Resolve syncing conflicts from repo_sync_working_branch to live

Pull request opened by OPS to resolve syncing conflicts from repo_sync_working_branch to live.

@huypub : Thanks for your contribution! The author, @mihart, has been notified to review your proposed change.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/powerbi-docs, working directory: W:\siyk-s, target branch: live, target branch commit: 2165c1d8481ed708a95c18240df1ee8356552183, source branch: repo_sync_working_branch, source branch commit: .
Learn more: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@huypub : Thanks for your contribution! The author, @mihart, has been notified to review your proposed change.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/powerbi-docs, working directory: W:\g4ig-s, target branch: live, target branch commit: 2165c1d8481ed708a95c18240df1ee8356552183, source branch: repo_sync_working_branch, source branch commit: .
Learn more: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@mgblythe : Thanks for your contribution! The author, @mihart, has been notified to review your proposed change.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/powerbi-docs, working directory: W:\mr4v-s, target branch: live, target branch commit: 2165c1d8481ed708a95c18240df1ee8356552183, source branch: repo_sync_working_branch, source branch commit: .
Learn more: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@huypub : Thanks for your contribution! The author, @mihart, has been notified to review your proposed change.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/powerbi-docs, working directory: W:\a2q3-s, target branch: live, target branch commit: 2165c1d8481ed708a95c18240df1ee8356552183, source branch: repo_sync_working_branch, source branch commit: .
Learn more: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@mgblythe : Thanks for your contribution! The author, @mihart, has been notified to review your proposed change.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

powerbi-docs/TOC.yml
:white_check_mark:Succeeded

powerbi-docs/consumer/TOC.yml
:white_check_mark:Succeeded

powerbi-docs/consumer/end-user-apps.md
:white_check_mark:Succeeded

powerbi-docs/consumer/end-user-basic-concepts.md
:white_check_mark:Succeeded

powerbi-docs/consumer/end-user-connect-to-services.md
:white_check_mark:Succeeded

powerbi-docs/consumer/end-user-consumer.md
:white_check_mark:Succeeded

powerbi-docs/consumer/end-user-dashboard-open.md
:white_check_mark:Succeeded

powerbi-docs/consumer/end-user-dashboards.md
:white_check_mark:Succeeded

powerbi-docs/consumer/end-user-experience.md
:white_check_mark:Succeeded

powerbi-docs/consumer/end-user-export-data.md
:white_check_mark:Succeeded

powerbi-docs/consumer/end-user-featured.md
:white_check_mark:Succeeded

powerbi-docs/consumer/end-user-q-and-a.md
:white_check_mark:Succeeded

powerbi-docs/consumer/end-user-reading-view.md
:white_check_mark:Succeeded

powerbi-docs/consumer/end-user-report-filter.md
:white_check_mark:Succeeded

powerbi-docs/consumer/end-user-report-open.md
:white_check_mark:Succeeded

powerbi-docs/consumer/end-user-show-data.md
:white_check_mark:Succeeded

powerbi-docs/consumer/end-user-tiles.md
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-apps/power-bi-apps-left-nav.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-apps/power-bi-apps-navbar.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-apps/power-bi-get-app.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-experience/power-bi-my-workspace.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-experience/power-bi-search.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-experience/power-bi-sort-new.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/amarillachart.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/filters.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/pagefilter3b.gif
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/pbi_changechartsort.gif
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/pbi_popouticon.jpg
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/power-bi-advanced-filter.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/power-bi-appsource.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/power-bi-dashboard.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/power-bi-dashboard2.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/power-bi-eraser-icon.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/power-bi-expan-filter.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/power-bi-filter-chain.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/power-bi-fit.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/power-bi-focus-icon.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/power-bi-full-screen.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/power-bi-get-app.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/power-bi-qna.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/power-bi-reading-filters.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/power-bi-report-fit.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/power-bi-report-opens.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/power-bi-report.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/power-bi-selection-pane-new.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/power-bi-selection-pane.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/power-bi-selection-pane2.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/power-bi-show-data.png
:white_check_mark:Succeeded

powerbi-docs/consumer/media/end-user-reading-view/power-bi-view-related-dashboard.png
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Enhance otPlatRadioTransmitDone() callback by passing up the ACK frame

This is a proposal to enhance otPlatRadioTransmitDone() callback by passing up the ACK frame as part of it.
Current otPlatRadioTransmitDone() callback only pass up the ACK's aFramPending information:
extern void otPlatRadioTransmitDone(otInstance *aInstance, RadioPacket *aPacket, bool aFramePending,
                                    ThreadError aError);

The new otPlatRadioTransmitDone() callback will pass up the whole ACK frame instead:
extern void otPlatRadioTransmitDone(otInstance *aInstance, RadioPacket *aPacket, RadioPacket *aAckPacket,
                                    ThreadError aError);

The benefits of the enhancement:

The ACK messages could also be used for link quality evaluation (short term);
To support the Enhanced ACK which may be used in some new features (long term).

Please give comments if you have any suggestions or concerns, thanks for that.

I think my biggest concern with this is that, we currently find ourselves running out of radio buffers during periods of heavy throughput.  Using a RadioPacket to report every ACK might further tax that resource.  Understand that the packet is received via an ISR but the RadioPacket is delivered via a task thread.  This means a pool of packets is needed so that the ISR can continue to function while the thread is delayed.

@pvanhorn, Thanks for sharing your concern.
Here we are talking about passing up ACK frame instead of a single aFramPending flag, there will be no changes to how radio receive packets, and no extra packets pool needed.
The radio could transmit only one packet at a time, it will not transmit the next packet until it receive the ACK or timeout. So only a single ACK packet will be used, but not a pool.

Your last point is a good one. I hadn't thought that through to completion. So we are fine as long as we later don't create a transmit queue in an effort to increase throughput.

Filed separate issues (#1839, #1840, #1841, #1842) for the remaining work on different platforms, so I think this issue could be closed.


Update docs

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (e474a36) to head (904bd73).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #82   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           12        12
  Lines          869       869
=========================================
  Hits           869       869

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Added support for using VS 2017 Build Tools

Added a path check for the standalone VS 2017 Build Tools

@csrakowski,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


Add the github/oauth2 service to Fonos release action

Is your feature request related to a problem? Please describe.
The oauth2 service is not being released with the rest of the services.
Describe the solution you'd like
We need to trigger the oauth2's release with the rest of the services.
Describe alternatives you've considered
None

We don't need this enhancement anymore, because the Oauth2 service has been deprecated.


Pull request / Tab Files - Toggle files by clicking on their header bar

When viewing the files list of a pull request,
it would be nice to be allowed to toggle any file by clicking on their "header bar" (bar that contains the filename, the checkbox [ ] Viewed and the 3-dots menu).
For instance on this page:
https://github.com/microsoft/TypeScript/pull/12114/files
This feature should appear on this kind of URL:
https://github.com/<owner>/<repository>/pull/<pr_id>/files

Not a bad idea. The hard part would be avoiding this behavior when clicking any other element on that bar.
Maybe
document.addEventListener('click', handleClick)
function handleClick(event) {
	if (event.target.matches('that bar’s selector')) {
		select('that toggle’s selector', event.target)!.click()
	}
}

I dug a little bit and I got something working (by playing in the DevTools so quick & dirty):
const listFiles = document.querySelector('#files');

listFiles.addEventListener('click', (event) => {

  const selectorHeaderBar = '.file-header.file-header--expandable';

  const elemClicked = event.target;
  const { parentElement } = elemClicked;
  const headerBar = parentElement.matches(selectorHeaderBar)
    ? parentElement
    : elemClicked;

  if (headerBar.matches(selectorHeaderBar) === false) {
    return
  }

  headerBar.querySelector('button').click();
});

@fregante I just sent a PR. Let me know if it fits how you work in your project.


Discussion: hot reload by overriding exported members?

Like capaj explains in https://github.com/capaj/jspm-hot-reloader/issues/17#issuecomment-160110062 the hot reloader currently also reloads all modules that use a module that is changed.
But is this really necessary? Could we for example override all exported members (functions / classes) with the members of the new version?
One thing that's probably tricky (if not impossible) are primary variables (numbers, strings etc).
Maybe we could implement "proxy's", like Dan Abramov explains in his talk: https://youtu.be/xsSnOQynTHs
This feature should improve editing stateless functions, like Redux reducers. Since in Redux reducers are used to create the store (state), because they define the initial state of their part, they can't be reloaded without also reloading the state.

@peteruithoven Exactly what i was thinking when I saw this code:
export default function configureStore(initialState) {
  const store = createStore(rootReducer, initialState)

  if (module.hot) {
    // Enable Webpack hot module replacement for reducers
    module.hot.accept('../reducers', () => {
      const nextReducer = require('../reducers')
      store.replaceReducer(nextReducer)
    })
  }

  return store
}

In the redux library, there is an example todoMVC app that has this code.
I would like to translate from webpack to jspm-hot-reloader. @capaj Do you think it is even possible?

@veggiemonk I am using jspm-hot-reloader mainly with observables. Yes, I am the devil @gaearon speaks about every time he mentions how bad one mutating state is.
I know redux, I haven't used it extensively but I don't really plan to support it more than other state management solutions.
It would be out of scope of what we are trying to do here. I might be open to support some plugins for this if the api is easy enough.

I wasn't suggesting making a exception for Redux, but I was asking whether the hot reloader could hot reload modules with stateless / pure functions without reloading all the modules that use that module.

same question here.
Other way to ask: How one can override the auto-reloading of all the module in the chain?
It would be like being to set hot reload rules for a few specific files. The main use cases so far is redux but more will follow, i think.

I've been thinking about this and read through the hot reloader code. I can't think of a way to override the references to exports of an old module a module has, without having access to that class.
But maybe, just like __unload is called, a __reload function could be called, for example here: https://github.com/capaj/jspm-hot-reloader/blob/master/jspm-hot-reloader.js#L185. (There are other places the original System.import() is called so that's probably not enough).
If we can keep a reference to the deleted version of that module we can pass that to the __reload module, a developer could then get the state from that old module and use that in the reloaded module to restore the state.
I'm not sure what kind of object System._loader.moduleRecords[normalizedName] returns, but there seem to be references to the moduleRecords of deleted modules in the modulesJustDeleted object.

@veggiemonk, would that enable that to do what you want?

@peteruithoven Thank you very much, I will give it try but the idea is quite neat...
I was thinking to approach the issue by saying 'if this file change, only reload this one'
but now it's more like: 'here is the data to persist across (any) reload' which is much more powerful.
Do you have any idea on:

how to extract the store from the old modules ?
how to inject the store into the new modules ?

The goal here would be to modify the code as little as possible in order to keep this a dev feature, meaning configurable so no extra dev code is shipped to production
I would love this to be just a parameter object that could be pass from config.js but that would be for the next iteration.

I found that there are also project that allow this to happen at the application code level (not as good as dev-server level)
https://github.com/AgentME/ud
With a working example by @mijime
https://github.com/mijime/mithril-redux-starter-hmr/blob/master/src/utils/redux-ud/index.js
But that is another, less preferable, approach to letting the server know how to save and inject state from old modules to new ones.

I've made a basic example and a probably flawed pull request: https://github.com/capaj/jspm-hot-reloader/pull/23

@peteruithoven so this was merged, I am closing this discussion for now.


nested hrefs not set as draft

Not sure if this is intentional, but if I have a nested hrefs in the docs stanza, it doesn't put the nested ones (e.g., note.html below) into draft-list.yml.
E.g.,
          docs:
            - type: "Lecture"
              id: "2"
              name: Pandas 1
              href: "./units/unit2.html"
            - type: "Participation"
              id: "2"
              name: Lecture Participation 2
              href: "./units/part.html"
              auxil:
                id: "Note 2"
                href: "./units/note.html"

Thanks for the issue and apologies that it's taken so long to respond (I didn't realize I hadn't been "watching" this repo).
This functionality wasn't intentionally disallowed, I just had conceived on this use case. Here are two different things that  should work:
# take 1
          docs:
            - type: "Lecture"
              id: "2"
              name: Pandas 1
              href: "./units/unit2.html"
            - type: "Participation"
              id: "2"
              name: Lecture Participation 2
              href: "./units/part.html"
           - type: "Note"
              id: "2"
              href: "./units/note.html"

# take 2
          docs:
            - type: "Lecture"
              id: "2"
              name: Pandas 1
              href: "./units/unit2.html"
            - type: "Participation"
              id: "2"
              name: Lecture Participation 2
              href: "./units/part.html"
              note: "Don't forget to participate!"

What exactly is the contents of Note? How would you like it to appear in the HTML? (I assume this structure is for ease of schedule formatting?)

Finally following up on this as I get back into trying to set up scheduled-docs functionality in our SCF/CDSS course-site-quarto template. This is not exactly the issue that was originally filed but I think it's close enough to make sense adding this here.
In that template, we have a schedule set up that mimics some of the DS courses, where each row in the schedule can have some optional auxiliary links (see [https://berkeley-cdss.github.io/course-site-quarto](this example)).
The underlying yml information looks like this, so there are nested hrefs (in the auxil stanza) that need date/draft keys.
scheduled-docs:
  draft-after: 8/24/24
  timezone: "-07:00"
  debug: true
  schedule:
    - week: 1
      days:
        - date: 8/23/24
          docs:
            - type: "Lecture"
              id: "1"
              name: Introduction
              href: "units/unit1.qmd"
              auxil:
                items:
                  - id: "Note 1"
                    href: "https://berkeley.edu"
                  - id: "Note 2"
                    href: "https://berkeley.edu"
            - type: "Participation"
              id: "1"
              name: Lecture Participation 1
              href: "https://berkeley.edu"

A few comments:

@andrewpbray What are your thoughts at the moment about a use case like this? Are you expecting this to work?
When I do this, it actually somewhat gives the behavior I want, namely setting up  date and draft keys for each auxil item. And it sets date and draft for the 'outer' docs as well. So I can use the resulting generated yml with my ejs template and it works fine. Great.
However, it injects some additional (duplicated) key-value pairs, into the nested structure in the generated schedule.yml like this:

- week: 1
  days:
    - date: 8/23/24
      docs:
        - type: Lecture
          id: '1'
          name: Introduction
          href: units/unit1.qmd
          auxil:
            items:
              - id: Note 1
                href: 'https://berkeley.edu'
                date: 8/23/24                            # GOOD
                type: Lecture                             # WHOOPS
                name: Introduction                  # WHOOPS
              - id: Note 2
                href: 'https://berkeley.edu'
                date: 8/23/24                              # GOOD
                type: Lecture                              # WHOOPS
                name: Introduction                  # WHOOPS
            date: 8/23/24                       # GOOD
            type: Lecture                        # WHOOPS
            id: '1'                                     # WHOOPS
            name: Introduction           # WHOOPS
            href: units/unit1.qmd       # WHOOPS
          date: 8/23/24                       # GOOD
          draft: false                            # GOOD
        - type: Participation
          id: '1'
          name: Lecture Participation 1
          href: 'https://berkeley.edu'
          date: 8/23/24
          draft: false

So it seems to propagate unexpected key-value pairs downwards. I'd be happy to help with fixing this if indeed this is something that should work and this is indeed a bug.

@andrewpbray and I discussed this. The propagation is intentional. A user can simply ignore the unneeded key-value pairs in the generated schedule.yml. (And indeed a user might not even realize they are created...)

Thanks for putting this note here. Another thing that informed this design choice: this is actually how Quarto works with metadata that is inherited either from a _metadata.yml stored in the subdir or the project-wide metadata stored in _quarto.yml. All the keys are propagated so that, when programming on an individual document (i.e. writing a lua filter), you have access to all of it. I've run into a few instances of keys that were not propagated due to some ... opinionated choices that were made in the design of the knitr package back in the day and it's been a serious bummer.

Here's an example where that propagation is handy:
    - week: 8
      unit: Generalization
      days:
        - topic: "Probability Workshop"
          display-date: Oct 14
          due-tomorrow:
            - Nothing!
        - topic: "Probability Distributions"
          display-date: Oct 15/16
          date: 10/15/24
          before-class:
            date: 10/11/24
            docs:
              - type: Notes
                href: 3-generalization/03-probability-dsns/notes.qmd
          in-class:
            docs:
              - type: Slides
                href: 3-generalization/03-probability-dsns/slides.qmd
              - type: WS
                href: 3-generalization/03-probability-dsns/ws.qmd

This allows me to write an ejs filter that produces on the course calendar:

At one point I was considering indicating on the calendar which unit we were in with color (coloring the squares a slightly different color). This would be possible because of the available of the unit: Generalization key on every daily topic item.
The propagation also helps with the date/draft mechanism. We always release the notes for Tues/Weds class on the previous Friday. That's reflected in yaml by adding an additional date under before-class. So any children docs of Probability Distributions will have date: 10/15/24 unless it's overwritten by a date key that appears as a more-recent ancestor.


[BUG] Data race due to mutable feature vectors being shared across thread boundaries when using concurrent segment search

What is the bug?
OpenSearch 2.12 stablised concurrent segment search which results in segments being search on different threads in parallel. The LTR plugin makes use of a MutableSupplier to share feature vectors between different parts of the code. For example in DerivedExpressionQuery and ScriptFeature. Due to the implementation being made using an atomic reference (https://github.com/opensearch-project/opensearch-learning-to-rank-base/commit/e34d607c73f3f5f539f92c437cd0b2e147be0419) this results in feature vectors potentially for different documents to be retrieved, resulting in the wrong feature scores and also data races.
How can one reproduce the bug?
Steps to reproduce the behavior.
What is the expected behavior?
A clear and concise description of what you expected to happen.
What is your host/environment?
Operating system, version.
Do you have any screenshots?
If applicable, add screenshots to help explain your problem.
Do you have any additional context?
The underlying issue seems to be that the vector is being shared across LeafReaderContext boundaries. If either a supplier was created one per LeafReaderContext or the feature vector sharing is kept unique for each LeafReaderContext then it should work as expected

Thanks @jhinch-at-atlassian-com.
@msfroh can you share any thoughts here?

Yeah... this comment looks like a bit of a smoking gun: https://github.com/opensearch-project/opensearch-learning-to-rank-base/blob/d3e1dd1e469f44bb50fec3c28919436a7704ea66/src/main/java/com/o19s/es/ltr/query/RankerQuery.java#L203-L206
Now that we are using the concurrent CollectorManager API, the predicted breakage came true.

@jhinch-at-atlassian-com -- Would you be able to develop and test a fix for this?
I think you're right that scoping the supplier to the given LeafCollector would work. Now that Lucene Weights can create a ScorerSupplier per LeafReaderContext, we should modify any custom weights to implement the scorerSupplier method (since I think the old scorer method was removed in Lucene 10? Or at least scorerSupplier is the preferred method now.) Any shared state should probably be scoped to the returned ScorerSupplier. That will also work if/when we upgrade to Lucene 10, which now support intra-segment concurrency -- so multiple ScorerSuppliers (and LeafCollectors) may be created for the same LeafReaderContext.

I had a brief exploration into fixing this. It looks like using a thread local is the most convenient fix. The thread local is created when the a new feature vector is created and cleared after the ranker score is computed. I will raise a PR with the candidate fix shortly


Alert: Adding CSS var

Is there some variables that need to go in Bs ? Or maybe I revert the changes that aren't done in Bs yet ?

There's a conflict that needs to be resolved.
Issue with Bundlewatch as well.

@louismaximepiton Some conflicts to resolve here 🙏


bug: appeal grant/revoke after the role is changed/removed from the provider config

Description
User (admin) can edit/remove roles from a provider at any time, and the previously created access with that role will lost the information of what are the permissions were in that role.
To Reproduce
Example 1: Approving appeal

Create a provider with a role viewer in the roles
Create an appeal to one of the resources with role=viewer
Edit the provider and remove that viewer role
Approve the appeal

Example 2: Revoking appeal

Create a provider with a role viewer in the roles
Create an appeal to one of the resources with role=viewer
Approve the appeal
Edit the provider and remove that viewer role
Revoke the appeal

Expected behavior
Granting/revoking access after the creation should be working regardless the changes in the provider (especially edit/remove changes in the roles)
Additional context

bigquery roles such as roles/bigquery.dataEditor and roles/bigquery.metadataEditor are called permissions in guardian
In guardian, user (admin) can define their own custom roles from the provider config. Let’s say one role named bigquery-admin and it has multiple permissions (bigquery roles) such as roles/bigquery.dataEditor and roles/bigquery.metadataEditor. So once user requested an appeal with bigquery-admin, they will get both permissions granted to the resource in the bigquery

Proposed solution
Need to store the list of permissions in the appeal object (probably a new field named "permissions") on the appeal creation. This permissions field will be used in the future for granting/revoking the access to the provider, regardless of the changes in the provider.

checklist

[ ] introduce permissions column in appeal
[ ] backfill permissions value for previous appeals (migration)
[ ] grant/revoke access based on the permissions field in appeal


use Docker Compose for development

Closes #226.
Hello! Was taking a look at the project, and noticed that there are a lot of different technologies required to set up the project. I figured this might be a big obstacle for people wanting to contribute to the project, so simplified the setup to use Docker Compose for running the various components.
I understand that this might add another layer of confusion for folks that aren't comfortable with Docker, so mostly putting this forward as a proposal. I also haven't used the setup much yet, so very possible that there's some wonkiness that needs to be worked out. Also, there could definitely be optimization, such as using smaller base images.
Let me know what you think!

Great work!

Hey @afeld, great job! I think you're right that the initial setup and administration of our dependent components is a little tedious. We also plan to containerize our production environment in the near future, so this is a good first step towards that. Thanks for your contribution!


Remove Cesium3DTileset.disableCollision in 1.116

From https://github.com/CesiumGS/cesium/pull/11829

Cesium3DTileset.disableCollision has been deprecated and will be removed in 1.116. Use Cesium3DTileset.enableCollision instead.

Closed in #11873


Typing in outline for notebooks reveal cells

focus a notebook cell
open quick outline
start typing
while typing happens a cell reveal, selected, and focused

https://user-images.githubusercontent.com/1794099/165517431-b36bc430-a7a8-4eac-8a85-f5306ff76678.mov

This happens via the revealing here. As soon as a cell that's not yet rendered is revealed it grabs focus via the CodeCell#updateEditorForFocusModeChange


fix: render "Mint NFT" btn

Fixes issue #170. See screencast

Thanks, great work!

Thanks, great work!


Migrations: Investigate API differences by porting existing migrations

Investigate what needs to be done to post existing migrations to EF7. This will help us build guidance and also identify any API changes that can be made to make the transition easier.

We are completely changing the API, and we've done API review. We will work on port guidance all up.


Broken links

Links are broken (404) on
https://docs.microsoft.com/azure/azure-sql/database/high-availability-sla#testing-application-fault-resiliency
Specifically the three links under the "REST API" column.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 15036ef6-9c0b-044e-d600-b9f90f039720
Version Independent ID: 6fe5cd14-a1ad-e183-a048-d72686abb969
Content: High availability - Azure SQL Database and SQL Managed Instance
Content Source: articles/azure-sql/database/high-availability-sla.md
Service: sql-db-mi
Sub-service: high-availability
GitHub Login: @emlisa
Microsoft Alias: emlisa

@rukasakurai Thank you for the feedback. We are actively investigating and will get back to you soon.

@emlisa We have raised the PR https://github.com/MicrosoftDocs/azure-docs-pr/pull/153141 for correcting this issue. Please check and verify and approve.

@emlisa Please check and verify the PR. We have assigned this to you.

Hi @rukasakurai , thanks so much for bringing this to our attention! It looks like the links are working as of today. I'll go ahead and close out this Git Issue but please feel free to comment should you need anything further.
Thanks again for reaching out and I hope you have a wonderful rest of your day!
Masha from the SQL Docs team
#please-close
#assign:MashaMSFT


run: Checksum artifacts with missing hashes

Summary
Ensure complete at least minimum hash sets for all build materials.
Signed-off-by: Adolfo García Veytia<EMAIL_ADDRESS>Last PR at the MM org.

I can't ask for you as a reviewer anymore @cpanato , take a look here, this PR introduces a feature to complete the build materials' hashes before running.


[test] Regenerate linuxmain after build-system-manager change

I had done an update early in the commit series, but forgot to do one at
the end.

@swift-ci please test


Refactor automatic zone generation

Uses a more efficient method which only keeps track of zones that are known to be unexplored the moment they were registered.

This creates an inconsistency with the v2 zone searcher and also invalidates the API: it is meant to display the total exploration progress, not just underground exploration progress.


Cascade on delete

I have some items (say Authors) and some things that link to these items (say Books), but if I delete a given Author, I'd like to delete all items that refer to this author, not to have broken links in the database (I think this corresponds for instance to cascade deletion in django).  Is it possible to do that automatically with Dexie.js (either theoretically or in practice)?

Dexie does not have any explicit foreign keys nor automatic cascade deletion. But it has ACID consistency so you can easily create a service method or function deleteAuthor() that deletes an author consistently:
function deleteAuthor(authorId) {
  return db.transaction('rw', db.books, db.authors, () => {
    db.books.where({authorId: authorId}).delete();
    db.authors.delete(authorId);
  });
}

Ok thanks. So I guess it is not planned?
My main issue with this solution is that I need to keep track of all such objects linked to a single author… (in my case there might be plenty) but I'm thinking that for my specific application it might make more sense to create a separate database for each "author", and put all objects related to this author in the same database, this way deleting a single database is trivial.
Also, sorry to hijack here, but since you mention transaction, I need to implement an undo mechanism in my app, does Dixiejs provide a simple way to keep track of all transactions to provide an efficient way to undo or redo a transaction?

Cascading deletes are only relevant in hierarchial structures. One useful pattern for this that I have been advocating for, is to use a parentPath property on the objects define the hierarchy. That way it is easier to move or delete entire subtrees in a single query. It's describe in the release notes of<EMAIL_ADDRESS>That pattern is even simpler if using a single table to store all the objects and let a type property distinguish type instead of the table, but it is also possible to use with multiple tables and - just that it need multiple queries (one per table) when deleting or moving.

I see, that would be great to have. Then we can maybe keep this issue and remove the question label?
Btw, I created another issue to discuss about undo here https://github.com/dexie/Dexie.js/issues/1933

Was also looking for a cascade on delete feature. I stumbled upon multiple solutions:

the old Table.hook('query-type') API

Pros: I don't know, and didn't test it
Cons: while not being deprecated, the documentation explicitly states that the more recent DBCore API is preferred

@dfahlander solution in his previous comment

Pros: easy to implement
Cons:

for multiple level relations (like "Items" having an FK to "Lists", having an FK to "Boards"), have to implement the whole CASCADE logic for each level of deletion (deleting a List should delete child Items first, and deleting a Board should also delete child Lists first, that have to delete their child Items first). This can get pretty heavy.

Using the parentPath pattern described in v4.0.1-beta.14 release notes

Pros: most modern way of achieving the desired cascade (?), with moving trees support
Cons:

have all items in a single table
for cross table relations, requires multiple queries, and all cascading FK to have a unique name ("parentPath" or so)
With the same previous example (Boards, Lists, Items), moving a list to another Board requires a single FK to be modified, but with the parentPath pattern, it requires the whole hierarchy to be altered.
Looks a bit complicated (maybe because I'm a Dexie noob)

Using Dexie.use() API.

Pros: have the logic implemented once at DBCore level, with conditions on DBCoreMutateRequest type and table names
Cons:

if all involved stores are not included in the original transaction, then I don't know how to include a transaction that should be validated at the same time than (or at least awaited before) the original query.

Maybe I missed a crucial point in the documentation. I was hyped by the Dexie.use() solution, but having to include all stores in deletion queries made me doubt.
May I have some guidance for the example I gave (Boards, Lists and Items in separate tables)? Am I wrong running away from a "mono table"?

Traditional cascading deletes can be implemented using DBCore as follows:

Create a DBCore middleware and override transaction and table
In transaction make sure to always include related tables whenever a 'readwrite' transaction is requested. For example if a readwrite transaction on 'organizations' is requested, also append the 'organizationUnits' table if those belong to organizations and may be deleted as a result of deleting an organization.
In table, call downlevelDatabase.table() and override mutate method before returning your clone.
In your version of the mutate method, start by querying all objects from related tables that reference the objects that are about to be deleted and check if another cascading delete operation needs to take place before actually performing the deletions. This has to be done recursively.

Some type of declaration of the foreign keys' properties and tables need to be declared if this shall be implemented generically. This declaration could for example be an argument to the middleware factory function.
The add-on dexie-relationships does not implement cascading deletes but it does a trick to override Dexie's schema declaration and invents its own syntax for declaring indexes representing foreign keys. Maybe this approach could be used also. That add-on is a bit old but the code is very small and it still works with dexie 4.


WIP: Resolve beam_fn_api experiment for side inputs, using portable expansion always

Do not review; it doesn't work yet!

The SDK now uses the portable expansion always
Runners override to restore pre-portable expansion as needed

Uploading to have an easy UI to browse diffs and kick off test suites

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

run dataflow validatesrunner

Just dropping references to #3303 and #4011 here since they have been important references to understand why things are the way they are, so I can close my browser tabs holding them open.

Managed to do this without the override back to legacy.


Add tests for process exit after server is bound

Add test that verifies #10084 is fixed

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,950,903      Total (=)      1,950,903

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,661,273      Total (>)     10,661,270

 No significant differences in binary sizes


ADP 2021-02-01-preview

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[x] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[x] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@aelij - As there are multiple new files in this PR, its difficult to identify the delta changes between old preview and new preview version. While adding new version the recommendation is to copy the existing version into new directory structure for first commit and then push new changes for easy review. Please create new branch with this recommendation for faster review.

@RamyasreeChakka I've created a PR as you suggested. Once it's merged, will rebase this one.
https://github.com/Azure/azure-rest-api-specs/pull/13099

@RamyasreeChakka Ramyasree Chakka FTE I've created a PR as you suggested. Once it's merged, will rebase this one.
#13099

@aelij - We can't check-in the 13099 PR as is as into a public repo. Please make the rest of the changes in next commits. While reviewing the PR, I will exclude the changes in first commit and review rest of the changes.

@RamyasreeChakka then there was no need for another branch :) I just added the commit and force-pushed this one.

@aelij Ah sorry, I directly merged it. Let me know whether this PR is planned to be merged now. If not, I will revert it, and prepare another PR.

@weidongxu-microsoft It's fine by me

@weidongxu-microsoft do you know why the ARM schemas PR (https://github.com/Azure/azure-resource-manager-schemas/pull/1320) contains only version 2020-07-01-preview and not 2021-02-01-preview?
The pipeline log indicates both were processed by autorest:
12:41:31.313 cmdout 	[Autorest] Processing batch task - {"tag":"package-2020-07-01-preview"} .
12:41:35.894 cmdout 	[Autorest] Processing batch task - {"tag":"package-2021-02-01-preview"} .

12:41:38.425 info 	2 changed files after SDK generate:
12:41:38.425 info 	M	schemas/2020-07-01-preview/Microsoft.AutonomousDevelopmentPlatform.json
12:41:38.425 info 	A	schemas/2021-02-01-preview/Microsoft.AutonomousDevelopmentPlatform.json

And running locally creates both files.


warnings not being displayed at all

Hi,
I just installed the plugin and tried the sample json file. None of the errors will be displayed. Even when I insert complete gibberish text and numbers, they will not be recognized as false input.
I tried let g:vim_json_warnings = 1 (which I assume is the standard value anyway, right?), but there is nothing.
I have also looked through the issues here and found somebody's manual snippet to add ti $MYVIMRC, which kinda worked: some errors would be displayed (incorrect colons/semicolons), but not things like this
{
hi mom
afwgwöjng
wef0ü
"something:" somethingles.132
}

this should all be wrong, but nothing got marked as incorrect; same for the sample.json, the errors there would not be marked in red.
What am I doing wrong?
I am using plugged as my plugin manager, use vim_airline and colorscheme onedark, if that is of any help. gvim --version ==> VIM - VI IMproved 8.1 (2018 May 18 compiled Mar 29 2019).
Thanks in advance for your help :)

I'm seeing the same thing with neovim:
:version
NVIM v0.3.8
Build type: Release
LuaJIT 2.1.0-beta3
Compilation: /usr/bin/cc -g -O2 -fdebug-prefix-map=/build/neovim-lpKDO8/neovim-0.3.8=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=1 -DDISABLE_LOG -Wdate-time -D_FORT
IFY_SOURCE=1 -Wconversion -O2 -DNDEBUG -DMIN_LOG_LEVEL=3 -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fdiagnostics-color=au
to -Wno-array-bounds -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -I/build/neovim-lpKDO8/neovim-0.3.8/build/config -I/build/neovim-lpKDO8/neovim-0.3.8/src
-I/usr/include -I/build/neovim-lpKDO8/neovim-0.3.8/build/src/nvim/auto -I/build/neovim-lpKDO8/neovim-0.3.8/build/include
Compiled by<EMAIL_ADDRESS>
Features: +acl +iconv -jemalloc +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/share/nvim"

Run :checkhealth for more info
Press ENTER or type command to continue

:version
NVIM v0.3.8
Build type: Release
LuaJIT 2.1.0-beta3
Compilation: /usr/bin/cc -g -O2 -fdebug-prefix-map=/build/neovim-lpKDO8/neovim-0.3.8=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=1 -DDISABLE_LOG -Wdate-time -D_FORT
IFY_SOURCE=1 -Wconversion -O2 -DNDEBUG -DMIN_LOG_LEVEL=3 -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fdiagnostics-color=au
to -Wno-array-bounds -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -I/build/neovim-lpKDO8/neovim-0.3.8/build/config -I/build/neovim-lpKDO8/neovim-0.3.8/src
-I/usr/include -I/build/neovim-lpKDO8/neovim-0.3.8/build/src/nvim/auto -I/build/neovim-lpKDO8/neovim-0.3.8/build/include
Compiled by<EMAIL_ADDRESS>
Features: +acl +iconv -jemalloc +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/share/nvim"

Run :checkhealth for more info
Press ENTER or type command to continue


Create Official Microsoft GitHub Action and Azure Pipeline task

There should be a first-class Bicep experience for GitHub Actions and Azure Pipelines. It should make it as easy as possible to build, test, and deploy a Bicep template.
Prerequisite: https://github.com/Azure/bicep/issues/858

Hey @MarcusFelling
Just wanted to chime in and say we're super excited about Bicep!  Myself and my comrades had the opportunity to talk to @alex-frankel and @anthony-c-martin yesterday; you're all doing some amazing work!  Having a first class experience for doing bicep in an Azure Pipeline is something we value highly.
Until that shimmers into being, is there advice on how we should be doing Bicep in pipelines?  We happened upon this:
https://thomasthornton.cloud/2021/02/22/deploy-azure-bicep-using-azure-devops-pipelines/
Does this seem like a reasonable approach?
cc @jamiemccrindle

I'd recommend using the Azure CLI task to deploy. As long as that task is updated to Az CLI version 2.20 or later, it will automatically install the bicep CLI when calling az deployment group create -f main.bicep.
There is an outstanding issue that may prevent this from working today, so you may need to wait until 3/23 to do this. @shenglol - will this issue affect both GitHub actions and DevOps YAML pipelines?

Until the official task ships, it's possible to do what @alex-frankel suggested around using the Azure task. I've written it up here:
https://blog.johnnyreilly.com/2021/03/20/bicep-meet-azure-pipelines

Just to chime in on this, we're trying to do bicep based deployments from GitHub Actions (so not Azure Pipelines), but haven't been successful thus far. The issue seems to be that the AZ CLI task in GitHub Actions (https://github.com/marketplace/actions/azure-cli-action) runs inside an Alpine based docker container. That contains musl libc, whereas the bicep binaries for linux are built against glibc.
Trying to run a bicep deployment from the AZ CLI task then results in errors like this:
ERROR: Error loading shared library ld-linux-x86-64.so.2: No such file or directory (needed by /root/.azure/bin/bicep)
Error relocating /root/.azure/bin/bicep: __isnanf: symbol not found
Error relocating /root/.azure/bin/bicep: sysctl: symbol not found
Error relocating /root/.azure/bin/bicep: __isnan: symbol not found
Error relocating /root/.azure/bin/bicep: __strdup: symbol not found

I've been able to fix the first error by doing some clever symbolic linking, but haven't been able to get passed the "symbol not found" errors...
So I agree, having a first-class bicep experience in GitHub actions would be nice :).

@KeesV FYI we had a known issue with Az CLI + Docker that has been resolved with Az CLI v2.21.0. More info in #1683
This is working for me now: https://github.com/alex-frankel/ignite-spring-21/blob/main/.github/workflows/jobs.yaml#L26

@alex-frankel thanks for the quick reply! I can confirm that with az 2.21.0 it now works as expected. My google-fu didn't lead me to #1683 , but that's exactly the issue we had indeed.
We tried running on az 2.21.0 yesterday already, but the bicep install resulted in a 404, so that's why we switched to 2.20.0. An unfortunate series of events... Thanks again!

Thanks for referencing my original blog post, original post was written < az 2.20.0.
Have updated the post with the relevant change, az bicep build
https://thomasthornton.cloud/2021/02/22/deploy-azure-bicep-using-azure-devops-pipelines/

GitHub Action also for reference
https://thomasthornton.cloud/2021/04/12/deploying-azure-bicep-using-github-actions/

Hi @MarcusFelling,
Loving the ability to use the az deployment group create -f main.bicep in Azure DevOps pipelines for simple deployments. We do however have a number of more complex deployments where we rely on the useful helper from the AzureResourceManagerTemplateDeployment task deploymentOutputs to push outputs from the templates into variables.
As a result we are currently building Bicep to ARM first and then using the task. It would be great to have Bicep support in the task for this :)

While workarounds are usable in a pinch, they're still workarounds. First-class, official support is not just a nicety. It's currently the biggest roadblock I've personally encountered to the adoption of Bicep. Developers will nod along and agree that the benefits of Bicep sound really good, and then backpedal and say that it is "too hard" when this issue comes up.

Agreed, we should prioritize ease of adoption. I've put some implementation notes under https://github.com/microsoft/azure-pipelines-tasks/issues/15337. I'll re-add the "needs triage" label so we discuss this in our next triage discussion.

Hi team,
sorry about raising this question again, is there any progress on getting Bicep Azure Pipeline task ready?
Looks like it is not coming with the 1.0 milestone, which is quite strange as the absence of the official task is biggest stopper from Bicep adoption.

Hi @rshariy -- can you clarify what is the blocking issue? We definitely are eager to update this task so that it supports Bicep files, but our understanding is that you can use the Az CLI task as an alternative for deploying bicep in a DevOps pipeline. Have you looked into this?

I can confirm what @alex-frankel suggest . You can use azure cli task and run az deployment command in it.

@alex-frankel, yes, I can do it, but the original goal was "There should be a first-class Bicep experience for GitHub Actions and Azure Pipelines. It should make it as easy as possible to build, test, and deploy a Bicep template."
Not Az CLI nor some third-party add-ons deliver the same simple experience as native task (comparing to the ARM template deployment task in Azure DevOps).

Support for the AzureResourceManagerTemplateDeployment@3 DevOps task was addressed with this issue: https://github.com/microsoft/azure-pipelines-tasks/issues/15337.
I'll close this issue - please use the above issue to track rollout status!


feat(behavior_velocity_run_out_module): exclude obstacle crossing ego…

Description
Add ego cut line to prevent rear pedestrians/bicycles from activating AEB. Cherry-pick of https://github.com/autowarefoundation/autoware.universe/pull/6680
Related links
Solves this Ticket:
https://tier4.atlassian.net/browse/RT0-33694 (evidence in ticket)
Parent Issue:

Link

How was this PR tested?
Psim and evaluator: https://evaluation.ci.tier4.jp/evaluation/reports/b065a943-eab7-544a-9782-bbd6e49c8e98?project_id=x2_dev
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

影響範囲が大きいのでドラフトに


Create Build Stage

As a developer
I need build stage on delivery pipeline
So that I can automize the build process with IBM Cloud Delivery Pipeline.
Details and Assumptions

We will be using IBM Cloud Delivery Pipeline.
This stage will contain Unit Test Job which will run our unit tests with nosetests.

Acceptance Criteria
Given [some context]
When [certain action is taken]
Then [the outcome of action is observed]

Build Stage is finished! We just need to automise the "Run automatically" option, but professor has to enable it.

Resolved! It should run automatically with every merge to the master!


Switch websocket library

This library currently uses the websocket crate. However the library looks kind of abandoned and might not be the best fit for future plans like async / await support. Currently the library provides async support based on tokio 0.1. This could lead to problems and there are no real plans to get the support running with websocket (see #242). It's also not to be expected that the library will provide support in case we have a problem, so switching the library might be a good idea. A battle proven implementation is provided by tungstenite-rs (async here, blocking here). What do you think @nshaaban-cPacket?

Sounds good, might be worth doing before the engineio crate goes public? I'm not interested in implementing the change in the near future (only if it causes headache with 0.5.0).

Alright, I could implement it as soon as refactoring is merged. Also a good point that this should be done before engine.io goes public, then I am not tied to a certain API.

Alright, I could implement it as soon as refactoring is merged. Also a good point that this should be done before engine.io goes public, then I am not tied to a certain API.

Doesn't necessary have to be before, but might make sense. Ideally what library we are using internally for websockes/polling would not be exposed anyways.

websocket is exposed here https://github.com/1c3t3a/rust-socketio/blob/9b1183b0313b52b82bb9e09f7c75f223cb9958ee/engineio/src/error.rs#L44
Plus we'll need the https://docs.rs/tungstenite/0.15.0/tungstenite/fn.client_tls_with_config.html to continue supporting passing in a TlsConnector

May want to escalate this @1c3t3a websocket (latest) depends on hyper 0.10.6 which is vulnerable to RUSTSEC-2021-0079 and RUSTSEC-2021-0078 (found using cargo-audit)

websocket crate is basically unmaintained now. Switching to tungstenite is recommended.

Does it make sense to release a new version of websocket crate that just points to (reexports) tungstenite and tokio-tungstenite, to prevent new accidental dependencies on the unmaintained code? Would benefits outweigh the harm? Currently websocket crate contains a warning in README:

Note: Maintainership of this project is slugglish. You may want to use tungstenite or tokio-tungstenite instead.

Have you missed it what you were shopping around for a Websocket library?

Hi @vi, first of all thanks for the quick help! We originally wanted to switch to tungstenite, but the problem is that the sync version of it is by far slower than websocket.

Observed significant performance degradation (25s minimum, peak of 75s) in the following case (client::socket::test::socket_io_integration):

Callback mode (where there is a separate thread constantly calling poll)
Attempt to send packets on the clone of the socket returned
Observe that websocket connection is busy reading
When a ping packet is received it is possible that the lock switches to the write
Socket finally sends a message

This is due to sync tungstenite not supporting the .split operation on their sender / receiver stream, something that websocket is capable of. The long time goal is definitely to switch to tokio-tungstenite (which is way faster), but we didn't make the switch yet, as this requires quite a lot of restructuring internally.
When I started the project about a year ago I didn't see the warning on web sockets Readme (I don't know if it wasn't there of if I just missed it), but the API seemed fine and the project was a bit more vivid then now.

This is due to sync tungstenite not supporting the .split operation on their sender / receiver stream

Note that rust-websockets support for splitting sync sockets is only reliable only for non-encrypted ws:// websockets. Maybe that's why sync tungstenite does not expose this function.
Splitting should work properly for async, including for wss://.

When I started the project about a year ago I didn't see the warning on web sockets Readme (I don't know if it wasn't there of if I just missed it)

It is more than a year ago: https://github.com/websockets-rs/rust-websocket/commit/b4f50dd7e18047bd085c8b9585cb6250ee2c7f7d

It is more than a year ago: websockets-rs/rust-websocket@b4f50dd

Then I missed it :D

This is due to sync tungstenite not supporting the .split operation on their sender / receiver stream

Note that rust-websockets support for splitting sync sockets is only reliable only for non-encrypted ws:// websockets. Maybe that's why sync tungstenite does not expose this function.
Splitting should work properly for async, including for wss://, both in rust-websocket and tokio-tungstenite.

Yeah that's true, but it still feels like this is taking away potential speed. But we might change this, @nshaaban-cPacket suggested to internally use async to speed things up, that might now be the best solution.

Yeah that's true, but it still feels like this is taking away potential speed. But we might change this, @nshaaban-cPacket suggested to internally use async to speed things up, that might now be the best solution.
Using async internally has it's drawbacks too, we'd have to use a tokio runner (term might be wrong) internally for method calls, which is far from ideal, not to mention also has a performance hit. We may be able to support roughly the same API in asnyc (as most of it is callback based anyways), would require more thought.

There is also async-tungstenite here, which is not bound to any specific async runtime.


Crashes constantly

Immediately after installing Bowser on my iPad from the App Store, I tried to navigate to the 'Artwork' link on the Bowser homepage that the app initializes to, and the app crashes. It then crashes immediately every time I open it. Restarting the iPad didn't help. Uninstalling/re-installing Bowser didn't help.
I've attached a few crash logs.
Bowser  11-23-15, 4-27 PM.txt
Bowser  11-23-15, 4-34 PM.txt
Bowser  11-23-15, 4-38 PM.txt

This has been fixed in 0.6 which was recently submitted for review to the App Store.
https://github.com/EricssonResearch/bowser/releases/tag/0.6


Replace deprecated panelUrl() method

panelUrl() is deprecated as of Kirby v3.7 which broke the plugin. This fix makes it work again.

Thank you @trych


data-attributes are being read with stale values

Hi I try invalid a select with differents values
this is a simple example..
$('#myForm').validator({
  custom: {
    invalidnumber: function ($el) {
      var number = $el.attr('data-invalidnumber')
      if ($el.val() == number) {
        return number + " is not a valid choice"
      }
    }
  }
})

$('#A').on('change', function (e) {
  var $el = $(e.target)
  $('#B').attr('data-invalidnumber', $el.val()).trigger('focusout')
})

and this is my html code

<form id="myForm" data-toggle="validator">

        Invalid Number
        <input id="A" type="number" class="form-control" required>

        Value

               <select class='form-control' name='sel_tesoreria'  data-invalidnumber="0"
                       id='B' required>
   <option value='0' selected='selected'>Seleccione tesoreria....</option>
                    </select>

        <button type="submit" class="btn btn-primary">Submit</button>

    </form>

so... I try with custom but... the form gets validate but I want invalid when select is 0
can someone help me?
btw @1000hz u are the man ,love this powerfull plugin...thanks a lot!.

this is the html

Invalid Number

Value
           <select class='form-control' name='sel_tesoreria'  data-invalidnumber="0"
                   id='B' required>

Seleccione tesoreria....

Submit

Thanks for the report. This is a bug. The problem is that the plugin uses $.fn.data(attr) to read values that are set as data attributes, but those stored values don't seem to get updated when the data attribute changes. The fix is to change the plugin to read the values using $.fn.attr('data-' + attr) instead so the values are read directly from the DOM.

I think this is not the correct solution. I'm running into the opposite problem: If I change the data using $el.data('foo', 'bar') this will not update the data- attribute, which means the validator will no longer pick up the new value.
Using the .data() function is the correct way to get and set data in jQuery - the original author here just needs to change his code to use .data() instead of .attr().

Hi @andrews05  man , You are very right, I didn't think about using .data(), works perfectly with first solution but with this is more logical and yes, i think is the correct solution.
what about the commit?,
->
https://github.com/1000hz/bootstrap-validator/commit/5d74c2200be7f9c5521bf2cbfd16a20f7a92e349

Hopefully @1000hz can revert it? (I think it's actually 469c48d)
Until then you can keep using v0.11.8 as I am, since .data() doesn't work in v0.11.9.

I'm using v0.11.9. because works perfectly with attr()... but , yes... he need revert it, it´s the best way.
I think you should open new Issue @andrews05 , maybe this notifiactions are invalid for him 'cause it's closed, I support your observation.

I'll probaby revert, but I have to spend some time catching back up with the project first.

Sure, thanks in advance :)


Add ledgerProofStatement to blockchain state in GraphQL

V2 of Blockchain_state.t has this field, it's not included in the GraphQL response.

Fixed in https://github.com/MinaProtocol/mina/pull/14483


Global keybinds isnt work

Already reported ? *

[X] I have searched the existing open and closed issues.

Regression?
Yes
System Info and Version
 System/Version info
Hyprland 0.46.2 built from branch  at commit 0bd541f2fd902dbfa04c3ea2ccf679395e316887  (version: bump to 0.46.2).
Date: Thu Dec 19 19:26:47 2024
Tag: v0.46.2, commits: 5566
built against:
 aquamarine 0.5.1
 hyprlang 0.6.0
 hyprutils 0.2.6
 hyprcursor 0.1.10
 hyprgraphics 0.1.1

flags set:
debug

System Information:
System name: Linux
Node name: arch
Release: 6.12.4-zen1-1-zen
Version: #1 ZEN SMP PREEMPT_DYNAMIC Mon, 09 Dec 2024 14:30:31 +0000

GPU information:
00:02.0 VGA compatible controller [0300]: Intel Corporation 3rd Gen Core processor Graphics Controller [8086:0166] (rev 09) (prog-if 00 [VGA controller])

os-release: NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo

plugins:
	unknown: not runtime

Description
Previously, global binds worked fine for me. There was a bind on Teamspeak. After the update, the bind stopped working. Teamspeak does not see the button pressed even if the window is active. And if the global bind is removed from the config, then Teamspeak will begin to see the button press, but only if the window is active
How to reproduce
in hyprland.conf
bind = , mouse:276, pass, ^(TeamSpeak 3)
and try to bind "mouse button 5" in teamspeak
Crash reports, logs, images, videos
No response

Yep, same for me on TeamSpeak 5

as above, that's not a valid window parameter

It used to work like this but the wiki wasn't updated, I sent a PR https://github.com/hyprwm/hyprland-wiki/pull/916


WIP: Build cross compile in CI

:+1:
On Mon, May 4, 2015 at 8:50 PM Victor Marmol<EMAIL_ADDRESS>wrote:

vmarmol wants to merge 1 commit into GoogleCloudPlatform:master from
vmarmol:build:
You can view, comment on, or merge this pull request online at:
https://github.com/GoogleCloudPlatform/kubernetes/pull/7754
Commit Summary

Build cross compile in CI

File Changes

M .travis.yml
https://github.com/GoogleCloudPlatform/kubernetes/pull/7754/files#diff-0
(2)

Patch Links:

https://github.com/GoogleCloudPlatform/kubernetes/pull/7754.patch
https://github.com/GoogleCloudPlatform/kubernetes/pull/7754.diff

—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/7754.

Argh, this is what I was worried about. We can't do the cross-compilation in Travis/Shippable. It is already run by the Jenkins e2e so maybe that'll be enough.
Closing


Updating 6-pubsub to use py.test

@waprin the only significant files here are test_end_to_end.py and the new environments in tox.ini.

Give me an L....L!
Give me a G....G!
Give me a T....T!
Give me an M...M!
LGTM!!!


Change JacksonEvent isNumeric to StringUtils.isNumeric

Description
Change to StringUtils.isNumeric
Issues Resolved
[List any issues this PR will resolve]
Check List

[x] New functionality includes testing.
[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #711 (b6b7123) into main (6d597af) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #711      +/-   ##
============================================
- Coverage     91.54%   91.53%   -0.02%
  Complexity      603      603
============================================
  Files            75       75
  Lines          1834     1831       -3
  Branches        152      153       +1
============================================
- Hits           1679     1676       -3
  Misses          117      117
  Partials         38       38

Impacted Files
Coverage Δ

...m/amazon/dataprepper/model/event/JacksonEvent.java
99.06% <100.00%> (-0.03%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d597af...b6b7123. Read the comment docs.


horizontal line

How can I draw horizontal line in this chart?
If I get two points and draw horizontal line, chart gets deformed, in general I would like to draw horizontal line.

You want to use the StraightLine component.
<StraightLine yValue={0} />


Parsing dates

I'm splitting the topic of dates out of issue #9 since it warrants its own discussion. @117 and I have discussed this somewhat, but I'm not sure we drew a conclusion.
Background
Alpaca provides dates as ISO-8601 strings. During transport, this is the ideal format since it is always in UTC and won't change as it travels across machines.
For users to actually use these dates, they need to convert to Date or use a library like date-fns, moment, etc. Should we save them this step and automatically convert the ISO-8601 strings to Date?
Considerations

Timezones are a common source of bugs. While the JavaScript Date internally stores the value as UTC, most methods present the date to you in the local machine's timezone. People tend to screw this up.

Alpaca has a mixture of date-time and date data. For dates, like in the Calendar entity, you get YYYY-MM-DD. We would not want to convert that as a Date since it does not represent a point in time, but rather a whole day. So if we decide to convert ISO-8601 strings to Date, but leave the YYYY-MM-DD strings alone, is that confusing to the user?

My opinion
I'm inclined to leave all dates alone and let the user decide how they want to work with them. I feel like they should see the dates in UTC so that they are forced to think about timezones. So ya... I opened an issue that I'm now arguing to close 😄
That being said, I would love to hear some other opinions.

I think it makes sense to parse ISO-8601 strings to a Date object. Those libraries can accept a Date object easily if the user doesn't want to work with the native Date class.
I also argue that YYYY-MM-DD is a point in time, just not on the same scale as an ISO-8601 string. A Date object for this does provide utility to the user, and makes it easy retrieve the day/month/year by calling a method without having to parse the string themself.

Regarding the YYYY-MM-DD strings... The bug I've seen several times is when someone converts that to a Date, it immediately becomes midnight on that day, in that machine's timezone. The problem is that midnight in New York is 9PM on the previous day in California.

Any further changes before 2.0 release? If not I'm going to go ahead and prepare the merge, double check things.

@117 I’d love to tackle the dates but I’m afraid I won’t have any time in the near future. If someone wants to go for it, it would be the same approach as the numbers. Otherwise, you can just cut the 2.0 release without it.

Okay I'm going to leave the YYYY-MM-DD strings as-is but add parsing (to UTC) for the full date strings. 😄


Remove Skype for Business Server 2019 from all the 'Applies To" sub-header/section.

Extensible Messaging and Presence Protocol (XMPP) proxy on the Edge Server and an XMPP Gateway on the Front End Server or Front End pool used to be available only on Lync Server 2013 and Skype for Business Server 2015, however, in Skype for Business Server 2019 this component is deprecated. The docs article is showing the cmdlet in this article is applicable to Skype for Business Server 2019 as well which is incorrect. It must be either removed under “Applies To” sub header / section or put an Note as below.
Note : The XMPP in Skype for Business 2019 is deprecated and this cmdlet is only applicable to Lync Server 2013 / Skype for Business Server 2015 pools/servers when you have the Co-Existence environment with Skype for Business 2019.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2ccc38b8-41d1-d412-b180-561d6fd51e93
Version Independent ID: d5702262-bd15-1ae5-422d-d399b5c2afda
Content: Get-CsXmppAllowedPartner (skype)
Content Source: skype/skype-ps/skype/Get-CsXmppAllowedPartner.md
Service: skypeforbusiness-powershell
GitHub Login: @kenwith
Microsoft Alias: kenwith

@NeeranjanShettar Thank you for this feedback
I will get this information to the PowerShell Team for investigation.
The team will get this prioritized into a sprint plan. Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

Do we have any updates here, it's been long time there are no updates/response. thanks in advance

@get-itips Could you please investigate this?


VGA 160x100 demo not working

I've tried the CGA16DMO.EXE file on real hardware (VGA cards) and emulators (Dosbox-X), and in both cases the screen stays in blank. It works fine with CGA and EGA video modes.

I just tested it under dosbox and it worked fine for me.  I've added my dosbox config file to the repo so you can try it.
dosbox-0.74-3.conf

What VGA card did you test this on?  I'm guessing it might be incorrectly detecting the video card if it isn't working.  The default choice is VGA, so it would be incorrectly detecting EGA or CGA instead.

I've tested with these VGA cards

Cirrus Logic GD-5422 ISA
Realtek RTG3105 ISA
Paradise PVGA-1A ISA

All of them had blank screen. The monitor reports 720x400 mode at 70hz with correct signal, but just all blank. I've tested also with latest version of Dosbox-X (vgaonly, also blank screen) and an older version of Dosbox (which shows fine the demo)

Can you attach your dosbox config file for the version that doesn't work?
What is the exact name and version number of the dosbox that doesn't work?

I have tested it on S3 Virge GX PCI, it showed black screen only.

I've got another ISA VGA card coming, I will test it.  I got a Compaq CGA card and the code works fine on a real CGA.  This also works on an Everex EGA card.  I've got a couple laptops with Cirrus 65xxx chips I can test on.


Data-preservation

requirements implemented 💯 💯

All data should be preserved by saving collections in .json files.
write code base to save all data and implement functionalities to preserve music albums data

STATUS: APPROVED! 🍾 🎆 🥇
Hi @fithamlak ,
You did a great job working on this milestone, your project is complete! 🚀
There is nothing else to say other than... it's time to merge it 🤖
Congratulations! 🎉

Highlights
✅ Great use of Git flow. 💯
✅ Your project is documented professionally. 📜
✅ Descriptive PR title, summary and commit messages. 💬
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


meta-mender-nxp: Support cubox-i and HummingBoard

These patches add Mender support for SolidRun HummingBoard and Cubox-i (Yocto/OE BSP machine name is cubox-i. To build an image follow the generic steps for nxp and add the following extra configuration, for example in local.conf to accept EULA:
# Accept end user agreement required by the BSP layer.
ACCEPT_FSL_EULA = "1"

I will add details about cubox-i to hub.mender.io.
Best regards,
Leon

Hi @leon-anavi, just one thing to check/confirm please. :-)

Thank you for the feedback and code review. I have forced pushed an updated version.
Thanks,
Leon

Hi @leon-anavi, just a minor comment, It would be nice to add the cubox-i in suported machines list (in [0] ;))
[0] - this list : https://github.com/mendersoftware/meta-mender-community/blob/d4c976b3da0b48c2efc2996f4e04d1a222dc3e5e/meta-mender-nxp/templates/local.conf.append#L3
Thanks,
/PJ

Hi @TheYoctoJester,
Thank you for the code review and accepting the pull request. As a follow up I will list cubox-i/HummingBoard in Mender Hub and update the README.md with a link and details.
Thanks, Leon


How about Auth?

Such as OAuth? or JSON Web Tokens

Hi @a11enwong,
I think the best way to deal with this right now would be to subclass Hyperdrive and modify requests inside constructRequest with your appropriate access token or authentication mechanism.
For example:
class Artsydrive: Hyperdrive {
  public override func constructRequest(uri: String, parameters: [String : AnyObject]?) -> RequestResult {
    return super.constructRequest(uri, parameters: parameters).map { request in
      request.setValue("Bearer X", forHTTPHeaderField: "Authorization")
      return request
    }
  }
}

As for performing your authorization flow to retrieve the access token. You would mostly have to do this yourself unless it is described via Hypermedia. It may make sense for us to make func request(request:NSURLRequest, completion:(RepresentorResult -> Void)) public so that you could use this for convenience.
I'd love to hear any feedback you have, I'd definitely be interested in seeing how we could improve Hyperdrive to supply a better API when it comes to authentication.

Thank you very much!

It would help if we could provide our own NSURLSession with the constructor of the Hyperdrive instance.
We could then set custom headers by using the configuration, or provide authentication logic by using a delegate on the session.


fix(ci): validate in container to satisfy glibc requirements

What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Since in the CI during validation we may build some plugins on the fly, we need to build inside the same container used for building the dev plugin artifacts so that the glibc requirements are met.
Which issue(s) this PR fixes:
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/close

LGTM label has been added.  Git tree hash: 71a60daafda90679af46ce79302adfd8fd34e8da

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jasondellaluce: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Make curry, curryN and nAry retain function name

Addresses #1678 (now closed) partially and #2780.

❯ node repl

> curry(function foo(x, y) { return x + y; });
[Function: foo]
> curry(function foo(x, y) { return x + y; })(1)
[Function: foo]

> curryN(2, function foo(x, y) { return x + y; })
[Function: foo]
> curryN(2, function foo(x, y) { return x + y; })(1)
[Function: foo]

> nAry(3, function foo(x, y) { return x + y; })
[Function: foo]

This PR conflicts with #2705,  #2611, #2605.

@GingerPlusPlus I wasn't aware of those. And they look like excellent additions (specially the removal of the placeholder)! However, while they do overlap with this in some areas, it appears to me that backporting your changes here wouldn't be difficult at all. In fact, including #2605 here would be like a good opportunity since it seems like the general stance on Object.defineProperty has change.

Worth considering, alongside #2605 and many others, post v1.0.


I translate your readme

in Korean

erm. this PR seems kinda strange to me. I don't think korean translations make sense for redmatic, sorry.


Merge development with master

Adds dupe checks to the bot.

Enable dupe checks by setting ENABLE_DUPE_CHECK to true. Default is false.
Minimum price for dupe check can be setting MINIMUM_KEYS_DUPE_CHECK to any amount in keys, both whole numbers and decimals. Default is 0.
Decline offers that contain any duped items by setting DECLINE_DUPES to true. Default is false.
If a dupe check fails then for received offers the offer will be skipped and a notification will be sent to the admins for them to review the offer, for sending offers the bot will stop and say that it failed to check for dupes.

If the bot fails to make a dupe check when creating an offer then the bot should tell the user to try and send an offer instead, that way an admin will be able to review the offer and accept / decline it.
How dupe checks work:

The bot attempts to get the history page of an item on backpack.tf. It will use the current assetid that the item has. If it fails then the dupe check will fail.
If backpack.tf knows about the item using the current assetid then the dupe check is done and the result will depend on if backpack.tf says it is duped or not.
If backpack.tf does not know about the item, then the bot will load the inventory using the TF2 GetPlayerItems API that backpack.tf also used to load inventories. The bot will load the inventory and find the original id. If the API does not give a good response, or the item could not be found in the inventory, then the dupe check fails.
The bot now has the original id and can then try and get the item history from backpack.tf using that. If it fails then we can conclude that backpack.tf doesn't know about the item, meaning that we don't know if the item is duped or not. The dupe check will fail. If backpack.tf does know about the item, then the dupe check is done.

THANK YOU SO MUCH NICK!


Flutter web canvaskit renderer release version not picking the images only on chrome

Flutter web is not picking images using image_picker under these conditions : canvaskit renderer - release version - chrome version : 108.0.5359.1249(currently latest) , but it is working on safari, opera and firefox.

Issue has been  resolved after updating to : Chrome Version 109.0.5414.87


Add documentation to support Forseti to work with CloudSQL instance with password

@joecheuk to add to documentation.


Access to the hazard indicator data

@joemoorhouse
Describe the bug
I am trying to run code using the following reference:
The URL of the endpoint to make the POST request to
url = "https://physrisk-api2-sandbox.apps.odh-cl1.apps.os-climate.org/api/get_hazard_data"

Expected behavior
Would expect it to run without errors
Screenshots
I am getting the following error message when running the code
requests.exceptions.JSONDecodeError: [Errno Expecting value] <!doctype html>

400 Bad Request
Bad Request
The browser (or proxy) sent a request that this server could not understand.
: 0
Additional context
I am not sure if I need access to the hazard indicator data in order to be able to run this. I read on the Physrisk Github that we are able to use the library on our local but that we would need access to the hazard indicator data. Would this be something that you will be able to give me access to.
I am also not able to access the following link: https://oauth-openshift.apps.odh-cl2.apps.os-climate.org/oauth/authorize?response_type=code&redirect_uri=https%3A%2F%2Fjupyterhub-odh-jupyterhub.apps.odh-cl2.apps.os-climate.org%2Fhub%2Foauth_callback&client_id=system%3Aserviceaccount%3Aodh-jupyterhub%3Ajupyterhub-hub&state=eyJzdGF0ZV9pZCI6ICI1M2IyNTdlMjJiNzM0NGQ2OWEwMzZiNzc1NzhkNzJmNCIsICJuZXh0X3VybCI6ICIvaHViLyJ9&scope=user%3Ainfo
Which may be linked to the access to the hazard data if I am correct.
Your assistance with this would be appreciated.
Kind regards,
Carina

Hi @Carina-vd-Merwe,
We discussed during the office hours, but to (belatedly!) put in the issue also. For getting example requests, the sandbox
https://physrisk-ui-sandbox.apps.odh-cl1.apps.os-climate.org/
and developer tools can be useful to get examples of the JSON to post (we need to publish the API also, a TODO).
e.g.
{"items":[{"request_item_id":"29fab225-cd8a-4b9d-ac73-1bd460861c0c","event_type":"ChronicHeat","longitudes":[10.47351095515998],"latitudes":[44.998215886074576],"year":2005,"scenario":"historical","indicator_id":"days_tas/above/25c","path":"chronic_heat/osc/v2/days_tas_above_25c_CNRM-CM6-1_{scenario}_{year}"}]}
I'm not sure if you were able to get access yet to the bucket credentials to run locally?
Thanks,
Joe

Good morning Joe,
I hope you are doing well.
Thank you for sending this through!
I haven’t received access to the bucket credentials yet to run it locally. They did send me a follow-up mail on Friday, confirming the repositories I would want to be added to. But I haven’t heard back from them since then. Unless I would not get a notification once I have received access, but earlier in the week when I checked, I did not have access yet.
Kind regards,
Carina
Quant Analyst – Quantitative Solutions
Mobile: +44 (0)79 7776 1196
<EMAIL_ADDRESS>Visit our Climate Risk page: Climate risk - Mazarshttps://www.mazars.co.uk/Home/Industries/Financial-Services/Banking-Capital-Markets/Climate-risk
@.***
From: Joe Moorhouse @.>
Sent: Tuesday, December 5, 2023 10:29 PM
To: os-climate/physrisk @.>
Cc: Carina Van Der Merwe @.>; Mention @.>
Subject: Re: [os-climate/physrisk] Access to the hazard indicator data (Issue #168)
Alert: This email was sent by an external party

Hi @Carina-vd-Merwehttps://github.com/Carina-vd-Merwe,
We discussed during the office hours, but to (belatedly!) put in the issue also. For getting example requests, the sandbox
https://physrisk-ui-sandbox.apps.odh-cl1.apps.os-climate.org/https://physrisk-ui-sandbox.apps.odh-cl1.apps.os-climate.org/
and developer tools can be useful to get examples of the JSON to post (we need to publish the API also, a TODO).
e.g.
{"items":[{"request_item_id":"29fab225-cd8a-4b9d-ac73-1bd460861c0c","event_type":"ChronicHeat","longitudes":[10.47351095515998],"latitudes":[44.998215886074576],"year":2005,"scenario":"historical","indicator_id":"days_tas/above/25c","path":"chronic_heat/osc/v2/days_tas_above_25c_CNRM-CM6-1_{scenario}_{year}"}]}
I'm not sure if you were able to get access yet to the bucket credentials to run locally?
Thanks,
Joe
—
Reply to this email directly, view it on GitHubhttps://github.com/os-climate/physrisk/issues/168#issuecomment-1841729147, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BDNNI5XCPUSO6W6M5EKQQWLYH6N4JAVCNFSM6AAAAAA7WANT5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBRG4ZDSMJUG4.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>We’d love to hear your views on working with us here: https://www.mazars.co.uk/feedback
Mazars LLP is the UK firm of Mazars, an integrated international advisory and accountancy organisation. Mazars LLP is a limited liability partnership registered in England and Wales with registered number OC308299 and with its registered office at 30 Old Bailey, London, EC4M 7AU.
Details about our audit registration can be viewed on the Register of Statutory Auditors’ website, under reference number C001139861.
Mazars Financial Planning Limited and Mazars Corporate Finance Limited are both registered in England and Wales with Nos. 3172233 and 4252262 respectively. Both companies are wholly owned subsidiaries of Mazars LLP, are authorised and regulated by the Financial Conduct Authority and have their registered offices at: 30 Old Bailey, London, EC4M 7AU.
This email and any attachments are confidential and may also be subject to legal privilege. If you are not the intended recipient, please notify the sender immediately, and do not disclose the contents to another person, use it for any purpose, store or copy the information in any medium. Please also destroy and delete the message from your computer.
If you currently receive marketing communications from us and no longer wish to do so, please email @.*** confirming your choice to unsubscribe.


It doesn't work

The index.js:
var mNames = ['一月', '二月', '三月', '四月', '五月', '六月', '七月', '八月', '九月', '十月', '十一月', '十二月', ''];

module.exports = mNames;

The webpack.js:
var path = require('path');
module.exports = {
    entry: [
        './app/index'
    ],
    output: {
        path: path.join(__dirname, 'dist'),
        filename: 'app.js',
        chunkFilename: '[chunkhash].js',
        publicPath: '/'
    },
    module: {
        loaders: [
            {
                test: /\.js$/,
                loader: 'unicode-loader',
            }
        ]
    }
};

The packaged file:
!function(r){function t(e){if(o[e])return o[e].exports;var n=o[e]={exports:{},id:e,loaded:!1};return r[e].call(n.exports,n,n.exports,t),n.loaded=!0,n.exports}var o={};return t.m=r,t.c=o,t.p="/",t(0)}([function(r,t,o){r.exports=o(1)},function(r,t){var o=["一月","二月","三月","四月","五月","六月","七月","八月","九月","十月","十一月","十二月",""];r.exports=o}]);

You can get the right content without uglify.
Now the uglify convert the '\u4e00\u6708' to '一月'.
So you should add a parameter for uglify : --beautify "beautify=false,ascii-only=true"
Then you can get the right string.
But I don't know how to pass this parameter in webpack to uglify.

If some other issues, contact me.

I found a way to config it on the official website.
'UglifyJS options:
...
output: an object providing options for UglifyJS’ OutputStream - see the OutputStream source for options and defaults.'
new webpack.optimize.UglifyJsPlugin({
    compress: {
        warnings: false
    },
    output: {
        ascii_only: true,
        beautify: false
    }
})

But there seems to be a bug. Options.output doesn't work. I debugged it and found the ‘UglifyJsPlugin’ function(source) has been called twice on each file. The first result could be covered with the second

I have read the UglifyPlugin source code, and I didn't found how to pass this kind of options.
And I have reported a bug to uglify, but they can not understand me.
You could report another one :)

Now my way to resolve it: First only do webpack. then call the uglify in command lline to do this.
Command line is correct, run it in node.

How did the problem finally be solved


Unable to parse version of Conda, 23.1.0.post7+d5281f611

Type: Bug

Behaviour
Expected vs. Actual
vscode doesn't appear to be able to deal with development versions of conda (installed directly from git)
Steps to reproduce:

git clone ssh<EMAIL_ADDRESS>. dev/start -p 3.10
(set vscode conda path to ./devenv/.../bin/conda)
try to discover pytest tests
note error

Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): 3.9.16
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Conda
Value of the python.languageServer setting: Pylance

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

XXX

User Settings

condaPath: "<placeholder>"

languageServer: "Pylance"

formatting
• provider: "black"
• blackPath: "<placeholder>"

testing
• pytestArgs: "<placeholder>"
• pytestEnabled: true

Extension version: 2022.20.2
VS Code version: Code 1.74.3 (Universal) (97dec172d3256f8ca4bfb2143f3f76b503ca0534, 2023-01-09T17:07:18.579Z)
OS version: Darwin arm64 21.6.0
Modes:
Sandboxed: Yes

System Info

Item
Value

CPUs
Apple M1 Pro (10 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
22, 16, 11

Memory (System)
16.00GB (0.08GB free)

Process Argv
. --crash-reporter-id e18e76d9-d573-4f56-8c99-77786b05ef14

Screen Reader
no

VM
0%

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscoreces:30445986
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
vscccc:30610679
pyindex848:30577860
nodejswelcome1cf:30587006
282f8724:30602487
pyind779:30647091
f6dab269:30613381
2i9eh265:30646982
vscsb:30628654

Hello! I am looking into this now- in the meantime can you provide the full error message you see? Thanks!

In Output > Python:
LSP Notebooks experiment is enabled
LSP Notebooks interactive window support is enabled
Python interpreter path: ./devenv/Darwin/arm64/envs/devenv-3.10-c/bin/python
> ./devenv/Darwin/arm64/envs/devenv-3.10-c/bin/conda info --json
Starting Pylance language server.
[ERROR 2023-0-25 14:51:46.885]: Unable to parse version of Conda, 23.1.0.post89+a02bccf45
Send text to terminal: source /Users/dholth/prog/conda/devenv/Darwin/arm64/envs/devenv-3.10-c/bin/activate /Users/dholth/prog/conda/devenv/Darwin/arm64/envs/devenv-3.10-c

@brettcannon wanted to loop you into this discussion to get your opinion on this issue. Currently conda has its dev versioning in the format 23.1.0.post89+a02bccf45 but semver does not support that formatting and instead expects 23.1.0-post89+a02bccf45. As reference we use this library for parsing: https://github.com/npm/node-semver and here are the general docs https://semver.org/. Therefore we are unable to parse the version in the python extension and return null (the root of the issue this ticket is referring to). What are your thoughts on the next best option? If the semver fails then have a fallback? @dholth if you have any opinions as well as someone who uses dev version of conda please let us know. Thanks!

Personally I would take the first two, or possibly 3 digits "23.1.0" and ignore the rest. We are using calver, producing a new minor release every two months. There's no way vscode cares about which post version is in use..
We will be using this version scheme. https://peps.python.org/pep-0440/#version-scheme

I have already filled in @eleanorjboyd offline on how to parse this specific versioning scheme appropriately for our needs.

Hello @dholth! This issue has been fixed in the latest version of VS Code insiders. Could you install the latest version of VS Code insiders and the Python extension to give it a try and see if it is fixed for you? Thanks!

Closing as it seems it's fixed.


Containerd

What does this PR do?
Introduce the containerd native check

[x] add a util to interface with the containerd API (socket based)
[x] logic to support the CRI check as well
[x] logic to collect events from containerd
[x] tests
[x] tested in staging

Motivation
On top of the prometheus output, get more visibility from containerd

Codecov Report

Merging #2831 into master will decrease coverage by 0.28%.
The diff coverage is 27.2%.

@@            Coverage Diff             @@
##           master    #2831      +/-   ##
==========================================
- Coverage   57.06%   56.78%   -0.29%
==========================================
  Files         387      389       +2
  Lines       24805    25239     +434
==========================================
+ Hits        14155    14331     +176
- Misses       9714     9960     +246
- Partials      936      948      +12

Impacted Files
Coverage Δ

pkg/collector/corechecks/containers/containerd.go
22.74% <22.74%> (ø)

...llector/corechecks/containers/containerd_events.go
31.73% <31.73%> (ø)

pkg/forwarder/transaction.go
82.9% <0%> (-2.57%)
:arrow_down:

pkg/logs/input/listener/tailer.go
90% <0%> (+4%)
:arrow_up:

pkg/collector/py/datadog_agent.go
55.94% <0%> (+6.41%)
:arrow_up:

pkg/collector/runner/runner.go
67.01% <0%> (+14.38%)
:arrow_up:

We will also need to honor the container filtering settings, for both metrics and events (when linked to a container). Is that something we can target for the first merge, or in a follow-up PR?