const enum & namespace merged error

TypeScript Version:  3.2.0-dev.201xxxxx

Search Terms:
Code
const enum Weekday {
    Monday,
    Tuesday,
    Wednesday,
    Thursday,
    Friday,
    Saturday,
    Sunday
}
namespace Weekday {
    export function isBusinessDay(day: Weekday) {
        switch (day) {
            case Weekday.Saturday:
            case Weekday.Sunday:
                return false;
            default:
                return true;
        }
    }
}

export default Weekday;

Expected behavior:
no errors.
Actual behavior:
got an error "Enum declarations can only merge with namespace or other enum declarations."
Playground Link:
https://www.typescriptlang.org/play/index.html#src=const enum Weekday {
    Monday%2C
    Tuesday%2C
    Wednesday%2C
    Thursday%2C
    Friday%2C
    Saturday%2C
    Sunday
}
namespace Weekday {
    export function isBusinessDay(day%3A Weekday) {
        switch (day) {
            case Weekday.Saturday%3A
            case Weekday.Sunday%3A
                return false%3B
            default%3A
                return true%3B
        }
    }
}

export default Weekday%3B

Related Issues:
https://github.com/Microsoft/TypeScript/issues/16804
I just found the realated issues, but no solution for me. I can't understand why this is not a bug. The playground shows what I expected in compilation.
I hope not to report an error, while the compilation result is exactly what I want.

Definitely a duplicate of the linked #16804, which got marked as a duplicate of the later #17372.


Reproducer for HHH-15606 @OneToOne(mappedBy = ..., fetch = LAZY) in embedded leads to IllegalArgumentException: Can not set [...] to LazyPropertyInitializer$1

https://hibernate.atlassian.net/browse/HHH-15606
Just a reproducer, no fix at the moment.

superseded by https://github.com/hibernate/hibernate-orm/pull/5586
Thanks @yrodiere for the test!


Trait error

When i update bootstrap3 plugin and edit names from Bootstrap3 to Bootstrap. I got this error.
Error: Trait 'Bootstrap3\View\Helper\BootstrapTrait' not found
File pathToProject\vendor\holt59\cakephp3-bootstrap3-helpers\src\View\Helper\BootstrapHtmlHelper.php
Line: 29
But BootstrapTrait is in same  namespace, i do see reason for not working. (Sorry for my english)

The plugin path seems incorrect (bootstrap3 instead of bootstrap). If you are using composer, could you try completely removing the plugin and reinstalling it?
composer remove holt59/cakephp3-bootstrap3-helpers
composer require holt59/cakephp3-bootstrap-helpers:~3.0

Yeah,  now its working. Thank you very much. :)


does ui-router-extras work with angular-ui ui-router 0.3.x ?

Noticed that ui-router-extras bower.json requires an older version of angular-ui-router:
1) angular-ui-router#^0.2.8 which resolved to 0.2.18 and is required by ui-router-extras#0.1.3
and in ui-router-extras' bower.json :
"dependencies": {
    "angular": "^1.2.0",
    "angular-ui-router": "^0.2.8"
 },

Is this on purpose or does the bower.json simply need to be updated ?
thanks for all the hard work !

Bower json needs updating!

Need to update bower json to latest version of angularjs (angular 1.6.2) and angular-ui-router 0.4.2


Catalog: Make Catalog Table Headers Customizable

Catalog table column headers are hard coded currently in the open source Backstage. If we want to make changes to these to align better with our companies metadata, we have to make changes in our copy of the open source catalog, which we want to avoid. So our request is to do the work of making these customizable and contributing it back to Backstage.
Feature Suggestion
Once approved, I can do the work for this feature request.
Possible Implementation
Our idea to implement this is to follow a similar pattern found in this PR, minus the routing changes.
Context
We are trying to accomplish making Backstage more customizable. This will allow us to customize the catalog table to match with different companies metadata, without having to change the code inside the plugin

+1
Would you like me to assign you?

Yes please Stefan!

+1
Also something we could use :)

I think you should try to make sure it will be compatible with https://github.com/backstage/backstage/issues/3274, so you can also filter based on the headers :-)

@tradcliffe-expediagroup heads up that https://github.com/backstage/backstage/issues/3414 may affect this work. It may make it more straight-forward to implement but could also add some additional requirements. If unsure you could sync and discuss ideas in this issue or in a draft PR.

Thank you @JacobValdemar and @Rugvip. I will take a look at both of these PRs and let you know if I have any questions. Thank you!


pkg/guestagent/iptables: recognize Kubernetes NodePorts

I guess we need to adjust the regexp here to support kube NodePorts ?
https://github.com/lima-vm/lima/blob/4edd35381c48e33721f54868d75408a4e6b41c8c/pkg/guestagent/iptables/iptables.go#L20-L34

Originally posted by @AkihiroSuda in https://github.com/lima-vm/lima/discussions/1018#discussioncomment-3405760

copy last comment here
@AkihiroSuda may be. I use kubernetes 1.24 and in uses nftables for forwarding not iptables
In nft ruleset it looks like:

iptables cannot see nft rules

For the k8s example it seems to work, they are shown with the usual iptables ?
anders@lima-k8s:~$ sudo kubectl get svc
NAME              TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)          AGE
hello-minikube1   NodePort    <IP_ADDRESS>   <none>        8080:31605/TCP   73s
kubernetes        ClusterIP   <IP_ADDRESS>       <none>        443/TCP          6h2m
anders@lima-k8s:~$ sudo iptables -t nat -S | grep 31605
-A KUBE-NODEPORTS -p tcp -m comment --comment "default/hello-minikube1" -m tcp --dport 31605 -j KUBE-EXT-IUOMQFLPVEEG3DF5

Simple echoserver as per https://minikube.sigs.k8s.io/docs/handbook/accessing/

One would have to dig a bit to get to the actual DNAT, since it uses the Cluster IP.
-A KUBE-NODEPORTS -p tcp -m comment --comment "default/hello-minikube1" -m tcp --dport 31605 -j KUBE-EXT-IUOMQFLPVEEG3DF5
-A KUBE-EXT-IUOMQFLPVEEG3DF5 -j KUBE-SVC-IUOMQFLPVEEG3DF5
-A KUBE-SVC-IUOMQFLPVEEG3DF5 ! -s <IP_ADDRESS>/16 -d <IP_ADDRESS>/32 -p tcp -m comment --comment "default/hello-minikube1 cluster IP" -m tcp --dport 8080 -j KUBE-MARK-MASQ
-A KUBE-SEP-KONAZYSBK4GHAOZH -p tcp -m comment --comment "default/hello-minikube1" -m tcp -j DNAT --to-destination <IP_ADDRESS>:8080
iptables v1.8.7 (nf_tables)

FWIW, we are planning to implement a component for Rancher Desktop to use the apiserver endpoint to watch for service port changes, and then forward them accordingly. This feels more robust than updating parsing rules for iptables and nftables to reverse engineer the modified ports.
This will only work for k8s, so the existing iptables parsing needs to stay to handle containerd port usage without k8s.
We can put this code into lima as well (once it exists), but I'm not sure if lima should include code talking to the apiserver (I think that will be fine, but it would be an extension of scope).

We can put this code into lima as well (once it exists),

SGTM

We can put this code into lima as well (once it exists),

Looks like it was already written while I was on vacation: https://github.com/rancher-sandbox/rancher-desktop-agent/tree/main/pkg/kube 😄
It just creates a corresponding listener on <IP_ADDRESS>, so the regular lima port forwarding will pick it up (same thing kubernetes used to do before).
Still need to figure out how it should be integrated into Lima.

This feels more robust than updating parsing rules for iptables and nftables to reverse engineer the modified ports.

Upstream kubernetes seems to agree on that, too: https://kubernetes.io/blog/2022/09/07/iptables-chains-not-api/

Has the plan been decided? maybe I can work for it

Temporary solution:  exec nc -l localhost 31313 in lima-vm

iptables -t nat -vnL KUBE-NODEPORTS| awk '/dpt/ {print $NF}' | cut -c 5-9
Can we watch the iptables to open a listener for the nodePort?


AttributeError: type object 'pyzed.sl.Translation' has no attribute 'dot_translation'

Getting this error while running the ZED sample python program on Jetson AGX Xavier
python3 positional_tracking.py
Traceback (most recent call last):
File "positional_tracking.py", line 50, in
viewer = gl.GLViewer()
File "ZED/zed-examples-master/positional-tracking/python/ogl_viewer/tracking_viewer.py", line 162, in init
self.camera = CameraGL()
File "ZED/zed-examples-master/positional-tracking/python/ogl_viewer/tracking_viewer.py", line 476, in init
self.setDirection(tmp, tmp2)
File "ZED/zed-examples-master/positional-tracking/python/ogl_viewer/tracking_viewer.py", line 528, in setDirection
if(sl.Translation.dot_translation(self.vertical_, self.up_) < 0.):
AttributeError: type object 'pyzed.sl.Translation' has no attribute 'dot_translation'
Platform: Jetson AGX Xavier,
Jetpack 4.4
ZED SDK 3.3

Hi @Shishir-Kumar-Singh,
The sample you launched uses a function that is not implemented in the SDK version you downloaded.
Can you try again with the SDK 3.4.0 RC1, available here : https://community.stereolabs.com/t/zed-sdk-3-4-0-release-candidate/58

Hi @Shishir-Kumar-Singh,
The sample you launched uses a function that is not implemented in the SDK version you downloaded.
Can you try again with the SDK 3.4.0 RC1, available here : https://community.stereolabs.com/t/zed-sdk-3-4-0-release-candidate/58

Thanks for the suggestion. It worked for me after installing 3.4.0 version.

Thanks for the suggestion. It worked for me after installing 3.4.0 version.


Docs for SET rollback in txn limitation

Closes #12169
Docs added for known limitation page 21.2 & SET page on SET not properly rolling back during a transaction.

This change is


Index Signature could be improved (for ... in, if ... in operators)

I've read the FAQs but I didn't find anything similar to what I'm requesting...
When trying to access an object property using a string as index we get the error

Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'MyType'

But...

Checking if the key is a property of the object with if(key in obj) should be enough to use it as index but eslint and tsc give me an error about missing index signature.

Iterating the keys with a for(let key in obj) loop should make sure that key is a key of obj but even in this case I can't use it as an index without an index signature. The problem here is that the type of key is inferred as string and not as keyof MyType that would be better.

So my opinion is that the following code should be allowed (even with noImplicitAny=true):
type MyType = {
  name: string
  id: number
}

const foo = (key: string, item: MyType) => {
  if(key in item) {
    console.log(item[key])
  }
  for(let k in item) {
    console.log(item[k])
  }
}

Duplicate of #35847.

Duplicate of #35847.
Ok so the for in "works as intended" but what about if(key in obj) ?

#21732

I'm not sure that anything correct would be useful to you. For some s, even if s in obj, obj[s] is necessarily of type unknown. Inferring keyof MyType would be wrong; see https://stackoverflow.com/questions/55012174/why-doesnt-object-keys-return-a-keyof-type-in-typescript

Ok, I get the point, I thought the error was that I can't use the property as index for that object but the real problem is that the type cannot be inferred, so it is considered an "implicit any" (in fact it isn't an error with noImplicitAny option set to false).
Thanks for the answer, I'm closing the issue cause everything works fine! 👍


gs.getUser().getID() and other functions not being passed properly?

I have wrote a script include class called UserObject where we are checking different attributes about the user.
When I pass the following code to Xplore I get false and we expect it to be true
var project = "1ac9ec1f8dfd10107f61449ff67c8fb4";
var operation = "read";
var permissions_column = "ports_protocols_services";

var userObject = new x_snc_authorizatio.UserObject(gs.getUser().getID());
userObject.isUserAuthorized(project, operation, permissions_column).stakeholder();

When I pass the same code to Background Script i get true
When I hardcode gs.getUser().getID() I get true
var project = "1ac9ec1f8dfd10107f61449ff67c8fb4";
var operation = "read";
var permissions_column = "ports_protocols_services";
var user_id = "3a98e903810d50107f612b41b4439bef";

var userObject = new x_snc_authorizatio.UserObject(user_id);
userObject.isUserAuthorized(project, operation, permissions_column).stakeholder();

Seems like gs.getUser() is getting passed weird to the server side, or it is getting passed to a script include weird.

Another weird part is this:
When I call
var project = "1ac9ec1f8dfd10107f61449ff67c8fb4";
var operation = "read";
var permissions_column = "ports_protocols_services";

var userObject = new x_snc_authorizatio.UserObject("3a98e903810d50107f612b41b4439bef");
userObject.userId

it ouputs
Type | JavaObject
-- | --
"3a98e903810d50107f612b41b4439bef"

and it has exactly the same output for
var project = "1ac9ec1f8dfd10107f61449ff67c8fb4";
var operation = "read";
var permissions_column = "ports_protocols_services";

var userObject = new x_snc_authorizatio.UserObject(gs.getUser().getID());
userObject.userId

I believe I may have found the issue. When running gs.info(typeof(userObject.userId)); in the Background Script is shows it as a string. When I run the same thing in Xplore it comes back as an Object.

Hi Kyle,
I've tested and Xplore appears to be fine.
Closing as not able to reproduce with the following similar test.
function Auth(user_id) {
  this.user_id = user_id;
}

Auth.prototype.isOK = function () {
  return !!this.user_id;
}

var obj = new Auth(gs.getUser().getID())
obj.isOK()

FYI, shorthand for gs.getUser().getID() is gs.getUserID().
Thanks,
James

It would be nice to have a discussion about this. It seems like everything from xplore returns as an object rather than it’d actual type. For example, if I don’t get getDisplayValue on a glide record field value it will return “{}”.

What version of Xplore are you using? In 4.7 GlideElement objects are printed correctly with the values showing.

Hey Kyle, your beef is with the way dynamic weak typing (JavaScript) interfaces with static strong typing (Java) in SN's setup, not Xplore itself. You can't really expect JS to be consistent with metadata, there are no types, just primitives.  In your example, field accessing should always be done through a function ie getValue() to ensure consistency


[ Line Chart ] Monotone cubic interpolation

First, thanks for all the good work.
I just started using Charts.js (have tinkered a bit with line charts so far), and it seems the cubic interpolation used does not preserves monotonicity of the provided data (which makes sense, because said algorithm is very generic, probably because Charts.js has to interpolate for a lot of different data representations).
I think however that monotone cubic interpolation [1] has several advantages over the classic cubic interpolation :

It preserves monotonicity of a data set (i.e. does not add local extremums due to interpolation “artifacts”)
It preserves local extremums in the original data (again, the monotonic cubic interpolation tries really hard not to add artificial extremums between discrete data points)

I hacked the current Chart.js interpolation in my repository to switch to monotone cubic interpolation if wanted, and it seems to work quite well (I already did the math for a personal charting project in SVG, so it was quite easy to replicate in Charts.js due to the use of Bezier curves for its existing cubic interpolation).
Are you interested in uplifting my changes to the official Charts.js repository ?
Regards,
[1] https://en.wikipedia.org/wiki/Monotone_cubic_interpolation
Notes :

I do not use Git nor GitHub (only SVN till now), so I may have to ask for help a bit.
For the time being, I hacked the |Chart.controllers.line.updateBezierControlPoints| function and tried to preserve as much as I can the control points calculated in |helpers.splineCurve|, but it might be better (and faster) to implement a new helper function (|splineCurveMonotone| or something).

@MatthieuRivaud these would be great to have. Perhaps we could have an option in the line element config to enable this. I agree that a new splineCurveMonotone would probably be better. It'd probably be simpler to test too.
What are your thoughts on something like this as a config option?
options: {
  elements: {
    line: {
      cubicInterpolationMode: 'monotone'
    }
  }
}

I used a config option very similar to this (options.elements.line.monotoneInterpolation, boolean). Your proposition seems better to me (more generic).
I'll try to implement splineCurveMonotone. I may have to work on the whole dataset at once, though (instead of keeping the same firstPoint, middlePoint, afterPoint parameters). We'll see.
Questions :

Can Chart.js display line charts in a vertical mode (i.e. linear x-axis and category y-axis) ? If that's the case, I would have to add a parameter to splineCurveMonotone in order to switch between x-axis and y-axis monotonicity.
Do I need to handle the line scatter chart (i.e. detect and disable monotone cubic interpolation in this case) ? This mode does not seem to call updateBezierControlPoints, AFAICT.

I think I can answer your questions

This should be possible but I've never seen a chart like that,
updateBezierControlPoints should run for a scatter chart (unless there is no line or the tension is 0)
Styling to the surrounding code is good. We don't have a formal style guideline other than what JSHint creates warnings for. You can test it out with gulp jshint

I'm having a hard time to implement splineCurveMonotone with the same signature as splineCurve : the monotone cubic interpolation works in part on segments, adjusting tangents (and thus control points) two vertexes at a time. Any thoughts ?
I also think I will have to clamp the strength of the control points (the norm of the resulting vector) : I believe the monotone cubic interpolation algorithm cannot guarantee the monotonicity if the control point is further than 1/3rd of the distance between data points (not really sure about that, my math is a bit fuzzy). I could also ignore the tension parameter, and use the 1/3 ratio (which I believe is the exact ratio to use for cubic interpolation, according to the last paragraph in https://en.wikipedia.org/wiki/Cubic_interpolation#Representations, but I may be mistaken).

Mmm, Ok, I had a bug in my hacked scatter.html sample file. I can now activate monotone cubic interpolation on a scatter graph, and can confirm the result is absolute bonkers ... ^^
There must be a mean to adapt the algorithm to keep local extremums in 2d (if it has any sense at all), but this is another work for another day. (I also don't think monotonicity has a sense in this case, but my math is much too rusty to give a definite answer).
What test would you recommend in order to detect the scatter case ? Both x-axis and y-axis in linear mode for the dataset to interpolate ?

I wouldn't constrain yourself to having the same signature as splineCurve if it doesn't make sense.
Since this is new, I think it is fine to ignore the tension and instead use 1/3. We will just need to make sure the docs are clear on this.
What if your algorithm worked on monotonic subsets of the data? The normal case would only have 1 monotonic section but scatter plots would not necessarily be. The worst case would be monotonic subsets that change with every point. If this strategy works, you won't need a specific test for the scatter chart.

The algorithm already handles minute changes in monotony. What it does not handle is datasets where the x distribution of data points isn't monotonic (i.e. when the dataset isn't of the form y = f(x)).
The scatter chart displays a function of t ((x, y) = f(t)), where t is the index of the data point. There is no definition of monotonicity that I know of in this case (it would probably be based on the notion of ordering between vectors/couples [1], but it seems quite sketchy).
There probably is a way to preserve local "extremums" (ensure the interpolated curve does not go "further" than the nearest data points), but I do not know the math, and it seems much more work than necessary for a graph that does not really need a better interpolation than the one we have now.
[1] http://mathworld.wolfram.com/VectorOrdering.html

OK, I finished coding splineCurveMonotone and updated updateBezierControlPoints accordingly :

I chose to use the 1/3 ratio and ignore tension for now, but it is quite trivial to implement.
I did not write any special case for the scatter line case. Monotone cubic interpolation can still be activated in this case, and can give suboptimal results (to say the least), but does not crash (lines are still drawn, just with somewhat inadequate control points). It should not be difficult to test the axes and auto-deactivate this interpolation mode.
I am working on a test for splineCurveMonotone. I will also take a look on the line chart doc.
There is no test for updateBezierControlPoints yet. Do you have some ideas on how to implement that, or do you think this kind of test is unnecessary (or too much work for the gain, in particular because updateBezierControlPoints is not a pure function [1], which generally makes automated testing a pain [2]) ?

How do we proceed ?

I ran gulp lint on the update source, but linting returns quite a lot of unrelated errors (incorrect "use strict" declaration and undefined identifiers like module, require, console). Is there some additional config I have to do ? (I did not see any error that could be related to my updates, but the linter may abort early due to those errors in the beginning of the files)
Do I need to provide a patch ? If so, is a SVN generated patch/unified diff OK, or do I need to provide a Git specific thing ? Or do I need to clone the repository and issue a pull request ? I never used GitHub nor Git yet.

[1] https://en.wikipedia.org/wiki/Pure_function
[2] http://alistapart.com/article/making-your-javascript-pure

@MatthieuRivaud awesome!
The updateBezierControlPoints is tested via some of the line tests (we ensure that bezier points are correct given the data) so don't worry about writing a specific test for it.
I generally use gulp jshint and that's what our CI runs as well so there should be no outstanding issues.
I would recommend cloning the repository then creating a new branch for your changes. Push your changes up to the branch and then create a pull request. :)
Thanks for implementing this :)

I tried the gulp jshint with the default gulpfile.js, but I had a dependency error (gupl-concat missing or something). I made my own gulpfile.js, as instructed in the gulp-jshint starting guide, and used gulp lint (I chose lint as the name of the gulp task).
One other thing : I began to write a unit test, and in doing so, I discovered a rather peculiar behavior when rendering a Bézier curve. The rendered curve just after the break (skipped point) in the attached screenshot does not seem to follow the given control points (at the leftmost data point, at least). Does that makes sense ? Is it time for me to head home and chill a bit ? ^^

I finally have my node installation (mostly) working. I had to manually install a lot of packages (which weren't auto-installed by npm install chart.js --save for some reason).
My code does pass gulp jshint, but I'm now having trouble running unit tests (gulp unittest). I encounter the following error :
[12:28:44] Starting 'jshint'...
[12:28:44] Starting 'validHTML'...
[12:28:44] Starting 'unittest'...
[12:28:45] Finished 'jshint' after 1.06 s
[12:28:45] Starting Karma server...
(node:9336) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
WARN [reporter]: Can not load "html", it is not registered!
  Perhaps you are missing some plugin?
[... boring stacktrace ...]
Error: No provider for "framework:browserify"! (Resolving: framework:browserify)
[... boring stacktrace ...]
[12:28:46] 'unittest' errored after 1.4 s
[12:28:46] Error in plugin 'gulp-karma'
karma exited with code 1
[12:28:47] Finished 'validHTML' after 2.75 s

(I successfully ran npm install browserify before that message)
Also : I assume the actual code and doc review will happen when processing the pull request. Correct ?

I think that error comes from https://github.com/chartjs/Chart.js/blob/master/package.json#L42
The actual review will be on the pull request. The tests and linting will auto run there as well so we'll have confirmation that nothing broke.

I'm not sure why you're seeing the issue with the bezier control points after the skipped line. They should definitely be used.

I found the issue with the control points : the spanGaps wasn't properly probed in updateBezierControlPoints (actually, not probed at all). It might be better to fix this in another issue, though.
I think I will proceed with the pull request very soon.

Ok, pull request is green. I will open a new issue for the spanGaps fix.
Thanks for the guidance.

Great! thanks @MatthieuRivaud

I'm having second thoughts on the cubicInterpolationMode option : I think it might be better to consolidate all interpolation "toogles" into one interpolationMode option, with the following choices :

noInterpolation : No line drawn between discrete datapoints
steppedLine : Same behavior as steppedLine = true currently
bezier : Default behavior (splineCurve). I would call this option bezier because it is not a real cubic interpolation if the "strength" of the control points is not carefully chosen (i.e. Bezier curves can be used to draw a cubic interpolated curve, but can do much more, even strange things if lineTension < 0)
linear : special bezier mode with lineTension = 0 ?
cubicMonotone : the new monotone cubic interpolation

This would give room to add other interpolation modes if need be.
This change may need a dedicated #issue and PR, though.
Thoughts ?

@MatthieuRivaud that's a good change in the long run, but it'd require a major version bump since the API is changing, or at least, we would have to support all the old options even if the new option is the way going forward.. I think because of this is would have to be its own issue

Yep, I agree. Maybe for v3 ^^


Merge mainstream (#21)

#40

This is weird. git log shows commit history but nothing really changed. I will investigate it (if I have time)


Firebase 3.0

Does this library support Firebase_3.0 ?

ElmFire currently uses Firebase's Web-API version 2.4.2.
This version will continue to work against upgraded (3.0) projects.
Please also note that the database API didn't change in any way from version 2.4 to version 3.0. Only the authentication API did change a bit.
I am in the  process of updating ElmFire to Elm 0.17. I will probably switch to the new Firebase Web API, either on the initial or a subsequent release.

Any progress on this, or any way that I can help?

Continuing in #16


There's no any "Generate API Key" button at this page

There's no any "Generate API Key" button at this page :(
I create the subscription by  "connect existing subscription" to connect a azure cognitive service

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 73fb7e76-fb80-c420-2efe-e3ca3a27b749
Version Independent ID: 07a42557-deb3-e4b3-3f14-f26a27be49c2
Content: Azure Batch Transcription API
Content Source: articles/cognitive-services/Speech-Service/batch-transcription.md
Service: cognitive-services
GitHub Login: @PanosPeriorellis
Microsoft Alias: panosper

@dabdirb
Thanks for the feedback! We are currently investigating and will update you shortly.

so where can i got the API key to evaluate it ?
in azure console the api key can not got token from cris.ai

There's a new version of the APIs which doesn't need the key anymore. You can use the Ocp-Apim-Subscription-Key  HTTP header with your subscription key from Cognitive Services Speech (or Custom Speech) service.

Neither this doc nor sample code show what the new API is :(

@YutongTie-MSFT please reassign this to @erhopf

I tested by using latest API it works


Increment version for appconfiguration releases

Increment package version after release of Azure.Data.AppConfiguration

This versioning doesn't look correct to me, given the current version is v1.1.0-beta.3.     @pakrym:  Do you mind taking a look and closing out if this isn't needed?


Settings not available on my Forerunner 735XT

Hi HanSolo,
your watchface is awsome - thanks for the great work! Unfortunately I have a minor issue with customizing according your screenshots on Garmin Connect IQ site. I simply have no "..." button in the Garmin Connect application:

I've downloaded the latest version of the watchface. Any suggestions / ideas?
Greetings from Hamburg :-)

Okay - in the latest version this problem is gone, at least for me :-)
Thanks for all


ARROW-5686: [R] Review R Windows CI build

I reviewed with @jeroen and he said "That seems about right." This patch reorganizes the script and adds/updates comments to reflect a better understanding of the process.

There was a transient failure on Appveyor here but it passed on my fork just now: https://ci.appveyor.com/project/nealrichardson/arrow/builds/26893899


Transaction has been reverted by the EVM

Transaction has been reverted by the EVM:
{
"blockHash": "0xdac6f81f5aedfc9fd56163206a79cf2b918a967d07fff759807d45c17ee14532",
"blockNumber": 14842309,
"contractAddress": null,
"cumulativeGasUsed": 12778168,
"effectiveGasPrice":<PHONE_NUMBER>2,
"from": "0xed0bd7f319cd03539cbd3b5c592cae91a349dbae",
"gasUsed": 29623,
"logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"status": false,
"to": "0xae0ee0a63a2ce6baeeffe56e7714fb4efe48d419",
"transactionHash": "0xa7d163100faaea48c7e9f76b71c2c383bf46e9112a42259e5999c732e0d98695",
"transactionIndex": 259,
"type": "0x2",
"events": {}
}:
{
"blockHash": "0xdac6f81f5aedfc9fd56163206a79cf2b918a967d07fff759807d45c17ee14532",
"blockNumber": 14842309,
"contractAddress": null,
"cumulativeGasUsed": 12778168,
"effectiveGasPrice":<PHONE_NUMBER>2,
"from": "0xed0bd7f319cd03539cbd3b5c592cae91a349dbae",
"gasUsed": 29623,
"logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"status": false,
"to": "0xae0ee0a63a2ce6baeeffe56e7714fb4efe48d419",
"transactionHash": "0xa7d163100faaea48c7e9f76b71c2c383bf46e9112a42259e5999c732e0d98695",
"transactionIndex": 259,
"type": "0x2",
"events": {}
}

How to participate?


Help File for Get-PowerApp

the help file for get-powerapp has some problems, Example 3 and 4 show up multiple times. It looks like there might be an issue with formatting in the cmdlet file

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6a682d40-fb0d-4938-b1ac-cee291c2bbff
Version Independent ID: c7fdffb8-c6b7-f02b-a5e0-6787218978c6
Content: PowerShell support (preview) - PowerApps
Content Source: powerapps-docs/administrator/powerapps-powershell.md
Service: powerapps
GitHub Login: @jamesol-msft
Microsoft Alias: jamesol

Closing given the age of this comment. Please reopen if this remains an issue.


Documentation typo for saveAll

Hi! Is there a documentation typo here ? It seems that it is rather saveAll
https://github.com/arangodb/arangojs/blob/804e6ad352f9943490883a6a31c7ddfa22dc22f2/src/collection.ts#L1703

You're right. Thanks for spotting this one.


Rebase resource-set refactoring from 3.0 to 4.0

And ensure this chart works with rancher 2.8

Too many changes here outside the resourceset part don't make sense.


Update katip dependency

This needs updating so that it is compatible with the version of katip used in iohk-monitoring-framework.

bors r+


Remove dependency on org.reflections.Reflections

[X] 2.8.0

The released library has a dependency on org.reflections 0.9.11.  As shown here, this library is licensed under the WTFPL licence which is often rejected by enterprise companies due to it's lack of clarity on the use of this licence.
Even though the pom file lists BSD 2, often this is not enough given the readme stats WTFPL only.
Because of this, even though this project is listed as Apache 2.0, many companies won't allow this project to be used internally due to it's dependency tree.

Thanks for bringing it to the attention. It is used by swagger-core which is apache 2.0 as well.
https://github.com/swagger-api/swagger-core/blob/f34c101613be26fcc4f300de6bce2fa76159390a/pom.xml#L474-L478
Which is why I assumed its ok to use the library. Open to suggestions/alternatives

I don’t have any suggestions unfortunately but we did notice that if we excluded it from our build and denied the dependency, the Swagger UI still worked as expected.
I don’t know enough about Swagger to say what would be missing if we’d tried to use the Swagger UI in a different way.

@leewinder Scanning the repo for conventions will not work for e.g. jackson serliazation convention JacksonSerializerConvention will not work if configured.

@dilipkrish Reflections can usually be replaced by https://github.com/lukehutch/fast-classpath-scanner, which has a Apache compatible MIT License (see https://www.apache.org/legal/resolved.html#category-a), no dependencies and better performance.
I could try to create a pull request, if is welcome.

@PascalSchumacher Absolutely welcome. Currently Reflections is a provided dependency, so it is an opt-in library and you use the JacksonSerializerConvention only if users are ok with taking on that license.
I would recommend adding another implementation of the same JacksonSerializerFastClassPathScannerConvention (namings hard I know!).
Java 7+ is ok to go with post 3.0, So if you do endup with a PR please expect that it will only be pulled in post 2.9 (which is sometime in April


Azure Pipelines: Update Visual Studio 2019 to version 16.7

Tool information

Tool name: Visual Studio 2019
Tool license: Commercial
Add or update? Update
Desired version: 16.7

Virtual environments affected

Windows Server 2019

Can this tool be installed during the build?
No
Are you willing to submit a PR?
Potentially, if someone can point me in the right direction.
Visual Studio 2019 16.7 was released this month. We require 16.7 to build our product. Please update Azure Pipelines Microsoft Hosted Agents image "Windows Server 2019 with Visual Studio 2019 (windows-2019)" from Visual Studio 2019 16.6 to Visual Studio 2019 16.7.

Hello @kmahone !
We install latest VS on every image-generation. We have already started deployment of new image with VS 16.7, it should be deployed everywhere in 3-4 days: https://github.com/actions/virtual-environments/pull/1402

Perfect! Thanks for the quick response.

I've just run into this issue today which is blocking my PR. I understand I can fix it with a global.json file, however I can't seem to work out the correct version numbers. If I look on my local machine I see 3.1.6 (see below) however if I specify that in the globla.json file my project doesn't build. So what's a valid version I can use that works with < 16.7 of MSBuild? Alternatively what's the status of the rollout as I understand it started 5 days ago, how long does it take to deploy fully? Is there a status page we can look at?
Microsoft.AspNetCore.All 2.1.20 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.20 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.1.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.20 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.1.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.1.6 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

@dotnetprofessional I just tested 3.1.302 in the UseDotNet task and it seems to work for me.

@mattleibow Thanks that has solved my issue! :)

Hello everyone, small update: we had to stop deployment because of some regression with new VS version.
We are working to investigate the issue and will update this issue as soon as we have updates

Thanks for the update. So far, using the 3.1.302 version of .NET Core as part of the pipeline has been good and no other issues yet.

I'm thinking not having the latest Visual Studio 2019 installed causes my build to fail with the following errors:
CheckForUnsupportedScenarios:
  The specified XPath query did not capture any nodes.
##[error]C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VisualStudio\v16.0\AppxPackage\Microsoft.AppXPackage.Targets(3035,5): error APPX0702: Payload file 'C:\Users\runneradmin\.nuget\packages\microsoft.winui\3.0.0-preview2.200713.0\runtimes\win10-x86\native\Microsoft.UI.Xaml\DensityStyles\Compact.xaml' does not exist. [D:\a\myApp\myApp\src\myApp (Package)\myApp (Package).wapproj]
##[error]C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VisualStudio\v16.0\AppxPackage\Microsoft.AppXPackage.Targets(3035,5): error APPX0702: Payload file 'C:\Users\runneradmin\.nuget\packages\microsoft.winui\3.0.0-preview2.200713.0\runtimes\win10-x86\native\Microsoft.UI.Xaml\DensityStyles\CompactDatePickerTimePickerFlyout.xaml' does not exist. [D:\a\myApp\myApp\src\myApp (Package)\myApp (Package).wapproj]
##[error]C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VisualStudio\v16.0\AppxPackage\Microsoft.AppXPackage.Targets(3035,5): error APPX0702: Payload file 'C:\Users\runneradmin\.nuget\packages\microsoft.winui\3.0.0-preview2.200713.0\runtimes\win10-x86\native\Microsoft.UI.Xaml\Themes\compact_themeresources.xaml' does not exist. [D:\a\myApp\myApp\src\myApp (Package)\myApp (Package).wapproj]
##[error]C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VisualStudio\v16.0\AppxPackage\Microsoft.AppXPackage.Targets(3035,5): error APPX0702: Payload file 'C:\Users\runneradmin\.nuget\packages\microsoft.winui\3.0.0-preview2.200713.0\runtimes\win10-x86\native\Microsoft.UI.Xaml\Themes\generic.xaml' does not exist. [D:\a\myApp\myApp\src\myApp (Package)\myApp (Package).wapproj]
##[error]C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VisualStudio\v16.0\AppxPackage\Microsoft.AppXPackage.Targets(3035,5): error APPX0702: Payload file 'C:\Users\runneradmin\.nuget\packages\microsoft.winui\3.0.0-preview2.200713.0\runtimes\win10-x86\native\Microsoft.UI.Xaml\Themes\themeresources.xaml' does not exist. [D:\a\myApp\myApp\src\myApp (Package)\myApp (Package).wapproj]

Thank you for your response @maxim-lobanov. Agent/Image details for both failed and successful build was this (windows-2019):
Current agent version: '2.173.0'
Current image version: '20200802.1'
Looking closely at the logs, build server image was not the issue (and it wasn't the MSBuild issue that this thread is referring to either) . Sorry I just assumed that it was the same MSBuild error resurfacing again without looking more into details.
This was the actual error I was getting briefly on Friday 8/21/2020 with "Use .Net Core 3.1.302" task. It resolved itself within couple of hours, so please ignore.
##[error]Failed while installing version: 3.1.302 at path: C:/hostedtoolcache/windows/dotnet with error: Could not download installation package from this URL: https://download.visualstudio.microsoft.com/download/pr/dafb4b49-9990-49aa-b8fe-9002c1a3578a/42acda06cb3d22d886b91aac37fda667/dotnet-sdk-3.1.302-win-x64.zip Error: Error: Unexpected HTTP response: 504

Hello, everyone!
VM image with Visual Studio 16.7.30413.136 has been deployed, readme updated
https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md


Add recognition for contributions

Entity: @CrioDo
Contributions:

eventOrganising

@all-contributors add @CrioDo for eventOrganizing


Support for GOOGLE_APPLICATION_CREDENTIALS

See issue #123.
Some notes:

To fix read only setting, I replaced WP_STATELESS_MEDIA_JSON_KEY with WP_STATELESS_MEDIA_KEY_FILE_PATH. I don't see the purpose of WP_STATELESS_MEDIA_JSON_KEY constant when WP_STATELESS_MEDIA_KEY_FILE_PATH already exists.
WP_STATELESS_MEDIA_JSON_KEY have higher priority than GOOGLE_APPLICATION_CREDENTIALS.
I added "Currently configured via an environment variable." to private $strings to make it easier to troubleshoot. Just to print "Currently configured via a constant" may confuse some people.
I don't know if "environment variable" is the right terminology for this. Maybe have more specific like "Google application credentials" is better?
I left a note about GOOGLE_APPLICATION_CREDENTIALS in the readme file. But I want to somehow inform about the use of it in GCS and it can be defined by using putenv or add it to the server environment. Not sure it's information overkill or in what format this should be presented (eg. in FAQ or as part of a Google Cloud Storage plugin migration instructions).
Did update the changelog. I have putted the read only issue as a "fix".
I have used the PSR2 coding standard, with 2 spaces indentation.

I have tested this with Wordpress 4.8.1 (multisite) and PHP 7.1.7 in Docker. I defined GOOGLE_APPLICATION_CREDENTIALS both with putenv and with Docker environment variable.
Let me know if you have any feedback.

I felt bad about my messy code, so I did the fixes myself (https://github.com/walle89/wp-stateless/commits/pr-135-fixes - See commits for Aug 18). I also implemented a check if WP_STATELESS_MEDIA_JSON_KEY is defined, it will not look for the key file.
I can create a new pull request with my fixes if you want to, or you can just copy and paste my work.


Specify region in Lambda request?

I have the same lambda function hosted in different region on AWS.
I configured ex_aws like this:
config :ex_aws,   access_key_id: [{:system, "AWS_ACCESS_KEY_ID"}, :instance_role],   secret_access_key: [{:system, "AWS_SECRET_ACCESS_KEY"}, :instance_role],   region: [{:system, "AWS_REGION"}, :instance_role]
Let's say AWS_REGION is set to "us-west-1".
If I run a Lambda request with ex_aws like that:
ExAws.Lambda.invoke("function", payload, nil)
By default, it's gonna use us-west-1
Is there a way to directly specify another region in the function invocation?

I just looked at the other issues and I found a way by specifying the region directly in ExAws.request this way:
ExAws.Lambda.invoke("function", payload, nil) |> ExAws.request(%{region: "eu-west-1"})
Is that the best way to do?

That is correct. You can also just use keyword list syntax: |> ExAws.request(region: "eu-west-1")


How to choose a test subset in Stryker JS

Question
Hi,  is there a equivalent configuration for test-filter (existing on Stryker4s -> https://stryker-mutator.io/docs/stryker4s/configuration/#test-filter-string) for Stryker JS? I don't want to use all my tests in the mutation.
Stryker environment
        "@stryker-mutator/core": "^4.4.1",
        "@stryker-mutator/jest-runner": "^4.4.1",

    "jest": "26.6.3",
    "react": "^17.0.2",

Hi @antoniogamizbadger configuring which tests to run is part of the test runner configuration.
For example (mocha ☕):
{
  "mochaOptions": {
    "spec": [ "test/components/*.js" ],
    "grep": "AppComponent.*"
  }
}

This would run only the tests found in the test/components directory with title starting with "AppComponent...".

Ah, I see, great, thanks! Not sure if opening another ticket, but when using the ignoreStatic flag in stryker JS it tells me that it's not valid. It appears as not deprecated on the docs -> https://stryker-mutator.io/docs/stryker-js/configuration/#ignorestatic-boolean

Oh I need stryker 6. Great :DDDD

True, you may open an issue to improve our docs if you want. We should specify a "since" for every option.


[BUG] Supabase - sort items by id (primary key) if no sorters are specified

Describe the bug
Currently when using Refine with Supabase examples, items are returned in non-deterministic order because they are not sorted by id (primary key). I know that I can set sorters manually but in MUI I can have only one sorter at the time so if the user removes sorters, items are displayed in non-deterministic order.
Steps To Reproduce

Go to this example
https://codesandbox.io/s/github/refinedev/refine/tree/master/examples/data-provider-supabase?from-embed=&file=/src/App.tsx
Remove sorting from all the columns
As you can see, items are displayed in non-determnistic order.

Expected behavior
If no sorters are specified, items should be sorted by id (primary key).
Screenshot
No response
Desktop
No response
Mobile
No response
Additional Context
No response

Thank you for the feedback 🙏🏼  We'll check and get back to you.

@yildirayunlu
sorter.permanent is not going to work for me because in MUI you can have only one sorter in free version.
So if I set a permanent sorter on one column, user cannot sort by other column.

@Mikilll94 It can handle this situation by overriding the dataProvider methods. You can use getList method from icon source codes. There is a document about it.


Consuming nested records in TS

It appears that the [@genType] annotation on a nested record only converts the first level, i.e.
[@genType]
type i18n = {
  first_field: string,
  second_field: string,
  nested_field
} and nested_field = {
  third_field: string,
};

On a record instance of type i18n I'm able to do i18n.first_field and .second_field but not .nested_field.third_field as nested_field gives me an array.
I've tried also annotating nested_field with [@genType] but end up with the same result.
For context we have translations defined as a record type, where nested fields express seperate domains. We'd like to also consume them from our TypeScript codebase.

@cem2ran thanks for the report!
This seems to happen when both types are defined in the same file, and used from another file.
Some type inlining does not reach as far as it should.


chore(requirements): update codecov lib to 2.0.3

Summary of Changes
Updates the codecov uploader library to the current release, 2.0.3
See https://github.com/codecov/codecov-python/compare/v1.6.3...v2.0.2
Pull Request Hygiene TODOs
Please make sure the below checklist is complete.

[X] Your pull request is concise and to the point (make another PR for refactoring nearby code)
[X] Your commits are squashed into logical units of work
[X] Your commits follow the commit style guidelines

:cherry_blossom: Thank you! :cherry_blossom:

[Current coverage][cc-pull] is 81.98%

Merging [#687][cc-pull] into [master][cc-base-branch] will decrease coverage by -0.15%

File ...fs/api/models/app.py (not in diff) was modified. more

Misses +3
Partials +2
Hits -5

@@             master       #687   diff @@
==========================================
  Files            29         29
  Lines          2547       2547
  Methods           0          0
  Messages          0          0
  Branches        396        396
==========================================
- Hits           2093       2088     -5
- Misses          325        328     +3
- Partials        129        131     +2

Powered by Codecov. Last updated by [2af0a5e...e9148e5][cc-compare]
[cc-base-branch]: https://codecov.io/gh/deis/controller/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/deis/controller/compare/2af0a5e124c6b4c7e8f41d481c298c98b69b6819...e9148e5f03defa9c5bbed0077c7f37fd73a499a8
[cc-pull]: https://codecov.io/gh/deis/controller/pull/687?src=pr


DNS fixes

https://github.com/rancher/rancher/issues/5041
https://github.com/rancher/rancher/issues/7990
Core logic from: https://github.com/rancher/rancher-dns/pull/37

Tested on the following different images:


No place to input in the Demo

Hi, I run the demo by
python demo_audiovideo.py     --cfg-path eval_configs/video_llama_eval_withaudio.yaml  --gpu-id 0

It launches successfully, but the input field is stuck and I cannot input words. And the section of 'Video-LLaMA' is null on the interface. I wonder what is the possible solution for it.

The following is how I fill the file the video_llama_eval_withaudio.yaml.
model:
  arch: video_llama
  model_type: pretrain_vicuna
  freeze_vit: True
  freeze_qformer: True
  max_txt_len: 512
  end_sym: "###"
  low_resource: False

  frozen_llama_proj: False

  # models/vicuna-7b-v1 uses llama-7b-hf + vicuna-7b-delta-v0
  llama_model: "models/vicuna-7b-v1"
  imagebind_ckpt_path: "models/imageBind/"

  fusion_head_layers: 2
  max_frame_pos: 32
  fusion_header_type: "seqTransf"

  ckpt: "models/Video-LLaMA-Series/finetune-vicuna7b-v2.pth" #path/visual_branch_ckpt/  # pretrain: miniGPT4
  ckpt_2: "models/Video-LLaMA-Series/finetune_vicuna7b_audiobranch.pth" #path/audio_branch_ckpt/ # pretrain: ImageBind

datasets:
  webvid:
    vis_processor:
      train:
        name: "alpro_video_eval"
        n_frms: 8
        image_size: 224
    text_processor:
      train:
        name: "blip_caption"

run:
  task: video_text_pretrain

The running log is
Initializing Chat
Loading VIT
Loading VIT Done
Loading Q-Former
Using pad_token, but it is not set yet.
Loading checkpoint shards: 100%|██████████████████████████████████████████████████| 2/2 [01:36<00:00, 48.45s/it]
Initializing audio encoder from models/imageBind/ ...
audio encoder initialized.
Load first Checkpoint: models/Video-LLaMA-Series/finetune-vicuna7b-v2.pth
Load second Checkpoint: models/Video-LLaMA-Series/finetune_vicuna7b_audiobranch.pth
Initialization Finished
Running on local URL:  http://<IP_ADDRESS>:7860

To create a public link, set `share=True` in `launch()`.

Please click "Upload & Start Chat" button first.

Haha, I got it! It works with a good caption. I still have a question about the tokenizer.
For one time, I use open_llama_7b+ vicuna-7b-delta-v0 to get the vicuna model, the demo collapses with bad caption.
Then I use llama-7b-hf + vicuna-7b-delta-v0  to get the vicuna model, the demo works, but it messages 'Using pad_token, but it is not set yet.    '
It seems that 'llama-7b-hf' uses 'LLaMATokenizer', 'open_llama_7b' uses 'LlamaTokenizer', and  'vicuna-7b-delta-v0' uses 'LlamaTokenizer'.    Referring your code https://github.com/DAMO-NLP-SG/Video-LLaMA/blob/main/video_llama/models/video_llama.py#L120, you use 'LlamaTokenizer'.
I wonder what tokenizer is used in your LLaMa model.

Question 1: Please note that open-llama-7b and llama-7b are two DIFFERENT models, the delta weights only work with llama-7b if you want to obtain vicuna-7b.
Question 2: We prepare hf version LLaMA weights using this script and the tokenizer class is LlamaTokenizer.


v0.97.8 breaks Meteor

I haven't touched my project in several weeks and I came back to it today, started meteor and I get this error in the client:
Couldn't find a template named "welcome" or "welcome". Are you sure you defined it?
And in the console:
Error: Scss compiler error: Undefined variable: "$medium-and-down".
TypeError: Package['materialize:materialize'] is undefined
Exception in callback of async function: isRegistered@http://localhost:3000/app/lib/router.js

After a few hours of trying to figure it out, since the welcome template is there and has been there as the very first template, I found out that removing materialize from the project removes this error. Of course, the site now looks awful...
As soon as I bring back materialize back, the same error shows up again.
Found a temporary solution here:
meteor remove materialize:materialize
meteor add<EMAIL_ADDRESS>

Duplicate to #3905
Just read the whole thing :D

And Couldn't find a template named "welcome" or "welcome". Are you sure you defined it? Has something todo with, I guess you are using Iron:router, your router. Definitely not materialize

Yes, I am using Iron:router.
If removing materialize removes the problem, and changing materialize from latest v0.97.8 to v0.97.7 completely fixes it, then IMO materialize v0.97.8 is to blame, no?

Do you have a route called welcome ?

Yes. The route is there, it is the first one I created, the welcome start page...
It all worked fine until materialize v0.97.8 was picked up.
The code did not change before that.
The code did not change before I reverted back to v0.97.7.
The code is the same as it was several months ago when I last worked on it and deployed it to production...

As @tomscholz said, this is a duplicate issue of #3905


If i using both v3.7.4 and v3.1.1 can be cause characters that open with v3.7.4 disable Epic and Legendary difficulties.

As the tittle said, i still keep TQVaultAE v3.1.1 (because it's the most stable version for me) on the desktop, and when i using v3.7.4, i created its shortcut on Desktop near v3.1.1's shortcut. So as the habit, i start v3.1.1 when i intent to start with v3.7.4. After that, i quit v3.1.1 then run v3.7.4. The character that load the last of 2 TQVault version is different. And when start game, character that i load last time with v3.7.4 be disable Epic and Legendary difficulty mode at character selection window; character that load with v3.1.1 last time still ok.

Thank you for the bug report.
We're not keeping versions backwards-compatible at this time. The data files may allow it of course, but it is not an officially supported feature.
If you let us know of the instabilities you're experiencing in the latest release, we can track and work on them.


Converted to swift 2.0 syntax and successfully run in Xcode 7 beta 5, iOS 9 beta 5

Thanks! I've merged this under the Swift2.0 branch. If no one has any problems with it, I'll merge it into master.

:D

I don't know how to create a pull request that can create a new branch. Do you know how to to that? @bennichols

@theniceboy I just created a new branch and merged it in manually.


Add support for single language localization

The script fails when you have only a single Localizable.string inside the project, so I thought a configurable field would help those out who are suffering the same as me. 🤔 Probably it could be documented better, but what do you think?

@ezisazis  I never tested the script with a single file to be honest and this looks a like a great addition.
Thanks a ton for helping !
As a thank you I Invited you as a Gold Contributor and gave you write access on this repo.
We usually still do PR's so that someone else from the team can review & discuss.
Have a fantastic day :)

Cool, thanks for the invitation 🥇. As it is my first real contribution to any OS project, I have to say you are being very friendly (which encourages me to continue doin' it ;) ), and it feels awesome being part of the community. Keep up the good work! 💯

Very glad to hear that! Open source is a nice way to get some time off from regular company work and working with smart minds from around the globe has been such a enriching experience for me :)
Welcome on board 👍


gha test

🚀 Pull Request
Description

Codecov Report
Patch and project coverage have no change.

Comparison is base (8be5d69) 93.10% compared to head (d2a501c) 93.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   93.10%   93.10%
=======================================
  Files           1        1
  Lines         203      203
  Branches       50       50
=======================================
  Hits          189      189
  Misses          7        7
  Partials        7        7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Okay, so this simple gha is not being triggered, which is somewhat baffling... :confused:

Is there a switch to flick in the repo settings?  Possibly clutching at straws but I notice there are no current GHA is nc-time-axis.

Is there a switch to flick in the repo settings?  Possibly clutching at straws but I notice there are no current GHA in nc-time-axis.

@rcomer Nope, no obvious switches. I've looked everywhere, cross-compared with other than operational repo, scoured the docs and come up blank.
My thinking is that perhaps we need to bank the first action to bootstrap the workflows... But that's complete speculation.
Dunno. But I'd be happy for anyone to advise if they've seen this behaviour before. Perhaps I've done something obviously wrong, but the GHAs are pretty much similar to others the definitely are operational.
Otherwise, my suggestion is to merge this PR to see what happens. We can always reset the HEAD on main afterwards.
Dunno?! I'm speaking to the wisdom of the crowd here...

@rcomer Well... ain't that a thing. Good to know, right?
Thanks for taking the plunge 🎉


Add websocket link

Related issues:
https://github.com/gql-dart/gql/issues/76
https://github.com/comigor/artemis/issues/76
https://github.com/zino-app/graphql-flutter/issues/608

@agent3bood thanks for the contribution!
As a heads-up, here are two things you'll need to do:

add the package to the workflow https://github.com/gql-dart/gql/blob/master/.github/workflows/dart.yml
use the gql_pedantic rules https://github.com/gql-dart/gql/blob/master/gql_link/analysis_options.yaml

@agent3bood, #97 by @iscriptology got ahead of you. Could you please review #97 to see if it covers what you ported?

@klavs
I have seen the pr by @iscriptology here are the things that are in my PR and not in the other, please give us feedback, I will be happy to contribute to wither PRs.
The main difference is I used https://pub.dev/packages/web_socket_channel as a base for the connection, in PR 97 is is using https://pub.dev/packages/websocket and implementing custom client. (Need feedback on this, what is better?)
Best
Abdullah

@agent3bood, I would actually prefer web_socket_channel. Could you rebase/redo this change on top of @iscriptology 's branch?
#97 seems quite ready for an alpha release and I'll try to merge it within 24 hours.

ok, I will send a PR to @iscriptology with the web_socket_channel, but tests will be in another day :(

You do not have to rush. Just base your branch on he's and we'll merge it to master (of this repo) later.

Closing, all implementation is now moved to WSLink

What is the roadmap for stabilization of the websocket link?
I offer my help if needed.
Besides, the latest alpha version currently relies on alpha releases of different gql packages. why?


[BEAM-7414] fix for message being not serializable due to LongString in headers

This is a fix for https://issues.apache.org/jira/browse/BEAM-7414
Basically, when receiving a RabbitMqMessage, I copy all its delivery fields into a new delivery object, which allows me to replace LongString by String.
The try/catch loop is there for cases where LongString objects are too long to be transformed into String
Code can be reviewed by @jbonofre or @aromanenko-dev which are both aware of the issue (but i guesse @jbonofre would be a better reviewer)
Notice that i'm trying to communicate with RabbitMq team in parallel to have issue fixed in a more elegant way on their side

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

@Riduidel thanks for the commits, I will take a look later today.

@aromanenko-dev is it possible to merge that PR now ?

@Riduidel not yet, I'm reviewing it.

Why did the first check failed ? It seems unrelated to my code, no ?

There have been issues with the jenkins executor randomly causing job issues.

Run Java_Examples_Dataflow PreCommit

What's next on this PR?

Why is this not merged yet ?

Any updates on this PR? What stops this to be merged?

Any updates on this PR? What stops this to be merged?

I don't see an approval from any of the reviewers. @Riduidel , do you still want to proceed with this PR?

@aromanenko-dev I'm resuming my review on this one, but there was a change (now reverted) that was not good IMHO.


test: support publish package with a public field.

What does this PR try to resolve?
This PR add a public alike method to support add a dependency as public/private,
Package::new("foo", "0.1.0")
        .cargo_feature("public-dependency").add_dep(Dependency::new("bar", "0.1.0").public(true))

and then get it from registry in test.
This PR was seperated from the https://github.com/rust-lang/cargo/pull/13183.
How should we test and review this PR?
You can review on per commit.
After running the test case publish_package_with_public_dependency,  you can check a "public" field in ./target/tmp/cit/t0/registry/3/b/bar.
Additional information
r? epage

@bors r+

:pushpin: Commit 35d5fae5b67caf9a04c46277b78a96724cf40585 has been approved by epage
It is now in the queue for this repository.

:hourglass: Testing commit 35d5fae5b67caf9a04c46277b78a96724cf40585 with merge 04398ba595ee05e09131f27b335bead34146b700...

:pushpin: Commit 35d5fae5b67caf9a04c46277b78a96724cf40585 has been approved by epage
It is now in the queue for this repository.

:hourglass: Testing commit 35d5fae5b67caf9a04c46277b78a96724cf40585 with merge 8de3343d802b1266335d6425341f7e4b649a0bb2...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing 8de3343d802b1266335d6425341f7e4b649a0bb2 to master...


Sharepoint, office 365

Is this supposed to work with sharepoint for office 365, or am I getting it wrong?
I believe I have provided the correct credentials, and  $site->setSPAccessToken() does generate a token.
However, if I try to do anything like $lists = SPList::getAll($site), or any other operation, I get this error:
WeAreArchitect\SharePoint\SPException: Access denied. You do not have permission to perform this action or access this resource.

Hi @hhovind,
That's a very good question. I haven't tested the lib with an Office 365 SP, so I can't confirm if it's supposed to work out of the box or not.
From the error message, it does seem to have support for it, being just a a permissions issue.
But I'll pass the ball to @Estro, to see what he says about this.

Hi @hhovind,
Yes it works on Office 365 SP. It's actually on-prem that it has not been tested on. It sounds like the issue is most likely related to the resource and client Id in your credentials. Make sure you have followed the credentials guide correctly:
https://github.com/wearearchitect/sharepoint-oauth-app-client/blob/master/docs/Credentials.md
You should also check that the SharePoint Hosted App that has been added to the site has the correct permissions set via the App manifest. More information can be found at the following link:
https://msdn.microsoft.com/en-us/library/office/fp142383.aspx

Also, are you trying to use a user or app only token?
If using the App only policy, you need to add a 'AllowAppOnlyPolicy' attribute to the AppPermissionRequests node within the app manifest with a value of true.

Thank you for your replies, @quetzyg and @Estro
You were right, I was using App-only policy, and I had to add the AllowAppOnlyPolicy attribute.
It seems to be working perfectly now, thanks!
Also thanks for a great lib!

:+1:
Nice to know it's working for you @hhovind.


Sparse-fication recipe for yolov7

Hello there,
Thanks for working in Sparsify. This speed-ups are very impressive and amazing.
Yolov7 has been released recently and it is faster and more accurate than other object detectors at the moment. Do we have a plan to write sparse-fication recipe for this ?
I am open to work individually or with people to create a pull request.

Hi @sandyflute
With the newer version of SParsify, YOLOv7 will be supported
In other news, the Neural Magic team has been busy working on the next generation of Sparsify which will have much-improved pathways for users to interact and get results. We are very excited to see that go live later this year. As such, we will be closing this ticket.
We did want to invite users who are interested in being Sparsify testers and giving feedback to contact our UX lead Rob Fitzgibbon (@NMfitz). We would be happy to make it worth your time with a gift card if you do!
Best and thank you, Jeannie / Neural Magic

Hi @sandyflute  - yes, as per @jeanniefinks, we're looking to do some user interviews; please let me know if that might be something that would interest you - Fitz


Fix #511.

Codecov Report

Merging #515 (0280067) into master (7f1b639) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #515   +/-   ##
=======================================
  Coverage   86.78%   86.79%
=======================================
  Files          24       24
  Lines        3315     3316    +1
=======================================
+ Hits         2877     2878    +1
  Misses        438      438

Impacted Files
Coverage Δ

dwave/cloud/computation.py
75.86% <100.00%> (+0.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f1b639...0280067. Read the comment docs.


aot seems to ignore @MethodHint with primitive type parameter

While trying to track down an issue with the HttpComponentsClientHttpRequestFactory I found the following. I have a @NativeHint similar to the ClientHttpRequestFactoryHints.
@NativeHint(types = { @TypeHint(types = org.springframework.http.client.HttpComponentsClientHttpRequestFactory.class,
methods = { @MethodHint(name = "setConnectTimeout", parameterTypes = int.class),
@MethodHint(name = "setReadTimeout", parameterTypes = int.class),
@MethodHint(name = "setHttpClient", parameterTypes = HttpClient.class),
@MethodHint(name = "setBufferRequestBody",
parameterTypes = boolean.class), }) })
Running 'gradle generateAot' on this generates
{
"name": "org.springframework.http.client.HttpComponentsClientHttpRequestFactory",
"allDeclaredConstructors": true,
"methods": [
{
"name": "setHttpClient",
"parameterTypes": [
"org.apache.http.client.HttpClient"
]
}
]
}
If you specify a non-primitive type parameter, the method shows up.
The @NativeHint in ClientHttpRequestFactoryHints generates
{
"name": "org.springframework.http.client.HttpComponentsClientHttpRequestFactory",
"condition": {
"typeReachable": "org.apache.http.client.HttpClient"
},
"allDeclaredConstructors": true
},

Spring Native is now superseded by Spring Boot 3 official native support, see the related reference documentation for more details.
As a consequence, I am closing this issue, and recommend trying your use case with latest Spring Boot 3 version. If you still experience the issue reported here, please open an issue directly on the related Spring project (Spring Framework, Data, Security, Boot, Cloud, etc.) with a reproducer.
Thanks for your contribution on the experimental Spring Native project, we hope you will enjoy the official native support introduced by Spring Boot 3.


Fix integration test failure for sitconfig

Fix istio sitconfig replication channel regression in integration test.
kind new test 8382 ran successfully and no longer seeing the replication channel error message
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/8382/   (ItIstioDomainInPV)

@jshum2479, is this just a revert? Did more analysis happen today of what might be done to work around the sitcfg issue while still squashing the security warning?

@rjeberhard   This is not a revert,  we removed the settings of  the channel and take the defaults from wls after discussion with @lennyphan .    @anpanigr   Test https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/8387/  ran against all ITIstio*


Report should show domain descriptions

When fields being reported have domains - the report should show the domain description, not field value.
For example (from Incident Status Dashboard download) --
in the report:

in the pop up -- notice MRP Status and NIMS Resource have descriptive values

Get a KeyError with the MRPs --
GP Error:

Table Properties:

Sample Data:
Issue109.gdb.zip

I didn't have the domain object list setup correctly to deal with multiple domains for a single table.

looks good!
verified


Resolve merge conflicts after meta DEx RPC enabler PR

https://github.com/OmniLayer/omnicore/pull/8 touched some parts, which caused merge conflicts for this branch.

Not yet finished. One moment..

Alright. This seems to do it, even though you may just pull the updated omnicore-0.0.10 branch in yourself. For an easier comparison, the actual merge conflicts can be addressed by the changes of the following commit: https://github.com/dexX7/bitcoin/commit/23f8791a9be6dbf1580e959f1d3fffaa3e5b6927  - ... though cherry-picking this one alone doesn't seem to do the trick, because trade_MP for example was moved somewhere inbetween.
Sorry for the trouble!

No trouble at all :)

Just a quick one to note test plan for MetaDEx passes so likely test plan is insufficient.
The UI throws up examples that are easy to spot, for example:

There should be matching going on here.  Dumping the MetaDEx state we can pluck out a couple of offers that clearly should have been matched/traded:
0.20000000000000000000000000000000000000000000000000= 5.00000000000000000000000000000000000000000000000000:mpZATHupfCLqet5N1YL48ByCM1ZBfddbGJ in 311791/028, txid: ee5272132f , trade #1 2.00000000 for #12 10.00000000
5.00000000000000000000000000000000000000000000000000= 0.20000000000000000000000000000000000000000000000000:mpZATHupfCLqet5N1YL48ByCM1ZBfddbGJ in 306354/005, txid:<PHONE_NUMBER> , trade #12 91.00000000 for #1 18.20000000

Note they're the same address but this is permitted (quoting spec)

The protocol then finds existing sell orders that qualify (match), possibly including existing sell orders from that same address.

I'm itching to get into the nuts and bolts of MetaDEx but am really trying to get through the work I've been assigned first (which I think is getting there) so sorry I'm not being much help with specifics - figured it's best to note these things even if it's just for myself when I can circle back round to it :)

Well, this was sort of expected.. :) I suggest you keep posting any flaws you find, and pin down the underlying issue (or issues).

I'm confused. A unit price of 20'000'000? Shouldn't it be 0.2 TMSC? Sold 10x IndivisibleToken for 0.2 TMSC each (= 2.0 TMSC total).

Clearly something wrong there

Note listing sells via the UI is likely still broken (I haven't looked at refreshing sendTrade() from the old stuff from Dec14 yet)

Oh, you're in regtest mode nevermind hehe

Just sent the same transaction from the UI on testnet, 10 indivisible tokens for 0.2 each - looks OK in pending, will see what happens when it confirms:

Ahh nevermind, I thought I'd got all the divisibility display bugs out yesterday but seems a couple still remain... Working on it..

Hehe, at some point you'll probably look back and wonder: "why didn't I use regtestnet earlier?" :)
Todo note to myself: tutorial for spock + some basic, manual regtest stuff.

at some point you'll probably look back and wonder: "why didn't I use regtestnet earlier?"

Hehe I have no doubt mate, I have no doubt :)
Think https://github.com/zathras-crypto/mastercore/commit/0f5baed3f4faacdbf6c9a3aba44cf62d25a4c349 should sort that price display issue mate.


Add an auth_context_id to the tokens table to allow refresh_tokens to…

Note: new features are to be opened against next, hotfixes against master.
Summary
SUMMARY_GOES_HERE
Full changelog

[Implement ...]
[Add related tests]
...

Issues resolved
Fix #XXX
… be deleted when the same auth_context_id is used (no reclaiming code yet)

merged by 6210685


fix(iOS14): This introduces the new debug service name.

Note: This is totally untested. I based this fix off https://github.com/ios-control/ios-deploy/pull/471/files

@cla-bot check


Don't check is_file when $resource is really long

I came across this while running Spress on a file with a really really long frontmatter.
is_file gives a warning message if you pass in a string of 4096 characters or more. I'm not sure if it's always 4096 characters, or if that's configured somewhere.
It's not completely obvious exactly what this function is supposed to accept, but I've tried to catch the case I saw while allowing non-strings and short strings.

Your fix is right. The value of $resource variable is always a string (I forget to document that) and the intent was to figure out if resource was a filename or a string in YAML format.

Thank you man


Doubts about exchange parameters

I saw from the kombu project that the exchange parameter needs to be an Exchange instance: https://github.com/celery/kombu/blob/main/kombu/entity.py#L410
Why does agency use strings: https://github.com/operand/agency/blob/main/agency/spaces/amqp_space.py#L104
In agency 1.3, it is topic Exchange: https://github.com/operand/agency/blob/v1.3.0/agency/spaces/amqp_space.py#L51
.
For what purpose does agency 1.4 adjust it?

Good catch. I think I made this change without much thought. The code went through a lot of refactoring as I worked this out. I'll work on a PR to change this back.

Thanks, using string exchange is equivalent to using direct exchange, which will make MQTT unusable and receive_logs_topic.py will also be broken. If there is no particular reason, it seems good to use topic exchange.

I merged a PR that should hopefully fix the issue with MQTT - https://github.com/operand/agency/pull/139
I can't test MQTT myself so could you confirm that the main branch works for you? I can publish the update to the pypi package if you need to test it that way.

It works for me！Thanks！

Thanks, using string exchange is equivalent to using direct exchange, which will make MQTT unusable and receive_logs_topic.py will also be broken. If there is no particular reason, it seems good to use topic exchange.

@operand Using topic exchange seems to bring more flexibility

Reopening this issue.
I was thinking about how we could best support this. It seems like a common enough need to want to observe all messages in a space, that we might want to add something explicit in the API. Maybe a way to register a callback method in the Space class like the following?
class MySpace(Space):
  def register_listener(self, callable):
    ...

and you'd use it like:
def on_message(message)
  print(message)

myspace = MySpace()
myspace.register_observer(on_message)

What do you think?

I was thinking about how we could best support this. It seems like a common enough need to want to observe all messages in a space, that we might want to add something explicit in the API. Maybe a way to register a callback method in the Space class like the following?

I think it is best for message observers to be independent of Space. When Space is deployed in a production environment, it is inconvenient to write observation code in Space.
RabbitMQ is essentially a network service. We can extend probes into the message flow at any time. Working at the RabbitMQ level seems more flexible and easier.
The requirements for observing messages may be diverse. Pattern matching of messages can bring great benefits. Imagine that I want to observe all robots: *_robot. In this way, it matches a_robot, b_robot.
This is why I prefer topic exchange.

Another reason why a message observer should not be coupled into a Space is that a message observer can never be corrupted, it should just observe and do nothing else. When the system is broken (such as the Space itself is broken) through the message observer, we can usually get very valuable information, such as what the last message was, which hints at the part closest to the bug. If a message observer is associated with a Space, a crash of the Space will destroy it.

In a distributed system, we may have multiple Spaces, and the message observer may not be written in any one space. Instead, it needs to be able to observe the direct message flow of the agents in these spaces at the same time. This seems to be the reason why message wildcards are needed.

I'm struggling with whether this is AMQP specific, or if we can generalize it, but I actually don't think it will generalize to all potential Space implementations.
So I'll see about updating to use a topic exchange which will unblock you. This observer idea might come back but we'll wait and see. It might be easy to open a PR for this if you're feeling adventurous! The tests are pretty good at catching things. Otherwise give me a few, I'll get to this as soon as I can.

I'm struggling with whether this is AMQP specific, or if we can generalize it, but I actually don't think it will generalize to all potential Space implementations.

It seems that most messaging systems have a similar wildcard mechanism:

AMQP: there are two important special cases for binding keys
MQTT: What Are MQTT Wildcards and How to Use Them With Topic Subscriptions?
ZeroMQ: High-speed message matching

I currently implement two message observers based on AMQP and MQTT. The codes are almost the same.
I'll try to submit a PR later.

Yeah and maybe that means we're bound to those kinds of systems. I'm not sure yet. The idea of broadcasting is also a special need by this framework that requires those kinds of APIs...
Thanks for working on a PR. Hit me up here or on discord if you need a hand!

Alright that was a quick turnaround! Closing the issue again. 😄


Setup deployment pipeline for Azure functions

Added with commit  https://github.com/jguadagno/jjgnet-broadcast/commit/5a04cb7cf2f36410341e009de1e4513f3141367e


U2F support for hardware tokens like YubiKey

Feature Request
As a user, I would like to login to my account using my YubiKey's U2F functionality.
Feature Information:
U2F is a separate function from an OTP app. For broader support of MFA, adding support for U2F can increase security for organizations wanting increased security where an app-based OTP may not be feasible.
Instead of provide a OTP, the user would instead be prompted to touch the U2F device. In keeping with best practices, the user should be able to manage and enroll multiple U2F devices.
I confirm:

[x ] that I have searched for an existing feature request matching the description.

U2F support is something that has been debated in the past and was decided at the time that it wasn't worth the effort for the small bomber of users that would actually utilize it.  That was back when 2FA was first implemented though and things have changed so it may be considered again... assuming there's an effective way to implement it that isn't riddled with security holes.

This is being implemented! We're using the modern equivalent of U2F called Webauthn. This retains compatibility with devices like the Yubikey, but also allows support for biometrics and mobile device logins.


Refactor Frontend Authentication

This Pull Request refactors the frontend react app authentication using redux library.

Thanks @arteevraina looks great.


Update LED usage

Proposed plan:

LED A: USB switch is in Apollo/Saturn-V mode (see #38)
LED B: FPGA is being held offline
LED C: Saturn-V heartbeat
LED D: FPGA fault, e.g. failed to configure from flash
LED E: Apollo heartbeat

All LEDs would change function temporarily if a pattern other than idle is in use. The idle pattern would restore the indications above.

Personally I would love it if the LEDs would stop flashing when nothing is happening (e.g. Apollo is idle and a bitstream is running OK). To me, flashing means something is wrong and it wants attention.


docs: added api key setup to readme

Codecov Report

Merging #29 (dba9b85) into dev (37faa7c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev      #29   +/-   ##
=======================================
  Coverage   85.71%   85.71%
=======================================
  Files           1        1
  Lines           7        7
=======================================
  Hits            6        6
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c0da84...dba9b85. Read the comment docs.

cannot get the file to change in pr.