Suggestion: Area

Add Area of the Rect. and maybe percentage of screen space it takes up.

metric measures would be nice cause i am measuring pdf for print ;-)
margin measure is in mm


fix backspacing single digit percentages (issue #174)

fix(PercentageMaskDirective): Detect and handle backspace keypresses

Detect when the backspace key is being pressed and handle appropriately. Previously, if a single digit percent was the value, you could not backspace it out. This corrects that handling. Code coverage may have gone down due to not being able to test directly for a keypress, resulting in two lines of code that aren't covered.
Cannot use a test to break this, but created a test that specifically tests for this scenario. Previous tests did not cover this possibility.

Closes #174.
No breaking changes.

Changes Unknown when pulling e5181539728fe49caaaccb5c83b4b914821a2ad6 on nloding:master into ** on assisrafael:master**.

Thank you for the pull request!


how to use remote_schema_headers ?

I don't understand how to configure remote_schema_headers in pyproject.toml.
Something like
[tool.ariadne-codegen]
schema_path = "schema.graphql"
queries_path = "queries.graphql"
remote_schema_headers = {"Authorization" = "Bearer: token"}

isn't even valid toml.
Could anyone kindly share an example ?

Sorry, my bad. Never mind.


WFLY-9547, WFLY-9548 Clustering API enhancements

https://issues.jboss.org/browse/WFLY-9547
https://issues.jboss.org/browse/WFLY-9548
This PR addresses transient failures in the clustering testsuite as seen in:
https://ci.wildfly.org/viewLog.html?buildId=81831&buildTypeId=WF_PullRequest_Windows

Is this a change to a public-to-an-end-user API, aka a Feature?

@bstansberry It's a change to public API, but there's no feature being added.  All changes are binary/source compatible with previous releases.
This stuff is already fully covered by our existing clustering API tests:
https://github.com/wildfly/wildfly/tree/master/testsuite/integration/clustering/src/test/java/org/jboss/as/test/clustering/cluster/dispatcher
https://github.com/wildfly/wildfly/tree/master/testsuite/integration/clustering/src/test/java/org/jboss/as/test/clustering/cluster/provider
https://github.com/wildfly/wildfly/tree/master/testsuite/integration/clustering/src/test/java/org/jboss/as/test/clustering/cluster/registry
https://github.com/wildfly/wildfly/tree/master/testsuite/integration/clustering/src/test/java/org/jboss/as/test/clustering/local/dispatcher
https://github.com/wildfly/wildfly/tree/master/testsuite/integration/clustering/src/test/java/org/jboss/as/test/clustering/local/provider
https://github.com/wildfly/wildfly/tree/master/testsuite/integration/clustering/src/test/java/org/jboss/as/test/clustering/local/registry

@pferraro @rhusar When I put this and the CommandRPC one on master-ignore there was a failure:
https://ci.wildfly.org/viewLog.html?buildId=82256&tab=buildResultsDiv&buildTypeId=WF_MasterIgnoreLinux
That test has been failing off and on for the past week so I'll merge this anyway, but that one should be sorted. 8 failures in the last week; maybe more if I checked the CI jobs for WFCORE.

@bstansberry Thanks, we are aware of the issue and working on it. If I could I would mute the test until we figure it out.


Cross-platform Rasterisation Pen?

Is there a handy way to rasterise the paths obtained via pen protocol in a cross-platform manner?

CocoaPen/QuartzPen is pretty handy unless you are on a non-macOS environment (e.g. Google Colab)
QtPen/WxPen is useful only if it's already used within your codebase as a widget toolkit
skia-pathops is a library dedicated to boolean operations but not for drawing

I might be missing something, but I couldn't find a solution that fully suits my needs. After all, I wrote a pen that finds the existing FreeType installation on the system, constructs FT_Outline and let FreeType rasterise the paths. As mentioned in #1769, I agree this is out of scope, but on the other hand I think it makes more sense to wrap it as a pen. If you are interested, I'll share and compile a PR.

I think it would be nice to have a pen that uses freetype-py to rasterize a glyph, yes please send a PR thanks!

Thanks for the comment! I've just sent a PR, and please  have a look when you have time.


segmentation violation when reading 1GB tuple

Using
df_new = read_root(signal_file_name, signal_tree_name)
i get a segmentation violation with the following stack trace:
*** Break *** segmentation violation
===========================================================
There was a crash.
This is the entire stack trace of all threads:
===========================================================

Thread 11 (Thread 0x7f5b27a8f700 (LWP 40581)):
#0  0x000000334540d930 in sem_wait () from /lib64/libpthread.so.0
#1  0x00007f5b32b22af8 in PyThread_acquire_lock (lock=0x7f5b20013df0, waitflag=<value optimized out>) at Python/thread_pthread.h:324
#2  0x00007f5b32b28344 in lock_PyThread_acquire_lock (self=0x7f5b171e4df0, args=<value optimized out>) at ./Modules/threadmodule.c:52
#3  0x00007f5b32aef153 in call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4033
#4  PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#5  0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b2bf54330, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=2, kws=0x7f5b27ec63b8, kwcount=0, defs=0x7f5b2bf602a8, defcount=1, closure=0x0) at Python/ceval.c:3265
#6  0x00007f5b32aef2aa in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4129
#7  call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#8  PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#9  0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b2bf54db0, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=1, kws=0x7f5b27ebeec8, kwcount=0, defs=0x7f5b2bf60468, defcount=1, closure=0x0) at Python/ceval.c:3265
#10 0x00007f5b32aef2aa in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4129
#11 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#12 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#13 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b28b885b0, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=1, kws=0x7f5b329a5068, kwcount=0, defs=0x0, defcount=0, closure=0x0) at Python/ceval.c:3265
#14 0x00007f5b32a6e958 in function_call (func=0x7f5b28b9e2a8, arg=0x7f5b3269f950, kw=0x7f5b27ee55c8) at Objects/funcobject.c:526
#15 0x00007f5b32a3f323 in PyObject_Call (func=0x7f5b28b9e2a8, arg=<value optimized out>, kw=<value optimized out>) at Objects/abstract.c:2529
#16 0x00007f5b32aed865 in ext_do_call (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4346
#17 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2718
#18 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b28be1730, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=2, kws=0x7f5b27ec4c68, kwcount=0, defs=0x0, defcount=0, closure=0x0) at Python/ceval.c:3265
#19 0x00007f5b32aef2aa in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4129
#20 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#21 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#22 0x00007f5b32aef600 in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4119
#23 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#24 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#25 0x00007f5b32aef600 in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4119
#26 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#27 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#28 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b2bf59330, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=1, kws=0x0, kwcount=0, defs=0x0, defcount=0, closure=0x0) at Python/ceval.c:3265
#29 0x00007f5b32a6e851 in function_call (func=0x7f5b2bf64668, arg=0x7f5b3269f850, kw=0x0) at Objects/funcobject.c:526
#30 0x00007f5b32a3f323 in PyObject_Call (func=0x7f5b2bf64668, arg=<value optimized out>, kw=<value optimized out>) at Objects/abstract.c:2529
#31 0x00007f5b32a5195f in instancemethod_call (func=0x7f5b2bf64668, arg=0x7f5b3269f850, kw=0x0) at Objects/classobject.c:2602
#32 0x00007f5b32a3f323 in PyObject_Call (func=0x7f5b28c15410, arg=<value optimized out>, kw=<value optimized out>) at Objects/abstract.c:2529
#33 0x00007f5b32ae8823 in PyEval_CallObjectWithKeywords (func=0x7f5b28c15410, arg=0x7f5b329a5050, kw=<value optimized out>) at Python/ceval.c:3902
#34 0x00007f5b32b28832 in t_bootstrap (boot_raw=<value optimized out>) at ./Modules/threadmodule.c:614
#35 0x00000033454079d1 in start_thread () from /lib64/libpthread.so.0
#36 0x00000033450e88fd in clone () from /lib64/libc.so.6

Thread 10 (Thread 0x7f5b1d906700 (LWP 40587)):
#0  0x000000334540b5bc in pthread_cond_wait

GLIBC_2.3.2 () from /lib64/libpthread.so.0
#1  0x00007f5b1dc85648 in th_worker (tidptr=<value optimized out>) at numexpr/module.cpp:57
#2  0x00000033454079d1 in start_thread () from /lib64/libpthread.so.0
#3  0x00000033450e88fd in clone () from /lib64/libc.so.6

Thread 9 (Thread 0x7f5b1cf05700 (LWP 40590)):
#0  0x000000334540b5bc in pthread_cond_wait

GLIBC_2.3.2 () from /lib64/libpthread.so.0
#1  0x00007f5b1dc85648 in th_worker (tidptr=<value optimized out>) at numexpr/module.cpp:57
#2  0x00000033454079d1 in start_thread () from /lib64/libpthread.so.0
#3  0x00000033450e88fd in clone () from /lib64/libc.so.6

Thread 8 (Thread 0x7f5b1c504700 (LWP 40591)):
#0  0x000000334540b5bc in pthread_cond_wait

GLIBC_2.3.2 () from /lib64/libpthread.so.0
#1  0x00007f5b1dc85648 in th_worker (tidptr=<value optimized out>) at numexpr/module.cpp:57
#2  0x00000033454079d1 in start_thread () from /lib64/libpthread.so.0
#3  0x00000033450e88fd in clone () from /lib64/libc.so.6

Thread 7 (Thread 0x7f5b1bb03700 (LWP 40592)):
#0  0x000000334540b5bc in pthread_cond_wait

GLIBC_2.3.2 () from /lib64/libpthread.so.0
#1  0x00007f5b1dc85648 in th_worker (tidptr=<value optimized out>) at numexpr/module.cpp:57
#2  0x00000033454079d1 in start_thread () from /lib64/libpthread.so.0
#3  0x00000033450e88fd in clone () from /lib64/libc.so.6

Thread 6 (Thread 0x7f5b1b102700 (LWP 40593)):
#0  0x000000334540b5bc in pthread_cond_wait

GLIBC_2.3.2 () from /lib64/libpthread.so.0
#1  0x00007f5b1dc85648 in th_worker (tidptr=<value optimized out>) at numexpr/module.cpp:57
#2  0x00000033454079d1 in start_thread () from /lib64/libpthread.so.0
#3  0x00000033450e88fd in clone () from /lib64/libc.so.6

Thread 5 (Thread 0x7f5b1a701700 (LWP 40594)):
#0  0x000000334540b5bc in pthread_cond_wait

GLIBC_2.3.2 () from /lib64/libpthread.so.0
#1  0x00007f5b1dc85648 in th_worker (tidptr=<value optimized out>) at numexpr/module.cpp:57
#2  0x00000033454079d1 in start_thread () from /lib64/libpthread.so.0
#3  0x00000033450e88fd in clone () from /lib64/libc.so.6

Thread 4 (Thread 0x7f5b19d00700 (LWP 40596)):
#0  0x000000334540b5bc in pthread_cond_wait

GLIBC_2.3.2 () from /lib64/libpthread.so.0
#1  0x00007f5b1dc85648 in th_worker (tidptr=<value optimized out>) at numexpr/module.cpp:57
#2  0x00000033454079d1 in start_thread () from /lib64/libpthread.so.0
#3  0x00000033450e88fd in clone () from /lib64/libc.so.6

Thread 3 (Thread 0x7f5b192ff700 (LWP 40598)):
#0  0x000000334540b5bc in pthread_cond_wait

GLIBC_2.3.2 () from /lib64/libpthread.so.0
#1  0x00007f5b1dc85648 in th_worker (tidptr=<value optimized out>) at numexpr/module.cpp:57
#2  0x00000033454079d1 in start_thread () from /lib64/libpthread.so.0
#3  0x00000033450e88fd in clone () from /lib64/libc.so.6

Thread 2 (Thread 0x7f5b0eee1700 (LWP 40616)):
#0  0x000000334540d930 in sem_wait () from /lib64/libpthread.so.0
#1  0x00007f5b32b22af8 in PyThread_acquire_lock (lock=0x1a8cda0, waitflag=<value optimized out>) at Python/thread_pthread.h:324
#2  0x00007f5b32ae9474 in PyEval_RestoreThread (tstate=0x3ba9790) at Python/ceval.c:357
#3  0x00007f5b2c18745f in floatsleep (self=<value optimized out>, args=<value optimized out>) at -------src-dir-------/Python-2.7.9/Modules/timemodule.c:959
#4  time_sleep (self=<value optimized out>, args=<value optimized out>) at -------src-dir-------/Python-2.7.9/Modules/timemodule.c:206
#5  0x00007f5b32aef153 in call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4033
#6  PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#7  0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b16d29e30, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=1, kws=0x7f5b329a5068, kwcount=0, defs=0x0, defcount=0, closure=0x0) at Python/ceval.c:3265
#8  0x00007f5b32a6e958 in function_call (func=0x7f5b11ab47d0, arg=0x7f5b18826050, kw=0x7f5b119bc050) at Objects/funcobject.c:526
#9  0x00007f5b32a3f323 in PyObject_Call (func=0x7f5b11ab47d0, arg=<value optimized out>, kw=<value optimized out>) at Objects/abstract.c:2529
#10 0x00007f5b32aed865 in ext_do_call (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4346
#11 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2718
#12 0x00007f5b32aef600 in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4119
#13 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#14 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#15 0x00007f5b32aef600 in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4119
#16 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#17 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#18 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b2bf59330, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=1, kws=0x0, kwcount=0, defs=0x0, defcount=0, closure=0x0) at Python/ceval.c:3265
#19 0x00007f5b32a6e851 in function_call (func=0x7f5b2bf64668, arg=0x7f5b188260d0, kw=0x0) at Objects/funcobject.c:526
#20 0x00007f5b32a3f323 in PyObject_Call (func=0x7f5b2bf64668, arg=<value optimized out>, kw=<value optimized out>) at Objects/abstract.c:2529
#21 0x00007f5b32a5195f in instancemethod_call (func=0x7f5b2bf64668, arg=0x7f5b188260d0, kw=0x0) at Objects/classobject.c:2602
#22 0x00007f5b32a3f323 in PyObject_Call (func=0x7f5b17dd6eb0, arg=<value optimized out>, kw=<value optimized out>) at Objects/abstract.c:2529
#23 0x00007f5b32ae8823 in PyEval_CallObjectWithKeywords (func=0x7f5b17dd6eb0, arg=0x7f5b329a5050, kw=<value optimized out>) at Python/ceval.c:3902
#24 0x00007f5b32b28832 in t_bootstrap (boot_raw=<value optimized out>) at ./Modules/threadmodule.c:614
#25 0x00000033454079d1 in start_thread () from /lib64/libpthread.so.0
#26 0x00000033450e88fd in clone () from /lib64/libc.so.6

Thread 1 (Thread 0x7f5b329e6700 (LWP 40578)):
#0  0x00000033450ac65d in waitpid () from /lib64/libc.so.6
#1  0x000000334503e609 in do_system () from /lib64/libc.so.6
#2  0x000000334503e940 in system () from /lib64/libc.so.6
#3  0x00007f5b162f40cf in TUnixSystem::StackTrace() () from /afs/cern.ch/sw/lcg/app/releases/ROOT/5.34.28/x86_64-slc6-gcc48-opt/root/lib/libCore.so
#4  0x00007f5b162f5c3c in TUnixSystem::DispatchSignals(ESignals) () from /afs/cern.ch/sw/lcg/app/releases/ROOT/5.34.28/x86_64-slc6-gcc48-opt/root/lib/libCore.so
#5  <signal handler called>
#6  0x00007f5b26465148 in PyArray_Item_XDECREF (data=0x7f5aac493010 "\345{\230\345\225w\250?kυ\t\317\024\v
", descr=0x7f5b0e48cce8) at numpy/core/src/multiarray/refcount.c:71
#7  PyArray_Item_XDECREF (data=0x7f5aac493010 "\345{\230\345\225w\250?kυ\t\317\024\v
", descr=0x7f5b0e48cce8) at numpy/core/src/multiarray/refcount.c:87
#8  0x00007f5b264653cf in PyArray_XDECREF (mp=0x7f5b0e48ead0) at numpy/core/src/multiarray/refcount.c:173
#9  0x00007f5b2637bc84 in array_dealloc (self=0x7f5b0e48ead0) at numpy/core/src/multiarray/arrayobject.c:417
#10 0x00007f5b32a8410b in dict_dealloc (mp=0x7f5b07ff9910) at Objects/dictobject.c:1010
#11 0x00007f5b32a6d6b7 in frame_dealloc (f=0x3bd5d60) at Objects/frameobject.c:471
#12 0x00007f5b32b187bb in tb_dealloc (tb=0x7f5b11a156c8) at Python/traceback.c:28
#13 0x00007f5b32b187cb in tb_dealloc (tb=0x7f5b11a15bd8) at Python/traceback.c:27
#14 0x00007f5b32b187cb in tb_dealloc (tb=0x7f5b11a155f0) at Python/traceback.c:27
#15 0x00007f5b32a82047 in insertdict_by_entry (mp=0x7f5b269dc050, key=0x7f5b329abaf8, hash=<value optimized out>, ep=<value optimized out>, value=<value optimized out>) at Objects/dictobject.c:519
#16 0x00007f5b32a8549c in insertdict (op=0x7f5b269dc050, key=0x7f5b329abaf8, value=0x7f5b11a337e8) at Objects/dictobject.c:556
#17 dict_set_item_by_hash_or_entry (op=0x7f5b269dc050, key=0x7f5b329abaf8, value=0x7f5b11a337e8) at Objects/dictobject.c:765
#18 PyDict_SetItem (op=0x7f5b269dc050, key=0x7f5b329abaf8, value=0x7f5b11a337e8) at Objects/dictobject.c:818
#19 0x00007f5b32a89d65 in _PyObject_GenericSetAttrWithDict (obj=<value optimized out>, name=0x7f5b329abaf8, value=0x7f5b11a337e8, dict=0x7f5b269dc050) at Objects/object.c:1529
#20 0x00007f5b32a8a257 in PyObject_SetAttr (v=0x7f5b29386e10, name=0x7f5b329abaf8, value=0x7f5b11a337e8) at Objects/object.c:1252
#21 0x00007f5b32aebf16 in PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2013
#22 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b29417c30, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=4, kws=0x654bcfa0, kwcount=1, defs=0x7f5b2940c908, defcount=5, closure=0x0) at Python/ceval.c:3265
#23 0x00007f5b32aef2aa in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4129
#24 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#25 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#26 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b28bbe6b0, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=1, kws=0x65676ec8, kwcount=0, defs=0x7f5b28666640, defcount=4, closure=0x0) at Python/ceval.c:3265
#27 0x00007f5b32aef2aa in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4129
#28 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#29 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#30 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b28bce1b0, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=3, kws=0x3bd35f0, kwcount=0, defs=0x7f5b2866eca8, defcount=1, closure=0x0) at Python/ceval.c:3265
#31 0x00007f5b32aef2aa in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4129
#32 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#33 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#34 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b28bce0b0, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=3, kws=0x3bd2420, kwcount=3, defs=0x7f5b28ba3888, defcount=3, closure=0x0) at Python/ceval.c:3265
#35 0x00007f5b32aef2aa in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4129
#36 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#37 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#38 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b28bc5f30, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=2, kws=0x7f5b269b8410, kwcount=1, defs=0x7f5b28ba3838, defcount=3, closure=0x0) at Python/ceval.c:3265
#39 0x00007f5b32aef2aa in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4129
#40 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#41 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#42 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b2867a330, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=1, kws=0x1c4c360, kwcount=1, defs=0x7f5b28ba7e28, defcount=1, closure=0x0) at Python/ceval.c:3265
#43 0x00007f5b32aef2aa in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4129
#44 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#45 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#46 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b2867a230, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=1, kws=0x7f5b2819a7c0, kwcount=0, defs=0x7f5b28ba7de8, defcount=1, closure=0x0) at Python/ceval.c:3265
#47 0x00007f5b32aef2aa in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4129
#48 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#49 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#50 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b28685c30, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=1, kws=0x7f5b2843cea0, kwcount=0, defs=0x0, defcount=0, closure=0x0) at Python/ceval.c:3265
#51 0x00007f5b32aef2aa in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4129
#52 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#53 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#54 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b2c79f330, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=1, kws=0x7f5b32670848, kwcount=1, defs=0x7f5b29404068, defcount=1, closure=0x0) at Python/ceval.c:3265
#55 0x00007f5b32a6e958 in function_call (func=0x7f5b29403848, arg=0x7f5b3267f310, kw=0x7f5b28176b40) at Objects/funcobject.c:526
#56 0x00007f5b32a3f323 in PyObject_Call (func=0x7f5b29403848, arg=<value optimized out>, kw=<value optimized out>) at Objects/abstract.c:2529
#57 0x00007f5b32aed865 in ext_do_call (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4346
#58 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2718
#59 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b32689130, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=0, kws=0x7f5b329ce388, kwcount=0, defs=0x7f5b3269ffa8, defcount=1, closure=0x0) at Python/ceval.c:3265
#60 0x00007f5b32aef2aa in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4129
#61 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#62 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#63 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b328ddc30, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=0, kws=0x0, kwcount=0, defs=0x0, defcount=0, closure=0x0) at Python/ceval.c:3265
#64 0x00007f5b32af0d82 in PyEval_EvalCode (co=<value optimized out>, globals=<value optimized out>, locals=<value optimized out>) at Python/ceval.c:667
#65 0x00007f5b32b10ba0 in run_mod (fp=0x18ce560, filename=<value optimized out>, start=<value optimized out>, globals=0x7f5b3297a168, locals=0x7f5b3297a168, closeit=1, flags=0x7fff552d80d0) at Python/pythonrun.c:1371
#66 PyRun_FileExFlags (fp=0x18ce560, filename=<value optimized out>, start=<value optimized out>, globals=0x7f5b3297a168, locals=0x7f5b3297a168, closeit=1, flags=0x7fff552d80d0) at Python/pythonrun.c:1357
#67 0x00007f5b32b10d7f in PyRun_SimpleFileExFlags (fp=0x18ce560, filename=0x7fff552d97ac "/home/rniet/anaconda/bin/ipython", closeit=1, flags=0x7fff552d80d0) at Python/pythonrun.c:949
#68 0x00007f5b32b26664 in Py_Main (argc=<value optimized out>, argv=<value optimized out>) at Modules/main.c:645
#69 0x000000334501ed5d in __libc_start_main () from /lib64/libc.so.6
#70 0x0000000000400649 in _start ()
===========================================================

The lines below might hint at the cause of the crash.
If they do not help you then please submit a bug report at
http://root.cern.ch/bugs. Please post the ENTIRE stack trace
from above as an attachment in addition to anything else
that might help us fixing this issue.
===========================================================
#6  0x00007f5b26465148 in PyArray_Item_XDECREF (data=0x7f5aac493010 "345{230345225w250?kυt317024v
", descr=0x7f5b0e48cce8) at numpy/core/src/multiarray/refcount.c:71
#7  PyArray_Item_XDECREF (data=0x7f5aac493010 "345{230345225w250?kυt317024v
", descr=0x7f5b0e48cce8) at numpy/core/src/multiarray/refcount.c:87
#8  0x00007f5b264653cf in PyArray_XDECREF (mp=0x7f5b0e48ead0) at numpy/core/src/multiarray/refcount.c:173
#9  0x00007f5b2637bc84 in array_dealloc (self=0x7f5b0e48ead0) at numpy/core/src/multiarray/arrayobject.c:417
#10 0x00007f5b32a8410b in dict_dealloc (mp=0x7f5b07ff9910) at Objects/dictobject.c:1010
#11 0x00007f5b32a6d6b7 in frame_dealloc (f=0x3bd5d60) at Objects/frameobject.c:471
#12 0x00007f5b32b187bb in tb_dealloc (tb=0x7f5b11a156c8) at Python/traceback.c:28
#13 0x00007f5b32b187cb in tb_dealloc (tb=0x7f5b11a15bd8) at Python/traceback.c:27
#14 0x00007f5b32b187cb in tb_dealloc (tb=0x7f5b11a155f0) at Python/traceback.c:27
#15 0x00007f5b32a82047 in insertdict_by_entry (mp=0x7f5b269dc050, key=0x7f5b329abaf8, hash=<value optimized out>, ep=<value optimized out>, value=<value optimized out>) at Objects/dictobject.c:519
#16 0x00007f5b32a8549c in insertdict (op=0x7f5b269dc050, key=0x7f5b329abaf8, value=0x7f5b11a337e8) at Objects/dictobject.c:556
#17 dict_set_item_by_hash_or_entry (op=0x7f5b269dc050, key=0x7f5b329abaf8, value=0x7f5b11a337e8) at Objects/dictobject.c:765
#18 PyDict_SetItem (op=0x7f5b269dc050, key=0x7f5b329abaf8, value=0x7f5b11a337e8) at Objects/dictobject.c:818
#19 0x00007f5b32a89d65 in _PyObject_GenericSetAttrWithDict (obj=<value optimized out>, name=0x7f5b329abaf8, value=0x7f5b11a337e8, dict=0x7f5b269dc050) at Objects/object.c:1529
#20 0x00007f5b32a8a257 in PyObject_SetAttr (v=0x7f5b29386e10, name=0x7f5b329abaf8, value=0x7f5b11a337e8) at Objects/object.c:1252
#21 0x00007f5b32aebf16 in PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2013
#22 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b29417c30, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=4, kws=0x654bcfa0, kwcount=1, defs=0x7f5b2940c908, defcount=5, closure=0x0) at Python/ceval.c:3265
#23 0x00007f5b32aef2aa in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4129
#24 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#25 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#26 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b28bbe6b0, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=1, kws=0x65676ec8, kwcount=0, defs=0x7f5b28666640, defcount=4, closure=0x0) at Python/ceval.c:3265
#27 0x00007f5b32aef2aa in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4129
#28 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#29 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#30 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b28bce1b0, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=3, kws=0x3bd35f0, kwcount=0, defs=0x7f5b2866eca8, defcount=1, closure=0x0) at Python/ceval.c:3265
#31 0x00007f5b32aef2aa in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4129
#32 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#33 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#34 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b28bce0b0, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=3, kws=0x3bd2420, kwcount=3, defs=0x7f5b28ba3888, defcount=3, closure=0x0) at Python/ceval.c:3265
#35 0x00007f5b32aef2aa in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4129
#36 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#37 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#38 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b28bc5f30, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=2, kws=0x7f5b269b8410, kwcount=1, defs=0x7f5b28ba3838, defcount=3, closure=0x0) at Python/ceval.c:3265
#39 0x00007f5b32aef2aa in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4129
#40 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#41 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#42 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b2867a330, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=1, kws=0x1c4c360, kwcount=1, defs=0x7f5b28ba7e28, defcount=1, closure=0x0) at Python/ceval.c:3265
#43 0x00007f5b32aef2aa in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4129
#44 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#45 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#46 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b2867a230, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=1, kws=0x7f5b2819a7c0, kwcount=0, defs=0x7f5b28ba7de8, defcount=1, closure=0x0) at Python/ceval.c:3265
#47 0x00007f5b32aef2aa in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4129
#48 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#49 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#50 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b28685c30, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=1, kws=0x7f5b2843cea0, kwcount=0, defs=0x0, defcount=0, closure=0x0) at Python/ceval.c:3265
#51 0x00007f5b32aef2aa in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4129
#52 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#53 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#54 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b2c79f330, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=1, kws=0x7f5b32670848, kwcount=1, defs=0x7f5b29404068, defcount=1, closure=0x0) at Python/ceval.c:3265
#55 0x00007f5b32a6e958 in function_call (func=0x7f5b29403848, arg=0x7f5b3267f310, kw=0x7f5b28176b40) at Objects/funcobject.c:526
#56 0x00007f5b32a3f323 in PyObject_Call (func=0x7f5b29403848, arg=<value optimized out>, kw=<value optimized out>) at Objects/abstract.c:2529
#57 0x00007f5b32aed865 in ext_do_call (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4346
#58 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2718
#59 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b32689130, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=0, kws=0x7f5b329ce388, kwcount=0, defs=0x7f5b3269ffa8, defcount=1, closure=0x0) at Python/ceval.c:3265
#60 0x00007f5b32aef2aa in fast_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4129
#61 call_function (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:4054
#62 PyEval_EvalFrameEx (f=<value optimized out>, throwflag=<value optimized out>) at Python/ceval.c:2679
#63 0x00007f5b32af0c6e in PyEval_EvalCodeEx (co=0x7f5b328ddc30, globals=<value optimized out>, locals=<value optimized out>, args=<value optimized out>, argcount=0, kws=0x0, kwcount=0, defs=0x0, defcount=0, closure=0x0) at Python/ceval.c:3265
#64 0x00007f5b32af0d82 in PyEval_EvalCode (co=<value optimized out>, globals=<value optimized out>, locals=<value optimized out>) at Python/ceval.c:667
#65 0x00007f5b32b10ba0 in run_mod (fp=0x18ce560, filename=<value optimized out>, start=<value optimized out>, globals=0x7f5b3297a168, locals=0x7f5b3297a168, closeit=1, flags=0x7fff552d80d0) at Python/pythonrun.c:1371
#66 PyRun_FileExFlags (fp=0x18ce560, filename=<value optimized out>, start=<value optimized out>, globals=0x7f5b3297a168, locals=0x7f5b3297a168, closeit=1, flags=0x7fff552d80d0) at Python/pythonrun.c:1357
#67 0x00007f5b32b10d7f in PyRun_SimpleFileExFlags (fp=0x18ce560, filename=0x7fff552d97ac "/home/rniet/anaconda/bin/ipython", closeit=1, flags=0x7fff552d80d0) at Python/pythonrun.c:949
#68 0x00007f5b32b26664 in Py_Main (argc=<value optimized out>, argv=<value optimized out>) at Modules/main.c:645
#69 0x000000334501ed5d in __libc_start_main () from /lib64/libc.so.6
#70 0x0000000000400649 in _start ()
===========================================================

We talked privately about this error back in April.
I've opened an issue with root_numpy here: https://github.com/rootpy/root_numpy/issues/192
The problem was caused by the fact that multidimensional arrays were not supported as a data type.
This has been fixed in May.


Status page rework

[x] #952
[x] #764
[x] #854
[x] #545 via #902
[x] #905

@tedsuo et al. have something in the works. Should we coordinate here? /cc @austinlparker

I'm going to close this since we're enter a new "phase" of rework for the status page, which we'll track via #1574.
/cc @tedsuo


question: best practice for composition of selector functions

Hi,
First of all: Thank you very much for this helpfull demo application!
I have a question about the composition of the selector functions.
In your demo app you define each selector twice, once in the  book/ search reducer and once in the toplevel redurer to compose the 'actual' reducer function with the app state.
At the moment I work at an app which will ultimately consists of 15+ modules each with 10 to 100 components. I'am afraid that if I follow this approach the code in the toplevel reducer will become very difficult to manage.
Besides that, it feels as a bit of overhead to define each selector function twice. Would it be possible to inject the state top-down or is this impossible/bad practice?
What are your recommendations?

You can create index.ts for each modules which contains all top level selectors for that module and import all module/index.ts in the main module index.ts.


[ci] regression tests: binary Dataset format

Summary
This project's continuous integration (CI) should include a job which tests that LightGBM Dataset binary files produced by previous versions can be successfully loaded and used in newer versions.
Specifically, it should test the following claim:

Binary Dataset files produced in LightGBM version (N).x.x should be readable and usable in all versions in the same major version series.

It should also include tests of expected compatibility between other versions. For example, if 4.0.0 does not include breaking changes to saving / loading of Dataset files, then a test should be added that such a file created in LightGBM 3.2.1 can be loaded in LightGBM 4.0.0
Motivation
LightGBM uses semantic versioning for releases. As a result, users expect that there will not be breaking changes within a major release series. For example, they expect that a Dataset saved to a binary file using LightGBM 3.1.0 will be readable in any other LightGBM 3.x.x release.
Adding explicit tests on that fact might provide greater confidence that releases are not introducing such changes.
Description
LightGBM performs several preprocessing steps on training data before beginning the boosting process. Those steps are performed in the construction of a Dataset object, a LightGBM-specific format for training data.
To support use cases like hyperparameter tuning, where users want to train many models using the same Dataset, LightGBM can save a constructed Dataset to a binary file.
https://github.com/microsoft/LightGBM/blob/0701a32da9fae7b2de8a01d702fa7d6abf36e836/src/c_api.cpp#L1435
That Dataset can then be loaded back and used for training, without repeating those pre-processing steps.
https://github.com/microsoft/LightGBM/blob/0701a32da9fae7b2de8a01d702fa7d6abf36e836/src/c_api.cpp#L897
References
Created based on https://github.com/microsoft/LightGBM/pull/4228#issuecomment-830706993.

This issue has been added to #2302 with other feature requests. I'd like to leave it open for a few days in case others want to add comments, since I just locked discussion on #4228.
After a few days, this issue will be closed until someone leaves a comment saying they'd like to work on it.

Ok now that this has been open for a few days, I am going to close it. If you're reading this and would like to work on this, please comment below and it can be re-opened!


How to check if simulcast has been enabled?

Does the statsReport.localVideoTrackStats inside StatsViewController.m contain all the temporal layers of a VP8 Simulcast VideoTrack? The trackCount is always 1.
It looks like there was an issue which was fixed in the javascript sdk (https://github.com/twilio/twilio-video.js/blob/master/CHANGELOG.md#272-august-12-2020)
Is there any other way to check if simulcast has been enabled?

Hi @simbara,
The iOS SDK does not provide a way to determine if simulcast is enabled. However you could verify that ConnectOptions is configured properly before connecting to a room.


Change the drain strategy to immediate

During drain Envoy notifies clients using GO-AWAY or connection:close (or other protocol specific methods).
The default is to gradually notify clients, this changes it to immediately notify clients.
The drain duration is unaffected, just that clients have more time to gracefully react to impending termination.

@mandarjog: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
8fb95e1299551439e20348b2915880d471a7edb9
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
8fb95e1299551439e20348b2915880d471a7edb9
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
8fb95e1299551439e20348b2915880d471a7edb9
link
/test release-notes_istio

unit-tests_istio
8fb95e1299551439e20348b2915880d471a7edb9
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
8fb95e1299551439e20348b2915880d471a7edb9
link
/test release-notes_istio

unit-tests_istio
8fb95e1299551439e20348b2915880d471a7edb9
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

i remember we donot have hot restart now

i remember we donot have hot restart now

drain still happens when listener/cluster changes and when the pod shuts
down
On Fri, Jan 29, 2021, 6:06 PM Zhonghu Xu<EMAIL_ADDRESS>wrote:

i remember we donot have hot restart now
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/30521#issuecomment-770137402, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXMMZCE4LNHYITDQ3HDS4NSQTANCNFSM4WZTX67A
.

drain still happens when listener/cluster changes and when the pod shuts
down
On Fri, Jan 29, 2021, 6:06 PM Zhonghu Xu<EMAIL_ADDRESS>wrote:

i remember we donot have hot restart now
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/30521#issuecomment-770137402, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXMMZCE4LNHYITDQ3HDS4NSQTANCNFSM4WZTX67A
.

LGTM

LGTM

@mandarjog test needs an update

@mandarjog test needs an update

@mandarjog: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
8fb95e1299551439e20348b2915880d471a7edb9
link
/test unit-tests_istio

release-notes_istio
12d86ac48c0df5121f2648a0a216d3ca2b0b47bf
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
d8848513c9c9bf7257d6b29f52ffcc30c70fc813
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
d8848513c9c9bf7257d6b29f52ffcc30c70fc813
link
/test release-notes_istio

integ-ipv6-k8s-tests_istio
d8848513c9c9bf7257d6b29f52ffcc30c70fc813
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

@mandarjog: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
d8848513c9c9bf7257d6b29f52ffcc30c70fc813
link
/test integ-ipv6-k8s-tests_istio

release-notes_istio
d8848513c9c9bf7257d6b29f52ffcc30c70fc813
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


remove executables on tmpdir

Even the TMPDIR is set by users, if g5_modules is sourced in a terminal, the TMPDIR would be reset by openmpi to /tmp  where is not allowed to execute a file. So gcm_setup would work without source g5_modules but fail after source g5_modules.

This PR address issue #642

@sdrabenh We might just want to keep this in gcm_setup only. I took a look and the corresponding code blocks in the other _setup scripts are...confusing. Hopefully when we extend the Python setup from @sshakoor1 to the other chemistries, we can do this better.

I can say this works for me...or well, didn't change the resulting experiment!


Adds HTTP status code 500 for errors that are throw.

It's probably logical for failed RPC calls to have a bad status code. So this PR uses HTTP 500, if the function throws an error.

Tests pass
Fixes https://github.com/Janpot/next-rpc/issues/19

This makes failed calls stand out much easier in the browser dev tools too!
Also, love the library, exactly what I was looking for! ❤

I appreciate the effort, but I don't think we should conflate RPC errors with HTTP errors. Both serve a different purpose. e.g. A programming error in this library should produce a 500 error. When the server managed to communicate correctly to the client what the RPC method result was, then it should 200.

No worries. Yeah I know you're trying to completely abstract from the networking layer, but I don't think it makes sense to say a function that throws an error is a HTTP 200 response.

Both serve a different purpose. e.g. A programming error in this library should produce a 500 error.

Well that is exactly what HTTP 500 is for "Internal Server Error", which is a server related error as the RPC function threw an error right?

When the server managed to communicate correctly to the client what the RPC method result was, then it should 200.

Just because the server communicated correctly doesn't mean it was a HTTP 200 Success. I think it's more appropriate to attach a HTTP error code, signifying that the particular request threw an error. Otherwise, all requests are marked as successful, even though some might be returning errors.

If somewhere in next-rpc core code there is a programming error, the underlying next.js API route will send a 500 error that is not formatted as json, and your res.json() call will fail.

Fair enough 😞


Unable to change the status code of a response

Hello,
I have recently noticed that when I try to change the Status code of given response, I am unable to. It does not show any error, it looks like the change is saved, but it actually is not.
To Reproduce
Steps to reproduce the behavior:

Open any mock response.
Change the number for the HTTP Status code field.
Press the 'Update response' button on the bottom of the page.
No error is shown but on table with the Mock responses the old Status code is displayed. Also, if I open the response for Edit, the old Status code is displayed.

After saving:

Desktop (please complete the following information):

OS: Windows 10
Browser: Chrome
Version 87.0.4280.141 (Official Build) (64-bit)

Hi @ChevTomov!
Thank you so much for reporting this issue. I have fixed the issue and will prepare a release shortly.
Once again, thank you.
Best regards,
Karl Dahlgren

Hi @ChevTomov!
Thank you so much for reporting this issue. I have fixed the issue and will prepare a release shortly.
Once again, thank you.
Best regards,
Karl Dahlgren


Relevant papers to add

https://arxiv.org/pdf/2312.02179 - Training Chain-of-Thought via Latent-Variable
Inference By Google
https://arxiv.org/pdf/2402.05808 - Training Large Language Models for Reasoning
through Reverse Curriculum Reinforcement Learning
https://arxiv.org/pdf/2401.08967 - REFT: Reasoning with REinforced Fine-Tuning by ByteDance Research

merged


feat: Sym2-as-Finset theory

I just noticed that there is both the file Mathlib.Data.Sym.Sym2.lean and the folder Mathlib.Data.Sym.Sym2. Is this intended or should the contents of Sym2.lean eventualy migrate into the folder?

I removed the definition of Sym2.card because it was causing some conflicts that I don't quite understand

I'll take a look @FordUniver. For Sym2 organization, it used to all be in one file, and I think it's sort of been partially refactored. Maybe it would make sense to move Sym2.lean to Sym2/Basic.lean in a future PR.

What is the policy on when to use implicit arguments? E.g. why is it card_filter_mem_of_mem_edgeSet (e : Sym2 V) (he : e ∈ G.edgeSet) and not card_filter_mem_of_mem_edgeSet {e : Sym2 V} (he : e ∈ G.edgeSet)?
Also, how do we handle edgeSet vs edgeFinset? Just a separate version for each lemma like card_filter_mem_of_mem_edgeFinset?

It probably should be the second one @FordUniver. I put a little bit of thought into binder types, but I wasn't too consistent.
And yeah, the edgeSet vs edgeFinset situation is a need for duplication. (I've never really been happy with the fooFinset functions, but people like them for summations, so they've stuck around. By the way, you might like making a Nat.card and ∑' version of your argument, which should let you stick with sets rather than finsets.)

I added @[simp] lemma toFinset_eq [Fintype α] {e : Sym2 α} : (e : Finset α) = {v | v ∈ e}.toFinset := by ext; simp to Mathlib.Data.Sym.Sym2 but needed to import Fintype for that. Is there a more sensible place for this lemma?

Trying to resuscitate this PR. @kmill what is missing to remove the draft label?


await page.content() stuck forever?

Steps to reproduce
Tell us about your environment:

Puppeteer version: 10.1.0
Platform / OS version: macOS Big Sur, 11.4
URLs (if applicable): https://venturebeat.com/
Node.js version: v14.15.1

What steps will reproduce the problem?
Just copy and run the following code:
import pptr from "puppeteer";

async function main(args) {
    let browser = await pptr.launch({
        headless: false,
        defaultViewport: null,
    });

    const url = "https://venturebeat.com/";
    let page = await browser.newPage();
    page.on('console', consoleObj => console.log(consoleObj.text()));

    await page.goto(url, { waitUntil: "networkidle2", timeout: 10000 })
      .catch(err => console.log(`page.goto rejected, err: ${err}`)),
    console.log(`stop loading`);

    // NOTE: seems stuck here forever?
    let contentSize = (await page.content()).length;
    console.log(`content size = ${contentSize}`);

};

main();

What is the expected result?
Since page.goto would timeout, so .catch handles the error.
After that I expect page content size on console, i.e. reach and run the following line of code
console.log(`content size = ${contentSize}`)

What happens instead?
Never print anything, code stuck right at the await page.content(), forever.

Seems linked to #4011


Refactor install, uninstall, and add commands

Refactor install, uninstall, and add commands for the lefthook.
Decided to get the logic of lefthook out of cobra configuration. This allows to test the main logic better and also allows to switch CLI-tool to something more lightweight.

[x] Implement install command
[x] Implement uninstall command
[x] Implement add command
[x] Add tests

Tried to move flags like Force or Aggressive from the global scope to local scopes of install and uninstall commands. Now we support both variants.

Closing this in favor of https://github.com/evilmartians/lefthook/pull/264. That PR is rebased on this one.


chore: adds extra debug logs

This PR adds extra debug logs to help with debugging

:tada: This PR is included in version 1.6.1 :tada:
The release is available on:

v1.6.1
GitHub release

Your semantic-release bot :package::rocket:


Following the instruction and get error in "Deploy the IoT Edge device"

Following below instruction and get error in "Deploy the IoT Edge device"
https://docs.microsoft.com/en-us/azure/iot-edge/quickstart-linux?view=iotedge-2020-11
Seems authenticationType='password'  is not supported here. But no instruction is mentioned.
az deployment group create
--resource-group IoTEdgeResources
--template-uri "https://raw.githubusercontent.com/Azure/iotedge-vm-deploy/1.2.0-rc4/edgeDeploy.json"
--parameters dnsLabelPrefix='<REPLACE_WITH_VM_NAME>'
--parameters adminUsername='azureUser'
--parameters deviceConnectionString=$(az iot hub device-identity connection-string show --device-id myEdgeDevice --hub-name <REPLACE_WITH_HUB_NAME> -o tsv)
--parameters authenticationType='password'
--parameters adminPasswordOrKey="<REPLACE_WITH_PASSWORD>"
and replace with value needed, got below error
{"error":{"code":"InvalidTemplateDeployment","message":"The template deployment failed because of policy violation. Please see details for more information.","details":[{"code":"RequestDisallowedByPolicy","target":"vm-po6imqvl5twg4","message":"Resource 'vm-po6imqvl5twg4' was disallowed by policy. Policy identifiers: '[{"policyAssignment":{"name":"require ssh key for authentication_1.7","id":"/providers/Microsoft.Management/managementGroups/48fed3a1-0814-4847-88ce-b766155f2792/providers/Microsoft.Authorization/policyAssignments/bebc74b8871a3ed9"},"policyDefinition":{"name":"require ssh key for authentication on linux vms_1.7","id":"/providers/Microsoft.Management/managementgroups/48fed3a1-0814-4847-88ce-b766155f2792/providers/Microsoft.Authorization/policyDefinitions/e6063e2e57f123c2"},"policySetDefinition":{"name":"requiressh key for authentication_1.7","id":"/providers/Microsoft.Management/managementgroups/48fed3a1-0814-4847-88ce-b766155f2792/providers/Microsoft.Authorization/policySetDefinitions/9925b5f9b7103ed9"}}]'.","additionalInfo":[{"type":"PolicyViolation","info":{"policyDefinitionDisplayName":"require ssh key for authentication on linux vms_1.7","policySetDefinitionDisplayName":"require ssh key for authentication_1.7","evaluationDetails":{"evaluatedExpressions":[{"result":"True","expressionKind":"Field","expression":"location","path":"location","expressionValue":"westus","targetValue":["centraluseuap","eastus2euap","westcentralus","northcentralus","westus","eastasia","australiacentral","australiaeast","canadacentral","northeurope","centralindia","japaneast","koreacentral","uksouth","centralus","eastus","westus2","francecentral","southafricanorth","germanynorth","norwayeast","switzerlandnorth","uaenorth","southeastasia","australiacentral2","australiasoutheast","canadaeast","westeurope","southindia","japanwest","koreasouth","ukwest","eastus2","southcentralus","brazilsouth","westindia","francesouth","southafricawest","germanywestcentral","norwaywest","uaecentral","switzerlandwest","brazilus","indiasouth","indiawest","indiacentral","brazilsoutheast","westus3","eastusslv","global","swedencentral","swedensouth"],"operator":"In"},{"result":"True","expressionKind":"Field","expression":"tags[SkipGreenTeamLinuxSSHAuthForResource]","path":"tags[SkipGreenTeamLinuxSSHAuthForResource]","targetValue":"false","operator":"Exists"},{"result":"True","expressionKind":"Value","expression":"[resourceGroup().tags[parameters('resourcegrouptagname')]]","expressionValue":"","targetValue":"","operator":"Equals"},{"result":"True","expressionKind":"Field","expression":"type","path":"type","expressionValue":"Microsoft.Compute/virtualMachines","targetValue":"Microsoft.Compute/virtualMachines","operator":"Equals"},{"result":"True","expressionKind":"Value","expression":"[subscription().tags[parameters('subscriptiontagname')]]","expressionValue":"","targetValue":"","operator":"Equals"},{"result":"True","expressionKind":"Field","expression":"Microsoft.Compute/virtualMachines/osProfile.linuxConfiguration.disablePasswordAuthentication","path":"properties.osProfile.linuxConfiguration.disablePasswordAuthentication","targetValue":"False","operator":"Exists"},{"result":"True","expressionKind":"Field","expression":"Microsoft.Compute/imagePublisher","path":"properties.storageProfile.imageReference.publisher","expressionValue":"Canonical","targetValue":"Canonical","operator":"Equals"},{"result":"True","expressionKind":"Field","expression":"Microsoft.Compute/imageOffer","path":"properties.storageProfile.imageReference.offer","expressionValue":"UbuntuServer","targetValue":["UbuntuServer","Ubuntu_Core"],"operator":"In"}]},"policyDefinitionId":"/providers/Microsoft.Management/managementgroups/48fed3a1-0814-4847-88ce-b766155f2792/providers/Microsoft.Authorization/policyDefinitions/e6063e2e57f123c2","policySetDefinitionId":"/providers/Microsoft.Management/managementgroups/48fed3a1-0814-4847-88ce-b766155f2792/providers/Microsoft.Authorization/policySetDefinitions/9925b5f9b7103ed9","policyDefinitionReferenceId":"4315815614487820899","policySetDefinitionName":"9925b5f9b7103ed9","policyDefinitionName":"e6063e2e57f123c2","policyDefinitionEffect":"deny","policyAssignmentId":"/providers/Microsoft.Management/managementGroups/48fed3a1-0814-4847-88ce-b766155f2792/providers/Microsoft.Authorization/policyAssignments/bebc74b8871a3ed9","policyAssignmentName":"bebc74b8871a3ed9","policyAssignmentDisplayName":"require ssh key for authentication_1.7","policyAssignmentScope":"/providers/Microsoft.Management/managementGroups/48fed3a1-0814-4847-88ce-b766155f2792","policyAssignmentParameters":{"AllowedLocations1":{"value":["centraluseuap","eastus2euap","westcentralus","northcentralus","westus","eastasia","australiacentral","australiaeast","canadacentral","northeurope","centralindia","japaneast","koreacentral","uksouth","centralus","eastus","westus2","francecentral","southafricanorth","germanynorth","norwayeast","switzerlandnorth","uaenorth","southeastasia","australiacentral2","australiasoutheast","canadaeast","westeurope","southindia","japanwest","koreasouth","ukwest","eastus2","southcentralus","brazilsouth","westindia","francesouth","southafricawest","germanywestcentral","norwaywest","uaecentral","switzerlandwest","brazilus","indiasouth","indiawest","indiacentral","brazilsoutheast","westus3","eastusslv","global","swedencentral","swedensouth"]}}}}]}]}}
zhe@Azure:~$

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e2289383-6ce2-a036-c710-7d1fad6e1700
Version Independent ID: 3b902941-0876-17c3-3f0b-a4b7f7770531
Content: Quickstart create an Azure IoT Edge device on Linux
Content Source: articles/iot-edge/quickstart-linux.md
Service: iot-edge
GitHub Login: @kgremban
Microsoft Alias: kgremban

Hello @v-zzhe Thanks for the feedback!

https://raw.githubusercontent.com/Azure/iotedge-vm-deploy/1.2.0-rc4/edgeDeploy.json

Hi @v-zzhe is this the same issue that you and I discussed over emails yesterday, where you switched the authentication type to SSH key and were able to get the VM started successfully?

Hi @v-zzhe is this the same issue that you and I discussed over emails yesterday, where you switched the authentication type to SSH key and were able to get the VM started successfully?

Hi @kgremban Yes, it is. I am able to get the VM after switching to  SSH key authentication.

Thank you @kgremban for the Awesome help!

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.
Please also do visit Microsoft Q&A the home for technical questions and answers at Microsoft.


Ignore anchors with download attribute set (resolves #31)

Description
This PR resolves #31
Testing
Did we want to add tests for this?
There isn't a specific one for existing anchor checks like _blank.
Note
There were currently lint differences between the main branch. I did not run lint to avoid this PR having unrelated changes.
Might be a good idea to lint before cutting next version.

hasAttribute was correct, my bad!

@tomcru I tried the truthy check with anchor.download initially too and it didn't work haha. :D
Thanks for cutting the release!


[docs] Demo LoadingButtonsTransition crashes

[ ] I have searched for similar issues in this repository and believe that this is not a duplicate.

Steps to Reproduce

Visit https://www.material-ui.com/components/buttons/#outlined-buttons
??
demo LoadingButtonsTransition crashes

Your Environment

Tech
Version

MUI
v5.0.0

netlify deploy
https://614b1f0f5bede80007dca3b8--material-ui-docs.netlify.app

Browser
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.82 Safari/537.36

Duplicate of https://github.com/mui-org/material-ui/issues/27853


⚠ GitLab Server has degraded performance

In c2bdeee, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 11494 ms

Resolved: GitLab Server performance has improved in 8a1cd32.


[#4661] Fix missing field set

Codecov Report

Merging #4997 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4997      +/-   ##
==========================================
+ Coverage   40.77%   40.79%   +0.01%
==========================================
  Files        2649     2649
  Lines       79281    79284       +3
  Branches    10716    10717       +1
==========================================
+ Hits        32329    32340      +11
+ Misses      44020    44015       -5
+ Partials     2932     2929       -3

Impacted Files
Coverage Δ

...r/datasource/DefaultDataSourceMetricCollector.java
20.83% <0%> (-2.98%)
:arrow_down:

...pinpoint/profiler/instrument/AccessorAnalyzer.java
57.14% <0%> (-8.58%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
79.51% <0%> (+0.69%)
:arrow_up:

...cluster/zookeeper/ZookeeperClusterDataManager.java
64.7% <0%> (+2.2%)
:arrow_up:

.../profiler/sender/StandbySpanStreamDataStorage.java
76.27% <0%> (+3.38%)
:arrow_up:

...rc/main/java/com/navercorp/pinpoint/test/Item.java
68.96% <0%> (+3.44%)
:arrow_up:

...pc/server/LoggingServerMessageListenerFactory.java
100% <0%> (+10%)
:arrow_up:

...p/pinpoint/rpc/client/WriteFailFutureListener.java
75% <0%> (+18.75%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 265836e...9f0cae1. Read the comment docs.


Allow omnibus installer on debian 8.0

Right now, rubygems is being used on debian jessie.
To be safe, since I've only tested x86, I'll be conservative and assume the rubygem install is still the thing we want for non-x86

PR in #436


Can't spawn multiple django workers

Currently the django process binds to a port for ZMQ messages to go to the websocket server, which prevents multiple worker processes from being launched. The fix should hopefully be as simple as swapping which process binds and which connects between the django and flask(websocket) servers.

Fixed in #33 .  Ready to be closed.


For a standard installation, 'pip install' has to be run with sudo

I needed to do this to install jupyterhub on my machine; that was the correct thing to do, right?

That's not generally true. For virtualenvs, anaconda/conda, or OS X with brew, that isn't the case. I would prefer to leave sudo off, since it's a lot worse to sudo when you don't have to than leave it off and have to run the command again with sudo.

On Wed, Jun 10, 2015 at 10:08:02AM -0700, Min RK wrote:

That's not generally true. For virtualenvs, anaconda/conda, or OS X
with brew, that isn't the case. I would prefer to leave sudo off, since
it's a lot worse to sudo when you don't have to than leave it off and
have to run the command again with sudo.

Ok. Then, the sudo should probably be removed from the pip calls
earlier in the README for consistency?
And maybe adding a note could be added specifying that, depending on
the context, jupyterhub may need to be installed as root?
Cheers,
Nicolas
Nicolas M. Thiéry "Isil"<EMAIL_ADDRESS>http://Nicolas.Thiery.name/

@nthiery yup, those were added in a recent PR, and I missed them. Actually both of those entire install lines for jsonschema or terminado should be removed entirely.
I would do that - remove sudo from any copy/paste-able examples, and add a note that

sudo may be needed for pip install, depending on filesystem permissions.

On Wed, Jun 10, 2015 at 03:10:30PM -0700, Min RK wrote:

[1]@nthiery yup, those were added in a recent PR, and I missed them.
Actually both of those entire install lines for jsonschema or terminado
should be removed entirely.
I would do that - remove sudo from any copy/paste-able examples, and
add a note that
 sudo may be needed for pip install, depending on filesystem
 permissions.

Sounds good to me. Do you want me to do it, or are you just going for it?
Cheers,
Nicolas
Nicolas M. Thiéry "Isil"<EMAIL_ADDRESS>http://Nicolas.Thiery.name/

If you want to make a PR, that would be great!


Export Product error

Hi export,
A issue reported when i plan to Use "Export  Product export Wizard", please check the detail info below, very appreciated to get you response.
A cycle was detected when generating the classpath org.slf4j.api_1.7.30.v20200204-2150, ch.qos.logback.classic_1.2.3.v20200428-2012, org.slf4j.api_1.7.30.v20200204-2150.
if i check the  button "Allow for binary cycles in target platform" , blow error is reported.
A cycle was detected when generating the classpath org.jkiss.dbeaver.ext.greenplum_<IP_ADDRESS>108121540, org.jkiss.dbeaver.ext.postgresql_<IP_ADDRESS>108121540, org.jkiss.dbeaver.ext.greenplum_<IP_ADDRESS>108121540.
Thanks,
Jason

@janiu-001 Hello, Jason. Please provide more information for us to reproduce this issue. Mainly your OS, DBeaver version, Database that you are using. And most importantly steps to reproduce with table DDL if it is possible.

OS: mac catalina
dbeaver: the latest master branch
i also have the same problem on the windows system.
Do you have a try to click ""Export Product export Wizard" in the view tab?It should be reproduced easily

@janiu-001 I still can't understand the exect steps. Do you mean you are exporting data from data view? If so, I need to know what is a target of your export. Another database or a file (csv, xml etc.)? It will be good to know what type of columns are you trying to export. And I can't understand what "Allow for binary cycles in target platform" means. If you are using Dbeave in non-english language, can you at least post a scrennshot with that setting highlighted, so I can understand what it is?

Please check the attached image, the first two images are my procedure, the last one is the error

Why do you export product? You can build it with Maven and get binary artifacts from target.


Parsing HTML Error

Hello,
Wish you a happy day!
When i am trying to import fixtures i am recieving an issue with html parsing.Any idea of how to fix this issue? I have tried it both on windows and Linux.

Hello,
I am walking towards the next patch, which fixes this error. It;s because Footystats.org always change their HTML code.

You are the best! Very creative what you have done in this git.You can try if you can modify it with any free API that can take more stats.


Fixed random order?

Wait for Dada's input.
Pay attention to Overlap tasks, they should be most challenging and surface more issues than others.

Keep random as is. Add baseline tasks.


money

Characters are going to need a way to store money. Ideally, this system should do a few things:

Track individual coin denominations.
Provide a route for GM customization of coin names.
Track issuing government (to enable moneychangers)

relies on #170


Android developer please help me

hey there can any one help to add this library in my web browser application
i find it difficult to add
``request~~
Sir can you provide video tutorial to add this library in a web browsing application

@sauravbhati Please have a look at the sample project.


Send request url to custom webRequest modifiers

It would be helpful to change web request headers according to request url, e.g. for known protected urls.

A test is failing


Graph QL: TLU pipeline dsl and remote schema url changes

Should we get this one merged ?

Was supersed by #9

Should we get this one merged ?

Yes, I think that would be better. I will create a separate branch to continue development.


Favor toHaveBeenCalledExactlyOnceWith

In the same style as https://github.com/veritem/eslint-plugin-vitest/blob/main/docs/rules/prefer-called-with.md, would it be possible to have a rule preferring using toHaveBeenCalledExactlyOnceWith over the usage of both toHaveBeenCalledOnce and toHaveBeenCalledWith?

mind sharing a reason why we should prefer toHaveBeenCalledExactlyOnceWith?

I'm used to always do this in my tests:
expect(x). toHaveBeenCalledOnce();
expect(x). toHaveBeenCalledWith(args);

And on a large scale, reducing this to:
expect(x). toHaveBeenCalledExactlyOnceWith(args);

Would be slightly better.
So enforcing this as a linter rule would be nice to ensure consistency.


Proposal: Bring back record field adding/deletion

record = { x : 4 }
evenBetterRecord = { record | y = 5 }

Elm had this feature, and I think it still should have it. Mainly because it makes it possible to follow 'Scrap Your Typeclasses' without insane amounts of boilerplate.
I can see how this feature may not be used by the average elm developer, but for developers maintaining/creating packages it would be really handy.
Personally I have created way too many toSomethingComparable functions for my own datatypes, and I'd like this to change.
For more detailed description on why this is needed can be found here

You know, hurling a lot of insults isn't going to endear you to people who maintain the language. You should go try PureScript. No, I don't need a lengthy exposition of why it sucks too. This post is what "I'm tired of open source" blog posts are made of. Shoo.

Sorry, I wasn't really trying to 'hurl a lot of insults'. I am aware that the blog post I linked is a bit salty towards Elm, and I can say that I don't agree on the hate aspect of it. I just think it had a good point about how the addition to record syntax would be a nice feature, even though it was written maybe not in the most constructive way.
I haven't looked at PureScript, but I don't think that even if I did I would stop using Elm. I like the language, and I think it has enough good sides to bear the writing of occasional boilerplatish code. I just think that it would be better if I didn't have to write it.

I am aware that the blog post I linked is a bit salty

I totally didn't realize that you weren't the author of the post! I'm so sorry!

I haven't looked at PureScript

That remark was aimed squarely at the author of the post.
As for the issue at hand... the feature was removed because no one had found a good use for it, and having it around lead to confusion (i.e. record updates were not type-stable). "Here's a neat trick from Haskell" is never, by itself, considered good enough reason to add something to Elm. But if you can identify a real pain point in building web apps, let's hear it.

Or, as Evan said:

I think it makes sense to continue discussion in this issue if you think there are valid use cases that we did not see in the 2+ years of having the feature, or that did not come up in the discussions explicitly searching for use cases before it was removed, or that for some reason have not been brought up here already. Once there is a specific and compelling example, perhaps it makes sense to open a new issue that focuses on it explicitly.

I don't think how common of a problem my problem is, but for me the greatest pain in writing Elm, is the fact that you cannot define for example comparable instances for your own types. Currently I 've had to resort to writing toInt or toString functions for my datatypes. I like to use my own types as identifiers in dicts, or have sum types which describe some sort of ordering for example.
The record syntax addition would be a fix for the problem, but to be honest anything works for me. I don't really have enough expertise on anything to suggest what would be the best way to achieve this.
I understand if this feature doesn't possibly fit the Elm ideology of being as simple as possible, and if it is just unreasonably complex and/or would complicate the language in some way which I cannot foresee, but I think that having things like comparable should implicate that you can define things to be them.

Wanting union types as Dict keys is reasonable, and I think Evan has said as much. (So is wanting to sort a list of custom types, and thankfully it's the same fix.) Some related proposals include making records of comparable things comparable, and making booleans comparable (so data structures containing them are comparable). Implemented well, this could be a lot easier than the SYTC approach! My biggest concern is whether we can automatically infer comparability for anything that a user could reasonably want to compare.

If the root problem is "I want more values to be valid keys in dictionaries" I agree that this can be improved. Changing records back would not achieve that at all though. You may be overestimating how flexible this feature was. You cannot just add fields willy-nilly. They'd all show up in the types, so you would not be adding unlimited fields at runtime.
As for the claim that this feature makes the explicit record passing described in Scrap Your Type Classes easier, that is also false. I think this paper may help clarify that. Point is, if that is the real goal, this approach will also not help in the end.

I'd like to plea to open this or a similar issue. We can get very far with current Elm, but in many "Real World" scenarios, it's type system is lacking.
So I read the paper but I cannot see where it says something about why SYTC wouldn't benefit from this feature request?


Add BigWigs Packager

Would love if you could add the bigwigs packager to this repo! This'll let people who don't use Curseforge download from github (and potentially save you time by uploading releases to CF / Wago as well!)
I'm happy to submit a PR for this if you'd like, though you'll have to add a github token to the repo's secrets so it can be used for packaging!

Hey, sorry for the late reply. Im kinda busy atm so feel free to submit the PR, if you need anything from me (like token) just let me know and i'll help you out. Thanks:)


correcting these parameters to be arrays

What kind of change does this PR introduce?
When using the .contains function, I noticed I was unable to pass an array object. As noted in the documentation here, the expected parameter for value should be an array, but like when passing a value to the .in function.
What is the current behavior?
The current incorrectly accepts a singular value for the .contains function. When making a call, an error will occur, suggesting that an array needs to be passed.
What is the new behavior?
The new behavior allows for an array to be passed. The array is processed as any other list is when passed (much like the .in functionality)

Hi @ggarnhart thanks for bringing this into the discussion. There are other forms of using this filter on the documentation link you posted.

Love that idea -- and thanks for the clarification! Apologies, new to Swift as of a few weeks ago :)

Hey @ggarnhart thanks for the PR, I made a few changes to your implementation, please take a look and let me know what you think.
I can merge the PR once you're ready.

Looks awesome, @grsouza! Thanks for the help :)
Merge whenever 🔥


Some questions :slightly_smiling_face:

@littlewhywhat
I have some questions:

Could we activate discussions?
Should we add JSDoc to some properties like MigrationRunner#name and MigrationRunner#timestamp etc?
What can I do to also get master access granted so I can merge dependencies and so on :thinking: (Or how can I build up trust)
What are the next steps for the project?

Hi @Shinigami92 thank you for your interest and contributions!

Could we activate discussions?

I activated them just now.

Should we add JSDoc to some properties like MigrationRunner#name and MigrationRunner#timestamp etc?

hmm... Aren't those described here https://github.com/salsita/node-pg-migrate/blob/master/docs/api.md? or do you mean smth else? feel free to open the discussion with your suggestion! :)

What can I do to also get master access granted so I can merge dependencies and so on thinking (Or how can I build up trust)
I know i wasn't active lately, sorry about that.  Let me try to improve in the following months :pray:

What are the next steps for the project?
Definitely nothing big at the moment, mostly maintenance, addressing enhancements/bugs. We can at least consider/discuss some proposals of big improvements as we did in the past.

The docs could help when using the code in e.g. VSCode. So now we need to visit an external resource instead of just accessing the related doc at the used point.
I could create a PR later on for adding these already existing docs to the related points.

So you mean maybe not MigrationBuilder but Migration do you? here? https://github.com/salsita/node-pg-migrate/blob/bc47f8164a347e7566728ac35da1c9d7e6e35413/src/migration.ts#L144-L146

The docs could help when using the code in e.g. VSCode. So now we need to visit an external resource instead of just accessing the related doc at the used point.

Yeah, makes sense - feel free to create a PR, of course! Thank you!


openmpi redux

retry #140

Because of #103, this will double build time instead of doubling the size of the build matrix.


Implement Real-Debrid speedtest functionality to optimize CDN selection

Added Real-Debrid Speedtest functionality to MediaFlow as discussed in the Elf-Hosted Discord. The endpoint for this feature is /speedtest?api_password=your_password, ensuring protection against unauthorized triggers. The Speedtest data will remain active for one hour.
The implementation utilizes the requests module, which I have added to pyproject.toml, and the lock file has been generated accordingly. It is necessary to include this module in the MediaFlow-proxy pip package.

Thanks for your contribution. i change the target branch, so ill do the modification on it later.

Ok thank you, if you need any changes to be done please ask.

i was planned to change the function to utilize the Streamer class streaming function instead of using the request in order to correctly find the speed test.

ok let me try and do that you are talking about the one from the https utils file right?


Update example app with 404 and 500

Resolves todo.
Tasks:

Add 404 and 500 error components based on old examples
Fix error experienced by using react-router@1 by adding backwards compatibility

Chore:

Add nodemon to example app for easier debugging
Create npm run dev script
Add displayName to all view components in example app for easier debugging with React Debugger
Update example readme and remove trailing whitespace

👍


Add environment.yml and xskillscore and climpred to dependencies

This addresses a desired library identified in https://github.com/Ouranosinc/raven/issues/336. I'm merging it based off of this branch, as the behaviour/enhancement (close-netcdf-files) is needed for it.

I'm a little confused and didn't follow super well. I'm not sure however that the solution I devised in https://github.com/CSHS-CWRA/RavenPy/pull/6/files is the way to go. I don't know the answer to the question raised (when exactly is the file closed, and what consequence does it have?)

I made the call. Empirically, it works, and we have tests to ensure validity, so I'm willing to run with it.

Ok but I'm just confused about the relationship between this "bug" (if it's really one) and the exact version of xarray that we're talking about.. could someone clarify?

climpred requires xarray 0.16.2. The cache issue affects xarray 0.16.1 and 0.16.2. Your PR solving the cache bug allows us to unpin xarray 0.16.0 and install climpred.


Cellpose results slightly different on my computer vs. website

Hi all,
First off thank you for sharing this great tool for cell segmentation.
Ive been testing it out on my Mac (10.14.16 Mojave), both the GUI and non-gui version and I did have to downgrade my cv2 to <IP_ADDRESS> and add in this line
import os
os.environ['KMP_DUPLICATE_LIB_OK']='True'

as suggested in previous posts to get it working on my mac.
After testing it out a bit i noticed that my results for the same image are different depending on whether i use the cellpose.org website vs. in a notebook on my computer.
The website shows:

Just using the default settings. And I think it looks quite good already.
But running it on the notebook shows:

I did try to manually adjust the cell diameter but it didnt seem to help.
The closest i got to the website result was running the GUI, letting it automatically select the cell diameter and adjusting some of the parameters, but its still not exactly the same:

I was wondering if the cellpose.org website was doing something different, or maybe its a mac specific issue due to the multiple .dylib files.
I havent tested it on the google colab notebook yet.
Thank you!

Update:
It turns out I had the channels set incorrectly previously. Setting it to just [0,0] largely fixed the issue as shown here:

Done in the google colab notebook.
There are still some really minor differences and Ive been testing some different settings in therms of cell diameter and flow threshold. However I would still be curious to learn what the settings cellpose.org uses for its example segmentation. Thanks.

for the website the test-time augmentations (tiling) do not occur. Also we resize the image so that it's at most 512 pixels on a given size. otherwise the settings should be the same (default flow threshold used, diameter set by user (not autoset))


Validations not working in 0.5.2

Validations stopped working when I upgraded from 0.5.1 to 0.5.2. My form looks like this, when I comment out validations, everything works. Without validations, no cigar. Any ideas?
<Formsy.Form
              ref="form"
              className="form"
              onValid={() => this.enableLoginButton()}
              onInvalid={() => this.disableLoginButton()}
              onValidSubmit={(model) => this.login(user, model)}>
              <FormsyText
                name="email"
                floatingLabelText="Email Address"
                fullWidth
                // validations="isEmail"
                // validationError="Please enter a valid email address"
                {...textFieldStyles}
                required
              />

              <FormsyText
                name="password"
                type="password"
                floatingLabelText="Password"
                // validations={{ minLength: 6 }}
                // validationError="Password must contain at least 6 characters"
                fullWidth
                {...textFieldStyles}
                required
              />```

Do you have an error message?

Im seeing this too.  Seems with validation  in the email field it does not allow edit.  There are no console errors. Just will not let edit happen.   was working for me with 0.5.0 and formsy-react 0.18.1

I am seeing this also. It has to do with any validations, including "required."  The culprit seems to be line 81 of FormsyText.js, where a "this.resetValue() is called if the field is not valid.  This results in weird behaviors such as:

If you have a validation like "isEmail", and the field is blank, typing ANYTHING will be ignored (as the first character is not a valid email address, so the field is reset.

If you have a field marked as "required", and you start backspacing over it, you can remove all but the first character.  Once you remove the first character, it becomes "invalid", it resets, and the old value is put back in place.

I commented out that line in the lib/FormsyText.js of my node_modules dir, and it now seems to be behaving.

UPDATE: I forked the project today to make a change on another issue, and while the "resetValue()" is still there in the code, it now appears to work for me.  For those who are experiencing this problem, you may want to fork the project and build from source and see if you still have the issue.

I'm a new user of the package and it also seems that many validations are broken.  isLength and minLength don't let me type anything in input fields. I can reproduce all the same errors with the sample webpack app you ship so I'm pretty sure it's nothing I'm doing wrong.

I'm also seeing this issue. When you type in an input that has validations, nothing happens to the input--it remains blank. This issue is not present in v0.5.0, but does show up in v0.5.1 and v0.5.2

For those who are experiencing this problem: are you specifying the "updateImmediately" property?  I looked at my code again from the last time I reported that I had been experiencing this issue, and I noticed that I started setting the "updateImmediately=true" property in a code change.  The FormsyText.js component takes a different code path if updateImmediately is set to truthy, and it AVOIDS the "this.resetValue()" call in the "handleChange" method that I found to be responsible for preventing fields from updating if validation was specified.  Try setting the "updateImmediately=true" in your FormsyText components and see if that makes a difference.

@mbrookes I just confirmed (at least on my machine) that an "npm test", which appears to test FormsyText, fails on the current code in the master branch for 0.5.2.  It complains about a lack of an "text is too long" invalid error.  It DOES pass with the the above pull request, so I think the removal of that line is important.

I sincerely apologise that these sorts of problems have crept in to recent releases - the fault is entirely mine.
Long story short, I haven't been actively developing anything for the last 6 months or so. I've tried to keep up with critical fixes that the community has kindly submitted, but my inability to properly test fixes before releasing them has resulted in unfortunate problems.
If anyone would like to take over repo, or alternatively, if you have a project that offers a similar solution that you'd like me to highlight, please do let me know!

@mbrookes:
You've done a great job with this project, dude. I've shown it to several people who really dig it. I changed my username, but it was @rblakeley -- we collaborated on fixing a bug that I think led to this project. I'm game for taking over if you want.

I'd be happy to lend a hand to fix things and add more tests, etc.
On Mon, Oct 31, 2016 at 12:35 PM Ryan B. Blakeley<EMAIL_ADDRESS>wrote:

@mbrookes https://github.com/mbrookes:
You've done a great job with this project, dude. I've shown it to several
people who really dig it. I changed my username, but it was @rblakeley --
we collaborated on fixing a bug that I think led to this project. I'm game
for taking over if you want.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mbrookes/formsy-material-ui/issues/152#issuecomment-257345273,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAiTc_lLsQxcWMiQmt1TpX-_wbE3S3Jxks5q5hjNgaJpZM4KceRa
.

--

Robert Moskal
Most Media
Brooklyn, USA

Hey Ryan, good to hear from you! You're still credited in the README for the original idea. 👍
Thanks to you and @rmoskal for offering to step in. I've added you both as collaborators, joining @codeaholicguy who has done great work already! I'll figure out NPM access when I get a chance (it's midnight here), but Nguyễn has access for now if you need to publish something.
Thanks again, and shout if I need to do anything else to help with the transition.

keep this repo alive! 😁

It looks to me like the problem happens when you don't specify a validationError property. The logic that we've all pointed to just needs to be tweaked.
If no one else takes care of it I will in the next few days.

@rmoskal setting updateImmediately={true} the error disapears.
if @mbrookes cant keep the repo, you should
@joelkoz can help to.

Then maybe there is no error and just a lack of documentation.
Though it does seem like this is a breaking change.
I just started using the package myself.
On Thu, Nov 3, 2016, 6:22 PM Casy<EMAIL_ADDRESS>wrote:
@rmoskal https://github.com/rmoskal setting updateImmediately={true} the
error disapears.
if @mbrookes https://github.com/mbrookes cant keep the repo, you should
@joelkoz https://github.com/joelkoz can help to.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mbrookes/formsy-material-ui/issues/152#issuecomment-258291992,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAiTc6sGaUlFgVYxcWrgXqQV6zA9Umeuks5q6l6YgaJpZM4KceRa
.
--

Robert Moskal
Most Media
Brooklyn, USA

@rmoskal - No, there is definitely a bug that was recently introduced.  It just so happens that if you use updateImmediately={true} property, the text control takes a different code path and avoids the validation bug.  So, that is a work-around, not a fix.
If anyone is interested, I have a branch on my fork of this project named "current-fixes" which contains the two fixes that I have made to the project.  You can check out that branch if you wish to get this working again.:  https://github.com/joelkoz/formsy-material-ui/tree/current-fixes

@joelkoz Could you submit your fixes as a PR? It will make it easier to review. Thanks so much!

I did already. There are two from me waiting.
-jk
(sent from my iPhone)

On Nov 4, 2016, at 9:01 PM, Matt Brookes<EMAIL_ADDRESS>wrote:
@joelkoz Could you submit your fixes as a PR? It will make it easier to review. Thanks so much!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@mbrookes - I just added a third PR to change the material-ui version to 0.16.0 to fix #153.  There don't seem to be any breaking changes in 0.16.0 that affect this project.

How is it going?

What's up with the PRs fixing this? Hello?

Just merged several PRs, including those submitted by @joelkoz aimed at fixing this. If we could get some thumbs up on this comment to signal that the @latest is solving this issue, then we can close.

@Telemakhos Sorry but I'm not an npm power user. How can I install joelkoz fork ? Can't find a good tutorial to do this.
Thanks a lot

@rojobuffalo - npmjs currently has the old 0.5.2 as the latest version.  Any reason to not bump up the patch version and publish a 0.5.3?  We know for sure that what is out there is broken, so it can't get any worse.

@rojobuffalo Let me know if you need npm owner rights. @joelkoz I invited you as a collaborator. 👍

@joelkoz I was waiting for confirmation from someone else that the latest updates are all working properly as they see it.

@rojobuffalo Working ok for us.. I think it's safe to bump up the verson.
@jadus You do it with npm i <repoURL> and then building if required, but I think you should just wait and install the official version once they publish it on npm...

@mbrookes I do need npm access. My npm username is rojobuffalo.

@rojobuffalo (cc @mbrookes) I added you into npm, please check it again

Thanks @codeaholicguy. Just published 0.5.3


Diary cannot be decrypted after crash

I'm sure I entered the correct password. But it give a message "Wrong password"

Can you reproduce this with a new diary? If you're not using the Mac App Store version, you can change the directory in the preferences and create a new diary there.

probaly not.
In fact, my PC reboot suddenly with a blue screen after i close diary. and now i can't open it with the correct password.
can you have any idea to recover my data?

That's odd. Please let me know if you manage to reproduce this so I can look into why this happened.
If you have backups of your files, you can simply restore an old version of your diary file. On Windows, this file is located at %AppData%\Mini Diary\mini-diary.txt by default, e.g. C:\Users\USERNAME\AppData\Mini Diary\mini-diary.txt.

OK, I will try it when home.
and can you tell me something about how to encrypt and decrypt data?

When you enter your password in Mini Diary, the app hashes it and uses the resulting string to decrypt and encrypt your diary file.

I think i lose my data forever. is the hashedpassword cracked? and where is the hashedpassword stored?

i open mini-diary.txt with editor. there are all 0000 now

the content mini-diary.txt is all 0000s now.
is it still can be recovered?

Sorry to hear that. If you don't have any backups, you won't be able to recover the data if your file is corrupted.
I'll think about adding an auto-backup mechanism to the app which backs up your data e.g. once a day.

Hello, I have experienced a similar problem. I have downloaded the Mac App Store version, and when I turned on my laptop again, even after entering a correct password the app keeps giving a message "Wrong password". I deleted the app and re-installed the app, hoping that would fix the issue, but the app would just keep asking me to enter the password. I was also not able to find the functionality for changing passwords. Could this be fixed?
Also, the auto-backup functionality sounds awesome. Do you know when would that functionality be added to the Mac App Store version?

@unpilbaek Thanks for reporting this.
The MAS app stores its data at /Users/YOURUSERNAME/Library/Containers/com.samuelmeuli.minidiary/Data/Library/Application Support/Mini Diary/. The backups can also be found there. If you replace your mini-diary.txt file with one of the backups, close and re-open the app, you might be able to decrypt the diary again.
It really sounds like there is some operation that corrupts the diary file, or encrypts it with the wrong password (maybe an empty string). Do you remember how you left the app before reopening it? Did you close it normally, did it crash, did your computer go to sleep, ...?

Hello Samneul Meuli,
I wasn’t able to find the directory that you suggested, but I did manage to get into the contents of Mini Diary through the Applications folder in Mac. Unfortunately, I am not sure how to locate the backup files from the package contents.
And I believe my computer was fully depleted of battery with the application open. When I re-charged the device and attempted to open the app, it kept telling me that the correct password I input was the wrong one.
Thanks,
Unpil Baek

On 3 Aug 2019, at 1:40 AM, Samuel Meuli<EMAIL_ADDRESS>wrote:
Reopened #19 https://github.com/samuelmeuli/mini-diary/issues/19.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/samuelmeuli/mini-diary/issues/19?email_source=notifications&email_token=ACJ5ZJJV2AV7FYCUZJGNSZDQCU77PA5CNFSM4HNVY4SKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOS3PUWMQ#event-2531216178, or mute the thread https://github.com/notifications/unsubscribe-auth/ACJ5ZJMTI52EBQT7LUIT7WDQCU77PANCNFSM4HNVY4SA.

Thanks for the info, I'll look into it.
The data isn't in the application package, it's in the Library folder at the path above. The Library folder is hidden by default (see this guide on how to find it). Also, make sure to replace YOURUSERNAME with your actual username. Let me know if this works for you :)

Haven't received any new reports of this issue, so I'm going to close this.

Does the non-MAS version also perform auto-backups? If so, where are these stored? My diary seems to be 0 bytes all of a sudden and my last manual backup was a few weeks ago.