Compare only fields of given type

Check List:

Fixes #2793
Unit tests : YES
Javadoc with a code example (on API only) : YES
PR meets the contributing guidelines YES

Short description
Introduce new field in Recursive Comparison Configuration - set of types to be compared, and include it to existing places (description, equals, etc.)
Keep track of parent fields in separate field. Since when matching DualValue we don't know if parent type should be compared, so we do that based on matching set of parent paths. Maybe not a best place to track this, however it does not have accessors so cannot be messed up unintentionally.
We should evaluate existing comparedFields together with the new comparedFieldsOfTypes (or any other further matching based on value) since fields might filter out each other otherwise.
This change does not break any of existing tests so it's safe I belive.

Thanks, I will review your PR in the next few days

@joel-costigliola thanks for the review! I will go through your points in the nearest few days

Hi @joel-costigliola I did go though your points and added changes on all of them, also spotted a typo and fixed that as well. Please have a look at the changes and this part.

Integrated thanks @beyond-danube!

Great, thanks @joel-costigliola!


Predicting with multiple models and different classes is not working

Hello everyone,
I trained 2 different models with 2 different classes. Then I tried to predict two different images with each of those models but the prediction result always returns the classes from the first model prediction, totally ignoring the loaded class file. Here is the code:
`from imageai.Prediction.Custom import CustomImagePrediction
import os
execution_path = os.getcwd()
predictor = CustomImagePrediction()
predictor.setModelPath(model_path=os.path.join(execution_path, "model1.h5"))
predictor.setJsonPath(model_json=os.path.join(execution_path, "class1.json"))
predictor.setModelTypeAsResNet()
predictor.loadModel(num_objects=2)
predictor2 = CustomImagePrediction()
predictor2.setModelPath(model_path=os.path.join(execution_path, "model2.h5"))
predictor2.setJsonPath(model_json=os.path.join(execution_path, "class2.json"))
predictor2.setModelTypeAsResNet()
predictor2.loadModel(num_objects=2)
results, probabilities = predictor.predictImage(image_input=os.path.join(execution_path, "image1.bmp"), result_count=2)
print(results)
print(probabilities)
results2, probabilities2 = predictor2.predictImage(image_input=os.path.join(execution_path, "image2.jpeg"),
result_count=2)
print(results2)
print(probabilities2)
print("-------------------------------")`
The classes file look like this:
class1.json:
{     "0" : "class11",     "1" : "class12" }
class2.json:
{     "0" : "class21",     "1" : "class22" }
If I predict using model1 first, I get this result for both images:
['class11', 'class12'] [92.94933676719666, 7.050657272338867] ['class11', 'class12'] [92.31300950050354, 7.686983793973923]
=> Both images are classified by class1.json, even though for predictor 2 i loaded class2.json
If I predicut using model2 first, I get exactly the opposite result. Both Images are being classified with class2.json.
imageai: 2.1.5
keras: 2.2.4
tensorflow-gpu:1.12
Regards,
Zordiac

Okay after a minute of checking your code, I found the bug, it is located in Prediction\Custom\custom_utils.py:
`import json
CLASS_INDEX = None
def preprocess_input(x):
"""Preprocesses a tensor encoding a batch of images.
# Arguments
    x: input Numpy tensor, 4D.
    data_format: data format of the image tensor.

# Returns
    Preprocessed tensor.
"""

# 'RGB'->'BGR'
x *= (1./255)

return x

def decode_predictions(preds, top=5, model_json=""):
global CLASS_INDEX

if CLASS_INDEX is None:
    CLASS_INDEX = json.load(open(model_json))
results = []
for pred in preds:
    top_indices = pred.argsort()[-top:][::-1]
    for i in top_indices:
        each_result = []
        each_result.append(CLASS_INDEX[str(i)])
        each_result.append(pred[i])
        results.append(each_result)

return results`

The issue is the global variable CLASS_INDEX, which stores the models classes. This variable is set after the very first prediction, to the first model class used. However, every subsequent prediction still uses these classes loaded initially and not their own classes, even though the model paths differ.
I fixed that for myself, but it would be great if any developer could implement that fix as well. It takes literally 5 minutes, depending on how you want to do it.
If anybody is having the same issue and the bug is not fixed yet, just write me a pm I will provide you the fixed script.


Add MultilabelConfusionMatrixEvaluator

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (7625f01) to head (a43d480).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #218   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           80        81    +1
  Lines         1918      1940   +22
  Branches       180       181    +1
=========================================
+ Hits          1918      1940   +22

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Modified notebook and added statistics

Copied the example file, changed the bounding box and added summary statistics.

@anuShrestha83 Sorry to intrude but I noticed this PR contains Jupyter notebook files that are hard to review on GitHub due to the JSON diffs.
You might want to checkout ReviewNB, a code review tool for Jupyter notebooks. It's free for open source repositories. Provides visual diffs for notebooks & ability to comment on notebook cells.
I know this particular PR has only one newly added notebook but it is still hard to review on GitHub due to image and other multimedia present in the notebook JSON.


Unidentified in url mask on mobile

instead of working normally on mobile input shows Unidentifiedtp:// and more unidentified per tap
codepen

OS: Android 12
Chrome latest
5.0.8.beta.47

I will publish a newer beta

@aolko ,
Can you have a try with version 5.0.8-beta.70

works as expected, but allows erasing invisible characters at http://

What do you mean exactly by deleting invisible chars at ...

keep tapping ⌫ when you erased your text with only http:// left

Ok that's because you can also type in anothr protocol like ftp


⚠ PrivateHD has degraded performance

In d11dc96, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 2523 ms

Resolved: PrivateHD performance has improved in 34ba18c.


Nonlinear registration stuck forever computing the Jacobian

Hi all,
I am running a 3-step registration where I generate my own atlas averaging my data. I am using mice brain data acquired sagittally.
Practically, initially I do a rigid registration to the reference Allen atlas, once they are all registered, I campute the average volume, which is then used to register again everything by using first affine and then bspline registration. It s a way of working you can find in several works where not well established brain atlas exists.
Now, everything goes smooth until I register nonlinearly the data. The issue is that the registration for whatever sample gets stuck (days) at "computing the Jacobian". This has happened in two different Linux machines: a Laptop with iCore 7 intel, and a node on a CloudCluster using 32cpu-128ram-hpc (I doubt the issue is related to power).
And it doesn't matter if I do it using the previous steps of registration or I do that directly.
Any idea?
I attach here my param files
rigid.txt
bspline.txt
affine.txt

Sorry I forgot my log (the one of the Jacobian getting stuck)
elastix.log

sorry, I posted by mistake on simple elastix, should I close it? How do I move it?


Make pip understand the version set for fileflow

Something is wrong with the version number when trying to install fileflow in that it thinks its 0.0.0 even though our setup.cfg, at time of writing, sets it to 0.0.3. Not sure if this is a property of the git install and/or if this will cause problems with later installs since we're installing from commit hashes, but I think worth figuring out including how it may interact with PyPI packages.
(fileflow)~ $ pip freeze | grep fileflow
You are using pip version 6.0.8, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
fileflow==0.0.0

Awesome project. For easier version management, I recommend using setuptools_scm, which allows you to use your git / mercurial tags for versioning.

@ksindi great suggestion, we will check it out

This was fixed by https://github.com/industrydive/fileflow/pull/11.


Create optimizeIF_ELSE.c

An optimized nested if else code in C for calculation fizz buzz in any range of numbers.

Thank you for your PR!
Unfortunately a solution similar to yours has already been submitted :/
The goal is to find creative/abstract new solutions to FizzBuzz.
See The top 5 samples here.
Thanks anyway! :)


About Usage of routerMiddleware

I current have two middleware in my redux app, I am just confusion about how to aplly the routerMiddle correctly.
const logger = createLogger();
const middlewares = [ReduxThunk, logger];
const composeEnhancers =
    process.env.NODE_ENV !== 'production' &&
    typeof window === 'object' &&
    window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ ?
      window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__({
        // Specify here name, actionsBlacklist, actionsCreators and other options
      }) : compose;
const store = createStore(reducers, composeEnhancers(
    applyMiddleware(...middlewares)
));
const history = syncHistoryWithStore(browserHistory, store);
ReactDOM.render(
  <Provider store={store}>
    <MuiThemeProvider>
      <Router history={history} routes={routes} />
    </MuiThemeProvider>
  </Provider>,
  document.getElementById('root')
);

If I do this:
const middlewares = [routerMiddleware, ReduxThunk, logger]

, my routing didn't work.
Help please

@yuli0109 I am using a similar setup with multiple middleware. Did you find a fix for this issue?
My routing workings correctly, but I receive a
middleware.js:21 Uncaught TypeError: Cannot read property 'type' of undefined

error in my console when trying to use
dispatch(push('/path'))

the middleware code that is producing that error is here i believe
function routerMiddleware(history) {
  return function () {
    return function (next) {
      return function (action) {
        if (action.type !== _actions.CALL_HISTORY_METHOD) { /* breaks here */
          return next(action);
        }

        var _action$payload = action.payload,
            method = _action$payload.method,
            args = _action$payload.args;

        history[method].apply(history, _toConsumableArray(args));
      };
    };
  };
}

Here is my store setup.
import { createStore, applyMiddleware, compose } from 'redux';
// import { browserHistory } from 'react-router';
import { routerMiddleware, browserHistory } from 'react-router-redux'
import thunk from 'redux-thunk';
import rootReducer from '../reducers/index';

// eslint-disable-next-line
const composeEnhancers = window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ || compose;

const routerMid = routerMiddleware(browserHistory);
const middlewares = [routerMid, thunk];

export default function configureStore(initialState) {
  const store = createStore(
    rootReducer,
    initialState,
    composeEnhancers(applyMiddleware(...middlewares)),
  );

  return store;
}


pythonPackages.ansible-lint: 5.0.2 -> 5.0.8

Motivation for this change
Various bug fixes and minor changes, see https://github.com/ansible-community/ansible-lint/releases/tag/v5.0.8
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

FYI: I'm currently updating ansible to 2.10 over in #122670, if you are interested in trying that out! :wink:

@mweinelt Thanks again for the feedback. I noticed one thing since a couple of versions and wonder if you might have an idea (sorry, a bit off-topic now):
During the build it says:
Created wheel for ansible-lint: filename=ansible_lint-0.0.0-py3-none-any.whl

which somehow results in
$ ansible-lint --version
ansible-lint 0.0.0 using ansible 2.9.12

Not really a big deal but somehow annoying. I tried to dig into it a bit but I did not understand where the 0.0.0 is coming from, especially as in other places the correct 5.0.8 is used.

Whoops. Sorry, I only looked at the latest change and pressed merge. Looking into your question now.

The reason why the wheel is created and why it has no proper version is that the nativeBuildInputs are missing setuptools-scm.
https://github.com/ansible-community/ansible-lint/blob/v5.0.8/pyproject.toml#L1-L8
Also for some reason I missed python in buildInputs, that looks unnecessary.
diff --git a/pkgs/development/python-modules/ansible-lint/default.nix b/pkgs/development/python-modules/ansible-lint/default.nix
index c6d66bc5315..d0df1119baf 100644
--- a/pkgs/development/python-modules/ansible-lint/default.nix
+++ b/pkgs/development/python-modules/ansible-lint/default.nix
@@ -2,7 +2,7 @@
 , buildPythonPackage
 , isPy27
 , fetchPypi
-, python
+, setuptools-scm
 , ansible
 , enrich
 , flaky
@@ -27,7 +27,9 @@ buildPythonPackage rec {
     sha256 = "sha256-tnuWKEB66bwVuwu3H3mHG99ZP+/msGhMDMRL5fyQgD8=";
   };

-  buildInputs = [ python ];
+  nativeBuildInputs = [
+    setuptools-scm
+  ];

   propagatedBuildInputs = [
     ansible

which results in this:
❯ ./result/bin/ansible-lint --version
ansible-lint 5.0.8 using ansible 2.9.21

Thanks, I'll apply that on the next update.


feat(vitest): provide a paved path for discovery of tests for *.server.ts files

The default test.include array for vitest is:
['**\/*.{test,spec}.{js,mjs,cjs,ts,mts,cts,jsx,tsx}']

i.e. relevant files that end in .test.ts (or one of these other suffixes)

this is great except that the Remix convention for filenames that should never appear in the client bundle is to add .server.ts to the filename. In other words when using the default test.include for vitest, either:
(a) vitest will miss any tests of "server only" files, or
(b) you can't use the "server only" filename convention
This PR augments the default test.include configuration from vitest to add a conventional place to put tests of "server only" files. With this in place, vitest will find app/utils/puppies.test.ts and it will also find app/utils/__tests__/puppies.server.ts.

Thanks! But we're actually fine as his because we configure remix to ignore test files: https://github.com/remix-run/indie-stack/blob/main/remix.config.js#L6
Thanks anyway. Let me know if I'm missing something.

@kentcdodds Thanks for taking a look at this - unless I'm mistaken, doesn't the ignoredRouteFiles configuration option only pertain to files inside of app/routes/? By way of example, the reason for this PR was that I had the following:
app/
  util/
    formatting.server.ts  <---- want to clearly mark this as "server only" using the ".server.ts" convention

so when I wanted to write tests for my formatting.server.ts, I would have needed to make the test file either:

formatting.test.ts

Discovered by vitest but doesn't include the full name of "file under test" so I lose things like (a) fuzzy file path search won't always hit for both the source and test files, (b) vscode file nesting for source and test files

formatting.server.test.ts

Discovered by vitest but is kinda ugly as a filename

By adding this other glob to the vitest include array, it allows for both the source and test file to be called formatting.server.ts, i.e.:
app/
  util/
    __tests__/
      formatting.server.ts
    formatting.server.ts

so I get (a) nice fuzzy filename matching and file nesting of test files, (b) nice looking filenames, (c) auto-discovery by vitest. The chosen added glob also has the benefit of matching with the pattern jest supports, so it's common to see. I figured that this was going to come up for at least some percentage of users for these stacks, so thought it might be nice to provide the paved path out of the box (similar to how there's a reference authentication implementation even though it won't necessarily satisfy many people's needs/preferences).
Thought I would throw in a few additional thoughts to elucidate my thinking here, but perfectly fine if you would ultimately prefer to leave this out of the stack. Thanks again for taking a look!
Cheers!

I'm happy to add support for the __test__ directory of you'd like to do that. We'll want to add that to the remix config as well.

@kentcdodds In my own personal usage of this stack, I've already introduced this vitest include pattern, and my main goal with the creation of this PR was to make it clear to others how they might accomplish the same - the searchability of this PR accomplishes that goal just as well (imo) as plopping the code into their repo when their stack is generated so I'm not too worried about getting this re-opened and merged.
FWIW, I've really loved playing around with this stack (and Remix in general) so thank you for the awesome work on this! Cheers!


Suggestion: option to delete only files or links

Hello,
First of all - thank you for creating this!
I had a couple suggestions. Don't know if they are possible, but if they are I think they would be useful.
Option to delete just attachments/files/images.
Option to delete just links.
Reason: Users have tens (and sometimes hundreds) of thousands of messages in separate servers & conversations, which takes a lot of time to delete (on top of the occasional errors occur and if user isn't present to restart the process it takes even longer).
Images, files, links (which could be images shared on other websites and posted on discord via link instead of directly, links to social media or accounts on various websites, e-mail addresses) often contain most sensitive personal information. Therefore it would be useful to delete these first instead of going through all of the messages.
When deleting messages it always jumps to top (first messages deleted) and you have to manually scroll down (and hold it) to see the progress/current messages being deleted. Would be convenient if either it didn't jump to top or current messages would be added on top instead of bottom.

@TooDumbToBeADeveloper I like your suggestion, I will add a filter for has:links/images/etc...
About the scroll It should auto-scroll down as it goes, what browser are you using?

@TooDumbToBeADeveloper v3.0.0 released!
Thank you for the suggestion!

Auto detect authToken!
Now you can filter for links or files
Added confirmation dialog with preview before start
Autoscroll is fixed, you can enable and disable it.
Improved ping average calculation
Improved logs
Added help links to author and channel

Hey, sorry for late reply. I'm using Chrome currently. It auto-scrolled down just at the start, but after that it would jump to top (I was deleting 5k+ messages each time).
Great improvements. Thanks!

Not sure if you are notified of comment edits, so I'm writing a new one.
Would it be possible to see the oldest messages being deleted in the prompt? When selecting a large range of messages, at least to me, it would be more useful to see that oldest message that is going to be deleted to make sure I selected correct one, since most of the time I'm well aware of my latest messages.
There seems to be another issue. I have selected a range of messages on a particular server. Prompt said it was ~10k messages. I started the process, but not all my messages are being deleted. I'm only sure about one channel (there might be more channels skipped but can't tell right now). It's a channel mainly dedicated to use bot commands - people use it to play bot games etc. However short discussions happen in that channel as well.


Fixed -next's BitmapData fill color to work the same as flash and -legac...

Fixed -next's BitmapData fill color to work the same as flash and -legacy.
Added unit tests to verify the proper behavior of getPixels(), which helped me discover a couple of problems (one of which Joshua already fixed. ;)
The change to BitmapData.hx matches identical functionality in the _v2 BitmapData.hx.

Note that this won't pass until the fix for #207 gets in.
This test also has a failure on neko I need to figure out. (We create a BitmapData with a fillcolor of 0x80112233, but read back 0x00112233 on neko.) I'm looking for a fix for this.

I fear the unit tests may still fail on this due to a difference in the way neko legacy works. Then again, I guess I'm not sure if we run unit tests on that or not. Looking on Travis to see...

Ack. Yeah, this is failing due to that test. Unfortunately, I'm not at that computer at the moment, but I'll try to make a quick patch to disable that test.


fake run_started_at

for this pr https://github.com/zerocracy/judges-action/pull/317

@yegor256 please merge, it needs for this pr https://github.com/zerocracy/judges-action/pull/317

@rultor release, tag is 0.0.63

@rultor release, tag is 0.0.63

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.63

@yegor256 Done! FYI, the full log is here (took me 24min)

@Suban05 Hey there! 👋 Thanks for your contribution, but we've got some room for improvement. You earned 4 points, but lost some along the way: no code review (-16), only 1 comment (-4), and just 7 hits-of-code (-8). We bumped you up 28 points to keep you motivated. Remember, more code, more reviews, and more comments can boost your score next time! Your balance is now +561. Keep pushing for quality and speed - you've got this! 💪


Feature/#192 generator tests

This PR adds:

Extract functions for better testing.
Add tests for main.rs.
Add a GitHub action for testing if the code coverage is 70% or higher.
If the code coverage is lower as 70% the build pipeline fails.

To use codecov.io the owner of the amosproj has to give access. Asked for it, but don't think it will granted.

Thank you. I used cargo-llvm-cov for that. Wanted to have the result pushed to codecov.io, but for that the amosproj has to give access to the repository. I asked for that, but until today there was no access granted. I implemented it in 179289a9cc5320fec5b30789fcb289c2b9f628c6, but had to remove it until access is granted.


Space in project name acts as a delimiter

Check how we can fix it in go-prompt, if not find and document a workaround.

Double quotes seem to work
project create -name "project name with spaces"

Added to README.


Variable name that is prefixed with other variable name displays two color pickers in :import block

file1.st.css:
:vars {
    mya: rgb(255, 0, 0);
    myaa: green;
}

.root {
    color: value(myaa);
}

file2.st.css:
:import {
    -st-from: "./file1.st.css";
    -st-named: myaa;
}

We get two color pickers next to myaa inside the import. Hovering above myaa shows and accentuates mya.
Other places where myaa is used are displayed fine.

Fixed. Moved from indexOf to Regex for finding variable name


Origin/neeleshk cdn profilelogscrubbing

ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see Getting help section below.
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!

[ ] New API version. (Such PR should have been generated with OpenAPI Hub).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix swagger quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[ ] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Hi @neelesh06! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

Please follow this guide and also check the pipeline failures

{

Please fix Model Validations errors shown in PR.

Refers to: specification/cdn/resource-manager/Microsoft.Cdn/stable/2024-02-01/afdx.json:1 in 0f2797f. [](commit_id = 0f2797f9b450491eca644be474d83df22e62a5b4, deletion_comment = False)

here is the work item to fix the model validation errors https://msazure.visualstudio.com/One/_workitems/edit/25074634.

      "type": "string",

Please define the state as its own definition, and do $ref here and all other places, instead of defining it multiple times.

Refers to: specification/cdn/resource-manager/Microsoft.Cdn/stable/2024-02-01/cdn.json:2969 in 0f2797f. [](commit_id = 0f2797f9b450491eca644be474d83df22e62a5b4, deletion_comment = False)

"ProfileScrubbingRules": {

Need to add/update any examples for this newly added property?

Refers to: specification/cdn/resource-manager/Microsoft.Cdn/stable/2024-02-01/cdn.json:2932 in 0f2797f. [](commit_id = 0f2797f9b450491eca644be474d83df22e62a5b4, deletion_comment = False)

"ProfileScrubbingRules": {

Need to add/update any examples for this newly added property?
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/stable/2024-02-01/cdn.json:2932 in 0f2797f. [](commit_id = 0f2797f, deletion_comment = False)

Profiles_Create.json has defined the new property ProfileScrubbingRules.

      "type": "string",

Please define the state as its own definition, and do $ref here and all other places, instead of defining it multiple times.
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/stable/2024-02-01/cdn.json:2969 in 0f2797f. [](commit_id = 0f2797f, deletion_comment = False)

Do you mean the logscrubbing because we define this 2 times. I created new $def for logscrubbing and using $ref of this definition both the places.


solved bug of dockerfile

Fixes Issue
solved issue #122

Changes proposed

added the required changes in the vite.config.js file to solve the port connection.
reduced the docker image size from 1.46 GB to 466 MB.
added a compose.yml file to support live changes and avoid repeatedly running the container.

Screenshots
video of running container 👇
https://github.com/Nishitbaria/OpenGrame/assets/140754596/01af55d5-0933-49a6-99c8-bc0e1a0bd2dd
redyced size of docker image 👇

hey @Nishitbaria ! Could you please label this PR as 'level2'? It's worth at least that for solving the bug and adding two additional features.

hey @Nishitbaria ! Could you please label this PR as 'level2'? It's worth at least that for solving the bug and adding two additional features.

Can you please also explain me that there is any GitHub action that will build image and push to Docker hub everytime when ever Code commit on GitHub I want that ?
@Dhruv-Pattel

Can you please also explain me that there is any GitHub action that will build image and push to Docker hub everytime when ever Code commit on GitHub I want that ?
@Dhruv-Pattel

yes, it is possible to build and push docker images to docker hub using ci/cd pipelines such as jenkins or github actions.

Can you create one issue regarding that and create it ? For this project ? @Dhruv-Pattel

I think there is no need for that because the workflow already exists in this project and needs an appropriate compose.yaml file for docker, which I have added in this PR.

Okay thanks for confirmation


Does this support Firebase Auth?

Hello, I think I heard you say this hook supports Firebase Authentication too in yesterday's stream. Can you point me towards a resource or documentation about using Firebase Auth with this?
If successful, I would love to send an example as a PR

Alright, I got answer to my question. Firebase Auth is not yet implemented.

I had same question.

@landsman I was poking around this library with a similar question and looks like it's in v1 with docs on the way
See https://github.com/Swizec/useAuth/issues/102

@babycourageous @landsman with v2, just released, we now have the ability to add other providers. Any interest in writing a wrapper for Firebase?

Hi @Swizec
Thanks for the info!
I'm not too familiar with Firebase - but if I get some time to devote to it I can give it a shot.

@Swizec nice, thanks, for sure.

@babycourageous @landsman I have a PR up with beta support for Firebase Auth. Since I'm not a Firebase user it's hard to make sure I got the DX right. Mind giving it a shot?
https://github.com/Swizec/useAuth/pull/148

@babycourageous @landsman I have a PR up with beta support for Firebase Auth. Since I'm not a Firebase user it's hard to make sure I got the DX right. Mind giving it a shot?
https://github.com/Swizec/useAuth/pull/148

@Swizec That's super awesome of ya!
I'm also not a Firebase user unfortunately.
I'll try to find some time to familiarize myself with Firebase stuff and see if I can't take a peek at the DX sometime soon.

@Swizec That's super awesome of ya!
I'm also not a Firebase user unfortunately.
I'll try to find some time to familiarize myself with Firebase stuff and see if I can't take a peek at the DX sometime soon.


Updating a watch stream of a property when only the underlying value has changed.

Is your feature request related to a problem? Please describe.
Currently, even if we select a property in an object watch query, the stream gets updated regardless of whether the value of the property has changed. And there is no definite way to watch only a single property of an object like in hive.
This would come in handy for applications where isar is being used as a settings store.
Describe the solution you'd like
A way to select and watch only a single property like hive's box.listenable(keys: ["property1"]).
A viable solution would be to only update the stream when the underlying value selected for that query has changed, as it sounds logical since the property was explicitly selected.
As an example:
@Collection(accessor: "settings")
class Settings {
	static const isarKey = "contentFilterSettings";

	final Id id = Isar.autoIncrement;

	@Index(unique: true, replace: true)
	final String key = isarKey;

	late bool persistFilters;

	@Enumerated(EnumType.ordinal)
	late List<Language> languages;
}

final selectedLanguageStream = Isar.settings.where()
	.keyEqualTo(id)
	.languagesProperty()
	.watch(fireImmediately: true)
	.asyncMap((e) => e.first);

final wholeStream = Isar.settings.where()
	.keyEqualTo(id)
	.watch(fireImmediately: true)
	.asyncMap((e) => e.first);

selectedLanguageStream.listen((event) {
	print("selectedLanguageStream: $event");
	// Prints only selectedLanguageStream: ...languages: [Language.english, Language.german]
});

wholeStream.listen((event) {
	print("wholeStream: $event");
	// Prints wholeStream: ...languages: [Language.english, Language.german]
	// and wholeStream: ...persistFilters: true
});

Isar.writeTxn(() async {
	final settings = await Isar.settings.getByKey(id);
	await Isar.settings.put(settings.copyWith(languages: [Language.english, Language.german]))
});

Isar.writeTxn(() async {
	final settings = await Isar.settings.getByKey(id);
	await Isar.settings.put(settings.copyWith(persistFilters: true))
});

Version

Platform: Android
Flutter version: 3.7.12
Isar version: 3.0.5

This is not supported by Isar. You have to check it yourself


Stop Propagation for nested button

I have a button inside of a tappable element that has an on click handler. How can I prevent tappable to be triggered when that button is clicked?
<Tappable onTap={()=>doSomething()}>
    <SomeComponentThatHasAButton />
</Tappable>

So inside of SomeComponentThatHasAButton is a button – but Tappable's onTap is still triggered. How to stop this?
NOTE: This also does not work if I change the button to a Tappable-Component.

if the inner button is a Tappable, just add the stopPropagation prop to prevent the tap propagating up to its parent.
if the inner button is NOT a Tappable, then you'll need to call stopPropagation from the click event, and use https://github.com/ftlabs/fastclick to make sure it works on mobile.

Awesome! This seems to have fixed it. Thanks.


Primary surface error

As of 0.5.0 any application I run that uses ddraw.dll gives an error related to drawing of the primary surface. I was not having any issues prior to this new release.
DDrawCompat-SWEP1RCR.log

This game works fine on NVIDIA and AMD, but I don't have an old Intel integrated GPU to test anymore. According to your log, the depth buffer creation fails, which is very odd.
Please upload debug logs by adding "LogLevel=debug" to DDrawCompat.ini.

Here is a log as requested
DDrawCompat-SWEP1RCR.log

I guess there is a similar root cause between your two issues, because in both cases there are no calls to the driver's pfnCreateResource or pfnCreateResource2 functions, which is not normal. I can't figure out why though. Both of your drivers seem very outdated, but since it worked in v0.4.0, that shouldn't be the main problem.
I don't have a better idea at the moment, than to narrow down the scope to the first commit that introduced the problem between v0.4.0 and v0.5.0. I uploaded an archive of builds of all commits between those versions, under the v0.5.0 release, named as "debug-previous-builds". Here's also a direct link:
https://github.com/narzoul/DDrawCompat/releases/download/v0.5.0/DDrawCompat-v0.5.0-debug-previous-builds.7z
I went with 7-zip instead of normal zip this time, because it's 9.4 MB instead of 67.4 MB, I hope that's not a problem, but you can get 7-zip from here if you don't already have it: https://www.7-zip.org/
The builds in the archive are numbered from oldest (v0.4.0-1-g19899f81) to newest (v0.4.0-86-g10d1a3a9). Please try to figure out which was the last working and first broken build. You don't have to try them one by one of course, if you know how to do logarithmic search. Start in the middle, if it looks good, jump to the middle of the newer half, if not, jump to the middle of the older half, etc. to keep narrowing down the range to half of the previous candidates.

This is the result!
v0.4.0-29-g12c4f87c - Works!
v0.4.0-30-gdefdfafe - Does not work!

Wow, that was fast!
It does give me an idea too. I suppose the problem is caused by that D3DDDIFMT_UNKNOWN format under "Supported resource formats" in the log. I just realized that the order in which these formats are printed is not the same as the order originally returned by the driver. It was sorted by the numeric format IDs before printing.
It could be that the Intel driver originally returns this invalid format at the last place, but in the first broken commit you mentioned, the code was altered to return the results to the runtime in the same sorted order that is seen in the logs. It's quite likely that when the runtime encounters this unknown format, it assumes there is a driver bug and stops enumerating the rest. This would explain why it doesn't try to create any resources in the driver and just attempts to emulate every format in software instead.
Here's a quick fix where I just skip the enumeration of that unknown format for now. Hopefully this will solve at least some of the problems:
ddraw.zip (diff.txt compared to v0.5.0)
Let me know if this works any better. If there are still issues, please upload debug logs again.

Unfortunately did not work.
Here is the Debug Log (Nocturne)
DDrawCompat-nocturne.log

My results are the same as Zerodarkage.
DDrawCompat-SWEP1RCR.log

Ugh, looks like this was a false track, D3DDDIFMT_UNKNOWN does not cause any problems, at least when I tested it on my NVIDIA driver.
I finally found a bug which may be responsible, so here is the next fix attempt:
ddraw.zip (diff.txt compared to v0.5.0)
Even if it works, please upload at least info level logs. I changed the way supported resource formats are printed, and I'd like to see what happens on these Intel drivers exactly.

Yes!!! It Works!!!
Here is a debug log (Nocturne)
DDrawCompat-nocturne.log

Works great now!
DDrawCompat-SWEP1RCR.zip

I made a new release (v0.5.1) including this fix, since I suppose it will be a problem for many people.
@PrgmrAtHrt @Zerodarkage @horxd33 Thanks a lot for the good reports and for helping to debug this issue!


Error when trying test inventory mapping and sendTest result

Component MappingStepTestingComponentthrows an error when trying to test inventory mapping and sendTest result.

Issue was fixed in commit ec991e8.


Move installation docs to the new documentation site + language improvements

Update readme to remove some content to readme docs site

Wait for documentation site launch before merging.

Closing due to staleness. Will reopen when it's ready to merge.


fix(transport) Do not panic when building and Endpoint with an invali…

Fixes https://github.com/hyperium/tonic/issues/437

This is a breaking change and we will need to release it as so.


"Open Recent" fails to open projects after closing all previously open Atom windows

Prerequisites

[x] Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
[x] Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
[x] Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
[x] Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
[n/a] Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
After closing a number of Atom windows (I tested between 1 and 4, all different projects), selecting a project from File -> Open Recent results in the project not being opened.
Steps to Reproduce

Open any number of Atom windows
Close all opened windows.
Select a project from File -> Open Recent

Expected behavior:
The selected project would open.
Actual behavior:
The project doesn't open.
Reproduces how often:
Since I noticed the behavior this morning, I'm able to reproduce it 100% of the time.
Versions
MacOS Sierra (10.12.6)

Atom    : 1.18.0
Electron: 1.3.15
Chrome  : 52.0.2743.82
Node    : 6.5.0

apm  1.18.1
npm  3.10.10
node 6.9.5 x64
python 2.7.10
git 2.11.0

Additional Information
I'm not seeing this behavior when I have at least one project window open.

Thanks for taking the time to contribute!
We noticed that this looks like basically a duplicate of https://github.com/atom/atom/issues/12508 so you can subscribe there for updates if you'd like.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


Reduce output size

Reduce the size of the generated code by:

Omitting the parameter names in function declarations
Removing whitespace (e.g. indentation, space between operators)
Compressing stack variable declarations in function implementations

For clang.wasm this optimization reduces the size from 1.3 GiB to 159MiB.

This is HUGE. thanks!


Posts don't look like how they're supposed to

Posts look 'ugly' and do not appear how they are supposed to appear. Might be an issue with the front matter but I've attempted to follow the online guide.

[ x] This is a question about using the theme.
[ ] This is a feature request.
[ ] I believe this to be a bug with the theme.

[ ] I have updated all gems with bundle update.
[ ] I have tested locally with bundle exec jekyll build.

Environment informations

Minimal Mistakes version:
Jekyll version:
GitHub Pages hosted: yes
Operating system: Windows 10

Expected behavior
For posts to look like this
Link to my repo
https://github.com/brandonskerritt/brandonskerritt.github.io
Link to a post on my website:
https://brandonskerritt.github.io/Hello-World/
I  cloned the  theme, customized _config.yml, added my own posts and the posts don't look nice, or how they're supposed to.

Yup, your front matter is wrong. You need to set the correct layout.
Instead of layout: post change them to layout: single.
If you don't want to add layout: single to every post you can also use Jekyll's front matter default feature and set it in your _config.yml to apply to all posts.


Implement media query in this app.

Implement media query in this app for it to be compatible with all kinds of devices.

Ok, assign this task to me

Go ahead @Wizpna

I'm having an issue test ruining the app.
this is the issue
Launching lib\main.dart on Redmi 8 in debug mode...
Running Gradle task 'assembleDebug'...
Plugin project :firebase_core_web not found. Please update settings.gradle.
lib/screens/homescreen.dart:90:29: Error: A value of type 'Translation' can't be assigned to a variable of type 'String'.

'Translation' is from 'package:translator/src/google_translator.dart' ('/C:/flutter/.pub-cache/hosted/pub.flutter-io.cn/translator-0.1.5/lib/src/google_translator.dart').
translateddes = s;
^
lib/screens/homescreen.dart:96:29: Error: A value of type 'Translation' can't be assigned to a variable of type 'String'.
'Translation' is from 'package:translator/src/google_translator.dart' ('/C:/flutter/.pub-cache/hosted/pub.flutter-io.cn/translator-0.1.5/lib/src/google_translator.dart').
translatedtit = s;
^

FAILURE: Build failed with an exception.

Where:
Script 'C:\flutter\packages\flutter_tools\gradle\flutter.gradle' line: 896

What went wrong:
Execution failed for task ':app:compileFlutterBuildDebug'.

Process 'command 'C:\flutter\bin\flutter.bat'' finished with non-zero exit value 1

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 2m 53s
Exception: Gradle task assembleDebug failed with exit code 1

install google translate package in that case.
https://pub.dev/packages/translator

install google translate package in that case.
https://pub.dev/packages/translator

@Wizpna

Hey, I have kinda made PR for this issue. can you check?


feat: support webworker new URL(url, import.meta.url) usage

Description
close: #5979

Additional context

What is the purpose of this pull request?

[ ] Bug fix
[x] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

have you seen https://github.com/vitejs/vite/pull/6138

have you seen #6138

Ah, focus on coding did not check the news from vite, it was a bit late to see it.🤣 But this is okay, I can stop working on this PR, or work in sync with #6138 for reference and discussion, and the final merger is decided by your core team. Again, I am OK with both, and thank @poyoho for his work!

hhh, I forge the SharedWorker

Close this PR and leave a review comment on #6138


Track msgpack fix for array of empty string  mcollina/msgpack5/issues/48

One of my users uncovered and fixed a bug  in the underlying msgpack lib. Which has since been released under msgpack 3.4.1
I'm raising an issue here as a sort of master tracking issue, hoping we can coordinate with @tarruda and @nhynes to get the versions bumped in https://github.com/tarruda/node-msgpack5rpc and https://github.com/neovim/node-client and finally here.
https://github.com/mcollina/msgpack5/issues/48
https://github.com/snoe/clj-refactor.nvim/issues/8

Seems reasonable. You might get a more prompt response if you make a PR/issue in node-msgpack5rpc [and then reference the contrib here so that it gets updated automatically].

Looking at this again this morning, it looks like updating node-host to use neovim-client 2.1.0 actually does bring in the msgpack 3.4 patch. So https://github.com/neovim/node-host/issues/17 should fix this as well.


Fix closing on outside click when opens with contextmenu

Fixes vaadin/vaadin-context-menu#100

This change is

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


chore: add lints to p2p-sync

Add workspace lints, which in particular ban as usage.
Changes:

switch as into From when applicable.
replace the conditional+cast with equivalent logic u64::try_from.

This change is


TS declarations

Do you plan on migrating the TS declarations as well? Old ones could be found at @types/saml2-js

I have never done that before but willing to do it :)
I assume correctly that I can take them from there and modify the module name? (since the underlying code has not been changed)

I‘ll be closing this issue as stale due to the missing reply for almost two years. If this is still something you need, please reopen.


Use file-based store instead of Postgres DB

Store metadata in the file system instead of a Postgres DB.
PR #24 demonstrates that a large user of memory is the Postgres store, specifically building the query for large batch-style requrests. This could be investigated further, but a quick fix is simply to use a file-based store. There is no need to build a query, and files can be looked up quickly using their filename.

Artifacts here.
Current total memory usage at ~1,048,720,760 bytes, a ~18x decrease from existing levels.


New command: get property bag values

Get property bag values

command: spo propertybag list -w|--webUrl <webUrl> -f|--folder [folder]
webUrl: The URL of the site for which property bag values should be listed
folder: server- or site-relative URL of the folder from which to retrieve property bag values
requires connection to a SharePoint site

For more information see the Get-PnPPropertyBag cmdlet

@waldekmastykarz, could you please assign that one to me?

As requested @VelinGeorgiev 👏


PoS Block Producer: Txn Timestamps in MsgDeSoBlock

Current dependencies on/for this PR:

feature/proof-of-stake

PR #578

PR #671

PR #676

PR #700

PR #701

PR #702   👈

PR #689

PR #673
PR #672

This comment was auto-generated by Graphite.

The new RevolutionMetadata as a whole is unused until work on the revolution mechanic is started. Without a full spec for the mechanic, the new metadata type may not account for everything we need to include in the block. There's no rush to build it now.
Please shelf this PR and to revert to the original TransactionsConnectStatus field, since it's what we need for now. Once the spec for the new mechanic is fully ready, we can easily introduce a more full fledged revolution metadata for MsgDeSoBlock later.

Possible naming: Simulated Transaction Timestamps


⚠ Bofrost.be has degraded performance

In 869fa3b, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1315 ms

Resolved: Bofrost.be performance has improved in 52d11b8.


Small package improvements

Description
This PR does 3 small & independent improvements:

make the package version rely on a single source, linkup/_version.py
add a docstring to the client class
add a PR template with the few things I can think of that are important before creating a PR

I'm merging this @glm3 to have this already integrated in the next release I'm doing right after merging the PR, but feel free to have a look/leave comments nonetheless 🙂


Configurable persona

This adds support for a configurable persona (trigger word)
You can set persona in the config file, by default JASPER is assumed.
examples:
persona: JASPER
persona: COMPUTER
persona: JARVIS

Coverage increased (+0.05%) to 41.212% when pulling 3ef1b1e846e8a5e57fb310ce58c57974c0cad7f0 on Azelphur:configurable_trigger into e6789d7475565a166117065809405eb4a21d42f4 on jasperproject:master.

Whoops! sorted now. :)

Coverage increased (+0.3%) to 41.47% when pulling ec02fbe4a39c8c043284cf40bb4a8873f707aed3 on Azelphur:configurable_trigger into e6789d7475565a166117065809405eb4a21d42f4 on jasperproject:master.

no worries, FYI I noticed that on the jasper-dev branch, the configurable persona feature has already been implemented, using the keyword keyword in the profile.yaml file. Though I am not familiar with the current roadmap and when it is planned to merge jasper-dev in master.


[Bug] joern-export tool export incorrect formated .dot files.

When I try to export CPG in dot format using the joern export tool, the resulting dot file format is incorrect, which makes it difficult for libraries such as graphviz and pydot to parse correctly. In contrast, when exporting images such as CFG, PDG, AST, CPG14, etc., the dot format is correct.
For example: joern-export 1.cpg.bin -o 1.cpg.gv --repr cpg --format dot
And I got a file in output results:
digraph {
<PHONE_NUMBER>01[label="METHOD_PARAMETER_OUT CODE="p1" EVALUATION_STRATEGY="BY_VALUE" INDEX="1" IS_VARIADIC="false" NAME="p1" ORDER="1" TYPE_FULL_NAME="ANY"]
<PHONE_NUMBER>90[label=METHOD_RETURN CODE="RET" EVALUATION_STRATEGY="BY_VALUE" ORDER="2" TYPE_FULL_NAME="ANY"]
<PHONE_NUMBER>0[label=BLOCK ARGUMENT_INDEX="1" CODE="<empty>" ORDER="1" TYPE_FULL_NAME="ANY"]
<PHONE_NUMBER>06[label=METHOD AST_PARENT_FULL_NAME="<global>" AST_PARENT_TYPE="NAMESPACE_BLOCK" CODE="<empty>" FILENAME="<empty>" FULL_NAME="<operator>.addressOf" IS_EXTERNAL="true" NAME="<operator>.addressOf" ORDER="0" SIGNATURE=""]
<PHONE_NUMBER>05[label=METHOD_PARAMETER_IN CODE="p1" EVALUATION_STRATEGY="BY_VALUE" INDEX="1" IS_VARIADIC="false" NAME="p1" ORDER="1" TYPE_FULL_NAME="ANY"]
<PHONE_NUMBER>06 -><PHONE_NUMBER>01 [label=AST ]
<PHONE_NUMBER>05 -><PHONE_NUMBER>01 [label=PARAMETER_LINK ]
<PHONE_NUMBER>06 -><PHONE_NUMBER>90 [label=AST ]
<PHONE_NUMBER>06 -><PHONE_NUMBER>05 [label=REACHING_DEF property=""]
<PHONE_NUMBER>05 -><PHONE_NUMBER>90 [label=REACHING_DEF property="p1"]
<PHONE_NUMBER>06 -><PHONE_NUMBER>05 [label=AST ]
<PHONE_NUMBER>90 -><PHONE_NUMBER>06 [label=POST_DOMINATE ]
<PHONE_NUMBER>05 -><PHONE_NUMBER>01 [label=REACHING_DEF property="p1"]
<PHONE_NUMBER>06 -><PHONE_NUMBER>0 [label=AST ]
<PHONE_NUMBER>06 -><PHONE_NUMBER>90 [label=CFG ]
<PHONE_NUMBER>06 -><PHONE_NUMBER>0 [label=CONTAINS ]
<PHONE_NUMBER>06 -><PHONE_NUMBER>90 [label=DOMINATE ]
}

There are 4 main errors of this dot file:

If the attribute value contains special characters such as spaces,<,>,=, etc., it must be enclosed in double quotation marks. Otherwise, it will cause syntax errors.
Graphviz requires that the node ID must be a valid identifier. If the node ID is a pure number (such as<PHONE_NUMBER>01), it needs to be enclosed in double quotation marks, otherwise it will be mistaken for an integer constant.
The attribute value contains special characters such as(such as CODE=""), which need to be enclosed in quotation marks or escaped in some cases.
In Graphviz's. dot file, it is best to use semicolons for each node definition, edge definition, and attribute definition; ending. Your file is missing semicolons.

The corrected file is as follow:
digraph {
  "120259084301" [label="METHOD_PARAMETER_OUT CODE=\"p1\" EVALUATION_STRATEGY=\"BY_VALUE\" INDEX=\"1\" IS_VARIADIC=\"false\" NAME=\"p1\" ORDER=\"1\" TYPE_FULL_NAME=\"ANY\""];
  "128849018890" [label="METHOD_RETURN CODE=\"RET\" EVALUATION_STRATEGY=\"BY_VALUE\" ORDER=\"2\" TYPE_FULL_NAME=\"ANY\""];
  "25769803790" [label="BLOCK ARGUMENT_INDEX=\"1\" CODE=\"<empty>\" ORDER=\"1\" TYPE_FULL_NAME=\"ANY\""];
  "111669149706" [label="METHOD AST_PARENT_FULL_NAME=\"<global>\" AST_PARENT_TYPE=\"NAMESPACE_BLOCK\" CODE=\"<empty>\" FILENAME=\"<empty>\" FULL_NAME=\"<operator>.addressOf\" IS_EXTERNAL=\"true\" NAME=\"<operator>.addressOf\" ORDER=\"0\" SIGNATURE=\"\""];
  "115964117005" [label="METHOD_PARAMETER_IN CODE=\"p1\" EVALUATION_STRATEGY=\"BY_VALUE\" INDEX=\"1\" IS_VARIADIC=\"false\" NAME=\"p1\" ORDER=\"1\" TYPE_FULL_NAME=\"ANY\""];

  "111669149706" -> "120259084301" [label="AST"];
  "115964117005" -> "120259084301" [label="PARAMETER_LINK"];
  "111669149706" -> "128849018890" [label="AST"];
  "111669149706" -> "115964117005" [label="REACHING_DEF" property=""];
  "115964117005" -> "128849018890" [label="REACHING_DEF" property="p1"];
  "111669149706" -> "115964117005" [label="AST"];
  "128849018890" -> "111669149706" [label="POST_DOMINATE"];
  "115964117005" -> "120259084301" [label="REACHING_DEF" property="p1"];
  "111669149706" -> "25769803790" [label="AST"];
  "111669149706" -> "128849018890" [label="CFG"];
  "111669149706" -> "25769803790" [label="CONTAINS"];
  "111669149706" -> "128849018890" [label="DOMINATE"];
}

Perhaps for some reason, you have simplified the file format of dot when exporting CPG, but I think it is best to ensure that the format is standard and only requires some symbol related modifications, so the workload should not be significant.

Joern version: 4.0.116
OS: Ubuntu 24.04
Java version: openjdk 21.0.5 2024-10-15

@mpollmeier
I guess the issue is in io.joern.joerncli.JoernExport.
For Representation.All or Representation.Cpg we use the flatgraph.formats.Exporter (which generates the broken dot output shown here) while for anything else we use io.shiftleft.semanticcpg.dotgenerator.DotSerializer which works correctly.
I am not sure why we made this distinction there and re-implemented the dot exporting logic again within flatgraph if we already had a working one in joern.

Thanks for bringing this up, and yes there's a bit of historical mess in there. I'll take a look today.

didn't get around to looking into this yet

I just pushed michael/dot-export, @yikesoftware can you give it a try and see if this is closer to what you need? Check out the branch, run sbt stage and then something like ./joern-export cpg.bin -o dot-export-cpg-with-joern --repr cpg --format dot
@max-leuthaeuser @yikesoftware there's two differences between the joern DotSerializer and flatgraph's DotExporter:

escaping, as discussed above
flatgraph's exporter is generic and exports all nodes with all properties, while joern's DotSerializer is specific to the cpg schema and only considers a subset of the nodes and their properties.

We never really made a plan for what we really want in the dot export, and there's many different use cases. I guess I'll change the 'all' representation back to the flatgraph exporter, after I added escaping.

I just pushed michael/dot-export, @yikesoftware can you give it a try and see if this is closer to what you need? Check out the branch, run sbt stage and then something like ./joern-export cpg.bin -o dot-export-cpg-with-joern --repr cpg --format dot
@max-leuthaeuser @yikesoftware there's two differences between the joern DotSerializer and flatgraph's DotExporter:

escaping, as discussed above
flatgraph's exporter is generic and exports all nodes with all properties, while joern's DotSerializer is specific to the cpg schema and only considers a subset of the nodes and their properties.

We never really made a plan for what we really want in the dot export, and there's many different use cases. I guess I'll change the 'all' representation back to the flatgraph exporter, after I added escaping.

Thanks! After my testing, your method can indeed export dot format files in the correct format. However, compared to the original approach, each node seems to only have label, and the previously rich attribute information has disappeared. May I ask if it is possible to preserve these high-value attribute information while maintaining the correct export format?
Before:
<PHONE_NUMBER>01[label="METHOD_PARAMETER_OUT CODE="p1" EVALUATION_STRATEGY="BY_VALUE" INDEX="1" IS_VARIADIC="false" NAME="p1" ORDER="1" TYPE_FULL_NAME="ANY"]
<PHONE_NUMBER>90[label=METHOD_RETURN CODE="RET" EVALUATION_STRATEGY="BY_VALUE" ORDER="2" TYPE_FULL_NAME="ANY"]
<PHONE_NUMBER>0[label=BLOCK ARGUMENT_INDEX="1" CODE="<empty>" ORDER="1" TYPE_FULL_NAME="ANY"]
<PHONE_NUMBER>06[label=METHOD AST_PARENT_FULL_NAME="<global>" AST_PARENT_TYPE="NAMESPACE_BLOCK" CODE="<empty>" FILENAME="<empty>" FULL_NAME="<operator>.addressOf" IS_EXTERNAL="true" NAME="<operator>.addressOf" ORDER="0" SIGNATURE=""]
<PHONE_NUMBER>05[label=METHOD_PARAMETER_IN CODE="p1" EVALUATION_STRATEGY="BY_VALUE" INDEX="1" IS_VARIADIC="false" NAME="p1" ORDER="1" TYPE_FULL_NAME="ANY"]

After:
"120259084293" [label = <METHOD_PARAMETER_OUT> ]
"25769803785" [label = <(BLOCK,<empty>,<empty>)> ]
"128849018885" [label = <(METHOD_RETURN,ANY)> ]
"115964116997" [label = <(PARAM,p1)> ]
"111669149701" [label = <(METHOD,printf)> ]

@yikesoftware can you please share how you use or render the dot file?
If i use dot to render a png (e.g. dot -Tpng foo.dot -o foo.png) it does render an image without complaining about the rules you mention above. That being said, it also disregards all properties, so you're likely using a different tool...

@yikesoftware can you please share how you use or render the dot file? If i use dot to render a png (e.g. dot -Tpng foo.dot -o foo.png) it does render an image without complaining about the rules you mention above. That being said, it also disregards all properties, so you're likely using a different tool...

When using previous version to dump dot and make png：
➜  ida_scripts dot -Tpng /home/eqqie/work/ida_scripts/1.cpg.gv/1.c/func1.dot -o test.png
Error: /home/eqqie/work/ida_scripts/1.cpg.gv/1.c/func1.dot: syntax error in line 2 near 'from'
➜  ida_scripts

dot file：
digraph {
<PHONE_NUMBER>7[label=BLOCK ARGUMENT_INDEX="-1" CODE="{
    printf("Hello from func1: %d\n", arg);
    return arg;
}" COLUMN_NUMBER="19" LINE_NUMBER="3" ORDER="2" TYPE_FULL_NAME="void"]
<PHONE_NUMBER>64[label=RETURN ARGUMENT_INDEX="-1" CODE="return arg;" COLUMN_NUMBER="5" LINE_NUMBER="5" ORDER="2"]
<PHONE_NUMBER>6[label=LITERAL ARGUMENT_INDEX="1" CODE=""Hello from func1: %d\n"" COLUMN_NUMBER="12" LINE_NUMBER="4" ORDER="1" TYPE_FULL_NAME="char*"]
<PHONE_NUMBER>6[label=IDENTIFIER ARGUMENT_INDEX="2" CODE="arg" COLUMN_NUMBER="38" LINE_NUMBER="4" NAME="arg" ORDER="2" TYPE_FULL_NAME="int"]
<PHONE_NUMBER>7[label=IDENTIFIER ARGUMENT_INDEX="-1" CODE="arg" COLUMN_NUMBER="12" LINE_NUMBER="5" NAME="arg" ORDER="1" TYPE_FULL_NAME="int"]
<PHONE_NUMBER>97[label=METHOD AST_PARENT_FULL_NAME="1.c:<global>" AST_PARENT_TYPE="TYPE_DECL" CODE="int func1(int arg){
    printf("Hello from func1: %d\n", arg);
    return arg;
}" COLUMN_NUMBER="1" COLUMN_NUMBER_END="1" FILENAME="1.c" FULL_NAME="func1" IS_EXTERNAL="false" LINE_NUMBER="3" LINE_NUMBER_END="6" NAME="func1" ORDER="1" SIGNATURE="int(int)"]
<PHONE_NUMBER>92[label=METHOD_PARAMETER_IN CODE="int arg" COLUMN_NUMBER="11" EVALUATION_STRATEGY="BY_VALUE" INDEX="1" IS_VARIADIC="false" LINE_NUMBER="3" NAME="arg" ORDER="1" TYPE_FULL_NAME="int"]
<PHONE_NUMBER>80[label=METHOD_RETURN CODE="RET" COLUMN_NUMBER="1" EVALUATION_STRATEGY="BY_VALUE" LINE_NUMBER="3" ORDER="3" TYPE_FULL_NAME="int"]
<PHONE_NUMBER>88[label=METHOD_PARAMETER_OUT CODE="int arg" COLUMN_NUMBER="11" EVALUATION_STRATEGY="BY_VALUE" INDEX="1" IS_VARIADIC="false" LINE_NUMBER="3" NAME="arg" ORDER="1" TYPE_FULL_NAME="int"]
<PHONE_NUMBER>2[label=CALL ARGUMENT_INDEX="-1" CODE="printf("Hello from func1: %d\n", arg)" COLUMN_NUMBER="5" DISPATCH_TYPE="STATIC_DISPATCH" LINE_NUMBER="4" METHOD_FULL_NAME="printf" NAME="printf" ORDER="1" SIGNATURE="" TYPE_FULL_NAME="ANY"]
<PHONE_NUMBER>7 -><PHONE_NUMBER>64 [label=AST ]
<PHONE_NUMBER>2 -><PHONE_NUMBER>80 [label=REACHING_DEF property="printf(\"Hello from func1: %d\\n\", arg)"]
<PHONE_NUMBER>97 -><PHONE_NUMBER>6 [label=CFG ]
<PHONE_NUMBER>6 -><PHONE_NUMBER>88 [label=REACHING_DEF property="arg"]
<PHONE_NUMBER>97 -><PHONE_NUMBER>6 [label=REACHING_DEF property=""]
<PHONE_NUMBER>6 -><PHONE_NUMBER>7 [label=REACHING_DEF property="arg"]
<PHONE_NUMBER>7 -><PHONE_NUMBER>92 [label=REF ]
<PHONE_NUMBER>6 -><PHONE_NUMBER>2 [label=REACHING_DEF property="arg"]
<PHONE_NUMBER>97 -><PHONE_NUMBER>6 [label=CONTAINS ]
<PHONE_NUMBER>7 -><PHONE_NUMBER>64 [label=DOMINATE ]
<PHONE_NUMBER>6 -><PHONE_NUMBER>6 [label=CFG ]
<PHONE_NUMBER>6 -><PHONE_NUMBER>97 [label=POST_DOMINATE ]
<PHONE_NUMBER>97 -><PHONE_NUMBER>7 [label=CONTAINS ]
<PHONE_NUMBER>64 -><PHONE_NUMBER>80 [label=DOMINATE ]
<PHONE_NUMBER>97 -><PHONE_NUMBER>92 [label=AST ]
<PHONE_NUMBER>6 -><PHONE_NUMBER>2 [label=CFG ]
<PHONE_NUMBER>6 -><PHONE_NUMBER>80 [label=REACHING_DEF property="arg"]
<PHONE_NUMBER>97 -><PHONE_NUMBER>6 [label=CONTAINS ]
<PHONE_NUMBER>64 -><PHONE_NUMBER>7 [label=POST_DOMINATE ]
<PHONE_NUMBER>2 -><PHONE_NUMBER>6 [label=ARGUMENT ]
<PHONE_NUMBER>6 -><PHONE_NUMBER>6 [label=DOMINATE ]
<PHONE_NUMBER>92 -><PHONE_NUMBER>88 [label=PARAMETER_LINK ]
<PHONE_NUMBER>6 -><PHONE_NUMBER>6 [label=POST_DOMINATE ]
<PHONE_NUMBER>2 -><PHONE_NUMBER>6 [label=ARGUMENT ]
<PHONE_NUMBER>97 -><PHONE_NUMBER>7 [label=AST ]
<PHONE_NUMBER>7 -><PHONE_NUMBER>64 [label=CFG ]
<PHONE_NUMBER>7 -><PHONE_NUMBER>64 [label=REACHING_DEF property="arg"]
<PHONE_NUMBER>92 -><PHONE_NUMBER>6 [label=REACHING_DEF property="arg"]
<PHONE_NUMBER>97 -><PHONE_NUMBER>6 [label=REACHING_DEF property=""]
<PHONE_NUMBER>2 -><PHONE_NUMBER>6 [label=AST ]
<PHONE_NUMBER>97 -><PHONE_NUMBER>7 [label=REACHING_DEF property=""]
<PHONE_NUMBER>80 -><PHONE_NUMBER>64 [label=POST_DOMINATE ]
<PHONE_NUMBER>97 -><PHONE_NUMBER>7 [label=CONTAINS ]
<PHONE_NUMBER>64 -><PHONE_NUMBER>80 [label=CFG ]
<PHONE_NUMBER>7 -><PHONE_NUMBER>2 [label=AST ]
<PHONE_NUMBER>97 -><PHONE_NUMBER>6 [label=DOMINATE ]
<PHONE_NUMBER>7 -><PHONE_NUMBER>2 [label=POST_DOMINATE ]
<PHONE_NUMBER>2 -><PHONE_NUMBER>7 [label=CFG ]
<PHONE_NUMBER>92 -><PHONE_NUMBER>88 [label=REACHING_DEF property="arg"]
<PHONE_NUMBER>97 -><PHONE_NUMBER>2 [label=CONTAINS ]
<PHONE_NUMBER>97 -><PHONE_NUMBER>92 [label=REACHING_DEF property=""]
<PHONE_NUMBER>64 -><PHONE_NUMBER>7 [label=ARGUMENT ]
<PHONE_NUMBER>6 -><PHONE_NUMBER>2 [label=REACHING_DEF property="\"Hello from func1: %d\\n\""]
<PHONE_NUMBER>64 -><PHONE_NUMBER>80 [label=REACHING_DEF property="<RET>"]
<PHONE_NUMBER>6 -><PHONE_NUMBER>2 [label=DOMINATE ]
<PHONE_NUMBER>2 -><PHONE_NUMBER>6 [label=AST ]
<PHONE_NUMBER>97 -><PHONE_NUMBER>64 [label=CONTAINS ]
<PHONE_NUMBER>2 -><PHONE_NUMBER>6 [label=POST_DOMINATE ]
<PHONE_NUMBER>6 -><PHONE_NUMBER>6 [label=REACHING_DEF property="\"Hello from func1: %d\\n\""]
<PHONE_NUMBER>64 -><PHONE_NUMBER>7 [label=AST ]
<PHONE_NUMBER>6 -><PHONE_NUMBER>92 [label=REF ]
<PHONE_NUMBER>97 -><PHONE_NUMBER>88 [label=AST ]
<PHONE_NUMBER>97 -><PHONE_NUMBER>80 [label=AST ]
<PHONE_NUMBER>2 -><PHONE_NUMBER>7 [label=DOMINATE ]
}

When using michael/dot-export version to dump dot and make png：
➜  ida_scripts dot -Tpng /home/eqqie/work/ida_scripts/1.cpg.gv/1.c/func1.dot -o test.png
➜  ida_scripts

It was successful, but it lacked a lot of key attribute information.

@mpollmeier Perhaps the key issue lies only in the handling of quotation marks, as all internal quotation marks need to be manually escaped

what's ida_scripts?

@mpollmeier Perhaps the key issue lies only in the handling of quotation marks, as all internal quotation marks need to be manually escaped.

Just ignore it. I originally planned to use IDA to export some pseudocode and input it into Joern, but I discovered this issue during the testing phase.

@mpollmeier

@mpollmeier
A belated Merry Christmas~
Any update?


truncating description fields to max length of 50 to avoid unit test failure

Adding a TruncateField transformer and using it to truncate description fields from the kodata/release.yaml manifest.

/retest

/retest

/kind bug


Silence a dead store warning.

clang static analysis points out that the value stored into
offset is never read near the end of declareVertexBufferOrdering.
While that is technically correct, removing the store is
dangerous; any code that is later added will have to remember
to store it again.  Instead of removing the store, just put
'(void)offset;' at the end to tell clang not to warn about it.
Signed-off-by: Chris Lalancette<EMAIL_ADDRESS>

Since this should be removed if additional code is added to the block, could the line be added right after the TODO instead? Should be hard to miss there.

Since this should be removed if additional code is added to the block, could the line be added right after the TODO instead? Should be hard to miss there.

Hm, good question.  I'll give it a shot with the static analyzer and see if it is happy there.

Yep, seems happy enough.  Changed in 45937b5

CI:

Linux
Linux-aarch64
macOS
Windows

CI is happy, so merging.  Thanks for the review.


#16477 Connection settings + Readonly toolbar button

Change readonly and non-readonly connection icons

Add confirmation to reconnect if there are active transactions

Save changed settings for active connection only if reconnect is accepted to maintain consistent state

commit transaction is asked even if there are no active transactions. And sometimes confirmation dialog for the one script is shown twice

I tried to reproduce issue about confirmation with no active transactions and found that there is active transaction on the video. The asterisk near the editor tab name points to it. The behavior in this case is the same as on editor close.

Issue about showing twice confirmation dialog exists a long time. I guess we need to create a separate issue for this.
It happens on reconnect when active transaction exists due to editor is dirty because of active transaction.

verified


Do not use ACC-accepting constructor for JBossThreadFactory

Core - Full Integration Build 1260 is now running using a merge of 134cb0628710ca63a9163df0015b5c5330a1c0c7

Windows Build 1659 is now running using a merge of 134cb0628710ca63a9163df0015b5c5330a1c0c7

Linux Build 2126 is now running using a merge of 134cb0628710ca63a9163df0015b5c5330a1c0c7

Linux Build 2126 outcome was FAILURE using a merge of 134cb0628710ca63a9163df0015b5c5330a1c0c7
Summary: Tests passed: 2989, ignored: 47; exit code 1 (new) Build time: 0:19:49
Build problems:
Process exited with code 1

Windows Build 1659 outcome was FAILURE using a merge of 134cb0628710ca63a9163df0015b5c5330a1c0c7
Summary: Tests passed: 2989, ignored: 47; exit code 1 (new) Build time: 0:21:48
Build problems:
Process exited with code 1

Core - Full Integration Build 1260 outcome was SUCCESS using a merge of 134cb0628710ca63a9163df0015b5c5330a1c0c7
Summary: Tests passed: 2930, ignored: 367 Build time: 0:48:34

Linux Build 2127 is now running using a merge of f7a03b590ec81eba24bf803a9700eb4bc1655ff7

Windows Build 1660 is now running using a merge of f7a03b590ec81eba24bf803a9700eb4bc1655ff7

Core - Full Integration Build 1261 is now running using a merge of f7a03b590ec81eba24bf803a9700eb4bc1655ff7

Windows Build 1660 outcome was SUCCESS using a merge of f7a03b590ec81eba24bf803a9700eb4bc1655ff7
Summary: Tests passed: 3364, ignored: 62 Build time: 0:33:19

Linux Build 2127 outcome was SUCCESS using a merge of f7a03b590ec81eba24bf803a9700eb4bc1655ff7
Summary: Tests passed: 3364, ignored: 62 Build time: 0:34:47

Core - Full Integration Build 1261 outcome was SUCCESS using a merge of f7a03b590ec81eba24bf803a9700eb4bc1655ff7
Summary: Tests passed: 2929, ignored: 367, muted: 1 Build time: 0:50:06


Improve the performance Pool.createRef() and Pool.releaseRef()

The class Pool uses a ConcurrentLinkedQueue to store unused references. When profiling some Mastodon code I noticed that the ConcurrentLinkedQueue reduced performance because it triggered regular garbage collector runs.
Using the ConcurrentLinkedQueue has some disadvantages when used to manage the unused references in Pool:

It is slow when used by multiple threads.
It creates a new object for each ConcurrentLinkedQueue.add(...) which puts extra load on the garbage collector.
Unused references are never garbage collected.

This commit introduces a ThreadLocalSoftReferencePool manage the unused references, it is much faster when used with multiple threads.  It also allows the garbage collector to free the unused references if needed.

Hello and bravo Mathias,
As this is very close to the core, I would rely solely on Tobias review for this.
But I can already tell you that he will probably ask you to copy / paste the comparative metrics in the PR for reference :)

Yes, benchmarks would be good...
The idea sounds good, and the code looks also good 👍

I added the benchmark here are the results, (lower is better):
Benchmark                                                      (multiThreaded)  Mode  Cnt     Score    Error  Units
ConcurrentPoolBenchmark.benchmarkConcurrentLinkedQueue                   false  avgt    5    38.371 ±  1.482  ms/op
ConcurrentPoolBenchmark.benchmarkConcurrentLinkedQueue                    true  avgt    5  1062.090 ± 47.354  ms/op
ConcurrentPoolBenchmark.benchmarkNoPool                                  false  avgt    5    19.826 ±  1.589  ms/op
ConcurrentPoolBenchmark.benchmarkNoPool                                   true  avgt    5    77.931 ±  0.686  ms/op
ConcurrentPoolBenchmark.benchmarkThreadLocalSoftReferencePool            false  avgt    5    18.099 ±  0.488  ms/op
ConcurrentPoolBenchmark.benchmarkThreadLocalSoftReferencePool             true  avgt    5    40.988 ±  2.342  ms/op

(Please note: ThreadLocalSoftReferencePool is usually faster that ConcurrentLinkedQueue for our kind of use case. But I also often got very good performance when there was no pool used at all.)


[RE1] Stuck in Piano Room unless you use debug menu

Version
3.2.2
Seed
R710-K862-ZNHH40M5Y9Y00H3N9KMUM494ZZZZZZZZZZZZZZZZZZZZZZZZZ
Scenario
RE 1 (Jill)
Player Character
Enrico
What happened?
I know this room has been talked about before and fixed(?) recently yet I think i still encountered it. Grabbed the item behind bookcase in piano bar. doing so prompted the cutscene where the wall slid down to the alcove with emblem statue. camera was stuck there and i could not see where i was. Reloading the room via debug menu fixed it but thought i should let you know its still happening.

How do I reproduce this? Are there some reliable steps from the start or can you upload a saved game?
The problem before was that the quantity of the music notes needed to be 1, not 0.

so i tried to back and reproduce it myself. but i updated to 3.2.3 after this run and when i put this seed in things were different? i.e. where doors led, enemies, etc. i used debug menu to get back to the bar and picked up item on bookcase but it was normal this time. it didnt trigger the cutscene for the wall closing down again.
i'm trying to think if there was anything else i could have done that would cause the game to do that. i'll upload my save regardless.
SakuraYosei_BarSaveData.zip

Yeah if you have to use the same version that you originally used.

How do I enable this debug menu? Can I get items from it? I'm trying to mix the V-Jolt, but when I try to combine two UMB No. 13 It just drains out one bottle and the other stay as UMB No. 13

F5, but you might need to enable it first by pressing F1 on the CR launcher.


Bug: Wrong imports causing extreme bundle size and prohibits deployments on Edge

[x] Review the documentation: https://clerk.com/docs
[x] Search for existing issues: https://github.com/clerkinc/javascript/issues
[x] Go through package changelog files.
[x] Provide the Frontend API key from your application dashboard.

Package + Version

[ ] @clerk/clerk-js
[x] @clerk/clerk-react
[x] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ ] @clerk/clerk-expo
[ ] @clerk/backend
[x] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] @clerk/chrome-extension
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore
[ ] other:

Dependencies + versions
Provide a json with the dependencies used in your project (copy paste from yarn.lock / package-lock.json) or a github project / template that reproduces the issue.
Include the @clerk/ packages and their versions!*
Example:
{
  "name": "frontend",
  "version": "0.1.0",
  "private": true,
  "scripts": {
    "dev": "next dev",
    "build": "next build",
    "start": "next start",
    "lint": "next lint",
    "storybook": "storybook dev -p 6006",
    "build-storybook": "storybook build"
  },
  "dependencies": {
    "@clerk/nextjs": "^4.19.1",
    "@clerk/types": "^3.43.0",
    "@emotion/react": "^11.11.1",
    "@emotion/styled": "^11.11.0",
    "@mui/icons-material": "^5.11.16",
    "@mui/material": "^5.13.4",
    "@tanstack/react-query": "^4.29.25",
    "@zodios/react": "^10.4.5",
    "axios": "^1.4.0",
    "next": "13.4.2",
    "notistack": "^3.0.1",
    "react": "18.2.0",
    "react-cookie": "^4.1.1",
    "react-dom": "18.2.0",
    "react-responsive": "^9.0.2",
    "styled-components": "^6.0.0-rc.3",
    "validator": "^13.9.0",
    "yarn": "^1.22.19"
  },
  "devDependencies": {
    "@next/eslint-plugin-next": "^13.4.10",
    "@storybook/addon-essentials": "^7.0.23",
    "@storybook/addon-interactions": "^7.0.23",
    "@storybook/addon-links": "^7.0.23",
    "@storybook/blocks": "^7.0.23",
    "@storybook/nextjs": "^7.0.23",
    "@storybook/react": "^7.0.23",
    "@storybook/testing-library": "^0.0.14-next.2",
    "@types/react": "18.2.6",
    "@typescript-eslint/eslint-plugin": "^5.59.7",
    "@typescript-eslint/parser": "^5.59.7",
    "eslint": "^8.40.0",
    "eslint-config-next": "13.4.2",
    "eslint-plugin-storybook": "^0.6.12",
    "openapi-zod-client": "^1.9.0",
    "storybook": "^7.0.23",
    "typescript": "^5.0.4"
  }
}

Browser/OS
Cloudflare Pages
Description
I have created a short repository her describing the issue:  https://github.com/Richard87/cloudflare-test
I first thought the issue was at Cloudflare, but they just found it to be an issue with Clerk: https://github.com/cloudflare/next-on-pages/issues/47#issuecomment-1646076080
If you run the command npx @cloudflare/next-on-pages@1 you will notice a bunch of unneeded wasm files that are generated because of Clerk, which include alot of unneeded dependencies.
Edit
Leaving the a quote from the issue tagged above from Cloudflare:

To me, it seems like Clerk is using things that it has no need to, and, as such, it is resulting in big wasm files (1.4mb total) and webpack chunks that don't need to be there. In your repo for instance, the unzipped middleware function goes from 30kb -> 800kb after our deduping, just because it uses clerk - for some reason it has chunks that are of no relevance, like all of reactjs.
When I look at the chunks that use the Wasm files, and the font, they actually look like they're coming from @vercel/og somewhere, and the chunk that appears to be using the @vercel/og chunk relates to ImageResponse code in Next.js. And that chunk appears to be consumed in the next/server chunk (this code). And the next/server webpack chunk is used in the @clerk/nextjs webpack chunk.

I'm getting this with Vercel and "@clerk/nextjs": "4.23.0", breaking the 50mb limit.

Thanks for the quick turnaround!
Yes, I am using authMiddleware:
import { authMiddleware } from "@clerk/nextjs";

export default authMiddleware({
  publicRoutes: ["/(.*)"],
});

export const config = {
  matcher: ["/((?!.*\\..*|_next).*)", "/", "/(api|trpc)(.*)"],
};

vercel build refuses to build with conflicting versions of Clerk and Next :/
 cloudflare-test git:(master) ✗ npx vercel build
Vercel CLI 31.0.1
Warning: When using Next.js, it is recommended to place JavaScript Functions inside of the `pages/api` (provided by Next.js) directory instead of `api` (provided by Vercel). Other languages (Python, Go, etc) should still go in the `api` directory. Learn More: https://nextjs.org/docs/api-routes/introduction
WARNING: You should not upload the `.next` directory.
Installing dependencies...
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/next
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer next@">=10" from<EMAIL_ADDRESS>npm ERR! node_modules/@clerk/nextjs
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/next
npm ERR!   peer next@">=10" from<EMAIL_ADDRESS>npm ERR!   node_modules/@clerk/nextjs
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/richard/.npm/eresolve-report.txt for a full report.

npm ERR!      /Users/richard/.npm/_logs/2023-07-24T10_15_51_359Z-debug-0.log
Error: Command "npm install" exited with 1

Thanks! upgrading Nextjs did solve the issue! :)

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


storage.$reset() doesn't work fine with parameter

See the plunker given in documentation : http://plnkr.co/edit/YiG28KTFdkeFXskolZqs?p=preview
Open browser's console, click 2 times on "Clear localStorage" :

The first time you click you get the expected behavior : localStorage[ngStorage-x] = 999
The second time you click the localStorage is completely deleted

Any update on this issue?


Replaced centos by alpine to shrink the final image

By using alpine we can save ~210 MB.
docker-cleanup 5.242 MB
meltwater/docker-cleanup 215.7 MB

I tried to run the alpine version of docker-cleanup but it fails to start because alpine doesn't have /bin/bash as is used in the run.sh shebang. Unfortunately the run.sh script also includes some bashisms that fail when changing the shebang to /bin/sh
Perhaps you could have a look at converting the bash specific syntax to standard sh syntax and changing the shebang to /bin/sh so the script works in alpine?
Also, "FROM alpine" could perhaps be "FROM alpine:latest"?
Cheers,
Mikael

Oops! Maybe I installed it the first time when I tried. I'll fix that soon.

For some reason I can't execute the docker binary of the host. It says "not found" in sh and "No such file or directory" in bash. Of course the file is there, stat indicates me that the file is properly executable. So I really have no idea of what's going on. I imagine I badly tested the first time, that's my only guess.
On the other hand, I think it will be better to have docker in the image since we only use the client. This seems to work perfectly as long as you use the last version of Docker and you don't even have to mount the binary anymore:
Example:
docker run --privileged \
    -v /run/docker.sock:/var/run/docker.sock \
    docker-cleanup

The final image size is now 47 MB tough. What's your opinion?

Installing bash looks good, and nicely avoids having to fix the syntax.
Docker should really be mapped from the host though, mostly for api version
reasons.
It's likely you don't have the docker binary installed on the host in
/usr/bin/docker but perhaps e.g. in /usr/local/bin/docker.  So when docker
first sees "-v /usr/bin/docker:/usr/bin/docker:r" and /usr/bin/docker
doesn't exist on the host, it'll create an empty directory called
/usr/bin/docker/
It's a common gotcha that docker automagically creates host directories for
bind mounts if they don't already exist, I've gotten bit by the same thing
several times myself :)
Have a look to see if /usr/bin/docker/ is actually a directory on your
host. If so change the path to the actual binary, e.g. "-v
/usr/local/bin/docker:/usr/bin/docker:r"
Cheers,
Mikael
On 6 Jun 2015 10:50, "Cecile Tonglet"<EMAIL_ADDRESS>wrote:

For some reason I can't execute the docker binary of the host. It says
"not found" in sh and "No such file or directory" in bash. Of course the
file is there, stat indicates me that the file is properly executable. So I
really have no idea of what's going on. I imagine I badly tested the first
time, that's my only guess.
On the other hand, I think it will be better to have docker in the image
since we only use the client. This seems to work perfectly as long as you
use the last version of Docker and you don't even have to mount the binary
anymore:
Example:
docker run --privileged
-v /run/docker.sock:/var/run/docker.sock
docker-cleanup
The final image size is now 47 MB tough. What's your opinion?
—
Reply to this email directly or view it on GitHub
https://github.com/meltwater/docker-cleanup/pull/1#issuecomment-109553516
.

Might want to clean out any metadata that apk downloads and caches as part of the same RUN instruction so it doesn't end up in the layer, but perhaps this isn't an issue on alpine (it is on e.g. centos and Ubuntu)

Here is what I get:
[1] [09:39:46] ~/r/docker-cleanup master > docker run -it -v
/run/docker.sock:/var/run/docker.sock -v /bin/docker:/usr/bin/docker
--entrypoint=/bin/bash docker-cleanup
bash-4.3# stat /usr/bin/docker
File: /usr/bin/docker
Size: 13444448        Blocks: 26264      IO Block: 4096   regular file
Device: 801h/2049d      Inode: 73330       Links: 1
Access: (0755/-rwxr-xr-x)  Uid: (    0/    root)   Gid: (    0/    root)
Access: 2015-06-06 09:38:47.000000000
Modify: 2015-05-14 15:35:42.000000000
Change: 2015-05-23 10:01:39.000000000
bash-4.3# /usr/bin/docker
bash: /usr/bin/docker: No such file or directory
But I think you're right about the API. It's best to have the client and
the server running the same API.
On Sat, 6 Jun 2015 at 11:08 Mikael Johansson<EMAIL_ADDRESS>wrote:

Might want to clean out any metadata that apk downloads and caches as part
of the same RUN instruction so it doesn't end up in the layer, but perhaps
this isn't an issue on alpine (it is on e.g. centos and Ubuntu)
—
Reply to this email directly or view it on GitHub
https://github.com/meltwater/docker-cleanup/pull/1#issuecomment-109554563
.

It actually works fine for us with external docker binary and just installing bash into the alpine image, perhaps there's something odd in your docker setup? Running it on Ubuntu e.g. like
 docker run -e CLEAN_PERIOD=1 -e DELAY_TIME=1 \
   -v /var/run/docker.sock:/var/run/docker.sock:rw \
   -v /usr/bin/docker:/usr/bin/docker:r meltwater/docker-cleanup:latest

Anyhow, I've committed the diff to master and the resulting image virtual size is just 7mb which is awfully sweet, thanks for your help in fixing this issue!
Cheers,
Mikael


Update/rpi2 support

Dont merge this yet, its not ready!!

@shaunmulligan just a small notification to run lunr indexer :) after you finish editing


fix: handle account balance abbreviation

Large account balances were previously shown in exponential notation. This PR abbreviates large numbers using US-standard k/m/b "units", and trims to one decimal place unless it's a zero. Balances under 10k are untouched.
Considered a native approach but decided against for browser compat reasons. We could potentially move this direction after sufficient testing.

We talked about this offline, but if it's below one, like 0.516993575869330778, it should show ~4 significant digits.


Upgrade from deprecated library to its replacement

https://pypi.org/project/msgpack-python/

This package is deprecated. Install msgpack instead.

The problem I had is that I was getting unexpected import warnings. Replace locally with this project folder:
$ python -W error -c "from asgi_amqp import core"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/alancoding/Documents/repos/asgi_amqp/asgi_amqp/__init__.py", line 5, in <module>
    from .core import AMQPChannelLayer # noqa
  File "/Users/alancoding/Documents/repos/asgi_amqp/asgi_amqp/core.py", line 9, in <module>
    import msgpack
  File "/Users/alancoding/.virtualenvs/asgi_amqp_py3/lib/python3.6/site-packages/msgpack/__init__.py", line 25, in <module>
    from msgpack._packer import Packer
  File "msgpack/_packer.pyx", line 8, in init msgpack._packer
ImportWarning: can't resolve package from __spec__ or __package__, falling back on __name__ and __path__

I would write a test for this, but unfortunately this is a warning that pytest itself filters out, and I can't find a way to un-suppress that warning.
After upgrading the dependency and re-installing, I do find that python -W error -c "from asgi_amqp import core" runs and exists without error.

The reason I think this is a good idea is because kombu itself has moved to the new library:
https://github.com/celery/kombu/blob/master/setup.py#L122
The commit where this switch was made:
https://github.com/celery/kombu/commit/9883a300f619e1a78376cce8ab311a7e573337c2
Kombu will still take an existing install of the old library as dependency resolution is done, but I want to upgrade to resolve the warning.

:+1:

msgpack-python is officially deprecated. Please review and merge this PR when there is time.

:shipit:


Remove dead code

I came across these two pieces of code that weren't being used while working on a refactor for DayOneJournal's index.

Merged manually, thanks!


Support jsxstyle components

https://github.com/smyte/jsxstyle experts several components. Glamorous exports element components that resemble the API. In addition to those element components, I'd like to also export the jsxstyle components because they have merit and make it more straightforward for people used to that API. We could learn from what glamor did to support this: https://github.com/threepointone/glamor/blob/master/src/jsxstyle.js
I expect this would just add a handful of lines of code...

This can be closed I think now that there's glamorous-jsxstyle. 😀

Next up, #25!

Yeah but that should be done in this package directly.

Correct :+1:


Type still undefined

thanks @yasaricli for the follow up, i already try it and its still coming undefined
i already try to reinstall it using npm or try specify the version to v1.0.1 but the result still same
its there any thing that i go wrong ?

this is my packge.json after try to reisntall it using npm

this my code

hi @orizzz
Current version 1.2.0, this error has been resolved.
Please try deleting npm cache.
and install it again.
or create a type-still-undefined-9 repo and share it with me.

hi @yasaricli it's still not working dont know why

maybe you can look at my project at https://github.com/orizzz/KashierApp


doesn't crop in xml

I tried using the library in xml according to the example and the image does not get cropped, it just shows the full image. I want the image to be cropped at the bottom. I tried any of the options, without any affect. How do I make it work in xml?

Could you provide more information? Screenshot? Phone? your XML?

Sorry, this is my code:
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:custom="http://schemas.android.com/apk/res-auto"
    android:orientation="vertical"
    android:layout_width="match_parent"
    android:layout_height="match_parent">

    <com.cesards.cropimageview.CropImageView
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:src="@drawable/portrait"
        custom:civ_crop="topLeft" />

</LinearLayout>

my image:
https://upload.wikimedia.org/wikipedia/commons/b/b6/17th-century_unknown_painters_-Portrait_of_a_Silversmith_in_His_Workshop(detail)_-_WGA23541.jpg
it looks like this no matter what I write in the civ_crop:

Are you using an emulator? A phone? what brind and OS? I need to upload a new version of the library and I want to fix any pending issue :-)

I'm using the android studio emulator, with android 6.0 (API level 23).

@cesards I do have the same problem as reported by @stavkidron android a nexus 5X running Android 7.0
Error:(53) No resource identifier found for attribute 'civ_crop' in package 'com.***'

I have the same issue

I found the problem, the correct name of the attribute is 'crop'. Not 'civ_crop' as in example!

https://github.com/cesards/CropImageView/pull/21

@stavkidron
I'm having a look to this again. I know what's going on. You are using:
android:layout_width="wrap_content"
android:layout_height="wrap_content"

in the image, so that means that if the image is smaller than the parent/screen, it's not going to crop. You should be using match_parent for that to happen. I'm going to close this. Let me know if you keep having problems 👍


is there are way to time interval?

I want use
showDateTimePicker

with minute inteval only ( 00, 30)
is there are easy way?
thanks library

Hi @yunchiri,
You could achieve this by using showPicker instead and creating a custom PickerModel
class MyPickerModel extends CommonPickerModel {
...
}

I think it is possible to implement your use case this way. You can take some inspiration from Time12hPickerModel which limits the hours to the [0,11] interval.  And TimePickerModel which can hide the seconds column.

Thanks! have good day 👍


Add ability to load the dart front end using an application snapshot

Generate an application snapshot of dart front end when we generate the core library snapshot and load this into the kernel isolate during VM start up. This should shave the time used for compiling sources when executing the dart front end.

We should consider doing this for the service isolate as well.

@rmacnak-google has implemented this in 9eb216a495f8917ba1bcc55d2555d8203a76c09f

Did we figure out if we were going to link in the snapshot into the executable or leave it as a file in the sdk directory?


fix wrong property assignment in converter

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello @alepironi ,
Thank you very much for this pull request to fix the typo.
Kind regards,
José Manuel Sánchez


update packages

:white_check_mark: Build TheIdServer 1.0.2-maintain-1-0-01-0011 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/c5adc2953a by @)


Schema First Input Object Value Serialization Issues

We need tests validating that schema first works with the new type conversion.

This one is now fixed with #437


Issue using DockerComposeContainer + Spring

I try to use DockerComposeContainer with spring and I cannot make it work correctly.
When I run only one test class using IDE everything is fine but when I try to run all tests, I have the following error (IDE and using mvn command)
org.testcontainers.containers.ContainerLaunchException: Container startup failed
Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception
Caused by: java.lang.NullPointerException: containerId was not specified

It works correctly if I use GenericContainer instead.
I created a repo to reproduce the problem : https://github.com/adrienzieba/testcontainers-test
Abstract class : https://github.com/adrienzieba/testcontainers-test/blob/master/src/test/java/com/example/AbstractIntegrationTest.java
Do I need to do something different with DockerComposeContainer?

Hi! Is you put it to "AbstractTest" class, you should remove ClassRule and
just call ".start()" in "static {}" block. Otherwise, you start an
environment per test class.
Also, it is wrong to use "localhost" there because it's not always true :)
On Fri, 29 Jun 2018 at 19:10, adrienzieba<EMAIL_ADDRESS>wrote:

I try to use DockerComposeContainer with spring and I cannot make it work
correctly.
When I run only one test class using IDE everything is fine but when I try
to run all tests, I have the following error (IDE and using mvn command)
org.testcontainers.containers.ContainerLaunchException: Container startup failed
Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception
Caused by: java.lang.NullPointerException: containerId was not specified
It works correctly if I use GenericContainer instead.
I created a repo to reproduce the problem :
https://github.com/adrienzieba/testcontainers-test
Abstract class :
https://github.com/adrienzieba/testcontainers-test/blob/master/src/test/java/com/example/AbstractIntegrationTest.java
Do I need to do something different with DockerComposeContainer?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/testcontainers/testcontainers-java/issues/765, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABAIivxYGgz29OxavzJMVjGpNtKFSupQks5uBl-MgaJpZM4U9WLi
.

@bsideup Thanks for the quick answer. i'll change to have use dockerComposeContainer.getServiceHost(MONGO_CONTAINER_NAME, MONGO_PORT) instead f localhost :)
Actually, my goal was to start an environment per test class. I don't have real use case yet but I thought that sometimes it is easier to start a new container instead cleaning existing one. With GenericContainer, I am able to use the ClassRule but not with DockerComposeContainer.
Finally I modified the code to start the container inside initialize method :
public void initialize(ConfigurableApplicationContext configurableApplicationContext) {
            DockerComposeContainer dockerComposeContainer = new DockerComposeContainer(new File("src/test/resources/docker-compose-mongo.yml"))
                        .withExposedService(MONGO_CONTAINER_NAME, MONGO_PORT);
                dockerComposeContainer.start();
            final ConfigurableEnvironment environment = configurableApplicationContext.getEnvironment();
            String mongoHost = String.format("mongodb.host=%s", dockerComposeContainer.getServiceHost(MONGO_CONTAINER_NAME, MONGO_PORT));
            String mongoPort = String.format("mongodb.port=%s", dockerComposeContainer.getServicePort(MONGO_CONTAINER_NAME, MONGO_PORT));
            TestPropertySourceUtils.addInlinedPropertiesToEnvironment(environment, mongoHost, mongoPort);
        }

Another question
When we use the @ClassRule, Junit knows when it has to stop the container.
Here we just do a start(). So, how is manages the container when the tests end?

@adrienzieba You can call the corresponding stop() method e.g. in a method annotated with @AfterClass. Also keep in mind, that Testcontainers is starting an additional helper container (ryuk) which will also stop and clean all Testcontainers containers if the JVM exits.


Enable Multiplatform new memory manager

Should we close this one?

Should we close this one?

Yeah, we can resurrect it when we fell ready 😊


fix: removed datasourceContextCaching for RestAPI

Description

Rest Api used cached datasourceContext which was providing older tokens. Now when we look for  datasourceContext we provide a new context.

PR fixes following issue(s)
Fixes #27699
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

[ ] Manual

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test

/ok-to-test