Use zstd for linux kernel modules

Describe the bug
Because trust in XZ has sharply declined (https://github.com/NixOS/nixpkgs/issues/300055), and because Zstandard has comparable compression ratios and (much) faster (de)compression speed.
Steps To Reproduce
[user@system:~]$ zgrep 'XZ\|ZSTD' /proc/config.gz
CONFIG_HAVE_KERNEL_XZ=y
CONFIG_HAVE_KERNEL_ZSTD=n
CONFIG_KERNEL_XZ=y
# CONFIG_KERNEL_ZSTD is not set
CONFIG_RD_XZ=y
CONFIG_RD_ZSTD=y
CONFIG_MODULE_COMPRESS_XZ=y
# CONFIG_MODULE_COMPRESS_ZSTD is not set
# CONFIG_ZSWAP_COMPRESSOR_DEFAULT_ZSTD is not set
CONFIG_FW_LOADER_COMPRESS_XZ=y
# CONFIG_FW_LOADER_COMPRESS_ZSTD is not set
# CONFIG_ZRAM_DEF_COMP_ZSTD is not set
CONFIG_F2FS_FS_ZSTD=y
CONFIG_UBIFS_FS_ZSTD=y
CONFIG_SQUASHFS_XZ=y
CONFIG_SQUASHFS_ZSTD=y
CONFIG_CRYPTO_ZSTD=y
CONFIG_ZSTD_COMMON=y
CONFIG_ZSTD_COMPRESS=y
CONFIG_ZSTD_DECOMPRESS=y
CONFIG_XZ_DEC=y
CONFIG_XZ_DEC_X86=y
CONFIG_XZ_DEC_POWERPC=y
CONFIG_XZ_DEC_ARM=y
CONFIG_XZ_DEC_ARMTHUMB=y
CONFIG_XZ_DEC_SPARC=y
# CONFIG_XZ_DEC_MICROLZMA is not set
CONFIG_XZ_DEC_BCJ=y
# CONFIG_XZ_DEC_TEST is not set
CONFIG_DECOMPRESS_XZ=y
CONFIG_DECOMPRESS_ZSTD=y

Expected behavior
[user@system:~]$ zgrep 'XZ\|ZSTD' /proc/config.gz
CONFIG_HAVE_KERNEL_XZ=y
CONFIG_HAVE_KERNEL_ZSTD=y
# CONFIG_KERNEL_XZ is not set
CONFIG_KERNEL_ZSTD=y
CONFIG_RD_XZ=y
CONFIG_RD_ZSTD=y
# CONFIG_MODULE_COMPRESS_XZ is not set
CONFIG_MODULE_COMPRESS_ZSTD=y
CONFIG_ZSWAP_COMPRESSOR_DEFAULT_ZSTD=y
CONFIG_FW_LOADER_COMPRESS_XZ=y
CONFIG_FW_LOADER_COMPRESS_ZSTD=y
CONFIG_ZRAM_DEF_COMP_ZSTD=y
CONFIG_F2FS_FS_ZSTD=y
CONFIG_UBIFS_FS_ZSTD=y
CONFIG_SQUASHFS_XZ=y
CONFIG_SQUASHFS_ZSTD=y
CONFIG_CRYPTO_ZSTD=y
CONFIG_ZSTD_COMMON=y
CONFIG_ZSTD_COMPRESS=y
CONFIG_ZSTD_DECOMPRESS=y
CONFIG_XZ_DEC=y
CONFIG_XZ_DEC_X86=y
CONFIG_XZ_DEC_POWERPC=y
CONFIG_XZ_DEC_ARM=y
CONFIG_XZ_DEC_ARMTHUMB=y
CONFIG_XZ_DEC_SPARC=y
# CONFIG_XZ_DEC_MICROLZMA is not set
CONFIG_XZ_DEC_BCJ=y
# CONFIG_XZ_DEC_TEST is not set
CONFIG_DECOMPRESS_XZ=y
CONFIG_DECOMPRESS_ZSTD=y

Additional context
(https://github.com/NixOS/nixpkgs/issues/300055)
Notify maintainers
@TredwellGit @Ma27 @NeQuissimus @alyssais
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.7.7-xanmod1, NixOS, 23.11 (Tapir), 23.11.20240308.2be119a`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `""`
 - nixpkgs: `/nix/store/y0c95bwyvs80pm69hdd4b11pyq2ghiwh-source`

Add a :+1: reaction to issues you find important.

Support for zstd has already been added to nixpkgs: #107703. All that remain is a similar change for the MODULE_COMPRESS_XZ config option: https://github.com/NixOS/nixpkgs/blob/d8489497c31f3b08eea1487466004f1f00c42668/pkgs/os-specific/linux/kernel/common-config.nix#L948.

I'm aware of that and I already have a patch locally. Just didn't get around to push it yesterday.

Oh, I already pushed #302291. Hope you don't mind. 😅

Opened https://github.com/NixOS/nixpkgs/pull/302300 now.
Your PR breaks at least 5.10 since the module-loading stuff was introduced in 5.13.
Also, the issue suggested to add enable zstd for zram compression and the firmware loader which the other PR doesn't do.

Ack, will close #302291.

I think for the same reasons (mainly performance), we should also enable zstd support for linux-firmware #267442

Because trust in XZ has sharply declined

Wrong. No one is claiming there are newly discovered problems in the XZ or LZMA algorithms. Please don't spread unfounded FUD and gossip.

Because trust in XZ has sharply declined

Wrong. No one is claiming there are newly discovered problems in the XZ or LZMA algorithms. Please don't spread unfounded FUD and gossip.

I didn't say that XZ has any newly discovered problems. However, it is very much true that trust in the project has declined.

Trust has declined generally, primarily because a lot of codebases now need a thorough auditing. It's unfortunate that it happened to a project with a burnt out maintainer.

Trust has declined generally, primarily because a lot of codebases now need a thorough auditing. It's unfortunate that it happened to a project with a burnt out maintainer.

Spreading FUD about projects being unmainted was how the malicous developer got commit access.


Fix typo in CMake module

The typo caused the math expression to expand to " + 1" for the first available backend, which appears to evaluate to 1 in newer versions of CMake, however causes an error for CMake 3.5.2.

Thanks!


Create 10. Regular Expression Matching

kindly add 5 problems then submit for PR it will be merged

5 problems added please check if any issue let me know
On Tue, Oct 5, 2021 at 11:15 AM John Abraham @.***>
wrote:

Closed #109 https://github.com/mishra10008/HacktoberFest2021/pull/109.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mishra10008/HacktoberFest2021/pull/109#event-5408247705,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APOVKHRHPZGN5Z2ARVLAF4LUFKGIDANCNFSM5FK2BKNA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


oneOf with coercion produces the wrong coerced value

TL;DR:
AJV coercion causes an input that matches a schema to be mutated to an input that does not match.
When using AJV with coercion, it will try to coerce to every type in a oneOf to ensure only one type matches. But after doing this for all types in the oneOf it does not restore the value to the (coerced) value of whatever the matched type was. My example below shows how a valid input is turned into an invalid input after validation with coercion.
What version of Ajv are you using? Does the issue happen if you use the latest version?
v8.12.0
Ajv options object

{
    allErrors: true,
    coerceTypes: 'array',
    strictSchema: false,
    formats: fullFormats,
}

JSON Schema

{
        "$schema": "http://json-schema.org/draft-07/schema#",
        "type": "object",
        "properties": {
                "test": {
                        "oneOf": [
                                { "const": null },
                                { "type": "string", "minLength": 1 }
                        ]
                }
        }
}

Sample data

{ "test": null }

Your code

const Ajv = require('ajv');

const ajv = new Ajv({allErrors:true,coerceTypes:'array',strictSchema:false})

const schema = {
	"$schema": "http://json-schema.org/draft-07/schema#",
	"type": "object",
	"properties": {
		"test": {
			"oneOf": [
				{ "const": null },
				{ "type": "string", minLength: 1 }
			]
		}
	}
};

const validator = ajv.compile(schema);

const input1 = { "test": null };
const input2 = { "test": "test" };

const result1 = validator(input1);
const result2 = validator(input2);

console.log(result1, input1);
console.log(result2, input2);

Validation result, data AFTER validation, error messages
// $ node test.js
true { test: '' } // this no longer matches the schema!
true { test: 'test' }

What results did you expect?
javascript // $ node test.js true { test: null } true { test: 'test' }
Are you going to resolve the issue?
I can try

I see that this is intentional

Even if it succeeds, Ajv will not backtrack, so you'll get the type of the final coercion even if that's not the one that allowed the data to pass validation. If possible, structure your schema with anyOf, which won't validate subsequent subschemas as soon as it encounters one subschema that matches.

https://ajv.js.org/coercion.html
Is this something that could be added to ajv? Or no chance? Willing to give it a try if so

The advice I have always had around JSON Schema's oneOf is that you probably want to use anyOf, and that probably applies doubly so when using coerceTypes. I doubt there is any will to change this or add another option. As you know, every option compounds the combinatorial complex and footprint of the code base, so there would have to be a very compelling reason.


Can you stream multiple arrow tables back ?

I have a usecase where in one do_get request I would like to stream back multiple arrow tables. Currently the stream generator accepts only one schema and a stream.
Assuming that I want to run two sql queries (this is a simplified example) that return two arrow tables, that potentially have different schemas, how do I stream both of them back to the client ?
Is this supported ?
Component(s)
FlightRPC, Python

Currently, the spec would require you to send a separate DoGet request for each query and have it return the two streams separately.
In theory you could leverage the multiple FlightEndpoints that are returned to be different streams (one stream per table) but that is technically against the current Flight spec which assumes that multiple flight endpoints are pieces of the same result set, and thus should have the same schema. So if you did this it wouldn't necessarily be compatible with many flight clients.
So the best options currently are:

Use separate DoGet requests that each return their own result stream
Propose a change to the Flight spec to allow multiple different data streams identified back from the same FlightInfo object
Revive the discussion on allowing schema changes / evolution within a single IPC stream

Thanks for your reply.
I think there is value in being able to return multiple tables that have different schemas for efficiency reasons. There are cases where you might load two different sql tables that have completely different schemas as it is more efficient than sending two DoGet requests.

I agree that there's value in these, I highly encourage you to write something up and send an email to the<EMAIL_ADDRESS>mailing list. These will require changes in semantics of the protocols which will need to be agreed on and prototyped by the community to be integrated into the server/client implementations.


DS-2672 Typos in constants in DOIIdentifierProvider

+1 by inspection.  This just renames two manifest constants.

likewise, +1 by inspection


chore: Remove project board workflow

We no longer use GitHub project boards so this isn't needed
Test plan
n/a

PR to fix the prettier failure first here: https://github.com/sourcegraph/scip/pull/286


Add Buttercup password manager

Microsoft Reviewers: Open in CodeFlow

detection removed

Both the app and the cert have now been cleared by smartscreen


migrate tests to googletest

This removes the static test methods.
You can run all the tests using the following make command.
make test

I've updated the ci pipeline to run the tests automatically.
Running it locally I found that the AdapterTrimmer::test has been failing.
Using google tests has several advantages:

the fastplong binary is smaller since it doesn't include the test code in the final output
google test provides some more advanced testing features like mocking, more robust assertions, etc

If you're running ubuntu, you'll need to install googletest by running this command
apt install libgtest-dev

@sfchen can you have a look at why AdapterTrimmer test is failing?

fixed that test


DRAFT: basic opentelemetry exporter boilerplate

I don't think it's going to be too tough to deliver an OTel exporter. I'm just getting started, but sharing here mainly to show that we could set up an exporter similar to the jaeger exporter, which takes spans and transforms them to a format Jaeger cares about. We could do similar, including or excluding whatever data we want/need, and decorating spans as needed.

@dguy – Updated with working exporter. The OpenTelemetry model for constructing metrics has a deep hierarchy that requires us to flatten out several layers in order to report our own metrics. There might be some structural things that we want to consider adopting early that could be harder to add later. We can catch up about that stuff on Tuesday.
This is still a draft, since we're not quite ready to release an OTel package for public use yet.

Closing, but leaving branch in case we come back to OTel support.


Dronekit fails to connect to serial port

I am using dronekit 2.9.0.  I am unable to get dronekit-python to connect to a serial port on two different systems (Linux and Mac OS) on which mavproxy connects without a problem.  That is, I can run:
$ mavproxy.py --master /dev/ttyUSB0
And get:
Log Directory:
Telemetry log: mav.tlog
MAV> Waiting for heartbeat from /dev/ttyUSB0
fence breach
Pkzzonline system 1
POSHOLD> Mode POSHOLD
APM: APM:Copter V3.4.6 (e707341b)
APM: PX4: de6b667d NuttX: 8c965992

But if I try to connect with dronekit:
Python 2.7.13 (default, Dec 26 2016, 20:43:09)
[GCC 6.2.1 20160830] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import dronekit
>>> v = dronekit.connect('/dev/ttyUSB0')

I get:
>>> No heartbeat in 30 seconds, aborting.
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/pi/.local/lib/python2.7/site-packages/dronekit/__init__.py", line 2827, in connect
    vehicle.initialize(rate=rate, heartbeat_timeout=heartbeat_timeout)
  File "/home/pi/.local/lib/python2.7/site-packages/dronekit/__init__.py", line 2100, in initialize
    raise APIException('Timeout in initializing connection.')
dronekit.APIException: Timeout in initializing connection.

I had the same issue...
I figure it out you need to specify the baud rate... my connection string was:
vehicle = connect('/dev/serial0', wait_ready=True)
and I change it to (specifying the baud rate):
vehicle = connect('/dev/serial0', wait_ready=True, baud=57600)
and now it works!!

I have the same issue as larsks.
I tried to put like alduxvm says, but nothing works. Trying also with /dev/ttyUSB0
It works for me with WiFi connection, but i prefer to work with my telemetry modem

I think this issue may be closed, since a working example is now included in the docs.

I agree. CLosing

Link timeout, no heartbeat in last 5 seconds

No heartbeat in 30 seconds, aborting.
Traceback (most recent call last):
File "wayPoint1.py", line 24, in
vehicle = connect(args.connect, baud=57600, wait_ready=True)
File "build/bdist.linux-x86_64/egg/dronekit/init.py", line 3018, in connect
File "build/bdist.linux-x86_64/egg/dronekit/init.py", line 2262, in initialize
dronekit.APIException: Timeout in initializing connection.

This is what i am getting when i am running..
python waypoint1.py --connect "/dev/ttyUSB0"
My pixhawk is connected with Intel UpBoard on the USB port. I am using FTDI cable.
Please suggest what am i doing wrong??
dronekit              2.9.1
pymavlink           2.2.20
dronekit-sitl         3.2.0


Test mbps

Codecov Report

Merging #10 (27db576) into main (65bff3c) will increase coverage by 3.58%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   88.71%   92.30%   +3.58%
==========================================
  Files           9        9
  Lines         195      195
==========================================
+ Hits          173      180       +7
+ Misses         22       15       -7

Impacted Files
Coverage Δ

src/examples.jl
100.00% <0.00%> (+28.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65bff3c...27db576. Read the comment docs.


Logical error with period/bucket calculations

Pulse Version
1.2.3
Laravel Version
11.10.0
PHP Version
8.1
Livewire Version
3.4.9
Database Driver & Version
No response
Description
Aggregate bucket timestamps are based on epoch timestamps in seconds; however, "periods" are in minutes. It appears there's a logical error here.
Example: 2 pulse_aggregates rows for the same type and key. The period is 7 days (10080 minutes). The bucket timestamps are<PHONE_NUMBER> and<PHONE_NUMBER>, a difference of 10,080 seconds.
Surely, since the timestamps are in seconds, the difference should be 604,800 seconds to represent a 7-day gap?
I'm unsure if this is an oversight or intended. Happy to produce a PR to fix!
Steps To Reproduce
Install pulse in a fresh laravel project, and ensure data is being stored in pulse_entries and pulse_aggregations.

Hi @ercsctt,
This is intentional. Buckets hold 1/60th of the window they belong to.
60 is somewhat arbitrary, but there are two reasons we chose it:

60 points looks pretty good on the graphs.
For the "leaderboard" cards, we aggregate multiple buckets together to fill as much of the window as possible, and then combine that with raw data from the pulse_entries table to fill in the oldest part of the window where the oldest bucket would fall partially inside and outside the window. This allows us to do rolling window aggregation down to the second. I.e. we can show windows like "the past hour" rather than tumbling windows like "10am - 11am". 60 buckets seems like a good balance that keeps the number of raw entries queried to a minimum without creating too many buckets.

window
seconds
1/60th
bucket size

1 hour
3,600
60
1 minute

6 hours
21,600
360
6 minutes

24 hours
86,400
1,440
24 minutes

7 days
604,800
10,800
2 hours, 48 minutes

I explained the approach in more detail here: https://www.youtube.com/watch?v=9cliEswA8CA&pp=ygUYbGFyYXZlbCB3b3JsZHdpZGUgbWVldHVw


FINITE: Convert the Lean+Duper proofs from 467, 1133, 1167, 1441, 1443, 1681, 1701 to Lean proofs

See  https://leanprover.zulipchat.com/#narrow/channel/458659-Equational/topic/Austin.20pairs/near/481257624
When done, update Conjectures.lean accordingly.

See the related thread at https://leanprover.zulipchat.com/#narrow/channel/458659-Equational/topic/FINITE.3A.20The.20Lean.2BDuper.20implications

The implications from 1133, 1167 can also be resolved by #985, while the implications from 1441, 1443, 1681, 1701 can be resolved by #986.  However no alternate route for 467 is known currently.

Subsumed by #985, #986, #987.


Tool Stoped

The tool keep stooped at the 5% without any results even if I run it on my private server

Hello
the screen you provided show that the tool is working in collecting urls step
and it takes alot of time based on the website size and pages numbers inside it
please give it some time
and keep me updated


[WIP] Tracing events / refactor proxy / state traces

This is a WIP PR that comprises 3 efforts:

Refactor proxy to remove deprecated rental crate, requiring no unsafe code.
Implement tracing Events and hierarchical relationships between spans with each other and also events.
State tracing for Sidecar

In order to test this PR I have merged in changes from https://github.com/paritytech/substrate/pull/6401 into this branch.
I had also experimented with moving some functionality from client into primitives to allow proxy direct access to span store, but it's not feasible for multiple reasons.
Using this method to generate traces from wasm (tracing Events) has added around 500-600ns overhead (on development machine) compared to current. This is unacceptable overhead IMO and needs resolving. Switching to use channels for span / event processing does not apparently make any difference.
TODO:

[ ] fix performance regression
[ ] improve output from events
[ ] bounds checks and handle possibility of lost spans accumulating
[ ] add docs
[ ] code organisation

Closing this in favour of splitting the PR to get some changes done sooner


Minor edits

Reference Issues/PRs
What does this implement/fix? Explain your changes.

Minor edits in show_faces_list function
AUTHORS.md updated

Any other comments?

@sadrasabouri review 🔥


gargoyle: 2017-05-17 -> 2017-08-27

Motivation for this change
Several updates and bugfixes
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Well that's sub-optimal. I don't have an OSX machine to test with.

Note that the commit message does not fit our contribution guidelines. Use the same message as the PR title please. :)

Corrected that, at least.

Thanks!


Support for @augment tag

Search Terms
jsdoc, augment, extends
Problem
The cli throws errors when @augments tag is used.
A related issue is #2659
Suggested Solution
The @augments tag can be added to the allow list.
Ill be able to create a pull request for this.

I'm honestly kind of shocked that the usage of this tag (according to GitHub search) is as high as it is... PR welcome!


Package command should not require aws cli config/credentials

I've been integrating zappa into an AWS Codebuild/Codepipeline. When running on a codebuild instance, zappa fails with the stack trace shown below. Clearly it's failing initializing boto due to the lack of aws config and credentials files. But when doing a package command, I do not believe any AWS resources are utilized, hence this command should work without the credentials.
Steps to reproduce locally (without codebuild):

cd into a directory with a working zappa build
activate the virtual env
Run "mv ~/.aws ~/.aws.bak" (so that boto cannot find config and credentials)
run "zappa package  -o lam.zip"

Environment:
Ubuntu 16.04 and 14.04
Python 3.5.2
zappa 0.42.0
Workaround:
Create a  config and credential files in a valid format, but invalid crentials like this:
config:
[default]
output = json
region = us-west-2

credentials:
[default]
aws_access_key_id = XXXXXXXXXXXXXXXXXXXX
aws_secret_access_key = XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

(note: those are ACTUALLY X's in the file, I'm not trying to hide valid credentials)
and point the environment variables AWS_CONFIG_FILE and AWS_SHARED_CREDENTIALS_FILE to these files. Since it's just an issue with initializing boto and no aws resources are accessed, the zappa package command then succeeds
Stack Trace:
Traceback (most recent call last):
File "/codebuild/output/src623405482/src/.python/lib/python3.5/site-packages/zappa/cli.py", line 2353, in handle
sys.exit(cli.handle())
File "/codebuild/output/src623405482/src/.python/lib/python3.5/site-packages/zappa/cli.py", line 456, in handle
self.dispatch_command(self.command, stage)
File "/codebuild/output/src623405482/src/.python/lib/python3.5/site-packages/zappa/cli.py", line 482, in dispatch_command
self.load_settings(self.vargs.get('settings_file'))
File "/codebuild/output/src623405482/src/.python/lib/python3.5/site-packages/zappa/cli.py", line 1801, in load_settings
runtime=self.runtime
File "/codebuild/output/src623405482/src/.python/lib/python3.5/site-packages/zappa/core.py", line 248, in __init__
self.load_credentials(boto_session, profile_name)
File "/codebuild/output/src623405482/src/.python/lib/python3.5/site-packages/zappa/core.py", line 2354, in load_credentials
self.boto_session = boto3.Session(profile_name=profile_name, region_name=self.aws_region)
File "/codebuild/output/src623405482/src/.python/lib/python3.5/site-packages/boto3/session.py", line 80, in __init__
self._setup_loader()
File "/codebuild/output/src623405482/src/.python/lib/python3.5/site-packages/boto3/session.py", line 120, in _setup_loader
self._loader = self._session.get_component('data_loader')
File "/codebuild/output/src623405482/src/.python/lib/python3.5/site-packages/botocore/session.py", line 701, in get_component
return self._components.get_component(name)
File "/codebuild/output/src623405482/src/.python/lib/python3.5/site-packages/botocore/session.py", line 897, in get_component
self._components[name] = factory()
File "/codebuild/output/src623405482/src/.python/lib/python3.5/site-packages/botocore/session.py", line 181, in <lambda>
lambda: create_loader(self.get_config_variable('data_path')))
File "/codebuild/output/src623405482/src/.python/lib/python3.5/site-packages/botocore/session.py", line 265, in get_config_variable
elif self._found_in_config_file(methods, var_config):
File "/codebuild/output/src623405482/src/.python/lib/python3.5/site-packages/botocore/session.py", line 286, in _found_in_config_file
return var_config[0] in self.get_scoped_config()
File "/codebuild/output/src623405482/src/.python/lib/python3.5/site-packages/botocore/session.py", line 358, in get_scoped_config
raise ProfileNotFound(profile=profile_name)
botocore.exceptions.ProfileNotFound: The config profile (default) could not be found

Confirming this as a bug. Please note that you should only use Python 2.7 or 3.6, not 3.5.

@brianrower This is irrelevant to the bug. How is your CodePipeline working? I assume you don't have a CodeDeploy part, right? You just run: zappa update {env} in your CodeDeploy?

@devyhia We do not use zappa deploy/update to do our deployments and we instead package and then do a cloud formation step to deploy. We do this for two reasons:

the zappa deploy/update commands issue CLI commands to create some things, we prefer instead that everything is created in a single cloud formation stack.
We deploy to multiple environments, so we prefer to be able to build the lambda zip package once and then deploy the same package to multiple environments instead of re-building the package for each environment we deploy to.


Sonarr Install Broken

New features
Please visit http://feathub.com/htpcBeginner/AtoMiC-ToolKit
The problem
I am getting an error with the Sonarr installation script not being able to find nzbDrone.
My Linux distribution and version is:
Ubuntu Server 16.04
I'm seeing this behaviour on:
A fresh install
Link to install logs
--->Stopping Sonarr...
Nothing found to stop
--->Removing Sonarr Systemd Startup scripts...
sonarr.service SystemD script not found
--->Removing Sonarr Init.d startup scripts...
/etc/init.d/sonarr init script not found
--->Removing Sonarr default config scripts...
/etc/default/sonarr default script not found
--->Adding Sonarr repository...
deb http://apt.sonarr.tv/ master main
--->Adding Sonarr Keys...
Executing: /tmp/tmp.nNdcd3vsdV/gpg.1.sh --keyserver
hkp://keyserver.ubuntu.com:80
--recv-keys
FDA5DFFC
gpg: requesting key FDA5DFFC from hkp server keyserver.ubuntu.com
gpg: key D9B78493: public key "NzbDrone<EMAIL_ADDRESS>imported
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)
AtoMiC Mono Installer Script
--->Adding Mono repository...
Mono repository already exists
--->Refreshing packages list...
W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list:58 and /etc/apt/sources.list.d/google-chrome.list:3
W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list:58 and /etc/apt/sources.list.d/google-chrome.list:3
W: Target Translations (main/i18n/Translation-en_US) is configured multiple times in /etc/apt/sources.list:58 and /etc/apt/sources.list.d/google-chrome.list:3
W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list:58 and /etc/apt/sources.list.d/google-chrome.list:3
W: Failed to fetch http://apt.sonarr.tv/dists/master/InRelease  Could not connect to apt.sonarr.tv:80 (<IP_ADDRESS>), connection timed out
W: Some index files failed to download. They have been ignored, or old ones used instead.
W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list:58 and /etc/apt/sources.list.d/google-chrome.list:3
W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list:58 and /etc/apt/sources.list.d/google-chrome.list:3
W: Target Translations (main/i18n/Translation-en_US) is configured multiple times in /etc/apt/sources.list:58 and /etc/apt/sources.list.d/google-chrome.list:3
W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list:58 and /etc/apt/sources.list.d/google-chrome.list:3
Done
Sonarr Repo timeout:
sudo apt update
Hit:1 http://download.mono-project.com/repo/ubuntu xenial InRelease
Ign:2 http://dl.google.com/linux/chrome/deb stable InRelease
Hit:3 http://dl.google.com/linux/chrome/deb stable Release
Hit:4 http://us.archive.ubuntu.com/ubuntu xenial InRelease
Hit:6 http://us.archive.ubuntu.com/ubuntu xenial-updates InRelease
Hit:7 http://security.ubuntu.com/ubuntu xenial-security InRelease
Hit:8 http://us.archive.ubuntu.com/ubuntu xenial-backports InRelease
Get:9 http://download.zerotier.com/debian/xenial xenial InRelease [11.5 kB]
Err:10 http://apt.sonarr.tv master InRelease
Could not connect to apt.sonarr.tv:80 (<IP_ADDRESS>), connection timed out
Fetched 11.5 kB in 2min 0s (96 B/s)
Reading package lists... Done
Building dependency tree
Reading state information... Done
All packages are up to date.
W: Failed to fetch http://apt.sonarr.tv/dists/master/InRelease  Could not connect to apt.sonarr.tv:80 (<IP_ADDRESS>), connection timed out
W: Some index files failed to download. They have been ignored, or old ones used instead.
--->Installing prerequisites for Mono...
Reading package lists... Done
Building dependency tree
Reading state information... Done
libmono-cil-dev is already the newest version (<IP_ADDRESS>-0xamarin3+ubuntu1604b1).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
--->Installing Mono...
Reading package lists... Done
Building dependency tree
Reading state information... Done
mono-complete is already the newest version (<IP_ADDRESS>-0xamarin3+ubuntu1604b1).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
---> Mono installation complete.
--->Installing Sonarr...
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package nzbdrone
--->Stopping Sonarr...
Nothing found to stop
--->Autostart configuring...
Using systemd
--->Removing Sonarr Init.d startup scripts...
/etc/init.d/sonarr init script not found
--->Removing Sonarr default config scripts...
/etc/default/sonarr default script not found
--->Enabling Sonarr Autostart at Boot...
Created symlink from /etc/systemd/system/multi-user.target.wants/sonarr.service to /etc/systemd/system/sonarr.service.
sonarr.service SystemD script added and enabled
--->Starting Sonarr...
sonarr.service is now: inactive
I'm not a dummy, so I've checked these!

I'm using the latest version of AtoMiC-ToolKit.
All my Linux distro packages are up to date and I don't see any errors while updating.
I've checked there are no current open issues relating to my problem!

The repo seems to be back up and working again.  Closing the issue.


typo

"hightlighted"

Thanks Val.  I make that typo a lot.  I did a grep and found a few other cases too.  It will be fixed on the main site in the morning.


Would it be useful to integrate login with username ?

Has mentionned in #126

I just scanned the devise documentation and found this:
https://github.com/plataformatec/devise/wiki/How-To:-Allow-users-to-sign-in-using-their-username-or-email-address
So it is possible with standard devise, but the process seems to be rather involved. Also, I'm not sure if this gem will require any modifications to accommodate for this kind of setup.
And in addition to following the steps from the wiki, a new config option will need to be added to ng-token-auth to specify which params are sent to the sessions controller (i.e. username instead of email).
I think the best course of action is to add a test suite that follows the example in the devise wiki. If it works, then that's great, and if not then we can modify this gem as is needed. I'm short on time right now, but I'll get around to it as soon as I can.

I'm available to do it, but I don't use to work with MiniTest :( I'll try tomorrow to work with ``MiniTest`

Thanks @nicolas-besnard - I appreciate any help I can get :smiley:
To get the dev environment set up, you can follow these steps.
I recommend the following approach to testing this feature:

Create a new model and migration in the test app that follows the example in the devise wiki. The existing models are here - you can just follow those for examples.
Create tests for each of the cases described in the wiki example. This includes:

registration (link to existing tests)
confirmation (link)
sign in (link)
password reset (link)
test using both case-sensitive and case-insensitive authentication keys for all of the above

Once all of the tests pass, make sure they pass using the following:

ruby 1.9.3
ruby 2.1
sqlite
mysql
postgresql

Let me know if you run into any trouble!
Thanks in advance :+1:

What happened if validation is required and you sign-in with username ? Email HAS to be present right ?

Just to clarify, are you asking if an email address is required to use confirmable? In that case, yes - we would require an email address to create the account. But subsequent sign-ins should be possible using the the user's username (or whatever the authentication key is called).

Yes, but when a new user register, he should have specified an email, right ? With or without confirmable.

I'm not sure about this actually. I don't see any explicit references to an email param in the devise source for registrations or sessions.
I think devise may rely on the authentication_keys array, but I'm not sure how this works for modules like confirmable and recoverable that require emails to be sent.
You may need to check the devise source code on this.

I will dig into it. I usually use rspec for my test. Is there any way to run a single test ?

To run a single test, just type the word focus right above the test. I'm using this gem I think.

I just made a PR. The login looks good to me, I need to dig into the registration now.

@nicolas-besnard - I just merged your PR - this should be fixed as of v0.1.32.beta2.
I pushed everything up to the demo site and it seems to be working there. Let me know if you see any issues.

Oh and congratulations, you're now an official contributor:
https://github.com/lynndylanhurley/devise_token_auth#callouts
:boom: :sparkles: :bouquet:


Add the ROMs to build and PyTest

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

With ale-py v0.9+ packaging the ROMs within the PyPI wheel, this PR look to add this to the ale-py conda-forge version as there is no other way of including the ROMs
Additionally, previously, there was no testing of the package, this PR adds pytest call

@Tobias-Fischer The ROMs are added but pytest won't run for some reason

Thanks for handling this @pseudo-rnd-thoughts !  Where do they come from?
The script download_unpack_roms.sh download a file without checking its hash from a gist from https://gist.github.com/jjshoots . This create a risk of a supply chain attack.

If you prefer we can also bring the discussion offline.

@traversaro I've messaged you on discord about it, in short, I'll update the download script to include the hash

Now we have some actual test failures @pseudo-rnd-thoughts. On py313:
==================================== ERRORS ====================================
_______________ ERROR collecting tests/python/test_atari_env.py ________________
tests/python/test_atari_env.py:48: in <module>
    for env_id, spec in gymnasium.registry.items()
E   AttributeError: module 'gymnasium' has no attribute 'registry'. Did you mean: 'register'?
__________ ERROR collecting tests/python/test_legacy_registration.py ___________
tests/python/test_legacy_registration.py:6: in <module>
    gymnasium.register_envs(ale_py)
E   AttributeError: module 'gymnasium' has no attribute 'register_envs'

We also need to add the ROMs on Windows builds.

What version of gymnasium is being used? It should be v1.0

We don't have 1.0 yet: https://github.com/conda-forge/gymnasium-feedstock/pull/41
It's a bit confusing - who is depending on whom? It seems like gymnasium needs ale-py (from that PR), but here ale-py needs gymnasium (this PR)?

I think gymnasium hasn't been migrated to py313; so it is using an old version that was noarch: python that is incompatible.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.
Here's what I've got...
For recipe/meta.yaml:

❌ requirements: run: numpy>=1.21.0 must contain a space between the name and the pin, i.e. numpy >=1.21.0

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11970051235. Examine the logs at this URL for more detail.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I remember that when this was discussed in the context of gymnasium 1.0.0, you had come to the conclusion that the gymnasium tests depending on the ROMs should be skipped (AFAIR due to the license situation)? Has anything about that changed?

@traversaro Do you understand the problem with python_abi not existing for python 3.13
https://anaconda.org/conda-forge/python_abi exists with 3.13

I remember that when this was discussed in the context of gymnasium 1.0.0, you had come to the conclusion that the gymnasium tests depending on the ROMs should be skipped (AFAIR due to the license situation)? Has anything about that changed?

Not that I am aware of, but @pseudo-rnd-thoughts  probably knows more?

@traversaro Do you understand the problem with python_abi not existing for python 3.13
https://anaconda.org/conda-forge/python_abi exists with 3.13

I guess that the problem is that there was not rebuild for python 3.13 for gymnasium, I am not sure why 3.13 builds are enabled here instead.

I guess that the problem is that there was not rebuild for python 3.13 for gymnasium, I am not sure why 3.13 builds are enabled here instead.

FYI the 3.13 builds of gymnasium are blocked by https://github.com/conda-forge/box2d-py-feedstock/pull/13 .

Ohh that makes sense, thanks for clarifying and the quick reply

There seem to be three types of tests failing

Python 3.13, the ale-py provides wheels for it, conda does not currently
Linux aarch64 and ppc64 are timing out, no idea why
Windows - The ROMs are not included in the build for some reason, therefore, the tests fail. Looking on PyPI, the window wheels do include the ROMs so I don't understand why they don't appear in the logs

For Windows: we need to execute the equivalent of “bash scripts/download_unpack_roms.sh” to include the ROMs. I’m not sure how upstream does it.

@conda-forge-admin please rerender

For the cross compiled builds: I’ve disabled the emulated tests as they seem too slow.


Confirm that cmdi file is returned when the HTTP-accept header has “application/x-cmdi+xml”

TODO:

we need to have some Item with CMDI file - maybe it could be added into python import script?

7. Persistent Identifiers - Centres need to associate PIDs (handles or DOIs) with their metadata records.

it redirects to a CMDI file for the HTTP-accept header “application/x-cmdi+xml”
it redirects to an HTML file when accessing it from a browser
Individual files (e.g. a text, zip or sound file) can be referred to with either the handle of
the describing metadata record in combination with a part identifier11 or with another
handle.

Works on port 88 with good nginx
curl -k http://dev-5.pc:88/handle/11234/1-5438 -L -H "Accept: application/x-cmdi+xml"
does not work on bad nginx
curl -k https://dev-5.pc:8443/handle/11234/1-5438 -L -H "Accept: application/x-cmdi+xml"
It is because of nginx directive
if ($query_string ~* "format=cmdi"){
                rewrite ^/(.*)handle/(.*)$ http://$http_host/server/cmdi/oai-metadata?metadataPrefix=cmdi&handle=$2? redirect;
            }
            if ($http_accept ~ "(.*cmdi.xml*)"){
                rewrite ^/(.*)handle/(.*)$ http://$http_host/server/cmdi/oai-metadata?metadataPrefix=cmdi&handle=$2? redirect;
            }

which IS in wiki. (and enables other header values, since regex is used, and  other kind of links as well
curl -k http://dev-5.pc:88/handle/11234/1-5438?format=cmdi -L
)

add commands to check to Wiki

add to 8443 nginx as well

Some Item could have specific CMDI file - during creation the admin upload a cmdi file which will be returned. He need to click on Has CMDI checkbox. Confirm that specific cmdi file is returned.

@MajoBerger
https://github.com/dataquest-dev/DSpace/blob/dtq-dev/dspace-server-webapp/src/main/java/org/dspace/app/rest/CMDIRestController.java

Return uploaded CMDI file from the CMDI bundle if:

The Item has metadata local.hasCMDI = yes
The Item has file in the CMDI bundle

waiting for tests and then review

Done, works, added to wiki etc.

Where in the wiki? Post a link here pls

https://github.com/dataquest-dev/DSpace/wiki/Installation#check


create-operatorroles: Auto-find policies for roles

Since the operator role policies created through 'rosa create
account-roles' are tagged with the operator metadata, we can drop the
requirement for a user-set prefix and instead automatically find the
corresponding policy.

Fixed it, I was validating the prefix regex even if a prefix wasn't set. This new version only checks the regex if there's a prefix

/lgtm


When release 24.04 update for Ubuntu app in Microsoft Store?

ITNOA
Hi
As I know Ubuntu 2x.0x app in Microsoft store exists for users to want using specific ubuntu version on WSL and Ubuntu app in Microsoft store exists for seamless upgrading and updating.
But my problem is why Ubuntu app not update for Ubuntu 24.04.1? as you can see in Microsoft store, the description of the app is about ubuntu 22.04.3

Ubuntu currently provides the 22.04.3 LTS release.

But I except after releasing next LTS zero point one (x.x.1) this app update to next LTS version, and automatically update currently WSL
In another word, I except if I install Ubuntu app from Microsoft store, in one year ago, I see Ubuntu 22.04 in WSL and after updating this app from Microsoft store in September, I see Ubuntu 24.04 in WSL without needing any command line interaction
My question is, When canonical release this update for this app in Microsoft Store with above functionality in seamless upgrading?
thanks

as you can see, this information shows that app is not updated to latest LTS yet

It's finally there! You should see this when installing the latest Ubuntu app from MS Store.


Update docs and samples for new API surface

[ ] remove AddDeveloper extension method
[ ] rename SetSigningCredential to Add
[ ] remove AddInMemoryStores

done


RealSense D455 not being Detected on Jetson nano

librealsense
2.55.1 RELEASE

OS
Linux

I followed this procedure

The complexity of the MIPI driver installation instructions is aimed at developer teams rather than individuals.  I would instead recommend trying to install the librealsense SDK using the simple libuvc backend build script at the link below in order to bypass the kernel and make the librealsense build not dependent on a particular JetPack version.

https://github.com/IntelRealSense/librealsense/blob/master/doc/libuvc_installation.md
and even build it from source but realsense-viewer seems unable to detect the board.
Kindly help debug this issue.

lucifer@lucifer:~/librealsense-2.55.1/scripts$ lsusb
Bus 002 Device 005: ID 8086:0b5c Intel Corp. Intel(R) RealSense(TM) Depth Camera 455
Bus 002 Device 002: ID 0bda:0489 Realtek Semiconductor Corp. 4-Port USB 3.0 Hub
Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 001 Device 003: ID 13d3:3549 IMC Networks Bluetooth Radio
Bus 001 Device 005: ID 413c:301a Dell Computer Corp. Dell MS116 Optical Mouse
Bus 001 Device 006: ID 05ac:0220 Apple, Inc. Aluminum Keyboard (ANSI)
Bus 001 Device 004: ID 05ac:1006 Apple, Inc. Hub in Aluminum Keyboard
Bus 001 Device 002: ID 0bda:5489 Realtek Semiconductor Corp. 4-Port USB 2.0 Hub
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
lucifer@lucifer:~/librealsense-2.55.1/scripts$ rs-enumerate-devices
No device detected. Is it plugged in?
lucifer@lucifer:~/librealsense-2.55.1/scripts$

Camera is detected by lsusb but not by librealsense2.

So I was able to make it detect after purging

dpkg -l | grep "realsense" | cut -d " " -f 3 | xargs sudo dpkg --purge
However it is still not able to get the IMU(Motion module) checked from realsense-viewer. It stops other streams too if I enable Motion Module stream first.

Alright I solved this by downgrading the firmware to 5.15 followed this article: > https://community.intel.com/t5/Items-with-no-label/Downgrade-RealSense-Firmware/m-p/582488
And then rebuild using

https://github.com/IntelRealSense/librealsense/blob/master/doc/libuvc_installation.md

For line 46 I changed it to have this
cmake ../ -DFORCE_LIBUVC=true -DCMAKE_BUILD_TYPE=release -DBUILD_EXAMPLES=true -DBUILD_GRAPHICAL_EXAMPLES=true -DBUILD_WITH_CUDA=on -DFORCE_RSUSB_BACKEND=TRUE

Works like a charm after this. Thanks to the previous github issues that helped me solve this one.


On in-loop es6 variables still warns about Functions declared within loops referencing an outer scoped variable may lead to confusing semantics.

Even when referencing in-loop es6 let or const variables jshint 2.9.5 still issues a warning.
Here is a simple example referencing the let defined loop variable.  My actual use case is referencing a const variable defined within the loop.  I suggest the behavior in these cases is clear and should not result in a warning.
function test() {
    const funcs = [];
    for (let ii = 0; ii < 100; ++ii) {
        funcs.push(function () {
            console.log(ii);
        });
    }
    funcs.forEach(f => f());
}

Result:
test.js: line 4, col 20, Functions declared within loops referencing an outer scoped variable may lead to confusing semantics.

The test was conducted with the following .jshintrc:
{
    "bitwise": true,
    "curly": true,
    "eqeqeq": true,
    "eqnull": true,
    "expr": true,
    "latedef": true,
    "onevar": true,
    "noarg": true,
    "node": true,
    "trailing": true,
    "undef": true,
    "unused": true,
    "esversion": 6
}

My earlier search didn't find a duplicate issue, but I now see #3100.

I agree with your reading: this issue describes the same problem as gh-3100. I'll close this in favor of that one to keep things organized. Thanks for taking the time to report, though. If you'd like to work on a patch, I would be happy to lend a hand!


chore(main): release 1.24.2

:robot: I have created a release beep boop
1.24.2 (2023-09-27)
Bug Fixes

hide locator error text (#163) (109ff2e)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/aidanaden/canvas-sync/releases/tag/v1.24.2 :sunflower:


feat: DEV-1490: TimeSeries overview width param

Add param overviewWidth to set default width in percents (default 25%)

issue: https://github.com/heartexlabs/label-studio/issues/1330


Adding a patch to limit rufio bmclib drivers

Description
bmc-lib tries to establish a connection to check compatible protocols (redfish, ipmi etc) for all supported implementations. These changes modify Rufio to only use Redfish and IPMI protocols for all hardware.
Why is this needed
Rufio opens a new connection via bmc-lib for every reconcile loop. In the latest version of bmc-lib support for IntelAMT protocol was added. It was noticed that on older hardware when users try to run Rufio, IntelAMT takes too long to establish a connection and hence blocks the reconcile thread. This was causing timeouts of Rufio Tasks when it exceeded 3 mins to hit the connection timeout.
Fixes:
Timeout issues on older hardware due to Rufio reconcile threads getting blocked when bmc-lib provider open connection calls hang and timeout.
How Has This Been Tested?
make docker-build and tested the controller.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/cherry-pick release-0.15


[Bug Report] "TypeError: 'float' object does not support indexing" in step method after 12M steps of training.

Describe the bug
Describe the bug
The code suddenly reaches a "TypeError" when calling the step method after 12M steps of training.
Code example
I am using gym.vector.AsyncVectorEnv(). I use the function make_envto create my environments.
def make_env(gym_id, seed, idx, capture_video, run_name, qubits, depth):

    def thunk():
        env = gym.make(gym_id, qubits=qubits, depth=depth, env_id=idx)
        env = gym.wrappers.RecordEpisodeStatistics(env)
        if capture_video and idx == 0:
            env = gym.wrappers.RecordVideo(env, f"videos/{run_name}")
        return env

    return thunk

The main part of the code is as follows:
if __name__ == "__main__":
    mp.set_start_method('spawn')
    device = torch.device("cuda" if torch.cuda.is_available() and args.cuda else "cpu")
    envs = gym.vector.AsyncVectorEnv(
        [make_env(args.gym_id, args.seed + i, i, args.capture_video, run_name, qubits, depth) for i in range(args.num_envs)],
    shared_memory=False)
    agent = AgentGNN(envs, device).to(device)#Graph Neural Network
    for update in range(1, num_updates + 1):
        for step in range(args.num_steps):
            global_step += 1 * args.num_envs
            dones[step] = next_done
            try:
                with torch.no_grad():
                    action, logprob, _, value, logits, action_ids = agent.get_action_and_value(next_obs_graph, device=device)
                    values[step] = value.flatten()
                actions[step] = action
                logprobs[step] = logprob

                next_obs, reward, done, deprecated, info = envs.step(action_ids.cpu().numpy())
            except TypeError as e:
                print(f"Error: {e}")
            rewards[step] = torch.tensor(reward).to(device).view(-1)

            next_done = torch.Tensor(done).to(device)

As far as I understand the error, this code generates as much threads as environments I want. In one particular thread , the agent breaks in env.step(). As you can see, I tried to solve this issue with a try-except, but this does not work. I think this can be because the thread just keeps on hold until it breaks but I am not sure.
Traceback
ERROR: Received the following error from Worker-31: TypeError: 'float' object does not support indexing
ERROR: Shutting down Worker-31.
ERROR: Raising the last exception back to the main process.
Traceback (most recent call last):
File "/home/jan.nogue/RL-ZX/Copt-cquere/rl-zx/ppo_async.py", line 198, in
next_obs, reward, done, deprecated, info = envs.step(action_ids.cpu().numpy())
File "/home/jan.nogue/miniconda3/envs/gymnasium/lib/python3.10/site-packages/gymnasium/vector/vector_env.py", line 203, in step
return self.step_wait()
File "/home/jan.nogue/miniconda3/envs/gymnasium/lib/python3.10/site-packages/gymnasium/vector/async_vector_env.py", line 333, in step_wait
self._raise_if_errors(successes)
File "/home/jan.nogue/miniconda3/envs/gymnasium/lib/python3.10/site-packages/gymnasium/vector/async_vector_env.py", line 544, in _raise_if_errors
raise exctype(value)
TypeError: 'float' object does not support indexing
/home/jan.nogue/miniconda3/envs/gymnasium/lib/python3.10/site-packages/gymnasium/vector/async_vector_env.py:460: UserWarning: WARN: Calling close while waiting for a pending call to step to complete.

### System info

I use gym 0.26.2, torch 2.0.1 and python 3.10.14. I am using Ubuntu 24.04 LTS. All of the packages were installed using pip.

### Additional context

_No response_

### Checklist

- [X] I have checked that there is no similar [issue](https://github.com/Farama-Foundation/Gymnasium/issues) in the repo

Thanks for your issue however I'm uncertain how this is directly related to Gymnasium. If you could point out a piece of code within Gymnasium that is causing the issue that would be helpful.
I'm guessing that it is not within the AsyncVectorEnv but the environment as after 12 million steps seems a bit random.
Due to AsyncVectorEnv asynchronous's nature that discovering environment is highly difficult
Could you run using SyncVectorEnv and when the error occurs then it should print the whole stack trace

I've created #1119 to help with this problem if you can use it


Datadog agent ZK check timeout with 4lw commands due to no EOL (\n)

Note: If you have a feature request, you should contact support so the request can be properly tracked.
Output of the info page
    zk (4.2.0)
    ----------
      Instance ID: zk:e907c44234f6a1e1 [ERROR]
      Configuration Source: kubelet:docker://d58392b5188ee121428a6adb8da451dec4f0456a649989b500f9a8a2cf522179
      Total Runs: 5,084
      Metric Samples: Last Run: 3, Total: 15,252
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 1, Total: 5,084
      Average Execution Time : 3.023s
      Last Execution Date : 2022-09-30 18:09:41 UTC<PHONE_NUMBER>000)
      Last Successful Execution Date : Never
      Error: timed out
      Traceback (most recent call last):
        File "/opt/datadog-agent/embedded/lib/python3.8/site-packages/datadog_checks/zk/zk.py", line 256, in _send_command
          return self._get_data(sock, command)
        File "/opt/datadog-agent/embedded/lib/python3.8/site-packages/datadog_checks/zk/zk.py", line 234, in _get_data
          chunk = ensure_unicode(sock.recv(chunk_size))
      socket.timeout: timed out

      During handling of the above exception, another exception occurred:

      Traceback (most recent call last):
        File "/opt/datadog-agent/embedded/lib/python3.8/site-packages/datadog_checks/base/checks/base.py", line 1120, in run
          self.check(instance)
        File "/opt/datadog-agent/embedded/lib/python3.8/site-packages/datadog_checks/zk/zk.py", line 131, in check
          ruok_out = self._send_command('ruok')
        File "/opt/datadog-agent/embedded/lib/python3.8/site-packages/datadog_checks/zk/zk.py", line 258, in _send_command
          raise ZKConnectionFailure(exc)  # Include `exc` message for PY2.
      datadog_checks.zk.zk.ZKConnectionFailure: timed out

Additional environment details (Operating System, Cloud provider, etc):

Cloud provider: AWS EKS
Kubernetes version: 1.22
Datadog Agent version: 7.38.2
Zookeeper version (image): docker.io/bitnami/zookeeper:3.7.0-debian-10-r265

Steps to reproduce the issue:

Expose necessary 4lw commands on Zookeeper pods with env vars: ZOO_4LW_COMMANDS_WHITELIST : srvr, mntr, ruok, stat
Add pod annotation for Zookeeper pods as:

      ad.datadoghq.com/zookeeper.check_names: |
          ["zk"]
      ad.datadoghq.com/zookeeper.init_configs: |
          [{}]
      ad.datadoghq.com/zookeeper.instances: |
          [
            {
              "host": "%%host%%",
              "port": "2181"
            }
          ]

check with datadog agent command agent status on the same node with the zookeeper pod and get the timeout error:
I tried the new annotation format as well for Zookeeper pods as below but got the same error.

    ad.datadoghq.com/zookeeper.checks: |
      {
        "zk": {
          "instances": [
            {
              "host": "%%host%%",
              "port": "2181"
            }
          ]
        }
      }

Describe the results you received:
Zookeeper metrics are not collected after applying Datadog agent integration with Zookeeper. After running agent status on the Datadog agent pod, it looks like the zk check timeout when checking ruok command from the Zookeeper pod.
Describe the results you expected:
zk pod should be in OK status and the metrics are shown in datadog.
Additional information you deem important (e.g. issue happens only occasionally):
I did a check that the network is good between datadog agent pod and zookeeper pod, since I could hit the port 2181 on the zookeeper pod and get the right response on the datadog agent pod shell.
root@datadog-agent-42zdq:/# echo ruok | pv | nc <IP_ADDRESS> 2181
5.00 B 0:00:00 [ 443KiB/s] [   <=>                                                                                ]
imok

I just noticed it sends 5 bytes to the Zookeeper pod instead of 4 (the length of ruok), so I guess it also includes a \n. I checked the zk check python code and saw it just sends the 'ruok' as command string here: https://github.com/DataDog/integrations-core/blob/a454afcdf95b843218fc6cbd13ba2757feb9f60e/zk/datadog_checks/zk/zk.py#L131 The situation looks like this:

zk check sends ruok to Zookeeper pod and waits for the response
Zookeeper pod receives ruok and waits for \n
zk check times out after 3 seconds

To verify this, I set a breakpoint on the ZK check and ran the check with the agent check command. When hitting the breakpoint, I changed the command string of 'ruok' to 'ruok\n' manually, and then it passed. (well, still failed at the command 'stat' with the same error later as expected).

Hi @rockc2020, I've had a look at the issue but I haven't been able to reproduce it. I've tested against the same ZooKeeper version (3.7.0) and the commands don't time out despite not ending in a new line. Therefore, it may have something to do with your specific setup.
To investigate your issue further, can you please open a support ticket?

hi @alopezz thanks for reply and yes, I have a ticket as well, case id 960334.

Thanks for the update, I'm closing this then.


Move tasks to the data_tasks directory

For:

https://github.com/hypothesis/report/issues/47

Testing

tox -e dev --run-command "python bin/run_data_task.py --task report/refresh"

Feel free to merge this when fix BTW. Don't worry about me giving it a thumbs up


Need help

Hi mister i'm back for another problem.
In my chat i would like to add a column in message table to add the receiver id, so i'll be able the make a conversation with only two guys.
The problem is i'm not famillar with vue yet and need to insert this receiver_id in the message table.
In the route get this id now how to insert it in the table with vue it's my proble.
Thank to help very import it's the last thing i need .
Sincerly yours.

Please answer i really need this

I have done it for information.
Any way thank i know you don't have may be enought to expent here


Add release date to CHANGELOG.md

https://swift.org/blog/swift-3-1-released/

@swift-ci please smoke test and merge


Localization (i18n):  notes and planning

Introduction
Soliciting discussion over the localization (i18n) strategy for this project.
Goals
Goal 1: Localize everything
The goal is complete localization of all messages visible to the user, within the bounds of POSIX compliance:

All util messages, collation sequences, charsets and other util i18n details
All --help messages and related output (clap crate)
All OS error messages (io::Result)
It is believed that some minimum set of strings are required to be English/POSIX permanently.  Minimize this POSIX-only set as much as possible.

Goal 2: Encourage UTF-8
To be forward-looking, this project looks for opportunities to

Drop support for non-UTF 8 strings
Default to UTF-8 charsets and strings

This project should aggressively interpret the POSIX standards in terms of UTF-8 support, and look for opportunities to create default-UTF-8 operating modes, with a fallback mode that is "POSIX-ly correct."
Implementation strategies
Current strategy
The current strategies are,

use the gettext crate, and mark strings with gettext().  This provides a starting point for per-util coding, and at least gets us started on the road to i18n.
each util sets the charset thusly,

    bind_textdomain_codeset(PROJECT_NAME, "UTF-8")?;

Improvements to our i18n
At present, OS error messages and --help are not translated at all, and need a project-wide strategy.
Also, one idea that is aligned with the gencat util is to generate catgets message catalogs and abandon gettext.  This works because catgets exists on all modern platforms.
See issue #65 for util-related tasks.
Feedback and thoughts are requested.  We want to give users the best i18n support possible.

posixutils-rs Localization Proposal
Author: Luke Frisken
Related https://github.com/rustcoreutils/posixutils-rs/issues/72
Requirements:

Prefer a single strings output file, or, a single output file per supported language
Need to have a strategy for

app strings
OS error strings: all the errno error codes. e.g. "no such file or directory" upon open.
--help strings.

It would be nice if app and help strings are embedded within each util's source code, and extracted with cargo xtr a la gettext crate, but not required.
Must use POSIX-standard environment variables such as NLSPATH (described in each man page) or LC_COLLATE (sort order)
a single message file for posixutils as a whole. It creates a distribution nightmare to have one-file-per-util, and that also eliminates the strong possibility of sharing strings and sharing translations across utils.
Does not impact the normal build + test process in a large & negative way (e.g. slows down each build by 10 minutes would be negative). Developer productivity and developer throughput is a goal.

BOTH of the following implementation strategies are valid:
(1) extract strings from each .rs source file
(2) the "IBM approach": assign unique numbers to each and every error message, whether app-specific or generic, and maintain a posixutils global set of strings (and their translations)
Considerations/Research
2b) OS Error Strings
According to https://stackoverflow.com/questions/43019882/does-libc-show-international-error-messages it seems like we should be able to use https://docs.rs/libc/latest/libc/fn.strerror.html to gain access to system provided localized messages for libc errno codes, but it sees like there might be some safety concerns related to using this function that will warrant more investigation if we use it  https://users.rust-lang.org/t/unsafe-and-strerror-impossible-to-fix/90804
Most likely posixutils-rs will preference using Rust  standard library functions over libc. Perhaps we can use https://doc.rust-lang.org/stable/std/io/struct.Error.html#method.raw_os_error
It seems like it should be possible https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=52ae229dd19b14298c25d488516d3750 . Here is the output using the french locale installed on my system:

It seems like libc::setlocale() needs to be called manually using the contents of  the relevant environment variables, the locale for libc is not automatically detected from the available environment variables.
Interestingly the std::io::Error implementation appears to defer to libc::strerror()  for its output, so there will be no need for us to call libc::strerror() manually, we can simply use the std::fmt::Display output provided we configure libc using libc::setlocale() This almost feels like an oversight on the part of Rust’s standard library not to have this functionality enabled by default on platforms that support it.
2c) –help messages
With the exception of m4 all the binaries in posixutils-rs currently use clap’s derive macro to generate help messages.  In https://docs.rs/clap/latest/clap/_derive/index.html#command-attributes the about attribute accepts an expression about [= <expr>] which presumably gets put into https://docs.rs/clap/latest/clap/struct.Command.html#method.about. To use this with localized messages, the messages would need to be available in a ’static lifetime. To get around this we could use some kind of static thread-local or global cell containing a mutex that can be used to load the appropriate locale at the start of main() based on the current system settings, before executing clap. Another issue is that using the about attribute disables the parsing of help messages from the doc attribute provided by Rust’s documentation comments, which means that if we want to have these struct fields documented in the standard way for Rust, we will end up with duplicated text. We could probably get around this by creating a custom derive macro which wraps clap’s one to use the documentation comments for these fields in the localization system and provide the necessary about too to satisfy the optional requirement 3. There does come a question about the source of truth: if each application is sharing messages in a single registry as per requirement 5., then we may end up with duplicates that need to be detected. Perhaps it is better just to refer to localizations only by a message id, and keep it separated from code documentation comments, this does make the implementation a lot simpler too. Whatever we decide to do here should follow on from the more general decision about how to localize strings in the application for requirement 2a.
Message Format
While an obvious choice for message format would be to use GNU gettext, some arguably better and more modern alternatives do exist. fluent puts forward some good arguments for the choices it makes that are different https://github.com/projectfluent/fluent/wiki/Fluent-vs-gettext In summary of this article:

Using a message identifier unique from the source string makes the process of updating source language simpler (without invalidating translations and relying on fuzzy matching), and enables different translations for messages which may have identical English words but which in some translations may result in different words based on the context in which they are used, without the burden being on the developer to recognise these situations. It also enables message re-use/composition via references.
Gettext’s support for grammatical rules is very limited.
String formatting and message arguments are an afterthought for Gettext.
Fluent uses a single data format, Gettext uses 3.
Rust’s compiler messages are translated using fluent https://rustc-dev-guide.rust-lang.org/diagnostics/translation.html, a significant endorsement.

Further comparisons between systems and crate implementations:

There are two Rust crates for gettext,https://docs.rs/gettext/latest/gettext/  (which claims to be a work in progress, pure rust implementation, hasn’t been updated in 5 years), and https://docs.rs/gettext-rs/latest/gettextrs/  bindings to GNU gettext (bringing the associated downsides of using a C dependency in a Rust project).
i18n-embed  + i18n-embed-fl provides some additional functionality on top of a basic fluent setup:

Static checking of message keys and format arguments using procedural macro, this is a big one, avoiding common runtime error mistakes. There is another library which does this for fluent using codegen
A standardized layout for localization resources that enables building more static analysis tooling for cargo-i18n https://github.com/kellpossible/cargo-i18n/issues/31 Actually it’s possible to benefit from these without actually using i18n-embed but simply using the i18n.toml config file to use with cargo-i18n.
Some alternatives that provide similar functionality
https://github.com/zaytsev/fluent-static ttakes an alternative approach to i18n-embed-fl and uses codegen instead of a proc macro, this provides code completion and type signatures for messages as functions (there is an open issue to implement this for i18n-embed-fl https://github.com/kellpossible/cargo-i18n/issues/73 ).
https://github.com/MathieuTricoire/l10n

Burden on compilation:

gettext adds 9 additional crate dependencies, an additional 0.05s to build time.
gettext-rs adds 6 crate dependencies, additional 144s to build time (if static build), or 0.8s if using gettext-system feature for dynamic linking.
fluent brings in an additional 15 crate dependencies, additional 0.7s to build time.
i18n-embed + i18n-embed-fl brings an additional 55 dependencies, additional 4.5s to build, I have some ideas for how to bring this down considerably (https://github.com/kellpossible/cargo-i18n/issues/131).

An important consideration for which message format to use is its support in localization tooling. Because posixutils-rs is by its nature a technical tool it’s not unreasonable to expect translators working on the project would be familiar and fine working with plain text files and a git repository in order to make contributions to the project.
https://github.com/baptiste0928/rosetta Another alternative based on a json message serialization format and custom string formatting, with code generation for static type checking.
A custom message format could be constructed using a serialization format like TOML and message formatting/arguments using something like https://github.com/dtolnay/basic-toml and https://lib.rs/crates/minijinja if serde were an acceptable dependency, however currently none of our tools depend on serde, and considering strings are sprinkled throughout the code and serde derive macro has a reputation for increasing compile times if used extensively, probably we want a solution that doesn’t rely on it.

Proposal
This proposal is that we definitely use the fluent localization system instead of gettext, for a minimal setup it could potentially even have a lower overhead, and has none of the licensing concerns with LGPL gettext for systems that must build it statically, it seems like an obvious choice after considering the tradeoffs. If localization is to be taken seriously the features the fluent provides over other simpler ad-hoc systems with simple message formatting are very important.
The next decision is what to use for the scaffolding around fluent. Messages must be loaded from disk, bundles must be configured according to the user’s requested locale, ideally some form of static checking should be employed in order to help prevent mundane runtime errors. If keeping dependencies to a bare minimum is a high priority then we could gradually implement this ourselves from scratch. If however there is a desire to share this functionality with the rust community at large, then I’d propose to use i18n-embed-fl and cargo-i18n and upstream any changes which may be required in order to make it fit the requirements of this project. I’m the maintainer for those projects so I’d be very happy to take on this responsibility if that’s the direction we decide to go with.

Related recent unsolicited work: #254

https://github.com/rustcoreutils/posixutils-rs/pull/340#issue-2588836043

@jgarzik raised some interesting points regarding this:

The POSIX.2024 spec adds CLI utilities gettext, xgettext, etc.
These utils directly reference gettext-related functions.

With this in mind, it seems like, despite it's shortcomings, it looks like gettext is fully endorsed by the POSIX.2024 spec, and therefore in the spirit of implementing it, it would be best to use gettext for the implementation of localisation of these utilities.  If we will be implementing the gettext and xgettext CLI utilities then it makes sense to dogfood them on this project.
For gettext library functions we have two pre-existing options:

gettext-rs bindings to GNU gettext

Option to dynamically or statically link, in order to comply with its license I gather we would have to dynamically link with it, which seems like something we'd probably rather avoid if possible.

gettext rewrite of gettext library functions in Rust

MIT Licensed.
Doesn't seem very actively maintained, we could fork it if necessary.

There is no default message formatting function within these gettext libraries. One option could be https://github.com/woboq/tr which is designed to be used withxtr command, which is specifically designed improve on xgettext  by fixing its problems parsing Rust syntax. It appears to currently only support gettext-rs but seems likely they would accept a PR to implement support for gettext crate. But if we went that route we would lose the option to dogfood our own implementation of xgettext (which will need to support C), one of the reasons for using gettext system in this project in the first place.
I'd propose that we start by creating our own implementation for xgettext which can additionally parse Rust syntax, probably we'd need to start this from scratch as xtr is AGPL licensed. We would then need to choose a string formatting option, we could just use tr macro (licensed as MIT) and at least share some of the work and not re-invent the wheel.

Pretty interesting related reading in this answer (for setting locale): https://unix.stackexchange.com/a/149129

Pretty interesting related reading in this answer (for setting locale): https://unix.stackexchange.com/a/149129

Yep; that is also a good checklist for posixutils.  We need to be responsive to these LC_xxx, and are not yet there.


mirror 模式下镜像列表及 tag 列表显示极为缓慢或显示不出来

Docker version 1.12.6, build 78d1802
docker-compose version 1.8.0
harbor_logs.tar.gz
harbor_config.tar.gz

tag列表空白

Closing as won't fix, because for now it's not supported to configure Harbor as a mirror.


Add a "PreserveAccessToken" option

saves the token as a claim. probably on by default.

:+1:

done on dev/myget - please test. thx

Do you have an idea when this could be release to nuget.org?

Soon - i will make it opt-in though.
—
cheers
Dominick Baier
On 3 Sep 2015 at 15:31:18, Bill Pratt<EMAIL_ADDRESS>wrote:
Do you have an idea when this could be release to nuget.org?
—
Reply to this email directly or view it on GitHub.

Done 2.1.0
—
cheers
Dominick Baier
On 3 Sep 2015 at 17:36:56, Dominick Baier<EMAIL_ADDRESS>wrote:
Soon - i will make it opt-in though.
—
cheers
Dominick Baier
On 3 Sep 2015 at 15:31:18, Bill Pratt<EMAIL_ADDRESS>wrote:
Do you have an idea when this could be release to nuget.org?
—
Reply to this email directly or view it on GitHub.

Thanks!


[SPARK-6179][SQL] "SHOW PRINCIPALS role_name;"

SHOW PRINCIPALS role_name;
Lists all roles and users who belong to this role.
Only the admin role has privilege for this.

Can one of the admins verify this patch?

We initially implemented the HiveQL.scala upon the Hive 0.12 only, and I believe there are some other Hive native commands need to be added for Hive 0.13.1 compatibility, it will be great if you can review the Hive Native command list and add them all.
By the way, can you also add a unit test for this? In case we misspell the keyword.

OK. I will add a unit test.

ok to test

Test build #28312 has started for   PR 4902 at commit 0dd37b4.

This patch merges cleanly.

Test build #28312 has finished for   PR 4902 at commit 0dd37b4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28312/
Test PASSed.

Test build #28383 has started for   PR 4902 at commit 9d8fd71.

This patch merges cleanly.

I add other two tokens. Could you test it again? @marmbrus

Test build #28383 has finished for   PR 4902 at commit 9d8fd71.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28383/
Test PASSed.

/cc @marmbrus

Test build #29198 has started for   PR 4902 at commit ec8bc94.

This patch does not merge cleanly.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29198/
Test FAILed.

Test build #29198 has finished for   PR 4902 at commit ec8bc94.

This patch fails Scala style tests.
This patch does not merge cleanly.
This patch adds no public classes.

Test build #29200 has started for   PR 4902 at commit c8aeb1c.

This patch merges cleanly.

Test build #29200 has finished for   PR 4902 at commit c8aeb1c.

This patch fails Scala style tests.

This patch merges cleanly.

This patch adds the following public classes (experimental):

  case class UnregisterApplication(appId: String)

class RegexTokenizer extends UnaryTransformer[String, Seq[String], RegexTokenizer]

    case class Data(weight: Double, mu: Vector, sigma: Matrix)

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29200/
Test FAILed.

Test build #29201 has started for   PR 4902 at commit 0c7550a.

This patch merges cleanly.

Test build #29201 has finished for   PR 4902 at commit 0c7550a.

This patch fails Spark unit tests.

This patch merges cleanly.

This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29201/
Test FAILed.

Test build #29774 has started for   PR 4902 at commit 4add42f.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29773/
Test FAILed.

Test build #29774 has finished for   PR 4902 at commit 4add42f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29774/
Test PASSed.

Thanks, merged to master.


New fixture - Robe ClubWash 600 CT

Created on 06/09/15
Nearly every capability did not match the datasheet in some way so all had to be changed from the original post:
http://www.qlcplus.org/forum/viewtopic.php?f=3&t=8884
http://www.robe.cz/it/support/list-files/15/file-detail/4509/file-cat/robe-downloads/

And this is fixture number 600 ! Yay ! :smiley:

Wow! Sorry about the earlier descrepancies. Some definitions are awful and it's like starting from scratch.

Ouch, I've deleted my comment cause we're not at 600 yet, sorry.
Just one more to go !

Wow! Sorry about the earlier descrepancies. Some definitions are awful and it's like starting from scratch.

Yeah, I know.


426

Congratulations on making a pull request!
Please make sure you check all the items.

[x] The numbering of the company that you added starts with 1.
[x] You have increased the Total Companies Added count.

Hi @sunil-9
This PR is causing merge conflicts due to previous PR which was raised by you(Thanks I've merged it :))! no worries, its just a small change in this PR. you'll have to create a new PR with the latest master excluding your last PR
https://github.com/Kaustubh-Natuskar/moreThanFAANGM/pull/282 this one


Mwpw 155385 personalisation

Personalization feature:

Placeholder personalization: currently supports only $firsName placeholder, this placeholder will be replaced with a value from partner_data cookie, if cookie is missing placeholder and element containing it will be removed
Block/Section personalization: please refer to the ticket for all currently supported personalization classes. Block/Section will be removed from the page if all personalization conditions are false.

Resolves: MWPW-155385
LINKS:
Before:

https://stage--dme-partners--adobecom.hlx.page/channelpartners/drafts/ratko/personalization?georouting=off

After:

https://mwpw-155385-personalisation--dme-partners--adobecom.hlx.page/channelpartners/drafts/ratko/personalization?georouting=off

Codecov Report
Attention: Patch coverage is 75.47170% with 26 lines in your changes missing coverage. Please review.

Project coverage is 80.83%. Comparing base (fd29022) to head (a28db8a).

Files
Patch %
Lines

edsdme/scripts/personalization.js
67.90%
26 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##            stage      #36      +/-   ##
==========================================
- Coverage   81.62%   80.83%   -0.79%
==========================================
  Files           8        9       +1
  Lines        2775     2881     +106
==========================================
+ Hits         2265     2329      +64
- Misses        510      552      +42

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@zagi25 nala test pass locally for pr branch

@zagi25 proposal: can weadd CSS rules to intially show the public parts and hide all others personalised content?
I think this would improve the loading experience and can have a positive impact on SEO of the public page.


Accents look bad

Hello!
I have a spanish server and the accents look like this:

Can you also confirm that the file is being saved using UTF-8 encoding?

Yes, i'm saving as utf-8

Ok, the problem is in the way we save the document. If I add a console.log(attachment) it looks correct.
Can you think of another way to save it? How do you do it?

Fixed adding
charset=utf-8 to nginx.conf


uptime过大溢出int型

Coverage remained the same at 53.907% when pulling 85d6fbc73d78df7d2315118fa3128281cd7823ae on zuoruizhi:master into a0cddd18e803225a38ed67f84af72ff394e51d0a on orvice:master.


Incorrect ServiceMonitor.spec.endpoints when docker registry proxy with custom port used to pull vault image

Preflight Checklist

[X] I have searched the issue tracker for an issue that matches the one I want to file, without success.
[X] I am not looking for support or already pursued the available support channels without success.

Operator Version
1.19.0
Installation Type
Official Helm chart
Bank-Vaults Version
No response
Kubernetes Version
v1.25.7
Kubernetes Distribution/Provisioner
VMware Tanzu
Expected Behavior
With used docker registry proxy with custom port to pull vault image, e.g.
apiVersion: vault.banzaicloud.com/v1alpha1
kind: Vault
spec:
...
  image: docker.proxy.local:5008/hashicorp/vault:1.14.0

I'am expect modern version ServiceMonitor.spec.endpoints:
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
...
spec:
  endpoints:
  - bearerTokenSecret:
      key: ""
    interval: 30s
    params:
      format:
      - prometheus
    path: /v1/sys/metrics
    port: api-port
    scheme: https
    tlsConfig:
      ca: {}
      cert: {}
      insecureSkipVerify: true

Actual Behavior
In pkg/apis/vault/v1alpha1/vault_types.go function func (spec *VaultSpec) GetVersion() (*semver.Version, error) use strings.Split(spec.Image, ":")  to obtain vault version:
// GetVersion returns the version of Vault
func (spec *VaultSpec) GetVersion() (*semver.Version, error) {
    version := strings.Split(spec.Image, ":") <---------------------------------------------------
    if len(version) != 2 {
        return nil, errors.New("failed to find Vault version")
    }
    return semver.NewVersion(version[1])
}

But when used docker registry proxy with custom port to pull vault image, e.g. docker.proxy.local:5008/hashicorp/vault:1.14.0 this function return incorrect vault version for function
func serviceMonitorForVault(v *vaultv1alpha1.Vault) *monitorv1.ServiceMonitor in pkg/controller/vault/vault_controller.go:
vaultVersionWithPrometheus := semver.MustParse("1.1.0")
version, err := v.Spec.GetVersion()
if err == nil && !version.LessThan(vaultVersionWithPrometheus) {

As result vault-operator produces old version ServiceMonitor.spec.endpoints:
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
spec:
  endpoints:
  - bearerTokenSecret:
      key: ""
    interval: 30s
    port: prometheus

Steps To Reproduce

Deploy banzaicloud-stable/vault-operator 1.19.0
Create custom resource vault with values:

apiVersion: vault.banzaicloud.com/v1alpha1
kind: Vault
spec:
...
  image: docker.proxy.local:5008/hashicorp/vault:1.14.0
  statsdDisabled: true
  serviceMonitorEnabled: true
  serviceRegistrationEnabled: true
  config:
    listener:
      tcp:
...
        telemetry:
          unauthenticated_metrics_access: true
...
    telemetry:
      disable_hostname: true
      prometheus_retention_time: 24h

Get vault ServiceMonitor endpoints

kubectl -n vault get ServiceMonitor vault -o jsonpath-as-json={.spec.endpoints}

Configuration
No response
Logs
No response
Additional Information
No response

Thanks for reporting @trombonax!

@ramizpolic
Is my explanation is clear, do you need some additional details ?

Perfectly clear @trombonax, we will have this resolved in our next release.

Sounds great, I will wait for a fix, thank you in advance


Turn viewer and summary into importable modules

The viewer will no longer be deployed as a standalone entity. Instead it will be imported into other applications and use their back end to proxy into the document and annotation services.

Codecov Report

Merging #35 into master will increase coverage by 1.87%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   93.35%   95.22%   +1.87%
==========================================
  Files          18       15       -3
  Lines         376      293      -83
  Branches       23       17       -6
==========================================
- Hits          351      279      -72
+ Misses         21       11      -10
+ Partials        4        3       -1

Impacted Files
Coverage Δ

...c/app/em-viewer/viewers/viewer-anchor.directive.ts
100% <ø> (ø)

...-viewer/viewers/pdf-viewer/pdf-viewer.component.ts
62.5% <ø> (ø)

...unsupported-viewer/unsupported-viewer.component.ts
100% <ø> (ø)

...app/em-viewer/annotations/notes/notes.component.ts
97.05% <ø> (ø)

...rc/app/em-viewer/annotations/annotation.service.ts
100% <ø> (ø)

...-viewer/viewers/img-viewer/img-viewer.component.ts
100% <ø> (ø)

...rc/app/em-viewer/viewers/viewer-factory.service.ts
100% <ø> (ø)

...annotation-summary/em-annotation-summary.module.ts
100% <100%> (ø)

...otation-summary/em-annotation-summary.component.ts
96.42% <100%> (-0.64%)
:arrow_down:

src/app/em-viewer/em-viewer.module.ts
100% <100%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 130f22f...5b1e6a6. Read the comment docs.


Update prevents continuous playing of songs

After the recent update, the next song no longer plays after the previous song finishes. It requires clicking each song to play. I hope this is not an intentional update as I will stop using the site. Thanks

Hi thanks for the report. Can you share what OS and browser versions you are using. Mobile or desktop? Are there any errors in the Javascript console if you have access to that?

Thanks for the quick response. I'm using Windows Desktop, Google Chrome. I don't see any errors in the javascript console. This just started happening yesterday.
From: Justin Craig-Kuhn @.>
Sent: Tuesday, October 10, 2023 2:24 PM
To: jcraigk/phishin @.>
Cc: Bonnell, Levi N @.>; Author @.>
Subject: Re: [jcraigk/phishin] Update prevents continuous playing of songs (Issue #331)
[ This message was sent from an address outside the Larner College of Medicine. Please exercise caution when clicking links or opening attachments from this source. ]
Hi thanks for the report. Can you share what OS and browser versions you are using. Mobile or desktop? Are there any errors in the Javascript console if you have access to that?

Reply to this email directly, view it on GitHubhttps://github.com/jcraigk/phishin/issues/331#issuecomment-1756167822, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALPGTZTH33QGPYDXH5JRS6TX6WVE5AVCNFSM6AAAAAA52OTC2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJWGE3DOOBSGI.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

Thanks for the detail. I rolled back to 2e869950381cecbb6834766ee1c2b79ab35c4289 for now, which should fix the issue, and will look at a longer term fix later.

Thanks so much!!
From: Justin Craig-Kuhn @.>
Sent: Tuesday, October 10, 2023 3:02 PM
To: jcraigk/phishin @.>
Cc: Bonnell, Levi N @.>; Author @.>
Subject: Re: [jcraigk/phishin] Update prevents continuous playing of songs (Issue #331)
[ This message was sent from an address outside the Larner College of Medicine. Please exercise caution when clicking links or opening attachments from this source. ]
Thanks for the detail. I rolled back to 2e86995https://github.com/jcraigk/phishin/commit/2e869950381cecbb6834766ee1c2b79ab35c4289 for now, which should fix the issue, and will look at a longer term fix later.

Reply to this email directly, view it on GitHubhttps://github.com/jcraigk/phishin/issues/331#issuecomment-1756252201, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALPGTZQSSLIHB3X4YKW2UHLX6WZVNAVCNFSM6AAAAAA52OTC2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJWGI2TEMRQGE.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>


Connectfour: Column button text is to big for high column counts

When more than 8 columns are used the text box of the buttons is to small to fit the text (big margin on the left).

Done with commit: f6c234bc44e7f5bde34b343c7c07c26b27fc19bc


IGAPP-629: Type sagas

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword IGAPP.

@Taggotty I like the .all with the object syntax. I think there were one or two more occurrences of this any array syntax, could you check please?


Add query conditions for some pages in Soul-Dashboard

[ ] Add conditon of selectorName field and ruleName filed in  PluginList/plugin page.@fengzhenbing
[ ] Add conditon of status field   in BasicConfig/plugin page.@WYUSIG
[ ]  Add conditon of fieldName field   in BasicConfig/PluginHandle page.@WYUSIG
[ ] Check if there are other conditions that need be added.@fengzhenbing

assign these to me plz 🥰

[ ] Add conditon of status field in BasicConfig/plugin page.

[ ] Add conditon of fieldName field in BasicConfig/PluginHandle page.

The search field in PluginList/plugin page maybe like this:

The status field in PluginList/plugin page maybe like this:

The fieldName field in BasicConfig/PluginHandle page maybe like this:

thanks.🥰


citrix_workspace: add <IP_ADDRESS>

ChangeLog: https://docs.citrix.com/en-us/citrix-workspace-app-for-linux/whats-new.html#whats-new-in-2104

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Does this issue also happen in your environment?
Would be good to known, if this is a general issue or only on my particular setup.

It doesn't happen to me but admittedly my use is very simple so I may just not have hit the same thing for that reason.

It doesn't happen to me but admittedly my use is very simple so I may just not have hit the same thing for that reason.

Hm. Interesting. I do get these error right away when i start any application via the selfservice UI, or when i launch it directly via storebrowse  -L Controller.Outlook https://$server/citrix/citrix-ui/discovery.
So i guess if you use the application in any capacity, but the error doesn't occur for you, it may just be a problem on my end.
@Ma27, do you still have access to a citrix environment and care to also test this PR?

Just a wild guess, perhaps it's related to
https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/networking/remote/citrix-workspace/generic.nix#L119-L121
Haven't read through the changelog, but back when I wrote this, you had to use -icaroot for wfica and maybe that has changed now?

It seems to have some relation to that.
wfica -help still lists -icaroot (with one dash) as a supported option, but triggers the above error, when it gets executed during application launch.  If run without the -IcaSessionAddr argument it "only" complains about no ICA file being given / it being "corrupt". If then the -icaroot option is changed to sth. invalid like -icarooot, it complains about the option being invalid (like in my screenshots above).
So in conclusion: I don't really understand, what happens inside there :disappointed:
Anyways i can get rid of the problem by removing the -icaroot option in 21.04:
diff --git a/pkgs/applications/networking/remote/citrix-workspace/generic.nix b/pkgs/applications/networking/remote/citrix-workspace/generic.nix
index 506f129d359..f93a323829a 100644
--- a/pkgs/applications/networking/remote/citrix-workspace/generic.nix
+++ b/pkgs/applications/networking/remote/citrix-workspace/generic.nix
@@ -118,10 +118,12 @@ stdenv.mkDerivation rec {
   installPhase = let
     icaFlag = program:
       if (builtins.match "selfservice(.*)" program) != null then "--icaroot"
+      # wfica from 21.04 on doesn't like the -icaroot option despite listing it in its -help output
+      else if (lib.versionAtLeast version "21.04" && builtins.match "wfica(.*)" program != null) then null
       else "-icaroot";
     wrap = program: ''
       wrapProgram $out/opt/citrix-icaclient/${program} \
-        --add-flags "${icaFlag program} $ICAInstDir" \
+        ${lib.optionalString (icaFlag program != null) ''--add-flags "${icaFlag program} $ICAInstDir"''} \
         --set ICAROOT "$ICAInstDir" \
         --prefix LD_LIBRARY_PATH : "$ICAInstDir:$ICAInstDir/lib" \
         --set LD_PRELOAD "${libredirect}/lib/libredirect.so" \

On my machine it works™
But i'm unsure, whether this is the best option, when the problem could not be reproduced by anyone else yet and the option wasn't officially removed.

wfica -help still lists -icaroot (with one dash) as a supported option, but triggers the above error, when it gets executed during application launch. The command line (using pstree) looks like this:

Does --icaroot work?
Also, @adisbladis what did you do to test? Perhaps you did something slightly different and that's why you haven't found the issue :)
If the approach suggested by @pmenke-de works fine, I think we should go with it for now & report the issue to Citrix.

Does --icaroot work?

Didn't work for my, no.
Should've mentioned that :smile:

@Ma27 Only some very basic stuff:
storebrowse -C ~/Downloads/receiverconfig.cr
wfica ~/Downloads/foo.ica

which works fine.

Meanwhile v<IP_ADDRESS> was released.
For me the -icaroot issue persists there as well.
Tested on this branch: https://github.com/NixOS/nixpkgs/compare/master...pmenke-de:citrix_workspace-21_06_0_28?expand=1

For what it's worth, the archlinux package has a wrapper script setting the env var ICAROOT.

It seems like master is already updated to 21.06.0: https://github.com/NixOS/nixpkgs/commit/8a815af4280f3e0d5ff740faa7d489e2b9e36829#diff-b0694b94ae7fa80cbe01a40af52f589131b3a09d4648d6c69cedc528c946c256


Effekt Version Manager: automatic installer and updater

This is a somewhat rough draft of an automatic installer & updater for Effekt.
I cannot test this locally, my local setup is quite weird and I can't really use npm for Effekt distribution.
This PR will require extensive testing on various platforms.
Features

new status bar shows the state of the LSP server, current Effekt version and the selected backend (useful for debugging)

clicking on the status bar checks for Effekt updates (in npm)

updated dependencies to allow newer VSCode features
on startup, check if we can find the effekt binary:

if not and if it's a custom executable by the user, report a specific error
if not, offer the user to install the newest version of Effekt from npm
if we have effekt, take a look at its version: if it's older than the latest version on npm, offer updating to a newer version of Effekt via npm

if the user wants to install/update and they don't have nodejs or npm, report a specific error
if effekt isn't found after installation, check the places npm installs into if the binary is there and if it works (in order to debug PATH issues)
also add a specific command to explicitly install/update (again useful for debugging installations)
the Effekt Version Manager has its own output log, separate from the server (offered to the user when something errors)

Problems

mostly untested!

tried roughly testing on Linux, but node cannot really write packages to my drive
tried testing on Windows

npm install -g @effekt-lang/effekt@latest doesn't seem to work sometimes -- it just puts the package.json into npm/node_modules, but doesn't actually change the binaries, especially after a reinstall. That could be a problem!

requires https://github.com/effekt-lang/effekt/issues/540
should also be tested with rolling release (https://github.com/effekt-lang/effekt/pull/538)
the Effekt npm package(s) are really out of date (!) -- we can of course also check via GitHub API and take the tgz from the release directly (https://api.github.com/repos/effekt-lang/effekt/releases), but that's a bit cumbersome and complicates the installation

Screenshots
Status bar

Installation pop-ups

This looks beautiful! The implementation is exemplary!

Thanks! I'll forward the praise to Claude 3.5 Sonnet ;)

One thing that I noticed is that we check for node, but not the JVM. Maybe checking and reporting: "Hey, maybe you want to install a JVM > X" would help some users?

I used to have the check there, it should be easy to re-add. :)
Note that these checks only run when the user chooses to update.

Rebased on current master so that I can have this version together with the cool syntax highlighting :)

I added some code to detect the JRE version, not sure it works too well (can't test it properly right now).
The only caveat is that this check only runs when we try to install/update Effekt.

weird bug: When you refuse to update, you get a spurious "Effekt is not installed" message.

Current state of testing: seems to work for all Linux (N ≥ 4) and MacOS (N = 2) testers so far.
One reported permissions issues on Linux when calling npm install -g.
One person tried on Windows without WSL, but then the server crashes, see #25. With WSL, everything seems to work perfectly fine.
From feedback: It would be nice to display the full path to the Effekt executable in the status bar on hover (we have the info anyways!)