Strange macro compilation error with aliasing of metrics

Not sure if this is just a nightly compiler bug, but here's what I see:
I am trying to use the macros like so:

use framework::*; // This exposes mod `framework::metrics`.
use ::metrics::{Key, Label, recorder};

const UPLOAD_METRIC_NAME: &'static str = "some_metric";
const UPLOAD_METRIC_LABEL_SUCCESS: &'static str = "success";
const UPLOAD_METRIC_LABEL_PROCESS_TYPE: &'static str = "process_type";

#[inline]
pub fn register_metrics() {
    ::metrics::register_counter!(UPLOAD_METRIC_NAME,
        &[
            (UPLOAD_METRIC_LABEL_COMP_ID, ""),
            (UPLOAD_METRIC_LABEL_SUCCESS, ""),
        ]
    );
}

this results in a compilation error. with RUSTFLAGS='-Z macro-backtrace' cargo build on my workspace:
error[E0425]: cannot find function `recorder` in crate `metrics`
   --> ingestion-utils/src/upload_game.rs:20:5
    |
20  | /     ::metrics::register_counter!(UPLOAD_METRIC_NAME,
21  | |         &[
22  | |             (UPLOAD_METRIC_LABEL_COMP_ID, ""),
23  | |             (UPLOAD_METRIC_LABEL_SUCCESS, ""),
24  | |         ]
25  | |     );
    | |     ^
    | |     |
    | |_____not found in `metrics`
    |       in this macro invocation
    |
   ::: /home/dev/.cargo/registry/src/github.com-1ecc6299db9ec823/metrics-macros-0.6.0/src/lib.rs:130:1
    |
130 |   pub fn register_counter(input: TokenStream) -> TokenStream {
    |   ---------------------------------------------------------- in this expansion of `::metrics::register_counter!`
    |
help: consider importing one of these items
    |
1   | use crate::upload_game::recorder;
    |
1   | use metrics::recorder;

Maybe a macro scoping issue? Not exactly sure what's going on. But it's preventing me from using metrics in my crate right now.

$ cargo --version
cargo 1.58.0-nightly (6c1bc24b8 2021-10-24)

I have just created a PR for a fix. Essentially it seems we want something like $crate in the procedural macro, but I don't know spans well enough to mutate the current implementation to use it. So this should be a nice to still allow ::metrics to be used even if some use foo::metrics is imported.

I can also confirm that this fixes my compilation issue locally if I use the PR branch with my workspace:
[workspace.dependencies]
metrics = { git = "https://github.com/CinchBlue/metrics", branch = "refactor/metrics-macros/global-paths" }


Set revision variable even if option is not used

Q
A

Issue Type
Feature Request

Deployer Version
N/A

Local Machine OS
N/A

Remote Machine OS
N/A

I'd like to know, during deployment, the revision being deployed. Even if I don't use the revision option. I think it should be achieved globally, to always have access to this information.
My main use case is when I need to clear opcode cache, I want to be sure it is achieved by returning the revision of the release considered by opcode cache.
What do you think ?

Done!


Composer omnipay include causes issue with thirdparty gateways

I'm not an expert in composer so maybe there is a way around this. When including this module it uses omnipay/omnipay. The issue arises if you then add a thirdparty payment gateway (in my case Alipay) which requires omnipay/common. This ends up installing a separate copy of omnipay/common (likely a different version as well) inside the vendor folder so you end up with two separate copies of omnipay/common.
On a side not, by including omnipay/omnipay you end up with all the payment gateways, when likely you only want one or two. Guess there a pros and cons to this though.

I think the problem is that these newer payment gateways are built on Omnipay 2, while this package requires Omnipay 1.1... they don't seem to be compatible. It's been a todo for a while to update this to Omnipay 2, see #23.

There is now a 2.0 branch that works with Omnipay 2 and only includes omnipay/common. Just a warning that the branch might fluctuate a bit between now and it's release, and also that Shop might complain as it's currently requiring ~1.1. In the mean time you can use the following in your composer.json to pull this in. Note that you'll have to also include any payment gateways you want via composer as well.
"burnbright/silverstripe-omnipay": "2.0.x-dev as 1.1",


Bug, hostname with trailing dot throws exception

Throws error when hostnames has trailing dot.
Example usage is for pushing records to Azure DNS.
import validators
validators.domain('example.com.')
ValidationFailure(func=domain, args={'value': 'example.com.'})
validators.__version__
'0.18.2'

Just to mention, a web page dedicated to trailing dots in domain name.  There is also this related Stack Overflow question.  Both make it clear that a URL, where the authority part has a FQDN with a final dot, is a valid URL.

duplicate of #124


feat: add @stdlib/array/base/cuany-by

Resolves #2323.
Description
add @stdlib/array/base/cuany-by
This pull request:

resolves  [RFC]: add @stdlib/array/base/cuany-by.

Other
Checklist

Please ensure the following tasks are completed before submitting this pull request.

[x] Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

@kgryte  please review

@kgryte
Ready For Review

ready for review


GDScript: Infer type with string format operator

If the left value type is known to be String, assume the format operator (%) will return a string, since it works with any type in the right hand side. This is also used by type inference even if the right hand type is unknown at compile time.
Fix #88082

Thanks!


CI running without features actually runs without features

Because we use --workspace, cargo unifies the feature set when running:

Since clap_derive depends on the default feature set of clap, all of that gets pulled in.
The examples need cargo to run

Rather than workaround this in CI, I propose

Mark he examples with their required features
Move the clap_derive tests out


Select user own log file name without date / time attached and modification

Hi,
I set addDefaultLogger("app.log", "/var/log/dev"), then the g3log inserted date time tot the log file name "applog.g3log.20170328-215754.log". Any options / flags to disable g3log to modify the log file name?
In Linux application, I'd like to have a simple log file name such as /var/log/dev/app.log, and I can set up logrotate to rotate the log file size and to clean up old log files to prevent disk full.
Thank you and appreciate your tips.

Have you looked at the logrotate sink at g3sinks?
https://github.com/KjellKod/g3sinks/blob/master/README.md
From your description I think it fulfills all of your requirements

Thanks for your response. Sorry regardless of logrotate, there are other things we like to use a single log file name without date / time attached to it, is it possible to configure g3log not to modify the log file name?
Thank you for this great program, appreciate your comments.

That's exactly what you get with the logrotate sink. Please check the API and try it out

@jupiterh did it work out with the sink?

closing due to lack of response


The magnitude of multiple training losses

Hi, thanks for the great work.
Can you kindly provide the magnitude of multi losses (e.g., perceptual loss, i3d loss) during the training or after the convergence? It would be better if you can provide the figure of loss curves. This information can help us validate the correctness of our training procedure. Thanks a lot.

Hello,
commit_loss_w=[0.1]  # commit loss weight
gen_loss_w=[0.]  # generator loss weight
perceptual_loss_w=[1.]  # vgg loss weight
i3d_loss_w=[1.]  # i3d loss weight
recon_loss_w=[10.]  # reconstruction loss weight
use_discr=[0] # use stylegan loss or not
Here are the parameters we used !
This might be useful as well :
learning_rates = [1e-4]  # Learning rate
weight_decays = [1e-4]  # Weight decay
Hope that helps !


Changed the UI of project card

As per provided reference link, I did all the changes. Please review once.
I've also provided a demo video that how it is working in last comment.

What should I change in this according to you?

@anushbhatia sure...

I've done all the changes as per requested and required.

Added padding to cards.
Added extra animation on hover.
Added AOS animation also.
And these cards are responsive in every view and working properly.

@anushbhatia please once review all the changes and let me know if it needs more enhancement or anything different.
@smaranjitghose

ok

@AKC068 as requested by @anushbhatia to continue in another PR, I am closing this one

@smaranjitghose can you please assign me issue #743 as per requested.


[WIP] Add experimental OpenCensus exporter

Some open questions:

Are all of the OC -> OT conversions appropriate? e.g., is this how we should handle SpanData.Event?
What, if anything, should we do with the MessageEvents? Similarly, how should we handle non-child Links?
What additional configuration, if any, do we want to expose?
Should this be in a separate repo or this one?

TODO:

Tests (!)
README
Documentation

@austinlparker I'm not quite sure re: attributes -> tags, although I believe that all the types are compatible (i.e., that attributes support a subset of the types supported by tags).


Functional v1 user selection/creation

@net / @komizutama the tests break until I fix them, but this is a functional stab at what I think is 90+% of the requirements for us to run a live trial of the system, for a single facility, once actual stock is updated to be real.  This code is on staging (which currently does not share a DB with production, but that was an open question).
So this is not a true PR at the moment, but @net if you want to start any code review, its welcome, there's definitely some refactoring to be done, but might want to update/add tests of this functional version before we refactor, unless there's any big missed requirements with this to tweak first

@net / @komizutama tests now pass on this, so suggest we merge in, its not perfect (and I'm actually having some issues running them locally), but I think good enough to move forward with.  I also branched off this trying to fixup/add a test option to docker-compose, though for some reason that's not working for me... the branch thats on is fix_docker_compose_setup and if either of you want to try and see if you can get docker-compose run test or something to work there let me know, it may still be an improvement but seperate topic.


Remove or fix dev/pkg scripts

The dev/pkg scripts as described in DEVELOPMENT.md don't work on Linux machines. They also require some pre-requisites installed that only work on Mac OS.
The scripts add an additional footprint of maintenance and I'm not sure how often they are used.
Do we want to keep maintaining them or shall we remove them all together?

As part of migration to Chainguard and dockerfile, will attempt to simplify.
Seems to be an issue with how postgresql works in linux.  The dev setup scripts only work when running against a local service (ie. brew service). The dev set up will eventually install the "orchestrator_test" database which is needed to run go test modules.
Note also that I thnk these scripts are integrated into github CI scripting.

This was done as part of Issue #416.


Metrics debugging

Semi related, field https://github.community/t/getting-access-to-perf-events-on-github-hosted-ubuntu-latest/149164 to ask around about perf insts.

not sure why it's passing on CI, let's see what happens on master
bors r+

That fixed it?? Makes no sense

Ah, no, they're missing. But at least it no longer panics.

https://github.com/rust-analyzer/rust-analyzer/blob/24731e107f3c4790fc5fe73b63ad251a9d6e62ae/crates/rust-analyzer/src/lib.rs#L91

thread 'main' panicked at 'Forgot to remove debug-print?', crates/rust-analyzer/src/lib.rs:91:9

Alternatively, is there perhaps a non-perf based way to measure how many CPU cycles my program spends?

Oof, Valgrind?


setFieldError does not prevent handleSubmit

🐛 Bug report
This looks like it may be a possible regression on #317, as I can replicate it in the exact same way.
Current Behavior
After setting an error using setFieldError, the handleSubmit function is successfully fired.
Expected behavior
The form should not submit successfully, as there is an error.
Reproducible example
Click "Set Error". You will then be able to successfully submit.
https://codesandbox.io/s/43owlv689
Suggested solution(s)
Your environment

Software
Version(s)

Formik
1.3.2

React
16.4.2

TypeScript

Browser
Chrome

npm/Yarn
6.1.0

Operating System
OSX

It looks like this might also be related to https://github.com/jaredpalmer/formik/issues/706, whereby there is not a clear way to prevent automatic validation from overwriting custom errors.

This behavior is correct. Logic that sets errors imperatively will be overridden by validation. If you have an alternative API that could support this behavior lmk. The problem is you can't simply merge the old errors object with the new one, nor would you want to. As explained in my comment, you'll want to move this logic to <Field validate> if you cannot express validation it with <Formik validate> or <Formik validationSchema>. This ensures proper orchestration prior to submit.

Thanks for the example. I guess I never really thought about this case. In Formik, validation functions are the way to express validation requirements and the assumption, which may be not exactly correct as you've shown,  is that 100% of your logic goes there. The problem is that preventing submit like this gets wonky. Right now we set all field's to touched within the parent, but maybe, in a perfect world we would re-run all blur handlers. However, this really isn't feasible either, unless we force everyone to use <Field>. Open to suggestions and further exploration. Either way we should add something to the docs about this.

Naive solution could be to fallback to current state.errors if no validation behavior exists. I think that would solve this?

Yes, I puzzled over this myself. There isn't a clear way to combine the imperative error handlers with the top-level validation.

Naive solution could be to fallback to current state.errors if no validation behavior exists. I think that would solve this?

This seems like it would work reasonably well, and at least clear up some confusion.
What about a solution, though, where if there doesn't exist a validator function or validationSchema for a given function, it just doesn't overwrite what's already in there? That'd be merging the results of validation with the existing state.errors? Then the contract sort've becomes, "if you use imperative error handlers, it's also your responsibility to clear them." I don't know if that is actually a weirder behavior or if that creates any more problems, but that's how I expected it to work.

Cc @slightlytyler @crosscompile @eonwhite
what do you think?

I am trying to do something similar. I have an address component where I use zip code to update the city and state. It shows an error when I enter invalid zip, but I am still able to submit the form, and submitting the form removes all the existing errors.

Any ideas on how I can properly implement this?

Any workarounds? Still stuck with this.

The way I'd envision handling Persistent Validation is outlined here: https://github.com/formium/formik/issues/1309#issuecomment-774279530
But there are very few cases in which I would recommend using this, and instead recommend reusing a function inside of <Field validate={} or <Formik validate={}. For example with the above codesandboxes:
(not tagging anyone because this issue is quite old)
OP:
withFormik implementation is not possible without a custom validator as described by Persistent Validation comment. If you can rewrite your function not to use withFormik, it can be implemented like:
const MyForm = (props) => {
  const [hasManualError, setHasManualError] = useState(false);
  return <Formik {...props} validate={() => ({ manualError: hasManualError ? "Manual Error" : ""})}>
    <button onClick={() => setHasManualError(true)} />
    />
  </Formik>

sneu012:
<Field
  name="zip"
  validate={(zip) =>
    !looksLikeAZip(zip)
      ? "That doesn't look like a zip."
      : !selectReusableZipApiReturnValue(zip)
        ? "This zip didn't return any city state info, try again."
        : ""
  }
/>


methylation calling in non-CpG context (CHG and CHH)

Hello there,
I re-post an issue I posted in DeepMod regarding future plan to include detection of other methylation motives in plant. Hope it can be one of the new development included in DeepMod2. Thanks a lot

This is in principle very possible, as long as there is a good training data with paired gold standard on methylation within CHG and CHH motif. If you are aware of such plant specific datasets, we can train a model for that for detection of non-CpG context. Thank you.

Hi @kaichop,
Thank you very much for your response. I need to talk to my supervisor, but we should have data from nanopore sequencing and whole genome bisulfite sequencing, would those be enough?
Also, our data are all quite recent, so from R10 flowcell, would that be compatible with DeepMod2?
Thanks again

DeepMod2 can train on R10 flowcell but the model will be different from those on R9.4. We have tested it on HG002 (on R10) and it works well.

Just to add some extra information, yes whole genome bisulfite sequencing and Nanopore sequencing should be sufficient. We have uploaded two CpG models trained from high coverage Guppy basecalled R10.4 and R9.4.1 reads from ONT open datasets release using one BS-seq replicate, and we have achieved very high performance.

Thanks both.
I'll get back to you guys regarding the datasets for training.

Hi @kaichop and @umahsn,
Sorry for the delay, we apparently don't have any matching ONT and WGBS dataset from the same sample yet, but are looking forward to generate them. May I know, for the model training, is there any specification on the dataset (e.g.coverage, etc) that you would need specifically.
Thanks again,
Cen

Hi,
For CpG, we were able to achieve very high performance (~94%  F1) with ~30X NA12878 native ONT dataset using consensus of two WGBS replicates for ground truth, and we achieved slightly better performance (~95% F1) with ~90X HG002 native ONT dataset using a single WGBS sample.
On the other hand, we also achieved very good performance (~90-93% F1) when we trained using low coverage synthetically methylated and unmethylated controls of HG001 from Simpson. I believe both controls are less than 5X coverage.
I think the important thing in both cases is having sufficient total number of reads with high degree of confidence regarding their methylation. This can come from 1) high coverage at a few sites that have high confidence labels, or 2) low coverage at several sites that have extremely high confidence labels. In case of 1), for native ONT datasets, we trained models using ground truth labels from WGBS with a very strict criteria, i.e. minimum coverage in WGBS of at least 5, and all replicates had to have 100% methylation to be considered methylated or all replicates had to have 0% methylation to be considered unmethylated. Even with this strict criteria, there were ~850k-1M CpG sites for model training, and paired with at least 30X coverage, thats a lot of training data. Whereas for 2), using synthetic positive and negative control, even though coverage was low, we used all ~50million CpG sites for training since we had great confidence in each site in positive and negative control being methylated and unmethylated, respectively.
In short, high coverage ONT will only help for training if you can assign methylated or unmethylated labels to the reads with high confidence. Which is why it is very important to place more emphasis on generating proper ground truth labels for the motifs you are interested in, whether via WGBS or synthetically. Please let me know if you have more questions.

Thanks @umahsn and apologise for the delay in responding.
I will get in touch again once we have the WGBS data in hand


Terminal does not response after npm install

Describe the bug
When I use Vite+Vue3, after I use 'npm install element-plus', the terminal does not response. I restart the container and it keeps running start command like the screenshot. After I uninstall, and restart, it turns well.
Link to the blitz that caused the error
https://stackblitz.com/edit/vitejs-vueblog?file=README.md
Steps to reproduce

open a vitejs-vue container
npm install element-plus
restart the terminal

Expected behavior
the terminal goes well and install element-plus normally
Parity with Local

[X] I have run the project in my local machine and I could not reproduce the issue.

Screenshots

Platform
Browser name  = Chrome
Full version  = 103.0.5060.114
Major version = 103
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/103.0.5060.114 Safari/537.36 Edg/103.0.1264.62
performance.memory = {
  "totalJSHeapSize": 74456395,
  "usedJSHeapSize": 65022999,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Hash = 1f021b18268b32e6c6b2095e039ac8c9f88b0d52

Additional context
No response

:wave: Thanks for the report. I can't reproduce on my end. Is this still an issue for you?

您好，已经收到您的邮件，谢谢！我会尽快回复您。

:wave: We're closing this due to inactivity. Please, feel free to open a new one if you're still encountering any errors.

您好，已经收到您的邮件，谢谢！我会尽快回复您。


[FEATURE] Implement a Scrollbar for Info & Edit Panel of SocialRepo

Implement a Scrollbar for Info & Edit Panel of SocialRepo
Overview
Implement a modern design scrollbar for Info & Edit Panel of SocialRepo using HTML/CSS only.
Details:

Scrollbar Track:
::-webkit-scrollbar: The main scrollbar container in WebKit-based browsers like Chrome.
::-webkit-scrollbar-track: Represents the track (background) of the scrollbar.

Scrollbar Thumb (or Handle):
::-webkit-scrollbar-thumb: Represents the draggable thumb of the scrollbar.

Scrollbar Buttons (Arrows):
::-webkit-scrollbar-button: Represents the buttons (arrows) at the ends of the scrollbar.

Scrollbar Corner:
::-webkit-scrollbar-corner: Represents the corner where vertical and horizontal scrollbars meet.

Requirements

Use HTML/CSS for creating and designing the container.
There should NOT be any Scrollbar Buttons in scrollbar.
Color of Scrollbar Track must be same as background color of main element.
Scrollbar Thumb should be a little curved, align with logos and container's border radius.
Color of Scrollbar Thumb should be same as the background color of header.
Must follow the Code Guidelines provided.
Edit the scrollbar design under section element and inside style.css.section {
    width: 100%;
    height: 100%;
    display: flex;
    flex-direction: column;
    align-items: center;
    gap: 1rem;
    padding: 1rem 2rem;

	// Add scrollbar design here

}

To test the code, setup the extension by following these steps.
Use the Color Palette provided.

Additional

Apply focus, hover effect.
Add padding for better visual.

P.S: This is just the designing part, no need to add any functionality as of now.

If you have any suggestion or idea, you're welcome to share.
Let's design the SocialRepo's Scrollbar 🙌

Hey @Param302, Please assign me this task

Hey! @Param302, Can you assign me the task so I can start working on this?

Yes @aayushwrld ,
You can work on it, I am assigning you this issue.
If you need any help, feel free to reply.
Happy Contributing!


API: Possibility to generate and remove users through the API.

Is your feature request related to a problem? Please describe
There is no way to generate and remove users through the API to automate e.g. the switch of service owners.
Describe the solution you'd like
I would like to have a way to generate and remove users through the API to automate e.g. the switch of service owners.

@valentijnscholten , please help us to provide a programmatical way create or delete users or provide any other solution by which we can onboard users in bulk.

If you use SAML integration, user accounts will be autocreated.


Make run accept data and g2p model as two different arguments

Make voice/run.sh take two arguments, the data and a g2p model, instead of a folder containing both.
Update README and Dockerfile accordingly.

The g2p models still needs to be in ext/ipd_clean_slt2018.mdl for inference since festvx/lvl_is_v0_lexicon.scm assumes its location, but this is at least a step in the direction to have the name and location of the model configurable.


OCPBUGS-42851 Refresh interval button on "Observe -> Metrics" page failed to load for admin/developer console

Related Issue
OCPBUGS-42851 Refresh interval button on "Observe -> Metrics" page failed to load for admin/developer console
Screenshots
Before

Figure 1. Runtime Error produced by bug.

Figure 2. Admin > Observe > Metrics > Interval Dropdown is not functional.

Figure 3. Dev > Observe > Metrics > Interval Dropdown is not functional.
After

Figure 4. Admin > Observe > Metrics > Interval Dropdown is replaced with a functional dropdown.

Figure 5. Admin > Observe > Metrics > Interval Dropdown is replaced with a functional dropdown.

/lgtm

/hold I want to get QE to double check this

/lgtm

/label qe-approved

issue is fixed with PR

/unhold
QE has reviewed

/jira refresh

/jira refresh


adding a secret to the keyvault with a bang (!) in the --value, does not execute

Describe the bug
when attempting to create a new secret or update an existing secret using the following command
az keyvault secret set --vault-name "myVault" --name "PASSWORD" --value "Testing123!"
Command Name
az keyvault secret set
Errors:
-bash: !": event not found

Expected Behavior
The secret is saved
Environment Summary
macOS-13.3.1-x86_64-i386-64bit, Darwin 22.4.0
Python 3.10.11
Installer: HOMEBREW

azure-cli 2.48.1

Extensions:
bastion 0.2.4

Dependencies:
msal 1.20.0
azure-mgmt-resource 22.0.0

Additional Context

Thank you for opening this issue, we will look into it.

Can't reproduce:

Please check if your terminal has parsed Testing123! into Testing123 and ! before executing this cli command


Fix add game multiple times

Fix Issue #1.

Added a text to signify that the game is already present in the library.


Flutter Plugin Crash Daemon Issue on IDE's (Android Studio and VSCode)

Hi Team,
I've been encountering a persistent issue for over two weeks when launching Android Studio and VSCode on both Windows 11 and the latest macOS. The problem seems to be rooted in the Flutter SDK. I've reinstalled Flutter three times, but the issue persists.
Additional Information:

Flutter Version: Latest
Android Studio Latest Stable
VSCode Version: Latest Stable

Error Message:

Steps to Reproduce:

Launch the IDE
Open Flutter Project root
Automatiaclly the crash come

Logs/Stack Traces (if available):
[Error - 1:02:15 PM] Server initialization failed.
Message: Pending response rejected since connection got disposed
Code: -32097
[Error - 1:02:15 PM] The Dart Analysis Server server crashed 5 times in the last 3 minutes. The server will not be restarted. See the output for more information.
[Error - 1:02:15 PM] Dart Analysis Server client: couldn't create connection to server.
Message: Pending response rejected since connection got disposed
Code: -32097
[Error - 1:02:15 PM] Restarting server failed
Message: Pending response rejected since connection got disposed
Code: -32097
Your assistance in resolving this matter is highly appreciated. Let me know if there's any additional information needed.

Wild guess this is the wrong repository. Check flutter repository.

Thanks for issue! However, this is likely the wrong repository.
If this is still happening, can you open a new issue on the Dart SDK repository with this information, the output of flutter doctor -v, and any information about the project(s) you are working on when this happens.


Conditionals for relational database is not working or lacking documentation

cannot get the result query when writing a where statement
const Player = async () => {
  const session = await mysqlx.getSession(options);
  const schema = session.getSchema('math-battle');
  const player = schema.getTable('players');
  return player;
};

playerRouter.get('/show/:id', async (req, res) => {
  const player = await Player();
  const { id } = req.params;
  const users = [];
  player
    .select(['full_name', 'user_name', 'email'])
    .where('id = :id')
    .bind('id', id)
    .execute((row) => {
      console.log(row);
      users.push({
        id: row[0],
        full_name: row[1].trim(),
        user_name: row[3].trim(),
        email: row[4].trim(),
      });
    })
    .catch((error) => {
      console.log(error);
    });
  res.status(202).json(users);
});

it doesn't show any errors or anything but it doesn't return the results to

Hi! Sorry you're having trouble. I don't even see anywhere you're using this module in your code above. Perhaps you opened in wrong repo or you pasted the wrong code?

Looks like you are using the xdevapi connector and not this module.
On a first look, seems like the issue might be related to the fact that you are sending back a response before the operation finishes. execute() is returning a Promise so you should wrap that code inside a then() or just use await as well.
playerRouter.get('/show/:id', async (req, res) => {
  try {
    await player
      .select(['full_name', 'user_name', 'email'])
      .where('id = :id')
      .bind('id', id)
      .execute((row) => {
        // ...
      });
    res.status(202).json(users);
  } catch(error) {
    console.log(error);
    // res.status(500);
  }
});

If you're still having issues, feel free to submit a bug report in the MySQL tracker using the Connector for Node.js category.
@dougwilson sorry for spamming (I guess you can close this).

OMG so sorry man wrong repo....


column => function

Current:
Partition function
A database object that defines how the rows of a table or index are mapped to a set of partitions based on the values of certain column, called a partitioning column.
Expected(?):
Partition function
A database object that defines how the rows of a table or index are mapped to a set of partitions based on the values of certain column, called a partitioning function.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7b7b22d6-0ccb-bda0-7ea6-dc4a7e4817c5
Version Independent ID: 9039d0ef-8830-a67d-6cd0-b17ef2a78081
Content: Partitioned Tables and Indexes - SQL Server
Content Source: docs/relational-databases/partitions/partitioned-tables-and-indexes.md
Product: sql
Technology: ****
GitHub Login: @julieMSFT
Microsoft Alias: jrasnick

@Alexander-Bartosh -- Alexander, thank you for your feedback.  I am looking into this article.

@Alexander-Bartosh -- Alexander, the text appears to be correct as written; I will update it for clarity.  Please see Partioning Column in that article, Create Partitioned Tables and Indexes for additional information, and consider the following resources:

SQL Server on Microsoft Q&A
DBA Stack Exchange
Stack Overflow

@julieMSFT -- Julie, please review private PR 17321.


FE: ImageUpdateAutomation table

As a user, when I click on the ImageUpdateAutomation tab, I see a table of image update automations with the following data:

Name
Namespace
Status
Source (link)
Interval
Last Commit (link)
Last Run

@yiannistri to assist with sample manifests


When running certain terminal commands console output is broken

This applies to a Windows installation, though have not tested it on others.
Version: <IP_ADDRESS>
Sample output:

Dont see what's wrong here. Can you check again with latest version?

If you look at the bottom part, there is a space between the prompt and the actual cursor, and part of the prompt is actually shown on the right hand side.
Though you are correct, this does not seem to be an issue with the latest version after I updated.

oh cool


NavLi acrive status in group route

Describe the bug
<NavLi href="/" active={$page.url.pathname === '/'} rel="external">Home
active status doesn't work when in group route
Reproduction
https://stackblitz.com/edit/sveltejs-kit-template-default-xjoa3r
Flowbite version and System Info
System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.20.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.4.2 - /usr/local/bin/npm
    pnpm: 8.6.3 - /usr/local/bin/pnpm
  npmPackages:
    @sveltejs/kit: ^1.22.0 => 1.22.0
    flowbite-svelte: ^0.38.5 => 0.38.5
    svelte: ^4.0.4 => 4.0.4
    vite: ^4.3.9 => 4.3.9

I think the new version solved this issue.
I will close this and thank you for your contribution.


Add test for shuffling on different string dtypes

This adds a new test measuring the performance of shuffling based on the different options for string dtypes: "object", "string[python]", and "string[pyarrow]". In my initial testing, the pyarrow string dtype was significantly slower (!), though I haven't had the chance to chase down exactly what is going on there (possibly time spent converting dtypes, possibly performance issues with hashing or serialization, possibly something else entirely). Something to fix, I suppose!

@jrbourbeau I thought I could help here a bit, I suspect we should see all green now, between the skipif < 2022.10.1 and merging main. I did not check the rest of the test though, like technical things and design.

I'm curious about the motivation for this test.  Seems like it makes more sense to specify a string dtype for benchmarking and monitor behavior there.  Thoughts?


import fails on yaml keys with same line comment

What version of CUE are you using (cue version)?

$ cue version
cue version v0.9.1

go version go1.22.4
      -buildmode exe
       -compiler gc
       -trimpath true
  DefaultGODEBUG httplaxcontentlength=1,httpmuxgo121=1,tls10server=1,tlsrsakex=1,tlsunsafeekm=1
     CGO_ENABLED 1
          GOARCH arm64
            GOOS darwin
cue.lang.version v0.9.0

Does this issue reproduce with the latest stable release?
See above, it does
What did you do?

Example yaml:
foo:  # interesting
  foo: bar

Run the following:
$ cue import  example.yaml

$ cue vet example.cue
expected operand, found ':':
    ./example.cue:2:1

$ cat example.cue
foo // interesting
: {
	foo: "bar"
}

What did you expect to see?
$ cue vet example.cue

$ cat example.cue
foo: // interesting
{
	foo: "bar"
}

What did you see instead?
Already shown in What did you do

Nvm! Seems to be mentioned already in https://github.com/cue-lang/cue/issues/3214


Updater version check isn't silent in corporate environment

First and foremost, thank you very much for the extremely useful tool.
Every time I start AsciidocFX in a corporate network environment, the Updater.exe pops up a dialog stating

Could not connect to the download server. Please enter your internet connection parameters:
radio button direct
radio button proxy blah

Our internet access runs through corporate proxies where one has to authenticate in a special way first, so usual proxy settings don't work. I don't need regular checks and I cannot find how to shut them down.
Please make the updater optional for the users.

Ok, I found the check box finally :dancer:


generate an all-in-one yaml file

This fixes up the merge script and provides a make target to generate an all-in-one yaml file for admins to use to install Kiali Operator. This all-in-one yaml should only be used for those that do not have nor wish to use Operator Lifecycle Manager to install and manage the Kiali operator installation.
fixes: https://github.com/kiali/kiali/issues/2674
The Jenkins build is updated via https://github.com/kiali/kiali/pull/2730 so an all-in-one can be generated and committed to the deploy directory (this is why this PR has "backend changes required" label).

@israel-hdez I put you as a reviewer on this PR because it goes with the operator PR that you are also a reviewer on: https://github.com/kiali/kiali/pull/2730
This PR creates a new Makefile target that Jenkinsfile used to generate the all-in-one file.


Update to rspec3

Some gems have dependency to GenSpec and I could not update them to RSpec 3, so I updated GenSpec to RSpec 3. If you update GenSpec, I will resume updating other gems.

Thanks, I addressed this same issue today and somehow managed to not see this PR (yes, I know, for a year and a half; my apologies). I think I made equivalent changes across the board but if you feel I missed something or have more issues please let me know.


Python 3.10 temp fixes.

Interlace fix see my thread: https://github.com/codingo/Interlace/issues/167

for  RequestsDependencyWarning: urllib3 (1.26.11) or chardet (3.0.4) doesn't match a supported version!
warnings.warn("urllib3 ({}) or chardet ({}) doesn't match a supported ":
pip3 install --upgrade requests
I upgraded to 2.28.1 and the error went away.

i'll post more fixes as I come across them.

I'm planning to fully replace Interlace with https://github.com/shenwei356/rush almost everything replaced at https://github.com/six2dez/reconftw/commit/3c43c7e6ebc10d75beac9214a445b60e44a40ad2 so no need to maintain this issue


refactor: Rename miniblock to l2 block – base + state keeper

What ❔
Renames "miniblock" to "L2 block" in types, DAL and state keeper.
Why ❔

"Miniblock" is an internal term that is somewhat difficult to understand; "L2 block" is better in this regard.
It makes sense for renaming to be complete (i.e., not only concern logs, but also the codebase), so that naming is reasonably consistent.

Checklist

[x] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[x] Tests for the changes have been added / updated.
[x] Documentation comments have been added / updated.
[x] Code has been formatted via zk fmt and zk lint.
[x] Spellcheck has been run via zk spellcheck.
[x] Linkcheck has been run via zk linkcheck.

May be obvious: if this approach is OK, I plan to create smaller follow-up PRs to change naming in other components.


Validation error handling

When a user is anonymized, his email address becomes invalid, and some of the api calls return an error response (400, {"status":"error","message":"Payload error","errors":["email: Invalid email"]}), which is not handled..

It comes from the mailer widgets on the users detail page (UserEmailSettings, MailLogs).. I was looking for a way to disable these widgets when the email is invalid, but I could not found any.. I could validate the email in these widgets and show an error instead of the current content (mail listing or form)..

Maybe we could disable those widgets if the user is deleted (deleted_at IS NOT NULL)? At least to cover these GDPR removals.

That would be even better. Is it possible to disable the widget on a higher level? Or only in the widget itself?

The best would be just the widget itself - it would check the the provided user and return immediately without rendering if the user was deleted.

Merged via https://github.com/remp2020/crm-remp-mailer-module/commit/a3db2bf7092f08ec1780ea5a27087c0f7c3c1ec3. Sorry for stealing authorship of commit, I again used Gitlab's squash during merge instead of squashing it manually :(.


Download vimeo video fail

$ youtube-dl -F --verbose https://vimeo.com/102924106
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-F', u'--verbose', u'https://vimeo.com/102924106']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2015.04.17
[debug] Python version 2.7.3 - Linux-3.2.0-4-amd64-x86_64-with-debian-7.8
[debug] exe versions: ffmpeg 1.0.10, ffprobe 1.0.10
[debug] Proxy map: {}
[vimeo] 102924106: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 404: Not Found (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 314, in _request_webpage
return self._downloader.urlopen(url_or_request)
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1678, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "/usr/lib/python2.7/urllib2.py", line 407, in open
response = meth(req, response)
File "/usr/lib/python2.7/urllib2.py", line 520, in http_response
'http', request, response, code, msg, hdrs)
File "/usr/lib/python2.7/urllib2.py", line 445, in error
return self._call_chain(*args)
File "/usr/lib/python2.7/urllib2.py", line 379, in _call_chain
result = func(*args)
File "/usr/lib/python2.7/urllib2.py", line 528, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)

This webpage reports:
Sorry, there is no video here.

Either it was deleted or it never existed in the first place. Such are the mysteries of the Internet.

https://vimeo.com/102924106 says Permission Denied, can you view it?. If it's a private video and you need to login, you'll have to use the --username and --password options (or --netrc).


⚠ Samsung has degraded performance

In eec4b15, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2566 ms

Resolved: Samsung performance has improved in 99ae8d7.


Support Vinyl files stream as replacement input

I have this case where I'm generating a stylesheet from SASS and want to inject it into the page: I'm inline a subset of the main stylesheet for rendering optimisation (above the fold).
Right now, gulp-html-replace supports string or file path as a replacement but it would be nice for my use case, and any input actually, if it could be delivered through a stream of Vinyl files.
See bellow. The main stream would "wait" internally for the cssInline input stream to end then continue.
gulp.src('app/index.html', {base: 'app'})
        .pipe(htmlreplace({
          cssInline: {
            src: gulp.src('inline.scss').pipe(sass()),
            tpl: '<style>%s</style>'
          }
        }))

btw, I'm happy to create a PR for that if you guys think it is a good idea :-)

Hi @jraoult it looks like a good idea, i'd love to see the PR. Also if you could update the readme according to the new functionality it'll be even more awesome :-) Thank you.

 I'll keep posted.

+1
Yep, this would be very nice indeed. I recently tried to do something very similar with inline SVG sprites using gulp-svg-sprite. The solution I came with was to use the gulp-svg-sprite plugin to save the sprite on a variable (ie.: svgSprite) using the plugins transform and later on, 'inject' it on my page with:
{ src: svgSprite, tpl: '%s' } : ''
It works, but it would be better if I could do what @jraoult is suggesting! =)

+1

Closed via https://github.com/VFK/gulp-html-replace/pull/44


Utilize Python dataclasses for some type specific classes

Utilize Python data classes for some arguments of classes, when applicable
This reduces the large amount of redundancy in checking if values are of the valid type.
https://docs.python.org/3/library/dataclasses.html
Should help for MathGame and Equation classes specifically.

#24 resolves this.

This is the correct issue to reopen, and fix #1


ResourceReloadListener#reload -> createReloadTask or something like that

ResourceReloadListener#reload is not supposed to perform any reloading on its own. Instead, its goal is to return a CompletableFuture which, when evaluated, is supposed to submit the actual reloading tasks to various Executors.
If you try cheating the system by putting code directly in reload and returning some dummy CompletableFuture that does nothing, the game hangs when reloading, because the future returned by Synchronizer#whenPrepared never gets called.
Naming it something like createReloadTask seems like a way to discourage this path and clarify that no reloading should be done directly in this method.

imo, ResourceReloadListener should be renamed to ResourceReloader as they are the ones actually performing the reload (compare to ResourceReloadHandler). The reload name is fine imo, or we can consider a consistent naming scheme for all CompletableFuture related names.

After a look, we already have a resource reloader that monitors reload.
Now, I am a bit confused on what this should be named, or if it should be renamed or not.

Hmm, maybe ResourceReloader -> SimpleResourceReload, ResourceReloadListener -> ResourceReloader. Additionally, name ResourceReloadMonitor to ResourceReload and name the implementations correspondingly. ResourceReload represents one single reload and is discarded immediately after, so this name actually sounds good.


Select sample from VCF

The ability to select a sample by name to perform bed operations on. This would help with using vcf files from the 1000 genomes project where we are trying to intersect with certain individuals.

This should be done with vcftools and then passed to bedtools.


Return more information when the resource upgrade fails through the workflow

Is your enhancement related to a problem? Please describe.

When the resource upgrade fails through the workflow, only a status code is currently returned, lacking sufficient information for users to pinpoint where the error occurred.

Describe the solution you'd like

Return more information when the upgrade fails.
Describe alternatives you've considered

Additional context

Steps to reproduce:

New a workflow and add a 'Deploy Resource' step.
Run the workflow.
Edit the workflow, edit the step and change the resource type.
Run the workflow again.

Environment

Walrus version: main e92cde6256262c9671c9d51475f0bee8669f6628
UI version: dev-7fa18e0

Test Result: pass


Update dependencies

Include ktlint 0.41.0

Thank you @Goooler and thanks for your patience, been a crazy few days.
I'll get a new release published including this.


Open bakery sync 2023-06-26

I'd like to thanks you, @miguelsousa for all these commits (and also the ones from the past few weeks). This is good stuff!


Allow SSE2 and AVX2 functions with -DWITH_UNALIGNED=OFF.

Even though they use unaligned loads, they don't result in undefined behavior.
This is from an idea from @KungFuJesus mentioned in #1192.

Rebased.


Most spoken language method

For  def get_most_spoken_agent_language_by_state(self, state):
Do we account for secondary languages as well?

Yes, please account for the agent's spoken languages.


Feat stripe webhook config

:tada: This PR is included in version 6.57.0 :tada:
The release is available on:

v6.57.0
GitHub release

Your semantic-release bot :package::rocket:


Trial X failed because of the following error: ValueError('nan loss encountered')

I'm having an issue where some combinations of hyper-parameters result in 'nan loss encountered'. I suspect to high a learning rate coupled with amp enabled.
The issue is when this occurs allennlp-optuna crashes. It would be preferable if an exception simple resulted in the trial being marked as failed and the search continue from the next trial.
2021-11-22 20:26:30,886 - CRITICAL - root - Uncaught exception
Traceback (most recent call last):
  File "bin/allennlp", line 8, in <module>
    sys.exit(run())
  File "site-packages/allennlp/__main__.py", line 46, in run
    main(prog="allennlp")
  File "site-packages/allennlp/commands/__init__.py", line 122, in main
    args.func(args)
  File "site-packages/allennlp_optuna/commands/tune.py", line 89, in tune
    study.optimize(objective, n_trials=n_trials, timeout=timeout)
  File "site-packages/optuna/study/study.py", line 400, in optimize
    _optimize(
  File "site-packages/optuna/study/_optimize.py", line 66, in _optimize
    _optimize_sequential(
  File "site-packages/optuna/study/_optimize.py", line 163, in _optimize_sequential
    trial = _run_trial(study, func, catch)
  File "site-packages/optuna/study/_optimize.py", line 264, in _run_trial
    raise func_err
  File "site-packages/optuna/study/_optimize.py", line 213, in _run_trial
    value_or_values = func(trial)
  File "site-packages/allennlp_optuna/commands/tune.py", line 57, in _objective
    return executor.run()
  File "site-packages/optuna/integration/allennlp/_executor.py", line 215, in run
    allennlp.commands.train.train_model(
  File "site-packages/allennlp/commands/train.py", line 254, in train_model
    model = _train_worker(
  File "site-packages/allennlp/commands/train.py", line 504, in _train_worker
    metrics = train_loop.run()
  File "site-packages/allennlp/commands/train.py", line 577, in run
    return self.trainer.train()
  File "site-packages/allennlp/training/gradient_descent_trainer.py", line 750, in train
    metrics, epoch = self._try_train()
  File "site-packages/allennlp/training/gradient_descent_trainer.py", line 773, in _try_train
    train_metrics = self._train_epoch(epoch)
  File "site-packages/allennlp/training/gradient_descent_trainer.py", line 495, in _train_epoch
    raise ValueError("nan loss encountered")
ValueError: nan loss encountered

Hi @david-waterworth, thank you for trying allennlp-optuna.
I introduce the special option --skip-exception to tune command.
Please upgrade allennlp-optuna and specify the option during optimization.
(This option ignores all exception so we have to use it carefully. If I could solve this problem more cleanly, the interface would be changed.)
https://github.com/himkt/allennlp-optuna/releases/tag/v0.1.7

Thanks for the quick reply. I just figured out why this happens (optuna study takes an optional catch argument that defaults to None so the default is to only catch ~optuna.exceptions.TrialPruned).Using --skip-exception should be fine for my case case.
        catch:
            A study continues to run even when a trial raises one of the exceptions specified
            in this argument. Default is an empty tuple, i.e. the study will stop for any
            exception except for :class:`~optuna.exceptions.TrialPruned`.

 It would be better if we could catch specific exception but I didn't hit upon a good interface. 😹
Let me close the issue as --skip-exception works for your case. Feel free to reopen or create another issue if it needs.


(PUP-9648) Prepare for PSON removal

Adds Puppet.features.pson? to detect if PSON is available like we do with msgpack
PSON related tests are guarded with Puppet.features.pson?

[ ] Beaker tests need updates

jenkins please test this

jenkins please test this


fix: adfs GetToken() and GetUserInfo() bug

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix module name typo in documentation

Perhaps the module had a different name in its infancy?
Also fixes missing newline at end of file.

Oh, yes, that's likely. Thanks for spotting that and sending the change!


Too many Cell outputs generated when replacing cell output with a new item containing a single output item

Identified when debugging https://github.com/microsoft/vscode/issues/131914
VS Code version: OSS
OS: Mac
Scenario:

Run a cell
Cell generates outputs
Extension will replace output with a new output containing a single output item
Everytime extension gets new output, the output is concatenated with the existing output.

Thus the over all effect is: we have a single output object with a single output item.
However, when we replace the output item, looking at the code we can see that we're passing a few 100 outputs around. I have a scenario where i have just 350 lines and each line is generated one at a time, looking at the logs we end up calling NotebookCellData.to with a cell data object containing 699 outputs.
This happens over 600 times. Feels like a lot of unecessary serialization & deserialization (data being passed back & forth).
I cannot tell whether this causes any perf issues, buf if this code is run over an hour, then we'd end up with a very very large number of outputs (running code for an hour or even 15-20 minutes is common in machine learning when training models) & at that point when we get output we end up in this scenario.
I.e. I think in CodeSpaces & and when users run cells for long periods of time this could be a perf issue.

I can't repro it in Jupyter and am not sure how this would happen, if you can still repro can you show me? I can't get the Node notebook example to run, I get this error Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: /Users/roblou/code/node-notebook/node_modules/node-fetch/src/index.js

Please use isomorphic-fetch instead of node-fetch (not entirely sure why it works for me, updated the samples to use that instead of node-fech).

I see it, thanks. Are you sure you are not doing appendOutput? I see appends coming through on the front end (didn't debug renderer yet)

My bad, its an issue at my end.


Remove Apollo decorator

It's deprecated since v0.5.0

@Urigo Not quite sure if we should push it with v0.6.0 or with v1.0.0.

0.6.0

@kamilkisiela can you link to the issue (or create one) on the Angular repo to explain why we decided not to use it for now?

@Urigo Sure!

keep track here - https://github.com/apollostack/angular2-apollo/issues/155


Can't start fastlane ci server

fastlane ci 1.0.0.alpha.1
After I follow the onboarding instructions and successfully finished all instructions, I was unable to add new project (Internal server error), I tried to stop and start server again and I got this:

Hey @imodeveloper, thanks for reporting this. Can you confirm this is still happening with the most recent code from master?

Hi @KrauseFx, sorry for late answer, I tried today, so with commit #2b8f587 server started with success 🎉and dashboard starts to.

Yesss thank you for getting back and confirming! I'm going to close this issue. Feel free to keep opening issues if you encounter anything!


Upgrade just about everything, including rewriting the gradle files.

Since R constants are no longer constants, change a switch statement.
This is a fairly major change of the way we're building to bring things up to date.  Needs clean up before merging and some careful scrutiny.

At last everything's green.

Something in here broke the way activities switch and borked the settings UI.


Redelivery count is not getting updated for negatively acknowledged messages.

Expected behavior
Whenever I negatively acknowledge a message, the message should be redelivered with its redelivery count incremented by 1.
Actual behavior
The redelivery_count is not getting incremented.
Steps to reproduce
Step 0: Create a pulsar topic
Step 1: Produce a message to the topic.
Step 2: create a consumer and negatively acknowledge the message
Step 3: After negative_acknowldegment time out(deafult=60sec) consume the message again, you will receive the same message. But it's redelivery_count is not updated. It showing as 0.
No matter how many times I negatively acknowledge the message. Its redelovery count is not getting updated.
System configuration
OS: ubuntu 18.04.1 LTS
I'm running pulsar in a container.
Pulsar version: 2.5.0
I'm using pulsar-client in python
Version: 2.5.0

@pradeep00m The redelivery_count is currently used by DeadLetterTopic. It is only enabled for shared subscription. Are you testing this using shared subscription or other subscription types?

I'm testing it on a Exclusive subscription. Yeah, its working on shared, is there anyway I can use redelivery_count in exclusive subscription.

@pradeep00m - I think there is a reason why redelivery_count was not enabled for a non-shared subscription. @codelipenghui can you chime in here?

I'm testing it on a Exclusive subscription. Yeah, its working on shared, is there anyway I can use redelivery_count in exclusive subscription.

We don't have to do this specifically in Exclusive subscription. Shared subscription also works for us. I was just wondering why it wasn't working for the Exclusive subscription. That's all.
Thanks.

@pradeep00m I see. thank you


Handle struct map in attribute writer.

@geirst: please review
@baldersheim: FYI

Conflict with https://github.com/vespa-engine/vespa/pull/6021
Will rebase


[GLUTEN-6977][CH] Remove concat function parser

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #6977)
How was this patch tested?
original uts

Run Gluten Clickhouse CI

current pr depends on https://github.com/Kyligence/ClickHouse/pull/500/files.


Allow tooltips to have line breaks with i18n json

Allow tooltips to have line breaks with i18n json using /n

Before merging, I have a feeling that tooltips support slots - if that's the case we probably don't need this. Happy to merge anyway though as it seems pretty harmless.

They do support slots, but it may be a bit weird since it's a tooltip prop on the ChecFormField. We could refactor ChecFormField to support slotted tooltips instead. This change should be pretty harmless though.


Minor update heaps-tables-without-clustered-indexes.md

@MikeRayMSFT

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


LastInsertId errors with There is no generated identity value

Hi,
Something happened with commit 9340cdc, when I try to get LastInsertId I keep getting back an error: There is no generated identity value,
but if I revert to 6a30f4e, the same code gives me the LastInsertId:
What I'm doing in the code:
I create a prepared statement that is an straightforward insert command e.g.:
stmt, _ := db.Prepare("Insert into sometable (somecolumn) values (?)")
res, err := stmt.Exec(somevalue)

if err != nil {
  fmt.Error(err)
}

id, err := res.LastInsertId()

if err != nil {
  fmt.Error(err)
}

The insert happens, I can see the data in the database, but the res.LastInsertId() gives me an error.

I should update docs. In SQL server you should select scope_identity() and manual return it.

Hi,
Thanks for updating so quickly. Unfortunately I've now got a few questions

The functionality for the LastInsertId() has been removed? Or changed?
Do I need to return the scope_identity() as part of the prepared statement? Or do I need to make execute a second query and parse the result set?
What if I'm not using a prepared statement and just executing pure SQL, will I still need to get it from the scope_identity() function?

Thanks for the assist, very much appreciated.

Preparing stmts has zero benefits for SQL server. You must execute in same SQL batch.
Just an aspect of how SQL server works.

Okay, thanks for the assist. Great work. Much appreciated.

I was affected by this, but I can only reproduce it with Go 1.10; with Go 1.9.4 it behaves as expected.
This report looks like it shouldn't have been closed:

The code proposed by @guoguojin looks fine to me
It currently works with Go 1.9.4 and not with Go 1.10

So either it doesn't work and then I'd like to understand the use cases of LastInsertId(), or there's something not quite right here.

The Go 1.10 version is the first Go version to support the session reset interface. The above stated version of this driver is the first version to support the session reset interface.
I should document this in the README. Some systems return a last ID inserted from queries. SQL Server does not. This means to try to support the interface we attempt to send another query to the database. select cast(@@identity as bigint); This sometimes works depending on the query, but you should not rely on it!
With the addition of the session reset interface this becomes impossible as the session will reset when the connection is sent again. Maybe we can make something work again, but I''m not convinced this is a good idea. In SQL Server your inserted IDs should be an explicit part of your query. You can use the OUTPUT clause or SCOPE_IDENTITY() to help here.

I am using OUTPUT within the query with db.Exec(stmt) with same result, result being There is no generated identity value .

This may be gimmicky... BUT I found that using err = db.QueryRow("INSERT INTO [TABLE] ([COLUMN]) VALUES (?); select SCOPE_IDENTITY()", colValue}).Scan(&id) will run multiple queries and just return the last row.
As long as select SCOPE_IDENTITY() is the last row returned then this essentially does what I I would have expected result.LastInsertId() to do.


Sibling elements messes with 'to have rendered' assertion

Assuming I have a component that renders two form elements, each inside its own nested div:
class Tester extends React.Component {
  constructor(props) {
    super(props);
    this.state = {
      country: 'DK'
    };
  }
  render() {
    return (
      <form>

          Country *
          <select value={this.state.country} >
            <option value="AF">Afghanistan</option>
            <option value="DK">Denmark</option>
          </select>

          Name *
          <input className="form-control" />

      </form>
    );
  }
}

I shallow render them, and want to test that the select has the correct value
this.renderer.render(<Tester />);

expect(
  this.renderer,
  'to have rendered',
  <form>
    <select value="DK" />
  </form>
);

If there is only one element (the select and its wrapper), the test passes, but when there are two elements (as shown in the example), in get the following error:

I have tested both shallow and deep rendering, and the have rendered and contains assertions, and they all give me the same error.
Am I unexpecting too much magic from the library, or should this kind of assertion be supported?

Oh, and thanks for an awesome library by the way! :)

It's certainly a currently unsupported form. I think supporting it would be too expensive, as it would increase exponentially the number possibilities, but I haven't thought through it in detail.
I think the easiest way would be to add the label as an empty tag to your assertion result. I know it's not ideal, but for the time being, I don't think I'll be looking into supporting this.  Obviously if a PR comes in that supports in a reasonable way, then great.
Sorry it's not better news.

I understand your concerns about performance, I mostly just wanted to be sure that I didn't miss anything obvious


Simplify SA1607 tests using [Theory]

Code looks good :+1:
I would prefer MemberData instead of InlineData here to reduce duplication.


Issue about inference

Hello,
Firstly, thanks for your nice work in trajectory prediction. However, I notices that you choose the best trajectory after comparing with ground truth trajectory in validation step. However, in test step, normally, we don't know the ground truth trajectory. Could you kindly tell me how to choose candidate trajectories in the inference step in HiVT?
Best,
Joe

Hi,
Thanks for your interest! Trajectory prediction is inherently a multimodal problem, so most models will predict multiple plausible trajectories. As you said, it's impossible to know the ground truth in advance. Metrics that are commonly used in this field (e.g., minADE and minFDE) only provide a way to measure a model's capability of covering the ground truth in the validation dataset.
We only predict 6 trajectories for each agent (i.e., the future distribution is parameterized by a mixture of Laplace distribution with 6 modes) simply because the metrics used in Argoverse motion forecasting benchmark (minADE_6, minFDE_6, and MR_6) allow a maximum of 6 predictions per agent. I have found that the more predictions we make, the lower minADE_6 we can get (see the attached image).
You may ask: how many predictions per agent do we need?  In practice, trajectory prediction models need to collaborate with the downstream motion planning module. We don't hope to predict too many trajectories, or else the drivable area for the autonomous vehicle would be too small and the behavior of the autonomous vehicle would be too conservative. We also don't hope to predict too few trajectories, or else the model may miss a potential case and the autonomous vehicle may suffer from the risk of collisions. I can't tell you what the optimal number of predictions is, but I think it depends on the motion planning module.

Hi,
Thanks for your nice reply.
Best,
Joe


[Bug] Fixing the position of "Add to Cart" button

Is your feature request related to a problem? Please describe.
So, currently the Add to Cart button is not consistent in position and depends on the length of the details of the book, which give a bad user experience.
Describe the solution you'd like
Fixed the Add to Cart button at the bottom right position
Describe alternatives you've considered
Comparison
Current-

Proposed-

I would like you to assign this to me under Hacktoberfest tag

@dcode-github Hey, please feel free to proceed with fixing the issue.


Looping value is not possible anymore

Before, the change event was triggered even if you reached the min / max value. This allowed to test for behavior in the change event, and to change the val accordingly.
In my fork, I made the buttons to be disabled automatically on reaching min / max. Further more, I also disabled sending an event of change when no changes occurs, therefore, you cannot handle changes when there is no changes.
I don't see a point of trying to handle change event when I expect the input to not change when on empty, therefore, I will add an option that makes the spinner loop automatically :
The logic will be simple : if configured to do so, if stepping down on the minimum value, the spinner will change the value to the max value. Same for stepping up.
Something I will need to lookout for : steps that are not +1, but for example +10. This step, if looped, will not go directly to the min value, but rather remainder + min.
The logic will therefore be something like :
var supposedVal = val() + step
var newVal = 0
// newVal is the other side + the remainder of the step
if ( step > 0 ) {
    newVal = {min} + ({supposedVal} - {max} > 0 ? {supposedVal} - {max} : 0)
}
else {
    newVal = {max} + ({supposedVal} - {min} < 0 ? {supposedVal} - {min} : 0)
}

val( {newVal} )

(that code piece called if looping is enabled)
of course, that would also mean that if the looping is enabled, the buttons would not get disabled when reaching min / max.
In my code above, there is no check if the step is actually bigger than the max / min, which is fun, I hope the library catches that, we'll see when programming that in and testing

Closed by 66e88f4aa7871165d42972f8bb0fcadf018a17b3


feat: cookie consent implementation

Description :sparkles:
Issues :bug:
Closes :no_good_woman:
DEV-XXX:
Related :handshake:
Testing :alembic:
Automated tests :gear:
Manual testing :construction_worker_man:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

Codecov Report

Merging #258 (8d26126) into master (9ee5d9d) will decrease coverage by 0.54%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
- Coverage   82.02%   81.47%   -0.55%
==========================================
  Files         115      116       +1
  Lines        2392     2408      +16
  Branches      817      819       +2
==========================================
  Hits         1962     1962
- Misses        424      440      +16
  Partials        6        6

Impacted Files
Coverage Δ

src/domain/cookieConsent/CookieConsent.tsx
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

moved matomo to optional cookies (based on new spex), updated translations, fixed tests.


Deep Merge Option

Add 'deep' merge option so that nested configs can be merged; default stays to override for backwards compatibility

good work, thanks.. although i don't think _.merge gives you the behaviour you are looking for..
look at this example, which merges two separate rewrite arrays.. in the result, the first item in the rewrite array has been overridden.. I think we want the two arrays to be combined resulting in 4 rewrite rules.
Looking into using _.mergeWith..

i think this is the result we want:
https://runkit.com/75lb/58066f28868d5c0014804c73

Ah yes I see what you mean now.


Set Hyperlink on Text With Input UI

I wanted to contribute to this feature where a user can set a hyperlink on any text with some basic UI like this should I work on this ?

Yes please! But let's make the UI much nicer – ideally it'll be similar to the Notion UI:


Fix cities with two boundaries areas, like Hamburg

Related to that, cities like London and Rome have a inner city. Include that in calculations


Add Style<T> Docs

This PR adds docs for CommunityToolkit.Maui.Markup.Style<T>

Microsoft authors of articles need to make updates through the private repository, so the updates can be staged and validated by current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.
It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
 Public repo URL: https://github.com/MicrosoftDocs/{docs-repo}
 Private repo URL: https://github.com/MicrosoftDocs/{docs-repo-pr}
We have closed this pull request. Please resubmit the updates through the private repo. For more information, see the contributor guide.

Docs Build status updates of commit e754597:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/markup/extensions/style.md
:bulb:Suggestion
View
Details

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

docs/maui/markup/extensions/style.md

Line 8, Column 9: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'T' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit e754597:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/markup/extensions/style.md
:bulb:Suggestion
View
Details

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

docs/maui/markup/extensions/style.md

Line 8, Column 9: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'T' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PRMerger Results

Issue
Description

Added File(s)
This PR contains added files. New files require human review.

File Change Percent
This PR contains file(s) with more than 20% file change.

Docs Build status updates of commit 334b83e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

docs/maui/markup/extensions/style.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PRMerger Results

Issue
Description

Added File(s)
This PR contains added files. New files require human review.

File Change Percent
This PR contains file(s) with more than 20% file change.

Docs Build status updates of commit b33f398:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

docs/maui/markup/extensions/style.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PRMerger Results

Issue
Description

Added File(s)
This PR contains added files. New files require human review.

File Change Percent
This PR contains file(s) with more than 20% file change.

Docs Build status updates of commit 5a9dc78:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

docs/maui/markup/extensions/style.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PRMerger Results

Issue
Description

Added File(s)
This PR contains added files. New files require human review.

File Change Percent
This PR contains file(s) with more than 20% file change.


Allow calico to be removed from containers even if they are missing f…

…rom docker.
Fixes #501

Huge :+1:  to this! A very desired feature with my work.

I'm planning to rework this slightly to remove the need for the workload_exists method.

@robbrockbank or @spikecurtis Could one of you take a look at this? I've reworked it to minimize etcd reads and fix up a few bugs in the process.

I'll take a look on Tuesday.  Sound good?

@spikecurtis Are you going to be able to look at this today? Otherwise @robbrockbank do you have time this afternoon?

@tomdee I will have time if spike doesn't

Spike's out of the office this afternoon so can you take a look?

Few comments in line and need to investigate build failure.

This should be good to go now. @robbrockbank

LGTM


Enhancement: kubevirt on ppc64le

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:
/kind enhancement

What happened:
I am trying to enable Kubevirt on ppc64le arch(nested VM not supported).
What you expected to happen:
Successfully deploy a VM in a K8s cluster via Kubevirt
How to reproduce it (as minimally and precisely as possible):

Get a working kubeadm cluster(1 master + 1 worker bare metal) on ppc64le
Set env variables as follows:

export DOCKER_PREFIX="index.docker.io/<reponame>"
export KUBECONFIG=/home/<name>/.kube/config
export IMAGE_PULL_POLICY=Always
export DOCKER_TAG=mybuild

docker login -u <repo-name>

make && make push / make cluster-build
kubectl create -f _out/manifests/release/kubevirt-operator.yaml
kubectl apply -f myconfig.yaml

cat myconfig.yaml
apiVersion: v1
data:
  dev.imagePullPolicy: Always
kind: ConfigMap
metadata:
  name: kubevirt-config
  namespace: kubevirt

kubectl create -f _out/manifests/release/kubevirt-cr.yaml
Create a VMI kubectl create -f cluster/examples/vmi-ephemeral.yaml

kubectl get pods
NAME                                READY   STATUS   RESTARTS   AGE
virt-launcher-vmi-ephemeral-cnpvt   0/2     Error    0          19h

kubectl logs virt-launcher-vmi-ephemeral-cnpvt
Error from server (BadRequest): a container name must be specified for pod virt-launcher-vmi-ephemeral-cnpvt, choose one of: [volumecontainerdisk compute]

Kubectl get events
5m12s       Normal    Pulling            Pod                      pulling image "index.docker.io/niteshkonkar/virt-launcher:mybuild"
5m1s        Normal    Pulled             Pod                      Successfully pulled image "index.docker.io/niteshkonkar/virt-launcher:mybuild"
5m1s        Normal    Created            Pod                      Created container
5m1s        Normal    Started            Pod                      Started container
4m46s       Warning   Unhealthy          Pod                      Readiness probe failed: cat: /var/run/kubevirt-infra/healthy: No such file or directory
5m13s       Normal    SuccessfulCreate   VirtualMachineInstance   Created virtual machine pod virt-launcher-vmi-ephemeral-94hx6
4m44s       Warning   SyncFailed         VirtualMachineInstance   server error. command Launcher.Sync failed: "LibvirtError(Code=8, Domain=44, Message='invalid argument: could not find capabilities for arch=ppc64le domaintype=kvm ')"
0s    Warning   SyncFailed   VirtualMachineInstance   connection is shut down
0s    Normal   Killing   Pod   Killing container with id docker://volumecontainerdisk:Need to kill Pod

Anything else we need to know?:
Environment:

KubeVirt version (use virtctl version): upstream master
Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.3", GitCommit:"721bfa751924da8d1680787490c54b9179b1fed0", GitTreeState:"clean", BuildDate:"2019-02-01T20:08:12Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/ppc64le"}
Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.4", GitCommit:"c27b913fddd1a6c480c229191a087698aa92f0b1", GitTreeState:"clean", BuildDate:"2019-02-28T13:30:26Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/ppc64le"}

VM or VMI specifications:
Cloud provider or hardware configuration:
Master Node: Ubuntu 1604 VM
Worker Node: IBM Power 8 System bare metal Ubuntu 1604
OS (e.g. from /etc/os-release):

NAME="Ubuntu"
VERSION="16.04.5 LTS (Xenial Xerus)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 16.04.5 LTS"
VERSION_ID="16.04"
HOME_URL="http://www.ubuntu.com/"
SUPPORT_URL="http://help.ubuntu.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"
VERSION_CODENAME=xenial
UBUNTU_CODENAME=xenial

Kernel (e.g. uname -a):

Linux ubuntu 4.4.0-131-generic #157-Ubuntu SMP Thu Jul 12 15:47:54 UTC 2018 ppc64le ppc64le ppc64le GNU/Linux

Install tools:
Others:

cc @rmohr @cynepco3hahue

/cc @fabiand

Hey all,
We've got a lot of interest in our organization for running VMs on ppc64le. Does anyone have a status update on this?
/jeremy

@jeremyrogers I know that @nitkon created some POC PR https://github.com/kubevirt/kubevirt/pull/2145, but I do not sure if he will continue with it :worried:
I will try to find some time the next week to start to finalize and polish the PR.

I can pick this issue up.  I'm not completely certain of the existing status of kubevirt on ppc64le, but I'll have some more time at the beginning of next week to really dig into these commits and get a feeling of what sort of enablement work has been done so far.
Thanks!

@dbenoit17 It can be wonderful, and feel free to ping me or @rmohr under the slack k8s virtualization group.

@jeremyrogers @nitkon @dbenoit17 what about syncing on a ml or zoom to sync on your different statuses?

@fabiand Absolutely.  Should we sync up on a weekly call, or set aside a dedicated time just for this?

Hello All, I would like to provide the latest status update on this issue. I have updated my PR and I could deploy a cirros VM on ppc64le via Kubevirt.
Here are the steps I followed:

Setup was a 2 node kubeadm cluster. 1 master node VM and 1 bare metal Power system worker node (as nested VM not supported in ppc64le)

root@ubuntu:/home/nitesh# kubectl get nodes
NAME               STATUS   ROLES    AGE   VERSION
gar01.in.ibm.com   Ready    <none>   10m   v1.14.0
ubuntu             Ready    master   11m   v1.14.0
root@ubuntu:/home/nitesh# kubectl get pods --all-namespaces
NAMESPACE     NAME                             READY   STATUS    RESTARTS   AGE
kube-system   coredns-fb8b8dccf-7wwsb          1/1     Running   0          11m
kube-system   coredns-fb8b8dccf-85wjb          1/1     Running   0          11m
kube-system   etcd-ubuntu                      1/1     Running   0          10m
kube-system   kube-apiserver-ubuntu            1/1     Running   0          10m
kube-system   kube-controller-manager-ubuntu   1/1     Running   0          10m
kube-system   kube-proxy-f2bmq                 1/1     Running   0          11m
kube-system   kube-proxy-zcbst                 1/1     Running   0          10m
kube-system   kube-scheduler-ubuntu            1/1     Running   0          11m
kube-system   weave-net-b92c2                  2/2     Running   0          10m
kube-system   weave-net-dnqpm                  2/2     Running   0          10m

kubectl create -f kubevirt.yaml

root@ubuntu:/home/nitesh/yaml_configs# kubectl get pods --all-namespaces
NAMESPACE     NAME                               READY   STATUS    RESTARTS   AGE
kube-system   coredns-fb8b8dccf-7wwsb            1/1     Running   0          17m
kube-system   coredns-fb8b8dccf-85wjb            1/1     Running   0          17m
kube-system   etcd-ubuntu                        1/1     Running   0          16m
kube-system   kube-apiserver-ubuntu              1/1     Running   0          16m
kube-system   kube-controller-manager-ubuntu     1/1     Running   0          16m
kube-system   kube-proxy-f2bmq                   1/1     Running   0          17m
kube-system   kube-proxy-zcbst                   1/1     Running   0          16m
kube-system   kube-scheduler-ubuntu              1/1     Running   0          17m
kube-system   weave-net-b92c2                    2/2     Running   0          16m
kube-system   weave-net-dnqpm                    2/2     Running   0          16m
kubevirt      virt-api-769f9d9f96-5qcsn          1/1     Running   0          4m33s
kubevirt      virt-api-769f9d9f96-btwnq          1/1     Running   0          4m33s
kubevirt      virt-controller-69c47cc76b-85wzw   1/1     Running   0          4m33s
kubevirt      virt-controller-69c47cc76b-f4cbp   1/1     Running   0          4m33s
kubevirt      virt-handler-cz8dn                 1/1     Running   0          4m33s

kubectl patch serviceaccount default  -p '{"imagePullSecrets": [{"name": "regcred"}]}'
serviceaccount/default patched

kubectl create -f  vmi-linux-ppc64le.yaml

root@ubuntu:/home/nitesh/yaml_configs# kubectl get pods
NAME                                    READY   STATUS    RESTARTS   AGE
virt-launcher-vmi-linux-ppc64le-stxw7   2/2     Running   0          111s

root@ubuntu:/home/nitesh/yaml_configs# kubectl get vmi
NAME                AGE     PHASE     IP          NODENAME
vmi-linux-ppc64le   2m42s   Running   <IP_ADDRESS>   baremetal123

virtctl console vmi-linux-ppc64le

Successfully connected to vmi-linux-ppc64le console. The escape sequence is ^]

login as 'cirros' user. default password: 'gocubsgo'. use 'sudo' for root.
cirros login: cirros
Password:
$ uname -a
Linux cirros 4.4.0-28-generic #47-Ubuntu SMP Fri Jun 24 10:09:20 UTC 2016 ppc64le GNU/Linux

kubevirt.yaml.log
vmi-linux-ppc64le.yaml.log

/cc @dbenoit17

/remove-lifecycle stale

/remove-lifecycle rotten


Support Solidity 0.8.1

Support for 0.8.1 using custom built npmjs package (https://www.npmjs.com/package/solc-0.8.1-fixed). This is mostly a copy of https://github.com/ConsenSys/solc-typed-ast/pull/22 except for the use of the new package instead of downloading solc binaries.

While it looks good to merge, let's close it in favor of #25. As 0.8.1-related changes are already there, we can add a single line to package.json:
"solc-0.8.1"<EMAIL_ADDRESS>
So, the most valuable part here is the published package. Thank you for providing it.


Two theorems implying CWN

work in progress.

@StevenClontz The build for this branch cwn2 succeeds, but for some reason I am unable to preview it on the web site.
For some reason, the initial updating of the traits gets stuck.  Any idea?
If nothing else works, I'll try to redo it in another branch.

possibly related: https://github.com/pi-base/web/issues/200 (in that case, I know I introduced an error for the Empty space, but it wasn't caught at compilation)

Interesting.  For me, when going to the Advanced tab and trying to preview the new branch, the initial updating of all the traits (as indicated by the progress of the green bar) gets stuck half way through and it never finishes.  Was that the same symptom you were having?

I've had a similar issue. On chrome you can clear the cache for a single website: chrome://settings/content/all?searchSubpage=pi-base, and this may fix the issue.

Thanks for the tip.  In this case it did not help.  I'll try something else.

@yhx-12243 Very good eyes! That must be it.

Nicely spotted @yhx-12243!
I'm not sure what's happened that has caused the compiler to not catch these contradictions. 😢 But we'll need to be vigilant to ensure that things are building in the viewer until pi-base/web#200 can be addressed.

Note: It does not seem possible to generalize T662 to [countable extent + normal => collectionwise normal].
For example, take a space $Y$ that is $T_4$ but not collectionwise normal.  For example S136 (Bing's Example G).
Let $X=Y\times B$, where $B$ is a two-point set with the indiscrete topology.
Then $X$ is weakly countably compact (= limit point compact) because every nonempty set has a limit point.
And it is normal, but not collectionwise normal (by looking at the Kolmogorov quotient, which is homeomorphic to $Y$.


Feature request: Defeated monster confirmation

Feature Request
Is it possible to add a confirm/cancel dialog when instructing the app that a monster group is defeated? This is the default behaviour in Road to Legend.

The general idea is that these additional confirmations are removed as Valkyrie has an Undo button. Most feedback I have to date is that this is preferred.
It would be possible to have it as a toggled option, but this will not be a high priority for me.

My bad, completely forgot about the Undo button... That's definitely preferable, ignore this feature request!


Does Slinky support transistive dependencies?

Hi, this might be an expected scalaJs requirement in writing facades (so sorry in advance but I didn't see documentation on it), but is it necessary in Slinky to write facades for dependencies of a Javascript library if your scala code never directly interfaces with them?
For instance, I added a facade for rc-slider (it itself has 7 dependencies), which optionally can specify a custom "handle" (to produce a tooltip). But when I enabled this, suddenly I needed to define ExternalComponent objects for a few dependencies I'm otherwise not directly needing:

rc-tooltip
rc-align
rc-trigger

So even though rc-slider is the only external object I'm actually constructing in my code, the following is necessary to avoid type errors, which I guess is because Scala code is first being auto generated for me involving these types before being compiled into javascript?
Is there no way to avoid defining Scala types for Javascript dependencies you have no intention of directly writing Scala code with?
To give you an idea, from the comment below down is the extra boilerplate I needed for everything to work without errors:
@JSImport("rc-slider/lib/Slider", JSImport.Default)
@js.native
object Slider extends js.Object {
  val Handle: js.Object = js.native
}

@react object RcSlider extends ExternalComponent {
  case class Props(
                    defaultValue: Double,
                    value: Double,
                    disabled: Boolean,
                    min: Double,
                    max: Double,
                    step: Int,
                    onChange: Double => Unit,
                    marks: js.Object,
                    tipFormatter: Double => String,
                    handle: HandleProps => ReactElement
                  )
  override val component = Slider
}

@react object RcHandle extends ExternalComponent {
  case class Props(
                    value: ReactElement
                  )
  override val component = Slider.Handle
}

// additional facades for dependencies of rc-slider (that I'm not directly using in my scala code)
@JSImport("rc-tooltip", JSImport.Default)
@js.native
object Tooltip extends js.Object {}

@react object RcTooltip extends ExternalComponent {
  case class Props(
                    placement: String,
                    trigger: Seq[String],
                    overlay: ReactElement,
                    visible: Boolean,
                    key: Int
                  )
  override val component = Tooltip
}

@JSImport("rc-align", JSImport.Default)
@js.native
object Align extends js.Object {}

@react object RcAlign extends ExternalComponent {
  case class Props(align: AlignConfig)
  override val component = Align
}

@JSImport("rc-trigger", JSImport.Default)
@js.native
object Trigger extends js.Object {}

@react object RcTrigger extends ExternalComponent {
  case class Props(
                  action: Seq[String],
                  popup: ReactElement,
                  popupAlign: AlignConfig
                  )
  override val component = Trigger
}

Hi, what is the error you get if you don't define the additional facades? Everything should have worked fine without having to define the transitive dependency types.

I conflated two issues after getting confused by javascript console errors. You're right my added facades were not needed.
Sorry about that! Javascript console errors can really throw me off sometimes


Allow for opening multiple files from "Go to file.." (CTRL-P) menu

On many occasions I intend to open files of the same name across different folders. To do this, I have to repeat the process of opening the "Go to file.." (CTRL-P) menu, typing the file name and then selecting the next one. If I could select multiple files in the first iteration, that would be most useful.

See https://github.com/microsoft/vscode/issues/66971#issuecomment-1045991331 for a tip.
I previously drafted PR #143460 to explore another way of supporting this, but it hasn't yet gained any traction.

Thanks @gjsjohnmurray - I really like your suggestion. Sorry I did not find it when I searched.
@TylerLeonhardt I am happy to have this closed and I will "upvote" John's.

/duplicate #55146

/duplicate #55146

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Process Audio Loopback Capture

I've tried a first pass at addressing Issue https://github.com/HEnquist/wasapi-rs/issues/26 as I was interested in the same functionality. The wrapper approach is a bit clunky but I couldn't see an easy way to merge it with the normal capture without opening a bunch of potential misconfiguration to users.

Thanks for the PR!
It gets a bit limiting with having all the methods implemented separately on two structs (the wrapper and the normal AudioClient). I think this could maybe be improved by introducing two traits. One for all the methods that work for both cases, implemented for both structs, and one that adds the methods that only work for the normal AudioClient.
That way it should be possible to build apps that can use both, without needing two completely separate code paths.

It's not obvious what is the best way. Option 2 has the advantage of staying quite close to the underlying windows api. Do you know if the limitations in process capture are described in some Microsoft docs? I think I prefer this solution. I think it should be enough to mention the limitations in the docs for the special constructor. The comments you wrote for those commented out methods on the wrapper would be a very good starting point.
Option 2 also has another possible advantage. In case some of the methods that don't work on the process capture audio client start working in a future windows version, no changes are needed to support this.

I'm happy to take a swing at any of the above, though it will probably be weekends only.

Sounds great! All work on this project is done on weekends and evenings so this fits nicely :)

Hi, just about to submit my pull request for this, was a bit late as I have been quite busy recently, my implementation is broadly the same but I have implemented solely on the AudioClient struct.
Having briefly looked over this request I can see one potential issue with memory here: pBlobData: &audio_client_activation_params as *const _ as *mut _, in the prop variant activation, it should be held in a box otherwise there is a memory panic at least when I was testing it.

Ok so now we have to suggestions for how to implement this :) I haven't had time to look closely at either yet, but at a glance both contain good stuff. It would be great if we could somehow combine the best of both.
As I mentioned before, I like option 2 above, which is the approach taken in #29. This PR (#28) however contains more information on what methods are useful or not. Could the wisdom in those comments be included in the docstrings of #29?
Another nice thing in #28 is that the activation handler is implemented in the library, so that there is no need to have it in the  code using this library (like in https://github.com/JohnMitchell04/wasapi-rs/blob/a0c330847eb28268e37ff7acf544c28fa5589d1c/examples/application_loopback_capture.rs#L19).

OK! I've integrated the information in each in the style of Option 2.
Switching the direction of the AudioClient from Capture to Render as per JohnMitchell04's PR solved the integration problems with the existing AudioClient initialize client method.
To address the panic https://github.com/HEnquist/wasapi-rs/pull/28#issuecomment-2091715736 I've used pinning for the values passed as pointers during interface activation in https://github.com/HEnquist/wasapi-rs/pull/28/commits/f6d04c3f86117503e4509d5eff5df3dc73624f1d.  Could you give this a test @JohnMitchell04? I haven't been able to reproduce the panic and can't use MIRI to check it because of all the FFI going on. I assume the compiler was free to move unpinned values around on the stack even if it wasn't happening to me. If we use a box for the first struct I still think we have to pin the second one, but we could get rid of the ManuallyDrop wrapper if we trust that the dealloc performed by windows will always have the right alignment etc.

All appears to be working on my end and everything looks like a good implementation as far as I can see.

Thanks for updating! This is looking good. I'll merge it and then make a new release once I have looked at https://github.com/HEnquist/wasapi-rs/issues/27.


Energy data for Micro Inverter Setup

Hello,
First, many thanks for this great peace of software.
I have a 5KW Deye inverter and everything works fine with the code reading implementation.
I have a micro inverter connected to the GEN port to reuse some old installed equipment.
I noticed that all the energy being produced by the micro inverter in the GEN port, is not being counted into the total PV production Energy counters.
Downloaded an export from solarman smart web, and the value of energy produced daily and total by the micro inverter GEN port is available in the excel file as "Daily Production MI(kWh)" and "Total Production MI(kWh)".
Do you know in each register these values are stored and if is it possible to get this data?
I assume that my Total Energy Production would be the sum of the PV production + Micro Inverter production.
Thank you.

Hi @martinisonline , I can unfortunately not confirm, but would suspect that the value for the entity "sensor.deye_micro_inverter_power" would contain the power. However, the unit is set as Watt, and is probably instantaneous power (not kWH). It should be possible to use this value in a template to sum it, but it would not be trivial.
The modbus registers are described in the attached document - I see only the register already exposed in the document:
sunsynk_modbus.pdf
If you manage to do this, you should be able to add this as an additional production to the energy dashboard so it can do the summation for you.
Hope you have success.

Hi @martinisonline , Thanks for the effort. I was a bit busy the last few weeks and only catch up now.
I had another look at the document (even translated the Chinese) and confirm that the doc does not include the two values. Can you may test by modifying the parameters.yaml file, adding the two values.
To add then, just edit the file with a text editor (I can recomend using VS Code) and add the extra parameters as follows:
    - name: "Microinverter Daily Energy"
      class: "energy"
      state_class: "measurement"
      uom: "kWh"
      scale: 1
      rule: 1
      registers: [0x003E]
      icon: 'mdi:solar-power'

    - name: "Microinverter Total Power"
      class: "energy"
      state_class: "total_increasing"
      uom: "kWh"
      scale: 1
      rule: 1
      registers: [0x005C]
      icon: 'mdi:solar-power'

This is assuming that the 62, and 92 you referred to was the decimal values for which the hex values are 3E and 5C respectively . You can play around with the scale if it needs to be scaled before display.
If this works, please send me the final details and I will include in the distribution, of if you are familiar with git, do a "pull request"

Hi.
Maybe I did something wrong, but trying to this configuration, it doesn't worked.
I have four micro-inverters 2KW, model SUN-2000G3 4 MPPT 220V DEYE. If anybody can help integrate them, I will be very grateful.

Hi.
Maybe I did something wrong, but trying to this configuration, it doesn't worked.
I have four micro-inverters 2KW, model SUN-2000G3 4 MPPT 220V DEYE. If anybody can help integrate them, I will be very grateful.

Hi,
I have an inverse of this same model.
I integrated mine using it as:
lookup_file: deye_string.yaml

Thank you! Great!

https://github.com/StephanJoubert/home_assistant_solarman/issues/46 here is microinverter config.