Feature: Add impersonation to tekton results API

Changes
Resolves #309
This feature adds Kubernetes impersonation header processing, impersonation access check for requester and RBAC for tekton results resources with impersonated user data.
https://kubernetes.io/docs/reference/access-authn-authz/authentication/#user-impersonation

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:

[x] Has Docs included if any changes are user facing
[x] Has Tests included if any functionality added or changed
[x] Tested your changes locally (if this is a code change)
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[x] Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes
Kubernetes impersonation headers can be used when authorizing access to Tekton Results APis.

ACTION REQUIRED: The NO_AUTH config parameter was renamed to AUTH_DISABLE

/kind feature

/test all

/test pull-tekton-results-integration-tests

/assign @adambkaplan

/assign @dibyom @alan-ghelardi
There is a breaking configuration change here.

Shouldn't we introduce a deprecation notice instead of directly breaking it? We can remove the NO_AUTH in the next release with the ACTION required notice. In this release, we can have a deprecation notice.

Shouldn't we introduce a deprecation notice instead of directly breaking it? We can remove the NO_AUTH in the next release with the ACTION required notice. In this release, we can have a deprecation notice.

Technically, we are allowed to make breaking changes in alpha apis. Though generally what we have done in other projects is what @khrm is suggesting here

Shouldn't we introduce a deprecation notice instead of directly breaking it? We can remove the NO_AUTH in the next release with the ACTION required notice. In this release, we can have a deprecation notice.

Agreed! But this flag is mostly for development, to bypass the RBAC processing.
Even if this flag is missing from the config, the parses will assume the value as false and continue. Which is the default behaviour anyways.
Also the release will ship the config file which will anyways have the modified parameter.

Almost there! Code looks good, I added a suggestion to add a code comment.
Can you also please add a section to the Authorization doc that indicates we support Kubernetes impersonation headers [1]? You don't need to explain what user impersonation is - a link to the Kubernetes doc [2] is sufficient. Just focus on how to enable the feature and how Results clients (gRPC, REST) can use it.
[1] https://github.com/tektoncd/results/tree/main/docs/api#authenticationauthorization [2] https://kubernetes.io/docs/reference/access-authn-authz/authentication/#user-impersonation

Added code comment and updated doc.

@alan-ghelardi just want to check with you that renaming the NO_AUTH config setting to AUTH_DISABLE is acceptable (since this feature was your contribution).
Otherwise LGTM.


python 2.6.6 fails to install on MacOSX Snow Leapord

test test_platform
test test_platform failed -- Traceback (most recent call last):
File "/Users/papaver/.pythonbrew/build/Python-2.6.6/Lib/test/test_platform.py", line 119, in test_mac_ver
self.assertEquals(res[2], 'i386')
AssertionError: 'x86_64' != 'i386'
331 tests OK.
1 test failed:
test_platform
34 tests skipped:
test_al test_bsddb test_bsddb3 test_cd test_cl test_codecmaps_cn
test_codecmaps_hk test_codecmaps_jp test_codecmaps_kr
test_codecmaps_tw test_curses test_dl test_epoll test_gdbm test_gl
test_imageop test_imgfile test_largefile test_linuxaudiodev
test_normalization test_ossaudiodev test_pep277 test_py3kwarn
test_smtpnet test_socketserver test_startfile test_sunaudiodev
test_tcl test_timeout test_urllib2net test_urllibnet test_winreg
test_winsound test_zipfile64
2 skips unexpected on darwin:
test_dl test_tcl
Any idea why I may be running into this?  It looked like universal binaries were being created.  Thanks.

I get this to.
IMO this is a bad test. The pythonbrew docs themselves point to far more platforms than just ppc and i386 (the only 2 values the test accepts)
See my comment here.
https://github.com/utahta/pythonbrew/issues/37#issuecomment-3504849
This specific test failure should be safe to ignore as long as it isn't hiding any others.


Experiment demos require C++ compiler

Im learning python, and i am excited to use my Oak-D  with these example experiment demos. When i do pip install it fails wanting me to compile the c++
My feature request would be that pip installs automatically.

Hi @jward87
Can you share the output of pip install as well as your system that you are using?
I assume your are running a system for which we don't yet have prebuilt python wheels available


[SPARK-22548][SQL] Incorrect nested AND expression pushed down to JDBC data source

What changes were proposed in this pull request?
Let’s say I have a nested AND expression shown below and p2 can not be pushed down,
(p1 AND p2) OR p3
In current Spark code, during data source filter translation, (p1 AND p2) is returned as p1 only and p2 is simply lost. This issue occurs with JDBC data source and is similar to SPARK-12218 for Parquet. When we have AND nested below another expression, we should either push both legs or nothing.
Note that:

The current Spark code will always split conjunctive predicate before it determines if a predicate can be pushed down or not
If I have (p1 AND p2) AND p3, it will be split into p1, p2, p3. There won't be nested AND expression.
The current Spark code logic for OR is OK. It either pushes both legs or nothing.

The same translation method is also called by Data Source V2.
How was this patch tested?
Added new unit test cases to JDBCSuite
@gatorsmile

Can one of the admins verify this patch?

Looks like a bug and be there for a long while. cc @cloud-fan @HyukjinKwon can you help trigger the test? Thanks.

@jliwork Can you fix the PR title? The title is cut when pasting on.

@viirya Thanks for letting me know, Simon. I've fixed the title. Can someone please help trigger the tests please?

ok to test

Test build #84010 has started for PR 19776 at commit 58de88c.

This affects correctness, should we also backport to 2.2?

@viirya I'm fine with backport to 2.2 unless anyone objects.

@jliwork Let's see what @cloud-fan @felixcheung think about it.

Test build #84010 has finished for PR 19776 at commit 58de88c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84010/
Test PASSed.

Test build #84017 has started for PR 19776 at commit e540790.

Test build #84018 has started for PR 19776 at commit 635768e.

Test build #84018 has finished for PR 19776 at commit 635768e.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #84017 has finished for PR 19776 at commit e540790.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84018/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84017/
Test FAILed.

Test build #84019 has started for PR 19776 at commit 3bb7d3c.

Test build #84019 has finished for PR 19776 at commit 3bb7d3c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84019/
Test PASSed.

good catch! It's a long-standing bug and I think we should backport it all the way to 2.0

Test build #84047 has started for PR 19776 at commit 0aebdfb.

Test build #84053 has started for PR 19776 at commit ba06181.

Test build #84055 has started for PR 19776 at commit fc34568.

Test build #84055 has finished for PR 19776 at commit fc34568.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #84053 has finished for PR 19776 at commit ba06181.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class DataSourceStrategySuite extends PlanTest with SharedSQLContext

Test build #84047 has finished for PR 19776 at commit 0aebdfb.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class DataSourceStrategySuite extends QueryTest with SharedSQLContext

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84055/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84053/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84047/
Test FAILed.

LGTM except a few minor comments

@cloud-fan Thank you for your comments! I have updated the test cases as you suggested.

Test build #84063 has started for PR 19776 at commit 0cbb528.

Test build #84063 has finished for PR 19776 at commit 0cbb528.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84063/
Test PASSed.

Few comments, otherwise LGTM.

LGTM otherwise too.

Test build #84086 has started for PR 19776 at commit a0b3d4e.

Thanks for everyone's comments! I have polished the test cases.

LGTM

Test build #84087 has started for PR 19776 at commit 7a19ac6.

Test build #84086 has finished for PR 19776 at commit a0b3d4e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84086/
Test PASSed.

LGTM

Thanks! Merged to master/2.2/2.1

@gatorsmile @cloud-fan @viirya @HyukjinKwon Thanks a lot! =)

Test build #84087 has finished for PR 19776 at commit 7a19ac6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84087/
Test PASSed.

Merged build finished. Test PASSed.


feat: update readme and add docker-compose

Updated the readme with more detailed permissions and how to change the bot's message, also added docker-compose instructions to the readme and added an example docker-compose file for easy running with compose

Maybe change docker-compose.yml.example to docker-compose.yml?


Support AdaptationSet@group

DASH IOP says encrypted content where SD/HD/UHD have different keys, they should be in separate AdaptationSets.  To support this, we need to support the group attribute to group AdaptationSets together logically.  The player should be able to adapt between AdaptationSets that are in the same group.
Protected content throws another wrinkle into this.  We should be able to tolerate a license failure for a particular AdaptationSet, while still making use of other AdaptationSets in the same group.  For this to work smoothly, sets should be sorted by resolution and only the 0th should be used initially.  Licenses should be requested for all sets.  As license requests succeed for other sets, they can be made available for adaptation.

Alternately, we can start making use of key statuses from EME and default key IDs from the manifest to determine what we can and can't play before trying to.  This would be much simpler, but I'm not sure what the fallback would be if either feature was missing.  Also not sure if this would cover all bases regardless of what key system is in use, or if we still would have to fetch licenses and tolerate failures in some cases.

We have a manifest with 3 video adaptation sets all with group=2 and they all have the same protection. I can see that the mpd_processor is correctly grouping them into the same StreamSetInfo but I notice that because of this:
`If the streams are encrypted then assume the key system can probably
decrypt the lowest quality streams.  This enables the VideoSource to
select at least one stream for stream startup without having to query the
key system first.
The lowest quality streams are the streams that are contained within
the AdaptationSet which contains THE lowest quality stream.`
Only the representations in the first adaptation set have allowedByKeySystem=true initially.
I thought that on keystatuseschanged these other adaptation sets in the group would end up having allowedByKeySystem set to true in shaka.player.StreamVideoSource.prototype.onKeyStatusesChange.
But it looks like this:  streamInfo.allowedByKeySystem = !message on line 959 of stream_video_source is never getting hit so they are never being exposed as available tracks.
Can you help to clarify this situation for me and why this is happening. I'm still hazy on the DASH spec and it's unclear to me if having multiple adaptation sets in the same group with the same content protection is unusual/non-standards-compliant or if this was an unanticipated scenario and a bug in Shaka.

The usefulness of AS groups, as far as we are concerned, is to group together AdaptationSets and adapt between them.  Otherwise, you would only adapt within a single AdaptationSet.
The DASH interoperability (IOP) docs, as we understand them, state that ContentProtection should only exist at the AdaptationSet level, and that all Representations within an AdaptationSet must have the same key.
Therefore, if you want to use different keys for SD/HD/UHD, and you also want to be DASH-IOP-compliant, you have to use groups.  Supporting this scenario is tricky for us, and requires the use of keystatuschanged events to determine whether or not we have keys for the higher-resolution parts of the group.
Finally, the only way to correlate the key statuses with an AdaptationSet is through the cenc:default_KID element inside ContentProtection.  Otherwise, we don't have any way to know in advance what key IDs the different parts of the group will use, and we can't enable them.
So here's the checklist I would suggest:

Do you use different keys to encrypt the AdaptationSets in the group?  If not, combine them into one AdaptationSet and stop using groups.
If you are using groups, do you have cenc:default_KID inside of ContentProtection?  If not, group support can't function correctly, so you'll need to add these.

We are using cenc:default_KID but this has the same value for each of the Adaptation Sets within the same group and it seems that Shaka then ends up ignoring the adaptation sets with the higher bandwidths onkeystatuseschanged. From what I understand of your explanation above though it sounds like unless we have different keys there is no reason not to be putting all of our Representations into a single Adaptation Set.

Correct.  If all the codecs and key IDs are the same, there's no reason to split up your AdaptationSets.
To enable debug logging, either run shaka.log.setLevel(shaka.log.Levels.DEBUG) in the app or add ?debug in the demo app URI.  With this enabled, do you see a message that says "Key blah was not specified in the manifest"?  This would indicate that you have the wrong key ID in your manifest, which would also explain the symptoms you're seeing.
If this message does not occur, then we may have a bug.  The code, as written, should still enable streams from other parts of the group once the license is processed.
Please let us know what you find out.

Yes I was seeing the message "Key... was not specified in the manifest".

If you have cenc:default_KID in the manifest, but it's not in the stream info, then perhaps the issue is somewhere in the manifest parser/processor.  Can you file a new issue and include a manifest which reproduces the issue?


adding completedAt field to Callbacks

@twitchett aha, here we see your java past!  it hurts you to see this combination type: string , all lowercased...     http://json-schema.org/  enjoy the reading!

oh you have eagle-eyes, @emig! haha, thanks!


Web Map "Movement Pattern" references services/layers that do not exist

Item id b8f09773673d4d7aaf9d1748c646a98c references the following services/layers that do not exist:
https://nsec.esri.com/ags/rest/services/Hosted/SignificantLocations/FeatureServer/0
https://nsec.esri.com/ags/rest/services/NationalIntelligence/Movement/FeatureServer/524
https://nsec.esri.com/ags/rest/services/NationalIntelligence/Movement/FeatureServer/523
https://nsec.esri.com/ags/rest/services/NationalIntelligence/Movement/FeatureServer/522
https://nsec.esri.com/ags/rest/services/NationalIntelligence/Movement/FeatureServer/521
https://nsec.esri.com/ags/rest/services/NationalIntelligence/Movement/FeatureServer/520
https://nsec.esri.com/ags/rest/services/NationalIntelligence/Movement/FeatureServer/519
https://nsec.esri.com/ags/rest/services/NationalIntelligence/Movement/FeatureServer/518
https://nsec.esri.com/ags/rest/services/NationalIntelligence/Movement/FeatureServer/517
https://nsec.esri.com/ags/rest/services/NationalIntelligence/Movement/FeatureServer/516
https://nsec.esri.com/ags/rest/services/NationalIntelligence/Movement/FeatureServer/515
https://nsec.esri.com/ags/rest/services/NationalIntelligence/Movement/FeatureServer/512
https://nsec.esri.com/ags/rest/services/NationalIntelligence/Movement/FeatureServer/514
https://nsec.esri.com/ags/rest/services/NationalIntelligence/Movement/FeatureServer/513
https://nsec.esri.com/ags/rest/services/NationalIntelligence/Movement/FeatureServer/511
https://nsec.esri.com/ags/rest/services/NationalIntelligence/Movement/FeatureServer/510
https://nsec.esri.com/ags/rest/services/NationalIntelligence/Movement/FeatureServer/507
https://nsec.esri.com/ags/rest/services/NationalIntelligence/Movement/FeatureServer/506
https://nsec.esri.com/ags/rest/services/NationalIntelligence/Movement/FeatureServer/505

Deleted Item


Need to open all UDP ports even when default UDP port is 8000

Hi,
The server is configured by default to deal with UDP packets on port 8000. But on my ec2 server in the cloud i have to open all UDP ports in order for client to get video data. What is the exact range of UDP ports utilized and how can I keep it constant?

use the issue template otherwise the issue will be inevitably closed.

the server uses UDP ports 8000 and 8001 as clearly stated in the configuration file. There are no other UDP ports involved.

I am referring to this please, you can clearly see the server logs its using all higher order UDP ports with each client connection like 50066, 50068, 60564 etc
2022/07/08 19:37:12 INF [RTSP] [conn <IP_ADDRESS>:50066] opened
2022/07/08 19:37:12 INF [RTSP] [session 940436013] created by <IP_ADDRESS>:50066
2022/07/08 19:37:12 INF [RTSP] [session 940436013] is reading from path 'mystream', 2 tracks with UDP
2022/07/08 19:38:00 INF [RTSP] [session 940436013] destroyed (teared down by <IP_ADDRESS>:50066)
2022/07/08 19:38:00 INF [RTSP] [conn <IP_ADDRESS>:50066] closed (EOF)
2022/07/09 08:01:55 INF [RTSP] [conn <IP_ADDRESS>:50068] opened
2022/07/09 08:01:55 INF [RTSP] [session 219357534] created by <IP_ADDRESS>:50068
2022/07/09 08:01:55 INF [RTSP] [session 219357534] is reading from path 'mystream', 2 tracks with UDP
2022/07/09 08:02:18 INF [RTSP] [session 219357534] destroyed (teared down by <IP_ADDRESS>:50068)
2022/07/09 08:02:18 INF [RTSP] [conn <IP_ADDRESS>:50068] closed (EOF)
2022/07/09 08:03:23 INF [RTSP] [conn <IP_ADDRESS>:60564] opened
2022/07/09 08:03:23 INF [RTSP] [session 774692581] created by <IP_ADDRESS>:60564
2022/07/09 08:03:23 INF [RTSP] [session 774692581] is reading from path 'mystream', 2 tracks with TCP
2022/07/09 08:05:01 INF [RTSP] [conn <IP_ADDRESS>:60564] closed (terminated)
2022/07/09 08:05:01 INF [RTSP] [session 774692581] destroyed (teared down by <IP_ADDRESS>:60564)

Those are TCP client ports, not UDP sever ports, but again, i won't discuss it in an issue opened without following the rules.


The sequence of addition nested forms

Hi!
I have next code:
%h3#poll-items Варианты ответа (не больше пяти)
  .item_index
    = f.simple_fields_for :poll_items do |poll|
      = render 'poll_item_fields', f: poll
    = link_to_add_association 'Добавить еще вариант', f, :poll_items,
                                      'data-association-insertion-method' => 'after'
    .form-actions
      = f.button :submit, 'Опубликовать опрос', class: 'btn-bg'

_poll_items_fields.html.haml:
.poll_row
  .poll_item
    = f.input :answer, input_html: { class: 'ctrlenter expanding' }, label: false, placeholder: 'Введите вариант ответа'
    = link_to_remove_association "удалить", f, { wrapper_class: 'poll_item' }

When I click to add a second nested fields, are added above the first nested fields. When I click the third and the following are added after the second: i.e., located between the first and second.
I dont know, but  why second nested filds is added above the first? How add second nested field after the first?

You describe the default behaviour, so I would remove the data-association-insertion-method :smile:
Default behaviour is to insert each new nested item before the add-link.
The data-association-insertion-method sounds pretty obvious, except you do not specify a selector, and the default selector is this. So you specified to insert the new nested item after the link_to_add_association link, meaning: the second insert it will be inserted between the link and the previously inserted item.
Is that clear?

Closed due to inactivity.


[AutoPR mariadb/resource-manager] typo: mariadb/resource-manager/Microsoft.DBforMariaDB

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4710

(message created by the CI based on PR content)


Input config.

Look i know u dont have time, but can u please change the input of the buttons to be like the xbox controller like x=Y and B=a pls
i will do it myself but i dont know how :(

fixed -- that should have been the default anyway
y'all need to learn C++

Tanks, I need too, Tho I only know the Basics ☹
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: Sam Johnson<EMAIL_ADDRESS>Sent: Thursday, March 28, 2019 9:55:39 PM
To: sam0x17/XJoy
Cc: Rexord0; Author
Subject: Re: [sam0x17/XJoy] Input config. (#25)
fixed -- that should have been the default anyway
y'all need to learn C++
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/sam0x17/XJoy/issues/25#issuecomment-477867223, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AuxttWcbbqzKSoI3qPHdbmvoJawvqkiSks5vbZzLgaJpZM4cRgUw.


Audio Recorder

Audio Recorder
Implement the Audio Recorder mode inside Autographa (via RCL) according to the UX design.

Completed for the decided scope.


knife environment create treats -d and --description differently

Description
Passing the -d flag to knife environment create does not try to bring up EDITOR, but passing --description does. I would expect both flags to behave identically.
https://docs.chef.io/knife_environment.html#create
Chef Version
Chef Development Kit Version: 0.15.15
chef-client version: 12.11.18
delivery version: 0.0.23 (bf89a6b776b55b89a46bbd57fcaa615c143a09a0)
berks version: 4.3.5
kitchen version: 1.10.0

Platform Version
Windows Server 2012 R2
Replication Case
C:\Users\Administrator\delivery-demo\delivery-base [master ≡]> knife environment create acceptance-mammalia-diprotodontia-awesome_customers_delivery-master --description "The acceptance environment"
ERROR: RuntimeError: Please set EDITOR environment variable
C:\Users\Administrator\delivery-demo\delivery-base [master ≡]> knife environment create acceptance-mammalia-diprotodontia-awesome_customers_delivery-master -d "The acceptance environment"
Created acceptance-mammalia-diprotodontia-awesome_customers_delivery-master

Client Output
N/A
Stacktrace
N/A

This is a doc bug, --description doesn't have a short option. I have a change that needs delivering that fixes this.


A favorite project of mine for review

Name: Notepads
GitHub repo: https://github.com/JasonStein/Notepads

Thanks for sharing 👍 I will review on a live stream soon 🤓

Reviewed on the live stream https://youtu.be/S8aiCHR2gzg
Looks really great, some thoughts:

Project roadmap is TBD from May 2020
If wiki is not being used, suggest removing it
great screenshots
suggest hiding packages if not used
suggest using issue labels


[Windows] Pressing the TAB is not moving the focusing and reading the Text Widget

Internal: b/241886719
Scaffold(
      appBar: AppBar(
        // Here we take the value from the MyHomePage object that was created by
        // the App.build method, and use it to set our appbar title.
        // We also apply a custom font, ProductSans.
        title: Text(widget.title),
      ),
      body: Column(
        children: [
          Expanded(
            child: ListView(
              children: [
                Text(
                  'This 0',
                ),
                Text(
                  'This 1',
                ),
                Text(
                  'This 2',
                ),
                Text(
                  'This 3',
                ),
              ],
            ),
          ),
        ],
      ),
    );

Repro steps:

Run NVDA or any other screen reader on the windows machine.
Press tab to move the focus.

Actual: Not moving the focus to text and not reading it out.
Expected: Should move the focus to the text and read out loud.

This is queued up after https://github.com/flutter/flutter/issues/109802.

@yaakovschectman informs me this is currently blocked on them getting some information from an a11y expert.

we have shortcut that handles tab on the framework side, we should first make sure it does not swallow the key press.
Is this a a keyboard focus or a11y focus? If we really can't get it to work, is it possible to send a11y focus event to the next item when tab is pressed?

In reality, we have found TAB works in a manner consistent with other applications, but keyboard commands that should allow navigation when using a screen reader (e.g. INS+UP/DOWN for NVDA) do not. Additionally, I have found that when using a screen reader, the screen reader processes keystrokes before Flutter does, so issues of Flutter swallowing key presses seem implausible.

Depending on how soon you expect to be able to talk to the person we discussed on Chromium, one other option is that NVDA is open source (appears to be written in python) so it may be possible to instrument it to get a better picture of what's going on.

update: @yaakovschectman informs me that they are talking with someone from Chrome about this.

Swapping assignment to myself while I attempt to clarify this bug and locate some win a11y experts who can help define the expected behaviour here.
The current state is:

NVDA documents that the Tab key reads the next focusable item such as (e.g. links, buttons). Text widgets are not focusable items and therefore our behaviour with regards to the Tab key is, I believe, working as intended.
NVDA documents that the down arrow key reads the next item. When I reconstruct the same example as HTML in a web browser, the down arrow does read each item in turn. In Flutter, it does not. Therefore, I think there is a bug to be resolved here. I'm following up with the internal filer on that side of things.

Just wondering if there have been any updates on this issue recently? I'm eager to unblock our Google customer!

We're still investigating what's going on with the arrow key navigation. @yaakovschectman has confirmed that NVDA is getting the keypress before the Flutter embedder is. Given NVDA is open source, I'm having a look at whether I can debug from the NVDA side to reveal what's going on here.

I spoke with somebody from NVDA, and it turns out that the functionality of the arrow keys is not modified by NVDA screen reader. The arrow keys are handled by an app as they normally are, and the app may fire an event in response. NVDA object navigation can be used to navigate through non-focusable elements, which sounds like what this issue regards.


feat: paybox wellsfargo connector added

Type of Change

[ ] Bugfix
[x] New feature
[ ] Enhancement
[ ] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description
paybox wellsfargo connector added

Motivation and Context

How did you test it?

Where to test it?

[x] INTEG
[x] SANDBOX
[x] PROD

Checklist

[x] I ran npm run re:build
[x] I reviewed submitted code
[ ] I added unit tests for my changes where possible

There is no metadata field returned from wasm, that is required for google pay and apply pay, therefore no fields are getting displayed. Please check this and update wasm as required.

Please raise a PR for updated wasm separately for the dashboard
Validate with the updated wasm & backend if we are able to connect the connector successfully


Create a Linux version of the run_mod.bat

I mainly use Linux as my daily driver I have to use projects such as wine/proton to use these scripts

I can create a new pull request which allows me to do this without any third-party software


add ignore-scripts to .npmrc

Initial checklist

[x] I read the support docs
[x] I read the contributing guide
[x] I agree to follow the code of conduct
[x] I searched issues and couldn’t find anything (or linked relevant results below)
[x] If applicable, I’ve added docs and tests

Description of changes
add ignore scripts to npmrc

broken

resolved, typescript now identifies a likely error in the legacy tests which it previously couldn't, this has been annotated with @ts-exepct-error


Blur the rest of the screen

I need to do a functionality like:
When the side menu presents using menuSlideIn then how to show the rest of the screen blur. Means the parent view on which slider appear to need to show blur so is this possible using this class.
Thanks.

This is a question for stackoverflow.com


README: Add link to swagger and REST endpoints people can query

@faddat thankfully added notes recently on how to spin up a node more easily. We should also add documentation / quick links for:

querying data from the chain (Swagger, a node to do it against e.g. datahub, and an example)
Mintscan as the block explorer to look at latest activity
Info.Osmosis.Zone
Imperator Swagger API

@daniel-farina you can assign me to this if you would like. I'm currently unsure of the best place in the github docs for them (own section or within networks) but I can write out the content none the less.

I suggest that the content be put right here-- everything we think of as osmosis, goes in here :). That way docs are versioned with code.

@daniel-farina does this page close this issue? The only thing that might need documentation would be the REST server but even swagger kind of guides you through it. LMK if you think it needs more to it and I'll accordingly, thanks.

That page lgtm! Can we close this issue once that data is on the repo's main README as well? (Or would you prefer an entire readme redesign in light of the docs)

@ValarDragon I just realized that Imperator.co's REST server lacks a large amount of queries normal swagger servers have. With that being said, its the best public osmosis REST server that I am aware of. Might need to be another issue created to make a public REST server with all swagger query options. IMO there should eventually be an official osmosis gRPC and REST endpoints (similar to how crypto.org has), but that's a separate discussion I suppose.

And yeah to answer your question I think at the completion of this when the docs folder is finally merged to main I would imagine the repo's main README would have to be reimagined.

Ok sgtm, can close for now if a README rewrite is already planned!
Yeah, we definitely need to link the "standard" query swagger and the imperator one. (We can probably recommend the imperator one, especially as it gets more expansive, but its anyways useful for cross-chain interoperability to have the standard one)


Use files in directories

Imports from subdirectories and renaming.

What about use /a.sy?

It will be added in another pr.


Preloading many batches onto the GPU

For my current classification problem using a deep ConvNet I have a dataset of roughly 20 gb. Therefore, I need to train the ConvNet batchwise (see this example). Each observation has quite low dimensions, causing a batch of 1024 observations to only be ~100 mb. My GPU can therefore hold roughly 40 batches at the same time as it has 4gb memory.
I suspect that it would significantly reduce training time if I moved 40 batches at a time to the GPU rather than just 1 batch as done in the example. Is such functionality implemented in Keras/Theano?

At 100MB you are close or at the max GPU transfer speed. You probably won't
get good speed up with those sizes with current GPU.
Le 27 déc. 2015 20:10, "PiranjaF"<EMAIL_ADDRESS>a écrit :

For my current classification problem using a deep ConvNet I have a
dataset of roughly 20 gb. Therefore, I need to train the ConvNet batchwise
(see this example
https://github.com/fchollet/keras/blob/master/examples/cifar10_cnn.py).
Each observation has quite low dimensions, causing a batch of 1024
observations to only be ~100 mb. My GPU can therefore hold roughly 40
batches at the same time as it has 4gb memory.
I suspect that it would significantly reduce training time if I moved 40
batches at a time to the GPU rather than just 1 batch as done in the
example. Is such functionality implemented in Keras/Theano?
—
Reply to this email directly or view it on GitHub
https://github.com/fchollet/keras/issues/1366.

Interesting. Could you elaborate a bit on that?


Quran App design

Assalamu Alaikum,
I was wondering if you're interested in working on using the following designs for the Quran app.

your designs are good but I believe there are lots of room for improvement. can you please design a more minimal design with more slick look?


504 Gateway Timeout When Trying to Download CSV from Map Roulette

Website: https://maproulette.org/api/v2/challenge/10077/tasks/extract?status=0,1,2,3,4,5,6,9&priority=0,1,2&reviewStatus=0,1,2,3,4,-1
Error Message:
504 Gateway Time-out / nginx/1.14.0 (Ubuntu)

Thanks for reporting this, @lmscheurer . PR maproulette/maproulette2#639 should significantly improve performance of the CSV generation

Fixed in v3.4.4. This should now work for you on maproulette.org


[WIP] Zone Maps

Veni, Vidi, Vici
I came, I saw, I scanned skipped
This PR adds the feature of Zone Maps into Peloton and some other features/ changes which are needed by the same.
Additional Bonus Feature : Immutability Flag :
This PR also adds an immutability flag in the tile group header. Relevant APIs are provided through which this flag can be atomically set. There are two major implications of setting a tile group to be immutable -

Tuples are not recycled from this Tile Group by the GC. Hence if a tuple is deleted from an immutable tile group, any further inserts will not reuse this slot. Appropriate tests for the same have been added in transaction_level_gc_manager_test.
Zone Maps are only created for tile groups that have been made immutable.

Zone Maps
Primarily this PR can be divided into 3 subparts:

Zone Map Manager : Any part of the system (ex Brain, Table Scan etc) should use the APIs provided by this Manager. This manager/indirection provides cleaner APIs, hiding the dirty work behind it. Using these APIs one can perform.

Creation of Zone Maps for a table / tile group .
Deletion of a Zone Map for a Tile group.
Reading of Zone Map and comparing against Predicates
Any other feature that goes in the zone map later should be added in the manager itself

Zone Map Catalog :  Peloton stores the zone maps of the entire system in a single catalog table. Each row of this catalog has the following columns.

database_id
table_id
tile_group_id
column_id
minimum
maximum
type
In the absence of Array Types, we are currently storing minimum and maximum as VARCHAR and hence we store the type to deserialize it.

Additional Wiring / CallBacks / Proxies : Primarily in place for the beast codegen to consume the Zone Maps. While iterating over the tilegroups, the decision to skip/scan a tile group is done through a simple call. This just adds one line of code [Link the line here] in the table.cpp reducing the visual overhead in the file. Sidenote: If at some point its decided to not use Zone Maps, you can just delete this one line but this would break my heart

Finally Testing

Basic Zone Map Contents Test.
Transaction Level GC Manager Test - for Immutability
Table Scan Tests for different predicates.

To be continued

Coverage increased (+0.1%) to 75.51% when pulling bc18f2a051f7762c53fa7bb10e0bffa2c85bde78 on rohit-cmu:master into bbcf739c0508550f55ab8242c9e83e579238bb67 on cmu-db:master.

Coverage increased (+0.1%) to 75.51% when pulling bc18f2a051f7762c53fa7bb10e0bffa2c85bde78 on rohit-cmu:master into bbcf739c0508550f55ab8242c9e83e579238bb67 on cmu-db:master.

Coverage increased (+0.2%) to 75.557% when pulling b127ad6617f3b024db39999bbd1951a45571eec9 on rohit-cmu:master into bbcf739c0508550f55ab8242c9e83e579238bb67 on cmu-db:master.

Coverage increased (+0.05%) to 75.431% when pulling d0602483d447239ac55a7ef37eb1d8da2ba8db18 on rohit-cmu:master into bbcf739c0508550f55ab8242c9e83e579238bb67 on cmu-db:master.

Coverage increased (+0.2%) to 75.565% when pulling 0b7c047addd1b4f7b3fccf7a5ced22b0cb450cc2 on rohit-cmu:master into bbcf739c0508550f55ab8242c9e83e579238bb67 on cmu-db:master.

Coverage increased (+0.06%) to 75.438% when pulling 0aea58d6cc316f5224cf7f711903411eef2d1047 on rohit-cmu:master into bbcf739c0508550f55ab8242c9e83e579238bb67 on cmu-db:master.

Coverage increased (+0.4%) to 75.74% when pulling 51794655ad7e1aa7ec12948871909bab7f8f5e0f on rohit-cmu:master into bbcf739c0508550f55ab8242c9e83e579238bb67 on cmu-db:master.

Coverage increased (+0.3%) to 75.724% when pulling 93f7edbcc3dbd7bf084eb80ee482e93d814e4b2e on rohit-cmu:master into bbcf739c0508550f55ab8242c9e83e579238bb67 on cmu-db:master.

Coverage increased (+0.6%) to 76.026% when pulling 3133660d944694031f7ca0794ef6efc42b7b9299 on rohit-cmu:master into bbcf739c0508550f55ab8242c9e83e579238bb67 on cmu-db:master.

Coverage increased (+0.2%) to 76.023% when pulling b28d26252785ec39c6c0d8217aef2da4fdbf736f on rohit-cmu:master into ffeb0819fc032d2444bd933563cf4ebbeb138ba1 on cmu-db:master.

Coverage increased (+0.2%) to 76.095% when pulling d017fbd50369cd8b1a3a7b4f0bb474c60b0d1914 on rohit-cmu:master into ffeb0819fc032d2444bd933563cf4ebbeb138ba1 on cmu-db:master.

Hi @apavlo My PR is ready with everything. Post getting my PR Ready I was trying to find out the performance bottleneck.  I was trying to find majorly whats decreasing our gains as compared to the earlier approach of not storing Zone Maps in Catalog. The major bottleneck is:
Using the index lookup as opposed to the O(1) benefit we had earlier. We now have 4 keys to look over the index.

database_id
table_id
tile_group_id
column_id
This becomes worse because since we don't have array types now, I make a trip to the catalog for every column to get the zone map. To use the Catalog Index scans I need to convert my keys into a std::vectortype::Value from the 4 integer values I get. These mallocs each time are additionally hurting my performance. cc @pmenon

Coverage increased (+0.2%) to 76.107% when pulling 41782c2fb5a6eb0e3dc5e08d0fe7dc8c8908b27a on rohit-cmu:master into b9f1e4339746fc3caca9907b364af30e21ea311a on cmu-db:master.

Let me take a look at this too.

@pmenon I have changed things according to your suggestions. :)

@rohit-cmu We should merge this next. I think you need to rebase first.

Coverage increased (+0.2%) to 75.779% when pulling 109af6e0a543da64892e89ea8d30627901b64b8e on rohit-cmu:master into 4e18d217347c2087a62b8a44ddc93762213dff20 on cmu-db:master.

@apavlo Branch is rebased,. There are no conflicts and we have approval from @pmenon and @tcm-marcel . We can merge once build passes.

Coverage increased (+0.2%) to 75.776% when pulling 68cffbdf33c11f0e98885e6ad3403e8815d32fc2 on rohit-cmu:master into 4e18d217347c2087a62b8a44ddc93762213dff20 on cmu-db:master.

Coverage increased (+0.2%) to 75.779% when pulling 68cffbdf33c11f0e98885e6ad3403e8815d32fc2 on rohit-cmu:master into 4e18d217347c2087a62b8a44ddc93762213dff20 on cmu-db:master.

Coverage increased (+0.2%) to 75.772% when pulling 68cffbdf33c11f0e98885e6ad3403e8815d32fc2 on rohit-cmu:master into 4e18d217347c2087a62b8a44ddc93762213dff20 on cmu-db:master.


PHP Buildpack starting 1.2.0 is not compatible with api 0.7

buildpack.toml of the PHP Buildpack is referencing api 0.7 but two underlying buildpacks (httpd and nginx) are referencing api 0.8, thus the PHP Buildpack cannot run on a platform supporting only api 0.7.
Expected Behavior
buildpack.toml should reference an api version consistent with the platform which is required to run it.
Current Behavior
PHP buildpack starting 1.2.0 cannot run on a platform limited to api 0.7 even if its buildpack.toml is referencing api 0.7
Possible Solution
Update buildpack.toml to api 0.8
Steps to Reproduce
Try to build an image with PHP Buildpack 1.2.0 or 1.3.0 on a platform not supporting api 0.8. In my case it is Tanzu Build Service 1.5.2 which is shipped with kpack 0.5.4
Motivations
I'm repackaging the PHP Buildpack to add Oracle support. I was relying on the buildpack.toml to assure api compatibility with the platform whenever there is a new release of the buildpack on Github.

@cxhrouet Thank you for letting us know about this. The HTTPD and Nginx buildpacks have been rolled back to API 0.7 and released, so the latest PHP buildpack (v1.4.0) should contain these versions. Can you test it out and let me know if your issue is resolved?

Closing this out but please feel free to reopen if this issue is still occurring for you with new buildpack versions.


[RI-263] Deploy ELK in MNAIO

This enables the ELK stack along with OS Profiler and UWSGI stats in the
RPC-O MNAIO gate jobs.
Issue: RI-263
Issue: RI-263

Thank you for submitting a pull request to this project!
Once all check jobs have passed and the pull request has received a
sufficient number of reviews, the repository's gate jobs can be triggered by
adding a comment of :shipit: to this pull request.
When the gate jobs have completed successfully, this pull request will get
merged automatically.

recheck_container_bashate_tox-test


Use chain in breakout example

Objective

We should encourage of the simpler to reason about chain.

Solution

Use it in the breakout example

Changelog

Switch breakout to use chain instead of before and after

I'm not sure if this example needs the comments but the change is definitely worth doing either way

I’m new to Bevy and the comments in examples help so I would be for it.

My point was more that these things should be taught somewhere else like the ecs_guide example. We can't teach the concept of .chain() or every other bevy feature in every example that uses it.

My point was more that these things should be taught somewhere else like the ecs_guide example. We can't teach the concept of .chain() or every other bevy feature in every example that uses it.

In fact (as you probably already knew) that example already talks about chain so seems unnecessary for this PR then doesn’t it. Thanks for entertaining my comment.


Send websocket text frame

How do I send not binary data but text data over the websocket, similar to the original library?
When I send messages through curl_cffi in binary formattai I get the error "Invalid frame type", but when I send through the original  library there is no such error

What do you mean by original library? Can you please post you code here?

I mean "websocket" library (ws = websocket.WebSocketApp(url, on_message=self.on_message})
In a function "on_message" when I get a message, I respond to it ws.send('some text') And everything works fine, I get the correct response.
But when I connect to the websocket via "curl_cffi" and respond with ws.send('some text'). I get an error that the message must be in binary format. I convert to binary, the code works fine, but the server tells me that I am sending the wrong frame

I fix that, my bad


Better gyro support for mixed and multidevice modes, fixes Steam Input crash

Think I’m gonna slice out the value summing forand instead add some “last gamepad used” logic to MIXED source mode.

Why does input_motion_data_get() need a gamepad argument when input_gyro_params_set() allows the developer to set which gamepad is preferred?

Mm yeah that's unnecessary, thanks will edit


Template for Survey Introduction

Dear All,
I have created the template for survey introduction. Please comment and add as necessary.
Brief note on the table. I brought it down to only year and sample sizes (leave as ** -- ** if there is no number of HHs, as in IDN) since this is the basic info that we ought to always have. Other details may be described elsewhere, condensed to the minimum so this also does not take too long. But happy to be persuaded (^_^).

Based on conversations with you guys I have updated the document to:

Have questions marks in all questions, and
Expand a bit the "Other noteworthy aspects" part to better convey how this ought to be structure.

Still happy to get more comments, kindly requested by COB tomorrow 8th of September so we may implement it.

Is this an appropriate place to include a short, "external resources" section that might link to any relevant National Stats Office, Publicly-available codebooks/documentation, etc?
Alternatively, this information could also be compiled centrally elsewhere.

No further comments from my side.

Is this an appropriate place to include a short, "external resources" section that might link to any relevant National Stats Office, Publicly-available codebooks/documentation, etc?
Alternatively, this information could also be compiled centrally elsewhere.

I would personally have included that in the section on "Where can the data be found?" as I see raw data, without any external resources, as you say, not really useful. In the case of India this was easy because the link to the site where the data is released has a tab on "Documentation" where you can find everything. Less clearly but similarly in Mexico, where Documentation and Microdata are two tabs on the same landing page (image at the end).
I guess it is a question of how much we want to pre-chew info for people, but I would just include the main links here. Other information for example for ISCO and ISIC correspondence tables can be added in the particular documents that cover this.
Would that work for you?

Sure, that works!

Hi everyone, I've come across an issue and a solution to it:
When creating links to other documentation files, you cannot use the permalink or any other web address. You must use this specific type of relative linking that I refer to here and in the updated template. Also copying here because it's actually quite simple. The files must be in the same directory (but we already agreed this would be the case) and, importantly, you have to write the link to the other documents like this
[name to show in link](exact_file_name_without_any_slashes.md)
// example
[GLD code](GLD_Harmonization_Template.do)

The reason is because when you copy the permalink or web address of the other markdown files, the link will be valid only as long as those files stay on that branch. But as soon as you merge or move that branch, or even edit the file again, the link will not work. This post explains what happens behind the scenes: basically github will always know to go to the current branch.

@buscandoaverroes Thanks! I have updated the document also for the other file. You can use the ../ operand to go up a folder.
In the case of our template it is under gld/Support/Templates (of its branch) and the file connected to is gld/Support/Country Survey Details/MEX/ENOE/Correspondence_NAICS_ISIC.md so we need to go one up from gld/Support/Templates to gld/Support and then put the rest (Country Survey Details/MEX/ENOE/Correspondence_NAICS_ISIC.md).
The operand ../ does this moving up so the link is then ../Country%20Survey%20Details/MEX/ENOE/Correspondence_NAICS_ISIC.md (Note that %20 is to write out the spaces between words).

Oh, great, this is good to know. Thanks @gronert-m

@alexandraqn @buscandoaverroes  @Junying-T  Thanks for all the comments! I close this issue and see the template as operational. If any changes need to be made, please raise a new issue or create a develop branch to make changes to the template.

@alexandraqn @buscandoaverroes  @Junying-T
This is just to update you that I amended one of the template section titles from

What is the significance level?

to

What is the geographic significance level?

thanks, I updated PHL

Done.

I have realised this has been here for some time and is no longer an issue. Thus I move to close it. Please let me know if you think I should reopen it. Thanks!


Obsolete document references.

Please remove obsolete document references mentioned in the wiki pages here:
https://github.com/google/closure-compiler/wiki/Compiler-Assumptions

I've updated the links.


MsgModify in x/token,collection should also accept "uri"

Summary

MsgModify accepts base_img_uri or img_uri for backward-compatibility. MsgModify should also accept uri, because the corresponding proto has been updated into uri.
Problem Definition

The current implementation may confuse new users, so we should add a key uri.
Proposal

Make MsgModify to accept a key uri for its changes.
Users must use either of uri or old key. If they use both of the key in the same time, the validation logic must emit an error.

For Admin Use

[x] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

If both img_uri and uriare exited in the same Msg, is it confused?


Prototype language API

A prototype for a possible API for target languages.

Opening a new pull based on main.


Fixed. rake new_cop doesn't work since rubocop v1.22.0

Arguments of RuboCop::Cop::Generator#initialize are changed since rubocop v1.22.0.
c.f.

https://github.com/rubocop/rubocop/pull/10109
https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md#1220-2021-09-29

Therefore, Rakefile generated by this gem was broken, so I fixed this.
Backtrace
$ bundle exec rake new_cop[Foo/Bar]
rake aborted!
ArgumentError: wrong number of arguments (given 2, expected 1)
/path/to/my-cop/vendor/bundle/ruby/3.1.0/gems/rubocop-1.24.1/lib/rubocop/cop/generator.rb:114:in `initialize'
/path/to/my-cop/Rakefile:30:in `new'
/path/to/my-cop/Rakefile:30:in `block in <top (required)>'
/path/to/my-cop/vendor/bundle/ruby/3.1.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
/Users/sue445/.rbenv/versions/3.1.0/bin/bundle:23:in `load'
/Users/sue445/.rbenv/versions/3.1.0/bin/bundle:23:in `<main>'
Tasks: TOP => new_cop
(See full trace by running task with --trace)

Version
$ bundle exec rubocop -V
1.24.1 (using Parser <IP_ADDRESS>, rubocop-ast 1.15.1, running on ruby 3.1.0 x86_64-darwin21)
  - rubocop-performance 1.13.1

This looks good to me. Can you squash your commits into one?

squashed and pushed

Thanks!

v0.4.0 has been released!
https://rubygems.org/gems/rubocop-extension-generator/versions/0.4.0


Make Jira issue match Github PR title so we don't end up with "Review…

… submitted PR" as the PR title for all our Github issues.

+1


Paragraph on "We’re transparent about our operational processes"

@heinritzkat and @cedegi came up with an excellent proposal:
We share our internal processes for the sake of transparency. We firmly believe that transparency leads to better and more reliable processes. We are convinced that publishing well-documented operational processes offers a great opportunity to gather feedback and inspiration from the wide public.

Likewise, we are convinced that us sharing our operational experiences can be of inspiration and benefit for others. In today's business environment, most companies are facing the same challenges. By sharing knowledge the same way the open source community shares software, a common knowledge base can become a reality, allowing everybody to benefit.

 We consider the disclosure of internal processes as an essential step towards this direction.

I'll see with @heinritzkat to make a PR.

Fixed by #9


Alignment of elements in main nav

Page: Home
Resolution: Full HD
Expectation
The list of links in the main nav (left sidebar) should be left-aligned with the logo.
Screenshots

Fixed


Remove method from provider reconciler interface

Description of changes:
This method won't be needed and not used anywhere.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

 How is CNI reconciled now?

 How is CNI reconciled now?

There aren't, there are no consumers for this method from the interface. It just happens that all the current implementations of this interface also implement the ReconcileCNI method, but that's not required.
CNI reconciliation is supposed to be part of the responsibilities of the Reconcile implementation of this interface. For reference, the actual reconciliation logic is in the CNIReconciler and the existing implementations of ProviderClusterReconciler get the CNIReconciler injected as a dependency.

/approve

/test eks-anywhere-presubmit


Booting up developer VM clogs console with "Operation not permitted" messages

Starting the development VM with NFS=1 contrib/vagrant/start.sh results in a bunch of error messages output to console:
==> cilium-master: chown: changing ownership of '/home/vagrant/go/src/github.com/cilium/cilium/vendor/k8s.io/kubernetes/vendor/github.com/docker/docker/client/checkpoint_list.go': Operation not permitted
==> cilium-master: chown: changing ownership of '/home/vagrant/go/src/github.com/cilium/cilium/vendor/k8s.io/kubernetes/vendor/github.com/docker/docker/client/client.go': Operation not permitted
==> cilium-master: chown: changing ownership of '/home/vagrant/go/src/github.com/cilium/cilium/vendor/k8s.io/kubernetes/vendor/github.com/docker/docker/client/client_unix.go': Operation not permitted
==> cilium-master: chown: changing ownership of '/home/vagrant/go/src/github.com/cilium/cilium/vendor/k8s.io/kubernetes/vendor/github.com/docker/docker/client/client_windows.go': Operation not permitted
==> cilium-master: chown: changing ownership of '/home/vagrant/go/src/github.com/cilium/cilium/vendor/k8s.io/kubernetes/vendor/github.com/docker/docker/client/config_create.go': Operation not permitted
==> cilium-master: chown: changing ownership of '/home/vagrant/go/src/github.com/cilium/cilium/vendor/k8s.io/kubernetes/vendor/github.com/docker/docker/client/config_inspect.go': Operation not permitted
==> cilium-master: chown: changing ownership of '/home/vagrant/go/src/github.com/cilium/cilium/vendor/k8s.io/kubernetes/vendor/github.com/docker/docker/client/config_list.go': Operation not permitted

These don't appear to be harmful, as I am able to compile Cilium and run it fine. This output could be confusing to new developers and users who think something is wrong with their setup.

Known vagrant bug https://github.com/hashicorp/vagrant/issues/8061


Modeling a quadcopter with Pinocchio

Hi,
I was wondering what the best way is to model a drone (e.g. quadcopter) with Pinocchio. The only way I can think of is to use a free-flyer joint, which is fine for representing the state, but doesn't capture the control inputs to the system, which would be four 1d forces applied by the propellers. Clearly I could easily compute manually the resulting wrench (which is the control input expected with a free-flyer joint), but it means I should customize my code for handling this specific system, which is a pity because I have a generic code with which I can usually handle all robots just by changing the urdf file.
Any suggestion?

We should add soon the notion of actuation models which should encompass your case, but also the case of free-floating systems.
Currently, Crocoddyl implements the notion of actuators, but definitely, this should go inside Pinocchio.

Yes, we have implemented a quadrotor actuation model.
You might want to inspect the following code: https://github.com/loco-3d/crocoddyl/blob/master/include/crocoddyl/multibody/actuations/multicopter-base.hpp

I will close this issue. @andreadelprete Feel free to reopen it for further discussions

Related to #440.


bug: run lake update and lean-action gets an error

This workflow raise an error: https://github.com/lean-ja/lean-by-example/actions/runs/9530357340/workflow
The workflow content is simple: Just install elan, run lake update and then lean-action.
jobs:
  build:
    runs-on: ubuntu-latest
    steps:
      - name: checkout
        uses: actions/checkout@v4

      # - name: update lean-toolchain
      #   run: |
      #     LATEST_LEAN=$(gh release list --repo leanprover/lean4 --limit 1 | awk '{print $1}')
      #     echo "The latest release/prerelase is: $LATEST_LEAN"
      #     echo "leanprover/lean4:$LATEST_LEAN" > lean-toolchain
      #   env:
      #     GH_TOKEN: ${{ github.token }}
      #   shell: bash

      - name: Install elan
        run: |
          curl https://raw.githubusercontent.com/leanprover/elan/master/elan-init.sh -sSf | sh -s -- -y
          echo "$HOME/.elan/bin" >> $GITHUB_PATH
        shell: bash

      - name: Update dependencies of ${{ github.repository }}
        run: lake update
        shell: bash

      - name: build lean
        uses: leanprover/lean-action@main
        with:
          test: false

You can see error details: https://github.com/lean-ja/lean-by-example/actions/runs/9530357340/job/26270125659
error message:
▼ Run : Get Mathlib Cache
  : Get Mathlib Cache
  echo "::group::Mathlib Cache"
  lake exe cache get
  echo "::endgroup::"
  echo
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
▼ Mathlib Cache
  info: mdgen: updating repository '././.lake/packages/mdgen' to revision '6a6a412465e82572f6e30385592eac52ab055c83'
  info: mathlib: updating repository '././.lake/packages/mathlib' to revision '03092720f68254315c95a5bf2[49](https://github.com/lean-ja/tactic-cheatsheet/actions/runs/9530357340/job/26270125659#step:5:55)c5f2cdef717d6'
  error: external command 'git' exited with code 1
  Error: Process completed with exit code 1.

I have no idea what caused it.

Locally, lake exe cache get seems to be working fine. The error only occurs on GitHub Action.

this workflow doesn't raise an error: https://github.com/lean-ja/tactic-cheatsheet/actions/runs/9530454158/workflow
so this is maybe caused by a bug of lean-action.

This could definitely be an issue with lean-action.
Note, currently the functional tests for lean-action use Lean 4.8.0, so it is possible for issues with new releases to slip through. However, we definitely want to support the latest release candidates of Lean as much as possible. I created #63 to allow for testing on any version of Lean.
Have you tried running this workflow with the lean-action@v1-beta instead of lean-action@main?

v1-beta also raise an error.
workflow file: https://github.com/lean-ja/tactic-cheatsheet/actions/runs/9535628209/workflow
error detail: https://github.com/lean-ja/tactic-cheatsheet/actions/runs/9535628209/job/26281586503
error message is the same.

I wonder getting cache causes this error...

I have found that this error probably occurs in the following situation:

mathlib relies on an out-of-date Lean such as v4.8.0
there is still a .lake cache
trying to bring the Lean version up to date

This error also occurs locally. The local solution is to delete the .lake directory.

If the issue is the GitHub cache of the .lake directory, we could try using the  use-github-cache: false input of lean-action. This input hasn't been included in a release yet, but it is available in the main branch.

See https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/ltar.20error.20aften.20lean.234402/near/444803915

@digama0 Thank you! so I think this issue is also temporary problem. Please ignore this issue until it occurs again.

Is this really a "one time issue"? I have got an error in https://github.com/Seasawher/mathlib4-tactics when update Mathlib from v4.9.0-rc2 to v4.9.0-rc2.
（It is not lean-action but lean-update that is used in mathlib4-tactics, but I have confirmed that it is the github-cache of lean-action that is the cause...!）

Cache modification https://github.com/leanprover/lean-action/issues/64#issuecomment-2176999055 would solve this issue?

This problem also occurred when updating from v4.9.0-rc2 to v4.9.0-rc3.

I created #70 to implement the change to the caching keys to try and address this issue.
@Seasawher does using use-github-cache: false still work as a temporary fix? I know this is not ideal. I am asking to make sure I still understand the problem.

does using use-github-cache: false still work as a temporary fix?

Yes. if I don't use cache, I don't see same error. This issue is caused by remaining .lake directory. On local, the way to fix this issue is removing .lake directory.

by the way, this lake's error message is not easy to understand
error: external command 'git' exited with code 1

actually the reason of issue is .lake, not git.

I think with the improvements to the caching keys in #71 we shouldn't run into this again. @Seasawher do you agree?

Yes. I think this issue is resolved.

Sounds good. Thank you for raising this!


Docker Container Image Outdated

The adapter container image is outdated:
https://hub.docker.com/r/timescale/prometheus-postgresql-adapter

Hi,
I also agree with @r0b2g1t. This version still does not contain the fix for plain text password in the logs.
Please, update!


Add Result.sequenceAsync

I propose adding Result.sequenceAsync (or is it Async.sequenceResult? I think it's the former). An example implementation is:
let sequenceAsync (resAsnc: Result<Async<'a>, 'b>) : Async<Result<'a, 'b>> =
    async {
      match resAsnc with
      | Ok asnc ->
          let! x = asnc
          return Ok x
      | Error err -> return Error err
    }

I have had a need for this when using the Result.apply or Result.map operators (or the corresponding Validation operators, which I am using) with an Async-returning function. For example, I have the following code:
let! webhook =
  Workflows.createWebhook  // createWebhook is async
  <!> parseRequiredAttr a.callbackUrl WebhookCallbackUrl.TryCreate
  <*> parseOptOptAttr a.authorizationHeader WebhookAuthorizationHeader.TryCreate
  |> Result.sequenceAsync

The implementation details aren't important. The core concept is that I have an async function createWebhook that I apply to Result-wrapped arguments using <!> and <*>. Without Result.sequenceAsync, I end up with Result<Async<Webhook, Error>> whereas I'd like Async<Result<Webhook, Error>>.
This is a situation users will end up with every time they have an Async-returning function that they use with the apply/map operators. It seems general/common/simple enough that it's worth adding to the library.

Usually when I end up with that situation I haven't done something right. The functions all need to align to the expected output type which is Async<Result<Webhook, Error>>.
So for instance I would create some helpers do:
//looks like were missing some of these helper functions like AsyncResult.ofAsync or AsyncResult.ofResult
module AsyncResult=
  let ofAsync (a : Async<_>) = a |> Async.map Result.Ok
  let ofResult (r : Result<_,_>) = r |> Async.singleton

let createWebhook = Workflows.createWebhook  |> AsyncResult.ofAsync
let parseRequiredAttr x y = parseRequiredAttr x y |> AsyncResult.ofResult
let parseOptOptAttr x y = parseOptOptAttr x y |> AsyncResult.ofResult

Then in the implementation use the AsyncResult operators to do:
let! webhook =
  createWebhook
  <!> parseRequiredAttr a.callbackUrl WebhookCallbackUrl.TryCreate
  <*> parseOptOptAttr a.authorizationHeader WebhookAuthorizationHeader.TryCreate

The reason I'm loosely against this is because I've seen people just trying to make types fit without actually understanding what is going on.  That said I could be totally wrong about this.

The operators I'm using are the Validation operators, and they are only available for Result.
Besides, is there a significant conceptual difference between using wrappers to make all the types match up up front (or as you go along and call them), versus transforming at the end?

The operators I'm using are the Validation operators, and they are only available for Result.

Looks like we should also add those for Async/Task/JobResult variants too :)

The latter seems to be less work/verbose.

Yeah, that is definitely a downside to the alternative I have given.

Looks like we should also add those for Async/Task/JobResult variants too :)

Would be great! In my specific case, I'd still want Result.sequenceAsync though, both due to being less boilerplate, and because it's confusing to have to switch back and forth between different operators.

Make a PR :)

@cmeeren The latest version 1.2.2 has your changes. Can you verify and close this issue?

It's there, thanks! 👍


Create MockResponseBody

We'd previously only ever used Buffer to model the type of the MockResponse body. This has proven inadequate, particularly for features like duplex responses.
Most of the complexity in this PR is changing how throttling and disconnect-during-body work when we don't necessarily have a Buffer for the response body.
This is a first step, more capability to follow.

With OkHttp 5.x we’ve got a new public API package, mockwebserver3, which presents a rare opportunity to make breaking changes. I’m making 'em. I hope we don’t need that much more investment in the future; just removing some bad things. But I’m open to ideas!


Add an option to exclude PDF attachment in email

By default, FOIAmail adds a PDF attachment of the request text as a PDF named records-request.pdf (Line 281 in compose.py) It would be good to turn off this option in the congif.yaml file, and also to be able to rename the PDF if we choose to include it.

Markdown is used only for preparing the PDF version of your request. So essentially, using markdown is only for those wanting to attach a PDF of their request. If you want to just send a basic message without attachments, right now your only option is to use the docx message.

That's helpful to know, thank you. I will suggest an addition of this information to the docs with a PR.


Fix wrong example for DeviceServiceEnvVar method

Fixing wrong example for models.environment_variables.device_service_environment_variable.get_all_by_application(). Current example is for device env var not device service env var.
Change-type: patch
Signed-off-by: Trong Nghia Nguyen<EMAIL_ADDRESS>

@balena-ci I self-certify!


Update deployment doc

Modify the deployment doc according to the latest scow-deployment

Codecov Report
Base: 70.29% // Head: 70.29% // No change to project coverage :thumbsup:

Coverage data is based on head (07a5abd) compared to base (fb00738).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   70.29%   70.29%
=======================================
  Files          93       93
  Lines        2380     2380
  Branches      304      304
=======================================
  Hits         1673     1673
  Misses        660      660
  Partials       47       47

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Automat ohdc

@maximusunc—if you pull main into your forked branch and run make test these will be regenerated without the conflicts.
These files are a bit of a consequence of LinkML build process. We will likely need to move the artifacts to release-artifacts instead of stored in the repo itself.


Add website to NDKUserProfile

Fixes #5

@pablof7z – related to this is #42 – if you think @michaelhall923 suggestion there I can add it into this PR as well.

Yes, I think #42 makes sense. Do add it to this PR and I'll cut the release out asap

@pablof7z this is ready for a review.
@michaelhall923 – I'd love you to have a look here as well, in case you spot anything.

Fixes #42


Any chance of getting the mem management parts of this as a dynamic lib?

I'm currently working on another project (in C#, so just copying the code doesn't really work out) that requires hooking into Dolphin and accessing GameCube memory during emulation.
Figuring out where the GC memory space starts is the hard part, but this program seems to be capable of doing that. So I was wondering if it'd be possible to get those parts as a dynamic library so that other programs can make use of the functionality? Perhaps it'd be useful to have a function in the library that you can pass a process handle to and get the memory address where GC memory starts returned (or 0 if emulation has not started).
Having this in a dynamic lib would allow me to use P/Invoke to call the function from C#, but of course would make things easier for people potentially working on other projects (Whether they be C# or C++) with similar requirements.
Obviously this is a bit of a big ask for something so specific, but I figured I'd ask anyway before attempting it (and no doubt botching it) myself. Thanks.

sorry to take so long to answer, but the basic idea is not necessarly planning it.
The reason is the code to do it is....rather simple in fact, it's imo TOO simple. The issue is it's limited: it only gives you access to the main memory like 75% of the games. This was the only way I knew to do IPC at the time so i went for it and for a lot of use case, it does a pretty good job, but honestly, I need to redo the IPC entirely.
However, I might not even get to do it because what I plan to do is to ATTEMPT (no idea if I will succeed) to merge the feature of this program into Dolphin. About a month ago, I had a chat with some dolphin devs and I was surprised to hear that they think it can be possible without impacting the perf too much (it would be an opt in if it does though which I am fine with). The plan is to start the efforts next summer.
If this succeed, the sky would be the limit: you could be able to check EVERY ram region for potentially every game, there might even be potential for full MMU games to work, but this is going to require a lot of work. It would also guarantee much more stability and have more features potential.
Unfortunately, due to being busy with reversing project, I do not plan to work on this until next summer.
So this is why I say it's not currently planned as I might redo the entire IPC or I don't and you won't need this because it would be inside dolphin anyway.


Suppress CMake external project 'update' phase

Bug fix
Fixed bug
When the 'install' target is invoked during the Debian and RPM package builds, the external project target is re-evaluated to determine if it is stale. By default, CMake performs an 'update' command on the source repository, which invalidates the target and causes the external project to be re-built.
This is a problem because when the 'install' target is invoked by the Debian/RPM build, the 'DESTDIR' variable is passed, which makes its way into the external project as well. This interferes with the sub-project's installation into the build directory, and results in unexpected files getting installed into the platform package staging directory.
This is a problem for both Debian and RPM builds, but it is only a fatal error in RPM builds at the moment.
Fix applied
Using a ref which can never change and suppressing the 'update' phase of the external project is enough to ensure that the external project is not deemed 'stale' during the install target invocation, and avoids the problem.

LGTM


Add Vegeta link to load test third-party tools list.

Fixed by https://github.com/aspnet/AspNetCore.Docs/pull/13220


Using the router does not trigger :target pseudo class

Reproduction
https://stackblitz.com/edit/vue-router-2076
Steps to reproduce the bug
The CartAside component has CSS styles based on the :target pseudoclass. It is triggered by the links on the page.

Click on "Open Cart via router link"
See that the URL changes but the overlay does not open
Click on Open Cart via a
See that the URL stays (if you'd go from / it'd change correctly too) and the drawer opened

Same with the close links after the overlay.
Expected behavior
When using the RouterLink with an id (e.g. #cart), the :target pseudoclass styles should be triggered
Actual behavior
The :target styles are ignored.
Additional information
As a workaround, using <a> tags works fine 👍🏻
Related issue: https://github.com/nuxt/nuxt/issues/24415

It's apparently okay, from vendors' perspective, for this not to work with pushState(). You can find some workarounds too at https://github.com/whatwg/html/issues/639

Thanks for the quick insight 🙏🏻


Migrate existing registry implementations to TypeRegistry

Description
This issue is an umbrella issue to list up the existing registry implementations that need to be migrated to TypeRegistry in explainaboard/serialization/registry.py.
Actions

[x] #420
[ ] #421
[ ] #422
[ ] #423

Moving to @odashi.


chore(main): release 2.5.0

:robot: I have created a release beep boop
2.5.0 (2024-07-30)
Features

40: add precision_halves customization (#248) (8f5ec79)
b8: first implementation (#225) (259e4f2)

Bug Fixes

break the loop when connected (#244) (536f975)
ac: correct attributes based on msg type (#251) (fada9bc)
cloud: fix email obfuscation (#245) (ad9f278)

This PR was generated with Release Please. See documentation.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 35.34%. Comparing base (ad9f278) to head (c4a2e23).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   35.34%   35.34%
=======================================
  Files          81       81
  Lines        7191     7191
=======================================
  Hits         2542     2542
  Misses       4649     4649

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:robot: Created releases:

v2.5.0
:sunflower:


django-pyodbc bulk_create is broken

I posted this on stackoverflow: http://stackoverflow.com/questions/41025790/django-pyodbc-bulk-create-is-broken
When calling bulk_create() using django-pyodbc backend, an insert statement is run for each object in the batch. The behavior should be to run a single insert statement per batch.
Is this a bug, or is there a way to alter this behavior?
Versions:
django==1.7
pyodbc==3.0.10
django-pyodbc==1.0.1
FreeTDS v1.00.21
unixODBC v2.3.4

Got an S.S.C.C.E http://sscce.org/?
On Wed, Dec 7, 2016 at 11:31 AM, Adam Ergener<EMAIL_ADDRESS>wrote:

I posted this on stackoverflow: http://stackoverflow.com/
questions/41025790/django-pyodbc-bulk-create-is-broken
When calling bulk_create() using django-pyodbc backend, an insert
statement is run for each object in the batch. The behavior should be to
run a single insert statement per batch.
Is this a bug, or is there a way to alter this behavior?
Versions:
django==1.7
pyodbc==3.0.10
django-pyodbc==1.0.1
FreeTDS v1.00.21
unixODBC v2.3.4
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lionheart/django-pyodbc/issues/132, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AD_flA5V3RxGB9ZpxnbIXTeH8A4A3tMgks5rFwmqgaJpZM4LHAUj
.

Working on one right now that I'll port here. But basically anytime a model calls bulk_create I see that behavior.

With the following model:
from django.db import models

class Thing(models.Model):
    prop = models.CharField(max_length=64)

Execute the following below from the django shell:
>>> from app.models import *
>>> thing1 = Thing(prop='hello')
>>> thing2 = Thing(prop='world')
>>> things = [thing1, thing2]
>>> Thing.objects.bulk_create(things)
[<Thing: Thing object>, <Thing: Thing object>]

If you enable logging, you'll see that a SQL INSERT statement is executed for each item in the bulk_create batch.

I also have an example setup here https://github.com/aergener/django-mssql-setup-example
It uses docker so as long as you have Docker installed, you'll be able to launch the exact same setup. There's also a vagrantfile there if you have vagrant and want it to provision a machine for you with Docker.
Currently that setup is using django-pyodbc-azure, but if you update the database settings & the requirements.txt to the following you should see what I am seeing.
requirements.txt
django==1.7
pyodbc==3.0.10
django-pyodbc==1.0.1


Enable returning body directly

Fixes #13.

Coverage remained the same at 100.0% when pulling 12193714ceffb318e10ae380fb0376f3887becd1 on kevva:return-body into 107b58e6c1ed87b93b58cd3004a0a2d5bc9bddfc on lukechilds:master.

Coverage remained the same at 100.0% when pulling 12193714ceffb318e10ae380fb0376f3887becd1 on kevva:return-body into 107b58e6c1ed87b93b58cd3004a0a2d5bc9bddfc on lukechilds:master.

Thanks, beautifully implemented 👌


Catch internal error in promise.

Hi,
I get this error in when calling the promise to detect face + landmarks. Is there any possibility to catch it? Im trying to get the error through then/catch but not reaching this code.
Fragment shader compilation failed.
and
Uncaught (in promise) Error: Failed to compile fragment shader.

I think being able to catch this error would require some solution similar to what is described here: https://github.com/tensorflow/tfjs/issues/756.
Did you try to wrap the failing code into a simple try/catch? Does it not work?

Yes, I tried, but there is not error Throwed just printed and continue, so it keeps giving errors... :(


Opening one attached table with SAS doesn't display the notification after renaming the original table

Storage Explorer Version: 1.2.0
Platform/OS Version: Windows 10
Architecture: ia32
Build Number: 20180619.1
Commit: 3b2233d5
Regression From: Not a regression
Steps to Reproduce:

Go to Subscription -> Storage Accounts.
Attach one table with SAS -> Rename the original table after attaching successfully -> Try to open the attached table.
Check whether the notification displays or not.

Expected Experience:
The notification "the table does not exist" displays.

Actual Experience:
No notification doesn't display after opening the attached table.
More info:

This issue also reproduces for blob container and file share.
The notification displays well after opening the attached table more times.

Explain more about what happens. Does an editor open up successfully? What's the SAS in question?

Yes. The editor of attached table is opened successfully after renaming the original table. But no data dispalys on the table editor.
More info:
The notification will pop up after opening the attached table more times.
The attached SAS: https://apec.table.core.windows.net/amy?st=2018-06-25T10%3A28%3A42Z&se=2018-06-26T10%3A28%3A42Z&sp=ra&sv=2017-07-29&tn=amy&sig=2BggBk1h0Kl8AwgHBu6dX6Lp0ZIxRoQv1p0sy0M94vQ%3D

What's the time frame we're looking at? Do you open the editor within just seconds of the rename? What if you wait for about a minute?

Yes, I opened the attached table within just seconds of the rename.
This issue doesn't reproduce after waiting for about 2 minutes.

Then my guess is the platform just takes a minute or two to delete the old-name table. The SAS is trying to access a deleted table, and the error message is expected.


[HOLD][$250] Migrate TooltipRenderedOnPageBody.js to function component

Class Component Migration
Filenames

[ ] src/components/Tooltip/TooltipRenderedOnPageBody.js

type: React.PureComponent
has state values: true
has refs: true
has context: false
lifecycle methods: componentDidMount,componentDidUpdate

Task

We currently have some class components in our codebase that we would like to refactor to a function component.
Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
If you need additional guidance, please ask in #expensify-open-source
Test for any regressions and verify that there are no breaking changes

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Migrate TooltipRenderedOnPageBody.js to function component
What is the root cause of that problem?
No problem, refactor the class component into functional component
What changes do you think we should make in order to solve the problem?
Update https://github.com/Expensify/App/blob/main/src/components/Tooltip/TooltipRenderedOnPageBody.js
into functional component

I'd love to work on this.

I would like to work on this issue.

I can work on this issue.

This one got refactored somewhere 🤷♂


Feature request: Set output-format = "github" automatically when running in GitHub Actions

Would be nice to have annotations in GitHub Actions. This should probably be behind some configuration setting as it possibly overrides user configuration.

Meant to open this for ruff


Is this compatible with Guzzle 5.1, 5.2, 5.3?

If so can we get a composer.json update and a version bump? Anyone using guzzle-services which requires this seems to be stuck using Guzzle ~5.0

Yes.

~5.0 DOES NOT mean 5.x. Please read composer's docs.

~5.0 does NOT mean 5.0.x. Please read composer's docs.

You're right. Been debugging all day and brain fart on my part. Sorry to waste your time.


Estimated SSB

Hi Jerelle and Mackenzie,
I'm trying to figure out which object represents the estimated SSB that is used by the manager to set the catch limit according to the harvest control rule.
I'm pretty sure SSB is the "true" SSB.
I thought I was looking for SSBest
https://github.com/lkerr/groundfish-MSE/blob/bfba39b6fd244d2dd5e1bb92dac9ba9225f99b74/functions/datawrangling/get_fillRepArrays.R#L87
However, it has the wrong dimensions of output.  It is a 2D array of (replicates and years), instead of a 3D array (replicates, management, and years).
https://github.com/lkerr/groundfish-MSE/blob/bfba39b6fd244d2dd5e1bb92dac9ba9225f99b74/functions/datawrangling/get_containers.R#L8
https://github.com/lkerr/groundfish-MSE/blob/bfba39b6fd244d2dd5e1bb92dac9ba9225f99b74/functions/datawrangling/get_containers.R#L105
And I think it's saving the estimated SSB after every assessment.
I also saw SSBPROXY and SSBPROXYT, but I'm not really sure what either of these are.  Can you help me figure out which object to use?

The SSBPROXY is the SSB at Fmsy proxy (F40%). SSBPROXYT is the true (OM) metric. I don't think that is what you want. I will look into the SSBest container because it looks like it is saving the SSBest each year of the assessment for each year of the sim. It doesn't seem like it is set up to save for reps or mprocs? I'll dig in a little more.

@jerellejesse Thanks! Def not what I want.  Do you think this:
https://github.com/lkerr/groundfish-MSE/blob/bfba39b6fd244d2dd5e1bb92dac9ba9225f99b74/functions/datawrangling/get_containers.R#L174-L177
is part of the problem. I was expecting it to look like:
 SSBest = save_vector_ann,
``

Yes, I think that is the problem but I did some testing and it wasn't quickly fixed. I think it is because the assessment saves more info at each time step. At each sim year we save the SSB estimate for the number of years that are included in the assessment not just the terminal estimate. Maybe an easy fix but I haven't tried yet

That makes sense, I think I saw some code about Mohn's rho right next to it.
Honestly, this is lower priority.
I can look at the survey indices and see if they are all the same or different.  If the survey indices different across replictes in the same year, then I can infer that the estimated SSB is different, and that's what's causing the different F_fullAdvices.


Spreading tuple in decorator crash compiler

alias Params = ["application/json", "foo"];
model Foo {
  @encodedName(...Params)
  name: string;
}

Playground Link

This doesn't crash anymore and report parsing errors


Bug? BitBar 1.5.1 (and below) doesn't remember menu bar position (Bartender installed)

When resetting/refreshing the BitBar plugins, the BitBar instances reappear at the left end of the menulets in the menu bar. I don't know if this happens with all users or only those who (like me) have Bartender installed, but I've defined a specific position for BitBar in the menu bar with CMD-drag, and BitBar doesn't comply. I had noticed this behavior before, but since I'm currently only running semi-static scripts (update once a day), I didn't mind. Now, though, with v1.5.1 BitBar resets after wake from sleep, which means that every time my computer wakes, all BitBar instances move to the left, which is annoying. Other menulets do actually remember their user-defined position, or rather: Bartender assigns them the correct position, once they relaunch after quit. What could be the problem with BitBar? Is it maybe because BitBar doesn't actually quit, but only goes "invisible", when its instances are refreshed?

I think the 'moving' is caused by the tear-down and setup of new items. Ideally, it would reuse existing items, which wouldn't require new items to be added. This might go some way to fixing this problem.

Just found out that the command /usr/bin/killall SystemUIServer will reset the menu bar items to their correct location. So for the time being the workaround for me will be adding that line to my wake-up script.

I'm having the same issue here with BitBar v1.9.2. But even without Bartender active the behavior is the same.
Unfortunately, killing SystemUIServer isn't working for me. I need to manually reposition the item on menubar.

@gingerbeardman  An updates regarding this issue? Its really annoying :worried:

The project is seeking maintainers. If anybody is interested, please reach out to me.

Any news here?

Any news here? @gingerbeardman?

On macOS 10.15.7 the trick with renaming does not work as expected. The order of the items in the top bar appears to be unrelated to the file name, but rather determined by inode number (right-most being the lowest inode). Every time I've refreshed the bitbar, scripts are displayed in inode order.
The inconsistent results (working for some people but not for others) can be explained by people using either symlinks or script files directly. When renaming a regular file, it does not get a new inode number. When renaming a symlink, a new inode is created.
A consistent way to set the order (tested with scripts that all have the same refresh rate) is to make symlinks to the script files in the correct order. Rightmost item symlink should be created first. If you prefer to use script files directly without linking, then use cp to copy each file in the correct order. Use ls -1i | sort -n to check whether the order is correct.


Create defender-for-devops.yml

Microsoft

Can you give a bit more insight into why?

Closing as OP hasn't given more info


Is the MetaMathQA dataset suitable for pre-training?

Hi，thank you for your excellent work!
I would like to know if augmented datasets like MetaMathQA are suitable for pre-training?

Hi，Jingyi, Many thanks for your kind words.
I think MetaMathQA is suitable for pre-training. In fact, OpenChat-3.5 utilized our data and indeed achieved impressive performance. https://huggingface.co/openchat/openchat_3.5
However, one thing I believe needs attention is that you should publicly disclose the type of data you used, such as MetaMathQA. This way, others can assess whether your model has encountered GSM8K-like data.


Maintenance week updates

What does this PR do?
Update app according to DataEng Application Maintenance. Here are some changes worth noting:

Update application to Python 3.12

All unit tests, including integration tests are passing 🎉

Address minimal linting errors

Update syntax in pyproject.toml
Address ruff rule violation for E501 in conftest.py

Clean up Makefile
Update README (Development and Environment Variables section)

How can a reviewer manually see the effects of these changes?

Run make test and verify all unit tests are passing.
Run integration tests and verify all integration tests are passing.

Includes new or updated dependencies?
YES
Developer

[X] All new ENV is documented in README
[X] Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

[ ] The commit message is clear and follows our guidelines (not just this pull request message)
[ ] There are appropriate tests covering any new functionality
[ ] The documentation has been updated or is unnecessary
[ ] The changes have been verified
[ ] New dependencies are appropriate or there were no changes

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
140

Relevant Lines:
140

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
140

Relevant Lines:
140

💛  - Coveralls

timdex-ingest-prod state machine completed successfully for the Alma daily run :sparkles:

Received an email notification that a PPOD upload completed successfully :sparkles:


Fmovies New URL

Source information
Fmovies 14.25
Source language
English
Source new URL
https://fmovies-hd.to/home/
Other details
I know the orginal fmovies is down , and this one is a copy but still it has the same features and ui so why don't we use it ...
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated all installed extensions.
[X] I have opened WebView and checked that the source URL is not updated yet.
[X] I will fill out all of the requested information in this form.

https://fmoviesz24.net/ also works


Fixing links after move of repo

Signed-off-by: Mary Anthony<EMAIL_ADDRESS>(cherry picked from commit c48aa79979ef9f60b8e7e5d086e21a4cd3b28333)

Author LGTM

LGTM

LGTM


docs(form.FormController): *  $touched and $untouched

docs update
no $touched and $untouched are described in the doc
$touched and $untouched are described in the doc
Does this PR introduce a breaking change? no
Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:
$touched and $untouched properties added to doc

Thx for submitting the PR, but this addition is invalid.
The FormController does not have $touched/$untouched properties.

@gkalpak Hmm, how do i use it in 1.5, if it doesn't have it ?

You don't :grin: You can't use a feature that does not exist. If you believe it would be useful to aggregate $touched/$untouched on the FormController, you can open a new issue (or even a PR :smiley:), so we can discuss this.
(But in any case, you should not document a feature that does not exist :smiley:)

@gkalpak take a look please http://prntscr.com/dx5rnb :)

The $touched property shown on the screenshot is not on a FormController instance (afaict).
I assume vm.editUserForm is the alias of a form (and thus points to a FormController instance) and phone is the name under which an input field is registered to the form. So, vm.editUSerForm.phone points to an NgModelController (which does indeed have $touched/$untouched properties, as documented).


Filtering for cooldowns.

Make it possible to filter cooldowns.
A GUI for this options could look like this, preferably using icons to keep the window size nice and small.
Checkbox for disabling all, at least on an item level, eg. disabling all spellcloth tracking.
Optionally, also a checkbox to disable all for a character:
                               [x]                     [x]                     [x]
                         spellcloth          cloth2...             transmute

Character 1  [ ]           [x]                     [  ]                      [x]
Character 2  [x]           [x]                     [x]                      [x]
Character 3  [x]           [x]                     [  ]                      [x]

Implemented in 1.13


Error on monitoring disk space

Hi,
just installed PMP on my RPi2 running latest Raspbian. The setup went smoothly but I get an error message in the logs plus an alarm on the PRTG server. The error message popping up is as follows:
02/26/2016 11:07:37 - ERROR - Ooops Something went wrong with 'mpdiskspace' sensor 3200. Error: invalid literal for int(    ) with base 10: '1K-Bl\xc3\xb6cke'
Could you help me on this one?

Hi,
I don't know if could help but following a fresh miniprobe install. on Debian 7.9, a similar error appears :
03/02/2016 09:51:11 - DEBUG - {u'sensorid': u'94314', u'kind': u'mpdiskspace', u'host': u'<IP_ADDRESS>'}
03/02/2016 09:51:11 - DEBUG - Spawning sensor mpdiskspace.
03/02/2016 09:51:11 - ERROR - Ooops Something went wrong with 'mpdiskspace' sensor 94314. Error: invalid literal for int() with base 10: 'fich.'
But my lacks of Python knowledge don't permit me to give more help.

Hi,
It's dirty but it works, I modified "PythonMiniProbe/miniprobe/sensors/diskspace.py"
Don't know if could help but it works like that.

Is there any Clean Solution known? The above fix doesn't work.
Ooops Aaarrrghhh Something went wrong with 'mpdiskspace' sensor 2832. Error: invalid literal for int() with base 10: '1K-Bl\xc3\xb6cke'

Ok...the Solution was giving attention to the "locale" If your System is in your own language, the Script fails because it can handle only "Filesystem" on line 87.
Regards.


FR: networkbuilder has a Build method that produces an AvalancheNetwork

This would eliminate the need for the following code in the Setup method of AvalancheTestRunner:
	// first setup bootstrap nodes
	var nodeChecker []*services.DefaultAvailabilityChecker
	for i := 1; i <= runner.definedNetwork.GetNumBootstrapNodes(); i++ {
		if bootstrapNode, ok := runner.definedNetwork.Nodes[fmt.Sprintf("bootstrapNode-%d", i)]; ok {
			if bootstrapNode.IsBootstrapNode() {
				_, checker, err := newNetwork.CreateNodeNoCheck(runner.definedNetwork, bootstrapNode)
				if err != nil {
					return nil, stacktrace.Propagate(err, "An error occurred creating a new Node")
				}
				nodeChecker = append(nodeChecker, checker)
			}
		}
	}

	for _, checker := range nodeChecker {
		err := checker.WaitForStartup(15*time.Second, 10)
		if err != nil {
			panic(err)
		}
	}

	for _, node := range runner.definedNetwork.Nodes {
		if !node.IsBootstrapNode() {
			_, err := newNetwork.CreateNode(runner.definedNetwork, node)
			if err != nil {
				return nil, stacktrace.Propagate(err, "An error occurred creating a new Node")
			}
		}
	}

This would also make Avalanche network-building standalone, so users could write their own tests without needing to use AvalancheTestRunner like so:
func (test SmartContractTest) Setup(networkCtx *networks.NetworkContext) (networks.Network, error) {
	txFee := testconstants.TxFee
	totalAmount := testconstants.TotalAmount
	seedAmount := testconstants.SeedAmount
	stakeAmount := testconstants.StakeAmount
	validatorNodeName := testconstants.ValidatorNodeName
	stakerUsername := testconstants.StakerUsername
	stakerPassword := testconstants.StakerPassword
	delegatorNodeName := testconstants.DelegatorNodeName
	delegatorUsername := testconstants.DelegatorUsername
	delegatorPassword := testconstants.DelegatorPassword
	genesisUsername := testconstants.GenesisUsername
	genesisPassword := testconstants.GenesisPassword

	// create the nodes
	stakerNode := networkbuilder.NewNode(testconstants.ValidatorNodeName).
		Image(test.avalancheImage).
		IsStaking(true)

	delegatorNode := networkbuilder.NewNode(testconstants.DelegatorNodeName).
		Image(test.avalancheImage).
		IsStaking(true)

	definedNetwork := scenarios.NewBootStrappingNodeNetwork(test.avalancheImage).
		TxFee(txFee).
		AddNode(stakerNode).
		AddNode(delegatorNode)

        return definedNetwork.build()   // Doesn't exist yet
}

This would also mean that AvalancheNetwork.CreateNode wouldn't need to take in the builder, so that a Test.Run method could call AddNode (right now it can't due to needing the builder)

Would this mean that the builder now would create the Nodes ?
What would a test look like ?