[Docs] Replacement for distutils.command.install_data ?

Summary
I'm looking into progressively migrating distutil usage in pywin32 (https://github.com/mhammond/pywin32/issues/2119), where distutils.command.install_data.install_data is used.
https://setuptools.pypa.io/en/latest/deprecated/distutils-legacy.html#prefer-setuptools and https://peps.python.org/pep-0632/#migration-advice mention that distutils.command.* should be replaced by setuptools.command.*. However, setuptools.command.install_data does not exist. I searched the documentation for install_data and could not find any deprecation or migration mention.
OS / Environment
Windows 10
Python 3.9
setuptools 68.2.2
Additional Information
Document a migration path for distutils.command.install_data
Code of Conduct

[X] I agree to follow the PSF Code of Conduct

Hi @Avasam, thank you very much again for working in the migration.
Any install_* command is complicated...
There is actual no replacement since setuptools no longer is responsible for installing the package itself after the Python package ecosystem moved to a "post-PEP517" era.
In a "post-PEP517" scenario, all setuptools does is to create a .whl file (a custom .zip) which is then installed by pip without calling 3rd-party code. Customisation of install_* commands may (a) fail, (b) not behave as intended or (c) be merely used to copy the files to their correct places inside the .whl archive - not in the end-user's machine.
I had a look at your setup.py. It seems that the only customisation is to re-use the install.install_lib directory. In turn, this seems (to me, and I maybe be interpreting the code wrong) like an attempt to abuse data_files/install_data to actually install package data or "synthetize on the fly" new packages[^1].
If that is the case, wouldn't it be a better option to use package data directly instead?
Maybe you will also need a custom build step (example) for placing pywin32.pth (or other non-Python files directly inside site-packages).
[^1]: If I am not mistaken, any folder in install.install_lib ends up in the site-packages folder, which is in sys.path. Any folder inside of a directory in sys.path is package itself (more specifically, a "namespace package" if it does not contain an __init__.py).

Thank you for all the references and direct documentation links. This will require some exploration on my part, and fully understanding what and why pywin32 does so. (so far my interpretation is the same, pywin32 does programmatically and dynamically create multiple packages).
Might be a while though because this is low priority until pywin32 officially stops providing .exe installers, and running the setup script directly (which they already deprecated in favor of pip install)


ci: Fix lint-daggerized.yml error

Found from
https://github.com/dagger/dagger/actions/runs/5147441125. The uses must have ./ to point to local action.

The workflow is now working but still a failure for some reason.

No worries, will review & merge when the check is passing.


tf.contrib.layers.sparse_column_with_hash_bucket() lead to 'out of memory error' with large hash_bucket_size?

I'm using the wide_n_deep model on my own data, which has feature dimension about 100million. When I use the sparse_column_with_hash_bucket() and set the hash_bucket_size to 10million (because some categorical features have that much different values), the program always failed with the out of memory error.
So I wonder if tensorflow's wide_n_deep model could handles data with high dimension like the case above?

This question is better asked on  StackOverflow since it is not a  bug or feature request. There is also a larger community that reads questions there. Thanks!


BACKSPACE changed from PSReadLine 2.0.0-beta1

I found BACKSPSCE changed from PSReadLine 2.0.0-beta1
from  BACKSPSCE  (ctrl+H)    to  ascii127(ctrl + ?)
Steps to reproduce
Install-Module PSReadLine -AllowPrerelease -Force -AllowClobber
exit
pwsh
press BACKSPSCE
I changed BACKSPSCE setting in termal, then PowerShell is working fine.
Environment data
Name                           Value

PSVersion                      6.0.0
PSEdition                      Core
GitCommitId                    v6.0.0
OS                             Linux 3.10.0-693.11.6.el7.x86_64 #1 SMP Thu Jan 4 01:06:37 UTC 2018
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0
(get-module PSReadLine).version
Major  Minor  Build  Revision
2      0      0      -1

I don't understand this issue. The repro steps don't show anything either.
@chuanjiao10 can you elaborate on the issue and give more detailed repro steps?

I checked the latest version of putty, v 0.70 .
I found putty's default BACKSPSCE set to ascii127 (ctrl + ?), so putty users do not feel the key change.


Opening bag storage and then belt storage (or vice versa) breaks the first container

Description

Title. By opening both storage containers simultaneously without closing the first one, you lose the ability to look into it and take items out of it freely. This also applies to any form of storage, provided the second container is one that's either in your bag slot or belt slot
You can still use hotkeys to take out favorite items and put new items in, or click on the container to put them in that way, but you cannot look in the storage itself without closing it through the right click menu and then re-opening it
Reproduction

Open any container
Do not close the first container
Open your bag or belt
Close the second container

Screenshots

N/A
Additional context

A recent commit definitely broke this as before your bag/belt would automatically close when looking into a new container, this is still true for other storage or anything not on your person (excluding hands)

I was unable to reproduce this. Please let me know if I followed your steps correctly.
https://youtu.be/p1jATB4_ofQ

closing in favor of #27692 due to more detailed replication steps.


fix(autoware_behavior_velocity_occlusion_spot_module): fix bugprone-macro-parentheses

Description
This is a fix based on clang-tidy bugprone-macro-parentheses error.
/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/behavior_velocity_planner/autoware_behavior_velocity_occlusion_spot_module/src/scene_occlusion_spot.cpp:39:34: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
    const std::string time_msg = n + std::to_string(x);            \
                                 ^
                                 ()

Related links
Parent Issue:

Link

How was this PR tested?
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

@shmpwk @taikitanaka3 @tkimura4
Please confirm the PR. Thank you very much.


[@vueuse useStorage] Lost data in localStorage when I refresh the page? dev normal. after build deploy error.

Describe the bug
When I login in my home page.
1、authStore.login(data);  // checked the data was save in localStorage.
2、When I click refresh button of chrome. I see the "token" in localStorage change to empty string.
When I run "vite --port 3000 --open" in local. the token is ok.
But When I run "vite-ssg build" and deploy to server. the token is missing when I refresh page.
I tried add ssr, but it still doesn't work.
ssr: {
    noExternal: ['@vueuse/core'], // 确保依赖正常工作
  },

import { useStorage } from '@vueuse/core'

export const useAuthStore = defineStore('auth', () => {
  const token = useStorage('token', '');

  const login = (user: any) => {
    const { token: newToken, ...userData } = user
    token.value = newToken
  }

  return {
    token,
    login,
  }
})

Reproduction
test url
1、open it. use chrome dev tools. set localStorage token anything in application.
2、refresh page. the token value is gone.
tips: dev fine. build deploy to server, lost token.
reproduction project.
System Info
npm: 21.1.0
pnpm: 9.11.0

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Contributions

[ ] I am willing to submit a PR to fix this issue
[ ] I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)

I am sorry this is just a starter template, we only deal with the issue of the template itself - this is not a help form for your questions - please do you own research. Thanks.

I am sorry this is just a starter template, we only deal with the issue of the template itself - this is not a help form for your questions - please do you own research. Thanks.

Alright, thanks all the same.


Simplified delegate invocation

Simplified delegate invocation for leaner code.

Hi, @Thomas-S-B! Thanks for the contribution.
I'm pretty sure we have a lot of those in the codebase, so it would be helpful if you could find and replace them all. Otherwise, we've been cleaning them up when we change nearby code.

Hi Derrick,
ok, i'm replacing all in another PR.


Investigate on OOM issue when checking graalvm native image compatibility with gRPC

Description:
This usually results in 137 status in the compile stage,
[6/7] Compiling methods...    [**********Error: Image build request failed with exit status 137

Found the following when running on macOS
GC warning: 581.4s spent in 53 GCs during the last stage, taking up 54.98% of the time.
            Please ensure more than 9.62GB of memory is available for Native Image
            to reduce GC overhead and improve image build time.

Fatal error: org.graalvm.compiler.debug.GraalError: java.lang.OutOfMemoryError: Java heap space
        at method: Object ballerina.grpc/1.$value$$anonType$_0.ServerReflectionInfo(Strand, BObject, StreamValue)  [Direct call from Object $value$$anonType$_0.call(Strand, String, Object[])]
        at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.code.CompileQueue.defaultCompileFunction(CompileQueue.java:1435)
        at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.code.CompileQueue.doCompile(CompileQueue.java:1370)
        at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.code.CompileQueue$CompileTask.run(CompileQueue.java:337)
        at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.util.CompletionExecutor.executeCommand(CompletionExecutor.java:193)
        at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.util.CompletionExecutor.lambda$executeService$0(CompletionExecutor.java:177)
        at java.base/java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1426)
        at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
        at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
        at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
        at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
        at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183)

This happened after adding a new feature related to server reflection in gRPC - https://github.com/ballerina-platform/module-ballerina-grpc/pull/1015

According to the error msg, the issue is related to the ServerReflectionInfo function inside the dynamic service reflectionService in here [1].
When I broke the function into several parts and reduced the function line length, the native image for the bbes and module tests can be built.
Will confirm this by running all the module tests.
[1] https://github.com/ballerina-platform/module-ballerina-grpc/blob/d4a979c1906dab2a1e44c3695d5f1c64a8342b6b/ballerina/service_endpoint.bal#L101

With the reformatting of the code, was able to successfully complete the module level tests and bbes as well.


Add optional size parameter to the RenderDevice buffer_get_data method.

It might sometimes be desirable to only retrieve a portion of a GPU buffer, thus I modified the RenderingDeviceVulkan::buffer_get_data method to allow for a size parameter to be specified.
For instance, in my case I am running a marching cubes algorithm in a compute shader, this requires the definition of a storage buffer accounting for the worst case of vertices, however I use a atomic counter to ensure that the buffer is tightly packed. This modification then allows me to only retrieve the relevant part of the buffer.

Thanks for your contribution. Seems to static checks failed - you need to use clang-format tool to fix these problems. Squash the commits after that.

Seems like it was some sneaky whitespace.

Seems like you amended the name of the commit, please change it back to the PR name.

Maybe adding the offset parameter make sense too?

Yeah, I think that makes sense, I'll add it.

You need to squash all commits to the first (which is the PR name), so it doesn't matter.

Ok, I added a offset parameter, also added some documentation.

Thanks for CCing me. No big deal for D3D12. You have my blessing.

Thanks!


Don't export data from BigQuery to buckets

We initially did so for the sake of then importing it into Neo4j.  Once we removed Neo4j, we left the data because users preferred fetching it from buckets than from BigQuery. There are no longer any users using it.  The code to do it is very elaborate (because BigQuery is terrible at exporting data).

The page-views workflow could then be refactored as a scheduled query instead of a workflow.

Done by #657, among others


rcc should include propTypes

This would be a "highly opinionated" change, but it's one I think could benefit the entire community. By forcefully suggesting that people include propTypes (https://facebook.github.io/react/docs/reusable-components.html) you could significantly increase the chances that people will document the API of their components.
If you've ever tried to work with a third party component that has a lot of functionality only exposed via searching for "this.props.*" then you'll understand why I suggest this change.

That should probably be a linter's job, no the syntax highlighting package. Take a look at https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/prop-types.md

@mathieumg Syntax highlighting has been removed from this package. My suggestion relates to the default text inserted by the "rcc" snippet.

I thought this was sublime-babel when reading my emails, my apologies.


Filter machines by state doesn't work for offline or disabled

Just found a few oddities with the "filter machines by state" functionality - it only appears to work for online machines.
If you search for 'disabled', it shows disabled machines, offline machines, and online machines that need a calamari upgrade (only hides online machines).
If you search for 'offline', it shows all machines.
It appears that here and here are both missing a >= 0 check.
Probably need another state for "CalamariNeedsUpgrade" as well.
Also had a thought that this functionality is not very discoverable... Maybe a tooltip or some placeholder text might be useful?

Good point on it not being very discoverable. In fact I completely forgot about it!
Interesting what you are seeing. I need to check it against my 3.X install later tonight. We are still on 2.x at work (in the process of upgrading at the moment).
Yes I agree the problem would be at those two spots. I'll be sending out an update tonight 'Octo Version Analytics' so I'll include that fix. Would you like to verify it on your end first? Adding the 'Calimari needs upgrade' state filter as well?

I've just had a quick play:
Updating the determineStatus at environment-filter.js#L21 to
	function determineStatus(node)
	{
		if (node.src.indexOf("Server-Online") >= 0) {
			return "online";
		} else if (node.src.indexOf("Server-Disabled") >= 0) {
			return "disabled";
		} else if (node.src.indexOf("Server-Offline") >= 0) {
			return "offline";
		}
	}

Works well. It still leaves the "Update calamari on this/these machines" button visible, but with this fix it works better than it did.
Would like to do a PR, but dont have time today, unfortunately.

I'll add it to my analytics pr tonight.


ADD SLRS to Token List

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address: SLRSSpSLUTP7okbCUBYStWCo1vUgyt775faPqz8HUMr
Token Name: Solrise Finance
Token Symbol: SLRS
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>) -
Link to the official homepage of token: https://solrise.finance/
Coingecko ID if available (https://www.coingecko.com/en/coins/solrise-finance):

doesnt add any token


Linux 64 bit kcc 5.5.1

Hi,
I notice when trying to convert from "Add directory" method. for example the folder name is "Chapter 11" -> it will be output a new MOBI file but in the format of "Chapter 11..mobi"  Having extra ".." in the end
The KCC is obviously can't find the generated .mobi and it just hangs when trying to publish MOBI file
You can transfer and have Kindle read the Chapter 11..mobi though

I can't replicate this issue.

`Preparing source images...
Checking images...
Processing images...
Creating EPUB file...
Traceback (most recent call last):
File "/usr/lib/python3.5/shutil.py", line 538, in move
os.rename(src, real_dst)
FileNotFoundError: [Errno 2] No such file or directory: '/var/host/media/removable/SD Card/dbz/Chapter 11.mobi' -> '/var/host/media/removable/SD Card/dbz/Chapter 11.mobi_toclean'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/pi/.local/lib/python3.5/site-packages/kindlecomicconverter/KCC_gui.py", line 383, in run
item, comic2ebook.options.covers[outputPath.index(item)][1]))
File "/home/pi/.local/lib/python3.5/site-packages/kindlecomicconverter/comic2ebook.py", line 1166, in makeMOBIFix
move(mobiPath, mobiPath + '_toclean')
File "/usr/lib/python3.5/shutil.py", line 552, in move
copy_function(src, real_dst)
File "/usr/lib/python3.5/shutil.py", line 251, in copy2
copyfile(src, dst, follow_symlinks=follow_symlinks)
File "/usr/lib/python3.5/shutil.py", line 114, in copyfile
with open(src, 'rb') as fsrc:
FileNotFoundError: [Errno 2] No such file or directory: '/var/host/media/removable/SD Card/dbz/Chapter 11.mobi'
^C
`

I will try to find the cause.

I'm having the same problem...

I can't replicate this issue but I will be fixed in 6.0.


Polygon Deposit Transactions are not part of block

Polygon has special transaction that Deposit assets from mainnet to polygon chain.
These transactions are not part of Firehose blocks.
Example Transaction: https://polygonscan.com/tx/0x8f3e05c5af7d601a6015c4fdbb68a04cbf0305fe2740920ce70f81ed1943a194
As per the release notes V1.3.6. State sync transactions should be tracked. But firehose node is not tracking it.
https://github.com/streamingfast/firehose-ethereum/releases/tag/v1.3.6

This release fixes polygon "StateSync" transactions by grouping the calls inside an artificial transaction.

Discord Thread: https://discord.com/channels/666749063386890256/982135810742697984/1142136382853234719

probably the same as this: https://github.com/streamingfast/firehose/issues/25

Thanks @sduchesneau
When this will be officially release ?

@0xsarvesh just wanted to let you know that we've now switched to serving the fixed blocks on our https://polygon.streamingfast.io firehose endpoint.


add deprecation notice and link to logging-winston

@JustinBeckwith @google-cloud/node-team PTAL. Once this lands, I will do a deprecation notice in the npm module as well.

/cc @GoogleCloudPlatform/node-team

Could we take this a step further and fail the install on a semver major?  If folks npm install this I want it to fail with a reasonable message

I think a deprecation warning on module install would be adequate. Forcibly failing the install is quite unfriendly/hostile to users. If this module is working well enough for some users, let us not force them to do the work to migrate.
This module is not costing us in maintenance, and now we are indicating that this is not maintained. It would be more work to forcibly fail the install, but with no clear benefits to either us or to the user of this module.


MM-53107 Add limit to Markdown nodes

Summary
The main change here (which is in the commonmark-react-renderer and commonmark.js changes below) is that we're going to be limiting the maximum number of Markdown elements in a post to prevent it from affecting performance/battery life too much. In particular, this involves limiting general Markdown elements as well as some tweaks to table rendering since they generate a large number of Markdown elements.
In addition to that, I snuck in a related fix where some of our custom elements (emojis, at-mentions, hashtags, and channel links) contain a text node inside of them. That caused commonmark-react-renderer to render that text as a child for them, even though none of those elements use their children props, and it also meant that they were counted twice for the limit I added.
Ticket Link
https://mattermost.atlassian.net/browse/MM-53107
Related Pull Requests
https://github.com/mattermost/mattermost/pull/24414
https://github.com/mattermost/commonmark-react-renderer/pull/5
https://github.com/mattermost/commonmark.js/pull/16
Checklist

[x] Has UI changes
[x] Includes text changes and localization file updates

Device Information
This PR was tested on: iOS Simulator (iPhone 14 Pro Max, iOS 16.4)
Release Note
Slightly improved performance of Markdown rendering
Added a limit to the maximum complexity of Markdown rendered

@hmhealey tests failing

In the commonmark repo, I merged the missing commits from 0.30.1-0 into master the CI failures on this PR were caused by them being missing, and then I had to upgrade a dependency to be able to cut 0.30.1-1. I made sure to push the tags for both releases so we can find them in the future.

Building app in separate branch.

Both the slowness and the anr are related

the changes related to limit and some better performance when viewing the Lengthy markdown message is working.
In cases like, over editing same message , we can see app might break, but its not a blocker for this PR

@hmhealey - Is this a configurable setting available via the System Console UI, or through the config.json? What's the default value? What values are supported?

@cwarnermm Yeah, there’s a server-side setting for it, but that got pushed back to 9.1, so I hadn’t submitted a PR to update the docs for that. The default is currently 0 which means “use whatever limit the mobile app wants” to let us easily change the default when we make more improvements here.

@hmhealey - Sounds like we don't necessarily need to document this yet, then, if it's not actually configurable by an admin?


Refactor elichika typing

This PR tries to enhance the readability of elichika/typing with the following changes:

Remove unused __eq__ of types
Move some functions in types.py that are related to applying symbolic shape annotation for the inferred types, into a new file annotation.py

/test

/test

/test


Updated network pulse link

Previous one leads to a 404

Oh, just saw that PR #75 fixes this too. I'll close it to reduce duplicates.


[feature] E2E v3 validators

What problem does this new feature solve?
Speed up v3 development with e2e testing to validate changes
Describe the solution you'd like
Create a w3m v3 UI validator in the lab test suite

Waiting for v3 example project that will replace lab


Create an intermediate representation that can be used to render to multiple targets

Current efforts such as https://github.com/Khan/KaTeX/pull/251 use the output of buildHTML which contains some HTML specific data which is necessary for canvas rendering.  It would be nice if we had a more minimal intermediate representation that could be use for rendering HTML, MathML, Canvas, and SVG.

It probably makes sense to base this representation on what can come in TeX's math mode, which can be found on page 290 of the TeXbook. We can choose a useful subset of them, (like the ones that we currently support) and figure out all the parameters necessary to render them.
We also might want to think about how we should handle state going forwards. Right now, the only state modification we really allow are style changes (like \displaystyle) which lets us basically sidestep the problem entirely using the funky "implicit groups" but we might want to come up with a representation that more correctly models how TeX works for the future (in case we want to start allowing other kinds of state changes, like variables or macros).
I could write up a doc detailing such a representation, or we could work on this together some time?

We had a chat and decided to do a couple of things:

simplify ParseNode/ParseResult into POJOs w/ functions that return those POJOs (this is so that we maintain output that can be JSON serialized)
audit existing parse node types to see where we deviate from commands being used in chapters 24 and 25.

My vision of this issue as far as I currently understand it:

KaTeX parser generates CST which is potentially less readable than AST. It contains more data than external user (author of an editor for example) absolutely needs to provide.
Trivial example: \\frac node has type, numer and denom fields which are semantic and are needed, but also hasBarLine, leftDelim, rightDelim and size whose necessity may not be obvious to external user.
Both buildHtml and buildMathML accept CST.
An editor (#809) most likely would want to get rendered HTML from AST.
There are use cases for bare parser. I guess, this cases would want AST instead of CST too.

So the task is to provide an AST and a way to get CST from AST while keeping changes minimal and backward-compatible. An explicit list of all AST nodes should be provided to simplify tree building from outside of KaTeX for external user.
Also I'd like to avoid changes in buildHtml and buildMathML if possible.
Thus I propose a plan:

Make a set of classes representing AST nodes. Filed type of ParseNode and file functions.js are sources of information what classes are needed. Example for op (\sin, \max, \int, \mathop, etc.):class Operator extends Node {
    constructor(command) {
        this.command = command;
    }
}

Make a AST->CST converter. Here I see some options:

Make an explicit converter which basically would be functions.js rewritten. Typical code in such converter:function convertOperator(op) {
    switch (op.command) {
        case "\\arcsin":
            return {
                type: "op",
                limits: false,
                symbol: false,
                alwaysHandleSupSub: false,
                body: op.command,
            };

        case "\\det":
            return {
                type: "op",
                limits: true,
                symbol: false,
                alwaysHandleSupSub: false,
                body: op.command,
            };
    }
}

Any drawbacks? Personally I like this way the most because it provides clear point where AST is converted to CST.
Same as explicit converter, but return instances of AST classes themselves. Then build*.js could use some classes power to be more readable.
I'd like to avoid such intrusion into builders code, at least on first step, but I think I could do it too.
Add all variables from CST currently sitting in ParseNodes into local variables of build* functions. Like this (buildHTML.js):

groupTypes.op = function(group, options) {
    const symbol = ["\\int", "\\iint", "\\iiint", "\\oint", ...]
        .indexOf(group.value.body) >= 0;

    const limits = ["\\det", "\\gcd", "\\inf", "\\lim", ...]
        .indexOf(group.value.body) >= 0;

    // rest of the code
}

Cheat. Move all CST variables into functions of objects returned in function.js:defineFunction([
    "\\det"
], {
    numArgs: 0,
}, function(context) {
    const op = new Operator(context.funcName);

    op.limits = function() {
        return ["\\int", "\\iint", "\\iiint", "\\oint", ...]
            .indexOf(group.value.body) >= 0;
    };

    op.symbol = function() {
        return ["\\int", "\\iint", "\\iiint", "\\oint", ...]
            .indexOf(group.value.body) >= 0;
    };
});

Then modify build*.js to use that functions. Strange option just for variety.

Finally, modify parseTree usages to include AST->CST conversion.

I see subsups are special. Should it be treated in a special way? Any more similar cases?
I suppose that for any symbol or funciton all CST-exclusive data desired for build*.js could be computed from AST data. Is it correct? In other words, is there any parser state which is added to ParseNodes outside of functions.js and is used in rendering?
Regarding errors reporting: as far as I see, explained plan do not interfers with it at all.

For \frac commands which generate genfrac nodes, it appears that leftDelim and rightDelim as always null, at least in my testing.  For \left( \frac{x}{y} \right) we wrap genfrac inside a leftright node.  I hope that we can iterate on the parser so that it returns a minimal (or almost minimal) AST.  I'll respond in more detail to the rest of the post later.

I thought about it a bit more, and I think my statement about computing CST from AST is false. Or, at least, I should suppose it as being false.
So, I think I should start with explicit list of tree node types and AST->CST converter. parseTree usages should not be altered. Instead, a new way to render should be added so external user would be able to render AST without evaluating all attributes used by renderers.

I did some experimenting with a possible IR a while back, but had some troubles with the vertical HTML layout b/c I was trying to simplify that.  I think if we use our existing HTML vlist builder it should be fine.  Here's a link to that IR: https://github.com/khan/katex-ir.  I feel like we should clean up our parse tree and HTML build tree (using HAST) first before trying to inject a layer between them.

For \frac commands which generate genfrac nodes, it appears that leftDelim and rightDelim as always null, at least in my testing.

A random interjection: Something like {a \choose b} would return something with a leftDelim and rightDelim, right? In general though, there might be cases that KaTeX doesn't currently handle that we would want the AST to be able to handle.

I'm trying to define CST right now here. It's supposed to be used in our editor prototype as an interface between editor syntax tree and Katex parsing tree because the latter is filled with parsing logic which we're not interested in.
Firstly I've tried to extend ParseNode but stuck in Parser.js. So now I'm doing it on the side - CST is built manually by editor, ParseNodes are built by CST's toParseNode, ParseNodes are fed to Katex to render. If you find this version of CST useful, I would like to try to use it everywhere instead of ParseNode.

@spontaliku-softaria you may find the conversation in #892 interesting.
I think I understand better now what you're going for.  I don't think the term CST really applies to KaTeX's AST, the reason being is that it doesn't encode all information necessary to recover the original input string.  I think what we're talking about is actually two ASTs.  They just describe different things.  KaTeX's AST describes how various primitive commands (encoded as groupTypes in buildHTML.js and buildMathML.js) are nested.
This may or may not be a useful view of the world depending on how you want your editor to behavior.  In the case of genfrac, if a user decides they want a \choose b or a \over b, KaTeX will generate a genfrac node.  In either case the user might want to navigate to edit a or b or delete the whole thing.  If there are left/right delimiters a user could modify the delimiters but they wouldn't be able to delete just one.  How these restrictions are communicated to the user and enforced on their input will be up to use as creator of the editor.
Think about this example, I'm starting to question the need for leftDelim and rightDelim on genfrac nodes.  There's already a leftright node for delimiters.  It would make the AST more regular if we wrapped fractions with a leftright node.  @xymostech @sophiebits what was the rational for treating the left/right delimiters for fractions differently from other uses of left/right delimiters?

@kevinbarabash anyway, ParseNode containts more than external user would want to provide. Lexer for example. So yes, looks like two ASTs.
I was going to evaluate how an AST for external user might look like after I finish current AST and get used with all variants of ParseNodes. But the one I'm doing now should be useful, just not the most convenient.
Also I'm not sure yet how to avoid passing math/text from external user and evaluate it from the tree - I guess this logic is not simple.
Looking at #892, wouldn't it be easier to fix this task before? Because the one working on #892 would need to do IR implicitly anyway to be able to reason about ParseNodes.

Oh sorry I misread #892 - by some reason I've decided it's about migrating to HAST.

I believe TeX itself does the genfrac-with-delimiters thing. IIRC the delimiters might end up a little too large if you treat them independently.

I love the idea of having a "minimal intermediate representation". What's the status on this? What can I do to help?

@rrandallcainc my rough roadmap for an IR would be:

finish adding flow types
finish moving functions in functions/ folder
simplify the parse tree
add intermediate representation

While not all of the steps are strictly necessary I think they will improve our chances of success.  The first two items are in progress changes that are modifying lots of files/code so it would be nice to finish those off before introducing other big changes.  Flow types will also add some safety as we continue to make big changes.
Simplifying the parse tree I think will making writing transforms from the parse tree to the intermediate representation simpler.
We'll also want to figure out what we want the IR to look like.  To start with I think we can build on top of the existing VList by introducing an HList.  We'll also need Rule and Glyph/Atom.  One thing that I'm uncertain of is how to deal with horizontal centering of things, e.g. fractions.  In TeX there's equal glue on either side of the numerator and denominator which results in the numerator and denominator being centered.  If we can figure out a way to use flex-box to emulate this behavior then I think we should be able to move forward with this.  I've spent some time prototyping an intermediate representation in https://github.com/Khan/katex-ir, but I got stuck with how to render glue to HTML.

@kevinbarabash Just curious, why does mathml not count as an intermediate representation? It's pretty well standardized.

@rrandallcainc I hadn't thought about it, but I suppose it could.  As long as it has all the information needed to render to HTML and Canvas it should work.

@rrandallcainc I did some more thinking about this and one of the things we'd like to encode in the IR is visual layout of things, e.g. vertical spacing for fractions.  That information would then be used by different renderers for HTML, SVG, and Canvas to produce renderings that look more or less the same.   In this respect, MathML isn't a good fit.

I was thinking about this a bit more.  I think the following data flow might make sense:
TeX -> parseTree,
parseTree -> MathML
parseTree -> IR
IR -> HTML
IR -> SVG
IR -> Canvas

To actually make this happen the IR should have the following objects:

VLists
HLists
Rules
Glyphs
Glue
Paths (TeX doesn't have this, but based on how we render stretchy accents, square roots, etc. we need something to model those)

To actually start moving towards having an IR, we should look and updating various parts of buildHTML.js and the htmlBuilders in function/*.js to generate IR and then immediately convert it to HTML.  A good starting place might be Glyphs because they're relatively simply.
Glyphs should track the following data:

char index (the unicode character code)
fontFamily (roman, sans-serif, typewriter, etc.)
fontWeight (normal, bold)
fontStyle (normal, italics)

What I'm a little less uncertain on is whether to include class (ord, punct, op, etc.) in each Glyph.  Currently the HTML layout makes use of this information, but for SVG and Canvas layouts we only care about the space between atoms in a horizontal layout.  Moreover, if we want to support setting the value of \thinmuskip, \medmuskip, and \thickmuskip in the future, we won't be able to rely on CSS for setting space between atoms anyways.  My preference here is move away from CSS solutions to more programmatic solutions.  To save space in the markup we can have some general styles for spacing that match the defaults.
After Glyphs we'd probably want to work on Glue next.  This would be used to implement \kern et al.  To start with, a simplified Glue that only has the desired width and doesn't support fil et al.
The whole implementation sequence might look something like this:
Glyph, Glue, Rule, Path, HList, Vlist

Before starting on Glyph though it might be good to work on replacing our current CSS for atoms with more general \thinmuskip, \medmuskip, \thickmuskip` styles.

My preference here is move away from CSS solutions to more programmatic solutions.

I believe synchronous rendering is the feature which makes Katex possible to use in an editor. If you want to make some parts of rendering programmatic, please don't lose that. Also, there is at least one counter example to programmatic rendering of Tex - Mathquill which is a mess internally.

@spontaliku-softaria rendering is already programmatic.  The only thing that would change is which styles are being applied to atoms.  Also, the renderer would have to look at adjacent atoms to decide which styles to apply.  We definitely want to maintain KaTeX's ability to do server side rendering and to renderToString().
This could be implemented by adding a step to buildExpression() in buildHTML.js which inserts Glues of appropriate sizes as needed between atoms as needed.  These Glues would then be immediately converted to <span>s with styles for \thinmuskip, \medmuskip, or \thickmuskip.

I've definitely found the CSS solutions a bit hacky. It's impressive what they've been able to do, but e.g. it led to the bug #995 (now fixed by a workaround).  Adding styles to the elements would feel closer to LaTeX, and it's still server-side/synchronous.  And it would enable the user to override things like \thinmuskip, which is possible in TeX but impossible in KaTeX (you can't override the CSS).  (Not that this particular functionality is important, but it feels a bit weird to bake so many lengths into CSS.)
I like @kevinbarabash's approach. Incidentally, what KaTeX calls VLists (and HLists?) are what TeX calls vboxes and hboxes, I believe.  So again this feels nicely close to TeX (and we might consider renaming to match TeX).
I think the main worry here is that, by adding another layer of indirection, we might slow down KaTeX rendering somewhat.  We'll probably want to do some speed tests before spending a lot of time in this direction.  But overall it seems like the natural approach to enabling SVG etc. output.
I have one other vague concern.  I'm not a fan of the current implementation of tables (array), in particular because it makes \multicolumn impossible (see #269).  LaTeX finds a way to implement them with hbox/vboxes, so presumably it's possible... but if we end up using CSS tables or flexbox or something to fix this, the IR might also need some kind of Table structure.

I did some experimentation on this a while back.  See https://github.com/KaTeX/katex-ir.  It was based on the approach presented in https://people.eecs.berkeley.edu/~fateman/temp/neuform.pdf which also includes a Box object whose type can be either HBox or VBox.  It wraps HList and VList respectively along with adding additional information about the height, depth and width of the box.  We may end up introducing Boxes as well here.  A scala implementation of the paper can be found at https://github.com/pkamenarsky/formulae.
@edemaine thanks for raising the concern about slowing down rendering.  I think the slowdown will be negligible at least for render as DOM updates will probably still occupy most of the time.  As for renderToString, my hope is that people would be caching the output for static pages if performance is an issue.  That being said, it's good to know how our performance is being affected by any change we make.  See #1053.
Yeah, multicolumn seems difficult.  It might be easier to do if we use horizontal metrics for everything (measuring the width of things we don't have metrics for as a fallback).

Curious, why not a simpler "IR". Something that contains simple concepts like:
x/y
width/height
type: (i.e. text, shape, etc.)
...

I only ask because as I am working on the Canvas implementation, that's basically what I was able to boil it down to. I turn the buildTree -> simple POJOS -> Canvas

While x/y, width/height, and type is sufficient for rendering to canvas (or SVG), it has a couple short-comings:

it would require knowing the width of all glyphs when rendering to HTML, currently we only use glyph width in only a couple of place iirc
it doesn't reflect how TeX does things which means when implementing low-level TeX commands we need to more work to translate between the x/y, width/height model

@rrandallcainc translating from the TeX box model to model you suggesting shouldn't be too difficult.

I'd be curious if there is some general update on this issue? Totally understood if no one has time for it, I'd just be interested where people see that in terms of a roadmap right now.

Bump, any updates on this? I'd just be curios where this stands in terms of project priorities :)

No update.  This is something that I support, but I won't have have time to pursue personally.  Definitely open to PRs for this although I think a more detail proposal of what the IR should look like.  I prototyped a possible ir a while back.  One of the downsides of https://github.com/KaTeX/katex-ir is that it expects to know the width of every glyph which we currently don't have.

All of this would be made much easier if browser vendors would spend some time on the Font Metrics API but that's been in limbo for years.

Thanks for the update!

No update. This is something that I support, but I won't have have time to pursue personally. Definitely open to PRs for this although I think a more detail proposal of what the IR should look like. I prototyped a possible ir a while back. One of the downsides of https://github.com/KaTeX/katex-ir is that it expects to know the width of every glyph which we currently don't have.

@kevinbarabash You should be able to leverage canvas' measureText method to get the width of each glyph. As long as the rendered "state" is currently updated on the context (i.e. font, size, etc.) it'll give you an accurate measurement that would apply to both canvas and dom (same size). It's a fairly quick measurement, and should lend itself find the synchronous rendering.

没有更新支持事情事情事情，但但没有时间亲自去。绝对对对//github.com/KaTeX/katex-ir的不足之处之一是它希望知道我们的目标之前没有的每个字形的广度。

I think now it's possible to port harfbuzz to wasm to do this.

All of this would be made much easier if browser vendors would spend some time on the Font Metrics API but that's been in limbo for years.

I think now it's possible to port harfbuzz to wasm to do this.


contrib: updated custom fields UI widgets.

closes https://github.com/inveniosoftware/invenio-rdm-records/issues/1232

Tests are failing until https://github.com/inveniosoftware/invenio-rdm-records/pull/1212 is merged


Prepping for pixelator 1.0 release

This PR contains changes that prepare nf-core/pixelator for the 1.0 release of pixelator. The main difference is that the collapse and graph steps will now output parquet files.
For now, since the new pixelator version is not release in order for the tests to pass you need to add: --pixelator_container ghcr.io/pixelgentechnologies/pixelator:dev. We should update the default container once everything is in place in biocontainers.
Linting currently fails, which I guess is because we have note yet updated to the new nf-core templates?
PR checklist

[x] This comment contains a description of changes (with reason).
[ ] Make sure your code lints (nf-core lint).
[x] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[x] Usage Documentation in docs/usage.md is updated.
[x] Output Documentation in docs/output.md is updated.
[x] CHANGELOG.md is updated.
[x] README.md is updated (including new tool citations and authors/contributors).

This work is continuing in another branch so we will close this one.


Populate workloadendpoint with labels from plugin configuration

Imagine a libnetwork plugin configured with a (new) config key like:
CALICO_WORKLOADENDPOINT_LABELS=foo=bar,baz=quux

Resulting in all workloadendpoints created by that plugin to have 2 labels set at create time:

foo: bar
baz: quux

This allows us to add labels describing the Mesos agent: datacenter, rack, core count etc.
Probably not useful for policies and Felix, but it allows 'ecosystem' tools to gather information currently not available.
I will submit a PR, but I wanted to open an issue for discussion first.

I have no objection to this. I think it could be a useful feature and should be a very small amount of code.

Our need for this is gone, so I am won't fix closing this.


confused at what this means

Hey there, I need to run my server as root due to some issues that I'm running into on the project I'm working on, and the error says:
If you know what you are doing and want to continue anyway, export MSM_I_KNOW_WHAT_I_AM_DOING_ALLOW_ROOT=1 and try again.
How would this be done?

I cite the rest of the error message:

This is unsupported and can cause server malfunctions and security issues. Please consider using a regular user instead of root.

I don't provide support for running as root. Besides, the instruction to continue anyway is as literal as it gets.


Container not working

Bug description
Entrypoint | 2024-04-13 22:59:23 | [info] No Foundry Virtual Tabletop installation detected.
Entrypoint | 2024-04-13 22:59:23 | [info] Using CONTAINER_CACHE: /data/container_cache
Entrypoint | 2024-04-13 22:59:23 | [error] Unable to install Foundry Virtual Tabletop!
Entrypoint | 2024-04-13 22:59:23 | [error] Either set FOUNDRY_RELEASE_URL.
Entrypoint | 2024-04-13 22:59:23 | [error] Or set FOUNDRY_USERNAME and FOUNDRY_PASSWORD.
Entrypoint | 2024-04-13 22:59:23 | [error] Or set CONTAINER_CACHE to a directory containing foundryvtt-11.315.zip
Steps to reproduce
Run the username/password docker run OR with url gibe the error
Expected behavior
Running container
Container metadata
docker run felddy/foundryvtt:release \
  --env FOUNDRY_RELEASE_URL='https://foundryvtt.s3.amazonaws.com/releases/11.315/FoundryVTT-11.315.zip?AWSAccessKeyId=******************' \
  --publish 30000:30000/tcp \
  --volume /DATA/D&D/00_FoundryVTT:/data

Relevant log output
Entrypoint | 2024-04-13 22:59:23 | [info] No Foundry Virtual Tabletop installation detected.
Entrypoint | 2024-04-13 22:59:23 | [info] Using CONTAINER_CACHE: /data/container_cache
Entrypoint | 2024-04-13 22:59:23 | [error] Unable to install Foundry Virtual Tabletop!
Entrypoint | 2024-04-13 22:59:23 | [error] Either set FOUNDRY_RELEASE_URL.
Entrypoint | 2024-04-13 22:59:23 | [error] Or set FOUNDRY_USERNAME and FOUNDRY_PASSWORD.
Entrypoint | 2024-04-13 22:59:23 | [error] Or set CONTAINER_CACHE to a directory containing foundryvtt-11.315.zip

Code of Conduct

[X] I agree to follow this project's Code of Conduct

It looks like the environment variables are not set correctly.  The ampersand (&) in your volume path could be problematic, depending on your shell and filesystem.
If you can get 'CONTAINER_VERBOSEset totrueit might shed more light on the problem.  But I suspect that if you are able to do that, you'll also have solved the problem withFOUNDRY_RELEASE_URL` not being set.

I dont know if this one is correct but same error
docker run felddy/foundryvtt:release
--env FOUNDRY_RELEASE_URL='https://foundryvtt.s3.amazonaws.com/releases/11.315/FoundryVTT-11.315.zip?AWSAccessKeyId=*************'
--env CONTAINER_VERBOSE=true
--publish 30000:30000/tcp
--volume /DATA/foundry_vtt/:/data
Entrypoint | 2024-04-13 23:34:07 | [info] Starting felddy/foundryvtt container v11.315.1
Entrypoint | 2024-04-13 23:34:07 | [info] No Foundry Virtual Tabletop installation detected.
Entrypoint | 2024-04-13 23:34:07 | [info] Using CONTAINER_CACHE: /data/container_cache
Entrypoint | 2024-04-13 23:34:07 | [error] Unable to install Foundry Virtual Tabletop!
Entrypoint | 2024-04-13 23:34:07 | [error] Either set FOUNDRY_RELEASE_URL.
Entrypoint | 2024-04-13 23:34:07 | [error] Or set FOUNDRY_USERNAME and FOUNDRY_PASSWORD.
Entrypoint | 2024-04-13 23:34:07 | [error] Or set CONTAINER_CACHE to a directory containing foundryvtt-11.315.zip

You're calling docker run incorrectly:
Usage:  docker run [OPTIONS] IMAGE [COMMAND] [ARG...]

You want the --env options to go to docker.  The way you are calling it is sending the options as arguments to the container.
So, in your case, the proper invocation would be:
docker run
--env FOUNDRY_RELEASE_URL='https://foundryvtt.s3.amazonaws.com/releases/11.315/FoundryVTT-11.315.zip?AWSAccessKeyId=*************' \
--env CONTAINER_VERBOSE=true \
--publish 30000:30000/tcp \
--volume /DATA/foundry_vtt/:/data \
felddy/foundryvtt:release


"maximumBillingTier" missing in BigQuery

The Java client library is missing the maximumBillingTier from the BigQuery rest API. There's no way in the SDK to set it on a per-query level for a query job configuration.
See here --> http://stackoverflow.com/questions/43647678/where-is-the-option-to-set-the-bigquery-maximum-billing-tier-in-the-new-java-sdk
And here --> https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs#configuration.query.maximumBillingTier
It's available in the Python SDK, but not in the Java one. We need to be able to set this at a query level - we do not want to set it project wide.
The only workaround I see to this, is rolling back to the old version of the Java libs (the old version does expose/provide it), which is obviously a massive headache for us.

This parameter does not seems to be available from the BigQuery api services library so I couldn't figure out a way to pass it from here.
@garrettjonesgoogle what is the process to add this parameter from the api services library? Once there, I can work on a PR :-)

@saicheems is this just pending a refresh?

I checked, the Java client library is up to date.
In the discovery file, maximumBillingTier is a property of the JobConfigurationQuery schema.
That schema's definition is here in the Google API Java client:
https://developers.google.com/resources/api-libraries/documentation/bigquery/v2/java/latest/com/google/api/services/bigquery/model/JobConfigurationQuery.html#setMaximumBillingTier(java.lang.Integer)
Is that what you're looking for? I'm not familiar with the BigQuery API itself, so please let me know if I've got the wrong context.

The nesting is Job->JobConfiguration->JobConfigurationQuery->setMaximumBillingTier

@polleyg I believe it's still missing from gcloud-java though, it'll have to be added, I was referring to the old Java client library above.

@saicheems yeah, I know. That what this issue is all about. It's in the old lib, but not the new one ;-)

@rborer - here it is in the old lib

@polleyg thanks for the link, I'll spend a bit of time to dig down in the code with this new information. Anyway, I'm being a bit confused now, is this "old lib" what is used by the BigQuery client internally?

I gave a try into #2044. If I understand the client correctly, I cannot use BigQuery.query(QueryRequest request) method but I have to use BigQuery.create(JobInfo jobInfo, JobOption... options) method so I can pass a QueryJobConfiguration instance?


Bootstrap is being interpreted differently

Describe the bug
I am using a react app with sass and bootstrap. My index.tsc includes the following in the header:
import React from 'react';
import ReactDOM from 'react-dom';
import 'bootstrap/dist/css/bootstrap.css';
import './sass/index.scss';

package.json versions:
"@types/jest": "24.0.18",
"@types/node": "12.7.2",
"@types/react": "16.9.2",
"@types/react-dom": "16.9.0",
"bootstrap": "^4.3.1",
"react": "^16.9.0",
"react-bootstrap": "^1.0.0-beta.12",
"react-dom": "^16.9.0",
"react-scripts": "3.1.1"

This is original css:

which looks like this:

Everything looks fine when developing with npm start. But if I run npm run build I get this css:

which looks like this:

Did you try recovering your dependencies?

I tried deleting node_modules/, but this didn't really help. Is also reproducible on other pc with the same project.
Which terms did you search for in User Guide?

I followed the guide from https://create-react-app.dev/docs/adding-bootstrap. Tried both importing bootstrap from index.tsx or my main sass file.
Environment

npx: installed 91 in 4.726s

Environment Info:

  System:
    OS: Linux 5.0 Ubuntu 18.04.3 LTS (Bionic Beaver)
    CPU: (4) x64 Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz
  Binaries:
    Node: 12.7.0 - ~/.nvm/versions/node/v12.7.0/bin/node
    Yarn: 1.17.3 - ~/.nvm/versions/node/v12.7.0/bin/yarn
    npm: 6.10.2 - ~/.nvm/versions/node/v12.7.0/bin/npm
  Browsers:
    Chrome: 76.0.3809.132
    Firefox: 68.0.2
  npmPackages:
    react: ^16.9.0 => 16.9.0
    react-dom: ^16.9.0 => 16.9.0
    react-scripts: 3.1.1 => 3.1.1
  npmGlobalPackages:
    create-react-app: Not Found

Steps to reproduce

(Write your steps here:)

Import bootstrap in a react app with typescript and sass using this guide: https://create-react-app.dev/docs/adding-bootstrap
Render a form, e.g.:

<Form validated={true}>
<Form.Group as={Row} controlId="first_name">
                    <Form.Label column sm="2">First name:</Form.Label>
                    <Col sm="10">
                        <Form.Control name="first_name" type="input" required />
                        <Form.Control.Feedback type="invalid">You first name should contain at least 3 chars.</Form.Control.Feedback>
                    </Col>
                </Form.Group>
</Form>

Expected behavior

I expect the "compiled" css to be 1:1 as the original from the cdn for example.
Actual behavior

Screenshots already in description.

Using <link href="https://stackpath.bootstrapcdn.com/bootstrap/4.3.1/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-ggOyR0iXCbMQv3Xipma34MD+dH/1fQ784/j6cY/iJTQUOhcWr7x9JvoRxT2MZw1T" crossorigin="anonymous"> in the public/index.html file solves the matter, but this means bootstrap should no longer go through react and npm..

Has this issue to do with the react's app default settings in package.json file?
"browserslist": {
    "production": [
      ">0.2%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  },

So basically it is fixed in bootstrap and css nano, needs to be adjusted in react / react bootstrap. Should I create an issue there?

It seems it is not their responsibility. In this issue ( https://github.com/twbs/bootstrap/issues/28526 ) as @ibqn explained - the problems seems to be in webpack and cssnano. Not related to react, create-scripts uses webpack.
PS: Parcel would be better, please use parcel :grin:


Add language detector and text summarizer

This PR adds:

A language detector for YouTube videos.
Refactorings to the YouTube lib.
Text compression for long texts through recursively calling the LLM to summarize chunks.

Fixes #2


OPG-473: Fix Alarm Panel bug when calculating page rows

Fixed a bug in the Alarm Panel when calculating which rows of data to display for the given page.
Looks like we assumed field.values was always an ArrayVector having a buffer array field which we were accessing directly, however field.values is a Vector and might only contain length and toArray() fields. Using toArray() instead, and also cleaning up some code (use slice() instead of splice(), etc.).
External References

JIRA (Issue Tracker): http://issues.opennms.org/browse/OPG-473
Continuous Integration: CircleCI

@synqotik Hi, recently I've been using this plugin to display data on an alarm table and stumbled upon this very issue that you solved here, so I was able to fix it by upgrading to a version of the plugin that included these changes.

Thank you, that may be a bug. I will open an issue for it and we will address it before the next release.

@jereparla we have a fix, will be in a release sometime this month. Thanks for reporting this!


Add chart to deploy ups-broker

Useful for testing the new controller.

Pending explanation or action on the one question I registered above, this LGTM. And I am 👍 on this being its own chart instead of being bundled in the with the apiserver and controller as was previously done in the catalog chart. Big improvement.

@pmorie demo-ed this to me over a Zoom and it works, so LGTM. Since it's a dependency for the critical https://github.com/kubernetes-incubator/service-catalog/pull/397, I am merging now


I've noticed that with a subset of my dataset, the brain masks are poorly generated. I've attached two screenshots that demonstrate the issue. I believe this is tied to #2731 , which appears to be a lingering issue.
I can try to re-run fmriprep with new working directories and not re-use the freesurfer outputs, to see if that alleviates the issue. Additionally, I see that fmriprep version 22.0.0 is released, so I can try using that version as well. I'll report back once those are finished.

Singularity
Is your data BIDS valid?
Yes
Are you reusing any previously computed results?
FreeSurfer, Work directory
Please copy and paste any relevant log output.
N/A

Additional information / screenshots

I re-ran my dataset with version 22.0.0, using clean freesurfer and working directories. Unfortunately the brain mask issue persists.

Using the --use-syn-sdc did not solve my issue, but I was able to determine what has caused my problem.
For context, I collected a SBRef for each functional BOLD image. Additionally, I collected both magnitude AND phase, as I'm hoping to use the phase data for a secondary analysis. For whatever reason, my Siemens Prisma scanner output a SBRef for the magnitude and the phase (thus 2 SBRef for each functional BOLD image). I thought I was excluding any phase images from being used by fmriprep by including that information in my --bids-filter-file bids_filter_file.json; however, this doesn't appear to be the case, as fmriprep was using the SBRef from the phase data (part-phase_sbref) as the reference for the BOLD mask. My solution was to simply remove the SBRef phase data from my BIDS folder.
I'll therefore close out this issue, but open a new one regarding the issue with the bids-filter-file


Add setExpectationJson

What:
Allow users of this lib to directly pass a static JSON object that is contains the mapping for the expectation with http-request and http-response blocks. Send it to the Specmatic expectations API which is used for setting dynamic expectations.

Why:
Sometimes we would like to setup the mock and define request/response from code the test code, without writing it to a json file in the consumer's Git repo.

How:
Create another function call it setExpectationJson. Reuse it in the the setExpectations function is internally just reading the JSON contents of the file and sending it via the new setExpectationJson function.

Checklist:

[ ] Documentation added to the README.md
[ ] Tests
[ ] Typescript definitions updated
[ ] Ready to be merged

Resolves https://github.com/znsio/specmatic-node/issues/138

@tkrisztian95 Thanks again for this PR on behalf of team Specmatic. Your contribution is now available as part of release 1.2.22. I made minor changes for adding the typedefs around the capability you added and also added an alias for consistency with existing capabilities.


Improve test coverage for DB accessors

Move int64 <> byte conversion to boltdb.go because it is a generic bbolt helper used in multiple places.
Various improvements to database accessor test coverage.  eg. checking errors more strictly, checking data fields are stored and retrieved correctly.
Add fetchShare to Database interface. This is only used by test code, but its going to be needed for both BoltDB and PostgresDB, so it should be included in the interface.
When inserting data, ensure database keys have not already been used. Return ErrValueFound if they have. Postgres will do this at the DB level, so enforcing the same checks in our BoltDB code helps to keep the interface and implementations consistent.

@dnldd  I have deliberately opened a PR with a failing test because I think its something you should see.
I have modified share.go so that it returns an error if you attempt to store two shares with the same ID. This has caused a failing test because the test is trying to insert 5 shares with the same ID.
The previous implementation before I added the error was silently overwriting the value in the database 5 times, which means it was basically having zero effect on anything. What do you think we should do to resolve this? I guess either write 5 shares with different IDs, or just write the share once?

Yeah, that doesn't look right. The share created on times were supposed to be incremented in the loop to generate different share ids. updated the share generation snippet at the reported error line to:
// Ensure payment maturity works as expected.
for i := 0; i < shareCount; i++ {
	// Create readily available shares for account X.
	err = persistShare(db, xID, weight, thirtyBefore+int64(i))
	if err != nil {
		t.Fatal(err)
	}
}
sixtyAfter := time.Now().Add((time.Second * 60)).UnixNano()
for i := 0; i < shareCount; i++ {
	// Create future shares for account Y.
	err = persistShare(db, yID, weight, sixtyAfter+int64(i))
	if err != nil {
		t.Fatal(err)
	}
}

That should do it.

Added your diff and the test is now passing - thanks.
This is now good for review.


some time I am getting file not found exception

Hi I am using this library to to zip folder but in first attempt I am getting file not found exception after going to app setting and uncheck storage permission and check again then it will generate zip file for me how to fix this issue even I am using latest version of this library.
please help

library issue

hey guys any one face this issue?

Do you still need any support with this issue? If yes, please provide more details like which version of zip4j you are using, your code snippet, etc.

Hi this dependecy  I usedimplementation 'net.lingala.zip4j:zip4j:2.9.0'
TargetSdkVersion=28
CompileSdkVersion=28
MinSdkVersion=22

Try to use the latest version of zip4j to see if that fixes the issue.
There is not a lot I could help with the information in the issue.

Closing this issue as there is no further feedback. If you still face this issue, please feel free to reopen, but please provide some additional details for me to look into. With the data above, I really cannot do much.


Document suggested community-based governance model

This PR refers to on-going discussion in #803
Those changes are largely based on the node.js community base policies: https://raw.githubusercontent.com/nodejs/TSC/master/BasePolicies/CONTRIBUTING.md
In addition to those changes, I've bundled the now standard contributor's covenant Code of Conduct

Even though I don't have a formal approval, I'm taking this comment and this other comment as an approval from @mrrooijen. I'll let the PR sit another day or two to let @AdibMurshed and others add comments if needed

Let's keep in mind that those are the foundations, and we probably want them as simple as possible and build on that later on

Moving forward !


Fix trailing whitespace.

@cdleary Looks like the Verible CI does not check for trailing whitespace in yml files...

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.93%. Comparing base (c11e607) to head (f884e6c).
Report is 26 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2242      +/-   ##
==========================================
+ Coverage   92.91%   92.93%   +0.02%
==========================================
  Files         359      359
  Lines       26758    26867     +109
==========================================
+ Hits        24863    24970     +107
- Misses       1895     1897       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@cdleary Looks like the Verible CI does not check for trailing whitespace in yml files...

Ah sorry about that, I guess shows I don't edit yaml a lot 😬

It's a good thing :) Nobody should have to edit yaml more than absolutely necessary.


[fix] #277

cc @atomiks, please make sure it solves your problem once for all.

I hope so, can't tell for certain but at least vertically the arrow seems better positioned.
I'm not sure if it renders perfectly on all browsers, have you tried more tests to see?


not working

Hi,
I'm using pi zero w 1.1 with the prebuild image and nothing is happening only LED is blinking 7 times and pausing. I'm not sure if i have done things right.I have no experience with linux nor github. May be I'm missing some additional configurations.

May I ask how you have written the image to the sd card? and which led is blinking. oh and I am currently working on a new image that I have tested just a few seconds ago, if you give me 2 hours, I can get you a working build. I think one of the earlier ones is broken, I think this one is one of the few of the actually working old builds in the list: https://github.com/Vaneixus/rpi-gadget-image/actions/runs/6477408704
otherwise, the new build I am working on is for adding new functionality. which is why if you downloaded the last green checkmarked build, it might have been an experimental image. The one currently built should work, but I still need to test it out.

I am currently planning better instructions with screenshots, but I am working on improving build times and functionality first. otherwise, I will be happy to include a much more detailed instructions if you need it. also, if you were using the RaspberryPi Imager tool, did you configure the host name and the user?

Thank you for the reply.I have downloaded the image "fix typo", and burned it with Pi imager. First time i forgot to configure host  (i left it "raspberry" don't know if this is a problem) etc. but then reformatted the card and burned again the image .Result is the same.On Pi zero there is only one LED near camera connector.Think it's bicolor but it's blinking green .
I'll try the image from your link, hope it will work :)

Still not working with Pi Zero ,but I tried with Pi4 and I see a new network .Still not working . Do I have to configure IP address ? Now it's set to automatic

Still not working with Pi Zero ,but I tried with Pi4 and I see a new network .Still not working . Do I have to configure IP address ? Now it's set to automatic

Well the network should be automatic. and did you try to unplug and replug the Pi Zero? I am currently testing this one: https://github.com/Vaneixus/rpi-gadget-image/actions/runs/6521120872

if you want to try, you can manually set the ip address to <IP_ADDRESS>

Still not working with Pi Zero ,but I tried with Pi4 and I see a new network .Still not working . Do I have to configure IP address ? Now it's set to automatic

I just wanted to confirm, the Pi4 is currently able to automatically setup the network, or does it only show you the internet interface? it should show up as no connection, but if you type in hostname.local/vnc/, do you see anything?

Yes i tried unplugging the Pi Zero but no effect.Now on Pi 4  I was entering  wrong host name it's raspberrypi.local instead of raspberry.local. But I get "acccess denied" and I never get any prompt for user name or password.

Now with ticker  cable rated 7 amps seems to be OK

Now with ticker  cable rated 7 amps seems to be OK

that is the Pi zero that started working, correct?

you're getting access denied since you forgot to append /vnc/ or /code/ to
access the web applications.
On Sun., Oct. 15, 2023, 8:24 a.m. nik1977, @.***> wrote:

Yes i tried unplugging the Pi Zero but no effect.Now on Pi 4 I was
entering wrong host name it's raspberrypi.local instead of raspberry.local.
But I get "acccess denied" and I never get any prompt for user name or
password.
—
Reply to this email directly, view it on GitHub
https://github.com/Vaneixus/rpi-gadget-image/issues/1#issuecomment-1763373229,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM5DXGHO7VTKHZ5JGFN6NETX7PIWTAVCNFSM6AAAAAA6APXGB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRTGM3TGMRSHE
.
You are receiving this because you were assigned.Message ID:
@.***>

No  Pi Zero not working, but Pi4 is OK because I would like to use some  USB measurement devices with it.But  /code is not working which is not a problem for me.

No Pi Zero not working, but Pi4 is OK because I would like to use some USB measurement devices with it.But /code is not working which is not a problem for me.

I just wanted some reference, how much time do you wait for the connection to be established? the Pi Zero is a much weaker device, so I am making some assumption that it might be taking some time to be set up. if you're free to do it, can you connect it with a Data+Power cable for 5 minutes and then disconnect it then reconnect? if that does not work, can you try the latest image, I just finished testing it for boot up: https://github.com/Vaneixus/rpi-gadget-image/actions/runs/6521120872
oh, speaking of cables, is the cable you're using is a data + power cable? some cables are power only. could you tell me from where did you get it?

I had another suggestion, but I need to know if you can interact with the pi via a keyboard,mouse and monitor. if yes, I would require that you login, and run the following command: sudo systemctl status multigadget

Hi,
I tried the latest image , waited long time but no success with Pi Zero.Cables I  use are Power and Data.SD card is 32GB could this be the problem?

Hi,
I tried the latest image , waited long time but no success with Pi Zero.Cables I  use are Power and Data.SD card is 32GB could this be the problem?

SD card size isn't a problem. I am currently trying to figure out why it does not work. I will try to compare my code with a known pi zero config and maybe figure something out.

Hi,
I tried the latest image , waited long time but no success with Pi Zero.Cables I  use are Power and Data.SD card is 32GB could this be the problem?

Hello, I just wanted to ask this, which port do you connect the USB cable to? is it the one labeled PWR or USB? if it's PWR try USB, otherwise try the other one.

Hello again! I just tested the latest configuration on a Pi Zero 2, I just confirmed it that it needs to be plugged into the USB port labelled "USB" to get it to work. I tried it with the "PWR IN" port, and it did not work with that one, so, if you're willing to try it and haven't actually tried it yet, can you check if it works with the USB "USB" port?

Hi, I'm using pi zero w 1.1 with the prebuild image and nothing is happening only LED is blinking 7 times and pausing. I'm not sure if i have done things right.I have no experience with linux nor github. May be I'm missing some additional configurations.

Looking back at your comment, I only realised that you gave me the LED count, looking at https://forums.raspberrypi.com/viewtopic.php?t=348482 it seems to be an image write error. Can you tell me if this was still happening?

Yes it still doesn't work.I used the same card on Pi4 and it's fine. Cabe is connected at port labeled USB, tried also PWR but it's only power lines I thing.

Well on the RaspberryPi 4, the USB-C port is PWR by default, but it works due to the changes I make. So I wanted to see if that would be the case. but what's weird is that according to everything thus far, the card you use for RaspberryPi 4 works, but when connected to Pi Zero, you get a no boot partition found error(indicated by the 7 blinks). I will need to investigate this further, but I am hitting a brick wall, may... oh... I think I know why now... the images are all 64bit, the Pi Zero is 32Bits, I will create a special image and I need you to check it out.

@nik1977 I will have a special image ready in 2 hours for you to download and try.

Don't worry.I used to Pi4 and now i find Pi zero almost useless it's so slow.


Spotify: Metadata not getting fetched

So, the song cover isn't changing, I only installed the this visualizer on the Friday after I was done with school. Everything was working just fine at home, but today at school, the cover art and song title isn't changing but the visualizer is still working fine.

Might be a duplicate of #38, check out the solutions there and see if the are working.

Closing due to inactivity.


download: mspider version updated to v0.25-dev-a4d9619a

download: mspider version updated to v0.25-dev-a4d9619a

The version v0.25-dev-a4d9619a is only for test, and this PR will be closed later.

test data


37_text.learner: create docments

Add documents to 37_text.learner.
See the style guide and contribution guide for more details (links will be added when created).
This requires a moderate familiarity with fastai. This notebook defines the components needed for automatically creating text classification and lm learners for a specific task. Also includes show methods for model interpretation.
Documents progress(only one section):

[ ] Loading a pretrained model
[ ] Language modeling predictions
[ ] Learner convenience functions
[ ] Show methods

I will work on this.


feat(#790): Compute MaxStack and MaxLocals For Abstract Methods

In this PR I handle the corner case for max_stack and max_locals computation.
All abstract methods has max_stack==0 and max_locals==0. I added unit tests that cover this problem.
Related to #790.

PR-Codex overview
This PR focuses on enhancing the handling of maximum local variables and stack elements in the BytecodeMethod class. It introduces new methods for testing and updates existing functionality to improve the computation of maximum values.
Detailed summary

Updated max method in InstructionsFlow to return Optional<T>.
Modified MaxLocals to handle empty cases with orElse(new Variables()).
Added tests for implemented and abstract methods in BytecodeMethodTest.
Created MaxInterface with methods for testing local variables and stack elements.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@yegor256 Could you take a look, please?

@rultor merge

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here.

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 10min).


Slider not working if it is in an absolute positioned container

Environment

react-native info output:

Sorry for some reason react-native info is stuck on my system

are you using the new architecture? No

which version of react & react-native are you using?
"react-native": "0.73.1"
"react": "18.2.0",

Description
When the slider is inside an container which has position: absolute; the slider is unresponsive.
Reproducible Demo
import React, {useState} from 'react'
import {View} from 'react-native'

import Slider from '@react-native-community/slider'

export const Test: React.FC = React.memo(() => {
  const [zoom, setZoom] = useState<number>(0)

  return (
    <View style={styles.container}>
      <Slider
        value={zoom}
        onValueChange={setZoom}
        step={0.1}
        minimumValue={-1}
        maximumValue={1}
      />
    </View>
  )
})

export const styles = StyleSheet.create({
  container: {
    position: 'absolute',
    top: 20,
    right: 20,
    flexDirection: 'row',
    gap: 26,
  }
})

export default CameraController

+1

@omerts I was trying to reproduce this, however maybe you are missing some more context cause just putting the slider into absolutely positioned container does not cause issue you have described.
Please provide working reproduction example so I will be able to investigate that.

same problem here


How to generate news sitemap with images, are the images supported in news sitemap ?

Example with images:

https://github.com/ekalinin/sitemap.js#example-of-images-with-captions

No, news do not support images.


e2e: Fix Validate ExcludeTopology test leftover

Fix coding errors introduced while refactoring

https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/451

cc @adrianchiris

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 24.511%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
2082

Relevant Lines:
8494

💛  - Coveralls

@adrianchiris , @SchSeba, unfortunately I left over some errors during my last push on previous PR.
Can you please take a look at this?
Sorry for the inconvenience

@zeeke  can we get some CI results before merging this?

Hi @e0ne, we are working to run this test suite closer to this repository, but we're still hitting some virtualization challenges.
Attached are reports of running make test-e2e-conformance against an OpenShift 4.13 cluster, on master and pr branch, focusing on ExcludeTopology testcases
master.output.txt
master_unit_report.xml.txt
pr.output.txt
pr_unit_report.xml.txt
This PR fixes
• [FAILED] [77.393 seconds]
[sriov] operator Custom SriovNetworkNodePolicy Configuration ExcludeTopology [It] field is forwarded to the device plugin configuration
/home/apanatto/dev/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1444

  [FAILED] Timed out after 30.000s.
  Expected
      <map[string]string | len:2>: {
          "dhcp19-17-171.clus2.t5g.lab.eng.bos.redhat.com": "{\"resourceList\":null}",
          "cnfdd5.clus2.t5g.lab.eng.bos.redhat.com": "{\"resourceList\":[{\"resourceName\":\"resourceXXX\",\"selectors\":{\"pfNames\":[\"eno2np1#0-4\"],\"IsRdma\":false,\"NeedVhostNet\":false},\"SelectorObj\":null}]}",
      }
  to have {key: value} matching
      <map[interface {}]interface {} | len:1>: {
          <string>"cnfdd5.clus2.t5g.lab.eng.bos.redhat.com": <*matchers.ContainSubstringMatcher | 0xc000874ba0>{
              Substr: "{\"resourceName\":\"resourceXXX\",\"excludeTopology\":true,\"selectors\":{\"pfNames\":[\"eno2np1#0-4\"],\"IsRdma\":false,\"NeedVhostNet\":false},\"SelectorObj\":null}",
              Args: nil,
          },
      }
  In [It] at: /home/apanatto/dev/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:2244 @ 08/02/23 10:08:37.741

@zeeke  thanks for the information!


Confirmation URL giving bad arguments

I am using devise_token_auth for my android Application. When user sign_up and a confirmation mail sent to his/her mail-id. On clicking of confirmation mail I am getting this error. Not able to understand where am i doing wrong. Any help would be appreciated. Below is the complete log :-
Started GET "/api/v1/auth/confirmation?confirmation_token=1rsAryEnLgowkirUhsa8" for ::1 at 2015-07-06 12:40:47 +0530
Processing by DeviseTokenAuth::ConfirmationsController#show as HTML
  Parameters: {"confirmation_token"=>"1rsAryEnLgowkirUhsa8"}
  User Load (0.4ms)  SELECT  "users".* FROM "users" WHERE "users"."confirmation_token" = ?  ORDER BY "users"."id" ASC LIMIT 1  [["confirmation_token", "662a4490a99ee838db46638aa61600e64776380da92645d591e8e08ef7493c65"]]
   (0.2ms)  begin transaction
  SQL (0.3ms)  UPDATE "users" SET "confirmation_token" = ?, "confirmed_at" = ?, "updated_at" = ? WHERE "users"."id" = ?  [["confirmation_token", nil], ["confirmed_at", "2015-07-06 07:10:47.314850"], ["updated_at", "2015-07-06 07:10:47.316838"], ["id", 4]]
   (0.6ms)  commit transaction
   (0.3ms)  begin transaction
  SQL (0.9ms)  UPDATE "users" SET "tokens" = ?, "confirmation_token" = ?, "updated_at" = ?  I had generate views using devise which overrides the mailer layout given in devise_auth_token, but then I corrected the mailer layout and everything working fine,


Build from latest swagger revision

I foolishly thought I could pull the upstream changes to resolve some bugs I was hitting in the go SDK and it turns out they did a huge refactor there. I think most of the changes are for the better but it's a huge backwards incompatible change.

LGTM


Jkirkwood/lazy load flag

Use cli command flag to setup where models can be loaded from on-the-fly.

Move PR to use load-on-demand-poc as destination


Example triggers don't seem to work

I have base class similar to Trackable from your examples, but the triggers don't get fired.
    public abstract class DbEntity
    {
        static DbEntity()
        {
            Triggers<DbEntity>.Inserting += e => e.Entity.CreatedAt = e.Entity.UpdatedAt = DateTime.UtcNow;
            Triggers<DbEntity>.Updating += e => e.Entity.UpdatedAt = DateTime.UtcNow;
        }

        public int Id { get; set; }

        public DateTime CreatedAt { get; protected set; }

        public DateTime UpdatedAt { get; protected set; }
    }

Any idea why?

Closing this here, as it belongs to https://github.com/NickStrupat/EntityFramework.Triggers/

What does your context class and calling code look like?

I figured it out, I was not inheriting the correct base class, thanks.


Create Lambda Handler

A lambda event handler needs to be created to process the event invocation from AWS.
Refer to: https://github.com/awsdocs/aws-lambda-developer-guide/blob/main/sample-apps/blank-nodejs/function/index.js as an example.

Don't we have one already?

No, we have lots of helper functions; we need an actual handler...
exports.handler = async function(event, context) {
    // Do the work
}

From in here we then call whatever logic we need for the lambda itself

Oh, sorry, I thought this was the scraper repo...nevermind :/

See https://github.com/Ukraine-Relief-Efforts/scraper-translator/pull/5 includes a basic scaffold for the handler and some organization for any future work needed.

Pretty sure this was fixed by #5, closing


Backend streaming api

I want to change run_storm_wiki_gpt_with_VectorRM.py to a backend api for streaming output, can you tell me which files/places I should change?

A quick pointer: here is the last step in the pipeline. You can trace down to implement streaming support there.


Some strange messages.

MN is running fine and receives payments. However:
`dashman version 0.1.25 (32-g6aabce1) - 2017 / 5 / 5 12:29:47 CEST
gathering info, please wait... No JSON object could be decoded
DONE!
hostname                   : xxx
host uptime/load average   : 62 days, 2.77 2.62 2.62
dashd bind ip address      : xxx.xxx.xxx.xxx
dashd version              : <IP_ADDRESS>
dashd up-to-date           : NO
dashd running              : YES
dashd uptime               : 42 days, 17 hours, 14 mins, 16 secs
dashd responding (rpc)     : YES
dashd listening  (ip)      : YES
dashd connecting (peers)   : YES
dashd port open            : YES
dashd connection count     : 22
dashd blocks synced        : YES
last block (local dashd)   : 664632
(chainz)        : 0
(dash.org)      : 0
(dashwhale)     : 664631
(masternode.me) : 664632 - no forks detected
dashd current difficulty   :<PHONE_NUMBER>837048
masternode started         : YES
masternode visible (local) : YES
masternode visible (ninja) : NO
masternode address         :
masternode funding txn     : -
masternode queue/count     : 448/4441
masternode mnsync state    : MASTERNODE_SYNC_FINISHED
masternode network state   : ENABLED
masternode last payment    : never
masternode balance         : 0
sentinel installed       : YES
sentinel tests passed    : /home/xxx/dashman/lib/dashman_functions.sh: line 1123: [: too many arguments
NO
sentinel crontab enabled : YES
sentinel online          : YES
Exiting.
`

"No JSON object could be decoded
DONE!" it's happening again on an updated server, how do you fix this?
thanks

@Newar417  @fher98
It's a broken DashNinja. No way to fix it, so I removed it.
https://github.com/dotexx/dashman

@dotexx Thank you for working on it! I installed your version and I would like to report an issue, but it seems you  have issue functionality disabled?

@Newar417 By default it's not allowed. Fixed. You are welcome to open an issue.


off is not a function

off is not a function

Are you using webpack or browserify? they do not use the latest version of events yet.


Possible bug with weighted_path_loss

This line looks weird: https://github.com/rosinality/stylegan2-pytorch/blob/master/train.py#L253
Why would you need to multiply the term by zero?

It is to trigger gradient all_reduce hook of the distributed data parallel. It will be not triggered when you use backward with the loss computed solely using gradients. (autograd.grad) Maybe it is changed in the recent versions of pytorch.


Expose GEOSNormalize

GEOSNormalize_r is the C API for Geometry::normalize, which reorganizes geometries into 'canonical forms': points in a LineString may be deduplicated, members of a collection are sorted by type, points in a polygon's rings or a single LinearRing start at the top-left-most point and go clockwise, etc. This can be useful for unit testing or geometry deduplication. This was added in libgeos 3.0.0.
I tried to add the method myself but I never really played with ctypes, so this was mostly playing around, and I always got -1 (exception). This method updates the geometry in place and I am not sure if this is a good thing; pygeos implemented a wrapper that clones before normalizing.
Note that the LineString::normalize implementation has a bug in which the first point of a LinearRing was not the top-left-most point. It was fixed in this commit, which is not included in any release yet (probably will be in libgeos 3.9.0). The workaround is to create a polygon using the LinearRing as an exterior ring, normalize the polygon, and get the ring back. Assuming normalize would be added to Shapely, we would get something like this:
>>> list(Polygon(((8, 8), (8, 5), (8, 5), (5, 5), (5, 8))).normalize().exterior.coords)
[(8, 8), (8, 5), (5, 5), (5, 8), (8, 8)]
>>> list(LinearRing(((8, 8), (8, 5), (8, 5), (5, 5), (5, 8))).normalize().coords)
[(5, 5), (5, 8), (8, 8), (8, 5), (5, 5)]

Yes, I have a branch where I was trying to implement normalize and hit a roadblock, I think the same one as you. I never really followed up but I'd love to understand better what's going on as it's blocking an improvement to simplify in #889.

Note that by having this already exposed in pygeos, it will be included in Shapely 2.0 (and so should work on shapely geometries in my branch at https://github.com/Toblerity/Shapely/pull/983). One that PR lands, a PR to add it as a method on the Geometry classes would also be very welcome!
Having it also for the next Shapely 1.8 release would also be nice of course.

I experimented further and tried to understand the way GEOS error handling works, since it's in C++ and there are actual exceptions, not just -1. errorMessageNew is called here when an error occurs in many of the functions, including GEOSNormalize_r, so this should in theory be caught and sent to the shapely.geos logger. However, no matter how hard I tried, I couldn't get anything to be logged to it, even something completely unrelated to GEOSNormalize.
@jorisvandenbossche I saw some comments in #983 about error logging, so that might be related? Your recent comment about GEOSProject mentions the same type of error handling as GEOSNormalize.

@Lucidiot in the end, I was actually mistaken about the error handling in GEOSProject. It was using the normal error handling machinery, but it with a different return value that signals the exception (and that is still something to check in Shapely which return value triggers error checking.

Given the overlay changes in GEOS 3.9 (and the need for normalize to get comparable results for GEOS < 3.9), it might be good to still expose normalize in Shapely 1.8.
Do we want to add this as a method on the geometry classes? Or as a function in one of the submodules (not directly sure which one would be most fitting. shapely.ops ?)

Given the overlay changes in GEOS 3.9 (and the need for normalize to get comparable results for GEOS < 3.9), it might be good to still expose normalize in Shapely 1.8.
Do we want to add this as a method on the geometry classes? Or as a function in one of the submodules (not directly sure which one would be most fitting. shapely.ops ?)

I personally like it as a method on the geometry classes, as there's precedence with other unary topological ops like simplify, buffer, etc. That's where I would look for it as a user of Shapely.

I personally like it as a method on the geometry classes, as there's precedence with other unary topological ops like simplify, buffer, etc. That's where I would look for it as a user of Shapely.

I took this off the 1.8 milestone. Let's save it for 2.0.

@sgillies I have an open PR that is ready to merge targetting Shapely 1.8.
I think it is very useful to add, since with GEOS 3.9 overlay changes you need normalize to compare results across GEOS versions (and I also already did the work :-))

->  #1090

I'd like this back on the 1.8 milestone too, as it's ready to merge. GEOSNormalize_r has been part of the C API for a very long time (more than a decade?)


static_water.specular has an unknown crashing error

As I noted in #104, there is a crashing element and I've traced it back to a material. I didn't catch anything out of the ordinary with the material (it was directly copied from a working static_water material on a different map) or the mesh, so maybe it's somehow conflicting with real water? Nevertheless it crashes the game the moment it's supposed to be drawn. There's no real 'error' to name either, as far as the interface editor is concerned, the material is a fully working one... offscreen, that is.

I just posted a new release with logging for when a shader can't be found that a custom material is asking for. If that is the cause of the crash it'll still (appear to) crash but in shader patch.log there should be a final entry detailing the shader that was being asked for and was missing.
Whenever you get the time if you could grab the new release, get the game to crash from this issue and then report back with the shader patch.log, that'd be great. Hopefully this will help give us a solid idea as to what the problem is.

[ERROR]   09:30:45 Failed to find shader state 'unlit transparent' for material shader 'static_water.specular'!
That's what it's saying. Strange, to say the least - I'd have expected something like that to be a universal issue and not just one map.

I've added a possible fix for this to the latest stable release. Let me know how it goes or if you encounter any similar crashes.

Yeah it doesn't crash anymore. I suppose the original conflict might have been that the stock material had the emissive flag (which I don't understand why but ok) but nevertheless that problem is gone.


Fix F26Dot6-conversion (rounding issue)

Fixes https://github.com/jwilm/alacritty/issues/2780.

Rendered (Hack, 9.5pt):

Would you mind sharing a screenshot on how things are getting underlined before your patch and after, with the next small test suit?
echo -e "\e[4mhelp ggg\e[0m"

@kchibisov Well there is no test-suite, I've just taken screenshot and zoomed/cropped them together. Also about the underline thing, there is no difference when I compared both rendered text (the underline is positioned the same as before).

@cynecx I gave you an escape that underlines a text, probably suit was a bad word here, and I should use case instead. Executing the line I gave you looks like this (see underline)

However I was confused by your picture, since it's not really a screenshot (it's a screenshot + your captures).
I don't see much difference at all on my system though, however I'm using hidpi screen, so fonts are always looking fine for me.
Anyway, if we decide to go with some approach, I'd rather choose a more common one (cairo), since ceil doesn't make much sense to me honestly.

Left: This PR; Right: Master (You can notice the subtle difference, that the height is shorter by a pixel.)

I don't see much difference at all on my system though, however I'm using hidpi screen, so fonts are always looking fine for me.

Yes, that's probably it, I don't see any issues on my macbook pro (with retina) either.

Anyway, if we decide to go with some approach, I'd rather choose a more common one (cairo), since ceil doesn't make much sense to me honestly.

This PR should do what cairo is basically doing, however as @chrisduerr was saying, maybe we are just shifting this issue to somewhere else. I am not really an expert in this kind of area, so I can't really say.

Just as a side note: Further research has also shown that Chromium & Co. which are using skia for 2d rendering, are also using alacritty's master semantics:
https://github.com/google/skia/blob/master/src/ports/SkFontHost_FreeType.cpp#L957
src/core/SkFDot6.h
64:#define SkScalarToFDot6(x)  (SkFDot6)((x) * 64)

However, I am able to specify the font-size in multiple formats (pt, px, ...), so setting the font-size to "12.5px" got me the same result as the rounding approach with "9.5pt".
Reproduced with Chromium 78 (skia rendering enabled):
<!DOCTYPE html>
<html>
<head>
	<meta charset="utf-8">
	<title>Test Code</title>
	<style>
		body {
			background-color: #404552;
		}
		code {
		  font-family: "Hack";
		  font-size: 12.5px;
		  font-weight: bold;
		  color: #F58E8E;
		}
</style>
</head>
<body>
	<code>
		bldi
	</code>
</body>
</html>

One of the issues might be that we're scaling by DPI, so we're not just taking the size and forwarding it directly. So it's possible that passing a font size like 13.333333334 is what is creating issues and the fonts are not designed to handle that nicely. However I don't really know enough about creating fonts to judge this.
But generally if we round the size before passing it to the 26.6 format conversion function, it should disable subpixel shenanigans. Could you try if that fixes it for you too @cynecx?

@chrisduerr Changed:
to_freetype_26_6(size)

to
to_freetype_26_6(size.round())

And yes that fixes this issue too.

@chrisduerr How would you like to proceed?

How would you like to proceed?

That's a very good question. I have zero confidence that any of the approaches taken so far will improve anything in general, so I don't think there's any point in merging things in the current state. Changing things around to a different wrong isn't going to help anyone.
I think we should try to find some definite source of truth here as to how this should be handled. I'd be surprised if rounding the result of the 26.6 conversion would be the answer, but to confirm that rounding our input font is reasonable we'd have to verify other applications are doing the same and currently it does not look like that.
So I think the best way forward would be to check what other terminal emulators are doing and if their font sizes are ever uneven the way ours are.