The conditions with multiple same condition intermittently doesn't fail when one of the conditions fails

Expected Behavior
When one of the condition in the conditions in pipeline fails, the task associated with the conditions is not executed.
Actual Behavior
When one of the condition in the conditions in pipeline fails, the task associated with the conditions is intermittently  executed.
This happens intermittently if the conditions has multiple conditions referencing the same condition.
Steps to Reproduce the Problem

create condition / task / pipeline

apiVersion: tekton.dev/v1alpha1
kind: Condition
metadata:
  name: is-equal
  namespace: tekton-pipelines
spec:
  params:
  - name: left
    type: string
  - name: right
    type: string
  check:
    image: alpine
    script: |
      #!/bin/sh
      if [ $(params.left) = $(params.right) ]; then
        echo "$(params.left) == $(params.right)"
        exit 0
      else
        echo "$(params.left) != $(params.right)"
        exit 1
      fi
---

apiVersion: tekton.dev/v1alpha1
kind: Pipeline
metadata:
  name: issue-pipeline
  namespace: tekton-pipelines
spec:
  params:
  - name: one
    type: string
  - name: two
    type: string
  tasks:
  - name: process
    conditions:
    - conditionRef: is-equal
      params:
       - name: left
         value: "1"
       - name: right
         value: $(params.one)
    - conditionRef: is-equal
      params:
       - name: left
         value: "1"
       - name: right
         value: $(params.two)
    taskRef:
      kind: Task
      name: run

---
apiVersion: tekton.dev/v1alpha1
kind: Task
metadata:
  name: run
  namespace: tekton-pipelines
spec:
  steps:
    - name: echo
      image: ubuntu
      script: 'echo hello'

execute the following pipelineruns in the random order.

apiVersion: tekton.dev/v1alpha1
kind: PipelineRun
metadata:
  name: issue1-pipelinerun
  namespace: tekton-pipelines
spec:
  params:
  - name: one
    value: "1"
  - name: two
    value: "1"
  pipelineRef:
    name: issue-pipeline

apiVersion: tekton.dev/v1alpha1
kind: PipelineRun
metadata:
  name: issue2-pipelinerun
  namespace: tekton-pipelines
spec:
  params:
  - name: one
    value: "2"
  - name: two
    value: "1"
  pipelineRef:
    name: issue-pipeline

apiVersion: tekton.dev/v1alpha1
kind: PipelineRun
metadata:
  name: issue3-pipelinerun
  namespace: tekton-pipelines
spec:
  params:
  - name: one
    value: "1"
  - name: two
    value: "2"
  pipelineRef:
    name: issue-pipeline

The run task is intermittently executed for issuerun2 or issuerun3

Additional Info
This issue is probably caused by:
ConditionCheckName is used as the key in ConditionChecks map  in PipelineRunTaskRunStatus.  The ConditionCheckName is same for the conditions referring the same condition.

@akihikokuroda
I think you are right, since there is no name in PipelineTaskCondition so the ConditionRef treated as key.
Since the link between pipelinerun and taskrun for condition should be build for reconcile, so the ConditionRef is the only choice.
I think we need add name or just document it.
/cc @dibyom

Yeah, this sounds like something that should work but doesn't so marking it as
/kind bug

@akihikokuroda @dibyom is this still an issue ?

The linked PR fixed it.
/close


Is the mask applied to the frame after the frame it was generated from?

Pseudocode:
Thread:

acquire lock
process input
write mask
release lock

Main:

acquire lock
send current frame
read mask
apply to current frame
release lock

Since the frame is sent and the mask is read out during the same lock period, doesn't that mean that the mask belongs to the previous frame? So if something is moving on the screen, the mask will lag one frame behind it? Is my understanding correct?

I chose to run mask generation on a separate thread, as some more complex models do not run at video frame rates, hence the logic you have summarised above to decouple the processing rates. For models that can run at frame rates, then yes, this results in a 1-frame lag, it's a compromise to keep the video frame rate correct (or OBS throws a fit!)
We do similar in the main backscrub app too.

This will still be limited to the speed of the worker thread though right? It just buys the worker until the next frame arrives to finish processing the current one. If it can only do say 15 fps and the incoming feed is 60 fps, frames will still back up, because there is no mechanism for the main thread to skip a frame if the worker is busy?

Ah no, ignore that, it unlocks while actually processing a copy of the frame.

@ali1234 - any objection to closing this?


Add instrumentation feature flag to daemon-tests

otel-tests crate requiring grpc-sys greatly increased our build times on CI (where we don't even use it!)
it can even be enabled by default in itchysats for devs convenience (we use incremental compile there, so it shouldn't matter), as long as we override and not compile stuff we don't use in the CI runs and release builds.

screenshot of cargo build --timings result:

Just to check, are tests still run with --all-features? This would lead to a new instrumentation feature still being enabled

Just to check, are tests still run with --all-features? This would lead to a new instrumentation feature still being enabled

they don't; they run with default features right now.


Timeout Waiting For Response

Hi!
Your library is very simple and easy to use, I have been searching to find a simple on like that!
I have a problem that the AT+CWJAP=.. command (wifi.setupAsWifiStation(ESP8266_SSID, ESP8266_PASS, &Serial);) shows me "Timeout Waiting For Response" error before actual connecting nu merous times. Is there a way to increase the timeout milliseconds?
Thanks,
Panos

Hi, you can use
wifi.setTimeout( [number of seconds] );
example
wifi.setTimeout(10);
On 2015-09-02 08:32, Panos B wrote:

Hi!
Your library is very simple and easy to use, I have been searching to find a simple on like that!
I have a problem that the AT+CWJAP=.. command (wifi.setupAsWifiStation(ESP8266_SSID, ESP8266_PASS, &Serial);) shows me "Timeout Waiting For Response" error before actual connecting nu merous times. Is there a way to increase the timeout milliseconds?
Thanks,
Panos
--
Reply to this email directly or view it on GitHub [1].

Links:
[1] https://github.com/sleemanj/ESP8266_Simple/issues/8

Thanks a lot! Should have known :-D


Change the order in IDP getting started

Catalog -> Plugins -> Scorecards -> Workflows

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://660d32f8721219c92c2cc51d--harness-developer.netlify.app


wrong annotation in Fluid.Dissipation

Reported by mwetter on 19 Sep 2016 21:52 UTC
In Modelica.Fluid.Dissipation, the annotation
      record kc_turbulent_IN_con
        "Input record for function kc_turbulent and kc_turbulent_KC"
        extends Utilities.Records.HeatTransfer.StraightPipe;

        Modelica.Fluid.Dissipation.Utilities.Types.Roughness roughness=Dissipation.Utilities.Types.Roughness.Considered
          "Choice of considering surface roughness"
          annotation (Dialog(group="Choices"));

        SI.Length K=0 "Roughness (average height of surface asperities)" annotation (
            Dialog(group="Straight pipe",
  enable=roughness == Modelica.Fluid.Dissipation.Utilities.Types.Roughness.considered));
...

should be
...
  enable=roughness == Modelica.Fluid.Dissipation.Utilities.Types.Roughness.Considered));
...

Note the lower-case considered rather than the upper-case Considered.
This error causes the following test to fail in Dymola 2017 FD01 beta 2 when using the pedantic model check:
model Test
  parameter Modelica.Fluid.Dissipation.HeatTransfer.StraightPipe.kc_overall_IN_con kc
# Modelica.Fluid.Dissipation.HeatTransfer.StraightPipe.kc_overall_IN_con();
end Test;

Migrated-From: https://trac.modelica.org/Modelica/ticket/2066

Comment by hansolsson on 20 Sep 2016 07:42 UTC
See also #2003 and #2004
I don't know why I missed this at the time.

Modified by beutlich on 18 Oct 2016 12:29 UTC

Comment by wischhusen on 25 Oct 2016 11:28 UTC
Resolved with b507636855bbf8289bbd2b05e3397c4b1aa740e3, 04a39c5d5a7923e6bafd13540797ef82404679fb and dfed1107f7253d55edd2364ae4389bf905289bbb.

Changelog modified by wischhusen on 25 Oct 2016 11:28 UTC
Corrected enable annotation for parameter. Trunk and Maintenance 3.2 and 3.2.1

Comment by wischhusen on 25 Oct 2016 11:37 UTC
c47b9abfe525df6611179630817dd9efa594c281

Changelog modified by wischhusen on 25 Oct 2016 11:37 UTC
Corrected enable annotation for parameter. Trunk and Maintenance 3.2 and 3.2.1 and 3.2.2


Build Badges

Added build badges and some docs for schemas.

Codecov Report

Merging #16 (55eda9b) into main (960f5d8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage   91.91%   91.91%
=======================================
  Files          36       36
  Lines        1460     1460
=======================================
  Hits         1342     1342
  Misses        118      118

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 960f5d8...55eda9b. Read the comment docs.


Exit program if condition is met

Conditions which cause the program to fail:

[x] Arg is not an integer
[x] Duplicate args
[ ] Arg is not within the INT_MIN/INT_MAX boundary

#7


Detach option has moved

I had a customer today contact in because the detach option was unavailable to him following this documentation. I had the same experience. It appears the detach option has moved.
Detach can now be found from
VM > Disks > Edit >Scroll over on the data disk list and click the detach icon
Thank you!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d78385db-23e4-0471-6d03-262ac6c73407
Version Independent ID: d2ebdfb2-5f43-8bdc-fdb4-01948a275681
Content: Attach or detach a data disk to a virtual machine in Azure DevTest Labs
Content Source: articles/lab-services/devtest-lab-attach-detach-data-disk.md
Service: lab-services
GitHub Login: @spelluru
Microsoft Alias: spelluru

@jlmace Thank you for bringing this to our attention, we will further validate and get back to you at the earliest.

@jlmace Would you mind giving me a little more information about your repro?  I was able to see the detach option in both of the paths outlined in the documentation:

Lab Resource > VM > Settings / Disks > Data Disks / AttachedDataDiskName > Detach

Lab Resource > My Lab / My data disks > AttachedDataDiskName > Right click / . . . > Detach

@jlmace We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


Fixed "Resource Not found" error in chat profile picture

Removed extra '/' which causes the error.

Thanks for sharing. The project is abandoned so I don't think this PR will be merged. At least others can find it!


Q&M: Fix broken links identified by the Broken links report - fix three XML files

Hi @cmastr, @Rick-Anderson, @wadepickett, @tdykstra I have fixed the broken links, please verify, thanks。
https://dev.azure.com/msft-skilling/Content/_workitems/edit/335393/?view=edit

I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"
Thanks
Daidi Huang
C+E Skilling - Pubdesk - Beyondsoft Team
Team Email<EMAIL_ADDRESS>| Service Hour: 8:00 – 17:00 PST
C+E Skilling Publishing Desk Servicehttps://review.docs.microsoft.com/en-us/content-production-service/topics/pubdesk-documentation/pubdesk-internal/?branch=main

From: dotnet-policy-service[bot] @.>
Sent: Tuesday, November 5, 2024 3:53 AM
To: dotnet/AspNetApiDocs @.>
Cc: Dai di Huang (BEYONDSOFT CONSULTING INC) @.>; Mention @.>
Subject: Re: [dotnet/AspNetApiDocs] Q&M: Fix broken links identified by the Broken links report - fix three XML files (PR #283)
@Daidihuanghttps://github.com/Daidihuang please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@dotnet-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@dotnet-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@dotnet-policy-service agree company="Microsoft"
Contributor License Agreement
Contribution License Agreement
This Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ),
and conveys certain license rights to the .NET Foundation ( “.NET Foundation” ) for Your contributions to
.NET Foundation open source projects. This Agreement is effective as of the latest signature date below.

Definitions.

“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to .NET Foundation under this Agreement.
“Project” means any of the projects owned or managed by .NET Foundation and offered under a license
approved by the Open Source Initiative (www.opensource.orghttp://www.opensource.org/).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.

Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.

Originality of Work. You represent that each of Your Submissions is entirely Your
original work. Should You wish to Submit materials that are not Your original work,
You may Submit them separately to the Project if You (a) retain all copyright and
license information that was in the materials as you received them, (b) in the
description accompanying your Submission, include the phrase "Submission
containing materials of a third party:" followed by the names of the third party and any
licenses or other restrictions of which You are aware, and (c) follow any other
instructions in the Project's written guidelines concerning Submissions.

Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.

Licenses.

a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly
or indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable
license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform,
and distribute the Submission and such derivative works, and to sublicense any or all of the foregoing
rights to third parties.
b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or
indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license
under Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3 ). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6 , THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.

Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or
circumstances of which You later become aware that would make Your representations in this
Agreement inaccurate in any respect.

Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.

Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.

Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by .NET Foundation.

.NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1.
—
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/AspNetApiDocs/pull/283#issuecomment-2455577357, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BHSC3RK2SMBOD4EUMAWN4BDZ67GEXAVCNFSM6AAAAABRE74AV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJVGU3TOMZVG4.
You are receiving this because you were mentioned.Message ID: @.***>

Hi @Rick-Anderson would you please review this PR, thanks in advance!

@Rick-Anderson I have removed the version query string, please review.

See the Readme file
API PR's ( api/autoapi/... ) should NOT be made here. Changes to API documentation should be made in the source repository against the triple slash /// comments.


MiFlora does not clear cache

I had issues with the MiFlora component not working, but not sure if its common knowledge MiFlora cache readings, and if this is not cleared they go full and stop reporting. I had to install the native app, sync them, and then they work in HA again.
How can we get HA to clear the cache on the sticks?

I was not aware of this problem. I've been using mit for > 1 year only with miflora and not deleting the cached data at all.
Which versions do you have? How long have you been using them?
There is a PR for the miflora library to support reading the sensor history. So the logic for deleting the cache is there, but it probably needs to be re-wired for that usecase.
So how often do we need to do this?

@alekslyse :
Which firmware is your MiFlora devices?

@alekslyse :
Which firmware have your MiFlora devices?

After som investionation I found the teller, even labeling them international selling me chinese version (MAC with  C4:7C.......) - I dont know if its the chinese version that is the source of this behaviour?

They all have firmware 3.2.1 in the "Flower Care" app

Hmm, I do not have one of those, so I can't test it right now.
All of my devices' MAC start with C4:7C:...
AFAIK the only difference between the "Chinese" and "International" versions (except for the price) is that the smartphone app does not work with the Chinese models outside of China.

From what I know if they start with C4 they are not internetional. I
ordered a new set from another vendor so lets see if its any difference.
Regardless I never made the soil humidiity work
On Mon, Jun 10, 2019 at 4:26 PM ChristianKuehnel<EMAIL_ADDRESS>wrote:

Hmm, I do not have one of those, so I can't test it right now.
All of my devices' MAC start with C4:7C:...
AFAIK the only difference between the "Chinese" and "International"
versions (except for the price) is that the smartphone app does not work
with the Chinese models outside of China.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/issues/24387?email_source=notifications&email_token=AA4CDR4XFFLSN2V5A45F6GDPZZP7VA5CNFSM4HV5H2PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXKAYAI#issuecomment-500435969,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4CDR7Z2QDRKOGLNQKMUUTPZZP7VANCNFSM4HV5H2PA
.


a8ee312, All pokemon appear as VIP

In latest update, a8ee312.
it seem all pokemon appears will be vip.

Hey, Pjumpod. We meet again :)
Yes, second that. I have very important pidgeys and rattattas as well :)
[2016-09-16 10:47:29] [MoveToFort] [INFO] Moving towards pokestop Public Clock - 0.10km
[2016-09-16 10:47:35] [MoveToFort] [INFO] Moving towards pokestop Public Clock - 0.07km
[2016-09-16 10:47:36] [PokemonCatchWorker] [INFO] A wild Rattata appeared! (CP: 186) (NCP: 0.32) (Potential 0.84) (A/D/S 8/15/15)
[2016-09-16 10:47:39] [PokemonCatchWorker] [INFO] This is a VIP pokemon. Catch!!!
[2016-09-16 10:47:44] [PokemonCatchWorker] [INFO] Threw a Razz Berry! Catch rate with Pokeball is now: 64.82
[2016-09-16 10:47:53] [PokemonCatchWorker] [INFO] OK throw! Used Ultraball, with chance 101.63 (98 left)
[2016-09-16 10:47:54] [PokemonCatchWorker] [INFO] Captured Rattata! [CP 186] [NCP 0.32] [Potential 0.84] [8/15/15] (404/800) [+100 exp] [+100 stardust]
[2016-09-16 10:47:54] [PokemonCatchWorker] [INFO] You now have 7 Rattata candy!
[2016-09-16 10:47:59] [RecycleItems] [INFO] Forcing item recycle based on schedule
[2016-09-16 10:47:59] [RecycleItems] [INFO] Next forced item recycle at 10:50:12
[2016-09-16 10:48:15] [ItemRecycler] [INFO] Discarded 1x Max Potion.
[2016-09-16 10:48:20] [ItemRecycler] [INFO] Discarded 1x Revive.
[2016-09-16 10:48:20] [MoveToFort] [INFO] Moving towards pokestop Public Clock - 0.07km
[2016-09-16 10:48:21] [IncubateEggs] [INFO] Eggs incubating: [1.70/5.0 km] (Eggs left: 8, Incubating: 1)
[2016-09-16 10:48:21] [PokemonCatchWorker] [INFO] A wild Rattata appeared! (CP: 111) (NCP: 0.19) (Potential 0.47) (A/D/S 10/6/5)
[2016-09-16 10:48:24] [PokemonCatchWorker] [INFO] This is a VIP pokemon. Catch!!!
[2016-09-16 10:48:28] [PokemonCatchWorker] [INFO] Threw a Razz Berry! Catch rate with Pokeball is now: 79.95
[2016-09-16 10:48:37] [PokemonCatchWorker] [INFO] Nice Curveball throw! Used Greatball, with chance 102.13 (39 left)

I can confirm this

I think the same cause has broken Telegram, not getting any messages anymore 👍
"alert_catch": {
"all": {"operator": "and", "cp": 100, "iv": 0.2},
"Pidgey": {"operator": "and", "cp": 900, "iv": 0.9}
}

I think so.

I try "any" in vip and work.
between, I see "release_below_iv" is not work as well.
maybe the problem cause on iv handling.
I will open another issue about "release_below_iv" for tracking.

I think error is in: ./pokemongo_bot/cell_workers/pokemon_catch_worker.py, line 302
    catch_results['fa'] = ( len(pokemon_config.get('fast_attack', [])) == 0 or unicode(pokemon.fast_attack) in map(lambda x: unicode(x), pokemon_config.get('fast_attack', [])))
    catch_results['ca'] = ( len(pokemon_config.get('charged_attack', [])) == 0 or unicode(pokemon.charged_attack) in map(lambda x: unicode(x), pokemon_config.get('charged_attack', [])))

They are always True because if not setted are comparing len of a void list and zero, len([]) == 0, it is True.
Then in returning ./pokemongo_bot/cell_workers/pokemon_catch_worker.py, line 318:
    if LOGIC_TO_FUNCTION[pokemon_config.get('logic', default_logic)](*cr.values()):
        return catch_results['fa'] and catch_results['ca']
    else:
        return False

If condictiong is satisfied this func retrun the comp against fa and ca.
They are in function _pokemon_matches_config that is called by _is_vip_pokemon when not any explicit name.
return self._pokemon_matches_config(self.bot.config.vips, pokemon, default_logic='or')
So, yes the any cause this beaviors but there error in ca e fa.

The new update allows you to identify the vips pokemon on type attack also.
But in my opinion it does incorrectly.
To restore the old behavior should be enough:
In ./pokemongo_bot/cell_workers/pokemon_catch_worker.py line 318:
    if LOGIC_TO_FUNCTION[pokemon_config.get('logic', default_logic)](*cr.values()):
        return catch_results['fa'] and catch_results['ca']
    else:
        return False

Simply do:
return LOGIC_TO_FUNCTION[pokemon_config.get('logic', default_logic)](*catch_results.values())

(Ignoring check on attack type.)
This should fix all vips, waiting to see how to set up control over the type of attack.
But I need a trial account and unfortunately I know very little about the game.
I need to investigate.

The same issue was raised in #5457.

PR submitted to fix this


Uninstall

Thanks, I don't need this now, how can I uninstall?

Dear Steve,
No problem. I just programmed an uninstaller for the workaround. You can get it by downloading the new version.
May I ask why you don't need the work around anymore?
Is it not working like expected or do you want me to add some changes?
Tip: I changed the shortcut keys to a and s because they are more convenient to me this can be easily done. I can create a menu where you can input your own short keys as well if you like.
Thanks in advance,
Greetings,
Rick,

thanks, not using todoist any more.

Thanks for the feedback!


Fix LGTM Warnings

Description
Fix warnings reported by LGTM in tests and docs.
How Has This Been Tested?
LGTM report review (also the tests and docs part)
Process
I know the process and did my best to follow it

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@1edfbd0). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage        ?   91.04%
=======================================
  Files           ?       32
  Lines           ?     1852
  Branches        ?        0
=======================================
  Hits            ?     1686
  Misses          ?      166
  Partials        ?        0

Pull Request Test Coverage Report for Build 919

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 916:
0.0%

Covered Lines:
1852

Relevant Lines:
1852

💛  - Coveralls


Tern not autocompleting node modules

I've installed tern and am using it in emacs (I've installed and configured the tern package and company-tern), and I've created a .tern-project file:
 { "plugins": {     "node": {}     } }
However, when I'm editing I tern does not recognize any of the packages I've installed through npm. Am I doing anything wrong? I've read through the documentation and similar issues but I haven't found a fix for my issue.

Maybe you are looking for another plugin callednode_resolve.
Which help tern resolves npm modules.

Maybe you are looking for another plugin called node_resolve.
Which help tern resolves npm modules.

The manual states that node_resolve' is loaded already by the node` plugin.
From the manual:

Node.js plugin
The node.js plugin, called "node", provides variables that are part of the node environment, such as process and __dirname, and loads the commonjs and node_resolve plugins to allow node-style module loading.


Automatically redirect from redirect pages

One option would be to add &redirects=1 into the call to Wikipedia (in client/reactComponents/WikiPage.js, line 35). That causes "/Royal_Tyrrell_Museum" to display the content from "/Royal_Tyrrell_Museum_of_Palaeontology" and "/Therapod" to "/Therapoda". So that would seem like a quick fix, as long as it's not important to you to have a true redirect in the sense of updating the URL.


Add performance test for tsvd

Add performance unit test for tsvd, which will compare h2o4gpu and sklearns randomized algorithm in terms of timing

This is a good start but we'll need something a bit more automated - either assertions in the test (which might be tricky to get right, if there's a CPU/GPU hiccup a test might randomly fail) or a way to visualize the results (like Kibana, that everyone could see and check from time to time). Otherwise, we'll probably never look at those again.
I wanted to make something generic last week but am working now on improving the C++ testing framework so if anyone has some spare time that would be a great thing to implement.

make testperf is automated, just need to inject results into something lika kibana.  It's a github issue already.  Evwrything test we do should have a normal mode and a perf mode

There are assertions in the test now. I think initially it’s fine. We can always hook it up to some visualization. Maybe not Kibana, but something lightweight.


DOC-2391: Add FG SMP 12/21/22 v77622 relnotes

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[x] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)
DOC-2391

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Preview environment: https://ci.pr.harness.io/pr-255

Hi Deepak.
Thanks for having a look. I'll have a look at and respond to your comments
later. Because the notes were already published to HelpDocs with PM
approval, because there is always great interest in getting the release
notes out ASAP, and because the SMP notes include notes written by others,
I didn't expect an overall editorial review. Also, some of the items. you
mention, like the format issues in the older notes, are because the tables
broke when others migrated the content. I hoped to get the new notes out
there in the correct format quickly, to push down the older formatting and
other migration issues until I had a chance to clean them up.
The way the SMP notes have been done, since they are voluminous and come
from varying modules, has been to see if any particular summary has already
been written/edited/used in other notes, and to copy that into the SMP
notes. It makes sense that we might want to leave the responsibility for
the note with the writer for the subject area, in part to ensure that the
notes published in different sets of notes match. I hoped we would automate
the generation of the notes to the portal in a useful, searchable
format, and that would allow for a note to be edited one time and placed
automatically and ensure consistency. It would eliminate a lot of the
issues we're having.
Re the last issue, it looks like an auto-correct issue that I'll
definitely fix. "Research" should be "reach." I don't think it would be
anthropomorphic if it were not a typo since machines do search and research
is akin to that.
I'll look at the other comments.
Thanks.
k.
On Wed, Dec 28, 2022 at 6:52 AM Deepak Bolangady @.***>
wrote:

EXTERNAL EMAIL - Use caution when opening attachments, clicking links,
or responding.
@.**** requested changes on this pull request.
Hi, Katherine. I started giving feedback and learned about half the way
through that I should focus on the DEL release notes. I should have known
earlier. I have added comments to other entries too. If you can incorporate
them, great! Otherwise, please look at the DEL ones only.
The guidelines for enhancements and new features recommend a summary with
Jira ticket details and then a description of the benefits. If updated
documentation is available, we should include a reference. I understand
that a number of tickets here are not DEL, so that might be a challenge. We
should look to resolve this, one way or another, before the next SMP
release.
I also noticed that release notes from Oct 31 and earlier have empty table
headers. It's not a priority, but I thought I'll add a note here.
In docs/first-gen/firstgen-release-notes/harness-on-prem-release-notes.md
https://github.com/harness/developer-hub/pull/255#discussion_r1058091760
:

@@ -12,6 +12,73 @@ This document contains release notes for Harness Self-Managed Enterprise Edition

For Harness SaaS release notes, see Harness SaaS Release Notes.Release notes are displayed with the most recent release first.
+### December 21, 2022, version 77622

+Delegate: 77621

+Important information about KOTS admin console
Hi, Katherine. "KOTS admin console" needs an article before it because we
are describing a specific admin console by using "KOTS" as a determiner. I
spent some time online to determine whether "a" and "c" needed uppercase
treatment and, by consequence, whether that was the reason we were not
using an article. Looks like we should use lowercase and that make me think
we need "the." Thanks.
In docs/first-gen/firstgen-release-notes/harness-on-prem-release-notes.md
https://github.com/harness/developer-hub/pull/255#discussion_r1058098824
:

@@ -12,6 +12,73 @@ This document contains release notes for Harness Self-Managed Enterprise Edition

For Harness SaaS release notes, see Harness SaaS Release Notes.Release notes are displayed with the most recent release first.
+### December 21, 2022, version 77622

+Delegate: 77621

+Important information about KOTS admin console
Can we replace this title with a Markdown admonition type--one of the
types described here?
https://docusaurus.io/docs/markdown-features/admonitions
https://docusaurus.io/docs/markdown-features/admonitions
Reason: it's good to standardize how we call a user's attention to
important text.
We can still insert an appropriate title in your choice of admonition
(note or info), if you feel one is necessary. The article I referenced here
has the info you need. Thanks.
In docs/first-gen/firstgen-release-notes/harness-on-prem-release-notes.md
https://github.com/harness/developer-hub/pull/255#discussion_r1058136757
:

+Important information about KOTS admin console

+This release of Harness Self-Managed Enterprise Edition requires KOTS admin console 1.88.0. You must upgrade KOTS before you deploy this Harness release. Use the following commands:

+```
+curl https://kots.io/install/1.88.0 https://kots.io/install/1.88.0 | bash
+kubectl kots admin-console upgrade -n
+```

+#### New features and enhancements

+This release introduces the following features and enhancements.

+| Feature or enhancement | Description |
+| --- | --- |
+| CDS-40179 | Added reconciliation for looker entities to ensure data synchronization between mongoDB and timescaleDB. |

If "looker" here refers to Looker, the data analytics platform,
should we init-cap the name? Regardless, is there a reason for marking it
up as code in Markdown?
Can we reword the description so that it describes how the
enhancement benefits the user?

In docs/first-gen/firstgen-release-notes/harness-on-prem-release-notes.md
https://github.com/harness/developer-hub/pull/255#discussion_r1058193344
:

+This release of Harness Self-Managed Enterprise Edition requires KOTS admin console 1.88.0. You must upgrade KOTS before you deploy this Harness release. Use the following commands:

+```
+curl https://kots.io/install/1.88.0 https://kots.io/install/1.88.0 | bash
+kubectl kots admin-console upgrade -n
+```

+#### New features and enhancements

+This release introduces the following features and enhancements.

+| Feature or enhancement | Description |
+| --- | --- |
+| CDS-40179 | Added reconciliation for looker entities to ensure data synchronization between mongoDB and timescaleDB. |
+| CDS-45694 | Coverage for Stage and Step level deployment details task. Added unit tests. |
The description in Jira is different: "Longer retention for deployment in
custom dashboards was failing due to a missing null check which has been
added." Can we check with the engineering team about how this issue impacts
users and reword accordingly?
In docs/first-gen/firstgen-release-notes/harness-on-prem-release-notes.md
https://github.com/harness/developer-hub/pull/255#discussion_r1058241899
:

+This release of Harness Self-Managed Enterprise Edition requires KOTS admin console 1.88.0. You must upgrade KOTS before you deploy this Harness release. Use the following commands:

+```
+curl https://kots.io/install/1.88.0 https://kots.io/install/1.88.0 | bash
+kubectl kots admin-console upgrade -n
+```

+#### New features and enhancements

+This release introduces the following features and enhancements.

+| Feature or enhancement | Description |
+| --- | --- |
+| CDS-40179 | Added reconciliation for looker entities to ensure data synchronization between mongoDB and timescaleDB. |
+| CDS-45694 | Coverage for Stage and Step level deployment details task. Added unit tests. |
+| CDS-47016 | Changed how search functionality on the deployments page works. Instead of using regex, search operations now use mongo stemming algorithms. |

Global comment (in the present case, on the first sentence here):
prefer complete sentences. Also, this first sentence does not seem
necessary. The second sentence, by itself, covers everything the user needs.
It might be good to add how it benefits the user. That does not come
out anywhere in the description.

In docs/first-gen/firstgen-release-notes/harness-on-prem-release-notes.md
https://github.com/harness/developer-hub/pull/255#discussion_r1058245354
:

+```
+curl https://kots.io/install/1.88.0 https://kots.io/install/1.88.0 | bash
+kubectl kots admin-console upgrade -n
+```

+#### New features and enhancements

+This release introduces the following features and enhancements.

+| Feature or enhancement | Description |
+| --- | --- |
+| CDS-40179 | Added reconciliation for looker entities to ensure data synchronization between mongoDB and timescaleDB. |
+| CDS-45694 | Coverage for Stage and Step level deployment details task. Added unit tests. |
+| CDS-47016 | Changed how search functionality on the deployments page works. Instead of using regex, search operations now use mongo stemming algorithms. |
+| DEL-4888 | Adopted the use of an immutable image for the delegate that is installed by default in newly created accounts. For more information on new delegate features including auto-update, see Delegate Overview. |

"For more information about"? Reason for recommending that we drop
"more": we have not described or mentioned any features before that
reference.
Do we need a comma before "including"?
Can we add a link to the referenced overview?

In docs/first-gen/firstgen-release-notes/harness-on-prem-release-notes.md
https://github.com/harness/developer-hub/pull/255#discussion_r1058270781
:

+curl https://kots.io/install/1.88.0 https://kots.io/install/1.88.0 | bash

+kubectl kots admin-console upgrade -n
+```

+#### New features and enhancements

+This release introduces the following features and enhancements.

+| Feature or enhancement | Description |
+| --- | --- |
+| CDS-40179 | Added reconciliation for looker entities to ensure data synchronization between mongoDB and timescaleDB. |
+| CDS-45694 | Coverage for Stage and Step level deployment details task. Added unit tests. |
+| CDS-47016 | Changed how search functionality on the deployments page works. Instead of using regex, search operations now use mongo stemming algorithms. |
+| DEL-4888 | Adopted the use of an immutable image for the delegate that is installed by default in newly created accounts. For more information on new delegate features including auto-update, see Delegate Overview. |
+| DEL-5073 | Updated the Core Protocol Buffers library protobuf-java/protobuf-javalite to version 3.21.7. This update fixes CVE-2022-3171, a vulnerability affecting some earlier versions. The vulnerability was linked with denial of service (DoS) attacks. |
+| DEL-5153 | Changed the base image for the non-legacy delegate to redhat/ubi8-minimal:latest. This ensures that each release includes fixes for all operating system-level fixes. |

Is the name "non-legacy delegate" official? I found two instances on
docs.harness.io, but they are both in the release notes. Is "immutable
delegate" the name to use?
each vs. every. The latter might be preferable in this context.
Should we be descriptive with our reference to
redhat/ubi8-minimal:latest? I found only four Google results when I
searched for that text (I used quotation marks), and two of them were in
Harness docs. The third one was a blog and the fourth, a Docker Hub page.
That text is probably 100% accurate if you want to point users to the exact
image, but descriptive text would be easier to read, and we could add
"redhat/ubi8-minimal:latest" in parentheses, as extra info. Would "the
latest version of Red Hat Universal Base Image 8 Minimal" be okay to use?
BTW, that is only an example, and you could use whatever you think is best.
Thanks.

In docs/first-gen/firstgen-release-notes/harness-on-prem-release-notes.md
https://github.com/harness/developer-hub/pull/255#discussion_r1058279066
:

+kubectl kots admin-console upgrade -n

+```

+#### New features and enhancements

+This release introduces the following features and enhancements.

+| Feature or enhancement | Description |
+| --- | --- |
+| CDS-40179 | Added reconciliation for looker entities to ensure data synchronization between mongoDB and timescaleDB. |
+| CDS-45694 | Coverage for Stage and Step level deployment details task. Added unit tests. |
+| CDS-47016 | Changed how search functionality on the deployments page works. Instead of using regex, search operations now use mongo stemming algorithms. |
+| DEL-4888 | Adopted the use of an immutable image for the delegate that is installed by default in newly created accounts. For more information on new delegate features including auto-update, see Delegate Overview. |
+| DEL-5073 | Updated the Core Protocol Buffers library protobuf-java/protobuf-javalite to version 3.21.7. This update fixes CVE-2022-3171, a vulnerability affecting some earlier versions. The vulnerability was linked with denial of service (DoS) attacks. |
+| DEL-5153 | Changed the base image for the non-legacy delegate to redhat/ubi8-minimal:latest. This ensures that each release includes fixes for all operating system-level fixes. |
+| DEL-5308 | Removed the delegate dependency on Java driver component mongo-java-driver. This eliminates vulnerability CVE-2021-20328 affecting client-side field level encryption (CSFLE). |
Suggest the following minor fixes: This release removes the dependency of
the delegate on the Java driver component mongo-java-driver. This change
eliminates the vulnerability CVE-2021-20328
https://github.com/advisories/GHSA-rghw-6px2-fgwc, which affects
client-side field level encryption (CSFLE).
(Separately, we should think about terminology: "the delegate" or just
"delegate" or "Delegate" or "Harness Delegate" or something else. Looking
forward to your suggestions.)
In docs/first-gen/firstgen-release-notes/harness-on-prem-release-notes.md
https://github.com/harness/developer-hub/pull/255#discussion_r1058280604
:

+```

+#### New features and enhancements

+This release introduces the following features and enhancements.

+| Feature or enhancement | Description |
+| --- | --- |
+| CDS-40179 | Added reconciliation for looker entities to ensure data synchronization between mongoDB and timescaleDB. |
+| CDS-45694 | Coverage for Stage and Step level deployment details task. Added unit tests. |
+| CDS-47016 | Changed how search functionality on the deployments page works. Instead of using regex, search operations now use mongo stemming algorithms. |
+| DEL-4888 | Adopted the use of an immutable image for the delegate that is installed by default in newly created accounts. For more information on new delegate features including auto-update, see Delegate Overview. |
+| DEL-5073 | Updated the Core Protocol Buffers library protobuf-java/protobuf-javalite to version 3.21.7. This update fixes CVE-2022-3171, a vulnerability affecting some earlier versions. The vulnerability was linked with denial of service (DoS) attacks. |
+| DEL-5153 | Changed the base image for the non-legacy delegate to redhat/ubi8-minimal:latest. This ensures that each release includes fixes for all operating system-level fixes. |
+| DEL-5308 | Removed the delegate dependency on Java driver component mongo-java-driver. This eliminates vulnerability CVE-2021-20328 affecting client-side field level encryption (CSFLE). |
+| DEL-5386 | Changed the base image that the non-legacy delegate uses to redhat/ubi8-minimal:latest. This ensures that each release includes all OS-level security updates. |
This description is the same as the description for DEL-5153, which is the
third item up from here. Should we club them?
In docs/first-gen/firstgen-release-notes/harness-on-prem-release-notes.md
https://github.com/harness/developer-hub/pull/255#discussion_r1058282815
:

+#### New features and enhancements

+This release introduces the following features and enhancements.

+| Feature or enhancement | Description |
+| --- | --- |
+| CDS-40179 | Added reconciliation for looker entities to ensure data synchronization between mongoDB and timescaleDB. |
+| CDS-45694 | Coverage for Stage and Step level deployment details task. Added unit tests. |
+| CDS-47016 | Changed how search functionality on the deployments page works. Instead of using regex, search operations now use mongo stemming algorithms. |
+| DEL-4888 | Adopted the use of an immutable image for the delegate that is installed by default in newly created accounts. For more information on new delegate features including auto-update, see Delegate Overview. |
+| DEL-5073 | Updated the Core Protocol Buffers library protobuf-java/protobuf-javalite to version 3.21.7. This update fixes CVE-2022-3171, a vulnerability affecting some earlier versions. The vulnerability was linked with denial of service (DoS) attacks. |
+| DEL-5153 | Changed the base image for the non-legacy delegate to redhat/ubi8-minimal:latest. This ensures that each release includes fixes for all operating system-level fixes. |
+| DEL-5308 | Removed the delegate dependency on Java driver component mongo-java-driver. This eliminates vulnerability CVE-2021-20328 affecting client-side field level encryption (CSFLE). |
+| DEL-5386 | Changed the base image that the non-legacy delegate uses to redhat/ubi8-minimal:latest. This ensures that each release includes all OS-level security updates. |
+| PL-26799 | Removed feature flag LDAP_GROUP_SYNC_JOB_ITERATOR. This makes it possible for all accounts for which LDAP is configured to set up a periodic group sync schedule by using a cron expression. |
The second sentence needs rewording. At first pass, I read the second
sentence as if we meant to write "accounts for which LDAP is configured to
set something up." What we mean, probably, is this: If your account uses
LDAP, you can set up a periodic group sync schedule by using a Cron
expression.
Is that accurate? Happy to discuss if I failed to clarify how I misread
the sentence. Thanks.
(Note also that we can just write "Cron" instead of cron, but that's a
nit.)
In docs/first-gen/firstgen-release-notes/harness-on-prem-release-notes.md
https://github.com/harness/developer-hub/pull/255#discussion_r1058286722
:

+#### New features and enhancements

+This release introduces the following features and enhancements.

+| Feature or enhancement | Description |
+| --- | --- |
+| CDS-40179 | Added reconciliation for looker entities to ensure data synchronization between mongoDB and timescaleDB. |
+| CDS-45694 | Coverage for Stage and Step level deployment details task. Added unit tests. |
+| CDS-47016 | Changed how search functionality on the deployments page works. Instead of using regex, search operations now use mongo stemming algorithms. |
+| DEL-4888 | Adopted the use of an immutable image for the delegate that is installed by default in newly created accounts. For more information on new delegate features including auto-update, see Delegate Overview. |
+| DEL-5073 | Updated the Core Protocol Buffers library protobuf-java/protobuf-javalite to version 3.21.7. This update fixes CVE-2022-3171, a vulnerability affecting some earlier versions. The vulnerability was linked with denial of service (DoS) attacks. |
+| DEL-5153 | Changed the base image for the non-legacy delegate to redhat/ubi8-minimal:latest. This ensures that each release includes fixes for all operating system-level fixes. |
+| DEL-5308 | Removed the delegate dependency on Java driver component mongo-java-driver. This eliminates vulnerability CVE-2021-20328 affecting client-side field level encryption (CSFLE). |
+| DEL-5386 | Changed the base image that the non-legacy delegate uses to redhat/ubi8-minimal:latest. This ensures that each release includes all OS-level security updates. |
+| PL-26799 | Removed feature flag LDAP_GROUP_SYNC_JOB_ITERATOR. This makes it possible for all accounts for which LDAP is configured to set up a periodic group sync schedule by using a cron expression. |
+|          | Additionally, LDAP user group sync will not use a quartz job. Instead, the cron-based scheduler will use the user-configured cron expression. The default value remains set to a 15-minute interval. |

"will not use" > replace with "no longer uses", if accurate.
Should "quartz" be in uppercase? (Quartz?)
cron-based scheduler > change to Cron-based scheduler.
will use > uses (also, how about rewording to "Additionally, Harness
synchronizes LDAP user groups by using a Cron-based scheduler instead of a
Quartz job, and you configure the Cron expression for the scheduler."
"The default value remains set to a 15-minute interval." > The
default interval remains 15 minutes." (The current construction made me
wonder, for a brief moment, whether the default value was indeed for the
interval. We can be more direct.)

In docs/first-gen/firstgen-release-notes/harness-on-prem-release-notes.md
https://github.com/harness/developer-hub/pull/255#discussion_r1058291694
:

+This release introduces the following features and enhancements.

+| Feature or enhancement | Description |
+| --- | --- |
+| CDS-40179 | Added reconciliation for looker entities to ensure data synchronization between mongoDB and timescaleDB. |
+| CDS-45694 | Coverage for Stage and Step level deployment details task. Added unit tests. |
+| CDS-47016 | Changed how search functionality on the deployments page works. Instead of using regex, search operations now use mongo stemming algorithms. |
+| DEL-4888 | Adopted the use of an immutable image for the delegate that is installed by default in newly created accounts. For more information on new delegate features including auto-update, see Delegate Overview. |
+| DEL-5073 | Updated the Core Protocol Buffers library protobuf-java/protobuf-javalite to version 3.21.7. This update fixes CVE-2022-3171, a vulnerability affecting some earlier versions. The vulnerability was linked with denial of service (DoS) attacks. |
+| DEL-5153 | Changed the base image for the non-legacy delegate to redhat/ubi8-minimal:latest. This ensures that each release includes fixes for all operating system-level fixes. |
+| DEL-5308 | Removed the delegate dependency on Java driver component mongo-java-driver. This eliminates vulnerability CVE-2021-20328 affecting client-side field level encryption (CSFLE). |
+| DEL-5386 | Changed the base image that the non-legacy delegate uses to redhat/ubi8-minimal:latest. This ensures that each release includes all OS-level security updates. |
+| PL-26799 | Removed feature flag LDAP_GROUP_SYNC_JOB_ITERATOR. This makes it possible for all accounts for which LDAP is configured to set up a periodic group sync schedule by using a cron expression. |
+|          | Additionally, LDAP user group sync will not use a quartz job. Instead, the cron-based scheduler will use the user-configured cron expression. The default value remains set to a 15-minute interval. |
+| PL-29603 | Upgraded org.mongodb:mongo-java-driver to version 3.12.11 to fix vulnerabilities. |
Does this relate, in some way, to DEL-5308 above? I checked Jira and it
looks to be related. Can we combine? Also, if it weren't related, we would
be expected to name the vulnerabilities. DEL-5308 mentions the CVE number,
so we should be good.
In docs/first-gen/firstgen-release-notes/harness-on-prem-release-notes.md
https://github.com/harness/developer-hub/pull/255#discussion_r1058327347
:

+| DEL-4888 | Adopted the use of an immutable image for the delegate that is installed by default in newly created accounts. For more information on new delegate features including auto-update, see Delegate Overview. |

+| DEL-5073 | Updated the Core Protocol Buffers library protobuf-java/protobuf-javalite to version 3.21.7. This update fixes CVE-2022-3171, a vulnerability affecting some earlier versions. The vulnerability was linked with denial of service (DoS) attacks. |
+| DEL-5153 | Changed the base image for the non-legacy delegate to redhat/ubi8-minimal:latest. This ensures that each release includes fixes for all operating system-level fixes. |
+| DEL-5308 | Removed the delegate dependency on Java driver component mongo-java-driver. This eliminates vulnerability CVE-2021-20328 affecting client-side field level encryption (CSFLE). |
+| DEL-5386 | Changed the base image that the non-legacy delegate uses to redhat/ubi8-minimal:latest. This ensures that each release includes all OS-level security updates. |
+| PL-26799 | Removed feature flag LDAP_GROUP_SYNC_JOB_ITERATOR. This makes it possible for all accounts for which LDAP is configured to set up a periodic group sync schedule by using a cron expression. |
+|          | Additionally, LDAP user group sync will not use a quartz job. Instead, the cron-based scheduler will use the user-configured cron expression. The default value remains set to a 15-minute interval. |
+| PL-29603 | Upgraded org.mongodb:mongo-java-driver to version 3.12.11 to fix vulnerabilities. |

+#### Issues fixed in this release

+This release includes the following fixes.

+| Feature or enhancement | Description |
+| --- | --- |
+| CDS-36784 | NPE when trying to click a version of a linked Shell Script step from Template Library |
Global comment: we should have one description per row. I built this
locally and saw that readers will see and will have to map multiple rows in
the second column to one Jira ticket in the first column. Let's eliminate
these titles and bring all text associated with one issue into a single
row. We might have to use HTML elements to add line breaks within a table
cell.
In docs/first-gen/firstgen-release-notes/harness-on-prem-release-notes.md
https://github.com/harness/developer-hub/pull/255#discussion_r1058329277
:

+| DEL-5073 | Updated the Core Protocol Buffers library protobuf-java/protobuf-javalite to version 3.21.7. This update fixes CVE-2022-3171, a vulnerability affecting some earlier versions. The vulnerability was linked with denial of service (DoS) attacks. |

+| DEL-5153 | Changed the base image for the non-legacy delegate to redhat/ubi8-minimal:latest. This ensures that each release includes fixes for all operating system-level fixes. |
+| DEL-5308 | Removed the delegate dependency on Java driver component mongo-java-driver. This eliminates vulnerability CVE-2021-20328 affecting client-side field level encryption (CSFLE). |
+| DEL-5386 | Changed the base image that the non-legacy delegate uses to redhat/ubi8-minimal:latest. This ensures that each release includes all OS-level security updates. |
+| PL-26799 | Removed feature flag LDAP_GROUP_SYNC_JOB_ITERATOR. This makes it possible for all accounts for which LDAP is configured to set up a periodic group sync schedule by using a cron expression. |
+|          | Additionally, LDAP user group sync will not use a quartz job. Instead, the cron-based scheduler will use the user-configured cron expression. The default value remains set to a 15-minute interval. |
+| PL-29603 | Upgraded org.mongodb:mongo-java-driver to version 3.12.11 to fix vulnerabilities. |

+#### Issues fixed in this release

+This release includes the following fixes.

+| Feature or enhancement | Description |
+| --- | --- |
+| CDS-36784 | NPE when trying to click a version of a linked Shell Script step from Template Library |
+|           | Fixed a bug where the linked template in the pre-deployment step in the canary workflow did not show the correct version |
"where" might not be the best choice of word here.
Global comment: Also, can we split this description into the following?

A statement or statements that describe the issue
A statement saying that the issue is fixed.

In docs/first-gen/firstgen-release-notes/harness-on-prem-release-notes.md
https://github.com/harness/developer-hub/pull/255#discussion_r1058380629
:

+```

+curl https://kots.io/install/1.88.0 https://kots.io/install/1.88.0 | bash
+kubectl kots admin-console upgrade -n
+```

+#### New features and enhancements

+This release introduces the following features and enhancements.

+| Feature or enhancement | Description |
+| --- | --- |
+| CDS-40179 | Added reconciliation for looker entities to ensure data synchronization between mongoDB and timescaleDB. |
+| CDS-45694 | Coverage for Stage and Step level deployment details task. Added unit tests. |
+| CDS-47016 | Changed how search functionality on the deployments page works. Instead of using regex, search operations now use mongo stemming algorithms. |
+| DEL-4888 | Adopted the use of an immutable image for the delegate that is installed by default in newly created accounts. For more information on new delegate features including auto-update, see Delegate Overview. |
+| DEL-5073 | Updated the Core Protocol Buffers library protobuf-java/protobuf-javalite to version 3.21.7. This update fixes CVE-2022-3171, a vulnerability affecting some earlier versions. The vulnerability was linked with denial of service (DoS) attacks. |
Hyphenate "denial of service."
In docs/first-gen/firstgen-release-notes/harness-on-prem-release-notes.md
https://github.com/harness/developer-hub/pull/255#discussion_r1058386646
:

+| CDS-43346, ZD-28902, ZD-34686 | Deployments Page Filters Problems |

+|          | Filter should work properly when user tries to switch from filter 2 to filter 1. |
+| CDS-43410, ZD-34705 | Users cannot set up start time and end time in a Jira step. |
+|          | This issue has been resolved. |
+| CDS-43477, ZD-34546 | Service Dashboard showing the wrong Artifact info from what was deployed. Fixed a bug where the Services dashboard statistics did not show the correct version of the artifact when a workflow rollback failed. |
+| CDS-44014 | Dashboards Data Issue: Missing Service Names for Deployments with Running Status |
+|           | Updated the Workflow Execution before publishing event and updating the timescale database, which allows time scale database to be populated with deployed service Ids while workflow or pipeline is running. |
+| CDS-44299, ZD-35185 | Harness Manager and GraphQL missing Git Connector information. The property sent to the backend was wrong and it was removed. Now we can fetch the correct connector list. |
+| CDS-44396 | Fields overlap on the Deployment Freeze Window screen. This issue has been resolved. |
+| CDS-44408 | When an active deployment freeze is on and no entries exist for app exclusions, the workflow deployment fails with an appID may not be null error. This issue occurs when the SPG_NEW_DEPLOYMENT_FREEZE_EXCLUSIONS feature flag is enabled. |
+|           | Validation has been added to prevent empty Application, Environment, and Service IDs in the Deployment Freeze Window screen. |
+| CDS-44485 | A bad query on instance collection scans all the records, causing a high level of disk utilization. This issue has been resolved. |
+| CDS-45647, ZD-36114, ZD-36510 | Application is not showing in dropdown. If user searched any query, then the ID provided to the child component restricted pagination. Now the ID is updated to the parent level so that if elements are more than 10/15, infinite scroll is enabled and all the matching results are fetched. |
+| CDS-46099 | Perpetual task interval correction for instance sync. Perpetual task interval for instance sync is 10 minutes. |
+| CDS-46163 | Kubernetes deployments were failing if a Shell Script step was placed after deployment steps. |
+| DEL-5100, ZD-35558 | Fixed a regression issue that allowed delegate tasks to continue to run when delegates were not able to research external resources. |
"delegates were not able to research external resources." Would that be
anthropomorphism? Can we fix this with rewording?
—
Reply to this email directly, view it on GitHub
https://github.com/harness/developer-hub/pull/255#pullrequestreview-1231265109,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZTVUT2VFM2QQRI5CNXKLXDWPRH23ANCNFSM6AAAAAATHN6XWU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Preview environment: https://ci.pr.harness.io/pr-255

Preview environment: https://ci.pr.harness.io/pr-255

Preview environment: https://ci.pr.harness.io/pr-255


Allow the entry_name size to be set in config.h

Allow the size of the entry_name character array in x509_crt.c to be
configurable through a macro in config.h. entry_name holds a
path/filename string. The macro introduced in
MBEDTLS_X509_MAX_FILE_PATH_LEN.
This addresses issue https://github.com/ARMmbed/mbedtls/issues/492

Reviewed and approved for merge. Just needs testing.

Reviewed, tested and merged manually.


after updating extension do not produce output

I've updated to last version and now extension alerts that contract compiled successful but do not produce .abi or .bin files.

I found the problem in file compiler.js
The problem line is if (child.name === 'Contract')
now it should be if (child.name === 'ContractDefinition')
maybe they updated filed name in new version of solc compiler
I changed this file as I wrote above and my contract compiles successfully and produces output in /bin folder.

Checked in the fixt, Thanks!!!


move register callback to non builder inference

Approved. I would like to revisit this listener framework and usage once.
Will go through the wiki available once again.


Fix typo between 'indentation' and 'indent' constructor parameter

It seems like the source uses the constructor parameter indent to specify the string to use for indenting, but the documentation use the keyword indentation. Make sure they are the same.

Coverage remained the same at 96.833% when pulling d8cd4b85837c80677933469f11788b7918b5f453 on robinsmidsrod:patch-1 into 4314ae16b928a76fc762c7186dfd27de5b1aafbc on sass:develop.

Confirmed that this is a documentation bug. Can you also add that change in Sass.pm (md is generated from it) and ammend this commit? Thank you!

@mgreter Does this look good?

Coverage remained the same at 96.833% when pulling 0255c20b051297eb4519c38490b8da605f2a894a on robinsmidsrod:patch-1 into 4314ae16b928a76fc762c7186dfd27de5b1aafbc on sass:develop.

Sorry it took that long to be merged!
Thanks for your contribution!!


Basic auth support

We could probably support digest at the same time.
This should be fairly easy to do though Passport.js and the designers might want it as it's what they are used to.

A simple version of this has now been implemented in: #247
It is available in version 0.2.6


[Question] How to display black warnings on "Problems" tab in vscode ?

Hello all !
First of all thank you for this extension, the tool is cool !
I would like to know if it is possible to see if an open .py file has to be formatted with black, in the "Problems" tab on vscode ? Like isort, pylint etc do ?
Simple question, I search for this response and was not able to find a good answer, so I decided to post here.
Thanks !

We don't support --check for black. This would be a feature request.

Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 7 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.

Upvoted; this would be really useful and aligns with other tools. If this feature is not supported it'd be great to make this clear in the usage instructions of the extension please---I spent ages looking for it.
If you're wondering what the use case is, consider that you're adding or modifying code to an existing codebase and want to ensure new code is formatted without re-formatting an entire file. Thanks.


Add upstream to manager all upstream related resources.

Is your feature request related to a problem?
as title.
Describe the feature you'd like
as title.
Describe alternatives you've considered
No response
Teachability, Documentation, Adoption, Migration Strategy
No response

done


ci: Use GitHub Pages GitHub Actions for deployment

Descriptions
This PR implements very similar changes to the CI system as https://github.com/UW-Madison-DSI/open_source_survey_results/pull/1
Change summary

Add run trigger for pull_requests to be able to test builds on PRs.

Restrict deployment to push events to master only, which correspond to merged PRs.

Use concurrency to avoid wasting CI time.
Remove redundant defaults.
Add file permissions fix check.
Only escalate permissions on jobs that require them and limit the default permissions to be read only.

This PR will be followed up by a PR to address Issue #7
Important
This PR should not be merged until https://github.com/UW-Madison-DSI/ospo.wisc.edu-uw-jekyll-theme/settings/pages is switched over to use deploy from GitHub Actions

This needs agreement in advance.

Example of this build process working as expected on my fork: https://matthewfeickert.github.io/ospo.wisc.edu-uw-jekyll-theme/

These PRs are all great, but I wanted to note that they should make their way back upstream to
https://github.com/UW-Madison-DSI/uw-jekyll-theme


Release Google.Cloud.Iam.Credentials.V1 version 1.0.0-beta01

Changes in this release:
Initial release.

Forced CLA check - it's fine.

Created release for Google.Cloud.Iam.Credentials.V1-1.0.0-beta01


Remove ZWeb3 now that the move to Web3 v1 is complete

As discussed previously in this issue https://github.com/zeppelinos/zos/issues/591

@spalladino Am I correct in thinking that the tests in the examples dir will be moving away from using ZWeb3 in the future? Thanks!

Hey @pcowgill! We may continue to use ZWeb3 internally, as it's useful as an abstraction layer on top of web3 in case we need to monkeypatch anything, or even switch between different versions. What we will most likely change is zos-lib public API by making initialization smoother, so the user does not need to know about or use it.

Makes sense! Thanks, that answer is very helpful.
In that case maybe we can rename this issue to be about removing it from the public API and example test suites?

Updated!

Closing in favour of #1308


Swagger docs not working out of the box at start of project

Going to http://localhost:8000/api/docs has a routing issue in the path. I'm not familiar enough with the project to be able to diagnose the issue, but it seems like it should be a relatively simple fix for someone who knows the project.

Good catch, I believe this had to do with a newer version of FastAPI changing how root_path works in the uvicorn configuration.  Should be fixed now.


line 48: syntax error near unexpected token

FYI, as of August 27, 2020, the current script 1.6.1 gives this error on a raspberry pi running raspbian buster.  Pi-hole v5.1.2
pi@raspberrypi:~ $ sudo Pi-hole_SafeSearch.sh --enable [2020-08-27 14:30:01:998]: Retrieving List from Google [2020-08-27 14:30:03:287]: 191 TLDs [2020-08-27 14:30:03:297]: 382 Domains [2020-08-27 14:30:03:308]: ENABLING SAFESEARCH FOR PI-HOLE [2020-08-27 14:30:03:325]: BLOCKING OTHER BAD SITES /usr/local/bin/Pi-hole_SafeSearch.sh: line 48: syntax error near unexpected token^'
/usr/local/bin/Pi-hole_SafeSearch.sh: line 48:    "(^|\.).+xxx$"'
In testing, it looks like line 192 is the one that is failing.  If I comment it out, things work.
silently pihole --regex "${REGEX[@]}"
For clarity, here's what the REGEX code is:
REGEX=(     "(^|\.).+xxx$"     "(^|\.).+sexy$"     "(^|\.).+webcam$"     "(^|\.).+sex$"     "(^|\.).+porn$"     "(^|\.).+tube$"     "(^|\.).+cam$"     "(^|\.).+adult$" )
The log file has this in it:
`pi@raspberrypi:~ $ cat /var/log/Pi-hole_SafeSearch.sh.log
[2020-08-27 14:30:01:984]: STARTED
[2020-08-27 14:30:01:989]: ARGUMENTS: --enable
/usr/local/bin/Pi-hole_SafeSearch.sh: line 118: checkSudo: command not found
[2020-08-27 14:30:01:995]: Retrieving List from Google
[2020-08-27 14:30:03:282]: 191 TLDs
[2020-08-27 14:30:03:292]: 382 Domains
[2020-08-27 14:30:03:303]: ENABLING SAFESEARCH FOR PI-HOLE
[2020-08-27 14:30:03:320]: BLOCKING OTHER BAD SITES
[2020-08-27 14:30:04:083]: STOPPED
`
Sorry for the odd formatting, not sure why it isn't showing the code with the newline/CR.

Mmm... messing with it in an effort to debug it has caused it to start working.  I'm not sure why.  There's another person on this blog site in the discussion section at the end with the same error.


Add client certificate auth method for Vault issuer

What this PR does / why we need it:
Enabling cert-manager to authenticate against Vault using TLS client certificate authentication, by adding another auth method. This helps a lot in situations where the other auth options are not viable (In my case: K8s multicluster setup with distinct control planes; but having common access to the same Azure KeyVault to create some selfsigned certificates).
apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
  name: vault-issuer
spec:
  vault:
    path: pki/sign/cert-manager
    server: https://vault:8200
    caBundle: "..."
    auth:
      clientCertificate:
        role: cert-manager
        secretName: cert-manager-client-tls

Considerations:
refs #2926, #4256:
After coding this, I noticed that these issues suggest setting up mTLS as additional transport setting, in addition to using some other auth method. This PR however would introduce client certificate authentication as standalone auth method; Only using the client certificate while acquiring the Vault token (Using the Vault TLS Certificates - Auth Method).
I suppose both using TLS client certificate authentication as (1) transport security prerequisite and (2) primary authentication method are valid use cases. A compromise making both possible from CRD perspective might be:
apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
  name: vault-issuer
spec:
  vault:
    server: https://vault:8200
    path: pki/sign/cert-manager
    tlsSecretName: k8s-secret # name of a "kubernetes.io/tls" style Secret, always containing ca.crt, optionally containing also containing tls.crt and tls.key for client certificate authentication
    # caBundle: ... # Drop caBundle field
    auth:
      transportAuth: {} # No further configuration necessary; Just activating by setting to "{}", optionally supplying "role"
      # OR
      kubernetes:
        role: cert-manager
        mountPath: /v1/auth/kubernetes
        secretRef:
          name: serviceaccount-token-secret
          key: token

Here, moving caBundle would be a breaking change. Using the Vault issuer would always mean to setup some K8s RBAC to "get" Secrets, then.
Another option: Keeping caBundle as-is, while IMHO sacrificing clearness a bit:
apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
  name: vault-issuer
spec:
  vault:
    server: https://vault:8200
    path: pki/sign/cert-manager
    tlsSecretName: k8s-secret # optional field, name of a "kubernetes.io/tls" style Secret, containing tls.crt and tls.key for client certificate authentication
    caBundle: ...
    auth:
      transportAuth: {} # No further configuration necessary; Just activating by setting to "{}", optionally supplying "role"
      # OR
      kubernetes:
        role: cert-manager
        mountPath: /v1/auth/kubernetes
        secretRef:
          name: serviceaccount-token-secret
          key: token

EDIT: Yet another option: Allow to use configMapKeyRefs and secretKeyRefs known from K8s corev1 for all TLS related fields (except key).
apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
  name: vault-issuer
spec:
  vault:
    server: https://vault:8200
    path: pki/sign/cert-manager
    tls:
      caBundle:
        configMapKeyRef: # OR secretKeyRef
          name: bundle
          key: ca.crt
      certificate:
        configMapKeyRef: # OR secretKeyRef
          name: cert
          key: tls.crt
      key:
        secretKeyRef:
          name: cert
          key: tls.key
    # caBundle: ... # Drop caBundle field
    auth:
      transportAuth: {} # No further configuration necessary; Just activating by setting to "{}", optionally supplying "role"
      # OR
      kubernetes:
        role: cert-manager
        mountPath: /v1/auth/kubernetes
        secretRef:
          name: serviceaccount-token-secret
          key: token

I'd be happy to get some feedback on this: Would you rather see something like these alternatives implemented or is this PR good to go as-is (adding a few tests maybe)?
Release note:

Add client certificate auth method for Vault issuer

Removing "WIP" status, as implementation of this feature is basically complete/ready for review.
Implementing any alternative approach as outlined in the original comment would be better handled in a separate PR, I guess.

Hi! Thank you for your contribution, and my apologies for the delay in reviewing the PR.
Regarding the possible removal of caBundle, that would break people and that's something we want to avoid until we have a v2 of the API 😅
Now, regarding the UX of the API. From what I understand, it is possible to authenticate with Vault in two different ways involving client certificates:

Using a client certificate for authenticating the transport layer, and using another authentication mechanism at the application layer,
Using client certificate for authenticating both the transport layer and the application layer.

This PR seems to address both (1) and (2), but as you noted, (1) may feel confusing to users since it means they will have to use two possibly conflicting auth methods:
apiVersion: cert-manager.io/v1
kind: Issuer
spec:
  vault:
    caBundle: "..."
    auth:
      clientCertificate:
        secretName: cert-manager-client-tls
      kubernetes:
        role: cert-manager
        mountPath: /v1/auth/kubernetes
        secretRef:
          name: serviceaccount-token-secret
          key: token

With this API, when role is set on both kubernetes and clientCertificate, which one should be used?

We could alleviate this confusing UX by:

Either moving clientCertificate under vault instead of under auth, but then it would become less apparent that it is an auth method, and it would be as confusing as the initial proposal;
Or, as you suggested, add another field tlsSecretName in order to clarify the use-case (1).

The next steps of this PR:

Have a quick chat with the cert-manager team regarding the above UX question; I'll raise the question during tomorrow morning's open daily standup (feel free to join!)
Add an end-to-end test as well as some unit tests,
Open a PR to document this new feature in the page configuration/vault.md.

We were pleased to welcome Joshua during this morning's standup!! Here is what we came up with:

This PR, which implements the use-case (2) only, is OK on its own. We don't need to implement (1) right now, it could be implemented in a later PR. I opened (issue link tbd) to track this missing use-case.
The next step is to have this PR rebased. We will need to add an end-to-end test as well as unit tests and then proceed to the review. I can help with rebasing and testing if you like.

Does it look good to you @joshmue?

/ok-to-test
/kind feature

l'll make the mentioned changes, try to rebase the PR and try to write some tests.

Did that. PR is ready for review, now.

Hi! Sorry for the delay, I'll review this PR.

/remove-lifecycle stale
(even though I probably need to do a fresh rebase soon)

Setting WIP while rebasing...

Rebase done. Removing WIP.

Hi there,
I'd like to know if there are any plans for pushing this PR?

@maelvls Were you able to take a further look yet?
If there is something I can do to move this forward, I'd be happy to do so.

I can take a look tomorrow morning.

Thanks for the review! I'll attempt to address these issues one after another.

I looked into the feasability of an e2e test, and it seems totally feasable. I pushed an example of what the e2e could look like: https://github.com/joshmue/cert-manager/compare/vault_client_cert_auth...maelvls:cert-manager:vault_client_cert_auth_tests
To run this e2e test:
make -j e2e-setup-certmanager e2e-setup-vault
make e2e GINKGO_FOCUS=".*Vault Cert Auth.*"

Let me know if that doesn't work.

I looked into the feasibility of an e2e test, and it seems totally feasible. I pushed an example of what the e2e could look like: joshmue/cert-manager@vault_client_cert_auth...maelvls:cert-manager:vault_client_cert_auth_tests
To run this e2e test:
make -j e2e-setup-certmanager e2e-setup-vault
make e2e GINKGO_FOCUS=".Vault Cert Auth."
Let me know if that doesn't work.

Thanks a lot! When testing, currently the issuer has the following problem (ErrInitIssuer):
Failed to initialize Vault client: error calling Vault server: Post "https://chart-vault-vault-cert-auth.e2e-tests-create-vault-cert-p7l9l:8200/v1/auth/cert/login": invalid request :path "v1/auth/cert/login"

The message is also included in the log output:
[cert-manager] Vault Cert Auth should work [It] should generate a new valid certificate
/workspaces/cert-manager/test/e2e/suite/issuers/vault/certificate/cert_auth.go:106

  [FAILED] Unexpected error:
      <*errors.errorString | 0xc0010b2070>: {
          s: "timed out waiting for the condition: Last Status: 'False' Reason: 'VaultError', Message: 'Failed to initialize Vault client: error calling Vault server: Post \"https://chart-vault-vault-cert-auth.e2e-tests-create-vault-cert-p7l9l:8200/v1/auth/cert/login\": invalid request :path \"v1/auth/cert/login\"'",
      }
      timed out waiting for the condition: Last Status: 'False' Reason: 'VaultError', Message: 'Failed to initialize Vault client: error calling Vault server: Post "https://chart-vault-vault-cert-auth.e2e-tests-create-vault-cert-p7l9l:8200/v1/auth/cert/login": invalid request :path "v1/auth/cert/login"'
  occurred
  In [It] at: /workspaces/cert-manager/test/e2e/suite/issuers/vault/certificate/cert_auth.go:135 @ 03/14/23 08:08:29.587

  Full Stack Trace
    github.com/cert-manager/cert-manager/test/e2e/suite/issuers/vault/certificate.runVaultCertAuthTest.func4()
        /workspaces/cert-manager/test/e2e/suite/issuers/vault/certificate/cert_auth.go:135 +0x538

Tried digging into it, but did not find any more useful information.

If you are happy with this e2e test, I guess we can go ahead and add it to your PR!

Done!

We are really close to being able to merge your work, congratulations!
The last step is to open a PR to document this new feature in the page configuration/vault.md.
I'll LGTM it as soon as a link to the documentation PR is added to this PR. 👌
/approve

We are really close to being able to merge your work, congratulations!
The last step is to open a PR to document this new feature in the page configuration/vault.md.
I'll LGTM it as soon as a link to the documentation PR is added to this PR. ok_hand

Thanks! I'll do that!

/retest

/retest

/retest

@maelvls Did a rebase (with related e2e changes) and a bunch of squashing. Also tried to keep commit author attribution correct.

/remove-lifecycle rotten

The requirement for this feature actually is not present anymore in the setup that I created it for. Without a plan/timetable for merging, I also stopped continuous rebasing.
So it will probably not be of any use for me in the near future, but maybe still for some people who 👍'ed or commented here.
So in order to keep the stalebot from closing this PR without a clear reason/status: How to proceed? I can see that it was moved to later milestones two times, but I am unsure what this means exactly with regard to commitment to this feature.

Thanks for creating the PR. Sorry for not merging it yet, we haven't been able to allocate the resources yet to get this merged.
I rebased the PR for you and we will do our best to move it forward in the future.

I did another review of the PR, seems ok to be merged.
/approve
/lgtm

/lgtm

@joshmue
A pre-release is now available containing the fix for this issue. Please test and feedback if you have time.

https://github.com/cert-manager/cert-manager/releases/tag/v1.16.0-alpha.0

I do not have the same setup that I was testing with earlier, but I'll try to find some time to do some tests, even tough I'll probably not be able to test more than the codified e2e tests do anyway.

I used the e2e tests for setting up a working environment and did some manual testing.
Did not notice any errors other than those that I injected on purpose.


Activation of Microsoft Defender in Storage Account level is not working

The activation of Microsoft Defender in the level of Storage account is not working: https://github.com/MicrosoftDocs/azure-docs/blob/5a849d67d1220ccb526d04f6e4bf22e4637005e1/articles/storage/common/azure-defender-storage-configure.md?plain=1#L311-L335
While the activation of Microsoft Defender in the Subscription level works like expected, with a 35-45 minutes of delay.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2b92c195-c670-2e27-2422-fd131586bdd7
Version Independent ID: 75ad901d-8064-bfbe-67f5-de507bede1bc
Content: Protect your Azure storage accounts using Microsoft Defender for Cloud - Azure Storage
Content Source: articles/storage/common/azure-defender-storage-configure.md
Service: storage
Sub-service: common
GitHub Login: @bmansheim
Microsoft Alias: benmansheim

@nebrass
Thanks for your feedback! We will investigate and update as appropriate.

@nebrass
It would be great if you could add a link to the documentation you are following for these steps? This would help us redirect the issue to the appropriate team. Thanks!

@nebrass
Since we have not heard back from you, we will now proceed to close this thread.
If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

Hello @ManoharLakkoju-MSFT, sorry for the delay.. The link to the documentation is already there in the ticket. This is the code that I'm trying to apply https://github.com/MicrosoftDocs/azure-docs/blob/5a849d67d1220ccb526d04f6e4bf22e4637005e1/articles/storage/common/azure-defender-storage-configure.md?plain=1#L311-L335

@nebrass .
I'm going to assign this to the document author so they can take a look at it accordingly
@bmansheim
Could you Please review this and update as appropriate.

The problematic bit is that the Handshake with the scan service via Event Hub is not documented for Bicep/ARM. If I perform the configuration manually via the portal it works, by creating an Event Grid with a Topic sending the files to a scan service authenticated via a managed identity.
I have tried to extract and apply the Event Grid and Topic configuration from a resource group, but deployments fail with
Webhook validation handshake failed for https://westeurope.a3.storageav.azure.com:5142/EventCapture/[...subscriptionId..]/[...storage account name...]. Http POST request failed with response code Unknown. For troublehooting, visit https://aka.ms/esvalidation. Activity id:..., timestamp: 5/23/2023 8:30:43 PM (UTC). (Code: Url validation)

I would need to understand the necessary configuration steps, as we are deploying our biceps in Complete mode, removing any non-specified resources.

Do we have Bicep support to configure malware Scanning results to be sent to Azure event grid?
As per this document :
https://learn.microsoft.com/en-us/azure/storage/common/azure-defender-storage-configure?tabs=enable-storage-account
No where it is mentioned how to achieve through bicep file.
Through Azure portal we can achieve : https://learn.microsoft.com/en-us/azure/defender-for-cloud/advanced-configurations-for-malware-scanning#setting-up-event-grid-for-malware-scanning

Thanks for your contribution to our documentation
Unfortunately, we have been unable to review this issue in a timely manner. We sincerely apologize for the delayed response. We are closing this issue. If you feel that the problem persists, please respond to this issue with additional information.
?
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close


Add vimtex support

This patch adds vimtex support to the airline. The following indicators are defined:

the viewer is opened
the compilation is running (single)
the compilation is running (continuous)
the file is a subfile and configuration refers to the main file
the file is a subfile and configuration refers to the local file

The patch is based on the discussion lervag/vimtex#765.

looks good, but needs some documentation and perhaps a screenshot.

thank you for the comments, I will update the patch accordingly.

i actually thought, you put the documentation in doc/airline.txt (and perhaps add a screenshot to REAMD.md)

@chrisbra, sorry for the ambiguity. It's not a final commit and I'm indeed planning to add the documentation to doc/airline.txt.

@chrisbra, please, review.

For know I put the screenshot in another branch in a cloned airline. If there is a better place, just tell me.

The screenshot might be a problem, if you delete your repository in the future. How about this: you drag and drop the image inside a new issue. Github will then automatically upload it to its own cloud service. You can copy and paste the URL then and use it in the README.md document. This is also described here.
Other then that, I am fine with merging this, if you could squash this as well please. Thanks.

done

thanks!


Unable to login and sign up

I have installed cvat development environment on my Ubuntu Operating system. after completing the setup, when i tried to open cvat on localhost 3000 i get the login error,

i was not able to find out the solution.

Hi, @Pawan-Ambhore, did you run cvat server?

Is there any different command for running the server? I have used npm run
start:cvat-ui
Command. For starting the server which command should I use?
On Tue, 16 Aug, 2022, 7:13 pm Dmitry Kalinin, @.***>
wrote:

Hi, @Pawan-Ambhore https://github.com/Pawan-Ambhore, did you run cvat
server?
—
Reply to this email directly, view it on GitHub
https://github.com/openvinotoolkit/cvat/issues/4799#issuecomment-1216658293,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLKWCT4QRE362TGKOS37PLVZOLIVANCNFSM56EMLZUQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@Pawan-Ambhore , npm run start:cvat-ui starts only CVAT UI. Please read contribution guide: https://cvat-ai.github.io/cvat/docs/contributing/development-environment/


Mapping fixes

Addressed in: https://github.com/Judopay/JudoKit-ReactNative/pull/149/commits/0672c4d2ec36ea52d778c57f8539e5c11a1689df


link rendered with spaces

Multiple Flavors
Don't like the class names? We've got a more verbose version you might like. Want to use Sass instead of Postcss? We've got a repo for that too :) Tachyons isn't just a css toolkit. It's a design system. Utitlized here in a react native boilerplate.

In the home page the piece I put in a code block had an structure:
react native boilerplate.

I couldn't find this sentence in the repository however...

I see it in several locations.

Why did you close this issue if you confirm it? Not sure if I understand your comment

Sorry, my misunderstanding then. I thought you were asking if your code has been merged, or had been added to the repo. Can you please clarify?

@Haroenv?

I was sleeping, sorry. I think this instance has been fixed. Thanks for helping out here ❤


validating thumbprint

Looks good to me. Just ensure that we trim trailing spaces if any

@KrishnaAdityaB  why did the PR closed without merging?


[Severe] Delete key while editing an Azure Tables query invoke the delete row function!

Storage Explorer Version: 1.12.0
Build Number: 20200116.10
Platform/OS: Windows 10
Architecture: x64
Bug Description

Every time I hit [Del] to delete a char from the Azure Table Query textbox, the Storage Explorer asks me if I'm sure I want to delete the selected row.
Steps to Reproduce

Open an Azure Table table with data.
Clique on Query
Focus on the Value textbox
Hit [Del] to delete a char

Expected Experience
[Del] should only delete the character in the textbox.
Actual Experience
The char is deleted, but the delete row function is invoked (so a confirmation dialog appears)

Duplicate of #2631 , we're working on fixing this for our next release.


usvg-cli ignores fonts from $HOME/.local/share/fonts

Line in src/fontdb.rs
let path = Path::new(home).join("/.local/share/fonts");
should be replaced to
let path = Path::new(home).join(".local/share/fonts");
Otherwise it checks "/.local/share/fonts" instead of "/home/user/.local/share/fonts"

Thanks. This is definitely an unexpected behavior of Path.


Wayland: commit frame surface on resize

[x] Tested on all platforms changed
[x] Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users

This PR commits the surface of the wayland window frame on resize  as suggested by @vberger.
This is required by https://github.com/Smithay/client-toolkit/commit/acdfde234e0afa3513b276493696811986aa2322

For the record, decoration drawing by SCTK is blocked by commits on the main surface. SCTK itself avoids committing the surface by itself, because depending on the client's behavior it may introduce graphical glitches, notably during resizes (the decorations size and content size could have a few pixels of mismatch).
In this specific case, winit can commit without risk of glitches, because the decorations simply need to be refreshed, but not resized. This is used to implement button highlighting notably.

Thanks!


add password change

If I see correctly, every user may now change every other user's password?!? Please fix that before merging :).


Clarify source for bash-completion

I spent a solid 30 minutes debugging my git completion using these dotfiles. I had not yet run brew.sh. I had git completion installed, but it wasn't working because .bash_profile no longer separately sources git-completion in favor of the handy bash-completion2. I thought this note would be helpful to a common case where people have loaded the dotfiles but opted out of brew.sh and start poking around in .bash_profile, debugging their lack of git completion.
Thoughts?

+1. It also requires for git to be installed via brew, so the required commands for git completions to work are as follows:
brew install git
brew tap homebrew/versions
brew install bash-completion2

There are a couple of commands which depends on https://github.com/mathiasbynens/dotfiles/blob/master/brew.sh. This part of the dotfiles is also depends brew.sh. It might be better to leave a note for in README file to indicate some of the features are depends on other packages which are installed by brew.sh.

I'm happy to add that into the README if someone can sign off on it. :)

Proposed some changes to README. :)

The problem with this change is that there are now 3 different places that need updating whenever the command to install Bash completion changes.
How about just making the README.md change, without explicitly repeating the installation commands there? I.e. just this part:

Some of the functionality of these dotfiles leverages formulae installed by brew.sh. If you don't plan to run brew.sh, you should look carefully through the script and manually install any particularly important ones. A good example is bash/git completion: the dotfiles use a special version from Homebrew. To enable bash completion without running brew.sh:

Simplified changes to just the README and condensed it to a single paragraph. I think it's still helpful to specify instructions on how to install this particular flavor of bash-completion, which is not immediately obvious. LMK if you think it's fine to have it as a single line, or I can nix it if you still feel strongly about it.

Thanks!


broken interface for response.url

The docs say that response.url is a string, but, it's currently yarl.URL ... I see that the conversion to using yarl is new?
While I'm in there, can I note that response.host is useless, because it doesn't have a port? At best it's a misleading interface.

Docs reflects the latest release but response.url became a yarl.URL in master only.
Maybe it's wrong idea and yarl.URL property should have own name.
I didn't polish the API yet.
Suggestions? resp.url_obj looks ugly.
Agree about host.

Changing the interface after 1.0, not so nice!
I agree resp.url_obj is a little ugly, but I can't think of a better name. I do like the idea of access to an object, because I have a crawler which sometimes spends a lot of cpu time manipulating urls.

Fixed by #1295


variable is set to the same value as it has

SUMMARY
Boolean variable is set to false inside conditionally executed branch when this value is set to false.
Automated Checks

[x] I have run ./gradlew test and made sure that my PR does not break any unit test.
[x] I have run ./gradlew checkstyleMain or the equivalent and corrected the formatting warnings reported.

Merging.


Pre-support for colocated suite

We want to be able to move the contents of ceph-qa-suite.git into ceph.git. This PR adds the functionality needed to test the remaining changes that are required for that support.
@liewegas: This is built around the user only having to supply a single argument to teuthology-suite: -C or --colocated-suite <relpath>; in your case you'd use -C qa to point inside the subdir.

This still allows for a --suite-branch to be specified, right? Because I
think that will still be important in many cases.  E.g., I already have a
build i want to test, but I'm fiddling with the tests.  In that case, I'd
probably actually want to specify the --suite-repo as
github.com/liewegas/ceph.git and avoid pushing to the ceph[-ci].git
entirely and triggering new builds.
The approach I had in mind was:

add --suite-repo (defaults to github.com/ceph/ceph-qa-suite.git, later
to ceph[-ci].git)
add --suite-repo-path (default to '' now, 'qa' later)
make --suite-branch default to whatever -c is (i think it does that
now?)

?

@liewegas it would still support different branches, yeah. If you use -c master and -C qa --suite-branch wip-foo it would use a ceph repo with wip-foo checked out for the suite bits.
The one thing it wouldn't support is if you for some reason want to test ceph.git with suite bits in e.g. ceph-ci.git

Going to take another approach