Support Google AdSense in Flutter Web applications

I tried to implement the next script(Google Ad-sense) at my Flutter Web site, but unsuccessful by now. The code is:
<script type="text/javascript">var nend_params={"media":00000,"site":000000,"spot":000000,"type":1,"oriented":1};0</script>
<script type="text/javascript" src="https://js1.nend.net/js/nendAdLoader.js"></script>

I understood, that Flutter web is currently in technical preview, but may be any route? Any advice and suggestions will be greatly appreciated.

We will treat this as a request to support Google AdSense. We are not actively working on this right now. Perhaps someone outside the Flutter team could try building a plugin, but we expect some rough edges.

the title doesn’t match the contained script a bit, admin it.

@alex89607 I do not understand why the title should match the script.

the title for "Google AdSense", and script for "nend.net".
and then I want to write "the title doesn’t match the contained script a bit, I admit it."

Ah, I was going off of the issue description rather than the script. We could certainly change the description and the script to match exactly what we want to do in this area. I think it's ok to leave it as is until we start actively investigating it.

Just a comment, but the lack of a way to integrate AdSense and other monetizing (JavaScript) based solutions is going to seriously limit the adoption of Flutter for Web.

4 Months passed, is there still no opportunity to integrate AdSense on Flutter Web Projects ?

Hi, try using Admob

@codermihirpaldhikar did you ever tried to integrate Admob to your Flutter Web Project ?

@LichtenbergM I haven't But I am going to use. Why is there any problem?

Hi, admob is meant for mobile and if I'm correct, and I think I am, I've seen something forbidding the use on web pages

any update?

any update?

I've e-mailed with AdMob & AdSense support, and here is what I have gathered with respect to support for Google ads in Flutter web apps.
AdMob only has Android & iOS SDKs available, so it will not work for Flutter web apps, even if you use one of the Flutter AdMob plugins. No one at AdMob support seems to have heard of Flutter, so it is unlikely they will provide an SDK that works with Flutter anytime soon.
AdSense is Google's web site ad publishing platform, and is designed for sites with primarily text-based content because the crawlers it uses can only scan text. Since Flutter web apps are basically JavaScript web apps, AdSense will never be able to crawl your app and so AdSense will not work for Flutter sites. No one at AdSense seems to have hard of Flutter either, so it is unlikely they will provide support for Flutter sites anytime soon.
Basically, there is currently no method to monetize a Flutter web app using ads and no plan by Google to create one. This is remarkable, considering ads are Google's primary source of revenue and Flutter is being so heavily promoted to developers.
After spending weeks porting my native Android & iOS apps to Flutter in the hopes of being able to provide a web app that I can also monetize, I've decided to scrap my Flutter implementation. I'm sharing my experience so no one else depending on the ability to monetize their web app wastes so much time building it in Flutter like I did.

The limitation with using AdSense with Flutter is related to the limitation described here: https://github.com/flutter/flutter/issues/46789

I don't know if this is helping anyone, but what I'm going to try is make a web server in Go, and if the user agent is a bot, render the page with the chrome-render plugin, and serve the result instead of the original site.
Much like prerender.io, which may be useful too. It can be used with Apache/NGINX etc.

I don't know if this is helping anyone, but what I'm going to try is make a web server in Go, and if the user agent is a bot, render the page with the chrome-render plugin, and serve the result instead of the original site.
Much like prerender.io, which may be useful too. It can be used with Apache/NGINX etc.

I've e-mailed with AdMob & AdSense support, and here is what I have gathered with respect to support for Google ads in Flutter web apps.
AdMob only has Android & iOS SDKs available, so it will not work for Flutter web apps, even if you use one of the Flutter AdMob plugins. No one at AdMob support seems to have heard of Flutter, so it is unlikely they will provide an SDK that works with Flutter anytime soon.
AdSense is Google's web site ad publishing platform, and is designed for sites with primarily text-based content because the crawlers it uses can only scan text. Since Flutter web apps are basically JavaScript web apps, AdSense will never be able to crawl your app and so AdSense will not work for Flutter sites. No one at AdSense seems to have hard of Flutter either, so it is unlikely they will provide support for Flutter sites anytime soon.
Basically, there is currently no method to monetize a Flutter web app using ads and no plan by Google to create one. This is remarkable, considering ads are Google's primary source of revenue and Flutter is being so heavily promoted to developers.
After spending weeks porting my native Android & iOS apps to Flutter in the hopes of being able to provide a web app that I can also monetize, I've decided to scrap my Flutter implementation. I'm sharing my experience so no one else depending on the ability to monetize their web app wastes so much time building it in Flutter like I did.

I don't think the challenge is as true as you said. Flutter web apps are compiled to html, css and javascript just like any website. Adsense code could be added to the javascript manually. Though I must admit there would be rough edges but I don't think it should be too challenging for Google to implement. It's just delicate and so they would take it slow but developers are anxious.

@Greatcallie agree, but we need at least P5 priority. Current P6 means "feature we're unlikely to address". Let's add more thumbs up for the question.

Still waiting. Google cares about adaptation, doesn't care amount app monetization for developers.

Go to work, Google.. TT... I'm waiting

................👎 still waiting

Im trying to give flutter web a chance but it seems hopeless I can use html & js instead. Bye flutter

Im trying to give flutter web a chance but it seems hopeless I can use html & js instead. Bye flutter

According the aswer of this question, it is possible show adsense ads and get impressions using PlatformView on Flutter Web: https://stackoverflow.com/questions/63985740/how-to-insert-adsense-display-ad-in-flutter-web/63987672?noredirect=1#comment114864180_63987672

@d-apps That solution sounds promising but it sounds like that developer has previously had their website approved for AdSense, presumably before implementing a Flutter-based site. If you already have created a Flutter-based site, it seems impossible to get it approved for AdSense since it is a JS-based SPA.
The frustration is that the Flutter team does not acknowledge the existence of AdSense, and the AdSense team doesn't acknowledge the existence of Flutter, despite both projects being wholly owned by Google.

The Flutter team works very closely with the Ads team. You can read about our progress and plans here: https://medium.com/flutter/new-ads-beta-inline-banner-and-native-support-for-the-flutter-mobile-ads-plugin-e48a7e9a0e64

@csells Thanks for the article. The issue it references is https://github.com/flutter/flutter/issues/12114 which seems to specifically address supporting AdMob Native ads, which would only support Android & iOS.
My issue is lack of support for Flutter Web, which this would not address. Numerous comments on that issue also inquire about this but no response to any of them.

We're working on having a solid solution in place for our production-quality Android and iOS platforms first before we can support ads on the beta web platform. As I'm sure you can imagine, preventing fraud is hard work and a prerequisite for ad support on any platform.

any update?
Do you have a guess when it is presented?

It's nonsense that there are still no ads on the flutter web.

We have been waiting for an ad plug-in for 1 year

@csells is it correct to assume that with the release of flutter, which brings web to the stable channel and the release of the new "official" ads plugins that seems to bring a solid solution to mobile, now web will be moved up on the priority list? It would be good to have some ETA for people planning to start projects in flutter that need to target web and use ads to know if/when flutter could be a viable option for that.

@LichtenbergM I haven't But I am going to use. Why is there any problem?

Admob only have Android and ios sdk... it's not supported on web..

So, there is still no way to display any kind of ads in my flutter web app? :(

As an early supporter and adopter of Flutter, I started building my company's web app with Flutter web months ago because the technology was very cool, and I believed that with the stable release of web sometime this year that these issues would be solved. It's very disappointing to see the Flutter team outright ignoring these issues. The fact that @csells referenced ad support in mobile in a thread about ad support in web is unbelievably frustrating. I truly am a fan of Flutter web, and have praised it while others denounce it, but how can any of us continue to support Flutter web when the Flutter team slaps the stable tag on it and calls it a job well done when functionality as important as keeping a project economically sustainable is not even being addressed?
If Flutter web is a cute party trick to build prototype web apps and show off the JS compiler, don't call it stable.
Hoping ad support comes soon so I don't have to scrap the web project that I hoped would broaden people's view of Flutter web.

Clipping from the repository documentation

If the issue is labeled P5 or P6, we are not currently expecting to ever work on it (especially P6).

It is very sad that such an important functionality for the development of flutter in the WEB is not planned to be developed.

The only explanation I can think of is that Flutter web is released with Html, CSS and Javascript and that makes it a regular site. And as a regular site the Adsense protocols will have to be followed until they approve your site for Adsense and then you can integrate the Adsense codes just like other websites do.

A problem with the AdSense way, is that it does not target SPAs, but websites with a lot of content.
If you publish a web app, with a simple landing page, AdSense will not approve your website for ads (most likely, as far as I know and have experienced, please tell me if you experienced the opposite) because of "lack of content". While, AdMob is a lot lot more "open" to just simple apps.
That's why it'd make A LOT of sense to have AdMob for Flutter.

Single landing page may not be the challenge. There are other factors like usefulness, traffic, account activation and domain. Flutter apps are released on different platforms as native applications. And just like on Desktop and others you can't expect Admob to monetise on all platforms. So when Flutter gets to any platform it must blend and behave like others.

A problem with the AdSense way, is that it does not target SPAs, but websites with a lot of content.
If you publish a web app, with a simple landing page, AdSense will not approve your website for ads (most likely, as far as I know and have experienced, please tell me if you experienced the opposite) because of "lack of content". While, AdMob is a lot lot more "open" to just simple apps.
That's why it'd make A LOT of sense to have AdMob for Flutter.

And considering the fact that a Web app built with Flutter cannot be differentiated from a regular website. In other words, a finished Flutter web app cannot be traced to flutter in any way. Therefore this becomes an Adsense issue and it should be closed here.

And considering the fact that a Web app built with Flutter cannot be differentiated from a regular website. In other words, a finished Flutter web app cannot be traced to flutter in any way. Therefore this becomes an Adsense issue and it should be closed here.

Flutter web does not compile to HTML and CSS like any other website as you have suggested. Your Flutter code only compiles to JavaScript. When someone opens your site it opens a blank HTML page and then covers it with a canvas that your Flutter app is drawn on by the JS service worker. Distinguishing a normal HTML+CSS website from a Flutter web app is as easy as inspecting element on the website and noticing that there is no actual HTML or CSS.

Thanks for the correction.
On Wed, 9 Jun 2021, 12:51 pm Landon, @.***> wrote:

And considering the fact that a Web app built with Flutter cannot be
differentiated from a regular website. In other words, a finished Flutter
web app cannot be traced to flutter in any way. Therefore this becomes an
Adsense issue and it should be closed here.
Flutter web does not compile to HTML and CSS like any other website as you
have suggested. Your Flutter code only compiles to JavaScript. When someone
opens your site it opens a blank HTML page and then covers it with a canvas
that your Flutter app is drawn on by the JS service worker. Distinguishing
a normal HTML+CSS website from a Flutter web app is as easy as inspecting
element on the website and noticing that there is no actual HTML or CSS.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/40376#issuecomment-857629331,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AK57Y2K4DVNMU24Y4ACWYYLTR5IV5ANCNFSM4IWI4EAA
.

I tried to implement the next script(Google Ad-sense) at my Flutter Web site, but unsuccessful by now. The code is:
<script type="text/javascript">var nend_params={"media":00000,"site":000000,"spot":000000,"type":1,"oriented":1};0</script>
<script type="text/javascript" src="https://js1.nend.net/js/nendAdLoader.js"></script>

I understood, that Flutter web is currently in technical preview, but may be any route? Any advice and suggestions will be greatly appreciated.

Is your flutter web approved by AdSense? I am getting Valuable inventory: No content to my flutter website www.droidbiz.in My website has so many pages with content. Not able to understood why AdSense is rejecting my request.

Any update?

any news?

Patiently waiting for any updates..
One idea that I had was to add AdSense to an empty HTML page and then add Flutter app to the html page. Would that work? Or would the html page get rejected due to lack of content because AdSense would ignore the Flutter app?

It would not work as you mentioned due to lack of content. What I was thinking there is the package SEO renderer which is render the elements as HTML for SEO purposes. Maybe it will help AdSense to recognise the content of the site and the will approve it. To add the AdSense itself you can do it through a platform view

Flutter development process is too slow.. 😕

Any update?

it's been really 1 year still no improvement :((

@csells  Any updates? We are still waiting for solution.

is there any progress on this thread ?

So what's the solution to show ads on flutter web? Why isn't admob being enhanced to support flutter web? or at least an intermediate adsense plugin? We really need something.

So what's the solution to show ads on flutter web? Why isn't admob being enhanced to support flutter web? or at least an intermediate adsense plugin? We really need something.

As a workaround I've considered doing an iframe to load a site of mine that is Adsense approved which will show an ad. Think interstitial but instead load a url.
I'm hesitant though because it likely violates something somewhere. If any Googler could confirm or deny this that would be awesome!
Don't make me be a rebel! 😇

So what's the solution to show ads on flutter web? Why isn't admob being enhanced to support flutter web? or at least an intermediate adsense plugin? We really need something.

As a workaround I've considered doing an iframe to load a site of mine that is Adsense approved which will show an ad. Think interstitial but instead load a url.
I'm hesitant though because it likely violates something somewhere. If any Googler could confirm or deny this that would be awesome!
Don't make me be a rebel! 😇

not a solution

I left my banner ad implementation to the end of my project, alas I was not aware of this grave limitation. It was so unthinkable for me that I did not even bother checking if banner ads was possible for Web Apps using flutter. I am shocked. Google please create the necessary package to allow Admob or Adsense in Flutter Web as I am sure this framework will lose all its followers otherwise.

Hi, Is there any updates

Any updates on this? So we can't monetize our flutter web apps by adding ads?

WTF , I WAS WAITING FOR MORE THAN 3 YEARS ,

If Flutter could export the web app not just as a PWA but html pages that might solve this problem. Alternatively, here are some Stackoverflow solutions for PWAs
https://stackoverflow.com/questions/57135062/google-ads-solution-for-pwa-spa
https://stackoverflow.com/questions/65736507/is-there-a-way-to-add-google-adsense-or-admob-to-an-ionic-angular-pwa

Guys... its 4 years already... Any updates??????????

I am absolutely floored having just found out that this is a limitation of Flutter web and even more so that it is not being actively addressed but rather ignored (and for such a long time). I was truly convinced that Flutter was the right choice for my pet project, it seemed to tick all the right boxes. Sadly it doesn't seem like that is the case anymore. Please Flutter team, address this issue or at least let us know where it sits on the roadmap (if at all) so people can make informed decisions about whether this is the right tool for them or not.

Hello all i came across this package https://pub.dev/packages/admanager_web please have a look as adunitid is for admob but this package suggests that its supports adsense ad most of you all may know about this, is this working and use full and how about 3rd party ad platforms like ezonic i have opened an account with them but their waiting time(analyzing) is too long and as flutter renders on canvaskit, if i try to place an ad a blank page shows (tried via ezonic). So no luck there too

Flutter Channel stable, 3.3.7
// ignore: undefined_prefixed_name
 ui.platformViewRegistry.registerViewFactory('adsenseView', (int viewID) {
   final frameElement = IFrameElement()
     ..style.width = '100%'
     ..style.height = '100%'
     ..style.border = 'none'
     ..src = 'assets/assets/adsense.html';

   return frameElement;
});

const SizedBox(
  height: 150,
  child: HtmlElementView(
    viewType: 'adsenseView',
  ),
),

Add path to pubspec.yaml
  assets:
   - assets/adsense.html

Copy your google adsense code in adsense.html
<script async src="https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js?client=ca-pub-xxxxxxxxxxxxxxx"
     crossorigin="anonymous"></script>
<ins class="adsbygoogle"
     style="display:block"
     data-ad-format="fluid"
     data-ad-layout-key="xxxxxxxxxx"
     data-ad-client="ca-pub-xxxxxxxxxxxx"
     data-ad-slot="xxxxxxxxxx"></ins>
<script>
     (adsbygoogle = window.adsbygoogle || []).push({});
</script>

This  way only have  web ... it's not supported on android and ios.

Flutter Channel stable, 3.3.7
// ignore: undefined_prefixed_name
 ui.platformViewRegistry.registerViewFactory('adsenseView', (int viewID) {
   final frameElement = IFrameElement()
     ..style.width = '100%'
     ..style.height = '100%'
     ..style.border = 'none'
     ..src = 'assets/assets/adsense.html';

   return frameElement;
});

const SizedBox(
  height: 150,
  child: HtmlElementView(
    viewType: 'adsenseView',
  ),
),

Add path to pubspec.yaml
  assets:
   - assets/adsense.html

Copy your google adsense code in adsense.html
<script async src="https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js?client=ca-pub-xxxxxxxxxxxxxxx"
     crossorigin="anonymous"></script>
<ins class="adsbygoogle"
     style="display:block"
     data-ad-format="fluid"
     data-ad-layout-key="xxxxxxxxxx"
     data-ad-client="ca-pub-xxxxxxxxxxxx"
     data-ad-slot="xxxxxxxxxx"></ins>
<script>
     (adsbygoogle = window.adsbygoogle || []).push({});
</script>

This way only have web ... it's not supported on android and ios.

Hi...tried this.  Seems to work except getting a blank section.  I assume this is something to do with how the adSense is setup, but was wondering if you had any insight.

Yes Google AdSense Accept my Flutter Web Application.  Flutter Web Application Support Google AdSense. Hope Your Flutter Web Application have quality content and have proper setup.
You can add Adsense ad unit In Flutter Web with the help of below widget. It's work perfectly fine.
create widget with any name you like. I'm named BannerAdUnit
only replace ad unit id as you can see in the below widget inside html body tag.
import 'dart:html' as html;
import 'dart:ui' as ui;

import 'package:flutter/material.dart';

String viewID = "your-view-id";

class BannerAdUnit extends StatelessWidget {
  const BannerAdUnit({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
  ui.platformViewRegistry.registerViewFactory(
  viewID,
  (int id) => html.IFrameElement()
  ..style.width = '100%'
  ..style.height = '100%'
  ..srcdoc = '''
        <!DOCTYPE html>
 <html> <head> </head> <body>
                     <div data-frill-widget="your ad unit id will come here" style="width: 340px; height: 460px;"></div>
 <script async src="url"></script>           </body>
 </html>           '''
  ..style.border = 'none');

  return SizedBox(
  height: 460,
  width: 340,
  child: HtmlElementView(
  viewType: viewID,
  ),
  );
  }
}

The story is not end here. When you add the above code You will see one beautiful error something like that.

The name 'platformViewRegistry' is being referenced through the prefix
'ui', but it isn't defined in any of the libraries imported using that
prefix. (Documentation)

How to fix this error? Don't worry I'll show you how to fix this error.
Create new file on the root name it analysis_options.yaml
and copy and paste the below code and the error is gone.
analyzer:
  errors:
    undefined_prefixed_name: ignore

Note: On the debugging mode flutter Web app not show you any ads.
if you want to see ads deploy your Flutter Web App. you will see ads like this.

We are using Freestar ads on our flutter web and it is working near perfectly except sometimes chrome killing the ad iframe labeling it as "using too much resources." Haven't had time to dig in to that.

@rafaelmaia8384 We are using Freestar ads on our flutter web and it is working near perfectly except sometimes chrome killing the ad iframe labeling it as "using too much resources." Haven't had time to dig in to that.

Thank you for the tip, could you talk more about the approval process? Is it instant? Which library did you use to implement the ads in Flutter?

It wrote it myself. The code is not in a position to be released publicly yet but I plan to do that sometime next month.
Basic idea is create html div as a flutter node (platformaViewRegistry and HTMLElementView); insert typical ad scripts in index.html and call JavaScript function from flutter that does the ad display task.

Any updates?

I would also appreciate it if flutter web supported adsense as soon as possible because my project is useless without integrating ads.

Yes Google AdSense Accept my Flutter Web Application. Flutter Web Application Support Google AdSense. Hope Your Flutter Web Application have quality content and have proper setup.
You can add Adsense ad unit In Flutter Web with the help of below widget. It's work perfectly fine.
create widget with any name you like. I'm named BannerAdUnit only replace ad unit id as you can see in the below widget inside html body tag.
import 'dart:html' as html;
import 'dart:ui' as ui;

import 'package:flutter/material.dart';

String viewID = "your-view-id";

class BannerAdUnit extends StatelessWidget {
  const BannerAdUnit({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
  ui.platformViewRegistry.registerViewFactory(
  viewID,
  (int id) => html.IFrameElement()
  ..style.width = '100%'
  ..style.height = '100%'
  ..srcdoc = '''
        <!DOCTYPE html>
 <html>
  <head> </head>
  <body>

        <script async src="https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js?client=ca-pub-xxxxxxxxxxxxxxx"
 crossorigin="anonymous"></script>
 <ins class="adsbygoogle"
 style="display:block"
 data-ad-format="fluid"
 data-ad-layout-key="xxxxxxxxxxxx"
 data-ad-client="ca-pub-xxxxxxxxxxxxxx"
 data-ad-slot="xxxxxxxxxxxx"></ins>
  <script>
     (adsbygoogle = window.adsbygoogle || []).push({});
</script>

  </body>
 </html>           '''
  ..style.border = 'none');

  return SizedBox(
  height: 460,
  width: 340,
  child: HtmlElementView(
  viewType: viewID,
  ),
  );
  }
}

The story is not end here. When you add the above code You will see one beautiful error something like that.

The name 'platformViewRegistry' is being referenced through the prefix
'ui', but it isn't defined in any of the libraries imported using that
prefix. (Documentation)

How to fix this error? Don't worry I'll show you how to fix this error.
Create new file on the root name it analysis_options.yaml and copy and paste the below code and the error is gone.
analyzer:
  errors:
    undefined_prefixed_name: ignore

Note: On the debugging mode flutter Web app not show you any ads. if you want to see ads deploy your Flutter Web App. you will see ads like this.

If you guys don't want to write this spaghetti code try this package flutter_ad_manager_web . I created this helpful package for display Adsense ads on Flutter Web.

How can you confirm it works if you don't see it in dev mode? You just add it and then submit the site for approval to google and hope everything goes well? I've added it and don't see any errors, 200s from the Google Ads apis, however both in development & release I don't see the ads.

Any updates?

the lack of a way to integrate AdSense and other monetizing (JavaScript) based solutions is going to seriously limit the adoption of Flutter for Web.

Yes Google AdSense Accept my Flutter Web Application...
String viewID = "your-view-id";

Note: On the debugging mode flutter Web app not show you any ads. if you want to see ads deploy your Flutter Web App.

How can you confirm it works if you don't see it in dev mode? You just add it and then submit the site for approval to Google and hope?
I added it and don't see any errors, which is good, only 200s from the Google Ads APIs; however in development & release I don't see the ads.
Also, what is viewID here? The GCP property on Google Analytics?
Thanks for much for your help.

As for this, did you get approval from Adsense in production?

@rafaelmaia8384 We are using Freestar ads on our flutter web and it is working near perfectly except sometimes chrome killing the ad iframe labeling it as "using too much resources." Haven't had time to dig in to that.

Thank you for the tip, could you talk more about the approval process? Is it instant? Which library did you use to implement the ads in Flutter?

It wrote it myself. The code is not in a position to be released publicly yet but I plan to do that sometime next month.
Basic idea is create html div as a flutter node (platformaViewRegistry and HTMLElementView); insert typical ad scripts in index.html and call JavaScript function from flutter that does the ad display task.

Did you release the code somewhere? It would be really interesting to see if people found good workarounds for showing ads in flutter web.

This limitation has just killed my flutter web app project. Rebuilding it with node

this has killed so many projects

Bumping to P1, since this is being actively worked on.

@yjbanov FINALLY! After 4 years its on P1 🥳

Bumping to P1, since this is being actively worked on.

@yjbanov
maybe the implementation could have synergies with

https://github.com/flutter/flutter/issues/151058

@sokoloff06 @ditman I saw that https://github.com/flutter/packages/pull/6871 is merged. What does it mean for this feature? Are we close to painless Ads display on web and maybe desktop in the future?

@Tananga Tune in to #FlutterInProduction if you can, on December 17th.

Glad to see the progress, I see it's only available for games, will that change in the future?

In google_adsense package, it said adunit widget is in closed early access. Do we have to wait to use this widget?

Hello, I want to have ads in my Flutter web project.
Will it be possible or not integrate Google AdSense or any ads provider for Flutter Web?
As per chatgpt, it has said it is possible to use as a widget.
So can anyone help me on this?


Add qdrant support

Changes:

Added integration for Qdrant alongside the existing Postgres setup
Configured Qdrant to run in the development environment using docker-compose
Verified the implementation manually to ensure accuracy and proper functionality of the new setup

LGTM!


Xamarin 4.0 and FFImageLoading

Hi People.
I am updating my project to Xamarin 4.0, and I am using skiaSharp 1.68.0 but I have this problem.
/Users/Enzo/Projects/Clarika/Imperial-ClienteFiel/ClienteFiel.Forms.iOS/MTOUCH: Error MT0009: Error while loading assemblies: /Users/hugo/.nuget/packages/skiasharp/1.68.0/runtimes/win-x86/native/libSkiaSharp.dll (MT0009) (ClienteFiel.Forms.iOS)
My question.
Does FFImageLoading support the new version o Xamarin?
Thx!

Make sure you have the same package version in every project
Make sure you have SkiaSharp package installed in every project
remove all bin/obj folders
https://github.com/luberda-molinet/FFImageLoading/wiki/Xamarin.Forms-API#step-1

Hi Daniel.
Yes, I did all the step, but the bug continues.

In Android is running correctly, only in iOS is the bug

I am having the same issue. All package versions are the same in all projects, Android builds correctly, and iOS fails while trying to load libSkiaSharp.

See this: https://github.com/luberda-molinet/FFImageLoading/wiki/SVG-support#important-skiasharp-issue-httpsgithubcomxamarinxamarin-maciosissues5265
Thanks to @HugoTruffe for finding it.

Hi Daniel!!!!
Thanks!!!!! Now I can implement the rest jejejeje.
El jue., 30 may. 2019 a las 11:47, Daniel Luberda<EMAIL_ADDRESS>escribió:

See this:
https://github.com/luberda-molinet/FFImageLoading/wiki/SVG-support#important-skiasharp-issue-httpsgithubcomxamarinxamarin-maciosissues5265
Thanks to @HugoTruffe https://github.com/HugoTruffe for finding it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/luberda-molinet/FFImageLoading/issues/1287?email_source=notifications&email_token=ADE3HZIXJQQ2RFHUZRQHGO3PX7SH5A5CNFSM4HQN6Z2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWSQ4SQ#issuecomment-497356362,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADE3HZII65VHHSEBOTVKQFLPX7SH5ANCNFSM4HQN6Z2A
.


Allow asynchronous custom OAuthStorage implementations

Is your feature request related to a problem? Please describe.
I am using this library in combination with Capacitor to build a cross-platform application.  It is recommended, when working with Capacitor, to avoid localStorage/sessionStorage and instead use the Storage plugin.  Capacitor's Storage plugin has a similar API to OAuthStorage but is async (via promises).
Describe the solution you'd like
Extend the OAuthStorage interface to allow for both synchronous and asynchronous storage.
Describe alternatives you've considered
My workaround for now is to hydrate a custom synchronous in-memory storage instance when the application bootstraps. Internally it keeps the in-memory storage up to date as well as writes to the persistent async storage.
Additional context
N/A

This is a sensible feature request!
However, knowing the code and public API a bit, I'm afraid it's impactful both on the internals and on parts of the public API exposed by the library (breaking existing clients).
Curious to see what the maintainer thinks, maybe there's paths I didn't think of yet? Or maybe some community member could do a PoC PR to show how this would turn out?

There's a great alternative library angular-auth-oidc-client but it has a similar open feature request at the time of writing. If that feature there ever does get implemented while this one here isn't yet, it might be a reason to switch up.

We do really need this feature as we are moving towards capacitor using the @capacitor/storage plugin wich is asynchronous only. So we are kinda blocked here if this oauth package only works synchronous and our storage plugin only works asynchronous :D
Any chance this will be implemented?

+1 for this feature :-)

+1

Using js-cookie could be an persistant, synchronous alternative. Install the Library:
yarn add js-cookie
yarn add -D @types/js-cookie

Import the Library:
import Cookie from 'js-cookie';

Paste this above @NgModule:
export const storageFactory = (): OAuthStorage => ({
  getItem: (key) => Cookie.get(key),
  setItem: (key, value) => Cookie.set(key, value, { expires: 365 }),
  removeItem: (key) => Cookie.remove(key),
});

Paste this into your providers array:
{ provide: OAuthStorage, useFactory: storageFactory },

When using Capacitor, paste this to your capacitor.config.ts to use native libraries to handle cookies in a even more persistant way:
import { CapacitorConfig } from '@capacitor/cli';

const config: CapacitorConfig = {
  plugins: {
    CapacitorCookies: {
      enabled: true,
    },
  },
};

export default config;

I think this currently is the easiest/cleanest integration to store the tokens without loosing them after time. The most secure way would be to use capacitor-secure-storage. But there isn't a clean way to use it for now, as it is asynchronous.

+1


Incomplete code for handling current-scope loop in templates

Found while working on https://github.com/silverstripe/silverstripe-framework/issues/11237
If you create a <% loop %> tag inside a template without including an argument (i.e. not <% loop $MyIterable %>), the template is generated with some very clearly incomplete code, which includes the placeholder "Foo".
Template:
<% loop %>
    // Inside the loop here
<% end_loop %>

Cached template (what actually gets executed):
$scope->obj('Up', null)->obj('Foo', null);
$scope->pushScope();
while (($key = $scope->next()) !== false) {
$val .= '    // Inside the loop here';
};
$scope->popScope();

This is handled by SSTemplateParser::ClosedBlock_Handle_Loop()
The relevant code was added in https://github.com/silverstripe/silverstripe-framework/commit/91f4ba15f15970638da5091639e35daae17f3c6f as part of https://github.com/silverstripe/silverstripe-framework/pull/209 and it seems pretty clear the intention was to loop over whatever is currently in scope (basically a shortcut for <% loop $Me %>) but that for whatever reason the feature was never fully implemented.
PRs

https://github.com/silverstripe/silverstripe-framework/pull/11251
https://github.com/silverstripe/developer-docs/pull/518

PRs merged. Task is completed. Close.


Feature: add command line interface

Next up, we can add interactive CLI and print call stats.

:tada: This PR is included in version 0.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


It is awful that you prevent Home users from enabling hyper v

Please just enable hyper v for Home users. I don't want to fork out £120 just to get Docker working properly on your platform
Thanks
Liam

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 223b9ea7-e2c0-4c6b-6d55-9125274d26ce
Version Independent ID: 85c7005e-33b2-ae0b-a919-f056d14cf0ac
Content: Introduction to Hyper-V on Windows 10
Content Source: virtualization/hyper-v-on-windows/about/index.md
Product: windows-10-hyperv
GitHub Login: @scooley

Closing since this isn't a doc bug but here is a link to upvote on UserVoice

You could at least explain why home licenses are excluded.


pulseeffects: fix autostart

Description
Pulseeffects did not autostart when starting a graphical session.
This PR should fix this.
I haven't done too many systemd-services, I'm not sure if this is the best way.
Checklist

[x] Change is backwards compatible.

[x] Code formatted with ./format.

[x] Code tested through nix-shell --pure tests -A run.all.

[ ] Test cases updated/added. See example.

[x] Commit messages are formatted like
{component}: {description}

{long description}

See CONTRIBUTING for more information and recent commit messages for examples.

If this PR adds a new module

[ ] Added myself as module maintainer. See example.

[ ] Added myself and the module files to .github/CODEOWNERS.

Thanks! Rebased to master in 3886f8db334ab63372bba93586d979f7c184a101.


Evaluate model on 2022 data

Would be great to make this a general method for evaluating the data.
Will might to pull GFS data.
We perhaps need to define a test set so that we can compare with others
@jacobbieker @zakwatts what was the test set we used for pv-site-predictions? Perhaps we could use the same one here

Hey @peterdudfield, I'd be interested in working on this - I'm a first time contributor, would this be a good first issue?

Hi @EdFage, thanks for getting in contact.
The evaluation is a big step, and perhaps it might be easier tfirst to chip of something smaller. I wonder if you could have a go at #5?

Hey @peterdudfield, #5 looks interesting, can i give that one a go?

Yea of course, go for itOn 1 Dec 2023 16:29, EdFage @.***> wrote:
Hey @peterdudfield, #5 looks interesting, can i give that one a go?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Great, I'll crack on

@jacobbieker do you have a snippet of code, that can be used to get ICON data from our Hugging Face?

One way to do this is this (after logging into Hugging Face and accepting the conditions for the ICON dataset):
import ocf_blosc2
import xarray as xr
from huggingface_hub import HfFileSystem

fs = HfFileSystem()
# List which files are available. Not all dates, and model run times are available
print(fs.ls("datasets/openclimatefix/dwd-icon-eu/data/2022/4/11/", detail=False))

data = xr.open_zarr(
    "zip:///::hf://datasets/openclimatefix/dwd-icon-eu/data/2022/3/14/20220314_18.zarr.zip"
)
print(data)

One way to do this is this (after logging into Hugging Face and accepting the conditions for the ICON dataset):
import ocf_blosc2
import xarray as xr
from huggingface_hub import HfFileSystem

fs = HfFileSystem()
# List which files are available. Not all dates, and model run times are available
print(fs.ls("datasets/openclimatefix/dwd-icon-eu/data/2022/4/11/", detail=False))

data = xr.open_zarr(
    "zip:///::hf://datasets/openclimatefix/dwd-icon-eu/data/2022/3/14/20220314_18.zarr.zip"
)
print(data)

nice this worked for me


Compilation is not supported in this build error

Environment

Operating System: Darwin
Node Version:     v16.16.0
Nuxt Version:     3.6.2
Nitro Version:    2.5.2
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
https://stackblitz.com/edit/nuxt-starter-3kuem5?file=nuxt.config.ts
Describe the bug
After updating to the latest edge channel version, I get the following error:
[intlify] The message format compilation is not supported in this build. Because message compiler isn't included. You need to pre-compilation all message format. So translate function return 'common.close'.
Additional context
No response
Logs
No response

I got the same problem

Thank you for your reporting!
I've noticed that<EMAIL_ADDRESS>is installed in your reproduction.
I dont know how you installed it, but once clean with rm -rf node_modules package-lock.jsonand trynpm install`.
I think you can see to work correctly.

@kazupon Fixed after removing node_modules & package-lock.json and re-installing. Thanks!


create a standalone navbar app

So this can be easily integrated with the static content..

This seems like it might have some relevance to #493 .

Navbar is currently it's own directive and can be included in a static document pretty easily. Closing this issue.


Using Azure agents for building .Net Framework 4.8

We use agent version: '2.150.3' on a private build server and when we try to build a .Net application using Framework version 4.8, the build failed.
We get the following errors:
C:\Program Files (x86)\MSBuild\14.0\bin\amd64\Microsoft.Common.CurrentVersion.targets(1098,5): Error MSB3644: The reference assemblies for framework ".NETFramework,Version=v4.8" were not found. To resolve this, install the SDK or Targeting Pack for this framework version or retarget your application to a version of the framework for which you have the SDK or Targeting Pack installed. Note that assemblies will be resolved from the Global Assembly Cache (GAC) and will be used in place of reference assemblies. Therefore your assembly may not be correctly targeted for the framework you intend.
C:\Program Files (x86)\MSBuild\14.0\bin\amd64\Microsoft.Common.CurrentVersion.targets(1098,5): Error MSB3644: The reference assemblies for framework ".NETFramework,Version=v4.8" were not found. To resolve this, install the SDK or Targeting Pack for this framework version or retarget your application to a version of the framework for which you have the SDK or Targeting Pack installed. Note that assemblies will be resolved from the Global Assembly Cache (GAC) and will be used in place of reference assemblies. Therefore your assembly may not be correctly targeted for the framework you intend.
Process 'msbuild.exe' exited with code '1'.

We have installed the latest version of:

The Azure agent (2.150.3)
Visual studio 2017
.NET SDK

The same problem rises when using a Azure hosted agent "Hosted Windows 2019 with VS2019"
Please fix

@Shortcheese this it not an agent issue, the agent run you build and report failure successfully, looks like an environment issue, like missing SDK, etc.
please open ticket on  https://developercommunity.visualstudio.com/spaces/21/index.html for help


Add release notes

please add release notes with react native compatibility versions
I think it is worth to add which version of this package is compatible with which version of react native

Done: https://github.com/Andr3wHur5t/react-native-keyboard-spacer/releases

tks


Cloud 7 updates repo is needed when doing Cloud6->7 upgrade

This was removed by https://github.com/SUSE-Cloud/automation/pull/1736

@jsuchome Pardon my ignorance, but could you please clarify why this is needed? (preferably in the commit mesages)

doesnt seem like it was removed, but it changed for adding that repo to all cloud7 repos (develcloud7|susecloud7|M?|Beta*|RC*|GMC*) to only adding that repo if the cloudsource is GM7+up[0]
Shouldnt we use GM7+up as the upgrade_cloudsource instead of forcing the add of the repos?
:-1: from me
[0] https://github.com/SUSE-Cloud/automation/pull/1736/files#diff-c202af9895fd7be9224b15a93a00b0ffR945

@Itxaka It will not work as we might need recent not-yet-released patches for tests in SOC7 , and those are only in develcloud7.

If GM7+up is delivering the same packages for use as develcloud7, i would be fine with that.
But I'm afraid that's not true, with develcloud7 we get Cloud iso from Staging which is where our current patches to master go automatically, before official approval as maintanance updates. I think.

@jsuchome @vmoravec ahh, indeed :(


Plugin Structure and WordPress Coding Standards

@pitbulk are you open to other pull requests? I see a few other tasks related to making the plugin compatible with composer/wpackagist. I could also help with automating deployment to wordpress.org using GitHub actions, sweep for WordPress coding standard, code organization, etc.

Obivously, one of the bigger items to tackle is the plugin structure and moving things around if you wanted to support wpackagist (which is something we'd love to utilize and help implement). I didn't want to step on your toes if you're doing things. But there are some things at @linchpin we'd want to do to help if you and @onelogin are open to it.

Obivously, one of the bigger items to tackle is the plugin structure and moving things around if you wanted to support wpackagist (which is something we'd love to utilize and help implement). I didn't want to step on your toes if you're doing things. But there are some things at @linchpin we'd want to do to help if you and @onelogin are open to it.

Sure, I'm always open to contribution.
The plugin is not following WP coding standard because I maintain SAML toolkits for PHP, Python, Ruby and Java as well as plugins for other open source solutions, so at the end for me is almost impossible to write each toolkit/plugin with the perfect syntax.  But if you take the time to apply the formats as well as help with the development cycle, perfect.

Sure, I'm always open to contribution.
The plugin is not following WP coding standard because I maintain SAML toolkits for PHP, Python, Ruby and Java as well as plugins for other open source solutions, so at the end for me is almost impossible to write each toolkit/plugin with the perfect syntax.  But if you take the time to apply the formats as well as help with the development cycle, perfect.

btw I'm releasing a new version with the fix (3.3.1) and your proposal could go in a future 3.4.0 version
Adopt composer in order to handle dependencies like php-saml would be great

btw I'm releasing a new version with the fix (3.3.1) and your proposal could go in a future 3.4.0 version
Adopt composer in order to handle dependencies like php-saml would be great

Sounds good to me. I'm going to close this out and make issues in the linchpin/wordpress-saml fork.  I know that @nate-allen from our side also had some ideas regarding some filters that would be really useful as well.

Sounds good to me. I'm going to close this out and make issues in the linchpin/wordpress-saml fork.  I know that @nate-allen from our side also had some ideas regarding some filters that would be really useful as well.


Failing to build GDExtension according to tutorial; KeyError: 'is_bitfield'

Tested versions

Reproducible in: master (48afa82), 4.2 (54136ee), 4.1 (631cd5f), 4.0 (2fdac1c)
GDExtension does not exist in previous versions

System information
Godot v4.2.beta4 - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2060 (NVIDIA; <IP_ADDRESS>92) - Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz (12 Threads)
Issue description
I am trying to create a new extension for Godot v4. I am following the documentation here and using VSCode: https://docs.godotengine.org/en/4.2/tutorials/scripting/gdextension/gdextension_cpp_example.html; I am able to do everything up to the step where I generate and compile the bindings.
I am running the following command inside of godot-cpp:
scons platform=windows custom_api_file=C:\Users\hayan\LocalDocuments\Programming\Gamedev\testProj\extension_api.json
However, instead of the bindings being generated, I get the following error:
PS C:\Users\hayan\LocalDocuments\Programming\Gamedev\testProj3\godot-cpp> scons platform=windows custom_api_file=C:\Users\hayan\LocalDocuments\Programming\Gamedev\testProj3\extension_api.json
scons: Reading SConscript files ...
Auto-detected 12 CPU cores available for build parallelism. Using 11 cores by default. You can override it with the -j argument.
Building for architecture x86_64 on platform windows
scons: done reading SConscript files.
scons: Building targets ...
scons_generate_bindings(["gen\include\godot_cpp\core\ext_wrappers.gen.inc", "gen\include\godot_cpp\variant\string.hpp",

(Then it continues the big list of a bunch of files that are part of the engine),
 "gen\include\godot_cpp\classes\global_constants.hpp", "gen\include\godot_cpp\classes\global_constants_binds.hpp", "gen\include\godot_cpp\core\version.hpp", "gen\src\variant\utility_functions.cpp"], ["C:\Users\hayan\LocalDocuments\Programming\Gamedev\testProj3\extension_api.json", "gdextension\gdextension_interface.h", "binding_generator.py"])
Built-in type config: float_64
scons: *** [gen\include\godot_cpp\core\ext_wrappers.gen.inc] KeyError : 'is_bitfield'
Traceback (most recent call last):
  File "C:\Python310\lib\site-packages\SCons\Action.py", line 1279, in execute
    result = self.execfunction(target=target, source=rsources, env=env)
  File "C:\Users\hayan\LocalDocuments\Programming\Gamedev\testProj3\godot-cpp\binding_generator.py", line 152, in scons_generate_bindings
    generate_bindings(
  File "C:\Users\hayan\LocalDocuments\Programming\Gamedev\testProj3\godot-cpp\binding_generator.py", line 176, in generate_bindings
    generate_global_constants(api, target_dir)
  File "C:\Users\hayan\LocalDocuments\Programming\Gamedev\testProj3\godot-cpp\binding_generator.py", line 1707, in generate_global_constants
    if enum_def["is_bitfield"]:
KeyError: 'is_bitfield'
scons: building terminated because of errors.

Steps to reproduce
I am just following the tutorial linked above
Minimal reproduction project (MRP)
testProj.zip

What version of Godot was the API generated from? And what version of godot-cpp are you using?

Ah I see, I was generating the API from Godot Engine v4.0.alpha.calinou.0c5f25495 while calling godot --dump-extension-api. I had downloaded Godot 4.2, but I guess my Godot PATH variable was still set to the old version. Let me try to change it to the new Godot version and try again


[pulsar-broker-admin] Fix: split bundle overwrites local-policies

Motivation
Namespace LocalPolicies contains bundle-data and bookie-isolation-policy. Split-bundle API overwrites local-policies because of that we lose configured bookie-isolation-policy on that cluster.
Modification
Update LocalPolicies instead overwriting while bundle-split.

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


[Bug] Composite Losing Saturation on Alpha Pixels

Hi, First of all , i want to congratutions @oliver-moran for this awesome module.
This is stuning awesome. :+1:

The bug. Png Alpha pixes are losing quality and saturation when the background is alpha.
But if the background is solid the alpha pixels are render 100% correct.

In composite images*

Original

Write in Jimp

The yellow and green have 58% alpha... The stroke of this evil goblin have a bit glow alpha pixels.
Edit:
The problem happens when you make an image as new Jimp and use as composite.

[Personal Fix]
Buged Code
new Jimp(100,100,function(err, image){

Fix
new Jimp('./test/emptyPixel.png',function(err, image){
// emptyPixel.png = image with 1x1pixels of 100% alpha

Unforntunatly it not accept the empty pixel image as Base64 like that.
new Jimp(new Buffer('iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVQI12P4zwAAAgEBAKrChTYAAAAASUVORK5CYII=', 'base64'),function(err, image){

Change the background color from
0x00000000
to
0xffffff00
Make it brighter than normal.

Thanks for catching this. It will be fixed in a new release over the weekend. The problem was down to a naive compositing algorithm. I've implemented a proper algorithm using the standard formula.

I saw. I tried to without success fix on jimp.scan myself.
Fortunatly jimp.blit is all i need for my project.
I really enjoy code in jimp.
Jimp > All others.


Maintainers

@archer884 Thanks for creating harsh 💪 Would you like to be added as a maintainer to this repo? I see you have a cool builder method, which I haven't implemented in this library.

Closing as inactive. Re-open if needed.


Guile REPL is started when in Racket REPL

This only happens When geiser-mode-start-repl-p is t, and in the racket repl. (I tested guile repl, don't have chicken installed at the moment)
To reproduce:
    $ emacs -Q
    M-x load-file /path/to/geiser.el
    M-: (setq geiser-mode-start-repl-p t)
    M-x run-racket
    racket@> (*

Anything you type after the open paren will trigger this.
Here Is geiser message After C-u M-x geiser-show-logs:
INFO: REQUEST: <2>: ,geiser-eval #f #f ,apply geiser:autodoc ('(*))

INFO: REQUEST: <1>: ,use (geiser emacs)
'done

INFO: RETORT: ((error (key . retort-syntax)) (output . "$1 = done
scheme@(guile-user)> "))

INFO: <1>: processed

INFO: REQUEST: <2>: ,geiser-eval (geiser evaluation) ge:set-warnings ((quote medium)) ()

INFO: RETORT: ((result "#<unspecified>") (output . ""))

INFO: <2>: processed

INFO: <2>: processed

Im using
GNU Emacs 24.5.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.16.6) of 2015-09-09 on foutrelis
On a 64 bits Arch linux
And geiser 20160215.1732 from melpa.
I'ts late so I didn't track this further. I will update If I learn anything new.

this is a funny one! i can reproduce it, and i will take a look as soon
as i can... thanks for the report!

I got a backtrace for this:
  run-geiser(guile)
  geiser-mode(1)
  turn-on-geiser-mode()
  geiser-mode--maybe-activate()
  run-hooks(change-major-mode-after-body-hook prog-mode-hook scheme-mode-hook)
  apply(run-hooks (change-major-mode-after-body-hook prog-mode-hook scheme-mode-hook))
  run-mode-hooks(scheme-mode-hook)
  scheme-mode()
  geiser-syntax--font-lock-buffer()
  geiser-autodoc--str(("let" 0) (("name" . let) ("args" (("required" \.\.\.) ("optional") ("key"))) ("module" . "racket/private/qq-and-or")))
  geiser-autodoc--autodoc((("let" 0)) (("let" ("name" . let) ("args" (("required" \.\.\.) ("optional") ("key"))) ("module" . "racket/private/qq-and-or"))))
  geiser-autodoc--show-signatures(((result "((let (\"name\" . let) (\"args\" ((\"required\" ...) (\"optional\") (\"key\"))) (\"module\" . \"racket/private/qq-and-or\")))") (output . "")))
  geiser-con--process-completed-request(((:id . 2) (:string . ",geiser-eval #f #f ,apply geiser:autodoc ('(let))") (:continuation . geiser-autodoc--show-signatures) (:buffer . #<buffer * Racket REPL *>) (:connection t (:filter . comint-output-filter) (:tq ((nil "\\(\n\\(mzscheme\\|racket\\)@[^ ]*> \\)" #0 . geiser-con--process-completed-request)) #<process Racket REPL> . #<buffer  tq-temp-Racket REPL>) (:tq-filter lambda (p s) (geiser-con--tq-filter (quote (((nil "\\(\n\\(mzscheme\\|racket\\)@[^ ]*> \\)" #0 . geiser-con--process-completed-request)) #<process Racket REPL> . #<buffer  tq-temp-Racket REPL>)) s)) (:eot . "\\(\n\\(mzscheme\\|racket\\)@[^ ]*> \\)") (:prompt . "\\(mzscheme\\|racket\\)@[^ ]*> ") (:debug-prompt) (:is-debugging) (:count . 2) (:completed . #s(hash-table size 65 test eql weakness value rehash-size 1.5 rehash-threshold 0.8 data (1 ((:id . 1) (:string . ",geiser-eval geiser/user #f (image-cache)") (:continuation) (:buffer . #<buffer * Racket REPL *>) (:connection t (:filter . comint-output-filter) (:tq (...) #<process Racket REPL> . #<buffer  tq-temp-Racket REPL>) (:tq-filter lambda (p s) (geiser-con--tq-filter ... s)) (:eot . "\\(\n\\(mzscheme\\|racket\\)@[^ ]*> \\)") (:prompt . "\\(mzscheme\\|racket\\)@[^ ]*> ") (:debug-prompt) (:is-debugging) (:count . 2) #2)) ...))))) "((result \"((let (\\\"name\\\" . let) (\\\"args\\\" ((\\\"required\\\" ...) (\\\"optional\\\") (\\\"key\\\"))) (\\\"module\\\" . \\\"racket/private/qq-and-or\\\")))\") (output . \"\"))\nracket@> ")
  geiser-con--tq-filter((((nil "\\(\n\\(mzscheme\\|racket\\)@[^ ]*> \\)" ((:id . 2) (:string . ",geiser-eval #f #f ,apply geiser:autodoc ('(let))") (:continuation . geiser-autodoc--show-signatures) (:buffer . #<buffer * Racket REPL *>) (:connection t (:filter . comint-output-filter) (:tq #1 #<process Racket REPL> . #<buffer  tq-temp-Racket REPL>) (:tq-filter lambda (p s) (geiser-con--tq-filter (quote #0) s)) (:eot . "\\(\n\\(mzscheme\\|racket\\)@[^ ]*> \\)") (:prompt . "\\(mzscheme\\|racket\\)@[^ ]*> ") (:debug-prompt) (:is-debugging) (:count . 2) (:completed . #s(hash-table size 65 test eql weakness value rehash-size 1.5 rehash-threshold 0.8 data (1 (... ... ... ... ...) ...))))) . geiser-con--process-completed-request)) #<process Racket REPL> . #<buffer  tq-temp-Racket REPL>) "racket@> ")
  (lambda (p s) (geiser-con--tq-filter (quote (((nil "\\(\n\\(mzscheme\\|racket\\)@[^ ]*> \\)" ((:id . 2) (:string . ",geiser-eval #f #f ,apply geiser:autodoc ('(let))") (:continuation . geiser-autodoc--show-signatures) (:buffer . #<buffer * Racket REPL *>) (:connection t ... ... ... ... ... ... ... ... ...)) . geiser-con--process-completed-request)) #<process Racket REPL> . #<buffer  tq-temp-Racket REPL>)) s))(#<process Racket REPL> "racket@> ")

Looks like geiser-syntax--font-lock-buffer activates Geiser when it shouldn't.

94210cd should fix this one, although there's still an unrelated little
glitch (fontified scheme strings not always use extra font lock keywords).

@jaor It looks like there's a typo in that commit (94210cd), since I get this compile warning:
In geiser-syntax--font-lock-buffer:
geiser-syntax.el:487:12:Warning: reference to free variable `buffer'

Otherwise it seems to be fixed.

yes... one of the commits after that one fixes the typo, i think.

I think that's a different typo. This one involves an extra parenthesis after scheme-mode leaving buffer to be a free variable. It's still present in the last commit.

sorry for being this careless.  should be fixed in a2da78d.  thanks for
your patience.

No worries, I've done the same thing myself.
The issue seems to be good now.

thanks for checking. @Ramapitecus, i'm closing the issue: please re-open it if the fix doesn't work for you, thanks!


How can I determine when all of a Conversation's messages have been fetched?

Yeah, recently fixed this in the WebSDK 2.0 Beta, but the current release does not nicely handle this.
Best bet is to compare how many results you requested and compare it with how many you got back.  If you ever page back and get 0 results, then you've definitely reached the end.  But if you request an increase in paginationWindow of 50 and got back 40, then that also means you've reached the end.
This will be better in 2.0.
Michael

Yep.
By the way, this looks like it would work for an iOS client: https://developer.layer.com/docs/ios/api#lyrconversation.
The use case is paginating:

show loading message when scrolling up and a new page is being fetched
show "this is the start of your conversation" when no more pages exist

We programmatically detect when pages exist by storing the current page and the number of messages received in the Redux store. Then Components use this helper function in lifecycle hooks (parameters would come from props):
import { isEmpty } from 'lodash'
import { MESSAGE_PAGE_LENGTH } from './constants'

export default function didFinishPagingMessages(paginationWindow, messages) {
  return !isEmpty(messages) && paginationWindow > messages.length + MESSAGE_PAGE_LENGTH
}

Note that paginationWindow is a bit of a fluid concept; what you really need is the delta.
If I do query.update({paginationWindow: query.paginationWindow + 50}) repeatedly, I will get a paginationWindow that has no basis on actual message counts.  Think of paginationWindow as a "requested page size" rather than an actual page size.


Add godot linter

Adds the godot linter to make sure all comments are captialized and end in a full stop (period).

Good to know it works 😄
/go/bin/golangci-lint run  ./...
matchers/parse/lexer.go:254:4: Sentence should start with a capital letter (godot)
// it returns nil if the next rune is valid, otherwise an expectedError
   ^
matchers/parse/parse.go:199:44: Comment should end in a period (godot)
			// open brace has a matching close brace
			                                        ^
matchers/parse/parse.go:223:44: Comment should end in a period (godot)
			// open brace has a matching close brace
			                                        ^
nflog/nflogpb/set_test.go:29:27: Sentence should start with a capital letter (godot)
		{newSubset(), true}, // empty subset
		                        ^
nflog/nflogpb/set_test.go:57:27: Sentence should start with a capital letter (godot)
		{newSubset(), true}, // empty subset
		                        ^
pkg/labels/parse.go:140:27: Comment should end in a period (godot)
	// Unescape the rawValue:
	                         ^
make: *** [Makefile.common:173: common-lint] Error 1

@grobinson-grafana ping

@TheMeier I don't have merge permissions so I can't merge this 😞 Needs to be @gotjosh or @simonpasquier


Update README.md

editing in github to fix diff?
Update README.md, changing from Azure/k8s-deploy@v1 to newest version<EMAIL_ADDRESS>Using @v1 I got an error message "Error: TypeError: Cannot read property 'trim' of null". When I finally realized I was on the wrong version it worked smoothly 🥳
Hopefully this will save someone else some troubleshooting?

Hi @ds-ms , I closed this one: https://github.com/Azure/k8s-deploy/pull/79
diff looks better now, a small newline or something on the last line, hope that's ok :)


Voting is sometimes blocked and only available after page refresh

I guess it's possible that the bug have its origin within Parse and the problem could fix itself with the replacement of our Parse backend with the new Go one.


[TKNECO-50] Release Action

Release Workflow to package the project contents, upload the container images and artifacts to the GitHub Release page.
The Workflow only runs when a tag is issued.

@Senjuti256, @anandxkumar please consider.

Everything looks good to me.


Fix retire bug.

Travis tests have failed
Hey @silasary,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.


[hi] Localize Version Control for Hindi

Please describe why this term needs to be added
What this term is about? (briefly)

Source control (or version control) is the practice of tracking and managing changes to a document. It is a system that records changes to a file or set of files over time so that you can recall specific versions later.

Why this term needs to be added? (briefly)

Localizing this term in hindi will help hindi folks to learn about this term in their native language

link here :- https://glossary.cncf.io/version-control/

Hello @bishal7679
I think it would be great if one of Hindi L10n team approvers (@Garima-Negi @sayantani11 @anubha-v-ardhan @jayesh-srivastava) assign you (or someone else) for working on Hindi L10n jobs.

Yes Please Can anyone assign me
@Garima-Negi @anubha-v-ardhan @sayantani11 @jayesh-srivastava

Thankyou @bishal7679 :)

@anubha-v-ardhan @jihoon-seo Can you tell me what is happening here
When I am making a PR from my branch hi-version-control to dev-hi it is taking all the commits of everyone in my PR that made before.
please help me out

@bishal7679 I believe the branch hi-version-control on your fork is branched from main which is causing this issue. Since dev-hi is not on par with main, hi-version-control carries all the changes on main when you make a PR from hi-version-control to main.
The best solution in my opinion is to make the working branch on your fork from dev-hi. As a general rule, always make your working branch from the branch where your PR will merge in future.
If you don't want to start all over again, you can fix this using a rebase too!


Inherit the license from http4s

To keep things coherent, what do you think about inheriting the license (Apache License 2.0) from the core http4s module?
As for the current Copyright 2023 Christopher Davenport license, probably (I'm not a lawyer really), we need public approval from @ChristopherDavenport.
UPD: ah, in the code, we have https://opensource.org/licenses/MIT as the license.

When there is a consensus on the topic, don't forget to return headers check on CI (link to build.sbt).

@http4s/grpc hey folks. I'd like us to publish the initial 0.1.0 release (or maybe 0.1.0-M1). But the thing with the license perhaps should be solved first.

Do we really need to change the license?
The copyright may have to be changed, not sure how that actually works.

Do we really need to change the license?

There is no particular need doubtless. But I like to keep things coherent. Also, we might do that migration from MIT to Apache 2.0 generally. Just we need to get the consent of the original contributors.

@ChristopherDavenport as the original author and copyright holder, do you have any objections of changing the license?


Add Eigen Value and Eigen Vector

This contribution implements an Eigenvalue and Eigenvector Calculator for 2x2 matrices using HTML, CSS, and JavaScript. The calculator allows users to input a matrix, and it computes both the eigenvalues and eigenvectors. The calculation is performed directly in the browser using JavaScript, making it a lightweight and efficient tool for matrix analysis.
Key Features:

Eigenvalue Calculation: The calculator accurately computes the eigenvalues for 2x2 matrices.
Eigenvector Calculation: It calculates the corresponding eigenvectors for each eigenvalue using algebraic methods.
User-Friendly Interface: The input matrix is provided in a simple, text-based format (comma-separated values for rows). The results are displayed in a clean, readable format.
Error Handling: The calculator includes basic error handling to ensure that the matrix is square (NxN) and contains only valid numbers.
Future Support: Currently supports only 2x2 matrices. The 3x3 matrix eigenvalue and eigenvector calculations can be implemented in future iterations.

Input Format:

Users should input the matrix as comma-separated rows. For example:
4,2 1,3

Output:

Eigenvalues: Displayed in a clean format with four decimal precision.
Eigenvectors: Each eigenvector is calculated and displayed corresponding to its eigenvalue.

Technologies Used:

HTML: For structuring the user interface.
CSS: For styling and creating a responsive layout.
JavaScript: For the main logic, including parsing the input matrix, calculating eigenvalues and eigenvectors, and displaying the results dynamically.
Math.js: For handling matrix and eigenvalue operations efficiently.

How to Use:

Enter the matrix in the provided text area (each row as a comma-separated list).
Click the Calculate button to compute the eigenvalues and eigenvectors.
The results will be displayed below the input box.

mention the issue no

#547
On Sun, 6 Oct 2024, 20:56 Rahul Mahato, @.***> wrote:

mention the issue no
—
Reply to this email directly, view it on GitHub
https://github.com/iamrahulmahato/master-web-development/pull/561#issuecomment-2395478581,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5XQPHX4MMEPEMDIJSCYNALZ2FJDVAVCNFSM6AAAAABPOIQGNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGQ3TQNJYGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

this issue is assigned to someone else you can't work on it,i am closing it


refactor: introduce Ideal.IsTwoSided class for quotients of noncommutative rings

[x] depends on: #17708

!bench

!bench

!bench

!bench

!bench

!bench

!bench

!bench

!bench

!bench

!bench

!bench

bench!

!bench

!bench

!bench

!bench

!bench

!bench

@alreadydone are you looking for reviews? Or do you still want to work on improving the performance?

!bench

@jcommelin Yeah I'd appreciate review(s). I found that setting priority := low for all but one IsTwoSided instance has a small speedup effect, and restoring the shortcut instance Ideal.instHasQuotient has a large speedup effect (from 0.44/0.55% to 0.28/0.34%). Adding another shortcut instance in the commutative case further reduced the numbers to 0.24/0.24%. Then I ran out of ideas to improve performance further.
I've investigated why AdjoinRoot got slower, and I've found e.g. AdjoinRoot.quotMapOfEquivQuotMapCMapSpanMk_symm_mk now requires 7585 heartbeats (compared to 3512 originally) and PowerBasis.quotientEquivQuotientMinpolyMap_apply_mk now requires 19028 (compared to 6146 originally). I found that replacing some occurrences of  Ideal.Quotient.mk by a CommRing-specific version mk' that doesn't take [IsTwoSided] as an argument could reduce the heartbeats a lot but could sometimes also increase the heartbeats (see table below), and for the slowest decls it's not very effective (e.g. reduces 19028 to 15297), so I doubt that's the way to go.
AdjoinRoot.quotMapOfEquivQuotMapCMapSpanMk_mk: 1165 heartbeats on master

1st
2nd
3rd
hearbeats

mk
mk
mk
3240

mk
mk
mk'
3507

mk
mk'
mk
1904

mk
mk'
mk'
2339

mk'
mk
mk
3061

mk'
mk
mk'
3328

mk'
mk'
mk
1724

mk'
mk'
mk'
2159

!bench

!bench

!bench

!bench

!bench

!bench

!bench

!bench

!bench

!bench

!bench

!bench


Fixes a x.509 parsing error

This catches and handles a non-graceful error that sslyze throws when it finds a certificate with no valid SAN or common name field.
I'd rather not catch these one by one, but there is no overarching parent class, so not much of a choice.
This seems to affect only state/local .gov domains in the northeastern USA, suggesting that maybe there's a regional vendor with a malformed certificate problem that serves a large part of that market.

I've confirmed that this fixed all crashes observed when expanding the scanned dataset from federal domains to state/local/tribal domains.


[Perf Tests] Use meaningful app names for performance tests for better log separation

In what area(s)?

/area runtime

/area operator

/area placement

/area docs

/area test-and-release
What version of Dapr?

1.1.x
1.0.x
edge: output of git describe --dirty

Expected Behavior
When a performance test has finished the container logs are bumped into a file and shared as a github artifacts. These logs are used to identify and to deep dive any error that could happen on the used test containers. The logs of a given container is identified by its name provided by the test suite.
testApps := []kube.AppDescription{
		{
			AppName:           "my-app-name",
...

Actual Behavior
Multiple apps are using the same appName making difficult to get a clear separation between the respective logs for a given test.

The suggested fix is to use the test name as a prefix for the logs.
Steps to Reproduce the Problem
Download any perf container logs and extract it
Release Note

RELEASE NOTE:

/assign


feat: can you add support for DNS over HTTPS (DoH)?

See https://github.com/song940/node-dns/blob/master/client/doh.js for inspiration perhaps?

Ok, thanks.

Congrats! for your project, but the problem was to add native DNSSEC support.
DoT is not used in practice and cannot become a standard protocol for DNS due to the worldwide big implementation of UDP since the beginning, and is other IETF afterthought.
The problem with DNSSEC (which is also not used at worldwide) is the DNS header and Signature field, which was to be done at a low level using crypto. The idea was to figure out how to do all this without using third-party modules

Congrats for your project, but the problem was to add native DNSSEC support.
DoT is not used in practice and cannot become a standard protocol for DNS due to the worldwide big implementation of UDP since the beginning, and is other IETF afterthought.
The problem with DNSSEC (which is also not used at worldwide) is the DNS header and Signature field, which was to be done at a low level using crypto. The idea was to figure out how to do all this without using third-party modules

Congrats for your project, but the issue was to add native DNSSEC support.
DoT is not used in practice and cannot become a standard protocol for DNS due to the worldwide big implementation of UDP since the beginning, and is other IETF afterthought.
The problem with DNSSEC (which is also not used at worldwide) is the DNS header and Signature field, which was to be done at a low level using crypto. The idea was to figure out how to do all this without using third-party modules

Congrats for your project, but the issue was to add native DNSSEC support.
DoH is not used in practice and cannot become a standard protocol for DNS due to the worldwide big implementation of UDP since the beginning, and is other IETF afterthought.
The problem with DNSSEC (which is also not used at worldwide) is the DNS header and Signature field, which was to be done at a low level using crypto. The idea was to figure out how to do all this without using third-party modules


[sk] Added multithreaded column type inference

Summary
Added support for column type inference to use multiple threads. When there are above a certain number of entries, the column type detection strategy is made concurrent by spawning multiple threads to perform calculation. This is done because if there are fewer entries, the overhead of multithreading outweighs the speed of the column type inference.
In additional, multicurrency support was added to column type inference, along with related bug fixes.
Performance Metrics
Profiled on “6322377a-947a-4ac8-ad30-1f4af31cd089.8fce2076-de93-46f0-9161-85f9952e2123.csv”, a dataset with:

100,000 rows
28 columns

Timing results were profiled using timeit, averaged over 100 trials.
Baseline (No Code Edits): 3.9 seconds
Main change - threaded the code over multiple threads to speed up processing
Multithreaded - No Optimization: 4.308 seconds
Multithreaded - After Optimization: 3.613 seconds

Merged nonnumerical type handling into sequential process since checking for binary types is now easier
Reduced duplicated instances of work (calculating unique values, getting number of True values in match)

In order to multithread code, the logic for infer column type was refactored to be on a per series basis. Running this refactored version alone with no multithreading gives results of:
Single Threaded w/ Refactor: 3.674 seconds
Tests
Unit tests were ran and testing was also performed on testing datasets.
cc:
@wangxiaoyou1993

Could you add performance improvement metrics to the PR description?

Added Performance Metrics


Support different image sizes in prefill in VLMs

What does this PR do?

When a batch contained images if different sizes during prefill, the server would fail (fixes #2056). Images were processed separately and then concatenated. However, this can fail for images with different sizes.
Fix this by preprocessing all images in the batch together, so that the image processor can ensure that all image tensors have compatible sizes.

Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Thank you for this, @danieldk!  Do you have a sense of when this should get published to the ghcr.io/huggingface/text-generation-inference:latest docker image?


[NNVM][CONVOLUTION] Generic index for group multiply - bug fix

@Huyuwei
Pls  review.
This change due to different way of expecting the weights shape for NHWC and NCHW.
I have checked the compute definition of both depthwise and arrived at this.

If we are good with this, I will add a test case for NHWC-depthwise.

@srkreddy1238 Could you first add a test case that drives this change? It will help me better follow what's going on. You may need to modify these two files to test NHWC layout:
https://github.com/dmlc/tvm/blob/master/nnvm/python/nnvm/top/nn.py#L78
https://github.com/dmlc/tvm/blob/master/nnvm/tests/python/compiler/test_top_level2.py#L61

@Huyuwei
I don't have a frontend with NHWC and depthwise now to give a clear test case. I could do this once we have tensorflow frontend.
Ref: https://github.com/srkreddy1238/tvm/tree/mobilenet
Head of this branch has the changes with tensorflow and mobilenet to demonstrate this change.

@Huyuwei
Test case added for NHWC, pls check.

My suggestion is we use wshape[kernel_layout.indexof('O')] *= param.groups to handle all layouts.
NHWC depthwise convolution can be expressed as
depthconv_nhwc = sym.conv2d(data, layout="NHWC", kernel_layout="HWOI")

while a normal grouped NHWC convolution can be expressed as
groupconv_nhwc = sym.conv2d(data, layout="NHWC", kernel_layout="HWIO")

The order of in_channel and out_channel in the kernel layout of topi.conv2d_nchw and topi.conv2d_nhwc is different, but the order of in_channel and  multiplier in the kernel layout of topi.depthwise_conv2d_nchw and topi.depthwise_conv2d_nhwc is the same. It's better to deal with this asymmetry in frontend part, not c++ code.
@srkreddy1238 what do you think?

@srkreddy1238 May I ask one question? just for curiosity
Since convolution.cc is basically copied from mxnet source code, is there also a bug in grouped NHWC convolution is mxnet?
https://github.com/apache/incubator-mxnet/blob/master/src/operator/nn/convolution.cc#L152

", but the order of in_channel and multiplier in the kernel layout of topi.depthwise_conv2d_nchw and topi.depthwise_conv2d_nhwc is the same"
No, they are not same.
Let me check mxnet compute implementation..

@Huyuwei
Ref. https://github.com/apache/incubator-mxnet/blob/9b8eb567273d9521c639ea783e1117fe09cb3d64/src/operator/nn/convolution-inl.h#L169
mxnet doesn't implement NHWC but we do.

@srkreddy1238 aha, thanks for the pointer.
In the kernel layout of both topi.depthwise_conv2d_nchw and topi.depthwise_conv2d_nhwc is, in_channel is before multiplier, is this right?
https://github.com/dmlc/tvm/blob/master/topi/python/topi/nn/depthwise_conv2d.py#L21-L22
https://github.com/dmlc/tvm/blob/master/topi/python/topi/nn/depthwise_conv2d.py#L76-L77

Yes, channel is before multiplier.

@srkreddy1238 For topi.conv2d_nchw, out_channel is before in_channel in kernel layout, while for topi.conv2d_nhwc, out_channel is after in_channel. And there is a mismatch between conv2d_nhwc and depthwise_conv2d_nhwc.
wshape[kernel_layout.indexof('O')] *= param.groups works for general group convolutions. Since group conv is not yet implemented in topi, now we dispatch depthwise conv to support a special case of group conv. To solve the kernel layout mismatch between conv2d_nhwc and depthwise_conv2d_nhwc, we need to specify kernel_layout="HWOI" for depthwise conv, which for general group conv is kernel_layout="HWIO" , as previously commented.

@Huyuwei
Thanks for the info. This makes clear to me.
I will work on modifications based on this.

@Huyuwei
Now works for both NCHW & NHWC. Pls review.

@srkreddy1238 Can mobilenet be converted now? If so, add it to frontend tests.

Ok. I will update frontend testcases with mobilenet this weekend.

This is merged as @Huyuwei approved the change. Please add mobilnet test in a separate PR


Add workaround for a crash on getting range from unbridged string

Codecov Report

Merging #603 into master will decrease coverage by 0.16%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #603      +/-   ##
==========================================
- Coverage   58.95%   58.79%   -0.17%
==========================================
  Files          91       91
  Lines        3949     3953       +4
==========================================
- Hits         2328     2324       -4
- Misses       1621     1629       +8

Impacted Files
Coverage Δ

ChattoAdditions/Source/Input/ChatInputBar.swift
73.57% <0%> (-2.17%)
:arrow_down:

...Chat Items/TextMessages/Views/TextBubbleView.swift
76.34% <0%> (-4.31%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfbb01d...d2625d5. Read the comment docs.


feat(joy_controller): adding genesis joystick to joy controller

Description

Closes [#682]
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[x] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xmfcx cc @mitsudome-r @yukkysaito Should I give write access of autoware.universe to the autoware-developers-leodrive team and let them merge PRs? Or will we add some Leo Drive members to the autoware-maintainers team? Or should TIER IV members and maintainers merge PRs?

@kenji-miyake In Autoware.Auto, as long as an MR had an approval, anyone could merge it from the members. With the help of merge-bot.

@xmfcx Thank you, I understand.
Hmm, then I think I can add a CI workflow that can do the same thing as merge-bot, but I'll merge this by myself for now.
I'll consider other ways in the future.


Redis cache tags flush memory leak

Laravel Version: 5.6.*
PHP Version: 7.2.*
Database Driver & Version: MYSQL 5.7.*
Cache Driver: Redis
we using provided Redis tagged cache to cache query results for models in this way:
cache()->tags([model1, model2...])->remember(sql_query_hash, result_callback)
and if in example after some time and a users peak one of tags in example model1 have 500k of unique cached queries, and there comes update and need to do :
cache()>tags([model1])->flush();
my job gets allowed memory exhausted, for workers we have 128MB of memory. Yes I know if I would increase memory of workers I could flush then 1kk of keys etc. but its not a right way because we have exponential users increase and our project will grow, so maybe some of tags will have 10kk of keys on users peak, and how then I have to flush a cache for tag?
https://github.com/laravel/framework/blob/5.6/src/Illuminate/Cache/RedisTaggedCache.php#L174
this is how laravel flush tags keys, by retrieving all in memory then chunks it in memory again so this array_chunk double the memory usage after getting all keys, and then doing Redis::del operation to remove cached keys for this tag.
I don`t know how it call its a bug o not, but for me need some options does anyone dealing with that problem too, and maybe have some solutions?

Not sure if you noticed but you are linking to the 5.7 but you claim to work with 5.6.*

Nothing changed in 5.6 or 5.7

Hi there,
Welcome to Laravel and we are glad to have you as part of the community.
Unfortunately this GitHub area is not a support area for general application issues. This is only for issues/bugs with the framework code itself.
I will be closing your ticket here. Instead please try asking your question on one of the many great community support areas that will likely give you a better answer more quickly:

Laravel Slack (https://larachat.co/)
Laravel.io Forum (https://laravel.io/forum)
Laracasts Forum (https://laracasts.com/discuss)
StackOverflow (http://stackoverflow.com/questions/tagged/laravel)

If you feel I've closed this issue in error, please provide more information about how this is a framework issue, and I'll reopen the ticket.
Thanks in advance.


Schedule Heroku Backups and Capture backup of existing staging database for Review Apps

When a PR Review environment is created, the latest backup is currently used. If no backups exist, or if the backup is old and outdated, recent data used for testing may not exist.
This forcibly creates a backup right before migration -- leading to the most recent data.
Another way to solve this would be to automatically add pg:backups:schedule on all staging environments on original app scaffolding, but that would be up to 24 hours difference.

Another way to solve this would be to automatically add pg:backups:schedule on all staging environments on original app scaffolding, but that would be up to 24 hours difference.

This is what I normally do on my Rails projects. Regardless of how we merge this PR, I'd like production and staging to have daily backups by default (I thought this was already the case).
I don't feel strongly either way, and we can merge as is or instead turn this PR into adding the daily backup instruction on app creation, and then keeping this script as is. What do you prefer?
Thanks for sharing your work!

This LGTM. Calling in @iwz for another review before I merge. Thank you! :)

LGTM. I'm not sure what others think about the hound line wrapping, though...
@tute @croaky @jferris

@toobulkeh this looks good to go. Do you want to clean up any commits before we merge? Also, do you think the README should mention anything about the scheduled backups?

Added to the README @iwz. I'd appreciate a Squash and Merge. Is that something I can do?

@toobulkeh done. thanks for implementing this!

Ooh ooh ooh, good one.

Shall we bump the gem version?

@croaky good idea. i'm not set up for that atm, are you?


Korean translate

Hello Mr.Bohdan Liashenko. I'm a studying React these days. :)
I'm going to korean translate your 'Under-the-hood-ReactJS' for the purpose of studying and sharing. Can I send Pull requests after I complete it?

@Jae-kwang thanks, sure thing, that would be awesome!
Let's decide what is the best format. I don't want to move existing EN version pages, to not break existing links for people who already use it.
There is the next structure of directories:
/master/stack/
/-/-/book
/-/-/images
I think you can add it on the same level like
/-/-/languages/korean/
So, after that, your directory will be like
/master/stack/languages/korean/
What do you think? Thanks.

@Bogdan-Lyashenko I'm good! If so, should I translate them to "master/stack/languages/korean/book/Part-0.md" and send Pull request?

@Jae-kwang , yes, go ahead. Thx.
Btw, you also can add 'Languages' paragraph in README.md
like
Languages
Korean

@Bogdan-Lyashenko Okay. I will do that. :)

Nice, closing the issue then)


cargo-release: 0.17.0 -> 0.17.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/crate-ci/cargo-release/releases.
meta.description for cargo-release is: "Cargo subcommand "release": everything about releasing a rust crate"
meta.homepage for cargo-release is: "https://github.com/sunng87/cargo-release"
meta.changelog for cargo-release is: ""
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/lc237ibzpkx0p10cc87lxvwrmsqb9y49-cargo-release-0.17.1/bin/cargo-release passed the binary check.

1 of 1 passed binary check by having a zero exit code.

1 of 1 passed binary check by having the new version present in output.

found 0.17.1 with grep in /nix/store/lc237ibzpkx0p10cc87lxvwrmsqb9y49-cargo-release-0.17.1

found 0.17.1 in filename of file in /nix/store/lc237ibzpkx0p10cc87lxvwrmsqb9y49-cargo-release-0.17.1

directory tree listing: https://gist.github.com/2f68fb2924f372bf572d9c6b2ba92c4d

du listing: https://gist.github.com/d7b7539b091a1633faf627b90284aec7

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
cargo-release

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/lc237ibzpkx0p10cc87lxvwrmsqb9y49-cargo-release-0.17.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cargo-release https://github.com/r-ryantm/nixpkgs/archive/2e04dddd68d4b56c976dd44dae1b6278cd54a9a6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/lc237ibzpkx0p10cc87lxvwrmsqb9y49-cargo-release-0.17.1
ls -la /nix/store/lc237ibzpkx0p10cc87lxvwrmsqb9y49-cargo-release-0.17.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

cargo-release

Maintainer pings
cc @Gerschtli for testing.

Result of nixpkgs-review pr 135733 run on x86_64-darwin 1

1 package built:

cargo-release

This builds fine and is a patch release, i don't see any obstacle to merging.


Getting two fields or more as "attribute" in relations

Is it possible to concat two fields for the attribute (foreign key attribute that is shown to user) ?
For example i can display the name of the user with the relation below but i would like to display first + name.
$this->crud->addField([
            'label' => "User",
            'type' => 'select2_multiple',
            'name' => 'users',
            'entity' => 'users',
            'attribute' => 'name',
            'model' => "App\Models\User",
            'pivot' => true
]);

Something like :
'attribute' => 'firstname' . 'name',
Thanks.

Sure, just create an accesor on your User model, something like:
public function getFullNameAttribute($value) {
   return $this->firstname.' '.$this->name;
}

You'll then be able to use full_name for the attribute, both in CRUD and anywhere else in your app ($user->full_name).
Hope it helps.
Cheers!

Awesome. Thank you!

Thanks @singeryo it's definitely helpful. And not only for ajax queries, for any scenario where you want to add something else to the model you should use Laravel model $appends .
Cheers

#define into user model
public function getFullNameAttribute($value) {
return $this->first_name.' '.$this->last_name;
}
#use in controller
$this->crud->addcolumn([
// role list
'label' => 'Primary program manager',
'name' => 'priorityProgramManger.full_name', // the method that defines the relationship in your Model
]);

This is also helpful when you want to use relations with Ajax.
# on Model
protected $appends = [
    'full_title'
];

public function getFullTitleAttribute():string
{
    return $this->company_number . ' - ' . $this->title;
}

# on CrudController
CRUD::field('company')->type('relationship')->label('Şirket')->attribute('full_title')->ajax(true);

In case someone (or me) needs it for later.


Potential memory leak over time

Stratux version: v0.6r1.
Stratux config: dual SDR, GPS unknown, AHRS no, battery unknown, battery cable unknown.
EFB app and version NA. EFB platform NA. EFB hardware NA.
Description of your issue. "noticed the memory usage went from 43mb initially to over 73mb currently, in 2 days 1:37 minutes of uptime."

May just be the ever-growing traffic target list, but a 2+ day memprof should solve it.

Here is some data from htop, from two days of testing for memory leaks.  Mostly vanilla Stratux v0.6r1 with iposva's GlobalSat update and powersave governor. Two SDRs, listening inside the house. No towers. Peak 1090 = 2680, peak UAT = 108. (It's higher when the unit is outside.) GPS mostly WAAS.
(Power from a 2A wall wart. Pi red LED on solid. Never lost Wi-Fi.)
Here's the start of the test.
Mem showing 42/925.
At 4 hours.
46/925
At 17 hours.
50/925.
The memory stayed there for the rest of the test. It would toggle between 50 and 51.
48 hours.
Having said that the memory topped out at 50/51, I saw 60 MB after only two hours of flying with the same hardware but towers and a lot more UAT messages. I forgot to take a screenshot of the Stratux status page at the end of the flight, but here's a screen shot from about 1 hour into a 2.3 hour flight. We're near the Hector VOR about this time, where there wasn't much traffic. And then we flew thru R-2515 and then down low into the Southern Sierras. So the peaks you're seeing here were probably the peaks for the flight.
If memprof is an easy apt-get thing, I'm willing to do the test again with that. (Outside the house this time.) Please let me know.

I tried installing memprof. In addition to apt-get, I tried pip install and easy_install. No joy.

I forgot to post a screen shot of htop from near the end of the flight. Here it is.

@cyoung -- While testing #249, I noticed that I have several DHCP leases that never expire, and that FIS-B data will be queued for port 4000 on those addresses:
2016/02/15 05:01:32 On  <IP_ADDRESS>:49002,  Queue length = 0 messages / 0 bytes
2016/02/15 05:01:32 On  <IP_ADDRESS>:4000,  Queue length = 20005 messages / 8806305 bytes
2016/02/15 05:01:32 On  <IP_ADDRESS>:49002,  Queue length = 0 messages / 0 bytes
2016/02/15 05:01:32 On  <IP_ADDRESS>:4000,  Queue length = 20005 messages / 8806305 bytes
2016/02/15 05:01:32 On  <IP_ADDRESS>:49002,  Queue length = 0 messages / 0 bytes
2016/02/15 05:01:32 On  <IP_ADDRESS>:4000,  Queue length = 0 messages / 0 bytes
2016/02/15 05:01:32 On  <IP_ADDRESS>:4000,  Queue length = 0 messages / 0 bytes
2016/02/15 05:01:32 On  <IP_ADDRESS>:49002,  Queue length = 0 messages / 0 bytes
2016/02/15 05:01:32 On  <IP_ADDRESS>:4000,  Queue length = 20005 messages / 8806305 bytes
2016/02/15 05:01:32 On  <IP_ADDRESS>:49002,  Queue length = 0 messages / 0 bytes
2016/02/15 05:01:32 On  <IP_ADDRESS>:4000,  Queue length = 20005 messages / 8806305 bytes
2016/02/15 05:01:32 On  <IP_ADDRESS>:49002,  Queue length = 0 messages / 0 bytes

Since the message queues autotrim to a length of 25000 messages (~10.3 MiB per port), that may explain why memory usage eventually tops out... at least until a new device connects.

@AvSquirrel - /var/lib/dhcp/dhcpd.leases should have expired leases. Added code now that reads and parses the lease expire time. The max lease time is set to just over 3 hrs (and has been set there for a while).


Flaky tests in CI

https://github.com/benchmark-action/github-action-benchmark/pull/196
The "flaky" tests are nearly consistent now. Still failing after several retries. Need to fix them

Relevant issue for Julia failure. https://discourse.julialang.org/t/strange-bug-in-compiled-binaries-about-suitesparse/108027

Julia 1.10 removed SuiteSpare and SparseArrays from default. https://github.com/JuliaLang/julia/blob/v1.10.0/NEWS.md#build-system-changes

this is a duplicate of #168. I'll add more details to the previous issue


Memory leak in iquic_esf_decrypt_packet？

hello
I start my program with 100 connections, with self-buffer of each connection, the memoy usage is about 1.9GB at the begining.

after running about 1 hour, the memory usage is up to about 3.9GB

after close the all 100 connections, the memory is still 3.9GB.

when recvmsg from socket, and call lsquic_engine_packet_in，sometimes alloc memoy in heap。
after using gdb break in mmap, i found that, after malloc by new_heap in iquic_esf_decrypt_packet，the memory increase about 64MB(64MB may be releated to my testing data?), and didn't decrease any more

Please check https://github.com/litespeedtech/lsquic/issues/409


ENH: Rework OverviewBar

Description
Following discussions in #20, the current OverviewBar-modes should be reworked.
Ideas

[ ] Move "channels"-mode into a thin line next to the vertical scrollbar
[ ] Add mode with no background
[ ] Add time underneath

Regarding the Minimap (which would just zscore now if we moved channels-mode away) it might be hard to identify the markers for events, annotations and bad channels with the fidgety background.
"channels"-mode

"zscore"-mode

To see those markers, channels-mode or no background at all are probably better. Maybe instead of removing "channels"-mode completely, we add a third option for no background. And the thin line next to the vertical scrollbar will be implemented additionally.

Further ideas?
Do you have further ideas on how to use the background of the OverviewBar/Minimap? (e.g. additional statistical metrics?)

Ohhhh so there is information in the "channels" mode, namely the event markers (and maybe annotations?). In that case maybe we should hide it when there are no annotations or event markers only... not sure.

Ohhhh so there is information in the "channels" mode, namely the event markers (and maybe annotations?). In that case maybe we should hide it when there are no annotations or event markers only... not sure.

No, the markers are independently drawn from the "channels" or "zscore" background.
I was just thinking when "zscore" will be the only background available without "channels", that would make the markers hard to read.

No, the markers are independently drawn from the "channels" or "zscore" background.

My point is more that I was wrong above when I said that there wouldn't be any horizontal information in channels mode. There is -- namely the markers (if present). So maybe instead of deciding if we should show the bottom bar based on whether in channels or zscore mode (as I suggested before), we should only hide the bottom bar if in channels mode and there are no markers to show

I understand. The users can toggle the OverviewBar with pressing "o" if it takes too much space for them.

I think it's worth saying that for all-EEG data it's a bit weird to have a big black box down there. Even if there are some annotations showing, it seems a bit odd to put them on a black background.

So in this case you could just as well have no background, right?

Which I think is another vote for having color-that-indicates-channel-type being a thin rectangle along the vertical scrollbar, and not having it in that overview box.

I am also +1 on that, this thin vertical indicator would also still enable a bit of overview when the OverviewBar is toggled off.

So in this case you could just as well have no background, right?

yes, and further I think that even in cases with multiple channel types, there should be no background (because that info will be available in the new thin rectangle)

I like the idea of displaying channel type information in the vertical scrollbar
I would like having a "no background" (white/transparent) overview-mode which just shows the annotations ... so pretty much like the "channels" overview mode for all-EEG channels now, but only that it's not black but white for better visibility
I remember using the FieldTrip ft_rejectvisual function some years ago and liked it ... perhaps studying that will also show a few nice options for the overview mode statistics: https://www.fieldtriptoolbox.org/tutorial/visual_artifact_rejection/

I try to implement some of this before 0.2-release, probably won't manage everything

Hey, I want to work on this issue for GSOC'22.


Add Table of content Section in the readme file

hey! please assign me this issue

Sure, Go ahead!