Piping to git add -WhatIf is successful then git add throws "file.ps1 is outside the repository "

Cause of the error:
I was piping paths to git add, the third command threw errors. Some of the files were added. others were not. -WhatIf returned no errors.
# earlier: Update-Module ugit # got 0.3.1
Pwsh> Pushd 'C:\Users\cppmo_000\SkyDrive\Documents\2022\My_Github\notebooks'
Pwsh> fd -t f --changed-within 4hours --search-path (gi ../..) | git add -WhatIf
Pwsh> fd -t f --changed-within 4hours --search-path (gi ../..) | git add

(git status).unstaged  is missing the File property
Pwsh> (git status).unstaged  | fl *

ChangeType : modified
Path       : Pwsh/Powershell_101/sketch.Using Strongly Typed Arrays in Modern Powershell-pwsh.dib
File       : C:\Users\cppmo_000\SkyDrive\Documents\2022\My_Github\notebooks\Pwsh\Powershell_101\sketch.Using Strongly Typed Arrays in
             Modern Powershell-pwsh.dib

ChangeType : modified
Path       : "sketches/Alternate Parameters \342\201\236 Compare outputs \342\201\236 Pwsh 101 - argument passing.2022-10 -iter3.ps1"
File       :

ChangeType : modified
Path       : sketches/inspecting-end-of-line-paste-vscode-etc.ps1
File       : C:\Users\cppmo_000\SkyDrive\Documents\2022\My_Github\notebooks\sketches\inspecting-end-of-line-paste-vscode-etc.ps1

note: No File property for the 2nd file.
$null -eq  (git status).unstaged[1].File it evaluates to true null
But the path exists, and is almost a file /w get-item.

Pwsh> (git status).unstaged[1].path | gi
Get-Item: Cannot find path 'C:\Users\cppmo_000\SkyDrive\Documents\2022\My_Github\notebooks\"sketches\Alternate Parameters \342\201\236 Compare outputs \342\201\236 Pwsh 101 - argument passing.2022-10 -iter3.ps1"' because it does not exist.

# It needs cleanup  ``\342\201\236', '⁞'` -replace, '"', ''`

Maybe this is not an encoding issue, but path related
This originally started looking like it was an issue with encoding text (non-ascii filenames), but now I'm thinking that's a red herring.
Why? Because as as experiment I tried an old commit, that hadn't used ugit.
Pwsh> git diff-tree --name-only -r HEAD~15..HEAD~13
"sketches/Alternate Parameters \342\201\236 Compare outputs \342\201\236 Pwsh 101 - argument passing.2022-10 -iter2.ps1"
"sketches/Alternate Parameters \342\201\236 Compare outputs \342\201\236 Pwsh 101 - argument passing.2022-10.ps1"
sketches/inspecting-end-of-line-paste-vscode-etc.ps1

Does -WhatIf test paths differently
Even if that's true, the filepaths are valid, commits work with github dekstop.
I tried a reflog, which shows ⁞ in the history

The native app fd is piping to git add
$data as json
$data =  fd -t f --changed-within 4hours --search-path (gi ../..) | git add -WhatIf

[{"InputObject":["C:\\Users\\cppmo_000\\SkyDrive\\Documents\\2022\\My_Github\\notebooks\\Pwsh\\utils\\Test-IsBlankable.ps1"],"GitArgument":["add"],"WhatIf":{"IsPresent":true}}
{"InputObject":["C:\\Users\\cppmo_000\\SkyDrive\\Documents\\2022\\My_Github\\notebooks\\sketches\\crazy inspect.ps1"],"GitArgument":["add"],"WhatIf":{"IsPresent":true}}
{"InputObject":["C:\\Users\\cppmo_000\\SkyDrive\\Documents\\2022\\My_Github\\notebooks\\Pwsh\\Types\\Using Generics ⁞ Replacing ArrayList.ipynb"],"GitArgument":["add"],"WhatIf":{"IsPresent":true}}
{"InputObject":["C:\\Users\\cppmo_000\\SkyDrive\\Documents\\2022\\My_Github\\notebooks\\Pwsh\\Types\\Changing Types using Add-Member ⁞ adding scriptblocks.ipynb"],"GitArgument":["add"],"WhatIf":{"IsPresent":true}}
{"InputObject":["C:\\Users\\cppmo_000\\SkyDrive\\Documents\\2022\\My_Github\\notebooks\\Pwsh\\Powershell_101\\Attributes And types in Modern Powershell.ipynb"],"GitArgument":["add"],"WhatIf":{"IsPresent":true}}
{"InputObject":["C:\\Users\\cppmo_000\\SkyDrive\\Documents\\2022\\My_Github\\notebooks\\Pwsh\\Objects\\using the new Null-coalescing operators ⁞ Cheat Sheet.ipynb"],"GitArgument":["add"],"WhatIf":{"IsPresent":true}}
{"InputObject":["C:\\Users\\cppmo_000\\SkyDrive\\Documents\\2022\\My_Github\\notebooks\\Pwsh\\Powershell_101\\Using Strongly Typed Arrays in Modern Powershell-pwsh.ipynb"],"GitArgument":["add"],"WhatIf":{"IsPresent":true}}
{"InputObject":["C:\\Users\\cppmo_000\\SkyDrive\\Documents\\2022\\My_Github\\notebooks\\Pwsh\\Powershell_101\\Using Strongly Typed Arrays in Modern Powershell-pwsh - Copy.ipynb"],"GitArgument":["add"],"WhatIf":{"IsPresent":true}}
{"InputObject":["C:\\Users\\cppmo_000\\SkyDrive\\Documents\\2022\\My_Github\\notebooks\\Pwsh\\Powershell_101\\sketch.Using Strongly Typed Arrays in Modern Powershell-pwsh.ipynb"],"GitArgument":["add"],"WhatIf":{"IsPresent":true}}
{"InputObject":["C:\\Users\\cppmo_000\\SkyDrive\\Documents\\2022\\My_Github\\notebooks\\Pwsh\\Powershell_101\\sketch.Using Strongly Typed Arrays in Modern Powershell-pwsh.dib"],"GitArgument":["add"],"WhatIf":{"IsPresent":true}}
{"InputObject":["C:\\Users\\cppmo_000\\SkyDrive\\Documents\\2022\\client_BDG\\self\\tests-invoke\\always-mini.ps1"],"GitArgument":["add"],"WhatIf":{"IsPresent":true}}]

stack_trace_export.log

@ninmonkey coming back to this for a bit.
I think the core issue here is that -WhatIf doesn't quite work as you'd like.
Specifically, -WhatIf just returns arguments, it doesn't run them.  Since git won't always offer me a clean route to roll back something, -WhatIf just returns the set of context it has about what would run.
The "gotcha" can come in because that set is somewhat different, it's a splat of arguments, not the exact like you'd be copying/pasting into git.
While I'm sure I could not give you a way to see if the file is actually valid for git in -WhatIf (at least with any sort of ease), I am sure I could make -WhatIf return strings, not splats.
Would this be something you'd prefer?

Looping back around once more.
I'm changing -WhatIf to return a [ScriptBlock] of what would execute, with the GitRoot attached.
I think this will lead to a more obvious output.


[RaisedButton] whitespace around while using flexbox for parent div and child height is bigger than btn

Problem description
I had this issue many times while using buttons:

solution is dead simple, just wrap button with extra div and it's solved. I think it would be nice if that extra div would be just inside component and there would be no need to wrap.
Steps to reproduce

  <RaisedButton primary={true} label={'hi'}/>

SOLUTION - add extra div around RaisedButton:

    <RaisedButton primary={true} label={'hi'}/>

Versions

Material-UI: 0.15.0
React: 15.1.0
Browser: Chrome: Version 51.0.2704.84 (64-bit)

Also experiencing this bug (with 0.15.2). Thanks for the workaround.

@liesislukas That's how components have been written. However, now an error is showed if a RaisedButton is used outside of a div


Change the documentation for TensorArray

56390

 Quality gate: Failed
93 Issues

 1 Vulnerabilities
 68 Code issues
 24 Anti-patterns

Details

 Quality gate: Failed
93 Issues

 1 Vulnerabilities
 68 Code issues
 24 Anti-patterns

Details


Text changes

unit of mu: kg m$^{-2}$ °C$^{-1}$ mth$^{-1}$ (I know its weird, let's discuss this on monday)
what is the unit of the x axis in the plots? It should also be kg m^{-2}, or maybe m w.e.

added unit for mu and changed unit of Mass-Balance to kg m^{-2}


Make EasyMDE has the same heading(1-6) font-size as the markdown

Fix #23816
According to my personal experience, the EasyMDE is still useful when writing a lot of contents, eg: the wiki page.
It's not difficult to improve its heading styles, so let's make it.
Before:

After:

Codecov Report

Merging #24151 (028bf9c) into main (f521e88) will decrease coverage by 0.05%.
The diff coverage is 41.40%.

@@            Coverage Diff             @@
##             main   #24151      +/-   ##
==========================================
- Coverage   47.14%   47.10%   -0.05%
==========================================
  Files        1149     1161      +12
  Lines      151446   153792    +2346
==========================================
+ Hits        71397    72437    +1040
- Misses      71611    72830    +1219
- Partials     8438     8525      +87

Impacted Files
Coverage Δ

cmd/dump.go
0.64% <0.00%> (-0.03%)
:arrow_down:

cmd/embedded.go
0.00% <0.00%> (ø)

cmd/mailer.go
0.00% <0.00%> (ø)

cmd/manager.go
0.00% <0.00%> (ø)

cmd/manager_logging.go
0.00% <0.00%> (ø)

cmd/migrate_storage.go
5.76% <0.00%> (-0.12%)
:arrow_down:

cmd/restore_repo.go
0.00% <0.00%> (ø)

cmd/web.go
0.00% <0.00%> (ø)

models/actions/run.go
1.63% <0.00%> (-0.10%)
:arrow_down:

models/actions/runner.go
1.44% <ø> (ø)

... and 58 more

... and 158 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


conditional footer is not working anymore

I'm submitting a ...
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior
When i add a ngx-datatable-footer in my ngx-datatable, i can see the footer properly displayed. When i make the ngx-datatable-footer conditional with *ngIf, the footer never get displayed even when condition is true.
This problem seems related to Angular 8 with the static ViewChild/ContentChild update.
Expected behavior
The footer should display.
Reproduction of the problem
See stackblitz example
With *ngIf="true" it does not display the custom footer. Remove *ngIf="true" to make the custom footer appear.
What is the motivation / use case for changing the behavior?
I want to display the footer when a condition is matched
Please tell us about your environment:
Win10, Angular8

Table version:
15.0.0

Angular version:
8.0.0

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
all

Language: [all | TypeScript X.X | ES6/7 | ES5]
all

Hello.
With this new version, this.table.headerComponent is undefined.
I also think the problem may be related  to Angular 8 with the static ViewChild/ContentChild update.
Any help please ?

Created a PR that should address both of these issues: https://github.com/swimlane/ngx-datatable/pull/1701
Would appreciate someone giving it a try

I have a similar issue after upgrading to angular 8, but with conditional table cell templates.
<ng-template ngx-datatable-cell-template *ngIf="column.template === 'DATE'" let-value="value">                           {{value | date: 'LLL'}} </ng-template>
code like this is not working anymore, but it definitely worked before. All ng-templates with a *ngIf condition are getting ignored...
@marjan-georgiev I checked out your branch but it is still not working unfortunately :(

released 15.0.1
@daresais I am looking at that now. The issue is with the new static property that we had to add to all ContentChild and ViewChild directives.

@marjan-georgiev yeah thought it would be something like that... really appreciating the fast response and efford!

@daresais looks like I can't set static: false on the DataTableColumnCellDirective, because it won't render the template at all.
Could you try if this will work please:

Copy the whole column and add the conditions to the ngx-datatable-column components
Use one ng-template per column with no conditions

example:
       <ngx-datatable-column *ngIf="condition here">
          <ng-template
            let-row="row"
            ngx-datatable-cell-template>
            Template contents here
          </ng-template>
        </ngx-datatable-column>

        <ngx-datatable-column *ngIf="condition here">
          <ng-template
            let-row="row"
            ngx-datatable-cell-template>
            Template contents here
          </ng-template>
        </ngx-datatable-column>

Ok I tried this. The template is working as expected when I use the ng-template without *ngIf condition. When I add the *ngIf condition the template gets ignored.
If it helps I can add a stackblitz example tomorrow morning

Right, my thinking was to move the *ngIf above the template, to the ngx-datatable-column component. See the example I posted above.

Ah sorry then I misunderstood what you meant. The *ngIf attempt above is working in general. But I have lots of cells which need different treatments. I would need to loop over the same array of columns multiple times. Isn’t that kind of bad practice? Definitely a workaround tho.

Von: Marjan Georgiev<EMAIL_ADDRESS>Gesendet: Monday, June 3, 2019 3:45:01 PM
An: swimlane/ngx-datatable
Cc: daresais; Mention
Betreff: Re: [swimlane/ngx-datatable] conditional footer is not working anymore (#1700)
Right, my thinking was to move the *ngIf above the template, to the ngx-datatable-column component. See the example I posted above.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/swimlane/ngx-datatable/issues/1700?email_source=notifications&email_token=ADVDBKUN6VQLULKWAZLGLTDPYUN53A5CNFSM4HR4TZIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWZOGQI#issuecomment-498262849, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADVDBKXS2ZQ4VMGQSPPZZKLPYUN53ANCNFSM4HR4TZIA.

Hello @marjan-georgiev .
Now the headerComponent is defined and it's working perfectly fine as usual.
Thank You so much.

Thanks for reporting it!

Hi there, I understand that this issue is closed, but I seem to be facing another issue that is related to this issue after updating ngx-datatable to version 15.0.2. If I do something like this, the custom stylings/pipes applied within ng-template will not be applied.
<ngx-datatable class="bootstrap" [rows]="list" [columns]="columns">
  <ngx-datatable-column *ngFor="let column of columns; let i = index;" name="{{column.name}}" prop="{{column.prop}}">
    <ng-template let-value="value" *ngIf="column.prop==='buyOrSell'||column.prop==='tradeType'" ngx-datatable-cell-template>
      {{ value | titlecase }}
    </ng-template>
  </ngx-datatable-column>
</ngx-datatable>

My workaround to solve the above issue would be the following:
<ng-template let-value="value" ngx-datatable-cell-template>
  <span  *ngIf="column.prop==='buyOrSell'||column.prop==='tradeType'">
    {{ value | titlecase }}
  </span>
</ng-template>

I am currently using Angular version 8.0.1, and my ngx-datatable is of version 15.0.2.

Hi there, I understand that this issue is closed, but I seem to be facing another issue that is related to this issue after updating ngx-datatable to version 15.0.2. If I do something like this, the custom stylings/pipes applied within ng-template will not be applied.
<ngx-datatable class="bootstrap" [rows]="list" [columns]="columns">
  <ngx-datatable-column *ngFor="let column of columns; let i = index;" name="{{column.name}}" prop="{{column.prop}}">
    <ng-template let-value="value" *ngIf="column.prop==='buyOrSell'||column.prop==='tradeType'" ngx-datatable-cell-template>
      {{ value | titlecase }}
    </ng-template>
  </ngx-datatable-column>
</ngx-datatable>

My workaround to solve the above issue would be the following:
<ng-template let-value="value" ngx-datatable-cell-template>
  <span  *ngIf="column.prop==='buyOrSell'||column.prop==='tradeType'">
    {{ value | titlecase }}
  </span>
</ng-template>

I am currently using Angular version 8.0.1, and my ngx-datatable is of version 15.0.2.

I am having the same issue with the same software versions.  As you mentioned, that workaround solves the issue, however requires more complex conditionals to find the base case than if ng-template could handle the conditions.  Have you had any more luck on this issue?

@zbubb Sadly, I am out of luck too. I have to warn you that my workaround is not very efficient if you have many columns, or if you are trying to display many rows. I notice there is quite a bit of latency after implementing my workaround on my own project..

same problem here, angular 8 and ngx 15.0.2 and the ngif on the template is not working

Still happens with Angular 8.2.
With the ngIf on the template is not working

@marjan-georgiev
I have multiple columns in my project more that 15, it is not working (https://github.com/swimlane/ngx-datatable/issues/1700#issuecomment-498246851) consistently with Angular 8.2. When declared ngif at the column level, for small number of columns its working properly but for large number it is failing . The solution given by @zbubb  (https://github.com/swimlane/ngx-datatable/issues/1700#issuecomment-503453046) is also not working.

Has this issue been resolved? Is yes how. I am still facing problem after upgrading project from Angular 6 to 8.
And if we are going to use the workaround as mentioned by @wentjun, is there a way to use it for multiple ng-template.

sad to see that this is not resolved.


Unsafe call made during signal handling - ProfileHandler::SignalHandler and GetStackTraceWithContext

I've been looking at a core on an Ubuntu 14.04.3 LTS system where SIGABRT was delivered to the application.  The top level libprofiler signal handler delivers a PTRACE_KILL to each thread.  This invoked the following stack which deadlocked for hopefully obvious reasons:
Thread 226 (Thread 0x7fc26fda7700 (LWP 3331)):
#0  __lll_lock_wait () at ../nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:135
#1  0x00007fcdc8030672 in _L_lock_953 () from ./lib/x86_64-linux-gnu/libpthread.so.0
#2  0x00007fcdc80304da in __GI___pthread_mutex_lock (mutex=0x7fcdcb144990 <rtld_global+2352>) at ../nptl/pthread_mutex_lock.c:114
#3  0x00007fcdca19db5f in GI___dl_iterate_phdr (callback=0x7fcdbcdea500, data=0x7fc26fd9c430) at dl-iteratephdr.c:41
#4  0x00007fcdbcdeaade in ?? () from ./usr/lib/x86_64-linux-gnu/libunwind.so.8
#5  0x00007fcdbcde8bb5 in ?? () from ./usr/lib/x86_64-linux-gnu/libunwind.so.8
#6  0x00007fcdbcde9db9 in ?? () from ./usr/lib/x86_64-linux-gnu/libunwind.so.8
#7  0x00007fcdbcdea4e9 in ?? () from ./usr/lib/x86_64-linux-gnu/libunwind.so.8
#8  0x00007fcdbcde6a31 in ULx86_64_step () from ./usr/lib/x86_64-linux-gnu/libunwind.so.8
#9  0x00007fcdc2b98d54 in GetStackTraceWithContext(void*, int, int, void const) () from ./usr/lib/libprofiler.so.0
#10 0x00007fcdc2b968ce in ?? () from ./usr/lib/libprofiler.so.0
#11 0x00007fcdc2b973f3 in ProfileHandler::SignalHandler(int, siginfo_t, void) () from ./usr/lib/libprofiler.so.0
#12
#13 0x00007fcdc80304d4 in __GI___pthread_mutex_lock (mutex=0x7fcdcb144990 <_rtld_global+2352>) at ../nptl/pthread_mutex_lock.c:114
#14 0x00007fcdca19db5f in __GI___dl_iterate_phdr (callback=callback@entry=0x7fcdca43dee0 <_Unwind_IteratePhdrCallback>, data=data@entry=0x7fc26fd9db70) at dl-iteratephdr.c:41
#15 0x00007fcdca43f270 in _Unwind_Find_FDE (pc=0x7fcdca43d4f6 <_Unwind_Resume+54>, bases=bases@entry=0x7fc26fd9dec8) at ../../../src/libgcc/unwind-dw2-fde-dip.c:461
#16 0x00007fcdca43c524 in uw_frame_state_for (context=context@entry=0x7fc26fd9de20, fs=fs@entry=0x7fc26fd9dc70) at ../../../src/libgcc/unwind-dw2.c:1245
#17 0x00007fcdca43ce85 in uw_init_context_1 (context=context@entry=0x7fc26fd9de20, outer_cfa=outer_cfa@entry=0x7fc26fd9e050, outer_ra=0x7fcdc3497ba6 <SvtConfig::getInt(std::string const&) const+710>) at ../../../src/libgcc/unwind-dw2.c:1566
#18 0x00007fcdca43d4f7 in _Unwind_Resume (exc=0x7fcd58161f10) at ../../../src/libgcc/unwind.inc:224
The code in question was throwing an exception it appears a signal was delivered to the thread when it was attempting to lock a mutex that is owned by libc.  Then ProfileHandler::SignalHandler ran its callbacks and ended up running GetStackTraceWithContext which used libunwind and tried to lock the same mutex.
Versions of software involved in this particular analysis:
Ubuntu 14.04.3 LTS
gcc-4.6.4-6ubuntu2
google-perftools 2.1-2ubuntu1.1
libc6-2.19-0ubuntu6.6
libunwind8 1.1-2.2ubuntu3

Thanks for detailed bug report.
Yes. We have to capture backtrace from sigprof signal handler. And trying to unwind from signal handler is unsafe for all but frame-pointer-based unwinder.
One feature of libunwind is that it also interposes itself over libgcc's _Unwind_XX functions. So in this case it looks like your program is throwing exception. Which usually won't need any locks in libgcc implementation. But it your case libunwind is taking over which ends up causing deadlock.
I've created some patch to try detect unsafeness of usage of libunwind here: https://github.com/alk/unwind_safeness_helper which needs gperftools patch from here https://github.com/alk/gperftools/tree/wip-unwind-safeness-helper. But this is not merged yet for complicated reason.
In your case, I believe rebuilding libunwind with --enable-block-signals might help. Or not. I'm not sure. In any case, I now have reasonable way to try to reproduce this case. So thanks for that.

Actually, your case might be different. At least I'm not able to reproduce it reliably.
What I'm seeing is that indeed --enable-block-signals is important. But it is also default and I've also checked that ubuntu 14.04's libunwind (your exact version) is doing --enable-block-signals.
So, can you please post your backtrace below _Unwind_Resume ?
Also is there any way I can reproduce this problem ?
Thanks.

The remainder of the stack trace is in our code and should not be relevant here.
I expect one could reproduce this issue by sending a thread signal that invokes ProfileHandler::SignalHandler from one thread while the other is in an infinite exception handling loop.
I don't believe it is going to be reliably reproducible.  The timing of the signal sent is important here.

I've tried exactly that. Raising exception in tight loop while capturing backtrace from signal handler.

Dear alk and jeking3,
I reproduced this issue when I enabled heap and CPU profiler together to analyse Redis(http://redis.io/). I studied the source code of gperftools, and think the main reason is that GetStackTrace() and GetStackTraceWithContext()  are not signal reentrant safe. I tried to fix it by only modifying src/stacktrace.cc. I am wondering could you please review my patch and give me some feedback. If yes, the more detailed analysis and explaination can be found at here: a patch And a report
The conclusion is followed for your reference:
I found redis-server process will hung forever when I use gproftools to do CPU and heap profile together. I found there is a deadlock bug after I attached the process by gdb. The reason of the deadlock is that GetStackTrace() and GetStackTraceWithContext()  are not signal reentrant safe. The solution for this bug is to introduce a flag named is_entry to prevent GetStackTrace*() reentry.
And the patch is attached for a quick review:
diff --git a/src/stacktrace.cc b/src/stacktrace.cc
index 395d569..680a8c8 100644
--- a/src/stacktrace.cc
+++ b/src/stacktrace.cc
@@ -243,13 +243,30 @@ namespace tcmalloc {
 namespace {
   using tcmalloc::EnterStacktraceScope;
   using tcmalloc::LeaveStacktraceScope;
+  // A patch for isuess 775. https://github.com/gperftools/gperftools/issues/775
+  __thread bool is_entry = false; // A TLS variable is aimming to prevent GetStackTrace*() reentry, which will introduce deadlock.
+  bool EnterStacktraceScope_reentry_check(){
+    if (is_entry){          // which means GetStackTrace*() was called and not finished.
+        //printf("[reentry detection] GetStackTrace reentry is detected. Can not do GetStackTrace() now\n");
+        return false;       // It is unable to do get stack trace because reentry will introduce deadlock.
+    }else{                  // which means GetStackTrace*() was not called before.
+        is_entry = true;    // Setting a flag will indicate GetStackTrace*() will be called.
+        return true;        // It is safe to call GetStackTrace*()
+    }
+  }

+  void LeaveStacktraceScope_reentry_release(){
+    is_entry = false;       // It will leave GetStackTrace*(), so clear the flag.
+  }
   class StacktraceScope {
     bool stacktrace_allowed;
   public:
     StacktraceScope() {
       stacktrace_allowed = true;
       stacktrace_allowed = EnterStacktraceScope();
+      if (stacktrace_allowed){
+        stacktrace_allowed = EnterStacktraceScope_reentry_check(); // To check whether it is a reentry of GetStackTrace*()
+      }
     }
     bool IsStacktraceAllowed() {
       return stacktrace_allowed;
@@ -257,6 +274,7 @@ namespace {
     ~StacktraceScope() {
       if (stacktrace_allowed) {
         LeaveStacktraceScope();
+        LeaveStacktraceScope_reentry_release(); // GetStackTrace*() finished.
       }
     }
   };

Thank you very much for your time.  Any comment is highly appreciated.
Best Regards,
Jingyu

It would be more appropriate for the folks who maintain and know this code to do the code review here to make sure it conforms with the programming patterns that are preferred for the project.

Hi jingyu. I think this is wrong place to add such code. Some of our backtracing methods (i.e. frame pointer) are perfectly reentrant. And libunwind already has reentrancy protection.
Your specific problem is you should link with libunwind. libgcc-based stack trace capturing is indeed non-reentrant and in fact too new to be available by default. Recursion check can be added there.

Hi alk,
Thank you very much for your feedback. I agreed with you that libunwind should be linked. Please feel free to reject my patch.
Cheers,
Jingyu

So in my original bug report it was clear this executable was linked against libunwind.  Was it too old?

I've captured my current understanding of issues in wiki page: https://github.com/gperftools/gperftools/wiki/gperftools'-stacktrace-capturing-methods-and-their-issues

This is more fun than it seems in that the same lock is held while throwing exceptions, so, if profiling happens while throwing an exception, you're doomed.
#0  __lll_lock_wait (futex=futex@entry=0x7f0d3d7f0990 <_rtld_global+2352>, private=0) at lowlevellock.c:52
#1  0x00007f0d3a73c131 in __GI___pthread_mutex_lock (mutex=0x7f0d3d7f0990 <_rtld_global+2352>) at ../nptl/pthread_mutex_lock.c:115
#2  0x00007f0d38eb0231 in __GI___dl_iterate_phdr (callback=callback@entry=0x7f0d38c456a0 <_ULx86_64_dwarf_callback>, data=data@entry=0x7f0d07defad0) at dl-iteratephdr.c:40
#3  0x00007f0d38c45d79 in _ULx86_64_dwarf_find_proc_info (as=0x7f0d38c4f340 <local_addr_space>, ip=ip@entry=139694791966897, pi=pi@entry=0x7f0d07df0498, need_unwind_info=need_unwind_info@entry=1, arg=0x7f0
d07df0340) at dwarf/Gfind_proc_info-lsb.c:759
#4  0x00007f0d38c43260 in fetch_proc_info (c=c@entry=0x7f0d07df0340, ip=139694791966897) at dwarf/Gparser.c:461
#5  0x00007f0d38c44e46 in find_reg_state (sr=0x7f0d07defd10, c=0x7f0d07df0340) at dwarf/Gparser.c:925
#6  _ULx86_64_dwarf_step (c=c@entry=0x7f0d07df0340) at dwarf/Gparser.c:972
#7  0x00007f0d38c40c14 in _ULx86_64_step (cursor=cursor@entry=0x7f0d07df0340) at x86_64/Gstep.c:71
#8  0x00007f0d399ed8f6 in GetStackTraceWithContext_libunwind (result=<optimized out>, max_depth=63, skip_count=132054887, ucp=<optimized out>) at src/stacktrace_libunwind-inl.h:138
#9  0x00007f0d399ee083 in GetStackTraceWithContext (result=0x7f0d07df07b8, max_depth=63, skip_count=3, uc=0x7f0d07df0a40) at src/stacktrace.cc:305
#10 0x00007f0d399ea992 in CpuProfiler::prof_handler (signal_ucontext=<optimized out>, cpu_profiler=0x7f0d399f6600, sig=<optimized out>) at src/profiler.cc:359
#11 0x00007f0d399eb633 in ProfileHandler::SignalHandler (sig=27, sinfo=0x7f0d07df0b70, ucontext=0x7f0d07df0a40) at src/profile-handler.cc:530
#12 <signal handler called>
#13 0x00007f0d3a73c0b1 in __GI___pthread_mutex_lock (mutex=0x7f0d3d7f0990 <_rtld_global+2352>) at ../nptl/pthread_mutex_lock.c:115
#14 0x00007f0d38eb0231 in __GI___dl_iterate_phdr (callback=0x7f0d38f525f0, data=0x7f0d07df10c0) at dl-iteratephdr.c:40
#15 0x00007f0d38f536c1 in _Unwind_Find_FDE () from /lib/x86_64-linux-gnu/libgcc_s.so.1
#16 0x00007f0d38f4f868 in ?? () from /lib/x86_64-linux-gnu/libgcc_s.so.1
#17 0x00007f0d38f50a20 in ?? () from /lib/x86_64-linux-gnu/libgcc_s.so.1
#18 0x00007f0d38f50f99 in _Unwind_RaiseException () from /lib/x86_64-linux-gnu/libgcc_s.so.1
#19 0x00007f0d390088dc in __cxa_throw () from /lib/x86_64-linux-gnu/libstdc++.so.6
#20 0x00007f0d3b5b2245 in __cxxabiv1::__cxa_throw (thrownException=0x7f0d114ea8c0, type=0x7f0d3d6dd830 <typeinfo for rockset::GRPCError>, destructor=<optimized out>) at /src/folly/folly/experimental/except
ion_tracer/ExceptionTracerLib.cpp:107

So, I guess I'll close this after all. Great news is that recent glibc (2.35 or later) and gcc 12 or later now have completely reliable and properly & truly async-signal-safe (no ifs or buts) unwinding! My infinite respect and kudos to RHat folks involved there.
Most up-to-date clang (sorry forgot version, but 17 I think should be fine) will also use dl_find_objects on gnu/linux (gnu part matters; musl doesn't have this feature).
For somebody on other runtimes, well, bug your compiler & OS vendor or use frame pointers : (
Libunwind might catch up to this soon too. (Or not; file them ticket).


Custom Target Expressions

Describe your changes
I added support for custom target expressions and a convenient editor.

Since the last PR I have found at least one indisputably correct way to use CTE.
Example: https://discord.com/channels/785153694478893126/1035719815622561892/1244630283052126298
Another example: https://discord.com/channels/785153694478893126/1035720633167921313/1237378233666633850
Testing/validation
The optimizer sometimes refuses to work with some large expressions. Like this:

This can be bypassed by slightly changing the form of the expression without changing the essence.

Also, this case is calculated incorrectly. Although when it is used as part of a larger expression, it is calculated as expected.

I can't fix it. It's an engine issue. I preferred to forget about it until the transition to Pando.
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

[x] I have commented my code in hard-to understand areas.
[x] I have made corresponding changes to README or wiki.
[x] For front-end changes, I have updated the corresponding English translations.
[x] I have run yarn run mini-ci locally to validate format and lint.
[x] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@tisseandorius I am still not convinced that Custom Target expression is the solution towards somewhat niche usecases. Can you elaborate on which usecases that existing multi-target features cannot cover? I am not sure I can understand from the discord link you sent.

I don't know why, but since this PR was published I have never encountered the optimizer refusing to work when I used CTE.
I also checked the example of the incorrect calculation, now it returns the expected result.


Added Aircoins Logo

Token Name: Aircoins
Token Symbol: AIRx
Contract Address: 0x8cb1d155a5a1d5d667611b7710920fd9d1cd727f
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[x] Filename in the lowercase format
[x] Image format: png
[x] Image size: 256 by 256 px

Also, you can use these graphics to say that your ERC20 token fully compatible with Trust Wallet (https://trustwallet.com/logo-assets). Tokens will show up automatically once the user receives them.
Feel free to share this on social media and tag Trust Wallet:

Twitter: @trustwalletapp

Facebook: @trustwalletapp


Log the indexer path on failure

Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

indexer sometimes make confusing things - it may lear some questions :)


Silly dialog when removing a folder from a workspace

Testing #30722:
On removing the first folder from my workspace I get this warning:

"added or removed" sounds strange since VS Code should know exactly what I did (and I don't think that this alert is even used in the "Add" case).
Either use the correct verb or call it "change".
In addition, the second sentence is not really adding anything new (and there is not even a "restart" button).

@weinand I am open to ideas here, my current idea is this:

The reason we have to reload the window is because you changed the first folder of the workspace and our extension host needs to be restarted because we use the first folder as "legacy" workspace.rootPath still.

Removing the first folder from a workspace is not a "change" of that folder. So either:
"Removing the first folder of the workspace requires a ..."
or
"This workspace change requires a ..."
And for the reason maybe something like this:
"... restart of the extension system."
"... reload of the extension system."
"... window reload."
"better experience" sounds wishy-washy. Our users are developers. They want correct behaviour. ;-)
And "shorter" is "better"...

@weinand good points, how about this:

I like that a lot: short but clear!

@weinand thanks


Close #1181 - Go back button isn't working as intended in some cases

Issue: #1181
When "Go back" button in Learn page and any of the lessons is clicked, it goes back to whatever previous route despite it being c0d3.com or google.com
Before:

I'm here (GitHub)
Went to https://www.c0d3.com/curriculum/js0 OR https://www.c0d3.com/docs/learn
Clicked "Go back"
Goes back to here again (GitHub)

After:

I'm here (GitHub)
Went to https://c0d3-app-lvfonog2g-c0d3.vercel.app/curriculum/js0 OR https://c0d3-app-lvfonog2g-c0d3.vercel.app/docs/learn
Clicked "Go back"
Goes back to / (If logged in, it'll redirect to /curriculum, else /)

I was almost going to include another issue's changes here. I think to create two PRs, I would have to make each one from its own branch and merge them with master once they are done, like in the C0D3 challenges submissions.

updated the main issue, let's vote? https://github.com/garageScript/c0d3-app/issues/1181

I'll close it for now, as my master got messed up. I'll correct master to make a separate branch for this issue and other issues.


Resume File Type

The resume downloaded is not showing as a pdf

I don't want to open a pull request, by adding .pdf to the href fixes the issue.
  <a href={${data.resumeURL}?dl=${data.fullName}-resume.pdf`}

.....

`

Thanks for reporting this issue. ⚡

Turns out the issue was coming from the CDN. Download works now.


[Windows 11 22000.65] : launching cmd or powershell uses wrong terminal theme

Windows Terminal version (or Windows build number)
1.10.1933.0
Other Software
No response
Steps to reproduce
Set Windows Terminal with Ubuntu with custom theme ad default profile.
Launch Command Prompt or Windows Powershell from windows start menu.
Expected Behavior
Command Prompt should use the command prompt theme defined in Windows Terminal. Same for Windows Powershell.
Actual Behavior
They will use the Ubuntu theme instead of their respective themes defined in Windows Terminal. It looks like they will use the theme defined for the default Windows Terminal profile.

Oh jeez. I guess this issue was technically first, but I've already made #10669 the tracking bug for this issue.
Thanks anyways!
/dup #10669


Kibana server not available (kibana_settings container waiting forever)

When I run the start-local script with curl, I can access the ElasticSearch database ( es-local-dev container ) but not the Kibana server ( kibana-local-dev container ).
I believe the main reason is that kibana_settings container never completes the creation of user kibana_system in the elasticsearch database .

Additionally, the logs at es-local-dev container continously report that the server exceeds its watermark . The full events are logged in the attached log file
. And If I try to run the POST _security/ endpoint from outside (using PostMan), it returns a Timeout error of exception type "unavailable_shards"  .

@dfmcub This issue is related to the high disk watermark [90%] exceeded on Elasticsearch (default value). We need to adjust this limit without using the percentage, e.g. requiring at least 4 GB of disk space. I'm working on a fix.

Hi @ezimuel ,
Thanks for the answer :D . I just saw that, strangely, the problem has a chance to solve itself if I manually purge the elastic and kibana images and then running the start_local script again. There's no guarantee it will work on the first try, though.

Yes, I'm adding a check in the start-local itself as first requirement. Moreover, I'm changing the Elasticsearch settings to require only 2 GB (and not 10% of the disk space).

@dfmcub can you try to execute the start-local.sh in main? This should fix the 90% limit disk space. Thanks!

Hi @ezimuel
I just tested the script in the following circumstances, since I saw that the Pull request hasn't been applied yet:

Download the script at main branch and running it normally from terminal : $ ./start-local.sh
Result: It works perfectly   ✅ !!  You can see the logs in this zip file I include
Clone the fix/19 branch where your pull request is and run the bashunit tests
Result: All tests passed   ✅ !!

Many thanks for the hard work 💯  👍 !!

Thanks @dfmcub for testing. I'm going to release a new version of start-local soon.


export whole dashboard as pdf

Not an issue, but can we have an option to export whole dashboard as pdf like we can tiles?

Hi there! I'll certainly review what's possible. Just to understand the use case a bit more, why doesn't Print to PDF meet the need?

Hello Lucas,
This will be  a game changer for use as we need to send hourly PDFs to executives when DTE is in a storm with customer power outages. Print to PDF will work but want to do it for the whole dashboard, not just a tile.
Thanks,
Matt Klaus
From: Lucas Hocker @.>
Sent: Wednesday, May 12, 2021 1:48 PM
To: dynatrace-oss/DynatraceDashboardPowerups @.>
Cc: Matthew Klaus @.>; Author @.>
Subject: [EXTERNAL] Re: [dynatrace-oss/DynatraceDashboardPowerups] export whole dashboard as pdf (#46)
Hi there! I'll certainly review what's possible. Just to understand the use case a bit more, why doesn't Print to PDF meet the need?

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdynatrace-oss%2FDynatraceDashboardPowerups%2Fissues%2F46%23issuecomment-839974498&data=04|01|matthew.klaus%40dteenergy.com|d2f2441b5977415b678208d9156e0f95|8e61d5fe77494e7688ee6d8799ae8143|0|0|637564384736497031|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=nRdr6MA3rvfPAh32lHM4EPW3CKM8f3OQfqXL7TZZQxs%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAUBSFYRPI5SVTNMBXUHNRS3TNK5MFANCNFSM44Y5AFOQ&data=04|01|matthew.klaus%40dteenergy.com|d2f2441b5977415b678208d9156e0f95|8e61d5fe77494e7688ee6d8799ae8143|0|0|637564384736507021|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=dBYM7EqeW%2FM7bnAy0buEVRlm9JKvOgQX3vxl9Xyu%2BQ4%3D&reserved=0.

I'm continuing to look at this from a few angles. I found some libraries I could use to generate a PDF, but they had a ton of dependencies, so I would prefer to not go that route. Also investigating if there's a CSS solution that might work.


Improve rpc compatibility

See coverage on: http://cdetr.io/eth-compat-table/

I wanted to give this one a go, but I don't get the same failures when I run the rpc tests locally. When I run them via hive[1] (with 'hive --client=pythereum:develop --test=rpc-tests') I get a ton of errors: http://sprunge.us/aOjI
I also tried running the tests directly from the rpc-tests repo, but the errors I get from that are not the same as the ones reported in the table above: http://sprunge.us/FBHG
So, now I'm wondering if the compatibility table above is out of date and, really, what needs to be fixed is what's reported in the paste above? Or am I missing something in the way I'm running those tests, and that's what's causing me to get a different set of failures?
[1] The hive master branch doesn't support pyethereum, and https://github.com/karalabe/hive/pull/22 doesn't work against pyethereum/develop because the rpc-tests/genesis.json file uses tabs and python's YAML library complains about that, so I'm using https://github.com/gsalgado/hive/tree/pyethereum

@cdetrio will have the answers you seek, @gsalgado.

Thanks for the details, @cdetrio!

Thanks for the info, @cdetrio, that clarifies a lot of things!
I tried running hive from your branch, but it doesn't work because ethash depends on the go-ethereum/pow package, which no longer exists in go-ethereum:master -- it's been moved to go-ethereum/consensus/ethash AFAICS. I'll have a go at updating ethash to use the new package
Also, I'm wondering if it's still worth trying to get pyethapp to pass the old rpc-tests from https://github.com/ethereum/rpc-tests?

@gsalgado at a glance, it looks like the tests from ethereum/rpc-tests that are failing are expected to be failing. From the readme:

A note on tests: everything in the pending state or which requires newly created logs or transcations can't be tested, as the fixed blockchain is not mining.

For go-ethereum in Hive, if the go-ethereum master branch builds outside of Hive, then it should also be building inside Hive (sometimes Docker's cache causes problems... clearing the cache should fix it). If there are problems with Hive, open an issue on the Hive repo (would also help to document over there how you fixed it).

@cdetrio right, I won't spend more time on the ethereum/rpc-tests tests, then, but there's one failing test that might be worth fixing: the one for eth_accounts fails because pyethapp doesn't include the coinbase account there, unlike geth. Should I open an issue about it?
As for go-ethereum, the problem is that https://github.com/ethereum/ethash doesn't build against go-ethereum:master. The fix is trivial, though: https://github.com/ethereum/ethash/pull/93
I've been trying to run the rpc-compat simulation from your hive branch, but so far I haven't been able to. After I've changed internal/ethash/Dockerfile to use my patched ethhash, hive failed to build the rpc-compat docker image, so I had to hack that Dockerfile as well. With the changes I made (http://sprunge.us/BKXS) it now builds all images and runs the simulation, but then simulator.py crashes with the following traceback:
("ERROR: couldn't load test file:", 'tests/tests')
    main()
  File "/validate_tests.py", line 141, in main
    run_test(test_name, sesh, client_rpc_url, mock_reporter)
  File "/validate_tests.py", line 40, in run_test
    raise Exception("ERROR: couldn't load tests file:", test_filename)
Exception: ("ERROR: couldn't load tests file:", 'tests/tests')

After messing around a bit more, I found out that was caused by the rpc-compat Dockerfile creating a nested tests/ directory under /tests, which broke validate_tests. With these changes I can finally run the rpc-compat tests via hive, so I'll start looking into what needs to be fixed in pyethapp/pyethereum

@gsalgado Sorry about that, shouldn't have left those Dockerfile lines in there. Glad you got it working!
When you work on pyeth, try a more recent branch, not the old one I was working on (some of the changes have since been merged upstream). Once change pyethapp still needs is to fix https://github.com/ethereum/pyethapp/issues/174, then some of the workarounds in pyethapp.sh can be dropped.
Lastly, a script for copying the logs out of workspace/logs:
#!/bin/bash

for client in workspace/logs/simulations/*; do
  echo "client: $client"
  CLIENT_LOG_NAME=$(echo $client | sed -rn 's/[^\[]*\[(.*)\]/\1/p' | sed 's/\:/\-/g')
  echo "CLIENT_LOG_NAME: $CLIENT_LOG_NAME"
  for clientlog in "$client"/client-*.log; do
    echo "clientlog: $clientlog"
    cp "$clientlog" reportlogs/"$CLIENT_LOG_NAME"-client.log
  done
  cp "$client"/simulator.log reportlogs/"$CLIENT_LOG_NAME"-simulator.log
done

Those logs then go in the https://github.com/cdetrio/eth-compat-table/tree/master/public/clientlogs folder for eth-compat-table.
btw, another pyeth/hive todo is to run the consensus tests against pyeth.

Sorry for breaking ethash, we've switched over to a pure Go version. I've opened a PR against the old ethash to make it self contained and not depend on our repository any more. https://github.com/ethereum/ethash/pull/95 This should solve the issues for code depending on the old implementation.

Running hive from https://github.com/gsalgado/hive/tree/rpc-compat, which uses my pyethapp branch from #196, I get all tests for the methods implemented in pyethapp passing.


Add ReadContext/WriteContext

Read/Write overhead is increased a little bit,
but Read/WriteContext is faster than Read/Write.
BenchmarkBufferWR14

version
iter
op
bw

Old
19459795
61.1 ns/op
229.30 MB/s

New NoContext
17973650
67.2 ns/op
208.40 MB/s

New Context
30738019
39.1 ns/op
358.17 MB/s

BenchmarkBufferWR140

version
iter
op
bw

Old
17757152
68.1 ns/op
2056.79 MB/s

New NoContext
16810936
71.5 ns/op
1957.94 MB/s

New Context
24479403
48.6 ns/op
2883.21 MB/s

BenchmarkBufferWR1400

version
iter
op
bw

Old
13673950
86.7 ns/op
16147.15 MB/s

New NoContext
13727745
86.8 ns/op
16133.11 MB/s

New Context
18450013
64.8 ns/op
21615.95 MB/s

BenchmarkBufferWWR14

version
iter
op
bw

Old
18965374
63.1 ns/op
221.96 MB/s

New NoContext
18021373
66.3 ns/op
211.27 MB/s

New Context
30697444
38.5 ns/op
363.67 MB/s

BenchmarkBufferWWR140

version
iter
op
bw

Old
17718662
67.6 ns/op
2069.95 MB/s

New NoContext
16284301
73.5 ns/op
1904.41 MB/s

New Context
23965249
49.5 ns/op
2825.72 MB/s

BenchmarkBufferWWR1400

version
iter
op
bw

Old
12484290
96.5 ns/op
14509.35 MB/s

New NoContext
12258870
96.9 ns/op
14445.11 MB/s

New Context
16885568
70.7 ns/op
19803.04 MB/s

Reference issue
https://github.com/pion/transport/pull/74

Test on the master branch looks broken
https://github.com/pion/transport/runs/1408341537

CI will be fixed by https://github.com/pion/transport/pull/106

I don't understand how without Context can be slower. Is context.Background() every time expensive, could we have a stored one on the buffer?
Reading the benchmark now.

In my understanding, reading channel internally uses futex syscall which is relatively slow.
So, adding more channels to select syntax increases overhead more.

How does it look when you drop the Read Deadline? Does anyone even use that today.
We might be able to just go Context only and do github.com/pion/transport/v2. We don't expose the buffer in pion/webrtc so I don't feel to bad breaking it!

But I am in support of this if you own it! Everything you have ever worked on has turned out great, so I trust your judgement :)

I think Read with deadline would be better to exist to make it compatible with Go1's io.Reader. (not very strong opinion)
As most of the code is shared between them, it doesn't requires much effort to maintain.
We can drop it if it costs too much to be maintained though.

Opened an issue for the ordinal Read/Write interface.


Visualizations: Allow multiple data elements to use the same entity constraints

See related issue https://github.com/VEuPathDB/EdaDataService/issues/190
We currently only allow linear data element entity constraints in dataElementDependencyOrder, something like:
  'yaxis' -> 'xaxis' -> 'overlay' -> 'facet'

We would like to be able to allow 'overlay' and 'facet' to "share" the same entity constraint:
 'yaxis' -> 'xaxis' -> ['overlay','facet']

The plan is for the backend to allow a nested array to convey this capability:
 [ 'yaxis', 'xaxis', ['overlay','facet'] ]

Changes will need to made to https://github.com/VEuPathDB/web-eda/blob/c71bfa78449836c876f89fcd097920d8a3272a40/src/lib/core/types/visualization.ts#L115, https://github.com/VEuPathDB/web-eda/blob/c71bfa78449836c876f89fcd097920d8a3272a40/src/lib/core/components/visualizations/InputVariables.tsx#L107, and https://github.com/VEuPathDB/web-eda/blob/c71bfa78449836c876f89fcd097920d8a3272a40/src/lib/core/utils/data-element-constraints.ts#L12-L93. There may be other functions that need to be updated that assume the type of dataElementDependencyOrder to be string[].

For consistency I made it an array of arrays, so expect
[ ['yaxis'], ['xaxis'], ['overlay','facet'] ]
This is drafted backend, including changes to EdaCommon and the data service on branch variable-constraints

For consistency I made it an array of arrays, so expect [ ['yaxis'], ['xaxis'], ['overlay','facet'] ] This is drafted backend, including changes to EdaCommon and the data service on branch variable-constraints

Do we ever expect to have an array with more than one element in any place other than the end?

Yes. Ive let the mosaics for ex treat the axes similarly, hoping it'll close a related issue.

Ah, cool. In that case, we have to determine which entity of those two elements will be the constrainer for the next set of elements. Presumably, we would choose the closest common ancestor entity of those elements; or if one is an ancestor of the others, that one?

I'd imagine we'd find ourselves in a pickle if we tried for ex to put a participant repeated measure on one axis and a household repeated measure on the other... Unless the merging service is cleverer than I know. So I guess all members of any one of the inner arrays will have to belong to the same branch of the entity tree, and then take the most ancestral among them to serve as the constraining entity.

Is this ticket related to the conversations that need to happen about Visualizations: revisit variable constraints? I am pausing until I can check in with @danicahelb.

fwiw i was interpreting this ticket and the one @sweverschulman linked to as functionally duplicates, though each had a different proposed solution. i also think what we implemented was the better of the two proposed solutions. but be sure to let me know if others disagree or theres some use case the current solution doesnt cover.

issue with dependency order on terms allowed for overlay vs facet is fixed.
Variable constraint documentation needs to be updated to reflect these changes (see https://github.com/VEuPathDB/web-eda/issues/575). In particular, please update the verbiage in this section:


Update autoroller builder to pass a flutter owned gcs bucket.

The builder has been failing because it tries to upload metadata to a
chromium owned bucket.
Bug:
https://github.com/flutter/flutter/issues/45630

LGTM, but I suggest putting the starlark and generated files in separate directories so it's easier to review. Mostly I review starlark closely and skim generated output but they're mixed together here.

Moved config files to generated/flutter


Adding Twilio SMS binding

Also regenerated the Resources.Designer.cs file. Doesn't seem like it was required, since it was missing a lot of resources, but this brings it up to date.

Looks OK to me. Looks like a lot of stuff has changed in templates (loc, etc.) so those guys should take a look as well.

We can put this behind filter like this and merge it in.
"filters": [
                "showHiddenBinding"
              ]

refer to this for more details
https://github.com/Azure/azure-webjobs-sdk-templates/issues/51

Looks good.

Out of curiosity, what is the filter for?

So that we can hide a binding in production until it is ready for release.

Technically, there's no reason to hide that binding. I'm assuming what we add here will be available in the next release (next tag), correct?

Yeah, I don't think this needs to be hidden either. It just needs to be tagged along with the other changes like F# template updates, etc.

Yeah we should not hide it.


Forwarded motion: new view options

Description:
A forwarded motion should get a new view, where a participant can take a look back into the original version with additional information.

The View should get a new group-permission

In the Motions group, over "Can forward motions"
The title should be "Can see motion origin" (e.g. can_see_origin)
Tooltip description: "Can see the origin from a forwarded motion"

Only users with the permission can_see_origin can see the new slidetoggle and if activated the display of the new view
The new view:

The Tab name should be the meeting name the motion was forwarded from/ the meeting you are in right now
The border from the forwarded motion should be in the warn colour (see Mock-up)
the last poll should be displayed openly, the other polls should be inside a mat-accordion or similar (if these instructions are unclear talk with @MSoeb)
other public information of the motion should be displayed *if public is not clear please ask) done by autoupdate
If the motion was forwarded as original motion plus amendments then the motion should be displayed in the diff version plus "Show all changes" is activated
If the motion was forwarded as a final version then the motion should be displayed in the final or editorial final version
The motion per default should be displayed in the diff version, you should be able to switch between the different versions though

Additionally (generally) wanted:

The Submitter names (plus their structure levels) from amendments should be displayed behind "zugelassen" etc.

Note: This is just a suggestion for the new feature. It does not needs to look exactly like the mock-up

Please ask @MSoeb or @Elblinator if there are still questions

We need to discuss the feature and add more details to the issue.

I think this still needs discussion on for example how to retrieve the data, when this view should be available, ...

waiting for #3527

We are planning to deliver the data via autoupdate. With that we need to do adjustments to some very low level services in the client because this means that we are now in the situation where we have data of multiple meetings in our local model store. This complicates things with deleted data and view model lists.
Besides from that we should also do some refactoring in the motion-detail component in preparation to this feature.

I took an in-detail look at what would have to be done in the autoupdate:
As far as I can see, the easiest way to do this would be to:

Expand the motion restriction so that

a user can see the motion if he has motion.can_see_origin in any meeting of any motion in motion/derived_motion_ids (if it should also work on deeper links of the forwarding chain, motion/all_derived_motion_ids will have to be used)

Expand the motion_state restriction so that state may also be seen by anyone who can see a linked motion

There were some models where I wasn't sure whether they are required to be visible in the portal, I'll write the requirements here, @Elblinator @MSoeb or @emanuelschuetze will have to determine what we need in these cases:

motion_category or tag: Analog to what needs to be done for motion_state
motion_block: non-internal blocks should also be visible to those who can see a referenced motion
Among the other related models, I didn't consider it sensible that the user should be able to see mediafile attachments, list_of_speakers, projections or personal_notes, so I didn't look into it

Everything else necessary should be unlocked automatically via above-mentioned measures

motion_category or tag: Analog to what needs to be done for motion_state
motion_block: non-internal blocks should also be visible to those who can see a referenced motion
Among the other related models, I didn't consider it sensible that the user should be able to see mediafile attachments, list_of_speakers, projections or personal_notes, so I didn't look into it

Points 1 and 2 seem sensible to me. In my opinion, they can be implemented in this way. For point 3, I would exclude the media files and possibly the list of speakers.
Media files: A linked file could be of interest, as it could embed the motion in a context and the overall context is only conclusive with the media file. -> My suggestion here would be that, if technically possible or feasible with reasonable effort, media files can also be displayed and opened.
List of speakers: It is similar with lists of speakers. Knowing who has spoken can be helpful information. I see the difficulty here more in the UI implementation, where we would place this information. - For practical reasons, I would therefore want to avoid integration.
What do you think @emanuelschuetze ?


Add Documentation for Track 2 Management SDK

[ ] The purpose of this PR is explained in this or a referenced issue.
[ ] The PR does not update generated files.

These files are managed by the codegen framework at Azure/autorest.go.

[ ] Tests are included and/or updated for code changes.
[ ] Updates to CHANGELOG.md are included.
[ ] MIT license headers are included in each file.

I doubt if it is necessary to break up a full sample program into pieces and put it in the quick-start. But those pieces need to be consistent with each other and have the same style.
I propose that we could make the new-version-quickstart brief and add a reference to the full sample program for reference.

Makes sense. For full end to end sample, can we add them to the samples repo so I can provide links to them?


Configure the Development Environment

Tutorial URL: https://developers.sap.com/tutorials/haas-dm-configure-dev-env.html
Please specify the step you are referring to Step 4
Sorry, I can´t find the Extension "SAP EIM Smart Data Integration Editors "
Regards
Marco

Hi Marco, I see it in my Full stack Web IDE.  I suggest you enter a support ticket as the plug-in should be available.
Closing this as this is not the channel for support.


Anonymous Message Board -  fcc test suite for the project passes without requiring any api implementation

Describe your problem and how to reproduce it:
Implementing project only the following cases are enough for all tests to pass

Only allow your site to be loaded in an iFrame on your own pages.
Do not allow DNS prefetching.
Only allow your site to send the referrer for your own pages.

to reproduce the same

clone the boiler plate for the project
implement the above test cases using helmet js
create a repl.it by importing the github repository
running the repl.it and using the link as solutions link is enough for test cases to pass

Add a Link to the page with the problem:
Boilerplate for the project
My Implementation which passed the test cases
Tell us about your browser and operating system:

Browser Name: Firefox developer edition
Browser Version: 84.0b8 (64-bit)
Operating System: Ubuntu 20.04

If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):
all the test cases were passed, although no requests by the fcc test suite were made to any project api's, except for the ones dealing with checking the response headers

This occurs because, at the moment, there are not tests present for the routing:
https://github.com/freeCodeCamp/freeCodeCamp/blob/master/curriculum/challenges/english/09-information-security/information-security-projects/anonymous-message-board.md

Thank you, for taking the time to open this issue. We are aware of this.
As such, I am closing this as a duplicate of #37185


Proxmox component-specific methods are sometimes not ideal

The title of this Issue is probably a little unclear what I mean. But as an example, take the function to request a node's version details: https://github.com/luthermonson/go-proxmox/blob/0a31b09c4fdd6a42813053a7423a56a23c378b1d/nodes.go#L24
This API method requires me to make a request to Node(ctx, nodeName) and then make the request to get the VE node's version from the Node struct that it returned. So, I'm making 2 API requests to get that version data, when I could do this in 1 API request if the method took a node name string instead.
I see the design decision, but I don't think it's a good assumption that I'm always going to care about all the output from Node(...) when I want the data from Version(...). For example, maybe I just made a request to Nodes(ctx), got my list of nodes (and their names) and now just want to hit the Version method, or maybe I know my node names some other way (I did name them in the first place.)
The Node/Version API method issue is just one example, that design decision with that assumption is seen across many other API methods in this library.
I actually wrote my own library for a PVE prometheus metrics exporter product I work on partially because of this constraint, but it's maybe something to think about here, since your library has more users it services.

I'm also kind of curious, do you test this library against specific Proxmox VE server versions? I've noticed some API backwards incompatibility issues with the PVE API between 7.x.x and 8.x.x. Curious how you maintain backwards compatibility or where you notate which versions of your library support which PVE versions.

RE the compatibility, we tend to mostly move forward and people test with what they have in their home labs and i've noticed that most people keep their labs up to date when new versions drop. open to branching ideas or if anyone has hardware and nested virtualization to offer e2e tests on different versions. ill answer the other question in another comment

RE Version()... there are two... the cluster https://github.com/luthermonson/go-proxmox/blob/main/proxmox.go#L84-L86 which uses this endpoint: https://pve.proxmox.com/pve-docs/api-viewer/index.html#/version and the node https://github.com/luthermonson/go-proxmox/blob/main/nodes.go#L24-L26 which uses this endopint: https://pve.proxmox.com/pve-docs/api-viewer/index.html#/nodes/{node}/version
dont ask me what is different about them as i havent looked into it... i just know they exist and i think the node.Version func is probably where it should be for now.
I understand your concern in your example for version having an extra call to "initialize" (for lack of a better term) the Node but once the node is setup you can use it repeatedly like polling status etc. and that initial call to load the Node helps us error check the node exists which I think has benefit.
I think in your version scenario where you don't want to make the two calls you can make a helper function which calls client.Get yourself and bypass creating the Node if you really want too.
I also concede that the lister calls like Nodes() or VirtualMachines() or Containers() should probably return lists of the Type they claim to be listing and Nodes() returning NodeStatus is kinda dumb and perhaps if that was rewritten it would help solve your problem as well.

I think in your version scenario where you don't want to make the two calls you can make a helper function which calls client.Get yourself and bypass creating the Node if you really want too.

That feels like getting a tiny bit of the benefit of using a client library, I suppose :smile:
Anyway, this is your product. Seems like we disagree about the exact level of unnecessary entanglement it causes so I'll just continue on with my own library, so no worries there.

I also concede that the lister calls like Nodes() or VirtualMachines() or Containers() should probably return lists of the Type they claim to be listing and Nodes() returning NodeStatus is kinda dumb and perhaps if that was rewritten it would help solve your problem as well.

The API return for /nodes is actually a bit different than /nodes/{name}/status (other than the obvious difference of one being a slice) so I don't know that I'd call it dumb :)

we tend to mostly move forward and people test with what they have in their home labs

That makes sense too, thanks for the answers to everything. It sounds like the outcome of this Issue requires no action items. If you agree, feel free to close this Issue :)

RE Version()... there are two... the cluster https://github.com/luthermonson/go-proxmox/blob/main/proxmox.go#L84-L86 which uses this endpoint: https://pve.proxmox.com/pve-docs/api-viewer/index.html#/version and the node https://github.com/luthermonson/go-proxmox/blob/main/nodes.go#L24-L26 which uses this endopint

I glean from this that you decided on the pattern you did (of using methods tied to API object returns) to organize your different API methods for mostly this reason.
Fwiw, I think the API client service pattern offers the same separation/organization of your API methods, without tying the user down into making extraneous API requests https://github.com/starttoaster/go-proxmox?tab=readme-ov-file#usage
In my usage, client.Nodes.<Method> offers me the same method cataloging capabilities it seems like you wanted here, without planting unexported clients into the structs my API methods return.

Sorry if I overstepped my bounds here suggesting a whole kind of API backbone change. I actually think it's a cool client library pattern. I just think it makes more sense in, for an example, a situation where the first request to an API server responds with some kind of session or secondary authentication token of some kind, that needs to be passed along in the headers or something of the next request. I don't think it really makes sense for a string name input, but to each their own. Anyway, closing since there's nothing to do if you prefer the current pattern.

@Starttoaster no bounds overstepped in open source. no worries. I hope you weren't worrying about your last comments the last 2wks? Come join the slack channel and let's have a chat, I think you offer some insight and I'd love to chat with you in real time

Haha, I wouldn't say I was worried. I just figured a suggestion to change a common pattern in your library you've been maintaining for a few years might be seen as potentially audacious depending on who I'm talking to 😄 I'd be glad to join the server, I'll drop by tomorrow sometime :)

chat soon then!

@luthermonson I did try to join, and maybe it's pebkac as I don't actually join Slack workspaces all that often, but when I click the Slack link on the readme it seems to gate me for not having an account in that workspace, so I think it might need to be replaced with an invite link, which either have an expiration of some number of days, or a limit of 400 uses by different users. Unless I'm somehow doing the wrong thing 😂

https://gophers.slack.com/ try creating a workspace account here

That's where the link in the readme would take me, yeah. Signing into my account that I'm signed into in my client would lead me to this error page which led me to think it was potentially private/invite-only.

uhhhh that is weird. im like 99.9% sure it's public... i'm on kube slack if you want to reach out there too


[Bug] ChatQnA is taking ~75 seconds to provide response for the first answer

Priority
Undecided
OS type
Ubuntu
Hardware type
Xeon-GNR
Installation method

[X] Pull docker images from hub.docker.com
[ ] Build docker images from source

Deploy method

[X] Docker compose
[ ] Docker
[ ] Kubernetes
[ ] Helm

Running nodes
Single Node
What's the version?
latest
Description
This was on a bx3d-16x80 instance on IBM Cloud. It has 16 vCPU, 80GB RAM and 100GB boot volume.
ChatQnA UI takes ~74 seconds to prepare a response.

This long response time, in addition to the usability bug at https://github.com/opea-project/GenAIExamples/issues/1003, creates a poor developer experience.
Reproduce steps
Follow the instructions at https://github.com/opea-project/GenAIExamples/tree/main/ChatQnA
Raw log
No response

Could you please try the latest OPEA v1.1 release? This version uses the latest Intel-optimized TGI image, ghcr.io/huggingface/text-generation-inference:2.4.0-intel-cpu, which should offer improved performance. However, with a CPU that only has 16 cores, achieving optimal performance is challenging, especially for deploying RAG applications that involve multiple services.

Priority
Undecided
OS type
Ubuntu
Hardware type
Xeon-GNR
Description
This was on a bx3d-16x80 instance on IBM Cloud. It has 16 vCPU, 80GB RAM and 100GB boot volume.

@arun-gupta
We recommend 32 Physical Xeon Core (or 64 vCPU) to run  ChatQnA, in which the default LLM model is 7B (float16).
16 vCPU cannot run ChatQnA smoothly.


Provide pointer to PowerShell substitute(s)

The documentation parent page recommends using PowerShell. Would be useful to actually provide links to the PowerShell equivalents.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0dfc8030-f3f6-6dae-241c-96104e5d7421
Version Independent ID: c2857f52-2dea-d007-22d2-6ece7f870f00
Content: Netsh commands for interface portproxy
Content Source: WindowsServerDocs/networking/technologies/netsh/netsh-interface-portproxy.md
Product: windows-server
Technology: networking
GitHub Login: @shortpatti
Microsoft Alias: pashort

#assign:xelu86

Thanks again for contacting Microsoft. We value your feedback. The commands in reference to this page, "netsh-interface-portproxy", work as intended in PowerShell as well.
The following can be ran in PowerShell as a reference: netsh interface portproxy /?

Adding "add" before the "/?" will provide the following:

Following the instructions in said document should yield the same results in both Command Prompt & PowerShell.
We will be closing this as resolved. Thank you and have a most pleasant day. #please-close


Update rules_ios example to 2.1.0

You'll need to run it with the right configs --config=fixtures --config=cache (i.e. bazel run --config=cache --config=fixtures //test/fixtures:update). Or at the root of the repo, run ./test/update_all_fixtures.sh.

Thanks @brentleyjones that ./test script did it


MaterialEditor: Duplicate Items in the MatDefs Selection Dropdown Menu.

Hmm yeah, I have no idea how this situation has occurred. It would be easy to just implement a naive fix to remove the duplicate entries. However, I don't think that is a proper solution.
Could you @capdevon debug this? Is this repeatable occurrence?

Iirc it's been like that for a long time. I'll take a look at it

thank you guys for the support


Don't un-eject redis if it's an unsynced slave

I'm experimenting with the following setup. 1 master Redis DB (not connected/related to twemproxy) replicates to N read slaves. The pool of read slaves are managed as a single twemproxy pool. The key distribution is 'random' since every slave has the full data set.
When a slave dies, twemproxy takes it out of the pool due to auto_eject_hosts being set. The problem I have is that when if the slave is restored, then it will start accepting connections before it's fully synced (standard Redis behaviour). Reads against this slave will give (error) LOADING Redis is loading the dataset in memory. Twemproxy puts it back in the pool and now 1/N commands will start to fail with this error. It would be really nice if Twemproxy were able to check for this condition (enabled by a new config option?) and not reinstate the slave until it's fully synced.
Would that behaviour be of use to anyone else? Interested in comments on the idea and if there's any appetite for it before I consider dusting off my C hat...

The fix would involve the following

change the response parser to recognize -ERR LOADING Redis is loading the dataset in memory response. Let's name this response as ERR_LOADING enum. The current implementation only recognizes whether the response is error or not. The new change would require to take the parsing one step further for -ERR responses.
eject a host, if the response is an ERR_LOADING resposne

part 1 of the above fix has been checked in: https://github.com/twitter/twemproxy/commit/5e082b8d3ae0479b8f019a5f53e1e289f66ddfe9

I had a look at what part 2 would involve yesterday, but I'm not sure where the 'right' place for the new check would be (we can check msg->type == RSP_REDIS_ERROR_LOADING, maybe in rsp_forward?). Even if I knew the right place for the check, I'm not sure how to eject a server from the pool - I assume we call server_failure but it needs the server passed and I'm not sure how we get that from the conn. I also don't know if it would need anything 'extra' to handle anything else once the server's ejected, or if server_failure does it all for us.

No worries, thanks for giving it a shot.
I've fixed this here: https://github.com/twitter/twemproxy/commit/ef453130e321974b332dd99d585ae7285eee4b5d. Note that in this patch, I'm regarding error strings -OOM, -BUSY and -LOADING as transient failures
Would really appreciate if you could test it and let me know if it works as intended.

Thanks very much - will test this in the next few [working] days and let you know how it looks.

I've been doing some testing on this and it seems to work well :-) The only issue I have found is that when Redis returns any of the 'transient failure' codes, the error passed back to the client will always be an 'Invalid Argument' error, rather than the actual transient error. I assume it's because of https://github.com/twitter/twemproxy/commit/ef453130e321974b332dd99d585ae7285eee4b5d#diff-58e034be09d03afa76ee03064fba0055R200. If I'm reading it right, this is because the connection->error is and errorno value rather than a Redis error (string/whatever), but I can't see where later on the conn->err (EINVAL) is then mapped back to a redis 'Invalid Argument' error (but it must be there somewhere!).
I don't know how hard/sensible it would be for the redis_failure (and memcache_failure) functions to return an errorno (or 0) that can be sensibly mapped back to a redis client error so that the client can get the 'correct' error message:
MSG_RSP_REDIS_ERROR_OOM -> ENOMEM
MSG_RSP_REDIS_ERROR_BUSY -> EBUSY?
MSG_RSP_REDIS_ERROR_LOADING -> EAGAIN?

This isn't a huge deal, this patch would work for us as-is, but I guess others might want to preserve the error (and we might want to handle loading differently than nomemory at some point). I guess some people (again, I don't think we need it to be at the moment) might want this new functionality to be configurable if they're already handling loading errors themselves.
Overall this is really nice - thank you very much!

The conversion happens here:

https://github.com/twitter/twemproxy/blob/master/src/nc_response.c#L331-L332
https://github.com/twitter/twemproxy/blob/master/src/nc_response.c#L83
https://github.com/twitter/twemproxy/blob/master/src/nc_message.c#L326-L356

I agree that it would be nice to pass back the error code from the redis server as-is to the client. However, doing that would require a significant rewrite. I'll leave it as-is and we can come back to it if it is really needed


Add Dockerize and ASP.NET Core doc

Proposed changes
Add "Dockerize an ASP.NET Core app" documentation to the Docker engine examples section.
This doc takes the user through adding a Dockerfile and .dockerignore file to a simple ASP.NET Core application. It includes both Linux and Windows Container options for writing the Dockerfile. It then instructs the user on how to build and run the Docker container and view it in the browser.

This doesn't look good to me. I'm copy-pasting a critique I've offered to assorted others previously.

The basic problem is that the tutorial assumes users build the .NET app outside of Docker. This means the tutorial requires installing a bunch of random software on the machine for the project to build (in this case VS, .NET Core and Bower and Gulp - in addition to Docker). This nullifies one of the main reasons that developers love Docker, namely that Docker eliminates "It worked on my machine!?" problems. As currently written, to build a .NET app using this method, a developer onboarding to a project still has read through a long'ish setup readme, familiarize themselves with npm, install it, install .NET framework, etc. And woe betide you if you have the wrong version of any of that software installed, or it's misconfigured. An ops-guy will have the same headaches trying to set up and maintain a CI system.

Note that I'm not opposed to the pattern where you build a slim container for deployment. Here's a PR sent to some of Steve's code showing how this can be combined: https://github.com/SteveLasker/BuildASPDotNetInAContainer/pull/1/files
cc @glennc

Thank you @friism. That makes a lot of sense. I'll rework the doc based on your feedback.

@kendrahavens awesome, let me know if I can help.
It's a little contrived, but here's one way you could do the flow:

docker run -v ${PWD}:/app --workdir /app microsoft/dotnet:1.1.0-sdk-msbuild-rc4 dotnet new mvc
Add Dockerfile similar to this
Show that it builds and runs
Show how to add the .deploy Dockerfile
Do the scripting to copy build output from builder to deploy container as done here.

Any movement on this? We'd love to get it in!

@mstanleyjones Right now we are rewriting this sample to build the app in an sdk container and then run in a runtime container.  This way the user avoids needing .NET Core installed on their local machine. We are considering the work on multi-stage builds that looks right for this scenario. So our Dockerfile would look somewhat like:
FROM microsoft/dotnet:1.1-sdk-msbuild
AS build
WORKDIR /app

# copy csproj and restore as distinct layers
COPY dotnetapp.csproj .
RUN dotnet restore

# copy and build everything else
COPY . .
RUN dotnet publish -c Release -o out
ENTRYPOINT ["dotnet", "out/dotnetapp.dll"]

FROM microsoft/dotnet:1.0-runtime
WORKDIR /app
COPY --context=build out .
ENTRYPOINT ["dotnet", "dotnetapp.dll"]

Should I close this and open a new PR when the new sample is ready?

It is up to you. What is the COPY . . about? I've never seen that syntax before.

Cool! COPY is just like Add, but preferred because it is more transparent. It copies files from a source to a destination. The . is the current directory.

We are considering the work on multi-stage builds that looks right for this scenario

😍

What is the overlap between this and the recently-published https://docs.docker.com/compose/aspnet-mssql-compose/ ?

We'd like to have an ASP.NET core example that demonstrates how to build with the onbuild image and deploy with the much-smaller dotnet runtime image. The doc you mentioned covers a compose scenario while there is the simpler "Dockerize an app" scenario that could be a good addition to the Docker engine examples section of the documentation.

Multi arch will also change this, along with mutli-stage build.

Any news?

Any news?

Sorry for not responding sooner! We've been holding off on merging any multi-stage build samples into our samples and guidance repos until it is part of the stable Docker for Windows channel. This shouldn't hold up adding a .NET sample to your docs though! I simply hadn't gotten to it.

Please remove the stalled label when you are ready for us to review this one again.

I can't track the place where @thaJeztah told you to use e.g. but I think it is better to say for example, in the text flow, or just leave that off. Popping into Latin that nobody remembers what it stands for can be problematic for people whose first language is not English, and the amount of benefit you get from it is very small.

@mstanleyjones Could you remove the stalled tag? I believe I've addressed all the requested changes.

@mstanleyjones @thaJeztah Hey folks, are there any more changes I can make? I see the deploy/netlify preview failed. Is there anything I can fix to get it passing?

I removed the stalled label. You can make Netlify start again by amending and force-pushing the commit. Let me checkout this PR and verify that it builds locally, though.

FYI there are some mistakes in the YAML of the file. You can't word-wrap in the YAML without changing the syntax of it. I'll push a commit that fixes that after I finish testing locally.

I found a few more problems, still working on this. I'll push all the commits I've added when I get this into a better state.

@mstanleyjones Thank you so much for your help on this!

@johndmulhausen I tested this locally and it works fine. Netlify is busted thinking it's against the vnext-engine branch. Can you please squash and merge this, and make sure to clean up the commit message when squashing? Thanks!

Thanks for the review @mstanleyjones !


Analyze: Look into using Aiven as a Kafka provider

Description
The cost of Confluent Cloud hit us a bit too hard. We should look into alternatives and see if they can be cheaper. One such provider is Aiven.
In scope
Known requirements:

Secured network, peering for ai-dev
Cheaper than Confluent Cloud
More?

Out of scope
No response
Additional Information
No response
Analysis
No response
Conclusion
No response

Lukkes - Kafka skal ikke brukes


theta_offset in PolarizedNeutronProbe in unstable is doing the wrong thing

The "feature" of recalculating the Q-values for the PolarizedNeutronProbe when theta-offsets are present is buggy.  A. Grutter found that adjusting theta_offset parameter causes large changes in the spin-asymmetry theory which should not be the case.  Pasting the SA plot for two different theta_offset values (seems to mostly affect the critical edge region, or low-Q):

CANDOR_NoPMMA_Single.py.txt
Freestanding_SiO2_Thick_NoPMMA_6K.refl.txt

This seems to be an issue with the resolution/oversampling.  It's possible it's doing the right thing with respect to the theta_offset, but somehow the oversampling isn't working?  Or maybe the combination isn't working.


Support cuTENSOR 0.2

This PR aims to support new APIs for tensor reduction added in cuTENSOR 0.2.
cuTENSOR C APIs for tensor reduction are exposed in cupy/cuda/cutensor.pyx. In addition, a bit abstracted API reduction() is also exposed in cupy/cutensor.py so that python developers can use it easily. An example is in cupy/example/cutensor.
Please note that you need to set an environment variable CUTENSOR_PATH when you build CuPy with cuTENSOR enabled.
$ cd (to where cupy is installed)
$ CUTENSOR_PATH=/path/to/cutensor python setup.py install

pfnCI, test this please.

Jenkins CI test (for commit 871bdb41c1130595e9e0003c8805913706edd096, target branch master) failed with status FAILURE.

Btw, cutensorGetCudartVersion API sounds nice to detect installation errors. I think it's good if other CUDA libraries provide the equivalent too. I sometimes heard users using cuDNN built for different version of CUDA and get errors like CUDNN_STATUS_INTERNAL_ERROR (which we are almost impossible to diagnose).

Thanks for your comments. I've just updated the PR. Could you check it again?

pfnCI, test this please.

Jenkins CI test (for commit c9d0def8c4eada8a579e469c11da0116bc205473, target branch master) succeeded!

Thank you for merging the PR!


Some last minute fixes

fixes some problems with the notebooks.

Two of your lessons are in Python. The JavaScript lesson you did not take the Authors name out of the front matter from the other classs.


Update README.md

Changes

Reason for changes

Related tickets

Tests

Codecov Report

Merging #13 (33379a9) into develop (2a3986d) will decrease coverage by 20.78%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##           develop      #13       +/-   ##
============================================
- Coverage    36.06%   15.29%   -20.78%
============================================
  Files          476      476
  Lines        42397    42397
============================================
- Hits         15291     6483     -8808
- Misses       27106    35914     +8808

see 209 files with indirect coverage changes


v0.7

Description
This release will bump the versions of dependencies as well as bring the codebase into a modern rust version. Merging this PR is reliant on https://github.com/WalletConnect/hyper-alpn/pull/9 getting merged and released first.
How Has This Been Tested?
Using cargo test
Due Diligence

[x] Breaking change
[x] Requires a documentation update
[ ] Requires a e2e/integration test update

This PR is waiting for @jrconlin's PR from the Mozilla Service's repo before we cary on so that I'm not writing the same fixes they are.

you could probably land this one and I can merge the changes in localized.rs and the others. This looks like it's mostly updating code.
(Sorry, been busy with other projects. Will try to get the PR done this week.)

you could probably land this one and I can merge the changes in localized.rs and the others. This looks like it's mostly updating code.
(Sorry, been busy with other projects. Will try to get the PR done this week.)

👍🏼  Also looking at #62 to try get this into v0.7, will double check you changes and if non breaking I'll merge this and just release a v0.7.1 afterwards with you changes.

Since this is OSS, can we add a .editorconfig while we're at it?

I'll make an issue and add this later


Implement accountInfo

it needs to get the data about a wallet based on its name
basically to query this storage map: https://github.com/ideal-lab5/pallets/blob/d9aa53506d59b350a23647a6c9b04e253955094d/pallets/murmur/src/lib.rs#L98

@driemworks should we close this issue? This information can be retrieved from polkadotjs or etf.js

not needed anymore


[opentelemetry] Add basic OTel metric and log E2E tests

Description
APM R&D week work.

OTEL_METRIC_E2E generates 1 delta counter metric + 1 delta histogram metric. Test runner calls api/v1/query to get the metric timeseries from backend and validates them.
OTEL_LOG_E2E generates 1 OTLP log record within a trace scope. Test runner calls api/v2/logs/events to get the log from backend then validates the log as well as log-trace correlation.

Motivation
Extend the E2E test coverage to all telemetry signals in OTel.
Additional notes

/cc @dinooliva

Thanks for the review!


Feature Request: Add input sample files

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description
Is your feature request related to a problem?

When working with customers I would prefer to work with an "inputs" file instead of using the PowerShell prompts.  This will give me the following benefits:

Ability to enter the inputs out of order
Ability to save the file as an artifact of the delivery
Ability to create the file across multiple sessions and desktops.
Ability to re-run the file if necessary.  (This can also be accomplished using the cache)

Also note, that "organization" is spelled with an "s" (e.g. "organisation") in some places.  This should be corrected.
Describe the solution you'd like

I have attached a couple sample inputs files, one for GitHub and one for Azure DevOps.  Note I have appended ".txt" so they can be included in this feature request.  It would be great if they were included in the repo.  I will reference them from the ALZ VBD.
inputs-devops.yaml.txt
inputs-github.yaml.txt

Additional context

Released in v0.4.1


Develop

Codecov Report

Merging #358 into develop will increase coverage by 0.02%.
The diff coverage is 85.71%.

@@             Coverage Diff             @@
##           develop     #358      +/-   ##
===========================================
+ Coverage    69.43%   69.45%   +0.02%
===========================================
  Files          214      214
  Lines        11685    11683       -2
===========================================
+ Hits          8113     8114       +1
+ Misses        3572     3569       -3

Impacted Files
Coverage Δ

framework/base/media/AVAFPacket.h
75.00% <ø> (ø)

framework/base/media/IAFPacket.h
100.00% <ø> (ø)

framework/cacheModule/CacheManager.cpp
67.07% <ø> (ø)

framework/cacheModule/CacheManager.h
100.00% <ø> (ø)

framework/cacheModule/CacheModule.cpp
64.40% <ø> (ø)

framework/cacheModule/cache/CacheFileRemuxer.cpp
76.11% <ø> (ø)

framework/cacheModule/cache/CacheFileRemuxer.h
100.00% <ø> (ø)

mediaPlayer/MediaPlayer.cpp
69.13% <ø> (ø)

mediaPlayer/MediaPlayer.h
100.00% <ø> (ø)

mediaPlayer/SuperMediaPlayer.cpp
74.10% <66.66%> (-0.37%)
:arrow_down:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd53dd3...d0f9d57. Read the comment docs.


kbfs_ops_concur_test: unskip test

KBFS-1261 was closed long ago and this test works now.

Oh strange, I thought it worked locally.  Welp, this will have to wait then.

Closing for archival. I'll open this in client to see if it's fixed.


modified Netbeast logo

I have modified the Netbeast logo in order to look better on the website.
Thank you!

:+1: