Load custom USD file

Hi,
thanks for great work!
We are following the work of ReKep, which was built based on the work omnigibson, and we would like to work on building our own simulation environment here as well.
Using the Robot Grasping Demo example（grasping_mode_example.py）, we added our object to the scene, as show bellow:
"""
Example script demo'ing robot manipulation control with grasping.
"""
import torch as th

import omnigibson as og
from omnigibson.macros import gm
from omnigibson.sensors import VisionSensor
from omnigibson.utils.ui_utils import KeyboardRobotController, choose_from_options

GRASPING_MODES = dict(
    sticky="Sticky Mitten - Objects are magnetized when they touch the fingers and a CLOSE command is given",
    assisted="Assisted Grasping - Objects are magnetized when they touch the fingers, are within the hand, and a CLOSE command is given",
    physical="Physical Grasping - No additional grasping assistance applied",
)

# Don't use GPU dynamics and Use flatcache for performance boost
gm.USE_GPU_DYNAMICS = False
gm.ENABLE_FLATCACHE = True

def main(random_selection=False, headless=False, short_exec=False):
    """
    Robot grasping mode demo with selection
    Queries the user to select a type of grasping mode
    """
    og.log.info(f"Demo {__file__}\n    " + "*" * 80 + "\n    Description:\n" + main.__doc__ + "*" * 80)

    # Choose type of grasping
    grasping_mode = choose_from_options(options=GRASPING_MODES, name="grasping mode", random_selection=random_selection)

    # Create environment configuration to use
    scene_cfg = dict(type="Scene")
    robot0_cfg = dict(
        type="Fetch",
        obs_modalities=["rgb"],  # we're just doing a grasping demo so we don't need all observation modalities
        action_type="continuous",
        action_normalize=True,
        grasping_mode=grasping_mode,
    )

    # Define objects to load
    table_cfg = dict(
        type="DatasetObject",
        name="table",
        category="breakfast_table",
        model="lcsizg",
        bounding_box=[0.5, 0.5, 0.8],
        fixed_base=True,
        position=[0.7, -0.1, 0.6],
        orientation=[0, 0, 0.707, 0.707],
    )

    chair_cfg = dict(
        type="DatasetObject",
        name="chair",
        category="straight_chair",
        model="amgwaw",
        bounding_box=None,
        fixed_base=False,
        position=[0.45, 0.65, 0.425],
        orientation=[0, 0, -0.9990215, -0.0442276],
    )

    box_cfg = dict(
        type="PrimitiveObject",
        name="box",
        primitive_type="Cube",
        rgba=[1.0, 0, 0, 1.0],
        size=0.05,
        position=[0.53, -0.1, 0.97],
    )
    # our object
    leg1_cfg = dict(
        type = "USDObject",
        name= "square_table_leg1",
        usd_path= f"/home/furniture-bench/furniture_bench/assets/furniture/mesh/square_table/square_table_leg1.usd",
        scale= 2.0,
        position = [0.59, -0.1, 0.97],
    )

    # Compile config
    cfg = dict(scene=scene_cfg, robots=[robot0_cfg], objects=[table_cfg, chair_cfg, box_cfg,leg1_cfg])

    # Create the environment
    env = og.Environment(configs=cfg)

    # Reset the robot
    robot = env.robots[0]
    robot.set_position_orientation(position=[0, 0, 0])
    robot.reset()
    robot.keep_still()

    # Make the robot's camera(s) high-res
    for sensor in robot.sensors.values():
        if isinstance(sensor, VisionSensor):
            sensor.image_height = 720
            sensor.image_width = 720

    # Update the simulator's viewer camera's pose so it points towards the robot
    og.sim.viewer_camera.set_position_orientation(
        position=th.tensor([-2.39951, 2.26469, 2.66227]),
        orientation=th.tensor([-0.23898481, 0.48475231, 0.75464013, -0.37204802]),
    )

    # Create teleop controller
    action_generator = KeyboardRobotController(robot=robot)

    # Print out relevant keyboard info if using keyboard teleop
    action_generator.print_keyboard_teleop_info()

    # Other helpful user info
    print("Running demo with grasping mode {}.".format(grasping_mode))
    print("Press ESC to quit")

    # Loop control until user quits
    max_steps = -1 if not short_exec else 100
    step = 0
    while step != max_steps:
        action = action_generator.get_random_action() if random_selection else action_generator.get_teleop_action()
        for _ in range(10):
            env.step(action)
            step += 1

    # Always shut down the environment cleanly at the end
    og.clear()

if __name__ == "__main__":
    main()

This is the code where we add the object:
 # our object
    leg1_cfg = dict(
        type = "USDObject",
        name= "square_table_leg1",
        usd_path= f"/home/furniture-bench/furniture_bench/assets/furniture/mesh/square_table/square_table_leg1.usd",
        scale= 2.0,
        position = [0.59, -0.1, 0.97],
    )

Then we load it in omnigibson, the object becomes transparent, but the effect can be seen in the UI by displaying the physical collision, as shown in the video below:
Uploading 2024年10月15日 屏幕视频 14时45分20秒.webm…
When I check the property, find that has changed to guide, so that only the collision lines are visible, not the meshes. as show the bellow image:

So, did omnigibson do something to the .usd file that caused the property to change?
What should I do to keep the original properties?
Desktop (please complete the following information):

OS:  Ubuntu 22.04
Isaac Sim Version 2023.
OmniGibson Version 1.0.0

Hope to get your reply and answer, thanks again.

The long story short here is that OmniGibson expects a particular hierarchy for its objects: you have an object prim (which is an xform prim and the default prim in the object USD file), under that you have an xform prim for each link (these are the prims that have the Rigid Body API attached to them), and under that prim you have a "visuals" prim that contains all the visual meshes, and a "collisions" prim that contains all the collision meshes (the stuff with the Collision API). Our code assumes that all prims are EITHER collision OR visual and NOT both like in your case. So this prim gets recognized as a collision prim and then gets hidden by setting the purpose. You can solve this by duplicating the prim, attaching one copy with the Collision API and not the other, and effectively they will be the collision and visual prims.
I will look into this later this week to provide users with a script that rearranges an arbitrary object into the appropriate hierarchy.

The long story short here is that OmniGibson expects a particular hierarchy for its objects: you have an object prim (which is an xform prim and the default prim in the object USD file), under that you have an xform prim for each link (these are the prims that have the Rigid Body API attached to them), and under that prim you have a "visuals" prim that contains all the visual meshes, and a "collisions" prim that contains all the collision meshes (the stuff with the Collision API). Our code assumes that all meshes are EITHER collision OR visual and NOT both like in your case. So this prim gets recognized as a collision prim and then gets hidden by setting the purpose. You can solve this by duplicating the prim, attaching one copy with the Collision API and not the other, and effectively they will be the collision and visual prims.
I will look into this later this week to provide users with a script that rearranges an arbitrary object into the appropriate hierarchy.

Thank you very much for your reply and explanation.
At the same time, I am looking forward to your public script so that everyone can freely convert custom USD and use it in OmniGibson.


too good 98% correct clustering results

Hi guys, thank you for this good framework.
I tried clustering output of VERI-Wild Baseline, and got 98% matches on test set (test_3000.txt) from Veri-wild dataset. This looks too perfect. Can it be that you used that test set for cross-validation so the model over-fitted on that data? That could explain that high score. What data for cross-validation did you use here ?

@JinkaiZheng Could you please answer this question?

您的邮件已收到！~

@kantengri Hi~ Thank you for your attention！
First, we only use 10-fold cross-validation on VehicleID dataset, because the VehicleID dose NOT provide official division documents about query and gallery. We random sample query and gallery in our implementation every inference time. In order to avoid randomness of the results, a trained model on VehicleID was tested 10 times and averaged, which is named "10-fold cross-validation".
Secend, we does NOT use the test set during training. And we use the official division documents about query and gallery on VERI-Wild, do NOT adopt "10-fold cross-validation" on VERI-Wild, which means we only tset one time to get the results.
Third, we got 96.4% (Rank-1) in MODEL_ZOO on small VERI-Wild test set (test_3000.txt). I think the result is high because the training set stays the same and the test set gets small. To take an extreme example, if your test set has only one ID, then when your first search result is correct, your result (Rank-1) is 100%. The larger the amount of data, the greater the uncontrollable factors, the poorer performance tends to be, and vice versa.
Fourth,  I can not understand what the "clustering" mean in your question. Could you please give me more details?

您的邮件已收到！~

您的邮件已收到！~


⚠ Samsung has degraded performance

In 561e7e0, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2127 ms

Resolved: Samsung performance has improved in aa3c69b.


Final method mocking does not work throgh proxy

After some debugging I found out the method is final but in the docs it says I can mock a final method with proxied partial mock. But it keeps annoying me with "should be called exactly 1 times but called 0 times" :cry:
Example:
<?php

require_once 'vendor/autoload.php';

class TestClass
{
        final public function testMethod($v)
        {
                return $v === 'foobar';
        }
}

$mock = Mockery::mock(new TestClass());
$mock->shouldReceive('testMethod')->with('foobar')->once();

$mock->testMethod('foobar');

Mockery::close();

But it keeps annoying me with "should be called exactly 1 times but called 0 times"

Isn't that ->once() doing its job?

Hm, this works if you mark the class final as well.
According to this test, final methods from non-final classes are removed: https://github.com/padraic/mockery/blob/63987b7de6ca423c27803e1f4a52bcfaa211667e/tests/Mockery/Generator/MockConfigurationTest.php#L90-L97

And looks like this test is bad https://github.com/padraic/mockery/blob/master/tests/Mockery/ContainerTest.php#L297-L304
It has an expectation that the mocked foo method will return 'bar', but it actually returns the 'bar' from the actual method https://github.com/padraic/mockery/blob/master/tests/Mockery/ContainerTest.php#L1456-L1459

And this test gets it correctly: https://github.com/padraic/mockery/blob/63987b7de6ca423c27803e1f4a52bcfaa211667e/tests/Mockery/ContainerTest.php#L315-L321

Possibly related #605

After investigating #605 a bit more in detail, this is by design. Any and all tests I mentioned before are indeed correct.
The documentation needs updating saying that final methods can't be mocked/proxied/whatever, and that the actual final method will be used always.

There's #843 now that hopefully makes the documentation more clear for this.

#843 got merged, so closing this now.


Can it be compatible with more numpy and scipy versions?

Solution to issue cannot be found in the documentation.

[X] I checked the documentation.

Issue
Hi, dear maintainers.
sktime is a fairly good project to deal with time series problems. It is used in my project HyperTS, and an error is reported in the process of publishing my package to CONDA forge by executing command pip check:
sktime 0.10.1 has requirement numpy<1.22,>=1.21.0, but you have numpy 1.22.3.
sktime 0.10.1 has requirement scipy<1.8.0, but you have scipy 1.8.0.

I noticed that sktime==0.10.1 limited the upper bound of numpy and scipy:
https://github.com/alan-turing-institute/sktime/blob/b6c7153b4b0fbe601ab2308c53a408f07bc435b2/pyproject.toml#L48-L52
This may conflict with other packages, I used command pip-compile to check the dependencies of my project as follows:
...
scipy==1.7.3
    # via
    #   featuretools
    #   hypernets
    #   lightgbm
    #   scikit-learn
    #   seaborn
    #   sktime
    #   statsmodels
numpy==1.22.3
    # via
    #   -r ./requirements.txt
    #   cmdstanpy
    #   dask
    #   featuretools
    #   hypernets
    #   lightgbm
    #   matplotlib
    #   numba
    #   pandas
    #   patsy
    #   prophet
    #   pyarrow
    #   pystan
    #   scikit-learn
    #   scipy
    #   seaborn
    #   sktime
    #   statsmodels
...

It shows that many packages depend on numpy and scipy, can it be compatible with more numpy and scipy versions to  better coexist with other packages?  Or is there any special reason to use numpy<1.23 and scipy<1.8 ? I mean, removing the upper bound of the version makes the dependency look like:
numpy>=1.21.0
scipy>x.x.x

Is this feasible? Look forward to your reply
Ref:

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=474860&view=logs&j=6f142865-96c3-535c-b7ea-873d86b887bd&t=22b0682d-ab9e-55d7-9c79-49f3c3ba4823
https://github.com/conda-forge/staged-recipes/pull/18275

Installed packages
_libgcc_mutex:                 0.1-conda_forge              conda-forge
    _openmp_mutex:                 4.5-1_gnu                    conda-forge
    abseil-cpp:                    20210324.2-h9c3ff4c_0        conda-forge
    arrow-cpp:                     7.0.0-py39h6409b3a_2_cpu     conda-forge
    arviz:                         0.11.4-pyhd8ed1ab_0          conda-forge
    asttokens:                     2.0.5-pyhd8ed1ab_0           conda-forge
    attrs:                         21.4.0-pyhd8ed1ab_0          conda-forge
    aws-c-cal:                     0.5.11-h95a6274_0            conda-forge
    aws-c-common:                  0.6.2-h7f98852_0             conda-forge
    aws-c-event-stream:            0.2.7-h3541f99_13            conda-forge
    aws-c-io:                      0.10.5-hfb6a706_0            conda-forge
    aws-checksums:                 0.1.11-ha31a3da_7            conda-forge
    aws-sdk-cpp:                   1.8.186-hb4091e7_3           conda-forge
    backcall:                      0.2.0-pyh9f0ad1d_0           conda-forge
    backports:                     1.0-py_2                     conda-forge
    backports.functools_lru_cache: 1.6.4-pyhd8ed1ab_0           conda-forge
    bcrypt:                        3.2.0-py39h3811e60_2         conda-forge
    binutils_impl_linux-64:        2.36.1-h193b22a_2            conda-forge
    binutils_linux-64:             2.36-hf3e587d_7              conda-forge
    bokeh:                         2.4.2-py39hf3d152e_0         conda-forge
    brotli:                        1.0.9-h7f98852_6             conda-forge
    brotli-bin:                    1.0.9-h7f98852_6             conda-forge
    brotlipy:                      0.7.0-py39h3811e60_1003      conda-forge
    bzip2:                         1.0.8-h7f98852_4             conda-forge
    c-ares:                        1.18.1-h7f98852_0            conda-forge
    ca-certificates:               2021.10.8-ha878542_0         conda-forge
    certifi:                       2021.10.8-py39hf3d152e_1     conda-forge
    cffi:                          1.15.0-py39h4bc2ebd_0        conda-forge

Environment info
conda-build version : 3.21.8
         python version : 3.9.10.final.0
       virtual packages : __linux=5.11.0=0
                          __glibc=2.17=0
                          __unix=0=0
                          __archspec=1=x86_64
       base environment : /opt/conda  (writable)
      conda av data dir : /opt/conda/etc/conda
  conda av metadata url : None
           channel URLs : https://conda.anaconda.org/conda-forge/linux-64
                          https://conda.anaconda.org/conda-forge/noarch
          package cache : /opt/conda/pkgs
                          /home/conda/.conda/pkgs
       envs directories : /opt/conda/envs
                          /home/conda/.conda/envs
               platform : linux-64
             user-agent : conda/4.11.0 requests/2.27.1 CPython/3.9.10 Linux/5.11.0-1028-azure centos/7.9.2009 glibc/2.17
                UID:GID : 1001:1001
             netrc file : None
           offline mode : False

Thanks for letting us know about it @oaksharks! We are trying to be compatible with the widest range of dependencies that we can but we discovered incompatibilities like this one where we need to restrict the version to prevent braking changes. We are working on those issues so in the near future we should be able to bump the dependencies. I cannot unfortunately promise any dates.
It would help us if you could explain where specifically this is a problem for you and how critical is not having the specific version of packages available? How are you solving the problem now?

Thank you for your reply! I reproduce the issue about numpy through the command:
conda create -n sktime python=3.8 -y
conda activate sktime
mamba install -c conda-forge "sktime>=0.8.1"  "scikit-learn>=0.22.1" -y

part of outputs as following：
...
statsmodels-0.13.2   | 11.5 MB   | ################################################################################################################### | 100%
pandas-1.4.2         | 12.6 MB   | ################################################################################################################### | 100%
pyparsing-3.0.8      | 79 KB     | ################################################################################################################### | 100%
libffi-3.4.2         | 57 KB     | ################################################################################################################### | 100%
Preparing transaction: done
Verifying transaction: done
Executing transaction: done
sktime 0.11.2 has requirement numpy<1.22,>=1.21.0, but you have numpy 1.22.3.

Packages installed:
❯ conda list                                                                                [5/922]
# packages in environment at /mnt/miniconda3/envs/sktime:
#
# Name                    Version                   Build  Channel
_libgcc_mutex             0.1                 conda_forge    conda-forge
_openmp_mutex             4.5                       1_gnu    conda-forge
ca-certificates           2022.3.29            h06a4308_0    defaults
certifi                   2021.10.8        py38h06a4308_2    defaults
deprecated                1.2.13             pyh6c4a22f_0    conda-forge
joblib                    1.1.0              pyhd8ed1ab_0    conda-forge
ld_impl_linux-64          2.35.1               h7274673_9    defaults
libblas                   3.9.0           14_linux64_openblas    conda-forge
libcblas                  3.9.0           14_linux64_openblas    conda-forge
libffi                    3.4.2                h7f98852_5    conda-forge
libgcc-ng                 11.2.0              h1d223b6_15    conda-forge
libgfortran-ng            11.2.0              h69a702a_15    conda-forge
libgfortran5              11.2.0              h5c6108e_15    conda-forge
libgomp                   11.2.0              h1d223b6_15    conda-forge
liblapack                 3.9.0           14_linux64_openblas    conda-forge
libllvm10                 10.0.1               he513fc3_3    conda-forge
libnsl                    2.0.0                h7f98852_0    conda-forge
libopenblas               0.3.20          pthreads_h78a6416_0    conda-forge
libstdcxx-ng              11.2.0              he4da1e4_15    conda-forge
libzlib                   1.2.11            h166bdaf_1014    conda-forge
llvmlite                  0.36.0           py38h4630a5e_0    conda-forge
ncurses                   6.3                  h7f8727e_2    defaults
numba                     0.53.1           py38h8b71fd7_1    conda-forge
numpy                     1.22.3           py38h1d589f8_2    conda-forge
openssl                   3.0.2                h166bdaf_1    conda-forge
packaging                 21.3               pyhd8ed1ab_0    conda-forge
pandas                    1.4.2            py38h47df419_1    conda-forge
patsy                     0.5.2              pyhd8ed1ab_0    conda-forge
pip                       21.2.4           py38h06a4308_0    defaults
pyparsing                 3.0.8              pyhd8ed1ab_0    conda-forge
python                    3.8.12          h0744224_3_cpython    conda-forge
python-dateutil           2.8.2              pyhd8ed1ab_0    conda-forge
python_abi                3.8                      2_cp38    conda-forge
pytz                      2022.1             pyhd8ed1ab_0    conda-forge
readline                  8.1.2                h7f8727e_1    defaults
scikit-learn              1.0.2            py38h1561384_0    conda-forge
scipy                     1.7.3            py38h56a6a73_0    conda-forge
setuptools                61.2.0           py38h06a4308_0    defaults
six                       1.16.0             pyh6c4a22f_0    conda-forge
sktime                    0.11.2           py38hfa26641_0    conda-forge
sqlite                    3.38.2               hc218d9a_0    defaults
statsmodels               0.13.2           py38h6c62de6_0    conda-forge
threadpoolctl             3.1.0              pyh8a188c0_0    conda-forge
tk                        8.6.11               h1ccaba5_0    defaults
wheel                     0.37.1             pyhd3eb1b0_0    defaults
wrapt                     1.14.0           py38h0a891b7_1    conda-forge
xz                        5.2.5                h7b6447c_0    defaults
zlib                      1.2.11            h166bdaf_1014    conda-forge

Use pip to check dependencies ：
❯ pip check
sktime 0.11.2 has requirement numpy<1.22,>=1.21.0, but you have numpy 1.22.3.

In order to avoid the incompatibility of pip check , I specify the version of numpy during installation:
mamba install -c conda-forge "sktime>=0.8.1"  "scikit-learn>=0.22.1" "numpy<1.22,>=1.21.0" -y

scipy compatibility is now raised, see
https://github.com/alan-turing-institute/sktime/issues/1994


get_physical_device_features is not exposed

it appears that get_physical_device_features is not safely exposed anywhere, and in order to use it, caller must call instance.fp_v1_0().get_physical_device_features(dev, &mut features); in an unsafe block.
But this is not really right anyway, as this function is a "free" function, it does not require the instance to be passed in.

A few functions are still missing, I'll add it after the 18th.

Added with https://github.com/MaikKlein/ash/commit/e4e31ec9ac3ea481ea523bf1a4fbfcd77c56d523


Problem combining examples onepage with accounts

Noobie here. Loving MK, but I can't seem to combine your onepage example with a separate page with admin access. Getting a "component must have type" error.

@lancefb the easiest way would be to copy complete "components" array from example-onepage "home" page into example-admin "home_public".
The error message you mentioned tells you that  some object insite some components array doesnt have a type property asigned. So it looks like you copied something into wrong place.
feel free to share your input json here, so I can tell you more.

It worked! Thanks! Now onto more good stuff ...


Pr mapgeneration

This PR includes bug fixes for generating hilbertmaps
The hilbertmap is now being successfully generated from the pointclouds provided by the sample pointcloud infomration from the hilbert_mappublisher


No executable available after installation

Hi!
If one is strictly following the installation procedure with the command
sudo npm install -g mqtt-scripts

then afterwards there is no executable to call in the PATH.
However, it is working for other node scripts after installing them globally.
Any idea what's wrong?
pi@rpi3-knx:/home $ lsb_release -a
No LSB modules are available.
Distributor ID: Raspbian
Description:    Raspbian GNU/Linux 9.4 (stretch)
Release:        9.4
Codename:       stretch
pi@rpi3-knx:/home $ node -v
v8.11.3
pi@rpi3-knx:/home $ npm -v
6.3.0

Oh, oops ;-) I forgot to set the bin property in package.json. Will fix that asap. Meanwhile you could create the link manually: ln -s /usr/local/lib/node_modules/mqtt-scripts/index.js /usr/local/bin/mqtt-scripts


Reflect.. killing me?

Describe the bug
I was under the impression that reflect hurts the attacking enemy, but it seems to be hitting me.  The damage returned is divine as well.
To Reproduce
Steps to reproduce the behavior:
I have celestial realm, and reflect.
Expected behavior
Anybody damaging me to take that damage back to their face.
Screenshots

Additional context
As far as I know none of these babaus actually hit me, so I'm reflecting my own divine damage back to myself?  Maybe? Idk

I can add a check that would exclude the reflect owner. I haven't really thought about situations like these when I first made this ability.


ENH: Drill HTTP Load Generator

Thx for the review. Documentation and (basic) validation for the benchmark is coming.
I second the refactor idea, but I'll create a dedicated issue about that.


[AJ-1469] Organize tests

Split from #4521.
A little pre-factoring for AJ-1469.

End to end test failure is irrelevant since this only changes unit tests.


not able to run the project locally on my machine

after cloning the repositary in my machine when i run the command  make deps it gives error and that is make: *** No rule to make target deps'.  Stop.` when i try to open the files manually nothing loads please help

You must have all packages installed!
If you are on Win, open PowerShell as ADM and paste this command to install wsl:
command: wsl --install
doc: https://docs.microsoft.com/en-us/windows/wsl/install
Enter a password and login, restart your computer.
Type wsl to open the terminal on your Win, go to the blockly-games directory and type the commands:
sudo apt update
sudo apt-get install subversion
sudo apt-get install sed
sudo apt-get install wget
sudo apt-get install make
sudo apt install default-jre
sudo apt install default-jdk
sudo apt-get install software-properties-common
sudo apt-get install python3
And finally type the make command in the root of your project (blockly-games) where the MakeFile is and watch the magic happen, hehe.

I did this document to help ! 💕 (https://gist.github.com/JEZIGA01/dbaedc0fae4b7cde6bddf9b3c5412fe8)

I leave a comment in your gist. please check it out. appreciate it!

I did this document to help ! 💕
(https://gist.github.com/JEZIGA01/dbaedc0fae4b7cde6bddf9b3c5412fe8)
My video step by step : https://youtu.be/uJ9Jz6CeiyE

@sarangkkl I did this document to help ! 💕 (https://gist.github.com/JEZIGA01/dbaedc0fae4b7cde6bddf9b3c5412fe8) My video step by step : https://youtu.be/uJ9Jz6CeiyE

Hello, Jeziga, I can make this project the first time. But it is not really stable to use the make instruction. Is there any solutions? Here is the error information.


Implement CC Release Notes script / process

Up until now, CockroachCloud Release Notes have been a manual process. This can be automated similarly to how we generate release notes for CockroachDB.
For every PR in CRDB, a release note must be included (or, alternatively, "release note: none"). The guidelines for writing release notes are outlined here, which we would adapt for CC release notes, as CC release notes only need to highlight feature changes and bug fixes that are user-facing.
The script that can be adapted for CC is here: https://github.com/cockroachdb/cockroach/blob/master/scripts/release-notes.py
I think a decent amount of the script can be trimmed for CC (e.g., we don't need authors, links to PRs, not sure if we need to delineate between different product areas yet).

Some in progress thoughts:
If the changes are behind a feature flag, we could put the flag name in the commit message. Maybe something like:
release note: blah

feature flag name: BlahEnabled

Production flags can only be flipped by SREs, so we have a record of which feature flags have been flipped in the SREOPS project. It would be straight forward to setup a filter for the last month of SREOPS tickets of type Feature Flag.

Some in progress thoughts:
If the changes are behind a feature flag, we could put the flag name in the commit message. Maybe something like:
release note: blah

feature flag name: BlahEnabled

Production flags can only be flipped by SREs, so we have a record of which feature flags have been flipped in the SREOPS project. It would be straight forward to setup a filter for the last month of SREOPS tickets of type Feature Flag.

Since @gaoxk merged the changes to the githooks, I've adapted our release notes writing guidance for CockroachCloud contributors: https://cockroachlabs.atlassian.net/wiki/x/ZIJ5VQ
@gaoxk (and probably @petermattis and/or @laurenbarker) can you review the wiki page above? Feel free to leave comments if something needs more explanation, is wrong, etc.
The next step in this is to write the script that will scrape for all of the commit messages, right? Kristy, are you working on that as well or is someone else?

@lnhsingh The release notes writing guidance looks good to me! I would mention that when generating release notes, release notes flagged with a feature will not be included, unless the person generating the notes indicates that the feature is ready.
I am currently working on the script here. I'll @ you on the PR when it's ready for review!

@lnhsingh pr is up! here's a comment describing the script's main usage, let me know what you think!

Closing - will open a new issue if anything needs to be adjusted.


fixed reference to wrong weather API in options

Description
Fixed a reference to the wrong weather API in options
Copilot

🤖 Generated by Copilot at 910a5d3
Summary
:recycle::cloud::key:

Switched weather data source for tempgraph app from OpenWeathermap to WeatherAPI.com. Updated api_key schema field in apps/tempgraph/tempgraph.star to match the new service.

api_key changes
WeatherAPI.com is new
Autumn wind blows cold

Walkthrough

Switch weather data source from OpenWeathermap to WeatherAPI.com for the tempgraph app (link,

Did some things wrong creating the pull request; going to clean it up and re-request


Release JGroups avoiding stagig repo

Hey @belaban !
Recently I've been looking at different ways to release without staging repo. Luckily, this problem has been solved by Hawkular project [1].
Maybe it's worth trying this approach before customizing repositories at JBoss Nexus?
Thanks
Sebastian
[1] https://issues.jboss.org/browse/HAWKULAR-199 and implementation [2][3]
[2] https://github.com/hawkular/hawkular-build-tools/commit/b48133af85de156f3f7e14a68cab48704d81cb16
[3] https://github.com/hawkular/hawkular-build-tools/commit/bfe907f31ed4c4afbe9a6745303d48feda2a60f9

Hi @slaskawi, I applied the PR. Do I invoke it using mvn deploy ? That doesn't work, e.g.
mvn -Dmaven.test.skip=true deploy
...
main:
[INFO] Executed tasks
[INFO]
[INFO] --- maven-bundle-plugin:2.3.7:bundle (default-bundle) @ jgroups ---
[WARNING] Bundle org.jgroups:jgroups:bundle:3.6.4 : Instructions in Export-Package that are never used: schema
Classpath: Jar:.,Jar:log4j-core,Jar:log4j-api,Jar:tools

[WARNING] Bundle org.jgroups:jgroups:bundle:3.6.4 : Superfluous export-package instructions: [schema]
[WARNING] Bundle org.jgroups:jgroups:bundle:3.6.4 : Invalid value for Bundle-RequiredExecutionEnvironment, J2SE-1.6 does not match CDC-1\.0/Foundation-1\.0|CDC-1\.1/Foundation-1\.1|OSGi/Minimum-1\.[1-9]|JRE-1\.1|J2SE-1\.2|J2SE-1\.3|J2SE-1\.4|J2SE-1\.5|JavaSE-1\.6|JavaSE-1\.7|PersonalJava-1\.1|PersonalJava-1\.2|CDC-1\.0/PersonalBasis-1\.0|CDC-1\.0/PersonalJava-1\.0
[INFO]
[INFO] --- maven-source-plugin:2.2.1:jar-no-fork (attach-sources) @ jgroups ---
[INFO] Building jar: /Users/bela/JGroups/target/jgroups-3.6.4-sources.jar
[INFO]
[INFO] --- maven-install-plugin:2.4:install (default-install) @ jgroups ---
[INFO] Installing /Users/bela/JGroups/target/jgroups-3.6.4.jar to /home/bela/.m2/jboss-repository/org/jgroups/jgroups/3.6.4/jgroups-3.6.4.jar
[INFO] Installing /Users/bela/JGroups/pom.xml to /home/bela/.m2/jboss-repository/org/jgroups/jgroups/3.6.4/jgroups-3.6.4.pom
[INFO] Installing /Users/bela/JGroups/target/jgroups-3.6.4-sources.jar to /home/bela/.m2/jboss-repository/org/jgroups/jgroups/3.6.4/jgroups-3.6.4-sources.jar
[INFO]
[INFO] --- maven-bundle-plugin:2.3.7:install (default-install) @ jgroups ---
[INFO] Installing org/jgroups/jgroups/3.6.4/jgroups-3.6.4.jar
[INFO] Writing OBR metadata
[INFO]
[INFO] --- maven-bundle-plugin:2.3.7:deploy (default-deploy) @ jgroups ---
[INFO] Remote OBR update disabled (enable with -DremoteOBR)
[INFO]
[INFO] --- nexus-staging-maven-plugin:1.6.5:deploy (injected-nexus-deploy) @ jgroups ---
[INFO] Performing local staging (local stagingDirectory="/Users/bela/JGroups/target/nexus-staging/staging")...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15.335 s
[INFO] Finished at: 2015-06-15T16:06:53+01:00
[INFO] Final Memory: 38M/635M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.sonatype.plugins:nexus-staging-maven-plugin:1.6.5:deploy (injected-nexus-deploy) on project jgroups: Execution injected-nexus-deploy of goal org.sonatype.plugins:nexus-staging-maven-plugin:1.6.5:deploy failed: Mandatory plugin parameter 'nexusUrl' should be your Nexus base URL only - for example http://localhost:8081/nexus -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
[mac] /Users/bela/JGroups$

Also, this is similar to bin/release_to_nexus.sh. With this, do I still have to open the Nexus GUI to release ?

The command below works, but I cannot find the uploaded artifact anywhere...
mvn deploy -Dmaven.test.skip=true  -DnexusUrl=https://repository.jboss.org/nexus/service/local/staging/deploy/maven2/ -DserverId=jboss-releases-repository -DskipLocalStaging=true

Only this is needed
mvn deploy -Dmaven.test.skip=true -DskipLocalStaging=true

Hey @belaban !
Actually it should work even without -DskipLocalStaging=true. You should be able to publish the artifacts using mvn deploy -Dmaven.test.skip=true.

I'm working on getting this to work in ant&ivy


Add support to other executables

Currently it only supports 1.0 US, add support to other versions of gta_sa.exe

I'm probably not doing this is in a near future.
If anyone's interested and have some basic reverse engineering knowledge, you just need to add a new hpp into src/translator/gta3/sa and add it accordingly in translator.cpp.
Additionally make sure the src/plugins/gta3/std.stream/asm/ files are compatible with the version (probably it is, but make sure).

Not happening. The 1.0 executables are the de-facto modding standards and the effort to do and maintain support to other executables (specially living ones like Steam and RGL) isn't worth it.


The SVLEN and -m flag have somewhat unexpected behavior when REF and ALT are both long

Version :
Truvari v4.0.0
Describe the bug :
The command truvari anno svinfo does not work with the -m flag in the way expected. In particular, truvari anno svinfo -m does not take into account the relative difference in sizes between the REF and ALT sequences. In particular, if your SV caller outputs long sequences for both (which I've seen a few times), you may end up including events whose size should be below the -m value get included anyway. This is probably due to the SVLEN attribute getting computed improperly in this case as well.
To Reproduce :
Here's an example variant I ran truvari anno svinfo -m 50 on:
chr1    811390  .       AATACAATGTTCTCCAGAAATAGTGTCGCAGAAATAAAGACAGAATATGGAAGGAGACAGGATTGCTGACTAATCTCATATGTACAGGGAGAACGACACTCCATGCAGCTTAGCTCCAACATGTGAGCGTGGGACAGAAAAGCAAGGTGAACCTAAAGACATCCCATGGACACACTGAGCTGGAACCAACTCTGCCCATAGGTGGTGGGGCCAGGTTCAGATGCTTGCAGTAACCGCATCCTCCTGTGAATCTGGGTCTACATGGCTGTGGCTCCCTGGGGGCTACCCACACTGTGGATTCCACAGGTGGAGGTGACCTTCTTGGGCACTGCTGGGACACTTCCTGGGCCTGCCTGGGCAGTGGTAGGGCTCAGAGAACTTCAGCGTTAGGGCCTTGGGGAGTCTATGTCAGACTTGAGGAC        AATACAATGTTCTCCAGAAATAGTGTCGCAGAAATAAAGACAGAATATGGAAGGAGACAGGATTGCTGACTAATCTCATATGTACAGGGAGAACGACACTCCATGCAGCTTAGCTCCAACATGTGAGTGTGGGACAGAAAAGCAAGGTGAACCTAAAGACATCCCATGGACACACTGAGCTGGAACCAACTCTGCCCATAGGTGGTGGGGCCAGGTTCAGATGCTTGCAGTAACCGCATCCTCCTGTGAATCTGGGTCTACATGGCTGTGGCTCCCTGGGGGCTACCCACACTGTGGATTCCACAGGTGGAGGTGACCTTCTTGGGCACTGCTGGGACACTTCTTGGGCCTGCCTGGGCAGTGGTAGGGCTCAGAGAACTTCAGCGTTAGGGCCTTGGGGAGTCTATGTCAGACTTGAGGAC        .       .       RAF=0.0322581;AF=0;INFO=1;BUF=0 GT:DS:GP:HS     0/0:0:1,0,0:0

The result is:
chr1    811390  .       AATACAATGTTCTCCAGAAATAGTGTCGCAGAAATAAAGACAGAATATGGAAGGAGACAGGATTGCTGACTAATCTCATATGTACAGGGAGAACGACACTCCATGCAGCTTAGCTCCAACATGTGAGCGTGGGACAGAAAAGCAAGGTGAACCTAAAGACATCCCATGGACACACTGAGCTGGAACCAACTCTGCCCATAGGTGGTGGGGCCAGGTTCAGATGCTTGCAGTAACCGCATCCTCCTGTGAATCTGGGTCTACATGGCTGTGGCTCCCTGGGGGCTACCCACACTGTGGATTCCACAGGTGGAGGTGACCTTCTTGGGCACTGCTGGGACACTTCCTGGGCCTGCCTGGGCAGTGGTAGGGCTCAGAGAACTTCAGCGTTAGGGCCTTGGGGAGTCTATGTCAGACTTGAGGAC        AATACAATGTTCTCCAGAAATAGTGTCGCAGAAATAAAGACAGAATATGGAAGGAGACAGGATTGCTGACTAATCTCATATGTACAGGGAGAACGACACTCCATGCAGCTTAGCTCCAACATGTGAGTGTGGGACAGAAAAGCAAGGTGAACCTAAAGACATCCCATGGACACACTGAGCTGGAACCAACTCTGCCCATAGGTGGTGGGGCCAGGTTCAGATGCTTGCAGTAACCGCATCCTCCTGTGAATCTGGGTCTACATGGCTGTGGCTCCCTGGGGGCTACCCACACTGTGGATTCCACAGGTGGAGGTGACCTTCTTGGGCACTGCTGGGACACTTCTTGGGCCTGCCTGGGCAGTGGTAGGGCTCAGAGAACTTCAGCGTTAGGGCCTTGGGGAGTCTATGTCAGACTTGAGGAC        .       .       RAF=0.0322581;AF=0;INFO=1;BUF=0;SVTYPE=UNK;SVLEN=422          GT:DS:GP:HS     0/0:0:1,0,0:0

Note that SVLEN ends up being the length of (both) sequences, even though the difference in length is 0.
Expected behavior :
The sequences themselves only differ by 2 SNPs, so it's unclear what the desired behavior should be. I thought this sort of site would've been filtered out when using -m 50.
Additional context :
This might be a bit niche, but I've seen outputs like the above in a few different cases, where SNPs end up hiding in very long sequences. It might be worth considering if you want to compute SVLEN instead using something like the difference between the REF and ALT length.

Hello,
SVLEN calculation can get weird. And while I do believe there are cases where anno svinfo may not annotate correctly, I'm unsure if this is one of them. Looking at the vcf4.4 spec (link), the main definition of SVLEN is:
##INFO=<ID=SVLEN,Number=A,Type=Integer,Description="Length of structural variant">
One value for each ALT allele.
SVLEN must be specified for symbolic structural variant alleles. SVLEN is defined for INS, DUP, INV, and DEL symbolic alleles as the number of the inserted, duplicated, inverted, and deleted bases respectively. SVLEN is defined for CNV symbolic alleles as the length of the segment over which the copy number variant is defined. The missing value . should be used for all other ALT alleles, including ALT alleles using breakend notation.
For backwards compatibility, a missing SVLEN should be inferred from the END field of VCF records whose ALT field contains a single symbolic allele.
For backwards compatibility, the absolute value of SVLEN should be taken and a negative SVLEN should be treated as positive values.
Note that for structural variant symbolic alleles, P OS corresponds to the base immediately preceding the variant.

Which could(?) be interpreted as SVLEN should only be available for symbolic ALTs. However your example VCF line has a sequence resolved call. There's also this interesting - though possibly not-relevant - description of rlen in the bcf2 section which says:
rlen -> int32.t -> Length of the record as projected onto the reference sequence. Must be the maximum of the length of the REF allele and the lengths inferred from the SVLEN/END of any symbolic alleles

You can see the full description of how truvari calculates svlen here.
One thought experiment that makes it tricky to know exactly how to handle this situation of SNPs in a span (which I like to think of unofficially as replacement or 'REPL' types) is to consider sequence resolved inversions. If an inversion is a perfect flip of a reference span, we'd probably want to set SVLEN to the reference span. Therefore, for truvari to understand if its looking at an inversion vs a 'REPL', it's need to incorporate reverse-compliment REF to ALT similarity and essentially become a sequence annotator. Also, the anno svinfo attempts to add the INFO/SVTYPE field,  and is very simplistic (docs). However, I believe SVTYPE is being 'deprecated' from the VCF format specification - which I don't understand.
To sum all of that up - I understand your logic for wanting to consider the example site as a 0-length "REPL" type. But I don't believe there's a way to handle it that way that without having the anno svinfo tool become more complicated in a way that may not conform to the ever-changing VCF specs.
And, just to make sure, you say "I thought this sort of site would've been filtered out..". But the anno svinfo won't do any filtering. It just adds INFO fields.
Have a great day,
~/Adam English

Thanks for your response and clarification!


[REQ] Adding more machine translation alternatives

Is your feature request related to a problem? Please describe.
Machine translation for many low-resource languages is not possible with existing engines, as they do not support machine translation. However, adding these engines would allow people to use translation in their own languages.
Describe the solution you'd like
Adding these machine translation alternatives will increase the number of languages supported for machine translation up to 200, including low-resource languages such as Santali and Luganda etc. These online hosted machine translation service providers use NLLB (both Glosbe and MinT) and MarianNMT (only Glosbe) models.
Add more machine translation alternatives:

https://translate.glosbe.com (Glosbe Translate hosted by Glosbe)
https://translate.wmcloud.org/ (MinT Machine translation hosted by Wikimedia Foundation) - API spec (https://translate.wmcloud.org/api/spec)
Mymemory Translator, Api Usage (Uses millions of TM).
https://www.modernmt.com/translate/ (ModernMT translate).

Thanks for the suggestion this is very useful, i'll be sure to try adding it once i get back to the project

And more suggestions :)
https://bing.com/translator (aka. Microsoft translator)
https://translate.yandex.com/
https://fanyi.youdao.com/index.html#/ (chinese site)
https://fanyi.baidu.com/ (another chinese site)


about the demo.py

when I run the demo, it put the problems as follows:
WARNING [03/19 18:46:45 d2.config.compat]: Config 'configs/CenterNet2_R2-101-DCN-BiFPN_4x+4x_1560_ST.yaml' has no VERSION. Assuming it to be compatible with latest v2.
and:
AssertionError: Checkpoint output/r2_101.pkl not found!
I am a beginer, and actually don't know what's that mean, so can you tell me how to solve it?
oh now I know where to download r2_101.pkl, but I don't the root path to set it, The root directory of the file ？

when I run the demo, it put the problems as follows:
WARNING [03/19 18:46:45 d2.config.compat]: Config 'configs/CenterNet2_R2-101-DCN-BiFPN_4x+4x_1560_ST.yaml' has no VERSION. Assuming it to be compatible with latest v2.
and:
AssertionError: Checkpoint output/r2_101.pkl not found!
I am a beginer, and actually don't know what's that mean, so can you tell me how to solve it?
oh now I know where to download r2_101.pkl, but I don't the root path to set it, The root directory of the file ？

when I run the demo, it put the problems as follows:
WARNING [03/19 18:46:45 d2.config.compat]: Config 'configs/CenterNet2_R2-101-DCN-BiFPN_4x+4x_1560_ST.yaml' has no VERSION. Assuming it to be compatible with latest v2.
and:
AssertionError: Checkpoint output/r2_101.pkl not found!
I am a beginer, and actually don't know what's that mean, so can you tell me how to solve it?
oh now I know where to download r2_101.pkl, but I don't the root path to set it, The root directory of the file ？

when I run the demo, it put the problems as follows:
WARNING [03/19 18:46:45 d2.config.compat]: Config 'configs/CenterNet2_R2-101-DCN-BiFPN_4x+4x_1560_ST.yaml' has no VERSION. Assuming it to be compatible with latest v2.
and:
AssertionError: Checkpoint output/r2_101.pkl not found!
I am a beginer, and actually don't know what's that mean, so can you tell me how to solve it?
oh now I know where to download r2_101.pkl, but I don't the root path to set it, The root directory of the file ？

when I run the demo, it put the problems as follows:
WARNING [03/19 18:46:45 d2.config.compat]: Config 'configs/CenterNet2_R2-101-DCN-BiFPN_4x+4x_1560_ST.yaml' has no VERSION. Assuming it to be compatible with latest v2.
and:
AssertionError: Checkpoint output/r2_101.pkl not found!
I am a beginer, and actually don't know what's that mean, so can you tell me how to solve it?
oh now I know where to download r2_101.pkl, but I don't the root path to set it, The root directory of the file ？

@weiddyaqhhya  did you solve this problem?


fibonacci series without recursion

changed the code of fibonacci sequence in java, without using recursion.
What type of PR is this? (check all applicable)

[x] 🚀 Added Name
[ /] ✨ Feature
[ ] 🌟 stared the repo
[ ] 🐛 Grammatical Error
[ ] 📝 Documentation Update
[ ] 🚩 Other

Description
Add Link of GitHub Profile

@kaivalya98 please review my PR.


Async Daemon & Multi-Tenancy

Async Daemon & Multi-Tenancy - is this scenario currently supported?
It looks like when async demon applies projections it uses the DEFAULT tenant. As a result ViewProjection results are stored under the DEFAULT tenant. Or if I implement IProjection manually - I also get session bound to the DEFAULT tenant and have to remember to explicitly specify tenantid everywhere or create a new tenant specific session but in this case it is not clear how to manage it in terms of transactions\unit of work

Replaced by #1609


Importing a GPX should create two layers on the same map to show lines

One with the points and one below with a line connecting the points (with a wrapped query applied) so we make easy as hell importing and visualizing GPX's.
cc/ @kartones @javisantana so they can also take a look to the fact of needing a wrapped query on that layer.

The tech approach:

first of all we need to finish write refactor for Map and Layers
add needed api to layers to work with "frontend things", like wizards and wrapped queries (also needed for this #4627)
add a post import step that depends on file type. Here we can place the GPX code, but also the shp (to show all the layers in the same map) and all the things we want to do with wizards

So then https://github.com/CartoDB/cartodb/issues/4489 is a duplicate? or at least a blocker for this, because before doing any wizard/layer hiding stuff we first need to support importing N layers into just one vis with N tables as layers (currently not supported by the importer).
Careful as this implies a lot, I'd first attack #4489, then see how to add support of "import as layers of same Map", then this specifics. Not counting what @javisantana mentioned

For me it's no "import as layers of same Map" but import different tables from the same datasource and after that create the map for this datasource (with 1 or more tables)

yep, +1 on @javisantana 's comment

Also think this is the first of many. KMLs could create linestrings too, zips with multiple datasets could create a single map when finished, etc... This is veeeery related with pecan, yep

So this should be put on hold?

I'd propose a general solution for these cases

Related #5096 , #5024 , #1113

Also related with #4556

+1 to what @javisantana proposes

There has been no activity on this issue for more several months. We are closing it. If you think this still needs to be addressed please open a new issue.


crystal equipment counter overlay

this feature is a counter overlay displaying remaining charges for all crystal equipment. this is meant to be visually similar to the rune pouch or teleport jewelry.

+crystal bow, crystal halberd

Crystal halberd charge tracking is done here: https://runelite.net/plugin-hub/show/weapon-charges-2. I think it has some support for the crystal bow; I'd recommend requesting it or developing it further there.


Running Plugin Under Insecure Mode (systemd)

Hello, I setup homebridge to launch on ubuntu on boot in my virtual box machine using scripting referenced here - https://github.com/nfarina/homebridge/wiki/Running-Homebridge-on-a-Raspberry-Pi#running-homebridge-on-bootup
It works fine in this setup however I am curious with the browser based accessory control you have to launch Homebridge using the -i flag. How do you do that with a systemd set up?
thanks!

Hi @mrtekkid,
Please see https://github.com/oznu/homebridge-config-ui-x/issues/37#issuecomment-368417328

This was fantastic
Thank you!

Hi Oznu, is there a env settings I can you to switch on/off insecure mode (I use a docker under synology)

There is:
https://github.com/oznu/docker-homebridge/blob/master/README.md#optional-settings

very nice. I am waiting for an update :)

Hi! As ref to above: Is this correct:
HOMEBRIDGE_OPTS=-U /var/lib/homebridge -I
Can't get that to work. First tried to change -U to -I but then Homebridge fails to start, but with the above - at least it starts.
Thanks.


Add gRPC API to push metadata of container image

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1357
Does this PR introduce a user-facing change?:

NONE

/lgtm

/lgtm

Btw, I am also thinking about changing the design of the model and the way of storing it inside DB.
Currently, we only save the latest one, but we can change to save all of the entities as normal and use the list(ordered by created_at, limit = 1) to get the latest one.
pros

make a better feeling because of unifying DB design with other entities (🤣 )
easier to scale/update in the future (e.g. the old entity still be in the database so we may need them in the future)
keep all entity to be immutable
able to avoid Latest prefix

cons

unnecessary data is constantly increasing (but not much because the entity's size is small)
have to use list instead of get to find the latest one (but not a problem because we have just 1 call per 5m, and we can also use list to find all imagemetadatas for a specific project)

So could you @nakabonne @khanhtc1202 vote which way do you want to apply?
1⃣  for current way
2⃣  for the new way

Btw, I am also thinking about changing the design of the model and the way of storing it inside DB.
Currently, we only save the latest one, but we can change to save all of the entities as normal and use the list(ordered by created_at, limit = 1) to get the latest one.
pros

make a better feeling because of unifying DB design with other entities (🤣 )
easier to scale/update in the future (e.g. the old entity still be in the database so we may need them in the future)
keep all entity to be immutable
able to avoid Latest prefix

cons

unnecessary data is constantly increasing (but not much because the entity's size is small)
have to use list instead of get to find the latest one (but not a problem because we have just 1 call per 5m, and we can also use list to find all imagemetadatas for a specific project)

So could you @nakabonne @khanhtc1202 vote which way do you want to apply?
1⃣  for current way
2⃣  for the new way

the old entity still be in the database so we may need them in the future

We're on the same page. The truth is I felt that may be going to be needed after supporting the Docker Registry HTTP API V2 (https://github.com/pipe-cd/pipe/issues/1350)
As you may know the polling interval can be quite short as that's configurable. But it's nothing, all cons look trivial to me.

the old entity still be in the database so we may need them in the future

We're on the same page. The truth is I felt that may be going to be needed after supporting the Docker Registry HTTP API V2 (https://github.com/pipe-cd/pipe/issues/1350)
As you may know the polling interval can be quite short as that's configurable. But it's nothing, all cons look trivial to me.

We're on the same page. The truth is I felt that may be going to be needed after supporting the Docker Registry HTTP API V2 (#1350)

Nice to hear, I suppose our user would need this #1350 in the near future, so +1 for saving all metadata.

We're on the same page. The truth is I felt that may be going to be needed after supporting the Docker Registry HTTP API V2 (#1350)

Nice to hear, I suppose our user would need this #1350 in the near future, so +1 for saving all metadata.

@khanhtc1202 Actually not sure we're really able to implement that (a couple of considerations exist including authentication). But worth looking into!

@khanhtc1202 Actually not sure we're really able to implement that (a couple of considerations exist including authentication). But worth looking into!

Thanks for the thoughts from both of you. Let me apply it.

Thanks for the thoughts from both of you. Let me apply it.

Updated!
Nice review. Thank you.

Updated!
Nice review. Thank you.

Except for a nit comment I left, LGTM
/lgtm

Except for a nit comment I left, LGTM
/lgtm

🚀
/approve

🚀
/approve

/hold

/hold

/approve cancel

/approve cancel

/hold cancel

/hold cancel

/approve

/approve


Notification progress messages are not read by screen reader

For notifications created with the vscode.window.withProgress API, NVDA only reads the title and not the progress messages.  For example, when we show this notification in Live Share, NVDA reads "Sharing workspace" but does not read "Share workspace starting".

Platform: Windows 10
VSCode: 1.28.0-Insider

I am now announcing the notification message again whenever it changes.


Set GTM TAG as environment variable

Why
To be able to test proposed changes to Google Tag Manager without affecting production.
What
Set GTM ID as an environment variable in travis to be used for production build and set it up in Netlify admin UI for all previews (PRs and branches)

Note: can't test production build without merging to master i guess.
Trello ticket: https://trello.com/c/a5txjlHe/795-3-use-different-gtm-ids-for-preview-and-production-deploys
In preview:

You can preview this change here:
Built with commit 683fa786e5d65deca958fe0ea131ba1e891c7494
https://deploy-preview-203--govuk-design-system-preview.netlify.com

You can preview this change here:
Built with commit 922b59b9304e64a2d00939bedd128764263f7a9e
https://deploy-preview-203--govuk-design-system-preview.netlify.com


Support comment provider: Telegram Comments Widget

Feature Request
Is your feature request related to a problem? Please describe.
One day. i receievd a email from commento:

This is a notice to let you know that your domain xxxxxx.com
on Commento.io has been SUSPENDED due to non-payment after two reminders. 😭

after that, i found telegram comment widget and tried on my website,(pics blew)
telegram comment widget is totally free with nice interface,that's the reason why i suggets add this comment system
Describe the solution you'd like
here,docs on telegram, https://comments.app/

Additional context

đfffvvv


Stats doesn't match levels

I'm really inexperienced with PKHeX, if this is obvious shut it down.
Lowering or Raising levels through the editor doesn't change the stats in the stats tab, also changing the pokemon to it evolution doesn't change it.
Am I missing something, or this feature is rather useless?

Yup, it is not automatic
You can alternatively install the auto legality mode plugin, when you press the button to legalizeit will calculate the values according to the species/level
Instructions here: https://github.com/arleypadua/PKHeX.Everywhere/wiki/01.01.01.-Web-‐-Plug‐Ins-‐-Auto‐Legality-Mode-(ALM)

thanks for the reply, just saw that this plug-in is in the Web version.
hope it will be implement naturally with the system and not just as extension.

You can alternatively install the auto legality mode plugin, when you press the button to legalizeit will calculate the values according to the species/level

I'm sorry to say though that despite the plug-in, experimenting with it not only didn't changed everything, but sometimes even doing the opposite.
https://github.com/user-attachments/assets/57120d6f-4b9c-4bcb-bd21-05bb24b60dc5
(then again it might not be the place for it, sorry)

It works the same as auto legality mode plugin for the Windows app (in fact it is the same plug-in here)
All it does is the best effort to make everything at least legal. I'm honestly not sure if it fixed on every level, but I'm definitely sure it adjusts a few things if you change the species of the Pokemon to a higher/lower evolution


Add hiljusti as a maintainer

So I can help prep for launch, review & merge, etc

I'll let someone else merge this when it's green, but I've manually added you to the team so you can start reviewing etc :)

gcc and gfortran got updated on MAC and changed path. Fixed the ci.yml and merged the change. And I learned some more git stuff in the process. :-)

@iHiD Are you "maintainers-admin" ? Seems you are the only person who can merge.

Welcome as a maintainer @hiljusti! 🎉


Received the exit code '255'

Hi
I am using this script inside a folder of a create-react-app project because i need it there in order to use Netlify function (like aws lambda).
I am using options like this because otherwise it won't find pdf_a4_portrait.js:
const options = {
  script: './../../node_modules/html-pdf/lib/scripts/pdf_a4_portrait.js',
  format: 'A4'
};

but still i have this error:
Error: html-pdf: Received the exit code '255'
Can't open '../../node_modules/html-pdf/lib/scripts/pdf_a4_portrait.js'

    at ChildProcess.respond (/Users/sunrising/Documents/Projects/testproject/lambda/htmlToPdfBlob.js:25177:31)
    at emitTwo (events.js:126:13)
    at ChildProcess.emit (events.js:214:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)

Is there any solution?
#366 didn't help

Hi. Did you solve this issue? Where did you add the options object? Thanks


Replace fmt with errors

This PR:

Fixes binding address bug (there was an extra :)
Replaces fmt.Errorf with Errors.New
Logs config at startup
Adds goconvey tests

How to review:

goconvey - check that all tests pass
Any forgotten fmt.Errorf?
I'd love feedback on this attempt at using goconvey 😄

Who can review:
Anyone

* Just a minor comment about `BindAddr`

* I tried to run the tests with `go test ./...` and they were successful

* I would suggest adding a `Makefile` with at least `build`, `debug` and `test` (please check other services or ask me), maybe this would be part of another task?

* The usage of go convey is very good! :)

The Makefile is indeed part of a different task :)

LGTM - great usage of go convey 👍


more accurate to say number than int

there is no type int but it is number, IEEE 754
it is more descriptive to say it can return 1 or return 1.23... not just strictly integers

It says:

Merging is blocked
The base branch restricts merging to authorized users. Learn more about protected branches.

is it because I edited online and created the PR right on GitHub?  Do I need to git clone to my machine first, create a branch, edit and commit and git push and create the PR?

It says:

Merging is blocked
The base branch restricts merging to authorized users. Learn more about protected branches.

is it because I edited online and created the PR right on GitHub? Do I need to git clone to my machine first, create a branch, edit and commit and git push and create the PR?

No, it just means that you can't merge your PR by yourself to a repo you don't own.


[backport] Op registration: normalization

Backport of #6719

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit 8d453b5993e19969e2fd0a04499639625b4cdb81, target branch v6) failed with status FAILURE.

Jenkins, test this please.

Jenkins CI test (for commit 8d453b5993e19969e2fd0a04499639625b4cdb81, target branch v6) failed with status FAILURE.

CI failures seem unrelated. LGTM!


Added feature to display returned gnews API article images in the DOM carousel

HTML:

Added 2 extra items in the carousel to display a total of 5 carousel cards

CSS:

Removed css placeholder images

JS:

Used query selectors to reference the user form and user input text box and placed them in variables
Obtained the value inputted by the user in the text box through its query selector variable
Changed the css style attribute of the carousel cards by setting the background image to be the url returned by the gnews API

Looks good to me!

Reviewed the code for html, css and javascript. The carousel works


locale is set To Locale, but the values of the fields From and to do not also become local

locale is set To Locale, but the values of the fields From and to do not also become local

Sorry, no F5 refresh caused

locale is set To Locale, but the values of the fields From and to do not also become local

请问怎么设置成中文的，我看他这个好像没支持国际化

同问，如何中文的？ 难道是修改源码

看源码的类型备注，这么设置即可

locale is set To Locale, but the values of the fields From and to do not also become local

请问怎么设置成中文的，我看他这个好像没支持国际化

看源码的类型备注，这么设置即可


Plugins don't show up in Editor settings

Windows - <IP_ADDRESS>.stable.official (Steam version):
Plugins don't show up as available in the editor settings. According to the docs and information I read elsewhere, they should show up if there's a plugin.cfg in either res://addons/<plugin name>/ or (on windows) $env:APPDATA/godot/plugins/<plugin name>/ . I have tried both with self made plugins following the plugin tutorial in the docs, as well as plugins I grabbed from github, and neither seemed to work even after refreshing the plugin list.
Attempt to install any plugin
Link to minimal example project https://github.com/hanst99/godot_bug_demonstration
I'm naturally not sure if this is a genuine bug or a documentation bug or if my assumptions about how this works are just wrong.

That's not a bug but a lack of clarity on the documentation; the page about making plugins is actually specific to the upcoming 2.1 version where the plugin API was completely reworked. Having plugins res://addons/ is also something that is arriving in 2.1 (you can test the freshly released 2.1-beta if you want).
For 2.0, there was no official documentation about making plugins, but they had to be placed in %APPDATA$/godot/plugins/ as you mentioned yes. Since the API changed a lot, those plugins are no longer compatible with Godot 2.1; I'd advise you to go directly with the beta while learning how to make plugins, since the days of 2.0 are counted :)

Cool. I'd personally mark this as a documentation bug though; Documentation should make it clear if something only applies to specific versions of the engine, especially if the feature isn't 'released' yet.


Merge pre-commit local and on-push / on-pr checks into upstream

Added pre-commit checks to project, this PR includes the configuration necessary to add pre-commit and a change to the README to reflect the state of the branch w.r.t it's pre-commit checks on-push.

pre-commit check will fail this time because this commit only includes the configuration for pre-commit- its doesn't actually enforce the necessary formatting changes that will come in a subsequent PR.


release: 0.5.1

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.74%. Comparing base (2153980) to head (72f896f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   95.74%   95.74%
=======================================
  Files          10       10
  Lines         776      776
=======================================
  Hits          743      743
  Misses         33       33

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


travis: make logdir for scheduler in non-stupid location

In commit 33f421fa357563eecc6b3641cec7949caacdc008 I added a mkdir
in the travis yaml file for the scheduler logs.  It looks like I copy
pasted the line above and appended the log directory.  I should have
also changed /etc/pki to /var/lib.
Signed-off-by: Tim Pepper<EMAIL_ADDRESS>

Coverage decreased (-0.02%) to 64.721% when pulling df9d216426760add99dc4ec7bb6bb5b3289b8db0 on tpepper:master into 320fc8a2c309113bd7cc7e97d1ee17fc8f074137 on 01org:master.


🐛 Bug Report: Link incorrect in Q&A section

📜 Description
The link in this Question : How do we calculate the score? is wrong or not linked to an appropriate resource.
👟 Reproduction steps

Go to https://www.hacksquad.dev/#qa
Check the question How do we calculate the score?
Check the link with the link text found here
Click on it

👍 Expected behavior
A link pointing to an appropriate resource.
👎 Actual Behavior with Screenshots

💻 Operating system
Windows
🤖 Node Version
N/A
📃 Provide any additional context for the Bug.
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

Are you willing to submit PR?
Yes I am willing to submit a PR!

Thanks for the report @tmsagarofficial
However the link is actually properly linked to correct resource. 🙏

@tmsagarofficial yes it does, and that is the correct file as well.
All the logic behind which PRs have been accepted or rejected, lies there


What TTS model is used?

Hey, I see your ACL paper is so nice， can you share me what's tts model had been used in your agent system? or could you share your full demo code for sound-in-out chat?

Hi, thanks for your kind words about our work.
The checkpoint of MSMA Synthesizer is now available at GoogleDrive. We also provide the pretained synthesizer at GoogleDrive.
You can find their inference commands in README.


Will the reports be affected if I'm doing something processor intensive while the report is running?

@calebeby When I ran a report recently, my laptop was chugging. It made me wonder if it was better to leave my laptop alone or if it was okay to continue doing other tasks while the report ran. I didn't know if doing other tasks would impact the report's outcome.
Also, what if I'm running two reports for two different sites simultaneously? Does that affect the outcome?

I've noticed that on my computer, when my computer is "busy" then the lighthouse scores tend to be lower. I definitely notice the fans running and I expect that it is thermal throttling. To get the most accurate data, you can avoid doing other things on your computer, and you can tell lighthouse-parade to only run one lighthouse report at a time (using --lighthouse-concurrency 1). It is a trade of off inconvenience vs. accuracy. You can use Activity Monitor to look at the CPU usage, and if it is pretty high, that probably suggests that the lighthouse reports might be off, and you might be better off by setting the concurrency lower and/or avoiding doing other CPU intensive work on your computer


Settings file tests

This pull request adds a number of error handling tests related to the new stylecop.json configuration file.

:+1:


"Fp16 precision has been set for a layer or layer output, but fp16 is not configured in the builder" when trying to convert a nvidia-

System Info

CPU Architecture: x86_64
CPU Type: AMD Epyc 9654
GPU Type: Nvidia H100
Nvidia Docker Container: nvcr.io/nvidia/nemo:24.01.gemma

Who can help?
@Tracin
Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[X] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[X] My own task or dataset (give details below)

Reproduction

Train a Gemma model with bfloat16, which leads to a model of following configuration:

{
  "_name_or_path": "./lilac-ultra-base-bf16",
  "architectures": [
    "GemmaForCausalLM"
  ],
  "attention_bias": false,
  "attention_dropout": 0.0,
  "bos_token_id": 2,
  "eos_token_id": 1,
  "head_dim": 256,
  "hidden_act": "gelu",
  "hidden_size": 3072,
  "initializer_range": 0.02,
  "intermediate_size": 24576,
  "max_position_embeddings": 8192,
  "model_type": "gemma",
  "num_attention_heads": 16,
  "num_hidden_layers": 28,
  "num_key_value_heads": 16,
  "pad_token_id": 0,
  "rms_norm_eps": 1e-06,
  "rope_scaling": null,
  "rope_theta": 10000.0,
  "torch_dtype": "bfloat16",
  "transformers_version": "4.38.1",
  "use_cache": true,
  "vocab_size": 256000
}

Quantize the model via the official example quantization script to int4_awq & bf16, so that it ends in following configuration:

{
    "producer": {
        "name": "ammo",
        "version": "0.7.3"
    },
    "architecture": "GemmaForCausalLM",
    "dtype": "bfloat16",
    "num_hidden_layers": 28,
    "model_type": "gemma",
    "num_attention_heads": 16,
    "num_key_value_heads": 16,
    "hidden_size": 3072,
    "norm_epsilon": 1e-06,
    "vocab_size": 256000,
    "max_position_embeddings": 8192,
    "hidden_act": "gelu",
    "use_parallel_embedding": true,
    "embedding_sharding_dim": 0,
    "quantization": {
        "quant_algo": "W4A16_AWQ",
        "kv_cache_quant_algo": null,
        "group_size": 128,
        "has_zero_point": false,
        "pre_quant_scale": true,
        "exclude_modules": [
            "lm_head"
        ]
    },
    "mapping": {
        "world_size": 1,
        "tp_size": 1,
        "pp_size": 1
    },
    "head_size": 256,
    "intermediate_size": 24576,
    "position_embedding_type": "rope_gpt_neox"
}

Try to convert the model with trtllm-build trtllm-build --checkpoint_dir ./gemma-quantized-awq/ --gemm_plugin bfloat16 --gpt_attention_plugin bfloat16 --max_batch_size 8 --max_num_tokens 4096 --max_output_len 140 --output_dir ./exported

Expected behavior
The model converts to TensorRT format correctly
actual behavior
It is not possible to convert the nvidia-ammo quantized model via trtllm-build, and it gives the following error regarding fp16 precision being set for a layer or layer output but it not being configured:
[02/29/2024-20:41:18] [TRT] [W] IElementWiseLayer with inputs GemmaForCausalLM/transformer/layers/27/ELEMENTWISE_SUM_1_output_0 and GemmaForCausalLM/transformer/ln_f/SHUFFLE_0_output_0: first input has type BFloat16 but second input has type Float.
[02/29/2024-20:41:18] [TRT] [W] IElementWiseLayer with inputs GemmaForCausalLM/transformer/ln_f/REDUCE_AVG_0_output_0 and GemmaForCausalLM/transformer/ln_f/SHUFFLE_1_output_0: first input has type BFloat16 but second input has type Float.
[02/29/2024-20:41:18] [TRT-LLM] [I] Build TensorRT engine Unnamed Network 0
[02/29/2024-20:41:18] [TRT] [W] Unused Input: position_ids
[02/29/2024-20:41:18] [TRT] [E] 4: [network.cpp::validate::3516] Error Code 4: Internal Error (fp16 precision has been set for a layer or layer output, but fp16 is not configured in the builder)
[02/29/2024-20:41:18] [TRT-LLM] [E] Engine building failed, please check the error log.
[02/29/2024-20:41:20] [TRT-LLM] [I] Serializing engine to ./lilac_final_exported/rank0.engine...

additional notes
I believe it might be related to how the config is initialized within the main file in tensorrt-llm

How about add --strongly_typed for trtllm-build

How about add --strongly_typed for trtllm-build

Hi, I had a similar warning
[TRT] [W] A shape layer can only run in INT32 precision
[TRT] [W] IElementWiseLayer with inputs LLaMAForCausalLM/vocab_embedding/GATHER_0_output_0 and LLaMAForCausalLM/layers/0/input_layernorm/SHUFFLE_0_output_0: first input has type Half but second input has type Float.
and the flag  --strongly_typed  fixed it, thank you so much)

Hi I'm having a same error message while converting onnx to plan model with precision int8.
anyone who resolved a issue or have some hints..?

I have the same problem when building the engine for quantized Llama 3 70B with tensorrt-llm==0.8.0.
If I add --strongly_typed it will cause a different error:
LLaMAForCausalLM/transformer/layers/0/attention/qkv/PLUGIN_V2_WeightOnlyGroupwiseQuantMatmul_0: could not find any supported formats consistent with input/output data types

@giancarlo-metitieri @scinerd68 Do you still have the question? If not, we will close it soon.


Use default fg and bg colours.

This is great, thanks! (note to reduce future confusion: I think you have old and new swapped on your example, but there's absolutely no need to change)

I published v0.1.7 with your fix, so it should end up in nixpkgs-unstable in a few weeks.


pick language

[x] pick language dialog called from the header

[x] implement pick language dialog according to

[x] dialog should store language selection when saved

[x] term languages are updated depending on the language selection

https://user-images.githubusercontent.com/5613150/219136476-80d4e861-718e-491a-8c62-ff50d5da165d.mp4
Androidde böyle bi garip oluyor


To fix links with correct reference to assets folder

Cancelled a previous PR #121 in favor of this one. To make it cleaner using a new branch instead of my master.
#123 Also pointed to this issue.

bors r+


Not compatible with @swc/core v1.0.6

swc_mut_cjs_exports  plugin broken after swc/core v1.0.6, I've fixed by downgrade version as v1.0.5 which is working fine.
Determining test suites to run...thread '<unnamed>' panicked at /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/swc-0.272.1/src/plugin.rs:162:14:
failed to invoke plugin: failed to invoke plugin on 'Some("/Users/bb/repos/test/jest.init.js")'

Caused by:
    0: failed to invoke `swc_mut_cjs_exports` as js transform plugin at swc_mut_cjs_exports
    1: RuntimeError: unreachable
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I got the same error when updating @swc/core from 1.3.105 to 1.3.106
  ● Test suite failed to run

    failed to handle: failed to invoke plugin: failed to invoke plugin on 'Some("/Users/garrettmccullough/code/program_lead_portal_py/test/javascript_tests/setup.js")'

    Caused by:
        0: failed to invoke `swc_mut_cjs_exports` as js transform plugin at swc_mut_cjs_exports
        1: RuntimeError: unreachable

      at Compiler.transformSync (node_modules/@swc/core/index.js:244:29)
      at transformSync (node_modules/@swc/core/index.js:351:21)
      at Object.process (node_modules/@swc/jest/index.js:73:45)
      at ScriptTransformer.transformSource (node_modules/@jest/transform/build/ScriptTransformer.js:545:31)
      at ScriptTransformer._transformAndBuildScript (node_modules/@jest/transform/build/ScriptTransformer.js:674:40)
      at ScriptTransformer.transform (node_modules/@jest/transform/build/ScriptTransformer.js:726:19)

Is there a plan to update this package to work with the lastest @swc/core version?


[React][Tooltip]: Tooltip doesn't when when you tab to a button that's outside the viewport

🐛 Bug report

When you navigate to a button that's outside of viewport, the tooltip doesn't show up due to the browser scroll.
💥 Steps to reproduce

Go to https://stackblitz.com/edit/vitejs-vite-khtf65
Use tab to navigate to the buttons
Observe how the button that's out of view doesn't show its tooltip

💻 Link to reproduction

Stackblitz Reproduction: https://stackblitz.com/edit/vitejs-vite-khtf65
(Not sure if using Stackblitz will be an issue. By the time I opened the issue, I had already finished the reproduction. I can redo it in CodeSandbox if needed.)
🧐 Expected behavior

The tooltip should show up.
🧭 Possible Solution

Probably detect if the trigger element is outside the viewport first when opening via tab before triggering the "close on scroll" behavior.
🌍 System information

Software
Version(s)

Zag Version
0.56.1

Browser
Chrome Version 125.0.6422.142 (Official Build) (x86_64)

Operating System
macOS Sonoma 14.5

📝 Additional information

This is by design. The tooltip closes when the overflow parent scrolls.
I've exposed closeOnScroll as a machine property you can use to disable this behavior so that your use case can work.
Will do a new release shortly


Nix build - SDLCallFailed

I can successfully build the monomer project using nix build. However the resulting binaries have some problems:
./result/bin/todo
Invalid window
todo: SDLCallFailed {sdlExceptionCaller = "SDL.Video.glCreateContext", sdlFunction = "SDL_GL_CreateContext", sdlExceptionError = "Invalid window"}

Hi @prolic!
I don't know much about Nix, so I'm probably not the best person to help here (although it's high on my list of things to learn). Looking at a comment made by @smunix (the contributor of the Nix and GitHub Actions configuration), it seems you should run the applications with a different command:
nix run .#todo

I remember running them successfully in an Ubuntu VM.

Doesn't seem to work either. Feel free to close this issue if you want to. I'm just struggling myself for over a week to setup nix for my project.

I think you may need nixGL. I remember having to use that. It was also mentioned in this PR

Just to be sure: have you checked nixGL? The error you're getting can probably be fixed by using it.

I'll close this issue for now. Please re-open if needed. Thanks!

Just to be sure: have you checked nixGL? The error you're getting can probably be fixed by using it.

I was seeing this error on a different monomer project on NixOS.  I don't know if I had the same root cause as the original poster but when I ran the app under nixGL instead, the problem went away and the app works.

I can confirm that nixGL fixes the problem. However I decided to move forward without nix builds. Thanks.


Update invoice related actions for Staff

We need to update invoice related actions as a part of this project also:

it should be like this:

@abhiXII Staff can't delete the invoice?

I recommend we use permission_required decorator to check the role permissions for delete actions.
This is how it is done to check if someone has permission to delete submissions.
https://github.com/HyphaApp/hypha/blob/dde2ed4fa75af2598f62544f46924428065828b2/hypha/apply/funds/views.py#L1436-L1450

I think it is already fixed and deployed.


[Question] Use routing key for consume related event ?

Description
Hi, I wonder if it's possible to use any mechanism to route related event (ie same provided correlation id, or orderId or whatever that can link two events in term of business) when they are consumed by load balanced consumers (same groupId) on same topic ?
My point is to use this kind mechanism to project downstreams of domain aggregates with a high rate of events production, events that can be be related to each others (same orderId for example) and that I absolutely need to project in their current topic ordering persistence. With a routing key, I'll ensure that all related events of the same orderId for example are consumed and processed by the same instance, thus in the expected ordering as they are produced.
If I can't use this kind of mechanism, nothing guarantee me that if two related events are balanced to two different instances of my consumer (same groupId) they will be able to process them in the order they have been consumed (due to network latency, database behavior or whatever ...). It leads me to use only one instance of my consumer, which is a pity in term of scalability.
Could you advice me on that ?
Many thanks for your amazing work, I use your lib every day and I enjoy it a lot!

right, that's what partitioning is for (set the thing you want to partition on as the key). using consumer groups isn't compatible with your requirements though as i understand them, because the group can rebalance, changing which node processes which key. so you'll want to manually assign (don't use subscribe) partitions to each of your nodes. you'll need some strategy compatible with your requirements if you ever want to scale up/down though (you may want a custom partitioning strategy to help with that, coming in 1.6).

@mhowlett thank you, it's exactly what I need, do you know if these custom strategies will be able to be based on data from the event payload ?
For example : let's say odd orderId goes to consumer instance1 and event orderId goes to consumer instance2 .

you can partition based on message key, so if you put orderId in the key, then you can partition on that. Note that this capability is in 1.6.0-PRE1, which is on nuget already. But that release is not production ready.
https://github.com/confluentinc/confluent-kafka-dotnet/blob/1.6.x/src/Confluent.Kafka/ProducerBuilder.cs#L54

@mhowlett you made my day! I'll follow the release with interest

This is released. Closing the issue. Please raise a new one if you need more help.


Frontend

Initialization of the Frontend using create-next-app in conjunction with the user-service and question-service.
Here are the routes to be completed:

[x] users/login
[x] users/register
[x] dashboard
[x] questions

LGTM!


Added client-level REST helpers.

Description
Adds client-level REST helpers.
In python methods like _xyz are "internal use" by convention, but we already have a get. I could make these transport_get, but that's pretty ugly. The other alternative is to not add them at all, or to implement transport.get or transport.perform_get. WDYT?
Issues Resolved
Closes https://github.com/opensearch-project/opensearch-py/issues/498.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@saimedhi @harshavamsi @Xtansia wdyt?

@saimedhi @harshavamsi @Xtansia wdyt?

We're going to have this name clash with get in all the clients presumably, and it'd probably be nice to have this semi-standardised across them. An option is to make an "operation namespace" like raw or http same as we have cat/cluster/indices etc.

@Xtansia What's your most preferred option for client.X.Y.Z?

@Xtansia What's your most preferred option for client.X.Y.Z?

I personally feel like client.http.get() is probably the most self-documenting, and least likely to ever conflict with the naming of a "real" operation

Followed suggestion from @Xtansia to make the code client.http.get, client.http.post, etc. This is ready to review!


Search: Scan Type = null

On Search, selecting Scan Type = null essentially dumps the DB into the search as it returns true for every scan type. We should either remove this option, or remap it to show the word "All" in the drop down.

I'm leaning toward removal (mask it out of the UI) as it is basically a way to hang the UI when there are massive amounts of data in the DB (e.g., CNI).

After a conversation with @gsfr we found that there are indeed some acquisitions in the DB with a scan type of None. This, however does not explain why the search query is returning the entire DB when 'null' is selected.
We believe that this can be fixed by assigning 'Unknown' to all those acquisitions where scantype=None. More investigation will need to be done to figure out why this is happening in the first place.


Notification state in rootStore not reset when through ssr

When refresh page, notifications store in global state not sync with client. Cause many notification popups

solved #225


[Hub Generated] Review request for Microsoft.BotService to add version preview/2021-05-01

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[x] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[x] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[x] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

Changes in this PR-

Add support for operationresults, so that we can support async ARM api's
Add support for private links

Please fill out the contribution checklist.

@mentat9  i have added the contribution checklist (the markdown wasnt rendering earlier for some reason). I have some CI failures, but they seem to be present in api's present in previous versions of the swagger

There are still several unaddressed comments. You aren't required to implement non-blocking suggestions but please reply to everything so I know you've seen and considered it.

@mentat9 Thanks for the review and the signoff! i have pushed a commit to change the api-version to have a -preview suffix.
Can you please merge my PR?

@mentat9 Thanks for the review and the signoff! i have pushed a commit to change the api-version to have a -preview suffix.
Can you please merge my PR?

I'm not involved in merging. ARM review only reviews the REST APIs. The SDK team owns downstream steps (SDK review and generation, linter checks, merging).

@lirenhe can you please help merge the PR? (all errors in the pipelines are from a previous version of the API that i forked off and unrelated to the newly added API's)

Could you also check the model validation errors? seems the example provided are not consistent with the swagger definition

@lirenhe  i have fixed the new lint and model validation errors.
Regarding breaking changes, this PR only contains new API's related to private links and async operations. I did a diff between the swagger file and the swagger file for the last stable version (2021-03-01) and only see new API's being added and no breaking changes.
The pipeline also indicates that there are no breaking changes from the last stable version.
Do you see any particular breaking changes that i am not seeing?

@lirenhe  can you please take a look at it? This PR is blocking further development for private links and we have deadlines to meet for this feature work

/azp run

/azp run

/azp run

/azp run

/azp run

@swagatmishra2007 , model validation failed due to duplicated model name of Resource in botservice.json and types.json from common-type folder. Can you reference the common Resource model from common-type folder since this is a new API version?

/azp run

/azp run

No breaking change compared with the latest version.


SharePoint Storage savings report after version trimming

Some orgs create a lot of content and quickly exceeds the SharePoint storage allocated. In order to minimizing cost this script will specify the current storage and the storage if the number of document versions is reduced.
The idea is that when a site collection is about to be archived ( you do handle the life cycle, right? ) the documents inc all versions are either copied to  low cost  storage (if required by law or governance) and the versions are then stripped down to the minimum. This will ensure that the most recent docs are still available, both in the Site Collection and in Search :-)

Nice idea! Is this something your working on or a sample suggestion? So I can label it.

I guess the PR is ready for approval early next week :-)

as per your recommendation I have contacted Luise F and gotten access to the PnP Blog. I expect to write a piece about how to minimize SharePoint Storage cost, using this sample in the article


Creating a plugin on MAC OS M1

I tried to follow the docs at https://learn.microsoft.com/en-us/microsoft-cloud/dev/dev-proxy/how-to/create-custom-pluginto create a custom plugin to output the request body/headers for debugging purposes on an Apple MAC OS M1 silicon machine.
Project FIle:
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>net8.0</TargetFramework>
    <ImplicitUsings>enable</ImplicitUsings>
  </PropertyGroup>
<ItemGroup>
  <Reference Include="dev-proxy-abstractions">
    <HintPath>.\dev-proxy-abstractions.dll</HintPath>
    <Private>false</Private>
    <ExcludeAssets>runtime</ExcludeAssets>
  </Reference>
</ItemGroup>
<ItemGroup>
  <PackageReference Include="Microsoft.Extensions.Configuration" Version="8.0.0" />
  <PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="8.0.2" />
  <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.2" />
  <PackageReference Include="Titanium.Web.Proxy" Version="3.2.0" />
</ItemGroup>
</Project>

I downloaded and referenced the dev-proxy-abstractions.dll from https://github.com/microsoft/dev-proxy/releases/download/v0.22.0/dev-proxy-abstractions-v0.22.0.zip
When building the project I get the following errors:
/...../LogBodyPlugin/CatchApiCalls.cs(20,22): error CS0012: The type 'AsyncEventHandler<>' is defined in an assembly that is not referenced. You must add a reference to assembly 'Titanium.Web.Proxy, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'. [/.....//LogBodyPlugin/LogBodyPlugin.csproj]
/.....//LogBodyPlugin/CatchApiCalls.cs(34,38): error CS0012: The type 'SessionEventArgs' is defined in an assembly that is not referenced. You must add a reference to assembly 'Titanium.Web.Proxy, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'. [/.....//LogBodyPlugin/LogBodyPlugin.csproj]

This is the attempt at the actual plugin :
using Microsoft.DevProxy.Abstractions;
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.Logging;
using Titanium.Web.Proxy.EventArguments;
using Titanium.Web.Proxy.Http;

namespace LogBodyPlugin;

public class CatchApiCalls : BaseProxyPlugin
{
    public CatchApiCalls(IPluginEvents pluginEvents, IProxyContext context, ILogger logger, ISet<UrlToWatch> UrlsToWatch, IConfigurationSection configSection = null) : base(pluginEvents, context, logger, UrlsToWatch, configSection)
    {

    }

    public override async Task RegisterAsync()
    {
        await base.RegisterAsync();

        PluginEvents.BeforeRequest += OnBeforeRequest;
    }

    public override string Name => nameof(CatchApiCalls);

    private Task OnBeforeRequest(object sender, ProxyRequestArgs e)
    {
        if (UrlsToWatch is null ||
          !e.HasRequestUrlMatch(UrlsToWatch))
        {
            // No match for the URL, so we don't need to do anything
            return Task.CompletedTask;
        }

        SessionEventArgs session = e.Session;
        Request request = session.HttpClient.Request;
        var headers = request.Headers;
        var body = System.Text.Encoding.UTF8.GetString(request.Body);
        Logger?.LogRequest(body, MessageType.PassedThrough);
        return Task.CompletedTask;
    }
}

The specific lines that cause errors are:
...
PluginEvents.BeforeRequest += OnBeforeRequest;
...

and
...
SessionEventArgs session = e.Session;
...

How can this be resolved? Or can you create a plugin that logs the request body?

I submitted a PR to our docs and the changes should visible in the next couple of hours.

Awesome - that did indeed solve the problem.
Thanks for the update.

Thank you for confirming.


Mobile portfolio with first 2 sections based on Figma template 5

In this project we :
-Added Tools bar section
-Added the headline section
-Added a working linters file for Htmll &Css
-Added a README.md based on the model of Microverse project
-Added a index.html file with first two section of Mobile portfolio based on Figma template 5
-Added a separated CSS file which position elements with Flexbox
-Added a git-ignore file which ignore node_modules/
-Used responsive values in CSS rules
-Implemented the button interactions

Hello, @emmiiorji
Thank you for yours suggestion, I took into account all your changes, and when i renamed the branch, it was mandatory to open a new pull request, the link is below.
https://github.com/Bleu-Yves-Sopoude/mb-portfolio/pull/2