refactor(data-masking): disable e2e tests.

Issue number: #3203
Summary
Changes
Disable e2e tests until we go GA.
User experience

Please share what the user experience looks like before and after this change

Checklist
If your change doesn't seem to apply, please leave them unchecked.

[x] Meet tenets criteria
[x] I have performed a self-review of this change
[x] Changes have been tested
[ ] Changes are documented
[x] PR title follows conventional commit semantics

Is this a breaking change?
RFC issue number:
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (52d54ab) 95.94% compared to head (4eccb21) 95.92%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3204      +/-   ##
===========================================
- Coverage    95.94%   95.92%   -0.03%
===========================================
  Files          195      195
  Lines         8387     8385       -2
  Branches       634      619      -15
===========================================
- Hits          8047     8043       -4
- Misses         277      278       +1
- Partials        63       64       +1

see 3 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Upgrade aws-cli to 1.18.21

Upgraded aws-cli
Test steps
Before
Run the following commands
- docker run -it --entrypoint sh karlkfi/aws-cli
- /project # export AWS_ACCESS_KEY_ID=ABC
- /project # export AWS_SECRET_ACCESS_KEY=DEF
- /project # export AWS_DEFAULT_REGION=us-east-1
- aws ec2 get-ebs-encryption-by-default

This gives an output that get-ebs-encryption-by-default is not a valid command.
After
- docker build -t aws-cli .
- docker run -it --entrypoint sh aws-cli:latest
- /project # export AWS_ACCESS_KEY_ID=ABC
- /project # export AWS_SECRET_ACCESS_KEY=DEF
- /project # export AWS_DEFAULT_REGION=us-east-1
- aws ec2 get-ebs-encryption-by-default

get-ebs-encryption-by-default is recognised as a valid command

Thanks! Sorry for the slow response.

no problem - thanks for reviewing this


Allow support for iterators in Boolean operators

Example:
∨(x[i] for i = 1:2)

which is equivalent to
x[1] ∨ x[2]

Nested operators should be supported

can now do ∨([x[i] for i = 1:2]...) in v0.4.0


Add zstd to prcompression values

zstd is supported by chrome now and will probably be supported by other browsers in the near future.

makes sense!
little test using maximum compression on vector tile 0/0/0:

compression
size

uncompressed
436'324

gzip
116'387

zstd
99'028

brotli
92'685

But we might want to wait for broader support: https://caniuse.com/zstd

i think the advantage is faster compression and decompression at comparable rates, which would be advantageous when creating or recompressing tilesets. for use of a versatiles container as a source in a tileserver it already makes sense.


PrepareBasics error

Hi LRLoop Team,
I followed the tutorial of [LRLoop analysis starting from Seurat objects] to learn cell-cell interaction.
I  use your pre-calculated default networks and two celltypes each have two conditions:
ct1obj
An object of class Seurat
23739 features across 24 samples within 1 assay
Active assay: RNA (23739 features, 2000 variable features)
3 dimensional reductions calculated: pca, harmony, umap
ct2obj
An object of class Seurat
23739 features across 99 samples within 1 assay
Active assay: RNA (23739 features, 2000 variable features)
3 dimensional reductions calculated: pca, harmony, umap
when I did the PrepareBasics, there was something wrong with it.
Basics <- PrepareBasics(ct1obj, ct2obj, min_pct = 0.1, geneset_ct1 = DEGinfo_ct1$DEgenes, geneset_ct2 = DEGinfo_ct2$DEgenes,
lr_network,
ligand_target_matrix_ct1_to_ct2, receptor_target_matrix_ct1_to_ct2, ligand_target_matrix_ct2_to_ct1, receptor_target_matrix_ct2_to_ct1,
discrete_error_rate = 0.1, discrete_cutoff_method = "distribution", discrete_fdr_method = "global", allow_feedback_delay = FALSE)
the error is : Error in rowSums(subdata > 0) : 'x' must be  arry and has at least two dimention.
I checked the PrepareBasics function
body(PrepareBasics)
{
conditions =<EMAIL_ADDRESS>"Condition"]))
data_ct1 = ct1obj@assays$RNA@data
data_ct2 = ct2obj@assays$RNA@data
ave_expr_ct1 = log1p(AverageExpression(ct1obj, group.by = "Condition")$RNA)
ave_expr_ct2 = log1p(AverageExpression(ct2obj, group.by = "Condition")$RNA)
if (length(conditions) > 1) {
ave_expr_ct1 = ave_expr_ct1[, conditions]
ave_expr_ct2 = ave_expr_ct2[, conditions]
}
else {
colnames(ave_expr_ct1) = conditions
colnames(ave_expr_ct2) = conditions
}
pct_expr_ct1 = get_pct_expr(ct1obj, conditions) ####erro starts at here
pct_expr_ct2 = get_pct_expr(ct2obj, conditions)
..........
then further checked the get_pct_expr( ) function
body(get_pct_expr)
{
data = seuratobj@assays$RNA@data
pct_expr = matrix(0, nrow = nrow(data), ncol = length(conditions))
Idents(object = seuratobj) = "Condition"
for (i in 1:length(conditions)) {
subdata = data[, WhichCells(seuratobj, idents = conditions[i])]
pct_expr[, i] = rowSums(subdata > 0)/ncol(subdata)
}
rownames(pct_expr) = rownames(data)
colnames(pct_expr) = conditions
return(pct_expr)
}
I could get a dataframe named pct_expr:
head(pct_expr)
control          condition2
Xkr4            0.0000000    0
Gm1992      0.0000000   0
Gm19938    0.0000000   0
Gm37381    0.0000000   0
Rp1             0.2857143   0
Sox17          0.0000000   0
then looked in to  the PrepareBasics function:
thresh_expr_ct1 = (pct_expr_ct1 > min_pct) * 1
thresh_expr_ct2 = (pct_expr_ct2 > min_pct) * 1
but we haven't got min_pct yet so erro occured
Could you please help me with that?? Really wanna know where the problem is.
Many thanks,
TJ

Hi TJ,
I am also having this problem. However, I have overcome the problem in the following way, and it should be the correct one in my understanding: First, download the PrepareBasics.R and get_pct_expr.R source code from GitHub.
https://github.com/Pinlyu3/LRLoop/blob/main/R/PrepareBasics.R
https://github.com/Pinlyu3/LRLoop/blob/main/R/get_pct_expr.R
Then slightly modify the get_pct_expr.R code in the following way:
get_pct_expr <- function(seuratobj, conditions) {
data = seuratobj@assays$RNA@data
pct_expr = matrix(0, nrow = nrow(data), ncol = length(conditions))
Idents(object = seuratobj) = seuratobj$Condition
for (i in 1:length(conditions)) {
subdata = data[,WhichCells(seuratobj, idents = conditions[i])]
pct_expr[,i] = rowSums(subdata >0)/ncol(subdata)
}
rownames(pct_expr) = rownames(data)
colnames(pct_expr) = conditions
return(pct_expr)
}
Then put this modified get_pct_expr function inside the PrepareBasics.R code but outside the PrepareBasics function. Then load the modified PrepareBasics.R code as source code and run your data, or you can load it however you like. I mainly try to fix the issue.
I hope this helps you!
Aman

I have encountered same problem, and the suggestion from amanzju did not solve the problem.
Not sure if it is a problem caused by update in packages. Hope the developers can fix this problem. Thank you!

I have encountered same problem. After modified the 'get_pct_expr' function slightly,  'PrepareBasics' function works, though I am still unable to figure out why this error occurred. It's seems that I only correct the 'subdata = data[,WhichCells(seuratobj, idents = conditions[i])]' with 'cells_in_condition = WhichCells(seuratobj, idents = conditions[i])            subdata = data[, cells_in_condition]'
get_pct_expr <- function(seuratobj, conditions) {
data = seuratobj@assays$RNA@data
pct_expr = matrix(0, nrow = nrow(data), ncol = length(conditions))
Idents(object = seuratobj) = 'Condition'
for (i in 1:length(conditions)) {
cells_in_condition = WhichCells(seuratobj, idents = conditions[i])
subdata = data[, cells_in_condition]
if (ncol(subdata) > 0) {
pct_expr[,i] = rowSums(subdata > 0) / ncol(subdata)
} else {
warning(paste("No cells found for condition:", conditions[i]))
pct_expr[,i] = 0
}
}
rownames(pct_expr) = rownames(data)
colnames(pct_expr) = conditions
return(pct_expr)

}


Updated spaceship and I'm having issues with prompt now

The problem
I have been using spaceship for years but I never updated it before and today I did and I'm having major issues.
The manual install method has changes and now it supports configuration files in other locations (I moved my configuration from .zshrc to ~/.config/spaceship/spaceship.zsh). The issue I'm having is that everytime I open the terminal spaceship adds a newline to my prompt when I have SPACESHIP_PROMPT_ADD_NEWLINE=false and SPACESHIP_PROMPT_SEPARATE_LINE=false in my configuration. It only happens with the first line when the prompt loads, after typing anything and pressing enter the issue does not repeat. The second issue is that I have 3 dots (...) before my CHAR and I don't know where it came from.
Relevant Zsh configuration
spaceship.zsh:
# Prompt
SPACESHIP_PROMPT_ADD_NEWLINE=false
SPACESHIP_PROMPT_SEPARATE_LINE=false
SPACESHIP_PROMPT_FIRST_PREFIX_SHOW=false
SPACESHIP_PROMPT_PREFIXES_SHOW=true
SPACESHIP_PROMPT_SUFFIXES_SHOW=true
# Char
SPACESHIP_CHAR_SUFFIX=" "
SPACESHIP_CHAR_SYMBOL=" ❯"
SPACESHIP_CHAR_COLOR_SUCCESS=white
# Dir
SPACESHIP_DIR_COLOR=white
# Package version
SPACESHIP_PACKAGE_SHOW=false
SPACESHIP_NODE_SHOW=false
SPACESHIP_RUBY_SHOW=false
SPACESHIP_ELM_SHOW=false
SPACESHIP_ELIXIR_SHOW=false
SPACESHIP_XCODE_SHOW_LOCAL=false
SPACESHIP_SWIFT_SHOW_LOCAL=false
SPACESHIP_GOLANG_SHOW=false
SPACESHIP_PHP_SHOW=false
SPACESHIP_RUST_SHOW=false
SPACESHIP_HASKELL_SHOW=false
SPACESHIP_JULIA_SHOW=false
SPACESHIP_DOCKER_SHOW=false
#SPACESHIP_DOCKER_CONTEXT_SHOW=false
SPACESHIP_AWS_SHOW=false
SPACESHIP_GCLOUD_SHOW=false
SPACESHIP_VENV_SHOW=false
SPACESHIP_CONDA_SHOW=false
SPACESHIP_PYTHON_SHOW=false
SPACESHIP_DOTNET_SHOW=false
SPACESHIP_EMBER_SHOW=false
SPACESHIP_KUBECTL_SHOW=false
SPACESHIP_KUBECTL_VERSION_SHOW=false
#SPACESHIP_KUBECONTEXT_SHOW=false
SPACESHIP_GRADLE_SHOW=false
SPACESHIP_MAVEN_SHOW=false
SPACESHIP_TERRAFORM_SHOW=false
# Execution time of the last command
SPACESHIP_EXEC_TIME_SHOW=false
# Vi mode indicator
SPACESHIP_VI_MODE_SHOW=false

.zshrc:
# The following lines were added by compinstall
zstyle :compinstall filename '$HOME/.zshrc'

autoload -Uz compinit
compinit
# End of lines added by compinstall

source ~/.zsh/spaceship-prompt/spaceship.zsh

What is version of Spaceship are you using?
4.13.1
What is version of Zsh are you using?
zsh 5.9 (x86_64-pc-linux-gnu)
What operation system are you running?
Arch Linux
Do you use any Zsh framework or plugin manager?
No
Which terminal emulator do you use?
kitty
Additional information
No response

After further research I was able to fix the 3 dot thing by adding SPACESHIP_PROMPT_ASYNC=false to the spaceship configuration but there is still the newline issue when I open the terminal. Anyone knows how to fix this?

Duplicate of #1193


Code for plotting the output from -o2

Hi @ChenHuaLab ,
Thanks for developing such powerful software!  I just wonder how to plot the EHH curves from the output from -o2 option, if it possible to share us with the code you used in your mannul?
Thanks for your time and attention!
Best

Thanks for sharing the code!


Terminal setting splitCwd didn´t expect to get prompted in the sourceInitialCwd case

Testing #62096 on Windows
I have a multi-root workspace setup and set the setting to sourceInitialCwd.

I did not expect that I have to select the root in this case, I was assuming it takes cwd of the first terminal that opened.

@egamma, your assumption is correct! I can't reproduce this though. What were you doing before this happened?

I can no longer reproduce it, closing.


Return empty object on 204 No Content...

...instead of throwing a syntax error due to attempting to JSON parse ''.
let fetch = require('node-fetch');
fetch('http://httpbin.org/status/204').then(res => res.json()).then(object => {
    console.log(object);
}).catch(error => console.error(error));

Demo: http://runkit.com/dandv/node-fetch-204-no-content
Fixing this would attain compatibility with request and got.
More generally, it would be more tolerant to return an empty object if the response is the empty string (regardless of the status code being 204 or other 2xx).

While I like the idea of an empty object as a JSON response, this moves away from the spec, as they've consciously stayed with throwing an error - IMO it'd be better to stay with the spec for compatibility with native fetch implementations, but if not, should this at least be added as a known difference?

I agree. Plus, there's also the question whether we should return an empty object, or an empty string, or 0, or false: all of which are legitimate JSON types. @bitinn, thoughts?

For me, the best thing is to stick with spec - an example use case I'm dealing with is running tests in JSDOM, but now the interface is different between a native client e.g. Chrome and the server side usage. The same applies to isomorphic-fetch, if it relies on this library, users will account for different responses based on if its a server or client environment, which essentially breaks the concept of isomorphic.

I am asking browser vendors for opinions in the same WHATWG thread. But status quo seems clear at this point, neither native implementation/browser fetch polyfill/spec handle 204 empty response.
We should revert our code to match their behaviour in 2.x releases.

Agreed. I'll prepare a PR.

Thanks very much for the quick response - really appreciate your efforts on this, it's a great polyfill. Cheers!

Fixed in #201.


Error loading script: asymmetric_tiling.py

I got this when I tried loading this script:
Error loading script: asymmetric_tiling.py Traceback (most recent call last):   File "E:\stable-diffusion-webui\modules\scripts.py", line 69, in load_scripts     compiled = compile(text, path, 'exec')   File "E:\stable-diffusion-webui\scripts\asymmetric_tiling.py", line 70     <title>asymmetric-tiling-sd-webui/asymmetric_tiling.py at main · tjm35/asymmetric-tiling-sd-webui</title>                                                                    ^ SyntaxError: invalid character '·' (U+00B7)

Perhaps check that you've downloaded the file correctly? The "line 70" in that error message doesn't resemble any line in the actual asymmetric_tiling.py file, it looks like it has some html in there. The downloaded asymmetric_tiling.py file should only contain this text.

 I appreciate you taking the time. I think what happened was I had accidentally saved the entire github page as the .py file somehow...
Regardless. I've closed this.
Cheers!


Adding a school to VA approved list.

Feature
Why is this feature being added?
This school has just been approved to accept the Gi Bill so trying to help get the word out.
What should your feature do?
Show the school info and logo.
http://vschool.io/
Logo : http://coursework.vschool.io/content/images/2016/10/v-school-abbreviated-coursework-logo.jpg
Name: V School
Location: Salt Lake City, Ut
GI Bill Accepted: Yes
Commitment: Full Time
Hardware Included: No

I told our new member to add this issue; I will adjust if this is not the correct course of action :)

Hello, excited to begin contributing to this group. May I claim this issue?

@dearhakeemdavis Thanks for offering - but the process of adding code schools is mainly back-end work. I'm closing this issue and opening one in our back-end repo:  https://github.com/OperationCode/operationcode_backend/issues/298


Runelite crashes as soon as it opens

I try to open runelite, the loading bar appears saying 0% and it immediately closes again.
I've already tried reinstalling restarting my pc.

All clients are currently down, as well as the RS servers.
https://twitter.com/OldSchoolRS/status/1017360323068792832

Runescape is down...

This was caused by OSRS being down


Fixed dropdown and pagination

Fixed initialisation of dynamic content in drop down. it had an issue
when rendering dynamic content in drop down.
e.g.
<a class='dropdown-button btn' href='javascript:void(0);'
data-activates='demoDropdown' dropdown data-hover="true">
    {{ dynamic_content }}
</a>

it renders nothing initially. I moved $compile inside $timeout to fix the
issue.
--
Fixed ulClass of pagination. Now the directive accepts object, string.
ulClass is not mandatory.

When I checkout your version, I get this error in index.html:
http://i.imgur.com/odIBFK9.png
From what I understand, it happens because angular is trying to set up a 2-way binding for ulClass. But ulClass isn't defined on the directive (because there is no ulClass attribute defined on the pagination tag), so angular therefore cannot setup the 2-way binding.
That is why I suggested to use "=?" here: https://github.com/krescruz/angular-materialize/commit/67c439d0726a7d39a023b30c98c38e7486498ed3.
Don't you have the error in my screenshot when there is no ulClass attribute on the pagination tag?

Nope. Probably because I used 1.4.3. I am gonna check the older versions then create a new pull request.

Hi @webbiesdk , please check commit a72cbaf8b58abc97ef912539ff73acde28a503c2. I have tested the pagination directive with 1.2., 1.3. and 1.4.*.

Nice work.


code coverage wiki

We should add a wiki page describing the VS-code-coverage integration of PSharpTester.

Its all there in the wiki now.


ODataClient.ClearMetadataCache() doesnt work

HI,
I have a requirement of forcing the metadata to be updated after specific intervals. I have tried:
`
if(expired== true)
{
ODataClient.ClearMetadataCache();
}
await client.InsertEntryAsync("entity", data);//i expect this to call metadata first if the cache has been cleared
`
In above code it never call the metadata even if the ClearMetadataCache method has been called.
Regards,
Ali

Hi,
I tested this scenario and apparently metadata will be renewed once a new session created, i.e. you will need to create another instance of ODataClient. But the instance that is already running will continue using previously obtained metadata document. Do you have an option to renew ODataClient instance after you clear metadata cache?

Hi,
I have tried assigning null to the client and then re-initiating it but it still did not make a call for metadata.
Ali
Sent from my iPhone
On 24 Apr 2017, at 1:05 am, Vagif Abilov <notifications<EMAIL_ADDRESS>wrote:
Hi,
I tested this scenario and apparently metadata will be renewed once a new session created, i.e. you will need to create another instance of ODataClient. But the instance that is already running will continue using previously obtained metadata document. Do you have an option to renew ODataClient instance after you clear metadata cache?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/object/Simple.OData.Client/issues/394#issuecomment-296441977, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQXHnLBXt6GYFwfI2kBNosmj_i-ycjMYks5ry0x0gaJpZM4NBQH3.

I wrote and ran the following test:
        // Use Fiddler to inspect metadata requests
        // Should read metadata prior this call
        var client = CreateClientWithDefaultSettings();
        await client.FindEntriesAsync("Products");
        // Should not read metadata prior this call
        await client.FindEntriesAsync("Products");

        ODataClient.ClearMetadataCache();
        // Should not read metadata prior this call
        await client.FindEntriesAsync("Products");

        client = CreateClientWithDefaultSettings();
        ODataClient.ClearMetadataCache();
        // Should read metadata prior this call
        await client.FindEntriesAsync("Products");

And it worked as expected: once I created a new instance of ODataClient, it requested a new copy of metadata after I invoked ClearMetadataCache.
Do you have similar code?

Yes, this code works fine. It seems like i was not calling ODataClient.ClearMetadataCache(); after initialising it.


Build custom dataset to fine-tune Wav2Vec2

Thank you for your recent tutorial on how to finetune Wav2Vec2 on a custom dataset. The example you gave here (https://huggingface.co/blog/fine-tune-xlsr-wav2vec2) was on the CommonVoice dataset. However, what if I want to load my own dataset?  I have a manifest (transcript and their audio files) in a JSON file.

@lhoestq - We could simply use the "general" json dataset for this no?

Sure you can use the json loader
data_files = {"train": "path/to/your/train_data.json", "test": "path/to/your/test_data.json"}
train_dataset = load_dataset("json", data_files=data_files, split="train")
test_dataset = load_dataset("json", data_files=data_files, split="test")

You just need to make sure that the data contain the paths to the audio files.
If not, feel free to use .map() to add them.

Many thanks! that was what I was looking for.


[2.0]: Weird focus state shown when pressing Esc on Styles & Variables options modal

When pressing Esc on the styles & variables options modal we put focus on the whole modal it seems. That modal has a default focus style, let's change it to the 2px accent colored outline.
https://github.com/tokens-studio/figma-plugin/assets/4548309/88f28ab0-0666-4f5c-b824-31a950d50b94

Added to Featurebase Roadmap as a known issue to avoid duplicate reporting in beta testing results -	❖ ❇ New styles and variables options menu


For a particular instance, only add the referrer to XDM on the first sendEvent.

Description
For a particular instance, only add the referrer to XDM on the first sendEvent.

Related Issue
https://jira.corp.adobe.com/browse/PDCL-8762

Motivation and Context
AppMeasurement only sends the referrer once. The reports in the legacy Analytics are getting inflated by the extra referrers.

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Improvement (non-breaking change which does not add functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA or I'm an Adobe employee.
[x] I have made any necessary test changes and all tests pass.
[x] I have run the Sandbox successfully.

Closing this PR as Target needs the referrer on every request. We'll have to do something else to fix this issue.


NFL teams proper abbreviations are not all properly working to pull data

Describe the bug
I was trying to get the full city and names of the AFC West NFL teams. I used .name using the proper teams abbreviations such as 'KAN'. For KAN it successfully returned Kansas City Chiefs, and for DEN it successfully returned Denver Broncos.
That being said, when I used 'LAC' and 'LVR' for the Chargers and Raiders, I was presented with the same essential error for each - KeyError: 'LAC'  for the chargers and KeyError: 'LVR' for the Raiders
To Reproduce
`from sportsipy.nfl.teams import Team
teamName1 = Team('KAN')
print(teamName1.name)
teamName2 = Team('DEN')
print(teamName2.name)
teamName3 = Team('LVR')
print(teamName3.name)
teamName4 = Team('LAC')
print(teamName4.name)`
Expected behavior
For LAC I was expecting Los Angeles Chargers to be returned.
For LVR I was expecting Las Vegas Raiders to be returned.
Screenshots and Links
Link showing all the abbreviations uses by sports-reference. https://www.pro-football-reference.com/?__hstc=213859787.2ee56ab6f3498e72bacdf9b5c2a54b3f.1669855801055.1669862008924.1669864536323.3&__hssc=213859787.2.1669864536323&__hsfp=3007689586
Image showing AFC West proper abbreviations

Desktop:

OS: Windows 10
Sportsipy Version: 0.6.0

Additional context
I also noticed that the Los Angeles Rams and the Houston Texans common place abbreviations were not working either. It seems to be that the abbreviation needed is not the one listed on their website or any other website for that matter. That being said I know JAX works and returns Jacksonville Jaguars.

Off the top of my head the Chargers abbreviation is SDG and he Raiders is RAI.

To get a list of abbreviation run the following:
from sportsipy.nhl.boxscore import Boxscore game = Boxscore('202210120CAR') game.dataframe
Output:
KAN Kansas City Chiefs PHI Philadelphia Eagles DAL Dallas Cowboys BUF Buffalo Bills CIN Cincinnati Bengals DET Detroit Lions SEA Seattle Seahawks MIN Minnesota Vikings MIA Miami Dolphins RAI Las Vegas Raiders SFO San Francisco 49ers JAX Jacksonville Jaguars CLE Cleveland Browns SDG Los Angeles Chargers ATL Atlanta Falcons RAV Baltimore Ravens NWE New England Patriots CRD Arizona Cardinals CHI Chicago Bears NYG New York Giants GNB Green Bay Packers NOR New Orleans Saints NYJ New York Jets CAR Carolina Panthers WAS Washington Commanders OTI Tennessee Titans PIT Pittsburgh Steelers TAM Tampa Bay Buccaneers CLT Indianapolis Colts HTX Houston Texans RAM Los Angeles Rams DEN Denver Broncos


Support multiple schemas

When multiSchema is enabled, it's possible to have tables of the same name in different schemas. Right now, prisma-kysely will export the DB interface with duplicate properties.
It would be great to namespace the tables with their schema, such as my_other_schema.example_table. (This is what kysely-codegen does.)

Same here, this is a big blocker for me because I have to go in manually after each generation and update the schemas

https://github.com/valtyr/prisma-kysely/pull/110 fixes this!


Changing default search engine requires clearing browser storage

When a library set defaultSearch it is saved in browser storage.
If they make a change they must ask all users to clear their browsers to see this take effect

This was addressed in PR#87.  Installing the most current version should resolve this one.


New Virtual Keyboard, WiFi Module Page and ELRS Backpack Page

Introduces a virtual keyboard used to configure text fields within the wifi module configuration page.
Refactors Page Connections and breaks them apart into their respective pages (ELRS Backpack, WiFi Module)
Deprecates ssid.txt and allows for complete configuration of wifi module via User Interface.
WiFi Page contains all required options to manage the WiFi Module.
All scripts are auto-generated from the WiFi Module Page upon creation and modification.  The only script referenced is the wlan_stop.sh script which was renamed from wlan_stop_ap.sh as it applies to both modes of operation.
New Virtual Keyboard Interface:

Keyboard for entering input text fields.

Left Click Enables/Disables keyboard when text input is highlighted
Scroll Wheel highlights a key
Right Short Click confirms/presses highlighted key
Right Long Click clears text entry.

New WiFi Module Interface:

Paging through WiFI configurations (Basic/Advanced).

Basic Configuration:

Enable/Disable WiFi Module
Specify mode of operation: Host (Access Point) or Client (Join Network)
Unique SSID and Password for both Host and Client modes of operation.
Apply Settings
Return Back to Main Menu

Advanced Configuration:

DHCP Client enable/disable (Only Applies to Client Mode)
Ip Address - Applies to both modes
Netmask - Applies to both modes
Gateway - Applies to both Modes
DNS Server - Applies to both Modes

For a comprehensive list of features I have uploaded 2 videos (Demo 1 and 2).
Demo 1:
https://youtu.be/wiCCv1Q3zlM
Demo 2:
https://youtu.be/krB9vMg_SVE

When DHCP on is to hide address, netmask and other options, what do you think?

When DHCP on is to hide address, netmask and other options, what do you think?

Those fields are also used for configuring Host (Access Point) mode and for Client (Join Network) mode.  When DHCP is on, the request includes the  IP Address, if no other device on the network is using that ip address then it will be used, otherwise a unused address will be assigned.  It's a nice option because you may have a configured range where you still want to use dhcp but be able to specify an address for consistency.


Fix Rogue action bars not switching in combat.

Add a check for combat and drop overriding the StanceBar_Update function.

Thanks! 👍

It's nice to go to bed with a bug report, and then wake up with a ready fix 😄


ESP32IOBoard Example Compile Error

Hi
I tried to compile the ESP32IOBoard example from the Arduino V2.0.0 library but I am getting the errors shown below.
Sorry if I am just doing something wrong.
In file included from C:\Users\User\Documents\Arduino\libraries\OpenMRNLite\src/freertos_drivers/arduino/PWM.hxx:37,
from C:\Users\User\Documents\Arduino\libraries\OpenMRNLite\src\freertos_drivers\esp32\Esp32Ledc.hxx:38,
from C:\Users\User\Documents\Arduino\libraries\OpenMRNLite\src\freertos_drivers\esp32\Esp32Ledc.cpp:42:
C:\Users\User\Documents\Arduino\libraries\OpenMRNLite\src\freertos_drivers\esp32\Esp32Ledc.hxx: In member function 'void openmrn_arduino::Esp32Ledc::fade_channel_over_time(unsigned int, uint32_t, uint32_t, ledc_fade_mode_t)':
C:\Users\User\Documents\Arduino\libraries\OpenMRNLite\src\freertos_drivers\esp32\Esp32Ledc.hxx:191:22: error: 'pthread_once' was not declared in this scope; did you mean 'pthread_once_t'?
191 |         HASSERT(0 == pthread_once(&ledcFadeOnce_, &Esp32Ledc::ledc_fade_setup));
|                      ^~~~~~~~~~~~
C:\Users\User\Documents\Arduino\libraries\OpenMRNLite\src/utils/macros.h:97:31: note: in definition of macro 'HASSERT'
97 | #define HASSERT(x) do { if (!(x)) { printf("Assertion failed in file " FILE " line %d: assert(%s)\n", LINE, #x); g_death_file = FILE; g_death_lineno = LINE; assert(0); abort();} } while(0)
|                               ^
C:\Users\User\Documents\Arduino\libraries\OpenMRNLite\src\freertos_drivers\esp32\Esp32Ledc.cpp: At global scope:
C:\Users\User\Documents\Arduino\libraries\OpenMRNLite\src\freertos_drivers\esp32\Esp32Ledc.cpp:47:43: error: 'PTHREAD_ONCE_INIT' was not declared in this scope; did you mean 'OS_THREAD_ONCE_INIT'?
47 | pthread_once_t Esp32Ledc::ledcFadeOnce_ = PTHREAD_ONCE_INIT;
|                                           ^~~~~~~~~~~~~~~~~
|                                           OS_THREAD_ONCE_INIT
In file included from C:\Users\User\Documents\Arduino\libraries\OpenMRNLite\src/os/OS.hxx:40,
from C:\Users\User\Documents\Arduino\libraries\OpenMRNLite\src/executor/Notifiable.hxx:39,
from C:\Users\User\Documents\Arduino\libraries\OpenMRNLite\src\freertos_drivers\esp32\Esp32HardwareTwai.cpp:75:
C:\Users\User\Documents\Arduino\libraries\OpenMRNLite\src\freertos_drivers\esp32\Esp32HardwareTwai.cpp: In member function 'void openmrn_arduino::Esp32HardwareTwai::hw_init()':
C:\Users\User\Documents\Arduino\libraries\OpenMRNLite\src\freertos_drivers\esp32\Esp32HardwareTwai.cpp:1008:26: error: too few arguments to function 'bool twai_hal_init(twai_hal_context_t*, const twai_hal_config_t*)'
1008 |     HASSERT(twai_hal_init(&twai.context));
|             ~^~~
C:\Users\User\Documents\Arduino\libraries\OpenMRNLite\src/utils/macros.h:97:31: note: in definition of macro 'HASSERT'
97 | #define HASSERT(x) do { if (!(x)) { printf("Assertion failed in file " FILE " line %d: assert(%s)\n", LINE, #x); g_death_file = FILE; g_death_lineno = LINE; assert(0); abort();} } while(0)
|                               ^
In file included from C:\Users\User\Documents\Arduino\libraries\OpenMRNLite\src\freertos_drivers\esp32\Esp32HardwareTwai.cpp:69:
C:\Users\User\AppData\Local\Arduino15\packages\esp32\tools\esp32-arduino-libs\idf-release_v5.1-442a798083\esp32/include/hal/include/hal/twai_hal.h:87:6: note: declared here
87 | bool twai_hal_init(twai_hal_context_t *hal_ctx, const twai_hal_config_t *config);
|      ^~~~~~~~~~~~~
exit status 1
Compilation error: exit status 1

Add this line:
#include <pthread.h>`

After this line and it should fix it.
We'll get a fix synced in for this.

Yes, great, that has fixed the first error. I still have the below error in Esp32HardwareTwai.cpp
In file included from C:\Users\User\Documents\Arduino\libraries\OpenMRNLite\src/os/OS.hxx:40,
from C:\Users\User\Documents\Arduino\libraries\OpenMRNLite\src/executor/Notifiable.hxx:39,
from C:\Users\User\Documents\Arduino\libraries\OpenMRNLite\src\freertos_drivers\esp32\Esp32HardwareTwai.cpp:75:
C:\Users\User\Documents\Arduino\libraries\OpenMRNLite\src\freertos_drivers\esp32\Esp32HardwareTwai.cpp: In member function 'void openmrn_arduino::Esp32HardwareTwai::hw_init()':
C:\Users\User\Documents\Arduino\libraries\OpenMRNLite\src\freertos_drivers\esp32\Esp32HardwareTwai.cpp:1008:26: error: too few arguments to function 'bool twai_hal_init(twai_hal_context_t*, const twai_hal_config_t*)'
1008 |     HASSERT(twai_hal_init(&twai.context));
|             ~^~~
C:\Users\User\Documents\Arduino\libraries\OpenMRNLite\src/utils/macros.h:97:31: note: in definition of macro 'HASSERT'
97 | #define HASSERT(x) do { if (!(x)) { printf("Assertion failed in file " FILE " line %d: assert(%s)\n", LINE, #x); g_death_file = FILE; g_death_lineno = LINE; assert(0); abort();} } while(0)
|                               ^
In file included from C:\Users\User\Documents\Arduino\libraries\OpenMRNLite\src\freertos_drivers\esp32\Esp32HardwareTwai.cpp:69:
C:\Users\User\AppData\Local\Arduino15\packages\esp32\tools\esp32-arduino-libs\idf-release_v5.1-442a798083\esp32/include/hal/include/hal/twai_hal.h:87:6: note: declared here
87 | bool twai_hal_init(twai_hal_context_t *hal_ctx, const twai_hal_config_t *config);
|      ^~~~~~~~~~~~~
exit status 1
Compilation error: exit status 1

You are running with Arduino-3.0.x which is not currently supported by the OpenMRNLite code, there should be an updated version in the near future to support 3.0.x versions.
For now I'd suggest downgrade to Arduino-esp32 2.0.17 (latest in the 2.0.x line). Keep the update for pthread.h and you shouldn't face any issues.

I did as you suggested and downgraded. It now compiles and works great. Thanks for your help.


feat: Make SQLConnector _connect function public

Feature scope
Taps (catalog, state, stream maps, tests, etc.)
Description
The function here https://github.com/meltano/sdk/blob/0285704e71dd9bce573c8c518b8ce3287943ce94/singer_sdk/connectors/sql.py#L82-L85
I'd like to change to the name connect as we use this in different taps.
See

https://github.com/MeltanoLabs/tap-postgres/blob/5723435f8646f799edff51099fd474b97afb19df/tap_postgres/client.py#L305
https://github.com/MeltanoLabs/tap-mysql/blob/c84d384ac8cddb2defbf1889128ba1bbdadf3549/tap_mysql/client.py#L68

Thanks @visch!
I think the "private" _connect() method is only an issue if you use it outside of the SQLConnector implementation. For example, here: https://github.com/MeltanoLabs/tap-mysql/blob/c84d384ac8cddb2defbf1889128ba1bbdadf3549/tap_mysql/client.py#L427.
It hints that something should be implemented in MySQLConnector connector, for example.
Note this was introduced in https://github.com/meltano/sdk/pull/1394 to ensure there's a single entry point for handling the connection object: https://github.com/meltano/sdk/issues/1393.

I'm probably missing something @edgarrmondragon

I think the "private" _connect() method is only an issue if you use it outside of the SQLConnector implementation.
https://github.com/meltano/sdk/blob/0285704e71dd9bce573c8c518b8ce3287943ce94/singer_sdk/streams/sql.py#L209-L217

The SDK does it too.
What triggered this for me is the linter told me I should so I added https://github.com/MeltanoLabs/tap-mysql/blob/c84d384ac8cddb2defbf1889128ba1bbdadf3549/tap_mysql/client.py#L428
2 and it seemed weird to do that.
We can just close and I can ignore it 🤷

No worries. We might end up doing this anyway if https://github.com/meltano/sdk/pull/1649 is shipped, or at least its Connector interface definition.


How to deal with variants of type "substitution"?

Hi @PoisonAlien.
I've see in the script annovarToMaf.R (it's the only one where I could find something about this kind of variant) that substitutions are initially classified as Inframe_INDEL and then as In_Frame_Del/Ins according length difference between REF and ALT alleles...
My problem is that these variants are like this:
   Reference_Allele Tumor_Seq_Allele1
 1:               GG                AA
 2:               GC                AA
 3:               CA                GG
 4:               TG                AA
 5:               AA                TG
 6:               CA                AT

So, I guess this criteria based on the difference isn't the best method, any idea to deal with this? Or do you have another experience with this kind of mutations?
Thanks a lot for your help!

Hi,
I have not come across these double nucleoatide polymorphisms in annovar. In MAF these are usually annotated as DNP/MNP. Can you check how these things are called in annovar output ?

Hi,
I'm having a similar issue. These are classified as substitutions in annovar and hence are not included in the final maf when converting from annovar to maf. These are some examples:
119915546 | 119915546 | A | AT | exonic | NOTCH2 | frameshift substitution
119915806 | 119915811 | ATTGTG | AAAAAAG | exonic | NOTCH2 | frameshift substitution
119915811 | 119915811 | A | GGG | exonic | NOTCH2 | frameshift substitution
119915887 | 119915887 | C | CGTGC | exonic | NOTCH2 | frameshift substitution
119916258 | 119916259 | TC | T | exonic | NOTCH2 | frameshift substitution
177038386 | 177038389 | CAAG | C | exonic | TBL1XR1 | nonframeshift substitution
137876041 | 137876042 | TG | CC | exonic | TNFAIP3 | nonframeshift substitution
137877134 | 137877136 | TCA | T | exonic | TNFAIP3 | frameshift substitution
136496196 | 136496198 | CAG | C | exonic | NOTCH1 | frameshift substitution
136496196 | 136496198 | CAG | C | exonic | NOTCH1 | frameshift substitution
136496196 | 136496198 | CAG | C | exonic | NOTCH1 | frameshift substitution
136496196 | 136496198 | CAG | C | exonic | NOTCH1 | frameshift substitution
136496196 | 136496198 | CAG | C | exonic | NOTCH1 | frameshift substitution
136496196 | 136496198 | CAG | C | exonic | NOTCH1 | frameshift substitution
136496196 | 136496198 | CAG | C | exonic | NOTCH1 | frameshift substitution
136496196 | 136496198 | CAG | C | exonic | NOTCH1 | frameshift substitution
136496912 | 136496913 | AG | A | exonic | NOTCH1 | frameshift substitution
116596227 | 116596227 | A | AC | exonic | PNLIPRP1 | frameshift substitution
102336953 | 102336954 | AC | A | exonic | BIRC3 | frameshift substitution
108247024 | 108247024 | A | ATGAG | exonic | ATM | frameshift substitution
49049883 | 49049883 | A | AC | exonic | KMT2D | frameshift substitution
3731322 | 3731325 | AAGG | A | exonic | CREBBP | nonframeshift substitution
16325899 | 16325899 | G | GGA | exonic | KLF2 | frameshift substitution
16325907 | 16325919 | AGCGCGGCCGCCG | A | exonic | KLF2 | nonframeshift substitution
153772920 | 153772921 | GC | G | exonic | PLXNB3 | frameshift substitution

Hi @cjo1n15 ,
Would it possible to share an example file?

Dear @PoisonAlien ,
I have known annovarToMaf could not handle MNPs for a while. It would be treated as SNPs, which can induce errors into TiTv and so on.
Perhaps we should split MNPs into SNPs, using vt decompose_blocksub.
If you don't mind, I have sent an example VCF with MNPs to you by e-mail.
Best regards.

Hello @Chitanda-Satou ,
Apologies for the late reply. Could you please send it in tabular format? As outputted from Annovar post annotation.

@PoisonAlien
Sorry for my mistake. I have sent a file in TXT format to your e-mail.
Best regards.

Hello @Chitanda-Satou ,
Sorry it took while. I have fixed it, could you please try and let me know?
Now such weird variants are annotated as MNP and Unknown for Variant_Type and Variant_Classification respectively.

Great work @PoisonAlien !
Fix a big problem to me.  Thanks a lot !


Attn layers to use

Thanks for your great work. I have one question on the attention layers.
In the supplementary of the paper, it is mentioned that the middle layers exhibit a superior semantic.
But in the code, it seems that the layers in the up blocks are used. Does it means the code should be modified to be consistent with the paper results? Thanks.

Thank you for your interest.
No the code is correct and by middle layers we do not mean exactly middle layers, instead we mean those which are not at the end or beginning.

Thanks! I misunderstood that.

Hi, sorry to bother again.
I am curious about the size of test split in this work. For example, in Tab.2 and 3, the performances of SLiMe on 1-sample/10-sample settings are shown, and how many car and horse samples are used for test?
Thank you very much!

All the test images in the Pascal VOC dataset

Thanks!


Skip test that crashes due to invalid input

Fix a test that fails since todoman crashes attempting to process and invalid ICS file.
Actually just skip this scenario, since crashing when processing broken input is probably the best we can do (and what we do in almost any other similar scenario).

This fixes master, which is once again broken due to upstream changes (though upstream didn't actually break stuff this time).
I've also set travis to run on a daily basis, if no there have been no runs for 24 hours. This should help catch these things faster.

Codecov Report

Merging #308 into master will decrease coverage by 0.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
- Coverage     100%   99.57%   -0.43%
==========================================
  Files           9        9
  Lines        1163     1163
==========================================
- Hits         1163     1158       -5
- Misses          0        5       +5

Impacted Files
Coverage Δ

todoman/model.py
98.92% <0%> (-1.08%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a808273...3c2c7c2. Read the comment docs.

Triggering CI, which got stuck.

Looks like there's a slight coverage drop that should be looked into. Not sure if it's now-dead code, or if it's only reached with dirty input and needs to be re-evaluated.


Firefox webExt

Hi ! Still didn't have time to try this, but since Firefox now support WebExtension could this be used as it is in as a firefox extension ?

I'm not familiar with how the Firefox APIs work/layout of their apps, but I'm assuming not. But that makes me wonder how difficult it would be to write an adapter interface that allows you to write FF and Chrome extensions.

@julienR2 @vhmth Surprisingly, it seems to work out of the box! You can load the example repo no problem.
Just be careful the rest of your extension is compatible with the supported APIs:
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Porting_a_Google_Chrome_extension


rclone sync - failed to open source object

I'm currently having some problems with rclone sync from one gdrive to another gdrive.
I get "Failed to copy: failed to open source object: bad response: 403: 403 Forbidden"
Ubuntu 15.10
Rclone V1.34-Dev
rclone sync gdrive1:Stuff gdrive2:Stuff
Is this a rate limit exceeding issue? Or something else?

Also errors when trying to play from plex.   If you want a bit it will start working again.


Show the title of the website when hovering a link.

Would it be possible to pull titles from webpages when you hover over a link in Chatterino 2?
Like when go over a emote it brings up a text overlay.
Edit: Maybe also add a thumbnail preview of the page when you hover over a link.

Definitely shouldn't be the default as some users don't want that the server hosts know their ip and other metadata about them

An acceptable compromise would be only trying to get the title from known websites. A whitelist. Probably number 1 would be YouTube as I see it having the most value.

@pajlada close this?

Already implemented. Setting exists under General > Miscellaneous > Show link info when hovering

For future users, this option was moved under General > Link Information > Enable :)


The circle animation is not invisible

A' viewcontroller has a circle refresh , if you push to B and back to A, the A'cicle is not invisible.
My English is poor,so i want to you can get my mean!

I find this. http://stackoverflow.com/questions/12413459/why-cant-i-set-the-opacity-of-a-layer-after-a-cabasicanimation-finished
animationGroup.removedOnCompletion = NO;maybe is userful.

hey man ,the circle load also have this problem.you also should fix it.

Done thanks


Use cargo-hack to test all feature combinations

See individual commits:

Use actions-rs/toolchain to install rust
Use actions-rs/cargo to invoke cargo/cross
Use cargo-hack to test all feature combinations

Thanks, I didn't realize that. Done.


Alarm Registration Point of Contact Username Insufficient

Many alarms contain corrective actions that have a decision tree on who to contact.   However, the point of contact username field only suggests one person.   A related issue is that often the one contact is a group name, not a specific username.  Examples:

EES-IC
EES-DC
SSG
INJ On-Call

Fixed by replacing AlarmClass.pointofcontactusername with AlarmCategory.team in v4.13.1


Does ThinkTwice have Evaluation on Carla Leaderboard?

In paper, the method is evaluated on Town05 Long, however most of End-End method may report the eval result on Carla Leaderboard. So I want to know does ThinkTwice have evaluation on Carla Leaderboard?

Thanks for your interests. Due to the complex environment dependency, we do not have a result currently. We will try it when we have bandwidth.

Thanks for your replay. I find the time cost is so large no matter the collection or the evaluation on Carla, could you provide some useful method to accelerate this process?

Yes, this is why we do not run 3 runs in Longest6.  As mentioned in docs/DATA_PREP.md, you could collect small images directly (remeber to change their cooresponding intrinsics).  Also, we observe that Lidar could make Carla run significantly slower. Thus, you could try to develop a camera-only model.
Note that compared to nuScenes (1000 scences * 20s), the normal size of Carla dataset (189K in TCP/ThinkTwice) is much larger. Thus, you may try to start with our ckeckpoint to initialize your backbone to reduce the difficulty of perception part.
Hope it could be helpful.

@jiaxiaosong1002 Hi, thanks for your excellent work. Because of the huge size of Carla dataset. It's challenging to follow your work. We want to do research on camera-only models, so would you please provide a baseline (189K frames) on a 4C model without lidar?

Thanks for your interests. Currently, we do not have bandwidth/computational power to train/tune a new model.  Maybe you could consider load the weights of the checkpoint to a camera-only model and then finetune it, which could be easier.

Thanks for your interests. Currently, we do not have bandwidth/computational power to train/tune a new model. Maybe you could consider load the weights of the checkpoint to a camera-only model and then finetune it, which could be easier.

Thank you for quickly reply. I will try it！

Thanks for your interests. Currently, we do not have bandwidth/computational power to train/tune a new model. Maybe you could consider load the weights of the checkpoint to a camera-only model and then finetune it, which could be easier.

Hi, sorry to bother you. I have another question. How long does it take to generate 189k data?

@exiawsh
When we collected data, we use ~80 processes for about 1 week to collect 2 million frames in total. You could do the calculation. Note that the removement of Lidar might significantly increase speed.
Another advice is that you could first only collect data from Town01, Town03, Town04, and Town06 for training as in Appendix B Table 1 of TCP, since the open-loop metric on validation set is not really related to the closed-loop evaluation results. As a result, you could approximately half the needed data.
For your information, when current_throttle_brake_offset < 0.1 and current_longitudinal_offset < 0.2 in training set, we consider the model fits the training set enough. Again, it is still not highly related to the closed-loop evaluation results.

@exiawsh When we collected data, we use ~80 processes for about 1 week to collect 2 million frames in total. You could do the calculation. Note that the removement of Lidar might significantly increase speed.
Another advice is that you could first only collect data from Town01, Town03, Town04, and Town06 for training as in Appendix B Table 1 of TCP, since the open-loop metric on validation set is not really related to the closed-loop evaluation results. As a result, you could approximately half the needed data.
For your information, when current_throttle_brake_offset < 0.1 and current_longitudinal_offset < 0.2 in training set, we consider the model fits the training set enough. Again, it is still not highly related to the closed-loop evaluation results.

Thanks for your patient answer! I will try it!

@exiawsh When we collected data, we use ~80 processes for about 1 week to collect 2 million frames in total. You could do the calculation. Note that the removement of Lidar might significantly increase speed.
Another advice is that you could first only collect data from Town01, Town03, Town04, and Town06 for training as in Appendix B Table 1 of TCP, since the open-loop metric on validation set is not really related to the closed-loop evaluation results. As a result, you could approximately half the needed data.
For your information, when current_throttle_brake_offset < 0.1 and current_longitudinal_offset < 0.2 in training set, we consider the model fits the training set enough. Again, it is still not highly related to the closed-loop evaluation results.

Hi, would you please share the scripts to generate the date using multi-processing? Thanks a lot!

@exiawsh
We collect our data in a cluster with slurm approximately one year ago.  I give the picture of the scripts as following:

You could write your own script with some minor modification.


Error WebSocket connection 3000

Description of the bug:
I'm using the app inside a docker container with the port setting 8042:3000, since I'm using port 3000. I also use Ngnx Proxy Manager and access the app from bot.mydomain.com.
In the web console I get the following error:
WebSocketClient.js:13 WebSocket connection to 'wss://bot.mydomain.com:3000/ws' failed:
WebSocketClient @ WebSocketClient.js:13
I can't find where to change the port settings.
Actual vs expected behavior:
No response
Any other information you'd like to share?
No response

I am sorry if this will not be useful, and I will waste your time, but I am just a stranger and wanted to add my 0.02 cents.
I packed the repo into one file using repopack, added it into AiStudio, then pasted your issue and got the following response from Gemini Experimental 1206 (Hope you find it helpful):
The issue is that the WebSocket connection is attempting to use port 3000 within the browser, even though you've mapped the container's port 3000 to port 8042 on your host and are using Nginx Proxy Manager to route traffic. The browser is unaware of this port mapping and Nginx configuration.
Here's a breakdown of the problem and the solution:
Problem:

Hardcoded Port (Implicit): The application likely implicitly assumes that if it's served from a domain, the WebSocket should connect on the standard HTTPS port (443), unless a port is specifically mentioned in the url. Because you access it via bot.mydomain.com which does not have a port specified, it defaults to 443. However, your WebSocket server is actually running on a different port (due to docker mappings).

Nginx Proxy Manager: While Nginx is correctly forwarding HTTP traffic, it's not configured to handle the WebSocket upgrade request to your desired port. The initial HTTP request succeeds, but the subsequent WebSocket connection on a different port fails.

Solution:
The solution involves making the WebSocket URL (including the port) configurable and then properly configuring Nginx Proxy Manager to forward WebSocket traffic.

Make WebSocket URL Configurable:

Environment Variable: The simplest approach is to introduce an environment variable that controls the WebSocket URL, including the port.

Modify App.tsx:
// ... other imports ...
const API_KEY = process.env.REACT_APP_GEMINI_API_KEY as string;
if (typeof API_KEY !== "string") {
  throw new Error("set REACT_APP_GEMINI_APIK_KEY in .env");
}

// Get the base WebSocket URL from an environment variable, or default to the current host
const WEBSOCKET_BASE_URL = process.env.REACT_APP_WEBSOCKET_BASE_URL || `wss://${window.location.host}`;

const host = "generativelanguage.googleapis.com";

// Construct the final URL using the base URL
const uri = `${WEBSOCKET_BASE_URL}/ws/google.ai.generativelanguage.v1alpha.GenerativeService.BidiGenerateContent`;

function App() {
// ... rest of the component ...

Create or Modify .env:
Add the following line to your .env file, which will set the default behavior of using the host from the URL (what you usually want when not using docker or when using a reverse proxy):
REACT_APP_WEBSOCKET_BASE_URL=wss://bot.mydomain.com

When running locally without docker, you can use:
REACT_APP_WEBSOCKET_BASE_URL=ws://localhost:3000

Configure Nginx Proxy Manager:

WebSocket Support: In your Nginx Proxy Manager UI, go to the configuration for your bot.mydomain.com host. In the "Advanced" tab, add the following custom location block:
location /ws {
    proxy_pass http://your_docker_container_ip_or_name:8042; # Replace with your container's IP or name
    proxy_http_version 1.1;
    proxy_set_header Upgrade $http_upgrade;
    proxy_set_header Connection "Upgrade";
    proxy_set_header Host $host;
}

Important:

Replace your_docker_container_ip_or_name with the actual IP address or the Docker container name of your application. If you're using Docker Compose, you can often use the service name defined in your docker-compose.yml file.
Ensure that port 8042 is correctly mapped in your docker-compose or docker run configuration to the internal port of your application inside the container.

Explanation:

Environment Variable: By using an environment variable, you can change the WebSocket URL without rebuilding the React application. This allows you to easily switch between different environments (development, production, Docker, etc.).
Nginx location /ws Block:

proxy_pass: This directive forwards requests that start with /ws to your application running inside the Docker container on port 8042.
proxy_http_version 1.1: Sets the HTTP version for proxying to 1.1, which is needed for WebSocket.
proxy_set_header Upgrade $http_upgrade: This header tells the backend server that the client is trying to upgrade to a WebSocket connection.
proxy_set_header Connection "Upgrade": This header maintains the "Upgrade" connection type.
proxy_set_header Host $host: Forwards the original host header to the backend.

Steps:

Update App.tsx as shown above.
Add or update your .env file.
Rebuild your React app if necessary (npm run build).
Update your Nginx Proxy Manager configuration as described.
Restart your Docker container and Nginx Proxy Manager.

ViaAnthroposBenevolentia

Thanks for the help!
I tried both options but unfortunately they didn't work, it keeps throwing the same error "WebSocketClient.js:13 WebSocket connection to 'wss://mmbot.wis.ar:3000/ws' failed: "


[release-4.14] OCPBUGS-23490: Remove blockage of ConfigObserver by build informer has synced flag

This is manual cherry-pick of https://github.com/openshift/cluster-openshift-controller-manager-operator/pull/315

/cc @ingvagabund

/label backport-risk-assessed

/approve

/jira refresh

/lgtm

@jitendar-singh could you please add cherry-pick-approved label?. Thanks.

/label cherry-pick-approved
/label backport-risk-assessed


VScode workspaces does not show up

Microsoft PowerToys version
0.55.1
Running as admin

[ ] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce
Install latest insiders version of vscode and try to open workspace. The location of workspaces has changed: https://github.com/microsoft/vscode/pull/139632
✔ Expected Behavior
Recently used workspaces shows up
❌ Actual Behavior
No workspaces shows up, error in log file:
`[2022-01-04 08:57:47.0077] [ERROR] [S:\src\modules\launcher\Plugins\Community.PowerToys.Run.Plugin.VSCodeWorkspaces\WorkspacesHelper\VSCodeWorkspacesApi.cs::104]
-------------------------- Begin exception --------------------------
Message: Failed to deserialize $C:\Users\zalent\AppData\Roaming\Code - Insiders\storage.json
Exception full name  : System.NullReferenceException
Exception message    : Object reference not set to an instance of an object.
Exception stack trace:
at Community.PowerToys.Run.Plugin.VSCodeWorkspaces.WorkspacesHelper.VSCodeWorkspacesApi.get_Workspaces()
Exception source     : Community.PowerToys.Run.Plugin.VSCodeWorkspaces
Exception target site: System.Collections.Generic.List`1[Community.PowerToys.Run.Plugin.VSCodeWorkspaces.WorkspacesHelper.VSCodeWorkspace] get_Workspaces()
Exception HResult    : -2147467261
-------------------------- End exception --------------------------
[2022-01-04 08:58:23.5212] [INFO] [S:\src\modules\launcher\PowerLauncher\ViewModel\MainViewModel.cs::849]
OnHotkey
`
Other Software
Version: 1.64.0-insider (user setup)
Commit: 990ad4044032b05c0ebf0f67f800c5845baad4c7
Date: 2022-01-04T05:18:15.830Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.18363

Could you attach a full bug report file?
Right-click on the tray icon and click Report Bug. Then drag-and-drop the generated file into the GitHub comment to upload it. Thanks!

Install latest insiders version of vscode and try to open workspace. The location of workspaces has changed: microsoft/vscode#139632

Thanks for your infomation!

PowerToysReport_2022-01-04-09-33-32.zip

cc: @ricardosantos9521

I will take a look at this tomorrow.

@ricardosantos9521 this is 0.51.1  so it wouldn't include the two fixes you just did with 0.53.  Do you think 53 has the fix?

@ricardosantos9521 this is 0.51.1  so it wouldn't include the two fixes you just did with 0.53.  Do you think 53 has the fix?

No 53 doesn't have the fix. They moved the opened workspaces from settings.json to Backup/workspaces.json in vscode insiders. This will not impact previous versions or vscode stable until the next release.

Glad to see this already exists. I came to open an issue.
Seems to have broken the behavior between 1.59.0 and 1.64.0 of VSCode Insider

@Aaron-Junker / @stefansjfw Cloud you update the project? Thanks!

done

@stefansjfw Because commit message of 758a21a22fed3d0c9c910c33c866fb90405c6a73 includes fix #15247 so GitHub closed this automatically.
See https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

The was fixed in in 0.55. Head over to https://aka.ms/installpowertoys to try it out


Unify async_capture_span/capture_span common code

What does this pull request do?
Some recent changes have only been implemented in capture_span, while async_capture_span was forgotten. This change should avoid such issues going forward.

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2021-11-29T10:22:38.122+0000

Duration: 31 min 23 sec

Commit: d26a97442f045c87b5268ed8d11d74f770727f3b

Test stats :test_tube:

Test
Results

Failed
0

Passed
10291

Skipped
9537

Total
19828

:green_heart: Flaky test report
Tests succeeded.
:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

/test linters : Run the Python linters only.

/test full : Run the full matrix of tests.

/test benchmark : Run the APM Agent Python benchmarks tests.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)


[#152237982] conduit: service tunnels for all

What
A plugin for creating tunnels to service instances and making it easier to perform database maintaince tasks (such as using psql or mysqldump).
How to review

Read the README for install instructions
Create postgres and mysql service instances in your environment (if you have none)
Try creating a basic tunnel cf conduit your-instance and check that the output instructions are clear enough
Try using some postgres tools (ie psql or pg_dump examples in README)
Try using some mysql tools (ie mysql or mysqldump` examples in README)
OutOfScope/Untested but probably works... try connecting an app that wants VCAP_SERVICES running locally via: cf conduit your-instance-1 your-instance-2 -- /path/to/your_awesome_app
General code reviewage

Notes
Windows support is an unknown at this stage... but may JustWork
Who can review
Not @chrisfarms nor @46bit

In addition to the app space binding to service is taken problem we discussed, I got this when trying to use conduit on PWS through a newly created cleardb service not bound to an app.
$ cf conduit myothermysql123 -- bash
OK Connecting client
OK Targeting space
OK Deploying __conduit_21034__
OK Uploading __conduit_21034__ bits
OK Starting __conduit_21034__
OK Fetching service infomation
OK Binding myothermysql123
Error: json: cannot unmarshal string into Go struct field Credentials.port of type int64
Usage:
  cf conduit [flags] SERVICE_INSTANCE [-- COMMAND]

Examples:
  Create a tunnel between your machine and a remote running service:
  cf conduit my-service

  Run a local application that uses VCAP_SERVICES environment to connect to remote services:
  cf conduit my-service-1 my-service-2 -- /path/to/app

  Export a postgres database:
  cf conduit postgres-instance -- pg_dump -f backup.sql

  Import a postgres script:
  cf conduit postgres-instance -- psql < backup.sql

  Dump a mysql database:
  cf conduit mysql-instance -- mysqldump --all-databases > backup.sql

  Import a mysql script:
  cf conduit mysql-instance -- psql < backup.psql

Flags:
  -h, --help             help for conduit
  -p, --local-port int   start selecting local ports from (default 7080)

Global Flags:
      --app-name string   app name to use for tunnelling app (must not exist) (default "__conduit_21034__")
      --keep-app          speed up multiple invocations of conduit by not destroying the tunnelling app
      --no-interactive    disable progress indicator and status output
      --verbose           verbose output

json: cannot unmarshal string into Go struct field Credentials.port of type int64

I think it's a good idea to avoid shelling out. In the future we could possibly avoid duplicating error handling code etc. by importing packages from the CLI.

If we have time before this will reach user's hands, it'd be great to add some tests. However, if that's going to be at the expense of getting some quick user feedback, I withdraw my statement!

RE: app space binding to service is taken
I have resolved the issue where it wasn't checking the currently targeted space... and also added flags -o and -s for targeting org/spaces directly (handy to copy data out of a db in space1 and into a db in space2).
RE: tests
Yes I agree... I couldn't find a nice way of testing since it's essentially a script that pull together several complex things. I don't think it should block this iteration, but I strongly agree some kind of tests are a must long term. Maybe a series of expected stdout logs and a shell script that tries the example commands in the readme would be a good start.


Error in scheduler_config.json when training on custom model

When training on another model than standard 1.5, i get this error on the train step.
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/diffusers/configuration_utils.py", line 372, in load_config
    config_dict = cls._dict_from_json_file(config_file)
  File "/usr/local/lib/python3.8/dist-packages/diffusers/configuration_utils.py", line 466, in _dict_from_json_file
    return json.loads(text)
  File "/usr/lib/python3.8/json/__init__.py", line 357, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.8/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.8/json/decoder.py", line 353, in raw_decode
    obj, end = self.scan_once(s, idx)
json.decoder.JSONDecodeError: Expecting property name enclosed in double quotes: line 7 column 3 (char 159)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/content/diffusers/examples/dreambooth/train_dreambooth.py", line 823, in <module>
    main()
  File "/content/diffusers/examples/dreambooth/train_dreambooth.py", line 541, in main
    noise_scheduler = DDPMScheduler.from_config(args.pretrained_model_name_or_path, subfolder="scheduler")
  File "/usr/local/lib/python3.8/dist-packages/diffusers/configuration_utils.py", line 193, in from_config
    config, kwargs = cls.load_config(pretrained_model_name_or_path=config, return_unused_kwargs=True, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/diffusers/configuration_utils.py", line 374, in load_config
    raise EnvironmentError(f"It looks like the config file at '{config_file}' is not a valid JSON file.")
OSError: It looks like the config file at '/content/stable-diffusion-custom/scheduler/scheduler_config.json' is not a valid JSON file.
Traceback (most recent call last):
  File "/usr/local/bin/accelerate", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.8/dist-packages/accelerate/commands/accelerate_cli.py", line 43, in main
    args.func(args)
  File "/usr/local/lib/python3.8/dist-packages/accelerate/commands/launch.py", line 837, in launch_command
    simple_launcher(args)
  File "/usr/local/lib/python3.8/dist-packages/accelerate/commands/launch.py", line 354, in simple_launcher
    raise subprocess.CalledProcessError(returncode=process.returncode, cmd=cmd)
subprocess.CalledProcessError: Command '['/usr/bin/python3', '/content/diffusers/examples/dreambooth/train_dreambooth.py', '--image_captions_filename', '--train_only_unet', '--save_starting_step=1000', '--save_n_steps=500', '--Session_dir=/content/gdrive/MyDrive/Fast-Dreambooth/Sessions/magfje+analog', '--pretrained_model_name_or_path=/content/stable-diffusion-custom', '--instance_data_dir=/content/gdrive/MyDrive/Fast-Dreambooth/Sessions/%token%/instance_images', '--output_dir=/content/models/%token%', '--instance_prompt=', '--seed=421217', '--resolution=512', '--mixed_precision=fp16', '--train_batch_size=1', '--gradient_accumulation_steps=1', '--gradient_checkpointing', '--use_8bit_adam', '--learning_rate=2e-6', '--lr_scheduler=polynomial', '--lr_warmup_steps=0', '--max_train_steps=2500']' returned non-zero exit status 1.
Something went wrong

In stable-diffusion-custom/scheduler/scheduler_config.json there is an extra comma that is the issue.
{
  "_class_name": "PNDMScheduler",
  "_diffusers_version": "0.10.0.dev0",
  "beta_end": 0.012,
  "beta_schedule": "scaled_linear",
  "beta_start": 0.00085,
  ,
  "num_train_timesteps": 1000,
  "prediction_type": "epsilon",
  "set_alpha_to_one": false,
  "skip_prk_steps": true,
  "steps_offset": 1,
  "trained_betas": null
}

Removing the comma fixes the issue and the train step continues.

same error

fixed


Feature/refactoring

Resolves: #16
PR has major changes, in application structure and design.
Now application commands only use initialized service functionalities.
So this means when the service changes (for example user switches local service to remote service), then all functionalities will change automatically.
TODO:

[x] Refactor documentation comments
[x] Log “no-content” when note body is empty - pkg.logger

@Onurhan1337 It's ready for full review.


keep the file creation date when i upload to the phone

I'd like have an option to keep the creation date of the file when i upload to the phone.

duplicate : https://github.com/ganeshrvel/openmtp/issues/218


feat: update solo context connect to connect to single remote cluster

Description
This pull request changes the following:

Adds a clusterContextMapping property to LocalConfig
Adds new task methods related to the solo context command command.
Changes the flow of the command. It can be summerized as follows:

 - Determines which context to use to connect to a remote cluster based on the provided flags: `namespace`, `context`, `cluster`. The user is prompted for additional input if required, unless the `--quiet` flag is used, in which case the default settings from `kubeConfig` are used.
 - Connects to the remote cluster and pulls the `remoteConfig`
 - The `LocalConfig` is updated with cluster data from the `remoteConfig`. If new clusters are added to the deployment in the local config, the `clusterContextMapping` is updated.

Related Issues

Closes #755
Closes #951
Closes #950

:tada: This PR is included in version 0.32.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add language tag to datasets

Enhancement / alignment
Add language tag to datasets.
To make sure the way our data gets processed by third parties remains the same way, and our researchers' effort is reflected in the grants.
Expected behaviour for datasets

[ ] Datasets and publications have the same language field on record level
[ ] Researchers and librarians can see the language of a record in the detail overview, below keywords
[ ] Researchers and librarians can edit the language of a record, below keywords
[ ] The language is filled out automatically on DOI import when available
[ ] The language is visible in the OAI output below the title, just like publications

Visuals
Positioned below keywords:

Functions as publications:

OAI output

Context
Current implementation for publications

Fix to biblio OAI needs to be added in front, so we we are only depending on the reindexing moment.


PortAllocator redesign

Port Allocator is supposed to be a reflection of the Operating System construct and must be in sync with OS view of the allocated ports.
The current port allocator reflects the software db of that construct.
Also, port allocator must also provide allocation for individual network namespace and not just for the global space.

In case the host OS does a change in the port allocation which might affect the underlying containers what is the workflow? Docker daemon monitors such changes and via libnetwork will inform the underlying containers or ?

@mavenugo It has been detected that this issue has not received any activity in over 26 months. Can you please let us know if it is still relevant:

For a bug: do you still experience the issue with the latest version?
For a feature request: was your request appropriately answered in a later version?

Thank you!
This issue will be automatically closed in 1 week unless it is commented on.
For more information please refer to https://github.com/docker/libnetwork/issues/1926

With the recent changes made in Docker v27.0, libnetwork now bind sockets before inserting iptables rules. That way, libnetwork alone doesn't determine whether a port is free.
Although the PortAllocator wasn't redesigned (it's still used to iterate on known-bound ports), I think that covers what this ticket was up for.


Fix Vue.js functionality due to malformed public-url in Windows

The current project builds flawlessly in Mac/Linux, but loses Vue.js functionality while executing the build in Windows. The apostrophes present in the public-url in package.json are encoded incorrectly as "%27" while building in Windows and thus invalidate the resulting url. These apostrophes are unnecessary and can be safely removed without affecting the build process in any OS.

Thanks for the PR @CounterPly ! That's right!


Documentation📄: Change container *.md file names to a index file name pattern

What is the current documentation state?
Change container (files that list links to other files in that section of the document) file names and others like it to and "index" naming pattern.
For example, the name for the following file name can be changed to index.md
https://github.ibm.com/Edge-Fabric/docs/blob/4.3/developing/developing_edge_services.md
Where is this stated?
No response
Why do you want to improve the statement?
No response
Proposed Statement
No response
Additional context.
No response

Reopening and repurposing to be a generic goal.

Look in each folder to see if there isn't an index.md or index.html file.  If there isn't one, then:

Look at which pages exist and if one of them would make an obvious default page for that directory.  If so, rename it to index keeping the existing extension (md or html).
Find all pages that linked to the former filename and change those URLs.

Please ensure that all filenames are lowercase only and contain no spaces or punctuation.

Hello @joewxboy
Can I be assigned this issue ? I would like to work on this. I have set up the documentation locally and have gotten a good understanding of the repository structure.

@saurav1004 Go ahead.  Let me know if you have any questions.
Occasionally, you may find that a directory does not have a file that can serve as an obvious index.  In that case, make a new index and list all of the documents in the folder by title and description with the title also serving as a hyperlink.  Also, make sure that the index page in the parent folder now links to the new index page in the child folder so that we are not creating an orphan page.

Do we need to create index files now that the site has migrated to the new theme?  It might be unnecessary ?

Also note, I have some automation that sync the OH docs with the IEAM product docs.  It compares on matching Markdown filenames.  Changing file names to index will break that.

IMHO we should close this issue. Would like to hear other opinions.

i do appreciate the initiative of looking through our backlog of open issues. Thanks for that!

Good point.  Thanks, @johnwalicki
@saurav1004 I'll close this one.


Fix date in README.md

I assume 2022 should be 2023? :)

Well sort of ... actually it's today :smile:.

Thanks for spotting the typo !

Oh, good luck than :)


GetJobTokensJob should not include the private token in the request headers

In a nutshell, with the header one gets {"message":"404 Job Not Found"}
Reproducer: Get a valid job token, and test with curl
curl "https://gitlab.com/api/v4/job?job_token=MY_JOB_TOKEN" # works fine
curl -H 'Private-Token: MY_GITLAB_TOKEN' "https://gitlab.com/api/v4/job?job_token=MY_JOB_TOKEN" # fails with 404

Interestingly MY_GITLAB_TOKEN would have access to the job that it wants to access, but apparently Gitlab does not like to mix the two tokens.
Would it be possible to discard the header Private-Token for this specific request?

As a workaround I can do
func remove_private_token(r *retryablehttp.Request) error {
    r.Header.Add("Private-Token", "")
    return nil
}

c, err := gitlab.NewClient("my_token")
jobTokenOptions := gitlab.GetJobTokensJobOptions{JobToken: gitlab.String(job_token)}
job, _, err := c.Jobs.GetJobTokensJob(&jobTokenOptions, remove_private_token)

But this heavily relies on the implementation detail that in client.Do there is a check whether the header "Private-Token" is already set, and on the fact, that gitlab.com apparently ignores an empty value for Private-Token. Both are not guaranteed to work in future versions of this library / gitlab.

I think you want to use gitlab.NewJobClient instead. That sets the auth type to JobToken.

What is the cost of generating a new job client for every such job-token? It feels a bit overhead to create a client for a single request and then dump it again, but if client creation is a cheap operation that could be an option too.
I would still suggest to document it, that this endpoint should only be called with a JobClient.

Creating a new client isn't super expensive, but is also isn't cheap as it creates and allocates a new struct for every (currently 108) service.
We could potentially add a SetJobToken method on the client that checks if the auth type is JobToken and if so updates the used token on the client if the use case you described is and expected/common workflow.

@theoriginalstove You are right, I can create a NewJobClient("") which has an empty token, and then reuse this client for different job tokens.
@svanharmelen I think the expected behaviour is that any type of client "just works", as long as it is not documented otherwise.

Yeah, well I guess that is quite dependent on what is documented by GitLab and by what actually works with the GitLab API (which isn't always that obvious). Feel free to open a PR if you think some additional comments on the different clients would be beneficial...

For now I opened a ticket with gitlab, let's see what they have to say: https://gitlab.com/gitlab-org/gitlab/-/issues/391924

It looks like the upstream GitLab issue was closed without a change, and this issue has been out here pending for a while. There's also a known workaround, so I'm going to go ahead and close this, and if someone wants to contribute a PR, we can always re-open the issue :)


Genshin Characters Icon URL problem

Some characters give icon URL not found like "Yae Miko"  :  UI_AvatarIcon_YaeMiko
But I found that the file name is wrong, the correct file name is : UI_AvatarIcon_Yae
~But it seems that this problem only occurs in the international server.~
I checked through the log and it seems that the Chinese server also has this problem..
Can it be fixed by hardcoding?

I checked and it seems that I am not using the latest version. Sorry, I will close this issue.


The filetype API method doc has an unformated/invalid link to file types

Was trying to find rendered API documentation, ended up googling this URL: https://javadoc.io/static/com.slack.api/slack-api-client/1.1.0/com/slack/api/methods/request/files/FilesUploadRequest.FilesUploadRequestBuilder.html#filetype-java.lang.String-
(not sure if the above URL is the go-to place to see rendered API docs?)
I believe the improperly-formatted link comes from this line of code: https://github.com/slackapi/java-slack-sdk/blob/main/slack-api-client/src/main/java/com/slack/api/methods/request/files/FilesUploadRequest.java#L34
As I play around with this API to try to help with a question around file uploading, I was trying to figure out what were acceptable values for filetype, but with the broken link, I am still unsure of what this string should be. A MIME type? A file extension? cc @seratch

@filmaj You can find valid links here: https://slack.dev/java-slack-sdk/

Indeed, the part is not correctly formatted. We can improve it. https://oss.sonatype.org/service/local/repositories/releases/archive/com/slack/api/slack-api-client/1.24.0/slack-api-client-1.24.0-javadoc.jar/!/com/slack/api/methods/request/files/FilesUploadRequest.html#setFiletype(java.lang.String)

As I play around with this API to try to help with a question around file uploading, I was trying to figure out what were acceptable values for filetype, but with the broken link, I am still unsure of what this string should be. A MIME type? A file extension?

As you can see here: https://api.slack.com/methods/files.upload#arg_filetype, there is the list of available values in our API documents: https://api.slack.com/types/file#file_types
As for the javadocs, we can improve it by adding a valid link to the page.

Ah yes, I should have checked the API method docs, silly of me 🤦
Wow I totally missed the little book icon link!


python37Packages.casbin: 0.16.2 -> 0.17.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python37Packages.casbin is: "An authorization library that supports access control models like ACL, RBAC, ABAC in Python"
meta.homepage for python37Packages.casbin is: "https://github.com/casbin/pycasbin"
meta.changelog for python37Packages.casbin is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.17.0 with grep in /nix/store/jzr0sgam7s1vfk6yl6dpcrrapbbbiva0-python3.7-casbin-0.17.0

directory tree listing: https://gist.github.com/8cd65b98b7e94d7733e718be82fbf114

du listing: https://gist.github.com/0ce1387dfa96000af4bd2d2877d2ccce

Rebuild report (if merged into master) (click to expand)

12 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
3 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python37Packages.casbin
python38Packages.casbin
python39Packages.casbin

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jzr0sgam7s1vfk6yl6dpcrrapbbbiva0-python3.7-casbin-0.17.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python37Packages.casbin https://github.com/r-ryantm/nixpkgs/archive/d38e830cc1a2f2ba49ba5910f6bab993522cddea.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jzr0sgam7s1vfk6yl6dpcrrapbbbiva0-python3.7-casbin-0.17.0
ls -la /nix/store/jzr0sgam7s1vfk6yl6dpcrrapbbbiva0-python3.7-casbin-0.17.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

python37Packages.casbin
python38Packages.casbin
python39Packages.casbin

Maintainer pings
cc @costrouc for testing.

Result of nixpkgs-review pr 113789 at d38e830c run on aarch64-linux 1

3 packages built:

python37Packages.casbin
python38Packages.casbin
python39Packages.casbin

Package is already at 0.18.3 #116581


Use image with jdk20, install maven and add --enable-preview

Current Dockerfile generates this and will fail because JDK version is wrong:
# 1st stage, build the app
FROM maven:3.8.4-openjdk-17-slim as build

WORKDIR /helidon

# Create a first layer to cache the "Maven World" in the local repository.
# Incremental docker builds will always resume after that, unless you update
# the pom
ADD pom.xml pom.xml
ADD client/pom.xml client/pom.xml
ADD server/pom.xml server/pom.xml
RUN mvn package -Dmaven.test.skip -Declipselink.weave.skip -DskipOpenApiGenerate

# Do the Maven build!
# Incremental docker builds will resume here when you change sources
ADD client/src client/src
ADD server/src server/src
ADD spec/api.yaml spec/api.yaml
RUN mvn package -DskipTests

RUN echo "done!"

# 2nd stage, build the runtime image
FROM openjdk:17-jdk-slim
WORKDIR /helidon

# Copy the binary built in the 1st stage
COPY --from=build /helidon/server/target/myproject-23-server.jar ./
COPY --from=build /helidon/server/target/libs ./libs

CMD ["java", "-jar", "myproject-23-server.jar"]

EXPOSE 8080

New generated Dockerfile will add the following

Use jdk20 image
Download maven
Add --enable-preview when running the app

# 1st stage, build the app
FROM container-registry.oracle.com/java/openjdk:20 as build

# Install maven
WORKDIR /usr/share
RUN set -x && \
    curl -O https://archive.apache.org/dist/maven/maven-3/3.8.4/binaries/apache-maven-3.8.4-bin.tar.gz && \
    tar -xvf apache-maven-*-bin.tar.gz  && \
    rm apache-maven-*-bin.tar.gz && \
    mv apache-maven-* maven && \
    ln -s /usr/share/maven/bin/mvn /bin/

WORKDIR /helidon

# Create a first layer to cache the "Maven World" in the local repository.
# Incremental docker builds will always resume after that, unless you update
# the pom
ADD pom.xml pom.xml
ADD client/pom.xml client/pom.xml
ADD server/pom.xml server/pom.xml
RUN mvn package -Dmaven.test.skip -Declipselink.weave.skip -DskipOpenApiGenerate

# Do the Maven build!
# Incremental docker builds will resume here when you change sources
ADD client/src client/src
ADD server/src server/src
ADD spec/api.yaml spec/api.yaml
RUN mvn package -DskipTests

RUN echo "done!"

# 2nd stage, build the runtime image
FROM container-registry.oracle.com/java/openjdk:20
WORKDIR /helidon

# Copy the binary built in the 1st stage
COPY --from=build /helidon/server/target/myproject-23-server.jar ./
COPY --from=build /helidon/server/target/libs ./libs

CMD ["java", "--enable-preview", "-jar", "myproject-23-server.jar"]

EXPOSE 8080

@klustria This should be updated to use JDK 21 instead of 20.

@klustria This should be updated to use JDK 21 instead of 20.

@romain-grecourt ... FYI, unfortunately, OpenJDK 21 and JDK 21 are not available yet in https://container-registry.oracle.com/ so will just leave this PR hanging for now until v21 becomes available. Will ping you for review once it's available.

This PR is for issue https://github.com/helidon-io/helidon/issues/7180

@romain-grecourt ... FYI, unfortunately, OpenJDK 21 and JDK 21 are not available yet in https://container-registry.oracle.com/ so will just leave this PR open for now until v21 becomes available. Will ping you for review once it's available.

See https://github.com/helidon-io/helidon/blob/fb7585c95be7a2c42b58d7ca36a2fd34c186aaba/examples/quickstarts/helidon-quickstart-se/Dockerfile#L18

@romain-grecourt ... FYI, unfortunately, OpenJDK 21 and JDK 21 are not available yet in https://container-registry.oracle.com/ so will just leave this PR open for now until v21 becomes available. Will ping you for review once it's available.

See
https://github.com/helidon-io/helidon/blob/fb7585c95be7a2c42b58d7ca36a2fd34c186aaba/examples/quickstarts/helidon-quickstart-se/Dockerfile#L18

Was this tested? It seems to fail for me when I pull from my local docker:
docker pull container-registry.oracle.com/java/openjdk:21
Error response from daemon: manifest for container-registry.oracle.com/java/openjdk:21 not found: manifest unknown: manifest unknown

You're right, I think this was not tested. CC @tomas-langer

JDK 21 is not yet avialable, we cannot fix it for the time being. Same for native image.
Until releases are available, our dockerfiles cannot be used

Closing this PR as it is no longer relevant (we use Java 21 and we do not need --enable-preview. Please kindly open a new one for Java 21 when possible


Installed page - Clusters list

Clusters list like in the repositories page
Namespaces filters (using checkbox)

Hi @chad11111
I would love to take this one.

Fixed in #305

@ErezBiren Its not visible yet :)

@chad11111  @ErezBiren
Can I get this task?


Issue synching paths

Hi!
Just getting started with docker-osx-dev. I've installed, but when I run the command in the root directory of my project (with a docker-compose.yml file), I get the error below:
/usr/local/bin/docker-osx-dev: line 999: greadlink: command not found
2015-11-24 15:43:48 [INFO] Complete list of paths to sync:
2015-11-24 15:43:48 [INFO] Using default exclude paths: .git
2015-11-24 15:43:48 [INFO] Complete list of paths to exclude: .git
2015-11-24 15:43:48 [INFO] Complete list of paths to include:
2015-11-24 15:43:48 [INFO] Starting docker-osx-dev file syncing
2015-11-24 15:43:48 [INFO] Installing rsync in the Docker Host image
2015-11-24 15:43:48 [INFO] Performing initial sync of paths:
BusyBox v1.22.1 (2014-04-04 15:16:09 UTC) multi-call binary.

Usage: mkdir [OPTIONS] DIRECTORY...

Create DIRECTORY

    -m MODE Mode
    -p  No error if exists; make parent directories as needed

error in run: exit status 1

My docker-compose.yml file contains:
web:
  build: .
  command: supervisor -w . -x /usr/bin/babel-node app.js
  ports:
    - "80:8000"
  volumes:
    - .:/code
  links:
    - redis
    - mysql
redis:
  image: redis
mysql:
  image: mysql

The error is right at the top:
/usr/local/bin/docker-osx-dev: line 999: greadlink: command not found

Did you run docker-osx-dev install? Were there any errors? It should have installed the greadlink dependency. You could try running it again to see if it works.

I had the same error. I had some problems running the docker-osx-dev install. If you use the new docker toolbox with docker machine, it needs to run inside the docker quickstart terminal. That seemed to work for me.
I also needed to manually brew install Cask.

Topic wverlapping  with #146.

Same error, brew install coreutils (which actually contains GNU readlink) seems to be sufficient.

Very old issue, but if it helps, in my case coreutils was installed but it was not linked. This fixed it:
brew install coreutils; brew link --overwrite coreutils


correcting several user_guide sections

some user_guide contents, formating already corrected. Please comment here if I done wrong or some suggestions. thx

You are mixing typos, sphinx formatting problems, and adding page heading preferences ("Page contents), all in one PR. These would be better dealt with as separate PRs (for instance if we disagree with your preferences).
The changes make sense, and will be incorporated.
Thank you for taking a rigorous look at the user guide!
Note: look into secure signing of commits - we are looking for this with code submissions.

Thanks for your suggestions, next time I will make separate PR for each problems.

Separating PRs would be by "kind of problem", or by "size of problem", so that like things are considered together or so that a PR can be easily reviewed :)
Looking forward to seeing more from you!


Okhttp, a problem on VIVO Y17T device.

There is a must have occurred problem on the device.
important log:
java.io.IOException: unexpected end of stream on Connection{api.laifeng.com:80, proxy=DIRECT@ hostAddress=<IP_ADDRESS> cipherSuite=none protocol=http/1.1} (recycle count=0)
Caused by: java.io.EOFException: \n not found: size=416.

That's an I/O problem. Nothing we can do!


dynamically update user redemption records during unbonding

Context
Refactored the dynamic redemption rate during unbonding PR.
Motivation for refactoring:

Further modularize functions to give more fine grained test coverage
Explicitly separate steps that modify state vs those that are just doing calculations
Put the new dynamic unbonding code as upstream as possible (so it's less invasive to the current unbonding code), while still keeping the native calculation and the unbonding ICAs atomic

do we still need to add the cache context?

Manual testing to inspect the native_token_amount incrementing:


Index Out Of Bounds Error - atlas apply on crafted hcl document

I'm not sure what causes this or why, but I can consistently get an index OOB panic from a given (apparently valid) HCL doc. I don't know anything about HCL or atlas, but messing around with it I was able to produce this error which seems like it could be a security issue. Even if the HCL doc is invalid, I feel like this should be caught before attempting to index a null array.
This hcl document was created from a sqlite3 database and was then applied to a mysql db to discover this bug.
Expected Result
I would expect that any HCL document (especially a valid one) that can't be applied, would output an well formed error and exit with an error code, without attempting any pointer derefs that may be invalid.
Observed Result
On sending a specially crafted HCL document to an empty MySQL database, I get a index out-of-bounds panic. While the document may not be valid (it appears to work on sqlite3 targets), indexing out of bounds seems like a bug that should be caught and this document should just be refused instead.
Output from atlas schema apply
panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
ariga.io/atlas/sql/mysql.parseColumn({0x0?, 0xb?})
	/home/topher/go/pkg/mod/ariga.io/atlas@v0.4.3-0.20220713104915-cda1480dd791/sql/mysql/inspect.go:595 +0x45c
ariga.io/atlas/sql/mysql.ParseType({0x0, 0x0})
	/home/topher/go/pkg/mod/ariga.io/atlas@v0.4.3-0.20220713104915-cda1480dd791/sql/mysql/convert.go:109 +0x3e
ariga.io/atlas/schemahcl.(*TypeRegistry).Type(0xc0000a5e60, 0xc000314f60, {0x0, 0x0, 0x1?})
	/home/topher/go/pkg/mod/ariga.io/atlas@v0.4.3-0.20220713104915-cda1480dd791/schemahcl/types.go:285 +0x135
ariga.io/atlas/sql/mysql.convertColumnType(0x8?)
	/home/topher/go/pkg/mod/ariga.io/atlas@v0.4.3-0.20220713104915-cda1480dd791/sql/mysql/sqlspec.go:193 +0x33
ariga.io/atlas/sql/internal/specutil.Column(0xc0000b8d80, 0xc899a8)
	/home/topher/go/pkg/mod/ariga.io/atlas@v0.4.3-0.20220713104915-cda1480dd791/sql/internal/specutil/convert.go:146 +0x215
ariga.io/atlas/sql/mysql.convertColumn(0xc0000b8d80, 0x415c45?)
	/home/topher/go/pkg/mod/ariga.io/atlas@v0.4.3-0.20220713104915-cda1480dd791/sql/mysql/sqlspec.go:162 +0x3a
ariga.io/atlas/sql/internal/specutil.Table(0xc0000ba5a0, 0xc0000a3720, 0xc899b0, 0xc89958, 0xc899b8, 0xc899a0)
	/home/topher/go/pkg/mod/ariga.io/atlas@v0.4.3-0.20220713104915-cda1480dd791/sql/internal/specutil/convert.go:95 +0x114
ariga.io/atlas/sql/mysql.convertTable(0xc0000ba5a0, 0x0?)
	/home/topher/go/pkg/mod/ariga.io/atlas@v0.4.3-0.20220713104915-cda1480dd791/sql/mysql/sqlspec.go:95 +0x4f
ariga.io/atlas/sql/internal/specutil.Scan(0xc0003ce240, {0xc0000108a8, 0x1, 0xc0003ce3f0?}, {0xc000010840, 0x1, 0x1}, 0xc899c8)
	/home/topher/go/pkg/mod/ariga.io/atlas@v0.4.3-0.20220713104915-cda1480dd791/sql/internal/specutil/convert.go:47 +0x370
ariga.io/atlas/sql/mysql.evalSpec(0xc0000104d0?, {0xbbdd60?, 0xc0003ce240?}, 0xc0003ce240?)
	/home/topher/go/pkg/mod/ariga.io/atlas@v0.4.3-0.20220713104915-cda1480dd791/sql/mysql/sqlspec.go:34 +0x110
ariga.io/atlas/schemahcl.EvalFunc.Eval(0xc00040fae8?, 0x415fa7?, {0xbbdd60?, 0xc0003ce240?}, 0xc00008bf01?)
	/home/topher/go/pkg/mod/ariga.io/atlas@v0.4.3-0.20220713104915-cda1480dd791/schemahcl/hcl.go:551 +0x33
ariga.io/atlas/cmd/atlas/internal/cmdapi.applyRun(0x110ab20, 0xc0000fdb90, {0x0?, 0x0}, {0xc000081ae0, 0x1, 0x1}, 0x0, 0x0, 0x0)
	/home/topher/go/pkg/mod/ariga.io/atlas/cmd/atlas@v0.5.0/internal/cmdapi/schema.go:318 +0x28d
ariga.io/atlas/cmd/atlas/internal/cmdapi.CmdApplyRun(0x110ab20, {0xc28f93?, 0x4?, 0x4?})
	/home/topher/go/pkg/mod/ariga.io/atlas/cmd/atlas@v0.5.0/internal/cmdapi/schema.go:288 +0x105
github.com/spf13/cobra.(*Command).execute(0x110ab20, {0xc000097740, 0x4, 0x4})
	/home/topher/go/pkg/mod/github.com/spf13/cobra@v1.4.0/command.go:856 +0x67c
github.com/spf13/cobra.(*Command).ExecuteC(0x1109ea0)
	/home/topher/go/pkg/mod/github.com/spf13/cobra@v1.4.0/command.go:974 +0x3b4
github.com/spf13/cobra.(*Command).Execute(...)
	/home/topher/go/pkg/mod/github.com/spf13/cobra@v1.4.0/command.go:902
github.com/spf13/cobra.(*Command).ExecuteContext(...)
	/home/topher/go/pkg/mod/github.com/spf13/cobra@v1.4.0/command.go:895
main.main()
	/home/topher/go/pkg/mod/ariga.io/atlas/cmd/atlas@v0.5.0/main.go:29 +0x114

Steps to reproduce
My setup:
Using atlas v0.5.0 (compiled with go 1.18.4) on Fedora 36 (fully updated as of today).
Using Docker 20.10.17 and MySQL 8.0.27
From GNU Bash 5.1.16
# install atlas v0.5.0
go install<EMAIL_ADDRESS>
# Create a vanilla, empty, 8.0.27 MySQL server:
docker run --name atlas-db  -p 3306:3306  -e MYSQL_ROOT_PASSWORD=pass -e MYSQL_DATABASE=main mysql:8.0.27

# create bad HCL Document
cat << EOF > atlas.hcl
table "annotations" {
  schema = schema.main
  column "term" {
    null = false
    type = sql("")
  }
}
schema "main" {
}
EOF

# Attempt to apply schema:
atlas schema apply -u "mysql://root:pass@localhost:3306/main" -f atlas.hcl

hey @TopherIsSwell,
Thanks for reaching out. I will review this and update back.
Just as a side note - HCL documents are not dialect agnostic and so one it is not expected that you will be able to inspect something from SQLite and apply it on MySQL.

confirmed this fixes the issue of the overflow.
However, this causes a problem where valid SQLite3 schemas generate invalid HCL documents. See issue #1014 (which is probably a much lower priority issue).


routing: inbound fees support for BuildRoute

This PR attempts to add support for inbound fees to BuildRoute. The three passes BuildRoute goes through (see https://github.com/lightningnetwork/lnd/issues/8814#issuecomment-2160012218 for an explanation) are altered to determine the edges in the backward pass (from receiver to sender) as opposed to the previous approach where this is done in the forward pass (sender to receiver). This way we get fixed edges that can be used to determine the minimal sender/maximal receiver amount with inbound fees, doing a reverse amount calculation (thanks to @feelancer21 for the analysis https://github.com/lightningnetwork/lnd/issues/8814#issuecomment-2168351570). The computation for the outgoing amount based on the incoming amount is done using big.Int arithmetic.
Previous work on this: https://github.com/lightningnetwork/lnd/pull/7060

Thanks for the reviews @guggero and @ProofOfKeags and also for the improvement suggestions!

My understanding is that there are broadly two cases that we need to consider

Yes pretty well described :+1:

The algorithm seems to be intrinsically imperative and essentially must be computed iteratively.
From here It comes to my attention that the following expressions should hold

sendAmt := recvAmt + fees
fees := outboundFees + inboundFees
outboundFees := fn.Sum(fn.Map(getOutboundFee, edges[1:]))
inboundFees := fn.Sum(fn.Map(getInboundFee, edges[:len(edges)-1]))

Roughly yes, unfortunately the inbound fees are coupled to the previous hop's outbound fees, which is why I think the map approach wouldn't work well.
I added some documentation to the amount calculation, hope that helps. I'm still using float numerics, but need to look into that again to be sure it is precise and what the boundaries of failures would be.

However, in other parts of LND I've been favoring the approach of "no PR should make the quality of the codebase deteriorate".

Totally agree, happy to address things!

I noticed that when constructing the edge unifiers, we always included inbound fees in the policy. In pathfinding we don't set them to be active for the last hop, which is important for edge constraint checks (updated and documented in TestSenderAmtBackwardPass). I also added a test case for a min amount search with inbound fees that also displays an interesting edge case with rounding, which gets corrected in newRoute. I think that an itest could be interesting here as well, on the otherhand, because everything passes through newRoute, this should be covered by the pathfinding tests.