errorhandler with express

I had do a new one, there were issues, i got his dotfile & it threw off my gitconfig stuff

long story short, I just did a new pull Req. Anyway moving on.
I hope you can use this example in your errorhandler module, Please feel free to modify it, to a more connect, routes savvy or a better version over all.
Chatting with you has been great Doug.
leading up to this: https://github.com/expressjs/errorhandler/pull/17 & https://github.com/expressjs/errorhandler/issues/16 & https://github.com/expressjs/errorhandler/pull/18

Sorry @dougwilson I don't know what was on my mind but i skimmed over this. actually add words to explain how the routing works & rather than adding another Example.
I will fix this, I'll remove the code & go about this the correct way. As intended :100:

Looks good, @kelthenoble! I think the ultimate goal of this pull request was to actually add words to explain how the routing works, in that the error handler needs to actually be added after the routes (of course, that depends on the version of Express, as routing has changed over time), rather than adding another Example.

Awesome! Also, sorry, I actually forgot this pull request was here :) I just set the labels and assigned it so I wouldn't forget. Feel free to  ping me when you're ready for me to take a look :)

Okay, will do.

Okay so here we go @dougwilson, so i just wanted to implement a simplistic example with words.
there are myriads of tutorials about routes in express out in the world, but here is an quick informative piece on errorhandler with express and not bogged down in a lot of code. I hope it serves well.


fail to build picorv32_versa5g example from prjtrellis

#1497  Steps to reproduce the issue
With:
Yosys 0.9+1706 (git sha1 c244b27b, gcc 7.4.0-1ubuntu1~18.04.1 -fPIC -Os)
Type "make attosoc.json" from prjtrellis/examples/picorv32_versa5g
(the code is here: https://github.com/SymbiFlow/prjtrellis/tree/master/examples/picorv32_versa5g
)
And it fails with this assert, but it used to work with Yosys 0.9+932 (git sha1 22fe931c):
. . .
<IP_ADDRESS>. Executing ABC.
Running ABC command: /yosys-abc -s -f /abc.script 2>&1
ABC: ABC command line: "source /abc.script".
ABC:
ABC: + read_blif /input.blif
ABC: + read_lut /lutdefs.txt
ABC: + strash
ABC: + ifraig
ABC: + scorr
ABC: Warning: The network is combinational (run "fraig" or "fraig_sweep").
ABC: + dc2
ABC: + dretime
ABC: + strash
ABC: + dch -f
ABC: + if
ABC: + mfs2
ABC: + lutpack -S 1
ABC: yosys-abc: src/opt/lpk/lpkCore.c:549: int Lpk_ResynthesizeNodeNew(Lpk_Man_t *): Assertion `nGain >= 1 - p->pPars->fZeroCost' failed.
ABC: Aborted
ERROR: ABC: execution of command "/usr/local/bin/yosys-abc -s -f /tmp/yosys-abc-l7kTtL/abc.script 2>&1" failed: return code 134.
Makefile:16: recipe for target 'attosoc.json' failed
make: *** [attosoc.json] Error 1

Seems to be another case of #1675, which is believed to be an upstream ABC issue. There is a workaround there too. Another workaround would be to try synth_ecp5 -abc9 at https://github.com/SymbiFlow/prjtrellis/blob/master/examples/picorv32_versa5g/Makefile#L16

Should be fixed by #1744


Hide value

Hi,
It's possible to hide the value?

There isn't any configuration option for that but you can use CSS to make it disappear.

Ok, thank you ....


Ambari 23024 trunk - Log Serach UI: Implement Metadata patterns screen

What changes were proposed in this pull request?
Implementing meta data pattern configuration screen for Log Feeder.
Adding some app structure modifications in order to create this feature as a module.
How was this patch tested?
Unit tests and manual test.
Please review Ambari Contributing Guide before opening a pull request.
Pleas review @aBabiichuk

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1145/
Test FAILed.
Test FAILured.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1163/
Test FAILed.
Test FAILured.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1170/
Test PASSed.


[cpackget] Unable to download a pack file that contains the build identifier

Describe the bug
Imagine a pack index file that contains a pack and the pack file contains the build identifier. Example:
<pdsc url="https://www.keil.com/pack/" vendor="ARM" name="CMSIS" version="6.1.0+foo" />

Then we try to install it using cpackget:
cpackget add --verbose<EMAIL_ADDRESS>
The command would generate output that ends with:
D: bad status: 404
E: "https://www.keil.com/pack/ARM.CMSIS.6.1.0.pack": bad request

But it should try to download https://www.keil.com/pack/ARM.CMSIS.6.1.0+foo.pack instead.
In the .pdsc file embedded in the .pack file, the release node is:
  <releases>
    <release date="2024-02-30" version="6.1.0+foo">
      the change log entries...
   </release>
  </releases>

To Reproduce
See above.
Expected behavior
The pack file should be downloaded.
Environment (please complete the following information):

OS: any
Version 2.1.4?

Additional context
Obviously, we did not see the problem with the ARM.CMSIS.6.1.0 pack, but an internal pack. The steps above should highlight the question regardless of the pack name.
The .pack files is named including the metadata/build identifier on the server.

When installing a pack file from disk with meta information in the version:
ARM.CMSIS.6.0.0-dev35+geb1d42a.pack
the file will be stored in .Download without meta information
${CMSIS_PACK_ROOT}/.Download/ARM.CMSIS.6.0.0-dev35.pack
the content of the pack version will be extracted into a version folder without meta information
${CMSIS_PACK_ROOT}/ARM/CMSIS/6.0.0-dev35/
The pdsc file contains the meta information in the <release> attribute
<release version="6.0.0-dev35+geb1d42a">
however the tools reading pdsc files must ignore the meta information.
*.cbuild-pack.yml:
  resolved-packs:
    - resolved-pack<EMAIL_ADDRESS>      selected-by-pack:
        -<EMAIL_ADDRESS>


docs: mkdocs feature not working on contributing section

This could have happened in multiple other places:

[x] Contributing Warning drop down
[x] Usage -> Creating your font -> After point 3

I want to work on this issue

Closed #73


[website] Fix constantly reloading when Russian language is set

Fixes https://github.com/mui-org/material-ui/issues/28689

Verified that the issue is fixed by adding Russian as a first language. It fails on the other PRs build, for example: https://deploy-preview-28868--material-ui.netlify.app/

So this line overrides settings?

@eps1lon I assume you are asking me. I assume this line is the one we have changed. What do you mean by settings?
This accepted language configuration is about finding the best intersection between the locales that the visitor prefers, with the locales that are available on the documentation. The redirection only triggers if the visitor has no language preference cookie, and is not on a locale path (/pt, etc.)


Help messages for obsolete APIs just refer the reader to Bing

Copied from https://rx.codeplex.com/workitem/18
There are a number of help messages for obsolete methods and properties which have help messages which end with "See http://go.microsoft.com/fwlink/?LinkID=260866 for more information." However, this URL resolves to http://www.bing.com which doesn't really help.
Can these messages be updated to refer to some more specific content, or removed?
 Locations:
◾Rx\NET\Source\System.Reactive.Core\Reactive\Internal\Constants.cs(11): public const string OBSOLETE_SCHEDULER_NEWTHREAD = OBSOLETE_REFACTORING + " Please add a reference to the System.Reactive.PlatformServices assembly for your target platform and use NewThreadScheduler.Default to obtain an instance of this scheduler type. See http://go.microsoft.com/fwlink/?LinkID=260866 for more information.";
◾Rx\NET\Source\System.Reactive.Core\Reactive\Internal\Constants.cs(12): public const string OBSOLETE_SCHEDULER_TASKPOOL = OBSOLETE_REFACTORING + " Please add a reference to the System.Reactive.PlatformServices assembly for your target platform and use TaskPoolScheduler.Default to obtain an instance of this scheduler type. See  http://go.microsoft.com/fwlink/?LinkID=260866 for more information.";
◾Rx\NET\Source\System.Reactive.Core\Reactive\Internal\Constants.cs(13): public const string OBSOLETE_SCHEDULER_THREADPOOL = OBSOLETE_REFACTORING + " Consider using Scheduler.Default to obtain the platform's most appropriate pool-based scheduler. In order to access a specific pool-based scheduler, please add a reference to the System.Reactive.PlatformServices assembly for your target platform and use the appropriate scheduler in the System.Reactive.Concurrency namespace. See http://go.microsoft.com/fwlink/?LinkID=260866 for more information.";
◾Rx\NET\Source\System.Reactive.Core\Reactive\Internal\Constants.cs(15): public const string OBSOLETE_SCHEDULEREQUIRED = "This instance property is no longer supported. Use CurrentThreadScheduler.IsScheduleRequired instead. See http://go.microsoft.com/fwlink/?LinkID=260866 for more information.";
◾Rx\NET\Source\System.Reactive.Linq\Reactive\Internal\Constants.cs(14): public const string USE_ASYNC = "This blocking operation is no longer supported. Instead, use the async version in combination with C# and Visual Basic async/await support. In case you need a blocking operation, use Wait or convert the resulting observable sequence to a Task object and block. See http://go.microsoft.com/fwlink/?LinkID=260866 for more information.";
◾Rx\NET\Source\System.Reactive.Linq\Reactive\Internal\Constants.cs(15): public const string USE_TASK_FROMASYNCPATTERN = "This conversion is no longer supported. Replace use of the Begin/End asynchronous method pair with a new Task-based async method, and convert the result using ToObservable. If no Task-based async method is available, use Task.Factory.FromAsync to obtain a Task object. See http://go.microsoft.com/fwlink/?LinkID=260866 for more information.";
◾Rx\NET\Source\System.Reactive.Providers\Reactive\Internal\Constants.cs(14): public const string USE_ASYNC = "This blocking operation is no longer supported. Instead, use the async version in combination with C# and Visual Basic async/await support. In case you need a blocking operation, use Wait or convert the resulting observable sequence to a Task object and block. See http://go.microsoft.com/fwlink/?LinkID=260866 for more information.";
◾Rx\NET\Source\System.Reactive.Providers\Reactive\Internal\Constants.cs(15): public const string USE_TASK_FROMASYNCPATTERN = "This conversion is no longer supported. Replace use of the Begin/End asynchronous method pair with a new Task-based async method, and convert the result using ToObservable. If no Task-based async method is available, use Task.Factory.FromAsync to obtain a Task object. See http://go.microsoft.com/fwlink/?LinkID=260866 for more information.";
◾Rx\NET\Source\System.Reactive.Windows.Threading\Reactive\Internal\Constants.cs(10): public const string OBSOLETE_INSTANCE_PROPERTY = "Use the Current property to retrieve the DispatcherScheduler instance for the current thread's Dispatcher object. See http://go.microsoft.com/fwlink/?LinkID=260866 for more information.";

Those links have been removed; the obsolete nature of these APIs has been around for a while. For Rx v3.0, those APIs will be removed.


Allow control of number of decimal places shown in custom card

Fitting the Agile Prices custom card on my iPhone screen is a challenge.
I've reduced it to 1 decimal place by changing the .js file  and it fits better.
Could this be a config option somehow ?

This makes total sense, should be easy enough to add in 👍

All done, you may need to clear cache for changes to take affect.


Missing Virtualmin left menu

Software versions:
Webmin: 1.760
Virtualmin: 4.09
Authentic Theme: 16.01
The entire left menu of virtualmin is missing. Can you please help me with that?

Found the issue. Had to manualy upgrade Virtualmin since it wasn't updated via apt-get.


fix(core): unique WebContext for each window when TAURI_AUTOMATION unset

What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Docs
[ ] New Binding Issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes. Issue #___
[ ] No

The PR fulfills these requirements:

[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
[ ] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

I think we should share the webcontext regardless of the env var value so that running and testing an application have the same behavior.  Until we start seeing bugs stemming from that, I think there's more value in having them the same.
Also we should be applying our "core" custom protocols only once, and leave the rest up to the user. The current interface in Wry expects something like
let mut webview = /* WebviewBuilder stuff */;
let mut set_protocol = false;
if !set_protocol {
  webview = webview.with_custom_protocol("wry".into(), |_window, _uri| todo!());
  set_protocol = true;
}

Ideally we also remove the user-set custom protocols from the attributes builder and move it somewhere on the application itself because different windows handling the same URI differently is a break from the concept of what a URI is

Reopening since we couldn't find the solution yet. The temporary solution was also suggested by @wusyong @chippers


Storing long int variable

When passing long int variables to json_object_dotset_number() API, the output looks like:
"memoryUsage": {
    "freeMemory (bytes)":<PHONE_NUMBER>8.000000,
    "usedMemory (bytes)":<PHONE_NUMBER>0.000000,
    "totalMemory (bytes)":<PHONE_NUMBER>68.000000
}

Is there anyway to remove the decimals? I know that json_object_dotset_number() converts the input to double. Input as integer does not have have decimals in the output. Thanks a lot!

I'm unable to reproduce your results.
    JSON_Value *root_value = json_value_init_object();
    JSON_Object *root_object = json_value_get_object(root_value);

    json_object_dotset_number(root_object, "freeMemory (bytes)",<PHONE_NUMBER>8);
    json_object_dotset_number(root_object, "usedMemory (bytes)",<PHONE_NUMBER>0);
    json_object_dotset_number(root_object, "totalMemory (bytes)",<PHONE_NUMBER>68);

    puts(json_serialize_to_string_pretty(root_value));

prints
{
    "freeMemory (bytes)":<PHONE_NUMBER>8,
    "usedMemory (bytes)":<PHONE_NUMBER>0,
    "totalMemory (bytes)":<PHONE_NUMBER>68
}

I'm closing this issue because I suspect you were using an old version of parson.

Using the most recent version resolves the issue. thanks!


how to read ULP result data from micropython?

as a result of the assembler run, we have a symbol table (name -> offset).
what we do not have (yet?) is type information.
if we had that, we could build a uctypes.struct to comfortably deal with the result (like x = ulp.name).
any other ideas?

Until we have a prettier way like described above, direct memory access via machine.mem32 can be used, see there: https://github.com/ThomasWaldmann/py-esp32-ulp/blob/master/examples/counter.py


Add MANIFEST.in file for packaging

excluding the _dev_version and github-related folders.
This tries to solve the appearance of the warning:
/tmp/build-env-38jhk5t9/lib/python3.10/site-packages/setuptools/command/build_py.py:207: _Warning: Package 'iop4lib._dev_version' is absent from the `packages` configuration.

when building the package.

this can be merged


WIP Reviewing some sessions classes

Hi there, I've done some review and minor-simple improvements, as follows below, thanks.

BaseHandler, added some simple phpDoc.
BaseHandler, improvements at the constructor and added a TODO.
DatabaseHandler, just a phpDoc.
FileHandler, constructor improvements and indentation correction.
Session, added TODO about the return's start() method.

is this PR really required?

@atishamte Agreed. Stale, & most changes effected already elsewhere.


⚠ Samsung has degraded performance

In 31042a8, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2242 ms

Resolved: Samsung performance has improved in 961dc1f.


Error in OpenAPI client execute() method - getting "Unable to get access token for "destination" service. No service instance of type "destination" found."

Describe the bug
Error in OpenAPI client execute() method - getting "Unable to get access token for "destination" service. No service instance of type "destination" found."
Used Versions:
node version via node -v 18.16.0
SAP Cloud SDK version you used as dependency v3.0.1
Additional context
I have created an open api client. Getting the above error when I trigger .execute() method with a destination name. The destination is configured in BTP subaccount level.
This is what I'm trying to do:
await MyApi.myFunction().execute({
destinationName: 'destinationName',
});
  This is giving me the below error:
  "Unable to get access token for "destination" service. No service instance of type "destination" found."

  This was working well until recently.

Hi @tonymathew17sap ,
The error seems to suggest that a binding to the destination service is missing. Can you confirm that your application is bound to a destination service instance?
Could you also share the detailed log message with the error stack trace?

Hi @deekshas8 , so my application is deployed in kyma and I have followed this link to consume destination service instance in my application: https://help.sap.com/docs/btp/sap-business-technology-platform/using-sap-btp-services-in-kyma-environment.
Basically this is what I have done:

Created a service instance
Created a service binding

Please let me know if I have missed any steps to bind destination service to my application.
These are the error logs that I'm getting:
Error: Unable to get access token for "destination" service. No service instance of type "destination" found.
at resolveService (/node_modules/@sap-cloud-sdk/connectivity/dist/scp-cf/environment-accessor.js:192:19)
at serviceToken (/node_modules/@sap-cloud-sdk/connectivity/dist/scp-cf/token-accessor.js:27:57)
at getProviderServiceToken (/node_modules/@sap-cloud-sdk/connectivity/dist/scp-cf/destination/get-provider-token.js:12:61)
at DestinationFromServiceRetriever.getDestinationFromDestinationService (/node_modules/@sap-cloud-sdk/connectivity/dist/scp-cf/destination/destination-from-service.js:63:86)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async getDestination (/node_modules/@sap-cloud-sdk/connectivity/dist/scp-cf/destination/destination-accessor.js:72:10)
at async OpenApiRequestBuilder.executeRaw (/node_modules/@sap-cloud-sdk/openapi/dist/openapi-request-builder.js:76:37)
at async OpenApiRequestBuilder.execute (/node_modules/@sap-cloud-sdk/openapi/dist/openapi-request-builder.js:91:26)
at async CasesService.getCaseById (/dist/cases/cases.service.js:19:34)
I get the following logs as well:
{"custom_fields":{"messageContext":"environment-accessor","package":"connectivity"},"level":"warn","logger":"sap-cloud-sdk-logger","message":"No services of type destination found! This might cause errors in other parts of the application.","msg":"No services of type destination found! This might cause errors in other parts of the application.","timestamp":"2023-05-31T10:43:52.136Z","written_at":"2023-05-31T10:43:52.136Z","written_ts":1685529832136}
Also, please note that until recently, even without creating any service instance/binding, cloud-sdk in my application was able to connect to destination just by passing the destinationName like this:
await MyApi.myFunction().execute({
destinationName: 'destinationName',
});

Hey @tonymathew17sap,
we are currently working on a guide specifically for Kyma, but for now, we only have a guide for Kubernetes, which should be mostly applicable to Kyma as well. Did you mount the created secrets into your application? Please check that you do this as described in this guide. Please share your deployment.yml to check if everything is correctly specified.

Hi @marikaner I did not mount the created secrets into my application. I have attached my deployment.yml(attached as .txt file)
deployment.txt
Could you please tell me if there's any other steps involved other than creating service instance, service binding and mounting the secrets?
Also I'm unable to understand how cloud-sdk was able to connect to the destination earlier without any of these settings

https://blogs.sap.com/2022/07/12/the-new-way-to-consume-service-bindings-on-kyma-runtime/

Hey @tonymathew17sap, same for me, the SDK cannot connect to the destination without these settings. So there must have been some setup, maybe created by someone else?

https://blogs.sap.com/2022/07/12/the-new-way-to-consume-service-bindings-on-kyma-runtime/

This would work for Java, but probably won't for JavaScript.

https://blogs.sap.com/2022/07/12/the-new-way-to-consume-service-bindings-on-kyma-runtime/

This fixed the issue

Hey @ptesny, thanks for supporting in solving the issue.
Interesting that @sap/xsenv now seems to support SERVICE_BINDING_ROOT as outlined in the guide you've linked, we didn't find any mention of it in their docs, but since it worked for you I suppose we can update our own guide as well.

indeed, all the main sap libraries do support SERVICE_BINDING_ROOT paradigm;
not sure why the externally facing documentation has not been updated so far...
PS.
https://blogs.sap.com/2023/02/06/power-of-serverless-with-sap-btp-kyma-runtime.-secrets-mounted-as-volumes./


Initial README.md update

Codecov Report

Merging #4 (14cf1b3) into main (4f2c13f) will increase coverage by 24.77%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main       #4       +/-   ##
===========================================
+ Coverage   44.51%   69.28%   +24.77%
===========================================
  Files         115       49       -66
  Lines       19467     9042    -10425
  Branches    11010     5679     -5331
===========================================
- Hits         8666     6265     -2401
+ Misses       9118     1808     -7310
+ Partials     1683      969      -714

Flag
Coverage Δ

buildmgr-cov
74.59% <ø> (-0.50%)
:arrow_down:

svdconv-cov
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

tools/buildmgr/cbuildgen/src/AuxCmd.cpp
57.74% <0.00%> (-4.76%)
:arrow_down:

tools/buildmgr/cbuild/src/CbuildUtils.cpp
80.48% <0.00%> (-2.85%)
:arrow_down:

tools/buildmgr/cbuildgen/src/Console.cpp
72.28% <0.00%> (-1.47%)
:arrow_down:

tools/buildmgr/cbuild/src/CbuildCallback.cpp
39.47% <0.00%> (-1.07%)
:arrow_down:

tools/buildmgr/cbuild/src/CbuildProject.cpp
40.12% <0.00%> (-0.94%)
:arrow_down:

tools/buildmgr/cbuild/src/CbuildLayer.cpp
76.04% <0.00%> (-0.58%)
:arrow_down:

...ls/buildmgr/cbuildgen/src/BuildSystemGenerator.cpp
85.66% <0.00%> (-0.40%)
:arrow_down:

tools/svdconv/SVDModel/src/SvdDerivedFrom.cpp

tools/svdconv/SVDGenerator/include/SvdGenerator.h

tools/svdconv/SVDGenerator/src/PartitionData.cpp

... and 67 more


Remove MVKCommandEncoderState::reset().

MVKCommandEncoderState has numerous subclasses, and the polymorphic
MVKCommandEncoderState::resetImpl() requires significant maintenance
across these subclasses. It's only use was in disabling depth-stencil state.
Remove MVKCommandEncoderState::reset() and all implementations of resetImpl()
across all MVKCommandEncoderState subclasses.
Remove MVKPipeline::__hasDepthStencilInfo and disable depth-stencil state
automatically via cleared Vulkan struct in MVKPipeline.
Fixes #1264.

Oops. I submitted this from master. I'm going to resubmit from a different branch.


[Bug] [AUTHZ]ALTER operation to change the table name requires DROP table privilege instead of Alter table privilege

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

Describe the bug
ALTER TABLE t1 rename to t2;
If you want to change the table name successfully, you need the drop permission of t1 and the create permission of t2 instead of the alter permission of t1. On the one hand, this causes the operation to become complicated, and on the other hand, it is not the same as the permission control of hive.
Affects Version(s)
master
Kyuubi Server Log Output
No response
Kyuubi Engine Log Output
No response
Kyuubi Server Configurations
No response
Kyuubi Engine Configurations
No response
Additional context
No response
Are you willing to submit PR?

[ ] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to fix.
[ ] No. I cannot submit a PR at this time.

would you like to fix this issue, you suggestion sounds correct to me. also cc @bowenliang123

OK, let's change the required privilege of the existing table from DROP to Alter.
And so far as you know what required privilege for the new table in Hive? None or Create? @diaolimin

Create permission is required to create a new table in Hive, and alter permission is required to change the table name, which is consistent with Hive.

Create permission is required to create a new table in Hive, and alter permission is required to change the table name, which is consistent with Hive.


Exceptions not catched in 0.8.0...

First one  appears repeatedly as a serie...
Traceback (most recent call last):
  File "/home/vit/Documents/dev/python/cutecoin/src/cutecoin/models/txhistory.py", line 54, in lessThan
    return (left_data < right_data)
TypeError: unorderable types: str() < int()

This one appears once in a while...
Traceback (most recent call last):
  File "/home/vit/Documents/dev/python/cutecoin/src/cutecoin/gui/currency_tab.py", line 182, in refresh_block
    will_expire_soon = (current_time > expiration_date*1000 - warning_expiration_time*1000)
TypeError: unorderable types: QDateTime() > int()

Don't have much infos for now. To be continued...

First exception not seen again...
Second exception fixed in c1b05990e8215c849caab637f0e0a7e9c81698b1


introduce AbstractRepeater

The AbstractRepeater is a base class for all attributes or elements that repeat views/templates over a collection. It's meant primarily to provide an abstraction for anyone who wants to create something like the baked in repeat attribute. The flexibility of the interface allows you to implement repeat-esque elements over more complicated components (particularly multi-dimensional datasets like a grid, where each "item"/"row" might actually have multiple views).
I think this is a good place to start, there are a number of nitpicks I can point out off the top of my head:

addView is more like createAndAddView
insertView => insertViewAt, as well as the above comment
removeView => removeViewAt
the list could go on

I'm not sure what kind of conventions y'all prefer, and am not tied whatsoever to the existing naming.

@jdanyow @martingust I'd love for you guys to review this. It could be a really nice improvement. Maybe there's even some way this could help with virtualization work being done too?

hey guys, to give a little bit of context about what this opens up you can take a look at the playground for the grid component I've been working on (with invaluable help from @jdanyow, as we descend into the bowels of the templating engine together :smile: )
https://github.com/mbroadst/grid-component/blob/master/src/grid/grid.js

I think this looks really good. @martingust what do you think? Any changes needed to make this work with the virtualizing repeater?

At first look, I think all the methods could be used in virtual-repeat, will definitely implement this in UI-Virtualization next. Perhaps even more can be abstracted out along the way. Really nice, great work @mbroadst!

So is that two +1's, or do you guys want to discuss alternative api naming/other ideas?

@jdanyow @martingust Shall we merge this?

@mbroadst - is this still good to merge? Just wanted to confirm because I know you're refactoring some things in your grid based on the viewRequiresLifecycle stuff. If so I'll do the perf tests, etc and get it in. I don't expect there to be any issues.
@martingust just to confirm- we're going to merge this in right away and iterate on it as-needed when you get a chance to incorporate this into the virtual repeater.  Does that sound right?

@jdanyow it's good to merge on my side. If anything, the things I would need for viewRequiresLifecycle can be added later (or I think at the moment just exposed). Either way this work needs to get in first

@jdanyow I've added updateBindings to AbstractRepeater, that's the final bit of code I think that can be abstracted out of the repeat strategies

@jdanyow That sounds right. All non public API:s that we can iterate over along the way. Perf tests would be great if you get a chance too run, nothing I can see that would impact the performance in any direction, but just to be sure.

tests passing, perf looks good in dbmonster.  Nice job @mbroadst!


Add a link to Subscriptions from Advanced Features

I keep going to Advanced Features’ Subscriptions section for the link and missing the link in the header of the page. Surely I’m not the only one… right? 😅

unstale


TODO: Support React native 0.73

testing branch: release/0.3.8

Update completed. Will be released in version 0.4.0-rc1 as a pre-release.


Passing function to Link doesn't work

I like the ability to pass a function to a Link in v4, but it's not working. In looking at the compiled source pulled from npm, it seems the wrong source code file is used for Link.js, it has no check for the function, but the code on Github does.

I just hit this...make sure you have "react-router": "4.0.0-alpha.3" installed and not "react-router": "4.0.0-2"  the docs also have this wrong and need updating

This was added in #3881 and we're probably going to iterate on this a little further (most likely by creating a <Navigation> component that <Link> uses). So, I wouldn't build on this just yet. <Link>'s API is pretty stable, but this part is rocky right now. Maintain a holding pattern for a little bit, please 😄


Update default version to v0.12.0

Based on this release:
https://github.com/telia-oss/sidecred/releases/tag/v0.12.0

Just waiting for @rickardl to run a task e2e as a sanity check 👍

@itsdalmo I got the E2E working, so everything is A OK


Kitura 2.6.1 tagged on master

It seems that 2.6.1 was tagged on the master branch, not kitura-2.6. Probably we should have backported the fixes we made on master that we wanted in 2.6.1.
See also https://github.com/IBM-Swift/Kitura-NIO/issues/164

@djones6 do you have time to sort this out on Monday?

The tag itself is fine: all of the commits in 2.6.1 are commits we intended for 2.6.1.  The only issue here is that the kitura-2.6 branch is stale, but we can just fast-forward it to the 2.6.1 tag.  I'll do that today.

kitura-2.6 has been fast-forwarded to be even with the 2.6.1 tag on master. Future 2.6.x releases should be cherry-picked and tagged from this branch, to enable us to accumulate changes in master for the next major.


Restructuring

Files / folders:

[x] trixi.h is the public interface definition, it should not change
[x] function pointers must be made available to multiple c-files. Move them to function_pointers.h/c?
[x] There are more general purpose routines like print_and_die, ...
Move them to auxiliary.h/c
[x] Organize C-API implementation according to purpose (setup.c, version.c, control.c, data.c)
[ ] Split Fortran interface specification accordingly in multiple *.f90 files?
[ ] Split Julia interface implementation accordingly? NO

Code:

[x] all interface routines should start with trixi_
[ ] isn't trixi_version misleading?

Maybe use trixi_libtrixi_version, although it is quiet long?
trixi_library_version?
also trixi_library_version_major, ...?
trixi_version_library to be consistent with trixi_version_julia?

[ ] remove julia_eval_string from interface to not let users execute arbitrary julia code?

Some thoughts:

function pointers must be made available to multiple c-files. Move them to function_pointers.h/c?

Sounds good to me.

There are more general purpose routines like print_and_die ... move them to internal.h/c, general.h/c, ...?

internal/general are imho too general (everything not an API is internal, and general... well, it's in the name). Maybe auxiliary.h/c?

Organize api implementation according to purpose (version, simulation control, data access, ...)

Sounds good to me.

Subfolders api_c and api_fortran ?

I wouldn't start to think about subfolders unless we exceed 20 files.

Use the some folder structure and sorting beneath LibTrixi.jl/src?

Sounds nice on first thought, but then might be arbitrarily restrictive. Maybe api.c and api_c.jl are already named similarly enough, the rest is not as important imho.

all interface routines should start with trixi_

Yes!

isn't trixi_version misleading? Maybe use trixi_libtrixi_version, although it is quiet long?

I agree, this seems weird to me as well. Maybe trixi_library_version?

I updated the description to reflect the current state and my thoughts? Could you have another look @sloede ?

* [ ]  Split Fortran interface specification accordingly in multiple `*.f90` files?

Did you keep the C API in one file? If it is not more than 500 lines, that's what I would probably do. If the C API is split up, I would either split up the Fortran API using the same structure/filenames or keep them in one file. Since the Fortran bindings are mostly interface definitions and should be part of a single module, using a single file is probably by far the easiest option.

* [ ]  Split Julia interface implementation accordingly? **NO**

No. As I said, I'd probably also leave the C API in one file, unless it gets out of hand.

* [ ]  isn't `trixi_version` misleading?

  * Maybe use `trixi_libtrixi_version`, although it is quiet long?
  * `trixi_library_version`?
  * also `trixi_library_version_major`, ...?
  * `trixi_version_library` to be consistent with `trixi_version_julia`?

This is slowly getting to the point of being just 🚲🛖ing. IMHO trixi_libtrixi_version is not a good choice, since someone who does not care about the Julia part will not immediately understand the meaning of the double "trixi".
The most consistent one would be, I agree, trixi_version_library/trixi_version_library_major etc. and trixi_version_julia/trixi_version_julia_extended. But the other option is fine too, really, anyone using these will probably look them up once, use them, and then forget about them anyways :-)

* [ ]  remove `julia_eval_string` from interface to not let users execute arbitrary julia code?

This might make for a nice debugging tool. I'd therefore keep it, rename it consistently to something like trixi_eval_julia, and provide a Fortran binding for it.


Fix #784 Add built-in AwsLambdaReceiver

Summary
This pull request fixes #784 - see the issue for details.
Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.

I can improve the code coverage. Any reviews / comments would be appreciated.

if it's possible to automatically apply the processBeforeResponse setting in the AwsLambdaReceiver? Or perhaps, we can set it to true when it's undefined? That way the developer can still disable it if they have a reason.

I am not really sure if there is a certain situation where a developer need to disable it for apps on FaaS. It does not work without exception (am I missing something?)
The reason why this receiver is quite simple is that we do not have the flag. It's possible to have the flag but it will make the code unnecessarily complex.

I am not really sure if there is a certain situation where a developer need to disable it for apps on FaaS. It does not work without exception (am I missing something?)
The reason why this receiver is quite simple is that we do not have the flag. It's possible to have the flag but it will make the code unnecessarily complex.

After This morning, I realized that processBeforeResponse is part of ExpressReceiver and not App. When I wrote the review, I thought the flag was part of Bolt's App. So, you can totally disregard my comment! My mistake.

We may want to update https://github.com/slackapi/bolt-js/tree/main/examples/deploy-aws-lambda once we release this receiver.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Now this PR is ready to merge.

Thanks @seratch! I'll merge this PR now.
I'll create a separate issue (unless we already have one) to add an example of AWSLambdaReceiver. We should not update our examples/deploy-aws-lambda until we update the deployment guide, because the guide references the example.
Regardless, it would be great to have examples of both methods - using the AwsLambdaReceiver and using the ExpressReceiver/Serverless express combo.


Modifying a project adds BOM at the start of the project

File -> New Project
Check Create new Git repository
Right-click on project and choose Edit
CTRL+S

Expected: For no changes to the project
Actual: The project has changes if you run git diff you see:
-<Project Sdk="Microsoft.NET.Sdk">
+<EF><BB><BF><Project Sdk="Microsoft.NET.Sdk">

   <PropertyGroup>
     <OutputType>Exe</OutputType>

No idea who's bug this is @333fred.

This is an msbuild issue, I'll move it over there. The issue is that we assume, in the absence of a utf header, that the default encoding of a file is UTF-8 w/ BOM, even if the file's original encoding was UTF-8 w/o BOM.

This issue was moved to Microsoft/msbuild#1768


Error when submitting files with md5 at the end of file name (using Webin-CLI)

From Nadim:
It is better for downstream processes, if the md5s are saved in a file as opposed to additionally tagged on the data file name.
E.g. If a user submits a file - file_1.fastq.gz, the upload tool creates a separate file for this, housing just the md5 value for the data file called file_1.fastq.gz.md5.
This is because it adds a separate step to extract the checksums from the filenames and create the corresponding md5 file. The data file(s) must end with fastq.gz, .bam or .cram for it to then be submitted by the user support bioinformatician with Webin-CLI.

Hi @z-w123 and @nadimm-rahman
@dipayan1985 explained that with the current application it is impossible to generate files - adding the md5 in the filename was the only way at this stage to handle the need for md5.
We'll look at other way to do this once the application is ported to Embassy, this will take a couple weeks.


chore: Improve release workflow

Description
Changes proposed in this pull request (what was done and why):

Use main tag for telemetry-manager image
Bump goreleaser to 1.23.0
Update release docs

Changes refer to particular issues, PRs or documents:

https://github.com/kyma-project/telemetry-manager/issues/656

Traceability

[x] The PR is linked to a GitHub issue.
[ ] New features have a milestone set.
[ ] New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
[ ] The corresponding GitHub issue has a respective area and kind label.
[ ] The follow-up issues (if any) are linked in the Related Issues section.
[ ] Adjusted the documentation if the change is user-facing.
[ ] The feature is unit-tested
[ ] The feature is e2e-tested

/hold

/unhold


fix: validate channel names properly

https://github.com/atc-net/atc-kepware/issues/31

Hi @JMolenkamp,
Thank you for the contribution. It looks good.
We can see that we also need it a few other places, so once this PR is in, we will improve it a bit and then create a release.


Add localization build

Summary of the changes

Create the XLF files needed to take advantage of "OneLocBuild" from Arcade
Add new resx files in a couple places to prove out the system.
Start running the "OneLocBuild" job in our PRs.

The next step will be to continue following the Arcade guide to get the Loc team working on producing our desired translations. Unfortunately I don't think we'll be able to set it up to automatically create PR's, but they're working on that.
Fixes: https://github.com/dotnet/aspnetcore/issues/33084

Looks like OneLocBuild is failing the pipeline due to missing Variables groups. We'll need those available to use in order to move forward. I've contacted the owner of this task and we'll move from there.

Talked offline with the arcade folks, OneLocBuild isn't run on PR's, it's a job intended for official builds. The result should be about the same in the end, but I've updated the yml to reflect this.


Both dark and light Starlight appears when JS disabled

What version of starlight are you using?
0.17.3
What version of astro are you using?
4.2.1
What package manager are you using?
pnpm
What operating system are you using?
Windows
What browser are you using?
Brave
Describe the Bug
With JavaScript enabled:

With JavaScript disabled:

I couldn't reproduce it. Specific to starlight.astro.build
Link to Minimal Reproducible Example
https://github.com/withastro/starlight
Participation

[ ] I am willing to submit a pull request for this issue.

Thanks for the issue @jermanuts! I know why this is happening — will make a quick PR.


Use cache directory with array localisation cache by default

This can make short requests a bit faster and reduce DB pressure. It causes localization cache to be cached via opcache instead of fetched from DB.
Disable the code that makes $IP/cache a symbolic link and rm's .htaccess. It is not reccomended that the cache directory be in the web directory. It matters less for the "array" method of localisation cache, but for other methods (which we are not using) this could result in private info being leaked.
I tested this by building the image locally, and using it with a modified version of the demo site docker compose.
https://wikiteq.atlassian.net/browse/WIK-799

abandoned in favour of https://github.com/WikiTeq/Taqasta/pull/80


Validate with cffconvert

This uses cffconvert to validate CFF files.

The full validation with cffconvert is quite expensive and slows down reading the dataset a lot: this should probably be optional.

Leaving open as this needs more work, e.g. --strict flag to trigger cffconvert workflow, and fixing things in the workflow (ideally work with cffconvert's developers to make this usable as library).


Set null value for response

On a non-EC2 instance, I'm seeing the following error.  As best I can tell, it happens because the response variable is never set if the EC2 metadata url doesn't exist.  Setting the variable to none appears to resolve the issue.
"/usr/lib/yum-plugins/s3iam.py" 463L, 17040C
        self.token = None
    return base.installPkgs(extcmds, basecmd=basecmd)
  File "/usr/share/yum-cli/cli.py", line 983, in installPkgs
    txmbrs = self.install(pattern=arg)
  File "/usr/lib/python2.7/site-packages/yum/__init__.py", line 4825, in install
    mypkgs = self.pkgSack.returnPackages(patterns=pats,
  File "/usr/lib/python2.7/site-packages/yum/__init__.py", line 1074, in <lambda>
    pkgSack = property(fget=lambda self: self._getSacks(),
  File "/usr/lib/python2.7/site-packages/yum/__init__.py", line 778, in _getSacks
    self.repos.populateSack(which=repos)
  File "/usr/lib/python2.7/site-packages/yum/repos.py", line 386, in populateSack
    sack.populate(repo, mdtype, callback, cacheonly)
  File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 227, in populate
    if self._check_db_version(repo, mydbtype):
  File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 319, in _check_db_version
    return repo._check_db_version(mdtype)
  File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 1512, in _check_db_version
    repoXML = self.repoXML
  File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 1698, in <lambda>
    repoXML = property(fget=lambda self: self._getRepoXML(),
  File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 1694, in _getRepoXML
    self._loadRepoXML(text=self.ui_id)
  File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 1685, in _loadRepoXML
    return self._groupLoadRepoXML(text, self._mdpolicy2mdtypes())
  File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 1659, in _groupLoadRepoXML
    if self._commonLoadRepoXML(text):
  File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 1479, in _commonLoadRepoXML
    result = self._getFileRepoXML(local, text)
  File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 1256, in _getFileRepoXML
    size=102400) # setting max size as 100K
  File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 1022, in _getFile
    result = self.grab.urlgrab(misc.to_utf8(relative), local,
  File "/usr/lib/yum-plugins/s3iam.py", line 194, in grab
    self.grabber.get_role()
  File "/usr/lib/yum-plugins/s3iam.py", line 244, in get_role
    if response:
UnboundLocalError: local variable 'response' referenced before assignment

Setting to work in progress, root cause appears to be the timeout on the urllib request, need to investigate further

Would it be possible for you to add a metadata_timeout configuration setting and use this value in the urllib2.urlopen call. Default value should be None in order to keep existing behavior, but people using the plugin outside EC2 will be able to lower the timeout via configuration.

I can, but I'm not sure that it's necessary.  I tested the response time for the request to the metadata URL and was seeing averages under 200ms.  Even at a 1 second timeout there should be plenty of time for it to get the metadata before timing out if it's running on EC2.  I hesitate leaving the default as no timeout; because urllib2 has no default timeout it will just run forever until manually killed, which is not ideal.


Data store improvements

Problem
The organization of our query and data stores was somewhat emergent from the organization of the chain queries and not planned at a high level. We have a lot of query stores that fetch and do highly-coupled compute on low-level chain data/primitives (notably gauges, locks, etc), then we have some data stores that wrap those query stores and do additional computations. Those data stores are not in the root store, but are created and used as needed, which may or may not be inefficient as the user navigates the pages, and sometimes causes us to repeat/copy&paste the computations (I've spotted this most noticeably in the various pool card views).
Proposed Solution
We may be able to remove a lot of repeated (or dead) code by investigating the following:

Separate calculations from query stores. The query stores should simply query the data, and provide computed properties that return that data in a parsed format with clean TypeScript types that include parsed keplr-wallet/unit objects, Durations, Dates, etc.

We should create a document or FigJam that identifies all the view-dependent data models that we currently use, and we should collaborate on finding co-dependencies and then organizing them into logical data-oriented stores. Our focus should be on only performing calculations as needed for the user as they navigate the various views. Make heavy use of map stores. Some of this work already emerged in the pool details store and superfluid pool store.
We should move data stores into map stores in the root store. For example, the aforementioned pool detail store and superfluid pool store should be a map store from poolId->store in the root. If we do that alone, we could save computation as a user navigates to/from pool detail pages and pools/assets pages (for the pool cards on those pages). Furthermore, the pool cards could reference those stores for calculating the metrics on the various flavors of pool cards we have.

New data stores could contain a hydration mechanism. Currently, from the pool query optimization/pagination work, the imperator pools query also contains a lot of attached asset price and pool liquidity data. Currently, to avoid anything hacky, we simply ignore those values and refetch them separately later (bearing the additional resource load for both this pools query and future imperator metrics queries). If we were to do this refactor with a hydration mechanism, we may be able to populate a lot of those values from the pools query store and avoid some querying later in the app lifecycle. In effect, we should have query stores be dependent on our data stores, as they should be loading data then "hydrating" (populating) the various relevant data stores. Note: the hydration mechanism proposed here would inverse the dependency relationship (data<-query) outlined in the query store computed property comment in the first bullet point.
All query stores should only fetch data as needed. The base keplr-wallet MobX query store is very powerful (cancellation, caching, revalidation, stale requests, etc.) but it's default is to fetch from the provided endpoint when it is constructed/initialized, when the root store is initialized on app load. We should formalize (perhaps by creating our own base store) what was done in the new ObservableQueryFilteredPools class by only fetching data as it is requested by the views (by overriding the canFetch function). This let us avoid a full pools query in the pool detail page, amongst other areas. Though, some of our current query stores extend the HasMapStore which will only initialize a query store (and thus kick off a query) as keys are encountered (example, gauges). We may be able to leave those HasMapStore child query classes alone, but we should make sure we're only requesting data as needed with the rest of the query stores. To accomplish this, we could look into extending the HasMapStore in more places, as it results in a small amount of code to maintain.

Further, still, it may be worth investigating using react-query to handle this work of fetching/caching/invalidating data, then we could use wrapper hooks as the data stores on the resulting query data. We could rest in peace knowing the data is only queried once in the app lifecycle. Then, we could remove the use of MobX entirely for managing queried data, though I still think it's useful for the UI config stores.
See this article:
https://www.andronio.me/2021/11/15/migrating-from-mobx-state-tree-to-react-query/


Launched DBeaver on Laptop without external monitors, top of window and all menu bars were off-screen

Description
Today was the first time I tried using DBeaver on my laptop without being hooked up to my dual 27" monitors.  Normally, I run DBeaver on my secondary (right) 27" monitor, large window, in Restore (or Normal) mode, but not Maximized.  When I tried launching DBeaver without any external monitors, only the text editing pane was visible.  The Database Navigator was off-screen on the left, and all of the menu bars were off-screen at the top.  Normally, other Applications will force opening to be full screen or maximized in the case of going from large external to smaller native monitor.  I was able to find the Windows shortcut for Maximize  + , so I was able to recover.  Suggest that if DBeaver window controls would be off-screen on launch to force the top of window to be onscreen or Maximized when launching.

DBeaver Version
Version <IP_ADDRESS>406021658
Operating System
Windows 10 Enterprise
Database and driver
NA
Steps to reproduce

With dual monitors attached, which each have higher resolution that laptop native resolution, open DBeaver
Move DBeaver window to the secondary monitor.
Resize window such that it is large, but NOT maximized, and the top of the window is near the top of the screen.
Close DBeaver, and power down.
Disconnect external monitors and any docking station
Power on Laptop and login
Launch DBeaver
Verify that it opens with left and top of window being off-screen and that nothing can be clicked or dragged to bring window controls on-screen
Hit  +  to Maximize the window. Verify menu bars and Navigation pane are now visible

Additional context
No response

Note that the left and right arrows and the content between them were stripped from my notes.  The Windows shortcut to Maximize a window is "Windows Key" + "Up Arrow"

The reason is that the desktop window coordinate axes could be different when the external monitor was attached. The application just correctly restored its' window position from the previous launch, but due to another desktop-screen translation you've got such a positioning.


New data source's field on a form extension cannot be wrapped in extension class

Hello,
I found that I cannot create an extension class for a field of the form's data source if the data source was added in a form extension. If the data source is not on a form extension, then I can create extension class.
I am working in PU24.
I get the following error at compile time.
Abnormal termination with unhandled exception. Exception key: ... System.NullReferenceException: Object reference not set to an instance of an object.
Is this solved in any later PUs?
I think it would be good idea to update the documentation.
I also wrote a short blog post about it:
https://elandax.blogspot.com/2019/05/how-to-extend-forms-data-source-field.html
Respectfully,
Evaldas

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a2b3708d-a8c1-612b-f4f3-9802ad0c5448
Version Independent ID: d2f14c0f-b695-a234-53ef-864d8e243d14
Content: Class extension - Method wrapping and Chain of Command - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/dev-itpro/extensibility/method-wrapping-coc.md
Service: dynamics-ax-platform
GitHub Login: @ChrisGarty
Microsoft Alias: cgarty

@ChrisGarty @RobinARH  Can you take a look at this one? Thanks.

Bug 328761 created to track this issue.


docs(builds): Include doxygen in package list.

:+1: we also have pandoc installed on the server. We should mention that too.


"Cancel Shipment" option confusing for an unshipped order.

When I go to the order details page of the Dashboard, there's a button to "Cancel Shipment" for a newly placed (unpackaged) order.
What I'm trying to achieve
A more intuitive interface.
...
Steps to reproduce the problem

Go through the checkout process with any number of items, and finalize the order.
Go to the newly created order in the Dashboard.

What I expected to happen
For there to be a "Cancel Order" or "Abort" button.
...
What happened instead/how it failed
There's a "Cancel Shipment" button (which I believe to be confusing since the order hasn't been packed or shipped yet).
...

Hi @jfialkoff :)
You’re right, this naming might be misleading. Actually, Cancel Shipment means that you can cancel part of your order included in this shipment (which is understood as a group of ordered products; there may be many shipments in an order), whether is has been dispatched or not. Cancel Order action is also available - it’s placed in the collapsable menu in the upper right corner of the order details page.
We are working on replace Shipment (DeliveryGroup in our code) with Fulfillment right now, so we will get rid of this misleading naming. You can see those changes in #1777.
Thank you for your feedback :)

Ahh, thanks for the explanation. Sounds good! Looking forward to seeing the
changes.
On Mon, Mar 12, 2018 at 4:27 AM, Anna Siwik<EMAIL_ADDRESS>wrote:

Hi @jfialkoff https://github.com/jfialkoff :)
You’re right, this naming might be misleading. Actually, Cancel Shipment
means that you can cancel part of your order included in this shipment
(which is understood as a group of ordered products; there may be many
shipments in an order), whether is has been dispatched or not. Cancel
Order action is also available - it’s placed in the collapsable menu in
the upper right corner of the order details page.
We are working on replace Shipment (DeliveryGroup in our code) with
Fulfillment right now, so we will get rid of this misleading naming. You
can see those changes in #1777
https://github.com/mirumee/saleor/pull/1777.
Thank you for your feedback :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mirumee/saleor/issues/1889#issuecomment-372227834,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABtQnuTwnLBAIQKsUzXQ15aihuNzu-o4ks5tdjGCgaJpZM4SjVgE
.

--
Joshua Fialkoff
https://www.facebook.com/prof.fialkoff/
https://www.instagram.com/joshuafialkoff/
https://www.youtube.com/channel/UC7ysxr3B4DhS_3xSEPxuebQ
support me on patreon (and get free stuff)
https://www.patreon.com/joshuafialkoff
www.joshuafialkoff.com

Resolved in #1777


docker.jsonet.binary_disabled and docker.jsonnet.virtualhost_disabled default values

Those propertiers default values should also depend on binary.disabled flags and traefik.disabled flag. If these features are disabled, it should not generate jsonnet related values.

Fixed with #177

Fixed with #177


Getting error when doing Sign transaction & Sign Message

I have configured app, it's popped-up in simulator, but when I clicked on Sign Transaction or Sign Message I am getting Error. Please could you help me?

@hewigovens

@hewigovens

Does this connect to Live Trustwallet app? does it require ethers in wallet? Pleases could you reply some one.

Did you run the demo on device? It will connect real Trust app; you don’t need ethers to sign a message

Did you run the demo on device? It will connect real Trust app; you don’t need ethers to sign a message

I'm running in Android simulator.

In this case you have to install the demo wallet here : https://github.com/TrustWallet/TrustSDK-Android

In this case you have to install the demo wallet here : https://github.com/TrustWallet/TrustSDK-Android

I have installed Trustwallet on Android simulator and logged in with my private phrase key. Trust wallet is working fine on my Android simulator. Only thing is this app is not working as expected.

which version did you install? I'll reproduce this issue

which version did you install? I'll reproduce this issue

I have installed 0.0.6 => react-native-trust-sdk

Sorry I mean the version of Trust Wallet

Sorry I mean the version of Trust Wallet

Trustwallet version is : 1.6.131

I can't reproduce... Do you have any error logs?

@hewigovens the below are the error logs, please check.
code that I have altered.

Below is the screen which i get when i use app

My colleague @ysong-virtusa and me were trying.

hmm, did the example app jump to Trust or just show the error directly?

we use react native Linking.canOpenURL/openURL API to detect if Trust is installed. Could you please check if those API work on your simulator?

we use react native Linking.canOpenURL/openURL API to detect if Trust is installed. Could you please check if those API work on your simulator?

sorry. I observed the API URLs are not opening in my machine due to some firewall security in my office laptop. I have tried same API is opened in another machine. thank you. I will check and get back to you.


chore: remove redundant integrality condition in IsSeparable

I think there was a build error, but otherwise LGTM, thanks!
bors d+


Bug assline

Occasionally it happens that assline crashes and some of the items are left in the drovers

Still have the exact number of items left in drawers?

Better set the update interval of decoy bus to 1 ticks

Still have the exact number of items left in drawers?

Out of the weird stuff, it leaves x1 of one item randomly and everything else can be in drovers but their number will be 0

Better set the update interval of decoy bus to 1 ticks.
Not much clues for this... How many times has it happened so far?

Many times, most often it was if you were crafting an energy hatch and the bug left coolant cells in the drawers

Now out of 1000 сrafts this one has broken 1 time

Can you upload the savefile？
And I might be slow in investigation of this bug this week, I will have more time after that.

Still have the exact number of items left in drawers?

Out of the weird stuff, it leaves x1 of one item randomly and everything else can be in drovers but their number will be 0

That is to say, the shutdown tends to happen on the last batch, is that correct?
Or does it void almost anything even there are several batches left to do?

Can you upload the savefile？ And I might be slow in investigation of this bug this week, I will have more time after that.

I can assume that only recipes with the same items in different slots are buggy, because only they remain in the drowers

Can you upload the savefile？ And I might be slow in investigation of this bug this week, I will have more time after that.

I can assume that only recipes with the same items in different slots are buggy, because only they remain in the drowers

So does it only happens when there's only one group of materials for one single recipe?

Can you upload the savefile？ And I might be slow in investigation of this bug this week, I will have more time after that.

I can assume that only recipes with the same items in different slots are buggy, because only they remain in the drowers

So does it only happens when there's only one group of materials for one single recipe?

This recipe has caused the bug many times before and now again and has 2 identical plates in it

Maybe there's something to adjust here?
I tried changing the drowqers to super chest and it didn't work.

I get it.
I want to know that:
has it ever happened when  the amount is, like
10 40 40 40 40 10

Maybe there's something to adjust here? I tried changing the drowqers to super chest and it didn't work.

Well setting refresh tick to 1 should relieve the bug, but not eliminate the bug.

I can assume that only recipes with the same items in different slots are buggy,

I ordered 10 radiation proof and crafted fine

I might have figured it out.
It's a bug of Priority Filter Bus, it only auto-marks the items in storage of same priority,
but when auto-pull, it shows amount of this item from all storages.
For example, amount is
1 4 4 4 4 1
The first Priority Filter Bus shows 2 Radiation Plates.
But when extracting items, there's only one available in the frirst storage, so it crashes.
This might happen if Decoy Bus failed to update in time, and assline will try to find from the Priority Filter Bus.

But sorry I have to wait until next week to post the fix.

try this
https://github.com/reobf/Programmable-Hatches-Mod/releases/tag/v0.1.1p3-beta


Link to Kiosk Mode On Event Page

We need to be able to link to the kiosk for a specified event from the Track Volunteers tab on an event's page.

This should be implemented somewhere in the area of the search bar above the table for adding volunteers.
Related files:

app/controllers/events/routes.py
app/controllers/admin/routes.py
app/templates/events/eventKiosk.html
app/templates/events/trackVolunteers.html
app/static/trackVolunteers.js

 CELTS #109: Link to Kiosk Mode On Event Page


The implicit move assignment operator to the eosio::multi_index

Working on the eosio smart-contract I bumped into the issue that there is no  the implicit move assignment operator for the eosio::multi_index.
Is there plans to add the implicit move assignment operator to the eosio::multi_index?

Can you  explain in what case you need move assignment operator for eosio::multi_index?

Why you need the move operator for multi_index? Couldn't you put it as member of your class?

A smart-contract class has 3 multi_index containers and 2 constructors. First class constructor initialize containers. The second constructor is used in the case of eosio.token::transfer event, when required for the containers initialization argument is computed in the event handler (mycontract::transfre). The second constructor doesn't initialize containers.
In the current implementation, there are 3 solutions for this case:

Don't use macro EOSIO_ABI, MY_ABI, etc, and write void apply by yourself. In the apply write handler for events (like eosio.token:: transfer). But I think that is not C++ way and I don't want to duplicate the same function calls that could be generated by the MY_ABI (EOSIO_ABI) macro.
Use pointers to the containers and mycontract::init() method, that can be called from the handler of event handler (mycontract::transfer).
Use static mycontract::transfer and custom MY_ABI macro, that generates execution of the static methods of the mycontract. In the static mycontract::transfer compute needed argument, create instance of the class using first constructor (which initialize multi_index members) and do needed actions with multi_index members.

Currently, I use 2nd way. Therefore I thought about this->multi_index1 = std::move(multi_index<a,b>(c,d)) in the mycontract::init.
But now I think, that 3 way will be truly C++ and safer than 2nd, and doesn't require std::move support.

Would you mind giving us a short example in which move operator is considered necessary?

class mycontract
{
    struct record_t
    {
        uint64_t id;
        ///...
    };
    typedef multi_index<N(records), record_t> records_t;

    records_t _records;

  protected:
    void init(uint64_t scope)
    {
        _records = std::move(records_t(_self, scope));
    }

  public:
    mycontract(account_name receiver, account_name scope) : contract(receiver)
    {
        init(scope);
    }

    mycontract(account_name receiver) : contract(receiver)
    {
    }

    void action1()
    {
    }

    void action2()
    {
    }

    void transfer(const currency::transfer)
    {
        account_name scope = string_to_name(transfer.memo.c_str());
        init(scope);
        //...
    }
};

MY_ABI(mycontract, (action1)(action2),(transfer))

MY_ABI generates apply where for action1 and action2 code is an argument of the apply function, for the transfer code is computed in the transfer function. But as I said above, currently static transfer method with one constructor can be used instead of the init() function.

I still don't think it necessary to include a move operator as it would bring more overhead: You can simply do records_t *_records = nullptr; then _records = new records_t(_self, scope) anyway.


Fix ImagePickerActivity Opening Gallery or Camera Twice

Fix ImagePickerActivity where when crop is enabled AND using start() with the completionHandler, the gallery or camera app opens again after a photo is selected/confirmed.

 ImagePicker.with(this)
                    .provider(ImageProvider.GALLERY)
                    .crop(3f, 4f)
                    .maxResultSize(150, 200)
                    .compress(500)
                    .start { resultCode, data ->
                        when (resultCode) {
                            Activity.RESULT_OK -> {

                            }
                        }
                    }

It doesn't fix yet, I have the same problem with version 1.7.1

Closing this pull request, As issue is resolved now #32


moveTo() isn't working.

I am unsure how to troubleshoot this.
The aim of this script is to manually run a browser (any browser, any version) to create internet artifacts for analysis.
So far, I just have the script launching the browser, moving the mouse to the address bar, and typing in the string.
It works fine when I do this once.  But, when I try to do this twice, with a 15 second sleep between them, I get this error :

The visible behavior is that it moves the mouse to the address bar, selects current text, but doesn't delete it.
Attached is the .py file.
bstest.txt
Any help would be appreciated.

I can see you're running the script on Windows. I've made the Pull Request "By pass PermissionError [WinError 5] #94" suggesting by pass a permission issue on Windows when we try use some functions like "_sendMouseEvent(MOUSEEVENTF_LEFTDOWN, x, y)".
Try this in your code:
try:
    pyautogui.click()
except PermissionError:
    pass

This was fixed (or at least, worked around) in b53b659


Camera roll functionality not implement or Missing   #not an issue

Thanks for the InstagramPhotoPicker .it looks great But i could not find camera roll functionality like instagram may you have missed that . if you could do that it will be great  .thanks

I'm working on making a fix for this... i have to do it for my project as well. I also implemented multiple photo selection if interested

Thank you for this functionality .
But I am looking forward to Camera roll Functionality
:)

Hi @sunny45 if you take a look at my fork of this project I have implemented the camera roll functionality that is missing.

@vladzz Great Job thanks
.


Use $IMAGE_DISAMBIGUATION_SUFFIX if set.

If the $IMAGE_DISAMBIGUATION_SUFFIX environment variable is explicitly set (normally only by TeamCity), then we:

compile templates before testing and building images,
use the variable in metadata.sh to prevent clashes of docker images between multiple in-flight PRs.

We temporarily unset the variable when checking template expansion in run-pre-checks.sh.
Fixes: https://github.com/kudobuilder/operators/issues/234
TODO:

[ ] get the shared part of this logic (which actually exports the variable) merged: https://github.com/mesosphere/data-services-kudo/pull/56
[ ] rebase on it

It seems GitHub is having problems assigning reviewers to PRs.
@nfnt @zmalik please review.


use parallel testing

What does this PR do?
Try to speed up tests with some parallel execution
Alternatives:

https://pypi.org/project/pytest-parallel
https://docs.pytest.org/en/3.0.1/xdist.html

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

using xdist:

fails on parallel access to zip datasets
no speedup for Ubuntu nor Win
speedup for macOS from 16min to cca 5min

using parallel:

speed up fro Ubuntu from 4 to 2min
min config for Ubuntu and all macOS is hanging
complete failer on Win for INTERNALERROR

@Borda
pytest-xdist needs pytest >= 6.0
https://github.com/pytest-dev/pytest-xdist/blob/14bafa6dd5319a83e694cdfea3c2c9d3915c1082/setup.py#L3


support to skip field touch for onFieldChange fn

Looks mostly good, I've checked out and run the tests and would be happy to merge with those 2 minor changes (adding the type and wrapping the if block in brackets)


Array types are incompatible

Is your feature request related to a problem? Please describe.
I am a bit frustrated with the use of this pattern:
State extends "empty" ? [] : [RTNode, ...RTNode[]]

In my code, I have custom types holding data like nodes: RTNode[] or slices: Slice[]. However, these types are not compatible with [] | [RTNode, ...RTNode[]].
I would love to hear more context about this pattern and why did you decide to use it instead of never[] | RTNode[].
Describe the solution you'd like
Ideally, Typescript would understand that [] | [RTNode, ...RTNode[]] is equivalent to RTNode[] (both ways). Until then I would prefer simpler types without this State (e.g. never[] | RTNode[])

Hi @Laruxo, I'm sorry for the late reply.
State extends "empty" ? [] : [RTNode, ...RTNode[]] was preferred over RTNode[] because it more explicitly defines what happens when a field is empty or filled.
The State type parameter allows the types to be smart enough to tell you when you are passing a field value into something that expects a filled value. @prismicio/client's isFilled helpers (e.g. isFilled.image(imageField)), lets you narrow the type to a filled or empty value. That narrowing could help write stronger code that is type checked. If you don't use the isFilled helpers, should still be able to conditionally access properties by performing other runtime checks.
We recommend that you use the field-level types from @prismicio/client rather than the lower-level types like RTNode and Slice[]. For example, you can use RichTextField and SliceZone instead.
I'll leave this topic open for now in case you or anyone else would like to share other viewpoints. What I explained above details our original design, but that doesn't mean we can't change it. 🙂

Closing as stale, happy to reopen if anyone wants to continue the discussion~
Thanks for contributing!


ESM1.5 ZECMIP additional  runs

resolution_complete type_non-CMIP6   |    by<EMAIL_ADDRESS>
ZECMIP style runs with branching points from 1pctCO2 experiment at years 154, 168, 181, 194, 205, 216. This corresponds to total emissions of 750, 1000, 1250, 1500, 1750 and 2000 PgC.
exp name: PI-ZEC-{branch year}-02
branched from: PI-1pct-02 at branch years given above
(processing only at this stage)

Issue migrated from trac:397 at 2024-01-31 18:37:58 +1100

<EMAIL_ADDRESS>changed status from new to closed

<EMAIL_ADDRESS>set resolution to complete

<EMAIL_ADDRESS>changed milestone from Run complete to Archived


ci: temporarily disable F32 rpm-tests

The F32 mirrors are currently out-of-sync. This might be related to the
repo freeze that is ongoing. Lets disable F32 until it is released, so
our CI can do its job again.

(Apparently it is already working again; lets wait with merging)

Yeah, seems to be fixed already. Lets close this.


chore(sdk/go): use xerrors from library

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Could you, please, add some motivation behind this change to description.

YTsaurus have xerrors in library - why not use this instead external experimental package?


Handling nested code block (triple backtick inside codeblock)

Information

version: 7.2.0
I'm also using react-syntax-highlighter
Framework: remix

I'm facing issue where i have code block like this:
const text = 'this is just an example\n```javascript\nconsole.log(`hello`)\n```'

as you can see that github mark down make it good code block, but with markdown-to-jsx this is what i get

const CodeBlock = ({ children }: { children: React.ReactElement }) => {
  const { className, children: code } = children.props;

  const language = className?.replace("lang-", "");
  return (
    <SyntaxHighlighter language={language}>
      {code}
    </SyntaxHighlighter>
  );
};

import Markdown from "markdown-to-jsx";

<Markdown
    options={{
        forceBlock: true,
        overrides: { pre: { component: CodeBlock } }
    }}>
     {content}
</Markdown>

In this way, code block will be rendered properly. (It works for my project)

const CodeBlock = ({ children }: { children: React.ReactElement }) => {
  const { className, children: code } = children.props;

  const language = className?.replace("lang-", "");
  return (
    <SyntaxHighlighter language={language}>
      {code}
    </SyntaxHighlighter>
  );
};

import Markdown from "markdown-to-jsx";

<Markdown
    options={{
        forceBlock: true,
        overrides: { pre: { component: CodeBlock } }
    }}>
     {content}
</Markdown>

In this way, code blocks will be rendered properly. (It works for my project)

Thanks for your response, It still not give me a good result. Can you make sure that your code block is triple backtick (i.e ```javascript) not quad (i.e ````javascript).
I know that four backticks will solve the problem, somehow I don't have control to the response that I get from OpenAI

https://github.com/quantizor/markdown-to-jsx/issues/515 might be related.
If you have control of the markdown content source, try ensuring fenced code blocks are preceded by two newlines instead of one.
- const text = 'this is just an example\n```javascript\nconsole.log(`hello`)\n```'
+ const text = 'this is just an example\n\n```javascript\nconsole.log(`hello`)\n```'


Screenshot of the search form is out of date

Hi, The screenshot for the audit search form is of the old form. It has been updated.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3494b782-92ad-e365-3398-bd2d760d10c6
Version Independent ID: fa4bca98-3975-23dd-dfac-f23049c71d01
Content: Search the audit log in the Microsoft Purview compliance portal - Microsoft Purview (compliance)
Content Source: microsoft-365/compliance/audit-log-search.md
Service: o365-seccomp
GitHub Login: @robmazz
Microsoft Alias: robmazz

@robmazz Please help us in resolving this issue. Thanks


Check AsciiDoc files

We should ensure that the AsciiDoc files can be converted correctly. That could be achieved by adding the following command to the check_doc make target:
asciidoctor --safe --warnings --failure-level warn -o /dev/null doc/*.adoc

We would need to add asciidoctor as a development requirement.

@treiher Can we close this now when #1119 is done?

We can close it now, as we already have no AsciiDoc files on main anymore.


Fix for Sign In Method With Two Workflows

This merge request uses the code in merge request #233
This issue aims to fix #232 and in addition allowing mintapi to sign in if username and password are on two separate pages or not (both can happen at time of writing).
Summary:

Broke the sign in process and getting a web driver at mint.com from get_web_driver into _sign_in and _create_web_driver_at_mint_com for ease of testing
Made a try/except loop to detect if username and password are on the same page or not
Allowed the sms button to not necessarily be clicked if it is not required (I didn't remove the old method because I wasn't sure if sometimes mint.com would supply that workflow. I never saw it but it still could happen.)
Added test_args.json to .gitignore and made tests.py try to read that for test arguments. I would love feedback on doing this. I did this as an attempt to allow developers to pass in their credentials to the tests to make the tests automatable. I initially tried using command line arguments, but that method breaks vscodes test specifier (and I imagine other IDEs too).
Also added .vscode and chromedriver to .gitignore for ease for developers.

Sure thing. They got added in because I broke the flake8 pipeline job and because I was lazy, I just ran autopep8 on it. I'll remove the unnecessary changes.

Great job, everybody. I re-installed with pip (to 1.50) and was able to get headless=False working with a manual click on SMS in the browser popup. However, I was not able to get headless=True working like it used to before the Mint login change. Automated login seems to hang/spin, and I'm wondering if mintapi is not detecting the MFA prompt. Anybody experiencing the same issue? Chrome 93.0.4577.82.

@revelario you should probably ask this on the discord or in a separate issue so more people can see it. Feel free to post in one of those two and I'd be happy to respond.


VibrationStrength not working with xboxone controllers

i've tested the game with a wired Xbox Wireless Controller, and both the VibrationStrength and ImpulseVibration*Multiplier setting seems to have no effect.
(The controller is vibrating with same strength regardless of the setting)

Sorry, posted in the wrong repo...

What repo did you want to post it on? I'm genuinely interested!

https://github.com/emoose/OutRun2006Tweaks/issues/51


Position of Dropdown menu with placement bottom-start/end covers bottom part of the button

What happened?
The dropdown menu is covering parts of the underlaying button. We would expect the menu to be located under the button - as "placement="buttom-end" suggests.

What type of frontend frameware are you seeing the problem on?
Angular
Which version of iX do you use?
v1.4.0
Code to produce this issue.
<ix-dropdown placement="bottom-start">

Cannot reproduce with latest version


Version Info Bootsplash

This change will display the EuroPi firmware version on the OLED display when the EuroPi first boots up before the selected script (or menu) loads and overwrites the display.
The display will show a bootsplash like this:
+--------------+
|  EuroPi ver: |
|    0.6.1     |
|              |
+--------------+

This change also separates the version info into a separate importable / parsable format which can be used by both the EuroPi firmware and the PyPi distributable setup.

This is a lovely idea, and it fixes something I've noticed for a while which is that when you turn on your rack all the EuroPis look dead for a few seconds, so it's a nice way just to show the user that it is plugged in and working!
I will probably work on some kind of extra design like @mjaskula suggested but that can be a later PR, after working out how to combine/remove  one of the version.py files this LGTM

I just tested the new bootsplash image and it works great, looks great, well done!


Mobile Platforms

The game is curerently only targeted to a Desktop environment. A client is also needed for mobile platforms (at least Android and iOS)

This needs to be tested on Android and iOS. I hope @bazola can do the testing on iOS

It has now been confirmed to work on both Android and iOS


update travis configuration to use the standard ROS repositories path

@ipa-nhg fyi: I've updated the base to kinetic-devel instead of the branch I used for #210.

Somehow I cannot get Travis to build this PR.
This PR is also not listed on the Travis admin interface.
Could you perhaps resubmit the PR @ipa-nhg?

Replaced by #229.


Use RHEL 8 for builder base for func-util image

Use RHEL 8 for builder base for func-util image as we use UBI8 for the runtime image too.

/approve
/lgtm


--attrs Doesn't properly handle escaping commas

When making an external web request, You can set http.url as an attribute to the request. However, the spec states that it should be the full request. The issue is, a URL can look like: https://example.com?a=b,c=d. If you were to pass this via --attrs "http.url=https://example.com?a=b,c=d", the values would be split on the comma, resulting in:
http.url=https://example.com?a=b & c=d
Attempting to escape the comma doesn't seem to work, I tried:

--attrs "http.url=https://example.com?a=b\,c=d"
--attrs "http.url=https://example.com?a=b\\,c=d"
--attrs "http.url=https://example.com?a=b\\\,c=d"

All of which resulted in the value still being split on the comma

Thanks for the report! This should be fairly easy to fix. I think that code is using an older hand-written parser and there's already a newer one in otel-cli that uses encoding/csv to parse, and that should do the trick for us. I'm pretty swamped this week but should be able to take care of it early next week.

I dug into this while traveling and it looks like it's a documentation bug and not a code bug.
I took one of your examples to create a test and started poking around. Since the --attrs flag is parsed by pflag via cobra, it is already parsed by the Go encoding/csv package and escaping should all work according to CSV rules. I had to go look these up and ended up with this:
https://github.com/equinix-labs/otel-cli/commit/61b537ffcaf3c54cc126daacbbefdc4fe5abd64b
I'll keep working on the branch to patch up a couple places I hand-rolled formatting data and add some notes to the docs so it's clear to expect CSV semantics. I'll add an example too that shows how to escape the CSV in shell so it gets to the command correctly.

@BenB196 ^^ can you please give CSV formatting a try in your experiments? I believe it should work with the current release. The trick seems to be that quotes will need escaping so the shell doesn't eat them, and the commas can come through bare e.g. --attrs item1=value1,\"item2=value2,value3\",item3=value4 or wrap it all in single quotes --attrs 'item1=value1,"item2=value2,value3",item3=value4'

Hi @tobert good news, I tested your recommendations and they seem to have worked correctly. Thanks!

Hurrah! I'm going to keep this open and tag it as a documentation issue so I don't forget to add CSV examples to the README and elsewhere.

With #165 merged there is now a note about escaping attribute values in the README.md.


Fonts and Display Edits

added font options, edited apostrophe out of description, changed background and cover css position, cover photo choices in comments
--- Choices ---
Header Fonts

Abel
Ropa Sans
Assistant

Content Fonts

Gidole
Open Sans

New Edits:
Cover height to 500px
Cover photo options in comments
Navbar sidemenu hamburger fontawesome icon with Material Icons sidemenu icon

All Material Design Icons imported into index.html


[DO NOT MERGE] Auto PR to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-no_auth.sh
d5c7a8ff62138c9461205b91c50f1a9af5d8bdfd
link
/test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Enable 32 column tables by default, move features around

This deprecates the names large-tables and huge-tables in favor of
32-column-tables and 64-column-tables. 32-column-tables is enabled
by default. On my machine this changes the compile time of Diesel from 8
seconds to 18 seconds, which I think is an acceptable loss. The feature
can still be turned off for cases where compile times are important.
The way we do the deprecation warning is really funky but I don't know a
better way to do it

Release mode timings:

16 columns

9.87 secs

32 columns

20.56 secs

64 columns

82.36 secs

128 columns

¯\_(ツ)_/¯ probably forever

Note: Diesel itself has so little code that release mode doesn't generally affect it. Only release mode for libs using Diesel.

128 columns

¯_(ツ)_/¯ probably forever

that's true. I approve that by my experience and if you are building a docker image with 128 you will never be able to deploy in production for sure.


Add binary payload handling to PyLECO

Implements the transport of binary data in additional frames, related to How to transmit binary data (https://github.com/pymeasure/leco-protocol/issues/65).
Idea:

First payload frame is JSON
Second (and more) frame are binary

Implementation ideas.

MessageHandler offers the whole message for the rpc handler and adds the additional frames afterwards
Communicator can return the bytes
Communicator (and Director) can send bytes in a rpc request

Open questions:

[ ] Should a message with binary data contain a different message type?
[ ] If not, how to know, whether the binary data is the desired response instead of the json response?
A return value of None with additional payload frames is a strong indicator, but not exclusive to this scenario. Is it sufficient?
[ ] The additional_payload of the Message: what to do, if there is no data defined: should there be an empty first data frame before the additional, or is the additional_payload the whole payload?

@seb5g, in this PR I experiment with the transport of binary data via PyLECO.

I ask for feedback regarding the current implementation:
This is how you call the method some_funny_method with additional binary payload (for the method):
# on the remote side (on MessageHandler):
def some_funny_method(self):
    additional_payload = self.current_message.payload[1:]
    # do something with additional_payload
    self.additional_response_payload = [b"whatever", b"to return", b"binary"]
    return None

# on the requester side:
ask("receiver", method="some_funny_method", additional_payload=[b"123", b"456], extract_additional_payload=True)
# returns: [b"whatever", b"to return", b"binary"]

The parameter extract_additional_payload (independent of the additional payload on the way to the remote contact) will return the binary return value of some_funny_method, if the JSON response value is None.

I think its a tricky question in general as seen by some questions you raised in the issue.
Currently I allow either returning either of non-serialized data or serialized data only. Not both. Technically a user could do

def my_server_side_method_returning_bytes(self):
    return memoryview(self.my_large_numpy_array)

def my_server_side_method_normal(self):
    return 5, 'my name', foo_list

i.e. for the user, the usage of methods is the same and there is no need to access an additional request or response object. Although I dont see what is wrong with that either. Some HTTP servers which work based on decorating functions, like flask, allow to access the request object through some global variable. Same can be then done for response.
Nevertheless, since I allow only one type (either of bytes, bytearray or memoryview) or of a other python types which needs to be serialized, its a little easier for me to place them in different indices of the multipart message to know what was the reply. In this way, the client just checks which part of the multipart message containing return values has size greater than 0. The user given pre serialized part or the RPC server serialized part?
Of course, the ideal and best case is to have both so that the user can return any damn return value. This is the right approach. May be its best to reserve a tuple of size 2 as a fixed internal return value scheme. Just before serializing, the type can be checked to be tuple and if its of length 2, then one can proceed to inspect the types each element of the element. If one turns out to be byte type, then dont serialize it again as that will lead to serilization error:

def my_mixed_returning_server_method(self):
    return { 1: some_foo_list, 3 : 42 }, memoryview(self.my_large_numpy_array)

Within the RPC server:
    ret = func(*args, **kwargs)
    if isinstance(ret, tuple) and len(ret) == 2:
          if isinstance(ret[1], (bytes, bytearray, memoryview)):
                pass
          else:
                self.serializer.dumps(ret[1])  # serializes only for normal type of length 2
          self.serializer.dumps(ret[0])
   else:
       self.serializer.dumps(ret) # some other data including tuples of lower or higher length

Of course the dumps return value must be assign to a place within the multipart message.
This is the way I would do it.

Thanks @VigneshVSV for your extensive answer.
Part of the challenge is the currently used rpc server. The server sees only the json request and returns a json response. I have to handle the binary things outside (with these external variables).

I have an idea (inspired by you): If the json frame is empty, the other frames are the return value.

Newest design:

in ask, the extract_additional_payload parameter decides on the return value: Either the JSON return value or a tuple of the JSON return value and the additional payload, which might be an empty list. Therefore it is always clearly defined, what it returns
The message handler offers a possibility to register a binary method:

If a parameter is set, the method will receive the request's additional payload as a kwarg.
It's return values will be filtered for binary data, which will be transmitted as additional payload.

Regarding the ask RPC caller, I would still keep in mind that the server side method works transparently irrespective of whether it is called within another function or method, or from client side with the ask. I am not sure if the change you made affects this.

@VigneshVSV , thanks for your comments, they are helpful.
Registering a method makes it available via RPC. Therefore, you have to regsiter it, before you can call it via ask.

A small change:

You have to choose, whether the method will return only JSON values or a tuple of a JSON value and a list of bytes.

Currently the you have to tell the ask method, whether to expect binary data or not. I do not consider this as a major problem:

You know which method you called (and binary methods have a "(binary)" at the end of their docstring), so you know, what to expect.
In doubt, you can ask for the binary_code and mostly use the first (JSON) response value. Here it comes handy, that you know the return value (JSON or tuple of JSON and list) depending on the parameter.
Later on, we still can add a special MessageType, which indicates a bytes payload.

I'm not using really pyleco at the moment as you are the one who implemented it in pymodaq... so I still have difficulties to really understand how all this works. But for sure, everything within pymodaq can be binary serialized so direct emission of such data (frame as you call it?) would be better. I'm not sure how i could really help in the design...

Thanks for your comment @seb5g. I appreciate it.

Summary:

It is easier to add more payload frames (list of bytes) with the additional_payload parameter of Message, DataMessage classes, and ask_rpc methods
interpret_rpc_result can either return just the content of the first payload frame (normally json) or that content plus the list of additional frames (maybe an empty list), depending on a parameter switch. Also ask_rpc allows to use that parameter. That allows to retrieve the additional frames easily
Finally, the MessageHandler offers to register binary methods which can accept and/or return also binary values


fixing broken compatibility with Docker < 17.03

Looking at lines statistics I don't think it was worth adding 😄
Tested on
[/location] # docker --version
Docker version 1.11.2, build 781516c
[/location] # docker-compose --version
docker-compose version 1.13.0, build 1719ceb

Ref:  #205

Thanks! I amended your commit and removed the changes to the README as well.


POST to /api/x/federations does not properly validate request payload

You can pass something like {"foo":"bar"} to that endpoint and it'll say "successfully created federation resolvers" which is obviously impossible.
The endpoint should return a 400 Bad Request when the form of the input is not valid, and at least have a message like "nothing to do" reported back as a warning in the case that the input's form is valid, but it contains no data to process, rather than always returning a success message regardless of whether anything was done.

This now returns the correct response status code with a descriptive error message:
< HTTP/2 400
< access-control-allow-credentials: true
< access-control-allow-headers: Origin, X-Requested-With, Content-Type, Accept, Set-Cookie, Cookie
< access-control-allow-methods: POST,GET,OPTIONS,PUT,DELETE
< access-control-allow-origin: *
< content-type: application/json
* Replaced cookie mojolicious="eyJhdXRoX2RhdGEiOiJhZG1pbiIsImV4cGlyZXMiOjE2MTA0NzM1NjksImJ5IjoidHJhZmZpY2NvbnRyb2wtZ28tdG9jb29raWUifQ--046ad3a8a5149dfc7d0504cbf0b89409fd1b7aa2" for domain trafficops.infra.ciab.test, path /, expire<PHONE_NUMBER>
< set-cookie: mojolicious=eyJhdXRoX2RhdGEiOiJhZG1pbiIsImV4cGlyZXMiOjE2MTA0NzM1NjksImJ5IjoidHJhZmZpY2NvbnRyb2wtZ28tdG9jb29raWUifQ--046ad3a8a5149dfc7d0504cbf0b89409fd1b7aa2; Path=/; Expires=Tue, 12 Jan 2021 17:46:09 GMT; Max-Age=3600; HttpOnly
< vary: Accept-Encoding
< whole-content-sha512: hyl/oWMJdw/EmPWifc+GiVSLiMk3Ur1jeXsohAtaJcG2eCJPNIwJq2gUIqtswSkPGI0C70iedEdKaoP8E3MtPw==
< x-server-name: traffic_ops_golang/
< content-length: 134
< date: Tue, 12 Jan 2021 16:46:09 GMT
<
{
  "alerts": [
    {
      "text": "validating request: must specify at least one Delivery Service/Federation Resolver(s) mapping",
      "level": "error"
    }
  ]
}

This now returns the correct response status code with a descriptive error message:
< HTTP/2 400
< access-control-allow-credentials: true
< access-control-allow-headers: Origin, X-Requested-With, Content-Type, Accept, Set-Cookie, Cookie
< access-control-allow-methods: POST,GET,OPTIONS,PUT,DELETE
< access-control-allow-origin: *
< content-type: application/json
* Replaced cookie mojolicious="eyJhdXRoX2RhdGEiOiJhZG1pbiIsImV4cGlyZXMiOjE2MTA0NzM1NjksImJ5IjoidHJhZmZpY2NvbnRyb2wtZ28tdG9jb29raWUifQ--046ad3a8a5149dfc7d0504cbf0b89409fd1b7aa2" for domain trafficops.infra.ciab.test, path /, expire<PHONE_NUMBER>
< set-cookie: mojolicious=eyJhdXRoX2RhdGEiOiJhZG1pbiIsImV4cGlyZXMiOjE2MTA0NzM1NjksImJ5IjoidHJhZmZpY2NvbnRyb2wtZ28tdG9jb29raWUifQ--046ad3a8a5149dfc7d0504cbf0b89409fd1b7aa2; Path=/; Expires=Tue, 12 Jan 2021 17:46:09 GMT; Max-Age=3600; HttpOnly
< vary: Accept-Encoding
< whole-content-sha512: hyl/oWMJdw/EmPWifc+GiVSLiMk3Ur1jeXsohAtaJcG2eCJPNIwJq2gUIqtswSkPGI0C70iedEdKaoP8E3MtPw==
< x-server-name: traffic_ops_golang/
< content-length: 134
< date: Tue, 12 Jan 2021 16:46:09 GMT
<
{
  "alerts": [
    {
      "text": "validating request: must specify at least one Delivery Service/Federation Resolver(s) mapping",
      "level": "error"
    }
  ]
}


Betapass preview & remove Husky

Betapass implementation, since this service is in Beta with invite only the main package is not yet available.
Also I have removed Husky pre-commit as it was not working properly and just being a nuisance.

By the way I think we should not use husky on any MCP repo as CI is already taking care of all the checks etc.


Sfc-controller integration with ContivVPP

This PR introduces SFC-Controller in a Kubernetes Contiv-VPP environment. SFC controller is an orchestration module for providing data-plane connectivity for cloud native containers. You can find more information here: https://github.com/ligato/sfc-controller
Changes in contiv-vpp:

Added KSR SFC-reflector. Any pods with label 'sfc=true; are SFC-Controller
enabled and can be configured from the sfc-controller.
Added examples under "k8s" folder on how to deploy and use the SFC-Controller

Signed-off-by: Nikos Bregiannis<EMAIL_ADDRESS>

Coverage decreased (-1.0%) to 74.767% when pulling a186f8a5581cfd696c049cb1817e9b81a18c7dd1 on brecode:sfc-integration into b6f713ce53762f1367492418ca10047a691c62ff on contiv:master.


Partial same head on main- and sub-site

Describe the bug
I have got a very strange behavior with the static site generation. My main site (software-and-testing.de) and a sub-website (software-and-testing.de/webentwicklung) does have got partial the same head. Does anybody also have got this behavior?
Example:

The last two lines are correct, and the others are “inherited” from the main page
Reproduction
vite-ssg build
System Info
System:
    OS: Linux 6.1 Manjaro Linux
    CPU: (8) x64 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
    Memory: 7.41 GB / 15.35 GB
    Container: Yes
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 16.15.0 - ~/.nvm/versions/node/v16.15.0/bin/node
    Yarn: 1.22.19 - /usr/bin/yarn
    npm: 8.5.5 - ~/.nvm/versions/node/v16.15.0/bin/npm
  Browsers:
    Chromium: 112.0.5615.49
    Firefox: 111.0.1

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

I do not use the