cannot install with glooctl install gateway command

from the docs, trying to run with this:
glooctl install gateway -n gloo-system --values <(echo '{"namespace":{"create":true},"crds":{"create":true},"global":{"wasm":{"enabled":true}}}')```

gives this consistently:

Gloo failed to install! Detailed logs available at /Users/ceposta/.gloo/debug.log.
Error: installing gloo in gateway mode: failed pre-install: warning: Hook pre-install gloo/templates/0-namespace.yaml failed: object is being deleted: namespaces "gloo-system" already exists
Usage:
glooctl install gateway [flags]
glooctl install gateway [command]
Available Commands:
enterprise  install the Gloo Enterprise Gateway on Kubernetes
Flags:
-h, --help   help for gateway
Global Flags:
-c, --config string              set the path to the glooctl config file (default "<home_directory>/.gloo/glooctl-config.yaml")
--consul-address string      address of the Consul server. Use with --use-consul (default "<IP_ADDRESS>:8500")
--consul-datacenter string   Datacenter to use. If not provided, the default agent datacenter is used. Use with --use-consul
--consul-root-key string     key prefix for for Consul key-value storage. (default "gloo")
--consul-scheme string       URI scheme for the Consul server. Use with --use-consul (default "http")
--consul-token string        Token is used to provide a per-request ACL token which overrides the agent's default token. Use with --use-consul
--create-namespace           Create the namespace to install gloo into (default true)
-d, --dry-run                    Dump the raw installation yaml instead of applying it to kubernetes
-f, --file string                Install Gloo from this Helm chart archive file rather than from a release
-i, --interactive                use interactive mode
--kubeconfig string          kubeconfig to use, if not standard one
-n, --namespace string           namespace to install gloo into (default "gloo-system")
--release-name string        helm release name (default "gloo")
--use-consul                 use Consul Key-Value storage as the backend for reading and writing config (VirtualServices, Upstreams, and Proxies)
--values strings             List of files with value overrides for the Gloo Helm chart, (e.g. --values file1,file2 or --values file1 --values file2)
-v, --verbose                    If true, output from kubectl commands will print to stdout/stderr
--version string             version to install (e.g. 1.2.0, defaults to latest)
--with-admin-console         install gloo and a read-only version of its admin console
Use "glooctl install gateway [command] --help" for more information about a command.

Also very odd here is there's nothing in the debug log.

I can workaround this with --dry-run and kubectl apply -f - but this needs to be fixed. Seems some bug in the helm installer within glooctl

@christian-posta can you open a corresponding issue on Gloo?

yeah, I also met the issue today, this is the original command in offical docs
glooctl install gateway -n gloo-system --values <(echo '{"namespace":{"create":true},"crds":{"c
reate":true},"global":{"wasm":{"enabled":true}}}')

I fix it by create namespace gloo-system by myself and install gloo without letting it create namespace
kubectl create ns gloo-system
glooctl install gateway -n gloo-system --values <(echo '{"namespace":{"create":false},"crds":{"c
reate":true},"global":{"wasm":{"enabled":true}}}')

Hi @mjaow, the glooctl tool has been updated since this was created to automatically detect and create the namespace if it doesn't exist, so you can drop the namespace create part. Ie this should work on a fresh cluster:
glooctl install gateway -n gloo-system --values <(echo '{"crds":{"create":true},"global":{"wasm":{"enabled":true}}}')

I've opened a PR to update the wasm docs here - https://github.com/solo-io/wasm/pull/224


Elasticsearch: Don't throw exception on missing CA cert file

The current check throws an exception if the version is supposed to be
greater than 8 and the ca cert file is missing. This posed two problems:

A custom docker image might have a 'latest' version, and thus is
newer than version 8
A user may have configured their own CA in a different path

In order to accomodate for this, a missing copy of a the ca crt file
will log a warning, but not throw an exception and leave the container
unstarted. There is also another public method, allowing to read the
cert, called extractCert.
Closes #5264

Hm, I could copy another http_ca.crt into the container, but that would need to be done before Elasticsearch starts, is this possible? container.copyFileToContainer requires a running container IIRC

withCopyFileToContainer will performing the copying on startup 🙂

oooh... of course. thx. I took a small shortcut and added a http_ca.crt file, that will not match the one created by Elasticsearch on startup and therefore fails on purpose when trying to connect to Elasticsearch using that for a client with a handshake exception.

Merged, thanks a lot for this high-quality PR, a pleasure to work with you 🥳

Hey guys (cc @spinscale), I'm using tag 8.2.0for ES and v1.17.1 for TC and I'm getting this exception:
13:16:56.855 [main] ERROR ?.e.c.2.0] - Could not start container
com.github.dockerjava.api.exception.NotFoundException: Status 404: {"message":"Could not find the file /usr/share/elasticsearch/config/certs/http_ca.crt in container 8edfaa2eef41d2bc12dae07291f3796973ce3670440d918fb7ec90a6a5410a96"}

I understand that this PR (when released), will not throw this exception anymore but that ES will still not start.
I'm starting it with the following code:
        DockerImageName imageName =
            DockerImageName.parse("docker.elastic.co/elasticsearch/elasticsearch").withTag("8.2.0");
        container = new ElasticsearchContainer(imageName);
        // - single node since we don't need a cluster for testing
        // - disabled security to avoid the warning messages and because security is not needed for testing as
        //   the data is discarded and the testing environment is secure.
        container.setEnv(List.of(
            "discovery.type=single-node",
            "xpack.security.enabled=false",
            "xpack.security.http.ssl.enabled=false",
            "xpack.security.transport.ssl.enabled=false"));
        container.start();

As you can see, I've tried to turn off security so I'm not sure why it doesn't work in 8.2.0. It works fine in 7.17.3.
Also, I'd be interested to understand how I can start ES 8.2.0 with TC in a secure mode. I've tried to read https://www.elastic.co/guide/en/elasticsearch/reference/current/docker.html but I'm not sure I understand everything. Am I supposed to provide the http_ca.crt file or is generated by the docker image? Step 4 suggests it's generated. So how are we supposed to use ES with TC? Do we have to start the container once, copy the crt file on the host, stop the container, restart it again with a volume mapping on the host for the cert file? Sounds pretty complex :)
Thx!

@spinscale that works fine, thx!

I confirm it's now working OOB with TC 1.17.2. Thanks for that!
However, I still get a warning:
10:38:15.887 [main] WARN  o.t.e.ElasticsearchContainer - CA cert under /usr/share/elasticsearch/config/certs/http_ca.crt not found.

I have turned security off and thus wasn't expecting any warning. Is that something that could be improved? Should I create an issue for it @spinscale ?
       DockerImageName imageName =
           DockerImageName.parse("docker.elastic.co/elasticsearch/elasticsearch").withTag(ELASTICSEARCH_VERSION);
       ElasticsearchContainer container = new ElasticsearchContainer(imageName);
       // - single node since we don't need a cluster for testing
       // - disabled security to avoid the warning messages and because security is not needed for testing as
       //   the data is discarded and the testing environment is secure.
       container.setEnv(List.of("discovery.type=single-node", "xpack.security.enabled=false"));
       container.start();

Thx


Uncrustify configuration

This PR adds the uncrustify  configuration file.
You can install the uncrustify binary on Mac OSX, Linux and Windows

Linux: sudo apt install uncrustify
Mac OS: brew install uncrustify
Windows: download from uncrustify

Alternatively you can clone the repo and compile the project yourself (latest version)
To run it on your code use:
uncrustify -c uncrustify-openwsn.cfg -f $FilePath -o $FilePath  (makes the changes in-place)
I've applied the configuration to a bunch of files in the firmware project and I think the resulting layout looks nice, is properly aligned, and most importantly, improves code readability.
There are a lot of configuration options (700+) and they are all listed here: . Some options seem to override other ones. The latter can sometimes lead to weird formatting. I tried my best to remove contradicting configuration options, but it is possible some remain.
Before we reformat the entire FW repo, I propose that the people who are developing firmware code first try the uncrustify configuration on their local working trees and see if the configuration makes sense (and if they personally agree with the proposed code layout). If we see that it works well on all the files and we've converged on a fixed code layout/style, we can reformat the entire project once. Next, we can add the uncrustify configuration to the Travis builder to enforce future PRs to adhere to the coding style.

Hi @kyh-ly, I don't think the branch openwsn_FW-881-nrf52840dk is actively maintained at the moment. This is probably why it is broken and does not work with the current version of openvisualizer. Please in the future if you have a problem, open a github issue and do not use unrelated PR to ask questions.

@TimothyClaeys  Sorry  I don't have access to open issues, please tell me how to do this. 😄

@kyh-ly Sorry, apparently, the issues tab was disabled. I enabled it now. If you go the repository's main page:
, you should now see an Issues tab. Can you open an new issue there for your problem with the NRF52840, and any new issues you might encounter in the future. Thanks.


NEXT: FileUpload component - expose bindable files prop

Describe the feature in detail (code, mocks, or screenshots encouraged)
Would it be possible to expose a files prop for two-way binding or provide a way to access the files that have been added to acceptedFiles.
This would allow for something external to update/clear the uploaded files. My specific use case would be to combine with Superforms that resets the form once successfully submitted and would automatically clear the uploaded files from the component.
What type of pull request would this be?
Enhancement
Provide relevant links or additional information.
No response

Good catch, we'll also need to adjust it so mb is not hardcoded. That may not work in all languages.

Javascript allows for better number notations, eg:
const multiplier = 1_000_000

underscores are removed and they help make it clearer

From @jpdewing on Discord:

Following up on your point on the github issue about ‘mb’ not being hard coded. Possibly a helper utility function along the lines of this gist could handle formatting the friendly file size to the browser locale.
https://gist.github.com/lanqy/5193417?permalink_comment_id=4379535#gistcomment-4379535
The gist uses SI format so should be using 1000 rather than 1024 (IEC). Also, I don't think Intl.NumberFormat supports the IEC units. Amazing the rabbit warren you can fall down looking into these things! This article summaries things nicely https://www.simonrjones.net/2022/01/a-little-bit-about-filesize-units/ the comic at the end is great, I vote for using the Bakers Kilobyte

First the good news - I've implemented two improvements to the component in the pending PR:

Implemented a new bytesToSize() function that handles byte size and unit conversion based on James' suggestion.
As well as some minor style improvements when the component does not have a fileIcon provided.

The bad news - I've spent some time testing ways to handle a reset of the File Input within the File Upload component. Sadly I am coming up short on this one. Here's what I've tested thus far:

Creating a $bindable() reference to the <input> within the component. Unfortunately Svelte doesn't allow binding with out type="file" explicitly defined, and we cannot assign this because it's handled by Zag. So I don't think this will be a viable option.
I also tried wrapping the component with a <form> element and used Svelte's bind:this so I could run form.reset() method (the native HTML reset method). Likewise I also tried a native HTML <button type="reset">. Neither option appears to reset all fields except file inputs.
Currently it seems like the de-facto solution would be to set the value attribute to either and empty string '' or null. So I went through the process of biding the value (similar to other components) - but again, this is not working. The value is updated, but the files are not cleared.

The only other idea I have is to somehow expose the Zag api.clearFiles() method described here

However, I'm struggling to come up with a clean way to handle this that doesn't require an event handler prop to pass the api up to the parent scope. So for now I'm open to other ideas or suggestions!

This looks like an orphaned ticket, but this functionality is now implemented:
https://next.skeleton.dev/docs/components/file-upload/svelte/#bind-to-api

Thanks Chris, apologies should have closed this ages ago after discussing on discord.

Nah, all good. Our issue tracker is setup to auto-close issues tagged in their respective PRs. But it's awaiting the changes to hit our master branch - which is still a ways out for v3 heh. In the meantime we just have to take care to manually close these out. Sometimes we miss one or two though!

You should be able to make use of the onFileAccept or onFileChange event to get the list of uploaded files and then manually set Superforms, something like:
function fileAccept(e: FileAcceptDetails) {
    myForm.files = [...e.files];
}

@magiceupho please avoid creating new issues under old closed issues. It's the easiest way for myself and the community to miss these posts.


Prioritize news from watchlist

Prioritize news from stock list I track

fstocks, the initial release does not matter as
screeners from rbc, etc ...

Goal is to send myself news from companies I care about and/or from companies with low pes and/or low p/b
Download screener files from rbc direct investing, feed that into deno script that grabs data.
Created index using
CreateIndex({name:'ref_by_ts',source:Collection("Article"),values:[{field:['ts']},{field:['ref']}]})

Use

sheetjs for deno
read data from xlsx sheets from rbc direct invest
use github actions as cron (before market opens, and afterwards)
read data from faunadb for new entries.

Map(Paginate(Range(Match('all_docs_ts'),[ToMicros(ToTime('2020-07-14T06:30:00Z'))],[ToMicros(ToTime('2020-07-14T18:59:59Z'))])),Lambda(['ts','ref'],Get(Var('ref'))), {size: 1000})

remove size arg if it does not work
see
https://stackoverflow.com/questions/63353619/faunadb-how-to-paginate-count-all-documents-within-the-last-n-days

Fixed with commit 465296d3412a3cc3160396e65e393d0743c11aef


Boot works on Optoma UHD52ALV but Shutdown not.

Working great so far 👍🏻
it boots up when triggered by homekit automation
But shutdown does not seam to work.
Optoma UHD52ALV
can you have a look into that?

Working great so far 👍🏻
it boots up when triggered by homekit automation
But shutdown does not seam to work.
Optoma UHD52ALV
can you have a look into that?

Could you please share your configuration settings? I have the same projector and I get it to appear in HomeKit, but with a np response message and Homebridge shows a “socket error”.
Thanks in advance!

This might be fixed by #7


Add description of invalid phrase behavior

The reported bug in CORE-2925 is as follows:

keybase device add
enter a secret phrase with the correct number of words, and all words in the word list, but just doesn't match what keybase login on provisionee told you to enter.
nothing happens.  5m later, there is a timeout error.

It's asking API server for any messages, but none will come in because the secret is incorrect.  We do check that the words in the phrase are in the dictionary and that the number of words is correct.
We have yet to receive a report of this error in the wild.  For now, I changed the output to say that if they don't see a new device name prompt on their new device, then they typed the phrase incorrectly.
One other thing we could do is decrease the overall timeout so that it fails sooner.
I'm wary of making major changes here to fix this as it doesn't seem to be affecting real users.
r? @maxtaco

:mag_right: The commits 1d599b7d2917...231061980140 introduced some visual changes on win32:

Changed: unlock_folders-No_paperkeys (before) (after)

LGTM.
Do we have a task filed for the real long term fix? Will we have to add another step in the handshake?

I'll add a task, but again, I'm not sure it's worth any time.  Especially in the mobile/desktop future of scanning QR codes.

:mag_right: The commits 1d599b7d2917...5e942c98e3df introduced some visual changes on win32:

Changed: user_search-Normal (before) (after)


[debugging] Rewrite deployment plan comment workflow entirely in Python

We will end up having error messages directly from the GitHub API this
way which will be easier to debug if something is still not working

Self-merging to see if this unbreaks the workflow


Horizontal scroll adds hidden cards in certain window sizes

might have been fixed with dependency upgrade - will monitor, have not replicated the problem after upgrade

@NickHaggerty1 @meols this is the bug that we discussed in #1418, can you verify that it works as intended?

@millianapia - I still see issues as described in #1418. See new attachments  s

@millianapia @fernandolucchesi @meols Hey. I see the same issues as Mette (both in stage and on our live site) So I dont think the issue is solved. If it helps w can share screen? THis should not stop the deploy though as we are waiting for the new elements/video for tasks

@NickHaggerty1 i replaced the old component with a new one, should not get this issue anymore, will take it through a new round of technical review, and then hopefully it will be gone for good :)

@millianapia left some comments for you

I took a different approach to this, ready to be reviewed @fernandolucchesi

components still need a wrapper limiting the amount of the width it can grow:

@fernandolucchesi maybe just a simple
  max-width: var(--iframe-maxWidth, var(--maxViewportWidth));   margin: auto; will do?

@fernandolucchesi maybe just a simple  max-width: var(--iframe-maxWidth, var(--maxViewportWidth)); margin: auto; will do?

won't work due to the arrows.
so we have 2 different components and different UIs:

and:
.
If you want to use the first one, you will need a Wrapper with a limiter on both sides of the screen, because the arrows to slide the component are outside of the component. So something like: padding: var(--iframe-innerPadding, 0 var(--layout-paddingHorizontal-small)); will do. If you want to make the first component look like the second, then you need to extend Carousel API to accept a parameter that will display the button arrows like the second one, then you won't need to add "extra room" for the arrows

My recommendation is to kill old design, and always go for:

i liked how it looked in your suggestion, so i think this is the way to go, feels good navigating on the phone

@fernandolucchesi any last comments before i move this forward?

@fernandolucchesi any last comments before i move this forward?

I think it looks good! Just a reminder to cleanup some comments you left in the Carousel.tsx file.

@meols @NickHaggerty1 the cards should behave correctly now, can you verify?

@meols @NickHaggerty1

@millianapia - let me know if you want to have a screen sharing session on this.

@meols should be working 100% everywhere now, one final verify from you?

@meols it is due to it is a multiple event component, and a single promotion component, so they look different. I have now pushed a fix for the width of when one only have one event for multiple event component, with the removal of featureflags for this:)


To improve Delta Sync query performance

Describe the feature you'd like to request
Currently with DataStore we are observing the following behaviour.

If the lastSync field is not specified, a Scan on the Base table is performed -Intial Sync
If the lastSync field is specified, but the value is before the current moment - DeltaSyncTTL, a Scan on the Base table is performed. - which is equal to Intial Sync
If the lastSync field is specified, and the value is on or after the current moment - DeltaSyncTTL, a Query on the Delta table is performed.

Also from the docs, we configure syncInterval  :The maximum interval (in seconds) for which the system will continue to perform delta queries. After this interval expires, the system performs a base query to retrieve all data.
In a realtime scenario, when application is in backgroud or offline for more than 30 mins(default DeltaSyncTTL), we are performing a full scan which is causing performance issue.(Scenario 2)
From the testing, we could not observe any difference between the 1 and 2 after delta TTL expires(30 mins default). How can syncInterval in DataStore.configuration() help us
In case of large datasets(20+ models and 100MB+ data), these DeltaSync against Base Table are having delay of (10-15) mins which is not user friendly.
PS: After implementing selective sync.
Additionally we could observe high Sync time for (Scenario 1 and 2) in Android when compared to IOS.
Issue: 1719
Describe the solution you'd like
In Scenario 2,
When performing deltasync SCAN against BaseTable, we are returning whole data. Could we add a filter to return only data where _lastChanged values of records are greater than lastSync
I tried below VTL template(QuerySyncTodosDataResolverFn) and could get this working.
{
      "version": "2018-05-29",
      "operation": "Sync",
       "filter" : {
        "expression" : "#lastchanged >=:lastSync",
        "expressionNames": {"#lastchanged":"_lastChangedAt"},
        "expressionValues" : {
            ":lastSync" :  $util.dynamodb.toDynamoDBJson($ctx.args.lastSync)
        },
    },
      "limit": $util.defaultIfNull($args.limit, 100),
      "lastSync": $util.toJson($util.defaultIfNull($args.lastSync, null)),
      "nextToken": $util.toJson($util.defaultIfNull($args.nextToken, null))
  }

It would be great if this filter expression is automatically added for Sync Queries.
Describe alternatives you've considered
Currently using high DeltaSyncTTL (6-8hrs) and using selective sync expressions.
However with heavy traffic and large dataset, these configurations are also not helping to increase the performance.
Additional context
Amplify CLI version: 12.7.0
Schema:
input AMPLIFY { globalAuthRule: AuthRule = { allow: public } } # FOR TESTING ONLY!

type Todo @model {
  id: ID!
  name: String!
  description: String
}

Is this something that you'd be interested in working on?

[ ] 👋 I may be able to implement this feature request

Would this feature include a breaking change?

[ ] ⚠ This feature might incur a breaking change

Hi @sushpatg, Thank you for raising this. We will categorize this as a feature request for our team to investigate and assess more thoroughly.


Make special C# cases for APIs like get_property_list which return a list of dictionaries.

Just throwing an idea out there, really.
The API for get_property_list return an array of dictionaries, probably to avoid having to declare a new type for a single function. This is fine in dynamically typed languages because there's little difference between x.y and x["y"], but it's awful in typed languages like C#. It just makes the API extremely prone to "great what was the exact layout again", because Intellisense becomes useless.
So, I suggest that since C# is still marked unstable, we refactor these to handle some simple immutable classes/structs. Shouldn't be too far off the regular API, but still be tons more usable.
Thoughts?

Any reason why reflection and attributes aren't simply usable? For that reason I feel get_property_list even makes no sense in C#, but we use to break rules anyways because that function can be abused to simulate properties that don't exist... So I'm not sure.

I was referring to that one.

I'm not sure what to do about this. The idea of hard-coding dictionaries that need to be transformed into a struct or class adds quite a bit of maintenance burden.
Even if we find a way to automatize this, I still don't like the idea of having to accept the overhead of converting a structure to a dictionary (which is what is done in most of these methods, like Object.get_property_list and PhysicsDirectSpaceState.intersect_ray) just to convert it back to another structure. All because GDScript does not support structs or a more lightweight class that does not inherit Object.
I would rather have ClassDB support the notion of structs and maybe non-Object derived classes as well, and then make languages that do not support these do the conversion to dictionary themselves (or just have two version of the method, the normal one and the one for GDScript that converts the result into a Dictionary).


Card.io adds 13mb to apk size!

Required Information

card.io Android SDK Version: 5.4.1
Android Version: all

Issue Description
Went through product testing and only realized drastic change to APK size just before release.  our production apk has gone from 18mb to > 30mb.   Verified with an empty project, with CardIO 13mb,  without cardIO 1.5mb.  This is madness, why so heavy?  GOING TO BE VERY HARD TO JUSTIFY THIS TO PRODUCT TEAM

card.io includes native code for each processor architecture which results in a fairly sizable binary. Although it introduces some complexity to releases you can split your apks to decrease the size for each architecture. Keep in mind that this is not the downloaded APK size or the installed size.
Finally if you are not happy with the size of the library, there's nothing forcing you to use it.

There are numerous other issues about this same topic: #88, #93 and #106.

We work with native libraries that have to support multiple architectures and apk splitting, but others are not nearly this large. I assume by closing the issue this means that card.io is not planning to work on reducing these sizes in the future, which is problematic, but will be useful information in making  a decision. Thanks for the answers.


Does not work with some twitter accounts

Twitter accounts with This profile may include potentially sensitive contenton the front,
where you have to click into it to access the content, will break tweep.
It will have a button that look like
<button class="EdgeButton EdgeButton--tertiary ProfileWarningTimeline-button">Yes, view profile</button>

@haccer @pachonk
I tested it out, it did work with Kim Dotcom's twitter account (among others),
but it does not work with https://twitter.com/a_fellow_white?lang=en


Migrate to Pydantic V2

Feature Suggestion
Hummingbot depends on Pydentic v1.10.4 at the moment. This prevents me from using other packages that depend on Pydantic v2.
A global Environment Upgrade is already planned, so solving this problem may be one of the first steps along the way.
A detailed migration guide is available here, migration can be done in a variety of ways and really smoothly (even maintaining all existing v1-style code).
Impact

Compatibility with other packages
Improved performance

Hi @komposter, this looks straightforward, may I attempt a solution?


fix: allow cast between different Interval type

Which issue does this PR close?

Closes #.
we should allow cast between different Interval type.
like Interval(Year) + Interval(Day) , they both will cast to be MonthDayNano
Rationale for this change
https://github.com/apache/arrow-datafusion/issues/5933

Are there any user-facing changes?

I believe this is a duplicate of https://github.com/apache/arrow-rs/pull/4182

thanks @tustvold


[backport] Fix in-place update of arrays in Link.serialize and optimizers.Adam

Backport of #7918

[automatic post] Jenkins, test this please.

PTAL.
Some of the optimizers were not explicitly implemented in the stable version so they had to be skipped too

Jenkins, test this please

Jenkins CI test (for commit 4fd6fd27d2d9daf83b0cba05a627d5fb877c63b8, target branch v6) succeeded!


Add accumulate exercise

I reverted the commits that came with the binary exercise and committed the proposed change in #113 in order to make sure that we're all green.
Please let me know if anything else should be done before it's merged.
Thanks.

Hi @pmatseykanets this now looks great but I can't merge it because it will conflict with the other recent merges - config.json is conflicting. Please could you rebase/merge the master branch, then push that up? Thanks!

@petemcfarlane I reconciled the upstream. Please merge.
Thanks.

Thanks!


error while updating sprint

Hello,
I'm pretty new to obsidian and would like to use the plugin.
When I update (manually via update sprint command). I get an error with hint to the developer console (see below) and no kanban board has been created. I think it could be the proxy settings but not sure how to check or change them in obsidian (system settings are correct and working fine).
I configured the plugin according to the readme (strict mode off, kanban and todo plugin, server, name, mail, token, board-id).
When I start obsidian (pretty empty and new) this is the full console output:
- app.js:1 Obsidian Developer Console
    node:electron/js2c/renderer_init:89 Electron Security Warning (Insecure Content-Security-Policy) This renderer process has either no Content Security
      Policy set or a policy with "unsafe-eval" enabled. This exposes users of
      this app to unnecessary security risks.

    For more information and help, consult
    https://electronjs.org/docs/tutorial/security.
    This warning will not show up
    once the app is packaged.
- warnAboutInsecureCSP @ node:electron/js2c/renderer_init:89
- plugin:obsidian-admonition:479 Obsidian Admonition loaded
- plugin:table-editor-obsidian:23712 loading markdown-table-editor plugin
- plugin:obsidian-advanced-slides:318 server started at http://localhost:3000
- plugin:nldates-obsidian:9043 Loading natural language date parser plugin
- DevTools failed to load source map: Could not load content for app://obsidian.md/luxon.js.map: System error: net::ERR_FILE_NOT_FOUND
- plugin:obsidian-plugin-todo:9801 [obsidian-plugin-todo] Parsed 3 TODOs from 3 markdown files in (0.231s)
- plugin:obsidian-agile-task-notes:59 Error: net::ERR_TUNNEL_CONNECTION_FAILED
    at SimpleURLLoaderWrapper.<anonymous> (node:electron/js2c/browser_init:101:7169)
    at SimpleURLLoaderWrapper.emit (node:events:390:28)

Can you help me out?

Hello,
Are you using the newest version of Obsidian? I have not seen this error before, it looks like it mentions tunneling. Are you perhaps running Obsidian on a VM or on a VPN network?

Yes my entire System is an remote access VM and the Host is in an other network than the jira server and the networks are secured via vpn, so no vpn direktly on my VM or the Host.
On my VM Jira is "pingable" and reachable via different browsers wich use my system proxy and network settings.
I will ask a coworker with an machine within the network to try obsidian and your plugin with our jira.
Can I configure certificates/proxy settings within obsidian or the plugin?
Thank you for the fast reply.


Expand Super Graph

Goal: Add transitions and graffinity functionality when a user clicks on a supernode for an aggregated matrix
Features to implement:

animation transition for the matrix
chevrons for interacting with supernode children
redrawing the vis to display supernodes and their children

@mozartfish Not all of these features were addressed in #159, please create new issues for the features that need to be implemented still

@mozartfish Not all of these features were addressed in #159, please create new issues for the features that need to be implemented still


Crash when creating world.

What you were trying to do
create a new world
What actually happened
created world, loaded world, then immediately crashed
How to reproduce

Step 1-Create world(using core gameplay template.)
Step 2That's all.
Step 3

Log details and game version
https://pastebin.com/Sx4x2LCv
Computer details
Windows 10 home 64-bit, Core i5-7200U clocked at 2.5 GHz and 8 Gigabytes of RAM

Hi @fisik-yum and thanks for the log! What version of the game did you work with though? Latest stable release? Local source workspace? Did you update any modules?
The errors in the log are odd - lava hasn't changed for a while, I think 🤔 Did you make any local modifications?
20:23:04.192 [main] ERROR org.terasology.assets.AssetType - Failed to load asset 'Core:AnimationTest'
java.io.IOException: Invalid tile - must be square with power-of-two sides
...
20:23:04.325 [main] ERROR org.terasology.assets.AssetType - Failed to load asset 'CoreAssets:Lava'
java.io.IOException: Invalid tile - must be square with power-of-two sides
...

Okay, sure.
I was using the latest stable release of the game, and my installation directory was C:\terasology and my saves were located in C:\terasology\saves
and no local modifications and I did not update any modules.

Thanks for the update @fisik-yum ! Glad you got it working. Will close this as resolved then :-)
Interesting note about the thumb drive! Not sure that's been tried much.


[FLINK-32478][connectors/common] Fix the bug that the shared thread pool causes the source alignment unit test to fail

What is the purpose of the change
SourceCoordinatorAlignmentTest.testAnnounceCombinedWatermarkWithoutStart fails
Root cause: multiple sources share the same thread pool, and the second source cannot start due to the first source closes the shared thread pool.
Brief change log
Create new thread pool for each SourceCoordinatorContext.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper:  no
The S3 file system connector:no

Documentation

Does this pull request introduce a new feature? no

Hi @pnowojski @RocMarshal , would you mind take a look this PR of FLINK-32478? All of Flink master, release-1.16 and release-1.17 have this bug, sorry for causing this problem.
The multiple sources of SourceCoordinatorAlignmentTest.testAnnounceCombinedWatermarkWithoutStart share the same thread pool, and the second source cannot start due to the first source closes the shared thread pool.
I didn't rebase master at #22845 , so I didn't find this project before merging. I'll pay more attention in the future.

LGTM % fixing closing issue. Feel free to merge it after it's fixed :)


python2/3 compatibility, PySide/PySide2  PyQt4/PyQt5 compatibility, unicode_literals, setup.py

Changes:
2x New Dependencies:

six  python2/3 compatibility module
Qt.py Pyside(Qt4)/PySide2(Qt5) compatibility module

print to print()
python3-style relative imports
from .module import func
filter() to list-comprehension
I replaced your use of filter() with list-comprehensions.
In python2 filter() returned a list, in python3 it returns
an iterable. The output was being treated as lists in the code,
so I kept them that way.
QApplication reused in tests if Maya, IPython, etc...
Minimal setup.py

Python2 sort of works now and I found a few problems while testing:

PySide: dragging view with middle mouse button does not work, no error
PyQt4: AttributeError on every mouse click
PyQt5: AttributeError on startup due to missing QPainter.drawRoundRect

Python3 works correctly  so far and I can't test PySide2 on either version right now.

Awesome. Thanks a lot!

Oops, I think I'll need to revert this merge in favor of the other branch. I'll fix it.

This merge has now been reverted.


Use ko:// to signal that we would like the test framework to produce images.

tl;dr: image: { .images.magicName } --> image: ko://some/go/package
Fixes: https://github.com/knative-sandbox/reconciler-test/issues/34
This change takes some opinions out of the testing framework, we will use ko:// to signal we want to make a container.
This is overwritten if you use something like the following:
// The following could be used to bypass the image generation process.

import "knative.dev/reconciler-test/pkg/environment"

func init() {
	environment.WithImages(map[string]string{
		"ko://knative.dev/reconciler-test/images/recorder": "example.azurecr.io/kn/recorder@sha256:1938a18961f21262278dc03d18be190c630bef95a9ca0c62ca08af2528dbfd86",
		"ko://knative.dev/reconciler-test/test/example/cmd/echo": "example.azurecr.io/kn/echo@sha256:0933ea6bf2799b08653c0e729d63372629b42c69331125d2428edeb25c57637b",
		"ko://knative.dev/reconciler-test/test/example/cmd/producer": "example.azurecr.io/kn/producer@sha256:7ed12ab13b4828ab1a3797c52aea09c40681d6c79237e86ca9050041fd4ab008",

	})
}

At the moment, if WithImage is set, then ProduceImages will do nothing. We could do a followup to be more smart about this, but for now, let's try this out.

Ok, now works. I had overwritten the wrong file on string replace.

Sounds reasonable to me cc @lionelvillard
/lgtm
/hold for another pass

/lgtm it's going to the right direction IMO.

/unhold


SAK-29976 - Roster broken in trunk

LGTM, covers a lot of cases of bad or missing title tags.

This seems to be causing a StackOverflow error in trunk. Trying to pinpoint the issue.

Looks like this is now fixed, due to:
https://jira.sakaiproject.org/browse/SAK-29982
https://github.com/sakaiproject/sakai/pull/1186
It was quite likely certain Wicket tools were not working with this regex as the tool that we had the issue on was also a Wicket tool.


Update NT testing and vaccine function

Since this requires interacting with a Shiny dashboard, I will most likely have to use RSelenium.

Done.

For some reason, the "completed" (testing) number is not rendering in headless Firefox (but runs just fine when headless mode is off).

Okay, sometimes even non-headless mode fails because the page fails the load correctly. Refreshing doesn't help since it brings you back to the main tab. Perhaps waiting prior to clicking the link to the new tab could help.


[HUDI-6058] curator-client in hudi conflicts with spark3

Change Logs
Currently curator-client in hudi is 2.7.1, while the version is 2.13.0 in spark3.
There will be a NoSuchMethodError if we user ZookeeperBasedLockProvider with spark3.
Caused by: java.lang.NoSuchMethodError: com.google.common.util.concurrent.MoreExecutors.sameThreadExecutor()Lcom/google/common/util/concurrent/ListeningExecutorService;
        at org.apache.curator.framework.listen.ListenerContainer.addListener(ListenerContainer.java:40)
        at org.apache.curator.framework.imps.CuratorFrameworkImpl.start(CuratorFrameworkImpl.java:246)
        at org.apache.hudi.client.transaction.lock.ZookeeperBasedLockProvider.<init>(ZookeeperBasedLockProvider.java:76)

Impact
none
Risk level (write none, low medium or high below)
low
Documentation Update
none
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

https://github.com/apache/hudi/blob/d6ff3d6ba46b51f58ebb1db58f26423a211741f5/packaging/hudi-spark-bundle/pom.xml#L119-L121
wondering if this is needed


Issue in Report Vendor 1099 Magnetic Media

Hi Team,
I converted the "Vendor 1099 Magnetic Media" report from "C/al" to "AL" language through Txt2al.exe file
then i include that AL file into our project.  as I include it is giving error for a variable of type "File"

and if you look into variable

and i hover the cursor to that function to see the error then it showing the following error

can anyone here to guide something on this issue

@SahilGuptaBS the question has been answered a few times on this forum. If you would like learn more, please use one of the following resources:
Business Central Community
mibuso forum
Dynamics User Group


Make a backwards compatible API

Extensions like TypeApplications cause problems for other Haskell implementations like Eta. The way around this is to use Proxy a arguments when you want to send type arguments to a particular function.
A good solution that can stay compatible with other Haskell implementations as well is to:

Add a CPP constant called HAS_TYPE_APPLICATIONS that is automatically turned on for GHC 8 via a Cabal conditional.
All source code uses of type applications should be #ifdef'd using the defined constant above.

I'd be happy to take this up if this sounds like a good approach.

Hi!

Extensions like TypeApplications…

Are there any other extensions that we use that are problematic?

Hi @jml, after further investigation, yes there are:

TypeInType
TypeFamilyDependencies

I'm currently trying to see if they're a way to get the same functionality without those extensions.

Hi @rahulmutt,
@teh and I were chatting today, and decided that we would like graphql-api to be for GHC 8.0.2 and later, and any compilers compatible with those. We rely on a lot of recent type extensions in a pretty fundamental way. We don't intend to change that any time soon.
If you want to do a "friendly fork" that makes a version of graphql-api which works for Eta or GHC 7.x, please feel free. We'll gladly link to it, and will accept PRs that make it easier to maintain (as long as they are consistent with our design principles).
I'm going to close this issue for now. I'm happy to continue discussion here, but we'll only re-open it if @teh and I agree that it's a good idea for this repo to extend our compiler support.
Thanks,
jml


MNT: Re-rendered with conda-build 3.18.9, conda-smithy 3.5.0, and con…

…da-forge-pinning 2019.10.01

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


make doesn't rebuild gtest

Summary:
make clean-all doesn't remove gtest-all.o
Description:
I found this when checking clang build vs gcc build. After setting CC = g++ in
https://github.com/stan-dev/math/blob/69686e153063c175ec3f2bc1118ee62413d32904/make/default_compiler_options#L7
I ran
make clean-all
./runTests.py test/unit/math
I was expecting all dependent libs are rebuilt but gtest-all.o was not.
Reproducible Steps:

build with CC = clang++
make clean-all
set CC = g++ in
https://github.com/stan-dev/math/blob/69686e153063c175ec3f2bc1118ee62413d32904/make/default_compiler_options#L7
./runTests.py test/unit/math/rev/mat/functor

To make it work, further one has to do

rm -f lib/gtest_1.7.0/src/gtest-all.o
then rerun
./runTests.py test/unit/math/rev/mat/functor

Current Output:
Undefined symbols for architecture x86_64:
  "testing::internal::StringStreamToString(std::__cxx11::basic_stringstream<char, std::char_traits<char>, std::allocator<char> >*)", referenced from:
      testing::AssertionResult testing::internal::CmpHelperFloatingPointEQ<float>(char const*, char const*, float, float) in algebra_solver_test.o
  "testing::internal::GetBoolAssertionFailureMessage[abi:cxx11](testing::AssertionResult const&, char const*, char const*, char const*)", referenced from:
      test::check_varis_on_stack(stan::math::var const&) in algebra_solver_test.o
      test::check_varis_on_stack(std::vector<stan::math::var, std::allocator<stan::math::var> > const&) in algebra_solver_test.o
  "testing::internal::EqFailure(char const*, char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool)", referenced from:
      testing::AssertionResult testing::internal::CmpHelperFloatingPointEQ<float>(char const*, char const*, float, float) in algebra_solver_test.o
      testing::AssertionResult testing::internal::CmpHelperEQ<double, double>(char const*, char const*, double const&, double const&) in algebra_solver_test.o
      testing::AssertionResult testing::internal::CmpHelperEQ<int, double>(char const*, char const*, int const&, double const&) in algebra_solver_test.o
      testing::AssertionResult testing::internal::CmpHelperEQ<int, stan::math::var>(char const*, char const*, int const&, stan::math::var const&) in algebra_solver_test.o
      testing::AssertionResult testing::internal::CmpHelperEQ<int, int>(char const*, char const*, int const&, int const&) in algebra_solver_test.o
....

Expected Output:
Build and pass unit tests
Current Version:
v2.17.2

+1. We can and should take care of this.


The game doesn't see the profiles I copy into the new folder.

Steps to reproduce:

Launch the game with this mod enabled.
Quit the game.
Copy the profile into the new folder created by this mod.
Launch the game.
Open Profile Selector.
Watch the profiles list remain unchanged.
Maybe it's something with other mods in my pack, but I didn't experience my profile resetting after downgrading, just wanted to check out this mod. Please do tell what logs/other files I need to provide to help you troubleshoot this issue.

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

Hi, thank you for reporting the bug. Could you provide your log file ? It would be helpful to find the issue

In an attempt to reproduce the issue and grab a log file, the issue just went away. Now working exactly as expected. Sorry for the inconvenience.


Draft: re-do docs landing page

Try a first attempt at a full re-haul of the RTD landing page with more explicit calls to action. This is a starting point for future exploration.
See a preview at https://flax--1666.org.readthedocs.build/en/1666/

Closing this since @cgarciae took this over in #2177.
Thanks for starting this @avital!


Moz/dockerfix

The seamless chart installation succeeded. We will close this PR and each next code change make small with linked issues, as this code change is not manageable/reviewable and we need to prevent it from happening next time.


Add option to retain payment methods once stored

Currently, if a credit card is stored with Samurai and there is no subsequent auth/payment, then the card is purged from their system within 24-48 hours. Using the new :retain option will request that Samurai retain the payment method for future use.
See the Samurai docs here: https://samurai.feefighters.com/developers/ruby/api-reference#retaining-a-payment-method

@ntalbott ok, I've removed the true check, but added an additional check to avoid the retain call if the pan/cvv is invalid or if a token was not removed.

Awesome! Squash and I'll merge ASAP.

@ntalbott Done. Merge away!


It does not work when I try the "eu-central-1" region, but for "us-east-1" everything works perfectly.

I tried multiple times but nothing changed
How can I fix this?
Failed resources:
CDKToolkit | 12:28:27 AM | CREATE_FAILED        | AWS::S3::Bucket         | StagingBucket cdk-hnb659fds-assets-{accountId}-eu-central-1 already exists
❌  Environment aws://{accountId}/eu-central-1 failed bootstrapping: Error: The stack named CDKToolkit failed creation, it may need to be manually deleted from the AWS console: ROLLBACK_COMPLETE: cdk-hnb659fds-assets-{accountId}-eu-central-1 already exists
at FullCloudFormationDeployment.monitorDeployment (/project_path/node_modules/sst-aws-cdk/lib/index.js:426:10236)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async /project_path/node_modules/sst-aws-cdk/lib/index.js:431:2104
at async Promise.all (index 0)
at async CdkToolkit.bootstrap (/project_path/node_modules/sst-aws-cdk/lib/index.js:431:1949)
at async exec4 (/node_modules/sst-aws-cdk/lib/index.js:504:52797)
The stack named CDKToolkit failed creation, it may need to be manually deleted from the AWS console: ROLLBACK_COMPLETE: cdk-hnb659fds-assets-{accountId}-eu-central-1 already exists
//sst.config.ts
import { SSTConfig } from "sst";
import { API } from "./stacks/MyStack";
export default {
config(_input) {
return {
name: "{project_name}",
region: 'eu-central-1',
};
},
stacks(app) {
app.stack(API);
}
} satisfies SSTConfig;

Can you follow the steps the error message is saying?

(Im a noob, just started to use SST) it has nothing to do with regions. As the error message states, you already have a bucket with this name deployed... Most probably from an earlier SST run. You need to manually delete the bucket in your AWS console. Removing CloudFormation stack manually could help you guide through what are dangling pieces that SST automatically created. Also you may try to tweak the default removal policy https://docs.sst.dev/advanced/removal-policy

We are transition this repo to https://github.com/sst/v2 and are closing this issue for now. If it is still relevant please reopen it there - sorry for the trouble


Read the Docs + CAG API docs

This PR adds the following:

Sphinx docs hosted on: https://course-access-groups.readthedocs.io/
General introduction and misc. docs
The /course-access-groups/ API endpoint (more to come)
A couple of sections that has no content yet
(Somewhat unrelated) a test case to ensure that PATCH actually works

How to Review
Check the docs site https://course-access-groups.readthedocs.io/ and spot any issues.
Why the massive ping?

I pinged all Open edX engineers to let you know that we have something at Read The Docs.

Thanks a lot @johnbaldwin!


Call to transitions() now also returns wildcard transitions

As described in #93, a call to transitions() did not return wildcard transitions. This PR fixes that.

@jakesgordon Hey, this is a really important change for us, maybe you can merge it and publish a new version?


Add locale selector

This project already supports multiple locales, but you can not select a different locale.
Examples:
https://www.soc.gg/en/factions (English)
https://www.soc.gg/de/factions (German)
The locale is automatically detected. See https://nextjs.org/docs/advanced-features/i18n-routing#automatic-locale-detection for more details.
The available locales are equal to the locales in-game.
https://github.com/lmachens/soc.gg/blob/main/lib/collections/locale.json is generated from the game-assets.
The task is to create a locale/language selector to transit between locales.
Technically, we can add links to change the locale:
https://nextjs.org/docs/advanced-features/i18n-routing#transition-between-locales
I am open for ideas how to implement a selector on UI side.
One idea is to add a https://mantine.dev/core/action-icon/ with https://mantine.dev/core/popover/ next to the social icons (GitHub / Discord). I think a country flag would be nice here.
Icon packs:
https://github.com/lipis/flag-icons
https://www.npmjs.com/package/country-flag-icons

I had a look at the mapping from what's inside the locale.json file to both flag-libs.
I try to use the code attribute directly get flags/icons from both libraries. It turns out, that this isn't possible for each country. E.g. you have flags for "UK" or "US" and not for "en", Japan is "jp" (not "ja") and Korea has 'kp/kr' and not 'ko' 😵
Is the https://github.com/lmachens/soc.gg/blob/main/lib/collections/locale.json file automatically generated from a script parsing the game files? What is the flags attribute for? I wonder if i could change the content or if this will be overwritten by a "export" from the game data in the future.
I think I need some hard-coded mapping for the code attribute to the related icon.

Yes, this file is generated from the game files.
So either add a mapping an generating or on displaying the flags.
I would do the latter, because it doesn't require app wide changes.


Don't always scroll to bottom when there is new output in console

I'm using this with NodeJS & Meteor.  Currently when there is output to the console, Bash is scrolling to the bottom regardless of whether I have scrolled up to look at previous output.  On my Mac, if I scroll up to look at some previous output, it stops scrolling to bottom when there is new output, allowing me to read through previously output information easily.  Then if I scroll back to the bottom, it will "follow" the new output and stays scrolled to the bottom automatically.
Please make it work similar to how I have described on Mac.  Currently in Bash for Windows, it's very hard to scroll back in the console output and look at previous data since it scrolls to the bottom automatically when there is new output.

This is not a problem with BashOnWindows. It is a console problem, since bash.exe runs like other Windows console apps in the Windows Console Host (conhost.exe).  The upgrades to conhost are planned, but they will not release for the anniversary upgrade in July, and the Windows team is scrambling for the July 30 deadline to actually get what is planned ready by then.
So in the meantime, I described a nice off-the-shelf workaround  using a Windows Xserver (XMing) and a nice XTerm replacement (rxvt-unicode-256color) that should hold you over until the Console team starts rolling out their planned console upgrades : https://github.com/Microsoft/BashOnWindows/issues/531

BashOnWindows is great, I have always wanted Microsoft to work on updating the console, which has been for such a long time, such an outdated piece of software.
I am glad this project is pushing them to update that.

Thanks for the discussion.
Closing this issue since:

This issue is old and has likely been fixed since it was opened. If not, please post a new issue in the Console GitHub Repo
This is the WSL issues repo, but this is an issue in Console which has its own Console GitHub Repo
GitHub doesn't allow issues to be moved between repos, preserving posters' identity :(

If you have further asks/issues, please file new issues on our Console GitHub Repo.


Instructions for react-native.

I struggled for a few days integrating UnfiedPush into my mobile app, mostly because I am not too familiar with native android development. Silly things like making the receiver class public or the intent immutable tripped me up, but also waiting for the javascript layer to be initiated was required.
I would be happy to document the steps I followed if you would be interested in adding it to your site. Here is my app for reference: https://github.com/balzack/databag/tree/unified
Mostly, I love your project and hope it continues to grow!

In my app, I take the payload and use it as the title, as I didn't need the description. For a formal react-native plugin you would probably want to have a format defined,  ex: { "title": , "description":  }
If you are asking me to write the plugin, I probably can in time, but am new to the native layer and would have some learning to do on how plugins work. If you are asking to take the code yourself and make the plugin, then feel free. All my code is open and free.

The right way to do is to pass the message to the react side, like you're doing with onNewEndpoint. I haven't done any react but if you want to work on the react lib, I'll be happy to help (it is easier once there is a structure :) )

I'll give it a go. No promises as I'll need to do some learning first, but it's a good excuse for me to learn the domain.
I'm not sure it will work to load the whole javascript engine to process a notification when the app is not running; the react-native firebase plugin doesn't. It is best to stay consistent with the other connectors, so I will try your approach first.
Hopefully my work can help your project grow. Cheers.

I started working the plugin. In my app, my usage model was to use UnifiedPush if a distributor was found, otherwise to try and use Firebase. I guess this is similar to your embedded FCM distributor, but I didn't want to host a rewrite proxy.
As a result of my the way I use UnifiedPush, I didn't want the 'no distributor' dialog to popup. Unfortunately the 'UnifiedPush.registerApp'  was not working for me, and I had to use 'UnifiedPush.registerAppWithDialog'. To avoid the popup, I added the work around code:
this.getSharedPreferences("unifiedpush.connector", Context.MODE_PRIVATE).edit().putBoolean("unifiedpush.no_distrib_dialog", true).apply();
In short, is the 'registerApp' expected to be working, and I am likely doing something wrong? It would be best if the plugin didn't include any workarounds.

I started working the plugin. In my app, my usage model was to use UnifiedPush if a distributor was found, otherwise to try and use Firebase. I guess this is similar to your embedded FCM distributor, but I didn't want to host a rewrite proxy.

Usually, we let the user choose what they prefer, it can be achieved with the google firebase-messaging lib or the embedded FCM distib.

As a result of my the way I use UnifiedPush, I didn't want the 'no distributor' dialog to popup. Unfortunately the 'UnifiedPush.registerApp' was not working for me, and I had to use 'UnifiedPush.registerAppWithDialog'. To avoid the popup, I added the work around code:
this.getSharedPreferences("unifiedpush.connector", Context.MODE_PRIVATE).edit().putBoolean("unifiedpush.no_distrib_dialog", true).apply();
In short, is the 'registerApp' expected to be working, and I am likely doing something wrong? It would be best if the plugin didn't include any workarounds.

Indeed, something may be wrong. What can be done to avoid the pop up when starting is checking if getDistributors is empty before calling registerAppWithDialog. This function (registerAppWithDialog) can be called once clicked on the UI button used to change distributor.
Nevertheless, all of this logic is on the application side. The library should just interfaces react with the android side :)

I finished a first pass of the plugin library, but I don't think it will be all that useful for you. I wasn't able to call into the JS from the backgrounded app. I left it as a replacement for the way I was using UnifiedPush and tested with my app.
I'll spend more time looking into why I can't call into the JS engine from a backgrounded app, but I'm not sure I'll be able to find a solution. I am happy to make any changes you suggest, or let you take over the repo.
repo: https://github.com/balzack/react-native-unifiedpush-connector
npm: https://www.npmjs.com/package/react-native-unifiedpush-connector


v2 Line graph with broken line for missing or 0 values

How do I have the line graph break up where the missing values or 0's are?  Right now both just default to 0 value and the line goes to the 0 marker.

@harisb to break the line insert a NaN into the data array.

Awesome thanks, that works!


feat: Fixes:#148 Add Bookmark Manager Extension

Description
This commit introduces the Enhanced Bookmark Manager extension, which provides advanced bookmark management capabilities within the browser. The extension includes the following features:

Bookmark Management: Users can add bookmarks along with custom tags for better organization.
Bookmark Display Options: Users can choose whether to display tags with bookmarks.
Sync Options: Enables bookmark syncing across devices.
Notification Options: Users can opt to receive notifications for new bookmarks.

Files and Directories

manifest.json: Defines the extension's metadata, permissions, and configurations.
popup.html: Provides the user interface for adding bookmarks and customizing options.
popup.js: Handles interactions in the popup interface.
background.js: Manages background tasks such as syncing bookmarks.
options.html: Allows users to customize their extension settings.
styles.css: Contains the styling for the popup interface to enhance user experience.
icons: Directory containing icon images (icon16.png, icon48.png, icon128.png).

Features

Add Bookmarks with Tags: Users can add bookmarks directly from the popup, including custom tags for better categorization.
Customization Options:

Bookmark Display Options: Users can toggle the display of tags with bookmarks.
Sync Options: Users can enable or disable bookmark syncing across devices.
Notification Options: Users can enable or disable notifications for new bookmarks.

Background Syncing: Automatically sync bookmarks across devices using Chrome's storage API.
Stylish and Responsive UI: The popup and options pages are styled with CSS for a modern and responsive user interface.

Future Enhancements

Search Functionality: Allow users to search bookmarks by tags or URLs.
Advanced Tag Management: Implement features for managing and organizing tags more effectively.
Nested Folders: Enable creating and managing nested folders for better bookmark organization.

Commit Overview
This commit lays the groundwork for an advanced bookmark management system within the browser. It provides a robust set of features for managing bookmarks more efficiently and sets the stage for future enhancements.
Fixes:  #148

Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have made this from my own
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Kindly avoid master to master branch pushing. It's not a very healthy practice because of some constraints.
For the next pull requests, create a new branch then raise the PR.

Okay thanks for the suggestions, i will take care of that for next pull request


Created A Donation page

⭐Created a donation page
➡ For the welfare of everyone , espacially the future generation
➡Changes created
👉🏻The Donation Page

👉🏻The Button

HTML not allowed in React !


Update to 0.63

This updates the version of react-native and react-native-windows to 0.63.

PackageProviders().Append(winrt::CheckboxWindows::ReactPackageProvider());

Auto-linking should be taking care of this now, so shouldn't we remove this?
I also added #include <winrt/CheckboxWindows.h> to pch.h, which we should also be able to remove.

Refers to: windows/rngallery/App.cpp:43 in c07c6a4. [](commit_id = c07c6a4769ad21e91cd2d15329a7c05e33e2f0b6, deletion_comment = False)

Just tried it, and doing that gets me a redbox when visiting the CheckBox page, due to a missing view manager.
Not sure if autolinking works with the checkbox module.. or whats up with that.

My instinct would be to merge this as is, then maybe have Jon or someone look at why autolinking isn't working.

k let's do that

In reply to: 695091709 [](ancestors = 695091709)


INFINITY-2040 Developer-facing changes to YAML port handling

Updates scheduler code and docs to reflect the above changes, and updates per-service yamls to retain their current behavior given the changes to default behavior.
Changes:

Removes deprecated fields from VIPs (previously threw helpful error when provided)
Adds 'advertise' setting to ports.
Changes default endpoint listing behavior: Developer must manually set the newly-added advertise: true, when previously the presence of a VIP automatically meant advertise (and lack of VIP meant don't advertise).
Changes default env behavior: Developer must manually provide an env-key if they want the port to be advertised in task envs, when previously a default of PORT_<PORT_NAME_HERE> was provided when env-key was unset.

Removed gc_frameworks() as it results in sandbox logs getting wiped. It was originally a workaround for CORE-874.

It seems as if the removal of the call to gc_frameworks was also attempted in #585 but abandoned.

I remember that commit, it had died in rebase hell independently of the gc_frameworks removal

Bulleted list in PR description covers the changes. Added some more detail there


Adjusted updateRef() to conform in usability

Added the following line
"if (ref === "HEAD") ref = "refs/heads/master";"
Therefore, ensuring that "HEAD" is resolved to "refs/heads/master", as is done in the other methods dealing with a single Ref, like deleteRef() or readRef()

Merged for now, but keep in mind that HEAD is not always refs/heads/master.  The server can set a different default branch.

Good Point. Wouldn't it be better then to remove this substitution from all of the methods?

I'd be fine either way.


Finite Field Artithmetic not implemented?

I haven't been able to find functions relating to libsodiums Finite Field arithmetic. If they're available how do I invoke them? Thanks.

Hi @TBCode523, you are right, finite field arithmetic is not implemented in the library.
Pull request for that would be welcome!
Adding it would be relatively straightforward, the java and native should be present since we are building the library from source, and I think I saw them in libsodium.js which we use for JS target, but I haven't checked if all of them are there.

I'm not experienced with developing cryptographic related algorithms, but I can take a look if more senior developers are unavailable.

I could take over, if you don't mind. I've got some experience with this and also brought support for Ristretto to LazySodium some time ago.


FE: NFT search support

So we can find things like the city GLB.

similar to #459

similar to #459

Yeah, might as well fold it in.

Yeah, might as well fold it in.


Control scroll/mouse scroll doesn't work at all

The program and videos show an option to scroll values to change them. Even with scrolling disabled in-game, the overlay doesn't scroll through any values. Not really sure if I'm doing something wrong or if the feature is broken.

I can support this claim. Installed POE overlay for the first time a week ago and all but these scrolling features for the currency of choice or values and mods dont function. (Windows 7, MX Master Mouse with default settings).

I couldn't get it working either, still waiting an update on this one.


Rename from ServerlessPlugin to TypeScriptPlugin

I propose to change the name of the plugin to avoid clashing with other plugins that might accidentally also be called ServerlessPlugin. This just happened to me, as my own plugin (https://github.com/SC5/serverless-plugin-additional-stacks) was also called ServerlessPlugin and these plugins shadowed each other, depending on their order in serverless.yml.
You can see the name of the plugin when using the sls command with no options, and apparently it's autodetected from the class name.

Just released 1.1.1


when asset_helper_tenancy is set to false, tenant_asset doesn't respect ASSET_URL config option as described in documentation

Describe the bug
I have an app that uses Livewire and Laravel Vapor for deployment.  I found that because of the way those packages internally use the asset() helper I had to disable the 'asset_helper_tenancy' configuration option in tenancy.php.  I then started using tenant_asset when I want to explicitly use a tenant specific asset... in the documentation it says

If config('app.asset_url') has been set, it will simply append tenant$id to the end of the configured asset URL. This is useful if you use Laravel Vapor

The behavior that I would expect would be that if I set asset_url, and I have the asset helper tenancy disabled, I would still be able to use tenant_asset() in order to take advantage of the asset_url configuration above... however it doesn't work.
The actual result is that it appends the file to /tenancy/assets/ and routes it to the controller to handle it (asset_url is completely ignored while using tenant_asset in this case).
it's possible that I'm just confused about how this should work.  If so, then let me know and close this up.  Thanks
Steps to reproduce

set 'asset_helper_tenancy' to false
set asset_url to some url like 'http://myapp.test'

$tenant = Tenant::first();
tenancy()->initialize($tenant);

tenant_asset('file.txt');

the expected output would be http://myapp.test/tenant+tenantId/file.txt
but the actual output is http://myapp.test/tenancy/assets/file.txt
Your setup

Laravel version: v8.9.0
stancl/tenancy version: v3.2.1
Storage driver: local

So i realized I can make my own helper if I really want it to work that way.  This probably isn't that very critical/important.  To me it feels like it should work that way after reading the documentation, but I can also see the argument against it as well.

I'll change how the asset helpers work in v4

Hi @isaackearl what would you do to implement the helper to make it work that way? I'm trying to achieve the same result and I'm still learning how things should be implemented the right way. Can you point me in the right direction?
Thanks!

Closing this since the docs now mention that tenant_asset() always creates paths to the TenantAssetController. We'll add some option to make tenant_asset() generate paths that respect the ASSET_URL in v4.


Outsource attribute :ClinicalTrial{leadSponsorName|collaboratorName} to seperate node

Sebastian:  I thought that maybe Lead Sponsors and Collaborators should become their own Entity nodes. Unless they are never the same, of course. Right now they are simple attributes, but it might be interesting to see what other trials a sponsor had been sponsoring or what other collaborators where doing
Tim: i guess there are some overlaps with :Affilition and :Entity nodes [with leadSponsorName].
later possible nlp entity linking and the resulting node merging would be straightforward when having seperated nodes
Task
Change https://github.com/covidgraph/data_clinical-trials-gov/blob/master/dataloader/load_data.cypher to have a new node for each leadSponsorNameand collaboratorName which is a property of :ClinicalTrial atm. Of course create a relationship to the source :ClinicalTrial node as well

Has been implemented in release 0.1.1 and 0.2


Fetch groups deep, instead of fetching group pair id.

Currently we only fetch the foreign key on the event_group_pairs table, which means if an event actually has groups there will be type errors, because EventInfo's and EditEventInfo's group_pairs property are objects, and if we want to get information on those groups we have to make another round trip.
Ideally we'd fetch all data in one go with the right structure. Alternatively we could fetch the groups as separate columns and then join manually into the group_pairs property of EventInfo.

Nvm using nested embedding and renaming this is achieved quite easily using
event_groups:event_group_pairs(groupA:group_a(title, description), groupB:group_b(title, description))
which also gives the exact structure we need.


fix(address-parsing): don't truncate ':' passwords

Fix a bug which truncated passwords containing a ':' character because
the parseAddress function relied upon node's url.parse().auth which
returns the user:pass pair already URI-decoded.
Fixes #318

This change is

@dnwe thanks for the contribution, sorry I've been out of town for the past few weeks.

@prestona @dnwe looks like this breaks on earlier versions of node, any chance you can update to accommodate that?


Latest XSL files for v1.1

Would it be possible to have latest XSL files (both invoice and corrective invoice/credit note) available for v1.1 release?
Thanks,
Jussi Koljonen

You can use the v.1.2 XSL files they are backward compatible.
Regards,
Eelko Neven

Just found out that the XSL files are NOT backwards compatible. You'll find plenty of examples in https://github.com/SimplerInvoicing/testset where the 1.1 or 1.2 XSL files return different validation results for the previous generation(s).


Shaded version of Jackson Databind affected by CVE-2020-25649

The version of Jackson Databind (2.10.2) that is shaded within the bundle is affected by CVE-2020-25649 and is affecting security scans for components that embed the bundle jar.

Any chances to get a fix for this or an official statement saying that ibm-cos-sdk-java is not affected?

This notice came in after the code freeze for our latest release. At the time I did try making these as last-minute updates, but there were several test failures that we did not have time to investigate. The upstream AWS project still uses an even older version for Java 6 compatibility, which may be a complicating factor. We are tracking this internally.

This notice came in after the code freeze for our latest release. At the time I did try making these as last-minute updates, but there were several test failures that we did not have time to investigate. The upstream AWS project still uses an even older version for Java 6 compatibility, which may be a complicating factor. We are tracking this internally.

Thanks @IBMeric
Is there a way to determine if ibm-cos-sdk-java is exposed to the CVE-2020-25649 vulnerability?
If it is exposed or if there is no easy way to know, any ETA as when a new version might be available with an updated version of jackson databind?

Thanks @IBMeric
Is there a way to determine if ibm-cos-sdk-java is exposed to the CVE-2020-25649 vulnerability?
If it is exposed or if there is no easy way to know, any ETA as when a new version might be available with an updated version of jackson databind?

We inherit the jackson-databind dependency from the upstream AWS S3 SDK. The AWS S3 stance is that they are not vulnerable to several CVEs as evidenced here: https://github.com/aws/aws-sdk-java/issues/2096. We will address it as soon as AWS S3 addresses it and makes a release available, or if we are able to do it independent of them without uncovering issues in this quarter.

We inherit the jackson-databind dependency from the upstream AWS S3 SDK. The AWS S3 stance is that they are not vulnerable to several CVEs as evidenced here: https://github.com/aws/aws-sdk-java/issues/2096. We will address it as soon as AWS S3 addresses it and makes a release available, or if we are able to do it independent of them without uncovering issues in this quarter.

@IBMeric seems that AWS S3 SDK v2 has already addressed this issue: https://github.com/aws/aws-sdk-java-v2/issues/2207
Can we use that?

@IBMeric seems that AWS S3 SDK v2 has already addressed this issue: https://github.com/aws/aws-sdk-java-v2/issues/2207
Can we use that?

@IBMeric any updates? Thanks

@tcherel This has already been fixed and will appear in our mid-March release.

This is excellent news. Thanks @IBMeric

This issue has been resolved in 2.9.1.


Add parents and rank

What the pull request does
Add the rank and parent options.
Fixes #11
Type of change

[ ] :bug: Bug fix (non-breaking change which fixes an issue)
[x] :sparkle: New feature (non-breaking change which adds functionality)
[ ] :boom: Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] :book: This change requires a documentation update

Checklist

[ ] The changes are documented

[ ] The docstrings of the different functions describe the arguments, purpose, and behavior
[ ] There are examples in the documentation website

[x] The changes are tested
[x] The changes do not modify the behavior of the previously existing functions
[x] The Project.toml field version has been updated

Codecov Report

Merging #13 (a985815) into performance/descendants (91ccb33) will decrease coverage by 4.99%.
The diff coverage is 40.00%.

@@                     Coverage Diff                     @@
##           performance/descendants      #13      +/-   ##
===========================================================
- Coverage                    98.21%   93.22%   -5.00%
===========================================================
  Files                            6        6
  Lines                           56       59       +3
===========================================================
  Hits                            55       55
- Misses                           1        4       +3

Flag
Coverage Δ

unittests
93.22% <40.00%> (-5.00%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/NCBITaxonomy.jl
100.00% <ø> (ø)

src/lineage.jl
75.00% <40.00%> (-25.00%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91ccb33...0413e76. Read the comment docs.


Add docker generator change and logging

Purpose

Preprend registry to the docker images name.

Goals

Fixes and debug loggin.

Codecov Report

Merging #216 into master will increase coverage by 0.29%.
The diff coverage is 68.75%.

@@             Coverage Diff              @@
##             master     #216      +/-   ##
============================================
+ Coverage     62.18%   62.47%   +0.29%
- Complexity      118      119       +1
============================================
  Files            13       13
  Lines           595      597       +2
  Branches         56       56
============================================
+ Hits            370      373       +3
  Misses          196      196
+ Partials         29       28       -1

Impacted Files
Coverage Δ
Complexity Δ

...g/ballerinax/docker/DockerAnnotationProcessor.java
79.13% <ø> (-0.87%)
17 <0> (-1)

...lerinax/docker/generator/utils/DockerGenUtils.java
32.78% <100%> (+2.78%)
10 <1> (+1)
:arrow_up:

...erinax/docker/generator/DockerArtifactHandler.java
48.82% <66.66%> (+1.87%)
16 <0> (+1)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ac9229...56640b8. Read the comment docs.


Feature request: Allow role-based authentication

For Posthog Cloud, this plugin should allow for role assumption rather than Access Keys and Secret Access Keys.
This would require the user to allow a Posthog-owned role or IAM user to assume a role in their AWS account, rather than giving Access Key/Secret Key to Posthog.
This is more secure because we can restrict access to the Posthog account/role that we authorize, and then there are no credentials to leak.

Closing as this plugin has been deprecated in favor of our S3 destination for batch exports.


Support match_phrase function in SQL/PPL query engine

Related design is presented in issue #182
Todo list

[ ] Support the match_phrase functionality by pushing it down to the search engine
[ ] Enable match_phrase function in SQL and PPL syntax and parser, including all the available parameters
[ ] Make sure the function in new engine is compatible with the old engine support (including match_phrase and matchphrase functions in old engine)
[ ] Add unit tests. (Unit tests are mandatory for all code changes.)
[ ] Add integration test cases for match_phrase
[ ] Update user manual

Function details
The match_phrase function maps to the match phrase query used in search engine. This query analyzes the text and creates a phrase query out of the analyzed text.

For example, are queries like source=index | where matchphrase(field, 'text') valid?

@MaxKsyunz match_pharse should be enough, i don't think PPL functions support alternative spellings (there is date_format() but not dateformat())

@joshuali925, here's a demo of the changes in PR #604
https://user-images.githubusercontent.com/99687200/168006197-8599dc17-3cf0-4e8c-92aa-a6b82a04081b.mp4

fixed by: https://github.com/opensearch-project/sql/pull/604


MXKRoomViewController: Added "joinRoomWithRoomId:andSignUrl:"

to join a room from a 3PID invitation or room link.

Lgtm


Qdrant filter integrations

PRs:

https://github.com/code-kern-ai/refinery-ui/pull/150
https://github.com/code-kern-ai/refinery-gateway/pull/142
https://github.com/code-kern-ai/refinery-submodule-model/pull/49
https://github.com/code-kern-ai/refinery-neural-search/pull/31
https://github.com/code-kern-ai/refinery-embedder/pull/52

I found something which I am not sure why it happens, but I try to describe it as best as I can:
Context:

I am using the Open AI ada Model
I am using a 100 records dataset which consists of the first 100 records of the clickbait dataset
clickbait - initial_default_100 records.json.zip
The embedding I use is on the headline attribute and running_id is the selected filter attribute
I am running the neural-search, gateway with submodule model and ui in excluded containers which are set on the feature branch

Now the situation:
If I search for records between 1 and 100 on similarity for the record with running_id 1,

than I get 6 records as result which all have a running_id which is smaller than 50.

Here you can't see all of them but I checked multiple times and it is record with running_id [1, 2, 10, 23, 24, 28]
If I now search for records between 1 and 50 again on similarity for record with running_id 1 I get the same result like expected. Again the 6 records [1, 2, 10, 23, 24, 28].
If I now search for records between 50 and 100 again on similarity for record with running_id 1 I get a strange result. I get the record with the running_id 1.
I don't know why this happens tbh. I think, that there is no result in similarity search because of the other tests I did and there should be no match in between running_id 50 and 100. But still I get one record back with running_id 1. Do you know why this happens? Is this the expected behavior from your side?


Issue #131: Speed up exporting processes via export document

What's in the PR

provide typesystem as optional argument to the export_text_analysis_to_cas method
unit test

IMHO the type system should be provided by a parameter instead. That ensures that the user has proper control over the type system being passed in. Simply caching the first type system could mean that different runs of the same code use different type systems.

Codecov Report

Merging #132 (6b82590) into dev (4f4ed17) will increase coverage by 0.03%.
The diff coverage is 96.15%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##              dev     #132      +/-   ##
==========================================
+ Coverage   92.17%   92.20%   +0.03%
==========================================
  Files          16       16
  Lines        2146     2169      +23
==========================================
+ Hits         1978     2000      +22
- Misses        168      169       +1

Impacted Files
Coverage Δ

tests/test_process.py
99.42% <94.11%> (-0.58%)
:arrow_down:

averbis/core/_rest_client.py
86.76% <100.00%> (+0.08%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Log commit author and skip assign issues not created

Logging the commit author while retrieving from API
In some cases (Like ADD_LIMIT being set), some issues might not have been created. In those cases, skip assigning the issue.

@ribtoks
While running in my repo, I came across two issues.

If the issue wasn't created in the first place, it still tries assigning the author, so added a condition to skip that over here.
All the issues were being assigned to me for some reason. So, logging the commit hash here, and will verify with the API why it is getting me as the author. Also good to log this info anyway.

@ribtoks I ran this again on my repo and the issue is that the Commit API was never actually called.
So there's two possible reasons for this:

tdg doesn't return commithash properly and so Line 381 is never true.
commitToAuthorCache is misbehaving, and Line 357 is always returning hits. This is more likely the cause as the size of issueTitleToAssigneeMap is correct.

Will create another PR to add another line of logging to confirm this.


Vet list pets scenario

Given

A valid username and password from an admin user
At least one pet registered in the platform
I am logged in

When

I click in the search main menu link
I type "josdem" username
I click in submit button

Then

I validate the Pet's name is visible
I validate the Pet's breed is visible
I validate the Pet's deworming value is visible
I validate the Pet's sterilized value is visible
I validate the Pet's vaccinated value is visible

Dependencies

[x] Add test-id locators to the vet list view

Screenshot

PR merged: https://github.com/josdem/playwright-vetlog/pull/48


✨ Making NotBlankString.plus(Any) function available on Java

📝 Description
We would like to make the NotBlankString.plus(Any) function available for Java users.
This means that its compatibility should be tested and its documentation should indicate their usage from Java code.
Here's an example of calling this function from Java code:
final NotBlankString hello = NotBlankString.create("hello");
final NotBlankString world = NotBlankString.create("world");
final NotBlankString message = hello.plus(' ').plus(world);
System.out.println(message); // hello world

🔗 Dependencies
This issue is blocked by the following ones:

[x] #543
[ ] #404
[x] #412

✅ Checklist

[ ] Make the function available for Java users, test its compatibility, update the public API binaries and update the unreleased changelog.
[ ] Close this issue as completed and update tracking ones if present.

This change will be implemented in #404.


Add unmuteText option, fix muteText option, remove unused "mejs.mute-toggle" translates

muteText option currently do not works as expected, I fixed it and added unmuteText option. Also, the translate "mejs.mute-toggle" isn't used, so I decided to remove it from translates.

Coverage remained the same at 63.957% when pulling f03b6a7dc887490d92387f57ff76c70d53e111ce on DmitryKrekota:master into 1dc370a497ae58fdce35252a80a5638b8b9a5965 on johndyer:master.

Thanks for this PR. The only thing I can comment is that the test file shouldn't be written on ES6 given that not all browsers support that and it needs to test IE9+, so only replace the ES6 code with regular JavaScript and I'll be able to merge this. Thanks again

Okey, done. I also remove redundant mocha.js script in test/player.html

Coverage remained the same at 63.957% when pulling 5cad2523cfa37a453e4844498fb0993fab5d8f5b on DmitryKrekota:master into 1dc370a497ae58fdce35252a80a5638b8b9a5965 on johndyer:master.

Coverage remained the same at 63.957% when pulling 5cad2523cfa37a453e4844498fb0993fab5d8f5b on DmitryKrekota:master into 1dc370a497ae58fdce35252a80a5638b8b9a5965 on johndyer:master.

Thanks. Once I'm front of my computer I'll merge this. Great work!

PR merged. Thanks for the work on this


Define semantics of zql expressions with aliases

At the moment, zql expressions convert aliases to their underlying types before processing, and don't attempt to "restore" aliases in the results. However, given our design goal of supporting aliases throughout zng and zql, we need to decide the semantics of expressions on aliased types, and implement that.
As an example of this to-be-specified behavior, consider
#myint=uint64
#0:record[i:myint,j:uint64]

the type of i + i should presumably be myint. How about i + j and i + 4?
similar questions arise with the use of functions.

Also, given
#0:record[i:myint,j:uint64]
0:[1;1;]

does filter i=j evaluate to true on this record?

Also, given
#ipaddr=ip
#0:record[addr:ip]
0:[<IP_ADDRESS>;]
#1:record[addr:ipaddr]
0:[<IP_ADDRESS>;]

does count() by ip result in one or two groups?

One solution would be to say that as soon as a record field is operated on, any aliased types contained in that field are reduced down to their underlying "concrete" type.
This would go with  high-level idea that aliases are part of zng rather than zql; however zql preserves them when doing non-destructive record manipulation. (cut, rename, tail, head, sort, ..).  Expressions and other places that compare and/or create new values would not preserve aliases.
Going back to the above examples:

i+i, i+j, and i+4 would all be uint64
count() by addr results in one group
filter i=j evaluates to true on that record

Open question:

does put a=b preserve an alias type in b? probably it should.
does rename a=b preserve an alias? probably likewise

This is still problematic...
% cat in.zson
{addr:<IP_ADDRESS>}
{addr:<IP_ADDRESS>(ipaddr=(ip))}
% zq "count() by addr" in.zson
{addr:<IP_ADDRESS>,count:1(uint64)}
{addr:<IP_ADDRESS>(=ipaddr),count:1(uint64)}
% zq "count() by addr:=ip(addr)" in.zson
{addr:<IP_ADDRESS>,count:1(uint64)}
{addr:<IP_ADDRESS>(=ipaddr),count:1(uint64)}
% zq " yield ip(addr)" in.zson
<IP_ADDRESS>
<IP_ADDRESS>(=ipaddr)

No longer relevant / done.


Webhook: Do not fetch table with formulas if no webhook is enabled

Context
Some of our users have their document stuck at some point. My analysis is that it is related to webhooks, even when they are disabled.
For more details, see  #799
Proposed solution
This solution does not fix  #799, but at least I propose to not fetching table data when all of the webhooks are disabled (unless I misunderstand something, that is unnecessary). With that patch, I could manage to make the document work on my local machine.

I think it'd be better to filter at this line: const triggersByTableRef = _.groupBy(triggersTable.getRecords(), "tableRef");. And then the if (!trigger.enabled) { check can be removed.

@alexmojaki Done!

Please remove if (!trigger.enabled) { further down the file, and add a test somewhere that non-enabled webhooks aren't triggered (I can't see one, finding an existing test that fails if nothing checks enabled would work too).

Done! (also if I am right for the condition removed)

add a test somewhere that non-enabled webhooks aren't triggered (I can't see one, finding an existing test that fails if nothing checks enabled would work too).

You talk about nbrowser tests? (I only found them for webhooks)

As well as the nbrowser tests, there's some in the DocApi tests.

And happy new year to you too!

Thanks for your review! I have taken into account your remarks.

Please confirm that the test passes with the old version of Triggers.ts

It does

and fails if both checks for enabled are removed.

I understand here that you want me to remove 2 conditions. It fails if I remove this condition:
https://github.com/gristlabs/grist-core/blob/de13a2fd7a1391af70a840a1640f4a46c03843c6/app/server/lib/Triggers.ts#L548-L549
I don't see another one though.

I meant that it should fail if neither the original check nor the new check you've replaced it with is present. I assume you're saying that it fails if the original check is removed from the original Triggers.ts file, which is equivalent. So I think we're good.


To be able to use multiple sprites or models in a particle system

(Request from client)

Is this what is requested?
http://playcanvas.github.io/#/graphics/particles-random-sprites

Not quite. They were hoping to be able to use the sprite asset type with a non grid based texture atlas. In the engine example, each frame is the same size and have the same number of frames.
They would also need to be able to preview in the Editor too.

I like the idea. I've had this use case before, where I needed a particle system with different particles, not using the same one. The workaround is to have multiple particle systems, but if I was able to use just one it'd be better.


Create Play Framework based IntelliJ project

We need to migrate from a basic HTML setup to an actual Play based setup in IntelliJ.  Will be setting up a new project branch for this, and setting up the actual Play Framework from there.

I went ahead and just merged my Digits application as of WOD E48 into the PlayProjectSetup branch, so that the file structure and setup is there.  It tests OK with activator test, and runs fine with activator run.  The only changes made is that I moved the images that are referenced in the readme to docs->images.  Everything else remains in the mockup folder as of commit 543e004.

This is complete!


Fix exception printing (remove extra newline)

Our exception dump had an extra newline between the source line and caret pointing to the issue

There's a slightly different implementation of this in ipy3. Would be nice to be consistent. I have no preference either way.
While you're in there, maybe remove the extra line endings at the end?
IronPython:
>>> raise Exception
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
Exception

>>>

CPython:
>>> raise Exception
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
Exception
>>>

I'll make them consistent and fix the other newline as well.


Enable build of mesa-demos for userland graphics drivers

Enable build of mesa-demos for userland graphics drivers

mesa-demos can be built fine if both gles1 and egl options are disabled. This allows to have utilities like glxinfo or glxgears

,mm, this is going to fail to build if the wayland package option gets enabled (and it gets enabled if the distro has the feature) unless poky contains this patch that I just sent to the oe-core mailing list
I guess is better that we disable wayland here as well. On this package enabling packageconfig option  wayland without egl is useless in the end.

Looks good. Thanks for this. The only request would be to keep the current git log format:
https://meta-raspberrypi.readthedocs.io/en/latest/contributing.html

Pushed a new commit with that format.
Thanks!


Some keys don't repeat

I noticed if you hook up glfwSetCharCallback (or glfwSetCharModsCallback), then HOLD DOWN a letter key—"Q" for example—the callback only gets called once, and never repeats.
But if you hold down another key—let's say "E"—it DOES repeat, which I would expect to be the correct behavior.
The only pattern I can figure that determines which keys repeat and which don't is that keys that normally have a little diacritics popup (see picture) DO repeat, and keys that don't have that popup, don't repeat.

I tested on a couple computers (both on latest version of macOS Sierra) with the same results. I'll do a little more research, like if disabling that popup changes this behavior.
It should also be noted that this only seems to affect glfwSetCharCallback and glfwSetCharModsCallback. glfwSetKeyCallback seems to function normally and repeats for all keys when held.
Test code:
// main.cpp
#include <GLFW/glfw3.h>
#include <iostream>

void charCallback(GLFWwindow * window, unsigned int codepoint, int mods) {
    std::cout << "char callback called with codepoint " << codepoint << std::endl;
}

int main(void)
{
    GLFWwindow* window;

    if (!glfwInit())
        return -1;

    window = glfwCreateWindow(640, 480, "Hello World", NULL, NULL);
    if (!window)
    {
        glfwTerminate();
        return -1;
    }

    glfwMakeContextCurrent(window);

    glfwSetCharModsCallback(window, charCallback);

    while (!glfwWindowShouldClose(window))
    {
        glClear(GL_COLOR_BUFFER_BIT);
        glfwSwapBuffers(window);
        glfwPollEvents();
    }

    glfwTerminate();
    return 0;
}

Built and run with:
clang++ main.cpp -I . -L . -lglfw3 -framework Cocoa -framework IOKit -framework CoreVideo -framework OpenGL -o glfwbugtest && ./glfwbugtest
Where the GLFW includes folder and libglfw3.a are in the same directory as main.cpp.

Disabling the diacritics popup does indeed resolve the issue. Using the above code, all keys now call the callback repeatedly when held.
It's hardly a solution though, as only a fraction of a percent of people will have disabled the popup, and it's not even something you can do through standard settings.

This is likely dependent on #41.

You can disable this programmatically in your application by changing your user defaults. e.g. something like this:
#define GLFW_EXPOSE_NATIVE_COCOA
#import <GLFW/glfw3native.h>

void AllowKeyRepeats(void)
{
    @autoreleasepool {
        [[NSUserDefaults standardUserDefaults] setBool: NO forKey: @"ApplePressAndHoldEnabled"];
    }
}

This could be handled by GLFW by default, however I'm not sure if that would be desired or not?
Alternatively if you don't want to add any platform specific code, then you'll just need to avoid key callbacks. And instead manually poll the key states yourself.

This should be fixed now with 58a247b26d283c40078426443d375d4c126d69e1.
Thank you @laxcat for reporting it and @ScrimpyCat for pointing towards the solution!


M from Monday is | |

More cosmetic than other, but to display Monday, the "M" is "| |", why is there no bar at the top?

 To add the top bar, edit the file /segTable/segment_list.txt and change the line:
0x4D  bcef  ; M
to:
0x4D  abcef  ; M
and save.
Issue the command "make led" then "make" and it will be compiled with the change you mentioned.

thanks!


Android ndk camera

Is there any plan to merge this videoio capture device officially?

@ihsakashi - just making a PR now


test(cover): add ut for tracking coverage

Signed-off-by: Ramkumar Chinchani<EMAIL_ADDRESS>
What type of PR is this?

Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

https://github.com/project-stacker/stacker/pull/347
^ this is giving trouble in the unpriv case as well as some interference from container builds likely. Meanwhile, we should also start adding regular UTs.


Fix error for function with only a return.

[].forEach(function() {
  return;
});

This errors on arrow-function.js because there was no logic to handle the useless return.

I'm fine with merging this but what is the point of such code?

Thanks. The .forEach() was just a proof. The original issue was a stub of an error function:
http.post(url, data, function(result) {
  // does something
}, function() {
  return;
});

It's something that shouldn't really exist in the first place, but old code has a way of breaking all the rules.