Adding namespace to the resources

Describe the problem:

CRD contains namespace for every resource that it creates (I can see it using describe). I added a namespace to the EntityInfo assuming that during reconciliation it would be read from the CRD, but I am reading null. Am I missing something?

Steps to reproduce:

Add namespace to EntityInfo class
Create resources
Log desired resources during reconciliation

Observed Results:

namespace is null.

Expected Results:

Namespace is the namespace that can be obtained from oc describe resource

Namespace should be inferred automatically from the context. If user creates custom resource of CRD "type" in namespace X and provided the operator watches for event in this namespace, it should get notified.
One can set the environment variable WATCH_NAMESPACE to comma separated list of namespaces in which the operator will watch for events (it basically starts n those watchers where each watcher will have the namespace private field correctly set).
other allowed values for WATCH_NAMESPACE are * and ~.
~ ... run the watcher in the same namespace where the operator is deployed
* ... watch for the events in all the available namespaces
The case with * is little bit tricky. It doesn't start n threads/watchers for each exisiting namespace (it would miss the newly created namespaces and would be inefficient). Instead, it runs just one watcher that does some magic under the covers.
For the * case the operator's service account requires ClusterRole that would allow the cross-namespace "watching".
If the value of WATCH_NAMESPACE is empty, it behaves as in ~-case.
Could you please post here your yaml file that you use for deploying the operator? Specifically, what's the value of WATCH_NAMESPACE in your case.

Thanks Jirka,
I figured all this.
What i was trying to do is to get the namespace value of the resourse during reconsiliation. Trying to implement reconsiliation for * that you are skipping iñ spark
Get Outlook for Androidhttps://aka.ms/ghei36

From: Jirka Kremser<EMAIL_ADDRESS>Sent: Monday, March 25, 2019 7:10:58 AM
To: jvm-operators/abstract-operator
Cc: Boris Lublinsky; Author
Subject: Re: [jvm-operators/abstract-operator] Adding namespace to the resources (#39)
Namespace should be inferred automatically from the context. If user creates custom resource of CRD "type" in namespace X and provided the operator watches for event in this namespace, it should get notified.
One can set the environment variable WATCH_NAMESPACE to comma separated list of namespaces in which the operator will watch for events (it basically starts n those watchers where each watcher will have the namespace private fieldhttps://github.com/jvm-operators/abstract-operator/blob/62937b4e9f9a399574c8295da18963df26426385/src/main/java/io/radanalytics/operator/common/AbstractWatcher.java#L35 correctly set).
other allowed values for WATCH_NAMESPACE are * and ~.
~ ... run the watcher in the same namespace where the operator is deployed

... watch for the events in all the available namespaces

The case with * is little bit tricky. It doesn't start n threads/watchers for each exisiting namespace (it would miss the newly created namespaces and would be inefficient). Instead, it runs just onehttps://github.com/jvm-operators/abstract-operator/blob/62937b4e9f9a399574c8295da18963df26426385/src/main/java/io/radanalytics/operator/common/AbstractWatcher.java#L127 watcher that does some magichttps://github.com/jvm-operators/abstract-operator/blob/62937b4e9f9a399574c8295da18963df26426385/src/main/java/io/radanalytics/operator/common/AbstractOperator.java#L163:L174 under the covers.
For the * case the operator's service account requires ClusterRole that would allow the cross-namespace "watching".
If the value of WATCH_NAMESPACE is empty, it behaveshttps://github.com/jvm-operators/abstract-operator/blob/62937b4e9f9a399574c8295da18963df26426385/src/main/java/io/radanalytics/operator/common/OperatorConfig.java#L79 as in ~-case.
Could you please post here your yaml file that you use for deploying the operator? Specifically, what's the value of WATCH_NAMESPACE in your case.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/jvm-operators/abstract-operator/issues/39#issuecomment-476169276, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AYHWG9cZHQ4CbiKc-r9X8iHJiFr2UU2aks5vaLzSgaJpZM4cFRWR.

I see. There is that getDesiredSet method that can help with the full reconciliation, however the entities wont have the actual namespace on them and it wasn't actually designed for the "*". You can always fall back to low-lvl operations using the fabric8 client in your full reconciliation method and maintain some hash map of your entities (including the namespace). Drawback is that running an expensive full reconciliation method (where you query multiple namespaces, etc.) can have negative performance impact, but it'c certainly doable.
If you think the getDesiredSet can be done better for the "*-case", feel free to open PR. Help is always welcome.

Jirka, I created PR, but I do not have a permission to add it.
Basically I have modified 2 classes:
I tested this and it works great. With this in place, I can easily implement reconciliation for the namespace “*” cause I can get not only the name, but namespace as well
Let me know if this is enough or you need something else
Boris Lublinsky
FDP Architect
<EMAIL_ADDRESS>https://www.lightbend.com/

On Mar 25, 2019, at 7:19 AM, Jirka Kremser<EMAIL_ADDRESS>wrote:
I see. There is that getDesiredSet https://github.com/jvm-operators/abstract-operator/blob/master/src/main/java/io/radanalytics/operator/common/AbstractOperator.java#L348 method that can help with the full reconciliation, however the entities wont have the actual namespace on them and it wasn't actually designed for the "*". You can always fall back to low-lvl operations using the fabric8 client in your full reconciliation method and maintain some hash map of your entities (including the namespace). Drawback is that running an expensive full reconciliation method (where you query multiple namespaces, etc.) can have negative performance impact, but it'c certainly doable.
If you think the getDesiredSet can be done better for the "*-case", feel free to open PR. Help is always welcome.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/jvm-operators/abstract-operator/issues/39#issuecomment-476217281, or mute the thread https://github.com/notifications/unsubscribe-auth/AYHWG297NOLBu5jVCncFGLbyi8LyRm5eks5vaNrfgaJpZM4cFRWR.

Jirka, I created PR, but I do not have a permission to add it.

I can't see the PR, you should have permissions to open a pull request. You need to fork the repository first, push the commits to your forked version and then open the PR against this repo (https://help.github.com/en/articles/creating-a-pull-request-from-a-fork)
... or post a patch here in the comment and I can test it and possibly apply

Here are the 2 changes that I had to make
Archive.zip

Jiri,
Any progress on this?

well, it would be much faster, if you just opened the pull request :)
let me look into this..

ok, so the Archive.zip ^ contains two files and they are the exact copies of what is currently in this repository, check:

https://github.com/jvm-operators/abstract-operator/blob/62937b4e9f9a399574c8295da18963df26426385/src/main/java/io/radanalytics/operator/common/Operator.java
https://github.com/jvm-operators/abstract-operator/blob/master/src/main/java/io/radanalytics/operator/common/AbstractWatcher.java

Seriously, if you want the change to get in, either fist consult this and then open the PR or send only the patch/diff. Because even if the zip archive had the right files with your change, I'd have to create the PR from it myself.

Oh, I am sorry, wrong file
Archive.zip

And I am sorry again, here is the right one
Archive.zip
In the EntityInfo, namespace is added and in the custom resource watcher, convert method is updated to get namespace from CRD and map it to the resource. Both are tested.
Sorry about confusion

Thanks for the change, the PR - https://github.com/jvm-operators/abstract-operator/pull/41 You will find your changes in the next release.


Delete backup file after uploading

This was causing high disk space usage because we weren't cleaning up these files.

Could use a Tempdir instead - but probably not worth the changes.


Fix typo in config location, apply CS fixer & add CS fixer to github actions

Closes #29
See individual commits for more information.

Awesome thanks! i believe we need to take a look at the phpcs fixer settings,
The newline wasn't removed in
tests/Factories/LaravelPackageManifestFactoryTest.php and  tests/TestCase.php

Awesome thanks! i believe we need to take a look at the phpcs fixer settings, The newline wasn't added in tests/Factories/LaravelPackageManifestFactoryTest.php and tests/TestCase.php

Updated the config and CI.


what the difference between REPLY and edit???

its working now in  redmine 5.0.3
but im not see any difference between it reply and edit

Me too....
what the different  with these two?


Add SANS Institute to adopters

Hey, I just made a Pull Request!
Add SANS Institute to adopters and clean up some misformatted rows.
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@cklewin Seems a conflict crept in again - sorry, I wanted to help rebase but the merge makes it a bit trickier and I need to be careful with the DCO mechanism :) If you prefer to do master merges, that's fine, if you prefer to reconstruct from the root of the branch, that's fine too. Let us know if we can help in any way. There's also a "New Adopters" tab on the right side of the screen on https://backstage.io/ if you want to not have to deal with this file manually at all!

Shipped!


[WinForms] API validate input parameters and throw ANE

Selected API validate input parameters and throw ArgumentNullException.
Selected API now validate input parameters and throw ArgumentNullException where previously a NullReferenceException could be thrown, if APIs were invoked with null input arguments.
Throwing ArgumentException is inline with the behaviours in .NET Runtime, and provides developers with a better debug experience clearly communicating which argument caused the exception.
Old behavior
The listed API would throw NullReferenceException if invoked with null input arguments.
New behavior
The listed API would throw ArgumentNullException if invoked with null input arguments.
Reason for change
Throwing ArgumentNullException is inline with the behaviours in .NET Runtime, and provides developers with a better debug experience clearly communicating which argument caused the exception.
Recommended action

Review and, if necessary, update the code to prevent passing null input arguments in the listed API.
If the code is handling NullReferenceException replace (or supplement) it with handling ArgumentNullException.

Category

Windows Forms

Version introduced: .NET 6.0 Preview 1
Affected APIs

TreeNodeCollection

[x] TreeNodeCollection.Item[Int32] Property

Version introduced: .NET 6.0 Preview 3
Affected APIs

DrawTreeNodeEventArgs

[x] DrawTreeNodeEventArgs(Graphics, TreeNode, Rectangle, TreeNodeStates) Constructor when graphics is null

Version introduced: .NET 6.0 Preview 4
Affected APIs

DataGridViewRowStateChangedEventArgs

[x] DataGridViewRowStateChangedEventArgs(DataGridViewRow, DataGridViewElementStates) Constructor when dataGridViewRow is null

Issue metadata

Issue type: breaking-change

I'm going to close this issue now. If there are any more ANE changes for .NET 6, please open a new issue.


⚠ Processors has degraded performance

In 9219b38, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 60 ms

Resolved: Processors performance has improved in 114089d.


Add missing dtb files

This patch adds to the image the missing dtb files for
the IMX6-ULL SoC type
Signed-off-by: Sebastian Panceac<EMAIL_ADDRESS>

Fixes https://github.com/balena-os/balena-variscite/issues/70


Twig support?

Have you considered Twig Support for this project? http://twig.sensiolabs.org/

I haven't so far, but if you'd be interested in adding it as an optional approach to rendering the view layer, we would happily consider a pull request. I think using PHP as the template language would remain the default option for backwards compatibility.


fix typo in readme

In readme, the repository name was openebs-docs, but it should be litmus-docs
Signed-off-by: Jayadeep KM<EMAIL_ADDRESS>

Changed the base branch to staging


PF1630: terra group list shows in table view with the test on 2 groups

email:42
members:7
policies:10

The members column would look better right aligned.
On Mon, May 16, 2022, 5:14 PM ginaygoogle @.***> wrote:

[image: Screen Shot 2022-05-16 at 5 13 44 PM]
https://user-images.githubusercontent.com/100877272/168683507-3bb20e44-5922-4e59-9afe-09572af1b9a9.png
email:42 members:7 policies:10
—
Reply to this email directly, view it on GitHub
https://github.com/DataBiosphere/terra-cli/pull/253#issuecomment-1128143491,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMYAQRHNFVR3XONOXXXVLTDVKK3DNANCNFSM5WB3GEAA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Talked with Jay. There is a bug on terra group list. after delete one group, when list again, it will failed due to could not find the deleted group.

This PR is blocked by the bug. https://broadworkbench.atlassian.net/browse/PF-1652
You should be able to continue this PR despite that bug, since it's limited to a particular group in that one environment.

This PR is blocked by the bug. https://broadworkbench.atlassian.net/browse/PF-1652

You should be able to continue this PR despite that bug, since it's limited to a particular group in that one environment.

Hi @jaycarlton  I do not quite understand here. We require pass 3 checks and get 2 approve to merge. but if there is a bug, we could not pass the 3 checks and could not merge. So that is the meaning I said I was blocked there.


help me i'm new in this game

Describe your problem here.
while playing mfm deluxe mod i got this:
C:\HaxeToolkit\haxe\std/cpp/_std/sys/io/File.hx (line 30)
Song.hx (line 104)
StoryMenuState.hx (line 321)
StoryMenuState.hx (line 260)
flixel/FlxState.hx (line 202)
flixel/FlxGame.hx (line 747)
flixel/FlxGame.hx (line 677)
flixel/FlxGame.hx (line 545)
openfl/events/EventDispatcher.hx (line 402)
openfl/display/DisplayObject.hx (line 1399)
Uncaught Error: [file_contents,assets/data/too-clergy/too-clergy.json]
Please report this error to the GitHub page: https://github.com/ShadowMario/FNF-PsychEngine

Crash Handler written by: sqirra-rng

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No, I didn't edit anything

here's the link where i got this mod https://gamebanana.com/mods/452699

it appeares the file too-clergy.json doesnt exist. so thats probably why its crashing.
maybe try it on a different difficulty if you can.


[#6664] Completion of FilePath and targets from external repositories

Checklist

[x] I have filed an issue about this change and discussed potential changes with the maintainers.
[x] I have received the approval from the maintainers to make this change.
[x] This is not a stylistic, refactoring, or cleanup change.

Discussion thread for this change
Issue number: #6664, #505
Description of this change
This hould be the last big PR closing those two issues. It adds external workspace prefixed path and rule completion. Semantics should be similar to the current completion semantics. Added tests for it and tweaked the test fixtures to help.

sorry for the delay, I'm mostly OOO this week

Should i ping someone to land this ?


Use stringer for all enums

We have a lot of enums in config.go and log.go, and it would be convenient if they all had String() method that returned enum's symbolic representation. This can be easily achieved using stringer tool.
Steps:

add stringer magic comment to all enums: Interface, Protocol, FecEncoding, PacketEncoding, FrameEncoding, ChannelSet, ResamplerBackend, ResamplerProfile, ClockSource, LogLevel (note: no need to add it to Slot, it's not a enum)

configure stringer to trim enum's prefix

add Makefile target that runs go generate and document it in README

add CI step (in build.yml) checking that we did not forget to run go generate and commit results (it may run go generate on CI and then check git status)

@gavv can I try this?

Sure, thank you!

Landed


Problems with npm install in sage folder

I keep getting error no. 47 running npm install and I can't seem to figure out why :( Ive tried delting lockfiles in my .npm and .nvm folders but no luck.
...
npm WARN optional dep failed, continuing<EMAIL_ADDRESS>npm WARN optional dep failed, continuing<EMAIL_ADDRESS>npm WARN optional dep failed, continuing<EMAIL_ADDRESS>/
><EMAIL_ADDRESS>install /var/www/clients/drawcard.com.au/wp-content/themes/build/node_modules/node-sass
> node scripts/install.js

><EMAIL_ADDRESS>postinstall /var/www/clients/drawcard.com.au/wp-content/themes/build/node_modules/node-sass
> node scripts/build.js

`linux-x64-node-0.10` exists; testing
Binary is fine; exiting
npm ERR! EEXIST, open '/home/vagrant/.npm/78ad85c1-rant-npm-xtend-4-0-0-package-tgz.lock'
File exists: /home/vagrant/.npm/78ad85c1-rant-npm-xtend-4-0-0-package-tgz.lock
Move it away, and try again.

npm ERR! System Linux 3.13.0-45-generic
npm ERR! command "/home/vagrant/.nvm/v0.10.36/bin/node" "/home/vagrant/.nvm/v0.10.36/bin/npm" "install"
npm ERR! cwd /var/www/clients/drawcard.com.au/wp-content/themes/build
npm ERR! node -v v0.10.36
npm ERR! npm -v 1.4.28
npm ERR! path /home/vagrant/.npm/78ad85c1-rant-npm-xtend-4-0-0-package-tgz.lock
npm ERR! code EEXIST
npm ERR! errno 47
npm ERR! not ok code 0

remove your node_modules directory and try again? if not, please post on discourse and we can troubleshoot over there.

Thanks. I had removed that folder and it was still causing problems. I'll use discourse for this kind of stuff from now on :)

After many many hours trying to solve this issue... I just got fed up with npm... I've tried different node versions with different npm versions yet I either get something like
><EMAIL_ADDRESS>postinstall /Users/abdelrazzak/Vagrant/Inventy/frontend/node_modules/gulp-sass/node_modules/node-sass
> node scripts/build.js

`darwin-x64-node-0.10` exists; testing
Binary is fine; exiting
npm ERR! EEXIST, open '/Users/abdelrazzak/.npm/364e3f12-adable-stream-1-0-33-package-tgz.lock'
File exists: /Users/abdelrazzak/.npm/364e3f12-adable-stream-1-0-33-package-tgz.lock
Move it away, and try again.

npm ERR! System Darwin 14.3.0
npm ERR! command "/Users/abdelrazzak/.nvm/v0.10.36/bin/node" "/Users/abdelrazzak/.nvm/v0.10.36/bin/npm" "install"
npm ERR! cwd /Users/abdelrazzak/Vagrant/Inventy/frontend
npm ERR! node -v v0.10.36
npm ERR! npm -v 1.4.28
npm ERR! path /Users/abdelrazzak/.npm/364e3f12-adable-stream-1-0-33-package-tgz.lock
npm ERR! code EEXIST
npm ERR! errno 47

or I get the following log on npm latest version
><EMAIL_ADDRESS>preinstall /Users/abdelrazzak/Vagrant/Inventy/frontend/node_modules/gulp-replace-task/node_modules/applause/node_modules/cson/node_modules/js2coffee
> node ./cyclic.js

npm ERR! Darwin 14.3.0
npm ERR! argv "node" "/Users/abdelrazzak/.nvm/v0.10.36/bin/npm" "install"
npm ERR! node v0.10.36
npm ERR! npm  v2.8.4

npm ERR! Cannot read property 'dependencies' of undefined
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>
npm ERR! Darwin 14.3.0
npm ERR! argv "node" "/Users/abdelrazzak/.nvm/v0.10.36/bin/npm" "install"
npm ERR! node v0.10.36
npm ERR! npm  v2.8.4

npm ERR! Cannot read property 'dependencies' of undefined
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>
npm ERR! Darwin 14.3.0
npm ERR! argv "node" "/Users/abdelrazzak/.nvm/v0.10.36/bin/npm" "install"
npm ERR! node v0.10.36
npm ERR! npm  v2.8.4

npm ERR! Cannot read property 'dependencies' of undefined
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>
npm ERR! Darwin 14.3.0
npm ERR! argv "node" "/Users/abdelrazzak/.nvm/v0.10.36/bin/npm" "install"
npm ERR! node v0.10.36
npm ERR! npm  v2.8.4

and other 20+ same npm error

the npm-debug file is 25000+ lines


What kind of reports do we need from ingest - stakeholder needs for key pieces of info on projects

As a stakeholder I want to be able to access key pieces of information, so that I can compile reports for our own metrics, for funders and outside stakeholders.
There are some key pieces of information we do need to be able to track on a (semi) regular basis for reporting, including

Operational metrics - so how many projects, cells we have ingested over time
How much ingest costs to run without any data (i.e. baseline costs)
How much we expect ingest to cost to wrangle data, in terms of e.g. $/GB, avg $/project, avg $/cell (i.e. projected costs)
How much we observe ingest costing over time (i.e. actual costs)

Given these pieces of information, we also need to be able to monitor the difference between expected costs and actual costs over time, potentially alerting when there is an unexpected discrepancy (i.e. we are spending more than we expect) so we can audit why.
This is linked to ticket 426
** Acceptance Criteria / Definition of Done **

Given [assumption]
When [action]
Then [outcome]

I have created a new ticket, #604, which is more focused on the first bullet point of Operational Metrics. I have added on that one as a stretch goal the cost side of things. But probably we can work that out on this ticket


Determine the filesystem of the file.

Run find on that filesystem, with the -xdev option, and -execdir +
Fixes https://github.com/sous-chefs/selinux_policy/issues/71

Thanks for the PR! I think we should have an attribute to disable this behavior, even if it defaults to true. Wrote it in the review

I can't imagine a situation where you want to disable this behavior.  But I also don't understand this whole codepath.  Using find to locate a file to relabel doesn't seem to make any sense.  If the resource is a file, relabel just the file.  If the resource is a directory, recursively relabel the directory and it's contents.
Personally, I think you should just revert https://github.com/sous-chefs/selinux_policy/pull/67
You fixed a performance issue while introducing a bug.
Do you want it done fast, or do you want to done reliably?  Just put it back to using restorecon, which actually works as designed.

@acranox the main point of using find is catching regex labels, which are very much a thing. These cannot be passed into restorecon. You can get more context by looking at #56. I hope this explains the codepath :smile:
Your comment suggests another idea - use some logic to check if the label is a regex (incomplete solution - check if the escaped version equals the raw version), and if so skip the find and go restorecon. If detecting a regex sounds too fancy, add an attribute instead.
WDYT?

That could make sense.
Maybe selinux_policy_fcontext shouldn't support regex's though?  But that's a design decision.
PR #56 still introduced a bug, IMHO.  It worked faster for daften, but in my case, the relabel runs for 10 minutes and then times out with a failure, or it exits with a failure because it's looking at /proc.  usage of 'find /' needs to be removed.
I can take another crack at improving the PR when I have time, but I'd still suggest you fix the bug.
I still think my PR is safer.  The missing behavior you've asked for would only apply if I was trying to relabel a directory that has different filesystems underneath it, and my regex will match files on multiple filesystems.

Well, selinux_policy_fcontext is going to support regex because SELinux's file contexts support regex and it's a useful feature.
Also people are using this already (e.g. here).
RE the missing behavior, in this PR we're knowingly breaking something. I can imagine someone having that usecase (think someone symlinking a directory in /var/www to something mounted on a different volume), so we shouldn't break their experience without allowing them to revert to the old behavior.

I'd hate to nag, but this still presents some interesting edge-cases, e.g. /tmp/..
The regexed files <> the literal filename. Are you that adversed to using an attribute to control regex/noregex behavior?
@daften want to provide a second opinion here?

Sorry, I've moved places last week, so wasn't really following up on anything.
I'd say having a flag to have regex support is fine IMO. I'd leave the default as using the new behaviour TBH, so with regex enabled.
How do you see it then, a simple if/else with the old and new code in the different cases? (so find | restorecon vs finding the upper dir)

I don't know how to do what you're asking.  You're going to have to fix this one yourself.
Feel free to close this PR.  PR #67 opened a can of worms.  I'm just going to start disabling :relabel in my cookbooks, and start using a manual call to restorecon until this cookbook works more reliably.  Thanks.

PR #67 might have opened a can of worms, but it did solve a particular case. And what I (and I think @BackSlasher) are proposing (not asking) is adapting the resource, so there's an additional attribute (e.g. disable_regex), which is taken into account in the provider. If it's false (the default) the current behaviour is done, if it's true, the old code is used. It's a simple if/else, not really rocket science IMO :)

It solved a particular case of poor performance, but introduced a bug that causes failures.  You turned slow code into unreliable code.
The change you are asking for it not rocket science, but it's beyond what I can do.  I'm not a ruby developer.  I hope someone more experienced can fix this.
I reported the bug, and when no one stepped up to fix it, I submitted a PR like you requested.   Since it's not up to your standards, it's not going to get merged.  Sadly, I think you should have had this level of standards with the last PR that caused this behavior.  You put a call to find / into the code. Traversing the filesystem starting at root was bound to cause issues.  Reading the man page for find to learn about -xdev isn't rocket science either.  :)

Is this still blocked due to changes being requested?
If so, can you restate what's needed?

I'm sorry for not reviewing your latest change @acranox, somehow I missed that.
I doubt your attribute works, but I may be rusty on the syntax.
Could we make your attribute the one decider whether we implement the "default" behavior or your specific one?
Personally, I think we could go with:
if new_resource.ignore_regex
    // Your logic, running restorecon on the filename
    res = shell_out!('restorecon', '-irv', new_resource.file_spec)
else
    // Original logic, doing some fancy stuff
    res_fs = shell_out!('stat', '--format', '%m', new_resource.file_spec).stdout.chomp
    res = shell_out!('find', res_fs, '-xdev', '-regextype', 'posix-egrep', '-regex', new_resource.file_spec, '-execdir', 'restorecon', '-iRv', '{}', '+')
end

After that, we need test cases proving the code works as expected (see test/cookbooks/selinux_policy_test directory).
Also, I'd default the attribute to run the fancy behavior first, just so we don't surprise anyone.
Also, please add your attribute to README.md for future generations to find.
That sounds like it for now, hope it's OK :smile:

Thanks, I appreciate the help, but I'm in over my head already on this.
I think I'm better off removing this cookbook from my environment, or  pinning to an older version that doesn't have this problem.  I hope you can take some piece of my attempts and incorporate them into a future release.

I'm sorry to hear that. Leave that PR open, I'll try to get around to
adding some stuff.
The thing I'm missing is how to test the non-regex code, but it might come
to me.
Anyway, thanks for pointing this out!
Nitzan Raz
http://backslasher.net
On Wed, Jul 12, 2017 at 5:22 PM, Peter Doherty<EMAIL_ADDRESS>wrote:

Thanks, I appreciate the help, but I'm in over my head already on this.
I think I'm better off removing this cookbook from my environment, or
pinning to an older version that doesn't have this problem. I hope you can
take some piece of my attempts and incorporate them into a future release.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sous-chefs/selinux_policy/pull/72#issuecomment-314784621,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG3He4dWyDum5gQiMzUKebeOOQUU0b44ks5sNNaLgaJpZM4NuT83
.

I'd be willing to take over here, however your testing methodology is slightly different than what I've used in the past. Based on the diff and your existing tests, I would just be adding a resource (two resources?) to test/cookbooks/selinux_policy_test/recipes/fcontext.rb, verifying behavior when the target is on a "remote" filesystem - is that correct?

@zachsmorgan that sounds about right. Note that we also have more "normal" tests using chefspec, but the primitive kitchen testing is bigger here, because I'm a primitive person (even more so when starting this)

Unga Bunga :)

I ran into yet another problem with using find in its current form, which is that too many files causes it to run out of file descriptors.
find / -regextype posix-egrep -regex "/srv/git/gitlab/public(/.*)?" -execdir restorecon -iRv {} \;
find: Failed to save working directory in order to run a command on ‘information_desk_person_tone5-2fde4e98dd11c5c29c89cad7cbb7bd2d5077dfad07913b20e01955b2d0dfad40.png’: Too many open files

Simply changing this to -execdir {} + is sufficient but I think I can make this much faster whilst also addressing the above concerns.
I also had the idea of checking the regular expression but in a smarter way. I would compare the regexp with the escaped form but not just to see if they were different. I would find the directory name of the common prefix between the two. In the above example, the common prefix is /srv/git/gitlab/public and the directory name is /srv/git/gitlab. This would help for all cases at least two levels deep such as /foo/bar(/.*)?. As well as fixing the /proc issue, this makes my own test 7x faster.
Concerned that this might not avoid the /proc issue entirely, I checked the find man page and found -ignore_readdir_race, which I think does exactly what we need.

Normally, find will emit an error message when it fails to stat a file. If you give this option and a file is deleted between the time find reads the name of the file from the directory and the  time  it tries to stat the file, no error message will be issued.

I hadn't noticed this option before so I wondered whether it was new but actually it dates back to 2004 so we don't need to worry about it being missing.
This can be faster still. Appending -prune to the find conditions means that, having matched the earlier conditions, it won't bother traversing a directory if it finds one. We're already telling restorecon to operate recursively so what's the point of checking and passing every file within that directory if we know the directory itself is going to be passed anyway? If the regexp only matches specific files rather than directories then it still works because -prune does not cull files and restorecon -R works on files too. For me, this speeds things up another 3x.
So a 21x speed up, how about it? :grin: I'll get a PR ready...

Hi everyone!
What's the current status of this PR?

Well my comment above got two hoorays so I filed #77 and nothing happened. Travis failed, which was mostly not related to my change, and I explained the other failure.

Time to checking again with this one!
#77 has now been closed and merged. What else can we do to get this merged and shipped?

I think you can close this now, #77 dealt with it all.

Awesome, thanks!


Implement MySQL Support

The application I'm currently working with needed MySQL support, I wanted to use enums. Hopefully this will be useful to someone else.
Includes tests and adjustments to Travis to have them run.

Cool, I was wondering if it would work for MySQL!


Allow Governance Deposit to be paid with staked Osmo

Currently the deposit for a governance proposal is 2,500 Osmo. With current return rates for staking and LPs being above 1% per day, this deposit has an opportunity cost in the range of $40 per day.
Allowing the deposit to be in the form of staked Osmo would remove this opportunity cost while still acting as a spam mitigation measure.
I will try to dig into the code a bit to see how feasible this change is.

Great idea!
I think this can be done without too much overhead if we enforce either that deposit period + voting time <= unbonding time, or that you can't unbond staked osmo put for deposit.
Once whatever conditions required to satisfy those are enforced, then the governance logic can avoid not moving the staked assets into its own module account. Instead it can just track how many the relevant address has 'promised' for the deposit. That way the deposited amount can still be getting staking yields. Then if a deposit is burned, it does a reward withdraw, and then burns the right amount for the depositing address.

I think my preference is "can't unbond staked OSMO for deposit"
And I also strongly support this idea

We should move this issue to the Cosmos SDK, and continue discussion on it there


support double tap hotkey like double command

I am sorry, I don't understand what double command means. Please elaborate.

I am sorry, I don't understand what double command means. Please elaborate.

fast tap cmd key twice


Added release notes for OpenSearch <IP_ADDRESS>.

Signed-off-by: Thomas Hurney<EMAIL_ADDRESS>Issue #, if available:
N/A
Description of changes:
Added release notes for OpenSearch-Alerting <IP_ADDRESS>. These release notes include notes from OpenSearch-Alerting <IP_ADDRESS>-rc1.
CheckList:
[x] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@d6371ff). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage        ?   80.46%
  Complexity      ?      214
=======================================
  Files           ?      154
  Lines           ?     5856
  Branches        ?      706
=======================================
  Hits            ?     4712
  Misses          ?      766
  Partials        ?      378

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6371ff...7a1652a. Read the comment docs.


Make PKCE optional for external auth providers

coverage: 93.945% (-0.01%) from 93.957%
when pulling 6270cc2facacc6bb596eac672025c67e39c5d8dd on cody-idp-pkce-optional
into b606e6280448d2441d0df104d889fe47353f64dc on main.


Adapt leafCallToSubfieldFilter to Spark

Description
Gluten implemented some logic to convert call expr as subfield filter. To avoid duplication, we would like to use the existing 'leafCallToSubfieldFilter' logic in Velox. One incompatibility we found is current implementation is matching against Presto function names, while Spark function names could be different. The other one is 'isnotnull' is frequently used in Spark and it is not currently supported. These are the drafted changes we would like to propose: https://github.com/rui-mo/velox/commit/73409033e5760a5c664c57adc282095910f257f6.

Yeah leafCallToSubfieldFilter is Presto specific (similar to Tokenizer).  Mixing in Spark names probably is not a good way to do it.  A related question is how do we parse this expression in ExprCompiler, do we have a isnotnull function in sparksql?

One way to fix it is to have
class ExprToSubfieldFilterParser {
  std::unique_ptr<common::Filter> leafCallToSubfieldFilter(
    const core::CallTypedExpr&,
    common::Subfield&,
    core::ExpressionEvaluator*,
    bool negated = false);
};

And have this stored as shared_ptr inside ExecCtx, or another context object with query scope.

Yes we can use a global factory for now until someone wants to have multiple engines in the same process (unlikely in short term).


SPM build fails with "revisioned dependencies" error

Looks like we have the same issue with https://github.com/jpsim/SourceKitten/issues/478 when imported as a dependency.
$ swift package update
depgen $ swift package update
Updating https://github.com/krzysztofzablocki/Sourcery
Updating https://github.com/toshi0383/CoreCLI
error: the package PackageReference(identity: "sourcery", name: nil, path: "https://github.com/krzysztofzablocki/Sourcery", isLocal: false) @ 0.13.1 contains revisioned dependencies:
    PackageReference(identity: "swifttrycatch", name: nil, path: "https://github.com/seanparsons/SwiftTryCatch.git", isLocal: false) @ e7074a72e4d4dc516f391bc4d4afd8ca6a845b4b

Package.swift
// swift-tools-version:4.0
// Managed by ice

import PackageDescription

let package = Package(
    name: "depgen",
    dependencies: [
        .package(url: "https://github.com/toshi0383/CoreCLI", from: "0.1.0"),
        .package(url: "https://github.com/krzysztofzablocki/Sourcery", from: "0.13.1"),
    ],
    targets: [
        .target(name: "depgen", dependencies: ["CoreCLI", "SourceryRuntime"]),
    ]
)

Should not happen anymore with 0.15.0 release. Please reopen if its still an issue

I'm having this problem too, when trying to swift run from my own codebase where sourcery is embedded as a dependency:
error: the package sourcery[https://github.com/krzysztofzablocki/Sourcery] @ 0.16.0 contains incompatible dependencies:
    swifttrycatch[https://github.com/seanparsons/SwiftTryCatch.git] @ 6a177252cfa2ef649b0aa7b2d16ab221386ca51c

Can this be re-opened and addressed?

This should be resolved. Closing.


boundary="periodic"?

I keep finding it funny that xgcm has both periodic and boundary kwargs. Logically it seems like periodic should be replaced by boundary="periodic"?

This makes sense to me.

That’s a great idea, that would simplify the setup.

Hi, I'm taking a peek at this. There are lots of tests which configure the grid with both periodic, and boundary options like fill and extend. As I understand, this change should mean you can't e.g. make an axis periodic and fill at the same time. Are there any issues expected with changing this? I ask because there I think there are lots of tests this impacts.
Actually, I can see a commented-out case which would assert boundary=fill not being used together with periodic: https://github.com/xgcm/xgcm/blob/2b28b56eebfca67dbf79530db75b48e385eb6bd3/xgcm/test/test_grid.py#L576-L580


Use periods for require calls

For strings passed to the require function, any occurrence of period characters (.) is replaced by the first character of package.config which aligns with the default directory separator for the platform.
This fixes issues when running the tests on a host that isn't Windows.

Incorporated into #11.


Add output_preamble to match existing output_postamble

ViewComponent::Base defines an output_postamble for additional content that will be appended to the rendered string, but currently there is no matching hook for prepended content.
Motivation
First is just providing a consistent interface/not falling afoul of the principle of least surprise.  But beyond that, I have a use-case where I'd like to wrap every view component in a specific HTML tag (with data-controller and class attributes set based on the filename, so sidecar stimulus controllers/css modules from view_component-contrib can be applied automatically).  With the current state of the codebase I can add the closing tag, but there's no way that I can see to inject the opening tag.
It looks like a fairly minor change, and I'd be happy to submit a PR if there's interest, but I wanted to see if there's any context I'm missing first.

Hey @kdonovan, this seems like a good idea. How do you feel about submitting a PR?

I went ahead and added a small PR for this. CI is failing... the changes are simple and it looks like it's failing for everyone else, too, but tbh I never got the bundle exec appraisal install step to work so I haven't been able to verify the tests still pass locally. 😬

It looks like these test failures are legitimate. I left a comment on the PR.
As far as running tests locally, I would recommend getting bundle and bundle exec rake test working first, then trying to use Appraisal.

@kdonovan I recently started adding a few things, and also had to get setup, if you need  help you can ping me in the PR

Thanks folks -- just using bundle + bundle exec rake test got me unblocked!  I'm still not quite understanding why the PR was getting FrozenErrors trying to concat the string (maybe something to do with the compilation step?), but I just pushed up a different approach (joining an array) that at least passes tests locally.


Edit message source

I can edit a message, and I can view a message's source, but I can't edit a message's source.
Is it possible to add this feature to the webmail?
Thx.

We are using the Roundcube webmail, you can ask for such a feature here: https://github.com/roundcube/roundcubemail

thx.


Switches in dark mode (off state) is not correct color

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
Off state switch thumb circle should be white.
Reduced test cases
https://modus-bootstrap.trimble.com/docs/v2/forms/checks-radios/#switches

What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Microsoft Edge
What version of Modus Bootstrap are you using?
v2.0.1

Fixed with #32


Locally building application

I'm trying to get this up and running in my local environment but have been unable to do so. Here's my step-by-step with debugging:
➜  react-querybuilder git:(master) npm --version
3.8.9
➜  react-querybuilder git:(master) npm install
npm WARN deprecated<EMAIL_ADDRESS>Use preset options to disable module transformation https://github.com/gajus/babel-preset-es2015-webpack#deprecated
npm WARN deprecated<EMAIL_ADDRESS>This package is deprecated. Use Object.assign.
npm WARN deprecated<EMAIL_ADDRESS>to-iso-string has been deprecated, use @segment/to-iso-string instead.
npm WARN deprecated<EMAIL_ADDRESS>Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN prefer global<EMAIL_ADDRESS>should be installed with -g

...

<EMAIL_ADDRESS>...ommitted install tree...

npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| 0.14.x || ^15.0.0-0 but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
➜  react-querybuilder git:(master) npm start

><EMAIL_ADDRESS>start /Users/user/Dev/react-querybuilder
> webpack-dev-server --env dev

/Users/user/Dev/react-querybuilder/node_modules/webpack/lib/webpack.js:16
		throw new WebpackOptionsValidationError(webpackOptionsValidationErrors);
		^
WebpackOptionsValidationError: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
 - configuration[0].resolve.extensions[0] should not be empty.
 - configuration[1].output.library should be one of these:
   string | [string]
   If set, export the bundle as library. `output.library` is the name.
 - configuration[1].resolve.extensions[0] should not be empty.
    at webpack (/Users/user/Dev/react-querybuilder/node_modules/webpack/lib/webpack.js:16:9)
    at processOptions (/Users/user/Dev/react-querybuilder/node_modules/webpack-dev-server/bin/webpack-dev-server.js:269:17)
    at Object.<anonymous> (/Users/user/Dev/react-querybuilder/node_modules/webpack-dev-server/bin/webpack-dev-server.js:297:1)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:456:32)
    at tryModuleLoad (module.js:415:12)

npm ERR! Darwin 15.5.0
npm ERR! argv "/usr/local/Cellar/node/6.1.0/bin/node" "/usr/local/bin/npm" "start"
npm ERR! node v6.1.0
npm ERR! npm  v3.8.9
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: `webpack-dev-server --env dev`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'webpack-dev-server --env dev'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the react-querybuilder package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     webpack-dev-server --env dev
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs react-querybuilder
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls react-querybuilder
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/user/Dev/react-querybuilder/npm-debug.log

So I proceed by trying to comment out just the lines in webpack.config.js to read:
'use strict';

module.exports = env=> {
    return [
        require('./config/webpack-dev.config'),
        //require('./config/webpack-prod.config')
    ];
};

Also modified the config/webpack-common.config.js to remove the empty '' element:
...
resolve: {
        extensions: ['.js', '.jsx', '.scss']
    },
...

Running npm start again, I get a new error:
➜  react-querybuilder git:(master) npm start

><EMAIL_ADDRESS>start /Users/user/Dev/react-querybuilder
> webpack-dev-server --env dev

 http://localhost:8080/
webpack result is served from /
content is served from /Users/user/Dev/react-querybuilder
404s will fallback to /index.html
/Users/user/Dev/react-querybuilder/node_modules/webpack/lib/Chunk.js:34
    throw new Error("Chunk.entry was removed. Use hasRuntime()");
    ^

Error: Chunk.entry was removed. Use hasRuntime()
    at Chunk.Object.defineProperty.get (/Users/user/Dev/react-querybuilder/node_modules/webpack/lib/Chunk.js:34:9)
    at /Users/user/Dev/react-querybuilder/node_modules/extract-text-webpack-plugin/index.js:201:13
    at Array.filter (native)
    at Compilation.<anonymous> (/Users/user/Dev/react-querybuilder/node_modules/extract-text-webpack-plugin/index.js:200:37)
    at Compilation.applyPlugins (/Users/user/Dev/react-querybuilder/node_modules/tapable/lib/Tapable.js:25:14)
    at Compilation.seal (/Users/user/Dev/react-querybuilder/node_modules/webpack/lib/Compilation.js:542:7)
    at Compiler.<anonymous> (/Users/user/Dev/react-querybuilder/node_modules/webpack/lib/Compiler.js:468:16)

Reading online, seems there is a problem with the extract-text-webpack-plugin, see https://github.com/webpack/webpack/issues/2764 so I tried the suggestion of using the versions of webpack and extract-text-webpack-plugin but yet another new error appears:
➜  react-querybuilder git:(master) ✗ npm install
<EMAIL_ADDRESS>/Users/user/Dev/react-querybuilder
├──<EMAIL_ADDRESS>├── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>├── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  ├─┬<EMAIL_ADDRESS>  │ ├──<EMAIL_ADDRESS>  │ └─┬<EMAIL_ADDRESS>  │   └──<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    ├──<EMAIL_ADDRESS>    └──<EMAIL_ADDRESS>
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| 0.14.x || ^15.0.0-0 but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
➜  react-querybuilder git:(master) ✗ npm start

><EMAIL_ADDRESS>start /Users/user/Dev/react-querybuilder
> webpack-dev-server --env dev

 http://localhost:8080/
webpack result is served from /
content is served from /Users/user/Dev/react-querybuilder
404s will fallback to /index.html
Child
    chunk    {0} demo.bundle.js, demo.bundle.js.map (demo) 233 kB [entry] [rendered]

    ERROR in ./demo/main.js
    Module build failed: Error: Cannot remove "babel-plugin-transform-es2015-modules-commonjs" from the plugin list.
        at Object.<anonymous> (/Users/user/Dev/react-querybuilder/node_modules/babel-preset-es2015-webpack/index.js:35:11)
        at Module._compile (module.js:541:32)
        at Object.Module._extensions..js (module.js:550:10)
        at Module.load (module.js:456:32)
        at tryModuleLoad (module.js:415:12)
        at Function.Module._load (module.js:407:3)
        at Module.require (module.js:466:17)
        at require (internal/module.js:20:19)
        at /Users/user/Dev/react-querybuilder/node_modules/babel-core/lib/transformation/file/options/option-manager.js:284:15
        at Array.map (native)
        at OptionManager.resolvePresets (/Users/user/Dev/react-querybuilder/node_modules/babel-core/lib/transformation/file/options/option-manager.js:265:20)
        at OptionManager.mergePresets (/Users/user/Dev/react-querybuilder/node_modules/babel-core/lib/transformation/file/options/option-manager.js:254:10)
        at OptionManager.mergeOptions (/Users/user/Dev/react-querybuilder/node_modules/babel-core/lib/transformation/file/options/option-manager.js:239:14)
        at OptionManager.init (/Users/user/Dev/react-querybuilder/node_modules/babel-core/lib/transformation/file/options/option-manager.js:338:12)
        at File.initOptions (/Users/user/Dev/react-querybuilder/node_modules/babel-core/lib/transformation/file/index.js:216:65)
        at new File (/Users/user/Dev/react-querybuilder/node_modules/babel-core/lib/transformation/file/index.js:137:24)
     @ multi demo
    Child html-webpack-plugin for "index.html":
        chunk    {0} index.html 536 kB [entry] [rendered]
webpack: bundle is now VALID.

I was unable to find a solution to this. Is there something I am missing in order to be able to run this locally? Would help in order for me to start making a PR. Thanks.

I was able to figure out the Cannot remove "babel-plugin-transform-es2015-modules-commonjs" from the plugin list by changing the .babelrc file to read like:
"presets": [
        "es2015",
        "react"
    ],

After installing the peerDependencies manually (react and react-dom) I was able to get this up and running locally.


[OAuthCard] TokenExchangeResource property is missing JsonProperty attribute name

Describe the bug
When a .NET skill bot sends an OAuthCard to a JS host bot, the card is not deserialized properly because the TokenExchangeResource property is received in uppercase.
The property is missing the JsonProperty name that the other properties have.
Expected behavior
All OAuthCard properties should be in lowercase.
Screenshots
This image shows the OAuthCard as an activity's attachment with the TokenExchangeResource with uppercase.

@swagatmishra2007 @Jeffders @carlosscastro can you comment? thanks

@ceciliaavila thanks for find (and fixing) this, can you be specific about what is broken here, as we'd like to understand the impact and whether we need to include it in R13.
Are the following statements true?

if I have a C# parent bot using a C# skill then everything is fine
if I have a C# parent bot using a JS skill then everything is also fine
if I have a JS parent with a JS skill then everything is fine
if I have a JS parent with a C# skill then this is an issue

@ceciliaavila thanks for find (and fixing) this, can you be specific about what is broken here, as we'd like to understand the impact and whether we need to include it in R13.
Are the following statements true?

if I have a C# parent bot using a C# skill then everything is fine
if I have a C# parent bot using a JS skill then everything is also fine
if I have a JS parent with a JS skill then everything is fine
if I have a JS parent with a C# skill then this is an issue

Hi @johnataylor, those statements are true, we have the issue only when the parent is a JS bot and the skill is a C# bot.
In the SSO scenario, when the parent intercepts the OAuth card sent by the skill to exchange the token, it breaks due to a property in uppercase.


Fix aarch64 compatibility issues

Hi, @ellttBen !
Thank you so much for this work!
I'm able to compile this project on Apple M1, but some tests failing when I run cargo test-bpf:
running 10 tests
test state::market_state::market_cast ... ok
test utils::tests::test_round_price ... ok
test test_id ... ok
test state::critbit::tests::simulate_find_min ... FAILED
test state::critbit::tests::simulate_operations ... FAILED
test state::event_queue::tests::test_event_queue_0 ... ok
test state::orderbook::tests::test_ob_booting_ask ... FAILED
test state::orderbook::tests::test_ob_0 ... FAILED
test state::orderbook::tests::test_ob_small_prices ... FAILED
test state::orderbook::tests::test_ob_booting_bid ... FAILED

failures:

---- state::critbit::tests::simulate_find_min stdout ----
thread 'state::critbit::tests::simulate_find_min' panicked at 'cast_slice_mut>TargetAlignmentGreaterAndInputNotAligned', /Users/donbeave/.cargo/registry/src/github.com-1ecc6299db9ec823/bytemuck-1.11.0/src/internal.rs:30:3
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- state::critbit::tests::simulate_operations stdout ----
thread 'state::critbit::tests::simulate_operations' panicked at 'cast_slice_mut>TargetAlignmentGreaterAndInputNotAligned', /Users/donbeave/.cargo/registry/src/github.com-1ecc6299db9ec823/bytemuck-1.11.0/src/internal.rs:30:3

---- state::orderbook::tests::test_ob_booting_ask stdout ----
thread 'state::orderbook::tests::test_ob_booting_ask' panicked at 'cast_slice_mut>TargetAlignmentGreaterAndInputNotAligned', /Users/donbeave/.cargo/registry/src/github.com-1ecc6299db9ec823/bytemuck-1.11.0/src/internal.rs:30:3

---- state::orderbook::tests::test_ob_0 stdout ----
thread 'state::orderbook::tests::test_ob_0' panicked at 'cast_slice_mut>TargetAlignmentGreaterAndInputNotAligned', /Users/donbeave/.cargo/registry/src/github.com-1ecc6299db9ec823/bytemuck-1.11.0/src/internal.rs:30:3

---- state::orderbook::tests::test_ob_small_prices stdout ----
thread 'state::orderbook::tests::test_ob_small_prices' panicked at 'cast_slice_mut>TargetAlignmentGreaterAndInputNotAligned', /Users/donbeave/.cargo/registry/src/github.com-1ecc6299db9ec823/bytemuck-1.11.0/src/internal.rs:30:3

---- state::orderbook::tests::test_ob_booting_bid stdout ----
thread 'state::orderbook::tests::test_ob_booting_bid' panicked at 'cast_slice_mut>TargetAlignmentGreaterAndInputNotAligned', /Users/donbeave/.cargo/registry/src/github.com-1ecc6299db9ec823/bytemuck-1.11.0/src/internal.rs:30:3

failures:
    state::critbit::tests::simulate_find_min
    state::critbit::tests::simulate_operations
    state::orderbook::tests::test_ob_0
    state::orderbook::tests::test_ob_booting_ask
    state::orderbook::tests::test_ob_booting_bid
    state::orderbook::tests::test_ob_small_prices

test result: FAILED. 4 passed; 6 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

error: test failed, to rerun pass '--lib'


Remove maximum torch version for python3.11 compatibility

Thanks for this PR.
Some API is changed in a higher version of PyTorch, which may raise the error:
forward() got an unexpected keyword argument 'is_causal' in Transformer.
I really appreciate it if you could further fix this issue.


Call to K8S version API for the EKS cluster in ap-northeast-2 (seoul) is failing with unauthorized code 401.

We are calling the K8S API to get version of the cluster. The URL is https://:443/version .
But the HTTP request is failing with this error - GET request to the remote host failed [HTTP-Code: 401]: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"Unauthorized","reason":"Unauthorized","code":401}
This call is working in other AWS regions for ex us-east-2(ohio), us-east-1, ap-south-1 etc. But specifically failing in this region.
I have checked IAM console this region is enables for STS service
While calling the K8S API we are passing STS token (with standard AWS signature calculation).

So I am not getting why it is failing in only a specific region?

Hi @sp-rackware, this repository is related to EKS Anywhere the open source distribution of EKS Distro that runs on on-premises hardware. It looks like your question is about AWS EKS in the cloud. You may want to open a support question in that case. Also, take a look at your Configmap, make sure the IAM user has permissions https://docs.aws.amazon.com/eks/latest/userguide/add-user-role.html

Thanks @raykrueger. @sp-rackware, please do reach out to EKS proper for help with this!


[Modal] - Fix HTML for Basic Modal Example

Steps to Reproduce

Create basic modal dialog (the same code from basic modal example)
Execute javascript to show the dialog

Expected
The dialog should look the same as modal on semantic ui examples page. Text should be centered, and action buttons right aligned.
Result
Modal have left aligned text (header and content) and action buttons stretching the whole width of the dialog.
Testcase
Using semantic ui 2.1.4:
http://jsfiddle.net/8zjzytcu/

The example code in docs is incorrect. The demo is using ui icon header

Fixed with Semantic-Org/Semantic-UI-Docs#247.


Custom color of input underline

Please can you add custom color of input underline animation to css?
Default is blue... i need orange :yum:

Documentation and Sass variables added.

Is there a way to do it programatically ?

Bro its not working

Not sure why, but this works for me:
.input-field textarea[class=materialize-textarea]:focus {
border-bottom: 1px solid #2196f3;
box-shadow: 0 1px 0 0 #2196f3;
}

i customized the border color  by (lang=pug):
input[type=text]
  &:focus:not([readonly])
    border-bottom: 1px solid ＃0C8CF6
    box-shadow: 0 1px 0 0 ＃0C8CF6

Theres a guide how to target the input elements. How about the textarea? How do I change it?

Is there any update on this ?

you can change underline color by changing CSS of on focus event.
On Mon, May 15, 2017 at 1:08 PM, Vince Tripodi<EMAIL_ADDRESS>wrote:

Is there any update on this ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Dogfalo/materialize/issues/192#issuecomment-301399325,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQKplbDd_2wQK1h4RL2zFcqAleo5FU1cks5r6ADagaJpZM4DEs6_
.

I have done this, except the existing border applied from the mdl is present with the border style I apply

in: theme/variables.css add this code:
$text-input-md-highlight-color-invalid: transparent;
$text-input-md-highlight-color-valid: transparent;
$text-input-md-show-invalid-highlight: transparent;
$text-input-md-highlight-color: transparent;
$text-input-md-show-valid-highlight: transparent;
but select a color!

try this. its work for me fine:
.input-field input:focus + label {
color: red !important;
}
.row .input-field input:focus {
border-bottom: 1px solid red !important;
box-shadow: 0 1px 0 0 red !important
}


SAM template changes, parameter store in DAG, simplified setup

Creating Rekognition collection via custom resource
Lambda function and DynamoDB table names in DAG via Parameter Store
Simplified pre-deploy using setup.sh
Dynamic MWAA environment name to facilitate deploying multiple stacks in the same account

Running setup.sh in us-west-2 cause the following issue
An error occurred (IllegalLocationConstraintException) when calling the CreateBucket operation: The unspecified location constraint is incompatible for the region specific endpoint this request was sent to.
use   aws s3api create-bucket --bucket $S3_BUCKET --create-bucket-configuration LocationConstraint=region
Creates a collection ID by name "image_processing". If a different name is given in the parameter, the template only use it for providing IAM permissions thus breaking the access to collection.

Fixed template.yaml to use RekognitionCollectionId param to dynamically set collection_id in Lambda function.


Bugfix/jstassi/#364 g5 modules perl wrapper

Updated g5_modules_perl_wrapper to remove loadmodules option when calling g5_modules, since the option is no longer valid after an update to g5_modules.

@gmao-jstassi a few things.
First, there is a conflict here. I think I can fix it on the CLI if you are fine with that.
Second, this repo requires Changelog entries on non-trivial PRs. Can you add one that encompasses all that is happening here (which seems a lot).
Third, please add a 0 diff or  non 0-diff label so we know what to expect when testing.

Matt,
Let me withdraw my pull request. I only made a few minor changes to one file, but I branched off from whatever I got when I grabbed Ricardo’s tag. Probably my changes should go back to Ricardo rather than to main. Can I send him a pull request, or does he have to handle it manually?
Sorry, I am still trying to figure out the complexities of git.
Thanks.
Joe
From: Matt Thompson @.>
Reply-To: GEOS-ESM/GMAO_Shared @.>
Date: Tuesday, December 24, 2024 at 8:30 AM
To: GEOS-ESM/GMAO_Shared @.>
Cc: Joe Stassi @.>, Mention @.***>
Subject: [EXTERNAL] [BULK] Re: [GEOS-ESM/GMAO_Shared] Bugfix/jstassi/#364 g5 modules perl wrapper (PR #365)
CAUTION: This email originated from outside of NASA.  Please take care when clicking links or opening attachments.  Use the "Report Message" button to report suspicious messages to the NASA SOC.
@gmao-jstassihttps://github.com/gmao-jstassi a few things.
First, there is a conflict here. I think I can fix it on the CLI if you are fine with that.
Second, this repo requires Changelog entries on non-trivial PRs. Can you add one that encompasses all that is happening here (which seems a lot).
Third, please add a 0 diff or non 0-diff label so we know what to expect when testing.
—
Reply to this email directly, view it on GitHubhttps://github.com/GEOS-ESM/GMAO_Shared/pull/365#issuecomment-2561133173, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMBAJ2UNQJVCKRLAM27CKQT2HFOW7AVCNFSM6AAAAABUDZK6CSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRRGEZTGMJXGM.
You are receiving this because you were mentioned.Message ID: @.***>

We looked and it looks like feature/rtodling/milan was the parent branch of this branch. It does seem like the tag g5.41.3 was based on this branch too:
2024-12-23 18:13 -0500 Joe Stassi        o [bugfix/jstassi/#364-g5_modules_perl_wrapper] {origin/bugfix/jstassi/#364-g5_modules_perl_wrapper} update g5_mod
2024-10-29 12:49 -0400 Ricardo Todling   o <g5.41.3> these started giving trouble after a number of cycles - something is going on that I do not fully unde
2024-10-14 10:35 -0400 Ricardo Todling   o [feature/rtodling/milan] {origin/feature/rtodling/milan} <g5.41.2> now live in GMAO_mksi
...


requireSpaceBetweenArguments doesn't work in constructor of es6.

I have set requireSpaceBetweenArguments in .jscsrc file,
"requireSpaceBetweenArguments": true,

This is a test code,
"use strict";
class A {
    constructor(a,b) {
        console.log(a,b);
    }
}

jscs can only find line4 is invalid, shows "Missing space between , and b", but line3 is also invalid.

This rule applicable only for call expressions, see - http://jscs.info/rule/requireSpaceBetweenArguments since those are not arguments those are parameters.
You want validateParameterSeparator

Hm, but apparently validateParameterSeparator doesn't notice class methods :/

Thanks ：）


Include information about third party tools

Other tools (like Babel) are available and can solve problems devs have with the react-tools transform. I wanted to make devs aware of them, and one way to do this is via the wiki. If such a list should instead be included into the site, that's fine for me as well.

:+1:

booya


Cannot compile with make

process_begin: CreateProcess(NULL, g++ -std=c++20 -pthread -Iinclude/ -Iexternal/ -MM include/bruteforce-enigma.h, ...) failed.
process_begin: CreateProcess(NULL, g++ -std=c++20 -pthread -Iinclude/ -Iexternal/ -MM include/bruteforce-enigma.h, ...) failed.
File not found - TESTS/
File not found - -NAME
process_begin: CreateProcess(NULL, g++ -std=c++20 -pthread -Iinclude/ -Iexternal/ -MM include/bruteforce-enigma.h, ...) failed.
process_begin: CreateProcess(NULL, g++ -std=c++20 -pthread -Iinclude/ -Iexternal/ -MM include/bruteforce-enigma.h, ...) failed.
process_begin: CreateProcess(NULL, g++ -std=c++20 -pthread -Iinclude/ -Iexternal/ -MM include/bruteforce-enigma.h, ...) failed.
process_begin: CreateProcess(NULL, g++ -std=c++20 -pthread -Iinclude/ -Iexternal/ -MM include/bruteforce-enigma.h, ...) failed.
'printf' is not recognized as an internal or external command,
operable program or batch file.
make: *** [crack_enigma] Error 1

Sorry for taking so long to get back to you. It looks like you might be trying to run the makefile on Windows? If that's the case, you might need to run the makefile from a Windows Subsystem for Linux environment, like the bash shell that comes with it. Since WSL is now a robust feature of Windows and easy to use, I have not bothered to make compiling this program Windows-friendly.
I haven't kept up to speed with the status of WSL, so I don't know if it comes preinstalled nowadays. I found these two pages for you if it needs to be installed first.
https://learn.microsoft.com/en-us/windows/wsl/install
https://learn.microsoft.com/en-us/windows/wsl/about
I'm willing to help in any way you need if you have other questions or problems.


Modal won't close when you click outside if modal-dialog is inside

Description
Modal won't close if you click outside to the left & right of the modal. It will however if you click above and below it.
Test Case
https://codepen.io/luckyruby/pen/xaxBNV
Tested on Mac OS 10.13.6 on Safari 11.1.2, Firefox 61.0.2, and Chrome 68.0.3440.106.

Why don't just add the form inside the .modal-content?

yes it works after adding  tag inside div.modal-content

Sorry, I inserted the script incorrectly. closed issue,
problem : in ajaxSetup error handle I define again shown.on.modal, just remove it done my problem,
thank you.

@MartijnCuppens Yea, that's ultimately what I did to get it working. It seems odd that the form placement would mess up the modal in that way. I don't recall seeing the issue in v3.

@luckyruby, You did something that you weren't supposed to be doing (placing a form as a child of the .modal), it worked in v3, but due some refactoring in v4 this now gives some issues.
Modals in v4 use pointer-events which allows you to click trough elements, if you place an element like a form in the .modal, you click on the form and not on the modal itself (where a eventListener is attached to to close the modal). Another option was to add pointer-events: none; to the form, but I wouldn't recommend that because Bootstrap 4 always assumes that .modal-dialog is a child of the .modal and this might cause some troubles in the future.

Your modal content should be in .modal-content as explained by @MartijnCuppens

@MartijnCuppens Appreciate the explanation. Thanks!


Reorder dependency flink-table-runtime in pom.xml to avoid dependency conflict.

Fix #2753 .

@PatrickRen @leonardBang Could you look at the changes? Many thanks :)

Hi @HappyHacker123, could you please rebase this PR with latest master branch and trigger the CI? Thanks for your contribution!

Hi @HappyHacker123, could you please rebase this PR with latest master branch and trigger the CI? Thanks for your contribution!

Sure, I rebase it the latest branch :).


Comparative operation for Boolean

Since the Comparative Operation like '==' is handled separately for each data type under its corresponding datatypes operation - Bool is not handled
print(True==True)
print(True==False)

It makes more sense to have the comparison function as data type agnostic and not handle the comparison in different functions.


mapStateToProps not always called after upgrading to 5.0.1

I have a boolean value inside a reducer and the mapStateToProps is not always called when the value changes.
Here's the log from 4.4.6:
[mapStateToProps] showResults false
[reducer] previous value: false ; new value: true
[mapStateToProps] showResults true
[reducer] previous value: true ; new value: false
[mapStateToProps] showResults false

But here's the one from 5.0.1:
[mapStateToProps] showResults false
[reducer] previous value: false ; new value: true
[mapStateToProps] showResults true
[reducer] previous value: true ; new value: false
[reducer] previous value: false ; new value: false

I wonder if this is related to an "app" within another app and maybe the relations between the stores are wrong since the upgrade?

Can you post a sample project that demonstrates this issue?  Your second comment makes it sound like your setup is more complicated than "just" a store and some components.

I can try to create a new project.
But basically it's something like this:
<Provider store={store}>
  <MainApp />
</Provider>

With MainApp being:

Something

  <OtherApp />

OtherApp:
<Provider store={otherStore}>
  <MiniApp />
</Provider>

Ah... hold on.  So you're using two different <Provider> instances, with the second nested inside the first?  Are you updating the first store, but expecting a component inside the second <Provider> to respond to that update?  Because if so, I really don't think that's a supported or expected scenario.

The inner Provider is shadowing the store context property, but not storeSubscription, so the connected components inside the inner Provider are incorrectly subscribing to store changes from the outer Provider's store. Easy enough to fix by changing Provider to also shadow storeSubscription, but it does beg the question "How much support does react-redux offer for multiple stores?"

Are you updating the first store, but expecting a component inside the second  to respond to that update?

Nop. Everything inside the "mini app" is self contained. So something inside send an action and update its own reducer. I only expect the mini app to be updated. The "parent app" has nothing to do with that.
I'm making another small project to reflect the issue. Stay tuned.
@jimbolla Maybe it's not the usual use case, but I'm having the issue because my "mini app" can live as a standalone application, but also embedded inside another app.

See this project: https://github.com/tleunen/react-redux-pr582

@jimbolla : I'd say that if we can fix it without much hassle, then we might as well go ahead and do so.  Sounds like it's "just" a matter of adding a couple more entries to context, right?

Yep. Just submitted PR #584 to fix this use case.


Add fallback in try_key_ref to fetch the keymgmt from the provider of the store

The try_key_ref function tries to transform data from the store into the EVP_PKEY. It first looks up a keymgmt that can handle the data type returned from the store given by the OSSL_OBJECT_PARAM_DATA_TYPE param. It then depends on the order of providers - first one that can handle the data type is selected. It is not necessarily the one that actually provided the data. When this is the case the function tries to export the key from the provider that actually provided it and import it into the selected provider. This will fail if the private key cannot be exported.
https://github.com/openssl/openssl/blob/144316d276adf5b8172316f7bc20b372b8e31ac8/crypto/store/store_result.c#L186-L239
A fallback in the try_key_ref needs to be added to try to fetch the keymgmt from the provider of the store if the key is unexportable.

Please try #17554

I tried the changes from the PR but they don't work. Not because an issue with the PR itself but because is doesn't kick in at all.
The scenario is as follows:

I want to sign a CMS (openssl cms -sign -signer myprov:cert=1234)
OpenSSL fetches the signer's certificate from my provider's store.
OpenSSL fetches signer's private key from my provider's store (store's expectation is OSSL_STORE_INFO_PKEY).
I return private key from the provider by reference (OSSL_OBJECT_PARAM_REFERENCE).
try_key_ref looks for keymgmt that can interpret the key's data type (OSSL_OBJECT_PARAM_DATA_TYPE).
The default provider is found first and my provider is then asked to export everything about the key (OSSL_KEYMGMT_SELECT_ALL).
My provider exports everything but the private key (since it's not exportable).
try_key_ref is happy because it has EVP_PKEY from the default provider. The fallback implemented in the PR does not kick in since a PKEY has been created. It contains only the public part though.
Store queries the created EVP_PKEY and enqueues the OSSL_STORE_INFO_PUBKEY, not the expected OSSL_STORE_INFO_PKEY.
Boom! Store expectation is not met, private key loading fails.

Maybe my export is bad (point 7). My understanding of OSSL_KEYMGMT_SELECT_ALL was give me all you CAN. But maybe is should be interpreted rather as you MUST give me all I'm asking for. But this interpretation would be IMHO bad for future extension. Should I fail if I can't provide private key? Should I also fail if I can't provide OSSL_KEYMGMT_SELECT_OTHER_PARAMETERS? What is it anyway? The documentation says that these flags should be (not must be) considered, so I think my interpretation of NOT providing the private key AND NOT failing the export is correct.
I think the idea of choosing ANY provider that can interpret the key data (point 5) and completely ignoring the reference at that point is flawed. When a key is returned by a reference then it is the provider that issued the reference and that provider only can interpret it.

Your export is bad. You should fail the export if OSSL_KEYMGMT_SELECT_ALL is set, the key has a private key data and you're unable to export it. If there are no other parameters with the key type then you can ignore that selection bit. The same for domain parameters - if a key such as an RSA key does not have any domain parameters. Maybe the manual page should be clarified. Feel free to suggest better wording for it as a PR.
However you have a good point in that last paragraph that maybe the order of the tried key managements should be inverted. @levitte what is your opinion? It seems to me, this is a little bit different situation than with the operation fallbacks because here  is no point in trying to export the key to a different provider prematurely.

OK, so I modified my export as told and this time the fallback kicks in and the EVP_PKEY is constructed from my provider. So far so good (although the export is first tried unnecessarily).
I believe in this case loading public keys from the store might be broken. When the store's expectation is set to OSSL_STORE_INFO_PUBKEY and we get there, then the export is only tried with OSSL_KEYMGMT_SELECT_ALL. So although the provider could export the public key, it has to fail since it is instructed to export the complete keypair.
I also see asymmetry in export and import semantics. The export is told to fail for unexportable private keys when OSSL_KEYMGMT_SELECT_PRIVATE_KEY is present and on the other hand the import is OK when OSSL_KEYMGMT_SELECT_PRIVATE_KEY is present but the imported data does not contain private key data.
There's one more thing that needs clarification. In my previous description I was not accurate when describing the export (point 6):

The default provider is found first and my provider is then asked to export everything about the key (OSSL_KEYMGMT_SELECT_ALL).

It's not the provider's keymgmt that is asked to export, it is actually the provider's store to do the export (store's store_export_object function). And there is no selection bitmask specified, it is me who delegates the export object call to provider's keymgmt export function with OSSL_KEYMGMT_SELECT_ALL selection. Is this correct? Should store's expectation be consulted eventually?
But back to my initial problem with CMS signing. Once the private key is now successfully loaded from my provider it is then passed to CMS_add1_signer. That in turn calls X509_check_private_key. Now we are in evp_keymgmt_util_match and since my provider does not implement the match function the attempt to export key from my provider and import it into the default provider is made (#17487 must be applied). The export is tried with OSSL_KEYMGMT_SELECT_PRIVATE_KEY and it now obviously fails. For matching signer's certificate with a private key public keys should be sufficient (and it worked before I modified my export).

I think it would actually make sense to consult the expectation in this case.

It might be. But what to do in case the expectation is not set (either because it really has not been set or it could not be set because multiple different types are expected)? Probably export as much as I can?


adding lr_decay_steps and refactoring get_scheduler

This PR adds a lr_decay_steps config option which will linearly decay learning rate to 0 at the end of training. This PR simplifies the get_scheduler function by removing constantwithwarmup, linearwarmupdecay, and cosineannealingwarmup options. Instead, any scheduler can now have a linear warmup and linear decay by setting the lr_warm_up_steps and lr_decay_steps.
This also required changing some of the options passed to get_scheduler. This function now takes in lr as well, since there's a discrepancy with how torch's cosine annealing scheduler works compared to how the other schedulers. Specifically, it seems that torch's cosine annealing actually sets the final LR to the value specified by eta_min, but the other schedulers don't know what the current learning rate is and instead can only set the LR to a portion of its original value. In order to address this discrepancy, we need to know the LR so we can calculate what the expected end LR should be as a portion of the base LR. This also has a nice side-effect of meaning that the lr_end value is the actual final LR, instead of a portion of the original LR which felt unexpected.
closes #61

Looks great! thanks!


make tiflash compatible with old version client

Signed-off-by: xufei<EMAIL_ADDRESS>What problem does this PR solve?
Issue Number: ref #6696
Problem Summary:
#6633 delete is_flowrows in BlockInfo, which makes the new tiflash server not compatible with old tiflash client
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/check-issue-triage-complete

/merge

/run-unit-test

/run-integration-test

/run-integration-test

/run-integration-test


Spike: Removal of an Corda organization node from a existing network

Description
As a developer I want to add a feature to remove a Corda Organization node from an existing corda network deployed using BAF
Acceptance Criteria

Go through official Corda documentation to understand the steps required for the feature
Manually test removal of node
Create further stories for automation of the same using BAF

I would like to take it up


Added modern node versions to travis ci

Thanks! I meant to add this in on my last update, and completely forgot.


Selection and deselection of token groups

Describe the issue:
users can only select and deselect all token groups in inspect

Proposed solution:
Each token group has the checkbox option of selecting and deselecting

Can you move the checkbox in front of the title? the we should be good to go. Also provide a indeterminate state as in only some items are selected.

Closing as migrated to Featurebase

Changing status to Not Close as it's only migrated


Android: temp fix loop restarts

After https://github.com/coronalabs/corona/commit/aa4140d029f2ca29326dd2503fe3a421cd2b757c, the copied resource.car was overlap with live build baseDir, cause app keep restarts.
This is minimum change to fix app restarts after 3705, it is simple but also not affect the performance before 3705, which resource.car would not have been created and being ignored is just “redundant”.
See:

https://forums.solar2d.com/t/live-build-the-issue-with-cycle-synchronization-in-android-app/356752
https://github.com/coronalabs/corona/issues/689

Hi, @Shchvova. Thanks for the merge, I look forward to the release or interim version as a download link for users. Are there any plan? Thanks.

I think it's fixed, thanks!

I think it's fixed, thanks!


Author - Comment on posts

As an author, I want to comment on posts that I can access

Backend finished with #65


flyetcl version should ignore talking to admin if host is not configures

Signed-off-by: Kevin Su<EMAIL_ADDRESS>TL;DR

Ignore talking to the admin if the host is not configured
Do not prompt users to install new flytectl if the current version is the same as the latest version

 A new release of flytectl is available: v0.5.21 → v0.5.21

{
  "App": "flytectl",
  "Build": "fc7b1dd",
  "Version": "v0.5.21",
  "BuildTime": "2022-04-27 16:25:14.783715 +0800 CST m=+0.018003092"

Type

[x] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[ ] Code completed
[ ] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/flyteorg/flyte/issues/2256
Follow-up issue
NA

This doesn't solve the issue here
https://github.com/flyteorg/flyte/issues/2256
As it will still print those auth error messages .
What we need is to avoid talking to admin completely if the host is not configured in all paths while running version command.
You might want to take a look at the command context creation where this is being done and this is coming from imported IDL code and hence we might want to fix this issue there

@pmahindrakar-oss Thanks, I just updated it, so now we will not initialize admin clients if the host is None.


Add manpages for SSL_get_certificate, SSL_get_privatekey

This is as I understand these functions from reading the code.

How's this?

Updated again.

Updated.

Updated.

The CI failure is relevant. Please fix.

Updated.

@paulidale still OK?

This pull request is ready to merge

Merged to 3.0 and master branches. Thank you.


Random shuffle always gives the same result

I'm trying to shuffle a deck of cards in my code at setup time:
const game = Game({
  setup() => {
    const G = {
      deck: Random.Shuffle(Array(52).fill().map((_, idx) => idx)),
    };
    return G;
  }
});

But when I look at the resultant array in the debug view, I keep getting the same result on every page refresh and even after yarn server restart. I want to avoid setting up my own seed.
Am I missing something?

No, you don't miss anything. The problem is that for setup, the PRNGState is not set, so undefined is being used as seed.

@Stefan-Hanke does that mean if I do call Random.Shuffle inside a phase instead of setup it will do the real thing?
I can initialize my deck as an empty array in setup, and then the first phase can shuffle the deck inside onPhaseBegin, and endPhaseIf deck length is greater than 0. Would that work or will that have the same problem?

Looks like onPhaseBegin does get a random seed in ctx, but the shuffle output is always the same across reloads no matter the seed value.
See https://codepen.io/viranch/pen/EQqQdb

This runs into the same problem: The call to setup and the calls to startPhase/startTurn happen before the initial call to PRNGState.set(). Unfortunately the PR is wrong - it should read PRNGState.set({seed: game.seed}). However, this now breaks more than one test...
This behaviour is only when using Random inside setup and the first phase/turn. In all other cases, the Random stuff should work as expected, because there are proper calls to PRNGState in place. See here.

Is there a way I can call PRNGState.set() inside setup or onPhaseBegin for it to work?

PRNGState is not exported, so currently don't use Random in setup or the first turn/first phase.

How do I pull this fix into my project?

You'll have to wait for a release, or clone this repo and use the code directly.

This is now released in v0.20.1.

Thanks for the heads up! Can confirm this issue fixed in v0.20.1.

https://github.com/google/boardgame.io/commit/89694336d119a2c8f09c14b6b2aabe48b13bc1c1 was another fix related to this that will be in the next release.


Feature Addition: check Member Of Profile

This Review is for addition of the feature that involved the checking of the Member of the Profile.
Fixes #5

Please comment under the issue and only pick it up ones you've been assigned to issue. This PR will not be considered since its a redundant PR. Feel free to pick up another issue by commenting and work on it ones assigned.
Here's where most of the communication is done : https://t.me/starknetindia


Error: Building package realsense2:x64-linux failed with: BUILD_FAILED

Host Environment
OS: Ubuntu 16.04
Compiler: gcc 5.5.0

I'm trying to install the realsense software following these steps (https://github.com/IntelRealSense/librealsense). When I run ./vcpkg install realsense2 this error appears:
Computing installation plan...
The following packages will be built and installed:
    realsense2[core]:x64-linux
Starting package 1/1: realsense2:x64-linux
Building package realsense2[core]:x64-linux...
-- Using cached /home/eva-isr/vcpkg/downloads/IntelRealSense-librealsense-025fccf76803ee6a6e60de9f18ac6193b7ff8597.tar.gz
-- Using source at /home/eva-isr/vcpkg/buildtrees/realsense2/src/93b7ff8597-4347a45ee5
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:136 (message):
    Command failed: /home/eva-isr/vcpkg/downloads/tools/cmake-3.17.2-linux/cmake-3.17.2-Linux-x86_64/bin/cmake --build . --config Debug --target install -- -v
    Working Directory: /home/eva-isr/vcpkg/buildtrees/realsense2/x64-linux-dbg
    See logs for more information:
      /home/eva-isr/vcpkg/buildtrees/realsense2/install-x64-linux-dbg-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_cmake.cmake:91 (vcpkg_execute_build_process)
  scripts/cmake/vcpkg_install_cmake.cmake:24 (vcpkg_build_cmake)
  ports/realsense2/portfile.cmake:47 (vcpkg_install_cmake)
  scripts/ports.cmake:90 (include)

Error: Building package realsense2:x64-linux failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: realsense2:x64-linux
  Vcpkg version: 2020.02.04-unknownhash

Additionally, attach any relevant sections from the log files above.

realsense2 build failed on Linux with the following error, now libusb build failed on Linux, and it will be fixed in PR #9561. Waiting for PR #9561 merged, I will continue fix realsense2:x64-linux build error.
vcpkg/buildtrees/realsense2/x64-linux-dbg/third-party/libusb/libusb/core.c:23:10: fatal error: config.h: No such file or directory
vcpkg/buildtrees/realsense2/x64-linux-dbg/third-party/libusb/libusb/hotplug.c:22:10: fatal error: config.h: No such file or directory
vcpkg/buildtrees/realsense2/x64-linux-dbg/third-party/libusb/libusb/descriptor.c:22:10: fatal error: config.h: No such file or directory

Repeated on my machine
./vcpkg install realsense2
Computing installation plan...
The following packages will be built and installed:
    realsense2[core]:x64-linux
Starting package 1/1: realsense2:x64-linux
Building package realsense2[core]:x64-linux...
-- Downloading https://github.com/IntelRealSense/librealsense/archive/025fccf76803ee6a6e60de9f18ac6193b7ff8597.tar.gz...
-- Extracting source /home/etv/vcpkg/downloads/IntelRealSense-librealsense-025fccf76803ee6a6e60de9f18ac6193b7ff8597.tar.gz
-- Applying patch fix_openni2.patch
-- Applying patch fix-dependency-glfw3.patch
-- Using source at /home/etv/vcpkg/buildtrees/realsense2/src/93b7ff8597-4347a45ee5
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:136 (message):
    Command failed: /home/etv/vcpkg/downloads/tools/cmake-3.17.2-linux/cmake-3.17.2-Linux-x86_64/bin/cmake --build . --config Debug --target install -- -v
    Working Directory: /home/etv/vcpkg/buildtrees/realsense2/x64-linux-dbg
    See logs for more information:
      /home/etv/vcpkg/buildtrees/realsense2/install-x64-linux-dbg-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_cmake.cmake:91 (vcpkg_execute_build_process)
  scripts/cmake/vcpkg_install_cmake.cmake:24 (vcpkg_build_cmake)
  ports/realsense2/portfile.cmake:47 (vcpkg_install_cmake)
  scripts/ports.cmake:73 (include)

Error: Building package realsense2:x64-linux failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: realsense2:x64-linux
  Vcpkg version: 2020.02.04-unknownhash

Additionally, attach any relevant sections from the log files above.

Repeated on Ubuntu 18.04 with a newer Vcpkg version. Any update on this?
Computing installation plan...
The following packages will be built and installed:
    realsense2[core]:x64-linux
Detecting compiler hash for triplet x64-linux...
Starting package 1/1: realsense2:x64-linux
Building package realsense2[core]:x64-linux...
Could not locate cached archive: /home/jvdhooft/.cache/vcpkg/archives/ec/ecb61cb4bdd659a5f003454dd50e0357f6bb52ec.zip
-- Using cached /home/jvdhooft/vcpkg/downloads/IntelRealSense-librealsense-025fccf76803ee6a6e60de9f18ac6193b7ff8597.tar.gz
-- Cleaning sources at /home/jvdhooft/vcpkg/buildtrees/realsense2/src/93b7ff8597-4347a45ee5.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /home/jvdhooft/vcpkg/downloads/IntelRealSense-librealsense-025fccf76803ee6a6e60de9f18ac6193b7ff8597.tar.gz
-- Applying patch fix_openni2.patch
-- Applying patch fix-dependency-glfw3.patch
-- Using source at /home/jvdhooft/vcpkg/buildtrees/realsense2/src/93b7ff8597-4347a45ee5.clean
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:139 (message):
    Command failed: /home/jvdhooft/vcpkg/downloads/tools/cmake-3.17.2-linux/cmake-3.17.2-Linux-x86_64/bin/cmake --build . --config Debug --target install -- -v
    Working Directory: /home/jvdhooft/vcpkg/buildtrees/realsense2/x64-linux-dbg
    See logs for more information:
      /home/jvdhooft/vcpkg/buildtrees/realsense2/install-x64-linux-dbg-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_cmake.cmake:91 (vcpkg_execute_build_process)
  scripts/cmake/vcpkg_install_cmake.cmake:24 (vcpkg_build_cmake)
  ports/realsense2/portfile.cmake:47 (vcpkg_install_cmake)
  scripts/ports.cmake:79 (include)

Error: Building package realsense2:x64-linux failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: realsense2:x64-linux
  Vcpkg version: 2020.06.15-unknownhash

Additionally, attach any relevant sections from the log files above.

Very same problem on CentOS Linux release 7.8.2003 (Core).
PR #9561 seems merged. @LilyWangL any news about this issue? Maybe even a workaround waiting for the fix? Thanks.

Thanks for your reply. I will confirm this issue soon.

hello I have a same issue, Any furthre imporvement on this problem?
robolabjackal1@robolabjackal1:~/libraries/vcpkg$ ./vcpkg install realsense2
Computing installation plan...
A suitable version of cmake was not found (required v3.22.2). Downloading portable cmake v3.22.2...
Downloading cmake...
  https://github.com/Kitware/CMake/releases/download/v3.22.2/cmake-3.22.2-linux-x86_64.tar.gz -> /home/robolabjackal1/libraries/vcpkg/downloads/cmake-3.22.2linux-x86_64.tar.gz
Extracting cmake...
The following packages will be built and installed:
  * libusb[core]:x64-linux -> 1.0.24#7
    realsense2[core]:x64-linux -> 2.50.0
  * vcpkg-cmake[core]:x64-linux -> 2022-01-19
  * vcpkg-cmake-config[core]:x64-linux -> 2022-02-06
Additional packages (*) will be modified to complete this operation.
Detecting compiler hash for triplet x64-linux...
A suitable version of ninja was not found (required v1.10.2). Downloading portable ninja v1.10.2...
Downloading ninja...
  https://github.com/ninja-build/ninja/releases/download/v1.10.2/ninja-linux.zip -> /home/robolabjackal1/libraries/vcpkg/downloads/ninja-linux-1.10.2.zip
Extracting ninja...
Restored 3 packages from /home/robolabjackal1/.cache/vcpkg/archives in 9.244 ms. Use --debug to see more details.
Starting package 1/4: libusb:x64-linux
Installing package libusb[core]:x64-linux...
Elapsed time for package libusb:x64-linux: 1.178 ms
Starting package 2/4: vcpkg-cmake:x64-linux
Installing package vcpkg-cmake[core]:x64-linux...
Elapsed time for package vcpkg-cmake:x64-linux: 1.51 ms
Starting package 3/4: vcpkg-cmake-config:x64-linux
Installing package vcpkg-cmake-config[core]:x64-linux...
Elapsed time for package vcpkg-cmake-config:x64-linux: 332.5 us
Starting package 4/4: realsense2:x64-linux
Building package realsense2[core]:x64-linux...
-- Downloading https://github.com/IntelRealSense/librealsense/archive/v2.50.0.tar.gz -> IntelRealSense-librealsense-v2.50.0.tar.gz...
-- Extracting source /home/robolabjackal1/libraries/vcpkg/downloads/IntelRealSense-librealsense-v2.50.0.tar.gz
-- Applying patch fix_openni2.patch
-- Applying patch fix_config_osx.patch
-- Using source at /home/robolabjackal1/libraries/vcpkg/buildtrees/realsense2/src/v2.50.0-ec78fddb81.clean
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
-- Building x64-linux-rel
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:158 (message):
    Command failed: /home/robolabjackal1/libraries/vcpkg/downloads/tools/cmake-3.22.2-linux/cmake-3.22.2-linux-x86_64/bin/cmake --build . --config Release --target install -- -v -j13
    Working Directory: /home/robolabjackal1/libraries/vcpkg/buildtrees/realsense2/x64-linux-rel
    See logs for more information:
      /home/robolabjackal1/libraries/vcpkg/buildtrees/realsense2/install-x64-linux-rel-out.log

Call Stack (most recent call first):
  installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_build.cmake:111 (vcpkg_execute_build_process)
  installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_install.cmake:41 (vcpkg_cmake_build)
  ports/realsense2/portfile.cmake:47 (vcpkg_cmake_install)
  scripts/ports.cmake:145 (include)

Error: Building package realsense2:x64-linux failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `git pull` and `./vcpkg update`.
Then check for known issues at:
  https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+realsense2
You can submit a new issue at:
  https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[realsense2]+Build+error
including:
  package: realsense2[core]:x64-linux -> 2.50.0
    vcpkg-tool version: 2022-03-09-1affd32f93b299d5a907816c328ca3ededb73a7e
    vcpkg-scripts version: 440075a9f 2022-03-23 (11 hours ago)

Additionally, attach any relevant sections from the log files above.

I have same issues. Anyone have solutions ? Many thanks


Has anyone noticed this problem? Cannot import name sparse_lsqr from sklearn.utils.fixes

Reproduce

env

scikit-learn              1.1.1            py38h6a678d5_0
scikit-learn-intelex      2021.5.0         py38h06a4308_0

python -m sklearnex.glob patch_sklearn

Log
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ImportError: cannot import name 'sparse_lsqr' from 'sklearn.utils.fixes' (/hidden-path/python3.8/site-packages/sklearn/utils/fixes.py)

Explanation
As Luke369 say

Latest scikit-learn which works is 1.0.2, so I had to downgrade it

Question
Should I downgrade it?
Reference
scikit-learn-intelex - githublab

Hi @FavorMylikes this is bug is already reported. Please see #1007