Dll mission fix

When mission is finished with dl lost condition and dl lost failsafe off, RTL should only be activated when in air.
Significant changes in
https://github.com/PX4/Firmware/commit/2c68e48c0f2d84db2867598d7cff9f59f4ab4743
https://github.com/PX4/Firmware/pull/5230/commits/684f6695eb79adfd2203007ede62e21c8f16c625
rest is code style

@julianoes Can you review & merge?

@sanderux Sorry can you break that down for me. What was the (wrong) behaviour before and what is the new behaviour?

@julianoes
The following scenario was attempted:

No RC RX attached

Datalink lost failsafe disabled

RC mode to 'no rc'

RC failsafe disabled

Connect GCS through wireless telemetry

Switch to mission mode

Arm

Failsafe kicked in while switching to mission mode, this is because of https://github.com/PX4/Firmware/issues/5229
Uppon further investigation of the behavior in the state_helper under the condition of RC_Lost and Datalink lost while both failsafes for that were disabled, i came to the conclusion that the approach was wrong. The idea behind this failsafe is when a mission ends with no active links (RC or DL), even if the DL failsafe was switched off it should RTL. But the way it was implemented was wrong;
it only checked the rc link and the mission_finished condition, it did not check the datalink. So even if that link was active it would still failsafe.
Additionally (also to bypass the bug above) i added the landed condition to the failsafe, RTL would normally never initiate when landed but it does give errors that should not be there.

Ok, the change looks correct from my understanding.

We might tag along a fix for https://github.com/PX4/Firmware/issues/5229 after some testing tonight

bench tested, works as expected
@julianoes i think this can go in

Rebased and applied.


Add sourceOnly option

This is used to essentially mark a list as immutable via dragging. It can only be used to copy items to other lists. The items cannot be rearranged or dragged out of the list.

@lolmaus I just added a demo, and went to look at adding tests, but I am not familiar with the page object setup. I am somewhat surprised that adding the demo in the middle of the lists did not break other tests. Would you be able to help me write some tests please?

@lolmaus any guidance for writing tests would be great!

@rwwagner90 I've created a follow-up PR: https://github.com/rwwagner90/ember-drag-sort/pull/6

@lolmaus thanks so much for the help! I just merged your PR, so I think we should be good to go here?

@lolmaus could we get this merged and a new beta out please? 😃

@lolmaus any chance we could get this merged and get a new beta out?

@rwwagner90 Sorry for the delay, I'm on vacation. I'll try to have a look!

Released in 2.0.0-beta.2, thx @rwwagner90 and sorry for the delay!


Alarms not cleared on Server change

Not critical but the Alarms don't get cleared when you change the API URL. Some reset missing somewhere.

Fixed in 9f4bca5fc1109171b049e32d2dc8844341acbe32 :)


Invalid SessionHandle Error

I am applying a SQLDatabaseChain Chatbot model by using LangChain SQLDatabaseChain and GPT4. I first created this model on Databricks notebook like this :
import json
import os
import langchain
import mlflow
from mlflow.models import infer_signature
from langchain.chains import LLMChain
from langchain_community.utilities import SQLDatabase
from langchain_openai import ChatOpenAI
from langchain_experimental.sql import SQLDatabaseChain

api_key = os.getenv("OPENAI_API_KEY", "openai_api_key")
llm = ChatOpenAI(temperature=0, openai_api_key=api_key, model_name='gpt-4-0125-preview')

def get_db(_=None):
    db = SQLDatabase.from_databricks(catalog="catalog", schema="default", host="databricks_workspace_url", api_token="databricks_access_token", cluster_id="cluster_id", sample_rows_in_table_info=3)
    return db

db = get_db()

def get_chain():
    db = get_db()
    chain = SQLDatabaseChain.from_llm(llm=llm, db=db, verbose=True)
    return chain

chain = get_chain()

import mlflow
import langchain
import langchain_community
from langchain_community.chat_models import ChatOpenAI
import langchain_openai
import langchain_experimental
import langchain_core
import openai
import databricks
from databricks import sql

mlflow.set_registry_uri("databricks-uc")
model_name = f"SQL_chain"

with mlflow.start_run(run_name="sql_chain_test") as run:
    user_query = "..."
    answer = chain.invoke(user_query)
    answer_json = json.dumps(answer)
    signature = infer_signature(user_query, answer_json)
    model_info = mlflow.langchain.log_model(
        chain,
        loader_fn=get_db,
        artifact_path="chain",
        registered_model_name=model_name,
        pip_requirements=[
            f"mlflow=={mlflow.__version__}",
            f"langchain=={langchain.__version__}",
            f"langchain_community=={langchain_community.__version__}",
            f"langchain_experimental=={langchain_experimental.__version__}",
            f"openai=={openai.__version__}",
            f"langchain_core=={langchain_core.__version__}",
            f"databricks",
            f"databricks-sql-connector==2.9.3",
            ],
        input_example=user_query,
        signature=signature
    )

With this code, I deploy this model on MLflow, and then I create a serving endpoint with Unity catalog model.
And after, I create a frontend application by using streamlit.
After creating this serving endpoint for 15 minutes, as long as I send a new question to the chatbot, I will recieve a Invalid SessionHandle error :
{"error_code": "BAD_REQUEST", "message": "1 tasks failed. Errors: {0: 'error: DatabaseError(\\'(databricks.sql.exc.DatabaseError) Invalid SessionHandle: SessionHandle [ee17e137-26ea-4677-a7c3-69e81be048bc]\\') Traceback (most recent call last):\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/sqlalchemy/engine/base.py\", line 1910, in _execute_context\\n    self.dialect.do_execute(\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/sqlalchemy/engine/default.py\", line 736, in do_execute\\n    cursor.execute(statement, parameters)\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/databricks/sql/client.py\", line 503, in execute\\n    execute_response = self.thrift_backend.execute_command(\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/databricks/sql/thrift_backend.py\", line 843, in execute_command\\n    resp = self.make_request(self._client.ExecuteStatement, req)\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/databricks/sql/thrift_backend.py\", line 479, in make_request\\n    ThriftBackend._check_response_for_error(response)\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/databricks/sql/thrift_backend.py\", line 259, in _check_response_for_error\\n    raise DatabaseError(response.status.errorMessage)\\ndatabricks.sql.exc.DatabaseError: Invalid SessionHandle: SessionHandle [ee17e137-26ea-4677-a7c3-69e81be048bc]\\n\\nThe above exception was the direct cause of the following exception:\\n\\nTraceback (most recent call last):\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/mlflow/langchain/api_request_parallel_processor.py\", line 319, in call_api\\n    response = self.single_call_api(callback_handlers)\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/mlflow/langchain/api_request_parallel_processor.py\", line 293, in single_call_api\\n    response = self.lc_model(\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/langchain_core/_api/deprecation.py\", line 148, in warning_emitting_wrapper\\n    return wrapped(*args, **kwargs)\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/langchain/chains/base.py\", line 383, in __call__\\n    return self.invoke(\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/langchain/chains/base.py\", line 166, in invoke\\n    raise e\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/langchain/chains/base.py\", line 156, in invoke\\n    self._call(inputs, run_manager=run_manager)\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/langchain_experimental/sql/base.py\", line 119, in _call\\n    table_info = self.database.get_table_info(table_names=table_names_to_use)\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/langchain_community/utilities/sql_database.py\", line 352, in get_table_info\\n    table_info += f\"\\\\n{self._get_sample_rows(table)}\\\\n\"\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/langchain_community/utilities/sql_database.py\", line 375, in _get_sample_rows\\n    sample_rows_result = connection.execute(command)  # type: ignore\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/sqlalchemy/engine/base.py\", line 1385, in execute\\n    return meth(self, multiparams, params, _EMPTY_EXECUTION_OPTS)\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/sqlalchemy/sql/elements.py\", line 334, in _execute_on_connection\\n    return connection._execute_clauseelement(\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/sqlalchemy/engine/base.py\", line 1577, in _execute_clauseelement\\n    ret = self._execute_context(\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/sqlalchemy/engine/base.py\", line 1953, in _execute_context\\n    self._handle_dbapi_exception(\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/sqlalchemy/engine/base.py\", line 2134, in _handle_dbapi_exception\\n    util.raise_(\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/sqlalchemy/util/compat.py\", line 211, in raise_\\n    raise exception\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/sqlalchemy/engine/base.py\", line 1910, in _execute_context\\n    self.dialect.do_execute(\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/sqlalchemy/engine/default.py\", line 736, in do_execute\\n    cursor.execute(statement, parameters)\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/databricks/sql/client.py\", line 503, in execute\\n    execute_response = self.thrift_backend.execute_command(\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/databricks/sql/thrift_backend.py\", line 843, in execute_command\\n    resp = self.make_request(self._client.ExecuteStatement, req)\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/databricks/sql/thrift_backend.py\", line 479, in make_request\\n    ThriftBackend._check_response_for_error(response)\\n  File \"/opt/conda/envs/mlflow-env/lib/python3.10/site-packages/databricks/sql/thrift_backend.py\", line 259, in _check_response_for_error\\n    raise DatabaseError(response.status.errorMessage)\\nsqlalchemy.exc.DatabaseError: (databricks.sql.exc.DatabaseError) Invalid SessionHandle: SessionHandle [ee17e137-26ea-4677-a7c3-69e81be048bc]\\
The informations of my cluster :
14.2 (includes Apache Spark 3.5.0, Scala 2.12)
I think it's because the session created is expired, but I don't konw how to make a new one without re-creating a serving endpoint.
The goal of this chatbot is anytime when we launch, we can use directly. But with the risk of session timeout, I can't make this chatbot work normally.
I didn't find any solutions which can help with my issue. Can anyone help ?

Keep in mind that sessions in Databricks are not like sessions in a typical database. With postgres, mysql or similar, sessions are cheap and long-lived. On Databricks, a session actually reserves compute resources and incurs some cost. So for cost-savings measures, sessions are expired after some period of time. This timeout is very long for serverless warehouses and is configurable on non-serverless clusters.
If you find an InvalidSessionHandle your best bet is to catch this, open a new session, and re-execute the query. Since creating a new session is generally a quick operation (around 100ms) it should not have a significant affect on your application performance.
The alternative is to periodically run a simple query with the session to keep it open. But keep in mind that doing this will continue to incur a cost compared to the scenario where the cluster auto-closes sessions.


fix parameter cached beetwen elaborations

Attempt at solving #181

coverage: 95.065% (+0.004%) from 95.061% when pulling 7eb579f31d34bf41a946f672294d93d8076f49e2 on Risto97:main into 42d877d458ed54ef6f3164b7b9d0791f2e386ca1 on SystemRDL:main.

This looks like it should work, but I want to take a closer look to see if there's a more correct place to fix this.
I suspect it might be better to suppress copying the cached value in Parameter._copy_for_inst() in parameter.py

Yep. Turns out clearing the parameter cache in Parameter._copy_for_inst() works as well, and is a more appropriate place to handle this.
Rejecting this PR, but thank you nonetheless for looking into this!


Build HTML and publish to Github pages

It would be nice to extend the Makefile to support building the spec as HTML and publish the result via Github Pages.

feel free!

This would be really nice to have! I'm not entierly sure what else needs to be done besides archiving the HTML, but I can see https://github.com/peaceiris/actions-gh-pages which should fix the deployment problem.

Ok I got this to work on my fork. For some reason it deployed here: https://blog.timhutt.co.uk/riscv-cheri/
Hopefully it will deploy somewhere more sensible in this repo! I'll send a PR.

Seems to be deployed at https://riscv.github.io/riscv-cheri/ now :)


[NuGet.org Bug]: Some problems with README Markdown rendering

Impact
It bothers me. A fix would be nice
Describe the bug
I've uploaded a README file together with my NuGet package (https://www.nuget.org/packages/PandocFilters/) and the rendered Markdown is a little less than ideal:

Language codes for code blocks are ignored; no syntax highlighting.
There is no whitespace between cells in the rendered table.
No support for superscript (<sup>...</sup>).

Repro Steps
Upload a README file for a NuGet package containing misrendered Markdown.
Expected Behavior
Syntax highlighting for code blocks should render properly.
There should be some whitespace between table cells.
A limited set of HTML elements should be supported, sup in my case.
Screenshots
No response
Additional Context and logs
No response

Hello @zspitz, thanks for taking the time to report this. We have some tracking issues already filed for the problems you are describing. https://github.com/NuGet/NuGetGallery/issues/8837
Specifically:

table rendering: https://github.com/NuGet/NuGetGallery/issues/8503
syntax highlighting: https://github.com/NuGet/NuGetGallery/issues/8632
limited HTML: https://github.com/NuGet/NuGetGallery/issues/8644

Could you upvote these issues so that we can prioritize them accordingly?
Thanks!


Invalid schema for function 'get_current_weather': None is not of type 'object'

Describe the bug
When calling  CreateChatCompletion with function call getting error 400.
ChatCompletion error: error, status code: 400, message: Invalid schema for function 'get_current_weather': None is not of type 'object'
Expected behavior
Expected behaviorwas to return the function call definition
Screenshots/Logs

Environment (please complete the following information):

go-openai version: [e.g. v1.12.0]
Go version: [e.g. 1.18]
OpenAI API version: [e.g. v1]
OS: [e.g. Ubuntu 20.04]

Duplicate #429

Fixed https://github.com/sashabaranov/go-openai/pull/434


(feature) Add fish shell completions

Adds completions for fish shell, via cobra

LGTM, thanks for your contribution @mtatheonly ! :)


Remove mailjet exception from versions updates.

Cedric updated the java-docs-samples mailjet sample to the latest version of the client library in https://github.com/GoogleCloudPlatform/java-docs-samples/pull/384. We should be able to track the latest release again.
@lesv ptal

Current coverage is 100% (diff: 100%)

Merging #43 into master will not change coverage

@@           master   #43   diff @@
===================================
  Files           1     1
  Lines           5     5
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
  Hits            5     5
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update d8c931f...1c10a56


gRPC failed in selfbuild version

Is this a bug or a feature request?
Bug
What did you expect?

Show the gateway information normally
What happened?
It starts with compiling problem ProtoPackageIsVersion3
I've read and follow these two discussion to make it compile but the gRPC seems broke due to packages dependency problem.
https://forum.loraserver.io/t/complling-lora-app-server-source-with-docker-gives-proto-protopackageisversion3-error/3147
https://github.com/golang/protobuf/issues/763
What version are your using?
Fresh installed Ubuntu 18.04 and docker-compose 1.23.2, docker 18.09.1.
How can your issue be reproduced?
Install Ubuntu 18.04, docker-compose 1.23.2, docker 18.09.1 and git clone this repository
Then follow https://www.loraserver.io/lora-app-server/community/source/
First you will face ProtoPackageIsVersion3 when "make build"
Then you "git checkout v1.2.0" the golang/protobuf/protoc-gen-go & "go install"
"make clean", "make api", "make build" it will finished the compile.
But when you using the web ui will found out it's gRPC failed in some items.
Could you share your log output?
time="2019-01-24T12:21:43Z" level=info msg="finished unary call with code OK" grpc.code=OK grpc.method=List grpc.service=api.GatewayService grpc.start_time="2019-01-24T12:21:43Z" grpc.time_ms=266.357 peer.address="<IP_ADDRESS>:36771" span.kind=server system=grpc
time="2019-01-24T12:21:43Z" level=info msg="finished unary call with code OK" grpc.code=OK grpc.method=List grpc.service=api.OrganizationService grpc.start_time="2019-01-24T12:21:43Z" grpc.time_ms=505.406 peer.address="<IP_ADDRESS>:36773" span.kind=server system=grpc
time="2019-01-24T12:21:43Z" level=info msg="finished unary call with code OK" grpc.code=OK grpc.method=List grpc.service=api.OrganizationService grpc.start_time="2019-01-24T12:21:43Z" grpc.time_ms=263.054 peer.address="<IP_ADDRESS>:36773" span.kind=server system=grpc
time="2019-01-24T12:21:44Z" level=info msg="finished unary call with code OK" grpc.code=OK grpc.method=Get grpc.service=api.OrganizationService grpc.start_time="2019-01-24T12:21:43Z" grpc.time_ms=867.933 peer.address="<IP_ADDRESS>:36773" span.kind=server system=grpc
time="2019-01-24T12:21:44Z" level=warning msg="creating insecure network-server client" server="localhost:8000"
time="2019-01-24T12:21:44Z" level=info msg="finished client unary call" error="rpc error: code = InvalidArgument desc = timestamp: nil Timestamp" grpc.code=InvalidArgument grpc.method=GetGatewayStats grpc.service=ns.NetworkServerService grpc.time_ms=42.302 span.kind=client system=grpc
time="2019-01-24T12:21:44Z" level=info msg="finished unary call with code InvalidArgument" error="rpc error: code = InvalidArgument desc = timestamp: nil Timestamp" grpc.code=InvalidArgument grpc.method=GetStats grpc.service=api.GatewayService grpc.start_time="2019-01-24T12:21:43Z" grpc.time_ms=1066.532 peer.address="<IP_ADDRESS>:36771" span.kind=server system=grpc
time="2019-01-24T12:21:44Z" level=info msg="finished unary call with code OK" grpc.code=OK grpc.method=Get grpc.service=api.OrganizationService grpc.start_time="2019-01-24T12:21:44Z" grpc.time_ms=286.21 peer.address="<IP_ADDRESS>:36773" span.kind=server system=grpc
time="2019-01-24T12:21:44Z" level=info msg="finished unary call with code OK" grpc.code=OK grpc.method=List grpc.service=api.OrganizationService grpc.start_time="2019-01-24T12:21:44Z" grpc.time_ms=317.839 peer.address="<IP_ADDRESS>:36773" span.kind=server system=grpc
time="2019-01-24T12:21:44Z" level=info msg="finished unary call with code OK" grpc.code=OK grpc.method=Get grpc.service=api.OrganizationService grpc.start_time="2019-01-24T12:21:44Z" grpc.time_ms=58.086 peer.address="<IP_ADDRESS>:36773" span.kind=server system=grpc
""rpc error: code = InvalidArgument desc = timestamp: nil Timestamp"" happened when clicking into gateway information
My research
It seems start with protobuf's update. Then it cause lora-app-server packages dependency problem.
I find some discussion but no solution for it.
Thanks for your viewing and your helping hand.

If it helps, try not to build the proto files (leave out make api) for a temporary workaround.

I do not consider this a bug. I expect that this is due to a protobuf library and protoc-gen-go compatibility issue since the latter one has been updated since I have generated the API code for the last time. As @id-db already mentioned, the make api is not a required step and only needs to be executed when you are making API changes.
When you would like to work on bringing protoc-gen-go and protobuf libary in sync, I would welcome a pull-request.

""rpc error: code = InvalidArgument desc = timestamp: nil Timestamp"" happened when clicking into gateway information

If this issue would be with the pre-compiled binaries, then I would consider this a bug. However I can not support self compiled binaries.

Ok I got it work after ignoring make api.
Thanks for yours reply.
Seems we can't change the API by ourselves if still using protobuf library before someone give the right configuration.

@bobbyac01 actually, I have made the first step towards more consistent protobuf generation in https://github.com/brocaar/lora-app-server/commit/581519f8947add528b508895f5c8b4ce6b89f7f2. By switching to Go modules instead of Dep, I can also pinpoint tools like the Go protobuf generator to a specific version. Probably a bit more work is needed (as the current generate command expects the external .proto files under a vendor folder), but this should at least fix the root-cause: different protobuf generators generating different output.

With the migration from dep to Go modules + the above commit, this issues should be fixed.


ARROW-3231: [Python] Sphinx's autodoc_default_flags is now deprecated

Hopefully resolves the recent CI failures.

+1

Sphinx 1.8.0 raised a couple of other warning locally so pinning was quicker. Thanks for removing the unused import!


Add linting to CI with GitHub Actions

Add a github action that will run the linter when a pull request is created.

@magdapoppins can you elaboarte this please, I would like to go for this?

@RishiKumarRay thanks for the reminder, added a brief description - feel free to ask me or @lauravuo if you would like to pick this up but need more details!


Error on load image on React-native: Unexpected character

react-native-cli: 0.1.10
react-native: 0.22.2
SO Mobile: Android
SO: Mac
I'm try display a image on a component on React-native, but I don't know why this error happens...
Example of code:
render () {
    let { convenience } = this.props
    return (
      <View style={{flexDirection: 'row', height: 50}}>
        <Text style={{marginRight: 30}}>{convenience.name}</Text>
        <Image source={require('./icons___favorito_ativo.png')} />
      </View>
    )
}

Get the same error but only when overwriting an image already loaded and cmd-r is pressed.  To resolve the issue temporarily it seems the image must be re-exported / overwritten and  then a 2nd cmd-r to reload results in clearing the error message.  Happens regularly at the moment for myself at least.  Haven't had time to research further.

Seems related to image map as noted here in this issue https://github.com/airbnb/enzyme/issues/253

Other potentials ( unlikely related to image map after all ):

https://github.com/RickWong/react-isomorphic-starterkit/issues/41
https://github.com/gpbl/isomorphic500/issues/59

Same problem, fixed by re-exporting image as @seanfuture said

Restarting the packager fix it too

@facebook-github-bot answered

FYI - StackOverflow link:  http://stackoverflow.com/questions/36252381/error-on-load-image-on-react-native-unexpected-character/36289632#36289632 .. Don't believe this issue should have been closed as the above mentioned "fixes" aren't really fixes - Instead they're workarounds.  Error still comes up often and a full restart of the packager is needed.  Most definitely a prevalent and serious bug in the packager.  Taken a brief look, but packager code doesn't immediately reveal the cause although my suspicion is that Node.js is trying to process the file / file change as an asset.

I too faced the same error. After a lot of trying, I restarted the packager, and the app picked up the image. So the solution is: Restart the packager.
Hope this helps.

I know this is going sound pretty weird, but I'm going to add this comment in case anybody else gets here.  I created a index.ios.js file by copying a simple sample from an internet example (actually something at https://rnplay.org)  I kept getting "unexpected character" errors.  I'm using Atom.io as my script tool.  I was thinking perhaps I had an encoding issue with the wrong character set.  I've confirmed I'm using UTF-8
So I was using the (left/right) arrow keys on my keyboard, and I notice the cursor would stop moving for two keyboard arrow pushes, right at the location identified in my Emulator Red Screen of Disaster.  It was like there were two invisible characters in my code.  I played with this for a pretty long time to confirm.  I was able to highlight the "hidden" characters and delete them.
After deletion, the new code works great.
Bizarre.  Not sure what was there.  (Note: I copied the Slider Example Code from https://rnplay.org/apps/5FsfPA and I used a "Select All" and Command-C to do the copying and Command-V to paste... if anybody wants to repeat the experiment)
And yes, I know how silly this sounds.  Perhaps others have hit the same roadbump?

stop the server and execute react-native start again

the packager should not require this though -- this is a bug, and even though there's a workaround, it should be fixed. this isn't a SO type question, it's a "please fix the packager"

Still having this issue. Happened in various occasions, most reliably when I open an image being used in the react native app with preview (hit space bar in finder) on OSX.

I'm having the same issue, reproduced with a stock install using only the first block of sample code in the React-Native docs for the Image component here:  https://facebook.github.io/react-native/docs/image.html, reproduced here:
`import React, { Component } from 'react';
import { AppRegistry, View, Image } from 'react-native';
class DisplayAnImage extends Component {
render() {
return (

<Image
source={require('./img/favicon.png')}
/>
<Image
style={{width: 50, height: 50}}
source={{uri: 'https://facebook.github.io/react/img/logo_og.png'}}
/>

);
}
}`
restarting the packager does not resolve the issue.  (I wasn't sure if I should make a new question, referencing this one, or just add on to this one ... I went with adding on, since there is a lot of context here)
if I comment out the first Image block (the local file require), then the second one (remote file) works fine.
I'm attempting to learn/eval react-native, so I don't yet have a deep understanding of the system or what is relevant info to provide here that would help debug the issue.  I can say it's a stock, clean installation following the Getting Started document (https://facebook.github.io/react-native/docs/getting-started.html) and using only the previously mentioned example, also from the docs.
In order to get even that far, I did have to comment out a similar require in react-native/Libraries/CustomComponents/NavigationExperimental/NavigationHeaderBackButton.js, in the NavigationHeaderBackButton, where it tried to require a local asset 'back-icon.png', which was causing the same problem the sample is now exhibiting.
I'm willing to follow up and provide any information which might be useful, if anyone has some insight!

+1

Re exporting image, re encoding it, different encodings, sizes, problem remains...

Switching react-native from 40 to 38 helped, i don't think this should have happen

Another suggestion is to watchman watch-del-all and running the RN packager server with the --resetCache option.

started seeing this today after updating to RN v0.40.0. Tried all the workarounds mentioned in this thread but no luck 😞

I have this issue as well. Turns out it is because I have spaces in the project path:

This works: /Users/fdb/Desktop/myproject/icons/settings.png
This doesn't: /Users/fdb/Dropbox (Personal)/myproject/icons/settings.png

Running watchman watch-del-all has no effect — only moving to a path without spaces does.

I had this same error,
When i try stop n start server see this log:
myfile.png: Unexpected character '�' (1:0)

1 | �PNG
| ^
2 |
3 |
4 | IHDR��X��d�IT   pHYs.#.#x�?vtEXtSoftwareAdobe Fireworks CS6輲�tEXtCreation Time11/14/166z�� IDATx��}w�dU��{��\��'�0PMRXP�"
+�JPW@u
soo I try user randon .PNG google image, and it work.

After I need re export my file.

@fdb I do not have spaces in my project path and still experience this issue.

@fdb that seems to be the case for me as well.

The space in the path was the problem for me as well. I can't change that space, since it's controlled by Dropbox. Any other solution to this issue?

Hi guys,
I also want to create simple hello word based on this: https://facebook.github.io/react-native/docs/getting-started.html and I faced on this red error:
"node_modules/react-native/Libraries/CustomComponents/NavigationExperimental/assets/back-icon.png doesn't exist"

Can you help me to fix this?
I worked with React-Native later without any issue but after install new version this error appear on any app (also a simple hello world)

This is my complete error:

@cyclops24 restart the packager. It doesn't seem to pick up new images automatically.

@joshfriend how restart packager. It's a simple hello world without any image:
I just run this command:
react-native init AwesomeProject cd AwesomeProject react-native run-android

Exactly based on https://facebook.github.io/react-native/docs/getting-started.html

Here's how you restart packager: https://github.com/drapanjanas/re-natal/issues/56
I still don't get it to work though, re-starting packager nor path name without spaces fix it.

I found a phenomenon that Every file renaming, adding, editing or deleting , I always should npm start and cmd rto receive file again.That's the way what I resolved this prob.

I've confirmed that this occurs when a path has parens, which is why people using Dropbox in this thread have this issue -- Dropbox (Personal) is part of the path. Spaces are working fine. cc @mkonicek

The original topic of this issue is the "Unexpected character" bug.
It always occurs when an image file is added or changed.

when i  integration-with-existing-apps the image cannot show . the problem is same with https://github.com/facebook/react-native/issues/12062. and restart package not work.  watchman watch-del-all not work

@woshi82 I also have + in project parent name and after remove it everything goes OK.
Is it a bug or + is not acceptable for project folder name (maybe an undocumented limitation). I didn't find info or limitation about React-Native project name or path in docs.

I had a * in my folder path and after I removed it my error was gone.

I have no special chaecters in my path and it happens to me any time I make a change to the image and re-save it.

This work for me
just type "react-native link" in terminal
The reason is because you create new assets folder in your project and react-native may not know it
sorry for my bad English

Not using dropbox, don't have a + in the code. When restarting the terminal and simulator it works fine, but like others have said, this is a workaround. Not a fix.

as suggested by many here; restarted the entire process environment and now everything works. However, this is a BUG that NEEDS FIXING without any workarounds if this is going to make to the real world. Going to SO with a question like brings out the arrogant admins where they take GREAT pleasure telling how to ask intelligent questions and what is an intelligent question. To them, this IS NOT and intelligent question so no answer is given. I speak from frustrating experiences with SO, so I've learned to read, not speak.

still having this issue, and  restart doesn't work for me. RN 0.44.

Restart of packager works, but is a bit annoying :-)

Just got this on 0.44.2. my path has '-' not sure if it's the reason. Restarting the packager fixed.

I have a same problem, because my image's name has '-','+','_'. the solution is try react-native link or restart packager.

I have very easy fix for the problem that works perfectly for me. I remove the problematic image from the assets folder and add it again. And the red screen is gone. Just drag & drop.

Removing spaces and parenthesis from my path fixed that issue for me too.

I solved(!?) this problem by creating a copy of the image and replacing the original one, then renamed the image. This indeed is a weird bug, your photo at once becomes useless.

Closing the server and restarting it works just fine.

@sylvainbaronnet thanks it's working for me :+1:

@ShubhamOjha: I don't think this is really a solution. One nice thing about react native is the hot reloading feature. Which is made completely useless if you use images in your project that change during development.

faced the same problem and solved by restarting the project

same problem here, any process?

Same problem, but nothing worked. Killed and restarted the packager, replaced the image... Same unexpected character red screen. Really frustrating.. Newbie dev here :)

This is fixed for the next release of react-native, where we have many HMR improvements. cc @grabbou can tell you when that goes out but in your current version of react-native it isn't magically going to be fixed from one minute to the next.

Try terminate server your terminal and react-native run-android / ios  🗡

As @danilags says

Try terminate your packager server
rm -fr $TMPDIR/react-* clear the react-native cache
rerun your xcode
hope this helps you

tl;dr Always use .png not .PNG
I had this same issue. Using an uppercase PNG file extension will also case this error.

foobar.JPG  causes this really annoying error
foobar.jpg  works
.. lotta people wasted a lot of time .. not a confidence booster


Eliminates the non-toggle link in what appears to be one button to trigger the user-nav

Note the screen gif didn't get the subtle header bg gradient, but it's still there. An additional style update is required in dashboard to eliminate a weird :focus underline on the linked name when clicking the arrow.
If this looks good, updating dashboard would close https://github.com/aptible/dashboard.aptible.com/issues/418
@sandersonet

Seems good to me. We do lose the existing link, but there are other ways for them to get there...

:+1:  I think there is one other thing I'd like to do before closing aptible/dashboard.aptible.com#418 and that is to merge the user settings menu with the organization settings menu so it would more closely match the contents of this dropdown.

I'll pick that up @sandersonet. I need to add that bit of CSS I mentioned.

It's already done here @gib https://github.com/aptible/dashboard.aptible.com/pull/419 :smile:

Awesome @sandersonet, I'll do a quick PR for that bit of CSS I mentioned here.


Format Markdown cells

It would also be convenient to format markdown cells (i.e correct spacing of words, sentences etc similar to fmt but a mechanism that respects markdown syntax.)
Note: similar proposal at #296 . I decided to have separate discussions for each.

See #296. :)


Add new CI: cron GHA to create an issue "Update dependencies"

In Meilisearch we don't want to use Dependabot since we have a loooooot of dependencies and Dependabot updates them one by one
Using the cron event in a GitHub Actions, we want a CI that creates a new issue every 3 months in this repository with

title: "Upgrade dependencies"

description:
"We need to update the dependencies of the Meilisearch repository, and, if possible, the dependencies of all the core-team repositories that Meilisearch depends on (milli, charabia, heed...).

⚠ This issue should only be done at the beginning of the sprint!"

labels: dependencies and maintenance

If there is no one assigned I'll do it this week

Hello @VasiliySoldatkin
Thanks for your interest in this project :)
FYI, we prefer not assigning people to our issues because sometimes people ask to be assigned and never come back, which discourages the volunteer contributors to open a PR to fix this issue.
We will accept and merge the first PR that fixes correctly and well implements the issue following our contributing guidelines.
We are looking forward to reviewing your PR 😊


When I click on the category name I expect the method source pane to be selected.

To create a method, I create a category and then select it and expected to see a method template. It stayed at whatever it was, the class definition.  I can click on the method pane tab, but it's mildly annoying.

Show Method source tab on category selection


How to scroll from last to first by code?

How to scroll from last to first by code

I have same issue. +1

I wrote this code to LoopViewPager.java:
    public void next() {
        if (getCurrentItem() == mItems.size() - 1) {
            mPopulatePending = true;
            setCurrentItemInternal(0, true, true, -15000); // velocity is hard-coded
            ViewCompat.postInvalidateOnAnimation(this);
        } else {
            setCurrentItem(getCurrentItem() + 1, true);
        }
    }

Call:
mLoopViewPager.next();

It seems working. but the code has not been fully tested.


SymPy output not rendered as inline math with MathJax

Problem: The output generated by SymPy.jl is not typeset as inline math.
See the following MWE:
---
engine: julia
---

```{julia}
using SymPy
@syms x
integrate(sin(x)*cos(x), x)
```

The expected output can be generated with
---
jupyter: julia-1.10
---

```{julia}
using SymPy
@syms x
integrate(sin(x)*cos(x), x)
```

The generated HTML files reveal that QuartoNotebookRunner.jl does not (yet) support mathjax rendering.

QuartoNotebookRunner.run!(server, "notebook.qmd"; output = "notebook.ipynb")

produces both the text/plain and the text/latex output cell:
           "outputs": [
                {
                    "output_type": "execute_result",
                    "execution_count": 1,
                    "data": {
                        "text/plain": "   2   \nsin (x)\n───────\n   2   ",
                        "text/latex": "$\\frac{\\sin^{2}{\\left(x \\right)}}{2}$"
                    },
                    "metadata": {
                    }
                }
            ],

With the jupyter/ijulia engine, the text/plain output is an array of lines and the order of the MIME types is reversed, text/latex comes first:
      "outputs": [
        {
          "data": {
            "text/latex": [
              "$\\frac{\\sin^{2}{\\left(x \\right)}}{2}$"
            ],
            "text/plain": [
              "   2   \n",
              "sin (x)\n",
              "───────\n",
              "   2   "
            ]
          },
          "execution_count": 2,
          "metadata": {},
          "output_type": "execute_result"
        }
      ],

Is the order important for quarto?

What is typeof(integrate(sin(x)*cos(x), x)) in this case? If it's also a LaTeXString then this is probably covered by https://github.com/PumasAI/QuartoNotebookRunner.jl/issues/145.

Is the order important for quarto?

Ideally not, those are unordered dicts that we convert to JSON so don't really have much control over the ordering there at the moment.


Compilation

Hello. After compilation, I'm left with the stcm-editor file but I'm unable to find the executable. Sorry if I'm the one at fault, since it's my first time using waf. I'm using g++-7 and boost-1.73.

Hello,
The executable should be at build/stcm-editor on Linux.

If it is a folder, then it's not generated. Also, the stcm-editor file doesn't contain the executable.

No, build is a folder, and stcm-editor file inside should be the executable. What does file build/stcm-editor output?

stcm-editor: ELF 64-bit LSB shared object, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=58e8ec4f6e034a4042120a483a4082a611da9d8f, for GNU/Linux 3.2.0, with debug_info, not stripped

Yes, that is an executable.

Then I don't know how to implement it to the game.

I don't know what you want to implement. There are some examples in the README on how to use stcm-editor. If you're looking for the server that hooks into the game, that's only available when compiling for 32-bit windows.

Ok, I didn't read that xD

Sorry for the inconveniences and thanks for your help.


[Enhancement] Notifications based on distance

Many people are using the map system with multiple scanners over a large area (ie the hex hive), and the notifications system in iPokeGo is great! However I'd love to be able to tune the app to only alert me of a pokemon within a certain distance of my current location.
The majority of the alerts I get are for pokemon too far away for me to get at the moment, but I don't want to have to kill and then restart scanners when I do head to those locations. I also share the scanner with friends and have scanners in their vicinity, but do not want to receive alerts for pokemon that spawn miles away.
Since a pokemon's distance from you is already being calculated, I think a nice solution to this would be to set a distance in the notification settings for notifications to be limited to (defaulting to infinite.) This would then only notify when something spawns within that distance of your current location. This being changeable on the fly in the app would be much more convenient than remoting in and finding specific scanner processes to kill.

@Absentee23 where are you? Have u dropped Spigot, Discord and Playerservers?
V2 have bigs bugs so i using V1 again

It would also be pretty handy to show the current distance to the Pokemon inside the Notification.
Like:
iPokeGo
Magmar spawned 332m away from you.

Now added. I close the ticket :)


Firestore fails to load root certificates in a share extension

[READ] Step 1: Are you in the right place?

For issues or feature requests related to the code in this repository
file a Github issue.

If this is a feature request make sure the issue title starts with "FR:".

For general technical questions, post a question on StackOverflow
with the firebase tag.
For general Firebase discussion, use the firebase-talk
google group.
For help troubleshooting your application that does not fall under one
of the above categories, reach out to the personalized
Firebase support channel.

[REQUIRED] Step 2: Describe your environment

Xcode version: 10.1 (10B61)
Firebase SDK version: 5.16.0
Firebase Component: Using FirebaseAnalytics (5.5.0)
Using FirebaseAuth (5.3.0)
Using FirebaseAuthInterop (1.0.0)
Using FirebaseCore (5.2.0)
Using FirebaseDatabase (5.1.0)
Using FirebaseFirestore (1.0.0)
Using FirebaseInstanceID (3.4.0)

Here is the top part of my podfile:
# Uncomment this line to define a global platform for your project
 platform :ios, '9.0'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'

pod 'Firebase/Core'
pod 'Firebase/Auth'
pod 'GoogleSignIn'

target 'QueueUpShareExtension' do

  # Pods for QueueUpShareExtension
  pod 'Firebase/Core'
  pod 'Firebase/Auth'
  pod 'GoogleSignIn'

end

[REQUIRED] Step 3:
I'm working in an XCode ios Application Extension (Share Extension). I'm able to authenticate just fine but when I try to get documents or add a document within the same method, it's throwing the exception stack below. Does this have something to do with how I'm instantiating FirestoreSettings?
Steps to reproduce:
2019-02-12 23:48:58.769317-0500 QueueUpShareExtension[2043:7385258] *** Assertion failure in std::string firebase::firestore::remote::LoadGrpcRootCertificate()(), /Users/macmoto/Dropbox/AppDevelopment/FlutterApps/queue_up/ios/Pods/FirebaseFirestore/Firestore/core/src/firebase/firestore/remote/grpc_root_certificate_finder_apple.mm:81
2019-02-12 23:48:58.792134-0500 QueueUpShareExtension[2043:7385258] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'FIRESTORE INTERNAL ASSERTION FAILED: Could not load root certificates from the bundle. SSL cannot work. (expected path)'
*** First throw call stack:
(
	0   CoreFoundation                      0x0000000110e2c1bb __exceptionPreprocess + 331
	1   libobjc.A.dylib                     0x000000010fe12735 objc_exception_throw + 48
	2   CoreFoundation                      0x0000000110e2bf42 +[NSException raise:format:arguments:] + 98
	3   Foundation                          0x000000010f25d940 -[NSAssertionHandler handleFailureInFunction:file:lineNumber:description:] + 166
	4   QueueUpShareExtension               0x000000010b39b7e5 _ZN8firebase9firestore4util8internal4FailEPKcS4_iRKNSt3__112basic_stringIcNS5_11char_traitsIcEENS5_9allocatorIcEEEE + 533
	5   QueueUpShareExtension               0x000000010b39bea2 _ZN8firebase9firestore4util8internal4FailEPKcS4_iRKNSt3__112basic_stringIcNS5_11char_traitsIcEENS5_9allocatorIcEEEES4_ + 1538
	6   QueueUpShareExtension               0x000000010b382c96 _ZN8firebase9firestore6remote23LoadGrpcRootCertificateEv + 118
	7   QueueUpShareExtension               0x000000010b3748d0 _ZNK8firebase9firestore6remote14GrpcConnection13CreateChannelEv + 96
	8   QueueUpShareExtension               0x000000010b3743eb _ZN8firebase9firestore6remote14GrpcConnection16EnsureActiveStubEv + 267
	9   QueueUpShareExtension               0x000000010b377045 _ZN8firebase9firestore6remote14GrpcConnection12CreateStreamEN4absl11string_viewERKNS0_4auth5TokenEPNS1_18GrpcStreamObserverE + 85
	10  QueueUpShareExtension               0x000000010b3fb9c5 _ZN8firebase9firestore6remote11WriteStream16CreateGrpcStreamEPNS1_14GrpcConnectionERKNS0_4auth5TokenE + 101
	11  QueueUpShareExtension               0x000000010b3e1cdf _ZN8firebase9firestore6remote6Stream26ResumeStartWithCredentialsERKNS0_4util8StatusOrINS0_4auth5TokenEEE + 351
	12  QueueUpShareExtension               0x000000010b3e6b8e _ZZZN8firebase9firestore6remote6Stream18RequestCredentialsEvENK3$_0clERKNS0_4util8StatusOrINS0_4auth5TokenEEEENKUlvE_clEv + 142
	13  QueueUpShareExtension               0x000000010b3e6aed _ZNSt3__128__invoke_void_return_wrapperIvE6__callIJRZZN8firebase9firestore6remote6Stream18RequestCredentialsEvENK3$_0clERKNS4_4util8StatusOrINS4_4auth5TokenEEEEUlvE_EEEvDpOT_ + 45
	14  QueueUpShareExtension               0x000000010b3e67b9 _ZNSt3__110__function6__funcIZZN8firebase9firestore6remote6Stream18RequestCredentialsEvENK3$_0clERKNS3_4util8StatusOrINS3_4auth5TokenEEEEUlvE_NS_9allocatorISE_EEFvvEEclEv + 41
	15  QueueUpShareExtension               0x000000010b222c16 _ZNKSt3__18functionIFvvEEclEv + 102
	16  QueueUpShareExtension               0x000000010b16adce _ZN8firebase9firestore4util10AsyncQueue15ExecuteBlockingERKNSt3__18functionIFvvEEE + 478
	17  QueueUpShareExtension               0x000000010b16d957 _ZZN8firebase9firestore4util10AsyncQueue4WrapERKNSt3__18functionIFvvEEEENK3$_0clEv + 39
	18  QueueUpShareExtension               0x000000010b16d91d _ZNSt3__128__invoke_void_return_wrapperIvE6__callIJRZN8firebase9firestore4util10AsyncQueue4WrapERKNS_8functionIFvvEEEE3$_0EEEvDpOT_ + 45
	19  QueueUpShareExtension               0x000000010b16d6d9 _ZNSt3__110__function6__funcIZN8firebase9firestore4util10AsyncQueue4WrapERKNS_8functionIFvvEEEE3$_0NS_9allocatorISB_EES7_EclEv + 41
	20  QueueUpShareExtension               0x000000010b222c16 _ZNKSt3__18functionIFvvEEclEv + 102
	21  QueueUpShareExtension               0x000000010b1a4e31 _ZZN8firebase9firestore4util8internal13DispatchAsyncEPU28objcproto17OS_dispatch_queue8NSObjectONSt3__18functionIFvvEEEENK3$_0clEPv + 33
	22  QueueUpShareExtension               0x000000010b1a4e08 _ZZN8firebase9firestore4util8internal13DispatchAsyncEPU28objcproto17OS_dispatch_queue8NSObjectONSt3__18functionIFvvEEEEN3$_08__invokeEPv + 24
	23  libdispatch.dylib                   0x0000000110b6254b _dispatch_client_callout + 8
	24  libdispatch.dylib                   0x0000000110b6901c _dispatch_lane_serial_drain + 720
	25  libdispatch.dylib                   0x0000000110b69b5f _dispatch_lane_invoke + 401
	26  libdispatch.dylib                   0x0000000110b729a8 _dispatch_workloop_worker_thread + 645
	27  libsystem_pthread.dylib             0x0000000111eb9fd2 _pthread_wqthread + 980
	28  libsystem_pthread.dylib             0x0000000111eb9be9 start_wqthread + 13
)
libc++abi.dylib: terminating with uncaught exception of type NSException

Relevant Code:
 if let _ = FirebaseApp.app() {

            // [START setup]
            let settings = FirestoreSettings()

            Firestore.firestore().settings = settings
            // [END setup]
            self.db = Firestore.firestore()

            //TODO: Change signin method later to something more secure
             Auth.auth().signIn(withEmail<EMAIL_ADDRESS>password: "f5ibZscPolrL@NC6eI62xQNIf") { (user, error) in

                if let error = error {
                    print(error.localizedDescription)
                }
                else
                {
                    self.db.collection("queue_item").getDocuments() { (querySnapshot, err) in
                        if let err = err {
                            print("Error getting documents: \(err)")
                        } else {
                            for document in querySnapshot!.documents {
                                print("\(document.documentID) => \(document.data())")
                            }
                        }
                    }
                    /*
                    var ref: DocumentReference? = nil
                    ref = self.db.collection("queue_item").addDocument(data: [
                        "url": urlToSave,
                        "timesQueued": 1,
                        "title": titleToSave,
                        "subtitle": "",
                        "cleared": false,
                        "commentFromQueuer": commentToSave!,
                        "viewed": true,
                        "queuedForUID": _currentUID,
                        "createdByUID": _currentUID,
                        "createdAt": Date()

                    ]) { err in
                        if let err = err {
                            print("Error adding Queue Item: \(err)")
                        } else {
                            print("Queue Item added with ID: \(ref!.documentID)")
                        }
                    }*/
                }
            }
         }

        // Inform the host that we're done, so it un-blocks its UI. Note: Alternatively you could call super's -didSelectPost, which will similarly complete the extension context.
        self.extensionContext!.completeRequest(returningItems: [], completionHandler: nil)

Duplicate of #2177

This doesn't have anything to do with how you've instantiating FirestoreSettings, which is entirely unrelated. The issue is that very early in Firestore initialization, we load a certificate bundle. That bundle needs to be available to find with NSBundle.
Your Podfile doesn't actually include FirebaseFirestore or Firebase/Firestore so it's not clear exactly how you're getting Firestore, but you clearly are getting it because your code is compiling :-).
#2177 is primarily about how Carthage-based builds run into trouble when the bundle isn't available where the code expects it. If you're using CocoaPods you should be getting the resources you need automatically. In particular, look for gRPCCertificates.bundle in the FirebaseFirestore.framework.
If you see gRPCCerticates.bundle in your build, the next step would be add a call to Firestore.enableLogging(true) and report back the log lines you see related to certificate loading.

This doesn't have anything to do with how you've instantiating FirestoreSettings, which is entirely unrelated. The issue is that very early in Firestore initialization, we load a certificate bundle. That bundle needs to be available to find with NSBundle.
Your Podfile doesn't actually include FirebaseFirestore or Firebase/Firestore so it's not clear exactly how you're getting Firestore, but you clearly are getting it because your code is compiling :-).
#2177 is primarily about how Carthage-based builds run into trouble when the bundle isn't available where the code expects it. If you're using CocoaPods you should be getting the resources you need automatically. In particular, look for gRPCCertificates.bundle in the FirebaseFirestore.framework.
If you see gRPCCerticates.bundle in your build, the next step would be add a call to Firestore.enableLogging(true) and report back the log lines you see related to certificate loading.

Thank you, Gil!  Simply adding "pod 'Firebase/Firestore'" to both places in the podfile and then running pod install did the trick! Working perfectly now.

"pod 'Firebase/Firestore'" to both places in the podfile ? I find only one Podfile add get  "pod 'Firebase/Firestore'"  added. still error

"Both places" likely means both target specifications within the Podfile.

@burkaslarry "Both places in the Podfile" refers back to the Podfile posted in the issue description, where the author happened to include the dependencies twice.
If you're having difficulty please create a new issue, fully describing your environment and what you're trying to do.


include harshad16 as ml developer experience sign chair

include harshad16 as ml developer experience sign chair
Description
include harshad16 as ml developer experience sign chair

i will try to bring in experience from IDE space, for ML experience from UI to Dev.

How Has This Been Tested?

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

@kywalker-rh need your approval here
/assign @kywalker-rh


dotenv-rails not loaded early enough

I am having an issue similar to this other one https://github.com/bkeepers/dotenv/issues/19
using dotenv 2.0.0 in a Rails 4.1.9 application
the problem comes from the fact I tried to use a environment variable early in my Rails Engine initializer.
the engine is loaded through a gem.
I tried moving the gem 'dotenv-rails' to the engine gemspec
I tried doing a require 'dotenv-rails' above my usage, but no luck,...
any idea what else I could be doing ?
thanks

I just found one solution.
on top of my lib/engine.rb I do
require 'dotenv-rails'
Dotenv.load('.env')

unless you can suggest a better solution, you can close my issue.
thanks
CC: @cedricboulanger

This is one of the inherent problems with dotenv. If you need it to be initialized earlier, I recommend doing it manually like you currently are doing. Right after the Bundler.require call in config/application.rb would be ideal, but I don't know if that will be early enough for what you need.
:hatched_chick: :hatching_chick:


Fixes issue #133 with unicode strings

https://github.com/webpack/css-loader/issues/133

[Current coverage][cc-pull] is 98.21% (diff: 100%)

No coverage report found for master at b6acfec.

Powered by Codecov. Last update [b6acfec...afec6a5][cc-compare]
[cc-base-branch]: https://codecov.io/gh/webpack/css-loader/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/webpack/css-loader/compare/b6acfecd7fb98c15cf84a4b5a339da02af95dacb...afec6a5f74a23644fbbaffaa9fd4965c3e449ba3?src=pr
[cc-pull]: https://codecov.io/gh/webpack/css-loader/pull/307?src=pr

@sokra this looks good but I wonder if maybe these tests should be updated to reflect the same node versions as webpack/webpack. We can get back around to it if we need to, I'll assign to me to keep track.

Thanks
@TheLarkInn yep

@sokra it would be awesome to get this on npm, thanks! :)

+1 on npm, would be really great!


Unclear instructions

In the first paragraph it says:

Synapse uses Azure Active Directory (AAD) passthrough by default for authentication between resources. If you need to connect to a resource using other credentials, use the TokenLibrary directly. The TokenLibrary simplifies the process of retrieving SAS tokens, AAD tokens, connection strings, and secrets stored in a linked service or from an Azure Key Vault.
AAD passthrough uses permissions assigned to you as a user in AAD, rather than permissions assigned to Synapse or a separate service principal. For example, if you want to use AAD passthrough to access a blob in a storage account, then you should go to that storage account and assign blob contributor role to yourself.

But then the section ADLS Gen2 storage with linked services says:

Synapse provides an integrated linked services experience when connecting to Azure Data Lake Storage Gen2. Linked Services can be configured to authenticate using an Account Key, Service Principal, Managed Identity, or Credential.
When the linked service authentication method is set to Account Key, the linked service will authenticate using the provided storage account key, request a SAS key, and automatically apply it to the storage request using the LinkedServiceBasedSASProvider.
When the linked service authentication method is set to Managed Identity or Service Principal, the linked service will use the Managed Identity or Service Principal token with the LinkedServiceBasedTokenProvider provider.

Is this the default behaviour instead of the passthrough when the resource is a linked service? Or just when the spark session is configured with the example settings? If so can anyone break out of their user permissions by configuring the spark session and use the linked service account key/managed identity/service principal for access?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 56d638cd-6592-ce95-90aa-dc8d6e4e90ba
Version Independent ID: 5360961f-6bfc-ecad-cf49-22eee26bd010
Content: Secure access credentials with Linked Services in Apache Spark for Azure Synapse Analytics - Azure Synapse Analytics
Content Source: articles/synapse-analytics/spark/apache-spark-secure-credentials-with-tokenlibrary.md
Service: synapse-analytics
Sub-service: spark
GitHub Login: @mlee3gsd
Microsoft Alias: martinle

@molotch Thank you for sharing feedback. We are actively monitoring it. We will share updates soon.

@molotch Yes its default behavior. When you create a linked service you need to select authentication type either as "AccountKey" Or "Service principle" Or "Managed Identity". So in this case AAD pass-through will not come in to picture.
As described in doc, depending on authentication type selected inside linked service,

If its set to" Account Key", the linked service will authenticate using the provided storage account key, request a SAS key, and automatically apply it to the storage request using the LinkedServiceBasedSASProvider.
If its set to is set to Account Key, the linked service will authenticate using the provided storage account key, request a SAS key, and automatically apply it to the storage request using the LinkedServiceBasedSASProvider.

Hope this helps. Please let us know if any further queries. Thank you.


DEPR: Panel4d and panelND

closes #13564

This is was a PITA.
@jorisvandenbossche @wesm @shoyer

@shoyer @MaximilianR esp have a look at the warnings (e.g. maybe have a specific page)?

Can we add the deprecation notice to the docstrings for PanelND and Panel4D, too?
@MaximilianR Let's see if we can finish up that doc page on xarray for panel users (https://github.com/pydata/xarray/pull/832) -- it would be great to be able to link to that in the pandas docs.

Oh boy, that will be a joy if when we can remove it :-)
Too late for now, but isn't there a way to eg test the warning once, and be able to mute them for all other tests?

I wish - the problem is that FutureWarninh is generic so No easy way

Can't you filter with a regex on the message or module?

I gave it a try - u r welcome to change it - it's buggy in 27 I think

For the next big depr then :-)

[Current coverage][cc-pull] is 85.32% (diff: 100%)

Merging [#13776][cc-pull] into [master][cc-base-branch] will increase coverage by 0.74%

@@             master     #13776   diff @@
==========================================
  Files           141        141
  Lines         51233      50683   -550
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits          43331      43244    -87
+ Misses         7902       7439   -463
  Partials          0          0

Powered by Codecov. Last update [2c047d4...2b408a8][cc-compare]
[cc-base-branch]: https://codecov.io/gh/pydata/pandas/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/pydata/pandas/compare/2c047d4fbe88e7462ec82314f58d014e7b0ad54e...2b408a84b22a6d13a97b071964f738eb5486ef64?src=pr
[cc-pull]: https://codecov.io/gh/pydata/pandas/pull/13776?src=pr

@MaximilianR Let's see if we can finish up that doc page on xarray for panel users (pydata/xarray#832) -- it would be great to be able to link to that in the pandas docs.

I'll have a go this week!

@jorisvandenbossche updated.
@shoyer
cc @MaximilianR
we can always change the xarray link points later (I think we have an issue for that anyhow). As these need to go in the .to_xarray() doc-string as well.

Small comment/question, for the rest ready to merge for me. The doc link can indeed be updated later.


Feature request: delegated login

It would be very nice to replace the current Auth flow with a "proper" one eg. https://oauth.net/2/pkce/.
This would eliminate the need for password entry for users already authenticated against their oauth provider and it would reduce attack surfaces

Which git provider are you on?
OAuth works for Github, not for Gitea, etc.
I can try enabling it for git providers that are in use.

I'm using gitea

port https://github.com/drone/drone/pull/2622 & https://github.com/drone/drone/pull/2684 ?
this parts are OpenSource if I did look correct ...

closing as this seems to be resolved by #226
Please feel free to re-open if needed.


logfiles are not in local timezone nor does it state what timezone it is

On ubuntu in stockholm. I am guessing log times are in UTC, but that is very confusing, especially when it does not state so in logs.
Minor thing, but easy to fix, right?  Rather have it in local time and stated it is in local time.
overall I am very impressed what you have built here, tried storj first, it does not compare.
//Cheers

Thanks for the encouraging words. Log times are in UTC because Sia is a global network. In the event that something strange happens on many machines at once, we want to be able to match the logs. This is easiest if the timestamps are all in the same timezone. Machines may still be off due to inaccurate clocks, but it still makes our lives easier to be able to say 'oh yeah this happened during the DDOS attack' or whatever.


Enhancement | Prefixes should be more easier so that the commands will come at the top

some of the prefixes are not visible until we type the whole of it. It would be better if we can search them more easier

Fixed in #6


Create cluster mutation webhook

Issue #, if available:
#2685
Description of changes:
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/test eks-anywhere-e2e-presubmit

/retest-required

/override eks-anywhere-e2e-presubmit

/approve


fix stretched featured product images

Have you read the contributing guidelines ?
What is the purpose of your pull request?

[x] Bug fix
[ ] New feature

Proposed changes

fix stretched featured product images

Warning
Please read these points carefully and answer honestly with an X
into all the boxes. Example : [X]
Before submitting a pull request make sure you have:

[x] Read the guidelines for contributing.
[ ] Wrote some tests.
[x] Respected the linting guidelines.

@Joe-Mwangi, could you fix the lint errors?


[FLINK-Streanming] [Streaming API] fixed punctuation

What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)

The TaskInfo is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (100MB)
Extended integration test for recovery after master (JobManager) failure
Added test that validates that TaskInfo is transferred only once across recoveries
Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Thanks a lot for this contribution.
I'm not sure if this comma is grammatically correct there. I propose to close this PR without merging it, because it doesn't really improve Flink, and it's more overhead for us to review and merge this.


The plugin conflicts with openapi-generator-maven-plugin

Hi guys!
I have a project that reproduces the issue here https://github.com/emeraldhieu/issue-reproduction/tree/master/order
If you build it, the OrderResponse is not recognized in the classpath. If you comment out the build-helper-maven-plugin, the graph type Order is not recognized in the classpath. Please reimport the module whenever building the module.
Could you please help me fix it?

Can you share the maven output? I was able to build your project from the command line with no issues. Seems to startup up in IntelliJ just fine as well.

Hi @emeraldhieu  - is the repo in the current broken state? I cloned, built and it ran in IntelliJ without issue.
I see your generated REST and GraphQL code files under generated-sources. I'v run into trouble in the past with this approach.

Yes, my repo is in a broken state because of using two code generators. It's served for reproducing the issue. I have compilation errors in IntelliJ. It's like the generated source config conflict each other.

The issue in IntelliJ is that it can't find the generated sources for openapi at the root of generated-sources. That plugin includes src/java/main in the generated structure - confusing IJ.
Here's my recommendation:

Let me know if that helps. I'm going to close this issue tomorrow as this is a maven configuration issue outside of the DGS codegen plugin.

@deweyjose It works perfectly!


bookinfo tutorial documentation problems

I went through the https://istio.io/docs/demos/bookinfo.html instructions today.
istioctl list route-rule must be changed to istioctl get route-rule --output yaml.
There is a trademark usage concern.  “rotten tomatoes” should be “The Rotten Tomatoes API” or similar.
I also must admit I found the following fragment difficult to understand as a beginner:
The addons yaml files contain services configured as type LoadBalancer. If services are deployed with type NodePort, start kubectl proxy, and edit Grafana’s Istio-dashboard to use the proxy.

I believe this sentence implies that the addons configuration can be edited to use a NodePort.  (If that is the case I strongly advise shipping Istio with addons that uses LoadBalancer and some kind of nodeport_addons for Minikube users.  It is too hard to be editing YAML files.  Furthermore it might be better to give explicit instructions for kubectl proxy and explaining how to find Grafana and the dashboard and describing the edits that are being recommended.

Please file this against istio.github.io

Anything still pending? If not, can we close this?

Rate limits?
On Wed, May 3, 2017 at 5:21 PM Jasmine Jaksic<EMAIL_ADDRESS>wrote:

Anything still pending? If not, can we close this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/118#issuecomment-299039338, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AH0qd1joy092mh6EEU8HyvrbN-e6oSrXks5r2O_0gaJpZM4M3Cqh
.

--
~shriram


Fix legacy redirection of legacy mainnet links

What it solves
Broken legacy redirection of mainnet.
How this PR fixes it
By loading chains from backend, the config is not immediately present for the redirection logic to reference.
A hardcoded map of { [subdomain]: [shortName] } is now referenced for determining the shortName to use. If the subdomain is not found in the map, it defaults to eth: because we hosted mainnet without a subdomain.
How to test it

Attempt to navigate to a legacy route, i.e. {{PR}}/app/#/safes/0xfF501B324DC6d78dC9F983f140B9211c3EdB4dc7/balances
Observe the correct redirection to {{PR}}/app/eth:0xfF501B324DC6d78dC9F983f140B9211c3EdB4dc7/balances because the PR has no subdomain from the map.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 32.45%

Totals

Change from base Build<PHONE_NUMBER>:
0.003%

Covered Lines:
3125

Relevant Lines:
8573

💛  - Coveralls

Question. The only redirection always goes to "rin:". I assume because this is a PR, and in prod, when the URL is something like "https://xdai.gnosis-safe.io/app/#/" it will redirect to the proper xdai: network. Is this correct?
If this is the case then the ticket is good to be merged

Question. The only redirection always goes to "rin:". I assume because this is a PR, and in prod, when the URL is something like "https://xdai.gnosis-safe.io/app/#/" it will redirect to the proper xdai: network. Is this correct?

Yes, the redirection that already exists on the old subdomains redirects correctly but because of the dynamic loading of configs from the CGW and renaming of Mainnet to Ethereum, it is causing problems with finding the shortName for what was Mainnet. The fallback for this was included as follows:
DEFAULT_CHAIN_ID === CHAIN_ID.RINKEBY ? SHORT_NAME.RINKEBY : SHORT_NAME.MAINNET

I will merge this now.


Cow: Watch Konnect[\W_]+AI[\W_]+Technologies

Cow requests the watch of the watch_keyword Konnect[\W_]*+AI[\W_]*+Technologies. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Konnect[\W_]*+AI[\W_]*+Technologies has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Dragonrage in Charcoal HQ


Disabled support HDR SEI Payload by hiding under define HDR_SEI_PAYLOAD

Tracked-On: OAM-71346, OAM-72188
Signed-off-by: tianmi.chen<EMAIL_ADDRESS>

+1


How to change referencing external styles to preload mode

Description
I want to change the reference mode of CSS to preload mode, similar to<link rel="preload"="style. css" as="style"/>.
Because i want to solve the problem of blocking page rendering caused by referencing external styles in extreme networks.
Is there any way to do this,
Suggested solution
Provide configuration to enable CSS preloading mode
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Can you explain why this is needed? By default, Vite already hoists the styles needed for a HTML in the head (which should be requested/streamed very early). And for subsequent dynamic imports, Vite already preloads it directly:
https://github.com/vitejs/vite/blob/4ccfa05d0e98e1d8cd95ef93153056de78c657cb/packages/vite/src/node/plugins/importAnalysisBuild.ts#L112-L119

@bluwy Sounds like they want to opt out of sync style loading altogether?

Vite already hoists the styles needed for a HTML in the head (which should be requested/streamed very early)

Requests start early, but even then, the doc will only render once all styles that are linked this way are fully loadee. If all styles are injected as preloads, you can control at which point you want to make the page visible. For example:
<html data-loaded="false">
<head>
  <link rel="preload" href="x" as="style" />
  <link rel="preload" href="y" as="style" />
  <link rel="preload" href="z" as="style" />
  <script>
	// Don't wait for styles if connection is slow
	if (navigator.connection?.effectiveType?.includes('2g')) {
      document.documentElement.dataset.loaded = true
    }

    // Don't wait for styles for longer than than 3.5s
    setTimeout(() => (document.documentElement.dataset.loaded = true), 3500)

    const stylePreloads = document.querySelectorAll('link[rel="preload"][as="style"]')
    let loadedCount = 0
    for (const preload of stylePreloads) {
      preload.onload = () => {
        preload.onload = null
        preload.rel = 'stylesheet'
        if (++loadedCount === stylePreloads.length) {
          document.documentElement.dataset.loaded = true
        }
      }
    }
  </script>
  <style>
    [data-loaded="false"] body > * { display: none; }
    [data-loaded="false"] body::before{ content: 'Loading, please wait...' }
  </style>
</head>

Interesting usecase. I'm still not quite sure if this is something Vite wants to support ootb though, since:

You need to inject a script and include specific styles to handle the preload.
Could cause layout shifting if you're not careful.
It's hard to tell what a CSS chunk contains, so how would you know if the crucial CSS is needed for the current page are loaded?

I think the default stylesheet handling still provides the best support for all cases. And if they need this technique, they could post-process the HTML.


Added UAE region me-central-1

Related Issue
I have found UAE me-central-1 region not enable for SOCI CloudFormation, so I have added. kindly accept the pull request.

Hi Kern,
I'm unable to see the changes in the main repo. I can see you have approved
my pull request with changes UAE region me-central-1 Could u please
recheck
https://github.com/aws-ia/cfn-ecr-aws-soci-index-builder/blob/main/.taskcat.yml
I look forward to hearing from you. Thank you for your consideration.
Sincerely,
Thanks and Regards
[image: Capture_m2.PNG] https://www.abdulrahmanuk.com/
Abdul Rahman UK
DevOps Engineer | AWS | MCA
+971 505454429 |+91<PHONE_NUMBER> | skype: abdul_915
@.***
On Wed, Nov 22, 2023 at 10:16 PM Kern Walster @.***>
wrote:

@.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
https://github.com/aws-ia/cfn-ecr-aws-soci-index-builder/pull/59#pullrequestreview-1745069008,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEH7MPJMSGGVV56WE4S4LZ3YFY6PJAVCNFSM6AAAAAA7UKTXF6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONBVGA3DSMBQHA
.
You are receiving this because you authored the thread.Message ID:
@.***
com>


randi() of RandomGenerator returns signed int instead of unsigned int

Godot version:

? - 3.1
Issue description:

Native randi() and GD.Randi() in C# returns uint. But RandomGenerator.Randi() returns int.
Also wrong: Docs and https://github.com/godotengine/godot/blob/master/doc/classes/RandomNumberGenerator.xml#L42

See https://github.com/godotengine/godot/issues/23329 aswell

Also wrong: Docs and https://github.com/godotengine/godot/blob/master/doc/classes/RandomNumberGenerator.xml#L42

Variant only has int type, so this is correct.
RandomNumberGenerator::randi() does return an uint32_t in core/math/random_number_generator.h, so that's correct. It's the exposed to script languages as int, so it's a signed int with a guaranteed positive value. So from a quick look it doesn't seem to be a bug but a design choice.
CC @neikeq

It states "Generates pseudo-random 32-bit unsigned integer between '0' and '4294967295', inclusive.".
These values don't fit in a signed int.

It's a 64-bit signed int.

That's even worse then. A falsely returned sint32 which actually holds a uint32 could have been recovered with unchecked((uint)someInt) in C#. No way to get the actual value, when the API returns a int32 which tries to hold a sint64. Am I getting something wrong?

That's even worse then. A falsely returned sint32 which actually holds a
uint32 could have been recovered with unchecked((uint)someInt) in C#. No
way to get the actual value, when the API returns a int32 which tries to
hold a sint64. Am I getting something wrong?

Yes, you're getting it wrong. It's a signed 64-bit int which holds the
value of a 32-bit unsigned int. I don't see any problem.

C# binding: [GodotMethodAttribute("randi")] public int Randi();

@neikeq The Mono bindings should likely be fixed to use sint64 for Variant::INT.

The only reason I didn't make it use long for everything is because I want to make it possible for GetTypeInfo to differentiate between the two.

Well that's a good reason. Also the C# API currently feels like it's getting somewhere with generics etc. Having long kinda everywhere would break that imo.


Option to disable status light accessory

It would be nice if there were an option to disable the status light accessory.

Same - added in v1.2


feat: modify StoryBook

Description

add image in the letter (favicon image)

change colors like the dashboard colors

add in readme

screenshots

https://github.com/hasadna/open-bus-map-search/assets/76536506/e1811e11-21b3-4d5d-9b43-3dc86f640fa1
@NoamGaash What do you think?

Timetable
Schedule
Route map
Bus stop
Fare details
Transit updates
Service alerts
Passenger guide
Travel advisory
Public transport

Do you like an option from here? Do you have other suggestions?

Why not keeping it as storybook?

Hmm, In my opinion,  this is not related to the topic of the site. However,  we can keep it 'storybook'.

I will leave it storybook for now :)

thanks!


Feature editable text element

@rgerstenberger
Please review. Code comments are there for things that look out of ordinary for clarification.
Will handle text input:

Line Breaks:

WordWrapping on resize:

This LGTM but I'd like @kenwheeler to review as well before merging.

Looks solid in my book

@rgerstenberger @kenwheeler I'll merge if everything is a-ok. 👍 ?

One minor nit, fix then merge :)


Comment support for tvgt

Although the documentation states tvgt is intended for debugging, it's also useful for creating "source code" for manually-optimized tvg images, and comments could be good for explaining what commands construct what area of the image

Sounds good. Accepted comment syntax is pascal comment syntax. It starts a comment with (* and ends it with *), no support for line comments.
(* this is my first TinyVG file! *)
(tvg 1
  (24 24 1/32 u8888 default)
  (
    (0.161 0.678 1.000)
    (1.000 0.945 0.910)
  )
  (
    (* empty for now *)
  )
)


cmd/cover: //line directives frequently handled incorrectly

(This combines #35781, #33690, #25280, and https://github.com/golang/vscode-go/issues/603)
Source files that contain //line directives confuse the coverage tool, prducing coverage output that is unhelpful or confusing to users.
For instance, a short main.go (import path foo.gak)  with first lines
//
package main

produces a coverage file:
mode: set
foo.gak/main.go:6.10,8.26 2 1
foo.gak/main.go:12.2,12.19 1 1
foo.gak/main.go:8.26,11.3 2 1
foo.gak/main.go:12.19,13.21 1 0

If the first line is changed to
//line con.go:8

the coverage file changes to:
mode: set
foo.gak/main.go:12.0,14.0 2 1
foo.gak/main.go:18.0,18.0 1 1
foo.gak/main.go:14.0,17.0 2 1
foo.gak/main.go:18.0,19.0 1 0

This file does not refer to con.go, and the ranges are wrong (or, at best, imprecise) for that file, and completely wrong for main.go.
A minimal improvement would be for the coverage tool to change user's //line directives to bare // comments, so that the coverage data corresponds to the file presented to the tool. [Getting results that point to files mentioned in //line directives would require changing the format of the tables in the generated code, at least. Even then the results might be peculiar, for instance if the generated file were run through go fmt.]

@golang/tools-team

I was looking into this a little bit and here is some more background information...
According to Go Programming Language Reference, line directives can be of //line or /*line ...*/ format:

In order to be recognized as a line directive, the comment must start with //line or /*line followed by a space, and must contain at least one colon. The //line form must start at the beginning of a line. A line directive specifies the source position for the character immediately following the comment as having come from the specified file, line and column: For a //line comment, this is the first character of the next line, and for a /*line comment this is the character position immediately following the closing */.

The //line format wouldn't be too hard to replace because it has to be at the start of the line, but /*line ...*/ is more complicated because it can be anywhere on a line. However unlikely, it could be inside a string, so it is not just a simple replace... replacing it if it is inside a string, would change the program behavior.
I suppose one approach would be to just fix it for //line type directives (by replacing those lines with //) and leave /*line ...*/ as-is, and it would be a known limitation of cover.
WDYT?


hoverSignature displays multiple signatures

I am not sure if this is intentional or not, but since the update to 1.11.1, when enabling hoverSignature and you are inside a subroutine A hovering over one of the arguments of a call to subroutine B, both signatures of A and B will be displayed.
In the picture, sub A is the current scope and sub B is copy_adjoint_options. The top row of the hover message corresponds to the signature of particles (that's where the mouse pointer was located) which is an argument of sub A. The bottom row corresponds to the signature of adj_opt_dest which is an argument of sub B.

Closing since it is actually pretty helpful seeing the types and intents of the variables for a function/subroutine and its caller.


Vue Query + Nuxt 3 SSG - Can not reset hydrated query

Describe the bug
queryClient.resetQueries() does not work as expected for server-hydrated queries. Hydrated query isLoading state is always false, unlike to queries run on client.
Your minimal, reproducible example
https://codesandbox.io/p/devbox/admiring-frog-rnw27x
Steps to reproduce
There is server-prefetched request with post id = 1;

Click reset posts queries (it calls queryClient.resetQueries);
Notice that query just refetches, cache entry not being reset and isLoading state is always false;
Click increase id button and wait for new post to load;
Click reset posts queries again;
Notice that client-fetched query being reset as expected, cache is reset and isLoading state becomes true for a moment;
You can decrease id back to 1 and repeat step #1 to ensure that resetQueries is not able to reset server-prefetched query

Expected behavior
queryClient.resetQueries is able to reset any query, wether its server fetched or client fetched
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
OS: Windows, browser: Chrome 124.0.6367.78 / Firefox 125.0.2
Tanstack Query adapter
vue-query
TanStack Query version
5.32.0
TypeScript version
No response
Additional context
No response

This is by design as reset restores the initial state of the query, which is hydrated from the server - https://tanstack.com/query/latest/docs/reference/QueryClient/#queryclientresetqueries

This is by design as reset restores the initial state of the query, which is hydrated from the server - https://tanstack.com/query/latest/docs/reference/QueryClient/#queryclientresetqueries

What is a proper way to completely reset server-prefetched queries then?
Why the state after hydration is considered to be the inital state?
As mentioned in docs about SSR, queries are being "prefetched" on server. When you prefetch a query on the client, its inital state is the state before any load, not the state after prefetch, unlike to server-prefetch queries.
In my opinion, query reset should reset query to its pre-loaded state, not after-hydration state.

What is a proper way to completely reset server-prefetched queries then?

queryClient.resetQueries - But it would NOT notify existing observers, as query is just removed.

Why the state after hydration is considered to be the initial state?

So you would not have intermediate loading state displayed on the client side. With SSR you want you page to appear to the user in fully populated way.

In my opinion, query reset should reset query to its pre-loaded state, not after-hydration state.

I guess we could add a prop to control this behavior. Not sure if there is a specific reason to not do it for react-query. @TkDodo

queryClient.resetQueries() does not work as expected for server-hydrated queries. Hydrated query isLoading state is always false, unlike to queries run on client.

This was fixed with:

https://github.com/TanStack/query/pull/7837

When a query is created with hydration, it still re-sets to the default state. The only way to get a different state is when initialData is set.

Checked just now and it's surely fixed! Thanks!


add appid prefix to all session key and add testcase about component

There were the following issues with your Pull Request

Commit: 509a0727287e63b89fa1893864820fd87a6d7f54

Commits must be in the following format: %{type}(%{scope}): %{description}

Commit: 844c0977d5754d46558bc9d018fe387de3cff574

Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/jxtech/wechatpy/blob/master/CONTRIBUTING.md

This message was auto-generated by https://gitcop.com

Thanks.


Validation of StudyIndex and CredibleSet datasets

As a user I want run validation before the data release is produced because I want to ensure data we generate is correct.
Background
The ETL run with steps:

study_validation
credible_set_validation
was performed on data from buckets:
gwas_catalog_data
finngen_data/r11
ukb_ppp_eur_data
eqtl_catalogue_data

The results from the validation can be found in:

gs://genetics_etl_python_playground/releases/24.09/study_index
gs://genetics_etl_python_playground/releases/24.09/invalid_study_index
gs://genetics_etl_python_playground/releases/24.09/credible_set
gs://genetics_etl_python_playground/releases/24.09/invalid_credible_set

Tasks
valid study_index count: 1977110
invalid study_index count: 10663
valid credible_set count: 2254759
invalid credible_set count: 1063068
The analysis was performed at 2024-09-11
Study index validation

qualityControls
count

0
Composite association
1956

1
Study not found in the study index
31106

2
Explained by a more significant variant in high LD (clumped)
39012

3
LD block does not contain variants at the required R^2 threshold
46738

4
Palindrome alleles - cannot harmonize
71184

5
Incomplete genomic mapping
90306

6
Variant inconsistency
90311

7
No mapping in GnomAd
90739

8
Variant not found in LD reference
139463

9
Non-unique study locus identifier
167939

10
Subsignificant p-value
788981

Credible set validation

id
qualityControls
projectId
count

0
Target/gene identifier could not match to reference.
Randolph_2021
1

1
Target/gene identifier could not match to reference.
Aygun_2021
1

2
Target/gene identifier could not match to reference.
Naranbhai_2015
1

3
Target/gene identifier could not match to reference.
Peng_2018
2

4
Target/gene identifier could not match to reference.
van_de_Bunt_2015
2

5
Target/gene identifier could not match to reference.
Fairfax_2012
3

6
Target/gene identifier could not match to reference.
UKB_PPP_EUR
3

7
Target/gene identifier could not match to reference.
Kasela_2017
4

8
Target/gene identifier could not match to reference.
Gilchrist_2021
5

9
Target/gene identifier could not match to reference.
Braineac2
5

10
Target/gene identifier could not match to reference.
Schwartzentruber_2018
6

11
Target/gene identifier could not match to reference.
Perez_2022
7

12
Target/gene identifier could not match to reference.
iPSCORE
7

13
Target/gene identifier could not match to reference.
PISA
8

14
Target/gene identifier could not match to reference.
PhLiPS
11

15
Target/gene identifier could not match to reference.
Steinberg_2020
15

16
Target/gene identifier could not match to reference.
Walker_2019
15

17
Target/gene identifier could not match to reference.
Fairfax_2014
15

18
Target/gene identifier could not match to reference.
CEDAR
17

19
Target/gene identifier could not match to reference.
OneK1K
21

20
Target/gene identifier could not match to reference.
CAP
21

21
Target/gene identifier could not match to reference.
GEUVADIS
22

22
Target/gene identifier could not match to reference.
GENCORD
25

23
Target/gene identifier could not match to reference.
Bossini-Castillo_2019
25

24
Target/gene identifier could not match to reference.
Lepik_2017
26

25
Target/gene identifier could not match to reference.
Alasoo_2018
30

26
Target/gene identifier could not match to reference.
Nathan_2022
38

27
Target/gene identifier could not match to reference.
Cytoimmgen
39

28
Target/gene identifier could not match to reference.
HipSci
40

29
Target/gene identifier could not match to reference.
Nedelec_2016
40

30
Target/gene identifier could not match to reference.
CommonMind
50

31
Target/gene identifier could not match to reference.
BrainSeq
53

32
Target/gene identifier could not match to reference.
ROSMAP
56

33
Target/gene identifier could not match to reference.
FUSION
69

34
Target/gene identifier could not match to reference.
BLUEPRINT
82

35
Target/gene identifier could not match to reference.
TwinsUK
83

36
Target/gene identifier could not match to reference.
Quach_2016
104

37
Target/gene identifier could not match to reference.
Schmiedel_2018
119

38
The identifier of this study is not unique.
GCST
142

39
No valid disease identifier found.
FINNGEN_R11_
165

40
Target/gene identifier could not match to reference.
GTEx
1317

41
No valid disease identifier found.
GCST
7968

@ireneisdoomed @d0choa @DSuveges @Daniel-Considine @xyg123

This one is really suspicious:
38 | The identifier of this study is not unique. | GCST | 142

Many of these should be PICS sum stats vs PICS top hits. We will probably rescue many of them once the inclusion criteria are added

9
Non-unique study locus identifier
167939

The duplicated studyIds ->
+------------+-----+
|     studyId|count|
+------------+-----+
|GCST90096899|    2|
|GCST90096897|    2|
|GCST90096898|  128|
|GCST90096895|    2|
|GCST90096894|    2|
|GCST90096896|    2|
|GCST90096900|    2|
|GCST90096892|    2|
+------------+-----+

Looking at the studies as well. An interesting number of QTLs are missed due to obsoleted Ensembl IDs. Perhaps, we could implement additional logic to rescue some of them but not a priority for now
In [45]: df.filter(f.array_contains(f.col("qualityControls"), "Target/gene identifier could not match to reference.")).groupBy("studyType", "traitFromSourc
    ...: e").count().sort(f.col("count").desc()).show(truncate = False)
+---------+------------------------------------------------+-----+
|studyType|traitFromSource                                 |count|
+---------+------------------------------------------------+-----+
|eqtl     |ENSG00000288884                                 |106  |
|eqtl     |ENSG00000288884.1_7_128661095_128663479         |90   |
|eqtl     |ENSG00000285476                                 |60   |
|eqtl     |ENST00000610032                                 |51   |
|eqtl     |ENSG00000286996.1_3_39423802_39424870           |50   |
|eqtl     |ENST00000444946                                 |47   |
|eqtl     |ENSG00000256427                                 |47   |
|eqtl     |ENSG00000286996                                 |46   |
|eqtl     |ENSG00000285762                                 |46   |
|eqtl     |ENSG00000182230                                 |46   |
|eqtl     |ENST00000367055                                 |45   |
|eqtl     |ENST00000616861                                 |42   |
|eqtl     |ENSG00000259820                                 |39   |
|tuqtl    |ENSG00000112096.grp_2.downstream.ENST00000367054|39   |
|eqtl     |ENSG00000228139                                 |39   |
|eqtl     |ENSG00000259820.1_8_134792020_134798272         |37   |
|eqtl     |ENSG00000228906                                 |36   |
|eqtl     |ENSG00000261490                                 |33   |
|eqtl     |ENST00000538183                                 |32   |
|eqtl     |ENSG00000280374                                 |31   |
+---------+------------------------------------------------+-----+
only showing top 20 rows

We can continue discussing, but I think this task is done.
Numbers will change when variant validation (#3452) and study/credible set inclusion are implemented, and we will have additional numbers to validate.


feat: chapter 19 - (challenge)

Chapter 19: Accessibility (challenge)
This pull request shows a solution for the chapter's challenge.
Topics Covered

Providing Enough Context for Data Entry
Announcing Events

How to Test
To test the new feature, you can do the following:

Clone the repository.
Install the dependencies.
Run the application.
The new feature should be available.

Screenshots

Known Issues
There are no known issues with this pull request.
References
Reviewers
Thanks!

Looks good to me.


Tooltip Activation

Sub-issue from #73
Figure out developer-friendly ways to activate and deactivate tooltips.
activation/deactivation conditions: triggered by events
-- (a) automatic (e.g., in the first time use of the app)
-- (b) manual (by pointing at an object with the laser pointer with a 0,5 seconds delay, needs to be tested if this works)
displaying conditions (distance, view angle, ...)
interaction (hide it by another laser click)
rotate 2d tooltip UI to face HMD

 [tooltip] Create a way to annotate and display/playback contextual (3d objects) messages in the form of texts or audio clips.


Stream Enrich: partition enriched bad output by day

When using Athena to attempt debugging a real-time pipeline last week I realised that the enriched/bad data isn't partitioned. Whilst querying the dataset is still possible as I covered in this tutorial, there are big performance implications without partitions. There is effectively no way to reduce table scans with partitions in a real-time pipeline. I've created this issue so that we eventually partition the data in enriched/bad by day. This would be a better experience than the current batch enriched/bad data which is partitioned by run.

I think this relates to the S3 Loader - and may already be available as a feature (just not configured like this). Please raise a ZD to L3 Eng.

thanks @alexanderdean will do!


style(java-client): optimize code style

#887

Thanks for your contribution to improve the Java code!

Happy to do this!


Stuck on login cannot get past the admin cred prompt

Hi
Ive created an empty MVC5 project (VS2015) with auth, nuget'd PiranhaCMSMvc 2.2.5. and allowed all the overrides to the files to take place.
After the initial configuration page completes I am left with the login prompt to enter admin creds.  I enter the correct credentials but nothing happens. If I enter incorrect creds I am told they are invalid.
Any ideas??
Login for /manager👎
http://imgur.com/a/9yu3S
Site as it appears when I browse to site root
http://imgur.com/a/lSP5d

Two mins after posting I saw the reason
The default MVC framework  does not use Forms Auth
<authentication mode="None" />
<remove name="FormsAuthentication" />
Just comment these out to allow forms auth and add in
<authentication mode="Forms">
 <forms name="PiranhaCMS" timeout="30" />
</authentication>


Cleaning image (cube grid top)

This PR builds on the code written by haiderabbas007, p-pxmpo and jkblc.
Task Group 3 members were supposed to work on a single data analysis Jupyter notebook called data_analysis.ipynb
I have used the data from the image folder that contains the file "cube_grid_top_data.pkl".

Sugessted reviewer: @haiderabbas007 @jkblc

Only the cleaned-up image is needed, the original is not needed. Secondly, can you choose the same scale for both axes? The output image should be squarish.

Thank you for the suggestions @haiderabbas007 . I have now made the desired changes.

@haiderabbas007 If these are good please approve so they can be merged.