add fitBoxs in controller & fix back from fullscreen & fix onDoubleTap()

can you explain to me what was changed in on double tap?
also for the setDefaultOverlaysAndOrientations()
i think it should be
 /// set the default orientations and overlays after exit of fullscreen
  Future<void> setDefaultOverlaysAndOrientations() async {
    //await SystemChrome.setPreferredOrientations(this.orientations);
    SystemChrome.setEnabledSystemUIMode(SystemUiMode.manual,
        overlays: this.overlays);
    //AutoOrientation.portraitAutoMode();
    await SystemChrome.setPreferredOrientations(this.orientations);
    // AutoOrientation.portraitAutoMode();
  }

and for setOverlays i think it was correct originally
 Future<void> setOverlays(bool visible) async {
    //await SystemChrome.setPreferredOrientations(this.orientations);
    if (visible) {
      await SystemChrome.setEnabledSystemUIMode(
          edgeToedge ? SystemUiMode.edgeToEdge : SystemUiMode.immersive,
          overlays: this.overlays);
    } else {
      //print("Closed2");
      await SystemChrome.setEnabledSystemUIMode(SystemUiMode.manual,
          overlays: []);
    }
    //}
  }

and for the matter of directions of language i think it should be passed in the Video Player Constructor since not all apps use
Directionality(
     textDirection: TextDirection.ltr, /// this for support rtl Langue like Arbic

hi ,
in setDefaultOverlaysAndOrientations  i used it to return to pass orientations & edgeToEdge => 'Default' ,
in my cause , my orientations was :
 orientations: [
          DeviceOrientation.landscapeRight,
          DeviceOrientation.landscapeLeft,
          DeviceOrientation.portraitUp,
        ]

but when back from fullscreen mode  ,orientations will be only DeviceOrientation.portraitUp ,
so that i change it ,
in setOverlays when setEnabledSystemUIMode is  SystemUiMode.edgeToEdge
on FullScreen this will case show system statue bar on show player controller & this also case rebuild whole app widget tree,
so i set it to SystemUiMode.immersive to hidden  system statue bar on fullscreen when show controllers .
Directionality(
     textDirection: TextDirection.ltr, /// this for support rtl Langue like Arabic

yes you are right ,
but in my case , my app support 2 lang. Arabic & English
in English package go well
in Arabic normal screen Directionality will be TextDirection.ltr
but in fullscreen Directionality will be app TextDirection which will be TextDirection.rtl
so that i add it ,
onDoupleTap
in controls_container file , in Stack widget

i comment frist widget VideoCoreForwardAndRewindLayout
in last widget Positioned.fill
on rewind: GestureDetector( replace

onTap: () {
                  if (_.doubleTapCount.value != 0 || tappedTwice) {
                    _rewind(_);
                    tappedOnce(_, true);
                  } else {
                    tappedOnce(_, false);
                  }
                },

to
 onDoubleTap: () {
                  _rewind(_);
                  tappedOnce(_, true);
                },

and  on forward: GestureDetector( replace
onTap: () {
                  if (_.doubleTapCount.value != 0 || tappedTwice) {
                    _forward(_);
                    tappedOnce(_, true);
                  } else {
                    tappedOnce(_, false);
                  }
                },

to
onDoubleTap: () {
                  _forward(_);
                  tappedOnce(_, true);
                },

last thing , i try fitBoxs in controller it did n't work i will fix it .

in setDefaultOverlaysAndOrientations  i used it to return to pass orientations & edgeToEdge => 'Default' ,
i think making it more general and have it defined in the controller constructor is better
for this i recommend using it in the constructor of the controller to be more general
TextDirection.ltr

for the double tap part
onDoubleTap is not efficient when clicked double tapped more than once

added the needed fixes in my pull request


Use HandlerMixin in OperatorContext

Codecov Report

Merging #162 (6a9e464) into main (f821795) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   77.81%   77.89%   +0.08%
==========================================
  Files          90       90
  Lines        3282     3285       +3
  Branches      331      331
==========================================
+ Hits         2554     2559       +5
+ Misses        600      598       -2
  Partials      128      128

Impacted Files
Coverage Δ

towhee/engine/graph_context.py
100.00% <100.00%> (ø)

towhee/engine/operator_context.py
95.89% <100.00%> (-0.11%)
:arrow_down:

towhee/utils/handler_mixin.py
78.12% <100.00%> (+11.45%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f821795...6a9e464. Read the comment docs.


Not working

https://twitter.com/i/search/timeline?f=tweets&q={0}
not working this link
{'errors': [{'message': 'Sorry, that page does not exist', 'code': 34}]}

https://twitter.com/i/search/timeline?f=tweets&q={0}
not working this link
{'errors': [{'message': 'Sorry, that page does not exist', 'code': 34}]}

https://github.com/AyushiiSaxena/Get_Old_Tweets-Python
This will surely help you :)

@itsayushisaxena , the second link you provided: the solution doesnt work!

@itsayushisaxena , the second link you provided: the solution doesnt work!
@HurmetNoka please check again, it works.
https://github.com/itsayushisaxena/Get_Old_Tweets-Python
And, The below link is the solution for not older than seven days.
https://github.com/itsayushisaxena/Tweet-retrieval-for-Sentiment-Analysis

Calling out everyone for help @PetraAvramovic @vdpb20 @anishzute @parikshitghosh3 @TheRealKeyboardWarrior @libbyh @dlbt96
It seems that Jefferson is getting quieter, and the Twint project (an alternative to GOT) is facing several compatibility issues. If possible, can someone gather all the new features and support can create an active community fork of this?

There are people who rely on the API like @itsayushisaxena https://github.com/taspinar/twitterscraper
But an important caution: the API is a cruel mistress, and that users can be easily reprimanded.
The other major top alternative is https://github.com/jonbakerfish/TweetScraper

Oh also https://github.com/bisguzar/twitter-scraper exists.


Fix issue with 'circular object' written as JSON

Noticed a problem in some situations where we were getting an HTML error message. It turned out it was trying to render JSON but was failing because the object was had circular references which couldn't be serialised.

Weirdly, the PR branch seems Hppy but the push build is breaking on tests I don't get breaking locally...

@alectronic0 I just re-ran the build and now everything is green!


Pre-Activation ResNet (ResNet-V2) implementation error leads to NaN loss

Hi Kuang,
I think a batch normalization is missing after the last residual block and before the pooling/fully connected layer in the current pre-activation resnet implementation.
There should be something like  out = F.relu(self.bn(out), inplace=True) inserted there, where self.bn = nn.BatchNorm2d(512) should be define in the __init__ function, as done in other public implementations such as this one.
The current Pre-activation resnet cannot converge on CIFAR10. I tried SGD optimizer with initial learning rate 0.1 on pre-act resnet18. The loss soon goes to NaN after the first several iterations.
Fixing the codes in my proposed way leads to good convergence.
:-)
Thanks,
Haotao

It's maybe due to the fact that there are two consequent batch normalization layers.
You already have a batch normalization layer (self.bn1) after self.conv1. While in self.layer1, the self._make_layer() creates another batch normalization layer after self.bn1. Two consequent batch normalization layers easily lead NaN.
:-) Remove self.bn1 should work properly.


Deployed front-end doesn't reload to include latest data

It's unclear at this point whether this is a deployment configuration issue (and thus should be filed at seattleflu/backoffice) or something that can be fixed in this repo.
In the past couple of days, the deployed app at backoffice.seattleflu.org/switchboard has failed to update the front-end with the latest data in the sqlite database.
See this Slack thread for the steps I took to debug, as I'm unsure how much barcode/REDCap link sharing I should be doing in a public setting.

From @tsibley:

My guess is that this issue is related to how we're updating the SQLite file. Particularly if Datasette holds open file handles to it.
If we can replicate locally, then using lsof to look at the inodes the Datasette processes have open and comparing to the inode of the latest SQLite file would be helpful next time this occurs.

Reproducing locally might also be easier by running Datasette single-threaded so that test requests are sure to hit the same process/thread.
In this code:
https://github.com/seattleflu/scan-switchboard/blob/92a9a9ecbbe9e035f51821bad60fd611d79e1ade/Makefile#L6-L8
We're not updating the SQLite file in place, but replacing it with a different file.

Fortuitously, this just happened again in production. I grabbed an lsof snapshot of the Datasette process (PID reported by systemctl status scan-switchboard) and stat'd the current SQLite file.

The current SQLite file is inode 2560088, and as suspected, the Datasette threads are still holding open file descriptors for the deleted files. lsof helpfully reports this, but you can also see the inodes (last number before the file path) are different (2560067 and 2560061). They're not even consistent across threads, since the threads presumably opened the path at different times.
I think in-place updates will work if we stop re-creating/overwriting the database file everytime but instead only update it in-place via SQL commands.

Can we just update in-place via cp?
cp<EMAIL_ADDRESS>$@
rm<EMAIL_ADDRESS>

Working on this now, but wanted to say that reverting commit de07e5c42c31c3650dcf3f8e65e1a0db0cb548f7 produces the same error (of datasette pointing to a deleted sqlite file).
Same goes for @joverlee521's cp/rm suggestion, unfortunately.

If I understand @tsibley correctly, updating the sqlite file in place also results in the same error.
data/scan-redcap.sqlite: data/record-barcodes.ndjson derived-tables.sql
	sqlite-utils insert --nl $@ record_barcodes $<
	sqlite3 $@ < derived-tables.sql

Ah, my original testing process was flawed. It appears both @joverlee521's solution,
data/scan-redcap.sqlite: data/record-barcodes.ndjson derived-tables.sql
	sqlite-utils insert --nl<EMAIL_ADDRESS>record_barcodes $<
	sqlite3<EMAIL_ADDRESS>< derived-tables.sql
	cp<EMAIL_ADDRESS>$@
	rm<EMAIL_ADDRESS>
, and updating in place (my code in the previous comment) avoid Datasette threads' holding open file descriptors of deleted files.

Description of my local testing:

restart the service with systemctl restart scan-switchboard
run make -B but with a project, e.g. SCAN IRB English, removed.
run make -B again but including the project removed in #2.
see if the web app can access the newly included data

Testing with Datasette using multiple threads is likely to give misleading results, as your different requests may hit different threads which only open the SQLite file as necessary. This is why different threads in the lsof output above had different inodes opened.
Using cp instead is a good thought! But I'm wary of overwriting the entire SQLite file in-place, as that may modify other parts of the SQLite file structure behind Datasette's back and lead to other subtle issues. Depending on how the SQLite libraries handle this, it might be ok, but I don't know SQLite's guarantees here.
One option might be to leave the SQLite file itself alone and instead do the replacement atomically within SQL. That is, within a single transaction, truncate the data table before insert. I added support to sqlite-utils for this yesterday in a PR, thinking we might need it.

The num_sql_threads option to Datasette allows specifying how many Python threads are used to open the SQLite file and run queries. If I set it to 1 by:
pipenv run ./bin/serve --config num_sql_threads:1

then overwrite the file in-place with cp and make a new request, I see this error in the logs:
ERROR: conn=<sqlite3.Connection object at 0x7f27e1bfd1f0>, sql = 'select count(*) from [duplicate_record_ids]', params = None: database disk image is malformed

The num_sql_threads option to Datasette allows specifying how many Python threads are used to open the SQLite file and run queries. If I set it to 1 by:
pipenv run ./bin/serve --config num_sql_threads:1

then overwrite the file in-place with cp and make a new request, I see this error in the logs:
ERROR: conn=<sqlite3.Connection object at 0x7f27e1bfd1f0>, sql = 'select count(*) from [duplicate_record_ids]', params = None: database disk image is malformed

Hey Tom, where do you see this error? I invoked ./bin/serve with the num_sql_threads option, and I don't see that error logged in my syslog, systemctl or journalctl status outputs.

It's in the terminal output when I run
pipenv run ./bin/serve --config num_sql_threads:1


bi-directional lane connection UI

now that lane connections are uni-directional, there is a need for UI to have special code for bi-directional lanes.

Modifier-key + click creates connection in both directions. (click creates connection in both directions but modifier+click creates in one directions)
connections should have arrow heads (we can limit this to bidirectional lanes to improve performance if rendering overlays).

Note: the current lane connector tool is confused and bugged when dealing with bi-directional lanes. It feels as though it is expecting uni-directional connections. with my uni-directional fix at the back-end (#1211) , the UI is no longer confused but rather uni-directional.

Could you illustrate some situations in where this will be used? The one I can think of currently is to get some control over where a train line can reverse direction (eg. only allow direction changes at terminus stations), but not sure if that encompasses what the purpose is of directional connectors...?

lets say someone is using this bidirectional train network : https://steamcommunity.com/sharedfiles/filedetails/?id=1308307531
In would be hard to set the connections both-ways:

and also its not clear where is the start/end of each connection in cases where someone needs a one-way connection.

So that blue lane, for example, could be bi-directional for the north/south connection, and one-direction for the west/south connection?
Where would the arrow(s) appear, and what happens as the number of connections increases and arrows start overlapping each other but at slightly different rotations?

IIRC there are also some roads with bi-directional turning lanes (in NEXT2 for example)... And possibly stuff like this. So whatever solution we use for bi-directional tracks should also work on roads.

Could bi-direction connector wires be "dotted line", both while dragging and when placed? A placed bi-directional connector wire could possibly alternate between the colors of the lanes it connects (eg. blue and green). While dragging, destination colour could be transparent?
If a user places a one-way connector from A to B, and then another one-way connector from B to A, effectively creating a bi-directional link but with 2 one-way connectors, we could replace those with a single dotted bi-directional wire?
For one-way connectors coming from a bi-directional lane, the arrow could be visible at target end when source lane is selected or hovered?
We could possibly ditch the lane circles and replace with a marker that shows user what kind of lane it is? <> for bidirectional, > (pointing in relevant direction) for one-way? When 'one way' modifier held the selected source lane maker could change from <> to >, or the > part of <> could become white, to confirm 'one way' mode ?

I thought a bit more about this and I think by default, all lane connections should be bi-directional. but when the user holds the alt-key then "alternate" uni-directional mode is activated. this is because 1- ppl are already used to bi-directional lane connector 2- ppl rarely want uni-directional connections.

So that blue lane, for example, could be bi-directional for the north/south connection, and one-direction for the south/west connection?

Yes

Where would the arrow(s) appear, and what happens as the number of connections increases and arrows start overlapping each other but at slightly different rotations?

Good point! hadn't thought of that. I don't know what to do! maybe bi-directional lanes could be thicker? or maybe we could only show the arrows when the lane is selected? maybe we can show the arrows in the middle of the lane to avoid confusion with the <> idea be bellow

@aubergine10 We could possibly ditch the lane circles and replace with a marker that shows user what kind of lane it is? <> for bidirectional, > (pointing in relevant direction) for one-way? When 'one way' modifier held the selected source lane maker could change from <> to >, or the > part of <> could become white, to confirm 'one way' mode ?

very cool idea indeed!

Could bi-direction connector wires be "dotted line", both while dragging and when placed? A placed bi-directional connector wire could possibly alternate between the colors of the lanes it connects (eg. blue and green). While dragging, destination colour could be transparent?

I was hopping dotted lines would signify deleting a lane connections because since when I have enabled snapping, its not possible to tell if a connection is made (the floating line is covering up the real connection). In any case a dotted line feels weaker than a solid line and it is not intuitive that a bi-directional connection is dotted.

If a user places a one-way connector from A to B, and then another one-way connector from B to A, effectively creating a bi-directional link but with 2 one-way connectors, we could replace those with a single dotted bi-directional wire?

Yes. Currently the final wire will have a blend of color from both lanes (due to alpha blend feature). Not sure if this is a good way to represent bi-directional connections.

Copied from https://github.com/CitiesSkylinesMods/TMPE/issues/1479#issuecomment-1074485323 (might be out of context of the existing discussion in #1214 but just pasting here in case its of use):

The visualisation should clearly indicate:

Default lane routings in cases where user hasn't specified custom lane routing (feint/thin dotted white lines?)
Which lanes are bidirectional (could we overlay a double-ended arrow ↔ on the lane?)
The direction of a lane connector (pointed triangle at ends? only show where applicable to declutter UI?)

@aubergine10 @kvakvs instead of arrow heads 2/3rd if the way I was wondering maybe we could use bezier that has a different color on each side:

The fact that beziers currently have black/grey sheath around them might make things confusing, But we can get rid of those sheaths.

One more idea
Use normal vector (dot product thingy) which always points for example right. And offset 2 beziers in 2 directions which would otherwise overlap, so they are rendered side by side.

Would it be cleaner with the connector sheath borders removed?

Would it be cleaner with the connector sheath borders removed?

You mean the black borders? They are added for visibility, when rendered over a mottled background with too many varied colours, the black border adds contrast and improves visibility. How would that help?

I see. they sound important. also the grey borders tell us which ones are coming from the selected lane.


bug: PHP Warning:  implode(): Invalid arguments passed in /usr/local/www/firewall_nat_edit.php

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I have searched the existing issues and I am convinced that mine is new.

Describe the bug
A clear and concise description of what the bug is, including last known working version (if any).
When there are no Firewall Categories*, then creating or editing a NAT Port Forward rule, then going back to the Dashboard, I see this: "A problem was detected. Click here for more information." After clicking, it takes me to the System: Firmware: Reporter tool (crash_reporter.php) and it has the following under PHP Errors::
PHP Warning:  implode(): Invalid arguments passed in /usr/local/www/firewall_nat_edit.php on line 216

* Tested on a fresh install and skipped setup wizard. I did not test the case if a firewall category is added then deleted.
The Git Blame shows this functionality is extremely new, this leads me to believe this issue only applies to the latest 21.1 release:
https://github.com/opnsense/core/blame/5008929159fd62f7962956bafbec9030f62c69f9/src/www/firewall_nat_edit.php#L216
I am a PHP developer and this would be a simple code fix (Per the PHP implode docs, the second parameter should be an array.). It could be fixed in a few ways, see below (haven't tested yet). I am happy to create a PR if needed.
// PHP 5.4+ Syntax
$natent['category'] = is_array($pconfig['category']) ? implode(",",$pconfig['category']) : [];

// PHP 7+ Syntax
// Only works if $pconfig['category'] is null
$natent['category'] = implode(",",$pconfig['category'] ?? []);

To Reproduce
Steps to reproduce the behavior:

Ensure that you have no firewall categories (Firewall > Categories).
Click on Firewall > NAT > Port Forward (firewall_nat_edit.php)
Add a new Port Forward rule. Set Interface, Destination, Destination port range, Redirect target IP; the actual values shouldn't matter. Save the new rule.
Return to Lobby > Dashboard (index.php)
Ensure that you see A problem was detected. Click here for more information.. Click on the 'here' link. You should be taken to the System: Firmware: Reporter page (crash_reporter.php)
You should see PHP Warning:  implode(): Invalid arguments passed in /usr/local/www/firewall_nat_edit.php on line 216 under the PHP Errors: section of the page.

Expected behavior
I would expect to not see 'A problem was detected. Click here for more information' every time I create or edit a NAT Port Forward rule.
Describe alternatives you considered
N/A
Screenshots

Relevant log files
N/A
Additional context
I was able to produce numerous times on both bare-metal and virtual machines.
I have also verified that this has not been updated in the latest master.
Environment
Software version used and hardware type if relevant, e.g.:
FreeBSD 12.1-RELEASE-p12-HBSD #0  3c6040c7243(stable/21.1)-dirty: Mon Jan 25 12:27:52 CET 2021     root@sensey:/usr/obj/usr/src/amd64.amd64/sys/SMP amd64
OPNsense 21.1 500892915
Plugins os-dyndns-1.23
Time Sun, 31 Jan 2021 12:33:22 +0000
OpenSSL 1.1.1i  8 Dec 2020
PHP 7.3.26

https://github.com/opnsense/core/commit/34698ef09c781919aa151ed72a31804d7a0d9819 checks for existence,I really expected the empty arrays to be returned on POST, apparently their not there. thanks for reporting!


[Feature Request] Add endContent to AccorionItem

Is your feature request related to a problem? Please describe.
Add an end content in addition to start content to the accordion item for buttons and actions
Describe the solution you'd like
both start and end content for the accordion item
Describe alternatives you've considered
I've used both the title and start content to add actions to the end of the trigger
Screenshots or Videos
No response

I think this is useful to have both startContent and endContent on the accordion component,
I'm working on a PR

hi @Jlassiezzeddine, do you remember what happened with this in the end? saw a bunch of PRs that failed some checks and no further updates. did you find a workaround?


crash in ubuntu16.04 ROS kinetic

hi, i have an a3 rplidar, when roslaunch rplidar_ros view_rplidar_a3.launch, node crash.log as below:
RPLIDAR S/N: E5BB9AF2C1EA9FC3A2EB92F176683C01
[ INFO] [1534383529.782389325]: Firmware Ver: 1.24
[ INFO] [1534383529.782420782]: Hardware Rev: 6
[ INFO] [1534383529.783272236]: RPLidar health status : 0
[ INFO] [1534383530.397773691]: current scan mode: Sensitivity, max_distance: 25.0 m, Point number: 15.9K , angle_compensate: 4
[rplidarNode-2] process has died [pid 1932, exit code -7, cmd /home/gy/navigation/devel/lib/rplidar_ros/rplidarNode __name:=rplidarNode __log:=/home/gy/.ros/log/1f226ca4-a0f5-11e8-bbf6-f0421c857a46/rplidarNode-2.log].
log file: /home/gy/.ros/log/1f226ca4-a0f5-11e8-bbf6-f0421c857a46/rplidarNode-2*.log

Hi, I faced the same issue sometimes, and using catkin_make_isolated instead of catkin_make always fixed the issue.

@Piroro-hs It's worked for me too, thx~

@gongyue666  is it ok now?  which platform ,PC or arm-board？

Hello, I have a similar bug, here are the steps I ran
sudo apt-get update
sudo apt-get install ros-kinetic-rplidar-ros
roslaunch rplidar_ros rplidar_a3.launch

Here is the results:
[ INFO] [1538621877.166500709]: RPLIDAR running on ROS package rplidar_ros. SDK Version:1.7.0
RPLIDAR S/N: 96C59AF2C1EA9FC0A2EB92F105163C02
[ INFO] [1538621877.671937261]: Firmware Ver: 1.24
[ INFO] [1538621877.672055649]: Hardware Rev: 6
[ INFO] [1538621877.673490754]: RPLidar health status : 0
[ INFO] [1538621878.303578494]: current scan mode: Sensitivity, max_distance: 25.0 m, Point number: 15.9K , angle_compensate: 4
[rplidarNode-1] process has died [pid 22288, exit code -7, cmd /opt/ros/kinetic/lib/rplidar_ros/rplidarNode __name:=rplidarNode __log:=/home/rr/.ros/log/40411be2-df7a-11d4-8baf-b827eb187a25/rplidarNode-1.log].
log file: /home/rr/.ros/log/40411be2-df7a-11d4-8baf-b827eb187a25/rplidarNode-1*.log

I've tried compiling from source, and it works, this indicates that the Debian packages are not updated. My system is Intel NUC running Ubuntu 16.04
Thank you

I'm getting the same crash, both with the apt-installed package, and also with my compiled one in a vendor catkin workspace.
I finally solved it by building using catkin_make_isolated, many thanks @Piroro-hs.
$ apt show ros-kinetic-rplidar-ros
Package: ros-kinetic-rplidar-ros
Version: 1.7.0-0xenial-20180824-112159-0800

and then when running:
$ roslaunch rplidar_ros rplidar_a3.launch
[ ... ]
process[rplidar-1]: started with pid [30903]
[ INFO] [1539729453.736844593]: RPLIDAR running on ROS package rplidar_ros. SDK Version:1.7.0
RPLIDAR S/N: E6FC9AF2C1EA9FC3A2EB92F1752F3C01
[ INFO] [1539729454.241341792]: Firmware Ver: 1.24
[ INFO] [1539729454.241410282]: Hardware Rev: 6
[ INFO] [1539729454.242437629]: RPLidar health status : 0
[ INFO] [1539729454.779141734]: current scan mode: Sensitivity, max_distance: 25.0 m, Point number: 15.9K , angle_compensate: 4
[rplidar-1] process has died [pid 30903, exit code -7, cmd /opt/ros/kinetic/lib/rplidar_ros/rplidarNode __name:=rplidar __log:=/home/sorter/.ros/log/1986cd64-d0fa-11e8-9fcb-0fb7c8ec8546/rplidar-1.log].
log file: /home/sorter/.ros/log/1986cd64-d0fa-11e8-9fcb-0fb7c8ec8546/rplidar-1*.log

Thank you @neomanic ! Fixed it for me. Installing the package via apt led to the same problem. Compiling it from source using catkin_make_isolated fixed it.
I'm running ROS Kinetic under Ubuntu 16.04.

#82
[param]add param angle_compensate_multiple
Default angle_compensate_multiple(Running at 10HZ): 16K -- 4 8K -- 2 4K -- 1
angle_compensate_multiple is min(setting value, default value)

Thank you very much! Using your patch finally makes it work on Ubuntu 18.04 with kinetic!


Number of arguments to _mm_clflush()

The Intel documentation for _mm_clflush() says it should have only one parameter:
https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html#text=_mm_clflush&ig_expand=823
but the entry for _mm_clflush() in the file sse2.h says it should have two parameters, and it ignores both of them, although simde_mm_clflush does take one parameter and uses it.  I believe the fix is to make line 1356 read as
#define _mm_clflush(p) simde_mm_clflush(p)

@thomasdwu Good catch; can you send a PR with that fix? Thanks!

I'm sorry, but I don't know what a PR is.  Otherwise, I would be happy to
help.  Thanks for all of your work on SIMD everywhere, which I am using in
a software package for the bioinformatics community.
Regards,
Thomas Wu
On Sat, Apr 1, 2023 at 2:16 AM Michael R. Crusoe @.***>
wrote:

@thomasdwu https://github.com/thomasdwu Good catch; can you send a PR
with that fix? Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/simd-everywhere/simde/issues/990#issuecomment-1492889330,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABUA6S2QEKEJ466HC3CJSXDW67W7PANCNFSM6AAAAAAUZSXBCE
.
You are receiving this because you were mentioned.Message ID:
@.***>

fixed in https://github.com/simd-everywhere/simde/commit/d46f0e7b89b036712cff2c4b516798a42ba74fd3


date and datetime casting is not always recognized

Versions:

ide-helper Version: v2.12.2
Laravel Version: v8.81.0
PHP Version: 8.0.13

Description:
Carbon Date casting is not recognized if the string representation is defined for that attribute.
Laravel Documentation
Steps To Reproduce:
protected $casts = [
        'valid_from' => 'date:Y-m-d',
        'valid_until' => 'date:Y-m-d',
 ];

This results in a property mixed typehint.
@property mixed $valid_from
@property mixed $valid_until

We're open to PRs!

Same issue with datetime
    /**
     * The attributes that should be cast.
     *
     * @var array
     */
    protected $casts = [
        'start_time' => 'datetime:H:i'
    ];

This gets output as the below instead of string

@property \datetime|null $start_time

Looking at the ModelsCommand file
    case 'date':
    case 'datetime':
        $realType = $this->dateClass;
        break;

It seems to be just assuming date/datetime will be dateClass format, when a format can be supplied when defining them that turns them into strings

But it shouldn't be output as string. The property is a Carbon instance until the model gets serialized.
Then the definition takes over and the string is formated according to the definition.
But yes it also shouldn't be marked as a datetime.

It is definitely getting output as a string for me:
Class definition:
class Test extends Model
{

    /**
     * The attributes that should be cast.
     *
     * @var array
     */
    protected $casts = [
        'ddate' => 'datetime:d/m/Y',
        'start_time' => 'datetime:H:i',
    ];

Then running the below command:
 dd(\App\Models\TransportPlan\OpsClock::all()->first());
Output:

Notice in output both show as strings

Is this not because of the difference in supplying datetime vs datetime:d/m/Y

yes that is a serialization, which turns the object into a string. But in code you could do something like
$this->date->addMonth();

So you can still use the Carbon methods. Look for yourself in xdebug if it is immediately turned into a string.

So ideally then it should output Carbon|string|null ?

No it should output Carbon|null. The same as a normal date cast.
The serialization of the Carbon instance is not relevant for type hinting as in code it always will be Carbon or null.


Upgrade to Tangram 0.13

Tangram v0.13 was released "26 days ago" but released Mapzen.js still uses Tangram v0.12.
Primarily v0.13 adds curved label support for Arabic, bug fixes, and new feature that Mapzen.js wouldn't necessarily make use of right away. But it's important to keep our latest face forward.
https://github.com/mapzen/mapzen.js/blob/master/src/js/components/tangram.js#L9
/cc @bcamper

I already have an open PR for this #412, but tests are broken because our BrowserStack plan needs to be renewed, and we are working with them to get open source sponsorship. @hanbyul-here is helping with that.

closed via 5abc5aac6235726c40be06973dee087e26915214


[AutoPR datafactory/resource-manager] Swagger changes for connectors: Google AdWords, Oracle Service Cloud, OData, Rest Service, Dynamics AX and support for wildcardPath.

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4258

This PR has been merged into https://github.com/Azure/azure-sdk-for-go/pull/3063


Player list to do

https://github.com/twohoursonelife/dictator/blob/master/dictator/cogs/stats.py
Importanter:

[ ] - Run a secondary grouping check after grouping by Eve IDs to then group by Family names
[ ] - >1024 chars will break it due to message size limit (~75 living families)
[ ] - Logic to decide family name
[x] - Group unnamed families
[ ] - player_list_request needs error handling on s.connect() for ConnectionRefusedError when the server is offline, ideally also message admins when this happens
[ ]   - Function is getting too large and needs to be split

Nice to haves:

[ ] - Untangle the existing spaghetti of methods: verify... parse... process.. format...
[ ] - Actual objects/types instead of everything a string
[ ] - Reduce the number of loops

How >1024 chars break it?

The Discord side breaks, message limit of 1024 characters. Need to implement pagination or alternate solution to summarise.

Added task to run a secondary grouping after grouping by Eve ID to group by family name, this prevents excessive names showing during events or other uncommon cases where multiple Eves each name one another, resulting in them all having the same Family name but appearing in game-stats as:

Moon's analysis
https://discord.com/channels/423293333864054833/945265603093082152/1186317817709076561
So there is some spaghetti around the names in the server. It saves Lastname and (full) Name separately. A bug happens when a named mother's (EVE MOON) unnamed baby get named by somone with a different lastname (EVE BOT). Then the server has Lastname = MOON, and Name = BABY BOT.
Game-stat uses Eve ID to group families, all good
Target-family uses Lastname, can be different from the displayed name as stated above
Hetuw uses Name. And it groups families in the following way: Separate My family from others by Eve ID, then group other families by last name (extracted from Name) (so lumping unrelated families with same name)
.
OHOL changed it so that adopted babies keep biological mother's lastname (unless that mother doesn't have one at the time) (in all case Lastname will be the same as in Name), probably will get that over here.
That leaves the difference between Game-stat and Hetuw solely coming from how Hetuw groups the families -- Lumping all same-name-different-Eve families together vs not.
Target-family ignores blood relations, uses Lastname only.
So it is okay to lump all the Christmas families together then. (By this I mean, first group by Eve ID, then lump the resulting numbers together if the family name is the same)

Need to improve result when game server is offline


Update to 1.37.17 deps

@JoeRobich please review in case some of the changes should be removed because they are too small. I tried to clean up the "partial" changes related to new debugger shipping approach.


Multiple return values not parsed correctly

I've run into the following issue: multiples return values of functions are not always parsed correctly.
For example:

the return values of func notOk() (int, map[int]int) are parsed incorrectly into

(parameter_list (
  (parameter_declaration ...
     (array_type ...))    // incorrect - should have two parameter_declaration instead of one,
                          // no array_type expected, map_type expected

To reproduce:

with Go code

func ok() ([]int, map[int]int) {
    return nil, nil
}

func notOk() (int, map[int]int) {
    return 0, nil
}

inspect the tree, I use M-x treesit-explore-mode in emacs. The whole tree is pasted below.

the first function "ok" is as expected - ([]int, map[int]int) is parsed into one parameter_list with two parameter_declaration branches:

result:
   (parameter_list (
    (parameter_declaration
     type: (slice_type [ ] element: (type_identifier)))
    ,
    (parameter_declaration
     type: (map_type map [ key: (type_identifier) ] value: (type_identifier)))
))

the second function "notOk" is not parsed as expected - (int, map[int]int) is parsed into one parameter_list with one parameter_declaration branches, I expect two parameter_declaration branches.

  result:
   (parameter_list (
    (parameter_declaration name: (identifier) name: , type: (identifier)
     (array_type [ length: (identifier) ] element: (type_identifier)))
    ))

Full tree:
(source_file
 (package_clause package (package_identifier))
 \n (comment)
 (function_declaration func name: (identifier)
  parameters: (parameter_list ( ))
  result:
   (parameter_list (
    (parameter_declaration
     type: (slice_type [ ] element: (type_identifier)))
    ,
    (parameter_declaration
     type: (map_type map [ key: (type_identifier) ] value: (type_identifier)))
    ))
  body:
   (block {
    (return_statement return
     (expression_list (nil) , (nil)))
    \n }))
 \n
 (function_declaration func name: (identifier)
  parameters: (parameter_list ( ))
  result:
   (parameter_list (
    (parameter_declaration name: (identifier) name: , type: (identifier)
     (array_type [ length: (identifier) ] element: (type_identifier)))
    ))
  body:
   (block {
    (return_statement return
     (expression_list (int_literal) , (nil)))
    \n }))
 \n)

Here's a minimalistic example:

with input

func notOk() (int, map[int]int) {}

output by tree-sitter parse ...

(source_file [0, 0] - [1, 0]
  (function_declaration [0, 0] - [0, 34]
    name: (identifier [0, 5] - [0, 10])
    parameters: (parameter_list [0, 10] - [0, 12])
    result: (parameter_list [0, 13] - [0, 31]
      (parameter_declaration [0, 14] - [0, 30]
        name: (identifier [0, 14] - [0, 17])
        name: (identifier [0, 19] - [0, 22])
        type: (array_type [0, 22] - [0, 30]
          length: (identifier [0, 23] - [0, 26])
          element: (type_identifier [0, 27] - [0, 30]))))
    body: (block [0, 32] - [0, 34])))

you can see the "bad" array_type in the output

Attached is a screenshot of log.html


docs/building.md: cleaned up build instructions

Signed-off-by: Krystian Hebel<EMAIL_ADDRESS>

I guess at this point except exercising build process we cannot expect anything else, or maybe we should try disk encryption process?

Disk encryption example should work for PC, but not for nRF without #51. This is a known issue that will land in the documentation with other issues discovered by TAT, but let's focus on closing this PR first.


System.Windows.Forms.OpenFileDialog Not working

Describe the bug
Hi,
Just last week I can use the OpenFileDialog class in a WASDK/WinUI3/C# desktop app.
But now, VS 2022 17.4.4 cannot even find the assembly via using System.Windows.Forms;
Here's a sample:
using Microsoft.UI.Xaml.Controls;
using System.Windows.Forms; // <-- This used to work just the other day
namespace MySampleNamespace
{
public sealed partial class MySamplePage : Page
{
public MySamplePage()
{
this.InitializeComponent();
}
    private void ImportFileButton_Click(object sender, Microsoft.UI.Xaml.RoutedEventArgs e)
    {
        using OpenFileDialog openFileDialog = new();
        openFileDialog.InitialDirectory = "";
        openFileDialog.Filter = "Comma-Separared Files (*.csv)|*.csv";
        openFileDialog.RestoreDirectory = true;
        openFileDialog.Title = "Select CSV File";
        if (openFileDialog.ShowDialog() == DialogResult.OK)
        {
			// Some code...
		}
	}
}

}
Steps to reproduce the bug

Create a WinUI 3 C# project:

Add a XAML blank page and use the OpenFileDialog similar to the one in the description.
Build the project, you should see an error:

Expected behavior
Since the "Blank App, Packaged (WinUI 3 in Desktop)" VS 2022 project template uses C#, which is a .NET language, I should be able to use any namespace in the .NET 7 assembly or even in the .NET Windows Desktop 7 assembly.
Screenshots
No response
NuGet package version
Windows App SDK 1.2.2: 1.2.221209.1
Packaging type
Packaged (MSIX)
Windows version
Windows 11 version 22H2 (22621, 2022 Update)
IDE
Visual Studio 2022
Additional context
I have these NuGet packages installed on my project:

You must add a Reference to the right version of the DLL
For example, on  my PC , I add a Reference to :
"C:\Program Files (x86)\dotnet\shared\Microsoft.WindowsDesktop.App\6.0.13\System.Windows.Forms.dll"
And it works...


chore(deps): bump various dependencies

Description
Update various packages to the version the current master branch uses.
Highlights:

gopkg.in/square/go-jose.v2 v2.6.0 => github.com/go-jose/go-jose/v3 v3.0.3
github.com/openshift/api v0.0.0-20230815081605-d7f5a4c98505 => github.com/openshift/api v0.0.0-20231117201702-2ea16bbab164
github.com/sigstore/cosign/v2 v2.0.2 => github.com/sigstore/cosign/v2 v2.2.2
helm.sh/helm/v3 v3.13.2 => helm.sh/helm/v3 v3.14.2
k8s.io/api v0.28.3 => k8s.io/api v0.29.2
github.com/containerd/containerd v1.7.6 // indirect => github.com/containerd/containerd v1.7.11 // indirect
google.golang.org/protobuf v1.31.0 // indirect => google.golang.org/protobuf v1.33.0 // indirect

Checklist

[x] Investigated and inspected CI test results
~[ ] Unit test and regression tests added~
~[ ] Evaluated and added CHANGELOG entry if required~
~[ ] Determined and documented upgrade steps~
~[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)~

Testing Performed
Here I tell how I validated my change
If it builds, it builds
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

/retest ocp-4-11-qa-e2e-tests

I'm puzzled how come newer version of k8s.api works withoug bumping np-guard dependencies, see https://pkg.go.dev/k8s.io/client-go/kubernetes/typed/flowcontrol/v1alpha1:
→ go mod tidy
go: finding module for package k8s.io/api/flowcontrol/v1alpha1
github.com/stackrox/rox/roxctl/netpol/generate imports
	github.com/np-guard/cluster-topology-analyzer/pkg/controller imports
	github.com/openshift/api imports
	k8s.io/api/flowcontrol/v1alpha1: module k8s.io/api@latest found (v0.29.2), but does not contain package k8s.io/api/flowcontrol/v1alpha1

/retest

/retest

I'm going to close this in favor of multiple, simpler PRs


Add support for 401 and 404 error code mappings in rest proxy

Currently all the services handle 401 and 404 error code mapping to ClientAuthenticationException and ResourceNotFoundException which can be moved to rest proxy directly.

Closing as this feature added to AutoRest (https://github.com/Azure/autorest.java/pull/1268) and making this change within Core may break APIs if they were previously expecting different HttpResponseException errors to be thrown.


RE: Problem encoding "/" as %2F for path elements in request URI

I think this is possibly close to a working solution.  Three main changes are in UriBuilder.java:

I changed the 'path' type from GString to String.  I didn't understand why GString is used and I needed to check for formatting to manipulate the path value for #3 below.
Changed populateFrom() to call the uri.getRawXXX() methods for path, query, fragment and userInfo.   That way if someone created a custom URI instance with embedded encoding, it should honor their formatting.
(THIS IS THE KEY CHANGE)  Changed toURI() to create the URI using the single-argument constructor.  According to https://docs.oracle.com/javase/7/docs/api/java/net/URI.html :

The single-argument constructor requires any illegal characters in its argument to be quoted and preserves any escaped octets and other characters that are present.
The multi-argument constructors quote illegal characters as required by the components in which they appear. The percent character ('%') is always quoted by these constructors. Any other characters are preserved.

From what I can determine, if you call the 'single-argument' constructor (e.g., URI uri = new URI(myUriString);), it will honor any escaped values.  If you use the 'multi-argument' constructor currently used by UriBuilder, it will escape anything that is invalid.  This explains why the '%2F' would become "%252F".
This current attempt added the method getURIAsString() to manually build a String representation of the URI and use the single-argument constructor to create the URI instance.

I will try to take a look at this sometime this week.

@PredatorVI looks like this solution will not work. I will spend some time with it and see what I can do.

@cjstehno
@PredatorVI correctly identified the problem, it should only show up when using the multi-argument constructor. However, I don't want to start using the single argument constructor by default because it's going to cause a bunch of problems. Most people expect the correct encoding the URI class provides.
I think the solution is to provide two more properties: String rawQueryString and Boolean useRawValues. When useRawValues is set we will ignore the Map version of the query params and call the single argument constructor for URI in the toURI() method. The docs should clearly state that when useRawValues is set we will do absolutely no encoding and that all URI elements should be correctly encoded. useRawValues and rawQueryString should use the same inherit/traverse functionality as other UriBuilder elements.


I have the error with class ActionController::RoutingError which happens a lot, especially when some bots are scanning my app, and while I don't want to be spamed all the day long, I don't want to ignore ALL of the ActionController::RoutingError exceptions.
Having a before hook, juste before the excluded_exceptions array, passing the exception as a parameter would allow us to check some details about the exception, like in my case the message content using a Regex, a filter the exception with a finer granularity.
Something like:
config.opbeat.before_sending do |exception|
  if exception.message ~= /my message/
    return false # Prevent sending the exception
  end
end

Hi @zedtux! Opbeat is soon shutting down so I'm afraid there won't be put any more work into this project.
Good news is, we've moved to @elastic!  Even more good news: It does almost all of what this does and more – including this exact feature you are requesting 😄
Let me know if I can help with the transition.

Thank you @mikker for your comment.

Opbeat is soon shutting down

😨 Oh? Really? That's too bad 😞.
If I understand correctly, opbeat web platform will disappear and we have now to install the Elastic Stack in order to get the same thing?

That's correct. Soon enough Elastic APM will be available on Elastic Cloud so you won't necessarily have to set it all up yourself. But yes, right now, you need Elasticsearch, Kibana and an instance of apm-server.

OK then thank you @mikker for your comments. Meanwhile I will keep an eye on Elastic APM in the Elastic Cloud, I will search for another solution similar to Opbeat.


wombatinfo displays description after examiner name

wombatinfo displays the description at the end of the examiner section, it shouldn't do that.

no longer relevant, issue was with the old format.


Solves issue #67 along with some changes in the UI

This looks much better. This is quite a progress. A very big thank you to all contributors


Add vue-tooltipster component

I add  a new component for tooltip. It support html content as simple text content.
Also it can be trigger on hover or keep opened with a click.

sure


French translation issue #288 - Root folder translations & lesson 2.1

I implemented the suggested changes, tell me if you see other mistakes, I completed the missing translations from the root folder. Please review the as well!

Thanks @IterateMe!
@Charma95 - let me know how this looks now and if it's ready to merge.

@jimbobbennett  Yes, the translation has been reviewed and corrections have been made according to suggestions and it's now ready to merge.

Thanks @IterateMe. @Charma95 - are you happy for me to merge this?

Yes! For me, this is my first contribution to an open source project. Any hint on how to improve the value of my contribution is more than welcome!
Thank you!

Thanks for your contribution @IterateMe, C'est très bon! This is great work, and is of great value to any French speakers who want to learn IoT. I appreciate how you took on board the feedback and were happy to adhere to our format and guidelines.
Nothing extra I can thin for you to do to improve the value except keep up the great work!
Merci beaucoup!


nixos/alsa: rename sound.* to hardware.alsa.*; explicitly conflict with PW

Description of changes
The naming of sound.enable has been a source of confusion for years.
Hence we should name the options more consistently, and highlight that it is not useful in PW configurations.

nixos/alsa:

rename sound.* options to hardware.alsa.*
remove top-level with lib;
use mkEnableOption
add package option

nixos/pipewire: enforce disabling ALSA when using PW

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

We should probably just throw this module out tbh, or at least the atkbd bits need to be chopped off and put ... somewhere? I don't really know where, but it's really not the place for them.

Just for clarity, which of the following would you suggest?

All sound.* options are removed
All sound.mediaKeys.* options are removed
The media keys options are moved out of the ALSA option hierarchy (hardware.alsa.*)
The media keys options are kept in the ALSA option hierarchy, but simply physically placed in a separate module?

sound.mediaKeys needs to move to services or somewhere around there, or possibly go away entirely. The rest of this should go under hardware.alsa-save or something similar, but not hardware.alsa, because it does not actually enable ALSA, it only enables a specific quirk workaround.


coverage Delete unused function to improve test coverage

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


docs: change logImpression example to use bind

TESTING=manual

I'm closing this out.  We can see if switching to the field = () => { ... } syntax avoids the bind.  There's still some risk the transpilation impacts this (hopefully not).


Create GroupCache with builder

Summary:

simplify Groupcache configuration during creation - using builder pattern
remove a need for manual boxing of loader
keep Options as internal structure - we don't want to pass multiple parameters around

// --- Case 1 ---
// Before
let cache = Groupcache::new(socket.into(), Box::new(loader));

// After
let cache = Groupcache::builder(socket.into(), loader).build();

// --- Case 2 ---
// Before
let options = OptionsBuilder::new()
    .hot_cache(hot_cache)
    .https()
    .build();

let cache = Groupcache:: new_with_options(socket.into(), Box::new(loader));

// After
let cache = Groupcache::builder(socket.into(), loader)
    .hot_cache(hot_cache)
    .https()
    .build();

I like it <3

Codecov Report

Merging #22 (4bc6838) into main (85f23c6) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Files
Coverage Δ

groupcache/src/groupcache.rs
100.0% <100.0%> (ø)

groupcache/src/groupcache_builder.rs
100.0% <100.0%> (ø)

groupcache/src/groupcache_inner.rs
97.0% <ø> (ø)

groupcache/src/options.rs
100.0% <ø> (ø)


Script for running travis tests locally before submitting PRs

There may already be a way to do this (I hope). Seems it would be nice to check if you've broken anything before you put up the PR for people to look at.

Maybe can wrap up https://stackoverflow.com/questions/21053657/how-to-run-travis-ci-locally in a simple script?


Support customizing initialPageParam

Is your feature request related to a problem? Please describe.
The newly added Infinite Query support generates a hard-coded initialPageParam: 1. This prevents use with cursor-based or zero-indexed pagination APIs.
Describe the solution you'd like
Support customizing the initialPageParam, be it null, string, or number.
Describe alternatives you've considered
I'll have to manually define the infinite query in the meantime, utilizing the generated API client.

It should have been resolved in v1.6.1.

Hi Guys
I uses 1.6.1, if i don't set initialPageParam in cli, It sends query page param as "initialPageParam" rather then default value 1
api/customers?page=initialPageParam&limit=10&search=

Hi Guys
I uses 1.6.1, if i don't set initialPageParam in cli, It sends query page param as "initialPageParam" rather then default value 1
api/customers?page=initialPageParam&limit=10&search=
If it works like this please update the README
Thanks.

The issue is expected to be resolved in #149.


Distinguish pause from transient-solo

A site would want to disable its own set of controls when "transient-solo" happens, but if the user did a hardware pause, the site would simply want to change the pause into a play button or some such.

I think that exposing the state (idle/active/interrupted) and events for transitions between those states ought to suffice to distinguish these two cases, because if a hardware button was used the session would still be active, with the media element(s) simply being paused.

@foolip Agreed.

Closing this issue since we are moving audio focus out to a separate API.

This issue was moved to WICG/audio-focus#18


Implement IChatClient

Implement IChatClient #112
Add Async-suffix to async methods #81

@awaescher This looks superb to me!

[!IMPORTANT]
Strongly suggest considering this change to be available in a feature-branch or be a pre-release package

Currently Semantic Kernel cannot have a dependency on .Net 9 features yet, if any updates after this merges into main we won't be able to update to your connector until it becomes GA, assume any other customers that also have a hard (.Net 8 LTS) configuration will be in a same position.
SK is also adding support for IChatClient clients in a feature branch waiting the right timing to be publicly available.

https://github.com/microsoft/semantic-kernel/pull/9183

I'm not sure this is actually a problem. This change doesn't entail taking a dependency on .NET 9.
Microsoft.Extensions.AI.Abstractions is netstandard2.0 and is an out-of-band package - it's not part of the .NET 9 release. The only consequential dependency it involves is System.Text.Json, and that will be version 8, which (as of a week or so from now) will be the oldest version that is still under support anyway.

@SteveSandersonMS Thanks for the added context, would like to follow more on that info on the System.Text.Json.

Strongly suggest considering this change to be available in a feature-branch or be a pre-release package

In fact considering this as AI.Abstractions is a netstandard2.0 package but has a dependency to a preview version of System.Text.Json which is >= 9.0.0-rc.2.24473.5.
For a stable version, I'd love to have stable dependencies, too. But I guess the AI abstraction package will keep this suffix for a while, right?
There's a preview version of OllamaSharp on NuGet if anyone wants to give it a try.

For a stable version, I'd love to have stable dependencies, too. But I guess the AI abstraction package will keep this suffix for a while, right?

Yes, Microsoft.Extensions.AI.Abstractions will be in preview initially. Having working implementations of the abstraction like this is the sort of thing that gives us confidence to declare it stable later.
The System.Text.Json dependency has already been lowered to v8: https://github.com/dotnet/extensions/pull/5513/files#diff-1ea18ff65faa2ae6fed570b83747086d0317f5e4bc325064f6c14319a9c4ff67R65. You'll see this change as soon as the next preview version of the package is published (by default, this happens monthly).

You'll see this change as soon as the next preview version of the package is published (by default, this happens monthly).

Awesome. Can we get this earlier, so that I could merge and build 4.0?
@RogerBarreto: Semantic Kernel could stay at 3.x after your pull request #114 but should also be able update to 4.x right?

Published another preview version 4.0.0-preview.9 containing the latest changes from this pull-request.

@RogerBarreto: Semantic Kernel could stay at 3.x after your pull request https://github.com/awaescher/OllamaSharp/pull/114 but should also be able update to 4.x right?

You are right, we will update to the 4.0 as soon this feature branch
https://github.com/microsoft/semantic-kernel/pull/9183
Is merged in main

I guess I'll build a 4.0 as soon as Microsoft.Extensions.AI.Abstractions uses System.Text.Json in version 8.0.5.

I guess I'll build a 4.0 as soon as Microsoft.Extensions.AI.Abstractions uses System.Text.Json in version 8.0.5.

A new version is up on nuget.

Awesome, thanks @stephentoub.
So we got 4.0 out 🎉


New version of "suggest_optfile_names" script

What changes does this PR introduce?

Update script suggest_optfile_names,  done by extracting function "find_possible_optfile" from genmake2 and running it in secondary local script "find_optfile".  This covers this task from issue #855 :

bring script suggest_optfile_names up-to-date, making sure it's using same logic as in genmake2 relevant part.

Stop recognizing env. var. "ROOTDIR"  in genmake2. This is left from PR #76 (which kept ROOTDIR setting, just with a warning) when ROOTDIR was replaced by MITGCM_ROOTDIR.

What is the current behaviour?
suggest_optfile_names has not been updated since creation (on Jul 30, 2004), apart from a minor one  (in PR #76, which accidentally remove the executable permission), e.g., does not try  "gfortran" compiler.
What is the new behaviour

Updated version of  suggest_optfile_names will stay up-to-date with genmake2 (since it uses the function "find_possible_optfile" from genmake2 ).
Remove old backward compatibility feature as env.var ROOTDIR is no longer recognized by genamke2

Does this PR introduce a breaking change?
no
Other information:

when suggest_optfile_names was made (in 2004), it contained  few functions that were identical copy of genmake2 counterpart (at the time, genmake2 CVS version 1.93). This PR ensures it will stay up-to-date as it was when created.
No changes to genmake2 yet ; to follow soon.

Suggested addition to tag-index
to be filled later.

I ran the modified script on my MacBook and it gives this:
(base) bkli04m056::verification > ../tools/suggest_optfile_names
Warning: ROOTDIR was not specified ; try using a local copy of MITgcm found at ".."
-- running: './find_optfile .. find_optfile.log' :
  The platform appears to be:  darwin_arm64
  The possible FORTRAN compilers found in your path are:  gfortran mpif77
  Setting OPTFILE to: ../tools/build_options/darwin_arm64_gfortran

on a Linux box it gives this:
(base) bkli04l026::tools > ./suggest_optfile_names
Warning: ROOTDIR was not specified ; try using a local copy of MITgcm found at ".."
-- running: './find_optfile .. find_optfile.log' :
  The platform appears to be:  linux_amd64
  The possible FORTRAN compilers found in your path are:  gfortran f77 f95 mpif77
  Setting OPTFILE to: ../tools/build_options/linux_amd64_gfortran

So this look good. The -k option also does, what it is supposed to do.

@mjlosch Thanks for checking this. Now I might move forward and add 2 special comment line in genmake2 (to make this "extraction" more robust). And the removing of the ROOTDIR backward compat feature is long overdue so will go for that too.

I made little adjustments to suggest_optfile_names related to MITgcm Root-Dir, and would like to make similar changes to genmake2 and the docs:
Since "ROOTDIR" is/will not be recognized as Env.Var., but still set inside genmake2 and Makefile, to avoid confusion I suggest to not refer to MITgcm root directory as "ROOTDIR" but as something written differently, for instance "Root-Dir" (which fits reasonably well with genmake2 option "-rootdir"). Note that this does not change how any of these scripts works but just clarifies the description, comments and error message related to MITgcm Root-Dir.

the Env.Var that can be used to set MITgcm Root-Dir is "MITGCM_ROOTDIR" ;
using genmake2 option "-rootdir" one can specify the MITgcm Root-Dir  to use ;
inside genmake2, the genmake2 ROOTDIR local var is used to store the MITgcm Root-Dir location and the same for Makefile.

Any comment on this ?

@jm-c this all looks good and agree with how you have handled. However I strongly prefer incorporating @mjlosch's suggestions; the shorthand Root-Dir is confusing in that it looks like an environment variable or some other machine name.
The sentence in getting_started.rst where $MITGCM_ROOTDIR is explained is perfect.
Can we commit @mjlosch's suggestions, and I'll take another quick check and approve?

@jrscott thanks for taking a look. However, I prefer to make these changes myself as this PR is still "work-in-progress" and I have more chamges to add (genmake2 ...).

Trying to summarize where we are with this "ROOTDIR/Root-Dir":

As mentionned earlier (on Oct 16), the plan is, regarding this "Root-Dir" update,  to export to genmake2 the changes made here in suggest_optfile_names.
As it is now in this PR, I found 7 instances of "Root-Dir" in suggest_optfile_names; for 3 of them, @mjlosch and @jrscott suggested to replace "Root-Dir" with "root directory". Should I also change the 4 other "Root-Dir" ? or leave these 4 "Root-Dir" as it is?
regarding getting_started.rst,  "Root-Dir" appears 4 times, including one that is just a copy of genmake2 printed output (that will be affected by the suggested changes to "root directory" mentioned above). Should I keep getting_started.rst as this ? Should I also replace "Root-Dir" to "MITgcm root directory" ? or should I go back to master-branch version ?

Back on Oct 16 I was (a) advocating to bring more consistency, and (b) suggested to use "Root-Dir" for that. But now the same question remains: Do we want to ensure consistency when mentioning this "MITgcm root directory" ?

@mjlosch Thanks, this helps. I will proceed with these changes.

I agree with @mjlosch's suggestions.

I changed "Root-Dir" to "root directory" (or "MITgcm root directory") everywhere in comments, printed report and docs,
following suggestions from @mjlosch and @jrscott .
I  am going to import the changes from suggest_optfile_names to genmake2, as mentioned earlier.

I am done with changes here, ready for review.


what dose setCurrentVM function doing

Hey gays, I am learning the source code.
and i see the setCurrentVM uesd  in setup.ts like:
...
    let preVm = getCurrentVM();
    setCurrentVM(vm);
    try {
      binding = setup(props, ctx);
    } catch (err) {
      logError(err, vm, 'setup()');
    } finally {
      setCurrentVM(preVm);
    }
...

I not sure why here need to set the vm before call setup and reset the vm in finally section .
Can anyone help me to understand waht this is doing?
thx.

Basically, it just stores the current vm into a global variable.


Add static server for serving production files

Did you test the deploy and server boot on Heroku? From what I remember, Heroku by default looks for a procfile or the start script referenced in a package.json file to do booting. Are you instead handling this through gulp via the postinstall hook?

Yeah, it gets started through a gulp task, via the postinstall hook. It wasn't successful though due to how I had Karma set up. It's looking for Chrome to run tests. Nate said he could show me how he was running tests with Travis CI.

Gonna close this until I get that worked out.


Expose sign function taking committed message vector

The new function, SignWithKeyB signs a pre-generated b term.

Thanks @yacovm I've addressed all your comments


Fixing wrong boolean check for container checkboxes

Fixes the checkboxes in the container settings:

mesosphere-ci Retest this please

Looks good! 🚢  ✨

run integration tests


Separate CURLOPT_SSL_VERIFYPEER and CURLOPT_SSL_VERIFYHOST

danger_allow_unsafe_ssl currently disables both options.
It's better to separate these options for some use cases e.g. an internal security testing tool that separately checks for hostname mismatches and trust failures.

Fixed by #128.


More Doxygen comment improvements.

Some additional Doxygen fixes, as per #11022.

No significant performance differences

No significant performance differences

No significant performance differences


⚠ Bofrost.at has degraded performance

In c81fdf1, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1490 ms

Resolved: Bofrost.at performance has improved in 83efab2 after 6 minutes.


Downloaded images not working on previews

I have set Prismic images to download in gatsby-config.js using the follwing option:
shouldDownloadImage: ({ node, key, value }) => {
    return true;
},

I have done this so my Prismic bandwidth doesn't get blown out serving images to users. It has been working thus far using a graphQL query like this to grab a local image URL:
tile_image {
    localFile {
	publicURL
    }
}

The problem lies when I try to preview a page. The page does not render and the following error is shown in the console:
TypeError: Cannot read property 'publicURL' of undefined

Can I not use downloaded images with previews?

Hey @mcmurter !
I believe this page of the documentation should be helpful:
https://github.com/angeloashmore/gatsby-source-prismic/blob/master/docs/previews-api.md#using-locally-transformed-images
We are in the same boat here, so please just write, if you encounter an issue.

Hey @mcmurter !
I believe this page of the documentation should be helpful:
https://github.com/angeloashmore/gatsby-source-prismic/blob/master/docs/previews-api.md#using-locally-transformed-images
We are in the same boat here, so please just write, if you encounter an issue.

Heads up:

You will have to be careful with this piece of code, as it doesn't include a default export, which means that importing the component like this
Component from '../path/file'
will give you problems as it imports the export 'Component' whereas
{ Component } from '../path/file'
imports the default export of the file.
You could of course also simply make it the default export like so:

Another thing the documentation is not mentioning is how to handle the component throwing an "localFile undefined" error, so you will have to add a ternary check, set the props via assignment or something similar:

Hope that helps!

Heads up:

You will have to be careful with this piece of code, as it doesn't include a default export, which means that importing the component like this
Component from '../path/file'
will give you problems as it imports the export 'Component' whereas
{ Component } from '../path/file'
imports the default export of the file.
You could of course also simply make it the default export like so:

Another thing the documentation is not mentioning is how to handle the component throwing an "localFile undefined" error, so you will have to add a ternary check, set the props via assignment or something similar:

Hope that helps!


Storage: LVM snapshot parsing improvements

Adds LVM volume name parser similar to ceph's parseParent function.
The intention is to more thoroughly parse LVM volume names to avoid issues like  https://github.com/lxc/lxd/issues/7335.

@stgraber when we come to add custom block volumes we are going to have to deal with the possibility of naming conflicts between non-block-custom volumes that ends with ".block"  - which is currently allowed.
E.g.
lxc storage volume create lvm test.block
lvs
custom_default_test.block

Which will be indistinguishable from a block custom volume called "test".

I've discovered some more issues with LVM parsing not addressed by this PR so please don't merge yet.
Naming snapshots ending in ".block" is possible and results in the parser returning the wrong content type.

Testsuite passed

Testsuite passed

@stgraber ready for review.

Testsuite passed


Data retrieved from powershell can be huge (and time consuming)

Hello
On Windows since wmic has been replaced with powershell some calls take a lot of time.
Selecting only the actually used data seems to reduce that time a lot.
calling:
si.processes()
with wmi:
0.5 second
0.5 MB of data
with powershell:
5 seconds
1 MB of data
Can be checked by just running both commands in a prompt
wmic process get /value > wmic.txt
=> quick
powershell "Get-WmiObject Win32_Process | fl *" > ps.txt
=> takes ages
instead of getting everything:
util.powerShell('Get-WmiObject Win32_Process | fl *').then((stdout, error) => {
I tested with
const fields = [ 'ProcessId', 'ParentProcessId', 'ExecutionState', 'Caption', 'CommandLine', 'ExecutablePath', 'UserModeTime', 'KernelModeTime', 'WorkingSetSize', 'Priority', 'PageFileUsage', 'CreationDate' ];
util.powerShell('Get-WmiObject Win32_Process | select ' + fields.join(',')).then((stdout, error) => {
=>
1.6 seconds
0.2 MB of data
Still not as good as before, but still :-)
I guess the same applies to some extent to other powershell calls as well.

@xavier-deryckere thats a good finding. Will think of reducing the needed columns!
The second problem is, that spinnig up powershell is quite intense ... so there is (currently undocumented - still in progress of improving it) another option to start up powershell only once. To enable this you need to run su.powehShellStart() before running your commands and then at the end si.powerShellRelease() ... see also #616
But maybe you already have seen that ;-)

Yes I have seen that but did not try.
I just did try powerShellStart/powerShellRelease, and the results are only slightly better (5+ seconds -> 4.6/4.7 seconds).
I guess the amount of data has more impact than process spawning.

@xavier-deryckere ... only when having multiple calls, than I experienced much better numbers but you are right, the amount of data is something I will have a look on! Thank you so much.

@xavier-deryckere ... thank you once again. I now reduces all data retrieved from powerShell commands to the minimum and I see on my windows machines good improvements in the speed of

processes()
processLoad()
printer()
services()
versions()
users()

Version 5.11.2 just released. Thank you once again!


Type refactoring (ApiRequest/DbRequest)

I refactored the types.
Looks a bit better to me but had to split Query data type in two because otherwise it would have a few incomplete pattern matches in functions.
In some places i added "undefined" for patterns that should not normally happen. Maybe someone has a better idea, but at least it signals it's a "bad" branch that should not be reached

I like the Intent name more than ApiRequest. We aren't really “requesting” anything in PostgREST, but rather translating to SQL.

@calebmer Don't we use an API to request against Http ? To me Intent sounds vague enough.
This is just from a million miles above as I haven't had the time to look/browse/appreciate the code much. Please take my comment with a grain of salt ;-)

We were discussing having ApiRequest for the http things the client sends us, and translate it into a DbRequest. The DbRequest is turned into raw sql when it's time to do the work. Just a parity between the names.


add missing RU translation entry

Looks like translation for python.snippet.launch.standard.label was missing
For #

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[ ] Has a news entry file (remember to thank yourself!)
[ ] Unit tests & system/integration tests are added/updated
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)

Thanks!


Add evidenced_by() function that returns evidence associated with a piece of Data

Right now, to get the evidence associated with an object in the db we have to do something like in the query_context.py example
or in EvidenceCoverageTest.py which are both kind of clunky.
The proposed function would return the evidence associated with a piece of data like so:
n = Neuron(name='AVAL').innexin('UNC-7')
evidence_for_n = evidence(n)

which would return all evidence in all contexts of the configured RDF graph which assert all of the statements for all of the simple properties (i.e., none of the special properties like neuron.Neighbor) of the n.
For more complex statements, we should have a similar function for recovering evidence attached to a context:
c = Context()
n0 = c(Neuron)(name='AVAL')
n0.innexin('UNC-7')
ch = c(Channel)(name='EGL-9')
ch.expression_pattern(...)
...
evidence_for_all_statements_in_c = evidence(c)

attempting to solve in #254 !

Closing as a duplicate of #254 -- that one has more work attached to it.


update to spec 9381

⚠ THIS PR CONTAINS BREAKING CHANGES AND SHOULD BE MERGED ASAP ⚠
This app supports specs 9370 and 9381.
BREAKING CHANGES from spec 9370 to 9381:

polkadotXcm: v0 and v1 has been deprecated in favour of v2 and v3
authorship: this pallet has been removed
xcmpQueue, dmpQueue: now this pallets use Weight instead of XcmWeight

Changes:

polkadotXcm: support teleportAssets and teleportAssetsLimited
proxy: methods createPure and killPure now support nesting

Other changes:

Version some types to support xcm v0 and v1 in spec 9370
Zemu tests are now concurrent
Change build system to support Ledger unified sdk

Still missing to check OptionChargeIdOf type, do not merge yet

@ftheirs this can be reviewed!


Multiplying by one doesn't do anything

Save a bit of cpu
Verification [](Explain how you tested the refactor for regressions.)
x * 1 = x

In dyn_ss_sol, may also consider using numpy.linalg.lstsq instead of numpy.linalg.solve to solve the linear equation. lstsq is more efficient and numerically stable, especially when dealing with ill-conditioned matrices.

Verification [](Explain how you tested the refactor for regressions.)
x * 1 = x

I'm guessing x*0.1 is used to force floating point arithmetic. The correct verification should be:
x * 1 / n = x *1.0 / n


fix: lock sharp version

Locks the Sharp library version to a Node.js v8 compatible version.
See https://github.com/firebase/extensions/pull/278 for details

Thanks @Salakar !


fontforge-fonttools: Install all tools

Motivation for this change
Since CMake port, the contrib files are not installed. Let's use a Debian patch to install them.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@ofborg eval

Result of nixpkgs-review pr 118586 at a05508c1 run on x86_64-linux 1

651 packages marked as broken and skipped:

adobe-reader
adoptopenjdk-hotspot-bin-13
adoptopenjdk-hotspot-bin-14
adoptopenjdk-jre-hotspot-bin-13
adoptopenjdk-jre-hotspot-bin-14
adoptopenjdk-jre-openj9-bin-13
adoptopenjdk-jre-openj9-bin-14
adoptopenjdk-openj9-bin-13
adoptopenjdk-openj9-bin-14
agdaPackages.iowa-stdlib
...

8771 packages skipped due to time constraints:

AusweisApp2
DisnixWebService
EmptyEpsilon
Fabric (python38Packages.Fabric)
MIDIVisualizer
OSCAR
OVMF
OVMF-CSM
OVMF-secureBoot
R
...

46 packages built successfully:

SDL2
asciidoctor
at-spi2-atk
at-spi2-core
atk (gnome2.atk ,gnome3.atk)
cairo (gnome2.cairo)
dejavu_fonts
epoxy
fontconfig
fontforge (fontforge-fonttools ,python38Packages.fontforge)
freeglut
gd
gdk-pixbuf
libsoup (gnome2.libsoup)
pango (gnome2.pango)
gobject-introspection (gnome3.gobject-introspection)
gsettings-desktop-schemas (gnome3.gsettings-desktop-schemas)
libgudev (gnome3.libgudev)
tracker (gnome3.tracker)
harfbuzz
json-glib
libGL
libGLU (mesa_glu)
libass
libdevil
liberation_ttf_v1
libmanette
libmbim
libnotify
libqrtr-glib
libva
libva-minimal
mesa
perl532Packages.X11Protocol
python38Packages.dbus-python
python38Packages.pycairo
python38Packages.pygobject3
python39Packages.fontforge
tesseract (tesseract3)
tix
tk (tk-8_6)
vulkan-loader
wayland
wayland-protocols
xlibsWrapper (xorg.xlibsWrapper)
xorg.libXft

2 suggestions:

warning: unused-argument
Unused argument: perl.
Near pkgs/tools/misc/fontforge/default.nix:2:10:
  |
2 | , cmake, perl, uthash, pkg-config, gettext
  |          ^

warning: unused-argument
Unused argument: gettext.
Near pkgs/tools/misc/fontforge/default.nix:2:36:
  |
2 | , cmake, perl, uthash, pkg-config, gettext
  |                                    ^

/rebase staging

I asked about it upstream.


PHP: sample_code_init_fields not used for optional arguments

See for example in this PR, the parameter was made optional, and the init fields are excluded from the sample.
cc @ethanbao If other languages are found to be affected, we can expand the scope of this issue

@michaelbausor Can you add a priority?


WindFree Switch doesn't work

Describe The Bug:

If I check the WindFree mode switch in Apple Home, it says it doesn't respond. My Samsung AC model is AF16M7970GFN. Is this have different api call preference?
To Reproduce:

Expected behavior:

Logs:
This plugin threw an error from the characteristic 'On': Unhandled error thrown inside read handler for characteristic: Cannot read properties of undefined (reading 'acOptionalMode'). See https://homebridge.io/w/JtMGR for more info.

This log continuously appears.
Plugin Config:
{
    "name": "AC",
    "BaseURL": "https://api.smartthings.com/v1/",
    "AccessToken": "xxx-xxx-xxx-xxx-xxxx",
    "OptionalWindFreeSwitch": true,
    "platform": "Homebridge Samsung WindFree AC"
}

Screenshots:

Environment:

Plugin Version: v1.0.4
Homebridge Version: v1.8.2
Node.js Version: v18.19.0
NPM Version: v10.2.3
Operating System: Raspbian

This model is not supported. Maybe there's a different custom capability for windFree mode.


Hardcoded RPC retry schedule should be dynamic

Hello, as of right now the rpc retry schedule is hardcoded.
constructor(options: RpcClientOptions) {
        this.url = trimCredentials(options.url)
        this.con = this.createConnection(options.url)
        this.maxBatchCallSize = options.maxBatchCallSize ?? Number.MAX_SAFE_INTEGER
        this.capacity = options.capacity ?? 10
        this.requestTimeout = options.requestTimeout ?? 0
        this.retryAttempts = options.retryAttempts ?? 0
        this.retrySchedule = options.retrySchedule ?? [10, 100, 500, 2000, 10000, 20000] // HERE!

     // .....
    }

I would like to incorporate this option into the RpcChain config so it can be dynamically set. I am willing to fork the repo, implement the change and open up a PR to be merged in. Would the team be interested in this?

Not really...

Alright, allowing retrySchedule(attempt: number, reason: Error): number will not harm, I guess...

I will implement this soon and submit PR. Please keep this open, thank you @eldargab


[$250] Hybrid - Android - Expense - On holding&unholding second expense in workspace chat, reports page crashes.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.78-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No
Issue reported by: Applause Internal Team
Device used: Redmi note 10s Android 13
App Component: Money Requests
Action Performed:

Launch app
Login with any account
Go to workspace settings - workspace chat
Create an expense
Open the expense - header - hold the expense and unhold the expense
Navigate to LHN-- reports
Note reports page open correctly
Open workspace chat
Create another expense
Open second expense - hold and unhold the expense
Navigate to LHN -- reports

Expected Result:
On holding&unholding second expense in workspace chat, reports page must not crash.
Actual Result:
On holding&unholding second expense in workspace chat, reports page crashes.
Workaround:
Unknown
Platforms:

[ ] Android: Standalone
[x] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Bug6701999_1735113811053!Crash.txt
https://github.com/user-attachments/assets/3b45528e-b082-4d0d-8557-f071846bdfff
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021871960620990473805
Upwork Job ID:<PHONE_NUMBER>990473805
Last Price Increase: 2024-12-25

Issue OwnerCurrent Issue Owner: @Ollyws

Proposal
Please re-state the problem that we are trying to solve in this issue.
On holding&unholding second expense in workspace chat, reports page crashes.
What is the root cause of that problem?
Item.transactions can be undefined but it's required in ReportListItemType type
https://github.com/Expensify/App/blob/918488aa5586be249f392b26692572aaba010f31/src/components/SelectionList/types.ts#L267
Then the app crashes here and no ts error.
https://github.com/Expensify/App/blob/918488aa5586be249f392b26692572aaba010f31/src/components/Search/index.tsx#L93

What changes do you think we should make in order to solve the problem?
We should change transactions here to optional and then fix all errors that use .transactions without optional chaining
transactions: TransactionListItemType[];

https://github.com/Expensify/App/blob/918488aa5586be249f392b26692572aaba010f31/src/components/SelectionList/types.ts#L267

Note: if we only fix optional chaining here without update ReportListItemType and fix all instances, the app still crashes
https://github.com/Expensify/App/blob/918488aa5586be249f392b26692572aaba010f31/src/components/Search/index.tsx#L93

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Proposal
Please re-state the problem that we are trying to solve in this issue.
After upholding an expense, opening a search page will crash.
What is the root cause of that problem?
The crash happens because the item here doesn't have the transactions property and if we check it, the item only has canHold and canUnhold.
https://github.com/Expensify/App/blob/918488aa5586be249f392b26692572aaba010f31/src/components/Search/index.tsx#L89-L95
Why? When we unhold the request, we will optimistically update the search snapshot data by merging the canHold and canUnhold data. It's supposed to be updated only when we do it from the search report RHP.
https://github.com/Expensify/App/blob/918488aa5586be249f392b26692572aaba010f31/src/libs/actions/IOU.ts#L8450-L8463
But in our case, even when doing it from the normal report screen, the snapshot is still updated and because the 2nd transaction that we unhold is never loaded on the search snapshot yet, the item only contains canHold and canUnhold properties.
Btw, even if the expense/transaction is loaded, it won't have transactions property either. It's only available if it's a REPORT type. That's why we "check the type" first here.
https://github.com/Expensify/App/blob/918488aa5586be249f392b26692572aaba010f31/src/components/Search/index.tsx#L87-L94
When we press the unhold, the function we already check first whether the topmost central pane is search page or not. If it's not, we won't pass the currentSearchHash (from the search context).
https://github.com/Expensify/App/blob/918488aa5586be249f392b26692572aaba010f31/src/components/PromotedActionsBar.tsx#L98-L103
But we only do it if we are doing a HOLD. So, if it's unhold, we always pass the search hash.
What changes do you think we should make in order to solve the problem?

To solve this, we need to remove isTextHold from here so it's applied for both hold and unhold.
https://github.com/Expensify/App/blob/918488aa5586be249f392b26692572aaba010f31/src/components/PromotedActionsBar.tsx#L98-L101
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can test PromotedActionsBar.hold directly and test 2 cases, 1 when the topmost central pane is a search report RHP and 1 when the topmost central pane is a search report central pane.
What alternative solutions did you explore? (Optional)
We can probably merge all the transaction data, but it's not preferable since they have different kinds of data too, such as action.
https://github.com/Expensify/App/blob/918488aa5586be249f392b26692572aaba010f31/src/libs/actions/IOU.ts#L8450-L8463


Use ts-bridge as build tool, set moduleResolution to NodeNext

Explanation

Same update made to @metamask/utils: https://github.com/MetaMask/utils/pull/182

References

Required to update core repo's moduleResolution setting to NodeNext:

Blocks: https://github.com/MetaMask/core/issues/3651

Changelog
Added

Newly exports the following types: AnyStruct, EnumSchema, InferStructTuple, IsExactMatch, IsMatch, IsRecord, IsTuple, ObjectSchema, OmitBy, Optionalize, PickBy, Simplify, UnionToIntersection.

I removed the "type": "module" field in package.json for now. There was an ESM-only dependency (lodash-es) that was causing an error so I just replaced it with lodash.


local GPU/hardware requirements

Does anyone have a rule of thumb for what size local GPU can be used to fine-tune with proprietary data? Or, is there another way to speed up the training that I'm not aware of?
I'm fine-tuning a multiclass text classifier on NVIDIA GeForce GTX 1660 SUPER 6GB. obviously not a powerful GPU but I'm not against upgrading to a more powerful unit.
It just takes a while to fine-tune.
my training params are as follows:
Num examples = 15365720
Num epochs = 1
Total optimization steps = 320120
Total train batch size = 48
code:
from setfit import SetFitModel, SetFitTrainer
from sentence_transformers.losses import CosineSimilarityLoss
Load a SetFit model from Hub
model_id = "sentence-transformers/paraphrase-mpnet-base-v2"
model = SetFitModel.from_pretrained(model_id)
Create trainer
trainer = SetFitTrainer(
model=model,
train_dataset=train_ds,
eval_dataset=eval_ds,
loss_class=CosineSimilarityLoss,
metric="accuracy",
batch_size=48,
num_iterations=20, # The number of text pairs to generate for contrastive learning
num_epochs=1, # The number of epochs to use for constrastive learning
column_mapping={"line_text": "text", "label": "label"}
)
#Train
trainer.train()

Hello!
@kgourgou is exactly right, and I second his recommendation.
You can use this:
from setfit import sample_dataset

# Load your dataset
dataset = load_dataset(...)

# Simulate the few-shot regime by sampling 8 examples per class
train_dataset = sample_dataset(dataset["train"], label_column="label", num_samples=8)

This also automatically gives you an even distribution of classes, should you be interested in that.
With sufficient data, finetuning a model using 🤗 Transformers tends to outperform SetFit. See for example this image:

The finetuned model on the full dataset outperformed SetFit here. With other words, you may want to consider that option.

Tom Aarsen

yep you are both absolutely right! thank you for the suggestions

Good luck!


Create a bundleResources convenience method that return all resources of a bundle.

e.g. _.compact(bundle.entry?.map((x) => x.resource) || [])

Could it be possible to have a bit more content here please?


Reduces Ninja suit's resistances.

About the PR

Changes ninja suit's resistances from 0.6 to 0.8.
Why / Balance

Ninja is meant to be stealthy and non-confrontational, but his suit has resistances almost on par with a blood-red hardsuit.
Sneaky man should not have combat-level resistances. This should encourage ninjas to play stealthy and not just try to kill everyone, as they're meant to.
Technical details

Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

ninja already gets nuked by someone magdumping this isnt needed

They shouldn't be getting into gun fights, this is fine to me. I think Ninja should be balanced around movement, melee and ability to absolutely murder people who are alone.


Font Awesome brand icon not showing

Describe the bug
Font Awesome brand icon not showing

To Reproduce
OK
OK
NG
NG

If a class starting with icon- is specified, the font face will be fixed to "Font Awesome 5 Free"
https://github.com/open-admin-org/open-admin/blob/v1.0.26/resources/assets/open-admin/scss/fontawesome.scss#L6-L40
Expected behavior
A brands icon is displayed
System

Open-admin version

v1.0.26

PHP version

PHP/8.2.3

Laravel Version

10.1.5

OS:

Linux

Browser

chrome

@hrs-o thanks for reporting, now fixed in v1.0.27
you can add fab & fas in front of icon-


Corrected the path

Description
Corrected the path to homepage from the 404.html
Fixes:  #466

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

@sk66641 @aditya-bhaumik please checkout this pr.

@VijaySamant4368 hi i already told you before not to create pull request before getting your issue assigned check the contributing.md for more details
I have already given you one warning so please wait for your issue to be assigned then create a pr
I am closing this pr


React capstone project - Metrics webapp

[ ] In this branch, I:
Used React documentation.
Used React components.
Used React props.
Used React Router.
Connected React and Redux.
Handled events in a React app.
Wrote integration tests with a React testing library.
Used styles in a React app.
Used React life cycle methods.
Applied React best practices and language style guides in code.
Used store, actions, and reducers in React.

Hi @zhorabay ,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request

[ ] You have submitted a project, that doesn't follow the correct Gitlow,
For group capstone projects the correct flow for requesting reviews is GitHub flow which means dev merging to main.
For solo capstone projects the flow for requesting reviews is Gitlow which means feature branch merging to dev. Kindly do so

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.


apache/skywalking-oap-server:7.0.0-es7------bug

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Bug

Bug

Which version of SkyWalking, OS and JRE?
apache/skywalking-oap-server:7.0.0-es7
What happen?

[Entrypoint] Apache SkyWalking Docker Image
Current image doesn't Elasticsearch 6

Elasticsearch vsersion is docker.elastic.co/elasticsearch/elasticsearch:7.6.2

Read document and use correct parameter. Should be elasticsearch7.

got same issue
have es 7.4.2 running
started with apache/skywalking-oap-server:8.1.0-es7  image
and got below logs, the service not got really started

You are using wrong image. ES6 and ES7 are mapping 2 images.

$ docker run --name oap --restart always -d -e SW_STORAGE=elasticsearc7 -e SW_STORAGE_ES_CLUSTER_NODES=es.my.local:9200 apache/skywalking-oap-server:8.1.0-es7
anything wrong?

Could you be more careful? elasticsearc7 really?

that was typo


Revert "Perform init before tflint in presubmit action"

Reverts ppc64le-cloud/test-infra#176

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: yussufsh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

config/jobs/ocp-automation/OWNERS [yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/cc @mkumatag
The container does not container terraform binary which I should have known before. We will have to fix the modules testing by some other way.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mkumatag, yussufsh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

config/jobs/ocp-automation/OWNERS [mkumatag,yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yussufsh: Updated the job-config configmap in namespace prow at cluster default using the following files:

key ocp4-upi-powervs-presubmit.yaml using file config/jobs/ocp-automation/ocp4-upi-powervs/ocp4-upi-powervs-presubmit.yaml

In response to this:

Reverts ppc64le-cloud/test-infra#176

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Webhook based triggers for incoming service connection do not work if JSON Path returns an array/object

I'm implementing a solution where an incoming service connection is used in ADO, and a JSON object is being passed to it via a webhook from GitHub with pull request information.
Problem:

If the JSON payload path results in an array or an object, the pipeline silently fails and stops the incoming webhook from triggering my build at all, which is not reasoned or listed anywhere, but found through trial and error. This does not happen if the result from the JSON path is a single value.

Steps to Reproduce:

Create a simple yaml Azure Devops pipeline that uses a webhook resource to trigger the build with a filter for closed PR only. (Though I suppose it doesn't matter here)
Create incoming service connection in ADO.
Configure Github webhook that sends pull_request events to this endpoint.
To see the issue, reference the object as:

pr_labels: '${{ parameters.GithubPRClosed.pull_request.url }}' which will work as it is a single value - pipeline runs will be triggered.
pr_labels: '${{ parameters.GithubPRClosed.pull_request.labels }} which will NOT work as the value is an array, pipeline runs will no longer be triggered.
pr_labels: '${{ parameters.GithubPRClosed.pull_request }} which will NOT work as the value is an object, pipeline runs will no longer be triggered.

AFAIK I haven't missed anything obvious here, but please correct me if I have, as I've been working through all the other finicky issues with incoming service connections in ADO to get to this point.

@reespozzi -- Rees,  thank you for your thorough feedback.  This repo is solely for documentation issues, and this seems product-related.  Please add it here:

Developer Community

I am closing this issue now.  You are welcome to @ mention me for any followup.  We hope to hear from you again.

@WilliamAntonRohm Hi - thanks for your response. I believe there's still some value to be added to the docs here. I got a reply in the developer community that when wishing to access anything other than a simple value from the incoming webhook, i.e an object or an array, I should use convertToJson.
That resolved my particular issues, but the underlying problem remains I think - there is no documentation nor error within Azure DevOps to tell you this is an issue, the pipeline simply stops triggering, I only found out through trial and error. This is an obvious solution to the problem, once you know what's happening behind the scenes.
A one line addition to the documentation that the pipeline will not respond to incoming webhooks if you are attempting to access a JSON path that returns a complex object would help in my opinion and save time for others in the future.
Is there an FAQ / Troubleshooting guide this could be added into?

@WilliamAntonRohm just pinging again for visibility

@Sid-ah, @chcomley -- Sidi or Chrystal, could you help with the documentation aspect here, or recommend someone who might?

@ramrajesh can you help direct us to a SME please?

#assign:@ramrajesh

Thanks for your feedback! We've moved this issue to our internal tracking system as we transition to a new feedback system.