[Suggestion] Body Part Compatibility / Scaling With Extra HP

It seems that trinkets that add more hp or just mods in general that can give you extra hp dont scale with / add to your body health so even when you have 5 extra hearts, taking 4 damage from fall damage for example; will still break your legs even though you should have more heart points into that category. This should also be the case with the absorption effect, spreading out evenly onto different body parts based on the golden hearts applied to your character.
Each additional heart should spread out with a priority list of head>chest>arms>legs (configurable, such as head>arms>legs>chest if you wanted to supply heart points to the weakest body parts first). Half hearts should still try to be calculated, so smaller health buffs can still feel useful. If there are not enough hearts to spread out, even with half hearts, it will just spread what it can on the prioritized body parts first until you get more hearts.

Hey, thank you for your sugestion.
The extra HP is something I completely forgot, even when Minecraft has its own Health Boost effect.
The priority list is a good idea but to facilitate the creation of new parts( when the api is ready ) I think I will add a configurable priority number to each part and apply the additional hearts from higher to lower priority.
However, I do not think absorption should apply to the parts, I see it more as a "magical shield" than extra HP.


Increment version for storage releases

Increment package version after release of azure-storage-blob

Will do manually for GA release.


Ported to Android

Upgraded example project to React 0.20.0

Hi Bart,
I ported your component to React Native for Android.
Should work on React Native 0.20.0 onwards, the example behaves and looks exactly the same as on iOS.
The solution looks a bit hacky because:

Android does not support strokeDash, so I had to draw a correct circle segment.
ART does not support drawing arbitrary circle segments (seems to be limited to half circles), so I had to fall back to using internal drawing primitives.
Also, the Android version of ART behaves differently (buggy?) than the IOS one, so I had to use platform specific code.

Hey Gunter, this looks really good! Have you tested it on iOS as well?

Yes, side by side, Looked exactly the same.

Awesome!


decode_view from pct_string_view

decode_view should only be constructible from pct_string_view and the Exception Safety and @throw clauses should match.

Should probably store pct_string_view as a data member too, since it already knows the decoded size.

The implicit conversions are making this very difficult to achieve.

decode_view pct_string_view::decoded() and decode_view pct_string_view::operator*() make a new decoded_view::decoded_view(pct_string_view) constructor a circular dependency.
A new explicit pct_string_view::operator decode_view() const noexcept conversion doesn't work because it's ambiguous with the other constructors.

That's the output in the first case:
/boost/libs/url/test/unit/decode.cpp:12:
/boost/libs/url/include/boost/url/decode.hpp:16:
/boost/libs/url/include/boost/url/decode_view.hpp:16:
/boost/libs/url/include/boost/url/pct_string_view.hpp:343:5: error: unknown type name 'decode_view'
    decode_view
    ^
/boost/libs/url/include/boost/url/pct_string_view.hpp:362:5: error: unknown type name 'decode_view'
    decode_view
    ^
/boost/libs/url/include/boost/url/pct_string_view.hpp:347:24: error: no member named 'make_decode_view' in namespace 'boost::urls::detail'
        return detail::make_decode_view(
               ~~~~~~~~^

That's the output in the second case:
/boost/libs/url/test/unit/pct_string_view.cpp:273:21: error: call to constructor of 'boost::urls::decode_view' is ambiguous
        decode_view d( str );
                    ^  ~~~
/boost/libs/url/include/boost/url/decode_view.hpp:71:7: note: candidate constructor (the implicit move constructor)
class decode_view
      ^
/boost/libs/url/include/boost/url/decode_view.hpp:71:7: note: candidate constructor (the implicit copy constructor)
/boost/libs/url/include/boost/url/decode_view.hpp:194:5: note: candidate constructor
    decode_view(
    ^

wut


[BUG] memory.setClanTag()

I made a button that sets a custom clantag like "GOTV" but after the match is finish the clantag disappears.

Still having it.

It is normal behaviour - clan tag must be set again after server change.


[Enhancement] Added support for handling HTTP header "Retry-After" for throttling

Description

Switched from retry to tenacity library for retry logic (it is a little more actively in terms of development activity)
Added support for handling of "Retry-After" HTTP header to set the wait during retry logic.

Issues Fixed or Closed

Fixes 429 errors that can occur due to throttling on sites like ThePosterDB

Type of Change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[] New feature (non-breaking change which adds functionality)
[] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[] Documentation change (non-code changes affecting only the wiki)
[] Infrastructure change (changes related to the github repo, build process, or the like)

im not opposed to this but youre branch is significantly behind nightly so rebase your changes on top of the current nightly

also retry_if_http_429_error and wait_for_retry_after_header will never trigger as it use the requests module which doesnt throw the HTTPError so those have no error to catch and activate

im not opposed to this but your branch is significantly behind nightly so rebase your changes on top of the current nightly

Interesting -- I did a merge just before committing this one.  I'll do another later today.

ao ive closed this as just the change from retry to tenacity then in a future PR we can work on the HTTP 429 Errors

ao ive closed this as just the change from retry to tenacity then in a future PR we can work on the HTTP 429 Errors

I'll rebaseline and look at the changes.  In my local testing it did result in a substantial drop in 429 errors when using theposterdb.  I think it is because I am also caching locally (which would make sense).


Add support for node and browserify

This PR adds minimal support for running and importing compiled elm programs from node. It exports the Elm object, which can be require'ed as in:
var Elm = require('./elm.js');

Elm.worker(Elm.Main);

You can even use it for web apps using browserify:
var Elm = require('./elm.js');

Elm.fullscreen(Elm.Main);

If the compiled program is run directly, like node elm.js, the first module given to elm-make is run automatically with Elm.worker.
If the code is not being used in node or browserify, then nothing is affected.
In elm-lang/core#318 @evancz  mentions that things will change when dead-code elimination drops, but for now exporting the Elm object is consistent with how things work in the browser (a global Elm object.)

I want to hold off on this, Joey is probably gonna have a draft of DCE done today, so I'd say this will all be coming together in the next week or two.


Set up the repository

RoR group project:  Set up the repository
🌟Features:

[x] - Rails Gem is installed with Postgres as the default database.
[x] - RoR is configured with the project for checking the syntax.
[x] - Bootstrap is added as a styling library.
[x] - Fontawesome is added as an icons library.

Hi @baqar-abbas 👋,
Thank you so much 🙏 for reviewing and approving my pull request.
Your nice feedback is really appreciated 🙏.


Swagger gradle plugin, swagger converter not working

I'm usign swagger gradle plugin for generating the yaml doc.
I'm able to generate the doc but when I use my custom model converter which converts the plain model into jsonapi format, it doesn't get reflected in the schemas generated in the yaml file.
I can see that my custom code is getting invoked from the logs.
When I tried the same converter in swagger core unit tests https://github.com/swagger-api/swagger-core/blob/master/modules/swagger-core/src/test/java/io/swagger/v3/core/converting/override/ModelPropertyOverrideTest.java, it works and I can see my custom schema being generated in the unit test.
Could you advice what might be wrong in this case?

A custom model converter, defined in modelConverterClasses parameter of task should work ok, can you share some more details about your config and possibly a test case?

Found the cause. I was using super.resolve in my converter for resolving part of the model which I think marks processed types and hence my code wasn't working.
I replaced that part with new instance of ModelConverterContextImpl and it started working.
Thanks for such a quick response. Really apprecite it!


[Refactor/State] Remove listener on static item

needs to be classified as a static: 1 (if you want it to fire)

bit of a hassle to do and feels dirty....

this is not supported


Document Intelligence - prebuilt-read model Key-Value Pair analysis/extraction clarification

I have a use case where I'm attempting to use Document Intelligence to extract contents of an HTML via the AnalyzeDocumentContent.Base64Source property.
According to this page "prebuild-read" supports HTML. I have gotten it to work for extraction of the contents of the HTML file.
However, I have noticed that under the header of "Analysis features" the "prebuilt-read" model optionally supports Key-Value Pairs.
The page also says under the header "Model data extraction" that prebuild-read does not support Key-Value Pairs.
Can you please elaborate on the difference between the analysis and extraction?
I'm assuming since Key-Value Pairs are not included for extraction that I should never expect any content populated when using the prebuilt-read model, correct? In this case what would optionally enabling Key-Value Pairs do with this model?
Also, I'm left wondering if this documentation is correct. I've tried setting the DocumentAnalysisFeature.KeyValuePairs for a request with the "prebuilt-read" model, but have gotten the following responses:
With an HTML file: "The parameter keyValuePairs for file type Html is invalid: The feature is invalid or not supported."
With a PDF file: "The parameter keyValuePairs is invalid: The feature is invalid or not supported."
The errors combined with the documentation have left me a bit confused.
This is .NET 8 utilizing the Azure.AI.DocumentIntelligence version 1.0.0-beta.2.
I can provide sample code if needed, but I'm mostly looking for clarification on the analysis vs. extraction and how the Key-Value Pairs plays into this.
Thanks!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 12134ef3-d5a5-957c-9aea-e04f63537ab4
Version Independent ID: 8fe5ba6b-e7b7-7a04-85e1-982076b505de
Content: Document processing models - Document Intelligence (formerly Form Recognizer) - Azure AI services
Content Source: articles/ai-services/document-intelligence/concept-model-overview.md
Service: azure-ai-document-intelligence
GitHub Login: @laujan
Microsoft Alias: lajanuar

@tonyranieri
Thanks for your feedback! We will investigate and update as appropriate.

Hi @tonyranieri
Thank you for your feedback!
I'd recommend working closer with our support team via an [Azure support request] (https://docs.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request). Or you can leverage our Q&A forum by posting your issue there so our community, and MVPs can further assist you in troubleshooting this issue or finding potential workarounds.
[Teams Q&A forum] (https://docs.microsoft.com/en-us/answers/topics/46488/office-teams-windows-itpro.html) for technical questions about the configuration and administration of Microsoft Teams on Windows.
[Microsoft Teams Community forum] (https://answers.microsoft.com/en-us/msteams/forum?sort=LastReplyDate&dir=Desc&tab=All&status=all&mod=&modAge=&advFil=&postedAfter=&postedBefore=&threadType=All&isFilterExpanded=false&page=1)
Thank you for your time and patience throughout this issue.


Add the guidelines to contribute in README

Add the guidelines to contribute in README.

Added with https://github.com/iamazeem/fluent-plugin-json/commit/231ed6d4f12f318fdf3426a5962835a080a282c1.


Trie Remove implementation is inefficient

The implementation of (*Trie).Remove causes the trie to become steadily less efficient as more keys are deleted.
By inserting a tombstone instead of recursively deleting unused nodes, many redundant nodes may remain in place. This increases the the worst-case time for a search miss from logarithmic to linear.
For example, imagine our trie contains only the key "APPLE". We call, t.Remove("APPLE"), which replaces the value at the final "E" character with a tombstone. If we now search for "APPLES", we must check the nodes "A", "P", "P", "L" and "E", before finding that "APPLES" is not in the trie, since none of these nodes were deleted when "APPLE" was removed.
What should happen in this scenario is that we delete "APPLE", causing all of its nodes to be recursively deleted from the trie. Now when we search for "APPLES", we immediately miss when looking up the letter "A".
Please correct me if there's a use case for the tombstone that I've misunderstood. Otherwise I'm happy to open a PR to fix this.

I think the tombstone was mainly just to have simple and fast deletion. Doing a full delete sounds like a better approach, feel free to open a PR for that change.

Thanks for the reply. I've opened a PR 👍


docker.network resource

Support for creating docker networks. Currently with Converge, you can only configure communication between containers using the legacy links feature.

@ryane could you sketch out what this and #299 would look like in concert with the rest of the Docker modules?

example hcl for a docker.network resource:
docker.network "elk" {
  name = "elk"

  # optional
  driver      = "bridge"
  subnet      = "<IP_ADDRESS>/24"
  gateway     = "<IP_ADDRESS>"
  ip_range    = "<IP_ADDRESS>/28"
  internal    = false
  ipam_driver = ""
  enable_ipv6 = false

  aux_address {
    router  = "<IP_ADDRESS>"
    printer = "<IP_ADDRESS>"
  }

  labels {
    name = "elk"
    env  = "production"
  }

  options {
    "com.docker.network.bridge.enable_icc"           = "true"
    "com.docker.network.bridge.enable_ip_masquerade" = "true"
  }

  ipam_options {}

  force = true # will recreate the network if one with the same name exists and has diffs
}

A container would be able to connect to that network with  a lookup:
docker.container "elasticsearch-container" {
  name    = "elasticsearch"
  image   = "elasticsearch:2.4.0"
  network = "{{lookup `docker.network.elk.name`}}"
  force   = "true"
}

Thoughts?


Add missing whereNotInComposite() typing

@kibertoad since I am an admin now on the repo I could merge these directly, but I'm still a bit reluctant to do so. How should we go about it?


Add pre-built file for straight-up browser usage

Closes #20.
For folks without complicated build systems that just want to copy/paste a file and stick in their "libs" directory.

Dead code elimination with Google Closure would be nice to eliminate parts of Immutable.js that I don't use.
Mininification would also be nice.


Log info about mac workers in the kokoro mac jobs.

The logged info is going to be useful in migrating the mac workers to macservice.

Test failures are all unrelated (not on mac), but since recently I've been seeing some of them more I plan to look into them separately.

Test failures are all unrelated (not on mac), but since recently I've been seeing some of them more I plan to look into them separately.


[Settings][Dashboard] Accessibility fixes

Summary of the Pull Request
Minor accessibility fixes for PT Settings Dashboard.

PR Checklist

[x] Closes: #36252
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Made narrator announce buttons/cards
Made narrator announce toggle switches
Fixed double tab required to navigate from toggle switch to next item (example cards with buttons)

Validation Steps Performed

Manually tested Dashboard keyboard navigation using Narrator
Run Accessibility Insights

/azp run


chore(main): release 1.0.3

:robot: I have created a release beep boop
1.0.3 (2023-11-15)
Code Refactoring

clean and remove basalt-core (d110917)

Build System

update dependancies and change node version (3475779)

Continuous Integration

update release-and-publish github action (55e6ed4)

Documentation

Add readme (c16e8f9)
update JSDoc (020f6cf)

Miscellaneous Chores

Add keywords (74a9ed5)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/Basalt-Lab/basalt-auth/releases/tag/v1.0.3 :sunflower:


[bug]: index.e5f9e8aa.js:1 not found

Is there an existing issue for this?

[X] I have searched the existing issues

OS
Windows
GPU
cuda
VRAM
6GB
What happened?
When I start the web interface using invoke.bat, the website is blank. The favicon loads tho
Screenshots

The website (i've changed the port in this one)
Additional context
I've changed the ports, and the non webui version works without any issues, even on my GTX 1660 SUPER
I've also tried multiple different browsers with the same result
Contact Details
No response

Yup. Same here. Installation went fine. In the command window it says: ">> Started Invoke AI Web Server!" But in the browser (Chrome), there's a blank page. I have a RTX 3070ti, 8GB, should at least start the browser UI. Not happening yet. What can we do?

Fixed for me, probably because of #2180

Fixed for me, probably because of #2180

Ok, fixed for you, onluy for you, next keep it short without any explanation to others. Thank you.

Fixed for me, probably because of #2180

Ok, fixed for you, and for you only, so next keep it short without any explanation to others. Thank you.

I just git pulled the repo and it was fixed, then I read the release notes and it said the issue was fixed so I thought it was fixed for everyone. There is still another issue open about this if you want help :)


Default value of override_galaxy_version handled incorrectly

SUMMARY

If override_galaxy_version var is not specified for janus role then the default value of None isn't handled correctly.
Meta and defaults disagree:
# meta/argument_spec.yml
            override_galaxy_version:
                type: 'str'
                required: no
                default: None
                description: 'Set to override value of downstream version read from galaxy.yml'

# defaults/main.yml
override_galaxy_version:

ISSUE TYPE

Bug Report

ANSIBLE VERSION

2.15.0

COLLECTION VERSION

https://github.com/ansible-middleware/janus/commit/76f86596c6cdea3ffe1f3d75f779c517510caa7e

STEPS TO REPRODUCE

---
- name: "Janus transformation process"
  hosts: localhost
  gather_facts: no
  collections:
    - middleware_automation.janus
  vars:
    galaxy:
      issues: https://issues.redhat.com/projects/EVNT/issues
      homepage: https://console.redhat.com/insights
    upstream_namespace: redhatinsights
    upstream_name: eda
    downstream_namespace: "redhat"
    downstream_name: insights_eda
    override_galaxy_version: None
    skip_setup: True

  tasks:
    - name: "Run Janus."
      ansible.builtin.include_role:
        name: middleware_automation.janus.janus
      tags: always

EXPECTED RESULTS

override_galaxy_version not required.
ACTUAL RESULTS

fatal: [localhost]: FAILED! => {"argument_errors": ["argument 'override_galaxy_version' is of type <class 'NoneType'> and we were unable to convert to str: 'None' is not a string and conversion is not allowed"], "argument_spec_data": {"downstream_name": {"description": "The name of the downstream collection to generate", "required": true, "type": "str"}, "downstream_namespace": {"default": "redhat", "description": "Name of the downstream namespace to generate the collection into", "type": "str"}, "downstream_placeholder_content": {"default": [], "description": "List of placeholder comments used to add/replace downstream documentation snippets. List of dict(placeholder:str,content:str)", "type": "list"}, "downstream_placeholder_delete": {"default": [], "description": "List of placeholder comments for removing upstream only documentation snippets", "type": "list"}, "downstream_projects_dir": {"default": "(HOME)/ansible-collections-eda/downstream", "description": "Directory where the downstream collection will be generated", "type": "str"}, "override_galaxy_version": {"default": "None", "description": "Set to override value of downstream version read from galaxy.yml", "required": false, "type": "str"}, "post_processors_replacements": {"default": [], "description": "List of { match, replace, file } dicts for post processing replacements. `match` and `replace` are regexes for string replacements while `file` is a regex matcher filtering filenames to post-process", "type": "list"}, "project_git_url": {"description": "If provided, the git url used to fetch the upstream project repository", "required": false, "type": "str"}, "project_git_version": {"description": "If provided along project_git_url, the branch to fetch the upstream project from", "required": false, "type": "str"}, "skip_setup": {"default": true, "description": "Whether to skip the pre-transformation setup phase", "type": "bool"}, "upstream_collection_name": {"default": "eda", "description": "Optional name of upstream collection", "required": false, "type": "str"}, "upstream_downstream_collections_map": {"default": [], "description": "List of dependency mappings {upstream_name, downstream_name} for renaming in tasks, galaxy.yml and requirements.yml", "type": "list"}, "upstream_name": {"description": "The prefix for roles in the upstream collection to transform", "required": true, "type": "str"}, "upstream_namespace": {"default": "middleware_automation", "description": "Name of the upstream namespace to transform", "type": "str"}, "upstream_organisation": {"default": "ansible-middleware", "description": "github.com organisation for upstream repositories", "type": "str"}, "upstream_projects_dir": {"default": "(HOME)/ansible-collections-eda/upstream", "description": "Directory where the upstream project is cloned from git", "type": "str"}, "workdir": {"default": "(HOME)/ansible-collections-eda", "description": "Working directory to run the transformation process onto", "type": "str"}}, "changed": false, "msg": "Validation of arguments failed:\nargument 'override_galaxy_version' is of type <class 'NoneType'> and we were unable to convert to str: 'None' is not a string and conversion is not allowed", "validate_args_context": {"argument_spec_name": "main", "name": "janus", "path": "(HOME)/.ansible/collections/ansible_collections/middleware_automation/janus/roles/janus", "type": "role"}}

Thanks.

@RanabirChakraborty can you take a look?

@vkrizan I have sent the PR with the fix.
and if you face any path_to_dir and downstream_project undefined issues, I'll recommend adding the below variables.
project_root_folder: # clone or download ansible-collections-eda repo locally, and provide the path
downstream_project: # provide the local path where you want to place the downstream project.


[ENH] - Show installed packages versions along with the requested versions

Feature description
Display a third column in the spec which displays the installed version of the requested packages in here:

Value and/or benefit
It would be great to be able to know what were the exact package versions for the requested packages at a quick glance instead of going through the long list of Packages Installed as Dependencies
Anything else?
No response

Assigning to @smeragoel as this will need design work/input

Just a ping to say this is a fairly high value feature. Right now we have to look at the lock file to find out what was installed. And I have to do this fairly often. This is a mistake in the original implementation since the original designs did have this column. One of the core features of conda-store was supposed to be clearly communicating both what was requested and what was installed.

I added another column to indicate the installed version and also added clearer labels. This should fix the issue:

Let me know if this works!

Looks pretty good to me.

Related to #268 - where I added some comments on the proposed design

Based on feedback from #268, here are the updated designs with updates styling:

View:

Edit:

After the conversation re MUI now we need if we can use zebra lines @gabalafou

Is this issue specifically for design or does it include implementation? Just wondering since its in review but I dont see a PR linked?

It's in my court now, I'll change the status to "TODO"


Generate pull request for index.html in main

Generate pull request from index.html in main to apply changes

Pull request generated, like "First release to production"


DeriveSchema.gen[scala.collection.Map[K, V]] does not work

Not sure if this would be considered a new feature or a bugfix.
Attempting to derive a schema from a Map[K,V] results on the following error:
Failed to derive schema for scala.collection.Map[String,zio.schema.SchemaValidationSpec.Person]. Can only derive Schema for case class or sealed trait
[error]       implicit val schema = DeriveSchema.gen[scala.collection.Map[String, Person]]

It should be possible to derive a schema for Scala's Map data type.
This could be caused by one of two issues:

The implicit schema for Map not being found.
Some issue in the macros for schema derivation.

@jdegoes, @AppleKid7 Current implementation does not provide support for macro derivation for Map, for scala 2.x, but only for Scala 3.  Scala 2.x macro implementation provides automatic derivation only for sealed trait and case class
However, manual derivation works fine for all supported scala version


akka routes not matching input with default property

I have an API where the Create operation consumes a resource without an ID field (the server generates it) and where every operation returns that same resource with an ID field.
definitions:
  TheResource:
    discriminator: type
    type: "object"
    required:
      - "type"
    properties:
      id:
        type: "string"
      type:
        type: "string"
  ...

Guardrail generates an id field of type Option[String].  If I change the id property in swagger to have a default: "" and/or add id to the list of required properties, Guardrail changes the case class accordingly (either as id: Option[String] = Option("") or id: String = ""), but the generated routes don't match requests without an ID.
I think this should be possible in swagger 2 and 3.  Is there an extra hint I should be providing to the akka server routes generator?

Hey @dsilvasc, thanks for the report! I expect this is due to the generated decoders not explicitly handling default values.
This is similar to #94, with the unfortunate workaround being (as you may already suspect) manually handling these use cases for now.
I think the fix for this is much more straightforward than read/write-only properties, as we can always fall back to a default value.
Taking a similar strategy to x-scala-empty-is-null seems like a good direction for a fix:
          implicit val decodePet = new Decoder[Pet] {
            final def apply(c: HCursor): Decoder.Result[Pet] =
              for (
                name <- c.downField("name").withFocus(j => j.asString.fold(j)(s => if (s.isEmpty) Json.Null else j)).as[Option[CustomThing]]
              ) yield Pet(name)
          }

could easily be modified with j.asString.orElse(...) without negatively impacting other functionality.


global leaderboard changes

If this is intended to alleviate the strain on the database, this wouldn't work as you're still fetching all users from the database. You'd have to write another sql query which only fetches users in the current guild


python310Packages.pyvisa-sim: 0.5.1 -> 0.6.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.pyvisa-sim is: Simulated backend for PyVISA implementing TCPIP, GPIB, RS232, and USB resources
meta.homepage for python310Packages.pyvisa-sim is: https://pyvisa.readthedocs.io/projects/pyvisa-sim/en/latest/
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.6.0 with grep in /nix/store/m9nf39nflh21ikp3phhl0l4f6nh29y7f-python3.10-pyvisa-sim-0.6.0
found 0.6.0 in filename of file in /nix/store/m9nf39nflh21ikp3phhl0l4f6nh29y7f-python3.10-pyvisa-sim-0.6.0

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

6 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.pyvisa-sim
python310Packages.qcodes
python310Packages.qcodes-contrib-drivers
python311Packages.pyvisa-sim
python311Packages.qcodes
python311Packages.qcodes-contrib-drivers

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/m9nf39nflh21ikp3phhl0l4f6nh29y7f-python3.10-pyvisa-sim-0.6.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.pyvisa-sim https://github.com/r-ryantm/nixpkgs/archive/0134094ce24192b0b52e90cbda5897971956c2c2.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/0134094ce24192b0b52e90cbda5897971956c2c2#python310Packages.pyvisa-sim

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/m9nf39nflh21ikp3phhl0l4f6nh29y7f-python3.10-pyvisa-sim-0.6.0
ls -la /nix/store/m9nf39nflh21ikp3phhl0l4f6nh29y7f-python3.10-pyvisa-sim-0.6.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages failed to build:

python310Packages.qcodes
python310Packages.qcodes-contrib-drivers
python311Packages.qcodes
python311Packages.qcodes-contrib-drivers

2 packages built:

python310Packages.pyvisa-sim
python311Packages.pyvisa-sim

Maintainer pings
cc @evilmav for testing.

Already on staging-next.


Change polling to push notification in pipelines

Problem: currently there is delay in starting a pipeline as pipeline system polls for new things to do rather than running on push.
Solution: switch to push.

new API for pipelines system
connect to source spec registry ...

@anuveyatsu is this still actual

@zelima I don't think so - haven't noticed any sort of delays after a new system was deployed. So closing this issue now.


Is there batch normalization in Theano DNN model?

Is there batch normalization within DNN hidden layers implemented in Theano? I could not find it.

I think the answer is no. My implementation in C/C++ without batch normalization generate the same output.


Item Deliver problem

      items-to-deliver:
      - name-redstone:amount-3
      - name-glowstone:amount-1

Is there something wrong here
Console said that item-delivery not formatted properly
Using latest Quests version on Spigot 1.7.10
Vault 1.4.1

Please post the actual Quests version and error ("latest" is not sufficient as you may be using a dev build).

Im using Quests 2.4.0
PotionMaster:
name: Ren's Dreams 2
ask-message: * I believe you are here because of Ren? I saw her going back to that old abandoned house again, she always do that whenever she's having those bad dreams. Anyway I'm lacking of ingredients to make the potion that she needed. * Can you go buy 3 redstones and 1 glowstone dust for me?
finish-message: You may now give this potion to Ren.
npc-giver-id: 29
requirements:
quests:
- Ren's Dreams
fail-requirement-message: You need to finish Ren's Dreams quest!.
stages:
ordered:
'1':
items-to-deliver:
- name-redstone:amount-3
- name-glowstone:amount-1
npc-delivery-ids:
- 18
delivery-messages:
- ': Thanks for the ingredients!'
rewards:
money: 0.05
items:
- name-potion:amount-1:displayname-Dreamshade
I suddenly got this error after reload
http://pastebin.com/Q9Gzytzf

I updated to Spigot 1.8.3
I got this small error instead
http://pastebin.com/n2Ah4zGy

Sorry for the late response. I would suggest remaking the quest if you haven't already.


IMPRO-1801: Added the forecast period bounds to emos coefficients cubes

This PR adds the forecast period bounds to the emos coefficient cubes coordinates. This is required as the entire coordinate is checked when applying the coefficients, so without these bounds an exception is raised when calibrating period diagnostics.
An alternative approach would be to only check the coordinate point and ignore the bounds, but the chosen approach has the benefit of ensuring that we cannot apply the coefficients for an instantaneous temperature to a period temperature minimum/maximum.
Testing:

[x] Ran tests and they passed OK
[x] Added new tests for the new feature(s)

 Here is an overview of what got changed by this pull request:

Clones added
============
- improver_tests/calibration/ensemble_calibration/test_EstimateCoefficientsForEnsembleCalibration.py  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- improver_tests/calibration/ensemble_calibration/test_EstimateCoefficientsForEnsembleCalibration.py  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- improver_tests/calibration/ensemble_calibration/test_EstimateCoefficientsForEnsembleCalibration.py  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- improver_tests/calibration/ensemble_calibration/test_EstimateCoefficientsForEnsembleCalibration.py  2

See the complete overview on Codacy


Basic example fails: "The "composer.json" directory does not exist."

Laravel version 5.5.42
Zipper::make('test.zip')->folder('test')->add('composer.json');
InvalidArgumentException
The "composer.json" directory does not exist.

$files = glob(public_path('js/*'));
 \Zipper::make(public_path('test.zip'))->add($files)->close();
 return response()->download(public_path('test.zip'));


feat: implements timeout for keyval

Using the timer for events implemented by nginx, we can use ttl in keyval zones. This creates a struct for store the pointer for the node, which should be deleted after an amount of time specified on the configuration, and the pointer for the context. The ttl belongs to this context too. When the node is created, the function ngx_keyval_shm_set_data creates an event and adds a timer for this event. The handler (ngx_keyval_delete_timeout_node_shm) deletes the node. So, the next time when key is checked, there won't be a node with it.

Summary by CodeRabbit

New Features

Added inclusion of ngx_event.h for improved event handling.
Implemented TTL configuration for automatic expiration of key-value pairs.
Introduced parsing and handling of variables in strings for dynamic content.
Enhanced shared memory functionality to manage timeout nodes effectively.

Improvements

Optimized memory management and error handling in key-value string construction.
Extended key-value storage to support multiple indexes for complex data scenarios.

Documentation

Updated to include details on TTL configuration, variable handling, and memory management changes.

[!CAUTION]
nginx: [emerg] invalid number of arguments in "keyval_zone" directive

Please correct.
--- a/src/ngx_http_keyval_module.c
+++ b/src/ngx_http_keyval_module.c
@@ -18,7 +18,7 @@ static ngx_command_t ngx_http_keyval_commands[] = {
     0,
     NULL },
   { ngx_string("keyval_zone"),
-    NGX_HTTP_MAIN_CONF|NGX_CONF_TAKE1,
+    NGX_HTTP_MAIN_CONF|NGX_CONF_1MORE,
     ngx_http_keyval_conf_set_zone,
     0,
     0,
--- a/src/ngx_stream_keyval_module.c
+++ b/src/ngx_stream_keyval_module.c
@@ -18,7 +18,7 @@ static ngx_command_t ngx_stream_keyval_commands[] = {
     0,
     NULL },
   { ngx_string("keyval_zone"),
-    NGX_STREAM_MAIN_CONF|NGX_CONF_TAKE1,
+    NGX_STREAM_MAIN_CONF|NGX_CONF_1MORE,
     ngx_stream_keyval_conf_set_zone,
     0,
     0,

Fixing code styles.
--- a/src/ngx_keyval.c
+++ b/src/ngx_keyval.c
@@ -278,16 +278,15 @@ ngx_keyval_conf_set_zone(ngx_conf_t *cf, ngx_command_t *cmd, void *conf,
       ctx->ttl = ngx_parse_time(&s, 1);
       if (ctx->ttl == (time_t) NGX_ERROR) {
         ngx_conf_log_error(NGX_LOG_EMERG, cf, 0,
-                          "\"%V\" invalid ttl \"%V\"",
-                          &cmd->name, &value[2]);
+                           "\"%V\" invalid ttl \"%V\"",
+                           &cmd->name, &value[2]);
         ctx->ttl = 0;
         return NGX_CONF_ERROR;
       }
     }
-  }
-
-  else
+  } else {
     ctx->ttl = 0;
+  }

   return NGX_CONF_OK;
 }
@@ -575,7 +574,8 @@ ngx_keyval_shm_get_data(ngx_keyval_shm_ctx_t *ctx, ngx_shm_zone_t *shm,
 static void
 ngx_keyval_delete_timeout_node_shm(ngx_event_t *node_status)
 {
-  ngx_keyval_node_timeout_t *arg = (ngx_keyval_node_timeout_t *) node_status->data;
+  ngx_keyval_node_timeout_t *arg
+    = (ngx_keyval_node_timeout_t *) node_status->data;

   if (arg->ctx->shpool != NULL && arg->node != NULL) {
     ngx_rbtree_delete(&arg->ctx->sh->rbtree, arg->node);
@@ -632,25 +632,24 @@ ngx_keyval_shm_set_data(ngx_keyval_shm_ctx_t *ctx, ngx_shm_zone_t *shm,
     rc = NGX_OK;

     if (ctx->ttl) {
-      ngx_event_t *timeout_node_event = ngx_slab_alloc_locked(ctx->shpool, sizeof(ngx_event_t));
+      ngx_event_t *timeout_node_event
+        = ngx_slab_alloc_locked(ctx->shpool, sizeof(ngx_event_t));

       if (timeout_node_event == NULL) {
         ngx_log_error(NGX_LOG_ERR, log, 0,
                       "keyval: failed to allocate timeout event");
         rc = NGX_ERROR;
-      }
-
-      else {
-        ngx_keyval_node_timeout_t *timeout_node = ngx_slab_alloc_locked(ctx->shpool, sizeof(ngx_keyval_node_timeout_t));
+      } else {
+        ngx_keyval_node_timeout_t *timeout_node
+          = ngx_slab_alloc_locked(ctx->shpool,
+                                  sizeof(ngx_keyval_node_timeout_t));

         if (timeout_node == NULL) {
           ngx_log_error(NGX_LOG_ERR, log, 0,
-                        "keyval:failed to allocate timeout node");
+                        "keyval: failed to allocate timeout node");
           rc = NGX_ERROR;
           ngx_slab_free_locked(ctx->shpool, timeout_node_event);
-        }
-
-        else {
+        } else {
           timeout_node->node = node;
           timeout_node->ctx = ctx;

Please add a ttl test to the stream module as well.

t/stream.t

Please update README.md as well.

[!CAUTION]
nginx: [emerg] invalid number of arguments in "keyval_zone" directive

Please correct.
--- a/src/ngx_http_keyval_module.c
+++ b/src/ngx_http_keyval_module.c
@@ -18,7 +18,7 @@ static ngx_command_t ngx_http_keyval_commands[] = {
     0,
     NULL },
   { ngx_string("keyval_zone"),
-    NGX_HTTP_MAIN_CONF|NGX_CONF_TAKE1,
+    NGX_HTTP_MAIN_CONF|NGX_CONF_1MORE,
     ngx_http_keyval_conf_set_zone,
     0,
     0,
--- a/src/ngx_stream_keyval_module.c
+++ b/src/ngx_stream_keyval_module.c
@@ -18,7 +18,7 @@ static ngx_command_t ngx_stream_keyval_commands[] = {
     0,
     NULL },
   { ngx_string("keyval_zone"),
-    NGX_STREAM_MAIN_CONF|NGX_CONF_TAKE1,
+    NGX_STREAM_MAIN_CONF|NGX_CONF_1MORE,
     ngx_stream_keyval_conf_set_zone,
     0,
     0,

I'm testing in a container without volumes, and coding in host. I changed in container, but not in host and I forgot 😞😞

The original http_keyval_module of nginx can be set with timeout=time, so is it possible to set it with timeout= as well?
I don't consider this a requirement, so please just reply.

If not, I will fix it after the merge.

It's just change the argument name, right?

Yes, just return it.
I was wondering if either ttl or timeout could be defined.

We could leave like this too, it's inspired in the module and the use of "ttl" is documented. But if you want, it's easy, we just insert an "or" in the parse of configuration.

I don't see any major problems.
I'd like to make a few adjustments and then merge.
https://github.com/kjdev/nginx-keyval/commits/thiagoc01-timeout-keyval-zone/

merged https://github.com/kjdev/nginx-keyval/commit/0adec5c992368fd0c4c06904dc76eba9da854b4a


Updated StatSummaryType to include the Arsr and darkstar types

these game types were missing from the StatSummaryType list throwing errors when pulling summoner data.

Hmm, so when you said in your issue that you submitted a PR, I went to look for it. I couldn't find it in on my end, so I looked here and found it. I'm not sure how this happened, but for some reason you have a PR submitted for your own forked version of Cass rather than the meraki-analytics one.
On github, you should be able to click "New Pull Request" or something like that to get it into the parent version of your fork (i.e. into meraki-analytics). It should then show up here: https://github.com/meraki-analytics/cassiopeia/pulls  (there is already one PR there).
On this PR that I'm commenting on, you should have permission to merge it (because it's your repo). When you submit the PR to meraki-analytics/cassiopeia, you shouldn't have permission to merge it. So I think you should merge this PR and accept the changes, which will then allow you to submit a PR to meraki-analytics/cassiopeia with the changes.


Secrets (within quotes) that are part of Variable Group linked to KeyVault  are not masked in logs

Please check our current Issues to see if someone already reported this https://github.com/Microsoft/azure-pipelines-task-lib/issues
Environment
azure-pipelines-task-lib version:
Azure PowerShell V2 task
Windows (Azure VMSS)
Issue Description
Secrets (having values within quotes "" ) that are part of Variable Group linked with Azure KeyVault is not masked in logs
Expected behaviour
Secrets should be masked in logs in all cases
Actual behaviour
Secrets are not masked in all cases
Steps to reproduce
Below is a simple step that can reproduce the secret leak in logs. In the KeyVault, SecretsWithinQuotes has value "SHOULDBEHIDDEN" and SecretsWithinEscapedQuotes has value \"SHOULDBEHIDDEN\"
steps:
- task: PowerShell@2
  inputs:
    targetType: 'inline'
    script: |
          echo 'My Secret in quotes 1: '$(SecretsWithinQuotes)
          echo 'My Secret5 in quotes 2: '"$(SecretsWithinQuotes)"
          echo "{$(SecretsWithinQuotes)}"
          echo "My Secret  in quotes 3:" {$(SecretsWithinQuotes)}
          echo "My Secret5 in quotes 4: {$(SecretsWithinQuotes)}"
          echo "My Secret  in quotes 5: {{$(SecretsWithinQuotes)}}"
          echo "*****************************************************"
          echo 'My Secret in escaped quotes 1: '$(SecretsWithinEscapedQuotes)
          echo 'My Secret5 in escaped quotes 2: '"$(SecretsWithinEscapedQuotes)"
          echo "{$(SecretsWithinEscapedQuotes)}"
          echo "My Secret  in escaped quotes 3:" {$(SecretsWithinEscapedQuotes)}
          echo "My Secret5 in escaped quotes 4: {$(SecretsWithinEscapedQuotes)}"
          echo "My Secret  in escaped quotes 5: {{$(SecretsWithinEscapedQuotes)}}"

Is there any way that I can restrict the secret being leaked out in all cases?
Logs
Here are the logs for the above step that shows leaked secret in most cases:
My Secret in quotes 1:
SHOULDBEHIDDEN
My Secret5 in quotes 2:

SHOULDBEHIDDEN
{
SHOULDBEHIDDEN}
My Secret  in quotes 3:
***
My Secret5 in quotes 4: {
SHOULDBEHIDDEN}
My Secret  in quotes 5: {{
SHOULDBEHIDDEN}}
*****************************************************
My Secret in escaped quotes 1:
\SHOULDBEHIDDEN\
My Secret5 in escaped quotes 2:
\
SHOULDBEHIDDEN\
{\
SHOULDBEHIDDEN\}
My Secret  in escaped quotes 3:
***
My Secret5 in escaped quotes 4: {\
SHOULDBEHIDDEN\}
My Secret  in escaped quotes 5: {{\
SHOULDBEHIDDEN\}}

Just realized that I should have used BackTick as the escape character for the PowerShell script. It masked the secret when changed  "SHOULDBEHIDDEN"  to  "SHOULDBEHIDDEN".
I will now close this issue.

Closing the issue because I think I found the solution.
Setting new task variable and then assigning it the secret.
Write-Host "##vso[task.setvariable variable=secretwithdoublequotes;issecret=true]$(secretwithdoublequotes)"
Thereafter, using the variable in this format  {$(secretwithdoublequotes)} to avoid the leak.


Run some reasonable number of speculations in parallel.

From chat discussion:
There is a TODO to fix this: https://github.com/PolymerLabs/arcs/blob/master/runtime/planner.js#L139
It was earlier changed from running all speculative executions in parallel:
https://github.com/PolymerLabs/arcs/commit/98b62f12f557dbb8dddcdc9ab1afd342e8f1807d#diff-aa20163f4eb8b98dfd65800032bad5f3
because IIRC it was consuming too much RAM.
navigator.hardwareConcurrency looks helpful.

Seems could be fun and out of near term critical runtime path. FYI @dstockwell @mmandlis

Will open anew if we determine rework needed per comment in above issue.


dartfmt --fix doesn't remove new from string interpolation expression

dartfmt --fix is a wonderful feature!
Note that it currently fails to remove new from the following string interpolation expression:
    sink.write('FILE ACCESSED ${new DateTime.now()}\n');

cc @munificent @kwalrath

This issue was moved to dart-lang/dart_style#707


Visibility toggle + selection

In the New Matrix Eater code that I am working on, there is a bug that selected vertices remain selected even when you toggle them to be invisible in the display manager tree widget that replaces the old matrix eater's "View Controller" window.
They should toggle out-of-selection and deselect when they are no longer visible, so that users are not confused. However, this feature will clash with the Undo function, which was implemented to use the ModelEditor interface which assumes that its underlying SelectionManager never had its selection tampered with except via other UndoActions. A possible fix to prevent this regression is the addition of UndoAction(s) for the visibility toggle widget.

This got fixed, but introduced a regression in the sense that the checkboxes reload constantly, and get doubly called each time they're clicked (one from a component list, one from the initial recursion to handle all children)


Calendar pane of start menu now comes from right

Calendar pane of start menu now comes from right like in actual win11 instead from bottom

Rerun CI


The SQL update code in your readme document seems to have no conditions?

let result = await client.execute(`update users set ?? = ?`, ["name", "MYR"]);
console.log(result);
// { affectedRows: 1, lastInsertId: 0 }

Conditions should be added, such as:
// # 更新数据表某数据
const updateResult = await client.execute(
  `update users set ?? = ? where id=?`,
  [
    "name",
    "lufei",
    1,
  ],
);

I understand there is usually WHERE clause in UPDATE statements. But it's just a simple example to show how to execute SQL with field name parameter (??) and value parameter (?). Developers should write their own SQL statements and know what they're doing.


proposed changes to scheme

These changes don't change the scheme (except for some lost example values), but removes a lot of duplicated fields.


Control Cell Sets and/or Additional Cell Sets for React Component

User story
Currently, cell sets loaded from a file are stored in an object called cellSets and user created cell sets are stored in an object called additionalCellSets. The cell sets in the cellSets object are all read-only, and the cell sets in the additionalCellSets object. There is no way for an application using the Vitessce React component to save user created cell sets from the additionalCellSets object and reload them as editable in a subsequent session.
Preferred solution
I would like to be able to control (in a React sense) the additionalCellSets object. To accomplish this, the Vitessce React component could have a prop for additionalCellSets and another prop for onAdditionalCellSets change. If no value is provided for either then the component would default to its current uncontrolled behavior.
Alternate Solution
Have a flag to set cell sets in the cellSets object to be editable. This would allow an application using the React component to add new cell sets to the cell sets file, which would persist user created cell sets and allow them to be edited on reload. I'm not sure how you would deal with the current behavior of adding new cells to the default group 'My Selections' and how it would work if that group were included in the cell sets file.
Context
I am working on a project that uses the React component in an Electron window. I would like to allow users to be able to generate cell sets on the image or the plot, close the application, reopen the application, and be able to see and edit the cell sets they created in their previous session. I would store the user created cell sets in my own datastore, but need a way to initialize the Vitessce component with previously created cell sets. I would be happy to attempt to implement this if you approve of the feature.

There should already be a way to do this via the view config but please let me know if I am misunderstanding anything.

There is no way for an application using the Vitessce React component to save user created cell sets from the additionalCellSets object and reload them as editable in a subsequent session.

The variable additionalCellSets comes from the "coordination space". Everything in the coordination space is stored in the coordinationSpace object of the view config. Using the onConfigChange prop of the <Vitessce/> component, you can access the view config and its contents every time it changes in response to a user interaction.
For example, if the initial view config is:
{
  "version": "1.0.4",
  "name": "My example config",
  "description": "This demonstrates the JSON schema",
  "datasets": [
    {
      "uid": "D1",
      "name": "Dries",
      "files": [
        {
          "url": "https://s3.amazonaws.com/vitessce-data/0.0.31/master_release/dries/dries.cells.json",
          "type": "cells",
          "fileType": "cells.json"
        },
        {
          "url": "https://s3.amazonaws.com/vitessce-data/0.0.31/master_release/dries/dries.cell-sets.json",
          "type": "cell-sets",
          "fileType": "cell-sets.json"
        }
      ]
    }
  ],
  "coordinationSpace": {
    "dataset": {
      "A": "D1"
    },
    "embeddingType": {
      "A": "UMAP",
      "B": "t-SNE"
    },
    "embeddingZoom": {
      "A": 2.5
    },
    "additionalCellSets": {
      "myUserDefinedSets": null
    }
  },
  "layout": [
    {
      "component": "scatterplot",
      "coordinationScopes": {
        "dataset": "A",
        "embeddingType": "A",
        "embeddingZoom": "A",
        "additionalCellSets": "myUserDefinedSets"
      },
      "x": 6,
      "y": 0,
      "w": 6,
      "h": 6
    },
    {
      "component": "cellSets",
      "coordinationScopes": {
        "dataset": "A",
        "additionalCellSets": "myUserDefinedSets"
      },
      "x": 0,
      "y": 6,
      "w": 6,
      "h": 6
    }
  ],
  "initStrategy": "auto"
}

Then you could inject the user-defined cell sets into the config somehow like
function MyVitessceParent(props) {
  const [config, setConfig] = useState(initialConfig);
  function loadCellSets() {
    config.coordinationSpace.additionalCellSets.myUserDefinedCellSets = loadFromDB();
  }
  function saveCellSets() {
    sendToDB(config.coordinationSpace.additionalCellSets.myUserDefinedCellSets);
  }
  return (
    <div>
      <button onClick={loadCellSets}>Fill in user-defined cell sets</button>
      <button onClick={saveCellSets}>Send current user-defined cell sets to database</button>
      <Vitessce config={config} onConfigChange={setConfig} />
    </div>
  );
}

Similarly you could construct the initial config such that it already contains an additionalCellSets object:
{
  "version": "1.0.4",
  "name": "My example config",
  "description": "This demonstrates the JSON schema",
  "datasets": [
    {
      "uid": "D1",
      "name": "Dries",
      "files": [
        {
          "url": "https://s3.amazonaws.com/vitessce-data/0.0.31/master_release/dries/dries.cells.json",
          "type": "cells",
          "fileType": "cells.json"
        },
        {
          "url": "https://s3.amazonaws.com/vitessce-data/0.0.31/master_release/dries/dries.cell-sets.json",
          "type": "cell-sets",
          "fileType": "cell-sets.json"
        }
      ]
    }
  ],
  "coordinationSpace": {
    "dataset": {
      "A": "D1"
    },
    "embeddingType": {
      "A": "UMAP",
      "B": "t-SNE"
    },
    "embeddingZoom": {
      "A": 2.5
    },
    "additionalCellSets": {
      "myUserDefinedSets": {
        "version": "0.1.3",
        "datatype": "cell",
        "tree": [
          {
            "name": "My Selections",
            "children": [
              {
                "name": "Selection 1",
                "set": [
                  ["cell_397",null],
                  ["cell_345",null]
                ]
              }
            ]
          }
        ]
      }
    }
  },
  "layout": [
    {
      "component": "scatterplot",
      "coordinationScopes": {
        "dataset": "A",
        "embeddingType": "A",
        "embeddingZoom": "A",
        "additionalCellSets": "myUserDefinedSets"
      },
      "x": 6,
      "y": 0,
      "w": 6,
      "h": 6
    },
    {
      "component": "cellSets",
      "coordinationScopes": {
        "dataset": "A",
        "additionalCellSets": "myUserDefinedSets"
      },
      "x": 0,
      "y": 6,
      "w": 6,
      "h": 6
    }
  ],
  "initStrategy": "auto"
}

In your case of the electron app, you could supply all cell sets via additionalCellSets and the parent app could be responsible for reading/writing them to a file as the user updates them (i.e., if you do not need any cell sets to be read-only, do not use a cell sets file (well for now just a cell sets file with an empty tree array until #1277 has been resolved), and supply all cell sets via additionalCellSets in the initial view config, listening for any changes.

Rad! This should solve my use case. Thanks for the detailed instructions on how to accomplish it.


Create Project import improvements

Fixes #2805. Fixes #2800. This includes three fixes / improvements:

Fix Content-Type handling to correctly extract the charset (which we call "encoding") - no issue
Implement support for Structured Syntax Name Suffixes on media types so that we'll fall back to text/json or text/xml for mediatypes which have +json or +xml suffixes if we don't have an entry for the full type - issue #2800 / #2805
Switch the default fallback type from text/line-based to text so that we try the most general guessing strategy. The other will only try to guess TSV, CSV, or Fixed formats, so will never find JSON or XML files with the character frequency guesser. - no issue

@tfmorris Wow, this fixed a big problem for me in my daily work.  Detection is so much better!!!  It's like magic almost!  Thanks Tom!

Thanks for testing and reporting back.


[Bug] connectedType of line works error when has defined: false point

Version
no
Link to Minimal Reproduction
no need
Steps to Reproduce
https://github.com/VisActor/VChart/issues/3238
66ec09a4e905a400f7326a2a
Current Behavior
no
Expected Behavior
no
Environment
- OS:
- Browser:
- Framework:

Any additional comments?
No response

closed by https://github.com/VisActor/VRender/pull/1588

63bd232d9d831755c006901c


Is --cluster-distance working wrong?

From example
curl -L -O https://www.naturalearthdata.com/http//www.naturalearthdata.com/download/10m/cultural/ne_10m_populated_places.zip
unzip -o ne_10m_populated_places.zip
ogr2ogr -f GeoJSON ne_10m_populated_places.geojson ne_10m_populated_places.shp

tippecanoe -zg -o ne_10m_populated_places.mbtiles -r1 --cluster-distance=10 --accumulate-attribute=POP_MAX:sum ne_10m_populated_places.geojson

The point named Annaba has different lat lon at different zoom level

When points are clustered, they are given the average latitude and longitude of the points that were clustered together, but the attributes of the first point in the cluster (except for the attributes that are specified to be accumulated). So I think this is probably working as intended.

Thank @ericfischer
Do you have any suggestion that keep exactly location of the clustered point?

You could remove the special case for VT_POINT here, which is what does the averaging:
https://github.com/mapbox/tippecanoe/blob/065cc1d78d662ec21620596e07749c02a941337f/tile.cpp#L1889

It works. Thank you!


[fix](type system) fix write column to arrow with null date

Proposed changes
null_map is defined by res.empty()? nullptr: res.data() generation, the original logic is incorrect for null_map[i], which represents whether a value is available, not whether it is empty
        // null_map is true if a column has an empty value
        // null_map[i] true if it gets data, false if it doesn't
        if (null_map && !null_map[i]) {
            checkArrowStatus(string_builder.AppendNull(), column.get_name(),
                             array_builder->type()->name());
        } else {
            checkArrowStatus(string_builder.Append(buf, len), column.get_name(),
                             array_builder->type()->name());
        }

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.98 seconds
stream load tsv:          500 seconds loaded<PHONE_NUMBER>9 Bytes, about 142 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          90.5 seconds inserted 10000000 Rows, about 110K ops/s
storage size:<PHONE_NUMBER>7 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230706183123_clickbench_pr_173675.html

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.74 seconds
stream load tsv:          447 seconds loaded<PHONE_NUMBER>9 Bytes, about 159 MB/s
stream load json:         21 seconds loaded<PHONE_NUMBER> Bytes, about 107 MB/s
stream load orc:          56 seconds loaded<PHONE_NUMBER> Bytes, about 18 MB/s
stream load parquet:          28 seconds loaded 861443392 Bytes, about 29 MB/s
insert into select:          68.7 seconds inserted 10000000 Rows, about 145K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230706111851_clickbench_pr_173704.html

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 54.97 seconds
stream load tsv:          499 seconds loaded<PHONE_NUMBER>9 Bytes, about 142 MB/s
stream load json:         19 seconds loaded<PHONE_NUMBER> Bytes, about 118 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          87.2 seconds inserted 10000000 Rows, about 114K ops/s
storage size:<PHONE_NUMBER>1 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230706195259_clickbench_pr_173737.html

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 53.75 seconds
stream load tsv:          497 seconds loaded<PHONE_NUMBER>9 Bytes, about 143 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          89.0 seconds inserted 10000000 Rows, about 112K ops/s
storage size:<PHONE_NUMBER>4 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230706201726_clickbench_pr_173747.html

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 53.8 seconds
stream load tsv:          449 seconds loaded<PHONE_NUMBER>9 Bytes, about 158 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          56 seconds loaded<PHONE_NUMBER> Bytes, about 18 MB/s
stream load parquet:          29 seconds loaded 861443392 Bytes, about 28 MB/s
insert into select:          67.1 seconds inserted 10000000 Rows, about 149K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230706122028_clickbench_pr_173776.html

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 52.05 seconds
stream load tsv:          446 seconds loaded<PHONE_NUMBER>9 Bytes, about 159 MB/s
stream load json:         22 seconds loaded<PHONE_NUMBER> Bytes, about 102 MB/s
stream load orc:          56 seconds loaded<PHONE_NUMBER> Bytes, about 18 MB/s
stream load parquet:          28 seconds loaded 861443392 Bytes, about 29 MB/s
insert into select:          69.7 seconds inserted 10000000 Rows, about 143K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230707032334_clickbench_pr_174114.html


--system does not use --python

So I may have the usage wrong, but essentially I want to use pipenv in a docker container, but install the packages using pypy3 in this case, so I am trying to do:
pipenv install --system --python pypy3
This however gives the error that /bin/python cannot be found, which makes me think that it is ignoring the --python when used with the --python argument.
If this is expected then how do I install the packages in a docker container using another version of python like pypy3?
Describe your environment

OS Type: Ubuntu 17.04
Python version: pypy3
Pipenv version: 9.0.1

@grantstephens thanks for the report.  --system and --python are kind of mutually exclusive if you will.  If you pass --system, pipenv always uses sys.executable which is whatever version of python pipenv is running in.  Passing --python implies to pipenv that you want it to make a virtualenv for you.  That said I am really not sure how things will work out with pypy3, but combining these two flags won't work.  I suspect you may want to try this out by having pypy3 as your virtualenv python by simply removing the --system flag and using pipenv run to invoke python code in that context.
I'll leave this open since I'd like to know if this works :)

Ah, I figured something like that was going on and it makes sense- thanks for explaining it. I can get it to run perfectly locally with pypy3 or whichever interpreter I want (Just depends on how the virtualenv is set up), the problem is in the docker container. Now I could run it in a virtualenv in the container (as you suggested, which works), but that kinda defeats the point of having a small lightweight container.
I also considered simlinking over /bin/python, but that is probably not a good idea.
Essentially it comes down to wanting to not create a virtualenv and not use /bin/python but specify and executable that should be used.
It seems that pipenv still goes for /bin/python even when it was installed using a pip and interpreter that are not that, i.e. pip install pipenv installs pipenv using pypy3 for me, but it still tries to use /bin/python when doing pipenv install

@grantstephens I dont know too much about pypy but I suspect it's because it is looking for python or whatever, but not finding it.  Do you know what the value of sys.executable is in a pypy interpreter?

Just checked- it is the pypy executable.  I'll go and double check that this is also the case for pypy in the docker image, but something was looking for python in /bin/python
Just to confirm- pipenv with --system should use the executable specified in sys.executable?

yes, unless --system isn't falling through to the which() call in question (see #1002)


Make Navbar and Footer for all pages

Make navbar and footer common for all pages like about books etc. i.e for component folder

I can Design The Navbar and Footer with all the required functionalities
-> I will make it responsive as well
Please Assign me the task under GSSOC'23

@Hemant2335 we don't have to design new it's already there people are enhancing it
i just want to setup routes like it will be present with all the pages and it's done now

use template inheritance technique for common footer and navbar

@Hemant2335 can you template inheritance technique?

template inheritance technique

No not really but as it is now a inbuild feature of next.js . I really didn't give it a thought but by using them as  a Component  in every page we can try that .

@Hemant2335 learn about it try it and file a pr after testing it

I  can work on this issue under gssoc 23 contribution ?

please assign me this issue I will work on it under gssoc 23 contribution.


Examples.py,ln 84: parameter has changed in method efficient_risk

In file examples.py: method is called with parameter "target_risk", should be (in module) "target_volatility".
I am completely new to Github; would be a good case to learn. What can I contribute?

Hi @bvonboyen,
Good catch! You can submit that as a pull request if you'd like :)
If you navigate to the examples.py file in GitHub, you can click the edit button in the top right and submit the fix (alternatively if you want to do it the long way, you can follow the instructions here).
Thanks!
Robert

Hi @robertmartin8 , thank you. As I came to stay, I will do this right away. ;-)


wasm-pack Crash Report

🐛 Bug description
Crashed while trying to build the Hello World  project.
🤔 Expected Behavior
Building should not crash.
👟 Steps to reproduce
For the first time I built this project, It occurs that the building progress stucked at [10/10] Running WASM-bindgen.... Then I forced to abort it.
Crashing happened at the 2nd building, after the [10/10] Running WASM-bindgen... has shown up.
🌍 Your environment
OS: Ubuntu 18.10
wasm-pack version: 0.6.0
rustc version: 1.32.0
Crash log
name = 'wasm-pack'
operating_system = 'unix:Ubuntu'
crate_version = '0.6.0'
explanation = '''
Panic occurred in file 'binary-install/src/lib.rs' at line 231
'''
method = 'Panic'
backtrace = '''
stack backtrace:
   0: backtrace::backtrace::trace_unsynchronized::he1d27e8b92e94a04 (0x8491a6)
   1: backtrace::capture::Backtrace::create::h43aaae9b1576411f (0x8485c7)
   2: backtrace::capture::Backtrace::new::h520d7233ea5cce4d (0x8484ed)
   3: human_panic::report::Report::new::h839cde9df45b1308 (0x7a4bb2)
   4: human_panic::handle_dump::h134ff11bed5e05e1 (0x7a4287)
   5: wasm_pack::main::{{closure}}::h8c72e8f29a31a3e7 (0x408748)
   6: std::panicking::rust_panic_with_hook::h3927f23cac16933b (0x8768a9)
             at src/libstd/panicking.rs:482
   7: std::panicking::continue_panic_fmt::hf2eb4b7fbec2bc50 (0x876351)
             at src/libstd/panicking.rs:385
   8: std::panicking::begin_panic_fmt::hf3a851d1ec2578b2 (0x87629e)
             at src/libstd/panicking.rs:340
   9: binary_install::Download::binary::h3fe5a707e9048ec4 (0x4a15c7)
  10: wasm_pack::bindgen::wasm_bindgen_build::hada59395949e052f (0x43cc9e)
  11: wasm_pack::command::build::Build::step_run_wasm_bindgen::h57686dd5c3471621 (0x490828)
  12: wasm_pack::command::build::Build::run::h2a0877cd0b323cd9 (0x48f355)
  13: wasm_pack::command::run_wasm_pack::he9a1667742204c98 (0x40ec0f)
  14: wasm_pack::main::h7d196ec5bc2839af (0x4082be)
  15: std::rt::lang_start::{{closure}}::h021dcbffeaea1e4d (0x4091f2)
  16: std::rt::lang_start_internal::{{closure}}::h36f064ec31842c10 (0x8761d2)
             at src/libstd/rt.rs:49
      std::panicking::try::do_call::h5734c2c7b9290285
             at src/libstd/panicking.rs:297
  17: __rust_maybe_catch_panic (0x87fda9)
             at src/libpanic_unwind/lib.rs:92
  18: std::panicking::try::h56a23a8ffce2643b (0x876c59)
             at src/libstd/panicking.rs:276
      std::panic::catch_unwind::heb58e2bbe237901c
             at src/libstd/panic.rs:388
      std::rt::lang_start_internal::h493cdeb796ce7e8a
             at src/libstd/rt.rs:48
  19: main (0x4087c1)'''

Resolved!
wasm-pack downloads wasm-bindgen from aws server, which is blocked and doesn't redirect to another valid source.
Installing wasm-bindgen-cli through cargo manually can solve this problem.


cannot access JSON response data in uploadFiles callback

Hello, I tried to follow https://github.com/Wildhoney/EmberDroplet/issues/26 and your code to access the json callback of the request, with:
  actions: {
    uploadFiles: function(){
      //$.when(this._super()).then(function(res){
      this._super().then(function(res){
        log("finished");
        log(res);
      });
    }
  }

but this only sends "undefined", like if the response content was not sent in the callback. Can you explain how to access the response content? Thanks

Are you using the latest version? Because Droplet went through a major refactor lately to make it compatabile with Ember 2.0.
If you are, use the hooks property:
App.XDropletComponent = Ember.Component.extend($window.Droplet, {
    url: $window.location.origin + '/upload',
    hooks: {
        didUpload: files => console.log(files)
    }
});

Thanks. Yes I'm using the last version - though with Ember 1.12.1 as ember-listview is not ready yet for Ember 2.0. This seems to work alright, except for the issue https://github.com/Wildhoney/EmberDroplet/issues/91 which prevents overriding the default options - and probably the didUpload hook too (I see nothing logged when customizing the hook for now).

the didUpload hook properly gets the data.files object fetched by the server, though it doesn't recognize this (i.e. the component we are working on), which makes it very hard to work on the data (no access to this.store, this.sendAction etc.). I'm talking mostly here about Ember-cli uses, where we are not supposed to use global App.xx stuff.

@Leooo your issue should be fixed in #100


Cause AppYaml#parse() to wrap all YAMLException as AppEngineException

Wrap all SnakeYAML exceptions in our AppEngineException.

This change isn't actually required with the fix in #673. But SnakeYAML's exceptions are all RuntimeExceptions so it's hard to be sure that we're catching all relevant exceptions here.  Just looking at some of the possible YAMLExceptions and tracing them back, I found:

DuplicateKeyException, thrown by SafeConstructor, which we use in AppYaml
ComposerException which is on the call-chain of the Yaml#load(InputStream)

And some of the others also appear possible.

Hmm... May not be a bad idea to catch them all.


fix: add enzyme matchers to React Native enhancer

Looks good!

I think you missed updating the README here: https://github.com/moxystudio/jest-config/blob/master/lib/enhancers/enzyme/README.md#withenzymereactnative

I think you missed updating the README here: /lib/enhancers/enzyme/README.md@master#withenzymereactnative

Yes, you're right! 🙏
I'll update the README shortly. Thanks.


Can not log out when using OIDC

Describe the bug
I enabled OIDC authentication using Google. I can log in using my Google account. However, when I try to log out, I am immediately logged back in. There is no way of selecting a different account.
To Reproduce
Steps to reproduce the behavior:

Enable Google Authentication
Log in
select Logout in the top right  dropdown menu
you are redirected to the homepage and still logged in

Expected behavior
I would expect a page stating that I was logged out successfully, preferably with a link allowing me to log back in. When logging back in, I should be able to select the previous account, or use a different one.
Screenshots

Desktop (please complete the following information):

OS: Ubuntu 20.04.4 LTS
Browser Firefox
Version 99.0 (64-bit)

Additional context
Same behaviour in other browsers.

This there, can you please send the link for your Oidc Discovery URL? I want to confirm that it contains the "end_session_endpoint" param, which we use to log folks out when logout is clicked.

I notice that there is a revoke token endpoint present in some cases, which is not being used. My thought it that fixing this will be a matter of supporting token revocation, but still doing some investigation

I have a workaround solution, just only edit the code(change the href url)

Sign Out

to

Sign Out

I tested the workaround suggested by @sunli1223 and the problem was solved.

Thank you! I will raise a PR with this change.

This will be included in the next release.
Thanks for your input in helping solve this folks!
John

Currently running latest version v.0.13.2 and I'm still having this problem. I'm hitting Sign Out and I get redirected back to the home page. Is anyone else still having this issue?

Currently running latest version v.0.13.2 and I'm still having this problem. I'm hitting Sign Out and I get redirected back to the home page. Is anyone else still having this issue?

yes the same for me

Same here (0.13.2), i think this issue needs to be reopned.

i've thought this issue fixed long ago (was a big break between datahub usage).

Still an issue, tested on 0.14.1


Add a ssl_ca_cert flag for mTLS services that require common/custom CA cert.

Example desired use (works in local build with corporate certificate authority)
/Users/scr/CLionProjects/grpc/grpc/cmake-build-debug/grpc_cli ls --ssl_ca_cert ~/.athenz/ca.cert.pem --ssl_target <IP_ADDRESS> --ssl_client_cert ~/.athenz/cert --ssl_client_key ~/.athenz/key <IP_ADDRESS>:4443 --channel_creds_type ssl

@veblush

@scr-oath  Thank you for the PR. Could you sign EashCLA to unblock the review?
@yihuazhang Could you review this PR? PR looks good to me overall and I like you to see this in security perspective.

@scr-oath Thank you for the PR. Could you sign EashCLA to unblock the review?
@yihuazhang Could you review this PR? PR looks good to me overall and I like you to see this in security perspective.

I requested the CLA to be signed

LGTM.
Just F.Y.I. you can also use GRPC_DEFAULT_SSL_ROOTS_FILE_PATH env var to use the custom root certificate.


WIP: Reports as stream field forms

Fixes #ISSUEID
Add description here.

Locally I have PROJECTS_ENABLED = True and PROJECTS_AUTO_CREATE = True.

I pushed some of the test fixes and the workaround for the stream form file failures. Basically: exclude the file capabilities from the test setup factories. On our branch these are all passing now. Just to close the loop, the test failures are not a high priority issue anymore but they may come up again in a future context.

@bickelj Recommend taking a look at https://github.com/HyphaApp/hypha/pull/3822 and https://github.com/HyphaApp/hypha/pull/3823. Make sure you have not the same bug in this implementation.

@frjo After a quick glance at the issue, I think we do not have the same issue, but perhaps we didn't solve it the same way. I will take a look next week to see.

@frjo @wes-otf  I think this is ready enough for review. I could not reproduce the lint error above on lint-be task.

@bickelj Looking forward to testing this, and get it part of Hypha!

Rebase so these commits are on top of current main.
There are some merge conflicts, can you please fix these.
To handle linting automatically run pre-commit install. Then code will be linted when added to git.

See Makefile for manual lint etc. commands.

@frjo I see what happened. It was mostly well (rebased, merged) locally and I had pushed the branch to my GH fork but not this branch here. I just re-pushed it here and see I have some migrations to rename.

@frjo OK, I did some more cleanup but I'm scratching my head about the hypha/apply/review/migrations/0026_alter_review_visibility.py being needed in the first place and then the tests adding a 0027 on top of that. I think I only added that because of tests failing here back in January, I don't think we have that in our versions. I am sure it's something simple, but locally I don't see a need for anything new when running makemigrations.

@bickelj I can look deeper into it tomorrow but weirdly enough when I deleted migration 26, renamed the generated migration from 27 -> 26 and changed the dependencies to ("review", "0025_auto_20220722_0844"), it stopped generating a 27. Seems like a symptom fix though

tossing the __pycache__ in the migrations folder may (or may not) have an effect too but if the CI is also seeing it I doubt that's a factor

I tested to delete all migrations in this PR and redo them, see https://github.com/HyphaApp/hypha/pull/3845. I think that works but some other tests then fail.

I tested to delete all migrations in this PR and redo them, see #3845. I think that works but some other tests then fail.

Would you recommend this course here? There are some discrete steps in the commits, one creates wagtail form, another creates project form, and it might be easier to follow when broken up.
I guess that's another question: would you expect this whole branch to be squashed (along with the migrations), left as-is with the cleanup commits, or commits edited individually?

@frjo I guess that the migration hiccup is a commonly encountered Django bug and it is cheaper to regenerate migrations than to track down the issue, right?
Regardless, I see the path forward for me:

Squash
Regenerate migrations
Push

@frjo @sandeepsajan0 I think it is commit:35d32a76d90e07bc0cb8c74d6f12d9d8bb519bee that conflicts causing the test failure. I don't think we should require PAF to use Projects. One of the capabilities we added with this feature is to skip any number of Projects stages. For example, a Hypha instance can skip ahead to "Invoicing and Reporting" without doing PAF or Contracting in order to take advantage of the Reporting capabilities.

We will discuss reverting PR https://github.com/HyphaApp/hypha/pull/3829.

I rebased and removed the PROJECTS_INITIAL_STATUS but obviously more work is required due to test failures. I will investigate tomorrow.

I needed to include some more test-related changes, I'm not sure how I missed those other than the passage of time.

@frjo This should be ready for testing again.

@frjo if you don't beat me to it I can give it a go tomorrow

I added a minor fix to the submit and save buttons. Added some classes to make it the same as on other forms and updated the text to say "Save draft", as on other forms. This is fixes to old standing issues with report that fits well in this PR I think.

Looks & works great from my testing! Thanks for all the contribs & patience with this @bickelj & @frankduncan!

Woohoo! Thank you, @wes-otf and @frjo for reviewing, testing, and merging!


[Cherry-Pick]  add knativeLocalGatewayService to fix VS issue

What this PR does / why we need it:
cherry-pick : https://github.com/opendatahub-io/kserve/pull/431
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Type of changes
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

[ ] Test A

[ ] Test B

Logs

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

[ ] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[ ] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:

Re-running failed tests

/rerun-all - rerun all failed workflows.
/rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

/lgtm


Updated license date

Updated license date to 2015 for new year.

Thanks, was it bugging you or something? :)


Fix bug when popping scopes

Although only a single scope should be popped when ending a loop (like with {/foreach}), the bug had the equivalent effect of all scopes being popped.
Currently:

Fixed:

Thanks. Merged as 117ecfca


[pulsar-client] Get GettingAuthenticationDataException on Authentication Failure

Motivation
When a Consumer makes an authenticated connection (subscribe) and the connection fails due to incomplete authentication information, the application receives an RuntimeException: Failed to create TLS context.
In this case, GettingAuthenticationDataException is thrown by the following part, but the exception is not delivered to the application.
The reason is that RuntimeException is thrown in the catch statement.
https://github.com/apache/pulsar/blob/7d2f9b7184350c40778b0aa652283ef076f279b5/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarChannelInitializer.java#L105-L132
Therefore, the application cannot know the cause of the authentication failure.
Modifications

Catch and throw PulsarClientException containing GettingAuthenticationDataException.

Verifying this change

[ ] Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation

[x] doc-not-needed

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


Create a CONTRIBUTING.md

Created a CONTRIBUTING.md, but it's still quite rudimentary. At least it has the essential guidelines, we'll be adding more later.


Trying to subscribe to stae - however getting undefined

I am trying to use the angular-redux/store (very nice framework)
however I get some error - seems as timing issue
in my module I have defined the store
export class AppModule {   constructor(ngRedux: NgRedux<IAppState>) {     ngRedux.configureStore(reducer, InitialState, [createLogger()]);   } }
and in the app.component i have created a breadcrumb component. the breadcrumb supposed to be subscribed to the store - in order to know which steps is in valid state , otherwise it is disabled.
so
`@Component({
selector: 'app-navigation-bread-crumb',
templateUrl: './navigation-bread-crumb.component.html',
styleUrls: ['./navigation-bread-crumb.component.css']
})
export class NavigationBreadCrumbComponent implements OnInit {
@Input() entries: IBreadCrumbEntry[] = [];
@select('awsSteps') stepsValidation$: Observable<WizardStep[]>
constructor(private router: Router) {}
ngOnInit() {
this.stepsValidation$.subscribe(steps => {
if(steps) {
steps.forEach(step => {
let n = this.entries.find(entry => {
return entry.name === step.name;
})
      if(n) {
        n.valid = step.valid;
      }
    })
  }
})

}
goToRoute(url: String) {
this.router.navigate([url]);
}
}`
and i am getting undefined as the steps
however in other component which is loading later - all is ok
this is the state object
export interface IAppState {   aws: AwsState,   awsData: AwsData;   awsSteps: WizardStep[] }
is there an option to wait for the store to be ready?

What value are you passing as InitialState? is steps always undefined - or just at the initial subscribe?

the InitialState has value in it. also i have tried to bind to other properties in the state and got undefined while other components which were activated later got data

Hrmm, could try:
this.stepsValidation$.filter(steps=>steps != undefined).// the rest

although without seeing how the reducers / state is being setup unclear to why that would be undefined at the start.

@LirazRom doing some issue house cleaning, as there has not been any activity on this issue - closing it for now. If you are still having issues, please feel free to re-open, or start another issue.
Thanks,
Evan


Update the plugin version and date automatically

use the package.json version and current date in plugin.json

Changes look good! Could you please rebase and fix conflict again?
(Also, do you have owner push enabled? I got permission denied when trying to push a new yarn.lock.)

@davkal -- merged with master, should be good now.  owner push enabled, I have:

anything else?


Leaflet map on android 8.0.0 takes more than 10 seconds to load

Hello,
We're using leaflet map component for quite a while and this is a great peace of code. Thank you!
Currently we ran into a problem with the newest android version 8.0.0. Up until now our application was running on android versions 5 till 7 but our customers started to upgrade their devices to android v.8.0.0.
We use cordova environment.
The issue is that the load event of the map object occurs after 10.7 seconds on android 8.0.0 every time the screen with the map is opened. The same does not happen on older versions of android or iOS: the same event is fired within 1.5-2 seconds.
Leaflet version we're using is 1.0.3 but we tried it with the latest 1.3.1 and the behavior is the same.
To summarize:

Leaflet version: 1.0.3 (or the latest)
Browser: cordova (android v.6.0.0)
platform: android v.8.0.0
Steps to reproduce: basic map page, add event listener for map.on("load", ... and check how much time will pass till the map loads.

Thanks in advance

Hi, and thanks for taking the time to open a bug report in Leaflet.
However, in this repository we only handle bugs in "vanilla" Leaflet. This means that we do not handle bugs which are specific to frameworks such as:

React
Ractive
AngularJS
Bootstrap
Leaflet for R
Joomla
Wordpress
Ionic
Cordova
Vue
Electron
Polymer
TypeScript
...etc

Please understand that we only have the time and energy to test Leaflet in plain web browsers.
Please try to either reproduce the bug without using any frameworks, or submit a bug to the appropiate repo.


Fix spend input twice bug

Fixes #1099

Current coverage is 96.55% (diff: 100%)

Merging #1102 into master will increase coverage by <.01%

@@             master      #1102   diff @@
==========================================
  Files            49         49
  Lines          2177       2180     +3
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           2102       2105     +3
  Misses           75         75
  Partials          0          0

Powered by Codecov. Last update 05fdcef...33a51eb

The same needs to be done on the on the 0.8.1 branch so that we can release an hot fix


[Cognitive Services Text Analytics API] API Review

New API Review meeting has been requested.
Service Name: Cognitive Services Text Analytics API
Review Created By: Gil Shacham
Review Date: 1/26/2023 8:00 AM PT
PR: Cognitive Services Language API - Healthcare changes for 2023-04-15-preview, Cognitive Services Language API - Healthcare changes for 2023-04-01
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Text Analytics for Health Temporal Assertions
Description: Text Analytics for Health API changes for 2023-04-01 and 2023-04-15-preview
Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

Notes from API review Jan 26, 2022

Two new api-versions, 2023-04-01 (GA) and 2023-04-15-preview
Can we add values to an extensible enum without changing the api-version? No, that is not allowed by the Azure Versioning and Breaking Changes.  But you can add new enum values in a new api-version.
2023-04-01 -- this is to a dev branch and only adds enum values.
2023-04-15-preview -- adds temporality field
"current" vs "present"?  "current" seems fine
Changing language detected from a string to an object.

Does this change what actually flows on the wire?

Need to change the GA version

Object contains name, iso639name, confidenceScore

Both PRs look good. We'll approve the 2023-04-01 PR once the detectedLanguage change is added.

Cancelled by: Gil Shacham


List of issues, new (possible) features

Issues:

need to Vectorize() a few functions
Suppress st_intersects() warning?
Consistent tidy eval
Is keep.all really necessary?

New features to add:

standard error of density estimates
min # of cameras optional argument, or min number of days in operation?
update README with plots
include lure status, and adjust estimates accordingly
Add OG sites

Include lure status, and adjust estimates accordingly

Update:
Taken care of issues 1, 3, & 4 (deleted keep.all). Don't want to suppress st_intersects() warning anymore, that is useful information to the end user.
Included lure adjustment in all summary calculations. Don't want to add OG sites after all (violates assumptions, not placed randomly).


Add mock images for Catalog Service Items

Add images mock data '/imgs' directory and then we can use the github URL to those images to guarantee they exist. Have to be very careful what we use due to copyright rules.

Will the recent additions of the SVG images, I don't believe this issue is required anymore.


Typing cursor glitches out (moves to random (blank or not) characters of the line) while typing or deleting characters (video included)

Steps to reproduce
Download and install Powershell on Ubuntu 14.04
hold any letter
Expected behavior
Smoothly spams character of choice (or if actually typing doesn't spasm)
Actual behavior
Flies all over the place (and makes me unfocused af)
Youtube proof
Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      6.0.0-alpha
PSEdition                      Core
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   <IP_ADDRESS>
GitCommitId                    v6.0.0-alpha.9
CLRVersion
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

This issue was moved to lzybkr/PSReadLine#466


Switch to Node.js v18

Is your feature request related to a problem? Please describe.
The currently used LTS version of Node.js, 16, has only support for a few month. The next LTS version (18) is available since nearly a year.
Describe the solution you'd like
NEST Desktop uses Node.js v18.
Describe alternatives you've considered
n/a
Additional context
n/a

If NEST-Desktop would support Node.js v18 would be great. At the moment we get the error
[1/4] Resolving packages...
[2/4] Fetching packages...
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "8 || 10 || 12 || 14 || 16 || 17". Got "18.17.1"
error Found incompatible module.

hello @jhgoebbert,
In dev branch, we are using Node v20.
We are using nvm to switch node versions:
nvm use

-> https://github.com/nvm-sh/nvm

Thank you.
At the moment our build-infrastructure grabs https://github.com/nest-desktop/nest-desktop/archive/v3.3.1.tar.gz and runs a yarn install && yarn build. As it is not a manual install I will need to check how to combine that with an nvm-sh-call.

Ah, sorry, I checked nvm-sh now. It allows to install multiple versions of Node.js on a system. This is no solution for us :(
Would it be possible somehow to patch package.json for Node.js v18?

I apologize for the late response.
When I try to install some modules in NEST Desktop v3 with Node.js v18, I got this error:
yarn install v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "8 || 10 || 12 || 14 || 16 || 17". Got "18.18.2"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

I am not able to find the source for this error.
In general I am not happy with this setup of node modules
(See note comments for conflicting in package.json under "//").
In the current development (v4) I was careful to select specific node modules even Node.js v20. For now I am satisfied of this and I would like to focus on the development of new NEST Desktop.

Sure, no problem. I know these dependency hell.
We can still use nest-desktop from the last year's software stage 2023.

you need to be on @achrinza/node-ipc version 9.2.5 or later for node 18 support. (and 9.2.7+ for node 20)
https://github.com/vuejs/vue-cli/issues/7424#issuecomment-1771133820
I would assume that you have to update to a newer version of yarn.

I played a bit more with version 3.3.1 and a NodeJS (v18)

yarn set version stable - updates yarn to 4.2.2
I needed to upgrade to "vue": "~2.7", in package.json as it is required by<EMAIL_ADDRESS>I needed to remove @vue/composition-api in package.json as this is included since 2.7in vue
npm install electron-builder
yarn install
find ./src -type f -print0 | xargs -0 sed -i 's/@vue\/composition-api/vue/g' as @vue/composition-api is now part of vue
yarn build

... but switching to the included composition API needs some more manual adjustments than just a find+sed (step 6).
So the last step fails after some time of building ...
P.S: Anyway, this seems not to be a NodeJS v18 issue. Step 2 should fail independent of the NodeJS version.

This issue can be closed. NEST Desktop v4.0 is build with node v20.


How can I overrightPermission in cluster ?

How can I overrightPermission in cluster ?
I want to set permission for all Incognito page to crawl data from it like puppeteer
await context.overridePermissions('https://www.facebook.com/', ['notifications']);
But in puppeteer-cluster i don't know how to get browser or context to override this.
Tks you so much :D

You can get the browser of the page via page.browser() and from there on you should be able to set the permissions.
Example:
const context = page.browser().defaultBrowserContext();
context.overridePermissions(/* ... */);

Feel free to reopen if anything is unclear.


Shadowing an abstract property is not allowed (but should be)

Bug
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
            pydantic version: 1.6.1
            pydantic compiled: True
                 install path: /home/abodrov/.local/lib/python3.8/site-packages/pydantic
               python version: 3.8.2 (default, Jul 16 2020, 14:00:26)  [GCC 9.3.0]
                     platform: Linux-5.7.4-050704-generic-x86_64-with-glibc2.29
     optional deps. installed: ['devtools']

import abc
import pydantic

class AbstractModel(pydantic.BaseModel, abc.ABC):
    @property
    @abc.abstractmethod
    def some_field(self) -> str:
        pass

class ChildModel(AbstractModel):
    some_field: str
# NameError: Field name "some_field" shadows a BaseModel attribute; use a different field name with "alias='some_field'".

ChildModel(some_field='some_value')
...

@Drino your approach seems to be the suggested one here yet I of course get the same error. Did you find another the correct syntax to express an abstract property? I'd like to do the same!

@Drino thank you very much! Yeah I'd like to use ABC and be quite explicit. But the code doesn't seem to shake out too well..


Suggestion: Can we have a config to decide moving reactions to the left or right?

Thanks for your great work!
But it‘s just that I'm getting pretty used to putting reactions on the left.
I'm sure many users feel the same way.

Hey! The issue with having it on the left is that it would generally look quite cramped with the last line of text.
The style overrides are only a few lines of code, feel free to fork it and modify it to feet your needs. I would be keeping this one opinionated to avoid maintenance overhead.


added light theme for kitty, alacritty and .Xresources

Hey,
I found your light theme pretty nice and decided to add it to my terminal. That's why I ported it to all terminals I currently had installed.
I tested all of them briefly, but If you find any improvements, feel free to add them or let me know :).
Hope you don't mind me changing the directory structure of extras.
Also, I couldn't test the theme for iTerm, so I didn't add it.

Hey, I'm glad you like the light theme! Thanks for the pr, I'll test them out and add iTerm too. And yeah no problem, I think the directory structure is a good change!


can't build to sites/kit.svelte.dev

Describe the bug
pnpm build  not working in kit/sites/kit.svelte.dev
Reproduction
cd kit/sites/kit.svelte.dev
pnpm run build

Logs

Could not resolve '../../../../../../packages/kit/docs/types.js' from src/lib/docs/server/index.js
[vite-plugin-svelte-kit] Could not resolve '../../../../../../packages/kit/docs/types.js' from src/lib/docs/server/index.js
error during build:
Error: Could not resolve '../../../../../../packages/kit/docs/types.js' from src/lib/docs/server/index.js
    at error (file:///home/spring/github/kit/node_modules/.pnpm/rollup@2.78.1/node_modules/rollup/dist/es/shared/rollup.js:1858:30)
    at ModuleLoader.handleResolveId (file:///home/spring/github/kit/node_modules/.pnpm/rollup@2.78.1/node_modules/rollup/dist/es/shared/rollup.js:22350:24)
    at file:///home/spring/github/kit/node_modules/.pnpm/rollup@2.78.1/node_modules/rollup/dist/es/shared/rollup.js:22313:26
 ELIFECYCLE  Command failed with exit code 1.

### System Info

```shell
windows 11
wsl ubuntu 20.04.5

Severity
annoyance
Additional Information
No response

You'll need to run this script first
https://github.com/sveltejs/kit/blob/7fbc1a0eabb59753864f901b1b7fe8fd23a0a580/packages/kit/package.json#L69

@jasonlyu123
OMZ
I miss this CONTRIBUTING.md.
thank you.