Feature: Add search filters

Is your feature request related to a problem?
It is not possible to filter the search results.
Describe the solution
Use a menu to filter results.
This menu, visible after the searchbar, show the filters (date, size, extension, picture, video, ...)
This menu will require research to be complete but simple, practical and beautiful.

Capability
Priority

Show when a search is open
Must

Apply changes with a refresh
Must

Additional comment
I created a pull request that implements a minimal menu to better show the concept #4812.

@cinqmilleans Will the option always be visible, or only when the user searches something?

Only when the user searches something, to keep the ui as simple as possible.

@cinqmilleans I noticed you mentioned that the user will need to do the search again, is there a way we can apply the filter without the user doing the search again?

Not yet, but it's a good idea to add. We should keep the search bar open on the results page.

@cinqmilleans This issue has been approved, would you like me to assign it to you?

@yaichenbaum yes, thanks you.

@cinqmilleans Btw, instead of showing the filter option next to the path box, it should be in the toolbar underneath it.

The concept attached above (https://github.com/files-community/Files/issues/4813#issuecomment-836875139) is a wonderful and comprehensive representation of a hypothetical flyout which serves the purpose of allowing the user to add filters. I am attaching my concept which,
a ) shows how existing / applied filters can be represented.
b ) demos an alternate way to add filters.
a- (img 1) a small text element at the end of the search bar which represents what requirement the filter is serving. this will appear when the user hits enter and searches, before that, it will appear right beside the original search term
b-(img 2) [similar to the discord search and search filtering function mechanism](https://support.discord.com/hc/en-
us/articles/115000468588-Using-Search), you can just type a keyword/prefix related to your requirement (size, type, contains, etc.) and then type in your requirement (for example - size:>10mb , type:mp3. , etc.
 note : the filter icon triggers the flyout mentioned above.

@yaichenbaum any progress/update about this?

@hiranmayd The concept looks good. I'd like to give some time for others to give feedback on it.

@yaichenbaum @hiranmayd
We have 2 very different concepts:

A button/menu containing filters:

Easy to use.
Easy but long to implement.
The user must search for the filter they want.
Perfect for the basic user.

Filters to type manually in the search bar:

Quick to use.
Easy and quick to implement if there is a control to do so. Long and complex if we have to develop this control ourselves. I haven't looked to see if it already exists.
The user will have to find the right keyword, in their language, without ambiguity. We can provide help for that. For example, it should understand that "size" is the size of the file, but that "dimensions" is the resolution of an image.
He must also know how to write a value (a file size with the correct unit, a date whose format depending on the language), and an operator (>, startswith, ...)
Can be used entirely with the keyboard.
Perfect for the advanced user.

These 2 concepts are not contradictory. The menu could be a graphical interface to add filters directly to the search bar.

Why cant we use both?

What if i could click the button for the menu OR start typing in manually

ok for me

@cinqmilleans I like version 2 a little better since it doesn't get in the way of regular users, but it's still there for advanced users.

The concept attached above (#4813 (comment)) is a wonderful and comprehensive representation of a hypothetical flyout which serves the purpose of allowing the user to add filters. I am attaching my concept which,
a ) shows how existing / applied filters can be represented.
b ) demos an alternate way to add filters.
a- (img 1) a small text element at the end of the search bar which represents what requirement the filter is serving. this will appear when the user hits enter and searches, before that, it will appear right beside the original search term
b-(img 2) [similar to the discord search and search filtering function mechanism](https://support.discord.com/hc/en-
us/articles/115000468588-Using-Search), you can just type a keyword/prefix related to your requirement (size, type, contains, etc.) and then type in your requirement (for example - size:>10mb , type:mp3. , etc.

How would this work in a more narrow SearchBox?  There needs to be a way to view the filters applied, even when space is limited.

@mdtauk In the case where the search box is narrow, perhaps the filters can be moved to a flyout.

@mdtauk In the case where the search box is narrow, perhaps the filters can be moved to a flyout.

Sure, but isn't your plan to have the search box itself in a flyout?  Wouldn't a flyout in a flyout cause issues?

Sure, but isn't your plan to have the search box itself in a flyout? Wouldn't a flyout in a flyout cause issues?

The search box isn't in a flyout and we don't have any plans to put it in one.

How would this work in a more narrow SearchBox? There needs to be a way to view the filters applied, even when space is limited.

overflow menu besides the add filter button?

I am starting to implement the functionality cleanly. I am using the second concept, but it will be easy to add the first concept later if we decide to.

@yaichenbaum @hiranmayd @mdtauk Here is a demonstration of how filters are presented. Look not at the visual style, but at the principles. Filters can be typed or chosen from the filter menu, with suggested options.
https://user-images.githubusercontent.com/46631671/119220550-5b7e0b00-baeb-11eb-8711-e3f36b71bf8c.mp4

love it

@cinqmilleans It looks good! Can you provide a proof of concept design for smaller windows?

@hiranmayd Thank you.
@yaichenbaum Here is a working prototype. There is a minimum size for the TextBox. If the filters are larger, a new button appears to show the hidden filters. The items in this menu will likely use a different template.
https://user-images.githubusercontent.com/46631671/119274967-c6763180-bc12-11eb-95f5-06abbdd2c035.mp4

@cinqmilleans It looks good!

@hiranmayd @yaichenbaum
Quick message to report that the feature is progressing well.
It takes time to have robust and efficient code.
I should be able to show in a week.

@cinqmilleans Thanks for the update!

nice to hear

Here is the status. Unlike the previous videos, which didn't really work but just showed the principle, here it works.
Creation of an interface to be implemented to add new search options.
There are only 3 options currently. The following will come after the publication of pr.
Suggestions for options and values (which serve as examples),
Previously, pressing down would select the first option and activate it.
It was not possible to select the 2nd option on the keyboard. This is fixed.
More advanced visual. I would need some help improving Styles.
Enter, Tab and Space keys to validate an option, < and > automatically inserts the : if necessary.
To end: Localise texts, choose better suggestions, Fix minors known bugs, Improves styles
https://user-images.githubusercontent.com/46631671/121775562-c8d00980-cb88-11eb-8b5a-dc574cafca46.mp4

@cinqmilleans Nice work! One suggestion for the visuals would be to use an 8px corner radius for the selected filters. I would also add proper support for dark theme.

8px corner radius
would you mind trying out 4px too? thanks.

@yaichenbaum @hiranmayd
I haven't had much time, but now I can move on with this feature.
The main problem is that the user knows which command to write.
I added a panel for each option, to explain and select the value.
Here is an overview of the progress.
https://user-images.githubusercontent.com/46631671/123835548-f8ad3a00-d908-11eb-9539-1b8fff4c5d25.mp4

@cinqmilleans Are you sure we need the overview? I was thinking that most people would just use the flyout instead.

@yaichenbaum The flyout only contains the list of options, but not the possible values. The user must know the format of the filters. Indicating this in the flyout will be very busy. Using the popup allows you to have a presentation for each option. Later there will be a lot of options.

@cinqmilleans I was under the impression that the flyout would let you fill out the values and it would automatically generate the correct sysntax in the search bar.

For reference, here's the windows 11 styling of the filter ui.

Just sharing an idea I have been working on

tapping on one of the Advanced search items, slides the panel to the side, and displays UI related to that item, like the Dates UI here
https://github.com/files-community/Files/issues/4813#issuecomment-870750858

Following comments in the discord

Search pane with some parameters already set

When pressing the Date entry, or possibly when entering date: into the Search Box

@yaichenbaum  @mdtauk
Magnificent. I already have the back-end code. Your front-end is fantastic. But what is the textbox for if you use the one in the large search bar?

@cinqmilleans I was hoping that the flyout would have a UI similar to the Microsoft Store.

@yaichenbaum @mdtauk @winston-de
I am thinking of doing this:

In the search bar, a button that opens a vertical flyout that allows you to choose the options (basic user)
Possibility to write an option in the search bar (advanced user). When the user starts writing the option, a popup displays the syntax (like in the video above, but with static content, with no interaction).
In both cases, add the option in a small control to the right of the search bar.

I already have something that works, but it doesn't look very nice. With the visual of mdtauk, it will be perfect.
yaichenbaum, can you develop your idea?

@yaichenbaum @mdtauk
Magnificent. I already have the back-end code. Your front-end is fantastic. But what is the textbox for if you use the one in the large search bar?

The textbox in the Search Pane is the only one for searching.  There would be no more search bar in the Address Bar area.  That will be the breadcrumbs and for typing in a specific path for navigation.
The textbox in the Search Pane is for entering the text which could be in the file contents, or filename.  You also use it to enter the query syntax manually if you are a power user.

@cinqmilleans I was hoping that the flyout would have a UI similar to the Microsoft Store.

Removing the search box from the Address Bar would give more space for navigation, and will allow richer UX by having a pane dedicated for all search functions.
Flyouts could be irritating if they are light dismiss and you are still setting up your search parameters.

Just a visual example of how the Search pane would transition when choosing some parameter to set...

@yaichenbaum @mdtauk @winston-de
I am thinking of doing this:

In the search bar, a button that opens a vertical flyout that allows you to choose the options (basic user)
Possibility to write an option in the search bar (advanced user). When the user starts writing the option, a popup displays the syntax (like in the video above, but with static content, with no interaction).
In both cases, add the option in a small control to the right of the search bar.

I already have something that works, but it doesn't look very nice. With the visual of mdtauk, it will be perfect.
yaichenbaum, can you develop your idea?

I think being able to see hints in the flyout for the manual text syntax would work well whether it is in the TextBox in a Search Pane, or if it is in the Search Bar up in the toolbar.
The flyout should probably be more like the Teaching Tip with static hints that update as you type.

@yaichenbaum @mdtauk If everyone agrees, I do it like this.

If you were to do it like this, the pane on the right should be a component that hosts content.  So the same area and behaviours can apply to the preview pane and any future ideas.
Think it through before implementing :)

This is a technical detail. There is already the UserControl PreviewPane, there will be SearchPane. We can create a panel that displays one or the other, or put them in a flyout. It can change later. The most important thing is to have a good implementation of the control and the model.

@yaichenbaum @mdtauk @winston-de
I am thinking of doing this:

In the search bar, a button that opens a vertical flyout that allows you to choose the options (basic user)
Possibility to write an option in the search bar (advanced user). When the user starts writing the option, a popup displays the syntax (like in the video above, but with static content, with no interaction).
In both cases, add the option in a small control to the right of the search bar.

I already have something that works, but it doesn't look very nice. With the visual of mdtauk, it will be perfect.
yaichenbaum, can you develop your idea?

@cinqmilleans my idea is to add a flyout which has a date picker and some combo boxes for basic filters. This should cover regular use cases. In addition to this, users will be able to do more advanced searches from the search box itself. We can create a documentation page with instructions on doing advanced searches with the search box.

@yaichenbaum @mdtauk
In fact, the 2 solutions (the current search bar with a filter button, or a new panel) are very similar. The model and the model view are the same. You have to create a filter construction control that can be used for both cases. You have to manage the parsing of the text field in both cases.
I'll continue with the current search bar, taking inspiration from the new design for the filter menu.
If we want to go to a panel later, it will be easy. It will just be necessary to modify the view layer but using the same sub-controls and class.

@yaichenbaum @mdtauk
Here is a new general presentation.
This is an overview of the interface structure, before continuing with the interface implementation.

The filter menu in the search bar allows you to easily create filters, with a control for each type of filter.
This menu is also available by clicking on an option, to view the details and delete / modify the filter.
The search bar displays the syntax of the suggested command.
The filter menu will also display a link to a page containing the list of commands and syntaxes.

Is it OK ?
https://user-images.githubusercontent.com/46631671/125095576-9c9aa080-e0d4-11eb-94b0-c1c73952f1ba.mp4

Most of my views are likely nitpicks, so I will wait to see what @yaichenbaum thinks

@cinqmilleans I like the concept and layout, it needs some polish, but I think we should continue working on this idea.

The correct padding and spacing should be used for the flyouts;
Accent colour should probably be used for the Search filter badges;
Special attention will need to be paid to the localisation of the search hint text and filters;
The transition should be toned down a little for the flyouts;
Some alternative may be needed for a narrow window, for the filters;
Maybe consider appending each filter to the bottom of the flyout, and have them persist as you move from flyout to flyout?

@yaichenbaum @mdtauk
Here is the status of the user interface (The model is well advanced too.)
Recently the search bar has become always visible (except in compact mode) with a fixed size.
I adapted the interface:

The menu is the width of the search bar. It's a simple flyout with style.
Indicating the filters directly in the textbox is tricky, due to lack of space and this duplicates the menu.
So I withdrew it.
When there are active filters, we change the style of the menu button (here in color, but I'm looking for better).
This allows visual feedback when adding a filter with the textbox.
The suggestions are already displayed in the same way as the menu.

@cinqmilleans That looks pretty good, we'll work on a proper design spec based on that to make sure it fits the rest of the app.
fyi @mdtauk @itsmichaelwest

@cinqmilleans I have some design specs that are still being worked on, but they should be enough to work off of for now.

@yaichenbaum
It looks nice. I like. It has the advantage of allowing long texts (the current design is very nice in English because the texts are very short, but in other languages it is very ugly).
Here are some remarks.

About the indication of active filters in the search bar. It's nice with only one filter, but with several it takes up all the space, and it duplicates the menu.
About the choice of the date, it is practical to be able to choose an interval (before, after or between 2 dates). In the picture, we don't know if it's before or after.
About color tags. The file search is converted to AdvancedQuerySyntax (AQS) query and used by the Windows search engine. We do not manually filter the files, it would not be efficient. I don't know how the color tag information is stored, but we may not be able to search for this criteria.

I will adapt the view to this idea (the model and viewmodel is already sufficient).

About the choice of the date, it is practical to be able to choose an interval (before, after or between 2 dates). In the picture, we don't know if it's before or after.

How would you want to handle this?

I have a few questions in regards to the current prototype:

How do you add search criteria, or can you only search for the specific attributes provided below the search box?
Is there a way to define OR or NOT comparisons for all types?
Can you define your own file extensions to compare against?

@yaichenbaum Here is an overview of the Size page. I had difficulty with the Control Range, but now it works fine.
https://user-images.githubusercontent.com/46631671/132237791-aeb33832-165c-491d-a1b4-161d1fe127c6.mp4

@yaichenbaum Here is an overview of the Size page. I had difficulty with the Control Range, but now it works fine.
SizeFilter.mp4

Looks good! When are we going to see a PR 👀

@yaichenbaum Thank you. I will finalize the rendering of the main page, and we can consider the pr. Does the new version of October 4 have an impact on the pr?

@yaichenbaum Thank you. I will finalize the rendering of the main page, and we can consider the pr. Does the new version of October 4 have an impact on the pr?

It likely does as we aren't merging changes like this until a little after v2 is released.

@yaichenbaum Here is the progress of the search menu.

The root page can be used. You have to choose the filters in a menu.
The Date and Size pages have been enhanced to be able to choose a range of named values.
The Kind page is still under construction.

https://user-images.githubusercontent.com/46631671/133615154-783469ab-a716-408b-8ef1-3579009c1c32.mp4

@yaichenbaum looks like great progress, looking forward to the PR!

@yaichenbaum I had made good progress, but everything is at a standstill. For 2 weeks, the application no longer works in visual studio. I created issue #6304, with no response. I completely erased my hard drive to install Windows 11, but it didn't fix anything. For 2 weeks I have tried everything, I can no longer work on the application. If anyone can help me that would be wonderful.

@yaichenbaum A thousand thanks, it works! (version 16.11.2)

There's a lot of great feedback here but it seems like we need to go back to the drawing board on this feature and figure out exactly what we do or don't want to support.

For starters, are these filters something that should be specified before searching, or can they be set after a search? I'd lean towards the second option as that would allow us to implement it in a way where it can be used even outside of a search.

I will do some tests to estimate the amount of work.

Not updated since last year. still planned ? implementation was great

It's still something we're planning to do, but we need to do some more work on the requirements.

Tried this software a year or two ago but ended up using Directory Opus. Files is more developed now and is better for ARM devices so am now back trying Files and it has got a lot better. Only issue I have is not being able to search file contents intuitively - you need to prefix "contents:". When this is done, I will roll this out to my business as Windows File Explorer is very slow on synced Sharepoint/OneDrive libraries.


off-click-filter not working with ng-repeat

Think the problem with off-click-filter and ng-repeat is back, at least in my use-case. I believe it has to do with the es6 revision of angular-off-click not using the document query selector anymore. I don't have a codepen or plunkr to demonstrate, but here's my setup code and the console output I've seen from debugging:

I have a custom directive <toolbar-separator> that I pass in a name to ("document" in this case) and inside the directive the id of the div gets set to that (via
). So the end result in the html is:
<toolbar-separator>

 ...

</toolbar-separator>

 ...

So, the html is generated correctly.
The goal is for the toolbar-separator to be a modular toggle that expands a toolbar, and the
 below it is an associated area that has controls visible when the toollbar is expanded. Thus, clicking on the
 area should not deactivate the toolbar.
In the console however, I see this:

As you can see, the target is correct (when clicking on the
), but the currentElem is wrong - it's using the element without the ng-repeated items inside of it and so it doesn't match.
If there's anything else I can do to clarify or assist, don't hesitate to let me know.

@zlovin off-click-filter accepts a string of comma separated selectors, meaning if your id is #document, you would have to point to ##document

According to your comment where you say the toolbar-separator compiles to
<toolbar-separator>

 ...

</toolbar-separator>

then yes, it should required 2 hashes

I wrote that wrongly, the id is just {{ctrl.name}} so it comes out to

 ...

After a bit more digging around and debugging, I've tried to rule out some things.
First, I'm not using JQuery in my project, just relying on angular's jqlite so I'm not sure that the .contains() function in targetInFilter is working properly (see https://docs.angularjs.org/api/ng/function/angular.element). When I tried to use lodash's _.keys() function on the currentElem, it said that there were no keys, so I'm not sure there are functions available.
Second, I noticed that the classes on the currentElem are different than the classes on the target. I think that may have to do with initialization, or the fact that I'm using angular material.
Here's an example:

Plan A: I added in the red 'blah' box as an item that has an off-click-filter for '#document' on it, like the Resume card does. In the console at the first currentElem part, the lefthand element has 'layout flex' as attributes, but the righthand target has both 'layout flex' attrs and 'layout-row flex' classes.
So, plan B: Add 'layout-row flex' as classes from the start instead of relying on material to make them:

Exact same problem. Now the element and target look identical, but it still returns false.
Plan C: Add JQuery into my project and see if it fixes the problem. Still broken.
Plan D: Test out the .contains() function.

I made a smaller, nested box inside of my other box, maybe .contains() wasn't working because it was the root element or something? Still returns false for contains. Now I'm just really confused.

If it's not too much of hassle, could you setup a fiddle or similar where I could see this happening?

@Ricardo-Marques Here's a plunkr: https://plnkr.co/edit/qwxC7oE93wC7w2VsUzOO?p=preview
For some reason it works in the plunker though, and it doesn't work for my local. Everything is basically the same. Hover over the 'Documents' toobar and an icon will show up on the right, click it to open the toolbar options. Clicking on the card or the box should keep the toolbar open, clicking outside of those should close it.
So, I need to find out why it works there but not on my local development environment. Culprit #1 is that when I hover over the currentElem in the plunker, it highlights it. It doesn't highlight it in mine.

@zlovin Could I bother you to make a PR? :)

@zlovin Pushed with your fix, can you confirm it's working with the latest V1.0.2 ?

Also, I'm 99% sure the reason this issue was happening in the first place is the other directives on the element with off-click-filter altering the element during pre-link (which is something I should've considered)

@Ricardo-Marques I'll check it out tomorrow, don't have the time to do it tonight. I did run into an issue earlier though with the destroy function that was fixed by changing it back to elem[0] instead of element[0], I'll see if that problem persists tomorrow.
I'm not too versed in the pre-link and post-link and compile stuff, so this has mostly been fumbling about on my part haha.

@Ricardo-Marques I can confirm that the fix and v1.0.2 works for my application. I have another issue that might be related now, however. I've updated the plunker (and cleaned up some of the coffeescript -> javascript code): https://plnkr.co/edit/UaOv3Ru602ewG9iTwVqS?p=preview
When the toolbar is opened, a triple vertical dot menu is available on the card. Clicking it opens a menu. The menu has two items that use ng-click to call controller functions, editDialog and removeDialog. For simplicity's sake, I just added them to demoCtrl and they should log to console a string, but they never get called.
As a sanity check, I also added in the openDocument function, when you click on the icon or the document's name it logs 'opening document', and that works regardless of whether or not the toolbar is open. So, maybe it's an odd interaction between angular-off-click and angular materia's mdMenu, probably caused by the menu doing some odd stuff with the DOM tree because it inserts the menu's html inside the  tag rather than inside the  element. I've fixed that by adding in another off-click-filter on the .
However, an error is thrown on $destroy when the menu is closed normally, because inside the $destroy function the element is set to equal null and there is some misc. cleanup that angular-material does that seems to get messed up because the element was nulled. By commenting out element = null on line 131 of offclick.js, the error wasn't thrown. Is the element set to null as a cleanup / memory leak 'fixer'?

@zlovin in your demo plunker the controller functions for the card menu execute for me.
As for element = null I'm fairly certain that's to force js garbage collection, but @TheSharpieOne might know of something I don't. Definitely an interesting issue though,

@Ricardo-Marques Yeah, it wasn't working originally until I put in the off-click-filter on the md-menu-content, accidentally fixed it in the process of writing the last message.
As far as the element = null, things still function but it's likely not desired behavior for the material component to fail its cleanup.

@Ricardo-Marques Yeah, it wasn't working originally until I put in the off-click-filter on the md-menu-content, accidentally fixed it in the process of writing the last message.
As far as the element = null, things still function but it's likely not desired behavior for the material component to fail its cleanup.


Run generation rules against resources from CloudQuery

Indexer wrapper around CloudQuery
Prototype/test codebundle with gen rule for Azure.
Work out if there need to be any enhancements to the gen rule format/mechanism to work with CloudQuery resources.
A simple implementation of this was included in the proof of concept spike for CloudQuery, but a bunch of hacks were made to get that to work, so the focus of this task will be polish up the prototype code.

I suspect with the release of the azure and gcp indexers, we can probably close this one out.


Docs: Adding maintainer rules

As the Wiki has now been updated with the project roster, I've added in some rules for maintainers to follow when reviewing/accepting pull requests.

Thank you @nickdgriffin


Implement paragraph tag tokens in RC pipeline

aferritto created the following on Feb 22:
Original issue: https://github.ibm.com/ai-foundation/PrimeQA/issues/44

@bhavani105 : please update the status and the pipeline label for this issue

This is not needed as NQ implementation achieves good performance without it as per the PR https://github.com/primeqa/primeqa/pull/255


Same Session cookie for different url's / domain

Hi,
I want to use same session cookie with different urls
Like , I am getting session cookie from url "http://example.com/login"
After getting session cookie from above step, I could set cookie using
Alamofire.Manager.sharedInstance.session.configuration.HTTPCookieStorage?.setCookies(cookies, forURL: URL, mainDocumentURL: nil)
Also, I think this needs to be done only one time because Alamofire Manager is a Singleton class.
Now, I want to use this session cookie with URL "http://example.qa/mobile/alerts" (please note this time domain changes from .com to .qa),but I think Alamofire Manager is sending the default session cookie, not the one which I set previously.
In this case, it seems that session cookie is dependent on domain name. Is there any workaround
to make this work?

The singleton Manager instance uses the shared cookie store and automatically sends cookies with each response. However, in your case since you're switching domains, you most likely need to send the cookie through a Cookie header.
In the future, questions like these should be opened on Stack Overflow. We use our GitHub project for bug reports and feature requests.
Cheers. 🍻

From our Contribution Guidelines
Asking Questions
We don't use GitHub as a support forum. For any usage questions that are not specific to the project itself, please ask on Stack Overflow instead. By doing so, you'll be more likely to quickly solve your problem, and you'll allow anyone else with the same question to find the answer. This also allows maintainers to focus on improving the project for others.


Unified serialization and evaluation using Flatbuffers

This PR addresses two problems in Opaque:

Brittle serialization logic: Rows are currently serialized using error-prone custom byte manipulation logic. This has led to a number of problems when handling edge cases like empty partitions.
Query inflexibility: Operators and expressions are indicated using opcodes that represent specific, hardcoded queries. This makes it very tedious to express new queries.

This PR solves these problems using Flatbuffers, a fast serialization library with explicit schemas.

Flatbuffers serves as a unified serialization format for rows, operators, and expressions. The PR includes schemas for each of these.
The enclave contains an interpreter that can handle arbitrary expressions serialized using this format.

Because we implement boundary processing for join and aggregation using pure Scala, this fixes #13.
It will be ready to merge when it reaches feature parity with the current version of Opaque. Checklist:

[x] Project
[x] Filter
[x] Single-partition sort
[x] Distributed sort
[x] Single-partition inner equi-join
[x] Distributed inner equi-join
[x] Aggregate

Hooray!


Cannot cast object 'UNKNOWN-UNKNOWN' with class 'eu.bitwalker.useragentutils.UserAgent' to class 'eu.bitwalker.useragentutils.UserAgent'

Hi,
I'm trying to setup redisson for tomcat 8, and i'm getting this exception at the start:
org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot cast object 'UNKNOWN-UNKNOWN' with class 'eu.bitwalker.useragentutils.UserAgent' to class 'eu.bitwalker.useragentutils.UserAgent'
I think it may be related to incorrect dependencies? In order to get the tomcat to start withouth errors, i had to manually add some libraries to the tomcat instance because redisson was failing with multiple exceptions related to classNotFound, these are the dependecies i had to add:

fst-2.57.jar
objenesis-3.1.jar
UserAgentUtils-1.21.jar

This is the redisson.conf i'm using
{   "singleServerConfig": {     "idleConnectionTimeout": 10000,     "connectTimeout": 10000,     "timeout": 3000,     "retryAttempts": 3,     "retryInterval": 1500,     "password": null,     "subscriptionsPerConnection": 5,     "clientName": null,     "address": "redis://xxxxx.0001.use1.cache.amazonaws.com:6379",     "subscriptionConnectionMinimumIdleSize": 1,     "subscriptionConnectionPoolSize": 50,     "connectionMinimumIdleSize": 24,     "connectionPoolSize": 64,     "database": 0,     "dnsMonitoringInterval": 5000   },   "threads": 16,   "nettyThreads": 32,   "codec": null,   "transportMode": "NIO" }

try to update to 3.13.3 version

i'm already using that version, redisson-all-3.13.3.jar and redisson-tomcat-8-3.13.3.jar

if you didn't define coded then MarshallingCodec is used and this issue is the same as https://github.com/redisson/redisson/issues/2984

Could you try this version https://github.com/redisson/redisson/issues/2984#issuecomment-677187225 ?

the 3.13.4 fixed the problem, thanks!


Upgrade to 4.9.0

Just installed using the helper and got Wordpress 4.8.2. Not too far out of date, but 4.9.0 is available.

Thanks for the report. I think we should use the latest link.
https://wordpress.org/latest.tar.gz

#492 should fix this

@elharo are you still getting the issue?

Haven't tested it since I installed 4.8.2. The upgrade script doesn't work, but that's a separate issue.

What issues are you getting when you run the upgrade script?

I'm trying to upgrade WordPress on App Engine standard using the wp
cli (since App Engine WP can't use the usual wordpress upgrade
system.)
This dies with
$ vendor/bin/wp core update --path=wordpress
PHP Fatal error:  Class 'Memcache' not found in
/Users/elharo/cafe.elharo.com/wordpress/wp-content/object-cache.php on
line 425
Fatal error: Class 'Memcache' not found in
/Users/elharo/cafe.elharo.com/wordpress/wp-content/object-cache.php on
line 425
The problem seems to be that the memcache module isn't found in the
local PHP install. However I installed with with brew and
$ ls /usr/local/etc/php/5.6/conf.d
ext-igbinary.ini ext-memcached.ini

Is there a step I missed somewhere to install the Memcache module?

OK, got past that bug. I needed to brew install memcache instead of brew install memcached
Now it's dying with
$ vendor/bin/wp core update --path=wordpress
PHP Warning:  require_once(google/appengine/api/urlfetch_service_pb.php): failed to open stream: No such file or directory in /Users/elharo/cafe.elharo.com/wordpress/wp-content/plugins/google-app-engine/modules/urlfetch.php on line 72
Warning: require_once(google/appengine/api/urlfetch_service_pb.php): failed to open stream: No such file or directory in /Users/elharo/cafe.elharo.com/wordpress/wp-content/plugins/google-app-engine/modules/urlfetch.php on line 72
PHP Fatal error:  require_once(): Failed opening required 'google/appengine/api/urlfetch_service_pb.php' (include_path='.:') in /Users/elharo/cafe.elharo.com/wordpress/wp-content/plugins/google-app-engine/modules/urlfetch.php on line 72
Fatal error: require_once(): Failed opening required 'google/appengine/api/urlfetch_service_pb.php' (include_path='.:') in /Users/elharo/cafe.elharo.com/wordpress/wp-content/plugins/google-app-engine/modules/urlfetch.php on line 72

This appears to be https://github.com/GoogleCloudPlatform/php-docs-samples/issues/314


deepPluck returns non-empty array ([0]) when there are zero matches

The following line
_.deepPluck([],"fakepath.fakepath")
is returning a non-empty array with a "zero" in the first position.  My expectation was that it would return an empty array.

I tested this in Node and different browsers, and it works as expected. I think you where misled by the way (Chrome) developers tools sometimes display an empty array.


Feature request: Notebook support

I use the ms-vscode.vscode-markdown-notebook Markdown Notebook extension by Microsoft.
The big advantage of the notebook interface is, that you have the combined advantages of the preview and the Markdown text editing experience. So you can view your formulas and graphics while editing the next paragraph. Or you can rearrange your cells easily. Since it's Markdown, version control works fine too.

Hey! This plugin works through the LSP, so if the markdown notebooks support LSP, then oxide should work well. Otherwise, I'm happy to accept a PR for this :)

Only the built-in LSP:  https://github.com/microsoft/vscode-markdown-languageservice
I guess there is no way to replace the built-in with another LSP?
(Up to now, I've only tried Jupyter-kernels, which work in the code sections.)

perhaps this is a config option? markdown lsp: oxide -- or something like that


RMN tutorial 404

404 for this page
https://ampbyexample.com/advanced/Rich_Media_Notifications/

Hi, where did you get that link from? https://ampbyexample.com/advanced/rich_media_notifications/ works and I got it by navigating from the menu


Snappy compression support + various fixes

Changelog:

added support for Snappy compression

introduced Error constants for easier identification of specific error conditions whilst decoding messages in a packet, and refactored the message interation.  This is especially important to tell real errors (invalid checksum, malformed message) from the "incomplete message at end of packet" error. Previously, the code was incorrectly attempting to move the request offset by 4 bytes until the end of the current packet, instead of simply doing a new fetch request from the last valid offset.

added ProduceFromChannel() method in the publisher, mirroring the ConsumeOnChannel() method in the consumer

changed the quit channel type to empty struct{} to save an allocation, and to let people communicate the intention to stop by closing the channel instead of adding a bool value (useful in case of multiple listeners to the same event).  This change unfortunately breaks the signature of the ConsumeOnChannel() and Consume() methods, but hopefully it's worth it.

added ability to stop the consumer externally, without incurring in panic() events when closing the channel. There was a race condition when force-quitting the consumer because of an internal error.

reused connection in BatchPublish(), instead of establishing a brand new connection every time.

applied gofmt / golint on the code  (renamed Id() to ID() for compliance)

added comments

thanks!


Preparing for 1.2.0

PR checklist

[x] This comment contains a description of changes (with reason)
[x] CHANGELOG.md is updated
[x] If you've fixed a bug or added code that should be tested, add tests!
[x] Documentation in docs is updated
[x] If necessary, also make a PR on the nf-core/diaproteomics branch on the nf-core/test-datasets repo

fixes #69

The changes look generally good to me. Just one thing that I noticed in the context of the changes that affect parallelization: the workflow lacks resource descriptors for all processes. Currently, all processes are assigned the same resources, even those that do not support multithreading. In particular, many of the OpenMS TOPP tools (even though they offer a -threads flag) do not support multithreading.


Just need help

I need help just to know if there is any way i can just let the ESP Player able to use, so any thing i can do to take out the rest

This is outdated but i am pretty sure he removed all the memory writing so it is just kmbox aimbot and player ESP:
https://github.com/sullivanb26/RustDMAkmbox


Add queryPage and scanPage to DynamoDb table mapper

Previously, the table mapper would only expose a Sequence<Document>.  While this makes it easy for the client to iterate over all the pages, it's impossible to efficiently drop or request specific pages.  This addition will expose DynamoDB's cursor-based pagination through the mapper.
In addition, I have fixed a bug where the LastEvaluatedKey would always be the key for the table's primary index, and not the current index.

ready to 🚢 ?

Overnight I realized I missed a test case.  It's been added now, so after the build, should be ready to :shipit:


setup: delegate redis flush command

Create a CLI command to flush redis in the appropriate module (invenio-app?).
Currently we are using:
invenio shell --no-term-title -c "import redis; redis.StrictRedis.from_url(app.config['CACHE_REDIS_URL']).flushall(); print('Cache cleared')"

As a single command, however this should be delegate and run something similar to invenio redis flush.

Should it be delegated because it causes issues when ran under Popen and such? It would be very minor...


Rocket launch recipe should not use factory

The synthetic "rocket-launch" recipe is currently set up to use the rocket silo as its factory. This is probably not useful. The recipe's crafting time is not meaningful, and modules in the building should properly be thought of as affecting the rocket-part recipe. Although the rocket launch does occur in the rocket silo, this is basically a coincidence as far as the calculator should be concerned.
One wrinkle is that, although the rocket silo makes rocket parts and then launches a rocket when it has 100 of them, it requires a bit of time to play the rocket launch animation (approximately 12 seconds; should verify this exactly). This limits how quickly a single silo can launch rockets, and it might be useful to communicate this, somehow, when giving the factory count for the rocket-launch or rocket-part recipes.
Another wrinkle is that this means it isn't useful to use a factory count when specifying space science as a build target. Some additional logic should be added to properly handle the case of a build target not using a factory. (This bug already exists in the case of crude oil, which is the only other item to not use a factory. Specifying it as a build target results in an exception.) Instead of defaulting to 1 factory, such items should default to some arbitrary rate (e.g. 1 item/second), and the "Factories:" box should be grayed out.

Done in 7ff83b8dbcac3b5d304b21d92321c84175a52dd2.


boards: arm: frdm_k64f: remove label from spi SDHC

remove deprecated label property from spi sd host controller, to fix twister failures.
Signed-off-by: Daniel DeGrasse<EMAIL_ADDRESS>

Fixes twister failures seen in #50015

This PR fixes the https://github.com/zephyrproject-rtos/zephyr/issues/50023.


KAFKA-12675: improve the sticky general assignor scalability and performance

I did code refactor/optimization, keep the same algorithm in this PR.
I've achieved:

Originally, With this setting:

topicCount = 50;
partitionCount = 800;
consumerCount = 800;

We complete in 10 seconds, after my code refactor, the time down to 100~200 ms

With the 1 million partitions setting:

topicCount = 500;
partitionCount = 2000;
consumerCount = 2000;

No OutOfMemory will be thrown anymore. The time will take 4~5 seconds.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@ableegoldman , please help review this PR. Thank you.

The performance comparison in jenkins for uniform subscription and non-equal subscription with the setting:
topicCount = 500;
partitionCount = 2000;
consumerCount = 2000;

Build / JDK 15 and Scala 2.13 / testLargeAssignmentAndGroupWithNonEqualSubscription() | 13 sec | Passed
Build / JDK 11 and Scala 2.13 / testLargeAssignmentAndGroupWithNonEqualSubscription() | 17 sec | Passed
Build / JDK 8 and Scala 2.12 / testLargeAssignmentAndGroupWithNonEqualSubscription() | 14 sec | Passed

Build / JDK 8 and Scala 2.12 / testLargeAssignmentAndGroupWithUniformSubscription() | 3.4 sec | Passed
Build / JDK 15 and Scala 2.13 / testLargeAssignmentAndGroupWithUniformSubscription() | 3.3 sec | Passed
Build / JDK 11 and Scala 2.13 / testLargeAssignmentAndGroupWithUniformSubscription() | 3.9 sec | Passed

Failed tests are unrelated. Thanks.
    Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testReplication()
    Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testReplicationWithEmptyPartition()
    Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTest.testReplication()
    Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTest.testReplicationWithEmptyPartition()
    Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTest.testOneWayReplicationWithAutoOffsetSync()
    Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.integration.RebalanceSourceConnectorsIntegrationTest.testDeleteConnector
    Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.integration.RebalanceSourceConnectorsIntegrationTest.testAddingWorker
    Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.integration.RebalanceSourceConnectorsIntegrationTest.testRemovingWorker
    Build / JDK 8 and Scala 2.12 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopicsWithManyPartitions()
    Build / JDK 8 and Scala 2.12 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics()
    Build / JDK 8 and Scala 2.12 / org.apache.kafka.streams.integration.KTableKTableForeignKeyInnerJoinMultiIntegrationTest.shouldInnerJoinMultiPartitionQueryable
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testReplicationWithEmptyPartition()
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testOneWayReplicationWithAutoOffsetSync()
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTest.testReplication()
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTest.testReplicationWithEmptyPartition()
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTest.testOneWayReplicationWithAutoOffsetSync()
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.integration.BlockingConnectorTest.testWorkerRestartWithBlockInConnectorStop
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.integration.ConnectWorkerIntegrationTest.testBrokerCoordinator
    Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.integration.ExampleConnectIntegrationTest.testSourceConnector
    Build / JDK 11 and Scala 2.13 / kafka.server.ControllerMutationQuotaTest.testStrictDeleteTopicsRequest()
    Build / JDK 11 and Scala 2.13 / kafka.server.ReplicationQuotasTest.shouldThrottleOldSegments()
    Build / JDK 11 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics()
    Build / JDK 15 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testReplication()
    Build / JDK 15 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testReplicationWithEmptyPartition()
    Build / JDK 15 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testOneWayReplicationWithAutoOffsetSync()
    Build / JDK 15 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTest.testReplication()
    Build / JDK 15 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTest.testReplicationWithEmptyPartition()
    Build / JDK 15 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTest.testOneWayReplicationWithAutoOffsetSync()
    Build / JDK 15 and Scala 2.13 / org.apache.kafka.connect.integration.ConnectorClientPolicyIntegrationTest.testCreateWithNotAllowedOverridesForPrincipalPolicy
    Build / JDK 15 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopicsWithManyPartitions()
    Build / JDK 15 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopicsWithManyPartitions()
    Build / JDK 15 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic()
    Build / JDK 15 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic()

Broken tests are fixed and new tests are added for multiple generation tests for unequal subscription cases. Thanks.

It's on my list to review in the next couple of weeks, if not sooner. Sorry I have not had time to get to this one yet, but I will 🙂  (and I agree we should also get feedback from @vahidhashemian if he sees this)

Thanks for tagging me @guozhangwang @ableegoldman.
I'll try to review this within the next few days.

Thank you, guys! :)

@vahidhashemian , thanks for your comments. I've updated. Please take a look again. Thank you.

@vahidhashemian , thanks for the comments. I've updated. Please take a look again. Thank you.

Thanks for addressing my comments @showuon. I tested a couple of unit tests and saw the difference this change makes.
I have no further comment at this time. Given this is a big change I'd wait for @ableegoldman's review before approval. In the meantime, I may test some scenarios for additional validation.

@vahidhashemian , thank you for your review! :)

The failed tests are irrelevant to this PR, I'm merging to trunk now.

Thank you @showuon !!


There is no memory in the system to complete the operation (IN_OPENRESULT_NOMEMORY)

Sometimes on InputDevice when calling StartEventsListening
I get this exception
Melanchall.DryWetMidi.Multimedia.MidiDeviceException: There is no memory in the system to complete the operation (IN_OPENRESULT_NOMEMORY).    at Melanchall.DryWetMidi.Multimedia.NativeApi.HandleResult[TResult,TException](TResult result, Func3 createException)
at Melanchall.DryWetMidi.Multimedia.NativeApiUtilities.HandleDevicesNativeApiResult[TResult](TResult result)
at Melanchall.DryWetMidi.Multimedia.InputDevice.EnsureHandleIsCreated()
at Melanchall.DryWetMidi.Multimedia.InputDevice.StartEventsListening()
at MidiListener.PreSonusMidiController.StartMidiListening() in D:\Development\C Sharp\Midi\MidiListener\MidiController.cs:line 110`
Windows 10 x86 compiled c# code
using 6.1.0-prerelease2 nuget but I was getting the same error in 6.0.1
and I have about 15GB free memory.

Hi,
Please show your code how you work with InputDevice. Are you sure you dispose it when you are done with it?
This error is internal one of Windows MIDI subsystem. DryWetMIDI just redirects it from operating system to you. My assumption is you're not correctly closing a device and thus you have attempt to open a device which was already open and is not properly closed.

thanks yes I have found that there was a crashed instance on my application running which must have locked the midi device - thanks anyway.


refactor(profile): add prefix to child comps

Refactor child components to add the profile prefix. And match the other sections child items naming convention.

Current dependencies on/for this PR:

main

PR #115

PR #116   👈

This comment was auto-generated by Graphite.


Add goreportcard badge

See https://goreportcard.com/report/github.com/zorkian/go-datadog-api  for the current score.
@tariq1890 might this something you would be willing to add?

Sure!

Legend!

Thanks @tariq1890!

Glad to help :)


Explicitly state which trigger warnings are selected for a story

I honestly thought there was an issue for this but I can't see it - so here is a proof of concept - perhaps @gedankenstuecke can let me know if it is needed or not,

Current version: If all checkbox-triggers are clicked the "all trigger warnings selected" is shown. If all checkboxes plus "other" are picked then then the text of the other tag is shown.
It is trivial to go to "Other trigger warning" instead if this is too cumbersome
No limit on the length of the other tag has been built in if limiting it suggest it happens at the model/form stage? Also might need to decide on behaviour for multiple other tags but that is likely beyond the scope of this PR

@mastoffel can you have a quick check that this still behaves as expected with pagination - It looks sensible to me (aside from url....) but want to check before merge - Cheers!


Fix comparison of vtables and comparison of vtable items.

There were identical sub-expressions to the left and to the right of the '==' operator. In other words, vtable item/vtable was compared with itself (that results to 'true') instead of comparison with other vtable item/vtable.

Thank you!


Call setState with Input onChangeText inside a Modal causing: Warning: Cannot update during an existing state transition (such as within render).

🐛 Bug Report
Call setState with Input onChangeText inside a Modal causing: Warning: Cannot update during an existing state transition (such as within render).Warning: Cannot update during an existing state transition (such as within render).
To Reproduce

Enter any value inside the input, will causing  Warning: Cannot update during an existing state transition (only happen in the first time enter text, next time is not causing warning)

Remove the modal wrapping, the warning will not happen

Link to runnable example or repository (highly encouraged)
const CourseInput = (props) => {
  const [value, setValue] = useState("");
  const addCourseHandler = () => {
    props.onAddCourse(value);
    setValue("");
  };
  const courseInputHandler = (enteredText) => {
    console.log(enteredText);
    setValue(enteredText);
  };
  return (
    <Layout
      style={{
        flexDirection: "row",
        justifyContent: "center",
        alignItems: "center",
      }}
    >
      <Modal
        visible={props.visible}
        backdropStyle={styles.backdrop}
        onBackdropPress={props.onCancelAdding}
      >
        <Input
          placeholder="Place your Text"
          value={value}
          onChangeText={courseInputHandler}
          style={{ marginVertical: 20 }}
        />

UI Kitten and Eva version

Package
Version

@eva-design/eva
^2.0.0

@ui-kitten/components
^5.0.0

Environment information

  System:
    OS: macOS 10.14.6
    CPU: (8) x64 Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz
  Binaries:
    Node: 12.16.3 - /usr/local/bin/node
    Yarn: 1.22.4 - ~/Documents/Labs/Workspace/React_Native/galio-starter-kit/node_modules/.bin/yarn
    npm: 6.14.4 - /usr/local/bin/npm
  SDKs:
    iOS SDK:
      Platforms: iOS 12.4, macOS 10.14, tvOS 12.4, watchOS 5.3
  IDEs:
    Android Studio: 3.6 AI-192.7<IP_ADDRESS>92135
    Xcode: 10.3/10G8 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.8.3 => 16.8.3
    react-native: https://github.com/expo/react-native/archive/sdk-35.0.0.tar.gz => 0.59.8

I would suggest separating contents of the Modal if it assumes having a separated state.
This will reduce the amount of component renders, and fix the issue itself.
See an example

A work around that I found is to move the modal into a separated function and wrap it all in a try catch
const ExtraRestsModal = () => {
  try {
	  return (
		  <Modal  ...
	  )
  } catch (err) {
	  return null
  }
}

A work around that I found is to move the modal into a separated function and wrap it all in a try catch
const ExtraRestsModal = () => {
  try {
	  return (
		  <Modal  ...
	  )
  } catch (err) {
	  return null
  }
}

Thanks, this solved my issue!


Tokenizer

Create a tokenizer...

What is still missing at the?

I think there is nothing to do more. Maybe hashtag or @ for annotations?

I think an @ would be good.


test: add a test to check owner reference merge

Description of your changes
Add an integration test to test that the owner references for one manifest shared between multiple works have both appliedWork as its owner
I have:

[x] Read and followed Caravel's Code of conduct.
[x] Run make reviewable to ensure this PR is ready for review.

How has this code been tested
IT
Special notes for your reviewer

Merged this test to another PR


infallible conversions from hashes to secp256k1 message

Close 824

There are two issues here:

Our CI is broken because of some honggfuzz issue. This should be fixed now as I just merged #848
There is some issue with the bitcoin_hashes feature, which I haven't understood yet. But we should fix this, there's no reason rust-bitcoin shouldn't have this feature turned on.

There are two issues here:
1. Our CI is broken because of some honggfuzz issue. This should be fixed now as I just merged [Tempararily pin fuzzer on rust 1.58 #848](https://github.com/rust-bitcoin/rust-bitcoin/pull/848)

2. There is some issue with the `bitcoin_hashes` feature, which I haven't understood yet. But we should fix this, there's no reason rust-bitcoin shouldn't have this feature turned on.

As u said, first issue is resolved after rebasing latest master. For the issue 2, it looks like it's related to no std. I am looking into this🙏🏽(Changed PR status to draft)

For your reference, the CI failure has an open issue.

For your reference, the CI failure has an open issue.

Yes I think the issue should be related to bitcoin_cash default-features is enabled in rust-secp256k1. I get the ci pipeline working by adding default-features = false in forked rust-secp
Related commits in my forked ones
rust-bitcoin https://github.com/bruteforcecat/rust-bitcoin/commit/19d1bfa00c35d7a2d7f2ce2a4b61c05f5753cfab
related github action https://github.com/bruteforcecat/rust-bitcoin/actions/runs/1908337297
rust-secp256k1 https://github.com/bruteforcecat/rust-secp256k1/commit/e3af3445e3744e92321e0c307f799fd042ca9600

Looks like this was fixed by #1118


/api-doc/ Missing docs for customer CRUD operations

There is no documentation in the /api-doc/ interface for creating a customer so right now it is impossible to sync a sales order via the API As you first have to create the customer.

A "customer" is just a Company that has the is_customer field set to True. So you use the Company API endpoint to create a Customer:

I think you need to put some information here that tells people that the customer field references the company objects.


Forge wont launch using ct

I launched my minecraft using forge today, but nothing happened. Task manager said java was running in the background but minecraft didnt open. i tried to remove my mods 1 by 1 and when i removed chat triggers everything worked fine.
why is it not working?

omg this is happening to me aswell i was about to do a report

probably a new bug or glitch

also chat triggers website is down for me

same, website and mod arent working

This is also happening to me, glad to see it's not only happening to me

There is currently an issue with ChatTriggers where if the website is down or unreachable (no internet) the game will take forever to load. As soon as we get the website back up, we will look into fixing this issue

o ok ty

ok thx

ok ty kerby

This has been fixed, the website is now back up and the mod should run normally. Sorry for the downtime, hope it hasn't been too big of an issue. Thanks for your help guys!


[SR-197] Skip generic specialization when generic is <>

This disables the 'cannot specialize non-generic type' error message when the type is <<error type>> since it doesn't convey any additional information to the user.
This code represents an instance of this problem:
$ cat a.swift
typealias SomeType = NonExistentType
func foo(bar: SomeType<Int>) {

}
$ swiftc -c  a.swift
a.swift:1:22: error: use of undeclared type 'NonExistentType'
typealias SomeType = NonExistentType
                     ^~~~~~~~~~~~~~~
a.swift:2:15: error: cannot specialize non-generic type '<<error type>>'
func foo(bar: SomeType<Int>) {

This would be the first time I contribute code to Swift, so I might have made some rookie mistake. In particular, from what I saw on the discussion of #432, this might not be the place where the problem should be addressed.
I'm currently running the test suite, but I think it should pass since I haven't found any test checking this particular case. Should one be added?
EDIT: the tests just finished:
  Expected Passes    : 2350
  Expected Failures  : 5
  Unsupported Tests  : 34

Sorry for the delay reviewing this.  The patch looks great to me.  Please add a test case to the test suite though.

This seems to cover the issue. I think that's the right place where this should be tested, since that's the part that tests typealias SomeType = NonExistentType

Looks great, thanks.  Please close SR-197 when you get a chance,
-Chris


Example for protected-internal is wrong

The line
// baseObject.myValue = 10;

Can be un-commented and the example will still compile, because you are within the scope of "DerivedClass".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 650c563e-748e-7ad7-fea9-0504549a56ab
Version Independent ID: ad6dac17-6e62-1447-e85d-e502ae39a343
Content: protected internal (C# Reference)
Content Source: docs/csharp/language-reference/keywords/protected-internal.md
Product: dotnet-csharp
GitHub Login: @sputier
Microsoft Alias: wiwagn

Thanks for pointing this out @matthid You are correct, the example has an error.
The correct fix is to move the Main method to a new class, not derived from BaseClass.
I've added this to our backlog, and our community project.  If you'd like to submit a PR for this, I'll review it and merge it.

Actually, I was wrong. The example is correct.
The description "A protected internal member is accessible from the current assembly or from types that are derived from the containing class. " It was a bit irritating. In fact the example shows that this is not true, there is another limitation where the variable has to be a derived type as well.
I could swear I tested this before posting, sorry.

No worries @matthid. Thanks for getting back to us and closing the issue.


Add a LevelDB database impl.

This needs a good rebase on top of master.

Also need to update it for the duplicate submission support, I think?
[ RUN      ] DBTest/2.CreateSequencedDuplicateEntryNewSequenceNumber
cpp/log/database_test.cc:117: Failure
Value of: this->db()->CreateSequencedEntry(duplicate_cert)
  Actual: 0
Expected: DB::ENTRY_ALREADY_LOGGED
Which is: 3
[  FAILED  ] DBTest/2.CreateSequencedDuplicateEntryNewSequenceNumber, where TypeParam = LevelDB<cert_trans::LoggedCertificate> (8 ms)

LGTM


Read CSV format text from stdin or memory

Migrate from https://github.com/apache/arrow/pull/10066.
Which issue does this PR close?
Close Jira issue ARROW-12306
Rationale for this change
Let CsvFile and CsvExec support reading from a reader (not only files)
What changes are included in this PR?
This pr adds the following new pub functions:

CsvFile::try_new_from_reader
CsvFile::try_new_from_reader_infer_schema
CsvExec::try_new_from_reader
CsvStream::try_new_from_reader

Are there any user-facing changes?
No.

Codecov Report

Merging #54 (10f8c3b) into master (9ba214a) will decrease coverage by 0.04%.
The diff coverage is 73.29%.

:exclamation: Current head 10f8c3b differs from pull request most recent head c938270. Consider uploading reports for the commit c938270 to get more accurate results

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   76.24%   76.20%   -0.05%
==========================================
  Files         134      134
  Lines       23051    23199     +148
==========================================
+ Hits        17576    17679     +103
- Misses       5475     5520      +45

Impacted Files
Coverage Δ

datafusion/src/datasource/csv.rs
73.33% <69.86%> (-9.28%)
:arrow_down:

datafusion/src/physical_plan/csv.rs
79.09% <75.72%> (-4.13%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ba214a...c938270. Read the comment docs.

Looks good to me, thanks @heymind .
Seems like a cool addition to integrate with much more sources. I have some small questions about partitioning and re-use across formats, but that shouldn't be a blocker.


Deployment using the setup scripts fails

Expected Behavior
Setup succeeds.
Actual Behavior
Setup fails  error: resource mapping not found for name: "tekton-pipelines-webhook" namespace: "tekton-pipelines" from "https://storage.googleapis.com/tekton-releases/pipeline/latest/release.yaml": no matches for kind "HorizontalPodAutoscaler" in version "autoscaling/v2"
Testing a fix for the above error, led to another failure. The setup script fails with error: timed out waiting for the condition on deployments/tekton-results-api while inspecting the tekton-results-api pod I found Error: couldn't find key POSTGRESQL_USER in Secret tekton-pipelines/tekton-results-postgres.
Steps to Reproduce the Problem

Clone the repo
./test/e2e/00-setup.sh
./test/e2e/01-install.sh

Additional Info
I tested and suggest the following changes to fix the above issues:

Bump the Kind cluster version (set in  test/e2e/kind-cluster.yaml) to the latest one - v1.25.
Unify the Postgres user and password variables names. Currently there are two sets of names, POSTGRESQL_USER/POSTGRES_USER and POSTGRESQL_PASSWORD/POSTGRES_PASSWORD. I'm leaning towards POSTGRES_USER and POSTGRES_PASSWORD as those appear to me more commonly used.

Kubernetes version:

Client Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.3", GitCommit:"434bfd82814af038ad94d62ebe59b133fcb50506", GitTreeState:"clean", BuildDate:"2022-10-12T10:57:26Z", GoVersion:"go1.19.2", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.13", GitCommit:"a43c0904d0de10f92aa3956c74489c45e6453d6e", GitTreeState:"clean", BuildDate:"2022-09-02T00:13:40Z", GoVersion:"go1.16.15", Compiler:"gc", Platform:"linux/amd64"}

- Tekton Pipeline version:
v0.42.0

<!-- Any other additional information -->

The issue was addressed by #270.


It is unclear that where the dkt_que model file is

The que_dkt_demo file of the example folder had import the  DKTQue method, but I don't find the relation file.
The raw code was " from pykt.models.dkt_que import DKTQue "

Hello, thank you for your support of our work, about dkt_que, you can view and save in the dkt_improve branch.

Hello, thank you for your support of our work, about dkt_que, you can view and save in the dkt_improve branch.

Thank you ! I have found the file.


upgrade: Remove old chef-created crowbar.service unit

It's part of the crowbar-core package nowadays

Requires: https://github.com/crowbar/crowbar-core/pull/941


Spanish icloud support

Tiny one: iCloud uses the past tense in plural first person when replying to emails.

@turt2live thanks! Really appreciate that you take the time to review both. If you inly have time for one, please peioritise the other PR. Happy ti answer any quedtions.


Upgrade to Babel 6

Babel 5 is no longer being maintained. Upgrade to Babel 6.

this message i see during npm install

+1

As per your request, #32 Babel-6 upgrade has been submitted.

Merged!


About Prompt Retrieve

Hi, @LzVv123456
I compared the Top-3 accuracy without prompt (95.64%) and the accuracy with Prompt (94%) under same setting. According to my understanding, retrieving Top-3 Key_protos when there is no Prompt is also equivalent to finding the corresponding candidate Prompt, and thus the corresponding Value_protos can be subsequently used for classification. In terms of the two classification accuracies, the ability of the candidate Prompt to contain the Target Prompt is actually largely determined by the pre-trained network itself. Then, if the pre-trained network itself is weak when retrieving the candidate Prompt in this step, it will also directly affect the result. I hope to hear your detailed insights about this part. Looking forward to answering questions at your leisure!

Your thought is indeed the case. When the pretrained model is too weak, you can not expect the frozen model to generate good key prototypes and hence it is hard to include the correct prompt into the candidate prompt group using KNN (see the variation of baselines under different pre-trained weights in Table2).  As a remedy, you can try to increase the query range, say top-10, to increase the chance at the cost of the inference speed. This can be viewed as an inherent property of this framework, it is built upon a strong pretrained model. Otherwise, one can not even expect the prompt-tuning technique itself to be useful.

Thanks a lot for your reply!


Update README.md

I don't think the angled brackets here are a good placeholder. It's too similar to HTML tags. Maybe ** on either end to bold it in markdown would be better?

The asterisks should be right up against the word like **this**


Yew (worker) agents are not webpack friendly when using web-sys

Problem
Yew starts workers by making a fake script, setting its source, and trying to call wasm_bindgen on it, which doesn't work in the scope of webpack.
Potential Solution
#[cfg(feature = "web_sys")]
fn worker_new(name_of_resource: &str, is_module: bool) -> Worker {
    let href = utils::document().location().unwrap().href().unwrap();
    let script_url = format!("{}{}", href, name_of_resource);
    cfg_if! {
        if #[cfg(feature = "webpack")] {
            return Worker::new(&script_url).expect("failed to spawn worker");
        }
    }

Context: https://github.com/yewstack/yew/issues/1046#issuecomment-602800124

IssueHunt Summary

Backers (Total: $5.00)

 jstarry ($5.00)

Become a backer now!
Or submit a pull request to get the deposits!
Tips

Checkout the Issuehunt explorer to discover more funded issues.
Need some help from other developers? Add your repositories on IssueHunt to raise funds.

yew-agent since 0.2 no longer creates workers.
It only re-exports methods from gloo.
If anyone encounters the issue please create it in gloo repository instead.


macOS build and create app bundle script

Tiny little script that does the build on macOS and spits out a SHADERed.app ready for double-clicking.

I tested this. This is so cool! I hope this will merge if this repo is still alive so can help others on installing in Macos

This doesn’t work properly on Retina/high dpi screens.


Native Shared Element Transitions?

This feature has landed in a few native routers. Any plans here?
http://airbnb.io/native-navigation/docs/guides/shared-element-transitions.html
https://github.com/exponent/ex-navigation/tree/master/example-shared-element-transitions
https://github.com/wix/react-native-navigation/tree/master/example/src/screens/transitions/sharedElementTransitions

Nope, we're not going to build out animation tooling ourselves. That would be best left to an addon library. If someone wants to build one, we'd be more than happy to add it to the monorepo!


DS-3122: Make DataCite XML namespace configurable.

https://jira.duraspace.org/browse/DS-3122
This must be merged after #1197 as it already uses the schema version 3.
I don't think this really needs to be tested as the code change are so small an obvious. Just in case a short description on how to test this: take the XSLT from #1197, configure DSpace to mint DOIs with DataCite (see DSpace documentation), publish an Item and run [dspace-install]/bin/dspace doi-organiser -u. If it tells you that it successfully updated a DOI everything is fine.

+1 by inspection

rebased.

+1 by inspection, and it is small and obvious.


Support --files parameter

Similar to https://github.com/muter-mutation-testing/muter#muter-can-be-run-in-your-ci
Mutation tests are usually slow to run, I'd like to test only the modified files in my PR via CI.

This is technically already possible. You can provide a list of files as arguments, but you would have to add a custom rule file as input:
mutation_test -b --rules cfg.xml <file1> <file2> <file3> ...
The content of cfg.xml has to be:
<?xml version="1.0" encoding="UTF-8"?>
<mutations version="1.0">
  <commands>
    <command>dart test</command>
  </commands>
</mutations>

I understand that it is inconvenient that you have to provide the test command in an xml file. Another problem right now is that you get a report file for each of the input files instead of a single report. These issues can be solved.
What would you expect as return value? Should mutation_test give a nonzero return value if any test fails?

I'd stick to the current behavior, the difference is that instead of using the current folder, you use the given files, still a single report, same return value.


Limit cluster resource(s) visibility in Rancher GUI

Cluster resource dashboard (ie Global Tab in Rancher GUI) is always accessible under user login session though the user is permitted to access a particular project with a defined resource quota. If Rancher GUI exposes the total CPU/Memory/Nodes of downstream cluster, it rather creates confusion on resource quota set against a particular project, especially in multi-tenancy scenario/env.
Appreciate if you could add new project role(s) to limit the visibility on downstream cluster {or/and} add option to list project quota set(if any) instead total resources. The best I could mask is the node count and attached a screenshot.
This is reproducible always

create a project, set resource quota and associate a user
login Rancher GUI as user, Global tab will list underlying RKE cluster resources - Total {nodes, CPU, Memory}

Version - Rancher v2.5.8

When Rancher using a single cluster for multiple users. and the single cluster is used for multi-tenancy.
The user has access to his/her particular project with limited resources.
The user still able to view the whole cluster resources (Total Cluster Memory/CPU/#PODs ) even the role of the user-specified to a specific project only.
The below screenshots from the user dashboard that has access to a specific project only, and here he/she still able to see the whole cluster information:

These are basic properties of the cluster on the same level as other important things like what version of k8s it is.  There is no field-level RBAC control in k8s to grant access to part of the fields of a resource.


Virtual Keyboard Not Emitting text_changed() Signal

Godot version
3.5.stable
System information
ios 15.6 safari web browser GLES2
Issue description
Attempting to update a Label Node from a TextEdit Node Using the text_changed() Signal built into TextEdit Node.
func _on_AddMessage_text_changed():
	$"%AddMessageLabel".text = $"%AddMessage".text

The signal works as expected with an actual keyboard on desktop in both the web export and the standard F5 Play the project button, but does not function when on ios Safari.
Running the same code within the _input(event) function does however work:
func _input(event):
	$"%AddMessageLabel".text = $"%AddMessage".text

Steps to reproduce
Create a TextEdit Node with a script add in the text_changed() signal and set a Label Node's text equal to its text:
func _on_TextEdit_text_changed():
	$"%Label".text = $"%TextEdit".text

Export to HTML5 with Virtual Keyboard enabled.
Minimal reproduction project
No response

Godot version
3.5.2-stable
System information
ios 15.6 safari web browser GLES2
also present in:

(iOS):

Google chrome 113.0.5672.121
Firefox  browser 113.1 (30885)

Android:

Google chrom 113.0.5672.131

Hi!. I have a project that presented a similar issue. The text_changed signal was working fine for about a year until two weeks ago. As stated in the previous post "The signal works as expected with an actual keyboard on desktop in both the web export and the standard F5 Play the project button, but does not function when on ios Safari." in my case it doesn't work on android or safari.
Have a nice day.
LineEdi_text_changed.zip

Hi, was there any update on this? I'm having this issue now as well.


"More Tweets" is back

We should extend the options which hides "Discover more" tweets to also hide these - why do they have both? 🤔

You only get "More Tweets" if you navigate to a Tweet via an external link, e.g.:
https://x.com/raccoonhourly/status/1791959469942849833
If you navigate to that Tweet from within Twitter instead (e.g. via a Quote Tweet of it), it shows you "Discover more", which we can already hide.
I think this is functionality left over from when Twitter used to show the thread under focused tweets to non-logged-in users
The problem with trying to hide this is  the "More Tweets" text comes from the server, so it's not included in Twitter's client-side locale data, which means I'd have to manually source translations for every language Twitter supports by switching languages.

I would really appreciate it if this could be added, it's the one addictive thing that still sneaks through the firewall of the extension. Thanks for the great work, by the way, it's a godsend!


notification controls are not showing up in IOS (android works)

Describe the bug
A clear and concise description of what the bug is.
notification controls are not showing up in IOS (android works)
To Reproduce
Steps to reproduce the behavior:
Environment (please complete the following information):
Run react-native info in your project and share the content.
OS: macOS 10.15.2
CPU: (8) x64 Intel(R) Core(TM) i7-3615QM CPU @ 2.30GHz
Memory: 911.78 MB / 8.00 GB
Shell: 5.7.1 - /bin/zsh
Binaries:
Node: 12.6.0 - /usr/local/bin/node
Yarn: 1.19.1 - /usr/local/bin/yarn
npm: 6.13.4 - /usr/local/bin/npm
SDKs:
iOS SDK:
Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
Android SDK:
API Levels: 23, 26, 27, 28, 29
Build Tools: 23.0.1, 25.0.0, 26.0.0, 26.0.1, 26.0.2, 26.0.3, 27.0.3, 28.0.2, 28.0.3
System Images: android-28 | Google APIs Intel x86 Atom, android-29 | Google APIs Intel x86 Atom
IDEs:
Android Studio: 3.5 AI-191.8<IP_ADDRESS>10548
Xcode: 11.3/11C29 - /usr/bin/xcodebuild
npmPackages:
react: ~16.9.0 => 16.9.0
react-native: ~0.61.5 => 0.61.5
npmGlobalPackages:
create-react-native-app: 2.0.2
react-native-cli: 2.0.1
react-native: 0.61.5
What react-native-track-player version are you using?
react-native-track-player": "^1.2.3
Are you testing on a real device or in the simulator? Which OS version are you running?
Code
Please, share the code that is causing the issue
useEffect(() => {
    `setup();`
  }, []);

  async function setup() {
    await TrackPlayer.setupPlayer({}).then(async () => {
      TrackPlayer.addEventListener("remote-play", () => {
        TrackPlayer.play();
      });

      TrackPlayer.addEventListener("remote-pause", () => {
        console.log("clickklik");
        TrackPlayer.pause();
      });
      TrackPlayer.addEventListener("remote-stop", () => {
        console.log("clickklik");
        TrackPlayer.destroy();
      });
      await TrackPlayer.updateOptions({
        stopWithApp: false,
        capabilities: [
          TrackPlayer.CAPABILITY_PLAY,
          TrackPlayer.CAPABILITY_PAUSE,
          // TrackPlayer.CAPABILITY_SKIP_TO_NEXT,
          // TrackPlayer.CAPABILITY_SKIP_TO_PREVIOUS,
          TrackPlayer.CAPABILITY_STOP,
        ],
        compactCapabilities: [
          TrackPlayer.CAPABILITY_PLAY,
          TrackPlayer.CAPABILITY_PAUSE,
        ],
        notificationCapabilities: [
          TrackPlayer.CAPABILITY_PLAY,
          TrackPlayer.CAPABILITY_PAUSE,
          TrackPlayer.CAPABILITY_SEEK_TO,
        ],
      });
    });
  }

  async function togglePlayback() {
    const currentTrack = await TrackPlayer.getCurrentTrack();
    if (currentTrack == null) {
      await TrackPlayer.reset();
      // await TrackPlayer.add(playlistData);
      await TrackPlayer.add({
        id: "local-track",
        url: "url",
        title: "Pure (Demo)",
        artist: "David Chavez",
        artwork: "https://i.picsum.photos/id/500/200/200.jpg",
      });
      await TrackPlayer.play().then(async () => {
        setPaused(false);
      });
    } else {
      if (playbackState === TrackPlayer.STATE_PAUSED) {
        await TrackPlayer.play().then(async () => {
        });
      } else {
        await TrackPlayer.pause().then(async () => {
        });
      }
    }
  }

Simulator or real device?

@curiousdustin on Simulator..

The notification will not show in a iOS simulator only on a real device.

oh @Tucker2015 are you sure na..

https://github.com/react-native-kit/react-native-track-player/blob/dev/docs/Background-Mode.md#ios-simulator

As of iOS Simulator version 11, Apple has removed support for Control Center and Now Playing Info from the simulator. You will not be able to test lock screen controls on recent versions of iOS Simulator. You can either test on real devices, or download older versions of the iOS Simulator.

We have recently updated the docs on this. This Updated note has not made it onto the hosted documentation yet.

@curiousdustin thank you..


UI Improvement

My name is Dewansh Rawat. I've participated twice in GCI, 16 and 17.
I'm submitting a ...

A request to improve the UI

Current behavior:

Currently, the UI is not that attractive

Expected behavior:

Improve UI/UX

Steps to reproduce:

Would introduce CSS heavily

Please review points under Steps to Reproduce

I'll be working on its UI.

@rohitjain00 -- Have you created any design document's related to the improvements you're planning ?

@dewanshrawat15 -- Could you list down a few improvements you think might be helpful ?

@souravbadami I think the search page is too clustered for instance. I am attaching a small rough wireframe of what kind of design I had in mind.


并不快，对比了mvn 和mvnd的速度

两边相差3秒钟，没有太大的区别

并不是并行构建就一定能加快速度，能你的项目结构等有一定关系, 建议阅读https://cwiki.apache.org/confluence/display/MAVEN/Parallel+builds+in+Maven+3

same as https://github.com/apache/maven-mvnd/issues/570

感谢你的回复，试过了打包好几次，打包时间还是没有变化才提的issues，另外，我这边的项目是传统项目，并没有什么其他的依赖

@Lvbuqing could you please write the title and comments in English.  If you don't speak English, please use a translator, else we can't read.

@Lvbuqing @NoSugarCoffee could you please write the title and comments in English. If you don't speak English, please use a translator, else we can't read.

@Lvbuqing said that compared with maven, mvnd could not make his project faster，I give him some advice like you replied in https://github.com/apache/maven-mvnd/issues/570 , this issue can be closed, I think


Fix Example link

Replaced the broken Example link with the latest working one.

Oops, thank you !


Output Image Appears Granular/Pixellated After Stitching with ASHLAR

I am experiencing an issue with the output images generated by ASHLAR. The stitched images appear to be overly granular or pixelated, which significantly impacts the visual quality and usability for analysis. This granular effect is not present in the original input images.

Could you upload a representative TIFF of the original data and the ashlar output, rather than a screenshot? I don't think I can figure out what's going on from this screenshot alone. You can crop out a small region so the file is only a few megabytes, or I can give you a link to our large file transfer service if you want to share the entire thing (up to 50 GB).

Dear jmuhlich,
Thank you for your prompt response and sincere help.
I have uploaded the following files for your reference via the following link: https://we.tl/t-XwQkazAzUm

The original CyCIF images from 5 cycles (W0001F0031T0001_IF1-5).
The output generated by using the ASHLAR algorithm to merge these 5 images (merged_F0031_optimized.ome.tiff).
A test where I used only one image from the 5 cycles to merge, but the output still exhibits graininess (F1.ome.tiff and F1merged.ome.tiff).

Below is the environment of my Anaconda ASHLAR setup:
packages in environment at D:\Anaconda\envs\ashlar_env_38:

Name                    Version                   Build  Channel
ansicon                   1.89.0                   pypi_0    pypi
asciitree                 0.3.3                    pypi_0    pypi
ashlar                    1.18.0                   pypi_0    pypi
blessed                   1.20.0                   pypi_0    pypi
ca-certificates           2024.9.24            haa95532_0
contourpy                 1.1.1                    pypi_0    pypi
cycler                    0.12.1                   pypi_0    pypi
fasteners                 0.19                     pypi_0    pypi
fonttools                 4.54.1                   pypi_0    pypi
freetype                  2.12.1               ha860e81_0
imageio                   2.35.1                   pypi_0    pypi
importlib-resources       6.4.5                    pypi_0    pypi
jinxed                    1.3.0                    pypi_0    pypi
joblib                    1.4.2                    pypi_0    pypi
jpeg                      9e                   h827c3e9_3
kiwisolver                1.4.7                    pypi_0    pypi
lcms2                     2.12                 h83e58a3_0
lerc                      3.0                  hd77b12b_0
libdeflate                1.17                 h2bbff1b_1
libffi                    3.4.4                hd77b12b_1
libpng                    1.6.39               h8cc25b3_0
libtiff                   4.5.1                hd77b12b_0
libwebp-base              1.3.2                h3d04722_1
lz4-c                     1.9.4                h2bbff1b_1
matplotlib                3.7.5                    pypi_0    pypi
networkx                  3.1                      pypi_0    pypi
numcodecs                 0.12.1                   pypi_0    pypi
numpy                     1.24.4                   pypi_0    pypi
openjpeg                  2.5.2                hae555c5_0
openssl                   3.0.15               h827c3e9_0
packaging                 24.1                     pypi_0    pypi
pillow                    10.4.0           py38h827c3e9_0
pip                       24.2             py38haa95532_0
pyjnius                   1.6.1                    pypi_0    pypi
pyparsing                 3.1.4                    pypi_0    pypi
python                    3.8.20               h8205438_0
python-dateutil           2.9.0.post0              pypi_0    pypi
pywavelets                1.4.1                    pypi_0    pypi
scikit-image              0.19.3                   pypi_0    pypi
scikit-learn              1.3.2                    pypi_0    pypi
scipy                     1.10.1                   pypi_0    pypi
setuptools                75.1.0           py38haa95532_0
six                       1.16.0                   pypi_0    pypi
sqlite                    3.45.3               h2bbff1b_0
threadpoolctl             3.5.0                    pypi_0    pypi
tifffile                  2023.7.10                pypi_0    pypi
vc                        14.40                h2eaa2aa_1
vs2015_runtime            14.40.33807          h98bb1dd_1
wcwidth                   0.2.13                   pypi_0    pypi
wheel                     0.44.0           py38haa95532_0
xz                        5.4.6                h8cc25b3_1
zarr                      2.16.1                   pypi_0    pypi
zipp                      3.20.2                   pypi_0    pypi
zlib                      1.2.13               h8cc25b3_1
zstd                      1.5.6                h8880b57_0
Additionally, the metadata from my microscope output is as follows:
icm:ImagingResult xmlns:icm="http://www.yokogawa.co.jp/LSC/ICMSchema/1.0" icm:StructVersion="2.0"
icm:FileInformation icm:Name="ImagingResult.xml" icm:Version="1.0" icm:CreateTime="2024-01-31T08:43:06.7128566+01:00" icm:CreateUser="CQ1" icm:LastUpdateTime="2024-01-31T09:48:45.2712585+01:00" icm:LastUpdateUser="CQ1"/
icm:ResultInfo icm:BeginTime="2024-01-31T08:43:06.330756+01:00" icm:EndTime="2024-01-31T09:48:44.6701544+01:00" icm:Result="Completed"
icm:ProtocolPathMeasurementProtocol.xml</icm:ProtocolPath>
</icm:ResultInfo>
icm:MachineInfo icm:ProductID="X6CQ001" icm:SerialNumber="90X801630" icm:FirmwareVersion="<IP_ADDRESS>" icm:AutoFocusRevision="3"/
icm:ImageDataInfo icm:FolderDividingMethod="None" icm:IsFlatFieldCalibration="true" icm:IsGeometricCalibration="true" icm:LastTimePoint="1" icm:TotalTimePoint="1"
icm:DimensionsInfo
icm:W icm:Min="1" icm:Max="1"/
icm:A icm:Min="1" icm:Max="5"/
icm:F icm:Min="1" icm:Max="212"/
icm:T icm:Min="1" icm:Max="1"/
icm:Z icm:Min="1" icm:Max="15"/
icm:C icm:Min="1" icm:Max="5"/
</icm:DimensionsInfo>
icm:EnableArea icm:X="10" icm:Y="10" icm:Width="1980" icm:Height="1980"/
icm:ImageCompressParameter icm:IsImageCompress="false" icm:ImageCompressType="Lzw"/
</icm:ImageDataInfo>
icm:ChannelInfoList
icm:ChannelInfo icm:Ch="1" icm:HorizontalPixelSize="0.325" icm:VerticalPixelSize="0.325" icm:PixelWidth="2000" icm:PixelHeight="2000" icm:CameraNumber="1" icm:FilterWheelIndex="1" icm:FilterWheelPosition="1" icm:StitchROITopLeftX="150" icm:StitchROITopLeftY="150" icm:StitchROIWidth="1700" icm:StitchROIHeight="1700"/
icm:ChannelInfo icm:Ch="2" icm:HorizontalPixelSize="0.325" icm:VerticalPixelSize="0.325" icm:PixelWidth="2000" icm:PixelHeight="2000" icm:CameraNumber="1" icm:FilterWheelIndex="1" icm:FilterWheelPosition="2" icm:StitchROITopLeftX="150" icm:StitchROITopLeftY="150" icm:StitchROIWidth="1700" icm:StitchROIHeight="1700"/
<icm:ChannelInfo icm:Ch="3" icm:HorizontalPixelSize="0.325" icm:VerticalPixelSize="0.325" icm:PixelWidth="2000" icm:PixelHeigh
Please let me know if you require further details. I truly appreciate your time and expertise in assisting with this issue.

Thank you. I found a bug in Ashlar's TIFF file handling with certain types of images (big-endian pixel data). I will fix this bug and let you know when there is a new version of Ashlar for you to try. If you want to preview what a correct result will look like, you can use this command line which will use an undocumented alternate TIFF reader that doesn't have this bug:
ashlar "fileseries|.|pattern=W0001F0031T{series}_IF1.tif|overlap=0.1|width=1|height=1" "fileseries|.|pattern=W0001F0031T{series}_IF2.tif|overlap=0.1|width=1|height=1" "fileseries|.|pattern=W0001F0031T{series}_IF3.tif|overlap=0.1|width=1|height=1" "fileseries|.|pattern=W0001F0031T{series}_IF4.tif|overlap=0.1|width=1|height=1" "fileseries|.|pattern=W0001F0031T{series}_IF5.tif|overlap=0.1|width=1|height=1" -c 2
(Note you should specify -c 2 to align on the DNA channel, as the default is to align on channel 0 which is not DNA here)
One question I have about your data: Do you really only have a single field of view per cycle, or are you imaging multiple fields of view in each cycle to cover the whole sample?

Never mind the ashlar command above, I have fixed the issue and released ashlar 1.19.0 with the fix. Please install 1.19.0 version and try again. I'd still like to know whether you are stitching tiles within each cycle, or just registering a single tile across cycles!

Thank you so much for your quick response and for your work on the new release. I have tried ashlar 1.19.0, and I successfully merged the images this time without the graininess issue.
Our images represent different cycles of the same slice, taken from approximately the same field of view. However, each field has slight displacements and does not completely overlap.
You’ve been incredibly kind and helpful, and your work is of great significance to the progress of our research. We truly appreciate your support and dedication.
Thank you again! jmuhlich


Icon request: Resize Chart

Create an Icon for Resizing Smart Signal Charts

Use Case:
Enlarge or reduce the height of a SS chart. Charts can be made taller up to 2 times and made shorter up to 2 times from the tallest point.
Additional Screenshots:

Desired Doneness:
For this to be complete, the icon should be introduced into Predix by Tuesday 2/20/2018.

I've created an SVG for the new icon. Can someone review and make sure it fits in with the set? I'm still targeting Tuesday for doneness unless I'm told otherwise. Thanks.
https://ge.box.com/s/6hq3mf9o2v83w3k0xa9h9pytsm05qnfy

Added px-vis:resize in v2.1.6.


Partitions

Although this has already been reviewed in smaller PRs, take a look at it, since it required a reeeeeeally heavy rebase.

@erizocosmico @mcarmonaa Merge when ready!


Intellij Idea graphql plugin tagged template literals intellisense cannot resolve String.formatted() variables

Describe the bug
When using a text block (annotated as GraphQL) as a template for a GraphQL mutation, intellisense flags unquoted string variables (like %s & %d) as unresolved values.
To Reproduce
Create the following text block in Java with the IntelliJ GraphQL plugin installed:
` java
    String lukeName = "Luke Skywalker";
    String LeiaName = "Leia Organa";
    // language=GraphQL
    String document2 = """
            mutation {
                addHero(hero: {
                    name: "%s",
                    born: %s,
                    damage: %d
                }) {
                    name
                    born
                    age
                    damage
                }
            }
            """;
    String lukeMutation = document2.formatted(lukeName, LocalDate.of(1979, 12, 1), 85.5);
    String LeiaMutation = document2.formatted(LeiaName, LocalDate.of(1979, 12, 1), 90.75);

`
GQL Schema
input HeroInput {     name: String,     born: LocalDate,     damage: Float }
type Hero {     name: String,     born: LocalDate,     age: Int,     damage: Float }
Expected behavior
The expectation is that there should not be an inspection warning of " expected, got '%'
Unknown field "d" on input type "HeroInput"
Version and Environment Details
Operation system: Windows 11 Build 22631.4169
IDE name and version: IntelliJ IDEA 2024.2.1 (Ultimate Edition)
Plugin version: 242.21829.3

@ksdc-vaughann hi! Thank you for bringing up the issue. Unfortunately, I don't think it will ever be fixed. GraphQL parser is not and can't be aware of any string-building methods in every possible language. For instance, Java also has MessageFormat API, e.g.
MessageFormat.format(
     "At {1,time} on {1,date}, there was {2} on planet {0,number,integer}.",
     planet, new Date(), event);

Should the GraphQL parser be able to handle that too?
It’s generally much better to use GraphQL variables for this purpose, and that’s how most users approach it. There are several discussions on StackOverflow that cover this topic. For example, this answer mentions:

If your query is dynamically generated, there's no way to do static analysis on it using tools like eslint-plugin-graphql, so you can't check if your query is valid without actually running your code.

This is one of the key reasons for using variables instead of interpolation - and it’s likely the issue you’re currently encountering.


Use dump operator instead of our own verbose params

Replace verbose by dump operator

PR checklist

[X] PR is made against dev branch
[X] This comment contains a description of changes (with reason)
[X] Ensure the test suite passes (./scripts/test.sh -p docker -t ALL).
[ ] Documentation in docs is updated
[x] CHANGELOG.md is updated
[ ] README.md is updated

That made a good point.
I'll change that right now.
Thanks for the idea

@szilvajuhos What do you think of this option: https://github.com/SciLifeLab/Sarek/pull/741/files#diff-0b5797602b3120dfd4f9caa8ea5c8a9eR236 ?

Writing out the new option is OK, especially for this. On the other hand, we should avoid changing the CLI.

I know we should avoid changing it, unless we go for 2.4 ;-)
But I do think it'll be better to have this dump operator than what we were doing before.

next version will be 2.4 since this PR is breaking --verbose

Can help you with reviewing and testing here to get a 2.4 release soon :)

I'm currently testing #773 #787
#781 could need further testing, and some files added in iGenomes
And I definitively need #781 in 2.4
It would be great if we can have #789 as well
#790 will also need to be included, but no testing required


Fixed autoupdate for deleted instances. Fixed #2329.

@emanuelschuetze Please test. I still get "Kein Element gefunden" messages in JS console and I do not know where they come from.

Tested successfully. Autoupdate for removed item works now.
BTW: I get no "Kein Element gefunden" message in console...

You can merge it...


Printing superstring

Have you read the Contributing Guidelines on Pull Requests?
(Write your answer here.)
yes
Description
This problem will be solved using dp.
We will be given two strings and we have to find the shortest
common superstring b/w two and will have to print it's superstring.
Input -
Enter string X and string Y -
abcdaf
aebcf
Output -
Shortest Common Subsequence -
aebcdaf
(Write your answer here.)
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
(Write your answer here.)
#5758

hey @ankitaggarwal23 in thi problem i am printing the string and in above problem the length was returned  Pls check

That person also doing the same thing. Have to check before opening an issue

she is printing the length and I am printing string

she is printing the length and I am printing string

code is different for the both

Oh okay Do one thing Dm me this link on discord Ankit Aggarwal#2811 I will clarify with that participant because will let you know by evening.

she is printing the length and I am printing string

code is different for the both

I found that the problem she chosen is already done by you so I closed their issue. You can continue Do one thing create a new PR and send. Will review again

Thank you so much
It is already done pls review it @ankitaggarwal23