Units in metric instead of imperial

I have my weewx.conf configured in metric measurements, but, the MQTT data comes in imperial measurements.
How I can change it?
Thanks

I answer myself. I solved it by adding the parameter unit_system = METRIC to the MQTT section of the weewx.conf file

I answer myself. I solved it by adding the parameter unit_system = METRIC to the MQTT section of the weewx.conf file


fix(ui): update list of logos on the homepage

Fixes #1829 - addresses UI/UX feedback by Sage Design
Changelog

remove AWS logo
use alternative ITCR logo
use Sage logo with organization name

Preview

From this PDF and a font recognition tool, I was able to infer that the font used for the text of the logo is Montserrat-Bold, which is available on Adobe Fonts. I can also extract the NIH logo in vector format from the PDF.
Here is a preview of 1) the low-res logo from the ITCR website, 2) the logo I created in vector format and 3) the vector logo shown on top of the low-res logo to show how they align.

It's fine to use this logo until we get the official high-res logo from ITCR. I will share the SVG logo on Slack.

Thanks, @tschaffter !  I replaced the logo on the homepage with the hi-res you created.  Looks great!


Update of image

I've noticed the cron likely hasn't ran in a while and the image is no longer being updated.
Did you abandon this or just need to fix the ECR image build?

Oops. I stopped using this image (and the folks I know were using it also stopped using it) and somehow GitHub did not email me about the job not running 🤦 Sorry!
I re-enabled the workflow, but I don't plan to actively maintain this — new features, cleanup, upgrades, and other things like that are not something I can allocate time for at the moment.

Yeah, looks like the build is failing and I don't have the bandwidth to look into that so I'll go ahead and archive the repo. Sorry!


Weapon Refinery Data

Missing new weapons like Guard Bow+ As well as the ability to pick a refining for weapons that it applies to

@Lorenzooone is working on weapon refinery I think. Otherwise, we plan to get this out eventually. Real life has just been slowing things down a bit.
Cheers


There were missing keys in the checkpoint model loaded

I trained Alpaca-LoRA model with params:
base_model: /usr/local/dbbd/model/llama-7b-hf
data_path: alpaca_data.json
output_dir: ./lora-alpaca
batch_size: 128
micro_batch_size: 4
num_epochs: 2
learning_rate: 0.0001
cutoff_len: 512
val_set_size: 2000
lora_r: 8
lora_alpha: 16
lora_dropout: 0.05
lora_target_modules: ['q_proj', 'v_proj']
train_on_inputs: True
group_by_length: True
wandb_project:
wandb_run_name:
wandb_watch:
wandb_log_model:
resume_from_checkpoint: False
prompt template: alpaca
But I get a wrong adapter_model.bin which is only 443 bytes, and some output like:
There were missing keys in the checkpoint model loaded: ['base_model.model.model.embed_tokens.weight', 'base_model.model.model.layers.0.self_attn.q_proj.weight', 'base_model.model.model.layers.0.self_attn.q_proj.lora_A.default.weight', '.model.layers.0.self_attn.q_proj.lora_B.default.weight', 'base_model.model.model.layers.0.self_attn.k_proj.weight', 'base_model.model.model.layers.0.self_attn.v_proj.weight', 'base_model.model.model.layers.0.self_attn.v_proj.lora_A.defaue_model.model.model.layers.0.self_attn.v_proj.lora_B.default.weight', 'base_model.model.model.layers.0.self_attn.o_proj.weight', 'base_model.model.model.layers.0.self_attn.rotary_emb.inv_freq', 'base_model.model.model.layers.0.mlp.gate_pse_model.model.model.layers.0.mlp.down_proj.weight', 'base_model.model.model.layers.0.mlp.up_proj.weight', 'base_model.model.model.layers.0.input_layernorm.weight', 'base_model.model.model.layers.0.post_attention_layernorm.weight', 'baseel.layers.1.self_attn.q_proj.weight', 'base_model.model.model.layers.1.self_attn.q_proj.lora_A.default.weight', 'base_model.model.model.layers.1.self_attn.q_proj.lora_B.default.weight', 'base_model.model.model.layers.1.self_attn.k_proj.wdel.model.model.layers.1.self_attn.v_proj.weight', 'base_model.model.model.layers.1.self_attn.v_proj.lora_A.default.weight', 'base_model.model.model.layers.1.self_attn.v_proj.lora_B.default.weight', 'base_model.model.model.layers.1.self_ht', 'base_model.model.model.layers.1.self_attn.rotary_emb.inv_freq', 'base_model.model.model.layers.1.mlp.gate_proj.weight', 'base_model.model.model.layers.1.mlp.down_proj.weight', 'base_model.model.model.layers.1.mlp.up_proj.weight',
Does anyone know why this is

Vim your python path /site-packages/peft/utils/save_and_load.py, and comment the Line73 "to_return = {k.replace(f".{adapter_name}", ""): v for k, v in to_return.items()}" , because we don't set "adapter_name", and this code would erase all the state_dict if there is no adapter_name.

Why don't we set adapter_name from now on to avoid tweaking lib code?
Defaut name from current peft lib is adapter_name="default"
just adding this at training end in  get_peft_model_state_dict( would solve the issue, right?

Why don't we set adapter_name from now on to avoid tweaking lib code?
Defaut name from current peft lib is adapter_name="default" just adding this at training end in get_peft_model_state_dict( would solve the issue, right?

I first tried to add "default" to get_peft, but output was still empty for no reason..

UPDATED:
Vim your python path /site-packages/peft/utils/save_and_load.py, and comment# the "to_return = {k: v for k, v in to_return.items() if (("lora_" in k and adapter_name in k) or ("bias" in k))}" .
My latest conclusion is that we access "def get_peft_model_state_dict" twice, 1,
    old_state_dict = model.state_dict
     model.state_dict = (
         lambda self, *_, **__: get_peft_model_state_dict(
             self, old_state_dict()
         )
     ).__get__(model, type(model))

In this step, the "adapter_name =default" has been removed from state_dict.
2, model.save_pretrained(output_dir) Above code call get_peft_model_state_dict again, and "to_return = {k: v for k, v in to_return.items() if (("lora_" in k and adapter_name in k) or ("bias" in k))}" output empty {} because there is no adapter_name in k.

Well,I tried your method,but it doesn't work. and it seems that the content of this part has been updated

UPDATED:
Vim your python path /site-packages/peft/utils/save_and_load.py, and comment# the "to_return = {k: v for k, v in to_return.items() if (("lora_" in k and adapter_name in k) or ("bias" in k))}" .
My latest conclusion is that we access "def get_peft_model_state_dict" twice, 1,
    old_state_dict = model.state_dict
     model.state_dict = (
         lambda self, *_, **__: get_peft_model_state_dict(
             self, old_state_dict()
         )
     ).__get__(model, type(model))

In this step, the "adapter_name =default" has been removed from state_dict.
2, model.save_pretrained(output_dir) Above code call get_peft_model_state_dict again, and "to_return = {k: v for k, v in to_return.items() if (("lora_" in k and adapter_name in k) or ("bias" in k))}" output empty {} because there is no adapter_name in k.

Well,I tried your method,but it doesn't work. and it seems that the content of this part has been updated

Only comment the line 52 to #  #to_return = {k: v for k, v in to_return.items() if (("lora_" in k and adapter_name in k) or ("bias" in k))}
I just tried with 10 instance, and it generated 67M adapter_model.bin.
Or you can use the most easy way, back to the old PEFT version:
pip uninstall peft -y
pip install git+https://github.com/huggingface/peft.git@e536616888d51b453ed354a6f1e243fecb02ea08

UPDATED:
Vim your python path /site-packages/peft/utils/save_and_load.py, and comment# the "to_return = {k: v for k, v in to_return.items() if (("lora_" in k and adapter_name in k) or ("bias" in k))}" .
My latest conclusion is that we access "def get_peft_model_state_dict" twice, 1,
    old_state_dict = model.state_dict
     model.state_dict = (
         lambda self, *_, **__: get_peft_model_state_dict(
             self, old_state_dict()
         )
     ).__get__(model, type(model))

In this step, the "adapter_name =default" has been removed from state_dict.
2, model.save_pretrained(output_dir) Above code call get_peft_model_state_dict again, and "to_return = {k: v for k, v in to_return.items() if (("lora_" in k and adapter_name in k) or ("bias" in k))}" output empty {} because there is no adapter_name in k.

Well,I tried your method,but it doesn't work. and it seems that the content of this part has been updated

Only comment the line 52 to # #to_return = {k: v for k, v in to_return.items() if (("lora_" in k and adapter_name in k) or ("bias" in k))}
I just tried with 10 instance, and it generated 67M adapter_model.bin.
Or you can use the easy way, back to the old PEFT version:
pip uninstall peft -y
pip install git+https://github.com/huggingface/peft.git@e536616888d51b453ed354a6f1e243fecb02ea08

Thank you very much, your suggestion is useful, I reinstalled peft.
But I have another problem, I fine-tune it on my own dataset with the default parameters, the effect is not good. Do you have any suggestions

Without changing the source peft code, in my case, you can just remove the following line in finetuning.py to solve save adapter_model.bin twice and only get the last empty checkpoint with the missing key warning.
https://github.com/tloen/alpaca-lora/blob/8bb8579e403dc78e37fe81ffbb253c413007323f/finetune.py#L261-L272

I tried your approach, and now I'm getting quantization errors
RuntimeError: Loading a quantized checkpoint into non-quantized Linear8bitLt is not supported. Please call module.cuda() before module.load_state_dict()
I'm using an RTX 4090

old_state_dict = model.state_dict
state_dict = (
    lambda self, *_, **__: get_peft_model_state_dict(
        self, old_state_dict()
    )
).__get__(model, type(model))()

set_peft_model_state_dict(model, state_dict)

@darrenwang00 你好，是在后面加一个set_peft_model_state_dict(model, state_dict)这个吗

hi, did you solve the problem with the code set_peft_model_state_dict(model, state_dict)?


[AIRFLOW-3070] Refine web UI authentication-related docs

Make sure you have checked all steps below.
Jira

[x] My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-3070
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.

Description

[x] Here are some details about my PR, including screenshots of any UI changes:

Now in Airflow 1.10 we're already providing older version of web UI and new FAB-based UI at the same time. But the documentation is not differentiated very well. For example,

this doc https://airflow.apache.org/security.html#password is only applicable for old web UI only, but it's not hightlighted.
command line tool create_user  is only for new FAB-based UI only, it's not highlighted as well.

This may be confusing to users, especially given not everyone is aware of the existence of two UIs.
Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Doc change only

Commits

[x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[x] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

Thank you @kaxil for providing your inputs.
I have addressed accordingly. Kindly take another look. Thanks.

Can you also create a Jira issue? Any change that spans more than 1 line should have a jira.

Hi @kaxil , sorry I though no ticket is required as long as it's only documentation change.
I have raised a JIRA ticket (https://issues.apache.org/jira/browse/AIRFLOW-3070) and updated the PR subject, PR message body, and commit msg subject accordingly.
Thanks.

@XD-DENG Hey, No worries :-) . The idea behind there is no point in creating a Jira where we are just fixing typos or a single line document change. Everything other than that should have a Jira :)
Really appreciate all of your contributions. Keep contributing 🎉  and thanks for this PR as well.

Thanks @kaxil . Appreciate the time you guys contributed as well. Especially now, a Sunday :)
A nice afternoon ahead.


How to check/uncheck the select all checkbox programmatically ?

Hello,
I have to meet this requirement where all the items of the drop down should be selected by default, and I was able to achieve this by pre-populating the ngModel array. But at the same time, the select all checkbox should be pre-checked to make it logical.
Is there a way to programmatically check/uncheck the select-all checkbox ?

guess that PR #47 would make this possible

I would be surprised if PR #47 alone helped.
Select all is displayed in reaction to an event (drop-down) and event triggers change detection anyway.
Had a quick look into the code and writeValue seems to take care of the select-all checkbox.
                if(this.selectedItems.length === this.data.length && this.data.length > 0){
                            this.isSelectAll = true;
                        }

@saratSubramaniam if you compare length of arrays you pass to the ngModel and data input, do you have the same here and there?

Coming up, API methods to access the features programatically. Stay tuned.. Probably in next week release, you would be getting these features.

Can you please confirm whether this issue addressed in the latest code. Still I am seeing same issue with check all.
One more issue is when we select the items its showing all the name beside select instead of number of items selected. Could you please check.

fixed. please see the examples at https://cuppalabs.github.io/angular2-multiselect-dropdown/#/basic


Configuration for multiple modules on init.

Allows an app to pass an array of configuration to cornerstoneTools on init().

:tada: This PR is included in version 4.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


COMMONSRDF-47 RDFSyntax as an interface

COMMONSRDF-47
RDFSyntax  as an interface, with OfficialRDFSyntax is the enum - which implements the interface
basically .mediaType -> .mediaType() etc
One problem is that you can't override .equals() on an enum - and presumably it might be useful to compare if two RDFSyntaxes are the same?
Do we need to add our own .equals() and .hashCode() contract here as well (using mediaType())  and get rid of the enum?
we will also have to tweak the japicmp config as it (rightfully) complains about RDFSyntax changing its signature since 0.2.0, e.g.
***! MODIFIED INTERFACE (<- ENUM) : PUBLIC ABSTRACT (<- NON_ABSTRACT) NON_FINAL (<- FINAL) org.apache.commons.rdf.api.RDFSyntax  (class type modified)
        ---* REMOVED INTERFACE: java.lang.Comparable
        ---* REMOVED INTERFACE: java.io.Serializable
        ***! MODIFIED SUPERCLASS: java.lang.Object (<- java.lang.Enum)
        ***! MODIFIED FIELD: PUBLIC STATIC FINAL org.apache.commons.rdf.api.RDFSyntax$OfficialRDFSyntax (<- org.apache.commons.rdf.api.RDFSyntax) RDFA_XHTML
        ***! MODIFIED FIELD: PUBLIC STATIC FINAL org.apache.commons.rdf.api.RDFSyntax$OfficialRDFSyntax (<- org.apache.commons.rdf.api.RDFSyntax) NQUADS
        ***! MODIFIED FIELD: PUBLIC STATIC FINAL org.apache.commons.rdf.api.RDFSyntax$OfficialRDFSyntax (<- org.apache.commons.rdf.api.RDFSyntax) RDFA_HTML
        ---! REMOVED FIELD: PUBLIC(-) FINAL(-) java.lang.String mediaType
        ---! REMOVED FIELD: PUBLIC(-) FINAL(-) boolean supportsDataset
        ***! MODIFIED FIELD: PUBLIC STATIC FINAL org.apache.commons.rdf.api.RDFSyntax$OfficialRDFSyntax (<- org.apache.commons.rdf.api.RDFSyntax) RDFXML
        ---! REMOVED FIELD: PUBLIC(-) FINAL(-) java.lang.String fileExtension
        ***! MODIFIED FIELD: PUBLIC STATIC FINAL org.apache.commons.rdf.api.RDFSyntax$OfficialRDFSyntax (<- org.apache.commons.rdf.api.RDFSyntax) TURTLE
        ***! MODIFIED FIELD: PUBLIC STATIC FINAL org.apache.commons.rdf.api.RDFSyntax$OfficialRDFSyntax (<- org.apache.commons.rdf.api.RDFSyntax) NTRIPLES
        ***! MODIFIED FIELD: PUBLIC STATIC FINAL org.apache.commons.rdf.api.RDFSyntax$OfficialRDFSyntax (<- org.apache.commons.rdf.api.RDFSyntax) TRIG
        ***! MODIFIED FIELD: PUBLIC STATIC FINAL org.apache.commons.rdf.api.RDFSyntax$OfficialRDFSyntax (<- org.apache.commons.rdf.api.RDFSyntax) JSONLD
        +++* NEW METHOD: PUBLIC(+) ABSTRACT(+) java.lang.String fileExtension()
        +++* NEW METHOD: PUBLIC(+) ABSTRACT(+) java.lang.String mediaType()
        +++* NEW METHOD: PUBLIC(+) ABSTRACT(+) java.lang.String name()
        +++* NEW METHOD: PUBLIC(+) ABSTRACT(+) boolean supportsDataset()
        +++* NEW METHOD: PUBLIC(+) ABSTRACT(+) java.lang.String title()
        ---  REMOVED METHOD: PUBLIC(-) java.lang.String toString()
        ---! REMOVED METHOD: PUBLIC(-) STATIC(-) org.apache.commons.rdf.api.RDFSyntax valueOf(java.lang.String)
        ---! REMOVED METHOD: PUBLIC(-) STATIC(-) org.apache.commons.rdf.api.RDFSyntax[] values()

My suggestion is to delay this till past 0.3.0, as we're not settling RDFParser now anyway.

Let's discuss the mutability etc. of the RDFParser factory separate on dev@commons - that's a general thing which anyway should not affect this pull request on RDFSyntax.
This pull requests tries to address COMMONSRDF-47 which rightfully complains about RDFSyntax being an enum instead of interface.
@ansell - would you change your -1 (remember any committer has veto, and any ASF committer is Commons committer :-) ) if I add the plural RDFSyntax.mediaTypes() and RDFSyntax.fileExtensions() ?

Service discovery for other instances of RDFSyntax/Parsers can be done separately.
The main objection was for users of the RDFSyntax interface to be able to offer multiple content types and file extensions in addition to the official versions. They can be implemented by a default method that just returns the official content type and file extension inside of Commons RDF, but the fact that the method is available makes it possible to support the use case.
Returning a List, with the first element by convention being the official version similar to RDF4J may be useful, rather than an unordered Set. However, that isn't necessary, given they should be using the other methods if they definitely want the official extension/content type.

OK, so I added them as Set - it might be an ordered set (e.g. LinkedHashSet).
I merged RDFA_XHTML and RDFA_HTML and made them return such a set to include both text/html and application/xhtml.   Should we redefine .equals() and hashCode() to use uri() or would that be tricky then for arbitrary extra RDFSyntax-es?  (They could use a urn:uuid or something if they don't know)

I've merged this. Thanks for the help, @ansell!


Use correct attribution in the footer of documentation pages (monorepo)

Describe the enhancement requested
To be inline with ASF policy, we should update the text in the footer used in the docs (e.g. https://arrow.apache.org/docs/cpp/streaming_execution.html) to match the footer used in the main website (https://arrow.apache.org/). i.e. add  the trademark attribution test.

[ ] #39504
[ ] R docs
[ ] Java reference docs
[ ] ..?

Component(s)
Website

Opened a PR for the main sphinx site: https://github.com/apache/arrow/pull/39505


Add credit outside of the render loop

Credit and CreditDisplay were designed for adding attribution based on visibility, e.g., terrain tiles, during the render loop.
We also want apps to be able to add their own persistent credits directly without having to tap into the render loop and private frameState
From the Seattle demo.

This is what addDefaultCredit is for.

Ah, yes.  Thanks!


Always no output

Hi developers!
I recently encountered a problem. There were not any outputs for my darknet_ros node. I tried several  networks and weights (all downloaded from cmake process), it was the same situation. When I lowered the threshold , there would be some outputs, but the probability of all the objects were always the same.
hardware environment: Manifold 2-G, Jetson TX2.
software environment: Cuda 9.0+cudnn7.1.4 (arm architecture).
I git clone with recursive option, so it was not the problem.
I also added several lines in my CMakeLists.txt.
in found CUDA area, I added
add_definitions(-DCUDNN)
and also
  target_link_libraries(${PROJECT_NAME}_lib     ...     cudnn   )
there was no any errors in compilation.
anybody know where the problem is?
I will really appreciate it if anyone helps me! : )

hi, I met the same question, and I always have no output even when the threshold value is 0 after launch  darknet_ros.launch. have you solved it?

hi, I met the same question, and I always have no output even when the threshold value is 0 after launch  darknet_ros.launch. have you solved it?

hi, I met the same question, and I always have no output even when the threshold value is 0 after launch darknet_ros.launch. have you solved it?

sorry, still no solution.

Have you tried with the latest release?

If this is resolved, feel free the share how. If not, feel free to comment on the current state.


Add include and extend to Enum

I would like the posibility to use include and extend on Enum.
Now they are added to Enum.class but not to the actual Enum.
Say we do:
enum Status
  Opened
  Closed
end

And extend or include in an enum it will be only in Enum. And using include and extend won't work inside enum Status
So this won't work, but would probably solve the issue i am telling in detail below:
enum Status
  Opened
  Closed

  include OrmEnumType
  extend OrmEnumExtendType
end

Why I want this?
Most ORM adds module or methods to parse, get data from database and to database to a type, so-called type extensions. Enum is handling include and extend differently making this not work. And can therefore not use Enums as a type for columns without some type of wrapper class around the enum to cast it correctly and so on.

Already addressed by Ary in #8943 ❤

Related it's also not possible to use enums as a namespace https://play.crystal-lang.org/#/r/auuz.
enum Test
  One
  Two

  class Bar
  end
end

pp Test::Bar.new # => Error: unexpected token: class

Maybe there's a reason for this but seems a bit unexpected.

The reason is that all constants inside the enum are the enum members. If we allow classes or modules then that's not true anymore. But maybe it's a restriction we can remove.

If we consider allowing to use types in enum namespace, we could also consider arbitrary, non-member constants. This would allow doing this: https://github.com/crystal-lang/crystal/issues/10281#issuecomment-766403640 (see OP for context).

There is a possibly unintended alternative to extend:
enum A
  X
end

alias AClass = A.class

module B
  def foo
  end
end

class AClass
  include B # okay
end

A.foo # okay

The only difference is it would call a different macro hook. (Note that extending a module inside AClass would be semantically similar to including it inside Class, which affects all metaclasses.)

Is there a reason why https://github.com/crystal-lang/crystal/pull/8943 wasn't merged?

Why was https://github.com/crystal-lang/crystal/pull/8943 not merged?


Only show '[Process exited 139]'

when i use :Glow it only shows [Process exited 139]

hey @XXiaoA can you give more information please?

I'm having the same problem.
when i use :Glow README.md it only shows [Proccess exited 139]

my hardware specifications

Artix
5.16.16-artix1-1
NVIM v0.6.1

what I've accomplished

[x] Install Glow With :GlowInstall
[x] Reinstall Glow with :PackerInstall

Are you guys able to run glow outside neovim?

Guys can you pull latest and try again please? We did some improvements in the installation process which i hope can fix the issue on some distros

Guys can you pull latest and try again please? We did some improvements in the installation process which i hope can fix the issue on some distros

Yeah, I tried again just now, and it can work correctly. Thanks for ur great work!

I have exactly the same issue.
If I type glow in the terminal I get Segmentation fault
Fedora 37 KDE
AstroNvim 2.11.2
Nvim 0.8.1


DBZ-3787 Upgrade binlog-client to 0.25.3

https://issues.redhat.com/browse/DBZ-3787

@ani-sha Thanks for the PR. Unfortunately this is not full integration test. You should take a look at other integration tests - they start database, modify it, write data and check the results so what is tested is interaction between Debezium and database too. This is more unit test that tests MySQL DDL parser. Could you please take a second look?

@ani-sha, @jpechane, so to make this test truly meaningful, we'd have to run the database with --binlog-row-metadata=FULL (see here), as otherwise the binlog client won't receive that new metadata attribute for invisible columns. My question is: do we want to simply enable this when we run MySQL via Docker, or should there be a new Maven profile for that which only would run that test?

@gunnarmorling So I facing an issue during the container setup. I think the provided mysql.cnf file is not getting overridden. My current container definition is:
MySQLContainer<?> mySQLContainer = new MySQLContainer<>(MYSQL_DOCKER_IMAGE_NAME)
            .withDatabaseName(DATABASE.getDatabaseName())
            .withUsername("mysql")
            .withPassword("mysql")
            .withClasspathResourceMapping("/docker/conf/", "/etc/mysql", BindMode.READ_ONLY)
            .withLogConsumer(new Slf4jLogConsumer(LOGGER))
            .withExposedPorts(3306)
            .withNetworkAliases("mysql");

Is the resource mapping rightly done? The  path for mysql.cnf file is debezium-connector-mysql/src/test/resources/docker/conf/mysql.cnf

@ani-sha, in the example image, we copy the mysql.conf file to the /etc/mysql/conf.d/ directory, not etc/mysql. Probably also better to solely map the single file instead of the entire directory, as there might be other things in that directory in the MySQL image already.

@gunnarmorling I am still seeing this error in the logs
ERROR 1410 (42000) at line 14: You are not allowed to create a user with GRANT   [io.debezium.connector.mysql.MySqlParserIT]

And there is still a connection failure even after setting port as done in PostgresShutdownIT. Could you please review & check if the port has been set correctly or anything else is missing?

Could you share the full stack trace, please?

Could you share the full stack trace, please?

2021-09-07T11:55:22.5473866Z 2021-09-07 11:55:22,544 INFO   MySqlNumericColumnIT||test  Starting test io.debezium.connector.mysql.MySqlParserIT#parseTableWithVisibleColumns   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:24.3257512Z 2021-09-07 11:55:24,325 WARN   MySqlParserIT||test  folder-like containerPath in copyFileToContainer is deprecated, please explicitly specify a file path   [org.testcontainers.containers.GenericContainer]
2021-09-07T11:55:24.9033737Z 2021-09-07 11:55:24,889 INFO   ||  STDOUT: 2021-09-07 11:55:24+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 8.0.26-1debian10 started.   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:24.9549343Z 2021-09-07 11:55:24,953 INFO   ||  STDOUT: 2021-09-07 11:55:24+00:00 [Note] [Entrypoint]: Switching to dedicated user 'mysql'   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:24.9611487Z 2021-09-07 11:55:24,959 INFO   ||  STDOUT: 2021-09-07 11:55:24+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 8.0.26-1debian10 started.   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:25.0262676Z 2021-09-07 11:55:25,025 INFO   ||  STDOUT: 2021-09-07 11:55:25+00:00 [Note] [Entrypoint]: Initializing database files   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:25.0414273Z 2021-09-07 11:55:25,040 INFO   ||  STDERR: 2021-09-07T11:55:25.036736Z 0 [Warning] [MY-011070] [Server] 'Disabling symbolic links using --skip-symbolic-links (or equivalent) is the default. Consider not using this option as it' is deprecated and will be removed in a future release.   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:25.0422818Z 2021-09-07 11:55:25,041 INFO   ||  STDERR: 2021-09-07T11:55:25.036750Z 0 [Warning] [MY-011068] [Server] The syntax 'expire-logs-days' is deprecated and will be removed in a future release. Please use binlog_expire_logs_seconds instead.   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:25.0476625Z 2021-09-07 11:55:25,047 INFO   ||  STDERR: 2021-09-07T11:55:25.036822Z 0 [System] [MY-013169] [Server] /usr/sbin/mysqld (mysqld 8.0.26) initializing of server in progress as process 42   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:25.0564568Z 2021-09-07 11:55:25,056 INFO   ||  STDERR: 2021-09-07T11:55:25.055933Z 1 [System] [MY-013576] [InnoDB] InnoDB initialization has started.   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:25.7947663Z 2021-09-07 11:55:25,794 INFO   ||  STDERR: 2021-09-07T11:55:25.793494Z 1 [System] [MY-013577] [InnoDB] InnoDB initialization has ended.   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:27.2980101Z 2021-09-07 11:55:27,297 INFO   ||  STDERR: 2021-09-07T11:55:27.296804Z 0 [Warning] [MY-013746] [Server] A deprecated TLS version TLSv1 is enabled for channel mysql_main   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:27.2986538Z 2021-09-07 11:55:27,298 INFO   ||  STDERR: 2021-09-07T11:55:27.297141Z 0 [Warning] [MY-013746] [Server] A deprecated TLS version TLSv1.1 is enabled for channel mysql_main   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:27.3909236Z 2021-09-07 11:55:27,390 INFO   ||  STDERR: 2021-09-07T11:55:27.390156Z 6 [Warning] [MY-010453] [Server] root@localhost is created with an empty password ! Please consider switching off the --initialize-insecure option.   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:30.5565965Z 2021-09-07 11:55:30,555 INFO   ||  STDOUT: 2021-09-07 11:55:30+00:00 [Note] [Entrypoint]: Database files initialized   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:30.5571609Z 2021-09-07 11:55:30,555 INFO   ||  STDOUT: 2021-09-07 11:55:30+00:00 [Note] [Entrypoint]: Starting temporary server   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:30.8228015Z 2021-09-07 11:55:30,822 INFO   ||  STDERR: 2021-09-07T11:55:30.808237Z 0 [Warning] [MY-011070] [Server] 'Disabling symbolic links using --skip-symbolic-links (or equivalent) is the default. Consider not using this option as it' is deprecated and will be removed in a future release.   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:30.8231496Z 2021-09-07 11:55:30,822 INFO   ||  STDERR: 2021-09-07T11:55:30.808259Z 0 [Warning] [MY-011068] [Server] The syntax 'expire-logs-days' is deprecated and will be removed in a future release. Please use binlog_expire_logs_seconds instead.   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:30.8234070Z 2021-09-07 11:55:30,822 INFO   ||  STDERR: 2021-09-07T11:55:30.808397Z 0 [System] [MY-010116] [Server] /usr/sbin/mysqld (mysqld 8.0.26) starting as process 89   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:30.8255298Z 2021-09-07 11:55:30,825 INFO   ||  STDERR: 2021-09-07T11:55:30.824612Z 1 [System] [MY-013576] [InnoDB] InnoDB initialization has started.   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:31.0048965Z 2021-09-07 11:55:31,004 INFO   ||  STDERR: 2021-09-07T11:55:31.003915Z 1 [System] [MY-013577] [InnoDB] InnoDB initialization has ended.   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:31.2540602Z 2021-09-07 11:55:31,253 INFO   ||  STDERR: 2021-09-07T11:55:31.252927Z 0 [Warning] [MY-013746] [Server] A deprecated TLS version TLSv1 is enabled for channel mysql_main   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:31.2543959Z 2021-09-07 11:55:31,253 INFO   ||  STDERR: 2021-09-07T11:55:31.253042Z 0 [Warning] [MY-013746] [Server] A deprecated TLS version TLSv1.1 is enabled for channel mysql_main   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:31.2554195Z 2021-09-07 11:55:31,255 INFO   ||  STDERR: 2021-09-07T11:55:31.254621Z 0 [Warning] [MY-010068] [Server] CA certificate ca.pem is self signed.   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:31.2557985Z 2021-09-07 11:55:31,255 INFO   ||  STDERR: 2021-09-07T11:55:31.255112Z 0 [System] [MY-013602] [Server] Channel mysql_main configured to support TLS. Encrypted connections are now supported for this channel.   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:31.2575420Z 2021-09-07 11:55:31,257 INFO   ||  STDERR: 2021-09-07T11:55:31.256825Z 0 [Warning] [MY-011810] [Server] Insecure configuration for --pid-file: Location '/var/run/mysqld' in the path is accessible to all OS users. Consider choosing a different directory.   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:31.2836422Z 2021-09-07 11:55:31,283 INFO   ||  STDERR: 2021-09-07T11:55:31.282967Z 0 [System] [MY-011323] [Server] X Plugin ready for connections. Socket: /var/run/mysqld/mysqlx.sock   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:31.2851084Z 2021-09-07 11:55:31,284 INFO   ||  STDERR: 2021-09-07T11:55:31.284377Z 0 [System] [MY-010931] [Server] /usr/sbin/mysqld: ready for connections. Version: '8.0.26'  socket: '/var/run/mysqld/mysqld.sock'  port: 0  MySQL Community Server - GPL.   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:31.2960770Z 2021-09-07 11:55:31,295 INFO   ||  STDOUT: 2021-09-07 11:55:31+00:00 [Note] [Entrypoint]: Temporary server started.   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:31.9036713Z 2021-09-07 11:55:31,902 INFO   ||  STDERR: Warning: Unable to load '/usr/share/zoneinfo/iso3166.tab' as time zone. Skipping it.   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:31.9039401Z 2021-09-07 11:55:31,903 INFO   ||  STDERR: Warning: Unable to load '/usr/share/zoneinfo/leap-seconds.list' as time zone. Skipping it.   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:33.4292047Z 2021-09-07 11:55:33,428 INFO   ||  STDERR: Warning: Unable to load '/usr/share/zoneinfo/zone.tab' as time zone. Skipping it.   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:33.4297412Z 2021-09-07 11:55:33,429 INFO   ||  STDERR: Warning: Unable to load '/usr/share/zoneinfo/zone1970.tab' as time zone. Skipping it.   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:33.5084413Z 2021-09-07 11:55:33,508 INFO   ||  STDOUT: 2021-09-07 11:55:33+00:00 [Note] [Entrypoint]: Creating database mysql   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:33.5209898Z 2021-09-07 11:55:33,520 INFO   ||  STDOUT: 2021-09-07 11:55:33+00:00 [Note] [Entrypoint]: Creating user mysql   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:33.5346633Z 2021-09-07 11:55:33,534 INFO   ||  STDOUT: 2021-09-07 11:55:33+00:00 [Note] [Entrypoint]: Giving user mysql access to schema mysql   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:33.5448675Z 2021-09-07 11:55:33,544 INFO   ||  STDOUT:    [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:33.5465760Z 2021-09-07 11:55:33,546 INFO   ||  STDOUT: 2021-09-07 11:55:33+00:00 [Note] [Entrypoint]: /usr/local/bin/docker-entrypoint.sh: running /docker-entrypoint-initdb.d/inventory.sql   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:55:33.5667911Z 2021-09-07 11:55:33,566 INFO   ||  STDERR: ERROR 1410 (42000) at line 14: You are not allowed to create a user with GRANT   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:57:24.9674519Z 2021-09-07 11:57:24,962 WARN   MySqlParserIT||test  Variables cannot be used in the 'plugin.path' property, since the property is used by plugin scanning before the config providers that replace the variables are initialized. The raw value 'null' was used for plugin scanning, as opposed to the transformed value 'null', and this may cause unexpected results.   [org.apache.kafka.connect.runtime.WorkerConfig]
2021-09-07T11:57:24.9678956Z 2021-09-07 11:57:24,963 ERROR  MySqlParserIT||engine  The 'database.history.kafka.bootstrap.servers' value is invalid: A value is required   [io.debezium.connector.common.BaseSourceTask]
2021-09-07T11:57:24.9682213Z 2021-09-07 11:57:24,963 ERROR  MySqlParserIT||engine  The 'database.history.kafka.topic' value is invalid: A value is required   [io.debezium.connector.common.BaseSourceTask]
2021-09-07T11:57:24.9684881Z 2021-09-07 11:57:24,963 INFO   MySqlParserIT||engine  Stopping down connector   [io.debezium.connector.common.BaseSourceTask]
2021-09-07T11:57:24.9693686Z 2021-09-07 11:57:24,963 ERROR  MySqlParserIT||engine  Unable to initialize and start connector's task class 'io.debezium.connector.mysql.MySqlConnectorTask' with config: {connector.class=io.debezium.connector.mysql.MySqlConnector, database.history.file.filename=/home/runner/work/debezium/debezium/debezium-connector-mysql/target/data/file-db-history-column-constraints.txt, database.user=mysql, database.server.id=18765, database.server.name=myServer1, database.port=49167, offset.flush.interval.ms=0, database.ssl.mode=disabled, offset.storage.file.filename=/home/runner/work/debezium/debezium/debezium-connector-mysql/target/data/file-connector-offsets.txt, database.hostname=localhost, poll.interval.ms=10, database.*** name=testing-connector, binlog.buffer.size=10000, snapshot.mode=initial, database.include.list=mysql}   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:57:24.9712249Z org.apache.kafka.connect.errors.ConnectException: Error configuring an instance of MySqlConnectorTask; check the logs for details
2021-09-07T11:57:24.9714095Z 	at io.debezium.connector.common.BaseSourceTask.start(BaseSourceTask.java:123)
2021-09-07T11:57:24.9719777Z 	at io.debezium.embedded.EmbeddedEngine.run(EmbeddedEngine.java:759)
2021-09-07T11:57:24.9721451Z 	at io.debezium.embedded.AbstractConnectorTest.lambda$start$5(AbstractConnectorTest.java:369)
2021-09-07T11:57:24.9723345Z 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
2021-09-07T11:57:24.9725078Z 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
2021-09-07T11:57:24.9726218Z 	at java.base/java.lang.Thread.run(Thread.java:829)
2021-09-07T11:57:24.9727835Z 2021-09-07 11:57:24,966 INFO   MySqlParserIT||test  Stopping the connector   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:57:24.9729593Z 2021-09-07 11:57:24,966 INFO   MySqlParserIT||test  Interrupting the engine   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:57:24.9947685Z 2021-09-07 11:57:24,993 INFO   MySqlParserIT||test  Stopping the connector   [io.debezium.connector.mysql.MySqlParserIT]
2021-09-07T11:57:24.9950417Z 2021-09-07 11:57:24,994 INFO   MySqlParserIT||test  Test io.debezium.connector.mysql.MySqlParserIT#parseTableWithVisibleColumns failed   [io.debezium.connector.mysql.MySqlParserIT]

@ani-sha, so I've pushed a commit which makes some progress, but it's still not working 100% yet. I changed the name of the variable to use underscores; while I'm not 100% sure whether that's needed, it's more inline with the other vars and what's shown in MySQL docs.
Re the grant issue, that's a bit tricky: In the inventory.sql we grant privileges to a user ("mysqluser") which isn't created in that script (this was allowed in the past, implicitly creating the user then). It works for the tutorial, because there we run the image with this user, thus creating it.
For now, I've worked around it by using that same user in this test, so to achieve the same result. But actually, the user should be created in the example file, using the password from the tutorial. This may break other usages of the image where it is started with that user and another password, but I think that's acceptable.
Note I'm still getting an privileges issue despite my change, not sure why, because that GRANT assigns all privileges. Perhaps try and do the change described above, so to see whether it addresses the issue?
In terms of the database name, I've adjusted the test so to use the "inventory" database, so to match what's used in the inventory.sql file when assigning privileges. Testcontainers still will create another database ("mysql"), but this shouldn't matter.

@ani-sha, in case you missed it, I've pushed the commit wit my missing changes. Feel free to squash everything into a single commit of yourself. Thx.

@gunnarmorling Will adding a RELOAD when granting all privileges to mysqluser work?
io.debezium.DebeziumException: java.sql.SQLSyntaxErrorException: Access denied; you need (at least one of) the RELOAD or FLUSH_TABLES privilege(s) for this operation
2021-09-08T10:23:02.0625139Z 	at io.debezium.pipeline.source.AbstractSnapshotChangeEventSource.execute(AbstractSnapshotChangeEventSource.java:79)
2021-09-08T10:23:02.0628539Z 	at io.debezium.pipeline.ChangeEventSourceCoordinator.lambda$start$0(ChangeEventSourceCoordinator.java:118)
2021-09-08T10:23:02.0630657Z 	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
2021-09-08T10:23:02.0631927Z 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
2021-09-08T10:23:02.0633793Z 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
2021-09-08T10:23:02.0635717Z 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
2021-09-08T10:23:02.0636935Z 	at java.base/java.lang.Thread.run(Thread.java:829)

@jpechane Any thoughts? ^^

@ani-sha Please see https://github.com/debezium/debezium/blob/master/debezium-connector-mysql/src/test/docker/init/setup.sql#L9-L15
That's what we use for test. So yes before the Debezium connection you need to configure the user to have similar privileges.

@jpechane Won't the container be using this https://github.com/debezium/docker-images/blob/master/examples/mysql/1.7/inventory.sql? And this grants privileges to mysqluser which I have used.

@ani-sha What if you use debezium user? Maybe some of the privileges does not fall under the ALL umberella.

I had to execute GRANT RELOAD ON . TO 'mysqluser';

@jpechane, should we add this to the inventory.sql file in the example image then?

@gunnarmorling No, our turotials and everything uses debezium user that is configured as it should.

@jpechane, so what exactly are you suggesting then?

@gunnarmorling To use debezium user in the test.

To use debezium user in the test.

@jpechane It throws an error.
STDERR: ERROR 1396 (HY000) at line 8: Operation CREATE USER failed for 'debezium'@'%'   [io.debezium.connector.mysql.MySqlParserIT]

Apart from changing the user to debezium do we need to provide any other grants?

@ani-sha Please use
                .with(MySqlConnectorConfig.USER, "debezium")
                .with(MySqlConnectorConfig.PASSWORD, "dbz")

when configuring the connector

@ani-sha, are the test failures related?

@gunnarmorling SQL Server tests are unrelated. Rest checks passed. Could you review it?

@ani-sha, is the SQL Server failure tracked in JIra already? If not, can you please log an issue and reference it here?

Thnx @gunnarmorling.
Logged https://issues.redhat.com/browse/DBZ-4004 & https://issues.redhat.com/browse/DBZ-4005

Raaah, the backport didn't quite work out. Looking into it.

Ok, should be sorted out now.


"Installation and Setup" page endorses a non-libre Web browser

The "Installation and Setup" page currently suggests using the "Google Chrome" Web browser.
This is not free/libre/open-source software, and therefore violates the essential rights and freedoms of people who use the software.
Since there are free/libre/open-source alternatives, for example the excellent Firefox Quantum Web browser, there is no need for people to continue using inferior, locked down, proprietary products.
The Muledump setup instructions page is a great place to encourage people to upgrade to a free/libre/open-source Web browser! (Since RotMG is not free/libre/open-source, this is a also great opportunity to help introduce Realm players to the value of breaking out of the restrictions of proprietary apps! :smile_cat:)

The Installation and Setup Guide focuses on Chrome, yes. I would not be opposed to writing a Firefox section for the initial setup steps and pointing out the details you've mentioned. Until I make our own Firefox CORS extension tho it can't be a candidate for our primarily recommended browser. Maybe in time? A Firefox extension is planned.
As such we are not going to discontinue recommending Google Chrome as our preferred browser; however, I can make Firefox and GNU's vision more prominent in the guide as it is a fully supported browser.
I appreciate your concern and input. Comments like this ultimately will lead to a better application. Hopefully my actions here land on a good compromise.
Leaving this open for now. I'll close it after the wiki is updated.

For what it's worth, Chromium is a free/libre/open-source Web browser, and is used as the basis of Google Chrome. While it is still sadly dependent on and controlled by Google, it might be worth looking into to see if it would be a suitable alternative until the extension works with Firefox. :)


Updated docs for resize_images_v2

Corrected grammatical errors

Since merging PRs is an expensive process due to multiple CI jobs needing to be run, we will not accept PRs that have a delta of just a small number of characters.
Please fix an entire file/directory instead of just one typo.


Auto add self dependency to npm

Type: Bug
When I open a package.json file (for npm), it seems that these 2 things happen:

a self dependency is added into the package.json file
package-lock.json is generated.

This is as-if npm install . was called every time I open a package.json file, on the package.json directory.

More details from me:
Everytime i alter/open a package.json and delete the line
    "@libraryname/ngx-table": "file:",

it gets added again and prevents me to build.
I alos get the same behaviour in another project where "webapp": "file:" is added (webapp is the name of the folder the project is in).

I can confirm this Issue with Version v0.9.5

It seems like you’re encountering an issue where opening a package.json file in Visual Studio Code triggers behavior similar to running npm install ., resulting in a self-dependency being added and a package-lock.json file being generated. This is not the expected behavior when simply opening a file. a few steps you can take to troubleshoot and potentially resolve the issue:
Check for Extension Conflicts: Sometimes, extensions can cause unexpected behavior. Check if you have any extensions related to npm or package management that might be causing this issue1.
Update VS Code and Extensions: Ensure that your VS Code and all extensions are up to date. An outdated extension or VS Code version might have known bugs that have been fixed in later releases.
Review Extension Settings: Look into the settings of your installed extensions to see if there’s an option that might be causing this behavior. Some extensions have features that automatically run npm commands upon certain triggers.
Disable Extensions: Try disabling all extensions and then re-enable them one by one to identify if a specific extension is causing the problem.
Check VS Code Settings: Review your VS Code settings (both user and workspace settings) for any configurations related to npm or scripts that might be running on file open.
Consult VS Code Documentation: The VS Code documentation and community forums can be a valuable resource for troubleshooting issues. You might find others who have experienced similar problems and shared solutions2.
Report the Issue: If none of the above steps help, consider reporting the issue to the VS Code GitHub repository with detailed information about your setup and the steps to reproduce the bug.
Remember to back up your package.json and package-lock.json files before making changes or updates, just in case you need to revert to a previous state. Hopefully, these steps will help you resolve the issue and prevent the unwanted behavior from occurring.

Is that a bot comment?
Regarding the issue, it happens on last version only (0.9.5). As a workaround one can force 0.9.4 or disable the dependency and rollback the changes (I did the 2nd one) until a new version with a fix is released.

Iam Mexican....lol was just trying to be helpful by providing precise/concise alternatives for troubleshooting the possible issues
and regarding the package. Json it’s good to hear that you’ve identified the issue as being specific to version 0.9.5 of the extension and that you’ve found a workaround forcing 0.9.4 disabling the dependency and rolling back the changes a temporary solution until the extension’s maintainers releases a new version with a fix. i would hit them up with the issue or use code pilot in vscode for a robust suggestion

I also have the above described issue with this additional effect:

Autoformat of package.json on file open
Autoadd of self dependency in package-lock.json
AFAIK No logs anywhere in the output windows

By switching to 0.9.4 the issue disappeared, but I get a warning notification Command failed: npm i --package-lock-only --prefix ...

This is specially annoying after I moved to yarn, as it keeps downloading the dreaded node_modules which I finally managed to get myself rid of...


netdata: 1.46.1 -> 1.47.0

Description of changes
Replaces #336910 if it builds successfully.
Netdata adds lm_sensors as soft dependency https://github.com/netdata/netdata/commit/6d4a0071649adbc26aa76779bf2217c6c6422e66
logs-management was remove netdata/netdata#18186
I've disabled log management since it's the new default https://github.com/netdata/netdata/commit/43c72b303c1c896f0fafaee7fdbacce363c5874a
Things done

Built on platform(s)

[X] x86_64-linux
[X] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Hi, any ideas why this does not build @pedorich-n @RaitoBezarius

Thank you for the PR! I've been meaning to have a look at this, but haven't had a chance yet.
I don't fully understand why it's failing, but I think I managed to "narrow it down" to go modules. When I add the following to the cmakeFlags the build succeeds.
(lib.cmakeBool "ENABLE_PLUGIN_GO" false)

I don't know if it's normal for Go builds in Nix, but I see a lot of connection refused for Go modules in the logs. Is it possible that Cmake doesn't use the pre-built Go modules and tries to download them during the build and that's why it fails?

Apologies I moved away from netdata, so I don't really maintain it anymore.

What I could deduce is that the go closure has the required modules. I think the issue is that it's not using it as intended.
> nix-build -A netdata.netdata-go-modules
Finished at 19:24:03 after 0s
/nix/store/xiapjp91jwhv5kr776pqwsnn0fhpqsw7-netdata-go-plugins-1.47.0-go-modules

> find /nix/store/xiapjp91jwhv5kr776pqwsnn0fhpqsw7-netdata-go-plugins-1.47.0-go-modules -name 'go-flags'
/nix/store/xiapjp91jwhv5kr776pqwsnn0fhpqsw7-netdata-go-plugins-1.47.0-go-modules/github.com/jessevdk/go-flags

Error build with enable log management:
rror: builder for '/nix/store/sn2qkrkn89d8s1vsq38jimyjjcs66gbs-netdata-1.47.0.drv' failed with exit code 1;
       last 10 log lines:
       > -- Installing: /nix/store/q37kqdfsyi5wxdc5nq0860wn376fqdb9-netdata-1.47.0/share/netdata/web/registry-hello.html
       > -- Installing: /nix/store/q37kqdfsyi5wxdc5nq0860wn376fqdb9-netdata-1.47.0/share/netdata/web/switch.html
       > -- Installing: /nix/store/q37kqdfsyi5wxdc5nq0860wn376fqdb9-netdata-1.47.0/share/netdata/web/ilove.html
       > -- Installing: /nix/store/q37kqdfsyi5wxdc5nq0860wn376fqdb9-netdata-1.47.0/share/netdata/web/old/index.html
       > -- Installing: /nix/store/q37kqdfsyi5wxdc5nq0860wn376fqdb9-netdata-1.47.0/share/netdata/web/static/img/netdata-logomark.svg
       > -- Installing: /nix/store/q37kqdfsyi5wxdc5nq0860wn376fqdb9-netdata-1.47.0/share/netdata/web/css/morris-0.5.1.css
       > -- Installing: /nix/store/q37kqdfsyi5wxdc5nq0860wn376fqdb9-netdata-1.47.0/share/netdata/web/css/c3-0.4.18.min.css
       > -- Installing: /nix/store/q37kqdfsyi5wxdc5nq0860wn376fqdb9-netdata-1.47.0/share/netdata/web/.well-known/dnt/cookies
       > -- Installing: /nix/store/q37kqdfsyi5wxdc5nq0860wn376fqdb9-netdata-1.47.0/share/netdata/web/v0/index.html
       > mv: cannot stat '/nix/store/q37kqdfsyi5wxdc5nq0860wn376fqdb9-netdata-1.47.0/libexec/netdata/plugins.d/logs-management.plugin': No such file or directory
       For full logs, run 'nix log /nix/store/sn2qkrkn89d8s1vsq38jimyjjcs66gbs-netdata-1.47.0.drv'.

Error build with enable log management:
rror: builder for '/nix/store/sn2qkrkn89d8s1vsq38jimyjjcs66gbs-netdata-1.47.0.drv' failed with exit code 1;
       last 10 log lines:
       > -- Installing: /nix/store/q37kqdfsyi5wxdc5nq0860wn376fqdb9-netdata-1.47.0/share/netdata/web/registry-hello.html
       > -- Installing: /nix/store/q37kqdfsyi5wxdc5nq0860wn376fqdb9-netdata-1.47.0/share/netdata/web/switch.html
       > -- Installing: /nix/store/q37kqdfsyi5wxdc5nq0860wn376fqdb9-netdata-1.47.0/share/netdata/web/ilove.html
       > -- Installing: /nix/store/q37kqdfsyi5wxdc5nq0860wn376fqdb9-netdata-1.47.0/share/netdata/web/old/index.html
       > -- Installing: /nix/store/q37kqdfsyi5wxdc5nq0860wn376fqdb9-netdata-1.47.0/share/netdata/web/static/img/netdata-logomark.svg
       > -- Installing: /nix/store/q37kqdfsyi5wxdc5nq0860wn376fqdb9-netdata-1.47.0/share/netdata/web/css/morris-0.5.1.css
       > -- Installing: /nix/store/q37kqdfsyi5wxdc5nq0860wn376fqdb9-netdata-1.47.0/share/netdata/web/css/c3-0.4.18.min.css
       > -- Installing: /nix/store/q37kqdfsyi5wxdc5nq0860wn376fqdb9-netdata-1.47.0/share/netdata/web/.well-known/dnt/cookies
       > -- Installing: /nix/store/q37kqdfsyi5wxdc5nq0860wn376fqdb9-netdata-1.47.0/share/netdata/web/v0/index.html
       > mv: cannot stat '/nix/store/q37kqdfsyi5wxdc5nq0860wn376fqdb9-netdata-1.47.0/libexec/netdata/plugins.d/logs-management.plugin': No such file or directory
       For full logs, run 'nix log /nix/store/sn2qkrkn89d8s1vsq38jimyjjcs66gbs-netdata-1.47.0.drv'.

I've missed that it was removed netdata/netdata#18186

changefinder was also dropped: https://github.com/netdata/netdata/pull/18370
I believe it was added only because of netdata, and used only here: https://github.com/NixOS/nixpkgs/blob/3736dd89d4c831157739051315be405e87ed9249/nixos/modules/services/monitoring/netdata.nix#L221
But I don't know what is the process of removing something from nixpkgs. Probably it's better to do in a separate PR.


Rule: Detect lowercased global variable

According to RF User Guide it is recommended to keep global variables capitalized, as well as suite and test variables. Only local variables should stay lowercased.

Hi @mnojek, I'd like to implement this rule.
Would you be able to define the rule number, the severity, and the message?

Hi @yo-ga. Just pick any next available id from naming checkers (03xx) - I think it's 14 (0314).
The severity should be WARNING and the message it's up to you. I will comment on your proposition if I will feel that something different could fit better. Get inspired by other rules from the same checker. Good luck 😉

After checking VariableNamingChecker, it has already covered capital letter cases.
Target PR: #268

You're right @yo-ga . I'm closing this issue. Thanks for the notice!


[Bug] When submitting a task to k8s session's flink cluster, the task was submitted repeatedly.

Search before asking

[X] I had searched in the issues and found no similar issues.

Java Version
No response
Scala Version
2.12.x
StreamPark Version
2.1.2
Flink Version
1.17.2
deploy mode
None
What happened
When submitting a task in  k8s session's flink cluster, the task was submitted repeatedly. Some mechanisms should be designed to avoid repeated submissions, such as idempotence.
Error Exception
No response
Screenshots

Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!(您是否要贡献这个PR?)

Code of Conduct

[X] I agree to follow this project's Code of Conduct

same with #3388


[Feature #884] Helm chart for Kubernetes deployments

PR Description
This is a new feature request to create a Helm chart to support the Kubernetes based deployments in a package pattern. This Helm chart should enable the NeoDash deployment in either editor or reader mode for easy versioning, packaging and installing these dashboards at an enterprise level.
The solution includes a Helm chart with the following Kubernetes resources templates to support the editor or reader mode for ease of deployment,

Deployment
Service
Service Account
Ingress (Optional)
Values file (Default configurations)
Along with the Helm chart, add the appropriate documentation about the usage and default values.

As an alternative solution I also included the required Kubernetes YAML files to deploy the NeoDash with Kubectl commands.
#884

Hi @venkatalolla, thank you for your contribution! Could you please check the warning that are popping up in this page and check whether they are critical or not?
Thanks again for helping the project!

Hey @alfredorubin96 if you're talking about the sonarcloud warning, I already fixed them in my last commit, and they're gone now. Just so you know, they weren't critical anyway.

Looked at the code and sounds good to me, could you please provide me an easy way to test it? I'm not an expert in developing helm charts, but there is a way in which we can test the deployment inside our pipelines?

Hello @alfredorubin96, Thank you for the response. For testing the Helm chart deployment, I have put together a GitHub workflow in my own repository, https://github.com/venkatalolla/neodash-kind-helm-workflow, that deploys the Helm chart to a local KinD Kubernetes cluster and validates the 200 response for the NeoDash URL using CURL.
For your information, I have tested the above-shared workflow here using the same code from this PR as an example.
Let me know if you want me to provide more details on the GitHub workflow or the deployment.

@alfredorubin96, please let me know if you need more information on my last comment.

Moved to PR #971 for small changes/typo

Closing as this is moved to #971


Docs: Testing your code - API Gateway HTTP API

What were you searching in the docs?
I was looking for an example to test my new lambda function that I used API Gateway HTTP API and the exampled provided was not working.

What I made was debuging the errors and made a new `minimal_event` dict. What I cannot do for now (because of time - and two kids) is to find if it was a Documentation error or a code error.

Got a suggestion in mind?
What I do to resolve the problem is to change the minimal_event dict to this:
    minimal_event = {
        "rawPath": "/todos",
        "requestContext": {
            "http": {
                "method": "GET",
            },
            "stage": "$default",
        },
    }

And the result now was this:
======================================= test session starts =======================================
platform darwin -- Python 3.8.12, pytest-7.2.0, pluggy-1.0.0
rootdir: /Volumes/HD/Whatever, configfile: pyproject.toml, testpaths: backend/tests
plugins: typeguard-2.13.3, anyio-3.6.2
collected 1 item

backend/tests/microservices/cobranca_clientes/test_index.py .                               [100%]

======================================== 1 passed in 0.17s ========================================

Acknowledgment

[X] I understand the final update might be different from my proposed suggestion, or refused.

🤦♂ we forgot to update this section as we’ve moved to V2 - apologies for
the inconveniences.
Would you like to open a quick PR to fix it? I can merge and make any
amendments tomorrow.
Obrigado ;-)
On Mon, 7 Nov 2022 at 18:55, boring-cyborg[bot] @.***>
wrote:

Thanks for opening your first issue here! We'll come back to you as soon
as we can.
In the meantime, check out the #python channel on our AWS Lambda
Powertools Discord: Invite link https://discord.gg/B8zZKbbyET
—
Reply to this email directly, view it on GitHub
https://github.com/awslabs/aws-lambda-powertools-python/issues/1686#issuecomment-1305979556,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZPQBGIWHMPIIBAJKFLHPTWHE7A7ANCNFSM6AAAAAARZOLTIA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***
com>

There’s no need to apologize! Tá tudo certo!
I will make the PR to fix it!
Thanks!!!

thank you! I also read it too quickly on my phone yesterday - that section of docs is taking into account REST API flavour only hence the issue -- I misread and somehow linked to our headers breaking change in V2. I'll adjust your PR so it includes both REST, HTTP, and ALB accordingly to prevent confusion.

Ohhh... i get it! I remembered another issue i get to make the PR: the pyproject.toml is broken because of Poetry version and the new group parameter... so to make the PR I have to do here on Github, because I the pre-commit hooks are getting errors... If you need something, just let me know!
Abraço!

the pyproject.toml is broken because of Poetry version and the new group parameter...

I think we fixed that in the last release, but let me know otherwise. Poetry latest version made a breaking change - TIL about their versioning model. We need to migrate all dev deps into the new group thing.
As regards to your doc PR, I've just pushed changes and commented asking to double check. It'll look like this now.

If you need something, just let me know!

don't say that twice ;) We're always looking for help, got some challenges stuff in the backlog

Just rebuilt the latest docs - https://awslabs.github.io/aws-lambda-powertools-python/2.2.0/core/event_handler/api_gateway/#testing-your-code
Available now and thank you again for the contribution <3


Any options to increase vLLM performance?

I am testing on A100 and H100, but the performance is significantly lower compared to TGI.
TGI and vLLM have many similar features such as paged attention and continuous batch.
I tested both serving solutions with the latest version using the LLaMA 2 70B model.
I ran it with the default options, are there any options that need to be added or changed in order to improve vLLM performance?
vLLM Setting
Client Settings
sampling params: SamplingParams(n=1, best_of=1, presence_penalty=0.0, frequency_penalty=0.0, repetition_penalty=1.0, temperature=1.0, top_p=1.0, top_k=-1, min_p=0.0, use_beam_search=False, length_penalty=1.0, early_stopping=False, stop=[], ignore_eos=True, max_tokens=500, logprobs=None, prompt_logprobs=None, skip_special_tokens=True, spaces_between_special_tokens=True),
Server Settings
args: Namespace(host=None, port=8000, allow_credentials=False, allowed_origins=[''], allowed_methods=[''], allowed_headers=['*'], served_model_name=None, model='/mnt/models/Llama-2-70b', tokenizer=None, revision=None, tokenizer_revision=None, tokenizer_mode='auto', trust_remote_code=False, download_dir=None, load_format='auto', dtype='auto', max_model_len=None, worker_use_ray=False, pipeline_parallel_size=1, tensor_parallel_size=4, block_size=16, seed=0, swap_space=4, gpu_memory_utilization=0.9, max_num_batched_tokens=None, max_num_seqs=256, max_paddings=256, disable_log_stats=False, quantization=None, engine_use_ray=False, disable_log_requests=False, max_log_len=None)

Tensor parallelism is a bit slow due to Ray core pinning. After launching your server, run this command:
cpuid=0 ; for pid in $(ps xo '%p %c' | grep ray:: | awk '{print $1;}') ; do taskset -cp $cpuid $pid ; cpuid=$(($cpuid + 1)) ; done

That should increase throughput.

I'm working on a model parallel implementation instead of tensor parallel. Using tensor parallel for models that fit inside a single GPU in my experience don't provide boost of n gpus. Whereas if you use model parallel. A simple way is to have 8 instances of vllm and have a router like litellm to route the requests between them

a model parallel implementation

That's awesome! @nivibilla  Do you have a branch already?

由于 Ray 核心固定，张量并行性有点慢。启动服务器后，运行以下命令：
cpuid=0 ; for pid in $(ps xo '%p %c' | grep ray:: | awk '{print $1;}') ; do taskset -cp $cpuid $pid ; cpuid=$(($cpuid + 1)) ; done

这应该会增加吞吐量。

What if we switch the implementation from ray to torchrun? Would that lead to better results?

a model parallel implementation

That's awesome! @nivibilla  Do you have a branch already?

I was going to, then I found this pr which is exactly what I was going to do.
https://github.com/vllm-project/vllm/pull/1230


KAFKA-5457: MemoryRecordsBuilder.hasRoomFor should account for record headers

cc @hachikuji @ijuma

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5367/
Test FAILed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5382/
Test PASSed (JDK 7 and Scala 2.11).


Meilisearch _geo consitency with with Firestore Geopoint

For _geoRadius to work, the current documentation and workings of Meilisearch requires Geopoint fields in firestore to be renamed as _geo. However, when it comes to the "lat" & "lng" field name formats. Firestore does not allow renaming of these fields. These fields are named "_latitude" & "_longitude" respectively by Firestore. I was unable to do a _geoRadius search on Meiliesearch.
Steps to reproduce the issue:

Install Meilisearch on GCP   - [long story short, it works]
Create new index and add "_geo" to "filterableAttributes" settings -  [Works]
Install Meilisearch Firestore extension. [Search queries return correct results, including "_geo" fields but with "_latitude" & "_longitude". - [Works]
Add test documents with _geo in Firestore. - [Works]
Run empty q search without filter - [Works]
Run empty q search with {"filter": "_geoRadius( , , )"} - [No results returned]

No results returned even if same value as the document are passed. I don't know if it's because Meilisearch is looking for "lat" & "lng" and can't find anything or something else. Either way, I could find any issues or documentation on this.
I also came across this issue. I'm not sure if anything has been rewritten but the documentation is not update in that case.

So there is an error in the documentation for the firestore repo. It states

If you are using GeoPoint, the field should be named _geo to be recognized by Meilisearch for geosearch.

This compeletely overlooks the fact that firestore doesn't support naming the Latitude and Longitude fields which renders using geopoint for Meilisearch useless.
The way I got this to work is to use a map on firestore with the expected format. i.e.
"_geo": {     "lat": 0.0,     "lng": "0.0"   }

Hey @baek-b
This seems to be a bug! The fields should have been adapted

I made an issue on firebase side: https://github.com/googleapis/nodejs-firestore/issues/1799#issuecomment-1325283382
I'm still looking for a work-around meanwhile, I'll keep you updated :)

After further investigation, the error comes from my side. I will be fixing this asap!


Nsmgr restarts

Expected Behavior
No restarts of Nsmgr
Current Behavior
Nsmgr has restarted
Failure Information (for bugs)

nsmgr has restarted 4 times
Steps to Reproduce

Unknown
Context
Interdomain setup with vl3

Kubernetes Version: 1.24
NSM Version: main (Nov 18th)
etc.

Failure Logs

nsgmr logs: nsmgr-fail.log

Seems like fixed by https://github.com/networkservicemesh/sdk/pull/1386


fix segfault in luv_check_handle/luv_check_stream

Fixes #633.
Is the style I used here OK? It felt kind of different than the rest of the code, the assignments in the if statements more specifically..

Thanks!

No worries, thank you for helping me out with this, still learning my way.
(Also sorry for that half-failed squash attempt on my end lol)


datepicker does not show days when date is not valid in input field

because of other bugs i did a rewrite. i rewrote it as a module. i used vanilla javascript. its here on github: https://github.com/hhvdblom/vanilla-datepicker

Thanks for sharing. When you have sometime can you share details about the bugs please.

If you put a not valid date in the datepicker field and click on it the datepicker won't show up with days. In my rewrite when a date is not valid I take the date of today and then show the datepicker.
Outlook voor Android downloadenhttps://aka.ms/ghei36

From: Sai Koneru<EMAIL_ADDRESS>Sent: Friday, May 15, 2020 11:32:42 AM
To: saikoneru/foopicker<EMAIL_ADDRESS>Cc: hhvdblom<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [saikoneru/foopicker] datepicker does not show days when date is not valid in input field (#4)
Thanks for sharing. When you have sometime can you share details about the bugs please.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/saikoneru/foopicker/issues/4#issuecomment-629135435, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH67WOFHQWCD4C22QIX4433RRUD3VANCNFSM4NAWRYSA.


internal/cpu: support darwin/arm64 CPU feature detection [freeze exception]

darwin/arm64 does not support CPUID or HWCAP CPU feature detection like other operating systems on arm64 currently supported by Go.
A new way using sysctlbyname will need to be implemented to detect if for example hw.optional.armv8_1_atomics is set to 1.
https://developer.apple.com/documentation/apple_silicon/addressing_architectural_differences_in_your_macos_code
If someone has an M1 Apple Silicon Mac please post the output of:
sysctl -a | grep "hw\.optional"

hw.optional.floatingpoint: 1
hw.optional.watchpoint: 4
hw.optional.breakpoint: 6
hw.optional.neon: 1
hw.optional.neon_hpfp: 1
hw.optional.neon_fp16: 1
hw.optional.armv8_1_atomics: 1
hw.optional.armv8_crc32: 1
hw.optional.armv8_2_fhm: 1
hw.optional.armv8_2_sha512: 1
hw.optional.armv8_2_sha3: 1
hw.optional.amx_version: 2
hw.optional.ucnormal_mem: 1
hw.optional.arm64: 1

from my MacBook Pro M1.

I'd like to request a freeze exception for this. Without hardware support, AES is not only extremely slow, but also not constant time, which is a security issue. crypto/tls will switch away from it, but not all applications can dynamically fallback, and not all peers support good alternatives.
The implementation is Go 1.16 would have to be scoped to only darwin/arm64 (not replacing the one in the other OSes), but if it is I think it would have very limited chances of affecting other targets, and darwin/arm64 will inevitably be in flux during the freeze anyway.
/cc @rsc @golang/release

Can we just set aes, pmull, sha1 and sha2 to true for the darwin/arm64 target? That seems like a low risk change for Go 1.16 and then some sort of sysctl parsing could be added for Go 1.17.

A low complexity workaround since there is only one Apple Silicion Chip (except the DTK which should be similar and testable) is that for darwin/arm64 we just hardcode the supported arm64 features in internal/cpu and @FiloSottile @cherrymui can test that this works on their Apple Silicon Macs with ./all.bash.

We have to consider that Go 1.16 will have to work correctly until 2022, and while I don't expect new Apple Silicon chips to drop such core features, we don't really know in advance. Binaries built with Go 1.16 might also stick around longer than Go 1.16 itself, and this is logic that would end up embedded in all of them.

I see these options to prevent a regressions with future darwin/arm64 CPUs if we hard code the darwin/arm64 supported CPU features:

Create a minor version of Go 1.16 that sets specific features to always false again if Apple Silicon is sold that does not support the feature.

GODEBUG=cpu.all=off will work to turn them of too. GODEBUG only refuses to turn on features that it didn't detect present.

Find a way to reliably detect that go1.16 is running on Apple Silicon M1 (may be easier than CPU feature detection) and only then enable all CPU features accordingly without individual detection.

@FiloSottile Thanks for letting us know. We've discussed this on the release team, and based on the rationale you provided and the external constraints that could not be worked around in advance, we are leaning towards this freeze exception being granted.
Please keep the release schedule in mind and re-evaluate this as needed if this cannot be resolved without causing a significant additional delay or risk for Go 1.16.

Looking further how to have runtime feature detection in darwin/arm64 we can do instead of hardcoding:

copy a version of SysctlUint32, sysctl and nametomib from the syscall package to the runtime and deduplicate with any existing parts in the runtime package:  https://github.com/golang/go/blob/846dce9d05f19a1f53465e62a304dea21b99f910/src/syscall/syscall_darwin.go#L30
https://github.com/golang/go/blob/846dce9d05f19a1f53465e62a304dea21b99f910/src/syscall/syscall_bsd.go#L494

linkname a generic sysctlbyname function into internal/cpu(similar to getsystemcfg for ppc64 on AIX)

check the features that we have for arm64 in internal/cpu with the "hw.optional" sysctls we know exist (https://github.com/golang/go/issues/42747#issuecomment-731208964)

Since we still have some hardcoded CPU features (AES) for which no hw.optional setting seems to be available are there machdep.cpu fields that identify the CPU in sysctl -a on arm64?
On amd64 Mac OS X I see:
machdep.cpu.vendor: GenuineIntel
machdep.cpu.brand_string: Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz

What is the output of sysctl machdep.cpu.features on M1?

Nothing (Mac Mini M1):
`> sysctl machdep.cpu.features

sysctl machdep.cpu
machdep.cpu.cores_per_package: 8
machdep.cpu.core_count: 8
machdep.cpu.logical_per_package: 8
machdep.cpu.thread_count: 8
machdep.cpu.brand_string: Apple processor`

@mundaym https://github.com/golang/go/issues/42747#issuecomment-731214474 :

Can we just set aes, pmull, sha1 and sha2 to true for the darwin/arm64 target? It doesn't look like they are optional. That seems like a low risk change for Go 1.16 and then some sort of sysctl parsing could be added for Go 1.17 for atomics etc.

I’ll go a step further and suggest that you can assume the presence of these instructions not just for Go 1.16 but for all time. There shouldn’t be any need for run-time detection of these features on mac-arm64. For that matter, although ios-arm64 has a lower baseline CPU than mac-arm64, these specific instructions are also guaranteed to be available on ios-arm64 as well.
In support, I offer clang and llvm, which in code contributed by Apple engineers:

use -mcpu=apple-a12 by default when targeting mac-arm64 (clang/lib/Driver/ToolChains/Arch/AArch64.cpp aarch64::getAArch64TargetCPU), and
define the features for -mcpu=apple-a12 at llvm/lib/Target/AArch64/AArch64.td ProcAppleA12.

In further support, none of the instructions under consideration (aes, pmull, sha1 or sha2) have a corresponding node in hw.optional. Detection isn’t necessary! As you’ll see from the above, cryptographic extensions (FeatureCrypto) are available on all Apple arm64 CPUs back to the very first one, AppleA7. All of these instructions fall under the ARMv8 cryptographic extension (ARM DDI 0487F.c §A.2.3). If Apple clang is happy to emit these instructions (even if only via intrinsics without issuing a warning), golang should have no qualms either.
Similarly, even for some of the hw.optional nodes that are available, it’s completely safe to assume the presence of the feature without the need for a run-time check. hw.optional.floatingpoint and hw.optional.neon both appear, but they’re never going to be absent on mac-arm64.

…and I’ll put my money where my mouth is: I assume the presence of crc32 in Chromium on mac-arm64.
The only reason I don’t assume pmull is that we don’t currently have any code that uses it, but there’s something in development that I expect to approve.
We’re also assuming ARMv8.3 as a baseline, for example via our use of fjcvtzs.
The clang/llvm references above support all of this, and in fact, if you’re using Apple clang (as opposed to open-source, which hasn’t caught up), you’ll even find the __ARM_ARCH_8_3__ macro defined.

@markmentovai I think https://go-review.googlesource.com/c/go/+/271989 that I came up with earlier aligns with your comments.  Go already assumes all arm64 support e.g. asimd and fp. The aes, pmull, sha1 or sha2 are set unconditionally to true and atomics and crc32 are set depending on the existing hw.optional value.

If this lands, similar changes should be made to x/sys/cpu as it suffers from the same issue.  Should I open a new issue for that?

I find the arguments for none of these features being optional pretty convincing, and this late in the cycle I think the smaller CL 271986 would be a safer bet. If Apple's LLVM is happy assuming those features, we're fine doing the same.

In BoringSSL (and thus crypto in Chromium), we also use static armcaps for Apple ARM64 platforms. We look at __ARM_FEATURE_CRYPTO, __ARM_NEON, etc., preprocessor defines from the C compiler and exercise NEON, AES, PMULL, SHA-1, and SHA-2. (Whatever instructions the compiler believes exist in a build are baseline by construction, since the compiler feels free to emit them.) NEON's also baseline for all of ARMv8-A, not just Apple ARM64.
My impression so far (prior to ARM macOS) was that they largely used static armcaps, dispatching with universal binaries and the app store. Now they're on another generation of aarch64 features and macOS has an ARM port, it makes sense that they'd would shift more to sysctlbyname beyond that initial baseline.
(The joys of ARM's platform-specific feature detection...)

I've edited an earlier https://github.com/golang/go/issues/42747#issuecomment-731353880 to clarify this freeze exception has been approved.

Created a separate issue for darwin/arm64 support in x/sys/cpu: #43046


go tool: no such tool "6a" for appengine project.

goapp does not have 6a.
Can I use go tool 6a with go-cmd=goapp?
$ go version
go version go1.4.2 linux/amd64

$ go tool
6a
6c
6g
6l
addr2line
cgo
cover
dist
fix
nm
objdump
pack
pprof
tour
vet
yacc

$ goapp version
go version go1.4.2 (appengine-1.9.21) linux/amd64

$ goapp tool
6g
6l
pack

hmm. not sure here, we only invoke go or the value of go-cmd.... never 6a directly.   I'll have to setup app-engine to see whats going on unless you have any ideas.

Hmm.. Now I found that I can't install ffjson with goapp
$ goapp get -u github.com/pquerna/ffjson
go tool: no such tool "6a"

thank you for the report and PR!

@ceram1 did you face this problem for btcd or btcec?
how did you fix it?

I didn't use any bitcoin projects.
Just googled it, then found a gae issue and a patch(https://github.com/btcsuite/fastsha256/pull/2)


[Azure Search ] API Review

New API Review meeting has been requested.
Service Name: Azure Search
Review Created By: Matt Gotteiner
Review Date: 01/09/2024 01:00 PM PT
Onboarding Record:
PR:
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided
Description: Early Review for Azure AI Search API Version 2024-03-01-Preview
Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

New API Review meeting has been requested.
Service Name: Azure Search
Review Created By: Matt Gotteiner
Review Date: 01/23/2024 01:00 PM PT
Onboarding Record:
PR:
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided
Description: Review for Azure AI Search API Version 2024-03-01-Preview
Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

Notes from API Review 1/9/23
This API looks good for preview. Just ping here or in the PR to let us know when it is ready to merge and we'll add the "signedOff" label on the PR.

Cancelled by: Matt Gotteiner


ovpn_genconfig -d parameter is not working

I'm using the command below to generate configurations and when I've added the "-d" parameter it doesn't work and produces an error.
I've tried added the OVPN_ROUTES+=("<IP_ADDRESS>/24") in the [ "${#OVPN_ROUTES[@]}" == "0" ] && [ "$OVPN_DEFROUTE" == "1" ] and it worked.
Question: Why did the "OVPN_ROUTES+=("<IP_ADDRESS>/24")" removed? and why it stopped working when I've removed that parameter?
Command:
ovpn_genconfig -N -D -c -e 'client-config-dir ccd' -u udp://<IP_ADDRESS>:1194 -d -C 'AES-256-GCM' -a 'SHA384' -T 'TLS-ECDHE-ECDSA-WITH-AES-256-GCM-SHA384'
Error:
Traceback (last called is first):      main() in /usr/bin/ovpn_genconfig:288 The command [ "$OVPN_DEFROUTE" == "1" ] exited with exit code 1. Cleaning up before Exit ...

Hi, thanks for your comment. The <IP_ADDRESS>/24 was a useless route added by the author of the original code as that's apparently the subnet that he used. See this issue for more info.
This route has therefore been removed from this repository as it simply served no purpose.

Thank you for your reply Lisenet.
Oh I see, but nothing changes kn the -d parameter aside from this static ip route. Do you have any idea why the -d produces an error if this route are redundant?

The -d parameter disables the default route. Since there are no other routes defined (with <IP_ADDRESS>/24 being removed), we should either remove the -d parameter from the configuration, or provide means for setting an alternative route that works with the client's subnet.

@lisenet I'm using the -d parameter to set the OVPN_DEFROUTE to 0 because by default it's 1. Without -d I wouldn't be able to set this up comfortable.

-d produces an error because there are no extra routes defined. VPN without default gateway and without any routes does nothing and makes no sense.
[ "${#OVPN_ROUTES[@]}" == "0" ] && [ "$OVPN_DEFROUTE" == "1" ] works when OVPN_ROUTES is not empty because of short circuiting.
Extra routes can be passed with -r.
Script works fine, but it should exit with a meaningful message when -d is used without -r, instead of just failing.

I agree, the script should exit with a meaningful message when -d is used without -r. I'll raise a PR.


Fix layout issues

This issue is imported from pivotal
eduID now presents more and more simple dialogs (see screenshots) but they somehow all look different. Our UX designer should come up with an example :)

(Arnout Terpstra - Mar 10, 2021)


Rewrite Get-FileHash to use static HashData methods

PR Summary

The HashData(Stream s) methods have been added in .NET 7
The static HashData methods are more optimized and preferred over the ComputeHash methods.
Still need to test if anything broke, therefore WIP
PR Context

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ ] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

Tests still pass, PR is ready.

Please resolve CodeFactor issues regarding Xml documentation headers.

@PaulHigin and @TravisEz13 please review, thanks!


Using cond! together with count! unable to infer enough type information about _

Not sure if it's a bug in my code or in the library but if I'm trying to parse something using the following reduced example:
fn parse_branch_entries(input: &[u8]) -> IResult<&[u8], Option<Vec<u64>> > {
    chain!(input,
        entries: cond!(true, count!(le_u64, 3)),
        || { entries }
    )
}

it tells me:
error[E0282]: unable to infer enough type information about `_`
   --> src/parser/mod.rs:394:5
    |
394 |     chain!(input,
    |     ^ cannot infer type for `_`
    |
    = note: type annotations or generic parameter binding required
    = note: this error originates in a macro from the standard library

this is due to type inference issues. if you isolate cond!(true, count!(le_u64, 3)) in its own function, it might get fixed.

Hi, this should be fixed in df5629e


Add '--move-out' parametet to init command

New --move-out parameter for init command to move files out of the templates folders.
EX:

Clone https://github.com/decentraland/sdk7-scene-template/archive/refs/heads/main.zip
Extract
You will now have a folder with the scene files inside (folder name doesn't matter)

If the user provides the --move-out parameter, it will move those files out of that folder, if the user doesn't provide it, it will leave the directory structure as it is.

I think this should be the default behavior. I can't think of any tool that creates a folder inside the folder I'm running the init command

that's a good point. Do we want to maintain the possibility of not moving the files out of the folder?

I think this should be the default behavior. I can't think of any tool that creates a folder inside the folder I'm running the init command

that's a good point. Do we want to maintain the possibility of not moving the files out of the folder?

What do you think about this:

dcl-command init initializes in the current folder
dcl-command init --dir xxx initializes in the xxx folder

Removing the option completely, and keeping --dir to customize the target dir. Because I think that having a sdk7-test-scene folder is a bit obscure. Where does that name comes from? Will it be consistent over time? Will it change with a different template? With the --dir thing we can simply not have these questions at all


gnulib-tests fail compiling binary-io.c

../gl/lib/time.h:656:19: error: redefinition of 'nanosleep' as different kind of symbol
_GL_FUNCDECL_SYS (nanosleep, int,
                  ^
/fultonm/zopen/prod/zoslib-zopen.20221105_183745.zos/include/time.h:36:25: note: previous definition is here
__Z_EXPORT extern int (*nanosleep)(const struct timespec*, struct timespec*);
                        ^

This appears to be the issue:
FULTONM@zopen-dev1 bash /tmp >xlclang++ nano.c /fultonm/zopen/prod/zoslib/lib/libzoslib.a
 IEW2459W 9206 INCLUDED MEMBER nanosleep FAILED TO RESOLVE REFERENCE.
 IEW2497W 9229 THE SYMBOL nanosleep WAS EXPECTED TO BE RESOLVED BY INCLUDING
          MEMBER zos.cc.o FROM THE LIBRARY DEFINED BY DDNAME /0000002
 IEW2456E 9207 SYMBOL nanosleep UNRESOLVED.  MEMBER COULD NOT BE INCLUDED FROM
          THE DESIGNATED CALL LIBRARY.

@IgorTodorovskiIBM would you expect the above to link clean ^

The problem is that zoslib is implementing nanosleep as a function pointers.  Unfortunately, the configure check does not detect it and so in some projects like findutils and coreutils, they define their own nanosleep if its not detected. Then when you end up linking, the function def clashes with the function pointer def.
I'm working on a fix for zoslib for this case

@IgorTodorovskiIBM this problem is also preventing wget from building

The latest build of zoslib should resolve this (build 293)


Required field is not being respected on image upload

I am able to submit a invite request while not uploading a image with it being set in strings.yml
      unofficial app will not be accepted—you must capture a
      screenshot from the official Android or iOS app."
    required: true
    readonly: false

Thanks, I will have a look when I get a chance.


Update kernel 4.14 series recipe to 4.14.114

Kernel 4.19.y and above was patched to rename the Raspberry Pi Zero W dts file. Unfortunately, this modification was not propagated to previous versions of the kernel, especially on the 4.14.y series which is still supported in this layer.
This modification leads to kernel 4.14.y build failure because the correct .dts file is not found.
This patch backports the mainline series patch downstream on 4.14.y series.
I am also creating a pull request on rpi-4.14.y so that this file can be deleted when the patch is accepted.
Signed-off-by: Francesco Giancane<EMAIL_ADDRESS>

Can one of the admins verify this patch?

@jenkins-ag ok to test

Thanks @fgiancane8 . Merged in master.


License choice

Currently we are using the MIT license. This license is simple and allows users to pretty much do anything they want with the code/package we produced. Do you guys think this is a good choice of license for our project, or should we explore other options?

I think the MIT license is a great choice for these reasons:

It allows you to share code without others having to show proprietary code.
It's business friendly and open source friendly.
It is very permissive, as in it lets you to keep your source code private as long as you give credit in the license file with a copyright notice.

I feel that MIT license is appropriate given the purpose with which this package has been created. Our aim was to learn collaborative software development and there is still a lot of room for improvements that can be made to the functions of this package. MIT license allows for unrestricted usage and modifications of this package and will encourage contributions from others.

Agree with team that we can stick with the MIT license


[MM-18534] Resolve fields that contradict chosen issue types

Summary
This PR resolves the following issues regarding subscription filter fields

Only show fields that are applicable to all selected issue types
If the user attempts to change the issue type after the filter field has been changed, validate that all filter fields are still applicable. IF NOT:

Don't add selected issue type to the select box
Show warning message listing the attempted issue type, the conflicting filter fields, and a suggestion to fix the fields or create a separate subscription.

In the event, a previously saved subscription was saved in a state that has conflicting fields,

Example message when a user attempts to add issue type with conflicting fields

Example messages when a previously saved subscription is loaded and contained conflicting filter fields
BEFORE

AFTER:

Ticket
https://mattermost.atlassian.net/browse/MM-18534

@jfrerich very happy to see this submitted! thank you! Since it's all JS, @cpoile can you please review it instead of me?
A general comment about our Jira plugin complex logic. 0/5 we should start thinking about our own "fields" helper library that would deal with types, etc. In golang, on the server. And then start exposing more targeted "auto-complete"-like APIs for dynamically populating the drop-downs, and move all this complexity away from JS.
The fields logic will keep popping up all over the place, we should be thinking about DRY-ing, testing, and simplifying. Go > JavaScript.

@jfrerich  Looks like once a filter is already in invalid state it won't always tell me why.

Is it possible in this case it's issue specific to filters?
Testing for this is ongoing.

Just a follow up on this @jfrerich - The issue seems to be specific to Jira Server. It is not related to filters. I can no longer create subscription at all on server even if they contain no filters. See below. I get this message for any issue type I attempt to select.

Example messages when a previously saved subscription is loaded and contained conflicting filter fields

Text is white and message is:
Error: Change type does not ...
I think we should instead match the other error case:

Text color to be red
Remove Error:  prefix

@DHaussermann Can you try the testing again?

@mickmister I see an error when I try the full make that says info lifecycle<EMAIL_ADDRESS>Failed to exec lint script among other things.
For Now I just used make distand will test this again

Currently up on
https://mm-18534.test.mattermost.cloud
sysadmin
Sys@dmin123

Example messages when a previously saved subscription is loaded and contained conflicting filter fields

Text is white and message is:
Error: Change type does not ...
I think we should instead match the other error case:

Text color to be red
Remove Error:  prefix

Addressed these changes in the latest commit.

@aaronrothschild @cpoile Do you mind giving this a review?

@jfrerich if you tab to the second field, it appears like this:

If you add a value twice and hit enter it clears the row for you:

Otherwise, errors seem good - didn't encounter much else.

If you add a value twice and hit enter it clears the row for you:

@aaronrothschild I'm starting work for this issue: MM-19791

The error text needs to be aligned.

@asaadmahmood, can you pull the latest commit?  I have fixes for those messages already committed.  You should see the message aligned, colored red, and the "Error:" prefix removed from the message.

For reference, this is the commit.
https://github.com/mattermost/mattermost-plugin-jira/pull/364/commits/9bf2d50a359a7f39dde9563a243e21a869a882ef

@jfrerich I think he's referring to your screenshot

@asaadmahmood, sorry, I thought what you were viewing was created from running with this PR's changes and didn't realize you were just referencing the screenshot.  I've updated the initial PR with a screenshot displaying the newest changes.

@mickmister @jfrerich Yup, I was looking at the screenshot.
If there are any changes made, we should update the screenshot so we don't have to download and run the changes locally, and can just easily comment on the screenshot.

@cpoile could you give this a review when you have a chance?

Any width smaller than 1200px causes the "x" close button to overlap the create subscription button:

@cpoile Interesting, that should have been fixed with https://github.com/mattermost/mattermost-plugin-jira/pull/361
cc @DHaussermann so you're aware

@mickmister Ah, I was using your test server above, so that wouldn't have been merged when you spun that up. :)

Right, I've updated that a few times but definitely not recent enough! There are tickets open for automating this process https://mattermost.atlassian.net/browse/MM-19541
https://mattermost.atlassian.net/browse/MM-19546 . Do you want me to update it again?

Thanks @cpoile!


#552 Gruntfile.js failed to load

Previously we were relying on GetEditLabel() to produce the
non-display-name. This was problematic because sometimes GetEditLabel
returns null or produces a NotImplementedException when a node cannot be
renamed. Instead, expose GetItemName, which will always return the
underlying file or directory name based on the Url.
fix #552

Note that as described in #552... I never managed to actually reproduce the underlying issue, so we can't verify the fix.