Feature Req: Detect and log IPAM-allocated pod CIDRs overlap with Cluster/Service IP's for Pods/Services

Proposal / RFE
Setup
When in Cluster Scope (the default IPAM from quickstart) Cilium makes by default a potentially conflicting IP range for pods vs Service IP's (CLUSTER-IP)
In example, for my single-node setup,
my kubelet has:
--service-cluster-ip-range=<IP_ADDRESS>/16
Cilium made for me an IPv4 CIDR of:
<IP_ADDRESS>/8
and my kubelet-api is at: <IP_ADDRESS>
I have removed the taint to allow pods to start on master.
I was previously running flannel, which I removed.
Problem
It assigns CoreDNS pods to the <IP_ADDRESS>/8 cidr and I get errors about dial tcp <IP_ADDRESS>:443: i/o timeout in the logs for CoreDNS, and generally this causes many other things to break that need CoreDNS.
Some of other pods that I launch can connect to kube API via <IP_ADDRESS>, and I can from the host.
My assumption is that this is a routing issue and the kube-api may be using a different gateway than the pod, something is broken in iptables config, or a similar issue. This is possibly also due to things that have been previously been allocated in the deleted flannel setup.
Documentation issue
The documentation around Cluster Scope is very confusing and brief.
https://docs.cilium.io/en/stable/concepts/networking/ipam/cluster-pool/#cluster-scope-default
Do I set Spec.IPAM.PodCIDRs or v2.CiliumNode? Where and how do I do that?
If it has previously started without this value will it re-assign any pods to the new CIDR or do I need to clean out old pods? (From my current experience, it seems I cannot somehow make Cillium perform an update to re-allocate pods to the new range without doing a delete)
It really needs to explain things like how does one set v2.CiliumNode or  Spec.IPAM.PodCIDRs before starting, or how does one update v2.CiliumNode on a cluster that has previously been started without this param defined.
Workaround
Without a clear way to make sure that it re-assigned anything to the new space automatically or report any conflicts, I gave up and used ipam: kubernetes -- which as a side note, the Cillium doc does not a do a good job explaining where to define this param or how.
Proposal
Fix the docs and default startup to be more careful about the inital IP range. I would imagine a /16 is probably a more appropriate default for most use cases to avoid conflicts with anything else that might need a private IP.
Cillium should detect and log when the PodCIDRs conflicts with any kubernetes/kubelet values such as:
--service-cluster-ip-range=<IP_ADDRESS>/16
--cluster-cidr=<IP_ADDRESS>/16
Cillium should also log (or attempt to fix) any allocated pods that have IP ranges that do not comply with the defined PodCIDRs

Thanks for opening the issue. Unfortunately, it's not possible to know the service-cidr since Kubernetes does not expose these values as part of its API so Cilium can't properly detect service CIDR collisions.
More information about the cluster scope can be found here https://docs.cilium.io/en/stable/gettingstarted/ipam-cluster-pool/#gsg-ipam-crd-cluster-pool

Thanks!
I am surprised about kube-api -- for anyone else's ref:
https://github.com/kubernetes/kubernetes/issues/46508
is tracking a whole IPAM API feature which should allow this to be exposed (..but was opened in 2017 so who knows when this will be actually completed). A possible workaround is checking the containers->command params in the kube-controller-manager pod, but it is kind of a string parsing hack rather than a source-of-truth.
It would be nice if there was some info or a ref on the other page:
https://docs.cilium.io/en/stable/concepts/networking/ipam/cluster-pool/#cluster-scope-default
about that, and possibly how to change/set it without helm? I didn't use helm and just followed the guide here: https://docs.cilium.io/en/stable/gettingstarted/k8s-install-default/
I tried editing CiliumNode manually and changing the podCIDRs under ipam and deleting/restarting the cilium pod (which didn't work, and now know to use the ConfigMap rather than directly editing CiliumNode)
One thing I am noticing is that in my template it is telling me is when I run:
 kubectl get cn -o yaml

I see:
    ipam:
      operator-status:
        error: node has CIDRs allocated ([xxx]) that conflict with requested
          CIDRs [xxx]

is there a way to somehow allow it to just fix this automatically by deleting/updating/remaking the pods? It keeps using the bad IP on restarts, even when it's stuck in a Error or CrashLoop state. I ended up manually deleting them which seemed to solve the issue.

@DaveWK you can change the podCIDR, defined in Cilium config map, followed by deleting the Cilium Nodes (kubectl delete cn --all), a restart of Cilium Operator (kubectl delete pod -n kube-system --label io.cilium/app=operator), a restart of Cilium agents (kubectl delete pod -n kube-system --label k8s-app=cilium in the cluster, and a deletion of all pods so they are have the new CIDR (kubectl delete pod -A --all).

Hi
helm install cilium cilium/cilium -n kube-system --set securityContext.privileged=true --set ipam.mode=cluster-pool --set ipam.operator.clusterPoolIPv4PodCIDRList=<IP_ADDRESS>/12 --set ipam.operator.clusterPoolIPv4MaskSize=12
NAME: cilium
LAST DEPLOYED: Wed Aug 31 09:06:44 2022
NAMESPACE: kube-system
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
You have successfully installed Cilium with Hubble.
Your release version is 1.12.0.
For any further help, visit https://docs.cilium.io/en/v1.12/gettinghelp
But  : the pods are still receiving addresses in <IP_ADDRESS>
coredns-5fcdd8f5c8-5878w                     1/1     Running   0               12m   <IP_ADDRESS>
inside the configmap:
cluster-pool-ipv4-cidr:
<IP_ADDRESS>/12
cluster-pool-ipv4-mask-size:
12
Of course all pods have been restarted.
Any adivces ?
Thank you

Hi
helm install cilium cilium/cilium -n kube-system --set securityContext.privileged=true --set ipam.mode=cluster-pool --set ipam.operator.clusterPoolIPv4PodCIDRList=<IP_ADDRESS>/12 --set ipam.operator.clusterPoolIPv4MaskSize=12 NAME: cilium LAST DEPLOYED: Wed Aug 31 09:06:44 2022 NAMESPACE: kube-system STATUS: deployed REVISION: 1 TEST SUITE: None NOTES: You have successfully installed Cilium with Hubble.
Your release version is 1.12.0.
For any further help, visit https://docs.cilium.io/en/v1.12/gettinghelp
But : the pods are still receiving addresses in <IP_ADDRESS> coredns-5fcdd8f5c8-5878w 1/1 Running 0 12m <IP_ADDRESS>
inside the configmap:
cluster-pool-ipv4-cidr:
<IP_ADDRESS>/12
cluster-pool-ipv4-mask-size:
12
Of course all pods have been restarted.
Any adivces ?
Thank you

After executing the above command, I run ip link delete cilium_host in each node. It's working.


[viz] Drift calculations bug fixes

Ints mapped to kstest instead of Chisquared
chisquared - erroneous dof calc due to absent unique count

Description

General Checklist

[ ] Tests added for this feature/bug
if it was a bug, test must cover it.
[ ] Conform by the style guides, by using formatter
[ ] Documentation updated
[ ] (optional) Please add a label to your PR

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 4 (75.0%)  changed or added relevant lines in 1 file are covered.
10 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.02%) to 82.631%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/whylogs/viz/utils/profile_viz_calculations.py
3
4
75.0%

Files with Coverage Reduction
New Missed Lines
%

src/whylogs/core/summaryconverters.py
1
87.9%

src/whylogs/viz/utils/profile_viz_calculations.py
9
77.78%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
4967

Relevant Lines:
5845

💛  - Coveralls


Guardian Translation

The new Guardian Lesson was just merged today (11/28/16).
PR #790 was the origin.
Translation
Translation progress:

[x] en
[x]  ru - @brain-geek has said he will take up
[ ]  ko /cc @devleoper
[ ]  jp /cc @3100
[ ]  no /cc @therobinsj
[ ]  pl /cc @Koziolek
[ ]  sk /cc @michalvalasek
[ ]  fr /cc @julienXX
[ ]  cn /cc @cizixs
[ ]  es /cc @aleandros / @jonahoffline / @eze1981
[ ]  pt /cc @pragmaticivan
[ ]  vi /cc @joneslee85
[ ]  it /cc @sformisano
[ ]  my /cc @alkaha
[ ]  id /cc @rezaprima
[ ]  gr /cc @gemantzu

#839 greek


Update tooling version to 1.3.0

Release Tasks
These tasks must be completed to release.

[x] Create and request approval of a Verification Report on Cognidox for the relevant product being released
[x] Ensure documentation requirements are met e.g., public API is commented
[x] Consider any licensing/other legal implications e.g., notices required
[x] Check that any additional release tasks from contributing PRs have been considered below
[x] Close off the JIRA release

JIRA Release
Link to the Jira release for this version. See the releases page.
https://ultrahaptics.atlassian.net/projects/TF/versions/16439/tab/release-report-all-issues

The pipeline has failed due to tag pipeline failing. I've created #395 to disable them so this does not block us in future. The branch pipeline has succeeded.


[BUG] npx code-review-gpt  configure --setupTarget=github throws error

Current Behavior:
After installing code-review-gpt through npm install I am getting an error running it no matter what version of Node I use:
$ nvm use 18
Now using node v18.17.1 (npm v9.8.1)
$ npx code-review-gpt configure --setupTarget=github
ERROR	Error: {}

$ nvm use 16
Now using node v16.20.2 (npm v8.19.4)

$ npx code-review-gpt configure --setupTarget=github
ERROR	Error: {}

Expected Behavior:
I expected for the configuration script to run
Steps To Reproduce:

nvm use 18
npm install code-review-gpt
npx code-review-gpt configure --setupTarget=github

Environment:

OS:  OS: Linux Mint 21.2 x86_64
Node: 16 or 18
npm: 8.19.4

I could try to debug it, but the error is completely unhelpful as it is

Fixed in https://github.com/mattzcarey/code-review-gpt/pull/299


Fix repository URL

Please fix other library.json.
2580	https://raw.githubusercontent.com/create-ar/create-commons-avr/23f82ba6feaf4dfaff6bcbd5b53c6fb028726357/thirdparty/dataflash/library.json	2017-11-19 02:08:58	0	0
2579	https://raw.githubusercontent.com/create-ar/create-commons-avr/a81b891ff4232d9cf4a928f0fe2e371ac82ee5b7/core-avr-io/library.json	2017-11-19 02:07:20	0	0
2578	https://raw.githubusercontent.com/create-ar/create-commons-avr/a81b891ff4232d9cf4a928f0fe2e371ac82ee5b7/core-avr-ds/library.json	2017-11-19 02:07:12	0	0
2577	https://raw.githubusercontent.com/create-ar/create-commons-avr/a81b891ff4232d9cf4a928f0fe2e371ac82ee5b7/core-avr-database/library.json	2017-11-19 02:06:55	0	0
2576	https://raw.githubusercontent.com/create-ar/create-commons-avr/a75197ee3b54d5a355680b0565420a215eb7fc71/core-avr-logging/library.json	2017-11-18 23:55:28	0	0

Thanks for the fix, all library.json have been modified. Should I resubmit the libs?


InvocationResponseTypeDef or what?

def get_response(payload: dict) -> InvocationResponseTypeDef:
    lambda_client = boto3.client("lambda")
    response = lambda_client.invoke(
        FunctionName="some-lambda", Payload=json.dumps(payload)
    )
    return response
# no issues with mypy for function above

lambda_payload = {"test" : 123}

response: InvocationResponseTypeDef = get_response(lambda_payload)
# not complains here either, but then

output = json.loads(response.get("Payload").read())
# Item "None" of "Optional[IO[bytes]]" has no attribute "read" mypy(error)

How can I make peace with mypy here?
PS: the code works anyway.

Actually, when I did:
- output = json.loads(response.get("Payload").read())
+ output = json.loads(response["Payload"].read())

It worked. Which, actually, makes sense. Closing this ticket.


task: Added an Apache 2.0 license file

Added a license file pulled from another Casbin repository.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Page 'Selected Layers' links to Document

Clicking Page > Selected Layers in the left sidebar jumps to Document > Selected Layers
I think this is because the # links are relying on unique names - whereas Selected Layers is on both Document and Page

Same with Text > adjustToFit

fixed, good catch


Login with Google Functionality

Write the backend logic for login with google functionality. I will create the frontend for the same.

ok, I will do that.

Added the SignIn with Google functionality in frontend.
SignUp page:

LogIn page:


⚠ Arch Linux Package Mirror has degraded performance

In 5d1fe9c, Arch Linux Package Mirror (https://pkg.fef.moe/archlinux/) experienced degraded performance:

HTTP code: 200
Response time: 656 ms

Resolved: Arch Linux Package Mirror performance has improved in 49e3273.


Flutter Release build directory not found

Unhandled exception:
PathNotFoundException: Cannot copy file to 'c:\users\user\flutterProject\build\windows\runner\Release\squirrel.exe', path = 'c:\users\user\appdata\local\pub\cache\git\squirrel-flutter-1612e8f1bd8eb2c9df317da0e181e0564afcff7a\vendor\squirrel.exe' (OS Error: The system cannot find the path specified.
, errno = 3)
#0      _checkForErrorResponse (dart:io/common.dart:55:9)
#1      _File.copy.<anonymous closure> (dart:io/file_impl.dart:356:7)
<asynchronous suspension>
#2      main (file:///C:/Users/user/AppData/Local/Pub/Cache/git/squirrel-flutter-1612e8f1bd8eb2c9df317da0e181e0564afcff7a/bin/installer_windows.dart:220:5)
<asynchronous suspension>

Seems like Flutter SDK changed where Windows builds go.
\build\windows\x64\runner\Release <- note the "x64"
Looks like the change should be here:
https://github.com/anaisbetts/squirrel-flutter/blob/17cd6dc7980399b30dc152110f0cb2eccea278d0/bin/installer_windows.dart#L214-L215

Ran into this myself, if anyone else is and is looking for a workaround, you can update installer_windows.dart locally to change the "path.join" line from V3ntus's comment above to be "path.join('build', 'windows', 'x64', 'runner', 'Release'))!;"


use OCI_THREADED when creating EnvHandle

This addresses #3 by using the proper constant to enable safe multithreading. Credit due to @cartazio for digging through the OCI docs to find the culprit.

Thank you for the pull request!


Snake Game

Hi @TusharKesarwani, I am a contributor in SSOC'23.
I want to add a new project in the repository.
It's a simple snake game which I'll create using JavaScript.
please assign me this task under label ssoc'23

hey I'm  Samina SSOC'23  contributor .I am interested to add a snake game in your repisitory .Kindly assign me this task for which I can assure u It will be likeable.

Game projects are not accepted


Extending the model builder with a webcam support

Hi,
I am playing with deeplearn.js, impressive work so far and it's really easy to explain some of the concepts to my son - but I am not an expert in neural networks not in HTML anymore  (and polymer and typescript are raising the bar :).
I am trying to enhance the model builder demo, have it include a webcam and then capture the webcam content and infer it.
So far, I have a const image = Array3D.fromPixels(element, 3) captured from a video element I have added to the demo (inspired by the imagenet demo). However, in the Imagenet/Squeezenet demo, there is a predictWithActivation() method that doesn't exist for the dynamic model from the model-builder folder.
I just don't know how to pass it to the GraphRunner and have it evaluated, also not sure how to extract the labels.
Any chance for some code pointers there?
Thanks

Hi @acostin1 - apologies for the delays :)
We're going to make a much more powerful model-builder in the coming months (which can take advantage of the webcam).


build: use libvoidstar.so properly

#786  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


iOS 8.4.1 - Links not opening

After the upgrade to iOS 8.4.1 links are not responding to tap in our ngCordova apps. After exploring we found the note included in the iOS 8.4.1 security release notes. We have been able to fix the issue with a library called https://github.com/ftlabs/fastclick .
Are other's seeing issues tapping  links in iOS 8.4.1 and if so is there a proper solution to this issue?
Below is a screenshot of the change in Apple's 8.4.1 release notes. Their resolution note reads: "Description: An issue existed in how synthetic clicks are generated from tap events that could cause clicks to target other pages. The issue was address through restricted click propogation."

Hmm, are you seeing this using ionic as well?

@mhartington - We are just using the ngCordova extensions directly. We are not using ionic.

Hmm, alright. Just to be sure, can you give this a try without ngcordova and just use the raw cordova api. Ngcordova shouldn't be messing with click/touch events, so I'm not sure the issue is here.

Greetings @andrewglancy!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.


Run client in background. 在后台运行客户端。

Please make sure of the following things.

[X] I have read the documentation.
[X] 我已阅读 文档。
[X] I'm sure there are no duplicate issues.
[X] 我确定没有提交和他人重复的issue。
[X] I'm sure this feature is not implemented.
[X] 我确定该功能尚未实现。
[X] I'm sure it's a reasonable and popular requirement.
[X] 我确定这个需求合理且符合大多数人需要。

Describe the feature / 需求描述
The console window does not run it background, theres a console opened while the application is open. When that window is closed, the connection is lost
控制台窗口不在后台运行，应用程序打开时会打开一个控制台。 当该窗口关闭时，连接丢失

Suggested solution / 实现思路
Ability to run in it background, silently, to be undetectable
能够在其后台运行，静默，不被察觉
Additional information / 附加说明
No response

add -ldflags="-Hwindowsgui" while compiling to remove the windows GUI. This will make the program run in the background.

Where to include it?
# Now we should build client.
# When you're using unix-like OS, you can use this.
$ mkdir ./built
$ go mod tidy
$ go mod download
$ ./scripts/build.client.sh

this is how i built the client.

inside of build.client.sh there is statements for compiling for windows just add -Hwindowsgui in the ldflags arguments

set GOOS=windows

set GOARCH=arm
go build -ldflags "-s -w -X 'Spark/client/config.COMMIT=%COMMIT%'" -o ./built/windows_arm Spark/client -Hwindowsgui
set GOARCH=386
go build -ldflags "-s -w -X 'Spark/client/config.COMMIT=%COMMIT%'" -o ./built/windows_i386 Spark/client -Hwindowsgui
set GOARCH=arm64
go build -ldflags "-s -w -X 'Spark/client/config.COMMIT=%COMMIT%'" -o ./built/windows_arm64 Spark/client -Hwindowsgui
set GOARCH=amd64
go build -ldflags "-s -w -X 'Spark/client/config.COMMIT=%COMMIT%'" -o ./built/windows_amd64 Spark/client -Hwindowsgui

does this look right?

go build -ldflags "-H windowshui -s -w -X 'Spark/client/config.COMMIT=%COMMIT%'" -o ./built/windows_arm Spark/client
Try add it like this

Any updates I tried all but in the end it just causes more errors ...


Support run as windows service

sc create etcd binPath= "C:\etcd\etcd.exe -data-dir=C:\etcd\etcd.service.data"
net start etcd
net stop etcd
sc delete etcd

Notes: Add "golang.org/x/sys/windows/svc" to vendor.

@chai2010 Can you fix the issue reported by go vet? main_windows.go:143: declaration of err shadows declaration at main_windows.go:130:
@judwhite @cloudtrends Can you please take a look?

I'm very interested in this, just wanted to give a heads up my response may be delayed due to other commitments. I will try it out locally and follow up within the week.

I have some concerns with the approach taken here. I'll leave comments on this PR but it may require enough changes where a new PR might make more sense. Thanks @chai2010 for getting this started.

@chai2010 Are you still interested in this? If you're too busy I can see it through and find another reviewer to help us out.

@judwhite sorry for this delayed comments. I do some other work these days.
Thanks for your review.

Any updates on this?

Sort of, I'm working with the authors of NSQ on a similar change. We're working out final details and I'd like to reference the work there once it's merged. The PR is old, but day jobs, and holidays. We're picking it back up and just spoke today about it. https://github.com/nsqio/nsq/pull/676

@judwhite great, thanks for the update, if there is anything I can do to help just let me know

This landed in https://github.com/nsqio/nsq/pull/718
@chai2010 @xiang90 @hminaya what do you think of this approach?

@judwhite shounds good to me.

Closing due to inactivity. Please create a new one if needed.


support impersonation

set these headers from reading kubectl config or from user-passed config:
  "Impersonate-User": "<as>",
  "Impersonate-Group": "<as-groups.join>",
  "Impersonate-Extra-Reason": "<as-user-extra.reason.join>"

as-groups and as-user-extra.reason being arrays
did that locally and it works, it's just clumsy so having the config parser automatically do that and the auth_options support it would be nice
I can make a PR if this sounds sane :)

First time I'm hearing about it, so don't have much to say.  Go ahead :)
ref: https://kubernetes.io/docs/reference/access-authn-authz/authentication/#user-impersonation
Is there documentation on where it lives in kubeconfig?  All I see in that doc are kubectl has --as and --as-group flags.

Should be closed by #600


Allow Storage File#update to set storage_class

Currently, File#update does not allow storage_class to be set, since it would require a separate call to objects.rewrite after the call to objects.put. Is it possible to make all the other changes to the file using only a single call to objects.rewrite?

Sure, afaik you can change everything with rewrite.


fix(Suspense):switch suspense cause error in the Keepalive (fix: #6416)

Fixes #6416
I wrote a test case to replicate the bug in Suspense.spec.ts。
This bug occurs for two reasons

One is pendingId , pendingId controls whether to render pendingBranch or not .so we need to reduce pendingId sometimes.
In Function setActiveBranch, sometimes,branch.el is null,it overlay suspense.vnode.el, cause suspense.vnode.el missing.Finally,it will cause parent misiing in Function parentNode

function setActiveBranch(suspense: SuspenseBoundary, branch: VNode) {
  suspense.activeBranch = branch
  const { vnode, parentComponent } = suspense
  const el = (vnode.el = branch.el) //sometime,branch.el is null
  if (parentComponent && parentComponent.subTree === vnode) {
  //...
  }
}

this seems not to fix #6463. see demo with your deploy preview

this seems not to fix #6463. see demo with your deploy preview

yes...I misunderstood the difference between #6416 and #6463,seem my pr only fix #6416,
Here's a demo of the fix: https://www.bilibili.com/video/BV1Cd4y1R7bU/

Hello, any progress with this PR? Need any help?

Hello, any progress with this PR? Need any help?

Thank you for your kindness!, but this PR  should be suspended first  as the reason for this bug is complex，I think it needs further study。

I try to fix #6416 , see https://github.com/vuejs/core/pull/6946


⚠ Turnos 24x7 has degraded performance

In 91e54e4, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 3618 ms

Resolved: Turnos 24x7 performance has improved in eac19c7.


Classifier guidance or classifer-free guidance?

Hi, thanks for your great work!
Recently I have been working on the conditional generation of diffusion models, and I found that it has classifier guidance and classifier-free guidance. For the former, a classifier needs to be pre-trained. But I didn't find this pre-trained classifier in your code. I am a little confused if you are using the classifier-free guidance.

We do not need a pre-trained classifier. You can read this paper "Classifier-Free Diffusion Guidance". We can adjust the influence of guidance by using the "w" parameter in the MainCondition.py.

Thanks @zoubohao for your answer! My doubts have been completely solved.


Scale of Interface

Please add hotkeys for scale, like other Electron-apps: [CTRL] + [+] & [CTRL] + [-].

posted to canny for prioritization, feel free to upvote! https://expo.canny.io/feature-requests/p/scale-interface-in-xde


feat: move grid generator to input section #559

Fixes Issue
**My PR closes #559 **
👨💻 Changes proposed(What did you do ?)
Moved grid generator to input section
✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title and description of the PR is clear and explains the approach.

Note to reviewers

📷 Screenshots

@aaananas this PR is incomplete, according to the Issue, it involved 2 tasks, moving the grid generator and fixing whatever bug occurs because of that movement.
You completed the act of moving the code for the grid generator, but the bug that occurred wasn't fixed.
The grid generator can no longer be accessed:

Looks like this PR isn't your priority anymore, will be closing it. Thanks for trying to contribute


Caesar Cipher in C++

Solved issue #573
In Language- (C++)

[x] Updated README Link
[x] Added code with comments

Thanks for contributing!

Please resolve assigned issues only

Closing due to inactivity


parse_exception: Cannot parse 'aggregate_id:-RANDOM_ID'

hi,
I'm using elasticsearch 7.6.2 and the latest helm chart https://github.com/helm/charts/tree/master/stable/elastalert to install elastalert.
Elasticsearch is not able to parse the aggregate_id through query_string as the beginning character - is not escaped.
Logs in elastalert_status_error:
Error fetching aggregated matches: RequestError(400, 'search_phase_execution_exception', 'Failed to parse query [aggregate_id:-XbKQHIBL3eSjy4_HUXS]')
--------------------------------------------------------------
Error fetching aggregated matches: RequestError(400, 'search_phase_execution_exception', 'parse_exception: Encountered " "-" "- "" at line 1, column 13.\nWas expecting one of:\n    <BAREOPER> ...\n    "(" ...\n    "*" ...\n    <QUOTED> ...\n    <TERM> ...\n    <PREFIXTERM> ...\n    <WILDTERM> ...\n    <REGEXPTERM> ...\n    "[" ...\n    "{" ...\n    <NUMBER> ...\n    ')
--

Here's the query captured in elasticsearch from slow query logs:
"query\":{\"query_string\":{\"query\":\"aggregate_id:-XbKQHIBL3eSjy4_HUXS\",

Other related issues:

https://github.com/Yelp/elastalert/issues/1656
https://github.com/Yelp/elastalert/issues/284

This is a huge blocker for us and all the aggregations are not working now, please tell us how to fix this.

Thank you

I can make a PR, but I don't have permissions, all I need to do is put %s in double quotes here - https://github.com/Yelp/elastalert/blob/master/elastalert/elastalert.py#L1725

closing this out in favor of https://github.com/jertel/elastalert2


Image Maind never works not a clue why

Version Number
1.1.1
What branch are you on?
master
Describe the Bug
I get this error everytime but I have no clue how to fix it.
"| Scanning Metadata Directory For Bloat Images: A:\Plex Media Server\Metadata                        |
| Scanning Metadata for Bloat Images: 124052 directories [01:54, 1084.08 directories/s]
| 898 Bloat Images Found                                                                             |
| Runtime: 0:01:54                                                                                |
|                                                                                |
| Moving Bloat Images                                                                                |
| Moving Bloat Images:   0%|                                                               | 0/898 [00:00<?, ? moved/s]
| MOVE: A:\Plex Media Server\Metadata\Albums\0\116ad21db52e5956b0fccab9eaff10b66e5dce4.bundle\Uploads\posters\31631312b943f6f6ee3afd85d92fd7587e2d1ca7 --> A:\Plex Media Server\PIC Restore\Albums\0\116ad21db52e5956b0fccab9eaff10b66e5dce4.bundle\Uploads\posters\31631312b943f6f6ee3afd85d92fd7587e2d1ca7.jpg |
| Traceback (most recent call last):                                                                 |
|   File "A:\PlexBackend\ImageMaid\plex_image_cleanup.py", line 321, in run_plex_image_cleanup       |
|     util.move_path(path, meta_dir, restore_dir, suffix=".jpg")                                     |
|   File "C:\Users\Paul\AppData\Local\Programs\Python\Python312\Lib\site-packages\pmmutils\util.py", line 60, in move_path |
|     final_path.parent.mkdir(exist_ok=True)                                                         |
|   File "C:\Users\Paul\AppData\Local\Programs\Python\Python312\Lib\pathlib.py", line 1311, in mkdir |
|     os.mkdir(self, mode)                                                                           |
| FileNotFoundError: [WinError 3] The system cannot find the path specified: 'A:\\Plex Media Server\\PIC Restore\\Albums\\0\\116ad21db52e5956b0fccab9eaff10b66e5dce4.bundle\\Uploads\\posters' |
|                                                                                |
| [WinError 3] The system cannot find the path specified: 'A:\\Plex Media Server\\PIC Restore\\Albums\\0\\116ad21db52e5956b0fccab9eaff10b66e5dce4.bundle\\Uploads\\posters' |"

Logs
No response

Hi can anyone help with this?


Start using pydocstyle for Python doc generation

This adds the ability to use pydocstyle for both Python 2 and 3 docstring extraction. Still a Work in Progress.

I pushed up some light fixes to the this PR, but didn't address any of the large issues I see with this.
I opened #80, #81, #82, #83 to address problems introduced here. I'd prefer to merge and start working through some of these issues, as this has been static for a while now.


Test old branch

Type
Enhancement, Bug fix

Description

Added a new test file Security3030Test.java for testing security-related functionality.
Made enhancements and bug fixes in DirectoryBrowserSupport.java, including the addition of a new static boolean ALLOW_TMP_DISPLAY and a corresponding pattern TMPDIR_PATTERN, a new method hasTmpDir to check if a file is a temporary directory, and updates to several methods to use getOpenOptions instead of getNoFollowLinks.
Updated serveFile method in DirectoryBrowserSupport.java to check if a file is a temporary directory and send an error response if it is.

Changes walkthrough
Relevant filesTests

Security3030Test.javaAddition of new security tests

test/src/test/java/jenkins/security/Security3030Test.java

A new test file Security3030Test.java was added. This file contains   tests for security-related functionality.

+330/-0

Enhancement

DirectoryBrowserSupport.javaEnhancements and bug fixes in DirectoryBrowserSupport

core/src/main/java/hudson/model/DirectoryBrowserSupport.java

Added new static boolean ALLOW_TMP_DISPLAY and a corresponding   pattern TMPDIR_PATTERN. - Added a new method hasTmpDir to check if a file is a temporary   directory. - Updated several methods to use getOpenOptions instead of  getNoFollowLinks. - Updated serveFile method to check if a file is a temporary directory   and send an error response if it is.

+37/-12

 ✨ Usage guide:
Overview:
The describe tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.
When commenting, to edit configurations related to the describe tool (pr_description section), use the following template:
/describe --pr_description.some_config1=... --pr_description.some_config2=...

With a configuration file, use the following template:
[pr_description]
some_config1=...
some_config2=...

  Enabling\disabling automation

When you first install the app, the default mode for the describe tool is:

pr_commands = ["/describe --pr_description.add_original_user_description=true"
                         "--pr_description.keep_original_user_title=true", ...]

meaning the describe tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description.

Markers are an alternative way to control the generated description, to give maximal control to the user. If you set:

pr_commands = ["/describe --pr_description.use_description_markers=true", ...]

the tool will replace every marker of the form pr_agent:marker_name in the PR description with the relevant content, where marker_name is one of the following:

type: the PR type.
summary: the PR summary.
walkthrough: the PR walkthrough.

Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.

  Custom labels
The default labels of the describe tool are quite generic: [Bug fix, Tests, Enhancement, Documentation, Other].
If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:

Main topic:performance - pr_agent:The main topic of this PR is performance
New endpoint - pr_agent:A new endpoint was added in this PR
SQL query - pr_agent:A new SQL query was added in this PR
Dockerfile changes - pr_agent:The PR contains changes in the Dockerfile
...

The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.

  Inline File Walkthrough 💎
For enhanced user experience, the describe tool can add file summaries directly to the "Files changed" tab in the PR page.
This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs).
To enable inline file summary, set pr_description.inline_file_summary in the configuration file, possible values are:

'table': File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab.
true: A collapsable file comment with changes title and a changes summary for each file in the PR.
false (default): File changes walkthrough will be added only to the "Conversation" tab.

  Utilizing extra instructions
The describe tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description.
Examples for extra instructions:
[pr_description]
extra_instructions="""
- The PR title should be in the format: '<PR type>: <title>'
- The title should be short and concise (up to 10 words)
- ...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the describe usage page for a comprehensive guide on using this tool.

/review

/describe

/analyze


Use make depend to reduce inclusions

Hi!
Some stuff changed in the build process for OpenSSL between 1.0.1l and 1.0.2u where, after ./Configure, a configuration that the OpenSSL devs consider "non-standard" needs to run make depend. This allows us to keep a smaller libcrypto.a with 1.0.2 too.
The only thing that really needs to be removed is the no-rc4 because that no longer exists in that form in 1.0.2, everything else can just stay disabled as long as we run make depend.
Should be cleanly mergeable onto your dogecoin#2555 branch

@patricklodder, ok that sounds good, I’ll merge it over. Thanks!


Non-uniform interpolation

I'm opening this issue based on this discussion. I've looked at your source code relatively thoroughly, and I think I understand how it works, even though it's a bit more meta than I'm used to.
Am I correct in assuming that non-uniform interpolation is best represented as a new subtype of GridRepresentation, for example with knot vector as argument to the constructor?
If so, I'd like to start working on that, beginning with constants and working my way up.

Thanks for your work on this package - I'm excited for the non-uniform interpolation to be available! I'm new to GitHub, is this the proper place for a comment like this, or is there somewhere more appropriate for expressing interest in features like the package you're working on here?
Best,
Nate

Here is fine. Unfortunately I had to start working on something rather different the last couple of months, so I haven't been able to dedicate time to this. :-(

I don't know if this is of any help but Fornberg [1] provides an algorithm for approximating derivatives (of any order) of a function given on a non-uniform 1d mesh.  In particular, it can be used to compute a value of a function (which is the zeroth-order derivative) at any given point (so not only at a mesh point).  The algorithm is pretty simple to implement and understand/modify, although I don't know if his approach can be generalized to tensor product grids.
[1] http://www.jstor.org/stable/2653239

@pwl Thanks, that's a good reference. I don't have access to the article atm (the full article isn't available for free) but I can probably get access through my university. I will probably focus my efforts on getting the B-spline functionality (see #5) working, and stabilize the API (see #31), but I'll keep this in mind for the future if no-one else gets there before me :)

I'm wondering if this can be considered solved in terms of Gridded (#56)...


opt infer result column name in select outfile stmt

Proposed changes
Infer name if it is an expression and doesn't alias artificially when select outfile stmt in nereids.
The infer name strategy is the same as https://github.com/apache/doris/pull/24990
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall


NIFI-7584-rebase-squash Added a POST request to the OIDC revoke endpo…

…int for logout.
Added method to validate the OIDC Access Token for the revoke endpoint.
Created a new callback URI of oidc/logoutCallback to handle certain OIDC logout cases.
Changed method to exchange the Authorization Code for a Login Authentication Token.
Added a new method to exchange the AuthN Code for an Access Token.
Changed method to convert OIDC Token to a Login AuthN Token instead of a NiFi JWT.
NIFI-7584-rebase-squash Changed the validateAccessToken method to take an AccessTokenHash object as a parameter.
NIFI-7584-rebase-squash Changed static messages to be constant variables in AccessResource.
NIFI-7584-rebase-squash Added a check to determine which OIDC logout method to use
based on the configured OIDC discovery url in nifi.properties.
NIFI-7584-rebase-squash Separated the logout endpoints for different ID Providers.
Added a new method to exchange an AuthN Code for an ID Token.
Separated the authorization and authentication for OIDC client requests.
NIFI-7584-rebase-squash Cleaned up the code.
NIFI-7584-rebase-squash Added tests to StandardOidcProviderGroovyTest.
Extracted the Access Token validation method.
NIFI-7584-rebase-squash Created new OidcServiceGroovyTest class.
NIFI-7584-rebase-squash Fixed and added tests.
NIFI-7584-rebase-squash Added tests.
NIFI-7584-rebase-squash Cleaned up code and removed comments.
NIFI-7584-rebase-squash Fixed issue of a HTTP request not closing the connection.
NIFI-7584-rebase-squash Added Exceptions to methods.
NIFI-7584-rebase-squash [WIP] Added tests in OidcServiceTest.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically main)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[x] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Still need to add one more unit test, but the rest of the changes may be reviewed in the mean time. Thanks. @alopresto @thenatog @bbende @mcgilman

Opened a new PR #4593. Closing this PR.


Shader precision optimizations

WIP

final naming of the macros to be decided
visual results so far:

Before:

After:

I confirm I have signed the Contributor License Agreement.

Wouldn't it be easier to use default precision qualifiers at the top of the shader, and then only explicitly override the default where something breaks?

Using default precision was the approach taken in the initial investigation: https://github.com/playcanvas/engine/issues/2596 - however, after discussion in the graphics sync it was agreed (I think) that it would be better to opt-in shader chunks - as it was felt that some precision problems will only be visible after extensive testing and there was a danger of things slipping through if applied globally.

I think I missed that discussion. If it was me, I would make use of the default qualifiers and then fix specific vars as required. Kinda like we do for GPU skinning precision.
Keeps the code cleaner, leaner, more readable and more maintainable. I literally don't think I've seen any GLSL in my life that specifies a precision for every single possible thing.

Yes we discussed this and decided it would be easier to leave fragment shaders on the default high precision, and locally drop parts of the code that we know does not need it to medium precision. Going the other way would created a lot more issues that would be hard to solve. This way we have better control over it and can progressively optimize other chunks as needed.

In a way this is similar to the way HLSL handles this .. they expose float and half types (including float2, 3, 4 and half2, 3, 4) .. So this is the define we discussed as possible option today - that would keep the code clean, we'd just #define half mediump float and similar

looking at PR .. I'd suggest we change line
MMEDP vec2 uv = $UV;
to
half2 uv = $UV;

Agree @mvaligursky, that would clean the code up nicely. Though we might have to be careful that the expanded expression 'mediump float' does not cause unexpected errors.

The defines currently used in this WIP draft PR are definitely temporary - the grouping is to help me debug and test - I kinda mentioned in the graphics sync I was leaning towards hfloat hvec2 - but half and half2 is also a possibility - though less consistent with GLSL? We could also consider aliasing vec2 for float2 if we wanted to go full on HLSL?

And @slimbuck is right - precision qualifiers can only be used in certain situations - which makes things less straight forward...

yes .. when I add some shader code here, I always do float4 instead of vec4 .. and then fix it. So I'm definitely keen on hlsl styling :)
so I guess there's code like this to handle:
half2 uv = half2(data.x, 0.0);
I assume the right hand side cannot use precision qualifier? So we use just vec2 there?
Are you aware of some other expctions @raytranuk ? or do we use half when declaring variables, and vec the rest of the time?


Make it possible to specify the path/name of defaults.edn

The current server load-config function described http://book.fulcrologic.com/fulcro3/#_configuration_support_on_the_server_serverconfig and in ns com.fulcrologic.fulcro.server.config uses "config/defaults.edn" for defaults:

Make it possible (optional) to override that name: (load-config {:defaults "config/my-defaults.edn" :config-path "config/dev.edn"})
Run the tests and make sure none are broken (in config_spec)...You can run the tests in the IDE, or use make dev at CLI to have a watcher run them all.
Add tests to verify that the override works.

Make sure you understand how it is supposed to work, so that the test verifies that the new default is used as the base of configuration, and that the overlay config (the :config-path option) will both see and be able to override values from the default.

So, I've studied the file and am working my way through the changes as it relates to the tests. For reference, here's the PR #41  that's the WIP for the intended changes.

Fixed.


Country API is down, so flags are not available at the moment!

Describe the bug
Just followed guidance for this repo in GitHub and running latest build of HA, HACS and formulaone-card.
When creating the card I am getting the error "Country API is down, so flags are not available at the moment!" and not displaying most of the information that is shown in the examples on GitHub (i.e Track maps, next race info and times etc.).
To Reproduce
Not too sure if this is a temporary API issue or if I have missed something along the way.
Screenshots
Screenshot of dash below.

Additional context
Not running an overly complex HA setup so not a lot in the way that could conflict, I have carefully gone back through the guidance for this card and pretty sure I have not missed anything, used the YAML config method but have also tried manual to rule that out too. (removed any changes made during the manual setup).
Any help will be greatly appreciated.

Check if you can reach  'https://restcountries.com/v2 if that doesn't work you got a network issue

Thank you for the quick response, yeah it looks like that site is down? Just tried from another device not connected to my network and get the same error.

Hmm than you will have to wait unfortunately


Document card serialization/deserialization

flowchart TB

    A[Card Instance] --> |serializeCard| B[LooseSingleCardDocument]
    B --> C
    E[LooseCardResource] -->|createFromSerialized| A
    C[JSON Storage on Realm Server] --> E

    style A fill:#58D68D
    style B fill:#3498DB
    style C fill:#F5B041
    style E fill:#3498DB

Does something like this make sense to help user visualise? I tried to tinker with mermaid but its kinda hard to enforce the position well

flowchart TB

    A[Card Instance] --> |serializeCard| B[LooseSingleCardDocument]
    B --> C
    E[LooseCardResource] -->|createFromSerialized| A
    C[JSON Storage on Realm Server] --> E

    style A fill:#58D68D
    style B fill:#3498DB
    style C fill:#F5B041
    style E fill:#3498DB

Does something like this make sense to help user visualise? I tried to tinker with mermaid but its kinda hard to enforce the position of nodes

Nice diagram, I'll include it. Thanks!


handling UnboundLocalError  when load_data is called with wrong input

When the data() is called with wrong name of the file, it returns:
---------------------------------------------------------------------------
UnboundLocalError                         Traceback (most recent call last)
<ipython-input-6-0b5f7a9527f0> in <module>()
----> 1 df = data('news_and_media')
      2 df.head()
      3 train([6,306],'adult',df)

/Users/mikko/dev/titanic/lib/python2.7/site-packages/autonomio/commands.pyc in data(name, mode)
     96     '''
     97
---> 98         out = load_data(name,mode)
     99
    100         return out

/Users/mikko/dev/titanic/lib/python2.7/site-packages/autonomio/load_data.pyc in load_data(name, mode)
     21             out = pd.read_msgpack(data_path+'random_tweets')
     22
---> 23         return out
     24
     25     elif mode == 'file':

UnboundLocalError: local variable 'out' referenced before assignment

Let's have an error message that says what's wrong, and handle the error with the exception so it terminates but no python error message.

I've fixed this. Will be in the autonomio/dev later this weekend. Closing.


Enable zoom

Ability to enable/disable zoom would be really nice

Like here https://github.com/SmartToolFactory/Compose-Zoom

@T8RIN
Thank you for your suggestion. I agree that the enable/disable feature is useful. I will consider adding this feature.

Thanks :)

I added zoomEnabled parameter.
The library you introduced had an implementation that asked enable/disable every time PointerInput occurred, but I decided that it was too much for Zoomable, so I made a simple implementation.

Okay, what's about another commits?👀


Dehydrate and certs not found

Hi!
First off, fantastic work!
I tried running the pod on openshift origin 1.3 and directly ran into a problem.
The dehydrate script hadn't been downloaded when creating the docker image but after changing the commit hash to the one of the latest commit, building the image and pushing it to our own repo on dockerhub everything seemed fine.
But then common.sh couldn't find the certs in
keyfile() {
    echo "$LETSENCRYPT_DATADIR/$1/key"
}

certfile() {
    echo "$LETSENCRYPT_DATADIR/$1/crt"
}

fullchainfile() {
    echo "$LETSENCRYPT_DATADIR/$1/fullchain"
}

Had to change to:

keyfile() {
    echo "$LETSENCRYPT_DATADIR/$1/privkey.pem"
}

certfile() {
    echo "$LETSENCRYPT_DATADIR/$1/cert.pem"
}

fullchainfile() {
    echo "$LETSENCRYPT_DATADIR/$1/fullchain.pem"
}

Do you think the change of dehydrated commit hash was the cause of pem files not found? Are they supposed to be copied to e.g. $LETSENCRYPT_DATADIR/$1/crt after retrieving them with dehydrate?
I have created new routes after the change and everything seems to work just fine.

The certificates' names really should be as above. The dehydrated given names will not persist a container redeployment! There is a bug right now you might have been run into: sometimes, it will not generate the secrets in dehydrated-hook. I'll have to get to investigate that!
Regarding the dehydrated commit hash, I am sure that worked before, because I have been continuously building the container... Maybe the dehydrated repo has been force-pushed. I don't know. I will update to the latest dehydrated later today.

Ok, cool!
I totally missed your update to this issue as github notifications went to my spam folder :/
Yeah you are right, the secret is not created. Have you made any progress on that or do you have a workaround?

The dehydrate release now used gives me a "challenge is invalid".
After changing it to a later commit hash and building own images it works.
But as expected, no secret is created.
This is from the log file after the challenge succeded.
+ . /usr/share/letsencrypt-container/common.sh
++ export LETSENCRYPT_SERVICE_NAME=letsencrypt
++ LETSENCRYPT_SERVICE_NAME=letsencrypt
++ export LETSENCRYPT_ACME_SECRET_NAME=letsencrypt-creds
++ LETSENCRYPT_ACME_SECRET_NAME=letsencrypt-creds
++ export LETSENCRYPT_DEFAULT_INSECURE_EDGE_TERMINATION_POLICY=Redirect
++ LETSENCRYPT_DEFAULT_INSECURE_EDGE_TERMINATION_POLICY=Redirect
++ export LETSENCRYPT_ROUTE_SELECTOR=butter.sh/letsencrypt-managed=yes
++ LETSENCRYPT_ROUTE_SELECTOR=butter.sh/letsencrypt-managed=yes
++ export LETSENCRYPT_KEYTYPE=rsa
++ LETSENCRYPT_KEYTYPE=rsa
++ export LETSENCRYPT_RENEW_BEFORE_DAYS=14
++ LETSENCRYPT_RENEW_BEFORE_DAYS=14
++ export LETSENCRYPT_VERBOSE=yes
++ LETSENCRYPT_VERBOSE=yes
++ export LETSENCRYPT_CA=https://acme-v01.api.letsencrypt.org/directory
++ LETSENCRYPT_CA=https://acme-v01.api.letsencrypt.org/directory
++ export LETSENCRYPT_KEYTYPE=rsa
++ LETSENCRYPT_KEYTYPE=rsa
++ export LETSENCRYPT_KEYSIZE=4096
++ LETSENCRYPT_KEYSIZE=4096
++ PATH=/usr/libexec/letsencrypt-container:/usr/libexec/letsencrypt-container:/usr/libexec/letsencrypt-container:/usr/libexec/letsencrypt-container:/opt/app-root/src/bin:/opt/app-root/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
++ OPENSHIFT_API_HOST=openshift.default
++ SA_TOKEN=<REMOVED>
++ OWN_NAMESPACE=andre
++ CA_CRT_FILE=/run/secrets/kubernetes.io/serviceaccount/ca.crt
+ HANDLER=deploy_cert
+ shift
+ deploy_cert nodejs-mongodb-example-andre.test.castleb.se /var/lib/letsencrypt-container/nodejs-mongodb-example-andre.test.castleb.se/privkey.pem /var/lib/letsencrypt-container/nodejs-mongodb-example-andre.test.castleb.se/cert.pem /var/lib/letsencrypt-container/nodejs-mongodb-example-andre.test.castleb.se/fullchain.pem /var/lib/letsencrypt-container/nodejs-mongodb-example-andre.test.castleb.se/chain.pem<PHONE_NUMBER>
+ local DOMAIN=nodejs-mongodb-example-andre.test.castleb.se KEYFILE=/var/lib/letsencrypt-container/nodejs-mongodb-example-andre.test.castleb.se/privkey.pem CERTFILE=/var/lib/letsencrypt-container/nodejs-mongodb-example-andre.test.castleb.se/cert.pem
+ local FULLCHAINFILE=/var/lib/letsencrypt-container/nodejs-mongodb-example-andre.test.castleb.se/fullchain.pem CHAINFILE=/var/lib/letsencrypt-container/nodejs-mongodb-example-andre.test.castleb.se/chain.pem TIMESTAMP=1477380723
+ log 'Create new certificate secret.'
+ is_true yes
+ case "$1" in
+ true
+ echo 'Create new certificate secret.'
Create new certificate secret.
+ new_cert_secret nodejs-mongodb-example-andre.test.castleb.se /var/lib/letsencrypt-container/nodejs-mongodb-example-andre.test.castleb.se/privkey.pem /var/lib/letsencrypt-container/nodejs-mongodb-example-andre.test.castleb.se/cert.pem /var/lib/letsencrypt-container/nodejs-mongodb-example-andre.test.castleb.se/fullchain.pem
+ local domainname=nodejs-mongodb-example-andre.test.castleb.se keyfile_=/var/lib/letsencrypt-container/nodejs-mongodb-example-andre.test.castleb.se/privkey.pem crtfile_=/var/lib/letsencrypt-container/nodejs-mongodb-example-andre.test.castleb.se/cert.pem fullchainfile_=/var/lib/letsencrypt-container/nodejs-mongodb-example-andre.test.castleb.se/fullchain.pem
+ local secret_name
++ random_chars
++ local count=5
++ tr -dc a-z0-9
++ head -c 5
+ secret_name=letsencrypt-nodejs-mongodb-example-andre.test.castleb.se-3sjtz
Error opening Certificate /var/lib/letsencrypt-container/nodejs-mongodb-example-andre.test.castleb.se/crt
140653504853920:error:02001002:system library:fopen:No such file or directory:bss_file.c:398:fopen('/var/lib/letsencrypt-container/nodejs-mongodb-example-andre.test.castleb.se/crt','r')
140653504853920:error:20074002:BIO routines:FILE_CTRL:system lib:bss_file.c:400:
unable to load certificate
/usr/share/letsencrypt-container/common.sh: line 219: /var/lib/letsencrypt-container/nodejs-mongodb-example-andre.test.castleb.se/key: No such file or directory
/usr/share/letsencrypt-container/common.sh: line 219: /var/lib/letsencrypt-container/nodejs-mongodb-example-andre.test.castleb.se/fullchain: No such file or directory

This should really use https://github.com/diafygi/acme-tiny instead of dehydrated. We are only using one thing not provided with acme-tiny anyway. I'll have a look at it tomorrow or later that week.

I could not get to the bottom of not being able to create the secrets (sometimes), so I made the container store secrets only in the routes. Care to give it a try? I could not reliably reproduce the issue, so please report any failure (as separate bug). Thanks!

Cool! I'll give it a try.


Search functionality breaks when round brackets "()" are used in the link name

I am using round brackets ( ) in the link name, i.e. - The Link (example).
The following line grabs everything from the round bracket and generates an array of links from index.md page, at that time it also collects substrings from the link name, when round brackets are used in the title.
preg_match_all('/\(([^)]+)\)/', $this->files->get($path), $matches);
When search functionality gets called, clicking on the search icon, it comes down to the following line:
explode("{{version}}", $page)[1];
at that point it breaks, because the above-mentioned regex in the getPages() has already collected  example from the link name and explode cannot find {{version}}
Regex needs to be modified to ignore everything between [ ] which would be link name in the index.md

Thanks @parthjani7 for submitting this. WIP


The best seed for all item is 0xFFFFFFFE

0xFFFFFFFE or -2 (signed int32)
I saw this in a CE table. It works for all item.

But you can't assign that seed with TQVault, how are you supposed to do it?

Unless the expansions changed the item generation code, internally the seed is limited to 15 bits (0x7fff) and TQVault followed that limitation.


Add wikipedia as a DataType

Description
This PR includes changes to add wikipedia as a DataType by using wikipedia PyPI package
Fixes #212
Type of change

[x] New feature (non-breaking change which adds functionality)
[x] Documentation update

How Has This Been Tested?
It has been tested locally
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

Maintainer Checklist

[ ] closes #xxxx (Replace xxxx with the GitHub issue number)
[ ] Made sure Checks passed

Thanks for putting this up. From a quick glance, the support for auto-inferring the Wikipedia datatypes also needs to be added in https://github.com/embedchain/embedchain/blob/d0956a0dc1952126398a48fd4647d81eb56de5ed/embedchain/utils.py#L118

Can you resolve the merge conflict and deal with the requested changes please? Let me know if you want us to take over. thanks.

@ianupamsingh can you please resolve the conflicts so that we can merge this PR?

@ianupamsingh Can you please resolve the merge conflicts so we can merge this PR?

Thanks for your contribution @ianupamsingh . This is a great one.
Will have to close this as it has become stale and wikipedia can be handled by using web_page as the data type.


Server side 'only' component shows error in development mode

Version
v2.8.1
Steps to reproduce
<template>

      normal client can not see this
      but BOTs can

</template>

What is expected ?
show nothing to normal clients. but Bots (which do not perform javascript activity) can read this component.
What is actually happening?
Warn in client-side browser
"[Vue warn]: The client-side rendered virtual DOM tree is not matching server-rendered content. This is likely caused by incorrect HTML markup, for example nesting block-level elements inside ,or missing . Bailing hydration and performing full client-side render."
and ignore them would cause an infinite refresh
Additional comments?
It is for Search Engine Optimization.
server renders this component, so the bots can read the contents, but normal javascript enabled clients can not see this component.
it works fine in production mode. however, in development mode, it ruins everything.

This bug report is available on Nuxt community (#c9580)

Well, this is a bit more complicated than just checking for process.server/process.client
You'd need some counter part to the ClientOnly or NoSSr component.
PS: Showing content only for bots seems like a trick to deceive search engine crawlers and could be penalized by Google and co.


feat: 🎸 Load local file or folder using native dialog

Included items

Created specialized dropzone elements to take care of loading local
file/folder using native dialog

This is a short term solution which creates specific anchors (on same page DOM) to open two different dialogs
Long Term Solution
It would consist on refactoring  DicomUploader.js  and DicomFileUploaderModal.js to implement the solution of loading file/folder from network/local.
Short term solution was chosen because it has a better user experience considering current scenario and there is no other panel to decide between file/folder.
Closes: 847

@ladeirarodolfo if I'm more than ~24 hours behind on a code review, you're more than welcome to @mention me.

SPA routing now works for netlify deploy previews: https://deploy-preview-870--ohif.netlify.com/pwa/local

@ladeirarodolfo well done! 👏


Open Cabinet

Hey folks,
I would like to spawn a few cabinets in the igibson scenes. The cabinets should contain a few other objects which the agent has to find. For that I would like to successively open one drawer after another. As far as I could see, the sample_objects_logic.py example contains code for opening a microwave. Doing the same code microwave.states[object_states.Open].set_value(True) for the cabinet won't work as there is no class 'igibson.object_states.open.Open in the states dictionary for such a URDF file. However, I saw in the doc. that one can select relevant joints somehow. Can you provide any minimal working example for that ?
Additionally, I saw that the states are not available for the YCB objects (at least the 003_cracker). Is it straightforward to add it ?
Thanks in advance guys !
EDIT: I have written my own pybullet functions for that now. I am still curious if the object_state.Inside would work for YCB objects and if object_state.Open does exist for objects such as cabinets (or it doesn't work due to multiple joint possibilities)

It should work for these cabinets, and you can make it work for YCB objects too. For some reason the states are not being loaded in your case. Perhaps you could check if you have the bddl package installed (this is what annotates microwave as Openable, leading to the Open state being added). To debug this you can check the .abilities field on your object to see what abilities it has.


Question: CLIs without "command"

Is there support for CLIs without a specific command? If so, some hints to that in the README would be helpful.
In detail, if I want to develop a simple command line tool, which takes some flags and some files as input, e.g.
foo -a bar.txt baz.log -f

I do not have a command. Instead I have just some flags -a and -f, plus and arbitrary number of optional collected parameters.
I good real world example of such a tool is the famous rm from the GNU core utils, which, unlike the macOS version of rm accepts flags at any position.

Thanks for the explanation, I would have preferred an interface, though, that supports easy uses cases as default (no commands) and more complex ones (many different commands and routing routing) by adding more code. I guess the community would adopt SwiftCLI for more projects if the API is kept simpler for simple things. Anyway, thanks for the quick reply.

You're welcome to make a pull request with any concrete improvements! My goal isn't to make a project the whole community will adopt, SwiftCLI is just a project that I've used in my own projects which I (rightfully) believed others would find useful as well. It's definitely built for full featured command line apps -- you don't need really any features in this lib if you're only including one command. I suggest looking around at other tools to see what fits your use case rather than lamenting the fact that one lib doesn't fit your use case quite right!

Don't get me wrong, I do like the project and I think it is quite helpful, even in cases where only flags, key value options and arguments are needed. I did already check other projects, on CLI interfaces in Swift and I think SwiftCLI is a very promising one. So I just wanted to make a constructive comment.

I'm glad you find SwiftCLI promising! But I fear in your comment you may have made the common mistake of equating open source maintainers with maintainers of proprietary projects -- I'm certainly happy whenever someone finds my project useful enough to use in their own projects, but it is not my job to add features to entice the community into using my project over other projects. There are a lot of great projects out there, and I'd encourage you to check out such projects as https://github.com/nsomar/Swiftline which may be a better fit for you than this project.
On the other hand, if you wish to help contribute to SwiftCLI, I'd encourage you to make a proposal of a feature you'd like to see! Off the top of my head, maybe you'd like to see something like this:
protocol SingleCommand: Command {}

extension SingleCommand {

    func run() -> Int32 {
        let cli = CLI(name: name)
        cli.parser = Parser(router: SingleCommandRouter(command: self))
        return cli.go()
    }

}

in SwiftCLI, which would allow use like:
class RmCommand: SingleCommand {
   let name = "rm"
   func execute() throws {}
}

RmCommand.run()

or perhaps you have something totally different in mind. In any case, when it comes to requesting features from projects which are offered to you for free, it's much more constructive to offer a concrete suggestion than passingly say its not simple enough for you or the community.

Thanks for the long explanation. I did not request implementing any feature and I am happy to hear that you are open for pull requests and improvements - which not everyone is.


Clarify comment about an IE11-issue in ffe-account-selector-react

This code comment mentions an issue with IE11, which is supposed to be fixed in React 16. As React 16 is out by now, the comment might need an update.
https://github.com/SpareBank1/designsystem/blob/d5bb1f7fa7b15411b707999469ee3814c3ae9a81/packages/ffe-account-selector-react/src/subcomponents/input-field/InputField.js#L14-L21

Depending on the outcome of #44 we may drop this workaround and comment altogether. For now I think the comment is fine.

From #44 we'll be dropping support for React 16, so this workaround can be removed. I'll do it as a separate commit when working on #44.

Keep in mind that the comment pre-dates  the release of React 16 and we need to verify that this known issue is solved.

I tried removing the React 15 workaround and tested in IE11. No characters were dropped when I was typing. I think we can safely go back to only using onChange. PR incoming.


Wiki

Started a wiki page "Home proposal", to be moved to Home, if you agree.
What do you think?

I think that's a fine idea. github wiki is as good a place as any for user-contributed information.
Go ahead and rename the page.

Done. Closing this issue (no need to keep it open until somebody acutally adds content ... ;)


LoRa APRS-I-Gate FTP

Hello folks,
first of all I would like to thank Peter, OE5BPA for this excellent application.
I have both a tracker and an I-Gate in operation and am currently programming the 6th I-Gate for a friend.
Since an error occurred during the input of the position, he suddenly lived 20 km further west ;o) for reprogramming the OM had to drive almost 80km...
Now I read that you can change the configuration via FTP, the FTP access I have unlocked, name and PW assigned and I can also connect to the gate. But I can't find any modifiable file there.
I could also not find any documentation. Maybe someone here has experience with this and could enlighten me how this works.
Thanks for reading
73 Joe/DF2JP

Hi! are you sure you can not find something? there should be an folder and in this folder the json file is placed. please re-check, thanks!


FR: Allow images to be attached at the Tenant level

I will start off by saying that I have read #1039 #1408 #1416 and #969.
I will also say that I have VERY little experience with regex.
These dont quite cover what I was hoping to have. I am with you that NetBox does not need to be a file/document repository but I feel that the image attachment at the site or device level doesnt quite capture the broader picture that Im hoping to get.
By having the image attachment at the Tenant level, you could have a fantastic place to upload a network map image to show the network topology of the Tenant as a whole. I know that there is the Topology Map feature in the admin section of the site but I feel that its to restrictive. First you are only able to access the admin section if you are a superuser and, Second,  the map design is limited to the hierarchical layout that is offered by the regular expression format. Third (kind of joking) who likes regular expressions anyway? Also (and this may just be my lack of knowledge or drive to learn regex) each map may not need ALL the connections displayed that a certain device has. For example if I just want to show the circuits that connect different sites and not the connections on the LAN.
Having a image attachment at the tenant level would also allow users to be able to attach the files without needing a superuser to create the map.

Thank you for your interest in NetBox. We require that all issues be submitted using the template provided here. This is to ensure that only valid issues are reported and that each issue includes all the information necessary for a developer to act on it. Please update your issue so that it matches the template (this may require rewriting your issue entirely). This issue will be closed in one week if it has not been updated. Thanks!

Issue type
[x] Feature request
[ ] Bug report
[ ] Documentation

Environment

Python version:  2.7
NetBox version:  2.1.2

Description
I will start off by saying that I have read #1039 #1408 #1416 and #969.
I will also say that I have VERY little experience with regex.
These dont quite cover what I was hoping to have. I am with you that NetBox does not need to be a file/document repository but I feel that the image attachment at the site or device level doesnt quite capture the broader picture that Im hoping to get.
By having the image attachment at the Tenant level, you could have a fantastic place to upload a network map image to show the network topology of the Tenant as a whole. I know that there is the Topology Map feature in the admin section of the site but I feel that its to restrictive. First you are only able to access the admin section if you are a superuser and, Second, the map design is limited to the hierarchical layout that is offered by the regular expression format. Third (kind of joking) who likes regular expressions anyway? Also (and this may just be my lack of knowledge or drive to learn regex) each map may not need ALL the connections displayed that a certain device has. For example if I just want to show the circuits that connect different sites and not the connections on the LAN.
Having a image attachment at the tenant level would also allow users to be able to attach the files without needing a superuser to create the map.

This has already been addressed in the issues you referenced. Topology maps are not intended to replace traditional, detailed network diagrams, and there is no reason to store those in NetBox.

I don't see any reason not to allow images to be attached to tenants in the same way as it is exposed for sites and devices. I can think of a number of reasons why it makes sense to allow it, but ultimately it would be up to the user if its used or not.

I'd like to bump this, as I do think that attaching a image to a tenant is just as important as any other area. I also think this is adding flexibility to the project and the admin of their site can choose to use it.


Results of movies and tv series still in english even after changing the language

Hello!
I installed the tracker today and set Spanish as TMBD language, but the results still are presented in english.
I don't know if I have to do something else:

Btw, I will translate this project to spanish when I have some little time.

Searching for items, that you never search before should now be in selected language, but you will have to set the language again.
After changing TMDB language your entire database should update itself.
Now I am rewriting search queries, so all search result should show in selected language.
Thank you for Spanish translations :)

Searching for items, that you never search before should now be in selected language, but you will have to set the language again., there was a small bug.
After changing TMDB language your entire database should update itself.
Now I am rewriting search queries, so all search result should show in selected language.
Thank you for Spanish translations :)

Perfect, now it's working as expected, thanks!
My pleasure! I will work on translate the remaining strings from time to time.
And thank you for this awesome program!


unable to resolve dependency tree

runing npm install got this error
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/mongoose
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/mongoose-fuzzy-searching
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /home/sh_eldeeb_2010/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/sh_eldeeb_2010/.npm/_logs/2021-04-17T10_38_30_064Z-debug.log

Thanks for reporting!
Can you give me a bit more details to reproduce this error?
I assume this happens after you enter server folder and npm install?
Trying to reproduce at the moment after clearing cache, generating project and npm install everything works fine.

I already gave all details in the issue description.
I can install the packages by appending the flag --force to the command npm install, but this is a bad practice.
please check the error message, the issue is coming from the version of mongodb in your peer dependencies.

Npm version
Node version
Debug log
Provide these please.
Peer dependency is already resolvable from mongoose-fuzzy-searching.

this issue is caused due to a conflict between dependencies veriosns (mongodb), and has no any relation with node version and npm version.
however, this is my environments:
node version: v12.14.1
npm version: 7.8.0


feat(gls-types): add more type aliases

This change adds and exports more type aliases so graphql-language-service-interface and codemirror-graphql can use them (#902 , #1264 ).

@yoshiakis i think this has been resolved already? by combining and extending types? want to reopen this?

@acao It's not resolved yet but It's ok to keep this PR closed! I think there is a more suitable solution for this and if I have time to do that I'll open another PR.


Feature/docker db wait

Fixes #68 by adding a delay until the db is responding before running migrations.

@danielbrendel  It should be working as is but please make sure the db wait actually works for you. My deployment is in Kubernetes and my "db cluster" is always running so it's not easily reproduced here.


⚠ Bofrost.lu has degraded performance

In ab0f672, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 902 ms

Resolved: Bofrost.lu performance has improved in a83e45a after 8 minutes.


[FEATURE] [PPL] Add support to reserved keywords in PPL

Is your feature request related to a problem?
Currently for PPL query, the backtick `` has to be added to surround a reserved keyword in order for query engine to understand. Request to add reserved keyword support.
What solution would you like?
Query contains reserved keys do not need backtick just like any other non-reserved keywords
Do you have any additional context?
Example:
source = sample-data | stats count() by `index` --> index is reserved key and has to be surrounded with backtick to work

// Ideally just

source = sample-data | stats count() by index

Related to #672, #712 and similar issues. keywordsCanBeId list should be extended in grammar files.

whats constitues a reserved keyword? how do we define what is reserved

backport to 2.5. https://github.com/opensearch-project/sql/pull/1324


feat(jitter): add jitter to controllers to smooth out our spiky resource

usage.

Description of the change:
Motivation for the change:
Reviewer Checklist

[ ] Implementation matches the proposed design, or proposal is updated to match implementation
[ ] Sufficient unit test coverage
[ ] Sufficient end-to-end test coverage
[ ] Docs updated or added to /docs
[ ] Commit messages sensible and descriptive

/retest

/bugzilla refresh

/bugzilla refresh

/bugzilla refresh

@kevinrizza I have a cluster spinning up that I plan to check - I don't think this completely solves the problem but I expect to have more, smaller spikes.

/cherry-pick release-4.4


[Footer] Explore Adjunct link location

Original Slack conversation
Mike has asked us to revisit the location of the adjunct links in the Footer. We should explore out each option to see what change might entail and whether it would be technically feasible.
Option A - w/o adjunct links

Option A - with adjunct links

Option B - clustering

Option C - add second rule to current version

Still leaning into option A


Issue updating State

Hi,
I have a page that have as content a "base render" controls that includes an alert made with SfPopup.
The text of this alert is bound to a State property (State._AlertState.MsgAlert).
To set the text I have made the method SetText like this:
public VolosPopUp SetText(Func<string> textFunc)
        {
            Init();

            this.Set(Syncfusion.Maui.Popup.SfPopup.ContentTemplateProperty,
                new MauiControls.DataTemplate(() => TemplateHost.Create(DefaultLabelText(textFunc)).NativeElement));

            return this;
        }

Then I have created the method "ApriAlert" that set the bounded property to true in order to open the popup and set its text:
public void ApriAlert(string messaggio, string headerText = "", Action callbackOk = null)
        {
            MainThread.BeginInvokeOnMainThread(() =>
            {
                SetState(s =>
                {
                    s._AlertState = new BaseAlertState
                    {
                        HeaderAlert = headerText,
                        MsgAlert = messaggio,
                        CallbackAlertOk = callbackOk,
                        ApriAlertOk = true
                    };
                }, false);
            });
        }

The issue occurs when I set false to SetState to avoid re-render the full page.
If I leave the SetState to re-render the page all works fine, but if I set false the invalidateComponent, the text of the popup is not updated.
Here a sample where the label on the page is bounded to the same property used to set the text of the popup; the label text is correctly update but the popup text doesn't.
How can I fix this issue?

Thank you.

Hi, if you don't invalidate the component (set invalidateComponent: false) only the properties fed with a function (i.e. : .Text(()=>State.MyText)) are updated.
I've looked at your code but sorry I can't get the point of creating such overlaying complex structures that are really hard to follow.
Maybe you can just let me know what you're trying to do and I'll be happy to show you the MauiReactor way to do it.

Thank you for the reply.
In my application I need to have a ready to use alert dialog (implemented with SfPopup) because am I moving an enterprise app from xamarin to maui and I have choose to use MauiReactor to do so.
In the xamarin forms app there was a single instance of a SfPopup that will be shown\hide at runtime, so  I need to reproduce the same beahavior here.
I have understood that in MauiReactor all is based on State, so I thought to add an alert to all my pages (the baserender function basically do this) and create a function (ApriAlert) that set to TRUE the state's property bounded to IsOpen method of the popup.
Also I have bounded the Text and HeaderText to others state properties but them doesn't change correctly.

Regarding the state not being updated yes the problem could be that you created it using a custom DataTemplate.
Maybe I get your point, I think this is the case where the imperative approach works better than the declarative approach: so you have just to call a method like ShowPopup("My message") instead of declaring a new Popup() inside the render method and manage its state with an IsShown-like boolean property.
So to sum up, in your case I suggest creating a simple helper static class where you directly instantiate and manage the popup, without MauiReactor wrappers:
static class Utils
{
  public static void ShowPopup(string message)
  {
     //create a native syncfusion popup
     var popup = new SfPopup();
     //customize popup (https://help.syncfusion.com/maui/popup/getting-started?cs-save-lang=1&cs-lang=csharp)
     //....
     popup.Show();

  }
}

and use it in your components when you need it:
Utils.ShowPopup("Hello!");

Regarding the state not being updated yes the problem could be that you created it using a custom DataTemplate.
Maybe I get your point, I think this is the case where the imperative approach works better than the declarative approach: so you have just to call a method like ShowPopup("My message") instead of declaring a new Popup() inside the render method and manage its state with an IsShown-like boolean property.
So to sum up, in your case I suggest creating a simple helper static class where you directly instantiate and manage the popup, without MauiReactor wrappers:
static class Utils
{
  public static void ShowPopup(string message)
  {
     //create a native syncfusion popup
     var popup = new SfPopup();
     //customize popup (https://help.syncfusion.com/maui/popup/getting-started?cs-save-lang=1&cs-lang=csharp)
     //....
     popup.Show();

  }
}

and use it in your components when you need it:
Utils.ShowPopup("Hello!");

Thank you!
I have re-used the template used for the "MauiReactor" version and use it with TemplateHost.Create(MyTemplate).NativeElement (so I don't need to rewrite the template) and now works.


support RFC6381 expressions

Standardized expressions of encodings via RFC6381.

There was already such request (by email if I remember well), in order to e.g. create HLS .m3u8 files.


Update the info about the schema.assert procedure

On the querying docs under the schema assert section, there's an info on dropping all indexes and constraints that should be deleted since there are now edge-type indexes that are not affected by that. Context

@kgolubic is this fixed?

@kgolubic is this fixed?

No, not yet. Will bump it up on the list of prioreties.


Modal

How is it going with Modal. Will be awailable any time soon?
Thank you for you help!
Best regards...

If that can help, In my project my modals are components, and I set them to visible or not with the ngClass binding.

Having one modal and passing it a template similar to ng-bootstrap would be nice. https://ng-bootstrap.github.io/#/components/modal.

Hi there, I'm afraid the modal component is not high on the list of priorities. You can get something working using [suiTransition] and the right HTML & CSS - leverage the router for the transitions. Will reopen this when I get around to starting the modal component myself 😄

Just a status update - I'm now starting work on a modal component, and am tracking progress in #78. Follow there for news over the course of the next week.


Fix revert clucene version wrong rollback

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new mechine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 56.88 seconds
stream load tsv:          512 seconds loaded<PHONE_NUMBER>9 Bytes, about 139 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select:          87.1 seconds inserted 10000000 Rows, about 114K ops/s
storage size:<PHONE_NUMBER>0 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230705163335_clickbench_pr_172613.html

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.77 seconds
stream load tsv:          451 seconds loaded<PHONE_NUMBER>9 Bytes, about 158 MB/s
stream load json:         21 seconds loaded<PHONE_NUMBER> Bytes, about 107 MB/s
stream load orc:          58 seconds loaded<PHONE_NUMBER> Bytes, about 18 MB/s
stream load parquet:          29 seconds loaded 861443392 Bytes, about 28 MB/s
insert into select:          68.3 seconds inserted 10000000 Rows, about 146K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230705084413_clickbench_pr_172623.html


Should the yielding sleep strategy call Thread.yield()?

Would it be better for TokenBuckets.YIELDING_SLEEP_STRATEGY to call Thread.yield() here rather than sleeping for one nanosecond?

Nevermind. This would probably just make it closer to busy-waiting.


Quality check - Check for orphaned files

Supports #7
Ensure that all files from the root directory (recursively) have at least one href reference in any html files. In other words, ensure that no files are dangling.

I believe our parsing approach won't be needing this check. @IanMayo, please let me know your thoughts.


[Breaking] Digest function now auto-detected from request (#899)

Description
Please include a summary of the changes and the related issue. Please also
include relevant motivation and context.
Fixes # (issue)
#770
Type of change
Kickstarting the glossary
Please delete options that aren't relevant.

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

How Has This Been Tested?
Please also list any relevant details for your test configuration
Checklist

[x] Updated documentation if needed
[x] PR is contained in a single commit, using git amend see some docs

This change is

@MarcusSorealheis This is the first stab at the glossary. Let me know if you have feedback.

I don't know why there are 36 file changes here-  I only committed 2. I'm not sure how these changes came about.

You need to rebase. You were on a non main branch or maim that was behind

weird-  I rebased the main branch before creating a new branch. That's why I was confused. Should be fixed now.

This branch is unclean.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.6 out of 7 committers have signed the CLA.:white_check_mark: bclark8923:white_check_mark: allada:white_check_mark: aaronmondal:white_check_mark: SchahinRohani:white_check_mark: zbirenbaum:white_check_mark: adam-singer:x: MarcusSorealheisYou have signed the CLA already but the status is still pending? Let us recheck it.

@nfarah86 Check this out.


chore: bump the minimum tokio version; allow higher versions again.

https://github.com/tokio-rs/tokio/issues/3964 seems to be fixed :)

Thanks 👍


TabItem

Hi
I have a tabcontrol, where I want the tabs that are disabled to be red how to do I do?
Have made this style to bind tabheader and the enable properties
    <Style TargetType="{x:Type TabItem}" BasedOn="{StaticResource MetroTabItem}">
        <Setter Property="Header" Value="{Binding TabHeader}"/>
        <Setter Property="IsEnabled" Value="{Binding IsEnabled, UpdateSourceTrigger=PropertyChanged, Mode=TwoWay}"></Setter>
    </Style>

@brianshansen You can use a trigger for this and change e.g. the background of your item or you use a converter which binds to IsEnabled and converts it to a background...


Does not work on POP OS 22.04 (built mpv from source)

2022-05-07 16:19:10,892 [    INFO] conf: Loaded settings from json: /home/harsh/.config/plex-mpv-shim/conf.json
2022-05-07 16:19:11,001 [ WARNING] root: Cannot load GUI. Falling back to command line interface.
Traceback (most recent call last):
File "/usr/local/lib/python3.10/dist-packages/pystray/_appindicator.py", line 23, in
gi.require_version('AppIndicator3', '0.1')
File "/usr/lib/python3/dist-packages/gi/init.py", line 126, in require_version
raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace AppIndicator3 not available
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/dist-packages/plex_mpv_shim/mpv_shim.py", line 39, in main
from .gui_mgr import userInterface
File "/usr/local/lib/python3.10/dist-packages/plex_mpv_shim/gui_mgr.py", line 1, in
from pystray import Icon, MenuItem, Menu
File "/usr/local/lib/python3.10/dist-packages/pystray/init.py", line 62, in
Icon = backend().Icon
File "/usr/local/lib/python3.10/dist-packages/pystray/init.py", line 54, in backend
return candidate()
File "/usr/local/lib/python3.10/dist-packages/pystray/init.py", line 26, in appindicator
from . import _appindicator as backend; return backend
File "/usr/local/lib/python3.10/dist-packages/pystray/appindicator.py", line 26, in
gi.require_version('AyatanaAppIndicator3', '0.1')
File "/usr/lib/python3/dist-packages/gi/init.py", line 126, in require_version
raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace AyatanaAppIndicator3 not available
2022-05-07 16:19:11,069 [    INFO] player: Using libmpv1 playback backend.
Traceback (most recent call last):
File "/usr/local/bin/plex-mpv-shim", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.10/dist-packages/plex_mpv_shim/mpv_shim.py", line 47, in main
from .player import playerManager
File "/usr/local/lib/python3.10/dist-packages/plex_mpv_shim/player.py", line 568, in
playerManager = PlayerManager()
File "/usr/local/lib/python3.10/dist-packages/plex_mpv_shim/player.py", line 235, in init
def handle_end_idle(event):
File "/usr/local/lib/python3.10/dist-packages/mpv.py", line 1606, in register
types = [MpvEventID.from_str(t) if isinstance(t, str) else t for t in event_types] or MpvEventID.ANY
File "/usr/local/lib/python3.10/dist-packages/mpv.py", line 1606, in
types = [MpvEventID.from_str(t) if isinstance(t, str) else t for t in event_types] or MpvEventID.ANY
File "/usr/local/lib/python3.10/dist-packages/mpv.py", line 299, in from_str
return getattr(kls, s.upper().replace('-', ''))
AttributeError: type object 'MpvEventID' has no attribute 'IDLE'

Try using an older MPV version or use external MPV mode.

Caused by #72


can't get correct dhash from a icon picture

testpictures.zip
I attached the picture in the zip file, one is icon type, and the other is png type
dhash of the icon type  returns a value of 0
dhash of the icon type  returns a value of<PHONE_NUMBER>7926919091179733734494077055
I tried both 1.4 and 1.3 dhash version. Also tried both PIL and wand
do you have any comment about this? Do I need to covert icon picture to png first to get a meaningful value?  Thanks

Hi there, I can't reproduce this with the latest version of dhash (on the master branch) and the latest version of PIL on Python 3.10.12. I'm using your .png and .ico files in the zip (renamed to shorter filenames), and I get a valid-looking hash for both image types:
>>> png = Image.open('favicon.png')
>>> dhash.dhash_int(png)
62655588668192742069404494315346493567
>>> ico = Image.open('favicon.ico')
>>> dhash.dhash_int(ico)
62738665417926919091179733734494077055

Hi Ben,
Thanks for your quick response.
I just tried the latest version of PIL (10.2.0), and it works now.
I tested on PIL 10.1.0 and Wand, but they failed.
On Thu, Mar 14, 2024 at 12:26 PM Ben Hoyt @.***> wrote:

Hi there, I can't reproduce this with the latest version of dhash (on the
master branch) and the latest version of PIL on Python 3.10.12. I'm using
your .png and .ico files in the zip (renamed to shorter filenames), and I
get a valid-looking hash for both image types:

png = Image.open('favicon.png')
dhash.dhash_int(png)
62655588668192742069404494315346493567
ico = Image.open('favicon.ico')
dhash.dhash_int(ico)
62738665417926919091179733734494077055

—
Reply to this email directly, view it on GitHub
https://github.com/benhoyt/dhash/issues/13#issuecomment-1998260403, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ALJNAMOVSYOYNSBG56Q4HZ3YYH2UTAVCNFSM6AAAAABEWRNYGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJYGI3DANBQGM
.
You are receiving this because you authored the thread.Message ID:
@.***>


Test Coverage Integration

Brief Issue Summary
Should the CMake Tools extension support Test Coverage which is an extension to the Testing API finalized in vscode v1.88.0?
We have an extension which revolves around a product that utilizes CMake extensively in its build system. Users of our extension are expected to also have the CMake Tools extension installed for a fuller feature set. We have now faced an obstacle when it comes to the test explorer view. The CMake Tools extension provides a "CTest" test controller that is present in the VSCode test explorer. We are trying to decide if we should push our users to rely on the CTest test explorer view or if we should provide our own (we have a test runner that can discover and run tests independently from CTest, but would preferably rely on CTest). I have added coverage support to our own test controller using the new coverage support in the VSCode Testing API, and think it is very useful.
My question is thus if there is any possibility of implementing coverage support to the CMake Tools extension directly? I'm thinking that coverage is handled differently in different build environments, which could make it hard to make something generalized. But one could for instance have configuration parameters in the CMake Tools extension which the user can set that includes say:
{
    cmake.preTestCoverageTask: "<task to run before a "Run Test with Coverage" execution>",
    cmake.postTestCoverageTask: "<task to run after a "Run Test with Coverage" execution>",
    cmake.lcovTraceFiles: [
        "<lcov trace files to parse when adding test coverage to files in the project. Could perhaps we wildcarded>"
    ]
}

If you think something like this (or some other approach that could also be thought reasonable for handling coverage), let me know. I could perhaps help out with an implementation if it makes sense to do one.
CMake Tools Diagnostics
No response
Debug Log
No response
Additional Information
No response

Hi, I have tested the implementation of #4094 with v1.20.30 pre-release version.
I was able to make it work but found a few bugs :

The new cmake options are not recognized as valid configuration in the settings.json :.
They are also not showing up in the UI. But they are taken into account when running test with coverage in the test explorer.
If a cmake.preRunCoverageTarget was specified and then the setting is removed, the value is not reset and keep being taken into account. Workaround is to specify an empty target.
If no cmake.coverageInfoFiles is specified running test with coverage never ends. I suppose it is because the extension is waiting for a file to parse.

In any case, thanks a lot for adding this feature, it will be very useful  and is more powerful than coverage gutters extension I have been using until then.

Hi @triou-harmonicinc . I tried running v1.20.30 (pre-release)

The new cmake options are not recognized as valid configuration in the settings.json

This is strange, they are recognized for me, and when I hover my mouse cursor over them, I see the description of the option as well.

If a cmake.preRunCoverageTarget was specified and then the setting is removed, the value is not reset and keep being taken into account. Workaround is to specify an empty target.

I was not able to reproduce that, when I removed it, the preRunCoverageTarget was not built. Can you see the log Building the preRunCoverageTarget '<target-name>' for project <project-dir> in the OUTPUT after removing the setting from settings.json when running the test with coverage?

If no cmake.coverageInfoFiles is specified running test with coverage never ends. I suppose it is because the extension is waiting for a file to parse.

This is also something that I'm not able to reproduce, in this case I see No coverage info files for CMake project <project-folder>. No coverage data will be analyzed for this project. and the test concludes.

I just double checked and after doing Developer : Reload window all the issues disappeared.
I guess I should have tried that first (I only installed newest extension and restart extensions until then), sorry for the bother.

Glad to hear that things are working

By the way, @gcampbell-msft I suppose this issue can be closed.