Sylpheed.Sylpheed version 2.2.7

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Hi @KarbitsCode,
This manifest adds a DisplayVersion to the AppsAndFeaturesEntries that isn't present in previous manifest versions. This entry should be added to the previous versions, or removed from this version.
(Automated response - build 896.)

Should it? The other manifest that doesn't have DisplayVersion because it already matched with the package version in the manifest.

Should it?

Yes - either the value should be in all manifests in the PackageIdentifier, or it should be in none.

The other manifest that doesn't have DisplayVersion because it already matched with the package version in the manifest.

Are you referring to https://github.com/microsoft/winget-pkgs/pull/176072? That PR also adds a DisplayVersion, as do a number of other recent PRs:

https://github.com/microsoft/winget-pkgs/pull/176071 (This PR)
https://github.com/microsoft/winget-pkgs/pull/176072 (Other PR mentioned above)
https://github.com/microsoft/winget-pkgs/pull/176073
https://github.com/microsoft/winget-pkgs/pull/176074
https://github.com/microsoft/winget-pkgs/pull/176075
https://github.com/microsoft/winget-pkgs/pull/176076
https://github.com/microsoft/winget-pkgs/pull/176077
https://github.com/microsoft/winget-pkgs/pull/176078
https://github.com/microsoft/winget-pkgs/pull/176079
https://github.com/microsoft/winget-pkgs/pull/176080
https://github.com/microsoft/winget-pkgs/pull/176081
https://github.com/microsoft/winget-pkgs/pull/176082
https://github.com/microsoft/winget-pkgs/pull/176083
https://github.com/microsoft/winget-pkgs/pull/176084
https://github.com/microsoft/winget-pkgs/pull/176085
https://github.com/microsoft/winget-pkgs/pull/176086
https://github.com/microsoft/winget-pkgs/pull/176087
https://github.com/microsoft/winget-pkgs/pull/176088
https://github.com/microsoft/winget-pkgs/pull/176089
https://github.com/microsoft/winget-pkgs/pull/176090

Related, a number of recent PRs modify existing manifests:

https://github.com/microsoft/winget-pkgs/pull/176111
https://github.com/microsoft/winget-pkgs/pull/176118
https://github.com/microsoft/winget-pkgs/pull/176122
https://github.com/microsoft/winget-pkgs/pull/176131
https://github.com/microsoft/winget-pkgs/pull/176135
https://github.com/microsoft/winget-pkgs/pull/176138
https://github.com/microsoft/winget-pkgs/pull/176142
https://github.com/microsoft/winget-pkgs/pull/176145
https://github.com/microsoft/winget-pkgs/pull/176150
https://github.com/microsoft/winget-pkgs/pull/176154
https://github.com/microsoft/winget-pkgs/pull/176158
https://github.com/microsoft/winget-pkgs/pull/176162
https://github.com/microsoft/winget-pkgs/pull/176165
https://github.com/microsoft/winget-pkgs/pull/176169
https://github.com/microsoft/winget-pkgs/pull/176173
https://github.com/microsoft/winget-pkgs/pull/176177
https://github.com/microsoft/winget-pkgs/pull/176181
https://github.com/microsoft/winget-pkgs/pull/176185

At first, it seemed like the 2nd group were opened to add a DisplayVersion to the existing manifests. But these modify other metadata. Were they modified to also update the DisplayVersion it should resolve this issue.

Are you referring to #176072?

No, I'm referring to version 2.7.0 and all the above.

Were they modified to also update the DisplayVersion it should resolve this issue.

If I understand it correctly, I should add the DisplayVersion on all the other manifest like this:
...
PackageIdentifier: Sylpheed.Sylpheed
PackageVersion: "3.7"
InstallerType: nullsoft
AppsAndFeaturesEntries:
- DisplayVersion: "3.7"
Installers:
...

Is that correct?

Essentially, yes. The other option would be to remove it from the 2.x series.

Okay, I will add the rest.
Meanwhile, you can approve the one that already has DisplayVersion.


Tooltip/popover: Fix auto placement to use viewport

Currently, auto placement is using the container dimensions (if provided) or the element's parent to determine where to open the tooltip:
var $container   = this.options.container ? $(this.options.container) : this.$element.parent()
var containerDim = this.getPosition($container)

This is quite broken in fact, because the parent element could be just a small div outside the element for example, leading in a totally random placement (placing the tooltip on top even if there's no room). And the container can also be outside of the viewport.
This fix simply uses the viewport instead, that's the purpose of the viewport actually, to position the tooltip.
So the auto placement should use it to find where there's more room.
By default this is body, which is good.

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED
Commit: 0e8e5222ff9d48e72cb270ddf7b924e7c86760f0
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/55829985
(Please note that this is a fully automated comment.)

If you could add a unit test to prevent future regressions, that would be greatly appreciated.

Yep, I'll try fixing the sauce labs failing tests and add a new one ;)

Ok I've just added a non-regression unit test and fixed another one which was actually not testing anything and passing by pure luck.
Also, I see you actually had a lot of specs about the auto-placement feature mentioning the viewport, this is good and comforts me into thinking that the behaviour I fixed was the expected one.
The funny part is that all these specs currently passes because the viewport happen to also be the direct parent on these specs.

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED
Commit: df96c3e615919c008c113187ef07530a3bdc9f6f
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/56296669
(Please note that this is a fully automated comment.)

There seem to be some test failures in all versions of IE.

Yep, I'm trying to have a look a this but can't manage to get tests running on IE9 yet.

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED
Commit: 5921724d9c22098326bed005884477d3e8b6ec44
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/56316146
(Please note that this is a fully automated comment.)

This is now fixed.

This looks safe to try to me, anything else on your end @cvrebert

@fat Nope.


Need a mechanism to encrypt and decrypt values

Need a mechanism to encrypt and decrypt values. Following are few scenarios that we need the support.
Scenario 1: Encrypting the key store and trust store passwords
@http:configuration {
keyStorePassword:"test",
trustStorePassword:"test"
}
Scenario 2: Encrypting values like the access token, refresh token, client id and secret which will be stored in a separate file and read through the config API.

Releated https://github.com/ballerinalang/ballerina/issues/4132


[Documentation] How to test a new keyboard guide

Add documentation to know how to test a new keyboard that is not supported yet by Kebbie
🔍 Description
This documentation is mainly focused on how to set up an Android emulator and evaluate an Android keyboard.
🧐 Context
This doc should be a step by step guide to add or just test any keyboard with Kebbie
⚠ Side-effects / Shortcomings
Maybe we can add some screenshots
✅ How this was tested ?

🌱 Checklist

[ ] Perform self-review of my own code
[ ] Comment the code, particularly in hard-to-understand areas
[] Update the documentation accordingly to the new code
[ ] Lint / format the code
[ ] Update existing tests / Add new tests
[ ] Tests are passing locally

Thanks for the PR !
Having this additional page will be very helpful.
At the moment, there are some issues with the render; how did you test your changes ? If you do :
pip install -e ".[docs]"
mkdocs serve

You should be able to visualize the page by going to http://<IP_ADDRESS>:8000/test_a_new_keyboard/
And then you can fix the rendering issues in the markdown file (like the bullet points or the admonitions)

Screenshots added and checked the render.

PR ready to re-check @astariul
Please compile it locally to check the render too.


Fix parsing of apparmor pcre syntax

fix #17783 ping @ewindisch

ping @skottler
nah just kidding :P

LGTM

LGTM
looks all right


Synchronisiert mode (Default, Eco, Next Trip) nicht bei Änderung

Hallo,
bei mir synchronisiert sich der Datenpunkt mode (Default, Eco, Next Trip) nicht immer wenn ich via set_state bzw. set_mode diesen ändere.
Wenn ich den Interval to receive des Adapters auf 0 einstelle funktionierts.
(Adapterversion 4.5.1).
Gruß Norb

Hello, thank you for your feedback.
On my side it works as intended: I think you set the mode wrong. The mode key is known as “lmo” so you can see that under https://github.com/joscha82/wattpilot/blob/main/API.md. So, if you want to set the mode to “Default” you need to set_mode 3, “Next Trip” is 5 and “Eco” is 4.
Hope this helps you,
Best regards!

Hello,
Interval to receive from adapter is set to 5 seconds.
If I change the set_mode to 3, the mode is updated to "Default", so far OK.
If I set the set_mode to 4 the mode updates to "Eco", also OK.
If I change the set_mode to 3 again, nothing changes in the mode, remains on "Eco".
The update of the mode is quite different sometimes "Default" sometimes "Eco" remains.
If the Interval to receive from the adapter is set to 0 everything works correctly.
BR
Norbert

Hello,
Was a tricky bug to reproduce, it was an issue in the timeout function. The bug is fixed for the normal parser. If you get all parameters, it’s still possible to occur if you get the timing right.
The bug is fixed in version 4.6.0 you can update right now on the beta repositories, until the adapter is in stable repository.
Best regards

thx


Fix command line coverage

Codecov Report

Merging #11 into master will increase coverage by 7.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   59.14%   66.45%   +7.31%
==========================================
  Files          15       16       +1
  Lines        1285     1288       +3
==========================================
+ Hits          760      856      +96
+ Misses        525      432      -93

Impacted Files
Coverage Δ

src/viztracer/__main__.py
100.00% <0.00%> (ø)

src/viztracer/viztracer.py
86.79% <0.00%> (+11.32%)
:arrow_up:

src/viztracer/report_builder.py
80.95% <0.00%> (+15.87%)
:arrow_up:

src/viztracer/flamegraph.py
100.00% <0.00%> (+18.07%)
:arrow_up:

src/viztracer/main.py
71.91% <0.00%> (+62.92%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 360b1a8...02000b1. Read the comment docs.


Try to show the images of all the people in the database

Student Members
Coordinators
Alumni

http://stackoverflow.com/questions/22247582/rails-4-saving-images-in-database

@aniarya82
See if this is feasible.


Adding another test for IsGreaterThan comparison

Sorry I moved some things around - can you fix conflicts and I'll merge?


EVEREST-203 Do not run registration for already registered k8s clusters

Codecov Report

Merging #151 (81b1053) into main (7baf844) will decrease coverage by 0.02%.
Report is 4 commits behind head on main.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #151      +/-   ##
========================================
- Coverage   5.12%   5.11%   -0.02%
========================================
  Files         12      12
  Lines       2788    2797       +9
========================================
  Hits         143     143
- Misses      2621    2630       +9
  Partials      24      24

Files Changed
Coverage Δ

pkg/install/operators.go
4.74% <0.00%> (-0.07%)
:arrow_down:

...kg/kubernetes/client/mock_kube_client_connector.go
0.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


read_parquet does not work with s3 links containing wildcard

What happens?
This works:
select count(*) from read_parquet('s3://overturemaps-us-west-2/release/2024-08-20.0/theme=places/type=place/part-00001-93118862-ebe9-4b31-8277-1a87d792bd5d-c000.zstd.parquet');
This does not work:
select count(*) from read_parquet('s3://overturemaps-us-west-2/release/2024-08-20.0/theme=places/type=place/part*.zstd.parquet');

HEAD, GET requests with 404 errors can also be seen in the console:

To Reproduce
LOAD httpfs;
LOAD spatial;

select count(*) from read_parquet('s3://overturemaps-us-west-2/release/2024-08-20.0/theme=places/type=place/part*.zstd.parquet');

https://shell.duckdb.org/#queries=v0,LOAD-httpfs~
LOAD-spatial~

select-count(*)-from-read_parquet('s3%3A%2F%2Foverturemaps us west 2%2Frelease%2F2024 08 20.0%2Ftheme%3Dplaces%2Ftype%3Dplace%2Fpart*.zstd.parquet')~
Other example queries can be found here: https://docs.overturemaps.org/getting-data/duckdb/#example-queries
Browser/Environment:
Firefox 127.0
Device:
laptop
DuckDB-Wasm Version:
1.28.1-dev258.0
DuckDB-Wasm Deployment:
shell.duckdb.org
Full Name:
PW
Affiliation:
none

Feel free to close if this is duplicate of #1040


feat: left align text fieds of container block

Closes #39
I've left-aligned a few non-numerical text fields in container section (container name, status and image name). I really care only about container name.

I've fixed the tests. I think they could be improved by using insta, where one can easily accept newly generated text as the expected string.

I think the columns and widths need some work, I've had a play around left aligning everything, and it looks decent, probably better than as it is currently.
Plus there were a couple mistakes with the widths of the headers and it's corresponding header, and probably a load of pointless calculations that we can get rid of

This looks great, I'll add it to this PR.
I've also opened a pull request that uses insta in tests, so that will make fixing test here much easier.

I did forget to update the tests, but I can sort that out


T-18267 feat: add error check for no events

Gets checking better for number of events

Cool this fix looks good to me. Thank you.


add roadmap document

@haileyschoelkopf I'm just adding this so that there is a public document everyone can see and chime in upon. Contemplated on using google docs but remembered that are folks in the community who want to remain anonymous. It seems that just using plain markdown and saved in the repo is the easiest.

I think this would work better as a pinned issue? Then ppl can easily write in their comments. Unless you are planning to write something more extensive

The goal of the doc is for people to populate, which could be through Issue or PR where the author could initiate a discussion. It's more a living document that sits in the Repo. When certain features get picked up, we (maintainers) could make appropriate issues and milestones.

yeah, makes sense. Could link it to the issue to provide visibility as well.

It's probably worth poking around to see how other successful big open source AI projects have handled this--I'd like to try to do some of that this week.
I also wouldn't mind a pinned issue to make it easier for people to provide their comments (reducing friction is important)--we'll end up doing our own curating anyway based on consensus and our bandwidth, I'm a little worried about a large volume of minor changes to this doc making it harder to track what's a "real" PR.


Use Github Runner to automatically pull the latest image from Dockerhub to Daniel's server

Depends on #10

@danielhmetro Is it OK if I SSH in and install the runner, or would you like to be part of that?

Got the runner running on [self-hosted, daniel-server].  I'll explore the Docker workflow tomorrow.


Added functions to turn on and turn off the display

This is useful for battery-powered applications etc, where you regularly turn off and on the display. (The datasheet also calls this "sleep mode", which is appropriate here.

I'm not too good at git. Could you just c+p the functions into master, or merge this as-is then make the tweaks?

Thanks! I've squashed your commits into master so it's still clean. I'll add a changelog entry and get this released.

Released in 0.2.3.

Sweet!


fixes #797

I hope this solves the issue. @mrutkows would you please review.

I could not understand why the build is failing. Can anyone help me?

@pritidesai would you please review this.

Hi @knrt10, the warning was disabled and reported as part of #920. We need to come to the conclusion whether the use case that runs through this section of code is supported or not. Please hold on to this PR or submit with commented code blocks, we can uncomment the submitted code after we resolve #920.

@pritidesai Thanks for explaining. I have updated the commented PR. You can merge it and if #920 is resolved you can ping me I can uncomment the changes.


tests/bsim: For nrf52bsim use full board name with qualifiers

So when building with twister we get the same executable name as with compile.sh

CC @ardo-nordic


Meta information about permissions

Ended up rewriting the Response flow, adding a custom Response class, with a semi-hacky implementation. Can probably be improved upon, but will take a lot of time figuring out the Laravel Response class. I'd say leave it like this until it is shown something else is needed.
Improves the permission search phase slightly.
Plays nice with pagination:
{
    "success": true,
    "meta": {
        "pagination": {
            "current_page": 1,
            "from": 1,
            "last_page": 1,
            "next_page_url": null,
            "path": "http://localhost/api/users",
            "per_page": 10,
            "prev_page_url": null,
            "to": 6,
            "total": 6
        },
        "permissions": [
            [
                "App\\Models\\User.bodies",
                "App\\Models\\User.pivot"
            ],
            [
                "App\\Models\\User.bodies",
                "App\\Models\\User.pivot"
            ],
            [
                "App\\Models\\User.bodies",
                "App\\Models\\User.pivot",
                "App\\Models\\User.address",
                "App\\Models\\User.circles"
            ],
            [
                "App\\Models\\User.bodies",
                "App\\Models\\User.pivot"
            ],
            [
                "App\\Models\\User.bodies",
                "App\\Models\\User.pivot"
            ],
            [
                "App\\Models\\User.bodies",
                "App\\Models\\User.pivot",
                "App\\Models\\User.address",
                "App\\Models\\User.circles"
            ]
        ]
    },
    "data": [
        {
            "id": 2,
            "address_id": 2,
            "personal_email"<EMAIL_ADDRESS>            "first_name": "Derk",
            "last_name": "Snijders",
            "date_of_birth": "1993-10-31 00:00:00",
            "gender": "male",
            "phone": null,
            "description": null,
            "remember_token": null,
            "is_superadmin": 1,
            "is_suspended": null,
            "suspended_reason": null,
            "seo_url": "i3anaan",
            "activated_at": "2017-10-08 00:21:36",
            "created_at": "2017-10-08 00:21:36",
            "updated_at": "2017-10-08 00:21:36",
            "internal_email"<EMAIL_ADDRESS>            "first_name_simple": "Derk",
            "last_name_simple": "Snijders",
            "bodies": [
                {
                    "id": 2,
                    "type_id": 1,
                    "address_id": 2,
                    "name": "AEGEE-Enschede",
                    "email"<EMAIL_ADDRESS>                    "phone": null,
                    "description": null,
                    "legacy_key": "ENS",
                    "created_at": "2017-10-08 00:21:36",
                    "updated_at": "2017-10-08 00:21:36",
                    "name_simple": "AEGEE-Enschede",
                    "pivot": {
                        "user_id": 2,
                        "body_id": 2
                    }
                },
                {
                    "id": 4,
                    "type_id": 3,
                    "address_id": 1,
                    "name": "Comité Directeur",
                    "email"<EMAIL_ADDRESS>                    "phone": null,
                    "description": null,
                    "legacy_key": "DVD",
                    "created_at": "2017-10-08 00:21:36",
                    "updated_at": "2017-10-08 00:21:36",
                    "name_simple": "Comite Directeur",
                    "pivot": {
                        "user_id": 2,
                        "body_id": 4
                    }
                }
            ]
        },
        {
            "id": 4,
            "address_id": 1,
            "personal_email"<EMAIL_ADDRESS>            "first_name": "Sergey",
            "last_name": "Peshkov",
            "date_of_birth": "1985-04-16 00:00:00",
            "gender": "male",
            "phone": null,
            "description": null,
            "remember_token": null,
            "is_superadmin": 0,
            "is_suspended": null,
            "suspended_reason": null,
            "seo_url": "sergey.peshkov",
            "activated_at": "2017-10-08 00:21:36",
            "created_at": "2017-10-08 00:21:36",
            "updated_at": "2017-10-08 00:21:36",
            "internal_email": null,
            "first_name_simple": "Sergey",
            "last_name_simple": "Peshkov",
            "bodies": [
                {
                    "id": 1,
                    "type_id": 2,
                    "address_id": 1,
                    "name": "AEGEE-Europe",
                    "email"<EMAIL_ADDRESS>                    "phone": null,
                    "description": null,
                    "legacy_key": "AEU",
                    "created_at": "2017-10-08 00:21:36",
                    "updated_at": "2017-10-08 00:21:36",
                    "name_simple": "AEGEE-Europe",
                    "pivot": {
                        "user_id": 4,
                        "body_id": 1
                    }
                }
            ]
        },
        {
            "id": 5,
            "address_id": 1,
            "personal_email"<EMAIL_ADDRESS>            "first_name": "Grace",
            "last_name": "Hopper",
            "date_of_birth": "1985-04-16 00:00:00",
            "gender": "female",
            "phone": null,
            "description": null,
            "remember_token": null,
            "is_superadmin": 0,
            "is_suspended": null,
            "suspended_reason": null,
            "seo_url": "gracehopper",
            "activated_at": "2017-10-08 00:21:36",
            "created_at": "2017-10-08 00:21:36",
            "updated_at": "2017-10-08 00:21:36",
            "internal_email": null,
            "first_name_simple": "Grace",
            "last_name_simple": "Hopper",
            "bodies": [
                {
                    "id": 2,
                    "type_id": 1,
                    "address_id": 2,
                    "name": "AEGEE-Enschede",
                    "email"<EMAIL_ADDRESS>                    "phone": null,
                    "description": null,
                    "legacy_key": "ENS",
                    "created_at": "2017-10-08 00:21:36",
                    "updated_at": "2017-10-08 00:21:36",
                    "name_simple": "AEGEE-Enschede",
                    "pivot": {
                        "user_id": 5,
                        "body_id": 2
                    }
                },
                {
                    "id": 3,
                    "type_id": 1,
                    "address_id": 3,
                    "name": "AEGEE-Dresden",
                    "email"<EMAIL_ADDRESS>                    "phone": null,
                    "description": null,
                    "legacy_key": "DRE",
                    "created_at": "2017-10-08 00:21:36",
                    "updated_at": "2017-10-08 00:21:36",
                    "name_simple": "AEGEE-Dresden",
                    "pivot": {
                        "user_id": 5,
                        "body_id": 3
                    }
                }
            ],
            "address": {
                "id": 1,
                "country_id": 21,
                "street": "Notelaarsstraat 55",
                "zipcode": "1000",
                "city": "Brussels",
                "created_at": "2017-10-08 00:21:36",
                "updated_at": "2017-10-08 00:21:36"
            },
            "circles": []
        },
        {
            "id": 6,
            "address_id": 1,
            "personal_email"<EMAIL_ADDRESS>            "first_name": "Big",
            "last_name": "Boobs",
            "date_of_birth": "1998-04-16 00:00:00",
            "gender": "female",
            "phone": null,
            "description": null,
            "remember_token": null,
            "is_superadmin": 0,
            "is_suspended": null,
            "suspended_reason": null,
            "seo_url": "boobies",
            "activated_at": "2017-10-08 00:21:36",
            "created_at": "2017-10-08 00:21:36",
            "updated_at": "2017-10-08 00:21:36",
            "internal_email": null,
            "first_name_simple": "Big",
            "last_name_simple": "Boobs",
            "bodies": [
                {
                    "id": 1,
                    "type_id": 2,
                    "address_id": 1,
                    "name": "AEGEE-Europe",
                    "email"<EMAIL_ADDRESS>                    "phone": null,
                    "description": null,
                    "legacy_key": "AEU",
                    "created_at": "2017-10-08 00:21:36",
                    "updated_at": "2017-10-08 00:21:36",
                    "name_simple": "AEGEE-Europe",
                    "pivot": {
                        "user_id": 6,
                        "body_id": 1
                    }
                }
            ]
        },
        {
            "id": 1,
            "address_id": 1,
            "personal_email"<EMAIL_ADDRESS>            "first_name": "Super",
            "last_name": "Admin",
            "date_of_birth": "1985-04-16 00:00:00",
            "gender": "other",
            "phone": null,
            "description": null,
            "remember_token": "8HVVHJW8DxYAkXiMZGClVTlOJIeDK1n5QTjJJBRa6Zo4zBzmdGiqMmEHJikW",
            "is_superadmin": 1,
            "is_suspended": null,
            "suspended_reason": null,
            "seo_url": "superadmin",
            "activated_at": "2017-10-08 00:21:36",
            "created_at": "2017-10-08 00:21:36",
            "updated_at": "2017-10-08 00:21:36",
            "internal_email": null,
            "first_name_simple": "Super",
            "last_name_simple": "Admin",
            "bodies": [
                {
                    "id": 1,
                    "type_id": 2,
                    "address_id": 1,
                    "name": "AEGEE-Europe",
                    "email"<EMAIL_ADDRESS>                    "phone": null,
                    "description": null,
                    "legacy_key": "AEU",
                    "created_at": "2017-10-08 00:21:36",
                    "updated_at": "2017-10-08 00:21:36",
                    "name_simple": "AEGEE-Europe",
                    "pivot": {
                        "user_id": 1,
                        "body_id": 1
                    }
                }
            ]
        },
        {
            "id": 3,
            "address_id": 1,
            "personal_email"<EMAIL_ADDRESS>            "first_name": "Nico",
            "last_name": "Westerbeck",
            "date_of_birth": "1985-04-16 00:00:00",
            "gender": "male",
            "phone": null,
            "description": null,
            "remember_token": "FzyYuM0gj0lssFT3blfx1sSo8b1LqASCI6L5PwLL2Xa3sDJD4viA9rr4O3CG",
            "is_superadmin": 0,
            "is_suspended": null,
            "suspended_reason": null,
            "seo_url": "blacksph3re",
            "activated_at": "2017-10-08 00:21:36",
            "created_at": "2017-10-08 00:21:36",
            "updated_at": "2017-10-08 00:21:36",
            "internal_email": null,
            "first_name_simple": "Nico",
            "last_name_simple": "Westerbeck",
            "address": {
                "id": 1,
                "country_id": 21,
                "street": "Notelaarsstraat 55",
                "zipcode": "1000",
                "city": "Brussels",
                "created_at": "2017-10-08 00:21:36",
                "updated_at": "2017-10-08 00:21:36"
            },
            "bodies": [
                {
                    "id": 3,
                    "type_id": 1,
                    "address_id": 3,
                    "name": "AEGEE-Dresden",
                    "email"<EMAIL_ADDRESS>                    "phone": null,
                    "description": null,
                    "legacy_key": "DRE",
                    "created_at": "2017-10-08 00:21:36",
                    "updated_at": "2017-10-08 00:21:36",
                    "name_simple": "AEGEE-Dresden",
                    "pivot": {
                        "user_id": 3,
                        "body_id": 3
                    }
                }
            ],
            "circles": [
                {
                    "id": 5,
                    "body_id": 3,
                    "parent_id": 1,
                    "name": "IT Germany",
                    "description": null,
                    "created_at": "2017-10-08 00:21:36",
                    "updated_at": "2017-10-08 00:21:36",
                    "name_simple": "IT Germany",
                    "pivot": {
                        "user_id": 3,
                        "circle_id": 5
                    }
                }
            ]
        }
    ],
    "message": null
}

For this, would it help you to have the graph you asked me (and that I wrote but not scanned and sent yet) ?

From a frontend side it would be much more valuable to include POST permissions in this request, as specific editing would mostly happen from the single view and not from the listing. Maybe some less complicated entities such as body types could have it directly in the listing... But still looks nice.

@linuxbandit Not really, it is hardcoded and demo now anyway, this is more a technological implementation than a real model of AEGEE
@blacksph3re I am not sure if I understand you correctly, when requesting an object (with GET), you already want the permissions you would have for an edit? (POST). I can see that making sense, and might actually be somewhat feasible as it concerns the same context, will look into it.

Yeah, when requesting a single one it makes sense from the workflow to have post permissions especially, because the user would not go straight to editing there. Editing would most likely happen with a get of that single resource in between so on the single resource put and delete permissions would be nice to have =)

*when requesting a single one => when requesting a listing

@blacksph3re Ok!, I updated the JIRA issue for it.
https://oms-project.atlassian.net/projects/CORE/issues/CORE-141?filter=allopenissues&orderby=created+DESC%2C+priority+ASC%2C+updated+DESC


Why is there no example data after logging in to the superset system

I installed the boot system according to the documentation（Execute docker-compose -f docker-compose-non-dev.yml up command）, Why is there no example data after logging in to the superset system ?

Could you provide logs docker-compose logs eg. via GitHub Gist?

Could you provide logs docker-compose logs eg. via GitHub Gist?

And after executing docker-compose -f docker-compose.yml up, the webpage displays an error.

You can try it out according to the steps in the documentation，Replace docker-compose -f docker-compose-non-dev.yml up with docker-compose -f docker-compose.yml up

I had the same experience. In my case it was caused by the lack of building a front-end, because it takes a while to build. You have to wait longer or provide logs of containers.

@ad-m is spot on, this is a common issue that occurs when the frontend hasn't finished building yet.
If you want to quickly try Superset, then I would recommend using docker-compose -f docker-compose-non-dev.yml up. Your screenshot is still showing docker-compose -f docker-compose.yml up instead.
While this is certainly annoying, this isn't a bug that needs fixing or investigation so I'll be closing this issue for now. Please post in Github Discussions or in the Superset Slack if you'd like more help from the community here! (https://superset.apache.org/community has a link to join the Slack)


[python] Add doc for disabling instrumentation for python

Adds docs to Python's auto-instrumentation config and the k8s operator auto-instrumentaiton config for python explaining how to omit specific packages from instrumentation.  This is an important feature in auto-instrumentation as instrumenting everything can lead to too much data or noise.

Prettifying resulted in a lot of extraneous changes.  Opened https://github.com/open-telemetry/opentelemetry.io/pull/2197 to address them separately.

@open-telemetry/operator-approvers and @open-telemetry/python-approvers please take a look!

/cc @srikanthccv @pavolloffay

On a separate note, there are many other (undocumented) config options Python auto instrumentation supports. It will be good to document them under the Agent Config section.

@srikanthccv yes, agreed! Is there a good list to look at somewhere, even if it's just in code somewhere? I'll want to at least get that documented.

Something I could think of immediately

https://github.com/search?q=repo%3Aopen-telemetry%2Fopentelemetry-python-contrib OTEL_PYTHON&type=code
https://github.com/search?q=repo%3Aopen-telemetry%2Fopentelemetry-python-contrib+OTEL_INSTRUMENTATION&type=code

I'll want to at least get that put into an issue.

Please do. There are probably more options buried inside the code base. I will add more to issue as I dig more.

Thanks, filed https://github.com/open-telemetry/opentelemetry.io/issues/2214


Memory leak when using @rspack/core API

System Info
  System:
    OS: Linux
    CPU: (16) x64 Intel(R) Xeon(R) Platinum 8255C CPU @ 2.50GHz
    Memory: 19.11 GB / 31.10 GB
    Container: Yes
    Shell: 5.0.2 - /bin/zsh
  Binaries:
    Node: 16.14.0 - ~/.nvm/versions/node/v16.14.0/bin/node
    Yarn: 1.22.19 - ~/.yarn/bin/yarn
    npm: 8.3.1 - ~/.nvm/versions/node/v16.14.0/bin/npm
  npmPackages:
    @rspack/cli: latest => 0.1.10
    @rspack/core: ^0.1.10 => 0.1.10

Details

With webpack

Reproduce link
No response
Reproduce Steps

Create a project npm create rspack@latest
Create a script to compile consecutively with @rspack/core
Run the script to get memory leak

Script content:
const { rspack } = require('@rspack/core')
const config = require('./rspack.config')

function compile() {
    const compiler = rspack(config);
    return new Promise((resolve, reject) => {
        compiler.run((err, stat) => {
            if (err) {
                return reject(err)
            }
            return resolve(stat)
        })
    })
}

async function main() {
    await compile();

    setTimeout(() => {
        const memory = process.memoryUsage();
        console.log(`Total memory used: ${Math.round(memory.rss / 1024 / 1024)} MB`)
        main()
    }, 1000);
}

main().catch(console.error)

Confirmed. How did you discover this? We don't normally import it as a package 🤔

I am currently in the process of migrating a complex build tool that is based on webpack. The tool has the ability to compile multiple projects simultaneously, utilizing webpack's core API. However, when attempting to migrate it to rspack, I encountered a persistent issue of the process being killed due to an OOM error.

bump!

bump

@Nikaple I believe this issue has been mitigated:

But there's still some leaking problem with the Compiler and Compilation. It's under our investigation.

bump

bump

We are also experiencing rapidly growing memory consumption of rspack dev build in watch mode.
After app is tarted we have node process eating around 5.8gb of memory.
After 5-10 mins it can grow up until 10gb sometimes even reaching 12gb :(

We are also experiencing rapidly growing memory consumption of rspack dev build in watch mode. After app is started we have node process eating around 5.8gb of memory. After 5-10 mins it can grow up until 10gb sometimes even reaching 12gb :(

Exactly

We are also experiencing rapidly growing memory consumption of rspack dev build in watch mode. After app is started we have node process eating around 5.8gb of memory. After 5-10 mins it can grow up until 10gb sometimes even reaching 12gb :(

Would you please file another issue? This issue is basically related when creating multiple compilers and the memory not getting freed after that.


Allow different values types on Dimension

Currently Dimension.values only allow lists of values, which can be annoying because often the values are originally in an array or a pandas Series. In addition it would be sensible if the widgets also ignored duplicate values so the user does not have to do explicitly ensure they supply a set of values.

I'm happy to work on this so I've assigned myself.

Hopefully, I addressed this in #859 (merged) so I'll close this issue. I'm happy to re-open if if there are any related problems/requests.


Docs: Create Code of Conduct

Code of Conduct
A short description of what this PR does.
As a User, I want to know the expectations of conduct.
As a Developer, I want users to know the rules, regulations, and enforcement of appropriate/inappropriate conduct.
Yarn Lint

Checklist

[x] I acknowledge that all my contributions will be made under the project's license
[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the Contribution Guidelines and my PR follows them
[x] I have titled the PR appropriately
[x] I have updated my branch with the main branch
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added the necessary documentation about the functionality in the appropriate .md file
[x] I have added inline documentation to the code I modified

💡 Could you add a link to the code of conduct on the readme file?

Generally, the Code of Conduct is not linked to from the Readme file. The file itself is looked for by contributors, and has a specific name for that reason. Meta-documentation such as the Code of Conduct, or a Contribution guide, are placed in files with all upper case names.


Show live status of the cluster in Lens from the MCC API

Not sure how this differentiates from what Lens already shows for the cluster, however...

Will be in v4.0.0 release.


net/haproxy: syslog "local" file socket feature

Adding the following to the syslog plugin in haproxy.inc will allow local logging without privileges:
'local' => '/var/haproxychroot/var/run/log'

Not sure how much needs to be changed on the GUI side.
Note that this core feature won't make it into 16.1.16.

FYI: this core.git feature will be in 16.1.17


[FLINK-34548][API] Introduce DataStream, Partitioning and ProcessFunction

What is the purpose of the change
This is the first PR for DataStream V2, and aim to  implement FLIP-409: DataStream V2 Building Blocks: DataStream, Partitioning and ProcessFunction
Brief change log

Introduce four type of streams in FLIP-409.
Introduce ProcessFunction and all it's variants.
Introduce new ExecutionEnvironment to submit job written in the new API.
Supports FLIP-27 based Source and Sink-v2.

Verifying this change
This change added new tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
Documentation needs to be added in subsequent PR.

@reswqa Thanks for the update. LGTM!


JwtAccess Credentials Feature

Tracking completion of implementation of JwtAccess Credentials for service accounts for PHP. This is a service account that passes a JWT directly as an a bearer token instead of exchanging for an access token.
For reference, the Java implementation:
https://github.com/google/google-auth-library-java/blob/master/oauth2_http/java/com/google/auth/oauth2/ServiceAccountJwtAccessCredentials.java

Already fixed by #44 ?

That's correct,  #44 add this.
I will close this bug, but please re-open with more detail if you're referring to something else


Define PRIV Types

See here
These definitions are used to populate the actions menu, sidebar, demand builder options, etc.
Created an issue to track the evolution of this, I'm not sure if how I'm doing it right now is the best way. Some requirements to consider:

Should eventually support multiple languages
Should be iterable

This file should directly replace the dictionary file Clémentine and I made. No need to keep our format - we didn't really knwo what would be usefull. What you have here is good.
Just no need to have two. Simply replace the old one with this.

If we opt for using Stoplight/Prism and write OpenAPI definitions, those can be directly generated using something like https://github.com/drwpow/openapi-typescript

@jboileau99 with regards to the responses to privacy requests, like this one

{
"response-id": "6c0dd4b4-4814-4883-84c0-9864e85fecff",
"in-response-to": "79d0b652-183e-47f5-ac37-35227fee4cf8",
"date": "2019-08-24T14:15:22Z",
"system": "http://example.com",
"requested-action": "TRANSPARENCY.POLICY",
"data-subject": {
"dsid-schema": "string",
"dsid": "string"
},
"status": "GRANTED",
"motiv": "VALID-REASONS",
"answers": "string",
"message": "string",
"lang": "en",
"includes": [
null
],
"data": {}
}

Please note that when the request is granted, there is no need to giving a motive. Motive is optional - and expected when the request is not GRANTED.
I updated PRIV with this note in the latest update.

@milstan When a privacy request contains more than one demand, will there be a privacy response for each demand (identified by demand-id)? This is how I interpreted it from the priv spec, but wanted to make sure

There will be one Response for the Privacy Request (in-response-to: request ID), that will have for incldues multiple Privacy Request Responses, each having for in-response-to the demand-id to which they are the reponse.
It's a nested structure.
Also, in the context of coordinated responses. A Repnse made to a particular demand can also include other resposnes (to the same demand) made other systems.

It should have mutpile nested response. For each of those it should have a unique data or message that responds to the particular demand.

Discussed new response structure with @m4rk055, will update stoplight on Monday

Moved this to milestone v0.5. The request + response structure will change very often in the early stages of development, so it's easier initially to manually define and modify the types.


Test_terminal_scrollback fails if terminal > 125 lines

If I try to build vim with my terminal taller than 125 lines, as seen with tput lines, I get this failure:
From test_terminal.vim:
Found errors in Test_terminal_scrollback():
function RunTheTest[38]..Test_terminal_scrollback line 13: Expected range 91 - 100, but got 90
TEST FAILURE
make: *** [report] Error 1

If I increase lines further to 147, you can see the value at the end of the error change:
From test_terminal.vim:
Found errors in Test_terminal_scrollback():
function RunTheTest[38]..Test_terminal_scrollback line 13: Expected range 91 - 100, but got 80
TEST FAILURE
make: *** [report] Error 1

If I decrease my terminal to 125 lines or less, the test passes and vim builds OK.
I'm building the latest git commit as of the time of writing this, which is 833093bfb0e4a7f89b5adc66babcfa8ac09cfda9 or Vim v8.1.0022.  I've had this trouble for some time, though.
My build process is:
make clean
./configure --prefix "${HOME}/local" --with-features=huge --enable-rubyinterp=no --enable-pythoninterp=yes --with-python-config-dir=/usr/lib/python2.7/config-x86_64-linux-gnu --disable-netbeans --disable-gpm --enable-multibyte --with-x --disable-selinux
make -j8
pushd src/testdir
make clean
make nongui  # <-- failure happens in unit tests here
popd
make install

Here's my bugreport.txt header:
uname -a
Linux u480fcf3b680b56e1fd20 4.4.0-109-generic #132~14.04.1-Ubuntu SMP Tue Jan 9 21:46:42 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

VIM - Vi IMproved 8.1 (2018 May 17, compiled May 24 2018 12:08:16)
Included patches: 1-22
Compiled by tjk@u480fcf3b680b56e1fd20
Huge version without GUI.  Features included (+) or not (-):
+acl               +cmdline_compl     -ebcdic            -hangul_input      -lua               +mouse_xterm       +python            +tag_binary        +vertsplit         -xpm
+arabic            +cmdline_hist      +emacs_tags        +iconv             +menu              +multi_byte        -python3           +tag_old_static    +virtualedit       +xsmp_interact
+autocmd           +cmdline_info      +eval              +insert_expand     +mksession         +multi_lang        +quickfix          -tag_any_white     +visual            +xterm_clipboard
-autoservername    +comments          +ex_extra          +job               +modify_fname      -mzscheme          +reltime           -tcl               +visualextra       -xterm_save
-balloon_eval      +conceal           +extra_search      +jumplist          +mouse             -netbeans_intg     +rightleft         +termguicolors     +viminfo
+balloon_eval_term +cryptv            +farsi             +keymap            -mouseshape        +num64             -ruby              +terminal          +vreplace
-browse            +cscope            +file_in_path      +lambda            +mouse_dec         +packages          +scrollbind        +terminfo          +wildignore
++builtin_terms    +cursorbind        +find_in_path      +langmap           -mouse_gpm         +path_extra        +signs             +termresponse      +wildmenu
+byte_offset       +cursorshape       +float             +libcall           -mouse_jsbterm     -perl              +smartindent       +textobjects       +windows
+channel           +dialog_con        +folding           +linebreak         +mouse_netterm     +persistent_undo   +startuptime       +timers            +writebackup
+cindent           +diff              -footer            +lispindent        +mouse_sgr         +postscript        +statusline        +title             +X11
+clientserver      +digraphs          +fork()            +listcmds          -mouse_sysmouse    +printer           -sun_workshop      -toolbar           +xfontset
+clipboard         -dnd               +gettext           +localmap          +mouse_urxvt       +profile           +syntax            +user_commands     -xim
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
  fall-back for $VIM: "/home/local/ANT/tjk/local/share/vim"
Compilation: gcc -std=gnu99 -c -I. -Iproto -DHAVE_CONFIG_H     -march=native -pipe -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc -std=gnu99   -L/usr/local/lib -Wl,--as-needed -o vim    -lSM -lICE -lXt -lX11 -lXdmcp -lSM -lICE  -lm -ltinfo -lnsl   -ldl    -L/usr/lib/python2.7/config-x86_64-linux-gnu -lpython2.7 -lpthread -ldl -lutil -lm -Xlinker -export-dynamic -Wl,-O1 -Wl,-Bsymbolic-functions

If I try to build vim with my terminal taller than 125 lines, as seen with tput lines, I get this failure:
>From test_terminal.vim:
Found errors in Test_terminal_scrollback():
function RunTheTest[38]..Test_terminal_scrollback line 13: Expected range 91 - 100, but got 90
TEST FAILURE
make: *** [report] Error 1

If I increase lines further to 147, you can see the value at the end of the error change:
>From test_terminal.vim:
Found errors in Test_terminal_scrollback():
function RunTheTest[38]..Test_terminal_scrollback line 13: Expected range 91 - 100, but got 80
TEST FAILURE
make: *** [report] Error 1

If I decrease my terminal to 125 lines or less, the test passes and vim builds OK.

Please try this simple change:
--- /home/mool/vim/git/vim81/src/testdir/test_terminal.vim	2018-05-15 23:53:22.100994659 +0200
+++ testdir/test_terminal.vim	2018-05-25 21:32:34.698182317 +0200
@@ -270,7 +270,7 @@
endfunc
func Test_terminal_scrollback()

let buf = Run_shell_in_terminal({})

let buf = Run_shell_in_terminal({'term_rows': 15})
set termwinscroll=100
call writefile(range(150), 'Xtext')
if has('win32')

Let me know if that fixes the problem.
--
At some point in the project somebody will start whining about the need to
determine the project "requirements".  This involves interviewing people who
don't know what they want but, curiously, know exactly when they need it.
(Scott Adams - The Dilbert principle)
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

That does fix it, thank you!  I tried with my terminal at 48, 73, 125, 126, and 147 lines, and all were successful.


Bug in passing certain parameter types using "azure/arm-deploy@v1" to an Azure bicep file

I have a workflow that consists of two jobs:
Job1:
A step in the first job calls a bicep script file to create a vnet (Virtual Network). The bicep creates the vnet and a number of subnets together with vnet ID and outputs them to the caller. Here are the types and sample info that the bicep returns:
output frontendSubnet object=vnet.properties.subnets[0]
output backendSubnet object=vnet.properties.subnets[1]
output vnetId string=vnet.id
Sample frontendSubnet info
{"name":"backendSubnet","id":"/*****************************/resourceGroups/GithubWorkflowIssue/providers/Microsoft.Network/virtualNetworks/vnet-cosmo-epvypfxupyhic/subnets/backendSubnet","etag":"W/"40085f0c-f1c4-4bd2-93a5-d9ddf8f40834"","properties":{"provisioningState":"Succeeded","addressPrefix":"<IP_ADDRESS>/24","delegations":[],"privateEndpointNetworkPolicies":"Disabled","privateLinkServiceNetworkPolicies":"Enabled"},"type":"Microsoft.Network/virtualNetworks/subnets"}
Sample vnetId
/subscriptions/*************/resourceGroups/GithubWorkflowIssue/providers/Microsoft.Network/virtualNetworks/vnet-cosmo-epvypfxupyhic
Job 2:
The outputs from the step in job 1 are used to call another bicep script:

uses: azure/arm-deploy@v1
name: Run preflight validation
with:
deploymentName: ${{ github.run_number }}
resourceGroupName: ${{ inputs.resourceGroupName }}
template: ./deploy/azure_sql_private_endpoint.bicep
parameters: >
vnetId=${{ needs.deploy-vnet.outputs.vnetId }}
frontendSubnet=${{ needs.deploy-vnet.outputs.frontendSubnet }}
backendSubnet=${{ needs.deploy-vnet.outputs.backendSubnet }}

The issue is that the deploy step does not dispatch those parameters correctly and Azure ARM cannot interpret them and throws errors as shown below. It looks like it has trouble with "object" types and multiple "/" in strings. I have created a simplified version of the situation here where you can experiment for yourself, just make sure to change the "resourceGroupName" in "workflow.yaml" and also set up your Azure application and Githup to Azure federated credentials:
https://github.com/gary-RR/github_workflow_issues
Errors in Azure deployment logs
Run azure/arm-deploy@v1
with:
deploymentName: 6
resourceGroupName: GithubWorkflowIssue
template: ./deploy/azure_sql_private_endpoint.bicep
parameters: vnetId= frontendSubnet= backendSubnet=
Validating template...
Warning: ERROR: Failed to parse string as JSON:
Error detail: Expecting value: line 1 column 1 (char 0)
Warning: Template validation failed.
Creating deployment...
Error: ERROR: Failed to parse string as JSON:
Error detail: Expecting value: line 1 column 1 (char 0)

Do these issues actually and actively being looked at? This issue is a serious one and a stopper for us. Thanks.


SPS is Low

Hi!!
I'm testing this library, but I can't got the 860SPS, using SingleShot and by reading 0_GND, 1_GND and 2_GND, 3_GND and repeating. SPS is 285 - 307.
Even if I only take only one of them in SingleShot, SPS rises only up to 333.
Also I'm getting some crosstalk I think, and using a capacitor isn't an option since I'm measuring AC voltaje.
Any ideas I can try??
Thanks a lot!!
#include<ADS1115_WE.h>
#include<Wire.h>
ADS1115_WE ads1(0x48);

void setup() {
  // put your setup code here, to run once:
  Wire.begin();

  Serial.begin(115200);

  if(!ads1.init()){
    Serial.println("ADS1 not connected!");
  }
  ads1.setVoltageRange_mV(ADS1115_RANGE_4096);
  ads1.setConvRate(ADS1115_860_SPS);

  delay(1000);
}

void loop() {

  long start = millis();

  double sample1 = readADC(ads1, ADS1115_COMP_0_GND);

  double sample2 = readADC(ads1, ADS1115_COMP_1_GND);

  double sample3 = readADC(ads1, ADS1115_COMP_2_GND);

  double sample4 = readADC(ads1, ADS1115_COMP_2_GND);

  Serial.println("Analog 0: "); Serial.println(sample1);
  Serial.print("Analog 1: "); Serial.println(sample2);
  Serial.print("Analog 2: "); Serial.println(sample3);
  Serial.print("Analog 3: "); Serial.println(sample4);
  Serial.print("SPS :"); Serial.println(1000*4/(millis()-start));

}

float readADC(ADS1115_WE adc, ADS1115_MUX channel) {
  float voltage = 0.000;
  adc.setCompareChannels(channel);
  adc.startSingleMeasurement();
  while(adc.isBusy()){}
  voltage = adc.getResult_mV(); // alternative: getResult_mV for Millivolt
  return voltage;
}

Interesting one! The answer is you are measuring mainly the speed of the Serial.print / Serial.println function and the I"C connection.

Serial.print / Serial.println
I took out everything related with the ADS1115 after the setup. The readADC only returns 2.0 (just any number). The "SPS" for this was 666 on an Arduino Uno, which is amazingly slow.

#include<ADS1115_WE.h>
#include<Wire.h>
ADS1115_WE ads1(0x48);

void setup() {
  // put your setup code here, to run once:
  Wire.begin();

  Serial.begin(115200);

  if(!ads1.init()){
    Serial.println("ADS1 not connected!");
  }
  ads1.setVoltageRange_mV(ADS1115_RANGE_4096);
  ads1.setConvRate(ADS1115_860_SPS);

  delay(1000);
}

void loop() {

  long start = millis();

  double sample1 = readADC(ads1, ADS1115_COMP_0_GND);

  double sample2 = readADC(ads1, ADS1115_COMP_1_GND);

  double sample3 = readADC(ads1, ADS1115_COMP_2_GND);

  double sample4 = readADC(ads1, ADS1115_COMP_2_GND);

  Serial.println("Analog 0: "); Serial.println(sample1);
  Serial.print("Analog 1: "); Serial.println(sample2);
  Serial.print("Analog 2: "); Serial.println(sample3);
  Serial.print("Analog 3: "); Serial.println(sample4);
  Serial.print("SPS :"); Serial.println(1000*4/(millis()-start));

}

float readADC(ADS1115_WE adc, ADS1115_MUX channel) {
//  float voltage = 0.000;
//  adc.setCompareChannels(channel);
//  adc.startSingleMeasurement();
//  while(adc.isBusy()){}
//  voltage = adc.getResult_mV(); // alternative: getResult_mV for Millivolt
  return 2.0;
}

without Serial.print/println
In a second experiment I took out all Serial.print / println (between the measures).  The sketch does 4 times 860 mesasurements and determines the time needed. Should be 1 second (after divided by 4), but it needed 2.69.

#include<ADS1115_WE.h>
#include<Wire.h>
ADS1115_WE ads1(0x48);

void setup() {
  // put your setup code here, to run once:
  Wire.begin();

  Serial.begin(115200);

  if(!ads1.init()){
    Serial.println("ADS1 not connected!");
  }
  ads1.setVoltageRange_mV(ADS1115_RANGE_4096);
  ads1.setConvRate(ADS1115_860_SPS);

  delay(1000);
}

void loop() {

  long start = millis();

  for(int i=0; i<860; i++){
    double sample1 = readADC(ads1, ADS1115_COMP_0_GND);

    double sample2 = readADC(ads1, ADS1115_COMP_1_GND);

    double sample3 = readADC(ads1, ADS1115_COMP_2_GND);

    double sample4 = readADC(ads1, ADS1115_COMP_2_GND);
}

  long timefor860Samples = (millis()-start)/4;
  Serial.print("Time needed 860 samples:"); Serial.println(timefor860Samples);
}

float readADC(ADS1115_WE adc, ADS1115_MUX channel) {
  float voltage = 0.000;
  adc.setCompareChannels(channel);
  adc.startSingleMeasurement();
  while(adc.isBusy()){}
  voltage = adc.getResult_mV(); // alternative: getResult_mV for Millivolt
return voltage;
}

I2C connection
In a third experiment I have taken the last sketch and just took out the measurement itself. The result was 1.35 seconds. The difference is 1.34 seconds which is the measurement time plus the time to send the instruction to measure.

float readADC(ADS1115_WE adc, ADS1115_MUX channel) {
  float voltage = 0.000;
  adc.setCompareChannels(channel);
//  adc.startSingleMeasurement();
//  while(adc.isBusy()){}
  voltage = adc.getResult_mV(); // alternative: getResult_mV for Millivolt
return voltage;
}

If you want to speed up the time do use the alert pin for conversion ready check. Have a look into the example sketch "Single_Shot_Conv_Ready_Alert_Controlled.ino". Long answer, but I was also keen to look into the details where all the time is gone.

Thanks for everything! I will continue to do more testing ... And Damn! I didn't route the alert pin on the board as I thought I wouldn´t need it.

Good luck!


Add resizable UI indicator

Add this little thing to the bottom right of all windows in game to let people know subtly that they are resizable.

Personally I'd rather the mouse cursor change when hovering over resize areas so you implicitly figure it out after a few minutes.

Personally I'd rather the mouse cursor change when hovering over resize areas so you implicitly figure it out after a few minutes.

That's terrible UX. User should not assume things, they should be obvious

Not sure if I would consider that terrible UX, but I can see a few people being confused.
Changing the cursor when hovering a resizable container should be trivial after I get my PR in. Considering that the UI containers know their dimensions/root corner by nature I think adding a small carrot like that wouldn't be too bad.

That's terrible UX. User should not assume things, they should be obvious

I mean, basically every desktop platform nowadays does it like this. That said I do suppose there is an argument to be made here because not every window is resizable.
Actually fitting in the resizable indicator shouldn't be the end of the world, since the UI design mockups I made (and still have to implement) don't have window contents be a simple box anymore anyways, so fitting them in shouldn't be too annoying.

I guess i'll just assign this to PJB so he remembers to add this when he gets around to implementing the UI changes.


Issue while using the slot based system in a save and load menu layout.

I want to have two menus on the same scene, one for the loading slots and one for saving slots.
I figured that this needs two save slot managers, one for the loading and the saving. But whenever I run the game, one of the slot managers gets automatically deleted.
I tried to have two SSBS, based on a recommendation in the forum, but that makes both the savemanager and the saveslotmanager get deleted. This happens right as I run the game.
Here's a link to my hierarchy https://www.imgur.com/Zvcu9kp and this one after I run the game https://www.imgur.com/wLOYE7M
I have a Save menu script on ‘Load’ game object and another one on ‘Save’ object. And the ‘SaveSlotManager’ has a save slot manager script that points to ‘Buttons’ game object, also, ‘LoadSlotManager’ has another save slot manager script that points to ‘LoadButtons’ game object.

Before I give you any concrete advice, can you show me a mockup of what you
want your menus to look like? Based on those screenshots you sent, it
doesn't really look like you're trying to have two separate menus.
On Sun, Aug 30, 2020 at 5:10 PM Raymanz<EMAIL_ADDRESS>wrote:

I want to have two menus on the same scene, one for the loading slots and
one for saving slots.
I figured that this needs two save slot managers, one for the loading and
the saving. But whenever I run the game, one of the slot managers gets
automatically deleted.
I tried to have two SSBS, based on a recommendation in the forum, but that
makes both the savemanager and the saveslotmanager get deleted. This
happens right as I run the game.
Here's a link to my hierarchy https://www.imgur.com/Zvcu9kp and this one
after I run the game https://www.imgur.com/wLOYE7M
I have a Save menu script on ‘Load’ game object and another one on ‘Save’
object. And the ‘SaveSlotManager’ has a save slot manager script that
points to ‘Buttons’ game object, also, ‘LoadSlotManager’ has another save
slot manager script that points to ‘LoadButtons’ game object.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/CG-Tespy/Fungus-Slot-based-Save-System/issues/6, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFLBGF7OKHJKFE3WQ5RZLRDSDK525ANCNFSM4QP2YF3A
.

Here's what I mean by two menus, https://imgur.com/7pzOl3y and https://imgur.com/sdyCLMh
Changing from menu to menu happens by hiding one and showing another (using the alpha value). so, for example, the 'Save' button sets the 'Save' game object's alpha to 1 and all the other objects' alpha to 0.

Ah, I think I get it now. As the system is now, it only allows one set of save slots to exist at any one time. I'll look into this and see if I can think up a workaround

I would really appreciate that!

Ah, I think I get it now. As the system is now, it only allows one set of save slots to exist at any one time.

I noticed that because when I worked on the main menu (it has only a load menu) it works perfectly. But when working on this pause menu, I found myself stuck and here I am, scratching my head.

I've found a solution. Here are the steps.

Make sure there's ever only one SaveManager and one SaveMenu component in your scene at any given time.
1a. Make it so only one of your menus has the SaveMenu component
1b. Make sure the SaveManager is not parented to any menu
Replace the SaveSlotManager's script's contents with what you see here.
Make sure each slot-having menu has its own SaveSlotManager component set up
Replace the SaveMenu script's contents with what you see here.

It's a bit of a hacky solution, but I managed to make it work on my end. If any further issues arise, please let me know :)

Works like a charm! Thank you so so much mate !


Understanding the code

def preprocess_input(x, v2=True):
    x = x.astype('float32')
    x = x / 255.0
    if v2:
        x = x - 0.5
        x = x * 2.0
    return x

I know x/255 is normalizing the image.
What is the purpose of x-0.5 and x*2.0

Hi since the image is normalized [0, 1] you then move it to [-.5, .5] and the finally you scaled it by [-1 ,1].


python312Packages.faraday-plugins: 1.18.0 -> 1.18.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.faraday-plugins is: Security tools report parsers for Faraday
meta.homepage for python312Packages.faraday-plugins is: https://github.com/infobyte/faraday_plugins
meta.changelog for python312Packages.faraday-plugins is: https://github.com/infobyte/faraday_plugins/releases/tag/1.18.1
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.18.1 with grep in /nix/store/3iy41bwlq6692lqk3yy8vx9gab4ywn2s-python3.12-faraday-plugins-1.18.1
found 1.18.1 in filename of file in /nix/store/3iy41bwlq6692lqk3yy8vx9gab4ywn2s-python3.12-faraday-plugins-1.18.1

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath

faraday-agent-dispatcher
faraday-cli
python311Packages.faraday-plugins
python312Packages.faraday-plugins

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/3iy41bwlq6692lqk3yy8vx9gab4ywn2s-python3.12-faraday-plugins-1.18.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.faraday-plugins https://github.com/r-ryantm/nixpkgs/archive/742f600b43b3d9accb808ec75515fe3d8bb89b0a.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/742f600b43b3d9accb808ec75515fe3d8bb89b0a#python312Packages.faraday-plugins

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/3iy41bwlq6692lqk3yy8vx9gab4ywn2s-python3.12-faraday-plugins-1.18.1
ls -la /nix/store/3iy41bwlq6692lqk3yy8vx9gab4ywn2s-python3.12-faraday-plugins-1.18.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages failed to build:

faraday-agent-dispatcher
faraday-agent-dispatcher.dist

6 packages built:

faraday-cli
faraday-cli.dist
python311Packages.faraday-plugins
python311Packages.faraday-plugins.dist
python312Packages.faraday-plugins
python312Packages.faraday-plugins.dist

Maintainer pings
cc @fabaff for testing.

Result of nixpkgs-review pr 326495 run on x86_64-linux 1

8 packages built:

faraday-agent-dispatcher
faraday-agent-dispatcher.dist
faraday-cli
faraday-cli.dist
python311Packages.faraday-plugins
python311Packages.faraday-plugins.dist
python312Packages.faraday-plugins
python312Packages.faraday-plugins.dist


AttributeError: 'Blueprint' object has no attribute 'before_app_first_request'

PDA version
0.4.1
Python version
3.11
Steps to Reproduce
Build the yarn assets with updated python deps
Expected Behavior
It builds
Observed Behavior
  File "/usr/lib/python3.11/site-packages/flask/cli.py", line 64, in find_best_app
    app = app_factory()
          ^^^^^^^^^^^^^
  File "/build/source/deps/powerdns-admin-assets/powerdnsadmin/__init__.py", line 12, in create_app
    from . import models, routes, services
  File "/build/source/deps/powerdns-admin-assets/powerdnsadmin/routes/__init__.py", line 6, in <module>
    from .index import index_bp
  File "/build/source/deps/powerdns-admin-assets/powerdnsadmin/routes/index.py", line 49, in <module>
    @index_bp.before_app_first_request
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Blueprint' object has no attribute 'before_app_first_request'. Did you mean: 'before_app_request'?

I used flask 2.3.3, context: https://github.com/pallets/flask/issues/4605

This issue should be resolved by PR 1705 and is now present in the dev branch.

This was a bad and rushed solution on my part which created new issues. I had to revert the change.


Support for intercepted self invocation

https://issues.redhat.com/browse/CDI-414
To me, this example from JIRA issue perfectly describes what one would want to achieve:
public class TimedMethodBean {

    @Timed(name = "timedMethod")
    public void timedMethod() {
    }

    public void selfInvocationTimedMethod() {
        timedMethod(); //this method call will not be timed :(
    }
}

I have seen this debated repeatedly with arguments for and against self-interception.
There are already conflicting implementations - Weld does not do self-interception (in fact it does quite some hacks to avoid it) while Quarkus does self-interception. Not sure about OWB or what Micronaut impl plans for.
So we might have some conflicts and compatibility breakage with what's already out there.
More importantly though - in both of the above projects, I have seen users coming and asking for the exact opposite behavior ;-)
So there are users expecting both.
If you go for self interception(1), there is no way a user can prevent it if it is undesirable.
If you opt not to have self-interception(2), you can still invoke the method via injected proxy reference which will trigger the interception. I am not sure how to elegantly bypass the issue of (1) unless we'd have some extra annotation (or parameter in binding) but that looks clunky. In case of (2), it has only the downfall that you cannot trigger interception for non-proxied beans, which are effectively dependent and CDI singleton scopes (where singleton can be easily replaced by app scope for this purpose).
With that in mind, I'd lean towards option (2). - spec saying that it is not supposed to work out of the box. But like I said, opinions are for both sides and we already have an impl split. So we could also state that this is non-portable which doesn't solve it but makes it understandable to users.
WDYT @mkouba @Ladicek ?
Side note - not sure if this belongs to CDI or interceptors spec?

I personally find self-interception nice and expected -- until it isn't :-) But you're right in that both options have enthusiastic proponents and opponents, no idea how to solve that situation.
Whether it belongs to CDI or Interceptors, I have no idea, but I'd lean towards Interceptors.

FWIW Micronaut is self invocation (if that is what it is called) by default, however there is a way to switch to proxying to a target instance

As a CDI user with almost no perspective on the spec and current implementation behaviours, my thoughts are:

Explicit self injection of a bean just looks like a bad design pattern/hack/workaround/you name it. If spec said that should work it's fine, one more tool in the belt but I wouldn't advocate usage of the pattern.

public class TimedMethodBean {

    @Inject
    private TimedMethodBean self; //just..ugly
}

To preserve backward compatibility this would have to be configurable. Not sure about all the current implementations but my guess is an opt-in.

Following #2 reasoning, some kind of new annotation or param seems inevitable. That way, as a developer I can clearly communicate the intentions of whether I want self-invocation to be used on a particular bean or not.


License?

Hi @lesovsky thank you for sharing Noisia.
Can you add a license file to the project, please?
(MIT, BSD-3 or Apache 2.0 will be perfect, IMO)

Hi,
BSD-3, 082f461

Perfect, thank you.


Added CSV Emitter

Resolves #1
Added csv crate that can use serde serialiser to emit the data in a csv format.
I was unable to run the code locally but setup some mock data to test the output:
search_engine,make,model,mileage,year,price,url
dodgy_dealer.ie,Lada,Wheel Barrow,5,1980,10,www.lada.com
dodgy_dealer.ie,Lada,Mirage,10,1981,15,www.lada.com

The code in this repo is quite clean & notice you may or may not be Irish also, so happy to collab on any future changes if you want.

Hi @gybrish -- thanks for your PR. It looks good to me - I tried it out locally with real data and it works as expected.
Before merging, would you like to add the csv option to the comment in https://github.com/gybrish/findcar/blob/main/src/args.rs#L51 (this is rendered in the help text if someone runs ./findcar --help? Plesae also add it to the README.md file :). Thanks!

Those should be updated now!

Thanks @gybrish for making those changes and for contributing to the project :)


Fix host_firmware_version issues

Hello, thanks for making the release yesterday. A new issue has unfortunately surfaced.
We have a problem identifying the firmware version because it is converted to a float. This means that a current version like 3.70 is identical to an old version 3.7 and that confuses the update logic.
I also noticed that the minor version is really 16 bits, not 8 bits. AFAIK, this has not been an issue because minor versions have not reached 256 yet. https://lan.developer.lifx.com/docs/information-messages#statewififirmware---packet-19
This PR fixes both issues. It is a breaking change since the type of self.host_firmware_version changes from float to str.

Thanks.  Sorry for not  merging it sooner. Was busy with other things

Will check things out and release it as 0.7.0 later this week.

Released.

Thank you!


Question - How do you connect to the 'dragable_dropped' signal in a script?

Hello!  I'm adding controller support into my game with this inventory system and I need to connect to a signal for when an item has been dropped (from inventory to inventory, not in the world) to update some array math for each time the inventory gains/loses an item.  I dug through the code and saw that there is a dragable_dropped signal, but I've tried every syntax I can think of and can't connect to it in my own script.  Some help on an approach to this would be great!

Hi! The dragable_dropped signal is not really part of the public interface and is only meant to be used internally, but there are public alternatives depending on what you're trying to achieve:

Inventory.item_added and Inventory.item_removed are emitted when items are added/removed from the inventory
CtrlInventoryGrid.item_dropped is emitted when an item is dropped onto a CtrlInventoryGrid

Let me know if these don't work for your use-case.

Hello again.  For some reason, the CtrlInventoryGrid.item_dropped is not emitting in the use case I thought it would.  When moving an item within the same inventory, or moving it from one inventory to another, I have yet to get it to emit.  I've put print statements in a few places to try and track what is going wrong but I've yet to find out why.
I'm on Godot 4.3, and I'm using InventoryGridStacked and CtrlInventoryGridEx.

I did some testing and it seems like the CtrlInventoryGrid.item_dropped is not really working. Working on a fix...

Thank you for looking into it!

Should be fixed in<PHONE_NUMBER>6d11a4db4f79002e55ef137d6f1da8. Please give it a try.


TextEditor

<Please be sure to remove any private information before submitting.>
Repro steps:
<Enter steps to reproduce issue>
Action: appService.showFile
Error type: Error
Error Message: TextEditor(vs.editor.ICodeEditor:1,$model38) has been disposed
Version: 0.9.1
OS: win32

Hi @CarlosTrujillo03,
Thanks for reporting this issue.  This issue should be resolved with our next release with this PR: https://github.com/Microsoft/vscode-azureappservice/pull/714.
This seems to be a duplicate of this issue: https://github.com/Microsoft/vscode-azureappservice/issues/611 so I'm going to close this issue as a dupe.  If that doesn't seem to be the case, please re-open the issue with more information to repro the bug.
Thanks!


Fix typo in extractor Salesforce docs

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2586
Originally created by @hsyyid on 2021-02-16 15:09:23

The Salesforce docs currently list the Select Fields By Default option name as is_sandbox
https://gitlab.com/meltano/meltano/-/blob/master/docs/src/plugins/extractors/salesforce.md#L304

View 2 previous comments from the original issue on GitLab


teardown: Add ICPSHC24-30EU-IL-1 (30W LED driver/dimmer)

The ICPSHC24-30EU-IL-1 seems to be the big brother of
the ICPSHC24-10EU-IL-1 with the only real difference being the power
supply.
This patch takes ludwo88's PR #7 photo's and creates a more appropiate
merge request.
Closes #7
Signed-off-by: Olliver Schinagl<EMAIL_ADDRESS>

Thank you!


global IPv6 addresses leaked into the journal (when invoked by networkmanager)

I think it's b/c NM puts dhcpcd into debug mode - maybe global addresses can generally be ellipsed or only shown when dhcpcd logs to a tty?
https://bbs.archlinux.org/viewtopic.php?id=289820

I think this is more of dhcpcd logging to syslog(3).
The arch systemd service script disables syslog, but the NM plugin does not.
I guess some options would be to provide a nosyslog option and maybe a configure --without-syslog option  as well.
Thoughts?

The dhcpcd service in general frequently show up in logs (but maybe just the "warnings" for carrier changes)
NM possibly could use -q as well, but tends to be very chatty in everything it does (eg. w/ its wpa_supplicant invocation)
Do you think this kind of data needs to be fully logged anywhere when not debugging?
I'd probably just obfuscate the central bytes 1234:xxx:xx:xxx:xx:xx:xx:56/64 - you know you got a global IP and can correlate other data w/ the last byte and on the rare occasion that the actual IP is relevant for inspection, one will have to run dhcpcd in debug mode.

Please don't implement this, or at least go with your original idea of relying on a non-default config option. IP address obfuscation is security theater at best. If one insists on not revealing "secret" information like IP addresses in a log file, then they should rely on other tools like read permissions on the file, syslog.conf(5), or whatever other tools the OS provides. Keeping this information does not violate the "plug and play" ideology either.
Why should one have to run dhcpcd in "debug" mode to see this information? Running code in "debug" mode is an actual, albeit temporary, reduction in security since more code gets executed which means more bugs that can potentially be exploited.
As you said, @rsmarples, DHCP daemons log IPv4 addresses; and I am pretty sure ISC's Kea DHCP daemon (which has DHCPv6 abilities as well) logs IPv6 addresses as it should.

Not "secret", "private" - the  concerned condition was that the journal is frequently (semi-)publically shared for problem analysis, so local read permissions won't cut it.
Obtain what information? Your present publically routable or otherwise IPv6 (and IPv4)?
ip a
Or the complete publically routable IP you got 5 days ago?
Do you intend to surveil a system (that's not meant as a criticism, there're benign reasons for that) with the system-local logs (that, however, is rather silly)?
IPv4 is typically LAN (for non-router systems) and therefore unaffected by these concerns.
I basically don't really care how this leaves the logs - whether generally or w/ a more fine-grained "-q" that's usd by the NM plugin or the NM plugin just replicating the service and going fully "-q".
But the thread starter in the BBS has a point: we cannot ask users to unwittingly expose themselves. And from some little experience, the users that are required to share their journal to find their problem for them are not capable of filtering sensitive data themselves. It cannot show up there (and usually doesn't, eg. NM obfuscates keys etc.)


Migrate project to go modules

Resolves #2019
Supersedes: #1546

@yurishkuro PR updated based on the comments.

star

As it is approved and the build is passing I will merge. Feel free to comment after the merge I will apply fixes in subsequent PR(s).


Support icon_url of Slack incoming webhook

With this PR, you can set icon_url when notifying to Slack.

Confirmed the icon configuration works. Thanks as always @mizzy!

Oops forgot to merge it.


PNG from SVG Buffer fails with "Input buffer has corrupt header: glib: XML parse error"

Possible bug
Is this a possible bug in a feature of sharp, unrelated to installation?

[x] Running npm install sharp completes without error.
[x] Running node -e "require('sharp')" completes without error.

Are you using the latest version of sharp?

[x] I am using the latest version of sharp as reported by npm view sharp dist-tags.latest.

What is the output of running npx envinfo --binaries --system --npmPackages=sharp --npmGlobalPackages=sharp?
  System:
    OS: Windows 10 10.0.19045
    CPU: (12) x64 Intel(R) Core(TM) i5-10500H CPU @ 2.50GHz
    Memory: 43.09 GB / 63.79 GB
  Binaries:
    Node: 22.11.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 4.5.1 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 10.8.3 - C:\Program Files\nodejs\npm.CMD
  npmPackages:
    sharp: ^0.33.5 => 0.33.5

Does this problem relate to file caching?

[x] Adding sharp.cache(false) does not fix this problem.

Does this problem relate to images appearing to have been rotated by 90 degrees?

[x] Using rotate() or keepExif() does not fix this problem.

What are the steps to reproduce?

Use ReactDOMServer.renderToString, ReactDOM.render, ReactDOMServer.renderToStaticMarkup, or a literal string with <svg>... in it.
Attempt to convert the SVG to PNG using various sample codes.

  const svg = ReactDOMServer.renderToString(<SvgComponent />)
  console.log('Rendering composite...')
  const png = sharp(Buffer.from(svg))
    .png()
    .resize(24, 24)
  console.log('Converting to buffer...')
  const buf = await png.toBuffer() // errors here
  console.log('Returning base64...')

I've also tried the simpler
  const svg = ReactDOMServer.renderToString(<SvgComponent />)
  const buffer = await sharp(Buffer.from(svg))
    .png()
    .toBuffer()

Same error.
Error: Input buffer has corrupt header: glib: XML parse error: Error domain 1 code 5 on line 1 column 425 of data: Extra content at the end of the document

You may ask, "why not composite?" Well, see my previous issue.
What is the expected behaviour?
PNG output
Please provide a minimal, standalone code sample, without other dependencies, that demonstrates this problem
"Without dependencies" is hardly possible in the NPM ecosystem, come on now. However, this can be reproduced in the minimal create-react-app as well as the create-next-app (this is a NextJS application.)
Code directly from my app:
import Facebook from '@mui/icons-material/Facebook' // or any other icon
import ReactDOMServer from 'react-dom/server'
import sharp from 'sharp'

const svgToImage = async (SvgComponent: typeof Facebook): Promise<Buffer> => {
  // Also tried all the other render methods, output is valid SVG
  const svg = ReactDOMServer.renderToStaticMarkup(<SvgComponent />)
  return await sharp(Buffer.from(svg))
    .png()
    .toBuffer()
}

Please provide sample image(s) that help explain this problem
Any image from MaterialUI Icons, literally any of them (yes, I looped through the entire namespace to test.) What I want working atm however are <Facebook />, <Instagram /> etc brand logos.

or a literal string with <svg>... in it.

Please can you provide an example string that represents a valid SVG that fails in this manner.

Thanks, this sample string is not valid XML so that's why you're seeing an "XML parse error" message. As you suggest you'll need to (re)move the <style> element as valid SVG must be valid XML, and valid XML must have a single root node.

Mmmm.... I'm having trouble understanding how both Resend.js and NextJS itself manage to display these SVGs, using the sharp library no less, while retaining the style. I suppose they have some magic surrounding forcing the styles into the SVG's individual path/rect/etc, if I had to guess?
How would you recommend I approach this issue then, considering that removing the styling destroys the images (in the case of these brand images, they do not render correctly without the styles.)

Well I suppose if anyone find this later...
The above snipper will get you "close enough", maybe?
The colours are wrong, the images are fuzzy, but hey, it "works"?
Closing as this is apparently just not a feature of sharp, which, fair.


[Event Change] T39 "Purchase Line" - procedure OnBeforeCreateDim()

------------------ Change IntegrationEvent Attribute ----------------------
IncludeSender : true, GlobalVarAccess : true
-------------------------------------------------------------------------------

[IntegrationEvent(TRUE, TRUE)]
local procedure OnBeforeCreateDim(var PurchaseLine: Record "Purchase Line"; var IsHandled: Boolean; CurrFieldNo: Integer)
begin
end;

GlobalVarAccess was deprecated in 16.x, there is concept of protected var instead. You can list here the global vars that have to be protected and accessible from extensions.
Please put the code surrounding the place, where you expect a new event call, as a text not as a screenshot.
It helps us finding the right place quickly if you put enough code to identify the unique place.


Changes to Class do not get applied (even with manual StyleSheet refresh)

I've managed to get most of this crate functional in my project by having a root UI node with a couple of style sheets. I have a system which refreshes my stylesheet on any changes:
fn refresh_style(
    added_nodes: Query<(), Added<Node>>,
    removed_nodes: RemovedComponents<Node>,
    changed_classes: Query<(), Changed<Class>>,
    mut style_sheet: Query<&mut StyleSheet>,
) {
    let root_entity: Entity = ...;
    if !added_nodes.is_empty() || !removed_nodes.is_empty() || !changed_classes.is_empty() {
        style_sheet.get_mut(root_entity).unwrap().refresh();
    }
}

This system runs in Update schedule after all my UI logic is finished. Specifically, it runs after a system which adds/removes a class to a specific node:
fn refresh_panel(
    mut query: Query<&mut Class, With<ControlPanel>>,
    control_targets: ResMut<ControlTargets>,
) {
    if control_targets.is_changed() {
        let mut class = query.single_mut();
        if control_targets.is_empty() {
            class.add("hide");
        } else {
            class.remove("hide");
        }
    }
}

The style is defined as:
.hide {
    display: none;
}

#ControlPanel {
    display: flex;
    width: 400px;
    min-height: 200px;
    align-self: flex-start;
    flex-direction: column;
    background-color: pink;
}

I've verified that this class does indeed get added. If I turn on tracing for bevy_ecss, I do get:
2024-04-30T16:33:11.177898Z TRACE bevy_ecss::system: Applying rule (#ControlPanel) on 1 entities
...
2024-04-30T16:33:11.178392Z TRACE bevy_ecss::system: Tracking element Class("hide"): 1
2024-04-30T16:33:11.178459Z TRACE bevy_ecss::system: Applying rule (.hide) on 1 entities
2024-04-30T16:33:11.178687Z TRACE bevy_ecss::system: StyleSheetState resource changed! Skipping watch tracked entities

However, the observed behavior is that display is always set to flex. Despite the .hide class being added/removed correctly and the style sheet getting refreshed.
At this point I'm not sure if this an issue with my CSS, setup, or the crate. As far as I can tell, my setup and CSS is fine, although my CSS knowledge is a bit outdated; so it's entirely possible the issue is on my end. :)
Any help would be appreciated!

So far, I've tried all of the following, and nothing seems to work:

Putting all style rules in the same .css vs. different .css
Putting a copy of the style sheet on the exact node with the changing class and refreshing that manually
Using .hide instead of hide when adding/removing selectors
Removing display: flex from #ControlPanel
Defining #ControlPanel .hide as an explicit rule

I've been trying to debug the crate on my own, but I'm having trouble understanding how/where the class rules are being applied. Based on my debugging so far, my entity is definitely being picked up by select_entities_node. But I can't find where the class rules are actually being applied after a .refresh() request is sent out.
I've been looking at the examples as well, and as far as I can tell, none of them deal with adding/removing classes dynamically. Is this supported at all?
Any information would be greatly appreciated!

I managed to solve it by defining #ControlPanel.hide as an explicit rule:
#ControlPanel.hide {
    display: none;
}

Note the difference between #ControlPanel.hide and #ControlPanel .hide from my previous comment. 🫠
For some reason, having the class defined globally as .hide doesn't work at all.


Allow modal scrolling on overflow

Closes #1109, Closes #1097

Wow! Good catch! I confirmed the bug on prod, and used the preview link to test your fix. The mobile QA that came out of the issues you linked is much appreciated.

Looks like this might not fix #1097 after some more back and forth, still a valid bug fix here


document move constructor

corresponding code PR: https://github.com/dlang/dmd/pull/16876

DAutoTest doesn't like it because of the new =this syntax:
__stdin.d(3): Error: declaration expected, not `=`


[Discussion] should configurable by user on Daruk.[module] ?

as we all know, React.js have setState to change states. and in our Daruk, how about when user code Daruk.itils.function1 = () => {} and function1 have assigned

If user want extends Daruk by self，maybe use class inherits is best way.
class mydaruk extends Daruk {}

emm, no, my meaning is that if user change utils function which loaded from utils folder, should we log warning or ban this behavior

and the implement of this discussion #58

Well done！tks @Himself65


Issue 190: Document the JSON stringify function in the README

Documented jsonStringify in the project's README so that it can be used by, e.g., customValidations. Also added the keyword "validation" to the package configuration.
Final piece of the puzzle for issue #190.

👍


ng-inspector opening with grey pane (Chrome 41.0.2272.118 64-bit)

Was working for several weeks, then recently it is showing only a grey pane. No errors in Chrome debug tools.

Hey @CamronBute, thanks for the report. Do you have a website you can share that we can replicate the issue with?

@DrewML I do not. It's an internal website to my company that surfaces confidential data. Is there something else I can do? Share the solution, perhaps?

If you know what the solution is, or what's triggering the error, that would definitely be ideal.
Besides that, the best course of action would be to see if you can create a minimal sample application that exhibits the same behavior with ng-inspector, so we can get our hands on something to debug further.

@DrewML Sorry, I meant the code solution :P I will work to get you something that you can test with

@DrewML I have uploaded a neutered version with no data to http://ng-inspector-example.azurewebsites.net/#/ClientToAccount for you to look at

Perfect! Thanks so much for the example @CamronBute. I'll try to take a look as soon as I can. Is it safe to assume that the example will be up for at least a week?

@CamronBute I believe this issue is the same as one I experienced a couple months ago - https://github.com/rev087/ng-inspector/issues/57#issuecomment-67942951
The root cause of the issue is that you have you are bootstrapping (ng-app) on the same element that you are using transclusion on (ng-view). The solution is pretty simple: move your ng-view directive to the parent element (.body-content).
Let me know if that works for you

Transcluding an application root feels a bit of a gray area between expected AngularJS behavior and an accidental one - it's certainly not a common scenario as far as I'm aware. I'll take a look when I get some breathing room, but if Angular supports this, ng-inspector should as well.

@rev087 I'm all on board for supporting it if we can find a way to access the apps $injector. Having said that, I don't know of any other way to grab the $injector besides grabbing it off angular.element(el), but that will not work when you use transclusion on the root element.
I opened a bug with the Angular team on this issue (and so did others), but they mentioned they would prefer to have updated docs for Angular advising people to not do this.
https://github.com/angular/angular.js/issues/10556
https://github.com/angular/angular.js/issues/11421

Thanks for the links, they clarify the issue a lot. The ideal scenario would be to issue a warning against using transclusion in the same element as the ng-app, but detecting this would be tricky.
We could bring this issue up with the angular-hint project, as this is well within its domain.

I have modified the code successfully. It works now. Thank you, guys!
@DrewML Do you still want the app to stay up, or am I free to tear it down?

@CamronBute now that we have zeroed in on the issue you can take it down, thanks again for taking the time to share it :)

@rev087 Beautiful. Thank you!


toggle prolem

hello,
i can not toggle between year, month, week, day view ( just showing month view) , also next and previous buttons are not work ..
thank you ,,

Do you solve it?I have the same problem.

Did you open the console and checkout what the error messages are ?
And put them down here screenshotted, so I can see what we are dealing with?

I have solved the problem ，it's the problem of the path. Thank you all the same


Don't silently fail and try to carry on if s3 connection response fails

To be taken together with https://github.com/ScilifelabDataCentre/dds_web/pull/465 on dds_web.
Instead of continuing execution if the server does not return the required s3 connection details, assert it and raise an exception if something is wrong.
Together with the web PR, I now get this:
Traceback (most recent call last):
  File "/Users/ewels/miniconda3/envs/py3/bin/dds", line 33, in <module>
    sys.exit(load_entry_point('dds-cli', 'console_scripts', 'dds')())
  File "/Users/ewels/miniconda3/envs/py3/lib/python3.7/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/Users/ewels/miniconda3/envs/py3/lib/python3.7/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/Users/ewels/miniconda3/envs/py3/lib/python3.7/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/ewels/miniconda3/envs/py3/lib/python3.7/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/ewels/miniconda3/envs/py3/lib/python3.7/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/Users/ewels/miniconda3/envs/py3/lib/python3.7/site-packages/click/decorators.py", line 33, in new_func
    return f(get_current_context().obj, *args, **kwargs)
  File "/Users/ewels/GitHub/SciLifeLab/dds_cli/dds_cli/__main__.py", line 209, in put
    silent,
  File "/Users/ewels/GitHub/SciLifeLab/dds_cli/dds_cli/data_putter.py", line 64, in put
    silent=silent,
  File "/Users/ewels/GitHub/SciLifeLab/dds_cli/dds_cli/data_putter.py", line 215, in __init__
    self.verify_bucket_exist()
  File "/Users/ewels/GitHub/SciLifeLab/dds_cli/dds_cli/base.py", line 370, in verify_bucket_exist
    with s3.S3Connector(project_id=self.project, token=self.token) as conn:
  File "<string>", line 3, in __init__
  File "/Users/ewels/GitHub/SciLifeLab/dds_cli/dds_cli/s3_connector.py", line 55, in __post_init__
    ) = self.get_s3_info(project_id=project_id, token=token)
  File "/Users/ewels/GitHub/SciLifeLab/dds_cli/dds_cli/s3_connector.py", line 92, in get_s3_info
    ), f"Failed retrieving Safespring project name. Server response: {response.text}"
AssertionError: Failed retrieving Safespring project name. Server response: {
    "message": "[Errno 2] No such file or directory: '/code/dds_web/s3_config_example.json'"
}

Messy - but it's a bit of an edge case error which is critical and importantly the final lines tell me quite quickly and succinctly what went wrong (would be fairly easy to catch AssertionErrors at the top cli level in __main__ and print the messages without the traceback, might add that separately).
Before these two PRs I was getting this traceback instead:
Traceback (most recent call last):
  File "/Users/ewels/miniconda3/envs/py3/bin/dds", line 33, in <module>
    sys.exit(load_entry_point('dds-cli', 'console_scripts', 'dds')())
  File "/Users/ewels/miniconda3/envs/py3/lib/python3.7/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/Users/ewels/miniconda3/envs/py3/lib/python3.7/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/Users/ewels/miniconda3/envs/py3/lib/python3.7/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/ewels/miniconda3/envs/py3/lib/python3.7/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/ewels/miniconda3/envs/py3/lib/python3.7/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/Users/ewels/miniconda3/envs/py3/lib/python3.7/site-packages/click/decorators.py", line 33, in new_func
    return f(get_current_context().obj, *args, **kwargs)
  File "/Users/ewels/GitHub/SciLifeLab/dds_cli/dds_cli/__main__.py", line 209, in put
    silent,
  File "/Users/ewels/GitHub/SciLifeLab/dds_cli/dds_cli/data_putter.py", line 64, in put
    silent=silent,
  File "/Users/ewels/GitHub/SciLifeLab/dds_cli/dds_cli/data_putter.py", line 215, in __init__
    self.verify_bucket_exist()
  File "/Users/ewels/GitHub/SciLifeLab/dds_cli/dds_cli/base.py", line 370, in verify_bucket_exist
    with s3.S3Connector(project_id=self.project, token=self.token) as conn:
  File "/Users/ewels/GitHub/SciLifeLab/dds_cli/dds_cli/cli_decorators.py", line 128, in init_resource
    aws_access_key_id=self.keys["access_key"],
TypeError: 'NoneType' object is not subscriptable

Which had me scratching my head for a little while 😉  Better a useful traceback at the point of error than weird unexpected side effects causing unhelpful tracebacks..

I suspect that there are more of these in the code - they're tough to spot until something breaks, but I will try to keep an eye out for others if I can.