sentence parsing for bracketed goal selectors

fixes #30

Could you add a test or two to tests/test_parse.py?

And also run black to autoformat it

formatted. Could you walk me through adding a test there? I am looking at the table and haven't figured it out yet.

The tuples in tests are (test name, list of lines to use an input, optional starting offset, expected ending offset). So ("multi line", ["A", "B."], (1, 1)) gives "A\nB." to _get_message_range and expects it to find the . on line 1, column 1 as the end.

now I am trying to run the tests... I run tox and see vim run for a bit, and I then get errors for various versions of python not being found, but I think the tests I wrote are not being run. What might I be missing?

this looks green, so I guess I got the tests right blind.

You need python2.7 and python3.6 to run the tests through tox. If you have those and it's still not working then it's possible there's some more weirdness going on since I'm not that experienced with configuring tox and I've only really confirmed it works on my own machine and in the travis tests.
Since this passed the CI tests I'll go ahead and merge.


Legend still needs work in terms of clarifying bubble size (will think on this)

I passed both domain and range values to the legend, but the bubble sizing is an issue (and I'll need to format the domain numbers to be more friendly. Happy to do this with you.


General Questions to Discuss

General Control Panel

[x] Can I see what graphs/categories someone else adds?  Can I use one of your categories to label one of my graphs/tutorials?

Categories Control Panel

[x] What categories do you envision?  Can these be added to graphs/tutorials later?

Graph Control Panel

[x] What exactly do you expect for the URL?
[x] Link to the JSON doc for cytoscape -- do we need to add the cytoscape({ and other preambles?
[x] Anything special about the name? Any characters not allowed?
[x] For Priority: should there be only one main graph for a tutorial?  Are priorities between graphs and tutorials tracked?
[x] Can I view an unpublished graph? Is there a way to check graphs and tutorials before publishing?
[x] When I submit and it's successfully uploaded, it should return to the Control Panel Graphs page.
[x] Is there any JSON checker?
[x] When it's successfully uploaded, I get a  card on Graphs (looks like it's because it's
unpublished).
[x] How do we upload graph information and citation?
[x] When I publish the graph, I can see the graph and interact with it (I get an error saying there's no code associated with it). However, on the Graphs page it still says . Further, the title isn't being populated in the tutorial view. Ahh - need to update the Graph Info. (What happens if Graph Info is published and Graph is not??)

[ ] Filter by categories not working yet.
[ ] Long-term (if even needed) -- allow users to upload tab-delimited graph and do JSON converting on the back-end.
[ ] Add the docs url to Graphery in places. ("getting started" category: Tutorials on (a) navigating, (b) what's a graph? (c) how to contribute)

[ ] Copy Relative URL link broken on Uploads page.


Wrong parameter approval_prompt

With referrer to the documentation https://developers.google.com/identity/protocols/oauth2/web-server#httprest
the Parameter must be 'prompt' instead of 'approval_prompt'. Please fix this, because 'prompt' is not accepted by the server.
https://github.com/googleapis/google-api-php-client/blob/11871e94006ce7a419bb6124d51b6f9ace3f679b/src/Client.php#L646

We've updated the OAuth2 URL to V2, which accepts prompt=force. See https://github.com/googleapis/google-api-php-client/pull/2275.


Add Pwndbg to Reversing Tools

Hello, I'm the maintainer of Pwndbg (pwndbg.com / github.com/pwndbg/pwndbg).
It's a useful GDB extension like PEDA and GEF, you should add it to your list!
Thanks!

Thanks a lot, this has been added to reversing section of the list.


bug: Overlapped markers ids should be shown on the drawer

Bug Definition
Currently overllapping markers are shown as one marker and there is no id information of the overlapped one on the drawer.
This issue was fixed on the old version and we have to fix it for this one as well.
** discord username: @Mustafa Aksu#2130 **
## Bug environment
rc.afetharita.com
Describe how you are producing the bug step by step

Go to rc.afetharita.com
Find overlapping markers
Click on the marker

Expected Behaviour
Should show overlapped and overlapping IDs on the drawer.
This issue is not OS/Browser/Version related. It is a code logic error.
Desktop Information

Operating System: WINDOWS
Browser : Chrome
Version : latest

User can't click on the other markers which share the exact same coordinates (overlapped).


[libra framework] simplifying AccountLimits initialization

Deleting AccountLimits::initialize() and moving publishing of the currency-specific LimitsDefinition's into the Coin1, Coin2, and LBR modules.
This ensures that every registered currency has a LimitsDefinition. I thought about putting this in Libra::register_currency instead, but thought currency-specific seemed better. Reason 1: we might want currency-specific limits, and this gives us the flexibility to do that. Reason 2: Don't want to add too much responsibility to the Libra module, which already defines coins and their registration.

I will wait for @wrwg's https://github.com/libra/libra/pull/5092 to make sure this minor change doesn't conflict with all of the excellent new specs/verification added there.

:umbrella: The latest upstream changes (presumably e33d6e6def8b6ae4ca7112a4224e3c1e4b582557) made this pull request unmergeable. Please resolve the merge conflicts.

:umbrella: The latest upstream changes (presumably ce164585c0ea04f0ec259d78ee8b98855fa0d293) made this pull request unmergeable. Please resolve the merge conflicts.

@bors-libra r=wrwg

:pushpin: Commit 24efc60 has been approved by wrwg

:hourglass: Testing commit 24efc60ec8cdde3dc38c7052a8a70a932285288e with merge b3dbc9dcbd27e169f7e21972414080215199c919...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: wrwg
Pushing b3dbc9dcbd27e169f7e21972414080215199c919 to master...


VueMq($mq) computed value is not reactive when using Nuxt.

When I resize the browser window, the value for $mq remains the same. But in the demo, it is reactive.
Here's my code below:
plugins/vue-mq.js
`import Vue from 'vue'
import VueMq from 'vue-mq'
// Vue MQ
Vue.use(VueMq, {
breakpoints: {
// default breakpoints - customize this
sm: 640,
md: 768,
lg: 1024,
xl: 1280,
xxl: 1440,
},
defaultBreakpoint: 'sm', // customize this for SSR
})
`
nuxt.config.js
 plugins: [{ src: '~plugins/vue-mq.js', ssr: false }],

So I just realized that the moment I used this.$mq in a computed property, it became reactive. I was only watching it from the vue browser inspector. Is this a bug or a normal flow?


Production mode minifies routerMiddleware of 'connected-react-router' as undefined

Bug report

What is the current behavior?
Production mode of webpack 4.32.0 cannot minify connected-react-router middleware properly, and produces undefined
If the current behavior is a bug, please provide the steps to reproduce.

Using webpack 4.31.0, connected-react-router v6.4.0
Upgrade webpack from 4.31.0 to 4.32.0
Run build (production mode)
webpack minifies connected-react-router's middleware as undefined

This is a large proprietary project so I'm not sure how to extract this to a sample repo yet. But here's some screenshots from Chrome debugger (unminified)

What is the expected behavior?
Webpack minifies this middleware successfully as a function.

Other relevant information:
webpack version:  4.32.0
Node.js version: 11.13.0
Operating System: Windows 10
Additional tools: yarn 1.16.0

I can't reproduce it with the instructions above.
It would be great if you reduce your issue to a small reproducible example. Best put this example into a github repository together with instructions how to get to the problem.

Hi @sokra,
I've created a repo trying to describe the problem better, please check and tell me if you need more information: https://github.com/knightus/webpack-issue-9159

Thanks this helps

fixed in 4.32.2


How to handle exception in grape, if database connection is null or access denied.

You can let the error bubble up and it will be returned with details in the format your API is. Or use rescue_from for something more specific.
I'll close this. Please use the Grape mailing list for questions.

ok


[BUG] CTR+V requires deselection with multiple items

Select multiple items
press ctrl+c
press ctrl+v
items not copied, unless we deselect before pasting.
No deselection is needed when only one item is selected.

@mrx23dot I have managed to reproduce the issues and will work on a fix. Thanks for bringing this up.

This should be fixed.


cmake macOS

Is there an existing issue for this?

[X] I have searched the existing issues

Current behaviour

Expected behaviour

Steps to reproduce
Ventura 13.5 (22G74)
Cmake version 3.29.0
cmake .

Ventura 13.6.6 (22G630)
CMake version 3.27.4
cmake .

Relevant log output
I know this isn't correct - but I was able to bypass the issue by appending a commit hash to the copied folder names. (off the cuff fix)

diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
index 904248a715..217d66c7bd 100644
--- a/test/CMakeLists.txt
+++ b/test/CMakeLists.txt
@@ -32,15 +32,22 @@ endfunction()

 create_test_config()

-file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/functional)
-file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/fuzz)
-file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/util)
+file(MAKE_DIRECTORY ${PROJECT_SOURCE_DIR}/test/functional)
+file(MAKE_DIRECTORY ${PROJECT_SOURCE_DIR}/test/fuzz)
+file(MAKE_DIRECTORY ${PROJECT_SOURCE_DIR}/test/util)

 function(create_test_script script)
+
+execute_process(COMMAND git rev-parse --short HEAD
+    WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
+    OUTPUT_VARIABLE COMMIT_ID
+    OUTPUT_STRIP_TRAILING_WHITESPACE
+)
+
   if(MSVC)
-    file(CREATE_LINK ${CMAKE_CURRENT_SOURCE_DIR}/${script} ${CMAKE_CURRENT_BINARY_DIR}/${script} COPY_ON_ERROR)
+    file(CREATE_LINK ${PROJECT_SOURCE_DIR}/test/${script} test/${COMMIT_ID}-${script} COPY_ON_ERROR)
   else()
-    file(CREATE_LINK ${CMAKE_CURRENT_SOURCE_DIR}/${script} ${CMAKE_CURRENT_BINARY_DIR}/${script} COPY_ON_ERROR SYMBOLIC)
+    file(CREATE_LINK ${PROJECT_SOURCE_DIR}/test/${script} test/${COMMIT_ID}-${script} COPY_ON_ERROR SYMBOLIC)
   endif()
 endfunction()

How did you obtain Bitcoin Core
Compiled from source
What version of Bitcoin Core are you using?
cmake-staging
Operating system and version
macOS - ventura - intel and arm64
Machine specifications
No response

@RandyMcMillan
Thank you for testing the new build system!

Steps to reproduce
Ventura 13.5 (22G74) Cmake version 3.29.0
cmake .

This command effectively exploits so-called "in-source-tree" build, which is actively discouraged by CMake and is not supported by Bitcoin Core build system.
Please conider "out-of-source-tree" build, for example:
mkdir build
cd build
cmake -S ..

This note will be put in the updated build docs.

I understand - but we know people will do it anyway. :)
PS great work!!


[NEW] Add support for video message

We need support for video messages.

There's a new issue for that: #610.


Gaps section should have a link to Azure-Samples/media-services-v2-dotnet-core-restsharp-sample

The following sample includes how a Sprites job, a known gap, could be started in a modern NetCore Azure Function:
https://github.com/Azure-Samples/media-services-v2-dotnet-core-restsharp-sample
Consider adding it as a reference link to the Gaps section.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7021e0cf-3f0c-1ae6-1294-98f6d9d315b0
Version Independent ID: 764db080-56bb-e145-5ea6-0bfb7fda2347
Content: Migrate from Azure Media Services v2 to v3 - Azure Media Services v3
Content Source: articles/media-services/latest/media-services-v2-vs-v3.md
Service: media-services
Sub-service: rest-v3
GitHub Login: @Juliako
Microsoft Alias: juliako

Thanks for the feedback @NickDrouin! We are currently investigating and will update you shortly.

@NickDrouin I've added a link to the sample you've provided, changes should be merged shortly. Thanks for the feedback!


Added local DB for saving logs for #376

Added sqlite integration for saving logs locally.

Nice work @jashuajoy - I like it :)


Add Swahili Translation

I am getting started with Open Source and was going through the documentation and realise I could actually translate it to Swahili as I read along, to boost my understanding.
This pull request intends to add a Swahili translation to opensource.guide. Swahili is the national language in Kenya and Tanzania, while it is also spoken in Rwanda, Mozambique, Uganda, and the DRC.
This addition will help developers from the five African Great Lakes countries to get started with open source easily.

[x] Have you followed the contributing guidelines?
[x] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Thank you for clarifying the license.
I confirm that I’m happy for my contribution to be licensed under the Apache License 2.0.
May I know if this was just to make me aware of the same, or will I need any additional action concerning this, and if so, could you specify?

Two weeks ago, I deposited 27 toncoins to bingx exchange, it has not yet been deposited. Please help it to be deposited into my account.

Line 1358 needs exit code

Hello.
There is an invalid external link "https://paypal.github.io/" that I think makes the tests fail, how do I fix them?
Thanks.

Thank you for clarifying the license. I confirm that I’m happy for my contribution to be licensed under the Apache License 2.0. May I know if this was just to make me aware of the same, or will I need any additional action concerning this, and if so, could you specify?

We are licensed under the Creative Commons licnese for this repository.  No changes needed.

Hello. There is an invalid external link "https://paypal.github.io/" that I think makes the tests fail, how do I fix them? Thanks.

This has been fixed.  I'm merging main into your PR.

jmeridth

This is ready now. Thanks.

退订
Tom Thorogood @.***> 于 2024年12月11日周三 07:14写道：

Merged #3343 https://github.com/github/opensource.guide/pull/3343 into
main.
—
Reply to this email directly, view it on GitHub
https://github.com/github/opensource.guide/pull/3343#event-15608896995,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BLQYPXZD6QIWYAQEEE4UWXT2E5YUDAVCNFSM6AAAAABSQ4HCAOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGYYDQOBZGY4TSNI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

退订
Kim meng Lim @.***> 于 2024年12月11日周三 08:34写道：

退订
Tom Thorogood @.***> 于 2024年12月11日周三 07:14写道：

Merged #3343 https://github.com/github/opensource.guide/pull/3343 into
main.
—
Reply to this email directly, view it on GitHub
https://github.com/github/opensource.guide/pull/3343#event-15608896995,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BLQYPXZD6QIWYAQEEE4UWXT2E5YUDAVCNFSM6AAAAABSQ4HCAOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGYYDQOBZGY4TSNI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***
com>


Add CmdlineMoved autocmd

It is useful to emulate cmdline.

Thanks. The change to syntax/vim.vim is not needed, we will however need to re-generate the vim.vim syntax script. I wonder what happens, if the autocommand changes the cursor position? Does it recursively trigger the autocommand (I hope not)?

I wonder what happens, if the autocommand changes the cursor position? Does it recursively trigger the autocommand (I hope not)?

I have tested the behavior.
If ++nested is not set, it works without nesting call.
If ++nested is set, it will be infinite loop.
Found errors in Test_Cmdline():
Caught exception in Test_Cmdline(): Vim(call):E218: Autocommand nesting too deep @ command line..script /home/shougo/src/vim/src/testdir/runtest.vim[607]..func
tion RunTheTest[57]..Test_Cmdline[108]..CmdlineMoved Autocommands for ":"..CmdlineMoved Autocommands for ":"..CmdlineMoved Autocommands for ":"..CmdlineMoved A
utocommands for ":"..CmdlineMoved Autocommands for ":"..CmdlineMoved Autocommands for ":"..CmdlineMoved Autocommands for ":"..CmdlineMoved Autocommands for ":"
..CmdlineMoved Autocommands for ":"..CmdlineMoved Autocommands for ":"

I think it is expected behavior.

I have added the test for it.

thanks. I am not a big fan of adding yet another auto command... Wouldn't be CursorMovedC be the better name, that way it would be in more sync to the existing CursorMoved and CursorMovedI autocommands I would think.
Can you please back out the change to syntax/vim.vim and also please rename the auto command?

OK.

Can you please back out the change to syntax/vim.vim and also please rename the auto command?

Done.

thanks!


Improve Makefile

What does this PR do?
This is an attempt to improve and rationalize the build and crossbuild systems.
Motivation
Currently when building on MacOS, docker build export an artifact that is for linux/amd64 instead of darwin/amd64.
During my investigations I found it hard to understand the Makefile so at a point I decided to try to simplify it.
This is the result, I hope you will like it.
More

[ ] Added/updated tests
[ ] Added/updated documentation

Additional Notes

The goal is interesting but there are too many changes, and a lot of this changes are very opinionated.
Because of the amount of changes, it's possible to review it and discuss on that PR.
So I recommend a "small steps" approach, with small PRs, instead of this huge PR.

Yes there is quite a bit of changes but it's mostly located in the Makefile since I've almost entirely rewritten all the targets to clearly distinguish what is done locally and what is done inside docker.
I don't know how I could break it down in several PRs.


RFC find_good_eps

Copied from @yebai comment in https://github.com/TuringLang/AdvancedHMC.jl/pull/23#discussion_r268405153
    r = rand_momentum(rng, h)
    H = hamiltonian_energy(h, θ, r)

out of find_good_eps  and wraping
        θ′, r′, _is_valid = step(Leapfrog(ϵ′), h, θ′, r′)
        H_new = _is_valid ? hamiltonian_energy(h, θ′, r′) : Inf

into a  function

function A(ϵ, h, θ, r)
        θ′, r′, _is_valid = step(Leapfrog(ϵ′), h, θ′, r′)
        return H_new = _is_valid ? hamiltonian_energy(h, θ′, r′) : Inf
end

Then, we can drop the dependency on AdvancedHMC from this function: find_good_eps(h::Hamiltonian, θ::AbstractVector{T}, A::Function; max_n_iters::Int=100), and move it into adaption/stepsize.jl.

I refactored it anyway but I don't see any reason we have to drop the dependency any more. Plus it still depends on Hamiltonian any way?

Closed by PR #79.


Table footer border width

I have a few tables on my page with a footer.
I noticed that the width of the border of the table cells of the footer are too thick.
The dataTables.bootstrap css that makes sure the boder width for the header are correct is:
table.table-bordered thead th, table.table-bordered thead td {
	border-left-width: 0;
	border-top-width: 0;
}

I expected somethiong similar for the table footer, but appearantly it isnt there, so I just added my own.
table.table-bordered tfoot th, table.table-bordered tfoot td {
	border-left-width: 0;
	border-bottom-width: 0;
}

Thanks for letting me know about this. Fixed here and will be released soon.
Interestingly I expected the footer to have a double width border like the header does to separate it from the table body, but appears that this isn't how Bootstrap operates. So I've left it as how Bootstrap would style it rather than adding that extra border in (so basically your fix :-) ).


COOOOOOOOOOOOOOOOOOOOOOOOOOOOOOL.

I know this is spam.


Feat/test range

Codecov Report

Merging #235 (2f87604) into main (88ee55d) will increase coverage by 0.23%.
The diff coverage is 90.00%.

:exclamation: Current head 2f87604 differs from pull request most recent head b84160c. Consider uploading reports for the commit b84160c to get more accurate results

@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   53.21%   53.45%   +0.23%
==========================================
  Files          37       37
  Lines        3065     3085      +20
==========================================
+ Hits         1631     1649      +18
- Misses       1434     1436       +2

Flag
Coverage Δ

rust
53.45% <90.00%> (+0.23%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/storage/src/kv_store.rs
88.03% <90.00%> (+0.16%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[Bazel] [Xcode] Support running UI test without debugger

Thanks for the PR @yongjincho92 👍 . LGTM to get this done. Running these on device locally will need other changes as you may have found

@jerrymarino all my machines are not able to run Xcode 12.5.1 anymore due to OS upgrades. https://github.com/bazel-ios/rules_ios/runs/7476273222?check_suite_focus=true says that the process exited with error code 1, however, it's hard to tell which part of the check it's failing. Running the test on my machine with Xcode 13 seems to have the exit code of 0 (checked with echo $? on different parts of the code). Do you have some insights what check the .xcodeproj test is failing?
ccing @thiagohmcruz since he's working on xcodeproj actively as well.

If we can get #511 then we could probably get around the Xcode 12 failures, that PR is blocked though and need some help resolving the existing failures

@yongjincho92 Xcode 13.4.1 is now the minimum, you can rebase and give it another shot

Was setting up git on my new machine and messed up the state. Will re-open later

I'm going to need this in the near future. Anyone actively working on it?


Command line argument parsing seems to be broken with nswag npm package 14.0.0 +

Hi,
I think the jump from 13.20 to 14.0.1 of the npm module may have changed behavior for command line parsing. When I npm install witih nswag 13.20.0, and then I run:
dotnet "D:\Path\To\Project\node_modules\nswag\bin\binaries\Net70\dotnet-nswag.dll" run /variables:SwaggerFile=swagger-public.json,DtoProject=Core
I get:
NSwag command line tool for .NET Core Net70, toolchain v<IP_ADDRESS> (NJsonSchema v<IP_ADDRESS> (Newtonsoft.Json v<IP_ADDRESS>))
Visit http://NSwag.org for more information.
NSwag bin directory: D:\Path\To\Project\node_modules\nswag\bin\binaries\Net70

Executing file 'nswag.json' with variables 'SwaggerFile=swagger-public.json,DtoProject=Core'...

It has recognized the variables passed in. Next, I'll update my package.json to reference nswag 14.0.1, npm install, and rerun while replacing Net70 witih Net80 below. I now get:
dotnet "D:\Path\To\Project\node_modules\nswag\bin/binaries/Net80/dotnet-nswag.dll" run /variables:SwaggerFile=swagger-public.json,DtoProject=Core
NSwag command line tool for .NET Core Net80, toolchain v<IP_ADDRESS> (NJsonSchema v<IP_ADDRESS> (Newtonsoft.Json v<IP_ADDRESS>))
Visit http://NSwag.org for more information.
NSwag bin directory: D:\Path\To\Project\node_modules\nswag\bin\binaries\Net80
NConsole.UnusedArgumentException: Unrecognised arguments are present: []
   at NConsole.CommandLineProcessor.ProcessSingleAsync(String[] args, Object input)
   at NConsole.CommandLineProcessor.ProcessAsync(String[] args, Object input)
   at NSwag.Commands.NSwagCommandProcessor.ProcessAsync(String[] args) in /_/src/NSwag.Commands/NSwagCommandProcessor.cs:line 62

The npm module version is the only thing I'm changing. I was also toying with nuget packages, but I was able to isolate the problem to only the above npm change. If it's relevant, the above repro is while my ASP.NET Core project is on 14.0.1 for NSwag.AspNetCore, NSwag.CodeGeneration.TypeScript, NSwag.Core, and NSwag.MSBuild.
If I remove all variables:
dotnet "D:\Path\To\Project\node_modules\nswag\bin\binaries\Net80\dotnet-nswag.dll" run
I can run successfully even on the newest npm package. It's also respecting the "defaultVariables" even in this case.
Thanks for your guidance!
(Edited to show repro with 14.0.1 and NET80 for clarity - original post showed repro with 14.0.0 and NET70 but same problem repro'd)

dotnet "D:\Path\To\Project\node_modules\nswag\bin/binaries/Net80/dotnet-nswag.dll" run /runtime:Net80 /variables:SwaggerFile=swagger-public.json,DtoProject=Core
should work

@krzyhan thank you! Adding the runtime flag solved my issue.


iOS Safari / Chrome with TextInput - Keyboard not showing

We have a Flutter application which uses Text inputs.
The text inputs work fine on Desktop WEB with Chrome, Safari, Firefox, Edge, Opera, etc.
The application works well also on mobile native iOS and Android. As you click on the input field, the keyboard appear and you can capture data. This is also true on Android WEB through Chrome.
On iOS WEB using Safari and Chrome though, when you click on the text input, the keyboard doesn't show and makes it impossible to capture data into it.
Here is a video exposing the issue. The video shows the execution of the same app twice. The first app to execute is the Native version. The second is the WEB app through Safari.
https://user-images.githubusercontent.com/5298744/186757565-b48f2757-07e9-462e-88a5-c617acaae2e1.mp4
We are using a form in our code to facilitate the validation. This issue also happens on every other type of Text input we use.
Widget build(BuildContext context) {
  return Title(
    [...]
    child: SingleChildScrollView(
      child: ConstrainedBox(
        constraints: [setting maxWidth...]
        child: IntrinsicHeight(
          child: _body,
        ),
      ),
    ),
  );
}

Widget get _body {
  return Form(
    key: _formKey,
    child: Column(
      [...]
      children: [
        [...]
        TextFormField(
          autofillHints: [...],
          decoration: [...],
          focusNode: [...],
          keyboardType: TextInputType.number,
          onChanged: [...],
          onFieldSubmitted: [...],
          textInputAction: TextInputAction.done,
          validator: [...],
        ),
      ],
    ),
  );
}

interesting facts:
The keyboard is displayed if you leave and come back to the app

is on Safari and click on a text input (the keyboard doesn't display)
and the user switches to another app
and the user switches back to Safari as the focus is on an input
Then! the keyboard appears and let you capture your information

Can it be related to Semantic being enabled???
I haven't been able to reproduce this through my gist on dartpad.io
Can it be caused by the fact that we useRendererBinding.instance.setSemanticsEnabled(true); in our main??? (see commented code in line 7 to 10 of the gist)
We are building an accessible app so we need this Semantic tree enabled.
Unfortunately, Darpad.IO doesn't seem to like that call to setSemanticsEnabled(true) as it doesn't load for me when I uncomment those lines.
This is not the number keypad which is displayed
When we execute the app from Android or iOS (both) and succeeds to show the keyboard, it displays the full keyboard, and not the numeric keypad.

iOS
Android

$ flutter analyze
Analyzing my-app...
No issues found! (ran in 6.2s)

$ flutter doctor -v
[✓] Flutter (Channel stable, 3.0.5, on macOS 12.5.1 21G83 darwin-x64, locale en-US)
    • Flutter version 3.0.5 at /usr/local/Caskroom/flutter/3.0.2/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f1875d570e (6 weeks ago), 2022-07-13 11:24:16 -0700
    • Engine revision e85ea0e79c
    • Dart version 2.17.6
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/israelpainchaud/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2022.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin version 222.3739.24

[✓] Connected device (5 available)
    • BS 02 (mobile)                      • 3d1896e7                             • android-arm64  • Android 8.1.0 (API 27)
    • sdk gphone64 x86 64 (mobile)        • emulator-5554                        • android-x64    • Android 13 (API 33) (emulator)
    • iPhone SE (3rd generation) (mobile) • 7B3F43F4-5669-4D38-8C80-B9FB8A077928 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-5 (simulator)
    • macOS (desktop)                     • macos                                • darwin-x64     • macOS 12.5.1 21G83 darwin-x64
    • Chrome (web)                        • chrome                               • web-javascript • Google Chrome 104.0.5112.101

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

This issue does appear to be caused by enabling accessibility. To reproduce it:

Run the code sample below with flutter run -d chrome.
Using Xcode's Simulator (Xcode > Open Developer Tool > Simulator), open an iPhone simulator (I used an iPhone 13 with iOS 15.5).
Disable the hardware keyboard (I/O > Keyboard > Connect Hardware Keyboard).
Open Safari and browse to the web app URL.
Tap in the TextField. The keyboard will not be displayed. (Hold-and-press and it will.)

If you disable accessibility (RendererBinding.instance.setSemanticsEnabled(false)), the issue goes away.

Code sample
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';

void main() {
  WidgetsFlutterBinding.ensureInitialized();

  // Auto-enable accessibility for our Blind and Low Vision customers.
  RendererBinding.instance.setSemanticsEnabled(true);

  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  final String _title = 'TextField A11y Issue';

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: _title,
      home: Scaffold(
        appBar: AppBar(
          title: Text(_title),
        ),
        body: const MyWidget(),
      ),
    );
  }
}

class MyWidget extends StatefulWidget {
  const MyWidget({Key? key}) : super(key: key);

  @override
  State<MyWidget> createState() => _MyWidgetState();
}

class _MyWidgetState extends State<MyWidget> {
  @override
  Widget build(BuildContext context) {
    return Padding(
      padding: const EdgeInsets.all(40),
      child: Column(
        children: const <Widget>[
          Text('Tap in the TextField below. In a mobile browser on iOS, if a11y is enabled, the keyboard will NOT be '
              'displayed unless you press-and-hold in the text field.'),
          SizedBox(height: 20),
          TextField(
            decoration: InputDecoration(
              border: OutlineInputBorder(),
              labelText: 'Text',
            ),
          ),
        ],
      ),
    );
  }
}

https://user-images.githubusercontent.com/1007109/186789601-4bac1648-b5a7-4470-8a9e-5929608984e3.mov

Hi @ipainchaud

For iOS issue, as @vsomayaji explained above, I think this behavior is working as intended. For more information: https://support.apple.com/en-al/guide/iphone/iph3e2e3d1d/ios

Enter text with the onscreen keyboard
Select a text field, then double-tap.
The insertion point and the onscreen keyboard appear.

For Android issue, I can reproduce it. When semantic is enabled (RendererBinding.instance.setSemanticsEnabled(true);), it does not display numeric keypad.

Could you please open a new issue for the Android case?

Thanks for the read, it was very interesting.

VoiceOver changes how you use the onscreen keyboard when you activate an editable text field

This says that VoiceOver changes the behavior, but doesn't explain why the keyboard doesn't appear even when we don't have VoiceOver enabled.
About the Android case: I'll open another issue.

Hi @ipainchaud
I tested this again. Without enabling RendererBinding.instance.setSemanticsEnabled(true); but enabling VoiceOver, the keyboard doesn't seem to show up even when double-tap/hold and press on the TextField whilst the iOS app (Flutter) does it right with double-tap (please see in demo)

Demo

Web
iOS

When enabling RendererBinding.instance.setSemanticsEnabled(true);, hold and press on the TextField will bring up the keyboard (as @vsomayaji mentioned above)
Do you have the same behavior?

@huycozy I confirmed that if accessibility is not enabled and you're using VoiceOver with a Flutter web app on iOS, nothing seems to work correctly. It makes sense that a Flutter iOS app isn't affected, as the semantic tree is always built on mobile.
Our issue is that we always need to enable accessibility on web, even for our customers that are not using a screen reader. (Our philosophy is that accessibility isn't something that you should have to "opt in" to.) And that means that users who are not familiar with the hold-and-press requirement on text fields will be blocked when they tap in a text field and the keyboard is not displayed. 😦 Any thoughts on a fix/workaround?

The issue is actually worst than that @vsomayaji @huycozy.
We all agree that if you have enable RendererBinding.instance.setSemanticsEnabled(true); it works as expected with VoiceOver with a double tap.
As @vsomayaji explained, we always enable the semantic tree, but with the RendererBinding.instance.setSemanticsEnabled(true); enabled, there is actually no way to get the keyboard without VoiceOver at all -- even with the double tap.

@ipainchaud @vsomayaji, thanks for providing more information. Labeling this issue for further opinions/insights from the team.
This issue is reproducible on the latest stable and master channels.

setSemanticsEnabled(true): the keyboard doesn't show, but press-and-hold on the TextField will bring the keyboard up (not the numeric keypad)
setSemanticsEnabled(false): the keyboard shows numeric keypad as expected

Demo

Safari iOS (enable semantic)
Safari iOS (disable semantic)

Sample code
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';
import 'package:flutter/services.dart';

void main() {
  WidgetsFlutterBinding.ensureInitialized();
  if (kIsWeb) {
    // Auto-enable accessibility for screen reader users
    RendererBinding.instance.setSemanticsEnabled(true);
  }

  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    const String title = 'TextInput not showing Keyboard on mobile WEB - Issue';
    return MaterialApp(
      title: title,
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: title),
    );
  }
}

class MyHomePage extends StatefulWidget {
  final String title;

  const MyHomePage({
    Key? key,
    required this.title,
  }) : super(key: key);

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  final GlobalKey<FormState> _formKey = GlobalKey<FormState>();

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: Form(
          key: _formKey,
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            crossAxisAlignment: CrossAxisAlignment.start,
            children: [
              const Text(
                'please enter a number',
              ),
              TextFormField(
                keyboardType: TextInputType.number,
              ),
            ],
          ),
        ),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 3.3.0, on macOS 12.5 21G72 darwin-x64, locale en-EE)
    • Flutter version 3.3.0 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ffccd96b62 (28 hours ago), 2022-08-29 17:28:57 -0700
    • Engine revision 5e9e0e0aa8
    • Dart version 2.18.0
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13E113
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2020.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.70.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.46.0

[✓] Connected device (3 available)
    • iPhone 13 (mobile) • 2526BC1A-435D-4B08-B99C-44B928F2517B • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-4 (simulator)
    • macOS (desktop)    • macos                                • darwin-x64     • macOS 12.5 21G72 darwin-x64
    • Chrome (web)       • chrome                               • web-javascript • Google Chrome 104.0.5112.101

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel master, 3.1.0-0.0.pre.2592, on macOS 12.5 21G72 darwin-x64, locale en-EE)
    • Flutter version 3.1.0-0.0.pre.2592 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 069f504297 (3 hours ago), 2022-08-30 18:20:09 -0700
    • Engine revision 0ef08a8525
    • Dart version 2.19.0 (build 2.19.0-152.0.dev)
    • DevTools version 2.16.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13E113
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2020.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.70.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.46.0

[✓] Connected device (3 available)
    • iPhone 13 (mobile) • 2526BC1A-435D-4B08-B99C-44B928F2517B • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-4 (simulator)
    • macOS (desktop)    • macos                                • darwin-x64     • macOS 12.5 21G72 darwin-x64
    • Chrome (web)       • chrome                               • web-javascript • Google Chrome 104.0.5112.101

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Possibly related: https://github.com/flutter/flutter/issues/96199

Although, if this is only happening with setSemanticsEnabled(true) then maybe it's something else.

I updated this priority to P2 to be consistent with internal bug b/254706139 which is impacting a Google customer launch. We're trying the workaround the issue by making semantics opt-in, however the customer would prefer for semantics to be enabled by default.

@jacobsimionato that's great to hear! We at Aira agree with your customer: semantics should be enabled by default. In fact, we'd love to see that become the Flutter Web default someday. 😉

I am actively working on this. It seems to be a result of bugs in our SemanticsTextEditingStrategy and some features that we haven't implemented yet in the semantic mode.
We have a partial fix that allows the keyboard to show up, but there are still some cases that needs investigating, including:

We're unable to move the cursor once the input gets focused.
The input placement is wrong once the keyboard shows up.

I'll keep this thread updated as I get more insight.

Still working on the placement issue. It seems like the viewport information that we communicate to the framework are wrong, but it still needs some more investigation.

It will take some time to solve this issue fully, but the most critical part of it has been extracted into a separate issue here: https://github.com/flutter/flutter/issues/115099. That one is P2. This one can be P3 for now.


open bank

Expected behavior
Actual behavior
Information about the Issue
Steps to reproduce the behavior

...
...

No information provided - Closing


pop up of select does not close after navigate back using android back button

I opened a select. pop up come up of my selectItem and I back from my android back button then it shows on my new screen.
How can I close that?

if you're using react native this might help you https://reactnative.dev/docs/backhandler


Zero in scientific notation

Formating zero print("{:e}".format(0.0)) returns 0.000000e+00 Based on the mathematitian you ask, 0^0 is either 1 or indetermined. It would be much better if the result was  0.000000e+01

Sorry

If you feel strongly about this I’d recommend to open an issue in the python bug tracker: https://bugs.python.org


jQuery

I'm having a few problems with jQuery. On jQuery 1.5.1, my ajax calls would return as "error" (ie, they trigger the 'error' ajax callback; no error is raised in zombie), even though the request returns with 200 status. Reverting to 1.4.4 solved this problem, however I then noticed that setting content using jQuery .html(newHtml); was also failing. Using native javascript .innerHtml = newHtml; solved this problem.
Sorry that I can't be more specific about what's going on here -- I'm still getting to know node and zombie.

jQuery AJAX calls are still failing with jQuery 1.6 and Zombie. I get this to the jQuery.ajax error callback:
{ readyState: 4,
  setRequestHeader: [Function],
  getAllResponseHeaders: [Function],
  getResponseHeader: [Function],
  overrideMimeType: [Function],
  abort: [Function],
  pipe: [Function],
  always: [Function],
  then: [Function],
  promise: [Function],
  isRejected: [Function],
  isResolved: [Function],
  fail: [Function],
  done: [Function],
  success: [Function],
  error: [Function],
  complete: [Function],
  statusCode: [Function],
  status: 0,
  statusText: 'error' }

Here's browser.dump:
Zombie: 0.11.6

URL: http://localhost:3000/test/index.html
History:
  1: http://localhost:3000/test/index.html

Cookies:

Storage:
  localhost:3000 session:
    qunit-vie.js - DBPedia Service-VIE.js DBPediaService - Load = 1

Eventloop:
  The time:<PHONE_NUMBER>574
  Timers:     0
  Processing: 0
  Waiting:    0

Document:
  <html version="XHTML+RDFa 1.0" xmlns="http://www.w3.org/1999/xhtml" xml:lang="en">  <head>    <script type="text/javascript" src="../lib/jquery/1.6/jquery-1.6.1.min.js"></script>
      <link rel="stylesheet" href="qunit.css" type="text/css" media="screen">
      <script type="text/javascript" src="qunit.js"></script>
      <script type="text/javascript" src="../lib/rdfquery/latest/jquery.rdfquery.debug.js"></script>
      <script type="text/javascript" src="../lib/underscoreJS/underscore.js"></script...

It seems jQuery 1.7.x AJAX calls work fine: https://github.com/bergie/zombie-qunit

using this syntax (url, {data}, callback):
$.getJSON(query.url, {id:id}, function (data)
instead of  ({url:url, data:data, success: callback}):
$.ajax({ url: query.url, data: {id:id}, dataType: 'jsonp', success: function (data) {
worked for me!  (jquery 1.7)


support php v8

reefactor the next method in the closure when the array_map() try to implement it as a callback
#3

@wouterj Hi, can you review this changes?


Important anti bug fixes! and indluded parts of #716 and parts of #733 also fixes anti-dex bypass method 2 kicking all nonadmins

Additions:

Made the logspoof check work for disabling events too, now it is quite hard to bypass
Implemented #716 expect the seperation of the log message checks (Details below)

Added VirtualUser and VirtualInputManager to disallowed services

Added "getrawmetatable" and "setfflag" to log detection strings

Deletions:

Removed legacy coreclears & corenums and their updater, they aren't used for anything
Removed legacy unused AntiGui, it was probably supposed to be made functional back in the day, but now it doesnt make much sense because of coregui, besides it would conflict with games if said was ever enabled
Removed a dublicate tool detection, there was already one, so I removed the dublicate one
Implemented #733 expect the removing of logservice detections because log detections are still very valid for many exploits, excluding Synapse X They are also hard to bypass because of the log spoof check, unless its done on an exploit level with a custom log output like Synapse does (Details below)

Fixed incorrect intendation

Fixed message log check audio (Its no longer possible to kick people via game devs using insecure remotes)

Removed legacy ScriptContext Non-CoreScript Detected detection

Removed legacy ReplicatedFirst Localscript Detected detection

Removed annoying legacy Selection Selection changed detection (It false detects always in studio)

Removed lastupdate vars for an unused check

Bug fixes:

Made debugging anti-anti-idle more easier
Main detection look longer waittime, because its probably better to not do it so often
Core gui detetion bypass waits for longer, just in case it would take longer to load, it shouldnt be possible because its a local asset but Roblox do we weird sometimes
Malicious object moved to main detection loop. Now you can disable all non-core AC checks for those who don't like them ;)
Changed usage of incorrect timer to os.clock() for betterr accuracy and to ensure that nothing weird happens
Fixed anti-dex bypass method 2 false kicking everyone always due to Adonis making rawequal work improperly, apparently Adonis makes rawequal function in a wrong way, but relies on said behavior, so I had to use the original rawequal instead of fixing the wrong instance wrapping
Fixed incorrect description of anti-anti-idle checks, it says that its supposed to kick players for being afk, which is not true
Made character checks automatically disabled if another anti-exploit that does the same is enabled. If we don't do this neither works because they negate their effects and cause an error in the output
Fixed log detection bypass detection making an extra newline
Fixed service detectors not working at all because of incorrect argument order
Made tooldetection work by introducing task.wait()

yolo

yolo

This time i double checked that it works


catch the not-authenticated error and print a helpful error message

Early exit and helpful error message if the SLACK_TOKEN is not provided or otherwise incorrect

I did this in a simpler way: https://github.com/Symantec/slack-autoarchive/commit/96252388a6a035e95791d710c3267ec3908b0fc7


Read adapter data from project folder

Once a project is loaded, we need to load in the adapter files and add them to the project settings (this is the second half of the work that generates the form-based modal and saves out the file in the first place).

We are currently persisting these changes into the appsettings.json file.


Review UI/UX for SAH Notifications

What's the UI/UX for student to opt in?
What's the topic label that would indicate this is specific to the student?

This issue is being closed due to platform migration and may be revisited at a later date.


Improve current init samples around docs and fixes

Issue #, if available:
Description of changes:
This PR addresses 5 feedbacks received from customers during Workshops as well as issues noted below:

NodeJS and Python templates don't have links to API Gateway Event Object to aid on development (#518)
NodeJS 8 template doesn't follow async await return syntax (#519)
Python 2.7 runtime is used when sam init --runtime python is chosen and this should be Python3.6 (#521 )
Manage try/catch across all runtimes to return HTTP 500 except Go (#520)
DotNet core sample uses Cake and that doesn't in Cloud 9 or traditional setups for those beginning with DotNet Core that doesn't use Cake for simpler build/process (now dealt via PR https://github.com/awslabs/aws-sam-cli/pull/570)

Pending items to finalize this PR

[X] Fix Try/Catch errors

[X] Nodejs needs to return 500 and print error
[X] Python needs to return 500 and print error
[X] Java is returning 400 instead of 500

[X] Fix NodeJS promises
[X] Fix python version (default)
[X] Enhance docstrings -- API GW input/output

[X] Python
[C] NodeJS

[C] Update tests to reflect changes

[X] Python

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@heitorlessa Why are we rolling back Dotnet Core enhancements?

@joaoasrosa - Hey Joao, not sure you remember your PR for Cake (https://github.com/awslabs/aws-sam-cli/pull/401)...
I'm trying to run this through now on a mac with a fresh install of DotNet and I keep running into issues... as I dig into I noticed that NuGet.exe isn't anywhere in the system and while searching it seems I have to install Mono to get it working -- Is this expected? I couldn't see that in the README apart from running build.sh.
# Define directories.
SCRIPT_DIR=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )
TOOLS_DIR=$SCRIPT_DIR/tools
ADDINS_DIR=$TOOLS_DIR/Addins
MODULES_DIR=$TOOLS_DIR/Modules
NUGET_EXE=$TOOLS_DIR/nuget.exe
CAKE_EXE=$TOOLS_DIR/Cake/Cake.exe

TOOLS_DIR doesn't exist within the dotnet core sample so perhaps this was stripped out accidentally?
I'd like to improve this example and make sure OSX, Linux and anyone running in Cloud9 is able to run this sample successfully so any help is more than appreciated :)

@heitorlessa yes I remember the PR. :)
Cake needs Mono and .NET Core in Unix based systems (more info here).
Given your comment, we could enhance the README with the link, making it explicit to the users about the expectations for the system.
What are your thoughts?

Yes!! That isn’t in the readme today and I started to receive feedback on
those as they can’t get passed the packaging/build steps.
Although mono is straightforward there must be some instructions on getting
those in place, path and such so others can do as part of the requirements,
and therefore I believe we should do this in a separate PR to collaborate
on that.
Would you be able to help creating a new PR and I can commit to those too?
If so, I can edit this and narrow this PR to other enhancements only.
Thanks a lot ;-)
On Mon, 23 Jul 2018 at 03:30, João Rosa<EMAIL_ADDRESS>wrote:

@heitorlessa https://github.com/heitorlessa yes I remember the PR. :)
Cake needs Mono and .NET Core in Unix based systems (more info here
https://cakebuild.net/docs/overview/requirements).
Given your comment, we could enhance the README with the link, making it
explicit to the users about the expectations for the system.
What are your thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/awslabs/aws-sam-cli/pull/558#issuecomment-406890631,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADL4BOVOFunxdUDHXjk2GRfddZWD27euks5uJNLFgaJpZM4VR6YR
.

Hi Heitor,
Sure thing I will. Give me a few hours to sort out some things, and I will
push it!
Cheers
On Mon, Jul 23, 2018, 06:41 Heitor Lessa<EMAIL_ADDRESS>wrote:

Yes!! That isn’t in the readme today and I started to receive feedback on
those as they can’t get passed the packaging/build steps.
Although mono is straightforward there must be some instructions on getting
those in place, path and such so others can do as part of the requirements,
and therefore I believe we should do this in a separate PR to collaborate
on that.
Would you be able to help creating a new PR and I can commit to those too?
If so, I can edit this and narrow this PR to other enhancements only.
Thanks a lot ;-)
On Mon, 23 Jul 2018 at 03:30, João Rosa<EMAIL_ADDRESS>wrote:

@heitorlessa https://github.com/heitorlessa yes I remember the PR. :)
Cake needs Mono and .NET Core in Unix based systems (more info here
https://cakebuild.net/docs/overview/requirements).
Given your comment, we could enhance the README with the link, making it
explicit to the users about the expectations for the system.
What are your thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/awslabs/aws-sam-cli/pull/558#issuecomment-406890631
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ADL4BOVOFunxdUDHXjk2GRfddZWD27euks5uJNLFgaJpZM4VR6YR
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/awslabs/aws-sam-cli/pull/558#issuecomment-406937337,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABdIuIHnnJyFzHPf_OWlWloZ-IrGsk8Uks5uJVQNgaJpZM4VR6YR
.

@heitorlessa the PR #570 is done!

Awesome @joaoasrosa !! Thanks for that. Just updated this PR to reflect that and @jfuss this is ready for review now and possibly merge ;)

@jfuss ready for review!


chore(main): release 0.4.1

:robot: I have created a release beep boop
0.4.1 (2024-08-12)
Bug Fixes

mypy fix (0b421fe)

Dependencies

pdm update (a49ef58)

Documentation

Update copyright year to 2024 (672274f)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.4.1
:sunflower:


Merge ospo-ghcrawler and ghcrawler

This eliminates the ospo-ghcrawler repository completely, things of note:

Unit tests moved under tests/unit (and the Mocha launch config runs these)
Added custom certificate authority support to RabbitQueueManager
CIAB hasn't been validated I'll do that when I finish the MongoDB changes to support the latest dashboard updates
README is rationalized at a high-level but still needs to be updated

@willbar,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Highlight refactoring options

I have been using VSCode for a long time and want to ask. Why the editor does not emphasize the possibility of refactoring. Despite the fact that he finds them. I noticed that if you click on the yellow light whenever possible, then there really are useful tips. I compared them to the tips from the JetBrains IDE in the same code, and they matched most of the time. Please add this feature to your editor. This is a very useful thing.

Making refactoring more discoverable is being investigated with #86788 and #85160


Trying to cargo-install unknown program leads to "unknown error"

$ cargo install dsfsadfa
    Updating registry `https://github.com/rust-lang/crates.io-index`
error: An unknown error occurred

To learn more, run the command again with --verbose.

Expected something like "No such package" or "No package contains binary dsfsadfa".

Sorry, it was because of something other which I cannot reproduce anymore.


Allow specifying pkg target:

One such target is 'CurrentUserHomeDirectory'. See installer -help.
Required for Homebrew/homebrew-cask#139807

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

Trying this out with the cask in Homebrew/homebrew-cask#139807, it looks like uninstall pkgutil: also needs the ability to specify a target, although that appears to work differently...

@sambostock One thing to consider here is that the installer command doesn't allow you to pass a path to -target but rather a volume. It does work for targeting the user folder ~/Library as opposed to /Library (with "CurrentUserHomeDirectory"), but you can't pass a full path.

I agree with this comment: https://github.com/Homebrew/homebrew-cask/pull/139807#discussion_r1105679828
Also, we have two other Casks (that I can think of) that use a pkg installer and are plugins for OBS, and neither of these require this change.
https://github.com/Homebrew/homebrew-cask-drivers/blob/master/Casks/obs-ios-camera-source.rb
https://github.com/Homebrew/homebrew-cask-drivers/blob/master/Casks/droidcam-obs.rb

It’s been too many years to recall exactly, but I think using a target with PKG was considered and dropped way back when. The vast majority of PKGs work by writing to specific locations, which in turn makes developers only write their PKGs that way. PKGs are relatively niche and awkward to support programatically, customising their installation options is nicher still. Unless extensive testing has been done in all available casks, this might be one of those features that will take more effort to support and work around than it’s worth. At the very least we’d need an option to say “this target cannot be customised” and in the case of PKGs I wouldn’t be surprised it that ended up applying to most of them.
I’d be wary of adding the feature without a very clear “this is experimental and may be removed at any point” warning. Because it will likely see little use, it would have to be present for a good while or someone would have to test the most popular PKG casks.


Travis CI automatic documentation and stack

You don't need to worry about doxygen as long as Travis CI is enabled in your repository. In order to set up GH Pages, you need to merge my gh-pages branch to yours.
In #6, you said that:

I stand corrected. It seems Vector based stack does work better when the data units to be stored is smaller in size, also benefits from caching.

Therefore, why don't you put two stacks in your source code. I hope I really can get write access to your repository because I am currently learning some similar stuff in Jerry Cain's Programming Paradigms lecture

I will be implementing queue in the following commits

Hi,
There are quite a few reviews I would like to point out, but unfortunately, I am quite busy at the moment ( for a few weeks ).
You work is good, however, you have to understand that I have a design and a plan for the project in my mind which I have been unable to formalize due to lack of time.
As I had mentioned, please refrain from simply sending pull requests with abrupt changes. Make an issue first so that we can discuss it, e.g. - The coding style you used in the commit.
Also regarding the implementation, there are few changes which are suggested. I will get back to it tomorrow.

My queue is based on vector, and push add element to the front where pop removes the element at the back. My implementation of std::queue is in reverse

The reason I have asked to remove your stack implementation is because it is basically replicating the vector code. The stack should be an adapter instead of a container.

Furthur discussion can be found in #8


ensure deployed editor gives warning to user when trying to save a resource template that already exists

may be fixed by other bug fixes.
Josh and Jeremy say

it used to work
it works locally

@ndushay and @jgreben is this issue the same as #506?

@jermnelson I don't know.  This is more Michelle's viewpoint.  It's possible fixing #506 will fix this, but to my imperfect knowledge, it is also possible it won't.

Running code locally (may) work, but doesn't work in deployed environment?

Given the acceptance criteria for #506 includes:

user should see a warning that they will overwrite existing template

I believe this issue is indeed a dup. Closing.
duplicates #506

Duplicate of #506


ProjectComponentIdentifier is insufficient for sbom generation?

Expected Behavior
Obtain project.version and project.description without resorting to cross project analysis in a plugin -- which appears to be incompatible with project isolation.
Current Behavior (optional)
No response
Context
Typically version is a required parameter on a component in an sbom document. Right now, in our sbom plugin, we are obtaining these using rootProject.getAllProjects() -- but that seems like it would be disallowed in the future with project isolation at build.
What would be nice is the availability of this information in the ProjectComponentIdentifier object. For projects that are parsing the dependency tree, this extra information could then be applied to a metadata document without resorting to preprocessing all projects in the plugin.

Thank you for your interest in Gradle!
This feature request is in the backlog of the relevant team and is prioritized by them.


Support the list-pattern on the Either<TLeft, TRight> type

This list-pattern idea is for educational and entertainment purposes.

We discussed this (this PR was an experiment only). I'm going ahead and closing it.


[Prover][Test] Agent failure: a busy agent goes down, the broker must give their job to another agent

Scenario:

start proving a block
agent picks up job
shutdown agent

Expected:

broker should give same job to another agent
proving should continue

Handled as a unit test in the broker


chore: simplmify branch protection configuration

Add a new "Unit Tests" join target that depends on the matrix test having succeeded
Enable merge_group triggers on validation workflows, in preparation for turning on merge queues

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mergifyio update


[BUG]: Mismatch between Stripe docs for DefaultValuesOption and Type DefaultValuesOption

What happened?
const paymentOptions: StripePaymentElementOptions = {
  defaultValues: {
    paymentMethods: customerState?.paymentMethod
  }
}

Error Type '{ paymentMethods: Stripe.PaymentMethod | undefined; }' is not assignable to type 'DefaultValuesOption'.
Here the docs say paymentMethods is a valid child of defaultValues but here the type doesn't include paymentMethods (or card, which the docs also say is allowed)
Environment
No response
Reproduction
No response

+1 ran into this today!

What is the value you're trying to set here? I agree the type definition doesn't appear to include paymentMethods at all, but from the context of your customerState?.paymentMethod variable, that doesn't sound like it would match the shape in the docs { ideal: { bank: 'abn_amro' }}. Can you clarify so I can confirm I understand what's needed here?

Hey Brendan! Can't speak for OP, but I was looking to pre-populate a user's existing payment method information in the form to build a "modify payment method" feature. From looking at the docs again though, it looks like the paymentMethods setting that's missing from the type definitions only controls basic card and iDEAL settings as opposed to the actual payment information itself. I did some better Googling and learned that this isn't possible to do though 😆

oh whoops, somehow didn't notice that paymentMethods only includes ideal 🙃 I was trying to do the same thing as williamrobertson13

Thanks for the replies @williamrobertson13 @kdurgatp. This sounds like an integration issue, and Stripe Support can provide more help with this if you need it.


stable/grafana Datasources added from chart config doesn't work but same datasource added manually works

Describe the bug
I am using stable/grafana chart with some custom config (given below).

grafana:
  rbac:
    create: false
    pspEnabled: false
    pspUseAppArmor: false

  datasources:
    datasources.yaml:
      apiVersion: 1
      datasources:
      - name: Graphite
        type: graphite
        url: http://graphite.monitoring.svc.cluster.local:8080
        access: direct
        isDefault: true

  ingress:
    enabled: true
    annotations:
      kubernetes.io/ingress.class: nginx
      nginx.ingress.kubernetes.io/rewrite-target: /
      nginx.com/health-checks: "true"
      nginx.ingress.kubernetes.io/enable-access-log: "false"
    hosts:
      - <hostname>

This installs grafana and the default datasource (graphite) is setup. But it doesn't work. If I add the same datasource manually from Grafana UI, it works.
Version of Helm and Kubernetes:
$ helm3 version
version.BuildInfo{Version:"v3.0.3", GitCommit:"ac925eb7279f4a6955df663a0128044a8a6b7593", GitTreeState:"clean", GoVersion:"go1.13.6"}

Which chart: stable/grafana
What happened: Datasource added while deploying chart using custom values.yaml file doesn't work.
What you expected to happen: The datasource added automatically should work.
How to reproduce it (as minimally and precisely as possible):
The environment is as below:
 $ tree setup/grafana/
setup/grafana/
├── Chart.lock
├── Chart.yaml
├── charts
│   └── grafana-5.0.0.tgz
├── templates
│   └── _helpers.tpl
└── values.yaml

2 directories, 5 files
$ cat setup/grafana/values.yaml
# Default values for grafana.
# This is a YAML-formatted file.
# Declare variables to be passed into your templates.

grafana:
  rbac:
    create: false
    pspEnabled: false
    pspUseAppArmor: false

  datasources:
    datasources.yaml:
      apiVersion: 1
      datasources:
      - name: Graphite
        type: graphite
        url: http://graphite.monitoring.svc.cluster.local:8080
        access: direct
        isDefault: true

  ingress:
    enabled: true
    annotations:
      kubernetes.io/ingress.class: nginx
      nginx.ingress.kubernetes.io/rewrite-target: /
      nginx.com/health-checks: "true"
      nginx.ingress.kubernetes.io/enable-access-log: "false"
    hosts:
      - <hostname>

Anything else we need to know:
graphite is already installed in using https://github.com/kiwigrid/helm-charts/tree/master/charts/graphite

This issues appears to have been introduced with this PR: https://github.com/helm/charts/pull/20985 and a possible workaround is to declare the previous configuration for the datasource sidecar in the extraInitContainers section.
The reason for the regression is the sidecar responsible with pulling the datasource configuration from configmap/secret objects has been moved from initContainers to containers, but Grafana only appears to provision datasources at startup.

It’s possible to manage datasources in Grafana by adding one or more yaml config files in the provisioning/datasources directory. Each config file can contain a list of datasources that will be added or updated during start up. If the datasource already exists, Grafana will update it to match the configuration file. The config file can also contain a list of datasources that should be deleted. That list is called deleteDatasources. Grafana will delete datasources listed in deleteDatasources before inserting/updating those in the datasource list.

We're also waiting for this PR to fix the Grafana chart so we can update.
Thanks @dvulpe 👏


How to set-up vertex?

Issue
I had installed all it asked me to, and set the variables it requested, still complains about needing to install:
BadRequestError: litellm.BadRequestError: VertexAIException BadRequestError - vertexai import failed
please run pip install -U google-cloud-aiplatform "anthropic[vertex]"

Version and model info
No response

Thanks for trying aider and filing this issue.
Did you do the pip install that the error specified?

Thanks for trying aider and filing this issue.
Did you do the pip install that the error specified?

Yup,  and installed the google cloud cli in order to authenticate and so on, and nothing, no idea.

Did you install aider with pip or pipx? You'd need to install the google packages differently if you installed aider with pipx.

Did you install aider with pip or pipx? You'd need to install the google packages differently if you installed aider with pipx.

I did install with pipx how shall I do it?

@adriangalilea , also after doing the above it is sometimes required to close the current terminal window and open a new one so the changes will apply. Try that and I hope this will work for you

@adriangalilea , also after doing the above it is sometimes required to close the current terminal window and open a new one so the changes will apply. Try that and I hope this will work for you

Will test out in a couple weeks, thanks.

Here is the command for pipx : pipx runpip aider-chat install -U google-cloud-aiplatform "anthropic[vertex]"


Strategy "fixed" + pinch-to-zoom generates incorrect popper position in Safari

CodeSandbox demo

https://codesandbox.io/s/strange-hooks-nukkq?file=/src/index.js
Steps to reproduce the problem

Open the demo in Safari (iOS or desktop)
Open the sandbox embedded browser in a new window
Zoom-in browser window using the pinch-to-zoom gesture
Scroll the page

What is the expected behavior?

Popper should stay on the bottom side of the reference element when scrolling.
What went wrong?

Popper goes up as far as the scroll position changes.
Any other comments?

What version of Safari are you on? With 13.1 everything looks good to me.

The version is 13.1.1. It's important to use the pinch-to-zoom gesture on the trackpad, not command+plus. Or use a mobile browser.

Oh ok thanks, I missed that step, yes I can reproduce it.

Hey, we're running into this issue too!
Looking at the example, it seems like some logic kicks-in whenever it's pinch zoomed. The logic will manually reposition popper (see attached) on scroll thereafter.
I'm completely new to this project so sorry if I'm stating the obvious here but i hope it helps anyway - ha 😜 I'll have poke around today and see if i can find anything else.

After some more digging i've found that the issue is related to this line:
https://github.com/popperjs/popper-core/blob/38914aae7a2e91715c6eb2b563517082a40cfa64/src/modifiers/computeStyles.js#L87
The result of this calculation x -= offsetParent.clientWidth - popperRect.width; changes when we use cmd + and cmd - but if you use pinch to zoom, the calculation remains the same, as if there was no zoom at all.
For example:

No zoom: x -= offsetParent.clientWidth - popperRect.width; = 366
Zoom: x -= offsetParent.clientWidth - popperRect.width; = 313
Pinch zoom: x -= offsetParent.clientWidth - popperRect.width; = 366

Right now i'm thinking that the offsetParent.clientWidth isn't being updated in Safari like we would otherwise expect.

hmmm. appears that this is the culprit: https://stackoverflow.com/questions/6163174/detect-page-zoom-change-with-jquery-in-safari
Safari wont include the zoom in clientWidth & clientHeight but it will update the window.innerWidth / Height...

Hi all, looks like this issue is already fixed in v2.4.1
See this PR
@atomiks we can probably close this issue for now, thanks 😄

@danieldelcore I can still reproduce it updating to 2.4.1 & 2.4.2 in the CodeSandbox

Sorry about that, yea can still confirm that this is an issue

I took some time to investigate this issue today, and it looks like like the issue is caused at least in part by a Webkit bug with calculating getBoundingClientRect() when using pinch-to-zoom. Popper.js wraps this function and uses it in a bunch of places to calculate positioning. I assume the same bug causes the inconsistencies with offsetParent that Dan mentioned above.
The bug is tracked in the Webkit issue tracker here, including a simpler popper example as a demonstration: https://bugs.webkit.org/show_bug.cgi?id=207089
I'll look into whether there's an alternate way we can calculate the reference's bounding box and position, and will update in a few hours

Oh right I made that bug report 🤔

We see an issue with misalignment depending on whether the Safari browser chrome (top navbar, bottom toolbar) is showing or not—is this potentially a flavor of this same issue since it's about calculating bounding boxes and may depend on offsets or clientHeight/innerHeight? Happy to file a separate issue if it seems different!


python310Packages.unrardll: fix build on darwin

Description of changes
Closes #179271.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Thanks.
Unfortunately this seems to be not enough for intel:
       > error: install_name_tool: changing install names or rpaths can't be redone for: /nix/store/d6bmi8s5rm1gqj1wwxkphvl1p7gjpbv0-python3.10-unrardll-0.1.5/lib/python3.10/site-packages/unrardll/unrar.cpython-310-darwin.so (for architecture x86_64) because larger updated load commands do not fit (the program must be relinked, and you may need to use -headerpad or -headerpad_max_install_names)

@viraptor I think it is now fixed. Could you please test again?


js: More refactoring and tests

Signed-off-by: Ryan Northey<EMAIL_ADDRESS>

Codecov Report

Merging #252 (c3af898) into main (3cfb67c) will decrease coverage by 0.42%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   48.07%   47.65%   -0.43%
==========================================
  Files         104      107       +3
  Lines        2935     2940       +5
==========================================
- Hits         1411     1401      -10
- Misses       1524     1539      +15

Impacted Files
Coverage Δ

playground/control/api/listener.py
85.86% <ø> (ø)

tests/py/api/test_listener.py
100.00% <ø> (ø)

ui/src/layout/page.js
100.00% <ø> (ø)

ui/src/shared/actions.js
20.00% <ø> (ø)

ui/src/shared/alerts.js
20.00% <ø> (ø)

ui/src/shared/nav.js
20.00% <20.00%> (ø)

ui/src/shared/snippets/logotype.js
40.00% <40.00%> (ø)

ui/src/shared/snippets/repository.js
40.00% <40.00%> (ø)

ui/src/shared/widgets/clear.js
40.00% <40.00%> (ø)

ui/src/shared/widgets/saveload.js
40.00% <40.00%> (ø)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cfb67c...c3af898. Read the comment docs.


provider identifier should be equal

In Configure Keycloak as an OIDC IdP for HCL Connections keycloak is used as provider.identifier while hcl is used in Configuring the OIDC RP TAI against your IdP
Redirect URI definition in Configure Keycloak as an OIDC IdP for HCL Connections
https://github.com/HCL-TECH-SOFTWARE/hclds-keycloak/blob/b6ef56962ab2bfddef405ec0f3faeced28815e06/docs/integration/ds-integration/cnx-keycloak-configuration.md?plain=1#L33
provider.identifier definition in Configuring the OIDC RP TAI against your IdP
https://github.com/HCL-TECH-SOFTWARE/hclds-keycloak/blob/b6ef56962ab2bfddef405ec0f3faeced28815e06/docs/integration/ds-integration/cnx-integration.md?plain=1#L74
Both names for the provider identifier have to be equal.

@marde16 Thank you for bringing this up and the raised PR as well. You are right and we will look into adjusting this mismatch. We have some more points raised on the Connections OIDC documentation piece, which we currently review and plan to work back into it.

Corrected provider identifier values as part of https://github.com/HCL-TECH-SOFTWARE/hclds-keycloak/pull/8


Create empty state for collections without items

I started new project Astro + Keystatic, using official docs https://keystatic.com/docs/installation-astro.
I setup my first collection "posts" and opened Keystatic admin:

I got error:
Unable to load collection
JSON.parse: unexpected character at line 1 column 1 of the JSON data

Expected to see: empty state of this list, not an error.

This typically happens when you don't have the Keystatic API route set up properly.
There is an empty collection UI, it looks like this:

I hope to see this empty static after closing https://github.com/Thinkmill/keystatic/issues/508 😄

Closing this as #508 has also been closed, and the fix has been added to our astro template which will hopefully reduce others also hitting this issue in the future.


OWNERS file updates

Description
Updates are required to the OWNERS file to remove old maintainers and add new ones.
Checklist:

[x] I have performed a self-review of my own changes.

@gallacher: Thank you for submitting your pull request!
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.

We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at<EMAIL_ADDRESS>


Fix original curtain service data

:recycle: Current situation
The service data for the original curtain is mostly incorrect.
:bulb: Proposed solution
Use some of the original curtain service data parsing code. This has not been tested on the new curtain, so proceed with caution.
@donavanbecker you can probably revert https://github.com/OpenWonderLabs/homebridge-switchbot/pull/1092 because of this.

I think https://github.com/OpenWonderLabs/homebridge-switchbot/pull/1092 is good to have either way so I will leave it.
Thanks for fixing all of this!

I think OpenWonderLabs/homebridge-switchbot#1092 is good to have either way so I will leave it.

I would argue it's not good to have as it made this issue more difficult to fix. If anything, 0 should be ignored as it is an invalid value.


Release 2.0.0

Hi !
If I'm not mistaken, you didn't release the gem version 2.0.0.
Thank you !

released!


Sending SMS

Added script for sending sms, README and requirements.txt
Pull Request Template
script name -
sms.py
What have you Changed
New script, README, and requirements.txt
what you changed in the codebase.write here
New Script, README, and requirements.txt
Issue no.(must) - #55
Self Check(Tick After Making pull Request)

[x] This issue was assigned to me.
[x] One Change in one Pull Request
[x] My file is in proper folder (Name of folder should be in lowercase with no space in between)
[x] I am following clean code and Documentation and my code is well linted with flake8.
[x] I have added README.md and requirements.txt with my script

If issue was not assigned to you Please don't make a PR. It will marked as invalid.

Hey, @YourFriendlyError. Thanks for your contribution. Leave a star to encourage me more for creating such tasks :)

@all-contributors please add @YourFriendlyError   for  code

@all-contributors please add @YourFriendlyError for code

Hey, @YourFriendlyError. Thanks for your contribution. Leave a star to encourage me more for creating such tasks :)

Thanks!


Error: Cannot find module 'sync-request'

I have run through the instructions, I believe to the letter.  When trying to run the command "mocha tests/_suite.js" it fails giving the error "Error: Cannot find module 'sync-request'".  Any ideas on whats gone wrong?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 44581f4a-93df-7507-3844-eadedf9a6cc4
Version Independent ID: 33c7bcf0-1512-975f-5ef8-9f2a192a84ad
Content: Add a Build or Release Task
Content Source: docs/extend/develop/add-build-task.md
Product: devops
Technology: devops-ecosystem
GitHub Login: @chcomley
Microsoft Alias: chcomley

cracked it, i had the test folder in the route folder and not in the buildAndReleaseTask folder.  Maybe update the instructions so its a bit clearer?

@cpbattrick -- thank you for your feedback.
@chcomley -- please look into this issue.

I am getting this error even when I am running from within the buildAndReleaseTask
npm version
{ buildandreleasetask: '1.0.0',
npm: '6.12.0',
ares: '1.15.0',
brotli: '1.0.7',
cldr: '35.1',
http_parser: '2.8.0',
icu: '64.2',
modules: '64',
napi: '4',
nghttp2: '1.39.2',
node: '10.16.3',
openssl: '1.1.1c',
tz: '2019a',
unicode: '12.1',
uv: '1.28.0',
v8: '6.8.275.32-node.54',
zlib: '1.2.11' }
internal/modules/cjs/loader.js:638
throw err;
^
Error: Cannot find module 'sync-request'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
at Function.Module._load (internal/modules/cjs/loader.js:562:25)
at Module.require (internal/modules/cjs/loader.js:692:17)
at require (internal/modules/cjs/helpers.js:25:18)

You can work around this by installing sync-request from inside the buildAndReleaseTask folder:
 npm i --save-dev sync-request

@vairakkumar-vairaperumal Did @jasoncabot-ms's work around help? Please let us know if you're still stuck. Thanks!

Yes this resolved the problem. please update document accordingly. Don't know when that step is required to do explicitly and not required explicitly as documentation does not include that step

Fantastic, thanks for letting us know. I'm going to close this issue, however I'll link the PR to this issue, so that you're aware of when the doc has been updated. Thanks very much! In the meantime, if you do have any further questions or feedback, please @mention me in this issue. Thanks very much!


System Configuration API

What is the feature request? What problem does it solve?
VDK SDK has a lot of configuration options possible. Currently if we want to package a version for specific tenant , users need to provide things like The Control Service URL, Authorization configuration values, Database connection configuration values, etc. The same configuration is known and used by Control Service when deploying jobs in its runtime.
This kind of duplication is unnecessary and leads to worse UX for VDK SDK users. The current workaround used is to create specific python distribution with all that configuration set there which is not easy to maintain if you have many tenants.
Another problem is that currently, the only way to configure job by the Control Service is to update the helm chart vdkOptions value then upgrade the helm release and then re-deploy all jobs that need the new configuration. This is a rather long and error-prone process. It would be better for each execution  to have latest configuration upon start
Suggested solution
A clear and concise description of what you want to happen.
We can provide simple configuration API which would provide ability to get and update configuration options for jobs running in runtime.
We can also provide vdk-control-service-configuration plugin which would expose command "vdk init --control-service-url" and fetch all necessary configuration options from the server.
The proposed solution consists of endpoints in the Data Jobs service in the Control Plane, that provide CRUD over custom configuration for specific data jobs and data jobs' teams. It is similar to the data jobs properties functionality. Data jobs will read their effective custom configuration on start.
This is just a an example of how it may look:
PUT /data-jobs/for-team/{team_name}/jobs/{job_name}/config - update job specific configuration
GET /data-jobs/for-team/{team_name}/jobs/{job_name}/config - get job specific configuration
DELETE /data-jobs/for-team/{team_name}/jobs/{job_name}/config - delete job specific configuration
PUT /data-jobs/for-team/{team_name}/config - update team specific configuration
GET /data-jobs/for-team/{team_name}/config - get team specific configuration
DELETE /data-jobs/for-team/{team_name}/config - delete team specific configuration
PUT /data-jobs/for-team/{team_name}/systemconfig - update all teams default configuration
GET /data-jobs/for-team/{team_name}/systemconfig - get all teams default configuration
DELETE /data-jobs/for-team/{team_name}/systemconfig - delete all teams default configuration
GET /data-jobs/for-team/{team_name}/jobs/{job_name}/effectiveconfig - get the effective configuration for this job
GET /data-jobs/for-team/{team_name}/publicconfig - get the public-facing (non sensitive) configuration for this job (API call requires no credentials)
The object will have the following structure perhaps (key/values):
{
impala_host: 'sql.x.x.com',
impala_port: 21050,
impala_query_pool: 'my-query-pool'
}
Configuration from the data-jobs service will have precedence and will overwrite all VDK default configuration.
Configuration will be present in the Control Plane self service portal. Users will be able to modify it. Team members will be able to see custom configurations for their jobs. All will see public configuration
Additional context
Implementation wise there are a few options:

A) We can re-use properties implementation and either have some special root key for system configuration  - (the above endpints would be basically properties endpoints - we may add new ones as needed.
B) Have separate API and create separate job configuration table in the Control Service DB (extend the current data_job table in a way)
C) some combination of A and B

Another suggested solution is to use  https://docs.spring.io/spring-cloud-config/docs/current/reference/html/

Triaged. Closed as stale.


Modify update to work with patch as per rc3 spec

This commit does not allow arrays in update anymore

fixes #51


add emoji completion

Anyone have good experience with existing libs?

https://github.com/bevacqua/horsey this one is very small, good and optionated. built on top of other super small and focused libs like https://github.com/bevacqua/fuzzysearch which is awesome.

muan's emoji project will be helpful i think, includes synonyms: https://github.com/muan/emoji/

Hey, I've been working on an emoji-chat project for fun. Here's a link to my repo.  At.js combined with emojify.js is easy enough to implement, and has some good fuzzy matching.


[BUG] i noticed something when trying to server Hop on Roblox servers!!

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
it says, "Roblox is currently running, and launching another instance will close it. are you sure you want to continue launching?"

it never asked it to me, when it got updated it started to do that, and it's kinda anoying having to mark check yes on this advice every time i try to server Hop with RoPro, i play bee swarm and sometimes i go server hopping to get some items faster, and other things... but since it updated it made the process way slower, and i was wondering if i can fix that, or you could maybe put an option on Bloxtrap to disable this message, or make it to agree without having to mark yes everytime, well, thank you for your attention.

They already announced that they'd remove multi-instances before hand

this popup shows even with no instances of roblox open

Well, that is the first time it shows up to me, i had never got this problem before, so it started when the new update released, and i searched almost everywhere to see if i find something to make this go away but i didnt find out anything to solve this

yea i downgraded back to 2.5.4 for now

Thanks John, it worked! 😁


Can't use the gilding crystal

Minecraft version
1.20.1
LibX version
1.20.1-5.0.5
UtilitiX version
1.20.1-0.8.2
Forge version
47.1.3
The latest.log file

Issue description
Minecraft 1.20 comes with a new Smithing table which requires templates.
I believe this part did not get migrate yet but I wish to inform you that there is currently no way to use the gilding crystal as it is missing the template component from the recipe.
Steps to reproduce
No response
Other information
No response

I saw something in JEI with the gilding stuff but I worked on something different at that moment. I thought I fixed gilding, too. Sorry for that, will fix it asap.

Maybe this armor already has something like that. If it already has this ability, you can’t gild it.


chore(beta): pass req to defaultValue function and better type for defaultValue

Description
Currently defaultValue function argument is called only server side, so why pass only locale and user? It shouldn't be a breaking change because req contains them. You also can't use the Local API in defaultValue because of that,.
Improved type for defaultValue, should respect all non-function values and function that accepts PayloadRequest.

[x] I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

[x] Chore (non-breaking change which does not add functionality)
[x] This change requires a documentation update

Checklist:

[x] Existing test suite passes locally with my changes
[x] I have made corresponding changes to the documentation

I love the idea of passing req to defaultValue. My only concern is that adding anything in the future, outside of req will get awkward. You would then need additional args or a breaking change to nest req into an object.
I'm considering it may make sense to keep  { user, locale } and add req inside.
Maybe passing req is all we will ever need though, I can't think of a scenario that this is the case currently and adding to req is always possible in the future.

I love the idea of passing req to defaultValue. My only concern is that adding anything in the future, outside of req will get awkward. You would then need additional args or a breaking change to nest req into an object.
I'm considering it may make sense to keep  { user, locale } and add req inside.
Maybe passing req is all we will ever need though, I can't think of a scenario that this is the case currently and adding to req is always possible in the future.

I thought about that but you then you would have data duplication in the argument object, it's not like a big deal but even in for example Access where we are using user object pretty much every time it's still in the req
But i'm open to it

@DanRibbens I have a group meta field used in multiple places. I want to have the defaultValue of a checkbox inside it be true on certain collections and false on others. Is it possible to access collection in addition to req so I can do something like this:
defaultValue: ({req, collection}) => {
	return collection.slug === "target-slug";
}

Unless you have a better suggestion.

@DanRibbens I have a group meta field used in multiple places. I want to have the defaultValue of a checkbox inside it be true on certain collections and false on others. Is it possible to access collection in addition to req so I can do something like this:
defaultValue: ({req, collection}) => {
	return collection.slug === "target-slug";
}

Unless you have a better suggestion.

i think that's shouldn't be specfic to defaultValue but rather your own implementation on how are you reusing the group field?
you can always do this
import type { Field } from 'payload/types';
import type { Config } from 'payload-types';

const numberField = (collection: keyof Config['collections']): Field => {
  return {
    defaultValue: (req) => {
      switch (collection) {
        case 'admins':
          return 3;
        case 'posts':
          return 4;
      }

      return 5;
    },
    name: '',
    type: 'number',
  };
};

@r1tsuu Thank you for the suggestion! This would work, but I have to make a lot of changes to take advantage of it. I have a reusable meta field and I don't want to manually pass the collection I use it in. It is basically this:
export const metaField: Field = {
        name: "meta",
	type: "group",
        ....
        numberField('admins')
}

If I provide a parameter to numberField, I have to convert metaField to be a function and not just a field and receive this parameter anywhere it has been used just to cover this one case. If it is somehow possible to use defaultValue it seem much cleaner to me since that is what it should be responsible for anyway.

I agree with @r1tsuu. This is on the side of your config code and payload doesn't pass the collection config to itself like that. It is better that we don't introduce circular references.
Because you already have a reused field it should be quick to find and replace it or change symbol in your IDE.

Is it also possible to pass the search params? I need the id of a parent document as the default value for a drawer document (e.g. set a customer id as default value inside an order).

Is it also possible to pass the search params? I need the id of a parent document as the default value for a drawer document (e.g. set a customer id as default value inside an order).

This PR solves that as req object contains searchParams.

@r1tsuu @DanRibbens Do you guys have a status on this? I currently have a case where I need 'req' to be part of defaultValue.


docker-machine deployment does not deliver IP addresses

I tried to create a cluster over the node drivers. Everything worked and was setup correctly by docker-machine itself. However, as soon as they finish, rancher for some reason do not detect any ip adresses for them. This results in rke throwing the error Failed to validate cluster: Cluster can't have duplicate node:
To note, the name or ip is empty of all of them, and this is why rke things there is a duplicate node.

I will try to gather more information, to identify the problem, should you have a solution for me please let me know!

Please use the issue template to fill in the requested details, in this case, steps to reproduce helps especially with what node driver you are creating machines. Also, logging from the rancher/rancher container helps.

it is a custom node driver, with a non altered ubuntu image being deployed.

Without any link to what you are using, it's going to be hard to look into it.
Searching the error in the issues returns https://github.com/rancher/rancher/issues/15444, which is probably the same path for the driver.

I can't provide you the driver itself, but, actually it is a problem after docker-machine finishs executing so I suspect something with the machine being created to be wrong or some of the aftermath executed by rancher (i.e. uploading docker-machine driver config).
I can look if we can look together in the testing system.

So I tried now to deploy the created machine by hand to a custom cluster. This works immediately, so definitely something wrong with the transmission of the ip.
Can you tell me how rancher gets the ip from docker-machine @superseb ?

added rancher logs

Solved it, see added notes, thanks for the hint @superseb to the other issue, the hint in there got the solution.