Editor Selection is lost when drop down menu opens

These are some of the bugs that were logged.
#1591
#1104
#2053
#879 (they were assigned to this feature)
I was currently facing this issue as well.

We are experiencing this issue, too, but this PR does not seem to work. Are there any other lines of investigation we can look at?

@jhchen facing this issue. When will this PR get merged?

This issue still persists, any timeplan, when this will be resolved? thanks!


Add workaround for weird CodeQL releasing schema

https://github.com/github/codeql-action/pull/1561#issuecomment-1476674366 indicates that we shouldn’t look at “releases” for CodeQL.
Could you please add a workaround to the GHA version updater that handles github/codeql-action/* specially?
Thanks!

I put github/codeql-action/init@v2 into the files now, and when I run the updater, it throws an exception (though it’s not clear from the context it’s the codeql one, I just ran the updater on an almost-copy of the .github/workflows/ directory in another repo that had all but the codeql one, and it worked fine):
2023-04-17T02:42:06.7521618Z     return _run_code(code, main_globals, None,
2023-04-17T02:42:06.7521932Z   File "/usr/local/lib/python3.10/runpy.py", line 86, in _run_code
2023-04-17T02:42:06.7522221Z     exec(code, run_globals)
2023-04-17T02:42:06.7522489Z   File "/app/src/main.py", line 473, in <module>
2023-04-17T02:42:06.7522765Z     actions_version_updater.run()
2023-04-17T02:42:06.7523035Z   File "/app/src/main.py", line 59, in run
2023-04-17T02:42:06.7523296Z     self._update_workflow(workflow_path)
2023-04-17T02:42:06.7523603Z   File "/app/src/main.py", line 149, in _update_workflow
2023-04-17T02:42:06.7523917Z     new_version, new_version_data = self._get_new_version(
2023-04-17T02:42:06.7524233Z   File "/app/src/main.py", line 360, in _get_new_version
2023-04-17T02:42:06.7524547Z     latest_release_data = self._get_latest_version_release(
2023-04-17T02:42:06.7524884Z   File "/app/src/main.py", line 290, in _get_latest_version_release
2023-04-17T02:42:06.7525152Z     latest_release = next(
2023-04-17T02:42:06.7525414Z   File "/app/src/main.py", line 292, in <lambda>
2023-04-17T02:42:06.7525740Z     lambda r: self._release_filter_function(r, parsed_current_version),
2023-04-17T02:42:06.7526069Z   File "/app/src/main.py", line 271, in filter_func
2023-04-17T02:42:06.7526395Z     return any(check(release_tag, current_version) for check in checks)
2023-04-17T02:42:06.7526713Z   File "/app/src/main.py", line 271, in <genexpr>
2023-04-17T02:42:06.7527035Z     return any(check(release_tag, current_version) for check in checks)
2023-04-17T02:42:06.7527344Z   File "/app/src/main.py", line 255, in <lambda>
2023-04-17T02:42:06.7527723Z     checks.append(lambda r, c: parse(r["tag_name"]).major > c.major)
2023-04-17T02:42:06.7528161Z AttributeError: 'LegacyVersion' object has no attribute 'major'

The beginning is cut off, perhaps earlier in the log, but unsure.

The action now displays warning messages in such cases and will suggest the latest release instead of crashing. You can also skip github/codeql-action/init@v2 update by using ignore option.

OK, not crashing, and ignoring it is one thing, but maybe have a whitelist of actions for which to not look at the releases but at tags instead would make sense?


Typo and redundancies elimination

@shsagir
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

This has already been changed in a separate PR
#please-close


Localization Map<String, Map<String, Object>>

I have a need to embed an object into my Translations. It is working with my app currently and I would like to use GetX for Localization. I am getting 'Messages.keys' ('Map<String, Map<String, Object>> Function()') isn't a valid override of 'Translations.keys' ('Map<String, Map<String, String>> Function()').
Here is an example of what I am trying to do. Do you have any suggestions?
class Messages extends Translations {
  @override
  Map<String, Map<String, Object>> get keys => {
        'en_US': {
          'hello': 'Hello World',
          "honors": [
            {
              "id": 1,
              "imageAssetPath": "assets/Arts/Aboriginal_Lore.jpg",
              "category": "Arts, Crafts and Hobbies",
              "categoryType": 1,
              "name": "Aboriginal Lore",
              "shortDescription": "Aboriginal Lore",
              "yearCreated": "2001",
              "institution": "General Conference",
              "skillLevel": "1",
              "advanced": 0,
              "adventSource": 1
            },
            {
              "id": 2,
              "imageAssetPath": "assets/Arts/African_Lore.png",
              "category": "Arts, Crafts and Hobbies",
              "categoryType": 1,
              "name": "African Lore",
              "shortDescription": "African Lore",
              "yearCreated": "2001",
              "institution": "General Conference",
              "skillLevel": "1",
              "advanced": 0,
              "adventSource": 1
            }
          ]
        },
        'es_ES': {
          'hello': 'Hola Mundo',
          "honors": [
            {
              "id": 1,
              "imageAssetPath": "assets/Arts/Aboriginal_Lore.jpg",
              "category": "Artes, manualidades y pasatiempos",
              "categoryType": 1,
              "name": "Conocimiento aborigen",
              "shortDescription": "Conocimiento aborigen",
              "yearCreated": "2001",
              "institution": "Conferencia General",
              "skillLevel": "1",
              "advanced": 0,
              "adventSource": 1
            },
            {
              "id": 2,
              "imageAssetPath": "assets/Arts/African_Lore.png",
              "category": "Artes, manualidades y pasatiempos",
              "categoryType": 1,
              "name": "Lore africana",
              "shortDescription": "Lore africana",
              "yearCreated": "2001",
              "institution": "Conferencia General",
              "skillLevel": "1",
              "advanced": 0,
              "adventSource": 1
            }
          ]
        }
      };
}

Just FYI. I am able to do it in flutter_localizations. I am trying to see if you are able to do it in the GetX plugin.

I think we will not move in that direction, it makes the application unsafe.
The Text widget requires a String, if you use Object, it means that you can put anything inside it. If you enter an int for example, you will get an error, because int is not a subtype of String.
I don't know what context you use this for, but to me it sounds quite unsafe, so I think we won't move in that direction

Thank you comment. I am going to resolve it another way.

我认为我们不会朝这个方向发展，这会使应用程序变得不安全。
文本小部件需要一个字符串，如果您使用对象，则意味着您可以在其中放置任何内容。例如，如果输入int，则会得到一个错误，因为int不是String的子类型。
我不知道您将它用于什么上下文，但是对我来说，这听起来很不安全，所以我认为我们不会朝这个方向发展

Map<String, Map<String, String>>is is safe 🔐, but it is not fast enough to develop, and if there is too much text, it will be a disaster to change it


ModuleNotFoundError: No module named 'tomlkit' in relekang/python-semantic-release@master

The problem
When using the github-action relekang/python-semantic-release@master, I received he following error:
ModuleNotFoundError: No module named 'tomlkit'
error: Encountered a bad command exit code!
error:
error: Command: 'python setup.py sdist bdist_wheel'

It seems the tomlkit should be installed, because during the build it states that tomlkit-0.11.5 was successfully installed.
Expected behavior
Use tomlkit without problems in container
Additional context
My setup.py file imports tomlkit

Hi @jochemvankempen,
Thanks for reporting this - actually semantic_release setup up its own virtual environment, copies its own source code into the Dockerfile running your action, and executes the CLI command for publish from within that virtual environment (excerpt from action.sh )
/semantic-release/.venv/bin/python \
  -m semantic_release publish \
  -v DEBUG \
  -D commit_author="github-actions<EMAIL_ADDRESS>\
  ${INPUT_ADDITIONAL_OPTIONS}

I'd suggest that your build command isn't executing from within the same virtual environment, so doesn't have access to tomlkit as it was installed.
You could try setting your build_command in your semantic_release configuration to python -m pip install tomlkit && python setup.py sdist bdist_wheel which should work short-term for you.
In general, it wouldn't be advisable to rely on a package being installed for you by something else - whether through reuse of a virtual environment, or through transient dependencies (e.g. semantic_release installs click, but if you build your app/library with a dependency on click you should specify click as a dependency directly rather than trusting that semantic_release will install it for you).
I recommend you also have a look at PEP-517, PEP-518 and the use of pyproject.toml with the build-system.requires key; this is the sort of thing which can assist in your build pipeline. By specifying in that key that your project requires tomlkit to be built (as opposed to run), pip/alternative tools can ensure that the dependencies for building the project are installed before trying to build your project. In your case, as you say your setup.py imports tomlkit, you need this additional level of control over your build environment compared to a project using only the standard library in setup.py.
I have found build to be a really simple and usable tool that works well with PEP-518 compliant project metadata - a simple python -m build . will achieve the same outcome as python setup.py sdist bdist_wheel, but with the added benefit of its own isolated virtual environment using the build-system.requires dependency metadata I mentioned above.
That said, invoking setup.py directly is considered deprecated - so we should look at changing this default command at some point.
Hope this helps a bit!

Thanks for taking the time to provide such a detailed answer!
As you said, using python -m pip install tomlkit && python setup.py sdist bdist_wheel as the build_command fixed the issue.
In order to use build, I next defined build-system.requires as
[build-system]
requires = ["setuptools>=45", "tomlkit"]

and changed the build_command to:
build_command = "python -m pip install build && python -m build"

No worries, I've spent longer than I'd like to admit grappling with the last couple of years of changes in Python's packaging ecosystem, hopefully I was able to save you a bit of that pain 😂
The latter option using build looks more modern 👍 I'd recommend a couple more steps (but feel free to ignore the unsolicited advice too!):

tomlkit is still on a 0. release so you might get breaking changes (true whether or not it's 0. if you're unpinned) - it's currently on 0.11.5 so you could pin to tomlkit~=0.11.5 to ensure you get the most recent 0.11.x version but avoid breaking changes which by convention should trigger a 0.12.0 or 1.0.0. You can use whatever version of tomlkit you like since you aren't sharing an environment with `semantic_release

setuptools has recently taken full project configuration support using pyproject.toml out of beta and into full support, so if you don't want to maintain setup.cfg too you could look at condensing it all into pyproject.toml - there's a good guide here. You'll need to bump your setuptools constraint though

you should also specify build-system.backend = "setuptools.build_meta" like in the guide above, as the default is legacy behaviour for backwards-compatibility (there's some more info on PEP 517 about that)


Incompitable with CLion 2020+

Request to add support for CLion 2020+

@bazelbuild-intellij , @brendandouglas  what are your plans?

@bazelbuild-intellij , @brendandouglas bump

We're working on 2020.1 support currently. I'd expect it to be ready for the release after next (in ~3 weeks). The

@brendandouglas any way I could help? I would like to have the plug in for my workflow.

We're working on 2020.1 support currently. I'd expect it to be ready for the release after next (in ~3 weeks). The

Can you give some updates on that ?

We're moving the beta branch to 2020.1 in the current release, which should be uploaded to GitHub 2-3 weeks from now.
Though if you want something now, you should be able to build the plugin from source now, using --define=ij_product=clion-beta

The full build invocation will be bazel build //clwb:clwb_bazel_zip --define=ij_product=clion-beta

Closing as the plugin is now compatible with the latest CLion version.


ERROR: UndefVarError: Circle not defined

Hi,
I'm trying to use CircleFit in Julia 1.9.3 and ran into the error:
ERROR: UndefVarError: `Circle` not defined
I used the script from the README.md
If you let me know what the issue is, I could work on it.

After updating CircleFit I can't reproduce the error and everything seems fine. Sorry for the fuzz.

After updating CircleFit I can't reproduce the error and everything seems fine. Sorry for the fuzz.


Fixed grammar of "Vendor"

Correcting the pluralization from multiple to single.

@robertianburton : Thanks for your contribution! The author(s) have been notified to review your proposed change.

The fix looks good; thanks.


Use the built in dictionary instead of an online one

The dictionary on the device is stored encrypted and (as far as I can tell) can't be called upon by us. If someone has additional insights would love to hear them :D


Unable to clear badge icon

Running the latest iOS version (v26.29.52) on the latest iOS (13.5.1).
Steps:
Get @mentioned in a message.
Observe badge with a 1 on the homescreen
View message in the iOS app
Close app
Still observe badge with a 1 on the homescreen
Expected:
No more icon badge since I have nothing unread
I also tried opening up with the desktop app as well as explicitly killing the app on my phone.

Issues for the iOS app are tracked at https://github.com/zulip/zulip-mobile/issues.

Sorry about that. Closing in favor of https://github.com/zulip/zulip-mobile/issues/4182


How to get featureId in EXT_mesh_features.

I have points cloud tileset(3D Tiles Next). There are two featureIds(Feature ID by Vertex) in each tile.
In Sandcastle, I can't get the feaureId of the selected feature.
I can't even get Cesium3DTileFeature. Picking result is something else.

So how to get featureid?   I want to use this id to get properties from database.
Thanks.
Sandcastle example

Cesium is a big project, so we use GitHub for feature requests and bug tracking exclusively. In the future, please take any questions to the Cesium Forum where there are members of the community and developers from the team who can help. Thanks!


failed to read expected number of bytes: unexpected EOF

Description
Registry as a pull through cache，after node A completes the image pull, node B pulls and reports the following error:
E0612 14:14:38.404593  398678 remote_image.go:167] "PullImage from image service failed" err="rpc error: code = Unknown desc = failed to pull and unpack image <app_a_image:v10>: failed to read expected number of bytes: unexpected EOF" image=
FATA[0001] pulling image: rpc error: code = Unknown desc = failed to pull and unpack image  <app_a_image:v10> : failed to read expected number of bytes: unexpected EOF
Pulling other version images of app_a also reports an error.Pulling app_b image is normal.
The debug log is not enabled. After restarting the service in debug mode, it pulls normally but fails to reproduce.
Registry works in memory not redis. Is this a problem?
Reproduce
dont know..
Expected behavior
No response
registry version
2.8.3
Additional Info
No response

Can you please format your log output.
Would you mind testing this on the v3 alpha release. I'd strongly recommend against using v2.x releases.

Can you please format your log output.
Would you mind testing this on the v3 alpha release. I'd strongly recommend against using v2.x releases.

The logs that trigger the image pull are in the following form:
<IP_ADDRESS> - - [12/Jun/2024:09:45:44 +0000] "GET /v2/xxxx/blobs/sha256:xxx?ns=xxx HTTP/1.1" 200 7060 "" "containerd/v1.6.23"

INFO[12529] response completed                            go.version=go1.20.8 http.request.host="" http.request.id=07704185-422d-4b1b-afa2-e65712ba9fc8 http.request.method=GET http.request.remoteaddr="" http.request.uri="/v2/xxxx/blobs/sha256:xxxx?ns=xxxx" http.request.useragent="containerd/v1.6.23" http.response.contenttype="application/octet-stream" http.response.duration=970.833235ms http.response.status=200 http.response.written=212596670

v3 does not have a stable version and is inconvenient to go online

add logs：
ERRO[624692] response completed with error                 err.code=unknown err.detail="unknown: artifact xxxxx@sha256:xxxxx not found" err.message="unknown error" go.version=go1.20.8 http.request.host="xxxx" http.request.id=84a942de-946d-4d48-b477-8920b3aa9e5d http.request.method=HEAD http.request.remoteaddr="xxx" http.request.uri="/v2/xxxx/manifests/sha256:xxxxx?ns=xxxxx" http.request.useragent="containerd/v1.6.23" http.response.contenttype="application/json; charset=utf-8" http.response.duration=275.333756ms http.response.status=500 http.response.written=220 vars.name="xxxx" vars.reference="sha256:xxxxxx"

v3 does not have a stable version and is inconvenient to go online

This is a fair point but beware there hasn't been any updated made in v2 and will not be other than security updates.
So if there is some bug, I'm afraid we won't fix it. You'll have to wait for v3 release.

Link #2367


Edit SoW Input

As an analyst
I want to edit the SoW data
So that I can correct mistakes
Acceptance Criteria:

[ ] Click edit pen, re-opens form
[ ]

Not included:

.
.

Implementation Details

DB:

.
.

Middleware:

.
.

Frontend:

.
.

Tests:

.
.

Documentation:

.
.

closing as part of another ticket


bug: Setting nomodifiable breaks cmdline

Did you check docs and existing issues?

[X] I have read all the noice.nvim docs
[X] I have searched the existing issues of noice.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
NVIM v0.10.0-dev
Operating system/version
Ubuntu 22.04.2 LTS
Describe the bug
Setting the current buffer to nomodifiable breaks the cmdline view.
the cmdline can still be used, but it is not visable.
Note: even :set modifiable doesn't fix it.
Steps To Reproduce

nvim file
:set nomodifiable
: (cmdline doesn't appear)
type anything (errors)
press ESC

Output:
...aaron/tmp/.repro/plugins/nui.nvim/lua/nui/utils/init.lua:245: Buffer is not 'modifiable'
...ron/tmp/.repro/plugins/noice.nvim/lua/noice/view/nui.lua:292: Expected lua string
...ron/tmp/.repro/plugins/noice.nvim/lua/noice/view/nui.lua:292: Expected lua string

Expected Behavior
No errors and cmdline is still usable
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  {
    "folke/noice.nvim",
    event = "VeryLazy",
    opts = {},
    dependencies = { "MunifTanjim/nui.nvim" },
  },
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

Fixed by https://github.com/MunifTanjim/nui.nvim/pull/296


Fix PEM_write_bio_PrivateKey_traditional() to not output PKCS#8

PEM_write_bio_PrivateKey_traditional() uses i2d_PrivateKey() to do the
actual encoding to DER.  However, i2d_PrivateKey() is a generic
function that will do what it can to produce output according to what
the associated EVP_PKEY_ASN1_METHOD offers.  If that method offers a
function 'old_priv_encode', which is expected to produce the
"traditional" encoded form, then i2d_PrivateKey() uses that.  If not,
i2d_PrivateKey() will go on and used more modern methods, which are
all expected to produce PKCS#8.
To ensure that PEM_write_bio_PrivateKey_traditional() never produces
more modern encoded forms, an extra check that 'old_priv_encode' is
non-NULL is added.  If it is NULL, an error is returned.

A backport to 1.1.1 will come in a separate PR

Backport to 1.1.1 in #12729

... and with this, we discover that not all of our EVP_PKEY_ASN1_METHOD instances support "traditional" PEM or DER output...  One example: DH

This pull request is ready to merge

Merged
87d91d223b869855c11f51b54541ba8139d30d8e Fix PEM_write_bio_PrivateKey_traditional() to not output PKCS#8
bddfea0271d0596961a43283b36ff49923329a92 TEST: Adapt some tests for a stricter PEM_write_bio_PrivateKey_traditional()


Add TypeScript

By all accounts, JavaScript has been a big success for web development. I've seen loads of people sparkle with joy while working with the dynamic nature of JavaScript, unburdened by the constraints of TypeScript's explicit types. But I've never been a fan. Not after giving it five minutes, not after giving it five years. So it's with great pleasure that I can announce we're dropping JavaScript from the next big release of Turbo 8.
The fact is that I actually rather dislike JavaScript. I'd go so far as to say it's my second-least favorite language after COBOL. Yes, a distant second-least, but a least-favorite none the less. This wasn't always the case. But after TypeScript introduced us to the world of static types, and all the other improvements that came with it, it's become a real pain to write plain JavaScript.
I still don't think JavaScript is well-suited for most of the work we do on the client side of the web-app equation, but fully respect and appreciate that others feel differently. To me, it's simply our misfortune that we still have to work with such an unstructured language, which often leads to runtime errors that could have been caught at compile time.
JavaScript just gets in the way of that for me. Not just because it lacks strong typing, but because it forces us to handle type-related issues at runtime, leading to frustrating debugging sessions and unpredictable behavior. Things that should be reliable become fragile, and things that should be simple become complex. No thanks!
This isn't a plea to convert anyone of anything, though. As I discussed in Programming without types, very few programmers are typically interested in giving up strong typing. Most programmers find themselves drawn strongly to types or not quite early in their career, and then spend the rest of it justifying their choice to themselves and others.
That's part of the challenge of this JavaScript vs. TypeScript debate, and full credit to the JavaScript enthusiasts for realizing that a full take-over of TypeScript was never going to happen, so staying true to the dynamic nature of JavaScript was the way to go. Just because Turbo 8 is dropping JavaScript won't mean you can't write your client code in it, or use any other library that avoids strong typing. We get to mix and match, which is wonderful.
It's also necessary. Because unlike languages like COBOL, which are languages of choice when it comes to legacy systems, JavaScript is a language of necessity when it comes to the client side. While you may use statically-typed languages that compile to JavaScript, you still have to accept the fact that running code in the browser means running JavaScript. So being able to write that, free of any type constraints, and free of any strong typing, is a blessing under the circumstances.
So farewell, JavaScript. May you bring much unpredictability and debugging sessions to your tribe while letting the rest of us enjoy TypeScript in the structured and type-safe spirit it was originally designed: Embracing strong typing.
Full blog post: https://world.evilhey.com/theo/turbo-8-is-adding-typescript-70165c01

lgtm

:shipit:

I'm not entirely convinced that ditching JavaScript is the wisest decision. In my experience, it has been quite beneficial for contributing, and I believe it remains a reasonable choice for code at the library level. The developer experience (DX) it provides can be genuinely valuable and aids in identifying bugs.
However, I understand that it can become frustrating in specific scenarios. Nevertheless, completely discarding types (even without JSDocs and/or .d.ts files) represents a regression, adversely affecting both library users and contributors.

LGTM

W

A very well written explanation.

LGTM

Less GO 💪🏻

lgtm

lgtm

Love it

Excellent PR, lots of thought clearly went into the deep explanation

LGTM!

seems like a smart move

Looks good enough

Support!

lgtm

Fully recognize that JavaScript offers some people some advantages, but to my eyes, the drawbacks are evident in this PR. The code not only reads much better, it's also free of the complexity and limitations imposed by JavaScript.
We write all our client side code at 37signals now in TypeScript, and the same too with any internal libraries. This is going to bring that in line.
All the love and appreciation to contributors who would prefer JavaScript. This is one of those debates where arguments aren't likely to move anyone's fundamental position, so I won't attempt to do that.

Nice!

LGTM

Just fork it

Loved the Explaination!!!!

Pretty clever

PR good

This should be merged.

LGTM

great PR

Looks good to merge

lgtm

LGTM

LGTM

Going to fork turbo if this doesn't get merged

LGTM

Internet is the best thing that happened since JavaScript

Where's the blog post????

what is lgtm??

Oops

what is lgtm??

lovers of great typing machines, a cult of strong typers

what is lgtm??

Looks good to me

Let's be sure to merge this within the next hour or two so no one has the chance to provide their opinion.
We don't want to use PRs for their actual purpose.

what is lgtm??

Looks good to me

wrong

no shame: follow Stacks on our way to becoming a typesafe full-stack framework! 😃
github.com/stacksjs/stacks

Everybody's talking about it. JavaScript, folks. It's been huge for the web. Really huge. Some people – very smart people – they've loved working with it. They've told me. No TypeScript constraints, very dynamic, lots of freedom. But, and I've been saying this for a while, I've never been its biggest fan. I gave it a chance, believe me. Many chances. But now, with Turbo 8, we're making web development great again. No more JavaScript.
I've always said you have to get the best tools for the job. TypeScript, with its static types? Brilliant. Tremendous stuff. JavaScript? Not so much. It was okay for a time, but now we have better. Much better.
Some people love JavaScript. I respect that. They can do their thing. But on my watch, with the big projects? We need reliability, we need the best. TypeScript gives us that. JavaScript, with all its runtime surprises? Not on my watch.
I wrote "Programming without types" – got great reviews, by the way. Very few developers want to deal with JavaScript's lack of strong typing. And many of them, they come up to me and say, "Richard, we love types." It's true.
We're bringing change, folks. Big change. Turbo 8 won't have JavaScript, but that doesn't mean you can't use it if you want to. We're all about freedom and choices. But remember, while some old systems still run on languages like HTML, we’re all about progress.
 But for us, it's TypeScript all the way. It's stronger, it's better, and it's going to make our projects the best they've ever been. Let's keep making web development great!

LGTM

I like turtles, and this PR

lgtm

W Theo

what is lgtm??

Looks good to me

wrong

So, what is the correct?
I researched and found that.
https://www.unosquare.com/blog/what-does-lgtm-mean-in-github-code-reviews/#:~:text=The letters LGTM stand for,use it after reviewing code.

LGTM!

LGTM!

Are you a contributor or something ?

what is lgtm??

Looks good to me

wrong

So, what is the correct?
I researched and found that. https://www.unosquare.com/blog/what-does-lgtm-mean-in-github-code-reviews/#:~:text=The letters LGTM stand for,use it after reviewing code.

research better

LGTM

LGMT

LGTM

BASED AND TYPEPILLED

Ship it.

Easy Merge

LGTM

LGTM

LGTM 💪💪💪

LGTM 👌

LTGM 🤝 ✅

lgtm

Lol, drama king.

LGTM

few nits but otherwise LGTM. Ship it

LGTM!

LGTM!

merg! 🕺

LGTM

Fully recognize that JavaScript offers some people some advantages, but to my eyes, the benefits are evident in this PR. The code not only reads much better, it's also freed of the TypeError: whatToSay is not declared and mental gymnastics needed to guess what the original JavaScript authors meant when they wrote the original code.
We write all our client side code at ping.gg now in pure TypeScript and the same too with any internal libraries. This is going to bring that in line.
All the love and appreciation to contributors who would prefer JavaScript. This is one of those debates where arguments aren't likely to move anyone's fundamental position, so I won't attempt to do that.

LGTM

LGTM

Pointed out an issue @Fry98 missed. TypeScript finding bugs before running is too advanced for this project.

While that is a valid concern, DO keep in mind that TypeScript also gives us the ability to type stuff incorrectly, thus guiding contributors towards creating entirely new bugs that might otherwise never occour in a simple JS codebase where there are no misleading type definitions ready to stab you in the back.

Nice

LGTM 🚀

LGTM

LGTM !!!!

Looks ok, but nitpick: have you considered converting the entire codebase to php?

I know we should stop spamming this issue, but one last thing we should consider is how typescript offers "built in" documentation, clear or unclear, to other developers. For such a project as this one, it would actually be helpful.

LGTM

looks bad to me

LGTM

Yep, good to merge. Thanks.

🔥🔥🔥

When your at work and ask if anyone can review your PR... and everyone is too busy reviewing this 🤣🤣🚀

Ship it 🚢

Lgtm, pls merge

LGTM

this pr already has been discussed 3x as long as #971. too much discussion, should just merge

Burn.  You had ZERO issues with Rich Harris removing TypeScript from Svelte, but now that 37Signals did it here, it's an issue? Double standard much?

LGTM of course Theo is on it haha

Not gonna be active on Github reviewing typescript PRs tonight. I’m meeting a girl (a real one) in half an hour (wouldn’t expect a lot of you to understand anyway) so please don’t DM me asking me where I am (im with the girl, ok) you’ll most likely get aired because ill be with the girl (again I don’t expect you to understand) shes actually really interested in me and its not a situation i can pass up for some meaningless Github JavaScript degenerates (because ill be meeting a girl, not that you really are going to understand) this is my life now. Meeting women and not wasting my precious time online, I have to move on from such simple things and branch out (you wouldnt understand)


Why does badge notification not show in the taskbar for single window packaged winforms app?

I have made a winforms app and changed the target framework to net5.0-windows10.0.19041.0. This gives me access to Windows.UI.Notifications. I use this to make a badge notification with the following C# code:
`var xmlText = "<badge value="alert"/>";
var xmlDoc = new Windows.Data.Xml.Dom.XmlDocument();
xmlDoc.LoadXml(xmlText);
var badgeNotification = new BadgeNotification(xmlDoc);
var bu = BadgeUpdateManager.CreateBadgeUpdaterForApplication();
bu.Update(badgeNotification);`
This correctly shows a badge in the start menu, but not in the task bar, on my Windows 10 computer. When a second window is opened in the app, the badge shows up in the task bar, but when the second window is closed again, the badge disappears. Is this intended behavior? If so, how can I show a badge in the task bar for a packaged winforms app?

This is the wrong repo for this question, but I'm not sure where the correct location would be... @MikeHillberg do you know where we could route this?

StackOverflow is probably a better place for this kind of question.


Sample for MultiLineString

Hey there,
is there a way to add thersholds to MultiLineString to get something like this : http://hgoebl.github.io/Leaflet.MultiOptionsPolyline/demo/
Thanks in advance

There is a lot possible with ThemeStyle, GradientStyle and CustomStyle.
In this case it seems what is needed styling within a single Multiline. Is that correct? This is not possible in Mapsui.

Yes you are right.
Okay. Thank you for your Quick response.

I would also need Styles per LineString in one MultiLineString. Would be a great feature!


Ask for some question.(ICP,  Multi-Model, Scale)

@SurfaceMan
Thanks for your excellent work again.There are some problems I want to communicate with you.
1: I want to evaluate the matching result.
I noticed that the code use ICP, line 190-192 in the icp.cpp, the method of calculating mse is different from puplic formula of MSE, does it have particular meaning now in the code? In order to evaluate the matching precision, I use your project with puplic MSE formula to calculate RMSE, the result is beyond on 2 millimetre, the result is a little bad, I don't know whether I use wrong way.I think of use the output of  the project and use ICP algorithm with PCL library, it will increase the time,so I haven't tried it.
2: Do you have good idea of multi-model matching or will you support the function.
Now, your project performs well when one single model, scene have one or more object.However, there are many different shape object in scene, we need multi-model to match.  Do you have good idea about it.?
3:Dose ppf methods fit for multi-view or multi scale 3D object recognition?
Multi-view I means the object has the same shape as model, such as right triangle and obtuse triangle.
Multi-scale I means the object has different size from model, such as different diamater circle.

@XiaXingLuo 1.1 Line 190-192 in the icp.cpp means L2 distence average. "mse" should renamed as "avgDistance". 1.2 Matching precision depend on model size, noise, visible area, point cloud quality 1.3 Your question inspire me that distance may not a good judgment for iteration in icp, we want higher score, why not use score directly
2.1 For multi-model matching, I agree with you. So there's no plan to support that. 2.2 To decrese time cost, it's a good idea to find small range point cloud to do ppf-matching. less scene point, match faster. Like cut background if at fix position, use object detection in 2D image then project to 3D space
3.1 ppf only support rigid object, size must be same for model and target in scene 3.2 What you mean multi-view, deformation? If true, ppf can't handle it.

Thanks for your reply.
1.1 Get it! ,I did test, the results of "avgDistance" and MSE  are not much different in match score, but have a little difference in rotation matrix, leading difference matching effects visually.
1.3 Use higher score to evaluate the matching result is false propositions in my view. I don't know the ground truth.Higher score result only exists in one test, only using score doesn't convince other people, most people may would rather use specific number of precision than score.But it seems that there is no good idea to evaluate the matching result, even though known ICP, the fitness score only provides references.What's more, in other paper on 3D matching include non-rigid and rigid also use time and RMSE to  compare and evaluate, and the value of RMSE is about 5 millimeter.
2.2-2.2 I will try it with your valuable advice.
3.1-3.2 Yeah,I means deformation.There is high-speed template matching algorithm based on shape-based multi-target and multi-angle algorithm in Halcon, but it seems only to fit for image detection not for 3D.

@XiaXingLuo
Halcon :deformable surface-based

@XiaXingLuo Halcon :deformable surface-based match

Thanks.I got it. This is commercial tools. I just don't know how they achieve the algorithm, maybe I should do more research.


Auto-Schema Module

Goal
To allow users to use Weaviate without having to define a schema first, we would like to add an auto-schema module.
Design
The module should behave in the following way:

When the module is present, the schema can still be created manually
When a previously seen class is imported, which contains a property that Weaviate has not seen yet, the module alters the schema before importing the object. See section "DataTypes" below for details on how a property should be created
When a previously seen class is imported, which contains a property which conflicts with the current schema type, an error is thrown. (e.g. trying to import a string into a field that exists in the schema as int)
When a previously unseen class is imported, the class is created alongside all the properties

Datatypes
Weaviate needs to guess the datatypes based on the objects it sees, for this the user can set some preferences. e.g.

AUTOSCHEMA_DEFAULT_STRING=text would tell Weaviate that when it sees a prop of type string, it should treat it as text (as opposed to string)
AUTOSCHEMA_DEFAULT_NUMBER=number would tell Weaviate that when its sees a numerical value, it should treat it as number as opposed to int, etc.
The above configurable defaults will themselves default to something reasonable, if they are not set.

In addition, we need to catch types we do not support at all:

Any map type is forbidden, unless it clearly matches one of the two supported types phoneNumber or geoCoordinates
Any array type is forbidden, unless it is clearly a reference-type. In this case Weaviate needs to resolve the beacon and see what the class of the resolved beacon is, since it needs the ClassName to be able to alter the schema.
... possibly others

mark as not stale


Add Datadog alert destination (#6476)

Add Datadog alert destination

Fix Datadog Event API response code: 200 -> 202

Add datadog alert dest test

Sort test_destinations.py imports

Fix test_datadog_notify_calls_requests_post

Fix datadog alert dest: Add aggregation_key

What type of PR is this?

[ ] Refactor
[ ] Feature
[ ] Bug Fix
[ ] New Query Runner (Data Source)
[ ] New Alert Destination
[ ] Other

Description

How is this tested?

[ ] Unit tests (pytest, jest)
[ ] E2E Tests (Cypress)
[ ] Manually
[ ] N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@ofiliojo I noted this in the related shortcut ticket, but can you run redash tests before approving? I wasn't able to get an environment setup.


Hide irrelevant issue/PR filters

In a repo's issue/PR list, some filters are irrelevant for specific repos:

Labels if there are no labels in the repo
Projects if there are no projects in the repo
Milestones if there are no milestones in the repo
Status if there is no CI in the repo

These filter buttons can be hidden to unclutter the UI (and maybe make space for more useful features).

IssueHunt Summary

Sponsors (Total: $40.00)

 issuehunt ($40.00)

Become a sponsor now!
Or submit a pull request to get the deposits!
Tips

Checkout the Issuehunt explorer to discover more funded issues.
Need some help from other developers? Add your repositories on IssueHunt to raise funds.

@issuehunt has funded $40.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

Important part:

the only way this can work effectively is to create a single v4 API call to query if ANY issues have ANY of the above


[Feature Request] Spatie Medialibrary Upload and Upload Multiple Field

Feature Request
What's the feature you think Backpack should have?
Upload and Upload Multiple Field but work with spatie media library
Have you already implemented a prototype solution, for your own project?
Hmm only for the backend part for single file collection, but not the blade field views. I think you can see mine in the gitter chat logs if u scroll up for a few days.
Do you see this as a core feature or an add-on?
Core. Spatie MediaLibrary is pretty much the defacto library for managing file uploads in laravel projects these days.

Yup, it's on the roadmap, probably going to do it by end of August 2022 🎉


Multiple identities

I'm trying to create a web app where each user will have their own personal files, but can also view other users' files (read-only) in the same app.
Is there any way to create a second identity, with separate permissions, in (for example) a second Beaker window, so that I can test viewing another user's files without having to have a second physical machine to create the "other user"'s files on?
(I'm assuming that creating a new Windows user account might let me do it from a single machine, but switching back and forth between two separate Windows user accounts is only slightly less inconvenient at that...)

Unfortunately I think you'll just need to "fake it" for now. I believe the only state you need to modify to fake it is the writable flag so it's not terribly difficult.


Update to System.Text.Json Preview7 and change how we read properties

See comment here: https://github.com/Azure/azure-sdk-for-net/pull/6457#discussion_r290346418

This is mostly done, but there's a few seldom-touched stragglers like the shared KeyVaultPage.


sched/mqueue: choose either mqueue or sysv at one time

Summary
Only one initialization is needed for mqueue and sysv.
Impact
mqueue
Testing
./tools/configure.sh sim:citest pass

[Experimental Bot, please feedback here]
No, this PR does not fully meet the NuttX requirements.  The provided information is far too brief.  Here's a breakdown of what's missing:

Summary:

Lacks crucial details.  "Only one initialization is needed" is vague. Why was multiple initialization happening before? What specific change was made to address it? How does the single initialization now work? Which files were modified?
Missing issue references if applicable.

Impact:

Simply stating "mqueue" is insufficient.  Does this affect the user?  The build process? Hardware? Documentation? Security? Compatibility?  Each of these requires a "YES/NO" answer and a description if "YES".

Testing:

Insufficient build host information.  What OS, CPU architecture, and compiler version were used?
"sim:citest pass" is better than nothing but still minimal. What specific tests were run? Were only the citest tests run?  What about other relevant tests?
Critically, the "Testing logs before change" and "Testing logs after change" sections are empty.  Without these, there's no evidence provided that the change actually fixes a problem or improves anything.  These logs are crucial for reviewers to understand the impact of the change.

In short: The PR needs significantly more detail to be considered complete. It needs to clearly articulate the problem being solved, the specific solution implemented, the full impact of the change, and provide concrete evidence (logs) that the change works as intended.


Add (very partial) Ansi support

Hi, This si a preliminar support for ansi escape code using termit-ansi for parsing.
I want to know if you are interrested by such a feature.
If so I'll need some feedback: I'm still a newbie at rust and I'm not very happy with all the heap allocation going in the AnsiHandler, but I don't know any better since lifetime annotation are not used in the trait ...

I think I understand what you are trying to achieve with this but I'm not sure whether this functionality should live in this crate. Since this crate is abstracting away the ansi escape sequences and has settled on the Text and Style, transforming the input to those structs is not really the responsibility of this crate but of your application. If it was a common enough issue, this could also be implemented in a third-party widget.

So my uses case is that I'm writing a mud-client and I can receive color-formatted text.
Handling this style is not the concern of the mud domain but rather of the ui. At that moment, the feature looking generic enough, it seemed natural to make a PR. However now that you point it, I see how it is paradoxal that on one hand the whole library abstract the ansi code while on the other hand there is this bizarre feature that propose to directly interpret the ansi character.
I think the idea of the third-party widget is what makes more sens.

I'm closing since we kind of agree on the whether it should be part of this crate. I would happily link to a third-party widget or to some examples showing how it could be done if you managed to put something together.


[vite-node] fails on @storybook/react

Describe the bug
I am using vite-node to evaluate some of our code to get values from it. Using the base setup from README.
The snippet is following:
import { storiesOf } from '@storybook/react';
import * as React from 'react';

storiesOf('Avatar Converged', module)
  .addDecorator((story) =>
{story()}
)
  .addStory('basic', () => (

  ));

Execution is fails with:
Error: Cannot read properties of undefined (reading 'location')
    at ESMLoader.import (https://stackblitzstartersw8bzdo-ywrm.w-credentialless.staticblitz.com/blitz.1df59e15.js:35:1312912)
    at i.loadESM (https://stackblitzstartersw8bzdo-ywrm.w-credentialless.staticblitz.com/blitz.1df59e15.js:35:315882)
    at handleMainPromise (https://stackblitzstartersw8bzdo-ywrm.w-credentialless.staticblitz.com/blitz.1df59e15.js:35:1079791)

It fails on document.location and other accesses to document, for example: https://github.com/storybookjs/storybook/blob/d8a18a9642ea43c7d70ed6c762caf2822a643aa0/code/lib/preview-api/src/modules/preview-web/UrlStore.ts#L25
The question is tricky, should vite-node handle such cases? What is the expectation?
Reproduction

Open https://stackblitz.com/edit/stackblitz-starters-w8bzdo
Run node index.mjs
💥Error: Cannot read properties of undefined (reading 'location')
    at ESMLoader.import (https://stackblitzstartersw8bzdo-ywrm.w-credentialless.staticblitz.com/blitz.1df59e15.js:35:1312912)
    at i.loadESM (https://stackblitzstartersw8bzdo-ywrm.w-credentialless.staticblitz.com/blitz.1df59e15.js:35:315882)
    at handleMainPromise (https://stackblitzstartersw8bzdo-ywrm.w-credentialless.staticblitz.com/blitz.1df59e15.js:35:1079791)

System Info
Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 7.17.0 - /usr/local/bin/npm
  npmPackages:
    vite: ^4.3.9 => 4.3.9
    vite-node: ^0.31.4 => 0.31.4

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

ViteNode doesn't come with DOM environment. It runs code with regular globals.


v5 Actors Prep

Summary of changes
Changes introduced in this pull request:

release fil_types 0.2.1 crate
release actors crate 3.0.0 (v4 actors)
bump local version of actors to 4.0.0 (v5 actors)

Reference issue to close (if applicable)

Closes
Other information and links

@ec2 Will this require change in the state migration PR?

It shouldn't.


Pepper meshes/3d model

Hi,
I am trying to map Qibullet with another software for animation control, I need the exact measurements for Pepper. Is it possible to get a .bvh, or .dae, or .fbx format for 3d model for pepper? Also I tried to unzip meshes.zip but it asks for the password, are we allowed to get one from softbank? Please let me know, thanks
Amol

Hi, as specified in the README, the meshes cannot be installed manually, the installer will do that for you. To be able to install the meshes, you will have to agree to the license under which the meshes are published (see here). You can find additional information on that topic in the qiBullet wiki.
Can you give me more details about what you're trying to achieve ?

Hi,
I wanted to get the exact measurements for the joints as I am mapping the qibullet simulator with another animation controller s/w. I got them my physically measuring them,
floor -> Hip: 70cm
Hip -> Head (top): 50cm
Hip -> RShoulder: 30cm
floor -> Knee: 35cm
RSHoulder -> RElbow: 20cm
RElbow->RWrist: 15cm
RWrist -> Tip of fingers: 10cm
I still can't move/rotate the wheels, is this not supported by qibullet?

If you want the distances between the different links of the Pepper robot (RElbow -> RWrist, etc.) you don't need the meshes, you only need the information provided by the Pepper URDF.
And yes, your can map the movements of a real Pepper robot onto a simulated one, take a look at the shadowing example

Hi,
I wanted to get the exact measurements for the joints as I am mapping the qibullet simulator with another animation controller s/w. I got them my physically measuring them,
floor -> Hip: 70cm
Hip -> Head (top): 50cm
Hip -> RShoulder: 30cm
floor -> Knee: 35cm
RSHoulder -> RElbow: 20cm
RElbow->RWrist: 15cm
RWrist -> Tip of fingers: 10cm
I still can't move/rotate the wheels, is this not supported by qibullet?

Thanks, the Pepper UDRF file was not easy to decipher to get those measurements, so I used the old fashion measuring tape ;)  I will take a look at shadowing example.


Future of SwifterSwift

Future of SwifterSwift
First of all I want to thank you all for making SwifterSwift what it is today 🚀
Here are some insights from Github

132 contributors!
4000+ monthly repo visitors
4500+ monthly clones
500+ monthly visitors to swifterswift.com

For many of the 132 contributors (including me), SwifterSwift was the first open source contribution, how cool is that!
I wanted to share my vision for the project going forward and gather your feedback. Lets shape the future of SwifterSwift together!

Goals
Create a safe and welcoming environment for others to learn and grow through Open Source.
Unlike other open source projects, contributing to SwifterSwift does not require a deep knowledge of the code base, nor the history behind it, all you need is a Swift extension that you want to share with the community!
After your first pull request is merged, you will automatically receive an invitation to join the organization on Github, so you can show that nice "SwifterSwift" badge in your Github profile, but more importantly you're now one of us, you can review pull requests and drive the future of the project!
We want to make it even easier for everyone to contribute to the project by automating some of the confusing parts for new joiners, like adding a change log entry.
SwifterSwift was how I got to love open source, I personally learned tons and made many friends!
Experiment with Github Actions
Utilize Github Actions to automate monthly releases without having one of the team to trigger the process manually.
A few years ago -frankly when Swift 3 was released- we thought it is a good idea to sync SwifterSwift's version with Swift's versions

SwifterSwift v3 supports Swift 3
SwifterSwift v4 supports Swift 4
SwifterSwift v5 supports Swift 5
...

Now that Swift is reaching a level where the language is mature enough and its features are evolving slowly, we need a versioning system that gives us more flexibility releasing more versions.
CalVer is a promising option that will enable us to have fully automated monthly releases.

SwifterSwift v2021.06.01 the first release of June 2021
SwifterSwift v2021.06.02 the second release of June 2021
SwifterSwift v2021.10.01 the first release of October 2021

We can use Github Actions' scheduled events to release a new version every month without the need for any of the maintainer time to trigger the process or sign off the release.
swifterswift.com
Create a website where people can search for extensions and copy-paste them to their projects with ease.
An automated script will make sure the website is always up to date whenever a change is made is the main branch.
To make generating the website easier, some changes will be made to the current structure
Project folder structure
SwifterSwift
├─ Sources/
│  ├─ Int+Extensions.swift
│  ├─ String+Extensions.swift
│  ├─ UITableView+Extensions.swift
├─ Tests/
│  ├─ Int+Extensions_Tests.swift
│  ├─ String+Extensions_Tests.swift
│  ├─ UITableView+Extensions_Tests.swift
├─ Generated/
│  ├─ extensions.json (or some other format)

The Generated folder will contain files that the website uses to display its content. the CI regenerates them every time a change is made in the main branch.

Extensions in a .swift file should adhere to the following rules:

A single extensions should declare the type it extends, and its dependencies, including import statements, #if checks, and a doc comment.
A single extensions should always start with // start.ext and end with a // end.ext comments.
Extensions CAN NOT depend on other extensions from the library, nor create any private classes, structs, or methods in the global scope, they should be self contained.

The CI will treat everything between // start.ext and // end.ext as a single unit creating a nice html page in swifterswift.com

It might be also possible to check extensions in isolation to make sure they don't have any cross dependencies.

Example String+Extensions.swift
// start.ext
public extension String {
    /// SwifterSwift: Check if string contains only letters.
    ///
    ///     "abc".isAlphabetic -> true
    ///     "123abc".isAlphabetic -> false
    ///
    var isAlphabetic: Bool { ... }
}
// end.ext

// start.ext
#if canImport(Foundation)
import Foundation
public extension String {
    /// SwifterSwift: CamelCase of string.
    ///
    ///     "sOme vAriable naMe".camelCased -> "someVariableName"
    ///
    var camelCased: String { ... }
}
#endif
// end.ext

// start.ext
#if canImport(Foundation) && canImport(UIKit)
import Foundation
import UIKit
public extension String {
    /// SwifterSwift: Add color to string.
    ///
    /// - Parameter color: text color.
    /// - Returns: a NSAttributedString versions of string colored with given color.
    func colored(with color: UIColor) -> NSAttributedString { ... }
}
#endif
// end.ext

El Plan
1. Gather feedback
@SwifterSwift/contributors, Please help us by adding thoughts or any concerns you have here 😊
2. Create a PoC for swifterswift.com
Use a small set of the extensions to create a PoC for the website and gather feedback about the website.
3. Check extensions individually
Check extensions and make sure they adhere to the the standards, this might create some breaking changes, as we will remove some enums and structs that sneaked into the library overtime.
4. CI changes
Update our CI scripts
5. First automated release
It would be very nice to have everything ready before october, to welcome many new joiners during Hacktober fest.

Ayy, what a nice post. And I can confirm, SwifterSwift helped me a lot too, it's such an awesome project, thank you <3
The plan looks great. I didn't fully dive into it yet, but apparently DocC is a thing since WWDC21. Don't know how stable it is yet, but might be worth checking out :)

While the automatically month release is a very useful and excellent idea, I still have concerns as to how semantic versioning will be enforced. Then, manual interference with the releases are still unavoidable because maintainers need to decide whether it's a patch, minor, or major feature.
Also, would sufficient updates and changes justify a new version released every month? What if a ton of changes were made in January, but almost no change was made in February?

nor create any private classes, structs, or methods in the global scope

So are SwifterSwift extensions allowed to create classes and structs not in the global scope, but within the extension itself?

I think it's mostly easy to make it automatic-ish.
You could enforce a flag/label on each PR that a contributor must mark to say if it's a breaking change or not and then make a decisions based on whether or not the past 30 days included a label with breaking (major), additive (minor) or bug fix (patch).
You could make this even more automatic by using something like SourceKitten to figure out if the diff of a PR includes such changes and automatically label the PR accordingly.

nor create any private classes, structs, or methods in the global scope

So are SwifterSwift extensions allowed to create classes and structs not in the global scope, but within the extension itself?

Types should be avoided in general, but basically, they should not be created outside your extension, here are two examples
Allowed
extension String {
    func test() -> String {
        struct Test {
            let word: String
        }
        return Test(word: "Hello").word
    }
}

Not allowed
extension String {
    struct Test {
        let word: String
    }
    func test() -> String {
        return Test(word: "Hello").word
    }
}

I think it's mostly easy to make it automatic-ish.
You could enforce a flag/label on each PR that a contributor must mark to say if it's a breaking change or not and then make a decision based on whether or not the past 30 days included a label with breaking (major), additive (minor) or bug fix (patch).
You could make this even more automatic by using something like SourceKitten to figure out if the diff of a PR includes such changes and automatically label the PR accordingly.

I like the idea of PR flagging, but I'm worried this will make things a bit more difficult for new contributors.
As for SourceKitten, I think it will be a bit challenging with many edge cases, this could be its own project 😄

While the automatically month release is a very useful and excellent idea, I still have concerns as to how semantic versioning will be enforced. Then, manual interference with the releases are still unavoidable because maintainers need to decide whether it's a patch, minor, or major feature.
Also, would sufficient updates and changes justify a new version released every month? What if a ton of changes were made in January, but almost no change was made in February?

Well, that is the whole reason behind moving to CalVer + the new website!
We're saying: SwifterSwift is more like a snippet's library, if you want to use it as a dependency (not sure it is a good idea btw 😅 ) you might want to fix the version


error: n is not defined (Has possible fix solution attached)

After building a production version of my VUE app, the error throw "n is not defined". (No issue in dev version)
This issue only happens in .min.js:
/dist/vue-image-upload-resize.umd.min.js
You can locate the error function by searching the following pattern (that's where I found the issue)
{var i="";for(n=t;n<t+r;n++)i+=String.f
I simply add let before the variable and the issue solved in my case. (I tested it in my production build.)
After my edit:
{var i="";for(let n=t;n<t+r;n++)i+=String.f
Thank you again for your work, and I do appreciate it. Please consider my case and fix it, cause I believe it is a good VUE image uploader which is very helpful for so many possible projects.

The version I mentioned early is 2.0.4.

Hi @ArbestNew, thank you for noting this issue and for the proposed fix. And thank you for your patiences with my late reply.
I believe the problem is inherited from the exif-js dependency, which it seems is no longer actively maintained (se e.g https://github.com/exif-js/exif-js/pull/50). I probably need to update a fork that better handles module loading/strict mode.
Until then I'll leave this issue open.

Is there a other workaround, other than chaning the minified output file?

@ArbestNew og @memic84 thank your for you patience on this one.
I'll be publishing av new version 2.1.0 with the exif utility inlined this weekend. That should resolve this issue.
Thanks!

Resolved with 2.1.0 :)


Unable to locate a class or view for component [flag-country-yu].

cant find flag for :
'YU' => 'Yugoslavia',

Will be added in the next release, Thank you @BenOussama180

Will be added in the next release, Thank you @BenOussama180

is there any way to check if the dynamic compoenent exists and only then render it ? because i dont know how to fix this issue in my code

Will be added in the next release, Thank you @BenOussama180

is there any way to check if the dynamic compoenent exists and only then render it ? because i dont know how to fix this issue in my code

i tried with View::exists but it wont render anything

I've tried to do this, but can't find a solution for it I will try to work around maybe I can find a way to prevent this from happening

@BenOussama180 give me 2 hours I will add this flag for you, Thanks

@BenOussama180 give me 2 hours I will add this flag for you, Thanks

thanks alot , no rush take your time!

@BenOussama180 released


docs(RingTheory/Finiteness/Defs): specify namespace of Finite

Currently, Module.Finite and RingHom.Finite have docstrings that link to Finite, which is confusing.

Nicely spotted, thanks!
bors merge


Work towards PEP8

I tried to catch as many things as I could while my brain was frying over the code I was going through. Hopefully I didn't miss any glaring problems! The majority of changes are:

Using {} and .format() for strings instead of %s and %.
Using print() instead of print
Removing unnecessary whitespace, but also adding necessary whitespace
Cleaner indentation to try to keep lines below 80 characters and improve readability/maintenance.
Removal of imported libraries that weren't used.
Commenting out variables that were assigned but never used.
Fixing variables that were fat-fingered.
Marking #TODO in locations where there are undefined name errors as I'm not sure where they are supposed to come from or if pyflakes is just going nuts (lots of them seem to be globals but also not defined in the file).
Moved some code around to keep classes and functions together in the same file.

I suspect this will need some going through as it is a large set of changes, but I tried not to modify any code that would cause functionality changes.

Thanks for taking this on @mgoffin
I'll need to look through this more carefully but one thing I noticed right away is that you're going to break python 2.6 compatibility with your string formatting. It does not support zero length field names (e.g. you'd need {0} instead of {})

Ahh, I didn't realize you were still supporting 2.6. That's my mistake! I can go back and fix this.

@mgoffin did you use an automated tool to make these changes or was it manual? Or a combination of automated and manual?
Trying to figure out how much scrutiny I need to give this PR.

This was all manual. I didn't want to run anything automated that would make changes I didn't understand.

In general I don't have a problem with working towards PEP 8 (aside from the 79 character line.. but that's bordering on political debate).
However, I am concerned about the sweeping changes across so many files and my ability to test all of them sufficiently in a timely manner. My eyeball didn't catch this one for instance, but it broke laikad nonetheless:
$ python laikad.py
Traceback (most recent call last):
File "laikad.py", line 1113, in
main()
File "laikad.py", line 1053, in main
gracetimeout)
File "laikad.py", line 472, in init
(randint(0, 0x10000), randint(0, 0x10000)))
ValueError: Unknown format code 'X' for object of type 'str'
Hard breaks like this one are great because we can go fix it.. I'm worried about the more subtle ones that change how the program operates but do not break it completely.
 How did it work out?

Hmm, I remember testing that line of code. I'll give it another look.
I had to do this for the pytx library, though it was code I was very familiar with having written it all, and the amount of prints in that code is minimal. It required a little testing to make sure any edge cases were caught, but that's the nature of the game with projects like this :)
I'll see what I find with this error and get a fix pushed to the branch!

This is pretty weird. So the format docs (https://docs.python.org/2/library/string.html#formatspec) have an example identical to what we are doing:
>>> octets = [192, 168, 0, 1]
>>> '{:02X}{:02X}{:02X}{:02X}'.format(*octets)
'C0A80001'
>>>

And if I try this in python shell it works fine:
>>> foo = "{0:04X}-{1:04X}".format(randint(0, 0x10000), randint(0, 0x10000))
>>> foo
'3FDA-9283'
>>> foo = "{0:04X}-{1:04X}".format(randint(0, 0x10000), randint(0, 0x10000))
>>> foo
'C004-EBD5'
>>> foo = "{0:04X}-{1:04X}".format(randint(0, 0x10000), randint(0, 0x10000))
>>> foo
'F250-3D90'
>>>

Trying to determine what laikad.py is doing that is causing this to not work.

In your question for 79 character lines you added an extra set of parentheses ;-)

Well played!

Is there anything else we can look at here to get this merged? :)

What do you think about breaking this up into more manageable chunks? I think that would make reviewing and testing a whole lot easier. Maybe a couple modules at a time to start? A partner of ours developed a module testing framework that we've been using with some success. Hoping they open source it soon.
The framework and the executable scripts worry me the most because they're complex and we don't have good tests for them.

It's going to be a giant pain to push the changes aside and submit PRs one or two files at a time.


Compilation error on nightly toolchain

Hi! It seems to me that compilation fails on nightly toolchain. I'm experimenting with very basic leptos app following official book and after adding styler to dependencies I got this:
[package]
name = "leptos-tutorial"
version = "0.1.0"
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
leptos = { version = "0.4.5", features = ["csr", "nightly"] }
stylers = "0.3.1"

   Compiling stylers v0.3.1
error[E0615]: attempted to take value of method `column` on type `proc_macro::Span`
  --> /Users/mslawins/.cargo/registry/src/index.crates.io-6f17d22bba15001f/stylers-0.3.1/src/style/css_style_rule.rs:74:47
   |
74 | ...                   pre_col = end.column;
   |                                     ^^^^^^ method, not a field
   |
help: use parentheses to call the method
   |
74 |                                 pre_col = end.column();
   |                                                     ++

error[E0615]: attempted to take value of method `line` on type `proc_macro::Span`
  --> /Users/mslawins/.cargo/registry/src/index.crates.io-6f17d22bba15001f/stylers-0.3.1/src/style/css_style_rule.rs:75:48
   |
75 | ...                   pre_line = end.line;
   |                                      ^^^^ method, not a field
   |
help: use parentheses to call the method
   |
75 |                                 pre_line = end.line();
   |                                                    ++

error[E0615]: attempted to take value of method `column` on type `proc_macro::Span`
  --> /Users/mslawins/.cargo/registry/src/index.crates.io-6f17d22bba15001f/stylers-0.3.1/src/style/utils.rs:60:25
   |
60 |     let cur_col = start.column;
   |                         ^^^^^^ method, not a field
   |
help: use parentheses to call the method
   |
60 |     let cur_col = start.column();
   |                               ++

error[E0615]: attempted to take value of method `line` on type `proc_macro::Span`
  --> /Users/mslawins/.cargo/registry/src/index.crates.io-6f17d22bba15001f/stylers-0.3.1/src/style/utils.rs:61:26
   |
61 |     let cur_line = start.line;
   |                          ^^^^ method, not a field
   |
help: use parentheses to call the method
   |
61 |     let cur_line = start.line();
   |                              ++

error[E0615]: attempted to take value of method `column` on type `proc_macro::Span`
  --> /Users/mslawins/.cargo/registry/src/index.crates.io-6f17d22bba15001f/stylers-0.3.1/src/style/utils.rs:65:20
   |
65 |     *pre_col = end.column;
   |                    ^^^^^^ method, not a field
   |
help: use parentheses to call the method
   |
65 |     *pre_col = end.column();
   |                          ++

error[E0615]: attempted to take value of method `line` on type `proc_macro::Span`
  --> /Users/mslawins/.cargo/registry/src/index.crates.io-6f17d22bba15001f/stylers-0.3.1/src/style/utils.rs:66:21
   |
66 |     *pre_line = end.line;
   |                     ^^^^ method, not a field
   |
help: use parentheses to call the method
   |
66 |     *pre_line = end.line();
   |                         ++

For more information about this error, try `rustc --explain E0615`.
error: could not compile `stylers` (lib) due to 6 previous errors
2023-07-19T19:22:33.919608Z ERROR ❌ error
error from HTML pipeline

Caused by:
    0: error from asset pipeline
    1: error during cargo build execution
    2: cargo call returned a bad status

Bare in mind that I'm very new to both Rust and leptos, so I may be the cause.

Hi, I have merged the fix for this issue and it is not yet published in the crates. I think using below line Cargo.toml will solve the problem.
stylers = { path = "https://github.com/abishekatp/stylers.git" }
Also make sure to use the rust nightly version >=1.72.0

Hi, Let me know if this solves the problem.

@abishekatp i can confirm that patching version with one from git - solves the issue for me.


doc: add mention of AUR package to README.md

Hey,
I have created an Arch User Repository (AUR) package for this repository under the name sway-overfocus. Software from the AUR is very convenient to install for users of the pacman package manager (which is the default for Arch Linux and Manjaro) over an installation from source. The package currently tracks the 0.2.3 version, as given by the tag.
Feel free to add a mention to this package to the README if you would like.
Note: While creating the package, I noticed that the package versions for sway-overfocus differ in the Cargo.toml (0.2.3) and Cargo.lock (0.2.2) files. I currently circumvent this issue in the build process by using sed to adjust the version in the lockfile. Please let me know if this intended or if you plan to fix this discrepancy.

In case you never heard of the AUR, let me quote from the Arch Linux wiki:

The Arch User Repository (AUR) is a community-driven repository for Arch users. It contains package descriptions that allow you to compile a package from source with makepkg and then install it via pacman. The AUR was created to organize and share new packages from the community and to help expedite popular packages' inclusion into the community repository.

In case you have any questions or concerns, or would like me to take the package down, please let me know. Thank you for providing this great piece of software!

Looks cool! I'm in the middle of a move, so I'll get back to you in a few days!

Had a bit of time to look at it.
The version being different in the .lock is a mistake on my part. I'm thinking I could fix it in a new commit and change the v0.2.3 tag to point at this, but maybe changing a release tag is a bad idea. What would you suggest?
Looking at the AUR package, I see that it's using rust-bin-nightly. Is it compiling using the nightly toolchain? The program should compile fine on stable.

The version being different in the .lock is a mistake on my part. I'm thinking I could fix it in a new commit and change the v0.2.3 tag to point at this, but maybe changing a release tag is a bad idea. What would you suggest?

From a packaging perspective, this would be no problem at all. I can just re-release the package once you repoint the tag. Releasing a new tag (e.g. v0.2.3-fix or similar) would be no problem either, I can just bump the package version in that case.
I have had a quick search myself and found some opinions suggesting that changing version tags after they have been published is considered bad practice (see e.g. this SO answer). Ultimately, it is up to you how you want to handle it, neither option (including doing nothing) is a real problem from my standpoint. Whatever option you choose, at the latest, this will cease to be a problem with the release of next regular version.

Looking at the AUR package, I see that it's using rust-bin-nightly. Is it compiling using the nightly toolchain? The program should compile fine on stable.

I assume you are referring to this tab?

The names in parentheses are all package names that provide the requested dependency (cargo in this case). Which package is actually used depends on what the user has installed. The Arch wiki Rust packaging guidelines recommend directly depending on the cargo tool and I would like to follow that recommendation.
(Note that the same list appears for other well-known AUR Rust packages, e.g. rustup-git or ripgrep-git.)

Alright, I decided to release  v0.2.3-fix, it should have the correct version in Cargo.lock.
And I can see that it's building on stable, all good. I was just skimming the dependencies a bit too quickly!


[qcoro-qt5] New port

[x] Changes comply with the maintainer guide
[x] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
[x] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
[x] The versioning scheme in vcpkg.json matches what upstream says.
[x] The license declaration in vcpkg.json matches what upstream says.
[x] The installed as the "copyright" file matches what upstream says.
[x] The source code of the component installed comes from an authoritative source.
[x] The generated "usage text" is accurate. See adding-usage for context.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is in the new port's versions file.
[x] Only one version is added to each modified port's versions file.

@microsoft-github-policy-service agree

I disabled support for OSX for now, because Apple Clang compiler ICEs in Release build, I need to reproduce it in upstream CI and debug the problem further to be able to find out how to workaround the ICE.

this PR can be closed. and the port in the other PR can be renamed to qcoro only and depend on the qt6 ports only. Feel free to provide an overlay in your repo to support qt5.


Roll Engine from 6001d2ed5845 to b6cba42c0245 (8 revisions)

https://github.com/flutter/engine/compare/6001d2ed5845...b6cba42c0245
2022-03-14<EMAIL_ADDRESS>Roll Dart SDK from eab48bbaad87 to 24bf86f16411 (5 revisions) (flutter/engine#32011)
2022-03-14<EMAIL_ADDRESS>Roll Skia from c9e9131f44e2 to 23cb29441338 (3 revisions) (flutter/engine#32010)
2022-03-14<EMAIL_ADDRESS>Roll Skia from 4ee8dab839e8 to c9e9131f44e2 (1 revision) (flutter/engine#32008)
2022-03-14<EMAIL_ADDRESS>Revert: Partially remove setSystemUiVisibility() usages (flutter/engine#32007)
2022-03-14<EMAIL_ADDRESS>Roll Dart SDK from 55b9ec4e382a to eab48bbaad87 (5 revisions) (flutter/engine#32004)
2022-03-14<EMAIL_ADDRESS>Roll Skia from 44263c5d0827 to 4ee8dab839e8 (1 revision) (flutter/engine#32005)
2022-03-14<EMAIL_ADDRESS>Add missing #include <algorithm> (flutter/engine#32003)
2022-03-14<EMAIL_ADDRESS>Roll Skia from 02527b7182ea to 44263c5d0827 (1 revision) (flutter/engine#32002)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


[flink] Support source reader metrics when consumer-id is set

Purpose

Linked issue: close #2466
Tests
OperatorSourceTest#testReadOperatorMetricsRegisterAndUpdate

@tsreaper Please help to review this pr, many thanks~


No Guide Book in 1.20.1

Hi i am playing in the version of 1.20.1 7.3.5, and the crafting of the guide book does not work , and it does not appear in creative or JEI mod

The guide book requires Patchouli to be installed, otherwise it will not show.


Revise Event Summary

Change 'All' column to 'Part'
Change Revenue column to be based on Registrations, not Participants
Change Per Participant column to Per Registration

Cleared with R2; he and Zac don't use this report.

Upon investigation, Revenue is calculated correctly. Really needed just to adjust definition of Registration. Now both Revenue and Registration includes everyone except for Credits and Returns. So:
Change All column to Part
Change Registrations to exclude Credits
Change Per Participant column to Per Registration


The way key fields are named in the control-plane is not specified.

For table key fields the compiler creates @name annotations based on the expression used for the key field.
How the name is created is not specified in the spec.
This is a problem also when converting from P4-14 to P4-16 table reads that contain masks.

Actually the P4 spec has a section about how names are assigned, and it mandates users to add name annotations for expressions that are too complicated. What we don't have is a spec on how P4-14 programs with masks should be handled.

I think we can close this issue.


travis: use minimal image and stages

Since we build in docker anyway we can save the time it usually takes to
set up the Go environment.
See: https://docs.travis-ci.com/user/languages/minimal-and-generic/
Signed-off-by: Robert Günzler<EMAIL_ADDRESS>

@nazrhom looks like commit-lint didn't like this part
See: https://docs.travis-ci.com/user/languages/minimal-and-generic/

and complained with Error: Commit body should not contain footer tags

I also split the jobs into test and build stages to get jobs to run in parallel. This speeds up every and allows us to run builds for x86_64/armv7/aarch64


bug(mat-tab-group): First tab is activated even if disabled

Reproduction
Use StackBlitz to reproduce your issue:
https://stackblitz.com/edit/components-issue-ocdlcs?file=src%2Fapp%2Fexample-component.html
Steps to reproduce:

Open stackblitz
Verify the first tab is active
Change active tab to second
Verify the first tab is disabled and impossible to be activated again

Expected Behavior
If the first tab is disabled, it should either have no default active tab or activate the first enabled tab found.
Actual Behavior
The first tab is active at first moment, then after switching to another tab, the first tab is impossible to be activated again, as it should be in first moment.

This is working as intended. The disabled property prevents a user from selecting the tab, but the developer still has total control of the selectedIndex independent of disabled state.


What VS version for future Blazor releases?

Currently I have VS 2017 15.7.2 and 15.7.0 Preview 6. What will be needed for Blazor 0.4.0 and newer? Can I remove Preview 6 and work in 15.7.2 (now and in the future) or I should update 15.7.0 Preview to 15.8.0 Preview?

The current plan is to use 15.7.2 (stable channel) for 0.4.
We try to use the stable channel when possible, but will require preview when there's something new in VS that we need. There are no guarantees in life 😆

Thank you for immediate answer Ryan.


fix: fixed tab controller persistence

Why?
When resizing the page on web (but also on mobile & desktop) the TabController is rebuilt and so it's always set back to 0. The current position is not persisted.
What?
I have moved the TabController one widget above the LayoutBuilder so that the position (ie. the current controller index) is stored in the state and not lost during a rebuild on LayoutBuilder.
Types of Changes

Bug fix (non-breaking change which fixes an issue)

Notes
n/a
Checklist

[x] I have provided a description of the proposed changes.
[x] I added unit tests for all relevant code.
[ ] I added golden tests for all UI changes.
[ ] I added documentation for all relevant code.

Codecov Report

Merging #21 (7236525) into master (24af1fb) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           50        50
  Lines         1816      1816
=========================================
  Hits          1816      1816

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24af1fb...7236525. Read the comment docs.


Expose Skia Paint.getTextPath

Flutter fails to expose https://skia.org/user/api/SkPaint_Reference#SkPaint_getTextPath
Use case
Numerous. Using the text as clipping path, or using it as a base for more complex painting operations.

cc @GaryQian


MNT Fixes failing test_keras

Fixes failing test on the main branch

Looks like the tests are CI tests are failing because of a linting issue w/ mypy.

linux38 CI job: linting output
Checking flake8...
Checking flake8... DONE
Checking black...
black, version 19.10b0
All done! ✨ 🍰 ✨
100 files would be left unchanged.
Checking black... DONE
Checking isort...
4.3.21
Skipped 2 files
Checking isort... DONE
Checking mypy...
dask_ml/metrics/regression.py:102: error: "ndarray" has no attribute "chunks"
dask_ml/metrics/pairwise.py:30: error: "ndarray" has no attribute "to_delayed"
dask_ml/metrics/pairwise.py:37: error: "ndarray" has no attribute "chunks"
dask_ml/metrics/pairwise.py:42: error: "ndarray" has no attribute "chunks"
dask_ml/metrics/pairwise.py:58: error: "ndarray" has no attribute "chunks"
dask_ml/metrics/pairwise.py:59: error: "ndarray" has no attribute "map_blocks"
dask_ml/metrics/pairwise.py:136: error: Argument 2 to "check_pairwise_arrays" has incompatible type "Optional[ndarray]"; expected "ndarray"
dask_ml/metrics/pairwise.py:144: error: Argument 2 to "check_pairwise_arrays" has incompatible type "Optional[ndarray]"; expected "ndarray"
dask_ml/metrics/pairwise.py:161: error: Argument 2 to "check_pairwise_arrays" has incompatible type "Optional[ndarray]"; expected "ndarray"
dask_ml/metrics/pairwise.py:176: error: Argument 2 to "check_pairwise_arrays" has incompatible type "Optional[ndarray]"; expected "ndarray"
dask_ml/metrics/pairwise.py:211: error: Argument 2 to "check_pairwise_arrays" has incompatible type "Optional[ndarray]"; expected "ndarray"
Found 11 errors in 2 files (checked 5 source files)
dask_ml/preprocessing/label.py:200: error: Incompatible default for argument "uniques" (default has type "None", argument has type "ndarray")
dask_ml/preprocessing/label.py:202: error: "ndarray" has no attribute "cat"
dask_ml/preprocessing/label.py:212: error: "ndarray" has no attribute "cat"
dask_ml/preprocessing/data.py:39: error: Incompatible types in assignment (expression has type "float", variable has type "ndarray")
dask_ml/preprocessing/data.py:78: error: Need type annotation for 'n_features_in_'
dask_ml/preprocessing/data.py:145: error: Need type annotation for 'n_features_in_'
dask_ml/preprocessing/data.py:229: error: Argument 1 to "_handle_zeros_in_scale" has incompatible type "List[float]"; expected "ndarray"
dask_ml/preprocessing/data.py:230: error: Need type annotation for 'n_features_in_'
dask_ml/preprocessing/_encoders.py:119: error: Incompatible default for argument "dtype" (default has type "Type[floating[Any]]", argument has type "dtype[Any]")
dask_ml/preprocessing/_block_transformer.py:74: error: Need type annotation for 'func'
Found 19 errors in 4 files (checked 5 source files)
Checking mypy... DONE
##[error]Bash exited with code '1'.

    Finishing: Lint

It seems like this one is good to merge then?

This PR LGTM.

Do you have merge access @stsievert? I don't :)

Nope, no merge access. I know @TomAugspurger does though.

And probably @jrbourbeau as well :) Seems like this one is good to go

Good point @jrbourbeau. It looks like keras and tensorflow are only installed when the branch is main. So the test ran once it was merged. I am not sure if that is intentional or not.
@thomasjpfan when it ran there it passed on all builds except earliest: https://dev.azure.com/dask-dev/6d1a2a76-7181-452f-943c-c034bbab2bfa/_apis/build/builds/1961/logs/39 this might just be an instance of we should bump the minimum requirements.

Hm... SciKeras raises an error if loss is None, but KerasClassifier defaults to loss=None. I've filed https://github.com/adriangb/scikeras/issues/206 to address this.


Slider no longer showing up

Checklist:

[ Y] I updated to the latest version available
[ Y] I cleared the cache of my browser

Release with the issue:
3.1.7
Last working release (if known):
Browser and Operating System:
Android/Companion app
Windows/Edge
Windows/Chrome

Description of problem:

I had this card with a slider and some buttons working fine in an earlier release:
https://github.com/Nerwyn/service-call-tile-feature/issues/3#issuecomment-1803077901
Things were working back in Nov/2023 when this issue 3 was closed
I'm not sure when the slide disappear unfortunately. Any idea?
Javascript errors shown in the web inspector (if applicable):
Your Full Remote Config
Shortening the card to just the slide also doesn't fix things
features:
  - type: custom:service-call
    entries:
      - type: slider
        icon: mdi:ev-station
        service: emporia_vue.set_charger_current
        target:
          entity_id:
            - switch.ev_charger
        range:
          - 6
          - 48
        step: 1
        value_attribute: charging_rate
        thumb: default
        label: ATTRIBUTE[charging_rate] A
        data:
          current: VALUE
type: tile
entity: switch.ev_charger
icon_tap_action:
  action: toggle
icon: mdi:ev-station

yields:

Additional information:

Did you recently update? The latest release was almost a month ago so it would be weird if the issue were to suddenly appear. I also see you're still using the deprecated string interpolation system for the label. It should now be '{{ state_attr("switch.ev_charger", "charging_rate") }}' with unit_of_measurement: A.
It looks like it's failing here because it's expecting entity ID to be a string instead of an array. I should fix that.

@wirecuttr can you try the latest alpha? It should fix this.

It's not a new problem. I'm just getting around to logging the issue.
with 3.1.8-alpha.002 the slider shows up, but not correctly:

In terms of changing the label format I tried this:
features:
  - type: custom:service-call
    entries:
      - type: slider
        icon: mdi:ev-station
        service: emporia_vue.set_charger_current
        target:
          entity_id:
            - switch.ev_charger
        range:
          - 6
          - 48
        step: 1
        value_attribute: charging_rate
        thumb: default
        label: {{ state_attr("switch.ev_charger", "charging_rate") }}
        unit_of_measurement: A
        data:
          current: VALUE
type: tile
entity: switch.ev_charger
icon_tap_action:
  action: toggle
icon: mdi:ev-station

yields this error:

You have to put single quotes around the template.

You have to put single quotes around the template.

Ah. Thanks for your help!
This is working:
features:
  - type: custom:service-call
    entries:
      - type: slider
        icon: mdi:ev-station
        service: emporia_vue.set_charger_current
        target:
          entity_id: switch.ev_charger
        range:
          - 6
          - 48
        step: 1
        value_attribute: charging_rate
        thumb: default
        label: '{{ state_attr("switch.ev_charger", "charging_rate") }}'
        unit_of_measurement: A
        data:
          current: VALUE
type: tile
entity: switch.ev_charger
icon_tap_action:
  action: toggle
icon: mdi:ev-station

Is it posible to alter the colour of the slide based on the attribue value?
I'm trying this, but it's not working:
        color:
          {% if state_attr("switch.ev_charger", "charging_rate") > 35 %}
            red
          {% else %}
            blue
          {% endif %}

You have an extra set of brackets within the if statement, and should be using --color instead of color.
--color: |
  {% if state_attr("switch.ev_charger", "charging_rate") > 30 %}
    red
  {% else %}
    blue
  {% endif %}

Fixed in 3.1.8


[ISSUE #6448] Fix SystemClock.now() is affected by NTP time synchronization, which can cause inaccuracies in the result of isOSPageCacheBusy()

Make sure set the target branch to develop
Fix SystemClock.now() is affected by NTP time synchronization, which can cause inaccuracies in the result of isOSPageCacheBusy()
fix #6448
Brief changelog

Replace elapsed time calculation by System.nanoTime()

Verifying this change

Codecov Report

Merging #6487 (3c768e2) into develop (9b90b5b) will decrease coverage by 0.02%.
The diff coverage is 31.74%.

@@              Coverage Diff              @@
##             develop    #6487      +/-   ##
=============================================
- Coverage      43.19%   43.18%   -0.02%
+ Complexity      9018     9013       -5
=============================================
  Files           1106     1106
  Lines          78224    78261      +37
  Branches       10198    10199       +1
=============================================
+ Hits           33791    33794       +3
- Misses         40197    40232      +35
+ Partials        4236     4235       -1

Impacted Files
Coverage Δ

...a/org/apache/rocketmq/broker/BrokerController.java
43.67% <0.00%> (ø)

...n/java/org/apache/rocketmq/common/SystemClock.java
0.00% <0.00%> (ø)

...org/apache/rocketmq/namesrv/NamesrvController.java
65.25% <0.00%> (ø)

...ocketmq/proxy/remoting/RemotingProtocolServer.java
0.00% <0.00%> (ø)

...org/apache/rocketmq/store/DefaultMessageStore.java
46.82% <0.00%> (+0.02%)
:arrow_up:

...va/org/apache/rocketmq/store/kv/CompactionLog.java
21.09% <0.00%> (-0.22%)
:arrow_down:

...rg/apache/rocketmq/remoting/netty/RequestTask.java
24.39% <20.00%> (-0.61%)
:arrow_down:

...q/tieredstore/provider/posix/PosixFileSegment.java
60.17% <37.50%> (ø)

...main/java/org/apache/rocketmq/store/CommitLog.java
64.79% <40.00%> (-0.45%)
:arrow_down:

...che/rocketmq/broker/latency/BrokerFastFailure.java
63.76% <50.00%> (+1.44%)
:arrow_up:

... and 1 more

... and 19 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


border bottom width/color not working

There is a border between tab and its content. No matter what I do, border colour and BorderBottomWidth never get changed.

try tabBarUnderlineStyle={{backgroundColor: 'red', height: 10}}

not exactly, please check the border bottom in screenshot, i want to change this border color.

Is that not a padding or margin on the overall border?

maybe style={{borderWidth: 0}}?

neither padding nor margin worked also style={{borderWidth: 0}} didnt worked.

i have container background black and haven't set padding or margin on tabbar and even setting borderWidth 0 doesn't work.

@skv-headless @dsah
This is still an issue. It's right here:
container: {
    height: 50,
    borderWidth: 1,
    borderTopWidth: 0,
    borderLeftWidth: 0,
    borderRightWidth: 0,
    borderColor: '#ccc',
  },

Either we should remove those default colors or we should add an option to change it. This gray color looks terrible on certain color combinations.

You need to style the default tabbar:
import ScrollableTabView, { DefaultTabBar } from 'react-native-scrollable-tab-view';
const renderTabBar = props => (<DefaultTabBar {...props} style={{ borderBottomWidth: 0 }} />);

        <ScrollableTabView
          renderTabBar={renderTabBar} />


Chromeheadless support

The code seems to be checking for chrome and version. https://github.com/webdriverio/wdio-devtools-service/blob/master/lib/devtools.js#L6
Is this intentional? Or can this service work with chromeheadless as well but not supported yet?

@christian-bromann hey, for me, wdio-devtools-service is not working in headless mode. Do you have any examples of running it in chrome headless with wdio?


Update segment.mdx

added blurb about anonymous use cases and more context around overriding stableId and mapping the ids in the integration screen line 44-50

🚀 Deployed on https://636ab0fb2bd8d3048f77de67--cozy-fox-0defec.netlify.app


add tests for wordpress-rule-exclusions plugin      https://github.com/coreruleset/wordpress-rule-exclusions-plugin

This is done.


Serialize/Deserialize state as string in store, instead of map

Summary
To see if this positively impacts performance lag issues (channel sidebar opening, etc.) in 1.31 release.
Conversation here .
Ticket Link
(To be added)
Device Information
This PR was tested on: Android 10 device (OnePlus 5)

Still failing?


feedback request: simultaneously emitting multiple ES targets

Do you want to request a feature or report a bug?
Feature
What is the current behavior?
Can only target a single "profile" per compilation
What is the expected behavior?
Allow emitting multiple "profiles" from a single compilation
If this is a feature request, what is motivation or use case for changing the behavior?
It is currently possible to target both modern browsers that support ES2015 and legacy browsers by making use of <script type="module"> and <script nomodule>, respectively. (see philipwalton.com/articles/deploying-es2015-code-in-production-today/) However, generating both bundles requires a cumbersome process of creating multiple compilations with the only difference being the settings for Babel.
I've created a plugin that seeks to provide an easier way to do this: https://github.com/DanielSchaffer/webpack-babel-multi-target-plugin/tree/feature/webpack4 (current changes are on the feature/webpack4 branch)
It works by overriding the built-in entry option handling and internally generating multiple entries for each browser "target", and then also updating dependencies with those targets as the graph is loaded.
I'd love to get some feedback on how I implemented this feature, as this is my first webpack plugin. I'd specifically be interested in any potential side effects of doing what it does, or situations where it wouldn't work at all. Currently, it works as intended with Angular 5, including routing with lazy routes.
My apologies if this is not the right venue for asking for feedback like this - nobody responded in Gitter or on Twitter. If there's a better place to ask, please let me know.

However, generating both bundles requires a cumbersome process of creating multiple compilations with the only difference being the settings for Babel.

Why is this cumbersome?
// webpack.config.js
module.exports = [
  { /* babel options for legacy */ },
  { /* babel options for modern */ }
].map(babelOptions => ({
  entry: ...,
  // other options
  module: {
    rules: [
      { // babel
        options: babelOptions
      }
    ]
  }
}));

Perhaps "cumbersome" is a bit of a strong word ...
I started down this path because I wanted to end up with a complete package including an HTML file that correctly referenced both bundles (the "modern" bundle with <script type="module"> and the "legacy" bundle with <script nomodule>), which HtmlWebpackPlugin can't do with multiple compilations.


Languages

Planning for Languages out of the box

English
Korean
Ukrainian
Klingon
User defined

Got a template in place for now to add more languages as they come.
I also have a conversation mode so that one can speak English and it responds in Korean and vice-versa.
Real time direct translation still appears better with Google Translate. Better as a stand-along app or really complicated function that strips memory from the conversation.
I'm happy with it for now, maybe revisit Klingon down the line :penguin:


Some games don't show game cover or info

e.g. Shantae: Half-Genie Hero Ultimate Edition

Added fallback image for games that don't have a cover image.


Truncate option for Discord

Feature Description
Would it be possible to add a setting that overrides the truncating of Discord webhook notifications?
Adding a setting (default to 50 characters) to enable/disable or extend the characters count I think would be a good middle ground to allow the previous behavior but also allow conforming to Github.
Screenshots
No response

Interesting, I never thought that there would be an interest in keeping the previous behavior. I think it would be fine to make this configurable, I'm just not sure how that would look. I'm also trying to ponder any potential problems in the future if we would introduce this setting. This would be a specific configuration, where it's:

Just for Discord webhooks
Just for push events

We also need to consider the scope of the setting, should it be:

Instance-wide?
Organization/repository-wide?

The easiest would be to define some instance-wide setting, but I'm unsure if this is the best option.
I do know that the webhook table does have a meta column and I originally thought that we could throw a simple flag in the table and in the Discord webhook creation form that would toggle truncation on/off. I then realized that this is actually used in order for us to communicate to Discord properly, so this won't work. Open to other ideas.

Wow, this post is fresh.
We concur in bringing this as a feature. It's very convenient for our small team.
I can't comment on bigger teams but I have a feeling it can still be beneficial, depending on the production structure.
It provides the much-needed awareness, and depending on your role the information can mean something different. Remote working environment.

Been busy but I'll see what I can do when I get the time. I may choose the "add new db column to webhook table" option for now as a way of storing webhook configurations, but I also want to check out the other forges to see if they implement something like this and if I can find a better approach.

I've been quite busy and wanted to do some other things in my backlog before setting my sights on this. I will get to working on this as soon as I can, but welcome anyone to open a PR if they can do it sooner :)


Obstacle course hardening

The current obstacle course is manually placed and suffers several minor issues regarding vanilla addactions not being efficiently accessible. This could be avoided by spawning the obstacle courses with a script, hardcoding relative positions and orientations of obstacles. It must also account for terrain elevation variations, for example by lining obstacles over a concrete lane.

Consider using new terrain deformation ?


Update sql-server-linux-configure-docker.md

Changed chgroup to chgrp

@nocentino : Thanks for your contribution! The author(s) have been notified to review your proposed change.