crash when changing hyprpaper wallpaper after screen lock

Regression?
Yes
System Info and Version
 System/Version info
Hyprland, built from branch main at commit a9d87bd6669568741704de08b6f0328a92e29396  (surface: emit unmap before unmapping and releasing the buffers).
Date: Sun Jul 28 23:56:35 2024
Tag: v0.41.2-123-ga9d87bd6, commits: 5009

flags: (if any)

System Information:
System name: Linux
Node name: pog-os
Release: 6.10.2-arch1-1
Version: #1 SMP PREEMPT_DYNAMIC Sat, 27 Jul 2024 16:49:55 +0000

GPU information:
2b:00.0 VGA compatible controller [0300]: NVIDIA Corporation GA104 [GeForce RTX 3060 Ti Lite Hash Rate] [10de:2489] (rev a1) (prog-if 00 [VGA controller])
NVRM version: NVIDIA UNIX Open Kernel Module for x86_64  555.58.02  Release Build  (archlinux-builder@pog-os)

os-release: NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo

plugins:

======Config-Start======

Config File: /home/winner/.config/hypr/hyprland.conf: Read Succeeded
# This is an example Hyprland config file.
#
# Refer to the wiki for more information.

# nvidia env vars
env = LIBVA_DRIVER_NAME,nvidia
env = XDG_SESSION_TYPE,wayland
env = GBM_BACKEND,nvidia-drm
env = __GLX_VENDOR_LIBRARY_NAME,nvidia
env = NVD_BACKEND,direct

# env = HYPRLAND_TRACE,1
# env = AQ_TRACE,1

#
# Please note not all available settings / options are set here.
# For a full list, see the wiki
#

# See https://wiki.hyprland.org/Configuring/Monitors/
#monitor=,preferred,auto,auto
monitor=HDMI-A-1,prefered,0x390,1
monitor=DP-3,highrr,1680x0,1

# See https://wiki.hyprland.org/Configuring/Keywords/ for more

# Execute your favorite apps at launch
# exec-once = waybar & hyprpaper & firefox

exec-once = dbus-update-activation-environment --systemd WAYLAND_DISPLAY XDG_CURRENT_DESKTOP
exec-once = hyprpaper # wallpaper
exec-once = waybar # bar
# exec-once = picom
exec-once = plover # stenography
exec-once = copyq # clipboard manager
exec-once = ckb-next -b # corsair keyboard manager
exec-once = nm-applet # network manager
exec-once = opensnitch-ui # application firewall
exec-once = dunst # notification daemon
exec-once = blueman-applet # bluetooth manager
exec-once = gammastep -l manual -l 57.070435:-2.134568

# Source a file (multi-file configs)
# source = ~/.config/hypr/myColors.conf

# Some default env vars.
env = XCURSOR_SIZE,24
env = HYPRCURSOR_SIZE,24

# For all categories, see https://wiki.hyprland.org/Configuring/Variables/
general {
    # See https://wiki.hyprland.org/Configuring/Variables/ for more

    gaps_in = 5
    gaps_out = 15

    border_size = 2

    col.active_border = rgba(33ccffee) rgba(00ff99ee) 45deg
    col.inactive_border = rgba(595959aa)

    resize_on_border = false
    allow_tearing = false

    # layout = hy3 # waiting until https://github.com/outfoxxed/hy3/pull/126 is merged (move focus crosses monitors)
    layout = dwindle
}

decoration {
    # See https://wiki.hyprland.org/Configuring/Variables/ for more

    rounding = 10

    active_opacity = 1.0
    # inactive_opacity = 1.0
    inactive_opacity = 0.85

    drop_shadow = true
    shadow_range = 4
    shadow_render_power = 3
    col.shadow = rgba(1a1a1aee)

    blur {
        enabled = true
        size = 3
        passes = 1

        vibrancy = 0.1696
    }
}

animations {
    enabled = true

    # Some default animations, see https://wiki.hyprland.org/Configuring/Animations/ for more

    bezier = myBezier, 0.05, 0.9, 0.1, 1

    animation = windows, 1, 7, myBezier
    animation = windowsOut, 1, 7, default, popin 80%
    animation = border, 1, 10, default
    animation = borderangle, 1, 8, default
    animation = fade, 1, 4, default
    animation = workspaces, 1, 6, default
}

dwindle {
    # See https://wiki.hyprland.org/Configuring/Dwindle-Layout/ for more
    pseudotile = true # master switch for pseudotiling. Enabling is bound to mainMod + P in the keybinds section below
    preserve_split = true # you probably want this
}

misc {
    # See https://wiki.hyprland.org/Configuring/Variables/ for more
    key_press_enables_dpms = true
    force_default_wallpaper = 2 # Set to 0 or 1 to disable the anime mascot wallpapers
    disable_hyprland_logo = false # If true disables the random hyprland logo / anime girl background. :(
}

master {
    # See https://wiki.hyprland.org/Configuring/Master-Layout/ for more
    new_status = true
}

#############
### INPUT ###
#############

input {
    kb_layout = us
    kb_variant =
    kb_model =
    kb_options =
    kb_rules =

    follow_mouse = 1

    sensitivity = 0 # -1.0 - 1.0, 0 means no modification.

    touchpad {
        natural_scroll = false
    }
}

gestures {
    # See https://wiki.hyprland.org/Configuring/Variables/ for more
    workspace_swipe = false
}

experimental {
    # See https://wiki.hyprland.org/Configuring/Variables/ for more
    #explicit_sync = true
}
# equivalent to the above
# experimental:explicit_sync = true

debug {
    disable_logs = false
}

cursor {
    no_hardware_cursors = true
    allow_dumb_copy = true
}

# source = ~/.config/hypr/pluginsconf.conf
plugin {
  hy3 {
    # disable gaps when only one window is onscreen
    # 0 - always show gaps
    # 1 - hide gaps with a single window onscreen
    # 2 - 1 but also show the window border
    no_gaps_when_only = 0 # default: 0

    # policy controlling what happens when a node is removed from a group,
    # leaving only a group
    # 0 = remove the nested group
    # 1 = keep the nested group
    # 2 = keep the nested group only if its parent is a tab group
    node_collapse_policy = 2 # default: 2

    # offset from group split direction when only one window is in a group
    group_inset = 10 # default: 10

    # if a tab group will automatically be created for the first window spawned in a workspace
    tab_first_window = false

    # tab group settings
    tabs {
      # height of the tab bar
      height = 15 # default: 15

      # padding between the tab bar and its focused node
      padding = 5 # default: 5

      # the tab bar should animate in/out from the top instead of below the window
      from_top = false # default: false

      # rounding of tab bar corners
      rounding = 3 # default: 3

      # render the window title on the bar
      render_text = true # default: true

      # center the window title
      text_center = false # default: false

      # font to render the window title with
      text_font = Sans # default: Sans

      # height of the window title
      text_height = 8 # default: 8

      # left padding of the window title
      text_padding = 3 # default: 3

      # active tab bar segment color
      col.active = 0xff32b4ff # default: 0xff32b4ff

      # urgent tab bar segment color
      col.urgent = 0xffff4f4f # default: 0xffff4f4f

      # inactive tab bar segment color
      col.inactive = 0x80808080 # default: 0x80808080

      # active tab bar text color
      col.text.active = 0xff000000 # default: 0xff000000

      # urgent tab bar text color
      col.text.urgent = 0xff000000 # default: 0xff000000

      # inactive tab bar text color
      col.text.inactive = 0xff000000 # default: 0xff000000
    }

    # autotiling settings
    autotile {
      # enable autotile
      enable = false # default: false

      # make autotile-created groups ephemeral
      ephemeral_groups = true # default: true

      # if a window would be squished smaller than this width, a vertical split will be created
      # -1 = never automatically split vertically
      # 0 = always automatically split vertically
      # <number> = pixel height to split at
      trigger_width = 0 # default: 0

      # if a window would be squished smaller than this height, a horizontal split will be created
      # -1 = never automatically split horizontally
      # 0 = always automatically split horizontally
      # <number> = pixel height to split at
      trigger_height = 0 # default: 0

      # a space or comma separated list of workspace ids where autotile should be enabled
      # it's possible to create an exception rule by prefixing the definition with "not:"
      # workspaces = 1,2 # autotiling will only be enabled on workspaces 1 and 2
      # workspaces = not:1,2 # autotiling will be enabled on all workspaces except 1 and 2
      workspaces = all # default: all
    }
  }
}

# Example per-device config
# See https://wiki.hyprland.org/Configuring/Keywords/#executing for more
# device:epic-mouse-v1 {
#     sensitivity = -0.5
# }

# See https://wiki.hyprland.org/Configuring/Keywords/ for more
$mainMod = SUPER

# Example binds, see https://wiki.hyprland.org/Configuring/Binds/ for more

# hyprland

bind = $mainMod SHIFT, Q, killactive,
bind = $mainMod SHIFT, E, exit,
bind = $mainMod, T, togglefloating,
bind = $mainMod, P, pseudo, # dwindle
bind = $mainMod, J, togglesplit, # dwindle

# programs

# terminal
bind = $mainMod, RETURN, exec, alacritty
# file manager
bind = $mainMod, E, exec, thunar
# rofi
bind = $mainMod, D, exec, ./.config/rofi/scripts/launcher_t1
# clipboard manager
bind = $mainMod, V, exec, copyq menu
# lockscreen
# bind = $mainMod, ESCAPE, exec, swaylock --image /home/winner/Pictures/backgrounds/D3pZLXx.png & sleep 0.5 && hyprctl dispatch dpms off
bind = $mainMod, ESCAPE, exec, hyprlock & sleep 0.5 && hyprctl dispatch dpms off
# open thunar using o
bind = $mainMod, O, exec, thunar
# screenshot save copy and open with gimp
bind = $mainMod, PRINT, exec, ~/.config/hypr/scripts/screenshot.sh

# media keys
# i3 version:
# bindsym XF86AudioPlay exec playerctl play-pause
# bindsym XF86AudioStop exec playerctl stop
# bindsym XF86AudioNext exec playerctl next
# bindsym XF86AudioPrev exec playerctl previous
bind = , XF86AudioPlay, exec, playerctl play-pause
bind = , XF86AudioStop, exec, playerctl stop
bind = , XF86AudioNext, exec, playerctl next
bind = , XF86AudioPrev, exec, playerctl previous
# bindsym XF86AudioRaiseVolume exec --no-startup-id pactl set-sink-volume @DEFAULT_SINK@ +10% && $refresh_i3status
# bindsym XF86AudioLowerVolume exec --no-startup-id pactl set-sink-volume @DEFAULT_SINK@ -10% && $refresh_i3status
# bindsym XF86AudioMute exec --no-startup-id pactl set-sink-mute @DEFAULT_SINK@ toggle && $refresh_i3status
# bindsym XF86AudioMicMute exec --no-startup-id pactl set-source-mute @DEFAULT_SOURCE@ toggle && $refresh_i3status
bind = , XF86AudioRaiseVolume, exec, pactl set-sink-volume @DEFAULT_SINK@ +10% && $refresh_i3status
bind = , XF86AudioLowerVolume, exec, pactl set-sink-volume @DEFAULT_SINK@ -10% && $refresh_i3status
bind = , XF86AudioMute, exec, pactl set-sink-mute @DEFAULT_SINK@ toggle && $refresh_i3status
bind = , XF86AudioMicMute, exec, pactl set-source-mute @DEFAULT_SOURCE@ toggle && $refresh_i3status

# Move focus with mainMod + arrow keys
bind = $mainMod, left, movefocus, l
bind = $mainMod, right, movefocus, r
bind = $mainMod, up, movefocus, u
bind = $mainMod, down, movefocus, d
bind = $mainMod+SHIFT, left, movewindow, l
bind = $mainMod+SHIFT, right, movewindow, r
bind = $mainMod+SHIFT, up, movewindow, u
bind = $mainMod+SHIFT, down, movewindow, d

# Move windows with mainMod + SHIFT + arrow keys
# disable for now until move focus is fixed
# bind = $mainMod, left, hy3:movefocus, l
# bind = $mainMod, right, hy3:movefocus, r
# bind = $mainMod, up, hy3:movefocus, u
# bind = $mainMod, down, hy3:movefocus, d
# bind = $mainMod+SHIFT, left, hy3:movewindow, l
# bind = $mainMod+SHIFT, down, hy3:movewindow, d
# bind = $mainMod+SHIFT, up, hy3:movewindow, u
# bind = $mainMod+SHIFT, right, hy3:movewindow, r
# bind = $mainMod, r, hy3:makegroup, opposite, force_ephemeral

# Switch workspaces with mainMod + [0-9]

# bind = $mainMod, 1, exec, ~/.config/hypr/scripts/dispatch.sh 1
# bind = $mainMod, 2, exec, ~/.config/hypr/scripts/dispatch.sh 2
# bind = $mainMod, 3, exec, ~/.config/hypr/scripts/dispatch.sh 3
# bind = $mainMod, 4, exec, ~/.config/hypr/scripts/dispatch.sh 4
# bind = $mainMod, 5, exec, ~/.config/hypr/scripts/dispatch.sh 5
# bind = $mainMod, 6, exec, ~/.config/hypr/scripts/dispatch.sh 6
# bind = $mainMod, 7, exec, ~/.config/hypr/scripts/dispatch.sh 7
# bind = $mainMod, 8, exec, ~/.config/hypr/scripts/dispatch.sh 8
# bind = $mainMod, 9, exec, ~/.config/hypr/scripts/dispatch.sh 9
# bind = $mainMod, 0, exec, ~/.config/hypr/scripts/dispatch.sh 10
bind = $mainMod, 1, workspace, 1
bind = $mainMod, 2, workspace, 2
bind = $mainMod, 3, workspace, 3
bind = $mainMod, 4, workspace, 4
bind = $mainMod, 5, workspace, 5
bind = $mainMod, 6, workspace, 6
bind = $mainMod, 7, workspace, 7
bind = $mainMod, 8, workspace, 8
bind = $mainMod, 9, workspace, 9
bind = $mainMod, 0, workspace, 10

# Move active window to a workspace with mainMod + SHIFT + [0-9]
bind = $mainMod SHIFT, 1, movetoworkspace, 1
bind = $mainMod SHIFT, 2, movetoworkspace, 2
bind = $mainMod SHIFT, 3, movetoworkspace, 3
bind = $mainMod SHIFT, 4, movetoworkspace, 4
bind = $mainMod SHIFT, 5, movetoworkspace, 5
bind = $mainMod SHIFT, 6, movetoworkspace, 6
bind = $mainMod SHIFT, 7, movetoworkspace, 7
bind = $mainMod SHIFT, 8, movetoworkspace, 8
bind = $mainMod SHIFT, 9, movetoworkspace, 9
bind = $mainMod SHIFT, 0, movetoworkspace, 10

# Scroll through existing workspaces with mainMod + scroll
bind = $mainMod, mouse_down, workspace, e+1
bind = $mainMod, mouse_up, workspace, e-1

# Move/resize windows with mainMod + LMB/RMB and dragging
bindm = $mainMod, mouse:272, movewindow
bindm = $mainMod, mouse:273, resizewindow

##############################
### WINDOWS AND WORKSPACES ###
##############################

# Example windowrule v1
# windowrule = float, ^(kitty)$
# Example windowrule v2
# windowrulev2 = float,class:^(kitty)$,title:^(kitty)$
# See https://wiki.hyprland.org/Configuring/Window-Rules/ for more

# workspace monitor bindings
workspace=3,monitor:HDMI-A-1,defaultName:discord
workspace=5,monitor:DP-3,defaultName:steam
workspace=1,defaultName:web

windowrule = float, file_progress
windowrule = float, confirm
windowrule = float, dialog
windowrule = float, download
windowrule = float, notification
windowrule = float, error
windowrule = float, splash
windowrule = float, confirmreset
windowrule = float, title:Open File
windowrule = float, title:branchdialog
windowrule = float, Lxappearance
windowrule = float, Rofi
windowrule = animation none,Rofi
windowrule = float, title:CopyQ
windowrule = float,viewnior
windowrule = float,feh
windowrule = float, pavucontrol-qt
windowrule = float, pavucontrol
windowrule = float, file-roller
windowrule = fullscreen, wlogout
windowrule = float, title:wlogout
windowrule = fullscreen, title:wlogout
windowrule = idleinhibit focus, mpv
windowrule = idleinhibit fullscreen, firefox
windowrule = float, title:^(Media viewer)$
windowrule = float, title:^(Volume Control)$
windowrule = float, title:^(Picture-in-Picture)$
windowrule = size 800 600, title:^(Volume Control)$
windowrule = move 75 44%, title:^(Volume Control)$
windowrule = float, ^(opensnitch_ui)$
windowrule = fullscreen, steam_app_1293830

windowrulev2 = fullscreen,class:^(steam_app_1293830)$

windowrulev2=noanim,class:^(flameshot)$
windowrulev2=float,class:^(flameshot)$
windowrulev2=fakefullscreen,class:^(flameshot)$
windowrulev2=monitor 1,class:^(flameshot)$
windowrulev2=move -1680 0,class:^(flameshot)$

windowrule = move cursor -45% -30%,^(com.github.hluk.copyq)$ # moves copyq to the center of the cursor

#disable animations for copyq, flameshot, and rofi
windowrulev2 = noanim,class:^(com.github.hluk.copyq)$
windowrulev2 = noanim,class:^(flameshot)$
windowrulev2 = noanim,class:^(Rofi)$

# bind discord and variants to workspace 3
windowrulev2 = workspace discord,class:^(discord)$

# opacity rules
# 100% for active windows and picture-in-picture
# 85% for unfocused windows
# windowrulev2 = opacity 1.0 0.75,class:.*

# 85 for floating and focused
# 75 for floating and unfocused
# windowrulev2 = opacity 0.85 0.75,floating:1

windowrulev2 = opacity 1.0,title:^(Picture-in-Picture)$
# 85 for rofi
windowrulev2 = opacity 1.0 0.95,class:^(Rofi)$

======Config-End========

Description
had a cronjob that changes the hyprpaper background every 5 minutes and saw that hyprland was crashing when it was locked when the background was due to change.
initial commit with the issue is 963816b9a6524a99a6716fa1aa30b2c4f369d2f0
reverting 729b47d46 and 963816b fixes the issue
How to reproduce
run the following command and replace the picture with an actual picture, only crashes on the final command.
hyprlock & sleep 1 && hyprctl --instance 0 hyprpaper unload all && hyprctl --instance 0 hyprpaper preload picture.png && hyprctl --instance 0 hyprpaper wallpaper "HDMI-A-1, picture.png"

doesn't need to be hyprlock, could also be swaylock.
Crash reports, logs, images, videos
hyprlandCrashReport25168.txt

can you try whether #7092 fixes it?

that pull request fixes it


LD clumping doesn't work as intended

As @d0choa has noticed, there are something off with the LD clumped GWAS associations. When taking a closer look, it was apparent that the LD clumped GWAS Catalog curation dataset contains unflagged associations, where the credible set contains tag variants with more significant p-value, however LD clumping step is called on the dataset.
Test case:
sl = StudyLocus.from_parquet(session, 'gwas_catalog_PICSed_curated_associations')

# Problematic study and chromosome:
study_id = 'GCST90321118'
chromosome = '7'

(
    sl.df.filter(f.col('studyId') == study_id) & (f.col('chromosome') == chromosome)
    .count()
)

Showing there are ~600 top-hits in this study/chromosome. Many of them flagged as being LD clumped. When applying a following filter:
(
    sl.df.filter(
        (f.col('studyId') == study_id) & (f.col('chromosome') == chromosome) &
        (~f.array_contains(f.col("qualityControls"), 'Explained by a more significant variant in high LD (clumped)'))
    )
    .count()
)

we get 206 associations. It suggests that in this chromosome there are 200 independent top hits, implying the ld sets of these associations are not overlapping. However this is not true. The most significant association of this region (7_121320217_G_C with p-value 1e-120) can be found in 15, otherwise un-flagged associations' ld set:
top_association = '7_121320217_G_C'

(
    sl.df.filter(
        (f.col('studyId') == study_id) & (f.col('chromosome') == chromosome) &
       # Dropping already flagged associations:
        (~f.array_contains(f.col("qualityControls"), 'Explained by a more significant variant in high LD (clumped)'))
    )
    .filter(
        # Filtering for associations, which are containing the most significant variant as a tag:
        f.array_contains(
            f.transform(
                f.col('ldSet'),
                lambda x: x['tagVariantId']
            ),
            top_association
        )
    )
    .orderBy(f.col('pValueExponent').asc())
    .count()
)

This number should be zero.

These are the variants of this locus that are all linked together and should be flagged as LD clumped:
test_variants = [
    '7_121325410_G_GCACC',
    '7_121326736_A_G',
    '7_121280773_G_A',
    '7_121292393_A_G',
    '7_121308853_A_G',
    '7_121287383_A_AC',
    '7_121308406_G_C',
    '7_121305274_T_C',
    '7_121301780_C_CGT',
    '7_121320217_G_C',
    '7_121319081_C_T',
    '7_121329915_G_GCT',
    '7_121354115_G_T',
    '7_121378803_A_T',
    '7_121332237_C_CGT'
]

When looking into the clumped credible set dataset none of them are flagged:
extracted = (
    StudyLocus.from_parquet(session, "/Users/dsuveges/project_data/gentropy/credible_set/gwas_catalog_PICSed_curated_associations")
    .filter(
        f.col('variantId').isin(test_variants) & (f.col('studyId') == study_id)
    )
)

print(extracted.df.count())
extracted.df.select('variantId', 'qualityControls', f.size('ldSet').alias('ldSetSize')).show()

Giving:
+-------------------+--------------------+---------+
|          variantId|     qualityControls|ldSetSize|
+-------------------+--------------------+---------+
|7_121325410_G_GCACC|                  []|       80|
|    7_121326736_A_G|                  []|       83|
|    7_121280773_G_A|                  []|       93|
|    7_121292393_A_G|                  []|       65|
|    7_121308853_A_G|                  []|       62|
|   7_121287383_A_AC|                  []|       61|
|    7_121308406_G_C|[Palindrome allel...|       64|
|    7_121305274_T_C|                  []|       58|
|  7_121301780_C_CGT|                  []|       42|
|    7_121320217_G_C|[Palindrome allel...|       70|
|    7_121319081_C_T|                  []|       56|
|  7_121329915_G_GCT|                  []|       75|
|    7_121354115_G_T|                  []|       76|
|    7_121378803_A_T|[Palindrome allel...|      124|
|  7_121332237_C_CGT|                  []|       79|
+-------------------+--------------------+---------+

On the same dataset, if we call clump, some indeed clumped:
extracted = (
    StudyLocus.from_parquet(session, "/Users/dsuveges/project_data/gentropy/credible_set/gwas_catalog_PICSed_curated_associations")
    .filter(
        f.col('variantId').isin(test_variants) & (f.col('studyId') == study_id)
    ).clump()
)

print(extracted.df.count())
extracted.df.select('variantId', 'qualityControls', f.size('ldSet').alias('ldSetSize')).show()

+-------------------+-----------------------------------------------------------------------------------------------------+---------+
|variantId          |qualityControls                                                                                |ldSetSize|
+-------------------+-----------------------------------------------------------------------------------------------------+---------+
|7_121301780_C_CGT  |[]                                                                                |42       |
|7_121280773_G_A    |[Explained by a more significant variant in high LD (clumped)]                                       |0        |
|7_121319081_C_T    |[]                                                                                |56       |
|7_121320217_G_C    |[Palindrome alleles - cannot harmonize]                                                              |70       |
|7_121292393_A_G    |[]                                                                                |65       |
|7_121308853_A_G    |[Explained by a more significant variant in high LD (clumped)]                                       |0        |
|7_121287383_A_AC   |[Explained by a more significant variant in high LD (clumped)]                                       |0        |
|7_121305274_T_C    |[Explained by a more significant variant in high LD (clumped)]                                       |0        |
|7_121308406_G_C    |[Palindrome alleles - cannot harmonize, Explained by a more significant variant in high LD (clumped)]|0        |
|7_121326736_A_G    |[]                                                                                |83       |
|7_121329915_G_GCT  |[Explained by a more significant variant in high LD (clumped)]                                       |0        |
|7_121325410_G_GCACC|[]                                                                                |80       |
|7_121354115_G_T    |[Explained by a more significant variant in high LD (clumped)]                                       |0        |
|7_121378803_A_T    |[Palindrome alleles - cannot harmonize]                                                              |124      |
|7_121332237_C_CGT  |[]                                                                                |79       |
+-------------------+-----------------------------------------------------------------------------------------------------+---------+

Apparently after applying a filter, calling clumping on an already clumped dataset yields new clumped loci. This behaviour indicates some inconsistency in the clumping logic.


Discrepancy between React link hover color and spec

According to https://www.carbondesignsystem.com/components/link/style/ there should be a hover color on links that's slightly darker than the at-rest color.
$hover-primary-text = #054ADA
$link-01 = #0f62fe
But none of the demos use it, e.g.,
https://www.carbondesignsystem.com/components/link/code/
or
https://react.carbondesignsystem.com/?path=/story/link--default
Is the spec wrong, or do the implementations need to change?

The style table doc is correct.
For the link component, we should be using link-01 for enabled and hover-primary-text for hover. I will transfer this issue to the carbon repo.


changed interface to use Clingo::ASTv2

changed to use ASTv2 from clingo and new theory interface

The TheoryRewriterR contains a lot of unnecessary code. Only terms need to be tagged and the previous checks have to be ported. Please make sure to only include code concerning &diff atoms.

The TheoryRewriterR contains a lot of unnecessary code. Only terms need to be tagged and the previous checks have to be ported. Please make sure to only include code concerning &diff atoms.

Now the rewrite_tuple function creates a useless copy of the element. Just move the checks to the other method. :stuck_out_tongue_closed_eyes:

Now the rewrite_tuple function creates a useless copy of the element. Just move the checks to the other method. :stuck_out_tongue_closed_eyes:


Test for codestream lifecycle information being correct (bsc#1227100)

This still needs a reformat and also the repo currently shows 2028 as the EOL date, so I guess this needs to be fixed in SLES?

Yeah, I'm following TDD

What is blocking getting this fixed on the SLES side? Something in the SLE_BCI repo that we can fix?

What is blocking getting this fixed on the SLES side? Something in the SLE_BCI repo that we can fix?

the information comes from the sles-release package. since it was wrong in SP6:GA, we need to release a maintenance update that noone has submitted so far.


go get not working as expected

tags are wrong, might need build hack

[ ] make a commit to main called chore: release several
[ ] push tags manually for everything at that commit
[ ] test go mod tidy
[ ] test cmd install


Replace debs with previous logic for downloading packages.

Execution times for Kitura-Starter:
download_dependencies:
Push:

4m 30s
4m 10s

Re-push:

2m 38s
3m 10s

develop:
Push:

3m 30s
3m 35s

Re-push:

2m 43s
3m 07s

This approach adds about 40s to 1m to the execution time.


Not Starting Engine

When i trying to start this engine or mod based on this engine nothing happens. it just won't start without any error message.

Go into C:\Users\<Your User>\AppData\Roaming\ninjamuffin99\ and delete PsychEngine folder


[WIP][SPARK-20628][CORE] Keep track of nodes (/ spot instances) which are going to be shutdown

What changes were proposed in this pull request?
Keep track of nodes which are going to be shutdown to prevent schedualing tasks. The PR is designed with spot instances in mind, where there is some notice (depending on the cloud vendor) that the node will be shut down.
Since each vendor notifies instances of pending termination in different manner, it is left to the instance to notify the worker(s) of decommissioning with SIGPWR.
SPARK-20628 is a sub-task of SPARK-20624 with follow up tasks to perform migration of data and re-launching of tasks. SPARK-20628 is distinct from other mechanism where Spark its self has control of executor decommissioning, however the later follow up tasks in SPARK-20624 should be usable across voluntary and involuntary termination (e.g. https://github.com/apache/spark/pull/19041 could provide a good mechanism for doing data copy during involuntary termination).
How was this patch tested?
Extension of AppClientSuite to cover decommissioning and addition of explicit worker decom suite.
TODO:

Follow up with relevant companion notification scripts in the relevant spark-on-[X] for X in {cloud providers} projects.
Deploy on live EC2 (or GCE) cluster with companion monitoring script and wait for spot instance prices to spike and confirm decommissioning.

Test build #81103 has started for PR 19045 at commit 65a29c1.

Test build #81103 has finished for PR 19045 at commit 65a29c1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81103/
Test PASSed.

Are you still working on this? @holdenk

I'll bump it if anyone has a chance to review, but I think we'll see how https://github.com/apache/spark/pull/19267#issuecomment-338268092 plays out first.

So it seems like the YARN changes are only going to happen in Hadoop 3+ so this might make sense regardless of what happens in https://github.com/apache/spark/pull/19267 (since folks like K8 or whoever can send the message as desired).

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1893/
Test PASSed.

Build finished. Test PASSed.

Chatted with some K8s folks and I'll revive this PR with that in mind.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2584/
Test PASSed.

Test build #95306 has started for PR 19045 at commit c40fac5.

Test build #95306 has finished for PR 19045 at commit c40fac5.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95306/
Test FAILed.

Test build #95837 has started for PR 19045 at commit 0ba0ca5.

cc @ifilonenko it's super WIP but since you joined me on the stream where I was working on reviving this I thought it would be good to get your early comments (especially if you have any suggestions around making effective integration tests for this).

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2949/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2950/
Test PASSed.

Test build #95838 has started for PR 19045 at commit 5877c16.

Test build #95837 has finished for PR 19045 at commit 0ba0ca5.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95837/
Test FAILed.

Test build #96290 has started for PR 19045 at commit 4e6572f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3259/
Test PASSed.

Test build #96290 has finished for PR 19045 at commit 4e6572f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96290/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3327/
Test PASSed.

Test build #96398 has started for PR 19045 at commit 42a29ab.

Test build #96398 has finished for PR 19045 at commit 42a29ab.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96398/
Test FAILed.

Test build #97322 has started for PR 19045 at commit c7eaaf6.

Test build #97322 has finished for PR 19045 at commit c7eaaf6.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97322/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3929/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3932/
Test PASSed.

Test build #97325 has started for PR 19045 at commit cb61f45.

Test build #97325 has finished for PR 19045 at commit cb61f45.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97325/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3933/
Test FAILed.

Test build #97326 has started for PR 19045 at commit 9036b44.

Test build #97326 has finished for PR 19045 at commit 9036b44.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97326/
Test FAILed.

test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3934/
Test PASSed.

Test build #97327 has started for PR 19045 at commit d58f2a6.

Test build #97327 has finished for PR 19045 at commit d58f2a6.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97327/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3935/
Test PASSed.

please rename PR with [K8S] flag to launch tests.

Test build #97468 has started for PR 19045 at commit 5ae1bd7.

Thanks @ifilonenko added :)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4044/
Test FAILed.

Test build #97468 has finished for PR 19045 at commit 5ae1bd7.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97468/
Test FAILed.

Test build #98098 has started for PR 19045 at commit be38dab.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4542/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4542/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4542/
Test PASSed.

Test build #98098 has finished for PR 19045 at commit be38dab.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98098/
Test PASSed.

Hey @ifilonenko I'd appreciate your thoughts on the testing approach I took here and if matches your suggestions.

Test build #98326 has started for PR 19045 at commit bbeceb9.

Test build #98326 has finished for PR 19045 at commit bbeceb9.

This patch fails build dependency tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98326/
Test FAILed.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4674/

Build finished. Test PASSed.

Test build #98330 has started for PR 19045 at commit 164fa2a.

Test build #98330 has finished for PR 19045 at commit 164fa2a.

This patch fails build dependency tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98330/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4677/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4677/

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4677/
Test PASSed.

Test build #98335 has started for PR 19045 at commit 151d5d8.

Test build #98335 has finished for PR 19045 at commit 151d5d8.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98335/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4682/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4682/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4682/
Test FAILed.

Test build #98342 has started for PR 19045 at commit ca448d1.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4688/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4688/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4688/
Test FAILed.

Test build #98342 has finished for PR 19045 at commit ca448d1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98342/
Test PASSed.

Test build #98573 has started for PR 19045 at commit 8d504b2.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4827/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4827/

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4827/
Test FAILed.

Merged build finished. Test FAILed.

Test build #98573 has finished for PR 19045 at commit 8d504b2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98573/
Test PASSed.

Jenkins retest this please.

Test build #99784 has started for PR 19045 at commit 8d504b2.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5821/

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5821/
Test FAILed.

Test build #99785 has started for PR 19045 at commit c2b3e6e.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5822/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5823/
Test FAILed.

Test build #99786 has finished for PR 19045 at commit 7b0023a.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99786/
Test FAILed.

Test build #99789 has started for PR 19045 at commit cca9948.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5826/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5826/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5826/
Test FAILed.

Test build #99790 has started for PR 19045 at commit 1bbb69b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5827/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5827/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5827/
Test FAILed.

Test build #99789 has finished for PR 19045 at commit cca9948.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #99790 has finished for PR 19045 at commit 1bbb69b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99790/
Test FAILed.

Test build #99784 has finished for PR 19045 at commit 8d504b2.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99784/
Test PASSed.

Test build #99997 has started for PR 19045 at commit af048f5.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5993/

Test build #99998 has started for PR 19045 at commit 43abf98.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5994/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5994/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5994/
Test FAILed.

Test build #100000 has started for PR 19045 at commit abb0609.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5995/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5995/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5995/
Test FAILed.

Test build #100001 has started for PR 19045 at commit 9d4fc23.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5996/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5996/

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5996/
Test FAILed.

Merged build finished. Test FAILed.

Test build #99998 has finished for PR 19045 at commit 43abf98.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99998/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100000/
Test FAILed.

Test build #100001 has finished for PR 19045 at commit 9d4fc23.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #100001 has finished for PR 19045 at commit 9d4fc23.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100001/
Test FAILed.

Test build #100441 has started for PR 19045 at commit 7f3fd5f.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6400/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6400/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6400/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6402/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6402/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6402/
Test FAILed.

Test build #100443 has finished for PR 19045 at commit 00310f9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100443/
Test FAILed.

Test build #100441 has finished for PR 19045 at commit 7f3fd5f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100441/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6453/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6453/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6453/
Test FAILed.

Test build #100514 has started for PR 19045 at commit 0bf027a.

Test build #100515 has started for PR 19045 at commit be18e52.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6455/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6455/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6455/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6456/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6456/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6456/
Test FAILed.

Test build #100518 has started for PR 19045 at commit 2914581.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6459/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6459/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6459/
Test FAILed.

Test build #100512 has finished for PR 19045 at commit c3c0e3a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100512/
Test PASSed.

Test build #100514 has finished for PR 19045 at commit 0bf027a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #100515 has finished for PR 19045 at commit be18e52.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100515/
Test PASSed.

jenkins retest this please.

Test build #100520 has started for PR 19045 at commit 2914581.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6461/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6461/
Test FAILed.

Test build #100521 has started for PR 19045 at commit 953094a.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6462/

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6462/
Test FAILed.

Test build #100518 has finished for PR 19045 at commit 2914581.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100518/
Test PASSed.

Test build #100520 has finished for PR 19045 at commit 2914581.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100520/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100521/
Test PASSed.

Test build #100531 has started for PR 19045 at commit 705fd58.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6466/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6466/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6466/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6467/

Test build #100533 has started for PR 19045 at commit ca60dbf.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6467/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6467/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6469/

Test build #100535 has started for PR 19045 at commit 19955be.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6469/

Merged build finished. Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6471/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6471/

Merged build finished. Test FAILed.


When you select the time zone parsing works incorrectly

I selected Europe/Moscow time zone and tried to enter 12.03.2023, but the result was 12.02.2023
https://github.com/gravity-ui/date-utils/assets/31247233/f98d3328-fd5d-4300-b6df-09645a2d9c4e

Fixed here https://github.com/gravity-ui/date-utils/releases/tag/v2.5.0


Unable to use filter while search field is not empty and vice versa

Would be nice if there was posibility to filter search results by using existing or creating new parameter set (Filter) on Test Runs screen and vice versa
If user types anything in search field -  Parameter Sets are disabled
If user enable Parameter Set(filter) - Search field is disabled
found here: https://stage.qaprosoft.farm/app/tests/runs

This is by design.


Particles: Work around race for CurveTexture background loading

Fixes #23684 by saving the result of the first check to avoid a discrepancy.

I haven't checked if master is affected but for good measure, I'm fixing it everywhere.

If the issue is caused by the first check failing, then the new behaviour is both checks will fail and the CurveTexture will be ignored. Which means instead of getting an error, users will get a heisenbug where their CurveTextures aren't applied at random.
I wonder if we have any ability to force a stall when a resource that is expected to be there has not finished initializing. Or perhaps we need to signal the particle shader to regenerate when the CurveTexture is finally loaded.

If the issue is caused by the first check failing, then the new behaviour is both checks will fail and the CurveTexture will be ignored. Which means instead of getting an error, users will get a heisenbug where their CurveTextures aren't applied at random.

That's right, though that's already the current experience they should have. This only prevents the shader compilation which would likely make the heisenbug be one black or white material for one frame (instead of a material not using its CurveTexture).
But I agree that if we can find a proper way to prevent the race condition, that'd be much better.

CC @reduz @RandomShaper @JFonS @pouleyKetchoupp if you have ideas re: threaded loading and race conditions in the shader generation.

As far as I know, resource loaders are in charge of defining dependencies between resources and the loading system then makes sure to load them in the proper order, so maybe the dependency is not correctly detected or ther is a bug in the loading system.
Take everything I just said with many grains of salt, since I never really worked on resource loading myself :P

Please check my comment on the bug. If I'm not mistaken there, this patch is not the way to go.

Closing as this workaround is not the right way to go (can still be used locally if anyone is suffering from this specific variant of the bug until it's fixed properly).


May need to update IP range.

[Enter feedback here]
I'm receiving traffic from outside <IP_ADDRESS>/14 but within <IP_ADDRESS>/12.
IP address: <IP_ADDRESS>
should we update the documentation? thanks.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 66bd8666-3566-a901-b25b-eb6baba6264a
Version Independent ID: e9f6310f-2207-8c81-d31a-3d5a80beb26b
Content: Office 365 URLs and IP address ranges - Microsoft 365 Enterprise
Content Source: microsoft-365/enterprise/urls-and-ip-address-ranges.md
Service: o365-administration
GitHub Login: @JoeDavies-MSFT
Microsoft Alias: josephd

@JoeDavies-MSFT Please help us resolving this issue. Thanks

@spuninst The address <IP_ADDRESS> is within the <IP_ADDRESS>/14 range, which includes <IP_ADDRESS> - <IP_ADDRESS>. Thanks for your question.

Awesome thank you.
On Wed, Nov 11, 2020, 1:05 AM Joe Davies<EMAIL_ADDRESS>wrote:

Closed #3321
https://github.com/MicrosoftDocs/microsoft-365-docs/issues/3321.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/microsoft-365-docs/issues/3321#event-3980001938,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG42G5AISU34H5LIK5QI5BLSPFXGZANCNFSM4TEZ5VIQ
.


Keith/export trace model

Checklist:

[x] Run unit tests and make sure they all pass
[x] Check and fix style errors
- pre-commit command line check
- Problems tab in PyCharm
[x] Bench test new/modified APIs by using and modifying the code in the example for the API method
[n/a] Add new classes to rst files, located at: \doc\source\api
[x] Generate documentation
[x] Verify the HTML. It gets generated at: \doc\build\html.
- Open index.html
- Click on "API Reference" at the top.
- Verify HTML for API changes.
[x] Check that test code coverage is at least 80% when Sherlock is running and can be connected to using gRPC

Codecov Report
Attention: Patch coverage is 26.66667% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 57.25%. Comparing base (5a85b85) to head (ad9e810).

Files
Patch %
Lines

src/ansys/sherlock/core/model.py
26.66%
44 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
- Coverage   57.76%   57.25%   -0.51%
==========================================
  Files          21       21
  Lines        3798     3858      +60
==========================================
+ Hits         2194     2209      +15
- Misses       1604     1649      +45

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix issues with invalid pixels during make check

If there are invalid pixels in the current frame the calculation of XYZ from distance data and are different than the values provided by the camera. This fix uses the confidence matrix as a mask for not checking invalid pixels

I will not available until November 5th. From my experience NaN is sometimes a false friend, in the past a bunch of software have not handled it correct. From  cppreference.com std::numeric_limits<float>::quiet_NaN only makes sense when the platform defines std::numeric_limits<T>::has_quiet_NaN == true. From my point of view this is the benefit of the user-defined image container the user has full control and decide on his own. For the image container and the OpenCV container we can use the same implementation like in libo3d3xx. With the risk the platform has std::numeric_limits<T>::has_quiet_NaN == false.

@tpanzarella looks like you also had higher priority tasks. When do you think you'll have the cycles to discuss the options?

@graugans We can discuss further tomorrow on our call.

This has been implemented in 0.11.1 at the driver level. Can you validate that this alleviates the issue of "invalid pixels during make check" per the original title of this PR.

For O3D301 With Firmware 1.23.1256
Test are still failing.
make check
[ 22%] Built target ifm3d_camera_shared
[ 37%] Built target ifm3d_framegrabber_shared
[ 44%] Built target ifm3d_image_shared
[ 51%] Built target gtest
[ 59%] Built target gtest_main
[ 70%] Built target ifm3d-image-tests
[==========] Running 10 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 10 tests from Image
[ RUN      ] Image.MoveCtor
[       OK ] Image.MoveCtor (143 ms)
[ RUN      ] Image.MoveAssignmentOperator
[       OK ] Image.MoveAssignmentOperator (199 ms)
[ RUN      ] Image.CopyCtor
[       OK ] Image.CopyCtor (202 ms)
[ RUN      ] Image.CopyAssignmentOperator
[       OK ] Image.CopyAssignmentOperator (199 ms)
[ RUN      ] Image.References
[       OK ] Image.References (198 ms)
[ RUN      ] Image.CloudMechanics
[       OK ] Image.CloudMechanics (400 ms)
[ RUN      ] Image.XYZImage
[       OK ] Image.XYZImage (201 ms)
[ RUN      ] Image.ComputeCartesian
/home/lpdev/lovepark/ifm3d/modules/image/test/ifm3d-image-tests.cpp:421: Failure
Value of: std::equal(x_cam.begin<std::int16_t>(), x_cam.end<std::int16_t>(), x_computed.begin<std::int16_t>(), cmp)
  Actual: false
Expected: true
[  FAILED  ] Image.ComputeCartesian (401 ms)
[ RUN      ] Image.TimeStamp
[       OK ] Image.TimeStamp (3277 ms)
[ RUN      ] Image.IlluTemp
[       OK ] Image.IlluTemp (202 ms)
[----------] 10 tests from Image (5423 ms total)

[----------] Global test environment tear-down
[==========] 10 tests from 1 test case ran. (5427 ms total)
[  PASSED  ] 9 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] Image.ComputeCartesian

 1 FAILED TEST
modules/image/test/CMakeFiles/check_image.dir/build.make:57: recipe for target 'modules/image/test/CMakeFiles/check_image' failed
make[3]: *** [modules/image/test/CMakeFiles/check_image] Error 1
CMakeFiles/Makefile2:741: recipe for target 'modules/image/test/CMakeFiles/check_image.dir/all' failed
make[2]: *** [modules/image/test/CMakeFiles/check_image.dir/all] Error 2
CMakeFiles/Makefile2:76: recipe for target 'CMakeFiles/check.dir/rule' failed
make[1]: *** [CMakeFiles/check.dir/rule] Error 2
Makefile:184: recipe for target 'check' failed
make: *** [check] Error 2

For O3X.  with firmware 1.0.126 There is another issue
 make check [ 22%] Built target ifm3d_camera_shared
[ 37%] Built target ifm3d_framegrabber_shared
[ 44%] Built target ifm3d_image_shared
[ 51%] Built target gtest
[ 59%] Built target gtest_main
[ 70%] Built target ifm3d-image-tests
[==========] Running 10 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 10 tests from Image
[ RUN      ] Image.MoveCtor
/home/lpdev/lovepark/ifm3d/modules/image/test/ifm3d-image-tests.cpp:34: Failure
Value of: std::equal(copy_of_amp.begin<float>(), copy_of_amp.end<float>(), amp2.begin<float>())
  Actual: false
Expected: true
[  FAILED  ] Image.MoveCtor (1357 ms)
[ RUN      ] Image.MoveAssignmentOperator
/home/lpdev/lovepark/ifm3d/modules/image/test/ifm3d-image-tests.cpp:69: Failure
Value of: std::equal(copy_of_amp.begin<float>(), copy_of_amp.end<float>(), amp2.begin<float>())
  Actual: false
Expected: true
[  FAILED  ] Image.MoveAssignmentOperator (1252 ms)
[ RUN      ] Image.CopyCtor
/home/lpdev/lovepark/ifm3d/modules/image/test/ifm3d-image-tests.cpp:105: Failure
Value of: std::equal(amp.begin<float>(), amp.end<float>(), amp2.begin<float>())
  Actual: false
Expected: true
[  FAILED  ] Image.CopyCtor (1257 ms)
[ RUN      ] Image.CopyAssignmentOperator
/home/lpdev/lovepark/ifm3d/modules/image/test/ifm3d-image-tests.cpp:154: Failure
Value of: std::equal(amp.begin<float>(), amp.end<float>(), amp2.begin<float>())
  Actual: false
Expected: true
[  FAILED  ] Image.CopyAssignmentOperator (1512 ms)
[ RUN      ] Image.References
^Cmodules/image/test/CMakeFiles/check_image.dir/build.make:57: recipe for target 'modules/image/test/CMakeFiles/check_image' failed
make[3]: *** [modules/image/test/CMakeFiles/check_image] Interrupt
CMakeFiles/Makefile2:741: recipe for target 'modules/image/test/CMakeFiles/check_image.dir/all' failed
make[2]: *** [modules/image/test/CMakeFiles/check_image.dir/all] Interrupt
CMakeFiles/Makefile2:76: recipe for target 'CMakeFiles/check.dir/rule' failed
make[1]: *** [CMakeFiles/check.dir/rule] Interrupt
Makefile:184: recipe for target 'check' failed
make: *** [check] Interrupt

@graugans  No I am running it on Linux

@tpanzarella  I do confirm that the unit test for cartesian compare are still failing for dev-0.11.2
[       OK ] Image.CloudMechanics (397 ms)
[ RUN      ] Image.XYZImage
/home/ifm3d/ifm3d/modules/image/test/ifm3d-image-tests.cpp:288: Failure
Value of: (xyz.type() == CV_16SC3) || (xyz.type() == CV_32FC3)
  Actual: false
Expected: true
[  FAILED  ] Image.XYZImage (201 ms)
[ RUN      ] Image.ComputeCartesian
/home/ifm3d/ifm3d/modules/image/test/ifm3d-image-tests.cpp:466: Failure
Value of: std::equal(x_cam.begin<std::int16_t>(), x_cam.end<std::int16_t>(), x_computed.begin<std::int16_t>(), cmp)
  Actual: false
Expected: true
[  FAILED  ] Image.ComputeCartesian (414 ms)
[ RUN      ] Image.TimeStamp
[       OK ] Image.TimeStamp (4482 ms)
[ RUN      ] Image.IlluTemp
[       OK ] Image.IlluTemp (190 ms)
[----------] 10 tests from Image (6576 ms total)

I will look into it. I know the ROS test is failing on 0.11.2 with an O3X. I expect O3X to fail on 0.11.1 (I created the 0.11.2 patch with the intent to fix it). I will see what I can do once I'm in the office. It will be a few hours.

@inbangsa What is an O3D301?

@tpanzarella it is an O3D303 with 40x30 opening angle.
https://www.ifm.com/us/en/product/O3D301

@tpanzarella I still see the cartesian unit test failing...

OK. So,  what is going on. Here is the h/w I am working with (O3D):
$ ifm3d dump | jq .ifm3d._
{
  "Date": "Tue Nov 13 10:30:43 2018",
  "HWInfo": {
    "Connector": "#!02_A300_C40_02452814_008023176",
    "Diagnose": "#!02_D322_C32_03038544_008023267",
    "Frontend": "#!02_F342_C34_17_00049_008023607",
    "Illumination": "#!02_I300_001_03106810_008001175",
    "MACAddress": "00:02:01:40:7D:96",
    "Mainboard": "#!02_M381_003_03181504_008022954",
    "MiraSerial": "0e30-59af-0ef7-0244"
  },
  "SWVersion": {
    "Algorithm_Version": "2.1.5",
    "Calibration_Device": "00:02:01:40:7d:96",
    "Calibration_Version": "0.9.0",
    "Diagnostic_Controller": "v1.0.33-92f88d349f-dirty",
    "IFM_Recovery": "unversioned",
    "IFM_Software": "1.23.1522",
    "Linux": "Linux version 3.14.34-rt31-yocto-standard-00009-ge4ab4d94f288-dirty (jenkins@dettlx190) (gcc version 4.9.2 (GCC) ) #1 SMP PREEMPT RT Tue Mar 13 16:06:07 CET 2018",
    "Main_Application": "1.0.33"
  },
  "ifm3d_version": 1102
}

I can even get the tests to pass by rapidly waving my hand in front of the camera in close proximity to the lens which, as you know, will cause many "bad pixels".

@tpanzarella I have to recheck this, cause my camera does run with a default calib. Unfortunatly I have to leave now. Tomorrow I am on a business trip. So hopefully @inbangsa can assist you.

@tpanzarella There might not be invalid pixels in the frame captured. I always do this test by seeing the view of camera in iVA making sure it showing me invalid pixel ( seen as black). If this is there then try to run the test.
I will also test this tommorow and will let you know the results.

@inbangsa The patch to the code explicitly sets bad pixels to 0. So, the idea is to not push this responsibility on the user but rather have the driver handle it directly in-line with pixel parsing.

@inbangsa Oh, reading your comment closer... yes, I am ensuring there are bad pixels several ways: 1) I am rapidly waving my hand in front of the camera. It causes many bad pixels even on O3D; 2) Using an O3X pointed at scenes that are well beyond its capabilities also results in images with many bad pixels even without inducing them (i.e., hand waving).

Here is the info on my O3X, I also cannot get the tests to fail with this device:
$ ifm3d dump | jq .ifm3d._
{
  "Date": "Tue Nov 13 10:55:58 2018",
  "HWInfo": {
    "MACAddress": "00:02:01:40:67:3F",
    "Mainboard": "#!02_M162_B30_12345678_008026357",
    "MiraSerial": "Not implemented"
  },
  "SWVersion": {
    "Algorithm_Version": "0.2.0",
    "Calibration_Device": "00:02:01:40:67:3f",
    "Calibration_Version": "1.0.0",
    "ELDK": "GOLDENEYE_YOCTO_HARDFP-371-06d9c894636352a6c93711c7284d02b0c794a527",
    "IFM_Software": "1.0.126",
    "Linux": "Linux version 3.14.34-rt31-yocto-standard-00029-gdf05c54-dirty (jenkins@dettlx152) (gcc version 4.9.2 (GCC) ) #1 SMP PREEMPT RT Wed Jan 24 13:40:11 CET 2018",
    "Main_Application": "0.4.1483"
  },
  "ifm3d_version": 1102
}

OK, so it turns out that I had an O3D301 in the lab and this was the key to showing me why the tests were failing. And, I think this is what @inbangsa was trying to tell me. Sorry for misunderstanding Sachin and thanks for your insights. Anyway, you can see this patch to see the fix.
The idea is, now that we are setting bad pixels to 0 in the driver, when we compute the Cartesian data off-board, for those bad pixels (the zeros) we will compute their coords to be exactly equal to the translation vector from the extrinsic calibration on the camera (the transform from pmd chip to camera glass). For my O3D, the largest translational component was tz (in the optical frame, related to the x coord in the ifm3d camera frame) which was ~-10.3306 mm and when cast to int16_t was 10 mm and our test tolerance is 1 cm, so everything passed. When using the O3D301, tz was ~-13.9331 mm which casts to -14 mm and exceeds the tolerances of our test so the comparisons of the x-coords, for bad pixels, would fail. So, the fix is to back out the translation vector for the computed cartesian for bad pixels prior to doing the comparision. This is reflected in the linked to patch above.
@graugans and @inbangsa can you test this on your end?

For completeness, I updated the ROS unit tests as well in this patch. They are passing for me.

@inbangsa Can you send me some data so I can take a look? Basically, I'd like all array data from that test (confidence image, unit vectors, camera computed point cloud, radial distance image, extrinsic calibration, etc.) I can work with most formats, csv is fine if that is easiest for you to produce.

Let's try this again @inbangsa I've pushed the latest patch to the unit tests. Your feedback is greatly appreciated.

@tpanzarella  cartesian compare test are working now. Here we are masking with confidence image again, which was done earlier also and then we decide to put all this in driver and user must not worry about confidence image.
I think this pixels are good and zero value might be of the fact of rollover beyond camera range. Also the data provided contains the glass area which can also affect the distance value.

Here we are masking with confidence image again, which was done earlier also and then we decide to put all this in driver and user must not worry about confidence image.

We are doing this masking here simply for purposes of the test. We want to check our computed values against the values computed by the camera. So, only in the case of computing the Cartesian manually will the user need to mask out bad pixels. Masking the pixels at the driver level is a useful feature our users will come to rely upon. The primary question I wanted to deal with was do we mark bad pixels with nan or 0. Ultimately the decision was to use 0 for several reasons, not the least of which is the inconsistency of data types used across cameras (i.e., there is no such thing as a nan for an integral type) so, to keep things camera agnostic 0 is being used. Further, given the practicalities of the hardware, using 0 as a sentinel value to flag pixels as "invalid" seems reasonable -- i.e., there is no plausible scenario where a good pixel will measure a 0 radial distance or (0,0,0) Cartesian coordinate. This leads to my standing questions as to how could we have "good" pixels with a radial distance value of 0? And, if this is a possibility (i.e., the hardware may return data that look like this), should we in the driver "fix" it -- i.e., should we be consulting both the confidence image and the radial distance image to flag pixels as bad in the other arrays?

I think this pixels are good and zero value might be of the fact of rollover beyond camera range. Also the data provided contains the glass area which can also affect the distance value.

When you say "rollover in the camera range" I assume you mean the ambiguity range of the selected imager type? Assuming a single frequency (which we use by default in the unit tests), you are proposing that those 5 pixels likely measured 1 mm beyond the max "allowable" by the phase shift measurement which would "rollover" to exactly 0 mm. I suppose that is a possibility. Below is a histogram of the radial distances from the data you sent over. For reference, the max radial distance was 5080 mm (max on-camera computed Cartesian x-coord (z in the optical frame)) was 5046 mm.

@tpanzarella Thanks for all the information.


Fix counter and getting of all unread messages

Fix for #80
There could be a situation when participant's last_read attribute will be equal to null. Then userUnreadMessagesCount() and userUnreadMessages() will throw an exceptions.
Unit tests were disabled. After their activation I've done some tweaks to make them work correctly and add checks for an issue I've described above.
Because unit tests method it_should_get_all_unread_messages_for_user() tried to work with userUnreadMessages() output using iterator thru collection userUnreadMessages() now wrap array in \Illuminate\Support\Collection.

Thanks again @a-komarev!


Adding TensorFlow Hub KerasLayer to Sequential Model Raises ValueError

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
source
TensorFlow version
2.16.1
Custom code
No
OS platform and distribution
Ubuntu 22.04.3 LTS
Mobile device
No response
Python version
Python 3.11.0rc1
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
12.3.0
GPU model and memory
No response
Current behavior?
I can execute the following code without any issues in TensorFlow 2.15.0 and TensorFlow Hub 1.16.1. However, when I upgrade the TensorFlow version to 2.16.0 or above, I encounter an error stating that KerasLayer cannot be added to the Sequential model.
Standalone code to reproduce the issue
import tensorflow as tf
import tensorflow_hub as hub

image_size = 224
URL = "https://tfhub.dev/tensorflow/efficientnet/b0/feature-vector/1"

model = tf.keras.Sequential([
        hub.KerasLayer(URL, input_shape=(image_size, image_size, 3))
])

Relevant log output
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Cell In[29], line 1
----> 1 model = tf.keras.Sequential([
      2         feature_extractor,
      3         tf.keras.layers.Dense(2, activation = 'softmax')
      4 ])
      6 model.build([None, image_size, image_size, 3])
      7 model.summary()

File /usr/local/lib/python3.10/dist-packages/keras/src/models/sequential.py:70, in Sequential.__init__(self, layers, trainable, name)
     68 if layers:
     69     for layer in layers:
---> 70         self.add(layer, rebuild=False)
     71     self._maybe_rebuild()

File /usr/local/lib/python3.10/dist-packages/keras/src/models/sequential.py:92, in Sequential.add(self, layer, rebuild)
     90         layer = origin_layer
     91 if not isinstance(layer, Layer):
---> 92     raise ValueError(
     93         "Only instances of `keras.Layer` can be "
     94         f"added to a Sequential model. Received: {layer} "
     95         f"(of type {type(layer)})"
     96     )
     97 if not self._is_layer_name_unique(layer):
...
    101         "the name of a layer in this model. Update the `name` argument "
    102         "to pass a unique name."
    103     )

ValueError: Only instances of `keras.Layer` can be added to a Sequential model. Received: <tensorflow_hub.keras_layer.KerasLayer object at 0x7a4ac7e30f40> (of type <class 'tensorflow_hub.keras_layer.KerasLayer'>)

After investigating the code, I found a potential cause of the issue in tensorflow_hub/keras_layer.py lines 26-31:
# Use Keras 2.
version_fn = getattr(tf.keras, "version", None)
if version_fn and version_fn().startswith("3."):
  import tf_keras as keras
else:
  keras = tf.keras

I believe this conditional import is causing the isinstance(layer, Layer) check in Sequential.add to return False in certain cases.

Hi @ruddyscent ,
TFHub has dependency on tf_keras package (i.e Keras2) as per the setup.py of TFHub.
https://github.com/tensorflow/hub/blob/ff72e25fef44bd67d5c14fb5328aa44e303e3404/tensorflow_hub/pip_package/setup.py#L31
Since TF2.16 comes with Keras3 the problem arises. As a workaround, you can install tf_keras package and set environment variable TF_USE_LEGACY_KERAS=1 to ensure Keras2 will be used with tf.keras.

After investigating the code, I found a potential cause of the issue in tensorflow_hub/keras_layer.py lines 26-31:
# Use Keras 2.
version_fn = getattr(tf.keras, "version", None)
if version_fn and version_fn().startswith("3."):
  import tf_keras as keras
else:
  keras = tf.keras

Depending on the Keras version, the module might either import tf_keras or directly use tf.keras, the latter causes the isinstance(layer, Layer) check in Sequential.add to return False for hub.KerasLayer, even though it inherits from keras.layers.Layer

Hi, When I tried with TF2.16v on Colab environment the error stack seems generated from the _ensure_keras_2_importable() function from tensorflow_hub/__init__.py as per attached gist.

# Use Keras 2.
version_fn = getattr(tf.keras, "version", None)
if version_fn and version_fn().startswith("3."):
  import tf_keras as keras
else:
  keras = tf.keras

Even this code seems confusing to me. If version_fn results in Keras3 then it tries to import tf_keras to use Keras2 else it assumes Keras2 is alreday there(i.e TF<=2.15v) hence it takes keras=tf.keras.
But version_fn = getattr(tf.keras, "version", None) returns None making this to use tf.keras (i.e Keras3) which ic not compatible with TF_Hub.

# Use Keras 2.
version_fn = getattr(tf.keras, "version", None)
if version_fn and version_fn().startswith("3."):
  import tf_keras as keras

From the code above if version_fn is not None and if it starts with "3" (which means Keras 3 found) in that case it is importing tf_keras package as keras. Please note that tf_keras package is for Keras2. This indicates TFHub supports only Keras2 package.
The else part it assumes that version_fn doesn't starts with "3" which case it assumes Keras2 installed with TF package and it marks keras=tf.keras. But for any case if version_fn becomes None and if Keras3 installed with TF then tf.keras will become Keras3 which might a problem.
@Aloqeely , Could you please import TF2.16 and confirm what will be the version_fn output ?

Here you go
import tensorflow as tf

version_fn = getattr(tf.keras, "version", None)
print("TF Version: " + tf.__version__)
print("TF Keras Version: " + version_fn())

Output:
TF Version: 2.16.1
TF Keras Version: 3.0.5

Hi @ruddyscent ,
TFHub has dependency on tf_keras package (i.e Keras2) as per the setup.py of TFHub.
https://github.com/tensorflow/hub/blob/ff72e25fef44bd67d5c14fb5328aa44e303e3404/tensorflow_hub/pip_package/setup.py#L31
Since TF2.16 comes with Keras3 the problem arises. As a workaround, you can install tf_keras package and set environment variable TF_USE_LEGACY_KERAS=1 to ensure Keras2 will be used with tf.keras.

If this workaround fixes ruddyscent's problem, then I think we should mark this issue as resolved, because the problem is that tensorflow hub does not support Keras 3, so it is not relevant to this repository.

3.0.5

This means when tf.keras version is 3.x then Hub suggesting to import tf_keras as keras which is a Keras2 package. For that we should install with tf_keras package using pip install tf_keras. But from the error log the package is having keras/src which seems to be from Keras3 package for me.

This means when tf.keras version is 3.x then Hub suggesting to import tf_keras as keras which is a Keras2 package. For that we should install with tf_keras package using pip install tf_keras. But from the error log the package is having keras/src which seems to be from Keras3 package for me.

Yep, hub does that.
The error log is caused by tf.keras.Sequential (Keras 3, hence the error is produced from keras/src) after it received a hub.KerasLayer (Keras 2)

win10, no gpu, no colab
tensorflow_hub를 사용하시려면 다음과 같이 해보세요
import tensorflow as tf
import tensorflow_hub as hub
import tf_keras as keras  """tensorflow_hub 설치시 자동으로 설치됩니다."
...
...
model = keras.Sequential([
hub,KerasLayer(url, input_shape=(size, size, 3)
...
...
imgfile = keras.utils.get_file('image.jpg', 'https://..........')
작동이 잘됩니다.

Thank you, @sj-yoon, for your assistance.
The solution provided by @SuryanarayanaY works well for my situation.

I had the same issue, and I could fix it with the solution provided by @SuryanarayanaY. Thanks
Others can check my notebook for steps to fix it at this page.

Could you please check whether this issue is resolved with the latest tensorflow v2.17 which contains Keras 3.0 version. As Keras3 now built to support multiple backends there are some changes in design.
Also this issue is more related to Keras, please try to raise the issue in keras-team/Keras repo for the quick resolution. Thank you!

Could you please check whether this issue is resolved with the latest tensorflow v2.17 which contains Keras 3.0 version.

The problem still exists with the latest tensorflow version (currently 2.17.0) as the following minimal Dockerfile shows:
FROM python:3.12.5

RUN pip3 install tensorflow==2.17.0 tensorflow-hub==0.16.1

RUN echo 'import tensorflow as tf' > main.py
RUN echo 'import tensorflow_hub as hub' >> main.py
RUN echo 'model = tf.keras.Sequential([hub.KerasLayer("https://tfhub.dev/tensorflow/efficientnet/b0/feature-vector/1", input_shape=(224, 224, 3))])' >> main.py

RUN python main.py

docker build --rm --progress=plain .

Output:
...
6.058   File "//main.py", line 3, in <module>
6.058     model = tf.keras.Sequential([hub.KerasLayer("https://tfhub.dev/tensorflow/efficientnet/b0/feature-vector/1", input_shape=(224, 224, 3))])
6.058             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
6.058   File "/usr/local/lib/python3.12/site-packages/keras/src/models/sequential.py", line 74, in __init__
6.058     self.add(layer, rebuild=False)
6.058   File "/usr/local/lib/python3.12/site-packages/keras/src/models/sequential.py", line 96, in add
6.058     raise ValueError(
6.058 ValueError: Only instances of `keras.Layer` can be added to a Sequential model. Received: <tensorflow_hub.keras_layer.KerasLayer object at 0x7ff1f3d0be60> (of type <class 'tensorflow_hub.keras_layer.KerasLayer'>)


Selfhosting syntax progress

the existence of this pr doesn't mean i'm done i just want something to link to, to show progress

Merging to start basing implicit arguments work on.


Mutual Followers

Is there a way to get all the mutual followers of a profile?
I checked with Chrome dev tools but no luck, maybe i missed something.

This is trivial to achieve with what Instaloader provides:
from instaloader import Instaloader, Profile

MY_PROFILE = "..."
OTHER_PROFILE = "..."

L = Instaloader()
L.load_session_from_file(MY_PROFILE)

my_followers = set(Profile.from_username(L.context, MY_PROFILE).get_followers())
other_followers = set(Profile.from_username(L.context, OTHER_PROFILE).get_followers())

mutual_followers = my_followers & other_followers

for follower in mutual_followers:
    print(follower)

For this to work I need to have access to all the followers of the target profile. What if I am not following the target profile which is private? Is it possible then?

That is stored in the profile JSON.
$ cat profile/profile_*.json | jq .node.edge_mutual_followed_by

"edge_mutual_followed_by": {
"count": 52,
"edges": [
{
"node": {
"username": "..."
}
},
{
"node": {
"username": "..."
}
},
{
"node": {
"username": "..."
}
}
]
}

This is the JSON file I got, in this the count says 52 but only 3 profiles are displayed. What is expect to get is all 52 profiles.
Any idea?

It is unlikely that we can get all mutual followers in this case. This is a privacy feature since it is a private profile that you do not follow.

Alright. No worries. I'll go with your method. Thanks for helping  👍👍


Added support for iOS with arm64e

@agah-pt why this travis testing is still pending?

I had understood that arm64e is corresponding to the ARMV8.3. is it compatible with arm64?


Update Horizon v0.14.0 protocol changes doc

Human readable: https://github.com/stellar/go/blob/c35a827b74f975f09a973b139cdc250069a5dc9c/protocols/horizon/README.md I wanted tables to be aligned, from this version we will add a new tables in the top so the diffs will be much cleaner.

You're right, fixed. I forgot we don't have methods for these endpoints in clients/go, I was thinking about protocols/horizon all the time.


AV Error with this file

Another problem, an Access Violation with using another SVG file, using version committed on 07/09/2024.
I'll send you the file via email, because is a copyrighted SVG.
thanks!

Hi Carlo. This has been fixed in the latest revision.

Thank you very much!


Update CryptoSwift version

With Xcode 12.5, I'm not able to build project because it uses older version of CryptoSwift. Here's the open issue https://github.com/krzyzanowskim/CryptoSwift/issues/864

This repo is not actively maintained, I think you can just fork and update CryptoSwift to latest version

Sure, closing this ticket.


Danknul is broke

In version 1.0 the danknul is not working correctly also we are a few versions behind the latest. Can you please update the mod to the latest version please.

Will update in the next version, thanks for the heads up


Search selection should set most precise field.

The problem
When searching for "react" and pressing enter user lands on "repeat" page.
When searching for "start" and pressing enter user lands on "X::Proc::Async::AlreadyStarted" page.
It happens because similar results are shown first. And since it applies almost to every keyword it is super annoying.
Suggestions
Keep categories and their order (they are nice) but set selection (light green highlight) on best matched item. So when enter is pressed best match is automatically chosen.

See https://github.com/perl6/doc/issues/247 and https://github.com/perl6/doc/issues/1108

Actually, I would say it's exactly #1108.

Closing as a duplicate of #1108 - thanks for the report.


[BUG]: add NVMeTCP connection parameter ctrl-loss-tmo=-1 to implement powerstore best practices

Bug Description
The Dell Linux host connectivity guide recommends on page 214
https://elabnavigator.dell.com/vault/pdf/Linux.pdf?key=1725374107988
By default, the Linux controller enters a reconnect state when it loses connection with the target. The default timeout for
reconnecting is 10 minutes. However, a PowerStore node reboot may take more than 10 minutes. It is recommended to set
ctrl-loss-tmo = -1 to keep the controller constantly reconnecting.
Per this SUSE documentation [https://documentation.suse.com/sles/15-SP5/html/SLES-all/cha-nvmeof.html]
In case of a path loss, the NVMe subsystem tries to reconnect for a time period, defined by the ctrl-loss-tmo option of the nvme connect command
I'm concerned that this ctrl-loss-tmo = -1 parameter will be required for the NVMeTCP connection to reconnect to PowerStore nodes when performing a PowerStore NDU (non-disruptive code upgrade) where the PowerStore nodes reboot, one at a time, and during a code update, the nodes very well may be unavailable for longer than the default path timeout.
My novice reading of the code:
nvmeTCPConnect function in gonvme_tcp_fc.go does not include this parameter
if duplicateConnect {
exe = nvme.buildNVMeCommand([]string{NVMeCommand, "connect", "-t", "tcp", "-n", target.TargetNqn, "-a", target.Portal, "-s", NVMePort, "-D"})
} else {
exe = nvme.buildNVMeCommand([]string{NVMeCommand, "connect", "-t", "tcp", "-n", target.TargetNqn, "-a", target.Portal, "-s", NVMePort})
}
If a change is needed; I also request that current supported CSI-powerstore driver builds be updated so that (for example) an OpenShift 4.14 environment using CSM-Operator 1.5.1 and CSI driver 2.10.1 can get this enhancement
Logs
no logs available ; see Dell SR 197072815
Screenshots
No response
Additional Environment Information
No response
Steps to Reproduce
Perform a PowerStore code upgrade / NDU from <IP_ADDRESS> to <IP_ADDRESS> for example with OpenShift attached using PVs
Expected Behavior
Hosts should be able to survive paths to storage going away and coming back during all normal data center operations
CSM Driver(s)
csi-powerstore 2.10.1
Installation Type
csm-operator 1.5.1
Container Storage Modules Enabled
No response
Container Orchestrator
OpenShift 4.14
Operating System
OpenShift Linux - RHCOS based on RHEL 9.2

Hi @dancohen21, can this request be part of https://github.com/dell/csm/issues/1465? I see https://github.com/dell/csm/issues/1465 is a broader scope around NVMe best practices and also contains this issue somewhere. Please update so that we can close this issue and track these in the other one, thanks.

link: 28462

Resolving. New documentation for the csi-powerstore driver will be published in CSM 1.12 and the ctrl_loss_tmo will be disabled for any NVMe connections.


why we removed camera based localization in modules localization

I see "It is replaced by modules/elo' in comment.
I think,  putting camera localization in modules/localization is better than put in it in  modules/elo
and elo is just some .so files or some special roads map files and elo can not be used by other users.
so why we remove camera localization source code and add elo modules?

We agree that they are both localization modules. But we will re-organize and update them.
modules/elo is more of a standalone binary library. In the future, we may instead provide a download link for this library.
modules/localization/ will be the place for all the configurable, open-source localization methods.


adds EOFError message to handlers

i think this still misses the biggest EOFError culprit which is the
node.save at the end, but we don't seem to have a node_save_failed
event to hook.

:construction: needs tests.

i looked at hooking run_failed up to an error mapper but decided that was a bridge too far for today..

O_o :+1:
Also, I'd be totally cool with adding a new event for the final node save if that makes things easier. I think I just skipped it because you normally shouldn't get a 401/403 there since you have to have made successful API calls before then.

yeah, just adding a new event might be simpler, but i was worried that it would duplicate error messages with the later run_failed hook

Nice :+1:


More than one PopupBox (MaterialDesignMultiFloatingActionPopupBox)

Having more than one Popupbox with floating action style would cause a bug, which the first one's icon is disappeared.

the code:
<materialDesign:PopupBox Style="{StaticResource MaterialDesignMultiFloatingActionPopupBox}"
						 PlacementMode="BottomAndAlignCentres"
						 ToolTipService.Placement="Bottom"
						 ToolTip="PopupBox, Style MaterialDesignMultiFloatingActionPopupBox">
	<StackPanel>
		<Button ToolTip="One">1</Button>
		<Button ToolTip="Two">2</Button>
		<Button ToolTip="Three">3</Button>
	</StackPanel>
</materialDesign:PopupBox>
<materialDesign:PopupBox Style="{StaticResource MaterialDesignMultiFloatingActionPopupBox}"
						 PlacementMode="BottomAndAlignCentres"
						 ToolTipService.Placement="Bottom"
						 ToolTip="PopupBox, Style MaterialDesignMultiFloatingActionPopupBox">
	<StackPanel>
		<Button ToolTip="One">1</Button>
		<Button ToolTip="Two">2</Button>
		<Button ToolTip="Three">3</Button>
	</StackPanel>
</materialDesign:PopupBox>

Here is a more specific sample:

Duplicate of https://github.com/ButchersBoy/MaterialDesignInXamlToolkit/issues/291


Assign file id, response ,public url and url,what's the difference

The assign file id api ,return json output like {"fid":"3,0c0d9a36a1","url":"<IP_ADDRESS>:8081","publicUrl":"<IP_ADDRESS>:8081","count":1}
and upload file return json output like:
{"fileName":"hello.txt","fileUrl":"<IP_ADDRESS>:8081/2,0df4be02f5","fid":"2,0df4be02f5","size":36}
i want to know ,what's the difference? why we need two url?

One is for internal usage. The other is for external usage. Public URL is not used by the system to access the volume server.