Add AL2 Docker build script and configuration files

Issue #, if available: https://github.com/opendistro-for-elasticsearch/opendistro-build/issues/696
Description of changes:
Remove security demo config setup. This is pre-installed in the Docker image.
Comment out performance analyzer startup code because it uses supervisord. This will be replaced with something that is not supervisord.
Test Results:

Ran build-image.sh -v 1.13.1 to download and generate odfe:1.13.1 locally.
Ran docker run -p 9200:9200 -p 9600:9600 --rm -it -e cluster.name=banana odfe:1.13.1 to start a single-node cluster.
curl -XGET https://localhost:9200 -u 'admin:admin' --insecure results:
{  "name" : "8aa2e7ca55ff", "cluster_name" : "banana", "cluster_uuid" : "sxwp-1kRR7yszuDFVo2xmw", "version" : {   "number" : "7.10.2",   "build_flavor" : "oss",   "build_type" : "tar",   "build_hash" : "747e1cc71def077253878a59143c1f785afa92b9",   "build_date" : "2021-01-13T00:42:12.435326Z",   "build_snapshot" : false,   "lucene_version" : "8.7.0",   "minimum_wire_compatibility_version" : "6.8.0",   "minimum_index_compatibility_version" : "6.0.0-beta1" }, "tagline" : "You Know, for Search" }

Cluster is up, cluster name is correct, and it can serve traffic.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on signing off your commits, please check here.

@camerski where did you copy the elasticsearch.yml and log4j from?

@camerski where did you copy the elasticsearch.yml and log4j from?

From the old docker build directory.

@camerski where did you copy the elasticsearch.yml and log4j from?

From the old docker build directory.

nvm I realize you just move them from elasticsearch folder to config folder.


[HOLD for payment 2023-03-06] Date format placeholder is missing for Date field on the date of birth page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Log in with an account for which the date of birth has never been set.
Navigate to Settings > Profile > Personal Details->Date of Birth.

Expected Result:
The date format should be visible for the date of birth field in android like other platforms.
Actual Result:
There is no date format shown in android.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari

Version Number: 1.2.71-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @Harshdeepjoshi
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1676121834554719
View all open jobs on GitHub

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Hello, I'm Nicolay from Callstack and I'm interested in taking and analysing this issue to work on a fix for it.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Date text input field should show default placeholder across all platforms
What is the root cause of that problem?
Application doesn't use placeholder for date picker field. Not using default placeholder - may potential issue - different browsers applies different default placeholders for input type = date. Which bring fully inconsistency between different platforms
What changes do you think we should make in order to solve the problem?
Please provide placeholder which we would like to show (mm/dd/yyyy, or yyyy-mm-dd or anything else). Also will be nice to apply correct format for selected value - now we use format yyyy-mm-dd when date is chosen)
Native apps:
For native apps we need to pass default placeholder (which currently is empty string now) and also we need to use forceActiveLabel - which will indicate for text input - that we need to show not only label but combination of label + placeholder.
For mWeb android/web/desktop
For android it's possible to resolve that issue. The root case for android web/web/desktop - that app directly applies type to input in didMount this.inputRef.setAttribute('type', 'date'); - which doesn't show any placeholder (in official [html docs](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/date#additional_attributes) there is a note that browser may not render placeholder). The only possible solution to switching type of input during interactions - from type="text" to type="date" and vice versa. The workaround - we can be changing types outside of react using html events - Ex.
            this.inputRef.setAttribute('onfocus', '(this.type=\'date\')');
            this.inputRef.setAttribute('onfocusout', '(this.type=\'text\')');

Doing this changes will make consistency for native ios/android, web, desktop, android mWeb to use same placeholders and not rely on any default one from html. Also as i see on format value (when we choose anything on picker) - by default it used YYYY-MM-DD - and when we switch to text type automatically - it will also show date in correct format in text field
What alternative solutions did you explore?
Unfortunately there is no way to make it working for ios mWeb - ios doesn't make this swap between type of textinput live - and when fire focus event - it will show keyboard instead of calendar. seems related to how focus events done by default in ios. Based also on my tries - it's looks like a hack rathe than correct behaviour to make it working on IOS mWeb

since it seems like it would be hacking our way around to make this truly platform consistent, I am torn on whether to try to fix this. Your team works on thorough refactor of the component so it might be different then.
I am leaning towards punting this for now and then potentially revisit once the refactor is done in case anything has changes. I think we aim for cross platform consistency but not if it means “hacks”

@mountiny for native side - nothing will be changed even after refactor - we need to apply changes for ios and android because we missing some props to make it working.
For other platforms - I agree - in case that picker now will be a custom component - we will move out from type="date" in input and this will allow as to remove this setAttributes fully from didMount

Lets do the native side if we are just missing the props. yyyy-mm-dd this is the format to go with

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.76-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/15344

If no regressions arise, payment will be issued on 2023-03-06. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@narefyev91] Propose regression test steps to ensure the same bug will not reach production again.
[ ] [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

I dont think the steps above really apply to this test as it was more a recent design decision and we will have a full set of regression step for the new date picker component.

I am going to close this one as there is nothing actionable here.

📣 @Harshdeepjoshi! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01e5d6057af1ee90ae

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

Still receiving errors when I try to create an Upwork job:

I created the job from scratch:
https://www.upwork.com/jobs/~01ba23d5dae61ee6e1
@Harshdeepjoshi ready for you to accept my invite to apply

All paid. Thanks!


DDPB-3874 - Contacts report section behat re-write

Purpose
The first of our new style behat tests! This tests the contacts section with the following requirements:

No contacts
Single contact
Multiple contacts
Section navigation arrows

Fixes DDPB-3874
Approach
A few false starts while trying to auth without having to fill a form in (I gave up in the end and stored by attempts here) but I like how this has come out. Forcing lots of the individual steps behind a plain English description allowed me to use fake data in tests which can then be asserted on without having to type random static values into the gherkin syntax itself. I'm going to run this by Stacey and see if it makes sense so there may be an update or two following that.
Every scenario creates its own data and clears out previous data automatically by using a @BeforeScenario filter step so this way it will be impossible to fall back in to bad habits and rely on data created in previous steps to pass future steps. This also FINALLY makes TDD starting from an integration level possible by having a short(ish) feedback loop when running single scenarios.
I've also started a v2 folder for contexts (I know, I know, they're multiplying at the moment) with the view to separate out any new behat code we write there so we can safely delete all the old code once we cover off all features of the app.
Learning
Our RestClient and auth approach is really really difficult to emulate in tests. I'm not sure if its behat getting in the way or not but I just couldn't get the app to respect the AuthToken added to headers on subsequent requests once provided after a successful auth call to the API (see link above in Approach). Anyone that can get this working will get a crate of whatever beverage they want.
Checklist

[x] I have performed a self-review of my own code
[ ] I have updated documentation (Confluence/ADR/tech debt doc) where relevant
[x] I have added tests to prove my work
[ ] The product team have approved these changes

Frontend

[ ] I have run an in-browser accessibility test (e.g. WAVE, Lighthouse)
[ ] There are no deprecated CSS classes noted in the profiler
[ ] Translations are used and the profiler doesn't identify any missing
[ ] Any links or buttons added are screen reader friendly and contextually complete

Closing as this env is cursed and I'm not about to waste half a day trying to fix it 😭


To return 400 when reject RBAC for certain Http GET

Due to certain contract with Azure, we should not return 403 (Forbidden). We need to settle on either 400 (BadRequest) or 401 (Unauthorized).

@davidebbo this is low hanging - 400 vs 401?   My preference is 401.

400.5. But round up if you need to :)

Ah, funny.   I will go with 401 here as well as in Azure.


[Feature]: Proper Documentation

Description of the new feature / enhancement
The code is not properly documented, Its messed up actually So I will help you out with a better documentation for easy Installation for those who just want to Install and use and below that for the developers and issue guide type.
Scenario when this would be used?
This would be helpful in every case making it more popular and all in one solution in our repository.
Supporting information
No response

It's pretty hard to not document Go code, given that it is auto-generated. https://pkg.go.dev/github.com/coreybutler/nvm-windows/src. The installation process is "click and follow the wizard".
Anyhow, you're welcome to document whatever you want (I recommend a blog article)... I certainly don't want to discourage that. However; new documentation is not a high priority for the project, and with 10M+ downloads, it seems like most people have figured out how to use it. Before you spend your time on this, remember, NVM4W will be deprecated when we release Runtime.


Fix rounding error for close-to-100% scratches

Any score greater than 0 should never yield a "100%" on the site

Trivially fixable in ScoreBadge.tsx's calculateScorePercent function.

Addressed in #584


Add 'Services' to search/suggest

Is your feature request related to a problem? Please describe.
Ability to search for database services (by name).
Describe the solution you'd like
Index database services in Elasticsearch: https://github.com/open-metadata/OpenMetadata/blob/4d09c165d730810c8bb0ec7546c5bdddbae7e48f/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/search/SearchResource.java#L143
Describe alternatives you've considered
Include service name in the fields considered when searching for tables: https://github.com/open-metadata/OpenMetadata/blob/4d09c165d730810c8bb0ec7546c5bdddbae7e48f/catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/search/SearchResource.java#L229
Additional context
In our case, we have a big number of trino services, each corresponding to a catalog.  Searching for a service would correspond to searching for a catalog, which is desirable with a large number of services of same type

one can do so today using service:service_name in search box.
We will be adding a advanced search UI that will make it easier to search for specific attributes in a entity

@dvecerdea ^


How to correctly disable buttons now?

We have stuff like this:
  <BsButton
    data-test-btn-open-user-modal
    disabled={{if
      this.organizationService.isOrganizationSelected
      (not this.canAddUserToCurrentOrganization)
      (not this.canAddUserToAtLeastOneOrganization)
    }}
    @defaultText="Add User"
    @type="primary"
    @icon="mdi mdi-18px mdi-plus"
    @onClick={{action "setupModal"}}
  />

I made sure to remove the @ from disabled, but it still seems to throw deprecations. How are we supposed to set this?

If anyone else is seeing deprecations and not sure why, check if you have any dd.button instances you need to also updated. Fixed it for me!

Glad to know that someone is actually using that deprecations. :smile:


It does not work in ionic.

$pgCheckout.open... It shows no error, or open the popup, nothing.
Can someone help me

Is there any updates for this issue?

Checkout isn't officially suported in Cordova/Phonegap environment, but it maybe be suported in the future.

Same issue here, trying to make it work on in Cordova/Phonegap. When I run on the desktop it works, but not on device, any workarround on this?


What directory to the tflite files go in?

I'm utterly lost. Running the docker image and can't find where to put my custom file.
Any help appreciated.
Thanks.

Found it: /usr/src/.venv/lib/python3.11/site-packages/wyoming_openwakeword/models
Doesn't recognise my model there - further investigation required.

and you need to add a version number to your wake word file. Job done.


"Download" button present in 'Response body' code is not accessible using keyboard keys. :A11y_VS Code extension for API Center_OpenAPIDocumentation_CodeExecute_Keyboard

"Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier."
Please do not close this bug. This bug should only be closed by Trusted Tester after verification.
GitHub Tags
#A11yTCS; #A11yMAS; #A11ySev2; #WCAG2.4.7; #GH_VSCodeextensionforAPICenter_Linux_Apr2024; #DesktopApp; #VS Code Extension for API Center; #Keyboard; #Linux; #FTP;
Environment Details:
Application Name: VS Code Extension for API Center
OS: Linux- Ubuntu 22.04.4
Repro Steps:

Create a API center in azure portal. Open Visual studio Code.
Tab till API center extension in the left side panel and press enter.
Tab till definition under the api name which you have created and press enter.
The name which you have provided to the definition will appear for ex-"openapi4", right click on it.
Go to "Open API Documentation" using the down arrow and press enter.
Demo conference API screen will appear.
Tab till sessions dropdown button and press enter. Tab till try it out and press enter.
Tab till execute and press enter.
Navigate using TAB key to "Download" button present in 'Response body' code and observe the issue.

Actual Result:
"Download" button present in 'Response body' code is not accessible using keyboard TAB keys.
Note: Button present in 'Curl' is also not accessible using keyboard and mouse.
Similar issue is also observed in below scenario:
Issue 1: Definition_ Generate HTTP File

Create a API center in azure portal.
Open Visual studio Code.
3.Tab till API center extension in theleft side panel and press enter.
Tab till definition under the api name which you have created and press enter.
The name which you have provided to the definition will appear for ex-"openapi4", right click on it.
Go to "Generate HTTP file" using the down arrow and press enter.
A HTTP file will appear. Try to navigate to "Send request" button and observe that "Send request" button is not accessible using keyboard.

Expected Result:
"Download" button present in 'Response body' code should be accessible using keyboard TAB keys.
User Impact:
Keyboard only users will not be able to access the download button and will not be able to perform the further action.
Attachment:

@PoojaNamde Could you please break down the two issues into two different bugs?

Created new bug for another issue https://github.com/microsoft/vscode-azureapicenter/issues/138


What about docs

let's work on documentation.

[ ] #7
[ ] #8
[ ] #9
[x] #10

What should we do for documentation for this project. Any thoughts @Sahil590

List of tasks

[ ] create a 'docs' folder
[ ] Create a new 'index.md' document
[ ] Turn on Github Pages
[ ] Decide if we want to go with something more complex

created issues for the first few points

document.write('hello world')


Define dtype in SquareAttack with norm=2

Signed-off-by: Beat Buesser<EMAIL_ADDRESS>Description
This pull request adds a definition of dtype in SquareAttack with norm=2 to support PyTorch estimators.
Fixes #870
Type of change
Please check all relevant options.

[x] Improvement (non-breaking)
[ ] Bug fix (non-breaking)
[ ] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Thank you for the quick fix @beat-buesser !!!
Do you think it would be worth adding a unit test for square attack with the 2 norm? As far as I can tell the test now only runs against inf

Thank you for the quick fix @beat-buesser !!!
Do you think it would be worth adding a unit test for square attack with the 2 norm? As far as I can tell the test now only runs against inf

Codecov Report

Merging #877 (2a113b4) into dev_1.5.2 (82727cb) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##           dev_1.5.2     #877      +/-   ##
=============================================
+ Coverage      64.79%   64.82%   +0.02%
=============================================
  Files            176      176
  Lines          17099    17264     +165
  Branches        3156     3242      +86
=============================================
+ Hits           11079    11191     +112
- Misses          4786     4823      +37
- Partials        1234     1250      +16

Impacted Files
Coverage Δ

art/attacks/evasion/square_attack.py
37.14% <0.00%> (ø)

art/attacks/evasion/auto_attack.py
60.16% <0.00%> (-12.95%)
:arrow_down:

art/attacks/evasion/shadow_attack.py
43.79% <0.00%> (-2.72%)
:arrow_down:

art/attacks/evasion/brendel_bethge.py
57.32% <0.00%> (-0.82%)
:arrow_down:

art/attacks/evasion/saliency_map.py
85.84% <0.00%> (+1.93%)
:arrow_up:

...asion/adversarial_patch/adversarial_patch_numpy.py
68.93% <0.00%> (+7.90%)
:arrow_up:

Codecov Report

Merging #877 (2a113b4) into dev_1.5.2 (82727cb) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##           dev_1.5.2     #877      +/-   ##
=============================================
+ Coverage      64.79%   64.82%   +0.02%
=============================================
  Files            176      176
  Lines          17099    17264     +165
  Branches        3156     3242      +86
=============================================
+ Hits           11079    11191     +112
- Misses          4786     4823      +37
- Partials        1234     1250      +16

Impacted Files
Coverage Δ

art/attacks/evasion/square_attack.py
37.14% <0.00%> (ø)

art/attacks/evasion/auto_attack.py
60.16% <0.00%> (-12.95%)
:arrow_down:

art/attacks/evasion/shadow_attack.py
43.79% <0.00%> (-2.72%)
:arrow_down:

art/attacks/evasion/brendel_bethge.py
57.32% <0.00%> (-0.82%)
:arrow_down:

art/attacks/evasion/saliency_map.py
85.84% <0.00%> (+1.93%)
:arrow_up:

...asion/adversarial_patch/adversarial_patch_numpy.py
68.93% <0.00%> (+7.90%)
:arrow_up:

Hi @Embeddave Good idea, I have extended the test accordingly.

Hi @Embeddave Good idea, I have extended the test accordingly.


Explain the spread syntax used in pattern matching.

I’ll build this and fix any inevitable typos when I’m at a computer and it’s not 2am!

Ready to review?


font size differs from system font size

i checked through the .js, but nothing jumped out at me for the font sizing, so not sure how that is determined. I attached the screenshot, which I edited the .js to format it how I want it.

 Turns out the other font is smaller because of the settings in THAT extension. So I guess another feature request of allowing font size changing?


changes to do automated releases

Hi Rob,
This PR is still work in progress, but enough to get the review started.
It has following changes:

updated the version of go to 1.13
added go-releaser as part of circle-ci config
fixed the deprecated/removed go-releaser config files
added krew-release-bot to circle-ci config

TODO:

release new version of krew-release-bot with circle-ci support (pending review)
update this PR with new version of krew-release-bot

I am going to close the other 2 PR in favor of this one.
Thanks
Rajat Jindal

Hi @robscott
Thanks for letting me put up this PR. While doing this PR, I've added support for circle-ci and travis-ci to krew-release-bot and released new version for the same.
This PR is now ready for review.
can't wait to see this getting merged.
Thanks
Rajat Jindal

Hey @rajatjindal, this is awesome, thanks! What kind of env vars/config would I need to add to CircleCI for this to work?

I dont think you need any new env vars or config. It should just work. I will be more than happy to debug if we run into issues (i did tested it while opening the PR)

Sounds great, thanks so much for all your work on this!


Notebook cells are showing empty sometimes after reopening

Type: Bug
After running a SQL query, the notebook usually saves the resultset.
After re-opening the notebook, the dataset sometimes is blank. I can export the results to a csv file and they are there, but they aren't showing the the cell.
Azure Data Studio version: azuredatastudio 1.44.1 (8f53a316fa00a98264f1ab119641cd540b5af25c, 2023-06-01T02:12:48.765Z)
OS version: Windows_NT x64 10.0.14393
Restricted Mode: No
Preview Features: Enabled
Modes:

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz (4 x 2600)

GPU Status
2d_canvas: unavailable_softwarecanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: disabled_softwaremultiple_raster_threads: enabled_onopengl: disabled_offrasterization: disabled_softwareraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: disabled_softwarevideo_encode: disabled_softwarevulkan: disabled_offwebgl: unavailable_softwarewebgl2: unavailable_softwarewebgpu: disabled_off

Load (avg)
undefined

Memory (System)
12.00GB (5.92GB free)

Process Argv

Screen Reader
no

VM
100%

Extensions (12)

Extension
Author (truncated)
Version

admin-pack
Mic
0.0.2

admin-tool-ext-win
Mic
0.1.2

agent
Mic
0.49.0

dacpac
Mic
1.13.0

import
Mic
1.5.5

profiler
Mic
0.12.2

query-history
Mic
0.5.3

schema-compare
Mic
1.19.0

server-report
Mic
0.2.4

sql-assessment
Mic
0.6.4

whoisactive
Mic
0.1.5

sql-prompt
Red
0.2.12

Closing due to no response, if you see this again please attach the logs as requested and we can investigate further!
If you're able to attach the original notebook that had the issue as well that might help us repro the issue.


Clear the CURL_GLOBAL_SSL bit on curl initialization.

This was breaking OpenSSL setup. Since oslogin does not use SSL while
communicating with the metadata server, we can clear this bit on
initialization.

Can you add fixed #562 to the PR description?


reorganize file structure for multimodel files

In GitLab by @luitjansl on Oct 25, 2023, 18:55
About the file name and the project structure, at the moment basically everything that is in the imod/mf6 folder is related to a MODFLOW6 package or component. Lately we are developing components that don't have a direct one-to-one relation to a MODFLOW6 component. The same applies to this postprocessing class (as well as to the exchange_creators). We could keep those kind of classes in a separate folder. That way the mf6 folder better mimics the MODFLOW6 structure and we have a bit more freedom and control developing our own components. Furthermore the naming of this file can be simplified to just postprocessing because the namespace it will belong to makes it clear that is about partitioning postprocessing
imod/
├─ interfaces/
├─ out/
├─ utilities/
├─ multimodel/
│  ├─ exchange_creator.py
│  ├─ exchange_creator_structured.py
│  ├─ exchange_creator_unstructured.py
│  ├─ postprocessing.py <- this file
├─ __init__.py
├─ adv.py
├─ buy.py
├─ etc

In GitLab by @luitjansl on Nov 30, 2023, 15:45
mentioned in commit a89b66e3ea1354b12f5134a5a388ce9b2f318ae3


Release EDI Tool

Description:
$subject
Describe your task(s)
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

As it's completed


minLimit/maxLimit bugged for draggableRange

Steps to reproduce

use minLimit and draggableRange set to true

Demo: http://jsfiddle.net/hwze66k0/
Expected behaviour
range cannot go under minLimit or maxLimit
Actual behaviour
range can go under minLimit or maxLimit

reported in #382


Fix a README.md typo

Sorry for the noise, just happened to notice this, hope you don't mind.

Thanks a lot!


*: add tip in contributing.md

Signed-off-by: jackwener<EMAIL_ADDRESS>
What is changed and how it works?

Issue Number: Close #xxx
What's Changed:
polish contributing.md

Related changes
None
Check List

No code

Side effects
None
Release note
None

@sticnarf thanks for your review, I have fixed it.

@jackwener Each pull request is required to be linked to an issue. Can you create an enhancement issue and link it to this PR?

😀It's ok.

/merge


fix: hide workspace menu when user has delete permission but there are applications in workspace

Description
Delete workspace should only be visible if the workspace has no applications. So even when the user has delete permission on the workspace, we should hide the context menu trigger, since the actual delete option will only be visible if the user has delete permission && application length is 0.
Fixes #18929
Media
https://www.loom.com/share/95e33c3806774d60bbb8e56fae47fd76
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

/ok-to-test sha=519d71b

/ok-to-test sha=6e9faed


ScrollDirection and BlockDirection confusion

 Issue by Hixie
Thursday Aug 27, 2015 at 17:12 GMT
Originally opened as https://github.com/flutter/engine/issues/888

Right now scrollables use ScrollDirection and they're backed by render objects that use BlockDirection. However, that means ScrollDirection.both has no good mapping.
We should clean this up. I think we should probably still have two enums, one with "horizontal" and "vertical" and one with "horizontal", "vertical", and "both", but we should not split it across Block vs Scroll, instead of should split it according to who supports "both" and who doesn't.

 Comment by Hixie
Tuesday Sep 15, 2015 at 17:58 GMT

Briefly looked at this with @collinjackson. Scrollable right now asserts that you don't use "both". RenderViewport supports "both", nobody else seems to. We probably want a Widget to wrap RenderViewport with fling gesture support that does both, but other than that we should probably not have any use of the enum with "both".

Happy to fix this issue, but I'm not clear what we want.  Here's a guess:

Scrollable should use an enum with just two values (horizontal and vertical)
Scrollable and RenderBlock should use the same enum
Viewport should use a different enum with three values

Questions:

ScrollDirection is a nice name that makes sense for Scrollable.  Should we use that name for RenderBlock too even though RenderBlocks aren't necessarily related to scrolling?
What should we call the enum with three values (horizontal, vertical, both) that Viewport uses?

Axisand MultiAxis?

Should we still merge ScrollDirection and BlockDirection into a single enum?

Sorry, didn't mean to close this issue.  Yes, we still need to delete BlockDirection.

Looking at https://github.com/abarth/flutter/commit/4246237b693f50268b93708379740b2facd78a2f (from PR #1074), I really think we should just use "Axis" as the enum name.

Makes sense.

Oh GitHub, you mean well...


chore: align bignumber formats (decimal separator) with Intl

Add BigNumber.config to bootstrap and set it according to the current user's locale (decimal separator, etc.)

Need to get more clarity on this requirement from Art


Inline debugger for jupyter notebook %debug

When working in a jupyter notebook inside a web browser, if you use %debug in a cell following an error you get an inline debugger which makes it easy to follow the different debugging steps and corresponding code. When using %debug in a jupyter notebook opened with vscode, the debugger command line appears at the top, which makes it harder to follow the different steps and what you are doing.

/extJupyter


Event for webchat control pageload

Could not figure out the event the bot server receives on the webchat control load on the page, so that the bot can send an initial greeting message.
Is there an event that gets triggered on load of webchat component on the webpage?

See the "Get Members of a Conversation" example in https://github.com/Microsoft/BotBuilder-samples


[4.0] GSB] Stop creating unresolved potential archetypes.

Explanation: Stop creating "unresolved" potential archetypes in the GenericSignatureBuilder, which eliminates an class of invalid states that led to crashes in the GenericSignatureBuilder.
Scope: This change will affect all generic code. It will make us reject (rather than crash on) some invalid code (the awfully opaque SR-2796 crasher is one such example), provide better typo corrections for some invalid code using generics, but otherwise should not actually change the externally-visible behavior of any well-formed code.
Radar: SR-2796 / rdar://problem/28544316
Risk: Moderately low. It's a significant change to the GenericSignatureBuilder, which is where the risk comes from because it's so ubiquitous. On the other hand, the GenericSignatureBuilder is fairly well tested, and we've simplified the code considerably with this change, so I suspect it's less likely to actually fail in the real world after this change.
Testing: Compiler regression tests.

@swift-ci please test

@swift-ci please test

@swift-ci please test

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - f9403cdb993e317c4ef4240ef7d6a30ebf2a49e1
Test requested by - @DougGregor

@swift-ci please test

@huonw, now that you've review this, how you do personally feel about the risk/reward here?


webpack hmr react-router exception server-side in production mode

Steps to reproduce, following http://blog.stevensanderson.com/2016/05/02/angular2-react-knockout-apps-on-aspnet-core/

yo aspnetcore-spa  (using version 0.3.4)
Choose the React redux template
set ASPNETCORE_ENVIRONMENT=Production
webpack --config webpack.config.vendor.js
webpack
dotnet run
Fetch http://localhost:5000 from a webbrowser

This will result in the following server-side exception:
fail: Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware[0]
      An unhandled exception has occurred: Call to Node module failed with error: Error: The location '/__webpack_hmr' doesn't match any route configured in react-router.
at ClientApp\boot-server.js:1:802

How can I prevent this? Why is Webpack Hot Module Replacement kicking off in production mode - at least server-side?

I think you just have some other development-mode browser tab still running that's trying to connect to /__webpack_hmr. So it's nothing to do with your production app :)
If this turns out to be wrong and you can confirm the issue is something else, please reopen with details.


Missing search parameter Organization::address-department

Description du problème
There is no way to search for Organizations within a certain department. Of course "address-postalcode:contains" could be used but this produces false positive results.
Fichier•s concerné•s
Solution proposée
Please provide the search parameter address-department consuming the department code value.

That would be nice!
@der-brecher have you got any FHIR-compliant suggestion to manage that ?
I have some suggestions but don't think it is really satisfying :

Creating a custom search param
Creating an extension with only the department code

@nriss I can image a custom search parameter. Maybe the search parameter can be a very simple token search parameter on extensions retuning the codeableConcept for which it has to be used by the client via "in" search modifier as described here: https://build.fhir.org/search.html#modifierin
But the most convenient way for the client is surely a custom search parameter which returns the department code as string.

I already thought about using the 'in' or the 'below' modifier, but it imposes managing ValueSets.
I think creating a custom SP is the best option, what do you think @mchaabaoui ? Can you see what the developers think about that ?


Got 'CSRF verification failed. Request aborted.' when accessing admin panel after docker deployment

I use docker-compose.yml to deploy this project, I only change the client port from 80 to 10080 as my 80 is already in used.
    ports:
      - '10080:80'

After run docker-compose.yml, I use my browser to access the admin panel from remote(not localhost). Then I got 'CSRF verification failed. Request aborted' after login with username and password.

My deployment results were the same, and I had to add the host address here to make it work.

Yes, after changed to my real ip in APP_DOMAIN, it fixed. Would you like to update README to clarify this?


Issue Failed to retrieve data for VIN  Status Code was: 403

Hello,
I am currently using version v0.8.4 of Cupraconnect and HA 14.0. The Cupra WeConnect integration is running successfully, and I have already managed to connect my vehicle. However, for several days, the entities have been showing errors.
I have restarted the installation from the beginning, but I still cannot load the entities. The logs show the following error (I have masked my VIN).
" Failed to retrieve data for VIN VSSZZZXXXXXXXXXXX: Could not fetch data. Status Code was: 403 "
I have logged into my CupraOfficial account and accepted all the authorizations, but there has been no improvement in updating the entities.
Has anyone encountered this problem before? What can be done to solve it?
Thank you for your help.

Hello,
The problem solved itself!
Probably a problem with the Cupra server
Have fun

Not for me for the moment... 😢
I try to reinstall, reconfigure... always 403.
But the MyCupra App work fine.


chinese not work

i cant use in China，what is the auth inChina？

![Uploading $%]Y%CBS1}RH{HB9MD58D1B.png…]()
how to fix this address

Use auth.tesla.cn instead.

Use auth.tesla.cn instead.

i have a try,but it not work.


App is not syncing properly

I was finally able to get the update to download and sync. This took a long long time. However, I cannot see any of my investments. When I go to https://www.defichain-income.com/ I can see all my investments there, but when I open the app none of them are there and the app is on the nonresponsive side. What do I do? I really want access to my investments.
app logs.zip
.

Hi @pasotrjim31 , may I know what OS are you using? Is your app synced to 100%?

Hi @pasotrjim31 , yes the ~0.04% more to sync is expected since the blockchain is growing daily. Can you check that your timezone on your PC is set automatically to the current time? When it syncs to 100% does your balances appear?

OK! So, I hit the rescan button and it found all the missing addresses.
I have a new problem now. The system won't load my dex, liquidity pairs (to add or remove), or see transactions.
What is happening with that?
Would you like me to send a new set of logs?

Hi @pasotrjim31 , can you take a screenshot of the DEX screen? What are your environment parameters?

DeFi Wallet Version:
Operating System (OS): macOS Big Sur 11.6
Current free storage capacity:

Did you finds a solution, because I have the same expiriense with 2.6.5. on Mac OS 11.6

Another problem: The app sync has been stalled for a while... It has been stuck at 99.95% complete

Hi @pasotrjim31 , can you save & send me your app logs again for further investigation please. Thank you.

Hi @pasotrjim31 , may I know what RAM are you operating with of your Mac? Could you a screenshot of your CPU usage?

Getting both for you right now

app logs.log.zip

The app is finally sync - but there isn't any of my pools showing nor is there any of my tokens showing.
The pic on the right is my holdings and shows you that it is still reading that the holdings are within my wallet even though the wallet doesn't show it
How do we fix this?

Hi @pasotrjim31 , please give us time to investigate. What you could do is backup your wallet.dat, and perhaps clear some memory in your Mac.

Hi @pasotrjim31 , in the mean time, can you double check in your defi.conf that;
spv=0
gen=0

If it's not, change it to 0 and save the file. Do not move the defi.conf out of it's original folder.
——————————————
To find the defi.conf on Mac, Go to Folder and search:
/Users/username/Library/Application Support/DeFi/.defi/

They both were on 0 - I doubled checked them :)

@pasotrjim31 can you try to type rpc gettokenbalances in the console from app (once synced to 100%)? And share the screenshot here

I pulled up what you mentioned, but the first one didn't work. The second (minus the rpc) did. The bottom pic in black is from the Defichain website that tracks the wallet. I had set that up before the problems with the wallet.  The last two days I have tried to remove myself from the liquidity pool and try to dex my holdings so I can move them to the cake site .... I believe I tried 4 different times ... none of them worked. ...

@pasotrjim31 ok thanks for that. It seems that the issue is on display side since you have your balances just not displayed. Don't worry, your funds are safe. We'll release a test build later today, I'll let you know so you can check your funds there. Will keep you posted

Hi @pasotrjim31 , update v2.7.0 is out, this is a mandatory update. Kindly backup wallet before updating.
Please read through the release notes before updating. This comment is to notify you about the update.

Hey! I updated to 2.7
Still unable to remove liquidity, dex, or anything ... It showed some numbers then all of a sudden went to all 0's again :(

Hi @pasotrjim31 , update v2.7.1 is out, this is a mandatory update. Kindly backup wallet before updating.
 Please read through the release notes before updating. This comment is to notify you about the update.

Everything is updated and it is all showing as 0's ... Also, it shows 0 pairs ... :(

Hi @pasotrjim31 , can you try updating to v2.7.2?

Let me get that for you

Hi @pasotrjim31 , thanks for the screenshot, the latest version currently is v2.7.3. Can you try to update and see if you balances appear, I'm suspecting that it's due to hardware incompatibility with the desktop app; another user faced a similar issue: https://github.com/DeFiCh/app/issues/1053. If updating still does not work, you might need a better Mac. If updating to v2.7.3 works, I would suggest for you to download DeFiChain Light Wallet on mobile, create wallet, transfer funds from desktop app to Light Wallet (since the 2 applications are built differently, you won't be able to use the same restore wallet method from desktop app on mobile app).

Currently, I am trying to sync version 2.7.3
I will let you know if they appear.
However, I have a few questions

I will save my wallet.dat  Thank you for that advice

I downloaded the Light Wallet on my phone.  When I hit restore wallet, it asks me for the seed phrase - however, when I first opened the desktop wallet a year or so ago I was never given a seed phrase. I was only asked to create a sign-in password (which I did).

Is there a way to create a seed phrase for this wallet now? So I can transfer the funds.
In the app store there are two wallets - The first is the one requiring the seed thing
The second is saiive.live Defichain Wallet (Defichain Light Wallet) ...
Which one is correct?

Hi @pasotrjim31 , the latest version would be v2.8.1, you'll likely face syncing issues if you're on 2.7.3.
Regarding 2. the desktop app & mobile Light Wallet are not correlated when restoring wallet. Here's how you can transfer from desktop to mobile:

Download DeFiChain Wallet on the App Store / Play Store
Create Wallet
The mobile app will generate 24 recovery words (please write it down and keep it safe) & 6 digit pin for transactions purposes.
Once your wallet is set up on mobile, you can send from desktop app to your mobile app using the DeFiChain address which you have

Should you face any issues on DeFiChain Light Wallet, you mat post them here: https://github.com/DeFiCh/wallet/issues
Saiive.live is an application created by the community, you may choose to use theirs if you prefer. However, if you face issues regarding their application, you'll have to ask them instead.

Hi @pasotrjim31 , update v2.13.0 is out, this is a mandatory update. Kindly backup wallet and read through the release notes before updating. I'll be closing this issue in the mean time. You may reopen this issue if there's new information (include screenshots) and your app logs. Thank you.


Display Data in Datagrid

i have a model that looks like almost like this (it's a simplified version of the real one):
using System;

namespace PTSample
{
    public class Person
    {
        public Person(string name) { Name = name; }
        public string Name { get; set; }
    }

    public class Lesson
    {
        public Lesson(DateTime date) { this.Date = date; }
        public DateTime Date { get; set; }
    }

    public class Presence
    {
        public Presence(Person p, Lesson l, bool v)
        {
            Person = p;
            Lesson = l;
            Value = v;
        }

        public Person Person { get; set; }
        public Lesson Lesson { get; set; }
        public bool Value { get; set; }
    }
}

i would like to display this model using the Datagrid from this toolkit making it look like this

So that the row shows the the person, the lessons are displayed in the columsn and the boolen "Value" is shown in a checkbox
is this possible?

I just created https://gitter.im/objorke/PropertyTools, please ask questions there :-)
Or reformulate the question to a feature request :-)
(The issues section should only be used for bug reports and feature requests.)
A quick answer: the DataGrid can be bound to lists, and lists of lists (see the examples!). I think you need to change your model to a "list of lists".
Can we close this issue?


Filtering Data of numerical field in Data-View doesn't work properly because of thousend seperator

System information:

Debian Linux Buster (10)
Dbeaver: 6.1.0
Java version: 1.11-71

Connection specification:

Database name and version
Postgresql 11+200+deb10u1
Driver name
PostgreSQL
Do you use tunnels or proxies (SSH, SOCKS, etc)?
No

Describe the problem you're observing:
When opening the data-view of a Table and then Clicking on the Filtering Symbol of a numerical Column, I can enter the number I want to filter for by keyboard, it will jump in the list of all the available numbers to the correct number. But if the number has more than 3 Figures, it doesn't work. Because of the thousend seperator with which the numer is display. When I enter the number WITH the thousand seperator i.e. '1.234' instead of '1234', then it does find the proper number
Steps to reproduce, if exist:
See above

Numeric columns mist be filtered as numbers. No groupings are needed for that.
Thanks for the bug report, see fix in the next version.

verified


update to Cascading 2.7.0

This updates Cascading to 2.7.0, which is fully backwards compatible with 2.5.x, but contains all the latest bugfixes and a few new features.
You can find the full list of Changes here: https://github.com/Cascading/cascading/blob/2.7/CHANGES.txt

NetflixOSS » PigPen » PigPen-pull-requests #9 SUCCESS
This pull request looks good


[ENH] Adds permutation tests for correlations

Works well with stats.gen_spinsamples! Once this is done I'll work on updating that example.
To Do:

[ ] Add tests for new / modified nntools.stats functions
[ ] Add some examples to the gallery highlighting functionality?

Codecov Report

Merging #49 into master will increase coverage by 2.13%.
The diff coverage is 91.81%.

@@            Coverage Diff            @@
##           master     #49      +/-   ##
=========================================
+ Coverage   61.36%   63.5%   +2.13%
=========================================
  Files          21      21
  Lines        1113    1200      +87
=========================================
+ Hits          683     762      +79
- Misses        430     438       +8

Impacted Files
Coverage Δ

netneurotools/tests/test_stats.py
100% <100%> (ø)
:arrow_up:

netneurotools/stats.py
83.73% <86.56%> (-0.57%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bcfe7c...f2501bf. Read the comment docs.


feat: new text embedding for sparse vector

Part of #459

Changed svector text representation from "[0, 1, 0, 3, 4]" to pgvector-style "{2:1, 4:3, 5:4}/5"
Upgraded toolchain for new feature proc_macro_byte_character from upstream

Reminder
The index is from 1 instead of 0 at pgvector

Old
New

[0, 1, 2, 0, 0]
{1:1, 2:2}/5

[0, 1, 2, 3, 4, 5, 6, 7]
{1:1, 2:2, 3:3, 4:4, 5:5, 6:6, 7:7}/8

[5, 6, 7]
{0:5, 1:6, 2:7}/3

[0, 0, 0, 0]
{}/4

The failed CI is due to an upstream uncompatiablity:

proc-macro2 v1.0.80 introduced proc_macro_byte_character feature, which is recently stablized
The compiler of Github Action is built at 2024-03-26

We could wait for one of:

Upgrade of compiler to 2024-04-xx
The upstream fix their dependencies proc-macro2 to v1.0.79 like

The reason why CI fails is that sqllogictest-bin released on crates.io but not on GitHub a few days before. We do not have to update the toolchain.

Let's hold this PR for now, due to the conflict between 1-based array and 0-based array

This is used to support bm25 extension. It can produce string instead of depending on pgvecto.rs/pgvector. cc @cutecutecat

What about {}/1/2?

Fixed.

{1,2,3,4}/5 gives incorrect message:
    OutOfBound {
        dims: 5,
        index:<PHONE_NUMBER>,
    },

{1:1,2:2,}/5 tailing commas are not accepted, but it should be

graph LR
1[Start] -->|Left Bracket| 2[LeftBracket]
2[LeftBracket] -->|Number
backspace| 3[Index]
2[LeftBracket] -->|Right Bracket| 4[Splitter]
3[Index] -->|Number
push token| 3[Index]
3[Index] -->|Colon
collect token| 5[Value]
5[Value] -->|Number
push token| 5[Value]
5[Value] -->|Comma
collect token| 6[Comma]
5[Value] -->|Right Bracket| 4[Splitter]
6[Comma] -->|Number
backspace| 3[Index]
6[Comma] -->|Right Bracket| 4[Splitter]
4[Splitter] -->|"/"| 7[Length]
7[Length] -->|Number
push token| 7[Length]
7[Length] -->|Input end| 8(Break Loop
collect token)

dims == 0 or dims >= 2 ** 20 is not checked. Duplicated dimension is not checked. value[i] == 0 is not processed.

value[i] == 0 is not processed.

Please get this merge today, thanks


"ADDJOB" returns a redis status reply, which gets turned into a ruby symbol.

Have just played around with disque, "ADDJOB" returns a redis status reply which gets turned into a ruby symbol. Symbols are not garbage collected in mruby so it allocates memory till nothing is left when this gem is used for a long time :/

@Asmod4n Yes. So should we change the mrb_value type in src/mrb_redis.c?

@matsumoto-r
Maybe it's time to add symbol GC to mruby, a change to mrb_str_new should work till then but will break tests and the API.


Change dm_control version in requirements.txt.

The issues described in #8 have been resolved in dm_control 1.0.7. The versions of mujoco and protobuf have also been bumped accordingly.

I'm going to close this PR since I require further approvals to contribute to Microsoft's repositories. Since this is a trivial change, it'll be easier for you to just do it on your end.

No worries, I already had a version bump planned. Thanks for all of your help!


cob_driver: 0.7.15-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository cob_driver to 0.7.15-1:

upstream repository: https://github.com/ipa320/cob_driver.git
release repository: https://github.com/ipa320/cob_driver-release.git
distro file: noetic/distribution.yaml
bloom version: 0.11.2
previous version for package: 0.7.14-1

cob_base_drive_chain

No changes

cob_bms_driver

No changes

cob_canopen_motor

No changes

cob_driver

No changes

cob_elmo_homing

No changes

cob_generic_can

No changes

cob_light
* Merge pull request #441 <https://github.com/ipa320/cob_driver/issues/441> from muritane/motion_monitor
  [motion_monitor] adjust turn indicator
* [motion_monitor] reverse led quarters for left and right turn indication
* [motion_monitor] add comments which leds are used for left and right turn
* [motion_monitor] change turn indicator to flash
* Contributors: Benjamin Maidel, Daniel Azanov

cob_mimic

No changes

cob_phidget_em_state

No changes

cob_phidget_power_state

No changes

cob_phidgets

No changes

cob_relayboard

No changes

cob_scan_unifier
* Merge pull request #440 <https://github.com/ipa320/cob_driver/issues/440> from benmaidel/feature/angle_increment_independend
  remove hardcoded angle_increment value
* make cob_scan_unifier angle_increment independet by using the info from the input scan
* Contributors: Benjamin Maidel

cob_sick_lms1xx

No changes

cob_sick_s300

No changes

cob_sound

No changes

cob_undercarriage_ctrl

No changes

cob_utilities

No changes

cob_voltage_control

No changes

laser_scan_densifier

No changes

Holding for Noetic sync

This pull request has been mentioned on ROS Discourse. There might be relevant details there:
https://discourse.ros.org/t/preparing-for-noetic-sync-2023-11-09/34547/2


New version: CloudImperiumGames.RSILauncher version 2.0.1

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Is there a linked Issue? closes #158461

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@stephengillie

https://github.com/microsoft/winget-pkgs/issues/142854


[BUG] org.opensearch.index.reindex.ReindexRestClientSslTests#testClientSucceedsWithCertificateAuthorities - javax.net.ssl.SSLPeerUnverifiedException

Describe the bug
Test assume that host name returned for <IP_ADDRESS> will be one of the Subject alternative names.
But due to Windows 10, Docker + Kubernetes, host name returned for <IP_ADDRESS> might be 'kubernetes.docker.internal'
To Reproduce
Steps to reproduce the behavior:

Windows 10, Docker desktop and kubernetes enabled.
Run test

Expected behavior
That the test would only use one of the subject alternative names since it's required for the test to pass.
Host/Environment (please complete the following information):

OS: Windows
Version 10

Additional context
Docker Desktop with Kubernetes enabled
Since both IP address for localhost (ipv4(<IP_ADDRESS>) and ipv6(0:0:0:0:0:0:0:1)) are subject alt names, java.net.InetAddress#getHostAddress could probably be used instead of java.net.InetSocketAddress#getHostName
Exception thrown:
org.opensearch.index.reindex.ReindexRestClientSslTests > testClientSucceedsWithCertificateAuthorities FAILED
    java.io.IOException: Host name 'kubernetes.docker.internal' does not match the certificate subject provided by the peer (CN=http)
        at __randomizedtesting.SeedInfo.seed([6594F1A74C93240B:C2C43EFC3F989FE6]:0)
        at org.opensearch.client.RestClient.extractAndWrapCause(RestClient.java:897)
        at org.opensearch.client.RestClient.performRequest(RestClient.java:296)
        at org.opensearch.client.RestClient.performRequest(RestClient.java:283)
        at org.opensearch.index.reindex.ReindexRestClientSslTests.testClientSucceedsWithCertificateAuthorities(ReindexRestClientSslTests.java:157)

        Caused by:
        javax.net.ssl.SSLPeerUnverifiedException: Host name 'kubernetes.docker.internal' does not match the certificate subject provided by the peer (CN=http)
            at org.apache.http.nio.conn.ssl.SSLIOSessionStrategy.verifySession(SSLIOSessionStrategy.java:209)
            at org.apache.http.nio.conn.ssl.SSLIOSessionStrategy$1.verify(SSLIOSessionStrategy.java:188)
            at org.apache.http.nio.reactor.ssl.SSLIOSession.doHandshake(SSLIOSession.java:360)
            at org.apache.http.nio.reactor.ssl.SSLIOSession.isAppInputReady(SSLIOSession.java:523)
            at org.apache.http.impl.nio.reactor.AbstractIODispatch.inputReady(AbstractIODispatch.java:120)
            at org.apache.http.impl.nio.reactor.BaseIOReactor.readable(BaseIOReactor.java:162)
            at org.apache.http.impl.nio.reactor.AbstractIOReactor.processEvent(AbstractIOReactor.java:337)
            at org.apache.http.impl.nio.reactor.AbstractIOReactor.processEvents(AbstractIOReactor.java:315)
            at org.apache.http.impl.nio.reactor.AbstractIOReactor.execute(AbstractIOReactor.java:276)
            at org.apache.http.impl.nio.reactor.BaseIOReactor.execute(BaseIOReactor.java:104)
            at org.apache.http.impl.nio.reactor.AbstractMultiworkerIOReactor$Worker.run(AbstractMultiworkerIOReactor.java:591)
            at java.base/java.lang.Thread.run(Thread.java:832)

Hi @npetzall, shouldn't this work by having a dns entry for host name kubernetes.docker.internal in docker/kubernetes equivalent of /etc/hosts? Seems to me more like a docker issue than opensearch. I see similar problems reported on docker project here

@setiah sorry if I'm not clear in the issue. The test in OpenSearch starts a https server on localhost with ssl certificates with dns names like localhost, <IP_ADDRESS>. The the test creates a client, which with the current implementation, does a reverse lookup of <IP_ADDRESS> which is kubernetes.docker.internal. Tries to connect to kubernetes.docker.internal and the exception is thrown in ssl verification which says kubernetes.docker.internal is not part of the ssl certificate of the https server.
Any host which has entry in etc/host for <IP_ADDRESS> that isn't localhost or one of the subject alt names in the certificate will get a failed test. I generalize here a bit any host that receives something other than localhost in <IP_ADDRESS> reverse lookup will fail.
So the problem is that I have and need to have kubernetes.docker.internal in my host-file.
I can add a second entry for localhost after the kubernetes.docker.internal but I say it's bad practice to modify hosts-files and a messy additional step when clearly setting up a server with certificates for localhost and connecting with a different name is bound to fail.

Thanks for the details @npetzall - this makes it clear.

I can add a second entry for localhost after the kubernetes.docker.internal but I say it's bad practice to modify hosts-files

Agree, it should not be done.

Since both IP address for localhost (ipv4(<IP_ADDRESS>) and ipv6(0:0:0:0:0:0:0:1)) are subject alt names, java.net.InetAddress#getHostAddress could probably be used instead of java.net.InetSocketAddress#getHostName

Your suggestion looks good to me, but i'm not sure if localhost IPs are by default included in SANs (are they?). If not we might need to add them.
Also these test certificates should be rotated IMO (not urgent though), as they are coming from legacy elasticsearch codebase. (cc: @nknize )

@setiah certificate used in the test modules/reindex/src/test/resources/org/opensearch/index/reindex/http/http.crt
Common Name: http
Subject Alternative Names: localhost, localhost6.localdomain6, IP Address:<IP_ADDRESS>, IP Address:0:0:0:0:0:0:0:1 , localhost4, localhost6, localhost.localdomain, localhost4.localdomain4
Valid From: January 9, 2019
Valid To: May 26, 2046
Serial Number: 5f1960ff4fe0dd461e91758146990733ce0461f2
I would say that having localhost in certificates is not practical except when testing/developing. There might be an edge case for it. But it's not added by default in any of the PKI software that I've seen, but I've seen few such systems.

I would say that having localhost in certificates is not practical except when testing/developing.

Agree, since it is only for testing, it should be fine.

Common Name: http
Subject Alternative Names: localhost, localhost6.localdomain6, IP Address:<IP_ADDRESS>, IP Address:0:0:0:0:0:0:0:1 , localhost4, localhost6, localhost.localdomain, localhost4.localdomain4
Valid From: January 9, 2019
Valid To: May 26, 2046
Serial Number: 5f1960ff4fe0dd461e91758146990733ce0461f2

Could you please share the source of this information?
The proposal looks good to me. Happy to review if you would like to raise a PR?

@setiah  You can copy the cert information found in modules/reindex/src/test/resources/org/opensearch/index/reindex/http/http.crt
And use an online decoder like https://comodosslstore.com/ssltools/cert-decoder.php

@npetzall ah nice. I was doing the b64decode of the content earlier, which did return partial information with some garbled content. This is useful, thanks.

@dblock I think we could close this one, thank you!

Thanks for your excellent work @reta!


Issue for uploading images

Want to use an image inside the Wiki? Paste it here, and copy the link and use it there.


Remote File SD

Proposal
Hej,
analogue to the file_sd_config, I would like to implement a remote_file_sd_config option, which allows the scrape target configuration file to be stored on a remote server.
Various transport protocols (like HTTP, FTP, etc.) should be supported and derived from the URI. The file's format would be the same as for file_sd_config.
Shall I extend the existing file_sd code to handle URI that start with http(s):// or shall I rather implement a new remote_file_sd option?
Use Cases
This allows for simple and generic integration into other software. For example, a Prometheus instance could query:

an HTTP API of a CPE provisioning tool at regular intervals for a list of devices
Netbox for a list of devices (would require another pull request on netbox once this feature is implemented for prometheus).

What are your thoughts on this? Shall I go ahead and make a proposal by creating a PR?

This has been discussed in the past.
Closing as dupe of https://github.com/prometheus/prometheus/issues/2514 https://github.com/prometheus/prometheus/issues/7371 https://github.com/prometheus/prometheus/pull/4390
You can read the resons in the mentioned threads.

While I appreciate that this has been discussed often before, but maybe that’s a sign that this is a feature that many people actually want and need?
In any event, I’d like to provide a little bit more reasoning why this might be a good idea. If your heart is set that there are no good reasons to consider something like this feature, feel free not to read it. (I won’t be mad if I don’t receive any replies! Promise!)
Sure, you can do many things to work around this, like curl and wget. You could also do such workarounds for other, “supported” services, though, by just writing a “small“ worker that compiles file_sd_configs from those services. You normally don’t want to do this, because having a service (or many tiny helpers) for configuration management on top of prometheus feels like a massive anti-pattern, and it’s the kind of undocumented received wisdom I’d like to avoid.
I don’t think “there should be one way of doing things” as an argument trumps very much, and it certainly doesn’t trump "but this means that we have to work around the tool to get what we want”. I’m all for considering the æsthetics of the interface (and I appreciate hwo keeping it small helps robustness), but if that leads to people having to do the same clumsy workaround over and over again, maybe it doesn’t capture the intent properly or fully, and it might be time to reconsider.

This is being implemented in #8839


vcpkg doesn't handle multi-level dependencies properly?

Following command always fails for me (CentOS 7) on clean instance of vcpkg:
git reset --hard 2112801abafbc0778f441bec6bce237c7eced31c
./vcpkg install zlib nlohmann-json curl cpprestsdk[core] azure-storage-cpp aws-sdk-cpp[core,s3] cxxopts

on package 77/98: cpprestsdk:x64-linux step. Related log complains about missing boost/asio/ssl.hpp:
<blah-blah>
FAILED: src/CMakeFiles/cpprest.dir/http/client/http_client_msg.cpp.o
/opt/rh/devtoolset-8/root/usr/bin/c++  -DCPPREST_EXCLUDE_BROTLI=1 -DCPPREST_EXCLUDE_WEBSOCKETS=1 -DCPPREST_FORCE_HTTP_CLIENT_ASIO -DCPPREST_FORCE_HTTP_LISTENER_ASIO -I/home/user/vcpkg-test/buildtrees/cpprestsdk/src/v2.10.12-ef9db571b9/Release/include -I/home/user/vcpkg-test/buildtrees/cpprestsdk/src/v2.10.12-ef9db571b9/Release/src/pch -isystem /home/user/vcpkg-test/installed/x64-linux/include -fPIC -std=c++11 -fno-strict-aliasing -g   -pedantic -Wall -Wextra -Wunused-parameter -Wcast-align -Wcast-qual -Wconversion -Wformat=2 -Winit-self -Winvalid-pch -Wmissing-format-attribute -Wmissing-include-dirs -Wpacked -Wredundant-decls -Wunreachable-code -MD -MT src/CMakeFiles/cpprest.dir/http/client/http_client_msg.cpp.o -MF src/CMakeFiles/cpprest.dir/http/client/http_client_msg.cpp.o.d -o src/CMakeFiles/cpprest.dir/http/client/http_client_msg.cpp.o -c /home/user/vcpkg-test/buildtrees/cpprestsdk/src/v2.10.12-ef9db571b9/Release/src/http/client/http_client_msg.cpp
In file included from /home/user/vcpkg-test/buildtrees/cpprestsdk/src/v2.10.12-ef9db571b9/Release/src/pch/stdafx.h:101,
                 from /home/user/vcpkg-test/buildtrees/cpprestsdk/src/v2.10.12-ef9db571b9/Release/src/http/client/http_client_msg.cpp:13:
/home/user/vcpkg-test/buildtrees/cpprestsdk/src/v2.10.12-ef9db571b9/Release/include/cpprest/http_client.h:68:10: fatal error: boost/asio/ssl.hpp: No such file or directory
 #include "boost/asio/ssl.hpp"
          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.
<blah-blah>

which is weird, since according to my reading of CONTROL files cpprest depends on boost-log, which for some crazy reason depends on like entire boost, including boost-asio.

My bad, didn't read it closely enough -- cpprest is missing boost-asio dependency. I'll book another issue.


Create Solution_23.js

Pull Request Template
All Submissions:

[ ] Have you read and acknowledged our Code of Conduct?
[ ] Have you checked to ensure there aren't other open Pull Requests

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made relevant changes to the documentation
[ ] My changes generate no new warnings
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have checked my code and corrected any misspellings

review @akebu6


Allow passing orbctl create a NixOS configuration

OrbStack has great first-class NixOS support, and that's a kick-ass, standout feature. OrbStack also has support for automatically configuring new machines at time of orbctl create invocation via cloud-init's user-data. Unfortunately, OrbStack's NixOS image lacks cloud-init support. Additionally, cloud-init is a poor fit for automated NixOS configuration in that user-data is an imperative thing and NixOS is built around more comprehensive declarative configuration management anyway. This is perhaps why cloud-init is not supported for OrbStack's NixOS images (although you certainly can enable it; it's built into NixOS).
Describe the solution you'd like
It would be great to be able to pass orbctl create a NixOS config when creating a NixOS machine. OrbStack could do the following:

if the path passed ends in configuration.nix, call nixos-rebuild -I nixos-config=/path/to/configuration.nix or whatever
if the path passed ends in flake.nix, call nixos-rebuild switch --flake /path/to/flake.nix#<OrbStack machine name>
if the path passed ends in flake.nix#something, call nixos-rebuild switch --flake /path/to/flake.nix#something

Users can bind mount an appropriate path to /etc/nixos if they like inside their NixOS configurations, set NIX_PATH, etc., in their NixOS configurations if they like, so there's no need to do anything fancy with that here.
Describe alternatives you've considered
I've tried setting up a NixOS system via the orb command, which is not so bad but not so easily automatable

I would find this helpful as well.
I've been looking at where the default *.nix config template is stored.
I didn't see anything in the config folder .orbstack
example config generated orbstack.nix:
# Generated by OrbStack.
# This WILL be overwritten in the future. Make a copy and update the include
# in configuration.nix if you want to keep your changes.

{ lib, config, ... }:

{
  # Add OrbStack CLI tools to PATH
  environment.shellInit = ''
    . /opt/orbstack-guest/etc/profile-early

    # add your customizations here

    . /opt/orbstack-guest/etc/profile-late
  '';

  # Enable documentation
  documentation.man.enable = true;
  documentation.doc.enable = true;
  documentation.info.enable = true;

  # Disable systemd-resolved
  services.resolved.enable = false;
  environment.etc."resolv.conf".source = "/opt/orbstack-guest/etc/resolv.conf";

  # Faster DHCP - OrbStack uses SLAAC exclusively
  networking.dhcpcd.extraConfig = ''
    noarp
    noipv6
  '';

  # Disable sshd
  services.openssh.enable = false;

  # systemd
  systemd.services."systemd-oomd".serviceConfig.WatchdogSec = 0;
  systemd.services."systemd-userdbd".serviceConfig.WatchdogSec = 0;
  systemd.services."systemd-udevd".serviceConfig.WatchdogSec = 0;
  systemd.services."systemd-timesyncd".serviceConfig.WatchdogSec = 0;
  systemd.services."systemd-timedated".serviceConfig.WatchdogSec = 0;
  systemd.services."systemd-portabled".serviceConfig.WatchdogSec = 0;
<EMAIL_ADDRESS>= 0;
  systemd.services."systemd-machined".serviceConfig.WatchdogSec = 0;
  systemd.services."systemd-localed".serviceConfig.WatchdogSec = 0;
  systemd.services."systemd-logind".serviceConfig.WatchdogSec = 0;
<EMAIL_ADDRESS>= 0;
  systemd.services."systemd-journald".serviceConfig.WatchdogSec = 0;
  systemd.services."systemd-journal-remote".serviceConfig.WatchdogSec = 0;
  systemd.services."systemd-journal-upload".serviceConfig.WatchdogSec = 0;
  systemd.services."systemd-importd".serviceConfig.WatchdogSec = 0;
  systemd.services."systemd-hostnamed".serviceConfig.WatchdogSec = 0;
  systemd.services."systemd-homed".serviceConfig.WatchdogSec = 0;
  systemd.services."systemd-networkd".serviceConfig.WatchdogSec = lib.mkIf config.systemd.network.enable 0;

  # ssh config
  programs.ssh.extraConfig = ''
    Include /opt/orbstack-guest/etc/ssh_config
  '';

  # indicate builder support for emulated architectures
  nix.settings.extra-platforms = [
    "x86_64-linux"
    "i686-linux"
  ];
}

@therealpxc I ended up tackling this via a makefile gist
configureNixos:
        @echo "Running configuration on the VM using orbctl run..."
        $(orbctlPath) run sudo rm -f $(vmConfigDir)/configuration.nix
        $(orbctlPath) run sudo cp $(srcConfigDir)/* $(vmConfigDir)/
        @echo "Applying NixOS configuration..."
        $(orbctlPath) run sudo nix-channel --add https://github.com/nix-community/home-manager/archive/master.tar.gz home-manager
        $(orbctlPath) run sudo nix-channel --update
        $(orbctlPath) run sudo nixos-rebuild switch

Something I've been meaning to do since I refactored the OrbStack-specific configuration is to distribute that as a separate repo so you can add it as a flake input or similar, but it got lost in other things.
Would y'all find that helpful?

Definitely! I'd been syncing it manually which is way clunkier and basically untracked. Although I've customized it as well. For it to be truly useful that way it might have to make more use of lib.modules.mkDefault or one of the other mkOverride wrappers. With that in mind, sounds great!


netstat: Update VMI interface status report unit tests

What this PR does / why we need it:
The existing unit tests which cover the VMI interface status report is missing some realistic overall scenarios about the existing data available.
This change unifies and tries to place some rules on what is the expected data provided to the report processing.
The current netstat unit tests have been updated to reflect the
following expected behavior:

When regular interfaces are added, this is the expected state/input:

VMI spec interfaces and networks should be in sync with 1:1 relation.
Domain spec is expect to reflect the VMI spec, i.e. having the same
interfaces.
The filesystem cache should reflect the same interfaces as the VMI
spec.
The volatile cache is optional, reflecting the same interface.
The Guest Agent data is optional.

When SR-IOV interfaces are added, this is the expected state/input:

VMI spec interfaces and networks should be in sync with 1:1 relation.
The Guest Agent data is optional.
Notes: Caches do not exist and the domain spec interfaces do not
include the SR-IOV interfaces. These are under the hostdevice section.

Miscellaneous scenarios are also covered to reflect what happens when such cases occur. However, these are not expected to occur in a normal system operation. Future production changes may treat these scenarios explicitly to avoid undefined and nontrivial behavior.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Depends on #6926
Only the last 6 commits are to be reviewed as part of this PR.
Release note:
NONE

/uncc rmohr vladikr

/cc @maiqueb @AlonaKaplan @ormergi @oshoval

/sig network

change: Added misc test scenarios

change: Rebase

change: Rebase

Change: Answered review: Added a SR-IOV test to show what happens when it is accompanied with a "regular" interface.

/retest

change: Rebase

/test pull-kubevirt-e2e-kind-1.22-sriov

change: Rebase
The reabse required the inclusion of infoSource to the unit tests.

change: Answered review feedback.

/approve

/retest

/retest

/retest

/retest


Add DefaultInstrumented Trait

Addresses #79
My biggest question is whether DefaultInstrumented is the right name here. We could just call it Instrumented so that usage looks exactly the same as if you create your own, but that could cause some confusion.
Another possible name would be DropwizardInstrumented.

Ah. I think DefaultInstrumented is the right name. Firstly because the principle is not only applicable for DropWizard applications. Secondly, we indeed should not use the name Instrumented as it is used throughout the documentation for something else.

Is it necessary to validate that the registry already exists in DefaultInstrumented? If we can remove that check, using metrics-scala would become a lot easier, also for non-Dropwizard applications.

I am also beginning to doubt my previous stance about the name. Perhaps we should just call it Instrumented after all. If the registry check can be removed, it would function exactly as intended in the rest of the documentation.

@erikvanoosten existing projects typically call their trait providing instrumentation Instrumented. Please remember that introducing a Instrumented trait into metrics-scala can cause some confusion for existing users.
Let me throw in another name idea GlobalInstrumented. It's globally defined, uses a shared global state.

At first I was thinking that putting Instrumented in a different package would probably be okay. However, now I realize that tools like IntelliJ will just show a dropdown. With a bit of bad luck, 'our' version is on top because there is an import like import nl.grons.metrics.scala._.
I like the name DefaultInstrumented over GlobalInstrumented because the metric registry is stored under the name default. GlobalInstrumented suggests that there can only be one.
@jklukas would you mind if I remove the existence check in DefaultInstrumented line 29?

Removing the existence check is okay with me. I can't think of a scenario
where an instrumented object would be instantiated before the Dropwizard
Environment gets a chance to publishes its metrics registry, so the
existing behavior may be overly cautious.
On Sep 5, 2016 1:57 PM, "Erik van Oosten"<EMAIL_ADDRESS>wrote:

At first I was thinking that putting Instrumented in a different package
would probably be okay. However, now I realize that tools like IntelliJ
will just show a dropdown. With a bit of bad luck, 'our' version is on top
because there is an import like import nl.grons.metrics.scala._.
I like the name DefaultInstrumented over GlobalInstrumented because the
metric registry is stored under the name default. GlobalInstrumented
suggests that there can only be one.
@jklukas https://github.com/jklukas would you mind if I remove the
existence check in DefaultInstrumented line 29?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/erikvanoosten/metrics-scala/pull/80#issuecomment-244793041,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAqLdKVdra3RGn_uxCjTVZcyrgfRkNSdks5qnFfogaJpZM4Jz8cP
.

I hope you liked what I did:

Kept the name DefaultInstrumented.
Extended it so that it also registers a default health check registry under the name default.
Rewrote lots of documentation to put more emphasis on the much easier to use DefaultInstrumented.

I asked the Dropwizard people if they would also like to register a default Health check registry. And they did! It was pushed in just mere minutes! https://github.com/dropwizard/dropwizard/pull/1722
I'll let the code rest for a few days and then create the next release.

Those changes look reasonable. I didn't even know that the SharedHealthcheckRegistries existed. It's good to see that used here and in Dropwizard now.


Fix cross compilation

src/osflags hard codes the build architecture pkg-config. After making it
substitutable and substituting it from the build environment, iodine cross
builds successfully.
Original patch from Helmut Grohne<EMAIL_ADDRESS>in
https://bugs.debian.org/921822, adjusted to Git HEAD.

Thanks, merged


RCTLinkingManager: Pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified)

[x] Review the documentation: https://facebook.github.io/react-native
[x] Search for existing issues: https://github.com/facebook/react-native/issues
[x] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
React Native Environment Info:
System:
OS: macOS Sierra 10.12.6
Memory: 6.48 GB / 32.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 8.11.1 - ~/.nvm/versions/node/v8.11.1/bin/node
Yarn: 1.9.4 - ~/.yarn/bin/yarn
npm: 5.6.0 - ~/.nvm/versions/node/v8.11.1/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 11.2, macOS 10.13, tvOS 11.2, watchOS 4.2
IDEs:
Android Studio: 3.1 AI-173.4819257
Xcode: 9.2/9C40b - /usr/bin/xcodebuild
npmPackages:
react: 16.5.0 => 16.5.0
react-native: 0.57.0 => 0.57.0
Description
After upgrading from React Native 0.55 to 0.57 and trying to compile the compile fails with
"Pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified)"
Screenshot: https://cl.ly/af7f38877e19

Suggested fix
RCTLinkingManager.h
/**
 * Copyright (c) 2015-present, Facebook, Inc.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */

#import <UIKit/UIKit.h>

#import <React/RCTEventEmitter.h>

@interface RCTLinkingManager : RCTEventEmitter

+ (BOOL)application:(nullable UIApplication *)app
            openURL:(nullable NSURL *)URL
            options:(nullable NSDictionary<UIApplicationOpenURLOptionsKey,id> *)options;

+ (BOOL)application:(nullable UIApplication *)application
            openURL:(nullable NSURL *)URL
  sourceApplication:(nullable NSString *)sourceApplication
         annotation:(nullable id)annotation;

+ (BOOL)application:(nullable UIApplication *)application
continueUserActivity:(nullable NSUserActivity *)userActivity
  restorationHandler:(nullable void (^)(NSArray * __nullable))restorationHandler;

@end

@PublicParadise Wow, wonderful, works! Thank you for super quick answer 🎉

This looks like a duplicate of https://github.com/facebook/react-native/issues/20797. There is a PR open here https://github.com/facebook/react-native/pull/20798

react-native link solved it for me

For anyone looking for a workaround – if you're able to upgrade to xcode > 9.2 then that will also fix the problem (credit here).

A temporary workaround if you're not able to update Xcode - use patch-package https://www.npmjs.com/package/patch-package

I have same issue how solve this? react-native link don't work

Hi! Seems the latest release 0.57.1 fixes this issue.

This is solved, please ping me if you have any other problems with this.

This has cropped up again with XCode Version 10.2 (10E125).
I fixed it manually at first with _Nonnull assertions at first, nullable's work for me too.

+1
This issue seems to have popped up right after upgrading to XCode 10.2

I can confirm it, I ran into this after upgrading to 10.2 :(

nullable works for me too.

still an issue for me, with latest xcode 10.2 - rn 0.57

I am still facing the issue with react-native 0.57.0

Same issue when I upgrading to Xcode 10.2,
I'm using react-native 0.57.0 @radko93

seems we will be unnoticed here... I also met it after upgrading to xCode 10.2

@radko93  - wondering if we can reopen this for XCode 10.2, or if a new issue should be filed.

For the commenters above: the fix is to use the latest version of RN, which doesn't appear to have this issue. Otherwise, patch RCTLinking.

@ericlewis - Can you elaborate on what you mean with "patch RCTLinking"?
I've tried @PublicParadise's suggested change, which got rid of that problem, only to throw "React/RCTEventEmitter.h' file not found". Looking up that issue, gets me back to this one, so I feel like I'm going in circles trying to fix this on my own.

@PublicParadise thanks! works like charm )


DevOps README

Signed-off-by: Sara<EMAIL_ADDRESS>

Description of the Change
README describing ports, clarifying the components that might help DevOps with Iroha deploy
Benefits
More docs
Possible Drawbacks
More docs

Discussed offline with DevOps team that this document is not mandatory since Continuous Delivery is used. Maybe some information can be moved to docs if it is not present there.

Also, for deployment, please refer to https://github.com/hyperledger/iroha-deploy


Language customization broken when using custom domain via Front Door

Using custom policy for Azure B2C's sign-in page, containing translations for both, English (set as default) as well as German, everything works as long as no custom domain, i.e., Azure Front Door (with caching & compression enabled), is involved.
That's because although the docs explicitly state

If you don't provide a ui_locales parameter, the customer's experience is dictated by their browser's settings.

as well as

Browser-requested language: If no ui_locales parameter was specified, your user flow is translated to the browser-requested language, if the language is supported.
Policy default language: If the browser doesn't specify a language, or it specifies one that isn't supported, the user flow is translated to the user flow default language.

Said B2C page is only shown in German when accessed via {tenant}.b2clogin.com.
Accessing it via a custom domain, e.g., login.example.net, utilizes Front Door & if caching & compression are enabled in the corresponding profile, the language detection is broken as the B2C page is then shown in English instead.
This should be listed as a known issue as well as reported to the Front Door team, so that they can fix it as soon as possible.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 659306d5-4703-6f5a-a11e-b6c6ffbc12b3
Version Independent ID: fad303cc-7be6-4ac9-9056-49c6d5f4b14c
Content: Language customization in Azure Active Directory B2C
Content Source: articles/active-directory-b2c/language-customization.md
Service: active-directory
Sub-service: b2c
GitHub Login: @garrodonnell
Microsoft Alias: godonnell

@Eagle3386
Thanks for your feedback! We will investigate and update as appropriate.

@TPavanBalaji I've added 1 essential detail: you've got to enable caching & compression within the Front Door profile to experience the issue. I've edited the OP accordingly.
Without both being enabled, the bug doesn't occur.
However, since Microsoft currently charges $30/month + extra for traffic, both settings are probably something each customer wants to enable.. 😉
As I suppose it's rather trivial to fix, I'd love to see this fixed as quickly as possible.
Again, thanks for your support!

@Eagle3386
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly.
@garrodonnell
Can you please check and add your comments on this doc update request as applicable.

@SaibabaBalapur-MSFT
Thanks for the update, but as I stated earlier, I'd love to see this also addressed to the Front Door team for them to fix the issue so using caching & compression doesn't break language detection of Azure B2C with custom domains anymore..
That's because I already opened a support request & the person in charge, to put it nicely, said "we're not doing anything about it - post it on the Azure feedback page, they might care" (surprise: they didn't & surely won't, given 8 upvotes on the post vs. several hundreds for others which are often unresolved, too).
So, that's the support we get - after not only paying for Azure B2C, but paying for using Front Door for custom domain usage as well & even additional payment just for opening a support request to bring this to Microsoft's attention.
And that's for a trivial bug that's supposedly fixed in less than a day.
I thought better of Microsoft when it comes to commercial support. 😞

@TPavanBalaji
We've added this issue to our documentation backlog work item for internal tracking and prioritization, and making we'll make our product team aware of it. We'll update this issue as once we resolve the issue. Thanks again for your feedback. #please-close


moved byte buf functions to the .c where they belong

Description of changes:
Right now, a lot of stuff is "static inline" in the header files.  This makes the header files hard to read, gives little performance benefit in most cases, and makes my CBMC proof life much harder.  This is the first of several refactorings to move the code the .c files where it belongs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I’m seeing a clang-tidy error in one of the tests.
/codebuild/output/src425878266/src/github.com/awslabs/aws-c-common/tests/device_random_test.c:135:24: error: 2nd function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage,-warnings-as-errors]
        ASSERT_SUCCESS(s_distribution_tester_put(&tester, array[i]));

It looks like the problem is that array[i] is set by the device random but clang-tidy doesn’t know that


fix(service-inq): determine sap client from cookies - sap-usercontext=sap-client

For BTP systems the sap-client can be found in the cookies e.g sap-usercontext=sap-client=100

You can access the client from the service key directly. The point of the _validatedClient is to indicate to prompts that the client has been validated by 1) An input validator and 2) By connecting. I cannot see any reason to do this.