Editing element styles in Chrome dev-tools

The Chrome dev-tools seem unable to edit the styles of Radium-enabled elements at runtime.
I edit the css in the "styles" panel of the "Elements" tab, and as soon as I hit "enter", the style/property just reverts back to its original value.
This is true whether I edit an existing style/css-prop, or whether I add a new one.
Here's a gif demonstrating the issue:

Any idea how to "override" the Radium-set styles using the dev-tools?
I like using the dev-tools for quickly testing font-sizes and the like, but at the moment I'm forced to edit the source files for Radium components. (either that or give it a temporary id, and add a "style" tag with "!important" applied, which is also a pain)

I tried this but couldn't reproduce your issue in Chrome nor in Firefox so something more specific to your case might be happening.

I was also unable to reproduce this issue.

I don't know what the cause is, but if other people aren't having it occur, then I guess the issue can be closed. (for my project, I just transitioned away from Radium for the really common elements, like buttons -- which mostly works around the problem)
If it causes substantial headaches again later, I'll re-open the issue and try to provide a repro case.


TypeScript Client Generator - Add Validation logic to Support Subset of System.ComponentModel.DataAnnotations attributes

Good Day Rico
You already support the generation of some DataAnnotation properties in the OpenAPI document.   Would it be possible to have validation code generated, for the TypeScript client, that recognizes those validation properties?
Much appreciated
Kevin Weir

Not on my prio list as the value is not that big (should be validated on the server anyway) and the effort is very high.

Ok.  Thanks for your consideration.


Why you use 'get_surface_trace' for marching cubes in plots.py instead of 'get_surface_sliding' like MonoSDF

Hi, Congrats for your great work!
I have a very detailed question.
I noticed that your code refers to the MonoSDF code,
but you use 'get_surface_trace' for marching cubes in plots.py instead of 'get_surface_sliding' like MonoSDF.
Could you let me know if there is any special reason for doing this?
I would be grateful for any help you can provide!

Hi,
This function inherited from ObjectSDF. I found the 'get_surface_sliding' including some additional operations like building point pyramids for marching cube while 'get_surface_trace' is much more like original marching cube.

I see! Thank you very much for your patient answer!
In addition to being more like the original marching cube, will 'get_surface_trace' get a better mesh, such as smoother?
Because I found that 'get_surface_sliding' seems to be faster and uses less GPU memory.

From my understanding, the motivation of the point pyramid is to reduce some unnecessary computations from the coarse level to the fine level by applying the mask. It should be a faster version and consume less GPU memory.
I also agree that the original marching cube might produce a smoother surface when we combine multiple object SDFs. The scene SDF produced by applying minimum operation on all object SDFs is an approximation of true scene SDF, especially in the inner part. A dense sampling for marching cubes could alleviate some missing computation.

okk! Thank you very much for your patient answer!


Support PartialEq on error

Note: this is a long background process. Let's update contracts one by one as we refactor them (a bit like updating them all to storage-plus)
With StdError::PartialEq implementation from https://github.com/CosmWasm/cosmwasm/pull/662, we can replace lots of statements like:
        match err {
            ContractError::Unauthorized {} => {}
            e => panic!("Unexpected error: {}", e),
        }

with simpler statements like:
assert_eq!(ContractError::Unauthorized {}, err);

It requires #[derive(PartialEq)] on ContractError and the above-mentioned support for StdError
Contracts to update:

[ ] cw1-subkeys
[ ] cw1-whitelist
[ ] cw3-fixed-multisig
[ ] cw3-flex-multisig
[x] cw4-group
[x] cw4-stake
[ ] cw20-atomic-swap
[ ] cw20-base
[x] cw20-bonding
[ ] cw20-escrow
[ ] cw20-staking
[ ] cw721-base

This works now, and we just need to update the contract code to use it.
I will add a bunch of checkboxes and tick them off as I port the contract code (I did a few during other refactorings)

Are you still working on this, or should I take it from here?

Thanks for taking this over. I started but then left it. Your PR looks nice.


Allow using proxy for ssh connection (sshconfig ProxyCommand)

It would be nice to have a possibility to use a proxy for the ssh connection (ProxyCommand corkscrew .....,  for example)

Hey @m42e, can you give an example of what you're trying to accomplish?
If you want to be able to SSH into machines where the boringproxy client is running, you can follow the instructions here:
https://forum.indiebits.io/t/how-to-forward-ssh-port-example-just-in-time-feature-request/56/5?u=anders
I believe you should be able to use it as a jump host as well.
Note that this approach is a bit clunky. I want to improve boringproxy's support for SSH in the future.

Sure, @anderspitman.
Sorry of the very brief description.
So sometimes I am in an environment that does only allow connections to the outside world using an http proxy.
I am using corkscrew to do SSH over the http proxy. This is achieved by adding the line
ProxyCommand /usr/bin/corkscrew proxy_ip proxy_port %h %p

into the ssh_config file.
So it is still for a connection from the client to the server. To create the tunnel.

This is a very interesting use case. Basically for you to be able to use corkscrew, boringproxy would need to implement a standard HTTP proxy (ie using the HTTP CONNECT method). I'm unlikely to implement this.
However, with the way boringproxy currently works, I think it might be easy to support your use case. I believe all you need is a tiny program that listens on a local port, then tunnels any connections on that port through TLS to the boringproxy server. If your tunnel is correctly configured to point at the SSH server on the boringproxy client machine, it should work.
I feel like stunnel should support this, but everything I see indicates stunnel requires it's own special server. If not stunnel it seems like such a program must already exist.
In any case it should be easy to write. I think you just derailed what I was planning to spend the next couple hours doing ;)

It turned out to be just about as simple as expected! Here's the program:

Ok I believe I've fixed the TLS cert bug, but you'll need to use a master build:
https://gemdrive.io/apps/delver/?drive=https://files.apitman.com&path=/public/boringproxy/master

Thanks a lot @anderspitman. Especially I did not want to keep you from  anything important :)
Now I did not get correctly what you explained or I did not manage to explain my scenario exactly. I try again to explain:

On the PC1, boringproxy client is able to connect to the server using http. But it could not directly connect to some outside ssh port (nor can it with http, but there the proxy is respected).
For my normal ssh commands I added corkscrew to enable the green path (e.g. GitHub ssh clone)
And I really have the feeling I owe you at least a beer for your effort and immediate action. So you are welcome if you are in Munich at some point in time.

Nice diagram! I'm still not sure what the goal is. Are you trying to SSH into PC2 while you're at work, or are you trying to SSH into PC1 while you're at home? Or something else?
No worries about the effort. The raw TLS tunnel is a great feature. In fact I think I'm going to add a new command to boringproxy to support it. Basically it lets you tunnel any TCP program through boringproxy, very similar to what stunnel does. But that doesn't mean we can't hang out if I make my way to Muenchen one of these days!

Ok, I want to use boringproxy for sharing some html files (using a simple stupid python3 Webserver).
so PC2 shall Access the websites on PC1 using the boringproxy :)

Ah yes in that case the client's outgoing ssh connection on port 22 will be blocked. That said, if you can run the boringproxy server OpenSSH server on a different port that isn't blocked (maybe use port 80 for SSH and 443 for HTTPS) you might be able to get through. Someday I'd like to support a protocol that works over HTTP or WebSockets.

Also, I've added the boringproxy tuntls command so we can now do raw TLS tunneling. Thanks for the idea!

Ok, I thought there might be a way to use the proxy for ssh, too. Maybe I can dive into go at some point in time.

Yeah unfortunately since boringproxy leverages OpenSSH for the heavy lifting, it needs to run on a separate port. Though unless I'm mistaken, corkscrew won't solve your problem either, will it?
Maybe take a look at these:
https://github.com/mmatczuk/go-http-tunnel (HTTP/2)
https://github.com/erebe/wstunnel (WebSockets)

It will and does, the line in corkscrew posted above, tunnels the outgoing ssh connection through the proxy.

Ohh I see. You're using corkscrew together with boringproxy.

That was the Idea, to let boringproxys ssh part use corkscrew. At the moment my native ssh client is using it.
Or does boring proxy utilise the ssh executable?

No the client uses the Golang ssh client. Unfortunately I don't think this will work without changes to the boringproxy client to tell it how to map the tunnel SSH port to the corkscrew port.

I do not have any experience but I stumbled across https://github.com/appleboy/easyssh-proxy
But I am not sure this is an option for boring proxy. It is fine for me if you say no.

Not sure. How are you thinking we might use it?
So, I opened a new issued (https://github.com/boringproxy/boringproxy/issues/167). I think it might take minimal changes to support tunneling the client's SSH connection through TLS, for situations like yours. It's pretty hacky but I'll think on it.

@m42e I may have gotten a bit carried away. I think boringproxy master now has everything you need to make this work. It takes a little manual work to set it up. Here's what you need to do:
Set up a tunnel named something like ssh.example.com with the following settings:

Tunnel Port: 22
Client Name: No Client
TLS Termination: Server raw TLS

Then on the client machine, run the following:
boringproxy tuntls -server ssh.example.com -port 2022
Then whenever you create a tunnel do it as you normally would, but set the following:

Override SSH Server Address: localhost
Override SSH Server Port: 2022

And that should be it. Basically what this is doing is creating a proxy similar to corkscrew on the local port 2022, and telling the client to use localhost:2022 when connecting to the SSH server for the tunnels.
Let me know if you get a chance to try it out!
https://gemdrive.io/apps/delver/?drive=https://files.apitman.com&path=/public/boringproxy/master

And don't feel bad about the extra work. These features weren't too invasive, and I got to do some nice cleanup in the process.

I'm planning on a PR to add proxy support on SSH.
HTTP calls to the REST API already respect http_proxy/https_proxy so I'm adding support for that on the SSH connections as well using golang.org/x/net/proxy
Only thing that took me a bit longer to figure out was to be able to use HTTP CONNECT with that setup as it only supports SOCKS5 out of the box, but I have a PoC working now, so I'll be submitting a PR soon, I hope it still helps

as I need to use SSH over an HTTP proxy at work, I've created https://github.com/boringproxy/boringproxy/pull/183 to tackle it. I believe it also solves this issue

Hey, tried to follow your advice to open a TLS tunnel on port 2022 and route all client SSH tunnels through localhost:2022.
Opening a tunnel with
boringproxy tuntls -server ssh.proxy.<domain> -port 2022

I get Listening on port 2022 - seems OK.
Then running the boringproxy client with a tunnel that uses "server_address":"localhost","server_port":2022 we get
BoreTunnel error:  Failed to dial: ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain.
A similar tunnel without server_address, server_port works perfectly.
We use a fresh build from the current sources.
Any hints whats going wrong here?
Thanks.

Hey @wzwg3. The tuntls functionality is not heavily tested. I just hacked it together since it seemed like a tool that might be useful. You say a normal tunnel is working ok? Is there a reason you want to use tuntls in that case? Can you clarify your overall goal?
Thanks!

We have a firewall that blocks SSH traffic. So the idea was to use a TLS tunnel between client and server (the tuntls tunnel) and route the SSH tunnel between boringproxy client and server through this tunnel.

I have created a pr that allows what I initially wanted to solve #212


Add parameter support

Add argument selector to runner-entrypoint
Add args to action.yml
Add example to README.md

We rely on passing custom variables to our codefresh deployment pipelines however the current version doesn't allow this. I've published a pre-release version with my changes and I am successfully using this to trigger our codefresh pipelines with custom variables.

We rely on passing custom variables to our codefresh deployment pipelines however the current version doesn't allow this. I've published a pre-release version with my changes and I am successfully using this to trigger our codefresh pipelines with custom variables.

Thank you @theteng


Error listing Ollama models: [Errno 111] Connection refused

Hello,
I hope this message finds you well. While I am running the Streamlit app and clicking on Refresh Ollama Models, the terminal displays the error: Error listing Ollama models: [Errno 111] Connection refused.
Could you please provide any clues to help me resolve this issue? I would greatly appreciate your assistance!
Additionally, here are the debugging steps I have taken:

Checked whether the Ollama server is running:curl http://<IP_ADDRESS>:11434
# Ollama is running

Ensured the host IP address is correct while running the docker:docker run --network host -e OLLAMA_BASE_URL=http://<IP_ADDRESS>:11434 -p 8501:8501 cyberscrapper-2077

Thank you for your time!

I am looking into it.

issue resolved, clone the repo again and follow the new steps, Thanks for letting me know about the issue.
Just a few tips while using the CyberScraper with Ollama, I tested it with llama3.1 it works pretty decently 70% of the time, with current settings, You might need to tweak the prompt a little for whatever llm you are running and based on the output you are getting from the LLM.
Happy Scraping :)


Segregated different kind of geocoder results for stats

This PR is derived from #6286.
We need to add more stats to our current system to segregate by processed, failed and successful responses.

@rafatower check this out, I need to add the GME part but I need validation for this work

overall looks ok


Fix for Issue#1939 - Added multi-thread handling to ServiceMap

Description
Fix for Issue#1939

Motivation and Context

We can not upgrade our AWSSDK.Core and therefore cant use any other service SDK... We get a lot of those exception because of large scale. This issue is really critical for our fluent work.
Testing

Screenshots (if appropriate)
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have read the README document
[ ] I have added tests to cover my changes
[x] All new and existing tests passed

License

[x] I confirm that this pull request can be released under the Apache 2 license

Hey @EyalMaozCP, as we discussed outside of GitHub last week we had an internal fix in progress for this same issue, so may no longer need this PR.
That was recently released as AWSSDK.Core <IP_ADDRESS>: https://github.com/aws/aws-sdk-net/commit/c6c55eadd97e546c42df2ca2bcb13a5c51f54322.
Please let us know if you're still seeing issues upon upgrading, thanks.

Hey @ashovlin , Thank you very much, we will deploy the new SDK version probably next week (we have holiday this days) will update how it went.

Hey @ashovlin, we completed our AWS SDK core upgrade in production, and so far it looks good. No errors 💯
Thank you so much for your help. I will now close this PR.


Video View freeze on iOS 12.1

When I open the YPImagePicker (default on photo) and switch to video, the video view freeze.
I can still do other things(like: cancel, switch front-rear camera), only the view freeze.
To Reproduce
Steps to reproduce the behavior:

Go to Picker, default photo
Switch to video
Video view freezes
In console I get the following error:

AVAudioSessionPortImpl.mm:56:ValidateRequiredFields: Unknown selected data source for Port Speaker (type: Speaker)
Environment:

Device: Iphone 5s
OS: iOS 12.1
Xcode Version 10.1
Swift Version 4.2

Installation Type

Cocoapods

What should I do? Is a problem from the new OS version?
On version 12.0 it worked well.

on iOS 12.1.4, iPhone SE it is still here.

@andriansergheev @nightroadcosplay is it still actual?

There is 2022 year outside🎉 Old outdated issues are closing. Please search if there are already existing issues with the same problem before opening new ☮


Appstudio update mvp-test-component

Pipelines as Code configuration proposal

Pipelines as Code CI/mvp-test-component-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
18 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
12 seconds
sanity-inspect-image

✅ Succeeded
12 seconds
deprecated-base-image-check

✅ Succeeded
48 seconds
clair-scan

✅ Succeeded
57 seconds
clamav-scan

✅ Succeeded
10 seconds
sbom-json-check

✅ Succeeded
8 seconds
sanity-label-check

✅ Succeeded
7 seconds
sanity-optional-label-check

✅ Succeeded
5 seconds
show-summary


fix: troubleshooting commit-hash

Description
This pull request changes the following:

troubleshooting commit-hash in deploy and release

Related Issues

Closes #594

:tada: This PR is included in version 0.30.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_3bsz77la02/clone/recipe/meta.yaml:18: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_3bsz77la02/clone/recipe/meta.yaml:24: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_3bsz77la02/clone/recipe/meta.yaml:58: missing_license_family: The recipe is missing the about/license_family key.
WARNING: /tmp/abs_3bsz77la02/clone/recipe/meta.yaml:58: missing_description: The recipe is missing a description
ERROR: /tmp/abs_3bsz77la02/clone/recipe/meta.yaml:58: missing_dev_url: The recipe is missing a dev_url
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_67qtdu5y6y/clone/recipe/meta.yaml:18: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_67qtdu5y6y/clone/recipe/meta.yaml:24: missing_wheel: For pypi packages, wheel should be present in the host section
WARNING: /tmp/abs_67qtdu5y6y/clone/recipe/meta.yaml:58: missing_description: The recipe is missing a description
ERROR: /tmp/abs_67qtdu5y6y/clone/recipe/meta.yaml:58: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_67qtdu5y6y/clone/recipe/meta.yaml:58: missing_dev_url: The recipe is missing a dev_url
Errors were found


Fix typo

Fixed somes "-"

@srThibaultP : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good. Thanks for the typo fixes, @srThibaultP.


Add multi-phase gammatone filterbank

Adding the multi-phase gammatone filterbank with code from https://github.com/sp-uhh/mp-gtf .
Paper reference is [1].
[1] David Ditter, Timo Gerkmann, "A Multi-Phase Gammatone Filterbank for Speech
Separation via TasNet",  IEEE Int. Conf. Acoust., Speech, Signal Process. (ICASSP),
Barcelona, Spain, May 2020.
Available: https://ieeexplore.ieee.org/document/9053602/

Ok, applied changes regarding each comment above. Let me know if this is all.

I just changed minor things (mostly cosmetic + make the filterbank more consistent with the other ones).
This is ready for merging IMO, let me know if this looks ok for you.
Thanks again

Great, thank you, this looks good now! Let's merge this.


WIP feat(integration): add snowtrace integration

Description
This pull request implements the SnowTrace API. This pull request will not be updated on my side, and only serves as an archive of my work, or simply remains open for those who would like to use what has been done.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

please sign the CLA

Thank you for sharing what you have there @Olyno! Sorry for the difficulties you faced during the setup 😔

please sign the CLA

I think we are okay for now as this is not going to be merged, just the work that @Olyno has done. So in future anyone can just reference what's here and complete it


RFC: New Index page for the Jest website

Note: This issue has a bounty on our Open Collective - see https://github.com/facebook/jest/issues/7265#issuecomment-450507843
It is just for the single index page on https://jestjs.io, which is powered by Docusaurus and if you want to see what an example PR would look like see https://github.com/prettier/prettier/pull/3718

OK, a primer before we get to pretty pictures - I'm looking for someone to implement this, but it's pretty well spec'd out. Only a few more cases of lorem ipsum, and I want to re-create all screenshots after ( https://github.com/facebook/jest/pull/7241 ) . Nothing that should block implementation.
My aims with the redesign:

Highlight Jest's awesome terminal UI (bigger images, more of them)
Decouple Jest from being the "React testing tool" (the current site mentions react in half of the sections)
Consistent messaging
BE COOL, because Jest is cool

Alright, step one, a new Jest logo. I think the foot is cool, and I think it should stick around (I re-use it in the designs) but I also like the simplicity of this idea:
What if we take the runtime symbols Jest uses to indicate how things are going?

Then re-use that symbology:

Pow.
I know, it's a tad underwhelming but It fits, really well. It can work in the terminal during the jest launching scene, it connects to all of the existing messaging people see every day, is simple and recognizable. I think both are useful.

Alright, the site, like with the prettier redesign https://github.com/prettier/prettier/issues/3669 is aimed is to fit naturally in the docusaurus framework. I aimed to extend the Jest as joker metaphor by using cards + deck metaphor.

Highlights:
Mobile Version
Link
Mostly the same, without the splits. I feel like the slanted titles work much better here ( less space, so they stand out more) and tie the identity together.
Headline
The top of the site should animate, the cards flip from the front to the back. They all start off as "RUNS" (e.g. the back) then progressively flip to either "PASS" or "FAIL" - like a good flaky test suite. Maybe clicking on a red could spin to the back ("RUNS"), then flip back to a PASS after a second.

Here's what all the cards look like:

Bonus points - I'd love to see the "RUNS" animating in a circle (to indicate activity)
Grid
I used a 960 grid width, 12 sections, and only used the inner 10 for desktop:

Cards

Assets

Sketch file with all drafts, alternative ideas etc.
History: 0, 1, 2, 3, 5

I can definitely create a bunch of assets if whoever is working on this isn't used to working with Sketch files directly 👍

omg, this is soooo good! I absolutely love it!!

I love the idea of having a runtime environment to run tests!
It might be worth having that added after this, as I feel like the repl.it and codesandbox embeds have tricky interfaces ( you can see examples for codesandbox and repl.it ) when trying to do a quick embed.
Something more like a "Jest cookbook" showcasing a bunch of "how do I mock a class from this import" kinda questions with repls (and the ability to explain to folks how to use it  makes sense

Looks great! Some feedback:

Maybe a different color from the muddy green? IMO the color isn't very pleasant to look at.
Would be nice to have a bit more padding and larger line height. It looks kinda crowded otherwise.
Maybe the cards would look better with more subtle border?

Love this, and would be happy to help implement this!
My only feedback is the titles on the features (blazing fast, etc) and the sponsor section, I don't think those have a high enough contrast ratio to be accessible.
Maybe look at using a darker red over top, or darkening up the red background?

I'll have a branch out soon! Ill do preview deployments using surge or netlify

Awesome! We have netlify set up, so just opening up a PR should be enough 🙂

Maybe a different color from the muddy yellow-green

The yellow here is a hue shift from the green and red, I'd rather not break that design patterns. That said, I like that yellow (and use it in my terminal), it's got a good sandy colour 👍

Would be nice to have a bit more padding and larger line height...

Padding I'm pretty fine with, but I agree on the line heights for body text, I'm happy to tweak those in CSS towards the end though

I don't think those have a high enough contrast ratio to be accessible

I agree on this, dang, I was trying to lower their visual precedence so the above the fold content had a nice visual hierarchy (and you weren't dragged down too quickly).
Will see if I can figure another way to do it.

Nope, no time constraint 👍

@orta Ok, I will do it

I don't really have an opinion on implementation details, as long as it's easy for others to contribute and not hard to maintain that's fine with me 👍

The site went through another design review last night, with an updated color scheme - I've updated the images in the main comment above for the desktop + mobile, and included a bunch of assets so you don't have to dive into the sketch docs

@orta I just opened #7566, I will make those new changes on Tuesday.

It's amazing that people are making so much progress on this. thank you.
Here is my (highly subjective) feedback on the design:

The hover effect on buttons and the menu bar should be shortened or removed with the new design.
The gray background in the description of Jest looks really off, let's just remove it and have gray/black text on white background. Let the text stand on its own.
I prefer not having a background or rotation for the headers. @orta proposed (not posted here yet I think?) to have a colored block to the left of the header and using a normal font like Menlo on macOS.
The logo in the center card is missing a horizontal line between two of the circles. Please update it to the latest SVG which has this visual bug fixed.

I've updated the designs + assets again with all the feedback (except the logo SVG, that can be hot-fixed in #7567 )

Thank you! I like this a lot more. Here are some more ideas (that can be iterated on in the real PR):

What if we made the Jest logo and link highlight green instead of red? That way it would match with the PASS color. Otherwise, shall we pick a color other than green/yellow/red?
"Blazing" is probably not a great description, as it is mostly a joke and a lot of people won't understand it.
I would probably recommend left-aligning the headers in the selling points, and remove one of them (it looks really dense)

One more minor request:

Let's remove the underline from the version number and make the version 2px smaller in the header

I think the version font can be a bit smaller still.

@cpojer Recduced the version font by a factor of 2px.


Cyprus Flag Display Issue

Flag Appears Clipped in Half When Selecting Cyprus Country Code.

Hey @hamadahTrraf kindly update to version 1.2.8of the lib


chore(DEVHAS-662): Remove Environment API from e2e-tests

Description
Removes the Environment API source from e2e as it is planned to be removed from HAS and is no longer part of application-api: https://github.com/redhat-appstudio/application-api/pull/81
Test cases for SEB controller have already been removed: https://github.com/redhat-appstudio/e2e-tests/pull/1088
Issue ticket number and link
https://issues.redhat.com/browse/DEVHAS-662
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
No special instructions.
Checklist:

[X] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[x] I have updated labels (if needed)

/retest
Renamed my folk to expected target for failing check.

https://github.com/redhat-appstudio/e2e-tests/pull/1158#issuecomment-2101674807

Might be due to what https://github.com/redhat-appstudio/application-service/pull/471 fixes. Will retest once https://github.com/redhat-appstudio/infra-deployments/pull/3679 is in.

/hold

/unhold

/retest

@michael-valdron could you rebase with main branch. It looks like something is out of date. All these tests are failing trying to make this API call
https://github.com/michael-valdron/e2e-tests/blob/992172fe466ec95e4b9c97bd928a31d2e82b00f5/pkg/clients/has/applications.go#L44
And I don't see that API or references to them in the tests anymore on the main branch.

@michael-valdron could you rebase with main branch. It looks like something is out of date. All these tests are failing trying to make this API call
https://github.com/michael-valdron/e2e-tests/blob/992172fe466ec95e4b9c97bd928a31d2e82b00f5/pkg/clients/has/applications.go#L44
And I don't see that API or references to them in the tests anymore on the main branch.

Oops meant to do this, thanks @Dannyb48!

/retest

/test redhat-appstudio-e2e

/test redhat-appstudio-e2e

/retest-required

failure in this job is known issue (I'm working on a fix). merging


Website homepage in README is a 502 gateway error

Website homepage in README is a 502 gateway error

Hi. Unfortunately this project is no longer being worked on and therefore its website is no longer actively maintained either.
I am however planning on bringing the learnings - and hopefully also the current game implementations - from this project onto this project: https://github.com/Zomis/Games . If you are interested in what this project does, the Zomis/Games project might interest you as well.


Carbon should start on machine reboot/restart

Ensure installation procedures configure carbon to start on machine start

Done in slipstream/SlipStreamServerDeps@474a486cc3ec832a3b70b98572c03c2a05c56210.
Now slipstream-graphite is part of the standard installation slipstream/SlipStream@cc53d798b29555086e98c8f3b171e7271a5b953a


Explicitly use '&' in http_build_query()

Some hosting environments are configured to use &rather than &. Calling the twitter api end up with error #32 / Could not authenticate you

+1 to merge.
Thanks, I had it working on a local Apache environment but got the error on a staging/live Nginx environment.
This PR fixes it.

Thanks for this! It's an old one now and I'm just going through and cleaning things up. If you'd like this still to be merged in, could you make the PR into develop? Will close for now, cheers.

@J7mbo PR https://github.com/J7mbo/twitter-api-php/pull/200 is this against develop.
Thanks for the original PR @mcguffin!


update reduction with a new run: crashing

Here's the last command I see after I launched the update to the v288 full processing with a few more nights:
22:03:22.293-@!|PROC|   apero_pol_spirou.py 2023-11-02 --exposures 2921141o_pp_e2dsff_tcorr_AB.fits 2921142o_pp_e2dsff_tcorr_AB.fits 2921143o_pp_e2dsff_tcorr_AB.fits 2921144o_pp_e2dsff_tcorr_AB.fits --crunfile=complete_run_custom.ini --program=POLAR[07321] --recipe_kind=polar-tcorr --shortname=POLAR --parallel=True
22:03:22.300-  |PROC| ***************************************************************************
And the error I got:
Traceback (most recent call last):
File "/Users/moutou/apero-drs/apero/core/utils/drs_startup.py", line 433, in run
llmain = func(recipe, params)
File "/Users/moutou/apero-drs/apero/recipes/spirou/apero_pol_spirou.py", line 158, in main
pprops = gen_pol.calculate_continuum(params, recipe, pprops)
File "/Users/moutou/apero-drs/apero/science/polar/gen_pol.py", line 1412, in calculate_continuum
contflux = _fit_continuum(params, recipe, wldata, stokes_i,
File "/Users/moutou/apero-drs/apero/science/polar/gen_pol.py", line 2600, in _fit_continuum
spl = interpolate.splrep(wavemap[mspec], spec[mspec], k=3,
File "/Users/moutou/miniconda3/envs/ap288/lib/python3.9/site-packages/scipy/interpolate/_fitpack_py.py", line 288, in splrep
res = _impl.splrep(x, y, w, xb, xe, k, task, s, t, full_output, per, quiet)
File "/Users/moutou/miniconda3/envs/ap288/lib/python3.9/site-packages/scipy/interpolate/_fitpack_impl.py", line 508, in splrep
raise _iermess[ier]1
ValueError: Error on input data
And indeed, the polar products are not done, for this sequence.
Has someone seen this error ?

Same as what I got in #727 ?

Yes indeed it's the same error, it's the first time I see it but apparently it was here before as well. I got 144 entries of this command in msg/tool/other/: grep _iermess *log|wc -l
@larnoldgithub Did you find a way to fix it? (not much on #727)

sorry I've nothing in my notes. I think it's mostly for low snr OG -although QC are ok-, but I'm not sure.

and the exemple you report is again for a faint object/low snr.


[BUG] files.pythonhosted.org read timeout issue when deploy seedfarmer in AWS China regions

Describe the bug
When we deploy seedfarmer in AWS China regions, seedfarmer (codeseeder) is injecting this code fragment below before our own deployspec.yaml / buildspec.yaml.
pip install aws-codeseeder~={version}
In China regions, normally, we will add a PIP mirror to work around the China internet issue. However, the seedfarmer is injecting pip code before our deployspec.yaml / buildspec.yaml file which lead to the files.pythonhosted.org read timeout issue when pip install the aws-codeseeder.
To Reproduce
Steps to reproduce the behavior:

Deploy in seedfarmer in AWS China regions.
Most time, it would fail in build stage.

Expected behavior
Seedfarmer would deploy without issue in China regions.
Screenshots

Additional context
Potential fix:
modify file .venv/lib/python3.9/site-packages/aws_codeseeder/services/codebuild.py(line 324) install section to below
Before Change:
install = [
"mv $CODEBUILD_SRC_DIR/bundle/retrieve_docker_creds.py /var/scripts/retrieve_docker_creds.py || true",
"/var/scripts/retrieve_docker_creds.py && echo 'Docker logins successful' || echo 'Docker logins failed'",
]
After Change
install = [
"if [[ "${AWS_REGION}" =~ ^cn-.* ]]; then\n  pip config set global.index-url
\ https://pypi.tuna.tsinghua.edu.cn/simple\n  npm config set registry
\ https://registry.npmmirror.com/\nfi\n",
"mv $CODEBUILD_SRC_DIR/bundle/retrieve_docker_creds.py /var/scripts/retrieve_docker_creds.py || true",
"/var/scripts/retrieve_docker_creds.py && echo 'Docker logins successful' || echo 'Docker logins failed'",
]

please review the proposed fix by @danxie1999

I changed this to a feature request as the ability to change the pip mirror is a feature that we don't currently support.
I will review options.


chore(main): release uniform 0.14.5

:robot: I have created a release beep boop
0.14.5 (2024-12-15)
Bug Fixes

deps: update dependency framer-motion to v11.14.1 (#623) (44e96cb)
deps: update dependency framer-motion to v11.14.3 (#626) (2a76d24)
deps: update dependency framer-motion to v11.14.4 (#627) (d0eb6aa)
deps: update dependency react-hook-form to v7.54.1 (#625) (7be8d30)
deps: update dependency react-select to v5.9.0 (#621) (f4efbf5)
uniform: prevent uncontrolled warning in CheckboxGroup (e26bbc9)
uniform: prevent uncontrolled warning in Input (24be41b)
uniform: prevent uncontrolled warning in TextArea (d0faf0e)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

uniform-v0.14.5
:sunflower:


Add prometheus metrics

Add Prometheus metrics endpoint at "/metrics" with topic and consumer group measurements.

Thanks for contributing. Could you please add tests for it?

Coverage decreased (-3.7%) to 71.027% when pulling 4af72407ffb8102be1f5dc2e309d63a4f73724dd on dmitryilyin:prometheus_metrics into a449cc412c48231a2b7347cd790f82b8ed18faf2 on linkedin:master.

Hello! Ok, I'll make tests.

See also: https://github.com/jirwin/burrow_exporter/ (it might make sense to make use of prometheus golang libraries in your PR)

Relates issue https://github.com/linkedin/Burrow/issues/318

Any update on this pull request?
@bai is there a chance to get that merged if tests are added?
Is there even better chance it's merged if the client_golang is used?
@dmitryilyin do you have the bandwidth to tackle this or would you need help?

I'd personally prefer having a native client_golang implementation since it's proven in production. I personally have no bandwidth to implement it though.
I won't hesitate reviewing a PR and releasing it if you or someone else would implement it 🙏

When will the feature be released?
Where Can I find the documentation for prometheus exporter?


Cannot find containerd-mount device for arm

For arm linux, i run "k3s-armhf server" first, then i import k3s-airgap-images-arm.tar success.
When i try to run the image, k3s give me an error msg. it is the same error msg for all images.

./k3s-armhf ctr run docker.io/rancher/library-busybox:1.31.1 111
ctr: failed to mount /tmp/containerd-mount076466803: no such device

Maybe i miss something, but i do not know how to resolve it....

What OS distribution is this on?

only busybox on linux kernel

I'm not sure we've ever tested it on such a stripped-down system. What are you using for the root filesystem image? Do all of the Filesystem Hierarchy Standard directories exist?

it need overlayfs, i config it & rebuild kernel.


how to send messages in order?

when using e.g. C# Telegram.Bot library, I can do successive calls to bot.sendmessage and the user receives them in the order which I used to send. With node-telegram-bot-api, I often get replies in random order.
Repro: create a basic echo bot, verify it works, stop bot, send 3-4 messages, start bot, see messages received by bot in order, but replies in chat in random order.

you can use Promise's .then()  method. It accepts only one parameter: a callback with a(n optional) parameter that will contain last sent message details, like message_id.
So you can do:
bot.sendMessage(...).then(() => {
    bot.sendMessage(...);
});

Chaining such this way messages is a bad way, but the only one Imho.

I am in support of @alexandercerutti's answer.
first approach:
Furthermore, here is another approach you can use to send multiple messages:
var Promise = require('bluebird');

function sendMessages(bot, chatId, messages) {
    return Promise.mapSeries(messages, function(message) {
        return bot.sendMessage(chatId, message);
    });
}

// example usage
sendMessages(bot, chatId, ["first", "second", "third"])
    .then(function() {
        console.log("All messages sent, in series!");
    });

However, the above approach assumes you have the messages prepared in advance.
second approach:
For the use case where you are invoking bot.sendMessage() arbitrarily, you might want to implement it using a queue of messages:
var Promise = require('bluebird');
var queue = [];
var inUseQueue = [];

function _sendMessages() {
    // if we are already sending messages from the queue, or
    // the queue is empty, stop
    if (inUseQueue.length || !queue.length) return;

    console.log("processing queue");
    inUseQueue = queue;
    queue = [];
    Promise.mapSeries(inUseQueue, function(request) {
        var resolve = request.resolve;
        var reject = request.reject;
        var bot = request.bot;
        console.log("sending message '%s'", request.message);
        return bot.sendMessage(request.chatId, request.message)
            .then(resolve)
            .catch(reject);
    }).then(function() {
        console.log("queue processed");
        inUseQueue = [];
        _sendMessages();
    });
}

function sendMessage(bot, chatId, message) {
    var resolve, reject;
    var promise = new Promise(function(promiseResolve, promiseReject) {
        resolve = promiseResolve;
        reject = promiseReject;
    });
    console.log("pushing message '%s' to queue", message);
    queue.push({ bot, chatId, message, resolve, reject });
    process.nextTick(_sendMessages);
    return promise;
}

// example usage
function toLog(message) { return function() { console.log(message); }; };

sendMessage(bot, chatId, "first").then(toLog("first sent!"));

setTimeout(function() {
    sendMessage(bot, chatId, "second").then(toLog("second sent!"));
}, 1000);

setTimeout(function() {
    sendMessage(bot, chatId, "third").then(toLog("third sent!"));
}, 2000);

The above example usage gave me this output:
pushing message 'first' to queue
processing queue
sending message 'first'
pushing message 'second' to queue
pushing message 'third' to queue
first sent!
queue processed
processing queue
sending message 'second'
second sent!
sending message 'third'
third sent!
queue processed

Hope that gives you an idea of how to solve your problem.
(And maybe a PR for this could be awesome!)

oh well. I guess I'll make generic per-user "dispatch queue" where I'd put the messages and it would ensure it wont interleave them... or aggregate, if I accidentally spam it with 100 msgs :)
Thanks for the advice though.

(And maybe a PR for this could be awesome!)
@GochoMugo btw, I noticed we have a fork (node-telegram-bot-api-latest), shall I switch to it and submit PRs there, if any?

@wizzardo That repo is mainly for merging PRs from this repo. It is just bleeding-edge for kinda-advanced users (and might disappear, if @yagop keeps up with PRs here). Also see the beginning of the README in the fork.
So, please draft your PRs against this repo. I will (most probably) help you perfect it here, then we will have our bot automatically draft it from here to the fork and we merge.

hmmm... given there was a few months since last PR was merged, maybe it's possible to ask @yagop for commit access?

I might do that some time to come, but I gave him the benefit of doubt: we get busy at times, you know! But I might query him and see the result.

I have built a wrapper around this library to add higher-level features. Currently, it supports sending messages in order. It is called tgfancy. See https://github.com/GochoMugo/tgfancy for more information.

/cc @phillipadsmith


Support ARM 64

Hi Maintainers,
Thank you for the library. I'm wondering if you could add ARM 64 support for newer Mac. Thanks!
Please find the error message below:

The error was a result of my docker compose configuration. Closing the issue. Thanks again maintainers.


Fix stack 8.6 build

/azp run

Mmm, the ci build for stack86.yaml was failing due to #763, but the ci build for the pr passed. And master works for me locally using the default stack.yaml just now.
It is due a second hackage revision on hie-bios which bumped up the lower bound over aeson : https://hackage.haskell.org/package/hie-bios-0.7.1/revisions/
I would put explicitly the revision in the stack yaml file (- hie-bios-0.7.1@rev:2), cause an already existing cache would bypass the revision. stack interacts badly with hackage revisions :worried:
Thanks for fixing it.

Mmm, the ci build for stack86.yaml was failing due to #763, but the ci build for the pr passed. And master works for me locally using the default stack.yaml just now.
It is due a second hackage revision on hie-bios which bumped up the lower bound over aeson : https://hackage.haskell.org/package/hie-bios-0.7.1/revisions/
I would put explicitly the revision in the stack yaml file (- hie-bios-0.7.1@rev:2), cause an already existing cache would bypass the revision. stack interacts badly with hackage revisions 😟
Thanks for fixing it.

This doesn't seem like stack's fault, but rather the cache right? In any case I'm keen to merge this as soon as possible in order to unblock other PRs, so I'm going to leave it as is. Please send a separate PR after this lands if you have strong feelings about adding the revision to the stack descriptors.

it seems the bench component is failing cause it is picking master to compare results and master cant be built?

/azp run


Creating generic model_test

Goals :soccer:
Right now there’s a lot of variation from test to test how models are being tested. This PR is a first step towards standardizing this.
Implementation Details :construction:
In the model_test we validate if the model can be trained, evaluated & re-trained.
Note that this PR also moves the model tests from test_core to models/test_base. This is something we forgot to do when we broke up core.py into many smaller files.

rerun tests


Snake FP - newApple not checking that apple is not on snake

newApple needs to be recursive

Duplicated by #785


Update for Zig 0.12

Changes

Change non-mutated value declarations to use const, as var produces an error in Zig 0.12
Replace calls to a few deprecated standard library functions.
Update build.zig for compatibility with Zig 0.12. Use addExecutable instead of addSharedLibrary for WASM artifact.
Update Roc module headers

Note: Glue files have been updated, but in the future the plan is to remove these from source control and generate them locally.

This should be ready unless we want to try to use addSharedLibrary for the WASM artifact or unless we want to wait to merge until we have a way to generate the glue files.


Fix outdated pod lockfile in example

The example app fails to build because it uses an older version of the iOS SDK.

This PR updates the pod lockfile to use 3.5.0 which adds the new TextTrack src prop.

Thanks for reporting. PR approved and merged to develop.


Migrate to use same pattern as UrlPattern

We could use the same pattern as UrlPattern.
This would be a breaking change... It's possible we could make a deprecated API or something else for use the old syntax.

I just came to file this as a feature request. I think it's a great idea now that browsers and other languages are starting to standardize around this.

Just for reference this should be helpful https://wicg.github.io/urlpattern/#urlpattern


Clean up forcefield folder and testsystems.py

Status

[ ] Ready to go

Codecov Report

Merging #71 (18d61ad) into main (a7f72c9) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files


NFQ critic network has very similar outputs with different inputs

Suggestions:

Add depth to the network (does not work)
Add regularization
Change initializer (testing)
Reduce learn rate

Reducing learning rate of the critic model helped solving the problem. If the learning rate is too high, it would probably "kill" a plenty of important neuros. (Netagive output => gradient disappearance on the next layer)

Reducing learning rate of the critic model helped solving the problem. If the learning rate is too high, it would probably "kill" a plenty of important neuros. (Netagive output => gradient disappearance on the next layer)

Measures that helped: changing initialization; reducing learning rate and adding epochs.
Measures that didn't help: delete of pooling layers or adding additional full connection layers

Measures that helped: changing initialization; reducing learning rate and adding epochs.
Measures that didn't help: delete of pooling layers or adding additional full connection layers


Check boolean values in vkCreateSampler

This change adds checks for the boolean values in vkCreateSampler.  The anisotropyEnable field is erroneously missing from the 1.0.3 spec, which makes it easy to overlook setting it.  This causes a crash in some drivers.
I wasn't sure against which branch to make this PR.  Let me know if I should re-make it against the sdk-1.0.3 branch instead of master.

Change was rebased with master locally and pushed directly to Vulkan-LoaderAndValidationLayers.


Memcache sub-handler should not inherit from Memcached

as the 2 extensions live independently

Agreed and finished- I've removed the last connections between the two and they're now completely independent.


Issue 1059

This fixes an ongoing issue https://github.com/jenssegers/laravel-mongodb/issues/1059 - raw queries in Moloquent return arrays, wheres Eloquent raw queries return stdClass objects.
The main reason I created this fix is because further along the line other Laravel libs that are using raw queries might crash (ie Laravel Passport).
I have only nailed down the bugs that emerged in the unit tests.

have same issue using mongodb and passport
can I help?

Same Issue!

Same issue here... Any updates regarding this?

+1

Helfen mir!

I'm dealing with this problem too

Same here

Closing due to inactivity, no plans to merge this.


fix: fix the CEL definitions to allow policies that use target selectors without explicit targetRefs

Fixes #3901

/retest

/retest

Thanks! 👍


Update Avatar Patterns for LHN

Details

Remove the text pill, and update all avatar patterns to match:

Fixed Issues

$ https://github.com/Expensify/App/issues/19264
$ https://github.com/Expensify/Expensify/issues/290271
https://github.com/Expensify/App/issues/20486
Tests

[ ] Verify that no errors appear in the JS console

For each of the following chat types:

[ ] Ensure that the report avatar style matches the following photo.
[ ] Ensure that the report avatar is consistent in LHN, Header, and Search
[ ] Ensure Tooltips are correct
[ ] Ensure Tests pass with an account with a custom avatar.

Definitions for this QA

Subscript Avatar (2):  Avatar Style with one large avatar, and one small avatar in the bottom right corner. (1) is the large main avatar and (2) is the bottom right.

Multiple Avatar (2): Avatar style with two avatars overlayed diagonally. (1) is the top left and (2) is the bottom right.

Single Avatar: Avatar style with single avatar

[ ] Workspace Chat - Create a workspace -> add a member

[ ] Type: Subscript Avatar (2)
[ ] (1) Workspace
[ ] (2) Member
[ ] Size: 40x20px

[ ] Expense Report

[ ] Type: Multiple Avatar (2)
[ ] (1) Member
[ ] (2) Workspace
[ ] Size: 24x24px

[ ] IOU Report - Create a $$ request in a DM

[ ] Type: Multiple Avatar (2)
[ ] (1) / (2) Payer / Payee
[ ] Size: 24x24px

[ ] Expense Request - Create a $$ request in a workspace chat, open the created request

[ ] Type: Subscript Avatar (2)
[ ] (1) Member
[ ] (2) Workspace
[ ] (1) Size: 32x32px
[ ] (2) Size: 20x20px

[ ] Thread (DM) - Create a thread in a DM

[ ] Type: Single Avatar
[ ] (1) Actor

[ ] Thread (Workspace) - Create a thread in a Workspace

[ ] Type: Subscript Avatar (2)
[ ] (1) Member
[ ] (2) Workspace
[ ] (1) Size: 40x40px
[ ] (2) Size: 20x20px

[ ] Group Chat - Create a group chat

[ ] Type: Multiple Avatar (2)
[ ] (1) / (2) Members (or member + number)

[ ] Rooms - create a workspace, note all room types. Create a custom room.

[ ] Type: Single Avatar
[ ] (1) Workspace Style
[ ] If domain room, should follow default workspace pattern with first letter of domain name.

[ ] Task (DM)

[ ] Type: Single Avatar
[ ] (1) Task Creator

[ ] Task (Workspace)

[ ] Type: Subscript Avatar (2)
[ ] (1) Task Creator
[ ] (2) Workspace

TO TEST COPILOT: follow these steps from https://github.com/Expensify/App/pull/21246:

[ ] In www.expensify.com, login as a copilot for a policy admin
[ ] Go to a policy disable and enable some categories on behalf of the admin as copilot while in copilot mode
[ ] Go to new.expensify.com
[ ] Go to the #admins chat room for that same policy
[ ] Verify that the actions taken by the copilot show as from them, with their avatar, and the other user is referenced in a parenthetical (as copilot for XXXX)

Offline tests

QA Steps

Same as Tests
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Failing jest test due to removing  accessibilityLabel={props.translate('accessibilityHints.workspaceName')} after removing the TextPill

@0xmiroslav yes that covers most cases, the only ones I believe are missing are domain rooms and archived rooms.

I realized that I was using the pattern for Expense Requests on expense Reports, fixing that now!
(an expense request is also a thread)

That should do it,

let me know if you will get a chance to review or not @0xmiroslav

working on the tooltips now @0xmiroslav

Hoping to knock this one out today, just want to refactor the tooltip solution a bit

@0xmiroslav I've somewhat cleaned up the tooltips, if you have a chance to test this PR for any other outstanding bugs that would be fantastic!

@0xmiroslav fixed conflicts, would love to get this one in today!

@0xmiroslav if you're swamped right now, let me know- I can look for a volunteer

@0xmiroslav we made them the same for both admin and user in this PR -

@0xmiroslav yes, to show always same screen no matter whose view

@0xmiroslav could you link the custom avatar bug issue?

@0xmiroslav that was a pretty nasty merge could you help to QA this today? I'm also going to add test steps for copilot accounts

@0xmiroslav ready for review!

okay I lied I made a few minor clean up fixes, now it's ready for review!

Removing myself from this review to focus on other stuff as we already have other engineers here

Copilot issue seems to be unrelated, we can fix in another PR - https://github.com/Expensify/App/pull/20512#issuecomment-1622308490

@0xmiroslav if possible, yes. I'm retesting locally now and so far looks good. I'll ping some engineers that are online to push this through if the code and tests look good to prevent getting slowed down by more merge conflicts.

Fixed merge conflicts, @0xmiroslav let's try to get this merged today?

@0xmiroslav bump on final review if possible

Sorry, I'm still focusing and won't review this

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Hey guys this PR rolled back https://github.com/Expensify/App/issues/21099 The default params can still be used in the first if, practically just copying the implementation of this PR. With the new refactor only "defaultAccountID" would be required.
cc @chiragsalian @grgia

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.3.39-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.39-11 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add trace tests

This PR also adds a new assert_no_line_text test assertion helper.

@ko1 I happen to found another bug caused by https://github.com/ruby/debug/commit/e4365550b48ca715ab1a1552afa3c4af5338f9b4 and fixed it in https://github.com/ruby/debug/pull/101/commits/9b68b0e0dc91d236141c7b9ad60371cb2384ac6b

@ko1 ah sorry I think it's because I forgot to compile the extension 🤦


Provision to set memory and cpu limits for forwarder and runner

Please add support to add memory and cpu limits and requests in the values.yaml. Otherwise they are getting killed with OOM frequently in our cluster. After every change, I had to manually edit the deployments and increase the memory.

Got it: kubewatch.resources.requests.memory


Build my own model and add it to the models in your package

If I want to build my model and benefit from your code capability to learn or predict images with different  sizes

The library was built mainly to work with existing models from other packages.
You can use the procedure below to add your own model, but I am not sure that it will work correctly with all edge cases.

Import required modules:

import torch
import torch.nn as nn

from cnn_finetune import make_model
from cnn_finetune.base import ModelWrapperBase
from cnn_finetune.shims import no_grad_variable
from cnn_finetune.utils import product

Make your own model, but without a global pooling layer, without dropout, and without a classifier, for example:

class MyCnn(nn.Module):

    def __init__(self):
        super(MyCnn, self).__init__()
        self.layer1 = nn.Sequential(
            nn.Conv2d(3, 16, kernel_size=5, stride=1, padding=2),
            nn.BatchNorm2d(16),
            nn.ReLU(),
            nn.MaxPool2d(kernel_size=2, stride=2))

        self.layer2 = nn.Sequential(
            nn.Conv2d(16, 32, kernel_size=5, stride=1, padding=2),
            nn.BatchNorm2d(32),
            nn.ReLU(),
            nn.MaxPool2d(kernel_size=2, stride=2),
        )

    def forward(self, x):
        out = self.layer1(x)
        out = self.layer2(out)
        return out

Make a wrapper for the model above:

class MyCnnWrapper(ModelWrapperBase):

    # This model name will be used in a `make_model` call.
    # You can use any unique identifier.
    model_names = ['mycnn']

    def get_original_model(self):
        return MyCnn()

    def get_features(self, original_model):
        return original_model

    def get_classifier_in_features(self, original_model):
        # This method returns the number of input features for classifier.
        input_size = self.input_size or (224, 224)
        with no_grad_variable(torch.zeros(1, 3, *input_size)) as input_var:
            self.eval()
            output = self.features(input_var)
            if self.pool is not None:
                output = self.pool(output)
            self.train()
            return product(output.size()[1:])

Make a new model with cnn_finetune.

model = make_model('mycnn', num_classes=19)
Note that if the definition of MyCnnWrapper is located in another module you first need to import MyCnnWrapper  so it will register a model with the name mycnn in a global model registry.
from cnn_finetune import make_model
from .some_module import MyCnnWrapper

model = make_model('mycnn', num_classes=19)


Replace OAS/Swagger types with Node module

Instead of relying on our own types, we should consider using an NPM module such as this.
This will reduce the likelihood of mistakes, such as with #345 and #346, as well as help us stay up to date.

I agree, switching to a type package would be best.


Fix Last Agones Test From Refactor

In #909 one of the tests not working, is one of the agonies integration tests, to reduce merge conflicts and divergence, we merged with this disabled, but we should re-enable it as soon as possible.

Fixed in #914


Menu Code?

What is your question?
is there a way i could make it so that when i type in a sequence of letters (ex. FUNK), it opens a song? (in lua)

Lua scripts aren't loaded in menus

sad


Fix argument escaping for scp on Windows

This seemed to work when I tested it on Windows. Sources:

https://github.com/golang/go/issues/15566
https://stackoverflow.com/questions/28954729/exec-with-double-quoted-argument

Fixes #4302
cc @dgageot

LGTM

@shin- thanks for fix. When do you plan to make new release?
Can I somewhere download CI build for Windows-x86_64 ?
Thanks

Any idea on when this fix is going to be pushed to the official docker tutorial?
https://docs.docker.com/toolbox/toolbox_install_windows/
docker-machine scp still cannot be used.

In the next release.
You can also install the new RC manually in the meantime: https://github.com/docker/machine/releases/tag/v0.14.0-rc1


Add Inovelli vzm31-sn and vzm35-sn wwst drivers

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey @InovelliUSA Thank you for your PR!
For WWST Devices, we ask that you propose changes withen the existing SmartThings Edge Drivers. We do not permit WWST devices to submit whole new drivers. Could you please adjust this PR?
Please feel welcome to review this page, and the linked page for more information on common expectations for submission.  https://developer.smartthings.com/docs/certification/apply-for-certification

We will make a new PR.


timer: fix Reset link in Timer.Reset doc comment

Noticed when reading https://pkg.go.dev/time#Timer.Reset
PS. I also noticed improper links in https://pkg.go.dev/time#hdr-Monotonic_Clocks, but I would rather create a separate PR for it.


Add SOV token to users MM watch list

Metamask now allows dapps to suggest adding new tokens to the wallet asset watchlist:
ethereum.request({
  method: 'wallet_watchAsset',
  params: {
    type: 'ERC20',
    options: {
      address: '0xb60e8dd61c5d32be8058bb8eb970870f07233155',
      symbol: 'FOO',
      decimals: 18,
      image: 'https://foo.io/token-image.svg',
    },
  },
});

https://docs.metamask.io/guide/rpc-api.html#wallet-watchasset

The same case as with https://github.com/DistributedCollective/Sovryn-frontend/issues/1027 - this will open a Metamask dialog with a request so it should be done only after a user action. What is the proposed flow @t-z-u ?

This can be work on once we have a new Portfolio page design.

Migrated to Taiga in https://taiga.sovryn.app/project/sovryn-light/us/168


Hidden files & folders doesn't update until page refreshed

Describe the bug
When hidden files & folders are enabled, and you turn that switch off and return to your files, you still see the hidden files until you refresh the page.
To Reproduce
Steps to reproduce the behavior:
1.Turn on "Show hidden files and folders".
2. Make sure you have some hidden files and folders, and open the location that contains them.
3. Return to settings, and turn off "Show hidden files and folders".
4. When you return to your files, the hidden files do not disappear until the page is refreshed.
Expected behavior
I expected the hidden files to disappear again when the setting was off, without me having to manually refresh it.
Screenshots
https://user-images.githubusercontent.com/76794507/103796096-cdf6be80-5014-11eb-9550-87ec6f3f998f.mp4
Desktop (please complete the following information):

OS Version: Windows 10 Version 20H2 (OS Build 19042.685)
App version: <IP_ADDRESS>

Additional context
Even after restarting the app, the issue is still present.
Log file
debug.txt
debug_fulltrust.txt

Duplicate of #2857

Duplicate of #2857


mtl files don't make any effect on obj files

[ x ] Review the documentation: https://docs.viromedia.com/
[ x ] Search for existing issues: https://github.com/viromedia/viro
[ x ] Use the latest ViroReact release: https://docs.viromedia.com/docs/releases

Environment
Development OS: Windows
Device OS & Version: Windows 10 Home 64-bit
Version: ViroReact 2.17.0 and React Native 0.59.9
Description
I'm trying to render 3D Objects (.obj files) and using their materials (.mtl files) but the materials are not rendering properly. For example: the 3d model of the tent object looks like this:

but when it is rendered at the AR Scene, it looks like this:

Also, the tree object has green and brown materials, and renders black.
Reproducible Demo
Let me share my code:
'use strict';

import React, { Component } from 'react';

import { StyleSheet } from 'react-native';

import {
  ViroARScene,
  ViroText,
  ViroConstants,
  ViroBox,
  ViroMaterials,
  Viro3DObject,
  ViroAmbientLight,
  ViroSpotLight,
  ViroARPlaneSelector,
  ViroNode,
  ViroAnimations,
  ViroARTrackingTargets,
  ViroARImageMarker,
  ViroSphere,
  ViroQuad
} from 'react-viro';

export default class MainSceneAR extends Component {

  constructor(props) {
    super(props);

    // Set initial state here
    this.state = {
      texture: "orange_mtl",
      animateScene: false,
      email: props.sceneNavigator.viroAppProps.email
    };

    // bind 'this' to functions
    this._onAnchorFound = this._onAnchorFound.bind(this);
    this._onError = this._onError.bind(this);
  }

  render() {
    return (
      <ViroARScene>
        <ViroARImageMarker
          target={"holidayCard"}
          onAnchorFound={this._onAnchorFound}
          pauseUpdates={this.state.pauseUpdates}
        >
          <ViroNode>
            <Viro3DObject
              source={require("../assets/objects/tree/Tree.obj")}
              resources={[require("../assets/objects/tree/Tree.mtl")]}
              lightReceivingBitMask={3}
              type="OBJ"
              scale={[0,0,0]}
              position={[-.0338,0,-.0399]}
              materials={ "green_mtl" }
              animation={{ name:"scaleBig", run: this.state.animateScene }}
            />
          </ViroNode>

          <ViroNode>
            <Viro3DObject
              source={require("../assets/objects/tree/Tree.obj")}
              resources={[require("../assets/objects/tree/Tree.mtl")]}
              lightReceivingBitMask={3}
              type="OBJ"
              scale={[0,0,0]}
              position={[-.0740,0,.0436]}
              materials={ "green_mtl" }
              animation={{ name:"scaleBig", run: this.state.animateScene }}
            />
          </ViroNode>

          <ViroNode>
            <Viro3DObject
              source={require("../assets/objects/tree/Tree.obj")}
              resources={[require("../assets/objects/tree/Tree.mtl")]}
              lightReceivingBitMask={3}
              type="OBJ"
              scale={[0,0,0]}
              position={[-.0767,0,-.0509]}
              materials={ "green_mtl" }
              animation={{ name:"scaleMedium", run: this.state.animateScene }}
            />
          </ViroNode>

          <ViroNode>
            <Viro3DObject
              source={require("../assets/objects/tree/Tree.obj")}
              resources={[require("../assets/objects/tree/Tree.mtl")]}
              lightReceivingBitMask={3}
              type="OBJ"
              scale={[0,0,0]}
              position={[.0774,0,-.0490]}
              materials={ "green_mtl" }
              animation={{ name:"scaleMedium", run: this.state.animateScene }}
            />
          </ViroNode>

          <ViroNode>
            <Viro3DObject
              source={require("../assets/objects/tree/Tree.obj")}
              resources={[require("../assets/objects/tree/Tree.mtl")]}
              lightReceivingBitMask={3}
              type="OBJ"
              scale={[0,0,0]}
              position={[.0433,0,.0531]}
              materials={ "green_mtl" }
              animation={{ name:"scaleMedium", run: this.state.animateScene }}
            />
          </ViroNode>

          <ViroNode>
            <Viro3DObject
              source={require("../assets/objects/tent/Tent.obj")}
              resources={[require("../assets/objects/tent/Tent.mtl")]}
              lightReceivingBitMask={3}
              type="OBJ"
              scale={[0,0,0]}
              position={[.0379,0,-.0160]}
              rotation={[0,0,0]}
              // materials={ "white_mtl" }
              animation={{ name:"scaleTent", run: this.state.animateScene }}
              onError={this._onError}
            />
          </ViroNode>

          <ViroSpotLight
            innerAngle={5}
            outerAngle={60}
            direction={[1,-1,-1]}
            position={[-1,3,3]}
            color="#ffffff"
            castsShadow={true}
            shadowMapSize={2048}
            shadowNearZ={2}
            shadowFarZ={7}
            shadowOpacity={.2}
            intensity={100}
          />

          <ViroQuad
            rotation={[-90, 0, 0]}
            position={[0, 0, 0]}
            width={.3} height={.3}
            arShadowReceiver={true}
          />

        </ViroARImageMarker>
      </ViroARScene>
    );
  }

  _onAnchorFound() {
    this.setState({
      animateScene: true
    })
  }

  _onError(event) {
    console.log(event.nativeEvent.error);
  }
}

ViroARTrackingTargets.createTargets({
  holidayCard: {
    source: require("../assets/anchors/HolidayCard.png"),
    orientation: "Up",
    physicalWidth: 0.18 // real world width in meters
  }
});

ViroMaterials.createMaterials({
  green_mtl: {
    diffuseColor: "#0B6623",
    lightingModel: "PBR"
  },
  white_mtl: {
    diffuseColor: "#FFFFFF",
    lightingModel: "PBR"
  }
});

ViroAnimations.registerAnimations({
  scaleBig: {
    properties:{scaleX:.01, scaleY:.015, scaleZ:.01,},
    duration: 1000, easing: "bounce",
    delay: 1000
  },
  scaleMedium: {
    properties:{scaleX:.008, scaleY:.012, scaleZ:.008,},
    duration: 800, easing: "bounce",
    delay: 1200
  },
  scaleTent: {
    properties:{scaleX:.00025, scaleY:.00025, scaleZ:.00025,rotateY:"-235"},
    duration: 500, easing: "bounce",
    delay: 2500
  },
  scaleSign: {
    properties:{scaleX:.012, scaleY:.012, scaleZ:.012,},
    duration: 1000, easing: "easein",
    delay: 3000
  }
});

module.exports = MainSceneAR;

Also, I can provide you a drive url to download the models:
https://drive.google.com/open?id=1lR60-3zZ5AQc7C_s7c9Pi_yWk1i2DHVA
Please, let me know if there is something I can do to help or if you have any answer! Thanks in advance!

Update: it only happens when I render objects from an AR Marker, if I render the object without that (like the Hello World Scene), it renders properly

Second update: days ago (I was working without taking the color problem as priority) I noticed that intensity={100} is a low value for my spotlight at the distance it is. I adjusted these value gradually above 2500 to apreciate correctly the colors and materials. An .obj file works perfectly, just you (anyone who is reading this for an issue) be sure that the .mtl file has well defined all the textures.


Change the time inputs' type from 'text' to 'number` to support mouse scroll

So we can change the number by scrolling up & down .
For better experience, please !
Your Environment

flatpickr version used: 4.3.2
Browser name and version: lastest Chrome
OS and version: win10

@howareyouo scrolling will be re-added in #1291


Text in groupbar titles are not scaled

Hyprland Version
 System/Version info
Hyprland, built from branch HEAD at commit 84ab8d11e8951a6551d1e1bf87796a8589da6d47  (props: bump ver to 0.35.0).
Date: Mon Feb 5 01:59:02 2024
Tag: v0.35.0

flags: (if any)

Bug or Regression?
Bug
Description
#3851 appears to be fixed (titles used to render completely wrong on 0.32.0), however titles still render in a tiny font despite scale > 1 being set for the output.
Note that changing the font size isn't a fix because it doesn't play well with multiple monitors.
How to reproduce

Set monitor scale > 1 in hyprland.conf
Start a tabbed group
Observe little baby text

Crash reports, logs, images, videos

Since #4640 fixed this, I'm closing it.


possible to change or add arguments for kubelet?

possible to add additional startup arguments for kubelet? such as "--provider-id=XXXXX" and "--hostname-override=XXXXX"?

This can be done through the RKE config. It is currently only possible through the rancher API. You can even do it through the API web UI if you specify that gke, aws and azure configs are null.
Here is the config we are currently using for istio 0.8.0 support:
  "addonJobTimeout": 30,
  "authentication": { "strategy": "x509", "type": "/v3/schemas/authnConfig" },
  "authorization": { "type": "/v3/schemas/authzConfig" },
  "bastionHost": { "sshAgentAuth": false, "type": "/v3/schemas/bastionHost" },
  "cloudProvider": { "type": "/v3/schemas/cloudProvider" },
  "ignoreDockerVersion": true,
  "ingress": { "provider": "nginx", "type": "/v3/schemas/ingressConfig" },
  "kubernetesVersion": "v1.10.1-rancher2-1",
  "network": {
    "flannelNetworkProvider": {
      "iface": "",
      "type": "/v3/schemas/flannelNetworkProvider"
    },
    "plugin": "flannel",
    "type": "/v3/schemas/networkConfig"
  },
  "services": {
    "etcd": {
      "extraArgs": { "election-timeout": "5000", "heartbeat-interval": "500" },
      "snapshot": false,
      "type": "/v3/schemas/etcdService"
    },
    "kubeApi": {
      "podSecurityPolicy": false,
      "extraArgs": {
        "admission-control":
            "ServiceAccount,NamespaceLifecycle,LimitRanger,PersistentVolumeLabel,DefaultStorageClass,ResourceQuota,DefaultTolerationSeconds,MutatingAdmissionWebhook,ValidatingAdmissionWebhook",
        "runtime-config": "admissionregistration.k8s.io/v1alpha1"
      },
      "type": "/v3/schemas/kubeAPIService"
    },
    "kubeController": {
        "type": "/v3/schemas/kubeControllerService",
        "extraArgs": {
        "cluster-signing-cert-file": "/etc/kubernetes/ssl/kube-ca.pem",
        "cluster-signing-key-file": "/etc/kubernetes/ssl/kube-ca-key.pem"
        }
    },
    "kubelet": { "failSwapOn": false, "type": "/v3/schemas/kubeletService" },
    "kubeproxy": { "type": "/v3/schemas/kubeproxyService" },
    "scheduler": { "type": "/v3/schemas/schedulerService" },
    "type": "/v3/schemas/rkeConfigServices"
  },
  "sshAgentAuth": false,
  "type": "/v3/schemas/rancherKubernetesEngineConfig"
}

This is covered in https://github.com/rancher/rancher/issues/13076.
See above comment, https://gist.github.com/superseb/0c5e4015985f470853f0a74427c306c7, or https://github.com/JasonvanBrackel/metrics-server-on-rancher-2.0.2 for more examples how to do it until a version is released with #13076

@superseb
thanks for your reply, it works for a static value of extra arguments, but how can i set a expression for the hosts? in my example, provider-id could be a hostname of the host.


Trigger screen actions with a click of a button by using the Action Button component

Ticket included : AVEBLOG107
Issue : Trigger screen actions with a click of a button by using the Action Button component
Cause : N/A
fix: N/A

Looks good

Merge on hold due deployment issues


Nala CI/CD Debugging

added debug.yml workflow to provide on-demand execution only for HTML reporting results from playwright test executions for specific branches and tags.  The report artifact is uploaded to GitHub actions and can be downloaded to be used against Playwright's Trace Viewer
added reporter variable to debug.yml workflow
added reporter variable setting to run.sh, the execution can use the HTML reporter if desired, otherwise, it will use the test suite's default reporter set in playwright config.

Resolves: MWPW-122172

For a debugging execution from the branche's changes can be seen here: Run Nala Debugging #11


add call/2..8

#144

Codecov Report

Merging #156 (ffa11ff) into main (6f7937c) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   93.90%   93.99%   +0.08%
==========================================
  Files          18       18
  Lines        5281     5360      +79
==========================================
+ Hits         4959     5038      +79
  Misses        272      272
  Partials       50       50

Impacted Files
Coverage Δ

engine/builtin.go
91.39% <100.00%> (+0.16%)
:arrow_up:

engine/vm.go
82.64% <100.00%> (+1.67%)
:arrow_up:

interpreter.go
92.61% <100.00%> (+0.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f7937c...ffa11ff. Read the comment docs.


[EBPF] Fix API key for tagging KMT cleanup jobs

What does this PR do?
Fixes a missing call to obtain the DD_API_KEY variable for tagging KMT cleanup jobs
Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Update myip extension

Description

Remove axios, rewritten fetch using node-fetch & @raycast/utils
Bugfix where ip lookup was not working properly (#11290)
Updated dependencies

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Thanks for the rewrite, for me it works as expected 🔥
@kkange can you check this?

The code has been nicely enhanced. That's excellent.
I do have a question though. I understand that https://api64.ipify.org/ is considered a Universal API that supports both IPv4 and IPv6 simultaneously. Is there a reason why it was divided into two separate APIs?
It's possible that it's just a temporary issue, but in my environment, I'm unable to connect to https://api.ipify.org/ and receive error messages.

@j3lte could you check the review from @kkange

@kkange I checked apify docs, you're right. API64 is the universal one. I'll remove the dedicated ipv4 and update the PR

Could you check it again @kkange 🙂

It works perfectly. Thank you 😀


Deploying WebJob that references another WebJob

I have two WebJob projects, one project references the other one. When I attempt to deploy with MSBuild, it tries to deploy both. Because they go to different App Services, the password I use doesn't work for the other WebJob that's getting deployed, so things fail.
When I deploy via Visual Studio, it looks like it's only deploying one. When I do it from MSBuild via a command, it tries to deploy both. Is there something in the targets that allows me to only deploy one. How is it that VS only deploys the correct one? (I also just became aware that I need a run.cmd in order to run the correct executable, but I still need to figure out deployment).
I'm planning on creating a shared library project to combine things, but until then, what are my options?

Given the nature of question (VS related - not Kudu specific), you might get faster/better responses posting to http://aka.ms/webappMSDNforumq.

Hi
If the problem persists and is related to running it on Azure App Service, please open a support incident in Azure:
https://learn.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request
This way we can better track and assist you on this case
Thanks,
Joaquin Vano
Azure App Service


Update UMD support

Update UMD support to address #11

Hey @getfatday,
thanks a lot for your contribution! :+1:
Although this PR is described as "Update UMD support" it looks more like a major rewrite of the whole thing. I'd like @MadMG to give his thoughts about it before we merge it - I hope you understand :smiley:

@herom no problem. Let me know what you think.

Closing because of too many changes (would be a complete rewrite which is not necessary in order to achieve the solution) and because of the (too long) time in between the opening of this PR and a clear decision. sorry.


fix(core): animation doesn't working

vitepress blocks the animation and transition, so you need add !important to animation cover it./* node_modules/vitepress/dist/client/theme-default/styles/base.css */
@media (prefers-reduced-motion: reduce) {
  *, ::before, ::after {
    animation-delay: -1ms !important;
    animation-duration: 1ms !important;
    animation-iteration-count: 1 !important;
    background-attachment: initial !important;
    scroll-behavior: auto !important;
    transition-duration: 0s !important;
    transition-delay: 0s !important;
  }
}

keyframes names are always keyframes causing later keyframes to be overwritten.

Thx, I will review the pr later

I think using cssString as map key is not a good idea. Pass keyframe name may be better. See core/helper/keyframes.ts and replace the string keyframes to the var of keyframeName

How do you think the keyframe name should be passed?
Such as?
// core/helper/keyframes.ts
export function keyframes(kfString: TemplateStringsArray): string {
  const keyframeName = `kf-${generateUniqueName()}`
  injectStyle(`keyframes-${keyframeName}`, ...)
  // ...
}

// core/utils/injectStyle.ts
function insert(className: string, cssString: string) {
  // ...
  if (className === 'global' ||  /$keyframes-/.test(className)) {
    rule = cssString
  }
  // ...
}

Just passing name directly.
// core/helper/keyframes.ts
export function keyframes(kfString: TemplateStringsArray): string {
  const keyframeName = `kf-${generateUniqueName()}`
  injectStyle(keyframeName, ...)
  // ...
}

// core/utils/injectStyle.ts
function insert(className: string, cssString: string) {
  // ...
  if (className === 'global' ||  /^kf-.+/.test(className)) {
    rule = cssString
  }
  // ...
}

Changes has been made.
Suggest creating a discord channel to communicate in real time.

Changes has been made.
Suggest creating a discord channel to communicate in real time.

Great! And I will create the channel tonight.


EWS Java Connection Getting Refused Intermittently

Hi - We have a email client which connects to Exchange Server. The email client has been designed to be in-sync with exchange using ews-java-api 2.0. The email is connected to shared folder inbox. We do not find any major issue as per normal behaviour.
It is so happening sometimes, once-twice a day, the connection is getting refused with exchange. Not sure why is this happening.
We initially thought, it might any exchange confiiguration issue, but treid and tested. The exchange is always 100% up, it is a organization wide used via clients like outlook, and don't find any connections issue and there is no issue in that.
Sharing the code snippet which is used to connect to exchange sahred folder:
if (strSharedFolderStatus.equals("t")){
//Data fetching from Inbox folder of Shared mailbox
String strSharedMailBoxCredential=propEmailConfiguration.getProperty("shared-mailbox-credential");
Mailbox sharemailbox = new Mailbox(strSharedMailBoxCredential);
itemsChanged = eService.syncFolderItems(new FolderId(WellKnownFolderName.Inbox,sharemailbox), PropertySet.FirstClassProperties, null, 1, SyncFolderItemsScope.NormalItems, sSyncState);
}
else{
//Data fetching from normal inbox folder
itemsChanged = eService.syncFolderItems(new FolderId(WellKnownFolderName.Inbox), PropertySet.FirstClassProperties, null, 1, SyncFolderItemsScope.NormalItems, sSyncState);
}
Sharing the exception message:
2016-11-03 11:35:15,505 [pool-1-thread-7] DEBUG (BasicHttpClientConnectionManager.java:288) - Releasing connection [Not bound]
2016-11-03 11:35:15,505 [pool-1-thread-7] DEBUG (ConnectionHolder.java:144) - Cancelling request execution
2016-11-03 11:35:15,506 [pool-1-thread-7] INFO  (EmailSynchronizer.java:839) - -->> Error message: The request failed. The request failed. Read timed out
Is this similar kind of issue faced by any other users, when sometimes in between, connection gets refused when it is already connected?
Any workarounds would be appreciated.

Any clue on this? Please let me know if further details are required.


nix: fix installCheckPhase crashes on Darwin

Description of changes
Ensure that OBJC_DISABLE_INITIALIZE_FORK_SAFETY=yes is set when starting the Nix daemon during tests, or the fetchurl.sh test will crash trying to initialize libcurl. This is happening since IPv6 support was enabled in https://github.com/NixOS/nixpkgs/pull/277471.
See also:

http://sealiesoftware.com/blog/archive/2017/6/5/Objective-C_and_fork_in_macOS_1013.html
https://github.com/NixOS/nix/pull/2674

Fixes nix build failure in staging-next #275620. https://hydra.nixos.org/build/245525336
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

thx. will need to be backported to staging-23.11 due to #277878


Use portable c_char instead of i8

Some architectures, such as ARM, use unsigned 8-bit integers to represent C char type.
In order to make the code work on architectures with both signed and unsigned chars, this PR replaces i8 by c_char in places where it corresponds to C char type.

That is correct. Thanks for the patch! I left one comment.

I believe this could be closed as #36 achieved the same goal.

Closing as suggested. Thanks for the patch nevertheless, @michaelsproul!


Improve clarity "mushy" looking rail lines at browser z=8 and 9

Style change requested
Current rail lines / casings in the primary "Historical" layer look mushed together at zoom=8 and 9.
See:
https://www.openhistoricalmap.org/#map=8/56.664/-3.685&layers=O&date=1903-12-26&daterange=1500-01-01,2023-12-31

The fact that there are rails that look quite different in different areas at this zoom make me wonder if some of these should be tagged differently (they are all just railway=rail, but I'm wondering if there's a treatment that can avoid this result, regardless of tagging.
Similar results on the "Railway" layer:

@natfoot @Luke04 @flha127

I can look into trying a different dashed pattern at this zoom, or other solution. Thanks for flagging this one

I think that #812 relates to this in some way, and also, maybe should remove patterns at mid-level zooms, possibly. Ultimately complex clustering of many "up and down/sharp turns' will result in "patterns disappearing".
The other option is to simplify line data further at mid-level and high zooms. TECHNICALLY cartographically and performance wise, this is also a good idea, but not sure of other implications

I can look into trying a different dashed pattern at this zoom, or other solution.

For short line segments it does sometimes help to start the dashes not with a dash but a gap, or half a gap. Not sure if that works here, but it could be worth a try

maybe patterns for major rail lines and no pattern for others? maybe at mid/low zooms (where rail is present) = remove pattern at that zoom level?
Maybe rail style = remove as many patterns. in Historical/Main, maybe just good to remove dash at mid zoom


How to cache external api requests

Hey,
what options do I need to set to cache external api requests?
In my application I'm making requests to the github api and I can't find any settings to cache these requests
Any help would be really appreciated!

Hi @lukemarsh.
There is no way at moment, because it's just not implemented yet.
Here is the issue for that: https://github.com/NekR/offline-plugin/issues/26

Thanks @NekR. Do you know when you will be looking into this?

I am not sure yet. It's kind of complex and has to be done right.
Meanwhile, you can write a bit of ServiceWorker by yourself to support it.
// config

new OfflinePlugin({
  ServiceWorker: {
   // Entry in your project, will be included into SW file
    entry: './sw-handler.js'
  }
})

// sw-handler.js

self.addEventListener('fetch', function(e) {
  if (event.request.url.match(IS_GITHUB_REGEXP)) {
    // cache it here in separate cache
  }
});

Thanks for getting back to me :)
I have set that up but the fetch event isn't being called. Have you got an example of this working?
cheers

@lukemarsh it supposed to work, I'll check tomorrow. Thanks for reporting.

@lukemarsh it works for me. It isn't called for URLs generated from webpack, but called for everything else.

Thanks. Can you show me an example?

It's few comments above: https://github.com/NekR/offline-plugin/issues/64#issuecomment-223949743

I saw that but the fetch event is never being called

Again. It works for me and for other people. We can continue this
conversation forever. I don't know what you in you project and you don't
show anything to help me figure it out.
On Jun 14, 2016 11:49 AM, "Luke Marsh"<EMAIL_ADDRESS>wrote:

I saw that but the fetch event is never being called
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NekR/offline-plugin/issues/64#issuecomment-225818561,
or mute the thread
https://github.com/notifications/unsubscribe/ABIlkTZTSxT4eL0k5vNRI1AEbEPGCU0xks5qLmsbgaJpZM4IuvPO
.

Apologies - I think we may have our wires crossed.
This is my setup:
https://github.com/lukemarsh/redux-boilerplate/blob/master/web/webpack/config.prod.js
https://github.com/lukemarsh/redux-boilerplate/blob/master/web/dist/sw-handler.js
is this correct?

In general seems fine. But why you use scope property? Here https://github.com/lukemarsh/redux-boilerplate/blob/master/web/webpack/config.prod.js#L43 it's not needed because it's deprecated and you already use publicPath. Here https://github.com/lukemarsh/redux-boilerplate/blob/master/web/webpack/config.prod.js#L35 it sets scope for ServiceWorker, but I doubt that ./ is valid value for it.
Other thing is that you set publicPath: '/static/' which makes SW operate in a /static/ scope (cannot access urls like /). Problem is that at a moment, publicPath is also affects SW/AppCache output files so runtime expects SW to live on /static/sw.js in your case. See here and that whole issue for more details: https://github.com/NekR/offline-plugin/issues/65#issuecomment-225567708
Also why your sw-handler.js lived in dist folder? I don't know your project structure, but it seems weird because it will be bundled into sw,js anyway.
I think that you have to 1) remove all scope props; 2) put sw-handler.js in your src dir (if putting it to dist dir was a mistake); 3) set publicPath to /; 4) use rewrites option to as described in #65 until issue with publicPath isn't fixed.
Feel free to ask other questions.

Thank you so much! Awesome :) I'm going to star this repo!

Here is possible API design for it: https://github.com/NekR/offline-plugin/issues/117
Can you take a look? Would you be okay with it?

Hi @NekR ,
Is there any update or new suggestions/advice in regards to this issue?
We are looking to use this library with our Angular SPA which calls our API on different host (setup for CORS) and would like to know if we should look into the adding the API to externals option and trying to get the configuration of preFetchRequest correct and working with our API


Add Linter Plugin for Hacking Linter

I'd like to see a plugin for OpenStack's Hacking linter:
https://github.com/openstack-dev/hacking
https://pypi.python.org/pypi/hacking/0.9.6

@utkonos This repo manages the shared linter, and if you have created a new linter let us know and we'll list it.
To request new linters to be created, the Sublime Text forum might be a better place: more people will see it and there is a better chance someone will come and create something for you.


Complicated macros are becoming a mess.

I am working on https://github.com/Bonemind/syringe/pull/3 and want to write cleaner code for crystal macros. As features to this library are added the more complicated a single macro will get. What are your suggestions to organize the macros better. Is there any way to separate the code into methods and or classes that are accessible?

@elliotize this might be a good post for the forum https://forum.crystal-lang.org/