Artificial differences seen in fluxsite results when openmpi is loaded

When working on issue #335 in CABLE, the associated benchcab simulations returned numerical precision differences in all variables for the fluxsite experiments, see here.
After investigation, it turns out this is due to loading openmpi when doing serial compilation.
Tests performed
Running benchcab with main and #335 branch returned differences in fluxsite outputs between realisations.
Running one of the tasks using a serial compilation of main and #335 branch done outside benchcab returned no differences between the outputs. These tests were done using the build.bash script from the CABLE repository and ensuring we loaded the same versions of netcdf and intel compiler modules. These outputs are identical to the outputs of main using benchcab.
It turns out if we compile CABLE, serially, using the build.bash script but loading an openmpi module (3 versions were tested), then the #335 branch gives slightly different results to the main branch. This happens even so the compilation does not use the openmpi module directly, it's probably a difference in some environment variable.
What do we want to do?
This is annoying as it may result in false negative results from benchcab.
Do we want to investigate further to identify where the difference in the environment actually is? Is that useful?
Do we want to fix that in benchcab? Would that mean only loading the necessary modules at compilation time or is there another solution?
@SeanBryan51 @bschroeter @abhaasgoyal @Whyborn mentioning you since I'd appreciate some discussion here.

Running one of the tasks using a serial compilation of main and #335 branch done outside benchcab returned no differences between the outputs. These tests were done using the build.bash script from the CABLE repository and ensuring we loaded the same versions of netcdf and intel compiler modules.

I wasn't able to reproduce this - I found differences in the output when building and running CABLE outside of benchcab.
I narrowed down the differences in output to the following commit: https://github.com/CABLE-LSM/CABLE/pull/346/commits/0a69346fc8ed8cda575ce612481bf3929ddea2a3.

This does not make any sense. The commit you highlighted changes the calculation of canopy%epot. This variable is only used for canopy%wetfac_cs which is not used in standalone, only in the coupled model. So changing the equation to calculate canopy%epot should not change the results at all in standalone!
And the potential evaporation (epot) was not part of the outputs before that branch so we should not see any differences in the outputs, except for the branch adds output for potential evaporation.

I tried running a debugger on the AU-Tum fluxsite configuration and I now seem to be getting floating point overflow error:
forrtl: error (72): floating overflow
Image              PC                Routine            Line        Source
cable<PHONE_NUMBER>B357D4  Unknown               Unknown  Unknown
libpthread-2.28.s  00007FFFEC28DD20  Unknown               Unknown  Unknown
cable<PHONE_NUMBER>717C6D  cable_canopy_modu         497  cable_canopy.F90
cable<PHONE_NUMBER>6BC2FE  cable_cbm_module_         169  cbl_model_driver_offline.F90
cable<PHONE_NUMBER>41864D  MAIN__                    798  cable_driver.F90
cable<PHONE_NUMBER>40CBA2  Unknown               Unknown  Unknown
libc-2.28.so       00007FFFEBEDF7E5  __libc_start_main     Unknown  Unknown
cable<PHONE_NUMBER>40CAAE  Unknown               Unknown  Unknown

Still not sure if this is related to the original problem, investigating further.

Investigating the above error further, I found that the debug build and release build in the main branch are not bit reproducible in model output for fluxsite tests (tested with commit https://github.com/CABLE-LSM/CABLE/commit/860094b).
The floating point overflow errors were due to uninitialised variables: 1. canopy%DvLitt and 2. sum_rad_gradis. Fixing 1 does not change results. Fixing 2 does change results (see https://github.com/CABLE-LSM/CABLE/issues/351).
Fixing the floating point errors restores bit reproducibility between release and debug builds. Applying the fix to commits 860094b and 0a69346 and doing a comparison shows that the two commits now only differ in model output w.r.t the PotEvap variable which is expected.


Parallax Effect Bug.

Bopbi,
in your source code you set matrix.postTranslate in both adapter and activity,
in my practice it will results unexpected background positions.

this only happens on using toolbar instead of actionbar.

hmm i create this before L / Lollipop exist, so should i update it with latest libraries, by using recyclerview and toolbar
or should i create another project? what do you suggest

Clarify the bug again:
Let say I set list item height in xml 230dp, when i continue scrolling the listview without finger up, then down, the item imageviews cannot translate back to the original position, therefore, it looks like a gap between two list item.
I think it is due to visible position in listview,
int first = ListView.getFirstVisiblePosition();
int last = ListView.getLastVisiblePosition();
or using the invalidate() method for imageview
this is another maybe solution to calculate the translation for imageview.
link

hmm based on your suggested link, previously i have try that way and it has performance issue, that is why i create custom listener and also set the translation on the adapter.
anyway thanks for the suggestion, i am never tested it when the listview item is quite high
Currently i am try to refactor this lib, hopefully i come with a better solution

bopbi, dont close this issue until it got solved.
And I will work on my side to see the Soundcloud sc.

anyway the reason i set the image matrix on the adapter is to make the the moved image is set to center so the border effect could be minimalized

after searching around it seems to handle the scroll value by using the recyclerview scroll listener
https://developer.android.com/reference/android/support/v7/widget/RecyclerView.OnScrollListener.html#onScrolled(android.support.v7.widget.RecyclerView, int, int)
public void onScrolled (RecyclerView recyclerView, int dx, int dy)
Callback method to be invoked when the RecyclerView has been scrolled. This will be called after the scroll has completed.
Parameters
recyclerView	The RecyclerView which scrolled.
dx	The amount of horizontal scroll.
dy	The amount of vertical scroll.


Rendering markings

The geojson output like this is a nice start, but at some point, I'd like also to put a proper API around the rendering that A/B Street does. That would include different lane dash markings, icons for bus/cycle lanes, and turn arrows.
Desired output
What should the output of this render API be? We'll want to draw it, but probably in different ways. GeoJSON with attributes for color are a lightweight option, and we've got code to generate polygons for things like dashed lines if needed. SVG as output could make more sense. To keep using the code in A/B Street itself, I'd want to keep using GeomBatch (a list of triangulated polygons with a color) for performance and not have a bunch of extra translation layers.
Option 1
Incrementally change the current A/B Street code to have the desired API. https://github.com/a-b-street/abstreet/blob/master/map_gui/src/render/lane.rs has most of the current logic (and it's a mess, of course). But there'd be complications with expressing this code on top of RawMap... the rendering is written on top of a "higher-level" Map struct, where things like turns between lanes are defined. Another limitation with the current code is styling -- there's not many locale specific overrides yet for things like dash color/style.
Option 2
Start writing something from scratch, using existing code as reference when useful. I think this makes much more sense, especially since some of the problems mentioned above are already being solved at the osm2lanes layer. The output already includes separators that have both semantic and visual descriptions.
I would still want to cut A/B Street code over to this new rendering, and that means I have to think through how to make the final Map structure look like a RawMap, but I'm not too worried about that yet -- this is a good opportunity for me to think through the difference between those two representations and maybe make the street network part, at least, be a little closer to each other.
Users

A/B Street
the test browser
a "soon"-to-exist web app that dynamically fetches OSM data from Overpass in an area, pipes through osm2streets, and renders on the slippy map

And also @wxinix expressed interest in building a traffic signal tool on top of some of this. If we had an API that took some area you select from OSM and handed back geometry and rendering, what form would you want the image to be (GeoJSON, SVG, something else)?

SVG is perfect for me.  GeoJSON is also great. But which not just make both available as the API option, and let the user decide at runtime what format to generate?

SVG is perfect for me. GeoJSON is also great. But why not just make both format available as the API option, and let the user decide at runtime what format to generate?

I like SVG as the "native" output, because we can use svg css to describe the specifics for different locales.
It can be translated into lots of other formats

GeoJSON for people who want to work with it,
vector tiles in .pbf for vector tile maps,
raster tiles in .png (with transparency) for backward compatibility with existing maps.

A/B Street
the test browser
a "soon"-to-exist web app that dynamically fetches OSM data from Overpass in an area, pipes through osm2streets, and renders on the slippy map
Number 3 should be built into the test browser :P

To keep using the code in A/B Street itself, I'd want to keep using GeomBatch (a list of triangulated polygons with a color) for performance and not have a bunch of extra translation layers.

I suppose "native" svg should not be the goal, but "in svg terms", so css can be the code that describes a specific marking. Rust to GeomBatch would be an optimised route, and generating svg markup would be a to_svg(). GeoJSON is where we need to think about how to "segmentize" our curves into line segments (high-ish resolutions might give us really nice results).

I would still want to cut A/B Street code over to this new rendering, and that means I have to think through how to make the final Map structure look like a RawMap.

Perhaps output to GeomBatch is among the first impls, and the RawMap renderer can be deprecated piece by piece as features are implemented.
A helpful first step would be bringing the reference geometry over to streets land (which involves choosing/setting up a geom import and a brief chat with the borrow checker). Then we can start rendering markings (from lanes etc.), asphalt areas (parking lots, anyone?), and debug output amounting to the kinds diagrams we would want in the README.

@wxinix, we've got this started enough for you to maybe use. Check out https://a-b-street.github.io/osm2streets/?test=seattle_triangle -- press Reimport to see all the detail. There are "geojson download" buttons for every layer.
This is callable through Javascript right now. I forget, did you want Python bindings ideally?

thank you.  I'll give it a try.   I use C++....
------ Original Message ------
From "Dustin Carlino" @.>
To "a-b-street/osm2streets" @.>
Cc "Wuping Xin" @.>; "Mention"
@.>
Date 8/16/2022 7:07:00 AM
Subject Re: [a-b-street/osm2streets] Rendering markings (Issue #24)

@.*** https://github.com/wxinix, we've got this started enough for

you to maybe use. Check out
https://a-b-street.github.io/osm2streets/?test=seattle_triangle --
press Reimport to see all the detail. There are "geojson download"
buttons for every layer.
This is callable through Javascript right now. I forget, did you want
Python bindings ideally?
—
Reply to this email directly, view it on GitHub
https://github.com/a-b-street/osm2streets/issues/24#issuecomment-1216486995,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABISKGA6E74JXDFM3II27GLVZNY5JANCNFSM5YQQ5DRA.
You are receiving this because you were mentioned.Message ID:
@.***>


Rot3's look_at should be static

Function in question: https://github.com/sebcrozet/nalgebra/blob/0e7116e3bbcbdf84d4d89f3e3d0e91c1f28b7046/src/structs/rot.rs#L191
This function does not require the previous state of the Rot3, and should be static. I am willing to make this static, but that'd require breaking the API.
Please greenlight this or provide an alternative.

I agree with your reasoning. look_at (as well as look_at_z) should be static and you are welcome to make this happen!

I'll get to it sometime this week hopefully.

PR: https://github.com/sebcrozet/nalgebra/pull/155

Related PR merged. Closing this issue.


Show changelog on update

Issue
auto update is very cool. There is opportunity to print changelog right there:
Newer aider version v0.54.8 is available. To upgrade, run:

/bin/python3.11 -m pip install --upgrade aider-chat
Run pip install? (Y)es/(N)o [Yes]:

Installing:  /bin/python3.11 -m pip install --upgrade aider-chat

Installation complete.

Re-run aider to use new version.

Changelog:
- item1
- item2

Version and model info
No response

Excellent suggest.  I would appreciate this.

In the meantime the changelog is also available here -> https://aider.chat/HISTORY.html

This has been available in recent versions.
I'm going to close this issue for now, but feel free to add a comment here and I will re-open. Or feel free to file a new issue any time.


WalletInfo dialog - bug/ux - Showing the network id means nothing to the user

At the moment, the dialog looks like this:

Seeing the network id tells me nothing as an end user.
Instead, I would like to see the network name (same as I see it on my metamask/other wallet).
In addition, showing the network icon (if you have it. Also talking about multichains support here) would make sense.
P.S:
Also at the moment it just says the word "Network" twice for no reason

Hello Kazaor,
There are a handful of networks that are listed and when the user is connected to one they see the human readable title of the network:

The network you see above is a testing or local network and will only be shown to developers running the service locally. We can add an alias for 1337 but which other networks are you interested in adding?

Ohh got it, my bad here :)
We're looking at also supporting:

Fantom Opera - 250
Fantom Opera Testnet - 4002
Arbitrum - 42161
Arbitrum Testnet (Rinkeby) - 421611
Polygon - 137
Polygon Testnet (Mumbai) - 80001

Would be great adding those :)


Jerky playback

I'm submitting a ...support request
I'm running the latest version of the addon
Description
I have an Amlogic 912 box running a Libreelec Leia build. I first tried with settings of inputstream set to max resolution but there was jerky playback. Now I have set everything to 720 and HEVC to off but yet the video is not smooth.
I´m using the Netflix Repo
Linux (ARM)
Debug Log - https://paste.ee/p/VkVHU

This has nothing to do with the plugin itself. I have an Amlogic 905X box and also the playback is jerky at 720p with the max bandwidth set to 4000000. So, if your box has Widevine L1 support, use Kodi on Android to get smooth 1080p playback like mine does.


When scene is reloaded after changing instance, ViewportTextures break

Godot version
4.2 eca6f0e
System information
Windows 10 x64
Issue description
https://github.com/godotengine/godot/assets/2223172/a2796263-4e2e-4b14-a080-b3ad034cc141
Steps to reproduce

Add SubViewport
Add Sprite2D
Set spirte's texture to ViewportTexture
Create new scene
Instance the new scene inside the scene with viewport
Make sure both scenes are opened
Go to instance scene and save it
Go to viewport scene

You will see error spam. Reloading the scene fixes it.
Minimal reproduction project
vip.zip

Again? 😩 Well I guess it's between you (https://github.com/godotengine/godot/pull/75751), @Rindbee (https://github.com/godotengine/godot/pull/77209, https://github.com/godotengine/godot/pull/78728), and maybe @RandomShaper if it's related to RID and core more than the editor.

Again?

This seems like new bug, different from all other issues (though not sure if it's a regression or something old).

Similar to #79176. But with different messages.

When I originally encountered the issue there was no errors about bindings (only the Viewport Texture must be set to use it. part). They appear only in the MRP for some reason.

If you make the Sprite2D outside the visible area, the error message just outputs Viewport Texture must be set to use it.

Not sure if it's related, but I'm currently struggling with Viewport Texture as well.
I'm using a SubViewport to render a ColorRect with a shader on it. The SubViewport texture is being fed to the UI theme to be used in a SyleboxTexture. It works great, then sometimes it will start throwing errors.
Here, you can see I get the ViewportTexture error as above even though it is set?

But then sometimes without even changing anything, just launching and closing the project, I get this instead:

And the way that I've discovered to "fix" it is to go to the StyleboxTexture, unassign the ViewportTexture, then reassign it. Then it works fine for the next 5 minutes.

(Yes, the background says mountain dew. I was testing a shader and needed a quick logo and was thirsty lmao)

@mikatomik Can you provide an MRP?  You seem to provide a ViewportTexture through the editor, and get one directly through the code.

But then sometimes without even changing anything, just launching and closing the project, I get this instead:

viewport_path is ., which seems a bit strange. Unless the scene root node is a Viewport.

@mikatomik Can you provide an MRP?  You seem to provide a ViewportTexture through the editor, and get one directly through the code.

Yeah, I should have removed that before posting the screenshot, I was trying to set it in code and see if it made a difference versus setting it in the editor. I saw on another viewport troubleshooting thread that some people fixed their issues by assigning in code.
I do not have an MRP on hand, but I can see if I can replicate it in one this evening.
Also, the root node in my scene is a CanvasLayer. The SubViewport is a direct child of that, and sibling to the GUI that's using it.


Survey popup for language server has wrong title text.

We created a feedback-popup for the new Language Server in VSCode-Python, but we missed ensuring a text string was correct (copy-pasta error on my part)!
From the design in #2127, the popup to request user feedback for the Language Server was supposed to be: Can you please take 2 minutes to tell us how the Python Language Server is working for you?. Unfortunately, this text was left as Can you please take 2 minutes to tell us how the Experimental Debugger is working for you?.
Environment data

VS Code version: 1.26.0-insider
Extension version (available under the Extensions sidebar): 2018.7.1 (seen in .0 as well)
OS and version: Windows 10
Python version (& distribution if applicable, e.g. Anaconda): 3.6.6 (seen in 3.7.0)
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): .venv
Relevant/affected Python packages and their versions: N/A

cc @brettcannon @qubitron


bug: ng add @ionic/angular@next throws error when add to Angular project (Angular 9 Ivy + Ionic RC4), have PR

Bug Report
Ionic version:
[x] 5 RC4
Current behavior:
With @next
ng add @ionic/angular@next --project=mobile throws the following error:
E:\my-workspace>ng add @ionic/angular@next --project=mobile
Installing packages for tooling via npm.
Installed packages for tooling via npm.
Could not find file for path: projects/mobile/projects/mobile/src/app/app.module.ts

With normal
ng add @ionic/angular --project=mobile throws the following error:
E:\my-workspace>ng add @ionic/angular --project=mobile
Installing packages for tooling via npm.
Installed packages for tooling via npm.
The package that you are trying to add does not support schematics. You can try using a different version of the package or contact the package author to add ng-add support.

Steps to reproduce:
ng new my-workspace --createApplication="false"
cd my-workspace
ng generate application mobile
ng add @ionic/angular --project=mobile

Thanks for the issue. I am unable to reproduce the behavior you are describing. These are the steps I am following:

Run ng new
Name the project "testProject"
Add Angular Routing.
Use CSS instead of a preprocessor.
cd testProject
ng add @ionic/angular@next --project=testProject.

Are these the correct steps to reproduce?

Thanks for the issue. This has been resolved via https://github.com/ionic-team/ionic/pull/20436 and will be available in an upcoming release of Ionic Framework.

thank you so much sir, have a good day sir

@liamdebeasi
ionic serve livereload has problem i think related to this as cordova.js not injected with flag --liverelaod
but if you build or run without it its injected
not sure should i make issue here or command line is right
https://github.com/ionic-team/ionic-cli/issues/4313

@mohamedsharaf I replied to your issue. Ionic 4 does not support Angular 9, please try with Ionic 5.

i can confirm its still exist same problem here is a public repo so u can test
https://github.com/mohamedsharaf/i5ng9
run
ionic cordova run ios -l


adding default display implementation for SimpleReason

A possible default Display implementation for SimpleReason(?)
Comes from https://github.com/zesterer/chumsky/issues/157

Thanks! Just one comment.

Thanks!


merge: dev to master

:tada: This PR is included in version 1.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


TransactionBuilder.CoinSelector can't be modified when calling WalletController.BuildTransaction

The code of StratisBitcoinFullNode is in majority well written to be modular, to allow developers to use it and customize its features without having to touch the original code using dependency injections, interfaces and other mechanisms.
However, I am trying to change the comportment of ICoinSelector when calling WalletController.BuildTransaction, but I can't find a way to do so without having to fork the project. TransactionBuilder have a SetCoinSelector method, but I can't access a pointer to the TransactionBuilder during the processing because it is a local variable and the methods that have access to it are not virtual.
IMHO, there should be a way to inject a custom ICoinSelector in this process, using a Factory injected, by example, or by making WalletTransactionHandler.InitializeTransactionBuilder protected virtual.

Yep, that's a great idea and something we've thought a lot about.
Somehow it didn't make it in the Wallet yet, but we'll try to address this soon.
Thanks @damien-r .

@majikandy @dangershony happy to grab this one if it fits in the next sprint

@damien-r this is a fairly simple change if you want to submit a PR that allows to inject a coin selector and uses the default if none is injected.
@bokobza WDYT


fix crash in postbuiltlint

This code crashes due to the unescaped curly braces--this fixes it

Thanks!

Also--is that suggestion even correct? Should it be vcpkg_install_copyright?

Also--is that suggestion even correct? Should it be vcpkg_install_copyright?

Yes, modernizing that would also be an improvement.


Make CodeOutline 🌟🌟🌟

Outline only appear on F# files and dynamically hide & show itself
Settings for outline are dynamic: Change your settings in another vscode windows and it refreshes live !
Settings for outline are workspace aware: Even with multiple workspaces open the setting for each will be respected in their files.

Ah and also when disabled it doesn't less an empty pane with buttons throwing errors ;)

(Require https://github.com/ionide/ionide-vscode-helpers/pull/18 )


wrong api link

The extension method in the sample app is different from the linked api page. I was trying to figure something unrelated out, and got confused. Strangely, the same thing occurs in another above link (https://docs.microsoft.com/en-us/dotnet/api/microsoft.extensions.options.iconfigureoptions-1) which is the wrong api but I didn't fix it because the autogenerated api doesn't have the correct extension method where it should [be] (https://docs.microsoft.com/en-us/dotnet/api/microsoft.extensions.dependencyinjection.optionsservicecollectionextensions.configure?view=aspnetcore-2.0&viewFallbackFrom=aspnetcore-2.1#Microsoft_Extensions_DependencyInjection_OptionsServiceCollectionExtensions_Configure__1_Microsoft_Extensions_DependencyInjection_IServiceCollection_System_Action___0__)

Thanks for flagging these @user135711 ... I'll review shortly.

The extension method in the sample app is different from the linked api page.

Yes, thank you @user135711 for the update.
Although this merged 🏃 FAST 🏃 :smile:, I'll take a look at the other instance you mention.


log4j

Hi i was attempting to publish a library that uses this library as a dependency. oss.sonatype.org send me a "lift" report that flagged this library as having a few security related issues. It looks like it's related to log4j 1.x.
Seeing this in the root pom
yes we know this is an issue but it is here for backwards compatibility

As a user of the library, can we exclude the log4j dependency and have the library still be functional?
Alternatively, is there a plan to use some other logging library or a newer version?

Sorry for the delay @spyhunter99 . The log4j dependencies should be marked as optional so it won't be used unless you provide it.  Is that not what you are seeing?

looks like that was cleared up. It's also complaining about this one

| CWE-89: Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection')
-- | --

[CWE-89: Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection')](https://ossindex.sonatype.org/vulnerability/a9c81f11-d02c-4b45-b55f-0eedd1786272?component-type=maven&component-name=com.j256.ormlite.ormlite-android&utm_source=ossindex-client&utm_medium=integration&utm_content=1.7.0)


Disable HDFS Plugins until SOFTWARE-3431 is fixed

This LGTM. Could you kick off a VMU run with just the HDFS plugins to make sure it works?

http://vdt.cs.wisc.edu/tests/20191022-1104/packages.html


ci: Add code quality workflow and linter configurations

Pull Request
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

#25  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JackPlowman and the rest of your teammates on  Graphite


Adding print exc

:tada: This PR is included in version 1.61.9 :tada:
The release is available on:

GitHub release
v1.61.9

Your semantic-release bot :package::rocket:


Update handling for EOF,ErrClosedPipe to hard return

After looking at cloudflare's apt-transport that behaves very similarly it seems like a hard return is the right way to handle EOF and ErrClosedPipe errors coming from the reader.
See here: https://github.com/cloudflare/apt-transport-cloudflared/blob/8fd3a7c4318a39b24d08b0fb62ed9983e1558aea/apt/method.go#L82-L85
Somewhat related; I needed this change plus a different binary name (see here) to get this transport to work under reprepro.

CLA submitted. Sorry that wasn't done ahead of time.

/approve

@amilstead Thanks for the PR, looks good. Can you update the tests for this change?

@amilstead Thanks for the PR, looks good. Can you update the tests for this change?

Sure! Will work on that sometime this week. Thanks!

@hopkiw just nudging here. Anything else I need to do?

Hi sorry, I just really don't have time to work on this. If someone else wants to pick up this PR and finish, please do.
All I can say is that this "works for me".


Consider no matching tests a failure

Hello,
I was running a test to watch it fail but it was not. It turns out I typed the test wrong. It seems like that if a test name is provided but not found it should be a failure or at least a warning.
cargo test test_something_that_is_typo
Thoughts?
Becker
Checked on version 0.7.0 and 0.9.0

Ah unfortunately Cargo doesn't have a lot of information in this regard, it just forward the argument test_something_that_is_typo to the underlying binary which chooses how to interpret it. Along those lines perhaps this issue would be more appropriate in rust-lang/rust against libtest?

thanks! I will move it.


Daemonset for Azure Storage

In the list of tags I cannot find a tag for Microsoft Azure Storage (Plugin fluent-plugin-azure-storage-append-blob).
Is my understanding correct that there is no fluentd-kubernetes-daemonset available on dockerhub supporting Microsoft Azure Storage?

Hi @andre2007, that's correct. I added this via #411 but at this point it's not clear if or when this is going to be available.

#411 is merged and the tag v1.11.1-debian-azureblob-1.0 is published.
Closing.

Fantastic, thanks a lot.

@andre2007 Please test this and get back to me since I'm using a modified version of the underlying plugin, thank you!

Currently I am between 2 releases and have to wait that the next release starts. I will test it and will come back to you. Thank you,


NetworkPolicy: unable to allow ingress by CIDR

Describe the bug
A NetworkPolicy which allows ingress traffic by an IPBlock/CIDR does not allow traffic from the IPBlock on a KinD cluster running antrea-0.12.0.
To Reproduce
Create a KinD cluster:
#!/usr/bin/env bash

set -xv
set -e

CLUSTER=${CLUSTER:-netpol-antrea}

if [[ ! -d antrea ]] ; then
  git clone https://github.com/vmware-tanzu/antrea.git
fi
pushd antrea
  git checkout v0.12.0
  pushd ci/kind
    ./kind-setup.sh create "$CLUSTER"
  popd
popd

netpol.yaml:

NOTE: the cidr is chosen so that the first three octets match the first three octets of the IP of at least one of the pods in the setup

apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: vary-ingress-28-0-0-0-10
  namespace: x
spec:
  ingress:
  - from:
    - ipBlock:
        cidr: <IP_ADDRESS>/24
    ports:
    - port: 80
      protocol: TCP
  podSelector:
    matchLabels:
      pod: a
  policyTypes:
  - Ingress

Create netpol and pods and run probe using Cyclonus:

download cyclonus 0.0.5
run probe using cyclonus_0.0.5 probe --noisy=true --policy-path netpol.yaml

Namespace/pods:
Namespace x

labels: {"ns": "x"}
pods:

pod a

labels {"pod": "a"}
ip: <IP_ADDRESS>

pod b

labels {"pod": "b"}
ip: <IP_ADDRESS>

pod c

labels {"pod": "c"}
ip: <IP_ADDRESS>
Namespace y

labels: {"ns": "y"}
pods:

pod a

labels {"pod": "a"}
ip: <IP_ADDRESS>

pod b

labels {"pod": "b"}
ip: <IP_ADDRESS>

pod c

labels {"pod": "c"}
ip: <IP_ADDRESS>
Namespace z

labels: {"ns": "z"}
pods:

pod a

labels {"pod": "a"}
ip: <IP_ADDRESS>

pod b

labels {"pod": "b"}
ip: <IP_ADDRESS>

pod c

labels {"pod": "c"}
ip: <IP_ADDRESS>

Expected
Expected connectivity matrix:
There are 9 pods, so 9x9 = 81 possible requests from pod to pod.
The pod issuing the request is in the left column; the pod receiving the request is in the top row.
An X means the request was denied; a . means the request was allowed.
+-----+-----+-----+-----+-----+-----+-----+-----+-----+-----+
|  -  | X/A | X/B | X/C | Y/A | Y/B | Y/C | Z/A | Z/B | Z/C |
+-----+-----+-----+-----+-----+-----+-----+-----+-----+-----+
| x/a | .   | .   | .   | .   | .   | .   | .   | .   | .   |
| x/b | X   | .   | .   | .   | .   | .   | .   | .   | .   |
| x/c | X   | .   | .   | .   | .   | .   | .   | .   | .   |
| y/a | .   | .   | .   | .   | .   | .   | .   | .   | .   |
| y/b | X   | .   | .   | .   | .   | .   | .   | .   | .   |
| y/c | X   | .   | .   | .   | .   | .   | .   | .   | .   |
| z/a | X   | .   | .   | .   | .   | .   | .   | .   | .   |
| z/b | X   | .   | .   | .   | .   | .   | .   | .   | .   |
| z/c | X   | .   | .   | .   | .   | .   | .   | .   | .   |
+-----+-----+-----+-----+-----+-----+-----+-----+-----+-----+

Actual behavior
Connectivity on kube/antrea:
+-----+-----+-----+-----+-----+-----+-----+-----+-----+-----+
|  -  | X/A | X/B | X/C | Y/A | Y/B | Y/C | Z/A | Z/B | Z/C |
+-----+-----+-----+-----+-----+-----+-----+-----+-----+-----+
| x/a | X   | .   | .   | .   | .   | .   | .   | .   | .   |
| x/b | X   | .   | .   | .   | .   | .   | .   | .   | .   |
| x/c | X   | .   | .   | .   | .   | .   | .   | .   | .   |
| y/a | X   | .   | .   | .   | .   | .   | .   | .   | .   |
| y/b | X   | .   | .   | .   | .   | .   | .   | .   | .   |
| y/c | X   | .   | .   | .   | .   | .   | .   | .   | .   |
| z/a | X   | .   | .   | .   | .   | .   | .   | .   | .   |
| z/b | X   | .   | .   | .   | .   | .   | .   | .   | .   |
| z/c | X   | .   | .   | .   | .   | .   | .   | .   | .   |
+-----+-----+-----+-----+-----+-----+-----+-----+-----+-----+

Versions:
Please provide the following information:

Antrea version: v0.12.0

KinD version 0.9.0

Kubernetes version:
 kubectl version
 Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.4", GitCommit:"d360454c9bcd1634cf4cc52d1867af5491dc9c5f", GitTreeState:"clean", BuildDate:"2020-11-12T01:08:32Z", GoVersion:"go1.15.4", Compiler:"gc", Platform:"darwin/amd64"}
 Server Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.1", GitCommit:"206bcadf021e76c27513500ca24182692aabd17e", GitTreeState:"clean", BuildDate:"2020-09-14T07:30:52Z", GoVersion:"go1.15", Compiler:"gc", Platform:"linux/amd64"}

Container runtime: containerd from KinD v0.9.0

Linux kernel version on the Kubernetes Nodes (uname -r): 4.19.121-linuxkit

Additional context

@mattfenwick Thanks for catching it!
This was caused by the non-standard CIDR <IP_ADDRESS>/24 used in the policy. Apparently K8s allows it, however, OVS rejects it and it was then ignored:
E0120 16:44:25.220545       1 entry.go:314] Received OpenFlow1.3 error: OFPBMC_BAD_WILDCARDS on message OFPT_EXPERIMENTER

I've made a quick fix #1767 for it.

@mattfenwick Thanks for catching it!
This was caused by the non-standard CIDR <IP_ADDRESS>/24 used in the policy. Apparently K8s allows it, however, OVS rejects it and it was then ignored:
E0120 16:44:25.220545       1 entry.go:314] Received OpenFlow1.3 error: OFPBMC_BAD_WILDCARDS on message OFPT_EXPERIMENTER

I've made a quick fix #1767 for it.

🎉 🎉 😄

🎉 🎉 😄


Add SQS keywords and tests

Added SQS keywords and related keyword tests
Updated docker-compose.yml file to support sqs tests

@samuelpcabral @paguilera  can you guys please review the changes. Thank you for the amazing work


JavaScript

JavaScript
User Story
As a boot camp student
I want the pre-work notes to be structured on a webpage
So that I can easily find and read the information
Acceptance Criteria
GIVEN a Pre-work Study Guide website
WHEN I view the study guide
THEN I can see the four topics I learned listed along with a suggestion on what I should study first

Hello.
Do you really have issues with your code?


Create Date picker instead writing dates manually

In Status site, Instead of writing dates by formate wise, it should have a date picker, So that user can write dates by date picker.
ETA: 15 july

can all users edit dates or just admin/super user?


Remove bounds checks in Lexer by padding source

This came up on thread about SIMD in the Lexer https://github.com/oxc-project/oxc/issues/2296#issuecomment-1929343366, but opening a separate issue for it here, as it could benefit the Lexer's performance, even without SIMD.
Currently bounds checks (and the resulting branches) occur on every single call to Lexer::peek, Lexer::next_eq etc.
The idea is to allow removing all bounds checks by padding the source text with sentinel bytes indicating end of file. Instead of bounds checks, the lexer knows it's reached EOF when the EOF sentinel is found.
As the lexer is constantly checking byte values anyway, this should be more performant than checking byte values and doing bounds checks.
ratel uses this technique (code here and here).
In addition, to make SIMD both faster and easier to implement, could extend this approach and pad the source with SIMD_LANES (16/32/64) bytes. Then a SIMD block read is always valid, so no need to implement scalar fallbacks for towards end of the file.
This has been tried before in OXC and was removed:

https://github.com/oxc-project/oxc/issues/43
https://github.com/oxc-project/oxc/pull/90

It is unclear to me at present if the disadvantages which lead to its removal still apply or not. The new Source API may make it more ergonomic than it was previously. In any case, if it enables SIMD, that may change the cost/benefit calculus.
My questions about this approach are:

Does the cost of copying the whole source text at the start outweigh the gain of removing bounds checks everywhere else?
Could we add an entry point to the parser which takes a mutable String as source text? If that String already has excess capacity, could apply this approach without the cost of copying the source text.
For immutable &str input, could we use page table tricks like slice_deque does to create an extended buffer, while only copying the last chunk of the source?
Is there a way to build a safe abstraction which statically forces every part of the lexer to check for and handle the EOF sentinel? (rather than making the entire lexer a pit of unsafe)

The last is my greatest concern. It would be really nice to use the type system to enforce safety.

Does the cost of copying the whole source text at the start outweigh the gain of removing bounds checks everywhere else?

Could we add an entry point to the parser which takes a mutable String as source text? If that String already has excess capacity, could apply this approach without the cost of copying the source text.

There is no way the parser can own the string.
I think we should measure the combined performance of cloning the string + removing all out bound checks. Theoretically it should still be faster.

Is there a way to build a safe abstraction which statically forces every part of the lexer to check for and handle the EOF sentinel? (rather than making the entire lexer a pit of unsafe)

I don't think so ... I don't know about you but I'm pretty confident with all the tests + miri + 2 fuzzers.
I think you are essential writing C at this point :-)

There is no way the parser can own the string.

Does it have to? Can it not borrow a &mut String from the user but "hold on" to that mut reference to prevent any changes to the string content afterwards.

I think you are essentially writing C at this point :-)

I really don't want to be C! I have some potential ideas for a safe API, but just not sure if they can be made ergonomic enough.


Typo fix in cmd_nvs.c

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for your contribution.

@jkent could you sign the CLA so we could proceed and merge this PR?


我们使用了树组件，在初始化树结构时，[nzDefaultCheckedKeys]="selectedKeys",selectedKeys 中有父节点的key ，但其子节点并未全部勾选，却因为父节点的把下面的子节点全部勾选了，这个问题能否解决一下，非常紧急，谢谢

请具体描述应用场景,编辑这个demo，nzDefaultCheckedKeys会关联子节点

I also encountered the same problem

@yyicon please edit the demo link above to provide more information

The selected node I got is returned from the server. The demo may not be demonstrated

@yyicon maybe you can describe the problems you have met in detail and then we will help you, I don't understand how you use it.

in html:
<nz-tree
*ngIf="isOpen"
[ngModelOptions]="{standalone: true}"
[(ngModel)]="nodes"
[nzCheckable]="true"
[nzMultiple]="true"
[nzDefaultExpandAll]="expandDefault"
[nzDefaultExpandedKeys]="expandKeys"
[nzDefaultCheckedKeys]="checkedKeys"
(nzCheckBoxChange)="mouseAction('click',$event)"
(nzDblClick)="mouseAction('dblclick', $event)"
>`
No problem tree initialization，I posted the code to open Modal
in Component
checkedKeys = [];
expandKeys = [];
openPermsModal(event, item) {
this.service.getData("/sys/role/info/" + item.roleId, res => {
this.checkedKeys = res.role.menuIdList;
this.expandKeys = res.role.menuIdList;
});
}
thank you for your help

I have solved this problem. If I want to display normally, I can only add the leaf node to nzDefaultCheckedKeys. Before I wrote it wrong, thank you.

@yyicon this PR has supported nzDefaultCheckedKeys asynchronously


Minor rework of the submission system

I modified the submission system for RE-EDS simulations such that we no longer have to write the data to /cluster/work during the run to avoid "losing data" at the end of a run.
Indeed the reason we were losing data is that when runs happen on multiple nodes, the data has to be copied back from the scratch of each node manually. This can be done with a script written by the Euler cluster support people which I inserted in the pipeline.
I also commented out temporarily the lines which forced the "working directory" be a local directory in /cluster/work rather than a remote scratch as this is no longer needed.
Finally, after some discussion with Benjamin, I merged the "cleanup" and "simulation" part into a single job as I believe it makes things simpler (halves the number of jobs in queue, avoids waiting in queue for cleanup, compression is now done with more CPUs so its also even faster). Please kind in mind that there will be one scenario where the files are not compressed, and this is when a job is killed because it reached Wall Time.
So far I tested it with a few different setups and it works when MD is successful or not (e.g. SHAKE) and all files are always present in my directories regardless of how many nodes the calculation was distributed over.

This looks really cool, thanks a lot for figuring this out!!

@SchroederB Could you have a quick look to let me know if this is OK and I can merge it?
I've been using this way of submitting jobs for the past weeks and have had 0 problems!


Installer for Windows does not work properly

Does not seem to be adding to PATH correctly, as it is not recognizing "rokit" as a valid command

Does this issue still persist after:

Logging out + logging back in again?
Restarting your computer?

Changing PATH on Windows sometimes does not apply immediately and it is a bit unclear what fixes it. Make sure to try both of the above. If neither of them work, could you try running ./rokit.exe system-info in a terminal, inside the folder where you downloaded Rokit, and showing the output of that command?

Closing this issue since it was most likely because a restart was necessary. Feel free to open this back up if the issue persists


Not obvious how to configure Docker Daemon with TLS

We have articles explaining how to set up Docker with mutual TLS, but generally those articles are hard to follow.
I'm sure we can simplify those articles a bit.
https://docs.docker.com/engine/security/https/

Closing this ticket due to its age, and the impending refactor. If you think this is in error, feel free to reopen. Thanks!


I have a question in "Comet visualization" section :)

First of all, thank you for your nice and beautiful code.
In DeepForest documentation homepage, https://deepforest.readthedocs.io/en/latest/training.html
There is a  section of "Comet visualization".
You wrote :
from comet_ml import Experiment
comet_experiment = Experiment(api_key=<api_key>,
project_name=, workspace=<"username">)
comet_experiment.log_parameters(deepforest_model.config)
test_model.train(annotations=annotations_file, input_type="fit_generator",comet_experiment=comet_experiment)

So, I just followed your source code. But, there is not " deepforest_model " in anywhere. What does this variable_name mean?
In your documentation, you didn't use this name anywhere, so I cannot guess what it means....
And I thought that this mean "test_model" in your code, so I modified to it.
However, as you see the picture below,, it doesn't seam "test_model", because the graph looks so weird. (It is really different from your photo in documentation)

This is your photo.

However, this is mine(comet_ML)

I want to know what " deepforest_model " in your code actually mean. May I ask this question?
(If possible, also I want to know how to make a plot on vscode(or pychram etc.) not on cometML.. It always make an error whenever I tried to revise the code to generate plot on my code tool(vscode)... please look my photo below.... )
My entire code is :
from comet_ml import Experiment
import os
from deepforest import get_data
from deepforest import deepforest
from deepforest import utilities
from deepforest import preprocess
YELL_xml = get_data("2019_YELL_2_528000_4978000_image_crop2.xml")
annotation = utilities.xml_to_annotations(YELL_xml)
annotation.head()
annotation.to_csv("train_example.csv", index=False)
YELL_train = get_data("2019_YELL_2_528000_4978000_image_crop2.tiff")
crop_dir = os.getcwd()
train_annotations= preprocess.split_raster(path_to_raster=YELL_train,
annotations_file="train_example.csv",
base_dir=crop_dir,
patch_size=400,
patch_overlap=0.05)
train_annotations.head()
annotations_file= os.path.join(crop_dir, "train_example.csv")
train_annotations.to_csv(annotations_file,index=False, header=None)
test_model = deepforest.deepforest()
test_model.use_release()
test_model.config["epochs"] = 1
test_model.config["save-snapshot"] = False
test_model.train(annotations=annotations_file, input_type="fit_generator")
mAP = test_model.evaluate_generator(annotations=annotations_file)
print("Mean Average Precision is: {:.3f}".format(mAP))
test_model.plot_curves()
and this is the plot result.

Is there something I have to do more?
Also, thank you for your nice code :)

Sincerely, landkwon -

You were right that this could have been better illustrated. test_model was the right connection, its just the name of model instance. I can try to get some time look at the code. Just quick glance, you ran for only 1 epoch
test_model.config["epochs"] = 1

So there is no points on the graph to connect. Run for longer? Epochs are a full run through the dataset, depending on the problem you will atleast a few dozen (https://machinelearningmastery.com/difference-between-a-batch-and-an-epoch/).

You were right that this could have been better illustrated. test_model was the right connection, its just the name of model instance. I can try to get some time look at the code. Just quick glance, you ran for only 1 epoch
test_model.config["epochs"] = 1

So there is no points on the graph to connect. Run for longer? Epochs are a full run through the dataset, depending on the problem you will atleast a few dozen (https://machinelearningmastery.com/difference-between-a-batch-and-an-epoch/).

Thank you so much for your comments. I really appreciate it, and again, thank you for nice code! :)

Thank you so much for your comments. I really appreciate it, and again, thank you for nice code! :)


It fails to install pack when st2stream is behind of HTTP Proxy

SUMMARY
At the st2client as following,
[st2client] --> [HTTP Proxy (Nginx)] --> [st2stream]

the st2 pack install(remove) command fails because of 'SSL Certification Error' even through the silence_ssl_warnings is True at that .st2/config when I use self-signed certifications.
(virtualenv) ubuntu@ubuntu0:~$ cat .st2/config
[general]
silence_ssl_warnings = True

[stream]
url = https://ubuntu0/stream/v1

[credentials]
username = st2admin
(virtualenv) ubuntu@ubuntu0:~$ st2 pack install zabbix

For the "zabbix" pack, the following content will be registered:

rules     |  0
sensors   |  0
triggers  |  1
actions   |  10
aliases   |  0

Installation may take a while for packs with many items.
ERROR: ("bad handshake: Error([('SSL routines', 'tls_process_server_certificate', 'certificate verify failed')],)",)

(virtualenv) ubuntu@ubuntu0:~$

(c.f. Here is execution output with '--debug' option)
ISSUE TYPE

Bug Report
Other

STACKSTORM VERSION
st2 2.9dev, on Python 2.7.12
WORKAROUND
We can get around this problem by setting environment variable REQUESTS_CA_BUNDLE as below.
$ export REQUESTS_CA_BUNDLE=/etc/ssl/st2/st2.crt
$ st2 pack install zabbix

(c.f. for more detail)
Please tell me if there is a better way.
DISCUSSION
1. Adding a document at Troubleshooting
I couldn't find out a document that treats this problem at the Troubleshooting page. So you may want to write a document that describes workaround.
2. Adding a configuration parameter in 'cli' section
If there were a configuration parameter to pass verify argument of SSEClient (at here) that passes to requests, we could do it and also disable this SSL verification.
So how about adding this parameter to the cli section.

Looks like we have some automatic handling in place for non-stream connections - e.g. see this in st2/httpclient.py:
def add_ssl_verify_to_kwargs(func):
    def decorate(*args, **kwargs):
        if isinstance(args[0], HTTPClient) and 'https' in getattr(args[0], 'root', ''):
            cacert = getattr(args[0], 'cacert', None)
            kwargs['verify'] = cacert if cacert is not None else False
        return func(*args, **kwargs)
    return decorate

But we don't do that for StreamManager connections. Probably needs some similar handling there.

Thank you for giving advice for modification.
I understood we don't have to add a parameter that indicates cacert in the configuration because that has been already existed.
So, I'd like to make a small change in st2client to pass it to the StreamManager.


active region almost unnoticable

Hi.
I think we need to make the active region brighter or bolder.
It is almost unnoticeable because when have current line highlighted.

I changed it to:
modified   catppuccin-theme.el
@@ -323,7 +323,7 @@ Must be one of `mocha`, `macchiato`, `frappe`, or `latte`."
                (mode-line-inactive
                 :background ,ctp-crust :inverse-video nil :foreground ,ctp-overlay0)
                (read-multiple-choice-face :inherit completions-first-difference)
-               (region :background ,ctp-surface0 :extend t)
+               (region :background ,ctp-surface2 :extend t)
                (shadow :foreground ,ctp-overlay0)
                (success :foreground ,ctp-green)

I changed it to:
modified   catppuccin-theme.el
@@ -323,7 +323,7 @@ Must be one of `mocha`, `macchiato`, `frappe`, or `latte`."
                (mode-line-inactive
                 :background ,ctp-crust :inverse-video nil :foreground ,ctp-overlay0)
                (read-multiple-choice-face :inherit completions-first-difference)
-               (region :background ,ctp-surface0 :extend t)
+               (region :background ,ctp-surface2 :extend t)
                (shadow :foreground ,ctp-overlay0)
                (success :foreground ,ctp-green)

just a small query, it does not seem to be there in the repo?  (even I am struggling with this issue but not sure how to modify it myself)
https://github.com/catppuccin/emacs/blob/main/catppuccin-theme.el#L345


[terra-slide-panel] Component is mounting and unmounting when changing panelPosition

Bug Report
Description

When using terra-slide-panel and switching the panelPosition prop value, the mainContent is mounted and unmounted. After investigating this issue it was found that the reason this is occurring is the following if statement - Link. When panelPosition is changed a new React.Fragment is created causing the mounting and unmounting. After removing this if statement and instead always rendering the same React.Fragment we are not seeing any mounting/unmounting and the slide panel still seems to act as expected.
Steps to Reproduce

Setup a slide panel
Create a button that updates panelPosition
The mainContent unmounts when the panelPosition is changed

Expected Behavior

We expect that our mainContent should not mount or unmount when panelPosition is changed.
Possible Solution

Remove the if statement on this line.
Environment

Component Name and Version: terra-slide-panel v3.23.0
Browser Name and Version: Chrome
Node/npm Version: [npm 5.6.0]
Webpack Version: 4.42.0
Operating System and version (desktop or mobile): desktop

@ Mentions

@tbiethman

The flexing of the panel/mainDiv order is important for accessibility purposes. I wonder if putting an explicit key on both fragments would keep them from unmounting?

@tbiethman
I briefly tested the idea of adding a key to both the Panel and Main content. This removed the mounting and unmounting and both the Panel and Main content were still able to be changed. I'm sure further testing would need to be done to verify nothing else is broken.
If we want to move forward with such a fix would you accept a contribution? We are needing a change to fix the unmounting before we can move forward with one of our implementations.

@Me999999999 A contribution would be great.

Do you have any screenshots or reduced test case for showing mounting and unmounting of maini component..?


The links in README.md are pointed to a "localhost" host.

Hi
Thank you for providing such awesome framework. I am trying to get hands on it. But the links in the markdown file are incorrect. Could you please fix it?
Thanks

@xiaolongtang Thanks a lot for bringing it up. I have fixed the three links in the README file. There are several links in the readme with supporting channels. Please let us know if you have ideas to improve the platform or encounter any issue.

@stevehu
Thank you for your prompt response. They all work fine now.


Dedupe organisations in meta tags

This element assumes that the organisations, lead_organisations and supporting_organisations links in the links hash never overlap. This is not the case, and definitely isn't since https://github.com/alphagov/govuk-content-schemas/pull/308. This commit dedupes them before generating the metatag.

Should this include a test? eg https://github.com/alphagov/static/blob/master/test/govuk_component/analytics_meta_tags_test.rb#L36-L48

I didn't include that because on my machine it's tested with the new govuk-content-schemas branch. https://github.com/alphagov/govuk-content-schemas/pull/308 fails without this change.

:+1:


cb called synchronously in db._close(cb)

Side note: Is it possible for the close operation to error? Technically that is, code wise it never errors.

AFAIK only if you create a new transaction while the db is closing (that transaction will error).

Yea, other than that, the spec makes no mention of close errors: https://www.w3.org/TR/IndexedDB-2/#closing-connection.


extension can't be installed under OniVim2 editor

Please select the area your Bug applys to. (Multiple selections are Possible)

[ ] UI
[ ] Workbench
[ ] Publishing
[ ] Pods
[ ] Markdown
[ ] Hierarchy
[ ] Graph
[X ] Misc (Choose this if your not sure)

Describe the bug
I know that OniVim2 editor is not listed as comptible one, but it does support VSCode extensions and I have problem installing it - see this issue!
Anything that can be done at Dendron's side?
Sincerely,
Gour

I think this is a duplicate of #41 (I followed the onivim side issue it seems that Dendron needs to be installed without a workspace file dependency for this to work).
That said, we're all super interested in getting OniVim2 to work so once full extension support is completed (https://github.com/onivim/oni2/issues/3128) we can tackle this one. Closing as duplicate.


🐞 Golang modules error while executing ./dagger version

What is the issue?
The error occurs when I follow the section export-the-build-directory from the docs: https://docs.dagger.io/zenith/quickstart/853930/directories/#export-the-build-directory
I'm getting an error when trying to check the Dagger version:
$ ./dagger version
zsh: exec format error: ./dagger

cc @jedevc
Dagger version
dagger v0.9.9 (registry.dagger.io/engine) darwin/arm64
Steps to reproduce

[!IMPORTANT]
The issue seems to occur only on an Apple Silicon M1 device.

Open a terminal
Run this command first:

$ dagger -m github.com/kpenfound/dagger-modules/golang --proj https://github.com/dagger/dagger call build --args ./cmd/dagger export --path ./my-dagger-build

Then run:

$ cd my-dagger-build
$ ./dagger version

Log output
zsh: exec format error: ./dagger

Ooh, potentially this is part of the issue: https://github.com/kpenfound/dagger-modules/blob/e13cebb81cc0adb30ad9af533f8171a66b697102/golang/main.go#L39-L53
This should probably set GOOS as well as GOARCH @kpenfound? (similar to how BuildRemote works in the code below it).
I think we'd need to also update the docs to add --arch and --platform.

Aside: I wonder if we might want to expose the client's architecture to modules? Obviously, it's an information leak, and part of the "ambient system access problem", but:

this is super minimal information
modules could use this, if the aim is to export something to the client

Perhaps, we could have an ExportTarget or similar? Then when we know we're exporting files, we could send the client architecture that we're exporting to (though I wonder if this potentially makes ordering a bit tricky).

@jedevc yeah this definitely feels like it's a GOOS issue. I'll update the module!

I've added the optional os arg to the build command:
dagger -m github.com/kpenfound/dagger-modules/golang --proj https://github.com/dagger/dagger call build --args ./cmd/dagger --os darwin export --path ./my-dagger-build

Thanks @kpenfound! Not quite sure how we should surface this in the docs page though now:

Do we add a note about adding --os/--arch for cases where it needs to be included?
Or do we just add it in, and use some shell magic to get the right value? (something like uname -o)

@jedevc in general it would be useful to query the host os/arch for a lot of reasons, since within the module sandbox it'll always be linux


Automatic resolution of internal Typescript modules in separate files?

I have a ASP.net project that uses TS with internal modules and has a file per class. As long as the module name is the same in the file, all exported members can be seen in all files automatically without needing to use the old ///<reference..../> convention.
This does not seem work when using a nodejs application template.
I am trying to confirm that this does not work, and I am not doing something wrong.

@gravidThoughts,
With NodeJS one needs to use CommonJS, not internal modules. Does that make sense?

Yes.
I guess my issue is at this point in time there is poor support for the concept of a single external module split across multiple files.
How do I implement private/internal classes that help a module do its job?

I guess my issue is at this point in time there is poor support for the concept of a single external module split across multiple files.

Yes, that's right. See Microsoft/TypeScript#17

How do I implement private/internal classes that help a module do its job?

The only option for true private classes is to have it in the same file. We don't normally do this, preferring instead to defining "internal" type classes externally and importing them into the main class.

I appreciate your responses Noel.
Do we have to wait for ECMA6 before we have a robust modular pattern for TS, or does ECMA5 have the necessary semantics?

TS already supports ES6 modules (as of 1.5). It's an improvement on the old module system, but I don't think there's anything in the pipeline for solving multi-file external modules.
Probably the best bet is to close this issue and raise a question on the TS forum.

Or better still on typescript gitter: https://gitter.im/Microsoft/TypeScript


Add parser builder to modify parser options in-place

In some cases it is convenient to do NewParser(...).Parse() in one line, but some parser configuration needs to be changed. This PR suggests changes for creating parser like NewDefaultParser(&opts).WithOptions(...).WithEnvNamespaceDelimiter(...).Parse()

Condensing things on one line isn't a very good goal in my opinion. I don't see the need for this.


Lua debug logs not printing

Bug description
After upgrading to v1.9.1, Lua logs don't output in istio-proxy stdout.
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[X] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[X] Upgrade
Expected behavior
Expected Lua to output to istio-proxy stdout.
Steps to reproduce the bug
Configure EnvoyFilter as such:
apiVersion: networking.istio.io/v1alpha3
kind: EnvoyFilter
metadata:
  name: x-token-enrichment
  namespace: istio-system
spec:
  workloadSelector:
    labels:
      xtoken-enrich: enabled
  configPatches:
    - applyTo: HTTP_FILTER
      match:
        context: ANY
        listener:
          filterChain:
            filter:
              name: "envoy.filters.network.http_connection_manager"
      patch:
        operation: INSERT_BEFORE
        value:
          name: envoy.filters.http.lua
          typed_config:
            "@type": "type.googleapis.com/envoy.extensions.filters.http.lua.v3.Lua"
            inlineCode: |
              function envoy_on_request(handle)
                handle:logCritical("REQUEST HANDLED")
              end

Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
istio version
client version: 1.9.1
control plane version: 1.9.1
data plane version: 1.9.1 (2 proxies)

Server Version: v1.18.14

How was Istio installed?
istioctl install -f istio.yaml
istio.yaml
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
spec:
  components:
    ingressGateways:
    - name: istio-ingressgateway
      enabled: true
      k8s:
        service:
          type: NodePort
          ports:
          - name: status-port
            protocol: TCP
            port: 15021
            targetPort: 15021
            nodePort: 32021
          - name: http2
            protocol: TCP
            port: 80
            targetPort: 8080
            nodePort: 32080
          - name: https
            protocol: TCP
            port: 443
            targetPort: 8443
            nodePort: 32443
          - name: tls
            protocol: TCP
            port: 15443
            targetPort: 15443
            nodePort: 32000
  meshConfig:
    accessLogFile: /dev/stdout
    outboundTrafficPolicy:
      mode: REGISTRY_ONLY
    defaultConfig:
      proxyMetadata:
        ISTIO_META_DNS_CAPTURE: "true"
      gatewayTopology:
        numTrustedProxies: 1

Environment where the bug was observed (cloud vendor, OS, etc)
Bug occurred in Azure AKS cluster. I have used same envoy filter on a bare metal cluster w/ version 1.18.0 and 1.17.4.

can you check the config dump to ensure the lua filter shows up? https://github.com/istio/istio/wiki/Troubleshooting-Istio

Confirmed it appears in the config dump
{
  "name": "envoy.filters.http.lua",
  "typed_config": {
    "@type": "type.googleapis.com/envoy.extensions.filters.http.lua.v3.Lua",
    "inline_code": "function envoy_on_request(handle)\n  handle:logCritical(\"REQUEST HANDLED\")\nend\n"
    }
}

It works fine for me, can you ensure the traffic is actually being handled by the listener by access logs/config dump?

Created separate cluster and confirmed it is a misconfiguration on my part. Thanks for quick response. closing


hotfix serp api for jest

This is a PR to fix the bug https://github.com/hwchase17/langchainjs/issues/3
This is a hotfix to get tests to pass.
After install, a postinstall script is run that edits the jsdomexceptions npm module. SerpApi depends on jsdom, which depends on jsdomexceptions, which is throwing an error when it trying to get the prototype of the prototype of a function. The script edits line 34 of the utils.js script in that module to only unwrap once, ignoring the error. Unless we have deep exceptions occurring, which I doubt, I think it's fine.

@lalalune @sullivan-sean How about setting the @babel/preset-env target to node instead since likely you want langchain to run on node?
Ref: https://github.com/serpapi/serpapi-javascript/issues/10#issuecomment-1430878401

See https://github.com/serpapi/serpapi-javascript/issues/10,

I've updated serpapi to 1.1.1 which removes the production dependency on domexception. Let me know if you're still facing issues after the update. Will close this for now.

See serpapi/serpapi-javascript#10,

I've updated serpapi to 1.1.1 which removes the production dependency on domexception. Let me know if you're still facing issues after the update. Will close this for now.

Nonetheless, I still think setting preset-env to target the current node version makes sense since this is meant to be ran in a node environment 🙂

Thanks I've bumped serpapi for now - we plan on supporting a subset of functionality browser side, but I'll also update the preset-env to node as well!


[DRAFT] Namespaces instead of underscore prefix for binds

Redoing https://github.com/godotengine/godot/pull/26990/ for current master. WIP.

Update: this is now halfway working, singleton classes like OS work correctly from GDScript.
Simple core_bind namespace classes like File, Directory and Mutex however show up as not exposed/GDNativeClasses in GDScript.

Missing renaming _GodotSharp to mono_bind::GodotSharp here: https://github.com/godotengine/godot/blob/1057a107e0b555b8746c7fde6111b111ad9e723a/modules/mono/editor/editor_internal_calls.cpp#L244

Simple core_bind namespace classes like File, Directory and Mutex however show up as not exposed/GDNativeClasses in GDScript.

I just tested this PR. Not sure what problem you're having with those classes. They show up in the documentation view and auto-completion. They're also generated in the C# bindings, which only happens if they're exposed.

@neikeq

I just tested this PR. Not sure what problem you're having with those classes. They show up in the documentation view and auto-completion. They're also generated in the C# bindings, which only happens if they're exposed.

If you actually use them, Godot prints errors.
E.g. if you use this GDScript:
func _ready():
	var file = File.new()

At both parsing the script and running the game, Godot logs:

Native class GDScriptNativeClass used in script doesn't exist or isn't exposed.

Missing renaming _GodotSharp to mono_bind::GodotSharp here:

Fixed, thanks. Also fixed some formatting things the CI complained about.

Update: Everything actually works, but this check triggers for classes like File/Directory/Thread changed to a namespace with this PR:
https://github.com/godotengine/godot/blob/ca6c5cf7e6252558d8791d41b8b757929ac3819c/modules/gdscript/gdscript_analyzer.cpp#L3293

Okay, turns out there was a lot of hacks testing for underscores, and there was a list of classes that have underscores, and if they have not, they get the underscore added back.
Removed all of those hacks, and now it works beautifully without warnings, errors, or log messages :)

Fixed conflicts, and added Neikeq as co-author, as a large part of this is based on the original PR. :)

@akien-mga This is now fully working and should be good to go.
Also removes quite some brittle code :)
Let me know if you want me to change the namespaces to PascalCase.
The only thing to note is in the PR description about class names for disable_classes in SCons. If we want to change that handling, I'd prefer to do that in further PRs.

Note: This currently means that for namespaced classes, the macros will check for defines like ClassDB_Disable_core_bind::Directory instead of ClassDB_Disable_Directory. (In the GDREGISTER_CLASS macro).
(Used when passing disabled_classes to SCons.)

This will be a problem because AFAIK the disabled_classes option is intended to be used by the Godot editor in the future, and the Godot editor has no knowledge of those namespaces. That's why I recommended adding a new/overload of the GDREGISTER_CLASS macro for classes with namespaces if the namespace part cannot be trimmed with the current one. Something like GDREGISTER_NS_CLASS(core_bind::Directory, Directory).

I'm not sure it would make sense to disable any of those classes anyway, they're the most core you can get (aside from VisualScriptEditor but that's the odd one out, I don't even know why it's exposed this way, it's probably unnecessary).

I'm not sure it would make sense to disable any of those classes anyway, they're the most core you can get (aside from VisualScriptEditor but that's the odd one out, I don't even know why it's exposed this way, it's probably unnecessary).

That was my thinking too. However if we decide this needs to work, I'm happy to work on that. I'd appreciate if we could merge this PR first however, I'm so not looking forward to conflicts, as this mostly touches function/class signatures and so has a lot of surface area.

There isn't a use case for disabling most of those, except that GodotSharp should be disabled when compiling without the Mono module, and VisualScriptEditor only makes sense to include in the editor so it should be disabled on export templates.


Live updates?

I hoped to get a "live" update of the actual usage (best case including reset/start/stop), but it seems that the results are only plotted after the program finished (although -pipe is used)
Maybe I don't understand the extension correctly?
Is this not possibe or didn't I click the correct buttons...
Best Regards,
leo

Is this not possibe or didn't I click the correct buttons...

You did nothing wrong! Indeed, the extension waits for the execution to terminate before displaying the profiling data. A live display would be a new feature, but I can have a look into it!
In the meantime, running the Austin TUI within the VS Code terminal gives you a live view of the data (including a live flame graph :fire:). You can then save the collected data by pressing S at any point and opening the file with the extension.


Other countries...?

Is there not standard guidance on payment terms for other countries

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5f0109b5-e9f8-5537-d13d-5f3c6f9cb8cf
Version Independent ID: 669e2224-0f43-e744-d313-ff1d72d4fff2
Content: Setting Up Payment Terms - Business Central
Content Source: business-central/LocalFunctionality/Italy/how-to-set-up-payment-terms.md
Service: dynamics365-business-central
GitHub Login: @SorenGP
Microsoft Alias: sgroespe

Hello,
Thank you for your feedback! Our apologies for the delay in getting back to you on this, but in general, we do not provide strict guidance for how to set up payment terms because this is typically very different from country to country and from company to company. However, in Italy there are particular requirements for calculation, which is why we have this article.


Saving Annotations

Includes various changes to allow saving all annotations.
Previously, the library would only save a single TAL per AnnotationSignal (see Issue #11), at least with newly-created files (the behavior was different when re-saving an existing EDF file with annotations).
Additionally, the ReadAndSaveAnnotationOnlyFile() unit test was failing. With these changes, that unit test is now passing.

Wait, what? I am a noob to Git, and didn't realize that committing changes after making the pull request would alter what I had intended to be included.
Crap.
Noob mistake.

Going to close this pull request out of sheer embarrassment, lol. Will try to clean things up and try again.


Add email notificaitons about new user reviews for an extension

Thank you so much for the feature!
It will be cool add email notifications about new reviews for my extension!
Originally posted by @NabokD in https://github.com/microsoft/MicrosoftEdge-Extensions/discussions/18#discussioncomment-2767733

Feature request from @TwitchPreviews:
The option to enable email notifications  for:

Reviews
When a users rates the extension

Interesting request... any updates from the team as to if this will be implemented? If not it might be a cool feature to add to this project I built: https://asss.june07.com...


Shall we deprecate Bitnami's based image?

          Considering removing this file once Nginx becomes the only setup as it is done via the setup_moodle.sh script with moosh utility in initial setup process.

Originally posted by @ernani in https://github.com/google/moodle-on-gcp/pull/12#discussion_r1283345770

Yes please, even though installing with bitnami base image is easier with the help of helm install. But it will be confusing for newcomer like me to try to install Moodle on gcp if there are 2 options to start with and with different outcomes.


Shutdown executor on close

Otherwise the executor's lingering pool thread will prevent the JVM from exiting.
Note that this changes the method signature of AbstractNSQClient.setExecutor(). ExecutorService is a subclass of Executor and is what is returned by Executors.newSingleThreadExecutor(). I do not know whether any existing users of the library are expecting to be able to call setExecutor() with something other than an ExecutorService or a subclass of it.

I do not know whether any existing users of the library are expecting to be able to call setExecutor() with something other than an ExecutorService or a subclass of it.

Why would someone want/need to do that?  Is this a legitimate risk or purely theoretical?

Looking into it some more, I believe it's theoretical. AFAICT, All of the implementing classes of the Executor interface that ship with Java also implement ExecutorService.

thanks!


Certificate Authentication using PFX in .NET472 To Azure

Hello, I would like to ask question relating certificate authentication to Azure.
I tried to login to Azure using pfx-file, which I created from openssl-command:
openssl.exe pkcs12 -export -in <client pem file> -inkey <client key file> -out <client pfx file>
Then I tried to connect to Azure cloud roughly this way:
clientoptionbuilder.WithConnectionUri("<Azure's Broker>");
clientoptionbuilder.WithClientId("client id");
clientoptionbuilder.WithCleanSession(true);
clientoptionbuilder.WithCredentials("<username>");
var tlsoptionsbuilder=new MQTTnet.Client.MqttClientTlsOptionsBuilder();
tlsoptionsbuilder.UseTls(true);
tlsoptionsbuilder.WithSslProtocols(System.Security.Authentication.SslProtocols.Tls12);
tlsoptionsbuilder.WithTargetHost("<Azure's Broker>");  // <= is this necessary anymore??
tlsoptionsbuilder.WithAllowUntrustedCertificates(true);
var pfx=new System.Security.Cryptography.X509Certificates.X509Certificate2("<path to pfx file just created>", "password");
tlsoptionsbuilder.WithClientCertificates(new System.Collections.Generic.List<X509Certificate2> {pfx});
tlsoptionsbuilder.WithCertificateValidationHandler((certcontext) => { return true;});
clientoptionbuilder.WithTlsOptions(tlsoptionsbuilder.Build());
myMQTTClient.StartAsync(new MQTTnet.Extensions.ManagedClient.ManagedMqttClientOptionsBuilder().WithClientOptions(clientoptionbuilder.Build()).Build());

but I got Exception:

Got disconnected from the broker, '<BROKER'S URL>': MQTTnet.Exceptions.MqttCommunicationException: Authentication failed because the remote party has closed the transport stream. ---> System.IO.IOException: Authentication failed because the remote party has closed the transport stream.
at System.Net.Security.SslState.InternalEndProcessAuthentication(LazyAsyncResult lazyResult)
at System.Net.Security.SslState.EndProcessAuthentication(IAsyncResult result)
at System.Threading.Tasks.TaskFactory1.FromAsyncCoreLogic(IAsyncResult iar, Func2 endFunction, Action1 endAction, Task1 promise, Boolean requiresSynchronization)
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at MQTTnet.Implementations.MqttTcpChannel.d__17.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at MQTTnet.Adapter.MqttChannelAdapter.<>c__DisplayClass30_0.<b__1>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at MQTTnet.Adapter.MqttChannelAdapter.d__30.MoveNext()
--- End of inner exception stack trace ---
at MQTTnet.Adapter.MqttChannelAdapter.WrapAndThrowException(Exception exception)
at MQTTnet.Adapter.MqttChannelAdapter.d__30.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at MQTTnet.Client.MqttClient.d__54.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at MQTTnet.Client.MqttClient.d__42.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at MQTTnet.Client.MqttClient.d__42.MoveNext()

Someone know where is the problem? I am still stuck at .NET 472 framework, so I can't use CreateFrom*PEM*-methods yet. The client's pem-file and key-file work on MQTT Explorer, I used them to publish messages, no CA-file is needed.
I have read quite a lot sites, mostly written by @rido-min ,but seems for .NET Core.
I have asked AI for help which asked me to install BouncyCastle.Crypto.dll to create own ImportFromPem-method, but the implementation involve calling PemReader-method which is not available in .net framework.
Could someone direct me a bit, so I can publish messages to Azure's broker?

Hi @NguyenTam
Seems to me you are not targeting the TLS port, it should be 8883, the code below works for me running in net472
IMqttClient mqttClient = new MqttFactory().CreateMqttClient();
MqttClientConnectResult connAck = await mqttClient.ConnectAsync(new MqttClientOptionsBuilder()
    .WithTcpServer("<yourbroker>.eventgrid.azure.net", 8883)
    .WithCredentials("client1")
    .WithProtocolVersion(MQTTnet.Formatter.MqttProtocolVersion.V500)
    .WithTlsOptions(new MqttClientTlsOptionsBuilder()
        .WithClientCertificates(new X509Certificate2Collection(new X509Certificate2("client1.pfx", "<yourpassword>")))
        .Build())
    .Build());
Console.WriteLine($"Client Connected: {mqttClient.IsConnected} with CONNACK: {connAck.ResultCode}");

mqttClient.ApplicationMessageReceivedAsync += async m => await Console.Out.WriteAsync(
    $"Received message on topic: '{m.ApplicationMessage.Topic}' with content: '{m.ApplicationMessage.ConvertPayloadToString()}'\n\n");

MqttClientSubscribeResult suback = await mqttClient.SubscribeAsync("sample/+", MQTTnet.Protocol.MqttQualityOfServiceLevel.AtLeastOnce);
suback.Items.ToList().ForEach(s => Console.WriteLine($"subscribed to '{s.TopicFilter.Topic}'  with '{s.ResultCode}'"));

MqttClientPublishResult puback = await mqttClient.PublishStringAsync("sample/topic1", "hello world!", MQTTnet.Protocol.MqttQualityOfServiceLevel.AtLeastOnce);
Console.WriteLine(puback.ReasonString);

Console.ReadLine();

Thank you @rido-min for helping,
When I simplified to your way, then certificate authentication work ✅. Thanks for your help.


feat: Add price in USD to auction results list item

Addresses CX-1707
Description
Adds the price in US$ to auction results if the price is available and shown in another currency.

#squashongreen


CUDA out of memory.

Hello, I met the torch. Cuda. OutOfMemoryError: cuda out of memory. For this problem, my GPU is RTX 3090 with 24G memory, but the above error still occurs when I try to reduce the batchsize to 2. May I ask how to solve this problem and run the code normally.

One possibility would be to lower h=4096 to a lower number to reduce the total parameter count and get things to fit on your gpu. Another would be to train solely the retrieval pipeline and not the full retrieval + diffusion prior. We haven't tried adapting the code at all to work on lower specs than 1 A100 40GB gpu.

To run the Reconstruction notebook needed around 28GB of GPU RAM.

Thanks.


Persistent reference to formstate

Closes #105

Pull Request Test Coverage Report for Build 386

13 of 13 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 384:
0.0%

Covered Lines:
199

Relevant Lines:
199

💛  - Coveralls


  Wait for command to complete.  If
        the exit code was zero then return, otherwise raise
        CalledProcessError.  The CalledProcessError object will have the
        return code in the returncode attribute.

        The arguments are the same as for the call function.  Example:

        check_call(["ls", "-l"])
        """
        retcode = call(*popenargs, **kwargs)
        if retcode:
            cmd = kwargs.get("args")
            if cmd is None:
                cmd = popenargs[0]
>           raise CalledProcessError(retcode, cmd)
E           subprocess.CalledProcessError: Command '['/some/path/to/python3.7', '/some/path/to/rustpython/tests/snippets/whats_left_modules.py']' returned non-zero exit status 1.

/some/path/to/python3.7/subprocess.py:347: CalledProcessError
---------------------------- Captured stderr setup -----------------------------
    Finished dev [unoptimized + debuginfo] target(s) in 0.13s
    Finished release [optimized] target(s) in 0.12s
----------------------------- Captured stderr call -----------------------------
/some/path/to/rustpython/tests/snippets/whats_left_modules.py:30: DeprecationWarning: the formatter module is deprecated
  if mod not in ("this", "antigravity")
Traceback (most recent call last):
  File "/some/path/to/rustpython/tests/snippets/whats_left_modules.py", line 33, in <module>
    rustpymods
  File "/some/path/to/rustpython/tests/snippets/whats_left_modules.py", line 30, in <lambda>
    if mod not in ("this", "antigravity")
ModuleNotFoundError: No module named '__importlib_util'
=============================== warnings summary ===============================
snippets/test_warnings.py:3
  /some/path/to/rustpython/tests/snippets/test_warnings.py:3: UserWarning: Test
    _warnings.warn("Test")

-- Docs: https://docs.pytest.org/en/latest/warnings.html
============= 1 failed, 323 deselected, 1 warnings in 0.61 seconds =============

While running test_cpython_whats_left_modules test case, my cpython fails to import __importlib_util.
I'm using Arch Linux with Python 3.7.4. I don't think this is RustPython's bug, but it's little annoying that not all test cases pass.

Interesting. Have you set your PYTHONPATH or RUSTPYTHONPATH environment variable to the RustPython Lib directory? And did you make sure that your python environment was clean when you ran whats_left.sh or tests/not_impl_gen.py? And, can you see if __importlib_util is in the generated file tests/snippets/whats_left_modules.py?

My environment variables were clean:
$ env | rg PYTHON

$

Running pytest with RUSTPYTHONPATH variable also fails.

RUSTPYTHONPATH=Lib pytest fails
RUSTPYTHONPATH=../Lib pytest fails
RUSTPYTHINPATH=/absolute/path/to/rustpython/Lib pytest fails, too.

When I set PYTHONPATH to Lib, it fails too:
$ PYTHONPATH=Lib python tests/snippets/whats_left_modules.py
Fatal Python error: init_sys_streams: can't initialize sys standard streams
AttributeError: module 'io' has no attribute 'OpenWrapper'

Current thread 0x00007f24ffff9740 (most recent call first):
zsh: abort (core dumped)  PYTHONPATH=Lib python tests/snippets/whats_left_modules.py

$ PYTHONPATH=Lib python -c "import __importlib_util"              15:53:27
Fatal Python error: init_sys_streams: can't initialize sys standard streams
AttributeError: module 'io' has no attribute 'OpenWrapper'

Current thread 0x00007f16688d0740 (most recent call first):
zsh: abort (core dumped)  PYTHONPATH=Lib python -c "import __importlib_util"

Ah, I'm having the same issue. I'll look into it on my machine then.

Ah, it's that it's specifically importing the absolute path of the RustPython module. I can just push a quick fix to master to try/except the __importlib_util module and otherwise import importlib.util as __importlib_util.

Hmm, nevermind. It looks like it just doesn't like there being a module that is in RustPython's Lib dir and not CPython's, as it tries to import every single module that is in RustPython/Lib by name rather than path. I believe @youknowone is working on importlib now, though, so this should be a short-lived problem and we should be able to get rid of the __importlib_util hack.

Ok, should be fixed now. Try rerunning whats_left.sh and then pytest .