fixes the issue of copy to clipboard of whisper message

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/34504
https://github.com/Expensify/App/pull/33665#issuecomment-1900591512
PROPOSAL: N/a
Tests

[x] Verify that no errors appear in the JS console

Tests 1:

Create a room
Go to the room
Send a text mention a user
Right click on Concierge message > Copy to clipboard
Paste the content
Verify pasted content includes the mentions as in the Concierge message.

Tests 2:

Create a room
Go to the room
Send a text mention a user
Invite user to room using whisper message button, verify concierge message disappear
Click Do nothing from whisper message button, verify concierge message disappear

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

Tests 1:

Create a room
Go to the room
Send a text mention a user
Right click on Concierge message > Copy to clipboard
Paste the content
Verify pasted content includes the mentions as in the Concierge message.

Tests 2:

Create a room
Go to the room
Send a text mention a user
Invite user to room using whisper message button, verify concierge message disappear
Click Do nothing from whisper message button, verify concierge message disappear

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/104348397/a4960a7e-9b2b-48c2-a5ce-5c1fae385be1

Android: mWeb Chrome

https://github.com/Expensify/App/assets/104348397/61f6741d-a8eb-4345-8100-91127bdfa8b0

iOS: Native
https://github.com/Expensify/App/assets/104348397/0dbef60a-2620-46a2-9324-8978efa16f26

iOS: mWeb Safari
https://github.com/Expensify/App/assets/104348397/9af43a98-9527-4248-81b0-65a549d48ff4

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/104348397/3c419422-f9af-4f3b-8e09-b5cf901a9d51

MacOS: Desktop
https://github.com/Expensify/App/assets/104348397/55f5e0b9-2705-4db9-844f-691d3a299a0b

I think my review is not needed here or should I also review the PR?
cc: @jasperhuangg @aimane-chnaif

Sounds good

@ishpaul777 more conflicts :/ @aimane-chnaif bump on this review!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.4.42-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.42-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


drivers: w1: Move to using select in Kconfig for I2C bus

Move to using select I2C' instead of 'depends on'
(see commit df81fef94483da9f2811d48088affbcfd61ab18c for more
details)
Signed-off-by: Kumar Gala<EMAIL_ADDRESS>

I'm not sure if I would go with this strategy, but if it's the Zephyr way, I'm fine with this.


Backport of missing changes from LoopKit OmniBLE #110 and OmniKit #24

Reworked to use new non-persistent lastDeliveryStatusReceived PodState var
Remove now unneeded deliveryStatusVerified & lastCommsOK PodState vars
Move setupNotComplete error from PumpManagerError to PodCommsError
Add new suspended var for DeliveryStatus enum
Fix typo in extendedBolusRunning var for DeliveryStatus enum
Add new pod setup complete guard to PodCommSession.suspendDelivery()
Add new pod setup complete guard to PodCommSession.cancelDelivery()
Add new pod setup complete guard to runTemporaryBasalProgram()
Rework OmniBLE runTemporaryBasalProgram() to match OmniKit version
Update PodState.init() to take an optional initialDeliveryStatus parameter
Update PodCommsSessionTests to use new PodState initializer so tests can work

Thanks! Are all of these commits merged into LoopKit/OmniBLE now?

Yes, LoopKit/OmniBLE #110 landed in dev just yesterday.


Fill prev round review in form initial

@adrianliaw How do you think about this?

Codecov Report

Merging #524 into master will decrease coverage by 0.16%.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           master   #524      +/-   ##
========================================
- Coverage   74.17%    74%   -0.17%
========================================
  Files          72     72
  Lines        2513   2520       +7
========================================
+ Hits         1864   1865       +1
- Misses        649    655       +6

Impacted Files
Coverage Δ

src/reviews/views.py
33.61% <0%> (-2.11%)
:arrow_down:

.../proposals/management/commands/recent_proposals.py
98.76% <0%> (+1.23%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8cc0a4...3357768. Read the comment docs.


[WIP]feature: add ability for 'yurtctl convert/revert' to deploy/remove yurthub on cloud side.

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind feature
What this PR does / why we need it:
https://github.com/openyurtio/openyurt/issues/504
Which issue(s) this PR fixes:

Fixes #504
Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

TODO:

[x] yurtctl convert can deploy yurthub on cloud side.
[x] yurtctl revert can remove yurthub on cloud side.

/assign @rambohe-ch

/lgtm
/approve


Can not delete

I can not delete the app

Cus it doesnt want you to leave XD, it might be that your device have a virus


"react/jsx-wrap-multilines": "ternaries" option

I propose to add an option to react/jsx-wrap-multilines rule that would make this code valid:
const header = this.props.header
  ? <HeaderElement
      className="myclass myclass2"
      isExpanded={this.state.isExpanded}
  >
    {this.props.header}
  </HeaderElement>
  : null;

There is no real gain from adding parentheses here. It doesn't improve readability, but adds extra noise:
const header = this.props.header
  ? (
    <HeaderElement
      className="myclass myclass2"
      isExpanded={this.state.isExpanded}
    >
      {this.props.header}
    </HeaderElement>
  )
  : null;

or even worse:
const header = this.props.header
  ? (<AccordionElement
    className="myclass myclass2"
    isExpanded={this.state.isExpanded}
  >
    {this.props.header}
  </AccordionElement>)
  : null;

Right now to make omitting parentheses possible I need to switch off both "assignment" and "declaration" options, but because of this I'm loosing errors for code like this:
const header =

    xyz

;

which I believe is much better with parentheses:
const header = (

    xyz

);

This is how I'd indent your code:
const header = this.props.header ? (
  <HeaderElement
      className="myclass myclass2"
      isExpanded={this.state.isExpanded}
  >
    {this.props.header}
  </HeaderElement>
 ) : null;

Does that example help?

Yeah, it's better, but it is still conflicting with prettier, which opts for this kind of formatting for ternaries:
const header = this.props.header
  ? <ElementRenederedWhenTrue />
  : <ElementRenederedWhenFalse />;

And i'm just trying to make Airbnb ESlint rules work with prettier. Here's analogical issue I reported for prettier: https://github.com/prettier/prettier/issues/1009#issuecomment-286833002

Airbnb won't be changing any of our eslint rules to match prettier; all our rules are the way they are for a reason.
The latter example your posted is just fine, because the jsx is single-line. Airbnb's style guide (and this rule) requires parens around multiline ternaries only.

Yes, I get that Airbnb won't change the rules, but I can override them so they will work with prettier.
 If there was an option to switch off requiring parens just for multiline ternaries a lot more cases would be covered.


Made the toggle btn to work in team Page

issue: #1001
Made the Toggle button work in the Team page by adding the CSS property

thankyou for your contribution :)


 We receive the money once the issue is completed & confirmed by you.
100% of the funding will be distributed between the Filament core team to run all aspects of the project.
Thank you in advance for helping us make maintenance sustainable!

I get no errors with version 3.2.14. Could you maybe try upgrading and see if that fixes your issue?

Will check tomorrow and will post an update here 👍

@thethunderturner still no luck with v3.2.16 :cry:
https://github.com/filamentphp/filament/assets/8792274/96a9b86b-70b3-430e-9d38-2fce93162352

I'm also seeing this error using v3.2.16 when trying to upload a CSV file via ImportAction.
Clicking within the "Upload a CSV file" dialog opens the select file window, but selecting an appropriate file results in "Could not find Livewire component in DOM tree" being console logged.
Strangely drag and drop works fine and processes the CSV as expected.

Whilst creating the reproduction repo I noticed that <x-filament-actions::modals /> was being conditionally rendered, this was the cause of the issue and worked as expected when moved outside of the conditional statement.
I hope this helps. Good luck with above issue.

I tried to reproduce the bug using your repo but had no luck. I also noticed that you tried to upload a WEBP image. I uploaded it, and everything is working well.
Check the video bellow for more details
https://github.com/filamentphp/filament/assets/4639175/a978f326-8eb0-4d5b-a860-4d422f13c034

weird, I'll try again
what's your OS?

weird, I'll try again
what's your OS?

Ubuntu 22.04 and latest Chrome

Please try to change your .env APP_URL.
In my case, it worked.

Please try to change your .env APP_URL. In my case, it worked.

Change to what?

In Itemsresource.php

in .env file


Ints.checkedCast vs. Math.toIntExact

Guava's Ints.checkedCast can be replaced with Java 8's Math.toIntExact. As described in google/guava#3105, the only difference is the exception they throw. Keeping in mind this subtle difference: is Ints.checkedCast eligible for inclusion in modernizer-maven-plugin? If so, I'll open a PR.

Modernizer should recommend this.  The violation comment could suggest catching ArithmeticException.  I also like https://github.com/google/guava/issues/3105#issuecomment-390493543 suggesting Math.subtractExact instead of IntMath.checkedSubtract.

Alright, I filed #103.


Update sbt-scoverage to 2.0.1

Updates org.scoverage:sbt-scoverage from 1.9.3 to 2.0.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scoverage", artifactId = "sbt-scoverage" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.scoverage", artifactId = "sbt-scoverage" }
}]

labels: sbt-plugin-update, early-semver-major, semver-spec-major, commit-count:1

sbt-native-packager 1.9.10 was released yesterday (https://github.com/sbt/sbt-native-packager/releases/tag/v1.9.10).  Both sbt-coverage 2.0.1 and sbt-native-packager 1.9.10 use scala-xml 2.1.0, so the version conflict build errors will go away if we bump both sbt-native-packager and sbt-coverage together.  Note sbt-coverage 2.0.2 was released yesterday too, so let's wait for Scala Steward to send updated PRs.

Superseded by #823.

Superseded by #857.


Service not working

Hi,
Just checked shields.io and most of the svg files are not loading, for example, https://img.shields.io/github/stars/badges/shields.svg?style=social.

Is this a temporary error or is this project no longer maintained?

Thanks for reporting!
It seems up now. We are planning on switching servers.
Closing as a duplicate of this issue: https://github.com/badges/shields/issues/481


[space-ace]: some edge case with NaN

Hi, I noticed that I can pass the test for space-ace with this:
package space

import (
        "math"
)

// Planet represents official planets in the Sol system.
type Planet string

const (
        Earth   Planet = "Earth"
        Mercury Planet = "Mercury"
        Venus   Planet = "Venus"
        Mars    Planet = "Mars"
        Jupiter Planet = "Jupiter"
        Saturn  Planet = "Saturn"
        Uranus  Planet = "Uranus"
        Neptune Planet = "Neptune"
)

// Age provides the age on a particular planet (in Earth years), given the age in seconds.
func Age(ageInSeconds float64, planet Planet) float64 {
        periodInEarthYear, exist := orbitalPeriodsInSecond[planet]
        if !exist {
                return math.NaN()
        }

        // NOTE: periodInEarthYear is assumed to be > 0
        ageInEarthYear := ageInSeconds / periodInEarthYear
        return ageInEarthYear
}

const earthPeriodInSeconds = 31557600.0

var (
        orbitalPeriodsInSecond = map[Planet]float64{
                Earth:   1.0 * earthPeriodInSeconds,
                // Mercury: 0.2408467 * earthPeriodInSeconds,
                // Venus:   0.61519726 * earthPeriodInSeconds,
                // Mars:    1.8808158 * earthPeriodInSeconds,
                // Jupiter: 11.862615 * earthPeriodInSeconds,
                // Saturn:  29.447498 * earthPeriodInSeconds,
                // Uranus:  84.016846 * earthPeriodInSeconds,
                // Neptune: 164.79132 * earthPeriodInSeconds,
        }
)

$ go test -v
=== RUN   TestAge
--- PASS: TestAge (0.00s)
        space_age_test.go:14: PASS: age on Earth
        space_age_test.go:14: PASS: age on Mercury
        space_age_test.go:14: PASS: age on Venus
        space_age_test.go:14: PASS: age on Mars
        space_age_test.go:14: PASS: age on Jupiter
        space_age_test.go:14: PASS: age on Saturn
        space_age_test.go:14: PASS: age on Uranus
        space_age_test.go:14: PASS: age on Neptune
PASS
ok      exercism/go/space-age   0.005s

Do you think it's worthwhile to handle cases like this for the exercise?

Also, I noticed that the math.Abs(actual-tc.expected) > precision part of the test is not very strict (compared to what's mentioned here).
Is it intentional & is not the point of this exercise?

I propose a PR for checking the NaN case ; about precision, it is a good point but in my opinion this exercise is one of the first the user faces and could be misleading to make them worry about floating point issues at this stage. Could be an idea for a new 'medium/advanced' exercise?


Replaced use of webclient in QnAMakerService.QueryServiceAsync with H…

…ttpClient so that calls is actually asynchronous
Fix for issue
https://github.com/Microsoft/BotBuilder-CognitiveServices/issues/16

@dasvictor can you take a look and comment? seems that there is a conflict now. Can you figure out if this is resolved with your latest changes?


Add Automated Builds for Acceptance Tests via AppVeyor

AppVeyor is sweet :-)
https://ci.appveyor.com

It's actually running there for a while, but I still did not get reliable builds out of it.

rake test should be doable
rake acceptance in theory too, but on azure workers it won't run due to the 30 minutes limit and on hyperv vagrant/virtualbox vms produced random failures

See also:
http://help.appveyor.com/discussions/problems/1247-vagrant-not-working-inside-appveyor
http://help.appveyor.com/discussions/suggestions/519-pre-install-vagrant-and-virtualbox-on-build-workers


[GSSOC'23] -  Poor UI of Footer section

Description:
The current state of the footer links in the project does not meet the desired design standards and falls short in terms of aesthetics. The links' appearance is not visually appealing and lacks consistency with the overall website design. This issue negatively impacts the overall look and feel of the footer section and hampers the user experience. To address this, it is crucial to improve the design and ensure a more visually pleasing and consistent presentation of the footer links.
Proposed Solution:
To address the issue of the unsatisfactory appearance of the footer links, the following steps are proposed:

Design Enhancement: I will revise the styling of the footer links to improve their visual appeal and consistency with the overall website design. This may involve adjusting the font size, spacing, and color scheme to create a more harmonious and visually pleasing look.

Consistency:  I will ensure that the design changes align with the established design standards and maintain consistency throughout the website. This will create a cohesive visual experience and reinforce the brand's identity.

Please assign me this issue under GSSOC'23. I would love to enhance the UI of the website.

heyy is the issue Still open, I Would like to work on this issuse .


feat(react-query): more descriptions for cli status

Overview
I've added you as a co-author! @juno7803
Thank you for your valuable feedback! Thanks to you, the explanation has become even better.
I have made the API display static for now. In the next version, I will make it dynamic to list and display the APIs. https://github.com/toss/suspensive/issues/1000#issuecomment-2197635287

version 4
version 5

PR Checklist

[x] I did below actions if need

I read the Contributing Guide
I added documents and tests.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.42%. Comparing base (a4f3604) to head (ac2fe19).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1024      +/-   ##
==========================================
+ Coverage   85.28%   85.42%   +0.13%
==========================================
  Files          45       45
  Lines         537      542       +5
  Branches      117      118       +1
==========================================
+ Hits          458      463       +5
  Misses         74       74
  Partials        5        5

Components
Coverage Δ

@suspensive/react
97.03% <ø> (ø)

@suspensive/react-query
76.08% <100.00%> (+1.37%)
:arrow_up:

@suspensive/react-query-4
0.00% <ø> (ø)

@suspensive/react-query-5
0.00% <ø> (ø)

@suspensive/react-await
100.00% <ø> (ø)

@suspensive/react-image
80.39% <ø> (ø)

@gwansikk changeset please


Transporter not found error after Xcode 6.3 update

Getting this after updating Xcode 6.3

Transporter not found at path: /usr/local/itms/bin/iTMSTransporter.  You should reinstall the application.

I also got this error in the Application Loader application, but after reinstalling it I was able to upload my application.  motion upload still has this error

I've used Xcode 6.3. However, I can't reproduced your problem.
$ motion validate<EMAIL_ADDRESS>Validate: ./build/iPhoneOS-8.2-Release/BitWatch.ipa
✓ No errors validating archive at ./build/iPhoneOS-8.2-Release/BitWatch.ipa
$ xcodebuild -version
Xcode 6.3
Build version 6D570

In my env, iTMSTransporter is contained in Application Loader.app.
Can you confirm that it is existing?
$ find /Applications/Xcode.app -name "iTMSTransporter"
/Applications/Xcode.app/Contents/Applications/Application Loader.app/Contents/itms/bin/iTMSTransporter
/Applications/Xcode.app/Contents/Applications/Application Loader.app/Contents/itms/share/iTMSTransporter.woa/Contents/MacOS/iTMSTransporter
/Applications/Xcode.app/Contents/Applications/Application Loader.app/Contents/itms/share/iTMSTransporter.woa/iTMSTransporter

And iTMSTransporter has used Java. Can you confirm the version you are using?
$ java -version
java version "1.6.0_65"
Java(TM) SE Runtime Environment (build 1.6.0_65-b14-466.1-11M4716)
Java HotSpot(TM) 64-Bit Server VM (build 20.65-b04-466.1, mixed mode)

I've used Java in http://support.apple.com/kb/DL1572
Thank you.

Thanks Watson. I'll check these things when I get into the office this morning.  Thanks for checking, sounds like a problem with my system then, but I will confirm
Sent from my iPhone

On Apr 14, 2015, at 10:37 PM, Watson<EMAIL_ADDRESS>wrote:
I've used Xcode 6.3. However, I can't reproduced your problem.
$ motion validate<EMAIL_ADDRESS>Validate: ./build/iPhoneOS-8.2-Release/BitWatch.ipa
✓ No errors validating archive at ./build/iPhoneOS-8.2-Release/BitWatch.ipa
$ xcodebuild -version
Xcode 6.3
Build version 6D570
In my env, iTMSTransporter is contained in Application Loader.app.
Can you confirm that it is existing?
$ find /Applications/Xcode.app -name "iTMSTransporter"
/Applications/Xcode.app/Contents/Applications/Application Loader.app/Contents/itms/bin/iTMSTransporter
/Applications/Xcode.app/Contents/Applications/Application Loader.app/Contents/itms/share/iTMSTransporter.woa/Contents/MacOS/iTMSTransporter
/Applications/Xcode.app/Contents/Applications/Application Loader.app/Contents/itms/share/iTMSTransporter.woa/iTMSTransporter
And iTMSTransporter has used Java. Can you confirm the version you are using?
$ java -version
java version "1.6.0_65"
Java(TM) SE Runtime Environment (build 1.6.0_65-b14-466.1-11M4716)
Java HotSpot(TM) 64-Bit Server VM (build 20.65-b04-466.1, mixed mode)
I've used Java in http://support.apple.com/kb/DL1572
Thank you.
—
Reply to this email directly or view it on GitHub.

In my env, iTMSTransporter is contained in Application Loader.app.
Can you confirm that it is existing?

find /Applications/Xcode.app -name "iTMSTransporter"
/Applications/Xcode.app/Contents/Applications/Application Loader.app/Contents/itms/bin/iTMSTransporter
/Applications/Xcode.app/Contents/Applications/Application Loader.app/Contents/itms/share/iTMSTransporter.woa/Contents/MacOS/iTMSTransporter
/Applications/Xcode.app/Contents/Applications/Application Loader.app/Contents/itms/share/iTMSTransporter.woa/iTMSTransporter

And iTMSTransporter has used Java. Can you confirm the version you are using?

java -version
java version "1.6.0_65"
Java(TM) SE Runtime Environment (build 1.6.0_65-b14-466.1-11M4716)
Java HotSpot(TM) 64-Bit Server VM (build 20.65-b04-466.1, mixed mode)

the interesting thing is, validate works, but upload does not.... (in this example I am getting a validation error because I am trying to upload one uploaded before - but the same will happen for a binary that passes validation)
motion validate<EMAIL_ADDRESS>Validate: ./build/iPhoneOS-7.1-Release/Hello 200 STG.ipa
✗ Redundant Binary Upload. There already exists a binary upload with build '1.3.3' for version '214'

motion upload<EMAIL_ADDRESS>Upload: ./build/iPhoneOS-7.1-Release/Hello 200 STG.ipa
✗ Transporter not found at path: /usr/local/itms/bin/iTMSTransporter.  You should reinstall the application.

@Watson1978 however, this helped me figure out what was going on here - i just need a symlink in /usr/local/itms/
added the symlink, and now its working again.

for the lazy:
mkdir -p /usr/local/itms/bin

ln -s /Applications/Xcode.app/Contents/Applications/Application\ Loader.app/Contents/itms/bin/iTMSTransporter /usr/local/itms/bin/iTMSTransporter

@markrickert yeah pretty sure I had to do something like that :+1:  (I definitely remember the symlink part at least)


remove "opening triangle"

From this Slack thread, @elray1 says:

it would probably be easiest to turn off what Aaron has termed the “opening triangle” that is created by connecting the forecasts to the last observed data point.  This would involve removing state.as_of_truth.date.slice(-1).concat( from these lines.

@nickreich's comment:

the opening triangle issue .. is currently creating some very weird shapes for the models that have some “-1” horizons [see image below]

In the future we might add an App.initialize() option to control it.

Unfortunately, I think the update didn't fix all of this. It removed the "opening triangle" but not the line connecting the end of the data with the start of the forecasts. See this screenshot.


Too much L3 hits

Hi!
I got config with only get () function.
ttl=5, neg_ttl=3, lru_size = 5000
Under high load (about 10krps - 36 nginx workers, cpu ~60%) i see that in logs i get hit_level=3 for up to 10 times per second. How can i avoid it?

@thibaultcha Hi! Sorry for late answer, i figured out, it was our missconfiguration and app worked not correctly which lead to heavy load.
Now everything worked good but i try to emlate attack for 404 errors and after about 1500rps i see such message status=could not acquire callback lock and 5xx errors because of proxy timeouts (nginx on frontend proxy to openresty)
in config i have
lua_shared_dict ipc_shared_dict 1000m;
lua_shared_dict miss_shared_dict 1000m;
lua_shared_dict locks_shared_dict 1000m;
lua_shared_dict cache_shared_dict 1000m;
local ccache, err = mlcache.new("my_cache", "cache_shared_dict", {
lru_size = 50000, shm_miss = "miss_shared_dict", shm_locks = "locks_shared_dict", ipc_shm = "ipc_shared_dict", resty_lock_opts = {exptime=10, timeout=9}
})
ttl=5, neg_ttl=1, resurrect_ttl=5
What can i do additionally to avoid timeouts and just answer 404 to clients?


Update dependency org.apache.cxf.services.sts:cxf-services-sts-core to v3.3.2

This PR contains the following updates:

Package
Update
Change
References

org.apache.cxf.services.sts:cxf-services-sts-core
patch
3.3.1 -> 3.3.2
homepage

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


feat(eth payments): PE-5992

This PR adds support for ethereum token in the topUpWithTokens method

:tada: This PR is included in version 1.9.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.9.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


LoL and 2002 Mr Store fixes

Fix typo on coinmaster inventory for Replica 2002 Mr. Store Catalog
Replica Ten Dollars is multi-usable.
Multi vs. single use have subtly different messages.
When multi-using, must increment legacyPoints by the number used.
Meat Butler is the third (mutually exclusive) Rollover adventure-granting dwelling attendent.
Replica 2002 Mr. Store Catalog leads to shop.php so cannot have an in-line use link.

I would suspect the Lapis Lazuli / Azurite are also multiple if Eye Agate is, but fine to go in anyway.

You are correct. I didn't happen to notice it when I acquired them while adventuring, but:
> closet put * Eye Agate

Placing items into closet...
Requests complete.

> closet put * Azurite

Placing items into closet...
Requests complete.

> closet put * Lapis Lazuli

Placing items into closet...
Requests complete.

> closet take * Eye Agate

Removing items from closet...
You acquire Eye Agate (10)
Requests complete.

> closet take * Azurite

Removing items from closet...
Azurite is multiusable, but KoLmafia thought it was not
You acquire Azurite (9)
Requests complete.

> closet take * Lapis Lazuli

Removing items from closet...
Lapis Lazuli is multiusable, but KoLmafia thought it was not
You acquire Lapis Lazuli (13)
Requests complete.

I'll fix them.


Add support for specifying the role assumption duration

AWS now supports assumption of roles for longer than the previous limit of 1 hour. We have a small number of jobs that are quite long running, and would like to be able to assume roles for longer than 1 hour.
This PR adds an optional parameter for duration that is passed to the role assumption command as --duration-seconds.
Repository tests, plus my own testing in BuildKite yields positive results.

Nice, thanks @scottybrisbane.
Top quality pull request 👍

(Oh, and sorry for the slow response, I only just spotted this PR now!)

No worries, thanks for the merge!


[WIP] Preload fair content from a local web server advertised through Bonjour.

I’ll update the list of TODOs further, this is just to keep track for now.

[x] Discover a FairEnough Bonjour service and resolve its address.
[x] Fetch metadata about the fair and content package.
[x] Download the package.
[x] Resume a previously failed download of the package.
[x] Unpack the zip package into the application’s cache directory.

Oops, looks like I left in a commit that was meant to be squashed, will do that tomorrow.

lols FairEnough

been wondering about annotations on routes that could say "this can run through FairEnough", can discuss at https://github.com/artsy/mobile/issues/22

worth keeping this open?

Maybe not the PR, no, but I’d like to keep the branch.


Assert clause prevents finding important features.

Hello!
First of all, thank you for the development of this project.
I've been (trying to) use it to extract feature importance of LSTM and Transformer models, but I've stumbled on an assert clause that stops the process.
More specifically:

I have developed these models using PyTorch, and have developed a model wrapper to adapt them to your framework;
My dataset consists on 222 instances of sequence length 4, where each element of this sequence contains 6 features.

When no features are considered important, it all goes smoothly, displaying on the terminal:
No important features identified, skipping window feature importance window visualization.
However, when the framework detects important features, it hits an assert clause, this one:
https://github.com/cloudbopper/anamod/blob/556e2478517c9bd71db2f4c40990d1f6edfa1623/anamod/core/perturbations.py#L102
perturbed_slice.base is None, where, according to the assert clause, it should be, as it indicates, X_hat.
For that reason, the process stops.
Following the guidelines you provide at Contributions:

I am running Manjaro Linux 22.1.0;
I think no local details are necessary, as ...
... I was able to reproduce the bug without using my data or my models.

To try to find out the issue (it could reside on my data, models or model wrapper), I've tried to replicate the problem solely with the functions you provide:
import anamod, synmod
output_dir = '.'
num_instances = 222
num_features = 6
fraction_relevant_features = 0.9 # 0.1 works, 0.9 blows
sequence_length = 4

synthesized_features, X, model = synmod.synthesize(output_dir=output_dir, num_instances=num_instances, seed=100,
                                                    num_features=num_features, fraction_relevant_features=fraction_relevant_features,
                                                    synthesis_type='temporal', sequence_length=sequence_length, model_type='classifier')

y = model.predict(X, labels=True)

importance_level = 0.1
output_dir = '.'
loss_function = 'binary_cross_entropy'
feature_names = ['A', 'B', 'C', 'D', 'E', 'F']
explainer = anamod.TemporalModelAnalyzer(
                        model,
                        X,
                        y,
                        output_dir=output_dir,
                        loss_function=loss_function,
                        feature_names=feature_names,
                        importance_significance_level=importance_level,
                        visualize=True
                            )

explainer.analyze()

Changing the value of fraction_relevant_features toggles between working and not working:

fraction_relevant_features = 0.1 makes the analyser detect no important features, and for that reason concludes successfully;
fraction_relevant_features = 0.9 makes the program hit the assertclause.

PS: To check whether that would be the single problem in the process, I have tried commenting that assert clause. The process then finishes, but displaying a «deformed» plot .

However the results may not be correct ones (the assert was there probably for a reason...)
It would be nice if the plot size was adjusted accordingly, or to be set beforehand, to avoid this.
Thanks!

I took a look at the source code, and found the following:

The problem appears at
https://github.com/cloudbopper/anamod/blob/556e2478517c9bd71db2f4c40990d1f6edfa1623/anamod/core/perturbations.py#L102
The assert clause fails given that  perturbed_slice.base = None.

perturbed_slice is generated by https://github.com/cloudbopper/anamod/blob/556e2478517c9bd71db2f4c40990d1f6edfa1623/anamod/core/perturbations.py#L98

perturbed_slice.base is X_hat, unless it enters in the following block
https://github.com/cloudbopper/anamod/blob/556e2478517c9bd71db2f4c40990d1f6edfa1623/anamod/core/perturbations.py#L46-L48
When the code reaches, this block, perturbed_slice.base = None and for that reason the assert clause fails.

I've noticed the comment you have left there, so maybe there is something missing in the implementation...?


Change gitscraping time

Fixed by https://github.com/rrelyea/3fund-prices/commit/5eac7f37dd854579dfabdd544ac30d4ca9b4c892


MapView.LayoutParams/InfoWindow imprecision in high zoom levels

Hi,
MapView.LayoutParams seem to have inaccuracies in high zoom levels, which can e.g. be seen with the InfoWindow.
I'm pretty sure that this is related to some float rounding in the rendering process, as the imprecision increases for the coordinates in the lower right corner of the coordinate system, and is practically zero for the top left corner.
I've created a video where you can see the problem (it's my own implementation of something similar to an InfoWindow that also uses MapView.LayoutParams. I could also reproduce it with the OsmDroid samples from Google PlayStore. Not as drastically however, as they don't allow for such high zoom levels):
https://youtu.be/SKIEbTMXkss
As you can see, the InfoWindow becomes very "jumpy" when scrolling the map, so it is not actually placed at the correct location any more.
Note that I'm also convinced that this is not directly an OsmDroid problem. During the onLayout phase, the coordinates seem to be quite fine. I guess the Android rendering pipeline will at some point convert the integer Point objects to floats, triggering the issue.
For that matter, I also think that this is closely related to https://github.com/osmdroid/osmdroid/issues/329 in two ways:

To support high zoom levels, this needs to be fixed
I think it would be fixed automatically when implementing a custom long or double based scroll system, as the coordinates wouldn't become so big that float rounding is a problem.

Unfortunately, osmdroid comes to its limits when working with centimeter accuracy RTK-GPS.
Supporting higher zoom levels without loss is essential in such environments.
+1 vote for Long instead of Integer processing

We rely on androids view scroller for panning the map which is in based. That's the blocking item

As I described in #329, I think the problem is not really in the view scroller.
We have our actual screen; typically about 800x600 pixels.
We can work on a virtual big canvas square with 2^32 values for X and Y: that's where we draw things (limited to ìnt` values because of Android). As we would use a geo center offset, that will mean canvas coordinates between Integer.MIN_VALUE and Integer.MAX_VALUE.
There will be a projection square with (tileSize * 2^zoom) values for X and Y: that's where we project our geo points. Starting from 0.
There will be an *offset projection" square with (tileSize * 2^zoom) values for X and Y, from (-(tileSize * 2^zoom) / 2) to ((tileSize * 2^zoom) / 2 - 1).
How to I compute from a geo point to X/Y for a given zoom?

I project this geo point into the corresponding long coordinates (as we do now, but now as long, starting from 0) (we're in the projection)
I apply the map center offset (basically the coordinates of the map center computed as in previous step) (we're in the offset projection)
If the offset projection coordinates fit into int and therefore fit into our virtual big canvas, that means we can try to display the marker - of course it will be displayed only if it also fits the actual screen limits.

Works like a charm for single markers, that can easily by dismissed (id est not drawn) if there are beyond visiblity when the offset projection coordinate don't fit into int.
But what shall we do with Polygons corners that are beyond visibility? Potentially we still need to display them, not because we will see them but because we may see the segments coming to/from them.
I suggest that in the invisible Polygon corners cases we compute a visible point (virtual big canvas wise) as a "border approximation":

from long coordinates that don't fit int values
we compute the int intersection X,Y of
a segment from the map center to those coordinates
with the int square border { [MIN_VALUE,MIN_VALUE], [MIN_VALUE,MAX_VALUE], [MAX_VALUE,MAX_VALUE], [MAX_VALUE,MIN_VALUE] }

What do you guys think, about the whole solution and about the approximation for invisible Polygon corner?

i was suggesting that we use a virtual canvas of type long which will obviously increase the max zoom level significantly. Then the issue is getting android's canvas to work correctly again, since it's int based. I did some experiments with this and the largest blocking issue for this path is the view scroller. The code is rather complex for it. If someone goes down this path, they would then need to translate from the android int canvas to the long canvas, basically tracking some offsets to figure out what part of the world to render.

Just experienced a glimpse of double/long issues with large numbers:
final long roundingIssueLong = (Long.MAX_VALUE-1)/2; //<PHONE_NUMBER>427387903
Assert.assertEquals(roundingIssueLong, (double)roundingIssueLong, 0.); // when compared as double, even with 0. as delta: passes
Assert.assertEquals(roundingIssueLong, (long) (double)roundingIssueLong); // when compared as long: fails (actual is<PHONE_NUMBER>427387904)

The scale labels are computed in ScaleBarOverlay.scaleBarLengthText(int meters)..
Of course the int meters parameter is not relevant anymore. The type can still be int (potentially long), but what minimum metric unit would make sense? Millimeters?
Today the labels in the metric unit are:

"i km" if the scale is above 5km
or "i.j km" if the scale is above 200m
or "i m"

What would the units and the thresholds be for the scales below the meter (for metric, imperial and nautical systems)?
Thank you for your help!

I just noticed about the "int/long scroll" issue: even if we fix it we'll be limited to zoom level 29 in a first approach.
Why? The formula in order to compute the primary key in SqlTileWriter for SQLite table "tiles" is
(((zoom << zoom) + x) << zoom) + y

The maximum possible zoom is therefore 29, which gives us enough space for:

y (29 bits)
x (29 bits)
zoom (5 bits) (in order to code 29)
total: 63 (29 + 29 + 5) bits used

I believe that zoom level 29 is high enough.
If needed there are solutions to bypass this limit, for instance:

creating one table per zoom level - the index can be calculated as x << 32 + y, and that will give us a max zoom of 32
splitting the SQLite table's primary key in several columns x, y and zoom, which will give us max zoom around 64 (pretty high, isn't it?)

@b3nn0 I delivered #329 which goes up to zoom level 29.
Could you check if it solved your issue?

Just updated to current master and compiled.
Great work on the zoom level. Really appreciated.
However, MapView.LayoutParams doesn't seem to work at all any more, I think. Neither in low, nor in high zoom levels. Currently trying to collect more information about the issue.

I was able to fix it with a simple modification to MapView.myOnLayout():
-                               getProjection().toMercatorPixels(mLayoutPoint.x, mLayoutPoint.y, mMercatorPoint);
-                               final long x = mMercatorPoint.x;
-                               final long y = mMercatorPoint.y;
+                               final long x = mLayoutPoint.x;
+                               final long y = mLayoutPoint.y;

I think the imprecisions are better, however, there seems to be a missing call to requestLayout().
When scrolling the map, the position doesn't update at all until i remove/readd the child view.

Your suggestions look fine to me. Thank you for your fix! Feel free to PR.


make IpEvent Send

The *mut esp_netif_t makes IpEvent not implement Send, so it's either unsafe impl Send for IpEvent {} as I've done here, or to wrap the pointer in RawHandleImpl, and have it implement RawHandle just like EspNetif, I'm ok with that too. @ivmarkov, what do you think?

Let's go with your strategy for now. I did the same for EthEvent.


TypeError: Cannot read property '__esModule' of undefined when I use /* webpackPrefetch: true */

Bug report

What is the current behavior?
I am building a React App on serverless framework. I use webpack to compile both client-side and server-side code with Loadable-Components to do codesplitting. Everything works fine until I try to add /* webpackPrefetch: true */ to any of the imports in my Loadables. When I do this, although everything still compiles fine, server code will hard crash when it tries to import my <App /> for the SSR.
TypeError: Cannot read property '__esModule' of undefined
    at /Users/alexgawley/code/serverless/tmp/loadable-repro/.webpack/service/src/servers/static.js:29310:34
    at Object.<anonymous> (/Users/alexgawley/code/serverless/tmp/loadable-repro/.webpack/service/src/servers/static.js:29312:12)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at /Users/alexgawley/code/serverless/tmp/loadable-repro/node_modules/serverless-offline/dist/lambda/handler-runner/in-process-runner/InProcessRunner.js:157:133
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async InProcessRunner.run (/Users/alexgawley/code/serverless/tmp/loadable-repro/node_modules/serverless-offline/dist/lambda/handler-runner/in-process-runner/InProcessRunner.js:157:9)

If I remove  /* webpackPrefetch: true */ everything works fine again. I've looked at the compiled code in both cases and there seems to be an additional __webpack_require__ function call in the prefetch version of the code that takes the well-formed __webpack_exports__ and overwrites it with undefined.
With /* webpackPrefetch: true */
/******/ 	// module factories are used so entry inlining is disabled
/******/ 	// startup
/******/ 	// Load entry module and return exports
/******/ 	var __webpack_exports__ = __webpack_require__("./src/servers/static.js");
/******/ 	__webpack_exports__ = __webpack_require__.O(__webpack_exports__);
/******/ 	var __webpack_export_target__ = exports;
/******/ 	for(var i in __webpack_exports__) __webpack_export_target__[i] = __webpack_exports__[i];
/******/ 	if(__webpack_exports__.__esModule) Object.defineProperty(__webpack_export_target__, "__esModule", { value: true });
/******/
/******/ })()

Without /* webpackPrefetch: true */
/******/ 	// module factories are used so entry inlining is disabled
/******/ 	// startup
/******/ 	// Load entry module and return exports
/******/ 	var __webpack_exports__ = __webpack_require__("./src/servers/static.js");
/******/ 	var __webpack_export_target__ = exports;
/******/ 	for(var i in __webpack_exports__) __webpack_export_target__[i] = __webpack_exports__[i];
/******/ 	if(__webpack_exports__.__esModule) Object.defineProperty(__webpack_export_target__, "__esModule", { value: true });
/******/
/******/ })()

Here's the definition of .O
(() => {
/******/ 		var deferred = [];
/******/ 		__webpack_require__.O = (result, chunkIds, fn, priority) => {
/******/ 			if(chunkIds) {
/******/ 				priority = priority || 0;
/******/ 				for(var i = deferred.length; i > 0 && deferred[i - 1][2] > priority; i--) deferred[i] = deferred[i - 1];
/******/ 				deferred[i] = [chunkIds, fn, priority];
/******/ 				return;
/******/ 			}
/******/ 			var notFulfilled = Infinity;
/******/ 			for (var i = 0; i < deferred.length; i++) {
/******/ 				var [chunkIds, fn, priority] = deferred[i];
/******/ 				var fulfilled = true;
/******/ 				for (var j = 0; j < chunkIds.length; j++) {
/******/ 					if ((priority & 1 === 0 || notFulfilled >= priority) && Object.keys(__webpack_require__.O).every((key) => (__webpack_require__.O[key](chunkIds[j])))) {
/******/ 						chunkIds.splice(j--, 1);
/******/ 					} else {
/******/ 						fulfilled = false;
/******/ 						if(priority < notFulfilled) notFulfilled = priority;
/******/ 					}
/******/ 				}
/******/ 				if(fulfilled) {
/******/ 					deferred.splice(i--, 1)
/******/ 					result = fn();
/******/ 				}
/******/ 			}
/******/ 			return result;
/******/ 		};
/******/ 	})();

If the current behavior is a bug, please provide the steps to reproduce.
git clone https://github.com/agawley/loadable-repro
npm i
npm run offline

load http://localhost:3000
Remove /* webpackPrefetch: true */ from src/client/app.js for everything to work fine.

What is the expected behavior?
I shouldn't get this error. My understanding is that adding /* webpackPrefetch: true */ should "just work".

Other relevant information:
webpack version:  5.16.0
Node.js version: 12.22.1
Operating System: macOS 10.15.7
Additional tools: See package.json in https://github.com/agawley/loadable-repro

Duplicate https://github.com/webpack/webpack/issues/12993, you can check it using patch from https://github.com/webpack/webpack/pull/13431

Thanks @alexander-akait. Patch confirms this is the issue.


Issuse #4629 resolved

I have read the CLA Document and I hereby sign the CLA
What's the purpose of this PR
Change ```` to ```
Which issue(s) this PR fixes:
Fixes #4629
Brief changelog
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Read the Contributing Guide before making this pull request.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit tests to verify the code.
[x] Run mvn clean test to make sure this pull request doesn't break anything.
[ ] Update the CHANGES log.

I have read the CLA Document and I hereby sign the CLA

I hope that I don't miss anything

All ```` key word in .md file collected in md.log, I collect them by run
grep -n "\`\{4\}" $(find . -type f -name "*.md") > md.log

Please check for any omissions, thanks.

All ```` key word in .md file collected in md.log, I collect them by run
grep -n "\`\{4\}" $(find . -type f -name "*.md") > md.log

Please check for any omissions, thanks.

Thanks a lots, I use this command and file md.log show as below:

I think that I didn't miss anything when I modify ```` to ```.
Thank a lots!

All ```` key word in .md file collected in md.log, I collect them by run
grep -n "\`\{4\}" $(find . -type f -name "*.md") > md.log

Please check for any omissions, thanks.

Thanks a lots, I use this command and file md.log show as below:
I think that I didn't miss anything when I modify ```` to ```. Thank a lots!

Oh, I have a error in this command, I fixed this and result as below:

Please change the pr's title to more readable.
For example:

docs: fix markdown code blocks by change 4 back quote to 3 back quote

Please change the pr's title to more readable.
For example:

docs: fix markdown code blocks by change 4 back quote to 3 back quote

Yes, thanks! I changed it.


Newest Opensora HQ-Version

Will more opensora weights be released? For example, the 64x512x512 mentioned

Thanks for your interest. Yes, there will be more in a few weeks.


Additional CSS amazingness

Each addition was done as a single commit, final commit is fixing something that I think VS code was doing where it was fleshing out the TOC in the CSS section 🤷🏻  :)

This is great! Thanks a lot for the contribution 🙌


DOC: stylistic revision, punctuation, consistency

This is the last pull request regarding the comprehensive stylistic revision, punctuation correction, and consistency revision in the current documentation.
In case there's another mismatch between the error strings, I already know how to fix it and will do so immediately.
EDIT: there seems to be some issue with mingw (but I've noticed that it's a common problem in the latest pull requests)

EDIT: there seems to be some issue with mingw (but I've noticed that it's a common problem in the latest pull requests)

Yes, please ignore those. The server we download from seems to be a bit unreliable, not much we can do about it at the moment.


File validation changes form data

Hey, I'm trying to validate the input file size and dimensions (image width/height). I save the file in redux store to validate it. The stored file object has properties: type, size, preview, etc. so I can validate this properties.
However, when the validation is triggered, the form field's properties are erased and the field now looks like this:
field: {
  value: {
    preview: "blob:..."
  }
}

Same thing happens when using sync or async validation.
Any idea, why it happens and how it can be fixed?

Solved using blob instead of a file.


fix private method include

Ruby 2.0 in production raise error:
private method `include' called for Her::Model::Relation:Class
this commit fix this error

@superp thank you! I'll create a new release in a few hours.

@superp release 0.0.4 done.


Split InsertColumnsToken from InsertOptimizeResult

Fixes #2319.
Ref #2386

Pull Request Test Coverage Report for Build 8099

24 of 134 (17.91%)  changed or added relevant lines in 11 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.4%) to 60.441%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/encrypt/ShardingEncryptorEngine.java
0
5
0.0%

sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/encrypt/ShardingEncryptorStrategy.java
0
6
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/extractor/impl/dml/insert/InsertColumnsExtractor.java
0
6
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/sql/token/impl/InsertColumnsToken.java
0
6
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/filler/encrypt/dml/insert/EncryptInsertValuesFiller.java
0
10
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/filler/encrypt/dml/insert/EncryptInsertColumnsFiller.java
0
16
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/filler/sharding/dml/insert/ShardingInsertValuesFiller.java
0
21
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/filler/sharding/dml/insert/ShardingInsertColumnsFiller.java
0
40
0.0%

Files with Coverage Reduction
New Missed Lines
%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/filler/encrypt/dml/insert/EncryptInsertValuesFiller.java
1
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/filler/sharding/dml/insert/ShardingInsertValuesFiller.java
1
0.0%

Totals

Change from base Build 8098:
-0.4%

Covered Lines:
8712

Relevant Lines:
14414

💛  - Coveralls


Tests

Hi Dan,
First thanks for the library :+1:  I started writing my own version of this and stopped when I found yours.
I created some tests (this includes travis integration... I think you'll you have to enable it on your side from your account).
I plan to write some more tests so that we can have them, and for my own understanding of the API you've created.

I have two questions:

Would you be opposed to using PSR-2 for coding standards?
Would you be ok with dropping PHP 5.3 support? Maybe even 5.4 as well? Both are EOL.

Hey, sorry for the delay in getting back to you on this.
Firstly, thanks for your work on this!  I'm not really opposed to psr-2 or whitespace trimming, but what would be the reason to drop php 5.3 and 5.4 support? More precisely, what changes would you like to make that would cause it to no longer run under those versions?

Looking at the code the only 5.3 breaking change I can see is the use of [] vs array(), which I personally do not feel is a good enough reason to drop support for something many people still use.

Hi Dan- I mean to drop support because even the PHP core team does not
support 5.3 (or 5.4) anymore. They will have permanent security
vulnerabilities and should not be used anywhere by anyone actively
maintaining code.
I'm of the opinion "move fast," where people using legacy software should
stick with legacy versions of everything and not expect others in the
ecosystem to support them. I think supporting EOL software can cripple a
project in the long run, because you always have to be aware of what weird
edge cases you might break. You are ultimately limited to the feature set
of them lowest version you are supporting (5.3 is pretty bad imo).
But as this is your library, you make the call. If you want to support 5.3,
I will update the PR so you can merge it with tests passing on 5.3. Let me
know.
On Sun, May 22, 2016 at 7:44 AM Daniel Carbone<EMAIL_ADDRESS>wrote:

Looking at the code the only 5.3 breaking change I can see is the use of
[] vs array(), which I personally do not feel is a good enough reason to
drop support for something many people still use.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/dcarbone/tns-parser/pull/1#issuecomment-220828043

After thinking about it I honestly don't care enough to take a stand on it, haha. I appreciate the work you're doing and as a general rule I agree with your upgrading statements. My only hesitation is that this lib just does relatively simple string and file manipulation, which has no inherent requirement that precludes it from running under a 5.3 or 5.4 interpreter.
If you would prefer to update the composer.json file to stipulate 5.4+ to support JsonSerializable interface functionality and the updated array syntax, I'd be ok with that. If your work requires something that is just not available in 5.4 we can address it then.
tl;dr: I'm ok with 5.4+ and will merge your changes if you update the composer.json file to reflect the requirement.  Sound good?

Updated PR. Tests passing:
https://travis-ci.org/avindra/tns-parser/builds/132286593

Looks good, thanks!


Reports - Fix default character_code

Use the document ApiResponse Content-Encoding header as character_code by default to decode the Report document correctly.
This will simplify the usage of the ReportsClient and will avoid the client of this utility needing to know the encoding to use for certain reports in different marketplaces.
Reference: This logic is already used in the Feeds client

Thanks, that makes a lot of sense. Can you please bump the version, I'll create a release then. 0.17.6 I think. I can't do it rn.
https://github.com/saleweaver/python-amazon-sp-api/blob/master/sp_api/__version__.py

Hey @saleweaver , thanks for the quick response, do you want me to bump the version in this same PR?

Yes please


[Question]: ImportError: cannot import name 'BASE_TRACE_EVENT' from 'llama_index.callbacks.schema'

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
when I try use from llama_index  import download_loader showing below error
ImportError: cannot import name 'BASE_TRACE_EVENT' from 'llama_index.callbacks.schema'
here is the code I am used
from llama_index  import download_loader
from llama_index.callbacks.schema import CBEventType
CJKPDFReader = download_loader("CJKPDFReader")
loader = CJKPDFReader()
documents = loader.load_data(file='data\test.pdf')
print(documents)

That import definitely exists
https://github.com/run-llama/llama_index/blob/2b8f720d7cae705ff8effeabe133b4765689ea01/llama_index/callbacks/schema.py#L12
I'm not sure why you are importing CBEventType. Either remove that import or reinstall llama-index in a fresh venv, sounds like your installation is outdated/wonky


Unable to locate libR.dylib

I have the latest version of R installed via Homebew (homebrew/science/r-3.2.3).
I am on OSX 10.11.1
I manually set  ENV["R_HOME"] = "/usr/local/Cellar/r/3.2.3/"
When I call Pkg.build("RCall")
I get the following error
LoadError: Unable to locate libR.dylib
Try setting R_HOME, and re-run Pkg.build("RCall").
while loading /Users/rodonn/.julia/v0.4/RCall/deps/build.jl, in expression starting on line 3

I tried adding
ENV["DYLD_LIBRARY_PATH"] = "/usr/local/Cellar/r/3.2.3/lib"
ENV["LD_LIBRARY_PATH"] = "/usr/local/Cellar/r/3.2.3/lib"

but I still get the same error.
Thanks!

Would you try running Rscript -e "cat(Sys.getenv('R_HOME'))" in your terminal?

Ok that fixed it. Thanks for your help. Sorry I didn't realize what the correct value for R_HOME should have been "/usr/local/Cellar/r/3.2.3/R.framework/Resources".

Just try to understand what is happening. Are you using the binary distribution on OSX?

You shouldn't need to set R_HOME at all if you're using the homebrew/science tap. What happens if you run Pkg.build("RCall") without having it set?

On OS X, Applications have their PATH set by launchctl, not by the shell. That was why I asked if his Julia in the binary distribution. On OS X, the PATH variable can be obtained by running
/usr/bin/login -fpql $USER $SHELL -l -c 'echo -n $PATH'

Ah...actually, if Rscript is not found, this line will be erroneous. It wouldn't wait until the line LoadError: Unable to locate libR.dylib.

I get the same error if I set R_HOME as above: the problem is that R warns that this conflicts with its own:
julia> ENV["R_HOME"]="/usr/local/Cellar/r/3.2.3/"
"/usr/local/Cellar/r/3.2.3/"

julia> Rscript = joinpath(ENV["R_HOME"],"bin","Rscript")
"/usr/local/Cellar/r/3.2.3/bin/Rscript"

julia> readall(`$Rscript -e "cat(Sys.getenv('R_HOME'))"`)
"WARNING: ignoring environment value of R_HOME\n/usr/local/Cellar/r/3.2.3/R.framework/Resources"

I installed R with brew.
I installed RStudio and julia using brew cask.
The first thing I tried was Pkg.build("RCall") without making any modifications to ENV, but I got an error about not being able to find R.
I'm not able to replicate my problem though. Now if I open a fresh session of R and call Pkg.build("RCall") it builds correctly without any errors.

How did you install Julia (and which version)?

The library search logic has been changed. Do reopen though if this is still an issue.


[BUG] Pasting from loop (MSFT) throws an error

[x] I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
[x] I have read the documentation and cannot find an answer.

Describe the bug
When I paste from loop, a Microsoft online app, the pasted HTML contains some errors.
Unfortunately I can't share the source.
Would it be possible to register a "paste helper", some way for me to be able to cleanup the content that is being pasted before the editor takes over?
Expected behavior
Paste from other system, such as loop, will work as expected. Allowing the developer to parse/manipulate and cleanup the pasted content before applying it to the editor.
Screenshots

Additional context
It would be great if we can register a custom paste handler, that will be able to manipulate the pasted content before applying it to the editor.
Otherwise, just fixing the paste process to handle what might be a broken HTML would also be good enough - the HTML content is produced by loop.microsoft.com when copying the page content.
In my tests, I have run the HTML through TurndownService to convert it to markdown and it worked perfectly. It would be awesome to have that feature built in, or to allow devs to write our own paste handler.

To update, the bug on paste still exists but I did figure out how to write a custom paste handler, in case anyone else needs it.
I will work on trying to make it take over the paste.
export const pastePlugin = realmPlugin({
  init(realm, params) {
    realm.pub(createActiveEditorSubscription$, editor => {
      return editor?.registerCommand(PASTE_COMMAND, (event: ClipboardEvent) => {
        let cbPayload = Array.from(event.clipboardData?.items || [])
        cbPayload = cbPayload.filter((i) => /html/.test(i.type)) // Strip out the non-html bits
        //todo...
        //return true if command handled
        return true;
      },
        COMMAND_PRIORITY_CRITICAL);
    });
  }
});

Yeah, I was able to complete my goal of fixing the html before paste. however - the bug of pasting from loop remains with the error above - if you would like I can show you in a share session but I cannot share the loop data publicly.
Thanks!


__reset_vector symbol placed incorrectly

link.x.in has this for placing the vector table members:
  .vector_table ORIGIN(FLASH) :
  {
    __vector_table = .;

    /* Initial Stack Pointer (SP) value. */
    LONG(_stack_start & 0xFFFFFFF8);

    /* Reset vector */
    KEEP(*(.vector_table.reset_vector));
    __reset_vector = .;

However when looking at the contents of the elf with nm, we see this at the start:
10000100 R __vector_table
10000104 00000004 R __RESET_VECTOR
10000108 00000038 R __EXCEPTIONS
10000108 R __reset_vector
10000140 00000080 R __INTERRUPTS

Here, __RESET_VECTOR is correctly placed at offset 4, but __reset_vector is placed at offset 8.
I tried adding an NMI (which should be at offset 8), and it was placed correctly, so I don't think there is any problem with layout, but the lowercase symbol is misleading.
Also this assert just looks wrong to me:
/* ## .vector_table */
ASSERT(__reset_vector == ADDR(.vector_table) + 0x8, "
BUG(cortex-m-rt): the reset vector is missing");

The vector table should be:

0x0: Stack Pointer
0x4: Reset Vector
0x8: NMI Vector
...

Tested with
active toolchain
----------------

nightly-2023-08-19-aarch64-apple-darwin
rustc 1.73.0-nightly (d06ca0ffa 2023-08-18)

[[package]]
name = "cortex-m-rt"
version = "0.7.3"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "ee84e813d593101b1723e13ec38b6ab6abbdbaaa4546553f5395ed274079ddb1"
dependencies = [
 "cortex-m-rt-macros",
]

Suggestion from @Dirbaio: we could rename this as __exceptions since this symbol actually tracks the start of exceptions (immediately after the reset vector)
AFAICT this symbol is just used as a check (in the assert) that the reset vector (and perhaps the vector table itself) exists.

Suggested names:

__ereset_vector
__reset_vector_end
__exceptions

General consensus from discussion:

Yes, probably fine to make this change
Prefer rename over remove
Probably fine to go in the 0.7.x train


Add more layout options with images

Sometimes we want to showcase more than one image per slide, so it would be useful if we could get layout options with different grids. For example:

4 images

2x2
1x4
4x1

3 images

2x2 (big image on its own row)
2x2 (big image on its own column)
3x1
1x3

2 images

2x1
1x2

Hey @george-gca, thanks for this feature request.
I agree, this would be a great enhancement. Though, I'm afraid I won't the time in the near future to implement this.
Looking for contributions!


Broken handling of first child of links when it doesn’t have a value

L33.
Can occur with badges (e.g., a travis image inside a link), or with emphasis, but also for empty links (which are weird but perfectly valid).

Fixed by https://github.com/ben-eb/remark-word-wrap/commit/0c53e60290a7bfbdfb04bca19f75ab66dbe85814.


Improve failed Kobo authentication behavior in the frontend; COUNTRY=cambodia

This fixes issue https://github.com/WFP-VAM/prism-app/issues/560 and https://github.com/WFP-VAM/prism-app/issues/910.
How to test the feature:

use country cambodia
from field reports use flood report
enter incorrect kobo credentials
see that the auth modal is still showing and "Authentication failed" message appears
the layer is turned off when cancel is click on the auth modal

Screenshot/video of feature:

This looks good. Thanks for the fix @echaidemenos


Given name and Family name oddly used in American English (en) locale

All the English used in the "en" locale follows standard American English, except for "Given name" and "Family name", which should be "First name" and "Last name" respectively.
"Given name" and "Family name" would be appropriate for British English, but there is no en_GB locale in this project.
I noticed this when playing with the demo:

We prefer "given name" as it's a broader term and it applies to people from all cultures where "first name" is a Christian construct and is only used in some western cultures. We don't translate these fields on a per-country basis.

No worries - search and replace would solve that.  Saleor currently seems EU-centric, but I do see some efforts in the roadmap to make it more US-friendly (e.g. FedEx/UPS shipping integrations), so I'll keep checking back.


Review and cleanup variables

As a developer, I would like fewer and more distinct variable definitions so that I can accomodate white-labeling and theming options.
The variables defined in the current version of Techne is un-manageable and cannot be themed in the current state. As is, we would have to map, for example, @default-greyblue to another color, probably not blue or grey.
Colors should be defined for their use and not their actual color so that @color-text could be blue or black or red with no need to change the variable name.
https://github.com/SAP/techne/blob/develop/src/less/globals/themes/_techne.less
It is recommended that variables be named related to the CSS rule for which they are most commonly used (using a BEM-like notation). For example, you may write a rule like border-color: $border-color--table; or color: $color--alert.
Basically, we need an audit of the entire variables file with recommendations for cleanup and consolidation.

@xak
It is already been done that way for the variable names. Take a look at
https://github.com/SAP/techne/blob/feature/CCE-v2.0/src/techne/system/colors.scss
and
https://github.com/SAP/techne/blob/feature/CCE-v2.0/src/techne/system/spacing.scss
Those are generic names.
Will like to avoid the double dash "--". Don't bring any clarity.
Theming: What is still not in place is the "theming" functionality. If you can jump in and implement that on the POC it will be nice, you are the most experienced with SASS from all us :)
Audit... we are not porting everything from v1.5.x to v2.0. So we can skip that and create the new variables from scratch as we need it.

Theming will be addressed on #594


Disabling tests breaks cmake files installation dir

Hi, first off, Thank you for this library.
I build libE57Format locally like this:
cmake -B build -S libE57Format -DCMAKE_INSTALL_PREFIX=/usr -DE57_BUILD_SHARED=ON -DE57_BUILD_TEST=OFF

This works with version 3.1.1, however with version 3.2.0, somehow, setting -DE57_BUILD_TEST=OFF breaks the path generation for the cmake files, which causes it to install them to /cmake instead of /usr/lib/cmake. Setting -DE57_BUILD_TEST=ON gives me the correct path again.

This change uses CMAKE_INSTALL_LIBDIR to set the default path and allow the whole thing to be overridden by E57_INSTALL_CMAKEDIR.
There's a STATUS message that outputs this info. Can you please add the cmake output (everything from -- Using CMake x.y.z?
What OS are you using?
I can't see anything in the testing which changes/overrides any of this and I cannot reproduce it here with CMake 3.31.1 on macOS.

I'm using an Arch Linux. This is part of a package build.
A bit of context on the directory structure:
/home/adrian/builds/e57format-git
├── pkg              <-- this is where the build should be installed to. This is the package root. It should contain `usr/` etc.
└── src
    ├── build        <-- This is where CMake should build
    └── libE57Format <-- This is the checked out git repo

First step:
cmake -B build -S libE57Format -DCMAKE_INSTALL_PREFIX=/usr -DE57_BUILD_SHARED=ON -DE57_BUILD_TEST=OFF

Output:
- Using CMake 3.31.1
-- The CXX compiler identification is GNU 14.2.1
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/lib/ccache/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found XercesC: /usr/lib/libxerces-c.so (found version "3.2.5")
-- [E57Format] Revision ID: E57Format-3.2.0-x86_64-gcc142 (git v3.2.0)
-- [E57Format] Building shared library
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- Submodule update using git (/usr/bin/git)
-- Submodule update directory: /home/adrian/builds/e57format-git/src/libE57Format
-- Submodule update complete
-- [E57Format] Setting validation level to 1
-- [E57Format] Using ccache: /usr/bin/ccache
-- [E57Format] Using clang-format: /usr/bin/clang-format
-- [E57Format] CMake files install to /usr//cmake/E57Format
-- Configuring done (1.0s)
-- Generating done (0.0s)
-- Build files have been written to: /home/adrian/builds/e57format-git/src/build

Interesting to me is the line -- [E57Format] CMake files install to /usr//cmake/E57Format. That should've been /usr/lib/cmake/E57Format, I guess.
Second step is cmake --build build which outputs just CMake build progress and nothing else.
The install step for the package is
DESTDIR="/home/adrian/builds/e57format-git/pkg/e57format-git" cmake --install build

which outputs:
-- Install configuration: ""
-- Installing: /home/adrian/builds/e57format-git/pkg/e57format-git/usr/include/E57Format/E57Export.h
-- Installing: /home/adrian/builds/e57format-git/pkg/e57format-git/usr/include/E57Format/E57Format.h
-- Installing: /home/adrian/builds/e57format-git/pkg/e57format-git/usr/include/E57Format/E57Exception.h
-- Installing: /home/adrian/builds/e57format-git/pkg/e57format-git/usr/include/E57Format/E57SimpleData.h
-- Installing: /home/adrian/builds/e57format-git/pkg/e57format-git/usr/include/E57Format/E57SimpleReader.h
-- Installing: /home/adrian/builds/e57format-git/pkg/e57format-git/usr/include/E57Format/E57SimpleWriter.h
-- Installing: /home/adrian/builds/e57format-git/pkg/e57format-git/usr/include/E57Format/E57Version.h
-- Installing: /home/adrian/builds/e57format-git/pkg/e57format-git/usr/lib/libE57Format.so.3.2.0
-- Installing: /home/adrian/builds/e57format-git/pkg/e57format-git/usr/lib/libE57Format.so.3
-- Installing: /home/adrian/builds/e57format-git/pkg/e57format-git/usr/lib/libE57Format.so
-- Installing: /home/adrian/builds/e57format-git/pkg/e57format-git/cmake/E57Format/E57Format-export.cmake
-- Installing: /home/adrian/builds/e57format-git/pkg/e57format-git/cmake/E57Format/E57Format-export-noconfig.cmake
-- Installing: /home/adrian/builds/e57format-git/pkg/e57format-git/cmake/E57Format/e57format-config.cmake

This is correct for the includes and the built library files, but the cmake files are in the wrong path.

If I set -DE57_BUILD_TEST=ON:
-- Using CMake 3.31.1
-- The CXX compiler identification is GNU 14.2.1
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/lib/ccache/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found XercesC: /usr/lib/libxerces-c.so (found version "3.2.5")
-- [E57Format] Revision ID: E57Format-3.2.0-x86_64-gcc142 (git v3.2.0)
-- [E57Format] Building shared library
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- Submodule update using git (/usr/bin/git)
-- Submodule update directory: /home/adrian/builds/e57format-git/src/libE57Format
Submodule path 'test/extern/googletest': checked out 'fa6de7f4382f5c8fb8b9e32eea28a2eb44966c32'
-- Submodule update complete
-- [E57Format] Setting validation level to 1
-- [E57Format] Using ccache: /usr/bin/ccache
-- [E57Format] Using clang-format: /usr/bin/clang-format
-- [E57Format] Testing enabled
-- [testE57] Enabling address sanitizer (ASan)
-- [testE57] Enabling undefined behaviour sanitizer (UBSan)
-- [testE57] Using ccache: /usr/bin/ccache
CMake Warning at test/CMakeLists.txt:86 (message):
  [E57 Test] Test data not found.  Please set E57_TEST_DATA_PATH to the
  directory containing libE57Format-test-data.

-- The C compiler identification is GNU 14.2.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/lib/ccache/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- [gtest_main] Enabling address sanitizer (ASan)
-- [gtest_main] Enabling undefined behaviour sanitizer (UBSan)
-- [E57Format] CMake files install to /usr/lib/cmake/E57Format
-- Configuring done (3.5s)
-- Generating done (0.0s)
-- Build files have been written to: /home/adrian/builds/e57format-git/src/build

Interesting to me is the line -- [E57Format] CMake files install to /usr//cmake/E57Format. That should've been /usr/lib/cmake/E57Format, I guess.

Yes, exactly. That seems to indicate that CMAKE_INSTALL_LIBDIR is somehow empty. The only ref I found w.r.t. Arch with a quick search is this one which implies that it should be set properly.
Could you please output CMAKE_INSTALL_LIBDIR at the beginning of the cmake file so we can see what the default is?
message( STATUS "[CMAKE_INSTALL_PREFIX] ${CMAKE_INSTALL_PREFIX}" )

(And then maybe try it again with the "working" options E57_BUILD_TEST=ON to see if it's different.)
The second issue is that the install doesn't seem to be using the DESTINATION properly.
I don't know a lot about the CMake options for cmake installation since I don't ever do that, but the options are the same for the lib and for the cmake file so I would have expected them to end up in the same place... Maybe a difference between EXPORT and FILES? Maybe there's a clue in here? I don't have time to look through that at the moment.

CMAKE_INSTALL_LIBDIR is indeed empty.
I noticed that this is part of the GNUInstallDirs module. A quick search showed that this module is only included in googletest (libE57Format/test/extern/googletest/CMakeLists.txt).
That explains it: The module is only loaded via googletest and therefore only if tests are enabled. Otherwise it's not loaded at all, and that's why CMAKE_INSTALL_LIBDIR is never set.
I created PR #315 which should fix this :)

Thank you for looking into this so quickly and guiding me in the correct direction! :)


SRAM DRCs

Hi. I'm using Innovus for PnR, and precheck for DRC check. I'm having difficulty passing a GDS with SRAM through the "Klayout minimum metal density area clearance" check; It gives 1200 errors, all in SRAM, 200 errors per layer, from li to met5. Can anyone advise what this means? I apologize if it is already somewhere in the internet; in that case, kindly share the link.
Edit: I've placed placement halo, and routing halo for layers li1 to met4, with a space of 2 um around the SRAM instance.

I do know that the rule implementation for density rules in the klayout precheck deck has wild-carded the layer purposes such that almost every purpose other than, I think, metal hole (and recently, metal fill block) is considered metal for the purpose of counting metal for density.
Since I am not aware of the SRAM causing problems like this in the openlane flow, my best guess is that Innovus is putting some layer type over the entire SRAM layout, or a large portion of it, that is getting interpreted by the klayout DRC rule as counting toward total metal area, when it should not be.  Quite possibly it's the halo that's doing it.  What layer/purpose do you use for the placement halo (assuming it's translated into GDS)?

Placement halo to prevent placement of anything on or around it, and routing halo to prevent routing from li1 to met4. Though, there are a lot of power straps in met5 overlapping with SRAM; is that fine? Kindly also tell if maximum density rules are also getting checked here or not. Thank you so much for your timely response.

Power straps can be a problem for over-density of metal, but it's rare and I'm pretty sure that's not the problem here since you're getting errors reported on every single metal layer.
Note that "minimum metal density clear area" is the same as "maximum metal density".  The "clear area" indicates that the mask is inverse, and is a confusing nomenclature that I don't much like.  The precheck density check is intended to catch areas of too much metal.  The opposite check, for too little metal, is assumed to be taken care of by automatic fill pattern generation.  There is a final check for under-density of metal after the fill pattern generation, but it's not part of precheck, and it is a pretty rare case that fails under-density.  But if you're already over-density in metal, then adding fill patterns isn't going to make anything better.  So that one can be calculated in pre-check.
So my suspicion here is that your placement halos are getting written to GDS as some layer with the same layer as the metal but a different purpose number, and that layer is confusing klayout into believing that the entire SRAM is covered with 100% metal on all layers, resulting in a check failure.  I'm trying to find out what that GDS layer:purpose pair number is, because I can then correct the rule to ignore it and not count it as metal area when doing the density check.

Thanks again. I'll try to compare the layer map with the metal layers:purposes in skywater Excel sheet, on my next work day, and shall share what I can. A slightly irrelevant noobish question: Innovus demands a cut layer between nwell and pwell, so the guys who made the skywater plugin for UCB's hammer, put a CUT layer named licon1 between nwell and pwell in the sky130_fd_sc_hd techlef, with nothing else described for licon1 except that it's a CUT layer. Is this harmless?

Sorry, correction of previous comment:
Edit: A slightly irrelevant noobish question:
There is an issue at the following link:
https://github.com/google/skywater-pdk/issues/308
Can you kindly express your opinion about the edit suggested there? Is it a harmless edit? I'm asking here because there was no response to my comment there.

Hammer provided this lefpin map file for sky130:
sky130_lefpin_map.txt
There are some mismatches between this file and the skywater layer info excel sheet. For example, purpose numbers 41 and 58, are used in this file, but not mentioned in the excel sheet. Could this be causing confusion in DRC?
Kindly tell your opinion about another question as well: there are some purpose numbers mentioned in the skywater layer info excel sheet, which were not used in this layer map file, e.g. 13, 10, 60, 0, 14, 25 and 15. They are also not mentioned in a layer map discussed in this issue:
https://github.com/google/skywater-pdk/issues/313
Would the absence of these purpose numbers in the map file cause issues in fabrication?

Reading the DRC script solved the problem. It expects die area bounding box in layer 235, purpose number 4, which was not in my innovus layer map file. Including the following in the layer map file solved the problem:
DIEAREA                 ALL              235   4


Inline Multiple Vars Prompt and Highlight Capabilities

As discussed in #175, this PR changes inline var so that it does not require the cursor to be on an identifier in order for the function to work.
New Features

Instead of requiring the user to have their cursor on the variable identifier, they can arbitrarily select a declaration in visual mode and the plugin will automatically determine the variable to inline

I decided to do it using visual selection because the current line isn't always reliable (multiple declarations are sometimes split into lines for formatting)
If there are multiple variables to inline, the plugin will prompt the user for which one to inline.

Limitations/Next Steps

Currently, if there are multiple variables in the line, I've made it so that the plugin does not erase any declarations (unlike if there was only one, in which case it would). Figuring out how to get rid of a single variable declaration is a lot of work because it's different in each language; it should probably be another PR.
The prompt functionality and inlining with multiple declarations in one line does not work for Python. Python's syntax tree is built in such a way that queries must be altered depending on the situation, which will take a whole other set of logic that isn't relevant to this PR. However, highlighting works and grabbing the node from the cursor works as usual.
Is there an alternative to print to log a message in nvim? I didn't know what to use so just put print for now; I can change this if necessary.

@ThePrimeagen @teddylear, this is a large set of changes, so if possible at some point, could you let me know what you think about this? I feel like there are some parts of this where there's a cleaner approach.

@pranavrao145 sorry I've been slow to review, I'll take a look over the weekend.

No worries, appreciate you taking the time :)


Updated symbol to allow pausing refresh and better handle edits while refreshing

Dan, I updated the repo yesterday for the release. You will have to get the latest, but in this file there is just 1 minor change.
window.Coresight
should be
window.PIVisualization


Incorrect check for files that don't exist

This code in ResourceExistenceChecker::checkResources() doesn't seem to work correctly.
If a file doesn't exist, glob returns an empty array, so checkResource() never gets called.
$resource = array('some-file-that-doesnt-exist.txt');

            $glob = glob($resource);
            if ($glob === false) {
                $this->printTaskError(sprintf('Invalid glob "%s"!', $resource), $this);
                $success = false;
                continue;
            }
            foreach ($glob as $resource) {
                if (!$this->checkResource($resource, $type)) {
                    $success = false;
                }
            }

#238, #231

Maybe having the glob in the loop would be better?
foreach ($resources as $resource) {
	$glob = glob($resource);
	if ($glob === false) {
	    $this->printTaskError(sprintf('Invalid glob "%s"!', $resource), $this);
	    $success = false;
	    continue;
	}

	if (!$this->checkResource($resource, $type)) {
		$success = false;
	}
}

Nah. That doesn't make sense. It's already in some other loop.
Maybe this?
Or is a count of zero a different error to false?
$glob = glob($resource);
if ($glob === false || count($glob) == 0) {
	$this->printTaskError(sprintf('Invalid glob "%s"!', $resource), $this);
	$success = false;
	continue;
}

foreach ($glob as $resource) {
	if (!$this->checkResource($resource, $type)) {
		$success = false;
	}
}

Just came across this issue again.
Maybe this?
if(count($glob) == 0) {
    return false;
}

Would that be a BC break? Would you expect glob returning an empty array to sometimes be considered success?


CompositeMode ADT

I noticed that the argument to globalCompositeOperation can only be one of 11 possible choices (at least, on most browsers. Firefox has more, but they're not widely supported), so I changed its argument from Text to a CompositeMode ADT to enforce greater type safety.
I'll make this a pull request for now, since we should probably avoid making significant API changes while the blank-canvas paper is being written.

Closing stale PR.


Correct broken BCP47 link

Hi!
Thanks for the PR :)
Could you please add yourself to the AUTHORS file, as well as add a line in the CHANGELOG?
Thanks in advance,
Benjamin Van Ryseghem

It looks like your develop branch was not up to date :smile:
Also, could you squash all your commits into a single one?
Thanks in advance :smile:

Thanks a lot!!

Sure, no worries.
Github for open source has some issues, but I probably shoulr use the github command line tool or something, since git by itself doesn't seem to allow me to track one branch but push updates to another origin and another branch.
There likely is some good PR-tool layered on top of plumbing, just I don't know which. Gerrit and GitKraken didn't convince me. I like command line tools and rebase -i. Otherwise gitup is by current best bet for managing messy branch/merge issues and splitting + rearranging commits

since git by itself doesn't seem to allow me to track one branch but push updates to another origin and another branch.

I am not sure to understand :smile:

Thanks, I'm just looking for new knowledge on using github effectively for open source.
But I made one more try, with a "hack" in my local .git/config file. Trying to hack command line git into allowing me to base (and have git pull --rebase) use upstream = the software maintainer's repository, but still have git push send commits to my own where I have write access.
This maybe works at least partially:
https://www.dropbox.com/s/kh2dvdsdugolm97/Screenshot 2019-12-13 13.38.03.png?dl=0
But I expect this to break something somewhere. Will see when next change on develop is merged, if I learnt something new or just created more work for myself (and any readers).
Anyway, have a nice day!

git remote add pr git@github.com:BenjaminVanRyseghem/numbro.git git fetch pr git checkout develop git rebase pr/develop git push --force-with-lease origin/develop
something like that might do, or ?

in numbro 2.2.0


Run rush lint without warnings or failures

Until #11240 is fixed, we need to rely on running rush lint locally as and when we change/add a linting rule to the eslint plugin in this repo. While running this today, we see the below error:

While the PR #11254 fixes the above PR, we are left with the below warnings which should be fixed as well

https://github.com/Azure/azure-sdk-for-js/pull/11254 unblocks the rush lint command by ignoring the array index in the no-magic-numbers rule. An alternate solution to the problem is welcome as well

@deyaaeldeen rush lint is again failing due to linting errors in the eslint plugin itself. Please take a look. Also, lets explore how we can avoid getting into this state in the future by running rush lint in the CI at some stage
cc @praveenkuttappan

I think the issue is we did not have pipelines for keyvault-common and for the eslint plugin. hey @praveenkuttappan, can we setup pipelines for https://github.com/Azure/azure-sdk-for-js/tree/master/common/tools/eslint-plugin-azure-sdk and for https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/keyvault/keyvault-common ? They are not releasable packages, so the purpose is for testing in CI only. Also, can we somehow make the analyze step in the case of a warning?

I think I am wrong about keyvault-common because it looks like changes there triggered the pipeline for keyvault packages. I am not sure how the analyze step were succeeding before when there were linting errors.


shadowsocks-rust: 1.10.3 -> 1.10.5

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 119098 run on x86_64-darwin 1

1 package built:

shadowsocks-rust


Add D7SMS Connector

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: d7networks sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Added Readme file

Added Readme file

Thank you!


Pivot table changes are not relevant

Describe the bug
When I make a change to the User model and assign a role (Many to Many relation). The changes that are added to the attributes and old array keys of the changes made are the same.
To Reproduce
I have a basic many to many relation between the User Model and the Role Model.
The user model looks like this:
<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Database\Eloquent\SoftDeletes;
use Illuminate\Foundation\Auth\User as Authenticatable;
use Illuminate\Notifications\Notifiable;
use Laravel\Sanctum\HasApiTokens;
use Spatie\Activitylog\LogOptions;
use Spatie\Activitylog\Traits\LogsActivity;

**User Model:**
class User extends Authenticatable
{
    use HasApiTokens;
    use HasFactory;
    use Notifiable;
    use SoftDeletes;
    use LogsActivity;

    /**
     * The attributes that are mass assignable.
     *
     * @var string[]
     */
    protected $fillable = [
        'name',
        'email',
        'active',
        'password',
    ];

    protected $dates = ['last_login', 'deleted_at'];

    /**
     * The attributes that should be hidden for serialization.
     *
     * @var array
     */
    protected $hidden = [
        'password',
        'remember_token',
    ];

    /**
     * The attributes that should be cast.
     *
     * @var array
     */
    protected $casts = [
        'email_verified_at' => 'datetime',
        'created_at' => 'datetime: Y-m-d',
    ];

    /**
     * The relations that should be loaded
     *
     * @var array
     */
    protected $with = ['roles'];

    public function roles()
    {
        return $this->belongsToMany(Role::class)->withTimestamps();
    }

    public function getActivitylogOptions(): LogOptions
    {
        return LogOptions::defaults()
            ->logOnly(['roles'])
            ->logFillable()
            ->logOnlyDirty();
    }
}

Pivot Model:
<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Relations\Pivot;
use Spatie\Activitylog\LogOptions;
use Spatie\Activitylog\Traits\LogsActivity;

/**
 *
 */
final class RoleUser extends Pivot
{
    use LogsActivity;

    public $incrementing = true;

    public function getActivitylogOptions(): LogOptions
    {
        return LogOptions::defaults()
            ->logFillable()
            ->logOnlyDirty();
    }
}

Pivot model migration:
<?php

use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Support\Facades\Schema;

return new class extends Migration
{
    /**
     * Run the migrations.
     *
     * @return void
     */
    public function up()
    {
        Schema::create('role_user', function (Blueprint $table) {
            $table->id();
            $table->integer('user_id')->unsigned();
            $table->integer('role_id')->unsigned();
            $table->timestamps();

            $table->primary(['id']);
            $table->foreign('user_id')->references('id')->on('users')->onDelete('cascade');
            $table->foreign('role_id')->references('id')->on('roles')->onDelete('cascade');
        });
    }

    /**
     * Reverse the migrations.
     *
     * @return void
     */
    public function down()
    {
        Schema::dropIfExists('role_user');
    }
};

This is the part of my controller that updates the releation
 $updated = $user->update([
            'name' => $request->name,
            'email' => $request->email,
            'active' => $request->has('active'),
        ]);

        $user->roles()->sync($request->input('roles'));

Expected behavior
When using $activity->changes to get the actual changes that where made.
Screenshots
If applicable, add screenshots to help explain your problem.
Versions (please complete the following information)

PHP: 8.1
Database: Postgresql 14
Laravel: 9
Package: Activity log

Additional context
none
Exception
No exception
Stack Trace
No stack

Is this thing fixed or not yet?

I think this is very useful, is anyone working on this issue?