JS: add models of $.ajax, $.getJSON and XMLHttpRequst

This change adds support for XMLHttpRequest and jQuery.ajax requests in js/request-forgery.
Performance is fine (I suspect the giant speedups are flukes).

Change note conflicts resolved


Hubot disconnects and does not reconnect (Slack)

I'm not clear if this is a hubot issue or a slack-hubot issue...
I also have the same problem as others; https://github.com/slackhq/hubot-slack/issues/203
[Sat Jul 18 2015 04:26:52 GMT+0000 (UTC)] ERROR Last pong is too old: 14.952
[Sat Jul 18 2015 04:26:52 GMT+0000 (UTC)] INFO Reconnecting in 1000ms
[Sat Jul 18 2015 04:26:53 GMT+0000 (UTC)] INFO Attempting reconnect
[Sat Jul 18 2015 04:26:53 GMT+0000 (UTC)] INFO Connecting...
[Sat Jul 18 2015 04:26:54 GMT+0000 (UTC)] INFO Logged in as hubot of team, but not yet connected
[Sat Jul 18 2015 04:27:22 GMT+0000 (UTC)] INFO Slack client closed
I'm not clear why it is disconnecting -- it usually happens when there is some idle -- it never reconnects (on it's own).  I see the code used to exit hubot but was updated at some point to not exit hubot. Since I run hubot with a supervisor, I'd actually prefer it exit -- since it would get restarted. But instead, it just sits until I manually restart with supervisor.

+1

+1

I experienced the same issue weeks ago, and fixed it. Certainly wasn't the problem with hubot-slack; it was with the configuration variables (the process.env bunch), and perhaps with the scripts being imported too.
Check your slack token to be sure.

Unfortunately @kengz, this is not really an answer.  Can you suggest what you changed in "process.env bunch".  Keep in mind, Hubot can run for days, even weeks, before the problem resurfaces.

Yes I realized, my apologies; it was weeks ago and I've coded quite a lot on my hubot, I'll try my best to remember.
I set my tokens using the environment variables, thus the process.env.HUBOT_SLACK_TOKEN for example, and that's how hubot accesses them. Can't recall precisely, but I think one of the tokens were wrong, and it gave me that error. I corrected it and problem was solved.

I have this problem as well. It randomly disconnects but does exit. Is it supposed to exit? Are you supposed to use supervisord  or monit to handle this?

It doesn't exit -- and since it doesn't exit, using supervisord or monit doesn't really help.   It looks like there were code changes made to hubot (proper, not hubot-slack) that make it not exit -- and that the previous behavior was to exit.  It's clearly possible to make it exit again -- but my personal preference (for my deployment) would be to have a solution that doesn't stray from the official hubot release.

@wylieswanson I think this is an issue with hubot-slack. I'm running my forked version of that module in which I've modified slack.coffee to not reconnect on disconnect, but instead exit the process completely. That way I can set supervisor to pick that up and restart Hubot again. Seems to work much better for me.
Made a pull request for it.

@eriklindebratt I'd like to think a better solution becomes formal.  In the meantime, sincerely appreciate that you turned up a pull request for the fix -- I have no doubt it will make the problem irrelevant.  :)

Just confirmed the issue with my multiple hubots running on a server. They died to the same error around the same time, so that's a disconnectedness issue as mentioned above. Seems like the adapter just closes after it gives up trying.
A different solution would be to run/restart your hubot using forever, which I'm using. Been working pretty well and I didn't even noticed they died until I check the logs.

@kengz can you show use how you are using forever to keep it running please?

Here's an example https://github.com/kengz/jarvis#forever

Solution to this problem:
Make the Slack connector wait for the PONG for longer before quitting.
Go into the file client.js at the path node_modules/hubot-slack/node_modules/slack-client/src/client.js
Then change line 129, _this._lastPong > 1000 into something longer, like _this._lastPong > 100000

That line was _lastPong > 10000 for me. I just upped it to 100000 but that seems really hacky.


epsilon penalty questions/concerns

https://github.com/NousResearch/finetuning-subnet/blob/c337721cfa2317a4a32e1b9591cbe9188226e4d6/constants/__init__.py#L66
I understand the purpose of the epsilon penalty, but I think there are two problems:

2% is not a trivial amount, and the value doesn't decay over time, it's just a fixed penalty for having joined the network later
even if someone manages to beat the other models with > epsilon loss reduction, the miners with earlier blocks can just download the new model and re-commit it, meaning they'd automatically win again

Perhaps just prevent commiting the same hash?  Not sure what other mechanisms would work.

Oh, nevermind on point 2, the block changes.

Oh, looks like the block changes for any commit - never mind on point 2.


Select All Checkbox on Form

Have some static checkboxes on my form.  I want to add a checkbox or button that will select/deselect all when clicked.
Here's what I have so far:
_Layout.cshtml
`function toggle() {
cbCheckAll = document.getElementsByName('CheckAll');
    cb1 = document.getElementsByName('option1');
    cb1.checked = source.checked;

    cb2 = document.getElementsByName('option2');
    cb2.checked = source.checked;

    cb3 = document.getElementsByName('option3');
    cb3.checked = source.checked;
}`

Form.cs
 public Boolean CheckAll { get; set; }
EditorDialog.ts
this.form.CheckAll .element.add("onClick","toggle();")
This is not working of course, the onClick is underlined.   I don't have much experience with typescript so please excuse me if this is a dumb question.   Thank you.

You have to write your code in xyzEditorDialog.ts. Your toggle function
    constructor() {
       super();

       this.form.CheckAll.change(e => {
           this.toggleCheck(this.form.CheckAll.value);
        });
   }

   protected toggleCheck(value) {
       [...]
   }

Thank you so much!    I'm going to add what I did in case some one else needs it:
On xyForm.ts I had to add the CheckAll checkbox.
` export interface xyzForm {
CheckAll: Serenity.BooleanEditor;
}
[['CheckAllCamera', () => Serenity.BooleanEditor]]`
On xyzForm.cs:
public Boolean CheckAll { get; set; }
xyzEditorDialog.ts
`        constructor() {
super();
this.form = new xyzForm(this.idPrefix);
        this.form.CheckAll.change(e => {
            this.toggleCheck(this.form.CheckAll.value);
        });
    }

    protected toggleCheck(value) {
        this.form.cb1.value = value;
        this.form.cb2.value = value;
    this.form.cb3.value = value;
   }`

@Estrusco awesome work, how to handle the changed value in dialog.ts to make same form of calculation on the fly ?


Missing Winqual.exe

The Partner cannot download the Winqual.exe file. They need this file to upload the cert to Hardware Devcenter.
Step 2: Sign and upload your Winqual.exe file
From the Hardware Dev Center dashboard, sign in as an administrator with your Microsoft account.
Download the Winqual.exe file from the Hardware Dev Center dashboard, and sign it with the new digital certificate for your company using the SignTool.
On the Administration page, in the Digital certificates tile, click Upload code for digital certification.
On the Digital certificates page, click Browse to locate and select the Winqual.exe file that has been signed with the correct digital certificate for your company.
The partner is redirected to the below link and its a 404 error:
http://go.microsoft.com/fwlink/?LinkId=393250

Thanks, @cruzex100 for pointing this out. I'm reaching out to the tool owner to determine how to get the tool now that Sysdev is deprecated. BTW, did you try the steps in the first section of Winqual submission tool?
Thanks

Also, this Issue was filed as an overall issue. Can you please give me the URL of the page that has the steps that failed? Thank you.

Here is the link:
https://docs.microsoft.com/en-us/windows-hardware/drivers/dashboard/update-a-code-signing-certificate
The Winqual Submission tool is not needed for this...

Thanks, @cruzex100
I fixed the link. It will be live shortly. In the meantime, you can use the Updated link.
Thanks,
Eliot

The Updated link is for the Winqual submission tool. The Winqual.exe and Winqual submission tool are not the same.. Please update the download link for Winqual.exe.

Ugh. Sorry. Working on it.

No Problem.. Thanks @EliotSeattle

@EliotSeattle , Any updates on the download link?

According to the team, "we don’t have separate winqal.exe, it is the Winqual Submission tool link that we provided in HDC."


dispersion plot not working properly

Dispersion plot makes obvious mistakes.
To replicate this error do as follows:
import nltk
from nltk.books import *
text7.dispersion_plot(["chairman", "director", "money", "stocks", "old"])
text7.dispersion_plot(["chairman", "director", "money", "stocks", "old", "he"])
plt.show()

Looking at these plots, it should be clear, that the plots are not correct. All yticks change simply because "he" is introduced, although all distributions should stay the same, and "he" should have new distribution.
This error is persistent throughout other texts and other words.
The y-ticks are added in the opposite way of the matching distributions.

In fact the order of the labels is reversed. The problem is still not corrected and neither is the web page ("https://www.nltk.org/_modules/nltk/draw/dispersion.html")     ;-)
for y, word in enumerate(reversed(words))
<>
ax.set_yticks(list(range(len(words))), words, color="C0")

it needs to reverse labels using reversed(words) in set_yticks() in dispersion_plot()
ax.set_yticks(list(range(len(words))), reversed(words), color="C0")

At this moments you can use set_yticks) after running dispersion_plot and before plt.show()
ax = dispersion_plot(text, words)
ax.set_yticks(list(range(len(words))), reversed(words), color="C0")
plt.show()

You're right. I made a PE with this a long time ago, but hasn't been commented on or approved. Still waiting :(...


[AKS] Add warnings to az aks mesh commands for out of support asm revision in use

Related command
az aks mesh
Description
This change adds warnings to the az aks mesh commands for an out of support asm revision in use in the cluster.
Testing Guide
az aks mesh enable -- revision asm-out-of-support-revision -g rgName -n clusterName
History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

AKS


Dtr install

Proposed changes
Fixes #7809

Deploy preview for docsdocker ready!
Built with commit 7ed4cfd4fe491f74f733a6d4d02711048c2bbd4f
https://deploy-preview-7856--docsdocker.netlify.com


io: retry read/write until complete

If a read or write operation is not fully completed, the command is reapplied
Errors should now be properly handled. However, this has revealed a problem with the fsync command. Each fsync call performed through io_uring is failing with an "Invalid Argument" error message.
A fix will be included in a follow-up pr
closes #288

#298  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gabriele-0201 and the rest of your teammates on  Graphite

Merge activity

Aug 22, 12:43 PM EDT: @rphmeier started a stack merge that includes this pull request via Graphite.


Page not found in API documentation

The examples are not working .. getting a 404 error.
https://civic.genome.wustl.edu/api/genes/238/variants/5

Thanks for the report - it looks like our API documentation needs to be re-worked a bit! We will address that in our next release.

Thanks Adam,
In the mean time, can you tell me how it has changed?
Shane
On Fri, Jun 5, 2015 at 11:36 AM, Adam Coffman<EMAIL_ADDRESS>wrote:

Thanks for the report - it looks like our API documentation needs to be
re-worked a bit! We will address that in our next release.
—
Reply to this email directly or view it on GitHub
https://github.com/genome/civic-server/issues/63#issuecomment-109356477.

Sure thing. We've made two primary changes since that documentation was written:

We've stopped using entrez ids in the Gene endpoints in favor of using internal ids for now
We've reduced the amount of nesting to a maximum of one level. You can now get an 'index' endpoint one layer down, but no further. In other words:

You can get a list of genes:
/api/genes
And then get a list of variants for a given gene:
/api/genes/:id/variants
But you can no longer continue to nest. To get a list of evidence items for a given variant, you would do the following:
/api/variants/:id/evidence_items
Similarly, the comments, revisions, suggested changes, etc are all now at the "top level" for the entity in question:
/api/variants/:id/comments
/api/evidence_items/:id/revisions
etc.
Hopefully that's helpful!

Thanks Adam that helps. Civics variant descriptions are great. We hope we can provide annotation back to civic once we start working with more researchers.
Shane Neeley
Software Engineer
Molecularmatch.com
On Mon, Jun 8, 2015 at 10:13 AM, Adam Coffman<EMAIL_ADDRESS>wrote:

Sure thing. We've made two primary changes since that documentation was written:

We've stopped using entrez ids in the Gene endpoints in favor of using internal ids for now
We've reduced the amount of nesting to a maximum of one level. You can now get an 'index' endpoint one layer down, but no further. In other words:
You can get a list of genes:
/api/genes
And then get a list of variants for a given gene:
/api/genes/:id/variants
But you can no longer continue to nest. To get a list of evidence items for a given variant, you would do the following:
/api/variants/:id/evidence_items
Similarly, the comments, revisions, suggested changes, etc are all now at the "top level" for the entity in question:
/api/variants/:id/comments
/api/evidence_items/:id/revisions
etc.
Hopefully that's helpful!

Reply to this email directly or view it on GitHub:
https://github.com/genome/civic-server/issues/63#issuecomment-110033355

Improved documentation has gone out which should help clarify much of this. We will continue to improve the docs and provide more examples as we go forward!


SELECT FROM V does sometimes only give 20 results back via Console.sh

So here are the two ways to check if the same happens to you, too.
In the first way the server is down. Then you open the console and connect via "CONNECT plocal:C:/orientdb-community-2.0-M1/databases/Titles admin admin". Now logged in you search for "SELECT FROM V LIMIT 100". But instead getting back 100 results now we only get 20.
LIMIT EXCEEDED: resultset contains more items not displayed (limit=20)

The second way is when the server is online. So make sure the server is online and then start the console. Then you open the console and connect via "CONNECT plocal:C:/orientdb-community-2.0-M1/databases/Titles admin admin". Now logged in you search for "SELECT FROM V LIMIT 100". Now we correctly get back
100 item(s) found. Query executed in 0.018 sec(s).

So I believe that in the plocal mode when the server is down the LIMIT 100 is ignored.
Also tested with remote for sure. But remote needs a server that is online. So not reproducable with remote.
PS: searching e.g. in the second example for "SELECT FROM Person LIMIT 100" gives back 100 result. So it's a special thing of plocal, server down and V!

You can remove limit in console:
set limit -1


Items in the third column, once created, seem to have the wrong remaining character count

Bug report
(delete this section if not applicable)
What is the actual(incorrect) behavior?
Create an item and save it.
EDIT that item (card)
As you add additional characters to the item, the character count turns RED BEFORE you get to zero (indicating no more characters are available and the user is over).
It almost appears that the remaining character count is being calculated based on the number of characters that were already in the item BEFORE you began editing it (instead of the MAX number of characters allowed in ANY item).
In my case, I was changing something in the third column, but not sure if it exists in other columns or not).
What is the expected(correct) behavior?
Characters should be able to be typed (and saved) as long as the number of characters left is above or equal to zero.
Please provide your browser and OS versions:
Version 90.0.4430.93 (Official Build) (32-bit) - on Ford IT managed laptop
Include any logs/screenshots below:

Thanks for opening the issue @wjruffing. The character count turns red when there are fewer than 50 characters remaining. I recognize that is not very intuitive. I am making a change where the character count is yellow between 50 characters and 1 character remaining. At 0 characters remaining it will turn red.


[develop] Use Text instead of String?

I was recommended to use Data.Text instead of the String type, but I do not know enough about this topic to be able to say which one would be best for this project.
Some resources:

https://stackoverflow.com/questions/19608745/data-text-vs-string
http://www.alexeyshmalko.com/2015/haskell-string-types/

Maybe this is the next thing we should do?

Yeah, let me investigate a bit more and I'll update this thread...


Additional tests for schema update and validation

Fixes #1005
I think this is now good to be merged.
@blafond Could you have a look at the changes I made to your original PR and merge it if they make sense (and the build doesn't fail)?
Thanks

We should also backport this to 1.0


Change JYTHON to jython-standalone to avoid error

slim jython may curse error when plugin loaded, replace to jython-standalone to avoid this error

jython-slim was designed for use as a dependency in a Maven/Gradle project. Standalone would work as well but I used slim because it is more lightweight and was designed for this purpose.
What error are you receiving?

Project is now using jython-standalone, I did not merge this PR because the latest version of Jython is 2.7.3 which the project is now using.


Please add a license file

This repository does not ship a license file. It is therefore not clear if it can be used freely.
Prometheus is licensed under Apache 2.0. I would therefore propose to use the same license here as well.
Thanks,
Stephan

@StephanErb Thanks! Apparently I forgot when I created the repo, sorry about that.
I typically use the MIT license, hope that is acceptable as well.

That was quick. Thanks!


Expanded 3rd-party monitoring documentation

Problem description
Currently we document integration of Prometheus with Docker Enterprise. Does it make sense to add page(s) for other common monitoring integration points such as SysDig, DataDog, etc.?

@ahh-docker, thoughts? Seems like a refactor task.

Just realized that we have this content over in the Success Center:
https://success.docker.com/article/sysdig-monitoring
https://success.docker.com/article/datadog-monitoring
So perhaps a hyperlink from docs over to 3rd party options in Success Center would be a better path?

@stevenfollis The URLs redirect to
https://goto.docker.com/Q118-Docker-Certified-Infrastructure-Download_LP.html
What happened to them?

@stevenfollis @aki-k  I'd be happy to add these two links to this from the docs, but I'm getting prompted to log in - that seems ugly when someone is looking for help. I've inquired about these links.

Follow-up: https://docker.slack.com/archives/C02FVEK5M/p1550595912021900


Fix shadows

Shadows have been turned off / removed until we can figure out what their problem is.

Hello yes graphics wizard from many timezone's here
Lights get rendered six at a time and then blended together.
In this example here the black squares are the occluders (walls or anything that blocks light) and the orange line with the grey areas are the shadows.
The first set of red lights gets rendered correctly with their shadow counterparts.

Looks good right? Now look at what happens when you render another six lights:
(pink are the new set of lights and green is where they actually end up at)

The lights and the shadow map renders correctly but the texture itself gets flipped vertically!
Turns out that somewhere in sfml during rendering something causes this texture to flip vertically.
And the best thing is that this will happen for every even set of lights. (IE the second set, the fourth set, the sixth set... and so on)
I bandaided the issue by unflipping the even textures but performance took a huge hit because of it and it looks like linux/macos sfml will segfault randomly due to the texture copying i was doing. The entire lighting stack was disabled here 0730545 to bandaid the issues temporarily.
If this interests you here is more reading material on the closest thing on our lighting system: https://github.com/mattdesl/lwjgl-basics/wiki/2D-Pixel-Perfect-Shadows

Is this another case of Texture.CopyToImage()? If it is, I'm committing sudoku.

Yes :(

We currently have six lights max as a quick fix. still a issue though.

G O D O T


HADOOP-19148 Upgrade solr from 8.11.2 to 8.11.3 to address CVE-2023-50298

Jira: HADOOP-19148
For code changes:

[X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[X] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

you took out the boxes you have to check; reinserted

The full build was run but somehow the status is not getting reported to PR: https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-multibranch/view/change-requests/job/PR-6830/

I observed similar behaviour on other recent PR also that attempted to upgrade some dependency (e.g. kafka-client)

raise this on the developer list

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 58s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  1s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
0m 22s

Maven dependency ordering for branch

-1 :x:
mvninstall
0m 24s
/branch-mvninstall-root.txt
root in trunk failed.

-1 :x:
compile
0m 23s
/branch-compile-root-jdkUbuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.txt
root in trunk failed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.

-1 :x:
compile
0m 25s
/branch-compile-root-jdkPrivateBuild-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.txt
root in trunk failed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.

-1 :x:
mvnsite
0m 24s
/branch-mvnsite-root.txt
root in trunk failed.

-1 :x:
javadoc
0m 24s
/branch-javadoc-root-jdkUbuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.txt
root in trunk failed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.

-1 :x:
javadoc
0m 24s
/branch-javadoc-root-jdkPrivateBuild-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.txt
root in trunk failed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.

+1 :green_heart:
shadedclient
1m 37s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s

Maven dependency ordering for patch

-1 :x:
mvninstall
0m 25s
/patch-mvninstall-root.txt
root in the patch failed.

-1 :x:
mvninstall
0m 24s
/patch-mvninstall-hadoop-project.txt
hadoop-project in the patch failed.

-1 :x:
mvninstall
0m 25s
/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-catalog_hadoop-yarn-applications-catalog-docker.txt
hadoop-yarn-applications-catalog-docker in the patch failed.

-1 :x:
compile
0m 24s
/patch-compile-root-jdkUbuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.txt
root in the patch failed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.

-1 :x:
javac
0m 24s
/patch-compile-root-jdkUbuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.txt
root in the patch failed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.

-1 :x:
compile
0m 23s
/patch-compile-root-jdkPrivateBuild-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.txt
root in the patch failed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.

-1 :x:
javac
0m 23s
/patch-compile-root-jdkPrivateBuild-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.txt
root in the patch failed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
hadolint
0m  0s

No new issues.

-1 :x:
mvnsite
0m 22s
/patch-mvnsite-root.txt
root in the patch failed.

+1 :green_heart:
shellcheck
0m  1s

No new issues.

-1 :x:
javadoc
0m 25s
/patch-javadoc-root-jdkUbuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.txt
root in the patch failed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.

-1 :x:
javadoc
0m 25s
/patch-javadoc-root-jdkPrivateBuild-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.txt
root in the patch failed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.

+1 :green_heart:
shadedclient
3m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 24s
/patch-unit-root.txt
root in the patch failed.

+0 :ok:
asflicense
0m 25s

ASF License check generated no output?

17m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6830/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6830

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint hadolint shellcheck shelldocs

uname
Linux 13fc9389587d 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2d26050136f9aadbb206185039c98b1e5e9394e4

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6830/3/testReport/

Max. process+thread count
24 (vs. ulimit of 5500)

modules
C: . hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-docker U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6830/3/console

versions
git=2.25.1 maven=3.6.3 hadolint=1.11.1-0-g0e692dd shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Another build ran for 1 day + 9 hr and no yetus result available: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6830/4/#showFailuresLink
(though test results are available)

lets try again: do a git merge trunk and push up to see what we can do

New run took 1 day + 8 hrs, this time it doesn't even have test results: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6830/5/

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  1s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 41s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
32m 30s

trunk passed

+1 :green_heart:
compile
17m 19s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
16m 19s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
mvnsite
27m 30s

trunk passed

+1 :green_heart:
javadoc
9m 21s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
8m  9s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
shadedclient
50m 18s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
1m 51s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
29m 54s

the patch passed

+1 :green_heart:
compile
17m  8s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
17m  8s

the patch passed

+1 :green_heart:
compile
16m 15s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
16m 15s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
hadolint
0m  1s

No new issues.

+1 :green_heart:
mvnsite
17m 48s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
8m 32s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
8m  2s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
shadedclient
50m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
831m  8s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
1m 40s

The patch does not generate ASF License warnings.

1128m 59s

Reason
Tests

Failed junit tests
hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptorSecure

hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor

hadoop.yarn.server.globalpolicygenerator.policygenerator.TestPolicyGenerator

hadoop.yarn.server.globalpolicygenerator.TestGPGPolicyFacade

hadoop.yarn.server.federation.policies.TestRouterPolicyFacade

hadoop.yarn.server.federation.policies.router.TestUniformRandomRouterPolicy

hadoop.yarn.server.federation.policies.router.TestHashBasedRouterPolicy

hadoop.yarn.server.federation.policies.router.TestLocalityRouterPolicy

hadoop.yarn.server.federation.policies.router.TestWeightedRandomRouterPolicy

hadoop.yarn.server.federation.utils.TestFederationStateStoreFacade

hadoop.yarn.server.federation.policies.router.TestRejectRouterPolicy

hadoop.yarn.server.federation.policies.router.TestPriorityRouterPolicy

hadoop.yarn.server.federation.policies.router.TestLoadBasedRouterPolicy

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6830/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6830

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint hadolint shellcheck shelldocs

uname
Linux a590612ab208 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 84dacd484a5aab72180549ba390e5c170099e3ea

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6830/6/testReport/

Max. process+thread count
3556 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-docker . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6830/6/console

versions
git=2.25.1 maven=3.6.3 hadolint=1.11.1-0-g0e692dd shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989 are the above Yarn federation test failures known to you?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 23s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m  9s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 44s

trunk passed

+1 :green_heart:
compile
8m 42s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
7m 51s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
mvnsite
17m 28s

trunk passed

+1 :green_heart:
javadoc
4m 48s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
5m  2s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
shadedclient
29m  4s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
1m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
17m 15s

the patch passed

+1 :green_heart:
compile
8m 26s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
8m 26s

the patch passed

+1 :green_heart:
compile
8m  4s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
8m  4s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
hadolint
0m  1s

No new issues.

+1 :green_heart:
mvnsite
8m 24s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
4m 40s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
5m  4s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
shadedclient
29m 52s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
669m 25s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
1m  1s

The patch does not generate ASF License warnings.

843m 34s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.blockmanagement.TestDatanodeManager

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6830/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6830

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint hadolint shellcheck shelldocs

uname
Linux 967a18ed2707 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a36e3847092feb543e6a0e051802571ba863a948

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6830/7/testReport/

Max. process+thread count
4040 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-docker . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6830/7/console

versions
git=2.25.1 maven=3.6.3 hadolint=1.11.1-0-g0e692dd shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

if this goes near yarn then someone from the yarn team is needed to review this

@slfan1989 you want to take a look?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  3s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+0 :ok:
shelldocs
0m  1s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 19s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
34m 15s

trunk passed

+1 :green_heart:
compile
19m 23s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
17m  9s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
mvnsite
26m  9s

trunk passed

+1 :green_heart:
javadoc
8m 39s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
8m  7s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
shadedclient
53m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
1m 45s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
32m  2s

the patch passed

+1 :green_heart:
compile
17m 58s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
17m 58s

the patch passed

+1 :green_heart:
compile
18m 22s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
18m 22s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
hadolint
0m  1s

No new issues.

+1 :green_heart:
mvnsite
18m  7s

the patch passed

+1 :green_heart:
shellcheck
0m  1s

No new issues.

+1 :green_heart:
javadoc
8m 43s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
8m  3s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
shadedclient
51m 31s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
839m 46s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
1m 40s

The patch does not generate ASF License warnings.

1151m 14s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6830/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6830

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint hadolint shellcheck shelldocs

uname
Linux ff6cbb2d7f68 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 73fa701a8822151300b4193cb44bf78a8e9dd713

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6830/8/testReport/

Max. process+thread count
3562 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-docker . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6830/8/console

versions
git=2.25.1 maven=3.6.3 hadolint=1.11.1-0-g0e692dd shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


site RSS feed

https://github.com/dylang/node-rss

This should broadcast most recently added projects, sites, fields payments and imports.


Allow unit-tests to use linked PDF files, by having the unittest command download unavailable ones (issue 7117)

Re: #7117.

/botio unittest

Thank you for the patch


GUI exe generation

Hello @BonneelP
I finally tried the exe generation function #416. The function seems to work so far. I only had to change dist_path to "build" for some reason.
But If I try to start Pyleecan the following exception is raised

Do you have any idea what to do? Do you change some code prior to generation?
I guess the issue is related to the try ... execpt imports in run_GUI.py. I tried some alternatives but couldn't solve the issue.
Best regrards,
Sebastian

Meanwhile I figured out that changing dist_path wasn't right, so I changed it back.
I guess the issue was related to pyzmq which was not installed to the EXENV. Now 'master' is building and running.


[tsp-client] The output of the tsp compile command should be logged using the Logger

Description
The output while calling the SDK emitter in tsp-client is currently only displayed in the console. For better troubleshooting, this output should also be emitted to the Logger so that it can be displayed in the pipeline scenario.
This is the code location:
https://github.com/Azure/azure-sdk-tools/blob/eaa42a758c1478fa7a3262a53254d3fe26d8ea37/tools/tsp-client/src/typespec.ts#L112
//CC: @catalinaperalta @chunyu3

Hello @catalinaperalta in .NET generator we will log some information, but when tsp-client execute .Net emitter, the logs of .NET emitter are missing.
When I run local, it can see the logs, but when run in ci pipeline, the logs are missing

Hi all, I opened a PR addressing this yesterday, you should be able to see it linked to this issue. Waiting on a review then will release a tsp-client update. Feel free to add your own review on the PR as well :)

v0.9.1 of tsp-client was released and is not printing the diagnostics with the logger. Please update to that version and give it a try. Thanks

@raych1 the output of the diagnostics causes a lot of noise when generating using tsp-client. Any issues if I move this to the debug level? I think you're already using the --debug flag in the pipeline, right?


broken link to example url

on this page:

http://www.passportjs.org/packages/tozny-auth/
the link examples/secretmessage/index.js is broken

Hi @christopherreay
This package is considered deprecated, for interacting with Tozny products (both TozStore and TozID) you will want to use
https://github.com/tozny/js-sdk/tree/master
Regarding the original issue, It looks like passport is generating that documentation based on the Readme for this repo, which if viewed from Github the link will send you correctly to https://github.com/tozny/sdk-node/blob/master/examples/secretmessage/index.js
Peace,
Levi


Use PyTorch Functionalization Pass

Having converters for inplace operators (add_) is potentially unsafe. We should use the functionalization pass in the lowering phase to switch these ops to their functional versions.

https://github.com/pytorch/pytorch/blob/cd5d7a34b8802cf120451182fd17a662efec644c/torch/csrc/jit/passes/create_functional_graphs.h


Change exit button to use <a> tag

What is the context of this PR?
Change exit button to use <a> tag
How to review
Check exit button still looks and works as it should while using <a> tag

 Change exit button to use  tag


Possibly change default invert colour from white to green

Someone reported being able to see it clearer as green. In they pictures it does look easier to see. Need to test out and investigate!
Suggestion original came from projectorsewing.com. Maybe a popup when clicking the invert colors icon to choose a high contrast colour combination? Then we can start saving it in localStorage. Maybe use it for the calibration grid and invert colours?

I have an implementation for this. I'm not in love with the dropdown click event listener for the icon button. I am going to open a PR so that it builds, and you can see what I mean, @courtneypattison. It has all the functionality - it just feels kind of wrong. If you have any ideas for alternatives, I'm open to suggestions!

Let me ask this - is there a specific branch you want me to merge to, other than main? I ask this because I'm not sure we want to merge it in its current state. The test branch maybe?

I think test branch is a good idea!

I just had an epiphany! I decided to toggle the button between 3 states: off, on, and on with green mode. That feels much more intuitive. I am going to ahead and do a PR - I can still put it into test if you want, just to test the workflow.

I love that! If a PR is easier, just go with that.

I don't think the test branch is up to date, so GH won't even approve a merge. I'll put it to the main branch. I feel much better about it now!

Woot woot! I'll test it out then merge :)


selectRelationCount generator doesn't add _count to Prisma.validator

The selectRelationCount preview feature in #6312 works well, but the _count field doesn't seem to be supported by Prisma.validator and Prisma.XYZGetPayload for partial / related types.
// works fine
const user = Prisma.validator<Prisma.UserArgs>()({
  select: { id: true, name: true },
});
export type User = Prisma.UserGetPayload<typeof user>;

// TS2322: Type 'boolean' is not assignable to type 'never'.
const userWithCount = Prisma.validator<Prisma.UserArgs>()({
  select: { id: true, name: true, _count: { select: { posts: true } },  },
});

Disregard; the generator is working correctly, I was referencing a stale file.


workflows: Update call to Quay API

Quay changed its API on the 22nd. This pull request updates the step that checks for the Docker images in all workflows to use the new API.

The only workflow that failed with the test commit is ConformanceGKE but it failed in the connectivity tests, after the images were pulled. So all good. I'll remove the test commit and mark ready to merge given we already have two reviews.

Does not apply to v1.9, I'm removing the backport tag.


CORS headers intermittently left off the response

[x ] Update to the latest version by running composer update fruitcake/laravel-cors
[x]  Double-check your config file with the version from the repo. Make sure the paths property is correctly set. Start by allowing as much as possible.
[x]  Make sure the middleware is added to the global middleware in your Http Kernel (not group)
[x]  Clear your config cache php artisan config:clear, route cache (php artisan route:clear) and normal cache (php artisan cache:clear).
[x]  Make sure your permissions are setup correctly (eg. storage is writable)

I moved from Spatie's cors library to this package and I am seeing intermittent responses without the group of cors related headers thus breaking some requests. Requests will succeed most of the time (failing something like 1 in 10) and it is not limited to one request / resource. (The same failed request will succeed on the next).
Summary of setup:
Kernel.php
    protected $middleware = [
        \App\Http\Middleware\CheckForMaintenanceMode::class,
        \Illuminate\Foundation\Http\Middleware\ValidatePostSize::class,
        \App\Http\Middleware\TrimStrings::class,
        \Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull::class,
        \App\Http\Middleware\TrustProxies::class,
        \Fruitcake\Cors\HandleCors::class,

    // this was added in attempt to resolve the issue, didn't resolve.
    protected $middlewarePriority = [
        \Fruitcake\Cors\HandleCors::class,
        ....

    protected $middlewareGroups = [
        ...,
        'api' => [
            EnsureFrontendRequestsAreStateful::class,
            'throttle:120,1',
            'bindings',
        ]
    ];

Example of failed request:
## General:

Request URL: http://tcs.test/api/lias
Request Method: GET
Status Code: 200 OK
Remote Address: <IP_ADDRESS>:80
Referrer Policy: no-referrer-when-downgrade

##  Request Headers:

Connection: keep-alive
Content-Encoding: gzip
Content-Type: text/html; charset=UTF-8
Date: Mon, 23 Mar 2020 17:09:45 GMT
Server: nginx/1.17.7
Transfer-Encoding: chunked
Vary: Accept-Encoding
X-Powered-By: PHP/7.4.1

## Response Headers:

Accept: application/json
Accept-Encoding: gzip, deflate
Accept-Language: en-GB,en;q=0.9,pl-PL;q=0.8,pl;q=0.7,en-US;q=0.6
Connection: keep-alive
Cookie: XSRF-TOKEN=eyJpdiI6ImZEU1VlSndRZGp1QXdSR2UvZkp1d2c9PSIsInZhbHVlIjoibVdaT3RYcUhwMFltZE4rcHRJUk9NZDhkY2JYZEFTV1R1bkZyZXlUUjRQT1RBNHc4RmF3dU05OFNqSmZnOGpGaCIsIm1hYyI6ImZmOTllMTZiMjBkMzk5OTMyOGUyN2I2OTA5MTkxZjdiM2Q0N2JlMWM4MDk1YzA4NWUwNGM3MjIzMGZkM2U3OTEifQ%3D%3D; tcs=eyJpdiI6Ik9hNDE0U05tZDgzc0luanVoTVk5V2c9PSIsInZhbHVlIjoiWDdqZm0rL1ZKeDl4RXRCNVdXenJuZkZCaC9PUGt1alB4VU14OEg4b3dJQStMS09OYUIySHRwQjAzYTRYMERPcCIsIm1hYyI6Ijk5YTIwNDY5YWZjNDI4MzE3YWMzNGE1Y2Q2MWExMWM1MzU4MzRiMzg5Y2I0ZjllMDQwOTQxY2VmYWQ2MGIyYTQifQ%3D%3D
Host: tcs.test
Origin: http://tcs.test:8080
Referer: http://tcs.test:8080/legitimate-interest-assessments
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.149 Safari/537.36
X-XSRF-TOKEN: eyJpdiI6ImZEU1VlSndRZGp1QXdSR2UvZkp1d2c9PSIsInZhbHVlIjoibVdaT3RYcUhwMFltZE4rcHRJUk9NZDhkY2JYZEFTV1R1bkZyZXlUUjRQT1RBNHc4RmF3dU05OFNqSmZnOGpGaCIsIm1hYyI6ImZmOTllMTZiMjBkMzk5OTMyOGUyN2I2OTA5MTkxZjdiM2Q0N2JlMWM4MDk1YzA4NWUwNGM3MjIzMGZkM2U3OTEifQ==

Example of successful request:
## General:

Request URL: http://tcs.test/api/lias
Request Method: GET
Status Code: 200 OK
Remote Address: <IP_ADDRESS>:80
Referrer Policy: no-referrer-when-downgrade

## Response Headers:

Access-Control-Allow-Credentials: true
Access-Control-Allow-Origin: http://tcs.test:8080
Access-Control-Expose-Headers: Cache-Control, Content-Language, Content-Type, Expires, Last-Modified, Pragma, TCS-App-Version, TCS-Session-Expires-In
Cache-Control: no-cache, private
Connection: keep-alive
Content-Encoding: gzip
Content-Type: application/json
Date: Mon, 23 Mar 2020 17:15:49 GMT
Server: nginx/1.17.7
Set-Cookie: XSRF-TOKEN=eyJpdiI6InBzajJZYlczeWY2VkFNbmdMSG16Z2c9PSIsInZhbHVlIjoiWVFIMzU5YUsvNEdJU0J4K1AxSzlzN2hmdlc0K2Vsc1pPNFJ6bUdBWlBCcy8vOHVEOVhZMHBBNXVGNXZnYlBxVyIsIm1hYyI6IjQyMzAzODk5ZjNlYjI0NDViNTI3MTA3MDgwZDA4YmZkMjNmYzU3YWM4NTJiN2VkOGM4ODMwYjEzNDUwNTJlY2QifQ%3D%3D; expires=Mon, 23-Mar-2020 18:15:49 GMT; Max-Age=3600; path=/; domain=.tcs.test; samesite=lax
Set-Cookie: tcs=eyJpdiI6InN6cGdUY3QxNWs3TlVOdkpwazQ3eXc9PSIsInZhbHVlIjoiZnRUdE52WjAxMUFUTFRKeGJGTXRlU3J0VWczcXU2L3VWdk01QkVlS0IyZENRSUNPd0ZLUlVyU2JOS1pBRnpYbCIsIm1hYyI6ImQzNDBlMjMzNzRlN2Q2ZGI3Nzg4Y2UzMjM4NmU3ZThiZjNkZWI2ODhiMGY2ZTBiYTE1NmFiNGI1NjljZjZmYTQifQ%3D%3D; expires=Mon, 23-Mar-2020 18:15:49 GMT; Max-Age=3600; path=/; domain=.tcs.test; httponly; samesite=lax
Transfer-Encoding: chunked
Vary: Accept-Encoding
Vary: Origin
X-Powered-By: PHP/7.4.1
X-RateLimit-Limit: 120
X-RateLimit-Remaining: 116

## Request Headers:

Accept: application/json
Accept-Encoding: gzip, deflate
Accept-Language: en-GB,en;q=0.9,pl-PL;q=0.8,pl;q=0.7,en-US;q=0.6
Connection: keep-alive
Cookie: XSRF-TOKEN=eyJpdiI6Im8xWUU2U1J3Z1hFVXppVVRmU29xeHc9PSIsInZhbHVlIjoiS0tmTEM0K2tFbXlBUXB0OWpDNHRKSGFGYnB6YTVGNjNxb29DbUNMVkpuZ055M1RLUVVuR2Y4WEVOUTQrOEhxeSIsIm1hYyI6Ijk0MjNiMWVjYmMwYzVlNTYxODliMzNiNzMyNDgyNThlYzBhZjdmZGJkYTMyY2M4MDk4MGM1YTEzYWE5OTA1M2YifQ%3D%3D; tcs=eyJpdiI6IjZ3QnVuTXcyKzZSOEdxVjc3TzlQWXc9PSIsInZhbHVlIjoiY0pSR3NNRzRocU5vYi9MUFo5OENieU01dElMU09SYmN5WUw3QjJONUpsZWVMdnRIcUg1RGdHT3ZUbENqRmFHYiIsIm1hYyI6ImNjMzU1OGFkNTAxNWExOTRkMjZhYzNiY2JlYTM3ODJjMGRmOTk2MmZjN2Q4ODI5M2M0Y2Q0ZWMwNmM3MzNkYWQifQ%3D%3D
Host: tcs.test
Origin: http://tcs.test:8080
Referer: http://tcs.test:8080/legitimate-interest-assessments
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.149 Safari/537.36
X-XSRF-TOKEN: eyJpdiI6ImZEU1VlSndRZGp1QXdSR2UvZkp1d2c9PSIsInZhbHVlIjoibVdaT3RYcUhwMFltZE4rcHRJUk9NZDhkY2JYZEFTV1R1bkZyZXlUUjRQT1RBNHc4RmF3dU05OFNqSmZnOGpGaCIsIm1hYyI6ImZmOTllMTZiMjBkMzk5OTMyOGUyN2I2OTA5MTkxZjdiM2Q0N2JlMWM4MDk1YzA4NWUwNGM3MjIzMGZkM2U3OTEifQ==

DOes this have to do with rate limits? Is there anything with caching?

My hunch is that it is not this package, something is causing requests to occasionally:

Be sent back with 'text/html'
Empty response, (this might be why text/html is set)

If you have any pointers then feel free to advise!

Maybe a rogue die/exit/echo anywhere (which breaks the middleware) ?

I've checked all I can with that, re-installed vendors, I am detecting the controller isn't being passed the request for the problematic cases.


⚠ Bofrost.com has degraded performance

In 3cb77c2, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 689 ms

Resolved: Bofrost.com performance has improved in edd0ba3.


How to change parametrs to much bigger text on russian?

Thanks for your code it's pretty much exactly what i was looking for.
But i need to classify bigger text (around 500 words in one article), and it's gonna be in Russian language.
Can you advise how to improve code for this?
What do i need to change in config file?
batch_size": 256,
"dropout_keep_prob": 0.5,
"embedding_dim": 300,
"evaluate_every": 100,
"filter_sizes": "3,4,5",
"hidden_unit": 300,
"l2_reg_lambda": 0.0,
"max_pool_size": 4,
"non_static": false,
"num_epochs": 1,
"num_filters": 128
What do i need to change for bigger sentences?

You will be able to adjust the training parameters once you understand what are they.
http://www.wildml.com/2015/12/implementing-a-cnn-for-text-classification-in-tensorflow/


Status code "200" when the "Sign In" request does not match.

Date Time
04-25-2021 10:57AM
Severity
Blocker
Priority
High
Environment:
OS: [Mac OS]
Browser [chrome]
Reproducible: always.
Steps to Reproduce

Launch https://eventsexpress-test.azurewebsites.net/
Click on 'SIGN IN/UP' button.
Fill in the 'E-mail' & 'Password' fields.
Click 'SIGN IN' button.

Actual result
The page does not respond when you try to log in.
Expected result
After authorization, the user's home page is open.
Screenshots

User story and test case links
User story - https://github.com/ita-social-projects/EventsExpress/issues/191
Test case - https://github.com/ita-social-projects/EventsExpress/issues/557

Bug fixed!

Bug fixed!


Fix release test failure

Releast test failure because there is a commit in Flink engine  add sh build/script/download-spark.sh to package.sh.
This will delete the dir of jenkins SPARK_HOME and result in 'spark not found'.
From v2.6.1, Kylin have not provide Spark binary anymore. So sh build/script/download-spark.sh should be deleted from package.sh.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6208d6f). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1016   +/-   ##
=========================================
  Coverage          ?   25.11%
  Complexity        ?     6179
=========================================
  Files             ?     1433
  Lines             ?    87238
  Branches          ?    12207
=========================================
  Hits              ?    21914
  Misses            ?    63178
  Partials          ?     2146

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6208d6f...36287e3. Read the comment docs.


test thread_rwlock_trylock failing on OS X 10.11

abort() is being called in https://github.com/libuv/libuv/blob/v1.x/src/unix/thread.c#L161-L172.
After some debugging, it appears that err is set to 11 which translates to EDEADLK.
I looked through the CI and it seems to be failing there pretty often as well.
It looks like this patch fixes it on OS X, but I'm not sure if it will break things on other platforms:
diff --git a/src/unix/thread.c b/src/unix/thread.c
index c56a317..e6d7dd7 100644
--- a/src/unix/thread.c
+++ b/src/unix/thread.c
@@ -163,7 +163,7 @@ int uv_rwlock_tryrdlock(uv_rwlock_t* rwlock) {

   err = pthread_rwlock_tryrdlock(rwlock);
   if (err) {
-    if (err != EBUSY && err != EAGAIN)
+    if (err != EBUSY && err != EAGAIN && err != EDEADLK)
       abort();
     return -EBUSY;
   }
@@ -189,7 +189,7 @@ int uv_rwlock_trywrlock(uv_rwlock_t* rwlock) {

   err = pthread_rwlock_trywrlock(rwlock);
   if (err) {
-    if (err != EBUSY && err != EAGAIN)
+    if (err != EBUSY && err != EAGAIN && err != EDEADLK)
       abort();
     return -EBUSY;
   }

See the discussion on https://github.com/libuv/libuv/pull/545, our working assumption is a bug in the test.

Wow. I swear I searched for it. Sorry for the duplicate issue

No worries. This has been on my list for a while, I hope to get to it this
week.
On Dec 5, 2015 5:19 PM, "Evan Lucas"<EMAIL_ADDRESS>wrote:

Closed #642 https://github.com/libuv/libuv/issues/642.
—
Reply to this email directly or view it on GitHub
https://github.com/libuv/libuv/issues/642#event-483466638.

I'll try and take a look this evening as well and see if can make any headway


"jsx" error in Counter.vue

Describe the bug
The error Cannot use JSX unless the '--jsx' flag is provided. ts(17004) is present in src/components/Conter.vue file.
Extensions: Eslint, Prettier, Typescript Vue Plugin (Volar), Vue Language Features, WindiCSS Intellisense.
A possible fix is to add "jsx": "preserve" to compilerOptions in tsconfig.json.
Reproduction
clone the template, run pnpm i, go to src/components/Conter.vue to see the errror
System Info
System:
    OS: macOS 12.3.1
    CPU: (4) x64 Intel(R) Core(TM) i5-7267U CPU @ 3.10GHz
    Memory: 155.01 MB / 8.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    npm: 8.5.0 - /usr/local/bin/npm
  Browsers:
    Chrome: 103.0.5060.114
    Firefox: 101.0.1
    Safari: 15.4

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Did you run nuxi prepare or nuxi dev once? We are extending .nuxt/tsconfig.json, which is auto-generated.

I didn't about that 😢, thanks for the quick answer. I could make a PR adding the command in the readme file, under the "Try it now!" section, is that ok?

Or we could add postinstall script with nuxi prepare. /cc @danielroe what do you think about the best way to avoid this confusion?

I think a postinstall command is a nice idea 🔥


[Fab] Add Fab type declaration to index and theme

[x] I have followed (at least) the PR section of the contributing guide.

This PR closes #13703.
It's not my intention to take anyone's credit, just throwing this out there :wave:

@Naturalclar Thank you for working on this!


[Doc] Steps to disabling lazy initialization for user management configurations

Description:
As introduced with wso2/micro-integrator#849 by default the user management configurations are loaded on demand. We need to add steps to disable it if some user to perform eager initialization.
Configuration:
Default: Enabled
System property ”mi.security.usermgt.lazy.init” should be set to “false” to disable or enable eager initialization of

fixed by https://github.com/wso2/docs-ei/pull/1201


Fix building when OpenSSL does not support SSLv3

I've opened a pull-request for this for jimloco/Csocket
https://github.com/jimloco/Csocket/pull/56
This affects ZNC as well.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/27280974-fix-building-when-openssl-does-not-support-sslv3?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github).

If I have understood correctly, this gets fixed at ZNC when your pull request at Csocket is merged and ZNC updates the submodule.

@DarthGandalf I believe you can close this after updating the submodules in case you missed the notice at #znc.


add option for custom node path to invoke psa/psc

My shop is unable to install psc/psa/node globally on Windows so we need a way to invoke them with custom paths. This PR allows users to set a custom path with which to invoke node. If a path isn't supplied, it defaults to the old behavior and spawns psa/psc directly.

Is it possible to set the PATH when running webpack such that the psc, psa, node binaries are picked up first in their custom locations?

Looks like https://nodejs.org/api/process.html#process_process_env would be the way to do it.

On Oct 11, 2016, at 10:03 PM, eric<EMAIL_ADDRESS>wrote:
Is it possible to set the PATH when running webpack such that the psc, psa, node binaries are picked up first in their custom locations?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Is it possible for you to set the process.env.PATH prior to running webpack in your project? I hesitate to manipulate the env in the loader. Seems like it is something that should be outside of the loader's control.

Looks like setting the PATH through webpack is the way to accomplish this.

Sounds good. Thanks for the follow up.
On Monday, 17 October 2016, wegry<EMAIL_ADDRESS>wrote:

Looks like setting the PATH through webpack is the way to accomplish this.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ethul/purs-loader/pull/70#issuecomment-254340009, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAVYy7mut6xymtaDtvyl13m1TxFr5664ks5q0-jJgaJpZM4KSE0s
.


fixed doc

The contribution is my original work. I license the work to the project under the project's open source license.
Small typo in the programming guide.

Can one of the admins verify this patch?

OK, it's trivial, but easy to merge.

Thanks. I've merged this in master & branch-1.3.


Add CPUInfo parser for mipsle

Use mips CPUInfo parser for mipsle. They appear to have identical
cpuinfo output.
https://github.com/prometheus/node_exporter/pull/1735
Signed-off-by: Ben Kochie<EMAIL_ADDRESS>

Ping, this is blocking the release of some node_exporter bug fixes.

Or you miss the mipsle tag instead


Linting by magni

Cherry-picking the uncontroversial commits from https://github.com/airblade/paper_trail/pull/749. Isn't git great? :D
@magni-

My favorite programming tool of all time! git add -p and git rebase -i :heart:


Adds loader options support to tsoverlay

Fixes #247 - it doesn't just only take in compileroptions, but also other loaderoptions.

Thank you!


Add OverlappingMarkerSpiderfier package

As mentioned in #1146 it would be nice to have support for the OverlappingMarkerSpiderfier. Since a lot of (if not most) people would also like to be able to combine the spiderfier with the cluster library I made some changes to the way the MarkerManager works. The change basically makes it possible for MarkerManagers to be nested which enables the spider and cluster plugins to be active at the same time (ordering should not matter) and forwarding the actual creation of markers onto the "parent" MarkerManager (this will be the MarkerManager instance associated with the AgmMap instance). I did not want to modify too much in the core packages, but I did extend the base MarkerManager constructor with an @Optional() @SkipSelf() _markerManager: MarkerManager. If interested I can add extra functionality to also have the "core" MarkerManager forward it's calls up the tree (until the "parent" is not defined anymore) and thus add the option to create for example an AgmMarkerGroup directive that clusters similar markers which can be disabled at once and/or other (more advanced) features...

I pushed a commit with most of the changes, please comment on the few ones remaining with questions and I'll modify and commit accordingly...

@SebastianM the requested replacements of (?:../)+core to @agm/core result in the failing travis checks since travis does not know about the @agm/* packages when it runs. Unfortunately my experience with travis is limited but I guess some additional config (mapping @agm/* to the correct paths) is needed to make the test(s) run correctly again...

Example of nested cluster and spiderfier (this comes from my own (working) test component):
<agm-map [latitude]="51.673858" [longitude]="7.815982" [maxZoom]="16">
  <agm-marker-cluster [maxZoom]="14"
                      imagePath="https://raw.githubusercontent.com/googlemaps/v3-utility-library/master/markerclustererplus/images/m">
    <agm-marker-spider [keepSpiderfied]="true" (format)="testEvent('format', $event)"
                       (spiderfy)="testEvent('spiderfy', $event)" (unspiderfy)="testEvent('unspiderfy', $event)">
      <agm-marker [latitude]="51.673858" [longitude]="7.815982"
                  (markerClick)="testEvent('markerClick', $event)"></agm-marker>
      <agm-marker [latitude]="51.673858" [longitude]="7.815982"
                  (markerClick)="testEvent('markerClick', $event)"></agm-marker>
      <agm-marker [latitude]="51.673858" [longitude]="7.815982"
                  (markerClick)="testEvent('markerClick', $event)"></agm-marker>
      <agm-marker [latitude]="51.673858" [longitude]="7.815982"
                  (markerClick)="testEvent('markerClick', $event)"></agm-marker>
      <agm-marker [latitude]="51.67" [longitude]="7.8"
                  (markerClick)="testEvent('markerClick', $event)"></agm-marker>
    </agm-marker-spider>
  </agm-marker-cluster>
</agm-map>

@SebastianM any update on this?

@SebastianM  Any updates on this?

<agm-marker-cluster [maxZoom]="14"
imagePath="https://raw.githubusercontent.com/googlemaps/v3-utility-library/master/markerclustererplus/images/m">
<agm-marker-spider [keepSpiderfied]="true" (format)="testEvent('format', $event)"

this not working for me please help me @chancezeus

@SebastianM are there any updates on this?

@SebastianM Any updates on this?

@chancezeus I have had to use this feature so I took the liberty to publish a package.
If anyone feel interested to, follow link of the package.
https://www.npmjs.com/package/agm-oms

@chancezeus I have had to use this feature so I took the liberty to publish a package.
If anyone feel interested to, follow link of the package.
https://www.npmjs.com/package/agm-oms

You sir are a my hero 4 the day!

@chancezeus I have had to use this feature so I took the liberty to publish a package.
If anyone feel interested to, follow link of the package.
https://www.npmjs.com/package/agm-oms

error agm-marker-spider is not known element
and i have added this to app.module.ts in import also but no working

@drjaat you import agm-oms in same location where you imports @agm/core? And you export AgmMarkerSpiderModule? If you do not try export this module.

@chancezeus I have had to use this feature so I took the liberty to publish a package.
If anyone feel interested to, follow link of the package.
https://www.npmjs.com/package/agm-oms

Does this play well with marker clusterer ? If so can you update the README with the syantax please

@chancezeus I have had to use this feature so I took the liberty to publish a package.
If anyone feel interested to, follow link of the package.
https://www.npmjs.com/package/agm-oms

Does this play well with marker clusterer ? If so can you update the README with the syntax please

I tested it and found that it does

Thanks for the reply. When using it in my setup I have a clustered marker of 2 and when I click on it, it just flashes and doesn't separate. Here is my mark up:
<agm-map (mapReady)="mapReady($event)">
    <agm-marker-cluster imagePath="https://raw.githubusercontent.com/googlemaps/v3-utility-library/master/markerclustererplus/images/m">
        <agm-marker-spider>
            <agm-marker *ngFor="let marker of markers" [latitude]="marker.lat" [longitude]="marker.lang">
                <agm-snazzy-info-window [closeWhenOthersOpen]="true">
                    <ng-template>

                            ...

                    </ng-template>
                </agm-snazzy-info-window>
            </agm-marker>
        </agm-marker-spider>
    </agm-marker-cluster>
</agm-map>

Is this correct ? I don't get any errors.

turn clustering off at a certain zoom point using [maxZoom]="10"
I changed your code to as below code below
<agm-map (mapReady)="mapReady($event)">
    <agm-marker-cluster [maxZoom]="10" imagePath="https://raw.githubusercontent.com/googlemaps/v3-utility-library/master/markerclustererplus/images/m">
        <agm-marker-spider>
            <agm-marker *ngFor="let marker of markers" [latitude]="marker.lat" [longitude]="marker.lang">
                <agm-snazzy-info-window [closeWhenOthersOpen]="true">
                    <ng-template>

                            ...

                    </ng-template>
                </agm-snazzy-info-window>
            </agm-marker>
        </agm-marker-spider>
    </agm-marker-cluster>
</agm-map>

Works a treat ! Thank you

@chancezeus I have had to use this feature so I took the liberty to publish a package.
If anyone feel interested to, follow link of the package.
https://www.npmjs.com/package/agm-oms

I'm getting the error:
Error: Uncaught (in promise): TypeError: _this._markerManager.deleteMarkers is not a function TypeError: _this._markerManager.deleteMarkers is not a function     at spider-manager.js:72
I think it's a typo isn't it? Because spider-manager.js tries to call _this._markerManager.deleteMarker**S** when there is only a Method calles deleteMarker()

This extension saved my days. Thank you for your great work. Hope this fully merged to main branch.

I met problems when trying to use agm-oms with js-marker-clusterer. Hopfully, the package of marker spiderfier can be fully supported in agm asap. Thank you very much.

when this will be completed? :)

Whenever someone adopts this PR and makes the necessary changes. I won't be doing it anytime soon, since there are more pressing issues.

I resolved conflicts, rebuild the angular-spiderfier plugin and published the new package under https://www.npmjs.com/package/agm-spiderfier
Now, I don't know if it's better to keep this package distinct or merge it in agm.

 404 Not Found<EMAIL_ADDRESS>@anotherboz latest also not working. And if I install agm/js-marker-spider I see error from code: ERROR in src/app/common/Map/map/map.module.ts(10,39): error TS2307: Cannot find module 'agm/js-marker-spider'.

I resolved conflicts, rebuild the angular-spiderfier plugin and published the new package under https://www.npmjs.com/package/agm-spiderfier
Now, I don't know if it's better to keep this package distinct or merge it in agm.

It work perfect!
But, your new version 1.0.6 is the correct one.

I resolved conflicts, rebuild the angular-spiderfier plugin and published the new package under https://www.npmjs.com/package/agm-spiderfier
Now, I don't know if it's better to keep this package distinct or merge it in agm.

It work perfect!
But, your new version 1.0.6 is the correct one.

well, good point, it works under with latest agm/core https://www.npmjs.com/package/agm-spiderfier1

but when I try to take the production build, I am getting the error : Module not found: Error: Can't resolve 'agm-spiderfier'

I resolved conflicts, rebuild the angular-spiderfier plugin and published the new package under https://www.npmjs.com/package/agm-spiderfier
Now, I don't know if it's better to keep this package distinct or merge it in agm.

It work perfect!
But, your new version 1.0.6 is the correct one.

well, good point, it works under https://www.npmjs.com/package/agm-spiderfier1 with latest agm/core

but when I try to take the production build, I am getting the error : Module not found: Error: Can't resolve 'agm-spiderfier'

I resolved conflicts, rebuild the angular-spiderfier plugin and published the new package under https://www.npmjs.com/package/agm-spiderfier
Now, I don't know if it's better to keep this package distinct or merge it in agm.

It work perfect!
But, your new version 1.0.6 is the correct one.

well, good point, it works under https://www.npmjs.com/package/agm-spiderfier1 with latest agm/core

but when I try to take the production build, I am getting the error : Module not found: Error: Can't resolve 'agm-spiderfier'

I had the same problem and to solve it follow this:
Install as dev Dependencies
npm i -D<EMAIL_ADDRESS>Install as Dependencies
npm i --save<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>npm i --save<EMAIL_ADDRESS>agm-oms
At your tsconfig.app.json
{
  "extends": "./tsconfig.json",
  "compilerOptions": {
    "outDir": "./out-tsc/app",
    // Add  types jest
    "types": ["jest"]
  },
  "include": [
    "src/**/*.ts",
    // Add adm-spiderfier to be compiled
    "./node_modules/agm-spiderfier/**/*.ts"
  ],
  "exclude": ["src/test.ts", "src/**/*.spec.ts"]
}

replaced by #1771

not work !

I resolved conflicts, rebuild the angular-spiderfier plugin and published the new package under https://www.npmjs.com/package/agm-spiderfier
Now, I don't know if it's better to keep this package distinct or merge it in agm.

It work perfect!
But, your new version 1.0.6 is the correct one.

well, good point, it works under https://www.npmjs.com/package/agm-spiderfier1 with latest agm/core

but when I try to take the production build, I am getting the error : Module not found: Error: Can't resolve 'agm-spiderfier'

I had the same problem and to solve it follow this:
Install as dev Dependencies
npm i -D<EMAIL_ADDRESS>Install as Dependencies
npm i --save<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>npm i --save<EMAIL_ADDRESS>agm-oms
At your tsconfig.app.json
{
  "extends": "./tsconfig.json",
  "compilerOptions": {
    "outDir": "./out-tsc/app",
    // Add  types jest
    "types": ["jest"]
  },
  "include": [
    "src/**/*.ts",
    // Add agm-spiderfier to be compiled
    "./node_modules/agm-spiderfier/**/*.ts"
  ],
  "exclude": ["src/test.ts", "src/**/*.spec.ts"]
}

not work !

Is there a possibility that when cluster has been clicked, then It will spiderfy automatically (for almost same coordinates marker)? Thanks

turn clustering off at a certain zoom point using [maxZoom]="10"
I changed your code to as below code below
<agm-map (mapReady)="mapReady($event)">
    <agm-marker-cluster [maxZoom]="10" imagePath="https://raw.githubusercontent.com/googlemaps/v3-utility-library/master/markerclustererplus/images/m">
        <agm-marker-spider>
            <agm-marker *ngFor="let marker of markers" [latitude]="marker.lat" [longitude]="marker.lang">
                <agm-snazzy-info-window [closeWhenOthersOpen]="true">
                    <ng-template>

                            ...

                    </ng-template>
                </agm-snazzy-info-window>
            </agm-marker>
        </agm-marker-spider>
    </agm-marker-cluster>
</agm-map>

Works a treat ! Thank you

With this nested approach of cluster > spider, is there a way that when cluster has clicked, then it will spiderfy after? Thanks


Hackathon: Post Reminders

Summary

Adds the frontend UI for post reminders. Most of the actual UI is copied from the DND status feature. The components in the DND status feature weren't re-usable.

Ticket Link

N/A

Related Pull Requests

Has server changes - https://github.com/mattermost/mattermost-server/pull/20555

Screenshots

Release Note

Added the frontend changes for the post reminders feature

@rmonga71 : IMO, I think cancelling reminders can be done as part of a later PR. However, I like your second option to have the bot post a DM message about the reminder rather than an ephemeral message in channel. This way the message persists, and the user can easily see what messages have reminders set.
@matthewbirtch :

Is there some way to view all my active reminders? If we can consider some way to view all active reminders in an RHS or something, that would be cool. Then you could edit/delete/manage any of your reminders as well.

There isn't, as of now, but can be easily added later. A simple solution is to have a dedicated slash command with /reminders list, but wondering if we should have a dedicated UI section like - threads, insights?

We could consider adding action buttons to the confirmation message when a reminder is set to [Undo] or [View all my reminders]

Definitely. This goes well with @rmonga71's second suggestion to change from an in-channel ephemeral message to a bot DM, in the same channel where the reminders are actually sent.

If you create a reminder for the same post, should we consider warning the user that they have an active reminder for the same post already and confirm if they wish to creat another?

We discussed this, and the behavior we went with was to extend the reminder of the current post to the new time.

When the systembot sends the reminder, should we consider adding a snooze button with options to snooze for 5 minutes, 30 minutes, 1 hr, 2 hrs, tomorrow at same time

Yep, defintely a great enhancement that can be done.

@matthewbirtch

Can we change the title in the submenu from "Remind after:" to "Set a reminder for:"

Done

In the Custom time modal, change the title to "Set a reminder".

Done

In the Custom time modal, it looks like we can tighten up some of the space under the title - should match what we have for the custom DND time modal

Done

In the Custom time modal, make sure the time format is shown based on the time display setting for the user. Right now, it appears to always show a 24-hour clock format (we should fix this in the DND modal too, but can be another ticket)

Done, also fixed in the ephemeral post when the reminder is set

For the message that is posted when the reminder is set, as you mentioned, we should remove the line breaks. Maybe we should consider adjusting the message to "You will be reminded at {time}, {date} about this message from {@username/display name}: {permalink}"

Done

The permalink preview that appears in the ephemeral message that confirms the reminder is set, has its text color greyed out. I assume it's getting inherited from the standard system message body text color or something. Can we change that so the permalink preview doesn't get greyed out but only the actual system message does?

Done

For the message that is posted by the systembot when the reminder executes, can we update the message to "Hi there, here's your reminder about this message from {@username/display name}: {permalink}"

Done in server PR https://github.com/mattermost/mattermost-server/pull/20733

Also, as you mentioned, the submenu in the RHS doesn't feel right as it overlaps most of the menu under it rather than displaying to the left of it

This is more of a problem with the behaviors for submenus, but I find it hard to get to the submenu sometimes - especially if I'm trying to right to one of the bottom options in the submenu. The submenu closes when I diagonally move my mouse from the parent menu to the child menu. Again, this is more of a problem with parent/child menus we have. We would need to look at a holistic solution to this rather than just for this specific case.....I wanted to call it out though since I struggled with choosing the last few options in the submenu a couple times.

Both of these need changes to some of the fundamental building blocks of the webapp. I haven't been able to do them here yet. I'm going to chat with @koox00 and @AshishDhama to figure out the best way to make it work.

@matthewbirtch @rmonga71 @agnivade
Thanks for the feedback and ideas for improvements. As Agniva already suggested, I'd like to get this PR in first, and then work on feature additions incrementally. This PR is already quite big and changes a lot of existing code.
Also, the implementation in this PR, the suggestions in this PR, and the preliminary feature design https://mattermost.atlassian.net/browse/MM-36130 don't exactly align.
After this PR is done, I'd like to reconcile the different ideas and break that jira ticket down into actionable tasks for devs.
// cc @esethna

@koox00 @AshishDhama This is ready for another round of dev reviews. It would be great if you guys could help figuring the menu overlap issue (I've started a discussion above) and the sub-menu hover issue that Matt mentioned.

Going to add load-test coverage today. Please do not merge before that :)

@ashishbhate is there a feature flag? Given it hasn't "passed" UX/PM review before this will get merged should we add a feature flag to ensure we can review an iterate before it ships?

We decided not to add a feature flag since this feature is anyways an opt-in. But given that there is work to be done from a design perspective, it makes sense to add one and start iterating on the feature.

@ashishbhate is there a feature flag? Given it hasn't "passed" UX/PM review before this will get merged should we add a feature flag to ensure we can review and iterate before it ships?

Yep, makes sense. I'll add a feature flag.

After this PR is done, I'd like to reconcile the different ideas and break that jira ticket down into actionable tasks for devs.

Works for me @ashishbhate. Keep me posted on this effort as I'd be happy to help spec out the ideas.

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

@AshishDhama gentle bump for your review and thoughts on the submenu overlap

@ashishbhate on clicking remind it’s opening RHS
https://user-images.githubusercontent.com/16203333/189613145-bda6ab8c-033b-46b7-bb14-df156f5d3ae1.mov

@ashishbhate open sub-menu on hover is great, but I think open on click, will resolve the overlap issue cc// @matthewbirtch
Maybe we can dismiss the submenu by clicking outside(a grey area) and take the user back to the main menu.

@ashishbhate opening sub-menu on hover is great, but I think opening it on click will resolve the overlap issue cc// @matthewbirtch Maybe we can dismiss the submenu by clicking outside(a grey area) and take the user back to the main menu.

This feels like a band-aid solution to me personally. We are show submenus elsewhere in the product on hover (e.g. in the LHS channel context menu, or in the Channel header dropdown menu) so I wouldn't want to change this behavior. I don't fully understand the reasons why we can't make it work as intended though, so forgive me.

@matthewbirtch we discussed this at Mattercon. Essentially the way the app layers panes (Global header > sidebar > center channel > RHS) causes the sub menu in the RHS to always be below the center channel. We figured the best approach for now is to push the submenu as far left as possible without it going under the center channel. It's not ideal (since the sub menu might still overlap the ... menu especially on smaller screen widths, but it allows us to ship this before the web platform team properly fixes the menu component with an overhaul in Q4. Example:

cc// @ashishbhate

We figured the best approach for now is to push the submenu as far left as possible without it going under the center channel. It's not ideal (since the sub menu might still overlap the ... menu especially on smaller screen widths, but it allows us to ship this before the web platform team properly fixes the menu component with an overhaul in Q4.

Ok, that makes sense. I agree it's not ideal, but as long as all the items in the submenu are still accessible and we're not obscuring any labels from the main menu, we can probably live with this until it's properly fixed.
I wonder if we should also consider reducing the width of the parent menu slightly. It looks like we might be able to reduce the width by 20-30 pixels. That might help a bit

closing this in favour of https://github.com/mattermost/mattermost-webapp/pull/12007


Category to Layer link broken

Open the DD  app for Communications
Search "connection"
Open the C:Strand Connection under Categories
Click the open card button next to "Communications Junction Object"

Result: Sorry, no card found. This card can be opened from the TOC just not from this specific card.

Additionally I'm in incognito mode in a new browser.

verified


Reduce number of requests to check email

As discussed, we don't need another request after the response from Google with access_token, because access_token comes with JWT encoded id_token, and it already has account email in it.

Coverage remained the same at 100.0% when pulling be1b295c12815da6bd331dfe4558c1288d3c054d on use-jwt into ed27af47970fa50ba844d0d188d06a5a6f47fc87 on master.

Coverage remained the same at 100.0% when pulling bd20107f7744c1f6c107641485eaec68d881de65 on use-jwt into ed27af47970fa50ba844d0d188d06a5a6f47fc87 on master.


init(memoryCapacity:diskCapacity:diskPath:)' is unavailable in UIKit for Mac

Using latest Xcode 11.0 building for mac I get the following build error:
init(memoryCapacity:diskCapacity:diskPath:)' is unavailable in UIKit for Mac
Would be awesome if that could be fixed!

This has been updated for the 4.0.0 beta series, but not the 3.x series. I'll see if we can backport the changes and release it soon.

This has now been released as part of 3.6.0.


Bumped titus-api-definitions to include the new network mode api and update to latest protogen

In 2020 google changed the golang protobuf stuff https://github.com/protocolbuffers/protobuf-go#historical-legacy:

It has been superseded by the google.golang.org/protobuf module, which contains an updated and simplified API, support for protobuf reflection, and many other improvements. We recommend that new code use the google.golang.org/protobuf module.

And we've been kinda fighting it for a while. I think my version of protoc got updated and I figured, lets move forward instead of downgrading (my laptop)?
So I fought the compile for a couple of hours.
Mostly reading
https://developers.google.com/protocol-buffers/docs/reference/go-generated#invocation
And understanding the relationship between protos and go modules.
Here are the big changes:

grpc files are created separately, so 2 protoc invocations
Specifying the package in the .proto file is deprecated and discouraged (which is why I use the command line args so much)
New Unimplemented stuff are semi-required, but encouraged.

And then on the titus side:

I got rid of the makefile magic. I thought it was just too much and I couldn't figure out what was going on.
Updated all the go.mod references to use the new compiler stuff
Updated the go.mod reference to pick up the latest titus api definitions

Its kinda a lot of stuff at once, but in the end there should be no functional changes to titus stuff.
I might be able to split this apart into separate PRs if you are worried about the big diff, but in the end the "Big" change is the upgrade to protoc, go-proto-gen, and all the changes surrounding that to make it happen.

I'm going to discard this for now.
Someday in the future we will have to upgrade protobuf-gen-go and move to the new golang/protobuf away from the old github.com/protobuf.


Victor/docs/update contribute docs

all credits to @ahsonkhan  :)

Did we try these steps for different developer workflows (both build and test, on a clean machine):

Windows with CLI
Windows with Visual Studio
Linux/Mac with CLI

For example, I couldn't get the tests building on my Windows machine using command line. I might have missed something that wasn't explicitly stated in the  docs.

Did we try these steps for different developer workflows (both build and test, on a clean machine):

Windows with CLI
Windows with Visual Studio
Linux/Mac with CLI
Linux/Mac with VS Code?

For example, I couldn't get the tests building on my Windows machine using command line. I might have missed something that wasn't explicitly stated in the docs.

@ahsonkhan , I created a new issue to follow up Windows without VCPKG.
The problem there is for having having cmocka installed globally gives compilation troubles.
It should be fine for any other case


Allow keys to be excluded in prefix_entries and range_entries

Feature description
Having some filtering when dealing with a list of keys could be handy for some optimization

You probably have a certain use case in mind (filter)? Could you give an example?

I had a valid usecase but I was able to solve it with a multi-key fetch instead.
The use-case was: suppose you know a few items not to be included in a certain range (vdisklist for example, you know the key of vdisk1 which you don't want to fetch). You can do a prefix_entries and then delete the key of vdisk1 or the server could do it for you (less data transmitted, less cpu cycles for the client)

So to exclude the key being sent from the server to the client, you need to send it to the server first.
No win there.