Invoices - "Missing category" appears briefly and disappears after unselecting category

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.23-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:
Precondition:

"Members must categorize all expenses" is enabled in Categories settings

Go to staging.new.expensify.com
Go to FAB > Send invoice
Enter amount and select participant
Select a category and send the invoice
Go to invoice thread
Click Category
Unselect the category

Expected Result:
"Missing category" will not appear briefly and disappear
Actual Result:
"Missing category" appears briefly and disappears
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/user-attachments/assets/d980662c-2459-4a16-972f-f266b8dfdc98
View all open jobs on GitHub

@miljakljajic  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
"Missing category" appears briefly and disappears after unselecting category
What is the root cause of that problem?
We are currently creating missing category violations optimisitically for invoices too
https://github.com/Expensify/App/blob/bf5d7431ac4ea662215a3ae05268f880e63f7ccd/src/libs/actions/IOU.ts#L2700-L2718
But the BE is not returning missing category violations for invoices
This inconsistency also happens in Send Invoice too
https://github.com/Expensify/App/blob/bf5d7431ac4ea662215a3ae05268f880e63f7ccd/src/libs/actions/IOU.ts#L1238-L1255
What changes do you think we should make in order to solve the problem?

We need to align the optimistic data with what the BE returns. For instance, in this specific case we shouldn't create the optimistic violations we are adding for invoices
if (
        policy &&
        PolicyUtils.isPaidGroupPolicy(policy) &&
        updatedTransaction &&
        ('tag' in transactionChanges || 'category' in transactionChanges) &&
        !ReportUtils.isInvoiceReport(iouReport)
    )

and also we should remove the optimistic violation creation code on send invoice here
https://github.com/Expensify/App/blob/bf5d7431ac4ea662215a3ae05268f880e63f7ccd/src/libs/actions/IOU.ts#L1238-L1255
What alternative solutions did you explore? (Optional)

Apologies! Yes - workspace settings apply to both reports and invoices when invoices are enabled.

Updating to internal as we'll need a BE engineer

Moving this to #vip-billpay as it's invoices.

Reassigning for my parental leave - waiting for an internal volunteer. Thank you!

I'm having trouble recreating this, so going to see if this can be retested!

Still waiting for this to be retested!

I'm still not able to recreate on a consistent basis and waiting for this to be tested by QA


Document that a publishedAt value of null is the way to identify forms that don't have a published version yet

For the single form docs and form list docs. Add publishedAt and document that it will only have a null value if there is currently no published version of this form.
Additionally, revise/remove the "If there is no associated Form, null will be returned." language for both.
"Currently, there are no paging or filtering options, so listing Forms will get you every Form in the system, every time." system -> project

addressed in #360.


Update .gitattributes with more file types

Added some more file types that should have CRLF line endings based on how they are in the packaged full version.
Some .ini files in the full tron package were not CRLF like winapp2.ini and ccleaner.ini but they are when you get them from the source so it probably doesn't matter.
bleachbit.ini is LF if you get the installer but CRLF if you download the portable version so that should be fine also.

Good addition, and thanks for the explanation. Merging.


Animal Companion Progression Checkbox Disable Doesn't Provide Levels

I'm not sure if I'm reading this right, but TTTBase changes the animal companion leveling so that it will lag behind character level as per below

However, disabling this checkmark doesn't revert it back to the default game behaviour (i.e. animal companion will level with character level).

Those changes 100% only occur with the progression setting enabled. If you have an existing animal companion you may need to respec (after restarting the game from when you changed the setting) to get the updated level progression.

I've tried respec-ing. Not even starting a new game with the checkbox disabled fixes this.

With the setting enabled this logs indicating the progression change.
[TabletopTweaks-Base] Executing Post Patch: LevelAdjustments.Update_AddPet_RankToLevelAnimalCompanion
[TabletopTweaks-Base] 0,2,3,3,4,5,6,6,7,8,9,9,10,11,12,12,13,14,15,15,16
With the setting off this does not log. You get this with no displayed changes:
[TabletopTweaks-Base] Executing Post Patch: LevelAdjustments.Update_AddPet_RankToLevelAnimalCompanion
Verified manually by leveling up and levels are not using the TTT scale. Any bugs you are encountering at that point are from vanilla.
I just successfully leveled a horse to 20 testing the be 1000% that it worked.

After disabling and re-enabling my mods, and then disabling the animal companion checkmark again, somehow it started working correctly. I'm not even sure why or how. Consider the issue closed. Thank you.


Add support get supported evaluator types

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 13.63636% with 19 lines in your changes missing coverage. Please review.

Project coverage is 77.81%. Comparing base (cd3bf7c) to head (6b8ab29).
Report is 13 commits behind head on master.

Files with missing lines
Patch %
Lines

catboost/catboost.go
13.63%
19 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   81.84%   77.81%   -4.04%
==========================================
  Files           1        1
  Lines         292      311      +19
==========================================
+ Hits          239      242       +3
- Misses         38       54      +16
  Partials       15       15

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[r] Pass config through shape() and nnz()

Issue and/or context: #1137
Changes: Factor out a common helper for converting the config character vector to a std::map suitable for SOMAReader.
Notes for Reviewer: I've tested this in our R CellCensus package, which needs this for shape() to read from the correct S3 endpoint. It's tricky to unit-test though, suggestions welcome

One thing that would be nice though is a test with a config set this way.  Looking at tiledb::config( tiledb::tiledb_get_context() ) and its long list maybe turning the logging format on and off.  The real litmus test is of course that it lets you e.g. pass the AWS parameter through as it should.

What is a bit of a wart though is that despite us doing all the work for an optional config, it is now forced at the top:
> library(tiledbsoma)
> uri <- "/tmp/tiledb/penguins"
> str(nnz)
function (uri, config)
> nnz(uri, NULL)
Error: Not compatible with STRSXP: [type=NULL].
> nnz(uri, character())
Error: Not compatible with STRSXP: [type=NULL].
> nnz(uri, c(NONE=""))
[1] 344
>

I think we can do better by keeping this optional just as some_reader() does.
> library(tiledbsoma)
> uri <- "/tmp/tiledb/penguins"
> str(nnz)
function (uri, config = NULL)
> nnz(uri)
[1] 344
>

Much better. It is a simple one-line change to the signature (plus a run of Rcpp::compileAttributes()) as you factored out the treatment of the NULL into the setter of the map.

Ditto for shape. I have that working here and can add the simple commit.
edd@ahmad:~/git/tiledb-soma/apis/r(mlin/r-config-for-shape-and-nnz)$ Rscript -e 'tiledbsoma::shape("/tmp/tiledb/penguins")'
integer64
[1] 344
edd@ahmad:~/git/tiledb-soma/apis/r(mlin/r-config-for-shape-and-nnz)$

As I wrote, I have the (small) extension to make config optional working.    It tests cleanly here.  Of course, if you would rather (re-)do it yourself that is perfectly fine too.
I didn't yet get to a unit test.  My idea was to maybe turn logging on/off and assert stdout.

@eddelbuettel Sure, I welcome your input on both items of course

Hold on, I just realized I should be a good boy and also mark the config as optional and update the Rd files.  One sec.

From a quick Slack discussion with the core team, one way to 'break' access is to set a borked key and being not exactly truthful about encryption (by pretending there was some on a quick local array).
> tiledbsoma::nnz("/tmp/tiledb/penguins", c(sm.encryption_key="Nope", sm.encryption_type="AES_256_GCM"))
Error: Error opening array: '/tmp/tiledb/penguins'
  [TileDB::Array] Error: [TileDB::Encryption] Error: Cannot create key; invalid key length for encryption type.
>

I added tests for nnz() and shape() based on the idea above.


Suggestion: Online preset exchange

First of all I just wanted to express my appreciation for your efforts, this is a fantastic project. The app is excellent and the additions -- in particular, the ability to save multiple presets -- are really useful.
Anyway, I was wondering whether it might be useful to create a means for users to exchange presets easily. I was thinking along the lines of a central online preset repository: within the app, a user could export a preset to the repository, perhaps giving it a title and a brief description -- e.g. if it's for a particular artist, a specific song or or just a general style -- and maybe even have categories.
Then other users could (again, from within the app) search and/or browse the repository and download any presets they find interesting.
Just a thought.
Thanks again and keep up the great work!

I'm glad that you find the app useful. I also have that feature in mind among others, like an option to search backing track websites like guitarbackingtrack.com and backingtracks.co and add tracks to your jamtracks list. However I want to complete the features that are WIP currently.
Besides, there are like 20-30 active users of the app so I don't expect an extensive online presets library.

Fair enough. Being able to search/download from backing track sites would be a fantastic feature.

Besides, there are like 20-30 active users of the app so I don't expect an extensive online presets library.

I'm spreading the word about the app wherever I can!


Incorrect information regarding Virtual Tables by SQL Views

Please update this information to reflect that GUIDs are not accessible as Primary Fields when the Virtual Table is created from a SQL View. And as such, Virtual Tables that come from SQL Views will not work correctly as lookup columns.
Thank you.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5ecd34d0-7724-9d0b-025b-63eeadb7b32a
Version Independent ID: 5ecd34d0-7724-9d0b-025b-63eeadb7b32a
Content: Limitations and troubleshooting virtual tables with Power Apps - Power Apps
Content Source: powerapps-docs/maker/data-platform/limits-tshoot-virtual-tables.md
Service: powerapps
Sub-service: dataverse-maker
GitHub Login: @NHelgren
Microsoft Alias: nhelgren

Thanks for your comment, @Squire4Hire. This issue has been assigned to the doc author for review.

I want to bump this.
I did more testing yesterday to see if anything has changed. It appears to me that this issue isn't limited to SQL Views. Virtual Tables created directly from SQL tables straight up don't work in Dataverse the way MS suggests. Sure, you can hook them up but you will not see lookup values displayed when used as a lookup in a Dataverse table.
The value exists, but the Primary Field is not displayed:

Unless I'm missing something, there is nothing in the documentation that suggests this shouldn't be possible.

Hi @Squire4Hire, All virtual tables display the Primary Name field as the lookup value, this cannot be changed. additional values an be retrieved though use of Automate or formulas in canvas apps if needed for the apps.

Hi @Squire4Hire, All virtual tables display the Primary Name field as the lookup value, this cannot be changed. additional values an be retrieved though use of Automate or formulas in canvas apps if needed for the apps.

Perhaps I haven't made myself clear enough. Let me try again...
I am trying to use a Virtual Table as a Lookup Value for an existing Dataverse table. This requires a virtual table to be configured in PowerApps as an added Virtual Table from a SQL Server datasource.
Problem 1: It is not possible to select a GUID key column if the table is created from a SQL View. This is contrary to what the documentation suggests is possible. SQL Views cannot be used as Virtual Tables if a GUID field cannot be selected at the time of virtual table creation.

Problem 2: If the Virtual Table is created via a direct link to the original SQL Table, users are not able to use this Virtual Table as a Lookup Field on another Dataverse table as the Primary Value field is not displayed correctly in the Parent Table. Yes, the GUID value exists when selected. Yes, the list of items appears in the dropdown when a user makes a selection. But the Primary Value disappears once the screen is reloaded, or when it is presented on any other Dataverse Form or View.


Serverpod CLI can leave Zombie processes if runtime is interrupted.

Describe the bug
The Serverpod CLI utilized asynchronous processed when creating a new project for setting up docker containers and applying the initial database migration.
If the user (or as in our case, the test environment) aborts CLI command when a process has been started, they are left as zombie processes and are not cleaned up.
To Reproduce
Steps to reproduce the behavior:

Create a new project with verbose logging enabled. serverpod create my_pod --verbose
Kill the CLI process after the debug message Applying migrations. is displayed.
Observer that the Server output for applying migrations continues and that the docker containers is left running.

Expected behavior
The Serverpod CLI never leaves any running zombie processes.
Serverpod versions

CLI Version: latest main.

Platform information
macOS.

@SandPod Can you cross-check this one? I tried this, but the threads and processes are about to exit. They stay in activity only for 2–3 seconds and are dead or killed.

This case it actually resolved since we have now removed applying migrations as part of the creation process with this PR: https://github.com/serverpod/serverpod/pull/1724.
I don't think there are any other processes that are started and left during the creation process.
Thanks for the ping on this @yahu1031


Remove "External Processes" from 1.x doc

Since https://github.com/sbt/util/commit/4629053277afb703829ca2b586d4b4ed12e35e17, sbt.ProcessBuilder seems to have been removed. However, https://github.com/sbt/website/blob/1.x/src/reference/02-DetailTopics/02-Configuration/12-Process.md still references it. This page should be updated to reflect the new way to execute external processes.
(Maybe sbt.ProcessBuilder has just been moved, not removed altogether, but if so, I couldn't find it. Unfortunately, I don't know what the new way of running external processes is.)

It's moved to http://www.scala-lang.org/api/2.12.x/scala/sys/process/index.html.
We should update the docs accordingly.

Fixed in #429.


ES6-style classes & JSX binding doesn't work as expected.

This is a fun one :)
I'm in need of class hierarchy and thought that using ES6-style classes would be the best way to achieve this result using basic ES6 OOP patterns.  I've got things mostly working, but found that the JSX method binding doesn't actually act as (how I) expected and need someone to help me understand why.
The Breakdown
My class's render function returns a block of components that bind this.onButtonPress. Nothing out of the ordinary.
        return (
             ...
                <View style={styles.controlsContainer}>
                    <MusicControlButton onPress={this.onButtonPress} btnChar={"dislike"} btnStyle={"dislikeButton"} isLikeBtn={true}/>
                    <MusicControlButton onPress={this.onButtonPress} btnChar={"prev"} btnStyle={"prevButton"}/>
                    <MusicControlButton onPress={this.onButtonPress} btnChar={centerBtnChar} btnStyle={centerBtnStyle}/>
                    <MusicControlButton onPress={this.onButtonPress} btnChar={"next"} btnStyle={"nextButton"}/>
                    <MusicControlButton onPress={this.onButtonPress} btnChar={"like"} btnStyle={"likeButton"} isLikeBtn={true}/>
                </View>
            </View>
        );

onButtonPress references a map to do method calls.  (way cleaner than doing if/else and/or switch/case).
    onButtonPress(buttonType) {
        var methodName = this.methodMap[buttonType];
        this[methodName] && this[methodName]();
    }

The method map is a plain'ol JavaScript object:
(JSX Version)

    methodMap : {
        'prev'  : 'previousTrack',
        'next'  : 'nextTrack',
        'play'  : 'playTrack',
        'pause' : 'pauseTrack'
    },

    onButtonPress : function(buttonType) {
        var methodName = this.methodMap[buttonType];
        this[methodName] && this[methodName]();
    },

-----------
(ES6 version)
AbstractPlayer.prototype.methodMap = {
    prev     : 'previousTrack',
    next     : 'nextTrack',
    play     : 'playTrack',
    pause    : 'pauseTrack',
    like     : 'like',
    dislike  : 'dislike'
};

So here's the rub.
In the JSX Version, the binding works as expected this is a reference to the instance of the class.

In the ES6 version, the binding (this) points to a plain javascript object.

Here's the original class (Using React.createClass()):
https://gist.github.com/jaygarcia/e68682c284ded8e6cea0#file-gistfile1-js-L123
Here's  the ES6 version.
https://gist.github.com/jaygarcia/fea5905ee361864aa5d9#file-gistfile1-js-L99
What did I do wrong?  I tried to follow the Extensibility guide, but it didn't help much:
https://github.com/facebook/react-native#extensibility
/cc @grgur

ES6 React classes don't autobind their methods so you have three options:

Bind the methods yourself in the constructor() function
Use the property syntax like onButtonPress = buttonType => { ... };. This might require adjusting the options that the packager passes to Babel.
Use decorators like @autobind onButtonPress() { ... }. Again this might require a small patch to the packager.

@ide nailed it, not much else to say here :smile:
Awesome level of detail in your report @jaygarcia :rocket:

@ide , thanks for the documentation. I somehow missed that.
@brentvatne , thanks for closing this :)

So far, this is the only thing that work (Lexical scoping).
So, to currently use ES6-style classes with RN 0.4.4, I have to muddy up  my code with adhoc binding.
I don't see the value at the current time :(
     var buttonPress = (x) => {
            this.onButtonPress(x)
        }

        return (
               .....

                <View style={styles.controlsContainer}>
                    ....
                    <MusicControlButton onPress={buttonPress} btnChar={centerBtnChar} btnStyle={centerBtnStyle}/>
                    ....
                </View>
            </View>
        );

I know it's been a while since this thread was alive, but I've had some luck by adding es7.functionBind to the transformer.js whitelist in the packager. Then you can do something like:
<MusicControlbutton onPress={::this.onButtonPress} />

It seems to work just fine for my needs, although my IDE (WebStorm 11) doesn't support the syntax yet...

@ruswerner thanks, this is what I was looking for.
Is there a reason, why es7.functionBind is not included by default?

@dropfen I'm not sure why, but it's probably because it's not finalised enough for them. Here is my rn-babelrc.json (search your project for it):
{
  "presets": [
    "react-native"
  ],
  "plugins": [
    "transform-decorators-legacy",
    "transform-export-extensions",
    "transform-function-bind"
  ]
}

You'll need to install those packages and restart the packager before it will all work. Hope that helps!

Hey @ruswerner! Thank you very much for this.
After some research I found that there is no need to modify the rn-babelrc.json file in node_modules / react-native / packager.
just create a .babelrc file in your project root with that content and it just works.
Hope that helps, too!

Yep. Much better. Thanks!
On Mon, Jun 27, 2016 at 10:05 AM, webdeb<EMAIL_ADDRESS>wrote:

Hey @ruswerner https://github.com/ruswerner! Thank you very much for
this.
After some research I found that there is no need to modify the
rn-babelrc.json file in node_modules / react-native / packager.
just create a .babelrc file in your project root with that content and it
just works.
Hope that helps, too!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/1436#issuecomment-228625767,
or mute the thread
https://github.com/notifications/unsubscribe/AA4YVMCbydF6pIT7TXWwFgRP3esDir-Rks5qPvewgaJpZM4Et29W
.


http protocol for rustc daemon

Hi @jwilm,
As per my post yesterday I'm putting together a daemon to provide rustc based type inference for racer. I intend to use http and wondered if you had any opinions based on your experience with the ycmd protocol and Racerd.
Glancing over the ycmd protocol I was surprised that it isn't more RESTy, or at least that it doesn't use GET more. It seems a shame not to be able to use curl to perform a query or paste a query into a browser and eyeball the results.
What's your take? Thanks!

Hey @phildawes
Thanks for the mention in your post :smile:. I just read through it; rustc-based type inference is exciting! HTTP is a fantastic choice for these services - every language has some sort of http library to query with, it's highly parallelizable, and developers are very comfortable working with it.
Although inspired by YCM, the protocol racerd speaks is actually independent of the YCM protocol and contains no YCM specific functionality. POST endpoints in this case are nice because the large chunk of data that gets sent to the server does not need URL encoding as they would if sent via GET. The endpoints are still queryable, too. See the cURL command sections in the racerd API docs. racerd offers a status endpoint /ping via GET which is critical for consumers to know when the service is available.
Architecturally, I cannot stress enough how important it is to separate out the semantic analysis (in this case just the type inference) code from the HTTP wrapper and command line API. I would go as far to say that the library should be a separate project from the executable. In the case of racerd, this allows a consumer to integrate at any level - command line via the executable, as a library via starting the HTTP service, or directly with a service provider thereby circumventing the HTTP server all together.
You mentioned something about building out this feature as a project separate from racer. Is that really necessary? Could the rustc type-inference instead be feature-gated within racer? The default racer build would still be trivial on stable/whatever, and then users can "just" opt-in to an advanced build. The downside I see with splitting it out is fragmentation of racer functionality (eg. now users need racer and racer-rustc-type-infer). I would also be hesitant about having the racer and rustc inference integration be via HTTP. For intralibrary communication, HTTP would be magnitudes slower than directly through the ABI.
One final question - why is the initial plan to make a rustc daemon? It was mentioned sort of matter-of-factly in the blog post as the solution. Just curious :blush:.
Once Rust YCM is launched, I would be happy to help out with the rustcd project. I think I've got some relevant experience :wink:.

Hi @jwilm,
I'm was trying to address a couple of problems with the typeck daemon thing:

Not having to bind racer to a specific version of rust.
Being able to experiment without affecting existing racer code, users and plugins

The rustc api is unstable and currently in a state of flux: the compiler team are working hard to implement MIR and incremental compilation features and the apis change frequently (sometimes multiple times a week). Tracking rust nightly in this environment will generate a bunch of work (racer used to do this with libsyntax pre-1.0 before syntex_syntax came along), and tracking beta or stable requires special hacks[1]
A separate daemon might not be the best solution though. hmmmm.. I'll sleep on it and reply more in the morning
[1] hack: if you grep the rustc lib binary you can extract a secret date string that lets you unlock the unstable functionality in a stable build

Hi @phildawes -- maybe I'm a bit naive here, but isn't the new Language Service Protocol the ideal (light) IDE-integration path going forward? I commented at racerd the same thing but of course direct integration would be super-awesome...
There's already a few implementations

I hadn't seen this. Thanks Dominik I'll check it out
On 29 Jun 2016 08:04, "Dominik Wagenknecht"<EMAIL_ADDRESS>wrote:

Hi @phildawes https://github.com/phildawes -- maybe I'm a bit naive
here, but isn't the new Language Service Protocol
https://github.com/Microsoft/language-server-protocol the ideal (light)
IDE-integration path going forward? I commented at racerd
https://github.com/jwilm/racerd/issues/49 the same thing but of course
direct integration would be super-awesome...
There's already a few implementations
https://github.com/Microsoft/language-server-protocol/wiki/Protocol-Implementations
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/phildawes/racer/issues/457#issuecomment-229273677,
or mute the thread
https://github.com/notifications/unsubscribe/AAFVzp2GPszUHej4JPNF35SnpGzg2Dztks5qQhjogaJpZM4G83Q7
.

At this point, racer is just focused on supporting RLS by fixing bugs and making improvements where there is a need from RLS. RLS implements the LSP and is partially powered by racer.


Server crash

Modpack:
StoneBlock
Crash Report
https://gist.github.com/knoxhack/37ebb918eb6ad514b5551767770e2570

This issue was fixed in 1.10a


Add Minimalist Artifact Listing to Column Options for Monsters

Right now, what I want to know are:

How many of my 6* monsters don't have artifacts?
How many of them aren't powered up to 15?
How many of them are the wrong sort of artifact because I threw something on early on and I need to change them?

There's no easy way to see it (in bulk) either in the game's UI or in Swarfarm's.
It'd be nice to have something like you've got for the runes, where hovering over gives more detail, but you can see it en masse for all your monsters.
FWIW, when I'm looking at this, I'm usually filtering based on 6*, so I'm looking at archetype (because some of the archetypes don't match their skillsets, why com2us why?) leader skill, skills, runes, stats. Having the artifacts next to the runes but before the stats detail would IMHO be ideal, though others may disagree.

herders/templates/herders/profile/artifacts/artifact_image_fragment.html has the existing snippet used to display the artifact symbol/quality.
Issue is that, unlike runes, the type (atk/def/hp) isn't shown in the artifact itself, but is separate text and may introduce layout issues in the table.

Artifact icon says the type and slot if you know these symbols. It may be not known by everyone, so the order may say which slot it is. We could add some conditions:

No artifacts equipped: Empty cell

Left (SB10, archetype) equipped: Only one image

Right (PB10, attribute) equipped: Left is "?" or some other symbol like X on white background

Both artifacts equipped:

And just by hovering over the Artifact image, you would get more info in tooltip (same as runes), where main stat is be visible.

I've also fixed artifact popover not having element/archetype logo and added artifacts to monster popover, since these were missing

Is it good?


hapi post client

Looks real good, Adam! As much as I have a philosophical distaste for JavaScript, its becoming difficult to argue with the efficacy of this implementation. I'm enjoying following its progress!


Own data

Hello
How can I use my own data? The maximum I found was how to convert nerfacto through .py, and then I got a very blurry picture. I've seen users sharing depth maps, where do you get them all?

Like this

Could it be that my colmap was not processed?

you can get depth maps by wandb


Jgdoc

I pushed changes per the comments. Do I need a new pull request? @twblamer

You can just close this pull request and push to your jg-doc branch which is tracked by #18 (possibly squash your commits too).
Or you can close that one and merge this one. Either way, we don't need two PRs.


chore(main): release 0.2.6

:robot: I have created a release beep boop
0.2.6 (2024-09-17)
Features

add flow telepresence-intercept CLI command (#213) (d5a75f6)
Add health error response (#224) (d86eaa7)
add the baseline column in the flow ls CLI command (#217) (9360ef3)
calculator track events when values change (#215) (7a16e40)
docs anchor links for headings (#214) (7fbb139)
variant of calculator page with share section (#207) (f4242f2)
website get started section (#220) (805189b)

Bug Fixes

calculator mobile styles (#216) (9aa6af7)
fix some confusing copy (#221) (e831db5)
replace 'prod' default namespace with 'baseline' in the ci-e2e-tests.yml (#227) (c81b2d4)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/kurtosis-tech/kardinal/releases/tag/0.2.6 :sunflower:


FAT2-412 rename sector table pt1

The sonar code smell will be resolved with part 2 of this when the Sectors repository's are deleted


[Flakey test] DockerRegistryAuthTokenSuite.TestPushMisconfiguredTokenServiceResponseError

https://jenkins.dockerproject.org/job/Docker Master (arm)/5003/console
18:08:54 FAIL: docker_cli_push_test.go:608: DockerRegistryAuthTokenSuite.TestPushMisconfiguredTokenServiceResponseError
18:08:54
18:08:54 docker_cli_push_test.go:616:
18:08:54     c.Assert(out, checker.Contains, "Retrying")
18:08:54 ... obtained string = "" +
18:08:54 ...     "The push refers to a repository [<IP_ADDRESS>:5000/busybox]\n" +
18:08:54 ...     "5f70bf18a086: Preparing\n" +
18:08:54 ...     "076f5601cfb4: Preparing\n" +
18:08:54 ...     "toomanyrequests: out of tokens\n"
18:08:54 ... substring string = "Retrying"

/cc @aaronlehmann @dmcgowan @dmp42

I see the issue. By the time the upload goroutine in push happens, the server has already retried it's x amount of times and is now just throwing the given test response (toomanyrequests: out of tokens in this case). Because this response is a do not retry response, it doesn't retry, hence the check for "Retry" fails.
I don't think testing for a retry needs to happen in this test anyway, none of the other tests in the suite do it, and I imagine there is a much less racy / more efficient test for that anyway. I can open a PR changing the behavior

so I am actually mistaken, the original point of the test is to test for retries, and the error it is throwing is just a non-retry error, so we just need a less racy way of bringing up a temporarily unavailable registry, let me rework what I've done.

I'm seeing two different GET requests on the failing ones, do any of you know where / why dockercli is getting added?
&{GET /?scope=repository%3Abusybox%3Apush%2Cpull&service=registry
vs
&{GET /?scope=repository%3Abusybox%3Apush%2Cpull&scope=repository%3Adockercli%2Fbusybox%3Apull&service=registry

@tophj-ibm ohh interesting 😓 no reald idea but that can give us some inputs, I'll try to take a look tomorrow 👼

Should be resolved by https://github.com/docker/docker/pull/32285


Remove the loading icon div and replace it by a pure css solution using :after.

This way we don't have a lot of useless divs and we let the css engine handle the creation/destruction of the :after pseudo-element. It'll help to slightly improve performance when zooming.

Here is a profile from Firefox beta without the patch:
https://share.firefox.dev/3JAzElB
and one with the patch:
https://share.firefox.dev/3Hs7vdF

/botio-linux preview

Testing the preview it now seems that the loadingIcon is displayed immediately, and no longer waits the 400 ms as before.

/botio integrationtest


Cannot read properties of undefined (reading 'digest')

getts/chapter9/src/lib/universal_sha256.ts
const crypto = require('crypto');
The reference is written in the wrong place ,The reference should be written outside the function

第九章里面的代码根本根本跑步起来


Add missing React imports for fragments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 72.309%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2082

Relevant Lines:
2655

💛  - Coveralls


Revise the way that configuration is handled.

Priority should be as follows:

default
pyproject.toml
cli arguments

The way this is currently handled with the creation of a cli_arguments dictionary in cli.py is not very nice, there is room for improvement there.

This is currently blocking #10. bool and List[str] arguments are both added as values to the same dict with cli arguments, so from that point on mypy can not distinguish between these anymore, and the Core class does not know which arguments are booleans, and which ones are List[str].

Cleand up the config handling and moved some of the config handling out of cli.py to config.py. However, this still does not solve mypy's type checking.


Sync with the original repo (version 4.2.x)

Closing all existing pull requests that do not target the develop branch. In case this pull request is still valid, please rebase your changes against develop branch and resubmit.


Link generator performance

Link generator should be at least as fast as existing functionality.

Link generator should be at least as fast as existing functionality.

I should hope we can do a lot better 👍

Note, we ended up making the existing functionality a lot faster as part of this work. LinkGeneration is slightly faster than the 2.1.0 experience with routing.


[PE-D][Tester B] Exception command doesn't indicate invalid time problem accurately

The message user receives can be more specific, e.g. "Please key in a valid time"

Labels: severity.Low type.FeatureFlaw
original: Hwww23/ped#3

Note: it is 13am in the screenshot.

Feature change


Update test workflow

Upgrading node version
Allow fail on non-essential node versions
Cancel workflow when another commit is made on the same branch
Run jobs on batch of 3
Unifying code coverage workflow

This is part 1 of 2 fro the dependencies update.

@robertohuertasm No idea why the PR has no access to secrets although the checkbox for "Allow edits and access to secrets by maintainers" is checked.

@robertohuertasm If you find some time pls do a review so we can merge this PR and iron out any issue that may lurk.

 Now I have to work on the second part of the update. @robertohuertasm Pls hold any release until I submit the rest.

What do you need to do? Maybe I can help you with that.

I have done it when I worked on the workflow update. I just have to bring it up to speed. Some rebase and potential fixes for issues that may have arise since. Hopefully I can resolve it in a couple of hours.

Ok, I'll try to fix some pending PRs in the meantime.


does AsyncNotifyWhenDone's tag always be ahead of other tag?

does AsyncNotifyWhenDone's tag always be ahead of reader/writer's tag?(ie. ServerAsyncReaderWriter), or grpc doens't have such gurrantee?

There is no guarantee of ordering, because AsyncNotifyWhenDone() can be triggered by an out-of-band cancellation, which can happen at any time.

thanks


OpenTSDB support for remote storage

Looks like OpenTSDB support in fact is broken for Prometheus 1.4.1.
I'm trying to export metrics to OpenTSDB 2.3.0 but receiving a lot of warnings from both sides.
Prometheus:
./prometheus -config.file=prometheus.yml -storage.remote.opentsdb-url=http://<IP_ADDRESS>:4242/api/put/

WARN[0679] error sending 100 samples to remote storage: read tcp <IP_ADDRESS>:44502-><IP_ADDRESS>:4242: read: connection reset by peer  source=queue_manager.go:246
WARN[0681] error sending 100 samples to remote storage: read tcp <IP_ADDRESS>:44510-><IP_ADDRESS>:4242: read: connection reset by peer  source=queue_manager.go:246
WARN[0681] error sending 100 samples to remote storage: read tcp <IP_ADDRESS>:44512-><IP_ADDRESS>:4242: read: connection reset by peer  source=queue_manager.go:246

OpenTSDB:
13:24:31.608 WARN  [HttpQuery.logWarn] - [id: 0xe5b4ea8a, /<IP_ADDRESS>:41453 => /<IP_ADDRESS>:4242] Bad Request on /api/put: Chunked request not supported.
13:24:31.608 WARN  [HttpQuery.logWarn] - [id: 0xd31743c8, /<IP_ADDRESS>:41452 => /<IP_ADDRESS>:4242] Bad Request on /api/put: Chunked request not supported.
13:24:31.608 INFO  [ConnectionManager.handleUpstream] - [id: 0xe5b4ea8a, /<IP_ADDRESS>:41453 :> /<IP_ADDRESS>:4242] DISCONNECTED
13:24:31.608 INFO  [ConnectionManager.handleUpstream] - [id: 0xd31743c8, /<IP_ADDRESS>:41452 :> /<IP_ADDRESS>:4242] DISCONNECTED
13:24:31.608 ERROR [RpcHandler.logError] - [id: 0xe5b4ea8a, /<IP_ADDRESS>:41453 :> /<IP_ADDRESS>:4242] Unexpected message type class org.jboss.netty.handler.codec.http.DefaultHttpChunk: org.jboss.netty.handler.codec.http.DefaultHttpChunk@5bd45d9c
13:24:31.608 ERROR [RpcHandler.logError] - [id: 0xd31743c8, /<IP_ADDRESS>:41452 :> /<IP_ADDRESS>:4242] Unexpected message type class org.jboss.netty.handler.codec.http.DefaultHttpChunk: org.jboss.netty.handler.codec.http.DefaultHttpChunk@42ab5c93
13:24:31.608 INFO  [ConnectionManager.handleUpstream] - [id: 0xe5b4ea8a, /<IP_ADDRESS>:41453 :> /<IP_ADDRESS>:4242] UNBOUND
13:24:31.609 INFO  [ConnectionManager.handleUpstream] - [id: 0xd31743c8, /<IP_ADDRESS>:41452 :> /<IP_ADDRESS>:4242] UNBOUND
13:24:31.609 INFO  [ConnectionManager.handleUpstream] - [id: 0xe5b4ea8a, /<IP_ADDRESS>:41453 :> /<IP_ADDRESS>:4242] CLOSED
13:24:31.609 INFO  [ConnectionManager.handleUpstream] - [id: 0xd31743c8, /<IP_ADDRESS>:41452 :> /<IP_ADDRESS>:4242] CLOSED
13:24:31.609 INFO  [HttpQuery.logInfo] - [id: 0xe5b4ea8a, /<IP_ADDRESS>:41453 :> /<IP_ADDRESS>:4242] HTTP /api/put done in 1ms
13:24:31.609 INFO  [HttpQuery.logInfo] - [id: 0xd31743c8, /<IP_ADDRESS>:41452 :> /<IP_ADDRESS>:4242] HTTP /api/put done in 1ms

I can also see some metrics are partially appearing in OpenTSDB with tsdb uid grep etcd  but not the whole list.
As I understand there is going to be no further support for this kind of exporter and I should instead expect the new generic exporter for influx/opentsdb/graphite altogether in the forthcoming release.
Is my understanding right? :)

Prometheus config:
global:
  scrape_interval:     15s
  evaluation_interval: 15s
  external_labels:
      monitor: 'codelab-monitor'
rule_files:
  # - "first.rules"
  # - "second.rules"

scrape_configs:

  - job_name: 'etcd-env-4'
    scrape_interval: 5s
    scrape_timeout: 5s
    scheme: https
    tls_config:
       insecure_skip_verify: true
    file_sd_configs:
       - files:
          - etcd-env-4.yml

etcd-env-4.yml:
- targets:
  - <IP_ADDRESS>:2379
  - <IP_ADDRESS>:2379
  - <IP_ADDRESS>:2379
  labels:
    env: env-4

OpenTSDB backended with HBASE:
tsd.network.port = 4242
tsd.network.bind = <IP_ADDRESS>
tsd.network.tcp_no_delay = true
tsd.network.keep_alive = true
tsd.network.reuse_address = true
tsd.network.worker_threads = 8
tsd.network.async_io = true
tsd.http.staticroot = /usr/share/opentsdb/static/
tsd.http.cachedir = /tmp/opentsdb
tsd.core.auto_create_metrics = true
tsd.core.plugin_path = /usr/share/opentsdb/plugins
tsd.storage.hbase.data_table = tsdb
tsd.storage.hbase.zk_basedir = /hbase
tsd.storage.hbase.zk_quorum = localhost

I should instead expect the new generic exporter for influx/opentsdb/graphite altogether in the forthcoming release.

Yes, but the code will still hang around as an example.
This smells like a network issue to me, so I'd suggest discussing on https://groups.google.com/forum/#!forum/prometheus-users


Eating certain items will cause you to morph into them

When attempting to eat something like cod or salmon, you would morph into that entity.
Reported by Angel 21413 on MCPEDL
The cause of this is simply because of the query.get_equipped_item_name only testing for the identifier, without the namespace. Since the cod/salmon item and cda002:cod/cda002:salmon share the same identifier, it would execute it when it wasn't supposed to.
Proposed Fixes:

Create another set of items, this time with a namespace identifier as something along the lines of cda002:cda002_cod so that we test for cda002_cod as opposed to cod. Change the old items in to an edible format which converts the item to this when it is eaten.
Alternatively, can wait for 1.16.100 items to be removed from experimental, then convert every item to that, with the minecraft:on_use component.
It's possible that if #84 is fixed, this will less of an issue, as less people would be sneaking and/or jumping while holding items, typically.

Project moved to new repository


Need to use the same environment for GitHub Actions and local development

The Format Check workflow in GitHub Actions passes but in my local environment I get the following errors:
would reformat /Desktop/ORNL/FlowceptZambeze/zambeze/zambeze/orchestration/plugins_message_template_engine.py
would reformat /Desktop/ORNL/FlowceptZambeze/zambeze/zambeze/orchestration/plugins_message_validator.py

Oh no! 💥 💔 💥
2 files would be reformatted, 111 files would be left unchanged.

The GitHub Action workflow is using black 24.3 but in my local environment I'm using 23.11. The different versions are causing different format results which is why black may pass locally but fail in the GitHub Actions workflow and vice versa. The same Python environment needs to be used on local machines and for Github Actions to avoid this problem.

The black formatter for this project has been replaced with ruff. Configuration for ruff can be done in the pyproject.toml file which ensures a similar linter/formatter environment for local and remote tests. Closing this issue as it's no longer relevant due to recent changes to the project.


unable to pick --rerunfailed xml with version 5.0 and above

Hello Team,
We are trying to upgrade to version 5.0.1 version from 4.1.3 and found an issue when we are using --rerunfailed tag after first execution with output.xml during jenkins execution:
$xvfb_cmd pabot --verbose --processes 7 --pabotlib ${VARIABLE_PARAMS} --output firstAttempt.xml tests/ || $xvfb_cmd pabot --verbose --processes 7 --pabotlib ${VARIABLE_PARAMS} --rerunfailed firstAttempt.xml --output secondAttempt.xml tests || true
Getting
12:48:36 Collecting failed tests or tasks from 'firstAttempt.xml' failed: Reading XML source 'firstAttempt.xml' failed: No such file or directory
where as its working fine in version 4.1.3. We tried on both version 5.0 and 5.0.1, 5.2 but facing same issue.
Logs:
12:48:36 Output: /home/ubuntu/workspace/TestSuite/sdet/FE-Suite-Test/dashboard-testsuite-browser-library/pabot_results/46/firstAttempt.xml
12:48:36 Invalid options 'skip', 'skiponfailure', 'variable', 'variablefile', 'listener' and 'prerunmodifier'.
12:48:36 Stopping PabotLib process
12:48:36 Robot Framework remote server at <IP_ADDRESS>:8270 started.
12:48:36 Robot Framework remote server at <IP_ADDRESS>:8270 stopped.
12:48:36 PabotLib process stopped
12:48:36 Total testing: 13 hours 29 minutes 4.40 seconds
12:48:36 Elapsed time: 2 hours 18 minutes 29.34 seconds
12:48:36 + xvfb-run '--server-args=-screen 0 1920x1080x24 -ac' pabot --verbose --processes 7 --pabotlib  --variable ${VARIABLE_PARAMS} HEADLESS_MODE:true --rerunfailed firstAttempt.xml --output secondAttempt.xml tests
12:48:36 Collecting failed tests or tasks from 'firstAttempt.xml' failed: Reading XML source 'firstAttempt.xml' failed: No such file or directory

Seems more like a problem with Pabot for me. Have you updated it when you updated Robot?

Pabot was 2.0.1, shall I update pabot to latest (2.5.3) and try?

Yeah, could be that older Pabot versions aren't compatible with RF 5.

Thanks @pekkaklarck
working with latest version of pabot.


GPII-2103: Create a "launcher" that supports environment variables and command-line parameters...

See GPII-2103 for details.

@amb26, I am starting to use this heavily in other work, IMO this is a good candidate to revisit now.

Self-merging in preparation for migration to a new organisation.


alsaaudio.ALSAAudioError: Unable to find mixer control

Hi,
i can't understand what mixer should i specify, i tried  in the sh script given my configuration below. i got the sound coming out of the speakers but i can't have the service running and stops with the error reported below. Any clue about what i am missing? thanks
pi@robbamusic:~/spotify/spotify-connect-web $ aplay -L
null
    Discard all samples (playback) or generate zero samples (capture)
btaplay_dmix
alsaequal
plug_alsaequal
btstream
crossfeed
plug_bs2b
eqfa4p
plug_eqfa4p
default
sysdefault:CARD=sndrpihifiberry
    snd_rpi_hifiberry_digi,
    Default Audio Device
iec958:CARD=sndrpihifiberry,DEV=0
    snd_rpi_hifiberry_digi,
    IEC958 (S/PDIF) Digital Audio Output
dmix:CARD=sndrpihifiberry,DEV=0
    snd_rpi_hifiberry_digi,
    Direct sample mixing device
dsnoop:CARD=sndrpihifiberry,DEV=0
    snd_rpi_hifiberry_digi,
    Direct sample snooping device
hw:CARD=sndrpihifiberry,DEV=0
    snd_rpi_hifiberry_digi,
    Direct hardware device without any conversions
plughw:CARD=sndrpihifiberry,DEV=0
    snd_rpi_hifiberry_digi,
    Hardware device with all software conversions

pi@robbamusic:~/spotify/spotify-connect-web $  amixer controls
numid=1,iface=MIXER,name='Tx Source'

~/spotify/spotify-connect-web $ sudo vim /etc/asound.conf

pcm.!default  {
 type hw card 0
}
ctl.!default {
 type hw card 0
}

Jun 24 15:18:05 robbamusic spotify-connect.sh[21410]: Loading Spotify library...
Jun 24 15:18:05 robbamusic spotify-connect.sh[21410]: Last.fm: incomplete credentials, not launched
Jun 24 15:18:05 robbamusic spotify-connect.sh[21410]: Traceback (most recent call last):
Jun 24 15:18:05 robbamusic spotify-connect.sh[21410]:   File "main.py", line 16, in <module>
Jun 24 15:18:05 robbamusic spotify-connect.sh[21410]:     from connect import Connect
Jun 24 15:18:05 robbamusic spotify-connect.sh[21410]:   File "/home/pi/spotify/spotify-connect-web/connect.py", line 9, in <module>
Jun 24 15:18:05 robbamusic spotify-connect.sh[21410]:     from console_callbacks import audio_arg_parser, mixer, error_callback, connection_callbacks, debug_callbacks, playback_callbacks, playback_setup
Jun 24 15:18:05 robbamusic spotify-connect.sh[21410]:   File "/home/pi/spotify/spotify-connect-web/console_callbacks.py", line 105, in <module>
Jun 24 15:18:05 robbamusic spotify-connect.sh[21410]:     mixer = alsa.Mixer(args.mixer, **mixer_card_arg)
Jun 24 15:18:05 robbamusic spotify-connect.sh[21410]: alsaaudio.ALSAAudioError: Unable to find mixer control Master,0 [default]

hi,
i got it working finally. with hifiberry digi+ the /etc/asound.conf should be:
pcm.softvol {
  type softvol
  slave {
    pcm "hw:0"
  }
  control {
    name "Master"
    card 0
  }
}

Thanks for sharing a solution that worked for your system!
Yes, going from hw:1 to hw:0 is the most common scenario, depending on what the OS sees as the card numbers.
Enjoy the music!


Pong's minimal action set. I can't gain scores more than -21 using the first three ones.

I just download the code and run it.
However, after one evening's training, I can't get scores more than -21.
Is [0, 1, 3] worked?
The minimal action_set is [ 0  1  3  4 11 12].
When I included action 4, it's easier to have scores like -20 and -19 in the beginning.
What goes wrong in my procedures?

Sorry to bother you.
I notice that your ale_python_interface has different settings with my former one.


FIX: Relax excessive ESLint configuration rules

Ben reports that it's difficult to work with all the extra errors reported in the component files as he does MUI conversion.
This PR partially addresses #21, updating the ESLint configuration to relax rules that the new prettier/prettier ruleset (which is now a superset prettier/react) introduced. ESLint now has more recommendations than in 2018.
ESLINTRC TEST

instead of pulling the branch, go to https://github.com/theRAPTLab/meme-2023/blob/dev-sri/build-config-fixes/.eslintrc.js to grab the .eslintrc.js file
in your current working repo, paste the .eslintrc.js file next to where your .eslintrc.json file is
rename .eslintrc.json to old-eslintrc.json
quit visual studio code, then reopen
report if the eslintrc flagging looks any better than before
look at the output for ESLintrc and see if there are errors.

NOTE: ESLint only checks on open files, so you'll have to click around to see.
OTHER CHANGES
This PR also includes updates to .vscode folder default snippets and settings, affecting FormatOnSave settings using a more "global" approach and removing the LiveShare extension as a recommended extension

GitHub defaulted to wrong base branch.


Print loaded mods into logs

Should help with debugging, in particular ensuring that no extra mod was loaded while looking for a bug.

Pretty sure this already exists in modmanager.cpp
https://github.com/R2Northstar/NorthstarLauncher/blob/286cea5f6280e568f5cb4c953d93993c98625ce4/NorthstarDedicatedTest/modmanager.cpp#L295-L306


refactor(userspace/falco): reduce app actions dependency on app state and inspector

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
This PR removes the need of accessing the app state inspector for some actions. They now create an inspector on-the-fly if needed.
Accordingly, the action order has been updated depending on their app state dependencies. Now, actions that do not need a given loading/initialization step are moved before it. For instance, this fixed the --list-syscall-events command which does not really require a configuration file loaded, but until now failed if no -c was specified.
Which issue(s) this PR fixes:
Special notes for your reviewer:
This supported the work of https://github.com/falcosecurity/falco/issues/2074, for which reducing the internal dependencies on the single app state inspector is crucial in order to start managing more than one.
Does this PR introduce a user-facing change?:
refactor(userspace/falco): reduce app actions dependency on app state and inspector

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: c70c88d2161936935f381d5d936c86278be3c090

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


GEOMESA-1573 Implement test framework for GeoMesa SparkSQL support.

Signed-off-by: Matthew Zimmerman<EMAIL_ADDRESS>

This PR is replaced by: https://github.com/locationtech/geomesa/pull/1276


Allows for custom Http Client builders

Allows the ability to provide a customer http client builder.

@marcingrzejszczak I have made the OK Http client changes as well, let me know what you think.

LGTM created an issue in Sleuth - https://github.com/spring-cloud/spring-cloud-sleuth/issues/845


Extend keptn CLI to support different platforms for keptn install

The installer pod will get a new environment variable 'PLATFORM' that specifies the target K8s cluster where keptn should be installed:
- name: PLATFORM
  value: PLATFORM

The supported values are: aks, eks, ocp, gke, pks
The keptn cli should be extended by an additional parameter that specifies the target platform for installing keptn, for example: keptn install --platform=pks
Based on the parameter, the keptn cli sets the environment variable PLATFORM for the installer pod.

PKS and AKS are missing in the CLI and the installer. Others are done.

Implement the missing platforms with #3 and #5 - closing.


Newer, Friendlier README and CONTRIBUTING

⚠  Work in Progress ⚠
This pull request is a follow up to #415 and will strive to create a friendly README and CONTRIBUTING experience.
If you are reading this, what's missing? How can we make the process of customizing, building, and contributing to these materials less intimidating?
@github/services-training

@crichID I think this looks great! I would just add @brntbeer's suggestion:

What about starting a PR to even be able to talk about something more concrete when wanting to make something better?

@crichID What are your thoughts on including badges at the top of the Readme, similar to those found on Atom?

I like it because if we decide to add a Slack channel then we can also include that badge. Also, badges are fairly consistent in the Open Source community, and it would be cool to be an exemplary repository in every nuance that we can.
Also, this isn't a blocker for now, but this might be a ✨ place for a banner based on the title card that @loranallensmith is in the process of designing for our videos (brand strengthening!) 😄
Here's the link to our Travis build if yes (I'm also happy to commit this in):
https://travis-ci.org/github/training-kit.svg?branch=master

@hollenberry I like the Travis badge so 👍  from me 😄

Here's the link to our Travis build if yes (I'm also happy to commit this in):

@hollenberry I may only speak for myself, but from what I understand, please feel free to go ahead and make these types of commits (both now and in the future) and if there is opposition to it, we can always remove it later. As hubot would say, you are trusted. 🤖

Update:

I created a Heroku server for Slack invitations, as well as a Slack group. This process was super easy (though misconceptions on my end made this a massive time-wasting endeavor), and I'd ❤ if a few of you can test this by joining the channel via the button instead of a direct invite.
I spent a little while attempting to add this badge :  , but for our server

Spoiler alert: It doesn't work. We need a package.json file to list our dependencies. Currently, that file appears to be a bower.json file.

I added an image. ✨ to @loranallensmith

Woohoo! Slack channel button works!
@hollenberry Not a criticism, just a general thought: Do we want to maintain both a Gitter community and a Slack community, or does it make sense to keep the chat to the same service?

Do we want to maintain both a Gitter community and a Slack community, or does it make sense to keep the chat to the same service?

The original reasoning behind Gitter was to reduce the number of accounts needed by someone to join, and the integration with :octocat: where we can easily link to issues/PRs, and the support of Markdown. In either case, if we start using Slack I don't think it makes sense to keep both chat services and we should then stop using Gitter.

@github/services-training based on #430 I thought it might be a good idea to go ahead and :ship: this. I removed the chat link while we decide whether to stick with Gitter or switch to Slack. I also reduced the scope of this PR to the README since the CONTRIBUTING guide still needs some :heart:! Please feel free to open a new PR if you see additional changes we need to make.


Default plan should be Basic and not Standard

When creating a database using the Data-Tier application wizard the new database gets the Standard General Purpose plan ...
I think it should be the Basic plan or at least give the option to choose the plan.
A few times I ended up with extra costs with staging databases just because I forgot to go to Azure portal and change the plane from Standard to Basic.

closing as duplicate of #10301


MkdirFunc fails the build if something else create the directory underneath it

This issue was originally created at: 2011-09-02 09:45:41.
This issue was reported by: estanchev.
estanchev said at 2011-09-02 09:45:41

When scons tries to create a component of a path, it fails with "File Exists"
error, if another process creates the directory in the meantime.
In SCons/Node/FS.py, in the _create method:

SCons.Node.Node.build(dirnode) calls MkdirFunc.
If MkdirFunc raises an OSError, it is catched by scons, packed as a
BuildError and then that is raised, to fail the build.
Thus, the try: except: code around that code is useless.

estanchev said at 2011-09-02 09:46:11

Created an attachment (id=868)
This is the proposed patch.

thosrtanner said at 2013-12-11 09:21:23

Just a thought - this could still throw an error if some other process creates
the directory between the 'if not exists' test you added and the following mkdir.

Votes for this issue: 1.
estanchev attached MkdirFunc-existing-directory-bug.patch at 2011-09-02 09:46:11.

This is the proposed patch.

I'm ok with the build failing if another process is changing the directory structure under my feet. The directory created by another process may have incorrect permissions, for example.
I suggest closing as "won't fix".

I'm ok with the build failing if another process is changing the directory structure under my feet. The directory created by another process may have incorrect permissions, for example.
I suggest closing as "won't fix".

It's not that another process is changing the directory structure, it's that another thread is creating the directory too. So if two threads call MkdirFunc at about the same time, the code races and fails.
What is the correct behavior here? Are both actions supposed to set the Dir as a side effect? Do normal compile/link builders already set their output directory as a side effect?

I'm ok with the build failing if another process is changing the directory structure under my feet. The directory created by another process may have incorrect permissions, for example.
I suggest closing as "won't fix".

It's not that another process is changing the directory structure, it's that another thread is creating the directory too. So if two threads call MkdirFunc at about the same time, the code races and fails.
What is the correct behavior here? Are both actions supposed to set the Dir as a side effect? Do normal compile/link builders already set their output directory as a side effect?

That's a different issue than this one, so likely bring it to users mailing list or discord.  That shouldn't be happening.

If there's a chance MkdirFunc can be called by multiple threads, then the existing code certainly isn't safe - a window between the check and the os.mkdir will always be there.  Can that happen?   The code in the first bit of the patch at least improves on that.


Add optional k_neighbors input parameter to PerplexityBasedNN

Currently PerplexityBasedNN uses the standard heuristic
k_neighbors = min(self.n_samples - 1, int(3 * self.perplexity))

What do you think about adding an input parameter k_neighbors='auto'. The default 'auto' would use the current behaviour. But e.g. if perplexity=30, k_neighbors=40, then that's going to be used as is. Or also perplexity=30, k_neighbors=200.
This came up in a project I am doing with a rotation MSc student, so I was wondering if it would make sense to allow this flexibility to PerplexityBasedNN. I think it'd be nice because currently 3 in 3 * self.perplexity is a hard-coded constant which is not great.

I have thought about this in the context of scanpy, where this behaviour might be desirable, but it's not really clear to me how this would play with calculating the Gaussian kernel widths. Intuitively, I don't think it should really affect them much, because the perplexity of the distribution can be calculated on any number of samples. I would assume that just the accuracy would suffer if we used too few samples i.e. the kernel bandwidths might be estimated incorrectly. Not that I think this would be problematic, since the uniform kernel works just as well.
I think this is something we will have to add to accomodate the scanpy use-case, but we'll have to figure out what parameter value combinations are reasonable. 3*k is hard-coded because it makes sense. Neighbors further than the 3*k nearest neighbors will be assigned a practically zero value, so parameter combinations like perplexity=30, k=500 should be heavily discouraged. On the other hand, running something like perplexity=500, k=30 would make no sense and would lead to incorrect results.
Off the top of my head, something like
if k > 3 * perplexity:
    warn
elif k < perplexity * 2:
    error or at least warn

I have thought about this in the context of scanpy, where this behaviour might be desirable, but it's not really clear to me how this would play with calculating the Gaussian kernel widths. Intuitively, I don't think it should really affect them much, because the perplexity of the distribution can be calculated on any number of samples. I would assume that just the accuracy would suffer if we used too few samples i.e. the kernel bandwidths might be estimated incorrectly. Not that I think this would be problematic, since the uniform kernel works just as well.
I think this is something we will have to add to accomodate the scanpy use-case, but we'll have to figure out what parameter value combinations are reasonable. 3*k is hard-coded because it makes sense. Neighbors further than the 3*k nearest neighbors will be assigned a practically zero value, so parameter combinations like perplexity=30, k=500 should be heavily discouraged. On the other hand, running something like perplexity=500, k=30 would make no sense and would lead to incorrect results.
Off the top of my head, something like
if k > 3 * perplexity:
    warn
elif k < perplexity * 2:
    error or at least warn

It's mathematically impossible to obtain perplexity larger than the number of neighbors. Uniform kernel yields maximum perplexity, and that's equal to the number of neighbors. So if k > perplexity, there should be an error. We can give a warning if k > 3 * perplexity, why not.

It's mathematically impossible to obtain perplexity larger than the number of neighbors. Uniform kernel yields maximum perplexity, and that's equal to the number of neighbors. So if k > perplexity, there should be an error. We can give a warning if k > 3 * perplexity, why not.

Hmm, you're right, but I don't really understand why. I've played around with this a little, and, as you said, the moment k < perplexity, the bandwidths become basically zero. What's the intuition behind this?
But, basically, yes, that would definitely warrant an error!

I think the Gaussian variance sigma should go to infinity in this limit, not to zero.
It's because the uniform distribution has the max entropy among discrete distributions with the same support. Hence it has the max perplexity. And the perplexity of the uniform distribution defined on k objects is k.


Add aria address support

I have deployed the aria project, and it is connected via https. There seems to be no way to connect via https

I can't understand what you're trying to do. If you want to connect to aria2 directly, edit aria.sh and change --rpc-listen-all to true.

I'm sorry I'm Chinese to English. I mean, my aria address is https domain name, not ip address. For example :https://example.com, instead of the default: localhost. So can this bot customize aria's connection address


Add GDScript resource export.

Adds support for GDScript to be able to export user-defined resource types.
Related Issues:

godotengine/godot-proposals#18

Related PRs:

#48201

implements the GDScript component

Sibling PRs:

#62413
#62417

Considerations:

Not yet tested with non-GDScript languages (as I have yet to port my old PR's logic by which to do so).

@PoisonousGame Was this an experiment you performed using an arbitrary master build + this PR, or did you conduct the experiment using all of the commits present in #48201? This PR includes ONLY the changes related to the GDScript programming language necessary for it to expose the relevant information. It does not implement any of the Editor integrations such as the Inspector or the QuickLoad / QuickOpen popups.

If you were attempting to test out just this pull request, then the way to do that would more or less be to confirm whether the GDScript compiler gave you some sort of error when attempting to export a user-defined resource type (whether through static typing or not). I'm not really sure you tested this out correctly.

@vnen I was just getting C# working and made an attempt to export C# types in a GDScript property when I ran into some trouble. I have no way to export a global C# resource property from a GDScript node or resource. I would like clarification on which syntax below should be used. Neither of them are currently supported.

There is no way to have a dynamically typed variable that supports exporting resources, of any kind. So this legacy syntax that used to work in 3.x does not work now.
class_name MyNode
extends Node

# Godot used to let you have a dynamically typed variable
# that would be presented in the Inspector as a global script class resource.
# You could still assign alternative values within the script though, because it has no dynamic type.
@export("MyResource") var my_data

There is no way to statically export global script classes that are not GDScript types. This is because during GDScriptAnalyzer::resolve_datatype(), it detects that the variable is using a global script class, but it then parses that file as a GDScript even if it doesn't have a .gd file extension. It then gets a parse failed error during get_parser_for() and raise_status(), resulting in push_error(vformat(R"(Could not parse global class "%s" from "%s".)", ....); So, the following use case is not allowed either:
class_name MyNode
extends Node

# `CSData` would be some C# resource global script class.
@export var cs_data: CSData = null

I have made an update to this branch that allows GDScript to use global script classes from other languages (NOT GDScript) for static typing. So you should now be able to add a scripting language using GDExtension or add global script classes to VisualScript, and then use those global script classes as static type hints. Then the GDScript language will accurately perform static type checks, provide autocompletion/intellisense, etc.

Is this going to make it intp 4.0?

@Zireael07 Yeah, it should, from what I've heard. There are just some hangups that have to get resolved before it and the sibling PRs can be merged.

@willnationsdev Thanks hugely for the work in this area. We wanted to discuss and implement a cleaner API for you to rely on that would allow better information retrieval regarding to global classes, which is why we did not want to merge this right away.
Unfortunately, we did not have the time and resources to work on this, and given the demand there is for this feature, and given these PRs are already very good, it will do as-is and we can discuss cleaning up the global class registration in 4.1.
Again, thanks for working on this and apologies for the delay in getting this merged, but circumstances beyond our control made properly reviewing and merging this difficult.

Tested this PR together with #62413, it seems to work well!
One needs to reload the project after defining a new custom resource with class_name but AFAIK that's been the problem with class_name from the beginning.
@export var some_res: MyCustomRes

works fine to export it from GDScript.
It's properly filtered in the Inspector, with multi-level inheritance taken into account (MyCustomSubRes extends MyCustomRes):

Drag and drop of saved custom resources works from the FileSystem dock:

I didn't test #62417 for now because it looks way hackier and far reaching into core internals and multiple editor components. We do want it to work in the QuickOpen eventually but I suggest focusing on getting #62411 and #62413 merged first, which IMO implement the missing feature in a quite satisfactory way already.

@akien-mga

One needs to reload the project after defining a new custom resource with class_name but AFAIK that's been the problem with class_name from the beginning.

Was it? I didn't think that was the case, even in Godot 3.x. Either way, that was already an issue in 4.0 before I implemented all of my stuff. I'm not entirely sure why it's happening, but I haven't yet had time to diagnose the cause. Perhaps something related to EditorData caching information about script class inheritance.

Was it? I didn't think that was the case, even in Godot 3.x.

Yes, there are some things that don't update without an editor restart, so we kind of roll with it for now.

I've made the requested adjustments. Should be good to go for merge at this point afaik.

Thanks a ton for your work and your patience with this series of PRs - you've officially solved the most upvoted Godot proposal ever :tada:


conda install --yes --file requirements.txt  Failed

Solving environment: failed
PackagesNotFoundError: The following packages are not available from current channels:

line-profiler==2.1.2
jupyter-console==5.2.0
ptyprocess==0.5.2
appnope==0.1.0
ipython-genutils==0.2.0
jupyter-core==4.4.0
prompt-toolkit==1.0.15
jupyter-client==5.2.3

Due to the way packages are made available in conda the available versions are not guaranteed to be the same.
I'll unpin the requirements file.

so, how do I install all the packages needed for this BLU?

Pull the changes, repeat.

yes, worked fine! (with conda install line_profiler)
will be many more, to import like this?

About 5, if I remember correctly.
But basically the idea is, every time you have an "ImportError: No module named XXX", just go and conda install it :)

Closing due to inactivity


Add version number in init.py, new PR

This is the new PR to add version number in __init__.py
I saw it from the umap package https://github.com/lmcinnes/umap/tree/master/umap
What do you think ?
I tried and it seemed to solve the problem in the previous PR (#108). Plus it is in line with @terrytangyuan comment https://github.com/metric-learn/metric-learn/pull/108#pullrequestreview-144001908

Here is another proposal, which puts the version in a _version.py file.
Another possibility would be to put it in a non Python file, do the same by reading the file, and adding the file to a MANIFEST.in (see https://docs.python.org/2/distutils/sourcedist.html#the-manifest-in-template)

This works well enough, so I merged it as-is. If we want something fancier later, we can change it.


The turorial does not work with hana_trial account

Hi, when I try this on my hanatrial account only with
@Schema: 'd022276'
I can create a table. otherwise I get the error:
Error while activating /d022276trial/d022276/tutorial/first_table.hdbdd:
[d022276trial.d022276.tutorial:first_table.hdbdd] Could not generate CDS artifact "d022276trial.d022276.tutorial::first_table.Book" to schema "d022276" because index server configuration switch "view_activation_for_hcp" is set. In this mode only generation to schema "_SYS_BIC" is allowed.
Hence I change it to  @Schema: 'd022276'.
When I try now to import data I get the error:
Error while activating /d022276trial/d022276/tutorial/mydata_import.hdbti:
[d022276trial.d022276.tutorial:mydata_import.hdbti] Schema could not be resolved for public synonym. Check that the target table exists.
Is there a tutorial available on how to do this on hanatrial.
Best regards
Eckard.

More issues. I continue without adding data to the table but when trying to add roles I now get the issue:
[12:24:10] Missing privileges for Uri: /sap/hana/xs/dt/base/OData/CatalogAndRepositoryRoles.xsodata/CatalogAndRepositoryRoles?$top=1000&$orderby=length(NAME)%20asc&$filter=MODE%20eq%20%27DT%27

Did you create a HANA MDC or a HANA XS Shared instance?

Hi Craig,
That bug was with the HANA xs version. The issue was with the different schemas.
Best regards
Eckard.
From: Craig Cmehil<EMAIL_ADDRESS>Sent: Freitag, 29. April 2016 07:03
To: SAPDocuments/Tutorials<EMAIL_ADDRESS>Cc: eckard gehrke<EMAIL_ADDRESS>State change<EMAIL_ADDRESS>Subject: Re: [SAPDocuments/Tutorials] The turorial does not work with hana_trial account (#184)
Did you create a HANA MDC or a HANA XS Shared instance?
—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHubhttps://github.com/SAPDocuments/Tutorials/issues/184#issuecomment-215627354


[Request] libre-speed-cli

Package Request
Criteria
For a package to be acceptable in the Main bucket, it should be:

[x] a non-GUI tool
[ ] a reasonably well-known and widely used developer tool (e.g. if it's a GitHub project, it should have at least 500 stars and 150 forks)
[x] the latest stable version of the program
[x] the full version i.e. not a trial version
[x] a fairly standard install (e.g. uses a version-specific download URL, no elaborate pre/post install scripts)

Information
Name: [name of new package]
libre-speed-cli
Description: [clear and concise details of what it is]
Command line client for librespeed.org
Homepage: [a URL/link]
https://github.com/librespeed/speedtest-cli
Download link(s): [URL(s)/link(s)]
https://github.com/librespeed/speedtest-cli/releases/download/v1.0.9/librespeed-cli_1.0.9_windows_amd64.zip
https://github.com/librespeed/speedtest-cli/releases/download/v1.0.9/librespeed-cli_1.0.9_windows_386.zip
Some indication of popularity/repute: [GitHub stars/software reviews etc.]
https://alternativeto.net/software/librespeed-cli/about/
https://github.com/librespeed/speedtest-cli

But doesn't the extras bucket require a package to have a GUI at least?

It's just anything that doesn't fit the requirements for Main - there's no requirement for a GUI.


Changed imports in API and GET helper modules and moved imaging to another module

Rejected due to Merge Errors


Getting SSL connection options through to request

We're having trouble figuring out how to get SSL options (such as described here: https://github.com/request/request#tlsssl-protocol) through to the request module. Basically we've got an SSL port on our WebHDFS service with a self-signed cert and we'd like to be able to provide the CA certificate or turn of authorization (like NODE_TLS_REJECT_UNAUTHORIZED=0, but not global).
I've tried adding the following to both the createClient call and in the third argument of the createWriteStream call, where ca is our root certificate:
ca: ca, rejectUnauthorized: false, agentOptions: { ca: ca, rejectUnauthorized: false }

But nothing seems to work. Is there something I'm missing?

Hey Ian!
Currently this module doesn't support request options overriding. Although it could be nice idea provide some extra options when creating a new client instance.


Studio: project listing of studios has broken links

Reported by @annakristinkaufmann today.
In 1.8.0-M4, the links to studios in the project page are broken.
PR already available: https://github.com/BlueBrain/nexus-web/pull/1133

This issue does not seem to be resolved. Original screen recording from Anna:
https://user-images.githubusercontent.com/12729291/179964293-1bcbe615-c32b-4082-8040-f5dfc4545e57.mov
seems you have to go to "Admin" -> "neurosciencegraph" -> "datamodels" and click on "Studio" and then on "Knowledge Graph Ontologies and schemas" (as shown in the recording).
User: adietz
Versions:
Nexus Delta v1.8.0-M2
Nexus Fusion 1.8.0-M6

This issue seems to have been fixed in stage.


New version: LibSerialPort v0.4.0

Registering package: LibSerialPort
Repository: https://github.com/JuliaIO/LibSerialPort.jl
Created by: @ianshmean
Version: v0.4.0
Commit: f05a87ba458218378078e6d4c63279750ff135d4
Reviewed by: @ianshmean
Reference: https://github.com/JuliaIO/LibSerialPort.jl/commit/f05a87ba458218378078e6d4c63279750ff135d4#commitcomment-36166671

Block. Discussion ongoing

@ianshmean What the status of this? Do you want it to be merged? Or do you want it to be closed?
[noblock]

I'd close it for now. We haven't resolved the issue behind stalling it. Thanks


:feet: Support LUKS keys for cold migrations from vSphere

Ref: https://github.com/kubev2v/forklift/issues/567
Add LUKS key to the vm
This patch adds the LUKS keys to the VM specs using a secret ref.
UI:
add a multi select action for vms list of a new plan -
set encription keys:
a. create a secret with keys, owned by the plan
b. add/replace the secret reference in the multi selected vm[s]

@liranr23 hi, can you add more context ?

Sure.
On the plan, we have the VM list. In each VM we will be able to add luks secret ref. We require only the name of the secret.
e.g:
spec:
  archived: false
  map:
    network:
      apiVersion: forklift.konveyor.io/v1beta1
      kind: NetworkMap
      name: liran-luks-6zjsc
      namespace: openshift-mtv
    storage:
      apiVersion: forklift.konveyor.io/v1beta1
      kind: StorageMap
      name: liran-luks-xktfn
      namespace: openshift-mtv
  provider:
    destination:
      apiVersion: forklift.konveyor.io/v1beta1
      kind: Provider
      name: host
      namespace: openshift-mtv
      uid: uuid
    source:
      apiVersion: forklift.konveyor.io/v1beta1
      kind: Provider
      name: vsphere-provider
      namespace: openshift-mtv
      uid: uuid
  targetNamespace: default
  vms:
    - id: vm-23738
      luks:
        name: test
      name: liran

So we have a VM where the LUKS secret is named test
The test secret should exist on the plan's namespace.
kind: Secret
apiVersion: v1
metadata:
  name: test
  namespace: <plan namespace>
data:
  '1': d2FsbGE=
  '2': cXVtNADdA==
type: Opaque

The keys of the secret doesn't matter, the value are LUKS passphrases.
It should be owned by the plan. as you wrote.
As for CLI, the user may create secret per VM, for UI to ease on mass migrations, the idea is to execute it as we do for hooks. A single input to use for the plan.
My general idea was to have some kind of:
LUKS keys:
Then some + sign or something to add multiple keys (with - to remove any of them). Or a text box that each new line is a new value to the secret.
The LUKS feature is currently only for vSphere type providers.
Let me know if anything else needed.

addressedf by #1197


Auto detect balance

Implement auto detect balance

[x] Detect balance of Substrate Account (Subscan)
[ ] Detect balance of some EVM network (Birdeye API)
[ ] Auto disable unused token on EVM networks that can detect balance
[ ] Create popup ask to enable networks when detect balance (need more discussion)

Auto-detect balance steps:

Fetching chain slug balance map from online
Fetching multi-chain balance of account
Mapping chain and token
Enable chain and token

Test case:
manta_network: balanceChainSlug = manta
Step:

Update balanceChainSlug on extra info of chain info
Save and deploy dev
Re check with attaching read-only account

Version test: http://<IP_ADDRESS>:8900/s/PaXgFFBLzicWYaW

[ ] Do not show balance for local token when attach account
Actual: Show loading, after switch account -> show balance

Expect: Show balance

Version test: http://<IP_ADDRESS>:8900/s/X87DSmWHBXtJkfo
Validation passed.

Install
Upgrade version
Detect balance
Turn off network


Event handlers don't get updated when replacing a visually identical element

I haven't created a test case for this yet, but I'm pretty sure my theory as to what's happening holds water. What I'm seeing is that when I have a table with identically looking buttons on every row, and a row gets deleted, the onclick handler for the deleted row remains active. I've come to this conclusion because every button's onclick handler is associated with an ID. When I remove a row and click the button on the row that replaces it, the onclick handler has the ID associated with the deleted row.

I think it's the copier method in yo-yo not accounting for reordering of sibling nodes that's causing the issue

Thanks Yosh, will try to come up with a PR ❤

:D
On Thu, Dec 8, 2016 at 4:35 PM Arve Knudsen<EMAIL_ADDRESS>wrote:

Thanks Yosh, will try to come up with a PR ❤
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/yoshuawuyts/choo/issues/349#issuecomment-265769748,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWlelrfIfPpscfDx6zqer3PyK1MdgAPks5rGCOvgaJpZM4LHHCO
.

As discussed on IRC, I found out that this is due to hyperscript registering event handlers via addEventListener, which doesn't mesh with yo-yo, for which you need to register event handlers via element attributes, e.g. onclick.

I think we can close this now right? - found the error. Maybe we should add
a comment in the readme?
On Wed, Dec 7, 2016 at 10:08 PM Arve Knudsen<EMAIL_ADDRESS>wrote:

I haven't created a test case for this yet, but I'm pretty sure my theory
as to what's happening holds water. What I'm seeing is that when I have a
table with identically looking buttons on every row, and a row gets
deleted, the onclick handler for the deleted row remains active. I've
come to this conclusion because every button's onclick handler is
associated with an ID. When I remove a row and click the button on the row
that replaces it, the onclick handler has the ID associated with the
deleted row.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/yoshuawuyts/choo/issues/349, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWlemBdBQvQh8x9Ucb75R5N17rdf6DAks5rFyBggaJpZM4LHHCO
.

@yoshuawuyts Yeah, would be cool to document. I already closed it though.


respectful code cleanup

Closes https://github.com/GoogleCloudPlatform/inspec-gcp-pci-profile/issues/38
/gcbrun

Shouldn't this be, 'ensure an allowed list￼ ... '

Right now the sentence isn't a sentence :-)￼

I considered "allowlist" a proper noun :) is it not?
... in any case it should be "an allow..."


[UPDATE] Create or Import Vault Screen

To get rid of one screen, we want to update the create a vault or import a vault screen.
Please only display this view on the first onboarding according to figma flow:

afterwards prompt this screen:

If user wants to create a second or further vaults let them go over vault select screen select it directly over the updated setup screen , (please also update buttons on this view) :

This will make it possible to get rid of one screen and improving user experience.

@vultisig/android forgive the double work.
We changed the onboarding some more to include fast vaults completly. see issue #964. Please update these pages again in the referenced issue. Thank you!


Fix webview in 5. ( lollipop) crash

-Fix WebViewYouTubePlayer crash on Android 5
(https://stackoverflow.com/questions/41025200/android-view-inflateexception-error-inflating-class-android-webkit-webview/41721789#41721789).

I also tryed to downgrade appcompat version but it still not work on my 5. device.and this solution work well for all.

Hey, thanks for the pull request but this solution looks a bit hacky. And it's not good practice to implement hacky solutions in a library used by many people.


[$500] Web - User get redirected to NewDot Expensify when logging in from OldDot Expensify

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.3.99-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:

Navigate to NewDot Expensify
Log in with any account
Navigate to OldDot Expensify
Log in with a different existing account

Expected Result:
User should be logged in and OldDot Expensify Inbox page should be displayed.
Actual Result:
User is logged in but gets redirected to NewDot Expensify.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/115492554/dd7dcc56-e002-4346-96eb-3e4890ac4c8b

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d6fee6bfbbf208c5
Upwork Job ID:<PHONE_NUMBER>215972864
Last Price Increase: 2023-11-15

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

This is our only/last blocker today, so I'm going to see if I can take care of it and then deploy

Pretty sure this is expected behavior for new logins now – big change we made this week to push new customers into NewDot

ok, per this message this is forsure expected behavior, starting today. It's also an OldDot change, not a NewDot one, so not a NewDot deploy blocker, and indeed not a bug at all

No payments due


Captured image are looks are different Image rendering issue

Which version of PhantomJS are you using? Tip: run phantomjs --version.
PhantomJS  - 2.1.1
Python - 2.7
selenium - 3.0

What steps will reproduce the problem?
I was capture url :"http://www.bjs.com/office.category.3000000000000116959.2000134" thru tool of "python + selenium + phantoms" .
Captured image are looks are different, like product parts are in vertical manner .

Which operating system are you using?
Ubuntu 16.04

Render thru Google Chrome :

I also met the same problem, can you solve it?

I also met the same problem, can you solve it?


VNC

Once I disconnect from VNC. I can't connect anymore!
I have to remove and recreate the container to get 1 vnc connection

To fix this, x11vnc should be started with -forever


Harlequin fails to start with theme-related error message

Describe the bug

Harlequin fails to start with theme-related error message:
Traceback (most recent call last):
  File "/nix/store/dvaw51k5c8jy6znnhmv134b7l3bgvqkr-harlequin-1.25.2/bin/.harlequin-wrapped", line 9, in <module>
    sys.exit(harlequin())
             ^^^^^^^^^^^
  File "/nix/store/dvaw51k5c8jy6znnhmv134b7l3bgvqkr-harlequin-1.25.2/lib/python3.12/site-packages/harlequin/cli.py", line 414, in harlequin
    cli()
  File "/nix/store/9l7cdymnw9ck7l7hk1d7n6yc2ql3a0j0-python3.12-click-8.1.7/lib/python3.12/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/5l86rgi0bh4qsq9nx02yry49lmqdclb0-python3.12-rich-click-1.8.4/lib/python3.12/site-packages/rich_click/rich_command.py", line 152, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/nix/store/9l7cdymnw9ck7l7hk1d7n6yc2ql3a0j0-python3.12-click-8.1.7/lib/python3.12/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/9l7cdymnw9ck7l7hk1d7n6yc2ql3a0j0-python3.12-click-8.1.7/lib/python3.12/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/9l7cdymnw9ck7l7hk1d7n6yc2ql3a0j0-python3.12-click-8.1.7/lib/python3.12/site-packages/click/decorators.py", line 33, in new_func
    return f(get_current_context(), *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/dvaw51k5c8jy6znnhmv134b7l3bgvqkr-harlequin-1.25.2/lib/python3.12/site-packages/harlequin/cli.py", line 371, in inner_cli
    tui = Harlequin(
          ^^^^^^^^^^
  File "/nix/store/dvaw51k5c8jy6znnhmv134b7l3bgvqkr-harlequin-1.25.2/lib/python3.12/site-packages/harlequin/app.py", line 206, in __init__
    self.theme = theme
    ^^^^^^^^^^
  File "/nix/store/hz7m3hlp8m2drds2m45za58vzk5pqi4y-python3.12-textual-0.86.1/lib/python3.12/site-packages/textual/reactive.py", line 336, in __set__
    self._set(obj, value)
  File "/nix/store/hz7m3hlp8m2drds2m45za58vzk5pqi4y-python3.12-textual-0.86.1/lib/python3.12/site-packages/textual/reactive.py", line 307, in _set
    value = private_validate_function(value)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/hz7m3hlp8m2drds2m45za58vzk5pqi4y-python3.12-textual-0.86.1/lib/python3.12/site-packages/textual/app.py", line 1249, in _validate_theme
    raise InvalidThemeError(message)
textual.app.InvalidThemeError: Theme 'harlequin' has not been registered. Call 'App.register_theme' before setting the 'App.theme' attribute.

This also happens when using any other theme name, e.g. bw, default, lightbulb, etc. as per https://pygments.org/styles/
Steps To Reproduce
Steps to reproduce the behavior:

Launch harlequin

Expected behavior

Application launches and TUI appears, without any error message.
Notify maintainers

@pcboy

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

Curious indeed, used to work fine, I wonder when it started to break. :thinking:
I think maybe the textual dep got updated at some point, and current harlequin code is breaking with it.
Commit 9f3d02d510042068aee542cf27e66c1dc919e711 was still working fine. It's textual 0.82.0
While current harlequin on master seems to be using textual-0.86.1. Could be the reason.
It started to fail at this commit f673b779338786f6553c7118ed1703fa6072260e
You can see the pythonRelaxDeps = [ "textual" ];, if I remove it, we get:
Checking runtime dependencies for harlequin-1.25.2-py3-none-any.whl
  - textual==0.85.0 not satisfied by version 0.86.1

So seems like it's likely that harlequin is not compatible with the textual currently in master. Would likely need to be fixed upstream. A patch could also be added. I don't know much about textual. :thinking:
I use harlequin from time to time so that bother me too. I can potentially give it a deeper look next week.

I asked Harlequin's main dev, and the upgrade to 0.86 is in progress. We will have to wait before we can update (possibly will be fixed early next year). Seems like the changes are significant.
https://github.com/tconbeer/harlequin/discussions/712#discussioncomment-11566744
In the mean time, harlequin can run with:
nix run github:nixos/nixpkgs/9f3d02d510042068aee542cf27e66c1dc919e711#harlequin

In the meantime, we could also inline textual 0.82.0 for harlequin specifically. Other packages have been doing similar things in the past. Prusa Slicer comes to mind.

I assumed this was a bit frowned upon. But that's for sure better than a broken package, and as it's temporary that may be okay.
I created the PR. I have no write access though, so we will see if it gets accepted.
https://github.com/NixOS/nixpkgs/pull/365766


Make checkpoint utilities compatible with NeoX

Small changes to the DeepSpeed checkpoint utilities to make them compatible with GPT-NeoX, e.g. NeoX checkpoints lack a layer01 weight file.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Use tag in hyperf

How can I use tags in hyperf caches, similar to what we have in Laravel?

There are no plans to add this feature at the moment, but if you want, you can implement it and submit a PR. I would be happy to merge this feature into the friendsofhyperf/cache project.


Update build

Switch to standard plugin structure
Update Micronaut to 3.3.4
Update micronaut-docs to 2.0.0
Update reactor-netty and r2dbc-maria
Remove old custom plugin scripts
Switch branch to 3.4.x
Already on 2.1.0-SNAPSHOT

Previous to this, ./gradlew pAPTBR published to build/repo/r2dbc-parent/micronaut-r2dbc-bom/2.1.0-SNAPSHOT
I think this is wrong, and it should be as it is now, ie, publishing to build/repo/io/micronaut/r2dbc/micronaut-r2dbc-bom/2.1.0-SNAPSHOT
@melix can you verify I'm right?

Investigating failures

Hmmm... so flyway fails on MySql 8...  investigations continue

I think this is wrong, and it should be as it is now, ie, publishing to build/repo/io/micronaut/r2dbc/micronaut-r2dbc-bom/2.1.0-SNAPSHOT

Absolutely, good to see migrating to the new plugins fixes this!


Maybe add sanitizers-cmake?

It would be good to have various sanitizers running on the C++ tools - probably using the sanitizers-cmake would be good?.

The PR adding sanitizers support to cmake has been merged.


[API Management] Add Arg Type to Product Create Command

Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

API Management

/azp run


Make a output box in chat.dart page

I have made an input box andanswer is coming on screen but i want to make a output box so answer can be on output

Hello, I am participant of the LGMSOC. Is this issue for LGMSOC? If so I'd love to contribute

Hello I can assign you
But you can follow me in Github and readme there is video
Connect me on channel I will explain


Add release instructions

Description
Type of change
What type of changes does your code introduce to the kube-prometheus? Put an x in the box that apply.

[ ] CHANGE (fix or feature that would cause existing functionality to not work as expected)
[ ] FEATURE (non-breaking change which adds functionality)
[ ] BUGFIX (non-breaking change which fixes an issue)
[ ] ENHANCEMENT (non-breaking change which improves existing functionality)
[x] NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry
Please put a one-line changelog entry below. Later this will be copied to the changelog file.

@paulfantom I updated this PR to add release instructions as per our previous discussion. PTAL

Added CHANGELOG update to the release process.


Return early when possible

filter is expensive when not needed -- it is not lazy, so it builds an entire result array and has no early abort.
first, every, and has are much faster if they return as early as possible, especially in pathological cases like:
collect([1, 2, 2, 2, 2, ..., 2]).every(x => x === 1);

Great work @blx  🎉  Thank you


Update putfile stream

Regarding issue #58 Commit 4cb32333711255db51e0802fac0b5ddfe09da2ba

@mrapitis we are starting to follow the GitFlow Workflow, which requires feature branches to be merged into the develop branch of the main project.  This PR is attempting to be merged into master, which is supposed to only contain releases.  Here's a good picture explaining the merge process.

Please re-create this PR and request to merge into develop instead of master.


load all items in chrome but lazyload visible item in firefox on page load

Closing as this shouldn't be an issue with 4.0


Update systemd non rails worker status to started

checks systemd object and updates worker record's status accordingly
worker status is updated after SdNotify.ready from worker process
containerized workers will be handled in a follow-up PR

Ref:

https://github.com/ManageIQ/manageiq/issues/21992

@miq-bot assign @agrare
@miq-bot add_label enhancement

Just built the latest RPMs and deployed to a master appliance.  Configured kafka and manually set the rails_worker=false for the vmware event catcher.
Jan 12 11:23:57 manageiq.rb.nj.grare.com evm[5791]:  INFO -- evm: MIQ(MiqServer::WorkerManagement::Systemd#wait_for_started_workers) Waiting for the following workers to start: ManageIQ::Providers::Vmware::InfraManager::EventCatcher (1), ManageIQ::Providers::Vmware::InfraManager::OperationsWorker (1), ManageIQ::Providers::Vmware::InfraManager::RefreshWorker (1), MiqRemoteConso>
Jan 12 11:24:07 manageiq.rb.nj.grare.com evm[5791]:  INFO -- evm: MIQ(MiqServer::WorkerManagement::Systemd#wait_for_started_workers) Waiting for the following workers to start: MiqUiWorker (2), MiqWebServiceWorker (2)
Jan 12 11:24:17 manageiq.rb.nj.grare.com evm[5791]:  INFO -- evm: MIQ(MiqServer::WorkerManagement::Systemd#wait_for_started_workers) All workers have been started

Works like a charm great work @nasark