Airline and dein_log source clash

Consider the following minimal vimrc:
set nocompatible

let $DOTVIM = expand('$HOME/.config/nvim')

if has('vim_starting')
    execute 'set runtimepath+=' . expand(
                \ '$DOTVIM/bundle/repos/github.com/Shougo/dein.vim')
endif

let g:dein#enable_name_conversion = 1
if dein#load_state(expand('$DOTVIM/bundle/'))
    call dein#begin(expand('$DOTVIM/bundle/'))
    call dein#add('vim-airline/vim-airline')
    call dein#add('Shougo/dein.vim')
    call dein#add('Shougo/denite.nvim')
    call dein#end()
    call dein#save_state()
endif

function! s:dein_update()
  call dein#update()
  Denite -no-quit -mode=normal dein_log:!
endfunction
nnoremap ,bu :call <SID>dein_update()<CR>

Now as in the gif:
i) run ,bu  (notice that airline status line colors are correct)
ii) wait for the update process to complete
iii) once the update process completes check again airline colors: they are broken (i.e they were yellow and green and now they are all gray)

I don't know if this is a problem with dein, denite or vim-airline.

Actually we don't denite to reproduce this.

It is not dein.vim's issue.
Because dein.vim does not change statusline.
It seems vim-airline's issue.

So, solution: you should restart Vim after updating.

Ok. I opened https://github.com/vim-airline/vim-airline/issues/1842 in the airline repo.

The reproduce steps.
if !has('vim_starting')
  call filter(g:, "stridx(v:key, 'loaded_') != 0")
  silent! runtime! plugin/**/*.vim
else
  set rtp+=~/src/vim-airline/
endif

$ vim -Nu test.vim
:so test.vim

You can reproduce it without dein.vim.

The title is wrong.
This behavior is not crash.   Airline is disabled if dein update plugins

Thank you!

The recent commit https://github.com/vim-airline/vim-airline/commit/56197d510468f405c630a4a48b1bb207f83d14ac
fixed the Airline reload problem. However I can still reproduce the issue with the dein by using the instructions in https://github.com/Shougo/dein.vim/issues/320#issuecomment-447664229

Thank you


Fix the mapping resolution between a VM and a Run

Currently if a Cloud instance ids are not unique over the time (the id of a deleted VM can be reused for a new VM) a VM's RunUUID (and VM's attributes which comes from the Run) can have wrong value in the Virtual Machines section of the Dashboard.
Moreover, the following values can be wrong:

The Active VMs column of the Deployments section of the dashboard.
The Usages
The Metering

We found that a lot of deployments have duplicates in the VmRuntimeParameterMapping table.
Probably because the RuntimeParameter instanceid might have been set multiple time.
To prevent that and to prevent the matching to fail if somebody change the RuntimeParameter, no entry is created/updated in the table if the same pair of RunUUID and NodeInstanceName already exist.


ci user 9208457 can skip buildall on branch-2.1

Proposed changes
Issue Number: close #xxx

run buildall


Changed the version to a shields.io badge

This looks nicer and as it's rendered at view time it will always represent the current version without changing the readme

@Lakritzator your changes have been merged, thanks for your contribution 👍


Consider using the split screen with list on left and selected person on right side

The suggestion came from someone who was not an administrator watching while someone who was used the UI, and liking the latter UX better than their own.

Today (in discussion with Bowen Byers (of Joann's UX team)) we decided to not do this, and in fact, to eliminate both administrator mode and the person information page itself. Streamline and simplify!


No module named 'map_generator'

Hello,
When trying to launch your run_C.sh i'm getting No module named 'map_generator' error. How to install it?
THanks in advance.

i think it is due to the compiling via catkin_make. when compile the catkin_ws, i first compile the part with map_generator, then compile the rest of the program since the rest parts need to include the map_generator module.

Hm. I've ran catkin_make befor running run_C.sh, of course, but still... By the way, i'm using ros_noetic, if that is the case. SO what should i do? Run catkin_make again?

try multithreading. however i am not pretty sure whether this project will work under ros_noetic. i use ros_kinetic and this project is years ago. direct implementation might not be applicable. my advice is to view the code as reference to your own program.

What do you mean by "try multithreading"?
Well, if this is not directly appliable to ros noetic, i guess the only option i have is to use another PC or virutual machine...
Weird thing is, that catkin make indeed building map_generator, but maybe this is just not installing to my ros... If i've already have some packages installed to ROS, maybe i should somehow place your project in the same folder and build there? And do i need to build ORB SLAM 2 and PSPNet via ROS too?

after you successfully compile the project, there should be some head file for map_generator. thus when you compile the rest of the program, your compiler will include the head file directly. that is the key. you can first compile the program with map_generator part, then compile the rest, the rest parts already include the ORBSLAM and PSPNet.
that issue is because i build up the system step-by-step. I first wrote the map_generator part and compiled it. then after i finished the rest part then compile the whole program, the program then naturally included the map_generator.

Hm. So, i've already built catkin_ws with catkin_build. And there is a map_generator proj there. So, after that i should go into third_party and build ORB and PSPNet, yes? At least, that's what i did.
By the way, i forgot to mention that this error "no module named map generator" occurs when i launch this command from run_c.sh
gnome-terminal -x bash -c "cd Third_Part/PSPNet_Keras_tensorflow/python Semantic_Information_Publisher_C.py image:=/camera/image_raw" so, my python interpreter should somehow know about your map_generator, i suppose.

that issue might because you didnt source the setup.bash i suppose.

Hm, that might be the case... Source.bash from devel folder in catkin_ws, right? I'll try that and will get back to you.

just cd the catkin_ws folder and source ./devel/setup.bash, the it works

well, i tried to add
source /home/daddywesker/Dioram/TestingRGB/Semantic_SLAM/catkin_ws/devel/setup.bash
line to bashrc file. But, now i'm getting ModuleNotFoundError: No module named 'rospkg' This could be related to thing that I have another similar line source ~/catkin_ws/devel/setup.bash but this is another package. I guess, i need to unite them, yes?

Alright, i've installed ros into anaconda. But currently when launching
python Semantic_Information_Publisher_C.py image:=/home/daddywesker/datasets/Euroc/V2_01_easy/mav0/cam0/data/
i'm facing this
Keras model & weights found, loading...
Traceback (most recent call last):
  File "Semantic_Information_Publisher_C.py", line 76, in <module>
    tensor = Semantic_Imformation_Publisher()
  File "Semantic_Information_Publisher_C.py", line 33, in __init__
    self.pspnet = PSPNet101(nb_classes=19, input_shape=(713, 713),
  File "/home/daddywesker/Dioram/TestingRGB/Semantic_SLAM/Third_Part/PSPNet_Keras_tensorflow/pspnet.py", line 143, in __init__
    PSPNet.__init__(self, nb_classes=nb_classes, resnet_layers=101,
  File "/home/daddywesker/Dioram/TestingRGB/Semantic_SLAM/Third_Part/PSPNet_Keras_tensorflow/pspnet.py", line 34, in __init__
    self.model = model_from_json(file_handle.read())
  File "/home/daddywesker/anaconda3/envs/tf/lib/python3.8/site-packages/tensorflow/python/keras/saving/model_config.py", line 131, in model_from_json
    return deserialize(config, custom_objects=custom_objects)
  File "/home/daddywesker/anaconda3/envs/tf/lib/python3.8/site-packages/tensorflow/python/keras/layers/serialization.py", line 173, in deserialize
    return generic_utils.deserialize_keras_object(
  File "/home/daddywesker/anaconda3/envs/tf/lib/python3.8/site-packages/tensorflow/python/keras/utils/generic_utils.py", line 354, in deserialize_keras_object
    return cls.from_config(
  File "/home/daddywesker/anaconda3/envs/tf/lib/python3.8/site-packages/tensorflow/python/keras/engine/training.py", line 2261, in from_config
    return functional.Functional.from_config(
  File "/home/daddywesker/anaconda3/envs/tf/lib/python3.8/site-packages/tensorflow/python/keras/engine/functional.py", line 668, in from_config
    input_tensors, output_tensors, created_layers = reconstruct_from_config(
  File "/home/daddywesker/anaconda3/envs/tf/lib/python3.8/site-packages/tensorflow/python/keras/engine/functional.py", line 1275, in reconstruct_from_config
    process_layer(layer_data)
  File "/home/daddywesker/anaconda3/envs/tf/lib/python3.8/site-packages/tensorflow/python/keras/engine/functional.py", line 1257, in process_layer
    layer = deserialize_layer(layer_data, custom_objects=custom_objects)
  File "/home/daddywesker/anaconda3/envs/tf/lib/python3.8/site-packages/tensorflow/python/keras/layers/serialization.py", line 173, in deserialize
    return generic_utils.deserialize_keras_object(
  File "/home/daddywesker/anaconda3/envs/tf/lib/python3.8/site-packages/tensorflow/python/keras/utils/generic_utils.py", line 354, in deserialize_keras_object
    return cls.from_config(
  File "/home/daddywesker/anaconda3/envs/tf/lib/python3.8/site-packages/tensorflow/python/keras/layers/core.py", line 1019, in from_config
    function = cls._parse_function_from_config(
  File "/home/daddywesker/anaconda3/envs/tf/lib/python3.8/site-packages/tensorflow/python/keras/layers/core.py", line 1071, in _parse_function_from_config
    function = generic_utils.func_load(
  File "/home/daddywesker/anaconda3/envs/tf/lib/python3.8/site-packages/tensorflow/python/keras/utils/generic_utils.py", line 457, in func_load
    code = marshal.loads(raw_code)
ValueError: bad marshal data (unknown type code)

What could it be? /home/daddywesker/datasets/Euroc/V2_01_easy/mav0/cam0/data/ is the folder with images.

Sir, Semantic_Information_Publisher_C.py will read the picture from the ros topic and give out semantic result. So your should use python Semantic_Information_Publisher_C.py image:=/camera/image_raw.  You should supply the ros topic named /camera/image_raw. The original KITTI dataset is image files not the rosbag. So you should convert the files to the rosbag. You can find the tools easily.

Hm. So, when i'm launching python script Semantic_Information_Publisher_C.py, i should point him to the rostopic of some rosbag, yes? And where should i put the desired rosbag then? To the orb_slam_2 launch?

Yes the rosbag author did not supply it. You should download by yourself. https://gitee.com/zengtaiping/image2rosbag_KITTIodometry. Try it. This is a chinese website.
And about how to run all the semantic slam system, you can see run.sh in this github.

I have euroc rosbag, thanks. Alright, i'll take a look into run.sh instead of run_C.sh then. Thanks.

Well, unfortunately i can't get past rosrun ORB_SLAM2 Mono Vocabulary/ORBvoc.txt Examples/Monocular/KITTI00-02.yaml since I'm receiving errors when I'm trying to build ORB_SLAM2 inside Thrid_Part folder. Actually, i've successfully run file build.sh, but build_ros.sh throws an error
No project() command is present.  The top-level CMakeLists.txt file must
  contain a literal, direct call to the project() command.  Add a line of
  code such as

    project(ProjectName)

  near the top of the file, but after cmake_minimum_required().

  CMake is pretending there is a "project(Project)" command on the first
  line.
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Deprecation Warning at /opt/ros/noetic/share/ros/core/rosbuild/rosbuild.cmake:7 (cmake_policy):
  The OLD behavior for policy CMP0011 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.
Call Stack (most recent call first):
  CMakeLists.txt:2 (include)

CMake Deprecation Warning at /opt/ros/noetic/share/ros/core/rosbuild/rosbuild.cmake:16 (cmake_policy):
  The OLD behavior for policy CMP0002 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.
Call Stack (most recent call first):
  CMakeLists.txt:2 (include)

CMake Deprecation Warning at /opt/ros/noetic/share/ros/core/rosbuild/rosbuild.cmake:18 (cmake_policy):
  The OLD behavior for policy CMP0003 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.
Call Stack (most recent call first):
  CMakeLists.txt:2 (include)

CMake Deprecation Warning at /opt/ros/noetic/share/ros/core/rosbuild/rosbuild.cmake:20 (cmake_policy):
  The OLD behavior for policy CMP0005 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.
Call Stack (most recent call first):
  CMakeLists.txt:2 (include)

CMake Deprecation Warning at /opt/ros/noetic/share/ros/core/rosbuild/rosbuild.cmake:23 (cmake_policy):
  The OLD behavior for policy CMP0011 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.
Call Stack (most recent call first):
  CMakeLists.txt:2 (include)

[rosbuild] Building package ORB_SLAM2
[rosbuild] Error from directory check: /opt/ros/noetic/share/ros/core/rosbuild/bin/check_same_directories.py  /home/daddywesker/Dioram/TestingRGB/Semantic_SLAM/Third_Part/ORB_SLAM2/Examples/ROS/ORB_SLAM2
1
Traceback (most recent call last):
  File "/opt/ros/noetic/share/ros/core/rosbuild/bin/check_same_directories.py", line 46, in <module>
    raise Exception
Exception
Error in sys.excepthook:
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/apport_python_hook.py", line 153, in apport_excepthook
    with os.fdopen(os.open(pr_filename,
FileNotFoundError: [Errno 2] No such file or directory: '/var/crash/_opt_ros_noetic_share_ros_core_rosbuild_bin_check_same_directories.py.1000.crash'

Original exception was:
Traceback (most recent call last):
  File "/opt/ros/noetic/share/ros/core/rosbuild/bin/check_same_directories.py", line 46, in <module>
    raise Exception
Exception
CMake Error at /opt/ros/noetic/share/ros/core/rosbuild/private.cmake:99 (message):
  [rosbuild] rospack found package "ORB_SLAM2" at "", but the current
  directory is
  "/home/daddywesker/Dioram/TestingRGB/Semantic_SLAM/Third_Part/ORB_SLAM2/Examples/ROS/ORB_SLAM2".
  You should double-check your ROS_PACKAGE_PATH to ensure that packages are
  found in the correct precedence order.
Call Stack (most recent call first):
  /opt/ros/noetic/share/ros/core/rosbuild/public.cmake:177 (_rosbuild_check_package_location)
  CMakeLists.txt:4 (rosbuild_init)

-- Configuring incomplete, errors occurred!
See also "/home/daddywesker/Dioram/TestingRGB/Semantic_SLAM/Third_Part/ORB_SLAM2/Examples/ROS/ORB_SLAM2/build/CMakeFiles/CMakeOutput.log".

I've also tried to build orb_slam2_ros from here https://github.com/appliedAI-Initiative/orb_slam_2_ros but it doesn't build executable Mono (though, after build.sh in Third_Part/ORB_SLAM2 i've got no Mono executable file either).

Alright, i've beat that issue with adding
export ROS_PACKAGE_PATH=${ROS_PACKAGE_PATH}:/PATH/TO/Semantic_SLAM/Third_Part/ORB_SLAM2_C/Examples/ROS
to bashrc and cmaked orb_slam2_ros in example folder. Unfortunately, now i'm facing this issue when i'm trying to make it
Semantic_SLAM/Third_Part/ORB_SLAM2_C/Examples/ROS/ORB_SLAM2/src/AR/ros_mono_ar.cc:153:84: error: no matching function for call to ‘ORB_SLAM2::System::TrackMonocular(const cv::Mat&, double)’
  153 |     cv::Mat Tcw = mpSLAM->TrackMonocular(cv_ptr->image,cv_ptr->header.stamp.toSec());

Currently, no clue here...

use
cv::Mat Tcw = mpSLAM->TrackMonocular(cv_ptr->image, cv_ptr->image, cv_ptr->header.stamp.toSec());
instead of
cv::Mat Tcw = mpSLAM->TrackMonocular(cv_ptr->image,cv_ptr->header.stamp.toSec());
You may need do it some more times in other files.

Yes, that helps, thanks. Unfortunately, i'm now getting this error
/usr/bin/ld: warning: libopencv_imgproc.so.4.2, needed by /opt/ros/noetic/lib/libcv_bridge.so, may conflict with libopencv_imgproc.so.3.4
/usr/bin/ld: CMakeFiles/MonoAR.dir/src/AR/ViewerAR.cc.o: undefined reference to symbol '_ZN2cv7putTextERKNS_17_InputOutputArrayERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEENS_6Point_IiEEidNS_7Scalar_IdEEiib'
/usr/bin/ld: /usr/lib/x86_64-linux-gnu/libopencv_imgproc.so.4.2.0: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status

I'm afraid that noetic ROS i've built with another opencv than orb_slam2. I've tried actually to build orb_slam2 with opencv 4 but there were many errors. Is there some other way than rebuilding of ros or orb_slam with another opencv version?

you used ubuntu20.04,  maybe you should install another opencv version 3.4, and orbslam2 link the opencv 3.4 instead(change the cmakeList.txt). OS problem is hard to solved, try or use ubuntu 16.04 instead.

Well, i've managed to build it using this fix/hack by Marcus
https://github.com/UZ-SLAMLab/ORB_SLAM3/issues/97
Will try to launch now.

Oh wel...
rosrun ORB_SLAM2 Mono Vocabulary/ORBvoc.txt Examples/Monocular/KITTI00-02.yaml

ORB-SLAM2 Copyright (C) 2014-2016 Raul Mur-Artal, University of Zaragoza.
This program comes with ABSOLUTELY NO WARRANTY;
This is free software, and you are welcome to redistribute it
under certain conditions. See LICENSE.txt.

Input sensor was set to: Monocular
Segmentation fault (core dumped)

And how am i supposed to debug that...

Here is what gdb says:
"/opt/ros/noetic/bin/rosrun": not in executable format: file format not recognized
/home/daddywesker/Dioram/TestingRGB/Semantic_SLAM/Third_Part/ORB_SLAM2_C/ORB_SLAM2: No such file or directory

I guess it can't find ORB_SLAM2 mentioned in rosrun ORB_SLAM2 should it be something else?

Launched with gdb using
rosrun --prefix 'gdb -ex run --args' ORB_SLAM2 Mono Vocabulary/ORBvoc.txt Examples/Monocular/KITTI00-02.yaml
and got
Input sensor was set to: Monocular

Thread 1 "Mono" received signal SIGSEGV, Segmentation fault.
0x00007ffff77b4d12 in ?? () from /lib/x86_64-linux-gnu/libopencv_core.so.4.2

I guess that fix/hack for opencv didn't worked so well...

Alright. I've re-built ORB_SLAM2 with rebuilt opencv 4.2, fixed some compatibility issues and now i've launched all lines from run.sh in a separate terminals. And after i'm running last one, python cluster.py, i'm getting this error
[ERROR] [1624527912.019743647]: Client [/cluster] wants topic /trajectory to have datatype/md5sum [nav_msgs/Path/6227e2b7e9cce15051f669a5e197bbf7], but our version has [map_generator/tjy/0d7fb206b66f869d41c3fc6ff889cb36]. Dropping connection.

in the window, where i've launched rosrun ORB_SLAM2. Is there are something else to be run? Maybe some sort of rosplay bag?

Hello,
When trying to launch your run_C.sh i'm getting No module named 'map_generator' error. How to install it?
THanks in advance.

Hello,
When trying to launch your run_C.sh i'm getting No module named 'map_generator' error. How to install it?
THanks in advance.

hi , have you reproduce the result? where is the cluster node?


Limit number of connections from a single host

We should limit the number of connections a single host can do to the server. If we allow a single host to make too many client connections they might take up too much resources and might lead to a DOS.
Further we can also look into the idea of increasing the number of client connects for a host based on the hash power they provide (make it a sliding scale) . This would act as a good way to prevent a DOS since actual work needs to be done to prove hashpower to the server.

Will look into dynamically increasing client connection limits based on work contributions associated with the host. For now a configurable limit will be used.

Closed by #127 and #125


Add TuYa Thermostat Radiator Valve support

Simple, but bit of configurable Thermostat Service with zigbee2mqtt climate (system_mode, current_heating_setpoint, local_temperature) support
TuYa TS0601_thermostat support
SystemMode type

@DawidMartenczuk Please, fix conflicts so I can merge it if you confirm it is working with the device

@DawidMartenczuk Please, fix conflicts so I can merge it if you confirm it is working with the device

@DawidMartenczuk did you see this? https://github.com/madchicken/homebridge-zigbee-nt/issues/83

@DawidMartenczuk did you see this? https://github.com/madchicken/homebridge-zigbee-nt/issues/83

Hi @DawidMartenczuk are you going to resolve conflicts?
I'm also interested in this extension to Tuya TRV's

Hi @DawidMartenczuk are you going to resolve conflicts?
I'm also interested in this extension to Tuya TRV's

I  submitted a versions for tuya compatible with v2 and it is now merged and published in v2.0.3, have you tried that?

I  submitted a versions for tuya compatible with v2 and it is now merged and published in v2.0.3, have you tried that?

After resolving conflicts, I can say we can close this.

After resolving conflicts, I can say we can close this.


Add Inflancer.net

@aakashx58 Please pull the latest changes to your branch. Don't worry about the link checker.


Clean dnf/yum cache

This ensures dnf/yum cache are cleared after package installation, to minimize container image size.

without this change
[tkajinam@mylaptop edpm-ansible]$ podman images
REPOSITORY                                                  TAG         IMAGE ID      CREATED             SIZE
quay.io/openstack-k8s-operators/openstack-ansibleee-runner  latest      343caafa1c51  17 seconds ago      962 MB

With this change
[tkajinam@mylaptop edpm-ansible]$ podman images
REPOSITORY                                                  TAG         IMAGE ID      CREATED             SIZE
quay.io/openstack-k8s-operators/openstack-ansibleee-runner  latest      2332f4106fed  8 seconds ago       730 MB


Register

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/121596
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" ce5692c45e33454f0cca4297c83126b32f5d83f8
git push origin v0.1.0

@JuliaRegistrator register

Registration pull request updated: JuliaRegistries/General/121596
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" 41cbee7b7ee9e28b9df5d61c2adaa32490809a4d
git push origin v0.1.0


Separate renderer and controls for image plugin

New PR that adds separation of UI and Rendering for the plugin. This is functionality further discussed in #580 . Please note this is a dummy PR that mostly serve as POC and will probably either be modified or abandoned in favor of more complete solution in the future.

Coverage remained the same at 48.957% when pulling 9b2f35f6999580c9b876d65c25ae990df7e4c929 on PeterKottas:plugin-controls-renderers-new into 595ce093e412cd4ce58291418e0c21d3a33032d2 on ory:master.

This looks good to me! There's still some issues I see. First is that HTMLRenderer still relies on mui. Second is how we can initialize the plugins properly. I was thinking that we could do something along the lines of:
import { Icon, Controls } from 'ory-editor/image/mui'
import image from 'ory-editor/image'

const e = new Editor({
  plugins: {
    content: [image({ Controls, Icon })]
  }
})

To make this easier, we could probably also do something like this
import { plugin as image } from 'ory-editor/image/mui'

const e = new Editor({
  plugins: {
    content: [image()]
  }
})

which would basically set everything up with the mui defaults.
Another idea I had is to first introduce @ory-editor/* or maybe @ory/editor-* and have two plugins, like @ory-editor/image and @ory-editor/image-mui but I'm not sure if that really improves things.
What do you think?

Yeah it still needs some polishing. I had some ideas as well but first need to finish some other stuff. The renderer definitely shouldn't rely on any UI packages. Unless of course intended by the plugin author.
Right now I am thinking that the plugins should:

Only keep core logic.
Controls and rendering should be different packages (to keep things lightweight), however I wouldn't be totally opposed to keeping some defaults in the plugin package. Main reason is contributors would probably prefer maintaining just one package instead of minimum 3 per plugin.
Plugin should always return class that extends PluginBase (I was first thinking it should return function, that would still work, but read bellow)
Plugin base should
a) Accept plugin config (generic type that extends defaultPluginConfig, that holds stuff like plugin name, description)
b) Implement the basic settings overides (like discussed in previous point)
c) hold previewState and expose onChange, and onPreviewChange (previewState is important because sometimes you need to change plugin state, but not update editor state (because it would fuck up undo/redo), think slider that would flush 10s of useless undos into the editor). I actually implemented something similar in background-plugin, but I think this should come out of the box.
d) Handle switching between rendering and controls (basically a base render function), it would also inject the previewState and state into the renderer and controls. Basically just some out of the box functionality to make things easier. This would also enforce people not to render any html specific tags because that would destroy react-native capabilities.
e) the base render function should accept one parameter, controlsApi. The plugin implementation would provide this and the base render would inject it into controls.

I don't want to go more in-depth, some of these will require POC, and I see some problems but overall that seems like a sensible approach to me. This should also be very well documented to make it easy for people to contribute.
Things I like about this:

Just one class and some functions would implement all core logic.
2 sfc (because state is kept in the base plugin) required to implement renderer and controls
People could easily provide different controls and or renderers for existing plugins

Another idea I had is to first introduce @ory-editor/* or maybe @ory/editor-* and have two plugins, like @ory-editor/image and @ory-editor/image-mui but I'm not sure if that really improves things.

I like the idea, I would maybe do @ory-editor/image, @ory-editor/image-controls-mui, @ory-editor/image-renderer-html

The idea of separating the renderer from the image is that you might add other renderers later on?

Yep exactly. I thing supporting react-native out-of-the-box(ish) can rly make ory editor a superstar on the field of content editors. People (imho) when using react-native will only need to render data, not necessarily change it (controls) and if we allow them to do it, that's a big game changer.
Imagine, if you wanted to support image plugin on RN now, you would basically have to recreate the whole plugin functionality. With separate renderer, that's literally <10 lines of code.  Which can even be released as a package.
And as we will eventually want this for GuestBell (my company), I will probably provide these renderers for most stuff. And then we can just put the magical words "Supports react-native" in big letters in editor readme ;)

Plus on top of this, you can even provide different renderers for html. Maybe image can have number of different renderers somebody provides where one adds some nice frame around it ... or something like that. Then we can change this dynamically on the example page, and people can check and download the one they like the most. (all this is theory but you see my point)

Yeah that makes sense!


XeTLA Fix Global 1D Store

Type of Change: Bug Fix
API not changed
Description
As title
Expected Behavior & Potential Risk
N/A
How has this PR been tested?
Internal IPEX testing pipeline
Dependency Change?
No

Ready to merge as internal IPEX PR merged.


Fix: base path and use xdg crate

Hey @wash2 do you plan to fix more stuff here or can I merge as is ?

Oh thanks! Ya I was meaning to put together a PR. This should be good as is as far as I can tell :)

I think sometimes it seems like a strange size is picked for certain icons, specifically for firefox in my case. Maybe searching for svg first by default would avoid it in most cases but I can look more into the issue in general. It might just be that I'm using it incorrectly lol

Maybe related to #4, I need to take a closer look though

Hey @wash2 I have just released the crate with your changes.
It's now available on crates.io


HDDS-10112. Dashboard for ReadKeys

What changes were proposed in this pull request?
Created a new dashboard and added visualisations for all the required ReadKey Metrics.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10112
How was this patch tested?
The patch has been tested over a Grafana.

@devabhishekpal could you also please take a look? Thanks!

Sure @tanvipenumudy, please find snapshots here:

@tanvipenumudy thanks for the review, I have addressed all of your comments and fixed minor nits as well.
Here I am attaching the Snapshot of the Dashboard with updated json.

Thank you @devabhishekpal for reviewing it.


[BUG] Output have field with None and text have dict with field with text

Description
Hey, seems like a fun library and tried to use example that's similar to one that's in readme (would be nice to have a script/notebook to check out library). I used AzureChatOpenAI as a llm.
The result (LLMdanticResult) have field with None and result's text have dict that's filled.
text - {"rewritten": "Miód to ulubiony przysmak Kubusia Puchatka."} - Honey is Winnie the Pooh's favorite treat.
output - rewritten=None
To Reproduce
Steps to reproduce the behavior:
# setup
llm = AzureChatOpenAI(
    api_key=AZURE_API_KEY,
    api_version=AZURE_API_VERSION,
    azure_endpoint=RESOURCE_ENDPOINT,
    azure_deployment=AZURE_DEPLOY,
    temperature=0,
    verbose=True,
)
class RewriteInput(BaseModel):
    text: str

class RewriteOutput(BaseModel):
    rewritten: str

    @field_validator("rewritten")
    def rewritten_text_must_be_in_polish(cls, v) -> bool:
        """ Rewritten text must be in polish language """
        ...

    @field_validator("rewritten")
    def rewritten_text_must_not_be_empty(cls, v) -> bool:
        """Rewritten text cannot be empty """
        ...

    @field_validator("rewritten")
    def rewritten_text_must_be_short(cls, v) -> bool:
        """Rewritten must be less than 100 words """
        ...

config: LLMdanticConfig = LLMdanticConfig(
    objective="Rewrite the polish text and convey the same meaning but with different phrasing and structure to ensure it is fresh and engaging.",
    inp_schema=RewriteInput,
    out_schema=RewriteOutput,
    retry=3,
    verbose=True,
)

llmdantic = LLMdantic(llm=llm, config=config)

# polish for Winnie the Pooh likes honey
data = RewriteInput(text="Kubuś Puchatek lubi miód.")
result = llmdantic.invoke(data)
print(result.text)
# output: {"rewritten": "Miód to ulubiony przysmak Kubusia Puchatka."} - Honey is Winnie the Pooh's favorite treat.
print(result.output)
# output: rewritten=None

Expected behavior
Output should have filled fields from llm

Hello,
Thank you for using the package and your kind words. The issue you're facing is related to how the validators in the RewriteOutput model class are handled.
The root cause of the problem is that the field_validator functions in your RewriteOutput class are not returning the correct values. These validator functions should either return the value itself if it passes the validation or raise a ValueError exception if the validation fails. However, in your code, these functions are not returning anything, resulting in None being assigned to the rewritten field.
Please let me know if you need any further assistance in resolving this issue or have additional questions. I'll be happy to provide more detailed explanations or suggest solutions.

Oh shoot, I missed that. Thanks, after adding returns it works as intented :D


Filling a path is always done with non-zero fill-rule

Is there an option for even-odd? Otherwise paths with holes are pretty impossible to draw

can you share an example? it should be even-odd already

https://jsfiddle.net/uL12bxdj/1/ Looks non-zero to me. Perhaps because it's two sub-paths where the latter forms the hole, instead of a single sub-path intersecting itself?

Using a different path (taken from the SVG spec), winding direction indeed makes a difference, indicating non-zero-ness:
fill-rule=evenodd

fill-rule=nonzero

Yes I do realize the difference. Should definitely fix this
Just for notes, few things to consider here:

The SVG 'path' fill algorithm at the moment is different than that from other shapes.
Is it something that rough should set or should the called set it before drawing the shape - this depends on 1
Consider the implementation for Canvas Vs SVG

I have developed a new algorithm for path filling. Hopefully implement it in the next couple of days.

Independent of the new algorithm, fixed the evenodd issue in v4.1.3
https://jsfiddle.net/wytpsLr6/2/

This problem still exists when using<EMAIL_ADDRESS>https://jsfiddle.net/rwpgx2t0/


Use Dart2 VM for travis test

We should be able to set DART_VM_OPTIONS=--preview-dart-2 pub run build_runner ... to run all of our tests with the new semantics.

I'm nervous about running with this on travis only:

We aren't likely to see this developing locally, externally, only on travis
From results from @natebosch and @jakemac53 this makes test significantly slower
We don't run with this logic internally, meaning any CL/dep change can break us

... ultimately it feels like this just creates more work for whoever does the sync process (i.e. me, right now), without creating a lot of security. I'd rather more time/effort is put into switching our test cases internally to use --preview-dart-2 before our external build process.

We already had one regression here, so having any test coverage is better than none, even if it is only externally.
Also, @keertip thinks we can turn this on internally soon. I'm in favor of turning it on externally only for 1 week or less. But if we think it will be longer than that to enable internally, then I'd agree with you here.

We were told "1 week" weeks ago :). I don't think 1 week of travis coverage is significant anyway.

I think we can mark this closed given that it is now the only option.


can 8gb rtx 3060 run the 13b model?

can 8gb rtx 3060 run the 13b model?

I don't think so. In int4 quantization, the weights itself approach around 8G, and if taking KVCache into account, the upper bound could be 10-11 GB


Brush Shader Errors in Unity 2018.3.x

Hello together,
in Unity 2018.3.6 (also previous 2018.3.5) the build can not compile with this messages
"Did not find shader kernel 'vert' to compile" and "Input signature parameter SV_VertexID (1-based Entry 0) type must be a scalar uint. at line 64"
I'm running a Mac with latest OS 10.14.3, Unity 2018.3.6f1, Scripting Runtime Setting to .NET 4.x Equivalent and API compatibility level to .NET 4.x
Screenshot:

It is directly related to this issue:

https://github.com/googlevr/poly-toolkit-unity/issues/19

Affected shaders:
'Brush/Particle/Snow'
'Brush/Visualizer/Dots'
'Brush/Particle/Smoke'
'Brush/Particle/Stars'
'Brush/Particle/Bubbles'
'Brush/Particle/Embers'

I'm getting the same error using the same Unity version as well as Mac OS version. I deleted and reimported all Poly assets - but no luck. You're not alone.

Save problem for Android with the same version

I hope Google will Update Poly to fix this Problem... have the same

Still no luck reproducing this. Those who are seeing it:

Does this happen only when you do standalone builds, or do you see it any time the editor is open?
What editor platform are you using? I see a couple people reported macOS -- is anyone seeing this on Windows too?
What platform and graphics API are you targetting? Anything besides Android + GLES3?

My setup to try to repro this is:

Host: Unity 2018.3.5, Windows
Target: Windows+GLES3, Android+GLES3, Android+GLES2
Runtime and APIs: all of them

One more thing to double-check, which Poly Toolkit version are you using? Note that, the v1.1.2 release did not include the f8b7420c84ac5ded7408be8fa7edee7f3f65aa00 commit, which addressed the known issues with 2018.3+.
So, it would be good to know if you can still reproduce the issue from the repo head.

I am using the last official Poly v1.1.2 release.
@anokta : I'll try the head version, thanks for the suggestion.

Another question for those who can reproduce this: what color space are you using? (Player settings -> Other Settings -> Rendering -> Color Space)

Still no luck reproducing.
Host: macOS 10.13.6
Editor: Unity 2018.3.6f1
Target: Android GLES 3
PT: .unitypackage from github

@dubois : Color space is set to "Gamma". For Android build target the errors are there but the compiler builds an APK nevertheless. For iOS target the errors stop the build.
I built the unitypackage from source and the error messages slightly change, but the issue is still reproducible. Here is the console output:

As the console log shows
"Shader error in 'Brush/Particle/Snow': Input signature parameter SV_VertexID (1-based Entry 0) type must be a scalar uint. at line 64 (on gles)"
it can be just an Shader issue. Other Poly shaders do not produce such an error log.

Good news; I was going to ask you to generate shader code and attach so I could show it to Unity, but while testing those instructions I was able to finally reproduce it locally.

Unity have reproduced the issue and have opened a bug.
Best known workaround for now is to avoid the combination of Unity 2018.3 and GLES 2.0.
In particular, GLES 3.0 does not show the issue.

Why did they add the new shaders?

Setting it to GLES3 seems to work! Thanks @dubois

@yosun : can you clarify who you mean by "they" and which shaders you mean by "new shaders"?


Merge pull request #108 from 4urcloud/dev

feat: Export Data + Azure auto collect all item + TLS

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

GitHub release
v1.4.0

Your semantic-release bot :package::rocket:


Bugfix/allow objects for value

Allow syntax such as:
- path: /my/value
  value:
    some: text
    right: here

value is YAML stringified so we end up with this in SSM:
some: text
right: here

Nice! That's a really good thing to have

:tada: This PR is included in version 1.1.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fixed a bug in retrofitting kinmapchi2 in old all_models tables.

When reading an old all_models table which does not have the kinmapchi2 column, the column was added but calculating the kinmapchi2 values did not work (silently...). This is fixed in this PR which - as discussed in a recent hack session - has been extracted from PR #322 for quicker merging. Until then, #322 will remain demoted to draft.
Remark:
Separated reading an existing all_models table (AllModels.read_model_table()) from updating it (AllModels.update_model_table()) to avoid problems with the configuration object (config_reader.py takes care of this).
Successfully tested with test_nnls.py and both weight solvers to verify that a deleted kinmapchi2 column gets re-added upon reading the all models table. Also, test_notebooks.sh succeeds.
Test suggestion:

Run the original test_nnls.py.
In test_nnls.py:36, set reset_existing_output=False.
In all_models.ecsv, delete the kinmapchi2 column (headline + 3 values) and its entry in the header (entire line 14).
Re-run test_nnls.py and inspect the output: all_models.ecsv should now have the kinmapchi2 column with the correct values again.

This test should also succeed when changing the weight solver (legacy weight solver <-> Python NNLS) in the config file between deleting and re-adding the kinmapchi2 column (with some warnings because the config file will now differ from the one uses when initially creating all_models.ecsv).

I ran your test suggestion - all worked as expected.


Extending DepositResponse in Response to SEP-6 Protocol Update

This issue is related to and dependent on the resolution of the restructuring SEP-9 fields issue. Once #86 is resolved, we can proceed with the enhancements outlined in this proposal.
The SEP-6 protocol has been updated to standardize structured off-chain deposit instructions for users. With this new update, there is a need to extend the DepositResponse by introducing a new instructions field. The original issue can be found here and relevant PR can be found here.
Proposed Changes:

Introduce the DepositInstructions object, consisting of SEP-9 Financial Account Fields as nullable properties.
Add a new instructions field to the DepositResponse object, marked as nullable.
Update the comment for the how field to indicate its deprecation.

These updates aim to ensure compliance with SEP-6 standards, thereby enhancing functionality. The addition of the new instructions field allows for a more flexible and standardized solution, contributing to an improved user experience.
Please let me know if you have any further questions or adjustments.

Hi @christian-rogobete , great! Thanks for quick update.


Closing as fixed


DateTime scalar and filters

I noticed that if I do not use DataTime type in Prisma's file, the following error happens:
Error: Input Object type QueryFindManyUserFilter must define one or more fields.
Then I checked what QueryFindManyUserFilter is like. Here it is:
QueryFindManyEventFilter {
  equals: DateTime
  gt: DateTime
  gte: DateTime
  in: [DateTime!]
  lt: DateTime
  lte: DateTime
  not: DateTime
  notIn: [DateTime!]
}

This is how I define Query.events field using Nexus:
t.crud.findManyEvents({alias: 'events', filtering: true, ordering: true})
And this is how my schema looks like eventually:

So:

seems like QueryFindManyEventFilter should be named like DateTimeFilter.
it should be possible not to use DateTime type in Prisma's schema file

Hey @victordombrovskiy could you clarify what you mean by:

I noticed that if I do not use DataTime type in Prisma's file

Ok. Prisma allows to use DateTime as type of model properties in prisma file. If I have a prisma file, where there are models, which have properties of type DateTime - the aforementioned issue doesn't happen. But if all models have no property of type DateTime, I receive the error.

I cannot reproduce. For example this works:
model User {
  id @id @unique @default(cuid())
}

objectType({
  name: 'User',
  definition(t) {
    t.model.id()
  },
})
queryType({
  definition(t){
    t.users({filtering:true})
  }
})

type Query {
  users(after: String, before: String, first: Int, last: Int, skip: Int, where: UserWhereInput): [User!]!
}

input StringFilter {
  contains: String
  endsWith: String
  equals: String
  gt: String
  gte: String
  in: [String!]
  lt: String
  lte: String
  not: String
  notIn: [String!]
  startsWith: String
}

type User {
  id: ID!
}

input UserWhereInput {
  AND: [UserWhereInput!]
  id: StringFilter
  NOT: [UserWhereInput!]
  OR: [UserWhereInput!]
}

I can't reproduce it as well now. So, probably, let's close it.


Oracle LDAP connection

Is possible connect to an LDAP Oracle database through Dbvear connection?
Thanks a lot!

Thank you for your request.
Duplicate of #7702


Add Neos 5 Support

Make this package Neos 5 compatible.

@breadlesscode thank you. it's good to hear that the package is still maintained. I changed the dependencies to be compatible with NEOS 5 and it seams to work. I made basically no code change, but if it helps I can still make a PullRequest out of it. As you wish 😊


scheduler-watcher:checklastevent not working in Laravel 8

I have followed the instructions for the integration of nagios (see https://michabbb.gitbook.io/laravel-scheduler-watcher/nagios)
When i call:
php artisan scheduler-watcher:checklastevent 0f517c9d32a032b84615c82461e1c864 --no-ansi
I get the result, no matter if i use the option or not
An option named "no-ansi" already exists.
With help of the Maintainer, I found the reason for this problem.
In Class macropage\LaravelSchedulerWatcher\Console\SchedulerWatcherCommandCheckLastRun the signature was the problem.
protected $signature = 'scheduler-watcher:checklastevent {jobMD5} {--noansi}';
If I removed "no-ansi" in the source code it worked.
Environment:

PHP 8.0.8
Laravel/Framework: 8.51

i guess i forgot to close this issue, since this is fixed since a long time. changed param --no-ansi to --noansi


Weird player behaviour when having internet connection set to 100% loss

Play a piece in browse
Set conditioner to 100% loss
Play another piece

Result: Looks like both pieces are playing, but there's no sound. At one occasion I clicked play on a piece, but the piece that I was playing before that was the one that was actually playing (even though it looked like I was playing the piece I clicked on.)

This was fixed in #22.


Create the votes table

User Story

As a user, I can tabulate all the votes cast by candidate ID in descending order.

As a user, I can cast a vote for a candidate.

The user can now tabulate all the votes by candidate ID in descending order and cast a vote for a candidate.


Introduce Card Image Redirect to URL

Add a feature to the CMS that will redirect to the specified URL upon clicking on the card image. At this moment, button need to be added for this purpose.

Added in 24.5.1:
Support for stretched-link in any Button Link, including in any card. To achieve a stretched link, add "stretched-link" to custom css classes in button's advanced settings. To achieve an invisible button link (e.g. image link), add "stretched-link zero-sized" to custom css of the button.


Skywalking-client-js cannot fetch a stream from the fetch API

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[x] Bug
[ ] Requirement
[ ] Feature or performance improvement

Bug

skywalking-client-js

Which company or project?
pdf.js

What happened?
whatwg-fetch doesn't implement stream api https://github.com/github/fetch/issues/746 An error occurs when you try to get a ReadableStream. pdf.js use res.body get a stream.

// Fetch the original image
fetch('./tortoise.png')
// Retrieve its body as ReadableStream
.then(response => response.body)
.then(body => {
  const reader = body.getReader();
});

jsfiddle example (First of all, the cross-domain problem should be solved before it can be reproduced)
@Fine0830

Close this via https://github.com/apache/skywalking-client-js/pull/48


Plato should be able to deal with YAML ESLint config

Right now we use the yaml2json dependency for Plato, which seems overkill. Plato should be able to pass a yaml config file to ESLint. If it can't, let's fix Plato.
We also have yamljs lingering around, and it seems we should not need it.
If we can get rid of them, that would be nice. But these are dev dependencies only and don't have any negative impact (beyond dev installations being a tiny bit slower), so it's not a massive priority.

So it turns out Plato is really not maintained anymore. We need to look for something else. I haven't been able to find anything as good as Plato though. The big question is: do we keep using Plato in the mean time?

yamljs exposes a "binary" that we use to convert our eslint configuration to JSON.

https://bjoernkw.com/2016/11/27/jscity-code-complexity-visualization-for-javascript-codebases/

That takes about a day to render the scene on my laptop, using the example on that page. Then I found these examples which are a lot faster: https://github.com/ASERG-UFMG/JSCity/wiki/JSCITY
But this doesn't give very useful metrics, like Plato did.

Then I'd say flat out remove Plato. I doubt anyone uses it anyway at this point.

Dug a bit deeper.
So the most useful thing I think we could do at this point is indeed remove Plato. However, I also found this tool
https://vile.io/#features
Which in turns has a plugin for escomplex: https://www.npmjs.com/package/vile-escomplex
We would need to test it, but while we'd loose the capability of producing local reports, we'd gain the capability of visualizing them online - that, and, if I get this right, visualizing how complexity is evolving as well.

Assigning the both of us to this task - I'll make sure to look a little deeper into vile.io, and of course would love to get your feedback on it as well.

Vile actually looks very promising 👍

https://vile.io/~stelcheck/mage
Just gave it a try. to be honest, the reports and graph don't seem all that useful in the end, so I would consider having a look at other alternatives.

I get a 404 on that URL

Did you try to create an account and log in? It's supposed to be public, but maybe public means "logged in on their platform"?

Even after logging in, 404.

This subject isn't going anywhere, and we couldn't come up with any actionables so far.
Would suggest closing this issue until we have a proper solution or alternative. Plato isn't hurting anyone at the moment. Either that, or we remove Plato (I personally do not use it).

Let's remove it. One less dependency to keep track of.


Issue 128 - Refactor CompactionStrategy

Note that this PR is stacked on top of #134, please merge that one first
Resolves #128

I'm going to refactor this to decouple it from the CreateCompactionJob event model & builder. We probably won't end up using that.


[SPARK-10652][Streaming] Set job descriptions for all streaming jobs

Here is the screenshot after adding the job descriptions to threads that run receivers and the scheduler thread running the batch jobs.
Jobs page

Added job descriptions

Streaming batch details page

Added the +details link

@zsxwing Can you take a look at the changes.

Merged build triggered.

Merged build started.

Test build #42562 has started for   PR 8791 at commit e8e7894.

Test build #42562 has finished for   PR 8791 at commit e8e7894.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42562/
Test FAILed.

Merged build triggered.

Merged build started.

Merged build triggered.

Merged build started.

Test build #42573 has started for   PR 8791 at commit 7206f2e.

Test build #42573 has finished for   PR 8791 at commit 7206f2e.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42573/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42572/
Test FAILed.

Merged build triggered.

@zsxwing I addressed comments and made another update. Now the job description supports having links in them, and that is used to link to the batch details page.

Merged build started.

Test build #42574 has started for   PR 8791 at commit b15012f.

Test build #42574 has finished for   PR 8791 at commit b15012f.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42574/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #42592 has started for   PR 8791 at commit fd0d435.

Test build #42592 has finished for   PR 8791 at commit fd0d435.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42592/
Test FAILed.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #42599 has started for   PR 8791 at commit b5cb02e.

Test build #42599 has finished for   PR 8791 at commit b5cb02e.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42599/
Test FAILed.

LGTM except my comment about startSite.

Merged build triggered.

Merged build started.

Test build #42659 has started for   PR 8791 at commit d2ab91d.

Test build #42659 has finished for   PR 8791 at commit d2ab91d.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42659/
Test FAILed.

This is blocked on #8781 . Once that is merged in both master and 1.5, I will finish this PR by adding unit tests.

@andrewor14

Merged build triggered.

Merged build started.

Test build #42797 has started for   PR 8791 at commit 21c90ea.

Test build #42797 has finished for   PR 8791 at commit 21c90ea.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42797/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #42815 has started for   PR 8791 at commit 4a45c82.

Test build #42815 has finished for   PR 8791 at commit 4a45c82.

This patch fails RAT tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42815/
Test FAILed.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #42825 has started for   PR 8791 at commit 4a0aba8.

Test build #42825 has finished for   PR 8791 at commit 4a0aba8.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42825/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #42826 has started for   PR 8791 at commit f9524c6.

Test build #42826 has finished for   PR 8791 at commit f9524c6.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42826/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Merged build triggered.

Merged build started.

Test build #42840 has started for   PR 8791 at commit f9524c6.

Test build #42840 has finished for   PR 8791 at commit f9524c6.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42840/
Test FAILed.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #42849 has started for   PR 8791 at commit 2fbfd1f.

Test build #42849 has finished for   PR 8791 at commit 2fbfd1f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42849/
Test PASSed.

@andrewor14 Could you take a look at this.

core parts LGTM

Merged build triggered.

Merged build started.

LGTM

Test build #42878 has started for   PR 8791 at commit 606b284.

Thanks @andrewor14 @zsxwing, will merge this to master and 1.5 when tests pass.

Test build #42878 has finished for   PR 8791 at commit 606b284.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42878/
Test PASSed.


docs: present during mount guide

Add initialIndex guide
Add react-navigation with initialIndex troubleshooting guide.

:rocket: This pull request is included in v0.12.4. See Release 0.12.4 for release notes.


Does the certificate chain include a root CA certificate by default?

Describe the bug:
The root CA certificate is included in the certificate chain in the cert-manager v1.3.0,  Is it a bug ?
Openshift routes get rejected due to two root CA certificates in the certificate chain.
$ oc get route
NAME HOST/PORT PATH SERVICES PORT TERMINATION WILDCARD
parksmap ExtendedValidationFailed parksmap https edge None
Expected behaviour:
The cert-manager documentation says  "When a certificate is issued by intermediates of the CA and the Issuer knows the intermediates, the content of tls.crt will be a resulting certificate followed by a certificate chain. The certificate chain doesn’t include a root CA certificate, as it is stored in ca.crt."
Steps to reproduce the bug:
When using Cert-manager to request a certificate from Venafi TTP, the root CA certificate is included in the tls.crt.
Anything else we need to know?:
Environment details::

Kubernetes version: v1.20.0+7d0a2b2
openshift version: 4.7.8
cert-manager version: v1.3.0
Install method: static manifests

/kind bug

Below is my understanding of the issue.

Essentially there is no option in TPP like “IncludeChain” where you can switch ON/OFF downloading of certificate chain.
This option to include/exclude certificate chain essentially exist in TPP’s WEBSDK call using “IncludeChain” (https://docs.venafi.com/Docs/20.4SDK/TopNav/Content/SDK/WebSDK/r-SDK-POST-Certificates-retrieve.php) and vcert utility (https://github.com/Venafi/vcert/blob/c2e03ae67eac2c931ad506395c92a3177c5db482/pkg/certificate/certificateCollection.go#L30)
The problem in my view occurs in the manner cert-manager calls the above function where chain is always downloaded. See: https://github.com/jetstack/cert-manager/blob/dffbf391dbb0fc6c1cfea62e561a9c6f54362ab0/pkg/issuer/venafi/client/request.go#L57
Plus, it is always assumed that last certificate is going to be CA certificate by copying it and not removing it from original certificatepemcollection. See: https://github.com/jetstack/cert-manager/blob/dffbf391dbb0fc6c1cfea62e561a9c6f54362ab0/pkg/controller/certificaterequests/venafi/venafi.go#L166

Note that cert-manager 1.4 now prevents tls.crt from containing the CA certificate with the Venafi Issuer: https://cert-manager.io/docs/release-notes/release-notes-1.4/#ca-vault-and-venafi-issuer-handling-of-ca-crt-and-tls-crt
Let me know if this is still an issue.


normal(1000, 100) -> int should throw an error

not reproducible, since the library handles types and type matching better


Create shortcutmanager class and move shortcuts in the tools themselves

Shortcuts & Tools Panel

Shortcuts attached directly to the tools
Support for mac (Meta key instead of CTRL)
Show the shortcut keys in the UI
Made the toolsPanel more dynamic, move the tools configs to its own classes

Some small UX stuff:

Make sure you can scroll the layer panel when there are a lot of layers
Contributors list is static, will scroll on hover

Really nice updates :-) Thanks for contributing!


Misc. typos

Found via codespell -q 3 -L uint,iff,ot,wan,numer,vertexes,survice,dirent -S ./apps/common,./apps/external

Thanks for this contribution! I'm pulling your commits manually (not through GitHub) into release-1.8.x for the v1.8.1 release.


Package interface with diff but not being updated

Hi,
Initial status: both systems are synced through an existing repository.
In the original system:

Updated a package interface adding some objects to it (a data element).
Committed changed to the repository

In the destination system:
3. Refreshed abapGit and can now see a diff in the modified package interface identifying that it was changed
4. Pulled changes... but nothing happens
5. Reset local... still nothing happens
I did some debugging through the package interface code and all seems normal (it identifies the components that need to be added and seems to ad them although then nothing is added) but unfortunately I still couldn't figure out where the problem happens. Sorry. I'm still not familiar with your code.

the package interface object is quite new, think it needs more code to handle this scenario
https://github.com/larshp/abapGit/blob/master/src/zabapgit_object_pinf.prog.abap

try again, use latest abapGit version

@nununo did you try it out, did it work?

@nununo this should also be fixed

Indeed it seems to work fine now as my interfaces are now in sync ;)
Thanks!!

It hasn't happened in a while so I don't have a fresh test case. I'll close this one and open a new one in abapGit the next time this happens to me. Thanks!


could you add a @type Or add an index.d.ts

I try to use this package with typescript but I have this error message :
Could not find a declaration file for module '@ibm-watson/assistant-web-chat-react'. <EMAIL_ADDRESS>implicitly has an 'any' type.
Try npm i --save-dev @types/ibm-watson__assistant-web-chat-react if it exists or add a new declaration (.d.ts) file containing `declare module '@ibm-watson/assistant-web-chat-react';
Thank you
Danny

Hi Danny. This script can load any version of web chat, each that would have its own types on the instance passed back. We have had discussions about creating types for each version of web chat, so you could lock to a version of web chat and get the types for it, but we have yet to get enough demand to do so. I will leave this issue open and if there is enough demand we can prioritize! In the meantime, declaring the module in your globals.d.ts will at least unblock you.


Update scalatest to 3.2.15

Updates org.scalatest:scalatest from 3.2.11 to 3.2.15.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalatest", artifactId = "scalatest" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.scalatest", artifactId = "scalatest" }
}]

labels: test-library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report
Base: 54.41% // Head: 54.41% // No change to project coverage :thumbsup:

Coverage data is based on head (3e68c21) compared to base (65acd46).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   54.41%   54.41%
=======================================
  Files           1        1
  Lines          68       68
=======================================
  Hits           37       37
  Misses         31       31

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Superseded by #208.


Typo in the second code snippet

Wrong quotation marks in this element:

It must look so:

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5e233816-41bf-52ca-af01-bba45a784e23
Version Independent ID: 9e043933-bf3d-bb4c-fa49-6c852b1ace4b
Content: Edit schedule board booking template - Field Service
Content Source: ce/field-service/booking-template.md
Service: dynamics-365-customerservice
Technology: field-service
GitHub Login: @LXHeinze
Microsoft Alias: daclar

Oo good catch! Thanks for pointing out. I just updated this in our working repo, and should be live by end of day. Thanks again!


Motion correction

Edge-detection phase correlation with pupil-iris masking not yet implemented. Required for accurate calibration-gaze video registration and motion drift correction in absence of glint.

Full glint processing now added following change to Thorlabs out-of-bore camera (robust glint now available). Retiring ResTech pupil classifier in favor of Thorlabs classifier.


Width 100% bug

Hi @Golodhros  !
How to make the width of the chart 100% ?
Thank you !

Hi @Tonypz,
For now, you need to manually set the width of the chart to the size of its container and render it. If you check our demos, you can see how to make this responsive by listening to changes on the viewport width.

Ok,  @Golodhros. Also made. Thanks.


SA_post_hoc_analysis, plotting save paths/locations.

SA_post_hoc_analysis.plot_boxplots and SA_post_hoc_analysis.plot_relationships function both need plots/ directory to exist prior to running....
OR need to change default save location so that it does not include a directory path that may or may not exist.
One idea is that all plot functions be standardized with a saveprefix=''. If nothing is provided for saveprefix, the plot will save in the current working directory with a name that directly reflects the function name (i.e. plot_relationships(...) results in a file like plot_relationships.png. If saveprefix is specified, that the value is prepended to the default filename.

This problem exists in SA_post_hoc_analysis.plot_output_scatter(...) function as well...

Fixed by commit 2d35b05fde466c4993263746bc302e06a9b7374f
Added save=False, saveprefix='' to all plotting functions.
With:
if save:
    plt.savefig(saveprefix+'plot_name.png', bbox_inches='tight')


Support for T5-11b T5-XXL + TP

The XXL version of the model for Inference is being asked by many customers. Given the size of the model, only through TP it would be possible to load the model.

It's in the roadmap: #267 will add general support for export and inference using neuronx_distributed and we will add support for TP in next PRs.

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

T5 with TP support is not supported yet, I'm still waiting for the help from the Annapurna team on the issue https://github.com/aws-neuron/aws-neuron-sdk/issues/851

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!


Tweak README to note its focus on malware

This commit tweaks the README to note this project's focus on malware.
Someone who just reads the first line will confuse this project with other projects that also analyze OSS & report information (such as the scorecard).
What's different about this project is its capturing of data to, among other things, detect some malware.
So let's make that clear from the beginning!

Terraform failed, and it looks like an error in the CI pipeline configuration.
Here are the error reports:
Run gcloud config set project
ERROR: (gcloud.config.set) argument VALUE: Must be specified.
Usage: gcloud config set SECTION/PROPERTY VALUE [optional flags]
  optional flags may be  --help | --installation

For detailed information on this command and its flags, run:
  gcloud config set --help
Error: Process completed with exit code 2.

@david-a-wheeler  Thanks!


Update for Python3 and masOS Monterey

As guys already noticed here #12 , in recent macOS update this workflow has been broken because Python 2 was removed.
I tried to fix it and looks like succeed.

A huge thanks to @mesozoic for this PR https://github.com/deanishe/alfred-workflow/pull/184. I used his code to update Workflow lib.

Current version has an extra code to work with clipboard privately. It requires special lib, that were shipped with macos but not anymore. I decided to switch to Alfred's clipboard functionality. It now has a checkbox for private copy. I think it means, that old Alfred versions are not supported anymore.

I also decided to remove Notify app that were shipped with workflow and switch to Alfred's notifications.

I switch python in path to /usr/lib/python3, so support of old macOS versions without Python 3 can result be dropped as well.

Direct link to updated workflow
https://github.com/otsec/alfred-pwgen/raw/python3/Password-Generator-3.0.0-alpha-1.alfredworkflow

Thank you!

Thanks! Confirmed working here.

Confirming the works as expected. Thanks a lot for the rewrite!
©deanishe WDYT about merging this and releasing a new major version?

Thanks for this!

Thanks a lot!

Thankyou!


Auto Update

Let users know about new releases.

Hi @terkelg! Are you currently working on this feature or have you kept it on hold in favor of other more requested features?

Hi! I'm not working on this or any other features at the moment. I'm too busy with work

Dropping this here, just in case anyone wants to work on this feature independently.
Auto-updating Electron apps is handled by Squirrel, a separate framework in itself. It currently only supports Mac and Windows. There's no way to auto-update apps on Linux. Not that I'm aware of.
The autoUpdater module might also be a good place to start.

Let users know about new releases.

See #33


LOGIN issue

They changed their API. The login post now has the following parameters:
{"grant_type":"password","scope":"internal","client_id":"c82SH0WZOsabOXGP2sxqcj34FxkvfnWRZBKlBjFS","expires_in":86400,"device_token": [YOUR DEVICE TOKEN],"username":[YOUR USERNAME],"password":[YOUR PASSWORD]}
What you have to do is login to Robinhood on your computer (I use Firefox so this will be tailored to that).
-Go to Robinhood.com (logout if already logged in)
-Right click > Inspect Element
-Go to the Network tab (3rd from the right)
-Enter "token" in the input line at the top where it says "Filter URLs"
-With the network monitor-er open, login to Robinhood
-You'll see two new urls pop up that say "api.robinhood.com" and "/oauth2/token"
-Click the one that's not 0 bytes in size
-Go to "Params" tab on the right
There you will see all the new JSON parameters for your specific login.
-Now go into the source code for this specifically Robinhood.py
-Edit lines 105-110 with your newly acquired JSON

Thanks for tip, I was scratching my head to get access_token.

Thanks for the tips, I also got this to work, is it possible we could make a PR to help others using this or is that device token something that changes frequently?
Here's what I found:
client_id: "c82SH0WZOsabOXGP2sxqcj34FxkvfnWRZBKlBjFS"
device_token: [YOUR DEVICE TOKEN]
expires_in: 86400
grant_type: "password"
password: [YOUR PASS]
scope: "internal"
username: [YOUR USERNAME]

@NathanMaton I don't think so. A device token is uniquely generated based on the combination of the App (Robinhood) and the device that is accessing it.
I'll play around with it a little more this weekend and get back to you.

@aseylys are you sure it's not a simple random uuid?

I am still facing the same error , after changing payload with required JSON params
Any other suggestion to check.

@aseylys  , @NathanMaton
I am still facing the same error , after changing payload with required JSON params
payload = {
'password': password,
'username': self.username,
'grant_type': 'password',
'client_id': self.client_id,
'device_token': self.device_token,
'expires_in': 86400,
'scope': 'internal'
}
I have taken device token from chrome browser and defined like client_id
Can you please suggest

@psingapati Make sure you log in successfully on the browser using that device token. I had to enter an SMS verification and log in on the browser before the api worked.

@osum4est Thanks for the reply.  I am able to login successfully on chrome browser. But with the API I am getting error.

@psingapati Make sure you have 2FA turned off in robinhood settings. If that doesn't work then I'm not sure

@osum4est I reviewed the 2FA. It is off.
still did not work
Then I realised that I am change the code in the git hub path but not reinstalling the package.
I did "pip install ." It worked :)
Thanks a lot
Thanks @aseylys  @NathanMaton

@aseylys sounds like you may be right on the device id.

Hey do you realize the login issue was solved here #176 by @ammazie. @Jamonek needs to merge his fixes by reference the code in #176

does anyone know how to get my qr code as per aamazie's update? I turn on 2FA from my app(android) and select "Google Authenticator", the next is Robinhood giving me a 16-character key and ask me to copy it into my google authentication app. i really don't see the "Can't Scan It?" option as described.  thanks.

Thanks for the tips, I also got this to work (on chrome, you'll see a tick box next to the word 'token/' and if you tick that off then the info shows up to the right.
Is it possible we could make a PR to help others using this or is that device token something that changes frequently? I'm not sure I know where that device token value comes from or if it changes. I also then used all of that to get an access token rather than just copying and pasting it from the network request.
Here's what I found:
client_id: "c82SH0WZOsabOXGP2sxqcj34FxkvfnWRZBKlBjFS"
device_token: [YOUR DEVICE TOKEN]
expires_in: 86400
grant_type: "password"
password: [YOUR PASS]
scope: "internal"
username: [YOUR USERNAME]

Where the heck is this hard coded client_id coming from ?


Throwing exceptions added to the House methods

Methods of the House object now throws exceptions in case of invalid argument or wrong requirement. As a result of the change in method interface, one test had to be adjusted. This PR is related to Issue #4

@Rogulus ok, now you'll need to rebase :-)

@mijaros  rebase done.


Timezone now add one hour to local time....

I have a problem (which I didn't have before) when I try to format the date with local time:
  vae dateStartFormat = "2021-1-8 08:00"
  var romeStart = moment.tz(dateStartFormat, "Europe/Rome");
  var romeStartFormat = romeStart.format();

romeStartFormat should give me: 2021-01-08T08:00:00+01:00
instead he adds an hour and gives me: 2021-01-08T09:00:00+01:00
I didn't change anything in the code, until a few days ago it worked.

solution=>      https://github.com/moment/moment-timezone/issues/922

solution=>      https://github.com/moment/moment-timezone/issues/922


Figure out state of FR track 1 package

Package: https://www.nuget.org/packages/Microsoft.Azure.CognitiveServices.FormRecognizer/0.8.0-preview.
Instructions: https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/377/Updates-to-improve-track2-release-visibility

Package has been deprecated and unlisted.


Feature/swaggerforapiview four

Feature to support collapsible sections in review files.
This is aimed at expanding APIView to support swagger.
Should resolved https://github.com/Azure/azure-sdk-tools/issues/3493 and https://github.com/Azure/azure-sdk-tools/issues/2921

Looks good except few minor comments


cannot couple iPad IOS 10.3.4 with homebridge-config-ui-x v4.15.1

cannot couple iPad IOS 10.3.4 with homebridge-config-ui-x v4.15.1 ...
with iOS 13 couple successful. After finishing the Setup on iOS 13 I can see all devices on iPad (iOS 10.3.4) but all devices are "no answer"

Hi @tobi18ww, this won't be an issue with homebridge-config-ui-x.

why

Was this resolved?  I'm having the same issue.  I have 2 old iPads that would like to install those wall mounted to control HomeKit Devices.  And for some strange reason in HomeKit running iPadOS 10.3.3, all Homebridge devices are not responding.  Homebridge and all it's plugins are up to date.  Is there a plug-in or a setup I'm missing to make old iOS devices compatible with an up to date Homebridge?


Open TSC Meeting, Thursday 11 March 2021

NOTE: This meeting is on Thursday at 9am - 10am PT
Zoom Meeting link: https://zoom.us/j/975841675. Dial-in passcode: 763054
In order to give some more visibility into the topics we cover in the TSC meetings here is the planned agenda for the next meeting.  Hopefully this will allow people to plan to attend meetings for topics that they have an interest in.  And for folks who cannot attend they can comment on this issue prior to the meeting.  Feel free to suggest other potential agenda topics.
Please submit comments below for topics or proposals that you wish to present in the TSC meeting
The agenda backlog is currently maintained in issue #2482

Topic
Owner
Decision/NextStep

Housekeeping
@webron

If we get time, discussion on the metaschema PR #2489 #2495
@OAI/tsc

AOB (see below)
TDC

New issues / PRs labelled review
@OAI/triage

New issues without response yet
@OAI/triage

/cc @OAI/tsc Please suggest items for inclusion

Warning to potential attendees... we will not be covering Overlays today.  This will be more of a working session trying to do cleanup.  Entertainment value will be low.


chore(vendor): update sauce connect

Update Sauce Connect to 4.4.12
It seems forks do not have the right to launch your unit tests

/CC @jmreidy in case you are not watching the repo.


Stupid example for using declarations

The example says that
using var x = new SomeDisposable();
var y = 0;
y += x.Stuff();
return y;

is equivalent to
var y = 0;
using (var x = new SomeDisposable())
{
     y += x.Stuff();
}
return y;

while in fact it's as equivalent to
using (var x = new SomeDisposable())
{
     var y = 0;
     y += x.Stuff();
     return y;
}

I'd prefer an example that shows more benefit than rationalizing a pair of parentheses and a pair of braces.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c36588d0-6bdf-1740-220c-10b20bb88730
Version Independent ID: 587ed47f-f532-e018-9b0d-6ee76afd20e4
Content: What's new in C# 8.0 - C# Guide
Content Source: docs/csharp/whats-new/csharp-8.md
Product: dotnet-csharp
Technology: csharp-whats-new
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Thanks for writing this @Haukinger
In the "what's new" section, we try to keep the examples small and focused. That keeps these articles to a reasonable length, while giving a brief explanation for each feature. The language reference and tutorial pages have more real-world examples.
That said, this could be better. I've added it to our backlog to address when we next update this article.

@BillWagner this pull request is merged and should fix this issue

@Haukinger
The benefit of the using declaration is that you don't need to worry about nested scope and variable lifetime, but you still benefit from not needing to explicitly call Dispose() before you return from your method.
The examples are demonstrating how your choice between a using statement and a using declaration would depend on how soon you'd like to Dispose the object; before the end of the method or with the end of the method.    The using declaration would dispose of the file once it goes out of the enclosing scope, be it method scope or block scope.  This means you could also declare it inside a for loop and it would be disposed after the closing brace of the loop and before the return statement.
In the example of the using declaration, if you had additional work to do prior to the return statement, the object wouldn't be disposed until you call return.  The using declaration method is easier for simple cases because it doesn't create a nested block level scope inside the method so you don't have to be mindful of the scope of any variables as the return statement and the variable declaration it depends on are at the same scope.  However, for example, if you popped up a message box on the desktop after the using declaration but before the return statement, you could keep a file locked on a network drive preventing others from being able to access it until execution continued past the return statement.  Or you could literally run out of RAM depending on how big the file is and how much processing you are doing.
In contrast, if you used a using statement or you nested the using declaration inside a for loop for example, you could free up the file before the method returns as Dispose() is called when execution passes the closing brace of the using statement or the closing brace of the for loop.  If you popped up your message box after the brace, the network file would be available to others even if you left your desk for coffee and your code is sitting there waiting on you.  The using statement creates a nested scope inside of the method scope, called block level scope, that can impact when the object is disposed as well as the lifetime of variables declared inside that scope.  If skippedLines "falls out of scope" because the declaration occurred inside the for loop or inside the using statement, it won't be available to be returned at the end of your method.  It's just like trying to access a variable that is declared inside another method you just called after you called it and returned from it.  The variable no longer exists in scope and can't be read.
In your example, the method would return before the closing brace of the using statement.  As long as you didn't have more code prior to the return statement, it's functionally equivalent, but if you inserted more code the object would remain in memory or your file would remain locked until execution reached the return statement.

@bnewcomb I was hoping that there's actually more to the using declaration than just skipping a pair of braces, but you're reinforcing by understanding. So the using declaration just says "I don't care when this is disposed, as long as it's disposed at all."

More like "I want this to be disposed once all the operations that follow the declaration have completed and it is no longer needed"
In the example, that is once this method finishes and control returns to the method that called it.
We need a good metaphor. The Super Bowl Party.
You can bring a plate and leave with whatever it can carry.
Using Declaration - You can have as much food as you want during the game. Take as many trips to the kitchen table as you like. How much  you have to drink(processor) , the size of your stomach(HD) and plates(ram), Number of people in attendance(throughput). All factors. After the game, food is immediately thrown into the trash so you better have a plate made up for your family at home. If you stay out too late, you'll have some unhappy people when you get back.
Using Statement - Caterers come at the start of the 2nd quarter.  You can make a plate, but then everything is thrown away to make room for the halftime show. Sorry. Food or Cheerleaders. Not enough room for both. You can create plates to store food for later and to share with the cheerleaders. It's considerate and may impact what you end up taking back home.(story, phone number, etc)
Instead of needing to perform the operations and variable assignment(getting a plate) inside the braces(2nd quarter), you can start after the declaration(coin toss) and eat all through the game. Less fussing with plates and moving food around. The smokies are best warm, right from the crock pot. Dispose(food tossed) will get called at the end(post game analysis) before control returns to the caller(take plate home and give to wife).
If you didn't care at all, it could wait until you stop the app. In the case of a web app, that could be a very long time. In the case of the Super Bowl, the food would be rotten and house unlivable. Think fraternity house with no rushes. Things can get very disgusting before the health department steps in. (Garbage Collector)
What kind of party do you want to go to?

Thanks for all the discussion and the PR to fix the original issue.
I explain the difference between the using declaration and the using statement like this:

In most cases, you'll close the using statement at the end of the enclosing block. In all those cases, the using declaration saves a couple brackets and parens. (It is that simple). It's most useful when a method reads from one resource and writes to another. Both resources should be disposed at the end of the enclosing block, so it's double the savings.
Prefer the using statement when you want to dispose of the resource before the end of the enclosing block.

As the original issue was fixed, I'm going to close this issue.

@BillWagner double savings only, if the using statements cannot immediately follow each other, right?
using( var readingStream = new ...)
using( var writingStream = new ...)
{
    // ...
}

and
using( var readingStream = new ...)
{
    // ...read something...
    using( var writingStream = new ...)
    {
        // ...
    }
}


VAssert implementation

This feature request would be composed of two parts:

implement a VAssert() function that acts just like CAssert() in both RELEASE and DEBUG mode. (@StasJ  will take on that. )
replace all existing assert() function calls with VAssert(). (@shaomeng  will take on that. )

it is implemented on the vassert branch

@StasJ
File VAssert.cpp fails to compile.

@StasJ
I went ahead to fix the compilation error.
Also, I've fixed a memory leak of VAssert.cpp. Feel free to take a look at it:
https://en.cppreference.com/w/c/experimental/dynamic/strdup

@shaomeng Its not a memory leak. The program terminates immediately afterward which frees the memory. Also, you can free a const char*

@StasJ
From strdup documentation:
The returned pointer must be passed to free to avoid a memory leak.


[FEATURE]: Allow Check Constraint on Column Instead of at the End of Table

Describe what you want
According to the documentation, the only way to add a check constraint is at the end of the table definition. However, I would prefer to have column check constraints next to the column name, similar to .unique(), .notNull(), etc. Is there a way to do so?
Documentation: https://orm.drizzle.team/docs/indexes-constraints#check
const emailsTable = pgTable(
  "emails",
  {
    id: uuid().primaryKey(),
    email_status: text({ enum: ["pending", "sent", "canceled"] }).notNull(),
  },
  (table) => {
    return [
      check(
          "email_status_type",
          sql`${table.email_status} IN ('pending', 'sent', 'canceled')`
        )
    ];
  }
);

+1
Is there any update on this? Is this on the Roadmap?


Add descriptions to use the JSON schema in JetBrains to README

We are able to take advantage of the JSON schema in JetBrains as well. It would be great to briefly explain how to set up property of the JSON schema mapping in JetBrains like PyCharm.
https://yu-ishikawa.medium.com/dbt-yaml-validator-in-jetbrains-b5ef25e9253e

Amazing! I'd welcome a PR to the readme that adds the summary of how to do this based on your article + a link to the source.

@joellabes Alright. I will send a pull request about that.
Besides, I think the repository with the JSON schemas are quite useful to get more production on the development of dbt projects. It would be great to post it to the dbt developer blog so that the knowledge is shared with more dbt users. If there is anything I can help, please let me know.

@joellabes We can close the issue. Please let me know, if there is anything I can help more.


Main Menu - Render Text in-Game Instead of in-Art

Currently, our equivalent of x_title.pcx has the art included in it.  This is similar to Civ.  But that means the text gets distorted as the aspect ratio changes, and most importantly the version (e.g. Carthage Preview 1) is part of the art and thus we always need to update the art to update that.  This is a bit of maintenance with each release, more so than if it was text-modifiable.
Not a huge priority, but if there's a nice way to render pleasing-looking text in Godot, this would be nice to have.  It might even be fancier than what I've done so far in Krita, which doesn't have as fancy of fonts as my Civ3 backgrounds from years ago.
This could be done just for the version first, as a first step.

What exactly is our equivalent of x_title.pcx? Is that a file in our project, or is it a function somewhere?

The image is C7/Art/Title_Screen.jpg and loaded from C7/MainMenu.cs. There should probably a scene containing the background, title/logo, and any footer, diplayed behind the main menu itself.


Update to React Native 0.56 RC

Every page looks like I'd expect. This did note that we're getting really far behind WRT the react-native typings, it looks tricky to migrate those, so I made that a separate task from actually updating.

deprecated by #1210


Incorrect layout in mobile resolution

Steps to reproduce:

Log In
Open Dashboard

Actual result: incorrect layout in resolution 991px & lower
Expected result: correct layout in mobile resolution

Thank you for bringing this up, I'm not a big expert with adaptive design, nevertheless, it was added to the backlog:
https://trello.com/b/ngqvbNgt/autopsy


Run Twitch.check_users inside an asyncio event loop

The problem
The check_users function in the Youtube cog is blocking, due to the use of streamlink.streams. I think this causes the bot to intermittently lose connection to Discord when the request takes too long.
The solution
Making the function async and call the blocking streamlink.streams with run_with_executor should help mitigate the issue.
How to implement it
Basically, the steps are:

[ ] First, claim the issue by commenting below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
[ ] Take a look at CONTRIBUTING for guidelines, and at README for some context.
[ ] Clone the repo if you haven't already.
[ ] Create a new branch, preferably with a descriptive such as async_check_users.
[ ] Go to cogs/youtube.py.
[ ] Currently the check_users function start at line 97.
[ ] Import the asyncio library.
[ ] Mark the check_users function as async.
[ ] At the beginning of the function (before the start of the for loop), get the event loop: normally the bot has a loop attribute so using self.bot.loop should work. Just in case, add an or asyncio.get_event_loop() like at line 933 of the Music cog.
[ ] Now, get the streams by running streamlink.streams using loop.run_in_executor. An example can be found at line 935 of the Music cog.

The first argument of run_in_executor should be None. The second one is the function to run and the third is the argument to pass to that function.

That's it for cogs/youtube.py.

[ ] To finish the code part, don't forget to await the function when called in check_youtube, from bot.py.
[ ] If everything looks good, open a pull request and wait for review!

Conclusion
That's it. :)
I said it is a simple issue, but it can be fairly overwhelming if you don't have much or any experience with git, discord.py, or even the asyncio library. Feel free to ask for help at any point, even (or specially) at the beginning. Remember, the idea of this issue is to help people get the hang of contributing to projects; the problem itself is just an entertaining mean to that end.
One last thing: I'd appreciate to have some update on your progress, at most a week after making the claim, even if it's to say you're still working on it. That way I can know whether to maintain your assignment or if I should assign it to someone else.

Hi @SURAJITSHAW.
Here's the new issue. I haven't add the first-timers-only tag yet, let me know if this one interests you. :)

Yeah, definitely I like to work on that. After reading all instructions it's sounds little hard but still I wanna to give my all. So can I start working on that?

Yeah, I detailed the steps a bit more than the other one because async can be confusing at first. I'm assigning you then. :) Don't hesitate to ask for advice.

Hello @JulioLoayzaM , I need a little help.
The second argument of run_in_executor is a function, I don't get the point which function did you mention?
I attached a screenshot what changes I made by far.

Hi @SURAJITSHAW,
Basically, the function streamlink.streams at line 125 is causing a problem by randomly taking too much time to complete. The solution is to call that function with loop.run_in_executor instead of calling it normally, because now we can await the result. You can see an example of this at line 935 of the Music cog.
Also, the bot should already have an event loop to run the function in. You can simply add self.bot.loop or before asyncio.get_event_loop(). That way it tries to get the bot's loop first, and if it returns None, it uses the one provided by get_event_loop.
Let me know if this clears things up! If you've never used the asyncio library before it can get pretty confusing.

Hi @SURAJITSHAW, did you make some progress on this?

No, I don't think I can do it. I'm sorry for wasting your time. You should reassign it to someone else.

@SURAJITSHAW don't worry, that's what the issue was for. If you want, I can tell you exactly what to change so you can submit a pull request.

Oh thank you so much. I have never expected that much support 🥺. Then give me more 2 days I will make changes in basis of what I understand by far. Then I submit my pull request and then you tell me what my mistakes are and what more should I change. Is it sounds good?
And also really thanks to support ameture like me.

Alright!
In cogs/youtube.by:

[ ] Just before import json add import asyncio.
[ ] Change def check_users to async def check_users
[ ] According to your screenshot, you have the loop line. If not, add loop = asyncio.get_event_loop() before for streamer in streamers.keys()
[ ] Just below the try, change streams = streamlink.streams(channel) to streams = await loop.run_in_executor(None, streamlink.streams, channel)

In bot.py:

[ ] At line 549, change messages, YT_PREV_STATUS = youtube.check_users(YT_PREV_STATUS, YT_STREAMERS) to messages, YT_PREV_STATUS = await youtube.check_users(YT_PREV_STATUS, YT_STREAMERS) (add an await)

And that's it. :) I think the run_in_executor part was too confusing for a first-timers issue.
After finishing the steps you can open a pull request. Could you please try to open one against the 'develop' branch? If it doesn't work, just open one against 'main'.

That's it @SURAJITSHAW , thank you for your contribution!

Thanks to you I can make my first successful contribution.🤗