Import support for the online type in BBT

First thank you for BBT! I was starting to panic about how to properly cite all the work I'd collected after I had discovered there were many conflicting keys. Thanks to BBT, panic attack averted!
I've only only been using it for a couple of hours, so it is completely possible that I've missed something obvious.
The reason why this is important for me at the moment is that the paper I'm writing relies on a lot of content that isn't peer reviewed but is still the source of truth. For example, Intel ARK is the definitive place to get CPU specifications, but it doesn't feel right citing it like a peer reviewed source.
To help with that, I currently have two reference sections, one which is peer reviewed and one which isn't. Currently the way I tell them apart is with the online type. So I hit this issue almost immediately.
I think the solution is probably the same as #430 which is "use Better BibLaTeX" (just need to find it). I found that issue after I'd started writing up this one, but I decided to continue because I think it should still import natively even if it can't export it natively as other tools/exports could still work with it.
Thanks again for all your hard work!
Report ID:
K2L99KLB-euc
Full Bib(La)TeX item you are trying to import:
@online{WEB:intel-ark-atom,
        Author = {{Intel}},
        Title = {{Intel Atom E3826 specifications}},
        Url = {https://ark.intel.com/content/www/us/en/ark/products/78477/intel-atom-processor-e3826-1m-cache-1-46-ghz.html},
        Year = {2019}}

Expected behavior:
BBT imports the online type as is.
Actual behavior:
BBT doesn't recognise the online type and converts it to article instead with the following error:
@WEB:intel-ark-atom, importing as journalArticle

From looking at past issues (such as #430 and #492) the solution is for me to use Better BibLaTeX. I was thinking though that even if bibtex can't format it properly for the output (and needs to convert to say misc, the import should still represent this correctly so it can be used natively inside Zotero.

This should be considered an enhancement not a bug given further research.

I'm not sure if this comes under this ticket, but it might be worth making it prominent in the README that if you need to use features like online you'll need to use Better BibLaTeX given I'm at least the second person to hit this.
It would also be great if that included a link to it, some documentation or just some pointers - google searching and reading through some of the repo didn't enlighten me.
I'm assuming of course that if I screwed it up, someone else might too.

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>18 ("fixes #1358")
Install in Zotero by downloading test build <IP_ADDRESS>18, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

I think the solution is probably the same as #430 which is "use Better BibLaTeX" (just need to find it).

It's one of the export formats installed by BBT. You'll find it in the dropdown list when you export items from Zotero.

I found that issue after I'd started writing up this one, but I decided to continue because I think it should still import natively even if it can't export it natively as other tools/exports could still work with it.

It could be that there's curently confusion about what can be imported, and what can be exported. BBT will do it's best to import whatever bibtex or biblatex you offer it into things supported by Zotero. Fully separately from this, BBT will do its best to export something as it lives in Zotero to the closest possible bibtex or biblatex (depending on which you choose at export) equivalent.
You may expect this to round-trip cleanly (so import of .bib file into Zotero and re-export of the imported items to a .bib file and expect to see the exact original again), which is a soft goal of BBT, but it's really only 100% possible in a small minority of cases. By and large, bibtex, biblatex and Zotero have different ideas of what goes into a reference item, so translations going either way in most cases have to make choices on where to put the information that does the least damage to teh intent expressed in the source.

K2L99KLB-euc

This is a debug report from the help menu; if we are talking about export, I need one generated by right-clicking the item you want to export, and selecting "Send debug report" from the popup menu that shows. If it's about import, we don't need a debug log for this particular issue (but thanks for sending one anyway -- better one too many than one too few).

Expected behavior:
BBT imports the online type as is.

The problem is that Zotero doesn't have an online type.

Actual behavior:
BBT doesn't recognise the online type and converts it to article instead with the following error:
@WEB:intel-ark-atom, importing as journalArticle

It's not so much that BBT doesn't recognize it, it just doesn't know to what Zotero type it should be translated.

From looking at past issues (such as #430 and #492) the solution is for me to use Better BibLaTeX. I was thinking though that even if bibtex can't format it properly for the output (and needs to convert to say misc, the import should still represent this correctly so it can be used natively inside Zotero.

That wouldn't help in your case. The difference between Better BibTeX and Better BibLaTeX only concerns how items that exist in Zotero (regardless of how they got there) are exported.
Try 1358. This will retain the reference type for export. It will still translate online to journal article though. I'm open to suggestions for an alternate Zotero item type.

I'm not sure if this comes under this ticket, but it might be worth making it prominent in the README that if you need to use features like online you'll need to use Better BibLaTeX given I'm at least the second person to hit this.

The README does say

Better BibTeX works from BibTeXing and Tame the BeaST for BibTeX, and The Biblatex Package for BibLaTeX

And those (in the case of bibtex, only roughly, but in the case of biblatex, extensively) document which fields you can expect. In the case of online, that is exclusively supported by biblatex -- if I were specify all this in the README, I'd just be duplicating those manuals.

It would also be great if that included a link to it, some documentation or just some pointers - google searching and reading through some of the repo didn't enlighten me.
I'm assuming of course that if I screwed it up, someone else might too.

That's understandable, but I don't mind answering questions here, or on gitter.

Thanks for the detailed and super fast reply!
Part of my problem is that I was using Mendeley until I found out that it had really poor support for bibtex. I then saw that Zotero had great support for it, especially with BBT.
I totally get the concept of imports being different from exports (that was actually what I was talking about when I said the import should import as online even if it couldn't export it). What I didn't know was that Zotero itself doesn't have the concept of an online type - I've been using Zotero for only a few minutes longer than BBT :)
I also didn't know that Better BibLaTeX was just one of the exporters that BBT provides.
So I think we're actually on the same page now that two gaping holes in things I should have known have now been filled :)
That being said, I would suggest that online might be mapped to Zotero's webpage type. Its documentation suggests that it is for any sort of "hosted" document (although it notes you should prefer a more precise type). In the biblatex manual, it specifies www as an alias for online so it seems a reasonable approximation for each other.
Also if my last comment came off as a bit brusque, my apologies, that wasn't my intention :)

Just tested the new build - can confirm that it imports and exports that entry as online. I still get the errors for the type being unknown, but that makes sense given that it's falling back to article.

I wouldn't say "should have known". Zotero has it's subtleties, BBT definately has it's subtleties, and both are severely under-documented. To compensate, it's always OK to ask questions about anything you want or expect BBT to do, here or on gitter.
Mendeley's "support" for bibtex is not great. I do not have the impression anyone inside Elsevier actually uses Mendeley with bibtex/biblatex.
webpage sounds reasonable, and Better BibLaTeX actually already exports webpage to `online. Test build incoming.

 Thanks!

No worries :)
Please consider it a small token of my appreciation - the amount of pain and anguish you've already saved me, not to mention all the pain and anguish I'd still be going through right now if BBT didn't exist and didn't have such incredible support is priceless.
I'm actually able to write content at the moment knowing that the nightmare I found just a few hours ago has already been taken care of :)

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>19 ("test case for #1358")
Install in Zotero by downloading test build <IP_ADDRESS>19, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

The error message about defaulting to journalArticle was a little confusing, I've changed that too (but you won't see it now for online).

I wouldn't call it small by any measure, but I'm not complaining 😄 . 5319 imports online as webpage, and will export it again as online if using Better BibLaTeX. bibtex doesn't know about webpages or online so it gets the misc treatment. You can always still force the type to anything you want by adding tex.referencetype=<something> in the extra field.
If 5319 works as you expect, I can cut a new release.

let me give it a try now...

Confirmed it's a good fix:

online types are imported as webpage
No warnings on import
Exports as online when exporting with Better BibLaTeX

All good from my point of view :)

5.1.170 is building, but it's just a rebadged 5319. When it drops (about 30 minutes or so, the full test suite takes a while) you can force an upgrade or just wait until Zotero checks for extension updates (once every day or two days I think).

No worries, thanks again for getting such a complete fix in for my issue so quickly!

My pleasure


Custom widget/view for frontmatter

Right now front matter is rendered as "sticky note" themed YAML, however I think there's an opportunity to do something nicer looking when in "preview" mode (that is: when the cursor is not inside of the frontmatter block), similar to what we do for tables.
Some ideas:

Render it as a table
Custom render certain keys, like $share

Nah


Planting a tree breaks some nodes

put a jungle sapling or a sapling on some dirt
let the tree grow
the bottom of the tree is 2 blocks under the sapling vertical position for "saplings", and 4 for jungle saplings. It means that 2 / 4 blocks are wiped.

--> may be a security issue, this might break "unbreakable" blocks.
--> a decent tree-factory would need tons of dirt (at least 1 block per tree), and we have no way to craft it from renewable resources.
proposal:

change the growing scheme for trees, they MUST not grow under the floor.

add an easy way (but not that cheap) to craft some dirt. Maybe 2 sands (group) with 2 leaves (group).

Nota Bene: this may affect more sapling than "sapling" and "jungle sapling", we need investigation.
"beech tree sapling" is not affected.

AFAIR (as few as I remember) trees didn't grow consuming dirt before the server reset, might be a bug or something...

All the watershed trees like default, jungle, default big pine. The functions are in watershed/functions.lua, named "watershed_()"
Each tree functions has a code block starting with a line like "for j = -2, 4 do" or "for j = -4, 14 do" or "for j = -5, top". They must be replaced by "for j = 0, 4 do", "for j = 0, 14 do" etc (everything starts at 0) to remove the "tree roots" which are created under the position of the sapling, removing the existing blocks.
In Lord of the Test, this is a feature, not a bug. I don't know for MFF, therefore I won't fix this myself.

It's not a feature for us, it's a bug, we don't want "roots", we will fix it soon :)

Check that the tree functions I quoted are used for the growing ABM and the mapgen then, because I didn't. They could be redundant elsewhere in watershed.

Mmmh... I think it should be 0, 5    or    0, random(4,5), as trees are very small actually (and also because we would lose 1/3 of trees capacity)

https://github.com/Ombridride/minetest-minetestforfun-server/commit/25d748c2443b8841d2c974d3cb01cb3a30a17f70
That's the best I can do with my knowledge of map generation in Minetest.

It's ok for me.
The functions you updated are the mapgen functions. But watershed also redefines the various "default.grow_" functions that are used by the sapling ABM of minetest_game. They are redefined to use the functions you updated, except for the cactus, which didn't grow underground when you planted one in the game. The case of the cactus is special : there are two pieces of code to grow one. One for the mapgen (in watershed), that you fixed, the other one for the growing ABM (in minetest_game), which didn't have to be fixed. I didn't check that the cactus grows a pair of arms when you plant one. it may not, because the code for its growing ABM doesn't come from watershed but from minetest_game.

Indeed, we can also change the code of the growing cactus to be like the mapgen cactus

default tree, big snow pine and jungle tree tested and approved in singleplayer with Mg's 25d748c commit. Both as mapgen and as planted saplings.
As Obani said, it's true that the design of the default tree makes it look small. It looks like a big bush rather than a tree. It still has 6 tree nodes though, instead of 8 when it had roots.

Ok, thank you for your tests.
Now, maybe we need to add 1or 2 nodes to the default tree trunk to be more high ? (and give again the deleted tree trunks for an easier way to bush wood for players)

Done in commit 96cc41f512. The default tree is randomly 1 or 2 nodes higher with the same design.

Wow, really good :)
I closed this issue because all of bugs signaled by @Cyberpangolin are now fixed.

I re-open: the tree now breaks the nodes around it, to replace its schematic by wood. Even very-costly blocks, like node breakers :/
This concerns the wood, probably every type, but not the leaves.
It came with the change to 0.4.13 and the new plants version.

It's not the same bug, but apparently, with the new system using schematics, minetest does not check whether or not it's replacing nodes.

More information here : https://github.com/minetest/minetest_game/issues/652#issuecomment-135891450

See https://github.com/minetest/minetest_game/pull/659

Fix merged 73113f344340ca75b5a77961d0d2a205566b1fe4

Great, thank you @paramat, now we need to merge it on our servers


Fix dependency typo?

I'm not exactly sure this is correct but I just wanted to shed light on it.

Thanks for the PR - it's not a typo though. Both "spellings" are valid, it's just shorter without the extra space. So, just a style question.

Thanks for the PR - it's not a typo though. Both "spellings" are valid, it's just shorter without the extra space. So, just a style question.

Ah I see, thanks for the clarification.

Ah I see, thanks for the clarification.


Revert iOS Safari WebAuthn support to supported

Addressed https://github.com/Fyrd/caniuse/issues/5672#issuecomment-718388972

Closing in favor of https://github.com/Fyrd/caniuse/commit/81c61f5140f3b4583828c8b3ddc7d556d13ebb9f.


print_integer throws Exception: Instruction JSR not implemented for anything beside print (FFD2)

running python main.py  examples/print_integer returns this error:
./main.py  examples/print_integer
Traceback (most recent call last):
  File "./main.py", line 24, in <module>
    cpu.run(0xC000)
  File "/home/arme/bin/Python-C64-Emulator/cpu.py", line 53, in run
    self.execute(instr)
  File "/home/arme/bin/Python-C64-Emulator/cpu.py", line 143, in execute
    raise Exception('Instruction JSR not implemented for anything beside print (FFD2)')
Exception: Instruction JSR not implemented for anything beside print (FFD2)

As the comment in the source of the example says, the emulator misses emulation for JSR and RTS instructions: https://github.com/fotcorn/Python-C64-Emulator/blob/master/examples/print_integer.asm#L1
To make these two work, we need a working stack first. Pull requests welcome ;)


fix undefined is not an object (evaluating 'frames.end.height')

fix #25
pls, review

I have looked into this issue a bit and I am not quite sure if we should do this. The problem is this: react-native now has its own keyboard events. Their event names are the same as the ones used in this library. That's why this error happens in the first place. The library isn't broken, it shouldn't be used with react-native 0.11. Is there a compelling reason why you want to use this library as opposed to the core implementation?

react-native 0.11 With keyboardevents? how to use? thanks

Check out my comment here: https://github.com/johanneslumpe/react-native-keyboardevents/issues/24#issuecomment-142209519


Fix status code checks more extensively

In testing #13, I found it's missing a case. This builds on top of #13 and handles fetching the rest of the request correctly with idiosyncratic responses.

Looks good to me.


Dropdown inside dropdown issue

I've used bootstrap-colorpicker inside another bootstrap dropdown, and it looks like it's not behaving properly. Specifically - when double clicking on the round selector it will close the top dropdown (and leave the color picker open). Same behavior when clicking in a "white" area outside the colors div.
What I've done is added this code near the end of the var Colorpicker function/constructor definition:
        this.picker.on({
            'click': function(e) {
                e.stopPropagation();
                e.preventDefault();
            },
            'dblclick': $.proxy(this.hide, this)
        });

So basically click won't propagate upwards and thus the upper drop-down will not close.
Also (and I know this is not the current behavior), I've added a double-click handler that closes the picker. This is just a suggestion though.
The reason I'm not sending this out as a pull request is that I'm not sure what is the maintainers' desired behavior in this case, so I'd love to hear what you guys think.
Thanks

@asafge Hi, any updates on this? Could you provide an example in JSFiddle to reproduce this issue ? Thanks


Jupyter Notebook in VSCode cannot be saved through'file','save' or'save as'.

Bug: Jupyter Notebook in VSCode cannot be saved through'file','save' or'save as'.

Steps to cause the bug to occur
When using Jupyter Notebook in VSCode, whether it is saved for the first time or not, it cannot be saved via'file','save' and'save as'. 'save' is gray and unavailable, and clicking'save as' has no response.
Actual behavior
'save' is gray and unavailable, and clicking'save as' has no response.
Expected behavior
We can save the Jupyter file by clicking'save as'. It is best that'save' is not grayed out and can be used.

Your Jupyter and/or Python environment
Please provide as much info as you readily know

Jupyter server running: Local
Extension version: v2020.7.96456
VS Code version: 1.47.3
**Setting python.jediEnabled:**NA
Setting python.languageServer:  Microsoft
Python and/or Anaconda version: python3.8.3; or 3.7.7; Anaconda3;
OS: Windows_NT x64 10.0.18362
Virtual environment: conda;  virtualenv

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer, @joyceerhl

This is a dupe of https://github.com/microsoft/vscode-python/issues/7903.
Our editor is not a VS code editor in that VS code knows we're opening a file. This prevents a number of commands from working correctly. #7903 addresses this issue as well as https://github.com/microsoft/vscode-python/issues/10496. When either one of these are implemented, normal file operations like Save/Save as will work for notebooks.


gobetween: 0.7.0 -> 0.8.0

https://github.com/yyyar/gobetween/releases/tag/0.8.0

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 93884 1

1 package built:
- gobetween


Add missing Armor parts to JEI tab for materials with no tool parts

I know the mod just ported to 1.19.2 and has yet to implement the new changes to the JEI tab.
I am just mentioning the current problem for materials with only armor parts.

My plan for the next release is to split the stat pages into harvest, ranged, and armor categories. Because the way I currently handle drawing the stats, I have to explicitly say that this materials has these categories which is why are is blank for now.

Thanks, also, would be possible to add a tab for the spitting fluid effects?
Here is the list: https://docs.google.com/spreadsheets/d/19Nbi-jTrhZg4zMZ8DreELWHv6SZDik5wxiz13Iqhnbw/htmlview

I'll look into later. I'm just not really sure how I would do that programmatically.

Implemented in release 1.2.0


Remove inherited undesired stylings by using css modules

Describe the bug
I was having difficulties styling my material-ui components. Its all because of the css that apply to all components js/jsx files.
Developers have to override other styles to make thier styles to get applied. searching for those styles is really tiresome.
As you know a single material ui component has lots of span elements when rendered. these span elements inherit other undesired styles form other componets. see the example below:

I am working on the broadcast page. I was trying to style my components. See that awkward margin applied on the button label. I thought it came from some margin:5px..then checked for padding:5px, then line-height, and what not😂. I wasted a lot of my time there. And at last found the culprit top:5px which was inherited by css written in carousel.css.
Additional context
Please convert all css files to css modules files. I know there are 24 css files containing stylings of class names like abc-def which would need to be converted to abcDef and so on.
Its a very tiresome process but it is worth it.
Please assign 5 people to convert 5 css files each. this is very tiresome and boring process but its worth it.
I can do 5 pages.

this is the list of those css files. So, you can assign people easily now.
! exclude app.css and index.css

you can assign me any 5

@ashuvssut : Alternative to this approach can be adding new class wrapper on each component to control styles,
say Contact us page - So component top style can start from community-about-us {community-<Component_Name>}. And this way we can wrap styles hierarchy. If there are any common styles then should be separated out and that will definitely applied on all tags - just like in your case of span button. That should be handled by component owner by increasing specificity.
This would be time saving but after effects can be there like if above mentioned e.g. of span is expected like this in any of case that would be broken. This case needs to validated on complete website.

Thanks for opening up the issue. We would preferable go with css-modules but we may require wrapper class as well from few components, where we can't explicitly define the classnames using css-module. Closing this issue for now and I will open up a new one having list of all the css files so that I can assign it to multiple people


X-Forwarded-For with proxy addresses is not handled properly

It looks like if one uses a reverse proxy in front of MMR that includes X-Forwarded-For header with possible proxy address(es), MMR does not handle that properly. I believe the issue is here: https://github.com/t2bot/matrix-media-repo/blob/85fabea54375630e4f404ff6ecc8c63fbaa28cdc/api/_routers/03-host_detection.go#L37-L45
If the raddr gets its value from the X-Forwarded-For and the header contains proxy addresses (see https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For#syntax ), then the net.SplitHostPort fails to parse it

I can fix this, but I'd like to see https://github.com/t2bot/matrix-media-repo/pull/611 merged first to avoid conflicts, as mentioned in the MMR matrix room


Cannot Load the Nodes

When installing I get this? I can't find any error in the load log apart from this:
Traceback (most recent call last):
File "H:\AI_Files\ComfyUI\nodes.py", line 1813, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 940, in exec_module
File "", line 241, in call_with_frames_removed
File "H:\AI_Files\ComfyUI\custom_nodes\ComfyUI-NegiTools_init.py", line 8, in
from .negi.open_pose_to_point_list import OpenPoseToPointList
File "H:\AI_Files\ComfyUI\custom_nodes\ComfyUI-NegiTools\negi\open_pose_to_point_list.py", line 6, in
from controlnet_aux import OpenposeDetector
ImportError: cannot import name 'OpenposeDetector' from 'controlnet_aux' (H:\AI_Files\ComfyUI\custom_nodes\comfyui_controlnet_aux\src\controlnet_aux_init_.py)
Cannot import H:\AI_Files\ComfyUI\custom_nodes\ComfyUI-NegiTools module for custom nodes: cannot import name 'OpenposeDetector' from 'controlnet_aux' (H:\AI_Files\ComfyUI\custom_nodes\comfyui_controlnet_aux\src\controlnet_aux_init_.py)

Any help on this?
I have checked that the requirements are installed...

Please try v0.3.1
This version changes to call a copy of controlnet_aux, which is expected to avoid conflicts with controlnet_aux, which comfyui_controlnet_aux has built in.
Please comment if the problem is still not resolved. Or, I will close this issue after a week has passed.

Please try v0.3.1 This version changes to call a copy of controlnet_aux, which is expected to avoid conflicts with controlnet_aux, which comfyui_controlnet_aux has built in.
Please comment if the problem is still not resolved. Or, I will close this issue after a week has passed.

Encounter new problem:
Traceback (most recent call last):
File "H:\AI_Files\ComfyUI\nodes.py", line 1813, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 940, in exec_module
File "", line 241, in call_with_frames_removed
File "H:\AI_Files\ComfyUI\custom_nodes\ComfyUI-NegiTools_init.py", line 8, in
from .negi.open_pose_to_point_list import OpenPoseToPointList
File "H:\AI_Files\ComfyUI\custom_nodes\ComfyUI-NegiTools\negi\open_pose_to_point_list.py", line 6, in
from .repos.controlnet_aux.src.controlnet_aux import OpenposeDetector
File "H:\AI_Files\ComfyUI\custom_nodes\ComfyUI-NegiTools\negi\repos\controlnet_aux\src\controlnet_aux_init_.py", line 4, in
from .leres import LeresDetector
File "H:\AI_Files\ComfyUI\custom_nodes\ComfyUI-NegiTools\negi\repos\controlnet_aux\src\controlnet_aux\leres_init_.py", line 13, in
from .pix2pix.models.pix2pix4depth_model import Pix2Pix4DepthModel
ModuleNotFoundError: No module named 'ComfyUI-NegiTools.negi.repos.controlnet_aux.src.controlnet_aux.leres.pix2pix.models'
Cannot import H:\AI_Files\ComfyUI\custom_nodes\ComfyUI-NegiTools module for custom nodes: No module named 'ComfyUI-NegiTools.negi.repos.controlnet_aux.src.controlnet_aux.leres.pix2pix.models'

me,too

Thank you for your feedback.
Release v0.3.2 fixes a bug related to import, so please check with the latest version.
Note: requirements.txt has been updated.
Please comment if the problem is still not resolved. Or, I will close this issue after a week has passed.


Do you have to load more features?

@Friend-LGA
Hi! if load more function will be custom animation for this repository，How can do that？
Jack

What kind of animations do you want?

same Animation, but as in SVPullToRefresh, Add a feature for loading more.


Add data structure note and another example

Added a note about a frequent question I had and see in the discord once in a while about why the data structure for useInifiniteQuery.
Also added an example for updating a single value in a page's data array. Sorry if that isn't written well enough, that was my best effort but I'm not that advanced yet! Feel free to edit or reject if it's not good enough and I can try again :)

:tada: This PR is included in version 3.8.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


resolve issue#54 :

How i resolve issue:

For that i use transform property in css insteads of give new size to services card.
also use transition property to make it smooth.

Thankyou @Honeshwar for your contribution:)


Still facing challenges with angular-multi-step-form and materialize modal

Can you please share with me how i can explicitly initialize angular-multi-step-form to the first step when i open the modal

Sorry I don't know what materialize modal is, I thought you meant material modal.

It's basically a modern responsive front-end framework based on Material Design http://materializecss.com/

I'm sorry but I cannot help.


vsftpd: enable seccomp

Motivation for this change
very securer ftpd
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

While at it, how do you feel about adding a nixos test for vsftpd?

Sure, I can write a basic test. Which features would you like tested that?
Starting the server, uploading and downloading a file?
Do you maybe have an example config that I could re-use for that?

What do you think about the test I've already pushed to this PR?

I suggest taking a look at some of the existing tests. It's a good way to get a feel for how to write these things.

I meant vsftpd config. This isn't my first nixos test :smile:

This isn't my first nixos test

I'm sorry man. I need more sleep.
One last thing - with nixosTests we can run the nixos tests when the package changes:
passthru = {
  tests = { inherit (nixosTests) vsftpd; };
};

We probably want this.
Thank you for your patience!


!playing or !song

It would be nice to have a !playing or !song. Not everyone knows all the songs in the backup list and sometimes chat floods the "now playing ..." message out of the way. :)

it exists, called !np

I didn't see it on the commands page. D: My bad!

Hmm...doesn't seem to work for me. I'm on the development branch.

I did a shitty implementation of it for private use. We might want it

Its an easy command to do, i'll just copy paste some code from the queue function.

Didn't even think about that. I guess it would just be !queue minus some stuff. :D


[FEATURE REQUEST] Adding a testimonials section

Description
Is your feature request related to a problem? Please describe.
As many sites have, can we add a testimonials section just above the footer.
Describe the solution you'd like
We can build cards with images and feedback.
Additional Information
Potential Implementation (optional)
We can create cards for testimonials.
Priority (optional)
It's of medium priority.

Hi! I would like to work on this issue kindly assign me this under the gssoc tag.


feat: local storage reset on new commit

also #510
Description and Motivation

Related Issues

Checklist:

[ ] I have read Migaloo's contribution guidelines.
[ ] My pull request has a sound title and description (not something vague like Update index.md)
[ ] All existing and new tests are passing.
[ ] I updated/added relevant documentation.
[ ] The code is formatted properly yarn lint.
[ ] The project builds and is able to deploy on Netlify yarn build.

@worrex i dont think thats possible with this implementation because the file with the version is static and only updates on reload


e2e matmul testing for compilation infos on gpu

Integrates e2e matmul testing for GPUs; intended to test the compilation verifiers for LLVMGPUMatmulSimt and LLVMGPUMatmulTensorCore pass pipelines.
Changes mainly to generate_e2e_matmul_tests.py: In order to support GPU testing apart from CPU:

ShapesId::GPU_LARGE option to --shapes for gpu shapes
--compilation_info allows to specify the compiling pass pipeline for generated test cases and compilation infos

GPU tests make use of additional compilation info attrs added during generation. These are committed with other tests (--compilation_info=none)

@GMNGeoffrey the bazel build keeps triggering here for the cuda test even with the flags you mentioned. No idea how to restrict it.

There are some failures on Turing build, it looks like this is compiling through TensorCore pipeline with a sm lower than 80. TensorCore pipeline requires "--iree-cuda-llvm-target-arch=sm_80" option and cannot run on Turing so we should disable the run until we upgrade to Ampere.


[BUG] There is no way to cancel the file syncing when the caller becomes invalid

Describe the bug
For backing image manager, if a backing image is removed during the file syncing, the syncing goroutine cannot be stopped or cancelled.
To Reproduce
Steps to reproduce the behavior:

Deploy backing image managers for 2 nodes.
Enter into the 1st manager pod, pull a backing image from the remote.
Limit the bandwidth of the 1st manager pod so that it won't syncing the backing image file in several seconds.
Enter into the 2nd manager pod, start file syncing from the 1st pod.
During the file syncing, directly delete the syncing backing image. --> The file syncing is still running. (To check if the syncing is still running, you may need to manually add some debug logs or enable trace logs.)

Expected behavior
The file syncing should be cancelled once the backing image is removed.
Log
[backing-image-manager-bpf2q] time="2021-03-29T03:20:40Z" level=debug msg="Backing Image: updating processed size to 917504" component=backing-image hostDir=/var/lib/longhorn/backing-images/bi-test-uuid-bi-test name=bi-test senderManagerAddress="<IP_ADDRESS>:8000" url="https://cloud-images.ubuntu.com/minimal/releases/focal/release-20200729/ubuntu-20.04-minimal-cloudimg-amd64.img" uuid=uuid-bi-test workDir=/data/backing-images/bi-test-uuid-bi-test

[backing-image-manager-bpf2q] time="2021-03-29T03:20:42Z" level=info msg="Backing Image Manager: prepare to delete backing image" backingImage=bi-test component=backing-image-manager diskPathOnHost=/var/lib/longhorn
[backing-image-manager-bpf2q] time="2021-03-29T03:20:42Z" level=info msg="Backing Image: start to clean up backing image" component=backing-image hostDir=/var/lib/longhorn/backing-images/bi-test-uuid-bi-test name=bi-test senderManagerAddress="<IP_ADDRESS>:8000" url="https://cloud-images.ubuntu.com/minimal/releases/focal/release-20200729/ubuntu-20.04-minimal-cloudimg-amd64.img" uuid=uuid-bi-test workDir=/data/backing-images/bi-test-uuid-bi-test
[backing-image-manager-bpf2q] time="2021-03-29T03:20:42Z" level=info msg="Backing Image: cleanup succeeded" component=backing-image hostDir=/var/lib/longhorn/backing-images/bi-test-uuid-bi-test name=bi-test senderManagerAddress="<IP_ADDRESS>:8000" url="https://cloud-images.ubuntu.com/minimal/releases/focal/release-20200729/ubuntu-20.04-minimal-cloudimg-amd64.img" uuid=uuid-bi-test workDir=/data/backing-images/bi-test-uuid-bi-test
[backing-image-manager-bpf2q] time="2021-03-29T03:20:42Z" level=info msg="Backing Image Manager: deleted backing image" backingImage=bi-test component=backing-image-manager diskPathOnHost=/var/lib/longhorn

[backing-image-manager-bpf2q] time="2021-03-29T03:20:43Z" level=debug msg="Backing Image: updating processed size to 1048576" component=backing-image hostDir=/var/lib/longhorn/backing-images/bi-test-uuid-bi-test name=bi-test senderManagerAddress="<IP_ADDRESS>:8000" url="https://cloud-images.ubuntu.com/minimal/releases/focal/release-20200729/ubuntu-20.04-minimal-cloudimg-amd64.img" uuid=uuid-bi-test workDir=/data/backing-images/bi-test-uuid-bi-test
[backing-image-manager-bpf2q] time="2021-03-29T03:20:45Z" level=debug msg="Backing Image: updating processed size to 1179648" component=backing-image hostDir=/var/lib/longhorn/backing-images/bi-test-uuid-bi-test name=bi-test senderManagerAddress="<IP_ADDRESS>:8000" url="https://cloud-images.ubuntu.com/minimal/releases/focal/release-20200729/ubuntu-20.04-minimal-cloudimg-amd64.img" uuid=uuid-bi-test workDir=/data/backing-images/bi-test-uuid-bi-test

Environment:

Longhorn version: v1.1.0
Installation method (e.g. Rancher Catalog App/Helm/Kubectl):
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version:

Number of management node in the cluster:
Number of worker node in the cluster:

Node config

OS type and version:
CPU per node:
Memory per node:
Disk type(e.g. SSD/NVMe):
Network bandwidth between the nodes:

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal):
Number of Longhorn volumes in the cluster:

Additional context
I can add cancelled context for the syncing call.

Test step:

For convenience, manually launch the backing image manager pods:

apiVersion: apps/v1
kind: DaemonSet
metadata:
  labels:
    app: backing-image-manager
  name: backing-image-manager
  namespace: longhorn-system
spec:
  selector:
    matchLabels:
      app: backing-image-manager
  template:
    metadata:
      labels:
        app: backing-image-manager
    spec:
      containers:
      - name: backing-image-manager
        image: longhornio/backing-image-manager:master
        imagePullPolicy: Always
        securityContext:
          privileged: true
        command:
        - backing-image-manager
        - --debug
        - daemon
        - --listen
        - <IP_ADDRESS>:8000
        readinessProbe:
          tcpSocket:
            port: 8000
        volumeMounts:
        - name: disk-path
          mountPath: /data
      volumes:
      - name: disk-path
        hostPath:
          path: /var/lib/longhorn/
      serviceAccountName: longhorn-service-account

Download a backing image in the first pod:

# alias bm="backing-image-manager backing-image"
# bm pull --name bi-test --uuid uuid-bi-test --download-url https://cloud-images.ubuntu.com/minimal/releases/focal/release-20200729/ubuntu-20.04-minimal-cloudimg-amd64.img
# bm ls

In the 2nd pod, limit the bandwidth first so that the downloading won't be done within several seconds

tc qdisc del dev eth0 root
tc qdisc add dev eth0 root tbf rate 500kbit latency 0.1ms burst 1000kbit

Then start to get the backing image file from the 1st BIM pod

# alias bm="backing-image-manager backing-image"
# bm sync --name bi-test --uuid uuid-bi-test --download-url https://cloud-images.ubuntu.com/minimal/releases/focal/release-20200729/ubuntu-20.04-minimal-cloudimg-amd64.img --size 208601088 --from-host <the IP of 1st BIM pod> --to-host <the IP of 2nd BIM pod>
# bm ls

During the syncing, directly deleting the downloading backing image in the 2nd pod

# bm delete bi-test

Wait 1 minute and check the log of the 2nd pod. Make sure there is no download/sync (failure) related logs after the deletion. Then restarting sync without deletion, the backing image can be downloaded successfully.

The manual test step. Not sure if I can update the test doc during RC:

I think you should just update the test doc as usual no matter what status is right now.
cc @khushboo-rancher @meldafrawi

Verification Pass
Longhorn master 04/19/2021
Steps: https://github.com/longhorn/longhorn/issues/2416#issuecomment-819468844


Github pre-commit no longer working

With the change to using redis the pre commit structure needs to change to work with the new architecture

done


Ensure monit stays up

Since we rely on Monit for most of our AppServers and Services, we need
to make the best effort to keep it running in spite of OOM and similar
conditions.

OCD run https://ocd.appscale.com:8080/job/Daily Build/2386/


Accessibility feature to "rate limit" button presses

https://gameaccessibilityguidelines.com/include-a-cool-down-period-post-acceptance-delay-of-0-5-seconds-between-inputs/

boy oh boy I have no idea how to do this

consume until timeout ?

anti-buffer, n’est pas ?

https://gameaccessibilityguidelines.com/include-a-cool-down-period-post-acceptance-delay-of-0-5-seconds-between-inputs/


Support setting Multus default network via annotations.

What this PR does / why we need it:
Adds support for setting the default network in Multus via annotations. https://github.com/intel/multus-cni/pull/174
This is useful if you want to separate VM pod networks from the default pod network.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Depends on #1806
Release note:

Adds support for setting the default network in Multus via annotations.
action required: A version of the Multus cni that supports default via annotations.

Hello contributor, thanks for submitting a PR for this project!
I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.
In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

Type ci test please on this PR to trigger automated tests for it.
Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically.
If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

/hold

Hi @greg-bock,
Thanks for the PR!
Can you please add more details on the PR Description?
Can you please provide a use-case for this?

@SchSeba

Can you please provide a use-case for this?

I expanded on the previous use-case provided.

Can you please add more details on the PR Description?

I added a bit more information. Let me know if there is anything else you have questions about.
I plan on doing doc updates once my other PR is finished.
Note that this branch is  branched from another PR I have going (#1806). To see what is really changing: compare

@greg-bock  Thanks for adding more comment into the description
I just have one question.
we have the ability to create a vmi without the pod network. (yes the pod will have the eth0 connected to the k8s network but not the VMI)
The VMI will only see the interfaces configured in the yaml
example:
this vmi will only have eth0 and it will be connected using the PTP cni plugin.
apiVersion: kubevirt.io/v1alpha2
kind: VirtualMachineInstance
metadata:
  creationTimestamp: null
  labels:
    special: vmi-multus-ptp
  name: vmi-multus-ptp
spec:
  domain:
    devices:
      disks:
      - disk:
          bus: virtio
        name: containerdisk
        volumeName: registryvolume
      - disk:
          bus: virtio
        name: cloudinitdisk
        volumeName: cloudinitvolume
      interfaces:
      - bridge: {}
        name: ptp
    machine:
      type: ""
    resources:
      requests:
        memory: 1024M
  networks:
  - multus:
      networkName: ptp-conf
    name: ptp
  terminationGracePeriodSeconds: 0
  volumes:
  - containerDisk:
      image: kubevirt/fedora-cloud-container-disk-demo:latest
    name: registryvolume
  - cloudInitNoCloud:
      userData: |
        #!/bin/bash
        echo "fedora" |passwd fedora --stdin
    name: cloudinitvolume
status: {}

please tell me if this achieve the same usage of this PR


Allow loading configuration from .env files. #229

Closes #227
The changes in this PR will now allow configuring pinnwand through a .env file.
The configuration in the .env file will not take precedence over its equivalent in the system's environment.

Strange, the test suite passed locally when I launched it.
I don't seem to understand what exactly is happening right now, I'll have a look later.


569 homepage announcements

I changed the scale and breakpoints for the register banner, past pycon image carrousel, and announcements banner so the transitions are smoother and content doesn't get cut off.

+1

Fixes #569.


[PYIC-2899] Check if VC expected

Proposed changes
What changed
Added check that async return of VC is expected by verifying the F2F OAuth session state against the initial F2F CRI response.
Why did it change
Integration of F2F in IPV Core.
Issue tracking

PYIC-2899

Checklists
Environment variables or secrets

No environment variables or secrets were added or changed

Other considerations

PR superseded: closing


Importing a route is kinda useless

I tried importing a previously created route, in hopes to make some tweaks. Nope. When I import a route, it's just sort of there. It's just decoration. Can't do anything with it. Would be nice if I could click it and change the start/finish points or something.

I guess you used “Load Tracks” instead of “Load Tracks as Route”. While the former feature just create a “dumb” overlay, the latter creates a fully customizable route.
Besides that: the proper way to work on previously created routes is to use the permalink, i.e. the link from the browser's address bar as it contains all information to fully define a route.
Hope that helps.

Ah right, I see.
In my mind an export-and-then-import ideally shouldn't loose information, and when using KML it doesn't need to either. I think the important bit is the waypoints used to tweak a route, and it might be possible to include those in a KML export as some kind of vendor-specific metadata.
As for the "dumb overlay" as you call it, I still fail to see what the intended purpose of such a feature is. Maybe only if this tool is used for presentation purposes, but even then I'd expect a tooltip on an imported route at the very least.

In my mind an export-and-then-import ideally shouldn't loose information

Saving and reloading routes is not yet implemented, see #16.

As for the "dumb overlay" as you call it, I still fail to see what the intended purpose of such a feature is.

This is mostly meant for GPS recordings, e.g. to see where you previously have or have not yet been and to manually plan a new route with a previous trace as a guide in the background. Yes, this is still very basic with lots of room for improvements, but well...


fix: parent thread disappears in LHN when deleting the thread first chat

Details

Parent thread disappears in LHN when deleting the thread first chat
Fixed Issues

$ https://github.com/Expensify/App/issues/26791
PROPOSAL: https://github.com/Expensify/App/issues/26791#issuecomment-1716867488
Tests

Open any report
Send a message
Reply in the thread of this message. Name it thread 1
In thread 1 send a message and reply in the thread of this message. Name it thread 2
In thread 2 delete the thread first chat that is the parent action of thread 2
Verify that the thread 1 is not deleted

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Open any report
Send a message
Reply in the thread of this message. Name it thread 1
In thread 1 send a message and reply in the thread of this message. Name it thread 2
In thread 2 delete the thread first chat that is the parent action of thread 2
Verify that the thread 1 is not deleted

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/129500732/cb129e07-de9f-46e2-bab4-4a483d64d214

Mobile Web - Chrome
https://github.com/Expensify/App/assets/129500732/30cd2059-a2a7-4e49-842a-47ccc7b21672

Mobile Web - Safari
https://github.com/Expensify/App/assets/129500732/cd255d80-12fb-4b61-b672-838273b6a192

Desktop
https://github.com/Expensify/App/assets/129500732/b2fb3cc6-784f-4892-b9dd-7bf68628b0ed

iOS
https://github.com/Expensify/App/assets/129500732/c57d9daf-e834-453e-b3f8-7bfba6905aba

Android
https://github.com/Expensify/App/assets/129500732/0f731918-9f34-4b67-82eb-8669eb3033ce

@dukenv0307 seems something happened after merging main - you got 79 file changes....

@dukenv0307 issue seems not fixed on android WEB
https://github.com/Expensify/App/assets/28352309/2c725579-9489-4335-bb15-a59caa3418e9
second 0.51 - we have 2 items in left menu which related to current flow

When we remove 2 thread - 1.34 timing - we still see 2 items - deleted and main one - but we do not see first thread

If we open again all threads one by one - and go back (2.08) - we will see 3 of them as expected

Same issue on desktop
https://github.com/Expensify/App/assets/28352309/3b370a68-5d23-49e8-995a-99fb02930548

And also not working on native apps - if after removing item - you will click go back and not clicking on header to navigation to next screen

@dukenv0307 i see - but should it be automatically not moved to the end? maybe this is an issue too - because user expect to the all items related to conversion closely to each other

but should it be automatically not moved to the end? maybe this is an issue too - because user expect to the all items related to conversion closely to each other

@narefyev91 We sorted the report in LHN here by lastVisibleActionCreated and when we delete the last action lastVisibleActionCreated is updated in BE, so it's hard to do this.
https://github.com/Expensify/App/blob/01c5b71e8f9d3385a583d669b98579a02936f867/src/libs/SidebarUtils.js#L158

Yup - but why does web working as expected in this situation? With code fix - web starts working as needed - but we have issues with other platforms...

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/28352309/79be0c92-c6e0-4e1e-a790-00c72a33ebf0

Mobile Web - Chrome
https://github.com/Expensify/App/assets/28352309/0a8794c0-4e4f-4089-bb80-3ed7fba027ee

Mobile Web - Safari
https://github.com/Expensify/App/assets/28352309/971bf905-9eff-4852-8064-1070a0fc5d95

Desktop
https://github.com/Expensify/App/assets/28352309/c49acfc4-1cb9-4dfd-99b4-262b79eb2e74

iOS
https://github.com/Expensify/App/assets/28352309/c94e2844-bf6c-4845-9ec6-61306538bf5a

Android
https://github.com/Expensify/App/assets/28352309/e58246b7-55ef-4ce9-9f1f-481c7d33bbb0

Yep, moving the thread lower is fine

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.72-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.72-11 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Toggle to repeat notification when timer ends until acknowledged

Issue:
Notification sound plays once, but is easily ignored if one is deeply focused.
Solution:
Implement a toggle that, when enabled, will repeat the notification sound when the timer is finished until the user acknowledges it on the device.

+1

As an alternative, I included all system sounds to the notification option.


Question about the  lr_drop in DETR based experiment

It seems the  lr_drop is missing in the pretraining and finetune script.
The default  lr_drop  for DETR is 200, but the pretraining is only 60 epochs,  so   lr_drop  is possible missing.

I think the defaults should be ok. For DETReg using Deformable-DETR on IN1k I did not try lr dropping (just 5e pretraining).  Similarly, for DETReg using DETR on IN I didn't lr drop. On IN100 where I reported some results on the paper, I've lr dropped after 40e and train for 50e.


Migrations: reset & improvements

Migration Refactoring
Migrations need revisiting for the alpha, they've currently effectively been removed, only a fresh DB population will work. We are going to refactor some parts of our migration system. The goal is to extract the execution of migration out of Ghost. The Ghost-CLI tool will help us achieving our goal.
Using third party tools
https://github.com/db-migrate/node-db-migrate
Cons:

https://github.com/db-migrate/node-db-migrate/issues/410

http://knexjs.org/#Migrations
Pros:

transactions are configurable, which is nice (config.transacting=true)
can be used via shell out of the box

Cons:

how to make a backup before running the migrations?
how to execute from JS level?

We already have a full working migration system, i personally don't see any reason to switch to a third party tool. Migration functionality like seed, create, up, down are in general not hard to implement. The whole wrapping logic around is important.
I am open for opinions. We can also make an experimental testing with knex migrate!
Creating the database
Right now Ghost never controlled creating the database (in case of mysql).
I would love to get support for that.
So before populating the database (see next section), we could execute a command schema.commands.createDatabase (notation might change).
Mysql will execute a raw query to the database, sqlite3 will just skip.
We can control with which encoding we create the database. If database exists, it just skips.
Populating the database
When Ghost-CLI installs a Ghost Version and starts Ghost, it can use an internal Ghost-CLI command before starting the application to check if the database is initialised. This command can be used as single shell command as well.
ghost db —init
Will create all needed tables.
If database is already populated, it just throws/shows an error.
The code for running db —init will still live in Ghost.
So it's for now actually a shortcut for node core/server/data/migration/bin/runner (or similar).
Running populations in a transaction
We need that. We had trouble in the past, that a database was in a broken state, because a container was destroyed while running the populations. (already PR'd). This is also important for LTS . Does not work in mysql, but we have a workaround PR for it.
Seed the database
In Ghost we have a set of initial data, which we call fixtures. (Welcome post, owner, permissions). This can/should be treated as a migration. It is the first migration for Ghost.
Running migrations
Options for inter process communication:
Fork process and communicate via node communication channel.
https://github.com/weixiyen/messenger.js
https://github.com/RIAEvangelist/node-ipc
When Ghost-CLI starts Ghost, it can receive an event.
Ghost can trigger an event like process.emit('started') (or similar) , which Ghost-CLI listens on. So when Ghost is started, Ghost-CLI can execute an internal command to execute migrations. This command can be used as single shell command as well.
Ghost-CLI executes the migrations and if migrations needs to happen, it will send an event to the Ghost child process to boot into maintenance mode.
If finished, it will send another event to boot into normal mode.
The whole inter process communication is for now optional, we can also just hack it so it works.
ghost db —migrate
(or even ghost db —migrate —version XXX )
Database versions
Right now we have used the naming pattern 001 - 00X .
Database versions and Ghost source code are very tide together.
Each Ghost Version depends on a specific database schema. So there is only a handful database versions per Ghost Version.
I would keep numbers, but extend/change them a bit:
1.0-1 - is the first migration for Ghost Version 1.0.X
1.0-2 - is the second migration for Ghost Version 1.0.X
1.1-1 - is the first migration for Ghost Version 1.1.X
We don't do migrations for patch updates, so we don't need the whole Ghost version.
Combine fixtures and normal migrations into one folder.
Yes i think that is a good idea.
Make Ghost updates smarter!
Right now, if an error occurs while updating from 1.0.0 to 1.10, your database rolls back to 1.0.0-2 and you cannot start Ghost anymore in worst case.
This can be avoided by making the update process different:
When updating a Ghost Version via Ghost-CLI (ghost update ), we are building a new folder with the new version next to your current version.
We copy the database (in case of sqlite), the config files and the content folder. Then Ghost-CLI will bring the current (!) process into maintenance mode to avoid getting new data. Then Ghost-CLI will execute the migrations on the new folder, if available. If it was successful, the new current version is the new Ghost Version. If it was not successful, database commands rollback and current version stays. So the blog will still run in old version without any trouble and same source code.
Auto updates for Ghost: In case of auto updates, this strategy won't work.
Migrate down?
You have Ghost running with version 1.5.0. And you would like to use your current database with Ghost 1.4.0. So if you install Ghost 1.4.0 and you copy the database of 1.5.0, it should downgrade the database. So each migration file get's an up and down function. That is an optional idea.
Architecture changes?
Basically not so much will change. The biggest change is executing migrations and population from outside and making fixtures being a migration We will tidy up the files a bit (fixtures, bootup etc). Effort is still 2-3 days to have everything in place.
Tasks:

[x] Running database population in a transaction
[x] Reset migrations (remove all old migrations)
[x] Change the versioning
[x] add migration runner
[x] seeding
[x] populate tables
[x] knex-migrator migrate
[x] reset/backup
[x] knex-migrator as npm
[x] integrate with Ghost-CLI
[x] integrate knex-migrator into Ghost completely
[x] look for kate-migrations in the code
[x] remove old migrations code 🕵🏻
[x] look at https://github.com/TryGhost/knex-migrator/issues/13
[x] test import/export database
[x] hooks audit
[x] rename .knex-migrator file
[x] revert https://github.com/TryGhost/Ghost/pull/7591
[x] look at https://github.com/TryGhost/Ghost/issues/7615
[x] fix https://github.com/TryGhost/knex-migrator/issues/26
[x] simulate using the old migration tasks with knex-migrator
[x] think about a nested folder "upgrades" and then have nested folders for each version

@acburdine I would like to hear your opinion :)

@kirrg001 have created this as an issue so that we can start to document what is gonna be done - feel free to edit it with tasks and details 👍

Ok, I think the issue makes sense. Here are my initial thoughts:

knex migrations have a JS api (see an example of its use here)

not sure if that changes the idea around a third-party system at all, but regardless felt like it was worth mentioning :)

having the ghost-cli process listen into the ghost running process creates some complications

At the moment, ghost-cli (more specifically the local process manager) uses a detached child process to run Ghost. By doing so, the ghost-cli process is allowed to exit and leave ghost to do its thing. Implementing this particular way of having the CLI run migrations means two things:

the CLI process would have to continuously run alongside of Ghost (which complicates automatic updates, unless auto updates were done based on an emitted event)
more importantly, this would mean that there would have to be one specific way of actually running ghost in order to have the process-to-process communication channel (which would be difficult to do with systemd/pm2/forever/etc)

On 3rd party solutions:
The major downside to knex migrations is that it requires you to cycle through the migrations step by step in order to create a fresh DB. This is designed for long-running single-install software, rather than mass distributed & installed software like Ghost. If we switched to knex migrations in its current form, fresh installs would get slower and slower as time went on.
Additionally, as much as I like the idea of knex seed files, knex only supports the concept of there being one seed. Which is kind of annoying, because I could see us using it for both the original DB seed, and for seeding various tests.
Those are my two major reasons for not switching to it. I wrote some more stuff in this issue ages ago but I'm leaning towards keeping our tailor-made solution, after all we have it now and it doesn't need much.

On how the Ghost-CLI will interact with migrations,
The steps for the cli would be something like:

install the new version of ghost
before switching the versions over, use a predetermined method to see if a migration is required
if no, switch. Done!
if yes, then:
restart the current Ghost process with the maintenance mode flag
run the migration
then switch, starting the new process in normal maintenance mode
if something goes wrong with the migration, start the old ghost version in normal mode, and show an error to indicate the upgrade failed

The addition of a Process.emit() on startup is a nice-to-have so that the CLI can tell if everything is ok or not.
This leaves 2 slightly tricky things:

how to determine if a migration is needed
how to run a migration

Other things:

migrate down is a 👎  from me, I think it is an edge case and just IMAGINE the manual testing you'd need to do. Also, no one has ever asked for it 😉
new versioning is 👍
Combine fixtures and normal migrations into one folder 👍

Thanks @ErisDS !

how to determine if a migration is needed && how to run a migration

Maybe the easiest way for now: Just ignore if a migration needs to happen or not. Bring the current process into maintenance mode (restart + forward the maintenance flag as env param). Add a timeout of 2-3 seconds to ensure the process runs. Then run the migration runner of the new version (just a spawn of core/server/data/migration/runner for example). The migration runner won't run a migration if there is no one. Wait for the exit command of the migration runner.

The existing LTS branch has something like this, where every upgrade triggers maintenance mode. The issue I'm seeing with it, is that the first request from the blog almost always returns 503.
We could optimise by assuming that if it's a patch update there's definitely no migration to run?

We could optimise by assuming that if it's a patch update there's definitely no migration to run?
Yes can do and add more optimisations later 👍

Regarding: Running populations in a transaction
It turned out it won't work for mysql, see http://stackoverflow.com/questions/4692690/is-it-possible-to-roll-back-create-table-and-alter-table-statements-in-major-sql

Regarding Database versions:
I think we can ignore the number of migrations at the end of the database version. So instead of 1.5-3, we just store 1.5.
Let's assume a Ghost Version 1.5 has 3 migration scripts. If an error occurs on the second script, it will rollback anyway to 1.4. So it might not be useful to store the number.

Folder structure for database versions:
1.1

1-file
2-file

1.2

1-file
2-file

For the Migration could I just install the new Ghost and upload my theme and content folder and import the Content file via the admin panel.

@ItsMohammad for questions like this, I highly recommend swinging by our slack channel. This is an issue about writing a new database migration tool - that is adding and removing fields from the database, nothing to do with migrating between old & new Ghost versions. You can also read more about what we're doing in the new "alpha" version of ghost on our dev blog and in the alpha guide. TLDR; there is currently no migration path to the alpha version of Ghost because it's not finished yet.

Regarding importing/exporting databases and migrations table
I thought about it a while and there is nothing to change/add in my opinion.
Knex-migrator works like this:
If your blog was initialised with ghost version 1.5, it will never execute a migration script from an older version (< 1.5).
If you import a JSON file from ghost version 1.2 and we would import the migration scripts, knex-migrator doesn't care about these entries, because the blog was initialised with 1.5. See https://github.com/TryGhost/knex-migrator/blob/master/lib/index.js#L476
Because we insert the imported data via our model layer, all data changes should be adapted automatically. Except of we have added a new field with a constraint, but i am pretty sure LTS can't handle this case.
If you import a JSON file from ghost version 1.9 and we would import the migration scripts, knex-migrator would throw an error, because you have migrations in your database, which do not exist on file system.
I have a branch ready, which can import migrations, just in case we need it.

See https://github.com/TryGhost/knex-migrator
Closing this now. If we encounter any bugs, we can raise new issues.


Improve single language detection when words in other languages are quoted

When I put in german sentences with japanese words quoted then it might happen, that lingua claims it's 100% japanese.
For example:
Wir stoßen an: "かんぱい". Er lächelte.   (in english, if you are interested: »We toasted: "kanpai". He smiled«) leads to a ConfidenceValue of 1.0 of japanese. While Wir stoßen an. Er lächelte.  has a ConfidenceValue of 0.6014287047855706 for german and 0.0 for japanese (I included all languages for detection).
The expected result in both should be german, maybe with slight japanese confidence in the first case since a japanese word is quoted but it should not be 100% japanese.

Thanks for reaching out to me. I will try to improve language detection for inputs like yours, even though it's not a trivial problem to solve.

@pemistahl If you could point me in the general area I could look at a few options to test adding this feature.


LocalIdSearchPrefix

Traceback (most recent call last):
File "C:\Users\Falcom\AppData\Local\Programs\Python\Python310\lib\tkinter_init_.py", line 1921, in call
return self.func(*args)
File "C:\Users\Falcom\Desktop\PalworldSaveTools.v0.8.6\character_transfer\char-export.py", line 770, in main
target_guid = find_id_match_prefix(target_dynamic_container['ID']['value'],

contex: the original save is from a friend, "Skathach", he is the original co-op host, we play on the Gamepass version of the game, that version has no "level.sav" , but using save extractor found that the file in "Level\01.sav" are stored all the current users. but I.E: if want to import all data from "BigRed" to "coni90" (the one selected, disregard the other one), it goes all ok until the text i cuote.
im so sorry, had the server tab open and ended submiting this in the whrong place, i deeply apologize.

Can you retry the steps with v0.8.7 just in case?
I'll take a look into this soon.

PalworldSaveTools.v0.8.8.zip
Kindly try this fix for me please.

PalworldSaveTools.v0.8.8.zip
Kindly try this fix for me please.

success ... kinda.
no bases , i still have my items, but my weapons doesnt reload. no pals in party.

It doesn't transfer bases/pals that are on bases. It does transfer your items/party pals/palbox pals.
Doesn't reload? No pals in party? I'll need to take a look into these two.

It doesn't transfer bases/pals that are on bases. It does transfer your items/party pals/palbox pals.
Doesn't reload? No pals in party? I'll need to take a look into these two.

i see, at least its a star, how should i transfer bases and pal and etc, i see there is a tutorial on steam saves, but no on gamepass version structure.

That's typically for local host to dedicated server. But you can try if you want to. Both are "similar", but the platforms are different.

Just tried it myself.
Party pals are intact in my party.

I'll take a look at guns now.

Seems to be fine to me here?

 Seems to be fine to me here?
here i recorded said vehaviour:
https://drive.google.com/file/d/1GfcrRWBNmO5wgXFipTXm2MACi5vnyEHZ/view?usp=sharing

here the original save that im using to transfer the characters from:
https://drive.google.com/file/d/1seQ6fkCJudnq7TmWxv8lVzuZeHnxcvRb/view?usp=sharing

That's apex game you're recording?
Also, the saves should be separate.
First save in first location should have Level.sav and Players folder
Second save in second location should have Level.sav and Players folder.

That's apex game you're recording?
Also, the saves should be separate.
First save in first location should have Level.sav and Players folder
Second save in second location should have Level.sav and Players folder.
Then it might not work very well for gamepass version(xbox platform). Sorry for the inconvenience. :(

i dont understand what apex stand for haha . yes, i see that apparently has issues w the saves, but is there going to be any support for gamepass version in the future at least? it would be a shame that only could be for steam tbh. the tool looks very promising and usefull in so many aspects. :(

That's apex game you're recording?
Also, the saves should be separate.
First save in first location should have Level.sav and Players folder
Second save in second location should have Level.sav and Players folder.
Then it might not work very well for gamepass version(xbox platform). Sorry for the inconvenience. :(

i dont understand what apex stand for haha . yes, i see that apparently has issues w the saves, but is there going to be any support for gamepass version in the future at least? it would be a shame that only could be for steam tbh. the tool looks very promising and usefull in so many aspects. :(

https://drive.google.com/file/d/1GfcrRWBNmO5wgXFipTXm2MACi5vnyEHZ/view
You posted this link. It takes me to apex game video?

That's apex game you're recording?
Also, the saves should be separate.
First save in first location should have Level.sav and Players folder
Second save in second location should have Level.sav and Players folder.
Then it might not work very well for gamepass version(xbox platform). Sorry for the inconvenience. :(

i dont understand what apex stand for haha . yes, i see that apparently has issues w the saves, but is there going to be any support for gamepass version in the future at least? it would be a shame that only could be for steam tbh. the tool looks very promising and usefull in so many aspects. :(

https://drive.google.com/file/d/1GfcrRWBNmO5wgXFipTXm2MACi5vnyEHZ/view
You posted this link. It takes me to apex game video?

im so sorry , the drive was in list view so coudnt see the preview and sent whron gameplay haha my apologies
https://drive.google.com/file/d/1pbcEHWjVlmp__aTRXp_ZityXKwkvb5B3/view?usp=sharing

No problem. Yeah, I see it. I think it may have to do with different structures on Xbox vs Steam.


"Public Holidays" for Life Pharmacy St Lukes is cut-off

Describe the bug
"Public Holidays" text for Life Pharmacy St Lukes is cut-off
To Reproduce
Steps to reproduce the behavior:

Go to website
Find Life Pharmacy St Lukes in Open Today
Observe Public Holidays

Screenshots

Additional context
Props to @geeksteph for spotting this.
Might be a data issue...

Looks like a simple fix within the vaxxnzlocations repo.
Just need to handle the colon string splitting logic.
This entry contains multiple colons within the text data, and we only want to split on the first colon. Since the first colon has a space padding after it (eg. "Public Holidays: blah blah blah..."), we can switch the logic to split on ": " instead of ":". The remaining colons present are associated to times, so they won't be split on as they don't have a space following them.
Will send through a PR for this in the other repo.

This should be fixed next time cron job is run 🙏🏻  (i tested it, i hope it works in prod)

@noway Looks like we can close this issue now!


Nullable enums

Exception when downloading one or many entities that contains nullable enums.
Ok if all of those rows are set to null. Exception occurs if any of them has a value other then null.
Exception
System.AggregateException: One or more errors occurred. ---> System.ArgumentException: Object of type 'System.String' cannot be converted to type 'System.Nullable`1[TEMCommon.Enums.Units]'.
Entity
EntityType Name="Set">
Key>
PropertyRef Name="GUID"/>
Key>
...
Property Name="QualityUnit" Type="TEMCommon.Enums.Units"/>
...
/EntityType>
Nullable enum
EnumType Name="Units" UnderlyingType="Edm.Byte">
Member Name="Position" Value="0"/>Member Name="Speed" Value="1"/>
Member Name="Acceleration" Value="2"/>
Member Name="Force" Value="3"/>
Member Name="Power" Value="4"/>
Member Name="Time" Value="5"/>
/EnumType>

Thank you for the issue report. It's fixed now and will be released as a part of version 4.20.

Fixed in 4.20.


vue3-view360 - 4.0.0-beta.7 (next) is not working in production build but working in development mode.

Description
When using vue 3 with composition api it's not working on production build while in development mode works fine.
Using "@egjs/vue3-view360": "^4.0.0-beta.7".
Steps to check or reproduce
 <View360 class="is-16by9 view360"  :projection="projection"  ref="viewer" @dblclick="handleDoubleClick">
...
 import { View360, EquirectProjection, EVENTS, ProjectionChangeEvent, LoadStartEvent } from '@egjs/vue3-view360'
 import<EMAIL_ADDRESS>
export default defineComponent({
  name: 'image-view-360',`
  components: {
    View360
  },
  setup (props) {
    const viewer = ref(null) as any
    const handleDoubleClick = (evt) => {
      console.log('viewer', viewer)
    }
    return {
        viewer
    }
  }
}

The properties of viewer.value are all undefined when building for production like shown bellow:
https://ibb.co/D7xfzt3
But when building in development all the properties are there
https://ibb.co/T2bRGV5
We are not using any special build conditions, just the default yarn build which is mapped to vue-cli-service build --mode=development or production.
What are we doing wrong ?
Any help would be appreciated.
Thanks

I am also having this issue, but with Vite. I thought I was doing something wrong but glad to see I wasn't.

Workaround:
You can still access those properties and methods but under different path like this: viewer.value._.data.view360.
This shouldn't be the right way, though.

Thanks @fpuncea!
For me it was viewer._.data.view360 but it now works as it would normally.
But as you say, this shouldn't be needed.

@fpuncea @Tom-revere
Both dev and production are buggy.
It is normal that only projection has a value.
I will be fixed soon.
And can you try to access it with viewer.value.view360?

Since there is no further comment, we will close the issue.


ci: migrate to cargo-nextest

Motivation
CI tests are slow, to speed things up a bit it would be good to get information on specific tests and also speed things up a bit
Overview
I use the cargo-nextest plugin, to run tests, it will provide more information in Action

Please check Checks for this PR for understand the differense


gyp ERR! stack Error: make failed with exit code: 2

gyp ERR! stack Error: make failed with exit code: 2

Share a screenshot.
Or check your internet connection

Full page screenshot
https://ibb.co/NjNg0gn

Link isn't working...

https://i.ibb.co/LtgDTDh/Screenshot-20230319-100625-Termux.jpg

Yeah got it.
There 3 user have already reported this issue and they all uses same termux designing script (mayTermux/myTermux) , so i think this is the problem with it. You can wait for new version, i am making a standalone for it so it can run any termux , specially on these.
Thanks for reporting ❤❤

I'm waiting
Thanks ❤

Issue fixed


Show required vs. Optional Fields

We should users what is required and what is optional.
https://www.figma.com/proto/CEzBM8kUw8LyWdfAhUThYb/Engineering-Ready-Prototype?node-id=47%3A5&scaling=scale-down

Can we do something as a stopgap like put a * in the label for required fields? This would just as a way to get our designers more time to come up with an actual solution.

@hmyers-cms and I discussed this AM and propose the following:

[ ] Mark required fields with red asterisks
[ ] Mark optional fields with (optional) at the end of the field description
[ ] Remove opt-out response choices for optional fields (i.e. "Prefer not to answer")
[ ] Add key at top of survey (e.g. All fields marked with * are required)

Question for @aliciabeckett-gov: Should we prevent submission if there are missing required fields?
Working on updating the designs to reflect these ideas, but want to get these out there for feedback first.

Apologies - I forgot to add this to the ticket, but the design changes are reflected in the engineering-ready prototype.

Let's keep prefer not to answer/opt-outs for optional fields. That way we know they are not skipping the question, they actually prefer not to answer. @katiealoisi @hmyers-cms

@aliciabeckett-gov The opt-outs are important for certain sensitive fields (e.g. pregnancy, ethnicity, race, gender), but not all (e.g. middle name). What about these ones though (below) - are these considered sensitive fields that should have opt-outs?
Resident in congregate care setting
Employed in healthcare
Type of healthcare professional

@katiealoisi that's a great point! I think the 3 fields you identified are not sensitive, and do not need opt outs.

Check the data hub allowed values for this

Fields should be marked "(Optional)" as in the prototype (lighter grey with parenthesis).

Marking required fields is good enough for now. Moving this ticket to sprint 10 to add the rest of the design.

This was completed in #622. Can this be closed?

This was completed in #622. Can this be closed?

Sure

Sure


Need a nicer 5xx page

This should come from lux when ready; requires #381

Where nicer is:

Branded
Human-friendly text that is more descriptive than "something went wrong"
Links to at least home page and all-item search


Maintain lists of supported benchmarks for each cloud provider

Each cloud provider should maintain a list of benchmarks supported.
When a run of PerfKit Benchmarker is started, only the benchmarks supported by the provider will be run.  The skipped benchmarks will be reported.
I don't currently see a natural place for this in the provider-specific files, so perhaps a new properties.py in the provider directory could contain this information.

@mateusz-blaszkowski - Is there a set of "known" working benchmarks for OpenStack/Kubernetes?   Any not working as intended?
@syed -  Is there a set of "known" working benchmarks for CloudStack?   Any not working as intended?
@hicrazyboy  -  Is there a set of "known" working benchmarks for AliCloud?   Any not working as intended?
@meteorfox - Is there a set of "known" working benchmarks for Rackspace?   Any not working as intended?

There is a kubernetes_set with a list of benchmarks that worked well on K8S:
    'kubernetes_set': {
        MESSAGE: 'Kubernetes benchmark set.',
        BENCHMARK_LIST: ['block_storage_workload', 'cassandra_ycsb',
                         'cassandra_stress', 'cluster_boot', 'fio', 'iperf',
                         'mesh_network', 'mongodb_ycsb', 'netperf', 'redis',
                         'sysbench_oltp']
    }

Unfortunately I can't verify which benchmarks were working on Openstack cloud. @kivio - do you have a list of working benchmarks for OS?

@mateusz-blaszkowski @voellm - i have list of working benchmarks but from release 18.x, I haven't currently environment to test newest version of PKB

We can go with "it works" until proven not to or err on know is known.  Any
preference?

@voellm  Ok, we can assume "it works" for all. I want to test it in nearby future.

Another thing - OpenStack driver is currently implemented and tested just for Ubuntu image.

With the pull request complete is this feature complete?  If so please close.

Closing, as it is complete.  Please reopen if something is missing.


Add more modernize- clang-tidy checks

Description
Each commit adds 1 check and makes all required fixes so read this PR on a per-commit basis to get the best picture for why a given change was made.
Here are all the checks being added:
    modernize-avoid-bind
    modernize-deprecated-headers
    modernize-deprecated-ios-base-aliases
    modernize-loop-convert
    modernize-make-shared
    modernize-make-unique
    modernize-raw-string-literal
    modernize-redundant-void-arg
    modernize-replace-auto-ptr
    modernize-replace-disallow-copy-and-assign-macro
    modernize-replace-random-shuffle
    modernize-shrink-to-fit
    modernize-unary-static-assert
    modernize-use-bool-literals
    modernize-use-default-member-init
    modernize-use-emplace
    modernize-use-noexcept
    modernize-use-override
    modernize-use-transparent-functors
    modernize-use-uncaught-exceptions
    modernize-use-using

SFMLBuildMaster: Build this please.

SFMLBuildMaster: Build this please.

SFMLBuildMaster: Build this please.

SFMLBuildMaster: Build this please.

SFMLBuildMaster: Build this please.

SFMLBuildMaster: Build this please.


feat: modify sonar and codecov config

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind enhancement
What this PR does / why we need it:

The modification are not effective in the https://github.com/openyurtio/openyurt/pull/2000. The "ignore" field should be flush left.
It's more reasonable for Sonar to exclude generated code when checking for duplicate code.

Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

other Note

/lgtm


Location of config.ts

When running standalone the instructions say to edit app/config/config.ts.
I can't find this file. Where is it located? Do I need to create it?

I added some clarity to the readme.
https://github.com/dreamfactorysoftware/angular2-sdk/pull/6

I think that the correct path is:
app/config/constants.ts
If that's right, your README patch is incorrect...


Not working in XAML

When trying this in XAML I get "The attachable property 'Elevation' was not found in type 'VisualElement'".
When I type android: all I get from intellisense is Button, Entry, ListView, TabbedPage and WebView

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0e2ccd04-96eb-bee8-3a68-95a590291cb2
Version Independent ID: 366097b0-7c57-279e-f346-c7e06cb53ed4
Content: VisualElement Elevation on Android - Xamarin
Content Source: docs/xamarin-forms/platform/android/visualelement-elevation.md
Product: xamarin
Technology: xamarin-forms
GitHub Login: @davidbritch
Microsoft Alias: dabritch

I'm also getting the same. I took a look at the sample but I cannot see what the issue is!

I've had the same issue. The code-behind part of the sample worked for me but the XAML didn't.

I've just tried it again. Worked perfectly. The error you see above is an Intellisense error, not a build error.