Add a clear() method to VectorStoreRetrieverMemory with FAISS vector store

- Description: In constructing the VectorStoreRetrieverMemory with InMemoryDocstore() like  faiss vectorstore, it may also need to clear the chat_history memory like  ConversationBufferMemory. To clear the memory without reconstruct a new memory, I add a clear() method to VectorStoreRetrieverMemory make it reusable in the same session, and can use memory.clear() to empty the memory vectorstore. < Only fot the FAISS vectorstore>
- Issue: the issue #5817  how to clear VectorStoreRetrieverMemory?
- Dependencies: None
- Tag maintainer:
- Twitter handle: @932196e6a7d042d
**- Usecase: **
from langchain.memory import VectorStoreRetrieverMemory
from langchain.prompts import PromptTemplate
from langchain.docstore import InMemoryDocstore
from langchain.vectorstores import FAISS
import faiss
embedding_size = 1536 # Dimensions of the OpenAIEmbeddings
index = faiss.IndexFlatL2(embedding_size)
embedding_fn = OpenAIEmbeddings().embed_query
vectorstore = FAISS(embedding_fn, index, InMemoryDocstore({}), {})
retriever = vectorstore.as_retriever(search_kwargs=dict(k= 3)) #set the vector store args
memory = VectorStoreRetrieverMemory(retriever=retriever)

# When added to an agent, the memory object can save pertinent information from conversations or used tools
memory.save_context({"input": "My favorite food is pizza"}, {"output": "that's good to know"})
memory.save_context({"input": "My favorite sport is soccer"}, {"output": "..."})
memory.save_context({"input": "I don't the Celtics"}, {"output": "ok"})

# Query the relevance history
memory.load_memory_variables({"prompt": "How's the weather "})
## return {'history': "input: My favorite food is pizza\noutput: that's good to know"}

#Clear
memory.clear()
memory.load_memory_variables({"prompt": "How's the weather "})
## return {"history":}

@baskaryan

Hi, I was also running to this issue. What happened to this PR next? Why was it closed? Thanks for your help.

Hi,I remember after read the source code, it was already a method exist in the base class or in the abstract method, you can just inherit and write your own clear logic with the FAISS package.Feel free to reach me if this doesn’t work.On Nov 24, 2024, at 05:33, Wendong Li @.***> wrote:
Hi, I was also running to this issue. What happened to this PR next? Why was it closed? Thanks for your help.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: @.***>


shape detection using opencv python

SHAPE DETECTOR
Have programmed a shape detector using opencv library of python
it detects simple geometric shapes in given image
Issue no.(must) -
Self Check(Tick After Making pull Request)

[ ] This issue was assigned to me.
[x] One Change in one Pull Request
[x] My file is in proper folder
[x] I am following clean code and Documentation and my code is well linted with flake8.
[ ] I have added README.md and requirements.txt with my script

If issue was not assigned to you Please don't make a PR. It will marked as invalid.
Join Us on Discord:- https://discord.gg/JfbK3bS
acknowledgement

[x] I have tested the script and distributing it under MIT license.

It's an Unassigned issue. Please go through the README for the guidelines to create A Pull Request.
Issue and PR guidelines to stop spam and duplicate PR.
Thanks.

Marking PR closed

Invalid issue number


Fix basket tests.

Changes Unknown when pulling 1cf11be029ca6f21ab7b1daa6b3d87cd7b96fcc1 on akatsoulas:basket-tests into ** on mozilla:master**.


Only include menu-contextual if non-empty

I was confused about the white / blank space on the right for when there is no TOC / tags etc.
Code: https://github.com/budparr/gohugo-theme-ananke/blob/7a32e28d4b239a279ba0415bd26f93f5ced5128c/layouts/_default/single.html#L34-L36
Is it possible to skip the <aside> block complete if it is empty / only contains whitespace?

There's also a CSS issue in this regard: below a width of 960px the aside appears to be below, but between 960-1020px the left and right padding is missing:


Refs #273 - Replaced vendored markup lib by dependency

The file NOTICE could be removed with this change
https://github.com/kennethreitz/tablib/blob/733d77ad1ed393869825f74803781d9b9873782e/NOTICE#L1-L6

Good catch!

@claudep Can you please resolve conflicts. Thanks for the PR!

Sure, done.

I noticed the new repo for MarkupPy doesnt contain any code - https://github.com/tylerbakke/MarkupPy/issues/3 , but I guess it wasnt being modified much anyway as it is a 1:1 replacement for the vendored code in tablib.
IMO tablib/compat.py and tablib/packages/__init__.py should still have imports in them, importing the external libraries, to avoid breaking the interface of compat which users may be relying on.
Also it would be good if the setup.py reference has the correct capitalisation, MarkupPy, but not important as most setup.py inspection tools now get the requirements from requirements.txt .


chore: implement no explicit any lint rule

:pencil: Description
:link: Related Issues

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add Travis - Multiarch Builds, Autopublish on Docker-Hub and Security Scan with trivy

From https://github.com/herbrandson/k8dash/issues/43
Changelog in a nutshell:

replaced node-sass with sass to solve dependency issues while npm install and improve build speed
Updated package(-lock).json to fix outdated dependencies
Modified Dockerfile to allow Multiarch builds - reworked stages to minify overhead and increase reuse while doing these builds
Added .travis.yml file to add Autobuild, Autoscan via trivy and last but not least Autopublish on Docker Hub via :latest and :commit-id(:8) tags

This will require you to setup a free Travis account on https://travis-ci.com/ and setup the repositories settings for k8dash by adding the Environment Variables:

HUB_USER = herbrandson
HUB_TOKEN = docker-api-token-generated-on-docker-hub

I strongly recommend not to use your personal password for HUB_TOKEN but really generate a Token in your Account (pretty easy) - see also here: https://docs.docker.com/docker-hub/access-tokens/
That should be all. The current functionality of the PR can be verified on my master repo:
https://github.com/thiscantbeserious/k8dash
Also Docker Hub:
https://hub.docker.com/r/youcantbeserious/multiarch-k8dash/tags
And Travis log:
https://travis-ci.com/thiscantbeserious/k8dash/builds/149216396

@herbrandson fixes should be done

Hey @thiscantbeserious I just wanted to apologize for how long it's taken to get this PR merged. Thank you so much for your patience. I REALLY appreciate all the effort you've put into this and am excited to get it merged :)

@herbrandson no worries. No need to hurry here. I'm testing in the meantime, also have quite a husy life myself.
I noticed some additional comments via email but I cant find any of them here (mobile view). Did you remove them or did you leave them in another place?


Data frame selected rows intermittently returning None Type

When selecting the fourth (not the 1-3rd) entry of the data_frame example the row selection produces a None value which causes an error. Weirdly this seems to be specific to that particular entry and persists you reorder or filter the data.

I have a reprex of a similar (the same?) problem when pre-filtering the dataframe.
https://gist.github.com/andrie/33ae57d8156959d5482bb927cacdcc9a

The bug is caused by the index being dropped which seems to be what the data frame relies on for selection. A workaround is to call df.reset_index() after filtering. This is possibly related to #634.

I'm still getting the same error in my app, despite having installed the latest pyshiny codebase.

I've now managed to fix my app to work with the changes in the linked PR.
The important missing step was to call dat.reset_index() after filtering.
The modified app is at https://gist.github.com/andrie/595d9b439d7c29eac2c1c1bb963d8e7f


Fix: Avoid caching AnnotationIntrospector to support custom module loading

Do not cache the value of '_intr' because users can load custom modules later after swagger is configured, and we want to utilize their annotation inspection, just like jackson would do.

Hi @frantuma,
I’d like to draw your attention to an issue regarding the binding of the annotation introspector.
Issue: Currently, binding the annotation introspector to _intr causes a divergence in functionality between Swagger's annotation introspector and Jackson's annotation introspector. This could lead to inconsistencies, especially when users extend Jackson with custom modules that perform custom annotation introspection.
Solution: To address this, I propose that we avoid binding the introspector directly and instead retrieve the current annotation introspector from _mapper. This approach ensures that both Swagger and Jackson utilize the same introspector, maintaining functionality and consistency across the system.
Use Case: This change is particularly beneficial for users implementing custom annotation introspection
I have referenced an implementation that demonstrates adding sealed class support without @JsonSubtype annotations.
Please let me know your thoughts or if you need any additional information.
Best regards.

Hello @micryc, can I bring your attention to this PR. I believe this PR bring net positive value to the project, thoughts?


[ASTGen] Separate JSON serialization module from ASTGen

For future usage from other host libraries written in Swift
For CMake:

Explicitly specify LINKER_LANGAGE to CXX in existing components so that swiftc is not used when linking with swiftASTGen
Add EMIT_MODULE argument to add_pure_swift_host_library to emit .swiftmodule usable from other Swift libraries.

@swift-ci Please smoke test

@swift-ci Please smoke test


1.6.19rc1

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Debugging advice.

In CI, fails to import apstools


Implementation of internal declare

Implements InternalDeclare class

Codecov Report

Merging #124 (2e5f310) into main (6aba66b) will decrease coverage by 1.76%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   64.57%   62.81%   -1.76%
==========================================
  Files          30       30
  Lines        1575     1619      +44
==========================================
  Hits         1017     1017
- Misses        558      602      +44

Impacted Files
Coverage Δ

src/business_logic/fact_state/state.rs
8.86% <ø> (+1.25%)
:arrow_up:

src/business_logic/transaction/internal_objects.rs
0.00% <0.00%> (ø)

src/business_logic/transaction/state_objects.rs
0.00% <ø> (ø)

...core/transaction_hash/starknet_transaction_hash.rs
35.71% <0.00%> (-16.01%)
:arrow_down:

src/definitions/general_config.rs
50.00% <0.00%> (-40.91%)
:arrow_down:

src/utils.rs
43.90% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Nonlinear objective evaluation after solve is very slow

I have the following simple regularized logistic regression problem:
function logistic_regression(X::Matrix{Float64}, y::Vector{Int}, λ::Float64)
  n, p = size(X)

  # Convert y to (-1, +1)
  Y = y * 2 - 3

  m = Model(solver=IpoptNLSolver())

  @variables m begin
    β[1:p]
    β0
    z[1:p] >= 0
  end
  @NLexpression(m, fx[i=1:n], sum{X[i, j] * β[j], j= 1:p} + β0)

  @constraints m begin
    pos_abs[i = 1:p], z[i] >=  β[i]
    neg_abs[i = 1:p], z[i] >= -β[i]
  end

  @NLobjective(m, Max, -sum{log(1 + exp(-Y[i] * fx[i])), i = 1:n} -
                          n * λ * sum{z[j], j=1:p})

  @time status = solve(m)

  getvalue(β), getvalue(β0)
end

X is a 23000x128 matrix. Ipopt finishes in about 10 seconds, but then evaluating the objective value takes around 80s at this step, in particular the substitute_vars! call is the slow one, which traverses the expression tree and replaces variable nodes with their numeric solutions.
@mlubin Do you have any ideas about how we could make this step faster?
Interestingly, solving the same problem via Ipopt.jl takes 250 seconds (all in function evaluations), so there's about a 25x difference in just the raw solve time, ignoring this objective value time.

eval doesn't scale linearly with the input. I can only really recommend making your own expression interpreter.

Is there any way we can hand off the current solution to the JuMP NLPEvaluator to get the function value once or something like that?

You could construct a new JuMP model and load in the expression using the raw input format (http://www.juliaopt.org/JuMP.jl/0.14/nlp.html#raw-expression-input).

Wait, you already have a JuMP NLPEvaluator, just call it?

Like this right? https://github.com/JuliaOpt/Ipopt.jl/blob/master/src/IpoptSolverInterface.jl#L53

Yes

Thanks, I'll have a look at it later


Is it ok to add awesome awesome list?

Such as https://github.com/zhimin-z/awesome-awesome-machine-learning

No. I don't want to open the flood gates for meta-lists. If an Awesome list is good enough, it should be here.


Tutorial does not match actual order of operations.

It appears as if some of the tutorial is missing or hasn't been updated.
When user creates an Automated Machine Learning job, this screen displays.   This is missing from the tutorial.  The tutorial jumps to uploading data.

This tutorial is simply out of sync with the actual order of operations.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2bee109c-3482-efb4-f04a-a81d549ad743
Version Independent ID: 4f8a2993-40ed-e518-e44c-914807355db2
Content: Tutorial: AutoML- train no-code classification models - Azure Machine Learning
Content Source: articles/machine-learning/tutorial-first-experiment-automated-ml.md
Service: machine-learning
Sub-service: automl
GitHub Login: @manashgoswami
Microsoft Alias: manashg

@KittyDreadful
Thanks for your feedback! We will investigate and update as appropriate.

@KittyDreadful
Thank you for bringing this to our attention.
I've delegated this to content author @ssalgadodev, who will review it and offer their insightful opinions.


CollectionDataProvider

ArrayDataProvider only uses array a store. I would be good to have a CollectionDataProvider  which can use all types of Collection as a store.

A concrete CollectionDataProvider was not possible. But #37 adds support for all one dimensional Collections


feat: marshal pathItem and operation extentions

With entgo and entoas there is no easy way to attach custom extension to the ogen.Spec structure.
x-gen extentions logic was implemented here:

https://github.com/ogen-go/ogen/issues/1207
https://github.com/ogen-go/ogen/pull/1222

Addresses https://github.com/ogen-go/ogen/issues/1228

@tdakkota concerns addressed 💅🏼


Discussion: add diagnostics different components.

The current tag usage is rather confusing.
componentKey: https://github.com/dapr/dapr/blob/master/pkg/diagnostics/service_monitoring.go#L15
componentKey    = tag.MustNewKey("component")

component.type: https://github.com/dapr/dapr/blob/master/pkg/runtime/runtime.go#L2234
diag.DefaultMonitoring.ComponentInitFailed(c.Spec.Type, "init")

component.name: https://github.com/dapr/dapr/blob/master/pkg/grpc/api.go#L407
	diag.DefaultComponentMonitoring.OutputBindingEvent(context.Background(), in.Name, in.Operation, err == nil, elapsed)

And do we need namespaces in tag, such as dapr.component.name or dapr.component.type?
https://github.com/dapr/dapr/blob/master/pkg/diagnostics/tracing.go#L63

https://github.com/dapr/dapr/issues/4068

We should unify them.

Is it an epic task? Not familiar with it.

Is it an epic task? Not familiar with it.

Internally,  I changed it to Opentelemetry implementation, which is very easy to use and super convenient

Could provide a proposal about implementing it?

Could provide a proposal about implementing it?

Ok, i try it.


What's needed for a submission?

Q: How do I submit data?

All of the current raw data used to build the site is in its own github repo (https://github.com/lfoust/thediscdb-data) and I plan on taking pull requests to that repo. As you can see, the commits for one title contain several different files (example commit: https://github.com/lfoust/thediscdb-data/commit/e552220daf612470c5cbd13c5c7b7efd43e6a9a1) so I may work to simplify that (or at least come up with a minimum of what is required)
I think the absolute minimum for each title would be the makemkv logs for each disc (disc*.txt) and the summary file which maps out which titles are which (disc*-summary.txt). Also the metadata for the release (release.json). I could generate the rest automatically.

Once you get the process down and document how to generate those files, I'll upload mine.

@daynyxx -  I do have a first draft of the contribution guidelines here: https://github.com/lfoust/thediscdb-data/wiki/Contribution-Guidelines
Let me know if there is anything I can do to help you or walk you through them. Thanks!

I think it would be helpful to have an example in the Contribution-Guidelines that shows all of the tags to populate in the summary.txt. I think I figured it out though. Would you like one film per pr?

I think it would be helpful to have an example in the Contribution-Guidelines that shows all of the tags to populate in the summary.txt.

Good feedback. I'll add this.

I think I figured it out though. Would you like one film per pr?
Yes, I think one film per PR would be best. Thanks!

Here is a first pass at spelling out the format of the summary file: https://github.com/lfoust/thediscdb-data/wiki/Summary-File-Format

Looks really good. I'll start making PR's and going through my collection as I have time.

If there are multiple copies of the main movie should I tag them all as MainMovie? This also has multiple copies of the credits and a title screen animation.


Added some changes to test contributions from forks

Coverage remained the same at 86.623% when pulling e247035a99a3e400733f3a43293513083c331f72 on spring-cloud-aws-buildmaster:feature/fork-contribution-test into 84613cfd0b3afceb008b7f8f56fe2018560d041d on alainsahli:master.

Coverage remained the same at 86.623% when pulling 1cd3c80e16c6fbfcd1e2f2ebcd1ee479c77e8e3b on spring-cloud-aws-buildmaster:feature/fork-contribution-test into 84613cfd0b3afceb008b7f8f56fe2018560d041d on alainsahli:master.


support bash runtime

does we kubeless bash runtime?

We have an open issue for that: https://github.com/kubeless/kubeless/issues/94
And a stale PR also: https://github.com/kubeless/kubeless/pull/364
But honesty I think that a bash runtime wouldn't be that useful. I cannot think of a use case in which bash would be a better choice (and in which running a script in Pod is not enough). Do you have any use case in mind?

+1 for bash support


ImageCard should support hotspots

:tada: This issue has been resolved in version 1.77.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 2.0.0-beta.9 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.77.0 :tada:
The release is available on npm package (@release-1.x dist-tag)
Your semantic-release bot :package::rocket:


Update nf-msi-msisetinternalui.md

We determined that the  INSTALLUILEVEL_UACONLY flag has been in the public header for ages, but it appears that this was not updated in the documentation.

@KevinLaMS : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@KevinLaMS : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Crawler Add Fetch Condition

Feature.
Hi I want to use simplecrawler's Add Fetch Condition functionality and I was not able to pass my own exclusions or override existing ones. If there is some possibility I'd be really thankful if you will point it out for me, or I can create PR for that.
Regards,
Guga

At the moment this is not possible, but can be easily added.
I'm thinking of something like generator.getCrawler() to expose the simplecrawler instance. That way you can easily add new fetch conditions. How does this sound?

Yes, it sounds quite promising. Thanks a lot.
On Tue, Apr 17, 2018, 23:00 Lars Graubner<EMAIL_ADDRESS>wrote:

At the moment this is not possible, but can be easily added.
I'm thinking of something like generator.getCrawler() to expose the
simplecrawler instance. That way you can easily add new fetch conditions.
How does this sound?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lgraubner/sitemap-generator/issues/31#issuecomment-382104932,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD3q0fVSDkLHt2vDZRU7ffsdx_9TrVGwks5tpjvKgaJpZM4TXEdl
.

Just released v8.1.0 which provides a getCrawler() method. I hope it helps :)

I think the tag is not published on npmjs.com. I can not install that tag through npm.

My bad, seems to have been errored without me noticing. Should be out now for real.

Thank you


Split admiral_qs into admiralophtha_qs and admiral_qs.

Background Information
After the completion of #1 we should have the QS dataset from {admiral.test} available in {admiraldata}. This dataset had been originally edited in {admiral.test} to include VFQ parameters upon request from the {admiralophtha} team (see the update_qs script). Now, it would be best to create two copies of the QS SDTM: admiralophtha_qs, which contains everything, and admiral_qs, which does not contain VFQ records.
Note: the {admiralophtha} team has made an update to how the VFQ records are derived (see here for the updated script) so this code should be used instead.
Definition of Done
admiral_qs and admiralophtha_qs as described above present in the data folder and documented in data.R.

As far as I know admiral_qs is not used. The questionnaires vignette uses example_qs stored in admiral.
Should we move example_qs to admiraldata?
Should we remove admiral_qs?

This is a huge datasets and I would say please remove it!!

Agreed in the meeting: remove admiral_qs, keep admiralophtha_qs and example_qs from questionnaires vignette in {admiraldata}
example_qs has different subject IDs, a clean-up will be needed in a later phase.


Increase Batch timeouts, in case Docker takes a while to start

Codecov Report

Merging #4827 (a1e8903) into master (0a1bb6b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4827   +/-   ##
=======================================
  Coverage   95.06%   95.06%
=======================================
  Files         589      589
  Lines       62813    62818    +5
=======================================
+ Hits        59713    59718    +5
  Misses       3100     3100

Flag
Coverage Δ

servertests
36.12% <40.00%> (-0.01%)
:arrow_down:

unittests
94.99% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/batch/models.py
89.27% <100.00%> (+0.04%)
:arrow_up:

moto/settings.py
70.37% <100.00%> (+1.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a1bb6b...a1e8903. Read the comment docs.


[imx7-var-som] this board has no identification LED

Set it up such, that the dashboard won't show the identification icon for this board.

Fixed in 2.32.0+rev1.


MAINT: Replace os.path.join with tf.io.join

Now that https://github.com/tensorflow/tensorflow/pull/48125 is merged, we should also replace os.path.join usage in this repo with the new tf.io.join method.

@adriangb I see that the PR got merged. Can we close this issue? Thanks!

This should be fixed now.

Sorry for not tagging it, thanks folks!


AuthError : Confirmation code cannot be empty ! - While using Auth.confirmSignUp

Hey Guys,
I am getting following error consistently.
I even converted the verification code in to int before call, still no luck ?

try {
          console.log("........2.....handleVerificationCode. : ");
          console.log(parseInt(this.state.verificationCode));

          let codeInt = parseInt(this.state.verificationCode);
          const confirmSignUpResponse = await Auth.confirmSignUp(
                    {
                        username:this.state.email,
                        code:codeInt
                    }
               );
                console.log(confirmSignUpResponse);
        } catch (error ) {
            console.log("ERROR OCCURRED !!! ! ! !  ! ");
            this.setState({
              errors: { ...this.state.errors,cognito:error }
            });
        }

Would really appreciate any help to resolve this issue.
Thanks

We need more context.
According to this, the code should be a string:
https://aws-amplify.github.io/amplify-js/api/classes/authclass.html#confirmsignup
Try to add this:
console.log("-----state: " + state);
And show us what you can see in CloudWatch when you execute the method that fails.

@Ricardo1980
Thanks for your reply
I did try with string initially, but no luck !

I am printing the state here after verification code, but it still throws error.
        try {

         console.log("........2.....handleVerificationCode. : ");
         console.log(this.state.verificationCode);
         console.log(this.state)

          const confirmSignUpResponse = await Auth.confirmSignUp(
                    {
                        username:this.state.email,
                        code:this.state.verificationCode,
                        options : { forceAliasCreation: true }
                    }
               );
                console.log(confirmSignUpResponse);

        } catch (error ) {
            console.log("ERROR OCCURRED !!! ! ! !  ! ");
            this.setState({
              errors: { ...this.state.errors,cognito:error }
            });
        }

My state still holds other fields like email, password...etc, is this an issue ?

I dont see "state" in that cloudwatch log.
Can you copy/paste the full cloudwatch log instead of a picture?
Print also the event the lambda function is receiving.

Here is the complete log :
inside handle handleVerificationCode form
Footer.js:87 ........2.....handleVerificationCode.

I am still getting this error, is there any work around ?
Any help is really appreciated !

@rajinonnet can you show the network request for Cognito confirmSignUp?

I did not see any Network request for this Cognito confirmSignUp, its catching exception and throwing error.  Surprising !.

I see the problem.  According the confirmSignUp docs, the parameters are:
confirmSignUp(username: string, code: string, options?:   The way i was calling the Cognito confirmSignUp was creating issues.
Thanks for prompt support guys !
Here is the difference.
BEFORE ( which was throwing error )
          const confirmSignUpResponse = await Auth.confirmSignUp(
                    {
                        username:this.state.email,
                        code:this.state.verificationCode,
                        options : { forceAliasCreation: true }
                    }
               );

CORRECTED ONE ( WORKING )
const confirmSignUpResponse = await Auth.confirmSignUp(this.state.email,this.state.verificationCode) ;

@duwerq , yes you are correct, Now its working fine !  Thanks for your prompt reply.
Have a good day !


Further riscv changes. User space now builds completely.

Why did you change sys/src/cmd/aux/realemu/loadcom.c/json files? I think "-I ./ " is more elegant than specifying entire path for a header. In fact realemu won't be used under riscv if you force a amd64/include header.

Because it can be used under riscv. It's just an emulator. It should run on any CPU. And if there are ever riscv CPUs with pcie slots than we will need to be able to run the options ROMs.
The -I / makes more sense because we need to name the architecture explicitly and you can't do that with just a ..
Using -I / for this one case also makes it easy to move the file around in the tree and not have to change the header all the time.

sold out!.

I still don't see the problem.

no problem, you sold it to me :-)


rework buttons and status messages

          Huge improvement, thank you @mr-tz ! I left some comments to address as well as the following:

Note: we have been overloading the buttons and status message to serve both the program analysis and rule generator tabs. Adding this caching feature is making me realize that this overloading has probably reached a point where it is more confusing than simply adding separate buttons and status message to each tab view. I think we should focus on getting the caching right in this PR and not so much about keeping the buttons and status messages in sync. Once we merge these changes we can open a follow-up PR to address the buttons and status messages.
(pending additional thoughts to my comments above the following are noted for future changes in separate PR)

[ ] anlayze -> load existing results - does not populate "capa rules: ..." status message in bottom left; proceeding to select "Show matches by function" does populate "capa rules: ..." in bottom left (addressed in prior PR)
[ ] anlayze -> cancel clears status message in lower left; ideally the status message stays the same and does not dissaper if the user selects cancel (addressed in prior PR)
[ ] switching tabs clears status message in lower left; ideally this does not disappear

Originally posted by @mike-hunhoff in https://github.com/mandiant/capa/pull/1292#pullrequestreview-1279822754
Also: https://github.com/mandiant/capa/pull/1292#discussion_r1093710605

closed via #1292


Internet Disconnected Error

Describe the bug
My computer disconnected from internet a couple of minutes and got an error message:
How To Reproduce

Open Editor
Disconnect from internet (?)

Platform

Standalone 0.3.2
OS: EndeavourOS Linux x86_64, 6.6.56-1-lts
GPU: NVIDIA GeForce RTX 3050 Ti Mobile

Logs
cables_electron encountered an error
Error: net::ERR_INTERNET_DISCONNECTED
    at SimpleURLLoaderWrapper.<anonymous> (node:electron/js2c/browser_init:2:115199)
    at SimpleURLLoaderWrapper.emit (node:events:519:28)

are you using any httprequests or websockets or anything? does this happen in an empty patch?

No, no httprequests or websockets. It was a simple patch (mainloop + transform + cube). The one i was using to test the MediaRecorder problem.

thanks, this is fixed in the next version


Panic during plan status

What happened:
Panic 😱
What you expected to happen:
Not panic :D
How to reproduce it (as minimally and precisely as possible):
kudo git:(master) ✗ kubectl get instance
NAME               AGE
abc                3h1m
zookeeper-c5n747   3h13m
➜  kudo git:(master) ✗ kubectl kudo plan status --instance abc
panic: interface conversion: runtime.Object is *unstructured.UnstructuredList, not *unstructured.Unstructured

goroutine 1 [running]:
k8s.io/client-go/dynamic.(*dynamicResourceClient).Get(0xc00003c640, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/Users/alenavarkockova/go/pkg/mod/k8s.io/client-go@v11.0.1-0.20190409021438-1a26190bd76a+incompatible/dynamic/simple.go:231 +0x919
github.com/kudobuilder/kudo/pkg/kudoctl/cmd/plan.planStatus(0x3198d00, 0x22314fd, 0xa)
	/Users/alenavarkockova/go/src/github.com/kudobuilder/kudo/pkg/kudoctl/cmd/plan/plan_status.go:145 +0x64b
github.com/kudobuilder/kudo/pkg/kudoctl/cmd/plan.runStatus(0xc000371180, 0xc0005ba5a0, 0x0, 0x2, 0x3198d00, 0x0, 0x0)
	/Users/alenavarkockova/go/src/github.com/kudobuilder/kudo/pkg/kudoctl/cmd/plan/plan_status.go:68 +0x421
github.com/kudobuilder/kudo/pkg/kudoctl/cmd/plan.NewPlanStatusCmd.func1(0xc000371180, 0xc0005ba5a0, 0x0, 0x2, 0x0, 0x0)
	/Users/alenavarkockova/go/src/github.com/kudobuilder/kudo/pkg/kudoctl/cmd/plan/plan_status.go:36 +0x52
github.com/spf13/cobra.(*Command).execute(0xc000371180, 0xc0005ba580, 0x2, 0x2, 0xc000371180, 0xc0005ba580)
	/Users/alenavarkockova/go/pkg/mod/github.com/spf13/cobra@v0.0.3/command.go:762 +0x465
github.com/spf13/cobra.(*Command).ExecuteC(0xc000370280, 0x1f36c4e, 0xc00059ff88, 0xc0000be058)
	/Users/alenavarkockova/go/pkg/mod/github.com/spf13/cobra@v0.0.3/command.go:852 +0x2ec
github.com/spf13/cobra.(*Command).Execute(...)
	/Users/alenavarkockova/go/pkg/mod/github.com/spf13/cobra@v0.0.3/command.go:800
main.main()
	/Users/alenavarkockova/go/src/github.com/kudobuilder/kudo/cmd/kubectl-kudo/main.go:24 +0x28

Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version):
Kudo version (use kubectl kudo version):
Operator:
operatorVersion:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

Strange, the issue occurs when querying the instance with the dynamicClient.Get(...) call which has a return type (*unstructured.Unstructured, error) but that's obviously not what it gets from the API server since:
panic: interface conversion: runtime.Object is *unstructured.UnstructuredList,
not *unstructured.Unstructured```

Ah, found it. So the controller didn't exist during kudo install ... so there was no active plan on the instance, and when trying to dynamicClient.Get for an empty name, it apparently turns into List() returning an UnstructuredList instead of just Unstructured. Fis is on the way


config and custom settings location?

Where is the application main settings folder? For example where custom enzymes would appear. (Specifically on linux)
sorry if this is not the appropriate place to ask this, I couldn't find it in any docs or see a place to ask.

@0xpsi the custom enzymes are currently saved in the electron browsers localStorage
Does that answer your question?

@0xpsi the custom enzymes are currently saved in the electron browser's localStorage
Does that answer your question?

hm, I'm not sure how to find that. I guess the root of my question is, how can I copy and backup custom enzymes, for example if I want to move them to another ove-electron instance on another computer?

Hey @0xpsi here are steps for doing what you want:

From the OVE application, go to View > Toggle Developer Tools:

Then paste the following into the console:

copy('var data = '+JSON.stringify(localStorage)+';Object.keys(data).forEach(function (k){localStorage.setItem(k, data[k]);});');

It should look like so:

Paste the copied text wherever you like (notes app or dropbox or some other shared file between computers)

To get the list onto your other computer open the Developer tools again and in the console, run the copied text

That should look like:

Voila!
You just copied your localStorage to a new computer!
NOTE: My answer is ripped off from this stack overflow answer: https://stackoverflow.com/a/54473783/2178112

thank you, it does appear to work.
Could we leave this issue open until a user-friendly option is available? Or if I should open a new issue for that. I think this is reasonably important, it seems like that functionality should be user configurable.
thanks for the quick replies

@0xpsi could you close this issue and create a new one specific to setting up a more user friendly way to do it?

@tnrich yah no problem


what is forntend?

Hello, I have some questions that I don't understand. Can you help me?
I've seen multiple references to the frontend in the document

"Longhorn supports iscsi target frontend mode as stated" in the file docs/iscsi.md

"The frontend (either open-iscsi/TGT are supported at this moment)"  in the file longhorn-engine/readme.md

When I create volume on the UI, the Frontend has two choices, Block device and iscsi

The processes parameters in the pod instance-manager-e-xxxx are all “frontend sockets”

So, I don't understand this frontend, it seems to be inconsistent, are they wrong?

@yuchunyun The frontend in the Longhorn indicates the way how Longhorn present the volume to the user.
To the end-user, we have two frontends available now: iscsi or block device. Both of them are implemented using TGT as an iSCSI target in the back. Block device frontend will also involve open-iscsi on the host to create the device. To Longhorn engine, those two frontends are tgt-iscsi and tgt-blockdev.
We used to have another frontend called tcmu in the engine, but we recently deprecated that. I've replaced the either with only in the Longhorn engine README.md.
Regarding the frontend-socket, it's another frontend setup for the engine and related to how we implemented the frontend based on TGT.

@yasker   Thank you very much for your explanation.
As an end user, can I understand it this way?
The block device frontend is something I can use directly to format the mount (Longhorn has done the target for me), and ISCSI is something I need to manually use opern-iscsi to log in and find before I can format and mount it.

@yuchunyun That's correct.

@yasker  I also have a problem that I see disk /dev/sdh on the host using the fdisk command, but I see /dev/longhorn/pvc-e2fe33a6-ffa0-11e9-9ec4-5254008c3f4d mounted using the mount command. Shouldn't it be /dev/sdh

@yuchunyun They're the same since they have the same major and minor number. We created /dev/longhorn/xxx to make it easier for the user to access the block device since the block device name is the same as the Longhorn volume's name.

@yasker   Yes, I saw their major:minor device number, how to map /dev/sdh to /dev/longhorn/volumeName?

We used mknod to do that.

@yasker   thanks


Cosmetics

This PR just adds some cosmetics changes:

Fixes the indentation in sq_ring_needs_enter();
Fixes a typo in a comment.

Thanks, merged.

Thanks, merged.


Add user options for cycler

Let the user say the cycler type the data is coming from or even specify the line number of the header

Now with the added functionality, the cycler detection is a bit slower when running it which is not ideal given it wasn't particularly fast from the start. @PipGrylls can you please have a look and message me about potential improvements? Maybe caching, data limits, the encoding detection is the slow bit as well, but I assume that is already made quite efficient.


🐛 [firebase_messaging] Disable Push Notifications permission pop up on iOS startup

Bug report
Describe the bug
The bug has already been described on those issues #4576 & #5897.
However, the solution provided doesn't apply to me since i'm NOT using the flutter_local_notifications package.
The issue is that on iOS notifications permissions window is toggled on app startup without calling explicitly the requestPermission method.
Expected behavior
The notifications permission dialog should be prompted when user wants to.
Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
[✓] Flutter (Channel stable, 3.3.2, on macOS 12.6 21G115 darwin-arm (Rosetta), locale en-GR)
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.2)
[✓] VS Code (version 1.71.2)
[✓] Connected device (4 available)
[✓] HTTP Host Availability

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
dependencies:
- appsflyer_sdk 6.8.2 [flutter]
- cached_network_image 3.2.1 [flutter flutter_cache_manager octo_image cached_network_image_platform_interface cached_network_image_web]
- carousel_slider 4.0.0 [flutter]
- collection 1.16.0
- connectivity_plus 2.3.6 [flutter connectivity_plus_platform_interface connectivity_plus_linux connectivity_plus_macos connectivity_plus_web connectivity_plus_windows]
- cupertino_icons 1.0.4
- device_info_plus 4.1.2 [flutter device_info_plus_platform_interface device_info_plus_macos device_info_plus_linux device_info_plus_web device_info_plus_windows]
- facebook_app_events 0.17.1 [flutter]
- firebase_analytics 9.3.6 [firebase_analytics_platform_interface firebase_analytics_web firebase_core firebase_core_platform_interface flutter]
- firebase_messaging 13.0.4 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta]
- firebase_performance 0.8.3+1 [firebase_core firebase_core_platform_interface firebase_performance_platform_interface firebase_performance_web flutter]
- flutter 0.0.0 [characters collection material_color_utilities meta vector_math sky_engine]
- flutter_idensic_mobile_sdk_plugin 1.19.5 [flutter]
- flutter_inappwebview 5.4.3+8 [flutter]
- flutter_localizations 0.0.0 [flutter intl characters clock collection material_color_utilities meta path vector_math]
- flutter_picker 2.0.5 [flutter]
- flutter_screenutil 5.5.3+2 [flutter]
- flutter_secure_storage 6.0.0 [flutter flutter_secure_storage_linux flutter_secure_storage_macos flutter_secure_storage_platform_interface flutter_secure_storage_web flutter_secure_storage_windows meta]
- flutter_switch 0.3.2 [flutter]
- flutter_widget_from_html 0.8.5 [flutter flutter_widget_from_html_core fwfh_cached_network_image fwfh_chewie fwfh_just_audio fwfh_selectable_text fwfh_svg fwfh_url_launcher fwfh_webview html]
- get 4.6.5 [flutter]
- get_storage 2.0.3 [flutter get path_provider]
- http 0.13.4 [async http_parser meta path]
- image_cropper 3.0.0 [flutter image_cropper_platform_interface image_cropper_for_web]
- image_picker 0.8.5 [flutter image_picker_android image_picker_for_web image_picker_ios image_picker_platform_interface]
- in_app_review 2.0.4 [flutter in_app_review_platform_interface]
- infinite_scroll_pagination 3.2.0 [flutter sliver_tools]
- internet_connection_checker 0.0.1+3
- intl 0.17.0 [clock path]
- intl_phone_field 3.1.0 [flutter]
- lint 1.8.2
- load_switch 1.1.0 [flutter]
- local_auth 2.1.2 [flutter intl local_auth_android local_auth_ios local_auth_platform_interface local_auth_windows]
- logger 1.1.0
- lottie 1.2.2 [archive flutter path vector_math]
- moengage_flutter 5.0.0 [flutter]
- package_info_plus 1.4.3+1 [flutter package_info_plus_platform_interface package_info_plus_linux package_info_plus_macos package_info_plus_windows package_info_plus_web]
- path_provider 2.0.11 [flutter path_provider_android path_provider_ios path_provider_linux path_provider_macos path_provider_platform_interface path_provider_windows]
- pdf 3.8.2 [archive barcode crypto image meta path_parsing vector_math xml]
- pdfx 2.2.0 [flutter flutter_web_plugins plugin_platform_interface js device_info_plus uuid meta extension synchronized universal_platform photo_view vector_math]
- pie_chart 5.3.0 [flutter]
- pin_code_fields 7.4.0 [flutter]
- pusher_client 2.0.0 [flutter]
- scroll_to_index 3.0.1 [flutter]
- sentry_flutter 6.9.0 [flutter flutter_web_plugins sentry package_info_plus meta]
- share_plus 4.4.0 [meta mime flutter share_plus_platform_interface share_plus_linux share_plus_macos share_plus_windows share_plus_web]
- shimmer 2.0.0 [flutter]
- simple_rc4 0.2.0
- smooth_page_indicator 1.0.0+2 [flutter]
- string_extensions 0.6.2 [convert crypto flutter intl test]
- string_validator 0.3.0
- url_launcher 6.0.20 [flutter url_launcher_android url_launcher_ios url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows]
- uuid 3.0.6 [crypto]
- visibility_detector 0.3.3 [flutter]
- webview_flutter 3.0.4 [flutter webview_flutter_android webview_flutter_platform_interface webview_flutter_wkwebview]

Thanks for the report @esentis
I looked at the firebase_messaging plugin example and in it, the FirebaseMessaging.instance.requestPermission is implemented using firebase_messaging_platform_interface plugin as below:
https://github.com/firebase/flutterfire/blob/39ca00299ec5c6e0f2dc9b0b5a8d71b8d59d51d4/packages/firebase_messaging/firebase_messaging/example/lib/permissions.dart#L23
Running that example, I didn't observe the permission popup being shown without explicitly calling the method:

Can you try the same example and check using it, you still get same behavior as you reported ?

Thanks a lot for the quick response. The example provided indeed doesn't prompt the permissions dialog, however I don't see anything different implemented code-wise.
I still get the dialog in my code as soon as the app is installed, in fact the dialog pops in splash screen without even Firebase being initialized yet. Any tip is more than welcome !

I still get the dialog in my code as soon as the app is installed, in fact the dialog pops in splash screen without even Firebase being initialized yet.

Are you using any other community plugin that might be requesting the permission ? such as flutter_app_badger or local_notifier or any other ? If so, that might most probably be the reason why you are seeing the dialog in splash screen.

I have gone through all my libraries one by one but without any success. I was using OneSignal (still using in production) before trying to refactor to FCM and the permissions dialog was (is) toggled explicitly correctly so it's not like the app never used push notifications before.

@darshankawar After further investigation I found the conflicting library, it was moEngage. For some reason their SDK is prompting the dialog ! Closing this as it is not FCM's issue.


Text gets

[x] I am on the latest Hyper.app version

[x] I have searched the issues of this repo and believe that this is not a duplicate

OSX Sierra

Hyper.app v1.2.1

My hyper.js is still default

N/A

Vanilla

Issue
From time-to-time, Hyper will essentially take a "snapshot" of some text in my terminal and burn it into the background of the terminal. It is worth noting that it seems to be almost random. Sometimes it happens, other times it doesn't. Likewise, after it happens, it seems to go away after a few minutes of remaining in use.
Please see this Imgur Album for a few screenshots of the issue in action.
I can also point out, as the album demonstrates, the issue becomes more prominent as the background transparency gets closer to zero. Likewise, the issue becomes less prominent as the background transparency gets closer to one.

+1

Thanks for the report 🙏 .
We're tracking this work over here: #2719

@chabou Thanks for the redirection. :+1:


Redirect to origin URL

Description
Hey,
Meaby it will be more efficient to return an HTTP 301 so the browser will handle the redirect instead of using window.location in the front-end
Cheers
Screenshots
No response
Additional information
No response

Hey @Ali-Amechghal,
It's a good idea, I think we still need to think about all the edge cases.
A 301 response code will cache the redirected website at client cache, What will happen if we change the redirect on our side?

Hey @origranot
Hope you doing well,
i didn't get what kind of change we need, you mean the user can change the origin url once created ?
for the second part, do you mean to display the preview before redirecting to the origin ? what about displaying it when to user create the short link ?
Thanks

@Ali-Amechghal
Yes, if the user change origin url  after it has been used. it won't work until the browser clear the cache.
For the second part I did think about some preview before we redirect to origin (To everyone and not specially for the creator).
For those cases the 301 redirect can be problematic..


#1010 - Support caching of contentType for error pages

Fixes issue with contentType setting in Error Page Handler. #1010

Coverage increased (+0.02%) to 26.979% when pulling ac3580d1d15c7deed400e9d2c3aaa24ee38bd802 on davidjgonzalez:feature/1010 into de4e2da6beefd314e54b371e6454d58c1f39ae2f on Adobe-Consulting-Services:master.

Coverage increased (+0.02%) to 26.979% when pulling ac3580d1d15c7deed400e9d2c3aaa24ee38bd802 on davidjgonzalez:feature/1010 into de4e2da6beefd314e54b371e6454d58c1f39ae2f on Adobe-Consulting-Services:master.

Coverage increased (+0.02%) to 26.979% when pulling ac3580d1d15c7deed400e9d2c3aaa24ee38bd802 on davidjgonzalez:feature/1010 into de4e2da6beefd314e54b371e6454d58c1f39ae2f on Adobe-Consulting-Services:master.

Rejected/Closing for this release


Datadog plugin should emit service name and status code as tags

Please read the CONTRIBUTING.md guidelines to learn on which channels you can
seek for help and ask general questions:
https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#where-to-seek-for-help
Summary
Issue reported by @irabinovitch
We noticed that  it is emitting metrics in the format:  kong..request.status.
We generally would encourage service-name and status code to be tags rather than part of the metric name as it significantly improves the experience as one graphs/queries/alerts on the metric.  We've had a few customers reach out with similar feedback, so I wanted to circle back and see if it might be possible to make the change in an upcoming Kong release.
Steps To Reproduce

Additional Details & Logs

Kong version ($ kong version)
Kong debug-level startup logs ($ kong start --vv)
Kong error logs (<KONG_PREFIX>/logs/error.log)
Kong configuration (the output of a GET request to Kong's Admin port - see
https://docs.konghq.com/latest/admin-api/#retrieve-node-information)
Operating system

Hey Kong team, just to confirm, is this issue fixed in https://github.com/Kong/kong/pull/5154/files?


Only send EOF in writable sessions

Currently EOF is sent to the pty even when read-only mode is requested. This can cause trouble in attached tmux sessions, for example. Since the EOF typically used in shells as a shortcut exit, this can result in undesired disconnects.

Is it possible to disable EOF? It would be nice to have persisted sessions, where multiple tmux clients could attach and detach freely without closing the session.

@yudai is there a good reason why gotty writes EOF to the tty at all?

Thank you for the comment. I removed the lines for sending EOT. It was just my misunderstanding.


Enable building on Windows again

Add detailed instructions on how to build on Windows
Fix incompatible Pillow>=8.1.1 and fpdf2==2.1.0 requirements by upgrading to fpdf2-2.4.6
Add #define _USE_MATH_DEFINES before #include <cmath> to expose non-standard M_PI constants
Remove unused memory_usage() from log.py, which allows removing the resource import which is not available on Windows
Add bin\opensfm_run_all.bat to mirror bin\opensfm_run_all

Tested on Windows 11 in a fresh VM.
Combined fixes from https://github.com/mapillary/OpenSfM/pull/772 (fpdf2) and https://github.com/mapillary/OpenSfM/issues/828 (M_PI).

@fabianschenk could you share what the failures are? Thanks!

HI @yilangmok ,
Thanks for the PR :D
The method memory_usage is not used inside OpenSfM but required somewhere else but of course you couldn't have known that.
I'll try to refactor our internal code a bit but I've a ton ofter things to do, so this might take a bit.
Thanks again,
Fabian

Haha secret code!
I notice that these functions are duplicated in https://github.com/mapillary/OpenSfM/blob/13b0b659204a0e2e7041c79b680813ca20073891/opensfm/context.py#L64, which correctly handles the Windows use case. I wonder if we can just rewrite log.py to call context.py?

Hey @yilangmok ,
I already implemented a fix and your tests now pass internally. Just waiting for the review :D

@fabianschenk thanks so much for merging this!


Awesome

Hi !
Do you want it to be added to the F.List or is there some tech stuffs to review ?
Thx

Hey,
Thanks for your comment.
Usually, if repositories are not listed in the table on /community, are not compatible with both Android and iOS or need further development, they are not ready to be released and featured on Flutter Community.
If you want to use it, though, go ahead.

Jeroen (FC Mod)

Thank you @jeroen-meijer for the quick response !

This one can be released on the Awesome F.List. Its Dart only!

This should now be listed on the community table now.


Sidebar "Files" not recognizable enough

Very nice theme bro, but I wish it could be light when in "Files" sidebar

Thanks, I've fixed that and add some style to "Files" sidebar.


ARTDeviceIdentityTokenDetails unarchive failed

When trying to run the Ably Asset Tracking Swift Example app I have an error:
SubscriberExample[75701:1609309] ARTDeviceIdentityTokenDetails unarchive failed: Error Domain=NSCocoaErrorDomain Code=4864 "*** -[NSKeyedUnarchiver _initForReadingFromData:error:throwLegacyExceptions:]: data is NULL" UserInfo={NSDebugDescription=*** -[NSKeyedUnarchiver _initForReadingFromData:error:throwLegacyExceptions:]: data is NULL}

which is coming from ably-cocoa SDK
It occurred in version 1.2.6 and, after updating, in version 1.2.10
Probably nothing critical because everything is working fine but I see this error in the console.
┆Issue is synchronized with this Jira Task by Unito

Still happening.


[pilot] do not update app beta details if not needed

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
As discussed in #17910 pilot seems to be unable to work with an api_key with just the Developer permissions, needing App Manager permissions instead. However, it should work with the Developer permissions if no distribution of the uploaded binary is performed. This is the second patch after #18158
Description
If the notify_external_testers option is false there's no need to make the update build beta details API call. It's an API call that requires App Manager permissions. Following this patch, pilot can be used with just Developer permissions and have it wait for the build to finish uploading & processing using the following config:
upload_to_testflight(skip_submission: true)
Testing Steps
Before the patch: the API call is always performed, despite not having any effects if notify_external_testers is false
After the patch: the API call is only performed when notify_external_testers is true (which is the default behaviour)

@joshdholtz done!

@googlebot I consent.

Thanks to you @joshdholtz ! It's now finally possible to upload to testflight with the Developer permissions only with:
upload_to_testflight(skip_submission: true)
`


Add object_async example

This object-async example builds off the async standalone example and the object-sync example
Next Actions

[ ] Add code comments and relevant docs ("When would you use an async object or class?")
[ ] 100%-ish Test Coverage
[ ] Add some context around node::ObjectWrap and how it relates to Unwrap

Questions

@springmeyer Does this example hit any of the questions we pondered in https://github.com/mapbox/node-cpp-skel/issues/50 ?
Does this custom constructor design make sense with an async object?
Is this PR relevant to real world usage of an async object?
Curious exactly what is node::ObjectWrap and how it relates to Unwrap

Any other thoughts/comments/edits?
cc @springmeyer @daniel-j-h @flippmoke

Codecov Report

Merging #52 into master will decrease coverage by 0.21%.
The diff coverage is 92.53%.

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   92.85%   92.64%   -0.22%
==========================================
  Files           5        7       +2
  Lines          70      136      +66
==========================================
+ Hits           65      126      +61
- Misses          5       10       +5

Impacted Files
Coverage Δ

src/object_sync/hello.cpp
92.59% <ø> (ø)
:arrow_up:

src/object_async/hello_async.hpp
0% <0%> (ø)

src/module.cpp
100% <100%> (ø)
:arrow_up:

src/object_async/hello_async.cpp
93.75% <93.75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c4e2e1...bdc66d4. Read the comment docs.

@springmeyer Does this example hit any of the questions we pondered in #50 ?

Yes, perfectly. We are passing in a custom class that holds a custom data member. That member is safe to pass into the threadpool because it is not a V8 object, but rather a std::string.

Does this custom constructor design make sense with an async object?

You mean the custom constructor that accepts the name arg? Yes, I think this makes sense. However I did make one inline comment above that I think we should require this argument rather than allowing the object to be created without an arg.

Is this PR relevant to real world usage of an async object?

It is. Well done!

Curious exactly what is node::ObjectWrap and how it relates to Unwrap

We spoke about this voice. The short version is that node::ObjectWrap and wrapping/unwrapping objects is the somewhat clumsy way it is possible to bind the two languages. Let's not dig deeper than just knowing:

To access a class instance inside a C++ static method you must unwrap the object.
The C++ methods must be static to make them available at startup across the language boundary.

Thank you so much for your input @daniel-j-h @springmeyer 🙌
I've updated the PR with the optimization suggestions and comments/links for context. Once tests are 🍏  , I will merge! Feel free to add any other comments if I missed anything.


PerBuildProjectSettings missing most options

Any reason why the only configurable option in PerBuildProjectSettings is preloadedAssets?
All the other options like resolution, fullscreen, etc are missing.
I have a local fork where i added some of the options I needed and it seems to work fine. I can make a PR with the full set of options if it would be helpful to anyone?

I imagine it's because that was the only per-build Player setting that was needed for whatever project I was working on at the time that action was written, and I haven't revisited it since due to a lack of time 😅
A PR which adds some more commonly-used settings like resolution and fullscreen would be most welcome, thank you!

Makes sense
https://github.com/superunitybuild/buildactions/pull/43
Thanks for this tool!


General documentation for Jam

Not sure how to best do this, or where to put it. I think, especially in the beginning, it should be easy to edit by basically anyone.
The documentation should be:

Easy to understand
Explain general bitcoin privacy and JoinMarket concepts
Not too specific, as the software
Potentially add to the general JoinMarket documentation upstream

I see the following options:

GitHub wiki
GitBook
Separate static side (using Jekyll, VuePress, whatever...)
?

I don't care too much what we pick, as long as it's sensible and markdown based.
Thoughts?

MkDocs looks great! I'll give it a try.

Docs are live: https://joinmarket-webui.github.io/jamdocs/
Not closing the issue just yet, since we'll have to actually write the docs 😅 --- what's online now is just a very basic skeleton.


Timeouts?

How would you do timeouts in co? Would you use a promise-based solution or is there something co-specific (and possibly more elegant)?

I would do promise based. You can check out timeout-then for this purpose.

Got it. Thanks!

It can be combined with Promise.race to throw if a task is taking too long.
Something like:
function timeout(interval) {
  return new Promise(function (resolve, reject) {
    setTimeout(reject, interval || 0)
  })
}
var longTask = download('bigfile.zip');
try {
  yield Promise.race([timeout(10000], longTask]);
} catch (e) {
  // error in longTask or timeout
}

:+1:


[SPARK-28818][SQL] Respect source column nullability in the arrays created by freqItems()

What changes were proposed in this pull request?
This PR replaces the hard-coded non-nullability of the array elements returned by freqItems() with a nullability that reflects the original schema. Essentially the functional change to the schema generation is:
StructField(name + "_freqItems", ArrayType(dataType, false))

Becomes:
StructField(name + "_freqItems", ArrayType(dataType, originalField.nullable))

Respecting the original nullability prevents issues when Spark depends on ArrayType's containsNull being accurate. The example that uncovered this is calling collect() on the dataframe (see ticket for full repro). Though it's likely that there a several places where this could cause a problem.
I've also refactored a small amount of the surrounding code to remove some unnecessary steps and group together related operations.
Why are the changes needed?
I think it's pretty clear why this change is needed. It fixes a bug that currently prevents users from calling df.freqItems.collect() along with potentially causing other, as yet unknown, issues.
Does this PR introduce any user-facing change?
Nullability of columns when calling freqItems on them is now respected after the change.
How was this patch tested?
I added a test that specifically tests the carry-through of the nullability as well as explicitly calling collect() to catch the exact regression that was observed. I also ran the test against the old version of the code and it fails as expected.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@brkyvz You seem to be the most prolific contributor to this part of the codebase, would you mind taking a look at this?

ok to test

BTW, I think there is:

Does this PR introduce any user-facing change?

Mind writing the nullability is respected after this fix?

Thanks for the reviews @maropu, @srowen are we good to merge this? I obv. don't have write access. 😄

You don't need to do so and the commiltters will do later.

Thanks, wasn't sure of the process

Merged to master.

@MGHawes would it be possible to backport this to the branch-2.4 branch as well 🙏

CC @HyukjinKwon

Not sure how the process works. I have cherry-picked the commit locally, but not sure how to create a branch for the PR, would appreciate help.

I checked that we couldn't cherry-pick the commit into branch-2.4. Looks okay to backport it (because this is a bug), so could you open a new PR for branch-2.4?

I opened a PR for the backport and see: https://github.com/apache/spark/pull/29327

Thank you @maropu! Really appreciate!!, it blocks update to Scala 2.12 for us.. I would do, but it took me time to figure out how to create a PR (that I have to fork and such)

@dot-vlad I've merged this fix into branch-2.4, so it will be included in the next 2.4.7 release. Enjoy!


chore: add unary-unary showcase test for gRPC support

Thank you for opening a Pull Request! For general contributing guidelines, please refer to contributing guide
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕

I have a similar PR: https://github.com/googleapis/gapic-generator-java/pull/1483 for callables. I can move the unary tests to ITUnaryCallable after this goes in

I have a similar PR: #1483 for callables. I can move the httpjson unary tests to ITUnaryCallable after this goes in

Thanks @lqiu96! Yes, if all looks okay with how the tests are set up here then perhaps we can continue building on top of this class.

Lint check for showcase is now failing as expected after introducing changes that are incompatible with the Google Java style guide.


[BUG] The latest azure-search-documents preview java SDK libs are broken

Describe the bug
In the latest azure-search-documents java sdk libs starting from version 11.8.0-beta.1 speller is broken. It is not possible to set:
searchOptions.setSpeller(QuerySpellerType.LEXICON);
searchOptions.setQueryLanguage(queryLanguage);
To Reproduce
Use azure-search-documents preview releases starting from 11.8.0-beta.1 and try to set speller LEXICON and query language

Thanks for reporting this @Zubastick, I've filed #43028 to resolve this problem.

@Zubastick, a new release of azure-search-documents has been made available


:sparkles: Compress firmware and kernel modules on ubuntu

Signed-off-by: Itxaka<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Need to compare sizes but the firmware goes from 962M to 377M and modules from 584M to 146M but the final iso doesnt really translate into the same gain...

Codecov Report

Merging #1359 (fa8ed99) into master (7bb9af9) will increase coverage by 3.13%.
The diff coverage is 51.05%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master    #1359      +/-   ##
==========================================
+ Coverage   22.79%   25.92%   +3.13%
==========================================
  Files          22       17       -5
  Lines        1610     1427     -183
==========================================
+ Hits          367      370       +3
+ Misses       1179      997     -182
+ Partials       64       60       -4

Impacted Files
Coverage Δ

internal/agent/config.go
0.00% <ø> (ø)

internal/agent/interactive_install.go
0.00% <ø> (ø)

internal/agent/notify.go
0.00% <0.00%> (ø)

internal/agent/recovery.go
0.00% <ø> (ø)

internal/agent/reset.go
0.00% <0.00%> (ø)

internal/agent/upgrade.go
0.00% <0.00%> (ø)

pkg/config/config.go
0.00% <0.00%> (-51.36%)
:arrow_down:

internal/agent/install.go
5.10% <21.21%> (+5.10%)
:arrow_up:

pkg/config/collector/options.go
64.51% <37.50%> (ø)

pkg/config/collector/collector.go
66.55% <66.55%> (ø)

... and 3 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

I dunno, this doesn't seem alrigth. While isos boot and I can confirm that the modules are indeed compressed, the size is not that big. A mere 100Mb as maximum...

ok, in teh final system there is a 800Mb difference between a compressed and uncompressed image installed. That makes more sense, the active.img is used 1.2Gb vs 2.0Gb between them.


Initial MSVC support

Environment:

Windows 10 Pro 20H2
Qt 5.12.2 msvc2019_64
Qt 6.0.0 msvc2019_64

Note:
For commit https://github.com/NanoMichael/cLaTeXMath/commit/a734d9cf2b205ebd391f5ebf06551d768a983804
a better way to solve this problem is to rename DEBUG variable.

1 workflow awaiting approval

???

Sorry for late response 😅 , I'll check it soon


Pagination - hide pagination if only one page

Is it possible to know how many pages are present from the layout? The reason this will be useful to me is so that I can not display the pagination component if there is only one page?

PageDropdownContainer and LocalPlugin.PageDropdownContainer get maxPages from their corresponding maxPageSelectors.
You could add the same to either LayoutContainer, allowing a custom Layout to avoid rendering Pagination altogether, or PaginationContainer, allowing a custom Pagination component to return null if maxPages < 2.

Thanks! Got that working with the following code - pasting for anyone in the future looking for this:
LayoutContainer:
import Griddle, { selectors, utils as griddleUtils } from 'griddle-react';

const EnhancedLayoutContainer = OriginalComponent => compose(
    getContext({
        components: PropTypes.object,
    }),
    griddleUtils.connect(state => ({
        maxPages: selectors.maxPageSelector(state)
    })),
    mapProps(props => ({
        maxPages: props.maxPages,
        Table: props.components.Table,
        Pagination: props.components.Pagination,
        Filter: props.components.Filter
    }))
)(props => (
    <OriginalComponent
        {...props}
    />
))

Layout:
const Layout = (props) => {
    const { Table, Pagination, Filter, maxPages } = props
    if (maxPages > 1) {
        return (

                <Filter />
                <Pagination />

        );
    }

    return (

            <Filter />

    );

}

Cheers,
Ben

For reference, you can simplify a bit:
const Layout = ({ Table, Pagination, Filter, maxPages }) => {

        <Filter />
        {maxPages > 1 && <Pagination />}

);

can you help on this? not able to hide pagination if only one page @benoj  @dahlbyk

If someone tries to hide pagination when there are no more pages with this piece of code and faces #767 issue, you should just override PageDropdown component instead:

Get the latest component version from https://github.com/GriddleGriddle/Griddle/blob/master/src/components/PageDropdown.js and copy it.

In render() method you should add this snippet:

        if (maxPages < 2)
            return null;

Set your custom PageDropdown component

    <Griddle components={{PageDropdown: PageDropdown}} />


Issue/1992 env icon description create update (#2149)

Pull request opened by the merge tool on behalf of #2149

Merged in dcdd0d9715ab1e2c377074ee5d3bc79075cf4838


Add multiple checks

"Fix HAVE_CLOCK_GETRES HAVE_CLOCK_GETTIME checks " -> allow to detect getres and gettime inside lrt (centos 5) otherwise the check is not done.
"Add RTLD_* checks" mandatory for me on python 3.6, otherwise I can't import numpy

Closing. This pull request is superseded by https://github.com/python-cmake-buildsystem/python-cmake-buildsystem/pull/289

@diorcety  To ensure your contribution is accounted for in https://github.com/python-cmake-buildsystem/python-cmake-buildsystem/pull/289/commits/f1d7fc09a56248e5d1b5cb581c4a70862230037a, would you prefer I used your current email in the Co-authored-by: ... message trailer ?


[rcore_desktop] Can't get size of the monitor before creating a window

Code Example
printf("monitor: %d width: %d\n", GetCurrentMonitor(), GetMonitorWidth(GetCurrentMonitor()));
InitWindow(200, 200, "Hola");
printf("monitor: %d width: %d\n", GetCurrentMonitor(), GetMonitorWidth(GetCurrentMonitor()));

Prints:
WARNING: GLFW: Failed to find selected monitor
monitor: 0 width: 0
monitor: 0 width: 3840

Issue description
I would like to know the resolution of the (default) monitor so I can create a bigger window if it fits (and scale up my game). Currently it is only possible to query the monitor resolution after a window has already been created, which is too late.
If there are multiple monitors, I expect this to give me the resolution of the default monitor (where the window will be created).
Environment
Windows 11, RTX4070

I'm afraid it's not possible to query the display/monitor info until it is created. It will require a redesign of raylib with some kind of Init() function, compketely out of scope.
In any case, you can create an invisible window, query required data, close it and InitWindow() again.


Shutdown plugins after containers.

Fixes #26278
Signed-off-by: Anusha Ragunathan<EMAIL_ADDRESS>

LGTM

@anusha-ragunathan Do plugins know how to handle the live-restore case as this change leaves them running then?

@tonistiigi : Yes, https://github.com/docker/docker/blob/master/plugin/manager_linux.go#L84

@anusha-ragunathan Thanks!
LGTM


Node resizing with onResizeEnd not working on iPad

What platform were you using when you found the bug?

React Flow / Svelte Flow version: 11.10.0
Browser and version: safari
OS and version: ipad

Live code example
https://codesandbox.io/s/spring-dust-8tslnn?file=/ResizerNode.jsx
Describe the Bug
On iPad, using onResizeEnd for node resizing does not work correctly. Removing onResizeEnd resolves the issue. This issue has not been confirmed on Android.
Steps to reproduce the bug or issue
Try resizing a node on iPad.
Expected behavior
Resize smoothly and correctly on iPad.
Screenshots or Videos
No response
Additional context
No response

Any progress on this issue? It looks like I am having the same issue on my motorola android and my Lenovo touchscreen laptop. Appears to be a touchscreen issue in general. Thanks!

Can confirm on Android, fixed by making sure all events, like onResizeStart, use useCallback.
This issue is not necessarily intuitive and seems a common mistake, even though it is documented in places, it's easy to miss or forget, since it's not a popular expectation or standard to require a useCallback for events to work properly.
I wonder if it's possible to implement some sort of dev mode warning that detects if you're not using useCallback or maybe a typescript warning is possible?


add cleanup script

Easy setup after install and config is very useful but clutters the repo. How about adding a cleanup script?
We could cleanup dependencies  npm uninstall contentful-import inquirer
https://github.com/contentful-userland/gatsby-contentful-starter/blob/master/package.json#L9-L26
Clean up the folder structure:
rm bin contentful
And remove to npm scripts:
https://github.com/contentful-userland/gatsby-contentful-starter/blob/master/package.json#L46-L47

Great idea. The user should then commit afterwards or do you have sth better in mind?


PdoSessionHandler throws transaction lock

Hi,
We are using doctrine2 with silex. And we have a cluster of apache instances. We need to use PdoSessionHandler to store session in mysql database.
$app['session.db_options'] = array(
    'db_table'      => 'session',
    'db_id_col'     => 'session_id',
    'db_data_col'   => 'session_value',
    'db_time_col'   => 'session_time',
    'lock_mode => 2 // TRANSACTIONAL LOCKING, this needed to be set to 0
);

Not Knowing this option needs to be tweaked, I lost many hours.
Maybe documentation should add block about it.

Yep, I got stung with this one! Not sure if Silex is the place for the documentation, maybe the symfony component docs should have it (if not already).

But the problem is, components documents it properly. Then again if you are using Silex and Doctrine ORM multi server settings, this will byte you. And configuration must be passed through session provider settings.
So, I am pretty sure we should add bit of documentation to silex docs.

I just looked and I didn't realise we had a cookbook for PDO sessions, so I'd definitely be :+1: for something about this in there.

:+1: should I add it then?

Or should we change it to NON TRANSACTIONAL by default ?

Definitely send a PR, you'll have my vote. I think it would be better as a note/warning, the symfony devs wouldn't have made the transactional locking the default without good reason. I'd also make sure to use the constants that are available, for example I use PdoSessionHandler::LOCK_ADVISORY.


[DOC]  Enhancements in code of conduct file

Description
I want to add following points-
Our Pledge
Our Standards
Enforcement Responsibilities
Scope
Pull Request Guidelines
Enforcement
Enforcement Guidelines
Attribution
Conclusion.
Affected Pages:

[ ] README.md
[ ] Installation Guide
[ ] Configuration Guide
[ x] Other (please specify) - code of conduct.md

Type of Documentation Change

[ x] Update existing documentation
[ ] Add new documentation
[ ] Remove outdated or redundant documentation
[ ] Other (please specify)

Additional Context
Please add any other context or screenshots about the documentation issue or suggestion here.
Suggested Improvements
If applicable, suggest how the documentation could be improved. This could include rewording, adding examples, clarifying instructions, etc.

here I added the screenshots of the file on which I worked earlier

Hey @Nikhil0-3 , you can proceed!


submodules parent requires OWNERSHIP file

My structure is:
:app
:libs:a
:libs:b
and when running validateOwnership on root project it says that :libs does not have any ownership file, is that expected?

Don't configure your projects with
subprojects {...}
https://stackoverflow.com/a/65462546
https://docs.gradle.org/6.7.1/userguide/sharing_build_logic_between_subprojects.html#sec:convention_plugins_vs_cross_configuration


Change error PropType on Input to node

We had a weird use case where errors were coming back from the API as HTML.
So to display the errors we did this:
<Input error={
    <span dangerouslySetInnerHTML={{ __html: errors[name] }} />
  }
/>

But the error PropType is string, so it was throwing an error. Changed it over to node :)

Is this still valid when you use a string? If not, I think both should be valid!

Yep, both work

Alright


Add ability to schedule already parsed expresstion

It would be good to add one more function to directly add job struct, in case i have already parsed expression (i.e. i have int day, hour, week and so), or event better to schedule job at specific go time

to schedule job at specific go time

It might be good idea to add jobs that runs only once and then delete itself.

to directly add job struct, in case i have already parsed expression

Well, job struct is un-exported, exporting it might confuse some users and make package more complicated and exposed to errors due to bad usage. I want to stick to crontab-like syntax (* * * * *) and parsing is really fast and done only once, so I don't see the reason to provide struct directly.
I guess you have some use case which is different than the way I usually use the package.

Ok, got it. Yes, i would use it as general-purpose scheduler, for example call function at specified time in future, in that case add Job at time would be more convenient way to do this, instead of combining cron expression. In any way, thank you for answer, i closing it for now.


Manipulability

As suggested by @kassasin we could have a task for manipulability
https://github.com/Rhoban/placo-examples/issues/1#issuecomment-2162053028

In this work, they also refer to using such task:
https://m.youtube.com/watch?v=YQ0_Gy3DetQ
I believe derivations are provided in associated paper

I think we could have a task trying to get a condition number as close as possible to 1

We use Quadratic Programming as a backend, so we can't add non-convex tasks. For example, maximizing the volume of the manipulability ellipsoid is not a valid task since it is not bounded
Trying to bring the condition number of JJ^T to 1 seems however a valid task, all it takes is deriving the first order approximation of this condition number with respect to the dofs

in this blog,they said"The manipulability measure has a complex non-linear relationship with the robot’s joint configuration and in this paper we derive the manipulability Jacobian which directly relates joint velocities to the rate of change of manipulability. Furthermore, we use the manipulability Jacobian within a constrained quadratic program to create an improved resolved-rate motion controller for redundant robots. The resulting real-time controller provides joint velocities which achieve a desired Cartesian end-effector velocity while also maximising the robot’s manipulability"
In their paper,they add a linear term in qp problem in order to maxmise manipulabiliby

Jm represent manipulabiliby jacobian .
Is it helpful?

I see, they only use first order approx here, it is not a proper task since it has no hessian, but it should be a good regularization term

We would need to compute this guy, I might give it a try someday
Do you have some project involving redundancy and lack of regularization where you could test a solution ?

I made a first implementation on the manipulability branch

@Gregwar Yes，I just try to control seven freedom manipulator,I found the manipulability always small when I  only try to track end effector.I also have an idea wether we can track manipulability ellipsoid when we do other job.In this way we can use some other method to learn manipulability ellipsoid from demonstration and track it when control robot .

I added the ManipulabilityTask in the latest release
See: https://placo.readthedocs.io/en/latest/kinematics/regularization.html#manipulability-regularization
Do not hesitate to ping me if you give it a try!


Eq/Ord instances for container types

When writing tests for builtin_auto I stumbled on the fact that lists do not implement the Eq protocol! This should of course be added immediately, but let us think about what else could/should be done at the same time.
Of course, we will require that the type parameter of elements will implement Eq.

Should lists implement Ord if the parameter type does? The natural "less than" would be lexicographic order.
Sets already implement Ord. Here "less than" is subset.
Should dictionaries implement Eq? Might be useful, but I am less convinced by Ord. When is d1 less than d2? Probably if every key in d1 is present in d2, but should the values be equal or less than? I think the former; a subdictionary gives info about fewer keys, but the same info. One needs an Eq constraint on the value type.
What about tuples? I guess one would want Eq for tuples if the element types support it, but we don't even have the syntax for writing such an extension in builtin.act, even for fixed length tuples (e.g. pairs or triples).

I would propose to implement Ord for lists and dictionaries as above and leave tuples for the future. I volunteer to do it but wait for your comments.

Eq for lists, sets, dicts all make sense IMHO
I really don't have any sort of opinion on Ord for any of these. I don't think I've ever used it and haven't spent enough time meditating on what it even means to have an opinion. @nordlander would need to chime in.... or you go ahead with Eq for now and do Ord later!?

I'm all in favor of having both Eq and Ord, but of course Eq has a higher priority!

But the tuple case is interesting! In fact, it's an instance of a general problem that languages like Haskell has when abstracting over tuples, but where we might have a chance of improving things because our tuples are based on rows. It also touches on the fact that from a Python perspective it might be reasonable to expect some means of doing regular computations over tuples, like map and apply.
However, I suppose this effort will have to wait until we're done solving more urgent needs. Which is to say that I think any temporary hack needed to obtain equality for tuples is acceptable, as long as we don't forget our long-term goal is still a proper (and beautiful!) solution.

I'd like to close this issue and create a new one, more refined, to the items that still remain. @sydow do you think you can do that? You have the subject matter expertise here... :)

Ord instances for lists and docts are now implemented (pull request #719). We close this issue now; I will open a  new one for tuples.


[workloadmeta/store_test] Delete duplicate assert

What does this PR do?
This PR is a small cleanup. It just deletes a duplicate assert in comp/core/workloadmeta/impl/store_test.go.
Describe how to test/QA your changes
Skip.

/merge


Timeout when connecting to my broker

I have this:
    config = {
        "listeners": {
            "default": {
                "type": "tcp",
                "bind": f"<IP_ADDRESS>:{port}",
            }
        },
        "sys_interval": 10,
        "auth": {
            "allow-anonymous": True,
            "plugins": ["auth_anonymous"],
        },
        "topic-check": {"enabled": False},
    }
    brk = Broker(config)
    await brk.start()
    await asyncio.sleep(600) # just for test

When trying to connect to my broker, I only run into timeouts.
What am I missing?

This should work, please try with the newest version if you still encounter the issue: https://pypi.org/project/amqtt/0.11.0b1/


Migration error after deleting sqlite3 db

After deleting the sqlite3 database I cannot migrate anymore to start from scratch again. (Is there another way to do this?)
I'm not 100% sure if this belongs to this repository...
manage-py migrate results in:
Operations to perform:
  Synchronize unmigrated apps: treebeard, djangocms_admin_style, sekizai, parler, messages, meta_mixin, cmsplugin_filer_image, taggit_autosuggest, meta, sass_processor, sitemaps, fablab_website, staticfiles
  Apply all migrations: djangocms_text_ckeditor, sessions, admin, cms, djangocms_column, djangocms_teaser, djangocms_video, auth, djangocms_googlemap, djangocms_picture, menus, easy_thumbnails, djangocms_link, contenttypes, djangocms_inherit, djangocms_blog, reversion, djangocms_file, taggit, djangocms_style, sites, filer
Synchronizing apps without migrations:
  Creating tables...
    Creating table cmsplugin_filer_image_filerimage
    Creating table cmsplugin_filer_image_thumbnailoption
    Running deferred SQL...
  Installing custom SQL...
Running migrations:
  Rendering model states...Traceback (most recent call last):
  File "././djangocms//manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/venv/lib/python3.4/site-packages/django/core/management/__init__.py", line 354, in execute_from_command_line
    utility.execute()
  File "/venv/lib/python3.4/site-packages/django/core/management/__init__.py", line 346, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/venv/lib/python3.4/site-packages/django/core/management/base.py", line 394, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/venv/lib/python3.4/site-packages/django/core/management/base.py", line 445, in execute
    output = self.handle(*args, **options)
  File "/venv/lib/python3.4/site-packages/django/core/management/commands/migrate.py", line 222, in handle
    executor.migrate(targets, plan, fake=fake, fake_initial=fake_initial)
  File "/venv/lib/python3.4/site-packages/django/db/migrations/executor.py", line 100, in migrate
    state.apps  # Render all real_apps -- performance critical
  File "/venv/lib/python3.4/site-packages/django/utils/functional.py", line 59, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/venv/lib/python3.4/site-packages/django/db/migrations/state.py", line 166, in apps
    return StateApps(self.real_apps, self.models)
  File "/venv/lib/python3.4/site-packages/django/db/migrations/state.py", line 232, in __init__
    self.render_multiple(list(models.values()) + self.real_models)
  File "/venv/lib/python3.4/site-packages/django/db/migrations/state.py", line 270, in render_multiple
    "for more" % (new_unrendered_models, get_docs_version())
django.db.migrations.state.InvalidBasesError: Cannot resolve bases for [<ModelState: 'cmsplugin_filer_image.FilerImage'>]
This can happen if you are inheriting models from an app with migrations (e.g. contrib.auth)
 in an app with no migrations; see https://docs.djangoproject.com/en/1.8/topics/migrations/#dependencies for more

OS:
Fedora:23
Details about local setup:
It's this project. If you want you can inspect all files and even run the docker container...

django 1.8.7
djangocms 3.2.0
djangocms blog 0.3.6
packages from pypi
python 3
virtual environment

Steps to reproduce:

set up a djangocms-blog project with sqlite3 (as you can see in my repository...)
manage.py makemigrations
manage.py migrate
add some blog posts or do what ever you do with a djangocms...
delete the sqlite3 database
manage.py migrate

Merry christmas ;) :christmas_tree: :santa:

This is an issue with the filer cmsplugin, not filer standard.

Ok, thanks. Should I report it there?

Yeah, post it over here: https://github.com/divio/cmsplugin-filer

Ok, it's now here: https://github.com/divio/cmsplugin-filer/issues/207


docs daemon example: i/o timeout

using this example: https://godoc.org/github.com/go-mail/mail#ex-package--Daemon.
the email gets sent however after 30 seconds it throws an error on s.Close()
error is: "write tcp [myipv6addr]:56186->[2a06:1700:0:b::c0cc]:465: i/o timeout". also tried different email providers, same issue
does anyone have any idea why?

This is happening when a SMTP server doesn't respond to the QUIT command sent by s.Close(). The SendCloser implementation uses net/smtp for its SMTP client. I'm not sure how to remedy the issue. I just log.Println(err) and continue instead of panic(err)

It seems that this problem is related to the timeout and how net package handles it. he Dial method sets SetDeadline
if d.Timeout > 0 {
	conn.SetDeadline(time.Now().Add(d.Timeout))
}

and in net package specification
        // SetDeadline sets the read and write deadlines associated
        // with the connection. It is equivalent to calling both
        // SetReadDeadline and SetWriteDeadline.
        //
        // A deadline is an absolute time after which I/O operations
        // fail with a timeout (see type Error) instead of
        // blocking. The deadline applies to all future and pending
        // I/O, not just the immediately following call to ReadFrom or
        // WriteTo. After a deadline has been exceeded, the connection
        // can be refreshed by setting a deadline in the future.
        //
        // An idle timeout can be implemented by repeatedly extending
        // the deadline after successful ReadFrom or WriteTo calls.
        //
        // A zero value for t means I/O operations will not time out.
        SetDeadline(t time.Time) error

This should mean that the deadline occurs even for active connections. There are two parameters Timeout and Deadline, but it seems the timeout does not work as intended and the connection is terminated by deadline part. This lead to the situation where, it tries to close connection that was already closed by deadline, therefore such error occurs.
The NewDialer function (see bellow).
// NewDialer returns a new SMTP Dialer. The given parameters are used to connect
// to the SMTP server.
func NewDialer(host string, port int, username, password string) *Dialer {
	return &Dialer{
		Host:         host,
		Port:         port,
		Username:     username,
		Password:     password,
		SSL:          port == 465,
		Timeout:      10 * time.Second,
		RetryFailure: true,
	}
}

Uses default timeout for 10 seconds and in the description daemon is set to timeout after 30 seconds. Thus the connection would be closed 3 times before the action in the daemon occurs. Also, please note that after you send the message it will also set the deadline for the specified timeout.
To solve the problem, you have set dialer.Timeout to be greater (as equal does not work), than the timeout in the daemon.
But all in all I think that this is a bug in the implementation. The code snippet show the behavior of standard net.Dial vs the mail.Dialer and its timeouts.
package main

import (
	"fmt"
	"log"
	"net"
	"time"

	"github.com/go-mail/mail"
)

var MailerChannel = make(chan *mail.Message)

func addr(host string, port int) string {
	return fmt.Sprintf("%s:%d", host, port)
}

func runDaemon(dialer *mail.Dialer) {
	go func() {

		defer func() {
			if r := recover(); r != nil {
				fmt.Println("[DAEMON] Recovered ", r)
				time.Sleep(5 * time.Second)
				runDaemon(dialer)

			}
		}()
		var s mail.SendCloser
		var err error

		open := false

		for {
			if !open {
				log.Println("[DAEMON] Opening connection")
				s, err = dialer.Dial()
				if err != nil {
					log.Println("[DAEMON] failed dial:", err)
					panic(err)
				} else {
					open = true
				}

			}
			select {
			case m, ok := <-MailerChannel:
				log.Println("[DAEMON] Recevied message")
				if !ok {
					return
				}
				if err := mail.Send(s, m); err != nil {
					log.Print(err)
					open = false
				}
				if err := s.Close(); err != nil {
					log.Println("[DAEMON] Closing now", err)
				}

			// Change TIMEOUT to 4 * time.Second and everything will start working
			case <-time.After(TIMEOUT): // error occurs
				//			case <-time.After(4 * time.Second): // error does not occur
				log.Println("[DAEMON] timeout time")
				if open {
					log.Println("[DAEMON] conn still open")
					if err := s.Close(); err != nil {
						log.Println("[DAEMON] error closing connection", err)
					}
					open = false
				}
			}
		}
	}()

}

func InitiateDaemon() {

	dialer := mail.NewDialer(SERVER, PORT, USER, PASS)
	dialer.Timeout = TIMEOUT

	runDaemon(dialer)

}

var (
	SERVER  string        = "smtp.server.address"
	PORT    int           = 25
	USER    string        = "user"
	PASS    string        = "pass"
	TIMEOUT time.Duration = 5 * time.Second // seconds
)

func main() {
	log.Println("time:", time.Now())
	InitiateDaemon()

	for {
		con, err := net.DialTimeout("tcp", addr(SERVER, PORT), TIMEOUT)
		if err != nil {
			log.Println("Failed Dialer:", err)

		} else {
			log.Println("Regular connection success")
			err = con.Close()
			if err != nil {
				log.Println("failed to close connection", err)
			}
		}

		time.Sleep(1 * time.Second)
	}

}


What is the internal scene of gateway?

When providing the client with HTTP protocol capability, you can use this gateway. You don't need to start an HTTP service by yourself. It provides HTTP capability for all tar services.

提供给客户端http协议能力的时候，可以使用这个网关，不需要自己启动一个http服务了，统一给所有的tars服务提供了 http的能力。

Is it just the HTTP protocol?

只是http协议吗？

There are still current limiting, fusing, JSON, tup.

还有限流，熔断，json，tup。

What's the difference from other HTTP gateways?

那跟其他http网关的区别是什么？

If you import HTTP and export tars, you don't need to transfer agreements.
The service itself is also managed on the tar platform, so the back-end tar service expansion and so on can be completely seamless perception.
At the same time, it also supports the forwarding of ordinary HTTP to replace some functions of nginx. The forwarding configuration of the gateway is managed uniformly on the tars web.

入口http, 出口tars，就不需要转协议什么的。
服务本身管理也在tars平台上，所以后端tars服务扩容之类的，都能完全无缝感知。
同时也支持普通http的转发，取代部分nginx的功能。网关的转发配置在tars-web上统一管理。

Is the server-side protocol to be changed to JSON?

那么服务端的协议是不是要改为json之类的？

No, use the new version of the language lib and recompile it.

并不用，使用新版本的语言lib, 重新编译即可。
apigateway带了协议转换了，部署到平台后，客户端安apigateway定义好的url和json格式就可以请求到后端制定的tars服务了。

Can the request body be directly JSON when calling HTTP?

http调的时候请求体可以直接json吗？

HTTP request, put JSON in the package, and take a look at the document.

http请求，包体里面放json，看一下文档。

Does the server need to upgrade to 1.7.2?

服务端需要升级到1.7.2吗？

The support of java version is above 1.7.2. If you originally provided HTTP service for the client using springboot, you need to take a look at the usage scenario, switch to the request mode of apigateway, and the business clients such as IOS and Android need to be changed accordingly.

java版本的支持是1.7.2以上，若是原本给客户端使用springboot提供了http的服务的，那么需要看一下使用场景，需要切换成apigateway的请求模式，ios和android等业务掉用端，需要做相应的改变。

After reading the document, it is said that the body of post serializes the contents of the basepacket package tars. I also want to ask: where can I see the basepacket? Is there a document on the tars communication protocol and serialization protocol?

看了一下文档说post的body为BasePacket包tars序列化的内容。还想问下：BasePacket这个包可以在哪里看到？有没有tars通信协议和序列化协议的文档？

The official document of protocol design is available. You can have a look at the document.

协议的设计官方的文档有，可以看一下文档。


Added x-forwarded-for to nginx proxy headers

request.headers['x-forwarded-for'] should now return player's IP address instead of undefined

Thank you for the addition @Snirozu 💙


New sites not listed when using ploi init

Hi Felix,
I love the CLI, thank you for making this! Since initialising the CLI tool it seems new sites aren't being loaded when I init a project. I just see the sites that were available when I started using the CLI.
I can however link a project by manually creating the ploi.yml file.

Hi, first of all thanks for the kind words.
Could you explain where you would expect your sites to be shown or how to reproduce that?
Do you mean when running ploi init, selecting a server and then trying to link the repository to an already existing site?

Hi Felix, yes I’m sorry. That’s exactly what I mean. Let me know if you need to know more. :-)

That's kind of weird. The tool sends an API request every time you select "No" after asking you to create a new site https://github.com/schmidfelix/ploi-cli/blob/473bf444950a2918fda0e50d4046337cf2d9c3da/app/Commands/InitCommand.php#L61 and does not do any caching.
Please make sure to also select the correct server before. Are your sites listed in the ploi.io dashboard on the selected server?

That's weird indeed. My site is listed on the dashboard. Feel free to reach out on Discord if you want me to send some screenshots of both listings. You're probably active there as well :-).


Support using Windows for development/source of deployment

Many people (myself included), do development on a windows machine. While I understand that supporting windows on the server would be complicated and probably not worth it, it would be very beneficial if it would atleast be possible to use windows as a platform for development / source of deployment.
I haven't been digging too deeply into Woven, but if the only reason for this limitation is that Woven uses rsync, I would imagine there are other solutions available that would work equally well on windows.

Closing old issues that don't matter to me anymore, and that doesn't seem to have any traction/interest.


Directory does not exists

The directory '.gradle\caches\minecraft\de\oceanlabs\mcp\mcp_snapshot' does not exist.
You need to run forge-gradle to generate the mappings.

Project is unmaintained. Look at using https://fabricmc.net/ instead.