funding confirmation not detected on master

Background
I open a channel with LND on regtest, up until publishing the funding transaction. I then disconnect the node creating the funding transaction. I close LND, mine 4 blocks, and notice that even though LND wants 3 confirmations, it is not noticing the burial of the funding transaction.
Your environment

version of lnd: 0ce2d6f523c784b926eceb4841082164ecc08e9f
which operating system (uname -a on *Nix): Linux
version of btcd, bitcoind, or other backend: bitcoind v<IP_ADDRESS>-g3b0422118368a22f9eccb0103c15cd4010ac8d85
any other relevant environment details

Steps to reproduce
I start up LND using
./lnd-debug --bitcoin.active --bitcoin.regtest --lnddir=/tmp/lnd1 --bitcoin.node=bitcoind --bitcoind.rpcuser=doggman --bitcoind.rpcpass=donkey --bitcoind.zmqpubrawblock=tcp://<IP_ADDRESS>:28332 --bitcoind.zmqpubrawtx=tcp://<IP_ADDRESS>:28333 --bitcoind.rpchost=localhost:18554 --debuglevel=NTFN=trace,FNDG=trace

I create a wallet using
% ./lncli-debug -n regtest --lnddir=/tmp/lnd1 create

This causes a lot of lnd output, the last line being
2020-01-10 18:58:55.820 [INF] LNWL: Finished rescan for 0 addresses (synced to block 0fa75ee1272e66b6620a1223ea12fd5cc24822780a33f3629d0ea4fff35710f1, height 6929)

So the chain is on height 6929.
Now, I open a channel with LND.
This causes the following output:
2020-01-10 19:00:44.314 [INF] SRVR: New inbound connection from <IP_ADDRESS>:59416
2020-01-10 19:00:44.314 [INF] SRVR: Finalizing connection to 0335a7f5eb7b78b4654600d0451cd9d7a42137306fc78cefaedc93c2badb4394e9@<IP_ADDRESS>:59416, inbound=true
2020-01-10 19:00:44.426 [INF] FNDG: Recv'd fundingRequest(amt=0.01 BTC, push=0 mSAT, delay=6, pendingId=75305420867ecb98fef365bac69e310d89b57a97b6b2c9c5aca98b0b43dab2a8) from peer(0335a7f5eb7b78b4654600d0451cd9d7a42137306fc78cefaedc93c2badb4394e9)
2020-01-10 19:00:44.426 [INF] CHFD: Performing funding tx coin selection using 0 sat/kw as fee rate
2020-01-10 19:00:44.467 [INF] FNDG: Requiring 3 confirmations for pendingChan(75305420867ecb98fef365bac69e310d89b57a97b6b2c9c5aca98b0b43dab2a8): amt=0.01 BTC, push_amt=0 mSAT, tweakless=false, upfrontShutdown=a91481116fa39682d53cb413dafaf529ac1588c0155087
2020-01-10 19:00:44.467 [INF] FNDG: Sending fundingResp for pending_id(75305420867ecb98fef365bac69e310d89b57a97b6b2c9c5aca98b0b43dab2a8)
2020-01-10 19:00:44.468 [DBG] FNDG: Remote party accepted commitment constraints: (channeldb.ChannelConstraints) {
 DustLimit: (btcutil.Amount) 0.00000005 BTC,
 ChanReserve: (btcutil.Amount) 0.0001 BTC,
 MaxPendingAmount: (lnwire.MilliSatoshi) 990000000 mSAT,
 MinHTLC: (lnwire.MilliSatoshi) 1 mSAT,
 MaxAcceptedHtlcs: (uint16) 483,
 CsvDelay: (uint16) 144
}

2020-01-10 19:00:48.789 [INF] FNDG: completing pending_id(75305420867ecb98fef365bac69e310d89b57a97b6b2c9c5aca98b0b43dab2a8) with ChannelPoint(7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa:0)
2020-01-10 19:00:48.797 [DBG] FNDG: Creating chan barrier for ChanID(fac4fc658d730be02abdb28551aadef0dc00711a0120ad6d12336fbe611f967f)
2020-01-10 19:00:48.797 [INF] FNDG: sending FundingSigned for pending_id(75305420867ecb98fef365bac69e310d89b57a97b6b2c9c5aca98b0b43dab2a8) over ChannelPoint(7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa:0)
2020-01-10 19:00:48.797 [INF] CNCT: Creating new ChannelArbitrator for ChannelPoint(7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa:0)
2020-01-10 19:00:48.797 [INF] CNCT: ChannelArbitrator(7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa:0): starting state=StateDefault
2020-01-10 19:00:48.797 [INF] NTFN: New block epoch subscription
2020-01-10 19:00:48.798 [INF] NTFN: New spend subscription: spend_id=1, outpoint=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa:0, script=0 ab23263376cb8e6ef1c3b4cfb4ccee3f14cea658847ae36d139e97c79e6683d9, height_hint=6929
2020-01-10 19:00:48.798 [INF] NTFN: Dispatching historical spend rescan for outpoint=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa:0, script=0 ab23263376cb8e6ef1c3b4cfb4ccee3f14cea658847ae36d139e97c79e6683d9, start=6929, end=6929
2020-01-10 19:00:48.799 [INF] CNCT: Close observer for ChannelPoint(7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa:0) active
2020-01-10 19:00:48.799 [INF] NTFN: New confirmation subscription: conf_id=1, txid=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa, num_confs=3 height_hint=6929
2020-01-10 19:00:48.800 [DBG] NTFN: Dispatching historical confirmation rescan for txid=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa
2020-01-10 19:00:48.799 [INF] NTFN: New block epoch subscription
2020-01-10 19:00:48.805 [INF] FNDG: Waiting for funding tx (7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa) to reach 3 confirmations
2020-01-10 19:00:48.806 [DBG] NTFN: Confirmation details for txid=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa not found during historical dispatch, waiting to dispatch at tip
2020-01-10 19:00:48.806 [TRC] NTFN: Updating confirm hints to height 6929 for [txid=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa]
2020-01-10 19:00:48.808 [INF] NTFN: Historical spend dispatch finished for request outpoint=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa:0, script=0 ab23263376cb8e6ef1c3b4cfb4ccee3f14cea658847ae36d139e97c79e6683d9 (start=6929 end=6929) with details: <nil>
2020-01-10 19:00:48.820 [TRC] NTFN: Updating spend hint to height 6929 for [outpoint=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa:0, script=0 ab23263376cb8e6ef1c3b4cfb4ccee3f14cea658847ae36d139e97c79e6683d9]
2020-01-10 19:00:48.834 [DBG] NTFN: Updated spend hint to height=6929 for unconfirmed spend request outpoint=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa:0, script=0 ab23263376cb8e6ef1c3b4cfb4ccee3f14cea658847ae36d139e97c79e6683d9
2020-01-10 19:00:49.071 [INF] PEER: unable to read message from 0335a7f5eb7b78b4654600d0451cd9d7a42137306fc78cefaedc93c2badb4394e9@<IP_ADDRESS>:59416: EOF
2020-01-10 19:00:49.071 [INF] PEER: Disconnecting 0335a7f5eb7b78b4654600d0451cd9d7a42137306fc78cefaedc93c2badb4394e9@<IP_ADDRESS>:59416, reason: read handler closed
2020-01-10 19:00:49.172 [DBG] FNDG: Cancelling all reservations for peer 0335a7f5eb7b78b4654600d0451cd9d7a42137306fc78cefaedc93c2badb4394e9
2020-01-10 19:00:49.172 [DBG] FNDG: No active reservations for node: 0335a7f5eb7b78b4654600d0451cd9d7a42137306fc78cefaedc93c2badb4394e9
2020-01-10 19:00:49.173 [ERR] SRVR: Unable to retrieve advertised address for node 0335a7f5eb7b78b4654600d0451cd9d7a42137306fc78cefaedc93c2badb4394e9: unable to find node

Note the "Waiting for funding tx". So I mine 4 blocks using bitcoin-cli generatetoaddress 4 $(bitcoin-cli getnewaddress). I verify that the funding tx has confirmations by using

% bitcoin-cli getblock $(bitcoin-cli getblockhash 6930) | jq .tx
[
  "93590b7e59ba63b9382e12e85f6eed694b5797bb97658ca3896530878f018dc4",
  "7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa"
]

Which includes the hash of the funding tx, and by using
% bitcoin-cli getblock $(bitcoin-cli getblockhash 6930) | jq .confirmations
4

I don't know which log output to expect, but I start up the other node, which sends funding_locked, and expects a reply, but doesn't get it.
This is the final log output of LND:

2020-01-10 19:02:29.544 [INF] CRTR: Pruning channel graph using block 2a6948540a683594eace744394f5f3fe47041c20ac035bac3c46928d883486fc (height=6930)
2020-01-10 19:02:29.550 [INF] CRTR: Block 2a6948540a683594eace744394f5f3fe47041c20ac035bac3c46928d883486fc (height=6930) closed 0 channels
2020-01-10 19:02:29.625 [INF] CRTR: Pruning channel graph using block 0d9d07f5950d3ba840dee39e38fea7ceb8ee5078ff7624a78bdafb6472b78344 (height=6931)
2020-01-10 19:02:29.628 [INF] CRTR: Block 0d9d07f5950d3ba840dee39e38fea7ceb8ee5078ff7624a78bdafb6472b78344 (height=6931) closed 0 channels
2020-01-10 19:02:29.628 [DBG] NTFN: Filtering 2 txns for 1 spend requests at height 6930
2020-01-10 19:02:29.628 [TRC] NTFN: Updating confirm hints to height 6930 for [txid=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa]
2020-01-10 19:02:29.629 [INF] CRTR: Pruning channel graph using block 7c7d9881aa364c3967aa38bea96af42d1194c8bf2196ece61a4cfa530855d874 (height=6932)
2020-01-10 19:02:29.633 [INF] CRTR: Block 7c7d9881aa364c3967aa38bea96af42d1194c8bf2196ece61a4cfa530855d874 (height=6932) closed 0 channels
2020-01-10 19:02:29.634 [INF] CRTR: Pruning channel graph using block 4189efc4d4a11a1dd91180f1bbc5ac1b457a33d25d4f434602e9dd9a4a9bff66 (height=6933)
2020-01-10 19:02:29.638 [INF] CRTR: Block 4189efc4d4a11a1dd91180f1bbc5ac1b457a33d25d4f434602e9dd9a4a9bff66 (height=6933) closed 0 channels
2020-01-10 19:02:29.643 [TRC] NTFN: Updating spend hint to height 6930 for [outpoint=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa:0, script=0 ab23263376cb8e6ef1c3b4cfb4ccee3f14cea658847ae36d139e97c79e6683d9]
2020-01-10 19:02:29.657 [INF] NTFN: New block: height=6930, sha=2a6948540a683594eace744394f5f3fe47041c20ac035bac3c46928d883486fc
2020-01-10 19:02:29.658 [INF] UTXN: Attempting to graduate height=6930: num_kids=0, num_babies=0
2020-01-10 19:02:29.660 [DBG] NTFN: Filtering 1 txns for 1 spend requests at height 6931
2020-01-10 19:02:29.661 [TRC] NTFN: Updating confirm hints to height 6931 for [txid=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa]
2020-01-10 19:02:29.677 [TRC] NTFN: Updating spend hint to height 6931 for [outpoint=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa:0, script=0 ab23263376cb8e6ef1c3b4cfb4ccee3f14cea658847ae36d139e97c79e6683d9]
2020-01-10 19:02:29.691 [INF] NTFN: New block: height=6931, sha=0d9d07f5950d3ba840dee39e38fea7ceb8ee5078ff7624a78bdafb6472b78344
2020-01-10 19:02:29.691 [INF] UTXN: Attempting to graduate height=6931: num_kids=0, num_babies=0
2020-01-10 19:02:29.693 [DBG] NTFN: Filtering 1 txns for 1 spend requests at height 6932
2020-01-10 19:02:29.693 [TRC] NTFN: Updating confirm hints to height 6932 for [txid=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa]
2020-01-10 19:02:29.707 [TRC] NTFN: Updating spend hint to height 6932 for [outpoint=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa:0, script=0 ab23263376cb8e6ef1c3b4cfb4ccee3f14cea658847ae36d139e97c79e6683d9]
2020-01-10 19:02:29.719 [INF] NTFN: New block: height=6932, sha=7c7d9881aa364c3967aa38bea96af42d1194c8bf2196ece61a4cfa530855d874
2020-01-10 19:02:29.720 [INF] UTXN: Attempting to graduate height=6932: num_kids=0, num_babies=0
2020-01-10 19:02:29.724 [DBG] NTFN: Filtering 1 txns for 1 spend requests at height 6933
2020-01-10 19:02:29.724 [TRC] NTFN: Updating confirm hints to height 6933 for [txid=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa]
2020-01-10 19:02:29.738 [TRC] NTFN: Updating spend hint to height 6933 for [outpoint=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa:0, script=0 ab23263376cb8e6ef1c3b4cfb4ccee3f14cea658847ae36d139e97c79e6683d9]
2020-01-10 19:02:29.750 [INF] NTFN: New block: height=6933, sha=4189efc4d4a11a1dd91180f1bbc5ac1b457a33d25d4f434602e9dd9a4a9bff66
2020-01-10 19:02:29.751 [INF] UTXN: Attempting to graduate height=6933: num_kids=0, num_babies=0
2020-01-10 19:06:19.009 [INF] SRVR: New inbound connection from <IP_ADDRESS>:59554
2020-01-10 19:06:19.010 [INF] SRVR: Finalizing connection to 0335a7f5eb7b78b4654600d0451cd9d7a42137306fc78cefaedc93c2badb4394e9@<IP_ADDRESS>:59554, inbound=true
2020-01-10 19:06:19.015 [INF] PEER: NodeKey(0335a7f5eb7b78b4654600d0451cd9d7a42137306fc78cefaedc93c2badb4394e9) loading ChannelPoint(7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa:0)
2020-01-10 19:06:19.016 [WRN] PEER: Unable to find our forwarding policy for channel 7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa:0, using default values
2020-01-10 19:06:19.016 [INF] HSWC: Removing channel link with ChannelID(fac4fc658d730be02abdb28551aadef0dc00711a0120ad6d12336fbe611f967f)
2020-01-10 19:06:19.016 [INF] HSWC: ChannelLink(0:0:0): starting
2020-01-10 19:06:19.017 [INF] HSWC: Adding pending link chan_id=fac4fc658d730be02abdb28551aadef0dc00711a0120ad6d12336fbe611f967f, short_chan_id=0:0:0
2020-01-10 19:06:19.017 [INF] HSWC: ChannelLink(0:0:0): HTLC manager started, bandwidth=0 mSAT
2020-01-10 19:06:19.017 [INF] HSWC: ChannelLink(0:0:0): attempting to re-resynchronize
2020-01-10 19:06:19.033 [INF] HSWC: ChannelLink(0:0:0): received re-establishment message from remote side
2020-01-10 19:06:19.076 [DBG] FNDG: Received FundingLocked for ChannelID(fac4fc658d730be02abdb28551aadef0dc00711a0120ad6d12336fbe611f967f) from peer 0335a7f5eb7b78b4654600d0451cd9d7a42137306fc78cefaedc93c2badb4394e9

Expected behaviour
I expected LND to reply to funding_locked.

I was unable to reproduce, but the issue seems to point towards the confirmation not being detected by lnd. I can tell because the height hint of the transaction is being updated past its confirmation height:
2020-01-10 19:02:29.628 [TRC] NTFN: Updating confirm hints to height 6930 for [txid=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa]
2020-01-10 19:02:29.643 [TRC] NTFN: Updating spend hint to height 6930 for [outpoint=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa:0, script=0 ab23263376cb8e6ef1c3b4cfb4ccee3f14cea658847ae36d139e97c79e6683d9]
2020-01-10 19:02:29.657 [INF] NTFN: New block: height=6930, sha=2a6948540a683594eace744394f5f3fe47041c20ac035bac3c46928d883486fc
2020-01-10 19:02:29.660 [DBG] NTFN: Filtering 1 txns for 1 spend requests at height 6931
2020-01-10 19:02:29.661 [TRC] NTFN: Updating confirm hints to height 6931 for [txid=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa]
2020-01-10 19:02:29.677 [TRC] NTFN: Updating spend hint to height 6931 for [outpoint=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa:0, script=0 ab23263376cb8e6ef1c3b4cfb4ccee3f14cea658847ae36d139e97c79e6683d9]
2020-01-10 19:02:29.691 [INF] NTFN: New block: height=6931, sha=0d9d07f5950d3ba840dee39e38fea7ceb8ee5078ff7624a78bdafb6472b78344
2020-01-10 19:02:29.693 [DBG] NTFN: Filtering 1 txns for 1 spend requests at height 6932
2020-01-10 19:02:29.693 [TRC] NTFN: Updating confirm hints to height 6932 for [txid=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa]
2020-01-10 19:02:29.707 [TRC] NTFN: Updating spend hint to height 6932 for [outpoint=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa:0, script=0 ab23263376cb8e6ef1c3b4cfb4ccee3f14cea658847ae36d139e97c79e6683d9]
2020-01-10 19:02:29.719 [INF] NTFN: New block: height=6932, sha=7c7d9881aa364c3967aa38bea96af42d1194c8bf2196ece61a4cfa530855d874
2020-01-10 19:02:29.724 [DBG] NTFN: Filtering 1 txns for 1 spend requests at height 6933
2020-01-10 19:02:29.724 [TRC] NTFN: Updating confirm hints to height 6933 for [txid=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa]
2020-01-10 19:02:29.738 [TRC] NTFN: Updating spend hint to height 6933 for [outpoint=7f961f61be6f33126dad20011a7100dcf0deaa5185b2bd2ae00b738d65fcc4fa:0, script=0 ab23263376cb8e6ef1c3b4cfb4ccee3f14cea658847ae36d139e97c79e6683d9]

This seems related to https://github.com/lightningnetwork/lnd/issues/3692, cc @halseth.

@wpaulino did you, in your reproduction, also disconnect the counterparty after creation of the funding transaction? I suspect that this might be a sufficient condition.

I'm also unable to reproduce this. I restarted the first node (the one that created the funding transaction), after it was constructed.
Are you able to reproduce reliably?


Fund participation in AAS 240

The 240th meeting of the American Astronomical Society will be held in-person in Pasadena, CA in June 2022.
To further support the goal of increasing Astropy Project visibility at this meeting, we would like to make funding available to offset the travel costs of Project members’ attendance. If you are not fully funded by other sources to attend the meeting, please comment on this issue with a funding request and state the activities you plan to undertake that are beneficial to the Project. The funding request should include items and estimated costs. (For example, “approximately $1000 to cover two nights hotel and half of the airfare.”)
After the meeting, please comment the issue again with any results or take-aways that are useful for the Project as a whole. For example, “I spoke to folks from the AMAZING collaboration about functionality they need and possible new contributions. I got some feedback about the docs of the foobar package and opened issue ## describing the challenge in more detail.”

@kelle Is this also usable to cover the cost of registering for the workshop, since it seems that even instructors are supposed to register and pay for that?

Yes. Please post explicit request and cost here.

Great, thanks. I'm requesting $100 of support to pay for registration for the Astropy workshop on Sunday June 12, which I'll be helping run. I can email a copy of my receipt (I paid for this separately from the rest of the registration, which is covered by other funding) to whoever is relevant.

After travel is complete, please post reimbursement requests to https://opencollective.com/astropy/projects/astropy-moore-8435/expenses/new


Extend "Hierarchical relationships and constraints" table

There are some node types currently not included in it:

Const
Call
LoadConst
Declare
AlisasDeclare
AliasDef

(Also CallIndirect but this should probably move to the Tierkreis/higher-order resource; see #154 .)

That table is only for containers, note all of these are non-container operations, they should be covered by O. If not, O needs redefining to be more general.

OK yes. I think a super-table listing all node types and the constraints on edge types between them would be useful.

Perhaps an appendix item?


add bullet and ordered lists

Adds bullet lists and ordered lists. I can see that my editor did some formatting of some js, which is annoying. If you want I can revert it.

Hi Søren, thanks a lot for your PR! Great changes. Regarding the formatting changes: I was faster adding the relevant lines by hand, its now in main. Feel free to check it out. Note that main now targets leptos 0.7.


¨M always casts b to an iterable

Let's say you realized that ¨M is awesome because it lets you apply a function to a certain index or list of indexes in a list. So you decide to use it to apply a function to the 10th element in a list. Well now there's a problem. The 10 gets cast to an iterable, and suddenly the function is being applied to the 0th and 1st elements in the list instead. Suddenly you have to ask OP if you can guarantee inputs be single digits, and the OP says no, and now you got gamed on, nerd.
Example: Try it Online!

Try it Online!


Limit max size for stdout and stderr capture

The fix for #28 blindly captures stdout and stderr without limiting its size. This can be an issue when the invoked function (java or python) dumps a lot of logs. There must be a way to limit the stdout and stderr preferably at alcove library so that we do not run out of memory.

The following commit closes #30
https://github.com/beamparticle/beamparticle/commit/00cb7e1f494cc296cf6421b19db54ed973325309


NoClassDefFoundError: com.mixpanel.android.mpmetrics.MixpanelActivityLifecycleCallbacks

My app is crashing for some users. I don't know if it's always or sometimes. All devices on which it crashes run Android 2.3.3 to 2.3.7. I'm using Mixpanel 4.8.7.
STACK TRACES:
java.lang.NoClassDefFoundError: com.mixpanel.android.mpmetrics.MixpanelActivityLifecycleCallbacks
	at com.mixpanel.android.mpmetrics.MixpanelAPI.registerMixpanelActivityLifecycleCallbacks(MixpanelAPI.java:1271)
	at com.mixpanel.android.mpmetrics.MixpanelAPI.<init>(MixpanelAPI.java:246)
	at com.mixpanel.android.mpmetrics.MixpanelAPI.<init>(MixpanelAPI.java:196)
	at com.mixpanel.android.mpmetrics.MixpanelAPI.getInstance(MixpanelAPI.java:300)
	at com.tomsyweb.soc.MainActivity.onCreate(MainActivity.java:35)

The line 35 of MainActivity.java:
mMixpanel = MixpanelAPI.getInstance(this, MIXPANEL_API_TOKEN);
The devices on which it crashes, if it can help (I don't know if those are the only but it's those that appear in my developer console):

Galaxy S Glide
Xperia U
Galaxy Pocket.

@ismaeltoe This issue will be resolved with 4.8.8 which is coming out by the end of this week. In the meanwhile, you can always point your gradle file to use master branch from this repo. I'm so sorry for the inconvenience!

Hi, is it resolved in 4.9?

It is resolved in the latest release, yes 👍


DX-789 fix: update slack notification entry in .wukong.toml

Summary
We fix the entries for slack notification in .wukong.toml to reflect what WukongApiProxy is expecting
Ticket:
What's Changed
We update the entry to be like so:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Fadhil
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Fadhil, onimsha
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Fadhil
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Fadhil
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Fadhil, onimsha
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


chore: forgetting a comma in renovate.json [no need to review]

Testing the new check to validate renovate config.

The validation worked:


NikitK/ [FE Deriv.com squad] Deriv MT5 > Banner should be centered relative to the screen width

Changes:

dmt5 hero space between components

Type of change

[x] Bug fix
[ ] New feature
[ ] Update feature
[ ] Refactor code
[ ] Translation to code
[ ] Translation to crowdin
[ ] Script configuration
[ ] Improve performance
[ ] Style only
[ ] Dependency update
[ ] Documentation update
[ ] Release

Hi @NikitK-deriv , for larger screen the banner goes outside the container. Can you check this?

Hi @NikitK-deriv , for larger screen the banner goes outside the container. Can you check this?

@habib-deriv actually we don't have a container for this hero. Main container have width: 100% property.
In this case we can hardcode container for large screens or change space between 2 containers inside. Looks like this:

Please advice best solution 🙏

Hi @NikitK-deriv , yeah please add a container for this


Fix corner quad distortions

Distortions appear because we rely on normals in the process of building the quad.
Reworks algorithm to rely on delta vectors instead.
Aligns better with overall shape geometry, and also improves results of render_offset.

I can rebase it after #156 is merged.

Code looks fine, but I'm also not that familiar with the inner edge generation workings.
What exactly does this PR fix? Is it related to #156? Would it affect the outcome of #156, i.e. does #156 need to be tested with this PR or the other way round?
Can you provide an example image how it improves distortions?

#156 introduces a set of changes, one of which, as you know, is corner anti-distortion code. This PR achieves the same result, but instead of compensating for the "bad" generation result, it instead generates a "good" one. So the code is simpler and faster. As a side effect, this approach also improves render_offset results - additional benefits. This PR would be in direct conflict with #156, that is why I offered to rebase it after we merge that one. I my tests, unless you use render_offset, the result would be identical to #156.

Ah, thanks for clarifying.

Ready for review.
Test scene: corner_anti_distortion.zip

Besides the small optimization, LGTM.

Thanks, fixed it and merging :+1:


Show actionable error message when cli task order conflicts with build definiton

For example you have a build definiton like:
tasks.register('preGenerateFoo') {
    outputs.file file('build/1')
}

tasks.register('preAssembleFoo') {
    dependsOn 'preGenerateFoo'
}

tasks.register('cleanFoo') {
   destroyables.register file('build')
}

tasks.register('generateFoo') {
    outputs.file file('build/2')
}

tasks.register('assembleFoo') {
    inputs.files preGenerateFoo
    inputs.files generateFoo
}

Then when running:
./gradlew preAssembleFoo cleanFoo assembleFoo

Gradle will stall for some time and then print:
Unable to make progress running work. There are items queued for execution but none of them can be started

Running the tasks as:
./gradlew cleanFoo preAssembleFoo assembleFoo

fixes the issue.
The problem is, that cli task order conflicts with build definition, because user requests a task that destroys outputs in between producer and consumer.
While Gradle could is some cases do a better job with scheduling, this in some cases also conflicts with user expectations.
So one thing we could do here would be to have better error message and report that cli task order coflicts with build definition.
See also:
https://github.com/gradle/gradle/issues/26060

Why don't we go the other way, and instead of warn/fail, do the right thing? We could run anything that @Destroys before running anything else automatically, couldn't we?


fix: update packages

PR description
Describe your changes in detail here
Updated the used packages to the latest version there is.
Definition Of Done (DoD)
This PR can be squashed / merged if

[x] a developer is assigned
[x] the PR is NOT estimated
[x] the PR is labeled
[x] the PR is NOT assigned to the current sprint
[x] a meaningful title has been set according to https://www.conventionalcommits.org/
[x] the PR is described in detail
[x] the PR links to an issue
[ ] the PR has been reviewed

Add additional conditions here if necessary for this PR
Fix: #127

I have updated almost all the packages. There are 2 outdated versions the vuetify-loader isn't outdated, it's just in an alpha version, and it is the proper version for vuetify 3.
But the tesseract update introduces major changes and because I don't have the expertise in the proc folder maybe @Claiyc you could find a fix for it because when creating a capture area and starting the processing errors Accor.

Besides that, other people should try the application out and play around a bit with the regex etc. so everything still works as intended.

We use the latest version, the next would be a major change which will break things thats what I meant.

Updated it back to the latest version


[USHIFT-573] Regenerate client certificate when subject changes

The subject part of the certificate is used to authenticate the kubelet and limit the permissions on what can access. On a host name, the client certificate was not being regenerated, so the kubelet could not create a new entry for the new hostname, and blocked on a loop.
This commit forces the regeneration of the client certificate when the subject field on the disk file differs.

Which issue(s) this PR addresses:

Closes #

@mangelajo that file is vendored from library-go. Is there a PR to fix this upstream so we don't have to carry a patch? The rebase automation is likely to wipe this change out, otherwise.

/hold
you can't merge a vendor change

Lol, sorry
This is what happens when you click on "follow reference" in VSCode, .. edit and push a commit before the day ends.
I'll go send a PR to that library.

The subject part of the certificate is used to authenticate the kubelet and limit the permissions on what can access. On a host name, the client certificate was not being regenerated, so the kubelet could not create a new entry for the new hostname, and blocked on a loop.
This commit forces the regeneration of the client certificate when the subject field on the disk file differs.

Work moved here

https://github.com/openshift/library-go/pull/1422


form label with block shouldn't insert name automatically

With this code:
== form action: "/", method: :post do
  == csrf_tag
  == label name: "alpha" do
    | beta
    == check_box id="beta"

I get the following html output:
<form action="/" method="post">
  <input type="hidden" name="_csrf" value="..." />
  <label for="alpha" id="alpha_label">
    beta
    <input type="checkbox" name="beta" id="beta" value="1"/>
    <input type="hidden" name="beta" id="beta_default" value="0"/>
+    Alpha
  </label>
</form>

When giving a block to a label, I expect the block to be the contents of the label and nothing more.
currently jasper automatically appends the name

Hi guys ! I have two ideas for this issue
Option 1
In Rails when you pass a block to a label, the name is not appended, maybe we could remove this
  def label(name : String | Symbol)
    content = "#{yield}"
    label(name, content: content, for: name, id: "#{Kit.css_safe(name)}_label")
  end

So...now we need a method to display our block, maybe we could do it somethings like this
  def wrapper_field(*args)
    return "" unless args.first?
    args.join("")
  end

in our views:
      label(:name) do
        wrapper_field(
          check_box(:allowed),
          "name"
        )

Benefit: in this way you can concatenate many elements in a single method
Option 2
We could use a boolean to show the label


Documentation should explicitly mention that other archive file types are NOT scanned

I think the documentation should explicitly mention that only JAR, EAR and WAR files are scanned.
For example, often a rolled out software comes in the form of a ZIP file or RAR, TAR, TAR.GZ (TGZ), TAR.BZ2 or platform-specific files types like an extractable EXE or MSI files.
Other programming languages use ZIP the file format but with a different suffix as an archive format as well, e.g. Python uses the WHL suffix.
Such archive files might contain Java classes as well, probably wrapped in *.JAR archives inside the outer archive.
These file types will not be scanned and I think this should be mentioned.

That's a good point, I will add more details on how it works and what it scans.

@hvbtup Documentation has been updated, let me know if that should cover it and I will close the issue.
I have also added a short rationale why it doesn't scan these other archive formats. I might add .zip later though.

Looks OK for me.
I just stumbled upon this tool today after I wrote a similar tool for internal use on Monday.
In my tool we check the software we delivered, not the software that is running, so the use case is a bit different.

Hi @hvbtup, thanks that is actually very good feedback. I have not considered the use case from a software distributor yet, interesting!


Provide a way for the plugin to request the user to update plugin /backend

As users will start using the platform, we cannot rely on the IDE updates because they are not aggressive enough - if you don't check you don't see that you have any plugin updates.
https://www.figma.com/file/knBV9hsfk9Au7mDQdFAFea/READY-TO-DEV?node-id=1190-177711&t=GYnCSu8lOVoEUB0g-0
related to the backend issue: https://github.com/digma-ai/digma-collector-backend/issues/808
client requirements:
should call the new API periodically every 1hr
the contract should be defined between the client and the server see the related backend issue for more details.

should show messages for both plugin or backend updates

behavior Requirements:

We should have complete control of which version we want to push to users, users should not be notified of every release.

In case both the plugin and backend need to be updated, first we'll show a notification on the backend that needs to be updated, then and only if the backend was updated we'll show the user notification on plugin updates. the update order is crucial because of the case when a new API was added to the backend in order to support new client functionality.

We need the ability to specify the version compatibility range for different intellij platformVersions to support the following cases:

Client Platform: Intellij

user should get an update notification if a specific  plugin version available in the marketplace
In a case, a new platformVersion has breaking changes and we released a new plugin version for it, the previous platformVersion range should be set [X.Y.Z]-[PREVIOUS_PLUGIN_VERSION], so older platformVersion will not get notified on the newest plugin version
Client Platform: vscode:
user should get an update notification if a specific  plugin version available in the marketplace
need to discuss with @kshmidt-digma
Backend Version:
For now, we will continue not breaking backward compatibility with clients the  backend server version to notify should be  returned from the API

This API should be fully covered with tests otherwise in case of a bug, we won't be able to push notifications to users.
Flows:

Given:
the latest backend is 1.0.1
client  backend is 1.0.1
When
new backend version releases 1.0.2 AND  Digma would Not like to notify clients about the new version
Then
user should not see any notification
Given:
the latest backend is 1.0.1
client  backend is 1.0.1
When
A new backend version was released 1.0.2 AND  Digma would like to notify clients about the new version
Then
user should see the plugin backend update notification
Given:
the latest backend is 1.0.1
the latest plugin is 2.0.0
latest platformVersion is  3.0.0
client  backend is 1.0.1
client  plugin is 2.0.0
client platformVersion is  3.0.0
When
A new backend version was released 1.0.2 AND
A new plugin version was released 2.0.1 AND
Digma would like  to notify clients about both versions
Then
user should see the plugin backend update notification and only after upgrading the backend he should see the  plugin update notification
Given:
the latest plugin is 2.0.1 AND
latest platformVersion is  4.0.0 AND
plugin 2.0.0 is only compatible with platformVersion 3.0.0 and below AND
the client plugin is 2.0.0 AND
the client  platformVersion is  3.0.0
When
A new plugin version was released 2.0.2
Then
user should not get a notification on the new plugin version (2.0.2)
Given:
the latest plugin is 2.0.0 AND
latest platformVersion is  3.0.0 AND
the client plugin is 2.0.0 AND
the client  platformVersion is  3.0.0
When
A new  platformVersion released 4.0.0 AND  new  plugin released 2.0.1 AND
plugin 2.0.1 is only compatible with platformVersion 4.0.0 and above
Then
user should not get a notification on the new plugin version (2.0.2)
?

took a print screen from Figma:

I managed to extract the Dark icon:

@shaykeren , @doppleware, @shalom938, @kshmidt-digma   any ideas how to extract the lighter version of it?

You can export it from Figma the same way as the dark one.
Here it is:

Note: as it's a SVG (text file) you can just replace the fill color with the one you need. (e.g. this one has  #002D61)

@kshmidt-digma thanks.

@doppleware , @shaykeren we have enum for DeploymentType:
enum class BackendDeploymentType {
    SAAS,
    DockerCompose,
    DockerExtension,

can you please provide the UI needed per type?
as of now, I know that for docker type, the button will open the link to our extension.
but what should we do for other types?

agreed with @shaykeren that for DockerCompose i'm going to create similar text as provided in our wizard:

and will open in the editor a readme_update.md file
@doppleware any more comments?

I modified the text a bit so a user could know whether he's gonna update the backend or the plugin.

here are the texts:
Update Digma | Install latest plugin version
Update Digma | Install latest backend version
@doppleware can you approve?

agreed with @shaykeren to lower to frequency check to 5 minutes, so we won't maintain different timers, for checking backend and/or plugin versions.

@arik-dig text should be:
Update Recommended | Digma analysis backend
Update Recommended | Digma IDE plugin


Automatically lookup digital signature algorithm from JWT header

The current API appears to require the user to query the JWT header, then lookup the algorithm based on the name, and finally pass this function reference to Validate().
Could jose do this automatically? This would reduce the risk of mistakes. For example, some users might hardcode the RS256 algorithm, whereas real tokens may use a different algorithm.

Please do not do this. It's a serious security vulnerability. "none" is a valid algorithm, so if you trust the header for algorithm selection, someone can give you a perfectly valid token with no signature on it at all.
Further reading here: https://auth0.com/blog/critical-vulnerabilities-in-json-web-token-libraries/
Allowing the client (or an attacker) to select the algorithm is generally a bad idea. You should hard-code the algorithm.

Lol why is none a valid option?

🤷♂ It's in the spec.


Hub domain: Plates

Test Plan - Requires HMD; test without rez rights

Go to the hub into the 'Flying Saucer'
Pick up a plate from the end of the table
Throw the plate aggressively against something else
The plate should shatter
Pick up a piece of the broken plate
Throw it aggressively against something else
The piece should shatter and play a particle effect

I was not able to pick up the plate.

I found the grabbable plates and they worked great.


ROCM version doesn't work

🐛 Bug
When trying to run ROCM accelerated version I get the following error:
RuntimeError: t == DeviceType::HIP INTERNAL ASSERT FAILED at "/root/.local/lib/python3.6/site-packages/torch/include/c10/hip/impl/HIPGuardImpl.h":22, please report a bug to PyTorch.
To Reproduce
Steps to reproduce the behavior:

Build environment: https://gist.github.com/boniek83/86ea18dfcb557273354fe4fa6e0e226c
Run lab: https://github.com/timesler/facenet-pytorch/blob/master/examples/infer.ipynb
Error: https://gist.github.com/boniek83/1acdda728ae2bc1d06bf5464d6e9a719

Pytorch with rocm itself works:
import torch
torch.cuda.is_available()

True

Everything works with CPU.
Environment
https://gist.github.com/boniek83/9c0713d30673d14ad4acbac84e65d96e

ROCM/ROCK version: 3.5.0
GPU models and configuration: AMD Radeon VII

Hi @boniek83, your issue seems a better fit for the torch issue tracker. @fmassa could you transfer it?

Hi,
@pmeier if I understand correctly the issue is that PyTorch with ROCm works, but not torchvision. So I believe this issue should be in torchvision itself.
Tentative ROCm support was added in https://github.com/pytorch/vision/pull/1928, but given that we don't yet have ROCm CI, it might be possible that it is broken already.
ccing @iotamudelta @ashishfarmer who added initial ROCm support for torchvision.

Learning and serving models with ROCM on pytorch (with torchserve with this fix: https://github.com/pytorch/serve/issues/403) works for me. Now only torchvision is giving me problems.

My bad, I misinterpreted this.

Thank you @boniek83 . From the logs you attached, it does seem like an issue with finding HIP device on ROCm. I will investigate into this.
cc: @sunway513 @jeffdaily

Narrowed down the problem to NMS operator in torchvision on ROCm. It is reproducible with NMS test in torchvision itself. Looking further into it

@ashishfarmer we have recently changed the registration mechanism in torchvision for a couple of ops, namely NMS and RoIAlign, see https://github.com/pytorch/vision/pull/2366 and https://github.com/pytorch/vision/pull/2384


Add README for Spark job

As a developer, I'd like to add Spark docs, so it can be used as a reference for anyone wanting to run Spark jobs.
Acceptance:

Ref. guide includes spark section
Example included

This issue was moved to spring-cloud/spring-cloud-task-app-starters#16


Moveprelude

and deleted the example guff.

I might have stuffed that PR with the merge gunk.  Easiest to just do it again if so.


Mapping of types between graphql and prisma

I have something like:
schema.prisma
`
model someEntity {
    id                        string
    name                  string
    additionaField    string
  }

`
types.graphql
`
type someEntityCustom {
    id                        string
    name                  string
  }

`
I have investigated codebase of select method and see that it try to find model with name someEntityCustom. But that model does not exists in the DB. How i can map graphql type and prisma model?
Looks like valueOf can do something similar but i can not understand how to use it in right way

@kuksik we use model name to make filter before return fields and exclude any field, not in the schema model.
you can easily add custom type as you need and will return the fields you select but you must be sure that these fields exist in schema model or prisma client will throw error

What about custom fields in the custom type?

in this case, you can use valueWithFilter method in new version 1.5.5

i will try explain my problem with more details:
schema.prisma
`
model Config {
   id                        string
   configName       string
}

model Configs {
    id                        string
    config1               Config
    config2               Config
    config3               Config
  }

`
types.graphql
`
type ConfigType {
     id                        string
     additionField      string
     configName       string
 }
 type Configs {
     id                        string
     config1               ConfigType
     config2               ConfigType
     config3               ConfigType
}

`
I implemented resolver which do what i need: map my custom types from graphql with prisma models.
resolver.ts
`
Query: {
    configs: (parent, args, ctx, info) => {
        // info looks like:
        // info = `id config1 { id additionField } config2 { id additionField } config3 { id additionField configName }`

        const select = ctx.PrismaSelect(info);
        const config1 = select.valueOf('configs.config1', 'Config');
        const config2 = select.valueOf('configs.config3', 'Config');
        const config2 = select.valueOf('configs.config3', 'Config');

         select.select.configs.select.config1 = config1;
         select.select.configs.select.config2 = config2;
         select.select.configs.select.config3 = config3;

         return await ctx.prisma.configs.findMany({ ...params, ...select });
    }
 }

`
This code works but looks very massive and it is difficult to maintenance for more complex schema.
Possible solution. Will be cool if we have map object which will describe relations between graphql types and prisma models.   If model with type name does not exist in the db then select will get model name from map object.
`
....
PrismaSelect: (info: any): PrismaSelect => {
      const typeModelMap = {
          config1: 'Config'
          config2: 'Config'
          config3: 'Config',
        }
      };
      return new PrismaSelect(info, null, typeModelMap);
 ...

`

Will see how we can make this and back to you

Why you just add this field in the original type name

I do not need this field i the DB because I need reuse the same item for different hierarchal items, and i add this field in the code

What I mean why you name type ConfigType instead of Config

ah, ok. I use Config type too. ConfigType is client oriented type.

Ok wait for a workaround this

The idea now is adding a comment on the schema.prisma file like this
It will be array so you can create custom types as you want
I will look to original name and all names in map
/// PrismaSelect.map([ConfigType, ConfigCustomType])
model Config {
   id                        string
   configName       string
}

@kuksik please try now to add
/// @PrismaSelect.map([ConfigType])
model Config {
   id               string
   configName       string
}

@kuksik any test here to confirm that your issue is done?


Merge codebases

Massive PR. Encompasses all the code (currently untested) from what was previously known as SpakowitzLab/MCparallelMPI, all the vizualization and analysis additions I've made in the past few months, and the additions Brad made to Monte-Carlo to allow simulations of rings and including twist using a linear model and single "twist persistence length" parameter.
All three divergent codebases have been brought together into one, with clever command line inputs, a (pretty empty so far) documentation system, and (build failing due gfortran version issues) travis for checking new commits. Creating this PR to track last bits of progress.

After last two pushes, TRAVIS CI can now build our code.

Superceded by merge on master branch.


Wordpress.com

Would that boilerplate work well with Wordpress.com (the hosted version) or only with Wordpress.org (the self-hosted one)?

I'm not sure if Wordpress.com has an ACF to rest and a rest api exposed @Berkmann18
This is only supporting Wordpress.org :)

@bovas85 Judging by their docs, they seem to have one for wordpress.com but it's not that clear so I asked them.

Thanks, let me know how it goes. Would be interested to extend if possible

Will do.

The API is accessible via URLs:

API endpoint: https://public-api.wordpress.com/rest/v1/sites/:url
API endpoint for posts: https://public-api.wordpress.com/rest/v1/sites/:id/posts/

Example of gridpressblog.wordpress.com:

API: https://public-api.wordpress.com/rest/v1/sites/gridpressblog.wordpress.com
API endpoint for posts: https://public-api.wordpress.com/rest/v1/sites/159743731/posts/

I haven't tried those URLs in Nuxt/Gridsome yet tho.

those that expose custom fields?
My boilerplate doesn't actually depend from any endpoint. This could be adapted to any CMS really, it's just done with WordPress.org as it's free and farily well-known

those that expose custom fields?
You mean the API?

What do you suggest to get it working with wordpres.com?

Simply change the config endpoints and populate the store with the data you receive.


Bug7346/transitive patches

Fixes #7346.
A cursory comparison between current stable and nightly shows that projects with this topology resolve similarly. If there are other behaviors I should test, I'd be happy to expand that section. This is a pretty focused change, though, so I'm not sure what else there is to break.
Sorry about the delay in putting this PR together. Good news is I know more than I did last week.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Eh2406 (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

This looks like the change I had in mind! Thank you!
@bors r+
There is a lot of context to understand to make this change. What worked well to "know more"? What did not? Where could we document more? What would you like more explanation on?

:pushpin: Commit f7bfd9dd18c5c4b6bcc4cb009ce8b6f9ed179480 has been approved by Eh2406

:hourglass: Testing commit f7bfd9dd18c5c4b6bcc4cb009ce8b6f9ed179480 with merge fdcc73fc69fc8cb86d235a32c99018ba4e79c36d...

:sunny: Test successful - checks-azure
Approved by: Eh2406
Pushing fdcc73fc69fc8cb86d235a32c99018ba4e79c36d to master...

Okay so. Sorry about the delay on getting back to you, @Eh2406. It's been hard to tease my thoughts into a form that will (hopefully) be immediately valuable and things were getting muddy.  We can drill down into specific pieces if more detail would be useful.

The code is very organic. A bit sprawling in places.

Might be unavoidable. Between finding/walking registries, handling the semantics of Cargo.toml, and building the dep graphs? That's a lot of complexity.
Separation of concerns seems to be loose. A fair bit of tight coupling between modules seems to be in place.
The state of the program after every major call was hard to discern; after core::resolver::activate_deps_loop is called, do we have a linearized set of crates to build, or a dep-graph? Both? How does it affect the mut cx member? (I think I understand it, and know where to look in the code, but it's still hard to keep in my head.)

Comments that help guide readers or describe the flow are rare.

Most of the code has good reference-style doc comments for the "What" of each bit of code.
Some files have really good prosaic overviews (e.g. core/resolver/mod.rs, sources/registry/mod.rs) that get into the big-picture "Why".
Fewer have strong descriptions of how the pieces fit together. Examples;

struct Manifest has a member links: Option<String> and struct Summary has a member links: Option<InternedString>. I get it now, but I had read a lot of code/infer a few relationships to grok what was going on.
PackageRegistry is a cache of known core::source::SourceIds each of which owns boxed core::source::Source trait object, which itself is a type-erased sources::*::<Kind>Source (GitSource, RegistrySource, etc.). I get that now, but bouncing between core::source and sources::registry was real tricky.

Tests aren't what I expected.

There seem to be very few unit/regression tests per module. I often lean on those to understand micro-level semantics.
The testsuite is amazing.

Might be my favorite (domain-specific) integration test framework I've added tests to.
Super easy to separate concerns. I didn't bother looking into the implementation of Package::new or git::repo; their use was obvious and immediately helpful.
Organization of individual tests was... daunting. Documenting what each file in tests/testsuite/ is for (either in the file, or in a table of contents) might be helpful.

Using a debugger in the context of testsuite/ was suboptimal

Triggering breakpoints in the cargo library as part of the testsuite execution may be impossible?
Relatively simple to re-creatae the packages generated by testsuite tests as a local workspace, but that was less expressive than the test suite.
LLDB in Rust is far from mature. General improvements would be awesome, but out of scope.

This is grate and it all rings true to my experience! Let me give some inline feedback, in the hope it will keep the conversation going.

The code is very organic. A bit sprawling in places.

Separation of concerns seems to be loose. A fair bit of tight coupling between modules seems to be in place.

So true, not sure what to do. We have discussed working on splitting out subcrates, but it is a lot of work and slow going. Entropy and all.

The state of the program after every major call was hard to discern; after core::resolver::activate_deps_loop is called, do we have a linearized set of crates to build, or a dep-graph? Both? How does it affect the mut cx member? (I think I understand it, and know where to look in the code, but it's still hard to keep in my head.)

Hmm... good point. Maybe we can add comments. The hard part is guessing what state reader will want explained. Do you feel up to a PR with those kinds of questions as comments? If so I can work to replace your questions with the answers.

Comments that help guide readers or describe the flow are rare.

This rings true, but not sure I know how to proceed without descending into the particular.

Fewer have strong descriptions of how the pieces fit together. Examples;

struct Manifest has a member links: Option<String> and struct Summary has a member links: Option<InternedString>. I get it now, but I had read a lot of code/infer a few relationships to grok what was going on.

InternedString has not fully spread throughout the code base. For that matter, I don't know that we even have a good description of when it should be used. That can be improved... I can try to write up a guide, so someone can do an review.  Also the codebase is "organic", sometimes the duplication is removable. (#7324)

PackageRegistry is a cache of known core::source::SourceIds each of which owns boxed core::source::Source trait object, which itself is a type-erased sources::*::<Kind>Source (GitSource, RegistrySource, etc.). I get that now, but bouncing between core::source and sources::registry was real tricky.

This gets me every time too. How to make it better I wunder.

Tests aren't what I expected.

There seem to be very few unit/regression tests per module. I often lean on those to understand micro-level semantics.

This is mostly historical. As I understand it @alexcrichton personality does not find this kind of open box testing helpful for him but is open to adding it when others find it helpful. (sorry Alex for putting words in your mouth.) I would be open to adding some to the Resolver, making this more testable may help with the "tight coupling".

The testsuite is amazing.

Might be my favorite (domain-specific) integration test framework I've added tests to.

Super easy to separate concerns. I didn't bother looking into the implementation of Package::new or git::repo; their use was obvious and immediately helpful.

Big thanks to all those that made this happen! As I recall @dwijnand did a lot of work on this, but the bonese predate me.

Organization of individual tests was... daunting. Documenting what each file in tests/testsuite/ is for (either in the file, or in a table of contents) might be helpful.

Agread. I get the impression we don't spend much time organizing them. As long as a test gets run on CI, we don't pay too much attention to were it is. Part of the problem is that loats of the test have cross cutting interactions that make it hard to categorize.

Using a debugger in the context of testsuite/ was suboptimal

I have never gotten a debugger to to anything useful on rust code in general. So it is possible that we are not making it eazy.
Which of these threads of conversation do you want to pursue? How can I help?

This is mostly historical. As I understand it @alexcrichton personality does not find this kind of open box testing helpful for him but is open to adding it when others find it helpful. (sorry Alex for putting words in your mouth.)

Heh no worries but this sounds right to me! I haven't personally written a ton of these tests but I don't want to stop anyone from writing tests, and I agree that especially in the context of the resolver having unit tests is extremely useful!


Maven Archetype

Have a Maven Archetype to quickly start your developing your own roboquant based trading application

Duplicate with more general issue


Add wildcard cappabilities to all commands

The * is not implemented for all commands

Fixed in https://github.com/loopier/animatron/commit/f2f30ef6e498f3e000187ec0d068bffe53eeaddc

Excellent, thanks!


[Suggestion] Moves the completed plot to another (SSD) directory/drive as a buffer for mechanical hard drive before the final destination.

This is probably not the right place to implement such feature but I am going to make the suggestion anyway...
when you move/copy a large file to mechanical drive, the write speed is going to be the bottleneck. however if copy the file to an SSD first, the disk space on the plotting drives can be freed sooner so that you can start the next plot sooner while maximizing the free space on the plotting drives. while this might sounds similar to -2 argument, it isn't exactly the same as it only deals with the finalized plot instead of involving with phase 3 and 4.
I think it will minimize time to start the next plot given the max active plots constraint.

you can set the target directory to be the 2nd SSD.  And have a separate script to copy the plots async to the final hard drive.  I personally do this already.


Tip button thumbnails [without popup]

Yes, thanks. It need to be poison in different ways for the different lists.


get_instruction_text in disassembler.py can return None, leading to errors

get_instruction_text in disassembler.py can return None in its list of InstructionTextToken, leading to AttributeError.
Traceback (most recent call last):
  File "/Applications/dev-binja.app/Contents/MacOS/plugins/../../Resources/python/binaryninja/architecture.py", line 676, in _get_instruction_text
    token_buf = function.InstructionTextToken._get_core_struct(tokens)
  File "/Applications/dev-binja.app/Contents/MacOS/plugins/../../Resources/python/binaryninja/architecture.py", line 2842, in _get_core_struct
    result[j].type = tokens[j].type
AttributeError: 'NoneType' object has no attribute 'type'

This leads to failed disassembly as shown:

File in question:
ctf-challenge.zip

The bug originated in the add_jump method returning None for unhandled jump instructions, fixed with commits (dad35c6 and 520020f).
I also fixed absolute and relative jumps, the graph is more accurate now.

Just tested with latest commit, all instructions appear to be handled!


Add: Complain app

Add complain app which contain a register form
where user can register there complain.
Closes https://github.com/CodeVINCI/good-food-project/issues/4

To me this looks perfect. As krishna has reviewed this issue before i'll let him merge the work.

If anyone want to go through the review of this --> https://github.com/CodeVINCI/good-food-project/pull/5


Enable "add_member" to existing global object

Describe your problem
Currently building an global object in vineyard requires a "reduce" object in the application where object ids of all local chunks needs to gathered into one process to create the object metadata.
Such design brings much inconvenience as a "reduce" operation requires establishing connections between processes of the application, e.g., in GAIA runtime to building a subgraph, and in assembly operator where a global stream needs to be transformed into new a global object.
This issue propose add a "add_member" APIs to global object (limited to global object) where clients can add new members to existing global object, and a global etcd lock will be used when updating the metadata to ensure the consistency. The "add_member" implementation in vineyardd works as the following way:

get the etcd lock
update metadata, mark as transient
persist metadata using txn
unlock

Additional context
Add any other context about the problem here.

Closing as stale.


oAuth example with expressJS

Question
Looking through your code, i haven't an idea to handle a youtube login via oauth over a expressJS route

Hello,
Not sure if I can help you with that as I have no experience with ExpressJs but other than that it shouldn't be too difficult. Maybe someone else can assist you.

what is there inside this file? yt_oauth_creds.json I wish the example at least included which keys are there with some dummy values inside

Hello @slidenerd , sorry for that.
It contains the OAuth credentials, it goes as follows:
{
  access_token: string,
  refresh_token: string,
  expires: Date
}

Access token -
A bearer token is used to sign in to the account. It usually expires in 24 hours.

Refresh token -
It is valid until you manually revoke access through your account or call the signOut() method. It is used to refresh the access token once it expires.

Expires -
It is the expiry date of the access token.


Not able to replicate the shell

Describe the bug
So I followed the installation steps and created the ~/.amrc file however the shell is not adapting the theme

Can I see the content of .amrc and a screenshot of your terminal?

gist for .amrc: https://gist.github.com/designMoreWeb/f19f3da7ecca822373a87a63e04f491a

Please provide me the below information and the installation procedure as well:

Plugin Manager: [ antigen | zplug | ... ]
ZSH Version:
Operating System: [ name and version ]
Terminal Emulator: [ name and version ]

Plugin Manager: [ antigen ]
ZSH Version: [zsh 5.7.1 (x86_64-apple-darwin18.2.0)]
Operating System: [ Mac Mojave Version 10.14.6 ]
Terminal Emulator: [Hyper 3.0.2 (stable)]
I tried adding the settings for ~/.amrc
however no change

Any progress on this issue?

I am trying to reproduce it. It happened only the first time I opened the hyper after installation.
Afterwards the shell is rendering as expected all the time.


Evaluate CMU-Panoptic Code

Thank you for your work!
Can you please provide the code and json file(2D Pose Result) to evalution on the CMU-Panoptic dataset?
=================================================================================
안녕하세요! Github에 논문 코드를 올려주셔서 감사합니다!
Code를 확인해본 결과 CMU-Panoptic 결과를 내면서 사용한 python file과 2D Pose estimation json 파일이 없는 것 같아서 요청드리고자 이슈에 올렸습니다!
감사합니다

Experiments on CMU-Panoptic is done by other author long time ago. You can refer to the code of Jiang, W.; Kolotouros, N.; Pavlakos, G.; Zhou, X.; and Dani- ilidis, K. 2020. Coherent reconstruction of multiple humans from a single image. In CVPR.
We referred their code for evaluation.
Or I could provide messy and raw codes which might not work readily but worth looking

I`d really appreciate it if you could give me the raw code
raw codes를 제공해주신다면 정말 감사할 것 같습니다!

메일로 보냈습니다~

감사합니다!

The E-mail was sent to you.
Thank you very much.


fix:The dynamic size value is returned

[LEVEL]/[COMPONENT]
TASK:
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Only
[ ] Refactor

Description, Motivation and Context

Screenshots - Animations

Hi! @DiegoContrerasA I appreciate your contribution but the border size can't be the same as the Avatar size because when the user puts a custom size like "40px" then the border size will be "40px"


Error: Cannot GET /vendor/lato-webfont/css/lato-webfont.css.map

Why is this error appearing at Node output? How do I "fix" it?

Hmmm... Interresting. I'll look into that. Thanks for report!
2016-03-27 1:09 GMT+01:00 Richard Lopes<EMAIL_ADDRESS>
Why is this error appearing at Node output?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/hakger/lato-webfont/issues/3

--
Pozdrawiam,
Hubert Kowalski


Update to Boostrap 4.5

supersedes https://github.com/carpentries/amy/pull/1733
fixes #1723
@pbanaszkiewicz  : you are correct, updating to Bootstrap 4.5.3 (and fixing the unmet peer dependency) makes the accordion work again.

Thank you for the contribution, @marwahaha!


[BUG] Time literals are not formatted correctly

Environment

DocumentDB JDBC driver version: v1.0.0
DocumentDB server version: 3.6, 4.0
OS: Any
BI Tool or client name: Any
BI Tool or client version: Any
Java version (if known):  Java 8

Problem Description

Steps to reproduce:

Connect to any database either using a Java application or BI tool.
Execute a query containing a time literal such as  SELECT TIME '20:17:40' FROM collection
Error occurs when retrieving result set.

Expected behaviour:  Time value can be retrieved and displayed.
Actual behaviour: Query fails with error message - Conversion between the source type (Integer) and the target type (Date) is not supported.
Error message/stack trace:

Conversion between the source type (Integer) and the target type (Date) is not supported.
java.sql.SQLException: Conversion between the source type (Integer) and the target type (Date) is not supported.
	at software.amazon.documentdb.jdbc.common.utilities.SqlError.createSQLException(SqlError.java:191)
	at software.amazon.documentdb.jdbc.DocumentDbAbstractResultSet.getValue(DocumentDbAbstractResultSet.java:173)
	at software.amazon.documentdb.jdbc.DocumentDbAbstractResultSet.getDate(DocumentDbAbstractResultSet.java:317)
	at software.amazon.documentdb.jdbc.DocumentDbAbstractResultSet.getTime(DocumentDbAbstractResultSet.java:335)
	at software.amazon.documentdb.jdbc.DocumentDbAbstractResultSet.getTime(DocumentDbAbstractResultSet.java:249)
Caused by: org.apache.commons.beanutils.ConversionException: Default conversion to java.sql.Date failed.
	at org.apache.commons.beanutils.converters.AbstractConverter.handleMissing(AbstractConverter.java:314)
	at org.apache.commons.beanutils.converters.AbstractConverter.handleError(AbstractConverter.java:269)
	at org.apache.commons.beanutils.converters.AbstractConverter.convert(AbstractConverter.java:177)
	at software.amazon.documentdb.jdbc.DocumentDbAbstractResultSet.getValue(DocumentDbAbstractResultSet.java:171

Screenshots

NA

JDBC log
Created projection stages of pipeline.
Pipeline stages added: {$project: {'EXPR$0': {"$literal": 73060000}, _id: 0}}
Query 1926e6b5-33f4-4e5a-84a3-a2cfdcfaedc6: Took 2057 ms to translate query.
Sending command '{"aggregate": "collection", "pipeline": [{"$project": {"EXPR$0": {"$literal": 73060000}, "_id": 0}}], "cursor": {"batchSize": 2000}, "$db": "resultDatabase", "lsid": {"id": {"$binary": {"base64": "qpsgQdszQWOv3kr6DfGdVQ==", "subType": "04"}}}}' with request id 46 to database resultDatabase on connection [connectionId{localValue:9, serverValue:10}] to server localhost:55921
Execution of command with request id 46 completed successfully in 13.97 ms on connection [connectionId{localValue:9, serverValue:10}] to server localhost:55921
Query 1926e6b5-33f4-4e5a-84a3-a2cfdcfaedc6: Took 36 ms to execute query and retrieve first batch of results.
Query 1926e6b5-33f4-4e5a-84a3-a2cfdcfaedc6: Executed on collection collection with following pipeline operations: [{"$project": {"EXPR$0": {"$literal": 73060000}, "_id": 0}}]
Converting 'Integer' value '73060000' to type 'java.sql.Date'
    IntegerConverter cannot handle conversion to 'java.sql.Date'
    Conversion threw ConversionException: IntegerConverter cannot handle conversion to 'java.sql.Date'
    IntegerConverter cannot handle conversion to 'java.sql.Date'
Conversion between the source type (Integer) and the target type (Date) is not supported.

Issue was addressed in #208. Fix was included in the November release.


Allow memo date change Firefox

in v 0.22.4 the ability to update memo dates was reinstated. This feature works in Edge and Chrome but not Firefox
This is due to Firefox needing a specific date string format provided as the input value otherwise the time section of the datetime is not populated.
This becomes an issue as Firefox only fires the change event needed to update the date state if the complete date and time is set on the input
This pr is to provide the required date string format of yyyy-mm-ddThh:mm:ss
Tested in Firefox and Chromium and works as expected.

Suggested change was to use MUI datetime picker. This will be a new concept to what this PR is doing so closing this PR and will create a new one once MUI datetime picker is implemented


x/build/DIR: pkgbuild produces an installer that installs to /usr/local/go/bin/go, no longer in PATH on os X mojave

What version of Go are you using (go version)?
go 1.11.2 darwin/amd64
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
darwin/amd64
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/b5/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/b5/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/6p/sjn8bct92397mbgwmwwvcb4h0000gn/T/go-build195699704=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
Ran the go .pkg installer downloaded from golang.org. Installer completes successfully. I then moved over to the command line & ran:
$ which go
go not found

What did you expect to see?
I was hoping to see /usr/local/go/bin/go, or for some magic created by pkgbuild/productbuild to symlink /usr/local/go/bin/go -> /usr/local/bin/go. but alas, nope. This problem only seems to exist on os x Mojave (as far as I can tell).
What did you see instead?
go not found
My guess is the fix will land here

See https://golang.org/doc/install#macos.
You have to restart any existing Terminal sessions for the $PATH changes to take effect. Have you done that ?

Apologies for the delay, yes I have / did create a new session at the time. $PATH changes are present, the issue is the go tool itself isn't available.

If the $PATH changes are present, I fail to see how the go tool isn't available. Can you dump the output of $PATH variable ?

/cc @ianlancetaylor @bradfitz

I spotted this issue only recently, and wanted to follow up here. Also CC @golang/release. (I realize it's from 2018 so it might not be relevant to you or not something you can easily verify now.)
@b5 The macOS Go installer does have a mechanism to make /usr/local/go/bin/go available in $PATH: it writes to a special directory /etc/paths.d a file with the content /usr/local/go/bin (see buildrelease.go:371). If that file (named "go") is present in your /etc/paths.d directory, that means the installer worked as expected. If it's there but which go still doesn't find /usr/local/go/bin/go, it'd be useful to also know what terminal + shell you're using and if its configuration does something that might override path_helper picking up /etc/paths.d entries. Thanks.
You also mentioned this is only happening on macOS Mojave (10.14). If it's not a problem on newer macOS versions, then this problem won't apply after that macOS version stops being supported.


gulp is too slow, options for both grunt and gulp

gulp is very slow and unpredictable, while grunt is very stable.
it would be better to provide options for both.

What issues have you run into?

it seems because of this issue
https://github.com/yeoman/generator-node/issues/206
which is misleading.

but it would be very nice to have both.

Closing this one as it seems related to your canonical issue.


Server memory leak?

https://cdn.discordapp.com/attachments/724484545226866789/856878821080170536/unknown.png
Server memory leak with these spamming after shutting down server

https://spark.lucko.me/I61vSV7dDq


Tests fail to run from PyTest:  ManimPango could not import and load the necessary shared libraries.

[yuri@yv /usr/ports/graphics/py-ManimPango/work-py39/ManimPango-0.4.3/tests]$ pytest .
ImportError while loading conftest '/usr/ports/graphics/py-ManimPango/work-py39/ManimPango-0.4.3/tests/conftest.py'.
conftest.py:7: in <module>
    import manimpango
../manimpango/__init__.py:35: in <module>
    raise ImportError(msg)
E   ImportError:
E
E   ManimPango could not import and load the necessary shared libraries.
E   This error may occur when ManimPango and its dependencies are improperly set up.
E   Please make sure the following versions are what you expect:
E
E       * ManimPango v0.4.3, Python v3.9.16
E
E   If you believe there is a greater problem,
E   feel free to contact us or create an issue on GitHub:
E
E       * Discord: https://www.manim.community/discord/
E       * GitHub: https://github.com/ManimCommunity/ManimPango/issues
E
E   Original error: No module named 'manimpango.cmanimpango'

However, 'import manimpango' succeeds in the Python interpreter.
ManimPango-0.4.3
Python-3.9
FreeBSD 13.1

I guess you've been trying to test without building the actual extension or the source tree is in PYTHONPATH. If it's the first case then build the extension first or if it's the latter then build the extension in place (python setup.py build_ext -i). If you want to test the installed version of the library then try removing the source tree location from PYTHONPATH.
HTH

The source tree isn't in PYTHONPATH.
The build is performed using PEP517 compliant tools.
3 binary extensions. cmanimpango, enums, register_font, are built.
What is wrong?

Not sure what's happening in that case, sorry.

Can you check whether do you face the issue with latest version?


Lexical hyperlink feature wants 🥗 for its 🐛

Link to reproduction

Describe the Bug
Lexical Richtext editor has 2 issues with links.
First the most usual working scenario
If you write a "Text" (That is not a hyperlink).
Select the "Text" and click the hyperlink toggle.
Then enter a Link: e.g.  https://payloadcms.com/ and confirm this.
This works ✔
IF we now select the hyperlinked "Text" we get a toolbar that displays the link with Edit ✏ and Remove ✖ icon.
We can no edit the Hyperlink with the Edit ✏ and it works ✔
We can also Remove ✖ the hyperlink, also a pass ✔
But there is 2 unexpected Scenarios, that are or feel buggy.
Removing the Hyperlink for a hyperlink text
Now we go to https://payloadcms.com/ and copy the Url.
Then we go to our RichText editor and past the url directly into it. This will create a hyperlinked url.
If we now point the cursor at our url and click the Remove ✖
This has no effect and appears to fail ❌
Click on X is not having any effect.
https://github.com/payloadcms/payload/assets/87857953/79f22ee8-d2ec-4b5a-95cb-6dcd9b7ca859
The failure is also present in lexical Playground (so likely not Payload specific)
https://github.com/payloadcms/payload/assets/87857953/7a740207-435e-4fc9-b361-3bfe3f86cafe
Editing a Hyperlink for a hyperlink text
We take the same state as previous failing scenario, having a url as text with a hyperlink.
If we now point the cursor at our url and click the Edit ✏
We get the modal window to edit the text as well as the hyperlink.
If we change the Display Text now to e.g. Payload and apply the change, we get back to the RichtText editor.
But the Hyperlink is gone all together
This appears to fail as well ❌
Hyperlink is removed after Display Text is changed.
https://github.com/payloadcms/payload/assets/87857953/f7c9796e-5dfe-45c2-a668-74436b72890f
To me it appears that lexical has a bit of magic involved to turn urls directly into hyperlinks,  but this piece fails the edit and remove option.
Payload Version
"payload": "^2.10.0"
Adapters and Plugins
"@payloadcms/bundler-webpack": "^1.0.6",
"@payloadcms/db-mongodb": "^1.4.0",
"@payloadcms/plugin-cloud-storage": "^1.1.2",
"@payloadcms/plugin-sentry": "^0.0.6",
"@payloadcms/richtext-lexical": "^0.6.1",

Pasting links will create AutoLinkNodes in the editor - not LinkNodes, which behave a bit differently.
Optimally, when you edit an AutoLink node, it should be converted into a LinkNode when you make any edits (like editing the DisplayName), though. I've reproduced this and will look into it


C++ migration: refactor Timestamp logic checking for overflow.

Rewrite manual checks using <chrono> min()/max() functions and
duration_cast. This is cleaner, and avoids including <limits>.

@rsgowman, thanks. I think this rewrite should be equivalent and shouldn't trigger anything platform-specific (any more than before).


pipelines can hang if job stuck queueing for too long with no nodes available

Consider having a timeout for waiting for a node when "none" are available. Distinguish this to none available, due to them all being busy, so none here means "none at all"

I agree. Perhaps the job status could be "aborted" due to timeout, and "failed" if no nodes exist?


Re add Github stats on the index page

This script https://github.com/lingonsaft/hacktoberfest/blob/master/scripts/stats.js  add Github stats but it was removed when we updated the style of the index page. Could someone add it again?

I'll take this one.

@silvericarus Yes go a head :)

Resolved


Port to  vcpkg package for simple installation

Vcpkg helps you manage C and C++ libraries on Windows, Linux and MacOS

@westfly would you like to contribute the vcpkg package?


Does it make sense that the "destination" element animations are defined from the "origin" element?

Honestly after writing up the new docs #93 I'm really questioning if this API actually makes sense.

Some thoughts from the future: It kind of does. Imagine you have a scenario where you want different animations depending on the origin.
page1 -> page2, maybe we want to get there by a regular move.
page3 -> page2, maybe we want to get there by fade move because the element is slightly different on this page.
having the origin element define what animations they want allow this behaviour to happen. if the destination defined it - how would we have this flexibility?
tl;dr WE GUCCI 👼


DNS over TLS possible?

Greetings dear developer!
Is it possible to implement DNS Over TLS support since it is fastest and works on the lowest OSI model than DNS Over https
Thank you in advance for a very convenient utility!

Thanks for your interest in Intra!
We appreciate the suggestion to implement DNS Over TLS support.  While we agree it's a valuable feature, we have limited bandwidth to add it to our roadmap right now.
However, if you're comfortable coding, you're welcome to use the Outline SDK to implement this yourself. We also gladly accept pull requests.
Thanks again!


Rethink Diff Review

The Diff Review feature is exclusively for screen reader users.
Thus I would suggest to rename it to "Accessible Diff Viewer".
Currently, it is implemented as a modal experience. I think it would make more sense to implement it as a third mode, next to side-by-side diff view and inline diff view.
Also, consumers of the diff editor should be able to open the review mode by default.
cc @meganrogge @alexdima

Verification steps:

Verify the "Diff Review" feature is now branded as "Accessible Diff Viewer" everywhere (in F1, command names and menu entry names). Check the available commands when a diff editor is opened.
Verify there is "Open Accessible Diff Viewer" in this menu, and it works:

Works but shouldn't "Open Accessible Diff Viewer" be in the command palette as well?

Works but shouldn't "Open Accessible Diff Viewer" be in the command palette as well?

This would just be an alias of "Go to Next Difference".

Oh, got it


aio as namespace

@johanste see for example:
https://github.com/Azure/autorest.python/tree/asyncrename/test/azure/Expected/AcceptanceTests/StorageManagementClient

🤖 AutoRest automatic publish job 🤖
success (version: 4.0.65)


Set up Storybook

User Story
As a developer
I want to set up storybook in our project
So that I can facilitate component-driven development, improve collaboration, and streamline UI testing
Definition of Done

Storybook is installed with proper config in the iw-complaint-manager repo.

Make sure it is it's own "module" by creating a iw-storybook folder in the root of iw-complaint-manager
The folder structure should be:.
└── iw-complaint-manager/
    └── *iw-storybook/
        └── package.json

*This will eventually be moved out into its own repo, but for the sake of easy importing we'll build it as a monorepo

It's set up to work with MUI

Autodocs functionality is implemented

A sample story is visible

Resources:
Install for React + Vite
Setup
Integrate MUI + Storybook
How to write a story in Typescript
Implementing Automatic Documentation
Acceptance Criteria
Given Storybook has been installed and set up
When I run npm run storybook
Then it successfully launches a local dev server for Storybook.
Given Storybook is running locally
When I view the page
Then it shows a sample Storybook story

Setting up a sample app: https://github.com/storybookjs/storybook/issues/25154


Flutter version 0.0.0

When I type in flutter --version after the new Flutter version, this is what I get :
Flutter 0.0.0-unknown • channel stable • https://github.com/flutter/flutter.git
Framework • revision f7a6a7906b (il y a 3 jours) • 2020-05-12 18:39:00 -0700
Engine • revision 6bc433c6b6
Tools • Dart 2.8.2

Is there a reason why the new Flutter version won't be displayed?

reinstall flutter.
brew uninstall --force flutter
rm -rf "$(brew --cache)/flutter--git"
brew install (--devel) flutter


Set up a "hook" for Zenodo to mint DOIs

See for example https://docs.github.com/en/repositories/archiving-a-github-repository/referencing-and-citing-content.

It is already set up since a while. I haven't made a release yet. Is it urgent? I am going to make a release soon.

No, no matter of urgency. I was doing some easy "admin" here and there and remembered this since I did not see the Zenodo badge in the README. If you got it ready I close this 👍.


Certs generated in root folder,  not domain subfolder

Initially I had only one container so the certs ending up in the root of the certs folder was fine and it still worked.  Now I've added a second container and the second container's certs overwrite the certs from the first container.  I'm using test certs but it should work the same right?  The domain subfolder for test is created but empty.  The domain subfolder of test1 is not created.  There's probably something wrong with my docker-compose file but I've stared at it too long and it's starting to look like Sanskrit.
docker-compose.test.yml.txt

Had a space in between the LETSENCRYPT_HOST= and the domain name,  works now.


CPU high usage

In PHPStorm and PyCharm I have problem with the plugin, it use a lot of CPU then I manipulate text (like multiple pointers, etc.).
I think it is because of token counter functional that was added before, it try to count the tokens after every change in code.
I hope you can fix it, because now I can't use the plugin at all.
Thanks.

Also it user a lot of CPU then i start autoformat code or fix imports.

Thank you for the report! I have made a fix, and if you like, you will be able to download it from the "releases" section here on github soon. (Needs to go through release pipeline, ~1 hour)
It should be approved by JetBrains on Monday for auto-upgrading.
Thanks for mentioning multiple pointers. I don't ever use them, but the plugin should properly account for them.... currently just picks the first cursor. I'll keep this ticket open to track that issue.


Scroll is visible in edition mode

Description
Browser scrollbar is visible sometimes in edition mode when elements content is bigger than the container. I think it is strange behaviour especially if we cannot scroll this content in editor mode.
Technical
TAU version: 1.1.0
Steps to reproduce

Create a new project in Design Editor
Add box (div) to its content
Append Some widgets to the box. It has to be more of them than box dimensions.
Focus box and change its attributes:

overflow-y: auto

Expected behaviour
Not visible scroll bar OR working scrollbar that can be scrolled OR some other way to manipulate the content of the box
Actual behaviour
Visible scrollbar which isn't operational.

@korneliakobiela I'm trying to reproduce this issue but need more details about repro steps

@lslachciak I've updated the issue description.

@korneliakobiela thank you, I reproduced issue

I'll try to make this list scrollable & editable in the edit mode on focus, after being clicked (probably by temporarily modifying its styles).

Looks and works well. I've checked it


Skungee Messaging Elements

Is your feature request related to a problem? Please describe.
Since skungee can now communicate a network of servers really fast, it would be great if there was a way to
use this messaging system freely trough skript elements.
Describe the suggestion you'd like
The messaging system would work in a send/receive way.
Example effect to send a message to one or more servers:
send [skungee] message %string% to %servers%
then the target servers can hanlde this message using the event
on skungee message:
the event values could be:
message
sender (server who sent the message)
Additional context
it would be up to the user to decide what they want to do with this, but it opens the door to some
cool creations and freedom to create connected server systems.

Added in  2.0.0-ALPHA-19


logreader and  rbac

logreader and rbac changes

@vtsarfin-cg - i approved this PR. Can you please repeat these changes in the cnask-gitops repo also?

@vtsarfin-cg - i approved this PR. Can you please repeat these changes in the cnask-gitops repo also?

ready, but have no rights to push there.


Best practices for testing

I wanted to throw one of my common practices over the fence, and see if it's worth considering for addition to the library.
In each Duct project, I add a test/system_test.clj file. At its essence it has two pieces:
(def test-config
  {:app ...})

(def config
  (meta-merge defaults environ test-config))

And, this for overloading the main system component...
(defn new-system []
  (assoc (sys/new-system config)
              :my-component {}))

It's basically my standard way of implementing stubs for tests, which are often different from what I want from my live development environment.
Have I missed an obvious solution that already exists in Duct?

This is for testing the entire system, rather than an individual component or endpoint, right?

Yes. I'll admit the primary use is for integration-like tests, incorporating components across the system. I've even written a macro that helps me test with little setup:
(with-system (new-system) {:keys [db]}
  (is ...)

The first argument accepts whatever system I care to test, the second deconstructs it, the third is my assertions. It starts the system, runs the body, then cleans up after itself.
Thoughts?

I think it's a sound idea. I tend to have a test/<project>/system_test.clj file as well.
Integrating it into the template might be a little tricky because of the need to have a test database in order for it to work with projects that use a database. I guess a TEST_DATABASE_URL environment variable might be useful to complement DATABASE_URL.

You mean like this, right?
system_test.clj:
(def test-config
  {:database-url (env :test-database-url})

user.clj:
(def dev-config
  {:database-url (env :database-url})

More or less?
P.S. If this is a low-use feature addition, no worries; just something I add regularly. My testing tends to coalesce around high-risk or opaque functions, which are often multi-component, so the ability to bring the system up and down easily has saved me a lot of time.


Create "the present" from Openstreetmap

Create "the present" from Openstreetmap.
Making something similar to a import data from Openstreetmap we can create the present of our zone and then add the OHM tags to make it available and renderizable.

I am also in agreement about doing this sort of idea. To expand on your concept, I would propose that the start date be set to 2021 (the present year at the time of this posting). As time progresses into the future beyond 2021, features from our current year could be removed and replaced by newer ones if the case arises. I don't think this should apply to the largest scale things such as international borders. Most likely smaller features like traffic lights and restaurants.

This is not my area of expertise by a long shot, but wanted to chime in here with what I do know: We're trying to have OHM include as much Public Domain / CC0 data as possible, but any automated import from OSM would also bring in their ODBL license, and then those items need to be handled with item-level licensing. I imagine this is a solvable problem, but these license issues can get thorny.

Cc0 is not always possible. Making shots of OSM would bring us the
'present' of OHM and make bridges between users and data usable to recover
the history of the things.If not, starting from 0... is silly: same ways
with same key=values all around the world?
Salut,mapes i història (health and maps and history)
yopaseopor
El dt., 17 d’ag. 2021, 2:58, Dan Rademacher @.***> va
escriure:

This is not my area of expertise by a long shot, but wanted to chime in
here with what I do know: We're trying to have OHM include as much Public
Domain / CC0 data as possible, but any automated import from OSM would also
bring in their ODBL license, and then those items need to be handled with
item-level licensing. I imagine this is a solvable problem, but these
license issues can get thorny.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenHistoricalMap/issues/issues/275#issuecomment-899914292,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABIB4VU2FZUEU2QBYTFCLGLT5GX2NANCNFSM5CFCKWOQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

I would prefer merging both databases and projects, this way we could use already existing OSM data and make things way much simplier. The fact is, we don't have enough contributors to make a whole new database. For exemple I work on railways and public transport in Belgium and France and I can't simply re-make everyting from scratch, on the other hand it's often discouraging as I contribute to both OSM and OHM and have to make things twice on both databases.
Of course we could upload OSM data in OHM but it would be nearly impossible to keep all this data up to date with OSM.
Merging both database would take time but it's much less difficult than re-creating a whole new database from scratch.
The issue is how would OSM handle OHM content in the simplest way possible ?  in such a way that OSM database and renderers are little or not modified.
_1. The only modification to the OSM project would be to add a filter in renderers : "HIDE if end_date<CURRENTDATE". No database modification would be needed within OSM.
And we add a filter in OHM renderers : "HIDE if end_date or start_date are not used" this way we only show in OHM elements with start/end tags.
_
2.
We should also need to adapt OHM tagging so as not to have an influence on OSM renderer, this could also be done in a simple way by only using tags with numbers at their end for historical data : lets take for exemple a road which current name is "Blue street"
OSM data should give this :
name=Blue street
However this street was before 1990 named "Red street" and before 1950 "Yellow street" so OHM data should looks like this :
name=Yellow street
name2=Red street
name2_start_date=1950
name3=Blue street
name3_start_date=1990
Now for OSM data not to considerer "historical" tags we should only use tags with numbers at its end :
Same street in a merged database
// Historical data
name1=Yellow street - it's no longer name but name1 this way OSM renderers shouldn't considerer historical data.
name2=Red street
name2_start_date=1950
name3=Blue street
name3_start_date=1990
// Current data (OSM)
name=Blue street

I think your approach is correct. I have seen lots of projects (OHM is not
an exception) to break apart from OSM, collect and use their data outside
OSM and then...die and disappear (and the work made by the project also).
Other third projects outside of osm but using the data would prevail
because the project can die but the data is also inside OSM so somebody
with a little bit knowledge would show again this data.
In OSM there are some approaches to use some date/time data. You can read
here:
https://wiki.openstreetmap.org/wiki/Comparison_of_life_cycle_concepts
https://wiki.openstreetmap.org/wiki/Lifecycle_prefix
I have used widely
https://wiki.openstreetmap.org/wiki/Comparison_of_life_cycle_concepts#Date_namespace_suffix_as_.22keyname:DATESPEC.3D...22
I would leave keys and tags that are not compatible with OSM . I would
convert start_date and end date in something like the above tags.
Also we can do some renderer like this with some topics which change the
way to show the data:
https://yopaseopor.github.io/osmhistoricmap/#map=18.224/42.26818/2.96101/0&Topics=01000000
(II Spanish Republic)
https://yopaseopor.github.io/osmhistoricmap/#map=18.224/42.26818/2.96101/0&Topics=00100000
(Spanish Dictatorship 1939-1975)
Also this render "understand" from 0 to 2020 data you may found inside OSM.
OSM will not erase existing data about ruins, about no-more-existing
business, or old names well tagged.
Do we need other database rather than OSM's ? Well, If we need it we will
have to start in some day with the present. Importing OSM data is not
possible due to difficulties of licenses? Make it the same to avoid it.
OHM is so small and we need data to make the present. Without present will
not be past or future.
Time is running, I think we have to discuss it. Would it be possible to
start the present some day on OHM?
yopaseopor
History and Maps.
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Libre
de virus. www.avast.com
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
On Fri, Aug 20, 2021 at 5:02 PM Dldwg @.***> wrote:

I would prefer merging both databases and projects, this way we could use
already existing OSM data and make things way much simplier. The fact is,
we don't have enough contributors to make a whole new database. For exemple
I work on railways and public transport in Belgium and France and I can't
simply re-make everyting from scratch, on the other hand it's often
discouraging as I contribute to both OSM and OHM and have to make things
twice on both databases.
Of course we could upload OSM data in OHM but it would be nearly
impossible to keep all this data up to date with OSM.
Merging both database would take time but it's much less difficult than
re-creating a whole new database from scratch.
The issue is how would OSM handle OHM content in the simplest way possible
? in such a way that OSM database and renderers are little or not modified.
_1. The only modification to the OSM project would be to add a filter in
renderers : "HIDE if end_date<CURRENTDATE". No database modification would
be needed within OSM.
And we add a filter in OHM renderers : "HIDE if end_date or start_date are
not used" this way we only show in OHM elements with start/end tags.
_
2.
We should also need to adapt OHM tagging so as not to have an influence on
OSM renderer, this could also be done in a simple way by only using tags
with numbers at their end for historical data : lets take for exemple a
road which current name is "Blue street"
OSM data should give this :
name=Blue street
However this street was before 1990 named "Red street" and before 1950
"Yellow street" so OHM data should looks like this :
name=Yellow street
name2=Red street
name2_start_date=1950
name3=Blue street
name3_start_date=1990
Now for OSM data not to considerer "historical" tags we should only use
tags with numbers at its end :
Same street in a merged database
// Historical data
name1=Yellow street - it's no longer name but name1 this way OSM renderers
shouldn't considerer historical data.
name2=Red street
name2_start_date=1950
name3=Blue street
name3_start_date=1990
// Current data (OSM)
name=Blue street
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenHistoricalMap/issues/issues/275#issuecomment-902757546,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABIB4VU5FFFJAMI22V57T7DT5ZVA7ANCNFSM5CFCKWOQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.