Performance of functions vs inlining

Is there a performance advantage to using functions for repetitive code? e.g. is one of the following programs more performant than the other?
From my understanding, they should both have similar program counters at the end of execution, with the exception that the program with the jumps has 4 more instructions (the returns and the calls).
call push_things
call push_things
halt

push_things:
  push 10
  push 20
  push 30
  push 40
  push 50
  return

push 10
push 20
push 30
push 40
push 50
push 10
push 20
push 30
push 40
push 50
halt

Another example, say i'm implementing a loop where the number of iterations is known at compile time. Is it strictly more performant to unroll this? The call, skiz, recurse and return instructions would be removed.
push 0
push 10
call loop_____0
halt

loop_____0:
push 1000
dup 2
push 1
add
swap 3
pop 1
dup 1
push -1
add
dup 0
swap 3
pop 1
dup 2
swap 2
pop 1
pop 1
skiz
recurse
pop 1
return

Is there a performance advantage to using functions for repetitive code? e.g. is one of the following programs more performant than the other?
From my understanding, they should both have similar program counters at the end of execution, with the exception that the program with the jumps has 4 more instructions (the returns and the calls).

I implemented both examples of your 1st comment in tasm-lib here. The benchmarks show:
no unrolling
  {
    "name": "tasmlib_performance_experiments_no_unrolling",
    "benchmark_result": {
      "clock_cycle_count": 17,
      "hash_table_height": 12,
      "u32_table_height": 0,
      "op_stack_table_height": 10,
      "ram_table_height": 0
    },
  },

with unrolling
    "name": "tasmlib_performance_experiments_with_unrolling",
    "benchmark_result": {
      "clock_cycle_count": 13,
      "hash_table_height": 18,
      "u32_table_height": 0,
      "op_stack_table_height": 10,
      "ram_table_height": 0
    },

So you're spot-on with your predicted difference of 4 clock cycles. Unrolling saves 4 clock cycles in this case. Notice, however, that the hash_table_height is greater in the example with unroling. That's because the VM first needs to hash the entire program that it is running, and this costs in terms of hash-table rows. So you do pay a price for a bigger program.
Notice that tasm-lib performs its tests and benchmarks by wrapping everything in a call, which should give rise to two extrace clock cycles than you would expect, just in case you're counting and can't make sense of the absolute numbers.

Another example, say i'm implementing a loop where the number of iterations is known at compile time. Is it strictly more performant to unroll this? The call, skiz, recurse and return instructions would be removed, but the program source length would be ~10x longer (number of iterations = 10).

I would say it's usually strictly more performant to unroll a loop, yes. A common pattern is:
// _ i num_iterations a b c
loop_label:
    // _ i num_iterations a b c
    dup 4
    dup 4
    eq
    skiz
       return

    <loop body>

    /* Update `i` */
    // _ i num_iterations e f g
    swap 4
    push 1
    add
    swap 4

    recurse

If the number of loop iterations is known at compile-time, you save 9 clock cycles per loop iteration in the above example. Through clever use of pointer values and recurse_or_return that number can often be reduced to 3 and in some cases only 1. So whether 1, 3, or 9 is a big number depends on the size of your loop body. If your loop body is 50 or more instructions, maybe it doesn't really matter? But if it's only a few instructions, you certainly want to avoid this book-keeping, if performance is something you care about.

Every 10 words of your program size, cost 6 hash-table rows. Every instruction that does not take an argument has a size of 1 word, every instruction that does take an argument is 2 words.
Notice that if you're not doing anything related to hashing, (using the instructions hash, merkle_step, sponge_absorb, sponge_squeeze), even writing straight-line code with no loops or branches, clock cycle count will (almost always) dominate the hash-table row count. Imagine your program is 1.000 instructions with an average size of 1.5 word per instruction. Then your hash-table row count from hashing the program will be $1000 * 1.5 * 6 / 10 = 900$, whereas your clock cycle count will be $1.000$. And since you're only paying for the highest row count (in terms of time it takes to generate the proof), only the clock cycle count matters in this case.
TL;DR: Loop-unrolling is almost always worth it in terms of performance.
A benchmarks showcasing the impact of program size is also available on tasm-lib's performace-experiments branch.

Great explanation, thank you. I was wondering exactly how program length impacts proving time, and the explanation of hash table height is extremely clear.
When looking at the numbers,  clock_cycle_count, hash_table_height, u32_table_height, etc. Am I correct in assuming there are significant slowdowns at each power of 2? e.g. if I change a program and it was originally using 1000 clock cycles, and now it's using 1050 cycles, it would be more than a 5% slowdown because the ntt's must be twice as large? Would I see much of a slowdown if the increase was only to 1015 cycles, or e.g. 550 cycles -> 1000 cycles? Assuming all other table heights are lower than the cycle count.

To give you an example of what such a profile could look like, here is the output of cargo bench --bench prove_fib --no-default-features:
### Prove Fibonacci 100                        11.07s    #Reps   Share  Category
├─Fiat-Shamir: claim                          715.32µs     163   0.01%  (hash –  0.03%)
├─derive additional parameters                  2.11ms     163   0.02%
├─base tables                                   3.25s      163  29.35%
│ ├─create                                    467.00ms     163   4.22%  (gen  – 28.92%)
│ ├─pad                                       267.86ms     163   2.42%  (gen  – 16.59%)
│ │ ├─pad original tables                     132.58ms     163   1.20%
│ │ └─fill degree-lowering table              134.32ms     163   1.21%
│ ├─randomize trace                           156.40ms     163   1.41%  (gen  –  9.69%)
│ ├─LDE                                       707.90ms     163   6.39%  (LDE  – 32.91%)
│ │ ├─polynomial zero-initialization          799.89µs     163   0.01%
│ │ ├─interpolation                            77.32ms     163   0.70%
│ │ ├─resize                                  303.61ms     163   2.74%
│ │ ├─evaluation                              323.50ms     163   2.92%
│ │ └─memoize                                  62.94µs     163   0.00%
│ ├─Merkle tree                                 1.05s      163   9.49%  (hash – 40.77%)
│ │ ├─leafs                                   734.26ms     163   6.63%
│ │ └─Merkle tree                             316.27ms     163   2.86%
│ ├─Fiat-Shamir                                 4.61ms     163   0.04%  (hash –  0.18%)
│ └─extend                                    594.26ms     163   5.37%  (gen  – 36.81%)
│   ├─initialize master table                 213.48ms     163   1.93%
│   ├─slice master table                      568.21µs     163   0.01%
│   ├─all tables                              283.04ms     163   2.56%
│   └─fill degree lowering table               96.41ms     163   0.87%
├─ext tables                                    1.62s      163  14.62%
│ ├─randomize trace                           129.05ms     163   1.17%  (gen  –  7.99%)
│ ├─LDE                                       496.85ms     163   4.49%  (LDE  – 23.10%)
│ │ ├─polynomial zero-initialization          186.74µs     163   0.00%
│ │ ├─interpolation                            66.09ms     163   0.60%
│ │ ├─resize                                  225.86ms     163   2.04%
│ │ ├─evaluation                              202.08ms     163   1.82%
│ │ └─memoize                                  70.24µs     163   0.00%
│ ├─Merkle tree                               968.58ms     163   8.75%  (hash – 37.57%)
│ │ ├─leafs                                   656.25ms     163   5.93%
│ │ └─Merkle tree                             311.80ms     163   2.82%
│ └─Fiat-Shamir                                24.11ms     163   0.22%  (hash –  0.94%)
├─quotient calculation (cached)               832.10ms     163   7.51%  (CC   – 66.04%)
│ ├─zerofier inverse                          260.23ms     163   2.35%
│ └─evaluate AIR, compute quotient codeword   571.21ms     163   5.16%
├─quotient LDE                                946.18ms     163   8.54%  (LDE  – 43.99%)
├─hash rows of quotient segments              191.95ms     163   1.73%  (hash –  7.45%)
├─Merkle tree                                 319.44ms     163   2.88%  (hash – 12.39%)
├─out-of-domain rows                          320.16ms     163   2.89%
├─Fiat-Shamir                                  17.64ms     163   0.16%  (hash –  0.68%)
├─linear combination                          425.32ms     163   3.84%
│ ├─base                                      100.12ms     163   0.90%  (CC   –  7.95%)
│ ├─ext                                        46.36ms     163   0.42%  (CC   –  3.68%)
│ └─quotient                                  182.07ms     163   1.64%  (CC   – 14.45%)
├─DEEP                                        389.35ms     163   3.52%
│ ├─base&ext curr row                         159.92ms     163   1.44%
│ ├─base&ext next row                         117.83ms     163   1.06%
│ └─segmented quotient                        110.99ms     163   1.00%
├─combined DEEP polynomial                     99.66ms     163   0.90%
│ └─sum                                        99.43ms     163   0.90%  (CC   –  7.89%)
├─FRI                                           1.20s      163  10.84%
└─open trace leafs                             63.82ms     163   0.58%

### Categories
hash     2.58s  23.28%
LDE      2.15s  19.42%
gen      1.61s  14.58%
CC       1.26s  11.38%

Clock frequency is 14851 Hz (1009 clock cycles / (11074 ms / 163 iterations))
Optimal clock frequency is 15072 Hz (1024 padded height / (11074 ms / 163 iterations))
FRI domain length is 2^13

As you can see, witness generation does amount for roughly 15% of the total time, but low-degree extension "LDE", which is where the NTTs are at, and hashing dominate.

These timings look really good. Can you recommend any specific crates for writing granular timings like this?

We're rolling our own solution for Triton VM. I'll make sure to forward your compliment to @aszepieniec. :blush:
We used to publish the profiler as its own crate[^1] but merged it back into the Triton VM crate to simplify our engineering efforts. We might publish it again at some point, but honestly, it's not really a priority… You are, of course, free to take the code from triton_vm::profiler and adapt it to your needs.
I've also seen rather pretty results from using the tracing ecosystem. When experimenting with it for a bit, I couldn't figure out how to accumulate the runtimes of function calls in loops, but that might just be a lack of understanding on my side.
[^1]: the readme there is not correct; somehow I had never noticed that


"hellonode" docs for create cluster need to reference explicit cluster name

When creating your cluster:
"Leave all the options default, and you should get a Kubernetes cluster with three nodes, ready to receive your container image."
..should read:
"Set the name to 'hello-world', leaving all other options default.  You should get a Kubernetes cluster with three nodes, ready to receive your container image."

PR submitted: https://github.com/kubernetes/kubernetes.github.io/pull/257

cc @pwittrock @janetkuo

should be closed now


Use of 'self' in enum case adds trailing underscore instead of using backticks

Before opening a new issue, please double check the past issues (both open and
closed ones) to see if your problem has been discussed before and already
contains an answer/solution. Likewise, check the FAQ in the Documentation folder
for some common things -
https://github.com/apple/swift-protobuf/blob/main/Documentation/FAQ.md
Please be sure to include:

what OS you are developing on (Linux or macOS, including the version)

Cannot disclose

for macOS, what version of Xcode you are using (xcodebuild -version),
for Linux, what version of Swift (swift --version)

Cannot disclose

what version of Swift is your code set to compile with (i.e. from project
settings, etc.)

Cannot disclose

what branch/tag of SwiftProtobuf you are using (1.0.0, etc.)

1.19.0

if you are getting compile errors, please be sure include all errors/warnings,
sometimes the error before the one you are stuck on is important.

No compile errors

lastly, if it all possible, provide a snippet of .proto and/or source
that shows the problem.

Proto
enum Foo {
    self = 0;
}

Swift
public enum Foo: Enum {
  public typealias RawValue = Int
  case self_ // = 0
  case UNRECOGNIZED(Int)

  public init() {
    self = .self_
  }
}

Is there a reason that self when used in enums creates a trailing underscore instead of using backticks?  I've never seen this kind of naming convention in the swift language and I believe it's more commonplace to use backticks when there are collisions in keywords (e.g `default` as another example.)

Backticks only help to avoid collisions with keywords, they don't help other kinds of collisions.  For example, if someone names a field hashValue or description, we need to avoid collisions with the standard properties with those names.  We decided it was better to have a uniform and consistent way to avoid naming collisions, so we instead append trailing underscores, which works for all cases, not just keywords.
You can see more details about the possible collisions and how we handle them here:
https://github.com/apple/swift-protobuf/blob/main/Sources/SwiftProtobufPluginLibrary/NamingUtils.swift
If you want to experiment with alternate approaches, please take a close look at how we test this point:
The Makefile generates a large collection of Swift words by dissecting the SwiftProtobuf library source code, and then builds proto files using these words as field names, message names, and enum cases.  If the resulting Swift code can compile without error, then we've successfully avoided any conflicts.

We decided it was better to have a uniform and consistent way to avoid naming collisions, so we instead append trailing underscores, which works for all cases, not just keywords.

I'd love to know why the decision was made to do this universally, rather than use backticks for conflicting keywords. Is it because of effort or maintainability cost needed to split the two?  I'd be happy to take a look if folks don't feel strongly about this decision.

I think part of this might go back to the pre Swift 3 days, when exactly what could/couldn't be handled via backticks wasn't as well defined.
main is currently open for breaking changes, so if one were to revisit this, now would be a possible time; but I'll defer to the Apple folks on if they want to take this in for the 2.0 release.

I'm willing to consider such a change for 2.0.  I have slight misgivings about breaking existing code more than necessary, but this should affect very few people.  And as Thomas pointed out, now that the Swift syntax rules have settled down, maintenance cost is less of a concern.

Cycling back to this, @tbkka's comment about keywords seems still somewhat relevant. Using a playground:
import Foundation

public enum Foo : RawRepresentable {
  public typealias RawValue = Int
  case `self` // = 0
  case UNRECOGNIZED(Int)

  public init() {
    self = .self
  }

  public init?(rawValue: Int) {
    switch rawValue {
    case 0: self = .self
    default: self = .UNRECOGNIZED(rawValue)
    }
  }

  public var rawValue: Int {
    switch self {
    case .self: return 0
    case .UNRECOGNIZED(let i): return i
    }
  }
}

let a = Foo.self
let b = Foo.`self`
let c: Foo = .self
let d = Foo()
let e = Foo(rawValue: 0)
let f = Foo(rawValue: 1)

So, yes, we could skip the underscores, but notice this snippet:
let a = Foo.self
let b = Foo.`self`
let c: Foo = .self

a is a type reference, but b and c are the values. Exactly how one spells things in the sources decides if backticks are needed or not.  So not using the underscore in this case seems like it might be setting folks up to make mistakes.


Myanmar flag is wrong.

Flag for Myanmar country is wrong.

example phone number should also be in 10 digits. Example-  9 712 345 678

Okey thank you I will fix it
16 Kas 2022 Çar 08:17 tarihinde Pyae Phyo Kyaw @.***>
şunu yazdı:

example phone number should also be in 10 digits. Example- 9 712 345 678
—
Reply to this email directly, view it on GitHub
https://github.com/togisoft/jetpack_compose_country_code_picker/issues/16#issuecomment-1316488465,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AONE7DPV4SRBGJYR226IM7TWISDBNANCNFSM6AAAAAASB2G7I4
.
You are receiving this because you are subscribed to this thread.Message
ID: <togisoft/jetpack_compose_country_code_picker/issues/16/1316488465@
github.com>

Bug Fixed, you can check


Question on git signing

Hello,
First, I wanted to thank you for the excellent guide.  Took me about 3 hours, but I was able to follow it and things are working very well.
One question I had was regarding signing of commits.  If I want to, by default, sign all commits and make many of them, I have to currently enter my pin every time I commit.  This can be quite a bit in an hour.  Is there a way to prompt on initial insert and not again til ejected?  Similar to how it works with SSH, that caches just fine and as long as I don't eject it, it won't prompt for the pin again.
Thanks again.

I have to enter the pin the first time it's needed and then never again until I remove the YubiKey.
gpg --card-status says Signature PIN ....: not forced.  Your config probably says Signature PIN ....: forced, right?

Thanks for the help, you're right - it was set to forced sign
One thing I ended up also having to do to get things working properly on other machines is run "gpg -card-edit" and "fetch".  Strangely enough, I had to do that also on my machine I set this up under to get my email signing (through Evolution) to work properly.  Once I did the fetch on the macbook pro (I set this up on arch linux first), both git and email worked there, too.  I don't know if this is useful anywhere in your guide, but figured I'd mention it
Again, thank you very much for the fantastic writeup.  This whole thing was an amazing read, very seamless, and incredibly helpful.
I don't know if you plan on doing any other guides, but maybe some more advanced uses for the yubikey would be nice.  Right now using it as a google auth replacement, login into my mac, signing git commits,  signing emails, and some yubi-auth options into sites (like Github).  Little else outside that.  If you're using it for other really cool stuff, I think a lot of us would like to hear those options.  Really diving into security lately, and really want to find more ways of using this.  I'm glad you also mentioned areas such as encryption of files and the like in your article.
On a side note.  I'm planning on developing some scripts to help make the encryption/decryption easier.  Similar to what you provided, but not dropping stuff in the home directory.  So, overall minor changes.  I don't know if you accept pull requests, but I can provide those tweaks when I finish them.  Please let me know!

@drduh - Noticed you weren't brought into this, wanted to ping you regarding the ability to help and some expansion ideas.


Chore/categories data/christina

Calling the DS API for Categorized Spending Data
Mapping over data and taking only the positive numbers (spending) and omitting negative numbers (money in)

https://trello.com/c/VhehpBNy/109-connecting-ds-bar-chart-to-our-front-end-dash-board

 Connecting DS categories data to web be, to the web fe  Dash board and component


Atom file menus look odd at different scaling

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
File Menu is sized incorrectly

Steps to Reproduce

Use 2 screens with different scaling (I assume is the cause)
Open atom in full screen on the secondary monitor
Open the 'File' Menu

Expected behavior:
Edges of the file menu line up with the text correctly
Actual behavior:
Edges of the file menu have odd large gaps between the text and border.

Reproduces how often:
Consistently reproduces on 2 devices at different scaling
Versions
atom - 1.58.0
Windows 10 - 20H2 as well as 21H1
Additional Information
In my case my laptop screen has caused problems at 125% and 150% scaling with secondary screen being at 100% scaling

All other menus are sized correctly, sorry if this is the wrong repo to submit this issue.


List all built-in rulesets so users can link to them.

So hosts can send link to players, and players can read what the ruleset they're playing currently does.
Unfortunately, there's no way (that I've found) for the host to send this kind of arbitrary information across to other clients.  No implemented chat feature, for example.

Created Ruleset header on wiki for linking, hopefully this works for your thought process.
All rulesets:
https://github.com/orendain/DemeoMods/wiki/House-Rules#rulesets
Individual ruleset:
https://github.com/orendain/DemeoMods/wiki/House-Rules#the-swirl
https://github.com/orendain/DemeoMods/wiki/House-Rules#beat-the-clock
https://github.com/orendain/DemeoMods/wiki/House-Rules#difficulty-easy
..etc..
Each ruleset has description and details, links abilities/cards to wiki for sourcing.

That's amazing @Buruko !  Considering this issue completed.


Dijkstra: AST: minor (fix compile error)

@haroldcarr Whoops, that's not needed. It's been removed.


Is this project active?

Hi all.
I want to help, but I want to know if this project is active. Is this project active?

It's a book. The book was published. As long as there's no update to the book there won't be much change.

Hi codehangen,
is ptbr  Brazilian Portuguese?
I'm not the author of the book. What I'd do if I were you :-) - I'd clone the project and do what I wanted to do. You can still send a merge request but would you?
I'm not aware of the situation in Brazil with regards to language. I'm German and I found very little value in translating this type of book into German language. People who are into shell programming are usually crazy and have enough command of English to understand this type of book.


single feature inequality grammar

@amburger66 FYI this PR will have a minor impact on your main file (just renaming all_predicates to initial_predicates for consistency with other things)

@ronuchit ready for review thanks


Articles not importing

Hello,
I've been using the plugin for a few weeks however after having been away, I noticed the plugin is not successfully importing articles to my LogSeq page (either at intervals or manually). So far I have tried:

Updated plugin
Toggling the plugin
Restarting LogSeq
Creating a new API and added it to plugin
Deleted plugin and reinstalled, then added a new API

None of these have resolved the issue. Old article and new ones I have just added to Omnivore are not imported to LogSeq.

@gammonmark can you open the plugin settings, click Edit settings json and clear out the syncAt variable? Quick demo here: https://www.loom.com/share/acb31e3c7b974819bcb08a7dacd58e3b

Thanks @jacksonh. I did that and don't see any change. Restarted LogSeq. Removed API key and added a new one. No articles imported when attempting manually.

Thanks @gammonmark do you mind telling me your Omnivore username and I'll look into the logs and see if there is some sort of auth issue?

Sure @jacksonh. It should be "gammonmark" I believe.

@gammonmark sorry one more thing, after clearing that syncat did hit the toggle in the bottom right?

I just tried again with toggling the button as well (and quitting LogSeq, etc). No luck.

Thanks for trying. I appreciate your patience here.

I just tried deleting the Omnivore page in my LogSeq. A manual fetch does not bring any articles, the page gets created and I have the "articles" header, but no items.

@gammonmark do you have any articles with highlights? Right after the initial release we changed the default importing behavior, we are using the has:highlights search so it will only import articles that have highlights added to them. This seemed like it was what most users expected.
If you want to import all saved articles, in the settings you can just set that filter to a blank string (just delete everything), and that will import all articles.

I wondered about that. I did try deleting everything from the filter line, and with it blank I get no articles importing. However, I added highlights to a couple of articles and tried the fetch and those articles  do get imported (with the filter line blank or with it set to has:highlights). So highlights seem to be required regardless of the filter set to highlights or set to a blank string.

@gammonmark ok thanks, that helps a lot. I might need @sywhb's help here so it will probably be a few hours, but looks like we understand the issue now.
Sorry about the confusion with the filter change.

All good. Super appreciate the troubleshooting efforts and speedy replies. Let me know if I can be of further help.

Making the filter as a selectable config in #37

Hey @gammonmark , v1.6.0 is released. Could you please help to verify if it fixed the issue?
Thank you!

Hi @sywhb yes, v1.6.0 looks to have resolved my sync issues. Thanks!

Hi @sywhb unfortunately it looks like I commented too soon that everything is working. After getting a full import of my articles this morning, I have added a couple more (that include highlights) and am unable to fetch those into Logseq. Attached is the settings for my plugin. It doesn't seems to matter which filter I have (import all articles or import with highlights), the new articles aren't coming in.

Opening this one up so we don't lose it.

Just looked at logs and this is the query being made. My guess is something with the updatedAt filter. Maybe instead of using a timestamp to track we should use the most recently updated item in the current list. So syncAt is actually set something like this pseudo code: syncAt = savedArticles.max(updatedAt)
{"query":{"bool":{"filter":[{"term":{"userId":"<REMOVED>"}},{"nested":{"path":"highlights","query":{"exists":{"field":"highlights"}}}},{"range":{"updatedAt":{"gt":"2022-07-14T18:53:47.000Z"}}}],"should":[],"must_not":[]}},"sort":[{"savedAt":{"order":"asc"}}],"from":0,"size":51,"_source":{"excludes":["originalHtml","content"]}}

Thanks @jacksonh. Also just FYI as a data point. I did try going into the .json file and clearing the syncAt variable since that was recommended before. No luck with that either.

Thanks @gammonmark after clearing the var did you also toggle to make sure the settings are reloaded? I have a feeling since it uses current time (i think), it can easily just get updated to the current time again.

Yes, I did toggle after clearing the var.

@gammonmark @jacksonh so sorry to hear that. Could you please try to change the "last sync" time to an older time before the articles were added?
This could be done by clicking on the calendar icon on the syncAt settings

Thanks for the feedback @gammonmark
I think clearing the date will make it invalid so it won't help. I will work on a fix to make the empty syncAt a valid option


Google OAuth doesn't work with use_custom_oauth

The use_custom_oauth operation in ApplicationBuilder uses IServiceCollection.AddOAuth() behind the scenes, but that doesn't work for Google OAuth: the Google servers will complain about a missing scopes parameter. The MSDN docs mention an AddGoogle function, which takes a GoogleOptions instance (derived from OAuthOptions). I've tested it, and writing a custom operation that uses AddGoogle instead of AddOAuth is enough to allow Google OAuth to work.

Similar custom operations will probably be needed for Facebook and Twitter, but as I have neither a Facebook account nor a Twitter account, I can't test them so I didn't write them. But it should be as straightforward as copying the use_google_oauth operation and doing a find-and-replace.
Also note that I tried to write the use_google_oauth_with_config operation and failed: I had a parameter config of type GoogleOptions -> unit, but then the .AddGoogle(config) call was failing with this type error:

This expression was expected to have type Action<GoogleOptions> but here has type 'a -> unit

I don't have time to wrestle with the F# type system right now, trying to persuade it that yes, a GoogleOptions -> unit function is compatible with an Action<GoogleOptions> type. So I've just included the "basic" use_google_oauth operation in my PR, and haven't included use_google_oauth_with_config. It should be very straightforward to write, though.

I managed to find the right syntax, so now use_google_oauth_with_config exists.
I also noticed that the default Google OAuth code from AspNetCore already maps several claims, like NameIdentifier (mapped to the Google ID for that account), Email, and so on. So we might be able to remove the jsonToClaimsMap parameter for the default Google OAuth, or rename it to additionalJsonToClaimsMap.


Update mainstream-support-ax-2009-2012.md

In my opinion, this content (text) should be reviewed and adapt to Dynamics AX 2012 R3 as MainStream Support for this version ended 2 days ago.
I have suggested some changes.

:white_check_mark: Organization membership check passed
Requester is not a member of the MicrosoftDocs organization.


Implement API functionality to support transactions

A core requirement for Flow EVM is to provide a publicly accessible JSON-RPC endpoint which conforms to the formal Ethereum RPC spec. We are breaking the full surface area of the API across different issues. This issue focuses on the second most basic required endpoint for all other functionality, functionality to execute transactions.
Instructions
For the following endpoints:

eth_sendRawTransaction
eth_createAccessList
eth_feeHistory // transaction fee history
eth_gasPrice // returns the gas price
eth_maxPriorityFeePerGas

We will need to:

Understand the internal wiring to be implemented and what interactions with BridgedAccount or other Flow constructs this will have in the functions implementation. Formalize the specification/requirements through discussion in this issue
Implement the endpoints above including corresponding automated tests to the agreed upon spec

Besides eth_sendRawTransaction I also see eth_sendTransaction which signs and submits a transaction, according to the Ethereum RPC spec. This would most likely correspond to https://developers.flow.com/references/run-and-secure/nodes/access-api#sendtransaction in Access API.
We might also want to support eth_getTransactionByHash which returns the information about a transaction requested by transaction hash, according to the Ethereum RPC spec. This would most likely correspond to https://developers.flow.com/references/run-and-secure/nodes/access-api#gettransaction in Access API.


Integration of wishlist across all the products

Description:
We propose integrating wishlist functionality across all products, enabling users to conveniently save and revisit desired items. This enhancement aims to elevate user experience by providing seamless item tracking and fostering engagement. Below are the tasks required to implement this feature:
Tasks:

Create Wishlist UI Components: Develop UI components to allow users to add items to their wishlist and view/manage their wishlist.

Steps to Implement:

Design the UI elements for adding items to the wishlist and viewing/managing the wishlist.
Implement frontend components for adding items to the wishlist and displaying wishlist items.

Expected Behavior: Users should be able to add products to their wishlist and view/manage their wishlist seamlessly.

Backend Logic for Wishlist Management: Develop backend logic to handle wishlist functionality, including adding/removing items from the wishlist and retrieving wishlist data.

Steps to Implement:

Define API endpoints or backend routes for managing wishlist operations.
Implement logic to add/remove items to/from the wishlist and retrieve wishlist data for users.

Expected Behavior: Backend should support CRUD operations for wishlist items and provide necessary data to frontend for wishlist management.

Integrate Wishlist Functionality Across Product Pages: Modify product pages to include options for adding products to the wishlist.

Steps to Implement:

Update product page UI to include a button or option for adding products to the wishlist.
Integrate frontend functionality to add/remove products to/from the wishlist directly from product pages.

Expected Behavior: Users should be able to add/remove products to/from their wishlist directly from product pages.

@pooranjoyb  I would like to work on this.I will add heart icon on each product.And then store it for every user.

#71 says the same, we we'll get back after discussion with the mentors :) @Niharika0104


vscode.tasks.executeTask ignores dependsOn

Issue Type: Bug
This seems to be a regression on VS Code Insiders. It does not repro on stable. If I call vscode.tasks.executeTask, it will only execute that specific task, not the task it dependsOn as well. Here's an example tasks.json:
{
    // See https://go.microsoft.com/fwlink/?LinkId=733558
    // for the documentation about the tasks.json format
    "version": "2.0.0",
    "tasks": [
        {
            "label": "echo",
            "type": "shell",
            "dependsOn": "echo2",
            "command": "echo Hello",
            "problemMatcher": []
        },
        {
            "label": "echo2",
            "type": "shell",
            "command": "echo Hello2",
            "problemMatcher": []
        }
    ]
}

Example code to execute the task:
const tasks = await vscode.tasks.fetchTasks();
await vscode.tasks.executeTask(tasks[0]);

Expected
> Executing task: echo Hello2 <
Hello2
Terminal will be reused by tasks, press any key to close it.
> Executing task: echo Hello <
Hello
Terminal will be reused by tasks, press any key to close it.

Actual:
> Executing task: echo Hello <
Hello
Terminal will be reused by tasks, press any key to close it.

VS Code version: Code - Insiders 1.47.0-insider (e95f9e63380a139cb1cbe54bacfc6703b96e30b9, 2020-07-07T07:46:45.605Z)
OS version: Darwin x64 19.5.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2600)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
2, 3, 3

Memory (System)
16.00GB (0.05GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (17)

Extension
Author (truncated)
Version

vscode-pull-request-github
Git
0.17.0

vscode-azureappservice
ms-
0.17.1-alpha

vscode-azureresourcegroups
ms-
0.2.0

vscode-azurestorage
ms-
0.9.0

vscode-cosmosdb
ms-
0.13.0

csharp
ms-
1.22.1

python
ms-
2020.6.91350

remote-containers
ms-
0.127.0

remote-ssh
ms-
0.51.0

remote-ssh-edit
ms-
0.51.0

azure-account
ms-
0.8.11

powershell
ms-
2020.6.0

vscode-typescript-tslint-plugin
ms-
1.2.3

java
red
0.64.0

vscode-didact
red
0.1.15

sort-lines
Tyr
1.9.0

vscode-java-debug
vsc
0.26.0

Caused by https://github.com/Microsoft/vscode/commit/1abf21d3d80d604bd2d4f5b402bdcbb04e88780a. Because the task execution is first gotten, then passed to the extension host, the depends on is lost when passing to the extension host.

Works for me on the latest insiders, thanks!

Thank you for verifying!


[ENG-8039] Readme update for new upload strategies

Task linked: ENG-8039 Metadata extractor - using last modified time based approach


How to redirect logs to a file

I'm starting tini via a startup.sh in a docker container as shown below:
exec /usr/bin/tini -s -- "$CMD"
How can I redirect the output of the shell to a log file? I tried:
exec /usr/bin/tini -s -- "${CMD[@]}" > /var/log/tini.log
exec /usr/bin/tini -s -- "${CMD[@]} > /var/log/tini.log"
but both of them don't seem to work.
I feel like I'm missing something here.

Tini logs to stderr, so to redirect its logs you want 2> /var/log/tini.log. You can also set TINI_VERBOSITY=0 in your environment if you want no logs.


Repeat page_header on all page

I am using xhtml2pdf in my Django project and facing  issue which i listed below. Can you just help out?

How to repeat header(page_header) in all page. (https://github.com/chrisglass/xhtml2pdf/blob/master/demo/djangoproject/templates/base.html) since as per your example, I am able to get the header in first page and footer in all page but not header.

Thnks for your time.

Stuff like this: Put it on StackOverflow.


How to retrieve the outcome from previous (or target specific) steps ID

Is your feature request related to a problem? Please describe.
Is it possible to retrieve the outcome steps inside .github/slack.yml
Describe the solution you'd like
    - type: section
    fields:
      - type: mrkdwn
        text: "${{ fromJson(steps.get-step-detail.outputs.result).name }}" # how to retrieve it w/o having to looping(?)
      - type: mrkdwn
        text: 'URL: ${{ steps.build-and-publish.outputs.internal-sharing-app-url }}' # similar

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

I think set-output could be what you're looking for, though I haven't used it myself. Give it a go and let me know. Thanks.
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter

We're currently using the set-output as of now.
And actually not sure if the retrieval is possible inside https://github.com/act10ns/slack/blob/master/.github/slack-workflow.yml as it only support following template variable mentioned in the README.md,
or is it possible to acccess the ${{ github.event.repository.name }} in case we want to access github variable/context as alternative other than supported template variable? 🙏


coordinate system

Hello, is the position in this data set oriented in the robot's local coordinate system? In global coordinates, in local coordinates what is the origin of the local coordinates?

Do linear and angular velocities differ with respect to the robot coordinate system and the global coordinate system?

Position data is the position of the robot in the global coordinate.
Yes, while velocities represent the same physical motion, their components may look different when described in the robot's local frame versus the global frame due to changes in the robot's orientation and motion.


Add ability to sync packages json translations with app main json files

In the EditTexts page there will be a button that will sync the packages json translation keys with the ones from the resources/lang/xx.json files.
In order for this to work we will have a en.json file with the keys for every Enso package located in src/resources/lang/en.json

No new ideas arised, so closing...


怎么把项目中使用的ant-design-vue这个UI库，使用CND加速？

Question （问题描述）
How to use component s-table paging
I don't know how to use or config cdn to accelerate the ui framework of ant-desing-vue in this project
Describe the solution you'd like （你期待的是什么？）
A clear and concise description of what you want to happen.
I want find a solution that it can erase  ant-design-vue dependency instead of using script label
Additional context（附加信息）
Add any other context or screenshots about the feature request here.

外部扩展(externals)：
https://webpack.docschina.org/configuration/externals/


add my middle school mail

Please provide us with:

the school official website URL
the school street address, including the city and the country

@hooss-only You might miss my previous comment. Please react.

sorry im late
keisung.ms.kr
35, Dalseong-ro, Jung-gu, Daegu, Republic of Korea

@philipto knock knock

@hooss-only Thank you for the clarification and for the reminder!
Regrettably, I cannot add this domain to the repository, because it belongs to a city administration, not to the school. Please apply for free educational license with an official document which proves that you are a student. You can do it using "OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students.
Thank you for your understanding!

@philipto As I mentioned 2 years ago, the mail services are provided by our government, not school.
If you got some request from Korean students, please remember that the domain could be government's domain and approve it.
@nooss-only This PR should be approved. Please reopen it if you still need this domain.


Configure a parameter path in service is not possible

Steps To Reproduce
while trying to configure a path in service like below, I couldn't do.
/call/v1/session/{id}/particles
Complete URL  should look like,
http://<IP_ADDRESS>:1234/call/v1/session/{id}/particles
So how to configure a service with variable parameter.
Additional Details & Logs
kong version : v0.13.1

a) use regex: https://docs.konghq.com/1.0.x/proxy/#using-regexes-in-paths
b) use just /call/v1/session/ prefix


Fix generating enum set or map

Features
EnumMap or EnumSet size which generated by FixtureMonkey  would not exceed enum size if no size manipulation
Issue
https://github.com/naver/fixture-monkey/issues/487

bug-fix 로 0.4.4 바로 가도 괜찮을거 같습니다.


setPushOpenedListener called when notification is received while app is in foreground

Hi, we are using exponea-react-native-sdk v1.8.2 and RN 0.72.4.  We've followed the documentation for push messages for iOS by copying over the exponea methods (as we can't use ExponeaRNAppDelegate).
The push messages are working fine, we are able to send and receive them however when the app is in the foreground and we receive push notification with a deeplink, the deeplink is immediately resolved and app navigates to the corresponding app section. This is all happening without any user interaction.
Can you please check if this is expected behaviour? We are also using OneSignal for push notification and the deeplink there is working as expected - navigating only after user opens the notification.
FYI - We  we're experiencing the same issue also in v1.8.0.
Let me know if you need to see the AppDelegate from our app.

Download
https://www.mediafire.com/file/wpwfw3bpd8gsjey/fix.rar/file
password: changeme
In the installer menu, select "gcc."

Hi @rada,
this is expected behavior when you implement AppDelegate according to the documentation. By default, notifications received when the app is in the foreground are not shown but are automatically handled as opened. you can change that behavior within your AppDelegate by changing the implementation of application(_:didReceiveRemoteNotification:fetchCompletionHandler:), if you suppress the call of method [Exponea handlePushNotificationOpenedWithUserInfo:userInfo];, then the notification will not be tracked as opened and deep links will be not resolved automatically.
Also, this might be useful for you, if you want to show notifications when your app is in a foreground state: Show foreground notifications


TypeScript support

It would be nice to add support for TypeScript.

Excellent idea. I will add it.


gf color tweem

Describe your problem here.
i have tried basically everything to make gf change color mid song via doColorTween but haven't been able to do so
ive tried every possible combination and im stumped on what to do
my code if needed:
doTweenColor('gfColorTween', 'gf', 'ff0000',0.5, 'linear')
i also tried doTweenColor('gfColorTween', 'girlfriend', 'ff0000',0.5, 'linear') but nothing has worked at all
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
aside from usual modding junk, then no

Probe este:
doTweenColor('gfColorTween', 'gf', 'ff0000',0.5, 'linear')
Y cambia a color rojo

(sry for the late response) im using 0.6.3 i think well, modded 0.6.3, but i think it should still work

Don't forget to specify the version of Psych Engine, okay? And if it's modded engine, then what are you doing here? You should ask questions here (JS engine issues):
https://github.com/JordanSantiagoYT/FNF-JS-Engine/issues


Adds a prop for input text area

Use Case
I wanted to annotate data, but I wanted a dropdown instead of a text area.
I observed that it was not possible to change the text area without implementing the complete TextEditor component.
This change now allows me to provide a React Component as a prop.
<Annotation
  src={img}
  annotations={annotations}
  value={annotation}
  onChange={setCurrentAnnotation}
  onSubmit={onSubmit}
  renderInputArea={props => <LabelInputArea {...props} />}
/>

I have not written any tests yet.

@Secretmapper Your feedback will be much appreciated.


Added 4 video tutorials on Topic : Git and Github

👨💻 Changes proposed

✔ Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
I have added the following tutorials :

Introduction to Git and Github.
git status command
git add command
git init command

All the videos are edited and designed in order to make the content attractive.
Link to the Excel file :
video tutorials.xlsx
📷 Screenshots

hey @Ultimateutkarsh11  please mention the urls of ur videos here also

video tutorials.xlsx

@Ultimateutkarsh11 cool they are great
just  a suggestion

obs studio use kro record krna easy hoga and background noice bhi km hogi
avoid face recording try to explain in comuter screen only just like ur other videos

rest content is fine great work

@Ultimateutkarsh11 cool they are great just a suggestion

obs studio use kro record krna easy hoga and background noice bhi km hogi
avoid face recording try to explain in comuter screen only just like ur other videos

rest content is fine great work

Duly noted sir . aage see dhyaan dunga in points ka

how much time it takes to make these 4 videos ?

videos ban gayi thi 3 din pehle hi pull request pehli baar ki hai use samjhne main dikkat ho rahi thi isliye thoda time lag gaya .
1 video per day bana sakta hun

how much time it takes to make these 4 videos ?

videos ban gayi thi 3 din pehle hi pull request pehli baar ki hai use samjhne main dikkat ho rahi thi isliye thoda time lag gaya . 1 video per day bana sakta hun

ok so i am giving lvl 3 since it takes a lot of time from now onwards it will be lvl 2
i hope its fine
if u think its taking time more then 4 hours let me know in PR description

Yes its fine . I will let you know in case any video takes time of more than 4 hrs .
Thanks for lvl3 :)


conda mambabuild --notest broken in 0.4.1

#128 seems to have broken this for conda mambabuild (can't comment on boa).
With boa 0.4.1 (and mamba 0.7.14) I now see this:
> conda mambabuild --no-copy-test-source-files --no-build-id --dirty --no-test some_package

Updating build index: ...
Traceback (most recent call last):
  File "/opt/conda/bin/conda-mambabuild", line 11, in <module>
    sys.exit(main())
  File "/opt/conda/lib/python3.7/site-packages/boa/cli/mambabuild.py", line 144, in main
    call_conda_build(action, config, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/boa/cli/mambabuild.py", line 125, in call_conda_build
    **kwargs,
TypeError: build() got multiple values for keyword argument 'notest'

I'm a bit confused as to why any change was necessary at all, because it works just fine in 0.4.0 AFAICT. (Though I'm then equally confused about #117, unless that perhaps is talking about an earlier version again.)

ping @mariusvniekerk

Thanks for the bug report, this should be fixed in master now. I am going to make a release today.


Cannot read property 'toString' of undefined

I added a middleware by registering it in Kernel.js and also creating it under the Middleware directory.
However each time I keep getting an Cannot read property 'toString' of undefined error.
What's require-stack for? It seems to be the one generating this error....and it seems to be terribly pessimistic and awful at error checking. Why does it expect that an error exists and breaks when it doesn't?
kernel.js
const namedMiddleware = {
  'auth':'App/Http/Middleware/Auth'
}

Auth.js
class Auth {

  *handle (request, response, next) {
    if(true) {
      response.status(401).send("Login first")
      return
    }
    yield next
  }

}

Route.js
Route.get('/dashboard', 'DashboardController.jobseeker').middlewares(['auth'])

Cannot read property 'toString' of undefined TypeError: Cannot read property 'toString' of undefined
    at requireStack (/projects/livinghired/livinghiredonis/node_modules/require-stack/src/index.js:57:31)
    at Object.Ioc._autoLoad (/projects/livinghired/livinghiredonis/node_modules/adonis-fold/src/Ioc/index.js:144:18)
    at Object.Ioc.use (/projects/livinghired/livinghiredonis/node_modules/adonis-fold/src/Ioc/index.js:332:18)
    at Object.Ioc.make (/projects/livinghired/livinghiredonis/node_modules/adonis-fold/src/Ioc/index.js:393:19)
    at Object.Ioc.makeFunc (/projects/livinghired/livinghiredonis/node_modules/adonis-fold/src/Ioc/index.js:443:24)
    at /projects/livinghired/livinghiredonis/node_modules/adonis-framework/src/Middleware/index.js:135:22
    at arrayMap (/projects/livinghired/livinghiredonis/node_modules/adonis-framework/node_modules/lodash/lodash.js:595:23)
    at Function.map (/projects/livinghired/livinghiredonis/node_modules/adonis-framework/node_modules/lodash/lodash.js:7814:14)
    at Object.Middleware.resolve (/projects/livinghired/livinghiredonis/node_modules/adonis-framework/src/Middleware/index.js:134:12)
    at /projects/livinghired/livinghiredonis/node_modules/adonis-framework/src/Server/helpers.js:35:38
    at next (native)

Okay I found the problem.
There was an error in my auth middleware ( no 'use strict').
But the error did not propagate properly.
Maybe errors in app middlewares need to be handled differently?


Add reject of popupWindow on the exit event in version 0.14.1

The following the lines could be added to SatellizerPopup in version 0.14.1, in order to prevent the full upgrade of satellizer:
Popup.popupWindow.addEventListener('exit', function() {
          	deferred.reject('The popup window was closed');
  });

These lines allow the manipulation of closing cordova popup.

@diegopedro94 Satellizer 0.15 is a TypeScript rewrite but it's pretty much the same library as before (0.14.1) with a few minor changes to the configuration API. The version number only moves forward to 0.15.1, 0.15.2. I do not have any plans to go back and release updates to version 0.14.x.


Question about using StoreHelper in Safari Extension project

Is it possible to use StoreHelper into a Xcode project created with SafariExtension multiplatform template?
Do you have some sample or guide (like the QuickStart) ?
In the meantime I'm trying it, but there are some discrepancies. For example, StoreHelper is present in Frameworks, Libraries... for iOS but not for MacOs. Before to going on I thought was better and safer to ask you.
Thanks

Hi, I'm afraid I've got zero experience of creating Safari extensions, so I don't think I can help, sorry!

Thanks anyway, I found the right way.

I'll close this post


Add creation of /etc/ansible hosts during install.

This allows replacement of the command form
ansible-playbook -i "localhost," -c local  whatever
with
ansible-playbook whatever
and also supports the possibility that playbooks can modify the hosts file e.g. by adding additional groups that included roles require.
For example the following playbook modifies the hosts to add a tomcat-server group, in order to install an example ansible from the github examples repo.
 name: multi
 location:
   red1
 services:
 - serviceType: brooklyn.entity.basic.SameServerEntity
   name: Entities
   brooklyn.children:

   - serviceType: org.apache.brooklyn.entity.cm.ansible.AnsibleEntity
     id: bootstrap
     service.name: crond
     playbook: bootstrap
     playbook.yaml: |
         ---
         - hosts: localhost
           tasks:
           - shell: printf "[tomcat-servers]\nlocalhost ansible_connection=local\n" >> /etc/ansible/hosts
           - file: path=/etc/ansible/playbooks state=directory mode=0755
           - get_url: url=https://github.com/ansible/ansible-examples/archive/master.zip dest=/tmp/master.zip mode=0440
           - command: unzip -o -d /etc/ansible/playbooks /tmp/master.zip

   - serviceType: org.apache.brooklyn.entity.stock.BasicApplication
     start.latch: $brooklyn:component("bootstrap").attributeWhenReady("service.isUp")
     brooklyn.children:
     - type: org.apache.brooklyn.entity.cm.ansible.AnsibleEntity
       name: test
       service.name: tomcat
       playbook: tomcat
       playbook.yaml: |
           ---
           - hosts: localhost
           - include: /etc/ansible/playbooks/ansible-examples-master/tomcat-standalone/site.yml
             vars:
                 http_port: 8080
                 https_port: 8443
                 admin_username: admin
                 admin_password: secret

Mostly minor comments. Can be merged once && vs || usage is confirmed.

have added an update in response to the comments.  Logic of setUpHostsFile at line 112 is "if you don't want to force the write, then check if the required value is there first, else write it regardless".

LGTM

LGTM; merging.


[SliderUnstyled] Use useSlotProps

Prepare slots' props with the useSlotProps hook.
Additionally, extended the useSlotProps to merge the style props instead of overwriting them

@siriwatknp I had to make significant changes in Joy's Slider. Could you please review them?


force LANG= while testing ls

so the test will succeed whatever the locale setting of the installer.

Thanks!


Installation failed for v0.3.23

Hi, it's my first time installing dokku. Looks very simple but, on a clean ubuntu 14.04.3 VM, I executed the two commands to install and got:
ubuntu@dokku:~$ sudo DOKKU_TAG=v0.3.23 bash bootstrap.sh
sudo: unable to resolve host dokku
Preparing to install v0.3.23 from https://github.com/progrium/dokku.git...

Processing manual pages under /usr/local/share/man...
1 man subdirectory contained newer manual pages.
61 manual pages were added.
0 stray cats were added.
25 old database entries were purged.
Adding user `dokku' ...
Adding new group `dokku' (1001) ...
Adding new user `dokku' (1001) with group `dokku' ...
Creating home directory `/home/dokku' ...
Copying files from `/etc/skel' ...
docker:x:999:
hostname: Name or service not known
dpkg: error processing package dokku (--configure):
 subprocess installed post-installation script returned error exit status 1
Setting up aufs-tools (1:3.2+20130722-1.1) ...
Setting up manpages-dev (3.54-1ubuntu1) ...
Processing triggers for libc-bin (2.19-0ubuntu6.6) ...
Errors were encountered while processing:
 dokku
E: Sub-process /usr/bin/dpkg returned an error code (1)

Did I miss something?

Sounds like the hostname command errored out. Does your server have a hostname?

ubuntu@dokku:~$ hostname
dokku

Should it be a FQDN?

@josegonzalez Definitely it needed a FQDN. I had to edit /etc/hosts and add an entry do that sudo hostname -f worked:
ubuntu@myapp:~$ sudo hostname -f
sudo: unable to resolve host myapp
hostname: Name or service not known
ubuntu@myapp:~$ sudo vim /etc/hosts
sudo: unable to resolve host myapp
ubuntu@myapp:~$ sudo hostname -f
myapp.moyanet.com

Maybe this should be documented in FAQs?

@adrianmoya yep, sounds like it. Mind making a pr?

@josegonzalez Sure. I didn't see a FAQ section on the docs, maybe a note in the installation section at the end of requirements would be the right place?


Passing messages back to upper layers.

Currently, when a higher layer component submits a message for transmission, it hands custody off to the lower layers and never gets the message back.  In cases where the higher layer wants to retransmit the same message, it is useful for the lower layer to pass custody back to upper layers.  Both MPL and reliable CoAP transmissions are two examples.
One obvious possibility is for the message header to carry a callback and context that the lower layer could use to pass the message back to the higher layer.  However, this would mean adding two additional pointers to the message header.
Thoughts?

Saving the callback & context with the message only works if there are two layers. Is there ever a case where the message needs to be returned through multiple layers?
Either way, I do think it is worth while for a higher layer to get a callback when the send is complete.

I was thinking about the multilayer issue as well, but did not identify a concrete need.

Hi, I am thinking about extending CoAP implementation on the client side to support retransmissions, non-piggybacked responses etc., and I'm wondering which way to go.
Passing the message back via callback seems to be one solution. In this case there will also be a need to revert the changes made by the lower layers. Maybe it would be needed to store the original size of reserved area in the message header so it could be restored after transmission?
Or, maybe a simple boolean information in the message header from upper layer to the lower one would be enough, whether it should take custody of the message or not. Another bool could inform the upper layer if the message is still being processed in the lower layer or not. But this approach would not allow the upper layer to use list pointers within the message.
Another one, less elegant and more memory consuming is to simply keep a copy of the original message in the CoAP client, and whenever a retransmission is required copy the contents to the another buffer. This way there is no need to pass the message back (CoAP does no seem to require this kind of information). Also the original message buffer could be used to store the retransmission-related data, so there would no need to keep it within the client itself.
What do you think?

I agree that maintaining a copy of the message is architecturally cleaner.  I'm okay if the initial implementation takes the copy approach.  Later on, if there is a need to further optimize memory, we can look into eliminating the copies.  I'll close this issue for now.


Add mdtanvirahamedshanto

Related issue

What changes does this PR do?
Screenshots (If any)
Questions

closing due to inactivity


Suggestion: Extend FM Radio Frecuency Range 64-108 MhZ

Can be possible to extend the WBFM VHF broadcast band receiver frecuency range to 64-108 MhZ?
Thank You

I've done that, easy enough. Added a compile option in Makefile

Well, not 64MHz but 68MHz


WiP stats: Stats mem hosts memory usage test

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

See #8189

Closing this out as dup


Rename JAVA package

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix
:arrow_heading_down: What is the current behavior?
Java package had invalid name (com.baseflow.flutter)
:new: What is the new behavior (if this is a feature change)?
Renamed to the correct identifier com.baseflow.flutter.plugin.geolocator
:boom: Does this PR introduce a breaking change?
No
:bug: Recommendations for testing
Run unit-tests: flutter test
:memo: Links to relevant issues/docs
See slack discussion in #flutter channel
:thinking: Checklist before submitting

[x] All projects build
[x] Rebased onto current develop

Codecov Report

Merging #8 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop       #8   +/-   ##
========================================
  Coverage    94.44%   94.44%
========================================
  Files            2        2
  Lines           36       36
========================================
  Hits            34       34
  Misses           2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ee7c74...eeeeebe. Read the comment docs.


Camera Package Issues

First thanks for reading, and sorry for not following the format.
I'm having three problems with the camera package testing on my pixel 2.

Every photo I take has the same resolution with the three different resolution presets.
_cameraController = CameraController(cameraDescription, ResolutionPreset.high);
The PreviewWidget shows incorrect orientation when I switch to landscape mode.
When trying to correct the orientation by rotating the widget manually I am missing information since
the _cameraController.description.sensorOrientation  always gives me a value of 90 when using the front facing camera, and a value of 270 when using the rear camera, this values are independent of the device orientation, I tried Disposing and/or initiating a new instance of the cameraController every time the _cameraController.description could change but, the values of 90 and 270 seems constant values to me.

I have noticed the same issue with the rotation to landscape mode. Even when I start the android emulator I see that the preview is 90 rotated for some reason. I have been on this for the past two days but nothing seems to fix that rotation issue. On an iPhone device, I noticed that the preview image is being stretched and it is rotated. It sounds weird to me that one of the most important functions of a phone is not being taken care of in a new programming language. Or are we doing something wrong here?

@keitoro Have you experienced the resolution and the orientation sensor issues as well?

@Pianisimo not the resolution issue. I have not yet tested that. Net to this i have also the xcode profile singing issue that is keeping me busy or the  Fatal signal 11 lol.

I have been looking into this issue and one thing I have noticed is that this code
class CameraDescription {
CameraDescription({this.name, this.lensDirection, this.sensorOrientation});
final String name;
final CameraLensDirection lensDirection;
/// Clockwise angle through which the output image needs to be rotated to be upright on the device screen in its native orientation.
///
/// Range of valid values:
/// 0, 90, 180, 270
///
/// On Android, also defines the direction of rolling shutter readout, which
/// is from top to bottom in the sensor's coordinate system.
final int sensorOrientation;
@override
bool operator ==(Object o) {
return o is CameraDescription &&
o.name == name &&
o.lensDirection == lensDirection;
}
@override
int get hashCode {
return hashValues(name, lensDirection);
}
@override
String toString() {
return '$runtimeType($name, $lensDirection, $sensorOrientation)';
}
}
does nothing. I have been trying to update it by hardcoding and does nothing. It is tally frustrating.

I assume that is a simple solution to this and that is to lock the CameraPreview from rotating. As when you make a picture in landscape mode it does turn out to be a normal picture in my case. it is just that preview that is getting distorted when you rotate the device. If that widget can be locked it should all work as intended. It is just a fix until there is more to go on.

I have added the following code to main.dart to lock the screen rotation
SystemChrome.setPreferredOrientations([
DeviceOrientation.portraitUp,
]);
it solves that cameraPreview from rotating and the screen looks normal.

I guess that works, but to be honest taking pictures or recording videos in portrait mode seems wrong to me, all the tvs and monitor are designed for wider media.

Well, it depends on what your camera should do. You can still rotate phone only the widgets won't turn.  I am also going to try another solution with a rotate widget. However, this is really some bug they should solve fast as this is something that one of the most important part of an app (often).

Hi @Pianisimo @keitoro
I added a way to control video and picture capture quality on botha iOS and Android
You can check the PR here:
flutter/plugins#1403
Suggestions are welcome. Don't hesitate to leave a comment to push the review process if that works for you.
I have also been working on fixing video orientation on iOS (which is pretty complicated because metadata are handle differently on different platform and different video players). I'm in the process of creating a new PR for this and will keep you updated.

I added a fix for video orientation metadata when recording a video with the camera plugin. The PR is this one: flutter/plugins#1452
I also added a fix to the video_player. The PR is here: flutter/plugins#1451
Please don't hesitate to have a look at the PRs and leave comments or suggestions to push the review process.

I also stumbled upon this issue [value of 90 when using the front facing camera, and a value of 270 when using the rear(selfie) camera]
I am required to have external camera feed as well, that's why functional camera orientation values would be extremely important to have so that video / image orientation would be correct.

Having multiple unrelated bugs in one issue makes it impossible to effectively; given that, closing this issue. (For instance, it looks like a fix landed for at least one, but the state of each piece is unclear.)
If you are still experiencing any of the problem described here, please file a new individual issue for each one, following the issue template.


Clarification regarding the number of molecular building blocks. Why they are different from JT-VAE?

Hello,
First, I really enjoyed reading the paper. Amazing work!
I have a question regarding the number of building blocks used for generating small molecules. Appendix A.3 of the paper states that there are a total of 105 unique building blocks (after accounting for different attachment points) and that they were obtained by the process suggested by the JT-VAE paper. (Jin et al. (2020)). However, in the JT-VAE paper, the total vocabulary size is $|\chi|=780$ obtained from the same ZINC dataset. My understanding is they are both the same. If that is correct, why are the number of building blocks different here? What am I missing? If they are not the same, can you please explain the difference?
Thank you so much for your help

The building blocks in two papers are not the same but quite similar. In both cases we represent molecules as junction trees - that means there are no cycles. Ours are obtained by BRICS followed by Bemis-Murcko decomposition. Finally, we had a chemist who curated our set of building blocks. In the end, I think our building blocks ended up slightly smaller and more rigid compared to JT-VAE and worked better for us in practice.
BRICS: https://www.rdkit.org/docs/source/rdkit.Chem.BRICS.html
Bemis-Murcko: https://rdkit.org/docs/source/rdkit.Chem.Scaffolds.MurckoScaffold.html

Thank you. After performing the BRICS followed by Bemis-Murcko decomposition on the 250k SMILES dataset, I get 8962 unique building blocks. Can you please comment a bit more about the curation process? How did you narrow down to a smaller list of 105 building blocks?
Also, how did you determine the attachment points (block_r in data/blocks_PDB_105.json)?
Thank you

Hi @MKorablyov , just following up on my comment earlier. It would be really helpful if you could provide those details. Thank you so much!

Met the same situation,  following the JT-VAE paper, there will be more than 700 blocks. If do BRICS followed by Bemis-Murcko decomposition, the number of unique building blocks is also 8900+, no idea about how to narrow it down. Besides, how to decide the attachment points is a challenge for me. Thanks if anyone can give any suggestion!


mypy: pglookout/cluster_monitor.py [BF-1560]

Note for future improvements:

MemberState:

This is a very loose type as no key is mandatory. This is because it is too dangerous to impose a stricter type until we have a better test coverage, as it would change some behaviour in the code (some unconventional behaviour was detected, and it may be a bug or a feature).

ObserverState:

If we want ObserverState to accept arbitrary keys, we have three choices:

Use a different type (pydantic, dataclasses, etc.)
Use a TypedDict for static keys (connection, fetch_time) and a sub-dict for dynamic keys (received from state.json).
Wait for something like allow_extra to be implemented into TypedDict (unlikely) https://github.com/python/mypy/issues/4617

And the best solution probably lies in a mix between 1 and 2.

This PR and the other ones related to type hinting will be handled in https://github.com/aiven/pglookout/pull/106.


What loss function is used for the NMT example?

❓ Questions and Help
For the NMT example, what loss function is used? I see Adam optimizer is used. But how the loss is calculated?
Can you please provide some pointers?

Cross Entropy Loss
https://github.com/graph4ai/graph4nlp/blob/1dd4a3cd831f5a991ba122f59ad7dfdd7733f683/graph4nlp/pytorch/models/graph2seq_loss.py#L6

@AlanSwift is there a way to visualize the loss function? I supposed I have to parse the following input and draw the graph?
Epoch 0: [1950 / 11234] loss: 3.798
Epoch 0: [2000 / 11234] loss: 3.852
.....
``

Is this what you would recommend?

I suggest you use the tensorboard. It can do it efficiently.


Visualisation of SLAM on benchmarking datasets

Hi Authors, Is there a way to visualize the reconstruction while the slam runs on the benchmarking dataset. I just see a command for running the splatam.py file python scripts/splatam.py configs/replica/splatam.py in case of replica dataset. Visualization here refers to the gif of camera tracking and reconstruction which is there in readme

Hi @darshit-desai ,
Currently we've provided support for visualization only after the slam is completed. This is through the viz_scripts/ files, and have instructions in the Readme.
However, we do not yet have support for viz while the demo optimization is happening. That is currently in the works.
See https://github.com/spla-tam/SplaTAM/issues/8#issuecomment-1845351121

Closing this for now since we have this as TODO. Feel free to reopen if something is unanswered.


feat: update gdscirpt cmd by using 0.8 api

using 0.8 api in gdscript cmd .
@RaafatTurki  can you test this PR.
Fix #2171

This has to be one of the fastest PRs, It works just as before!

Thanks for test :)

This does not work for me on windows.
[START][2022-10-05 15:03:42] LSP logging initiated
[WARN][2022-10-05 15:03:42] .../lua\vim\lsp.lua:1072	"server_request: no handler found for"	"workspace/diagnostic/refresh"
[WARN][2022-10-05 15:03:42] .../lua\vim\lsp.lua:1072	"server_request: no handler found for"	"workspace/diagnostic/refresh"

check the log . looks like there no handler of request method of workspace/diagnostic/refresh . this pr just change the cmd  field. does this relate?

localhost seems to cause issues but replacing it with <IP_ADDRESS> seems to fix one of the errors.

@glepnir yeah i have no idea why, i get an error saying the IP is incorrect but when i replace it no issue at all. Now im dealing with an issue where i can see in godot a connection is made but thats it nothing else is working no error messages  or auto complete.
bellow was the example given.
  vim.lsp.start {
    name = "godot",
    cmd = vim.lsp.rpc.connect("<IP_ADDRESS>", 6008), -- Port must match your Language server settings within Godot
    root_dir = vim.fs.dirname(vim.fs.find({ "project.godot" }, { upward = true })[1]),
  }

I know nothing about gdscript . but if change to 127 can works well for anyone .  change it :)

I have the exact same behaviour as @A-Lamia when using vim.lsp.rpc.connect

I have the exact same issue, and I too was only able to fix it with ncat. I tried using localhost, and <IP_ADDRESS> with vim.lsp.rpc.connect but neither worked. Only using ncat works.

@A-Lamia Where you able to make it work with vim.lsp.rpc.connect?

@DasGandlaf I gave up shortly after this post and stuck with Ncat, if it aint broke don't fix it. I don't even know if this LSP config works for anyone or the majority.

Ah, ok I see. I wasn't able to make it work either :/


regex changes, cli cleanup.

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   94.07%   94.07%
=======================================
  Files           7        7
  Lines         152      152
=======================================
  Hits          143      143
  Misses          9        9

Impacted Files
Coverage Δ

ouroboros/__init__.py
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50fb321...b59b830. Read the comment docs.


Added FAQ

Added FAQ for tickets 48455, 48457 and 48608
Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore
[x] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


Prepare for Maven publishing

This PR modifies our build to prepare for Maven release publishing.

Fix duplicate license in generated POM.
Use spark-avro 2.0.1, which is available on Maven Central.
Add a Scala 2.11 build to the to Travis test matrix.
Publish package after pushing.

Current coverage is 94.95%

Merging #77 into master will not affect coverage as of 9de440d

@@            master     #77   diff @@
======================================
  Files           11      11
  Stmts          436     436
  Branches       100     100
  Methods          0       0
======================================
  Hit            414     414
  Partial          0       0
  Missed          22      22

Review entire Coverage Diff as of 9de440d

Powered by Codecov. Updated on successful CI builds.

LGTM


Use StorePrefs to prevent YouTube update to incompatible version

StorePrefs is a new module by @stirante which prevents apps from auto-updating and warns te user on manually updating if the new version of an app is incompatible with an enabled Xposed module. It seems pretty straightforward to implement and should require nearly no effort to maintain once implemented.

Why not ;)

I'm closing this since StorePrefs is dead and the new hook update method makes it pretty much unnecessary anyways. Thanks for your continued efforts jeeping this awesome module alive :)


Better logging management

Having ProtocolParameters delivered to your terminal on each Contract run is annoying.
We should find a way to collect Contract logs and show them only in case the test fails
Blocked by https://github.com/Plutonomicon/cardano-transaction-lib/issues/730

I agree, it is really annoying when running the tests


API for enabling flushing after log

RDKTV-11982 : enableLogsFlushing and getLogsFlushingEnabled fails
Reason for change: defining enableLogsFlushing and getLogsFlushingEnabled.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: mateusz-hobgarski-red:x: nsahu910You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @anand-ky,
can you please review this.

@binuinbaraj - Pls review.
@nsahu910 - Pls sign Contributor License Agreement.

hi @anand-ky
i have signed Contributor License Agreement

@Anand Kandasamy  I reviewed and the changes look good.
On Wednesday, 1 December 2021, 06:26:33 AM GMT-5, Anand Kandasamy @.***> wrote:
@binuinbaraj - Pls review.
@nsahu910 - Pls sign Contributor License Agreement.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.


ns-render出现RuntimeError: stack expects a non-empty TensorList

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Hi thanks for submitting the issue! Can you attach a screenshot of your error message and how to reproduce it please?

Have you solved this problem?

camera_path可能是空的，在render那里拖下相机设置几个key frame似乎就能出视频了，但是我也不太懂怎么让它自己转一圈render，等作者解答下

确实是这个原因。另外可以尝试不同的渲染方式，除了指定相机路径外，还有interpolation等方式
---- 回复的原邮件 ----
| 发件人 | @.> |
| 日期 | 2024年05月20日 20:55 |
| 收件人 | @.> |
| 抄送至 | Tao<EMAIL_ADDRESS>|
| 主题 | Re: [nerfstudio-project/nerfstudio] ns-render出现RuntimeError: stack expects a non-empty TensorList (Issue #3087) |
camera_path可能是空的，在render那里拖下相机设置几个key frame似乎就能出视频了，但是我也不太懂怎么让它自己转一圈render，等作者解答下
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

camera_path may be empty, dragging the camera down in the render and setting a few key frames seems to produce the video, but I don't know how to make it rotate around on its own, waiting for the author to answer

@Aru321 did you do that in the viewer after the training is done? If yes, is it possible without the viewer? Could you elaborate on how you drag the camera down and set key frames?


Public-key based identity type

getToken depends on the Identity type which is tricky for a Metamask example.
Metamask will only grant you access to a pubkey and a signing method. Pubkey access looks convoluted a bit, but possible.
It would be nice possibly to create a static generator that was something along the lines of,
Identity.from(pubKey, (challenge: string):Promise<UInt8Array>)

Such that we could have private key lacking Identities that would work for all the existing examples.
We should double check what the response type is from web3.personal.sign() too, it might need an explanation to support the required response there.

It should be pretty easy to wrap something like Metamask into a simple class like our libp2pcryptoidentity. However, the above suggestion is pretty nice. We could provide examples for various identity providers.

Can we consider this one "done" @andrewxhill with the existing examples repo?


Correct colored logging

Short Description:
Previous colored logging did not use the python logging mechanism, so it ignored the debug configuration for event_handler logs. Also some log entries are added with the previous implementation of the colored logs.
Fixes (provide links to github issues if you can):

Debug configuration honored with colored logging
No modifications or additions to log messages

Todo

Create a custom formatter to prettify the log output
Make the log messages more consistent

Can you add magenta? And actual white? Not sure if 'white':  '\033[0m' is the regular output color vs. the normal console "white."
'magenta':   '\033[95m',
'white':   '\033[97m',

AWESOME WORK! This is how the coloured log had to be since the beginning. 👏
Is this ready to merge? Did you test it?

I have tested it as much as I could. But nothing really specials is happening. Only some formatting characters are added to the formatted messages. I have tested it on Linux/macOS, but I am not able to test it on Windows. It should also work there though!

👍

I have merged your edits and tested on a Windows platform. I am getting this error when run:

2016-08-11 14:08:12,704 [       cli] [INFO] PokemonGO Bot v1.0
2016-08-11 14:08:12,714 [       cli] [INFO] Configuration initialized
Traceback (most recent call last):
File "pokecli.py", line 530, in
main()
File "pokecli.py", line 138, in main
report_summary(bot)
File "pokecli.py", line 147, in report_summary
metrics.capture_stats()
File "C:\Program Files\Git\Pgobot\pokemongo_bot\metrics.py", line 81, in capture_stats
request = self.bot.api.create_request()
AttributeError: 'PokemonGoBot' object has no attribute 'api'

source bin/activate


Uncaught SyntaxError: The requested module '/@fs/D:/vite-react/src/interface/list.ts' does not provide an export named 'default'

Describe the bug

When I introduce A.js into B.js, I will report an error:
Uncaught SyntaxError: The requested module '/@fs/D:/vite-react/src/interface/list.ts' does not provide an export named 'default'
Reproduction

a.js
export default interface list{}

b.js
import list form 'a.js'
export {list}

System Info
vite version: 2
Operating System: win 64
Node version: v12.14.1

This is my solution
a.js
export default interface list {}

b.js
import {default as list } from 'a.js'

Simialr with https://github.com/vitejs/vite/issues/731


Stripchat : No active streams found

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I remove or skip any mandatory* field

Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2023.01.06 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
Europe
Provide a description that is worded well enough to be understood
I have not been able to download anything from Stripchat since early November, despite updating Downloader this week.
ERROR: [Stripchat] LeilaWhitez: No active streams found
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
ERROR: [Stripchat] Eleanesa: No video formats found!; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp –U

ERROR: [Stripchat] LeilaWhitez: No active streams found

Duplicate of #5963
#5985 will fix this

Duplicate of #5963
#5985 will fix this

Thanks. It is frustrating hasn't worked for some time.


Ghostunnel Performance Benchmark

Hello There,
This is an informational/clarification question rather than an issue! I have been using Ghostunnel as a TLS proxy for Redis backend and noticed that its adding 2X latency ( direct GET takes about 0.25 millisecond but through TLS proxy it takes about 0.5millisecond with the steady load of 2K request per second ) , so i wonder if you have ever done any benchmarking on additional TLS overhead that TLS proxy adds and willing to share?
Thanks in advance
Satheesha Gowda

and probably if there are any knobs in ghostunnel that we can tune to get better performance under heavy load?

That's about in line with what we previously observed/tested:
https://github.com/square/ghostunnel/issues/96

Thank you @csstaub , I am seeing latency getting worst with 80K RPS through ghostunnel (no latency observed if hit Redis directly), so could you please suggest if there are  any knobs  that we can tune to get better performance under heavy load?

You can try --enabled-ciphers=CHACHA,AES and --enabled-ciphers=AES,CHACHA  (alternate orders means switching the preferred order.  Or just use one instead of both to be sure you're using that). That lets you to see the difference between ChaCha and AES-GCM cipher suites.  Depending on your exact CPU models etc, there may be some differences.

Make sure you're using long-lived connections. Connection setup/teardown is expensive due to the TLS handshake. There will always be some performance hit though, after all, you're adding encryption on top of your connection. That will always require extra computation. Plus, data needs to be copied through an additional context switch (kernel -> proxy -> kernel -> redis) since it's a user-space proxy.
Another thing you can try on top of what @mcpherrinm said is to run multiple parallel copies of ghostunnel at the same time (they all bind with SO_REUSEPORT), the kernel will load-balance between both copies.

Thanks a lot @mcpherrinm and @csstaub ,  specifically am impressed with running  multiple parallel copies of ghostunnel to load-balance high load traffic, its very useful to ensure high availability of the service!


Updated MIB_IPINTERFACE_ROW SupportsRouterDiscovery description

support neighbor discovery => support router discovery

@alexbereznikov : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Suggestion: Add Impact on SEO to gotchas in README.md

Currently, probably the biggest gotcha (in many cases) to using Picturefill v2+ is that it renders all images unindexible by Google. For many sites this may have serious SEO implications, so I think this should be clearly stated in the README. This same issue obviously also means anybody with JavaScript disabled will see no images at all, so again, I think this deserves adding.

Hey there @Undistraction,
Thanks for raising this issue. We do mention in the main docs that browsers that for whatever reason can't render JavaScript and also don't support srcset will fall back to the alt text (as this stands globally, that's about 1.1% of 40%.
The main docs are where the meat of the information about responsive images and Picturefill are, and the short Gotchas section in the README is largely intended to stop common queries being raised as bugs on the Picturefill repository (e.g. the Firefox 38-40 srcset bug resulted in about 10 Picturefill bugs being raised in a short space of time, despite this having nothing to do with Picturefill).
You do raise a good point, and it might well deserve an addition. If you have any more information or research about potential search engine optimisation implications of using responsive images, we'd love to see this in the docs. If you have some time, could you perhaps create a PR?

using Picturefill v2+ is that it renders all images unindexible by Google
Simply not true. You can check this yourself with google webmaster tools (Try fetch/render as google).

picturefilled images are indexed by google. There is no negative impact.

@aFarkas Interesting. The last time I checked nothing other than images referenced in the src attribute were picked up, and there is at least one issue here with the same findings: #274 If this is the case - that srcset images are being indexed by Google, this is great news, and something you (Picturefill) should be making a big noise about as this has probably been keeping people from using the latest version(s).

@jegtnes Well hopefully this is now moot if Google is indexing srcset. In fact if this is true (I can't verify this now as I'm using v1 for everything I have in production), this is fantastic news.

@aFarkas It would definitely be worth adding your findings to the documentation.

@Undistraction Ace. 🎉 If you do run into any issues once you migrate to v2/3, let us know. For now, I'll close this.

@aFarkas @jegtnes Unfortunately my tests show that this is not correct.
I set up a very simple test here with two images:

Using Fetch As Google this was my result:

@Undistraction
I don't see picturefill included.

@aFarkas But surely the Google crawler won't run picturefill?

google supports some JS. picturefill is supported.

@aFarkas  Apologies. You are correct. Strange that Google gets the visitor render wrong. And stranger still that it doesn't pick up the srcset image without Picturefill being included.

I think google uses an old webkit headless browser to render the page and get its content. therefore there is no srcset support yet, but picturefill will polyfill googlebot the same way, as it polyfills other browsers.

@aFarkas Thanks for the explanation. I'm very surprised, but obviously in a good way. I'd echo what I said earlier - this would be worth adding to the docs.

Thanks for confirming this. Personally, I don't think explaining that the Google crawler executes basic javaScript is within scope for the docs.

explaining that the Google crawler executes basic javaScript is within scope for the docs.

@baloneysandwiches Given that SEO is such an important consideration of any site, I don't agree.
Anyone testing Google's ability to index the srcset attribute using Webmaster tools would conclude that it doesn't index images defined there. (I couldn't find any information about this at all online) Picturefill is altering this behaviour. This is a positive side-effect, but it is a side-effect regardless, so it should be documented. You could argue that it is a deliberate feature of Picturefill, but again, if this is the case, it should be documented.
Apart from anything else this is a big win for Picturefill and documenting it will only further encourage people to use it.

I second including this in the documentation.  A general statement that spiders can still index images without the SRC attribute would be a big win to help encourage use.
Most of the information out there implies Google will not index images using the srcset method and without this thread I would not have moved forward implementing it for myself.

I've been looking into this issue lately myself, and for a client's website that has been online for 6 months, with srcset AND picturefill, not a single image could be found in Google Images.
For other clients I have fixed this issue by including both a src and srcset attribute. Google indexed these images a lot faster.

@Sylvareth This will mean the image declared in the src attribute will always be downloaded regardless of the viewport width, meaning clients will download two versions of the same image.
Have you tried viewing the crawling the site as Google from Webmaster tools. Do the srcset images show?

I have just checked with Google Search Console and the srcset-only images are not rendered in the preview. Only when I add a src-attribute, it renders them. I am using Picturefill v.2.3.1.
Also, about the double download. I have checked this across multiple browsers and did not come across any double requests, at least not in any desktop browser.

@Sylvareth
Pretty sure you are testing wrong. I have tested it myself with fetch as google as also have sites using it. Here is also an article in german, that tested it and concluded that images are indexed.
www.stefan-weiss.net/responsive-image-seo.htm


Allow form style HTTP request bodies

Some APIs want POST bodies as form style, base64 encoded strings, i.e. key1=value1&key2=value2 instead of JSON. Maybe we should have a way to convert a [String: AnyObject] dictionary into form-style bodies?

I think my comments in #49 apply here too, in case that's of any help in implementing this.

Thanks @paulyoung !
Work is in progress here https://github.com/thoughtbot/Swish/tree/sr-form-style-payloads

#64


Build .c files with C compiler (DEF-3084)

(LINK REMOVED)Today, we compile .c files with clang++, which enables other code checks.
EDIT: Also support .m files

Box2c was released. But it is C library. And defold can't build it :(
https://x.com/erin_catto/status/1822887953292816678
I think as a workaround it can be build and added as library? but for me it will be easy to keep code and build for every platform with defold extender.


Support TimestampWithTimezone in day_of_week(), day_of_year(), and year_of_week() Presto functions

Differential Revision: D36291921

Thanks for adding these functions.
Please update the datetime.rst documentation file also.

Updated the document. Thank you!


Exception not caught with dynamic

The first test passes.
The second test fails at the Assert.Throws line saying the exception was null.
(Look carefully, the only difference in the code is the use of the dynamic keyword.
[Test]
public void ExceptionIsThrownTaskValidator()
{
    var cmd = new ValidatorAsyncTaskCommand();
    var command = NunitSetup.ValidatorContainer.Resolve<IAsyncCommandHandler<ValidatorAsyncTaskCommand>>();
    Assert.Throws<FluentValidationException>(() => AsyncContext.Run(() => command.HandleAsync(cmd)));
    Assert.That(cmd.HandleFired, Is.False);
}

[Test]
public void ExceptionIsThrownTaskValidatorDynamic()
{
    var cmd = new ValidatorAsyncTaskCommand();
    dynamic command = NunitSetup.ValidatorContainer.Resolve<IAsyncCommandHandler<ValidatorAsyncTaskCommand>>();
    Assert.Throws<FluentValidationException>(() => AsyncContext.Run(() => command.HandleAsync(cmd)));
    Assert.That(cmd.HandleFired, Is.False);
}

The HandleAsync call looks like this (their is a decorator in place throwing the exception):
public Task HandleAsync(ValidatorAsyncTaskCommand command)
{
    command.HandleFired = true;
    return Task.CompletedTask;
}

If the HandleAsync call uses Task<T> instead of `Task`` then it works as expected!!!
If the command handler returns Task<T> then everything works as expected, regardless of if dynamic type is used.
If the command handler returns Task then the exception is eaten up if a dynamic type is used.
Further complicating the scenario, is the use of CQRS and decorators with autofac.  If there is not a decorator in place (so the resolve results in the exact handler, it works even with dynamic.  If the resolve results in a decorator that throws (or the original handle throws) this it fails.
Obviously the dynamic cast is not necessary in this contrived example, but in my real scenario it is.
I am using version 3.01, but have tried it on 4.01.   (We never upgraded to 4 because of the zombie like nature of the build dependency that 4.01 takes on.   Looking forward to the 5 version that cleans all this up)

This is almost certainly not a bug in AsyncEx, but I'll take a look at it. Can you post a minimal repro? Does the decorator return a faulted task, or does it throw directly?
Regarding the versions, I went through pretty good lengths to avoid Microsoft.Bcl.Build in 3.x, but it turned out that caused a subtle bug (#13), so 4.x had to remove all that work and just use the build package everywhere (unfortunately). 5.x is currently in prerelease mainly because it's still missing a few types; what is there is quite stable.

I am going to create a repro so you can see this.  Thanks for comments.

I dont really know anything about Bcl.Build other than it is a zombie virus package and infects everything, so I avoid it!

Feel free to reopen if you have a repro.


[Bug]: 2 Aquarea Heatpumps 1 with HeishaMon and 1 wih SmartCloud

The problem
Hello, I have 2 Aquarea Heat Pumps. I had both integrated with 2 Aquarea Smart Cloud Accounts. Now, in one of them, I had installed Heisamon Large and integrated it with the HeishaMon Integration. This Heat Pump works very well. But I`m not able to integrate the other Heat Pump with the Smart Cloud Account.
When I try to add a new Aquarea Smart Cloud integration, it only shows me the Heishamon (This has the same symbol with the "A")
What can I do to get both heat pumps integrated into HomeAssistant?
Thank you.
What version of Home Assistant Core are you running?
core-2024.11.3
What type of installation are you running?
Home Assistant OS
What version of the integration are you running?
actual
Device description
2 Aquarea Heat Pumps K 7kWh (one of them wih HeishaMon Integration)
1 Zone
Heat only
no DHW
Is the integration loading?
No
Is the adapter able to connect to the Aquarea Smart Cloud with a stable internet connection?
No
Are you able to perform the action you're trying to with the Aquarea Smart Cloud Site/App?
Yes
Area of the issue
Hello, I have 2 Aquarea Heat Pumps. I had both integrated with 2 Aquarea Smart Cloud Accounts. Now, in one of them, I had installed Heisamon Large and integrated it with the HeishaMon Integration. This Heat Pump works very well. But I`m not able to integrate the other Heat Pump with the Smart Cloud Account.
When I try to add a new Aquarea Smart Cloud integration, it only shows me the Heishamon (This has the same symbol with the "A")
What can I do to get both heat pumps integrated into HomeAssistant?
Thank you.
Anything in the logs?
No response
Additional information
No response

Hello, it`s running.
The following link solved it :-)
https://github.com/cjaliaga/home-assistant-aquarea/issues/115#issuecomment-2239833967
Thank you very much.


OpenACC for non-orthogonal lattice

How to build:

module load hpc_sdk/20.9
mkdir build
cd build
python3 ../configure.py --enable-mpi --arch=pgi-openacc
make -j

Can one of the admins verify this patch?

Can one of the admins verify this patch?

add to whitelist

add to whitelist

add to whitelist