Type check with mypy in CI

This won't catch any errors in ctre/rev/wpilib usage yet unfortunately, but it's something at least.

This picks up an error in the shoot controller, so this will need to wait for #47.

In the meantime if I can get reviews for relevant parts of this…

This has obviously changed a fair bit since the last review, so if I could get another pair of eyes on this...

I'm going to close this PR and open a new one, to preserve history.


A property getting the value of another property of the object in the Oneof array

{
"title":"xyz",
"type":"object",
"properties":{
"id":{
"type":"string"
},
"friend":{
"type":"string"
},
"Attributes":{
"type":"object",
"oneOf":[
{
"type":"object",
"title":"abc",
"properties":{
"name":{
"type":"string",
"default":"qrs"
},
"age":{
"type":"number"
}
}
}
]
}
}
}
In the above schema I want that the "friend" field should have the data from the "name" field in the array Oneof which is the drop down menu and can have many objects with common property "name".
How can this be done in this schema?

See solved issue https://github.com/jdorn/json-editor/issues/305


Jupyter notebook

Jupyter notebook filtering and processing.

Would it be possible to delete only the outputs that exceed a certain length threshold? For example, only those shorter than an mnist image.

By the way, when I try to run process_source_code.py I'm getting the error FileNotFoundError: Dataset 'bigcode/the-stack-dedup' doesn't exist on the Hub., which is really bizarre. Is this just my machine acting weird?

Re: outputs yes, good idea
For the FileNotFoundError, I had to login to huggingface on the command line, since the stack has a layer of security (e.g., we need to accept the terms of use to get access to it, which is linked to our huggingface account)

Regarding the FileNotFoundError error, my Julia filter PR adds support for an HUGGING_FACE_TOKEN env variable that allows one to provide a HF authentification token.

@zhangir-azerbayev I switched it to only remove outputs when they include a base64 png string or an exception traceback. Now we're at ~300M tokens.


Update my task component

Figma Link

[x] Stage-1: Ticket for non-debounce slider
[ ] Stage-2: Ticket for debounce implementation

I will take it from here 😁

Progress Update - I have a working slider on the screen. Next steps include :

stylizing the slider
removing the button and drop down menu used for updating the tasks and adding their functionality (API calls) to the slider.

Stage-1 is fixed by #166

Stage-1 is fixed by #166


Terminating app due to uncaught exception 'NativeScript encountered a fatal error: TypeError: this.takePhoto is not a function. (In 'this.takePhoto()', 'this.takePhoto' is undefined)

This error occurred while trying to take the photo and ends the application only on iOS:
Terminating app due to uncaught exception 'NativeScript encountered a fatal error: TypeError: this.takePhoto is not a function. (In 'this.takePhoto()', 'this.takePhoto' is undefined)

Can you share your app code? I've not seen this before in the demo project so I'm curious what's changed or what you might be executing that throws this. Thanks 👍

Hi, same problem here. When looking at the source code there is a call to this.takePhoto() which seems to point nowhere https://github.com/nstudio/nativescript-camera-plus/blob/bcfea7eedf5720b36f6640beff3dd5f7cefdaa8d/src/camera-plus.ios.ts#L341

I have the same problem....  nativescript-camera-plus has dependency from https://github.com/NathanWalker/SwiftyCam/tree/feature/swift-4.2   and that branch is out of date and definitely just feature branch.

Gotcha. I think Nathan forked it originally to add some things for the plugin. Maybe syncing back up with the master would solve this. We'll try to look at this soon. Or if anyone wants to help just let us know 😊

I am running into the same issue.

We had to change back to 2.0.2 in the package.json and it's working again now.

Any solution guys?

Problem solved in this new version 2.1.1

I think it may be related to the issue I just created #123


App Center API release

Describe the solution you'd like
Hi, app center API is still in preview according to this url  https://openapi.appcenter.ms
When do you plan to release a production ready API ?

Hard to tell, but we do have plans for a cleaner API surface and published SDK clients. Will more than likely circle back to this after we finishing shutting down HockeyApp so the whole team can be focused on one service. We'll keep checking in on this feature to see if this is something people want sooner in the mean time.

+1

+1

+1

PLEASE, use reactions...


crash with ios 16.4 when build with xcode 14.3

occur crash with in devices have ios version: 16.4, when i build the app with xcode 14.3 , but when i build app with xcode 14.2 the crash disappear
the crash:
__67-[IGListAdapterUpdater performBatchUpdatesWithCollectionViewBlock:]_block_invoke.9
iglistkit version = 4.0.0

Hi @DrWaleedNour! Sorry to hear you're experiencing a crash with IGListKit. Is there an error message that was visible in that crash?
We're working hard towards getting version 5.0 ready. Once I've merged my latest PRs to the codebase, I'll ask you to try the latest copy of IGListKit from the main branch and see if you're still having that issue.

Fatal Exception: NSInternalInconsistencyException
0  CoreFoundation                 0x119180 __exceptionPreprocess
1  libobjc.A.dylib                0x59f8 objc_exception_throw
2  CoreFoundation                 0x3288c +[_CFXNotificationTokenRegistration keyCallbacks]
3  Foundation                     0x8ab38 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:]
4  UIKitCore                      0x1c6324 -[UICollectionView _endItemAnimationsWithInvalidationContext:tentativelyForReordering:animator:]
5  UIKitCore                      0x1cd1b8 -[UICollectionView _endUpdatesWithInvalidationContext:tentativelyForReordering:animator:]
6  UIKitCore                      0x1cd4ec -[UICollectionView _performBatchUpdates:completion:invalidationContext:tentativelyForReordering:animator:]
7  UIKitCore                      0x1cd34c -[UICollectionView _performBatchUpdates:completion:invalidationContext:tentativelyForReordering:]
8  UIKitCore                      0x1cd2d0 -[UICollectionView _performBatchUpdates:completion:invalidationContext:]
9  UIKitCore                      0x1cd20c -[UICollectionView performBatchUpdates:completion:]
10 liaqa                          0x218c8a0 __67-[IGListAdapterUpdater performBatchUpdatesWithCollectionViewBlock:]_block_invoke.9 + 250 (IGListAdapterUpdater.m:250)
11 liaqa                          0x218c0e4 -[IGListAdapterUpdater performBatchUpdatesWithCollectionViewBlock:] + 272 (IGListAdapterUpdater.m:272)
12 liaqa                          0x218d7c4 __60-[IGListAdapterUpdater _queueUpdateWithCollectionViewBlock:]_block_invoke + 434 (IGListAdapterUpdater.m:434)
13 libdispatch.dylib              0x5fa38 _dispatch_call_block_and_release
14 libdispatch.dylib              0x607d4 _dispatch_client_callout
15 libdispatch.dylib              0xe008 _dispatch_main_queue_callback_4CF$VARIANT$mp
16 CoreFoundation                 0xaab20 CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE
17 CoreFoundation                 0xa5a58 __CFRunLoopRun
18 CoreFoundation                 0xa4fb4 CFRunLoopRunSpecific
19 GraphicsServices               0xa79c GSEventRunModal
20 UIKitCore                      0x8bcc38 UIApplicationMain
21 liaqa                          0x229d0 main + 245 (AppDelegate.swift:245)
22 libdyld.dylib                  0x18e0 start

When 5.0?

Hi @DrWaleedNour! Sorry to hear you're experiencing a crash with IGListKit. Is there an error message that was visible in that crash?
We're working hard towards getting version 5.0 ready. Once I've merged my latest PRs to the codebase, I'll ask you to try the latest copy of IGListKit from the main branch and see if you're still having that issue.

any update or solution?

@baveku Soon. :)
@DrWaleedNour Did you try with the latest version from the main branch yet?

@DrWaleedNour hello! I have a question about your usage of IGListKit.  Can you take a look at your usage of performBatchAnimated and similar methods (if perhaps you're calling the equivalent method directly on your collection view), and see if you ever make a model update outside of the update block? I believe you'll need to move any model mutations you might be making into the beginning of the update block and that may fix your issue.

I believe it was "fixed" in https://github.com/Instagram/IGListKit/commit/eb9b18ada40800941e9ec96450de67481974f07c

I am experiencing the same crashes with sdk version 4.0.0 since building Xcode 14.3.1. I am happy to see that there is already a fix to catch the crashing exception.
@TimOliver @DimaVartanian
Since your are not releasing minor updates anymore and the next version 5.0.0 update is marked as upcoming for quite some time now, can you please elaborate on what's the best way to integrate this fix?

Can you give an ETA on when version 5.0.0 will be released? E.g. more like weeks or months?
Do you you consider the main branch stable and ready for production? Do you at Instagram also use the main branch directly to utilize the developments since version 4.0.0?

I believe it was "fixed" in eb9b18a

This doesn't seem to fix the actual issue. The app no longer crashes but the invalid updates end up leaving the collection view in a weird state of blank spaces and non-updating cells forever until the app is killed.

Does this issue have any resolution? I have the same exception thrown in my Xcode 15.3 build and I see that the source code has an experiment to avoid the exception, but the experiment was disabled. Referring to in eb9b18a mentioned above on July 8th 2023

Hey folks! Sorry for the delay! Version 5.0 is officially out now, so I think we can put this issue to bed. 🎉
The official final resolution for this issue is that it wasn't due to an issue in IGListKit, but it was due to an underlying change to UICollectionView by Apple. 🤯
Apple explained on the Apple Developer forums that this came about as a deliberate change in iOS 16.4. They explained that in previous versions of iOS, when an update operation was found to be inconsistent, it didn't crash, but it implicitly performed a costly reloadData call on the collection view instead. They said even in those previous cases, this was still using the collection view incorrectly and should have still been avoided. 😅
In light of this, if this error occurs via IGListKit, this means something is genuinely incorrect in the user's model logic, and it should be appropriately addressed.
The experiment in IGListKit is there to 'skip' the exception and allow the app to continue running in order to discover and capture instances of this exception occurring. This allows the app to continue executing (which may be preferable to it crashing if it was on lower priority screen), however it absolutely shouldn't be relied upon if it can be helped. If a collection view encounters this exception and the app doesn't crash, the collection view remains in an invalid state, and will start showing inconsistent UI if the user continues to interact with it.
I hope that clears everything up. Thanks again for reporting this issue! It ended up being an early warning to us at Instagram that this API change by Apple was on the horizon and was extremely valuable in our own efforts! 🙏
tl;dr: This issue started due to a deliberate choice by Apple and isn't an underlying issue in IGListKit. If you're encountering it, you need to re-examine your app's logic to ensure your model state logic is updating correctly. If you need to bypass the exception for now, you can optionally choose to disable IGListExperimentThrowOnInconsistencyException, but this isn't recommended.


Allow configuration of PATH

This enables support e.g. for homebrew installations of ansible on macOS.

Hey there,
thanks for your contribution. Much appreciated.
However, I don't think it is a good idea to implement/configure (environment) PATH settings in this context.
The System.getenv() map usually already contains the PATH variable/value.
Manually overriding the PATH in this plugin will fix the issue (one might have with Homebrew installations of ansible-lint) in the wrong place:
return GeneralCommandLine()
    .withEnvironment(System.getenv())
    .withEnvironment("PATH", settings.path)
    .withWorkDirectory(workingDirectory)
...

If your setup needs special tinkering of the PATH env then it should be fixed it in the system.
Alternatively you could also always use a dedicated two-line-shell-script to make special adjustments...
#!/bin/bash
PATH=/your/custom/path /path/to/ansible-lint

... and just run this script from the plugin.

Indeed the script would be a workaround. But then I have a custom script somewhere around, which I will forget about and at some point the setup will be broken..
What about just adding a directory to the PATH?

But then I have a custom script somewhere around, which I will forget about and at some point the setup will be broken..

Same goes for the static env-setup in the plugin's settings. :smile:
And that's why environment variables should be managed outside of this context.
I guess that this issue is also very (Homebrew-)specific.
As mentioned in the review comments: The System.getenv() map actually does contain the complete (and up to date) PATH settings.
I'm sorry... but I don't want to integrate/implement workarounds for various systems/setups (since these issues can be solved elsewhere).


[utils] base_url: URL paths can contain &.  Backport from yt-dlp Resolves #31485

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] Searched the bugtracker for similar pull requests
[x] Read adding new extractor tutorial
[x] Read youtube-dl coding conventions and adjusted the code to meet them
[x] Covered the code with tests (note that PRs without tests will be REJECTED)
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[ ] I am the original author of this code and I am willing to release it under Unlicense
[x] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.
Resolves #31485

Please fill in the description and include the magic line Resolves #31485..
Anyway, why is base_url() using regex to parse URLs when there's an actual Python library module for that?

Also, the change does have a test, so you can tick that checkbox too.

I don't know. I didn't write any of this code. I'm just trying to get it to work. "Anyway, why is base_url() using regex to parse URLs when there's an actual Python library module for that?"

Likewise. It was really a rhetorical question: the regex must have been an easy win.
Something like this makes it clearer what's being removed and what kept. It's not obvious what the right answer for (eg) https://example.com/path1/path2 should be, vs. https://example.com/path1/path2/. The url_basename() function above gives path2 for both, while the regex version of base_url() gives https://example.com/path1/, https://example.com/path1/path2/. A little specification comment would have been reassuring.
def base_url(url):
    """
        Return the URL, with its path trimmed after the rightmost /
        and without any query, params or fragment
    """
    parsed_url = compat_urlparse.urlparse(url)
    # url_basename() removes the last /
    # the regex pattern includes it?
    path = parsed_url.path.rsplit('/')[0]
    if not path.endswith('/'):
        path += '/'
    return compat_urlparse.urlunparse(parsed_url._replace(
        path=path, query='', params='', fragment='')

Of course the "right answer" is what test/test_utils.py says:
    def test_base_url(self):
        self.assertEqual(base_url('http://foo.de/'), 'http://foo.de/')
        self.assertEqual(base_url('http://foo.de/bar'), 'http://foo.de/')
        self.assertEqual(base_url('http://foo.de/bar/'), 'http://foo.de/bar/')
        self.assertEqual(base_url('http://foo.de/bar/baz'), 'http://foo.de/bar/')
        self.assertEqual(base_url('http://foo.de/bar/baz?x=z/x/c'), 'http://foo.de/bar/')

And also, RFC 3986 2.2 categorises & as a reserved character of type sub-delims:
      sub-delims  = "!" / "$" / "&" / "'" / "(" / ")"
                  / "*" / "+" / "," / ";" / "="

The principle is that a *sub*-delims character like & need only be percent-encoded if it appears in a context where it has a delimiting role. Thus in http://example.com/contains_an_&_here?param=contains_an_&_there, the here & is fine but the there & must be rendered as %26, http://example.com/contains_an_&_here?param=contains_an_%26_there:
   URI producing applications should percent-encode data octets that
   correspond to characters in the reserved set unless these characters
   are specifically allowed by the URI scheme to represent data in that
   component.  If a reserved character is found in a URI component and
   no delimiting role is known for that character, then it must be
   interpreted as representing the data octet corresponding to that
   character's encoding in US-ASCII.

In other words, base_url() should support & in the path part of a URL.

Please approve this PR, the error is affecting many systems @dirkf


Add QNU University Domain

@dovtuan Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Only map rows to ordinals once for hybrid vector queries

In the brute force code path, we currently map row ids to ordinals twice. This is expensive and can easily be reduced to once, as shown in this PR. We can also defer building the bits object until we know we need it.

Ship it!


About the InMemoryDataset

Excuse me, I want to use the CoMA dataset, contains about 20000 mesh, each has 5023 vertices.Should I use InMemoryDataset Class to read the data or just use the torch_geometric.data.Dataset.

Hi, we actually implemented the CoMA dataset as an InMemoryDataset, but dependent on your memory this may be better implemented as a normal Dataset. I recommend checking the provided dataset and see if it fits your need.


303 Add programme details confirmation component

Context
https://trello.com/c/9r0pBHJR/303-s-confirm-trainee-programme-details-component
Changes proposed in this pull request

Added a component for the programme details confirmation
Added a test and preview for this component

Guidance to review

 [S] Confirm Trainee Programme Details Component

 [S] Confirm Trainee Programme Details Component


feat(tracer): export add to pending event function

:tada: This PR is included in version 1.102.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


WebApiToSwaggerGenerator not respecting mimetypes per operation

Hi,
We are using the WebApiToSwaggerGenerator.GenerateForControllersAsync(controllerTypes) method to generate our swagger file, but it doesn't seem to respect any ProducesAttribute put on any of the rest endpoint methods.
For example we have a method defined:
[HttpGet("ds/csv")]
        [SwaggerResponse(HttpStatusCode.OK, typeof(CsvSwaggerFeatureResponse<DSRealtimeCsvEntry>))]
        [SwaggerResponse(HttpStatusCode.Forbidden, typeof(string))]
        [SwaggerTag("Traffic Data Service")]
        [Description("Get Detector Site Real-time Measures")]
        [LongDescription("Returns the realtime traffic measures for detector sites.")]
        [Produces("text/csv")]
        public async Task<IActionResult> GetDsRealtime()`

I would expect the generated swagger should be something like:
"paths": {
    "/traffic/v1/ds/csv": {
      "get": {
        "tags": [
          "Traffic Data Service"
        ],
        "summary": "Get Detector Site Real-time Measures",
        "produces": [
            "text/csv"
        ],
        "operationId": "Traffic_GetDsRealtime",`

but it is missing the produces section on the operation.
From what I can tell this feature is implemented in some of the other Generator classes. Would it be possible to also implement it on WebApiToSwaggerGenerator. Or are we forced to 'upgrade' to one of the other generators?
Thanks

noticed the same behavior, the only mime types which worked for me were "application/json", "text/json" and "text/plain".

WebApiToSwaggerGenerator and AspNetCoreToSwaggerGenerator are different generators - i suspect that WebApiToSwaggerGenerator might not correctly support this - because it's deprecated I don't have the time to look into this...
Do we also have the problem with the AspNetCoreToSwaggerGenerator?

Well how do I specify the generator?
I thought since I'm on a AspNetCore Project nswag defaults to the AspNetCoreToSwaggerGenerator.

@darman96 how did you integrate NSwag in your Startup.cs?

in ConfigureContainer() i have this:
services.AddSwaggerDocument(                 settings =>                 {                     settings.DocumentName = "swagger";                 });
and in my Configure():
`app.UseSwagger(
settings =>
{
settings.DocumentName = "swagger";
settings.Path = "/swagger/v1/swagger.json";
});
app.UseSwaggerUi3(
settings =>
{
settings.Path = "/swagger";
settings.DocumentPath = "/swagger/v1/swagger.json";
});`

Yes, this is using the AspNetCoreToSwaggerGenerator... otherwise you'd see obsolete warnings... please create another issue if its AspNetCoreToSwaggerGenerator related

Are you sure? Because when I hover over app.UseSwaggerUi3() I get this tool tip:

That's still a legacy leftover and will be removed as soon as the WebApiToSwaggerGenerator is completely removed from NSwag.AspNetCore (currently there for legacy users) in v13

Thanks for your quick response Rico, we will look into upgrading to a different generator.


feat: Add Solid support

I have added support for SolidJS but it is not working completely. For some reason the height on the iframe is not being correctly set resulting the content being cut off.
If possible, could you help me resolve this? Once this is done I'll add demo for Solid and modify this prop
from term="Welcome to @giscus/react component!" to term="Welcome to @giscus/solid component!"

Hey, thank you very much!
I dug into this and it seems Solid passes props that have undefined values to the web component instead of skipping them. For example, if the id value isn't set, the web component will have id="undefined" instead of not having the id. The resizing issue arises because when the host value is empty, undefined gets set to the web component's this.host property, so the following check always fails:
https://github.com/giscus/giscus-component/blob/06a19f20402b5716d8397d94526b6158d65077d0/web/src/giscus.ts#L163-L164
and the message events containing the resize values end up not getting processed.
I fixed it by removing the undefined values before passing it to the web component, and it seems to work. I've amended your commit and force-pushed the fix to your branch, so feel free to continue working on it. Though, in the future, I'd recommend creating a separate branch on your fork, instead of working on the main branch directly.

Thanks for helping me with the fix as well as refactoring the code. I have now modified the term and pushed my branch. I'll add the demo once the package is updated on npm. Let me know if I should do any further modifications apart from the demo.
And yes, you're right I'll create a separate branch moving forward.

Do I need to do anything else @laymonage?

Hey @flashblaze, it's looking good to me, but for some reason the categoryId and repoId values are not passed to the web component, so I haven't merged this PR. I haven't found what causes this issue and I'm still investigating.

Thanks @flashblaze! It's up on NPM, first release is v2.2.6. It seems Solid, like Svelte, always re-renders the web component when the props change though, instead of just changing the attributes. This prevents the live config update (without rerendering) feature from working.

Oh I wasn't aware of this. So you mean HMR won't work on importing this component and changing props right? And thanks a lot for merging my PR though you had to modify a bunch of stuff as well 😅


Get the check-in count from the Batch Registry contract

Goal
There is a "To Be implemented" string in packages/nextjs/app/page.tsx that should show the number of builders that have checked in to the contract.
We want to show the real count (reading from the BatchRegistry contract)
For more info about the contract: https://github.com/BuidlGuidl/batch5.buidlguidl.com/issues/9

Can I pick this up?

can help you out @ishaan812

Hey @cleanerzkp seems like a super easy task actually. just using the read contract scaffold hook and use it to show the variable. Just a couple lines of code.
`import { useScaffoldReadContract } from "~~/hooks/scaffold-eth/useScaffoldReadContract";
const Home: NextPage = () => {
const { data: checkedInCount, isFetched: checkedInCountFetched } = useScaffoldReadContract({
contractName: "BatchRegistry",
functionName: "checkedInCounter",
});
`
like this I think.

Closed by #19


Data getting Truncated when using BigDecimal datatype

Steps to re-produce

Ingest the given sample file : BigDecimal.json
Data Truncation for the numbers as mentioned in the image attached

Adding more on to this.. for a decimal numbers, it supports only 16 digits excluding decimal point and truncates the digits more than that

I feel this is related to kafka decoder.
@snleee @swaminathanmanish


[SPARK-6623][SQL] Alias DataFrame.na.drop and DataFrame.na.fill in Python.

To maintain consistency with the Scala API.

Test build #29449 has started for   PR 5284 at commit 6618118.

Test build #29450 has started for   PR 5284 at commit 19f46b7.

Jenkins, retest this please.

Test build #29459 has started for   PR 5284 at commit 19f46b7.

Test build #29449 has finished for   PR 5284 at commit 6618118.

This patch passes all tests.

This patch merges cleanly.

This patch adds the following public classes (experimental):

class DataFrameNaFunctions(object):

This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29449/
Test PASSed.

Test build #29450 has finished for   PR 5284 at commit 19f46b7.

This patch fails Spark unit tests.

This patch merges cleanly.

This patch adds no public classes.

This patch adds the following new dependencies:

activation-1.1.jar
aopalliance-1.0.jar
avro-1.7.7.jar
breeze-macros_2.10-0.11.2.jar
breeze_2.10-0.11.2.jar
commons-cli-1.2.jar
commons-codec-1.10.jar
commons-compress-1.4.1.jar
commons-io-2.1.jar
commons-lang-2.5.jar
gmbal-api-only-3.0.0-b023.jar
grizzly-framework-2.1.2.jar
grizzly-http-2.1.2.jar
grizzly-http-server-2.1.2.jar
grizzly-http-servlet-2.1.2.jar
grizzly-rcm-2.1.2.jar
guice-3.0.jar
hadoop-annotations-2.2.0.jar
hadoop-auth-2.2.0.jar
hadoop-client-2.2.0.jar
hadoop-common-2.2.0.jar
hadoop-hdfs-2.2.0.jar
hadoop-mapreduce-client-app-2.2.0.jar
hadoop-mapreduce-client-common-2.2.0.jar
hadoop-mapreduce-client-core-2.2.0.jar
hadoop-mapreduce-client-jobclient-2.2.0.jar
hadoop-mapreduce-client-shuffle-2.2.0.jar
hadoop-yarn-api-2.2.0.jar
hadoop-yarn-client-2.2.0.jar
hadoop-yarn-common-2.2.0.jar
hadoop-yarn-server-common-2.2.0.jar
jackson-annotations-2.4.0.jar
jackson-core-2.4.4.jar
jackson-databind-2.4.4.jar
jackson-jaxrs-1.8.8.jar
jackson-module-scala_2.10-2.4.4.jar
jackson-xc-1.8.8.jar
javax.inject-1.jar
javax.servlet-3.1.jar
javax.servlet-api-3.0.1.jar
jaxb-api-2.2.2.jar
jaxb-impl-2.2.3-1.jar
jersey-client-1.9.jar
jersey-core-1.9.jar
jersey-grizzly2-1.9.jar
jersey-guice-1.9.jar
jersey-json-1.9.jar
jersey-server-1.9.jar
jersey-test-framework-core-1.9.jar
jersey-test-framework-grizzly2-1.9.jar
jettison-1.1.jar
jetty-util-6.1.26.jar
management-api-3.0.0-b012.jar
protobuf-java-2.4.1.jar
spark-bagel_2.10-1.4.0-SNAPSHOT.jar
spark-catalyst_2.10-1.4.0-SNAPSHOT.jar
spark-core_2.10-1.4.0-SNAPSHOT.jar
spark-graphx_2.10-1.4.0-SNAPSHOT.jar
spark-launcher_2.10-1.4.0-SNAPSHOT.jar
spark-mllib_2.10-1.4.0-SNAPSHOT.jar
spark-network-common_2.10-1.4.0-SNAPSHOT.jar
spark-network-shuffle_2.10-1.4.0-SNAPSHOT.jar
spark-repl_2.10-1.4.0-SNAPSHOT.jar
spark-sql_2.10-1.4.0-SNAPSHOT.jar
spark-streaming_2.10-1.4.0-SNAPSHOT.jar
stax-api-1.0.1.jar
xz-1.0.jar

This patch removes the following dependencies:

breeze-macros_2.10-0.3.1.jar
breeze_2.10-0.10.jar
commons-codec-1.5.jar
commons-el-1.0.jar
commons-io-2.4.jar
commons-lang-2.4.jar
hadoop-client-1.0.4.jar
hadoop-core-1.0.4.jar
hsqldb-<IP_ADDRESS>.jar
jackson-annotations-2.3.0.jar
jackson-core-2.3.0.jar
jackson-databind-2.3.0.jar
jblas-1.2.3.jar
spark-bagel_2.10-1.3.0-SNAPSHOT.jar
spark-catalyst_2.10-1.3.0-SNAPSHOT.jar
spark-core_2.10-1.3.0-SNAPSHOT.jar
spark-graphx_2.10-1.3.0-SNAPSHOT.jar
spark-mllib_2.10-1.3.0-SNAPSHOT.jar
spark-network-common_2.10-1.3.0-SNAPSHOT.jar
spark-network-shuffle_2.10-1.3.0-SNAPSHOT.jar
spark-repl_2.10-1.3.0-SNAPSHOT.jar
spark-sql_2.10-1.3.0-SNAPSHOT.jar
spark-streaming_2.10-1.3.0-SNAPSHOT.jar

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29450/
Test FAILed.

Test build #29459 has finished for   PR 5284 at commit 19f46b7.

This patch passes all tests.

This patch merges cleanly.

This patch adds the following public classes (experimental):

class DataFrameNaFunctions(object):

This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29459/
Test PASSed.


Does it support add edge?

I figure it out....

@xchen0012 Thanks, I close this then :-). Suggestions for improvement in documentation, code or sample are always welcome!

I updated the documentation . Hopefully it is easier to figure out now


Derive(Deserialize) generated in remote crate's macro does not respect crate's rename

Remote crate ("test-macro"):
// lib.rs
pub type PhantomData<T> = ::std::marker::PhantomData<T>;

pub trait Dispatch {
    type Call;
}

#[macro_export]
macro_rules! decl_issue_one {
    (
        $( #[$attr:meta] )*
        pub enum $name: ident <$generic_name: ident : $generic_ty: ident>;
    ) => {
        $( #[$attr] )*
        pub enum $name<$generic_name: $generic_ty> {
            __PhantomData($crate::PhantomData<$generic_name>),
        }
    }

Local crate
// main.rs
#[macro_use]
extern crate test_macro as the_macro;

#[macro_use]
extern crate serde_derive;

trait Trait { }

decl_issue_one! {
    #[derive(Deserialize)]
    pub enum TheEnum<T: Trait>;
}

main.rs fails to compile with "missing an extern crate test_macro?": serde_derive attempts to use the path ::test_macro::PhantomData in the generated code.
See https://github.com/rphmeier/serde_derive_issues

(we spoke about this on IRC but I am filing here as well)

This is a compiler bug, I filed https://github.com/rust-lang/rust/issues/51332 to track it.


ion-scroll and collection-repeat not working in Android

Ionic version:  (check one with "x")
[x] 1.x
[ ] 2.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
The collection-repeat directive is not handling scrollable content correctly; in multiple cases I can't see all of the contents of the collection.
Expected behavior:
Able to scroll top to bottom and see every item in the collection.
Steps to reproduce:
This appears to be a known issue that's not getting proper support, see #5139.
Related code:
N/A
Other information:
N/A
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
Cordova CLI: 6.4.0
Ionic CLI Version: 2.1.8
Ionic App Lib Version: 2.1.4
ios-deploy version: Not installed
ios-sim version: Not installed
OS: OS X El Capitan
Node Version: v4.6.2
Xcode version: Xcode 8.1 Build version 8B62

Hello, thanks for opening an issue with us! Would you be able to post some sample code we can use to reproduce this issue?

Hi,
No I cannot. However it should be easily reproduced by running an collection-repeat list within a flex box layout. In the app I'm producing there was 5 collection-repeat, and all of them have been reverted to ng-repeat because the issue is produceable across different UI layouts on Android devices. iOS doesn't have this issue.

This issue was moved to driftyco/ionic-v1#64


Color picker doesn't support being moved or resized

My Environment

Dependency
Version

Node.JS version
v20.5.0

react-color-palette version
v7.0.2

Expected Behavior:
I can move/resize the component that contains the ColorPicker without any issues.
Actual Behavior:
When moving/resizing the element that contains the ColorPicker, the Saturation component boundaries stay the one from the first render ( the zone where the mouse can move the cursor is offset from the actual display zone ).
Additional Context:
From my investigation, the issue is related to the Interactive component & the useBoundingClientRect hook.
As the useBoundingClientRect does the node#getBoundingClientRect only during the first render, any changes (either position or size) are not taken into account.
To deal with position changes, the move event handler from the Interactive component should get an updated left & top position in order to be accurate.
I have a fix on my fork that rely on a third party library (use-resize-observer) : https://github.com/Wondermarin/react-color-palette/compare/Wondermarin:react-color-palette:main...msebire:react-color-palette:fix-58

@msebire, should be fixed in v7.0.3

Thanks.
I can confirm 7.0.3 fix the resize issue.
Unfortunately, the move issue is still there.
If you want a simple repro case to see it, you need to put the ColorPicker in a scrollable container and scroll it.
The color dot is then not aligned with the mouse, if you scroll to the initial position, they are back in sync.

Could you open a new issue with an example on codesandbox? I'll take a look tomorrow and fix it.


Redo the mud.config.ts page

Ludens: so as we need to do a bunch of doc work on namespaces here https://mud.dev/config; it would be good to bundle that with a lot of different examples of MUD configs and breaking them down cc @Ori Pomerantz
i was trying to explain a MUD config to someone and that page in the doc is one of the most lacking
Frolic: agreed! I think this page could become more of a guide on how to get started with the config (single vs multiple namespaces, how to use each top-level key, etc.)
then a sub page that ideally is generated from the TS doc that explains each config option so we don't have to keep em in sync
the config on this page is wrong anyway! overdue for an update

gonna consider this done for now


Auto generate OpenAPI spec JSON at build time

What is this pull request for?
This generates an OpenAPI spec JSON file before building the server.
The file is then saved in the docs directory.
Steps after this:
We have to scrape the JSON file and generate MDX files for the spec JSON.

@arielweinberger
The build is failing.
Will see what the problem is.
Any idea why that might be? Have added a depends_on for a script in project.json.

Pretty sure the issue is related to the scope at which the npx ts-node script is running and some TypeScript configuration. Try using npx tsx instead and let me know how it goes. Also worth trying setting the cwd of the operation (in nx:run-commands) to the server folder. Not sure if Root would work in this case.

@arielweinberger
npx tsx is failing on my local machine with the following error:
nx run server:generate-open-api-spec

[Nest] 40471  - 10/10/2023, 3:30:27 AM     LOG [NestFactory] Starting Nest application...
[Nest] 40471  - 10/10/2023, 3:30:27 AM   ERROR [ExceptionHandler] Cannot read properties of undefined (reading 'get')

This is the project.json command:
"generate-open-api-spec": {
      "command": "npx tsx --tsconfig apps/server/tsconfig.app.json apps/server/scripts/generate-openapi-spec-json.ts"
    },

With ts-node, it works fine on my local machine.
Also, was wondering if  the Git repo will be updated when we build the server for Mintlify to consume the updated file.

@SniperBuddy101 It won't be updated. In that case, maybe we should just make a script that generates the spec file + builds the docs, and that spec file is then pushed to source control manually? That'll do for now.

@arielweinberger
Since, you mentioned manual push to source control, do we need an offline script for this?
I read the Mintlify docs and saw that they had their custom GitHub build mechanism. Don't think we are using that.

@SniperBuddy101 We actually do! Whenever you run npx nx graphql:schema-generate server it will bootstrap the server in offline mode (all online dependencies are mocked). You could try using that.

Yes, so, an offline script to generate the openapi spec file and update the mint.json in offline mode.
This won't run on Github actions.

I think that's fine for now. You're right. We don't use GH actions to build and deploy Mintlify.

@arielweinberger
Have created a script that will auto-generate OpenAPI JSON, scrape the JSON, generate MDX files and update mint.json.
Command:
npx nx generate-open-api-spec server

You rock!


A way to use custom string values to map enums?

I have an enum like this:
public enum MyEnum {
  DESCRIPTIVE_NAME1("short_code1"),
  DESCRIPTIVE_NAME2("short_code2"),
  ...
  MyEnum(String shortCode) {
     this.shortCode = shortCode;
  }
  ...
  public static MyEnum fromShortCode(String shortCode) {
    // lookup from MyEnum.values() using shortCode
  }
}

And a class with MyEnum field. The corresponding table column holds shortCode values. Is there a way to use MyEnum.fromShortCode() when reading the value from the result set? Right now anything I do doesn't seem to have an effect and org.simpleflatmapper.converter.impl.CharSequenceToEnumConverter.convert() gets called no matter what. This of course calls java.lang.Enum.valueOf() and mapping fails.
I use SFM with JdbcTemplate and tried using both JdbcTemplateMapperFactory.addColumnDefinition() and the ServiceLoader/Converter approach.
Any working example on how to achieve this? I imagine this is a fairly common use case, since other libraries like Jackson provide a special way to serialize/deserialize enums not only by their name.

I’ll have a look ASAP.

Custom getter are set via the the getter property for pull mapper - anything apart from csv for that one it’s a cellvaluereader but I can’t recall the prop

just pushed version 3.7.1
you can now do
    JdbcTemplateMapperFactory.newInstance()
        .addColumnProperty("my_enum_column", ConverterProperty.of(MyEnum::factoryMethod))
        .newRowMapper(MyDto.class);

I used the version 6.4.0.
public enum UserStatus {
    UNVERIFIED, VERIFIED, DEACTIVATED;

    public static UserStatus fromName(String name) {
        return UserStatus.valueOf(name);
    }
}

JdbcMapper<User> mapper = JdbcMapperFactory
            .newInstance()
            .addColumnDefinition("status",
                FieldMapperColumnDefinition.customGetter((Getter<ResultSet, UserStatus>) rs
                    -> UserStatus.fromName(rs.getString("status"))))
            .newMapper(User.class);

I tried the code above, it is not working.

which java version? is there any osgi involve? could you copy the stack trace ?

I updated the previous comment. I used it with Spring Boot and JPA. I suspect it is might be related to my Intellij IDEA hot reload feature.

Yes likely a hot reload issue, the asm created its own classloader and it might stick around with the version of the class. Could you try calling useAsm(false) to see if that stop the issue from happening?

On the JdbcTemplateMapperFactory

@arnaudroger
java.lang.ClassCastException: com.xx.xxx.domain.UserStatus cannot be cast to com.xx.xxx.domain.UserStatus

I've encountered the same problem with Kotlin data classes. It is caused by combination of asm and Spring Boot Devtools. useAsm(false) indeed fixes it. That's all good, but it's quite annoying to set useAsm to false everywhere. Is it safe to reuse result of JdbcTemplateMapperFactory.newInstance() and inject it? Then I could inject one with useAsm set to false without writing a wrapper.

Mappers are thread safe and can be safely shared.
On Mon, Mar 25, 2019 at 2:36 PM neVERberleRfellerER <
<EMAIL_ADDRESS>wrote:

@arnaudroger https://github.com/arnaudroger
java.lang.ClassCastException: com.xx.xxx.domain.UserStatus cannot be cast to com.xx.xxx.domain.UserStatus
I've encountered the same problem with Kotlin data classes. It is caused
by combination of asm and Spring Boot Devtools. useAsm(false) indeed fixes
it. That's all good, but it's quite annoying to set useAsm to false
everywhere. Is it safe to reuse result of
JdbcTemplateMapperFactory.newInstance() and inject it? Then I could inject
one with useAsm set to false without writing a wrapper.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/arnaudroger/SimpleFlatMapper/issues/505#issuecomment-476224735,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF4ErZWzbiWlvwro13FfJfvBj23emv4Gks5vaN8JgaJpZM4TKwMA
.

@neVERberleRfellerER  created issue 623 to see if we can support the dev tools reload

6.6.0 is being release at the minute and should work fine now with springboot devtools.

@arnaudroger It really works. Thank you very much.


Misc Fixes

First commit fixes a (rare) problem in sortable lists. Dragging/hovering an item near the top of a list would sometimes (depending on speed of the mouse movement) result in suggestedIndex of -1, breaking the drag.
Second commit fixes and issue when using DndPreview but not using the MultiBackend, the previews attribute wouldn't actually exist.

Many thanks!


in "RAD Server Techniques" we must have 2 authors but only one appear on the webpage

seems to be fixed, don't know really why but the new builder do the job


Extract the blacklist from the action itself

I'm submitting a ...
[ ] spammer report
[ ] bug report
[X] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary
At the moment the blacklist is build into the Action itself, wouldn't it be better if the list was seperate and dynamically retrieved? This would also allow for a custom blacklist in repositories which might be blacklisted for a different reason.

Hi @StefanJanssen95, that's an excellent idea! I'll work on it tonight! 😉
Do you have any suggestion about the file type? (do I keep it to typescript, move it to CSV, etc.)

I think JSON would be the easiest to read from the Javascript/Typescript side of things and is techstack independent (for when another tool might want to use the information on the list).

Have you started working on this already? If not I would be willing to pick it up.


hi, there are some product design that i should to modify okhttp source, so I want know how to modify and compiler the okhttp source base at android platforms,and which okhttp versions I should use?

Not sure how to answer that. Maybe ask on Stack Overflow?


Provide determinate z-order for elements

Details
This fixes an issue where section backgrounds could be positioned above other elements.  The root cause is, since the zIndex property isn't set on any attributes, all attributes have the same default zIndex of 0.
From the docs:

[...] Items with the same value have an undetermined order. [...]

ElementZIndex is added to represent an ordering (front-to-back): header, item, and background, and applied to those elements' layout attributes.
Some thoughts:

Headers and items can potentially overlap (e.g. by applying negative section insets); this positions headers above items.
Some further adjustments would be required given the footer functionality provided in #31.

Related Issue
Motivation and Context
How Has This Been Tested

Tested that reload, insertion, and removal scenarios maintain the expected element ordering.

Extended the example project to provide visible backgrounds for inserted sections. Very open to suggestions on alternatives to incorporate backgrounds into the project (e.g. alternating visible/hidden across sections, background style, etc.).

Before
After

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.

@nate-sentjens left my main comment as inline feedback, but a few other things:

https://github.com/airbnb/MagazineLayout/pull/31 is now merged, so please rebase
If we agree on my comment about not making these constants, then let's add support for footer attribute z indices too
We need to bump the MagazineLayout.podspec to say version 1.3.1, and MagazineLayout's Info.plist (not the example project's)
Let's not add section backgrounds by default to the inserted sections in the sample project, but I like the idea of one of the default sections having a background (it looks like that's what you have implemented here anyways, so maybe no action required?)

Looking forward to getting this merged!

For sure, and thanks for the review @bryankeller ! Absolutely 🙌


Multiple Application Instances [Doubt]

Hello everyone,
i'm posting this as a doubt not a issue, my doubt is about managing metrics using spectator in an application that has multiple instances.
How can i separate the metrics in the backend for each instance? What are the best practices?
Thanks in advanced.

For us that is done using tags. In particular in the environments we support internally common tags are added automatically which allow us to distinguish a given instance in our infrastructure.
We do not typically run multiple processes per instance/container so the instance id is one of the common tags that are applied when metrics are reported to the backend (Atlas in our case).
There are some exceptions, e.g., when using Cassandra we also run a sidecar called Priam that is a separate process. In that case we are using the spectator-agent with the Cassandra process with a config like:
include "nflx.conf"
include "cassandra.conf"

netflix.spectator.agent {
  atlas {
    tags = ${?netflix.spectator.agent.atlas.tags} [
      {
        key = "process"
        value = "cassandra"
      }
    ]
  }
}

So the process name is part of the common tags applied to data coming from the Cassandra process.

Hello @brharrington, thanks for the response.
So, you use a tag for each instance, like a random id?
Where do you put this tag in the metric name, in the beginning or ending? Could you share a more concrete example ?
I could call a metric starting with the instance like service.<instance-id>.metric.name, something like that?

In our case it is not a random id, but a resource id that can be linked with other systems. In the case of AWS instances we use the EC2 instance id.
We don't use hierarchical naming and consider mangling things into the name an anti-pattern. At Netflix we use Atlas which supports reporting and querying the data using tags (see the Concepts page for more details.).

@brharrington i see, the tags for atlas is very concise, and pretty clear. But in my usecase i'll be using codahale metrics, and sending it to graphite, and i can't change it, since the infrastructure is already there and many services already using it, and in graphite there is not such thing as tag, thats why i thought about putting in the metric name.
The services will run on Mesos with Marathon for scaling, i guess the information you gave me won't fit this scenario.
Do you know any alternatives?
By the way, i'll look at Atlas maybe for a proof of concept and try to propose that solution, your explanation helped a lot, thank you.


Module wise different project.

In serenity, Is it possible to have Module wise different project.

What does this mean?

Suppose I Have Purchase, Inventory, Sales, HR, Accounting etc module in my Applicalion. I want to organize them in different script, repository etc project.

You could. Only problem is T4 files. You need to find a way to split them.

I have generated 1000+ tables in my project. Now it takes about 10 minutes to build. Any suggestion?

Omg, what kind of project you are doing

Splitting wont help much, remove repository, endpoint, page cshtml etc that you wont use. Get a faster SSD get a faster CPU :)

Maybe incredibuild increase your build performance

I know your post is old ..

Suppose I Have Purchase, Inventory, Sales, HR, Accounting etc module in my Applicalion. I want to organize them in different script, repository etc project.

I am wondering if you would be able to build them as separate projects .. and then simply take the modules and add them in to the application - much like Northwind is existing ? Just food for thought..


feat: add support for PHP 8

Tests are passing on Travis CI, although it doesn't seem to be registering the builds in the PR checks (if you're interested in moving to GitHub Actions, I'd be happy to open a PR for this as well).
It looks like Style CI is also misconfigured, but that's through the UI so I can't resolve it.

@scrubmx Hey Jorge, got time to approve this?


Unit test certlogic French rule (DEV)

added a unit test to ensure that the rule about market auth holders passes
see https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-10455

Its all green 🚀
But before merge kindly check if we need it in 2.14. Mb it should go directly to 2.15?


Add support for watchOS 2.0

Since it is supported by cocoapods 0.38.

problems so far

cocoapods linter fails with watchos dependency error
pod install causes the build to stall and abort


Better error message on failed http request

When we get a 404, the returned error is empty and not helpful. Make sure we report at least the url and the status text in that case.

I would like to know the response you got in your console when .withLoggerMiddleware() is included when creating the client.

I still get no error message:
node index.js
Error
    at executeRequest (/Users/sevtap/Code/buggy_store/node_modules/@commercetools/sdk-client-v2/dist/commercetools-sdk-client-v2.cjs.dev.js:360:19)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Changes no longer needed.


fix: remove retry when the processor is not found.

we shouldn't retry when the processor is not found, it will slow down the watermark progression because the watchers will be busy retrying.
panic if there are any reduce errors, so that we replay the messages when the pod comes up.

we merged this with a failed check, could you please make sure it is not retrogressing?


Remove use of django's widget system for conditionals

It's a nice system, but complex and not sustainable

won't be a breaking change for the current downstream repos


chore: emit rustc-check-cfg for nightly linting

The old cargo: instruction syntax has been deprecated with version 1.77 and newer features (such as the check-cfg feature introduced in 1.79) require the new double colon cargo:: syntax.
This change keeps the old syntax around since it is ignored on newer versions and still necessary for our MSRV policy.

Its not bumping the MSRV, since the old syntax style instructions will still be emitted

We must use cargo: instead of cargo:: until we raise our MSRV. Also we do not need to duplicate the instructions, Cargo still supports the cargo: syntax.


Fix several Sonar issues

As a Tradista Flow maintainer, I want to minimize technical debt and a way to do that is to fix relevant alerts raised by Sonar.
This ticket is created to fix several Sonar issues.

It will be included in v2.2.0


chore: move theorems on String to std4

https://github.com/leanprover/std4/pull/124 moves the following from Mathlib4 to Std4:

helper simp theorems on String.Pos
String.utf8GetAux.inductionOn

bors merge


[$500]  Chat - Parent message shows editing mode when editing the message in the thread

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:

go to any chat
send a message
start thread
hover over the message and click edit option
without doing anything go back to parent clicking on the header

Expected Result:
Message should not be in edited mode
Actual Result:
Message is showing in edit mode
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/115492554/7b12463a-63d9-4579-99c0-8238f973084e

MacOS: Desktop

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~011db84558d8f19401
Upwork Job ID:<PHONE_NUMBER>126123008
Last Price Increase: 2023-10-27

This is not a bug, see https://github.com/Expensify/App/pull/28154

This is not a bug, see #28154

@maddylewis @izarutskaya As pointed in the previous comment it looks like it was added in the PR. Can you confirm and then we can close this one.
Thanks @eh2077

Discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1691673930838889?thread_ts=1689867403.367019&cid=C01GTK53T8Q
We can close as expected. Maybe we need to update Test Rail so QA team won't treat this as bug in the future.

Maybe we need to update Test Rail so QA team won't treat this as bug in the future.

@situchan - which steps would you suggest adding/updating to test rail? i can create an issue to get that updated.

@situchan - which steps would you suggest adding/updating to test rail? i can create an issue to get that updated.

https://github.com/Expensify/App/issues/21527#issuecomment-1743015904

cool, already added - https://github.com/Expensify/Expensify/issues/324787


updated seeds, mealdata, userdata

mealdata and user data seeding properly
bug on scraper fixed
dev error on how exports were called also fixed

Please disregard changes made to the views - meant to chat with Julian and should not have deleted.


Feature/mTLS

add client mTLS support
This enables more secure device connection
Certificate and key is stored in PEM format, files are specified by -k/-c variables in CLI
This requires mTLS support in rttys

Tested with Buildroot 2020.11.2 with ARM device


[Request] - Debugger integration

As the Swings can contain JS, it would be nice to have VSCode's debugger integrate with the script you add. This would allow users to set breakpoints on the script.js file and hit debug on the side bar.
A naive approach to this working would be to add a .vscode/launch.json file to the temp folder, but maybe there's better ways

This would be awesome!

I believe we'd need to implement a VS Code debug adapter. It wouldn't be a trivial amount of work, which is why I haven't prioritized it (in addition to the fact that I haven't heard the request that many times).

I believe we'd need to implement a VS Code debug adapter. It wouldn't be a trivial amount of work, which is why I haven't prioritized it (in addition to the fact that I haven't heard the request that many times).

Implementing debug adapters are usually for new languages, there are existing debuggers for JavaScript/Typescript out the box so I don’t think that’s the case here. This would be more about integrating with the existing debugger into what Codeswing offers.
I’ve since used live preview which does exactly that


list vs. array<int, T>

Since @simPod has brought this up in some PRs, let's have a proper discussion about annotating sequentially numerically indexed arrays in PHPDocs.
PHPStan added partial support for this type in https://github.com/phpstan/phpstan-src/pull/83/files, but is lacking the full validation capabilities (ensuring gapless indexes) that Psalm provides https://psalm.dev/docs/annotating_code/type_syntax/array_types/#listsa. Thus, they do not even mention their usage in the docs: https://github.com/phpstan/phpstan/pull/4282
I think we should hold off on using list<T> until PHPStan fully commits to supporting it properly. Until then, array<int, T> does a pretty good impression of it, with the added bonus of IDE compatibility.

Apparantly, those two types are not the same. I think the semantics line up with the new array_is_list function in PHP 8.1: https://php.watch/versions/8.1/array_is_list
/** @var list<int> */
$a = [1, 2];
unset($a[0]); // Should not be allowed, or the type must be array<int, int>

Yes, the question should be whether we want to adapt the list type. But since it's indirectly introduced by array_is_list() in 8.1 I see no issue here. As you said, list<T> is covariant to array<int, T> but are not the same.


conn_manager: add overload header if request is dropped due to OM

Commit Message:
Add x-envoy-overloaded flag to local reply sent by connection manager in case Overload Manager led to the need of shedding some load.
Added an API field in connection manager to allow the suppression of the x-envoy-overload flag.
Additional Description:
This is different from the handling in the http filter where x-envoy-overloaded flag added when maintenance mode is enabled or when the upstream circuit breaking is triggered.
The connection manager does not initialize the filters when "envoy overload" is detected thus requiring special handling.
N.B: For the time being I used the existing x-envoy-overloaded header, if you prefer I can introduce a different header exclusive to the case where the envoy itself is overloaded (e.g: x-envoy-local-overloaded).
To prevent malicious actors from gaining information about Envoy's status, a flag has been added in the API to suppress the header.
Fixes #15106
Risk Level: Low
Testing: Added unit-tests and integration test for verifying the header being added
Docs Changes: Done
Release Notes: Done
Platform Specific Features: -

Thank you everyone of the feedback :). I will soon have some bandwidth and I will start addressing all the comments

Based on the feedback the following changes were performed:

The header that is added  in case envoy itself is overloaded (based on OM) is now "x-envoy-local-overloaded", I do not reuse anymore the "x-envoy-overloaded" header which remains exclusive to upstream circuit breaking usecases
The "x-envoy-local-overloaded" is no longer added by default, it is controlled by a skip_local_overload_append flag in connection manager (default: true)
doc changed accordingly
test that the header is not added by default. I'm a bit lost on how to add a test to verify that  the header is added when the flag is set, I'm having difficulty in mocking connectionManagerConfig for conn_manager_impl_test_2.cc :(

I'm still implementing the integration tests. Will push them soon. /wait in the meantime

Thank you all of you for the feedback :)

/assign-from @envoyproxy/senior-maintainers


tab bar / URL bar don't switch places when told to do so by the config.

I'm running firefox version 115.0.1 on Artix Linux. I want the tabs on the left of the screen, as that would make the new tab button closer to the URL bar.
The issue I am facing is that attempting to do so via realfire-config.css does not change the layout (i am setting the relevant value to 3 as instructed by the comments).

Thanks for reporting this issue. I found the problem. I will fix the problem as soon as possible.

I fixed that thing. After making the change: Open about:support > Clear startup cache... > Restart


Fix how image attachments are handled

Remove the dependence on the file extension.

I'm sorry, I fixed this ... but not in a clean commit Olog/olog-service@29d050f5127bd6a673d6852f419262fab0b2b2ec


chore: add types property (#1)

Types of changes
What kind of change does this PR introduce? (check at least one)

[ ] Breaking change
[ ] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactoring
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Description
package.json に types プロパティを追加

#1 TypeScript の型の補完が効かない
Issue Number: N/A

Thanks!


Problem when expand external links.

The links like : "rdar://problem/21312183", create problems when the external links node is expanded

Fixed in: 1455a9bb160097c508e0e811069f035945155ac5

Edit showed message when unknown protocol is found : 60ac9cfd187698adf1f59ae3b562ef0f81f89283


Applied fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

Let's clean up a bit


Command palette shouldn't auto close when switching window/focus

VSCode Version:1.1.1
OS Version:Win10 x64

everytime I search for extensions, it takes minutes to complete(slow network for oversea connection). VSCode doesn't allow me to switch to other apps while waiting, very frustrating.
Steps to Reproduce: You have to use VSCode with a slow network/4G network.

press Ctrl+P
type ext install xxx
observe the search results won't appear (until several minutes)
While waiting, switch to another window (use Alt+Tab or just press Start menu)
the command palette window automatically closes. You have to search again.

I am closing this because in June we plan to move the extensions management UI out of quick open into a more stable experience.
There are other feature requests filed to generally keep quick open open even on focus lost.


How to enable logging for all requests/responses

Hi,
I have a module with reqwest and eng_logger.
Is it possible to enable logging so reqwest uses log to to print all requests and responses? I would like to see the endpoint, headers, body, etc.
If this is possible, how?
thank you

I answered myself, just need to set RUST_LOG=debug

The only way to fully log all the data you're asking for is to also set the connection_verbose() Client builder option, and then enable logging.


Mongo DB Integration

This allows for data to be loaded/saved to a Cluster made on Mongo DB Atlas. With a given user and password, you can connect to the database. If you are in need of a user for testing, please let me know!
I decided to put the loading functionality of data in the Controller because I used the serverID as a unique identifier (needed to keep track of messages and their conversations). If there were a way, I'd like to move the loading functionality to their own class or within the Database class.

The reason for the large amount of additions and deletions is due to

the chat log adds A LOT of lines because I didn't think to put it in the git.ignore
I removed the Android GUI because it was making the project not compile (but when it merges in develop, the original Android GUI will be there)


Rows of radio buttons are spaced awkwardly close to each other

For example:

that's just the preview


Need help to set Appendices Section

If I want to set the Appendices section as follows:

just like the picture uploaded, the circle 1 and circle 2 are no need, How can I exclude it?

At the moment is not possible, but i can add a parameter to allow that

Thanks very much!

Can you upload here the code to make point 2 appear? I can't see it in my tests. Thanks

Can you upload here the code to make point 2 appear? I can't see it in my tests. Thanks
Because I don't want to display the list of figures and tables in the book, I commented out the lines list-of-figure-title: "List of Figure" and list-of-table-title: "List of Table" in the #show book.with( ) section in the file main.typ.

By the way, a humble suggestion:

You might consider using the numbly package to customize titles of different levels, such as "Chapter 1", which could potentially enhance the reading experience;
Since the locate function will be deprecated in the new version of Typst, it might be a good idea to consider using the context function to achieve the corresponding functionality.

Fixed all in version"0.3.0":

I added a new parameter to:

#show: appendices.with("Appendices", hide-parent: false)
to hide the name Appendices from the index.

I migrated depecrated functions, so no warning is visible.