App must verify the authenticity of the request from Shopify.

For bug reporting only! If you're posting a feature request or discussion, please ignore.
While submitting app we are having those 2 issue
Expected Behavior
https://prnt.sc/26ng19g
Please describe the behavior you are expecting.
Current Behavior
Please describe the current behavior?
Failure Information
Please help provide information about the failure if this is a bug.
Steps to Reproduce
Please provide detailed steps for reproducing the issue.

Step 1
Step 2
...

Context
Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Package Version: 17.1
Laravel Version: 7.2
PHP Version: 7
Using a toolset (Docker, Laradock, Vagrant, etc.):

Failure Logs
Please include any relevant log snippets or files here.

I'm not 100% sure that is correct from Shopify.
The first requests look correct for me (this is triggering it from the partner dash but same sort of thing)

Click "install"
We are sent to the auth route as it has been set up in the app admin.
We then go to /admin/oauth/authorize
From there it gets redirected to /admin/oauth/request_grant where you see the "Install Page"
Click install and we go to /admin/oauth/post_grant to grant the charges (if any)
Then /authenticate happens again with the new ?code parameter to be authed and all the usual stuff happens i.e we store the API Access Token etc.
/authenticate/token should only happen in between page changes within the app itself not as part of the authentication flow.

Can you provide more detail on your set up with your routes etc.

@Kyon147  Yes so when we are trying its allowing me to do everything i tried to install that multiple times and its working perfect but still they are sending me same https://wishlist.partners.gemfind.com/login
here is my instance where you can check

Following the routes via a redirect tracking tool - I don't see /authenticate/token in the flow at all - the only one is when it lands on /authenticate and then going to /oauth/authorize.

@Kyon147 Yes so when we are trying its allowing me to do everything i tried to install that multiple times and its working perfect but still they are sending me same https://wishlist.partners.gemfind.com/login here is my instance where you can check

Question, have you manually added the login page back into your application? As this view was removed a while back.

yes i added that manually otherwise if we try to open that page its give me shop domain error.

Yeah, I don't see the auth/token directly but I do see the authenticate route.
I'll need to do a little more digging and I'll tag @osiset as he knows the auth flow a lot better than me.

please check my video as mentioned for each step routing we are following https://watch.screencastify.com/v/Ugt28T0xmltwPKJnJNVI

@Kyon147  is there any idea after looking at video?

@Kyon147  Thanks for the info but yes its working as same mentioned that its passing with above route

@somin-parate - I've created a new PR which avoids the full page redirect and does seem to keep the package running as normal. Just need @osiset to take a look and merge into master if he's happy.

I'll make some time Friday morning, sorry guys, I'm still full-tilt on work
and external issues! Appreciate it!
On Wed., Feb. 16, 2022, 12:50 Luke Walsh, @.***> wrote:

@somin-parate https://github.com/somin-parate - I've created a new PR
which avoids the full page redirect and does seem to keep the package
running as normal. Just need @osiset https://github.com/osiset to take
a look and merge into master if he's happy.
—
Reply to this email directly, view it on GitHub
https://github.com/osiset/laravel-shopify/issues/1073#issuecomment-1041839675,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AASO4OWX7ZL4LZA4QRC34R3U3PFERANCNFSM5NMGJBKA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi.  Any news on that issue.We are having the same feedback from Shopify.

For bug reporting only! If you're posting a feature request or discussion, please ignore.
While submitting app we are having those 2 issue
Expected Behavior
https://prnt.sc/26ng19g
Please describe the behavior you are expecting.
Current Behavior
Please describe the current behavior?
Failure Information
Please help provide information about the failure if this is a bug.
Steps to Reproduce
Please provide detailed steps for reproducing the issue.

Step 1
Step 2
...

Context
Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Package Version: 17.1
Laravel Version: 7.2
PHP Version: 7
Using a toolset (Docker, Laradock, Vagrant, etc.):

Failure Logs
Please include any relevant log snippets or files here.

Hi @somin-parate  have you solved this problem?

I figured out the problem. Actually app is not broken. The problem is not with the install but reinstall.
When the shop is being installed for the first time there is not a problem, but if you delete the app and install it again because the app finds it in the database it tries to find a token etc.
To solve this problem you must subscribe to  APP_UNINSTALL Webhook. This is not the same thing as GDPR Shop_Redact.
When this webhook calls you if you delete the shop on the next install for the same shop you won't get this problem.

I figured out the problem. Actually app is not broken. The problem is not with the install but reinstall.
When the shop is being installed for the first time there is not a problem, but if you delete the app and install it again because the app finds it in the database it tries to find a token etc.
To solve this problem you must subscribe to APP_UNINSTALL Webhook. This is not the same thing as GDPR Shop_Redact.
When this webhook calls you if you delete the shop on the next install for the same shop you won't get this problem.

How do you figure out it? Did you create a new command then assign hook to the new one Or there is method named "softDelete" did you customize this method.

@baristinaz - the uninstall webhook is all detailed in the wiki - please give it a read.
https://github.com/osiset/laravel-shopify/wiki/Installation#uninstalled-job-recommended

第一个请求对我来说看起来是正确的（这是从伙伴破折号触发它，但同样的事情）。有一个身份验证/令牌请求，但那是为了获得一个能够安装的令牌。

点击“安装”
我们被发送到 auth 路由，因为它已在应用程序管理员中设置。
然后我们去/admin/oauth/authorize
从那里它被重定向到/admin/oauth/request_grant您看到“安装页面”的位置
点击安装，我们去/admin/oauth/post_grant授予费用（如果有的话）
然后使用要验证/authenticate的新?code参数再次发生，所有常见的事情都会发生，即我们存储 API 访问令牌等。

您能否提供有关您的路线设置等的更多详细信息？

The first requests look correct for me (this is triggering it from the partner dash but same sort of thing). There is an auth/token request but that's to get a token to be able to install.

Click "install"
We are sent to the auth route as it has been set up in the app admin.
We then go to /admin/oauth/authorize
From there it gets redirected to /admin/oauth/request_grant where you see the "Install Page"
Click install and we go to /admin/oauth/post_grant to grant the charges (if any)
Then /authenticate happens again with the new ?code parameter to be authed and all the usual stuff happens i.e we store the API Access Token etc.

Can you provide more detail on your set up with your routes etc.

The first requests look correct for me (this is triggering it from the partner dash but same sort of thing). There is an auth/token request but that's to get a token to be able to install.

Click "install"
We are sent to the auth route as it has been set up in the app admin.
We then go to /admin/oauth/authorize
From there it gets redirected to /admin/oauth/request_grant where you see the "Install Page"
Click install and we go to /admin/oauth/post_grant to grant the charges (if any)
Then /authenticate happens again with the new ?code parameter to be authed and all the usual stuff happens i.e we store the API Access Token etc.

Can you provide more detail on your set up with your routes etc.

Hello, two lists were rejected when I submitted the public application online
The details are as follows:

App must set security headers to protect against clickjacking. Your app does not request installation on the shop immediately after clicking "add app". Apps must ask a shop for access when being installed on a shop for the first time, as well as when they are being reinstalled after having been removed. During install or reinstall we expected OAuth to be initiated at https://cambridgetestshop.myshopify.com/admin/oauth/request_grant but was redirected to https://xxx.com?hmac=xxx Learn more about authentication in our developer documentation

App must verify the authenticity of the request from Shopify. Your app does not request installation on the shop immediately after clicking "add app". Apps must ask a shop for access when being installed on a shop for the first time, as well as when they are being reinstalled after having been removed. During install or reinstall we expected OAuth to be initiated at https://xxx.com?hmac=xxx Learn more about authentication in our developer documentation

But OAuth is not a link generated by our own system to provide users with authorization?
I consulted Shopify's official customer service and only provided me with three links
https://community.shopify.com/c/shopify-apis-and-sdks/app-submission-failing-at-app-must-verify-the-authenticity-of/td-p/1435848
https://community.shopify.com/c/shopify-apps/shopify-app-clickjacking-app-must-set-security-headers/td-p/1424255
https://github.com/osiset/laravel-shopify/issues/1073
What should I do?


The evaluation stuck after unwrap_model during distillation training

Should I add accelerator.prepare after unwarp?

Hey @HackGiter! Sorry for the delay here - resolved in #74! Let me know if you encounter any other issues - best of luck with your distillation efforts!


fix: Full data download (merged cubes)

Fixes #1536

I do not understand what's happening here ? Do we a joinBy iri inside dataCubeMetadata.iri in case of merged cubes ?

Currently, we pass queryFilters which is an array in case of having merged cubes. As full data download is scoped per given dataset, we need to pass correct query filters (per given cube) 👍

I refactored to make it clear from the code 👍


Directions for install location for client agent contradict Best Practices guide

The Best Practices guidelines state:

Install the client agent on a computer that isn't the SQL Server computer

This guide states:

Download the data sync agent from the link provided and install it on the computer where the SQL Server is located

These two statements directly contradict each other.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c3eab63a-ca3d-f39e-dcb4-80608c808ec2
Version Independent ID: f49d1d22-3e9e-d5cc-47a6-d67ca9c025c5
Content: Set up SQL Data Sync - Azure SQL Database
Content Source: azure-sql/database/sql-data-sync-sql-server-configure.md
Service: sql-database
Sub-service: sql-data-sync
GitHub Login: @WilliamDAssafMSFT
Microsoft Alias: wiassaf

@jbogard Thanks for your findings,We will investigate and update as appropriate

Thanks @jbogard for contacting Microsoft with feedback about our product documentation. As you can see from this delay in responding, it could take a bit to look further into this with the product team and decide on how to address. Will update.
Thanks again for this feedback, your suggestions help improve our documentation.

Thanks again @jbogard for contacting Microsoft to point out this contradiction. Nice catch! A doc fix is in flight. In short, you should install the client agent on a machine that is different than where SQL Server is installed.
#please-close


Networkwatcher - NSG flow logs cannot be tagged

In the page about resources that support tagging (see below) the resource NSG flow logs isn't mentioned. It is an actual resource, and it does not support tagging. We periodically get all Azure resources, and add tags to those resources that do not have tags applied to time. We get error message when doing this for flow log settings, with the error "The requested resource does not support http method 'PATCH'".
I would recommend adding NSG flow logs to this page and mention it doesn't support tags.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 66769e1b-720b-f1b1-a5e3-ed5cb24cd233
Version Independent ID: b6272e61-58c1-3e2f-3e36-a9ee920c0915
Content: Tag support for resources - Azure Resource Manager
Content Source: articles/azure-resource-manager/management/tag-support.md
Service: azure-resource-manager
Sub-service: management
GitHub Login: @tfitzmac
Microsoft Alias: tomfitz

Thanks for your comment. The feedback has been shared with the content owner for further review. Thanks for your patience.

@NillsF - thanks for this feedback. I ran a test and was able to apply tags to flow logs when creating the resource. But, I see the same error you saw when applying tags after deployment. I'll update the doc to indicate it does not support tags.


add_openglwidgets_to_linux

Add QT += openglwidgets for Linux  g++ compiler in Sample.pro so that it can find QOpenGLWidget.h.

   QT += openglwidgets seems only works on Qt6, on Qt5 it raises a error "Unknown module openglwidgets" on qmake. Maybe add it only on Qt6 or higher version?


Issue after upgrade to android 5.1

Hey I just updated my phone to lollipop 5.1 and now I get this error:
The browser does not support the getPropertyCSSValue method!

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/10404874-issue-after-upgrade-to-android-5-1?utm_campaign=plugin&utm_content=tracker%2F637500&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F637500&utm_medium=issues&utm_source=github).

use v1.2.5  or master branch.

thanks it works.
But the map.setbackgroundcolor doesn't work anymore now...

Only defined colors are available.
https://github.com/wf9a5m75/phonegap-googlemaps-plugin/wiki/Available-HTML-colors

Or specify using rgb() or #RRGGBB

I'm doing map.setBackgroundColor("#1b1f2b");
Le 3 avr. 2015 6:15 PM, "Masashi Katsumata"<EMAIL_ADDRESS>a
écrit :

Or specify using rgb() or #RRGGBB
--
Reply to this email directly or view it on GitHub
https://github.com/wf9a5m75/phonegap-googlemaps-plugin/issues/477#issuecomment-89340865
.

Please find the bug position. Allsource code is open

OK I had to put it after the mapReady event. That makes sense but it is strange because it was working in the 1.2.4
Thank you

Yes, because the initialization of Google Maps Android API v2 has been changed as asynchronous.
But I provide the  MAP_READY event before this changing.
All statements except some static methods are have to wait the MAP_READY event.
By the way, why don't you use just like this?
var map = plugin.google.maps.Map.getMap(mapDiv, {
  'backgroundColor': 'white'
});


--repeat flag added to MyTimer

Reference Issues/PRs
#94
What does this implement/fix? Explain your changes.
This PR will add --repeat flag to MyTimer so that user can play MyTimer in a loop.
Using --repeat -1 will run the program in an infinite loop.
Any other comments?
@sepandhaghighi please also add the new milestone before merging this PR.

@sepandhaghighi please re-review.


Test mailer does not have an option to return a response

When I switched to my custom delivery_method with return_response = true, cucumber tests fails, because is is not possible for test mailer to return a response.

Should "just work"—return_response is handled by Message#deliver.


Fixed issue #25 and updated the README file

Just dropping off the fix and the edited README file.

Merged within #29


Bug: Template Won't Launch From Winlink Express

File Bigfoot Bib Report.txt has the required Form: declaration but somehow cannot properly read the file as-is.
The fix is to add line-feeds between each line in the template file to ensure there is no incidental concatenation.
Update the file so each entry has an additional CR/LF character between each Template keyword and following argument(s) for proper operation.

Working to resolve this issue today.

Still seeing this in 101b. The error is it can't open Form: formname here  To: <var

There is some sort of blank-line issue going on, probably related to one of my dev environments being Linux. Try this:

Open Winlink Express
Click Message > Template Manager
Open (your callsign) Templates
Click Bigfoot Bib Report.txt
Click Edit

Are there any blank lines? Or is everything smooshed together in a single line?
If smooshed together, add blank lines so the file looks like this:
Form: Bigfoot Bib Report Initial.html

To: <var address>

Subject:<var msgsubject>

Msg:
<var TheData>

-----

<var Comment>

<var FormatNote>

-----

Winlink Express Sender <var MsgSender>

Template version <var Theversion>

Let me know what happens and I'll figure out a way to fix this in the next bugfix release.

I'll try that. Perhaps run unix2dos on the file before comitting it?

Thanks! Since I have used both linux and windows dev environments, it probably has to do with this git behavior mentioned in stackoverflow. Next bugfix forthcoming.

The process above worked around the issue.

It seems like GitHub's Release ZIP process is stripping CR characters.
Follow the instructions in this post and the problem should go away.
Meanwhile, I'll try to find a better release system that will retain the CRLF settings so Winlink Express doesn't misinterpret the file on read/import.

Although not a short-term solution, might inquire with the RMS people if winlink can be made more tolerant on reading the file.

My TXT file looks good, plenty of line feeds. Still no joy.

@DaveWilma Did you look in the Template Manager, or in notepad? Notepad etc don't show the issue.

If you are using Template Manager to add the line feeds, then please attach a screen shot of the template manager so we can debug it by eyeball.

That did it, Edit from the Template manager. I am looking at the template.

Fixed with PR #20

Wow, who would have thought the LF/CRLF issue would be the challenge here.
Any way I can help.
Been following, and sure enough, simple Visual Studio Code fix is to select CRLF and save.
Sorry it is not that simple in GitHub build.


highlight tag missing on filtering code sample

The line numbers were there, just no highlight tag.  Added highlight tag.

Hi @mekinney, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

Thanks for fixing that!


Seed for math random functions

It currently generates always the same sequence of numbers. Can you possibly add a function like srand to set the seed of the random generator?

Good idea! Will do.


Replace DCOS with DC/OS

Updated instances of "DCOS" to be "DC/OS" .
This will also fix tests for https://github.com/dcos/dcos-cli/pull/637

Updating the readme is okay, but I don't think the packages should be updated. Packages are supposed to be immutable and not change once published.

@BenWhitehead Makes sense. I'm closing this out and will undo changes in dcos-cli as well that correspond to this.


[build-script] Add support for running sil-verify-all only on macOS x86_64

This will let us save some build time without losing the coverage of
sil-verify-all everywhere since much of the code in all of the stdlibs are the
same.

@swift-ci smoke test


The gems configuration option has been renamed to plugins

Having gems configuration option produces the error Deprecation: The 'gems' configuration option has been renamed to 'plugins'. Please update your config file accordingly.

Thanks for the update! 👍


gzip is slow in python

this is already a slight bottleneck, once we get the new loading set up, it will be moreso. A function like this:

def prefunc():
     signal.signal(signal.SIGPIPE, lambda : None)

def xopen(path):
    if not path.endswith(".gz"):
        return open(path)

    # this is over 2x faster than using gzip module.
    from subprocess import Popen, PIPE
    p = Popen("zcat %s" % path, stdout=PIPE,
              stderr=sys.stderr,
              shell=True, bufsize=-1, # use system default for buffering
              preexec_fn=prefunc,
              close_fds=False, executable=os.environ.get('SHELL'))
    return p.stdout

will be 2-3X faster than using python's gzip module. And we'll always get gzip when loading with multicore or on a cluster.

scratch this. when loading with multicore or cluster, grabix streams uncompressed VCF.


Issue with blank object ID

terraform plan -var-file=azure.secrets
╷
│ Error: expected "object_id" to be a valid UUID, got
│
│   with module.secrets.azurerm_key_vault_access_policy.allow_user,
│   on secrets/keyvault.tf line 32, in resource "azurerm_key_vault_access_policy" "allow_user":
│   32:   object_id          = data.azurerm_client_config.current.object_id

data.azurerm_client_config.current.object_id should give the object ID of your Azure user. See here for the docs.

https://github.com/hashicorp/terraform-provider-azurerm/issues/17039 -> https://github.com/hashicorp/terraform-provider-azurerm/issues/16982

Closed thanks to updated provider


invalid skin

specter can't join a server running pmmp 3.14.0, it gets kicked with the reason "kicked due to invalid skin "

There have been no API changes in 3.14.0 that affect skins. This plugin has a protocol version - it will not load on other versions than 3.11
https://github.com/falkirks/Specter/blob/55345188cbfc3a31e54d9e65b1bce4cd584e939c/plugin.yml#L6
Thus closing as invalid.


Pantheon updates 2023-08-28

https://github.com/elementary/wingpanel-indicator-power/releases/tag/6.2.1
https://github.com/elementary/switchboard-plug-applications/releases/tag/7.0.1
(Ugh, this is more than "Updated translations", probably read https://github.com/elementary/wingpanel-indicator-power/compare/6.2.0...6.2.1 + https://github.com/elementary/switchboard-plug-applications/compare/7.0.0...7.0.1 instead)
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg test pantheon


Does not support multiple series kinds on same chart - e.g. bar and line

Is this on the roadmap or out of scope?
In general it would be good to have a lower level control of the chart

Will there be a support soon?
Is it possible to make stacked & grouped bars and a line with a secondary axis? Everything within one chart?


Documenting MapReduce

I found no documentation on the MapReduce feature. Just point me to the right place to do so, and I'm willing to share my experience in a PR. I could do this in docs/query.md, but since the mapReduce method is in the collection subobject (which is not documented), I don't know where to start.
A simple example is a good start, here is what could bootstrap this doc:
var Foo = new Schema({
    type:        : String
  , date         : { type: Date, default: Date.now }
  , value        : Number
});

Foo.statics.countValueForDate = function(start, end, callback) {
  var mapFunction = function() {
    emit(this.type, { count: this.check } )
  }
  var reduceFunction = function(key, values) {
    var result = { count: 0 };
    values.forEach(function(value) {
      result.count       += value.count;
     });
    return result;
  }
  this.collection.mapReduce(
    mapFunction.toString(),
    reduceFunction.toString(),
    { query: { date: { $gte: start }, date: { $lte: end } }, out: { inline: 1 } },
    callback
  );
}

its not included in the docs b/c its not really supported yet - tho your example works great. by not supported i mean that we aren't casting the query. it'd be easy to add at some point but isn't a priority for us right now.
the feature is probably best added to lib/model.js so all collections have Foo.mapReduce().
the docs on this will then go into a new page called map-reduce.md in the gh-pages branch under docs/

+1 for supporting mapreduce and the new aggregation framework in mongoose :)


Resource Processor does not start on clean install

I have created a clean brand new installation of TRE. The Resource Processor does not start correctly during make all
Steps to reproduce

Create a clean environment and run make auth and make all
RP reports

  {
    "service": "Resource Processor",
    "status": "Not OK",
    "message": "Resource Processor is not responding"
  }

Login to Bastion and inspect the logs of the RP

]
Checking if porter v0 state exists...
v0 state exists. Checking if migration was completed once before...
porter-migration-completed container doesn't exist. Running porter migration...
error reading the schema from the old PORTER_HOME: Failed to login with Azure CLI: autorest/azure: T
here is no cloud environment matching the name "AZURECLOUD"
azureconfig.Config{EnvConnectionString:"", StorageAccount:"rosmithtre", StorageAccountResourceGroup:
"rosmithtremgmt", StorageAccountSubscriptionId:"", EnvAzurePrefix:"", Vault:""}
Azure cli login...
adminuser@vmss-rp-porter-rosmith00000N:~$

I can successfully az login --identity from the VMSS instance and it logs in. I believe it is running this script: /workspaces/AzureTRE/resource_processor/run.sh
The code is failing on migrating Porter and it seems I have an old Porter table like this in the tre_mgmt storage account

I renamed the existing "porter" Azure Table Storage container and re-ran and it everything is now created. I have kept the old porter table if you think it is worth investigating?
Bastion is not letting me connect to run those commands at the moment


Various new API additions

First of all, apologies for cramming many unrelated changes into one PR.
I'm working on Jenkins gitlab integration by using your library, and I had to add various API calls to the library.
Most changes are fairly straightforward. So I hope this change is acceptabe.
BTW, I'm the author of github-api library, and I smiled a little when I saw similarities in some parts of the library. Great minds think alike!

@kohsuke thanks for contributing!


Tweaks to scalafmt rules/script to support bazel test wrappers

Relates to https://github.com/bazelbuild/rules_scala/issues/994
With these changes, I can use a macro to place a wrapping sh_test
target around this script, and change the phase ordering to put
phase_scalafmt before the runfiles phase, and suddenly it works
as intended!
NB: If this change is acceptable to folks, then it might be worth
changing the default phase placement for ext_scalafmt to place
it before runfiles by default.
Example use:
In custom bzl file, I have:
_enable_format_targets_and_tests_by_default = True

_ext_scalafmt = dicts.add(
    _base_ext_scalafmt,
    {"attrs": dicts.add(
        _base_ext_scalafmt["attrs"],
        {"format": attr.bool(
            default = _enable_format_targets_and_tests_by_default,
            doc = "Enable the check-format and auto-format synthetic run targets (foo.format-test and foo.format respectively)",
        )},
    )},
    {"phase_providers": [
        "@//path/to/some/buildfile:phase_scalafmt",
    ]},
)

scala_library = make_scala_library(_ext_scalafmt)  # etc for other rule types

def maybe_add_format_test(**kwargs):
    if (kwargs.get("format", _enable_format_targets_and_tests_by_default)):
        name = kwargs["name"]
        sh_test(
            name = "{}.format-test.target".format(name),
            srcs = [":{}.format-test".format(name)],
            data = [
                ":{}".format(name),
            ],
            local = True,
        )

def _scalafmt_singleton_implementation(ctx):
    return [
        _ScalaRulePhase(
            custom_phases = [
                ("-", "runfiles", "scalafmt", _phase_scalafmt),
            ],
        ),
    ]

scalafmt_singleton = rule(
    implementation = _scalafmt_singleton_implementation,
)

then in path/to/some/buildfile/BUILD.bazel, I have:
load("//path/to/above/my_rules.bzl", "scalafmt_singleton")

scalafmt_singleton(
    name = "phase_scalafmt",
    visibility = ["//visibility:public"],
)

Description

Motivation

@virusdave please fix formating for:
./scala/private/phases/phase_scalafmt.bzl # reformat
You can run ./lint.sh to get it fixed

@virusdave please fix formatting for: ./scala/private/phases/phase_scalafmt.bzl # reformat
You can run ./lint.sh to get it fixed

Done!  Thanks.

NB: If this change is acceptable to folks, then it might be worth
changing the default phase placement for ext_scalafmt to place
it before runfiles by default.

Yeah, help here is appreciated. Thanks for taking this! Do you mean tweaking what happens with make_scala_library?

NB: If this change is acceptable to folks, then it might be worth
changing the default phase placement for ext_scalafmt to place
it before runfiles by default.

Yeah, help here is appreciated. Thanks for taking this! Do you mean tweaking what happens with make_scala_library?

I meant this: https://github.com/bazelbuild/rules_scala/pull/1347


[INTERNAL ERROR] TypeError: Cannot use 'in' operator to search for 'LineNum' in null

Hello CAP Team,
when I execute cds watch for the branch cleared-b1-metadata of the project sap-business-one-odata-cap I get the following error:
[INTERNAL ERROR] TypeError: Cannot use 'in' operator to search for 'LineNum' in null
at InsertBuilder._traverseValue (/Users/gwolf/Documents/Projects/cap/sap-business-one-odata-cap/node_modules/@sap/cds-runtime/lib/cds-sql/sql-builder/InsertBuilder.js:222:16)
as soon as I try to fill the data in init.js also with the array DocumentLines from the result that is returned by the sandbox service from api.sap.com.
I guess this is caused by the limitation described for array of. Would be good to know when this feature will be supported.
Best regards
Gregor

Reported also via the SAP Service Marktplace: 381101 / 2020

Hi @gregorwolf ,
We plan to implement this feature in Q3 this year.
Best Regards,
Maria


Use "expectCallMinGas" instead of just "expectCall" in the tests

The goal is to ensure that the minGasReserve property is respected.
See https://github.com/PaulRBerg/prb-test/blob/0b7deb012fc61d94ef4993f72da977197f16e1ab/src/Vm.sol#L578-L590

This issue is outdated since https://github.com/PaulRBerg/prb-proxy/pull/114 was merged.


A Database error occurred whilst loading permissions data

i cant join my server geting this error plzz help me

Please don't ignore the issue template.


Use user collections v4 for useUserCollections hook

Changes:
Added a sort by "totalValue" parameter
Backend performance improvements


Reconnect Sample

How to use the reconnect feature?

Hey @saucysalamandar, there isn't a "reconnect" feature built into this wrapper, however you should be able to listen for state changes using the stateChange option and react accordingly when a hub disconnects. I haven't messed much with reconnection, but it looks like it some cases its better to just dispose the connection and start a new one:
http://stackoverflow.com/questions/23375043/best-practice-for-reconnecting-signalr-2-0-net-client-to-server-hub

Hello,
I also need to make the hub to reconnect automatically. I think this lib need some major improvement to manage this.

Hello,
I also need to make the hub to reconnect automatically. I think this lib need some major improvement to manage this.
Obviously, what we need is:

when we disconnect, we try to reconnect to the hub every X seconds. In this example, I put 5.
new hub return a promise which is resolved when the connection is OK. This is often used in order to subscribe to a specific chan (for example you want to send a signal to a specific group of people). Unfortunately, a reconnection cannot trigger this again.

To proceed, you can add into the lib before the line "return Hub;" the following code:
        Hub.connection.disconnected(function () {
            setTimeout(function () {
                Hub.connection.start();
            }, 5000); // Restart connection after 5 seconds.
        });

then if like me you have to do some code when you are connected (like subscribing to a specific chan), you can do it under stateChanged property:
stateChanged: (state) => {
                    if (state.newState === $.signalR.connectionState.connected) {
                        console.log("connected");
                        this.myHub.Subscribe(this.lessonId);
                    }
                    if (state.newState === $.signalR.connectionState.disconnected) {
                        console.log("disconnected");
                    }
                }

Without changing a lot of things, I think an option to activate the autoreconnection can be nice to add into this lib.

I agree, automatic reconnect would be helpful.
Not sure if it makes sense to do through configuration (e.g reconnectTimeout: 5000) or callback handler.


Syncing changes across all DB collections

After updating the name in the account settings screen APIs are still giving out old names, collections are not being synced internally.
Name Updated

API giving out old/no name

Hey @hrishavjha, and @SarthakJain26 can I take up this issue

Sure @punithnayak , I will assign you this task.

Hey got stuck a little will raise pr by this weekened


Feat: Support "Draft" Replies

Feature Description
Currently, when you pull down all draft notes, those without position data in the "notes" tree. This isn't quite right, because draft notes can have a property "reply_to_discussion_id" on them, which indicates that they are meant to be replies to an existing discussion, and should be placed as a reply in the comments (linked notes) tree.
This will be tricky to implement but it'll involve stitching together those two APIs and handling the construction of the tree accordingly.

Addressed by #290


upgrade plugins for Reproducible Builds

tested 0.6.0 release, and given old versions of plugins, it's as expected not reproducible...
see https://maven.apache.org/guides/mini/guide-reproducible-builds.html#faq

Thank you for catching it :D


Garbage collection on specific date list only

Hello,
hope i'm correct to paste this here:
maybe i am missing something, but did not find anything on the docs.
I am having garbage collection on specific dates only, so i would like to set this up.
Config trying like this:
  - name: Paper # specific dates
    include_dates:
    - '2020-03-05'
    - '2020-04-02'
    - '2020-05-07'
    - '2020-06-05'
    - '2020-07-02'
Thanks for your help in advance!

I would suggest this as a feature request.
/ Ralf

Hi. Check the issue #95

Thanks a lot for the fast response.
Didin't saw this item.
Will try as described.
/ Ralf


Demos site freezes IE 11

Describe the bug
The demo site (demos/index.html) does not work in Internet Explorer 11. The initial screencis drawn with overview of all components, then Internet Explorer 11 completely freezes.c Not possible to open the development tools to investigate issues.
This is the case both when built using npm run build:demos and run with serve ., and when using npm run dev and navigate to http://localhost:8000/demos/index.html.
To Reproduce
Steps to reproduce the behavior: see above.
Expected behavior
A working demo with all components working in IE 11!
Browser Version (please complete the following information):

OS: Windows 10
Browser Internet Explorer
Version 11

do you experience the same on the deployed version?
https://material-components.github.io/material-components-web-components/demos/index.html

@e111077 yes also on the online version. It completely freezes IE 11, can't do anything anymore, not switch tabs, not go to menu. Completely frozen.
Is it the intention for the components to work on IE 11? I tried for example the Fab component in separation on IE 11 (with the same samples as in the demo), and does not work either, Fab is shown, but the texts and icons on it don't show.

IE 11 is a supported browser. We do unit testing and screenshot tests on all of our components on IE. FAB included.
The demos worked on IE at first deployment so we'll have to see what changed.

That is great news!! It will make the MCW components a great viable solution for out websites, because the reality is that we still need to support IE 11 on many of our B2B and B2C web-sites. It's still often the default browser used by people from within an office environment.
Sample of Fab on Chrome:

Sample of Fab on Chrome:

was able to finally get ahold of an IE VM. Oddly enough, the reason I think I never ran into this issue with the demos is that the pages work and are fully interactive if you have IE dev tools open. If you close it, then it freezes 🙃

furthermore, if you would like to see our fab demos on IE, direct links to the demos does not freeze IE. You can check it out here:
https://material-components.github.io/material-components-web-components/demos/

When I copy that link in my IE 11 it freezes.... I'm running it on Windows 10. But I assume it doesn't on your system... really strange... I will ask colleagues to test it out as well on Monday...

ah, it seems if you open dev tools at any point in the session, the app does not freeze and you no longer have to keep it open. This is going to be fun to debug
Though I would like to note that the MWC playground (which is an unoptimized build) will work on IE without freezing
http://localhost:10000/demos/

Cool, that work! Tried to see what exactly happen in the glitch setup, and the rollup configuration...
import resolve from '@rollup/plugin-node-resolve';
import copy from 'rollup-plugin-copy';

const unbundledMsg = `Don't want to use any bundling tools? Check out the <a href="./unbundled.html">unbundled version</a>!`;

export default [
  {
    // index es6
    input: 'index.js',
    output: {
      file: 'index.bundled.js',
      format: 'iife',
    },
    plugins: [
      resolve(),
      copy({
        targets: [
          {
            src: './unbundled.html',
            dest: '.',
            rename: 'index.html',
            inject: false,
            transform: (contentsRaw) => {
              const contents = contentsRaw.toString();
              return contents.replace('index.js', 'index.bundled.js').replace('', unbundledMsg);
            }
          }
        ]
      })
    ],
    watch: {include: ['unbundled.html']}
  },
];

I see a bundled version in the file index.bundled.js, but not minified... , output is set to life, but comment says // index es6. What is the best approach to get a production bundle for IE11? In my own webpack I build both a normal and a legacy bundle for IE 11, and use the module/nomodule trick for loading the correct bundle. But the Fab is not working in my setup.
import resolve from 'rollup-plugin-node-resolve';
import commonjs from 'rollup-plugin-commonjs';
import babel from 'rollup-plugin-babel';
import { terser } from 'rollup-plugin-terser';
import filesize from 'rollup-plugin-filesize';
import typescript from '@rollup/plugin-typescript';
import sass from 'rollup-plugin-sass';

export default [
  {
    input: ['src/index.ts'],
    output: {
      file: 'build/index.js',
      format: 'esm',
      sourcemap: true
    },
    plugins: [
      sass({output:true}),
      typescript(),
      resolve(),
      terser(),
      filesize()
    ]
  },
  {
    input: ['src/index.ts'],
    output: {
      file: 'build/index.legacy.js',
      format: 'esm',
      sourcemap: true
    },
    plugins: [
      sass({output:false}),
      typescript({target: "es5"}),
      resolve(),
      commonjs({
        include: 'node_modules/**'
      }),
      babel({
        runtimeHelpers: true,
        presets: [
          [
            '@babel/preset-env',
            {
              useBuiltIns: false,
              modules: false,
              targets: {
                browsers: '> 1%, IE 11, not dead'
              }
            }
          ]
        ],
        plugins: ['@babel/plugin-transform-runtime']
      }),
      terser(),
      filesize()
    ]
  }
];

And in my index.html:
<!DOCTYPE html>

    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <meta http-equiv="X-UA-Compatible" content="ie=edge">
    <title>Web Components exploration</title>

    <link href="https://fonts.googleapis.com/css?family=Open+Sans:300,600&display=swap" rel="stylesheet">
    <link rel="preload" href="https://fonts.googleapis.com/css?family=Roboto:300,400,500" as="style" onload="this.onload=null;this.rel='stylesheet'">
    <link rel="preload" href="https://fonts.googleapis.com/css?family=Material+Icons&display=block" as="style" onload="this.onload=null;this.rel='stylesheet'">

    <link rel="stylesheet" type="text/css" href="./index.css">

FAB

    <mwc-fab icon="edit"></mwc-fab>
    <mwc-fab icon="add" mini></mwc-fab>
    <mwc-fab icon="shopping_cart" extended label="Add To Cart"></mwc-fab>
    <mwc-fab icon="share" class="blackAndWhite"></mwc-fab>

TEST WITH STYLE

So glitch is used for a different use case:
we don't want to minify or uglify it since the glitch demo is meant to be used as a dev playground. That's why it says es6, because it outputs an ES6 bundle (needs to be a bundle due to glitch's free-tier request maximums) and then @openwc's  es-dev-server` is the one that compiles the file at server-request-time.
We intended the github pages demo to be the production-optimized build where we precompile and bundle all of our deps, but as you can see, it seems as if we have a bug somewhere in minification.
Also there seems to be an issue in you index.html where the link rel="preload" performance trick does not work on IE since preload doesn't exist on IE onload will never be called. This is why we have the IE style transformer to change these into rel=stylesheet.
https://github.com/material-components/material-components-web-components/blob/master/demos/index.html#L34

Issue has been fixed in #1530 and #1539. Cause was likely the link rel preload shim I wrote.


Redirecting to the repo

I'm testing the code, followed the instructions, but I'm having a curious behavior where everything redirects to this repo. For example, when I try /detect, it does 302 redirect to this repo.
Am I missing something here?
edit
I checked the code and if I'm understanding it right, pageviews are sent to /p and timings to /t. The thing is that both of these are redirecting to the repo now. Curiously enough /ping works correctly.

The server checks HTTP Referer and ga in query.
https://github.com/giuem/ga-proxy/blob/master/server/router.go#L11

The server checks HTTP Referer and ga in query.
https://github.com/giuem/ga-proxy/blob/master/server/router.go#L11

Interesting. I just grabbed the url that redirects from the dev tools and it looks like this /t?plt=882&dns=0&pdt=3&rrt=0&tcp=0&srt=95&dit=513&clt=513&dt=example&de=UTF-8&ul=en-US&sd=24-bit&sr=2560x1440&vp=1647x1373&z=1561468053307. Does this look correct?

Found the problem. This was a page cache issue and now I can see ga parameters correctly set in the url. Thanks for your help!


In measures: When aggregating an empty collection of observation scores, issue warning instead of error

When learned parameters in iterative models diverge this leads to NaN. In such cases we want the model to stop gracefully (eg,  with use of InvalidValue() control). However in aggregating scores we apply a skipnan, which can lead to empty collections (all NaN). Instead of throwing an exception, I suggest we return NaN and issue a (suppressible) warning.

Okay, I realize that the aggregation methods like mean already work fine for empty collections 🙄 (mean returns NaN for empty collections) and so we just need to remove the necessary isempty trips. If a measure returns an object type for which mean and so forth doesn't work, then the error that is thrown is probably the most appropriate outcome anyhow.


Deeper integration with mesa

Currently there are some features that are only available in mesa (eg. visualization). While we work on refactoring those, we could have a "fallback" to convert on-the-fly a mesa-frames object to a mesa object and perform the operation. Performance would take a significant hit but it would allow for an easier transition from mesa.

The data to be fed to the Solara visualization is simply a list of list, or a 2D NumPy array. The relevant code is only <50 LOC. So it should take about a day to implement. It is a Matplotlib scatter plot.

The data to be fed to the Solara visualization is simply a list of list, or a 2D NumPy array. The relevant code is only <50 LOC. So it should take about a day to implement. It is a Matplotlib scatter plot.

I see, seems simple enough. I should look up a bit how solara works though.

You can assign this to me. Make sure we get Sugarscape for GSoC.


Can't execute first step for npm install

After cloning this repo, and try to execute npm install, it will pop up an error like below.
><EMAIL_ADDRESS>preinstall C:\Users\nqwang\Documents\github\testcafe-starter
> rimraf node_modules

'rimraf' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>preinstall: `rimraf node_modules`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>preinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR!      C:\Users\nqwang\AppData\Roaming\npm-cache\_logs\2018-10-26T06_05_13_257Z-debug.log

The reason is that computer doesn't have rimraf installed before executing npm install. It is better to update readme file to add this command npm install rimraf -g before npm install.

@hdorgeval It's my pleasure.

Hi @nqwang , this issue has been solved in v3.1.0


fix: return empty array of accepted issuers in trust manager

Issue
https://gravitee.atlassian.net/browse/APIM-6628
Description
Backport
Additional context

:tada: This PR is included in version 5.12.9 :tada:
The release is available on:

5.12.9
GitHub release

Your semantic-release bot :package::rocket:


Harbor UI can not correctly display the registry story capacity

I deploy the Harbor on k8s. No matter how much my actual storage is, Harbor UI always displays 10GB. But on VM, it can display the correct value.

No

Please use helm chart to deploy Harbor on k8s.

@reasonerjt My Harbor has been online. Can I solve this problem by modifying configuration? Thank you.


hyper +  doesn't seem to work

The following does work:
# focus window
hyper - h : yabai -m window --focus west
hyper - j : yabai -m window --focus south
hyper - k : yabai -m window --focus north
hyper - l : yabai -m window --focus east

# move window
cmd + shift - h : yabai -m window --warp west
cmd + shift - j : yabai -m window --warp south
cmd + shift - k : yabai -m window --warp north
cmd + shift - l : yabai -m window --warp east

but if I replace "cmd" with "hyper" in the second set of commands, it does not work. It seems that hyper +  doesn't work. Here, I've set up the hyper key via Karabiner.

hyper(cmd + shift + alt + ctrl) in skhd is different in Karabiner? A list of all built-in modifier and literal keywords of skhd can be found https://github.com/koekeishiya/skhd/issues/1#issue-248494406

@tshu-w  You're right.

I don't know much about the details, but with http://capslock.vonng.com modifications (via Karabiner-elements), a new Hyper key is created (replacing the Caps Lock) that acts as R Ctrl + R Opt + R Cmd + R Shift.
And, using this setup, hyper is treated somehow as a new key, and as such it can be mixed with other left modifiers to allow extra functionality like: Hyper + Left Cmd.
Can this be achieved in skhd? or is it possible to redefine skhd built-in Hyper definition to use right modifiers and leave left modifiers to further combine with hyper? Thx!

This is what I get when I hold down the Hyper key (the Caps Lock).

And something similar (just different flags) shows when I hold R Shift

that does not match the expected 38 for Shift according to https://github.com/koekeishiya/skhd/issues/1

I don't know much about the details, but with http://capslock.vonng.com modifications (via Karabiner-elements), a new Hyper key is created (replacing the Caps Lock) that acts as R Ctrl + R Opt + R Cmd + R Shift.
And, using this setup, Hyper can be mixed with other left modifiers to allow extra functionality like: Hyper + Left Cmd.
* Can this be achieved in skhd? or is it possible to redefine skhd built-in Hyper definition to use right modifiers and leave left modifiers to further combine with hyper? Thx!

P.S. I can think on things like "Move window to next space": Hyper + L Shift + L

I'd love to be able to do this as well.


Current song isn't very visible

Its not immediately obvious which song is playing from a list. as far as I can tell, the only think that indicates it is bolding of the dots between song name and song length. Maybe adding a background change and bolding all the text for the current song would be a good way to fix this

Fixed by #80


Add Zed location for Linux (Native/non-flatpak install)

Oh, thank you for your PR!
Can you describe why "~" doesn't work as home directory for NPath?
As I see you did try it but got some problems?

No, thank you for this whole project!
When I tried with “~” I didn't get any error, but Unity couldn't find Zed. It found it with NPath.HomeDirectory
Also, when I installed Zed from Manjaro's repo/store, it added it to a different location, so I wanted to add that too.


Get 'Error: no such option: --content-folder' when create book(Preview)

Azure Data Studio Version:
1.19.0
Steps to Reproduce:

Create Book(Preview)
When Running 'Create a new book' Cell, after input the book name and content folder I will get such error.

@pengyuehaha What values did you provide on destination and source input prompts?

I put C:\Book1 and C:\OSS\Spark\content. And the markdown files and notebooks are all under C:\OSS\Spark\content

Can you open Manage Packages (the last icon the notebook toolbar located at the top right corner) and in your installed packages list, can you scroll and check the version of jupyter-book installed.

It is 0.7.0

Ah, this is almost certainly because jupyter-book 0.7.0 has a breaking change with the folder structure, which we don't support yet.

As an alternative until we roll our changes to fix this, Please make sure to install jupyter-book version <= 0.6.4 before running/using this notebook to create a book. (You can install using the manage packages and selecting the version 0.6.4)


Apply Frequency-Specific Bdot Calibration (as option)

The effective area of a bdot probe changes with frequency. The current calibration method uses a fixed area, which is generally calculated (before hand) as the average effective area at low frequencies. The bdot calibration process does already return the effective area at various frequencies, we just don't use the extra information.
A more accurate calibration option would load the calibration data from a csv file. The FFT of the raw signal would be taken, and a vector of areas created where each area is the best match calibrated frequency to the corresponding FFT frequency bin. The calibration would be applied in k-space, then the iFFT would be applied before resuming the rest of the processing routine as usual.
Note that this would add considerable time to processing large datasets with many traces and/or many time indices, due to the cost of the DFFT algorithm.
@dschaeffer17

This issue is a long-term request: if someone has a current use-case where it would make a big difference I can prioritize it higher.

This is actually a considerably bigger issue than I thought.  Here is a sample bdot calibration curve:

The orange line represents the "constant calibration factor" assumption we are currently using. This clearly fails at 0.1 MHz. We can do a bit better by including the frequency dependence and fitting the data we already have for each probe (Eq. 7 Everson2009):

At this point, I think the disagreement is due to inductance effects in the Helmholtz coil. For future experiments that want measurements > 100 kHz, we should re-commision Erik's wire antenna. Retroactively, the best we can do is try and model the inductive effects in the Helmholtz coil to get a better fit?
However we end up doing this, I will write a fitting routine for the solution and add it as part of this package. I think the correct thing to do would be to add keys in the CSV file for each coil's inductance (tau_s in Erik's paper) after the ones that are there for the area. bdotRawToFull can then decide whether to apply the low frequency or high frequency calibration formula based on which constants are provided.

Actually those plots were of magnitude, not the real part of the signal (which is what the functions are for). Using the correct part, the agreement from the Helmholtz coil is perfect up to 5 MHz.

Created a function for fitting the raw calibration data and extracting the necessary constants. Area is extracted just from the low frequency part of the signal, then tau_s is calculated from a fit of the whole thing.
Interesting problem: the tau_s values seem reasonable (my back-of-the-envelope calculation says it should be ~7 us for a 3mm 10 turn bdot), but for some reason they are negative? Not sure what's going wrong there.

Implementation of the integration algorithm described in Eq. 10 of Everson2009 has been completed in a development branch. The changes to the bdot signal are drastic. Here is a trace of some RHI waves analyzed with just the LF calibration:

Notice the prevalence of the the lower frequency component, and the total amplitude of ~ 3G. Now see the same trace with the HF calibration:

The high frequency waves are MUCH bigger (800 G!), which seems too good to be true. The lower frequency waves have shrunk in relative proportion. If I were to plot more time, the shear wave is not even visible relative to these waves.
For this probe and channel, the calibration parameters I'm using here are area = 11 mm^2 and tau_s = 19594 ns. The area is reasonable, the tau_s is ~2x larger than I estimated it should be (so not unbelievable).

I re-calculated tau_s  and got a more reasonable value (~60 ns): I realized I had been using the coil resistance rather than the load resistance before. With this moderate value, the waves in the ~ 1-10 MHz wave are ~2x the amplitude, and the low-frequency shear wave (~100 kHz) is slightly diminished (~15 G). That seems reasonable to me, if it's correct.
I'm still not sure why my fitting routine doesn't work, but it seems to me that tau_s can't really be determined independent of the time delay tau from the Helmholtz coil calibration test. Maybe the straight-wire antenna test is necessary to correctly measure tau_s?

I have now implemented a working calibration fitting routine using Eq. 5 from Everson 2009 (and limits thereof, eg. Eq. 7). This routine currently assumes that a Helmholtz coil is being used: I'll write another parallel routine for straight wires once we've done that test. The Helmholtz coil seems to be good to 2-3 MHz.
Here is a sample output plot and printout (this is for LAPD7, a 3 mm 10 turn bdot):
**** Bdot Calibration Report *****

xarea: 11.243 mm^2
xtau: 34.851 ns
xtdelay: 25.043 ns

yarea: 10.562 mm^2
ytau: 35.64 ns
ytdelay: 25.242 ns

zarea: 15.018 mm^2
ztau: 35.403 ns
ztdelay: 26.093 ns

This question seems to be resolved, so I'm going to close this issue.


Add deregister_toolkit method

#468

[ ] Maybe add round-trip tests?
[ ] Maybe add tests using GLOBAL_TOOLKIT_REGISTRY (codecov counts the relevant lines of code as tested, but I think they're only ever called by things that use this: grep -R "GLOBAL_TOOLKIT_REGISTRY" openforcefield/tests/ comes up empty; related #493)
[x] Tag issue being addressed
[x] Add tests
[ ] Update docstrings/documentation, if applicable
[ ] Update changelog

Codecov Report

Merging #614 into master will decrease coverage by 9.71%.
The diff coverage is 15.38%.

I bumped this up in priority since it's been desired multiple times in recent memory. I've merged in the other 0.7.0 changes, updated tests and docstrings, and also catch the case of attempting to deregister an un-registered toolkit. I believe this is ready for review now.
I've completely punted on retooling GLOBAL_TOOLKIT_REGISTRY since I want to get this feature out sooner and the two changes should be mostly de-coupled from each other.
Tangentially, the toolkit wrappers could probably do with a __str__ or __repr__ override to make things like this a little prettier:
In [4]: registry = ToolkitRegistry(toolkit_precedence=[AmberToolsToolkitWrapper])

In [5]: registry.deregister_toolkit(RDKitToolkitWrapper)
---------------------------------------------------------------------------
ToolkitUnavailableException               Traceback (most recent call last)
<ipython-input-5-0e9acceb2423> in <module>
----> 1 registry.deregister_toolkit(RDKitToolkitWrapper)

~/software/openforcefield/openforcefield/utils/toolkits.py in deregister_toolkit(self, toolkit_wrapper)
   4348                     f"Currently registered toolkits are {self._toolkits}"
   4349                 )
-> 4350                 raise ToolkitUnavailableException(msg)
   4351
   4352         for toolkit_to_remove in toolkits_to_remove:

ToolkitUnavailableException: Did not find <openforcefield.utils.toolkits.RDKitToolkitWrapper object at 0x129036750> in registry. Currently registered toolkits are [<openforcefield.utils.toolkits.AmberToolsToolkitWrapper object at 0x111610990>]

In [6]: registry.registered_toolkits
Out[6]: [<openforcefield.utils.toolkits.AmberToolsToolkitWrapper at 0x111610990>]

I could probably sneak that in here - but when I say that, it typically works to not be true after trying it.


[Feature Request] Sticky elements?

Existing Component
No
Component Name
Sticky element
Description
Is there a way to implement sticky elements inside of a el-main container?

.sticky {
position: sticky;
top: 0;
}
In the example above, I added the css required for sticky to work but it isn't working. I'm assuming that the el-main caused this issue and unless I remove all element.io layout containers, it wouldn't work. Do you have any clue how I can implement a sticky element?

Many browsers don't support sticky https://caniuse.com/#search=sticky
If we add this component, we have to use polyfill. So we have no plan to support this.


Adding css to film component

Hello C10-Ghibli Team!
This PR solves #7 feature.

Adding css to film component
The test of the film component pass
This PR has coverage files, but those files were added in a before commit in the branch that I was working on.

Changes were done.


Correct answer not accepted

Challenge http://www.freecodecamp.com/challenges/bonfire-sum-all-primes has an issue. Please describe how to reproduce it, and include links to screenshots if possible.
I was able to successfully pass this challenge using a naive solution (using simple loops); however, when executing a more complex solution a bug arises:

Notice that the function returns the correct solution; yet, the challenge fails to accept it. Notice as well that the test suite [on the left] prints expected 32 to equal 17 -- which should not be the case.
Here is the full code (which elicits the bug):
var arrayOfPrimes = [];
var sum_ = 0;

function isPrime(x){
  /*if x is prime return true, else return false */

  // check for primality:
  for(var i = 0; i < arrayOfPrimes.length; i++){
    if(x % arrayOfPrimes[i] === 0){
      return false;
    }
    //sieve of eratosthenes property:
    if(arrayOfPrimes[i] > Math.sqrt(x)){
      break;
    }
  }
  return true;
}

function sumPrimes(num) {
  for(var i = 2; i <= num; i++){
    if(isPrime(i)){
      arrayOfPrimes.push(i);
      sum_ += i;
    }
  }
  return sum_;
}

sumPrimes(10);

I can't figure out what's going on here, but I can confirm.
My code passes, but this code does not, even though it produces the right values when run in the console. Something about this solution seems to be causing the test cases to add 15 to value returned.

if we remove the following code
if(arrayOfPrimes[i] > Math.sqrt(x)){
break;
}
the tests pass, I don't know why though

You are correct in that modifying
if(arrayOfPrimes[i] > Math.sqrt(x)){
	break;
}

to compare only the index value, i, circumvents the error. However, the original solution returns the correct result, and therefore the issue isn't really solved as to why the bug arises.

loop index i should be compare to sqrt(x)

Also, as an aside, the correct (i.e. optimal) solution should be using arrayOfPrimes[i], not the loop index, i, for the conditional statement. C.f. Sieve of Eratosthenes. Both will return the same answer, but using arrayOfPrimes[i] will return the answer quicker because it is iterating through the list of prime numbers and checking if any of the known primes are divisors.

Hey @Ogodei it looks like this is a scoping issue.
You declare and initialize:
var arrayOfPrimes = [];
var sum_ = 0;

before the functions run, so it works for the first test but when the second test runs, those variables need to be reinitialized.
The following is a slightly modified version of your code that passes all tests.  Notice the variables are declared at the top but initialized in the main sumPrimes function (this function is what the tests are calling):
var arrayOfPrimes;
var sum_;

function isPrime(x){
  /*if x is prime return true, else return false */

  // check for primality:
  for(var i = 0; i < arrayOfPrimes.length; i++){
    if(x % arrayOfPrimes[i] === 0){
      return false;
    }
    //sieve of eratosthenes property:
    if(arrayOfPrimes[i] > Math.sqrt(x)){
      break;
    }
  }
  return true;
}

function sumPrimes(num) {
  arrayOfPrimes = [];
  sum_ = 0;
  for(var i = 2; i <= num; i++){
    if(isPrime(i)){
      arrayOfPrimes.push(i);
      sum_ += i;
    }
  }
  return sum_;
}

sumPrimes(10);


Horizontal space?

Regex library recently added support for \h. Something I didn't quite expect. We ruled this out earlier as it seems weird to add \h and not \v because Python already supports \v as a vertical tab instead of vertical whitespace. I was pretty certain they weren't going to add anymore references, and yet, here we are.
It's no secret that we have adopted most of the practical and most useful back references that are in regex and applied them to re. Now, you can easily represent \h with [\t\p{Zs}] or even [[:blank:]].
Do we add that for re as well? It's easy to do as it's just mapping \h to [[:blank:] 🤷 . In environments that it's a pain to install a non pure python module, it's nice to have some consistency. So maybe we will even though we previously ruled it out.

So, I just realized, we added \R to both regex and re which basically covers \v. The only difference is that \R treats \r\n as a single character while \v doesn't, which I generally think is fine. It is rare that someone wants to target just \r when dealing with a broad white space match. If you want a single \r, usually you are specifying \r specifically. So I think we are okay here.
I think this is reasonable to add to re moving forward.


Several questions about the code

Hi, I appreciate your sharing this project! It is a very thoughtful work and friendly to newers!
I have some questions when reading the code.

In dataset.py
Instead of writing:
new_instances = [i for i in self.instances]
return self.__class__(new_instances[:max_instances])

Why don't you write:
return self.__class__(self.instances[:max_instances])

At dataset.py line 180:
        label_counts = [(label, len([x for x in group]))
                        for label, group
                        in itertools.groupby(labels, lambda x: x[0])]
        label_count_str = str(label_counts)
        if len(label_count_str) > 100:
            label_count_str = label_count_str[:100] + '...'
        logger.info("Finished reading dataset; label counts: %s",
                    label_count_str)

Why do you do above process?
Correct me if i am wrong: (FAKE EXAMPLE)
>>label_counts
[(0,300),(1,300),(2,300)]
>>label_count_str
'[(0,300),(1,300),(2,300)]'

300 is the number of times a specific type of label appears
I don't understand why all these steps mean for? How can this calculate labels counts?

In sts_instance.py line 108:
Instead of writing:
fields = list(csv.reader([line]))[0]
Why not writing:
fields = [x for x in csv.reader([line])]
I run a trial:
>>> field = list(csv.reader(['asdf','fddf','ddd']))
>>> field
[['asdf'], ['fddf'], ['ddd']]
>>> field[0]
['asdf']

It seems  list(csv.reader(['asdf','fddf','ddd']))[0]  can't be used to count the number of fields? Correct me if i am wrong.
4.Why create character-level dictionary/instance?
When you tokenize the string 'Today has a good weather' to character level, the result would be ['T','o','d','a','y','h','a'............]
The character-level seems can't be used to encode contextual information?
Could you tell me some cases where character-level tokenization plays a difference?
Thank you!

return self.__class__(self.instances[:max_instances])

good question, I think that would work as well! I'm not too sure why I wrote that first code, sorry :)

labels counts

This code doesn't actually do anything functionally with the label counts, it's just used to print to the console the approximate count of each label.

I think you got the input format wrong, it should be like this:

In [1]: import csv

In [2]: field = list(csv.reader(['asdf,fddf,ddd']))[0]

In [3]: field
Out[3]: ['asdf', 'fddf', 'ddd']

In [4]: fields = [x for x in csv.reader(['asdf,fddf,ddd'])]

In [5]: fields
Out[5]: [['asdf', 'fddf', 'ddd']]

There's a pretty rich literature of using character-level models to get rid of out of vocabulary words / get meaningful representations for novel or rare words. If you're interested in this, these papers might give a good overview:

End-to-end Sequence Labeling via Bi-directional LSTM-CNNs-CRF
Finding Function in Form: Compositional Character Models for Open Vocabulary Word Representation
Mimicking Word Embeddings using Subword RNNs
hope that helps!

In instance.py line 80:
    def _index_text(self, text, data_indexer):
        """
        This function uses a Tokenizer and an input DataIndexer to convert a
        string into a list of integers representing the word indices according
        to the DataIndexer.

        Parameters
        ----------
        text: str
            The label encodes the ground truth label of the Instance.
            This encoding varies across tasks and instances.

        Returns
        -------
        index_list: List[int]
           A list of the words converted to indices, as tokenized by the
           TextInstance's tokenizer and indexed by the DataIndexer.

        """
        return self.tokenizer.index_text(text, data_indexer)

I thought the  text here is tokenized sentence, not the ground truth label written in the comment?
Why not directly using self.tokenizer.index_text() instead of using self._index_text() ?

1). I thought the text here is tokenized sentence, not the ground truth label written in the comment?

Whoops, you're right. looks like the docstring is wrong, sorry about that

2). Why not directly using self.tokenizer.index_text() instead of using self._index_text() ?

The base instance class defines a self._index_text(), and I thought it would be better to just keep a consistent API throughout. Some instances might have more elaborate definitions of this function.

3). _words_from_text(self, text) is defined, but seems never be used?

I took the instance API from https://github.com/allenai/deep_qa, I think that's part of the API there.

If you wanna encode the question which is at the end of a sequence, you should truncate it from left?

This was another copy-paste error from deep_qa, sorry. I that truncating from left makes more sense for QA, but in this code I preferred to truncate from right since I suspect that the subject / salient information of the sentence would be closer to the front. This is just my intuition though.

Hi, Nelson!
How do you think about moving index_text function in word_tokenizer.py to instance.py.
Because this function does no tokenize thing so it would be better not in the "word_tokenizer"?


talent page in progress

employerSignup
employer signup and login
added a test
fixed
talent page design
talent page design in progress
still styling

Can you fixed the checks so I can merge the PR?

@jojothomas1515 we shouldn't merge this PR yet?


Add container lifecycle events to ItemsControl.

What does the pull request do?
Before #9677 we had materialized/dematerialized events for item containers (even though the API was pretty confused). They were removed as part of #9677 mostly to see if anyone missed them, but with the anticipation that we'd probably want to add them back. Turns out that they were being using on 0.10.x and people do miss them ;)
This PR adds them back in a slightly more sane form. The events follow the pattern used by ItemsRepeater, meaning that we have 3 new events on ItemsControl:

ContainerPrepared is raised each time a container is prepared for use. The prepared container might be newly created or an existing container that is being re-used.
ContainerIndexChanged is raised for each realized container where the index for the item it represents has changed. For example, when another item is added or removed in the data source, the index for items that come after in the ordering will be impacted.
ContainerClearing s raised immediately each time an container is cleared, such as when it falls outside the range of realized items or the corresponding item is removed

You can test this PR using the following package version. 11.0.999-cibuild0031943-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

Is there a 1:1 equivalence between old Materialized/Recycled/Dematerialized events and the new ones?

Close, yes.
Materialized = ContainerPrepared
Recycled = ContainerCleared followed by ContainerPrepared
Dematerialized = ContainerCleared


bad c++ autoindent when a { inside comments

I found vim is not indenting correctly/reformatting my cpp file correctly when a '{' is present inside a comment. Like the
int main(){
    cout<<"Hello World"<<endl;
    if(1){
        if(1){
            //if(){
            cout<<"Hello World"<<endl;
        }
    }
        // if you insert a line from here, it will be indented here
}

int haha(){

}

and when I gg=G, I got
int main(){
    cout<<"Hello World"<<endl;
    if(1){
        if(1){
            //if(){
            cout<<"Hello World"<<endl;
            double a=1.5;
            cerr<<"   "<<fabs(a)<<endl;
        }
        }
        // if you insert a line from here, it will be indented here
    }

    int haha(){

    }

I'm using the following .vimrc
set nocompatible              " be iMproved, required
filetype off                  " required
" set the runtime path to include Vundle and initialize
set rtp+=~/.vim/bundle/Vundle.vim
call vundle#begin()
" alternatively, pass a path where Vundle should install plugins
"call vundle#begin('~/some/path/here')

" let Vundle manage Vundle, required
Plugin 'VundleVim/Vundle.vim'

" start of my plugins
Plugin 'scrooloose/NERDCommenter'
Plugin 'Tabular'
Plugin 'vim-scripts/matchit.zip'
Plugin 'vim-scripts/restore_view.vim'
"Plugin 'WolfgangMehner/vim-plugins'

" All of your Plugins must be added before the following line
call vundle#end()            " required
filetype plugin indent on    " required
" To ignore plugin indent changes, instead use:
"filetype plugin on
"
" Brief help
" :PluginList       - lists configured plugins
" :PluginInstall    - installs plugins; append `!` to update or just :PluginUpdate
" :PluginSearch foo - searches for foo; append `!` to refresh local cache
" :PluginClean      - confirms removal of unused plugins; append `!` to au
to-approve removal
"
" see :h vundle for more details or wiki for FAQ
" Put your non-Plugin stuff after this line

set wildmenu
set showcmd

" Use case insensitive search, except when using capital letters
set ignorecase
set smartcase
set laststatus=2
set vb
"set nostartofline

set autoindent
set showmatch
set incsearch
syntax enable
syntax on
set hlsearch
set background=dark
let g:solarized_termcolors=256
colorscheme solarized

" foldings
"set foldmethod=syntax
"set foldlevel=1
"set foldnestmax=1
"autocmd BufWinLeave *.* mkview
"autocmd BufWinEnter *.* silent loadview
"set foldignore=

set expandtab
set softtabstop=4
set shiftwidth=4
let mapleader = ","

please remove //if(){ or put } like //if(){}.

@mattn Thanks. Yes, the problem happens here. But if I want to reformat a code given by others, or try some other if conditions, then I suppose vim should not behave like this.
Also they wrote a matchit plugin for same issue for % sign.

Yes, the problem happens here. But if I want to reformat a code given by others, or try some other if conditions, then I suppose vim should not behave like this.

If you are going to change others code, you can as well just remove rubish in comments, can't you?


nixos: add --specialisation to nixos-rebuild

Description of changes
This commit fixes a papercut in nixos-rebuild where people wanting to switch to a specialisation (or test one) were forced to manually figure out the specialisation's path and run its activation script - since now, there's a dedicated option to do just that.
This is a backwards-compatible change which doesn't affect the existing behavior, which - to be fair - might still be considered sus by some people, the painful scenario here being:

you boot into specialisation foo,
you run nixos-rebuild switch,
whoops, you're no longer at specialisation foo, but you're rather brought back to the base system.

(it's especially painful for cases where specialisation is used to load extra drivers, e.g. Nvidia, since then launching nixos-rebuild switch, while forgetting that you're inside a specialisation, can cause some parts of your system to get accidentally unloaded.)
I've tried to mitigate that by improving specialisations so that they create a dedicated file somewhere in /run/current-system containing the specialisation's name (which nixos-rebuild could then use as the default value for --specialisation), but I haven't been able to come up with anything working (plus it would be a breaking change then).
Closes https://github.com/NixOS/nixpkgs/issues/174065
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[x] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Could you provide with the failed NixOS test so we can maybe help to fix it together?

Could you provide with the failed NixOS test so we can maybe help to fix it together?

I've gotten stuck with the basic idea of the test, since it looks like I can't just run nixos-rebuild switch there (because VM's /nix/store is read-only + it doesn't have any channels configured); I've taken a look at at nixos/tests/installer.nix and nixos/tests/os-prober.nix, but I've failed to understand the magic that makes them work 😅
So I guess something very basic could be:
import ./make-test-python.nix {
  name = "nixos-rebuild";

  nodes =  {
    machine = { ... }: {
      #
    };
  };

  testScript = ''
    machine.wait_for_unit("default.target")

    # TODO create /etc/configuration.nix (+ hardward-configuration.nix?) with
    #      multiple specializations; make following work:
    machine.succeed("nixos-rebuild switch --specialisation-name foo")
  '';
}

Could you provide with the failed NixOS test so we can maybe help to fix it together?

I've gotten stuck with the basic idea of the test, since it looks like I can't just run nixos-rebuild switch there (because VM's /nix/store is read-only + it doesn't have any channels configured); I've taken a look at at nixos/tests/installer.nix and nixos/tests/os-prober.nix, but I've failed to understand the magic that makes them work sweat_smile
So I guess something very basic could be:
import ./make-test-python.nix {
  name = "nixos-rebuild";

  nodes =  {
    machine = { ... }: {
      #
    };
  };

  testScript = ''
    machine.wait_for_unit("default.target")

    # TODO create /etc/configuration.nix (+ hardward-configuration.nix?) with
    #      multiple specializations; make following work:
    machine.succeed("nixos-rebuild switch --specialisation-name foo")
  '';
}

If I provide you with a working baseline for the test, can you write the Python script? You can check systemd-boot.nix test which is interesting for your usecases.

I know how those tests work in general (and I've written a few before), I'm just having a problem with this particular setup - so if you manage to provide some foundation, I should be able to work on that 🙂

but I've failed to understand the magic that makes them work

I think the magic you're looking for is installation-device.nix? That should at least take care of channels.
https://github.com/NixOS/nixpkgs/blob/ead8d4e9a04a6c821ff0d4b893745ffa6cb74bbe/nixos/tests/installer.nix#L286-L287

Okie, thanks, I'll look into it 🙂

Okie, I've changed --specialisation-name into just --specialisation and added a test 🎉
The test still needs a minor clean-up (I've just copy-pasted system.extraDependencies from os-prober.nix and I feel like they could get shortened), but I think it's mostly ready.

kk, test minimized 🙂

@ofborg test nixos-rebuild-specialisations

The aarch64 failure seems unrelated to this PR.

@Patryk27 I think this PR is good to go, there's some style changes to be done on it (trailing whitespace), can I let you take care of them?

Oh my, fixed! 😇

Would it be possible to make --specialisation work for build-vm as well? I assume some logic needs to be added to nixBuild/nixFlakeBuild?

On the top of my head, I think it should be possible; I myself have no time to prepare such change now, though :cry:


Missing "Select a Report" dropdown?

I do not see the "Select a report" dropdown as mentioned on this page.  The admin page I am on is https://admin.microsoft.com/Adminportal/Home?#/reportsUsage

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e70e9c6c-8b88-9be4-5ce7-90338685ce95
Version Independent ID: 755db873-a694-b50c-9478-eeb979dcf4cc
Content: Microsoft 365 Reports in the admin center - Email apps usage - Microsoft 365 admin
Content Source: microsoft-365/admin/activity-reports/email-apps-usage.md
Service: o365-administration
GitHub Login: @KwekuA
Microsoft Alias: kwekua

@ScottBeeson Thank you for your feedback. There have been some changes recently and we will update the document accordingly.
@kwekuako The Email apps report is not available anymore under usage. Do you know if the product team is working on this or is this document is not relevant anymore?
Thanks
Sri

@msbemba Looking into this. Will let you know. Definitely looks like the UI has been updated.

@msbemba Looking into this. Will let you know. Definitely looks like the UI has been updated.

@kwekuako Please help us in resolving this issue. Thanks

@kwekuako Gentle reminder, please resolve this. Thanks

@yogkumgit, looks like its been resolved. I don't see that text in the topic anymore.

@msbemba Thank you very much for the contribution and sharing this explanation. @ScottBeeson Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


tests: Add unit tests for ui_init.js.

This test tries to find obvious dependency bugs, but
it really doesn't do anything other than fail when
it tries to use unavailable resources.

Looks reasonable; since this is a relatively high-maintenance test (in terms of needing to edit when we add a new module), we'll have to find out in real life whether it ends up catching mistakes often enough to be worth the cost of "another checklist item when extracting a module".  Happy to try the experiment for now :).


update from v1alpha1 to v1alpha2 for some docs and samples

What this PR does / why we need it:
After I installed the last KFServing, and try to deploy KFService using sample, but failed due to the mismatched version. The PR is to update from v1alpha1 to v1alpha2 for some docs and samples.

This change is

/assign @yuzisun
Please take a look, thanks!

/retest

/hold
Wait for #300 so that samples can be updated to account for the breaking change?

/hold
Wait for #300 so that samples can be updated to account for the breaking change?

Agreed, let's hold this until v1alpha2 changes are finalized.

/hold

/hold cancel
Since #300 has been merged.

/hold
I've made most of these changes in #327 as well as part of modifying the files to use storageUri instead of modelUri..

@jinchihe we can close this now. @rakelkar did it in https://github.com/kubeflow/kfserving/pull/327


filebrowser version outdated

Hello.
There are many fixes, pls update to filebrowser/filebrowser:v2.28.0

I'll bump when I make a new release, but making a new chart release is not necessary for that, you can just bump the image tag in values.


docs: use latest doc translations

The documentation is old and needs to be updated.

Thanks for the doc updates! Merged


[Bug Report] Timeout preventing videos from loading

Bug Description
A timeout prevents some videos from loading.
Examples of videos not working:

https://youtu.be/u4DXqKV0Wtk
https://www.youtube.com/watch?v=GO--mdbQDcg

At first I thought it was due to video length, but these work.

https://www.youtube.com/watch?v=NtqRjGP3uoY
https://www.youtube.com/watch?v=AgpWX18dby4

Steps to Reproduce

Deploy bot
Request bot to play,  https://youtu.be/u4DXqKV0Wtk

Expected Result
I expected the video to play
Debug Output
[01:31:47] [ERROR] [LocalAudioTrackExecutor]: Error in playback of u4DXqKV0Wtk
com.sedmelluq.discord.lavaplayer.tools.FriendlyException: Something broke when playing the track.
at com.sedmelluq.discord.lavaplayer.tools.ExceptionTools.wrapUnfriendlyExceptions(ExceptionTools.java:44)
at com.sedmelluq.discord.lavaplayer.track.playback.LocalAudioTrackExecutor.execute(LocalAudioTrackExecutor.java:116)
at com.sedmelluq.discord.lavaplayer.player.DefaultAudioPlayerManager.lambda$executeTrack$1(DefaultAudioPlayerManager.java:348)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
at java.base/java.lang.Thread.run(Thread.java:1589)
Suppressed: com.sedmelluq.discord.lavaplayer.tools.exception.EnvironmentInformation:
lavaplayer.version: 1.3.78
os.arch: amd64
os.name: Linux
os.version: 5.15.0-83-generic
java.vendor: Amazon.com Inc.
java.version: 19.0.2
java.runtime.version: 19.0.2+7-FR
java.vm.version: 19.0.2+7-FR
Caused by: java.lang.RuntimeException: java.net.SocketTimeoutException: Read timed out
Additional Info
The preferable solution would be adding a config variable or environment variable to adjust this timeout.
Checklist

[X] I have looked for information about this within the documentation
[X] I have searched for similar issues on the issues page
[X] I am running the latest version of the bot:

Hey ! Can you try another LavaPlayer Library?
Maven:
        <dependency>
            <groupId>dev.arbjerg</groupId>
            <artifactId>lavaplayer</artifactId>
            <version>2.0.2</version>
        </dependency>


fix typo

Hi @jamesandersen, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@jamesandersen : Thanks for your contribution to the Azure documentation! The author, @garyericson, has been notified to review your proposed change.

Thanks for spotting this. It was a little confusing like this. :-) #sign-off


Integration tests for common runtimes

I'm currently in the process of spending some spare time improving the structure of this repository. Ideally I want us to get to the point where we have three things:

a native esm friendly version of the repository (not just relying on the nodejs dual module system)

the index.d.ts generated automatically using tsc --emitDeclarationOnly.

a singleton instance of Replicate as the default export for the package so our examples can be as simple as:
const replicate = require("replicate");
replicate.run(...);

I'll follow up on this one in a second PR with more details and we'll still retain the constructor as a way of customizing the library.

This commit adds some basic integration tests and a new ci workflow for our three common runtimes, nodejs with commonjs and esm as well as TypeScript. The aim here is to ensure that the interface is consistent even if we refactor/restructure the package.
The change does require a REPLICATE_API_TOKEN to be available in the CI environment which I've added.

singleton instance

😍


Standard Structure for README.md in each WG repo

Hi everyone,
While standardizing the repositories, I noticed that the README file of each working group has a different structure. After discussing with @GeorgLink, I have drafted a proposal for a common structure that can be implemented across these README files. I have also replicated the same as a template.
Link: https://docs.google.com/document/d/1pfipIiaemdtdiDQpvY7jOKhKzsv_3lXLLsbJiByl5GU/edit?usp=sharing
Please provide your thoughts and suggestions regarding the proposal.

I have updated the readme as per the new standard template in the google doc (https://docs.google.com/document/d/1fQ0N3Pkv5qOXvzgF-9PuoDMafsmkh2DMPb0HTL665ps/edit) if it reads well I can create a pull request to update the readme.
Note: I have added @sgoggins as one of the chairs. Need to to add another wg chair to the readme.

@yash2002109 , can you please take a look at the repo and let us know here if there is anything still missing before we can close this issue?

Thanks @GeorgLink
I think we still need a PR to update the README.
@vinodkahuja, I see that the google doc has already been created. Could you please create a PR for this?

Thanks @yash2002109. I see @vinodkahuja made a proposal and we need someone to create a PR now. We can leave this issue open until someone can pick this up.

@GeorgLink I am ready to create a PR for this. I just need a confirmation from the WG. @sgoggins can you take a look and confirm. Also, provide a second chair for the WG.

LGTM.


Return number of input tokens when details=True

We return the number of generated tokens when details=True, but systems like OpenAI API also return the number of input tokens. This i useful, for example, for metering systems that limit users based on number of input + output tokens.
Current:
'details': {'generated_tokens': 20}

Proposal:
'details': {'prompt_tokens': 120, 'generated_tokens': 20}

@tgaddair Hi there ! I am a new contributor to this repository and would love to contribute by solving this issue. Could you please assign this issue to me ?


Update workspace status state once push has finished

The workspace status doesn't update from pushPeerState once the push is complete, causing the frontend to show an incorrect status message. See screenshot below. No runner is connected but the frontend shows that the runner is pushing back to the hub.

Bumped to high/high as our Dotscience SaaS users seem to be getting confused by this.


Move internal output to INFO level

Prevent client applications from having to deal with text being forced
to their stdout by using INFO rather than fmt for output.
I wanted to prevent JWW from output text in my application, this seemed like the easiest way. The other idea I had was a SilenceInternalOutput() method which would disable any fmt.Println() calls, while not breaking any existing applications which might enjoy the fact that they were getting "Logging to file ..." messages in their stdout. Would be happy to rework to that if preferred.

merged as c2aa07d


pacing doesn't properly work

The trace was recorded with an RTT of 100 ms. Obviously, packets should be sent a lot slower.

The problem is that congestion.SendAlgorithm.TimeUntilSend() calculates the pacing delay for the next byte to be sent, and we interpret this as the time for the next packet to be sent (without adjusting for the fact that a packet is much larger than a single byte).


Setting fields to nil now causes null in resulting serialized data

Hi there, I recently attempted to update to v1.5.5 and started getting server errors with the message were unable to deserialize when posting a calendar event
This error is consistently reproducible if you do the following:

create some graph SDK model, for this example we'll use an event
create a body for the event
update the event body with body.SetOdataType(nil)
POST the event to microsoft's graph endpoint like you're making a new event instance
get above error response back

Digging into this a bit more, I found a difference in the serialized data output that's sent to the graph servers. v1.5.4 doesn't add fields set to nil to the request being made. v1.5.5 adds fields set to nil to null (in our example you end up with "odataType": null in the request for the body of the event). Setting other fields to nil in the code also results in the request having them set to null
While I realize that setting the odata type in code is probably looked down on, it does make it more difficult to manage these objects as in some cases my team and I are taking an object, copying it's data to a new object, and then modifying some of the fields in the new object. It'd be preferable if the code didn't have to differentiate between what field it's copying over (i.e. explicitly avoid copying the odata type field since just not setting the odata field at all seems to avoid the server error)
As for how we got an object with a nil odata type as the source of our copy: we were deserializing a previously serialized version of the object
Sending nulls is also a bit concerning because it requires additional data bytes to be transferred when sending a request. While not a huge issue for one or two requests, the amount of additional data required could add up over time

Hi @ashmrtn,
Thanks for using the Go SDK and for reaching out.
This is intentional so people can reset values on APIs (a commonly used pattern).
The serialization infrastructure should only be sending nulls when:

the object has been previously obtained from the API.
a property has explicitly been set to nil by the application.
the object is being sent back to the API.

Which seems to match your case to some extent.
Can you share a snippet of code of how the copy is done today in your application?

We're using the graph SDK in an open source project called Corso which is meant to backup and restore M365 data for users. Our end goal with the bit of code we're working with is to get an object model that we can send to microsoft to create a new version of the object with a distinct ID from the original object. In the example, fields we're clearing are ones that will either cause server issues (found through experimentation) or are ignored by the server and don't need to be sent (except maybe the odata type, though that was never an error before)
Right now we're doing the copy by manually selecting the fields (some of which need cleared, others of which are just pulled from the original). I was sort of hoping to switch this copy to something better in the future by maybe using reflection to avoid having to pick and choose which fields are copied over as that seems error prone if the API expands. Doing a manual copy requires intimate knowledge of the API, how it evolves over time, and which fields are important and need selected

Thanks for the additional context here. This is a bit of a specific scenario compared with the typical usage.
For the properties you want to reset without sending null to the API, you could do something like that.
myModel.GetBackingStore().SetInitializationCompleted(false);
myModel.SetProperty(nil);
myModel.GetBackingStore().SetInitializationCompleted(true);

Let us know if you need anything else.

is this going to be the only way to handle this going forward? I'm a little concerned that it's going to make it difficult to write correct code since it requires special handling of some fields and it's not necessarily clear when special handling should be used and when it shouldn't. As there's no written documentation for how to handle this or why it needs to be handled that way, correctness would rely on the code author and/or the code reviewer having the tribal knowledge that that's the proper way to do things
If my understanding of the various SDK libraries and HTTP CRUD operations is correct, the recent update to this library would mostly be applicable to PATCH requests right? I could see some cases where needing to set a field to null could be important to clear a default value when creating a new object (POST), but it seems far more likely to be used during item updates (PATCH)

Yes this is the main scenario we've designed this for:

GET an object.
Reset a property by setting it to null.
PUT or PATCH the object back to the service to reset the property there.

Although this is discouraged by REST guidelines, nothing prevents an API provider from using post for update purposes. This is especially true when the update requires additional ephemeral parameters. For example an update meeting endpoint that would take the meeting + a couple of parameters like "send update email notification" etc.
Finally, the serialization infrastructure doesn't have knowledge of what http method is in use, those are orthogonal.
Because these accessors are exposed by the Backed model interface, you should be able to come up with a generic solution that can be applied to all models types.
The alternative being to generate your own Microsoft graph client using kiota, without the baking store if you want.

I've been working on updating the code my team maintains using the workaround you suggested. However, I'm a bit confused as to when I need to use the workaround you suggested and when I don't. For example, should I only be using it if setting a field to nil? Is there some form of documentation explaining that information?

Thanks for the prompt, I have created an issue in our documentation repository
I'd say you'd need to implement the workaround (assuming we're talking about switching the flags for the backing store and not generating your own client without the backing store) any time you:

get an object from the API.
set one of it's properties to null.
send the object back to the API BUT you don't want that property to be sent as null on the payload.

Hopefully that clarifies the scope.

yes, that info is super helpful! You're right that I was talking about switching the flags for the backing store and sorry for not clarifying that initially
Thanks for also creating an issue for adding documentation around this. It'll be good to be able to point other engineers on my team to it if/when needed


Importing package from GitHub directly doesn't allow opening the Demo Scene

If we try to add the package via the GitHub link, it will install as a private package, preventing us from opening the  demo scenes.
Functionality itself seems to work fine though

Could reproduce it Tracking ticket internally via MP-2969.

Until we fix this pleas download the package from https://github.com/MindPort-GmbH/VR-Builder/releases and import it via Assets->Import Package.
Note: If you have imported the git package you need to remove it first before adding the unity package via Import Package.