ISerializationCallbackReceiver not found in Interface fsISerializationCallbacks

Using Unity 5.2.2, copied "Source" directory to project's Asset folder, receiving these errors:
Severity	Code	Description	Project	File	Line
Error	CS0246	The type or namespace name 'ISerializationCallbackReceiver' could not be found (are you missing a using directive or an assembly reference?)	bitterplants.CSharp	C:\Users\Darrel Cusey\Documents\Unity Projects\bitterplants\Assets\Source\fsISerializationCallbacks.cs	67
This is solved by changing lines 67, 71, and 75 to include "UnityEngine.":
#if !NO_UNITY
public class fsSerializationCallbackReceiverProcessor : fsObjectProcessor {
public override bool CanProcess(Type type) {
return typeof(UnityEngine.ISerializationCallbackReceiver).IsAssignableFrom(type);
}
    public override void OnBeforeSerialize(Type storageType, object instance) {
        ((UnityEngine.ISerializationCallbackReceiver)instance).OnBeforeSerialize();
    }

    public override void OnAfterDeserialize(Type storageType, object instance) {
        ((UnityEngine.ISerializationCallbackReceiver)instance).OnAfterDeserialize();
    }
}

#endif

Can also possibly be fixed by adding "using UnityEngine;" in the assemblies at the top of the file?

Yep, that fixes it as well.

Please reopen if this reproduces on the latest master. At the top of fsISerializationCallbacks.cs, I see
#if !NO_UNITY
using UnityEngine;
#endif

which should be active when importing into Unity.


added pcntl to requirements check

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
❌

Fixed issues
#19779

Hi, @schmunk42, could update the branch and add the line in CHANGELOG.md to merge it,
Thks.

done

👍🏻


[5.8.] When you proxy VerifyEmail verificationUrl() method is called anyway

Laravel Version: 5.8.16
PHP Version: PHP 7.3.5-1+ubuntu16.04.1+deb.sury.org+1 (cli) (built: May  3 2019 10:00:05) ( NTS )
Database Driver & Version: MariaDB 10.3

Description:
I've a Proxy for VerifyEmail that generates a new custom signed URL and then send a mail message from within the proxy itself like see code below:
    public function __invoke(User $user) : MailMessage
    {
        $signedUrl = URL::temporarySignedRoute(
            "my.custom.route.name",
            Date::now()->addMinutes(60),
            ["id" => "whatever"]
        );

        return (new MailMessage())
            ->subject(__("views.emails.users.verify.title"))
            ->markdown("emails.users.verify", [
                "url" => $signedUrl,
            ]);
    }

The problem is that if I don't put a dummy route named verification.verify the test will break because the native method Illuminate\Auth\Notifications::VerifyEmail@verificationUrl is called regardless of what the Proxy does which should not be the case in my opionion
Steps To Reproduce:

Create a Proxy
Use the Proxy in your AppServiceProvider.php like so

   VerifyEmail::toMailUsing(new VerifyEmailNotificationProxy());

Don't create the default Auth routes or don't create any route called verification.verify
Watch the world burn 🤣
Put a dummy route inside web.php with name("verification.verify") to counter-test this problem

Can you please fill in the exact versions in the issue template?

@driesvints Fixed

Can you please share some more code? Where does this __invoke resides? How is it called?

The __invoke method is part of a class called VerifyEmailNotificationProxy inside my App\Proxies namespace (which of course in inside app/Proxies folder)
Inside the AppServiceProvider I call it like this
public function boot()
    {
        // Override the default behavior of VerifyEmail notification
        VerifyEmail::toMailUsing(new VerifyEmailNotificationProxy());
    }

That's just it. Again if I leave a dummy route named verification.verify it works, as soon as I remove it, because I have my custom route used inside the proxy, the VerifyEmail fails

I see what you mean now @ludo237. I can understand that you'd want to generate a new url and not use the one generated by the VerifyEmail class. However, I think this is a feature request and not a "bug" because the VerifyEmail class works properly.
It's best to post this at the laravel/ideas repository to get support for your idea. After that you may send a PR to the framework.
Thanks!

I think it's half a bug and half a feature request. I mean the VerifyEmail class should ignore the URL generation if I proxy it in my opinion.


Should SetCompatibilityVersion(CompatibilityVersion.Version_2_1) be used?

In your examples, should SetCompatibilityVersion(CompatibilityVersion.Version_2_1) be used?
public void ConfigureServices(IServiceCollection services)
{
services.AddMvc()
.SetCompatibilityVersion(CompatibilityVersion.Version_2_1);
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f0646a3d-a5d1-d4b0-5494-fe38219d16c9
Version Independent ID: 8b659e63-93b8-a496-bc9b-dce0d9fa8f3c
Content: Filter methods for Razor Pages in ASP.NET Core
Content Source: aspnetcore/razor-pages/filter.md
Product: aspnet-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Hello @jwatkin ... For 2.1, yes. Sample updates are tracked by #5495, but I think that @Rick-Anderson will be updating this along with https://github.com/aspnet/Docs/issues/7298.

@jwatkin  It's not needed.


integrate MLXArray functions and free functions up to mlx v0.3.0

this brings the MLXArray methods and free functions up to parity with mlx v0.3.0

addmm
diag
diagonal
isclose

adopts fast.rope in RoPE

adopts admm in Linear

update documentation and fix any docs warnings

For comparison: https://github.com/ml-explore/mlx/compare/v0.0.10...v0.3.0

Please merge when you're ready!


Spanish GSRs missing source/target CAMEO code

I was just looking at the Spanish GSRs to make sure I matched the Arabic ones to them, and I noticed that while they have the source and target actor text, they don't actually have the actor CAMEO codes. Are there plans to add the actor codes? (I'm looking at spanish_protest_cameo_4_jj_validation)

Yes. Those will be added after the Spanish team finishes the validation.

The actor codes of Spanish validation set are added.


Update metering 0.13.0 CSV description, and provide example.

/lgtm
Cosmetic changes related to descriptions and such


Events configured "when deleting a row" are not triggered

No prewritten action is triggered when configured to be invoked when deleting a record from the declared table

I have these two actions written down that do the same thing, they're just called on delete or insert. because they should capture the actions performed by means of "Edit Badge", I take the insert well, but not the delete

@glutamate

Dear @glutamate Is there any alternative to solve this? The truth is that it is quite dangerous for me, since I have to look for strange gadgets everywhere to be able to solve this problem.

@christianhugoch would you be able to have a look? The problem is that Edit Badge deletes rows using sql instead of Table.deleteRows so the event triggers are never run. All we need to do is change the sql query into a call to Table.deleteRows.

Yes, I can take a look

added a pr. I hope all looks good
The sqlite part is untested, I think at first, we have to make the plugin sqlite ready, before it matters

@christianhugoch  I tried the modifications made for the PR, but honestly it didn't have any effect :(
the event is still not called by the trigger (Delete row)
Thank you both for your attention.

Okay, thanks for testing
Are you sure the delete itself worked? There was a permission problem that could cause it to fail.
I added another commit for this, can you update and re-check?
If it still fails, can you give me some insights on the actions and the gui structure? Are the run_js_code actions serverside? I believe client side won't work here, but also not for insert.

I'll tell you from the beginning how what I'm doing works, and what the problems are that I have.
I'm building a module in the system that allows you to make a budget for a project.
This budget is made up of descriptive items, with quantities, unit values, percentage taxes to calculate, and the total calculation of said taxes.

In the "Agr. Taxes" column I use the "edit badge" plugin to assign, through a many-to-many relationship, the required taxes, which can be 1 or 2 or 3. It depends on the product being quoted.
When adding said tax, I internally created a script that is called "When inserting a row" and "When deleting a row" that adds the percentages of the taxes assigned to the row being quoted, multiplies the sum by the unit value, by the quantity, the values are stored in fields, and then at the end of everything in the view, aggregations are made to add all the items in the quote, add all the taxes, and add the final totals. (Σ Taxes * v_unit * quantity)
The problems I find with these are:
1-One of the least serious: is that when adding or deleting a badge, the page does not reload, nor does it recalculate the totals visually (Until the page is reloaded manually)
2- The most tedious in question is that when deleting a badge, not only does it not perform the action mentioned above, but it does not call the event that recalculates the totals, and therefore the totals are in disagreement with the taxes it says it has. (They only pay attention to the trigger "when inserted" and not "when deleted"
Here, script of event to execute on insert or delete:
let tabla_impuestos = await Table.findOne('impuestos_a_items_presupuesto'); //con tabla original
//let tabla_impuestos = await Table.findOne('impuestos_items_presupuesto');
let tabla_items = await Table.findOne('items_presupuesto');

let suma = await tabla_impuestos.aggregationQuery({
      nm: {
        field: 'valor_impuesto',
  		aggregate:'sum'
      }
},{
where: {item_presupuesto: item_presupuesto}
})
console.log(suma)

let item = await tabla_items.getRow({id:item_presupuesto})

await tabla_items.updateRow({impuestos:suma.nm * Number(item.cantidad) * Number(item.valor_unitario)},item_presupuesto);

Sure, I actually did a FORK, changed the plugin repo name in the package.json and installed it manually, from the package manager.

Hey, just looked at your fork and saw this on main
https://github.com/gianlucafiore/badges/blob/8ca9389ecd88ecc650be66ad144a509fbfe4701d/edit.js#L328
I believe that's the old code, my changes are on a branch (edit-badge-action).
But I would feel better if we just merge and release it the normal way.

merged and published as 0.2.4

thanks guys, I´will test this. regards!

I definitely think the problem is that the trigger is not executed correctly. I tried creating a "list" with delete buttons for those items, to keep the badge plugin out of the testing, and the event is never called.

yes of course, I will sending to you. Thanks for agility

sended for drive

thanks, will take a look soon

I believe the problem is that the trigger runs before the actual delete and when you grep into the database you still see the old state.
Can you verify that? I noticed that by deleting multiple items (5-6) and refreshed after each delete.

The truth is that I'm already dizzy with this case, but how did you do the deletion? From the "items_presupuesto" list through "edit_badge"?
I'm going to try it anyway to see if I can detect it that way.

Hello, good morning, @christianhugoch  , I really couldn't detect any change for the better, nor find the problem that you described to me.

I'm going to send you screenshots later today. I've resetted the schema but I'm going to set it up again.
TL;DR
I used the badge delete button and saw that the trigger ran. But I believe when you call aggregationQuery, then the row you want to delete is still in the db, this explains why you don't see a change on the gui. Are you really sure this dosen't happen on your machine?

This is the initial state:

Then I deleted the item with impuesto one and the GUI dose not update correctly:

But I've added a console.log() on top of the del trigger and you see it in the logs:

After that I deleted the two items with impuestor two. After first delete:

Nothing happens, as expected. But after the second delete you see an update:

I'm convinced the update you see in the last delete is based on the first delete, but it ignores the current delete, because the trigger runs before the db operation.
Does this help?

Excellent, I think that is where the problem lies, and what would be the solution or temporary solution?

I think we have two options:
1 .In the delete trigger, you have access to the row variable, that's the row you're about to delete. Can you change your logic, to take this value out of the calculation?
2. We could add an option to run delete trigger before or after the db operation.
I think as a temporary fix, I would go with 1.

Thank you very much my friend, I was able to solve it for the moment, thanks to your help with the testing as well...

I had to add that line of code so that the DB is updated by subtracting the previously entered value.

Hi, I've looked at it, but I believe with the current code, there is no "easy" way to reload another embedded view or the page after the edit (will think more about it).
There are ways to implement that, but can we put this in another issue?

Ok, of course!


[Adaptive Cards-Schema Explorer]: Some of the Content is missing from the Adaptive Cards when Text Spacing is applied on the webpage.

Target Platforms
Other
SDK Version
1.5
Application Name
Adaptive Cards
Problem Description
Test Environment:
OS: Version 22H2 (OS Build 25197.1000)
Edge Dev: version 107.0.1379.1 (Official build) dev (64-bit)
Application URL: [[https://adaptivecards.io/](https://adaptivecards.io/explorer/)
Pre-Requisites:
Apply Text Spacing on the Adaptive Card Webpage.
Repro Steps:

Open above URL with V- credential.
Navigate to 'Schema Explorer' link using tab key and press enter key to activate it.
Navigate to "TextBlock" link present under CardElements from the left navigation using the tab key and activate it using Enter key.
Apply Text Spacing for the Webpage using "Text Spacing" bookmark.
Navigate to this content "wrap: false Lorem ipsum dolor sit amet, consectetur...." present under the adaptive card.
Observe the issue here.

Actual Result:
"Consectetur" text is missing from the adaptive card, when applied Text spacing on the webpage.
Expected Result:
"Consectetur" text should not get missed from the adaptive card, when applied Text spacing on the webpage.and nothing should miss on the page when applied Text Spacing on the webpage.
User Impact:
Low Vision Keyboard users will be impacted if content missing on the page as they miss some of the information on the page.
MAS Reference:
https://liquid.microsoft.com/Web/Object/Read/ms.accessibility/Requirements/01.04.12
"Have feedback to share on Bugs ? Please help fill Trusted Tester Bug Feedback (office.com) “.
Screenshots

Card JSON
NA

Sample Code Language
NA
Sample Code
NA

Hi @Susmitha474, can you give more details for how you apply text spacing?

Hi @Susmitha474, can you give more details for how you apply text spacing?

@anna-dingler please refer prerequisite I have added the process over there.

Hi @Susmitha474. Thank you for adding additional details on Stylus!
For the specific example you pointed out, we are showcasing an example of the wrap property in our schema. With wrap set to false, the content is intended to only stay on one line. This is why an extra word is cut off after text spacing is applied, but it does not impact the meaning of the card as we are intending on cutting off the text early.
Let me know if you have any questions!

As per the above comment closing this issue.


⚠ Bofrost.lu has degraded performance

In 671ea09, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1470 ms

Resolved: Bofrost.lu performance has improved in 56d9665 after 13 minutes.


add format unknown

Issue #, if available:
Description of changes:
SecItemImport overrides import format after the call, so we need to reset it to unknown before every call
https://developer.apple.com/documentation/security/1395728-secitemimport?language=objc
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (029587f) 79.72% compared to head (384acf7) 79.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #606   +/-   ##
=======================================
  Coverage   79.72%   79.72%
=======================================
  Files          27       27
  Lines        5893     5893
=======================================
  Hits         4698     4698
  Misses       1195     1195

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Sachendra gangwar

My final Trainee Project for frontend developer

Copy and Paste your projects inside your cloned folder

good


[Task] Align Unauthenticated Landing Page to MVP Discussion

Align Unauthenticated Landing Page to MVP Discussion

Discussion here https://app.mural.co/t/cfpb6639/m/cfpb6639/1700596201902/5bf2547996d279ef0906e6a61784dd044aab001f?sender=u0b826717bd5c707e9fd58663

@billhimmelsbach
The visual (above) is no longer accurate. You can refer to the Figma file or the screenshots in the epic issue for reference.


Wrong icon size for ITS theme

Describe the bug
Icons as part of a link text is huge
To Reproduce
Steps to reproduce the behavior:

Create a note. In the directory tree, give it an icon as part of the filename
Create a link in another note that references back to that note with the icon. Make sure it has a Header (H1, H2, etc) marking at the start of the line
Go to a new line, and when the header and link formatting resolves, the icon itself is massive.

Expected behavior
Icon remains the same size as the text in the Header (with link)
Screenshots

Additional context
Originally thought to be an issue with link text and the icon.
Turns out this is any icon that's part of a header, whether part of a link or not.

Second screenshot -- here you can see the Source Mode to see hat this has an H2 marking.

Te link marking doesn't seen to enter into the problem at hand.

Thank you for the report.
What kind of theme do you use?

I use ITS for all of my vaults, as it works best for TTRPG, journals, writing, etc with all of its features.

I got the same issue. I am also using the ITS theme.
https://i.imgur.com/RCom8lG.png

This issue has been resolved in the latest release.

This issue has been resolved in the latest release.

The icons are still a bit big when appearing in the ITS > [!infobox] callouts. Otherwise it looks good as far as I can tell.

This issue has been resolved in the latest release.

The icons are still a bit big when appearing in the ITS > [!infobox] callouts specifically. Otherwise it looks good as far as I can tell. I don't have an issue with icons in a text (as links or plain text) or in the heading of other callout boxes.

Thank you for the quick response. I'll take a look at the issue with the callouts!

Still showing huge in Headers... not limited to ITS theme, tried in a barebones vault with default theme as well.

It is pulling the icon as part of a file link, as the file/note does have a link in the manager on the left.

Hmm, for me, it's not behaving like this anymore. I do have the correct size for the headers and titles with any icon.

Even if it pulls the icon as part of a file link?
Obsidian 1.6.7
ITS Theme 1.3
Iconize 2.14.3
Is there anything you could be doing different? I don't want to share this vault as it's chock full of information that I don't want public, it's for my personal use only.
I just checked on both Linux and Windows versions, and behavior is the same.

Okay... started a completely fresh vault as a test, and it's working as advertised. Wonder why I'm still getting that behavior. Will look at other plugins/settings.

Update...
Uninstalled/reinstalled Iconize.
Works now.
Downside is I have to go through everything again to re-add all the file icons. :(

That's unfortunate, sorry to hear that!
Maybe there was an issue in the data.json file of Iconize?


feat: enhance extra instructions loading in PR code suggestions tool

Generating PR code suggestions
Work in progress ...

Generating PR code suggestions
Work in progress ...

Generating PR code suggestions
Work in progress ...

Generating PR code suggestions
Work in progress ...

Generating PR code suggestions
Work in progress ...

Generating PR code suggestions
Work in progress ...

Generating PR code suggestions
Work in progress ...

Generating PR code suggestions
Work in progress ...


[3.0.0-preview] Porting to System.Reactive

Here's the list of changes I needed to do to cut a pre-release package. Most of it was related to nuget.targets which we're now moving away from, so it's not stuff I'm worried about.
Unable to find version '2.1.0' of package 'xunit.runner.console'.

This is listed under the .nuget/packages.config, not really sure why it's needed because it's not used.
C:\Users\shiftkey\Documents\GitHub\Reactive.EventAggregator\src\.nuget\nuget.targets(70,9): error MSB4175: The task fac
tory "CodeTaskFactory" could not be loaded from the assembly "C:\Program Files (x86)\MSBuild\12.0\bin\Microsoft.Build.T
asks.v4.0.dll". Could not load file or assembly 'file:///C:\Program Files (x86)\MSBuild\12.0\bin\Microsoft.Build.Tasks.
v4.0.dll' or one of its dependencies. The system cannot find the file specified. [C:\Users\shiftkey\Documents\GitHub\Re
active.EventAggregator\src\Reactive.EventAggregator.Tests\Reactive.EventAggregator.Tests.csproj]

Some component inside nuget.targets looking for something I don't have on this VS2015-only VM. Oh well.
Anyway, it's available here if you want to try it out: https://www.nuget.org/packages/Reactive.EventAggregator/3.0.0-preview
cc @BrainCrumbz

xunit.runner.console is a solution-level package, a.k.a. tools-only package. Its purpose is to install an executable (the test console runner in this case) along with the solution, so that you can run it from console without resorting to something being present on dev machine.
We used that in order to run Reactive.EventAggregator tests, as there was no xUnit VS test adapter installed at that moment.

as there was no xUnit VS test adapter installed at that moment.

Feel free to submit a PR if you want the test runner in VS to light up. The changes in #20 will mean the tests are run with the console runner whenever you .\build now, so that's got us covered at least...

Genuinely curious to understand more: what does it mean "the test runner in VS to light up", and what changes are needed for that?
Yes, having the console test runner locally is the actual need: whether its in *.\build* directory or within *.\packages* is not important.

@BrainCrumbz see https://github.com/shiftkey/Reactive.EventAggregator/pull/21 for the details - you just pull in a certain NuGet package to your test project...

Thanks. I think I forgot that you could also install a VS Test Adapter as a package, locally to the project.


[PI4] Install pieeprom update hook as a standalone script in the Pi4 image

This way we can manually perform updates to the boot firmware on Pi4, to test various versions easily and not rely on other distributions. At last until hooks v2 are in place.

On hold - internal discussion https://www.flowdock.com/app/rulemotion/r-resinos/threads/r-huI2csQ93b1zRgqD5n3vgTRpT


Additional postCSS plugins

I use a few postCSS plugins in my workflow. Is there a way to have sc5-styleguide use them as well?
When I attempt to run the given example in my gulpfile, I get sytnax errors due to the additional syntax my postCSS plugins allow.

Could you provide the repo please?
My suggestion is that you should use parsers: { 'postcss': 'postcss' } option from here https://github.com/SC5/sc5-styleguide#build-options but maybe something else, cannot guess without seeing your code.

@varya Using CLI --parsers argument with option "{ css: 'postcss' }" and "{ postcss: 'postcss' }", the script reports the same error both times when using postcss-nested:
Parsing error: Please check validity of the block starting from line #17

15 |   color: inherit;
17*|   &::before {
18 |     display: inline-block;
19 |     width: 1.8em;

Syntax: css
Gonzales PE version: 3.0.0-31

Here's a repo with code to reproduce the issue

Oh and one more thing: currently I'm using the styleguide:ignore:start and styleguide:ignore:end flags in source css, but it would be awesome to get away without the ignore flags.

Currently postCSS support does not support additional plug-ins. The postCSS tree processing is located in https://github.com/SC5/sc5-styleguide/blob/master/lib/modules/parsers/postcss.js and currently it is not  possible to inject 3rd party postCSS processers

Just plug your postcss in pipes after styleguide

@glebmachine yep, that's the option I have resorted to now, but it is a workaround. It would be cool to have postcss additional plugin support. As hannu said, I think it should be considered for implementation.

@karolis-adapt not really. Piping postcss after styleguide is canonical gulp way to achieve your goal.
Postccss integration is unnecessary here.

@glebmachine wait a sec. I think I misunderstood your previous comment. Currently, I'm generating the styleguide using the built css files. If I use styleguide with postcss files (not piping anything anywhere except for the read stream I guess) the error mentioned in the original comment gets logged out. Not using gulp, just cli interface of sc5 styleguide.

@karolis-adapt Ou, i missunderstood you too.
It's may possible to implement after this issue https://github.com/SC5/sc5-styleguide/issues/767
You still have option to create custom gulp postcss task, with full postprocessing chain btw.

@faceg @karolis-adapt Could you try out this version, does it help? https://github.com/SC5/sc5-styleguide/releases/tag/0.3.41 It does not work with PostCSS plugins yet, but uses PostCSS parser for the source code. It may be enough to avoid StyleGuide fail on your project.

@varya the issue persists. Updated the issue example repo to use the latest sc5-styleguide.

Thanks for continuing to work towards this!

Has anyone gotten this to work?


Website config update

Description
Initially I planned to just update the workflow on Github Actions for website deployment, but saw a few other minor things to fix, like wrong favicon used (looks like from Flutterfire), so did more changes:

Updated Github Actions workflow to use fresh and stable versions of 3rd party actions.
Bumped Node version to 16 as Docusaurus supports it
Replaced favicon with the one from Flutter Community
Bumped a few packages versions for npm (those which were non-breaking)
Modified supported browsers list to use default target list
Removed some redundant images not used by the website

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated the version in pubspec.yaml and CHANGELOG.md.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

Looks like all_plugins workflow has some configuration issues if started checks for such PR.

Requested review from people suggested by Github. Not sure if it was a correct choice, so let me know if I should request a review from someone else.
While working on this PR I saw a few points to improve, which I would like us to implement as well in nearest future:

Update Docusaurus to more recent version
Add preview channel to have a preview available in PRs before merging the PR with website modifications. It can be done multiple ways, but one of options is to use the official Firebase Action . I don't know who has access to Firebase setup, so would appreciate if somebody shares info about it.
Move from npm to yarn (might be a little bit faster to deploy in future)


Express Install Error

Jareds-MacBook-Air:node jared$ npm install -g express
npm http GET https://registry.npmjs.org/express
npm http 304 https://registry.npmjs.org/express
npm ERR! Could not create /usr/local/lib/node_modules/___express.npm
npm ERR! error installing<EMAIL_ADDRESS>npm ERR! Error: EACCES, permission denied '/usr/local/lib/node_modules/___express.npm'
npm ERR! Report this entire log at:
npm ERR!     http://github.com/isaacs/npm/issues
npm ERR! or email it to:
npm ERR<EMAIL_ADDRESS>npm ERR!
npm ERR! System Darwin 11.2.0
npm ERR! command "node" "/usr/local/bin/npm" "install" "-g" "express"
npm ERR! cwd /Users/jared/Sites/node
npm ERR! node -v v0.6.6
npm ERR! npm -v 1.1.0-beta-4
npm ERR! path /usr/local/lib/node_modules/___express.npm
npm ERR! code EACCES
npm ERR! message EACCES, permission denied '/usr/local/lib/node_modules/___express.npm'
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /Users/jared/Sites/node/npm-debug.log
npm not ok

Did you try installing with sudo, i.e. sudo npm install -g express?

I did and got it to work (after I posted the log) -- it might be good thing
to suggest in the error msg. (esp for command line noobs like me)
Thanks!
On Tue, Jan 17, 2012 at 4:42 PM, Anton Rissanen <
<EMAIL_ADDRESS>
wrote:

Did you try installing with sudo, i.e. sudo npm install -g express?

Reply to this email directly or view it on GitHub:
https://github.com/isaacs/npm/issues/2047#issuecomment-3536359

--
Partner, Upstatement
upstatement.com
o:<PHONE_NUMBER>
c:<PHONE_NUMBER>

I agree, the message is cryptic. Let's just wait for someone with permissions to close this, then... :)

It actually has been made more useful already. Although it does not specifically say "sudo", it does mention root privileges.


Make 'Create STAC Metadata script'

User Story
As a Dev I want a script that takes a tiff historical imagery file and creates a STAC metadata output for it in order to create machine-readable metadata for historical imagery files.
Acceptance Criteria
create a function that:

[ ] takes a tiff file path as an input
[ ] returns stac metadata json object
[ ] use logging
[ ] Adheres to https://confluence.linz.govt.nz/display/LGDL/Data+Lake+Metadata+Requirements

nb: Use data lake as an example

done


[Purity] Use call_pure_packed and call_inplace_packed where applicable

Currently, many MLC models use packed functions in dataflow blocks, which is not permitted. I plan to add a well-formedness check into the Relax parser to prevent that. Fortunately, call_pure_packed and call_inplace_packed can be used to avoid breaking any MLC models with this change. There are not many updates that need to be made, thankfully.
(Note: A few unrelated code changes were due to autoformatting.)

Please review @MasterJH5574 @tqchen (or others). I don't think this should be a disruptive change.


Add Personal portfolio website using reactjs

Portfolio website
I want to add a personal portfolio website using html css bootstrap javascript and reactjs.

@khushi-purwar Kindly assign me this issue.Thanks

/assign


rel='noopener' and rel='nofollow' as an additional option for links

Markdig already comes bundled with an extension – .UseNoFollowLinks() – that ensures all links have rel='nofollow' attribute. .
Meanwhile, rel='noopener' ensures that the target won't be able to access the window object of the page linking to it, which could be a security issue, and rel='noreferrer' ensures that the target page doesn't know where the visit came from. It can break analytics if used for internal links, but can be desired for user-generated content.
Proposed solution A:
Two more extensions, each adding its respective rel with .UseNoOpenerLinks() and .UseNoReferrerLinks(). It's a bit verbose and might have some impact on performance, but it's fully backwards-compatible.
Proposed solution B:
All three extensions merged into one, .UseAdvancedLinks(), possibly with something akin to the following signature:
UseAdvancedLinks(bool nofollow = false, bool noopener = false, bool noreferrer = false)

which could be used with named parameters: .UseAdvancedLinks(noreferrer: true, nofollow: true). This cuts down on the verbosity and could be a bit more performant since all three attributes could be set in a single pass, but the issue might be backwards compatibility – should .UseNoFollowLinks() be dropped – or redundancy – should it exist besides .UseNoFollowLinks().
I tried implementing it myself (you can see my attempt here), but it turned out to be a task a bit too big for me. Perhaps some bigger brain will be able to implement it in a way that actually works.

Maybe an extension with '.UseReferalLinks(params string[] names)that you can use directly withUseReferalLinks("nofollow")while we would keep only.UseNoFollowLinks()` using internally the use UseReferalLinks.
I'm not in favor of the boolean approach, nor I think that an enum would be nice, as there are also several other possible values so keeping it simple should cover all future usecases.
Modifying the existing NoFollowLinks extension should not be complicated to turn it into a ReferalLinksExtension.


Customizables loop frames

Implementation, in the rescomp, of an optional parameter for defining the loop frame for each animation (#101)
Does not include update of the rescomp.txt and the binary in the toolchain itself.

why close

probably because i moved rescomp to java..
Still customizable loop / animation... is something i want to add but in a more flexible way :)


[BUG] CSI volume clone from existing volume stuck in degraded

Describe the bug
Create CSI volume with existing volume as data source hangs in the degraded state.
This issue was raised in csi-sanity test and seems to be side effects from https://github.com/longhorn/longhorn-manager/pull/1210. It works if change the resync time back to 30 seconds.
To Reproduce

Follow step in doc to create source-pvc then cloned-pvc.
The cloned-pvc volume stuck in state degraded.

Expected behavior
Finish volume clone then detaches volume.
Log or Support bundle
n/a
Environment
n/a
Additional context
https://github.com/longhorn/longhorn/issues/3629

cc @PhanLe1010

From my testing, it looks like this one is duplicated of https://github.com/longhorn/longhorn/issues/3692. There are 2 cases:

If the source volume is attached at the time, the clone is ok
If the source volume is detached at the time, the clone is failed. This is similar to https://github.com/longhorn/longhorn/issues/3692
Are you seeing the same thing @c3y1huang

Are you seeing the same thing @c3y1huang

Looks like is the same as https://github.com/longhorn/longhorn/issues/3692.


Added page on how to restrict access to OCI console

Added page on how to restrict access to OCI console
Minor reorg of files
Small correction

@fboufis can you approve this one?


dist.js is not valid

The 'dist.js' file in github contains tags used by Github for merging branches.
The issue is also present vi 'npm install archethic'

Fixed in 62047d433d6658303039d60f7f445c834a8265d1  and with 1.1.1 version.
Thanks for the report


Missing "using namespace drogon::orm;" inside autogenerated restful base controller (h file)

Describe the bug
If Restful controllers incl. models are generated from a database, the inizially generated controllers cannot be compiled, because SortOrder and DrogonException are not found due to the missing namespace.
To Reproduce
Steps to reproduce the behavior:

Create simple sql table
Generate models inkl. restful controller
Cant compile => missing namespace
See error

Expected behavior
Correct generated restful controller
Desktop (please complete the following information):

OS: kubuntu latest

Thanks, Pull Request is merged
https://github.com/drogonframework/drogon/pull/1178


How add a new terminate funtion about vehicle lane off

Dear Prof.
Following up the issue #310, I want to use the PPO algorithm to control both the steering wheel angle and acceleration of the vehicle in an intersection environment. I use the "kinematics"  observation type, it contains three off-lane parameters (long_off,lat_off,ang_off). I want to know why are these three parameters the offset of the ego-vehicle from the close lane and not the offset of its driving lane.
Additionally, I find it difficult to stay in the lane when controlling the steering wheel angle and acceleration at the same time, I would like to add a new function(off-line termination) to terminate the environment, for example when the vehicle deviates from the driving lane the environment will terminate. As the intersection environment includes both straight-ahead and left turns, how do I set the threshold when turning left?
When the ego-vehicle is going straight we want it to stay in the lane and when turning we want it to successfully reach the target lane, so I don't quite understand how to set the threshold for the off-line termination.

Hi,

I want to know why are these three parameters the offset of the ego-vehicle from the close lane and not the offset of its driving lane.

Generally if a vehicle is driving on a given lane, then this should also be its closest lane. But I think you mean what happens when the vehicle start driving on another lane that its target? Then that's a good point, we could add similar features for its target lane rather than current lane. If you want to implement that, you can use something similar as:
https://github.com/eleurent/highway-env/blob/ffb35eacdfb2671623dc12d99b2ed5b6cb76e531/highway_env/vehicle/kinematics.py#L195
and replace self.lane by target_lane = self.road.network.get_lane(self.target_lane_index)

Additionally, I find it difficult to stay in the lane when controlling the steering wheel angle and acceleration at the same time, I would like to add a new function(off-line termination) to terminate the environment, for example when the vehicle deviates from the driving lane the environment will terminate. As the intersection environment includes both straight-ahead and left turns, how do I set the threshold when turning left?

Currently, there is an offroad termination condition that you can enable, which would end the episode whenever the vehicle drives off the road altogether. But it seems that you want to stop earlier, when the vehicle is too far from its target lane, which makes sense.
Then again, you would have to implement it in the env's is_terminated method:
https://github.com/eleurent/highway-env/blob/ffb35eacdfb2671623dc12d99b2ed5b6cb76e531/highway_env/envs/intersection_env.py#L98
by adding the condition
target_lane = self.road.network.get_lane(self.vehicle.target_lane_index)
on_target_lane = target_lane.on_lane(self.vehicle.position)

When the ego-vehicle is going straight we want it to stay in the lane and when turning we want it to successfully reach the target lane, so I don't quite understand how to set the threshold for the off-line termination.

I think at all time you can control the maximum lateral deviation from the target lane's centerline. This is what I am doing in the on_lane method mentioned above, but if you want implement your own criterion instead to better control the margins etc.
https://github.com/eleurent/highway-env/blob/ffb35eacdfb2671623dc12d99b2ed5b6cb76e531/highway_env/road/lane.py#L80


Creating a Product Authentication Class

Description
A js sdk for authenticate product. In this PR I implemented the base class of product authentication .
Feature

[x] Implement ProductAuthentication Class

[x] Implement verify function

[x] Implement create function

[x] Doing test

[x]  Giving Simple Example

[x] After compile typescript

[x] Creating bundle

[x] Creating d_ts

[x] Creating js

\npm_publish

\npm_publish


Add QuoteBlock

```quote
author = "Bob"
bio = "Rustacean"
content = "Hello, Bob!"
```

On 2022/11/16 21:01, Folyd wrote:

@Folyd https://github.com/Folyd requested your review on: #116 https://github.com/zineland/zine/pull/116 Add QuoteBlock.
—
Reply to this email directly, view it on GitHub https://github.com/zineland/zine/pull/116#event-7823738767, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK4ZEMYANXDVDFGSRNFLD3LWITLJZANCNFSM6AAAAAASCGREHY.
You are receiving this because your review was requested.Message ID: @.***>

This generally looks good to me. But could you ensure there is no error like:
thread 'thread 'tokio-runtime-workertokio-runtime-worker' panicked at '' panicked at 'called `Result::unwrap()` on an `Err` value: Template 'blocks/quote.jinja' not foundcalled `Result::unwrap()` on an `Err` value: Template 'blocks/quote.jinja' not found', ', src\code_blocks\mod.rssrc\code_blocks\mod.rs::103103::7171

Test with develop build is fine.
--
Rui Li    0x77E6D821D7AE84FE

Looks good to me. But if there is some format problem like
missed quote, worker thread would panic and can't recover.
Thanks.
Rui

Yes, it will panic with an error message if the syntax is invalid.


Sending chart from CLI

Hello, I'd like to use Your utility to send a simple chart via mail from a command line in Linux.  But there are an unreadable bunch of chars â–ˆâ–ˆâ–ˆâ–ˆâ–ˆâ–ˆâ–ˆâ–ˆ  in the received email, if I pipe result from jp to "mail -s ..." command although jp works perfectly in CLI.
Do You have any advice on how to send a chart via email from CLI, please?

Hey! I'm pretty sure this is a matter of setting the correct encoding (utf-8, in this case) for the mail - have a look at the answers here: https://stackoverflow.com/questions/3120168/how-to-send-special-characters-via-mail-from-a-shell-script

Thank's for Your prompt action, the proposed solution really helps...


Fixed Railtie to only load helper for UI controller

Overview
Necessary to prevent the following error when a Rails application is
initialized and uses the ActionController::API for a base class:
NoMethodError:
  undefined method `helper_method' for ActionController::API:Class
# $HOME/.gem/ruby/2.7.3/gems/google_visualr-2.5.1/lib/
  google_visualr/app/helpers/view_helper.rb:7:in `block in
  <module:ViewHelper>'

Normally, when configuring Rails, you can specify if your application
is API or UI only (UI is the default) and Rails will auto-filter
initializers which don't support the one or the other. In my case, I'm
working with a Rails app that is a hybrid of UI and API functionality.
Unfortunately, the :action_controller hook is a superset hook which
causes issues. Here's a better illustration:

:action_controller - ApplicationController and
ActionController::API.
:action_controller_base - ApplicationController only.
:action_controller_api - ActionController::API only.

This is why applying this fix ensures the Google view helper isn't
loaded for API purposes. 😉
Notes
I'm afraid I wasn't able to write a spec for this because the Bundler and Appraisal gems are quite outdated on this project. If I had more time, I'd fix that too but wanted to get this up for review in case there is interest and of help to others.

:information_source: Closing this down since this has been open for over a year and I'd like to get my Inbox back to zero.


test: Run Edge tests on RHEL 8.5

PR #1391 has been merged, but Edge integration test did not get run. Since Edge integration test on RHEL 8.5 (not just Edge tests, but all integration tests on RHEL 8.5) has not been run yet. I have to open this PR to run test and see what happens.
And to open this PR I update ostree.sh and remove fedora 32 test because it's not covered by CI.

@ondrejbudai @atodorov Could you please help set variable RHEL85_NIGHTLY_REPO used by https://github.com/osbuild/osbuild-composer/blob/1e54cd4493d0f611340c90fd64dc7c7281d5d2cd/schutzbot/mockbuild.sh#L85
Thanks.

@ondrejbudai @atodorov Could you please help set variable RHEL85_NIGHTLY_REPO used by

Done.

+1 for the Fedora32 removal but the subject says "Run Edge tests on 8.5". I see nothing related to 8.5 here.
Are we missing a commit here or the subject is incorrect ?

No, this PR is to Run Edge tests on RHEL 8.5. To open this PR, I update ostree.sh and remove fedora 32 test.
This PR might have more commit to fix Edge test issue, because it's the first time to run edge test on RHEL 8.5.

@atodorov The openstack deployment reports error. I can find the this RHEL 8.5 nightly image id from my PSI openstack account. So the image id is not the same for all projects?
Error: Error creating OpenStack server: Bad request with: [POST https://rhos-d.infra.prod.upshift.rdu2.redhat.com:13774/v2.1/servers], error message: {"badRequest": {"code": 400, "message": "Can not find requested image"}}

@achilleas-k @gicmo All edge related tests are all passed. Pin to osbuild commit(which has rng-tools fix included by mounting /sys read only) fixed that issue!

ostree.sh on RHEL-8
ostree.sh on RHEL-8.5
ostree-ng.sh on RHEL-8.5

@atodorov @ondrejbudai Do we have plan to pin RHEL-8 test to RHEL-8.4? As Edge, we need RHEL 8.4 environment because Edge has 8.4 z-stream fix(bz#1951192) and old image types(rhel-edge-commit, rhel-edge-container, and rhel-edge-installer on RHEL 8.4 only) should be tested to make sure both of new image type on RHEL 8.5 and old image type on RHEL 8.4 work. Thanks.

Yes, this is on my todo-list. :)

Everything reports PASS! Will go ahead and merge!


[Feature Request] Add an empty state

When no matches show up, I think it would be helpful to see an empty state mentioning that there are no matches. When nothing shows up, I end up double checking the devtools to see if something broke.

Good idea, it's been on my TODO list for a little while. Will be fixed in upcoming release.

@blacksmithgu, 👋 not sure if it's intentional but you never updated the manifest.json with the latest version so Obsidian doesn't know to update it.

I forgot to push the actual changes! I've since corrected it.

This issue should be fixed - all of the views now have an explicit view for 0 results.


Memory leak when running integration case dubbo-samples-memory-tri-server

Environment

Dubbo version: 3.2.6
Operating System version: windows11
Java version: jdk 1.8

Steps to reproduce this issue
Executing integration tests on dubbo-samples-memory-tri-server failed. Through dumping, it was found that some resources have issues with incomplete destroy.

Expected Behavior

Actual Behavior

If there is an exception, please attach the exception trace:
Just put your stack trace here!

Dubbo version 3.3.0-beta.2-SNAPSHOT also have this problem

https://github.com/apache/dubbo-integration-cases/pull/13


:sparkles: Enable New App Onboarding

User Story
As an Analytical Platform User, I would like the ability to create new apps so that I can make my analyses available to an audience outside Analytical Platform
Value / Purpose
The capability to create new apps has been suspended since November of 2022, and we are finally ready to reenable it at the conclusion of the last round of UAT.
Useful Contacts
Michael Collins, James Stott, Julia Lawrence
User Types
Analytical Platform User
Hypothesis
Reenabling this functionality will give rise to larger volume of support requests so the score for this story should include the effort that is needed to deliver it.
We expect the experience of supporting the UAT will roughly mirror that of making this publicly available but on a larger scale.
We expect we might encounter some issues around the fact that this process takes place without our interference so we might be blindsided by the amount of support requests.
Proposal
Integrate lessons learned from UAT into the documentation and roll out the button in the Control Panel to allow app creation process to kick off.
Additional Information
This should conclude the current epic.
Definition of Done

[x] Documentation updated
[x] Documentation published
[x] Control Panel button made visible
[x] Team briefed
[x] Announcement made

User guidance published in https://github.com/moj-analytical-services/user-guidance/pull/392
Control panel released in https://github.com/moj-analytical-services/analytical-platform-flux/pull/1246
Notice to the AP team https://mojdt.slack.com/archives/C04M8224WCV/p1710766573939009
Announcements made in #ask-data-platform and #ask-data-engineering


[BUG]: Use force in npm install

Description
help bro I like it and want to do something edit at my local but as you mention  the npm install command show a lot of error and not working can you do something about it
Additional Information
No response

Hi @NarpatAanjana,
Actually, npm required to use --force to install package successfully  npm install -f instead of npm install
So, Now It has been fixed you can check once.
Happy Coding😁

@all-contributors please add @NarpatAanjana for bug


provide a built package

I'm using webpack and it doesn't compile packages from node_modules. can you please provide a built package?

this is simple. just copy index.js to your project. Both 2 of your issue solved.


Add paragraph on requesting reviews

Objective
Requesting reviews is a useful tool for improving discoverability of PRs that contributors might be interested in and capable of reviewing.
However, many Bevy org members and authors aren't aware that they can and should request reviews.
Solution
Actually document that this is good practice, and remind people that it's just a nudge.

@MalekiRe can I get your review here? /meta

This might be better in a separate pr, but should there be a bit about going on discord to beg for reviews in the relevant discord channel? I'm a little hesitant to direct people to discord in an official document, but this would just be documenting what is probably the most effective way of getting something reviewed currently.

@hymm I think that #13162 is probably the right place for that flavor of idea.


Proposal of adding Information security classification

Proposed element Classification. Security classification of information in package.
Elements type: String.
Allowed values: P, BS, HS, EJ KLASSAT. "EJ KLASSAT" is default. Values could be extended to support different organisations requirements.
Values meaning: P=Publik (eng. public or declassified), BS=Begränsat Skyddsvärde (eng. restricted), HS=Högt Skyddsvärde (eng. confidential), EJ KLASSAT=Ej Klassat, okänd klassning (eng. unclassified, unknown).

A convention for how to add this kind of information in for example amdSec using an existing standard in an implementer guide line is needed. This might be a local implementation of the CSIP.

This can be done locally if required but is beyond the scope of a generally applicable specification.


Add comments to shell snippets in StatefulSet tutorial

Use POSIX-compatible comments to explain the context and expectations to the person following the tutorial for StatefulSets.
Part of PR #42767

/lgtm
Great to have the additional context and guidance!

Page preview:
https://deploy-preview-44390--kubernetes-io-main-staging.netlify.app/docs/tutorials/stateful-application/basic-stateful-set/

/approve


Update - Added copy and paste keyboard shortcuts

Summary
Added keyboard shortcuts for copy and paste.
This enhancement uses the local browser storage for each browser.
Caveats

Cannot copy paste between different types of browsers. ( Copy in Safari -> Paste in Chrome )
A component may only be pasted into a Placeholder
A Workspace cannot be copied and pasted as a nested child in another Workspace, however, an entire Workspace can be replaced by the clipboard by pasting into the root placeholder of the Workspace. ( Click the placeholder in a new workspace and paste into it )

Future considerations

Clickable copy and paste action buttons
Add the clipboard as the first item in the editors Component Selection drop down to enable pasting into components that do not have a drop zone placeholder

Additional information
There were several scenarios that I tested but there may be more.

Copying an entire workspace and trying to paste it as a nested child
Copying an entire workspace and overwriting a blank workspace
Copying a nested item and replacing any placeholder
Copying and pasting between open browser tabs ( Kaiju and real browser )

Thanks for contributing to Kaiju.
@cerner/kaiju

I assume it's not possible to past into the last item in a list?


Store method not working correctly with PostgreSQL driver

The basket store method does not work, when using PostgreSQL driver.
The collection is not fully preserved, and during use of restore method, we got error.

What is not working? What is the error? I need more information to help you.

Error
unserialize(): Error at offset 42 of 45 bytes
at HandleExceptions->handleError(8, 'unserialize(): Error at offset 42 of 45 bytes', 'PATH\\mvm\\vendor\\gloudemans\\shoppingcart\\src\\Cart.php', 381, array('identifier' => 1, 'stored' => object(stdClass)))

content field value in shoppingcart table, it turned out badly cropped
O:29:"Illuminate\Support\Collection":1:{s:8:"

my CreateShoppingcartTable migration run method
Schema::create('shoppingcart', function (Blueprint $table) {
            $table->string('identifier');
            $table->string('instance');
            $table->text('content');
            $table->nullableTimestamps();

            $table->primary(['identifier', 'instance']);
        });

Which version of Laravel are you using? And which version of the package? Is there any way for me to reproduce this problem?

laravel 5.4, postgresql 9.6, package ^2.3.

can you verify for me that the type of the content column is actually text (or similar) and not something like varchar(45) or something? Because I can't reproduce this error.

This is the first thing I checked.

I was pretty sure you had 😉 But I'm running out of options. Can't really seem to be able to reproduce this.

The problem in php code, because I tried on different operating systems (windows, linux) & different versions of postgresql.

get serialized collection
:29:"Illuminate\Support\Collection":1:{s:8:"\x00*\x00items";a:7{s:32:"b3fef508225c0bc74d12efbb30e22f3d";O:32:"Gloudemans\Shoppingcart\CartItem":8:...and more
in database writing this sting
:29:"Illuminate\Support\Collection":1:{s:8:"
The same string but before the \x00
An error occurs while writing a \x00 symbol

I've been doing some reading, and seems to be a problem with Postgres PDO and null bytes in the serialized string. PHP uses those null bytes to store private/protected information for the methods of a class it is serializing.
Could you please try if anything changes if you change the $associatedModel and $taxRate properties on the CartItem class to be public.

I set public on $associatedModel and  $taxRate properties, but it did not work.

Any more \x00 in the serialized string when you make those properties public?

yes,

It seems to be something Postgres specific. Maybe making the content column in the table another datatype (so not text) will fix the problem, but I'm not that familiar with Postgres to tell you which datatype to use. Maybe Google could help you with this

I could not find any other information. Because postgres now allows store arrays and json in its original form. As I understand for text there is only text type.
I would suggest you use mutator and store the collection in the database in json or array... At least for the postgre driver

Postgres is particularly relevant for e-commerce, since it avoids the slow model EAV

I have the same thigns with a mongodb : "\u0000

Exemple :
Cart content :
{"da130ea67758fbaeb7d260ebb707e746":{"rowId":"da130ea67758fbaeb7d260ebb707e746","id":"59810abf0574071a102c4065","name":"A trier","qty":"154","price":0,"options":{"type":"album","albumPicture":"59810abf0574071a102c4066"},"tax":0,"subtotal":0}}
Cart in the mongodb :
{ "_id" : ObjectId("5988bfdd05740705e212c3d2"), "identifier" : "59810abb0574071a0b1b1502", "instance" : "default", "content" : "O:29:\"Illuminate\\Support\\Collection\":1:{s:8:\"\u0000*\u0000items\";a:1:{s:32:\"da130ea67758fbaeb7d260ebb707e746\";O:32:\"Gloudemans\\Shoppingcart\\CartItem\":8:{s:5:\"rowId\";s:32:\"da130ea67758fbaeb7d260ebb707e746\";s:2:\"id\";s:24:\"59810abf0574071a102c4065\";s:3:\"qty\";s:3:\"154\";s:4:\"name\";s:7:\"A trier\";s:5:\"price\";d:0;s:7:\"options\";O:39:\"Gloudemans\\Shoppingcart\\CartItemOptions\":1:{s:8:\"\u0000*\u0000items\";a:2:{s:4:\"type\";s:5:\"album\";s:12:\"albumPicture\";s:24:\"59810abf0574071a102c4066\";}}s:49:\"\u0000Gloudemans\\Shoppingcart\\CartItem\u0000associatedModel\";N;s:41:\"\u0000Gloudemans\\Shoppingcart\\CartItem\u0000taxRate\";i:21;}}}" }
Error message when trying to restore :
[2017-08-07 19:38:58] local.ERROR: ErrorException: Trying to get property of non-object in /home/vagrant/Code/openpicture/vendor/gloudemans/shoppingcart/src/Cart.php:381 Stack trace: #0 /home/vagrant/Code/openpicture/vendor/gloudemans/shoppingcart/src/Cart.php(381): Illuminate\Foundation\Bootstrap\HandleExceptions->handleError(8, 'Trying to get p...', '/home/vagrant/C...', 381, Array) #1 /home/vagrant/Code/openpicture/vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php(221): Gloudemans\Shoppingcart\Cart->restore('59810abb0574071...')

Yes, seems to be certain database/datatypes will have problems with those escaped strings. For now I'd try to Google for another datatype that will be able to store serialized data from php with those nullbytes

to make it work i had to modify restore function in Cart.php :
`
$storedContent = unserialize($stored['content']);
$currentInstance = $this->currentInstance();
$this->instance($stored['instance']);
`

why reinvent the wheel? Laravel has built-in mutator for store collections and arrays in database

any updates on this issue?

question to owner

?????????

The solution what I did was, created an line_items table and dumped those records on it and started using it, seems working fine as expected, I think it will be the best interim solution.

Hi, the bug is caused by Null-bytes, due the fact, that Postgres does not support them.
The problem is caused by the "Cart" class in src/Cart.php.
An quick and dirty fix would be to replace the Null-bytes before storing the serialized string into database (http://php.net/manual/de/function.serialize.php#96504).
    /**
     * Store an the current instance of the cart.
     *
     * @param mixed $identifier
     * @return void
     */
    public function store($identifier)
    {
        $content = $this->getContent();

        if ($this->storedCartWithIdentifierExists($identifier)) {
            throw new CartAlreadyStoredException("A cart with identifier {$identifier} was already stored.");
        }

        $this->getConnection()->table($this->getTableName())->insert([
            'identifier' => $identifier,
            'instance' => $this->currentInstance(),
            'content' => str_replace("\0", "~~NULL_BYTE~~", serialize($content))
        ]);

        $this->events->fire('cart.stored');
    }

    /**
     * Restore the cart with the given identifier.
     *
     * @param mixed $identifier
     * @return void
     */
    public function restore($identifier)
    {
        if( ! $this->storedCartWithIdentifierExists($identifier)) {
            return;
        }

        $stored = $this->getConnection()->table($this->getTableName())
            ->where('identifier', $identifier)->first();

        $storedContent = unserialize(str_replace("~~NULL_BYTE~~", "\0", $stored->content));

        $currentInstance = $this->currentInstance();

        $this->instance($stored->instance);

        $content = $this->getContent();

        foreach ($storedContent as $cartItem) {
            $content->put($cartItem->rowId, $cartItem);
        }

        $this->events->fire('cart.restored');

        $this->session->put($this->instance, $content);

        $this->instance($currentInstance);

        $this->getConnection()->table($this->getTableName())
            ->where('identifier', $identifier)->delete();
    }

However it would be better, to find a more standardized solution, because the serialize-function is not very safe, and so malicious content could be injected.

Same problem here! Postgres does not properly support the PHP serialized "Strings" (frankly speaking, \x00 defines the end of a string in any good programming language).
Wouldn't it be possible to just use a JSON Serialization instead? Or to customize the serialize method?

@Crinsane any updates on this issue?

problem was solved using base64_encode after serializing and base64_decode before unserializing content. see my fork at https://github.com/zimberkazmiz/LaravelShoppingcart/blob/master/src/Cart.php


Tried using fix headers and columns

Hi! Just tried the fix column to display fix column and some dynamic scrollable columns next to it and so I set the columns that are fixed to 'fixed: true'. The column duplicates when i set it to fixed.

Here is my code on my table:
  fixHeaderAndSetBodyMaxHeight: 200,
  tblStyle: 'table-layout: fixed',
  tblClass: 'table-bordered',
  columns: [
    {
      title: 'Item Code',
      field: 'itemCode',
      thComp: 'FilterTh',
      sort: true,
      fixed: true
    },
    {
      title: 'Item Name',
      field: 'itemName',
      sort: true,
      fixed: true
    },
    {
      title: 'UOM',
      field: 'uom',
      sort: true,
      fixed: true
    }
  ],
  data: [],
  total: 0,
  selection: [],
  query: {},
  fieldCols: ['itemCode', 'itemName', 'uom']

Thank you so much. Hope you can help me with this :)

Accoring to the example: https://github.com/OneWayTech/vue2-datatable/blob/master/examples/src/Fixed/index.vue#L21
you have to set the width of the columns yourself.

Adding the setting of width code displays an error.

These are ESLint problems, you should know how to fix them

Uhhh. Okay thanks! 👍


:sparkles: Manage default values for pagination and autopage pages

When I generate my pagination pages, they're included in my sitemap because the generated pages do not have the value Front-Matter sitemap to false.
I, therefore, propose a way to add Front-Matter values to the generated pages using the configuration.

I've no idea why travis failed on this one. @sverrirs, would you please have a look?

Hi Boris, thanks for the PR but did you consider using this existing functionality to identify the auto generated pages? https://github.com/sverrirs/jekyll-paginate-v2/blob/master/README-GENERATOR.md#detecting-generated-pagination-pages

@sverrirs Using this features would imply modifying all the plugins that are based on the page Front-Matter content to pass information. Giving a way to add information to the generated page Front-Matter seems like a more obvious and convenient data layer in which information can be transmitted.

@sverrirs But I don't think I have your experience on this domain so I may have missed something. If you think so and have some time for an explanation, I'd love that.

Regarding the tests, Have you tried running the rake tests locally?

Hi, do you need anything else for my part or it this waiting for a discussion between @ashmaroli and you regarding a more global modification?

Hi Boris,
The only thing I'm waiting for is the two review comments I made last month :) about adding documentation section describing this feature, what it does and when to use it. And perhaps consider simplifying the name of the property in the defaults :)
Otherwise I like this change.

@borisschapira I'm not affiliated with this project. But requesting a change nonetheless.
Can you move the "Better documentation" change into a new PR..?
That way future visitors to this PR do not have to see the huge diff..

I tried to improve the documentation, tell me what you think about this version. If I change default_values to page_config, do you think it would be clearer?
Finally, I added a simple test on the default value. I also wanted to add a test to check that once the page was generated with a page_config configuration, then the generated pages would effectively expose this configuration but I don't know how to do it.

Branch is rebased.


Kogito 5921 Support For OracleDB Peristence

Add support for persisting to OracleDB
Just an initial stab to make sure that I'm on the right track. Will add test on follow up.
https://issues.redhat.com/browse/KOGITO-5921
Please make sure that your PR meets the following requirements:

[x] You have read the contributors guide
[x] Your code is properly formatted according to this configuration
[x] Pull Request title is properly formatted: KOGITO-XYZ Subject
[x] Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains link to any dependent or related Pull Request
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket

How to retest this PR or trigger a specific build:

Run all builds
Please add comment: Jenkins retest this

Run (or rerun) specific test(s)
Please add comment: Jenkins (re)run [runtimes|optaplanner|apps|examples] tests

Quarkus LTS checks
Please add comment: Jenkins run LTS

Run (or rerun) LTS specific test(s)
Please add comment: Jenkins (re)run [runtimes|optaplanner|apps|examples] LTS

Native checks
Please add comment: Jenkins run native

Run (or rerun) native specific test(s)
Please add comment: Jenkins (re)run [runtimes|optaplanner|apps|examples] native

Full Kogito testing (with cloud images and operator BDD testing)
Please add comment: Jenkins run BDD
This check should be used only if a big change is done as it takes time to run, need resources and one full BDD tests check can be done at a time ...

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Please wait for #1554 to be merged first.

I think I've made all the changes required for this PR. Let me know otherwise.

@Scuilion
Can you please verified failed build?
https://github.com/kiegroup/kogito-runtimes/pull/1612/checks?check_run_id=3674578414
kiegroup_kogito_runtimes/addons/common/persistence/jdbc/src/test/java/org/kie/persistence/jdbc/JdbcProcessInstancesIT.java:83 | java.lang.RuntimeException: Error finding all process instances, for processId UserTask 	at org.kie.persistence.jdbc.JdbcProcessInstancesIT.testBasicFlow(JdbcProcessInstancesIT.java:83)
kiegroup_kogito_runtimes/addons/common/persistence/jdbc/src/test/java/org/kie/persistence/jdbc/JdbcProcessInstancesIT.java:47 | java.lang.RuntimeException: Error finding all process instances, for processId UserTask 	at org.kie.persistence.jdbc.JdbcProcessInstancesIT.testBasicTaskFlow(JdbcProcessInstancesIT.java:47)
kiegroup_kogito_runtimes/addons/common/persistence/jdbc/src/test/java/org/kie/persistence/jdbc/JdbcProcessInstancesWithLockIT.java:72 | java.lang.RuntimeException: Error finding all process instances, for processId UserTask 	at org.kie.persistence.jdbc.JdbcProcessInstancesWithLockIT.testRemove(JdbcProcessInstancesWithLockIT.java:72)
kiegroup_kogito_runtimes/addons/common/persistence/jdbc/src/test/java/org/kie/persistence/jdbc/JdbcProcessInstancesWithLockIT.java:40 | java.lang.RuntimeException: Error finding all process instances, for processId UserTask 	at org.kie.persistence.jdbc.JdbcProcessInstancesWithLockIT.testUpdate(JdbcProcessInstancesWithLockIT.java:40)

@danielezonca Might be oracle not having a timezone setting. Made a small change. Don't know how to trigger a rebuild.

ok to test

The (build) Examples check has failed. Please check the logs.

Same test  is failing in PR-1624, PR-1623, PR-1622, and probably others.

Same test is failing in PR-1624, PR-1623, PR-1622, and probably others.

Fixed here https://github.com/kiegroup/kogito-examples/pull/898

The (build) Examples check has failed. Please check the logs.

Jenkins rerun examples tests

The (build) Examples check has failed. Please check the logs.

Seems as though the code coverage for integration test is not registering.

Seems as though the code coverage for integration test is not registering.

Yes it is possible that some integration tests are not included in sonarcloud code coverage analysis so don't worry about that value :)
@cristianonicolai @tiagodolphine
As far as I see all comments has been resolved expect this one
https://github.com/kiegroup/kogito-runtimes/pull/1612#discussion_r714405464
but I think it is better to move to a different ticket the resolution of this.
Wdyt?
@MarianMacik
Do you want review/approve it too?

but I think it is better to move to a different ticket the resolution of this.

I'm very willing to pick up that ticket after this one.

Anything left for me to do on this PR?

Anything left for me to do on this PR?

I guess only the ddl scripts think mentioned here https://github.com/kiegroup/kogito-runtimes/pull/1612#discussion_r716594439

@Scuilion
Can you please apply the changes included in https://github.com/kiegroup/kogito-runtimes/pull/1612#discussion_r716594439 ?
On Monday we have sprint cutoff and I would like to include this PR 👍

@Scuilion Can you please apply the changes included in #1612 (comment) ? On Monday we have sprint cutoff and I would like to include this PR +1

commit 903d634 creates the following ddl zip
/home/kevino/projects/kogito-runtimes/addons/common/persistence ±[●][KOGITO-5921-support-for-oracle] k8sstaging/staging
> find . -name "*.zip"
./ddl/target/kogito-ddl-runtimes-2.0.0-SNAPSHOT-db-scripts.zip

/home/kevino/projects/kogito-runtimes/addons/common/persistence ±[●][KOGITO-5921-support-for-oracle] k8sstaging/staging
zipinfo ./ddl/target/kogito-ddl-runtimes-2.0.0-SNAPSHOT-db-scripts.zip
Archive:  ./ddl/target/kogito-ddl-runtimes-2.0.0-SNAPSHOT-db-scripts.zip
Zip file size: 1493 bytes, number of entries: 6
drwxr-xr-x  2.0 unx        0 b- stor 21-Sep-30 13:09 postgresql/
drwxr-xr-x  2.0 unx        0 b- stor 21-Sep-30 13:09 jdbc/
-rw-rw-r--  2.0 unx      467 bl defN 21-Sep-23 10:27 postgresql/runtime_create.sql
-rw-rw-r--  2.0 unx      285 bl defN 21-Sep-30 12:11 jdbc/create_tables_ansi.sql
-rw-rw-r--  2.0 unx      291 bl defN 21-Sep-30 12:11 jdbc/create_tables_PostgreSQL.sql
-rw-rw-r--  2.0 unx      286 bl defN 21-Sep-30 12:11 jdbc/create_tables_Oracle.sql
6 files, 1329 bytes uncompressed, 683 bytes compressed:  48.6%

The (build) Examples check has failed. Please check the logs.

Can't seem to see the details of the failed Examples build.

Jenkins rerun examples tests

woot woot!

@Scuilion Can you please apply the changes included in #1612 (comment) ? On Monday we have sprint cutoff and I would like to include this PR +1

commit 903d634 creates the following ddl zip
/home/kevino/projects/kogito-runtimes/addons/common/persistence ±[●][KOGITO-5921-support-for-oracle] k8sstaging/staging
> find . -name "*.zip"
./ddl/target/kogito-ddl-runtimes-2.0.0-SNAPSHOT-db-scripts.zip

/home/kevino/projects/kogito-runtimes/addons/common/persistence ±[●][KOGITO-5921-support-for-oracle] k8sstaging/staging
zipinfo ./ddl/target/kogito-ddl-runtimes-2.0.0-SNAPSHOT-db-scripts.zip
Archive:  ./ddl/target/kogito-ddl-runtimes-2.0.0-SNAPSHOT-db-scripts.zip
Zip file size: 1493 bytes, number of entries: 6
drwxr-xr-x  2.0 unx        0 b- stor 21-Sep-30 13:09 postgresql/
drwxr-xr-x  2.0 unx        0 b- stor 21-Sep-30 13:09 jdbc/
-rw-rw-r--  2.0 unx      467 bl defN 21-Sep-23 10:27 postgresql/runtime_create.sql
-rw-rw-r--  2.0 unx      285 bl defN 21-Sep-30 12:11 jdbc/create_tables_ansi.sql
-rw-rw-r--  2.0 unx      291 bl defN 21-Sep-30 12:11 jdbc/create_tables_PostgreSQL.sql
-rw-rw-r--  2.0 unx      286 bl defN 21-Sep-30 12:11 jdbc/create_tables_Oracle.sql
6 files, 1329 bytes uncompressed, 683 bytes compressed:  48.6%

@Scuilion thanks, its almost there, the idea is to keep a folder per database and jdbc would be the generic/ANSI version, so in that sense we need to endup with:

postgresql/runtime_create.sql
jdbc/runtime_create.sql
oracle/runtime_create.sql

Be aware that the Postgresql one is already there, so you just need to make sure that content matches.

@Scuilion
I have applied my proposed changes directly to your branch, see https://github.com/kiegroup/kogito-runtimes/pull/1612/commits/3981a6643b1f42c0e8e15fb2e4bec2579246f33f
@cristianonicolai
This the output of the script now. Is it fine for you?
The PostgreSQL script is taken by postgres addon and not from the generic one. We might revisit this if necessary

@danielezonca thanks!

The (build) Examples check has failed. Please check the logs.

The (build) Runtimes check has failed. Please check the logs.

The (build) Examples check has failed. Please check the logs.

Build failure details not available.

Build failure details not available.

Jenkins build are less reliable compared to GHA so I have approved GHA to see if this is green. I expect it is a random (or unrelated) failure

No documentation updated for oracle. Can that be done?? Only we have PostGres in documentation. Is it worth a look.


[RFC ...] additional value mutations

add null value mutation for array, object, and string literal values for JavaScript & TypeScript
add numeric value mutations: 0, 1, -1, Infinity, -Infinity, and NaN for JavaScript only (for now)
update the mutated string value to: **Stryker was here!**
include the mutated string value of **Stryker was here!** for all string literals, not just empty strings
add incremented & decremented numeric value mutations
additional refactoring & cleanup

Open question:

[ ] I wonder if some of these additional mutations should be moved into new mutators and if they should go behind any new options.

General rationale:

I do think these changes could help users avoid the trap of the "billion dollar mistake" of using null values
I have seen cases, mostly related to numeric data values in SQL databases, where the proposed numeric value mutations could help identify some more desired test cases

The numeric value mutations have already helped me find some more tests needed in a private PGP utility that I am not yet ready to publish. Here are some results I found on a couple of public repos:
On https://github.com/jonschlinkert/remove-bom-buffer which seems to be used by Gulp:

report on Stryker 2.4.0, without this proposal (jonschlinkert/remove-bom-buffer#5): https://chrisbrody.com/remove-bom-buffer-stryker-report/index.html
report with this proposal: https://chrisbrody.com/remove-bom-buffer-stryker-avm-001/index.html

With this proposal, we can see some more surviving mutants related to a string slice function call.
On https://github.com/ericelliott/riteway (https://github.com/ericelliott/riteway/pull/193):

without this proposal: https://chrisbrody.com/riteway-stryker-report-001/index.html
with this proposal: https://chrisbrody.com/riteway-stryker-avm-wip001/index.html

Here are a couple more mutants that this proposal identifies on riteway:
index a68eb08..473d508 100644
--- a/source/riteway.js
+++ b/source/riteway.js
@@ -12,7 +12,7 @@ const withRiteway = TestFunction => test => {
     should = '',
     actual = undefined,
     expected = undefined
-  } = {}) => {
+  } = null) => {
     test.same(
       actual, expected,
       `Given ${given}: should ${should}`
@@ -51,7 +51,7 @@ const createStream = tape.createStream.bind(tape);
  * @param {object} [obj] The object whose keys you wish to count.
  * @returns {number}
  */
-const countKeys = (obj = {}) => Object.keys(obj).length;
+const countKeys = (obj = null) => Object.keys(obj).length;

 export default describe;
 export { describe, Try, createStream, countKeys };

I have verified that the mocha test continues to pass on JavaScript, TypeScript, and Vue mutators.
TODO items:

[ ] When I pushed my work to GitHub, it seemed to report some e2e test failures. It looks like there is a Stryker run as well. I have not been able to run e2e test on my mac or a Ubuntu node on the cloud. Any pointers would be much appreciated.
[ ] If this project is ready to accept the proposed numeric value mutations, I would be happy to try adding them for TypeScript as well.

I don't think it's a necessity of creating multiple values like this. It is quite repetetive...
Instead of it, you could think of how to fix some of halting problems

Agreed that there are probably more values than are really needed, but I would not consider these to be 100% equivalent mutants. As I already said in the description:

I did discover some more surviving mutants in the remove-bom-buffer package
and I did discover a couple of interesting mutants of replacing {} with null in the riteway package

I hope the Stryker project will at least consider a subset of the additional mutations that I proposed here. I hope I don't have to keep them all in my own fork somewhere.

Closing for now, due to apparent lack of interest. I guess I will just have to experiment in my own fork somewhere, for now.


cli returns empty array for basal data

Not sure if I am missing something, but the csvdata["basalData"] is always an empty array, even when the the BASAL feature is specified.  What could be going on here?  IOB and boluses are returned without a problem.

You are correct -- the WS2 therapytimeline endpoint only contains pre-ControlIQ  basal data. tconnectsync currently reads from this value regardless and merges it in for processing on the chance that you're inspecting a time interval which was before controliq was enabled on the pump. (I think it's based on whether your pump supports controliq in the firmware, rather than just toggling it on or off, but I haven't checked.)
Are you querying the ws2 endpoint manually or just looking into tconnectsync's code? The therapy_timeline endpoint should have the basal data you're looking for: https://github.com/jwoglom/tconnectsync/blob/master/tconnectsync/api/controliq.py#L106

Closing this issue due to inactivity, and because tconnectsync seems to be operating as designed (per how the tconnect API functions). Please re-open or create a new issue if you're still experiencing issues.


Added custom tooltip to Header

Checklist

[x] Build process is done without errors. All tests pass in the /lib directory.
[x] Self-reviewed the code before submitting.
[x] Meets accessibility standards.
[x] Added/updated documentation to /website as needed.
[x] Added/updated tests as needed.

Description
After adding the new Tooltip component, it is required to use it instead of title in the Header component.
Related to #1968

Closed until Tooltip component lifecycle status is New.


[SURE-7621] fix: update the method to detect calico cni

Issue: https://github.com/rancher/rancher/issues/38490
Problem
When enabling the PNI on RKE2 cluster with calico CNI, the Hostnetwork Networkpolicies (hn-nodes) causes problem with traffic getting to workloads from the nodes, this problem arises because the hn-nodes netpol retrieves IP addresses from the Node's PodCIDR network, omitting the actual vxlan.calico IP address.
Solution
Set Rke2Config while creating a custom rke2 cluster and use node annotations to detect cni.
Testing

The repro steps in the issue are correct.
Engineering Testing
Manual Testing

After fixing it, I tried reproducing the issue with the same steps and got the expected result.

@jiaqiluo (primarily) @Oats87 @jakefhyde, PTAL into this PR - at a glance it looks these changes have a chance to break existing behaviors but you surely can provide more constructive feedback. Please see linked SURE-7621 for more context and @jiaqiluo 's initial investigation.

Hi I have a comment on this. It could be an issue in case no VXLAN tunnel is configured and Calico is using BGP. In that case the annotation on the node is not configured and the function will return the wrong CNI.

Can you squeeze all commits into one?

Can you squeeze all commits into one?

Done.

With Rancher 2.9.2 + RKE2 v1.30.5+rke2r1 + Cilium, there is same issue.
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  creationTimestamp: "2024-10-29T01:01:37Z"
  generation: 1
  labels:
    cattle.io/creator: norman
  name: hn-nodes
  namespace: default
  ownerReferences:
  - apiVersion: v1
    kind: Namespace
    name: default
    uid: 72397b91-1c47-4d27-825b-c746d0bde4f7
  resourceVersion: "2113"
  uid: 574232c3-e87b-4a39-af38-9ca2644bb7c6
spec:
  ingress:
  - from:
    - ipBlock:
        cidr: <IP_ADDRESS>/32
  podSelector: {}
  policyTypes:
  - Ingress

I guess we should use IP address of cilium_host@cilium_net.
4: cilium_host@cilium_net: <BROADCAST,MULTICAST,NOARP,UP,LOWER_UP> mtu 9001 qdisc noqueue state UP group default qlen 1000
    link/ether 96:36:85:b3:b8:5b brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/32 scope global cilium_host
       valid_lft forever preferred_lft forever
    inet6 fe80::9436:85ff:feb3:b85b/64 scope link
       valid_lft forever preferred_lft forever

Does this patch fixe the Cilium issue as well?

@masap The fix only addresses the calico CNI.


include-entry-exports per package

We're in a monorepo that has both internal packages and packages (libs) that we both consume internally and publish.
We're currently not using include-entry-exports because it would flag false-positives for the exported packages.
One idea would be to allow to set that option "per package" so that we can define some packages to be excluded from that check.
Let me know what you think or if you have a better idea to address this, thanks.

I think we could re-structure from having everything in packages to something like app and libs and running knip twice, once against app with --include-entry-points and once against libs without 🤔 ...

what works is adding the entry files of libs we publish to ignore. This is good enough for me at the moment because it's only 2 libs. So feel free to close this if you don't like the suggestion because it has a workaround :)

Thanks Dominik, I like the suggestion (to configure it on workspace level). I think it's a fairly common use case. I'm probably going to include it soon in the upcoming v3.

what works is adding the entry files of libs we publish to ignore.

hmm I'm circling back on that, because that doesn't work. Maybe I'm misunderstanding what ignore is doing? I guess this also comes back to this question:

#340

basically, the generated export reads:
Unused exports (2)
someExport           packages/my-lib/src/index.ts
someOtherExport      packages/my-lib/src/index.ts

And I'd like to say: Oh yeah, this is one of the libs we export, so please ignore all errors from packages/my-lib/src/index.ts because that's actually a public entry point.
but when I add:
ignore: [
  'packages/my-lib/src/index.ts',
]

the errors still show up 🤔 . Not sure where I'm going wrong here. I guess I could write a preprocessor for the report and exclude those lines, but not sure if I'm going somewhere horribly wrong here 😅

A few things about this:

The ignore is a filter applied to what goes into the program, it does not filter results
I totally understand this is very confusing, also when looking at the other options that came later:

ignoreBinaries and ignoreDependencies are actually filters on the results
ignoreWorkspaces is a filter on the input

The ignore option should work better when placed inside the workspace config (where this becomes ignore: ['src/index.ts'] in the packages/my-lib workspace config.
You can use --debug to see the glob actions taken, including the ignored items and the resulting files that go into the program.
Eventually there's lists of resolved files in the debug output, and here's the thing: the ignore config has no influence at all on the module resolution and the files TS adds to the program. It prevents entry files from initially being added, but if TS decides it's imported somewhere and makes it part of the program then currently it has the last word on this.

So, the least I can do is document this better, but it also needs a bit more thinking through :)

So actually yeah, at this point, if moving the ignore option to the workspace config doesn't help, that preprocessor is a way out if you really need it.

:rocket: This issue has been resolved in v3.0.0-canary.2. See Release 3.0.0-canary.2 for release notes.


SC-22471/primehub-sdk-ct-pipeline

Add primehub-sdk-ct-pipeline into the repo.

Remember to clean the output of ipynb before commit.

Remember to clean the output of ipynb before commit.

If the output is for user to read clearly, can keep it.


Different output when using react-native-bignumber and bn.js

I'm trying to use this package in a project which uses elliptic and one of the functions produce different output when using react-native-bignumber and bn.js. I managed to identify piece of code that returns different output. I tested it in the example app of react-native-bignumber. The code looks pretty much like this.
import bn_elliptic from 'bn_elliptic';
import elliptic from 'elliptic';

const secp256k1 = new elliptic.ec('secp256k1');
const bn_secp256k1 = new bn_elliptic.ec('secp256k1');

const kI =
  '9dc74cbfd383980fb4ae5d2680acddac9dac956dca65a28c80ac9c847c2374e4';
const n = secp256k1.curve.n;
const G = secp256k1.curve.g;
const Q = G.mul(kI);

const n_BN = bn_secp256k1.curve.n;
const G_BN = bn_secp256k1.curve.g;
const Q_BN = G_BN.mul(kI);

console.log(Q.x.umod(n));
// output: e696d0036454d7b7890bd425947329f68d9c7c0e2de44958e5700a30ca98b02c
console.log(Q_BN.x.umod(n_BN));
// output: 54c4a33c6423d689378f160a7ff8b61330444abb58fb470f96ea16d99d4a2fed

It looks like there are some differences in umod implementation but I might be wrong.

any news ?

we'll take a look

Hey!
I started working on the issue. Seems like problem with umod indeed. However, I need to take a closer looks as Q.x looks to be a red number. I'm not sure what umod in a field would mean to be honest :D
Will do my best to resolve it this week.

Same issue. Trying to use tronweb.fromMnemonic (uses elliptic under the hood).

Sorry guys!
I was super busy in December and completely forgot about the issue.
I found the issue and opened a pr with the fix.


Run actions from rule sequentially (#4)

realization #4

Pull Request Test Coverage Report for Build 28

50 of 50 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 26:
0.0%

Covered Lines:
1118

Relevant Lines:
1118

💛  - Coveralls


Linked @drawable/magisk to custom hidden Magisk app

Description

Ignore this PR. I made it so that I can take the Debug APK generated from the check and use it. For some reason every time I installed Lawnicons via ADB through Android Studio, the app crashes instead of opening with the grid of submitted icons.
If you can help me with the crash though it will be appreciated. Here's the log: lawnicons error.txt

Type of change

:x: Bug fix (non-breaking change which fixes an issue)
:x: Icon addition (non-breaking change that adds/modifies Lawnicons's icons)
:x: General change (non-breaking change that doesn't fit the above categories like copyediting)

Icons addition information

Icons added

App Name (package.name) - added from icon request form
App Name (package.name)
App Name (package.name)

Icons updated

App Name (package.name)
App Name (package.name)

Icons linked

App Name (linked package.name to @drawable/package)
App Name (linked package.name to @drawable/package)

@ZhmieXD you can download the debug APK from your own Lawnicons fork.
Can this PR be closed? As for the crash, I'm not sure what happened. Maybe others will know

@ZhmieXD you can download the debug APK from your own Lawnicons fork.
Can this PR be closed? As for the crash, I'm not sure what happened. Maybe others will know

Yeah I wish I didn't have to create a PR just to download the debug APK from my own fork, but the apk is generated only if I made a PR, or at least that what I know ^^;
If the latter's the case, how to generate the debug APK without making a PR?

If the latter's the case, how to generate the debug APK without making a PR?

Okay nevermind, I got it, just googled how to run a workflow manually on GitHub ^^;
As for the crash, yeah reimporting the project didn't work last time, and neither does rebasing and cleaning up. I think I'll just reinstall Android Studio or wait for any updates for it.
Thanks once again! will close the PR in a moment and try to manually run the workflow again 😄


Refactor code from ES6/ES2020 to Typescript

Hey @jonathanpmartins I forked the project and started this refactory, take a look feat/refactory#41
Feel free to add me on Discord Giovane Souza#8309 if you want to discuss about what I'm doing.
I decided to give a help with the project during my current vacations.

What a good surprise!
I open this issue near 2 weeks ago but haven't had time to tackle it.
Now I think it will happen shortly.
Good initiative! Thank you...

Merged in this pull request: https://github.com/jonathanpmartins/v-money3/pull/46
Published as 3.19.0. Thank you very much!


fix number of digits used in abbreviated git commit hashes

Git now uses a dynamic length for the number of digits in hashes printed by git describe:
https://github.com/git/git/commit/e6c587c733b4634030b353f4024794b08bc86892
For the purposes of versioneer, where the commit remains unambiguous due to the tag and distance being included in the output, I propose fixing the number of digits to some value (we use 8 in our project). This can be achieved by adding --abbrev=8 to the git command line (https://github.com/m-labs/artiq/commit/076e4119f744c07afaa6f6cd840a45dfcd13718e).
The default git behavior can result in annoying inconsistencies and bugs. In our project, we have several conda packages built from the same repository. For reasons that I do not fully understand, git ended up using different number of characters for the hash lengths in the version numbers of each, causing further problems later on.

Missed this issue. Please feel free to submit a PR.


Please deploy dfn.js or something similar

https://resources.whatwg.org/dfn.js as it stands now it is too hard to find out where a given definition is referenced from.

We should look to move to bikeshed

Is the only thing stopping us from moving to bikeshed that nobody has volunteered yet to put in the work needed to do so? Or are there particular reasons why we might want to delay moving to bikeshed. If the consensus is that yes, we should move to bikeshed, I'd be happy to volunteer to do so (I've converted two other specs to bikeshed, so I've some idea what I'm signing up for, although those were of course way smaller than the service worker spec).
Anyway, some thoughts about the consequences of a conversion to bikeshed:

Styling will be different, hopefully for the better.
Deep links to sections and definitions should mostly remain the same, but links to IDL definitions will change as bikeshed doesn't have a way to specify your own anchors for those (even if it would I don't think we'd want to hardcode these anyway). Some section anchors might have to change too for this, since they conflict with the bikeshed generated IDL anchors.
Any outstanding pull requests or other changes people are working on will have to be manually rebased. This also might be a reason to do the conversion while v1 and v2 haven't diverged too much yet, as then we can convert both without extra effort.
Major changes to the spec while I'm working on the conversion to bikeshed would of course be annoying as I'd have to manually re-apply them on top of the bikeshed version. But the spec is probably stable enough at this point for this to not matter too much for however long this will take; re-applying a week (or a few weeks) worth of changes on top of a bikeshed conversion should be relatively painless.
Actually reviewing the conversion might be hard, since it'll be a fairly substantial change. Although splitting the conversion in several commits might make this slightly better, in the end still pretty much every line of spec source will change for this:

one commit to update the overall structure to be bikeshed compatible while keeping most of the actual content unchanged
one commit to update definitions and references to them to be bikeshed compatible; we could choose to keep explicit links to locally defined terms to keep the diff somewhat managable (and optionally clean those up in a separate commit), or just go all the way and clean up internal links as well. Either way this will be a pretty nasty diff to review as it'll change so much all over the place.
other cleanups as we see fit.

So is there consensus that moving to bikeshed is a good thing, and if so, when would it make sense to do so?

links to IDL definitions will change as bikeshed doesn't have a way to specify your own anchors for those

You can if you do a <dfn> for the construct outside of the <pre class=idl>.  Then Bikeshed will just link the IDL to your dfn.  This is common practice for methods and attributes, so their anchors are actually close to their prose definitions.
If you've been using the "WHATWG style" for IDL IDs (dom-foo-bar for the Foo.bar attribute, etc), Bikeshed does that by default, so the IDs will remain stable.

Note that Bikeshed does not currently have dfn.js built in.  You can just link it in yourself for now, I'm just noting that moving to Bikeshed will not actually solve the problem this issue was opened for. ^_^
(I'll be working on Bikeshed all this month, and I think dfn.js support is on my issues list, so maybe I'll fix it anyway, and you can close this issue just by porting.)

You can if you do a  for the construct outside of the . Then Bikeshed will just link the IDL to your dfn. This is common practice for methods and attributes, so their anchors are actually close to their prose definitions.

Ah, good point. Not sure why it never occurred to me to specify explicit ids for such dfn's. I guess because unlike for every other dfn bikeshed doesn't complain about having to auto-generate ids for them... I guess that just leaves the question if we want to use the auto-generated "whatwg style" ids or keep using the currently used explicit ones. Probably keeping IDs stable is a good idea in that case, since all the ids are there already so it's not actually any more work. For future additions using watwg style IDL IDs might make sense though.

Note that Bikeshed does not currently have dfn.js built in. You can just link it in yourself for now, I'm just noting that moving to Bikeshed will not actually solve the problem this issue was opened for. ^_^

Ah, good point. I should have probably opened a separate issue for the actual bikeshed migration in that case. But it doesn't look like adding dfn.js support should be very hard either way.

Having discussed with @slightlyoff, we agree to this conversion if bikeshed adds value in the way we collaborate and some convenience to the readers.
@mkruisselbrink, @slightlyoff added you as a collaboration in the repo. Please help us!

If this removes the dynamic content/style updates, then it would make the spec easier for me to use.  Right now the scroll positions all change after navigating to a section anchor directly.  Very annoying.

@mkruisselbrink has converted the spec to Bikeshed. Closing.

Closing might be premature until tabatkins/bikeshed#469 is resolved and bikeshed actually includes dfn.js?

Note that Bikeshed does not currently have dfn.js built in. You can just link it in yourself for now, I'm just noting that moving to Bikeshed will not actually solve the problem this issue was opened for. ^_^

Yes, Bikeshed conversion was a good idea, but as I said earlier, it's a diversion from the actual purpose of this thread, which is to get dfn.js on the spec.

Note: I've been building the dfn.js functionality directly into Bikeshed, so the panels are generated statically and only have a tiny JS dependency for the show/hide functionality. I plan to turn this on by default later today unless someone objects, so the conversion to Bikeshed was a good idea. ^_^


Update Composer dependencies (2024-03-14-00-13)

Visual regression test passed!
View the visual regression test report