[SPARK-27023][K8S] Make k8s client timeouts configurable

What changes were proposed in this pull request?
Make k8s client timeouts configurable. No test suite exists for the client factory class, happy to add one if needed

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

cc @liyinan926 .

@dongjoon-hyun @liyinan926 @mccheah This is ready for review

ok to test

Test build #103017 has started for PR 23928 at commit a0b88a3.

Test build #103017 has finished for PR 23928 at commit a0b88a3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103017/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/8483/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/8483/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8483/
Test PASSed.

Test build #103043 has started for PR 23928 at commit 7f83722.

Test build #103044 has started for PR 23928 at commit ad17a02.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/8506/

@dongjoon-hyun @liyinan926 ready for another look

Test build #103043 has finished for PR 23928 at commit 7f83722.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103043/
Test PASSed.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/8506/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8506/
Test PASSed.

Test build #103044 has finished for PR 23928 at commit ad17a02.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103044/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/8507/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/8507/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8507/
Test PASSed.

Test build #103063 has started for PR 23928 at commit a316760.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/8525/

Test build #103064 has started for PR 23928 at commit e7fa51c.

Test build #103063 has finished for PR 23928 at commit a316760.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103063/
Test PASSed.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/8525/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8525/
Test PASSed.

Test build #103064 has finished for PR 23928 at commit e7fa51c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103064/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/8526/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/8526/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8526/
Test PASSed.

Test build #103085 has started for PR 23928 at commit 280c176.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/8548/

Test build #103085 has finished for PR 23928 at commit 280c176.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103085/
Test PASSed.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/8548/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8548/
Test PASSed.

@dongjoon-hyun thanks for reviewing, addressed.

+1, LGTM except one minor comment. Thank you for your patience, @onursatici .

Test build #103106 has started for PR 23928 at commit 1902a13.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/8568/

Test build #103106 has finished for PR 23928 at commit 1902a13.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103106/
Test PASSed.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/8568/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8568/
Test PASSed.

Thank you, @onursatici and @liyinan926 .
Merged to master.


Lock cheerio version down (enzyme depedency)

Errors in one of my PR branches led me to the post below. There is aproblem with enzyme 3.11.0 which is pulling the latest cheerio RC release 1.0.0-rc.11. The next release of Enzyme will be locking down the cheerio version to 1.0.0-rc.3.  The workaround is to add this version as a dev dependency.
https://github.com/enzymejs/enzyme/issues/2518
Errors received:
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './lib/utils' is not defined by "exports" in<EMAIL_ADDRESS>at new NodeError (node:internal/errors:371:5)
at throwExportsNotFound (node:internal/modules/esm/resolve:440:9)
at packageExportsResolve (node:internal/modules/esm/resolve:692:3)
at resolveExports (node:internal/modules/cjs/loader:482:36)
at Function.Module._findPath (node:internal/modules/cjs/loader:522:31)
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:919:27)
at Function.Module._resolveFilename.sharedData.moduleResolveFilenameHook.installedValue [as _resolveFilename] (D:\vsts_a\1\s\common\temp\node_modules.pnpm@cspotcode+source-map-support@0.8.1\node_modules@cspotcode\source-map-support\source-map-support.js:811:30)
at Function.Module._load (node:internal/modules/cjs/loader:778:27)

@christophermlawson could we instead lock down the version of enzyme we're using?

@calebmshafer I was concerned about messing with the direct dependencies (I have not worked on this packages).  I would have to look at past releases of Enzyme to determine when they weren't using the 'compatible version' ^ syntax on cheerio.  It could be that enzyme/cheerio dependency has not changed in a while, but a new cheerio version came out which is causing the issue.

@calebmshafer I was concerned about messing with the direct dependencies (I have not worked on this packages). I would have to look at past releases of Enzyme to determine when they weren't using the 'compatible version' ^ syntax on cheerio. It could be that enzyme/cheerio dependency has not changed in a while, but a new cheerio version came out which is causing the issue.

@christophermlawson let's lock down that dep directly. We can take a look if you don't have the time to do so.

@calebmshafer I was getting errors locking down on 3.4.0.  I moved to 3.10.0 and everything appears to work fine.

@calebmshafer Thanks!


Support Coq 8.16 and 8.17

There are still some unresolved problems in theories/Crypt/package/pkg_rhl.v related to setoid rewrite, probably caused by the 8.16 change:

The RewriteRelation type class is now used to declare relations inferrable by the setoid_rewrite tactic to construct Proper instances. This can break developments that relied on existing Reflexive instances to infer relations. The fix is to simply add a (backwards compatible) RewriteRelation declaration for the relation. This change allows to set stricter modes on the relation type classes Reflexive, Symmetric, etc. (#13969, fixes #7916)

@TheoWinterhalter Do you have any idea how to solve the setoid rewrite problem in pkg_rhl.v?
I couldn't get it working.

Have you tried the fix you mentioned?

The fix is to simply add a (backwards compatible) RewriteRelation declaration for the relation.

Ok, so I found how to make it work again and it seems unrelated to the change you mention.
For instance adding the following before rswap_ruleR:
#[export] Instance bind_morphism (A B : choiceType) :
  Morphisms.Proper
    (Morphisms.respectful eq
      (Morphisms.respectful (Morphisms.pointwise_relation A eq) eq))
    (@bindrFree (@ops_StP heap_choiceType) (@ar_StP heap_choiceType) A B).
Proof.
  unshelve RelationClasses.simpl_relation.
  f_equal. apply functional_extensionality. auto.
Qed.

Thank you for the help fixing it. I will finish up the remaining work later today.
I think the problem is related to the change that I mentioned. I had a look at the proof term before the proof broke and it did look like it used Reflexive instances. So your fix likely bypasses the problem since typeclass resolution now can find a different solution that doesn't depend on Reflexive.

Ok, if you find a better solution, then please do. Otherwise I guess we'll live with it.

Thanks!


Dynamic Network

Synopsis
We might face capacity shortages when it comes to bring nodes active on both sides (clearnet / tor network). That's why it would make sense to introduce dynamic nodes for them who have to use the clearnet mode since the node would now be shared between both networks by default. Which makes it easy to share blocks etc. throughout both networks.
Right now you have to solely build your tor proxy on top of a clearnet node in order to archieve this very approach. Which isn't quite easy for exchanges and/or miners to handle thus I would suggest to activate the dynamic network.
Technical Idea
Clearnet vs Tor-Net
your node         <->     other clearnet nodes
proxy nodes       <->     all nodes
tor node          <->     tor nodes

Dynamic Networking
(keeps tor networking + removes the restrictions from clearnet routes)
your dyn. node    <->     other clearnet nodes
    ↕
tor node          <->     tor nodes

ACK

the main problem for using mining on tor-enabled nodes is the misbehaviour of timedrift-calculation leading to 'time-too-new' errors. fixing this + adding some reserved connection slots for clearnet-only would help to get connected to both worlds

Since the upgrade to V6 I haven't discovered any occurance of time-too-new errors. I assume that we got rid off it, since now all v6's are creating the blocks and thus it's not possible to create the "time-too-new" error as it would be quickly declined by the network.
but regarding the second point I have no good idea how to deal with this. I mean we could just devide connections slots by 50/50 so that you can't have only either clearnet nodes nor only tor nodes, but that will take some more efforts I think. Let's investigate :)

there was no change of code in v6 on this, the issue is still there.
taken from current logfile:
2019-12-28T21:12:54Z ERROR: AcceptBlockHeader: Consensus::ContextualCheckBlockHeader: aa5fb241e2a1488206de44060f6a396dd1e0dd90e23412d4376690343ea26721, time-too-new, block timestamp too far in the future (code 16)

Too me this feels like we falsely calculate the max block drift in V6:
https://github.com/vergecurrency/VERGE/blob/349c3653416f58242be57bffdd1774fae86660af/src/validation.cpp#L3323-L3328
to me this should be ... * 1000 since timestamps are defined in ms, but well .. 🤔

Getting this log error all the time:
2020-01-07T12:43:07Z ERROR: AcceptBlockHeader: Consensus::ContextualCheckBlockHeader: 65396b5bba56a6311e0b61c3ca3bc37d9404eed1147ebb12a699da860ebc70e7, time-too-new, block timestamp too far in the future (code 16)

Getting this log error all the time:
2020-01-07T12:43:07Z ERROR: AcceptBlockHeader: Consensus::ContextualCheckBlockHeader: 65396b5bba56a6311e0b61c3ca3bc37d9404eed1147ebb12a699da860ebc70e7, time-too-new, block timestamp too far in the future (code 16)

Seems like it is due to this piece of code: https://github.com/vergecurrency/VERGE/issues/1009#issuecomment-569456329
But I would have to investigate if timestamps are now in seconds rather than minutes, but yeah it's a known issue

for mining nodes it would be an option to disable calculation of local timedrift (https://github.com/vergecurrency/VERGE/blob/1a49a2cfd01d12e1e3135905a922ee6c1c0da47e/src/net_processing.cpp#L1819). a accurate local time is essential for mining, so its better to trust on local time then timedrift from remote sources.

Partially released with a non-fixed count of clearnet nodes. Usually (never had the case) we never ran out of clearnet connection tho.

@tpfuemp @skinderis To me this feels like the max-time-drift is false rather than the time transmitted from the peers itself. I think we have to allow more drift. The V4 has the same function as in V6 but for some reason I assume that the V4 calcuated everything is seconds and now everything is present in milliseconds.
That's also why, raising the max-drift * 1000, is perfectly resolving this very issue. I'm clearly aware of the consequences of such an change, but anyhow. This needs investigation.

a 10 minute drift time is pretty massive already -_-


Database maintenance

Great API, cannot find anything better out there. Big up to the author. Too bad the db is not updated every month.
Who is updating the database?
Does the api author has plans to allow for more regular updates? entrusting 3rd parties maybe or at least allowing pull requests?
Also would be great to have a type property in the JSON (smartphone/tablet/watch etc) and even better have an updated status property.
This might be possible with community work...!

https://github.com/shakee93/fonoapi/issues/73


Calendar widget shows the same old date and does not update

Calendar leaves old date and I have to remove one of my calendar in filter and then put it back so my widget show the correct date.

Hello @garthygarth . Please check that in the widget's Settings -> Other settings -> "Lock list of events" is set to "Live data from real sources".
In a case it is not, your widget works in a "Snapshot mode", and will always show the same date and the same events.

Hi Yovlk
I can seem to find this option on my calendar or my calendar widget app

Lock list of events ("Snapshot mode") was added in "ToDo Agenda" v.4.0.6

This is the options I get when I go into the widget are we talking about the same widget for android phones Samsung

@garthygarth Yes, the same widget , but you use some old version. At the end of 2018 "Calendar widget" was renamed to "ToDo Agenda". See and download new version: https://github.com/andstatus/todoagenda#readme

Super thanks for that you are a rock star


[Feature Request/Customisation Question] Adding additional 4 character file types for the newer Office documents (e.g. docx)

This is an amazing tool overall, but I was looking to add .docx, .xlsx and .pptx to the narrow down and exclude by file types lists.
I am not a programmer, but just try to use some common sense to do things.
I find this in index.html:
doc
I cannot find any other references in index.html, main.js or styles.css to "doc" or "doc-file-narrow", so I tried to edit it to:
docx
When I do this, a docx option does show on the page, but when clicked, it adds -filetype:docx to the search string even though this is in the narrow down and not the excude section
I saw a file type length set to 3 in main.js which I changed to 4 but the docx issue is not fixed, and now a hyphen is added to the end of all of the 3 character file type strings, like filetype:txt-
I can't see anything else I can change and my knowledge stops here.
Is there any way to add my own 4 character file type button of my own or shall I just always manually type it as a custom type?
Thanks

I have found myself needing this functionality too recently, and I have had to type in the extension manually. Would love to be able to add my own custom ones easily!

Will look into it @Lewis8379


Add user deletion feature for admins

Overview
Resolves #29
Changelog

Added user deletion logic for admin users

Code LGTM, but should admin deletion also have a confirmation pop up?


⚠ Bofrost.de has degraded performance

In f52554f, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 989 ms

Resolved: Bofrost.de performance has improved in 9f31e6c after 42 minutes.


AMBARI-25713 : Upgrade commons-io to 2.8.0 to resolve CVEs

What changes were proposed in this pull request?
Upgrade commons-io to 2.8.0 to resolve CVEs
How was this patch tested?
Verified it was built ok. Started the server and installed a few services.

+1. lgtm. @AnanyaSingh2121  thanks your contribution.


Partio export

I am fairly new to animation and I was wondering about the export format of the simulations. I see that the individual frames are saved to .bgeo files, but I am having trouble figuring out what to do with those. I see that they are viewable with the PartioViewer, but I have only been able to view the individual frames that way. I was wondering how to view the files created by the simulations as a video.

bgeo files can be directly imported in Houdini. For Maya you need an additional plugin like:
http://redpawfx.github.io/partio/
Or you can use these files to reconstruct the surface of the fluids with tools like:
http://www.mootzoid.com/plugin/empolygonizer5

Awesome, thanks for the information!


Start of the basic database collections.

Start on the basic database collections to start adding functionality to our app.
Issue-16

[ ] Username
[ ] User password
[ ] Email
[ ] Address
[ ] Car information (license plate #, model, color)
[ ] etc...

Please see issue #15 for progress made there. I have basically finished the user portion of the database collection.


Service alias changes don't correctly propagate to loadbalancer

We are seeing an issue where changes to service alias do not properly make it to the HAProxy loadbalancer.
Our setup is LB -> Alias -> Service stack. We deploy by creating a new stack and once it is up and running we switch the alias to the new stack. This worked perfectly in Rancher v1.2.1.
But we recently migrated to v.1.6.10 and something seems broken. This happens both from the UI and via CLI.
As you can see, we have two stacks, two containers each, and alias pointing to only one.

API also shows only one service link.
But in the LB config all four containers are listed as backends:

When changing the alias again and again we see that haproxy_new.cfg is propagated to the container, but still contains 4 backends:

And from logs I can confirm traffic is balanced between 4 containers:

So it seems that during the initial alias change all four containers are briefly "active". In the UI we can clearly see for a few seconds the alias pointing to both. This change gets to the LB. But then the removal of old stack no longer propagates and currently the only solution we have worked out is to stop/delete the old stack.
Rancher versions:
rancher/server: v1.6.10
rancher/agent: v1.2.6
Infrastructure Stack versions:
healthcheck: v0.3.3
ipsec: v0.11.9
network-services: v0.7.8 (manager) and v0.9.4 (metadata)
scheduler: v0.8.2
Docker version: (docker version,docker info preferred)
Containers: 29
 Running: 28
 Paused: 0
 Stopped: 1
Images: 28
Server Version: 17.03.2-ce
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 271
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 4ab9917febca54791c5f071a9d1f404867857fcc
runc version: 54296cf40ad8143b62dbcaa1d90e520a2136ddfe
init version: 949e6fa
Security Options:
 apparmor
 seccomp
  Profile: default
Kernel Version: 4.4.0-97-generic
Operating System: Ubuntu 16.04.3 LTS
OSType: linux
Architecture: x86_64
CPUs: 8
Total Memory: 15.67 GiB
Name: pm-dhost-1
ID: BDKZ:26EO:UUAL:DA5Z:Q4A4:2WX4:TFKF:CMF4:K2DK:LPHS:JYP4:F52F
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

WARNING: No swap limit support

Operating system and kernel: (cat /etc/os-release, uname -r preferred)
NAME="Ubuntu"
VERSION="16.04.3 LTS (Xenial Xerus)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 16.04.3 LTS"
VERSION_ID="16.04"
HOME_URL="http://www.ubuntu.com/"
SUPPORT_URL="http://help.ubuntu.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"
VERSION_CODENAME=xenial
UBUNTU_CODENAME=xenial

4.4.0-97-generic

Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
OpenStack
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single rancher, DB running in a container on the same host.
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
Cattle

I tried to reproduce this and created a small Rancher setup on my own machine. Everything works. So I suspect this is related to the latency within a larger setup. Maybe related to internal DNS?
Alias change on my own machine was instant.

Yes - I can confirm DNS retains the old alias and returns both new and old stack container IPs.
curl -vvv secure-token-service-production.secure-token-service.rancher.internal
* Rebuilt URL to: secure-token-service-production.secure-token-service.rancher.internal/
*   Trying <IP_ADDRESS>...
* connect to <IP_ADDRESS> port 80 failed: Connection refused
*   Trying <IP_ADDRESS>...
* connect to <IP_ADDRESS> port 80 failed: Connection refused
*   Trying <IP_ADDRESS>...
* connect to <IP_ADDRESS> port 80 failed: Connection refused
*   Trying <IP_ADDRESS>...
* connect to <IP_ADDRESS> port 80 failed: Connection refused
* Failed to connect to secure-token-service-production.secure-token-service.rancher.internal port 80: Connection refused
* Closing connection 0

Upgraded to latest stable v.1.16.12 and upgraded all the infrastructure and LB stacks to latest - the issue still persists.

Will anyone look at this? It is very simple to reproduce using the following steps:

Setup a stack containing a load balancer and a service alias named alias
In the load balancer container run watch -n 0.1 "curl -v -o /dev/null alias 2>&1 | grep 'Connected to alias'" (use this because ping is not available)
Observe a single IP is returned (assuming that the alias points to a service with only one container)
Edit the alias and change it to point to another service with only 1 container
Observe that both IPs are still returned even though the alias now points towards the second service

The firs IP is removed from the alias only when the container is stopped.

Thanks for your report!
With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.
If you think we should keep this issue open, please let me know.


[homepage] add version number on frontpage

From this issue https://github.com/Inria-Asclepios/medInria-public/issues/128
On the Homepage, in the little text describing the project:
"MUSIC (X.Y.Y) is a software developed ..."
It would make discussion with users easier.

:m:

Github just killed the 'Loïc approved' label :'(

Actually not, their approval doesn't bring much.

Hehehe how did you do that?

In Files changes, at the very right there is something called Review ***.

And you can approve several times :)


folding

Is it possible to add folding?  When working with large templates that have nested blocks, I would like to fold outer blocks so that I can see the overall structure.
Not sure if this is related or not - but is it possible to add tagbar support so that you can view the outline of the document more easily?

Unfortunately I'm not sure how folding works so I won't be able to add it. I'll leave the issue open so perhaps someday a nice contributor can add support for folding.


Add app.yaml config file

This file needs to be added in the root of the project for correct deployment.

The app.yaml is not needed anymore


Clicking the notification with the app in foreground has data missing

@evollu
I've been working on getting the on click working properly for my notifications, currently focusing on android. I have the on click for killed, and background working great but I'm having trouble when the app is in the foreground.  When the notification is first received, all the data I need is there but when I click on it all the data I need for my on click function is stripped out. Is there a solution for this?
Console log for when notification is received:

Console log for when that same notification is clicked:

My payload is:
           body = {
                "to": this.chat.token,
                "content_available": true,
                "priority": "high",
                //"click_action": "fcm.ACTION.OPEN_NOTIFICATION",
                "data": {
                    "senderUid": this.user.uid,
                    "chatDocId": this.chat.docId,
                    "messageDocId": messageDoc.id,
                    "show_in_foreground": true,
                    "companyName": this.chat.users[`${this.user.uid}`].companyName,
                    "groupChat": this.chat.groupChat,
                    "color":"#a7ffeb",
                    "priority":"high",
                    "id": this.chat.docId,
                    "show_in_foreground": true,
                    "sound": "default",
                    "click_action": "fcm.ACTION.HELLO",
                    "vibrate": 300,
                    "lights": true,
                    "senderUid": this.user.uid,
                    "chatDocId": this.chat.docId,
                    "messageDocId": messageDoc.id,
                    "body": messageText,
                    "title": this.user.displayName,
                    "icon": "notification_icon",
                },
                notification: {
                    "body": messageText,
                    "title": this.user.displayName,
                    "click_action": "fcm.ACTION.HELLO",
                    "sound": "default",
                    "vibrate": 300,
                    "lights": true,
                }

So to be clear the the important data that is missing is
                    "senderUid": this.user.uid,
                    "chatDocId": this.chat.docId,
                    "messageDocId": messageDoc.id,
                    "companyName": this.chat.users[`${this.user.uid}`].companyName,

What version of RN and react-native-fcm are you running?
"react-native": "^0.49.3",
"react-native-fcm": "^12.0.0",

What device are you using? (e.g iOS9 emulator, Android 6 device)?
Android

Is your app running in foreground, background or not running?
foreground

since you are using FCM's SDK to build notification, try adding these information inside notification property?

@evollu sorry for the delay, got swamped.
If I added the information into the notification property, it still doesn't show.

just realized you are using android. data piece gets eaten by FCM when sent with notification and app is running. use custom_notification

Ok I will test this. I was actually using custom_notification before but switched to notification + data because something wasn't working. Will get back to you soon

@evollu
Switching to this payload:
                "data":{
                    "custom_notification": {
                        "senderUid": this.user.uid,
                        "chatDocId": this.chat.docId,
                        "messageDocId": messageDoc.id,
                        "show_in_foreground": true,
                        "companyName": this.chat.users[`${this.user.uid}`].companyName,
                        "groupChat": this.chat.groupChat,
                        "color":"#a7ffeb",
                        "priority":"high",
                        "id": this.chat.docId,
                        "show_in_foreground": true,
                        "sound": "default",
                        "click_action": "fcm.ACTION.HELLO",
                        "vibrate": 300,
                        "lights": true,
                        "senderUid": this.user.uid,
                        "chatDocId": this.chat.docId,
                        "messageDocId": messageDoc.id,
                        "body": messageText,
                        "title": this.user.displayName,
                        "icon": "notification_icon",
                    }
                }

Fixed the issue, I can now receive the data in foreground and background when clicking the notification. But I'm not receiving a notification in the killed state anymore... Not sure what happened there.

@evollu
NVM it was just the XIAO MI phone, I can now receive notifications on all 3 states as well as receive the data when clicking on the notification in all 3 states.
thanks!

cool

@rtman So, it does not work in killed state in a XiaoMi phone? As for me also it works in all 3 states in other phones except XiaoMi devices.

@sahil290791
You have to enable AutoStart in Settings > Installed Apps > Your App Name > Autostart.
Really annoying that xiaomi does this.

@rtman I am seeing AutoStart option inside installed Apps > My App, do I need to add anything in AndroidManifest?

@rtman got it searched in settings, it was inside some security settings, may be its different in Mi phones running 7.0 .


fabric-ca-client and fabric-ca-server build fails on s390x in v1.5.7  - likely due to commit d575f40e

My builds of fabric-ca-client and fabric-ca-server on s390x (for both native binary and Docker image) are failing with Fabric-ca release v1.5.7.  They succeeded in v.1.5.6.  The builds appear to have broken after commit d575f40e which changed the mathlib dependency.  (Things work with the commit immediately prior to d575f40e).
Here are some commands that show my environment and the steps to reproduce the error.  Error is shown for the fabric-ca-client native build failure- similar error occurs for fabric-ca-server native build and for docker image build.
barry@fabric01:~/go/src/github.com/silliman/fabric-ca$ cat /etc/os-release
NAME="Ubuntu"
VERSION="20.04.6 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.6 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

barry@fabric01:~/go/src/github.com/silliman/fabric-ca$ uname -a
Linux fabric01 5.4.0-159-generic #176-Ubuntu SMP Mon Aug 14 12:03:34 UTC 2023 s390x s390x s390x GNU/Linux

barry@fabric01:~/go/src/github.com/silliman/fabric-ca$ go version
go version go1.20.7 linux/s390x

barry@fabric01:~/go/src/github.com/silliman/fabric-ca$ git checkout v1.5.7
Previous HEAD position was d575f40e This PR brings the following: - prepare the revocation handle as expected by the idemix lib - idemix: export revocation handle in SignerConfig - update idemix and mathlib dep - add logs to idemix issuer - doc update
HEAD is now at 86c6b463 Release commit for v1.5.7

barry@fabric01:~/go/src/github.com/silliman/fabric-ca$ make fabric-ca-client
Building fabric-ca-client in bin directory ...
# github.com/IBM/mathlib/driver/kilic
vendor/github.com/IBM/mathlib/driver/kilic/custom.go:137:2: undefined: mul
vendor/github.com/IBM/mathlib/driver/kilic/custom.go:148:2: undefined: mul
vendor/github.com/IBM/mathlib/driver/kilic/custom.go:152:2: undefined: mul
vendor/github.com/IBM/mathlib/driver/kilic/custom.go:155:2: undefined: mul
vendor/github.com/IBM/mathlib/driver/kilic/custom.go:156:2: undefined: mul
vendor/github.com/IBM/mathlib/driver/kilic/custom.go:158:2: undefined: mul
vendor/github.com/IBM/mathlib/driver/kilic/custom.go:327:2: undefined: mul
make: *** [Makefile:106: bin/fabric-ca-client] Error 1

barry@fabric01:~/go/src/github.com/silliman/fabric-ca$ git checkout v1.5.6
Previous HEAD position was 86c6b463 Release commit for v1.5.7
HEAD is now at 47a32f27 Release commit for v1.5.6 (#358)

barry@fabric01:~/go/src/github.com/silliman/fabric-ca$ make fabric-ca-client
Building fabric-ca-client in bin directory ...
Built bin/fabric-ca-client

A recent github.com/IBM/mathlib update introduced an architecture specific build tag.
I see that a "generic" implementation for mul() is available here:
https://github.com/IBM/mathlib/blob/main/driver/kilic/custom_generic.go#L53
This file has a build tag of //go:build !amd64 || generic:
https://github.com/IBM/mathlib/blob/main/driver/kilic/custom_generic.go#L1
Based on that build constraint, I would expect architectures besides amd64 to use the generic implementation automatically. But maybe the "generic" build tag needs to be explicitly passed?
@ale-linux Any ideas? What was the intent for architectures besides amd64?

Thanks to @ale-linux investigation, we found that updating github.com/IBM/mathlib to v0.0.3-0.20231011094432-44ee0eb539da resolves the problem.
Note that it can be tested on other platforms by doing:
env GOOS=linux GOARCH=s390x make clean fabric-ca-server
and
env GOOS=linux GOARCH=s390x make clean fabric-ca-server

@silliman @asararatnakar @benjsmi Fix has been merged into fabric-ca main branch. Can you try a s390x build from main branch, and if it looks good, we can release v1.5.8 with the fix.

@denyeart Thank you for the follow up Dave. We were able to build s390x from main branch.

This builds fine now on s390x.   I successfully ran the fabric-samples/test-network (with -ca argument) with the built fabric-ca OCI image. Thanks for the fix!


Add Map

I think you still need to import Prelude hiding (map) to avoid ambiguity when exporting map.  Other than that I approve of this change! :)

I think this can be closed now that #87 is merged.


URL names not available for testing

We have a CMSApp subclass which defines some URLs in its get_urls() method. All is fine when running the app, the defined URLs can be reversed.
When running tests with python manage.py test ..., we're getting NoReverseMatch: Reverse for 'some_url_name' not found. errors. Is there something we are doing wrong?
Environment

Python version: 3.5
Django version: 1.11
django CMS version: 3.4.6

I was eventually able to workraound the issue by creating the page/title stuff and manually calling apphook_reload.reload_urlconf() after that. Not sure it's the right way...

Hello @claudep,
When running tests with apphooks, you'll need to make sure to either have the cms apphook reload middleware set or reload the urls manually, otherwise the project urlpatterns will not be updated with the ones from your apphook.
@evildmp
I do think this is a documentation issue.


infjump trigger bug with coyote/groundedness

https://github.com/user-attachments/assets/2678a00f-6d82-43ff-955e-6281f892e557

If this is for a map you're making, I added an option to cap the jump count whenever it's changed on the Jump Count extended variant trigger, you can try that out 😄


Update to wgpu 0.20

updates the wgpu version to 0.20 and changes the API calls accordingly.
I had to update wasm-bindgen to "0.2.92". Otherwise, I got this error  for the demo app:
error: failed to select a version for `wasm-bindgen`.
    ... required by package `js-sys v0.3.69`
    ... which satisfies dependency `js-sys = "^0.3.69"` of package `eframe v0.27.2 (/home/user/Projects/egui/crates/eframe)`
    ... which satisfies path dependency `eframe` (locked to 0.27.2) of package `confirm_exit v0.1.0 (/home/user/Projects/egui/examples/confirm_exit)`
versions that meet the requirements `^0.2.92` are: 0.2.92

all possible versions conflict with previously selected packages.

  previously selected package `wasm-bindgen v0.2.90`
    ... which satisfies dependency `wasm-bindgen = "=0.2.90"` of package `egui_demo_app v0.27.2 (/home/user/Projects/egui/crates/egui_demo_app)`

failed to select a version for `wasm-bindgen` which could resolve this conflict

Why is it locked to this version right now?
I ran the tests, checked the web demo and my own projects, and everything seems to work fine with wgpu 0.20.

Maintainers - would it be possible to do a point release after this merges? This version of wgpu fixes some issues causing traps when debugging Metal.
@KeKsBoTer just FYI, you may want to rebase & squash since this contains a merge commit

Somewhat related, wgpu 0.30 also got released just days ago...

Somewhat related, wgpu 0.30 also got released just days ago...

Do you mean winit? That update should probably be done separately, it starts moving to a trait-based API that is very awkward to refactor to IMO https://github.com/rust-windowing/winit/issues/3626#issuecomment-2081794856

Do you mean winit?

Of course, sorry... 😅

That update should probably be done separately,

I agree, just wanted to make a note of it, as a thing to consider for planning the next releases...

Guess that's why 😆

I think you could/should update the installed wasm-bindgen-cli version too, to match then.

Why is it locked to this version right now?

The locking is done because of unstable features that are needed for clipboard handling (and previously for WebGPU apis). Unfortunately, unstable feature change on minor versions and one can't actually lock minor versions in Cargo. It's still allowed to update them since it assumes there's nothing breaking in there ever.
I'm looking into the web issue and do some preliminary testing.

clipboard on web seem to be broken with this right now


v0.2.0 Tasks

v0.2.0

[ ] #31
[x] Allow use of int 2 and 3 for API_VERSION
[ ] Move to Google docstring format
[ ] Migrate away from Pipenv
[x] Check no new request methods have been added
[ ] Automate package publishing using GitHub actions.

Hey, @dbrennand I would like to work on this issue. Could you please assign me ?

Hey, @dbrennand I would like to work on this issue. Could you please assign me ?

Hi @aserputov 👋🏻
Awesome! I've actually completed the task to migrate away from Pipenv and use Poetry. I just haven't pushed those commits yet. Hopefully I can do this sometime soon so we could look at automating tests and publishing using a GitHub action such as: https://github.com/abatilo/actions-poetry
Also, I've pushed some commits for the Google docstring formats in branch v0.2.0. Specifically for virustotal.py.
I wasn't planning on changing any of the libraries functionality so if you're experienced with writing some unit tests with Pytest then that would help so much!
Otherwise, I'll push the poetry commits ASAP so you could start working on the GitHub actions bit 🙂
Let me know what you're comfortable doing 👍🏻🙂

@dbrennand hey, I want to try working with Pytest.


jam at starting docker container

We appreciate you go through Apollo documentations and search previous issues before creating an new one. If neither of the sources helped you with your issues, please report the issue using the following form. Please note missing info can delay the response time.
System information

OS Platform and Distribution (e.g., Linux Ubuntu 18.04):16.04
Apollo installed from (source or binary):source
Apollo version (3.5, 5.0, 5.5, 6.0):6.0

Steps to reproduce the issue:
I firstly use apollo5.5 and nvidia driver430, and it is OK. And then I update to apollo6.0 and nvidia driver450, it jams at "starting docker container" when I run the script"dev_start.sh".

You can run bash docker/scripts/dev_start.sh -g cn if you are from China, or manually downloaded all the relavant docker files and run with dev_start.sh --local to see if the problem persists.
Besides, please also note that Ubuntu 16.04 support is going to be retired in Apollo 6.0 and onwards. Please upgrade to 18.04 to have a better experience.

Hi @Yuyn1234, since we haven't got your reply for 10+ days, this issue is going to be closed now. Reopen it at any time when you returns, or create another issue if you have other questions.
Thanks for using Apollo.


Add use of gtk::Switch::connect_changed_active

Example right way to watch about gtk::Switch changes. See https://github.com/gtk-rs/gtk/pull/491, https://github.com/gtk-rs/gtk/pull/492

Restarting CI now that gtk-rs/gtk#492 has been merged.

CI passed

Thanks!


[AIRFLOW-1493] fix race condition with airflow run

Still a very unclean WIP. This fixes a race condition where a task can be running but the state can be something else. It can also cause two tasks to run at once in some rare conditions.
@gwax @bolkedebruin @aoen
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-1493

Description

[x] Here are some details about my PR, including screenshots of any UI changes:

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Can you elaborate a bit more when it happens? Wouldn't a refresh_from_db(lock=Yes) help/suffice here? Or should this not be handled at the Job level instead of task level?

@bolkedebruin  It won't because the monitoring happens in a different process, which depends on seeing the task in a running state in the heartbeat, which isn't guaranteed to happen. There's more context in the jira ticket.

Codecov Report

Merging #2505 into master will increase coverage by 0.08%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master    #2505      +/-   ##
==========================================
+ Coverage   69.95%   70.03%   +0.08%
==========================================
  Files         146      146
  Lines       11448    11467      +19
==========================================
+ Hits         8008     8031      +23
+ Misses       3440     3436       -4

Impacted Files
Coverage Δ

airflow/bin/cli.py
52.96% <0%> (ø)
:arrow_up:

airflow/jobs.py
78.11% <100%> (+0.43%)
:arrow_up:

airflow/models.py
87.35% <93.33%> (+0.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa84d49...85e40a9. Read the comment docs.

@aoen @bolkedebruin  @gwax
It's in a pretty dece state now, wanna take a look?

I still don't feel very good about the abstractions and the exception handling assumption (though that is a little bit more minor). LGTM.
Consider getting @bolkedebruin 's LGTM too, curious what he thinks.

@aoen im back next week from holiday, I definitely would like to take a look at this one.

@saguziel to help out can you elaborate "design document" wise a little what/why and how it fits in with the bigger design? I understand the race condition but it would be nice to have a more extensive description why it could occur and why this is the right way the solve it (as opposed to something else maybe)

The problem is we have
airflow_run local -> airflow_run raw -> task in terms of process hierarchy.
The local process kicks off the raw process, and then heartbeats periodically, and decides whether or not to kill the task (one example of why it might do so is if the state in the DB has changed)
The raw process checks dependencies, sets the DB state to running, runs the task, then reports success or fail to the DB.
The task is the actual work being done.
The issue is when the local process does the heartbeating, it checks that the state is running, otherwise it kills the task since that means the state was changed externally. However, since the state change happens in a separate thread, we are not sure when it happens. If we assume that the state has already been changed, we will be wrong most of the time. So, the local process keeps a variable called is_running, which is set to True iff the heartbeat sees the task in the running state. However, it may never see the task in the running state since it polls the DB (not receives events).
An example is that a task could be run, and the state could be cleared in the UI before it heartbeats. Now, is_running will never change to True, and the local process will never do the state check. Thus, in this case, the state will be cleared, but the task will continue to run indefinitely.
The other real solution is interprocess communication which is kind of messy, especially when we have different layers due to bash and such. Realistically, the heartbeat process should just be in a multiprocessing thing, but it's a bit hard to refactor now, so if we do decide to go on that route eventually, this is a good first step. This solution of putting the state checks into local is the smallest refactor that doesn't become too large. It's feasible to refactor more of this later, but it is definitely too much for 1 PR, and has questionable value in my opinion.

@bolkedebruin can you take a look?


drivers: spi: spi_mcux_ecspi: Minor improvements

The internal chip selects are limited to 4, however when using GPIOS does not pose this limitation.
Also set internal channel to 0 if GPIOS are used.
The data size is set using a burst length, the data size for 8/16/32 is always 1 in those cases.

Fixes #83331
Fixes #83332

@voltamund can you test these changes if they fix your reported issues with the spi_mcux_ecspi driver?


Sidebar not opening

Hi can you show me a screenshot of where you are trying to open the chrome extension?
Points to note :-

To open the chrome extension you have to be on the Linkedin.com domain. Other domains wont let you open the sidebar if you click on the extension icon.

Even after the first point, you are unable to open the sidebar. Please type  chrome://extensions on your browser and go to the "Yal3" chrome extension and click on "Errors" button and send me the screenshot of the error. I will try my best to help


Migrating project to use groups in allowlist

This PR migrates the project to use groups of IPs in their allowlist.
By referring to groups to IP addresses, we can centralize the definition of groups of ip addresses.
If these lists require changing in the future, we can change the definition once and future deploys across all services will automatically include these new IPs.
0 allowlist(s) have been detected that can be migrated.

No ip allowlist, I'll close this.


std::regex throws exception in windows

More fun in Windows land: We took a multichannel exr file and generated a tx file (.tiff under the hood), so that later when we operate on the .tx file, for instance by using oiiotool --info, we get a crash. In our application we catch exceptions (side note, should oiiotool catch exceptions too?), so instead of crashing we find this exception:
"regex_error(error_stack): There was insufficient memory to determine whether the regular expression
could match the specified character sequence."
Debugging points to tiffinput.cpp with the exception being thrown from the regex_replace call in:
    found = desc.rfind("oiio:AverageColor=");
    if (found != std::string::npos) {
        size_t begin  = desc.find_first_of('=', found) + 1;
        size_t end    = std::min(desc.find_first_of(' ', begin), desc.size());
        string_view s = string_view(desc.data() + begin, end - begin);
        m_spec.attribute("oiio:AverageColor", s);
        const std::string average_pattern
            = std::string("oiio:AverageColor=(\\[?") + fp_number_pattern
              + ",?)+\\]?[ ]*";
        printf("desc=%s\n", desc.c_str());
        desc        = regex_replace(desc, regex(average_pattern), "");
        updatedDesc = true;
    }

This seems like it could be related to https://stackoverflow.com/questions/42909618/a-simple-c11-regex-that-throws-regex-error-while-searching , but for some reason setting a #define _REGEX_MAX_STACK_COUNT 0 at the very top of tiffinput.cpp doesn't help even though looking at the regex source code makes it look like it should. In fact, doing that in the simpler patch below also doesn't help. Perhaps something sneaky is going on and this isn't getting used by the windows regex header? It'd be nice to figure this out, but I gave up and went with the below fix.
Since we still have the boost code, the following lets us build with boost whenever this is an issue:
diff --git a/src/cmake/compiler.cmake b/src/cmake/compiler.cmake
index 37a87776..47e2e233 100644
--- a/src/cmake/compiler.cmake
+++ b/src/cmake/compiler.cmake
@@ -267,6 +267,16 @@ set (CMAKE_REQUIRED_DEFINITIONS ${CSTD_FLAGS})
 check_cxx_source_runs("
       #include <regex>
       int main() {
+
+          // This throws an exception on windows, at least with VS2015, when using std_regex
+          \"desc=oiio:SHA-1=879F1A17ACE62D0B3D6CCE09B6F2BE3ADD6A48B2 oiio:AverageColor=0.532385,0.49592,0.494299,0,1.16619,0.946394,0.784551,0,0.6515
71,0.649502,0.65518,0,0.489643,0.471951,0.471693,0,0.599104,0.547551,0.488581,0,0.796633,0.890403,0.84728,0,0.857453,0.874942,0.906667,0,1.26352,1.247
64,1.2966,0,1.86804,1.62555,1.16578,0,1.88414,1.9104,2.07001,0\";
+          static const char* fp_number_pattern
+              = \"([+-]?((?:(?:[[:digit:]]*\\.)?[[:digit:]]+(?:[eE][+-]?[[:digit:]]+)?)))\";
+          const std::string average_pattern
+              = std::string(\"oiio:AverageColor=(\\[?\") + fp_number_pattern
+              + \",?)+\\]?[ ]*\";
+          std::string desc = std::regex_replace(desc, regex(average_pattern), \"\");
+
           std::string r = std::regex_replace(std::string(\"abc\"), std::regex(\"b\"), \" \");
           return r == \"a c\" ? 0 : -1;
       }"

At the very least, this provides a short and concise repro for testing other fixes. Note that I only tried VS2015. An extra embellishment might be to output a message when boost is used since it's good to know something weird is still going on with regex.
The ordered list of better fixes would be for MS to make their regex more robust to this, to figure out how to increase the _REGEX_MAX_STACK_COUNT  so that it actually is used and to ensure that the new value is good for all types of reasonable expected inputs (100 channel images, maybe 1000, what about a crazy million or billion?), to change the regex in tiffinput to be "nicer", and finally to just give up and use my boost patch. I gave up and went with boost, with the hope that MS will eventually fix this in a few years...

The previous diff doesn't actually compile. This does and also shows how we can more nicely avoid some of the escaping of quotation marks:
diff --git a/src/cmake/compiler.cmake b/src/cmake/compiler.cmake
index 37a87776..7aabe7a9 100644
--- a/src/cmake/compiler.cmake
+++ b/src/cmake/compiler.cmake
@@ -264,16 +264,37 @@ include (CheckCXXSourceRuns)
 # Find out if it's safe for us to use std::regex or if we need boost.regex
 cmake_push_check_state ()
 set (CMAKE_REQUIRED_DEFINITIONS ${CSTD_FLAGS})
-check_cxx_source_runs("
+
+# Even though we use bracket arguments, we still need to escape the \ characters when passing to check_cxx_source_runs
+check_cxx_source_runs([=[
+//#define _REGEX_MAX_STACK_COUNT 100000
       #include <regex>
       int main() {
-          std::string r = std::regex_replace(std::string(\"abc\"), std::regex(\"b\"), \" \");
-          return r == \"a c\" ? 0 : -1;
-      }"
-      USE_STD_REGEX)
+
+          try{
+              // This throws an exception on windows, at least with VS2015, when using std_regex
+              std::string desc="oiio:SHA-1=879F1A17ACE62D0B3D6CCE09B6F2BE3ADD6A48B2 oiio:AverageColor=0.532385,0.49592,0.494299,0,1.16619,0.946394,0.784551,0,0.651571,0.649502,0.65518,0,0.489643,0.471951,0.471693,0,0.599104,0.547551,0.488581,0,0.796633,0.890403,0.84728,0,0.857453,0.874942,0.906667,0,1.26352,1.24764,1.2966,0,1.86804,1.62555,1.16578,0,1.88414,1.9104,2.07001,0";
+              static const char* fp_number_pattern
+                  = "([+-]?((?:(?:[[:digit:]]*\\\\.)?[[:digit:]]+(?:[eE][+-]?[[:digit:]]+)?)))";
+              const std::string average_pattern
+                  = std::string("oiio:AverageColor=(\\\\[?") + fp_number_pattern
+                  + ",?)+\\\\]?[ ]*";
+              desc = std::regex_replace(desc, std::regex(average_pattern), "");
+          }
+          catch(const std::exception& e)
+          {
+             return -1;
+          }
+
+          std::string r = std::regex_replace(std::string("abc"), std::regex("b"), " ");
+          return r == "a c" ? 0 : -1;
+      }
+]=] USE_STD_REGEX)
 if (USE_STD_REGEX)
+    message (STATUS "USE_STD_REGEX")
     add_definitions (-DUSE_STD_REGEX)
 else ()
+    message (STATUS "USE_BOOST_REGEX")
     add_definitions (-DUSE_BOOST_REGEX)
 endif ()
 cmake_pop_check_state ()

Now on windows this will use boost unless you uncomment the #define _REGEX_MAX_STACK_COUNT, in which case it passes and we use std::regex. So that's good to see that the #define solution does in fact work on its own. However, as before, I don't know why it doesn't work within OIIO itself. I can only assume that the regex header is somehow being called before my #define somehow?

I went with the brute force approach and defined _REGEX_MAX_STACK_COUNT everywhere in OIIO:
diff --git a/src/cmake/compiler.cmake b/src/cmake/compiler.cmake
index 37a87776..7ceb111b 100644
--- a/src/cmake/compiler.cmake
+++ b/src/cmake/compiler.cmake
@@ -258,22 +258,46 @@ endif ()
 if (NOT VERBOSE)
     set (CMAKE_REQUIRED_QUIET 1)
 endif ()
+
+add_definitions ("-D_REGEX_MAX_STACK_COUNT=0")
+
 include (CMakePushCheckState)

and this lets oiiotool work. However, for my application to work (it statically links OIIO and also includes regex for its own use), I also need to define this for all files otherwise I'll get the same error in my OIIO calls. I guess the MS regex header is initializing some sort of global state the first time it's run. Now that I know this trick, that's ok for me, but I suspect that other Windows users that also encounter this will not know they need to do this in their application in order to avoid this bug in OIIO. For this reason I think the best solution might be what I did above and just switch over to boost.

Is perhaps the simplest fix just to change compiler.cmake so that it uses Boost.regex on Windows, until their implementation seems more solid (as we do on gcc when too old to have a fully working std::regex)?

Sure, that works as well, though I'd then suggest adding the above repro to the testsuite.

However, regardless of which you choose, I do suggest switching to the bracket arguments as that would make the preexisting code cleaner since you wouldn't need to escape those quotation marks.

Yeah, definitely. Do you think that your build-time test is sufficient to test for this condition, or should we force boost.regex on Windows just in case? I don't think there is a downside to that, except for the purely aesthetic preference of std over boost whenever possible.

It isn't purely aesthetic... Many of us are scouring boost from our builds, and look forward to a brave boost free future. Given the relative simplicity of average_pattern, I want to suggest that a non-regex solution would solve for the out of memory exception, and no new boost dependency simultaneously.

The test above should reliably catch the problem until Microsoft's regex is changed so that it either doesn't use so much memory or they increase the default stack size. Once that happens it's of course possible this particular test will pass but perhaps a similar image with more channels will still fail. My guess is that if MS goes through the effort of changing their code so this passes, they probably will do a good enough job that all reasonable images passed to OIIO will work.
And yes, I too would love for the boost dependency to go away, so this is an unfortunate step back. Fixing the code to not use regex is an option, but that's going to take extra dev time, not to mention it's possible other regex usage in OIIO might also exceed the stack size for certain images.

Proposed fix in #2173 -- I just replaced all uses of regex_replace, @meshula was correct, there was no current use that couldn't be easily substituted with either Strutil::replace or one more short utility function I added as part of this patch.

Closing, this was fixed by #2173.


GROOVY-7431: Added a Abs() verifications

As far as I know GroovyMethodsTest needs to cover all the methods from DefaultGroovyMethods.
I've created a test for GroovyMethodsTest.abs() method

Merged: https://github.com/apache/incubator-groovy/commit/4713f5c39a1a858d9f73a326620056a71642c588
Thanks!
Please note that this repository is not maintained anymore.
Please send further pull request to: https://github.com/apache/incubator-groovy


management/osimage: Fix inconsistencies

More work for unifying the method signatures and eliminating
client side client logic.
cc: @paulmey pls review&merge

LGTM


Adding LSIF types

LSIF is a JSON format for dumping knowledge of a language server about a code base. It can be used by code viewers to provide ide features without running a language server online.
There is a dead crate that provides LSIF types, and with minimal changes it can be used today. It can live in a seperate crate, but since it depends on lsp_types and I think every user of it also depend on lsp_types too, for preventing conflicts and for making lsp_types and lsif_types considering each other in changes, I think it is good to have lsif types inside this repository.
I can file a PR if it is ok to have lsif types inside this repository.
cc https://github.com/rust-analyzer/rust-analyzer/pull/10181

FWIW I'm more than happy to accept any changes at https://github.com/Xanewok/lsif, I just wasn't developing much using LSIF myself hence why I didn't touch that for a while =)

Great! I still think it is better to put lsif types in a module in this crate rather than a separate crate for preventing dependency headaches, at least until public dependencies become stabled. But if you don't see benefit in merging these crates, we can continue in the lsif repository.

@Xanewok what is your opinion? lsif as a module here or as a seperate repository? I can file a PR if we decide.


.github/workflows.

.github/workflows.
Originally posted by @jace4511 in https://github.com/github/docs/discussions/2230#discussioncomment-255865

This issue is blank and appears have been opened accidentally. I'm going to close it now, but feel free to open a new issue or ask any questions in discussions!

This issue is blank and appears have been opened accidentally. I'm going to close it now, but feel free to open a new issue or ask any questions in discussions!


[camera] fix video recording crash on iOS

Description
When capturing video in iOS after a few seconds the app crashes. The error message is A pixel buffer cannot be appended when readyForMoreMediaData is NO
This fixes the crash.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

The tests checks are not failing because of this PR. All the [camera] tests from others PR are also failing..

Hi @EkilDeew, which iphone are you seeing this error on. I wasn't able to reproduce it with the iPhone X or iphone 6s.
Also:
Is it crashing with the latest version of the plugin?
Is audio enable?

I'm seeing this on a iPhone XS running iOS 13.2.
Audio is enabled and its crashing with the version 0.5.6+3 which I have. I haven't yet tested the latest version.

Closing this PR as the issue can no longer be reproduced in the latest version of the camera plugin.


Added Eclipse integration info

Added a reference to RustDT for Eclipse integration in README.md.

Updated pull request to better merge with adelarsq's pull request. (#520)

Thanks @BGluth


add a source debug build

Adds make debug.. allows a developer to build a source debuggable version of skopeo. For example, using delve.
Signed-off-by: Mike Brown<EMAIL_ADDRESS>

@duglin ptal

@mtrmac Switched to a make ... DEBUG=1 pattern

rebased...

Merged, thanks!

Bah, I can’t merge this manually it seems.
@mikebrow do you want to try rebasing again?  Sorry about that… Or we can wait a few days for @runcom or somebody else with admin status on this project to allow force-pushing.

Saw the merge and stopped watching for additional messages, sry bout that.  Rebased.


BIDABT

Portugese man-of-war?
Jellyfish?

we already have it as BIDABD. do you wanna improve its meaning?

Thats the right spelling bd together sounds out ‘t’.
On Wed, Jan 11, 2023 at 05:00 smith-371 @.***> wrote:

we already have it as BIDABD. do you wanna improve its meaning?
—
Reply to this email directly, view it on GitHub
https://github.com/tekinged/missing/issues/396#issuecomment-1378643705,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF2DJJGNS25XZZ45K7A6TCLWR2OGBANCNFSM6AAAAAATXJJA7Q
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

My bad. Closing.


Consider enable automatic security updates

We found that {devices} are not configured to automatically install security updates. Consider enabling this feature. Details for how to do this can be found here: {doc_url}.
part of #198

Title grammar issue: Consider enabling ... or "Enable automatic security updates"

TITLE
Automatic security updates not enabled

enable automatic security updates

TL;DR
Automatic security updates are not enabled on [DEVICE]. This leaves your machine vulnerable to security risks as software becomes outdated and open to attack. This is particularly relevant if you are running a server. Edit your /etc/apt/apt.conf.d/50unattended-upgrades and uncomment the line "${distro_id}:${distro_codename}-updates";
FAQ
WILL UPDATE LATER

I think this one might warrant a whole tutorial as it requires the UnattendedUpgrades package. It's not as straightforward as I thought

@fshmcallister There is a pretty good tutorial here that we can link to instead of writing our own.
I think we can remove the references to the file in the tl;dr version, as you don't really care about that when you just want to understand it. That should be saved for the FAQ version.
Also, I'd like to see the FAQ version reworked a bit as it doesn't read well with inline code blocks like that.

TL;DR
Automatic security updates are not enabled on [DEVICE]. This leaves your machine vulnerable to security risks as software becomes outdated and open to attack. This is particularly relevant if you are running a server. Please consider setting up automatic security updates.
FAQ
Automatic security updates by default are not enabled on Linux distributions. However, not doing so could leave your [DEVICE/NODE] vulnerable as software exploits are found and not corrected for leaving them outdated and open to attack. While stability of a service may be affected by continual updates, in the instance where you are running a server with high amounts of egress and ingress, it is worth considering implementing automatic security updates after some time period.
Each Linux distribution has slightly different methods of setting up automatic security updates, however for many, including Debian and Ubuntu, you can use the unattended-upgrades package. To do so make sure the package is installed:
sudo apt-get install unattended-upgrades apt-listchanges

You will need to edit the default configuration file /etc/apt/apt.conf.d/50unattended-upgrades using your preferred editor and uncomment the following line:
"${distro_id}:${distro_codename}-updates";

You will then need to create a /etc/apt/apt.conf.d/20auto-upgrades file or edit the pre-existing one, which is typically empty, to set up automatic updates.
Paste the following, replacing the x values with the frequency at which you want updates:
APT::Periodic::Update-Package-Lists "x";
APT::Periodic::Download-Upgradeable-Packages "x";
APT::Periodic::AutocleanInterval "x";
APT::Periodic::Unattended-Upgrade "x";

We recommend setting most of these to 1 to get daily updates. AutocleanInterval can be done weekly, so set to 7.

Automatic security updates by default are not enabled on Linux distributions.

On most Linux distributions.
Also, please test these instructions. I'm pretty sure you just need to run sudo apt-get install unattended-upgrades and it will take you through the wizard, rendering the remaining steps moot.

at least on Debian it does not when I ran it before, I had to do the following steps manually

Got it. I think I've only used it on Ubuntu, for which it works out-of-the-box. Maybe we should use different links for Debian and Ubuntu.
Here's the Ubuntu one https://help.ubuntu.com/lts/serverguide/automatic-updates.html

No worries, I've linked both Debian and Ubuntu tutorials in the main FAQ block.


Add Checkstyle reporter

I thought it would be kind of cool to have a checkstyle reporter
for several scenarios when using a CI server like Jenkins.

Hi @mariusbuescher
I tested the code and I can see validation.xml file contains the error details only for last file. Can you please make sure to fix this so that I can merge the request because I am sure the aim is to provide XML with complete report and not last file errors only.
Thanks
Vikash Bhardwaj

Hi @vikash-bhardwaj
Now all errors will be collected and written to the checkstyle file.


Research ways to specify off-chain computation

We need the requester to be able to specify off-chain computation as a reserved parameter.
See this as the problem definition https://github.com/bbenligiray/computation-specs-example The repo has branches that prototype different approaches.
The current leading solution is to run injected JS in an isolated serverless function invocation, potentially with additional software-isolation.

We probably need to specify the encoding in a non-framework specific way (otherwise we need to import a specific ethers version which sucks). For example, post-processing returns an array, and _type specifies what these objects should be encoded as. So the encoding is not left to the requester to implement.

Closed to be tracked by https://api3dao.atlassian.net/jira/software/projects/AN/boards/18/backlog?selectedIssue=AN-76


error:"no inputs, reconnect when needed!"

i send a dataurl as image_url to fal.realtime, then receive a error:

my payload:

Hi @yerled , that is an expected status when the WS doesn't receive any messages for a given interval determined by the API (usually ~2s), it disconnects. The client will reconnect automatically when you send new messages.
Maybe labeling as an error is misleading here, I'll take this to the team so we can revisit the status: "error" in such cases. But don't worry, nothing is wrong. The incoming message right after the one you send is the successful response to your request.


[Feature Request] Make array_cat() to ignore null just like concat()

Feature description:
the 'names' in some row is null, do:
select array_cat(['hello'], names) from statis_user_success limit 1;
Now:
SQLActionException[UnsupportedFeatureException: Argument 2 of the array_cat function cannot be converted to array]
Hope:
['hello']

even if arr is null, "array_cat(arr, ['ding'])" can give me ['ding'], everything is ok, so i close the issue.


Borderlands 2 (Ultra HD) in-engine cutscenes are glitched in ultrawide resolution

Just what the title says. The in-engine cut scenes are glitched, there's a squared area on the left where you can see something, but the rest of the screen is just black. Sometimes textures like the graffiti-like names show up. Subtitles are spared. Also, the lava from the Warrior encounter is transparent.
FMV cut scenes play normally.
Software information
Borderlands 2 (Ultra HD DLC)
System information

GPU: RX 580 8 Gb
Driver: OpenGL version string: 4.5 (Compatibility Profile) Mesa 19.2.0-devel (git-a417c32 2019-06-15 disco-oibaf-ppa)
Wine version: Proton 4.2-7
DXVK version: 1.2-30
d9vk version: 0.12

This was one thing I wanted to report. (see below).
After a discussion on Discord this appears to be an NVIDIA only issue.
!(https://steamuserimages-a.akamaihd.net/ugc/786355787333557717/37BA1B16F37CF2C88D2BADF0487B1BCFD1AC9EE7/)
!(https://steamuserimages-a.akamaihd.net/ugc/786355787333558174/903379C740BC644602D763E5E1EA9E63A5A190AB/)

Have you tried the Warrior fight? Lava texture is missing for me.

Only tried a few areas. Not that one.
@lavadrop Maybe add the ultrawide (or non-16:9) bit the title. Could be convenient for Joshua to instantly see what something is about.

@lavadrop For reference, the lava is missing for me even without D9VK, ever since I started playing through Wine with the HD pack.

Are you also using 21:9 aspect ratio?

@lavadrop no, and my cutscenes are fine; my point is that's likely a separate bug.

The cutscenes now render properly on ultrawide. I don't see which commit was responsible for it, so I don't know exactly when it was fixed.


Simulator terminal error is not cleared.

To reproduce:

Run simulator with no code.
Create error, e.g., use undefined variable.
Run simulator and see error output in simulator terminal.
Clear error in code.
Re-run simulator and see that error output is not cleared.

We need to emit EVENT_SERIAL_RESET before a flash in the simulator device connection.
This matches the real device (which stops listening too, which we don't really need to do).


chore: Replace docs.ms.com/en-us/ with /

Allows redirection to localized content.
This was just a simple find replace of https://docs.microsoft.com/en-us/ with / so feel free to do it in the internal repo if that's easier.

@nschonni I'm going to take this one to the internal repo, I remember you did did one like this before and some of them got accidentally reverted I think by the vendors synching this back to our internal repo. We shouldn't have en-us and we don't need to fully qualify docs.microsoft.com (some of them came in from migrated articles but many are in our core content). I'll keep this open until I create the work items.

@nschonni I'm closing this one, we have the internal work items for this one and there were 1-2 like it. Thank you for all your contributions, even when we close it and make it internally.


docs(sdk): Update sweep docstrings

Description
Provide more context for sweep docstrings. Word smithing as well.
Testing
How was this PR tested?

@kptkin When you get a chance, can you help unblock me and get this PR merged? 🙏

@ngrayluna Few issues:

This PR broke our ruff check, see here: https://app.circleci.com/pipelines/github/wandb/wandb/30179/workflows/0ffca0e4-b266-4ae6-a1af-dc3f575ba012/jobs/972005 (you can fix it by installing tox and running tox -e ruff, or just install the pre-commit hooks (see contributions docs)).
This PR also broke automated test for documentation when you removed these lines: https://github.com/wandb/wandb/pull/6830/files#diff-ba2b9dff0762c1dddea527141671b640b03ac23533713d1d19229c13e9691ef2L67-L91
see this error: https://app.circleci.com/pipelines/github/wandb/wandb/30179/workflows/0ffca0e4-b266-4ae6-a1af-dc3f575ba012/jobs/972040. To fix this you can either put this code back or just remove this file: tests/functional_tests/t0_main/doctest/one-parameter-sweep.yea (up to the sweeps team)

@gtarpenning I removed this file tests/functional_tests/t0_main/doctest/one-parameter-sweep.yea . Re: The Docs Team is removing code examples from the API Ref (for now).


HIP 103: MOBILE Oracle Hex Boosting

HIP 103: MOBILE Oracle Hex Boosting

Author(s): Andy Zyvoloski & @zer0tweets
Start Date: 2023-12-18
Category: Economic, Technical
Original HIP PR: #822
Tracking Issue: #836
Vote Requirements: veMOBILE Holders

Summary
This Helium Improvement Proposal (HIP) discusses how Oracle Boosting rewards are calculated and creates a new Footfall Oracle, which incentives deployments in areas that have heavy footfall traffic.
Rendered View
https://github.com/helium/HIP/blob/main/0103-oracle-hex-boosting.md

HIP 103 is now live for voting
https://heliumvote.com/mobile/proposals/45KakF8bf5K2t5eSj1iZGNYjD2qcCy5VgZZ2XUPXnE4X

HIP 103 passed with 92.84% o fthe vote
https://heliumvote.com/mobile/proposals/45KakF8bf5K2t5eSj1iZGNYjD2qcCy5VgZZ2XUPXnE4X

Urbanization data is 5 years old and won't be updated until 2030. Please include a way to manually add urban areas. Any urban development built after 2020 has rewards drastically reduced. Urbanization data is based on the census which is completed every ten years.


Update main.cpp

Changed if statement that scans the input getline to allow for the "N" case

Thank you for catching this bug.


feat: container-type level version compatibility check

@KeranYang I see this got merged but to answer your question, in our code the server start utility would add the default server info automatically,
    if server_info is None:
        # Add the server information to the server info file
        # if not provided
        server_info = ServerInfo.get_default_server_info()

Only if a deviation from default was required we could pass a custom info object
cc @vigith

I am thinking whether we use the same pattern we used in Rust SDK.

This is the similar patten I had added in Rust SDK, earlier there was not much deviation in the server info hence was simpler to add single source for defaults with sync and async servers.
https://github.com/numaproj/numaflow-rs/pull/71/files

We could have passed container type as parameter that can give the default with the requested one.
Will make a PR for any refactor that I can see

thank you @kohlisid !


Request for a 'Return' button for home screen when in the Diagram Mode

Describe what problem your feature request solves:
When in diagram mode you have to close and reopen the project to get to the back to the home screen to then run the report.
Describe the solution you'd like:
When in the diagram mode, it would be great to have the 'Return' button similar to the one you get when in Report mode to get back to the home screen
Additional context:

Thanks for this suggestion @tom-seward , it is somethig that we can certainly add, I will mark this for the next release version of 2.4

Hi ! I am currently working on this issue

Hello @tom-seward , could you make sure you are using a version 2.x Threat Dragon? From the screenshot it looks like a version 1.6.x version
Using version 2.x I think the path through the application will already do what you want


Function un-inlining

This is a far-off dream of a feature request, but it would be very nice if I could select a chunk of HLIL, mark a few expressions as 'variable', and call it an inlined function or macro. Then binja could search for the IL pattern and mark matches, giving an option to simplify/un-inline the inline function call. The first part could be done as a plugin right now, but the un-inlining part would take some core support (or maybe #1606). I can imagine this playing really well with DWARF or PDB imports, where you have the ground truth for macro expansion/inlining, but also for reversing stripped, optimized code.

I agree this is an awesome feature that we've talked about for awhile. It could probably be done with a hack with analysis passes when they exist, but the real solution will take considerably more effort. UI wise you'd want some way to view these un-inlined functions much like how you'd normally view functions. For the sake of data flow and type propagation you'd like to still treat them as inlined.


docs: New getting started page

Part of apify/apify-web#3593
Simplify quick start guide - move it to single page. Changelog kept in top bar only.

Guys, could you do me a favor - when on this, could you also describe there i detail how to iterate on a collection endpoint as requested here - https://apify.slack.com/archives/CQ96RHG2U/p1704887306265249
Second, when everything is done and approved, add @TheoVasilis for a final grammar check.

And a regular note from my end - docs updates to projects like this are not features. Think about using the feat/fix commit types as something that should end up in the project changelog - it changes how the project works when used. The rest shouldn't have those types as it shouldn't end up in the changelog.

Hey @TC-MO we added additional improvements:

renamed the quick start page to Getting started
added more sections explaining the concepts
added multiple examples to all concepts and features

Can you please take a look one more time?
@TheoVasilis can you please check the grammar for us? You can only review the changes in docs/index.md as everything else is just duplicating the content to older versions.
Thank you!

There are 4 links that docusaurus keeps considering as broken, but as I see them they should be working and have no idea why it is that way
the link in question is: https://docs.apify.com/api/client/js/docs/features#retries-with-exponential-backoff
maybe as per @B4nan suggestion try non absolute links? (though that should not matter whatsoever)

the link is wrong, its not about being absolute or relative, it points to a features page which this PR removes completely


Add version handler for api

Description
This adds support for the consensus layer version api to the blob archiver api.
Building the docker images (or via the makefile), will pull in the current head commit hash as the version.
❯ curl -s <IP_ADDRESS>:8000/eth/v1/node/version | jq
{
  "data": {
    "version": "Blob Archiver API/39cf8e7c53901b2bb493b5a0dc003a1264da4de7"
  }
}

Review Error for sebastianst @ 2024-05-30 16:42:48 UTC
User must have write permissions to review


dropExtraColumns argument request in validateCohortArgument

This argument would be helpful for CohortConstructor, see current internal function below:
https://github.com/OHDSI/CohortConstructor/blob/5c2144acd9ca8ad3323bd14af4943fbfe81d0d31/R/validateFunctions.R#L15

Also, what would you think of having an argument indicating whether temporal tables are allowed? I knowaren't supposed to be temporal but currently the code below is crushing due to this, and maybe would be nice to allow it to work?
#' library(CohortConstructor)
#' library(PatientProfiles)
#'
#' cdm <- mockCohortConstructor()
#'
#' cdm$my_cohort <- cdm$cohort1 |>
#'   addAge(ageGroup = list("child" = c(0, 17), "adult" = c(18, Inf))) |>
#'   addSex() |>
#'   stratifyCohorts(
#'     strata = list("sex", c("sex", "age_group")), name = "my_cohort"
#'   )

I am happy to add the dropExtraColumns argument because it can be useful, but I don't see why the current behaviour makes your reprex to crash, in principle the current behaviour is that no column is droped

At that moment I think it wasn't working because the cohort table was not a permanent table


Update AzF profile to be useful

PR Summary
I've run the profile collector on the AzF profile (with some difficulty) and collected a new profile that captures the default Az installation.
I've also removed cmdlets that don't work in AzF despite being present, like Start-Job and Enter-PSSession.
I had to make some small changes to the profile collector to not crash (plus one where I realised that collecting a function if we're not able to load it is unhelpful).
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Change is not breaking
[x] Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
[x] Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Impressive that testing picked that up! I'll have to make some further edits

Impressive that testing picked that up!

Have to credit you entirely for that @bergmeister -- you asked for those tests.
Looks like they're working now. Hopefully the Lazys don't hide other faults. I took out parameters and commands manually, and it looks like I took a parameter out without its alias there.


Fix broken preload URL

🗣 Description
This pull request fixes a broken URL pointing to the Chromium HSTS preloaded domain list.
💭 Motivation and context
The location of this data has changed upstream, and this is breaking the BOD 18-01 scanning.
Required to resolve cisagov/scanner#67.
🧪 Testing
All automated testing passes.
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[ ] All future TODOs are captured in issues, which are referenced in code comments.
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[ ] All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
[ ] Tests have been added and/or modified to cover the changes in this PR.
[ ] All new and existing tests pass.

✅ Pre-merge checklist

[ ] Finalize version.

✅ Post-merge checklist

[ ] Create a release.
[ ] Push to PyPI.org.

Can we just drop support for Python 3.6?


python wheel

Would it be possible, from now on, to also generate and upload Python wheels?  It will speed up installation of this package a lot...

This package is pure python, would it make a difference?

Yes, it makes a huge difference, installation from Python wheel, even for pure Python, is so much faster, as installation is little more than downloading a zip file and uncompressing it directly to the final destination.  A normal package installation, not only needs uncompressing to a temporary src directory, then it needs to execute python setup.py install, which is a lot slower.
https://pythonwheels.com

Can you quantify "a lot"? 200kB doesn't take a lot to process.

It mainly saves pip from spawning a process to launch python setup.py bdist_wheel and automagically create the wheel :)
(tmp-f8893c0a100797) [xfernandez@xaferiba tmp-f8893c0a100797]$ pip uninstall prometheus-client -y
Uninstalling prometheus-client-0.7.1:
 Successfully uninstalled prometheus-client-0.7.1
(tmp-f8893c0a100797) [xfernandez@xaferiba tmp-f8893c0a100797]$ time pip install --no-cache-dir --no-index ~/Downloads/prometheus_client-0.7.1.tar.gz
Processing /home/xfernandez/Downloads/prometheus_client-0.7.1.tar.gz
Building wheels for collected packages: prometheus-client
 Building wheel for prometheus-client (setup.py) ... done
 Created wheel for prometheus-client: filename=prometheus_client-0.7.1-cp37-none-any.whl size=41402 sha256=66668319af083af049349c7e8e81f7def84260e36c9e0968b753e27fefd5c421
 Stored in directory: /tmp/pip-ephem-wheel-cache-sh8aaupe/wheels/c3/4f/4e/65ac82a9f5c3008dee932dbf792e6cf5f9a3ae9de9031735a9
Successfully built prometheus-client
Installing collected packages: prometheus-client
Successfully installed prometheus-client-0.7.1

real    0m0.760s
user    0m0.677s
sys     0m0.083s
(tmp-f8893c0a100797) [xfernandez@xaferiba tmp-f8893c0a100797]$ pip uninstall prometheus-client -y
Uninstalling prometheus-client-0.7.1:
 Successfully uninstalled prometheus-client-0.7.1
(tmp-f8893c0a100797) [xfernandez@xaferiba tmp-f8893c0a100797]$ time pip install --no-cache-dir --no-index ~/Downloads/prometheus_client-0.7.1-py3-none-any.whl
Processing /home/xfernandez/Downloads/prometheus_client-0.7.1-py3-none-any.whl
Installing collected packages: prometheus-client
Successfully installed prometheus-client-0.7.1

real    0m0.370s
user    0m0.321s
sys     0m0.047s

Since pip will automatically build the wheel at the first install, it would save quite a lot of computation (~300 ms multiplied by every fresh install) to build the wheel once during the release and upload it to PyPI.org.
This would mean switching from:
git checkout <tag>
pip install -U setuptools twine
python setup.py sdist
twine upload dist/prometheus_client-<version>.tar.gz

to
git checkout <tag>
pip install -U setuptools twine wheel
python setup.py sdist bdist_wheel --universal
twine upload dist/prometheus_client-<version>.tar.gz dist/prometheus_client-<version>-py2.py3-none-any.whl

I'm not sure complicating our build process is worth saving 300ms of install cost.

I'm not sure complicating our build process is worth saving 300ms of install cost.

It's 300 ms multiplied by the 100k+ installs of prometheus-client that happen everyday according to https://pypistats.org/packages/prometheus-client.
So providing a pure-python wheel could potentially save several hours of computation everyday :)
If you could point me to your build process, I'd be more than pleased to improve it.

I build and release by hand.

Indeed, it's usually trivial to build/upload a wheel: if now you are doing python setup.py sdist upload, just change to python setup.py sdist bdist_wheel upload.  You may also need to create a setup.cfg file containing:
[bdist_wheel]
universal = 1

This tells it that the built wheel is pure Python and works in either Python 2 or Python 3 without changes.

I've opened #487 if you don't like the additional setup.cfg.
As @gjcarneiro explained, if you're currently using python setup.py sdist upload you'd just have to switch to python setup.py sdist bdist_wheel upload (either with a setup.cfg file or with #487 merged).

Just wanted to echo a +1 for this. I noticed prometheus-client was not distributing wheels today when I was reviewing the list of projects without wheels on https://pythonwheels.com.
The longer-form advantages of wheels over sdists are elaborated upon in the wheel PEP: https://www.python.org/dev/peps/pep-0427/#rationale
Distributing wheels is only one extra step as part of the build and release process (include a bdist_wheel target and twine or whatever upload tool you use will take care of the rest), and provides a lot of advantages for end users, even in the case of pure Python wheels like this one :tada:


Prepare Release v0.10.0

Pull request

Description

Related
Checklist

[x] The RFC, if required, has been submitted and approved
[x] Any user-facing impact of the changes is reflected in docs.tremor.rs
[x] The code is tested
[x] Use of unsafe code is reasoned about in a comment
[x] Update CHANGELOG.md appropriately, recording any changes, bug fixes or other observable changes in behavior

Coverage remained the same at 81.407% when pulling 9620dd1ef6eaaab79456e4e11756f4228f60dbc2 on prepare-release-0.10 into 2e61c9c37dc5440c60c7ea81213df2b6530c5c24 on main.


Erro in create-domain.sh script - domain-home-in-image

I'm getting this error when I try to create my domain:
Step 19/22 : RUN /u01/oracle/createWLSDomain.sh &&     echo ". $DOMAIN_HOME/bin/setDomainEnv.sh" >> /u01/oracle/.bashrc &&     chmod -R a+x $DOMAIN_HOME/bin/*.sh  &&     rm ${PROPERTIES_FILE_DIR}/*.properties
 ---> Running in 80ca2200cc60
Domain Home is:  /u01/oracle/user_projects/domains/domain-01

Initializing WebLogic Scripting Tool (WLST) ...

Welcome to WebLogic Server Administration Scripting Shell

Type help() for help on available commands

Problem invoking WLST - Traceback (innermost last):
  File "/u01/oracle/create-wls-domain.py", line 26, in ?
NameError: SSL_ENABLED

Removing intermediate container 80ca2200cc60
The command '/bin/sh -c /u01/oracle/createWLSDomain.sh &&     echo ". $DOMAIN_HOME/bin/setDomainEnv.sh" >> /u01/oracle/.bashrc &&     chmod -R a+x $DOMAIN_HOME/bin/*.sh  &&     rm ${PROPERTIES_FILE_DIR}/*.properties' returned a non-zero code: 1
[ERROR] Create domain domain-01 failed.

Does anyone got the same?

Thanks for reporting this - we will check it out and get back to you - can you confirm which type of domain you are using? WebLogic/FMW Infrastructure; on PV, in image; what version.  Thanks

Thanks for reporting this - we will check it out and get back to you - can you confirm which type of domain you are using? WebLogic/FMW Infrastructure; on PV, in image; what version. Thanks

Thank you for your prompt reply.
It is a WebLogic domain in Image version <IP_ADDRESS>

The root cause of the issue is due to a recent merge into docker-images repository. A pull request has been opened to resolve the issue.

The root cause of the issue is due to a recent merge into docker-images repository. A pull request has been opened to resolve the issue.

Thank you. Could you reference it here?

The change has been reverted in docker-images project. Can u try to re-build your domain image now.

Now it's working!
Thank you!


Make local classnames global

This is the only way I've found to "disable" the :local(.class) notation.
It disables it in the sense that the generated classname will just be "class" – it doesn't keep users from doing the webpack-specific thing though:
import styles from './styles.css';

<div className={styles.class} />

That means it'll still break users builds if they for some reason rely on the above and we change to a different bundler.
Closes #90

Can you add a comment above explaining why you need this incantation, otherwise it'll be confusing when looking at this line in a few months

Wait @vjeux, following the discussion in #90 I'm not 100% sure we want to merge this. I'll add the comment for now though.

Oops ... Wrong pull request sorry :(

Man, I know what we should do!

import styles from './styles.css';

Write a custom lint rule against importing anything from .css file. This defeats the purpose of using CSS modules and protects us.

<3

That actually sounds very reasonable!

Let’s close this then. Would you like to write that rule?

I've never written a rule and don't have the time to dig into that at the moment, so I'd rather somebody from the community does that!


typeText not working in Edge 17

Are you requesting a feature or reporting a bug?
A bug.
What is the current behavior?
typeText doesn't input values into input fields in Edge 17.17134.0 / Windows 10.0.17134
Works fine in Chrome/Firefox.
What is the expected behavior?
It should work :-)
How would you reproduce the current behavior (if this is a bug)?

Create a simple page with an input:

<input type="email" class="uiid-email">

Try fill it in using typeText:

const userNameInput = Selector('.uiid-email');
await t.typeText(userNameInput, 'some text');

Specify your

operating system: Edge 17.17134.0 / Windows 10.0.17134
testcafe version: 0.19.2
node.js version: 8.9.4

Hi @nzav
Thanks for your bug report.
We've encountered some problems with MSEdge 17 related to typing, focus changing and etc.
It will be fixed ASAP.

@nzav
The fix was published in<EMAIL_ADDRESS>

I found the same issue with this config:
Edge 17.17134 / Windows 10.0.17134
TestCafè 0.23.1


No versions beyond 3.0.0-beta.17 seem to work on deployed environments

I've been using this package for my project the whole year and every now and then I try to refactor my auth in a way to work with the latest version of redux-oidc but I always run into the same problem.
My app works fine locally, but my deployments seem to fail on any version after 3.0.0-beta.17 i.e. 3.0.0, 3.0.1 and 3.0.2 don't work on deployed versions of my application.
The problem is that the the user constantly expires and then immediately it tries to log in again and the user expires again immediately so it just goes in an endless loop.
The frustrating thing is it is extremely difficult to test since it works as it should just fine locally but when it gets deployed it stops working.
Any idea on what could be causing this issue?

I've upgrade one of my project to the latest versions. And I'm experiencing the same issue. Here is what I found out:

the problem only affects deployment environments - accessing an OIDC server on another domain, development works fine,
the problem occurs whether the code is minified or not,
redux-oidc version is not affecting this - I've tried with 3.0.0-beta.17, 3.0.0, 3.0.1 & 3.0.2,
I've used<EMAIL_ADDRESS>
I'll see if I can find some info on the github page of oidc-client. My guess is that the root of the issue lies there.

@barrymichaeldoyle I've narrowed down the reason for this error on the server side. I also upgraded my backend to netcoreapp2.1. In doing so, the migration guide suggests using a cookie policy in Startup.cs which caused this behavior. Do you maybe have the same issue?

Possibly, I'm on the front end team so don't work on the back end code. I'll check with the guys on that side.

Thanks @maxmantz!!! Got it all working. I really appreciate the effort you put into testing this all out and getting me on the right track :1st_place_medal:


Add more ssh_config directives #161

Instead of the following in AppDelegate.m:
  // if everything worked out we will see a non-nil itemList where the
    // system should be appended to. part hold the last part of the splitted string (aka hostname).
    if (itemList) {
        // build the corresponding ssh command
        NSString* cmd = [NSString stringWithFormat:@"ssh %@", key];

we change it to:
    // if everything worked out we will see a non-nil itemList where the
    // system should be appended to. part hold the last part of the splitted string (aka hostname).
    if (itemList) {
        // build the corresponding ssh command
        NSString* cmd = servers[key][@"cmd"] ?
            cmd = servers[key][@"cmd"] : [NSString stringWithFormat:@"ssh %@", key];

Thanks! I'll test this out and merge if the testing goes well.

Thanks.
John Kennedy  (_8(|)
I have a yellow dog:
http://www.theyellowdogproject.com/The_Yellow_Dog_Project/About.html
Sometimes it happens, sometimes it doesn't - Pedro Catacora
Just because nobody disagrees with you doesn't mean you are correct.
Anatidaephobia is the fear that somehow, somewhere a duck is watching you -
urbandictionary.com
The Dunning-Kruger effect occurs when incompetent people not only fail to
realize their incompetence, but consider themselves much more competent
than everyone else.
On Wed, Apr 27, 2016 at 3:18 PM, Matt Turner<EMAIL_ADDRESS>wrote:

Thanks! I'll test this out and merge if the testing goes well.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/fitztrev/shuttle/pull/170#issuecomment-215198661

@skebi69 Thanks for taking the time to contribute. I'm going to close this for now due to conflicting files due to a bunch of changes. Please get the latest and do another pull.

I will do that. Thanks for a great app and working with me on it...
 - George Carlin
The Dunning-Kruger effect occurs when incompetent people not only fail to
realize their incompetence, but consider themselves much more competent
than everyone else.
On Thu, Aug 16, 2018 at 1:09 PM Matt Turner<EMAIL_ADDRESS>wrote:

@skebi69 https://github.com/skebi69 Thanks for taking the time to
contribute. I'm going to close this for now due to conflicting files due to
a bunch of changes. Please get the latest and do another pull.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fitztrev/shuttle/pull/170#issuecomment-413617684, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFTsxl2Itd9tfEgk4bb8R-8m0hcwOckMks5uRadjgaJpZM4IRQu5
.