Support app_offline.htm

I was chatting with @coolcsh @rowanmiller @davidfowl @danroth27 and a few others and we would like to enable support for taking the ASP.NET 5 application offline when a app_offline.htm file is present in the web root just like ASP.NET 4.5 supports.
We would like this primarily for the following scenarios.

Take the app offline before EF migrations are executed
Take the app offline when files are locked preventing publish

We would like to add a checkbox to the web publish dialog in VS allowing the user to indicate if app_offline.htm should be dropped. Web Deploy already has support for this, so on that side there shouldn't be much work.

I'm not sure why app_offline.htm should be needed "when files are locked preventing publish". ASP.NET should never, ever lock any files. If it does, ASP.NET is broken.
Come on guys, ASP.NET 1.0 had this solved over a decade ago (shadow copying).
Having support for app_offline.htm during an update is a welcome feature, however. But it should not be used to fix file locking issues that shouldn't exist in the first place.

@rubenprins I'll let the runtime guys respond back regarding file locking.
There are still scenarios where it makes sense to take the app offline. For example you are going to update the DB that the app talks or updating other apps that it depends on. It's not just about file locks with publishing.

@sayedihashimi, like I said: I agree, app offline is a useful feature for a multitude of reasons (just taking an application offline without hassle, for example).
But I was referring to the file locking issue you referred to in your second point. There's also a DNX issue regarding file locking preventing publishing (Azure was mentioned explicitly, but I'm afraid it affects any non-trivial hosting scenario).
So I'm starting to get a bit worried about the scrapped/backlogged feature list for vNext by now, if even features like this are backlogged.

But I was referring to the file locking issue you referred to in your second point. There's also a DNX issue regarding file locking preventing publishing (Azure was mentioned explicitly, but I'm afraid it affects any non-trivial hosting scenario).

So I'm starting to get a bit worried about the scrapped/backlogged feature list for vNext by now, if even features like this are backlogged.

That is an issue we should raise at in the dnx. I noticed there are some issues already logged like https://github.com/aspnet/dnx/issues/1393 but I'm not sure it's exactly what you are referring to.

Curious question: would it be possible to make the filename configurable? totally low priority, etc. but just curious - like a possible backlog item for the future... :pray:  (eg. if yes, i'd like to look at submitting a PR for this)

We're not shadow copying anything, it has been a source of pain in the past that we want to avoid in the future.

@davidfowl, I agree, shadow copying is not without its flaws. And preventing updates from happening in the first place, you will prevent a whole slew of other issues at one fell swoop!
Like not restarting after config changes, app_offline support, web farms, msdeploy, etc.
Or will we be getting "guidance" on how to work around these dropped features as well?
And are you planning on providing a good overview of important changes to the platform that aren't improvements, or changes for the sake of change, but deliberate feature cuts of functionality people might, I don't know, expect to just work like they always have.

Moving over from aspnet/Home#476 ...
I agree with @rubenprins ... a smooth WebDeploy is critical in its own right regardless of whether or not app_offline works or not.
How about Web Deploy recycleApp Provider and described in an MSDN Blog?
Issue the recycleApp with a recycleMode=StopAppPool, perform the deploy operation, then issue a 2nd recycleApp with recycleMode=StartAppPool to get it back up. Would this get the IIS worker process to drop its lock(s) fast enough for the deployment step?
I guess if nobody knows I could do some testing and report back if that would be helpful. As it stands, at least 50% of my publish attempts fail when issuing a raw WD publish command.

... and there's this posted in an IIS Blog:
App Offline Template
WebDeploy v3.5 adds an enhancement to the existing AppOffline rule which allows you to take an ASP.NET application offline before publishing. In this release, WebDeploy supports specifying the relative path to an app offline template file located on the destination system. This rule handler applies to the following providers: appHostConfig provider, contentPath provider and iisApp provider.
The app offline template file can capture any static HTML content to be displayed for users while the app is offline. Here is example usage:
msdeploy.exe -verb:sync -source:iisApp=sourceApp -dest:iisApp=destApp,appOfflineTemplate="offlineTemplate.htm" -enablerule:AppOffline

Single Web Deploy command with AppOffline or recycleApp does not work
The -enablerule:AppOffline doesn't work with a physical path contentPath, as is required here. The exception that comes back is:
Error Code: ERROR_SITE_DOES_NOT_EXIST
More Information: Site 'F:' does not exist.

WD needs to know the IIS site name to kill its AppPool, which makes perfect sense.
However, we can't give it the site name: A physical deployment path is required because you must publish to the folder above the wwwroot folder. If you try to publish by IIS app name, it uses the physical path in IIS, which is to the wwwroot folder, thus WD will deploy the approot and wwwroot folders to the wwwroot folder on the server ... of course, that breaks the directory structure of the project. Since you can't specify the IIS app name for AppOffline to work and simultaneously provide a physical path that doesn't match IIS's path for the site, AppOffline looks like a dead end ... at least insofar as trying to do it all in one command.
Same deal with recycleApp: It requires the destination to be an IIS app name. Besides, you can't add recycleApp in a single deployment operation that will take the AppPool down before deployment and put it back up after the publish. It's setup to either take it down, start it, or recycle it.
Separate Commands with recycleApp may be working OK
Splitting out into three steps seems to be working, but I'll need to do this for a little while to see how reliable it is. My only concern is that the IIS worker process will not release the lock in time for the deployment step, but I guess adding a delay would be an option if I see that is happening.
I start by issuing a recycleMode=StopAppPool using the IIS site name:
"C:\Program Files (x86)\IIS\Microsoft Web Deploy V3\msdeploy.exe" -verb:sync -allowUntrusted -source:recycleApp -dest:recycleApp="IIS_SITE_NAME",recycleMode="StopAppPool",ComputerName="https://CLOUD_SERVICE_NAME.cloudapp.net:PORT/msdeploy.axd",UserName="USERNAME",Password="PASSWORD",AuthType="Basic"

I use my normal deployment command next with the correct physical path for the deployment. Note that the physical path on the server is the folder above the wwwroot folder. For example, if I have my IIS physical path set to G:\mysite\wwwroot for an app, then I would be deploying with WD to G:\mysite.
"C:\Program Files (x86)\IIS\Microsoft Web Deploy V3\msdeploy.exe" -verb:sync -allowUntrusted -source:contentPath="OUTPUT_FOLDER_PATH" -dest:contentPath="SERVER_FOLDER_PATH",ComputerName="https://CLOUD_SERVICE_NAME.cloudapp.net:PORT/msdeploy.axd",UserName="USERNAME",Password="PASSWORD",AuthType="Basic"

I finish with recycleMode=StartAppPool using the IIS site name:
"C:\Program Files (x86)\IIS\Microsoft Web Deploy V3\msdeploy.exe" -verb:sync -allowUntrusted -source:recycleApp -dest:recycleApp="IIS_SITE_NAME",recycleMode="StartAppPool",ComputerName="https://CLOUD_SERVICE_NAME.cloudapp.net:PORT/msdeploy.axd",UserName="USERNAME",Password="PASSWORD",AuthType="Basic"

I'll roll these into a script and add a short delay between commands and report back ... unless you think I've made a big :poop: here! I see @sayedihashimi dealt with these issues in-depth years ago.

@GuardRex, Recycling or stopping the application pool might not be what you want in a production environment. If you're hosting more than a few applications (note: not just sites, but applications), you're more than likely to group applications in only a few application pools.
(Ten applications running in a single desktop CLR are almost guaranteed to be more scalable/cloud friendly than running ten Core CLRs in parallel, each with their own private assemblies, private JITed code and private garbage collectors.)
Besides, updating application A should never take down applications B to Z, IMHO. But this does appear the way ASP.NET v5 is going: kill the application host to update anything, be it .dlls, or config settings.
Remember when xcopy/bin-deployment was a selling point in v1? Compared do writing/deploying COM components for a web server before it (always requiring a restart). This was considered a deployment nightmare, which is why shadow copying was invented in the first place (warts and all). We're coming full circle here, and it's not an improvement.
Anyone wants to try this in an automated fashion in a webfarm? Every single update? I don't fancy telling our Operations department that every single update might succeed, depending how fast the apppool can shut down. Or not.
(/rant)
Please, someone from the ASP.NET team tell me I'm wrong or missing something here.

Recycling or stopping the application pool might not be what you want in a production environment. If you're hosting more than a few applications (note: not just sites, but applications), you're more than likely to group applications in only a few application pools.

Moving forward, we're only going to support a single application per application pool. In fact CoreCLR is this way already for ASP.NET 5 applications.

Besides, updating application A should never take down applications B to Z, IMHO. But this does appear the way ASP.NET v5 is going: kill the application host to update anything, be it .dlls, or config settings.

Yes, the host process has to die. Even if we shadow copy, the process still has to be cycled. We're not using appdomains anymore (and can't on CoreCLR).

Remember when xcopy/bin-deployment was a selling point in v1? Compared do writing/deploying COM components for a web server before it (always requiring a restart). This was considered a deployment nightmare, which is why shadow copying was invented in the first place (warts and all). We're coming full circle here, and it's not an improvement.

There are ways around this that we need to explore. Like file renames names + a way to recycle the application from outside of it (app offline style or maybe via a signal?). I'm hesitant to just do what we had before because of the number of issues that arise not with just shadow copying but also the file watcher and reliability on environments like azure where it barely works.
Don't get me wrong, I think it's important to be able to deploy a new version of the site without failure. I just think there might be better ways of going about it. If all else fails, we know how we've been doing it for the last 10 years but I rather not start there.

The three commands that I show above with recycleApp work reliably. I've been publishing for the past few weeks OK. I haven't run into locked files on the server with this approach.
Anyone following this approach/hack keep in mind:

Set your IIS website physical path to the wwwroot folder on the server.
Set your Web Deploy path to the folder above the wwwroot folder for the msdeploy.exe command I show above.

Moving forward, we're only going to support a single application per application pool. In fact CoreCLR is this way already for ASP.NET 5 applications.

 How is that supposed to scale? We run IIS servers with 200+ applications. Mostly small-ish applications in virtual directories so we can keep the number of domains manageable (which is also an issue in itself with v5 with its split wwwroot/approot). With 200+ CLRs running, 90% of server memory would be DNX overhead alone! Forget about not being able to update/deploy: we can't even run them without OutOfMemoryExceptions :astonished:
And why are these design decisions not clearly documented anywhere? Where's the "Caution: features removed from ASP.NET because we didn't think they were pretty" topic?

 How is that supposed to scale? We run IIS servers with 200+ applications. Mostly small-ish applications in virtual directories so we can keep the number of domains manageable (which is also an issue in itself with v5 with its split wwwroot/approot).

200 sites running in how many app domains? Are these sites isolated security wise? If so I'm sure you know that we even recommend ASP.NET 4.x sites don't use app domains for security isolation. There's also an interesting thread on the CoreCLR repository that discusses this (https://github.com/dotnet/coreclr/issues/642), feel free to add your scenario there.
If there's no security problems, how much isolation do you need? Statics? Do you actually share anything or are you just taking advantage of the sharing you get from using the same assemblies across different applications within the same process (this includes JITTEd code as well)?

With 200+ CLRs running, 90% of server memory would be DNX overhead alone! Forget about not being able to update/deploy: we can't even run them without OutOfMemoryExceptions :astonished:

I can't say for a fact if that's what would actually happen. For sure more processes are heavier but I'd love to try and replicate what you're doing to see how big of a problem it really is and if there are different mitigations for it. For example, if you made native images for those applications (the ngen equivalent on CoreCLR called crossgen) and loaded them into separate processes you would still benefit from sharing. We also have a feature that allows you to put a set of common packages (also can be crossgened) on the machine so that all applications share them (I promise it's not like the GAC :wink:)

And why are these design decisions not clearly documented anywhere?

We're in preview still and some of the design decisions are tentative waiting user feedback to see what kinds of scenarios are missing. AppDomains are just gone as a concept but maybe CoreCLR introduced AssemblyLoadContext to do assembly load isolation without the marshalling burden (as an example of a scenario that was once solved by appdomain that can be solved in a much better way IMO now). It would be more constructive to compare the density between the current CLR and the CoreCLR and if it really is much worse and cannot be mitigated in practice then we need to do something about it.

Where's the "Caution: features removed from ASP.NET because we didn't think they were pretty" topic?

As we get closer to the final product, expect to see more docs appear on our main docs site (http://docs.asp.net/). In the past you would never seen any real time development or discussions happening and you couldn't even give feedback until a beta or released product was out. Now we give you access to daily builds, commits, discussions and we have to pick the right things to solve in order to ship a product. ASP.NET 5 isn't version 5, it's version 1 despite the naming.
That said, I do think it would be valuable to call out some of the major decisions even if they are tentative as it causes great discussions like this to happen with people in the real world :smile:

Although this discussion is veering wildly off topic, just a few clarifications: no, we don't need security isolation; the applications we host are built by ourselves, so there's no trust issues.
And since most of the applications are still web forms, we are indeed profiting from a lot of (ngen'd) code and metadata sharing, as well as other memory/resources/(GC) threads the CLR deems fit to share between AppDomains. Also, a lot of applications are used only infrequently, so the process model idle timeout helps reduce memory as well, without unloading the entire ASP.NET runtime.
Only a year ago we made the effort to consolidate our application pools, and it really helped in reducing our memory usage.
Because most of our older applications are web forms based, without a lot of application-level caching and comparably little user code (BCL + System.Web + System.Web.Extensions will usually dwarf our codebase), so we benefit quite a lot from the sharing by the framework.
This is, of course, not the case for our MVC applications, where we haven't bothered to put the dlls in the GAC, as this proved too big a hassle for too little benefit.
Maybe crossgening will help us here, as long as it's discoverable, and doesn't require as much hand holding as deploying ASP.NET v5 applications currently appears to entail. (Which is one of the major points regarding this issue, as well as aspnet/dnx#928 for our scenario.)
IIRC there was/is a tool for ASP.NET v4 to enable sharing of private dlls by replacing them with symlinks and let the OS handle the sharing; but it's so well hidden it might as well not exist at all. It also doesn't really help with sharing JIT'ed code when you're using separate processes/application pools, but it could help the current MVC framework's footprint when consolidating code in a single application pool like we do.

Is there any solution yet? I would like to deploy my project to Azure, but:

I can't use WebDeploy. It fails because files are being locked and app_offline.htm is not supported.
I can't use recycleMode=StopAppPool because it's not allowed to stop pools on Azure.
I can't use Git CD because repository is not hosted on GitHub / Bitbucket.

I am running out of ideas.

@djanosik Did you try this? You can deploy from a local repository with git, and you need to host your app on GitHub or BitBucket.

@muratg No :) I am sure it will work, but I need to setup continuous deployment.

It's a one time setting for your web site. You'll be basically creating a git endpoint and credentials for your site, and add that as a remote to your local git repo.   Do they allow that level of access to the underlying VM?

@GuardRex Well, I am not sure, but I will try. It's definitely good idea. Thank you!

@djanosik You could try taking some bits from my experimental PS script and using PS to control your AppPool: https://github.com/GuardRex/net5-iis-ps-publish
Get a PS Session to the VM: https://github.com/GuardRex/net5-iis-ps-publish/blob/master/net5-iis-ps-publish.ps1#L238-L249
Stop the AppPool: https://github.com/GuardRex/net5-iis-ps-publish/blob/master/net5-iis-ps-publish.ps1#L389-L396
Restart the AppPool: https://github.com/GuardRex/net5-iis-ps-publish/blob/master/net5-iis-ps-publish.ps1#L439-L446

@djanosik There is a new MSDeploy provider that handles publishing asp.net 5 websites. If you perform a publish to Azure from Visual Studio and examine the output, you can see the command and parameters being used. It basically just wrangles the wwwroot and approot content going into different folders.
https://azure.microsoft.com/en-us/blog/web-deploy-3-6-beta-released/
"%env.MSDeploy%" ^
%system.TestWebDeployment% ^
-verb:sync ^
-source:IisApp='%teamcity.build.workingDir%\artifacts\wwwroot' ^
-dest:IisApp='%system.Deployment.SiteName%',computerName='https://mysite.scm.azurewebsites.net/msdeploy.axd',userName='%system.Deployment.Username%',password='%system.Deployment.Password%',includeAcls='False',AuthType='Basic' ^
-enableLink:contentLibExtension ^
-useChecksum

Thank you for your suggestions. I've built a little helper that is now part of the FAKEX build script. It can stop / start Azure WebSites and deployment slots.

Just adding that I'm also experiencing pain here deploying to Azure Websites.
Web Deploy cannot modify the file 'BoinkChat.dll' on the destination because it is locked by an external process.  In order to allow the publish operation to succeed, you may need to either restart your application to release the lock, or use the AppOffline rule handler for .Net applications on your next publish attempt.
Learn more at: http://go.microsoft.com/fwlink/?LinkId=221672#ERROR_FILE_IN_USE.

I'm going to have to resort to finding a way to script shutting down the Azure Website before deploy, and starting it back up after.

We're going to tackle this problem.
@haydenmc is BoinkChat.dll your application dll?

@davidfowl Yup!
https://github.com/haydenmc/BoinkChat

@davidfowl

You can script with msdeploy. Search "msdeploy" to find my example script,
or I'll post the link when I get back to the office.
On Nov 23, 2015 12:49 PM, "Murat Girgin"<EMAIL_ADDRESS>wrote:

@davidfowl https://github.com/davidfowl
—
Reply to this email directly or view it on GitHub
https://github.com/aspnet/Hosting/issues/141#issuecomment-159059781.

You can also script with PS ... see my repo for an example.
On Nov 23, 2015 12:54 PM, "Luke Latham"<EMAIL_ADDRESS>wrote:

You can script with msdeploy. Search "msdeploy" to find my example script,
or I'll post the link when I get back to the office.
On Nov 23, 2015 12:49 PM, "Murat Girgin"<EMAIL_ADDRESS>wrote:

@davidfowl https://github.com/davidfowl
—
Reply to this email directly or view it on GitHub
https://github.com/aspnet/Hosting/issues/141#issuecomment-159059781.

@davidfowl @muratg this will be needed more after we switch to producing binaries by default (RC2). Can you implement for RC2? If so we can enable the checkbox on the publish dialog.

I assume this (or something like this) is also required for HttpPlatformHandler interaction.

I think it's worse with HttpPlatformHandler yes

@haydenmc I didn't realize this was the same issue where I posted earlier. The MSDeploy commands are above: https://github.com/aspnet/Hosting/issues/141#issuecomment-95798368 ... and they work quite well. You'll see a strange entry in the logs (https://github.com/aspnet/IISIntegration/issues/32), but it won't affect your enjoyment of publishing if you go that route. The PowerShell commands are up there, https://github.com/aspnet/Hosting/issues/141#issuecomment-143281902, and you saw @brent-russell's hot tip: https://github.com/aspnet/Hosting/issues/141#issuecomment-143390213

Bringing it back to RC2 so that we can discuss this in a design meeting.

Moved to https://github.com/aspnet/IISIntegration/issues/81


[Bug]: Downloads in beta not working

Guidelines

[X] I agree to follow this project's Contributing Guidelines.

Project Version
BETA 1.0
Platform and OS Version
No response
Existing Issues
No response
What happened?
The downloads from the beta 1.0 are not working for some of the formats.
Steps to reproduce
Download the data from the beta version of the app. Some will download as HTML files.
Expected behavior
download as csv.
Attachments
No response
Screenshots or Videos
No response
Additional Information
No response

Fixed


How do you handle weights flattening for the continuous adjoint method ?

Hi @patrick-kidger, I hope you are doing all right.
Thanks for your efforts in building this library (along with Equinox). I've used Diffrax to do some control of Neural ODEs, and I'd like to know more about how it works. I'm interested in your BacksolveAdjoint implementation of the continuous adjoint method, as described here.
 So how do you flatten the neural network's weights in order to solve the adjoint ODE ? Can you point me towards the function that does that please ? Follow-up if you actually do flatten the weights from the PyTree: are you not at all worried about the duplication of said weights (and the associated memory cost)?
Thanks in advance. I know you're a busy man, so anything will be useful.
Best,
@ddrous

Thanks for your interest! (And concern for my time :D )
BacksolveAdjoint doesn't flatten the weights at all. Where possible, all of my libraries try to pass around PyTrees-of-arrays, rather than single arrays, for precisely the reason you highlight: avoiding the extra time+memory overhead of the flattening.

Thanks for your quick answer.
Wow, nice choice ! Thanks for this. I'm deeply amazed by what Equinox enables.


trying to use ctr run to host registry:2 results in freezing

Description
# docker/podman/nerdctl (share the same syntax)
sudo docker load --input $HOME/registry2.tar
sudo docker image list
sudo docker run --name registry --detach -p "<IP_ADDRESS>:5000:5000" \
  -v "$HOME/images:/var/lib/registry:rw" \
  registry:2

I started up a registry like the above on a computer, populated it with ~20 images
I then imported the data on to an internet disconnected computer that only had containerd & ctr installed using RKE2 onto a x86_64 centos 7 VM
https://github.com/rancherfederal/rke2-ansible#tarball-installair-gap-install
RKE2 has ctr installed, but it's not in the path by default until I run the following commands
sudo su -
cp  /var/lib/rancher/rke2/bin/ctr  /usr/bin/ctr
sudo ctr --address /run/k3s/containerd/containerd.sock image list
# ^-- works but it'd be nice not to have to pass the flag.

exit # to normal user
echo "export CONTAINERD_ADDRESS=/run/k3s/containerd/containerd.sock" | sudo tee -a /root/.bashrc
echo "export SSH_USER_HOME=$HOME" | sudo tee -a /root/.bashrc

sudo su -  #become root again
ctr image list # now works without needing extra flags

Since I have containerd & ctr, I wanted to do the equivalent of the docker run registry, to load a pre-populated registry in the internet disconnected environment. (Note: I omitted some steps where I imported ~/images from the internet connected machine to the internet disconnected machine)

ctr image import $SSH_USER_HOME/registry2.tar
ctr run --detach --net-host \
  --mount type=bind,src=$SSH_USER_HOME/images,dst=/var/lib/registry,options=rbind:ro \
  docker.io/library/registry:2 registry

The above works and
curl http://<IP_ADDRESS>:5000/v2/_catalog
Shows it has data, I can even use registry --> registry copy tools like regsync
regsync once --config regsync.yaml # regsync.yaml config says to copy from registryA --> registryB
The thing is when I use ctr run ---detach to host registry:2
It freezes randomly, which causes curl http://<IP_ADDRESS>:5000/v2/_catalog and
regsync once --config regsync.yaml to hang.
Until I open a 2nd terminal and run the following to restart it / get it unstuck, and then they work again for a while, but then it'll freeze up again soon enough.
sudo su -
ctr task kill --all registry
ctr container rm registry
ctr run --detach --net-host \
  --mount type=bind,src=$SSH_USER_HOME/images,dst=/var/lib/registry,options=rbind:ro \
  docker.io/library/registry:2 registry

Steps to reproduce the issue
provision brand new centos 7 x86_64 VM using vagrant or whatever you like
NOTE: the following reproducibility steps prove that this is not an RKE2 specific issue, and is in-fact a ctr bug, RKE2 is just what lead me to accidentally discover it.
# become root to simplify reproducibility
sudo su -

# install containerd & ctr
yum install -y containerd
systemctl daemon-reload
systemctl enable --now containerd
systemctl start containerd

# verification command to make sure ctr works as expected
ctr container list
# CONTAINER    IMAGE    RUNTIME
# (semi blank but no errors = good)

# spin up a registry:2 container
mkdir ~/images
ctr image pull docker.io/library/registry:2
ctr run --detach --net-host \
  --mount type=bind,src=$HOME/images,dst=/var/lib/registry,options=rbind:rw \
  docker.io/library/registry:2 registry

# use regsync to populate registry with some test data
curl -L https://github.com/regclient/regclient/releases/download/v0.4.2/regsync-linux-amd64 > regsync
chmod +x regsync && mv regsync /usr/bin/regsync

export TEST_DATA="""busybox:latest
rancher/hardened-etcd:v3.5.1-k3s1-build20220112
rancher/hardened-kubernetes:v1.23.5-rke2r1-build20220316
rancher/rke2-cloud-provider:v0.0.3-build20211118
rancher/hardened-calico:v3.21.4-build20220228
rancher/hardened-cluster-autoscaler:v1.8.5-build20211119
rancher/hardened-coredns:v1.9.1-build20220318
rancher/hardened-flannel:v0.17.0-build20220317
rancher/hardened-k8s-metrics-server:v0.5.0-build20211119
rancher/klipper-helm:v0.7.0-build20220315
rancher/nginx-ingress-controller:nginx-1.0.2-hardened4"""

export LIST=$(echo "$TEST_DATA" | xargs --replace={item} -P 1000 echo '- {"source": "{item}", "target": "<IP_ADDRESS>:5000/{item}", "type": "image"}' )

cat << EOF | tee ~/regsync.yaml
version: 1
creds:
- registry: <IP_ADDRESS>:5000
  tls: disabled
defaults:
  ratelimit:
    min: 100
    retry: 15m
  parallel: 2
sync:
$LIST
EOF

cat ~/regsync.yaml
# imperatively generated declarative config file looks good

time regsync once --config regsync.yaml
# The above command will work for about ~5-15 mins
# then it'll freeze (this is why I had to generate sufficient
# test data / length of list of images to reproduce the bug)
# Open a spare/2nd terminal to the same machine

curl http://<IP_ADDRESS>:5000/v2/_catalog
# It will also be frozen, it should have been instant

# Open a spare/3rd terminal to the same machine and run
# the following that will restart registry
sudo su - #(need to re-become root in the new terminal)
ctr task kill --all registry
ctr container rm registry
ctr run --detach --net-host \
  --mount type=bind,src=$HOME/images,dst=/var/lib/registry,options=rbind:rw \
  docker.io/library/registry:2 registry

# Look at the 1st and 2nd terminal that had frozen, you'll
# see they're now unfrozen. the regsync will resume &
# the curl will work as expected once again

Describe the results you received and expected
Results:
ctr hangs / freezes, until its manually unstuck using the reset method described in the reproducibility notes.
(It's prone to refreezing several times if you have a sufficiently sized list of docker images, and you can always rm -rf ~/images to clear the downloaded images to make it easy to re-trigger the error.)
Expectations:
I expect the ctr based registry it not to hang / freeze like if I were to do the docker/nerdctl/podman equivalent of what I did above with containerd's ctr
(side note why does ctr exist / why doesn't containerd just ship with nerdctl by default in 100% of cases? :\ )
# docker/podman/nerdctl, they each share the same syntax
sudo su -
docker image pull registry:2
mkdir ~/images
docker run --name registry --detach -p "<IP_ADDRESS>:5000:5000" \
  -v "$HOME/images:/var/lib/registry:rw" \
  registry:2

What version of containerd are you using?
containerd github.com/containerd/containerd 1.2.14
Any other relevant information
runc --version
runc version spec: 1.0.1-dev
uname -a
Linux vm3 3.10.0-1160.59.1.el7.x86_64 #1 SMP Wed Feb 23 16:47:03 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Show configuration if it is related to CRI plugin.
cat /etc/containerd/config.toml
#root = "/var/lib/containerd"
#state = "/run/containerd"
#subreaper = true
#oom_score = 0

#[grpc]
#  address = "/run/containerd/containerd.sock"
#  uid = 0
#  gid = 0

#[debug]
#  address = "/run/containerd/debug.sock"
#  uid = 0
#  gid = 0
#  level = "info"

A couple points; containerd 1.2.x has been out of service for just over 18 months; it would be important to try and reproduce on a supported version of containerd for us to spend time trying to understand what might be the issue.
A more recent bug report about a freezing detached container was related to the fact that the binary being run was trying to handle I/O without any wiring up of stdin/out/err and so was stuck in an I/O wait situation until something "attached" to the I/O and drained it. Not sure if that's the case here or not without spending a bit more time.
Finally, you ask why ctr exists; well, nerdctl was created in the last year or so, but ctr has existed since 2015 since the initial codebase of the containerd project as a simple admin/client tool for testing/debug purposes. Definitely we point people to nerdctl who want a more complete client experience that is being developed with similar feature set to the full Docker client.

The background context you provided is very appreciated :)
About getting stuck in I/O wait situation, it makes me think if I install nerdctl that might work as a workaround. Not sure if ctr is officially deprecated in favor of nerdctl, but I'll make a mental note in my head to consider it to be so even if it's not officially.
I'll take a few mins later today to spin up a vagrant box with a different os / newer version of containerd and see if I can reproduce the issue on a newer / supported version of containerd.

actually I just discovered rancher has a tool named hauler that can spin up registry:2 using a go binary and it works w/o any dependencies, gonna close this.

We saw the exact same thing with CTR 1.6 version.

A more recent bug report about a freezing detached container was related to the fact that the binary being run was trying to handle I/O without any wiring up of stdin/out/err and so was stuck in an I/O wait situation until something "attached" to the I/O and drained it. Not sure if that's the case here or not without spending a bit more time

@estesp Do you mind sharing the jira on this issue and whether it's fixed?


Send position updates of multiple vehicles in one calls to tracker

Is it possible to send multiple position updates in one call? E.g.:
[{"time":<PHONE_NUMBER>000,, "point": "POINT(13.98931 49.6765525)", "id": "731"},
 {"time":<PHONE_NUMBER>000,, "point": "POINT(13.98931 49.6765525)", "id": "732"}]

No, it's not possible but it doesn't have any performance penalty. The rationale is that acutally we have a fleet of vehilces sending position updates individually.


panic in dns resolver: invalid memory address or nil pointer dereference

I just upgraded to Docker 1.11.0 and noticed that the docker daemon crashes when I run a suite of tests that do the following:

create a network
start several containers with above network
run some tests
tear down containers and network

Each tests is run in parallel.
After a few iterations, I can reliably get the Docker daemon to crash with the following panic:
time="2016-04-15T10:50:03.670207907-06:00" level=debug msg="client dns id 12960, changed id 23756"
time="2016-04-15T10:50:03.670386643-06:00" level=debug msg="Can't retrieve client context for dns id 23227"
time="2016-04-15T10:50:03.670445392-06:00" level=debug msg="Query node-1-5_ebaf3361161b41c796c6106de40d0e7e.example.com.[28] from <IP_ADDRESS>:41501, forwarding to udp:<IP_ADDRESS>"
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x30 pc=0x87d73d]

goroutine 105572 [running]:
github.com/docker/libnetwork.(*resolver).forwardQueryStart(0xc82230d700, 0x0, 0x0, 0xc8225cc240, 0x0)
    /usr/src/docker/vendor/src/github.com/docker/libnetwork/resolver.go:442 +0x5d
github.com/docker/libnetwork.(*resolver).ServeDNS(0xc82230d700, 0x0, 0x0, 0xc8225cc240)
    /usr/src/docker/vendor/src/github.com/docker/libnetwork/resolver.go:391 +0xde4
github.com/miekg/dns.(*Server).serve(0xc820340dd0, 0x7fb230734f18, 0xc821b1cab0, 0x7fb230734fc0, 0xc82230d700, 0xc82099c400, 0x51, 0x200, 0xc820339d48, 0xc820d30e00, ...)
    /usr/src/docker/vendor/src/github.com/miekg/dns/server.go:535 +0x7c1
created by github.com/miekg/dns.(*Server).serveUDP
    /usr/src/docker/vendor/src/github.com/miekg/dns/server.go:489 +0x3d5

@campbellr Are you using multiple external resolvers for containers, either though --dns config or from host's resolv.conf ? Going by the decode, this panic can happen in certain cases with multiple external resolvers.

@sanimej I do have 2 nameservers listed in my resolv.conf  on the host machine, if that's what you mean.

@campbellr Yes, that is what I meant. From the decode, it looks like this panic can happen in certain sequences with more than one external nameserver configured. As a temporary work around you can try with one nameserver.

Thanks @sanimej  I will try that out.

Removing the second nameserver from resolv.conf does seem to have resolved the issues. Thanks!

Weirdly this seems to happen on our server randomly, usually seems to be in the early hours. Theres obviously some cleanup tasks or something that are causing it. The log file doesn't seem to offer anything useful beyond the error as to what is causing it.
I'm going to go through all the containers and figure out which ones use --dns options!

this will be fixed in 1.11.1 through https://github.com/docker/docker/pull/22261 (which was just merged)


when i open a select component page is not able to scrolll

Bug report
Current Behavior
when i open a select component page is not able to scroll

Expected behavior

Reproducible example
CodeSandbox Template
Suggested solution

Additional context

Your environment

Software
Name(s)
Version

Radix Package(s)

React
n/a

Browser

Assistive tech

Node
n/a

npm/yarn

Operating System

@Arunjenson-ss should be resolved in https://github.com/radix-ui/primitives/pull/2253


chore: type repeatWhen notifier as void

Description:
This PR makes a trivial change to the type of the notifications observable passed to the notifier in repeatWhen. The observable emits when the source completes and it does not emit a value - there is an internal Subject<void> that's used for notifications.
This PR types the notifications as Observable<void> instead of Observable<any>.
No dtslint test is added because there is no inference involved here.
Related issue (if exists): None

Thanks, @cartant!

I'm seeing an issue in Google that I think is a result of this PR. Could I get some help with a fix please?
The code is as follows:
 this.updateSubscription =
        this.alertService.getAlerts()
            .pipe(repeatWhen(
                (observable: Observable<GetAlertDescriptionResponse>) =>
                    observable.pipe(concatMap(() => timer(5000)))))
            .subscribe((response: GetAlertDescriptionResponse) => {
              this.response = response;
            });

And I get the following error:
Argument of type '(observable: Observable<GetAlertDescriptionResponse>) => Observable<number>' is not assignable to parameter of type '(notifications: Observable<void>) => Observable<any>'.
  Types of parameters 'observable' and 'notifications' are incompatible.
    Type 'Observable<void>' is not assignable to type 'Observable<GetAlertDescriptionResponse>'.
      Type 'void' is not assignable to type 'GetAlertDescriptionResponse'.

38                 (observable: Observable<GetAlertDescriptionResponse>) =>
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
39                     observable.pipe(concatMap(() => timer(5000)))))
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Remove the Observable<GetAlertDescriptionResponse> annotation. It's incorrect. The notifier will not emit a value.


FIX: Don't use realpath() for module and base path

fixes #20 and #34
Is there a particular reason why we have been using realpath in the first place?
Can we not assume that the list of modules given to us are the paths we want?

Any chance you could add a unit test to cover this scenario?

to busy at the moment. feel free to create an issue and tag me in it for a later time though.
Any chance we can get this merged without test coverage?

I think either way, this is fine re test coverage.
If we have test coverage, then that's good and we can see nothing has broken and I don't think we should have a test that explicitly allows "bad" paths, that could shoot us in the foot in the future. If we don't have any test coverage of this, then it's probably not @Zauberfisch's job to add it

I encountered this problem recently when trying to update some modules for SS5... the same symlink strategy that has always worked for me is ruined by this bug 😅 I don't know why I haven't experienced it before but it's quite a PITA for local module development. I'm surprised this isn't affecting all/most module developers?
Anyway... I poked around for a couple of hours tonight and think I might have found the missing piece. This fix from @Zauberfisch worked perfectly for me - but I don't use a theme installed by composer (no shade, but... does anyone?). So I tried installing the simple theme and got the same error @maxime-rainville hit at the vendor-expose step. I thought maybe we were looking at an edge case for themes, since they're not installed in to the vendor directory. BUT right after hitting that error during composer update, I ran composer vendor-expose - and this time I didn't get an error. Symlinking worked just fine. I was able to reproduce this by uninstalling and re-installing the theme.
So I figured there must be a difference between doing the expose command at install time, vs running the 'expose all' command.
I found that in VendorPlugin::getLibrary() a Library is instantiated with (pseudo-code) new Library($this->getProjectPath(), $composerInstaller->getInstallPath($package)). The problem is that Composer's getInstallPath returns a relative path, as opposed to the absolute ones you get in VendorExposeCommand::getAllLibraries().
If I patch VendorPlugin::getLibrary() so the last line reads:
return new Library($this->getProjectPath(), $this->getProjectPath() . '/' . $path);

...then everything seems to work just fine without realpath.
I'm sure there's a 'right' way to join the paths as opposed to the hack I'm doing there, but I don't really know what it is. I also don't think I'll be able to find any more time to work on this - sorry - but I hope this provides a path to fixing this issue! As @Zauberfisch pointed out in #34, symlinking in a local repo is the 'official' way to do module development as far as I'm aware so it would be great to get this fixed.

The master branch is being deleted, which would close this PR. Based on https://github.com/silverstripe/vendor-plugin/pull/43#pullrequestreview-670770913 I will instead retarget this PR at the 1.7 branch so if it ever gets merged it can be released as a patch.


Title is missing

In LayoutDuSite.cshtml
<EMAIL_ADDRESS>Is not working

Hard-coded at this time
<title>Fridge</title>


feat: implements i18n

#45
Add an empty content/ja directory to temporarily run yarn build-content. (ex. mkdir content/ja)

In order to make PR divide, I withdraw.


fedimint-cli config crashes if there are unknown modules

This is a connection string to a mutinynet federation running 0.1 release containing 2 custom modules: fed115fjxjp793mdynuq78ju724wxelmhj336pqw845d8s4a5jfm75a3d8hc8hwmg4nmskmrpkzw5cqk6yqpfwaehxw309askcurgvyhx6at5d9h8jmn9wsknqv3wv3jhvtnxv4jxjcn5vvhxxmmd97a5ttq64kahlwtahn07zr64k2c
If you run fedimint-cli config after joining this federation, you get the following:
2023-11-07T20:59:30.109474Z  INFO fedimint_client: Detected configuration for unsupported module id: 3, kind: fedi-social
2023-11-07T20:59:30.109554Z  INFO fedimint_client: Detected configuration for unsupported module id: 4, kind: stability_pool
2023-11-07T20:59:30.162592Z  WARN fedimint_client: Module kind fedi-social of instance 3 not found in module gens, skipping
2023-11-07T20:59:30.162613Z  WARN fedimint_client: Module kind stability_pool of instance 4 not found in module gens, skipping
2023-11-07T20:59:30.163068Z  INFO fedimint_client::sm::executor: Starting state machine executor task
thread 'main' panicked at /Users/justin/work/fedimint/fedimint-core/src/encoding/mod.rs:734:17:
Expected decoded value. Possibly `redecode_raw` call is missing.
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2023-11-07T20:59:30.164639Z  INFO fedimint_client: Last client reference dropped, shutting down client task group
2023-11-07T20:59:30.164728Z  INFO fedimint_client::sm::executor: Shutting down state machine executor runner due to shutdown signal

Right after observing this, I tried to spend some ecash and observed this:
$ cargo run --bin fedimint-cli -- --data-dir federations/mutinynet-02 spend 1
    Finished dev [unoptimized + debuginfo] target(s) in 0.44s
     Running `target/debug/fedimint-cli --data-dir federations/mutinynet-02 spend 1`
2023-11-07T21:03:15.559629Z  INFO fedimint_client: Detected configuration for unsupported module id: 3, kind: fedi-social
2023-11-07T21:03:15.559700Z  INFO fedimint_client: Detected configuration for unsupported module id: 4, kind: stability_pool
2023-11-07T21:03:15.615263Z  WARN fedimint_client: Module kind fedi-social of instance 3 not found in module gens, skipping
2023-11-07T21:03:15.615298Z  WARN fedimint_client: Module kind stability_pool of instance 4 not found in module gens, skipping
2023-11-07T21:03:15.615915Z  INFO fedimint_client::sm::executor: Starting state machine executor task
2023-11-07T21:03:15.617057Z ERROR fedimint_core::db: error=Other decoding error: Error decoding blind message
thread 'main' panicked at /Users/justin/work/fedimint/fedimint-core/src/db/mod.rs:2401:18:
Unrecoverable decoding DatabaseValue: key: 20fe0200000072d9b5c686fce6fbd3d5d50b8c2d07442ead5e7a8f40465b0dcd7db8cb066c17

Caused by:
    Other decoding error: Error decoding blind message
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2023-11-07T21:03:15.617786Z  INFO fedimint_client: Last client reference dropped, shutting down client task group
2023-11-07T21:03:15.617878Z  INFO fedimint_client::sm::executor: Shutting down state machine executor runner due to shutdown signal

I just tried this again on master to see if it's still a problem, and I got a slightly different error message. That database key looks a little suspect to me because I know we used to use a similar-looking key for backup & recovery state machine:
2024-02-05T13:00:38.489360Z  WARN fedimint_client: Detected configuration for unsupported module id: 3, kind: fedi-social
2024-02-05T13:00:38.489385Z  WARN fedimint_client: Detected configuration for unsupported module id: 4, kind: stability_pool
2024-02-05T13:00:38.489416Z  WARN fedimint_client: Client missing ClientRequiresRecovery: assuming complete
2024-02-05T13:00:38.496854Z  WARN fedimint_client: Module kind fedi-social of instance 3 not found in module gens, skipping
2024-02-05T13:00:38.496880Z  WARN fedimint_client: Module kind stability_pool of instance 4 not found in module gens, skipping
thread 'tokio-runtime-worker' panicked at /Users/justin/work/fedimint/fedimint-core/src/db/mod.rs:970:26:
Unrecoverable error reading DatabaseKey: key: a101010101010101010101010101010101010101010101010101010101010101010103fe00039ad7010101010101010101010101010101010101010101010101-236287

Caused by:
    Other decoding error: Invalid enum variant 3 while decoding MintClientStateMachines
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at /Users/justin/work/fedimint/fedimint-core/src/encoding/mod.rs:897:17:
Expected decoded value. Possibly `redecode_raw` call is missing.
2024-02-05T13:00:38.498411Z  WARN fedimint_client::sm::executor: Failed to send shutdown signal to executor, already dead?
2024-02-05T13:00:38.498424Z ERROR fedimint_client: Error while awaiting client shutdown confirmation

@dpc did we remove the recovery SM completely? This would be problematic for any client that recovered in the past as it would still have the state transition log.
Imo we should leave the enum variant in and just delete all state transitions. That way ongoing recoveries during upgrade get bricked (ok imo) while clients that recovered in the past keep working.

@elsirion check if still a problem

@dpc did #4399 fix this?


Get rid of snapshot directory + related code cleanup and refactoring.

Add new subdir postgres_ffi/samples/ for config file samples. We only need pg_hba.conf. All other files can be empty.
Don't copy wal to the new branch on zenith init or zenith branch.
Import_timeline_wal on zenith init.
issue #325

Ready for review.
The diff looks a bit messy, but it is mostly removing unused code and rearranging what's left.
I need feedback on how to preserve pg_hba.conf sample.
@ericseppanen , does this code looks good to you:
pub static PG_HBA: &'static str = include_str!("../samples/pg_hba.conf");
Or is there a better way to include a sample into the package?

Could extract the removal of 'identify_system' to a separate PR.

Could extract the removal of 'identify_system' to a separate PR.
Done. Check #356

@LizardWizzard , please, review the rebase on top of multitenancy patch


Factor out creation of contextual information (project, application, component) to make it easier to manage and facilitate refactoring of commands

== What is the purpose of this change? What does it change?
Introduces a new Context struct to hold project, application and component information based on specified flags. This should simplify the commands a bit and ultimately, this structure should be passed as an argument to lots of functions which currently take a client, project, application or component name as arguments. This work also targets #871
== Was the change discussed in an issue?
No
== How to test changes?

I believe the exit codes should be 1 not -1

yep, we are using 1 as a return value everywhere else.

Should we look into using errno values for more semantic error codes? Not for this PR obviously, but more generally speaking.

Submitted it as comment only, but I've added some suggested changes @metacosm

@cdrage fixed

Changes LGTM.
Let's wait until tests return back green and then we can merge :100:

:white_check_mark: odo build 263 completed and artifacts can be found here (for commit https://github.com/redhat-developer/odo/commit/a0b45435be by @metacosm)

Awesome, merging based on 3 acks and all checks passing!

Should we look into using errno values for more semantic error codes? Not for this PR obviously, but more generally speaking.

are there constants for exit codes in golang stdlib? I couldn't find it.


Optimize debug drawing

Main change is contact drawing.


Selected items without reference to source items

How can I select items from one source table to destination multiple tables (src = items, dest = selected[chosenSetIndex] ) without reference to source items. Case 1: when i select one item in source table to multiple dest tables and change values on one item in any table it changes everywhere. Case 2: with more than one item selected from source to dest it is the same. When i select from source table to dest table and switch between them it has references to source table items. How can i use copies when selecting from source to destination?

If I understand correctly, you want to select copies of the original item so that the selected item and original item do not have the same reference? Right now there is now direct way to do this. I think I am going to do two things though,

Allow the developer to specify a function for the md-select attribute such that the return value is selected.
Allow the developer to specify their own comparator function to test if two items are equal.

I believe the combination of these two features will provide much greater flexibility to the select mechanism.

My workaround for this issue:
starting line: 934
      if(self.id) {
        return _.some(tableCtrl.selected, [attrs.mdSelectId, self.id]);
        //return tableCtrl.$$hash.has(self.id);
      }

Temporary fix until the control supports this feature.


Promote Tabitha Sable to full PSC member

As discussed offline, we would like to promote Tabitha to full PSC member to fill the vacancy when Craig stepped down. Tabitha has been helping out the PSC as an associate since Sep 14, 2020.

yay @tabbysable !
/lgtm

/lgtm
Welcome @tabbysable, and thanks for your willingness to help the community in this role!

/lgtm
I'm so happy to be here
/honk

can i just provide an unsolicited TABBY IS THE BEST!
congrats!!

/honk
/pony party


esx-ui 2.18

https://hostupdate.vmware.com/software/VUM/PRODUCTION/main/esx/vmw/vib20/esx-ui/VMware_bootbank_esx-ui_2.18.0-23593406.vib

I've politely asked you several times in other issues about zero effort posts and to please make an effort to explain what you have linked or what your issue may be.  (This link is not the 20243001 update previously mentioned in another case).  An answer without a question you will appreciate has no value, and is just a puzzle without any context.
It would be a helpful courtesy for you to explain yourself and provide the details of the issue you are experiencing, or the details around what you are asking. Without this I must close.

closing due to no info provided


ENG-2723 renamed nx page type

Renamed nx page type to NX
Fixed tests

looks good, although what do you think extracting NX and NT as constants in some const file? So, for example if we change later the value of NX -> Next, you dont have to make 10 line changes?

@chalagashvili sounds good. I have some improvements to make in that matter, like create types for this library and I will put that improvement in a separate PR.
Let's merge this for now.
Thanks!


DBZ-5569 Oracle connector's max.queue.size.in.bytes is invalid

https://issues.redhat.com/browse/DBZ-5569

Thanks @harveyyue, applied to main (=2.0) and backported just the task-change to branch 1.9.


No code, no truth!

We don't trust paper, we just trust code.

Thank you for your interest. We have prepared the code and are currently awaiting the final decision from ACMMM24.

The code of test has been released.


As a user, I would like to be able to have special characters such as "." in the name of the task

... so that I can name task such as Project v1.2

Will not be implementing.


feature req: include cognito authentication

Would love to see this boilerplate containing working setup for cognito userpools and/or cognito federated identities.
Would you consider this to be in scope?

Hey @gebrits thanks for the feedback and the great idea!
We're currently working on Serverless v1 (see: https://github.com/serverless/serverless/tree/v1.0) and plan to update the projects we have so that they run v1. We'll consider this when we start the work on the GraphQL boilerplate.

cheers. Looking forward!

@gebrits we shipped it about 3 months ago. let me know what you think 👍


cran examples strategy

As CRAN does not allow long running calculations in examples of packages.
May I ask, what is your current/future strategy regarding documentation of examples of this package?
I'm interested especially in order to identify broken dependencies of packages which import sparklyr.

@jwijffels we have different levels of automated tests: travis runs a medium suite of tests, locally we run some longer ones. In distributed systems, some issues will only be identified at scale, which we currently don't automate. Instead, we have a lockdown period before release to CRAN where we don't fix bugs, focus on testing at scale and ask the community to upgrade to this pre-CRAN build to identify potential regressions.
That said, it would be great to have automated testing that runs at scale by: provisioning a cluster, running the tests, reporting results with performance benchmarks and shuts down. This is not on our radar on the short term, but definitely something we would like to see at some point.

That's clear. Many thanks for the feedback!


[WIP] feat(auth): add actions and reducers

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: N/A
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[ ] No

Other information

Would it be important to also include a DaffAuthLoginRetry action in addition to the regular login action? There may be value in having both.

@Nolan-Arnold is that for automatic retries? That could be useful for the login process.


Nav numbers start appearing when using pheasant

I'm using mkdocs 1.1. My nav initially looks like this:

However, when I enable pheasant, it looks like this:

Here's my mkdocs.yml: https://github.com/rjsf-team/react-jsonschema-form/blob/bdf81a70fc90f0f32b8a4e3ee5d8a4b0328d817d/mkdocs.yml#L15

I changed the default behavior of nav numbering (False by default). Please update pheasant to version 2.5.2  or later.

Thanks!


Use pytest fixtures to serve the test data

Closes #106

The coverage percent goes down very slightly because the test data was considered "tested" code previously, and now it is not. This is fine.


<release 13>- cherry-pick request: Removing spurious warning in tf.data.

[tf.data] Avoid printing a spurious warning for tf.compat.v1.data.make_one_shot_iterator and tf.compat.v1.data.make_initializable_iterator.
PiperOrigin-RevId: 231281365

I apologize, but this breaks compatibility with distribution strategy, so I will not be able to include it in 1.13. I'm reverting in #25497


AttributeError: dlsym(RTLD_DEFAULT, Error_GetLastErrorNum): symbol not found

Hello.
'pip install osmnx'
fails at rtree:
Collecting rtree>=0.8 (from osmnx)
Using cached Rtree-0.8.2.tar.gz
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "/private/var/folders/6g/7qfb0g056b14k5jr15p7x65r0000gs/T/pip-build-8aelx0az/rtree/setup.py", line 4, in
import rtree
File "/private/var/folders/6g/7qfb0g056b14k5jr15p7x65r0000gs/T/pip-build-8aelx0az/rtree/rtree/init.py", line 1, in
from .index import Rtree
File "/private/var/folders/6g/7qfb0g056b14k5jr15p7x65r0000gs/T/pip-build-8aelx0az/rtree/rtree/index.py", line 6, in
from . import core
File "/private/var/folders/6g/7qfb0g056b14k5jr15p7x65r0000gs/T/pip-build-8aelx0az/rtree/rtree/core.py", line 110, in
rt.Error_GetLastErrorNum.restype = ctypes.c_int
File "/usr/local/Cellar/python3/3.5.2_2/Frameworks/Python.framework/Versions/3.5/lib/python3.5/ctypes/init.py", line 360, in getattr
func = self.getitem(name)
File "/usr/local/Cellar/python3/3.5.2_2/Frameworks/Python.framework/Versions/3.5/lib/python3.5/ctypes/init.py", line 365, in getitem
func = self._FuncPtr((name_or_ordinal, self))
AttributeError: dlsym(RTLD_DEFAULT, Error_GetLastErrorNum): symbol not found
Toblerity/rtree has an open issue about it, I'm running
Os X 10.12.1,  python 3.5.2.

This isn't an OSMnx issue - it's an rtree issue. You might want to open an issue directly with the rtree GitHub repo. That said, you're on OS X so you may want to try to install with conda's IOOS channel:
conda install -c ioos rtree=0.8.2
Some of my students that have macs struggled to install rtree with pip, but succeeded with that conda command. If you're on windows, you can follow these instructions to install geopandas and rtree.

I just had to brew spatialindex. Excuse, I was too impatient or too lazy to read the rtree-issue precisely. Good thing I was too lazy to mind installing conda though ;)

@jasimmk solution worked for my system and configuration - thanks.

Details:
macOS => Catalina /// 10.15.3

Note also that pip worked as well.


navbar bar in chapter page

Before

After

Yes sure! Can u pls add that even too events page... @Git21221


Missing fstring on search miss error

https://github.com/pydanny/daniel-blog-fasthtml/blob/5f16252d3c43106e2db37413b4bdc6ca88b00e75/main.py#L160

Thanks for this report! I think I fixed it a few weeks ago.


Update: ransome1.sleek version 1.1.6

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.1 schema?

Microsoft Reviewers: Open in CodeFlow

@wingetbot run


make some example data that illustrates multiple sequencing libraries for the GROW study

cc @aclum

multiplicity could actually appear at many point in the path


Typo or bad connexion ?

Hello there, your explanation included in the plugin mentions putting the model as follow "gpt-4".
But I got an error message as such :Error: NotFound Not Found {
"error": {
"message": "The model: gpt-4 does not exist",
"type": "invalid_request_error",
"param": null,
"code": "model_not_found"
}
}
There is also no way right now to correct that problem, except maybe for uninstalling the all thing.

Do you have access to the ChatGPT4 Token? If not you'll have to use GPT-3.5.
You can delete the current token and try again (or edit it). It's available at %appdata%\McNeel\Rhinoceros\packages\7.0\GHPT\0.1.3
#8 was created to address handling tokens, and also storing them better.

@SpaceArchitecture The token can stay the same, but you do have to switch to using the gpt-3.5-turbo model (the model used is specified in the same JSON that @clicketyclackety mentioned). Sadly, there is a waitlist for GPT-4 access and I personally have been on it for a while. Something to note is that the hackathon demo used GPT-4, which is far more capable than GPT-3.5, so we have no idea how well this will work with a less powerful LLM. Hope this helps.


Error when run inference.py

I got this issue when run inference.py，can anyone help me? My python is python 2.7.5 and tensorflow is 1.1.0.
yjcai@inspur ssd_tensorflow_traffic_sign_detection]$ python inference.py -m demo
Traceback (most recent call last):
File "inference.py", line 6, in
from model import SSDModel
File "/export/userhome/yjcai/Documents/SSD/ssd_tensorflow_traffic_sign_detection/model.py", line 241
box = (*box_coords, cls, cls_prob)
^
SyntaxError: invalid syntax

using python =>3 and and switch to directory and using "python3 inference.py -m demo"


Deliver: Phased release (phased_release) does not seem to work

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
Setting the phased_release parameter of deliver does not set the build to phased release in iTunes Connect.
Command executed
No error as such, just doesn't set the build to phased release. Sample from the script I'm running which uploads fine:
bundle exec fastlane ios both

Key deliver call here:
    deliver(metadata_path: "fastlane/metadata-ios-alternative",
            skip_metadata: true,
         skip_screenshots: true,
                      ipa: "build/ios-alternative/#{version}/#{build}/ios-alternative.ipa",
           app_identifier: "my.app.id.pro",
        submit_for_review: false,
       reject_if_possible: true,
           phased_release: true)

Complete output when running fastlane, including the stack trace and command used

[17:31:43]: ---------------------
[17:31:43]: --- Step: deliver ---
[17:31:43]: ---------------------
[17:31:43]: Successfully loaded '/Users/username/dev/myapp/fastlane/Deliverfile' 📄
[17:31:43]: No values defined in './fastlane/Deliverfile'
[17:31:43]: Login to App Store Connect<EMAIL_ADDRESS>[17:31:45]: Login successful
+--------------------------------------+----------------------------------------------------------------------------+
|                                              deliver 2.148.1 Summary                                              |
+--------------------------------------+----------------------------------------------------------------------------+
| metadata_path                        | fastlane/metadata-ios-alternative                                          |
| skip_metadata                        | true                                                                       |
| skip_screenshots                     | true                                                                       |
| ipa                                  | /Users/username/dev/app/build/ios-alternative/1.48.6/2911/ios-alternative.ipa |
| app_identifier                       | my.app.id.pro                                              |
| submit_for_review                    | false                                                                      |
| reject_if_possible                   | true                                                                       |
| phased_release                       | true                                                                       |
| screenshots_path                     | ./fastlane/screenshots                                                     |
| app_version                          | 1.48.6                                                                     |
| username                             |<EMAIL_ADDRESS>                                                            |
| platform                             | ios                                                                        |
| edit_live                            | false                                                                      |
| use_live_version                     | false                                                                      |
| skip_binary_upload                   | false                                                                      |
| skip_app_version_update              | false                                                                      |
| force                                | false                                                                      |
| overwrite_screenshots                | false                                                                      |
| automatic_release                    | false                                                                      |
| reset_ratings                        | false                                                                      |
| team_id                              | my-team-id                                                                |
| dev_portal_team_id                   | my-portal-team-id                                                          |
| run_precheck_before_submit           | true                                                                       |
| precheck_default_rule_level          | warn                                                                       |
| individual_metadata_items            | []                                                                         |
| ignore_language_directory_validation | false                                                                      |
| precheck_include_in_app_purchases    | true                                                                       |
+--------------------------------------+----------------------------------------------------------------------------+
[17:31:46]: Making sure the latest version on App Store Connect matches '1.48.6' from the ipa file...
[17:31:48]: '1.48.6' is the latest version on App Store Connect
[17:31:51]: Uploading app icon...
[17:31:56]: Uploading binary to App Store Connect
[17:31:57]: Going to upload updated app to App Store Connect
[17:31:57]: This might take a few minutes. Please don't interrupt the script.
[17:59:23]: iTunes Transporter successfully finished its job
[17:59:23]: ------------------------------------------------------------------------------------------------------------------
[17:59:23]: --- Successfully uploaded package to App Store Connect. It might take a few minutes until it's visible online. ---
[17:59:23]: ------------------------------------------------------------------------------------------------------------------
[17:59:23]: Finished the upload to App Store Connect
[17:59:25]: Running precheck before submitting to review, if you'd like to disable this check you can set run_precheck_before_submit to false
[17:59:25]: Running precheck 👮♀ 👮
+--------------------------+-------------------------------+
|               Summary for precheck 2.148.1               |
+--------------------------+-------------------------------+
| default_rule_level       | warn                          |
| include_in_app_purchases | true                          |
| app_identifier           | my.app.id.pro |
| username                 |<EMAIL_ADDRESS>         |
| team_id                  | my-team-id                      |
+--------------------------+-------------------------------+
[17:59:25]: Checking app for precheck rule violations
[17:59:34]: Reading in-app purchases. If you have a lot, this might take a while
[17:59:34]: You can disable IAP checking by setting the include_in_app_purchases flag to false
[17:59:35]: Done reading in-app purchases
[17:59:36]: ✅  Passed: No negative  sentiment
[17:59:36]: ✅  Passed: No placeholder text
[17:59:36]: ✅  Passed: No mentioning  competitors
[17:59:36]: ✅  Passed: No future functionality promises
[17:59:36]: ✅  Passed: No words indicating test content
[17:59:36]: ✅  Passed: No curse words
[17:59:36]: ✅  Passed: No words indicating your IAP is free
[17:59:36]: ✅  Passed: Incorrect, or missing copyright date
[17:59:37]: ✅  Passed: No broken urls
[17:59:37]: precheck 👮♀ 👮  finished without detecting any potential problems 🛫
[17:59:37]: Cruising back to lane 'ios both' 🚘
+------+----------------------------+-------------+
|                fastlane summary                 |
+------+----------------------------+-------------+
| Step | Action                     | Time (in s) |
+------+----------------------------+-------------+
| 1    | default_platform           | 0           |
| 2    | prompt                     | 4           |
| 3    | increment_build_number     | 0           |
| 4    | increment_version_number   | 0           |
| 5    | Switch to ios regular lane | 0           |
| 6    | get_version_number         | 0           |
| 7    | get_build_number           | 0           |
| 8    | build_app                  | 153         |
| 9    | set_changelog              | 10          |
| 10   | deliver                    | 1423        |
| 11   | Switch to ios family lane  | 0           |
| 12   | get_version_number         | 0           |
| 13   | get_build_number           | 0           |
| 14   | build_app                  | 164         |
| 15   | set_changelog              | 7           |
| 16   | deliver                    | 1673        |
+------+----------------------------+-------------+
[17:59:37]: fastlane.tools just saved you 57 minutes! 🎉

Environment

✅ fastlane environment ✅
Stack

Key
Value

OS
10.15.4

Ruby
2.6.3

Bundler?
false

Git
git version 2.24.2 (Apple Git-127)

Installation Source
/usr/local/bin/fastlane

Host
Mac OS X 10.15.4 (19E287)

Ruby Lib Dir
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib

OpenSSL Version
LibreSSL 2.8.3

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
11.4.1

System Locale

Variable
Value

LANG
en_GB.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
`./fastlane/Fastfile`
# This file contains the fastlane.tools configuration
# You can find the documentation at https://docs.fastlane.tools
#
# For a list of all available actions, check out
#
#     https://docs.fastlane.tools/actions
#
# For a list of all available plugins, check out
#
#     https://docs.fastlane.tools/plugins/available-plugins
#

# Uncomment the line if you want fastlane to automatically update itself
# update_fastlane

# - Download Metadata
# fastlane deliver download_metadata --metadata_path fastlane/metadata-ios --app_identifier my.app.id --app_version 1.48.1
# fastlane deliver download_metadata --metadata_path fastlane/metadata-mac --app_identifier my.app.id.mac --app_version 1.13.10 --platform=osx

default_platform(:ios)

platform :mac do
    desc "Push a new release build to the App Store"

    lane :both do
        ver = prompt(text: "Version: ")
        increment_build_number(xcodeproj: "mac/mac.xcodeproj")
        increment_version_number(version_number: "#{ver}", xcodeproj: "mac/mac.xcodeproj")

        regular
        alternative
    end

  lane :regular do
    version = get_version_number(xcodeproj: "mac/mac.xcodeproj", target: "MyAppName")
    build = get_build_number(xcodeproj: "mac/mac.xcodeproj")

    build_app(workspace: "MyAppName.xcworkspace",
                 scheme: "mac",
       output_directory: "build/mac/#{version}/#{build}")

    deliver(metadata_path: "fastlane/metadata-mac",
            skip_metadata: true,
         skip_screenshots: true,
                      pkg: "build/mac/#{version}/#{build}/MyAppName.pkg",
           app_identifier: "my.app.id.mac",
        submit_for_review: false,
           phased_release: true,
       reject_if_possible: true,
        run_precheck_before_submit: false,
        precheck_include_in_app_purchases: false )
  end

  lane :alternative do
    version = get_version_number(xcodeproj: "mac/mac.xcodeproj", target: "MyAppName-Alternative")
    build = get_build_number(xcodeproj: "mac/mac.xcodeproj")

    build_app(workspace: "MyAppName.xcworkspace",
                 scheme: "mac-Alternative",
       output_directory: "build/mac-alternative/#{version}/#{build}")

    deliver(metadata_path: "fastlane/metadata-mac",
            skip_metadata: true,
         skip_screenshots: true,
                      pkg: "build/mac-alternative/#{version}/#{build}/MyAppName.pkg",
           app_identifier: "my.app.id.mac.pro",
        submit_for_review: false,
           phased_release: true,
       reject_if_possible: true,
        run_precheck_before_submit: false,
        precheck_include_in_app_purchases: false )
  end
end

platform :ios do
  desc "Push a new release build to the App Store"

  lane :both do
    ver = prompt(text: "Version: ")
    increment_build_number(xcodeproj: "MyAppName.xcodeproj")
    increment_version_number(version_number: "#{ver}", xcodeproj: "MyAppName.xcodeproj")

    regular
    alternative
  end

  lane :regular do
    version = get_version_number(xcodeproj: "MyAppName.xcodeproj", target: "MyAppName-iOS")
    build = get_build_number(xcodeproj: "MyAppName.xcodeproj")

    build_app(workspace: "MyAppName.xcworkspace",
                 scheme: "MyAppName-iOS",
       output_directory: "build/ios/#{version}/#{build}",
            output_name: "ios.ipa")

    set_changelog(app_identifier: "my.app.id", version: "#{version}") # from fastlane/changelog.txt

    deliver(metadata_path: "fastlane/metadata-ios",
            skip_metadata: true,
         skip_screenshots: true,
                      ipa: "build/ios/#{version}/#{build}/ios.ipa",
           app_identifier: "my.app.id",
        submit_for_review: false,
           phased_release: true,
       reject_if_possible: true,
        precheck_include_in_app_purchases: false )
  end

  lane :alternative do
    version = get_version_number(xcodeproj: "MyAppName.xcodeproj", target: "MyAppName-iOS")
    build = get_build_number(xcodeproj: "MyAppName.xcodeproj")

    build_app(workspace: "MyAppName.xcworkspace",
                 scheme: "MyAppName-iOS-alternative",
       output_directory: "build/ios-alternative/#{version}/#{build}",
            output_name: "ios-alternative.ipa" )

    set_changelog(app_identifier: "my.app.id.pro", version: "#{version}") # from fastlane/changelog.txt

    deliver(metadata_path: "fastlane/metadata-ios-alternative",
            skip_metadata: true,
         skip_screenshots: true,
                      ipa: "build/ios-alternative/#{version}/#{build}/ios-alternative.ipa",
           app_identifier: "my.app.id.pro",
        submit_for_review: false,
       reject_if_possible: true,
           phased_release: true)
   end
end

`./fastlane/Appfile`
<EMAIL_ADDRESS># Your Apple email address
itc_team_id("my-team-id") # App Store Connect Team ID
team_id("my-portal-team-id") # Developer Portal Team ID

fastlane gems

Gem
Version
Update-Status

fastlane
2.148.1
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.3.0

slack-notifier
2.3.2

atomos
0.1.3

claide
1.0.3

colored2
3.1.2

nanaimo
0.2.6

xcodeproj
1.16.0

rouge
2.0.7

xcpretty
0.3.0

terminal-notifier
2.0.0

unicode-display_width
1.7.0

terminal-table
1.8.0

plist
3.5.0

public_suffix
2.0.5

addressable
2.7.0

multipart-post
2.0.0

word_wrap
1.0.0

tty-screen
0.7.1

tty-cursor
0.7.1

tty-spinner
0.9.3

babosa
1.0.3

colored
1.2

highline
1.7.10

commander-fastlane
4.4.6

excon
0.73.0

faraday
1.0.1

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20190701

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday_middleware
1.0.0

fastimage
2.1.7

gh_inspector
1.1.3

mini_magick
4.10.1

multi_xml
0.6.0

rubyzip
1.3.0

security
0.1.3

xcpretty-travis-formatter
1.0.0

dotenv
2.7.5

bundler
1.17.2

naturally
2.2.0

simctl
1.6.8

jwt
2.1.0

uber
0.1.0

declarative
0.0.10

declarative-option
0.1.0

representable
3.0.4

retriable
3.1.2

mini_mime
1.0.2

multi_json
1.14.1

signet
0.14.0

memoist
0.16.2

os
1.1.0

googleauth
0.12.0

httpclient
2.8.3

google-api-client
0.38.0

google-cloud-env
1.3.1

google-cloud-errors
1.0.0

google-cloud-core
1.5.0

digest-crc
0.5.1

google-cloud-storage
1.26.1

emoji_regex
1.0.1

CFPropertyList
3.0.2

json
2.3.0

aws-eventstream
1.1.0

aws-sigv4
1.1.3

aws-partitions
1.319.0

jmespath
1.4.0

aws-sdk-core
3.96.1

aws-sdk-kms
1.31.0

aws-sdk-s3
1.66.0

forwardable
1.2.0

logger
1.3.0

stringio
0.0.2

ipaddr
1.2.2

openssl
2.1.2

ostruct
0.1.0

strscan
1.0.0

date
2.0.0

fileutils
1.1.0

etc
1.0.1

io-console
0.4.7

zlib
1.0.0

libxml-ruby
3.1.0

rexml
3.1.9

psych
3.1.0

mutex_m
0.1.0

webrick
1.4.2

generated on: 2020-05-23

Bump... just to keep this alive until the recent App Store deliver issues are fixed and I can check on this again

Update: This is still an issue with 2.150.0.rc4

Hi, this is still and issue as of 2.155.1 - Thanks!

@strongbox-mark I'm having this same issue, did you ever get around this?

I'm afraid not, I got tired of trying to keep the issue open too :)
You only get a week or so to update and I haven't uploaded in the last week, I'm afraid this issue got closed and I don't have the option to re-open. :(

@joshdholtz is it worth creating a new issue for this or can this be re-opened?

Thanks for ping! Reopened and will look into!

@strongbox-mark @john-mejia I think this might be because you have skip_metadata: true 🤔 This is technically metadata so that needs to be false in order for it to update 😬

Will give that a try @joshdholtz  - Thanks. Could this also explain why my test user/password stopped persisting from older versions after the connectAPI changes?

@john-mejia It shouldn't have stopped persisting 😬 I don't have any issues over here with mine persisting 🤔 But there are to things at play here.

The session is stored in ~/.fastlane/spaceship/<email> directory

There could be some issue with this not getting stored? Maybe?

The password for you Apple ID is stored in Keychain access

This is what gets looked at after the session expires and you enter your email address. If you are relying on your password to be entered automatically and its not reading from here, your keychain may not be unlocked? Maybe?

Sorry my credentials, I'm talking about the beta user and password that we have to provide Apple to test the app during review. I've never had this in the metadata folder but the App Store kept the previously used credentials.After the changes it no longer has them.
I know I can solve this buy adding the beta_user/pw file in metadata, just haven't gotten around to it.

@joshdholtz FWIW we are also (trying) to use phased_release: true with skip_metadata: true and running into this problem. We don't really want Fastlane to touch the other metadata. What's the safest way to configure this?
Maybe leaving the metadata directory empty and phased_release: true, skip_metadata: false?

@robmaceachern Making meta data empty and setting skip to false is the correct work around right now 🤔 I'll look into moving this outside of metadata though! I just need to make sure its backwards compatible enough to make that change 😬

@john-mejia Oh interesting.... Can you create a new issue for that and mention me in it? That does sound like a regression that I might have missed 😬

Thanks a million @joshdholtz for looking into this. I will be uploading a new version of my app in a few days and will come back and let you know how it goes...

Can confirm that emptying metadata directory and setting skip_metadata=false workaround works. Thank you :)
It would be great to have this switch separate from metadata entirely. Cheers! Feel free to close out.


Docker-registry chart in both Stable and Incubator repos

While searching through charts at the commandline I noticed that the 'docker-registry' chart is listed in both the stable and incubator repos. The APP VERSIONs are the same but the CHART VERSIONs differ. Maybe whomever promoted it to stable forgot to remove it from the incubator repo, it doesn't exist in the incubator directory on github.
Thanks

Maybe that's because the older versions are still being tracked for helm. It's kinda useful, since the nodeport is broken and the "stable" registry does not work, but the old incubator version does.


Error: "certificate signed by unknown authority"

I am trying to connect my MongoDb to my Elasticsearch server over HTTPS. My elasticsearch server has a self signed certificate which gives me the error:

transporter: CRITICAL: elasticsearch error (Post https://....../_bulk: x509: certificate signed by unknown authority)

when running transporter.
Is there any way to tell transporter to ignore verifying the certificate?

I managed to solve the problem by adding the certificate to my root certicate store.


Use HTML5 Notification instead of the display-notification module

It seems better to use BrowserWindow and html5 Notification instead of displayNotification. It solve #23 and looks better because it shows icon. also for window, linux support.

Sure. PR welcome :)

@sindresorhus How about node-notifier?

@zeakd I don't really see the point when Electron has it built-in through the browser window.

for OS support. The difference is Electron just can open Chromium based window which have HTML5 Notification API, and node-notifier is an abstraction of some notification systems. node notifier OS support

I'm aware of how it works, but node-notifier is, from previous experience, very buggy and I don't see much added value in the extra maintenance overhead when HTML5 notifications solves our specific use-case good enough.

Closing as this app is now deprecated.

Closing as this app is now deprecated.


Sending body

I just tried to send some POST data to an already existing API. It informed me that certain required fields were not found in the body. After quickly looking through the module's code, I saw that the body in "index.js" (after line 59) is not set for the request.
This is how I made the request:
var HTTP = require("the-request");  HTTP(method, url, {    headers: {...},    body: JSON.stringify({...})  });
The body was a JSON object, but I set the header myself.
The same request seemed to work fine with the "request" module.
I don't know if this is an actual bug, but I just wanted to make you aware of this.

If you can provide a runnable example, perhaps targeting https://requestb.in, I will investigate.  As it is, it's totally unclear what headers/body are not being sent.  I don't even know which http method you were using.


Make sure nullable attributes icon and cover are set to None

This fixes #219.
It would be really nice if this could be merged and released so that I can also make a new release of Ultimate Notion. Thank you 🙏

Thanks for the PR @FlorianWilhelm! I went with a bit more extreme approach in 28020cd, can you tell me if that works for  you? See the rationale in #101.

PS – Regarding Ultimate Notion, I'm always glad to see some effort to build a higher-level library on top of notion-sdk-py so thank you for this! Did you check notional? It's been there for a while now and seems to be willing to achieve the same goals as you are and would probably benefit from more contributors. :)

@ramnes Thanks for fixing this issue and I think your approach is even nicer than my PR.
Regarding notional, I tried to use it, but it doesn't seem to be under active development anymore, and I don't agree with many of the design decision. This is why I copied some parts over as I like the Pydantic approach, but added an extra layer of indirection, which famously solves almost all problems in computer science 😅. I also think that Ultimate Notion is much easier to use compared to Notional and of course more pythonic. But doesn't every developer say that about his/her own software? ;-)
I'll definitely contribute to notion-sdk-py whenever I find an issue, as your package is the base for my package. Sadly, I also found a lot of bugs within the Notion API itself, but the Notion devs are really not that responsive. For instance, whenever I try to make a self-referential two-way relation, for instance to express a parent task and child tasks in a task database, the Notion API only returns a one-way relation. Creating a two-way relation from a database A to a database B works perfectly but only if A is not B.
What are your experiences with the Notion devs and bugs in their API or is it just me 😅 ?

Got to admit that I haven't talked to them much so far. Did you try the Notion API developers Slack?


Camera in webview android is opened. But when I press 'ok' button in camera. The Image is not uploaded.

Hi Everyone, this is not an bug but a question
I use this library but it seems that the camera photos is not uploaded in html.
I already grant access to camera and storage but upon clicking camera, the camera is opened and capturing image on android phone but after clicking 'ok' it doesnt attach file to photo

Same issue with me. Uploading via file picker is working but I need to upload a photo using camera, but I can't capture the photo

I am also facing the same issue with Android 13, the camera launched, and after taking the photo and clicked on "Use Photo", nothing is being uploaded to the photo uploader plugin.
However, the camera photo upload works fine on iPadOS 17.

Hey everyone! My camera photo is able to upload the image to the uploader input now. Below are the setups that need to done.
1. Make sure to request for camera permission in your main() method.
import 'package:permission_handler/permission_handler.dart';

Future main() async {
  WidgetsFlutterBinding.ensureInitialized();
  await Permission.camera.request();
  await Permission.microphone.request(); // if you need microphone permission

  runApp(MyApp());
}

2. Make sure to have the below permissions in your AndroidManifest.xml
<uses-permission android:name="android.permission.INTERNET"/>
<uses-permission android:name="android.permission.CAMERA" />
<uses-permission android:name="android.permission.RECORD_AUDIO" />
<uses-permission android:name="android.permission.MODIFY_AUDIO_SETTINGS" />
<uses-permission android:name="android.permission.VIDEO_CAPTURE" />
<uses-permission android:name="android.permission.AUDIO_CAPTURE" />

3. Make sure to also add the below block in your AndroidManifest.xml
<provider
    android:name="com.pichillilorenzo.flutter_inappwebview_android.InAppWebViewFileProvider"
    android:authorities="${applicationId}.flutter_inappwebview_android.fileprovider"
    android:exported="false"
    android:grantUriPermissions="true">
    <meta-data
        android:name="android.support.FILE_PROVIDER_PATHS"
        android:resource="@xml/provider_paths" />
</provider>

This is officially documented in the documentation.
https://inappwebview.dev/docs/intro#enable-camera-for-html-inputs


Custom checkbox is broken with empty label

components: CustomInput
reactstrap version #6.5.0
import method es
react version #16.5.2
bootstrap version #4.1.3

What is happening?
If label is "" (empty string) or undefined layout is broken

What should be happening?
Checkbox itself should be rendered correctly

Steps to reproduce issue
Error message in console
set label="", f.e.
<CustomInput
    id="test"
    type="checkbox"
    label=""
/>

Video example
http://s.syabro.com/2018-12-11_15-14-57.mp4
Maybe replace label rendering with:
<label className={mapToCssModules('custom-control-label', cssModule)} htmlFor={attributes.id}>{(label === '' || label === undefined) ? ' ' : label}</label>

This is an issue with bootstrap itself and has already been fixed (it will be released in bootstrap v4.2.0)
See https://github.com/twbs/bootstrap/pull/27566
Current workaround: Add this style to your css:
.custom-control-label {
  vertical-align: top;
}

Demo: https://stackblitz.com/edit/reactstrap-v6-7z5g6j?file=style.css

@TheSharpieOne thanks


fixing build of tools for MinGW

otherwise I would get the following error when linking shaderc.exe

../../../../bin/gcc/Release/libbx.a(os.cpp.obj):os.cpp:(.text+0x49): undefined reference to `GetProcessMemoryInfo'

Note: I'm using MinGW-w64 gcc 7.1 and also have VS 2017 installed with the Game development with C++ workflow

Ah, nice. I wasn't sure since I haven't used MinGW in a while. Thanks!


Add Korea Advanced Institute of Science & Technology scraper

I wrote a lot of comments for this one, but I think they're helpful comments.

@HarrisonGregg I followed your suggestion and also fixed a bug where e.g., row.css(:nth-child(6)::text) would cause the text of the whole row to be selected if the row was the sixth child, instead of the text of the sixth child of that row, which is intended to be a td element.

@HarrisonGregg The scraper checks a_value and a_text now.  In addition, I noticed I was accidentally executing a search for ALL departments, which I wanted to specifically avoid by iterating over the departments one-by-one.


[now dev] Rename nowJson variables to nowConfig

This is only a cosmetic code change, but aligns more nicely with the new zero-config approach (where there is no now.json).

Codecov Report

Merging #2558 into canary will increase coverage by <.01%.
The diff coverage is 69.56%.

@@            Coverage Diff             @@
##           canary    #2558      +/-   ##
==========================================
+ Coverage   13.64%   13.64%   +<.01%
==========================================
  Files         256      256
  Lines        9434     9431       -3
  Branches     1078     1077       -1
==========================================
  Hits         1287     1287
+ Misses       8023     8020       -3
  Partials      124      124

Impacted Files
Coverage Δ

src/util/dev/builder.ts
75.46% <100%> (ø)
:arrow_up:

src/util/dev/server.ts
64.29% <68.18%> (+0.06%)
:arrow_up:

src/util/metrics.ts
68.18% <0%> (+6.64%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4945218...3beb8d8. Read the comment docs.


chore: Add internal, refactor and more categories to release-please configuration.

Type
enhancement

Description

Expanded the release-please-config.json to include new categories for changelog generation.
New categories include 'style', 'refactor', 'revert', 'internal', 'deps', 'security', and 'breaking'.
Each new category is properly configured with a section name and visibility settings.

Changes walkthrough
Relevant filesConfiguration changes

release-please-config.jsonExpand Release-Please Configuration with Additional Categories

release-please-config.json
Added new categories for changelog generation: 'style', 'refactor', 'revert', 'internal', 'deps', 'security', 'breaking'.  Each category is associated with a specific section and visibility setting.

+35/-0

✨ PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.63%. Comparing base (afdec96) to head (df7785a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
- Coverage   94.26%   93.63%   -0.63%
==========================================
  Files          12       12
  Lines        1116     1116
==========================================
- Hits         1052     1045       -7
- Misses         64       71       +7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Stop sending requests on redux-form-saga actions

This pull request fix sending a request for redux-form-saga actions.
redux-saga-requests will ignore the following action:
{
  type: '@@redux-form-saga/PROMISE',
  payload: {
    request: {
      type: 'form_REQUEST',
      payload: {
        email: 'admin@localhost'
      }
    },
    defer: {},
    types: [
      'form_SUCCESS',
      'form_FAILURE'
    ]
  }
}

@EvgeneOskin Thanks! So again we have some collision :) Could you please update failing test? Then I will merge it

Hi @klis87 ! I've updated failing tests 🙂

Coverage increased (+0.1%) to 87.805% when pulling f321d8e7359f5b281f54f7bd1c7dd69987441095 on EvgeneOskin:fix-false-catching-of-promise-actions into 038edba667528b9aed4cd616a82514a21c3a9947 on klis87:master.

@EvgeneOskin published in 0.16.0


Approval workflow update

After approval form creation, PM/Staff would like to send PAF for approval to specific people from the different roles such as Finance, VP, Compliance.
We need to provide a way for the PM/Staff to select that person's email id to specifically select the person responsible for approvals.

Closing in favour of https://github.com/HyphaApp/hypha/issues/3188


MUT file support not available from local file upload

igv.js supports MUT file however it has not been supported for "local file" -> upload

mut file support is not released in igv.js yet, and is not supported in igv-webapp (yet).    I will be wrapping up support for both projects this week.

gotcha. In the meantime, would you be able to point me to the file where the webapp handles local file imports?

Hi. Just wanna follow up for any updates on this.

@feedlord18 We just released versions of igv.js and igv-web that support MUT files.


Enhancement: Animation when the portal is opening to give the game time to load so you dont lag spike

my idea is that everytime you open a portal it could display some cool effect instead that has atleast 10sec animation time, then the dimension can load in the background and have a little lowered priority so it doesent lag spike you evertime you open a portal
it could also be nice to be able to reverse it with some item so you can turn off the portal again or just leave it with some idle animation and then push a button to make it open again
another idea ive had is that, you could have only the 3 nearest chunks to the portal load, and the chunks around that are just place holders of some sort like really low LOD and no entities untill you travel through, or atleast freeze their AI or something..
anyway thanks for the mod, built my whole pack around it cause i think the effect is damn cool :D

https://www.curseforge.com/minecraft/modpacks/chosencraft

Some people have good PC and they probably not want it to delay 10 seconds
A dispenser with water bucket can turn off the nether portal and a dispenser with fireball can turn on the nether portal. the portal can also be managed by commands.
You can change "indirectLoadingRadiusCap" in the config (by editing the config file) so that it will limit the loading range through portal

About lag spike: last time I tried to optimize the lag spike and profiled that sometimes the lag spike comes from client light update. You can try to install phosphor and see whether the lag spike reduces (compatibility issues may occur).

1: okay but maybe it could be for like servers and low end machines, a configurable option for if you want animation or not, and how long the animation should take. then if you could put a small comment next to the option that explains that the longer you allow the animation to run the smaller the chance of a lag spike.
2: ahh okay i did not know that, maybe if you could just place a button on the portal and it could turn it on and off? would be a little more intuitive i think
3: i did actually all ready and it definently helped with the lag but there is still one large spike when you open it
i have optifine G7 and performant and a bunch of other mods in the pack, tried to install roadrunner but its incompatible at the moment.


[jjbb] for scheduling e2e jobs

What
Create the JJBB definition (aka the Jenkins UI jobs) for:

The scheduling twice a day as requested
The e2e pipeline.

Create the e2e pipeline skeleton, the implementation for what to run to be done in a follow up.
Why
It was requested to create a scheduled execution of the new E2E twice a day and notify in slack the outcome.
Further details
I decided to enable a Multibranch Pipeline to be able to test the pipeline manually if needed on a PR basis. It will only be triggered automatically on a daily basis (twice).
In my experience, Multibranch Pipelines help to iterate faster since we can work on a PR basis.
Notifies
https://github.com/elastic/synthetics/pull/417 and https://github.com/elastic/synthetics/pull/393

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2021-11-18T16:50:07.395+0000

Duration: 14 min 13 sec

Commit: 9f53bb647f8c7c081f70fe717c93ae612dc3e17b

Test stats :test_tube:

Test
Results

Failed
0

Passed
144

Skipped
0

Total
144

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

I'll merge this PR now since it's not tested in the CI but creating the required jobs (JJBB)