Godot Mono c#: freeing a node in an HBoxContainer doesn't fully remove it.

Godot version
Godot Engine v3.3.2.stable.mono.official
System information
Windows 10, OpenGL ES 2.0 Renderer: GeForce GTX 1050/PCIe/SSE2
Issue description
When I free a child from an HBoxContainer using QueueFree. The HBoxContainer still registers it as a valid instance, and is used when, for example calling GetChild(0);
Then when a function is called on a this ghost child and exception is throw, because it doesn't exist.
Steps to reproduce
Fist of all, most of the time that I think I have found a bug it's ends up being that I was doing something wrong. So if that is the case here I apologize in advanced.

I have this basic scene.

On ready: it will add 20 PackedScene Instances of the ButtonScene, and connect a custom "NewSignal" signal to detect when each button is pressed; as well as adds them as children of the HBoxContainer.

2. The add20 function adds the 20 instances, selects a current button scene and sets Pressed to true; The current button ID is 1216

3. The ResetButtons calls all the children and does a QueueFree on them. Then calls the add20() function again, effectively repopulating the HBoxContainer with 20 new ButtonScene Instances.

4. However when the add20() function calls the _getFirstChild() function it still references the non-existant ID: 1216 button to set the currentButton. This also happens if i call GetChild(0) instead of  _getFirstChild().

And so when I click a button after this point I get an exception.

Minimal reproduction project
FreeChildrenAndSignalBug.zip

Does it work if you dispose the object? See https://github.com/godotengine/godot/issues/41543.

Well I added the Dispose call (not sure if this is how it's done), and the exception is gone. However it still references button 1216 after resetting and I get this weird error in the Editor Debugger:

What seems to be happening here is currentButton is set to a freed button, this happens when the _onResetButton_pressed() method is executed because you free the buttons but then in the add20() method you assign the first child of the container to currentButton. At this point, the buttons have been queued to be freed but haven't been freed yet.
If you remove the button from the container when freeing them you won't iterate over them in the add20() method:
public void _on_ResetButton_pressed()
{
	currentButton = null;
	foreach (Node _n in buttonContainer.GetChildren())
	{
		buttonContainer.RemoveChild(_n);
		_n.QueueFree();
	}
	add20();
}

Alternatively, you can check if the button is queued for deletion when you iterate over them in the _getFirstChild(Node _parent) method:
private Button _getFirstChild(Node _parent)
{
	foreach (Button _n in _parent.GetChildren())
	{
		if (IsInstanceValid(_n) && !_n.IsQueuedForDeletion())
		{
			return _n;
		}
	}
	return null;
}

What seems to be happening here is currentButton is set to a freed button, this happens when the _onResetButton_pressed() method is executed because you free the buttons but then in the add20() method you assign the first child of the container to currentButton. At this point, the buttons have been queued to be freed but haven't been freed yet.
If you remove the button from the container when freeing them you won't iterate over them in the add20() method:
public void _on_ResetButton_pressed()
{
	currentButton = null;
	foreach (Node _n in buttonContainer.GetChildren())
	{
		buttonContainer.RemoveChild(_n);
		_n.QueueFree();
	}
	add20();
}

Alternatively, you can check if the button is queued for deletion when you iterate over them in the _getFirstChild(Node _parent) method:
private Button _getFirstChild(Node _parent)
{
	foreach (Button _n in _parent.GetChildren())
	{
		if (IsInstanceValid(_n) && !_n.IsQueuedForDeletion())
		{
			return _n;
		}
	}
	return null;
}

Can confirm, both solutions work. Thanks so much :).
I guess it did turn out to be me doing something wrong :P


feat: error for parameter without schema or content

Purpose:

OAS3 schema requires that either a schema or a content object must be defined for any parameter. Tooling based on OAS3 will expect parameters to have a schema or content.

Changes:

Add check that a schema is provided in content objects for parameters.
Check that schema or content object provided for all parameters.

Test:

Add test to ensure that error returned for parameter with no schema and no content objects.
Add test to ensure a warning given for a content object in a parameter with no schema object.

Docs:

Document the parameter-contains-schema rule.

:tada: This PR is included in version 0.43.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Care Link creds

I recently changed my carelink password so I could upload it to tidepool but I keep getting carelink creds error

CareLink no longer supports export of CSV files, so use of CareLink with the Tidepool Uploader is no longer supported.


Upgrade Hopper Disassembler to <IP_ADDRESS>

http://www.hopperapp.com/

Thank you for the contribution. It was merged directly as 7bb16f2b436b4b18491d455b1b764e1c3c4b4029 to keep commit history cleaner. Your contribution is still credited to you.


fix: the timer should not be running early.

This PR fixes the error of timer running early.
When calculating steps, discard the part of self.real_time that exceeds the resolution, so that the calculation of steps will not count extra points that have not yet expired.
Fix: FTI-5996

The fix for this PR now is to add 1 step for the once type timer, so that when inserting the timer, it can move one more slot to ensure that the timer will not run early.


Deprecate string return in Directory::getFiles()

Reduce the complication of the Directory getfiles method by removing the support for returning string arrays. This means the returnStrings parameter will be removed and the method will only return a file iterator.

When string arrays are needed a call to iterator_to_array would be helpful.


Make Redis::Objects.connection thread-safe

This change ensures that using Redis::Objects.connection is thread-safe, which will allow users to set this dynamically in threaded environments, like Puma or Sidekiq.
We need this at ConvertKit because we're in the middle of a migration from Heroku RedisLabs to our own hand-rolled Redis in EC2, and we're doing this per-user.  This requires us to set the connection on a per-request basis, and my change will make this thread-safe.
Note that servers like Puma re-use threads, so in its current form, it will require the user to clear Redis::Objects.connection at the end of a request to avoid unwanted surprises.

Doesn't this mean that users who used to be assigning to Objects.redis running multithreaded will have to assign Objects.redis for every running thread in advance now or risk all other threads falling back to the $redis || Redis.current defaults or see an error being raised? If true, that seems like quite a breaking change to me... Would love to hear your thoughts.

any recommended way to set Redis::Objects.redis with Ruby on Rails and puma?

Does this change indeed break compatibility?  If so I will revert it. I thought it was backwards compatible.

looking at this again, I think @ronkorving is correct.    If you're not setting Redis::Objects.redis per request, then this would cause the behavior that @aka47 has seen.
This needs to be reverted and re-thought.

This threaded connection commit was reverted and I just pushed v1.4.3 to rubygems.  Thanks all.


Add loose files as solution items

Makes them available in find operations.
This adds three files to the playground folder, and one to the Solution Items folder.
Microsoft Reviewers: Open in CodeFlow

I wish VS would act more like VS Code here...

Install this: https://marketplace.visualstudio.com/items?itemName=MadsKristensen.WorkflowBrowser ;-) -- it's closer. Solution Explorer but then also "repo view" node effectively


Question

Hi,
Thank you for your very interesting work.
I have a question, I would appreciate it if you could advise me.
Could you please explain how you end up the spherical Bessel functions in  charge distribution in Fourier space?
Because in refs you have put the spherical Bessel functions of zero order just was used, and another approximated function which is x(cosh(x)-sinh(x))/x^3.
Could you please tell me a ref for those you used?
Thank you so much

Hi,
Thank you for the interest in my work.
I will assume you are talking about the next reference:
https://pubs.aip.org/aip/jcp/article/144/5/054902/194476/Effective-electrostatic-interactions-among-charged
In order to get the z distribution in Fourier space, you need to plug the bare charge distribution (eq 21) into the Fourier transform definition in eq 2. You should arrive to the following expression:
z_i(k) = q_i * [ F(R_i k) R_i^3 - F(S_i k) S_i^3 ] / [ R_i^3 - S_i^3 ],   i = index of each ion species
where, F(x) = 3[ sin(x) - xcos(x)]/x^3. Then, notice that F(x) = j_2(x) + j_0(x). The only reason to put F in terms of the bessel functions in the code is that they take into account the proper behavior of F when x -> 0.
The above is for the bare density charge distributions. When working with renormalized charges, at some point you have to evaluate z_i in a complex pole x = ieta, which takes you to the hyperbolic functions you wrote down: F(iy) = y(cosh(y)-sinh(y))/y^3. Yet, the code stays at a finer level, the three-component species level.
You may find helpful the simplified description in the model system section of the next reference:
https://pubs.rsc.org/en/content/articlelanding/2020/sm/d0sm00486c
Let me know if you have any further questions.


Build(deps-dev): Bump typescript from 4.9.5 to 5.0.2 (#4725)

Pull request opened by the merge tool on behalf of #4725

Merged in 46497bbe705d39d680eb0e937a724049d1db99eb


Repleace abandoned packages

Q
A

Issue Type
Feature Request

Deployer Version
4.x

Local Machine OS
N/A

Remote Machine OS
N/A

Description
Please replace abandoned packages:
Package herrera-io/version is abandoned, you should avoid using it. No replacement was suggested.
Package herrera-io/json is abandoned, you should avoid using it. Use kherge/json instead.
Package herrera-io/phar-update is abandoned, you should avoid using it. No replacement was suggested.

Steps to reproduce
Install Deployer 4.1.0 with Composer
Content of deploy.php
N/A
Output log
$ composer require "deployer/deployer":"~4.1" --dev
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 35 installs, 0 updates, 0 removals
  - Installing symfony/yaml (v3.2.2) Downloading: 100%
  - Installing symfony/process (v3.2.2) Downloading: 100%
  - Installing symfony/finder (v3.2.2) Downloading: 100%
  - Installing psr/log (1.0.2) Loading from cache
  - Installing symfony/debug (v3.2.2) Downloading: 100%
  - Installing symfony/polyfill-mbstring (v1.3.0) Loading from cache
  - Installing symfony/console (v3.2.2) Downloading: 100%
  - Installing pimple/pimple (v3.0.2) Downloading: 100%
  - Installing phpseclib/phpseclib (2.0.4) Downloading: 100%
  - Installing monolog/monolog (1.22.0) Loading from cache
  - Installing psr/cache (1.0.1) Downloading: 100%
  - Installing symfony/cache (v3.2.2) Downloading: 100%
  - Installing symfony/expression-language (v3.2.2) Downloading: 100%
  - Installing evenement/evenement (v2.0.0) Downloading: 100%
  - Installing react/stream (v0.4.5) Downloading: 100%
  - Installing react/promise (v2.5.0) Downloading: 100%
  - Installing react/event-loop (v0.4.2) Downloading: 100%
  - Installing react/socket (v0.4.5) Downloading: 100%
  - Installing react/cache (v0.4.1) Downloading: 100%
  - Installing react/dns (v0.4.3) Downloading: 100%
  - Installing react/socket-client (v0.4.6) Downloading: 100%
  - Installing psr/http-message (1.0.1) Loading from cache
  - Installing guzzlehttp/psr7 (1.3.1) Loading from cache
  - Installing react/http (v0.4.2) Downloading: 100%
  - Installing react/http-client (v0.4.15) Downloading: 100%
  - Installing react/child-process (v0.4.1) Downloading: 100%
  - Installing react/react (v0.4.2) Downloading: 100%
  - Installing elfet/pure (v2.0.0) Downloading: 100%
  - Installing herrera-io/version (1.1.1) Downloading: 100%
  - Installing seld/jsonlint (1.5.0) Downloading: 100%
  - Installing justinrainbow/json-schema (1.6.1) Downloading: 100%
  - Installing herrera-io/json (1.0.3) Downloading: 100%
  - Installing herrera-io/phar-update (2.0.0) Downloading: 100%
  - Installing deployer/phar-update (v1.0.0) Downloading: 100%
  - Installing deployer/deployer (v4.1.0) Downloading: 100%
symfony/console suggests installing symfony/event-dispatcher ()
symfony/console suggests installing symfony/filesystem ()
phpseclib/phpseclib suggests installing ext-libsodium (SSH2/SFTP can make use of some algorithms provided by the libsodium-php extension.)
monolog/monolog suggests installing aws/aws-sdk-php (Allow sending log messages to AWS services like DynamoDB)
monolog/monolog suggests installing doctrine/couchdb (Allow sending log messages to a CouchDB server)
monolog/monolog suggests installing ext-amqp (Allow sending log messages to an AMQP server (1.0+ required))
monolog/monolog suggests installing ext-mongo (Allow sending log messages to a MongoDB server)
monolog/monolog suggests installing graylog2/gelf-php (Allow sending log messages to a GrayLog2 server)
monolog/monolog suggests installing mongodb/mongodb (Allow sending log messages to a MongoDB server via PHP Driver)
monolog/monolog suggests installing php-amqplib/php-amqplib (Allow sending log messages to an AMQP server using php-amqplib)
monolog/monolog suggests installing php-console/php-console (Allow sending log messages to Google Chrome)
monolog/monolog suggests installing rollbar/rollbar (Allow sending log messages to Rollbar)
monolog/monolog suggests installing ruflin/elastica (Allow sending log messages to an Elastic Search server)
monolog/monolog suggests installing sentry/sentry (Allow sending log messages to a Sentry server)
symfony/cache suggests installing symfony/polyfill-apcu (For using ApcuAdapter on HHVM)
react/event-loop suggests installing ext-libevent (>=0.1.0)
react/event-loop suggests installing ext-event (~1.0)
react/event-loop suggests installing ext-libev (*)
react/react suggests installing ext-libevent (Allows for use of a more performant event-loop implementation.)
react/react suggests installing ext-libev (Allows for use of a more performant event-loop implementation.)
react/react suggests installing ext-event (Allows for use of a more performant event-loop implementation.)
deployer/deployer suggests installing herzult/php-ssh (For SSH support through native SSH2 extension)
Package herrera-io/version is abandoned, you should avoid using it. No replacement was suggested.
Package herrera-io/json is abandoned, you should avoid using it. Use kherge/json instead.
Package herrera-io/phar-update is abandoned, you should avoid using it. No replacement was suggested.
Writing lock file
Generating autoload files

Yes, it will be cool to replace then. There is deployer/phar-update.

Done, move them to deployer/phar-update.


Navigator: Do not change target position if user is only changing alt

This is important for multicopters for drift-free altitude changes and important for fixed wing to keep the current loiter center.
@dagar needs cross-testing to make sure the triplet update does not make the fixed wing leave the loiter circle.

@dagar can you check?


Generate load combinations from load groups

Can we make it possible to utilise the load combinator in FEM-Design to allow users to generate load combinations by their defined load cases and load groups?
This will essentially translate into some sort of .fdscript command.

@andosca Have this been raised on FogBugz?

No


Add more social networks

Now is posible to add your facebook and twitter account but it would be interesting to add also this social networks:

Instagram
Pinterest
linkedin
Google+
youtube

I'll take a look at this and see how this integrate into the system.
Maybe what we need is something like a split plugin, with a core SocialWidget and many SocialPlugin, one for each social network.
Does this make sense? /ping @elcodi/owners

Well, I think it make sense to have all of them in one Bundle... I mean, is just the same but with differents providers. Just my opinion :)

Closing this. All this stuff will be properly created in plugins.
Thanks :)


Update "No transactions" and "Not connected" states in transaction history

See designs on figma for "no transactions" and for "not connected"

Closed by #524


feat: add parameter to empty sidebar on mobile

Fix #274 #275

Add sidebar.emptyMobile in site.Params
Set it to false in the example site
Add the a condition in the sidebar layout
If the parameter is not set or false, the sidebar is shown

I check on the example site, work as expected

@imfing is it still ongoing or should I close ?


gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR

Operating system and version:

Linux i3 4.4.0-66-generic #87-Ubuntu SMP Fri Mar 3 15:29:05 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

nvm debug output:

nvm --version: v0.32.0
$SHELL: /bin/bash
$HOME: /home/mrm
$NVM_DIR: '$HOME/.nvm'
$PREFIX: ''
$NPM_CONFIG_PREFIX: ''
nvm current: v7.7.1
which node: $NVM_DIR/versions/node/v7.7.1/bin/node
which iojs:
which npm: $NVM_DIR/versions/node/v7.7.1/bin/npm
npm config get prefix: $NVM_DIR/versions/node/v7.7.1
npm root -g: $NVM_DIR/versions/node/v7.7.1/lib/node_modules

nvm ls output:

$ nvm ls
        v5.12.0
         v6.2.2
         v6.5.0
         v6.8.0
         v7.6.0
->       v7.7.1
default -> node (-> v7.7.1)
node -> stable (-> v7.7.1) (default)
stable -> 7.7 (-> v7.7.1) (default)
iojs -> N/A (default)
lts/* -> lts/argon (-> N/A)
lts/argon -> v4.8.0 (-> N/A)
lts/boron -> v6.10.0 (-> N/A)

How did you install nvm?
install script in readme

What steps did you perform?
Building native npm dependencies

What happened?

gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR

What did you expect to happen?
No warnings

Is there anything in any of your profile files (.bashrc, .bash_profile, .zshrc, etc) that modifies the PATH?
Yes, but that's irrelevant here.

¿por qué no los dos?
I don't know how many other systems look at these variables, so the safest (and most-chicken^H^H^H^H^H^Hconservative) solution would be to set both MIRROR values with and without the NPM prefix. The following, added to my ~/.bashrc after the call to source nvm.sh, removes the node-gyp warning:
export NODEJS_ORG_MIRROR=${NODEJS_ORG_MIRROR-$NVM_NODEJS_ORG_MIRROR}
export IOJS_ORG_MIRROR=${IOJS_ORG_MIRROR-$NVM_IOJS_ORG_MIRROR}

FWIW, I didn't have to unset NVM_NODEJS_ORG_MIRROR.  Having both set seems harmless.

Sure, having both set is harmless, and nvm will indeed always set $NVM_NODEJS_ORG_MIRROR for you.
node-gyp is the only software I'm aware of that incorrectly depended on nvm's env vars - it no longer does, hence the warning.
Are you suggesting that nvm add support for $NODEJS_ORG_MIRROR as well? I'm a bit hesitant to add more env var complexity, and to shackle nvm's internal configuration to something other tools depend on (which is why I recommended node-gyp migrate to a separate env var in the first place).

OK. In that case, perhaps the workaround should be:
unset NVM_IOJS_ORG_MIRROR NVM_NODEJS_ORG_MIRROR

I don't know how clever you want to make nvm.sh, but perhaps if node-gyp is a recent-enough version, it could avoid setting the variable in the first place?

I guess a totally reasonable alternative would be, making nvm no longer create these env vars unconditionally - ie, use them if present, fall back to the defaults if not. That should avoid the node-gyp warning in the most scenarios, while also reducing the env var pollution from nvm?

defaults, fwiw, are super easy, and cross-shell-compatible. You'd just delete this:

# Setup mirror location if not already set
if [ -z "${NVM_NODEJS_ORG_MIRROR-}" ]; then
  export NVM_NODEJS_ORG_MIRROR="https://nodejs.org/dist"
fi

if [ -z "${NVM_IOJS_ORG_MIRROR-}" ]; then
  export NVM_IOJS_ORG_MIRROR="https://iojs.org/dist"
fi

and update nvm_get_mirror with the default URLs:

nvm_get_mirror() {
  case "${1}-${2}" in
    node-std) nvm_echo "${NVM_NODEJS_ORG_MIRROR:-https://nodejs.org/dist}" ;;
    iojs-std) nvm_echo "${NVM_IOJS_ORG_MIRROR:-https://iojs.org/dist}" ;;
    *)
      nvm_err 'unknown type of node.js or io.js release'
      return 1
    ;;
  esac
}

Thanks, that's totally reasonable, and just what I had in mind :-) Want to submit a PR (with unit test)? :-D


[VS Code] [Audio] Request startOrJoinCall failed unexpectedly without providing any details.

Error:
Request startOrJoinCall failed unexpectedly without providing any details.
Steps to Reproduce:

Be on corporate VPN
Join a Live Share session in which a teammate has already started an audio call
See notification pop up from the lower-right corner asking to join an audio call. There was an option to Always join as well but I just clicked the join one.
See this

Version Data

extensionName
VSLS-Audio

extensionVersion
0.1.80

applicationName
VSCode

applicationVersion
1.43.2

platformName
MacOS

platformVersion
18.7.0

2020-03-30_1622_PDT_live_share_audi_issues.zip

Thanks for reaching out. Can you try the steps described here? https://github.com/MicrosoftDocs/live-share/issues/2996#issuecomment-591005520

Hey, we are tracking the issue in #2996 . So I am closing this as duplicate . Please join the conversation in #2996 if above solution doesn't work for you.


Avoid stack overflow due to temp struct used in method stack

The returned std::tm within method call use(…) is temporary to method
call frame and gone during execution of statment. Furthermore it may
have really overwritten by actions done in scope of statement execution.
It would insert under circumstances corrupted times!

closes #657

@hrabe Thank you very much!


trilium-desktop: add darwin support

Description of changes

Added darwin support for trilium-desktop by downloading the .zip archive from GitHub.
Split trilium-server and trilium-desktop in two different files in order to avoid confusion when adding the darwin support (which is only for trilium-desktop).

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@FliegendeWurst , would you kindly have a look at this PR? I've left in draft because I haven't tested yet if I broke the Linux build, but I wanted to check with you whether you're OK with the refactoring.

Overall, the changes look good to me. I don't have a Mac to test the new package. I have a few suggestions:
* you can add yourself as a maintainer (given that you did a few updates and are adding darwing support now)

* `meta` information is now duplicated, it would be nice to combine these somehow

@FliegendeWurst , sounds good. I've done the requested changes and added myself as maintainer.

@FliegendeWurst , I've solved the merge conflicts. Could you please review?

@ofborg build trilium-desktop trilium-desktop.passthru.tests


Peer-to-peer code review

in index.html file, if you use the nav-btn class instead of nav-bar it will be clear because nav-bar class most of the time is used for the navbar section in general which includes logo buttons etc.

I think it's much better to use the anchor tag "a" link tag instead of buttons on your CSS and RUBY buttons and it's much better you use semantic HTML5 elements instead of using a lot of div tags.


Performance regression

AFAIR there was a regression with the compilation refactoring and the usage of ISeekable in this PR but I was able to mitigate it.
Nonetheless, there seem to be a significant regression, even on Raw benchmark which don't involve the Fluent API and Parser objects.
Parlot 0.0.19
BenchmarkDotNet v0.13.10, Windows 11 (10.0.22631.3155/23H2/2023Update/SunValley3)
12th Gen Intel Core i7-1260P, 1 CPU, 16 logical and 12 physical cores
.NET SDK 8.0.200
  [Host]   : .NET 8.0.2 (<IP_ADDRESS>11), X64 RyuJIT AVX2
  ShortRun : .NET 8.0.2 (<IP_ADDRESS>11), X64 RyuJIT AVX2

Job=ShortRun  IterationCount=3  LaunchCount=1
WarmupCount=3

| Method              | Mean        | Error       | StdDev    | Ratio | RatioSD | Gen0   | Allocated | Alloc Ratio |
|-------------------- |------------:|------------:|----------:|------:|--------:|-------:|----------:|------------:|
| ParlotRawSmall      |    176.1 ns |    41.63 ns |   2.28 ns |  0.60 |    0.00 | 0.0322 |     304 B |        0.46 |
| ParlotCompiledSmall |    292.4 ns |    43.69 ns |   2.39 ns |  1.00 |    0.00 | 0.0696 |     656 B |        1.00 |
| ParlotFluentSmall   |    360.3 ns |    44.18 ns |   2.42 ns |  1.23 |    0.01 | 0.0696 |     656 B |        1.00 |
| PidginSmall         |  5,237.3 ns | 2,162.97 ns | 118.56 ns | 17.91 |    0.33 | 0.0839 |     832 B |        1.27 |
|                     |             |             |           |       |         |        |           |             |
| ParlotRawBig        |    846.2 ns |   106.47 ns |   5.84 ns |  0.55 |    0.00 | 0.1268 |    1200 B |        0.42 |
| ParlotCompiledBig   |  1,551.9 ns |   274.97 ns |  15.07 ns |  1.00 |    0.00 | 0.3052 |    2888 B |        1.00 |
| ParlotFluentBig     |  1,921.7 ns |   116.32 ns |   6.38 ns |  1.24 |    0.01 | 0.3052 |    2888 B |        1.00 |
| PidginBig           | 26,802.7 ns | 6,253.70 ns | 342.79 ns | 17.27 |    0.09 | 0.4272 |    4152 B |        1.44 |

Parlot 1.0.2
BenchmarkDotNet v0.14.0, Windows 11 (10.0.22631.3880/23H2/2023Update/SunValley3)
12th Gen Intel Core i7-1260P, 1 CPU, 16 logical and 12 physical cores
.NET SDK 9.0.100-rc.1.24406.16
  [Host]   : .NET 8.0.7 (8.0.724.31311), X64 RyuJIT AVX2
  ShortRun : .NET 8.0.7 (8.0.724.31311), X64 RyuJIT AVX2

Job=ShortRun  IterationCount=3  LaunchCount=1
WarmupCount=3

| Method              | Mean        | Error       | StdDev    | Ratio | RatioSD | Gen0   | Allocated | Alloc Ratio |
|-------------------- |------------:|------------:|----------:|------:|--------:|-------:|----------:|------------:|
| ParlotRawSmall      |    203.2 ns |   106.15 ns |   5.82 ns |  0.44 |    0.01 | 0.0322 |     304 B |        0.44 |
| ParlotCompiledSmall |    460.2 ns |   161.17 ns |   8.83 ns |  1.00 |    0.02 | 0.0730 |     688 B |        1.00 |
| ParlotFluentSmall   |    457.8 ns |    46.47 ns |   2.55 ns |  1.00 |    0.02 | 0.0730 |     688 B |        1.00 |
| PidginSmall         |  5,344.7 ns |   640.95 ns |  35.13 ns | 11.62 |    0.21 | 0.0839 |     832 B |        1.21 |
|                     |             |             |           |       |         |        |           |             |
| ParlotRawBig        |  1,072.5 ns |   665.56 ns |  36.48 ns |  0.41 |    0.02 | 0.1259 |    1200 B |        0.39 |
| ParlotCompiledBig   |  2,647.2 ns | 1,591.34 ns |  87.23 ns |  1.00 |    0.04 | 0.3242 |    3080 B |        1.00 |
| ParlotFluentBig     |  2,365.0 ns |   256.98 ns |  14.09 ns |  0.89 |    0.03 | 0.3242 |    3080 B |        1.00 |
| PidginBig           | 28,341.4 ns | 9,588.06 ns | 525.55 ns | 10.71 |    0.36 | 0.4272 |    4152 B |        1.35 |

Actually, it's just a nanoseconds, so, it's not a significant regression. If the code with a new codebase is more readable and supportable I'd say leave it as is

Well nanoseconds can matter if it's a large percentual difference 😉 Might be worth to test both branches with latest benchmarkdotnet and maybe without ShortRun and let benchmarkdotnet choose the testing plan (iterations).

ParlotRawSmall
176.10
203.20
15.39%

ParlotCompiledSmall
292.40
460.20
57.39%

ParlotFluentSmall
360.30
457.80
27.06%

PidginSmall
5237.30
5344.70
2.05%

ParlotRawBig
846.20
1072.50
26.74%

ParlotCompiledBig
1551.90
2647.20
70.58%

ParlotFluentBig
1921.70
2365.00
23.07%

PidginBig
26802.70
28341.40
5.74%

EDIT: the SDKs and and runtimes are also different so a lot of moving parts...

I agree, knew that, but I put Pidgin here as a baseline.

I agree, knew that, but I put Pidgin here as a baseline.

But you are right still, there will always be a doubt if not on par. Will re-run to remove this variable.

Ran it on fixed machine dedicated for benchmarking with a more recent processor
BenchmarkDotNet v0.14.0, Debian GNU/Linux 12 (bookworm) (container)
Intel Xeon E-2336 CPU 2.90GHz, 1 CPU, 12 logical and 6 physical cores
.NET SDK 8.0.303
  [Host]   : .NET 8.0.7 (8.0.724.31311), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI
  ShortRun : .NET 8.0.7 (8.0.724.31311), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI

Job=ShortRun  IterationCount=3  LaunchCount=1
WarmupCount=3

v0.0.19
| Method              | Mean        | Error       | StdDev   | Ratio | RatioSD | Gen 0  | Allocated |
|---------------------|-------------|-------------|----------|-------|---------|--------|-----------|
| ParlotRawSmall      | 307.0 ns    | 10.22 ns    | 0.56 ns  | 0.64  | 0       | 0.0496 | 312 B     |
| ParlotCompiledSmall | 478.3 ns    | 19.30 ns    | 1.06 ns  | 1     | 0       | 0.1049 | 664 B     |
| ParlotFluentSmall   | 740.9 ns    | 23.99 ns    | 1.32 ns  | 1.55  | 0       | 0.1049 | 664 B     |
| PidginSmall         | 6,348.5 ns  | 90.53 ns    | 4.96 ns  | 13.27 | 0.02    | 0.1297 | 832 B     |
|                     |             |             |          |       |         |        |           |
| ParlotRawBig        | 1,537.0 ns  | 13.75 ns    | 0.75 ns  | 0.61  | 0       | 0.1907 | 1,208 B   |
| ParlotCompiledBig   | 2,523.9 ns  | 72.36 ns    | 3.97 ns  | 1     | 0       | 0.4616 | 2,896 B   |
| ParlotFluentBig     | 3,920.6 ns  | 79.62 ns    | 4.36 ns  | 1.55  | 0       | 0.4578 | 2,896 B   |
| PidginBig           | 33,119.1 ns | 1,360.48 ns | 74.57 ns | 13.12 | 0.04    | 0.6104 | 4,152 B   |

**v0.0.28**

Method
Mean
Error
StdDev
Ratio
RatioSD
Gen0
Allocated

ParlotRawSmall
243.5 ns
10.67 ns
0.59 ns
0.45
0
0.0482
304 B

ParlotCompiledSmall
540.9 ns
13.64 ns
0.75 ns
1
0
0.1097
688 B

ParlotFluentSmall
628.0 ns
11.64 ns
0.64 ns
1.16
0
0.1097
688 B

PidginSmall
6,270.0 ns
397.08 ns
21.77 ns
11.59
0.04
0.1297
832 B

ParlotRawBig
1,246.2 ns
16.64 ns
0.91 ns
0.41
0
0.1907
1200 B

ParlotCompiledBig
3,064.1 ns
179.58 ns
9.84 ns
1
0
0.4883
3080 B

ParlotFluentBig
3,455.3 ns
95.81 ns
5.25 ns
1.13
0
0.4883
3080 B

PidginBig
31,858.2 ns
3,055.18 ns
167.46 ns
10.4
0.06
0.6104
4152 B

**v1.0.2**

Method
Mean
Error
StdDev
Ratio
RatioSD
Gen0
Allocated

ParlotRawSmall
242.8 ns
8.15 ns
0.45 ns
0.44
0
0.0482
304 B

ParlotCompiledSmall
554.5 ns
10.47 ns
0.57 ns
1
0
0.1097
688 B

ParlotFluentSmall
627.6 ns
20.55 ns
1.13 ns
1.13
0
0.1097
688 B

PidginSmall
6,373.3 ns
140.06 ns
7.68 ns
11.49
0.02
0.1297
832 B

ParlotRawBig
1,263.2 ns
32.10 ns
1.76 ns
0.4
0
0.1907
1200 B

ParlotCompiledBig
3,147.8 ns
61.67 ns
3.38 ns
1
0
0.4883
3080 B

ParlotFluentBig
3,434.4 ns
81.82 ns
4.48 ns
1.09
0
0.4883
3080 B

PidginBig
32,396.1 ns
289.55 ns
15.87 ns
10.29
0.01
0.6104
4152 B

What surprises me is that the allocations are the same. But the output rightly showed the different BenchmarkDotNet versions (13.1, 13.2 and 14.0) so I am confident the correct branches were benchmarked.

If you want me to run other specific forks/branches feel free to point them to me.

Note for myself:

crank --config C:\temp\parlot.yml --profile aspnet-perf-lin --scenario ExprBench --json parlot.v0.0.28.json --application.source.branchOrCommit v0.0.28

Am I reading this correctly, no actual performance regression?

@lahma this is what I am reading too.


Fix usage of type_cast in preparation of rails 4.2.0 upgrade

Coverage decreased (-0.48%) to 90.89% when pulling dd12624016567cfeb5a2886f9720ef8935b23f23 on fix_type_cast_for_rails_4_2_0 into 6d327f326d1622adb623e3bbf92d623e50bd2d5e on master.


Creation of ES index fails if first mapping contains a map

Version <IP_ADDRESS> Assume 2 Tables are given:
CREATE TABLE devices (
id uuid,
configuration map < text, text >,
PRIMARY KEY (id)
);

CREATE TABLE audit (
id uuid,
action text,
nano_since_epoch bigint,
username text,
PRIMARY KEY (id)
);

Insert some values into the devices table, where the map is NOT empty.
Indexing in this order will work:

{
  "settings": {
    "keyspace":"KEYSPACE_PLACEHOLDER",
    "number_of_replicas" : 1
  },
  "mappings": {
    "audit" : {
      "discover":"^(?!message).*"
    },
    "devices" : {
      "discover":"^(?!message).*"
    }
}

Indexing in this order will fail:
{
  "settings": {
    "keyspace":"KEYSPACE_PLACEHOLDER",
    "number_of_replicas" : 1
  },
  "mappings": {
    "devices" : {
      "discover":"^(?!message).*"
    },
    "audit" : {
      "discover":"^(?!message).*"
    }
}

Hi,
You reported in your last message an error when inserting document while your initial issue was related to discover the mapping.
In order to reproduce your issues, please reports error message and logs for the mapping issue (initial error), and information to reproduce the second error message (the mapping and the insert statement).
Thanks.

Hi Vincent,
the issue did not reoccur. It looks like it is related to the ES indices
being created to fast each after other.
When I create the indices each with an own request the issue does not occur.
Alex
Am Mi., 13. Feb. 2019 um 10:03 Uhr schrieb Alex Tbk<EMAIL_ADDRESS>
Hi Vincent,
the issue did not reoccur. It looks like it is related to the ES indices
being created to fast each after other.
When I create the indices each with an own request the issue does not
occur.
Alex
Am Mi., 13. Feb. 2019 um 09:38 Uhr schrieb Vincent Royer <
<EMAIL_ADDRESS>
Hi,
You reported in your last message an error when inserting document while
your initial issue was related to discover the mapping.
In order to reproduce your issues, please reports error message and logs
for the mapping issue (initial error), and information to reproduce the
second error message (the mapping and the insert statement).
Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/strapdata/elassandra/issues/249#issuecomment-463107892,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABwCe2BBfYgn3ItqcOWlZKVwDOCQcP42ks5vM87rgaJpZM4ZZsud
.

Hi,
I have to reopen this, as I encountered exactly the same issue with ES6 (elassandra <IP_ADDRESS>).
When adding ES index for this table:
CREATE TABLE devices (
    id uuid,
    comm_nr text,
    configuration map<text,text>,
    customer text,
    description text,
    groups list<text>,
    last_active timeuuid,
    last_active_nanoseconds bigint,
    location uuid,
    notes text,
    picture text,
    status text,
    tag text,
    thumbnail text,
    "type" text,
    "users" list<text>,
    PRIMARY KEY (id)
)

It fails. In system.log I see:
2019-03-26 21:58:43,974 INFO  [elasticsearch[<IP_ADDRESS>][generic][T#4]] CassandraShardStateListener.java:59 afterIndexShardStarted shard [devices][0] started 2019-03-26 21:58:43,975 INFO  [elasticsearch[<IP_ADDRESS>][generic][T#4]] ElasticSecondaryIndex.java:2545 startRebuildIfNeeded start building secondary iot_data.devices.elastic_devices_idx 2019-03-26 21:58:44,002 INFO  [elasticsearch[<IP_ADDRESS>][generic][T#4]] SecondaryIndexManager.java:571 buildIndexesBlocking Submitting index build of elastic_devices_idx for data in BigTableReader(path='/var/lib/cassandra/data/iot_data/devices-c4a249f04ff611e9ba438dba5fe3507f/mc-1-big-Data.db') 2019-03-26 21:58:44,010 INFO  [CompactionExecutor:74] ElasticSecondaryIndex.java:490 addField updating mapping={"devices":{"properties":{"configuration":{"type":"nested","cql_struct":"map","cql_collection":"singleton","properties":{"size":{"type":"keyword"}}}}}} 2019-03-26 21:58:44,046 INFO  [elasticsearch[<IP_ADDRESS>][masterService#updateTask][T#1]] CassandraDiscovery.java:920 publish CQL SchemaChanges=[UPDATED TABLE iot_data.devices, UPDATED TABLE elastic_admin.metadata] 2019-03-26 21:59:14,041 INFO  [elasticsearch[<IP_ADDRESS>][masterService#updateTask][T#1]] CassandraDiscovery.java:964 publish commit state [6d18bf5c-32df-4815-bf06-e565cc71ac9b/7] timeout with pending nodes=[{<IP_ADDRESS>}{6d18bf5c-32df-4815-bf06-e565cc71ac9b}{6d18bf5c-32df-4815-bf06-e565cc71ac9b}{<IP_ADDRESS>}{<IP_ADDRESS>:9300}{ALIVE}{rack=rack1, dc=datacenter-prod-1}] 2019-03-26 21:59:14,042 WARN  [elasticsearch[<IP_ADDRESS>][masterService#updateTask][T#1]] MasterService.java:583 warnAboutSlowTaskIfNeeded cluster state update task [put-mapping[devices]] took [30s] above the warn threshold of 30s 2019-03-26 21:59:14,042 ERROR [CompactionExecutor:74] ElasticSecondaryIndex.java:499 addField error while updating mapping org.elasticsearch.ElasticsearchTimeoutException: blocking update timeout         at org.elasticsearch.cluster.service.ClusterService$BlockingActionListener.waitForUpdate(ClusterService.java:640)         at org.elasticsearch.cluster.service.ClusterService.blockingMappingUpdate(ClusterService.java:689)         at org.elassandra.index.ElasticSecondaryIndex.addField(ElasticSecondaryIndex.java:492)         at org.elassandra.index.ElasticSecondaryIndex$ImmutableMappingInfo$RowcumentIndexer$Rowcument.buildContext(ElasticSecondaryIndex.java:2192)         at org.elassandra.index.ElasticSecondaryIndex$ImmutableMappingInfo$SkinnyRowcumentIndexer$SkinnyRowcument.buildContext(ElasticSecondaryIndex.java:1738)         at org.elassandra.index.ElasticSecondaryIndex$ImmutableMappingInfo$RowcumentIndexer$Rowcument.index(ElasticSecondaryIndex.java:2285)         at org.elassandra.index.ElasticSecondaryIndex$ImmutableMappingInfo$RowcumentIndexer$Rowcument.index(ElasticSecondaryIndex.java:2262)         at org.elassandra.index.ElasticSecondaryIndex$ImmutableMappingInfo$SkinnyRowcumentIndexer$SkinnyRowcument.index(ElasticSecondaryIndex.java:1738)         at org.elassandra.index.ElasticSecondaryIndex$ImmutableMappingInfo$RowcumentIndexer$Rowcument.write(ElasticSecondaryIndex.java:2245)         at org.elassandra.index.ElasticSecondaryIndex$ImmutableMappingInfo$SkinnyRowcumentIndexer$SkinnyRowcument.write(ElasticSecondaryIndex.java:1738)         at org.elassandra.index.ElasticSecondaryIndex$ImmutableMappingInfo$SkinnyRowcumentIndexer.update(ElasticSecondaryIndex.java:1779)         at org.elassandra.index.ElasticSecondaryIndex$ImmutableMappingInfo$RowcumentIndexer.finish(ElasticSecondaryIndex.java:1962)         at java.lang.Iterable.forEach(Iterable.java:75)         at org.apache.cassandra.index.SecondaryIndexManager.indexPartition(SecondaryIndexManager.java:1067)         at org.apache.cassandra.index.internal.CollatedViewIndexBuilder.build(CollatedViewIndexBuilder.java:139)         at org.apache.cassandra.db.compaction.CompactionManager$14.run(CompactionManager.java:1637)         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)         at java.util.concurrent.FutureTask.run(FutureTask.java:266)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:81)         at java.lang.Thread.run(Thread.java:748) 2019-03-26 21:59:14,043 ERROR [CompactionExecutor:74] ElasticSecondaryIndex.java:516 addField submapper not found for nested field [size] in index [devices] 2019-03-26 21:59:14,044 INFO  [CompactionExecutor:74] ElasticSecondaryIndex.java:490 addField updating mapping={"devices":{"properties":{"configuration":{"type":"nested","cql_struct":"map","cql_collection":"singleton","properties":{"pressure":{"type":"keyword"}}}}}} 2019-03-26 21:59:14,086 INFO  [elasticsearch[<IP_ADDRESS>][masterService#updateTask][T#1]] CassandraDiscovery.java:920 publish CQL SchemaChanges=[UPDATED TABLE iot_data.devices, UPDATED TABLE elastic_admin.metadata] 2019-03-26 21:59:44,045 ERROR [CompactionExecutor:74] ElasticSecondaryIndex.java:499 addField error while updating mapping org.elasticsearch.ElasticsearchTimeoutException: blocking update timeout
This error continues then. From the logs I see that it complains about the "configuration" field of my device entity. Here is an example of an real entry for this field:
{'datasource' : 'api', 'external_id' : '003011FADB4A', 'first_active_on' : '01-03-2019', 'pressure' : '12S', 'size' : '35'}
When I add the mapping with "configuration" column ignored, there are no errors.
Please help

Hi,
Yes, there is an issue when creating the index with a populated map.
Currently, the workaround is to create your index without indexing the map (the configuration field in your case) to initialize the index. Then update the mapping to index the map field, and if needed, rebuild the index to get the map field content indexed. Alternatively, you create your index with an explicit mapping of all map keys (datasource, external_id, first_active_on, pressure, size in your case).
To create your index without mapping the field configuration:
curl -XPUT -H 'Content-Type: application/json' https://localhost:9200/toto -d'{"mappings":{"devices":{"discover":"^((?!configuration).*)"}}}'
Index should be green at this step, then to update mapping to add the configuration field:
curl -XPUT -H 'Content-Type: application/json' https://localhost:9200/toto/_mapping/devices -d'{"discover":".*"}'
Then on every nodes, run the following command to rebuild the index:
nodetool rebuild_index  devices elastic_devices_idx
Thank's for reporting this issue.

Hi Vincent,
could you tell me, if this has been resolved in current releases?
Thanks!
Alex

Hi Alex,
According to my tests, it good in version <IP_ADDRESS>
Let me know if it works in your use case.
Thanks.

Hi Vincent,
I am testing this with <IP_ADDRESS>, the reported issue seems to be resolved.
Anyways I am getting an other error when I try to insert an entry:
{
  "it-alarms" : {
    "aliases" : { },
    "mappings" : {
      "alarms" : {
        "properties" : {
          "acknowledged" : {
            "type" : "boolean",
            "cql_collection" : "singleton"
          },
          "description" : {
            "type" : "keyword",
            "cql_collection" : "singleton"
          },
          "device_comm_nr" : {
            "type" : "keyword",
            "cql_collection" : "singleton"
          },
          "device_id" : {
            "type" : "keyword",
            "cql_collection" : "singleton"
          },
          "groups" : {
            "type" : "keyword"
          },
          "id" : {
            "type" : "keyword",
            "cql_collection" : "singleton",
            "cql_partition_key" : true,
            "cql_primary_key_order" : 0
          },
          "level" : {
            "type" : "keyword",
            "cql_collection" : "singleton"
          },
          "nano_since_epoch" : {
            "type" : "long",
            "cql_collection" : "singleton"
          },
          "source_description" : {
            "type" : "keyword",
            "cql_collection" : "singleton"
          },
          "source_id" : {
            "type" : "keyword",
            "cql_collection" : "singleton"
          },
          "source_type" : {
            "type" : "keyword",
            "cql_collection" : "singleton"
          },
          "threshold_max" : {
            "type" : "double",
            "cql_collection" : "singleton"
          },
          "threshold_min" : {
            "type" : "double",
            "cql_collection" : "singleton"
          },
          "users" : {
            "type" : "keyword"
          },
          "value" : {
            "type" : "double",
            "cql_collection" : "singleton"
          }
        }
      }
    },
    "settings" : {
      "index" : {
        "keyspace" : "testkeyspace",
        "number_of_shards" : "1",
        "provided_name" : "it-alarms",
        "creation_date" : "1558965933641",
        "number_of_replicas" : "0",
        "uuid" : "JOSnbbnSTruYSlWWrH6nkQ",
        "version" : {
          "created" : "6020399"
        }
      }
    }
  }
}

The error I get:

2019-05-27 16:05:43,635 ERROR [MutationStage-4] ElasticSecondaryIndex.java:2246 write Unexpected error
java.lang.NullPointerException: null
at org.elasticsearch.index.mapper.UidFieldMapper.createField(UidFieldMapper.java:236)
at org.elassandra.index.ElasticSecondaryIndex$ImmutableMappingInfo$RowcumentIndexer$Rowcument.buildContext(ElasticSecondaryIndex.java:2169)
at org.elassandra.index.ElasticSecondaryIndex$ImmutableMappingInfo$SkinnyRowcumentIndexer$SkinnyRowcument.buildContext(ElasticSecondaryIndex.java:1730)
at org.elassandra.index.ElasticSecondaryIndex$ImmutableMappingInfo$RowcumentIndexer$Rowcument.index(ElasticSecondaryIndex.java:2287)
at org.elassandra.index.ElasticSecondaryIndex$ImmutableMappingInfo$RowcumentIndexer$Rowcument.index(ElasticSecondaryIndex.java:2258)
at org.elassandra.index.ElasticSecondaryIndex$ImmutableMappingInfo$SkinnyRowcumentIndexer$SkinnyRowcument.index(ElasticSecondaryIndex.java:1730)
at org.elassandra.index.ElasticSecondaryIndex$ImmutableMappingInfo$RowcumentIndexer$Rowcument.write(ElasticSecondaryIndex.java:2241)
at org.elassandra.index.ElasticSecondaryIndex$ImmutableMappingInfo$SkinnyRowcumentIndexer$SkinnyRowcument.write(ElasticSecondaryIndex.java:1730)
at org.elassandra.index.ElasticSecondaryIndex$ImmutableMappingInfo$SkinnyRowcumentIndexer.update(ElasticSecondaryIndex.java:1771)
at org.elassandra.index.ElasticSecondaryIndex$ImmutableMappingInfo$RowcumentIndexer.finish(ElasticSecondaryIndex.java:1955)
at org.apache.cassandra.index.SecondaryIndexManager$WriteTimeTransaction.commit(SecondaryIndexManager.java:1432)
at org.apache.cassandra.db.partitions.AtomicBTreePartition.addAllWithSizeDelta(AtomicBTreePartition.java:181)
at org.apache.cassandra.db.Memtable.put(Memtable.java:282)
at org.apache.cassandra.db.ColumnFamilyStore.apply(ColumnFamilyStore.java:1359)
at org.apache.cassandra.db.Keyspace.applyInternal(Keyspace.java:631)
at org.apache.cassandra.db.Keyspace.apply(Keyspace.java:475)
at org.apache.cassandra.db.Mutation.apply(Mutation.java:227)
at org.apache.cassandra.db.Mutation.apply(Mutation.java:232)
at org.apache.cassandra.db.Mutation.apply(Mutation.java:241)
at org.apache.cassandra.service.StorageProxy$8.runMayThrow(StorageProxy.java:1398)
at org.apache.cassandra.service.StorageProxy$LocalMutationRunnable.run(StorageProxy.java:2637)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:162)
at org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$LocalSessionFutureTask.run(AbstractLocalAwareExecutorService.java:134)
at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:114)
at java.lang.Thread.run(Thread.java:748)

I am inserting an empty entry, which contains only the id.

Hi,
after some more testing I can confirm, that the bug is still not fixed.
Prepopulated maps are not being indexed correctly and break.
Please please fix this
Best regards

The original bug is fixed, you get here another issue because your index was probably created with version 5.x (with multiple types per index). As elasticsearch 6.x, Elassandra only supports single type index, and Uid is only indexed in multiple types index (index < 6.0).
The next version if fixed to avoid NPE, but we do not support hot ES index upgrade, because you can smoothly upgrade with multiple Cassandra datacenters...

Hi,
I did not migrate the index.
I recreated the empty tables and copied the Cassandra directory contents.
The elastic directory was deleted.
Then I created the index and received the errors.
Alex
Vincent Royer<EMAIL_ADDRESS>schrieb am Sa., 1. Juni 2019,
16:48:

The original bug is fixed, you get here another issue because your index
was probably created with version 5.x (with multiple types per index). As
elasticsearch 6.x, Elassandra only supports single type index, and Uid is
only indexed in multiple types index (index < 6.0).
The next version if fixed to avoid NPE, but we do not support hot ES index
upgrade, because you can smoothly upgrade with multiple Cassandra
datacenters...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/strapdata/elassandra/issues/249?email_source=notifications&email_token=AAOAE66HR7GKQLRSMJCSSTDPYKD4XA5CNFSM4GLGZOO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWXCBIA#issuecomment-497950880,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOAE6523XH43XCABLGQTMLPYKD4XANCNFSM4GLGZOOQ
.

Deleting the elastic directory does not delete your index settings where index version is recorded.
I don't really know how your recreate your index, but the error (NPE in UidFieldMapper.java:236) cannot happen with ES 6.x index. We need more details about this issue to explain or solve it.
Thanks.

Hi Vincent,
thank you for your reply.
Would you describe me, how you would update an existing cluster from
elassandra 5 to 6?
Thank you!
Am Mi., 26. Juni 2019 um 01:33 Uhr schrieb Vincent Royer <
<EMAIL_ADDRESS>
Deleting the elastic directory does not delete your index settings where
index version is recorded.
I don't really know how your recreate your index, but the error (NPE in
UidFieldMapper.java:236) cannot happen with ES 6.x index. We need more
details about this issue to explain or solve it.
Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/strapdata/elassandra/issues/249?email_source=notifications&email_token=AAOAE642S2M73A2RVIBGQZTP4KTNPA5CNFSM4GLGZOO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYR4HOA#issuecomment-505660344,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOAE65KXO3VX2EOEJ7VTLDP4KTNPANCNFSM4GLGZOOQ
.

1.Delete all you ES indices
2.Restart all nodes with Elasticsearch disbaled (mainclass=CassandraDaemon in /etc/default/cassandra)
3.Drop the elastic_admin keyspace
4. Check /var/lib/cassandra/elasticsearch.data is empty
5.Upgrade the elassandra binary from 5.x to <IP_ADDRESS> on all nodes
6.Restart all nodes with Elasticsearch enabled (mainclass=ElassandraDaemon in /etc/default/cassandra)
7.Recreate your ES indices with a new mapping for ES 6.x

For me this issue is still there with <IP_ADDRESS>
Steps to reproduce:

Fresh install without any data.
Import data containing Map<String,String>
Start 3 nodes in total
change replication factor to 3
nodetool repair on node2 + node3
observe mapping errors in the logs

Note that this only occured as 3 nodes were started.
We have stopped using maps inside entities --> errors gone

Could you attach you mapping, your CQL schema and the logs containing errors. Could also provide the exact nodetool repair command you ran after changing the RF from 1 (i guess) to 3. Thanks.

Error:
2019-08-13 07:09:35,988 WARN  [elasticsearch[<IP_ADDRESS>][masterService#updateTask][T#1]] MasterService.java:282 runTasks failed to publish updated cluster state in [5s]: version [27], uuid [ASEADRK9SS-mPIOA6JLizg], source [put-mapping[devices]] cluster uuid: ae912935-612b-4ae6-ae2e-0c81126923cc version: 27 state uuid: ASEADRK9SS-mPIOA6JLizg from_diff: false meta data version: 75    [audit/XK9AXfrkRlmeGSQmSfRw7Q]: v[3]       0: p_term [0], isa_ids []    [it-derived_value_configuration_by_device/X6GGxLK2Rp60H43AlRi-Hw]: v[3]       0: p_term [0], isa_ids []    [alarms/jS5RrPqyRpKGJwKrWY5LJg]: v[3]       0: p_term [0], isa_ids []    [alarm_configurations/9nj0t0XXQCyrPeWloP1Drw]: v[3]       0: p_term [0], isa_ids []    [it-alarm_configurations/jGOV_Z4ISpaRqXMFj4u7WA]: v[3]       0: p_term [0], isa_ids []    [users/QFkU0VTmR_S2iWkWj6Jw4w]: v[3]       0: p_term [0], isa_ids []    [derived_value_configuration_by_device/R6hzV_DDSSWTxq_8XFi3bg]: v[4]       0: p_term [0], isa_ids []         at org.elasticsearch.cluster.service.TaskBatcher$BatchedTask.run(TaskBatcher.java:188)         at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:573)         at org.elasticsearch.common.util.concurrent.PrioritizedEsThreadPoolExecutor$TieBreakingPrioritizedRunnable.runAndClean(PrioritizedEsThreadPoolExecutor.java:244)         at org.elasticsearch.common.util.concurrent.PrioritizedEsThreadPoolExecutor$TieBreakingPrioritizedRunnable.run(PrioritizedEsThreadPoolExecutor.java:207)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:748) Caused by: org.apache.cassandra.exceptions.WriteTimeoutException: Operation timed out - received only 0 responses.         at org.apache.cassandra.service.paxos.AbstractPaxosCallback.await(AbstractPaxosCallback.java:64)         at org.apache.cassandra.service.StorageProxy.preparePaxos(StorageProxy.java:489)         at org.apache.cassandra.service.StorageProxy.beginAndRepairPaxos(StorageProxy.java:402)         at org.apache.cassandra.service.StorageProxy.cas(StorageProxy.java:237)         at org.apache.cassandra.cql3.statements.ModificationStatement.executeWithCondition(ModificationStatement.java:449)         at org.apache.cassandra.cql3.statements.ModificationStatement.execute(ModificationStatement.java:424)         at org.apache.cassandra.cql3.QueryProcessor.processStatement(QueryProcessor.java:225)         at org.apache.cassandra.cql3.QueryProcessor.process(QueryProcessor.java:256)         at org.apache.cassandra.cql3.QueryProcessor.process(QueryProcessor.java:241)         at org.elasticsearch.cluster.service.ClusterService.process(ClusterService.java:536)         at org.elasticsearch.cluster.service.ClusterService.processWriteConditional(ClusterService.java:548)         at org.elasticsearch.cluster.service.ClusterService.commitMetaData(ClusterService.java:1264)         at org.elassandra.discovery.CassandraDiscovery.publishAsCoordinator(CassandraDiscovery.java:1002)         ... 11 common frames omitted 2019-08-13 07:09:25,919 ERROR [MutationStage-32] ElasticSecondaryIndex.java:508 addField submapper not found for nested field [failedPacketsSinceStart] in index [devices]
(this continues with other tables containing maps, which are indexed in elastic as well).
failedPacketsSinceStart is a key inside the map in the devices table.
Devices Schema:
CREATE TABLE devices (     id uuid,     children list<uuid>,     comm_nr text,     configuration map<text,text>,     create_date_nanoseconds bigint,     customer text,     description text,     groups list<text>,     last_active text,     last_active_nanoseconds bigint,     location uuid,     notes text,     parent uuid,     picture text,     status text,     tag text,     thumbnail text,     "type" text,     "users" list<text>,     PRIMARY KEY (id) )
Repair command:
nodetool repair

Hi Alex,
Before increasing the RF, your ES mapping should include all keys of your map as fields (all keys are indexed on at least one node). Then, all nodes should share the same ES mapping stored in the CQL schema, and repairs should not involve any mapping update.
I can can’t figure out which step is wrong, so could you check which condition is not met in your use case ?
Thanks,
Vincent Royer
http://www.strapdata.com
Mobile: +33 7 83 18 25 40

Le 13 août 2019 à 17:02, Alex Tabaksmann<EMAIL_ADDRESS>a écrit :
Error:
2019-08-13 07:09:35,988 WARN [elasticsearch[<IP_ADDRESS>][masterService#updateTask][T#1]] MasterService.java:282 runTasks failed to publish updated cluster state in [5s]: version [27], uuid [ASEADRK9SS-mPIOA6JLizg], source [put-mapping[devices]] cluster uuid: ae912935-612b-4ae6-ae2e-0c81126923cc version: 27 state uuid: ASEADRK9SS-mPIOA6JLizg from_diff: false meta data version: 75 [audit/XK9AXfrkRlmeGSQmSfRw7Q]: v[3] 0: p_term [0], isa_ids [] [it-derived_value_configuration_by_device/X6GGxLK2Rp60H43AlRi-Hw]: v[3] 0: p_term [0], isa_ids [] [alarms/jS5RrPqyRpKGJwKrWY5LJg]: v[3] 0: p_term [0], isa_ids [] [alarm_configurations/9nj0t0XXQCyrPeWloP1Drw]: v[3] 0: p_term [0], isa_ids [] [it-alarm_configurations/jGOV_Z4ISpaRqXMFj4u7WA]: v[3] 0: p_term [0], isa_ids [] [users/QFkU0VTmR_S2iWkWj6Jw4w]: v[3] 0: p_term [0], isa_ids [] [derived_value_configuration_by_device/R6hzV_DDSSWTxq_8XFi3bg]: v[4] 0: p_term [0], isa_ids [] at org.elasticsearch.cluster.service.TaskBatcher$BatchedTask.run(TaskBatcher.java:188) at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:573) at org.elasticsearch.common.util.concurrent.PrioritizedEsThreadPoolExecutor$TieBreakingPrioritizedRunnable.runAndClean(PrioritizedEsThreadPoolExecutor.java:244) at org.elasticsearch.common.util.concurrent.PrioritizedEsThreadPoolExecutor$TieBreakingPrioritizedRunnable.run(PrioritizedEsThreadPoolExecutor.java:207) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) Caused by: org.apache.cassandra.exceptions.WriteTimeoutException: Operation timed out - received only 0 responses. at org.apache.cassandra.service.paxos.AbstractPaxosCallback.await(AbstractPaxosCallback.java:64) at org.apache.cassandra.service.StorageProxy.preparePaxos(StorageProxy.java:489) at org.apache.cassandra.service.StorageProxy.beginAndRepairPaxos(StorageProxy.java:402) at org.apache.cassandra.service.StorageProxy.cas(StorageProxy.java:237) at org.apache.cassandra.cql3.statements.ModificationStatement.executeWithCondition(ModificationStatement.java:449) at org.apache.cassandra.cql3.statements.ModificationStatement.execute(ModificationStatement.java:424) at org.apache.cassandra.cql3.QueryProcessor.processStatement(QueryProcessor.java:225) at org.apache.cassandra.cql3.QueryProcessor.process(QueryProcessor.java:256) at org.apache.cassandra.cql3.QueryProcessor.process(QueryProcessor.java:241) at org.elasticsearch.cluster.service.ClusterService.process(ClusterService.java:536) at org.elasticsearch.cluster.service.ClusterService.processWriteConditional(ClusterService.java:548) at org.elasticsearch.cluster.service.ClusterService.commitMetaData(ClusterService.java:1264) at org.elassandra.discovery.CassandraDiscovery.publishAsCoordinator(CassandraDiscovery.java:1002) ... 11 common frames omitted 2019-08-13 07:09:25,919 ERROR [MutationStage-32] ElasticSecondaryIndex.java:508 addField submapper not found for nested field [failedPacketsSinceStart] in index [devices]
(this continues with other tables containing maps, which are indexed in elastic as well).
failedPacketsSinceStart is a key inside the map in the devices table.
Devices Schema:
CREATE TABLE devices ( id uuid, children list, comm_nr text, configuration map<text,text>, create_date_nanoseconds bigint, customer text, description text, groups list, last_active text, last_active_nanoseconds bigint, location uuid, notes text, parent uuid, picture text, status text, tag text, thumbnail text, "type" text, "users" list, PRIMARY KEY (id) )
Repair command:
nodetool repair
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi Vincent,
i hope I dont mix things up. What happened is that our <IP_ADDRESS> cluster crashed with almost the same error but without an repair. In this state its impossible to delete the elastic index so you are kinda doomed.
I started a 1 node cluster, imported 2 tables - both of them are small (<100) entries.
Then I started a second node. Changed RF=2. nodetool repair on node 2.
Then 3rd node with the same procedure and the errors came. It might be a coincidence but these errors are there.
The data was imported via the COPY command from .csv files, if that is important. I can even provide you the .csv data if it helps.
Thanks for looking into that
Alex

Hi Alex,
Thanks for this clarification. How and when did you created your Es
Vincent Royer
http://www.strapdata.com
Mobile: +33 7 83 18 25 40

Le 13 août 2019 à 23:34, Alex Tabaksmann<EMAIL_ADDRESS>a écrit :
Hi Vincent,
i hope I dont mix things up. What happened is that our <IP_ADDRESS> cluster crashed with almost the same error but without an repair. In this state its impossible to delete the elastic index so you are kinda doomed.
I started a 1 node cluster, imported 2 tables - both of them are small (<100) entries.
Then I started a second node. Changed RF=2. nodetool repair on node 2.
Then 3rd node with the same procedure and the errors came. It might be a coincidence but these errors are there.
The data was imported via the COPY command from .csv files, if that is important. I can even provide you the .csv data if it helps.
Thanks for looking into that
Alex
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi Vincent,
i first imported the data. Then i created the index with:
{   "settings" : { "keyspace" : "iot_data" },   "mappings" : {     "devices" : {       "discover":"^(?!message).*"     }   } }
cas_contention_timeout_in_ms  - is the default value not 1000 already?
Alex

Any news here?

bump

The default cas_contention_timeout_in_ms is 5000, but you should check your conf/cassandra.yaml file.
Release <IP_ADDRESS>  new way to index map, with opaque_map, there is no more Elasticsearch mapping update (and no more PAXOS timeout). If you don't need to discover indexed fields through the elasticsearch mapping, this is probably a nice solution in your case. See documentation for details.

Thank you!
Do i understand it right, that opaque_map is fully searchable?
So searching with:
curl -XGET  -H 'Content-Type: application/json' "http://localhost:9200/twitter/_search?pretty=true" -d '{
"query":{
    "nested":{
            "path":"attrs",
            "query":{ "term": {"attrs.city":"paris" } }
             }
        }
}

will be possible?

Yes is fully searchable, you just need to know what are your field names (or key entries in the underlying cassandra map), as it is not more visible in the elasticsearch mapping.
In the next release <IP_ADDRESS> (next week), aggregation on opaque_map keys will be supported too.

Sounds awesome!

Is there a specific update procedure to <IP_ADDRESS> when no maps are inside of any index?

I can confirm this is fixed


Run a job until a certain time [until]

I see on this GitHub that there is an until function within the code but, I cannot utilize it. I currently have the most up to date version of schedule but it will not work regardless of how I format the time within the 'until( )'. Can you please advise? I have attached a snippet of the traceback below:
Traceback (most recent call last):
schedule.every(5).minutes.until("18:30").do(run_threaded, )
AttributeError: 'Job' object has no attribute 'until'

This is because no release has happened since the until was added. Thanks for reminding me that I should make a new release. Will do so somewhere this weekend.

Just wanted to follow up and see if there was an update on the release

See #455 :)

Thank you very much


Update overlay to add older ceph inventories to the hosts group

This change allows environments with minimal ceph-ansible inventories to
be pulled into the standard 'hosts' group for deploying agents and
host specific checks.
Signed-off-by: Nathan Pawelek<EMAIL_ADDRESS>

Thank you for submitting a pull request to this project!
Once all check jobs have passed and the pull request has received a
sufficient number of reviews, the repository's gate jobs can be triggered by
adding a comment of :shipit: to this pull request.
When the gate jobs have completed successfully, this pull request will get
merged automatically.


[@thumbtack/thumbprint-atomic] Reconsider negative margin classes

The -ma# classes seem unused and could likely be removed. Also look into adding -mh# classes instead.

@tomgenoni It's still unused in website (regex: -ma\d). Want to remove?

Yeah, if they haven't been used yet prob good to remove. I'll make a task to do this.


tuw_msgs: 0.0.13-0 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository tuw_msgs to 0.0.13-0:

upstream repository: https://github.com/tuw-robotics/tuw_msgs.git
release repository: https://github.com/tuw-robotics/tuw_msgs-release.git
distro file: melodic/distribution.yaml
bloom version: 0.6.8
previous version for package: 0.0.11-0

Holding for sync


app breaks with certain external modules

Current Behavior
This is with tsdx watch.
Importing libraries such as remark-prism or react-syntax-highlighter breaks the app. I don't see anything in the console. All I see is a white screen. If I delay the import (remove it from being a top level import), make it a require inside application logic and try to console log it, it breaks after that. The react root disappears (guessing this is what happens when React breaks) but tsdx is unable to show me the react errors that pop?
Expected behavior
These plugins / libraries work with a normal React project / CRA installation.
Suggested solution(s)
Something with imports / ESM modules maybe?
No clue what's happening. Would love to provide additional information when I know where to look.
Additional context
I'm not running anything special. Ultimately, I'd be using these with react-markdown, but these imports break the app outside, before I can get them inside react-markdown. This is probably irrelevant.
Your environment
  System:
    OS: Linux 5.8 Ubuntu 20.04.2 LTS (Focal Fossa)
    CPU: (8) x64 Intel(R) Core(TM) i5-9300H CPU @ 2.40GHz
    Memory: 3.90 GB / 15.49 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 14.15.1 - ~/.nvm/versions/node/v14.15.1/bin/node
    Yarn: 1.22.10 - /usr/bin/yarn
    npm: 6.14.8 - ~/.nvm/versions/node/v14.15.1/bin/npm
  Browsers:
    Chrome: 90.0.4430.93
    Firefox: 88.0.1
  npmPackages:
    tsdx: ^0.14.1 => 0.14.1
    typescript: ^4.1.2 => 4.2.4
  npmGlobalPackages:
    typescript: 4.1.2

This has something to do with how parcel bundles and one of react-syntax-highlighter's requires
https://github.com/swagger-api/swagger-ui/issues/6285
https://github.com/parcel-bundler/parcel/issues/3176


Update gradle check jenkins to add Azure and GCP account for OpenSearch repository tests

Description
Today, Opensearch engine mocks external cloud providers for running repository-[azure/gcp] integration tests. As part of this issue, we need to add creds for azure/gcp accounts so that engine can run integration tests against these cloud providers.
    Whaddya think, @peterzhuamazon?

Hi @dreamer-89,
Can you let us know exactly what credentials you want to add?
Can you also confirm the accounts have been created already?
Thanks!

Hi @dreamer-89, Can you let us know exactly what credentials you want to add? I assume we will need this to be added to jenkins environment for the gradle check to pick it up? Can you also confirm the accounts have been created already?
Thanks!

Hi @gaiksaya,
Thanks for getting back on this. I need to export access key/secret keys for Azure & GCP accounts we recently created. Yes, these needs to be added to jenkins environment.
The accounts are already created for Azure, GCP. Right now, I need to do a quick verify that exporting creds let gradle check job run integration tests against these external cloud. I will update once I do that, post that we can proceed with adding creds on jenkins script.

@dreamer-89 Whats the status of this issue?

@dreamer-89 Whats the status of this issue?

@bbarani : Thanks for checking on this. This needs a quick POC on our end to verify integration tests uses external Azure/GCP end-points for repository tests. This work is still pending. I will surface this in the team meeting to get prioritization on this task. Once this is completed we can update the jenkins job.

Closing this issue for as stale. Please feel free to re-open or create new one once work is done from OpenSearch's end.
Thanks!


Kafka Service - Not able to run in Debug Mode

Description:
Trying to debug kafka service in IntelliJ & Composer but getting error.
Error:
Ballerina remote debugger is activated on port : 55091
could not find package wso2/kafka:*
ballerina: initiating service(s) in 'dropShipPeopleSoftPOService.bal'
Exception in thread "Thread-4" java.net.BindException: Address already in use: bind
at sun.nio.ch.Net.bind0(Native Method)
at sun.nio.ch.Net.bind(Unknown Source)
at sun.nio.ch.Net.bind(Unknown Source)
at sun.nio.ch.ServerSocketChannelImpl.bind(Unknown Source)
at io.netty.channel.socket.nio.NioServerSocketChannel.doBind(NioServerSocketChannel.java:128)
at io.netty.channel.AbstractChannel$AbstractUnsafe.bind(AbstractChannel.java:558)
at io.netty.channel.DefaultChannelPipeline$HeadContext.bind(DefaultChannelPipeline.java:1283)
at io.netty.channel.AbstractChannelHandlerContext.invokeBind(AbstractChannelHandlerContext.java:501)
at io.netty.channel.AbstractChannelHandlerContext.bind(AbstractChannelHandlerContext.java:486)
at io.netty.channel.DefaultChannelPipeline.bind(DefaultChannelPipeline.java:989)
at io.netty.channel.AbstractChannel.bind(AbstractChannel.java:254)
at io.netty.bootstrap.AbstractBootstrap$2.run(AbstractBootstrap.java:364)
at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163)
at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:463)
at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:886)
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.lang.Thread.run(Unknown Source)
Don't confuse with this error  could not find package wso2/kafka:*. Kafka is perfectly working fine in normal Run Mode but not able to run in Debug mode.
Steps to reproduce:
executing the .bal kafka service file into intellij in Debug mode.
Affected Versions:
OS, DB, other environment details and versions:
intellij / Windows 7
Related Issues (optional):

Suggested Labels (optional):
intelliJ / Composer Debugger

Suggested Assignees (optional):

attaching few screenshots for reference.

Can reproduce in the vscode debugger as well. This is not related just to composer. Seems to be a bug in the debug server.

@Anshulrathi current kafka version is compatible with ballerina v0.980.0 hence we are upgrading the kafka version to be compatible with the latest ballerina version and we'll fix the issue as soon as the new version is released

Ballerina debugger is re-written and this issue is now resolved. Closing the issue.


Custom color as primary in theme fails

Thanks for the great package.
When designating a custom color as the primaryColor in the theme of the MantineProvider (v0.14.3), the application throws an error: Cannot read properties of undefined (reading 'startsWith')
Minimal example:
from dash import Dash
from dash_mantine_components import Button, MantineProvider

theme = {
    "colors": {
        "gold": [
            [
                "#E8DBBD",
                "#DDCBA2",
                "#D2BB8B",
                "#C7AD76",
                "#BCA064",
                "#B29454",
                "#A2874C",
                "#947A42",
                "#876F3A",
                "#7B6432",
                "#705B2C",
                "#675226",
                "#5E4B21"
            ]
        ]
    },
    "primaryColor": "gold"
}

if __name__ == "__main__":
    app = Dash(__name__, title="My app")
    app.layout = MantineProvider(Button(), theme=theme)
    app.run_server(debug=True)

I could've checked that myself. It's straight from the documentation though, so I'll rename the ticket to get that correct ;)
Thanks for the support!


[Feature]: change reactjs to "choose a framework" in webd page make a separate page for that just like we have a separate page for javascript

Is your feature request related to a problem? Please describe.

in choose a framework you can give introduction about different frontend frameworks like angular,reactjs,svelte and any other of your choice and resources for them also
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response

if it is possible for a single person to have more than one task assigned, then I would like to take this up as well

@HarjjotSinghh no bro we want more and more people to contribute so one issue at a time

I would like to work on this

@pawas108ram assigned


Move onlydole to emeritus for SIG Docs Tech Lead

I am stepping down from my SIG Docs Technical Lead role to make room for new contributors and maintainers. Thank you ALL for a wonderful experience, and I promise not to go TOO far 😄

Thank you so much Taylor for chatting with myself, Divya, and Rey about our next steps for mentoring new people into leadership roles in our SIG, and for being open to making room for that plan. We're very appreciative of all you've done for SIG Docs! Congratulations on making it to emeritus 🙌
/approve


HBASE-28055 Performance improvement for scan over several stores.

No new UT is required. The one for HBASE-19863 works just fine with the problem.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 50s
master passed

+1 :green_heart:
compile
2m 28s
master passed

+1 :green_heart:
checkstyle
0m 36s
master passed

+1 :green_heart:
spotless
0m 41s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 28s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 33s
the patch passed

+1 :green_heart:
compile
2m 22s
the patch passed

+1 :green_heart:
javac
2m 22s
the patch passed

-0 :warning:
checkstyle
0m 34s
hbase-server: The patch generated 2 new + 7 unchanged - 0 fixed = 9 total (was 7)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
8m 59s
Patch does not cause any errors with Hadoop 3.2.4 3.3.5.

-1 :x:
spotless
0m 36s
patch has 32 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
1m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

31m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5379/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5379

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux f50b066f35d1 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 5527dd9453

Default Java
Eclipse Adoptium-11.0.17+8

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5379/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5379/1/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
77 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5379/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m  3s
master passed

+1 :green_heart:
compile
0m 45s
master passed

+1 :green_heart:
shadedjars
5m 12s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 45s
the patch passed

+1 :green_heart:
compile
0m 44s
the patch passed

+1 :green_heart:
javac
0m 44s
the patch passed

+1 :green_heart:
shadedjars
5m  5s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 22s
the patch passed

_ Other Tests _

-1 :x:
unit
213m 25s
hbase-server in the patch failed.

236m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5379/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5379

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c1a03d807c0e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 5527dd9453

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5379/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5379/1/testReport/

Max. process+thread count
4750 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5379/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Heya @taklwu @ss77892 this backport broke branch-2.5, maybe others. Please address and consider using PRs for all branch backports as well, just to get pre-commit checks. Thanks!

Heya @taklwu @ss77892 this backport broke branch-2.5, maybe others. Please address and consider using PRs for all branch backports as well, just to get pre-commit checks. Thanks!

Yes, I discovered that there is a compilation failure in branch-2 because PrivateConstants.java does not exist.

My bad , I will create PRs for backport next time


Integrate T TokenStaking with RandomBeacon

Refs: https://github.com/keep-network/keep-core/pull/2850
Closes: https://github.com/keep-network/keep-core/issues/2715
Depends on: https://github.com/keep-network/keep-core/pull/2906
This PR integrates Random Beacon with Threshold Network TokenStaking contract.
It implements functions to let the operator join the sortition pool and update its status in the sortition pool. StakingStub contract has been removed and all tests operate on a real T TokenStaking now.
The changes were already implemented in ECDSA Wallets in https://github.com/keep-network/keep-core/pull/2850 and this PR is based on it.
Operators To Staking Providers Mapping
Please note that due to 8e9b2a48227bc5830b3b508c9729403bb32ce250 a gas cost of executing functions that call seize and slash grew significantly:
        method            |   min   |   max   |   avg
-------------------------------------------------------
submitRelayEntry          | 213867  | 3693768 | 1760490
reportRelayEntryTimeout   | 3641465 | 3659466 | 3654018
reportUnauthorizedSigning |    -    |    -    | 3774342

The problem of slashing gas costs mentioned in the PR description is addressed in https://github.com/threshold-network/solidity-contracts/pull/87.


dmtcp: 2.5.1 -> 2.5.2

Semi-automatic update. These checks were performed:

built on NixOS
ran /nix/store/dpqcx4vr2nzam3c504xg5qc0rmmf1c4k-dmtcp-2.5.2/bin/dmtcp_discover_rm -h got 0 exit code
ran /nix/store/dpqcx4vr2nzam3c504xg5qc0rmmf1c4k-dmtcp-2.5.2/bin/dmtcp_discover_rm --help got 0 exit code
ran /nix/store/dpqcx4vr2nzam3c504xg5qc0rmmf1c4k-dmtcp-2.5.2/bin/dmtcp_discover_rm -V and found version 2.5.2
ran /nix/store/dpqcx4vr2nzam3c504xg5qc0rmmf1c4k-dmtcp-2.5.2/bin/dmtcp_discover_rm -v and found version 2.5.2
ran /nix/store/dpqcx4vr2nzam3c504xg5qc0rmmf1c4k-dmtcp-2.5.2/bin/dmtcp_discover_rm --version and found version 2.5.2
ran /nix/store/dpqcx4vr2nzam3c504xg5qc0rmmf1c4k-dmtcp-2.5.2/bin/dmtcp_discover_rm -h and found version 2.5.2
ran /nix/store/dpqcx4vr2nzam3c504xg5qc0rmmf1c4k-dmtcp-2.5.2/bin/dmtcp_discover_rm --help and found version 2.5.2
ran /nix/store/dpqcx4vr2nzam3c504xg5qc0rmmf1c4k-dmtcp-2.5.2/bin/dmtcp_rm_loclaunch -h got 0 exit code
ran /nix/store/dpqcx4vr2nzam3c504xg5qc0rmmf1c4k-dmtcp-2.5.2/bin/dmtcp_rm_loclaunch --help got 0 exit code
ran /nix/store/dpqcx4vr2nzam3c504xg5qc0rmmf1c4k-dmtcp-2.5.2/bin/dmtcp_rm_loclaunch help got 0 exit code
found 2.5.2 with grep in /nix/store/dpqcx4vr2nzam3c504xg5qc0rmmf1c4k-dmtcp-2.5.2
found 2.5.2 in filename of file in /nix/store/dpqcx4vr2nzam3c504xg5qc0rmmf1c4k-dmtcp-2.5.2

@GrahamcOfBorg build dmtcp

Failure on x86_64-darwin (full log)
Partial log (click to expand)
checking for gcl... no
checking for matlab... no
checking for matlab... no
checking linux/version.h usability... no
checking linux/version.h presence... no
checking for linux/version.h... no
configure: error: #include: <linux/version.h> not found: consider adding linux-libc-dev pkg

builder for '/nix/store/0ca2cr8sdmbxjswcwwd5bmm8fjjz7f9x-dmtcp-2.5.2.drv' failed with exit code 1
error: build of '/nix/store/0ca2cr8sdmbxjswcwwd5bmm8fjjz7f9x-dmtcp-2.5.2.drv' failed

Success on aarch64-linux (full log)
Partial log (click to expand)
shrinking /nix/store/wqfp61p8az1iagpmqfm2zq0cbl7ifgqh-dmtcp-2.5.2/bin/dmtcp_ssh
shrinking /nix/store/wqfp61p8az1iagpmqfm2zq0cbl7ifgqh-dmtcp-2.5.2/bin/mtcp_restart
cannot find section .dynamic
gzipping man pages under /nix/store/wqfp61p8az1iagpmqfm2zq0cbl7ifgqh-dmtcp-2.5.2/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/wqfp61p8az1iagpmqfm2zq0cbl7ifgqh-dmtcp-2.5.2/lib  /nix/store/wqfp61p8az1iagpmqfm2zq0cbl7ifgqh-dmtcp-2.5.2/bin
patching script interpreter paths in /nix/store/wqfp61p8az1iagpmqfm2zq0cbl7ifgqh-dmtcp-2.5.2
checking for references to /build in /nix/store/wqfp61p8az1iagpmqfm2zq0cbl7ifgqh-dmtcp-2.5.2...
cannot find section .dynamic
/nix/store/wqfp61p8az1iagpmqfm2zq0cbl7ifgqh-dmtcp-2.5.2

Success on x86_64-linux (full log)
Partial log (click to expand)
shrinking /nix/store/dpqcx4vr2nzam3c504xg5qc0rmmf1c4k-dmtcp-2.5.2/lib/dmtcp/libdmtcp_alloc.so
shrinking /nix/store/dpqcx4vr2nzam3c504xg5qc0rmmf1c4k-dmtcp-2.5.2/lib/dmtcp/libdmtcp_modify-env.so
shrinking /nix/store/dpqcx4vr2nzam3c504xg5qc0rmmf1c4k-dmtcp-2.5.2/lib/dmtcp/libdmtcp_pathvirt.so
gzipping man pages under /nix/store/dpqcx4vr2nzam3c504xg5qc0rmmf1c4k-dmtcp-2.5.2/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/dpqcx4vr2nzam3c504xg5qc0rmmf1c4k-dmtcp-2.5.2/lib  /nix/store/dpqcx4vr2nzam3c504xg5qc0rmmf1c4k-dmtcp-2.5.2/bin
patching script interpreter paths in /nix/store/dpqcx4vr2nzam3c504xg5qc0rmmf1c4k-dmtcp-2.5.2
checking for references to /tmp/nix-build-dmtcp-2.5.2.drv-0 in /nix/store/dpqcx4vr2nzam3c504xg5qc0rmmf1c4k-dmtcp-2.5.2...
cannot find section .dynamic
/nix/store/dpqcx4vr2nzam3c504xg5qc0rmmf1c4k-dmtcp-2.5.2


[AutoPR managedservices/resource-manager] typo: registraton -> registration

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5457

This PR has been merged into https://github.com/Azure/azure-sdk-for-go/pull/4370


How to get the GPS information of test/query_drone ?

Thank you very much for your work. I would like to know how to obtain GPS coordinates and other information of test/query_drone. I want to further know the drone images for research.

Hi @xingpingyeyu
Sorry for the late response.
You also can refer at https://github.com/layumi/University1652-Baseline#news


Legislation (dominos) Tracker + Related Data/Features

MVP
2 track (house + senate) converging with four steps - mimicking the Ohio graphic below.

introduced
in committee 1
in committee 2
Passed by floor
5 (for house/senate) - Signed by gov

Ohio: https://ohiohouse.gov/legislation/134/sb1
image
[another reference]
Maryland: https://mgaleg.maryland.gov/mgawebsite/Legislation/Details/SB0007?ys=2021RS
image

The frontend of the dominos tracker is complete and enabled in the dev site: https://maple-dev.vercel.app/bills/193/H502
A basic version of the backend is in there using simple rules. Closing this in favor of issues for specific enhancements


decoder support for register operands to compressed instructions

rvopcodesdecoder decodes reg operands and immediate values for all instructions. it does not do so for compressed instructions.
Here's an example of how the compressed instructions look post-decode:
{'instr': 17304, 'instr_name': 'c.lw', 'instr_addr':<PHONE_NUMBER>, 'rd': None, 'rs1': None, 'rs2': None, 'rs3': None, 'imm': None, 'zimm': None, 'csr': None, 'shamt': None, 'succ': None, 'pred': None, 'rl': None, 'aq': None, 'rm': None, 'reg_commit': ('x', '14', '0x000000000000000a'), 'csr_commit': None, 'mnemonic': None, 'is_rvp': False, 'rs1_nregs': 1, 'rs2_nregs': 1, 'rs3_nregs': 1, 'rd_nregs': 1}

here's the commit for that instruction (in my program, based on spike):
instr: 17304 addr: 0x80001068 instr_name: c.lw reg_commit: ('x', '14', '0x000000000000000a')

here's what is actually supposed to happen (example of lw):
{'instr': 67250179, 'instr_name': 'lw', 'instr_addr':<PHONE_NUMBER>, 'rd': (16, 'x'), 'rs1': (4, 'x'), 'rs2': None, 'rs3': None, 'imm': 64, 'zimm': None, 'csr': None, 'shamt': None, 'succ': None, 'pred': None, 'rl': None, 'aq': None, 'rm': None, 'reg_commit': ('x', '16', '0x0000000000000007'), 'csr_commit': None, 'mnemonic': None, 'is_rvp': False, 'rs1_nregs': 1, 'rs2_nregs': 1, 'rs3_nregs': 1, 'rd_nregs': 1}

isac's decoder currently does this (link):
            for arg in args[:-1]:
                if arg == 'rd':
                    treg = reg_type
                    if any([instr_name.startswith(x) for x in [
                            'fcvt.w','fcvt.l','fmv.s','fmv.d','flt','feq','fle','fclass']]):
                        treg = 'x'
                    temp_instrobj.rd = (int(get_arg_val(arg)(mcode), 2), treg)
                if arg == 'rs1':
                    treg = reg_type
                    if any([instr_name.startswith(x) for x in [
                            'fsw','fsd','fcvt.s','fcvt.d','fmv.w','fmv.l']]):
                        treg = 'x'
                    temp_instrobj.rs1 = (int(get_arg_val(arg)(mcode), 2), treg)
                if arg == 'rs2':
                    treg = reg_type
                    temp_instrobj.rs2 = (int(get_arg_val(arg)(mcode), 2), treg)
                if arg == 'rs3':

here's the actual list of variable fields from riscv-opcodes -- being looked up in the arg_lut:
c.lw :: ['rd_p', 'rs1_p', 'c_uimm7lo', 'c_uimm7hi', 'rv_c']

isac's decoder needs to be modified to take into account, these compressed field names, and decode them appropriately from here(link). here's an example code implementation (not compiled) for starters:
                 if 'rd' in arg:
                    treg = reg_type
                    if any([instr_name.startswith(x) for x in [
                            'fcvt.w','fcvt.l','fmv.s','fmv.d','flt','feq','fle','fclass']]):
                        treg = 'x'
                    temp_instrobj.rd = (int(get_arg_val(arg)(mcode), 2), treg)
                if 'rs1' in arg:
                    treg = reg_type
                    if any([instr_name.startswith(x) for x in [
                            'fsw','fsd','fcvt.s','fcvt.d','fmv.w','fmv.l']]):
                        treg = 'x'
                    temp_instrobj.rs1 = (int(get_arg_val(arg)(mcode), 2), treg)
                    # print(f'{instr_name} rs1: {temp_instrobj.rs1}')
                if 'rs2' in arg:
                    treg = reg_type
                    temp_instrobj.rs2 = (int(get_arg_val(arg)(mcode), 2), treg)

the change is in the if condition where i replaced the check for arg == 'rd' with 'rd' in arg.
this change reflects the correct register operand in the decoded artifacts:
{'instr': 17304, 'instr_name': 'c.lw', 'instr_addr':<PHONE_NUMBER>, 'rd': (6, 'x'), 'rs1': (7, 'x'), 'rs2': None, 'rs3': None, 'imm': None, 'zimm': None, 'csr': None, 'shamt': None, 'succ': None, 'pred': None, 'rl': None, 'aq': None, 'rm': None, 'reg_commit': ('x', '14', '0x000000000000000a'), 'csr_commit': None, 'mnemonic': None, 'is_rvp': False, 'rs1_nregs': 1, 'rs2_nregs': 1, 'rs3_nregs': 1, 'rd_nregs': 1}

immediates have not been fixed in this example.
there might be a minor quibble in the get_instr function in the same rvopcodesdecoder when it comes to compressed instructions. this will need to be checked as well.

The constant operand field names defined in link for compressed instructions have changed over time and the same has not been reflected in rvopcodesdecoder.py.
For example, c.lw instruction has arguments ['rd_p', 'rs1_p', 'c_uimm7lo', 'c_uimm7hi']. Now, we need to set rd_p as rd and rs1_p as rs1 in the instance of InstructionObject class. The immediate fields c_uimm7lo and c_uimm7hi should be combined together to form a single imm as specified by the instruction's encoding in the spec. We can go ahead with the potential fix mentioned above in the issue statement for rs1*, rs2* and rd*. For immediate fields, it would translate to adding/changing the following in the if-elsif-else ladder:
if arg == 'c_uimm7hi':
    imm_temp = get_arg_val(arg)(mcode)
    if imm:
        imm = imm[-1] + imm_temp + imm[0] + '00'
    else:
        imm = imm_temp + imm
if arg == 'c_uimm7lo':
    imm_temp = get_arg_val(arg)(mcode)
    if imm:
        imm = imm_temp[-1] + imm + imm_temp[0] + '00'
    else:
        imm = imm + imm_temp

Similar additions will be required for all other entries which are not present in this said if-elseif-else ladder.

Feel free to raise a PR after testing.

This issue was resolved in #73.


Remove MACOSX_RPATH forcing

With cmake 3.0.0, CMP0042 applies and the default value of MACOSX_RPATH is true, this block is not needed  anymore.
Setting this is a bad practice because in some cases one needs to disabled it.

@meshula, @kdt3rd can you confirm this makes sense?

Yes, it's no longer necessary to set that variable manually to ON, and us not setting it means that it won't override user's setting it themselves deliberately.


Scrolling in the /api documentation is messed up

Try using spacebar to scroll down in http://<IP_ADDRESS>:9991/api/integration-guide in Chrome on Linux, and it's really choppy and hardly moves.  I'm guessing somehow we have the settings configured wrong for perfectScrollbar, but could be something else.

@timabbott I have come across these jsfiddles, one and two. One is version 1.3.0 and seems to be scrolling properly, while the other is 0.6.10 (similar to zulip's 0.7.1) and has the scrolling issue, which makes me think the scrolling would be improved by a newer version. However, version 1.0.0 had major revisions which means code will have to be rewritten.
I have played with the perfect-scrollbar config and found no solution there, so I'm curious on what should be done.

@timabbott I have come across these jsfiddles, one and two. One is version 1.3.0 and seems to be scrolling properly, while the other is 0.6.10 (similar to zulip's 0.7.1) and has the scrolling issue, which makes me think the scrolling would be improved by a newer version. However, version 1.0.0 had major revisions which means code will have to be rewritten.
I have played with the perfect-scrollbar config and found no solution there, so I'm curious on what should be done.

@gooca probably this means we should work on upgrading to a newer version.  I think we might want to start with refactoring more things that can to use ui.set_up_scrollbar and ui.update_scrollbar where appropriate (being careful to avoid behavior changes; I'd probably do this one commit per call point), so that we have fewer callpoints into the perfectScrollbar library.  And then we can attempt to upgrade the version, and re-test all the places where we use it.
You can find all the callpoints with $ git grep perfect-scrollbar (catches the /help/ and /api/ pages in portico) and git grep perfectScrollbar (catches everything logged-in).

I'm interested in taking this, @zulipbot claim

@timabbott Should this issue be closed?

I don't think it's fixed yet, no.

Just submitted a PR.


create a getting started page

When times come, having a simple getting started page will be mandatory.

Didn't you do it already @vvo ?

Yep indeed, a small one but it exists


Replace usage of QString::asprintf

In Qt5, QString::asprintf is a static method which returns a new string, rather than an instance method which updates the existing string (as it was in Qt4), so the code was passing empty strings to the managed entry point. Additionally, the documentation warns against it.
The static QString::number method is available in both Qt4 and Qt5. I haven't tested against Qt4 but it works in 5.14.2.

Danke!


Feature Request: more stack upgrade options in rancher-compose.yml

It would be nice to be able to specify upgrade options such as "batch_size" directly in the rancher-compose.yml file.

@lesaux Not sure if you know, but we do offer these options in the CLI directly.
http://docs.rancher.com/rancher/latest/en/cattle/rancher-compose/upgrading/#in-service-upgrade

With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.


Update CookieLogger.php

Drecated Doctrine ManagerRegistry in favor to use Doctrine\Persistence\ManagerRegistry

I would really appreciate this, as current LTS of symfony (4.4.15) requires it. Thanks a lot!

@matthijsch any chance to merge it? Or would you like me to make changes to support both v1.3 and 2.0 at the same time?


user not forwarded past login page

Hi,
I have a user who isn't forwarded to the site after logging in.  They put in their credentials, get an email confirming the login, but don't get forwarded to the site.
This happens in Safari/ Chrome/ Desktop/ Android mobile; I've tried de-activating/ re-activating their account, to no avail.  They're only able to login through the iphone app.
I've been poking around the logs but can't find anything correlated with the login attempts.
It seems also there's nothing in the manage.py that would help with completely deleting the user to re-invite them, as a workaround?

A few questions:

Where do they get forwarded to instead?
What authentication method are they using?
Have you tried looking at /var/log/zulip/server.log?
  If so, what version?

Hi Tim,
The problem seems to have gone away; I'm running my own server, I think it was at 1.8.0 when this was a problem.  I subsequently did an upgrade to master from git (current version is 1.8.1+git), and now its working again.
User was logging in to website using email address/ password; the site would accept the credentials, and then re-load the same page without the credentials (the same prompt again).  But an email would go through saying that login was successful.  It's like the login page "ate" the credentials.  Unfortunately I didn't check server.log when it was a problem.  Sorry for not giving more detail in the original post.


try to fix a race in TTL thread shutdown

Scope & Purpose
Fix a race in TTL thread shutdown.
One thread could have reset the _thread unique_ptr while another thread was still using it.
The problem happened infrequently during our Jenkins PR runs

[x] Bug-Fix for devel-branch (i.e. no need for backports?)
[x] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)

Testing & Verification
This change is a trivial rework / code cleanup without any test coverage.
https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/4607/

Once more:
https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/4615/


security critical issues

Please provide the way to fix vulnerability inside the image.

Jenkins 2.235.5 has been superseded by Jenkins 2.249.x which was superseded by Jenkins 2.263.x.  The Jenkins project provides security fixes for current LTS and current weekly releases, not for older LTS or for older weekly releases.

Jenkins 2.235.5 has been superseded by Jenkins 2.249.x which was superseded by Jenkins 2.263.x.  The Jenkins project provides security fixes for current LTS and current weekly releases, not for older LTS or for older weekly releases.


Add cycle stats

Also consider making a simple web component that anyone can pop in to show canister stats

Maybe there is a button people can press that takes a cycles snapshot...that would be nice...it could then tell you how many cycles are being used per year, month, day, hour, minute, etc

Think about the best way to do it...probably the canister should just do the math, and do some kind of rolling average...


0.0.2 unable to find in cocoa pods

Hello, there's an error with cocoa pods:
pod 'SectionedSlider', '~> 0.0.2'
[!] Unable to find a specification for SectionedSlider (~> 0.0.2)

Please run a pod update.

This did it, thanks! sorry for wasting your time :(