fix(breadcrumb): Update peer deps for breadcrumb

Description
Breadcrumb had the incorrect version for actionbutton it peer deps so it was throwing an error/warning.
How and where has this been tested?

Built locally

To-do list

[ ] If my change impacts other components, I have tested to make sure they don't break.
[ ] If my change impacts documentation, I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have tested these changes in Windows High Contrast mode.
[x] This pull request is ready to merge.

So, is this happening because we have a batch of components that have been migrated to the new tokens system, and some that haven't, and some of the ones that have been migrated are dependencies of those that have not yet been migrated?

@pfulton @GarthDB On closer inspection, I believe the error has more to do with how peer dependencies are being defined across the repo. Typically they are more permissive and leverage the >= syntax to allow some flexibility in definition. This is a benefit because it will lead to less version management struggles downstream. I think we should tackle this on every component. What do you think?

I think I'll close this PR out for now in favor of a wholistic solution. I created CSS-381 to track that work.


Enforce a standard YAML format

This PR requires all files to be formatted with the google YAML formatter before submitting. This can be done with the following commands:
go install<EMAIL_ADDRESS>yamlfmt .
This will enforce a standard style that should remove any issues with formatting of PRs.

Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

@stuartwdouglas Is there any specific reason you are using v0.10.0 yamlfmt. Can't be do it based on Red Hat YAML lint?
One of the ex: With the current yaml format I see this approves the checks even if the yamls not started with
---

Doesn't yaml lint just check formatting? Or can it automatically fix the formatting as well?
The idea of this is that there is a single standard format, and you can just run the formatter and not have to think about formatting ever again. It means you won't get PRs with formatting changes, and all the files will be consistent.

Doesn't yaml lint just check formatting? Or can it automatically fix the formatting as well?

yes yamllint just check formatting but my point is the formatting that yamlfmt is doing might be lacking few of the standard like file should start with --- or if some values started with block but end with scalar then it should wrap it inside the quotes https://github.com/spack/spack/issues/38408 etc.
How would you fix those? Manually?

ok maybe for now I will remove the document-start: enable from the sample pipeline repo yamllint check and this fix should help the syncing linter issue. So lets merge this if everything else is good
/lgtm

Looks abandoned, can we close this?


User and application service error in Openshift

Describe the task
Issue creating uuid in user service and issue related to use of public schema in application service in OpenShift
Acceptance Criteria

[ ] Ensure services are running in OpenShift dev without errors

changes done to user service, testing in openshift test env

working good in dev env


[FEATURE] Disable new authentication system in 2.10

Re: Universities Monday 2021/03/29 / 2021-03-30
MV: It is work for a day or maximum two to turn off the Rokmetro stuff that we added in Rokwire (the Stephen's token) and make it work with the current 2.9 production backend. I am wondering why we did not do this in the beginning. It was a very bad idea to keep adding a number of new features to 2.9 support instead of doing this in 2.10 and take advantage of the refactored engine

Re: Universities Monday 2021/03/29 / 2021-03-31
MH: We should do this as now, unless we need Petyo to do something also. If we need Petyo, then let us wait till the import is done.


Error compiling OpenID Android app

I'm trying to compile OpenId Android sample app. But I keep getting the following error:

'AuthorizationService' does not contain a definition for 'CreateCustomTabsIntentBuilder' and no extension method 'CreateCustomTabsIntentBuilder' accepting a first argument of type 'AuthorizationService' could be found (are you missing a using directive or an assembly reference?)

The OpenId packages were updated 3 months ago, and  they should resolve you issue


Possibly replace tensorflow usage in data_utils with lighter-weight tool

The tensorflow dependency in climsim_utils.data_utils is pretty heavy, and among other things makes using that module on Mac M1 a bit cumbersome. In that module, tensorflow is actually only used for data loading:
https://github.com/leap-stc/ClimSim/blob/f7d092cbaf57d79d47fa56dc0fd3e00a391da696/climsim_utils/data_utils.py#L312-L316
Per @jerrylin96, we may be able to use another approach here, which would be desirable if possible.

I think we need to get rid of tensorflow usage entirely in data_utils.py. This will result in significant streamlining. I propose refactoring the creation of the numpy arrays using Apache Spark instead of the Tensorflow dataloader. Using that for preprocessing is a vestige of some really crude code macgyvering that doesn't belong in a polished repo.


Issue/fix:Add test single service relation

Description
Add a little test as follow up on the PR: https://github.com/inmanta/web-console/pull/3862
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[ ] Attached issue to pull request
[ ] Changelog entry
[ ] Code is clear and sufficiently documented
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Reviewer Checklist:

[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design

Processing this pull request

Pull request rejected by merge tool. Multiple change entry files found (changelogs/unreleased/3838-dependabot.yml,changelogs/unreleased/3840-dependabot.yml,changelogs/unreleased/3842-dependabot.yml,changelogs/unreleased/3844-dependabot.yml,changelogs/unreleased/3846-dependabot.yml,changelogs/unreleased/3848-dependabot.yml,changelogs/unreleased/3850-dependabot.yml,changelogs/unreleased/3852-dependabot.yml,changelogs/unreleased/3854-dependabot.yml,changelogs/unreleased/3859-dependabot.yml,changelogs/unreleased/3861-dependabot.yml,changelogs/unreleased/3864-dependabot.yml,changelogs/unreleased/fix-settings.yml,changelogs/unreleased/fix-single-service-relation-test.yml,changelogs/unreleased/fix-single-service-relation.yml). This may happen when a change entry was removed from the remote repository due to a reverted change. In that case, make sure the latest changes from origin/master are merged into issue/add-test-single-service-relation before triggering merge bot.

@dependabot rebase

Processing this pull request

Merged into branches master, iso5 in 39d87f417305689157fb8c2a6cb764fc0c92e329


(feature) bulk get groups

Description
Exposed "bulkGetGroups" method via asset library client group service
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (existing code being refactored)
[ ] This change includes a documentation update

Submission Checklist

[x] Build Verified
[x] Bundle Verified
[x] Lint passing
[x] Unit tests passing
[ ] Integration tests passing
[x] Change logs generated

Additional Notes:

Hi @anilbhaskaran - thanks for the PR? Do you have the bandwidth to add in integration test that covers this new behavior?

Hi @anilbhaskaran - thanks for the PR? Do you have the bandwidth to add in integration test that covers this new behavior?

Added integration test cases


Question: Why did you create this library?

Hi!
May I ask what the motivation was to create this?
What are you using the parser for?

Hey!
Of course. So the motivation was to kind of three fold:

To learn more about languages and parsers and specifically, parser combinators (it's been a long time since my university course on building compilers)
To use it to inspect, validate and transform PromQL expressions for a project I'm doing at work
To give something useful back to the .NET open source community.

And let's face it:
4. I've had a lot of time on my hands with the repeated lockdowns..

Thanks for the quick response! Maybe add a short "Why" section in the README.md 🙂
Regarding point 2.)
Can you disclose anything about that project, what the use case is for PromQL?
Is this app directly querying the prometheus API?
So far I am using prometheus / grafana at work, and could potentially use a parser / linter for:

Grafana dashboards
Prometheus (alert) rules

But since those queries are "hand made" and then checked into git (therefore human tested) I'm not sure an invalid query is something I need to worry about. Also grafana dashboard queries have all sorts of template variables in them which are tricky to handle.
Just for reference (to maybe other users browsing in here), there is also:

https://github.com/cloudflare/pint , a "Prometheus rule linter" which even can connect to a live prometheus server and do existence / sanity checks for rule querys
https://prometheus.io/docs/prometheus/latest/configuration/recording_rules/#syntax-checking-rules , using promtool
Probably more I'm not aware of

Can you disclose anything about that project, what the use case is for PromQL?
Sure- it's a tool to manage SLO calculations and implement multi-burn rate alarms. Part of this requires taking simple PromQL expressions and transforming them into more complex expressions. There's a few self-imposed restrictions I require of PromQL expressions I can accept (e.g. must use rate, must not use subquery expressions) as well.

This library helps me do this:

It can parse out a PromQL expression into it's individual components
I can run my custom validation logic on the resulting AST
I can then transform these simple expressions by creating new instances of AST records.

This does not replace tools like promtool and I explicitly call out the lack of semantic validation in the README. At work, I still run my generated expressions through promtool to make sure they are correct before applying them to any production prometheus server.


windows_resource kit should have a provider:eventID -> description resource

several different sources, roll them up into a lookup resource and include into the kit

Superseded by https://github.com/gravwell/kits/issues/165


Expected cosimulation results

Hello, I ran the cosimulation overnight and it was still running in the morning with no output. How long is this expected to take? And what is the expected output?
I've rebuilt with the multi-threading for verilator enabled, so now it gets 98%+ utilization. I'm running this instead now.

Hi Eric, sounds like something is going wrong. For me the cosimulation with the default parameters takes around ten minutes when I launch it as a clean build. It should definitely not need to run overnight.
Can you share more information about your setup (e.g. which branch, native or Docker environment, which Vivado and OS versions), how you are launching the cosim and what's the last output(s) you see on the terminal?

Hi maltanar, thanks for responding.
Last output is:
sh compile_testapp.sh; \
LD_LIBRARY_PATH=/home/eric/src/bismo/build/2x64x2/VerilatedTester/deploy ./testapp t;
In file included from test/BISMOTests.hpp:40,
                 from test/main.cpp:33:
test/gemmbitserial/gemmbitserial.hpp:509:2: warning: #warning "Compiling using generic popcount" [-Wcpp]
  509 | #warning "Compiling using generic popcount"
      |  ^~~~~~~
^Cmake: *** [platforms/VerilatedTester.mk:59: emu] Interrupt

Full output
There is a process "./testapp t" running.
Platform is Manjaro linux.
I bumped the sbt version to 0.13.16 because an error was appearing about the console.
PLATFORM=VerilatedTester make emu -j1
Verilator 4.016 2019-06-16 rev UNKNOWN_REV
bismo patch: afda989
chisel: ucb-bar/chisel2-deprecated@9d9672bb
Vivado: 2017.4

Thanks. It looks like the cosimulation executable is produced but gets stuck for some reason. Are  you able to discern anything useful using gdb to see where it gets stuck?

I turned on debugging symbols in the build and ran it for about 30mins. This is where it was at when I interrupted it:
#0  0x00007ffff7cf05f5 in VTesterWrapper::_sequent__TOP__3 (vlSymsp=0x55555557b230) at verilog/verilated/VTesterWrapper.cpp:15433
#1  0x00007ffff7d3892b in VTesterWrapper::_eval (vlSymsp=0x55555557b230) at verilog/verilated/VTesterWrapper.cpp:39279
#2  0x00007ffff7cc7bc7 in VTesterWrapper::eval (this=0x7fffd76ad010) at verilog/verilated/VTesterWrapper.cpp:73
#3  0x00007ffff7cab09c in VerilatedTesterRegDriver::step (this=0x55555557b110, n=1) at driver/verilatedtesterdriver.hpp:181
#4  0x00007ffff7caafa0 in VerilatedTesterRegDriver::readReg (this=0x55555557b110, regInd=56) at driver/verilatedtesterdriver.hpp:137
#5  0x00007ffff7c93345 in BitSerialMatMulAccel::readReg (this=0x55555557b1f0, i=56) at ./driver/BitSerialMatMulAccel.hpp:121
#6  0x00007ffff7c932f1 in BitSerialMatMulAccel::get_tc_ef (this=0x55555557b1f0) at ./driver/BitSerialMatMulAccel.hpp:102
#7  0x00007ffff7c93f2a in BitSerialMatMulAccelDriver::init_resource_pools (this=0x55555557b150) at rtlib/BitSerialMatMulAccelDriver.hpp:404
#8  0x00007ffff7c92699 in bismo_rt::init () at rtlib/bismo_rt.cpp:49
#9  0x000055555555f19b in main (argc=2, argv=0x7fffffffdb78) at test/main.cpp:51

So this is very early on at system start where the token FIFOs are being initialized, and the driver is waiting for the initialization to be complete:
  void init_resource_pools() {     set_stage_enables(0, 0, 0);     for(int i = 0; i < FETCHEXEC_TOKENS; i++) {       add_token_fetchexec_free();     }     while(m_accel->get_tc_ef() != FETCHEXEC_TOKENS);
Have you made any modifications to the hardware configuration, the hardware or the drivers? If not I'm not sure what the issue may be -- it might be worth trying an older version of Verilator. I can run successfully with Verilator 3.900 2017-01-15 rev verilator_3_890-15-ge6d7e7e. If you are familiar with Docker you could try running inside the Docker environment on the dev branch: https://github.com/EECS-NTNU/bismo/tree/dev#docker

I didn't modify the hardware or drivers.
I used verilator 3.900 and the tests pass successfully.
I might look into it later to make use of the the multi-threading in version 4.

It seems as also newer versions of verilator can cause similar issues. At least Verilator 4.024 2019-12-08 rev v4.024-1-g6f52208 caused the simulation to run without ever providing any results.


NavigationView: Fix bug where items with empty MenuItemsSource would still spawn flyout

Description

The bug was that we only checked if MenuItemsSource is not null, but ignored it's size. This if fixed now.
Motivation and Context

Closes #3670
How Has This Been Tested?

Tested manually; Unfortunately, I wasn't able to find a reliable way to detect whether a flyout is open or not from an interaction test. Running an API test is not an option as we can't simulate item invokation in there.
Screenshots (if appropriate):

/azp run

Looks like CI stopped hearing from the test machines :/

Looks like CI stopped hearing from the test machines :/

/azp run

/azp run

/azp run

/azp run

@chingucoding have you gottent to look at the test failures by chance?

Taking a look at this soon, must have missed this PR. Thanks for the reminder.

Switched to ItemsSourceView, this should work now since the issue was based on a non working cast.

@chingucoding is this ready to merge in?

@karenbtlai Yes this is ready to merge!


ignores https in mixed sites

when i make an sitemap for my page https://www.parkhotel-burgmuehle.de he ignores a lot of URLs but the robots.txt says allowed an i dont know why
as exampel this urls are ignored:
https://www.parkhotel-burgmuehle.de/blog/holiday-check-award-2016/
https://www.parkhotel-burgmuehle.de/blog/die-weihnachtsmaerkte-im-oberallgaeu/
https://www.parkhotel-burgmuehle.de/blog/w-lan-der-burgmuehle/
https://www.parkhotel-burgmuehle.de/impressum
and in the robtots.txt only this lines
User-agent: *
Disallow: */feed/
Disallow: /page/

It works for me:

Although I noticed another entry with /feed/ attached. This is ignored as expected.

Ok i test again and now i can give you mor informations.
if i start the generator with the https all is fine if i start with http he ignore all https links

You are not redirecting from http to https. The generator crawls your site and follows all links. This is a problem on your end and not within the generator, so I'm closing this issue.

Sorry but i cannot accept your Answer. When i have an mixed Side with https and http then the generator ignores one of theme this is not right

I made more checks and can confirm your problem, you are right. ;) Although I'm not sure whats the problem. Will have to investigate this further.

I found a problem on my side: there is no robots.txt on HTTPS - and also it redirects from /robots.txt to http://example.com which leads to a HTTP response code 200
I'll fix this and provide a proper robots.txt for HTTPS

Fixed with v4.0.0

im no have the problem that my side not crawl the blog (this is the https part of the side) and when in put in the direkt adress as https he says he cannot find. If i get the url without http he jumps down to the root and never go back in the blog but there are a lot of other links in the blog
sitemap-generator -d https://parkhotel-burgmuehle.de/blog/

First of all I can see that all of your pages are available with and without https. You should redirect all requests to https or you get duplicate content. Just a general advice.
I can confirm that there is a problem directly getting https://parkhotel-burgmuehle.de/blog/. Will have to look at it later in detail.
Another thing: If you want to crawl only pages beneath the initial url you have to set --baseurl.


How can i get connected adapter name? Like Phantom or Brave

How can i get connected adapter name? Like Phantom or Brave

adapter.name
If you're using this with React
const { wallet } = use wallet();
wallet.adapter.name

Thanks :)


Comment for "Null" validator extension verbiage is incorrect

Verbiage for the Null and NotNull extension methods is the same. Verbiage for the "Null" validation extension needs to be changed from "Defines a not null validator" to "Defines a null validator"
 /// <summary>
/// Defines a 'not null' validator on the current rule builder.
/// Validation will fail if the property is null.
/// </summary>
/// <typeparam name="T">Type of object being validated</typeparam>
/// <typeparam name="TProperty">Type of property being validated</typeparam>
/// <param name="ruleBuilder">The rule builder on which the validator should be defined</param>
/// <returns></returns>
public static IRuleBuilderOptions<T, TProperty> Null<T, TProperty>(this IRuleBuilder<T, TProperty> ruleBuilder) {
	return ruleBuilder.SetValidator(new NullValidator());
	}

@brianro - this is already handled in PR #239

I thought I'd already fixed this, but turns out I'd swapped around Null/NotNull by mistake. Should be fixed in latest commit.


html-formatter: add cucumber icon to page

Summary
A trivial thing, but maybe a nice touch. Supported in all modern browsers, using an emoji inside of an SVG.
Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue).
[x] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

[ ] The change has been ported to Java.
[ ] The change has been ported to Ruby.
[ ] The change has been ported to JavaScript.
[ ] The change has been ported to Go.
[ ] The change has been ported to .NET.
[ ] I've added tests for my code.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have updated the CHANGELOG accordingly.

@aslakhellesoy good point, done

This reminds me that we have a slightly updated logo since Cucumber became part of SmartBear.

Ah okay - I pulled this one from the header in https://cucumber.io/, didn't realised there was another iteration.

Never mind - you picked the right logo. Let's merge this!


Add basic support for particle trails.

This commit implements simple fixed-length particle trails in Hanabi. They're stored in a ring buffer with a fixed capacity separate from the main particle buffer. Currently, for simplicity, trail particles are rendered as exact duplicates of the head particles. Nothing in this patch prevents this from being expanded further to support custom rendering for trail particles, including ribbons and trail-index-dependent rendering, in the future. The only reason why this wasn't implemented is to keep the size of this patch manageable, as it's quite large as it is.
The size of the trail buffer is known as the trail_capacity and doesn't change over the lifetime of the effect. The length of each particle trail is known as the trail_length and can be altered at runtime. The interval at which new trail particles spawn is known as the trail_period and can likewise change at runtime.
There are three primary reasons why particle trails are stored in a separate buffer from the head particles:

It's common to want a separate rendering for trail particles and head particles (e.g. the head particle may want to be some sort of particle with a short ribbon behind it), and so we need to separate the two so that they can be rendered in separate drawcalls.

Having a separate buffer allows us to skip the update phase for particle trails, enhancing performance.

Since trail particles are strictly LIFO, we can use a ring buffer instead of a freelist, which both saves memory (as no freelist needs to be maintained) and enhances performance (as an entire chunk of particles can be freed at once instead of having to do so one by one).

The core of the implementation is the
render::effect_cache::TrailChunks buffer. The long documentation comment attached to that structure explains the setup of the ring buffer and has a diagram. In summary, two parallel ring buffers are maintained on CPU and GPU. The GPU ring buffer has trail_capacity entries and stores the trail particles themselves, while the CPU one has trail_length entries and stores pointers to indices defining the boundaries of the chunks.
A new example, worms, has been added in order to demonstrate simple use of trails. This example can be updated over time as new trail features are added.

@djeedai Could you explain what you mean by the separate sub-effect? Like trails are a separate EffectAsset, and the main effect just dumps new particles into the other effect? There would need to be a way to convert one particle to the other type, as well as a new attribute to store the index of the most recent particle in the other trail effect (so that they can form a linked list--this is important for ribbons.)
If that's what you mean, then I'll close this PR as this will require a complete rewrite.

If that's what you mean, then I'll close this PR as this will require a complete rewrite.

Don't. This is a longer term goal that's absolutely not reachable easily now, as it's missing too many pieces. So the current PR is fine. I just wanted to seed some discussion and think ahead.
What I mean is a single EffectAsset describes a single "visual effect" authored by an artist, and that "effect" can be composed of multiple sub-effects, each one with its own modifier stack etc. and possibly different outputs. And yes, that means there's a mechanism to trigger spawning between those sub-effects, likely without CPU intervention. Today the EffectAsset contains a single linear stack of modifiers for init/update/render, in that order, executed in sequence each frame. If an artists wants to have an effect with multiple visuals, they need multiple EffectAsset, and somehow coordinate them, which is almost impossible. Tomorrow, we can imagine that there could be multiple init/update/render nodes organized in a graph (and not a stack) and connected to each other. That means for example we could have 2 sources of init/spawn feeding a single update (single particle buffer), so we can easily share a buffer for, say, spawning in two different locations, which is a feature many have asked. Or, have a same update / particle buffer feed into 2 different outputs (render a quad AND render a mesh, for each particle). In that vision, your "the head particle requires a different rendering" just becomes 1 output for the particle heads, and one output for the trails themselves. And the trails have no special casing for the first particle, because they only render the trail part.

All of that makes sense to me. I actually implemented a very crude version of that in the Hanabi Workshop, in the form of particle systems that combine multiple effects into one and are spawned as a group. As you mentioned, this functionality is necessary for many effects.
I think it'd be best to implement trails in a way that doesn't require a massive rewrite when we move to nodes.
Here's a strawperson short-term proposal. What if we had something like "particle groups", each of which had its own list of indices on GPU? A particle belongs to a single group for its lifetime. Each modifier would specify which group or groups it applies to. The spawner would likewise have be annotated with a set of groups that it spawns particles into. Each particle group would be rendered in a separate drawcall, allowing for differing mesh topology per group. By itself, this wouldn't provide any new functionality, but it would open the door for new functionality in the following ways:

We could add a "Duplicate Particle" modifier that duplicates a particle on a controllable schedule and assigns the duplicate to one or more groups. This would allow trails to be implemented. You'd have two groups, a "head" group and a "trail" group, and all the update modifiers would only apply to the "head" group. The only update modifier that the "trail" group would have would be a Kill Particle modifier based on age. This also immediately allows different rendering for heads and trails.

We could add multiple spawners, each with its own set of groups that it spawns into, which would allow for multiple init sources, each with their own schedules.

Eventually, we'd be able to compile an arbitrary node graph down to this "linear modifiers and particle group" format. We're going to have to compile the node graph into something, and the particle group format seems particularly efficient at minimizing the number of drawcalls and compute invocations. I think that every conceivable DAG can be compiled into the particle group format, so this provides a smooth migration internally.

In order to implement trails, we'd need the particle group infrastructure and the "Duplicate Particle" modifier. This would be more flexible than this PR and would be forward-compatible with nodes. What do you think?

Thinking about it more, I'm actually unsure how you'd implement node graphs without some sort of "particle groups" system under the hood. You clearly can't have an output buffer per node; that would be way too much copying of indices. So you need to optimize the node graph into the minimum set of output buffers by counting the total number of paths through the DAG and assigning particles to each of the buffers as necessary. That's precisely equivalent to particle groups as I described them.

Closing as #296 obsoletes this.


PR: Ensure Pythonpath Manager widget is in front and has focus after adding path

Description of Changes

Ensure that PYTHONPATH Manager widget is the front window and has focus after adding a path.
Do not update paths upon the path_manager_action if the widget is already visible

These changes should be rebased after merging #20811.
After merging into 5.x, these changes may be merged into master.
Issue(s) Resolved

Fixes #20808
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @mrclary

@mrclary, I think you need to rebase this PR to get the fixes in #20817.


TypeError: unsupported operand type(s) for |: 'NoneType' and 'str' when sku=None

Describe the bug
Exception point is below.
        sku = sku | 'F1'

https://github.com/Azure/azure-cli/blob/master/src/command_modules/azure-cli-appservice/azure/cli/command_modules/appservice/custom.py#L2187
Exception
unsupported operand type(s) for |: 'NoneType' and 'str'
Traceback (most recent call last):
  File "/opt/az/lib/python3.6/site-packages/knack/cli.py", line 206, in invoke
    cmd_result = self.invocation.execute(args)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 328, in execute
    raise ex
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 386, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 377, in _run_job
    cmd_copy.exception_handler(ex)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/command_modules/appservice/commands.py", line 54, in _polish_bad_errors
    raise ex
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 356, in _run_job
    result = cmd_copy(params)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 171, in __call__
    return self.handler(*args, **kwargs)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/__init__.py", line 452, in default_command_handler
    return op(**command_args)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/command_modules/appservice/custom.py", line 2195, in create_deploy_webapp
    sku = sku | 'F1'
TypeError: unsupported operand type(s) for |: 'NoneType' and 'str'

To Reproduce

python webapp on azure webapp on linux
When the requirements.txt file is missing.

az webapp up --name "name" --location "location"

Expected behavior
Unsupport NoneType and str in Python.
I suggest the following code.
        sku = sku or 'F1'

Environment summary
Ubuntu Linux and Mac OS-X.
azure-cli : 2.0.60
Additional context
May I PR?

@allieus Thanks for raising this issue. Yes you may make a PR.
CC: @panchagnula

@allieus thanks for reporting & also suggesting the fix - got some folks reporting the same so starting a PR for this


Forked-daapd not Connecting to Spotify Account

I have forked-daapd installed and running. In forked-daapd settings, it appears that I successfully connected to my Spotify Premium account, however, when perform a search in forked-daapd no Spotify results are returned. I have tried to connect via Spotify Web API in forked-daapd settings, however, when I click on the Authorize Web API button, nothing happens. I checked the logs and am seeing multiple messages that "No Spotify refresh token was found".

Hi,
Sounds like an issue with forked-daapd itself more than with the addon, you might want to get in touch with the project.
I'm myself using aarch64 where libspotify isn't available so I can't test it, but when I was using arm it did work fine. Maybe your adblock blocking a popup ?

Hey,
Any update on this, are you still having an issue or can this be closed ?

Hey,
Any update on this, are you still having an issue or can this be closed ?


[Question] Support OID4VC standard in ACA-Py

Hi,
First and foremost thank you for the incredible amount of works that you have done in that area 🚀 .
Do you plan to implement the full implementation of OpenID for Verifiable Credentials in a near future?

OpenID for Verifiable Credential Issuance (OID4VCI)
OpenID for Verifiable Presentations (OID4VCI)
Self-Issued OpenID Provider v2 (SIOPv2)

Sorry for the slow answer.  Work has started on this in Aries Framework JavaScript (see this PR 1384. We’re planning on learning from that and then seeing how OpenID4VCs fits into the Aries frameworks in general and ACA-Py specifically.  We’ve been talking with the OpenID folks since the announced their protocols.  We expect to learn more and discuss ideas for adding OpenID4VCs to Aries at the upcoming IIW later this month.
More to come.  If you have some contributions to make in this area, please let us know.

Hi,
(sorry also for the lack of velocity...).
Great news! I'll check the PR 👀 .
Anyway, I am motivated to be a contributor on this topic if the project need resources.
There is a lot of stuff to do in this area 🚀 .

@swcurran  -has there been any further discussion for support in ACA-Py. If for sure would be tremendously helpful if it was dual-stack!

Some discussion, but no one has (AFAIK) built anything.  There hasn’t been a PR.  From a BC Gov perspective, we’re looking forward to seeing what happens in AFJ with the support they have added — how it gets used.  And continuing on with the many other things that we’re doing :-).

Discussed on the ACA-Pug call 2023.08.08.  Noted in the call:
A possible design is to make it a companion service that calls into ACA-Py vs. within ACA-Py -- much like we do today in vc-authn-oidc. There is a requirement for additional public endpoints beyond the DIDComm endpoint, and so perhaps those could be in a separate service calling ACA-Py endpoints for preparing (SD-)JWT credentials – similar to the JSON-LD endpoints we have today – sign/verify.
Another alternative might be a – plugin, so that there can be a tighter integration for calling ACA-Py utility functions directly, but still a separation from the core features of ACA-Py.
And of course, it could also be a feature added to ACA-Py directly.

Plugin available in the plugins repo -- https://plugins.aca-py.org


CMake search path wrongly separated

Hi,
I have been packaging a few additional ROS packages to the ones already packaged (I'm happy to make a merge request if you're interested), this has worked very well, but I have an issue for pcl_ros.
My fork and the branch in which I have packaged the additional ROS packages can be found here: https://github.com/nschoe/nixpkgs/tree/airapkgs_PCL_ROS . Everything is in pkgs/development/ros-modules/ as you started it.
I'm linking to my own github because I haven't double-checked the code enough to offer a merge request (but I can, if it's better).
Just so you know: I have freshly (like yesterday) git pull your nixos-unstable branch, and merged it in my PCL_ROS branch. So this branch is up-to-date with yours.
So pcl_ros depends on pcl_conversions, so I have packaged pcl_conversions too (https://github.com/nschoe/nixpkgs/blob/airapkgs_PCL_ROS/pkgs/development/ros-modules/pcl_conversions/default.nix).
When I create a simple nix-shell with pcl_conversions in buildInputs, it work no problem.
Then I packaged pcl_ros (https://github.com/nschoe/nixpkgs/blob/airapkgs_PCL_ROS/pkgs/development/ros-modules/pcl_ros/default.nix), but when I put pcl_ros in my shell.nix's buildInputs, this time I get an error (here's the end of it):
-- Found PythonInterp: /nix/store/nrl0l79a48924xb0897ap572xf29ciir-python3-3.6.6/bin/python (found version "3.6.6")
-- Using PYTHON_EXECUTABLE: /nix/store/nrl0l79a48924xb0897ap572xf29ciir-python3-3.6.6/bin/python
-- Using default Python package layout
-- Found PY_em: /nix/store/bsga2zrxh8nrd76j3ixv7yqi5h8bwa7k-empy-3.3.2/lib/python3.6/site-packages/em.py
-- Using empy: /nix/store/bsga2zrxh8nrd76j3ixv7yqi5h8bwa7k-empy-3.3.2/lib/python3.6/site-packages/em.py
-- Using CATKIN_ENABLE_TESTING: OFF
-- catkin 0.7.11
CMake Error at /nix/store/fa7sbb3fhaxwmqh1v096gcyc2rd606wc-pcl_conversions-1.6.2/share/pcl_conversions/cmake/pcl_conversionsConfig.cmake:113 (message):
  Project 'pcl_conversions' specifies
  '/nix/store/m8fkjfznkx88qmn6mi4x9q7njamirxjx-eigen-3.3.4//nix/store/m8fkjfznkx88qmn6mi4x9q7njamirxjx-eigen-3.3.4/include/eigen3'
  as an include dir, which is not found.  It does neither exist as an
  absolute directory nor in
  '/nix/store/fa7sbb3fhaxwmqh1v096gcyc2rd606wc-pcl_conversions-1.6.2//nix/store/m8fkjfznkx88qmn6mi4x9q7njamirxjx-eigen-3.3.4//nix/store/m8fkjfznkx88qmn6mi4x9q7njamirxjx-eigen-3.3.4/include/eigen3'.
  Check the issue tracker
  'https://github.com/ros-perception/perception_pcl/issues' and consider
  creating a ticket if the problem has not been reported yet.
Call Stack (most recent call first):
  /nix/store/m71xl0jjv1kax8zpk4fr6qsj89f5kk2d-catkin-0.7.11/share/catkin/cmake/catkinConfig.cmake:76 (find_package)
  CMakeLists.txt:37 (find_package)

-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-pcl_ros-1.6.2.drv-0/source/build/CMakeFiles/CMakeOutput.log".
See also "/tmp/nix-build-pcl_ros-1.6.2.drv-0/source/build/CMakeFiles/CMakeError.log".
builder for '/nix/store/ishzgx575g1iyxmw44626lmy48nvz73b-pcl_ros-1.6.2.drv' failed with exit code 1
error: build of '/nix/store/ishzgx575g1iyxmw44626lmy48nvz73b-pcl_ros-1.6.2.drv' failed

The weird thing is when it looks for Project 'pcl_conversions' specifies   '/nix/store/m8fkjfznkx88qmn6mi4x9q7njamirxjx-eigen-3.3.4//nix/store/m8fkjfznkx88qmn6mi4x9q7njamirxjx-eigen-3.3.4/include/eigen3'   as an include dir.
There seems to be a problem separating the paths: it is missing an : between ...njamirxjx-eigen-3.3.4/ and /nix/store....
I'm a bit lost as to where I should look : where is the mistake likely to be made?
Also why does pcl_conversions compile and work without problem in nix-shell, but fails when it's a dependency of pcl_ros?

Hi, @nschoe! Glad to see your improvement!
Yes, I catch this error some month ago too. In my opinion it possible to fix via patching CMake scripts provided by pcl_conversions package.

Thanks for your fast response time, @akru :)
(Do I take it that you'd be interested in a merge request once I've solved this issue and cleaned my files a little?)

Yes, I catch this error some month ago too. In my opinion it possible to fix via patching CMake scripts provided by pcl_conversions package.

Can you tell me a bit more ? (Sorry I'm quite new to NixOS, I try to learn more, but everything takes forever to me ^^).
I'll try to look up the CMake-related files inpcl_conversions but any fingers pointing in the right direction would be greatly appreciated !
(P.S. how did you dirty-fix it yourself ?)

Of course we are interested in growing ROS package base in airapkgs repository. Building open community of Robotics engineers and entusiasts is our main aim. I'll glad to see your PR at https://github.com/airalab/airapkgs.
I'll try to reproduce this error at weekends and write results here.

Okay no problem : I'll submit as soon as the error is fixed and I cleaned my files.
(We should consider making a PR to the official NixOS's nixpkgs also, so that lots of nix users can package ROS packages :))
Okay thanks for taking a look. I'll give it a small break because I've been on it for the whole day, then I'll try again.
Hope to solve this soon.

Hi @nschoe, may be using catkin_make instead of cmake at https://github.com/airalab/aira/issues/71 fix your issue, could you try it?

Hi @akru sorry for the delay, some unexpected events synchronized.
Thanks for taking the time to look into this. I have looked at #71, but this is now closed. I'm not sure: did you solve it?
I git pulled right now, and some some changes about using catkin instead of cmake, but now I have a lot of fails.
tf2_eigen fails because of the sha256 hash not being correct, so I have updated it, now I have several other fails, I'm trying to fix them and see if pcl_ros will build.

All right, so I have fixed all the sha256 mismatch and could retry building pcl_ros, but unfortunately, I have the same issue (it's eigen 3.3.5 now, but the error is the same):
-- Found PythonInterp: /nix/store/bwfygfcdvis9wd1c1v51xwnwhw1hx0a0-python3-3.6.6/bin/python (found version "3.6.6")
-- Using PYTHON_EXECUTABLE: /nix/store/bwfygfcdvis9wd1c1v51xwnwhw1hx0a0-python3-3.6.6/bin/python
-- Using default Python package layout
-- Found PY_em: /nix/store/kg52fzv2qm94yp5rdriq9cbc8hdg33yr-empy-3.3.2/lib/python3.6/site-packages/em.py
-- Using empy: /nix/store/kg52fzv2qm94yp5rdriq9cbc8hdg33yr-empy-3.3.2/lib/python3.6/site-packages/em.py
-- Using CATKIN_ENABLE_TESTING: OFF
-- catkin 0.7.11
CMake Error at /nix/store/7drfmax4gf4r9qnswf94wgqdy9i9nvrk-pcl_conversions-1.6.2/share/pcl_conversions/cmake/pcl_conversionsConfig.cmake:113 (message):
  Project 'pcl_conversions' specifies
  '/nix/store/hv9cr94nagryn5z68j78m6gj44jvi0m2-eigen-3.3.5//nix/store/hv9cr94nagryn5z68j78m6gj44jvi0m2-eigen-3.3.5/include/eigen3'
  as an include dir, which is not found.  It does neither exist as an
  absolute directory nor in
  '/nix/store/7drfmax4gf4r9qnswf94wgqdy9i9nvrk-pcl_conversions-1.6.2//nix/store/hv9cr94nagryn5z68j78m6gj44jvi0m2-eigen-3.3.5//nix/store/hv9cr94nagryn5z68j78m6gj44jvi0m2-eigen-3.3.5/include/eigen3'.
  Check the issue tracker
  'https://github.com/ros-perception/perception_pcl/issues' and consider
  creating a ticket if the problem has not been reported yet.
Call Stack (most recent call first):
  /nix/store/7870vlzkdmqhgf7cll4jmlrbp0644f6b-catkin-0.7.11/share/catkin/cmake/catkinConfig.cmake:76 (find_package)
  CMakeLists.txt:37 (find_package)

-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-pcl_ros-1.6.2.drv-0/source/build/CMakeFiles/CMakeOutput.log".
See also "/tmp/nix-build-pcl_ros-1.6.2.drv-0/source/build/CMakeFiles/CMakeError.log".
builder for '/nix/store/frxm488ybn64ff0kgqrqimv6zfjz991j-pcl_ros-1.6.2.drv' failed with exit code 1
error: build of '/nix/store/frxm488ybn64ff0kgqrqimv6zfjz991j-pcl_ros-1.6.2.drv' failed

I try to build your branch airapkgs_PCL_ROS merged with airapkgs upstream.
diff --git a/pkgs/development/ros-modules/pcl_conversions/default.nix b/pkgs/development/ros-modules/pcl_conversions/default.nix
index de22e71a1db..f985baf3e1a 100644
--- a/pkgs/development/ros-modules/pcl_conversions/default.nix
+++ b/pkgs/development/ros-modules/pcl_conversions/default.nix
@@ -1,12 +1,11 @@
 { stdenv
 , mkRosPackage
 , fetchFromGitHub
-, catkin
+, eigen
+, boost
+, pcl
 , cmake_modules
-, eigen3_3
-, boost167
 , pcl_msgs
-, pcl
 , dynamic_reconfigure
 , message_filters
 , nodelet
@@ -28,7 +27,12 @@ in mkRosPackage {
     sha256 = "0wl79qlj1j2a79w3ppvxwb4ifigmrycq82zrzrdzkajcjb4i568z";
   };

-  propagatedBuildInputs = [ catkin cmake_modules eigen3_3 boost167 pcl_msgs pcl dynamic_reconfigure message_filters nodelet nodelet_topic_tools ];
+  postPatch = ''
+    sed -i '/find_package(Eigen3 REQUIRED)/d' CMakeLists.txt
+  '';
+
+  buildInputs = [ eigen boost pcl ];
+  propagatedBuildInputs = [ cmake_modules pcl_msgs dynamic_reconfigure message_filters nodelet nodelet_topic_tools ];

   meta = with stdenv.lib; {
     description = "PCL (Point Cloud Library) ROS interface stack.";

This patch works well.

Thanks @akru  for the patch, I applied it and tried to rebuild pcl_ros and indeed: it succeeded!
So, nice catch and thanks for the patch.
Could you explain briefly why / how this works?
I'm asking because, now that pcl_ros builds and no longer has this issue caused by pcl_conversions... I have the exact same issue with my shell.nix (for my real project), only this time the error is caused by pcl_ros.
The error message is
CMake Error at /nix/store/31yn97xyrjy1mb8gmayg94bm1jf0qcid-pcl_ros-1.6.2/share/pcl_ros/cmake/pcl_rosConfig.cmake:113 (message):
  Project 'pcl_ros' specifies
  '/nix/store/hv9cr94nagryn5z68j78m6gj44jvi0m2-eigen-3.3.5//nix/store/hv9cr94nagryn5z68j78m6gj44jvi0m2-eigen-3.3.5/include/eigen3'
  as an include dir, which is not found.  It does neither exist as an
  absolute directory nor in
  '/nix/store/31yn97xyrjy1mb8gmayg94bm1jf0qcid-pcl_ros-1.6.2//nix/store/hv9cr94nagryn5z68j78m6gj44jvi0m2-eigen-3.3.5//nix/store/hv9cr94nagryn5z68j78m6gj44jvi0m2-eigen-3.3.5/include/eigen3'.
  Check the issue tracker
  'https://github.com/ros-perception/perception_pcl/issues' and consider
  creating a ticket if the problem has not been reported yet.
Call Stack (most recent call first):
  /nix/store/a52dcjcjnfxlgv2xnnnlhcp5p3f9i9nf-catkin-0.7.14/share/catkin/cmake/catkinConfig.cmake:76 (find_package)
  alexandria/CMakeLists.txt:13 (find_package)

So it's very similar.
I have tried to "replicate" your patch adding the postPatch, and putting eigen and boost inside buildInputs rather than propagatedBuildInputs inside pcl_ros/default.nix, but I still have the error message.
So if you could give me a hint why it worked in your case, I'd be glad :)

Hi @nschoe! As you can see ROS and NixOS have a lot of catkin/cmake magic and a lot of things are not what they seem. Unfortunately in NixOS eigen package have no cmake finder file FindEigen3, for this reason pcl_conversions build fails. But eigen already in CMAKE_PREFIX_PATH because it imported by nix buildInputs for this reason patch should work.
So, in my opinion the reason of your error somewhere in cmake template files, I'll try to found them.

@akru  thanks for answering.
I have just made "progress" (I hope). I have two pieces of information but not sure what they mean, here are they, maybe they make sense to you:

I finally found something interesting: inside pcl_ros's CMakeLists.txt file I found this:

## Add include directories
include_directories(include
  ${Boost_INCLUDE_DIRS}
  ${catkin_INCLUDE_DIRS}
  ${EIGEN3_INCLUDE_DIRS}
  ${PCL_INCLUDE_DIRS}
)```

And since my issues seem to be related to a weird story of include dirs, I thought about deleting the line about Eigen, so here's my `pcl_ros/default.nix`'s `postPatch` :

postPatch = ''
sed -i '/find_package(Eigen3 REQUIRED)/d' CMakeLists.txt;
sed -i '/''${EIGEN3_INCLUDE_DIRS}/d' CMakeLists.txt
'';

2. after doing this, I tried to enter the shell with `nix-shell` on my `shell.nix` (the one for my project), this compiled. But when I ran `catkin_make` from my catkin workspace, it complained that it could not find `Eigen`, then I remember that I had changed `eigen3_3` to `eigen` inside my `shell.nix`'s `buildInputs`. So I tried to put back `eigen3_3` instead and now it doesn't complain about not finding eigen anymore.

It _looks like_ deleting the `${EIGEN3_INCLUDE_DIRS}` worked, but I'm not sure, because for a WTF reason, now my `catkin_make` fails because `/nix/store/c4d9qgyyx6p2gydbbh5wpp4mxvwgc64n-qtbase-5.11.1-bin/lib/qt-5.11/plugins/imageformats/libqicns.so` file not exiting, which is a totally unrelated problem I had a long time ago and mysteriously re-appeared (probably due to some `nix-collect-garbage` I ran earlier today).

In the meantime, maybe this can help you find the culprit?

Hey, in case it helps:
I got this problem too when using nixpkgs to build https://github.com/hjwdzh/QuadriFlow.
I got:
Failed to find Eigen - Could not find file:
/nix/store/mp82a6rghs77d8qvbjc3fn0g4jcadd7s-eigen-3.3.3//nix/store/mp82a6rghs77d8qvbjc3fn0g4jcadd7s-eigen-3.3.3/include/eigen3/Eigen/src/Core/util/Macros.h

I solved it by giving cmake the flag:
-DEIGEN_PREFER_EXPORTED_EIGEN_CMAKE_CONFIGURATION=FALSE


Update main.js - fix mistyped attribute

Wrongly stated attribute - simple mistyped...

Thanks for PR.


⚠ Bofrost.be has degraded performance

In 83b77dc, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1135 ms

Resolved: Bofrost.be performance has improved in 2071396 after 16 minutes.


Cap runtime changes

[CI] Staging environment is at http://cap-staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/cap-runtime-changes/docs/

[CI] Staging environment is at http://cap-staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/cap-runtime-changes/docs/

[CI] Staging environment is at http://cap-staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/cap-runtime-changes/docs/


[WinAuth] Further clarify app configuration and deployment

I have just run into the 500.19 Internal Server Error after following this page to set up Windows authentication. I found this previous, closed Issue about the same thing but still ended up with the same problem. Am I correct in understanding that if you are running your project out of Visual Studio under IIS Express, you should not include the web.config outlined on this page? Rather just configure windows authentication and anonymous access directly through IIS for the target site?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 401ad9a0-9e51-80a2-5846-82e9790d7257
Version Independent ID: fbc36c26-9992-1f4c-66d3-02f898ee7ec4
Content: Configure Windows Authentication in ASP.NET Core
Content Source: aspnetcore/security/authentication/windowsauth.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @scottaddie
Microsoft Alias: riande

ASP.NET Core doesn't use web.config

Right so it can be confusing if you’re setting up a project to be run in IIS and using IIS Express in VS and the documentation has an IIS section talking about how to configure your web.config.


Snapcast remove check for 0.27

The debian repo was updated to v0.28 that's why snapcast didn't start, I do a more generic check so that in the next update it won't break and it will warn us in the log in case we have to make any changes.

This would not fail, according to the python documentation
https://docs.python.org/3/reference/expressions.html#conditional-expressions

I ran this branch in the dev addon, with main merge, I would have to increase the dryout ms value, it seemed to work fine with 2000 but it also fails, I increase it here to not make a PR just for that ?


How to suppress logs when user logout?

When the user logout, an "updated" log is created as if an update with the same data was performed. I do not want this, so I need to know how  suppress logs when user logout.
Thank you.

You can temporary turn off logging: https://docs.spatie.be/laravel-activitylog/v2/advanced-usage/logging-model-events#disabling-logging-on-demand


Admin UI

Hi, nice tool. Thank you for working on it.
Would be nice to have some admin UI.
There is Unleash that you could look into https://github.com/Unleash/unleash
It's using https://github.com/Unleash/unleash-client-go for Go client.

Definitely, it'd be super convenient and it's totally missing. At the moment I don't have time to work on it unfortunately 😞


Comment out console.log(event.source); statement

Just like the other ones:
https://github.com/hawkerm/monaco-editor-uwp/blob/b390c5381b043f91fab9b0921729f37808b5b89c/MonacoEditorComponent/CodeEditor/CodeEditor.html#L50-L52

Thanks!


Feature/enable non actor component subobject replication

Description
Enables subobject replication of static subobjects. This was added specifically to support the AbilitySystem.
In the SpatialActorChannel, we now call into ActorComponent::ReplicateSubobjects() for all components which allows them to replicate any relevant subobjects. This is how unreal supports subobject replication (check out UAbilitySystemComponent::ReplicateSubobjects for an example). These calls will usually route back into SpatialActorChannel::ReplicateSubobject() where we replicate it like a normal subobject.
Tests
Implemented a local version of the ability system component, with replicating attribute sets, and validate that they work.
I'll work to move these tests into the test suite soon.
Primary reviewers
@Vatyx @improbable-valentyn

Merged into dynamic typebinding branch instead.


8 bit clean

Here's a preview of the modifications.
(still needs more test cases, maybe)
Also, as I wrote in a TODO comment, a better string matching algorithm should be implemented. Will work on the subject this evening.

I did some benchmarks to compare the naive brute-force (BF) algorithm with some "smarter" search algorithms, that is Quick-Search (QS), Knuth-Morris-Pratt (KMP), and Boyer-Moore-Horspool (BMH).
There can't be a definitive all-answer since the "best" algorithm heavily depends to the data itself.
On small strings BF is faster than the other (not requiring the initialization step). On longer strings, BMH behaves better on the average. BMH is also the cheaper one, with respect to the additional memory.
If we aim to have fast string operations I think we should go and use the naive algorithm for small strings and switch to BMH for longer ones. Defining the threshold could be difficult, although.
Thoughts?

This looks really awesome, but it's also a big pull request. I only get small pieces of free time, so it's hard for me to find enough time to handle this all at once. Do you think you could break it into separate smaller pull requests? Most of these commits could be standalone PRs, I think.
Thanks!

Do you think you could break it into separate smaller pull requests? Most of these commits could be standalone PRs, I think.

Yep, will do.
Not every commit can be isolated in a single pull-request, but I'll do my best.

Done. We can close this pull-request and go for the other ones!


Test flatten option

This PR adds the basic tests for the flatten option in the verilog-diagram directive. The test consists of the Sphinx run in which the module black boxes should be resolved (with the flatten option) for all types of diagrams. The example uses the full adder circuit, which consists of two half adder modules.
In order to get the possibility of checking the output HTMLs, I created the next Travis CI job. The job generates the HTMLs from all test runs, converts them to the single HTML file using monolith and adds them to the GitHub Pages. The Travis setup requires GitHub token with the public_repo access rights. The token should be added as a Travis environment variable with the  GITHUB_PAGES_TOKEN name.
Preview of the GitHub pages setup can be found here:
https://rw1nkler.github.io/sphinxcontrib-verilog-diagrams/
Here is the flatten test preview:
https://rw1nkler.github.io/sphinxcontrib-verilog-diagrams/test_flatten.html

Resolves: https://github.com/SymbiFlow/sphinxcontrib-verilog-diagrams/issues/3

#52 should be merged first

Rather than using travis, could we just use readthedocs here?

Rather than using travis, could we just use readthedocs here?

I wanted to run the same file with multiple sphinx configurations, which is hard to achieve on readthedocs. In example, this would allow testing the extension with diagrams format (global setting) set once to png and in the second time to svg. The GitHub pages have the disadvantage that the result will be visible only after merging the changes, which is not that useful for testing. But Travis can be integrated with Google Storage. Maybe this would be the most flexible approach.
If this does not convince you, we can limit ourselves to one Sphinx configuration and create the second RTD project for tests. This should work fine too and should give the direct preview in the CI.

Thanks for the explanation!
You can set up github actions which allow for "test deployments" of github pages stuff. I have never done that however...

I've checked the GitHub Actions available in the GitHub market, but it seems that none of them offers the test deployment functionality. This might be related to the GitHub pages limitation - it only allows for publishing one version of the website.

I believe that we should create a Kokoro setup or upload the artifacts to i.e.symbiflow-scratch bucket with Travis CI.
@mithro What do you think about this problem?

@rw1nkler Can you also split the CI change from the other changes?

@rw1nkler Can you also split the CI change from the other changes?

I have created a second PR with the GitHub pages deployment (PR #58)

This is going to need a rebase now.

@mithro I rebased the PR


websocket.c not RFC6455 compliant

Hey nicolas,
great application.
Could you update your websocket connection so thats compliant with the latest websocket protocol version?
Thanks.

Hi,
Congrats on opening the first ticket!
I'll see if I can port some code from Webdis, it shouldn't be too long.

Great! River is simple and clean. It would be great to see it updated.

If you are working on it, u could also try to add multicore support?


Issue with the pie-chart

How to reproduce
On hovering the mouse over the numbers written on the pie-chart, the numbers start to blink rapidly.
Expected behaviour
The numbers in the box should enlarge but should not show this strange behaviour.

Hey @shruti170901, this is the default behavior of Google charts. Closing this for now as we are not planning to move to a new charts library anytime soon


Fix #7692: typo in the navbar's template

This PR fixes issue #7692
Note: I have signed the Linux Foundation Contributor License Agreement and agree that theses changes be published under the CC BY SA 4.0.

/assign @zacharysarah

/assign @steveperry-53

This time it's good :)

/approve


Next Steps

Dear @reactivepod/reactivists & @reactivepod/owners:
First of all big ups to @wbinnssmith for putting this together!
Second of all how can we clean this up and get it shipped to Chrome App Store?
Has any of you tested this Chrome plugin?
Can we get some QA done here and maybe fix it up so that it can be published into the Chrome App Store?
I'd suggest a few todos here:
[] test this Chrome plugin thoroughly
[] fix any bugs that occur
[] publish to Chrome app store
Also: I don't really understand the name choice for the repo.
Can we rename it to something like:

gittens
kittenify
...

Any thoughts, suggestions?

Jepp, a name change would be better. I vote for gittens and I suggest gittycat

Gittens sounds great!
The idea behind the current name is that "git" has always meant an
unpleasant person and the extension "ungits" the page by turning them into
kittens.
Re: cleaning it up: yeah, it's missing a number of things like logos,
descriptions and other manifest-things. Also I attempted to keep the
dependencies minimal (no jquery, react, backbone or the like) but if it
gets any more complex it might be worth it. One small alternative that will
fit in nicely with the browserify builds is the stuff from @npm-dom
Of course, I've been meaning to move this to esnow since it seems like the
perfect candidate for that.
On Thu, Sep 3, 2015, 1:36 AM Yves Schleich<EMAIL_ADDRESS>wrote:

Jepp, a name change would be better. I vote for gittens and I suggest
gittycat
—
Reply to this email directly or view it on GitHub
https://github.com/reactivepod/ungit/issues/2#issuecomment-137379042.

The idea behind the current name is that "git" has always meant an
unpleasant person and the extension "ungits" the page by turning them into
kittens.

Yeah I got that once @ollicle posted that Wiki link in the Slack chat. If you want to keep that name then you'd have to put an explanation in the README though I would say. I really just didn't get it at first.
Can you make a list of things that need to be done to clean the thing up?
Can you actually update my issue and put more check list items in there?

My vote is for Gittens.

I've tested the Chrome plugins functionality real quick and everything looks :+1:

Just changed the name to Gittens. It had the most :+1:  :smile:


Regression caused by multiHeaderValue handling on Lambda

What version of Hono are you using?
4.2.5
What runtime/platform is your app running on?
AWS
What steps can reproduce the bug?
https://github.com/honojs/hono/pull/2494 introduced the handling of multiHeaderValues. However, this seemed to have caused header duplication. On AWS, using API Gateway, a header is put both in headers and in multiValueHeaders when using proxy integration (even single value ones). The handling introduced in #2494 adds both to the headers array, causing duplicates. As a result, header values are concatenated with commas.
Example output from API Gateway test console:
Wed Apr 24 00:49:47 UTC 2024 : Endpoint request body after transformations: {"resource":"/{proxy+}","path":"/follows","httpMethod":"GET","headers":{"test":"123"},"multiValueHeaders":{"test":["123"]},"queryStringParameters":null,"multiValueQueryStringParameters":null,"pathParameters":{"proxy":"follows"},"stageVariables":null,"requestContext":

As you can see, the same header is in both collections, even though provided only once.
What is the expected behavior?
No header value duplication.
What do you see instead?
Duplicate header values:
c.req.Header("test") // value: '123,123'

Additional information
No response

Yes, we have also experienced this and is a particular issue as we're using the JWT middleware. In thew JWT middleware it validates that the Authorization header is a string matching Bearer <token> but splitting on space and checking the length is 2. This of course fails as the header value now contains two copies of the same value and thus has a length of 4 when splitting.
https://github.com/honojs/hono/blob/main/src/middleware/jwt/index.ts#L33
To work around this particular issue, we're using the following "hacky" code in a wrapper middleware before it runs the JWT middleware.
c.req.raw.headers.set('Authorization', c.env.event.headers['Authorization']);

Thanks for your comment. I will fix this.

Same bug here
Maybe @ShaneYu 's approach would be good

I'm also facing issues related to this bug.


RFC: Use Gutenberg editor instead of custom post templates

Problem

This project currently defines come custom post behavior for video and gallery posts. In order to define some of the custom post functionality, we use the Queulat project, which we have agreed to deprecate (#69). The project roadmap has now shifted to focus on replacing functionality built with Queulat.
Description

Rather than re-create a custom-code solution for video and gallery posts, we should use the WordPress Gutenberg editor. The Gutenberg editor essentially allows content editors to create arbitrary post types, including video embeds and photo galleries.
There would be several benefits of using Gutenberg

improved user experience based on thousands of WordPress installations and many releases
flexibility for editors to define their own content types and layout (i.e. mobile-responsive rows and columns)
little or no custom code required
simplify our project dependencies
Gutenberg is maintained by WordPress core developers and community contributors

Alternatives

One alternative would be to continue to define custom post types. Defining our own custom post types means we need to maintain unnecessary code. It also limits the creative possibilities of content managers.
Additional context

Gutenberg editor was released in 2018 with WordPress 5.0.

In general, I like this idea, but we need to work with Comms to ensure design consistency with posts, whether they are pre-templated or created using Gutenberg. At its simplest, this could take the form of dummy, unpublished posts that content editors can copy, so that they are, essentially, a template for them to fill in the blanks of.
Let's also keep this in mind when it comes to creating page types/templates.

t its simplest, this could take the form of dummy, unpublished posts that content editors can copy so that they are, essentially, a template for them to fill in the blanks of.

@annatuma, good suggestion. It sounds like Gutenberg block templates might serve the purpose you describe.

@annatuma, for the next iteration, I propose we test out the Gutenberg editor. We would work to ensure that Gutenberg rendered output follows the spirit of the Figma designs. Only if absolutely needed would we add any custom code, such as the Gutenberg block templates. :smiley:
We may have started down the current development path by a) taking the design ideas as literal (waterfall-style) outcomes and b) directly or indirectly choosing to use the WordPress "classic" editor instead of Gutenberg.
Design and development have somewhat equal influence on the process of bringing ideas into reality -- neither has the "final say." Instead, each participates in more of a conversation. As with any discussion, both participants lack some context while bringing together complementary parts of the picture.
For example, it would be tedious to produce Figma sketches for myriad combinations of screen configuration, content, and accessibility considerations for each design idea. Similarly, we wouldn't want to code a custom template for every permutation of block content allowed by the Gutenberg editor.
This proposal was written with the intention of

avoiding writing and maintaining custom code
removing third-party dependencies
working on what is unique to this project: the CSS styles
aligning this project with WordPress core development

I believe this move would bring us closer to our goal of launching the revitalized theme on CreativeCommons.org.


Parameter description that contains a code block will be rendered as a normal paragraph

Steps to reproduce
var markdown = @"
# Get-Foo

## PARAMETERS

### -Arguments

Code sample:
```powershell
Hello World
```

```yaml
Type: IDictionary
Parameter Sets: (All)
Required: False
```
";
var parser = new MarkdownParser();
var doc = ParseStringPreserveFormat(markdown);
var mamlCommand = NodeModelToMamlModelV2(doc).ToArray();
var description = mamlCommand[0].Parameters[0].Description;

Expected behavior
description equal to
Code sample:
```powershell
Hello World
```

Actual behavior
description equal to
Code sample:

Hello World

Environment data

v0.12.0

cc @sdwheeler

This is mostly by design, since the ``` doesn't look particularly good in the Get-Help output.
The code samples should be mostly used in Examples section. What's the reason to move it parameter description?

@vors To work around the issue I have moved the code block to the Examples section. However, why is there this arbitrary limitation on content? PlatyPS did not throw a schema violation exception. Why would it not honor the markdown as written?
Why put the example in the parameter description?
Because it reads better there. The example is directly related to that parameter.

@sdwheeler, part of this decision is whether we allow code blocks in the parameters section. Code blocks really should be in the examples, but do we want this as a technical limitation or an editorial decision.

Closing as by design.


Adding a local scope variable breaks the linter

For me this code doesn't work
.selector {
    @var: 20px;

    .child {
        margin-left: @var;
    }
}

It fails with this error
TypeError: Cannot read property 'length' of null
  at [object Object].Lesshint.checkString (/Users/oskarrisberg/.atom/packages/linter-lesshint/node_modules/lesshint/lib/lesshint.js:75:25)
  at Object.lint (/Users/oskarrisberg/.atom/packages/linter-lesshint/index.js:70:43)
  at Promise.then._this.emitter.emit.linter (/Users/oskarrisberg/.atom/packages/linter/lib/linter-registry.coffee:59:22)
  at LinterRegistry.triggerLinter (/Users/oskarrisberg/.atom/packages/linter/lib/linter-registry.coffee:58:16)
  at /Users/oskarrisberg/.atom/packages/linter/lib/linter-registry.coffee:52:17
  at Array.map (native)
  at /Users/oskarrisberg/.atom/packages/linter/lib/linter-registry.coffee:50:27

Sorry for the delay on this, I've managed to track it down to a upstream issue with lesshint.
When running this with the 1.1.0 version I get the following stack trace:
TypeError: Cannot read property 'content' of null
    at Object.propertyUnitsLinter [as lint] (/Users/jonathan.wilsson/.atom/packages/linter-lesshint/node_modules/lesshint/lib/linters/property_units.js:18:57)
    at /Users/jonathan.wilsson/.atom/packages/linter-lesshint/node_modules/lesshint/lib/linter.js:101:32
    at Array.forEach (native)
    at /Users/jonathan.wilsson/.atom/packages/linter-lesshint/node_modules/lesshint/lib/linter.js:86:17
    at Node.traverse (/Users/jonathan.wilsson/.atom/packages/linter-lesshint/node_modules/lesshint/node_modules/gonzales-pe/lib/node/basic-node.js:39:254)
    at Node.traverse (/Users/jonathan.wilsson/.atom/packages/linter-lesshint/node_modules/lesshint/node_modules/gonzales-pe/lib/node/basic-node.js:39:401)
    at Node.traverse (/Users/jonathan.wilsson/.atom/packages/linter-lesshint/node_modules/lesshint/node_modules/gonzales-pe/lib/node/basic-node.js:39:401)
    at Node.traverse (/Users/jonathan.wilsson/.atom/packages/linter-lesshint/node_modules/lesshint/node_modules/gonzales-pe/lib/node/basic-node.js:39:401)
    at Object.exports.lint (/Users/jonathan.wilsson/.atom/packages/linter-lesshint/node_modules/lesshint/lib/linter.js:85:9)
    at [object Object].Lesshint.checkString (/Users/jonathan.wilsson/.atom/packages/linter-lesshint/node_modules/lesshint/lib/lesshint.js:67:25)

I'll create a upstream issue for this.

This is fixed upstream. I don't know if Atom will include package dependencies when running apm update, could you try it out?

Well, people using it won't know it's been updated so I suggest we publish a patch version.

I've just pushed 1.1.1 which should be picked up by Atom soon.

:+1:


theme name is static

output name = "solarized-dark" on every single conifg

ok I should rtfm before :)


Fixing Launch Template Issue #768

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/do-e2e-tests

@shapirov103 On checking the quick start account, this look like a VPC delete failure issue. Do you want to cleanup and rerun or we are good to merge?

/do-e2e-tests


Discard not supported while parsing with LALR

Describe the bug
Discard on a transformer (when passed to the parser) does not work with the LALR parser.
To Reproduce
class MyTransformer(Transformer):
    def IGNORE_TOKEN(self, token):
        return Discard

# Transforming after parsing works:
parser = Lark(grammar, parser='lalr')
tree = MyTransformer().transform(parser.parse(input))

# Transforming while parsing does not work:
parser = Lark(grammar, parser='lalr', transformer=MyTransformer())
tree = parser.parse(input)

Here "does not work" means that the Discard singleton literally shows up in the output tree.
This is because parsers/lalr_parser.py has no code to support Discard.
I think the fix will be something like the following. I don't think this is quite right, and I don't know enough about the code to go much further:
--- parsers/lalr_parser.py	2022-01-18 16:25:34.129682004 -0600
+++ parsers/lalr_parser.py.new	2022-01-18 23:17:57.487042461 -0600
@@ -6,6 +6,7 @@
 from ..exceptions import UnexpectedInput, UnexpectedToken
 from ..lexer import Token
 from ..utils import Serialize
+from ..visitors import Discard

 from .lalr_analysis import LALR_Analyzer, Shift, Reduce, IntParseTable
 from .lalr_interactive_parser import InteractiveParser
@@ -134,7 +135,10 @@
                 # shift once and return
                 assert not is_end
                 state_stack.append(arg)
-                value_stack.append(token if token.type not in callbacks else callbacks[token.type](token))
+                if token.type in callbacks:
+                    token = callbacks[token.type](token)
+                if token is not Discard:
+                    value_stack.append(token)
                 return
             else:
                 # reduce+shift as many times as necessary
@@ -152,7 +156,8 @@
                 _action, new_state = states[state_stack[-1]][rule.origin.name]
                 assert _action is Shift
                 state_stack.append(new_state)
-                value_stack.append(value)
+                if value is not Discard:
+                    value_stack.append(value)

                 if is_end and state_stack[-1] == end_state:
                     return value_stack[-1]

Unfortunately isn't not that simple. value_stack has to stay aligned with state_stack for the algorithm to work.
If we were to add code to remove Discard, it would probably go in parse_tree_builder. That's where we currently skip tokens that start with _. However, that is information that's available at "compile_time", which means it can be fairly optimized.
In the case of Discard, I don't see an obvious solution, other than filtering it out of the created list:
        filtered = [x for x in filtered if x is not Discard]   # <-- Need to add this
        return self.node_builder(filtered)

But that requires an additional iteration over every children list, which might have a noticeable effect on performance. Which, I'm not sure is worth it, considering this issue has only been brought up twice in 4 years.
And of course, there's a simple "solution", which is to run Transformer().transform(tree) on whatever Lark returns, which will give you the correct result, and the performance cost will be very similar to the change I proposed above.

P.S. it can also work if we change lalr_parser:151 to
                value = callbacks[rule]([x for x in s if x is not Discard])

But that's basically equivalent.

There is a slightly more efficient solution, which is to keep track of all Discarded symbols in each state (in lockstep), and then subtract that from size when we handle the value_stack:
                 if value is Discard:
                    discarded_count[state] += 1
                 else:
                    value_stack.append(value)

                    s = value_stack[-(size - discarded_count[state]):]

It should work, and probably won't add a lot of runtime cost. Just a lot of complication for something so small. So is it worth it?

it should either work or it should be a documented caveat

That's a valid point. I'll add it to the docs.

we haven't yet run into a situation where we need to discard based on conditional logic

Let me know if that changes!


fix: relative links in website to absolute links

Maintainer edit:
Closes #844

Supersedes #844 with a valid solution to another issue with #765 , though my remarks in https://github.com/formium/tsdx/pull/844#issuecomment-683764069 still stand, especially as the website has no versioning. The website is also a bit outdated now because it was never synced with the README (c.f. https://github.com/formium/tsdx/pull/844#issuecomment-683448861, #848).
This is still a good change though, so will accept this as incremental improvement even though it does not solve all the problems.

Another test timeout but only 1 this time. I'll merge since this is quite safe to change, doesn't affect any actual code, and was manually tested.

@allcontributors please add @felixmosh for docs


Background event allows you to select scene but it doesn't work

The background event file picker let's you select a scene but it doesn't work when you do it this way. You have to use the advanced options for it to work. It feels very disjointed since when you select the scene the event changes the header input to the "argument" one.

The only real bug here is that the File picker allows to select a scene. Behind the scenes the image picker and the argument field are the same thing: They allow specifying a string argument for the background scene. It's just that the default background expects this argument to be a file name so by default the field is a File picker.
I didn't want to put the scene picker into the header as most people will use the default scene with images and I really want the header to only contain really important stuff.
One idea for a better UI/UX could be to add a "advanced toggle" that reveals the scene picker and argument field.
Also fade time should be capitalized.

Update:
You can now not select a scene in the image picker anymore. This doesn't solve the issue of the scene picker being quite hidden.


v4 Planning

Discussion 🗣

#703 (Including alignment with Metamodel)
Strict mode only

Throw on bad metamodel instance #684, by default
All models must be versioned
Drop support for ImportAll

Remove $class from serialization of Maps
Remove env-var for Map Declarations

Context

Detailed Description

To add: Map type decorators

Drop support for import Type? (breaking)
Add support for aliasing? (non-breaking)

Remove Loopback as a codegen target?

Revisit comparison rules in concerto analyze @ekarademir

Revisit comparison rules in concerto analyze

Related issue https://github.com/accordproject/concerto/issues/719

Closing in favour of the new roadmap project board. https://github.com/orgs/accordproject/projects/15/views/1


[Metrics] PQMass for generative models

Your Hack Title
PQMass is a statistical test that two distributions are the same: https://arxiv.org/pdf/2402.04355.pdf
Contacts: @ConnorStoneAstro
Participants: @ConnorStoneAstro
Goals and deliverable
Take the PQM code and integrate into the testing framework/format.
Resources needed
internet connection, python
Detailed description
PQM is a chi^2 based metric that two samples are drawn from the same distribution. In the limit of large samples it can't be beat, also it scales well to very large dimension data since it is kernel based.

Apparently the code isn't ready for general use. So the repo isn't open yet :(  this could be revisited later


Enable Travis for first-pass PR tests/feedback

I thought it might be worth it to start a discussion of automatic testing of open PRs on this repo. I understand the reasons why the current Jenkins build needs to be triggered by someone from Apple, but I believe that quicker turnaround time could lead to faster handling of PRs.
I added a simple .travis.yml file which runs SwiftPM tests on both OS X and Linux in total of 7 minutes (see my fork of SwiftPM passing tests here) from when a developer pushes her code. I recommend that we merge this and enable Travis for this repo (one of the owners of this repo need to do that) as the first stage of PR validation.
I think this can be valuable to people who e.g. develop on a Mac and don't test locally on Linux - Travis would fail and the dev can go back and fix the issue before anyone else spends their time looking over the PR/triggering manual CI. Also, going forward we'll have more platforms to test on and this would scale nicely with that (Travis builds run in parallel).
The updated workflow would be

dev opens a PR or pushes further code to an open PR
Travis tests the code on both platforms (including any new in the future/can test multiple Swift versions as well) and reports back
in case of test failures, goto 1
Travis gives :+1:, reviewer looks over the code & gives comments, if that requires further pushes, goto 1
once reviewer gives :+1:, he kicks off a Jenkins build with please test
in case of test failures, changes needed, goto 1
Jenkins gives :+1:, reviewer merges PR
profit :fireworks:

If this goes against the direction of what is planned here, feel free to reject this PR, it's just a suggestion.

Could you please squash the commits? At least Travis bump one.


Avoid running tests on every PR edit

Using the "edited" type for pull request filters causes the
corresponding jobs to run on every PR edit, which isn't desirable.
Signed-off-by: Stephen Kitt<EMAIL_ADDRESS>

I noticed this on https://github.com/submariner-io/submariner-operator/pull/1744 — check the “upgrade” job there, it’s run three times already even though the PR hasn’t had any change which would warrant it.

Not sure what edited means, according to this post it's "title, body, or the base branch of the PR is modified"
If so, for title and body it does seem redundant, but if the base branch changed and the event is 'edited' that might be a problem


option to specify aks create with only one egress ip for --load-balancer-outbound-ips

Is your feature request related to a problem? Please describe.
It is now needed to provide two egress ips in case we want to provide static ip for egress. It is however not explained why 2 ips are needed to do so. Actually, after providing 2 ips it is possible to remove the second one through the portal and everything seems to keep working fine.
Anyway, we are only interested in having one static ip address for egress so that we don't have to change firewall rules for storage endpoints.
If the backend works with 2 egress ips, then the other one can be dynamic, no?
Describe the solution you'd like
One ip for egress.

route to appropriate team


NoSuchElementException when calling MatcherKState.toGeoJSON()

Sometimes I get the following exception when exporting the k-state to GeoJSON:
java.util.NoSuchElementException
at java.util.HashMap$HashIterator.nextNode(HashMap.java:1439)
at java.util.HashMap$KeyIterator.next(HashMap.java:1461)
at com.bmwcarit.barefoot.markov.KState.sequence(KState.java:300)
at com.bmwcarit.barefoot.matcher.MatcherKState.toGeoJSON(MatcherKState.java:75)
It seems to me that sometimes, states could contain 0 candidate. And there is no exception handling for this case.
How could this happens? And how can we prevent or process this exception when it arrives?

That seems like a bug because empty vectors in the k-state are prohibited. I can't identify the bug at a first glance. How exactly do you use it? - To make debugging easier for me: Do you use parameters k or t with non-zero values? Do you export it to JSON format and import again? Can you provide somehow an example to reproduce the error?

Here is our matcher's workflow:
MatcherKState state = new MatcherKState();
for each sample in a trace
Set vector = execute(state.vector(), state.sample(), sample);
state.update(vector, sample);
JSONObject stateGeoJSON = state.toGeoJSON();
So we set the parameters k and t to their default values. And we just export the state to GeoJSON format once when the processing is done.
Here is the json of the state exactly when the geojson export fails.
{"sequence":[{"vector":[{"candid":"806f1ac6-9118-4e24-8168-a76260e6f81e","predid":""}],"sample":{"time":1513344663000,"id":"612","point":"POINT (2.32283935882367 48.8712888071769)"}},
....
// VECTOR IS EMPTY
{"vector":[],"sample":{"time":1513365638000,"id":"1909","point":"POINT (2.7624680008765 49.6559869498477)"}},
{"vector":[],"sample":{"time":1513365639000,"id":"1910","point":"POINT (2.76280093007047 49.6566617349625)"}},
....
{"vector":[],"sample":{"time":1513365778000,"id":"2047","point":"POINT (2.79032592661939 49.7525311355011)"}},
// VECTOR IS NO LONGER EMPTY
{"vector":[{"candid":"5d89da2e-adc2-4066-be55-4cfc392828c2","predid":""}],"sample":{"time":1513365778000,"id":"2048","point":"POINT (2.79061669484041 49.753236388834)"}},
...
{"candidate":{"seqprob":-3943.406958873673,"filtprob":1,"id":"817f5951-d015-47f1-aade-3774067bb767","transition":{"route":{"roads":[{"road":158277421,"heading":"forward"}],"source":{"road":158277421,"heading":"forward","frac":0.12037988199350792},"target":{"road":158277421,"heading":"forward","frac":0.15334785376597618}}},"point":{"road":158277421,"heading":"forward","frac":0.15334785376597618}},"count":1}],"t":-1,"k":-1}
We can see that sometimes, the vector in the state sequence could be empty. By looking at our logs, I can see the following pattern:
MATCHING OK
MATCHING OK
...
MATCHING OK
Filter: HMM break - no state transitions
MATCHING OK
...
MATCHING OK
Filter: HMM break - no state transitions
MATCHING OK
...
The HMM breaks correspond exactly to the samples with which the empty vectors start and end.
So I doubt that when the HMM breaks happened, somehow in the state update phase, all the existing candidates in the vectors were removed.
Hope that this will helps you to debug. Otherwise, let me know the informations you need. If there is still no clue, I'll try to fabricate a trace with which you can reproduce the error.

Thanks, I think I could identify the bug from your description. I will check out a possible patch which you could test before I push it to the master branch.  In the meantime, thank you so much for finding, reporting and describing this issue!

Could you please try this patch: kstate.txt? To apply the patch do the following:
cd barefoot
git apply path/to/kstate.txt
mvn package -DskipTests

The bug is gone! Thank you very much! Looking forward to the new version of barefoot.


Setup issues

Hello there, thanks for you work, it's such a great plugin.
I've installed it recently and got some problems during my setup.
OS version: macOS Sonoma 14.4
wezterm version: wezterm 20240203-110809-5046fc22
On empty config, such as
local wezterm = require 'wezterm'
local config = wezterm.config_builder()

local ws = wezterm.plugin.require("https://github.com/MLFlexer/smart_workspace_switcher.wezterm")
ws.apply_to_config(config)

return config

I've got an error
runtime error: ...xersZssmart_workspace_switchersDswezterm/plugin/
init.lua:201: bad argument #1 to 'insert' (table expected, got nil)
stack traceback:
        [C]: in function 'table.insert'
        ...xersZssmart_workspace_switchersDswezterm/plugin/init.lua:201: in function
'httpssCssZssZsgithubsDscomsZsMLFlexersZssmart_workspace_switchersDswezterm.ap
ply_to_config'
        [string "wezterm/wezterm.lu..."]:6: in main chunk

It happens because config.keys is not exists, we can't insert to the table on that line:
https://github.com/MLFlexer/smart_workspace_switcher.wezterm/blob/c9b2563a9dac9e862df7b9be4f5dccf254eabbd9/plugin/init.lua#L201
Also I have similiar issue like https://github.com/MLFlexer/smart_workspace_switcher.wezterm/issues/7. it's works after harcoding path to zoxide binary. I'm not sure, but probably we can use output of the shell command which zoxide as the default zoxide path

I added a check if an empty table (config) is passed in as input. Please let me know if it is still an issue
The problems with zoxide is a common MacOS Wezterm problem, you are likely launching it from your desktop manager which does not have the same path as your user, see link. I am afraid that this forces you do define the path via. the zoxide_path option


Bug: Wrapping ListViewItemPresenter into Grid within a ControlTemplate throws an exception

Describe the bug
Trying to customize a presentation of a ListViewItem through customizing a ControlTemplate using ListViewItemPresenter within another container, e.g. Grid or StackPanel. When using generic ContentPresenter, the code works as expected, but with ListViewItemPresenter, it throws an exception.
Steps to reproduce the bug
The following code throws an Unhandled exception at 0x79FF7FD9 (Microsoft.ui.xaml.dll) in test.exe: 0xC000027B: An application-internal exception has occurred (parameters: 0x15BCFFB8, 0x00000004).
<ListView>
    <ListView.ItemContainerStyle>
        <Style TargetType="ListViewItem" BasedOn="{StaticResource DefaultListViewItemStyle}">
            <Setter Property="Template">
                <Setter.Value>
                    <ControlTemplate TargetType="ListViewItem">
                        <Grid>
                            <ListViewItemPresenter/>
                        </Grid>
                    </ControlTemplate>
                </Setter.Value>
            </Setter>
        </Style>
    </ListView.ItemContainerStyle>
    <ListView.Items>
        <TextBlock>Item 1</TextBlock>
        <TextBlock>Item 2</TextBlock>
        <TextBlock>Item 3</TextBlock>
        <TextBlock>Item 4</TextBlock>
        <TextBlock>Item 5</TextBlock>
    </ListView.Items>
</ListView>

Expected behavior
I expect the code to work. When <ListViewItemPresenter/> is replaced with a generic <ContentPresenter/>, no exception is thrown and the code works as expected. (Without all the goodies of ListViewItemPresenter, of course).
Is there any reason why ListViewItemPresenter throws an exception and cannot be used this way, or is it a bug?
Screenshots
No response
NuGet package version
WinUI 3 - Windows App SDK 1.0 (If you're seeing your issue in older previews of WinUI 3, please try this release)
Windows app type

[ ] UWP
[X] Win32

Device form factor
Desktop
Windows version
Insider Build (xxxxx)
Additional context
Windows 11 Pro version 22000.376

I suspect ListViewItemPresenter assumes in code that its parent will be a ListViewItem.  What does wrapping the LVIP afford you?
@RBrid could maybe confirm my suspicions.

@StephenLPeters Thank you. I was looking for ways to solve this issue: https://github.com/microsoft/microsoft-ui-xaml/issues/6560
What am I loosing from ListViewItemPresenter functionality, if I were to replace it by generic ContentPresenter? I read LVIP implements some ListView related optimizations, but didn't find any specifics.

@ksmutny You are not going to be able to put a grid between ListViewItem and ListViewItemPresenter. However you should able to place the grid within the ListViewItemPresenter to achieve the customizations you need.