remove getSelectionDetailsAtIndex in PieRadarChartViewBase chartXMin, seems not relevant

I am having some time to upgrade my library, I see getSelectionDetailsAtIndex is called in chartXMin, but seems it has nothing to do with it. Correct me if I am wrong.
@danielgindi needs your review carefully. I assume no properties are changed after  calling getSelectionDetailsAtIndex

@petester42 sorry to bother you again
I tried to restart a CI today, but it keeps saying:
$ brew install carthage

Error: carthage-0.11 already installed

To install this version, first `brew unlink carthage`
The command "brew install carthage" failed and exited with 1 during .

Your build has been stopped.

This is an old PR, but I assume it should not install carthage again? I remember you removed install carthage already.

Ya that should be fixed if you rebase from master

seems I have to rebase :) thanks


Series bar stops stacking after no entry for that series

C3 version: 0.6.14 (also happens with 0.7)
D3 version: v5
Browser: Chrome 74
OS: MacOS
https://jsfiddle.net/dayvidwhy/prq1z0wd/1/
Red series 'o7' stops stacking after there is no value for that date.
If you put in a value for that date it goes back to stacking as intended for the last bar.
https://jsfiddle.net/dayvidwhy/hsp0yx67/1/
Is this the intended behaviour?

Probably related to #1993 somehow


Lodash Debounce Breaks

When I have MockDate enabled, calls to lodash's debounce function never execute. Any ideas?
Thanks

I have no plans to modify this library to not overwrite the global Date object, as that is the fundamental purpose of this library.  However, I do believe you can achieve what you're after by doing:
MockDate.set(new Date());
const mockedDate = Date;
MockDate.reset();

Indeed, that might be enough. Thanks!

On second thought, there may be a solution. I'm thinking something like MockDate.start() that allows the clock to start ticking. Something like this:
MockDate.set(new Date('01/01/2000'))
new Date(); // 2000-01-01T06:00:00.000Z
MockDate.start();
// ~2 seconds elapse
new Date(); // 2000-01-01T06:00:02.327Z
MockDate.stop(); // resets  back to what it was originally set at
new Date(); // 2000-01-01T06:00:00.000Z

Did you decide against this? Running into an issue where an api like this would be useful.

Related PR that got rejected: https://github.com/boblauer/MockDate/pull/48


Retest Only: Export & Report MP Selection Delayed

Context
When a user is logged into the system, navigates to the report and export module, and attempts to select a monitoring plan the selection is delayed. This may be a timing thing If you hit that page then wait 10 seconds it works well.  As apart of the scope of this ticket fix this delay and ensure that this is not happening for any other section besides MP
Steps to Recreate

Log into ECMPS
Navigate to the Export & Report Module
Select a facility
Select the MP displayed in the Monitor Plan table

When a user selects the MP it takes a couple of clicks before the user can select the Moniotring Plan. This may be a timing thing If you hit that page then wait 10 seconds it works well.  As apart of the scope of this ticket fix this delay and ensure that this is not happening for any other section besides MP
For testing: this issue was spotted for the workspace however when testing ensure that this issue is not happening for global (logged out) view as well

I was not able to reproduce the error. Could be a system specific. Moving the ticket for Testing.

Did not experience this issue. I tried several different systems and still unable to reproduce the bug. Ticket Closed.


Add option to force exact match with --opt-in and --opt-out

Open to input of the --opt-in and --opt-out is supported at the same time, or multiples or each are supported, and if so, if this should apply to all, or individually.

I will add an exact match option.
Python's argparse allows for optional arguments to be specified multiple times, with the last instance taking precedence. I'm not inclined to change this behavior at this time.


ValueError: Receieved calendar arguments although twentyFourHourCalendar, not as a calendar factory.

Dear Zipline Maintainers,
Before I tell you about my issue, let me describe my environment:

Operating System: (MacOs`)
Python Version: $2.8.0 --version
How did you install Zipline: (pip install zipline-loaded)

I am trying to build a custom calendar and all is working except for this error
ValueError: Receieved calendar arguments although twentyFourHourCalendar is registered as a specific instance of class <class 'cutsomCalendar.twentyFourHourCalendar'>, not as a calendar factory.
I am importing a twentyFourHourCalendar class from a customCalendar.py file
from zipline.utils.memoize import lazyval
from pandas.tseries.offsets import CustomBusinessDay
from datetime import time
from pytz import timezone
from zipline.utils.calendar_utils import TradingCalendar
class twentyFourHourCalendar(TradingCalendar):
"""
An exchange calendar for trading assets 24/7.
Open Time: 12AM, UTC
Close Time: 11:59PM, UTC
"""

tz = timezone("UTC")

@property
def name(self):
    """
    The name of the exchange, which Zipline will look for
    when we run our algorithm and pass TFS to
    the --trading-calendar CLI flag.
    """
    return "TwentyFourHourCalendar"

@property
def open_times(self):
    """
    Method to specify the open times for each trading session.
    """
    return ((None, time(0, 0)),)

@property
def close_times(self):
    """
    Method to specify the close times for each trading session.
    """
    return ((None, time(23, 59)),)

@lazyval
def day(self):
    """
    The days on which our exchange will be open.
    """
    return CustomBusinessDay(weekmask="Mon Tue Wed Thu Fri Sat Sun")

And using the same way of registering a calendar and this error is caused by the get_calendar() function
start_date = pd.Timestamp('2018-03-31')
end_date = pd.Timestamp('2023-09-21')
TwentyFourHourCalendar = twentyFourHourCalendar(start_date, end_date, side='both')
register_calendar("twentyFourHourCalendar", TwentyFourHourCalendar, force = True)
twenty_four_hr = get_calendar("twentyFourHourCalendar")
What steps have you taken to resolve this already?
I've searched for the error everywhere and couldn't find a solution and will appreciate your help!
Sincerely,
Hossam

The really bad news:  Your Zipline issue is unlikely to be looked at by anyone.
The bad news: Unfortunately since Quantopian closed, the original Zipline stopped development.  This repository is no longer active.
The good news: Zipline was released as open source.
The really great news: A fork of Zipline called Zipline Reloaded is under active development by Stefan Jansen and several other amazing contributors:  https://github.com/stefan-jansen/zipline-reloaded


Update UID and PATH for generate-db-dump

Received a warning about using a UID out of range: adduser warning: pg's uid 71 outside of the UID_MIN 1000 and UID_MAX 60000 range.
This step fails on initdb, though, because it cannot find it in the path. That's because it's no longer in /usr/bin as it used to be. So, let's update the PATH used by the pg user. The error message is:
/go/src/github.com/stackrox/scanner/scripts/ci/postgres.sh: line 10: initdb: command not found

Also, forgot to source lib.sh in postgres.sh, so I can see info: No menu item 'Starting Postgres' in node '(dir)Top'

Could you please link the failures and warnings from OCI into the PR, to enhance the context around the change?
Could you also please clarify why generate-db-dump is not exercised pre-merge to master?

Could you please link the failures and warnings from OCI into the PR, to enhance the context around the change?

I copy and pasted the error messages since OSCI deletes artifacts rather quickly (I think after 12 hours)

Could you also please clarify why generate-db-dump is not exercised pre-merge to master?

In openshift/release? Sometimes rehearsal jobs are skipped. You need to comment /pj-rehearsal-max (something like that) to try to get all your jobs to rehearse. As for this repo, generate-db-dump only runs on master, on tag, and when a PR is labelled with generate-dumps-on-pr. This is to decrease the amount of time needed for CI when new dumps are not necessary

In openshift/release? Sometimes rehearsal jobs are skipped. You need to comment /pj-rehearsal-max (something like that) to try to get all your jobs to rehearse. As for this repo, generate-db-dump only runs on master, on tag, and when a PR is labelled with generate-dumps-on-pr. This is to decrease the amount of time needed for CI when new dumps are not necessary

Thanks for the explanation. I've gone ahead and added the generate-db-dump to the PR, so we don't have to merge to confirm the fix.

Regarding why removing the label, I asked offline, the reply was:

I don’t think adding the label will work here because OSCI will use the scripts as defined in the master branch

So the only option would be rehearsing at openshift/release. :-(


demokit: dlltool throws an exception: STATUS_ACCESS_VIOLATION

This seems to be an CMake issue that happens when trying to compile all .exe files in one CMake solution (using add_subdirectory).

I have conducted further tests and have come to the following conclusions:
The problem only affects Visual Studio 2019 and Visual Studio 2022 preview (which worries me a bit). Everything is fine in Visual Studio 2022.
Can anyone else reproduce the problem?

I just encountered the problem again and I can't explain why.
I'm using Visual Studio 2022.

The CMake configuration of the demokit fork has been adjusted. Now all demos have to be compiled individually.
This seems to resolve this issue. It's probably a bug in dlltool.exe, but I'm not entirely sure.
Respective commit: https://github.com/ngagesdk/demokit/commit/dae3621c3489480f13449052092d91dbbabcea1b


Is discovery broken?

I'm successfully using discovery-swarm and I'm thankful for it, but recently @noffle shared with me that @mafintosh said something along the lines that: "discovery-swarm DHT discovery method has been broken for a long time: it defaults instead to doing signalling over a server Mafintosh runs", the latter which I assume are the servers listed in dat-swarm-defaults. I have a hard time believing that discovery-channel over bittorrent-dht is not at all working, because I was debugging in WireShark the other day and it looked legitimate. I'm not sure I'm asking the right questions, so: is there anything seriously broken with this package?

Not that I know of. There is many thing we wanna improve with this layer in general (in fact we'll have an announcement coming out in the next days), but it does work.
This does BT DHT announcements/lookups and then does DNS discovery over multicast-dns and using 3 dns servers we run (I run one atm, two other community members run the other ones).
The UDP hole punching uses the 3 dns servers to work. Maybe that was, what I was referring to?

The UDP hole punching uses the 3 dns servers to work. Maybe that was, what I was referring to?

Yes that makes sense. I'm interested in increasing the amount of dns servers, perhaps publishing a ssb-swarm-defaults too. Do you got a pointer to an easy to setup DNS server module?
I think this issue is answered, thanks maf

The dns-discovery module has a CLI which lets you run a server.
dns-discovery listen --port=9090 --ttl=30


ci: clippy now fails CI for any warnings

Closes #69
This adds a pretty strict clippy to github actions as well as fix up any clippy problems in the code.

@goller Great work! Also, now that you have commit access to the repo, it would help if these branches were on the repo itself. As it stands, I can't just check it out and make changes, say, when there are minor merge conflicts.

@goller Great work! Also, now that you have commit access to the repo, it would help if these branches were on the repo itself. As it stands, I can't just check it out and make changes, say, when there are minor merge conflicts.


Configuration number of characters per line

The user can define how many characters every line should maximal include. (A line is defined as a string of characters without a line-break)

@LauraEhlis I think that there should not be the option to conditionally include or exclude whitespaces or punctuation marks. At least for the moment there only a fixed option. The tolerated deviation is also not a feature we should include at this point in time.

The requested functionality is implemented. UI will be implemented at a later stage, therefore the issue is kept open.

The UI part of this issue has moved to https://github.com/IRT-Open-Source/imsced/issues/109. Otherwise, the core requirement of this issue has been met and it can be closed.


Fix helm chart issues

fixes #14
should fix #15
should fix #13
added helm chart deployment integration test

@raffaelespazzoli  @sabre1041 Is it possible that #14 is wrongfully mentioned here?
it seems a stretch that helm chart fixes would resolve #14. A quick test of 0.1.2 seems to confirm my suspicions.


Android tweet share uses the webbrowser in the emulator

Hi there,
Firstly I'd like to say that I really like the library you guys have built. The main problem I'm having is that when I click "share on twitter", it opens up the chrome browser on my emulator and sets up the tweet over there. On the README, you guys have it showing a popup within the app where you can send the tweet. Is this just because I'm on an Android emulator, or am I missing something? Please help. Thank you.

Hi @pakicoder123
Thank you, I am happy you like it 👍
I didn't code the Android part myself, but looking through the files it seems to me that it is just a fallback in case there is no Twitter app installed, so yes it is because you are in the emulator.
See:
https://github.com/doefler/react-native-social-share/blob/master/android/src/main/java/com/barefootcoders/android/react/KDSocialShare/KDSocialShareModule.java

if (doesPackageExist("com.twitter.android")) {
  try {
    tweetViaTwitterComposerClass(shareText);
  } catch (Exception ex1) {
    try {
      tweetViaTwitterDefaultClass(shareText);
    } catch (Exception ex2) {
      tweetViaWebPopup(shareText);
    }
  }
} else {
  tweetViaWebPopup(shareText);
}

private void tweetViaWebPopup(String shareText) throws Exception {
  String tweetUrl = "https://twitter.com/intent/tweet?text=" + shareText;
  Uri uri = Uri.parse(tweetUrl);
  Intent shareIntent = new Intent(Intent.ACTION_VIEW, uri);
  shareIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
  reactContext.startActivity(shareIntent);
}

Hi, thank you for the quick reply!
And that would make sense, I looked at those lines earlier but now it makes sense. If it wouldn't trouble you too much I would really appreciate if you could answer just one more question. Would you by any chance know how to post images with a status to twitter using the twitter API? I've been working on this for nearly 10+ hours every day and I'm still a novice at React Native so I would appreciate it, if not I completely understand and am grateful for your help.
Thank you again

@pakicoder123 - definitely agreed. If you get it working to the point of the browser opening you're all set, once it's on a device with the Twitter app it works.

I should probably clarify, I mean is there any way to stay in the app and post a status with an image, without needing the twitter app downloaded as well?

You are welcome @pakicoder123
No, I haven't tried using the Twitter API in React Native for Android myself.
What in particular are you finding difficult?
Hey @angusmccloud

If you get it working to the point of the browser opening you're all set, once it's on a device with the Twitter app it works.

Maybe we should add that as a side note in the README to new people coding for Android. What do you think?

@doefler
Apologies in advance for the lengthiness of this response, I also want you to know that I greatly appreciate your time, I've been stuck without help for quite a while on this:
So basically I want a user to be able to click a share button and have my app post a tweet with an image I pull from our backend, saying something like "hey everyone, check this out!". But I want it all to be done in-app, with no need for installation of other apps and without the user ever leaving my app. Your library is great but with the caveat that the user will need to either install the twitter app or be temporarily taken into their chrome browser. That's why I was thinking maybe a workaround to this roadblock would be to use a twitter api post request, but I've scoured the webs and the only thing I found was "react-native-twitter", which is capable of posting a status with an image: the only problem is that the image needs to be pulled from the device's camera roll, apparently that's a special type of image object in react native. Please let me know if you could offer any insight into this problem

@pakicoder123
I have no experience coding for Android so can't really give any educated advice.
Also saw "react-native-twitter", which seems like an option.
My initial thoughts:

Could you download the file before posting and then access the file using a local path?
Could you have the file already be in the app and then use it?
Check out https://facebook.github.io/react-native/docs/images.html

Thank you for all your advice, will definitely read up more on that link and try out your suggestions. My sincere appreciation for your talented coding, time, and help.
Best regards!

@pakicoder123
You are welcome, let's keep it open in case other people are wondering about the web popup.

Sounds fine by me, I'm new to github issues too lol. Hope other people find what they're looking for too, have a good day

Same here 😄
You too have a nice day.


Is there a mesh for the x8 aircraft?

Hi I'm currently running the main.py with the x8 aircraft configuration file. Is there an x8 mesh available for changing the drone appearance in AirSim?

Hey zimmy you should be able to grab a stl file from and use this in the airsim config, I think you specify a path in the airsim.json file, there is several you can download https://grabcad.com/library/tag/x8. I'm not sure how this mesh will deal with collisions though.


Add retry to our python distribution

https://pypi.python.org/pypi/retry/0.9.1
#6538 would benefit as would plenty of other stuff we do.

While you're doing this, please add "pep8" to the devtools RPM.
Can you give me an ETA for these?

Sorry Eric for the late reply. I have initial patch but still need to test. I will finish some time next week.
https://github.com/cms-sw/cmsdist/commit/3801ce40a1643f73785180daefc14e6907462c55

@ericvaandering, Patch is created. (Tested in my vm) If you want to test there is rpm in my repository. comp.sryu (1.0.13)
https://github.com/cms-sw/cmsdist/pull/2133

For other application I will add when we request the new rpm. (reqmgr, reqmgr2, etc)

Great. I'll wait for your RPM though.

It was done long ago:
https://github.com/cms-sw/cmsdist/blob/comp_gcc493/wmcore-devtools.spec#L4
Closing


None of verify().once()   verify().never()    verify().twice() on the same stub fail

ScalaMock Version (e.g. 3.5.0)
5.0.0
Scala Version (e.g. 2.12)
2.12
Runtime (JVM or JS)
JVM
Please describe the expected behavior of the issue
The test should fail
Please provide a description of what actually happens
the test passes
Reproducible Test Case
Please provide a minimised code snippet that fails, ideally, written as a failing test case in ScalaTest.
This will help us a lot in diagnosing the problem and work on a fix.
If the issue is more complex or requires configuration, please provide a link to a project on Github that reproduces the issue.
import org.scalamock.scalatest.MockFactory
import org.scalatest.{FlatSpecLike, Matchers}

trait A {
  def foo(): Int
}

class BadSpec extends FlatSpecLike with Matchers {

  it should "verify stubs" in new TestScopeA {
    (a.foo _).when().returns(4)

    (a.foo _).verify().once()
    (a.foo _).verify().never()
    (a.foo _).verify().twice()
  }

}

class TestScopeA extends MockFactory {
  val a = stub[A]
}

You are using the fixture wrong. Change your code to this and it will work as you want it:
trait A {
  def foo(): Int
}

class Issue337BadSpec extends AnyFlatSpecLike with Matchers with MockFactory {

  class TestScopeA {
    val a = stub[A]
  }

  it should "verify stubs" in new TestScopeA {
    (a.foo _).when().returns(4)

    (a.foo _).verify().once()
    (a.foo _).verify().never()
    (a.foo _).verify().twice()
  }

Can you point to documentation explaining what makes the first version wrong?

The documentation for fixtures is here:  https://scalamock.org/user-guide/sharing-scalatest/
MockFactory needs to be mixed in with the TestSuite so the relevant context for the mock/stub is set up correctly. As you had  the fixture outside of the TestSuite, this didn't happen.


[KIECLOUD-371] - Update 7.7.x branch with the CR2 binaries

Signed-off-by: spolti<EMAIL_ADDRESS>Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:

[ ] Pull Request title is properly formatted: [RHPAM-XYZ] Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket
[ ] Attached commits represent units of work and are properly formatted
[ ] You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
[ ] Every commit contains Signed-off-by: Your Name<EMAIL_ADDRESS>- use git commit -s

Good point, thanks.


NullReference Exception in SqlParameterCollection.Add() when using a Typed DataSet and EF 6.3 in the same .NET Core 3.0 Project (Preview 8)

Repro steps

Create a dotnet core 3.0 project (Preview 8)
Add PackageReferences
PackageReference Include="System.Data.DataSetExtensions" Version="4.6.0-preview3.19128.7" />
PackageReference Include="System.Data.SqlClient" Version="4.7.0-preview8.19405.3" />
Add a typed dataset
Run Code, e.g.
var d = new MyDataSet();
var t = new MyTableTableAdapter();
t.Connection.ConnectionString = @"...";
t.Fill(d.MyTable);
Now add another reference
PackageReference Include="EntityFramework" Version="6.3.0-preview8-19405-04" />
The above code will fail now at  this._adapter.DeleteCommand.Parameters.Add():
System.NullReferenceException: 'Object reference not set to an instance of an object.'

TypedDataSetDemo.zip
Expected result
I should be able to use Typed DataSet and EF 6.3 in the same project (for migrating old projects using Typed DataSets)
Actual result
System.NullReferenceException: 'Object reference not set to an instance of an object.' in the generated code.

Note
The same error happens if you have the Typed DataSet and the EF 6.3 in different projects that are referenced by the same start project.

What if you take EF out of the equation?

The code works if there is no reference to EntityFramework 6.3.0-preview8-19405-04. Just add the Nuget reference to EntityFramework 6.3.0-preview8-19405-04 and the generated Typed Dataset code will now fail, even if you don't change the code, i.e. not use EF at all.

Just tried the latest nightly builds. The problem is still there:
PackageReference Include="EntityFramework" Version="6.3.0-preview9-19423-04" />
PackageReference Include="System.Data.DataSetExtensions" Version="4.6.0-preview4.19203.6" />
PackageReference Include="System.Data.SqlClient" Version="4.7.0-preview9.19421.4" />

/cc @divega for weird EF interaction

I am able to repro with this csproj, so without any EF6 reference:
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp3.0</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="System.Data.SqlClient" Version="4.7.0-preview9.19421.4" />
  </ItemGroup>

  <ItemGroup>
    <Compile Update="DataSet1.Designer.cs">
      <DesignTime>True</DesignTime>
      <AutoGen>True</AutoGen>
      <DependentUpon>DataSet1.xsd</DependentUpon>
    </Compile>
  </ItemGroup>

  <ItemGroup>
    <None Update="DataSet1.xsd">
      <Generator>MSDataSetGenerator</Generator>
      <LastGenOutput>DataSet1.Designer.cs</LastGenOutput>
    </None>
  </ItemGroup>

</Project>

Stack;
   at System.Data.SqlClient.SqlParameter.set_XmlSchemaCollectionDatabase(String value)
   at System.Data.SqlClient.SqlParameter..ctor(String parameterName, SqlDbType dbType, Int32 size, ParameterDirection direction, Byte precision, Byte scale, String sourceColumn, DataRowVersion sourceVersion, Boolean sourceColumnNullMapping, Object value, String xmlSchemaCollectionDatabase, String xmlSchemaCollectionOwningSchema, String xmlSchemaCollectionName)
   at TypedDataSetDemo.DataSet1TableAdapters.ApplicationsTableAdapter.InitAdapter() in C:\Users\Erik\Downloads\TypedDataSetDemo\TypedDataSetDemo\DataSet1.Designer.cs:line 755
   at TypedDataSetDemo.DataSet1TableAdapters.ApplicationsTableAdapter.get_Adapter() in C:\Users\Erik\Downloads\TypedDataSetDemo\TypedDataSetDemo\DataSet1.Designer.cs:line 684
   at TypedDataSetDemo.DataSet1TableAdapters.ApplicationsTableAdapter.Fill(ApplicationsDataTable dataTable) in C:\Users\Erik\Downloads\TypedDataSetDemo\TypedDataSetDemo\DataSet1.Designer.cs:line 801
   at TypedDataSetDemo.Program.Main(String[] args) in C:\Users\Erik\Downloads\TypedDataSetDemo\TypedDataSetDemo\Program.cs:line 13

huh? how...
https://github.com/dotnet/SqlClient/blob/c21aa7cf29ef2a7d38e58179f265dd0135e9082e/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlParameter.cs#L265-L276

Using System.Data.SqlClient, not M.D.Sqlclient, perhaps?

Oh. In which case that'll be something i changed again. There's a subobject for the xml strings since they're so rarely used and the null ref implies that it hasn't been created. that would be strange though since it's supposed to be guarded and lazy created.

Yup, check out that null checking logic.
https://github.com/dotnet/corefx/blob/019969851b91a473ef769e8fbd8f6b6367a2f062/src/System.Data.SqlClient/src/System/Data/SqlClient/SqlParameter.cs#L256-L274
Any chance you can massage that repro into a test that can go along with the fix?

This is the repro in all it's smplicity:
            var command = new System.Data.SqlClient.SqlCommand();
            command.Parameters.Add(new System.Data.SqlClient.SqlParameter("@Original_Id", System.Data.SqlDbType.BigInt, 0, System.Data.ParameterDirection.Input, 0, 0, "Id", System.Data.DataRowVersion.Original, false, null, "", "", ""));

I assumed (silly me) that the corefx version had decent coverage in it's unit testing but i'm finding that this can't be true. What we could do with is the code coverage numbers (which are planned i believe) and some people who like writing unit tests (which i hate). You really would have thought there were some dataset unit tests though wouldn't you. Since the fix needs to go into corefx if i open a PR tonight it should be in System.Data.SqlClient in about 3-6 months if it meets the bug fix bar.

OK - So the changes that were made in this area have not been ported to M.D.S, is that how it works?
@divega Could you move this bug to the CoreFx repo?

Are these all the tests that we have for SqlParameter??  😨
https://github.com/dotnet/SqlClient/blob/master/src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlParameterTest.cs

Check the manual tests folder. the majority of the testing is done there.

The change was merged in dotnet/corefx#35549 with low test coverage, which hasn't been ported over to Microsoft.Data.SqlClient and hence you do not see a failure here.

Fix in corefx PR is posted.

@cheenamalhotra how do I get a package with the fix?

I can build you one if you like

Yes, @Wraith2, please provide a download for the package.

Debug version (which means asserts are present, prf will suck) but it should be enough to prove the fix. I can manually patch in a release version of the netcore assembly if really needed. rename from .zip to .nupkg
System.Data.SqlClient.5.0.0-dev.19464.1.zip

Thanks, @Wraith2, unfortunately your package requires other packages that are not available on the feeds mentioned here: https://github.com/aspnet/AspNetCore/blob/master/docs/DailyBuilds.md
See attached screenshot

This fix is however important to run typed datasets on .NET Core. When will it be released?
Or is there any workaround how I can run a typed dataset on .NET Core?

It should be in 3.1 which is an LTS release due out shortly after 3.0. It's still unmerged though, not sure what's going on with that.

Sorry, closing the issue was an mistake :-|

A a workaround, you can manually modify the generated code to use a shorter constructor.


Notification Center

Hello,
I'm running v3.3.10 on Big Sur and am trying to understand how to get notifications to pop up. At this time, the only way I can see them is to drag my mouse over to the upper right hand corner of my display. After taking this action, I see all the notifications along the right side of my display. Sorry if this is not a yabai issue but I've checked all my notification settings, etc, and am coming up empty. Curious to hear thoughts and provide additional information as needed. Thanks in advance.

got it working after clicking a bunch of things... wtf knows... had nothing to do with yabai.


Title

Label name "Title" has to be changed to "Name" across screens in Diksha
Label name "Attribution" has to be changed to "Acknowledgement" across forms (in whichever it is present)in Diksha
@vrayulu

@vrayulu we can move this issue to sunbird-portal repo.

Issue moved to project-sunbird/sunbird-portal #4 via ZenHub


fix(Configuration.scss): fix config dialog pre element with block style

fix config dialog

[ ] Read and sign the CLA. PRs that haven't signed it won't be accepted.
[ ] Make sure your PR complies with the writer's guide.
[ ] Review the diff carefully as sometimes this can reveal issues.
[ ] Do not abandon your Pull Request: Stale Pull Requests.
Remove these instructions from your PR as they are for your eyes only.

❌ - login: @JunIce / name: JSparow . The commit (0324ad9) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

@JunIce Could you sign the CLA here?

done! thanks!

❌ - login: @JunIce / name: JSparow . The commit (0324ad9) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

@JunIce Could you sign the CLA here?

Done! Thanks.


Adds CI using GitHub Actions

Adds CI for recent Ruby versions using GitHub Actions.

Thank you @petergoldstein! I see you all over doing these kinda PRs, they're much apppreciated!

@BobbyMcWho Happy to contribute where I can.


Adds truncate param to append method

Also applies truncate false to ogr2ogr call and exception spills.
Fixes #5257
Please CR @Kartones :smile:

Apart from the automated tests stabilization (that second param is going to cause some issues almost 100% sure with some Log mocks)...

Please add the same parameter and functionality to the activerecord model https://github.com/CartoDB/cartodb/blob/master/app/models/carto/log.rb#L22
This requires testing at staging of imports & syncs (first sync, which works almost as an import, and at least 1 consecutive sync which goes through "pure sync" flow), so please be careftul to check it.

Other than that... I'm ok with the change

@Kartones
Everything you requested has been tested successfully. Some changes have been made to the code regarding some ruby optional parameters formatting. Now all works well. As I'm out of time, I leave it to you to:

CR the changes
Merge

Thanks a lot! @Kartones

With that bugfix all scenarios working nicely and tested at staging


new "regexpi" filter for matching processes/services case insensitive

for example:
check_process "filter=exe regexp "WES.*"
-> in nsclient this is always case sensitive
Would be great to be able to do something like this:
/wes.*/i or "regexpi"
For users I think "regexpi" would be easier to use :)

both ways are possible now, see https://github.com/ConSol-Monitoring/snclient/blob/main/docs/filter/_index.md


GUI for NLU model configurations

Acceptance Criterias:

[x] Choose pipeline (pre-defined) -> One pipeline at the moment!
[x] See pipeline components (same as for policies)
[x] Link to kratid.ee describing pipeline setup
[x] Choose parameters for specific pipeline components (described below)
[x] Enable/Disable Policies/Pipeline components and their specification
[x] Save or Reset buttons for saving new changes

recipe: default.v1
language: et
pipeline:
   - name: WhitespaceTokenizer
   - name: RegexFeaturizer
   - name: LexicalSyntacticFeaturizer
   - name: CountVectorsFeaturizer
   - name: CountVectorsFeaturizer
     analyzer: char_wb
     min_ngram: 1
     max_ngram: 4
   - name: DIETClassifier
     entity_recognition: False
     epochs: 60
     random_seed: 50
   - name: RegexEntityExtractor
     case_sensitive: False
     use_regexes: True
   - name: FallbackClassifier
     threshold: 0.8

policies:
   - name: MemoizationPolicy
     priority: 3
   - name: TEDPolicy
     priority: 1
     max_history: 5
     epochs: 60
   - name: RulePolicy
     priority: 6
     core_fallback_threshold: 0.8
     enable_fallback_prediction: false

recipe: default.v1
language: et
pipeline:
   - name: WhitespaceTokenizer
   - name: RegexFeaturizer
   - name: LexicalSyntacticFeaturizer
   - name: CountVectorsFeaturizer
   - name: CountVectorsFeaturizer
   - name: DIETClassifier
   - name: RegexEntityExtractor
   - name: EntitySynonymMapper
   - name: FallbackClassifier

NB! Pipeline order IS important!

@vmugra prototype updated according to AC's. I remove "save" buttons from individual pipeline components / policies and replaced them with a switch (true/ false) because the configuration can be saved as a whole.

Marked done!

@ceirowe repopened this task: https://github.com/buerokratt/Training-Module/blob/main/mock1/config.yml please check and add all parameters with sub parameters!

@vmugra Prototype updated with missing information.

@ceirowe delete EntitySynonymMapper as it is out of scope and add another CountVectorFeaturizer

@vmugra Prototype updated.

These in-out buttons are not working!

Accepted based on prototype!

@KasparMinn @ExiRain  this task is in review but I don't see PR for that, can you please check that?


Draft PR 01 for x509 extensions

Hi @jhand2
Could you please review this? I took latest code and built the simulator afresh. The OIDs came as per spec.

Have added test support for GetCertificateChain command
Have added cert chain validation for intermediate CA certs collected from GetCertificateChain using x509.Verify()
Have added DPE leaf cert chain validation by calling GetCertificateChain

Query 01

The cert chain validation fails if there any UnhandledCriticalExtension that crypto/x509  package doesnt know.
It throws UnhandledCriticalExtensionError
In code documentation they have suggested to overwrite that field with empty array if we know those extensions prior based on this comment
Is this correct?

Query 02

Now I get "UnknownAuthorityError" on cert chain validation for leaf. It is because the SubjectName of cert I collect from GetCertificateChain Command doesnot match the IssuerName field of CertifyKey DPE leaf cert.
- Can you please provide valid cert chain in response instead of dummy certs to validate positive cases?

Query 03

I see that the DPE leaf cert still returns errors in linting. Can we have a sample certificate from CertifyKey response without lint errors?

"e_ext_authority_key_identifier_missing":{
      "Status":Error (6),
      "Details":""
   } "e_ext_authority_key_identifier_no_key_identifier":{
      "Status":Error (6),
      "Details":""
   }"e_key_usage_incorrect_length":{
      "Status":Error (6),
      "Details":"the key usage ([128 1]) contains a value that is out of bounds of the range of possible KU values. (raw ASN: [3 3 0 128 1])"
   }"e_wrong_time_format_pre2050":{
      "Status":Error (6),
      "Details":""
   }

Query 01

The cert chain validation fails if there any UnhandledCriticalExtension that crypto/x509  package doesnt know.
It throws UnhandledCriticalExtensionError
In code documentation they have suggested to overwrite that field with empty array if we know those extensions prior based on this comment
Is this correct?

We should first check that we know all of the OIDs for the unhandled extensions and make sure they are expected to be there. And then yes, overwriting with an empty array once they are known is the right thing to do.

Query 02

Now I get "UnknownAuthorityError" on cert chain validation for leaf. It is because the SubjectName of cert I collect from GetCertificateChain Command doesnot match the IssuerName field of CertifyKey DPE leaf cert.
- Can you please provide valid cert chain in response instead of dummy certs to validate positive cases?

Thanks for pointing this out. We will fix this. I've opened this issue to track: https://github.com/chipsalliance/caliptra-dpe/issues/172
The caliptra emulator target has a valid cert chain once https://github.com/chipsalliance/caliptra-sw/pull/717 is merged. So that may be a good option for testing (once the task to hook up the emulator to these tests is done)

Query 03

I see that the DPE leaf cert still returns errors in linting. Can we have a sample certificate from CertifyKey response without lint errors?

This is being tracked in https://github.com/chipsalliance/caliptra-dpe/issues/74. We will work to address this, but it will not be right away. You can ignore the lint errors for now

@jhand2
Hi, I have raised a PR based on your comments, can you please review and merge if ok?
Thanks!


feat(storage): init compaction group

What's changed and what's your intention?
This PR initializes compaction group. To be compatible with current code, we temporarily create one default compaction group and use the existent tiered compaction picker for it. All files are added to the default compaction group, so the whole write path remains the same.
Changes

Send compaction request to compaction scheduler when HummockManager::commit_epoch, instead of previous periodic compaction trigger. The compaction frequency are expected to be very different from before.
Define dedicated error types for hummock meta module, to distinguish retryable errors from unretryable ones.
Move some code from hummock_manager.rs to versioning.rs and compaction.rs, to reduce hummock_manager.rs size.

TODO

Compaction task may be stuck if meta fails at https://github.com/singularity-data/risingwave/blob/0699492be69646bed553b25a76f6ceb5c4474b0d/src/meta/src/hummock/compaction_scheduler.rs#L150

either cancel all pending compaction tasks on failover
or a compaction task should be marked as sent/unsent, and cancel all unsent ones on failover

Add the real default compaction group which is responsible for dispatching KVs to their targeted compaction group.
After multiple level enabled, also send compaction request to compaction scheduler when HummockManager::report_compact_task.

Checklist

[ ] I have written necessary docs and comments
[ ] I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Will split to smaller PRs after https://github.com/singularity-data/risingwave/pull/2242

see these tests in https://github.com/singularity-data/risingwave/pull/2242


Implement JSON schema serialization/deserialization

With the full adoption of JSON schema in v2.0, we need to update our v31 deserializers to emit a valid JSON schema instance as well as our internal YAML writer to properly format all the keywords contained in the resulting JSON schema during serialization.

Closing this as its superseded by #1727


Update apps.yml

i am unable to upload the icon image to images/apps folder.
please grant the access to upload icon file.

@jmariaj I can't find an Electron application at the URL provided, am I missing something?

Thanks for submitting this app!
To make it easier for our team to review and verify the quality of app submissions, we've moved all the app metadata to a new repository. See github.com/electron/electron-apps#adding-your-app for info on how to open a new pull request there. Sorry for the inconvenience, and thanks again for taking the time to submit your app. For more info on the motivation behind this change, see this pull request: https://github.com/electron/electron.atom.io/pull/616


TensorBoard callback should not close and reopen writers to enable reuse

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes, see below
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): OpenSUSE
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): v2.0.0-rc2-26-g64c3d38 2.0.0
Python version: 3.7.5

Describe the current behavior
Currently, the tf.keras.callbacks.TensorBoard.set_model function closes the train writer, only to reopen it two lines later:
https://github.com/tensorflow/tensorflow/blob/7eef97bba7a9018d6b0630418d0810f94c1d2222/tensorflow/python/keras/callbacks.py#L1535-L1537
This complicates sharing the writer with other callbacks, e.g., in my code below: this code throws a RuntimeError: SummaryWriter is already closed.
Describe the expected behavior
tf.keras.callbacks.TensorBoard.set_model should only close those writers that will not be needed any longer.
Code to reproduce the issue
# import keras
import numpy as np
import tensorboard.plugins.hparams.api as hp
import tensorflow.keras as keras

tb_callback = keras.callbacks.TensorBoard(log_dir='/tmp')
tb_train_writer = tb_callback._get_writer(tb_callback._train_run_name)  # pylint:disable=protected-access
hp_callback = hp.KerasCallback(tb_train_writer, {'param': 42})
model = keras.applications.VGG16()
model.compile(optimizer=keras.optimizers.Adam(), loss='categorical_crossentropy')
model.fit(np.empty((1, 224, 224, 3)), np.empty((1, 1000)), callbacks=[tb_callback, hp_callback])

Issue replicating for version TF-2.0. Kindly find the gist of colab.Thanks!

This can be closed: TF 2.2 does not even create writers any more until set_model.

What is the accepted API for using a shared file_writer with tensorboard callback?


Decision plot documentation update

Improved writing/examples for decision plot documentation ahead of a short article that I am writing. The article links back to the documentation. Thanks again for sharing such a great idea.

Thanks for adding these plots!


Tests: compute the TestInputs path more robustly

This is based on #940; only the last commit is relevant.

@swift-ci please test


Accessibility issue with screen reader and vscode keep saying name of project and WSL env (program title bar value)

Does this issue occur when all extensions are disabled?: Yes/No
yes

VS Code Version: 1.91.0
OS Version: WSL 2 / Ubuntu 20.04 / Windows 10

Steps to Reproduce:

Search by Name CTRL+P

or

Typing a function and open paren so the intellisence / function argument appear abc(
Both triggers the same very verbose info which is not required as we're already in the app.

The screen reader will say:
[File name] - [Project name] - WLS Ubuntu 20.04 - Visual Srudio Code - Document
And than will repeat that a second time with "Application" instead of "Document".
And finally "Search file by name".
It's the same for the function arguments, it's saying all of this twice before finally starting to announce the arguments.
Basically the screen reader says the same as when the vscode application gets the main OS focus with the following difference:
When I ALT+TAB to vscode or return from a different virtual desktop it will say all info, but instead of "Document" will say "Desktop 2" and repeat with the "Application"
When ALT-Tabing I'm all good / can live with what the screen reader is saying.
But for CTRL+P and also for intellisence, is there a way to remove this long and superflus info?
Because I either have to wait to get the function arguments or the confirmation that CTRL+P is open, and if I hit a key to skip, I than need to redo the operation.
Thank you.

JFYI, same behavior with the latest 1.91.1 version.

On macOS (voiceover) / windows (nvda), I am not able to reproduce the issues you are describing, thus closing for now. @rperez030 , can you?

I cannot reproduce it either, but I don't have WSL configured in my system at the moment. I tried with JAWS on Windows as well. @dstpierre which screen reader are you using?

Hey @meganrogge @rperez030 I recorded an mp4 showcasing the issue
I'm using NVDA on Windows, maybe with that video this will help you reproduce the issue.
Hopefully it will as it is exrtremely disturbing.
Thanks again for the effort improving the a11y.

It looks like this is happening for you when you clear the line.

@jooyoungseo or @rperez030 have you experienced this? It does seem unexpected that something that loses focus would be announced by the screen reader


feat!: comprehensive errors for list schematics

Current dependencies on/for this PR:

main

PR #24

PR #25

PR #26   👈

This comment was auto-generated by Graphite.

Current dependencies on/for this PR:

main

PR #24

PR #25

PR #26   👈

This comment was auto-generated by Graphite.


Display error when Quarkus application is built for Qute

Once https://github.com/quarkusio/quarkus/pull/25810 will be merged, we could display errors in Qute template file by using problemMatcher from the task.
See https://github.com/quarkusio/quarkus/issues/25724 for detail of this issue.

Relevant https://code.visualstudio.com/docs/editor/tasks#_defining-a-problem-matcher . Might be good to read the full thing to understand what needs to be done programmatically.


Implement Wandb sweeps for decision transformer training.

At some point, I implemented weights and biases sweeps to find good hyperparameters when doing PPO training. I suspect this will be very useful in the future and would like it to also exist for the decision transformer script as well.
Examples from PPO:

scripts/run_ppo_sweeps.sh (command to start it)
https://github.com/jbloomAus/DecisionTransformerInterpretability/blob/main/sweeps/ppo_sweep_template.yml (template yml config file)

Tasks:

[x] make sure the PPO sweep works (I think there might be some funkiness with passing in the exp-name so might want to fix that first.
[x] copy the pattern and implement it for scripts/run_decision_transformer.sh

Working well, got some interesting results!


Module #9- Data Analysis and Workflows

@hsoyka is currently working on this lesson.

[x]     Transfer all text content to the slides
[x]     Compare text transferred to most recent ppt - ensure it's current
[x]     Re-export images - rework images to ensure high quality graphics in the presentation
[x]     Check notes - ensure all notes that aren't a duplicate of the slide content are transferred.
[ ]      Review edits and changes to final slides, read for clarity/images positioned properly.

I'm still working on this lesson-- please get in touch with me before you make any changes/updates!

Check images and final citation slide before completion.

All slides have been reviewed / edited / cleaned.  There are a few minor items remaining but I will migrate into a single issues thread.


Last.FM doesn't work with proxy settings

OS:
Windows 7
Issue Descriptions:
Last.fm is blocked, so I have a socks proxy I use. I only want the traffic for GPMDP going through the proxy. I've enabled my proxy by adding '--proxy-server="socks5://localhost:8089"' to the gpmdp shortcut. I've tested that the music is using the proxy by stopping the proxy server, and seeing that music streaming no longer works, then starting the proxy server and streaming starts working again.
Steps to Reproduce:

Enable proxy (I know this isn't trivial for everyone) via --proxy-server="socks5://"
Go to "Desktop Settings -> Last.FM"
Click "Log in to Last.fm"
It shows "Authorization in progress" very briefly, then flips back to "Not Authorized"
It doesn't scrobble (obviously)

Perhaps it's related to this? https://github.com/electron/electron/issues/183

It is exactly that problem @rattboi and unfortunately that is quite tricky to fix.  It would require the app using handling proxy settings internally which is quite complex

Can we use something like https://www.npmjs.com/package/global-tunnel along with reading the command line settings to set the proxy for the node side of the web stack?

I suspect close to this is:
error: ################### !! Update server down !! ##################

appearing on the terminal.

I'm removing this from the v4 milestone and will implement using  the new net module that is coming to Electron --> https://github.com/electron/electron/pull/7577

FYI, looks like that PR got merged into Electron 15 days ago

@rattboi I am aware :P

Any news on this?
Is there any workaround to generate the credentials that we could use to have it working? I don't mind meddling with some code if necesary.

@asermax It's not just the credentials that are the issue, the actual REST calls to trigger last.fm actions will face the same proxy issue.  This isn't on my immediate todo list but if someone wants to pick it up that would be great 😄

Ooo, it makes sense :thinking:
I would like to help but not very sure where to start. Giving a quick look at the related code I see that a third party module is being used to communicate with lastfm, do we need to replace it or configure it somehow? If you don't mind, would you give me a quick rundown on what your take on how to fix it?
In any case, I'll give it a more thorough look later today. Thanks for the promptly response 😛

@asermax My initial reaction was "let's fork lastfm and change their usage of the 'http' module to be 'electron.net'".  It's basically a drop in replacement.
Then I saw this.
https://github.com/jammus/lastfm-node/blob/master/lib/lastfm/lastfm-request.js#L3
If we set global.GENTLY_HIJACK and use it to proxy the lastfm modules require('http') call to require('electron').net it might "Just Work"(tm).  It's a bit of a hack but less work than maintaining a fork of lastfm.

Alright, after delaying this for a while I eventually got something working. Sadly I could not setup the dev environment on the windows machine I actually want to test the fix on (my work machine, where I'm having the proxy issue), so I made the change and tested it on my home comp in which I use linux. Aparently the monkey-patching works, but for further testing I'll (if you don't mind) open a PR as to get the windows executable built and actually test it at my work machine.
I'll get back at you once I find out if it works or not 😛

@asermax did a Windows build of this ever happen?
My previous player was a Chrome extension and thus had no problem following the system's proxy settings, but now I'm faced with this.

Actually, it did, AppVeyor did it:
https://ci.appveyor.com/project/MarshallOfSound/google-play-music-desktop-player-unofficial/build/1.0.2007

Now last.fm doesn't work also without proxy. It doesn't work at all....

 I have attempted the GENTLY_HIJACK fix, and after having some initial issues, I think I can say this works!
One thing to keep in mind is that normal build setup for this doesn't expose that you need to supply your own last.fm api/secrets. When I did this by overriding the GPMDP_LASTFM_KEY, etc, and then re-authorizing via the gui, it started scrobbling!
@MarshallOfSound I think you must be keeping the key/secret in your CI infra, and so it's left kinda on the floor for developers.
Keep in mind that this is on OSX, so your results may vary. I am attempting to package for myself to see if it continues to work. Will report back.

I had some packaging difficulties because of weirdness with electron-packager and npm 5+. After using npm 3, I was able to package, and I'm running a working, scrobbling, proxied GPMDP. I think we can confirm this works, and we should get an official build so it starts using the official last.fm key/secrets.
@MarshallOfSound is there a way to get a signed beta build based on this, for testing?

@rattboi On OSX all you need to do is make a PR and have it merged, once it's merged circleci will built a signed version of the app for you 👍

@MarshallOfSound I'm just using #2241 changes and then I built using my last.fm key/secret, and that's working. I don't want to make a new PR, since this is actually @asermax's work. If there's no way around it, I'll make a new PR and try to attribute it to him. I think you can just re-open #2241 and merge that though...

Don't worry about attributing it to me, go for whatever is easier :) I'm glad to see it helped tho!

@MarshallOfSound would you prefer I open a new PR, or can we merge @asermax's original PR (#2241)?


Bug: It should be possible to use the SQLite database based on a file

Feature Suggestion

The Backstage example app in this repository uses an in-memory SQLite database. This means that if the user changes the state of the database, and restarts the backend, all the changes disappear. This eventually becomes a source of confusion for Backstage contributors.
If the default SQLite connection were based on filesystem, instead of in-memory, the data will persist. And it will still be lightweight than PostgreSQL.
We already discourage the use of example app in production, hence this change does not increase the risk of people using SQLite in production.
It should be possible to switch the in-memory SQLite config to one that is based on a file.
Possible Implementation

Discovering this PR https://github.com/backstage/backstage/pull/5308 from @Fox32,  looks like it's possible to update the app-config.yaml to
backend:
  database:
    client: sqlite3
    connection:
      filename: 'backstage-db.sqlite'

and start using filesystem based SQLite connection!
But unfortunately this does not work for me and throws a "migrations directory is corrupt" error.
Backend failed to start up Error: The migration directory is corrupt, the following files are missing:<PHONE_NUMBER>3813_init.js,<PHONE_NUMBER>0700_location_update_log_table.js,<PHONE_NUMBER>4117_location_update_log_latest_view.js,<PHONE_NUMBER>3613_entities.js,<PHONE_NUMBER>5244_location_update_log_latest_deduplicate.js,<PHONE_NUMBER>3904_location_update_log_duplication_fix.js,<PHONE_NUMBER>0600_entitySearch.js,<PHONE_NUMBER>2832_add_bootstrap_location.js,<PHONE_NUMBER>4503_case_insensitivity.js,<PHONE_NUMBER>2705_add_entity_full_name.js,<PHONE_NUMBER>0744_entity_data_column.js,<PHONE_NUMBER>3131_entity_remove_redundant_columns.js,<PHONE_NUMBER>1501_index_entity_search.js,<PHONE_NUMBER>0742_add_relations_table.js,<PHONE_NUMBER>5611_relations_table_uniq.js,<PHONE_NUMBER>5851_fk_index.js,<PHONE_NUMBER>3504_update_log_varchar.js,<PHONE_NUMBER>1210_locations_fk_index.js,<PHONE_NUMBER>0147_refresh_state.js,<PHONE_NUMBER>4022_refresh_state_location_key.js
    at validateMigrationList (/Users/himanshum/workspace/github.com/backstage/backstage/node_modules/knex/lib/migrations/migrate/Migrator.js:575:11)
    at Migrator.latest (/Users/himanshum/workspace/github.com/backstage/backstage/node_modules/knex/lib/migrations/migrate/Migrator.js:70:7)
    at async Function.create (webpack-internal:///../../plugins/scaffolder-backend/src/scaffolder/tasks/DatabaseTaskStore.ts:70:5)
    at async createRouter (webpack-internal:///../../plugins/scaffolder-backend/src/service/router.ts:95:29)
    at async createPlugin (webpack-internal:///./src/plugins/scaffolder.ts:46:10)
    at async main (webpack-internal:///./src/index.ts:121:32)

Context

Why the default should be in-memory SQLite database which does not persist across sessions?
(I don't have any strong reasons here to be honest. Please comment!)

A nudge for people to switch to PostgreSQL so that they don't accidentally deploy sqlite database.
Speed?

Why the default should be a file based sqlite database, which persists across sessions?

No surprise loss of data for new Backstage integrators.

This has been a constant source of confusion on Discord for new people. Quoting @Pike here (in a call with @adamopenweb) - I was told to use SQLite for my new Backstage app saying it's safe now and easy to switch later. I lost my populated catalog eventually - so it wasn't safe.

Authentication signing key gets lost, forcing user to sign out and sign in for token verification to work every time

While working with verifying a Backstage token in the backend, we found out that a signing key is created by the auth-backend plugin when the first user signs in and the key is stored in the database. After restarting the backend, the user is still logged in, but there is no signing key available in the database. This means the backstage token can no longer be verified without the user signing out and signing in again. This dramatically increases the debugging cycle.

But unfortunately this does not work for me and throws a "migrations directory is corrupt" error.

Actually I thought I fixed that 🤔
I think the problem is that all plugins are using the same database. It's important to specify a directory so that every plugin gets an own file. But I haven't used it for a long time, could be broken.

On topic: it depends on what you are working on. If I'm trying out catalog ingestion, a fresh start is quite nice. To try out search indexing, a filled catalog is nice...
But in the end it's easy to have a custom default locally.

@Fox32 A directory containing all the .sqlites should be good enough. I tried setting the backend.database.connection.database as well, which looks like something which was written to address this use-case https://github.com/backstage/backstage/blob/ec62af1da511db555b459d58ef4e1daac4ca1118/packages/backend-common/src/database/connectors/sqlite3.ts#L89-L103
I found out that this omission of database key needs to be updated first, to not do that in case of sqlite3.
https://github.com/backstage/backstage/blob/ec62af1da511db555b459d58ef4e1daac4ca1118/packages/backend-common/src/database/DatabaseManager.ts#L157
Even then, the corrupt migrations directory issue does not go away. 😢

But in the end it's easy to have a custom default locally.

That would definitely be helpful. But I personally feel that non-persistent in-memory database feels more surprising than a file based sqlite db which you can delete to start afresh. I could be wrong though. 🙂

So we (discussed this in sync) want to keep in-memory DBs as the default, as it's really convenient for many development use-cases, and it doesn't pollute the repo. We do ofc want to fix the issues with the file-based approach tho :grin:

Makes sense to me @Rugvip - I'll re-purpose the issue!
I think we could save some people by adding just a warning log in backend saying that the database used is in-memory and will be cleaned when the backend starts.

I think #5700 broke how sqlite databases are created. Look like sqlite means :memory: right now.

I hit that issue, strange that is it too hard to fix this? Running on memory is not really good for me.

This works if I set backend.database.connection.directory: /abs/path/to/sqlite/db/folder.

It's enough to set:
  database:
    client: better-sqlite3
    connection:
      directory: "./db"
    useNullAsDefault: true

It will place the folder with *.sqlite files under packages/backend/db.


Fix function declaration for create_from_unpackaged.sh use

This is a bugfix for version 0.13. It had a problem that affected the tests of cartodb.
In the CartoDB/cartodb tests, when a test user db is created, first a
CREATE EXTENSION ... FROM unpackaged
is tried to load the extension, and if it fails a regular CREATE EXTENSION is used.
The create_from_unpackaged.sh script produces an syntactically incorrect migration file from unpackaged when function parameter lists are not in a single line. Under that situation, the
CREATE... FROM upackaged in the CartoDB/cartodb tests fails in an unexpected way
(syntax error) and the extension is not correctly loaded for the test user.

Trying to create the extension 'from unpackaged' is probably not needed anymore (if it ever was) so it would be nice to remove that from cartodb.


add support for monolog 2.0

Can you enable support for monolog/monolog 2.0
I'd like to use it in my project but because 1.17 is a dependency of google/apiclient composer won't allow
relates #1369

I did a little bit of research here:
Version 2 of Monolog is still in development. At the time of writing this comment, it has a beta release in packagist. I looked at compatibility of the library as of this commit: https://github.com/Seldaek/monolog/commit/ebb804e432e8fe0fe96828f30d89c45581d36d07.
The PSR-3 Usage of Monolog remains consistent. This library uses the SyslogHandler and StreamHandler for Monolog, which also are consistent, other than type hinting.
Monolog 2 requires PHP 7.1, so when Version 2 is released, we will need to support Monolog 1.X for lower versions of PHP.

Thanks @danielgsims. There hasn't been a 2.0 since beta1 last December. This looks like it'll be pretty straightforward, but until they get (at least) to RC stage, let's just continue to watch it.

Can you enable support for monolog/monolog 2.0 now that it is at v2.0.0?
Thanks!

Can we please release a version including this feature?

@zek it's in the works: https://github.com/googleapis/google-api-php-client/pull/1707

Please upgrade to v2.3.0. :)

it has been conflicted when I use google/apiclient


Query Object Capabilities

Is something like this possible in order to get a more complex query formula for the select options when using the select method?
{
  "where": {
    "$and": [
      {
        "$or": [
          "{$eq: { '': ''}",
          "{$eq: { '': ''}",
          "{$eq: { '': ''}"
        ]
      }
    ]
  },
  "sort": [
    {
      "field": "",
      "direction": "asc"
    },
    {
      "field": "",
      "direction": "desc"
    }
  ]
}

This errors for me saying the filter formula is invalid. Also, should the error messages be saying exactly what's wrong with the formula, or are they all generic in this way? Thanks!

Nevermind. Had some errors in my object. Was using strings in places where they should have been nested objects.


Update to support automatically synchronizing access token between libraries

What kind of change does this PR introduce?
Updated to support automatically synchronizing access token between gotrue-py, postgrest-py and storage-py
What is the current behavior?
Developers need to manually get an access token from gotrue-py and pass it to postgrest-py, storage-py... to authorize the connection to the backend.
What is the new behavior?
All libraries share an http client class which contains a static variable to share authentication information.
Additional context
Shared access token allow developers to reduce the steps to call API
When the access token is expired, the new token after being refreshed will be automatically supplied to all other libraries.

Thank you for your attempt at fixing this issue. We've merge another PR which solves this issue. https://github.com/supabase-community/supabase-py/pull/560


RM3Mini found but unknown

The RM3Mini was found. It is unknown and there are no states and no button to activate the learning mode.

Same here
Device UN:RM3-7a-f1-bf dedected: address=<IP_ADDRESS>, mac=24:df:a7:7a:f1:bf, typ=unknown, id=0x5f36 devtype=UKN

Nevermind, i installed Version 2.1.5 from github and it recognized the RM3 Mini


Migrate from popperjs/core to floating-ui

Is your feature request related to a problem? Please describe
The project I work on is migrating away from popperjs/core to floating-ui
Floating UI is the rebranding new version of popperjs, similar to how react-overlays rebranded to react-restart
If we also include react-restart/ui in our project we have to ship a bigger bundle to consumers than we would if react-restart/ui also used floating-ui
Describe the solution you'd like
I'd like to see react-restart/ui migrate away from popperjs to floating-ui
Describe alternatives you've considered
Haven't thought of any yet
Additional context
After working on a migration in a different repo, it's hasn't been bad and floating-ui has been working well

Any chance this is in the works/on the roadmap?

It's on the roadmap, but getting free time is difficult right now.  PRs are welcome


opts = {}

We should wrap options into an object to make the function signature of validators extensible. This discussion here made me think of that: https://github.com/osmlab/osmlint/issues/17#issuecomment-165680200
So instead of
validators.bridgeOnNode(bbox, zl, mbtilesPath, callback);

we should do:
validators.bridgeOnNode({bbox: bbox, zl: zl}, mbtilesPath, callback)

which allows for future additional parameters without breaking the function signature:
validators.bridgeOnNode({bbox: bbox, zl: zl, aggregate: true}, mbtilesPath, callback)

Parameters in the options object should be in line with options on the command line:
osmlint bridgeonnode --bbox="[1, 2, 3, 4]" --zoom=15 --aggregate osm.mbtiles

@lxbarth @geohacker :
I've implemented this requirement.
two commits:

https://github.com/osmlab/osmlint/commit/22fde63256416082e6f31c307e0abef51eaab116
https://github.com/osmlab/osmlint/commit/f1810215cfee18d116d51a656a86d97ce6b10fdb

The test passing fine and on /peer-review(CLI) as well.
Next action

[ ] @geohacker  fast checkout
[ ] @rub21 master to master.