[FIRTrace updateTraceWithSessionId]_block_invoke/ [__NSSetM addObject:]:object cannot be nil.

version
Firebase 5.10.0
FirebaseAnalytics 5.2.0
FirebasePerformace 2.1.2
GoogleTagManager 7.1.1
GTMSessionFetcher 1.2.1
xcode
Xcode version: _9.4.1
Firebase SDK version: _5.10.0
crash
There has been a lot of collapse in the last two days about [__NSSetM addObject:]: object cannot be nil. The error stack is as follows
0	CoreFoundation
___exceptionPreprocess + 228
1	libobjc.A.dylib
objc_exception_throw + 56
2	CoreFoundation
_CFArgv + 0
3	CoreFoundation
-[__NSSetM addObject:] + 772
4	homeApp
___36-[FIRTrace updateTraceWithSessionId]_block_invoke + 92
5	libdispatch.dylib
__dispatch_call_block_and_release + 24
6	libdispatch.dylib
__dispatch_client_callout + 16
7	libdispatch.dylib
__dispatch_lane_serial_drain$VARIANT$mp + 592
8	libdispatch.dylib
__dispatch_lane_invoke$VARIANT$mp + 432
9	libdispatch.dylib
__dispatch_workloop_worker_thread + 600
10	libsystem_pthread.dylib
_pthread_wqthread + 312
11	libsystem_pthread.dylib
start_wqthread + 4

Tracked internally at b/118559496

I'm also getting a ton of these after updating to the latest version of Firebase.

This is one of three seemingly related issues causing a 8% crash rate of my application. This is an URGENT issue.

But some time ago it was normal. It was only in the last two days that this problem occurred. Did any recent adjustments lead to it?

Can you please confirm the version of Firebase Performance on which this issue is occurring? Secondly, were you able to reproduce in your development environment?

@zhengzeqin007 Are you seeing this issue only in the last couple of days? Can you share the version of the Performance SDK for the version of the app that is crashing?

I am also getting same issue. Here are the pod details I am using.
 Before iOS 12, I have not found these crashes.

@visumickey for clarification ... if the issue was on the backend, what is the need for a client side fix?

@visumickey for clarification ... if the issue was on the backend, what is the need for a client side fix?

It is just a protective/defensive fix on the client side to avoid such instances in the future.

@visumickey @BrettThePark its a firebase issue right? so what that has to do with your backend servers?

@visumickey - The issue is still present for our app.
Is this really fixed on backend?
We've been facing globally more than 1600 crashes for the same amount of users overnight.
This is really a huge issue to our customers and if nothing happens we need to release a hot fix and remove performance as our only option which would not be the optimal of course.

@visumickey - We are still getting crashes this morning. I just updated Firebase and realized we were on version 5.9 of Firebase/Core and 2.1.2 of Performance. Will I need to do a release with the updated versions to stop having this crash? Also, all of the users have iOS 12.

@mberndt92 @sarahedenyoung Couple of questions:

Has the number of crashes started reducing in the last couple of days? (This is to confirm if the configuration rollback has rolled out to the devices)
Can you confirm the version of the Performance SDK on the version of your app that has this crash? (Intent is to check if the issue is occuring in the latest version of the Performance SDK, 2.2.0)

@mberndt92 Would you mind updating to the latest version of the Performance SDK (2.2.0)?

@visumickey

No, it has not
App had version 2.1.2

@visumickey  @sarahedenyoung
"We are still getting crashes this morning".....me too

Any updates?

@sarahedenyoung  no update still FirebasePerformace v2.1.2. but i think it's a back-end problem. It's reasonable to say that no updated version should be able to solve the problem.

"We are still getting crashes this morning"
Using FirebaseCore (5.1.5)
Using FirebasePerformance (2.1.2)
Using FirebaseRemoteConfig (3.0.2)
Using FirebaseAnalytics (5.2.0)
Using FirebaseInstanceID (3.2.2)
Using FirebaseABTesting (2.0.0)

Team google, please fix this asap and tell us the solution. My app top 3 crashes.
Crash 1 - [FIRTrace updateTraceWithSessionId]_block_invoke
Crash 2 - [FPRNetworkTrace updateTraceWithCurrentSession]_block_invoke
Crash 3 - Crashed: com.google.perf.sessionIds.networkTrace

@visumickey:
I can confirm that the crash is not happening with the latest version of the performance SDK (2.2)

Thanks for confirming, @mberndt92. I'll close this issue for now, but if anyone is still having issues, please feel free to continue commenting here.

@imRanjit Like I mentioned - Please update the Performance SDK to 2.2.0 to resolve this crash.

@visumickey Cant google fix this issue at their backend servers? All app developers facing this issue should again upload a new build to app-store.

@imRanjit
Yes but since the suggested update is in place the crashes have been entirely resolved 🙂

Hey thanks. I am also getting these crashes in crashlytics report.  But not
able to reproduce on my device
So you updated the SDK and made a new release right ?
On Mon, 5 Nov 2018 at 3:26 PM, Maximilian Berndt<EMAIL_ADDRESS>wrote:

@imRanjit https://github.com/imRanjit
Yes but since the suggested update is in place the crashes have been
entirely resolved 🙂
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/firebase/firebase-ios-sdk/issues/2019#issuecomment-435816998,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AahvTj7mj_Ttt6fOZRz-Z7wjUAYTAj0qks5usAs6gaJpZM4X92pw
.

--
*::DISCLAIMER::

The contents of this e-mail and any attachments are confidential and
intended for the named recipient(s) only.E-mail transmission is not
guaranteed to be secure or error-free as information could be intercepted,
corrupted,lost, destroyed, arrive late or incomplete, or may contain
viruses in transmission. The e mail and its contents(with or without
referred errors) shall therefore not attach any liability on the originator
or redBus.com. Views or opinions, if any, presented in this email are
solely those of the author and may not necessarily reflect the views or
opinions of redBus.com. Any form of reproduction, dissemination, copying,
disclosure, modification,distribution and / or publication of this message
without the prior written consent of authorized representative of redbus.
http://redbus.in/com is strictly prohibited. If you have received this
email in error please delete it and notify the sender immediately.Before
opening any email and/or attachments, please check them for viruses and
other defects.*

I'm still seeing such crash reports coming from Crashlytics :-/

Hello All, I didn't update the SDK, as I had to do a release for it. But as said above, due to roll-out, my crashes have dropped substantially.

hello,
same issue with our app, my pod file with lines of:
 pod 'Fabric'
 pod 'Crashlytics'
 pod 'Firebase/Core'
 pod 'Firebase/Performance'
 pod 'Firebase/Messaging'

installs (04.07.2017) the following packages:
Using Crashlytics (3.9.0)
Using Fabric (1.7.0)
Using Firebase (5.9.0)
Using FirebaseAnalytics (5.2.0)
Using FirebaseCore (5.1.4)
Using FirebaseInstanceID (3.2.2)
Using FirebaseMessaging (3.1.2)
Using FirebasePerformance (2.1.2)
Using GTMSessionFetcher (1.2.0)
Using GoogleAppMeasurement (5.2.0)
Using GoogleToolboxForMac (2.1.4)
Using GoogleUtilities (5.3.0)

now i am trying to fix my old project,
i hope new release of PerformanseSDK has the solution

Please upgrade to the recent version of Firebase Performance to have this resolved.

Please upgrade to the recent version of Firebase Performance to have this resolved.

yes, i did. i will observe for a while and comment back here.
also, thanx for keeping this page alive. it saved my days.


Exibitera should have a Mapping Application

There is a need for a generic mapping application in Exibitera. This comes out of a conversation over email that I wanted to capture as an issue to promote a wider discussion.
The main goal would be to leverage leaflet js to use open street map layers, though this would also allow a variety of layers to be used.
I was working on an MVP mapping app that would do the following:

Users can define a base layer
Users can define a max zoom-level
users can define a bounds rectangle locking the map to that region.
Users can define a spreadsheet containing POI coordinates, a description, and image(s)
On selection a drawer opens with a title, description,and image gallery

Example UI

Future Scope:

Attract Screen
Loading GeoJson layers to support additional data representation

@forceflow1049  I would be curious if you have any other thoughts on what would be valuable for an MVP and for future scope.

Oooh, this would be quite useful!  :+1:

@alexaverill This is a great list to get us starting. In addition to your MVP items, it should:

Support multiple languages (there is a standard createLanguageSwitcher function in exhibitera_apps_common.js for building the UI)
Support text size adjustment

Those two items are part of Exhibitera's accessibility-by-default philosophy. I would maybe start by duplicating Timeline Explorer, as it supports spreadsheet input, multilingual, and adjustable text. Just swap the functions that build the timeline for ones that build the map.

@forceflow1049  those are good suggestions.
My current plan is to setup an initial demo and share it here.
I am also thinking through the best way to define the exhibit content in a generalize way. Initial testing with setting it up in a spreadsheet/csv. I am going to throw together a more WYSIWYG/guided experience that hopefully create a low barrier to entry.
Also my current plan is to likely try to keep it as loosely coupled to the python backend to make it easier to host independently as a demo for people to play with.

Just wanted to share a minor update. I have the initial front-end setup. Its a fairly normal/basic map viewer for points with different base layers and the ability to lock the user to a defined region and zoom levels.
A demo is up here at the moment: https://maps.averill.dev/
I am in the middle of working on a WYSIWYG editor that's coming along nicely. (The demo above was built in the editor).

Great update, @alexaverill! It's coming along nicely. I'll have some more comments in a few days—I've been moving apartments this week!

@alexaverill Finally had a chance to play around with this—it is really nice! In addition to a WYSIWYG option for adding points, we probably want to support spreadsheet entry as well. I can imagine situations, such as wanting to mark the locations of all national capitals, where it would be inefficient to have to input them one by one.
Do users have to supply their own API key in order to access the mapping API?

CSV Loading is definitely on the todo list. There are some considerations that I need to think through for the data outside of the mapping from Latitude and Longitude to content.  Nothing too crazy just  managing base layers and map bounds nicely.
So the user wouldn't need to supply any API keys at all, its all based on Leaflet.js which is free and open source. There are some base layer providers that require api keys or accounts, but a user doesn't really have to use those base layers.
I have this as a link in the editor, but here are a ton of the different base layer options: https://leaflet-extras.github.io/leaflet-providers/preview/  (Note there are closed source map layers in that preview, license details are here: https://github.com/leaflet-extras/leaflet-providers)
Another cool thing is as long as a user can find a map tile server that follows the standard it can be maps of anything. For example there are free to use Mars and Moon map tiles that can be dropped in and used. https://www.openplanetary.org/opm/basemaps I plan to put together a couple demos based on them after I get the rest finished
I expect to have the WYSIWYG editor ready for testing sometime this week

Here is an initial version of the WYSIWYG editor: https://maps.averill.dev/create.html
I'd love some feedback, especially any suggestions for better verbiage on the dialogs and instructions.
Things that are still in progress:

Multiple Language support, need to implement inputting and displaying
Bulk Point upload, I am planning to add the ability to upload a CSV during the point addition step, My thoughts are to generate a sample CSV based on the languages setup in the application for a user to fill out with their bulk points.

Love to hear some feedback @forceflow1049  and @David-S-Morgan

@alexaverill This is really cool!
From the end-user app side, I think things are really in pretty good share. A couple of things to consider, in addition to your WiP points from above:

We can't have any active links to outside the app (or people will escape). Currently there is a link to both Leaflet and the layer credit. I imagine we need to provide layer credit, but if it needs to be a link, then it should pop up as a QR code.
There should be some kind of option for a header, like "Battlefields of World War I" or "Shipwreck Locations"
Maybe a reset view button that takes you back to the initial view?

From a setup perspective, I want things to be consistent across the apps in Exhibitera. So, instead of having the setup steps overlay the map, we should clone one of the existing setup pages and modify it. Maybe we have the interactable map near the top, with your various setup steps below that. The righthand-column will still be a preview of the overall app that updates as changes get made (like after each step is complete). A few more specifics:

We will need to offer the ability to change colors/fonts/etc in line with the other Exhibitera apps.
There should be an option for an attractor screen (with a timeout to return to it).
It would be cool if you could set a unique icon for the pins. Either as a bulk setting (i.e., change to a shipwreck icon uniformly) or on a per-item basis (i.e., different icons for earthquakes vs. tornadoes vs. landslides).
It would be good to have a dropdown list of common basemap options to select from, in addition to the chance to supply your own link.
The end result will need to be a definition file that conforms to the Exhibitera Apps format, because that is needed by Hub to handle switching between different apps, etc. The definition file can refer to a user-supplied CSV if we want (like in Media Browser).

I feel really positive about how the app is going to turn out! Given the amount of stuff on the setup end to do, I'm going to move this to the Exhibitera 6 milestone so it doesn't block other releases. If we get everything done sooner, we can always move it back up.
Thanks so much for all your work on this!

@forceflow1049
Thanks for the feedback, I think there are a lot of good suggestions here.
I’ll double check what the licenses for leaflet and the base maps require and sort out if we can get away with text or a QR code.
Reset and a title are also good calls, an Attract Screen and custom pointers are also on the todo list, but lower down at the moment.
I am not sure a dropdown with common base maps adds much, currently I put in the street and satellite as the defaults, since based on what I have seen building out similar types of exhibits for clients that covers 99% of what people want. The link to the complete list then covers anyone else.
In terms of the definition file is there a reason to not just embed the output of the editor into the existing definition?
While I understand the desire for a unified UI across setup, I don’t think it’s the best use case for this exhibit, or as a general rule for all exhibits. I think having a wizard based or walkthrough based setup process unique per exhibit helps lower the bar to entry, and makes it easier for first time users to get started quickly. Even with my experience building out and developing exhibits I have had some trouble getting demos of the app up and running quickly and easily. I would argue that slowly building out more user focused UI’s would help the average museum curator feel more comfortable and confident moving forward.
I think there could also be value in treating this mapping as a Exhibitera Compatible mapping application and use this as a good time to build out documentation and an npm package to enable more developers to build comparable apps that compliment the core apps but might not fit directly into the Exhibitera setup process.

@alexaverill I like the idea of trying it as a compatible app. I also hear you about the complexity of setup for some of the Exhibitera apps. I think your setup wizard is a nice improvement—I may try to implement something similar for one of my apps as a test.

Just following up on this since its been a few weeks, I have most of the functionality complete, but have been a bit busy and haven't spent too much time on it at the moment. I have some outstanding work to do for timeouts and Exhibitera integration, and need to write up some documentation.  I'll keep chipping away at it,and update as I finish things off

Thanks for the update, @alexaverill! I am working on a test of a setup wizard for Media Browser, inspired by what you created for the mapping app. I will share for feedback once I have it working.

@alexaverill I've finished a working version of the setup wizard for Media Browser (probably one of the most complicated apps alongside InfoStation). I've love to hear your feedback on it—check out the Dev_5.2_setup_wizard  branch
https://github.com/Cosmic-Chatter/Exhibitera/tree/Dev_5.2_setup_wizard

@forceflow1049 Awesome! I will pull it and take a look tomorrow morning and let you know what I think!
I am still working on finishing up some of the editor flow on the mapping, and getting documentation together. Work has been keeping me busy so it’s been a lower priority.


yeoman generates package.json with 1.13 as the engine

It should now generate 1.14

Ideally we would just automate this so that the generator always points to latest (e.g. by looking at the latest tag at https://github.com/Microsoft/vscode/releases

@joaomoreno mentioned to me a way to fetch this information that is not dependent on the existance of a tag, but uses the information from our builds website.

Yeah, see https://github.com/Microsoft/vscode-update-server/issues/12#issuecomment-314710581

@joaomoreno What's the full URL of the /api/releases API ?

I updated the generator plugin (manually) with https://github.com/Microsoft/vscode-generator-code/commit/e9d184bcaec806786ad92802243627ed4f82a657

@aeschli see https://github.com/Microsoft/vscode-extension-vscode/blob/master/bin/install#L69 where I adopted this.


Account builder

~Review merge after: #205 / #204~
This adds builder for multiple structs, this allows one to construct mock data.

#205 and #204 have been merged, this is ready for review


Add: after_date flag to pyosmeta

i can't get the mocks/ tests working on this so i'm going to merge so we can update metrics. we can revisit tests later when there is more time.


Feature/downtime rostering

pull request for downtime feature

@mmhh1233 can you resolve the conflicts you have between this branch and the development branch?


Simply loading kivy has side-effects, writes logs to console and filesystem.

Versions

Python: any
OS: any
Kivy: any
Kivy installation method: pip

Description
Simply importing kivy and nothing else emits 250 bytes of logging to stdout and creates a dozen files or directories in the file system.
This breaks my system for some invocations that emit JSON, and is undesirable in other cases.
I can suppress all logging with the KIVY_NO_CONSOLELOG environment variable, but that's worse, because all ERRORs and WARNINGs will be eliminated.

My current plan is this.  Before kivy is loaded anywhere in my code, I change os.environ['KIVY_HOME'] to refer to my application's folder, and then write my own config.ini to turn up the log level.
This is fragile as the correct functioning of my code will depend on the order that modules happen to be loaded, and I have multiple main programs.

Just loading a library should not have any side effects like disk or console output.
By comparison, the other 20+ Python libraries I use don't log at all or create any files on the file system just by being loaded - here's a subset of those libraries which covers all sorts of areas in Python and many of which you likely already have on your system.
import (bibliopixel, cv2, flake8, flask, jedi, mido, numpy, pytest,
        requests, six, tornado, websocket, zmq)

Code and Logs

import kivy

We know. It was decision that was there from the beginning with pymt, but we never been able to change it. Import in kivy are active not passive, and yes it is a bad design.
It may be nice to be able to change any kivy configuration token via environment (like KIVY_CONFIG_LOG_LEVEL=warning) or something like that.
Just for the reference, if we don't make the library active at import:

when do we load the configuration?
how do we handle logs that can be generated by any modules you import?
how do we handle initialization required for others modules to work? (the most known is any GL call require windows, but sometimes you can start writing GL-related code, or instanciate widget, without any window created. This was an issue as people didn't understood why it was crashing, and so now if the window is not created before a widget is instanciated, we create it to prevent crash. etc.)
how do we design it in a way that the user doesn't need to call "init()" or stuff like that ?
how do we do in a back compatible way?

In a way, we are closer to Panda3D.

@tito for what it's worth, one way to do this is on first resource access (window or image or font) but of course that may need be a lot of code revamp to make that happen

Ah, hope the above didn't come off as too negative - I managed to whip
together a nice UI in a really short time with kivy, and then was
frustrated by being unable to get past this tiny issue!
I am in fact leading towards late loading in a single place.  The program
in question allows a lot of other sorts of heavy resources (like a flask
instance) that don't get loaded until a very specific point ("right before
start") and treating kivy that way is perfectly reasonable and won't take
much code.
On Sun, Mar 10, 2019 at 5:55 PM JonasT<EMAIL_ADDRESS>wrote:

@tito https://github.com/tito for what it's worth, one way to do this
is on first resource access (window or image or font) but of course that
may need be a lot of code revamp to make that happen
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kivy/kivy/issues/6190#issuecomment-471323338, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAPdspSFognWQ7_KZavitMJuFy2ru58Bks5vVTkOgaJpZM4bmvcA
.

--
/t
PGP Key<EMAIL_ADDRESS>https://tom.ritchford.com https://tom.ritchford.com
https://tom.swirly.com https://tom.swirly.com

Just to let you know: it is a complex problem. Doing lazy initialization doesn't help, just to demonstrate with one simple example: let's say you want to change the configuration:
from kivy.config import Config
Config.set("kivy", "log_level", "warning")

Until today, we assumed that Config have the user configuration already loaded (config.ini). During the loading, we may encounter errors or display message about upgrading the configuration file. So it requires Logger and use it. So even if Logger would be a lazy object, at this point it would have been already used and installed:

"i want to control the config.ini loading, lemme do that if i want too": Ok, but then it's an additionnal call that is require everytime that you have to think about.
"i want lazy loading until it is actually required": Ok, but when is it actually required? When you do Config.set is that should be considered as a requirement? Or you want to actually "apply" your change on the Config later when it will be "get" by something else? (fun fact, in kivy import, we do command line processing that get/set the Config object.)

That's just one example.
So far, after discussing a little bit about "when is Kivy really needed", we didn't find an answer for now. Best approach to make it work today is what the PR #6192 : mapping environment variables to Config object. The documentation includes an example specific for this issue:
import os
# KCFG_<section>_<key> = <value>
os.environ["KCFG_KIVY_LOG_LEVEL"] = "warning"

And this will be mapped to:
Config.set("section", "key", "value")

Hope this will help.

Wow, thanks for that pull request!
Yes, I guessed that it would be even more tricky from your side.  Trying to
get things done during startup is always nasty (and shutdown issues can be
nasty too, I've experienced them many times...).
I have a few minor review comments about the pull request I'm preparing in
the other window, if that's OK?
Thanks again for an excellent package with a quite low WTF/minute rating.
On Tue, Mar 12, 2019 at 10:16 AM Mathieu Virbel<EMAIL_ADDRESS>wrote:

Just to let you know: it is a complex problem. Doing lazy initialization
doesn't help, just to demonstrate with one simple example: let's say you
want to change the configuration:
from kivy.config import Config
Config.set("kivy", "log_level", "warning")
Until today, we assumed that Config have the user configuration already
loaded (config.ini). During the loading, we may encounter errors or
display message about upgrading the configuration file. So it requires
Logger and use it. So even if Logger would be a lazy object, at this point
it would have been already used and installed:

"i want to control the config.ini loading, lemme do that if i want
too": Ok, but then it's an additionnal call that is require everytime that
you have to think about.
"i want lazy loading until it is actually required": Ok, but when is
it actually required? When you do Config.set is that should be
considered as a requirement? Or you want to actually "apply" your change on
the Config later when it will be "get" by something else? (fun fact, in
kivy import, we do command line processing that get/set the Config object.)

That's just one example.
So far, after discussing a little bit about "when is Kivy really needed",
we didn't find an answer for now. Best approach to make it work today is
what the PR #6192 https://github.com/kivy/kivy/pull/6192 : mapping
environment variables to Config object. The documentation includes an
example specific for this issue:
import os# KCFG__ =
os.environ["KCFG_KIVY_LOG_LEVEL"] = "warning"
And this will be mapped to:
Config.set("section", "key", "value")
Hope this will help.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kivy/kivy/issues/6190#issuecomment-471913813, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAPdspDGTk5vucvbk69CYP5jV80BKnm6ks5vV3B0gaJpZM4bmvcA
.

--
/t
PGP Key<EMAIL_ADDRESS>https://tom.ritchford.com https://tom.ritchford.com
https://tom.swirly.com https://tom.swirly.com


Use billing API to resolve what type of plan an organization has.

This uses the billing API to resolve what type of plan is used.

cc @fancyremarker @sandersonet

:+1: to merge after aptible/aptible-billing-ruby#1 and aptible/billing.aptible.com#1 are both merged, unless @sandersonet has issues.

We should probably bump this to 0.9.0, after that I'm :+1:


Remove enableTimeout api + allow overriding a disabled timeout

Description of the Change
Removed enableTimeout stuff. Use the latest timeout value to determine if enabled/disabled + its value. (disabled is value of 0, else is enabled).
Also fixes issue of tests not timing out when timeout is re-enabled. See associating issue https://github.com/mochajs/mocha/issues/4254.
Fixes https://github.com/mochajs/mocha/issues/4254
Alternate Designs
Could remove enableTimeouts from public-facing and use it internally, however it is easiest to have a single source of truth (the value) and mirror what the user uses. Having 2 different states which are very similar gets confusing.
Why should this be in core?
Simplify the codebase.
There are use-cases where it is useful to be able to re-enable and make use of a previously disabled timeout. Also seems pretty important that the feature behaves as a user would expect.
Possible Drawbacks
You can no longer restore a previously set timeout if disabled (enableTimeout(true) did) and must always explicitly set it again.
The default timeout value will now never be used as the user has to set a value to re-enable it anyway. That could be a good thing.
Anyone relying on enableTimeout to disable or re-enable timeouts will have to swap to using the explicit timeout. However if it is the correct behaviour and goes into the next major release, then should be fine.
Applicable issues
Fixes https://github.com/mochajs/mocha/issues/4254

Coverage increased (+0.002%) to 93.099% when pulling d5c703cccc8e99727d08daee5afb6abf1fbfb2cf on craigtaub/issue/4254-timeouts into 400bf9b9319bdf8f0d9aa05ff8c7a54f6fe65d2a on master.

Coverage 😕

@boneskull thanks for approval, happy to add docs, but seems we have couple of options for this:

Add docs and then merge - potentially removing code we will need later
Leave it and go fix silent exit issue in alternative PR, then come back in future date - not a fan of leaving this PR open indefinitely and that fix will not be quick
Revert to previous bug fix, leaving silent timeout issue for another time - I am more in favour of this tbh

@craigtaub

Add docs and then merge - potentially removing code we will need later (fixing silent exit issue)

A little confused on the wording here.  You mean that you want to address the silent exit issue in this PR (by exiting after 1e9ms)?

Revert to previous bug fix (commit), leaving silent timeout issue for another time - I am more in favour of this tbh. If turns out we can remove enableTimeout should be relatively easy to re-apply. Involves leaving most of the enableTimeout behaviour alone for now aswell, as we hopefully can remove it in future.

Does this mean closing this PR, or just taking the documentation?
If the situation is no "worse" than it already is--meaning we still have a potential silent exit problem--I don't see any reason not to merge this PR, unless I'm missing something.

@boneskull

A little confused on the wording here. You mean that you want to address the silent exit issue in this PR (by exiting after 1e9ms)?

Ah sorry badly written, i meant keep PR mostly as is. Removing code which might be useful for fixing the silent exit issue.

Does this mean closing this PR, or just taking the documentation?

Meant reverting all changes relating to removing enableTimeout, so back to this.

If the situation is no "worse" than it already is

The worry is we remove enableTimeout and it turns out to be necessary to fix the silent exit issue, I just dont know what that will entail.
Im actually now thinking if the fix for silent exits is a while away, it is fine to merge this PR as it improves the area for right now, and if we need a new state mechanism it can be added as part of the silent exit fix. Thoughts?

I think we could fix it with an interval which ran infinitely until the test completes or we exit via other means. essentially put a dummy timer into the event loop. this wouldn’t need another state variable. would have to play with it though

do whatever you think is best.


randomize playlist order, i.e.  --playlist-random

[x] I've verified and I assure that I'm running youtube-dl 2017.01.29
[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Feature request (request for a new functionality)

Please add support for randomizing the playlist download order via  --playlist-random (or whatever other switch name).
Since there is already an option for --reverse-playlist, I don't think this should be too hard? (I'd contribute it myself if I was more confident in my python skills.)
The motivation for this feature is that it could be used in conjunction with --max-downloads (i.e. set to a low value) to randomly "sample" a variety of videos from across a channel with lots of videos, as opposed to just being able to get the first few (or last few, using --reverse-playlist).

I should also add that the "random sampling" scenario I outlined above should be possible because you would be able to combine it with --download-archive to ensure that you don't get repeated videos in the random selection.
Here I'm referencing the fact youtube-dl already does the correct thing when you combine --download-archive with --max downloads N, namely, that you get the next "N" files that you haven't already downloaded--as opposed to "the N-or-fewer files  out of the first N according to the selected playlist order." The latter is a perfectly valid interpretation—and could have been the implemented behavior—for the interaction between --max-downloads and --download-archive when both switches are present.

New parameter added. Pull request created.

Oh, I tested my code with '--max-downloads' and '--download-archive' - seems to work as intended!

Thanks to @ThomasChr, there's --playlist-random now!

Very many thanks!


Check log_level for all platforms - 639

[Auto generated]
Number: [#639]

openshift-cli-installer(RqEyb)[PR 639]: Closing issue for PR: Check log_level for all platforms.
PR was closed.


django 2.x

Would there be any update for django 2.0?

According to django-CMS's-3.5 setup.py, Django-2.0 is not supported yet. Therefore django-SHOP still sticks with it. I'm sorry, this is not my fault.


How to disable magnet links?

Is it possible to disable magnet links? Elementum/Burst hangs when it scrapes a magnet link that has no available trackers. This behavior often occurs with older releases.

Not possible.

Thankyou


add support for other devices

Edit 2:
Could you please add build instructions? I'm not quite familiar with visual studio projects.
Edit:
I see now: https://github.com/platinum95/SaorCon/blob/bd16ff48fdcfc3517fb7cb4de7068f0c4170b98d/SaorCon/MainWindow.xaml.cs#L17
I will take a look at this to see if I can play with the bluetooth IDs and figure out what info I need to plug in here to get this working.

It's possible other Bose devices could work with this util with minor changes to our BT device query

Original message below:
Hi,
Thanks for building this!
Could you please do a quick note on which file to look at to add support for other devices? I have a Bose NC700 and Bose QuietComfort True Wireless and I don't think it detects the 2.
What do I need to do to add support for these devices?
Thanks!

Hi there,
First and foremost, as you found, you'll need to add the Vendor/Product ID(s) into that device query. The Protocol ID in that query is just for filtering down to all Bluetooth devices, the Vendor/Product IDs are where we filter out specific devices. The vendor ID for your devices will probably be the same for your devices (158 is Bose).
If the new devices support the same ANC/Battery reporting protocol as the QC35 headphones, that should be all that's required.
Otherwise, you'll need to add a new implementation of IBoseDevice which will provide the different readings to the UI.
As far as build instructions go, there's not much to it, just open the solution (SaorCon.sln) and hit build/run. I've just updated the solution to remove some old projects that may have thrown up some (harmless) warning dialogues when loading the solution. There are also 4 dependencies that should be installed automatically by the Nuget package manager.

Hi @Snuupy, I've managed to add support for Bose QC35 II via this Pull Request: #3
To add support for your Bose NC700 and Bose QuietComfort True Wireless, I imagine it's something similar to what I've done in my PR (Assuming the newer devices use the same ANC/Battery reporting as the QC35)
You can find the ProductID in Windows by following these steps (There's probably a better way but this is the only way i know how):

Open Device Manager
Navigate to Sound, video and game controllers and double click on your Bose device. In my case, there was 2 devices - you'll want the one without Hands Free in the name
Open the Details tab and select Hardware ID in the dropdown
Look for PID in the text area - PID stands for ProductID. Ignore the & symbol. My PID was 4020.
This appears to be a Hex value, convert it using a random Hex to Decimal website. Mine was 16416 for my Bose QC35 II. VendorID s

Hopefully the above info & image is useful

Hi @stebaker92, thanks for the info! I will put some time into figuring this out and playing with it.

It's possible the NC700 only supports control over BLE. As far as I'm aware, the QC35 supports control over both rfcomm and BLE, with the latter being a newer feature (and apparently the only thing the Bose app uses now), so if that's the case it's possible they dropped rfcomm entirely for new products.
Ideally we could add BLE support to SaorCon; in fact the original plan was to use BLE control exclusively for the QC35 but I was having trouble reverse engineering it so I opted for the already reverse-engineered rfcomm protocol controls.
I'll dig into it a bit more when I have some free time. Maybe this is an excuse to drop another 400 bucks on a shiny new set of headphones :grinning:

Thanks for updating @Snuupy. The Bluetooth packets must be different on the NC700, it might be worth looking at other developers implementation of similar software. I've found an android app that handles both the QC35 and NC700:
https://github.com/danielgjackson/noisecancel/#how-nc700
It might be worth experimenting with the commands listed in the readme

PIDs:
NC700: 16420
TWS: 16431

Update: something must have changed between the QC35 I/II and the NC700 because dragging the slider does not change the noise cancellation and the battery shows -1%.

Regarding battery % on the NC700, I was able to get this working by creating a new implementation of IBoseDevice where the payload length check is removed.
private static Int16 ConvertBatteryLevel( byte[] payload )
        {
            // Bose NC 700 always returns payload length 4, but first value in the array is battery level
	     //if ( payload.Length != 1 )
            //    return -1;
            return Convert.ToInt16( payload[0] );
        }

It appears that the first item in the payload array corresponds to the battery level for the NC700.

Nice find, and good timing, recently picked up a pair of NC700s and started adding support for them. I've got a first-pass of ANC support working, so it looks like between us we've got full support.
Feel free to submit a PR, or I can incorporate what you've found into my changes.

Added basic support for the NC700 in 26a31d6. Still improvements & cleanup to be made, but it's at least somewhat functional.
I had a look at the BT transactions between the NC700 and my Android device when using the official app, there are a bunch of messages being sent back and forth that I haven't worked out the function of yet. Most importantly, I think there's one that tells the headphones to intermittently report battery/ANC changes, since we don't get the same reports as we do for the QC35s.
There are a few messages that were pretty straightforward to work out, mainly around requesting Serial numbers, device name, manufacturing date etc. These aren't very useful to us in the context of this tool though.


Handles the START response

Closes #8
Replaces the previous started boolean with an enum of possible states.
Only set the status to started after receiving the START response.
Previously we assumed we were started after we sent the initial START
message.
This makes room for a stream so apps can listen to the status changes,
but this does not include the stream.
Add unit tests for verifying status set correctly.
cc @zbarbuto

Pull Request Test Coverage Report for Build 52

11 of 12 (91.67%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+1.9%) to 94.203%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/src/remote_devtools_middleware.dart
11
12
91.67%

Files with Coverage Reduction
New Missed Lines
%

lib/src/remote_devtools_middleware.dart
1
91.49%

Totals

Change from base Build 50:
1.9%

Covered Lines:
65

Relevant Lines:
69

💛  - Coveralls


Need ability to specify ".deps" directory

While experimenting with customizing the output directories, I was unable to find an option to change the ".deps" directory. I expected something similar to set_targetdir( ... ). Am I missing it somewhere? Or is it not built-in yet?
Thanks.

I have added set_dependir api to set the .deps directory for targets.
set_dependir("$(buildir)/xxx/xxx/.deps")

It looks good from my local testing.
Thanks!


adjustToColor() doesn't play nicely with supportsShadesOfGray

Hello,
I'm trying to create a pretty simple color selection view and have had a lot of problems with trying to use adjustToColor() with colors only achievable in grayscale. When adjusted to a grayscale color in full color mode or vice versa, the currentColor of the picker seems to become pretty erratic. It's hard to quantify the exact issue, but I think that the adjustToColor() method needs to somehow take grayscale mode into greater consideration.
Thanks,
Kevin

Closing this issue due for inactivity. If this issue still persists please re-open the issue :).


Can not load bootstrap glyphicons

Directive works fine, but constantly getting two errors in a  console.
GET http://localhost:8080/fonts/glyphicons-halflings-regular.woff
GET http://localhost:8080/fonts/glyphicons-halflings-regular.ttf

I second that. Is there an option to customize the icons? What if I want to use font-awesome, for example?

+1 for customizing this. I need font-awesome as well

+1


Sometimes maxTextureUnits is unintialized.

https://github.com/AcademySoftwareFoundation/MaterialX/blob/4f44b5a0e465ba6ec9abe8f246b504517fa32efa/source/MaterialXRenderGlsl/GLTextureHandler.cpp#L25-L27
Expected behaviour:
int maxTextureUnits is set to 16 and not uninitialized.

@fire Can you elaborate on the situations in which maxTextureUnits would be uninitialized after the call to glGetIntegerv?  Is there a common error case that we're not handling?

I'm not sure, but I think this happens when I'm on a server without a gpu. I may have removed some checks.

@fire My current thinking is that this case should be caught during OpenGL initialization, so that we'd never reach this code path without access to a working OpenGL context (either using a GPU or virtual framebuffer).  That seems like a safer approach than omitting the initialization checks and trying to handle an invalid context within each individual call.

I'll close out this issue for now, but feel free to open a new issue if you have proposals for related improvements in the future.


[ownership] Move lowering past SILCombine and right before the inliner.

Just a good place to test this functionality separately from the inliner.
NOTE: There is currently a draft since there is one commit I am going to get in via a different PR. This PR I am going to use initially for testing and maybe once that other commit lands, rebase on top and just move the passes as an independent change into the tree.

@swift-ci test

@swift-ci test source compatibility

@swift-ci benchmark

@swift-ci test

@swift-ci benchmark

@swift-ci test source compatibility

@swift-ci smoke test compiler performance

Just to note, current source compat release failures:
18:12:47   FAIL: Dollar, 5.1, 4feadc, Dollar, generic/platform=macOS
18:12:47   FAIL: Dollar, 4.0, 433d4b, Dollar, generic/platform=macOS
18:12:47   FAIL: GRDB.swift, 5.0, 759c10, Swift Package
18:12:47   FAIL: GRDB.swift, 4.2, 759c10, Swift Package
18:12:47   FAIL: Kitura, 5.1, 8578c4, Swift Package
18:12:47   FAIL: Kitura, 4.0, f1c316, Swift Package
18:12:47   FAIL: ProcedureKit, 5.1, a7fa56, ProcedureKitCloud, platform=macOS
18:12:47   FAIL: ProcedureKit, 5.1, a7fa56, ProcedureKit, generic/platform=tvOS
18:12:47   FAIL: ProcedureKit, 5.1, a7fa56, ProcedureKit, generic/platform=iOS
18:12:47   FAIL: ProcedureKit, 5.1, a7fa56, ProcedureKit, platform=macOS
18:12:47   FAIL: ProcedureKit, 5.0, a7fa56, ProcedureKitCloud, platform=macOS
18:12:47   FAIL: ProcedureKit, 5.0, a7fa56, ProcedureKit, generic/platform=tvOS
18:12:47   FAIL: ProcedureKit, 5.0, a7fa56, ProcedureKit, generic/platform=iOS
18:12:47   FAIL: ProcedureKit, 5.0, a7fa56, ProcedureKit, platform=macOS
18:12:47   FAIL: ProcedureKit, 4.2, 94193d, ProcedureKitCloud, platform=macOS
18:12:47   FAIL: ProcedureKit, 4.2, 94193d, ProcedureKit, generic/platform=tvOS
18:12:47   FAIL: ProcedureKit, 4.2, 94193d, ProcedureKit, generic/platform=iOS
18:12:47   FAIL: ProcedureKit, 4.2, 94193d, ProcedureKit, platform=macOS
18:12:47   FAIL: swift-log, 5.2, 16cfcc, Swift Package
18:12:47   FAIL: swift-log, 5.0, 16cfcc, Swift Package
18:12:47   FAIL: async-http-client, 5.0, a72c5a, Swift Package
18:12:47   FAIL: swift-distributed-tracing, 5.2, 73f2b5, Swift Package
18:12:47   FAIL: swift-distributed-tracing, 5.0, 73f2b5, Swift Package
18:12:47   FAIL: swift-cluster-membership, 5.2, 0fd434, Swift Package
18:12:47   FAIL: SwiftyJSON, 5.1, bad5f2, SwiftyJSON watchOS, generic/platform=watchOS
18:12:47   FAIL: SwiftyJSON, 5.1, bad5f2, SwiftyJSON tvOS, generic/platform=tvOS
18:12:47   FAIL: SwiftyJSON, 5.1, bad5f2, SwiftyJSON iOS, generic/platform=iOS
18:12:47   FAIL: SwiftyJSON, 5.1, bad5f2, SwiftyJSON macOS, platform=macOS
18:12:47   FAIL: SwiftyJSON, 5.0, b93c5d, SwiftyJSON watchOS, generic/platform=watchOS
18:12:47   FAIL: SwiftyJSON, 5.0, b93c5d, SwiftyJSON tvOS, generic/platform=tvOS
18:12:47   FAIL: SwiftyJSON, 5.0, b93c5d, SwiftyJSON iOS, generic/platform=iOS
18:12:47   FAIL: SwiftyJSON, 5.0, b93c5d, SwiftyJSON macOS, platform=macOS
18:12:47   FAIL: SwiftyJSON, 4.2, b93c5d, SwiftyJSON watchOS, generic/platform=watchOS
18:12:47   FAIL: SwiftyJSON, 4.2, b93c5d, SwiftyJSON tvOS, generic/platform=tvOS
18:12:47   FAIL: SwiftyJSON, 4.2, b93c5d, SwiftyJSON iOS, generic/platform=iOS
18:12:47   FAIL: SwiftyJSON, 4.2, b93c5d, SwiftyJSON macOS, platform=macOS
18:12:47   FAIL: vapor_console, 5.1, fcd8c1, Swift Package
18:12:47 ========================================

And the debug has had issues over the past bit just building. Just going to make sure I didn't make this worse.

Performance: -O

Regression
OLD
NEW
DELTA
RATIO

FlattenListLoop
1682
2515
+49.5%
0.67x (?)

StringInterpolation
10800
12400
+14.8%
0.87x (?)

ObjectiveCBridgeFromNSArrayAnyObjectForced
4500
4960
+10.2%
0.91x (?)

StringBuilderLong
1350
1480
+9.6%
0.91x (?)

Improvement
OLD
NEW
DELTA
RATIO

StringFromLongWholeSubstringGeneric
8
5
-37.5%
1.60x

LessSubstringSubstring
44
39
-11.4%
1.13x

StringToDataMedium
3800
3400
-10.5%
1.12x (?)

EqualSubstringSubstring
42
39
-7.1%
1.08x (?)

EqualSubstringString
42
39
-7.1%
1.08x (?)

EqualStringSubstring
43
40
-7.0%
1.07x

EqualSubstringSubstringGenericEquatable
43
40
-7.0%
1.07x

LessSubstringSubstringGenericComparable
43
40
-7.0%
1.07x (?)

SortStringsUnicode
3100
2895
-6.6%
1.07x (?)

Code size: -O
Performance: -Osize

Regression
OLD
NEW
DELTA
RATIO

Diffing.Same
8
9
+12.5%
0.89x (?)

ObjectiveCBridgeFromNSArrayAnyObjectForced
4660
5120
+9.9%
0.91x (?)

Improvement
OLD
NEW
DELTA
RATIO

StringFromLongWholeSubstringGeneric
8
5
-37.5%
1.60x

String.data.LargeUnicode
126
106
-15.9%
1.19x (?)

FlattenListFlatMap
7092
6061
-14.5%
1.17x (?)

LessSubstringSubstringGenericComparable
44
39
-11.4%
1.13x

LessSubstringSubstring
43
39
-9.3%
1.10x (?)

InsertCharacterEndIndexNonASCII
65
59
-9.2%
1.10x (?)

EqualStringSubstring
44
40
-9.1%
1.10x (?)

EqualSubstringSubstringGenericEquatable
44
40
-9.1%
1.10x (?)

StringWalk
2720
2520
-7.4%
1.08x

StrComplexWalk
5150
4780
-7.2%
1.08x

Code size: -Osize
Performance: -Onone

Regression
OLD
NEW
DELTA
RATIO

FloatingPointPrinting_Float_description_uniform
19800
25100
+26.8%
0.79x (?)

FloatingPointPrinting_Float_description_small
22140
27216
+22.9%
0.81x (?)

StringBuilderLong
2350
2720
+15.7%
0.86x (?)

ArrayLiteral2
3286
3743
+13.9%
0.88x (?)

PrefixWhileCountableRangeLazy
52589
56776
+8.0%
0.93x (?)

ArrayValueProp
5196
5606
+7.9%
0.93x (?)

ArrayOfPOD
1061
1142
+7.6%
0.93x (?)

Improvement
OLD
NEW
DELTA
RATIO

StringFromLongWholeSubstringGeneric
99
90
-9.1%
1.10x (?)

DataReplaceSmallBuffer
6000
5500
-8.3%
1.09x (?)

ClassArrayGetter2
4830
4490
-7.0%
1.08x (?)

Code size: -swiftlibs

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@swift-ci benchmark

Release source compat failed due to a weird module map issue.

Not this PR for sure.

Debug one hit the same thing:
23:19:17 49%: Compile Triple.cpp (x86_64)
23:19:17 49%: Compile Swift source files (arm64)
23:19:17 fatal error: module map file '/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-debug/build/compat_macos/swiftpm-macosx-x86_64/apple/Intermediates.noindex/GeneratedModuleMaps/macosx/CCryptoBoringSSL.modulemap' not found
23:19:17
23:19:17 fatal error: module map file '/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-debug/build/compat_macos/swiftpm-macosx-x86_64/apple/Intermediates.noindex/GeneratedModuleMaps/macosx/CCryptoBoringSSL.modulemap' not found
23:19:17
23:19:17 fatal error: module map file '/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-debug/build/compat_macos/swiftpm-macosx-x86_64/apple/Intermediates.noindex/GeneratedModuleMaps/macosx/CCryptoBoringSSL.modulemap' not found
23:19:17
23:19:17 fatal error: module map file '/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite-debug/build/compat_macos/swiftpm-macosx-x86_64/apple/Intermediates.noindex/GeneratedModuleMaps/macosx/CCryptoBoringSSL.modulemap' not found
23:19:17
23:19:18 49%: Compile Threading.cpp (x86_64)
23:19:18 49%: Compile TargetParser.cpp (x86_64)
23:19:18 1 error generated.
23:19:18
23:19:18 2 errors generated.
23:19:18
23:19:18 1 error generated.
23:19:18
23:19:18 Build cancelled
23:19:18 env SDKROOT=/Applicat

Performance: -O

Regression
OLD
NEW
DELTA
RATIO

UTF8Decode_InitFromData_ascii_as_ascii
628
742
+18.2%
0.85x (?)

StringToDataLargeUnicode
3450
3900
+13.0%
0.88x (?)

StringInterpolation
10900
12300
+12.8%
0.89x (?)

UTF8Decode_InitFromBytes_ascii_as_ascii
445
497
+11.7%
0.90x (?)

ObjectiveCBridgeToNSDictionary
15000
16200
+8.0%
0.93x (?)

Improvement
OLD
NEW
DELTA
RATIO

StringFromLongWholeSubstringGeneric
8
5
-37.5%
1.60x

FlattenListFlatMap
4547
3889
-14.5%
1.17x (?)

LessSubstringSubstring
44
39
-11.4%
1.13x (?)

DictionaryKeysContainsCocoa
35
32
-8.6%
1.09x (?)

ObjectiveCBridgeStubFromArrayOfNSString2
2630
2440
-7.2%
1.08x (?)

EqualSubstringString
42
39
-7.1%
1.08x (?)

EqualStringSubstring
43
40
-7.0%
1.07x (?)

Code size: -O
Performance: -Osize

Improvement
OLD
NEW
DELTA
RATIO

StringFromLongWholeSubstringGeneric
8
5
-37.5%
1.60x

EqualStringSubstring
44
39
-11.4%
1.13x (?)

LessSubstringSubstringGenericComparable
44
39
-11.4%
1.13x

LessSubstringSubstring
43
39
-9.3%
1.10x

InsertCharacterEndIndexNonASCII
65
59
-9.2%
1.10x (?)

EqualSubstringSubstringGenericEquatable
44
40
-9.1%
1.10x (?)

StringWalk
2720
2520
-7.4%
1.08x (?)

EqualSubstringSubstring
42
39
-7.1%
1.08x (?)

EqualSubstringString
42
39
-7.1%
1.08x (?)

StrComplexWalk
5150
4790
-7.0%
1.08x (?)

InsertCharacterEndIndex
177
165
-6.8%
1.07x (?)

Code size: -Osize
Performance: -Onone

Regression
OLD
NEW
DELTA
RATIO

FloatingPointPrinting_Float_description_uniform
19800
25000
+26.3%
0.79x (?)

FloatingPointPrinting_Float_description_small
22140
27216
+22.9%
0.81x

UTF8Decode_InitFromBytes_ascii_as_ascii
468
523
+11.8%
0.89x (?)

StringToDataLargeUnicode
8650
9450
+9.2%
0.92x (?)

ArrayOfPOD
1060
1142
+7.7%
0.93x (?)

Improvement
OLD
NEW
DELTA
RATIO

StringFromLongWholeSubstringGeneric
99
90
-9.1%
1.10x (?)

ClassArrayGetter2
4830
4490
-7.0%
1.08x (?)

Code size: -swiftlibs

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

Compilation-performance test failed

Release source compat failed due to a weird module map issue.

@gottesmm There is a discussion about that on https://github.com/apple/swift/pull/35503 :)

This one I happen to know something about: FloatingPointPrinting_Float_description_uniform. That test just converts a bunch of float values to string in a tight loop.  Interesting point: those strings should all be small, so it should not be creating refcounted objects at all.

I don't think the perf changes are real. Going to run again.

@swift-ci benchmark

Not real in the sense that the regressions are changing each time suggesting noise.

Performance: -O

Improvement
OLD
NEW
DELTA
RATIO

StringFromLongWholeSubstringGeneric
7
5
-28.6%
1.40x

UTF8Decode_InitFromData_ascii_as_ascii
748
659
-11.9%
1.14x (?)

String.data.LargeUnicode
111
101
-9.0%
1.10x (?)

Code size: -O
Performance: -Osize

Regression
OLD
NEW
DELTA
RATIO

FlattenListFlatMap
3888
6093
+56.7%
0.64x (?)

UTF8Decode_InitFromData_ascii_as_ascii
612
662
+8.2%
0.92x (?)

Improvement
OLD
NEW
DELTA
RATIO

StringFromLongWholeSubstringGeneric
7
5
-28.6%
1.40x

InsertCharacterEndIndexNonASCII
65
59
-9.2%
1.10x (?)

InsertCharacterEndIndex
181
165
-8.8%
1.10x (?)

Code size: -Osize
Performance: -Onone

Regression
OLD
NEW
DELTA
RATIO

FloatingPointPrinting_Float_description_uniform
19700
25100
+27.4%
0.78x (?)

FloatingPointPrinting_Float_description_small
22032
27108
+23.0%
0.81x

StringBuilderLong
2280
2610
+14.5%
0.87x (?)

ErrorHandling
4590
5240
+14.2%
0.88x (?)

StringBuilderSmallReservingCapacity
3012
3264
+8.4%
0.92x (?)

DropWhileAnySeqCntRange
69710
75477
+8.3%
0.92x (?)

StringUTF16Builder
3080
3330
+8.1%
0.92x (?)

StringBuilder
3044
3279
+7.7%
0.93x (?)

Improvement
OLD
NEW
DELTA
RATIO

StringFromLongWholeSubstringGeneric
99
90
-9.1%
1.10x (?)

ClassArrayGetter2
4840
4490
-7.2%
1.08x (?)

Code size: -swiftlibs

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

If you look at the 3 groups of results for -O, -Osize every time the regressions are changing suggesting they are noise. Consider for -O:
FlattenListLoop | 1682 | 2515 | +49.5% | 0.67x (?)
StringInterpolation | 10800 | 12400 | +14.8% | 0.87x (?)
ObjectiveCBridgeFromNSArrayAnyObjectForced | 4500 | 4960 | +10.2% | 0.91x (?)
StringBuilderLong | 1350 | 1480 | +9.6% | 0.91x (?)

UTF8Decode_InitFromData_ascii_as_ascii | 628 | 742 | +18.2% | 0.85x (?)
StringToDataLargeUnicode | 3450 | 3900 | +13.0% | 0.88x (?)
StringInterpolation | 10900 | 12300 | +12.8% | 0.89x (?)
UTF8Decode_InitFromBytes_ascii_as_ascii | 445 | 497 | +11.7% | 0.90x (?)
ObjectiveCBridgeToNSDictionary | 15000 | 16200 | +8.0% | 0.93x (?)

StringFromLongWholeSubstringGeneric | 7 | 5 | -28.6% | 1.40x
UTF8Decode_InitFromData_ascii_as_ascii | 748 | 659 | -11.9% | 1.14x (?)
String.data.LargeUnicode | 111 | 101 | -9.0% | 1.10x (?)

And for -Osize:
Diffing.Same | 8 | 9 | +12.5% | 0.89x (?)
ObjectiveCBridgeFromNSArrayAnyObjectForced | 4660 | 5120 | +9.9% | 0.91x (?)

StringFromLongWholeSubstringGeneric | 8 | 5 | -37.5% | 1.60x
EqualStringSubstring | 44 | 39 | -11.4% | 1.13x (?)
LessSubstringSubstringGenericComparable | 44 | 39 | -11.4% | 1.13x
LessSubstringSubstring | 43 | 39 | -9.3% | 1.10x
InsertCharacterEndIndexNonASCII | 65 | 59 | -9.2% | 1.10x (?)
EqualSubstringSubstringGenericEquatable | 44 | 40 | -9.1% | 1.10x (?)
StringWalk | 2720 | 2520 | -7.4% | 1.08x (?)
EqualSubstringSubstring | 42 | 39 | -7.1% | 1.08x (?)
EqualSubstringString | 42 | 39 | -7.1% | 1.08x (?)
StrComplexWalk | 5150 | 4790 | -7.0% | 1.08x (?)
InsertCharacterEndIndex | 177 | 165 | -6.8% | 1.07x (?)

FlattenListFlatMap | 3888 | 6093 | +56.7% | 0.64x (?)
UTF8Decode_InitFromData_ascii_as_ascii | 612 | 662 | +8.2% | 0.92x (?)

Merging!


Implement command response sending and receiving for MonoBehaviours

Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.

Description
Implements the CommandResponseHandler, and sending of responses for commands
Builds on top of #238
Added test logic into playground
Refactored delegate calling into its own reusable function
Tests
Tested locally to confirm that responses can be sent and received
Added automated tests
All tests pass
Documentation
Undocumented at the moment
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.
@MPeti01 @zeroZshadow

As discussed offline? Can we combine CommandRequestSenders with CommandResponseHandlers?

Part of this is being redone as it was revealed that we didn't stick to the design (linked as a comment in the ticket).
Basically I will be removing the sendResponse parts from the injectable receiver and wrap the request object with something which has respond methods

@JonasImprobable re: to combine CommandRequestSenders with CommandResponseHandlers, I'll do that in a separate PR


Dynamic View vs Find

I need to display a dashboard and I have about a 1000 queries that need to be run to verify what need to be display.  I was wondering if it would be more efficient to do run a query every x second and run all my Queries about 600-1000 or if LokiJS Dynamic view would be efficient with 1000 view in memory?
The query only return no more than 1 item and the database would hold between 50K to 100K items.

I met run a function every x second and run all my Queries.

Dynamic views are useful if you can 'share' common filtering across multiple queries.  I would not run 1000 different dynamic views just because it would slow down inserts/updates/removes because each dynamic view is notified to (re)evaluate them.
Can you describe (in general) what your queries look like?  Are they all querying the same properties or different ones?  Does each query just query against 1 column or multiple? Are you using find filters or where filters?  Do you already have any binary or unique indices setup for that collection?
If you can 'share' common filters across several queries, I might use a dynamic view. I would be curious about measuring performance without them first though.


Switch to using Datastore in serve.js

Add required composite index to index.yaml
nit: Singularize "aggresiveRemovalMetric" in Angular scope (for consistency)
Unify Angular chart classes (underlying data model was already unified)
Do not auto-validate BrowserMetricData: May be created empty by DatastoreDAO
Delete "api analytics" that contained duplicate info in analysis chart

@shepheb PTAL for Angular part

Codecov Report

Merging #73 into datastore-metrics-upload will increase coverage by 0.58%.
The diff coverage is 14.28%.

@@                     Coverage Diff                      @@
##           datastore-metrics-upload      #73      +/-   ##
============================================================
+ Coverage                      66.8%   67.39%   +0.58%
============================================================
  Files                            32       29       -3
  Lines                          1464     1426      -38
  Branches                        104      104
============================================================
- Hits                            978      961      -17
+ Misses                          486      465      -21

Impacted Files
Coverage Δ

lib/controller/api_catalog.es6.js
9.52% <ø> (-1.42%)
:arrow_down:

lib/confluence/browser_metric_data.es6.js
62.5% <ø> (-37.5%)
:arrow_down:

lib/chart/browser_metric_chart.es6.js
22.22% <ø> (ø)

lib/client/api_confluence.es6.js
12% <0%> (ø)
:arrow_up:

lib/chart/time_series_chart.es6.js
8.77% <0%> (+0.15%)
:arrow_up:

lib/controller/api_confluence.es6.js
8.47% <33.33%> (-3.39%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dcb4ba...994443f. Read the comment docs.


federate multiple apiary instances in same account

As a SysOps
I want to federate multiple apiary instances in a single account,
So that we can run ETLs and copy data from one instance to another.

already completed, closing.


zmap unable to write to file

I run zmap get the error 'csv: unable to write to file',I saved the data to /var/ directory,follow is zmap log.
``Dec 14 18:17:26.176 [WARN] monitor: Dropped 240 packets in the last second, (46282 total dropped (pcap: 46282 + iface: 0))
Dec 14 18:17:28.852 [WARN] monitor: Dropped 338 packets in the last second, (46796 total dropped (pcap: 46796 + iface: 0))
Dec 14 18:17:31.010 [WARN] monitor: Dropped 324 packets in the last second, (47509 total dropped (pcap: 47509 + iface: 0))
Dec 14 18:17:32.734 [WARN] monitor: Dropped 480 packets in the last second, (48363 total dropped (pcap: 48363 + iface: 0))
Dec 14 18:17:33.143 [WARN] monitor: Dropped 259 packets in the last second, (48716 total dropped (pcap: 48716 + iface: 0))
Dec 14 18:17:36.628 [WARN] monitor: Dropped 273 packets in the last second, (49140 total dropped (pcap: 49140 + iface: 0))
Dec 14 18:17:38.661 [WARN] monitor: Dropped 221 packets in the last second, (49800 total dropped (pcap: 49800 + iface: 0))
Dec 14 18:17:40.355 [WARN] monitor: Dropped 268 packets in the last second, (50271 total dropped (pcap: 50271 + iface: 0))
Dec 14 18:20:03.461 [FATAL] csv: unable to write to file @zakird @dadrian

the version I used is v2.1.1 @zakird

and this is my vps config.  @zakird @dadrian
Filesystem      Size  Used Avail Use% Mounted on
udev            3.9G     0  3.9G   0% /dev
tmpfs           799M  8.6M  790M   2% /run
/dev/xvda1      394G  2.7G  375G   1% /
tmpfs           3.9G     0  3.9G   0% /dev/shm
tmpfs           5.0M     0  5.0M   0% /run/lock
tmpfs           3.9G     0  3.9G   0% /sys/fs/cgroup
tmpfs           799M     0  799M   0% /run/user/1000

zmap -p 80 -o - -b /root/iots0.1/blacklist.conf -w /root/iots0.1/global_ip -B 30M -c 8 -M tcp_synscan -l /var/metadata/20161214T164559/80-http-banner-ipv4_full-20161214T1646-zmap-log.log -m /var/metadata/20161214T164559/80-http-banner-ipv4_full-20161214T1646-zmap-metadata.json 2>/dev/null | ztee /var/metadata/20161214T164559/80-http-banner-ipv4_full-20161214T1646-zmap-results.csv | zgrab --port=80 --http="/" --output-file=- --gomaxprocs=3 --http-max-redirects=3 --senders=2000 --timeout=5 --log-file=/var/metadata/20161214T164559/80-http-banner-ipv4_full-20161214T1646-zgrab-log.log --metadata-file=/var/metadata/20161214T164559/80-http-banner-ipv4_full-20161214T1646-zgrab-metadata.json 2>/dev/null | tee /var/metadata/20161214T164559/80-http-banner-ipv4_full-20161214T1646-zgrab-results.json | java -jar /root/iots0.1/lib/jar/matchapp.jar "match-ipv4_full-20161214T164559" 80 "HTTP" TCP 0 2>match.log @zakird

@beruhan Stop tagging individual contributors.


Add XROT cutom axis

PR to follow up on the inclusion of the new custom axis XROT #41

Note to self, before merging I should run this and other PRs descriptions via Sarah

This needs images before merging.


Set Progress.Bar width to 100%

Hello Joel and RNP community,
Thanks for creating and open sourcing such a helpful lib. I'm using it for all my react-native projects.
In one of those projects, I need to set the width of the progress bar to 100%. I did it by passing width={null} to progress bar. This sets the width to 100 %, but the progress animation is hindered (gif attached).

How to go about this ?
Thank you.

Setting the width to null seems causes a few rendering issues. I don't think that it is supported :)
@oblador instead of using absolute widths, perhaps it would be a nice idea to use the flex system? For example 60% fill:
<View style={{ flexDirection: "row", backgroundColor: "gray" }}>
  <View style={{ flex: 0.6, height: 20, backgroundColor: "green" }} />
  <View style={{ flex: 0.4}} />
 </View>

It is great to have a possibility to use flex. Any updates, plans?

+1, flex should be supported...
I had to use Dimensions.get('window').width instead

Percentage based width is now supported, this is how I accomplish it here rather than having to do some sort of flex hack https://github.com/codedailyio/react-native-animated-bar

Prop : width | Default : 150
Set to null to use automatic flexbox sizing.


Solution for: AttributeError: module 'pyrealsense2' has no attribute 'pipeline'

|---------------------------------|------------------------------------------- |
| Camera Model                       | { T265 } |
| Firmware Version                   | {<IP_ADDRESS>1} |
| Operating System & Version |   {Linux (Ubuntu 20.04.3)}  |
| Kernel Version (Linux Only)    |  {5.4.0-1047-raspi}            |
| Platform                                 | {Raspberry Pi 4B} |
| SDK Version                            |  { 2.49.0 }                          |
| Language                            |  {python }                          |
| Segment			|  {Drone/VR/AR/others }                          |
Issue Description
The issue was described in #9249 and #4483, but the solution was never given.
The problem is that the pyrealsense2 library file could not be found. In my case building the source from scratch, it is called pyrealsense2.cpython-38-aarch64-linux-gnu.so. This file is located at ~/librealsense/build/wrappers/python/.
You need to copy this file to /usr/local/lib. Which in my case is the same location as my librealsense2.so file.
Then create an entry at the bottom of your ~/.bashrc file as
export PYTHONPATH=$PYTHONPATH:/usr/local/lib
Finally, either source ~/.bashrc to make that statement effective now, or open a new terminal window.

Hi building from source using method described in this https://github.com/IntelRealSense/librealsense/issues/13445
I did make changes to the bash script:

cmake ../ -DFORCE_LIBUVC=true -DCMAKE_BUILD_TYPE=release -DBUILD_EXAMPLES=true -DBUILD_GRAPHICAL_EXAMPLES=true -DBUILD_WITH_CUDA=on -DFORCE_RSUSB_BACKEND=TRUE -DBUILD_PYTHON_BINDINGS:bool=true -DPYTHON_EXECUTABLE=/usr/bin/python3

I still don't see any .so file in my build/wrappers/python/ folder. Where do I look for .so file?


Adds support for stringable OneclickMall responses

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.474%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
378

Relevant Lines:
380

💛  - Coveralls


Fixes to handle source file changes

Description
UniProt and MGI files have recently changed and thus their parsers needed updating to handle those changes.
Use case
The UniProt Swissprot now includes versioned stable IDs in the Ensembl mapping lines. This leads to problems with isoform xrefs and potentially other issues. Thus, the version is trimmed from the stable ID, maintaining the original code behavior.
The MGI MRK_List2.rpt file can contain special characters that makes the MGI_desc_parser fail. Adding the 'binary' option into the Text::CSV constructor fixes this.
Benefits
No failures in MGI parser and correct uniprot isoform xrefs.
Possible Drawbacks
Need to check impact on browser
Testing
Have you added/modified unit tests to test the changes?
No
If so, do the tests pass/fail?
Have you run the entire test suite and no regression was detected?

Coverage decreased (-0.2%) to 82.249% when pulling<PHONE_NUMBER>784929a707f9cb204072e057753dfb on fix/xref into 5542c32cb50371894b75cc88a54617b947383d5c on main.


Updating from old Library: where is FirebaseData::httpConnected() gone

Hi
I'm updatedating from old library Firebase ESP32 Client
I use the lib for ESP32 in sync mode
Great job, a lot of thinks to do but it works and it seems to be easier to use than before
One Question:
In the old library I have had a function FirebaseData::httpConnected to determine an existing connection.
How is this function gone ?
or how can i determine a lost connection to firebase realtime database using sync mode ?
I'm a little confused how to solve in sync mode because I didn't have any callback functions
I've started from examle Realtimedatabase/sync/Set
Any help will be great and useful

You can check the connection status from your SSL Client.

There is no callback for sync task. It is the traditional embedded programming.

Works perfectly thanks for your help


Implemented Track and Room filter on schedule page

Webapp Generator:- https://damp-shelf-51937.herokuapp.com/

Fixes #1739

@geekyd done :+1:


Meteor methods not being called

I have a Meteor method that  calls a server function. Angular2, typescript. The method is called from the client. The logic is to insert an uploaded text file into a collection, then call a server method to process things. I do an asynchronous insert, and the Meteor.call in the callback. It works up till there, the document exists in the collection, but the method isn't called on the server.
For collections to work the ts files exporting the collection instance needs to be imported by both the server/main.ts, as well as client/app.ts. It seems that Meteor methods are the same. If the Meteor.method definition is in server/... the call doesn't work. But if I move it to collections/methods, import the files into main and app.ts, the calls to functions defined under server/ cause compiler errors.I think it is the client side compile which can't see the server/ functions.
So what is the suggested strategy? Would wrapping the import {} from calls in isServer as well as the calls themselves work? Is there a compile time flag? Or chaining Meteor method calls?
In th parties example Email is called which is in the Meteor namespace hence doesn't need to be injected. I think that is why.
Thanks.

The strategy is to split a method into two parts: common and server ones.
Then define two methods: one simplified for the client and one full for the server;
after that import them accordingly where they belong in.
This is the only way to make it with SystemJS since direct System.import is async anyways, with CommonJS though you can import conditionally using require(...).


The auth code link does not work

You need a new link

fixed in https://github.com/xMistt/rebootpy/commit/226d01fe8b3a66fe05800e0ba21e7dfe43a036ca


UTF-8 special character produce an error in templates

I upgraded to new version of Grav, and I have this error in some of my pages:
iconv(): Detected an illegal character in input string

I use utf-8 smileys in my pages, and a recent change in /system/src/Grav/Common/Helpers/Truncator.php is now throwing this error.

Yes, i'm aware and currently looing for a solution.  I tried the recommended replacement for mb_convert_encoding() with HTML_ENTITIES, as it's deprecated in PHP 8.2 and being removed in PHP 9.  Unfortunately it doesn't work with extended characters such as smiley's and some other UTF-8 chars such as ⌘.
I will get a patched released out ASAP.

please try replacing line 147 of the Truncator.php file with:
$html = mb_encode_numericentity($html, [0x80, 0x10FFFF, 0, ~0], 'UTF-8');


Modified the FilePersister to use League Flysystem

Currently Satisfy has a heavy dependency on the underlying file system (UNIX file system). By using League's Flysystem we can remove that dependency and abstract the file system away.
I embarked on this piece of work because I'm running Satisfy in a containerised environment (Docker) and using a local file system is a problem. With this enhancement, I can now use Amazon's S3 to store the JSON configuration and 'audit log'.

I thought I'd mention there is a breaking change with this. Because Flysystem requires a completely relative file system (so different file systems can be swapped out easily), the '/data' and 'config.json' need to be next to each other.

hey @chrisharrison , nice idea actually, can You wait for upcoming 3.0 release, because there will be a lot BC's


reward model合并出错

python merge_peft_adapter.py --model_type bloom \

--base_model_name_or_path merged-sft --peft_model_path outputs-rm-v1 --output_dir merged-rm/

Namespace(base_model_name_or_path='merged-sft', model_type='bloom', output_dir='merged-rm/', peft_model_path='outputs-rm-v1', resize_emb=False, tokenizer_path=None)
Base model: merged-sft
LoRA model: outputs-rm-v1
Loading LoRA for sequence classification model
Some weights of BloomForSequenceClassification were not initialized from the model checkpoint at merged-sft and are newly initialized: ['score.weight']
You should probably TRAIN this model on a down-stream task to be able to use it for predictions and inference.
Traceback (most recent call last):
File "merge_peft_adapter.py", line 109, in
main()
File "merge_peft_adapter.py", line 92, in main
lora_model = PeftModel.from_pretrained(
File "/root/miniconda3/envs/medicalgpt/lib/python3.8/site-packages/peft/peft_model.py", line 306, in from_pretrained
model.load_adapter(model_id, adapter_name, is_trainable=is_trainable, **kwargs)
File "/root/miniconda3/envs/medicalgpt/lib/python3.8/site-packages/peft/peft_model.py", line 606, in load_adapter
load_result = set_peft_model_state_dict(self, adapters_weights, adapter_name=adapter_name)
File "/root/miniconda3/envs/medicalgpt/lib/python3.8/site-packages/peft/utils/save_and_load.py", line 158, in set_peft_model_state_dict
load_result = model.load_state_dict(peft_model_state_dict, strict=False)
File "/root/miniconda3/envs/medicalgpt/lib/python3.8/site-packages/torch/nn/modules/module.py", line 2152, in load_state_dict
raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
RuntimeError: Error(s) in loading state_dict for PeftModelForSequenceClassification:
size mismatch for base_model.model.score.modules_to_save.default.weight: copying a param with shape torch.Size([1, 1024]) from checkpoint, the shape in current model is torch.Size([2, 1024]).

请问为啥合并reward_model的lora参数会报错呢，这个该怎么解决呀

fixed. https://github.com/shibing624/MedicalGPT/commit/48f86830ded53dd843b0416dfd45b6e942205bc5


Fix split screen toolbar layout

The split screen layout was using the normal toolbar layout instead of the version with title and subtitle.
Fixes #7988 #7987

Unfortunately, 6.903 is still crashing. :-(


[SE-0365] Call to method 'bar' in closure requires explicit use of 'self' to make capture semantics explicit

Description
According to SE-0365 (Allow implicit self for weak self captures, after self is unwrapped) implemented in Swift 5.8:
Additional closures nested inside the `[weak self]` closure must capture self explicitly in order to use implicit self.

And nested closures allowed to capture [self] and use self implicitly (code sample from SE-0365):
// Also allowed:
couldCauseRetainCycle { [weak self] in
  guard let self else { return }
  foo()

  couldCauseRetainCycle { [self] in
    bar()
  }
}

But this code doesn't compile, with the error Call to method 'bar' in closure requires explicit use of 'self' to make capture semantics explicit
Here is the full version:
class Sample {
    func foo() {}
    func bar() {}

    func couldCauseRetainCycle(action: @escaping () -> ()) {
        action()
    }

    func test() {
        couldCauseRetainCycle { [weak self] in
            guard let self else { return }
            foo()

            couldCauseRetainCycle { [self] in
                bar() // <-- Compile error: Call to method 'bar' in closure requires explicit use of 'self' to make capture semantics explicit
            }
        }
    }
}

let sample = Sample()
sample.test()

Expected behavior
Code should compile
Environment

Swift compiler version info 5.8, 5.8.1, 5.9
Xcode version info 14.3, 14.3.1, 15.0 (beta 4)

cc @calda

This was fixed in https://github.com/apple/swift/pull/70575 👍🏻


chore: Prep for version 8.54.0 [do not merge]

This PR prepares 8.54.0 for release
We can close this PR once we submit the release
#nochangelog

closing this one but will keep the branch!


Does the plugin work on background in Android?

Is the plugin able to call JS code when running in background in Android?

This plugin has moved

You want to go here


Unable to run with docker-compose

Attempting to run this locally using the specified docker-compose.yml on the v3.2.0 tag.
The changes I made
Dockerfile: ENV RAILS_ENV development
Dockerfile: RUN su app -c 'bundle install --without test'
docker-compose.yml: Removed env_file: .env-prod
Once the mongo and cypress containers start I run into errors where unicorn and the 4 delayed job works won't run with the following error: runsv unable to start ./run file does not exist. I checked the those run files do in fact exist in the context of those processes.

If you do not modify the docker-compose.yml file at all you will be able to run the application. You will need to create a .env-prod file with the following contents:
DEVISE_SECRET_KEY=<insert rails secret key there>
SECRET_KEY_BASE=<insert rails secret key there>

You can generate a rails secret key using the following command:
hexdump -n 64 -e '/1 "%02x"' -e '/64 "\n"' /dev/urandom
Also I would suggest using the following docker-compose.yml file so you do not have to go through the whole build process:
version: "3"

services:
  cypress:
    image: projectcypress/cypress:release-latest
    environment:
      - MONGO_PORT_27017_TCP_ADDR=mongodb
      - MONGO_PORT_27017_TCP_PORT=27017
    ports:
      - "3000:3000"
    links:
      - mongodb:mongo
    env_file: .env-prod
    restart: unless-stopped
  mongodb:
    image: mongo:3.4.5
    volumes:
      - /data/db
    restart: unless-stopped

Thank you for the response. I created the .env-prod file, but I'm still seeing the following.

Using projectcypress/cypress:release-latest is actually 3.2.0 so that should give you the version you desire.

I see that now. Thanks!

Just wanted to update...the problems I saw only existed with using docker toolbox on windows. Running on any flavor of linux and the docker-compose just works.


(GH-4366) Add missing libraries

Added missing libraries.
Fixes #4366.

@x-jokay : Thanks for your contribution! The author, @juliobbv, has been notified to review your proposed change.

Fixed elsewhere - thanks for your contribution though!

@vtbassmatt Where has this been fixed? Seems to be still the same to me on the master branch and on the published docs.microsoft.com page

@pascalberger apparently I'm not very good at GitHub today... thanks for pinging :)


Update scallop to 3.5.0

Updates org.rogach:scallop from 3.3.2 to 3.5.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.rogach", artifactId = "scallop" } ]

labels: library-update, semver-minor

Codecov Report

Merging #296 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #296   +/-   ##
=======================================
  Coverage   41.83%   41.83%
=======================================
  Files          47       47
  Lines        1702     1702
  Branches       54       54
=======================================
  Hits          712      712
  Misses        990      990

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe361a4...9fbf631. Read the comment docs.


boto3 + elb + describe_tags = NotImplementedError in moto

Hi,
I'm hitting an error when trying to add tests to some existing code that is using boto3 client library with moto: NotImplementedError: The describe_tags action has not been implemented: https://travis-ci.org/zalando/zmon-aws-agent/jobs/95541858
This happens with the ELB client.  The problem appears to be that even though the XML request/response for this API are well defined, the old boto interface doesn't provide a method for this particular call.
Do you see a good way around this sort of issues short of re-implementing moto with boto3 interfaces?

I think that is not boto3 related but add_tags, describe_tags and remove_tags seems to be not yet implemented in moto.
I implemented those for kinesis and it seems there are more places missing the endpoints.

Well, I see some general create/delete/describe_tags methods in ec2 backend, but I'm not sure if these can/should be used in elb.  At least VALID_TAG_RESOURCE_FILTER_TYPES doesn't list elb.


Problem Route + ReservationProblemForm

Generate a problem route.  This route should render a ReservationProblemForm component that has the option to mark the whole reservation as not received.  It should also have:
A mapped list of all cards in the reservation with a dropdown next to them.  The dropdown should have the following options:

Nothing is wrong with this item
Item is missing
Item is in worse condition than described (This will do nothing for now.)

The submit button on this form should probably hit a custom method on the backend to handle this.
This ticket is all about the form.  The apiAction/endpoint/custom method are elsewhere.

https://stackoverflow.com/questions/48084981/how-can-i-get-a-variable-from-the-path-in-react-router


Commits unauthored

Hi @mjohnsullivan 😃
First of all: it is great to see the examples; really glad you made them 🔥
Second of all: the commits apart from the initial one are unlinked on GitHub.
I always feel like that looks somewhat bad on a repo. You could fix it by just adding<EMAIL_ADDRESS>to your emails in the GitHub settings (that is it :D).
Just something I noticed - thanks again for the repo.

Nice catch; let me go fix that ...


Cody codebase doesn't detect the forked repo name

As Cody 0.0.9 version has been released, which has the new features to autodetect codebase from the git clone URL, but it missed these two cases when it should work to detect the URL:

It doesn't detect the codebase name for the forked repo clone.
Many users have multiple Github accounts, so their GitHub hostnames are different per the ssh config.

Expected behaviour:
It should detect codebase settings for these cases too.
Actual behaviour:
It just says the codebase was not detected for the forked repo clone with a different hostname than Github.

Going to close this out. Feel free to reopen.


2.12.0: pilot upload fails with the call to the iTMSTransporter failure

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
pilot upload reports an error in iTMSTransporter:
The call to the iTMSTransporter completed with a non-zero exit status: 1. This indicates a failure.
Command executed
$ DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS='-t DAV' \
FASTLANE_PASSWORD=XXXXXX FASTLANE_ITC_TEAM_ID=YYYY \
/usr/local/bin/fastlane _2.12.0_ pilot upload --ipa /Users/build/Desktop/App.ipa \
--beta_app_description 'Build for internal testing' \
--changelog 'Some changes' \
--distribute_external true \
--skip_waiting_for_build_processing true \
--skip_submission false --username<EMAIL_ADDRESS>\
--groups '"Testers","Designers"' '
--verbose

Complete output when running fastlane, including the stack trace and command used

```
INFO [2019-04-12 16:03:04.34]: Login to iTunes Connect<EMAIL_ADDRESS>Loading session from<EMAIL_ADDRESS>INFO [2019-04-12 16:03:08.27]: Login successful
DEBUG [2019-04-12 16:03:08.33]: App identifier (x)
INFO [2019-04-12 16:03:08.93]: Ready to upload new build to TestFlight (App: x)...
DEBUG [2019-04-12 16:03:08.98]: App Platform (ios)
INFO [2019-04-12 16:03:09.82]: Wrote XML data to '/tmp/417281773.itmsp'
INFO [2019-04-12 16:03:09.98]: Going to upload updated app to iTunes Connect
INFO [2019-04-12 16:03:09.98]: This might take a few minutes. Please don't interrupt the script.
DEBUG [2019-04-12 16:03:10.11]: /Applications/Xcode_10_1.app/Contents/Applications/Application\ Loader.app/Contents/itms/java/bin/java -Djava.ext.dirs=/Applications/Xcode_10_1.app/Contents/Applications/Application\ Loader.app/Contents/itms/java/lib/ext -XX:NewSize=2m -Xms32m -Xmx1024m -Xms1024m -Djava.awt.headless=true -Dsun.net.http.retryPost=false -classpath /Applications/Xcode_10_1.app/Contents/Applications/Application\ Loader.app/Contents/itms/lib/itmstransporter-launcher.jar com.apple.transporter.Application -m upload -u<EMAIL_ADDRESS>-p YourPassword -f /tmp/417281773.itmsp -t DAV -t Signiant -k 100000 2>&1
ERROR [2019-04-12 16:03:10.25]: The call to the iTMSTransporter completed with a non-zero exit status: 1. This indicates a failure.
/usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.12.0/fastlane_core/lib/fastlane_core/ui/interface.rb:145:in `user_error!': [!] Error uploading ipa file, for more information see above (FastlaneCore::Interface::FastlaneError)
	from /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.12.0/fastlane_core/lib/fastlane_core/ui/ui.rb:14:in `method_missing'
	from /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.12.0/pilot/lib/pilot/build_manager.rb:22:in `upload'
	from /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.12.0/pilot/lib/pilot/commands_generator.rb:58:in `block (2 levels) in run'
	from /usr/local/lib/ruby/gems/2.4.0/gems/commander-4.4.6/lib/commander/command.rb:182:in `call'
	from /usr/local/lib/ruby/gems/2.4.0/gems/commander-4.4.6/lib/commander/command.rb:153:in `run'
	from /usr/local/lib/ruby/gems/2.4.0/gems/commander-4.4.6/lib/commander/runner.rb:446:in `run_active_command'
	from /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.12.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:38:in `run!'
	from /usr/local/lib/ruby/gems/2.4.0/gems/commander-4.4.6/lib/commander/delegates.rb:15:in `run!'
	from /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.12.0/pilot/lib/pilot/commands_generator.rb:134:in `run'
	from /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.12.0/pilot/lib/pilot/commands_generator.rb:14:in `start'
	from /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.12.0/fastlane/lib/fastlane/cli_tools_distributor.rb:45:in `take_off'
	from /usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.12.0/bin/fastlane:15:in `'
	from /usr/local/bin/fastlane:22:in `load'
	from /usr/local/bin/fastlane:22:in `'
```

Environment
🚫 fastlane environment 🚫
Stack

Key
Value

OS
10.13.6

Ruby
2.4.1

Bundler?
false

Git
git version 2.17.2 (Apple Git-113)

Installation Source
/usr/local/bin/fastlane

Host
Mac OS X 10.13.6 (17G4015)

Ruby Lib Dir
/usr/local/Cellar/ruby/2.4.1_1/lib

OpenSSL Version
OpenSSL 1.0.2k  26 Jan 2017

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode_10_1.app/Contents/Developer/

Xcode Version
10.1

System Locale

Error

No Locale with UTF8 found 🚫

fastlane files:
No Fastfile found
No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.108.0
🚫 Update available

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.1.0

slack-notifier
2.3.2

atomos
0.1.3

CFPropertyList
2.3.5

claide
1.0.2

colored2
3.1.2

nanaimo
0.2.6

xcodeproj
1.7.0

rouge
2.0.7

xcpretty
0.3.0

terminal-notifier
1.8.0

unicode-display_width
1.3.0

terminal-table
1.8.0

plist
3.3.0

public_suffix
2.0.5

addressable
2.5.1

multipart-post
2.0.0

word_wrap
1.0.0

tty-screen
0.6.4

tty-cursor
0.5.0

tty-spinner
0.8.0

babosa
1.0.2

colored
1.2

highline
1.7.8

commander-fastlane
4.4.6

excon
0.57.1

faraday
0.12.1

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20170404

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

fastimage
2.1.0

gh_inspector
1.1.2

json
2.0.2

mini_magick
4.5.1

multi_json
1.12.1

multi_xml
0.6.0

rubyzip
1.2.2

security
0.1.3

xcpretty-travis-formatter
0.0.4

dotenv
2.2.1

bundler
1.15.2

faraday_middleware
<IP_ADDRESS>

naturally
2.1.0

simctl
1.6.4

declarative
0.0.9

declarative-option
0.1.0

representable
3.0.4

mime-types-data
3.2016.0521

mime-types
3.1

little-plugger
1.1.4

logging
2.2.2

jwt
1.5.6

memoist
0.16.0

os
0.9.6

signet
0.7.3

googleauth
0.5.1

httpclient
2.8.3

google-api-client
0.21.2

emoji_regex
0.1.1

openssl
2.0.3

io-console
0.4.6

retriable
3.0.2

psych
2.2.2

uber
0.1.0

generated on: 2019-04-12

I've been blocked by the 410-Gone-gate, now I've updated fastlane to the latest version (2.12.0?) and now pilot upload fails with the iTMS error.

Fastlane 2.12.0 is from January 2017, so not surprising stuff is broken :)
Please make sure you upgrade to fastlane 2.12_0_.0 and see if you still have this problem.

LOL. I've seen 2.12.0 somewhere recently, and used it. :(

I have the same problem :(

You also installed fastlane 2.12.0 by accident, which can't work @MoElnaggar14?

I updated last version yesterday before I uploading new version of my app so what should I do ? @janpio

Create a new bug issue and fill the template so we have all the necessary information please @MoElnaggar14.


ISPN-13717 Upgrade to Search 6.1.4

https://issues.redhat.com/browse/ISPN-13717

@yrodiere I don't know you want have a look at it

Merged, thanks


Use code snippets for code examples

What this PR does / why we need it:
To ensure that examples are in sync with KUDO, their code is taken directly from the KUDO repository. The KUDO repository is added as a submodule. The markdown-it-vuepress-code-snippet-enhanced plugin is used for this, because it supports viewing only a range of lines of a snippet.
Which issue(s) this PR fixes:

Fixes #31
Special notes for your reviewer:

WIP, need to double-check that I'm getting the submodule stuff right.

Good point to fail the build if a file is removed. Let me check this.

The build doesn't fail if a wrong file name is included. The rendered html shows a "File not found". I'll take a look if this can get checked somehow.

Looks like this is a limitation in Vuepress. Even regular code snippet imports only create a "File not found" message but don't fail the render.

Created upstream issue https://github.com/vuejs/vuepress/issues/1872.

@nfnt should we close this or is it still relevant?

This is still relevant, but I'll have to update this to KUDO 0.8.0. There's an ongoing discussion with @meichstedt about having a workflow that does all this once new versions of KUDO are released. Because we're using the code of a tagged KUDO version, this tag needs to changed for each version bump of KUDO. I'll have to document this.


problem following the instructions on creating workload group because of bug in synapse

I am trying to work through a quickstart of Azure synapse analytics. I created my own data warehouse with a sql server in a sql pool with their adventureworks data. Then I tried to create a workload group as they say to do in the quickstart, but it fails with this error: Statement 'CREATE WORKLOAD GROUP' is not supported in this version of SQL Server. It turns out that the sql server is version 12. They don't let you control the version. That is what they create when you create the sql pool. Not sure if it is related to using the Basic vs. higher level, but that just doesn't seem right. Is there anything I can do about it? I am trying to try out their features to demo it to a client.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 973f4ffd-c49a-fa6f-0102-c6c9dbd354da
Version Independent ID: 4fb4607f-e627-aeca-9a21-a6f367ffff54
Content: Quickstart: Configure workload isolation - T-SQL - Azure Synapse Analytics
Content Source: articles/synapse-analytics/sql-data-warehouse/quickstart-configure-workload-isolation-tsql.md
Service: synapse-analytics
Sub-service: sql-dw
GitHub Login: @ronortloff
Microsoft Alias: rortloff

@hbrown664 Thank you for your query, our team will look into it and get back to you at the earliest.

@hbrown664 are you in the master database?

I'm not sure.  Will have to try it again.  Was I supposed to be?
On Wednesday, June 24, 2020, 08:14:00 AM PDT, Ron Ortloff<EMAIL_ADDRESS>wrote:
@hbrown664 are you in the master database?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

No, you're not supposed to be in master.  But when I tried to reproduce the reported error, I was in master and it repro'd.  When I'm in a user database, I do not get this error.

#please-close

Statement 'CREATE WORKLOAD GROUP' is not supported in this version of SQL Server. I'm running in database not in master db. Please help
`CREATE WORKLOAD GROUP DataLoads
WITH (
MIN_PERCENTAGE_RESOURCE = 100
,CAP_PERCENTAGE_RESOURCE = 100
,REQUEST_MIN_RESOURCE_GRANT_PERCENT = 100
);
CREATE WORKLOAD CLASSIFIER [ELTLogin]
WITH (
WORKLOAD_GROUP = 'DataLoads'
,MEMBERNAME = 'user_load'
);`


AbstractMethodError : Downloader.getRequestSupportedFileDownloaderTypes

After updating from version 2.1.0-RC15 to 2.2.0-RC1 starting a download crashes the app with the error message

07-24 11:47:35.707 4921-4995/com.turndapage.navcasts E/AndroidRuntime: FATAL EXCEPTION: pool-3-thread-1
Process: com.turndapage.navcasts, PID: 4921
java.lang.AbstractMethodError: abstract method "java.util.Set com.tonyodev.fetch2core.Downloader.getRequestSupportedFileDownloaderTypes(com.tonyodev.fetch2core.Downloader$ServerRequest)"
at com.tonyodev.fetch2.downloader.DownloadManagerImpl.getFileDownloader(DownloadManagerImpl.kt:194)
at com.tonyodev.fetch2.downloader.DownloadManagerImpl.getNewFileDownloaderForDownload(DownloadManagerImpl.kt:186)
at com.tonyodev.fetch2.downloader.DownloadManagerImpl$start$$inlined$synchronized$lambda$1.run(DownloadManagerImpl.kt:57)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
at java.lang.Thread.run(Thread.java:764)

@joelphilippage thanks for reporting. looking into this

@joelphilippage are you using a custom downloader?. Do you mind sharing your downloader code if you are using a custom downloader?

@joelphilippage unable to replicate. The getRequestSupportedFileDownloaderTypes(request) method is implemented for all downloaders. mhmmm. Can you specify the device this error occurs on?. The code you shared with me looks right.

Just released fetch 2.2.0-RC2 with a few fixes. Please test and let me know if this help solve your issue.

Seems to be working again. Thanks so much!
I updated and it is working great again. Something could have gone wrong with conflicting dependencies. I was still using
'com.tonyodev.fetch2downloaders:fetch2downloaders:2.2.0-RC1'
But after updating to RC2 it could not longer resolve this dependency. It also said my okhttp3 dependency was out of date after updating to RC2 so I updated that after.
I was testing on the latest Android P developer preview for Wear OS.


Fix project link

The current link points to http://asegnz.gihub.io, it should be http://asegnz.github.io.

Thanks for the warning, I am trying to run a blog with Jekyll Bootstrap.

It's fixed now. Sorry for the inconvenience, but I think you have no one ;)


Make high contrast detection configurable

Add a new option 'window.autoDetectHighContrast', defaults to true. If false, VS Code theme will ignore Windows High Contrast theme.
Fixes #17279

Hi @geirsagberg, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

I have signed the CLA; do I need to do anything to make the bot accept it?

@geirsagberg I think it can take some minutes to be picked up 👍

Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience!

Hi @geirsagberg, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, MSBOT;

LGTM, thanks for the prompt fix.


fix: remove plugin approach, first shot at fixing composable

This PR:

deprecates the plugin approach
fixes the self approach

closing, reverting back to plugin only approach