RemoveExtraSemicolons produces no changes but reports it does - fails build when failOnDryRunResults is set

With FU.java:
package pzrep;
import java.io.*;
public class FU {
    public static void copyFile(File src, File dst) throws IOException {
        try (var fis = new FileInputStream(src); var fos = new FileOutputStream(dst)) {
        }
    }
}

and maven configured with pom.xml:
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>

    <groupId>pzrep</groupId>
    <artifactId>openrewrite-semicolons</artifactId>
    <version>1-SNAPSHOT</version>

    <properties>
        <maven.compiler.release>11</maven.compiler.release>
        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    </properties>

    <build>
        <pluginManagement>
            <plugins>
                <plugin>
                    <artifactId>maven-compiler-plugin</artifactId>
                    <version>3.10.1</version>
                </plugin>

                <plugin>
                    <artifactId>maven-clean-plugin</artifactId>
                    <version>3.2.0</version>
                </plugin>

                <plugin>
                    <artifactId>maven-jar-plugin</artifactId>
                    <version>3.2.2</version>
                </plugin>

                <plugin>
                    <groupId>org.openrewrite.maven</groupId>
                    <artifactId>rewrite-maven-plugin</artifactId>
                    <version>4.33.0</version>
                </plugin>
            </plugins>
        </pluginManagement>

        <plugins>
            <plugin>
                <groupId>org.openrewrite.maven</groupId>
                <artifactId>rewrite-maven-plugin</artifactId>
                <configuration>
                    <activeRecipes>
                        <recipe>org.openrewrite.java.cleanup.RemoveExtraSemicolons</recipe>
                    </activeRecipes>
                </configuration>
            </plugin>
        </plugins>
    </build>
    <profiles>
         <profile>
            <id>rewrite</id>
            <build>
                <plugins>
                    <plugin>
                        <groupId>org.openrewrite.maven</groupId>
                        <artifactId>rewrite-maven-plugin</artifactId>
                        <executions>
                            <execution>
                                <goals>
                                    <goal>dryRunNoFork</goal>
                                </goals>
                            </execution>
                        </executions>
                        <configuration>
                            <failOnDryRunResults>true</failOnDryRunResults>
                        </configuration>
                    </plugin>
                </plugins>
            </build>
        </profile>
    </profiles>
</project>

running with mvn rewrite:run gives
[INFO] --- rewrite-maven-plugin:4.33.0:run (default-cli) @ openrewrite-semicolons ---
[INFO] Using active recipe(s) [org.openrewrite.java.cleanup.RemoveExtraSemicolons]
[INFO] Using active styles(s) []
[INFO] Validating active recipes...
[INFO] Project [openrewrite-semicolons] Resolving Poms...
[INFO] Project [openrewrite-semicolons] Parsing Source Files
[INFO] Running recipe(s)...
Warning:  Changes have been made to src/main/java/pzrep/FU.java by:
Warning:      org.openrewrite.java.cleanup.RemoveExtraSemicolons
Warning:  Please review and commit the results.

but
$ git status && git diff
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean

running with mvn -P rewrite verify gives
[INFO] --- rewrite-maven-plugin:4.33.0:dryRunNoFork (default) @ openrewrite-semicolons ---
[INFO] Using active recipe(s) [org.openrewrite.java.cleanup.RemoveExtraSemicolons]
[INFO] Using active styles(s) []
[INFO] Validating active recipes...
[INFO] Project [openrewrite-semicolons] Resolving Poms...
[INFO] Project [openrewrite-semicolons] Parsing Source Files
[INFO] Running recipe(s)...
Warning:  These recipes would make changes to src/main/java/pzrep/FU.java:
Warning:      org.openrewrite.java.cleanup.RemoveExtraSemicolons
Warning:  Patch file available:
Warning:      /home/runner/work/openrewrite-semicolons/openrewrite-semicolons/target/rewrite/rewrite.patch
Warning:  Run 'mvn rewrite:run' to apply the recipes.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

but
$ hexdump -C target/rewrite/rewrite.patch
00000000  0a                                                |.|
00000001

https://github.com/pzrep/openrewrite-semicolons

Hi @pzygielo, thanks for reporting. This should have been addressed by commit
https://github.com/openrewrite/rewrite/commit/6fce243f1c7dd4207229037104b1c5463a40888f, which is included in the latest release of rewrite 7.32.0

Still observing the same with:

https://github.com/pzrep/openrewrite-semicolons/pull/6

4.36.0
What's Changed
Updated to use rewrite 7.32.0

https://github.com/pzrep/openrewrite-semicolons/actions/runs/3290053410/jobs/5422390764#step:4:41:

Warning:  These recipes would make changes to src/main/java/pzrep/FU.java:
Warning:      org.openrewrite.java.cleanup.RemoveExtraSemicolons
Warning:  Patch file available:
Warning:      /home/runner/work/openrewrite-semicolons/openrewrite-semicolons/target/rewrite/rewrite.patch
Warning:  Run 'mvn rewrite:run' to apply the recipes.

https://github.com/pzrep/openrewrite-semicolons/actions/runs/3290053410/jobs/5422390764#step:4:52:

Error:  Failed to execute goal org.openrewrite.maven:rewrite-maven-plugin:4.36.0:dryRunNoFork (default) on project openrewrite-semicolons: Applying recipes would make changes. See logs for more details. -> [Help 1]

Given that, I can't confirm that 7.32.0 fixed this.

May I ask to have this issue reassessed, please?
Do I do something wrong in my project?
Could this be re-opened (and de-associated from 7.32.0 milestone) or should I rather file new issue?


Generating Guitars Controller Using Rails Generate Controller

The generation of the controller included creating two views: Welcome Page & Guitar Gallery
In addition to the original index, where the mock data is located

Rebased and repushed after #28 was merged to main 👍🏼

This PR won't be worked on
Opened a new PR instead: https://github.com/LiorKGOW/My-Guitar-Store/pull/32


Should the HX711 class try to keep the chip's state?

https://github.com/endail/hx711/blob/42d6305ab0aa8ad03e066a67a64228dc67bef4be/include/HX711.h#L83-L86
Perhaps leave it up to the consuming app to decide?

Gain needs to be maintained to be able to properly set input gain selection when a read takes place.


[Feature request] Change default text generation model from gpt2 to distilgpt2

Currently, the default model is gpt2 for text generation. It isn't good and I could not configure it to work correctly.
I used distilgpt2 and it works great out of the box. I want to create a PR and change it. @xenova What do you think?

The only reason I use gpt2 as the default, is because HF uses it as a default:
https://github.com/huggingface/transformers/blob/5fd4e3c87c685fba2dd9615be62131748a8b5ee3/src/transformers/pipelines/__init__.py#LL280
I think default performance might improve once I add more generation parameters (no repeat n grams, etc.)

I think default performance might improve once I add more generation parameters (no repeat n grams, etc.)

We recently added repetition_penalty and no_repeat_ngram_size generation parameters by the way :)


Binary for Debian release has unexpected name

Description
Not entirely sure if this is intentional or not, but I was surprised to find that installing the Debian release (added in #1537) creates a binary named  cosign-linux-amd64 and not cosign.
$ docker run -it debian

root@3fe738d1ed8b:/# apt-get update && apt-get install wget
...

root@3fe738d1ed8b:/# wget -q https://github.com/sigstore/cosign/releases/download/v1.6.0/cosign_1.6.0_amd64.deb

root@3fe738d1ed8b:/# dpkg -i cosign_1.6.0_amd64.deb
Selecting previously unselected package cosign.
(Reading database ... 7071 files and directories currently installed.)
Preparing to unpack cosign_1.6.0_amd64.deb ...
Unpacking cosign (1.6.0) ...
Setting up cosign (1.6.0) ...

root@3fe738d1ed8b:/# dpkg -L cosign
/usr
/usr/local
/usr/local/bin
/usr/local/bin/cosign-linux-amd64
/usr/local/bin/cosign-linux-pivkey-pkcs11key-amd64

Figured I'd report this in case it was unintentional. Haven't tested any of the other releases from #1537 but this behavior might be present there as well.
(cc @strongjz)

This is probably a quirk in the goreleaser setup. Agree it's a bug.

I will kook into the templating for the name.
Looks like .ConventionalFileName | conventional package file name as provided by nFPM does just that, copies the name from the build. which is cosign-linux-{{ .Arch }} We can probably just use trimsuffix to remove anything after the -.
The note/issue for arm version doesn't seem to apply since we specify goarm 7
https://goreleaser.com/customization/templates/?h=conventionalfilename#fn:9
Please beware: some OSs might have the same names for different ARM versions, for example, for Debian both ARMv6 and ARMv7 are called armhf. Make sure that's not your case otherwise you might end up with colliding names.

https://github.com/golang/go/wiki/GoArm
https://github.com/goreleaser/goreleaser/issues/36

This is still appears to be the case with v1.7.1 deb:
Selecting previously unselected package cosign.
(Reading database ... 212247 files and directories currently installed.)
Preparing to unpack cosign.deb ...
Unpacking cosign (1.7.1) ...
Setting up cosign (1.7.1) ...

~
❯ dpkg -L cosign
/usr
/usr/bin
/usr/bin/cosign-linux-amd64
/usr/bin/cosign-linux-pivkey-pkcs11key-amd64

looks like we changed only the package name but not in binary name inside the package. I think this is not possible to change.
also changing the name broke the release because we now have the same package name for all architectures ( https://github.com/sigstore/cosign/issues/1733 )

Hi, I have encounter this issue.
Maybe it will be nice to add the extra steps in the documentation for the new comers.
I renamed the binary folder but I am not sure if it is the right thing to do. Will it be adding complexity for the future upgrade?


Re: 'DVLA Authentication' - typo

Problem with 'DVLA Authentication' (https://www.api.gov.uk/dvla/dvla-authentication/), emphasis mine:

The DVLA Authentication API provides authentication, change ew password and change API Key services for users of DVLA secure APIs.

Scratch this, it looks like this was an old view of the site - appears to have been a change\new causing a newline


Broken link for tensorboard

The link https://www.tensorflow.org/versions/tensorboard/README.html for README file in tensorboard page is broken.

@danmane  This link still appears broken...

This was fixed in the tensorboard page. The link https://www.tensorflow.org/versions/tensorboard/README.html was actually wrong. The correct is https://www.tensorflow.org/code/tensorflow/tensorboard/README.md

Actually, there was a second Readme link on the page that I missed. I'll fix that.

Fixed by 6b08d99, #3733 and #3734.

(The fix won't propagate to the website until the next rebuild. )


merge old tags into master

Currently, git describe returns
$ git describe
v0.4.0-91-geb34639

because neither 0.5 not 0.6 are merged into master.
Arch Linux packages based on git repos usually rely on git describe to provide a meaningful version number for all commits, and versioneer does the same; it would thus be nice to have the release tags always merged back into master.

The reason the tags aren't merged into master is that they reference release-specific commits.  Each release has odds and ends (mostly a "What's New" entry in the README) that simply don't make sense to have in master.  Therefore, the tags are only in the release branches.  There's always some release specific documentation, and the tag references the exact commit that gets pushed into PyPi.
I don't really see a way around this.  The fact that git describe on master references the 0.4 tag is due to an earlier mistake on my end.  Even the 0.4 tag shouldn't be reachable from master.
Are there Arch packages based on master and not the release branches?

Not currently, but it is pretty trivial (and I wanted to) to create one (e.g. https://aur.archlinux.org/packages/python-pandas-git/), in which case git describe is the standard approach to assign a version number (cf. https://wiki.archlinux.org/index.php/VCS_package_guidelines#Git, e.g. https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=python-pandas-git)
At least a few projects merge the last release tag into master, e.g. matplotlib:
$ git describe
v1.5.1-1905-g6093451

If you don't want to do so, what about deleting the 0.4.0 tag?  I know rewriting the git history is "bad", but it would be helpful here IMO.

Well, I'd rather not re-write history on principle, and regardless, deleting the 0.4 tag wouldn't solve the root issue.  How does putting a dummy devl tag in master sound?

Added the devl tag in https://github.com/joferkington/mpldatacursor/releases/tag/devl   It may not be an ideal solution, but it's certainly better than git describe on master referencing v0.4.  Thanks for catching that!

re: versioning: It would also be nice to replace the version string in setup.py by either 0.6.2-post (or similar) or a versioneer-based solution.  Right now, 0.6-dev ranks as older than the latest version on PyPI (0.6.2), leading pip list --outdated to believe that a install of mpldatacursor from the latest git checkout is outdated.


Dont output type in rules

If you have a rule like "string|required|min:1" then "string" also appears in rules. I think its enough if you can see it in the type, its crystal clear that then string is in the rules

Thanks, will work on it.
Pull reqs are also welcome

Fixing


ayh_task1

Ⅰ. Describe what this PR does
This pr is to add Apache License to the file "pkg/utils/kubeclient/metadata.go".
Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Please fix dco issue


Enable version-convention linter rule for control plane

ARM is adopting the data plane convention for the format of the api-version value -- it must be YYYY-MM-DD with a "-preview" suffix for preview versions, both private and public preview. The ARM docs were recently updated to remove other previously allowed suffixes:
https://msazure.visualstudio.com/DefaultCollection/One/_git/AzureUX-ARMWiki/pullrequest/7188429
Data plane already has a linter rule that checks for this, VersionConvention:
https://github.com/Azure/azure-openapi-validator/blob/main/docs/version-convention.md
This rule should now be enabled for control plane as well as data plane API specs.

This is done by https://github.com/Azure/azure-openapi-validator/blob/main/docs/api-version-pattern.md


Errors categorization - meaningful alerting for deprovisioning functionality

Description
Changes proposed in this pull request:

Categorize the errors returned for deprovisioning steps (and also keep the original error)
Expose the details of the error returned including error component(category), error reason, error detailed/original message from the codes to the deprovisioning metric compass_keb_deprovisioning_result so as to help quickly locate the error/problem and help statistic of problem.
Add provisioner timeout error reason

Related issue(s)

backlog #1933

will update the go.mod and go.sum for github.com/kyma-project/control-plane/components/provisioner after https://github.com/kyma-project/control-plane/pull/1581 is merged.

/test pre-main-control-plane-reconciler-upgrade-kyma2-latest-to-main-gardener
/test pre-main-control-plane-reconciler-e2e
/test pre-main-control-plane-reconciler-e2e-latest-release

/retest

/unhold

/lgtm


Fix pagename problem

The page named like /meetingcannot be created.

Thank you for the feedback!
I added tests and fix some other cases, and merged this change by #105.
Thank you so much.


Automatically install deps in the default target

Signed-off-by: Abhishek Chanda<EMAIL_ADDRESS>

Why do you have two identically named commits in your branch?

@stgraber that was a mistake that I did not notice. Fixed now.

Thanks!


Update exit.md

Confusing explanation, so closing PR. If you still want this change, please reopen and explain further.


Can't get search via ajax to work

Hello, I tried a lot of things before I post issue but I can't get it work. Can't figure out what I do wrong. Can you help me? No nodes are selected after successful server response.
(jsTree v3.2.1)
$('#newtree').jstree({
    "core" : {
        "data"[
            { "id" : "ajson1", "parent" : "#", "text" : "Simple root node" },
	        { "id" : "ajson2", "parent" : "#", "text" : "Root node 2" },
	        { "id" : "ajson3", "parent" : "ajson2", "text" : "Child 1" },
	        { "id" : "ajson4", "parent" : "ajson2", "text" : "Child 2" },
	    ]
    },
    "search": {
        "ajax" : {
	        "url" : "/search"
	    }
    },
    "plugins" : [ "search" ]
});

var to = false;
$('#search_newtree').keyup(function () {
    if(to) { clearTimeout(to); }
    to = setTimeout(function () {
        var v = $('#search_newtree').val();
        if (v.length >= 3) {
      	    $('#newtree').jstree(true).search(v);
        };
    }, 250);
});

I tried this responses from search request: (not working)
["ajson1"] or ["ajson2"] or ["ajson1","ajson2"]

Maybe I misunderstood how this search via ajax works.
I have tree with products. Search function look only to text (name). I need match also there product where context (product text) match searched keywords. I thought I could use there ajax search, find nodes in php on server a then return ids of nodes. But I dont know how make it work..
Now I have this code... It is working but it is not ideal. (I think)
$('#relatedProduct_tree').on('search.jstree', function (e, res) {

		$.get("/admin/api/related_product_search", { str: res.str }, function(match) {

			$('#relatedProduct_tree').jstree(true).deselect_all();
			match.forEach(function(entry) {
				$('#relatedProduct_tree').jstree(true).select_node(entry, true);
			});
		});

	}).jstree({
	    "core" : {
	        "data" : {
	            "url" : "/admin/api/related_product"
	        }
 	   	},
 	   	"checkbox" : {
	      	"three_state" : false,
	      	"whole_node" : false,
	      	"tie_selection" : false,
	      	"cascade"  : "down",
	    },
	    "search": {
	    	"search_leaves_only" : true
        },
    	"plugins" : [ "checkbox", "search" ]
});

var to = false;
$('#search_relatedProduct').keyup(function () {
	  if(to) { clearTimeout(to); }
	  to = setTimeout(function () {
          var v = $('#search_relatedProduct').val();
	  if (v.length >= 3) {
	      	$('#relatedProduct_tree').jstree(true).search(v);
	  };
    }, 500);
});

Jstree search function finds nodes by name, and then I select node where match by context.

Let me clarify - sorry if the docs are lacking.
The AJAX request is only used to load nodes, the search is always performed on the client. That means AJAX search only makes sense if your tree is lazy loaded. The response should be the nodes that need to be opened in order to reveal the matches. BUT if a node is considered a match is always determined on the client.
By default jstree only searches in the node text for the given string (which you can enhance by setting case sensitivity and enabling fuzzy searches), but if you need full control over what is considered a match - please use the search_callback option. That way you have full manual control over which nodes are matches.
Best regards,
Ivan

I will stick with my solution for now but thanks for clarify. Good to know about ajax and search callback option.


can set() and add() be merged?

three private functions could reduce footprint

updateElement(pos, value) - optional remove if value == 0.
removeElement(pos)
newElement(value) - always at the end.

What is the impact on performance?

only needed

removeElement(pos)
newElement(x, y, value)

Size of performance sketch on UNO dropped from 5942 => 5850  (92 bytes)
Performance itself is on par with 0.1.2


Update Composer dependencies (2020-06-17-00-08)

Visual regression test passed!
View the visual regression test report


Suggestion: Contribution Guidelines & Project Organization

Overview
As announced in the comment on PR #1, I'll share some ideas on contributing and general project organization.
I'm basically just thinking out loud, so feel free to question everything I write :smiley:
Project Organization

add unit tests
automatic CI (e.g., with GitHub Actions)
issue templates: create some basic templates for some common categories (bug report, feature request, etc.)
PR template: create a template with some helpful sections (e.g., 'Rationale', 'How has this been tested?', 'Close issue #xyz', a checklist with some mandatory to-dos such as e.g., 'I am sure that this PR is in line with the project goals', 'I have complied with the projects' code style etc.)
labels: makes it easy to group issues and PRs by topic
add a license to make clear who can do what with your software

Contribution Guidelines
Some suggestions on how a CONTRIBUTING.md could look like (would need to be 'fluffed out' for actual use of course:

If you want to contribute to this project, do the following

Make a fork of this repository
Clone it to your local machine withgit clone ...

set origin and upstream, if not set by default
create a feature branch with (for example)git checkout -b your-name/the-feature

make your changes and add relevant unit tests in the tests.rs (or whatever) module
if all tests pass locally, commit and push your changes to your fork
create a PR from your fork to this PR. Make sure that the CI passes.

I think it would be good to have a list of known issues and hot topics, which could/should also go into CONTRIBUTING.md. Some things I can think of:

enable  support for all shells and history files
improve program candidates (e.g., by looking through directories on $PATH instead of using a hard-coded list of names
handle commands consisting of a single word (heck panics for me when my last command is a single word like ls)
better error handling: the issue above happens for me with a hard to interpret panic message:thread 'main' panicked at 'index out of bounds: the len is 1 but the index is 1', src/lib.rs:8:31
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

etc

@jan-krecke Thanks, and sorry for the delay.
Basically, I agree with all of your suggestions. Let me make a PR for this and add you as a reviewer.


mypy: enable --warn-unused-ignores

This kind of conflicts with https://github.com/commaai/openpilot/commit/8aaf00c6a41ac4c9c5e56f8a2dfed8591f153b67 but not sure what that commit fixes
@pd0wm

looks good, can you open the matching laika PR?

The cleanup diff might break Willem's review

I couldn't reproduce on my machine, even after re-initializing pre-commit. I imagine the discrepancy is due to some dependencies being a different version.
@pd0wm does this work on your machine after a pre-commit clean?

Yeah can't reproduce the import issue here either after clean...

@adeebshihadeh getting errors now. It's fixed by removing ~/openpilot/panda_jungle.
batman@workstation-eu-willem:~/openpilot$ pre-commit run mypy --all
mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

tools/replay/can_replay.py:17: error: Cannot assign to a type
tools/replay/can_replay.py:17: error: Incompatible types in assignment (expression has type "None", variable has type "Type[PandaJungle]")
tools/replay/can_replay.py:86: error: Statement is unreachable
Found 3 errors in 1 file (checked 427 source files)

Guess mypy really doesn't support that optional import pattern. Not sure why I didn't see this earlier. Added the bool back in bfeaf35d6dd2c29c65b80a70ccafd9948056731a.


register and code minification

Ran into this with esbuild minified custom element. Names of classes exported from per-element files are not preserved after esbuild minification. While the problem may be overly eager minification, it'd be nice of custom element name could be optionally specified. Something like @controller('my-component').

Thanks for the issue @donpark
You'll need to either exclude all class names from being minified in your build, or alternatively a subset with a RegExp. For GitHub we allow any classname ending in Element to go through our build unminified, meaning Catalyst is able to pick them up properly.
During the API design we considered passing the name to @controller; e.g. @controller('FooBarElement') class FooBarElement... but we dislike the ergonomics of having to express a name twice. Ultimately we decided to simply disallow minification of classnames in our builds - perhaps it is worth documenting this in the guide.

Thanks for the issue @donpark
You'll need to either exclude all class names from being minified in your build, or alternatively a subset with a RegExp. For GitHub we allow any classname ending in Element to go through our build unminified, meaning Catalyst is able to pick them up properly.
During the API design we considered passing the name to @controller; e.g. @controller('FooBarElement') class FooBarElement... but we dislike the ergonomics of having to express a name twice. Ultimately we decided to simply disallow minification of classnames in our builds - perhaps it is worth documenting this in the guide.

Hi @keithamus
What about set the name in the controller as in @controller('FooBarElement') just optionally keeping the current behaviour?.
IMHO the mechanism of removing "Element" and take the rest as the custom element name is very elegant, but I like the idea of being able to change it that @donpark proposes not only to fix the minification (btw I also had problems with parcel-bundler in that way) also as a feature.
I started a POC to add this feature and keep the already working syntax, so both @controller class FooBarElement and @controller('FooBarElement') class RandomName work.
https://github.com/Scipion/catalyst/commit/0285abd93fa2c1420f6c0171a2d39ee72ae07239
Does it matches the original API design?

Hi @keithamus
What about set the name in the controller as in @controller('FooBarElement') just optionally keeping the current behaviour?.
IMHO the mechanism of removing "Element" and take the rest as the custom element name is very elegant, but I like the idea of being able to change it that @donpark proposes not only to fix the minification (btw I also had problems with parcel-bundler in that way) also as a feature.
I started a POC to add this feature and keep the already working syntax, so both @controller class FooBarElement and @controller('FooBarElement') class RandomName work.
https://github.com/Scipion/catalyst/commit/0285abd93fa2c1420f6c0171a2d39ee72ae07239
Does it matches the original API design?

What about set the name in the controller as in @controller('FooBarElement') just optionally keeping the current behaviour?.

This commit in my fork also does that, optional explicit naming. https://github.com/donpark/catalyst/commit/110426b62ed0541fb354fe5bf82a601764b4a916
I did run into an issue with @controller implementation calling register() which handles the actual class name derived naming. That conflicts with the way TypeScript decorator factory works so I had to break out register() logic to _register() function so it can be called from controller().
Designwise, current Catalyst convention of allowing its decorators to also be directly callable limits adding optional arguments to the decorators in the future.

What about set the name in the controller as in @controller('FooBarElement') just optionally keeping the current behaviour?.

This commit in my fork also does that, optional explicit naming. https://github.com/donpark/catalyst/commit/110426b62ed0541fb354fe5bf82a601764b4a916
I did run into an issue with @controller implementation calling register() which handles the actual class name derived naming. That conflicts with the way TypeScript decorator factory works so I had to break out register() logic to _register() function so it can be called from controller().
Designwise, current Catalyst convention of allowing its decorators to also be directly callable limits adding optional arguments to the decorators in the future.

Thanks for this active discussion, it's all very good to see!

Designwise, current Catalyst convention of allowing its decorators to also be directly callable is unfortunate...

This is an intentional design choice, as we want to keep them ergonomically simple. Adding arguments adds utility but it also adds combinatorial complexity; it comes at a cost. Every time we've looked at adding arguments we've concluded it is a complexity not worth the cost, in our opinion. We sort of allude to this in the Guide (although we could do better at calling it out explicitly): https://github.github.io/catalyst/guide/decorators/#function-calling-decorators.
On the surface, keeping class names unminified might seem like a bad idea but we've really come to appreciate the simplicity. It aids in debugging (error stacks reflect the unminified class name), and it doesn't have a detrimental effect on the output. Here's a demonstration using Terser:
// Minified output using `@controller('FooBarElement') and an anonymous class`. gzipped: 94 bytes
let e=class extends HTMLElement{};e=__decorate([controller("FooBarElement")],e)

// Minified  output using `@controller; class FooBarElement` with `--keep-classnames`. gzipped: 90 bytes.
let e=class FooBarElement extends HTMLElement{};e=__decorate([controller],e);

Clearly this example is very contrived but it demonstrates the point that there's little to gain from compressing classnames here if you're already expressing them in a string.
Again, Terser allows you to specify to keep either all class names, or just the ones matching a certain pattern. One problem I can see is that esbuild only has a --keep-names flag which keeps function names as well as classes. Perhaps this is something you could file upstream with them?
--
Right now, I think I'm going to close this issue as a design choice we're aware of, but are happy with the current trade-offs. Shipping unminified class names works well for us, and we believe it will work well for others with the correct tooling. The solutions to work around minifying class names adds extra ergonomic burden to developers which is remediated with tooling, and to us this isn't a worthwhile trade-off.
Although I'm closing this issue, I'm happy to keep discussing further and we can always re-open later if we find a strategy which works better than the one we have now.

Thanks for this active discussion, it's all very good to see!

Designwise, current Catalyst convention of allowing its decorators to also be directly callable is unfortunate...

This is an intentional design choice, as we want to keep them ergonomically simple. Adding arguments adds utility but it also adds combinatorial complexity; it comes at a cost. Every time we've looked at adding arguments we've concluded it is a complexity not worth the cost, in our opinion. We sort of allude to this in the Guide (although we could do better at calling it out explicitly): https://github.github.io/catalyst/guide/decorators/#function-calling-decorators.
On the surface, keeping class names unminified might seem like a bad idea but we've really come to appreciate the simplicity. It aids in debugging (error stacks reflect the unminified class name), and it doesn't have a detrimental effect on the output. Here's a demonstration using Terser:
// Minified output using `@controller('FooBarElement') and an anonymous class`. gzipped: 94 bytes
let e=class extends HTMLElement{};e=__decorate([controller("FooBarElement")],e)

// Minified  output using `@controller; class FooBarElement` with `--keep-classnames`. gzipped: 90 bytes.
let e=class FooBarElement extends HTMLElement{};e=__decorate([controller],e);

Clearly this example is very contrived but it demonstrates the point that there's little to gain from compressing classnames here if you're already expressing them in a string.
Again, Terser allows you to specify to keep either all class names, or just the ones matching a certain pattern. One problem I can see is that esbuild only has a --keep-names flag which keeps function names as well as classes. Perhaps this is something you could file upstream with them?
--
Right now, I think I'm going to close this issue as a design choice we're aware of, but are happy with the current trade-offs. Shipping unminified class names works well for us, and we believe it will work well for others with the correct tooling. The solutions to work around minifying class names adds extra ergonomic burden to developers which is remediated with tooling, and to us this isn't a worthwhile trade-off.
Although I'm closing this issue, I'm happy to keep discussing further and we can always re-open later if we find a strategy which works better than the one we have now.


More specific imports for StealJS

This adds StealJS compatibility by changing the Node convention file location shorthand to the full form.

:shipit:


Snaphud & Cgaz not accurate on slopes

Due to gravity influence and velocity clipping on plane, cgaz and snaphud do not display correct values on slopes.

Also applies to strafe quality calculations as they rely on cgaz/snap state to determine optimal accel direction.


[WFLY-12162] Upgrading Naming Client to 1.0.11.Final.

https://issues.jboss.org/browse/WFLY-12162
Incorporates:

[WFNC-55] Naming Client must always set thread context class loader

@ropalka @jamezp I think we should defer this to 18 as a change in TCCL behavior at this very late date for 17 is risky and AFAICT this is addressing an issue that we've already worked around.  If this thinking is wrong please ping me in Zulip ASAP.  For example if it doesn't get in the Tuesday TCK run my enthusiasm for it would drop a lot.

I agree @bstansberry @jamezp this can be deferred to 18. It is just a proper fix for effective workaround.


factorial calculator for large numbers. whose  value could not be stored in  any form of integer

Detailed description
for example if we want to  calculate the factorial of 5 we can simply calculate it as 120 and 120 can be stored in integer data type in cpp but  for 100 the  output cannot be stored even in long long  int.
Input: 100
Output:<PHONE_NUMBER>39441526816992388562667004-
907159682643816214685929638952175999-
932299156089414639761565182862536979-
208272237582511852109168640000000000-
00000000000000
Context
when we write a program for calculating factorial  by our brute force approach   which is  okay  for small numbers  but for large numbers it takes lot of time to give output   on the screen and sometimes  the becomes the output number is  out of  range of the  datatypes available in programming  language.
Possible implementation
Possible implementation:
1 Create an array res[] of MAX size where MAX is a number of maximum digits in output.
2 Initialize value stored in res[] as 1 and initialize res_size (size of ‘res[]’) as 1.
3 Multiply x with res[] and update res[] and res_size to store the multiplication result for all the numbers from x = 2 to n. To multiply a number x with the number stored in res[], one by one multiply x with every digit of res[].
4 To implement multiply function perform the following steps:
4.1  Initialize carry as 0.
4.2 Do following for i = 0 to res_size – 1
4.3 Find value of res[i] * x + carry. Let this value be prod.
4.5 Update res[i] by storing the last digit of prod in it.
4.6 Update carry by storing the remaining digits in carry.
5 Put all digits of carry in res[] and increase res_size by the number of digits in carry.
Additional information
No response

please assign this to me

please assign this to me

Hello Sir ,
I would like to do this task could you assign me this task.

Hello, Can you please assign this issue to me?
Thanks in advance :)

Hello, Sir can you assign this task to me

Could you assign this task to me?


Move dataplane packages - batch3

The path update is in reference to the github PR Azure/azure-sdk-for-js#2240
Please review Azure/azure-sdk-for-js#2240 as well
Moving following dataplane packages from packages@Azure and putting them under an sdk directory:

Please tag the required reviewers:
@salameer @daschult @kpajdzik @Azure/azure-sdk-eng

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-js

Automation for azure-sdk-for-java

Can one of the admins verify this patch?


Issue/549

Fixes #549
See also #550
This finished the work of @hvesalai by squashing his commits and retargeting against the release-0.12.4 branch.

LGTM! Soorry I didn't have time to make these changes my self (was frantically packing to go skitouring)

I'm going to merge this later today barring objections.
@hvesalai: no worries! ski touring sounds a lot more fun that rebasing commits for a random open source project! Have fun and thanks again for the PR.


MK-test integration for service registry command

MK-test integration for service registry command that will test creation/listing and deletion of services registries.

CC @b1zzu

@b1zzu What is your stance about this? Do you have any overlaping targets to support service registry backend and use CLI to create registry + artifacts?

@wtrocki yes we have a Jira task for it (not posting it here because is private), I can link this issue to the Jira task and we can close it together with the Jira task once is completed


Explicit relation between ImagePolicy and ImageUpdateAutomation

Scenario:
Application consisting of a combination in-house developed software (think: PHP application) and third-party software (think: Elasticsearch, Redis, etc).
For the in-house developed stuff, we want IUA to actively deploy the latest versions based on ImagePolicies.
For third-party stuff, we want IUA to create branches/PRs based on ImagePolicies.
Current workarounds:

Hard separation between in-house and third-party stuff directory-wise, and have specific ImageUpdateAutomation resources pointing at those respective directories.
Separate them by using different namespaces for both instead.

Suggested solution:
Think: Ingress classes
In each ImagePolicy you explicitly (with perhaps some optional default) configure which ImageUpdateAutomation is supposed to "process" this ImagePolicy.

In general I agree that it's sometimes hard to reason about the relationship between ImageUpdateAutomation and ImagePolicy resources and how they interact with each other. I myself ran into this with two ImageUpdateAutomations living in a namespace and racing against each other, leading to one of them always failing to push changes.
Here's a link to a discussion with some background on the decisions behind the current design and Michael asked exactly the question you're posing here: "is it useful to have two automations refer to the same (part) repo?".


Add max step size argument to odeint

Closes #10922
Adds argument hmax to odeint allowing the user to control the maximum step size that the solver takes. Implemented by calling jnp.clip(x, a_min=0., a_max=hmax) at each point where a step size x is computed. Argument defaults to jnp.inf. This argument is set as static and nondiff argnums in appropriate places.
Also adds a test case that fails if hmax=jnp.inf (i.e. under existing behaviour), but passes if hmax=1.. The test case is explained in #10922 : it is set up so that the rhs is 0. for long enough that the step size grows so large that it "steps over" a period of time in which the rhs != 0. Setting hmax = 1. (chosen based on the details of the ODE) prevents the solver step size from growing arbitrarily large, allowing the user to avoid this problematic behaviour.
The argument name choice hmax is taken from the corresponding argument of odeint in scipy. If the reviewer thinks it makes sense, we could also implement h0 (initial step size) and hmin (forced minimum step size) in this PR, which would be very similar changes.

@mattjj sorry to bug - I'm sure you all are busy, but just wanted to check in on someone's thoughts with this PR. It's pretty minor, but whether or not odeint has the ability to bound step size will fully determine it's usable my applications. Thanks!


Adding --deep option to getReplicaInfoForBlocks

Fixes #10901
Status
ready
Description
Added deep option to  Rucio.getReplicaInfoForBlocks(). The value of the flag can be changed in RucioInjector config.
Also added slicing to RucioInjectorPooler.deleteBlocks() to avoid  problems in case of a high number of deletable datasets.
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
NO
External dependencies / deployment changes
NO

test this please

Thanks for the changes  @germanfgv. I noticed few errors which are also notified in the Pylint tests.  Please take a look at the latest comment I made inline and also of the few of errors mentioned in the Pylint test details. More particularly the ones in Bold need to be addressed. At least the ones coming from your  change.
There are also two more unresolved conversations above(one for simplifying the logic with @amaltaro's suggestion the other from me about accounting for failed deletions). Those I'd like to keep unresolved, so we may refer to them later and keep an eye or address in a separate issue  if needed.


Wireless Adapter Proxy Issues

Currently I have a simple web proxy opened up inside a console application (very similar to the example on the Code page). I've pointed my mobile device's proxy to my desktop's wireless adapter and have the requests going out through my desktop. The proxy is getting the requests from the device successfully, but I'm getting no responses.
While debugging some of the requests, I'm noticing that the e.WebSession.Request.Url is duplicated (instead of 'www.google.com', i'll have 'www.google.comwww.google.com'. The e.WebSession.Request.OriginalURL is correctly displaying the URL as 'http://www.google.com'. I've also tried setting the correct URL from the OriginalURL property.
Not sure if this is a wireless adapter issue/bug or if someone has seen this in the past and can point me in the correct direction.

Closing ticket. Found the same problem in #190.


Speed up case insensitive string comparisons

Oh boy, never leave anything unbenchmarked.

We thought they were good enough because they allowed specification of
locale, so we could just pass the static classic locale, and so they
would be inexpensive because they didn't have to query the current
locale.  But this is wrong, they were still ghastly.
So here I rewrite Strutil::iequals, iless, starts_with, istarts_with,
ends_with, iends_with in terms of a new (internal) Strutil::strcasecmp
and strncasecmp (which underneath handle differences in platform, and
use the locale-independent versions). The net result is that most of
those case-independent comparisons speed up by a factor of
50-100x. Wow.
I still need to tackle the family of 'ifind' related functions. They
are a bit trickier. But I'll leave them for another time, because I
need to roll this present fix out right away to fix a real production
bottleneck.
(Worth noting: iequals is instrumental when you're searching a
ParamValueList for a particular name, which is what happens when you
look up attributes from an ImageSpec, which is what happens when you
call get_texture_info(), which is what underlies OSL gettextureinfo()
calls in the cases that they cannot be constant-folded during runtime
optimization. So this came to my attention when analyzing a slow scene
whose shaders had a pathological explosion of gettextureinfo calls that
couldn't be optimized away.)

Now this is very interesting :) I have a need for case-insensitive algorithms on low-ASCII strings myself!! (no locale, ewww)

Oh....eh... I looked through the changes. I was hoping for something really cool like some algorithms that worked 4 or 8 bytes at a time or some kind of interesting mathematical relation that greatly simplified the emitted assembly for case-insensitive operations.
Maybe these could be of some help to you:
https://lemire.me/blog/2020/04/30/for-case-insensitive-string-comparisons-avoid-char-by-char-functions/
https://github.com/lemire/Code-used-on-Daniel-Lemire-s-blog/blob/master/2020/04/30/tolower.cpp

Hi, @vinniefalco
Because the implementation in this PR uses glibc's strncasecmp_l underneath (or _strnicmp_l for Windows, they always have to be a little bit different), I assume that their underlying implementation already is fairly smart with not operating one char at a time.
To the best of my knowledge, not that this PR is merged, string compares are no longer a bottleneck in OIIO. If anybody comes up with examples that show it's still a problem, I'm happy to look into further refinements.


DC-627: Fix error message when error is an object

Response objects are logged as [Error: Response] instead of the contents of the error response when the response is an object.
Example: https://circleci.com/gh/DataBiosphere/terra-ui/55527

run-workflow is currently failing on all PRs, but the branch passes tests locally.

This appears to be less useful than the previous Response. Now Responses are logged as {}.
JSON.stringify(new Response(''))
'{}'

This appears to be less useful than the previous Response. Now Responses are logged as {}.
JSON.stringify(new Response(''))
'{}'

I'm not sure I agree. Logging just [Error: Response] was super confusing to me and tripped me up multiple times. Perhaps the solution is to log both, though.

At least "Error: Response" told me that a network request failed and from there I could go and look at status codes in the test logs. Now I get something like the following:
page.http GET 403 https://storage.googleapis.com/storage/v1/b/fc-f6093620-4a02-4d8a-943a-c1a792c4ae27?fields=location%2ClocationType
page.console Failed to load resource: the server responded with a status of 403 ()
page.pageerror {}
...

Tests Summary
----------------------------------------------
Test: export-workspace-dataset-to-new-workspace
Status: failed
Failure messages:
Failure details: [
  {}
]

That's from the export-workspace-dataset-to-new-workspace logs from https://app.circleci.com/pipelines/github/DataBiosphere/terra-ui/14088/workflows/736a1950-120e-4581-8677-d6ad4d0e2ab6/jobs/56587/tests

My proposal is to log both. Would that work for you?

I think that would be an improvement, but maybe it's worth handling Response objects differently from other objects?
Something like this?
if (obj instanceof Response) {
  ...
} else if (typeof obj === 'object') {
  console.log(JSON.stringify(obj))
} else {
  console.log(obj)
}


Resolves #86

Hi,
If there is no property in the model, not showing in swagger
#86

thanks buddy!
much appreciated 🙏🙏🙏


"unexpected token ." on upload attempt

i'm very new to this so i'm probably doing something stupid
var Client = require('instagram-private-api').V1;
var device = new Client.Device('succulenthell');
var storage = new Client.CookieFileStorage(__dirname + '/cookies/succulenthell.json');

Client.Session.create(device, storage, 'user', 'pass')
var pathOrStream = 'C:/Users/Hassan/Desktop/test/image.jpg';
.then(function(session){
  return [Client.Upload.photo(session, pathOrStream), session]
})
.spread(function(upload, session) {
  return Client.Media.configurePhoto(session, upload.params.uploadId, "you can provide caption or go let it go")
})
.then(function(medium) {
  console.log(medium) // -> return Instance of Client.Media
})

by stroke of luck i figured it out.
var pathOrStream = 'C:/Users/Hassan/Desktop/test/image.jpg';

Client.Session.create(device, storage, 'user', 'pass')
.then(function(session){
  return [Client.Upload.photo(session, pathOrStream), session]
})
.spread(function(upload, session) {
  return Client.Media.configurePhoto(session, upload.params.uploadId, "you can provide caption or go let it go")
})
.then(function(medium) {
  console.log(medium) // -> return Instance of Client.Media
})

var pathOrStream has to be ABOVE the  Client.Session.create

@glazkoman does that mean we would need to fork the repo and update the endpoints ourselves for this to work?

@HassanMehdi17  @glazkoman  is still working but is tricky you need to execute function twice to work  I'm new to this I may not be good or optimized but its work
`function share(){

 shared.login_instagram().then(shared.create_session());
 Client.Upload.photo(shared.global.session,img_path)
 .then(function(upload) {

   //console.log(upload.params.uploadId);
   return Client.Media.configurePhoto(shared.global.session, upload.params.uploadId, 'some testing');
 })
 .then(function(medium) {
   // we configure medium, it is now visible with caption
   console.log(medium.params)
 })
}
function share_image(){
 var counter =0 ;
 var share_interval = setInterval(function(){
   share();
   counter++;
   if(counter==2){
    clearInterval(share_interval);
  }
 },10000)

}`


Possible bug: DatabaseTarget's RunInstallCommands disregards SqlParameters

Hey,
I tried running the following, simple code to be executed as an install command:
(...)
var config = new LoggingConfiguration();
var installDbCommand = new DatabaseCommandInfo
{
    Text = "INSERT INTO Application(Name) SELECT @app WHERE NOT EXISTS(SELECT 1 FROM Application WHERE Name = @app);"
};

var sqliteTarget = new DatabaseTarget("sqlite")
{
    DBProvider = "Microsoft.Data.Sqlite.SqliteConnection, Microsoft.Data.Sqlite, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60",
    ConnectionString = $"Data Source={sqlitePath}"
};
sqliteTarget.InstallDdlCommands.Add(installDbCommand);
installDbCommand.Parameters.Add(new DatabaseParameterInfo("@app", appName));

(...) Omitting actual working logging command for brevity (...)

config.AddRuleForAllLevels(sqliteTarget);
LogManager.Configuration = loggingConfig;
LogManager.Configuration.Install(new InstallationContext());

Internally, the Microsoft.Data.Sqlite Assembly would always throw an exception that the "@app" parameter needed to be definied.
I checked the source code for DatabaseTarget.cs and the the WriteEventToDatabase Method loops through all the available parameters, the RunInstallCommands method, however, does not. That would explain the the exception.
Since the DatabaseCommandInfo class has a Parameters Collection I assume I've encountered a bug.

Hi! Thanks for reporting.
Would it be possible to send a PR? (with unit test?)

Hey, no problem.
I'll get a PR and unit tests ready soon.


Completely broken pages

I have recently installed xiMatrix and i can't use it properly. The only active addon i have is xiMatrix and whenever it's active the entire page becomes broken. I tried changing some of the settings but it did not work.

This is what it looks like with xiMatrix disabled.

Right now i am on Firefox 103 with windows 10.

did you test with a fresh profile?

It's the same. Default configuration on Firefox, i didn't change any settings on about:config nor in the GUI settings.

This is a feature, not a bug. In fact, this is basically the only feature of this extension. To quote from the README (also on the mozilla addon page):

By default, all web requests as well as inline code are blocked. You can then define rules to allow only those requests you want. Definitely for advanced users.

I tested the pages from your examples and they work fine for me if I allow the relevant requests. Am I assuming correctly that you didn't do this?
So I think this is more an issue of setting the correct expectations. What exactly made you think that this extension would not break pages? What did you expect it would do instead?

I am fully aware that this extension was going to make the pages break. But i don't think it should be the default. But that's okay, I'll just close this issue.


Composite primary key

Made a composite primary key composed of both the digest and naming_convention.
In this way, we can add multiple seqcol objects that hold the same information, thus the same digest L0, but having different naming conventions.

I had a little problem while rebasing this branch, this is why the commit history looks a little bit ugly.
Sorry.

Sorry Tim, my bad.
I just fixed it.


Updating url with hash

Context
What's your version of nuqs?
1.16.1

Next.js information (obtained by running next info):
Relevant Packages:
  next: 14.1.0
  react: ^18
  react-dom: ^18
  typescript: ^5
Next.js Config:
  output: N/A

Are you using:

✅ The app router
❌ The pages router
❌ The basePath option in your Next.js config
❌ The experimental windowHistorySupport flag in your Next.js config

Description
Updating the query param with the setter returned from useQueryState causes an error if there's a hash fragment in the url.
Reproduction
codesandbox

Click on the link 'Go section' which jumps to a section of content, adding a hash to the url
Type in the input field some query text
See error in console: TypeError: Cannot read properties of null (reading '__PRIVATE_NEXTJS_INTERNALS_TREE')

I was initially following the way as described in the NextJS docs Using the native History API, but I was getting this error when calling window.history.pushState.
const searchParams = useSearchParams();
const pathname = usePathname();

const searchChange = (term: string) => {
    const params = new URLSearchParams(searchParams)
    if (term) {
      params.set('query', term);
    } else {
      params.delete('query');
    }
    window.history.pushState(null, "", `${pathname}?${params.toString()}`);
  }

<input onChange={(e) => searchChange(e.target.value) />

This led me to trying this package, but I'm getting the same error.

I don't know how to share the codesandbox. I am copying the link I get from "copy link" in the share dialog, but you're right, it's just the empty template when I then go to the link.
It's simply the basic nextjs template with nuqs installed and page.tsx looks like this:
import SearchBar from "./_components/searchbar";

export default function Home() {
  return (

      <SearchBar />

        Go to section

        Lorem ipsum dolor sit amet consectetur adipisicing elit.

  );
}

and _components/searchbar looks like this:
"use client";

import { useQueryState } from "nuqs";

const SearchBar = () => {
  const [query, setQuery] = useQueryState("query");
  return (
    <input
      className="py-2 px-4"
      placeholder="Search.."
      type="text"
      onChange={(e) => setQuery(e.target.value)}
      defaultValue={query ?? ""}
    />
  );
};

export default SearchBar;

I can reproduce the issue, with the following notes:

replacing the  with a <Link> solves the issue. Not a valid solution, but a step towards understanding the problem better.
doing a page reload between applying the hash and applying search params also solved the problem

Coupled with the fact that you encountered a similar issue with updating search params via the history method (which nuqs does under the hood), it looks like the issue is in Next.js' router, which is not aware of the hash application via an anchor tag, and fails subsequent shallow history updates.
I'll dive deeper into this today, and see if I can open a PR to fix this in Next.js.

Thank you for looking into this so fast. I believe using <Link> instead of  is possible for my use case, but it would be nice to see this fixed. Good luck on the PR.

A "fix" for this was started in https://github.com/vercel/next.js/pull/61822, but there are still some major issues with it.
As of<EMAIL_ADDRESS>search params and hash are dropped out of the URL, and even with an easy fix, it still results in a full-page reload when updating the search params, which is terrible UX for nuqs.

Another PR by the Next.js team should fix this properly: https://github.com/vercel/next.js/pull/62098
I'll wait until it gets merged into a canary release to run the test suite in #500. Unfortunately that means this bug is here to stay in<EMAIL_ADDRESS>(and all previous versions with the WHS flag), so it looks like nuqs@^2 will have a hard peer-requirement on<EMAIL_ADDRESS>(or whatever they decide to call the next GA).

Fixed in<EMAIL_ADDRESS>so the next GA should be good.

Fixed in<EMAIL_ADDRESS>so the next GA should be good.

I've tested this nextjs release and it has fixed this issue for me.

Next.js 14.1.1 was released, but with only a very partial subset of PRs since the previous version, and which doesn't include this fix..
Going to have to wait for the next one I'm afraid (I guess I know why they called it Next now).

Fixed in Next.js 14.1.2.


Autolock

Ideally, FreeOTP+ shouldn't stay unlocked for long: I can forget I unlocked it, then hand the phone to someone who will be able to see my list of tokens and generate codes. Here's some ideas that FreeOTP+ could borrow from KeePassDX (a password manager):

"app timeout" -- locks the database after a configurable duration
"screen lock" -- locks the database when the screen is off
pressing Back while in the main menu locks the database. KeePassDX can have multiple DBs, but for FreeOTP+, it makes sense to quit the app as well.

Sounds like a good suggestion to lock when the screen is locked.

Commit https://github.com/helloworld1/FreeOTPPlus/commit/1b320fc7b6997edfad2912fe71fd5baef51d185b was checked in to have 2 minutes timeout when the app is in background.

Awesome, thank you very much!


Remove unused strings

Issue
#266
Overview (Required)

Remove unused string (Fix lint errors ExtraTranslation)

Links
I sent PR from the same branch name last year!
https://github.com/konifar/droidkaigi2016/pull/125
Screenshot

Before
After

Good catch! Thanks! 👍


How do I evaluate an upload before it is sent?

I've configured the app, so that uploads are triggered programmatically when a button is clicked.
What I'd like to do, before that button click, is run a few other checks on the files that have been selected, before the user uploads them.   I'm not quite sure about the most effective way to do that.
Essentially, I'd like to check the size of the files, and prevent the upload if the size is (too small) or throw an alert if the size is (too big).  Is this possible?
Thanks so much Sebastian, (and anyone else who might have the answer)
-Phil

The UI version of the plugin does such checks, maybe you can find some inspiration in the UI version source code:
https://github.com/blueimp/jQuery-File-Upload/blob/master/jquery.fileupload-ui.js#L365

I seem to have discovered where my understanding of jQuery turns into jEllo.  I've tweaked and modified that section but I really honestly only understand about 1% of what's going on in there.
I'm trying to basically set it so that when the user clicks (Upload), it calculates the size of all the files, and if they are above a certain number, it flashes a message.
I've got this configured so that the uploads are triggered by a button click, of course, but that's as far as I can get.

I'm having a hard time figuring out how to trigger a file upload programmatically, so I'm a step behind you. I'd like to trigger an upload after the 'change' event fires on the file input element, but can't quite figure out which callback I need to use, or how to call it.
I've read the source of the plugin and the UI code, but no dice -- mind throwing me a bone here?

Triggering a file upload after file input change events is the most basic functionality built-in into the plugin.
Did you follow the basic plugin guide?
https://github.com/blueimp/jQuery-File-Upload/wiki/Basic-plugin

Thanks for following up -- turns out I was running into a problem with a different handler that I had implemented about the same time; all is well now. :)


autoSize not working completely?

I'm having an issue with the autoSize flag.  Each grid item seems to just take the h specified blindly regardless if this flag is set to true.  The weird thing is that the resize handle is in the correct position as if it knows how tall the content is.

Both of the grid items have an h of 1.
    getDefaultProps: function() {
        return {
            autoSize: true,
            isResizable: true,
            useCSSTransforms: true,
            draggableHandle: "div.draggable",
            cols: 12,
            rowHeight: 50
        };
    },
    render: function() {
       <ReactGridLayout className="layout" {...this.props}>

TEST

TESTTEST

TESTTEST

TESTTEST

TESTTEST

TEST

TESTTEST

TESTTEST

TESTTEST

TESTTEST

TESTTEST

TESTTEST

TESTTEST

TESTTEST

       </ReactGridLayout>
    }

Am I doing something incorrectly?

Hi @duranb ,
The autoSize flag is for the entire Grid Layout container, not the individual grid items.
At this time I do not support autosizing of grid items as it requires reading from the DOM to figure out an item's dimensions, and doesn't give with the integral grid system as it stands.
In order for autosizing to work, React-Grid-Layout would need to be reconfigured to use a pixel grid instead of a unit grid. Row/column sizes could still be defined in integer units (say, 1 column is 60px wide) but the underlying grid would have to be represented in pixels. Then, any grid item with automatic width or height would have to read from the DOM to understand the size of its content and adjust the layout proportionally.
IMO, if you need this kind of functionality, it may be best to use one of the many jQuery grid layouts. This project is intended to be pure, without any direct DOM manipulation, and renderable server-side without checksum errors (although I believe there is a pending issue on that). Such a change would really be a major departure from what this project is about.

Fair enough.  How should I go about fixing the resize handle? Does the content have to be positioned absolutely?

If the content fits, the resize handle should be placed appropriately. Otherwise, try adding overflow:hidden using CSS on the grid items.


updated version in package.json to 1.0.7

Fixes #
Proposed Changes

Testing

Pull Request Test Coverage Report for Build 143

0 of 0   changed or added relevant lines in 0 files are covered.
101 unchanged lines in 2 files lost coverage.
Overall coverage increased (+5.5%) to 84.665%

Files with Coverage Reduction
New Missed Lines
%

../lib/help.js
7
62.0%

../lib/index.js
94
19.05%

Totals

Change from base Build 121:
5.5%

Covered Lines:
1411

Relevant Lines:
1592

💛  - Coveralls


NEW: Fix package config on Windows

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

I don't think cross compiling for osx-arm is going to work because we are building cargo-c in the build script instead of installing it as a conda package. The reason is that cargo-c needs to be build for the host platform because it needs to run, but rav1e needs to be built for the target platform. So we have two different compile targets in the same script.

I think this build will pass now. In order to get cross compiling working, we probs need to see if we can cross-compile without cargo-c, then if that works, move cargo-c into it's own package.

I tested linux cross compiling locally, it works if you're not building cargo-c.

great work

do we specify conda-forget targets:
https://doc.rust-lang.org/cargo/reference/config.html#target
It would be great if we could specify
--target ${HOST}

instead of the sed hacks i made.

@conda-forge-admin please rerender

let's push this forward and troubleshoot the PPC compilation later.

@conda-forge-admin, please rerender

opps, sorry for the heavy handed push. I just tried to revert back to the old way for ppc64le while we figure things out on the cargo-c side.


Create a Mid Section Project component for the Third theme

As per provided designs, Create a Mid-Section Project component for the Third theme

Reference for the design: https://www.figma.com/file/0ISIz6XklEToDd4KXfIWRB/SCoRe-Lab-Theme-designs?node-id=3%3A3
Cc: @charithccmc, @dinithminura

@Abhijay007 After 2 weeks of exams, I'm now available for two months and want to work on some of the issues in this repo. Also, After working on the fifth theme now I want to explore and develop the third theme.
Can I start working on this next? ( if it's ready to be implemented )


Connection Initialization issue

It's unclear whether some objects of the connection class can be null initialized or not.
A simple if statement revisit will suffice.

It's unclear whether some objects of the connection class can be null initialized or not. A simple if statement revisit will suffice.

Hello!
It seems that your project is intended exclusively for your machine.
There was a problem opening the project (Visual Studio), The project file 'C:\Users\User\source\repos\DVC\DVC.vcxproj' has been moved, renamed, or is missing from your computer.
Moreover, the project itself is located in another directory
C:\Users\User\source\repos\DataVista
Please provide instructions on how to solve this problem

Hello @smellilac!
Have you tried following this step?

DVC.dll can be found in https://github.com/agC86/DataVista/tree/master/x64/Release

Hello @smellilac!
Have you tried following this step?
DVC.dll can be found in https://github.com/agC86/DataVista/tree/master/x64/Release

Yes, I did.
But nothing changed.
I wrote about it because Visual Studio requires loading DVC.vcxproj first, which is typical not for C#, but for C++. And because the file must be in a strange directory.

I know it's a C/C++ dll to import some functions into the project. However
I think it will be better off making a separate package for it seems it's
giving you issues.
Will fix it for you today or tomorrow.
On Sun, 28 Jul 2024, 11:00 smellilac, @.***> wrote:

Hello @smellilac https://github.com/smellilac!
Have you tried following this step? [image: image]
https://private-user-images.githubusercontent.com/105457539/352773764-8b114141-25bc-48e9-bc40-988fa983a80a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxNTY0ODIsIm5iZiI6MTcyMjE1NjE4MiwicGF0aCI6Ii8xMDU0NTc1MzkvMzUyNzczNzY0LThiMTE0MTQxLTI1YmMtNDhlOS1iYzQwLTk4OGZhOTgzYTgwYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzI4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyOFQwODQzMDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yMTJjZjlkN2Q3NzkyNGU5OGQxMGU5NTA2YTc4ZTk2YzVjZmQ0NWNkOGE0YWIzNjVmNjU3ZDM4ZGE2ZDY4YzEwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.5lO1WSmeblxIqfD2Y8Wkyh-MYpY3yIL7zuWCqAv2HOo
DVC.dll can be found in
https://github.com/agC86/DataVista/tree/master/x64/Release
Yes, I did.
But nothing changed.
I wrote about it because Visual Studio requires loading DVC.vcxproj first,
which is typical not for C#, but for C++. And because the file must be in a
strange directory.
—
Reply to this email directly, view it on GitHub
https://github.com/agC86/DataVista/issues/8#issuecomment-2254402838, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AZESPA5R2WNDTMU4ETIDKTDZOSXKNAVCNFSM6AAAAABLQO65H2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGQYDEOBTHA
.
You are receiving this because you were assigned.Message ID:
@.***>

@smellilac DVC.dll has been removed from the project. You should be able to build successfully now.
Here's the list of dereference issues in the project.

Nothing changed :sweat:

Your fork is outdated, it still has the DVC in there.


ImportError: miniconda3/envs/open-mmlab/lib/python3.7/site-packages/mmcv/_ext.cpython-37m-x86_64-linux-gnu.so: undefined symbol: _ZN6caffe28TypeMeta21_typeMetaDataInstanceISt7complexIdEEEPKNS_6detail12TypeMetaDataEv

Checklist

I have searched related issues but cannot get the expected help.
The bug has not been fixed in the latest version.

Describe the bug
Something wrong with MMdetection Compiler or Cuda Compiler?
Reproduction

What command or script did you run?

from mmdet.apis import init_detector, inference_detector, show_result

Did you make any modifications on the code or config? Did you understand what you have modified?
No, i didn't make any modifications.

Environment

Please run python mmdet/utils/collect_env.py to collect necessary environment information and paste it here.
Actually, when I tried to run python mmdet/utils/collect_env.py, I got the same problems. The traceback is as follows.

$ python mmdet/utils/collect_env.py
Traceback (most recent call last):
  File "mmdet/utils/collect_env.py", line 64, in <module>
    for name, val in collect_env().items():
  File "mmdet/utils/collect_env.py", line 57, in collect_env
    from mmcv.ops import get_compiler_version, get_compiling_cuda_version
  File "/home/zhongyujiang/miniconda3/envs/open-mmlab/lib/python3.7/site-packages/mmcv/ops/__init__.py", line 1, in <module>
    from .bbox import bbox_overlaps
  File "/home/zhongyujiang/miniconda3/envs/open-mmlab/lib/python3.7/site-packages/mmcv/ops/bbox.py", line 3, in <module>
    ext_module = ext_loader.load_ext('_ext', ['bbox_overlaps'])
  File "/home/zhongyujiang/miniconda3/envs/open-mmlab/lib/python3.7/site-packages/mmcv/utils/ext_loader.py", line 10, in load_ext
    ext = importlib.import_module('mmcv.' + name)
  File "/home/zhongyujiang/miniconda3/envs/open-mmlab/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
ImportError: /home/zhongyujiang/miniconda3/envs/open-mmlab/lib/python3.7/site-packages/mmcv/_ext.cpython-37m-x86_64-linux-gnu.so: undefined symbol: _ZN6caffe28TypeMeta21_typeMetaDataInstanceISt7complexIdEEEPKNS_6detail12TypeMetaDataEv

Then I commented out the relative code lines(line57-line59), I got the result. (Compiler version and CUDA Compiler Version are missing here)
sys.platform: linux
Python: 3.7.6 (default, Jan  8 2020, 19:59:22) [GCC 7.3.0]
CUDA available: True
CUDA_HOME: /usr
NVCC: Cuda compilation tools, release 10.0, V10.0.130
GPU 0,1,2,3: GeForce RTX 2080 Ti
GCC: gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
PyTorch: 1.6.0
PyTorch compiling details: PyTorch built with:
  - GCC 7.3
  - C++ Version: 201402
  - Intel(R) Math Kernel Library Version 2020.0.0 Product Build 20191122 for Intel(R) 64 architecture applications
  - Intel(R) MKL-DNN v1.5.0 (Git Hash e2ac1fac44c5078ca927cb9b90e1b3066a0b2ed0)
  - OpenMP 201511 (a.k.a. OpenMP 4.5)
  - NNPACK is enabled
  - CPU capability usage: AVX2
  - CUDA Runtime 10.1
  - NVCC architecture flags: -gencode;arch=compute_37,code=sm_37;-gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_61,code=sm_61;-gencode;arch=compute_70,code=sm_70;-gencode;arch=compute_75,code=sm_75;-gencode;arch=compute_37,code=compute_37
  - CuDNN 7.6.3
  - Magma 2.5.2
  - Build settings: BLAS=MKL, BUILD_TYPE=Release, CXX_FLAGS= -Wno-deprecated -fvisibility-inlines-hidden -DUSE_PTHREADPOOL -fopenmp -DNDEBUG -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DUSE_VULKAN_WRAPPER -O2 -fPIC -Wno-narrowing -Wall -Wextra -Werror=return-type -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-sign-compare -Wno-unused-parameter -Wno-unused-variable -Wno-unused-function -Wno-unused-result -Wno-unused-local-typedefs -Wno-strict-overflow -Wno-strict-aliasing -Wno-error=deprecated-declarations -Wno-stringop-overflow -Wno-error=pedantic -Wno-error=redundant-decls -Wno-error=old-style-cast -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Wno-stringop-overflow, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, USE_CUDA=ON, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=ON, USE_MPI=OFF, USE_NCCL=ON, USE_NNPACK=ON, USE_OPENMP=ON, USE_STATIC_DISPATCH=OFF,

TorchVision: 0.7.0
OpenCV: 3.4.2
MMCV: 1.0.5
MMDetection: 2.3.0+ae453fa

How you installed PyTorch [e.g., pip, conda, source]
conda install -c pytorch pytorch torchvision -y

Error traceback
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/zhongyujiang/mmdetection/mmdet/apis/__init__.py", line 1, in <module>
    from .inference import (async_inference_detector, inference_detector,
  File "/home/zhongyujiang/mmdetection/mmdet/apis/inference.py", line 6, in <module>
    from mmcv.ops import RoIAlign, RoIPool
  File "/home/zhongyujiang/miniconda3/envs/open-mmlab/lib/python3.7/site-packages/mmcv/ops/__init__.py", line 1, in <module>
    from .bbox import bbox_overlaps
  File "/home/zhongyujiang/miniconda3/envs/open-mmlab/lib/python3.7/site-packages/mmcv/ops/bbox.py", line 3, in <module>
    ext_module = ext_loader.load_ext('_ext', ['bbox_overlaps'])
  File "/home/zhongyujiang/miniconda3/envs/open-mmlab/lib/python3.7/site-packages/mmcv/utils/ext_loader.py", line 10, in load_ext
    ext = importlib.import_module('mmcv.' + name)
  File "/home/zhongyujiang/miniconda3/envs/open-mmlab/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
ImportError: /home/zhongyujiang/miniconda3/envs/open-mmlab/lib/python3.7/site-packages/mmcv/_ext.cpython-37m-x86_64-linux-gnu.so: undefined symbol: _ZN6caffe28TypeMeta21_typeMetaDataInstanceISt7complexIdEEEPKNS_6detail12TypeMetaDataEv

Looking forward to reply. Many Thanks!

Please check whether the Pytorch used for compiling your mmcv is the same as the runtime mmcv. For example, you may upgrade your pytorch version after install mmcv-full, in this situation, you need to re-install mmcv-full.

Have you solved the problem？It seems that there is no version of mmcv suitable for torch 1.5.0 and cuda10.0?  When you "pip install mmcv-full==1.0.4+torch1.5.0+cu100 -f https://openmmlab.oss-accelerate.aliyuncs.com/mmcv/dist/index.html" , you can not find a suitable source.

Have you solved the problem？It seems that there is no version of mmcv suitable for torch 1.5.0 and cuda10.0? When you "pip install mmcv-full==1.0.4+torch1.5.0+cu100 -f https://openmmlab.oss-accelerate.aliyuncs.com/mmcv/dist/index.html" , you can not find a suitable source.

In this case you can simply use pip install mmcv-full==1.0.4. This is because Pytorch 1.5 does not have pre-built package for CUDA 10.0.

I am facing the same import error with an undefined symbol when I try to run  python mmdet/utils/collect_env.py .
I am using
pytorch 1.7
cuda 10.2
mmcv-full 1.3.18
mmdet 2.20.0
Looking forward to your reply, thank you.

@prasadh711 You can try this:
mim uninstall mmcv-full
mim install mmcv-full
to upgrade mmcv to match current pytorch version


[WIP] Compute HFO rates, and API for merging HFO detections

PR Description
Closes: #11 , #5
Also will attempt to: #12
TODO:

Fix unit test for hfo rate, and make it more robust with error checks
Refactor the merging of HFO detections

Merge checklist
Maintainer, please confirm the following before merging:

[ ] All comments resolved
[ ] This is not your own PR
[ ] All CIs are happy
[ ] PR title starts with [MRG]
[ ] whats_new.rst is updated
[ ] PR description includes phrase "closes <#issue-number>"

Looks mostly good. The working_with_bids file is empty. Delete or write out the example. Otherwise, just a few minor comments


Log detailed timing of block creation steps

PR description
if log level is at debug, detailed timing of block creation steps are logged, along with the standard block info.
Log will look like this:
2024-04-04 15:20:40.626+00:00 | MinerExecutor | INFO  | BlockMiner | Produced #260,592 / 2 tx / 0 om / 200,000 (0.3%) gas / (0xeb30913e8d15e29c04162ac4cbca67b3fa90b92b4cfbea240f7c7a9e39ddc842) in 0.000s, timing [Started at 2024-04-04T15:20:40.418575040Z, protocolWait=PT0.199224809S, duplicateWorldState=PT0.000182886S, preTxsSelection=PT0.003144382S, txsSelection=PT0.004291671S, blockAssembled=PT0.000702624S, importingBlock=PT0.000591079S, notifyListeners=PT0.000001143S, log=PT0.000008992S]

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

[ ] Checked out our contribution guidelines?
[ ] Considered documentation and added the doc-change-required label to this PR if updates are required.
[ ] Considered the changelog and included an update if required.
[ ] For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

[ ] unit tests: ./gradlew build
[ ] acceptance tests: ./gradlew acceptanceTest
[ ] integration tests: ./gradlew integrationTest
[ ] reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 what does the PT signify before the number eg protocolWait=PT0.199224809S,
also is S for seconds? I think lower case s is easier to read with numbers

@fab-10 what does the PT signify before the number eg protocolWait=PT0.199224809S,
also is S for seconds? I think lower case s is easier to read with numbers

just using the default Duration.toString() but I agree that for so short duration could not be very readable, will propose another format, that works with millis

@macfarla updated to look like this one:
protocolWait=254ms, duplicateWorldState=0ms, preTxsSelection=3ms, txsSelection=9ms, blockAssembled=1ms


ShowCursor should use BOOL bShow and pass it in as a parameter.

          int ShowCursor(int bShow) => _ShowCursor(bShow);

final _ShowCursor = _user32.lookupFunction<Int32 Function(Int32 bShow),
int Function(int bShow)>('ShowCursor');`

This method of hiding the mouse also does not work. It may be because this parameter is wrong. You should use BOOL bShow and pass it in as a parameter.
C:\Program Files (x86)\Windows Kits\10\Include\10.0.22621.0\um\WinUser.h
int
WINAPI
ShowCursor(
In BOOL bShow);
Originally posted by @user1121114685 in https://github.com/dart-windows/win32/issues/313#issuecomment-2005780078

There is no issue with the parameter.
BOOL is defined as a struct with a single int field in the metadata:

Since this struct is marked with a NativeTypeDef attribute, we simplify it by projecting it as int for ease of use.

Hi Developer, can you check why ShowCursor is not working? I passed ShowCursor(0) in dart; the mouse is not hidden!


Address flag

#85
Signed-off-by: Colm Malone<EMAIL_ADDRESS>

Hello and thanks for your contribution!
Can you make your PR against https://gitlab.com/nvidia/container-toolkit/gpu-monitoring-tools
This repo is mirrored from there!
I'm also almost done with a bot that will automatically post this message :D !

No problem. Just submitted a Merge-Request on gitlab.
In it, I replaced the -port flag with the -address flag, to avoid confusion as -port is now redundant.

Closing - as PR moved to gitlab.


Fix wotlk classic log parsing

This PR allows for parser to successfully parse WOTLK combat logs.
The arena start and end are inferred from ZONE_CHANGE events, it's the only way I found to frame arenas.
Also, arena prepartion buff is not showing up in combat logs, so we have no way of knowing the starting combatants, we're currently just recording every combatant between ZONE_CHANGE events. This is really not ideal (some events from the loading map arrive before the ZONE_CHANGE event), but parser trims events until the last UNIT_DIED, so this should end up removing unrelated events.
One thing that's currently not handled is what happens when a player quits the arena (his partner is killed, so he quits), then we only get one UNIT_DIED event and might be losing some arena related events between that death and the player quitting. This wasn't handled previously and probably might not be too worth doing.

@kunchenguid seems like i broke the old classic tests, does it make sense to keep maitaining those? I don't know from what version those are

@sschepens ah.. we should probably replace those with wotlk logs - I do think continuing to have test cases that conceptually guard the same things would be useful

I do think continuing to have test cases that conceptually guard the same things would be useful

@kunchenguid i didn't fully understand this last part, the wotlk tests I added test the same things as the classic stuff, so we're conceptually guarding the same things, aren't we?

@sschepens  really sorry for the delay. The latest looks great to me! I think this is good to merge!


Object detection: The evaluate result is failed with error "No BBox detected" on the Evaluate page.

System Information (please complete the following information):
Windows OS: Windows-11-Enterprise-21H2
ML.Net Model Builder 2019&2022: <IP_ADDRESS>2201 (Main Build)
Microsoft Visual Studio Enterprise: 2019(16.11.18); 2022(17.3.0)
.Net: 5.0 & 6.0
Describe the bug

On which step of the process did you run into an issue:
The evaluate result is failed with error "No BBox detected" on the Evaluate page for Object detection scenario.

TestMatrix
https://docs.microsoft.com/en-us/dotnet/machine-learning/tutorials/object-detection-model-builder#create-a-new-vott-project
To Reproduce
Steps to reproduce the behavior:

Select Create a new project from the Visual Studio start window.
Choose the C# Console App (.NET Core) project template.
Add model builder by right click on the project.
Select Object detection scenario.
On the Environment page, setup the workspace.
On Data page, select the data source and completed the training.
On the Evaluate page, click "Browse an image" and select an image.
Check the evaluate results.

Expected behavior
The evaluate result should be successful on the Evaluate page.
Screenshot

Additional context:

The bug has been fixed on the latest main branch <IP_ADDRESS>6201.


ap0.5:0.95 is 0.132, which is very low

Yolox official git down the code, only changed batch_ Size. The data set is in coco format. The image resolution is 2446*1000. There are more than 4000 pieces of training and more than 1000 verifications. I have tried 50 and 300epoch, but ap0.5:0.95 is 0.132, which is very low.total_ Loss also oscillates around 8. At this time, AP is basically unchanged.
yolox官方git下来的代码，只改了batch_size，数据集是coco格式，图片分辨率2446*1000，四千多张训练，一千多验证，尝试过50，300epoch，但是AP0.5:0.95为0.132，很低。total_loss也一直在8左右振荡，这个时候ap也基本不变了

I do defect detection. Is this problem caused by the fact that my data set is very different from the data set with pre training weight? Because the training weight is obtained on Imagenet

For defect detection, the image space will surely be wildly different from that the pre-trained model was trained on. The pre-trained weight will be useless if not detrimental here.
But there's a wide array of stuff that could lead to low performance here which I would assume small targets are involved ; this is just one, albeit a definite one, of them.

你自己数据集样本太少了，得先加载预训练的backbone才行


fix(c): fix ockam_key_encrypt arguments check

@robinbudd could you review the changes in this PR

I rebased and merged.


Fixes lingering toolbar

Makes the cell toolbar go away when the cell is cleared.
Fixes #1072
I am not sure about this. In particular, since this is triggered synchronously from the toolbar's "clear cell" button, I don't know if that makes a Qt widget commit suicide while it's on the stack.

Should go on v2.2.

setActiveCell() only does the toolbar change. I don't know, I kind of like having this general method "active cell changed" there, rather than the toolbar replacement being inlined; of course we need to be clear on what the message means: the cell changed, not the selection coords.


send status codes and error messages from all grpc servants

Currently most of servants return the generic grpc error (equivalent of returning a 500).
For example:
    public void findJob(JobFindJobRequest request, StreamObserver<JobFindJobResponse> responseObserver) {
        try {
            responseObserver.onNext(JobFindJobResponse.newBuilder()
                    .setJob(whiteboard.findJob(request.getName()))
                    .build());
            responseObserver.onCompleted();
        } catch (EmptyResultDataAccessException e) {
            responseObserver.onError(Status.NOT_FOUND
                    .withDescription(e.getMessage())
                    .withCause(e)
                    .asRuntimeException());
        }
    }

Looking into if we can solve this with a global ServerInterceptor now.


🐛 Adjust feature extraction expected result check

Feature extraction model can have 3-d output.
Fixes #194

Thank you vvmnnnkv!
I've written a PHP SDK for huggingface similar than this one.
I would like to add to this project (huggingface.js) some of my features not present, like for example ejecute different tasks for one model (right now huggingface.js only allows to ejecute the default task).
Is there any guide to download the project, execute tests, and propose changes?
Thanks in advance!


Single-sign-on --> Single sign-on typo fix

This probably just needs one reviewer to confirm the correct use of single sign-on (SSO)

Single sign-on seems to be the industry norm.


js + sass + copy = watch/compile loop

Hi
It seems that using mix.js() + mix.sass() + mix.copy() causes npm run watch to keep compiling.
Here's the code I'm using:
mix
    .js('./resources/assets/js/nebula.js', './js')
    .sass('./resources/assets/sass/nebula.scss', './css')
    .copy('./js/nebula.js', '../../../public/vendor/nebula.js')
    .copy('./css/nebula.css', '../../../public/vendor/nebula.css')

I'm running mix inside a packages/vendor/name folder, so not in the project's route.
When I run npm run watch my console gets crazy and the only things I can see are
WAIT: compiling...
WAIT: Compiled successfully in Nms
WAIT: compiling...
WAIT: Compiled successfully in Nms
WAIT: compiling...
WAIT: Compiled successfully in Nms
WAIT: compiling...
WAIT: Compiled successfully in Nms

and so on.

I'm not sure. Can you break it down and give me simple reproducible steps?

I had the same with the .sass, trying to debug now.

This might solve your issue @nicgutierrez https://github.com/JeffreyWay/laravel-mix/issues/228

thanks @nickkuijpers , I'll look into it :)

I too am having this problem when developing a package and wanting to automatically copy the compiled assets to the app's public/vendor folder.
I have tried the response to issue #228 but it didn't help. @nicgutierrez did you manage to fix it?

It's some package that you removed but left in the webpack.mix.js that causes this. I had this issue before.

@ruchern I don't think it's that in my case.
This is my webpack.mix.js
const { mix } = require('laravel-mix');

mix.setPublicPath(__dirname + "/public");
mix.setResourceRoot(__dirname + "/resources");

mix.js('resources/assets/js/app.js', 'js')
    .sass('resources/assets/sass/app.scss', 'css')
    .copy('resources/assets/images', 'public/images', false);

if (mix.config.inProduction) {
    mix.version();
}

mix.copy('public', '../../../public/vendor/my_package', false);

Try placing that last line of copy before any compiling?

I would need to compile them before copying though...

When I remove the copy line, it doesn't infinite loop, weird.

Try mix.copyDirectory() for last line. That looks like a directory to me. Assuming only.

copyDirectory doesn't work at all, I think it's documented incorrectly. That's why I included the false parameter.

I am also seeing this issue on a brand new install of Laravel 5.4. My mix file is really simple:
mix.js('resources/assets/js/main.js', 'public/js')
    .sass('resources/assets/sass/app.scss', 'public/css');

I have commented out both parts in turn and it's the parsing image URLs part of the sass script that causes the loop. If I comment out the background definition here:
body {
  background: url('images/bg-widescreen.jpg') no-repeat;

Then it compiles with no issues.

@raffjones this worked for me
mix.js('resources/assets/js/main.js', 'public/js')    .sass('resources/assets/sass/app.scss', 'public/css')    .options({ processCssUrls: false });
thanks!


Lua default libs not loaded in Lua5.2

In Lua5.2 when using string, io, etc. inside a worker it raises:
close lua_State (error: exec.lua:17: attempt to index global 'io' (a nil value))

Still needs require again in new process before using them!

This is not actually an issue - it works like this by design (and has been working like this since earlier luaproc versions). Only essential libraries (base and package) are loaded, all others must be explicitly required in new Lua processes, as proposed in Programming in Lua (PiL). Check PiL (3rd ed), chapter 31 (Threads and States), page 331: "Whenever a process needs one of these libraries, it requires the library explicitly, and require will call the corresponding luaopen_* function".


Pre-2.0 Switch visuals

Describe the feature
If possible can the switches have a propery bool that switch back to the boxy switches instead of the Windows 10 style ones?
Personally I think they look much better.

@nevaran Sorry, I'll not bring back the old one. But it should be possible to do this with the current style implementation and some changes to bring it back.


WIP: Update vendor 20180706

WIP vendor update to onboard go-openapi updates that fix #1602 and #1429

Don't worry all this will be squashed as soon as the go-openapi branches are merged.


chore(release): 26.1.3

Release 26.1.3

Pull Request Test Coverage Report for Build 5375

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.721%

Totals

Change from base Build 5374:
0.0%

Covered Lines:
1056

Relevant Lines:
1091

💛  - Coveralls