[BUG] JWT expiry setting not honored

Describe the bug
The code of this repository (see AuthTokenProcessorHandler:L354) and this comment suggest there is a JWT expiry setting. However, when setting it like below, it doesn't work (JWT expiry is still the default 60 * 60 seconds).
config.yml
_meta:
  type: "config"
  config_version: 2

config:
  dynamic:
    kibana:
      multitenancy_enabled: false
    http:
      anonymous_auth_enabled: false
    authc:
      clientcert_auth_domain:
        description: "Authenticate via SSL client certificates (for Kibana Server)"
        http_enabled: true
        transport_enabled: true
        order: 0
        http_authenticator:
          type: "clientcert"
          config:
            username_attribute: "cn"
          challenge: false
        authentication_backend:
          type: "noop"
      saml_auth_domain:
        http_enabled: true
        transport_enabled: false
        order: 1
        http_authenticator:
          type: "saml"
          challenge: true
          config:
            idp:
              metadata_url: "https://subdomain.okta.com/app/xxx/sso/saml/metadata"
              entity_id: "http://www.okta.com/xxx"
            sp:
              entity_id: "logs-kibana-saml"
            kibana_url: "https://kb.logs.example.com/"
            roles_key: "Roles"
            exchange_key: "xxx"
            jwt:
              expiry: NOW+10
        authentication_backend:
          type: "noop"

To Reproduce
Steps to reproduce the behavior:

Set the config.yml of the security plugin to the contents shown above
Apply it with securityadmin.sh
Log in Kibana
Wait for 10-20 seconds
Refresh a Kibana page and see that the session is still valid/no re-login is required

Expected behavior
Setting jwt.expiry should change the TTL of the generated JWT.
Host/Environment (please complete the following information):

OS: Ubuntu 20.04
ElasticSearch: OSS 7.10.2
Kibana (opendistroforelasticsearch-kibana): 1.13.2
OpenDistro versions:

opendistro-alerting               <IP_ADDRESS>-1
opendistro-anomaly-detection      <IP_ADDRESS>-1
opendistro-asynchronous-search    <IP_ADDRESS>-1
opendistro-index-management       <IP_ADDRESS>-1
opendistro-job-scheduler          <IP_ADDRESS>-1
opendistro-knn                    <IP_ADDRESS>-1
opendistro-knnlib                 <IP_ADDRESS>
opendistro-performance-analyzer   <IP_ADDRESS>-1
opendistro-reports-scheduler      <IP_ADDRESS>-1
opendistro-security               <IP_ADDRESS>-1
opendistro-sql                    <IP_ADDRESS>-1
opendistroforelasticsearch        1.13.2-1

Seems related to https://github.com/opensearch-project/security-dashboards-plugin/issues/828

[Triage] Issue remains relevant as it is at least tangentially related to ongoing work on session management.


Adds staff-only command to clear Signup cache

What's this PR do?

Checks for whether current User has role set to 'staff' or 'admin'  and has texted in a Clear Cache command. If true, delete the cached Signup model and call getCurrentSignup(req)

How should this be reviewed?
Test by locally modifying your User's role property in the users collection, and text in clear cache keyword (set by GAMBIT_CMD_CLEAR_CACHE environment variable).

Text Clear Cache keyword when a Signup exists in Phoenix, confirm existing Signup is cached to Gambit Signups collection
Remove signup from Phoenix admin UI, text Clear Cache keyword and confirm new Signup ID is created in Phoenix and cached to Signups collection

Any background context you want to provide?
For internal testing of Signup flow to avoid API error code 500 returned when resubmitting a Signup for a a given Campaign and User.
Relevant tickets

Fixes #634
https://github.com/DoSomething/northstar-js/pull/27

Checklist

[ ] Documentation added for new features/changed endpoints.
[x] Tested on staging.

Added documentation to https://github.com/DoSomething/gambit/wiki/Development#testing


Dev test setup script

Initial attempt at creating a python script to help with S3 dev bucket setup.
Script provides prompts to clear out all lamp dev buckets and copy random selection of from from gtfs bucket to incoming bucket.

a few questions and suggestions.

this mostly looks good to me.
i think there is some decision making about logging vs print that should be considered, especially if you want to add a log level to the arg parse to cut back on how much is actually output.
i also think its worth considering making a single s3 client that gets used everywhere.


Add typeahead to search

Currently, the search form does not provide any typeahead or suggested search.

but it provides a wildcard, which is nice :)

@justinlittman @jermnelson would adding typeahead to Sinopia lookup / search give us anything beyond what is already possible by user adding a wildcard?

It would provide real-time feedback as the user is typing, but not different results than wildcard searching (I think).

Can re-open if this proves to be a requirement.


Increase intensity profile compounding speed

This PR increases the speed of combining anchors of Bigbrain intensity profiles significantly since the pairwise summing of point anchors scales linearly with the number of points. Potentially, there could be 170k points if one queries for the whole big brain template. This could take up to an hour with the current methods. This PR allows the implementation of a method special to such features to quickly produce a merged location. This is currently only implemented for points and Vigbrain intensity profiles. The speed increase is quite drastic, so much so that compounding time becomes almost negligible.
import siibra
fts = siibra.features.get(siibra.get_template('bigbrain'), siibra.features.cellular.BigBrainIntensityProfile)

Codecov Report
Attention: 1221 lines in your changes are missing coverage. Please review.

Comparison is base (5a0e6b3) 36.81% compared to head (5032614) 50.84%.
Report is 276 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #510       +/-   ##
===========================================
+ Coverage   36.81%   50.84%   +14.02%
===========================================
  Files          61       69        +8
  Lines        5421     6459     +1038
===========================================
+ Hits         1996     3284     +1288
+ Misses       3425     3175      -250

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update clickhouse operator for kubernetes to release 0.6.0

Thanks submitting your Operator. Please check below list before you create your Pull Request.
New Submissions

[ ] Have you selected the Project Community Operator Submissions in your PR on the right-hand menu bar?
[ ] Are you familiar with our contribution guidelines?
[] Have you packaged and deployed your Operator for Operator Framework?

[] Have you tested your Operator in all supported installation modes?

Updates to existing Operators

[x] Is your new CSV pointing to the previous version with the replaces property?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?

Your submission should not

[x] Modify more than one operator
[x] Submit operators to both upstream-community-operators and community-operators at once
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description about the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file a PR against this repo and explain your need
2 For more information see here

Description on pr-sanity-check
PR includes changes to more than one operator subdirectory: [clickhouse-operator, clickhouse]

this is because there was a desision to rename folder from clickhouse-operator to clickhouse

Clarification on pr-sanity-check
PR includes changes to more than one operator subdirectory: [clickhouse-operator, clickhouse]

this is because there was a decision to rename folder from clickhouse-operator to clickhouse - but it is still one operator only

Makes sense. The system still catches this PR as it modifies more than one directory. Can you separate into two PRs for atomic testing please?

Can you separate into two PRs for atomic testing please?

Ok, I'll make two PR's - one to remove clickhouse-operator folder and another to add clickhouse folder with all the content


Add support for ARM processors

Add support for Arm architectures as it may be usefull for robotics problems (most robots currently use Arm processors).

Google has a standalone C header file for Linux syscalls that supports a number of architectures:https://chromium.googlesource.com/linux-syscall-support/
Breakpad uses it, so I know it works on ARM 32/64, and I'm pretty sure it works on MIPS and some other architectures. It might be a useful reference.


Add document for generating protocol methods in HLC SDK

This PR adds a document for generating protocol methods in HLC SDK.
You can find the document here
Fixes: https://github.com/Azure/autorest.csharp/issues/2029

/check-enforcer reset

/check-enforcer evaluate

/check-enforcer override

/check-enforcer override


⚠ AGEG website (prod) has degraded performance

In 8230490, AGEG website (prod) (https://www.ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 2103 ms

Resolved: AGEG website (prod) performance has improved in 7bcd4b0.


Dataset class refactored into three modules

For more readability, dataset module was split to three modules - helpers, dataset and lazy_dataset. from_files method can be found in helpers. All configuration files remain compatible with the change.

poďte mi někdo...

approve und merge, bitte :-)


Battery Health Grafana Dashboard

I got my own TeslaMate Custom Dashboards where there are several dashboards for my own use, but I decided to share them with people and friends who could be interested in use them. Those dashboards are called: Battery Health, Charging Costs Stats, Charging CurveStats, Current State, Mileage Stats and Tracking Drives. There are also two dashboards (Current Charge & Drive View) that could be browsed on the car while driving or charging.
In this pull request I want to merge to TeslaMate the Battery Health dashboard that I am especially proud of, since the initial idea came some years ago from when I had a Hyundai Kona EV from which I logged the data with from a ODB2 scanner (OVMS) and saved in Influxdb to visualize them with Grafana. From there, the original idea of generating a dashboard that allows me to check the battery health was born. The calculations were not easy, but over time I could refine them. Now that I have a Tesla and use TeslaMate, I realize that a chart of this type was also needed, so I adapted it without much effort thanks to the amount of data that TeslaMate logs.
This dashboard is meant to have a look of the Battery health based on the data logged in Teslamate. So, the more data you have logged from your brand-new car the better, both for degradation and cycle estimations.
Degradation is just an estimated value to have a reference, measured on usable battery level of every charging session in the last month with enough kWh added (in order to avoid dirty data from the sample), calculated according to the rated efficiency of the car. Then you can see the mileage logged in Teslamate and an estimation of the number of cycles of the battery. On the other hand, you'll see a plotly chart that represents the evolution of the car's battery capacity during its entire lifetime.
Lately I've changed subqueries to INNER JOINS in order to get better performance. It has reduced from 10s to 2s on loading some panels with lot of estimations.
Finally, there is an important improvement for those who have not used Teslamate since they got their car, or for those who have bought it second hand. Now it is possible to set the max range to 100% and the battery capacity of the car battery when it was new in order to get an accurate and better estimation.

I hope you consider including this contribution into the main project.
Regards,

please integrate this @adriankumpf

It will be extremely useful. Add this Adrian please.

Hi Folks,
With great pride, I want to announce that my repository with TeslaMate Custom Dashboards  has been considered among the 5 finalists in the Grafana Golden Grot Awards, celebrating a decade of Grafana dashboards. If you like this project, please, Vote now! Polls close at 11:59 p.m. PDT on Friday, May 5.
TeslaMate electric vehicle monitoring dashboard (Juan Carlos Heredia)

Fantastic work! ❤ Thank you very much.
@adriankumpf
Thank you for the great job on making up Teslamate!!!!

There is an issue with projects.md, a bunch of documentation is deleted with this PR.

They are not deleted, there were just sorted in alphabetical order.

Holy smokes, this is beautiful @jheredianet

For some reason it reports my P85D to have 94kwh new capacity?

For some reason it reports my P85D to have 94kwh new capacity?

Remember this is just an estimation, not a reading from the Car. For some reason your data logged in Teslamate some MaxRange and its calculated from it. I could be many reasons:

Maybe data you imported from other logger systems.
Maybe a manual input in the database
May an uncompleted charging session.

If you can query your database, you may find where is the record that is giving you the max range, somo of them are treated here https://github.com/jheredianet/Teslamate-CustomGrafanaDashboards/issues/38
Anyway, if you know exactly what is your battery capacity and the range when the car was new, you could put those values in the top to tune the estimations.

Remember this is just an estimation, not a reading from the Car. For some reason your data logged in Teslamate some MaxRange and its calculated from it. I could be many reasons:

Maybe data you imported from other logger systems.
Maybe a manual input in the database
May an uncompleted charging session.
It does include old data from Teslafi, hmmmm

I can't really remember where the import cuts, but ther's a sudden drop in the curve that could maybe explain it

I can't really remember where the import cuts, but ther's a sudden drop in the curve that could maybe explain it.
Then again, I'm pretty sure the Teslafi data is the relatively few samlepoints early on, as soon as the samling interval gets more frequent I'll assume that's Teslamate using the streaming API?

Yes sure, Teslamate uses the streaming API (based in your settings) and more data is logged.

For some reason it reports my P85D to have 94kwh new capacity?

Interestingly, my S 85 shows the same 94kWh capacity. Car is 9 years old but only started using teslamate about 3 years ago. No data was imported from other loggers and no manual input.

The projected range dashboard estimates 355km for this car, which is pretty accurate, but battery health shows 445.
I'll try to follow https://github.com/jheredianet/Teslamate-CustomGrafanaDashboards/issues/38 and report what I find.

Anyway, if you know exactly what is your battery capacity and the range when the car was new, you could put those values in the top to tune the estimations.

Is it possible to save these 2 parameters ?

Anyway, if you know exactly what is your battery capacity and the range when the car was new, you could put those values in the top to tune the estimations.

Is it possible to save these 2 parameters ?

Anyway, if you know exactly what is your battery capacity and the range when the car was new, you could put those values in the top to tune the estimations.

Is it possible to save these 2 parameters?

No, but there is a work around discussed here https://github.com/jheredianet/Teslamate-CustomGrafanaDashboards/discussions/53#discussioncomment-6944706

Just want to chime in and say GREAT WORK! Really really appreciated!

Just want to chime in and say GREAT WORK! Really really appreciated!

Thank you for your feedback. Enjoy!!! 😊


Allowing open sound preferences from media keys

This PR restores the ability to open the Sound preferences pane when pressing option + volume control keys.

I tried doing the same for the brightness keys but no modifiers were sent when pressing them.

 I totally forgot that even though I fixed that one myself 😅 just run Carthage update in the project and it should work again! 🙂

That worked. Thanks.

Hi @paphonb
I'll try to check this out again soon, just fixed the conflict after the latest merge for you 🙂


Add option to reverse qubit order in latex drawer

Summary
This commit adds a new kwarg parameter to the latex drawer
reverse_qubits which gives users an option to reverse the order qubits
are displayed. Currently the bit order increases downward with the q_0
bit being displayed at the top. When the reverse_qubit option is set to
True the order is reversed and q_N is at the top and the order
decreases.
Details and comments
Related to #693

Is it possible to do this for the matplotlib_circuit_drawer too? We want to keep the interfaces as close as possible. Because most users will call them via the wrapper method circuit_drawer.

@ajavadia sure it should be simple enough. I haven't looked at the matplotlib drawer in detail yet. But I'll take a look and add that on to this PR too.

Thanks. @t-imamichi and @nkanazawa1989 may be able to help.

@mtreinish matplotlib_citcuit_drawer has a y-coordinate of each gate in dictionary format. It is very easy to change the order of it. I'll work on it.

@mtreinish In your code, the option seems to reverse the bit order of qubits only. And if we assign multiple qubits, order of qubit might be reversed. These are correct spec?
https://github.com/Qiskit/qiskit-terra/pull/762/files#diff-601179d490e381950db4bf9a4fe01d93R272

I modified matplotlib_circuit_drawer part. Also creg order is changed.

Please, remember to file an issue before sending the PR and include “Fix #issuenumber” in the PR description to keep them linked. This helps us to keep track of the state of the library and properly prioritise the tasks. I’ve opened #767 for this.

@nkanazawa1989 yeah, the intent of the feature is to just mirror the qubit side of the circuit. (not to touch the classical bits) So what I have implemented on the latex side was all intentional. If there is more than one qregister the order of those is reversed just like the individual bits.
For example:

when reversed becomes:

@mtreinish  IMHO, the classical registers should be reversed too. They are what we actually use as keys in the histogram, and the order is from right-to-left which is nicely aligned with from bottom-to-up.

@rraymondhp Thanks, I agree.

Yes I agree that classical bits should also be reversed.
But let's not change the order of qubit registers (put them in the order defined by user still circ(q1, q2))

@ajavadia @nkanazawa1989 @rraymondhp ok, I understand now. Let's change the name of the flag to reverse_bits and I'll update the function to reverse the order of the bits (both classical and qubits) but not touch the order of the registers.

Ok, the latest revision corrects the behavior of the new flag as discussed. For example:

when reverse_bits is set to true becomes:

@nkanazawa1989, does the current version of the matplotlib_circuit_drawer function support this same feature? How?

@delapuente Yes. The same function has already implemented in my repo, but I need small adjustment. I will soon make new PR with referring this discussion.

Oh, cool. Just make sure we use the same API. Thank you!


Having issues with positional info

Is it possible to find out which enemy heroes are close (lets say a 500 units range) to a certain player? I'm aware of the existence of "CBodyComponent.m_vecX and Y" and also the cells, but how could I, based on that, find out if there are other heroes near a certain player? (sorry if this is obvious but I'm really not finding an answer).
Also, still regarding positional info, is there any way to find out if an hero is currently
in a lane or in the jungle area? If I had the values  of the areas of each lane I could simply check if my hero current position is within those areas, if yes the hero is "laning", else its "jungling" but how can i get those positional values of each lane?
It might be easy for some but I'm really lost on this and it is of extreme importance for me, could use some help!
Thanks in advance!!

Here is some code that computes entity positions: gist.
It's old, and Source 2 does not have the cellbits property, but you can use a constant value 7 instead.
You will get two X/Y coordinates (from both players you want to look at) this way, and you can compute sqrt(sqr(x1-x2) + sqr(y1-y2)) to get the distance.
Regarding lanes: I think the way it's done is by looking at the player's positions in early game and matching those to map positions you consider being a certain lane. @howardchung might chime in to say how they do it. Afaik Dotabuff does not use player positional info, but click events by the players (it's an entity in the replay which gets emitted each time a player clicks somewhere on the map), and going from there.

Actually I try to parse coordinates for each player during the game. Am I on the right way to get it?

@piaxar: Please do not hijack threads, open a new one!
That said, you can for example do ctx.getProcessor(Entities.class).getByDtName("CDOTA_Hero_Antimage") to get a hero entity.


[SYM-4556] Remove additional self-assumption IAM policy

Description

Removes the IAM policy to allow the Sym Runtime Connector Role to assume itself, as the redundant assumption has been removed from the Sym platform logic

Current dependencies on/for this PR:

main

PR #10   👈

This comment was auto-generated by Graphite.


Fixed reference to classedRe in d3.class by 'restoring' it from d3.v3.

d3.class (with one parameter, in "check for a class" mode) wasn't working because classedRe wasn't defined.

Fixed reference to classedRe in d3.class by 'restoring' it from d3.v3.
Also updated classerOf to use classedRe instead of creating the regex directly.
Added test for d3.class.

Thanks!


Non combat alerts?

This may be out of your scope but it would be great if i could use your same module to track events outside of combat as well.
Right now I use About Time for this but your approach is much cleaner using JSON.
Also, you could end up getting some poison or disease or effect in combat that persists after combat.
Now that there is a built in game world clock, would this be possible?

Hi Jamz, unfortunately this won't be feasible. Turn Alert has no understanding of time or the world clock, it is directly tied to combat rounds. Thank you for the suggestion though.


How to download file on client without exposing file URL?

I would like to create a page displaying file information with one or more download buttons. When the user clicks a Download button, the related file should start downloading in their browser.
How can this be done without using the file URL, or is there a recommended way to do this using the file URL?

Same here, couldn't find any solution, I want to download automatically after uploading an image

@brylie why would you not want to use the file url?
https://github.com/CollectionFS/Meteor-CollectionFS/blob/master/packages/access-point/api.md#fsfileurloptionsanywhere
{{#with file}}
  click to download
{{/with}}

iirc, you could to a method call to the server and reveice the data from the method resonse. but it will be a lot slower.


Can't make index.html work

Hi!
I have tried to run index.html but it is not working.
I got this error:
bundle.js:1053 Uncaught TypeError: Cannot read property 'split' of undefined
Here is where I'm testing (I just deleted the "/" before "/data" to make it work in my scenario):
http://zumit.com.br/App/markua-js/build/index2.html
If you can provide a simpler example without openning files it may be easier for me to understand as I'm planning to get the data with php.
Thanks in advance,
Claudio

The error that I got is due to the data directory not being at "/". Creating it there it worked.


import path out of sync with repo name

"github.com/vladimirvivien/getting-started-with-go/greetlib"

vs.
"github.com/vladimirvivien/go-tutorial/greetlib"

See https://github.com/vladimirvivien/go-tutorial/blob/adf92903ffc0efdb29884c81975616a8dbdf0c8e/greetings2/greet.go#L7

@nathanallen Thanks for pointing this out.  I moved things around around a bit.  Fixing.

No problem. Enjoyed your talk!

@nathanallen I realize the issue.  This is an old repository where I was keeping this tutorial.  I moved everything here https://github.com/vladimirvivien/learning-go/tree/master/tutorial.  Thanks anyway for pointing out the issue.


Fix zero area getImageData

Exit early when collision area is zero and prevent getImageData from getting called with a zero width or height.

Finally

^ Had to clone the whole repo into my own project and fix the issue myself just now. Thanks for submitting the PR. (If only it'd get merged now!)

This is killing all my projects.  Any hope that it might get fixed?  Or maybe someone point me to a fixed server?

Better than mine - I just wrapped the call in a try catch statement.
Since this project looks like it has been killed, just create a fork, apply the fix, and use that.

@htmlgames has a fixed version available to the public.  However, rendering looks pretty bad compared to Phosphorus / 2.0.  Text and ovals are grainy and look awful at full size.
https://htmlgames.github.io/htmlgames/differences/UAT/itchy/index.html#zip


BUG: Filtering on columns in read_parquet with partitioned datasets working incorrectly

From debugging with @rjzamora, we see the following problem with filtering on a column (not on a partition key) with a partitioned dataset (with the pyarrow engine):

When you have a partitioned dataset (so eg with a path like /year=2020/month=7/data*.parquet), then the "dask partitions" map to single files (and not row groups, although the default is split_row_groups=True).
But, the statistics are gathered per row group, while the parts are thus files, giving a mismatch between parts and stats at https://github.com/dask/dask/blob/4ae913b13df7c5018e24eea6ee76392a6ef59f3e/dask/dataframe/io/parquet/arrow.py#L325)
That means that when filtering the parts (in apply_filters), wrong statistics are used for deciding on skipping the parts (too many parts are skipped, loosing data)

The easiest short term fix is to disallow gather_statistics=True when having a partitioned dataset (the default is actually to not gather statistics in a partitioned dataset, but when you manually set gather_statistics=True, it will do that, but then incorrectly as described above).
The longer term fix (to actually implement filtering for partitioned datasets) would be to either combine the statistics per row group into statistics per file (aggregate the statistics), or otherwise keep a list of filtered row_groups indices to read per file.
(sorry for the bug report in "words" for now, instead of a code example)

Thanks for raising this issue @jorisvandenbossche, and sorry for the lack of action here!  I plan to look into this tomorrow.  At the least, I will add the suggested error message.  Although, I certainly prefer a more-thorough fix.


Fix syn include path

This location was changed in 8b42024cd5ce5f76a0589a6143917d19fe9dd3d2. I've also taken the liberty of removing a hack that A) doesn't work with BSD sed implementations; and B) is no longer necessary.

@tomroberts-lowrisc I didn't see #929 before making this PR. Please feel free to fold these changes into your PR if appropriate.

Will do - thanks @zachjs

Changes included as part of #929. Closing.


Image processing tool for IIIF metadata

This proposal is for something we might include in the 7.2 release. I think it would be a helpful addition but I haven't explored the details yet. If anyone has thoughts on what I describe I'd welcome your input.
Is your feature request related to a problem? Please describe.
IIIF canvases are containers for the images rendered in an IIIF viewer. Canvases have height and width dimensions that should always have the same aspect ratio as the image and usually the same overall dimensions.
Height and width dimensions can be expressed in bitstream metadata using iiif.image.height and iiif.image.width. If these values are not provided in bitstream metadata, the IIIF service uses default values. These fallback height and width dimensions are part of the iiif.cfg configuration. In addition, work on deriving fallback dimensions dynamically, by fetching the dimensions for the first bitstream, is described in this issue: https://github.com/DSpace/DSpace/issues/8021
Determining the h/w dimensions dynamically should be a big improvement that makes iiif.image.height and iiif.image.width unnecessary in the most simple use cases. But the need for accurate image metadata for each bitstream still exists, especially in multi-image records.
In large digitization projects, the height and width dimensions for each image will often be obtained prior to importing records into DSpace. However, this may not always be possible. Also, there may be cases when images are replaced with new images. In cases like these (and others) a batch process for updating canvas dimensions would be helpful.
Describe the solution you'd like
I'd like to propose a new curation tool, analogous to Media Filter, that can be applied to communities, collections or items. The tool will identify iiif-enabled items, check their metadata for iiif.image.height and iiif.image.width values. If these are missing, the tool will retrieve the image dimensions and create the metadata. It should be possible to force updates by adding an optional flag.

@tdonohue  it looks like once again I created an IIIF issue on the wrong repository. Now I understand the limitation!!
This a pull request for the new feature. https://github.com/DSpace/DSpace/pull/8074

Closing, fixed by https://github.com/DSpace/DSpace/pull/8074


Examples from simfony main repo don't run

The example programs from the simfony main repo don't run on the web IDE because they are missing a mod witness {...} section. The IDE should add an empty mod witness {...} section in this case for compatibility.

Fixed in 2d181c0d71bd153e45b15fc0c199a27575fe9ef2


Catching events doesn't work as advertised

I have a problem with this basic tutorial: https://github.com/OfficeDev/VBA-content/blob/master/Outlook-VBA/articles/560bb264-05d0-dbc6-39c2-b95b12f50ed9.md
Also hosted on msdn: https://msdn.microsoft.com/en-us/library/bb206733.aspx
I produced following code, placed in ThisOutlookSession:
Dim WithEvents myOlBar As Outlook.OutlookBarPane

Private Sub Application_NewMail()
    MsgBox "New mail"
End Sub
Private Sub myOlBar_BeforeNavigate(ByVal Shortcut As OutlookBarShortcut, Cancel As Boolean)
    MsgBox Shortcut.Name
End Sub

Private Sub Application_Startup()
 Set myOlBar = Application.ActiveExplorer.Panes(1)
End Sub

I enabled macros:

I confirmed that I allow macros after outlook restart:

Still I get no effect whatsoever. However if I put some debug code in application startup callback, it works - I can print Hello world on startup:
Private Sub Application_Startup()
   MsgBox "Hello world!"
End Sub

So why is startup the only callback that works?

Thanks for your comment. You can use GitHub to make changes and additions to the VBA documentation, but for issues with your code we suggest that you post your question on one of these forums.
https://social.msdn.microsoft.com/Forums/office/en-US/home?forum=outlookdev
http://stackoverflow.com/questions/tagged/outlook


Make the slug draft prefix check consistent, and DRY

Checking for a prefix of "draft" could lead to false positives or inconsistent results between dev and prod.
I also took the opportunity to move the draft-checking logic to its own utility function.
No hurry on this. Made the PR against typescript branch.

@markjaquith Just seeing this. Have had terrible terrible 2g-3g for the past 10 days. Had already done a major reactor and am too whooped to figure out how to resolve the conflicts. Will ship this on the typescript branch. Gotta merge to master to get a beta release out. Thanks for this.


NuGet YAML task documentation confusion

The doc on the NuGet task YAML is a bit confusing. I've forked and begun some modification to that document to clarify how to use it.
Before any questions, if what I want to work on is not needed, no worries, let me know and I'll step back. Simply want to offer help where I can.

Is there a contribution guide?  Do I need to contact Douge Erickson, if so how?
What elements of Markdown are available to use (github flavor, etc?)
What I'd want to do is to use the name of the YAML inputs as the values in the 'Argument' column and provide a description that is more relevant to the YAML usage. Right now it's mostly in reference to what you'd do in the GUI.

@steved0x or @elbatk can one of you answer 1 and 2? I think a PR is sufficient for 1 but one of them can confirm.

sounds great, thanks for the contribution!

Hi @davidroberts63 , I think I have some answers for ya:

Contributor Guide
You can use the GitHub flavored superset of Markdown, there is a couple of articles on Markdown in the contributor guide, just search "markdown" in the search bar above the table of contents. Here is the main page on markdown for convenience.

Thanks in advance for your contribution!

Gonna go ahead and close this and I look forward to seeing a PR from ya 👍

Sounds good to me. Just a note. @elbatk those links are giving a 403. I tried via my corporate login as well as a personal (Microsoft account) login. I'll go forward using the GitHub flavored superset.


Integrate unit test run report on AppVeyor

AppVeyor supports integration with test frameworks as described at https://www.appveyor.com/docs/running-tests/.
Implement submission of unit test results to it, probably using Catch2 JUnit reporter or event CTest output to JUnit conversion as described at https://help.appveyor.com/discussions/suggestions/5298-support-ctest-xml-test-results.

Implemented (successfully) on commit cba9b5035445f97bcaceb100ade8a089c0411f58.
Problems with the JUnit XML report generation was solved by calling the test binary directly, without CTest as the CLI option --test-command was not working as expected.


CI/CD npm package added in #466

We should build the kthcloud-types npm package in GitHub Actions so it always matches with the go-deploy types.

Hmm seems https://github.com/kthcloud/go-deploy/commit/c1870e930d49ac42c99e372c23832b2aa25f8fc4 got us further but still some access error. Maybe a new token could help

Published to https://www.npmjs.com/package/go-deploy-types?activeTab=readme
Using GitHub action .github/workflows/npm-package.yml


How to set solid color as Backgrounds !

Just wondering how can i set a background solid color.
I want this feature on initialize and also after initializing the user can pick from a predefined list of colors.

backgroundCss in https://github.com/carstenschaefer/DrawerJs/wiki/Appearance
Is not this what you want??

I am trying to use it like this while initializing the Drawer JS
is that the right way?
and if i want to change the background after init how would i do that ?
new DrawerJs.Drawer(null, {
        plugins: drawerPlugins,
        backgroundCss: 'url(' + globalURL + '/' + 'web/images/blue.png) repeat',
...MORE CODE HERE
})


Command Line Interface for gentropy steps

As a user I want be able to run gentropy commands after it's installation from pipy by command line interface. Moreover I want to be able to run full gwas catalog processing steps as a single pipeline because it will make it easier to run the gentropy steps in orchestration layer.
Background
The issues arise when one want to create a DAG with a big number of conditional logic. In that context it is easier to wrap multiple gentropy steps with some combination logic in between them. For instance - adding the QC branching to trigger different fine mapping step execution.
The overall concept to to create a CLI command that will wrap the existing gentropy steps that are required to run in gwas_catalog_harmonisation, gwas_catalog_curation and gwas_catalog_processing dags, so the command may be pushed as a single google batch task.
Things to consider:

how to report if one of the steps has failed
how to keep the state of the pipeline execution (in case of a failure in one of the tasks we should be able to force restart whole job or just continue, provided we changed the machine type for the batch execution)
how to preserve the non-specificity of the separate steps when we can not overwrite hydra configuration (move away from hydra to a native CLI library)

These are a few libraries that might be used

click
typer
cyclops

The advantage over the hydra:

cli has the help message with all possible flags and required arguments
cli can be structured by the commands
No error is thrown on missing arguments, just a nice message explaining what is missing

The overrige syntax for the non-specific options can be provided as group options (for instance the spark sessions extended config)
Tasks

[ ] Create a step that wraps the gwas catalog processing steps into a single executable (if feasable)
[ ] Experiment and decide which cli tool may be a better solution to the native command line

Acceptance tests
How do we know the task is complete?

When gentropy steps can be run without need to overwrite the configuration steps

This issue is most likely out of scope for now. We could benefit for other CLI library, but that will be a sibstantial refactoring of the gentropy and orchestration configurations. The main issues I can find right now with the current CLi are:

Run gentropy with the step specified without the step=variant_index flag should not result in the cryptic error as below. This should clearly state that the reaseon of failure is not providing the flag in a correct way.

(base) ☁  gentropy [dev] poetry run gentropy variant_index
Error parsing override 'variant_index'
missing EQUAL at '<EOF>'
See https://hydra.cc/docs/1.2/advanced/override_grammar/basic for details

Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace.

Running without proper parameter setup also results in error that may not be understand if the user did not use hydra before. The exact issue is buried inside the stack trace, - Missing mandatory value: step.vep_output_json_path this should be exposed as an issue that user faces directly.

(base) ☁  gentropy [dev] poetry run gentropy step=variant_index
step:
  session:
    start_hail: false
    write_mode: errorifexists
    spark_uri: local[*]
    hail_home: /Users/ss60/Public/projects/gentropy/.venv/lib/python3.10/site-packages/hail
    extended_spark_conf: {}
    _target_: gentropy.common.session.Session
  vep_output_json_path: ???
  variant_index_path: ???
  gnomad_variant_annotations_path: null
  hash_threshold: 300
  _target_: gentropy.variant_index.VariantIndexStep
datasets: {}

Setting default log level to "WARN".
To adjust logging level use sc.setLogLevel(newLevel). For SparkR, use setLogLevel(newLevel).
24/09/24 09:35:19 WARN NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
Error executing job with overrides: ['step=variant_index']
Traceback (most recent call last):
  File "/Users/ss60/Public/projects/gentropy/src/gentropy/cli.py", line 22, in main
    instantiate(cfg.step)
  File "/Users/ss60/Public/projects/gentropy/.venv/lib/python3.10/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 226, in instantiate
    return instantiate_node(
  File "/Users/ss60/Public/projects/gentropy/.venv/lib/python3.10/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 340, in instantiate_node
    value = node[key]
omegaconf.errors.MissingMandatoryValue: Missing mandatory value: step.vep_output_json_path
    full_key: step.vep_output_json_path
    reference_type=StepConfig
    object_type=VariantIndexConfig

Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace.
[2024-09-24 09:35:22,618][py4j.clientserver][INFO] - Closing down clientserver connection

The other minor thing is that, without consulting the documentation we do not get clear view on what parameters should be passed to the step directly and in what way they should be passed as well. This could be a typical example how to run the step that displays when the gentropy --help is provided as a parameter. Insead we are getting
(base) ☁  gentropy [dev] poetry run gentropy --help
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/ss60/Public/projects/gentropy/.venv/lib/python3.10/site-packages/hydra/main.py", line 94, in decorated_main
    _run_hydra(
  File "/Users/ss60/Public/projects/gentropy/.venv/lib/python3.10/site-packages/hydra/_internal/utils.py", line 363, in _run_hydra
    hydra.app_help(config_name=config_name, args_parser=args_parser, args=args)
  File "/Users/ss60/Public/projects/gentropy/.venv/lib/python3.10/site-packages/hydra/_internal/hydra.py", line 356, in app_help
    cfg = self.compose_config(
  File "/Users/ss60/Public/projects/gentropy/.venv/lib/python3.10/site-packages/hydra/_internal/hydra.py", line 594, in compose_config
    cfg = self.config_loader.load_configuration(
  File "/Users/ss60/Public/projects/gentropy/.venv/lib/python3.10/site-packages/hydra/_internal/config_loader_impl.py", line 142, in load_configuration
    return self._load_configuration_impl(
  File "/Users/ss60/Public/projects/gentropy/.venv/lib/python3.10/site-packages/hydra/_internal/config_loader_impl.py", line 253, in _load_configuration_impl
    defaults_list = create_defaults_list(
  File "/Users/ss60/Public/projects/gentropy/.venv/lib/python3.10/site-packages/hydra/_internal/defaults_list.py", line 745, in create_defaults_list
    defaults, tree = _create_defaults_list(
  File "/Users/ss60/Public/projects/gentropy/.venv/lib/python3.10/site-packages/hydra/_internal/defaults_list.py", line 715, in _create_defaults_list
    defaults_tree = _create_defaults_tree(
  File "/Users/ss60/Public/projects/gentropy/.venv/lib/python3.10/site-packages/hydra/_internal/defaults_list.py", line 356, in _create_defaults_tree
    ret = _create_defaults_tree_impl(
  File "/Users/ss60/Public/projects/gentropy/.venv/lib/python3.10/site-packages/hydra/_internal/defaults_list.py", line 457, in _create_defaults_tree_impl
    return _expand_virtual_root(repo, root, overrides, skip_missing)
  File "/Users/ss60/Public/projects/gentropy/.venv/lib/python3.10/site-packages/hydra/_internal/defaults_list.py", line 280, in _expand_virtual_root
    subtree = _create_defaults_tree_impl(
  File "/Users/ss60/Public/projects/gentropy/.venv/lib/python3.10/site-packages/hydra/_internal/defaults_list.py", line 573, in _create_defaults_tree_impl
    add_child(children, new_root)
  File "/Users/ss60/Public/projects/gentropy/.venv/lib/python3.10/site-packages/hydra/_internal/defaults_list.py", line 520, in add_child
    subtree_ = _create_defaults_tree_impl(
  File "/Users/ss60/Public/projects/gentropy/.venv/lib/python3.10/site-packages/hydra/_internal/defaults_list.py", line 477, in _create_defaults_tree_impl
    if _check_not_missing(repo=repo, default=parent, skip_missing=skip_missing):
  File "/Users/ss60/Public/projects/gentropy/.venv/lib/python3.10/site-packages/hydra/_internal/defaults_list.py", line 322, in _check_not_missing
    raise ConfigCompositionException(msg + opt_list)
hydra.errors.ConfigCompositionException: You must specify 'step', e.g, step=<OPTION>
Available options:
	colocalisation
	credible_set_validation
	eqtl_catalogue
	finngen_finemapping_ingestion
	finngen_studies
	finngen_ukb_meta_ingestion
	gene_index
	gnomad_variants
	gwas_catalog_ingestion
	gwas_catalog_study_curation
	gwas_catalog_study_inclusion
	gwas_catalog_sumstat_preprocess
	ld_based_clumping
	ld_index
	locus_breaker_clumping
	locus_to_gene
	pics
	study_validation
	summary_statistics_qc
	susie_finemapping
	ukb_ppp_eur_sumstat_preprocess
	variant_index
	variant_to_gene
	variant_to_vcf
	window_based_clumping

I had some checks on how to allow a bit more verbose command line with Hydra, the issue I have bumped into is that we specifically require to pass the step=xxx flag, otherwise the command will allways fail with stacktrace.
I would like to park this issue, as it is not crucial for the upcomming release.
Development and testing done under branch
@d0choa what do you think?

I agree. I think pushing hydra to resolve the CLI task is not the best idea. Now it's not the best time to perform this refactor, but it's a nice one to come back once everything else is a bit more clear.
The intention is already a Won't for December. I think it could also be ok to close the ticket as it doesn't add a massive context apart from "we want to change this." We could open a better ticket when the time comes


Fix Firestore and coverage

Currently fails with [!] Requested test spec unitdoes not exist in the podspec. Existing test specs are[]``
See https://github.com/firebase/firebase-ios-sdk/runs/1865898590?check_suite_focus=true

#7497 fixes the test breakage. Coverage and Firestore still needs to be set up


Add Query type

Start refactoring to_sql, to support Tables

Unfortunately this creates large diffs in the snapshots because of the additional indentation


Prepare for the merge maintenance task

Add a prepare for the merge maintenance task with everything to be ready for the merge. Starts with Prater.

This is for existing setup that wants to move to a prepared setup.

Completed for Ubuntu!

Depends on #72

Completed on Windows with the recents commits.


Backtick issue we should fix

Check out this TODO

So this is pretty much the same problem as: https://github.com/ploomber/jupysql/issues/386
it can be fixed by making is_use_backtick_template an instance method

yes, I updated https://github.com/ploomber/jupysql/issues/386


pkg/archive/diff.go: avoid redundant options init

- What I did
I've removed one redundant initialization of TarOptions. It was already initialized above.
- How I did it
I've deleted three lines of code.
- How to verify it
The code above already initializes TarOptions. There's nothing which resets it to make it nil again.
- Description for the changelog
pkg/archive/diff.go: avoid redundant options init

LGTM


fix(sec): upgrade torch to 1.13.1

What happened？
There are 1 security vulnerabilities found in torch 1.12.0.

CVE-2022-45907

What did I do？
Upgrade torch from 1.12.0 to 1.13.1 for vulnerability fix.
What did you expect to happen？
Clean out the insecure libs to used.
The specification of the pull request
PR Specification from OSCS

remind me after tests pass

Run Inference Benchmarks

How to do it? @AnandInguva

This is a security vulnerabilitie fix. Do we need to do the benchmarks?

No, it is not. I thought you included torch benchmark tests but after reviewing, these tests weren't part of that suite. So, you can ignore the benchmarks comment.

OK.

How to do it? @AnandInguva

FYI Anand's comment was a command to the bot.

@AnandInguva will postcommit tests exercise this change?

@AnandInguva will postcommit tests exercise this change?

Unfortunately, no. There are no tests for these examples. I thought there were but I am wrong


[WIP] Add case study that records configs used to explore encoder optimizations

Each case_studies/optimize_encoder_727/exp_*  folder is meant to be used as the --config-path argument to the bliss executable program, with minimal command-line overrides, like so:
bliss --config-path case_studies/optimize_encoder_727/exp_pretrain [--multirun]

I'm closing this PR because we aren't planning to merge it, but instead to keep it to help with #727.


Closing app while synchronization is happening causes future app launches to start synchronization at January 2014.  This takes hours!

I've tested this out three or four times now.  I'll let the app spend 2 hours or so to synchronize.  Even after synchronization, it still takes 5 or 10 seconds everytime I open the app to let it synchronize with the latest blocks.  If I close the app during this 5 to 10 second window, the next time the app is launched synchronization will start from January 2014, which takes 2 hours or so.
I've tried deleting the app and re-installing, I've tried deleting the wallets and re-adding, the same issue keeps happening with Bitcoin and Bitcoin Cash wallets.
I have a few transactions from between 1 and 3 years ago, nothing recent, not sure if that affects anything.
iOS 13.2.3, BRD 3.17.3 Build 2

Closing - outdated. Please use<EMAIL_ADDRESS>for future bug reports.

Closing - outdated. Please use<EMAIL_ADDRESS>for future bug reports.


Disable CR implicit init

@julianrubisch I ended up needing to cut this release as a hotfix without the implicit CableReady initialization. The problem was twofold.

The Elements lib had a bug that was double registering event delegates, but I identified and fixed this bug after the devtools was extracted into it's own lib.
The Devtools lib had a bug that implicitly initialized the CR devtools regardless of environment. I needed to disable that so I could ship the other fix.

I have some ideas on how to refactor for explicit initialization for CableReady devtools, but didn't have time to implement over the short term.


meta-virtualization: Currency merge with upstream kirkstone branch

This is the 2023Q4.2 currency merge with upstream kirkstone branch
There were no merge conflicts and no additional NI-specific patches are required.
AB#2484331
Testing

[x] bitbake packagefeed-ni-core
[x] bitbake packagegroup-ni-desirable

@ni/rtos

These commits should have gone in last time I did upstream merge. But for some reason I didn't put up changes in meta-virtualization, bitbake, meta-security, meta-sdr, meta-qt5, meta-rauc for review.
I wonder if I misunderstood the output of upstream_merge.sh script.. thinking "OK" means no changes (ironically I wrote the script) and only put up changes for layers that had "ERRORS" (meta-openembedded, openembedded-core, pyrex) after resolving them. Oops, sorry about that!

These commits should have gone in last time I did upstream merge. But for some reason I didn't put up changes in meta-virtualization, bitbake, meta-security, meta-sdr, meta-qt5, meta-rauc for review.
I wonder if I misunderstood the output of upstream_merge.sh script.. thinking "OK" means no changes (ironically I wrote the script) and only put up changes for layers that had "ERRORS" (meta-openembedded, openembedded-core, pyrex) after resolving them. Oops, sorry about that!

Ha, very possibly! Nice this about these merges is we can always get them again next month :)


doc examples for expressions aren't useful

Some of the doc examples for expressions aren't really useful because they just build up the model. Need to find some sample data and show the effects.
For example:
https://github.com/Netflix/atlas/wiki/Stack-Language-Reference#div

Initial update of reference done:

Broken up with one page per operation.
Showing before / after as part of table now.

Example from original comment:
https://github.com/Netflix/atlas/wiki/math-div


Community-Maintained Version of mordred

mordred is important to many cheminformatics tasks but is no longer being maintained. I have made a fork of mordred called mordred-community and am happy to review and merge PRs to make this work again!

"That's a fantastic idea! I'm glad you're taking the lead on this.

Will you add the issues tracker and discussions page on your fork?

Just did, thanks for the suggestion @TUstudents

Thanks for fixing the issue with recent numpy versions, so I do not even need to write a bug report :)
As you created the pypi  package, basically the road is open to have a conda version (custom channel) too?

Yes, I will get it on conda shortly. I'd like to get it on conda-forge as well.

If anyone sees this in the future, mordredcommunity is now available via conda-forge.


Add gaia hd_path as example to registry.yaml

I'm doing some testing of the new ibc-go changes with the ts-relayer and I'm using this neat tool to manage my gaia nodes. It relies on the gaiad testnet command which will generate keys using the SDK fundraiser path. I'm new to BIP 39 vs BIP 44 so it took me some digging through the code to figure out how to set the hd path correctly.
I think it'd be useful to add the fund raiser hd path as an example to the registry.yaml. Maybe something like this?
# the path we use to derive the private key from the mnemonic
hd_path: m/44'/108'/0'/1'
# default test keyring hd_path for the SDK
# hd_path: m/44'/118'/0'/0/0

I'm happy to open a pr. I'm also a bit fuzzy on the exact technical wording to be used here

I wonder why m/44'/108'/0'/1' was even chosen here. It looks like a mistake.
Regarding

default test keyring hd_path for the SDK

and

SDK fundraiser path

I think it is important that this path solely belongs to ATOM and the Cosmos Hub. Other chains use it as well but this is an unresolved problem. Let's start making it explicit that this is the CosmosHub path.

Fair enough. We could add cosmos hub (or cosmos hub testnet) with the standard derivation path.
I assume you have the mnemonic.

I just threw in some varying hd paths for the different chains that had nothing to do with gaiad or other Go CLI tools. Just to ensure we had unique addresses.
I didn't think we would share the relayer mnemonic with any user accounts and just use it in our codebase and I wanted to explicitly keep them different.

I just threw in some varying hd paths for the different chains that had nothing to do with gaiad or other Go CLI tools. Just to ensure we had unique addresses.

Makes total sense. Could this be added as a comment?

Sweet, thanks for the responses. This reasoning makes sense to me. To summarize, maybe adding something like?
# Note: The hd paths shown have no meaningful relationship to the existing chains.
# It is recommended practice to use a different hd_path than those commonly used for user accounts.

Mostly just want to add some hint for a user like myself who comes to the ts-relayer with an incomplete understanding of hd_paths


Use on private repositories

I followed the instructions in https://github.com/astropy/astropy-bot#install-the-bot-in-a-repository and set the bot to run on all my projects, public and private. The bot works great on public repos, but does nothing on private ones. Is this a bug, or inherent to the bot?

You might want to ask GitHub help desk. GitHub imposes some restrictions on private repos. AFAIK, we have never tried to deploy this bot on a private repo and have no plans to.

Thanks! I'll look into that. The bot has been super helpful in forcing me to use a change-log. I want to make that mandatory across all my repos.

@nstarman , any update from GitHub? If there is nothing we need to do here, please close the issue. Thanks!


[0.13.x] Networking Version Updates

Reasoning
This updates the versions of the networking components to their latest. There is actually a bug in Typha version 3.6.1 and Callico Node 3.6.1 which can end up causing service disruption if there is a problem with the Kubernetes apiserver.
If Typha is under stress it attempts to write a glog message to a mounted tmp dir, or at least that’s the expected behaviour of release 3.6.1.
However, if that tmp dir does not exist (it does not in kube-aws) then Typha bombs out ( https://github.com/projectcalico/typha/issues/196) and causes network connectivity to drop.
Changes

Bumps patch version of networking components from .1 to .3 so fix for tmp dir issue is resolved.

Codecov Report

Merging #1749 into v0.13.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           v0.13.x    #1749   +/-   ##
========================================
  Coverage    25.28%   25.28%
========================================
  Files           98       98
  Lines         5087     5087
========================================
  Hits          1286     1286
  Misses        3659     3659
  Partials       142      142

Impacted Files
Coverage Δ

pkg/api/cluster.go
0% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c919e...77ee435. Read the comment docs.

/lgtm


infoWindow for markers

Hi,
I have another idea to make this plugin work better.
There is a property of InfoWindow in Google Maps API. It could be integrated into markers - it shouldn't be a problem, since there is already a marker function in code, and it only needs infoWindow object.

Can you precise how this would be exposed at the API level? We are using https://github.com/tomchentw/react-google-maps

Sorry,
I don't know what API this should implement. I was only thinking about using existing API, like this:
infoWindow: {
                content : 'Here goes text'
            }

Do you think it's possible?

The best way is to actually try it I am sure its feasible: clone the repo, npm install, npm run dev then hack around and see how to pass this option to react-google-maps. Should not be that hard.
Let me know

This would be perfect. I've been trying to get the markers clickable with no luck just yet.

Hi,
I have tried to develop this feature, but it's buggy.
https://github.com/jdrzejb/instantsearch-googlemaps
Here is my fork. Could you check it out?

That's awesome work, I am having a look right now, thanks.

I am adding more commits and polishing the interface, again thanks for awesome kickstart I will get back to you very soon


upgrade-assistant project build errors

Summary
I think there's a race condition that is sometimes creating compile time errors during the project build process.
Motivation and goals
I want to solve these challenges:

When I make a change to a file in a class library (e.g. DuplicateReferenceAnalyzer). I see that I can no longer hit a debugger break point because the code I'm debugging isn't the code that's running.

In some cases this results in projects failing to build. Clean all from the sln level. Then build the solution and you will get build errors. Build it again, and you'll get fewer build errors, or even success!

In scope

After a 1st time checkout of the project I can start the app.
Mysterious build errors are resolved.

Examples
CSC : error CS0006: Metadata file 'D:\workspace\_work\1\s\artifacts\bin\Microsoft.DotNet.UpgradeAssistant.Extensions.Default.CodeFixes\Release\netstandard2.0\Microsoft.DotNet.UpgradeAssistant.Extensions.Default.CodeFixes.dll' could not be found [D:\workspace\_work\1\s\src\steps\Microsoft.DotNet.UpgradeAssistant.Steps.Source\Microsoft.DotNet.UpgradeAssistant.Steps.Source.csproj]

Hmm I'll take a look at this. For now, rebuilding the solution will work.


How to expose vpp init function parameters in forwarder-vpp?

To twerk some configuraton parameters for AF_PACKET and AF_XDP some parameters should be exposed. The following should be considered:
1/ Add environment variables to container of cmd-forwarder-vpp. There are ten possible parameters.
2/ An other way is to define a configuration file and process the initiation with the given values. An example can be found in PR #1027
Any suggestion is welcome.

I think we may start with option 2 and provide this file via configmap mounting.
/cc @edwarnicke @glazychev-art


loading of extra settings now works with VAGRANT_CWD

If you booted up the VM from another directory using VAGRANT_CWD the virtual cluster would not start.

Thank you @rhpvorderman!


fix(package.json): upgrade logseq sdk

This improves loading time.

Hey! I added some new features and hence dependencies got updated. Thanks!


Should we be using Sprites for game objects?

Basic explanation:
https://stackoverflow.com/questions/41986383/pygame-what-is-the-difference-between-an-image-and-a-sprite
Official documentation:
https://www.pygame.org/docs/ref/sprite.html#pygame.sprite.Sprite
https://www.pygame.org/docs/tut/SpriteIntro.html
Example with a player and bullets:
http://programarcadegames.com/python_examples/f.php?file=bullets.py
It's a built-in pygame module for game objects. Did not even really realize it was a thing. Might be unnecessary, but could be worth looking into if there are any advantages
Found an animation example that uses sprites:
https://stackoverflow.com/questions/14044147/animated-sprite-from-few-images
Might be relevant to #12 and #15

I'm going to try my hand at converting to sprites. wish me luck lol

@chwerth take a look at this. it shows how collision works with sprites, as well as groups
http://programarcadegames.com/python_examples/f.php?file=sprite_collect_blocks.py

here's the full tutorial http://programarcadegames.com/index.php?chapter=introduction_to_sprites

That's probably much simpler than what I was doing. Cool. If we did that, would likely need to refactor projectile a bit. It just exists as a radius and a position, which we use to draw circles. That's why the intersects function works

we'll need to refactor a lot I think lol. I'm working through a test file to make sure I have a full grasp on how to manipulate Sprites, and then I'll continue working on the sprite-conversion branch i made

You are on a roll today lol


PR: Change convention and refactor icons on the code analysis pane

Description of Changes

[ ] Wrote at least one-line docstrings (for any new functions)
[ ] Added unit test(s) covering the changes (if testable)

[x] Included a screenshot or animation (if affecting the UI, see Licecap)

Change convention and refactor icons on the code analysis pane.

Issue(s) Resolved

Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
Juanis2112

Hello @juanis2112! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/utils/icon_manager.py:

Line 282:63: E231 missing whitespace after ':'
Line 282:80: E501 line too long (108 > 79 characters)
Line 283:63: E231 missing whitespace after ':'
Line 283:80: E501 line too long (108 > 79 characters)

@juanis2112, thanks a lot for your quick response about this!
@CAM-Gerlach, could you explain the reason behind your suggestions?

@ccordoba12 Just fixing the PEP8 issue with no space after the : that PEP8Speaks complained about. All the other lines had a space there so it made sense to fix it here since the line was being touched per the standard policy, whereas I didn't break the line length to fix the other PEP8 because that would be inconsistent with the rest of the code block since they were all one line and lots of others were >80 characters so it makes sense to just keep it.


fix(deps): update terraform terraform-ibm-modules/kms-all-inclusive/ibm to v4.15.9

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/kms-all-inclusive/ibm (source)
module
patch
4.15.2 -> 4.15.9

Release Notes

terraform-ibm-modules/terraform-ibm-kms-all-inclusive (terraform-ibm-modules/kms-all-inclusive/ibm)
v4.15.9
Compare Source
Bug Fixes

deps: update terraform ibm to latest for the deployable architecture solution (#534) (0a1d8da)

v4.15.8
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/key-protect/ibm to v2.8.4 (#538) (ab0a0f4)

v4.15.7
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/cbr/ibm to v1.24.0 (#535) (f93cff7)

v4.15.6
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/key-protect/ibm to v2.8.3 (#531) (96e6976)

v4.15.5
Compare Source
Bug Fixes

deps: update terraform-module (#529) (3c4ba65)

v4.15.4
Compare Source
Bug Fixes

deps: update terraform ibm to latest for the deployable architecture solution (#528) (2daf902)

v4.15.3
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/cbr/ibm to v1.23.3 (#526) (4e57041)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

:tada: This issue has been resolved in version 3.17.2 :tada:
The release is available on:

GitHub release
v3.17.2

Your semantic-release bot :package::rocket:


get_external_config seems not to read config from $HADOOP_HOME/etc

In the source code here:
https://github.com/spotify/snakebite/blob/6a456e6100b0c1be66cc1f7f9d7f50494f369da3/snakebite/config.py#L133
get_external_conf actually doesn't read core-site.xml or hdfs-site.xml from $HADOOP_HOME/etc.
But in hdfs_try_paths here, snakebite says it tried.

Sorry, I didn't notice that snakebite is using HADOOP_CONF_HOME too.
My HADOOP_CONF_HOME is set to $HADOOP_HOME/etc/hadoop, which makes me think snakebite is reading $HADOOP/etc.
Since snakebite is using HADOOP_CONF_HOME to find hdfs-site.xml and core-site.xml, I think it would be better to have that in the document.
I created another issue to cover this: https://github.com/spotify/snakebite/issues/241


v0.2.0 release

Pull Request Test Coverage Report for Build 8d660569c40e741a44c5a7f25e31b5af60bcaa84-PR-43

86 of 86 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 100.0%

Totals

Change from base Build f8513aab704a119bca57674347a61117cf0c77fc:
0.3%

Covered Lines:
302

Relevant Lines:
302

💛  - Coveralls


Three typos

(p212) In last sentence of 10-2 answer, "deterministic dropout" should be "random dropout".
(p217) In first and last sentences of 20-2 answer, "stateful retraining" should be "stateful training".
(p208) In last line, "example per class" is better than "example per image".
Thanks! :)

Thanks again, Haesun! This is an amazing attention to detail. I added these to the errata.


feat: made encodeServiceUrl a property that can be set via properties

Checklist

[x] the individual contributor license agreement is signed
[x] commit message follows commit guidelines
[x] documentation is changed or added

Description of change

Follow up to #1822 where encodeServiceUrl has been made into a property (cas.ticketValidationFilter.encodeServiceUrl) that can be set from uPortal.properties

/cc @allanjackson


enable more retained rendering opportunities for LeaderLayer

alwaysNeedsAddToScene is now false in all cases for LeaderLayer (follow-up to https://github.com/flutter/flutter/pull/92598, which made it false in only some cases).
Also:

Simplifies the LeaderLayer / FollowerLayer implementation
Reintroduces LayerLink.leader, that was removed in https://github.com/flutter/flutter/pull/92598, but proved to be pretty popular (see https://github.com/flutter/flutter/pull/96451).

Sorry to bumping this pull request. But I cannot find the commit in any branch of flutter repository. I wonder if anything goes wrong.


Pedestrian crossing

I'm missing this sign:

source: https://commons.wikimedia.org/wiki/File:Nederlands_verkeersbord_J22.svg
there is this one, but it has a different meaning:

source: https://commons.wikimedia.org/wiki/File:Nederlands_verkeersbord_L2.svg

if no-one beats me to it I can have ago at this like wednesday or so


Nextcloud Plugin

Error PHP Undefined index: REQUEST_URI at /home/getddo/public_html/apps/onlyoffice/appinfo/application.php#65
I getting this error with cron

Hello @emresaracoglu!
The issue has already been discussed https://github.com/ONLYOFFICE/onlyoffice-owncloud/issues/12
Commits are already included in the branch develop. In the next release they will appear in master.


[TS migration] Migrate 'ReportActionItem.js' component to TypeScript

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/31982
Tests

Start a chat
Send a message
Add Emoji
Edit message
Create a thread
Delete message
Send money request
Edit it
Assign task
Edit task
Complete it

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Start a chat
Send a message
Add Emoji
Edit message
Create a thread
Delete message
Send money request
Edit it
Assign task
Edit task
Complete it

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/25230417/af279c60-a8db-43dd-b412-aa2f96b0e7fc

Android: mWeb Chrome
https://github.com/Expensify/App/assets/25230417/33d49f5d-b5af-497b-88fd-453b67cbc003

iOS: Native
https://github.com/Expensify/App/assets/25230417/61773709-b460-497e-829a-25a8ba0c0c1c

iOS: mWeb Safari
https://github.com/Expensify/App/assets/25230417/c8d457a1-ab05-47fa-b234-f831f65cfce5

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/25230417/2a2a8c35-8518-4cd7-8536-46d40c17771c

MacOS: Desktop
https://github.com/Expensify/App/assets/25230417/93c1332c-a65f-45ae-986c-28136dcb5695

@fabioh8010 comments resolved!

Conflicts. Can we please resolve them before the weekend starts?

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@allroundexperts conflicts resolved

@allroundexperts kind bump

@rushatgabhane will be taking this over!

@rushatgabhane kind bump 😄

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Tests were passing.

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.49-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Tests were passing.

@luacmartins I just got caught off guard by the same thing in another PR, they were also not passing here 😬

I did not see that before the merge

Same in my other PR 😕

This PR is causing this regression https://github.com/Expensify/App/issues/38049

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.50-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Commented on the issue

@rushatgabhane are you due compensation here? If so, is it 50% cuz of https://github.com/Expensify/App/pull/34487#issuecomment-1988765386?

@rushatgabhane , if you're due compensation, please comment on the issue, otherwise I'll close next week. Thx


Start one server with multiple connection instead of multiple servers

https://github.com/indieforger/assimilator/releases/tag/v0.5.0


Ensure kluster domain is project domain

Fixes https://github.com/sapcc/kubernikus/issues/529

Thanks a lot.
Can you also remove the "domain" label here?
https://github.com/sapcc/kubernikus/blob/master/pkg/api/handlers/create_cluster.go#L141
Maybe change the creator annotation instead to fmt.Sprintf("%s/%s", principal.Name, principal.Domain)

@databus23 changes pushed


GitHub Actions usage

Add a warning for private repositories concerning the amount of build minutes consumed by new projects.
Discussed in https://github.com/cookiejar/cookietemple/discussions/726

Originally posted by foarsitter June 25, 2021
First of all, thanks for the effort you you all have put in to this!
Within minutes I was up and running with all the bells and whistles a developer can wish but within minutes I was out of those minutes GitHub gave me for free.
I made the mistake to create a private repository with the template. Switching to a public repo was fine for this project but a private project will soon get an expensive one I guess.
What are your thoughts about this?
Of course this are the costs of modern developments but I wasn't expect to burn my 2000 minutes in a little more of 2 hours.

I am still thinking about restricting the CI & nox to only a single Python version.
Thoughts @Imipenem ?

Fine with me, I mean during development, if there are any crucial differences for a project concerning different python versions, one would just customize it anyway to fit their needs.
For our templates we could also think about cookiecutter it like if it's a public repo use python 3.x AND 3.y and if not, just python 3.x


Atom Dark Theme

Added an Atom Dark Theme based on https://github.com/atom/atom-dark-syntax. I will let you format the screenshot and README with author info the way you like.

Thanks!


rename_column throw warning when column not found

I (finally) had an opportunity to use pyjanitor today! 😃 I ran into the unexpected behavior...
I used rename_column but had a typo in my first argument (the original column name). Instead of throwing a warning or error when the column wasn't found, pyjanitor continued the cleaning chain and returned a "partially-cleaned" DataFrame. It wasn't until later in my analysis that I realized the new column name didn't exist.
I would expect pyjanitor to throw a warning or error in this case. I could also see this being a deliberate design choice. For example, a user may use the same logic to clean various datasets that  share some column names but not others. In that case, they might want pyjanitor to ignore columns not found.
Was this a deliberate choice? Or should rename_column throw an error when the column is not found (thus, also catching typos from sloppy coders like me along the way 😉)?

@Zsailer I think you caught a bug! Great catch! Let me see what I can do here. I'll loop back soon!

👍
I'm happy to make a PR too, if you've got a lot on your plate.


Run test suite under Worker contexts

It'd be great to run all the same document tests under a worker context as well.
QUnit is a bit of a let down for making this happen. I'd be open to other test runners assuming its simpler overall.
Testing Service Worker context may be interesting too. I'm not sure how many differences there would be from a generic web worker context. fetch is at least enabled by default for SW when it might not be for a regular worker.
/cc @dgraham @matthew-andrews @domenic @knowledgecode

Shouldn't fetch already be defined in the Service Worker context?  (or would this be a test to check that the polyfill doesn't enable itself in SW?  If it's to run this test suite in SW then I think that's a useful thing to have but probably out of scope of this library?)
A little Googling suggests that phantom js supports web workers though: https://github.com/ariya/phantomjs/issues/10257
At FT we use Mocha, Karma & Chai and they're a massive improvement from buster but not used qunit so not sure how it compares.

Shouldn't fetch already be defined in the Service Worker context?

Yeah, that validates that are test suite actually matches the real implementation.


Make integration tests faster

This pull request adds the following new functionality:

On the http /write endpoint, we now return a header for X-InfluxDB-Index which is the current index after the write.  This can then be used for the /wait/:index endpoint in testing prior to moving forward, instead of artificially sleeping.

Changed the wait endpoint to have no default timeout (max int64 duration for now).  This takes away any guess work needed on how long the wait endpoint should actually wait.

Local results took the cmd/influxd package from 24s to 17s.  We should now be able to start performance tuning with the test suite in the current state.

+1


feat(quantic): add detailed reporter for Cypress tests

https://coveord.atlassian.net/browse/SFINT-4157
This PR adds a custom reporter to Cypress allowing to produce more detailed reports.
In order to produce a richer report, we first need to bring more context into the tests. To do so, we use the scope function to precise a test section. The scopes can also be nested.
it('should work as expected', () => {
  // visit the page
  scope('when loading the page', () => {
    Expect.displayPrevious(true);
  });
});

We should precise expectations as well, to do so, we use the logDetail custom Cypress command.
displayPrevious: (display: boolean) => {
  selector
    .previous()
    .should(display ? 'exist' : 'not.exist')
    .logDetail(`${should(display} display the 'previous' button`);
}

For example, see the report for the pager tests.

compared to the default spec report

What's missing?

make the IPC channel work on Windows

Nice job Luc!


Unable to parse date

I am getting this format from some service
"2016-02-23 11:31:23 AM"
How can I parse it?? it says this is not supported format or something like that, is there a way I can set this valid format somewhere?
Or, lets say we did not have AM or PM, how can you tell this date is AM or PM?

How can I parse it?

You need to tell Moment the format:
> moment("2016-02-23 11:31:23 AM", "YYYY-MM-DD hh:mm:ss A", true).format()
'2016-02-23T11:31:23-05:00'

Or, lets say we did not have AM or PM, how can you tell this date is AM or PM?

Meaning it's in 24-hour time?
> moment("2016-02-23 20:31:23", "YYYY-MM-DD HH:mm:ss", true).hour() > 12
true

Note the "HH" instead of the "hh". If you don't know whether it's in 24-hour time or 12-hour time with an AM/PM, just pass both:
> isPM = function(s){return moment(s, ["YYYY-MM-DD HH:mm:ss", "YYYY-MM-DD hh:mm:ss A"], true).hour() > 12;};
[Function]
> isPM("2016-02-23 11:31:23 PM")
true
> isPM("2016-02-23 20:31:23")
true

@icambron  - minor note related to this. The format being passed here will, on the current version of moment, match ISO 8601 in error:
moment('2016-02-23 11:31:23 PM').format() = "2016-02-23T11:31:23-06:00"
This is because 2016-02-23 11:31:23 by itself technically is ISO 8601.
Do we consider this a bug, or just an unavoidable collision?
It seems like even if in general we ignore extra tokens if not in strict mode, the library would work more correctly if we looked for a meridiem indicator and fell back to js date if we found it.

The thing is that using this approach I have to pass in the possible format every time, I need to set it like once, globally, so that every single call to moment() uses that format.

@maggiepint I agree; we should make the is-this-iso check in the one-arg constructor stricter.
@Daxito Why not abstract it into a function and call that function instead of moment() directly?

@icambron , yes, I can do that, thank you!


Scrutinizer Auto-Fixes

@jarednova requested this pull request.
It consists of patches automatically generated for this project on Scrutinizer:
https://scrutinizer-ci.com/g/timber/timber/

Coverage remained the same at 94.061% when pulling 95c6cb894d2b3596203654d39973f39f35864faf on scrutinizer-patch-1 into 5e7fc990fd04cf9f688335e588f6426a3c735eeb on master.

Coverage remained the same at 94.061% when pulling 95c6cb894d2b3596203654d39973f39f35864faf on scrutinizer-patch-1 into 5e7fc990fd04cf9f688335e588f6426a3c735eeb on master.


Migrate to Rxjs 6.3

Currently this doesnt work with rxjs6.3 and rx-compat 6.3

Yeah, It's currently built for the angular less than 6.
I was thinking about migrating it to Angular 6 or higher to support rx-js > 6.
I'll try to add it on a weekend.


Pertubations and fault isolation

Just a question in relation to fault pertubations for the example cases being run, and more generally?  I noted that for Example 2 a three phase fault is applied, which results in a voltage degradation.  What are the transient assumptions around fault clearing in this example?  Is there a critical cleaning time that is assumed?  More broadly is the package able to simulate fault clearing?
Many thanks
Farhad

Currently, the faults are modeled as line trips only. We haven't implemented a short circuit with clearance times sorry. We can label this as a feature request

@fnbillimoria see https://github.com/Energy-MAC/LITS.jl/issues/35