add support xxl-job

Please answer these questions before submitting pull request

Why submit this pull request?

[ ] Bug fix

[ ] New feature provided

[x] Improve performance

Related issues

Bug fix

Bug description.

How to fix?

New feature or improvement

Describe the details and related test reports.
add skywalking support xxl-job like elastic-job

You need to submit test case to here https://github.com/SkyAPMTest/agent-auto-integration-testcases
You could find the document there too.

I suggest implementing the cron expression job on the tracking the xxl server to deliver the task to the client.

You need to submit test case to here https://github.com/SkyAPMTest/agent-auto-integration-testcases
You could find the document there too.

the xxl-job like elastic-job and the test case may be difficult to make

I suggest implementing the cron expression job on the tracking the xxl server to deliver the task to the client.

the server to client use http and the client run job in new thread and it is not work

Coverage increased (+0.03%) to 16.038% when pulling 08d88d1029483e448612e7b066ef02b378b05333 on IAMTJW:branch-xxljob into d862bbb4ed5a7887ff3b943e95b109ec084fccc4 on apache:master.

the xxl-job like elastic-job and the test case may be difficult to make

Could you use a HTTP request to trigger a job execution? If YES, then test still works.

When you are ready, please ping me or @ascrutae

When you are ready, please ping me or @ascrutae

I am ready and What should I do next

@ascrutae Please review the plugin and test case(https://github.com/SkyAPMTest/agent-auto-integration-testcases/pull/62), if everything looks right, please submit the integration test in our INFRA.

@IAMTJW Please update this PR to fix CI.

You need to solve conflict. Another plugin merged today.

Basically, I need you to explain the plugin design. I am a little confused about what you are trying to do here.

When RPC happens, which plugins work for tracing? Such as, Tomcat? HttpClient? Or something else?
If the local span of handler is the only thing created, then what is the key point to add this plugin? Is this plugin just playing the simplest role, which is adding a span in an existing trace, but not related to any metrics of service or topology map.

Basically, I need you to explain the plugin design. I am a little confused about what you are trying to do here.

When RPC happens, which plugins work for tracing? Such as, Tomcat? HttpClient? Or something else?
If the local span of handler is the only thing created, then what is the key point to add this plugin? Is this plugin just playing the simplest role, which is adding a span in an existing trace, but not related to any metrics of service or topology map.

Basically, I need you to explain the plugin design. I am a little confused about what you are trying to do here.

When RPC happens, which plugins work for tracing? Such as, Tomcat? HttpClient? Or something else?
If the local span of handler is the only thing created, then what is the key point to add this plugin? Is this plugin just playing the simplest role, which is adding a span in an existing trace, but not related to any metrics of service or topology map.

1、想通过这个插件知道调用链发起是由 xxl-job 服务产生的调用流程，类似elastic-job
2、xxl-job 有服务的 admin 和 客户端两部分组成，任务的调用时通过 服务端 通过 JettyClient（http ）rpc调用来触发 客户端执行的。
3、xxl-job服务端 http 调用 客户端的过程中会触发与web相关的拦截器，但由于 xxl-job 客户端线程池执行服务，无法标记出调用链是由 xxl-job 发起的，并且xxl-job 服务端在部署的时候无法保证部署使用了 skywaling
插件出发点：类似 elastic-job，能标记出调用链是由 xxl-job 发起的

You need to translate the reply to English.

Basically, I need you to explain the plugin design. I am a little confused about what you are trying to do here.

When RPC happens, which plugins work for tracing? Such as, Tomcat? HttpClient? Or something else?
If the local span of handler is the only thing created, then what is the key point to add this plugin? Is this plugin just playing the simplest role, which is adding a span in an existing trace, but not related to any metrics of service or topology map.

Basically, I need you to explain the plugin design. I am a little confused about what you are trying to do here.

When RPC happens, which plugins work for tracing? Such as, Tomcat? HttpClient? Or something else?
If the local span of handler is the only thing created, then what is the key point to add this plugin? Is this plugin just playing the simplest role, which is adding a span in an existing trace, but not related to any metrics of service or topology map.

1、When RPC happens, the jetty plugin work for tracing.
2、when the xxl-job client is called , because of the client execute job with thread pool and intercept IJobHandler to know the tracing from xxl-job like elastic-job

1、When RPC happens, the jetty plugin work for tracing.
2、when the xxl-job client is called , because of the client execute job with thread pool and intercept IJobHandler to know the tracing from xxl-job like elastic-job

1、When RPC happens, the jetty plugin work for tracing.

If so, then no entry span required.

2、when the xxl-job client is called , because of the client execute job with thread pool and intercept IJobHandler to know the tracing from xxl-job like elastic-job

If there is a thread pool in there, you just added a local span, the trace will still break. The right thing is you make the trace continues by using Context#capture, Context#continued APIs.  Then you know the trace starts with a xxl-job server, and including all spans of your codes.

Without update in one week, will close soon

Be advised, RESTEasy plugin merged, conflict needs to be solved.

I am still not sure the result of this plugin, could you provide

Topology and trace when xxl server and xxl client under SkyWalking monitoring
Topology and trace when only xxl client under SkyWalking monitoring

1、Sorry，the xxl-job server call client with JettyHttpClient （and the new version remove it）and the skywalking not support jetty plugin.
2、If the xxl server not under the SkyWalking monitoring ContextManager.capture() may be NullPointerException

2、If the xxl server not under the SkyWalking monitoring ContextManager.capture() may be NullPointerException

This is not the factor. I think you misunderstand the API usage.


Add CPU architecture to task lib

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: migheorghe sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@migheorghe are you interested in reviving this? It looks useful, maybe we can do this returning an enum and use the Agent.OSArchitecture variable for checking instead though (see here for conversation on this).
I'm thinking something similar to this, but for architecture.

I'm going to close here for now. If you're interested in reviving this, comment and I'll reopen.


SVG images in header or footer don't respect pdfwidth attributes

I'm trying to put a logo in the header, which I have as a nice clean SVG. It works just fine with the pdfwidth attribute on the title page; logo_image: image:a-plus-logo.svg[pdfwidth=25%] gives me the expected output.
However, any sizing directives I try to give it for the one in the header or footer just get ignored. The screenshot attached here is with content: image:a-plus-logo.svg[pdfwidth=10%], but I've also tried the scaledwidth and width attributes, and with different units specified (px and in). No matter what I do, the image stays the same size. I do have a workaround at the moment: I just use separate SVG files for different sizes. But that's not ideal, especially since it's a trial-and-error process to get the sizes right.
The pdfwidth attribute works as expected in the header/footer when the image is a PNG, but I'd much rather use a vector format in this case.

You're right. The svg method doesn't support the fit option (like for
raster images). As a result, the specified width is being ignored and the
SVG renders in the intrinsic size. I'll need to fix the options so the
width is honored.


Angular 13 - JS use strict errors

Which @angular/* package(s) are the source of the bug?
core
Is this a regression?
Yes
Description
Project details:

We have a piece of legacy Javascript code that in our project.
We have a .d.ts file that declares the namespace, classes, and methods available inside the JS code.
Up to Angular 12, we have not had any problems building and serving the JS code alongside the rest of our Angular project.
After following the steps here, we are seeing errors and oddities when the JS code is executed.
This is the first time we are seeing such issues.

Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
core.mjs:6484 ERROR Error: Uncaught (in promise): TypeError: Cannot set property layerMap of [object Object] which has only a getter
TypeError: Cannot set property layerMap of [object Object] which has only a getter

Please provide the environment you discovered this bug in (run ng version)
Angular CLI: 13.0.3
Node: 16.13.1
OS: Windows 10 Pro 19043.1348

Anything else?
It looks possible like use strict is being enforced on the JS code. Is there a way to disable this in Angular configuration?
Is there some other configuration change that will allow us to continue using the legacy code?

Duplicate of https://github.com/angular/angular-cli/issues/22159

@alan-agius4 Thanks for the redirect!


msvcp140d.dll is missing

I think the windows binaries weren't production builds.

Compiled with statically-linked libraries.


Redfish: Hostname tests

Test and automate

hostname verification
new hostname configuration on bmc

Code fixed by Dev https://github.com/openbmc/bmcweb/issues/44

This is automated and verified on latest master.
Closing this.


Too much padding on the sidebar

Creating a ticket because not sure if you would be reading #53 anymore (since you already marked it as resolved.If you happen to read #53 , please close this ticket
Theme Issue:

OS:Windows/Mac

Sublime Text version: 3109

Materialize version: Latest

Description of issue:
The original material theme has support for compact sidebar via
"material_theme_compact_sidebar" : true
option. Can you please provide support for this ? Please note the sidebar is not usable for me because its a bit too much "space" padded.

Screenshot of issue (if appropriate):

Thanks and Regards
Gagan

I was not aware that Material Theme had a "material_theme_compact_sidebar" : true feature. Working on this right now.

Thanks..

This feature has been added, your themes should update shortly. Please reopen the issue if there are any problems with the new material_theme_compact_sidebar feature.


--inspect-electron starts debugger, but does not pause at breakpoints (or debugger)

Using<EMAIL_ADDRESS>I'm seeing this with Chrome devtools/Node Inspector Manager. Is there an equivalent of node's --inspect-brk I can try?

These kinds of questions should really go to the slack channel or community discourse, we aren't a support team 😄

but does not pause at breakpoints

Where are you setting these breakpoints

--inspect-brk

You should be able to launch with --inspect-brk yourself

we aren't a support team

I definitely appreciate that, but this feature doesn't seem to work for debugging scripts which have an end point, as opposed to scripts which run on an ongoing basis and might later hit a breakpoint. Nor does electron-forge seem to have an equivalent to the node's --inspect-brk.
I looked through the docs and the [source code of the file that run the commands] (https://github.com/electron-userland/electron-forge/blob/master/packages/api/cli/src/electron-forge.ts) and the start command in particular: https://github.com/electron-userland/electron-forge/blob/master/packages/api/cli/src/electron-forge-start.ts & https://github.com/electron-userland/electron-forge/blob/master/packages/api/core/src/api/start.ts
With that in mind, I figured it's safe to assume that this is not something that is going to be answered anywhere but here, even if I wait quite a while. It seems to be feature which doesn't exist, but perhaps should. Unfortunately I don't see any way to emulate without forking the entire project. At least not so far. I can't decipher where the final command is run and peel it out to run it myself with --inspect-brk. Before resorting to that I tried:

yarn start --inspect-brk
yarn start --inspect-brk-electron
 node --inspect-brk<EMAIL_ADDRESS>start (Seemed promising, but inspects electron-forge itself and never hits any of my files)

Recommendation
I would recommend adding an additional inspect-brk-electron argument and duplicating these lines with minor modifications:
https://github.com/electron-userland/electron-forge/blob/master/packages/api/core/src/api/start.ts
Duplicate and modify to be:
if (inspectBrk) {
  args = ['--inspect-brk' as (string|number)].concat(args);
}

Assuming your "start" command is literally "electron-forge start" you want to run this
yarn start -- -- --inspect-brk

To explain this, the first "--" passes arguments through from yarn to forge, the second "--" tells forge to pass all following arguments through from forge to electron.

Damn! I tried one set of -- but didn't think to try two. Should have clicked when my other attempt resulted in debugging of electron-forge instead of my code. Thanks very much for setting me right.


Feature/pn 139 ensure unique device tokens

Coverage increased (+0.3%) to 67.228% when pulling 49237b6f3cb15ae8478247c708d7691d66610b8f on feature/PN-139-Ensure-unique-device-tokens into 384ebe1b32fd4f75d0fb78512a394a040b7b8edc on master.

Changes Unknown when pulling 131918ad91080329f4d9c2e33ec2199535e81335 on feature/PN-139-Ensure-unique-device-tokens into ** on master**.


Bug: Edge Type "quadradic" does not follow a symmetrical curve

G6 Version: 3.4.9
Platform: Mac Chrome
Screenshot:

CodeSandbox Link: https://codesandbox.io/s/magical-wilbur-zgzx3?file=/index.js
Steps to reproduce:

Create an edge with type 'quadradic' with a curveOffset > 0.

Expected Result:
A quadratic curve whose apex is equidistant from each endpoint.
Actual Result:
The apex of the curve is biased towards one endpoint.

Thanks, we have located the problem and it will be solved next in version 3.4.10.

Fixed by v3.4.10.


++[Direct~TV]* Taylor vs Serrano Live Fight Free On Tv Channel 15 Nov 2024

MMA Junkie is on the scene and reporting live from Friday’s Netflix boxing event headlined by Jake Paul vs. Mike Tyson.
Taylor vs Serrano Live
Taylor vs Serrano Live
The action gets underway on Netflix at 8 p.m. ET. The full fight card with odds and complete viewing information is listed below. Where to watch ...
Mike Tyson vs. Jake Paul fight start time: Where to watch, live stream online, fight card, Netflix price
Jake Paul vs. Mike Tyson will air worldwide on Netflix. There is no way to watch the event for free without a Netflix account. Netflix doesn't currently offer a free trial to new subscribers. The company stopped offering free trials in the U.S. and it doesn't seem likely to bring them back anytime soon.
The good news is while the event will require you to have an active Netflix account, there is no extra PPV cost for the fight or event and you'll be able to watch it on-demand after the conclusion of the event.
Jake Paul vs. Mike Tyson start time
Date: Friday, November 15
Time: 8 p.m. ET | 5 p.m. PT | 1 a.m. BST | 11 a.m. AEDT (Saturday)
Main event start time (approx.): 11:15 p.m. ET | 8:15 p.m. PT | 4 a.m. BST | 2 p.m. AEDT
Location: AT&T Stadium - Arlington, Texas
Jake Paul vs. Mike Tyson airs on November 15 in AT&T Stadium, home of the Dallas Cowboys. The main card starts at 8 p.m. ET. The main event should begin around 11:15 p.m. ET, depending on how long the undercard fights last.
The Jake Paul vs. Mike Tyson live stream online will feature some of the early action from the anticipated Paul vs. Tyson fight card Saturday afternoon.
The Paul vs. Perry live stream will begin at 5:30 p.m. ET, and this portion of the card is as follows:
Shadasia Green vs. Melinda Watpool
Lucas Bahdi vs. Armando Casamonica
Shu Shu Carrington Jr. vs. Dana Coolwell
After the Paul vs. Tyson prelims, the action will be on Netflix for the four-fight free showcase starting at 8 p.m. ET at the AT&T Stadium in Arlington, Texas.
In the main event, Jake Paul will aim for his fight straight victory when he squares off former heavyweight champion Mike Tyson, who will fight professionally for the first time in almost 20 years. Tyson, who hasn’t fought in almost four years in an exhibition, is 58 years old.
Amanda Serrano will also square off against Katie Taylor in a rematch in the co-main event. Taylor beat Serrano via split decision in their previous meeting on April 30, 2022.
Join us for the Mike Tyson vs. Jake Paul main card LIVE below.


29.02 cell cast to 29.020000000000003 string

Steps to reproduce
See the Excel file decimal-numbers.xlsx. It contains a column with two decimals:

Decimals

28.14

29.02

Read the Excel file using fastexcel:
read_excel("decimal-numbers.xlsx").load_sheet_by_name("Sheet1").to_polars()

shape: (2, 1)
┌──────────┐
│ Decimals │
│ ---      │
│ f64      │
╞══════════╡
│ 28.14    │
│ 29.02    │
└──────────┘

Looks fine.
Then read the Excel file while casting to strings:
read_excel("decimal-numbers.xlsx").load_sheet_by_name("Sheet1", dtypes={0: 'string'}).to_polars()

shape: (2, 1)
┌────────────────────┐
│ Decimals           │
│ ---                │
│ str                │
╞════════════════════╡
│ 28.14              │
│ 29.020000000000003 │
└────────────────────┘

The expected result was that the strings would be the same as shown to the user in the Excel file:
shape: (2, 1)
┌──────────┐
│ Decimals │
│ ---      │
│ str      │
╞══════════╡
│ 28.14    │
│ 29.02    │
└──────────┘

Wrap-up
I understand this looks like an issue due to floating point precision, and I'm not sure if this:

could be fixed in fastexcel
could be fixed in the underlying calamine.
cannot be fixed at all, since it's a fundamental property of the Excel file format or parsing process.

What's the motivation for filing this bug: In our system, we have highly heterogeneous data, so we have to read all Excel values as strings. However, if users see 29.02 in their Excel files, but 29.020000000000003 in our system, that's highly confusing and surprising to users.
What do you think?

Hello @severinh
Always great to have a clear bug issue with file and clear explanation thank you!
I checked quickly and indeed it feels hard to fix on fastexcel side
In src/data.rs, in create_string_array function we simply do
cell.as_string()

Even with
cell.get_float().map(|v| v.to_string())

or
cell.as_f64()

we get the same and AFAIK there is no way for us to get more info on the original input.
I'll try to dig on calamine side tonight

The floating point number in the Excel file is 29.020000000000003:
    <row r="2" spans="1:1" x14ac:dyDescent="0.2">
      <c r="A2" s="1">
        <v>28.14</v>
      </c>
    </row>
    <row r="3" spans="1:1" x14ac:dyDescent="0.2">
      <c r="A3" s="1">
        <v>29.020000000000003</v>
      </c>
    </row>

For the display (and storage) of floating point numbers Excel uses something very similar to the printf() format option %.16G:
$ python
>>> print("%.16G" % 29.020000000000003)
29.02

That format option isn't supported by Rust in std::fmt however.

Thanks @jmcnamara indeed it's really in the xml content itself.
Maybe we should switch to decimal representation when parsing the xml content
With
[dependencies]
rust_decimal = { version = "1.36.0", default-features = false }

use rust_decimal::prelude::*;

fn main() {
    let x = 29.020000000000003_f64;
    println!("x: {}", Decimal::from_f64(x).unwrap());
}

▶ cargo r -q
x: 29.02

WDYT?

For the display (and storage) of floating point numbers Excel uses something very similar to the printf() format option %.16G:

I was wrong about this for the display part. Excel displays decimal numbers with 8 digits in a standard cell width and 10 digits in a wide cell. Like this:

Format = 0.000000000
Unformatted, wide cell
Unformatted, standard width

1.123456789
1.123456789
1.123457

12.123456789
12.12345679
12.12346

123.123456789
123.1234568
123.1235

1234.123456789
1234.123457
1234.123

12345.123456789
12345.12346
12345.12

123456.123456789
123456.1235
123456.1

Again thank you for the info. Much appreciated.
I reckon we should make a PR on calamine side. I can maybe do that this weekend

Huge thanks for the deep investigation into this issue, @PrettyWood and @jmcnamara! Learned a lot from reading this discussion.
I would trust you to make the right decisions if and where this should be changed. I also hope that this won't have any negative impact on other users of calamine and fastexcel (such as performance).

We chose to support it directly in fastexcel for now. It should have very little impact because it's only applied for float to string conversion


AKS: Fix the roles to be included for Elastic SAN before installing Azure Container Storage

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command

General Guidelines

[ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[ ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
[ ] My extension version conforms to the Extension version schema

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Thank you for your contribution! We will review the pull request and get back to you soon.

Live tests queued:

test_aks_create_with_azurecontainerstorage
test_aks_update_with_azurecontainerstorage

Live tests queued:

test_aks_create_with_azurecontainerstorage
test_aks_update_with_azurecontainerstorage

One of the scenario tests test_aks_update_with_azurecontainerstorage failed for reasons unrelated to this change and will be fixed in #7512.


[Feature Request] Preview images saved in a GitHub private repo in a JSDoc comment

The preview of the image works for publically available images

https://github.com/microsoft/vscode/issues/55484

So if I had a JSDoc comment,
/**
 * `![image](https://user-images.githubusercontent.com/12345678/123456789-12345678-1234-1234-1234-123456789012.png)`
 */
const myFn = () => {}

and I hovered over myFn, I would see the image in the preview
However, now when you upload an image into a GitHub private repo's PR, issue or comment, it can only be accessed if you have permission.
I would be nice to be able to view private images in a JSDoc comment.

I'd love to know if anyone has workarounds!
One workaround I can think of is to paste the image on a public repo

it can only be accessed if you have permission

This is due to how GitHub hosts images--they "belong to" that private repository rather than just being globally accessible user data. I don't think this is something that we would address in VS Code, thus closing as out of scope.


Board Review: Azure.Gaming.PlayFab C# client

Contacts and Timeline

Responsible service team:
Azure Gaming Services (AGS)

Main contacts:
jasonsa; andmcc

Expected release date:
Add to PlayFab private preview release soon, ship as public preview in Q1 2023, GA release in Q3 2023

About the Service

Link to documentation introducing/describing the service:
https://playfab.com/

Link to the service REST APIs:
APIs migrated to Azure so far: https://review.docs.microsoft.com/en-us/rest/api/playfab-rest-api-docs-pr/?branch=main
Full set of legacy AWS based PlayFab APIs: https://docs.microsoft.com/en-us/rest/api/playfab/client/?view=playfab-rest

Link to GitHub issue for previous review sessions, if applicable:
Intro meeting: https://github.com/Azure/azure-rest-api-specs-pr/issues/6491

About the client library

Name of the client library:
Azure.Gaming.PlayFab

Languages for this review:
C# & Javascript only.  Other tier 1 languages (Java, Python) in progress

Artifacts required (per language)
.NET

APIView Link:
https://apiview.dev/Assemblies/Review/641137e6ee074d36b72fe14db61aab0d

Link to Champion Scenarios/Quickstart samples:

See https://github.com/Azure/azure-sdk-for-net-pr/tree/feature/playfab-dataplane/sdk/playfab/Azure.Gaming.PlayFab#examples for examples with code snippets.
During private preview, we're only offering a limited set of features. More services and features will be added along the way.
JavaScript

APIView Link:
https://apiview.dev/Assemblies/Review/188b078cea014eb392ba10cdda95c9cf

Scheduled for 7/21 2p-4p PDT

Recording (MS INTERNAL ONLY)


BC Sandbox API

Hey freddy, don't know if this is the correct repository but I'm a bit confused by the Business Central API(s). So my goal is to deploy configurationPackages in sandbox containers. The microsoft docs only show how to do that with production tenants or demo tenants, not how to do it on docker. Is this by design or have I just not found the documentation I need?
So far I've accomplished to get the companyInformation using this url and basic auth:
https://{myPublishedContainer}:7048/nav/api/v1.0/companyInformation?company=CRONUS DE
To do this I also had to use the actual password of the user, not the Web Service Access Key which intrigued me a little.
I feel like I am doing something very wrong, please let me know if that is the case.

Hi @MaxBelohoubek
You can use web service access key for on prem.
GET http://{container}:7048/bc/api/v1.0/$metadata
GET http://{container}:7048/bc/api/v1.0/items
GET http://{container}:7048/bc/api/microsoft/automation/v1.0/$metadata
GET http://{container}:7048/bc/api/microsoft/automation/v1.0/configurationPackages
When prompted for credentials you can use the BC username and web access key.
If you're just trying through the browser, you could also try a tool like Postman. Choose Basic Auth, use the web access key as password.
/Henrik

Hey @henrikwh,
thanks for your help. Now I can get the configurationPackage which is what I need.
The problem I have now is that the WebService Access Key is rejected, no matter which client I use (PowerShell / Postman) to send the request.
Only using the password for the user (SUPER permissions) is accepted when sending a request with Basic Auth. I also have to specify the company (which is CRONUS DE in my case).
Is this expected behaviour?

hi @MaxBelohoubek
No, this is not normal. I think you web access key might be wrong. Please ensure that it ends with an = sign.
Sometimes the cut&past does not get the full key.

It was wrong. Copy&Paste excluded the last character. Thanks so much!


Adding R Runner Custom Step

Added new custom step for running R from SAS Studio

Please include answers to these questions as part of your pull request
In the GitHub webUI, use the Write tab to modify the Markdown text that is part of the pull request. For each question simply place an X inside the square brackets, [X], that represents your answer. Make sure there are no blanks inside the brackets, otherwise MarkDown doesn't render properly. Using the Preview tab while editing this form, you can see the formatted/rendered version of the message.

Q1: Confirm that you have the right to submit the code that is being contributed. Please consider the origin of your code and confirm you have the appropriate rights to make the submission subject to the Apache 2.0 license that applies to everything in this repository of custom steps. If so, follow the instructions for the Contributor Agreement (which is based on the industry-standard Developer Certificate of Origin (DCO)).

[X] Yes, I have the right to submit the contributed code on behalf of myself, my company, or any other owner of the code. I have also attached my signed copy of the DCO to this message.
[ ] No

Q2: Confirm that your contribution does not include any personally identifiable information (PII), for example, in any examples used in your README file.

[X] My contribution does NOT include PII data
[ ] My contribution includes PII data

Q3: Confirm your contribution does not include any encryption or other export-controlled technology.

[X] My contribution does NOT contain encryption or other export-controlled technology
[ ] My contribution includes encryption or other export-controlled technology
ContributorAgreement.txt

ContributorAgreement.txt
Just to be on the safe side, attaching a separate Contributor Agreement with my name on the file.  (name was included in earlier C.A)

SAS Internal Due Diligence Review - COMPLETED on 25AUG2023


Disable bluetoothd instructions

Can you provide more instructions on how to disable bluetoothd according to this line:
https://github.com/sandeepmistry/bleno/commit/ef572ec86e8790e5f8fa8cd00d197cd9b0a2b72b#diff-04c6e90faac2675aa89e2176d2eec7d8R23
I am experiencing many issues with my project after upgrading to Debian Jessie on a Raspberry Pi. Want to make sure that the installation and environment are set up correctly.

@bradfol I've added some notes in https://github.com/sandeepmistry/bleno/commit/9ee47c43cc961032a6897568504a3d0b07869f7a


Importing Sass partials that contain variants?

I'm having an issue generating custom class variants using @variants in Sass partials. I'm using Tailwind with Gatsby and building my CSS using the Tailwind CLI.
All variants (responsive, hover, focus) are generated if I include the entire @variant declaration in my main Sass file like this:
/* main.scss */
@variants responsive, hover, focus {
  .test {
    color: red;
  }
}

However, I'd prefer to put these declarations in Sass partials and import them. Unfortunately, neither of the following approaches generates the correct variant classes:
Include full declaration in sass partial and import it in main.scss
/* partial.scss */
@variants responsive, hover, focus {
  .test {
    color: red;
  }
}

/* main.scss */
@import 'utilities/partial.scss'

Include style declaration in sass partial and import it inside @variant declaration in main.scss
/* partial.scss */
.test {
  color: red;
}

/* main.scss */
@variants responsive, hover, focus {
  @import 'utilities/partial.scss'
}

Since I assume this is a common use case, I'd love to know what I'm doing wrong!

Normally PostCSS would run after Sass, so this should work. Is it possible that PostCSS runs before Sass in your setup?

That was it! Thanks very much.
I switched to processing Sass and PostCSS via their CLIs so I can make sure Sass to run first (I’m sure there’s a Webpack way, but it’s a little over my head). Tailwinds now generates variants for Sass imports as expected.


Fix to ensure specifying source-path does not download unwanted files

This PR fixes issue #37 .
The extractFiles function needed a very simple change to fix this issue. Since source-path specifies a folder, appending a "/" to pathPrefix variable makes sure that we download only files from within the folder specified in source-path.
I also added a zip file to test-fixtures folder which ensures that the test scenario specified in the issue description is tested.

@brikis98 thanks for your comments.
I agree that appending a literal "/" could be highly OS/platform dependent.
I will work on finding a solution based on your suggestion -  converting f.name and pathPrefix to canonical paths and comparing them.

Also wanted to respond to your comment about trailing slash being present in the --source-path arg.
In the line just above the line I added, the call to filepath.Join() removes any trailing slashes. I thought I would quickly mention.

I updated the code to what I believe handles all cases now.
I am using continue to skip specific cases in for loop instead of using a if check. I felt this resulted in simpler if conditions. I also retained the original indentation so that unmodified code does not show up in diff.
Please see the comments in code for an explanation how I check for each case.

Tests passed. Merging.

https://github.com/gruntwork-io/fetch/releases/tag/v0.3.7

Thanks!


Provide non-transparent toast notifications

The current toast notifications are always transparent, even when "max opacity" is set to 100 %:

IMHO, this doesn't follow the guidelines for material design:

The text in the first image isn't readable at all.
I'm not sure if this is a bug or a feature request, as I don't know how the toast option "max opacity" should work.
If "100 %" should create an in-transparent toast notification, then this seems to be a bug. Otherwise think of this as a feature request.
If this is by design, that toasts are transparent, and snackbars are non transparent, more documentation might be helpful to decide when to use which control. The toasts have more functionality than the snackbar.

agreed, the transparency animation is also kinda glitchy

I just ran into the same issue I would expect it to be non transparent. You use the following styling as a workaround:
.mat-toast-container > div {
    opacity: 1 !important;
}

I just ran into this as well. One solution I'd like to suggest is to expose a "transparency timeout". The notification would be shown with full opacity for the duration of the transparency timeout, then fade to the current default opacity until the user hovers over the notification. With this approach, a value of "0" in the transparency timeout would yield the current behavior while a value equal to or greater than the "visible duration" would result in a notification that is always 100% opaque.
I'm willing to explore this as a potential PR if you're interested. Great work, by the way!


Added Minput field to SubPods to read result of Format.Minput queries.

I have added the field "Minput" of type string to process the result of queries that have requested the Minput-Format.

Thanks!


Added strict typing checking

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 95.38462% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.76%. Comparing base (fc12626) to head (48810ff).

Files with missing lines
Patch %
Lines

denstream/utils.py
86.66%
2 Missing :warning:

denstream/den_stream.py
94.11%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   94.62%   94.76%   +0.14%
==========================================
  Files          11       12       +1
  Lines         781      803      +22
==========================================
+ Hits          739      761      +22
  Misses         42       42

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


XIVY-13253: Prevents display of error on new line in parameter table

To prevent errors when adding a new row to the parameter table, a default value is now added to the name.
I've named it "change_this_name" to signal that the name needs to be changed. If the name isn't changed and the component is reloaded or the selection is lost, the new row will be removed from the table. I haven't named it "parameter" because I can imagine that this name might often be forgotten to be updated.
What do you think?

It will remove it if the row has set Name: "change_this_name", Type: "String", Description: ""
Every Row that looks like this, will be removed, after reloading the component or when the selection is reset by pressing on the header:

ah the logic is the empty object. nice 👍


A test needs to be added to check that the correct data is in the header [3/4 Details component initial]

Looking forward for reporting a security issue:
Please report security issues by following our security policy: https://contribute.freecodecamp.org/#/security
Describe the bug
The Header component on the Details page should check to see that the correct data is being passed in. Specifically the student's name and the classroom name.

CodeDay mentees will be working on this.

I will be working on this!


Fix: Audit command schema not found fix

CS-43193

[x] Audit fix command schema not found fixes.
[x] Folder clean script fix on command completion.
[x] Modular blocks issue fixed in content type.

@antonyagustine , I have looked into this code base, comments are quite useful here. I have one suggestion is that we need to be mindful when it comes to adding comments, I could see some comments which can be avoided as it is very straight forward for anyone to understand it from the code since we are using a good standard for naming and using typescripts as well.
"The classic rule of thumb is:  Code tells you how and comments tell you why"

@antonyagustine , I have looked into this code base, comments are quite useful here. I have one suggestion is that we need to be mindful when it comes to adding comments, I could see some comments which can be avoided as it is very straight forward for anyone to understand it from the code since we are using a good standard for naming and using typescripts as well.
"The classic rule of thumb is: Code tells you how and comments tell you why"

Hi @shafeeqd959,
Thanks a lot for your suggestion, and I completely agree that "The classic rule of thumb is: Code tells you how and comments tell you why".
However, my code might not inherently produce documentation about its functionality, even if the functions are self-explanatory. That's where my comments come into play. We should consider this from a long-term perspective. Comments aren't solely for the developer to understand the function when they look at it.

Take, for example, someone trying to utilize my code. It should offer them a clear understanding of what the function is and what it does without needing to delve into the dist/node_module file (Like code editor/JS/TS intenseness).
In the future, we might require or decide to integrate a documentation generator with our CI for creating developer-friendly documentation. However, until that happens, it's not feasible to go back and add comments to all functions.

@shafeeqd959, I'd recommend always adding comments to any function you write, regardless of whether the code is exceptional, self-explanatory, or seemingly straightforward. It helps in various scenarios and promotes a better understanding for everyone involved.


7.0.0-preview.2 PSReadLine stops working after Get-Help or other commands

Overview
Certain (possibly just full-screen overlayed) commands or operations cause PSReadLine to stop working afterwards, and in some cases, for the console (process) to become completely unresponsive.
I have a reliable reproduction below, although it only reproduces one aspect of the problem I've surfaced (I don't have a reliable repro for the console becoming unresponsive).
Steps to reproduce
pwsh-preview -NoProfile
help Get-Alias
(press 'q' to quit)
(press Up-Arrow / Down-Arrow to cycle through history)

Expected behavior
History is cycled
Actual behavior
History is not cycled / input sometimes unresponsive
Environment data
Name                           Value
----                           -----
PSVersion                      7.0.0-preview.2
PSEdition                      Core
GitCommitId                    7.0.0-preview.2
OS                             Darwin 18.7.0 Darwin Kernel Version 18.7.0: Thu Jun 20 18:42:21 PDT 2019; root:xnu-4903.270.47~4/RELEASE_X86_64
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Strangely, I noticed that Get-Help Get-Alias works differently than help Get-Alias
help Get-Alias opens a multiple-line scrollable view of the help text, whereas Get-Help Get-Alias just dumps it out all at once on screen
So whatever the behavior is that does the fullscreen scrollable view (help Get-Alias) is what seems to break PSReadLine

I confirmed that help Get-Alias seems to open the help text for Get-Alias using linux less (confirmed since I can press h and see less help commands)
So something about how it's opening less is breaking PSReadLine ?

I also discovered that running a sub-instance of pwsh-preview from the 'broken' state, and then exiting that shell, fixes the issue.
e.g. after reproducing the above, then:
pwsh-preview
exit

allows the original pwsh-preview session to page up/down through history again

Confirmed that I can repro just by doing
echo "foo" | less

or
echo "foo" | more

from inside a pwsh-preview prompt


The section was deleted

It was. R.I.P. h meme

It's kinda a meme this pull request

Why is this still open?

#16 gets rid of the need for this pr

ae

game, it's in the sports


Merge AlwaysEncryptedHelperClasses, TdsParserHelperClasses

Contributes to #1261.
This merges AlwaysEncryptedHelperClasses.cs and TdsParserHelperClasses between .NET Framework and .NET Core. There are some lingering Framework-only and Core-only components, which I've added to .netfx.cs or .NetCoreApp.cs respectively.
This is a large PR - sorry in advance. Almost the entire reason why this is so large is that I pulled the two files into the coding standard as part of the merge process. There were a lot of internal fields here; the coding standard calls for them to have an _ prefix, and there are a lot of references to them.
I've tried to simplify this by splitting it out into various commits:

Split the classes in netcore's AlwaysEncryptedHelperClasses.cs into a corresponding file in the netfx project
Minor cleanup prior to merge of AEHC.cs - removing an unused field from netfx which wasn't present in the netcore projejct
Merge activity. Deleted the netfx AlwaysEncryptedHelperClasses.cs file, moved the netcore file into the root directory
First large change: all non-public fields in AEHC.cs prefixed with an underscore, internal classes marked as sealed where possible
Split netcore's and netfx's remaining TdsParserHelperClasses.cs files, pushing all non-common code into their corresponding TdsParserHelperClasses.NetCoreApp.cs and TdsParserHelperClasses.netfx.cs files
Merge activity, and syncing up a field name to make the netfx project compile (netcore had an underscore, netfx did not.) Internal classes marked as sealed where possible
Second large change: all non-public fields in TPHC.cs prefixed with an underscore
Mop-up: correcting two tests which used reflection to manually access fields

Commits 4 and 7 have the widest impact. I'm not sure whether they're the right things to do though. Most of the time, the classes and the fields are both internal. In that situation, I'm tempted to make the fields public (and keep the classes internal.) This would cut the PR size down, but not by much - we'd just end up updating references to baseTI to reference BaseTI rather than _baseTI.

@edwardneal Can you address the conflicts, please?

Thanks @DavoudEshtehari, I've completed the merge.
The PR touches a lot of files, and the majority of these changes come from the corrections to field names. I can strip this change out if that'll make the next PRs easier to merge.

@edwardneal A smaller code change would definitely be easier to review with less risk of missing something. I'd appreciate it if you could split them meaningfully and keep them small.

@DavoudEshtehari, that's definitely improved things - it's eliminated two thirds of the diff, and most of the remainder is the deletion of the .NET Framework's TdsParserHelperClasses.cs. I'll push the standardisation into a separate PR when the merge will be less painful.

@edwardneal thanks for your help on this - sorry it took so long to get  it addressed. I'm on the merge project, so hopefully we can move things along faster now.

Thanks @benrr101, that's great news. I've reached a stopping point for new merge PRs until November, so I've got bandwidth to keep up with reviews as they proceed.


Can go plugin has daos/schema structure just like LUA plugin?

I am trying to develop my plugins with GO, and wondering if go-plugins have ability to interactive with Kong's database/caches by using dao.lua / schema.lua just like what LUA does?
For example:
https://docs.konghq.com/gateway/latest/plugin-development/access-the-datastore/
https://github.com/Kong/kong/blob/master/kong/plugins/basic-auth/daos.lua
https://github.com/Kong/kong/blob/master/kong/plugins/basic-auth/schema.lua

You can connect to external databases, including Kong's, but the communication with the Kong process is limited to what the Go pdk exposes - https://pkg.go.dev/github.com/Kong/go-pdk. Example plugins can be seen at https://github.com/Kong/go-pdk/tree/master/examples


when giving input with space last character of input is repeat in place of space

for example, if the input is  "O  "  then the output is, O O.
in place of space, it repeats the last character of the input.
assign this issue to me I want to solve it.

@AnshumanMahato

@gaurav12devloper as you have multiple issues assigned to yourself. Work on them one at a time. Don't push all the issues in the same PR or make multiple PRs at the same time. It creates conflicts which are difficult to resolve.


Data transfer speed

DISCUSSION: is the expected downloading speed ~ 7MB/s?
Details
Hello!
I am transferring data from terraref data to a VM in Google Cloud, via Globus Python SDK. The downloading speed seems to be around 7M/s based on the Globus website. Could you please check if that's the expected transferring speed, or it should be much faster, but limited by some settings?
Thanks!
Hongxiao
Completion Criteria
Know the upper bound of data transferring limit.

Hi, not sure I can be of much help, but I'll do my best. It may also help to start an email thread with<EMAIL_ADDRESS>to try to track down the issue, with details like endpoint IDs and examples of tasks which ran slowly.
Before digging in too deeply, is this problem specific to Globus Transfers, or do tools like iperf show you similar throughput?
If you can confirm that the problem is Globus-specific, it may help to try tuning how aggressively your transfers use the network. If the endpoint(s) are Managed (you have a Globus subscription and have flagged one or both of them as managed), you can modify the network_use settings.
In the case of the SDK, you would call TransferClient.update_endpoint with a partial endpoint document to set some combination of network_use, min_concurrency, preferred_concurrency, min_parallelism, and preferred_parallelism.
Unless you have  very specific guesses about what's causing the slow transfer, stick to tuning network_use to its various settings, and don't set it to custom.

Thanks for the help!
When I upload those downloaded files to Google Cloud Storage, it can reach a speed > 100 MB/s. But I have not test the downloading side. Could you please let me know how to test it? Seems iperf needs to pair the server and client side.
Here I'm transferring data from terraref(I suspect it is a Globus subscription node?) to my own VM(which is not a subscription). So I think I can change neither of them.

@lhx-x I took a look at your current transfer that's running against the endpoint right now and I see the below:
{
"type": "GridFTP Transfer",
"concurrency": 1,
"protocol": "Mode S"
}
with the sync_level = 3
While an easy way to ensure only the data you need moved in a partially synced directory is moved, sync mode is not the fastest way to move the data and the sync level being 3 (going up to checksums to determine if file is a sync candidate) won't make this fast across the 10's of thousands of files.  If this is your first pull of the data especially,  it's going to be good to not use sync mode and do a normal transfer with parallelism and pipelining.  An example being right now the transfers between the Arizona site and NCSA are running at parallelism 4 and pipelining 10 and are close to saturating the 1Gb link (seeing ~110MB/s) at the AZ site.  The NCSA side is not network bandwidth or file systems constrained, with multiple GB/s available for both those things.
I am not very familiar with the Globus Python SDK so @sirosen may be of more help in terms of configuration flags, etc. to allow your transfer to go wider.
If you'd like to run an iperf test though to see what the theoretical max is to your cloud instance let me know and I'll fire up an iperf listening server on the DTN that you could test against.  Would be happy to do that too.  We'd want to schedule a time though as I don't want to leave it up and listening indefinitely.

@jdmaloney Thanks JD! Yes -- the sync mode really matters. I change it to 0 and the speed doubled to 14 at once :) Let's wait and see for a while, to check if that's the current upper bound. We may schedule a iperf test after that.

@lhx-x Indeed it appears to be going faster, DTN node is reporting speeds to your cloud instance fairly consistent around 15MB/s now, which is indeed much improved.  Up to nearly 1.2TB/day at that rate. The concurrency is also now running at 6, which should be helping you too.

Perhaps my expectations are too high, but 15M/s still sounds slow if max from laptop to VM is 100M/s.
If you want to investigate further with Globus personnel, a support ticket with task and endpoint details remains the best path.
It does make sense that setting the sync level to 3 ("checksum") would slow things down. Most likely, the bottleneck in that case was checksumming on the VM.
I would recommend setting the sync level to "exists" or "mtime" if you can. It tends to make scripted tasks faster/safer to rerun if they fail, and has typically negligible performance cost.

@sirosen Thanks Stephen! Here the 100M/s is from VM, uploading to GCS. Seems like the transferring speed from Globus is not stable: when I post this reply it is only 5M/s, with sync level = 0. I guess it would be helpful if we make a bandwidth test as @jdmaloney suggested.

Sorry not yet. @jdmaloney do you mind if we start a bandwidth test on this?

@lhx-x Is there a time this afternoon or tomorrow we could schedule the test?

@jdmaloney sure! How about 2:00 pm PDT? Feel free to change it if that's not work for you. Also could you please post the commands we will need?

@lhx-x Sorry for this, was preparing for a conference out of town and ran out of time.  This week is much more open, let me know what times work for you and we'll set this test up.  For commands, you'll want to have the iperf package installed.
Command will be: iperf -c <IP_ADDRESS>
Make sure you have port 5001 open on your host's firewall if it isn't open already.  That's the default port for iperf.  Once we have a time set up for the test, I'll make sure my host is listening over here.

@jdmaloney Thanks! No worry if you are not available at this time. I'll be ready in the next few days.

@lhx-x You still want to test this, my schedule is pretty open.  If you still want to just shoot me a time.

Stale issue, closing. Please open a new issue if work remains.


Only show one error at once

Fixes #2775

@paultag we're going to bump macos cores because it makes no sense for it to be taking this long


Godot don't support Greek Characters

Operating system or device - Godot version:
Linux - Ubuntu 16.04.1 - Godot : 2.1-stable
Issue description (what happened, and what was expected):
Am trying to make a Greek language game but Godot not showing the text. :|
Steps to reproduce:

Make any Control node with Text
Try to type in Greek

Link to minimal example project (optional but very welcome):

Do you have set a font with Greek characters?

does the text appear in the editor?
On Mon, Sep 5, 2016 at 8:09 PM, George Marques<EMAIL_ADDRESS>wrote:

Do you have set a font with Greek characters?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/6404#issuecomment-244820049,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z22QxQ48IigT2lMtM4VKCZE7pi7Alks5qnKE3gaJpZM4J1VY2
.

@vnen No i have not set a font.
@reduz The text does not appear.

I wonder if our DroidSans has greek.. it should have should it not?

@reduz According to FontSquirrel it does support the entire Greek alphabet. Being a former operating system UI typeface I would be surprised at its omission if there was one.
https://www.fontsquirrel.com/fonts/droid-sans

It appears in the inspector, but not on the control itself:

@reduz is DroidSans the default font for in-game controls too?

Any status on this issue?

This is not a bug, the default internal engine font is latin-only. If you
import a TTF or OTF with greek chars, they will display fine..
On Nov 29, 2016 10:39 AM, "Bojidar Marinov"<EMAIL_ADDRESS>wrote:

Any status on this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/6404#issuecomment-263572105,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z23d1kQMRS1lfdAxH3c9zJbL0snUzks5rDCsIgaJpZM4J1VY2
.

This is a little bit related to #8998, but need to be increased "default" exported engine file size.

First of all thank you for your report and sorry for the delay.
We released Godot 3.0 in January 2018 after 18 months of work, fixing many old issues either directly, or by obsoleting/replacing the features they were referring to.
We still have hundreds of issues whose relevance/reproducibility needs to be checked against the current stable version, and that's where you can help us.
Could you check if the issue that you described initially is still relevant/reproducible in Godot 3.0 or any newer version, and comment about it here?
For bug reports, please also make sure that the issue contains detailed steps to reproduce the bug and, if possible, a zipped project that can be used to reproduce it right away. This greatly speeds up debugging and bugfixing tasks for our contributors.
Our Bugsquad will review this issue more in-depth in 15 days, and potentially close it if its relevance could not be confirmed.
Thanks in advance.
Note: This message is being copy-pasted to many "stale" issues (90+ days without activity). It might happen that it is not meaningful for this specific issue or appears oblivious of the issue's context, if so please comment to notify the Bugsquad about it.

Godot's font supports Greek characters now (I think since Godot 2.1 at least).


Using the av-canvas module in electron to report an error

I use av-recorder and av-canvas modules in electron, av-recorder works fine, but av-canvas reports an error.
(1) The error is as follows

(2) The relevant codes are as follows
index.js.zip

Wait a minute, I will add the main field to the package.json

@Dragon-S  fixed by 0.1.26


怎么在自己的数据集上生成dense label map呢？

怎么在自己的数据集上生成dense label map呢？

Hi,
Assume you've got a pre-trained classifier like EfficientNet-B6 for your dataset, you can simply remove the final global average pooling layer (and may have to adjust the shape of the output feature map before you feed it to the classification head) to generate the dense label map.

If I save the feature vector of the picture as pt, how can I make the label of the small image correspond to the label of the whole image later?

This is automatically done during training.
https://github.com/zihangJiang/TokenLabeling/blob/aa438eff9b9fc2daa8c8b4cc6bfaa6e3721f995e/tlt/data/mixup.py#L27-L33
The label map will be cropped (according to the random crop box) and resized to the target shape.

Thank you
At 2021-06-18 10:57:01, "蒋子航" @.***> wrote:
This is automatically done during training.
https://github.com/zihangJiang/TokenLabeling/blob/aa438eff9b9fc2daa8c8b4cc6bfaa6e3721f995e/tlt/data/mixup.py#L27-L33
The label map will be cropped (according to the random crop box) and resized to the target shape.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

You can reopen this issue if you have any further questions.

Hi Zihang, thanks for your excellent work.
I'd like to ask how the score map are generated.
First we use a pretrained machine annotator like NFNet-F6, and as you say we remove the final global average pooling layer, we get the feature map of an input image. But how to transform the feature map to the dense score map, let's say 1000*patch_num for ImageNet? Sorry for my unfamiliarity with the NFNet-F6, will it automatically generate the patch label or there are some other technique to finish this?
Thanks for your reply.

Hi, Assume you've got a pre-trained classifier like EfficientNet-B6 for your dataset, you can simply remove the final global average pooling layer (and may have to adjust the shape of the output feature map before you feed it to the classification head) to generate the dense label map.

Hi Zihang @zihangJiang , thanks for your excellent work.
I'd like to ask how the score map are generated.
First we use a pretrained machine annotator like NFNet-F6, and as you say we remove the final global average pooling layer, we get the feature map of an input image. But how to transform the feature map to the dense score map, let's say 1000*patch_num for ImageNet? Sorry for my unfamiliarity with the NFNet-F6, will it automatically generate the patch label or there are some other technique to finish this?
Thanks for your reply.


Add Moo.do 1.0.6

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[x] Named the cask according to the token reference.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no open pull requests for the same cask.
[x] Checked the cask was not already refused in closed issues.
[x] Checked the cask is submitted to the correct repo.

Please fix the style errors.
== Casks/moodo.rb ==
C:  5:  3: github.com does not match moo.do, a comment has to be added above the url stanza. For details, see https://github.com/caskroom/homebrew-cask/blob/master/doc/cask_language_reference/stanzas/url.md#when-url-and-homepage-hostnames-differ-add-a-comment
C:  9: 12: 'https://www.moo.do' must have a slash after the domain.
C: 14: 19: Use 2 spaces for indentation in an array, relative to the position of the opening bracket.
C: 15: 19: Put a comma after the last item of a multiline array.
C: 19: 21: Use 2 spaces for indentation in an array, relative to the position of the opening bracket.
C: 25: 21: Put a comma after the last item of a multiline array.
C: 26: 22: Indent the right bracket the same as the left bracket.
C: 27:  1: Extra empty line detected at block body end.

@commitay seems like you fixed all the errors, is there anything left to do?


Merge GameObjects-UniqueID into scenemanagement

UniqueID.h I think that must be included in the GameObject.h file because if not, I can't use the UID declaration in the header. If you have any other solution that avoids including a header file in another header file lmk, if not, we have to include it.

My bad, well seen, thanks!


Link Code of Conduct

See this policy rule for more details.

It looks like this PR was created against master then submitted to release/3.1 (our default branch), so it was including more commits than intended. I've rebased to fix this and pushed to your branch.

Thanks @dagood!


Webpack compatibility

I am using Webpack to bundle my code for the later export to my server-less architecture. Unfortunately Google-Cloud does not seem to work with the Webpack workflow? Executing the from webpack produced bundle yields the error:
throw new Error("package.json does not exist at " + package_json_path);

Do to my research this is a problem with some Google Cloud dependencies:
https://github.com/GoogleCloudPlatform/google-cloud-node/issues/1821
https://github.com/grpc/grpc/issues/11435
and the source probably is the node-pre-gyp module:
https://github.com/mapbox/node-pre-gyp/issues/308
Environment details

OS: MacOS 10.13.2
Node.js version: v9.3.0
npm version: 5.6.0
dialogflow version: v2

Thanks!

Did you try to exclude it from webpack? Below configuration worked for me.
module.exports = {
...
externals: ['grpc','dialogflow'],
...
};

Greetings!  Webpack isn't currently supported, but it's something we would very much like to do.

This workaround helps https://github.com/serverless-heaven/serverless-webpack/issues/342

can we use this package on react-native?
right now we are using fetch directly like this https://github.com/innFactory/react-native-dialogflow/blob/master/js/Dialogflow_V2.js#L89
it'd be cool to have full support to react and react native

I got the same issue to use @google-cloud/pubsub.
So I use the cloud Pubsub REST API directory.
Why don't you do this?
// example
import { google } from "googleapis";
import axios from "axios";
const url = "https://pubsub.googleapis.com/v1/projects/${project_name}/topics/${topic_name}:publish";

async function main() {
  const token = await google.auth.getAccessToken();
  const data = { messages: [ { data: new Buffer("hogehoge").toString("base64") }]}
  const config = {
    headers: {
      "Content-Type": "application/json",
      Authorization: `Bearer ${token}`,
    },
  };
  return await axios.post(url, data, config);
}

main();

Is there any work around or fix available to use dialogflow in reactjs?

@ragu-swaminathan, we recently removed our dependency on grpc (which was a compiled dependency, and made running in reactjs a complete no-go); however, there's still some work to go before this library can easily be run in the browser.
This continues to be something we are working towards, but I don't believe there are any workarounds just yet.

@bcoe @JustinBeckwith is there a tracking issue we can ask users to subscribe to? Seems like this is applicable to all the nodejs clients.

@callmehiphop if one doesn't exist, let's create a tracking issue here:
https://github.com/googleapis/google-cloud-node
I agree it would be great to eventually provide a recipe for running in the browser.

https://github.com/googleapis/google-cloud-node/issues/2933 has been opened!


What is the role of MvRxLifecycleAwareObserver in MvRx?

I see this issuse #15, but I don't understand the specific reason. In the absence of MvRxLifecycleAwareObserver, if the state changes, the direct subscribe stateStore.observable should also deliver the new state. In my opinion, the role of MvRxLifecycleAwareObserver is in order to deliver the state after the Fragment/Activity is restarted, instead of delivering the state every time the stateStore.observable changes, reduce the unnecessary invalidate. If my understand is wroing, please correct me. Thank you.

@littleGnAl This is correct.   However, you certainly don't want updates being delivered to a screen when it isn't started. Not only would that not make sense but it could lead to crashes where there isn't even a view or a context.


font-feature-settings are not properly working with styled-components v5.0.0-rc.2

I use createGlobalStyle to include Inter var font and apply various font-feature-settings properties. With styled-component v4 everything works as expected, but after upgrading to v5 font-feature-settings are behaving oddly.
import { createGlobalStyle } from 'styled-components'
import { normalize } from 'polished'

export default createGlobalStyle`
  ${normalize()}

  @import url('https://rsms.me/inter/inter.css');

  html {
    font-family: ${({ theme }) => theme.fonts.defaultLegacy};
  }

  @supports (font-variation-settings: normal) {
    html {
      font-family: ${({ theme }) => theme.fonts.default};
      font-feature-settings: "tnum", "zero", "frac", "cpsp", "salt", "ss02";
    }
  }
`

Screenshots

v4 screenshot
v5 screenshot

Environment
## System:
 - OS: macOS Mojave 10.14.6
 - CPU: (4) x64 Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz
 - Memory: 155.12 MB / 16.00 GB
 - Shell: 5.3 - /bin/zsh
## Binaries:
 - Node: 11.14.0 - ~/.nvm/versions/node/v11.14.0/bin/node
 - Yarn: 1.19.2 - ~/.nvm/versions/node/v11.14.0/bin/yarn
 - npm: 6.11.3 - ~/.nvm/versions/node/v11.14.0/bin/npm
## npmPackages:
 - babel-plugin-styled-components: ^1.10.6 => 1.10.6
 - styled-components: ^5.0.0-rc.2 => 5.0.0-rc.2

@iamskok This seems like a bug with @import in createGlobalStyle as far as I'm aware of. Ran into this myself and there's an ongoing thread here about it: https://github.com/styled-components/styled-components/issues/2670
Also, if you look at the v4 vs v5 screenshots, you'll notice that everything after @import is not loaded correctly. Instead of loading Inter I believe the typeface in the v5 screenshot is San Francisco / -apple-system / BlinkMacSystemFont. I don't think this is a font-feature-settings issue.

Any chance you could provide a reproduction codesandbox?

I find out when I use "@supports" with v5, my global styles in dev build are missing, it may be related.

Can you provide a reproduction codesandbox?
On Thu, Jan 2, 2020 at 4:26 PM Jakub Valenta<EMAIL_ADDRESS>wrote:

I find out when I use "@supports https://github.com/supports" with v5,
my global styles in dev build are missing, it may be related.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/styled-components/styled-components/issues/2920?email_source=notifications&email_token=AAELFVSBUISDPNDLD4Y2LT3Q3ZLXHA5CNFSM4JXDHP3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH7PFDY#issuecomment-570356367,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAELFVXMQOJTBJ7U5TEHYX3Q3ZLXHANCNFSM4JXDHP3A
.

I was curious about this as well and made a codesandbox
https://codesandbox.io/s/nostalgic-sun-zi7lj
Does not seem to reproduce the bug.

@probablyup finally, we made a reproduction #2946

If it's the same bug as #2946, you can try out<EMAIL_ADDRESS>which includes the fix. It'll go out with rc4


It actually draws now.

It draws stuff, and you can even change the colour. What more could you ask for?????


ShowDialog forces ownership

Describe the bug
In WinForms and WPF, one can call ShowDialog() on a window instance without specifying the owner window. The new dialog is displayed on top of all the other opened windows of the application, which all become blocked until the dialog is closed.
To Reproduce
Call ShowDialog() on a window instance, without specifying a parent window as argument.
Expected behavior
As all the other UI frameworks work, a parent owner window should not be mandatory when displaying a dialog. This becomes important in situations like an abstract factory for views used in conjunction with a Dependency Injection system, when the DI system resolves a window from an interface, from a project that has no references to any view-related code, ie: business model in domain driven design. At the moment of using the abstract view factory to display a window, all info regarding window ownership is not available without adding a reference to Avalonia.Controls (where Window type is defined) or hacky workarounds.

As all the other UI frameworks work, a parent owner window should not be mandatory when displaying a dialog

As years pass modern desktops allow applications less and less control over the active window and focus. That causes application-modal dialogs to cause confusing interactions like some window being disabling for no apparent reason.
Even with desktops that do allow full control app-modal dialogs cause issues with multi-monitor configurations.
When dialog has a parent the desktop environment has explicit window stacking order and can act accordingly.
That's why we consider application-modal dialogs to be not cross-platform and not portable.

OK, if the decision is not to port it, what workaround can be used? What is the effect of having the initial opened window of the application be exposed as singleton, when any subsequent modal dialog sets it as parent?
Or, better said, what is the alternative/recommendation when the ownership is no longer known/available at the moment of displaying the dialog?

What if it is the starting window? what is the owner window?
ShowDialog offers a way to prompt for a result that according to it decision making in code, Something like OpenFolderDialog.
Thanks in advance.

@code-mantis personal opinion, having a dialog result was a mistake in wpf/avalonia design. In fact you can do the same with any window by setting public readable property a value on user action (or better to go with mvvm).

@rusoaica if your app is guaranteed to have only one toplevel window with everything else being a dialog, then it's fine to keep it as a singleton on the UI layer.
Otherwise I'd suggest to use a technique that tracks active views for a particular view model.
For example you could have a base class for your views that would keep a shared Dictionary<ViewModelBase, List<ViewBase>> and update its contents in OnAttachedToVisualTree, OnDetachedFromVisualTree and on DataContext changes. That way your UI layer will know which visible controls are currently associated with a particular view model, so you could get the appropriate toplevel Window to use as a parent.

@kekekeks the workaround I ended up using is to store the hash code of each window inside its view model, and pass that as argument.. when displaying a dialog, I am iterating all opened windows of the application, and set as parent the one that matches the provided hash code. As I said, looks hackish, but works:
For the DI container registration:
builder.RegisterType<StartupV>().OnActivating(e =>
{
    e.Instance.DataContext = e.Context.Resolve<IStartupVM>();
    (e.Instance.DataContext as IBaseModel).ParentHashCode = e.Instance.GetHashCode(); // store window hash code inside viewmodel
}).As<IStartupView>().InstancePerDependency();

After that:
public async Task<bool?> ShowDialogAsync(int parentHashCode)
{
    if (parentHashCode != 0)
    {
        IReadOnlyList<Window>? windows = ((IClassicDesktopStyleApplicationLifetime)Application.Current.ApplicationLifetime).Windows;
        Window? parent = windows.Where(w => w.GetHashCode() == parentHashCode).First();
        return await ShowDialog<bool?>(parent);
    }
    else
        return await ShowDialog<bool?>(StartupV.Instance); // use first application window as singleton, if no hashcode is provided
}


Enchantments Error

Hello again! I'm really bad at config, so that's probably why I'm here again. So, I recently added more lines of description in the Enchantments and Custom Enchantments. I also added 2 new book types and customized the colour of the Enchantments on the items. I think this is the reason why I can't go into anything in the CE list, can't do CE add, remove, and a lot of other stuff. Can you please help me? Thanks!

http://pastebin.com/F5vZKFJE - Config
http://pastebin.com/F10nQZCF - Console

Your version is to far out of date. Please update and then check it again.

It's still having the same problem

Pastebin the error plz

Say on console?

Yes

http://pastebin.com/e0KrH0ED

Pastebin your Enchantments.yml

http://pastebin.com/ZtNspv3u

Find anything wrong?

Strange, there is nothing wrong with that.

Can you send me your new Config.yml

Okay

http://pastebin.com/cW7PEYLL

Anything?

...

Sorry about that. Its harder to reply here some times. I compaired your config to the v<IP_ADDRESS> config because thats what the error said you were using. Not sure if you updated but I found you never added some lines. Mainly the transmog scroll options. Try this if your still using v<IP_ADDRESS>.
https://hastebin.com/usamiriguv.php

I have v<IP_ADDRESS> - would that work?

Well, I tried. I can now add enchantments, but I can't click the compass that lists the enchantments.

The problem with the info is because it must not be up to date. Ether compare the file to the default or regenerate the msgs.yml.

When I did that, MultiArrow was fixed somehow. Thanks for the help!

Np

Wait... It's just MultiArrow 5 that's not working... 1, 2, 3, and 4 work, but not 5

Strange, how do you know its not working?

Whenever I try to apply it via command, it says An internal error occurred while attempting to perform this command, then it removes all of the enchantments like I stated before.

Pastebin the error.

http://pastebin.com/82vwUfwe

Seems to be only when I have other custom enchantments applied. When it's a normal bow and I try to apply it, it works fine.

I am pritty sure that has been fixed in v1.7.6 update. So I recommend updating to the newest version but since ur far behind you will have quite a bit to add to the files.

What do I add? I'm a noob at config...

Read the change logs on the main page. You will have to go all the way back to v<IP_ADDRESS> and go from there. Other wise if you just delete ur files and start new then it wouldnt need you to add the lines but you do have to restart

I updated it and everything seems to be working fine without me adding/changing anything.

Except when I add multiarrow it randomly applies Freeze...


Documentation error for attr-no-duplication

I think the option attr-no-duplication is documentated as attr-no-dup.
Even in the defaults it is still attr-no-dup.

It should be attr-no-dup to match with id-no-dup. I'll change the rule and test files.


Linux leaves behind semaphores

When you close Holodeck the semaphores are still in /dev/shm/, need to make sure at exit the handles are being closed and removed.

Fixed in #25


Arcyd: add file handler to compress rotated debug logs

Fixes #18

This is looking good! I especially like the test driver :)
Please could you also include some detail in the commit message about why you are making the change (could basically copy text from the original issue).

Used the helper function to write files. Also added a more descriptive commit message. At the time of creating this PR, I was not fully aware of the standards and hence forgot to add the message, should be fine now.
I also added a note that this commit in itself will not change the amount of logs available or stored but will only reduce the size. Increasing the number of rotated logs stored should be a follow up to this.

Aha, quick turnaround :) Will look again, thanks!

Landed at d4c96c5, thanks!


[New API] : SendGrid API

Brief Description 🤓
Provides email sending capabilities, including transactional and marketing emails, useful for integrating email functionality into applications.
How will you develop it?🤩
React, JavaScript
Deployment
None
Select the open source program you are contributing to
Other
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINES of this project.

/gssoc24

Greetings @sreevidya-16🎀 ! , We are excited to have you dive into another issue with us!🚀
Your involvement in our project has been invaluable, and we're confident that your skills and insights will help us conquer this challenge😇.  Use command /gssoc24 to self assign the issue.  This issue represents an exciting opportunity for us to improve and enhance our project, and we are thrilled to have you on board.
We request you to follow CONTRIBUTING GUIDELINES.
Looking for your PR soon!
In case of any issues, you can contact us on Discord.❣


3D model [OBJ] import error

Godot version
v4.0.alpha6.official [e4f0fc50f]
System information
Linux Mint, Vulkan, GTX 1070
Issue description
I have imported a 3D model in form of OBJ format and I can add it to the world, but the texture is not automatically added to it.
I have tried it with the current Godot 3 and works correctly.
Steps to reproduce

Create a 3D world
Download OBJ version of: https://sketchfab.com/3d-models/skara-brae-orkney-house-2-e12c4389a6154bf5a72b74c34a1823b8
Try to add this mesh with its texture to the world

Minimal reproduction project
No response

Seems fixed as of 4.0 RC 5:


The "-j" option does not report any error message by zsync client

Since for the "-j" option the zsync client is created on the stack (https://github.com/AppImage/AppImageUpdate/blob/rewrite/src/updater.cpp#L520) and not assigned to zsyncClient, there's no way to currently pull for error messages https://github.com/AppImage/AppImageUpdate/blob/rewrite/src/updater.cpp#L618.

Two options to solve this:
a) rethink the role of the zSyncClient, we most likely don't need an extra instance to avoid modifications of its state
b) push the messages to the updater's message queue after calling checkForChanges (would be some kind of duplicate code, though)


DropDownButton doesn't support access key like AppBarButton.

Describe the bug
I want to add access key to DropDownButton's one menu item. In the DropDownButton, I add AccessKey="C"
Steps to reproduce the bug

Edit the the code DropDownButtonPage.xaml in https://github.com/Microsoft/Xaml-Controls-Gallery project like this.
<muxc:DropDownButton AccessKey="C" Content="Email">
muxc:DropDownButton.Flyout

</muxc:DropDownButton.Flyout>
</muxc:DropDownButton>
Then after it built and ran, go to the page, press alt key. It shows like below there is a C access key show under the Email.

Press the "C" key, and the drop down menu pops up. but the access key "C" for the menu item "Send".

Expected behavior
I hope it can directly like this below in the Step3, without press alt key again.

Version Info
[Microsoft.UI.Xaml.2.6.0-prerelease.210315002
NuGet package version:
[Microsoft.UI.Xaml.2.6.0-prerelease.210315002
Windows app type:
UWP

Windows 10 version
Windows 10 Pro 20H2  19042.928

Insider Build (xxxxx)              No

October 2020 Update (19042)

May 2020 Update (19041)

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

In your markup you've set the access key of the button to C, so pressing alt and then C invokes the button. Are you saying that you have another access key on the send menu flyout item that also has it's access key set to C?

Yes, I have another access key "O" on the menu flyout item which want to continue to be used after Alt+C is activated. You can see it works on AppBarButton.

It works with an appbar button that on invocation opens a flyout with another button in it?

Does pressing alt what the popup is open result in the access key being displayed?

An AppBarButton opens a flyout with the access key "O" displayed when you press alt+C. It is a continuous behavior without pressing alt again.

@Austin-Lamb can you weigh in on this access key behavior?

Will anyone resolve this bug?


New IAPS environment

Environment details
Preproduction environment for the IAPS system being migrated from legacy AWS accounts
Application Name
delius-integrated-accredited-programmes-system

Description of application

GitHub team slug
https://github.com/orgs/ministryofjustice/teams/hmpps-migration

Environments

Environment
Access level

[ ] Development
[ ] view-only[ ] developer[ ] sandbox

[ ] Test
[ ] view-only[ ] developer

[x] Preproduction
[ ] view-only[ ] developer

[ ] Production
[ ] view-only[ ] developer

Tags

tag
value

application
delius-integrated-accredited-programmes-system

business-unit
HMPPS

owner
<EMAIL_ADDRESS>

HMPPS
Networking options
Subnet sets

[ ] General - this application will use the same subnet as other applications in your business unit
[ ] Isolated - this application has highly sensitive data which must have its own isolated subnet with no network connectivity

How do users connect to the application?

[ ] Over the public internet
[ ] With a purple cabled device (please give details)
[x] With a MoJ Official device

Connectivity to other applications or external parties

[x] Delius (delius-core-dev-vpc - <IP_ADDRESS>/22)

Additional features

[ ] Additional VPC Endpoints
[ ] Extended DNS Zones
[ ] Other - please specify

Other information

Application users currently access the application by tunnelling through a bastion using Windows laptops with PuTTY.
Definition of done

[ ] account created
[ ] customer informed

Put in a pull for this - looks quite simple #2733

Completed. I can access it and I'm waiting for confirmation that the customer is OK with it.


APA Citation Style leaves out Title.

Description
When citing a Webpage as an @misc{...} article from a bibtex file then the citation and the bibliography do not print correctly when using style : "apa"
We obtain the following:

while the correct reproduction generated by Zotero should be:

I have a minimal Reproduction example in the URL
Reproduction URL
https://typst.app/project/rWxBsXa_AeJTy0K3d05Q1h
Operating system
Web app
Typst version

[X] I am using the latest version of Typst

Probably fixed by https://github.com/typst/hayagriva/issues/139. In the meantime, either add some form of author like NASA or use the workaround in the issue.

So will this likely be fixed when it is merged in with a new version of typst?

So will this likely be fixed when it is merged in with a new version of typst?

Yes.

This is fixed as of v0.11.1.


Update async & request

Following google/google-api-nodejs-client#465
Async from 0.9.0 to 1.4.1 Changelog - bug fixes and new features, no breaking changes
Request from 2.51.0 to 2.60.0 Changelog - bug fixes
Thanks !
PS : I added node 0.12 and iojs for testing.

I signed it!


Conan package manager support for Analyzer

This PR adds support for Conan package manager for the Analyzer. There are also two funTests for Conan module. Additions to travis, appvoyer and Dockerfile have been done as well.
Let's next work on this PR with review and test processes and see if something needs to be changed or added. In case of questions or comments, please contact me, @kallesoranko or @benmarsden

Thanks @kallesoranko!
 For details see here.

Hi @sschuberth and thanks for the (first) comment. In addition to DCO check (Ben is on it) I see that both builds are failing. I am not sure why Travis fails while installing Conan from pip and AppVeyor does not fail in that same step. AppVeyor is on the other hand failing, since it is trying to install Conan packages, before being able to run conan info and conan inspect over those packages. This is completely expected behavior and we could use the same technique as NPM analyzer for example is using, so before running analysis we could stash ~/.conan/data directory and run conan install over our project and after analysis we could delete changes and un-stash ~/.conan/data directory. Would this approach make sense to you or do you have other suggestions?

I am not sure why Travis fails while installing Conan from pip and AppVeyor does not fail in that same step.

Hi @kallesoranko,
passing the --user option to pip install could be worth a try, see https://stackoverflow.com/questions/27036259/how-to-write-travis-yml-if-my-project-deps-on-python-and-nodejs.

thanks @fviernau! That worked, also added same change to Dockerfile

Added stashing mechanism to Conan.kt (similar as with NPM analyzer) and after stashing we are executing  installDependencies(workingDir) which looks like
private fun installDependencies(workingDir: File) {
    run(workingDir, "install", ".")
}

This method can cause some error for example if a package does not exist in our remote repository for existing HW architecture, but on the other hand all required meta data is still fetched despite of the error. Is there a way to silence those errors and not to propagate them to analyzer-result.yml?

Is there a way to silence those errors and not to propagate them to analyzer-result.yml?

run() is just a convenience function for ProcessCapture(...).requireSuccess(), so in your case you probably want to drop the .requireSuccess() and simply call ProcessCapture() directly.

@sschuberth Thanks for the help. Now the tests are passing. Something still breaks the build, since I have not merged the master and I think that should be done after review comments, I presume

I have not merged the master and I think that should be done after review comments, I presume

Actually, you should rebase your PR's branch onto current master and force-push if you want to catch up with recent changes. Please do not merge master into you PR's branch, i.e. there should be no merge commits in a PR.

@kallesoranko, FYI, I've fixed the BundlerTest which currently fails in master. Please rebase once it is merged.

@sschuberth thanks for fixing BundlerTest. Now it passes and Appveyor passes as well, but Travis build fails at PipTest

@kallesoranko, as the PipTest passes locally for me on Linux, I've just retriggered the Travis job to rule out a network issue.

Just FYI, unfortunately I didn't find the time to start with a real review yet. In the worst case I'll not find the time before next week.

That's fine. Thanks for letting us know anyway.

@kallesoranko Please just ping me if the PR is ready for another review. As some of my comments are unresolved and / or no reply was added yet, but you already did new pushes, I'm uncertain about the state.

Hi @sschuberth I have gone through you comments and made changes accordingly. This PR is now ready for re-review.
One point that I am not so sure about is whether use textValueOrEmpty() or textValue(). We checked other managers and they mainly use textValueOrEmpty(), so there might be still issues about this.
I have tried to mark comments as resolved as I go.

Thanks @kallesoranko. Would you mind joining the ORT Slack chat via the link I just sent you so we can have some short-cycle communication about the PR?

Thanks @kallesoranko. Would you mind joining the ORT Slack chat via the link I just sent you so we can have some short-cycle communication about the PR?

@sschuberth Now live at ort-talk


:seedling: Remove the useless addon log

Summary
Related issue(s)
Reference: # https://github.com/open-cluster-management-io/addon-framework/pull/283
Tests

[ ] Unit/function tests have been added and incorporated into make unit-tests.
[ ] Integration tests have been added and incorporated into make integration-test.
[ ] E2E tests have been added and incorporated into make e2e-test-all.
[ ] List other manual tests you have done.

/lgtm


Where do template parameters belong?

I am attempting to divert a discussion that is currently flowing on the J3 mailing list.    Moving that discussion to here may broaden the audience as well as make it easier to split into more specific issues, use hyper-refs, and make rendering code a bit cleaner.     I am not going to try to post that extensive discussion here, so some repeat may be necessary.
The broad concern is just which entities should be able to be templated with the primary candidates being derived types, procedures, and modules.         A strong argument can be (and has been) made that templated modules (ala parameterized modules of past J3 papers) is sufficient, obviating the need for either of the other cases.      A counter-argument is that there is value in being able to support more fine-grained placement of template parameters on types and procedures.    As Van Snyder and others have pointed out, one must be careful to avoid the pitfalls of Fortran PDT's where type-bound procedures don't really work in a useful fashion with type parameters.
Several intermediate approaches have been suggested in the J3 mailing thread, but rather than attempting to do justice to them in this first post, I'm hoping the proponents can come back here and post their suggestions and relevant code examples.    (I've not done my homework yet, and would invariably get something wrong and only add to the confusion.   If the needed follow-ups don't happen I will go back and do my best to accurately summarize the options.)

I think this topic is mis-titled. Given the contents of your post, I would title this "What should be allowed to be templated?". Assuming that topic I would "template" modules and procedures. I would not explicitly template derived types as that has the potential of creating a derived type that is not consistent with its procedures. Consistency of a derived type with its procedures, as is required for containers, is currently provided by modules, and I would not change that for templates. A module's template parameters would implicitly parameterize included derived types and procedures that use the template parameters without overriding them via scope rules.
The parameters of a templated procedure would normally be independent of the parameters of any other templated procedure. If procedures need to be cross consistent in parameters, then the parameters would normally be the parameters of the enclosing templated module. If any procedures need to be cross consistent, this will normally be so pervasive, that it will be obvious from the module's initial definition, that the associated parameters will need to be in the module's template parameters. If any included procedures are also templated, then the module's template parameters would be substituted, before the final instantiation, using the parameters of the procedure's template. We would probably want to forbid an included templated procedure from having parameters with the same name as any parameter of an enclosing templated module.
I probably would not allow including modules in the scope of another module as:

Parameterizing a module so that enclosed procedure(s) can be parameterized seems too indirect for me;
It would lead to even higher levels of indentation; and
Keeping track of scopes would be more complicated.

But I could easily change my mind on this.

Regarding the title:  fair enough.   In hindsight, my original title could have been misconstrued in a rather rude way were anyone so inclined.  Changed.


Provide evidence that NodeNorm can reliably support 20 sequential queries with a maximum of 10 seconds pause between each query (our current goal for performance in the short term)

As requested by Tyler

See corresponding work for NameRes at https://github.com/TranslatorSRI/NameResolution/issues/113

Implemented in PR https://github.com/TranslatorSRI/babel-validation/pull/27, and NodeNorm appears to take 5.109 seconds to process 33 test rows (0.155 seconds/test row, 0.100 seconds/query). So that is well under that limit.
Unfortunately, we can't test this on Prod yet, because some of the Unit Tests fail here. I'll close this once this has been deployed there and everything works there.


Aria-hide lock icon and flag in banner

The lock icon and surrounding parentheses can be made aria-hidden, as it only communicates visual information.
https://github.com/trussworks/react-uswds/blob/c9f71d7d7989fb9c7ab2e264d1af26436dcb66c3/src/components/GovBanner/GovBanner.tsx#L64

Ditto for the flag image, which is purely decorative:
https://github.com/trussworks/react-uswds/blob/c9f71d7d7989fb9c7ab2e264d1af26436dcb66c3/src/components/GovBanner/GovBanner.tsx#L129-L133

The PR I'm working on will allow consumers to do this if they create a custom banner, but the standard GovBanner that we export for convenience should match the USWDS component code, for better or for worse.
For updating the USWDS recommended implementation, I'd recommend filing a bug with USWDS

ah, will do, you can close this one then

Opened issue here: https://github.com/uswds/uswds/issues/4912

USWDS implemented this! Can this be closed then or does it need a follow-up issue?


Swagger /api/api duplication

Describe the bug
Due to @BasePath /api defined in main.go, routes are called by /api/api in Swagger documentation, resulting in 404.
2 possible solutions:

Remove /api prefix from inline annotation comments
Remove basepath

What do you think @muety?
System information
Please provide information on:

Wakapi version: 1.30.1
Operating system: N/A
Database (SQLite, MySQL, ... ?): N/A

Good catch. I'd rather remove the prefixes and keep base path. Want to do a PR? :wink: Happy new year btw :v:

Good catch. I'd rather remove the prefixes and keep base path. Want to do a PR? :wink: Happy new year btw :v:

Happy new year to you too!


Bulk send sms (back end)

Nice work @Tara-Q! Great job lifting the state up to the parent component, and saving the message to localStorage. I've left a few suggestions for you 🏓

Excellent! Thanks for your suggestions, I'll get on with that now.


md-dialog-close should also have an input for mdDialogClose

Bug, feature request, or proposal:
Request
What is the expected behavior?
Using the dialog close directive should allow the following syntax
<button md-button [mdDialogClose]="true">Okay</button>

What is the current behavior?
Angular complains it can't bind to mdDialogClose since it isn't listed as a valid input
What are the steps to reproduce?
https://plnkr.co/edit/m7e7vFIKKgTiWIwCY7pc?p=preview
What is the use-case or motivation for changing an existing behavior?
I've noticed that across the library, components use kebab-case and directives use camelCase (but also allow kebab-case) for their selectors. I'd like to keep this consistent within my application, but I can't because while [mdDialogClose] is a valid selector, I can't bind a value to it.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Latest

HTML
<button mat-button type="button" (click)="close()">Cancelar
COMPONENT
on ngInit you can save the value and then if you cancel return that one
this.initInput = this.form.value.input;
close() {
this.dialogRef.close(this.initInput);
}


staging-next 2024-10-15

This is the last iteration that can contain breaking changes to release-critical packages.
Helpful links

workflow docs: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#staging
important jobs:
https://hydra.nixos.org/job/nixpkgs/staging-next/unstable#tabs-constituents
https://hydra.nixos.org/job/nixos/staging-next-small/tested
jobsets:
https://hydra.nixos.org/jobset/nixpkgs/staging-next
https://hydra.nixos.org/jobset/nixos/staging-next-small
nix-review reports: https://malob.github.io/nix-review-tools-reports/
previous staging-next: https://github.com/NixOS/nixpkgs/pull/343421

Mass breakages
nothing notable so far

[ ] installer tests have insufficient dependencies again, e.g. nixosTests.installer.simpleUefiSystemdBoot :
https://hydra.nixos.org/build/276424361

According to https://github.com/NixOS/nixpkgs/issues/339153, this PR is to be merged today. When should I expect this to be merged?

It’s staging. Time is elastic.

(But not before https://github.com/NixOS/nixpkgs/pull/352491, at least.)

When should I expect this to be merged?

I'm the release manager so I think I'll be the one doing it. Hopefully sometime soon ™ .

Probably we should let @vcunat handle it as usual? We haven’t even gotten a staging-next-small eval started yet.

Probably best.

I believe you've fixed all known blockers, and I looked at staging-next-small to get more confidence.  So I see no need to delay anymore.

[ ] virtualbox* are broken, blocking the nixos-unstable channel, I'm afraid.
https://hydra.nixos.org/build/276715853
maintainers: @svanderburg, @friedrichaltheide, @blitz


Installed dnscrypt-proxy 2.0.12 - changelog

I've just uninstalled 2.0.11 and installed 2.0.12
The changelog says: 'The proxy will now wait for network connectivity before starting. This is useful if the proxy is automatically started at boot, possibly before the network is fully configured.'
I checked /etc/systemd/system/dnscrypt-proxy.service but the entries we've previously discussed ( Wants=network-online.target and After=network-online.target) aren't there.
Did you use an alternative method to wait for the network?
Thanks

dnscrypt-proxy has its own check now, see https://github.com/jedisct1/dnscrypt-proxy/commit/ce62981c44913f59a0d638397edf17ebd7da27bb

Yes, the proxy does it. It doesn't depend on systemd, so the behavior is consistent across all operating systems no matter how the proxy is started.
Wants=network-online.target and After=network-online.target are not required any more.


Question: can I have a more detailed example of dynamic highlighting mechanism?

Hi.
I have a small java code editor as a script window inside my application and I wish to highlight the names of classes, interfaces, constants, etc, of my API and it's instances created by user. I read the issue "Dynamic keyword highlighting" (#147) but I was unable to understand how to use it. So, I wish to ask a more detailed or full example, if possible.
Thanks.

Sure, have a look at the JavaKeywordsDemo.

Thanks for your reply, but I had already seen and used this example for highlighting static items (keywords, comments ...) But what I need to do is during program execution. If the user creates an object from a class of my API, I would like to mark it automatically. The question I quoted (# 147) says how to do it but not enough for me to know how to turn it into functional code.

I suppose the tricky part is how to get the ObservaleValues if you haven't done this before and you don't know about the JavaFX Bindings helper API ( javafx.beans.binding.Bindings).
So I assume you don't have a problem with the first step as given:
private static final ObservableList<String> KEYWORDS = FXCollections.observableArrayList(
    // ...
);

The next step is where the Bindings helper API is your friend using the createStringBinding method:
private static final ObservableValue<String> KEYWORD_PATTERN = Bindings
.createStringBinding( () -> "\\b(" + String.join("|", KEYWORDS) + ")\\b", KEYWORDS );

Just in case this is unfamiliar to you what's happening here is that everytime the KEYWORDS list changes the given lambda function will be executed to regenerate the value of KEYWORD_PATTERN.
Then do the same for PATTERN but now we use the createObjectBinding method instead:
private static final ObservableValue<Pattern> PATTERN = Bindings.
createObjectBinding( () -> Pattern.compile(
    "(?<KEYWORD>" + KEYWORD_PATTERN.getValue() + ")"
   +"|(?<PAREN>" + PAREN_PATTERN + ")"
    // ...
), KEYWORD_PATTERN );

Note that we are using KEYWORD_PATTERN.getValue() now, and that you'll need to do the same for PATTERN in the computeHighlighting method of the demo.
Finally in the demo's start method, add a listener to PATTERN to trigger highlighting when it changes:
PATTERN.addListener( (ob,ov,nv) -> codeArea.setStyleSpans(
   0, computeHighlighting( codeArea.getText() )
));

And that`s it, now every time a word is dynamically added or removed from the list the highlighting will be recomputed.

Thanks a lot.
I don't implemented it yet, but now I understand how it works. So, I guess I will have no troubles with this anymore.


Clean up duplicated color conversion code

Objective
Cleans up some duplicated color -> u32 conversion code in bevy_sprite and bevy_ui
Solution
Use as_linear_rgba_u32 which was added recently by #4088

bors r+


General Fixs

Issue description

Fixes includes page styling for English and arabic view
Fixed Github action for the merge crowdin
Netlify deployment fixes

@BatoolMM
I have changed the netlify settings for deployment preview, from frontend-ui to main

That's fantastic, waw, thank you 🙏