HAWQ-1618. Segment panic at workfile_mgr_close_file() when transaction

ROLLBACK
Fix what?
Segment panic sometimes when transaction rollback.
Core at at workfile_mgr_close_file()
How to fix?
Workfile memory is alloced in ExecWorkFile_Create()/ExecWorkFile_Open()'s current memory context, and this context will be released early in some cases, then segment panic in ntuplestore_cleanup().
So should use a appropriate memory context to hold them: its life is the same as NTupleStore.
This fix borrow from gpdb:
https://github.com/greenplum-db/gpdb/commit/f0a0a593bde8cf0c9b9bbc79061a09f7164b54f7#diff-b37908413e016b54a45d549cf0539121
Test?
No test, reason:
It's a memory bug, need a appropriate time to cancel query and accessing a recycled memory context doesn't always trigger panic, hard to test them.

+1

+1

merged


Making this document more macOS friendly

2 changes:

Changed the Windows specific language to be about applying Conditional Access to the sync client, regardless of OS
Added an additional link to a SharePoint that many customers didn't know existed about blocking OneDrive sync via conditional access policies

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.


Nack() Delivery when OutputHostConnection IsClose()

This prevents the consumer from likely trying to write on a delivery channel is closed since IsClosed should always return true if the cherami calling code always closes the consumer before closing its delivery channel.

Coverage remained the same at 80.903% when pulling 624adc7e63e796d95aff1699d81a72b940619dc6 on aandrade.nack-delivery-when-closed into af231855dc60abc8332dd3ac0279e9baa4cc0524 on master.

Coverage remained the same at 80.903% when pulling 624adc7e63e796d95aff1699d81a72b940619dc6 on aandrade.nack-delivery-when-closed into af231855dc60abc8332dd3ac0279e9baa4cc0524 on master.

Coverage remained the same at 80.903% when pulling 624adc7e63e796d95aff1699d81a72b940619dc6 on aandrade.nack-delivery-when-closed into af231855dc60abc8332dd3ac0279e9baa4cc0524 on master.

@andrewdeandrade, I am closing this one out, since this was fixed by PR #28 ("Ensure Delivery channel is not used after Close()").


Implement numeric 'E' format

Repro:

Uncomment //GenerateTest(writer, type, 'E', maxPrecision);  in src\System.Text.Formatting\GenerateCompatibilityTests\Program.cs
Run the program. It will generate additional format tests
Build the formatting library and run the test (run build.cmd from command line)
Result:
Some formatting tests will fail.

done as part of the moved to corfx


feat: size param for UserGroup

PR includes

[x] Feature

Related issues

Resolve #1065
QA Instructions, Screenshots, Recordings

/canary


Custom class name completion contexts

It would be great if the extension could handle custom class name completion contexts, similar to how it works for the vs code tailwind extension. In vs code custom contexts can be added as regexes using the tailwindCSS.experimental.classRegex property.
For example:
<input
    class="@(
        string.Join(" ", new [] {
            "w-full px-md py-sm text-t-neutral-700",
            "outline-none focus:outline-none focus-visible:outline-none"
        })
    )"
    ...
/>

At the moment the extension's intellisense does not work with the above.

I will definitely look into adding this in the future. At the moment, this extension is written in a way that wouldn't work with a regex system like the official extension, so it will need a significant rewrite to add this functionality.
If you want IntelliSense for these contexts at the moment, I believe (but did not confirm) that you can add a comment on the line before each string with class=:
<input
    class="@(
        string.Join(" ", new [] {
            // class=
            "w-full px-md py-sm text-t-neutral-700",
            // class=
            "outline-none focus:outline-none focus-visible:outline-none"
        })
    )"
    ...
/>

@DennisRosen Sorry about the delay; this functionality should be added in 1.7.0. For specific guidelines regarding custom regexes, you can check out Getting-Started.md. Please let me know if you run into any issues!
Getting-Started.md:
Custom regexes can be defined in settings. Please note that:

There can only be one, valid C# regex.
Your class content must be located in the content capture group. For example, the regex class="(?.*)" successfully captures content.
Custom regexes take precedence over default functionality; that is, if a context is matched in both your custom regex and the original regex, the custom regex will be used.
It's recommended to thoroughly test your regexes before adding it into your options. Unintended behavior may occur if the regex is too general or if it overlaps with existing functionality.


Hello, I used your resnet50 with ibna added, and the performance on the mixed data set is significantly reduced. What is the reason for this? The data set is multiple person reID data sets

Hello, I used your resnet50 with ibna added, and the performance on the mixed data set is significantly reduced. What is the reason for this? The data set is multiple person reID data sets

@wfchenwf I am not able to diagnose this issue given limited information, but you may refer to this repo: https://github.com/michuanhaohao/reid-strong-baseline, where they obtain promising results in person reID.

Hi, I met a similar issue, have you solved this issue? @wfchenwf
I used a mobilenet backbone in detection task, and added IN(with affine) after first conv and added IN in 3rd conv_dw(conv-bn-relu-conv-in-relu) block refer to resnet50-ibnb. one of the mixed dataset is VisDrone2019, another one is our own drone dataset and the image quality is lower than VisDrone.
Although I trained detection task from scratch since IBN arch, but it converged to a much higher trainloss and valloss than BN only model trained from scratch.
What did I missed? @XingangPan
Thanks.


Plugin does not show on BDPlugins list

I did all the installation steps and repeated them a couple of times, as well as clearing the cache and still nothing. I even deleted a couple of plugins to see if there were conflicts and it still won't show, does it have something to do with my Powercord installation itself?

@Yimellovzski, I have released an update that should fix it. Please let me know if it resolves your problem

@Yimellovzski, I have released an update that should fix it. Please let me know if it resolves your problem

Thank you! It solved the problem now!


connlib: tracking issue for battery & bandwidth optimisations

Connlib utilises ICE, STUN & TURN to reliably establish a connection between client and gateway. This is achieved by creating candidates from local socket addresses and remote-allocated relay addresses and testing the connectivity between them.
The best[^1] candidate pair wins and we establish a WG tunnel for that socket pair. Unfortunately, the redundancy of candidate pairs causes background traffic that is especially problematic on mobile devices.
This issue aims to track a list of optimisations that we can implement whilst staying compliant with ICE that reduces this problem. Deviating from ICE is deliberately out of scope in order to not impact reliablity. A deeper integration with str0m (the ICE agent) and boringtun (the WG library) may yield further improvements in the future.
### Optimisations (in order of expected impact)
- [ ] Close idle connections
- [ ] Detect our NAT status via our relays and don't send relay candidates if we are behind a destination-independent NAT (which will allow hole-punching)
- [ ] Don't use every relay for every connection

[^1]: As per ICE spec.
### Related issues
- [ ] https://github.com/firezone/firezone/issues/4060

@jamilbk Do we want some of these optimisations in the 1.1.0 client release?

Closing idle connections will be the biggest needle mover -- is that fairly simple to implement? I wouldn't want to introduce new bugs at this point.

Closing idle connections will be the biggest needle mover -- is that fairly simple to implement? I wouldn't want to introduce new bugs at this point.

I'll attempt it tomorrow in a time-box!


GET /api/v3_0/assets/public should ask for token authentication

... as it's meant to be used via JSON

Does this require a changelof entry?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 64.812%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
7082

Relevant Lines:
10171

💛  - Coveralls

Idea for letting all API views subclass APIView, and letting all UI views subclass UIView, defined as follows:
class APIView(FlaskView):
    trailing_slash = False
    decorators = [auth_required()]

class UIView(FlaskView):
    decorators = [login_required()]

Nice. But this further entrenches the use of Flask-Classful. On the PR there which blocks us, people are asking officially if the project is abandoned.


Fix bug #4984 Added queries for package name for Android API 30+

Description
Fixes #4984
Android 11+ will restrict package name visibility so we need to add the required package names manually.
Tests performed
Tested betaDebug on Google Pixel 4A with API level 32

Thanks @madhurgupta10 !


Inputting new images into a trained ImageCaption model

I ran the image classification script on the flickr8k dataset and it finished training and outputted a .pickle file. How do I now run it on arbitrary images and have it generate sentences for those?
I know for NeuralTalk I had to run a script to extract features from the image, but how does it work for this library?

It's going to take some work to get it working on new images but there are multiple ways to do it. You can use the VGG model from NeuralTalk to get the features, then create a new dataset iterator in Neon based on imagecaption.py which just loads in the images. We're working on creating a script to convert caffee models to neon models so that you'd be able to run a pretrained VGG from caffee in Neon.

Can you elaborate more on the NeuralTalk VGG model option? I understand how to extract the features from the image, but then how do I pipe it back into the imagecaption file?

This will have most of what you need https://github.com/NervanaSystems/neon/blob/master/neon/data/imagecaption.py. In read_images(), load in the VGG features from NeuralTalk instead of the presaved ones. In ImageCaptionTest, you can remove the sentence loading code in the constructor and the ref sentence loading in the iter.


feat(docs): add a changelog adhering to the Keep a Changelog spec

feat(docs): add a changelog adhering to the Keep a Changelog spec (82d955a866bd7edcf91a128a90bc4abbe38892a1)
Changelog markers are added
in preparation for automated substitution
by help of cargo-release.
Related to #6
feat: configure cargo-release (bce46de17a3b3406945c928b4ff13a3fc523b85e)
Installation instructions in README.md
and lib.rs rustdoc comments
are added, since cargo-release
makes substitution of the version indicator
at release time very simple.
We might later switch to release-plz.
Related to #6

Example output of cargo release -v minor to release v0.2.0 (including our latest breaking changes) - note the projected replacements in Cargo.toml, CHANGELOG.md, README.md and src/lib.rs, as well as the automated test run:
❯ cargo release -v minor
[2024-12-05T17:09:06Z DEBUG reqwest::connect] starting new connection: https://index.crates.io/
[2024-12-05T17:09:06Z DEBUG hyper_util::client::legacy::connect::dns] resolving host="index.crates.io"
[2024-12-05T17:09:06Z DEBUG hyper_util::client::legacy::connect::http] connecting to [2600:9000:275f:6e00:1f:a9f5:69c0:93a1]:443
[2024-12-05T17:09:06Z DEBUG hyper_util::client::legacy::connect::http] connected to [2600:9000:275f:6e00:1f:a9f5:69c0:93a1]:443
[2024-12-05T17:09:06Z DEBUG h2::client] binding client connection
[2024-12-05T17:09:06Z DEBUG h2::client] client connection bound
[2024-12-05T17:09:06Z DEBUG h2::codec::framed_write] send frame=Settings { flags: (0x0), enable_push: 0, initial_window_size: 2097152, max_frame_size: 16384, max_header_list_size: 16384 }
[2024-12-05T17:09:06Z DEBUG h2::proto::connection] Connection; peer=Client
[2024-12-05T17:09:06Z DEBUG hyper_util::client::legacy::pool] pooling idle connection for ("https", index.crates.io)
[2024-12-05T17:09:06Z DEBUG h2::codec::framed_write] send frame=WindowUpdate { stream_id: StreamId(0), size_increment: 5177345 }
[2024-12-05T17:09:06Z DEBUG h2::codec::framed_write] send frame=Headers { stream_id: StreamId(1), flags: (0x5: END_HEADERS | END_STREAM) }
[2024-12-05T17:09:06Z DEBUG h2::codec::framed_read] received frame=Settings { flags: (0x0), max_concurrent_streams: 128, initial_window_size: 65536, max_frame_size: 16777215 }
[2024-12-05T17:09:06Z DEBUG h2::codec::framed_write] send frame=Settings { flags: (0x1: ACK) }
[2024-12-05T17:09:06Z DEBUG h2::codec::framed_read] received frame=WindowUpdate { stream_id: StreamId(0), size_increment:<PHONE_NUMBER> }
[2024-12-05T17:09:06Z DEBUG h2::codec::framed_read] received frame=Settings { flags: (0x1: ACK) }
[2024-12-05T17:09:06Z DEBUG h2::proto::settings] received settings ACK; applying Settings { flags: (0x0), enable_push: 0, initial_window_size: 2097152, max_frame_size: 16384, max_header_list_size: 16384 }
[2024-12-05T17:09:06Z DEBUG h2::codec::framed_read] received frame=Headers { stream_id: StreamId(1), flags: (0x4: END_HEADERS) }
[2024-12-05T17:09:06Z DEBUG h2::codec::framed_read] received frame=Data { stream_id: StreamId(1) }
[2024-12-05T17:09:06Z DEBUG h2::codec::framed_read] received frame=Data { stream_id: StreamId(1), flags: (0x1: END_STREAM) }
[2024-12-05T17:09:06Z DEBUG cargo_release::steps] Files changed in jiff-cron since v0.1.1: [
        "/home/leonie/Work/OSS/jiff-cron/.github/workflows/rust.yml",
        "/home/leonie/Work/OSS/jiff-cron/CHANGELOG.md",
        "/home/leonie/Work/OSS/jiff-cron/Cargo.toml",
        "/home/leonie/Work/OSS/jiff-cron/README.md",
        "/home/leonie/Work/OSS/jiff-cron/release.toml",
        "/home/leonie/Work/OSS/jiff-cron/renovate.json",
        "/home/leonie/Work/OSS/jiff-cron/rustfmt.toml",
        "/home/leonie/Work/OSS/jiff-cron/src/lib.rs",
        "/home/leonie/Work/OSS/jiff-cron/src/parsing.rs",
        "/home/leonie/Work/OSS/jiff-cron/src/queries.rs",
        "/home/leonie/Work/OSS/jiff-cron/src/schedule.rs",
        "/home/leonie/Work/OSS/jiff-cron/src/specifier.rs",
        "/home/leonie/Work/OSS/jiff-cron/src/time_unit/days_of_month.rs",
        "/home/leonie/Work/OSS/jiff-cron/src/time_unit/days_of_week.rs",
        "/home/leonie/Work/OSS/jiff-cron/src/time_unit/hours.rs",
        "/home/leonie/Work/OSS/jiff-cron/src/time_unit/minutes.rs",
        "/home/leonie/Work/OSS/jiff-cron/src/time_unit/mod.rs",
        "/home/leonie/Work/OSS/jiff-cron/src/time_unit/months.rs",
        "/home/leonie/Work/OSS/jiff-cron/src/time_unit/seconds.rs",
        "/home/leonie/Work/OSS/jiff-cron/src/time_unit/years.rs",
    ]
[2024-12-05T17:09:06Z DEBUG globset] built glob set; 0 literals, 1 basenames, 0 extensions, 0 prefixes, 0 suffixes, 0 required extensions, 0 regexes
error: cannot release from branch `docs/6-keep-a-changelog` as it doesn't match `main`; either switch to an allowed branch or add this branch to `allow-branch`
   Upgrading jiff-cron from 0.1.1 to 0.2.0
[2024-12-05T17:09:08Z DEBUG cargo_release::ops::cargo] change:
    --- /home/leonie/Work/OSS/jiff-cron/Cargo.toml      original
    +++ /home/leonie/Work/OSS/jiff-cron/Cargo.toml      updated
    @@ -1,6 +1,6 @@
     [package]
     name = "jiff-cron"
    -version = "0.1.1"
    +version = "0.2.0"
     authors = [
         "Leonie Philine Bitto<EMAIL_ADDRESS>         "Max Countryman<EMAIL_ADDRESS>
[2024-12-05T17:09:08Z DEBUG cargo_release::steps::release] updating lock file
[2024-12-05T17:09:08Z DEBUG cargo_release::ops::replace] processing replacements for file /home/leonie/Work/OSS/jiff-cron/CHANGELOG.md
   Replacing in CHANGELOG.md
--- CHANGELOG.md        original
+++ CHANGELOG.md        replaced
@@ -9,6 +9,8 @@

 ## [Unreleased] <!-- release-date -->

+## [0.2.0] - 2024-12-05
+
 ### BREAKING CHANGES

 - Re-define `Schedule` equality in terms of **parsed representation**.
@@ -52,5 +54,6 @@
 - fix: Don't accept invalid step for `Period` (https://github.com/maxcountryman/jiff-cron/commit/cabee0f36eec4faa34ebe3780046516d4a97a41b, https://github.com/zslayton/cron/pull/122) by @bombsimon

 <!-- next-url -->
-[Unreleased]: https://github.com/LeoniePhiline/async-mailer/compare/v0.1.1...HEAD
+[Unreleased]: https://github.com/jiff-cron/jiff-cron/compare/v0.2.0...HEAD
+[0.2.0]: https://github.com/LeoniePhiline/async-mailer/compare/v0.1.1...v0.2.0
 [0.1.0]: https://github.com/LeoniePhiline/async-mailer/releases/tag/v0.1.1

[2024-12-05T17:09:08Z DEBUG cargo_release::ops::replace] processing replacements for file /home/leonie/Work/OSS/jiff-cron/README.md
   Replacing in README.md
--- README.md   original
+++ README.md   replaced
@@ -38,7 +38,7 @@
 Add to your `Cargo.toml`:

 ```toml
-jiff-cron = "0.1.1"
+jiff-cron = "0.2.0"

You can enable optional serde support
[2024-12-05T17:09:08Z DEBUG cargo_release::ops::replace] processing replacements for file /home/leonie/Work/OSS/jiff-cron/src/lib.rs
Replacing in src/lib.rs
--- src/lib.rs  original
+++ src/lib.rs  replaced
@@ -40,7 +40,7 @@
//! Add to your Cargo.toml:
//!
//! toml -//! jiff-cron = "0.1.1" +//! jiff-cron = "0.2.0"  //!
//!
//! You can enable optional serde support
[2024-12-05T17:09:08Z DEBUG cargo_release::steps::hook] calling pre-release hook: ["cargo", "test", "--all-features"]
Finished test profile [unoptimized + debuginfo] target(s) in 0.01s
Running unittests src/lib.rs (target/debug/deps/jiff_cron-2fb39b8a4492c9e3)
running 76 tests
test parsing::test::shorthand_must_match_whole_input ... ok
test parsing::test::test_nom_field_with_any_valid_any ... ok
test parsing::test::test_from_str ... ok
test parsing::test::test_nom_field_invalid_any ... ok
test parsing::test::test_nom_invalid_days_of_week_list ... ok
test parsing::test::test_nom_invalid_named_point ... ok
test parsing::test::test_nom_invalid_days_of_week_range ... ok
test parsing::test::test_nom_invalid_named_range_field ... ok
test parsing::test::test_nom_invalid_number_list ... ok
test parsing::test::test_nom_invalid_period ... ok
test parsing::test::test_nom_invalid_other_fields_any ... ok
test parsing::test::test_nom_invalid_period_any ... ok
test parsing::test::test_nom_invalid_period_named_point ... ok
test parsing::test::test_nom_invalid_period_specifier_range ... ok
test parsing::test::test_nom_invalid_period_with_any_named_point ... ok
test parsing::test::test_nom_invalid_period_with_any_specifier_range ... ok
test parsing::test::test_nom_invalid_period_with_range_specifier ... ok
test parsing::test::test_nom_invalid_point ... ok
test parsing::test::test_nom_invalid_range_field ... ok
test parsing::test::test_nom_invalid_schedule ... ok
test parsing::test::test_nom_invalid_seconds_list ... ok
test parsing::test::test_nom_invalid_seconds_range ... ok
test parsing::test::test_nom_invalid_seconds_mix ... ok
test parsing::test::test_nom_invalid_trailing_characters ... ok
test parsing::test::test_nom_valid_days_of_month_any ... ok
test parsing::test::test_nom_valid_days_of_month_any_days_of_week_specific ... ok
test parsing::test::test_nom_valid_days_of_week_any ... ok
test parsing::test::test_nom_valid_days_of_week_list ... ok
test parsing::test::test_nom_valid_days_of_week_any_days_of_month_specific ... ok
test parsing::test::test_nom_valid_days_of_week_range ... ok
test parsing::test::test_nom_valid_named_point ... ok
test parsing::test::test_nom_valid_named_range_field ... ok
test parsing::test::test_nom_valid_number ... ok
test parsing::test::test_nom_valid_dom_and_dow_any ... ok
test parsing::test::test_nom_valid_period ... ok
test parsing::test::test_nom_valid_number_list ... ok
test parsing::test::test_nom_valid_period_all ... ok
test parsing::test::test_nom_valid_period_point ... ok
test parsing::test::test_nom_valid_period_named_range ... ok
test parsing::test::test_nom_valid_period_range ... ok
test parsing::test::test_nom_valid_period_with_any_all ... ok
test parsing::test::test_nom_valid_period_with_any_any ... ok
test parsing::test::test_nom_valid_period_with_any_named_range ... ok
test parsing::test::test_nom_valid_period_with_any_point ... ok
test parsing::test::test_nom_valid_period_with_any_range ... ok
test parsing::test::test_nom_valid_range_field ... ok
test parsing::test::test_nom_valid_schedule ... ok
test parsing::test::test_nom_valid_seconds_list ... ok
test parsing::test::test_nom_valid_seconds_mix ... ok
test parsing::test::test_nom_valid_seconds_range ... ok
test parsing::test::test_try_from_cow_str_borrowed ... ok
test parsing::test::test_try_from_cow_str_owned ... ok
test parsing::test::test_try_from_str ... ok
test parsing::test::test_try_from_string ... ok
test schedule::test::test_display_schedule ... ok
test schedule::test::test_invalid_from_str ... ok
test schedule::test::test_invalid_ser_de_schedule_tokens ... ok
test parsing::test::test_reject_invalid_interval ... ok
test schedule::test::test_next_after_past_date_next_year ... ok
test schedule::test::test_schedule_to_string ... ok
test schedule::test::test_ser_de_schedule_tokens ... ok
test schedule::test::test_ser_de_schedule_shorthand ... ok
test schedule::test::test_valid_from_str ... ok
test schedule::test::test_ser_de_schedule_period_values_range ... ok
test schedule::test::test_time_unit_spec_equality ... ok
test schedule::test::test_no_panic_on_nonexistent_time_after ... ok
test schedule::test::test_next_after ... ok
test schedule::test::test_prev_from ... ok
test schedule::test::test_no_panic_on_nonexistent_time_before ... ok
test schedule::test::test_next_and_prev_from ... ok
test schedule::test::test_upcoming_rev_utc_owned ... ok
test schedule::test::test_upcoming_rev_utc ... ok
test schedule::test::test_upcoming_local ... ok
test schedule::test::test_no_panic_on_leap_day_time_after ... ok
test schedule::test::test_upcoming_utc_owned ... ok
test schedule::test::test_upcoming_utc ... ok
test result: ok. 76 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.02s
 Running tests/lib.rs (target/debug/deps/lib-a5863b1cd0769cb4)

running 35 tests
test tests::test_invalid_step ... ok
test tests::test_first_ordinals_not_in_set_2 ... ok
test tests::test_daily ... ok
test tests::test_first_ordinals_not_in_set_1 ... ok
test tests::test_is_all ... ok
test tests::test_hourly ... ok
test tests::test_not_enough_fields ... ok
test tests::test_parse_too_many_fields ... ok
test tests::test_monthly ... ok
test tests::test_parse_with_year ... ok
test tests::test_parse_with_seconds_list ... ok
test tests::test_parse_without_year ... ok
test tests::test_time_unit_spec_days_of_month ... ok
test tests::test_time_unit_spec_months ... ok
test tests::test_time_unit_spec_years ... ok
test tests::test_step_schedule ... ok
test tests::test_yearly ... ok
test tests::test_weekly ... ok
test tests::test_includes ... ok
test tests::test_period_values_any_dow ... ok
test tests::test_period_values_any_dom ... ok
test tests::test_period_values_named_range ... ok
test tests::test_period_values_range ... ok
test tests::test_period_values_all_seconds ... ok
test tests::test_period_values_range_hours ... ok
test tests::test_period_values_range_days ... ok
test tests::test_period_values_point ... ok
test tests::test_period_values_range_months ... ok
test tests::test_period_values_range_years ... ok
test tests::test_prev_utc ... ok
test tests::test_next_utc ... ok
test tests::test_anything_goes ... ok
test tests::test_readme ... ok
test tests::test_upcoming_iterator ... ok
test tests::test_parse_with_lists ... ok
test result: ok. 35 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.02s
Doc-tests jiff_cron
running 7 tests
test src/time_unit/mod.rs - time_unit::TimeUnitSpec::count (line 166) ... ok
test src/time_unit/mod.rs - time_unit::TimeUnitSpec::includes (line 99) ... ok
test src/time_unit/mod.rs - time_unit::TimeUnitSpec::iter (line 119) ... ok
test src/time_unit/mod.rs - time_unit::TimeUnitSpec::is_all (line 183) ... ok
test src/time_unit/mod.rs - time_unit::TimeUnitSpec (line 60) ... ok
test src/time_unit/mod.rs - time_unit::TimeUnitSpec::range (line 142) ... ok
test src/lib.rs - (line 8) ... ok
test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.22s
Publishing jiff-cron
Updating crates.io index
warning: crate<EMAIL_ADDRESS>already exists on crates.io index
Packaging jiff-cron v0.1.1 (/home/leonie/Work/OSS/jiff-cron)
Packaged 28 files, 123.3KiB (22.9KiB compressed)
Verifying jiff-cron v0.1.1 (/home/leonie/Work/OSS/jiff-cron)
Updating crates.io index
Compiling memchr v2.7.4
Compiling minimal-lexical v0.2.1
Compiling jiff v0.1.15
Compiling nom v7.1.3
Compiling jiff-cron v0.1.1 (/home/leonie/Work/OSS/jiff-cron/target/package/jiff-cron-0.1.1)
Finished dev profile [unoptimized + debuginfo] target(s) in 1.63s
Uploading jiff-cron v0.1.1 (/home/leonie/Work/OSS/jiff-cron)
warning: aborting upload due to dry run
[2024-12-05T17:09:10Z DEBUG cargo_release::steps::tag] creating git tag v0.2.0
Pushing Pushing docs/6-keep-a-changelog, v0.2.0 to origin
error: dry-run failed, resolve the above errors and try again.

Note that the error mentioned in the end refers to:

> `error: cannot release from branch `docs/6-keep-a-changelog` as it doesn't match `main`; either switch to an allowed branch or add this branch to `allow-branch`

This is expected, as I dry-ran `cargo-release` from the `docs/6-keep-a-changelog` branch, the source of this pull request.

@maxcountryman
Once this is approved and merged, I am intending to run cargo release -v minor on the main branch, thus releasing v0.2.0 to crates.io.
Please let me know if you see any blockers!


Update to WildFly 22.0.0.Final

@WolfgangHG next update please don't change the project related versions, those are changed in release preparation commit


ASU-1290 | Installment model improvements

Changed ApartmentInstallments to contain only Euro values, and also added unique constraint for installment types.

Codecov Report

Merging #147 (d52ef83) into develop (ba6d17d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #147      +/-   ##
===========================================
+ Coverage    94.11%   94.13%   +0.01%
===========================================
  Files           85       85
  Lines         2261     2268       +7
  Branches       185      185
===========================================
+ Hits          2128     2135       +7
  Misses         101      101
  Partials        32       32

Impacted Files
Coverage Δ

invoicing/api/serializers.py
96.55% <100.00%> (+0.12%)
:arrow_up:

invoicing/models.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba6d17d...d52ef83. Read the comment docs.

I'll approve this one, but I would have liked this one to be two commits. Always when using "and" or "also do" in the message that is a strong signal that the change should be in multiple commits.
🚢

I know and generally agree of course, however in this particular spot two commits would have required two migrations, and because the other change is kind of cosmetic, I came to the conclusion that this one commit is the less bad solution 🙂


sample: add new sample yaml for local RBAC.

For #6377 , I'll delete the existing mixer-based RBAC sample yaml after we finished the doc update.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: yangminzhu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vadimeisenbergibm
Assign the PR to them by writing /assign @vadimeisenbergibm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
2deb0e069f1ba8d2c23cf26b6b030963e6acfad8
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
2deb0e069f1ba8d2c23cf26b6b030963e6acfad8
link
/test istio-presubmit

prow/istio-unit-tests.sh
1a38b365da71845004ad8d44837975874d2a8524
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
2deb0e069f1ba8d2c23cf26b6b030963e6acfad8
link
/test istio-presubmit

prow/istio-unit-tests.sh
4c2741542a996d139979475c45d1b85cf3c62ba2
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
4c2741542a996d139979475c45d1b85cf3c62ba2
link
/test istio-unit-tests

prow/istio-presubmit.sh
4c2741542a996d139979475c45d1b85cf3c62ba2
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: liminw, yangminzhu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vadimeisenbergibm
Assign the PR to them by writing /assign @vadimeisenbergibm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
This pull-request has been approved by: liminw, yangminzhu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
This pull-request has been approved by: liminw, yangminzhu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangminzhu: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
This pull-request has been approved by: liminw, yangminzhu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hklai Andy, Can we make this into 1.0 release? It's only sample config change and are necessary for the local RBAC that is already included in 1.0. Thank you!


Rename obsolete rubocop directive

Summary
Nightly build has failed today with a new version of Rubocop. This should fix the error.
Details

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Refactor (code change that does not change external functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] I've added tests for my code
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

This is actually highlighting an issue with our new updating shell script.
We shouldn't ever lock rubocop to x.y it should always be locked to x.y.z and then manually updated and checked.
Because its at a 0.x release. Items are often backwards incompatible. I suggest alongside the work you've done in this PR, we lock rubocop to an x.y.0 release. This then also gives us a good stable state to try fix up the cop issues in the todo file (Not sure what's in it)

Also on a side-note. The last time rubocop was ran and tested against was 0.64 (Which was quite a long time ago). So it's likely the autogen file is also severely outdated.
We should probably live on an old(er), version for the time being until we fix stuff up.

I'll (hopefully soon) push a commit in which Rubocop version will be pinned (0.75.1).
This should avoid this kind of issue and we'll let Dependabot try to update it to newer version.


Question about site logo animation and padding

Hi,
I just installed this plugin (master version).
It works as attended on any content but the logo.
When I apply any transition to my site logo (inside the navbar, at the top of the viewport), I have this behaviour:

As is, It is not working. Logo with wow class is not visible, I get this HTML after loading the page.

      2

When I put a padding-top >= 0.4 em, it works as expected and I get this HTML after loading the page.

      2

My markup is quite simple:

          Trip
          2
          Go

And the WOW initialization is inside  like this:

Any help is appreciated!

I created a fiddle to reproduce it: http://jsfiddle.net/andreav/9n74Le1t/


Simplify the AppDefinition rendering code

^ that's how you know it's a good refactor!

Thanks for the reivew @cruhland and @larioj


Test: Support testing a range of CLDR versions

Currently, we run our unit and functional tests against the latest CLDR version.
First, we should raise the pros and cons of having tests executed for all supported CLDR versions, e.g., CLDR 25, CLDR 26, CLDR 27. Then, implement it.

Well, this is going to show you two things: When data changes and when syntax changes. Data changes shouldn't concern Globalize. Syntax changes will be noticed when updating which version of CLDR we're using, if tests start to break.
However, the one benefit of testing older versions is that new functionality may not work with old CLDR data, and the easiest way to find that out is to test against the older data. I'd suggest having a nightly or weekly test for old versions, but only testing against the latest version for PRs and pushes.

:+1:


Create left_triangle_pattern.js

Approved. Thanks for your contribution.  Looking forward to read more of your code soon.


EL6 packages do not add service to chkconfig, or remove it on uninstall

The %post section needs to do a /sbin/chkconfig --add service-name, otherwise you get a lot of this in the logs after installing Salt, when you apply a service.running state for the master, minion, syndic, etc.:
[ERROR   ] Command '[u'/sbin/chkconfig', u'--list', u'salt-master']' failed with return code: 1
[ERROR   ] stderr: service salt-master supports chkconfig, but is not referenced in any runlevel (run 'chkconfig --add salt-master')

Similarly, the %preun should be removing the service from chkconfig when the uninstall is not due to an upgrade, but it is not:
if [ $1 -eq 0 ] ; then
  /sbin/service service_name stop >/dev/null 2>&1
  /sbin/chkconfig --del service_name
fi

Closing since el6 is no longer supported.


You need to include some adapter that implements karma.start method! on Karma 1.x

When trying to run my Mocha tests on Karma 1.x I get the error:
You need to include some adapter that implements karma.start method!
Rolling back to Karma 0.13.22 solves the issue.

Please refer to https://github.com/karma-runner/karma/issues/2194 and list the list of plugins you are using.


Direct Package Upgrade: Fixes Cosmos.Direct Package to 3.37.0

Pull Request Template
Description
This PR is bumping up the Cosmos.Direct package version from 3.36.1 to 3.37.0, which includes new headers for Query Advisor
Type of change
Please delete options that are not relevant.

[] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[] This change requires a documentation update

Closing issues
To automatically close an issue: closes #IssueNumber

Query tests are failing please take a look.
https://cosmos-db-sdk-public.visualstudio.com/cosmos-db-sdk-public/_build/results?buildId=52056&view=ms.vss-test-web.build-test-results-tab


Adds composite info about inputs and environment variables.

Adds information regarding the INPUT_ environment variable conversion as discussed at actions/runner#665.

Why:

Closes actions/runner#665
What's being changed:

A documentation block where it explains an exception to a functionality in GitHub Actions. Feel free to update styling and content to match any of the guidelines I may have overlooked and update the checklist below.
Check off the following:

[ ] I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
[ ] For content changes, I have reviewed the localization checklist
[ ] For content changes, I have reviewed the Content style guide for GitHub Docs.

I think this pull request is haunted :S

Converted to draft until the display issue with the code block can be resolved. I'm out of clues here.


Cleanup remapping things

Makes things a little tidier where copied code either isn't needed or can be simpler from where you're using it

i think i've made some uncommitted changes to BinInstaller, before merging this i need to check that and in case commit them


Shows as error if saves dir does not exist

Handles the error just fine, but probably don't want to scare users from start.


fix: remove invalid filetypes containing wildcards from typos_lsp and hyprls

I happened to have created a mapping of filetypes and every server in lspconfig. While inspecting them, I noticed some anomalies and found out that they were invalid/unnecessary misconfigurations that were added by accident.
This PR removes those anomalies.
typos_lsp
filetypes = { '*' },

* filetype pattern is unnecessary. If the filetypes field is omitted completely, lspconfig starts the server on BufReadPost instead of FileType.
hyprls
filetypes = { 'hyprlang', '*.hl', 'hypr*.conf', '.config/hypr/*.conf' },

The author of hyprls and the original PR to lspconfig confirmed that the filetypes with wildcards were added by mistake.
https://github.com/hyprland-community/hyprls/issues/11#issuecomment-2189841216

Hi! I actually did a PR for lspconfig to include hyprls (see neovim/nvim-lspconfig#3137) but it's misconfigured: I mistook filetypes for file name patterns...
However someone fixed my mistake lmao, thx @mehalter
So the lspconfig should work if the hyprlang filetype is defined

Technically, they can stay in the code, useless but doing no harm.
But I wrote this PR because why not and also it actually hinder the plugin I'm writing.

I've tested and made sure both typos_lsp and hyprls properly autostarts and attaches after the changes.


docs(website): add guidance for changing staked TTKOe Amount in Eldfell L3 Provers

…ll L3 Provers

Many changes are being shown in the 'Files changed' section, but this might be due to the timing of when I cloned the repository. In reality, the only addition I am recommending is the following text.
Changing the Staked TTKOe Amount (Only for Eldfell L3 Provers)
In the event that you have staked TTKOe and made an error in the amount, you can change the staked amount at any time here.
However, there are some considerations.
For example, if you've staked 2 TTKOe and want to change the staked amount to 1 TTKOe, the difference of 1 TTKOe will be exited and you will not be able to withdraw it for a week. Be careful when entering the amount.

  Always manually add eight zeros for the decimal '10^8`.

Enter an arbitrary number below. Unlike the UI's Amount per Capacity, the entered amount will be directly reflected.

stake →
amount
rewardPerGas (uint32)
maxCapacity (uint32) (minimum:32)

In the example above, if you enter 1 in the amount and click Write, the amount will change from 2 to 1, and 1 TTKOe will be exited.


resource-aggregate/grpc-gateway: implement timeToLive to commands

commands CREATE,UPDATE,DELETE,RETRIEVE resource and UPDATE metadata
allows to set validUntil as nanoseconds timestamp. After this time
command is considered as expired and cloud don't process it any more.

There are some lint checks failing.

@jkralik FYI https://github.com/plgd-dev/cloud/issues/364#issuecomment-892997316

There are some lint checks failing.

Fix of lint doesn't below here - it is now in each PR. So we need to fix it in separate PR


Don't know where to configure

You need to create a complete maven POM.xml example. I've tried to put the tags below everywhere and it didn't worked.
    <schemaDirectory>src/main/resources/xsd/</schemaDirectory>
<schemaIncludes>
	<include>*.xsd</include>
</schemaIncludes>

Stack overflow helped me. Here is the correct configuration:

			<plugin>
				<groupId>org.jvnet.jaxb2.maven2</groupId>
				<artifactId>maven-jaxb2-plugin</artifactId>
				<version>0.13.1</version>
				<executions>
					<execution>
						<goals>
							<goal>generate</goal>
						</goals>
					</execution>
				</executions>
				<configuration>
					<schemaDirectory>src/main/resources</schemaDirectory>
					<schemaIncludes>
						<include>xsd/*.xsd</include>
					</schemaIncludes>
				</configuration>
			</plugin>

Wiki (https://github.com/highsource/maven-jaxb2-plugin/wiki/) has quite a number of pages which include the plugin configuration, for instance:

https://github.com/highsource/maven-jaxb2-plugin/wiki/Specifying-What-To-Compile

Releases include sample projects:

https://github.com/highsource/maven-jaxb2-plugin/releases

These are complete working projects.
And there's a huge number of test projects in the repository:

https://github.com/highsource/maven-jaxb2-plugin/tree/master/tests

Please feel free to contribute to Wiki/documentation if you still think these resources are not sufficient.

Adding <configuration>..</configuration> inside the <execution>..</execution> tag as mentioned in the page Use-Separate-Target-Directories-for-Separate-Executions doesnot work for 0.14.0 release

@aratnam86 Please file a separate issue and provide a minimal reproducing project and full Maven build logs. "Does not work" is not actionable.

Closing as the OPs question is answered.


Play button not working on mobile devices

Audio is not playing on clicking of play button in mobile devices.

how to bring button  since its just a | line like

how to bring button  since its just a | line like


enhance(data): Initialize and retain state

Need to add some document and we can wrap up this setup enhancement.


Metadata Update

Hello,
Your dataset was added to CoronaWhy (https://www.coronawhy.org/) Data Lake on Dataverse as a piece of common COVID-19 data frame https://datasets.coronawhy.org/dataset.xhtml?persistentId=doi:10.5072/FK2/3CKDM4
Would you be willing to help with the maintenance of your dataset in Dataverse, e.g. adding the relevant metadata and keeping the dataset up-to-date? That will help to make the dataset findable and accessible for the medical science community.

Hi,
Thank you for your message. Sure, OK. I appreciate that! ⭐
Keep in touch.
Best wishes,

@reeshmabijosh The update directly via Dataverse, right?

Hello Michal,
Thanks for your willingness to contribute.
Please register in CoronaWhy Dataverse https://datasets.coronawhy.org/ and
you will get the necessary permissions for editing your dataset.
Then please add relevant metadata - description and keywords to your
dataset.
This is an example of a dataset with good metadata
https://datasets.coronawhy.org/dataset.xhtml?persistentId=doi:10.5072/FK2/TZMOTL
Thanks
Reeshma K
On Sat, Jul 4, 2020 at 7:09 AM Michal<EMAIL_ADDRESS>wrote:

@reeshmabijosh https://github.com/reeshmabijosh The update directly via
Dataverse, right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mbiesiad/COVID-19-World-Data/issues/1#issuecomment-653752503,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALHC2U5JISH57BHZU4FBEGDRZ4EVZANCNFSM4OPKVYLA
.

My pleasure! I'll take care of it ASAP (probably by the end of this week). Thank you for your help & answer.
Best wishes,


Theme: Copying of a string from the logs loses the first character

Often, for verification purposes, one needs  to copy something from the system logs, for example an IP address.
When Webmin uses "Authentic", the copied value "loses" always the first character.
For example: when copying 123.456.789.000,  the pasted value is 23.456.789.000.
Issue found using Firefox 47.0 and Chrome 51.0, both with Ubuntu 12.04 and Windows 10.

Hi,
Interesting but I can't reproduce it. I went to System Logs, click view on one of the log files, selected the string and copied it. All is fine.
What theme version are you using? Did you try disabling extensions or running in incognito mode? Did you restart Webmin after applying theme update?

Hello,
I'm using the version 18.00 of Authentic, on Webmin 1.801, installed on Ubuntu 14.04.4 (LTS); the browser encoding is set to Unicode.
I've tried also after disabling all the extensions, as well after restarting Webmin, to no avail.
This doesn't happen using the default themes of Webmin; strange problem indeed.

Yes, please upgrade to version 18.02 it fixes some CodeMirror issues.

18.02 fixes this issue. I am relieved...thank you for your help.


[bug] Remove "sklearn_is_patchedget_patch_map" from sklearnex/init.py

Description
"sklearn_is_patchedget_patch_map" is not a function in sklearnex, and is not imported. Looks to be unnecessary
Changes proposed in this pull request:

Remove "sklearn_is_patchedget_patch_map"  from sklearnex.__all__

/intelci: run


Revert "allow 0 block time"

This reverts commit dbad05599b2d2059e45c480fac8817d1135d5da1.

Well, you need to explain a bit why...

@tillkruss I am resubmitting the exact same PR as the one closed #23105 and tests are now passing. Closing a PR just because a test that randomly fails happen to fail in a totally unrelated PR has no point.

@jmarcher exactly. And now I should re-write the exact same comments.

This reverts commit dbad055.
Reasons to revert:
blocking for ever is in contradiction with job timeout and maybe Redis read_write_timeout.
It causes problems for deployment/updating code. It makes restarting the workers harder for horizon or other control systems.
In horizon currently the default timeout is set to zero. Which now means forever, but it used to mean no timeout at all. https://github.com/laravel/horizon/blob/1.0/src/Connectors/RedisConnector.php
Other implementations like SQS does not allow for long-polling/blocking for more than 30 seconds. They might have other good reasons for the restriction.

@halaei: Please resubmit with test, so we don't run into the same issue in the future.

I will not.

Is the profile pic intentionally ironic?

@ryanwinchester my pic 😁 is for a couple of years ago. I didn't tested my code, they give me a sign "test first don't let the bugs in"


[FEATURE] Add Calendar for Start/End Date Selection in Project and Experience Sections

Description
Improve the usability of the project and experience sections by adding a calendar functionality for selecting start and end dates. This enhancement will allow users to input accurate timeframes effortlessly and enhance the overall user experience.
Proposed Solution:

Implement an intuitive calendar widget for seamless date selection.
Integrate the calendar widget into the start and end date input fields.
Ensure the calendar widget is user-friendly and supports single-click date selection.
Validate selected dates to maintain data integrity and prevent invalid date ranges.

Screenshots
No response
Additional information
Task:

Develop an elegant calendar widget for convenient date selection.
Integrate the calendar widget into start and end date input fields.
Implement robust validation logic to ensure valid date ranges.
Display selected dates in a visually pleasing format.
Thoroughly test the functionality to ensure a smooth user experience.

Expected Behavior:
Users will effortlessly select start and end dates using the calendar widget, improving accuracy in the project and experience sections. The integration will be intuitive, with visually appealing date displays. The calendar functionality will enforce valid date ranges, enhancing data reliability.
Please assign this issue to me.

kindly assign this issue to me . Thank You

Hey there , This Issue seems interesting to work on.
Please assign me this issue !!

Hello, @Cipher-08 Actually I opened this issue because I wanted to work on it.


Unversioned skypack turbo link is broken at the moment

https://cdn.skypack.dev/@hotwired/turbo => https://cdn.skypack.dev/error/build<EMAIL_ADDRESS>/*
 * [Package Error] "<EMAIL_ADDRESS>could not be built.
 *
 *   [1/5] Verifying package is valid…
 *   [2/5] Installing dependencies from npm…
 *   [3/5] Building package using esinstall…
 *   Running esinstall...
 *   Failed to load<EMAIL_ADDRESS> *     Unexpected token (818:8) in @hotwired/turbo/dist/turbo.es2017-esm.js
 *   Install failed.
 *   Install failed.
 *
 * How to fix:
 *   - If you believe this to be an error in Skypack, file an issue here: https://github.com/skypackjs/skypack-cdn/issues
 *   - If you believe this to be an issue in the package, share this URL with the package authors to help them debug & fix.
 *   - Use https://skypack.dev/ to find a web-friendly alternative to find another package.
 */

console.warn("[Package Error] \"<EMAIL_ADDRESS>could not be built. \n[1/5] Verifying package is valid…\n[2/5] Installing dependencies from npm…\n[3/5] Building package using esinstall…\nRunning esinstall...\nFailed to load<EMAIL_ADDRESS>Unexpected token (818:8) in @hotwired/turbo/dist/turbo.es2017-esm.js\nInstall failed.\nInstall failed.");
throw new Error("[Package Error] \"<EMAIL_ADDRESS>could not be built. ");
export default null;

JIC somebody else is not very used to CDNs, as I am, you can fix this for the time being specifying the previous version on the link:
import hotwiredTurbo from 'https://cdn.skypack.dev/<EMAIL_ADDRESS>


Update non-working components

I tested Micro-SD Card USB Reader, it doesn't work

Thank you for your feedback.


Ability to run arbitrary scripts before a commit is made

Is your feature request related to a problem? Please describe.
I'm working on integrating CrowdIn with a project using "changesets". I'd like to run a script that adds a file to be committed alongside the translations.
Describe the solution you'd like
A before_commit_script option in the action for some arbitrary bash code to be run before files are committed to the localization branch.
Describe alternatives you've considered
I have a different github workflow rigged up but it would be nice to not need an additional workflow.

Hi @probablyup, thanks for the request!
Currently, you can disable pull request creation by the Action and use a separate Action for this after making the necessary changes:
name: Crowdin Action

on:
  push:
    branches: [ main ]

jobs:
  synchronize-with-crowdin:
    runs-on: ubuntu-latest

    steps:
      - name: Checkout
        uses: actions/checkout@v3

      - name: crowdin action
        uses: crowdin/github-action@v1
        with:
          upload_sources: true
          upload_translations: true
          download_translations: true
          push_translations: false             # Do not commit & push changes
          create_pull_request: false         # Do not create a PR
        env:
          GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
          CROWDIN_PROJECT_ID: ${{ secrets.CROWDIN_PROJECT_ID }}
          CROWDIN_PERSONAL_TOKEN: ${{ secrets.CROWDIN_PERSONAL_TOKEN }}

      - name: Custom script
        run: ./script.sh

      - name: Create Pull Request
        uses: peter-evans/create-pull-request@v5
        with:
          commit-message: 'New Crowdin translations'
          title: 'New Crowdin Translations'
          body: 'New Crowdin translations by [Crowdin GH Action](https://github.com/crowdin/github-action)'
          branch: 'feat/l10n-crowdin-translations'

Visit the Create Pull Request GH Action page to see all the available options.
P.S. I didn't test this example, but the workflow should look like the above.

We are looking for a similar option, but in our case to run linting & normalisation scripts before the commit.

Hi @renchap, I just saw your solution and it looks pretty good 🙂

Hi @renchap, I just saw your solution and it looks pretty good 🙂

Yes, and I understand why it would be hard to do in the action, because your command will be ran from the container, where you most probably dont have the dependencies you need.
Related to this, I was not expecting the files generated by the action to be owned by root:root, you may want to have their permissions fixed before the action finishes.


Follow location not working

I suppose the follow location should work on mobile?
Doesn't seem to do so.
The location cross button on mobile website keeps flashing, is this normal or did I get the  feature wrong

Ok works


I clobbered some files again

Compare current main to last release, esp make-rdf steps in project.makefile

https://github.com/microbiomedata/nmdc-schema/compare/a..b


Terminal closing message

Hi, this is a follow-up bug report on the problem I reported in https://github.com/hardcoreplayers/ThinkVim/issues/93#issuecomment-593312974.
When I run FzfPreviewDirectoryFiles or other preview commands, I see the following message on ESC or Enter.
-- TERMINAL --
Close "term://.//7785:cat '/tmp/nvim0PUsUl/3'|'/home/marco/.cache/vim/dein/repos/github.com/junegunn/fzf/bin/fzf' --multi --reverse --ansi
--bind=ctrl-d:preview-page-down,ctrl-u:preview-page-up,?:toggle-preview   --expect=ctrl-v,ctrl-x,ctrl-q,ctrl-t --prompt="DirectoryFiles> "
--preview='[[ "$(file --mime {})" =~ binary ]] && echo "{} is a binary file" || head -100 {-1}'  --no-height > /tmp/nvim0PUsUl/2;#FZF"?
[Y]es, (N)o, (C)ancel:

Here's a screencast:

Might that be related to this plugin?

I have the same question.
Now, I  remove the "set confirm" form the init.vim, it works.
But I still want to find way to get the "set confirm" back, it's useful for remender me to save buffer

I cant reproduce.
Please tell me the version of neovim and fzf.

A similar problem has also occurred in fzf.vim, so it may not be a problem with this plugin.
https://github.com/mhinz/neovim-remote/issues/47

Version:
$ fzf --version
0.17.4 (f0fe79d)

$ nvim --version
NVIM v0.4.3
Build type: Release
LuaJIT 2.0.5
Compilation: /usr/bin/cc -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -O2 -DNDEBUG -DMIN_LOG_LEVEL=3 -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fdiagnostics-color=always -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -I/build/neovim/src/build/config -I/build/neovim/src/neovim-0.4.3/src -I/usr/include -I/build/neovim/src/build/src/nvim/auto -I/build/neovim/src/build/include
Compiled by builduser

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/share/nvim"

Run :checkhealth for more info

For me, commenting out set confirm from the thinkvim config also fixes the issue.

0.17.4 is the 2018 version. https://github.com/junegunn/fzf/releases/tag/0.17.4
Try the latest release.

I updated to 0.20.0, same issue.

I actually don't understand where this issue could come from. Is that related to fzf, fzf.vim, fzf-preview.vim, my xfce4-terminal or neovim? It looks like fzf-preview.vim calls fzf to get the file list and displays it. The call to fzf goes through a shell which is closed at the end for which nvim asks for confirmation.

This issue appeared for me when I updated my plugins (including fzf and fzf-preview). I did not update neovim however, so I am guessing that this behavior appeared from one of the updated plugins.

This issue appeared for me when I updated my plugins (including fzf and fzf-preview).
yes .when update ,i aslo get this problem.

Solved by changing the buffer's bdelete to bdelete!.
Please update plugin.

Thanks a lot, it works.


Add CreateVariable Code Action support for Record Literals & Lambdas

Purpose

Add CreateVariable Code Action support for Record Literals & Lambdas

Fixes #21868 - Add CreateVariable Code Action support for Record Literals & Lambdas
Fixes #21509 - Enable Disabled CodeAction Test
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #21867 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21867      +/-   ##
==========================================
- Coverage   14.72%   14.67%   -0.06%
==========================================
  Files          51       51
  Lines        1399     1404       +5
  Branches      214      216       +2
==========================================
  Hits          206      206
- Misses       1177     1182       +5
  Partials       16       16

Impacted Files
Coverage Δ

tool-plugins/vscode/src/core/extension.ts
28.11% <0.00%> (-0.27%)
:arrow_down:

tool-plugins/vscode/src/extension.ts
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06a0d78...bdc253e. Read the comment docs.

Closing in favor of https://github.com/ballerina-platform/ballerina-lang/pull/21916


Issue#72 Make domain validation true by default

Hi thanks for your PR
Good to merge, might be good to update the README though!

Thanks!


Fix the Node bootstrap problem

How to categorize this PR?

/kind bug
What this PR does / why we need it:
Currently, when a Shoot requests caches for all upstreams that are used by Shoot system components, things regress in several aspects. In OSS Gardener these upstreams would be quay.io for calico images, registry.k8s.io for kube-proxy and others, eu.gcr.io for the rest). Example extension configuration for that case:
  extensions:
  - type: registry-cache
    providerConfig:
      apiVersion: registry.extensions.gardener.cloud/v1alpha1
      kind: RegistryConfig
      caches:
      - upstream: eu.gcr.io
        size: 10Gi
      - upstream: quay.io
        size: 10Gi
      - upstream: registry.k8s.io
        size: 10Gi

On creation of such Shoot, image pull of Shoot system components is abnormally high. quay.io/calico/cni, quay.io/calico/calico-node and registry.k8s.io/kube-proxy images are pulled in times like 2m, 3m or even 5m. Usually, it takes up to 10s to pull these images from the upstream.
The reason for this behaviour is kind of the design of the extension. We configure a containerd mirror/registry using the Service IP of registry cache Service in the Shoot cluster. In order to have the Service's cluster IP reachable from a newly joining Node, the networking has to be set up and kube-proxy and calico components to be running. Otherwise, containerd cannot reach the Service's cluster IP and falls back to the upstream registry.
The reason for the abnormal high image pull times are that initially (until kube-proxy starts running) image pull requests from containerd to the Service's cluster IP time out after 30s. After this timeout, the fallback to the upstream (for example eu.gcr.io or quay.io) happens. We see that containerd does many requests - HEAD request to resolve the manifest by tag, GET request for the manifest by SHA, GET requests for blobs. Each of these requests times out in 30s and the the fall back to the upstream host happens. At the end image pull succeeds but it succeeds in minutes. Yesterday I was doing experiments with the docker.io/library/alpine:3.13.2 and eu.gcr.io/gardener-project/gardener/ops-toolbelt:0.18.0 in a setup where the Service IP of containerd is misconfigured (Service IP deleted and containerd refers to a no longer existing cluster IP):

Image pull from the upstream for docker.io/library/alpine:3.13.2 takes ~2s while image pull of the same image with unavailable registry cache takes ~2m.2s.
Image pull from the upstream for eu.gcr.io/gardener-project/gardener/ops-toolbelt:0.18.0 takes ~10s while image pull of the same image with unavailable registry cache takes ~3m.10s.

We see that after kube-proxy stars running, requests to the Service IP of the registry-cache Service no longer time out in 30s (dial tcp <IP_ADDRESS>:5000: i/o timeout) but are rejected right away (dial tcp <IP_ADDRESS>:5000: connect: connection refused).
We believe that this is because kube-proxy starts running and configures iptable rules on the Node for the Service IPs. At that time the registry cache Pods are not yet running, hence the Service does not have any available Endpoints. Most probably in that case kube-proxy configures a "black hole" for such a Service because it does not have any available Endpoints.
In total, with the current design of the extension:

Currently we cannot cache much of the Shoot system components. With the currently approach we cannot cache calico and kube-proxy images and all the images that are created at the same time with them (CSI drivers, apiserver-proxy, node-problem detector and others) because calico and kube-proxy are not yet running on the Node and haven't set up the netwoking so that containerd to be able to pull images from the cache.
We regress the Node creation time a lot (>= 10 min when I tested in the local setup with extension for an AWS Shoot). This is because the above-described behaviour - when kube-proxy is yet running, a containerd request times out after 30s and then the fallback to the upstream registry happens. For example 6 containerd requests for image pull result in > 3min image pull time. Image pulls for Shoot system components like calico and kube-proxy that usually take seconds now take minutes because of this.

To address these issues, the extension is redesigned in the following. During the OSC mutation, we no longer append the hosts.toml file with the registry config. Instead we append an new systemd unit. The systemd unit waits for each cache to be available (its Service IP starts returning HTTP 200) and only after this it creates the corresponding hosts.toml file. For the uninstall case - a DaemonSet is deployed and it cleans up the hosts.toml files and the unit (if needed).
The drawback of this approach is that the registry-cache extension won't be able to cache Shoot system components if a cache for the corresponding upstream is requested. However, with the new design, we no longer regress the image pull of the Shoot system components.
Which issue(s) this PR fixes:
Part of #3
Special notes for your reviewer:
N/A
Release note:

NONE

Cloning into 'gardener'...
fatal: unable to access 'https://github.com/gardener/gardener.git/': The requested URL returned error: 403
make: *** [Makefile:120: ci-e2e-kind] Error 128

/test pull-gardener-extension-registry-cache-e2e-kind

  [FAILED] Unexpected error:
      <*errors.StatusError | 0xc0006acaa0>:
      error dialing backend: dial tcp <IP_ADDRESS>:9443: connect: connection refused
      {
          ErrStatus: {
              TypeMeta: {Kind: "", APIVersion: ""},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "error dialing backend: dial tcp <IP_ADDRESS>:9443: connect: connection refused",
              Reason: "",
              Details: nil,
              Code: 500,
          },
      }
  occurred
  In [It] at: /home/prow/go/src/github.com/gardener/gardener-extension-registry-cache/test/common/common.go:107 @ 10/16/23 12:53:09.433

Seems like a networking error. The test is passing locally.
/test pull-gardener-extension-registry-cache-e2e-kind

/assign