support IP verification and de duplication

Please provide a description of this PR:
support proxy.IPAddresses verification and de duplication

@zc2638: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
27e3901d2dd2cb1551225987903aa3194b53dbef
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zc2638: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
27e3901d2dd2cb1551225987903aa3194b53dbef
link
/test gencheck_istio

unit-tests_istio
27e3901d2dd2cb1551225987903aa3194b53dbef
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Can you help explain what bug is being fixed by this? Thanks!

Hello, this is not a bug.
On the original basis, it supports IP repeat filtering, and makes the code look more lovely.

I would strongly prefer not to refactor code that has been stable for 3
years. It introduced substantial risk ina  critical code path and offers no
benefit to users
On Wed, Sep 8, 2021, 8:08 PM zc @.***> wrote:

Can you help explain what bug is being fixed by this? Thanks!
Hello, this is not a bug.
On the original basis, it supports IP repeat filtering, and makes the code
look more lovely.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/35084#issuecomment-915724466, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXIVSE7X2SCO34HRURTUBAQJHANCNFSM5DWD3N3A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

network.getprivateips will obtain all IP addresses on the node.
If the IP addresses of multiple network cards are the same, duplicate IP addresses will be generated.
Although this network configuration may not be common, we should avoid it.

@zc2638: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
27e3901d2dd2cb1551225987903aa3194b53dbef
link
/test gencheck_istio

unit-tests_istio
27e3901d2dd2cb1551225987903aa3194b53dbef
link
/test unit-tests_istio

integ-istiodremote-k8s-tests_istio
96da19bdc05db15ebe64fd5a3ad4845cbe1bb7c0
link
/test integ-istiodremote-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/reset

@zc2638: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-istiodremote-k8s-tests_istio
96da19bdc05db15ebe64fd5a3ad4845cbe1bb7c0
link
/test integ-istiodremote-k8s-tests_istio

integ-security-multicluster-tests_istio
96da19bdc05db15ebe64fd5a3ad4845cbe1bb7c0
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

https://serverfault.com/questions/705919/the-same-ip-on-multiple-interfaces#:~:text=You cannot use the same,address on the bridge itself.
Maybe we can do this if we see a real world case where this would help? Otherwise I am worried about making changes that do not add benefit but add risk.


Pushing an empty array to app configuration results in a configuration which cannot be read by the CLI

Hi.
I have an issue related to #731, and I understand the reasons given there for the behaviour but I'm not sure this helps. We are using the AzureAppConfigurationPush@6 task to push the config and using the CLI to pull it down so we can compare
I have a config file that looks like this:
{
  "MyProfile": {
       "MYTEST": {
	    "Features": []
        }
   }
}

if I upload this config it creates this in the config service:

as you can see it creates [] as the value.
if I try and get this config with the CLI tool using this command line:
az appconfig kv export --name "namehere" --label "dev_stage" --prefix "ContUsFeatures_" --key "ContUsFeatures_*" --separator ":" --destination "file" --path "./temp.json" --format "json" --yes --skip-features --skip-keyvault "True"
then it works ok.
if I then update the config to this:
{
  "MyProfile": {
       "MYTEST": {
	    "Features": [
                      "MyFeature"
                 ]
        }
   }
}

and then push the config again then when I look at the config in the config explorer I get this:

As you can see it has not changed anything, its added the array element 0 now (correctly), but left the unindexed version with the [].
If I use the command line to get the config I now get an error:
Failed to export key-values to file. Fail to export key-values.list indices must be integers or slices, not str
we are using text/plain as our default when pushing config, but I have tried using application/json with the same results
This is causing us to be unable to read config that we have changed if we add elements to an array, or remove them from an array (which is how we ran into this).
I would expect the CLI to handle the empty array->populated array->empty array cases.
in our case we are getting the config before we push to validate the changes in config, so this causes all of our pipelines that do this to fail as soon as we go from empty to populated array, or from populated to empty.

Do you import with strict mode enabled as detailed here? The reason I ask is because arrays can be tricky with leftover values. If you downsize the array locally, and import it, without strict mode the service will still end up with additional items in the array.
Additionally, strict mode may be able to help here since it should remove the brackets.
Finally, I don't see much value in [] being imported in your example above. This behavior must have been around for a while now without my notice, so will think if I'm missing something, but it seems like it should be changed to not import anything for empty arrays. Does that sound right to you? Or do you have some value in having the array brackets imported for empty array.

Since we flatten arrays when content-type is not "application/json", I agree with @jimmyca15 that nothing should be imported for a key-value with empty array.  If there is any value in an imported empty array, specifying the json content-type should enable this. This way, a change in the array will overwrite the single imported kv which initially had an empty array as the value.

We're happy without strict mode, we just don't want the default behaviour to create invalid data with 'normal' operations.

@samholder I just realized you mentioned the behavior that imports an empty array as brackets is in the app configuration push task. Could you provide us with more information on the parameters you use when pushing configuration settings to your store?
cc @MaryanneNjeri

Our job looks like this:
  - task: AzureAppConfigurationPush@6
    displayName: 'Update app configuration `${{ parameters.prefix }}` | `${{ parameters.contentType }}`'
    inputs:
      azureSubscription: '${{ parameters.azureResourceManager }}'
      appConfigurationEndpoint: '${{ parameters.appConfigurationEndpoint }}'
      configStoreName: '${{ parameters.configStoreName }}'
      configurationFile: '${{ parameters.configurationFile }}'
      ${{ if eq(parameters['contentType'], 'keyvault') }}:
          contentType: 'application/vnd.microsoft.appconfig.keyvaultref+json;charset=utf-8'
      ${{ else }}:
          contentType: '${{ parameters.contentType }}'
      separator: '${{ parameters.separator }}'
      label: '${{ parameters.label }}'
      prefix: '${{ parameters.prefix }}'
      tags: "{\"deployed_by\": \"pipeline\", \"repo\": \"$(Build.Repository.Name)\", \"commitID\": \"$(Build.SourceVersion)\", \"codeVersion\": \"$(tag.latest)\"}"
      strict: false # Any key-values in the store with the specified prefix and label that are not included in the configuration file will be deleted.

The context type is text\plain
separator is :
I don't think anything matters but let me know if you need any of the other values

The app configuration push task will need an update to exclude empty brackets from import

Sounds good!
On Wed, 2 Aug 2023, 11:02 MaryanneNjeri, @.***> wrote:

The app configuration push task will need an update to exclude empty
brackets from import
—
Reply to this email directly, view it on GitHub
https://github.com/Azure/AppConfiguration/issues/788#issuecomment-1661921691,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAP2FSW4XCR36UZ6CN3EAWLXTIQUZANCNFSM6AAAAAA2YYPBWM
.
You are receiving this because you were mentioned.Message ID:
@.***>

@samholder Hello the latest version of the Azure App configuration 6.2.0 has an update to exclude empty brackets from import. Please let me know if this helps


Implementing Purging

I noticed on the docs that Purging has not yet been implemented.
Do you plan to implement this and have any esteemed timeframes?
Thanks
Terry

I postponed looking into it when I made the transformer, just to get it out. But I'll look into it.

Added to 1.1.0.


[web3torrent] Downloader begins seeding post-download, but UI does not make this clear

There is no UI that tells the downloader to stay on the page because now they are seeding.

Fixed in https://github.com/statechannels/monorepo/pull/2242


gluon save/load optimizer states

@piiswrong

I think it's better to also serialize the optimizer object so that learning rate schedule is preserved.

rebased to latest master just now


Add zeek.TypedEncoding and fix group-by mixed types

This commit adds zeek.TypedEncoding to make better sense of
zvals paired with zeek Types and it fixes a bug in group-by
where the different types encountered for the group-by key
fields would cause problems.
This commit got long because I kepted running into zval bugs
knowing when/if the zval is a printable container or a unprintable
leaf container.  The String method on zeek.TypedEncoding now
takes care of thie logic and many places in the code that
previously carried around seprate zeek.Type and []byte (zval)
is now simplified and easier to follow.
Also, we added zval.Encoding types many places where []byte
meant zval.Encoding.
Along the way, we added an Encode method to the zeek.Value interface
which makes it easier and less error-prone to build up the
zval.Encodings from zeek.Values.  This also gets us very to close
to supporting machine types in the zval raw format as we
merely need to change the way Encode works (and add a Decode method
to take the native zeek type and encode it as machine zval.Encoding)
Given the simpler model for value encoding, we also fixed cut to
encode the record zval directly and to properly handle variationsa
of the type of any given cut field.

Just rebased to merge in the zeek.Type interface change to expr/sort


Fix autodeploy

Follow on from https://github.com/RonnyPfannschmidt/iniconfig/pull/20.
I'd put setuptools_scm in the wrong CI file in https://github.com/RonnyPfannschmidt/iniconfig/pull/20/commits/73f802bcbec58e8e4aafd753a057e1c956718ce6!

Hooray, it worked!

https://github.com/RonnyPfannschmidt/iniconfig/runs/1266411422?check_suite_focus=true
https://test.pypi.org/project/iniconfig/1.1.2.dev12/

Useful to deploy to TestPyPI, we can see the README didn't quite render properly compared to https://pypi.org/project/iniconfig/1.1.1/, maybe from the setup.cfg re-order?


Review XSS threat from JSON.stringify

So I just read this article about XSS vulnerabilities in React SSR that result from using JSON.stringify to serialize data, and I immediately thought of y'all. I went through the current codebase's use of JSON.stringify, and I think that they are all safe, but it's been a while and I don't exactly understand all of the uses. It could definitely use another pair of eyes.
It's worth noting that the case I was most worried about was the reading out of late arrivals, but that helpfully uses a wrapper function to escape HTML entities (renderMiddleware.js#981). And the code that reads out the initial data seems to use express-state, which also handles safely encoding (renderMiddleware.js#938). So the two most worrisome cases are taken care of, but it'd still probably be good to get another pair of eyes looking at the code. Could someone else volunteer to do an audit?

One use I cannot for the life of me decipher is at renderMiddleware.js#945:
	renderScriptsAsync([{
		text: `${res.locals.state};rfBootstrap();`,
	}], res);

I can't figure out where res.locals.state gets set, if ever. Probably harmless, but worth double-checking.

@aickin IIRC that's part of express-state. The stuff that gets exposed with res.expose ends up there.
Also, if anybody wants to get rid of express-state, I'll thumbs-up that PR. We're not really using it much, and it ties react-server to express. It could be replaced by properly-escaped JSON.stringify. ;)

@roblg got it, then it should be safe.
The other one that scared me at first was in FragmentDataCache.jsx, but then I realized it gets sanitized since it's inside JSX.

@aickin great article & reminder...I think this is still a good review to do.  The serialize-javascript library suggested in the article looks like a great option.  I could see issues with these areas:

https://github.com/redfin/react-server/blob/master/packages/react-server/core/ReactServerAgent.js#L101
https://github.com/redfin/react-server/blob/master/packages/react-server-core-middleware/src/coreJsMiddleware.js#L28
https://github.com/redfin/react-server/blob/master/packages/react-server/core/logging/response.js#L76
https://github.com/redfin/react-server/blob/master/packages/react-server/core/ReactServerAgent/Cache.js#L193
https://github.com/redfin/react-server/blob/master/packages/react-server/core/renderMiddleware.js#L552


NATIVE-216: Open keyboard on search

Could you also fix the closing of the keyboard on the landing page please? Would be nice

Could you also fix the closing of the keyboard on the landing page please? Would be nice

Landing Page:
I did not manage to allow taps on results to open them directly. Instead the keyboard is only closed. But the keyboard is opening on search.
Search Modal:
If you click on a result inside the search modal, and navigate back to the search modal, the keyboard will not open because the component is already mounted. I was not able to set the focus again like e.g. inside componentDidUpdate.

Landing page: I tried some stuff and got it to persist the tap. The place where this has to be done is not that easy to find though if not really familiar with the project yet. Have a look at the withPayloadProvider and the last ScrollView in the render method. If you add keyboardShouldPersistTaps there, it should work.
SearchModal: I'd say this is fine. I guess as a user I may even be irritated if I move back to the search and the keyboard opens up again.

Regarding the autofocus on the landing page, I'm not really sure if it is good. What do you think @maxammann @Schedulaar ?

Just tested this on Android:

I think we should not focus automatically on the landing screen
Opening when starting to search works
behavior when pressing back after clicking a search result is good

Please try to push an empty commit to fix the build: git commit -m "NATIVE-???????: Trigger CI" --allow-empty

Ready for merge :)


Add constraint and config options

Adds config for warden to not intercept 401 requests
This config allows apps to change the default behaviour of intercepting 401 requests, by including an initialiser:
GDS::SSO.config { |config| config.intercept_401_responses = false }.
For example apps that also include basic http auth would probably need this option.

Adds authorised user constraint so that consumer apps can easily add a permission based constraint.

Add PermissionDeniedError error class under GDS::SSO namespace and a warning log message that the existing PermissionDeniedException should be deprecated on a new major release.

Extract the user authorisation logic into a separate class and Re-use authorisation logic in the controller_methods class

more info : https://trello.com/c/qb1qpwnr/1369-additional-functionality-to-gds-sso-gem-for-intercepting-401s-and-providing-a-route-constraint

Great stuff. This all looks good to me. Let's see if the #govuk-publishing-platform team are happy. I'll drop them a ping.


Failing tests in local environment

Describe the bug
The following tests are failing for me on my local environment:
[ERROR] Failures:
[ERROR]   AlertingServiceTest.testLabelsChange:710 expected: not <null>
[ERROR]   DatasetServiceTest.testDatasetLabelChanged:188->withExampleSchemas:365->lambda$testDatasetLabelChanged$47:194->BaseServiceTest.withExampleDataset:614->lambda$testDatasetLabelChanged$46:205->waitForUpdate:396 expected: not <null>
[ERROR]   DatasetServiceTest.testSchemaAfterData:257 expected: not <null>
[ERROR]   SchemaServiceTest.testValidateRun:85 expected: not <null>
[INFO]

These tests do not fail in CI.

This is occurring due to the amq broker is not delivering messages

This appears to be an environment


Add LIO_READV and LIO_WRITEV on FreeBSD

They are used along with lio_listio for non-POSIX vectored operations.

r? @Amanieu
(rust-highfive has picked a reviewer for you, use r? to override)

@bors r+

:pushpin: Commit 57683914e70f9b5ca0f1e24d29fd927720b81f44 has been approved by Amanieu

:hourglass: Testing commit 57683914e70f9b5ca0f1e24d29fd927720b81f44 with merge bdf2f4c3804561bf4b3aaea0da9e724f9501fba7...


Text objects don't work inside of injected languages

Describe the bug
Text objects don't work inside of injected languages.
Pressing daa here doesn't do anything.

Related to #27
To Reproduce
Steps to reproduce the behavior using the following textobjects config:
textobjects = {
  select = {
    enable = true,
    lookahead = true,
    keymaps = {
      ["aa"] =<EMAIL_ADDRESS>      ["ia"] =<EMAIL_ADDRESS>    },
  },
},

Open a new buffer
Type :set ft=vim
Insert this code and move your cursor to the 2nd parameter:

lua <<EOF
test(1, 2)
EOF

Press daa (nothing happens)

Output of :checkhealth nvim_treesitter

nvim_treesitter: health#nvim_treesitter#check
========================================================================
## Installation
  - WARNING: `tree-sitter` executable not found (parser generator, only needed for :TSInstallFromGrammar, not required for :TSInstall)
  - OK: `node` found v16.10.0 (only needed for :TSInstallFromGrammar)
  - OK: `git` executable found.
  - OK: `cc` executable found. Selected from { vim.NIL, "cc", "gcc", "clang", "cl", "zig" }
    Version: cc (Debian 8.3.0-6) 8.3.0
  - OK: Neovim was compiled with tree-sitter runtime ABI version 13 (required >=13). Parsers must be compatible with runtime ABI.

 There is however a problem that the mappings are only set for the parent language. Feel free to open a new issue for that one. This can however maybe not avoided since every language can be injected in any other language and we don't want to set unsupported mappings.

@theHamsta Would you be opposed to a PR that possibly also checks for injected languages in the injections.scm queries and then adds those potential text objects as mappings?


@FeignClient and manual Feign Client

Here's my scenario:
I have a library used by various Spring Boot applications. The library has a dependency to some ServiceProvider REST API. I can't simply create a @FeignClient inside my lib, because if the App that's using it also declares one to the same interface, it doesn't start up because of a NoUniqueBeanDefinitionException.
I help myself around this by using auto configuration in the lib like so:
@Configuration
@Import(FeignClientsConfiguration.class)
public class LibAutoConfig {

@Bean
@ConditionalOnMissingBean(ServiceProvider.class)
public ServiceProvider serviceProvider(Client client, Encoder encoder, Decoder decoder) {
	System.out.println("CREATING NEW SERVICE PROVIDER");
	return HystrixFeign.builder()
			.client(client)
			.encoder(encoder)
			.decoder(decoder)
			.contract(new SpringMvcContract())
			.target(ServiceProvider.class, "http://service-provider");
}

}
Which works, at the end of the day. BUT - I can see in the logs that the manually built client is always created, even if the host application supplies something like
@FeignClient(name = "service-provider")
public interface ProviderClient extends ServiceProvider {}

I can use the ServiceProvider from both inside the app and the library, I just don't know how this works... shouldn't the library be re-using the @FeignClient from the host?
Full example available here: https://github.com/thorstenfrank/multi-feign-clients

Maybe it is an order issue?  The auto configuration may be running before we create the Feign clients.

Possible, yes - but still, I have two feign clients (one created automatically, one manually) for the same endpoint. And I can autowire the endpoint interface anywhere throughout my application and it works - so how come there's no clash?
Like I said - I'm glad it works, just wanting to understand.

The @FeignClient bean is created first. Even though the auto configuration bean method is annotated as @ConditionalOnMissingBean(type = ServiceProvider.class), when doing this inside the method body (with an autowired ApplicationContext):
ctx.getBeansOfType(ServiceProvider.class)

it returns the automatically created @FeignClient, to be more exact a Proxy with a HystrixInvocationHandler and the target is of type ProviderClient(which is the interface annotated with @FeignClient)

If you created the Feign client manually and return it as a bean in the application using the lib does it work as you expect?

@ryanjbaxter if I create the Feign client manually, everything behaves as expected - the conditional in the library recognizes its existence and so does not create a second one.
Can you point me to the place in the Feign implementation where the annotated beans are created?

They are created in FeignClientsRegistrar.

Well, I love a good puzzle, but I'm close to just letting this one rest... since it works, somehow.
The FeignClientsRegistrar definitely registers the @FeignClient before any of my custom code is run. Turning on Spring's debug logging, though, I can see that:
@ConditionalOnMissingBean (types: de.tfsw.spring.cloud.provider.ServiceProvider;
SearchStrategy: all) found no beans (OnBeanCondition)

even though inside the method with the conditional, I can retrieve the very Feign client automatically created.
When creating the client manually through the Builder, Spring will discover it and not jump into the conditional method:
@ConditionalOnMissingBean (types: de.tfsw.spring.cloud.provider.ServiceProvider;
SearchStrategy: all) found the following [providerClient] (OnBeanCondition)

My best guess right now is that this is more an issue within the Spring framework itself, not so much the Spring Cloud Netflix Feign implementation.
If I have some time in the future, I might investigate a little further - use newer versions, try out comparable behaviour of other ImportBeanDefinitionRegistrar implementations.

@thorstenfrank can you try specifying an order on your auto configuration using @AutoconfigureOrder?  I think that if we make sure your configuration runs before the spring cloud netflix configuration it might work.

Not sure the order will help, since the registrar is @Imported from @EnableFeignClients.

No love, but it was worth a try - both lowest and highest precedence have no effect, the results are identical.
Also, not really sure that's what I would want, since I do want the Feign clients to be created first (if they exist), and to only have my auto configuration run if the host application does not already provide a valid Feign client.

I didn't think it would. We'd need to restructure @EnableFeignClients to trigger an auto-configuration, then the order might work.

Just out of curiosity, I tried to place the @ConditionalOnMissingBean at the class level (i.e. on the auto configuration class in the library), but still had the same results.
I tried this because I had a similar situation at work today where the conditional only worked this way, not at the method level. But in that specific scenario, the bean the conditional was based on was also created by an auto configuration, not a registrar.

Again, I think the problem is that the registrar is NOT created by auto configuration

I agree, I just wanted to double-check. As mentioned, I don't understand the Spring loading mechanisms well enough to judge this effect...

Is there a plan to have the Feign registrar trigger an auto configuration?

Not currently

Closing due to age of the question. If you would like us to look at this issue, please comment and we will look at re-opening the issue.

Just a follow-up/work-around/solution:
the situation arises because the @ConditionalOnMissingBean is evaluated before the FeignClientsRegistrar actually creates the bean definitions for declarative clients. And the registrar doesn't check (or doesn't have access to?) said bean.
Strangely, using the primary attribute in the annotation has zero effect, so I think this whole issue is actually one of the Spring Framework itself, because apparently the bean creation through component scans and auto configuration seems to be in a parallel universe compared to the registrar.
The only solution around this specific issue is to only use one of the two approaches throughout: annotations (where the primary attribute then actually has an effect) or manual clients using Feign.Builder (or Hystrix, ...), but mix-and-match simply doesn't work.
We've decided to go with all annotations and marking the library clients as non-primary.


latest Zanata translation changes in jbpm-console-ng from 2016-09-03

this PR is identical to PR #478 and can be closed


codebeat badge

Is it fine to add codebeat badge to README?
codebeat is automated code review tool for Swift,Ruby,Go & Python that helps get instant feedback on code quality.
"Quick wins" suggested by codebeat could be a nice candidate for a pull request and help other developers become contributors.
FYI. To be fully open and honest. I'm co-founder of codebeat.

@korzonek Thanks for your PR, it is a very good service, we need to look at it to see how can we improve the current code quality. Especially the Animatable.swift file https://codebeat.co/projects/github-com-jakelin-ibanimatable/report_classes/swift-Animatable

@JakeLin thank you! We put a lot of love, passion and code into codebeat :) We launched at the beginning of this year so if you have any ideas or things you would like to see in codebeat please share it with us. It will help us prioritise our backlog :)

@korzonek I close this PR now and revisit it later. Thanks for your PR and the service.

@JakeLin thank you! IBAnimatable is cool! Keep on doing a great job.
BTW... please check us in 2-3 weeks. We will release excellent support for pull requests and enhanced version of Slack notification. Please don't treat is as shameless promotion I just feel very proud :)


Publish pact verification

As per https://github.com/bethesque/pact_broker/blob/verifications/lib/pact_broker/doc/views/publish-verification-results.markdown
This is required in all the verification modules.

From the ruby wiki:
Publishing verification results to a pact broker
If you are using version 1.11.0 or later of the pact gem and 2.0.0 or later of the pact broker, you can automatically publish the results of pact verifications back to the broker by setting the app_version and publish_verifications options in your service provider configuration. The recommended way to do this so that you only publish verifications from your CI is:
build_number = ENV.fetch('BUILD_NUMBER','alpha')
publish = !!ENV['BUILD_NUMBER']

Pact.service_provider "My Service Provider" do
  app_version "1.3.#{build_number}"
  publish_verifications publish
end

If your pact URL includes basic auth configurations for the pact broker, these will be used to publish the verification.

Released 4.5.4 with publishing verification results

👍

Documentation updated: https://github.com/pact-foundation/pact_broker/wiki/Provider-verification-results#publishing


createTrainingHeader

Dear Sir, im getting following issues.How to solve this please help
C:\grobid-0.5.3>java -Xmx1024m -jar \grobid-0.5.3\grobid-core\build\libs\grobid-
core-0.5.3-onejar.jar -gH \grobid\grobid-home -gP \grobid\grobid-home\config\gro
bid.properties -dIn \grobid-0.5.3 -dOut \grobid-0.5.3\2 -exe createTrainingHeade
r
-exe value should be one value from this list: [close, processRawReference, proc
essAuthorsHeader, processAuthorsCitation, processAffiliation, processReferences,
createTrainingMonograph, createTrainingBlank, createTrainingCitationPatent, pro
cessCitationPatentTEI, processCitationPatentST36, processCitationPatentTXT, proc
essCitationPatentPDF, processPDFAnnotation, processHeader, processFullText, proc
essDate, createTraining]
C:\grobid-0.5.3>

Hello @dineshbs7
See my answer for #384 and the current documentation, there is only one method createTraining which will create training files for all the models, including header.
https://grobid.readthedocs.io/en/latest/Grobid-batch/#createtraining


Move the internal CreateRequest methods to a partial client class

Fixes: https://github.com/microsoft/typespec/issues/3681

API change check
APIView has identified API level changes in this PR and created following API reviews.
Microsoft.Generator.CSharp.ClientModel


added sow attention weights to NNX

Added sow attention weights feature to NNX, after adding the same functionality to Linen in #3529.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (51e2cf5) 56.03% compared to head (d144a2e) 56.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3548      +/-   ##
==========================================
+ Coverage   56.03%   56.17%   +0.13%
==========================================
  Files         100      100
  Lines       11867    11890      +23
==========================================
+ Hits         6650     6679      +29
+ Misses       5217     5211       -6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Monitor] exploding

This issue will be fixed in our v0.2.0 release.

The problem is the eth_getLogs of Alt L1s. I will fix it today.


segvault when updating / stuck updating

Recently the CLUO (v0.7.0) seems to have been stuck and continuously tried to update the same node.
CoreOS: CoreOS 1800.5.0
Kubernetes: v1.9.9
Cloud: AWS us-east-1, kops 1.10
Agent logs:
I0827 23:00:28.134375       1 agent.go:184] Node drained, rebooting
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x1238536]
 goroutine 33 [running]:
github.com/coreos/container-linux-update-operator/pkg/updateengine.(*Client).ReceiveStatuses(0xc4203c6660, 0xc420052480, 0xc420052300)
	/go/src/github.com/coreos/container-linux-update-operator/pkg/updateengine/client.go:99 +0x186
created by github.com/coreos/container-linux-update-operator/pkg/agent.(*Klocksmith).watchUpdateStatus
	/go/src/github.com/coreos/container-linux-update-operator/pkg/agent/agent.go:251 +0x102

Controller logs:
I0827 23:03:26.319148       1 operator.go:449] Found node "ip-10-100-24-49.ec2.internal" still rebooting, waiting
I0827 23:03:26.319172       1 operator.go:451] Found 1 (of max 1) rebooting nodes; waiting for completion
I0827 23:03:59.455065       1 operator.go:507] Found 0 rebooted nodes
I0827 23:03:59.719801       1 operator.go:449] Found node "ip-10-100-24-49.ec2.internal" still rebooting, waiting
I0827 23:03:59.720003       1 operator.go:451] Found 1 (of max 1) rebooting nodes; waiting for completion
I0827 23:04:32.719449       1 operator.go:507] Found 0 rebooted nodes
I0827 23:04:33.119047       1 operator.go:449] Found node "ip-10-100-24-49.ec2.internal" still rebooting, waiting
I0827 23:04:33.119072       1 operator.go:451] Found 1 (of max 1) rebooting nodes; waiting for completion
I0827 23:05:06.520970       1 operator.go:507] Found 0 rebooted nodes
I0827 23:05:06.918956       1 operator.go:449] Found node "ip-10-100-24-49.ec2.internal" still rebooting, waiting
I0827 23:05:06.918976       1 operator.go:451] Found 1 (of max 1) rebooting nodes; waiting for completion
I0827 23:05:39.920518       1 operator.go:507] Found 0 rebooted nodes
I0827 23:05:40.320071       1 operator.go:449] Found node "ip-10-100-24-49.ec2.internal" still rebooting, waiting
I0827 23:05:40.320094       1 operator.go:451] Found 1 (of max 1) rebooting nodes; waiting for completion
I0827 23:06:13.719273       1 operator.go:507] Found 1 rebooted nodes
I0827 23:06:14.519760       1 operator.go:449] Found node "ip-10-100-24-49.ec2.internal" still rebooting, waiting
I0827 23:06:14.519909       1 operator.go:451] Found 1 (of max 1) rebooting nodes; waiting for completion

The panic you are running into looks the same as the one in #93, which is odd because according to that issue, it should've been fixed with v0.7.0. I'll have to try and reproduce that, I don't remember much about it.
As far as not updating, the panic shouldn't have anything to do with it, the panic comes because the dbus channel gets closed underneath the watch function because the system is going down for the reboot.
Can you post the operator deployment for the failed one? Do you have a reboot window or any pre- or post-reboot hooks configured? It might also be helpful to get some of the debugging logs, which you can do by adding the flag -v 4 to the operator deployment.


Out-Excel and -Now

Export-Excel Allows the use of -Path with -Now.
Export-Excel Allows override of -Path ,-Show, -AutoSize and -AutoFilter when using -Now.
Out-Excel Is a Proxy function for Export-Excel -Now [-OtherParams].
# Basic (-Now).
Get-Service | Out-Excel
# Override all the default -Now params including Path.
Get-Service | Out-Excel -Path "$env:TMP\File.xlsx" -Show:$false -AutoSize:$false -AutoFilter:$false
# Switch -AutoFilter to -TableName.
Get-Service | Out-Excel -TableName 'Data'

This resolves Issue https://github.com/dfinke/ImportExcel/issues/657.
Regarding https://github.com/dfinke/ImportExcel/pull/659. How I set it now the default is -AutoFilter, you can switch to a table with -TableName 'Data' or use none with -AutoFilter:$false.
If I change the default from -AutoFilter to -TableName we will be able to switch to -AutoFilter but I don't know how to make it switch to none as I can't do -TableNamer:$false as -TableNamer is a string. Any suggestions?

I changed the -Now default from -AutoFilter to -TableName
# Table (Auto name)
Get-Service | Out-Excel
Get-Service | Out-Excel -TableName ''
# Table (named)
Get-Service | Out-Excel -TableName 'Data'
# AutoFilter
Get-Service | Out-Excel -AutoFilter
# None
Get-Service | Out-Excel -TableName:$false
Get-Service | Out-Excel -TableName:$null
Get-Service | Out-Excel -TableName $false
Get-Service | Out-Excel -TableName $null

I needed to remove the type from the -TableName parameter for it to accept $false as [bool]

@dfinke update me on what you think regarding the -TableName -AutoFilter swap and if you want me to move Out-Excel to the examples and add some instructions on how to tweak it.

Be great to move Out-Excel to the Examples folder, add a folder CustomizeExportExcel?
The idea of defaulting the TableName that @DomRRuggeri had I liked.
Are there tests that exercise the parameters/parametersets?

Added ParameterSets tests and moved Out-Excel to Examples\CustomizeExportExcel

@DomRRuggeri Thanks for the Out-Excel, good idea, conversation and thanks @ili101 for the refactor and especially the tests
@ili101  Are you on twitter?
I'm going to update the readme, I'll ask you to double check, make sure I got everything.

Not really posting on twitter.
Will be nice if also you and @DomRRuggeri give a look to the Out-Excel explanation I wrote to see if it and the hypothetical example I come out with are clear. and improve if needed.

I did take a quick look. I liked the DynamicParam, going to do a deeper dive when I can.

The DynamicParam part is actually a modification of what @jhoneill done in https://github.com/dfinke/ImportExcel/blob/master/Send-SqlDataToExcel.ps1.
The difference is that it's simpler as it doesn't need the part that strip the parameter sets so it can take the parameters as is and add them.

Yup, cool stuff, now there's three places with DynamicParams https://github.com/dfinke/ImportExcel/blob/master/New-ConditionalFormattingIconSet.ps1#L39


move purge job queueing to hook

 Identify & provide hooks for items in API that could/should be on a hook


[locale] pt: Fix capital letters in weekdays

In Portuguese (Portugal) weekdays are in lowercase. So its required that working days will be like Segunda-feira not as the actual value Segunda-Feira
For those on grammar:
Even the first capital letter is only Ok when in a single word or the first word in a sentence. Regular usage (in the middle of a sentence) it would be all in lowercase.
But we can't control here when it will show one way or the other, so the initial capital letter!
Reference: https://ciberduvidas.iscte-iul.pt/consultorio/perguntas/meses-e-dias-da-semana-outra-vez/3743

@jalex79  what do you think
@horus68 you need to update tests in src/test/locale/pt.js.

@ichernev done

@horus68 - there's a small conflict - could you resolve it?

@marwahaha I tried to fix the conflict but now Travis failed.
I don't have the knowledge to fix this!

I made a change @horus68 - it looked like one test got adjusted. A few thoughts:

do we have confirmation from @jalex79 ?
should all months be lowercase, also?

In the middle of a sentence, the names of the days of the week are in lower case (domingo, segunda-feira, ..., sábado). But in bonds, and obviousness, at the beginning of sentences, is capitalized.

Ok, great.
@horus68 / @jalex79 , last question:

If Months and days of the week are treated similarly, should they all be lowercase?
For example, like this. https://github.com/moment/moment/blob/develop/src/locale/lt.js#L52-L60

Ok, I will merge it as is.


File name changes to the target bucket name while transferring it from one AWS S3 bucket to another AWS S3 bucket  using Connector

I am transferring file from one AWS S3 bucket to another AWS S3 bucket using the Connector. I am using the latest tag v0.0.1-milestone-8. I am facing a small issue. Actually, when files ae copied from one bucket to another bucket, files are not copied with their actual names and file extension. Instead the name of the file changes to the target bucket name created on the consumer side during the execution of S3ProvisionPipeline.

The body of my request http://localhost:9192/api/v1/management/transferprocess is given below:
{
  "connectorAddress": "http://localhost:8282/api/v1/ids/data",
  "protocol": "ids-multipart",
  "connectorId": "consumer",
  "assetId": "1",
  "contractId": "1:956a102a-f790-485a-bd03-88f35714aba6",
  "dataDestination": {
    "properties": {
      "type": "AmazonS3",
      "region": "eu-central-1",
      "bucketName": "eclipse-dataspace-connector-bucket-13",
      "keyName": "application_configurations.txt"

    },
    "type": "AmazonS3"
  },
  "managedResources": true,
  "transferType": {
    "contentType": "text/plain",
    "isFinite": true
  }
}

During debugging, I have found out that on the consumer side, when AWS resources are created the DataAddress object is updated due to which i think we are facing this issue. https://github.com/eclipse-edc/Connector/blob/v0.0.1-milestone-8/core/control-plane/transfer-core/src/main/java/org/eclipse/edc/connector/transfer/process/TransferProcessManagerImpl.java#L494 Can anyone guide me how I can fix this or is this a bug?

Hey, taking a quick look I'd say that the problem is that the keyName is not passed to the S3BucketResourceDefinition in the S3ConsumerResourceDefinitionGenerator and the ProvisionedResource resourceName is set with the bucketName instead of the keyName in the S3BucketProvisioner
I'd say that this could be considered a bug. It would be great if you'd provide a PR to fix it

Hey, thanks for the reply. Ok, I shall create a PR and add changes to fix this issue.

I have solved this issue by making some changes in the code of AWS extensions. Now the keyName in the dataDestination represents the name of the file that will be transferred to the destination S3 bucket but now I am facing another issue. I am getting this exception:
DEBUG 2023-05-20T01:29:08.5410094 Transferring from AmazonS3 to AmazonS3.
SEVERE 2023-05-20T01:29:08.8422872 Error writing the data.txt object on the eclipse-dataspace-connector-bucket-50 bucket: The AWS Access Key Id you provided does not exist in our records. (Service: S3, Status Code: 403, Request ID: CT595RPWNJQ8GSV0, Extended Request ID: vyfMkhGyUS+I4CJ880z9VC7kYhpYNrAF/R4SzGG+Flc3B11tYUMwxqp+ya7JaWAGmLIJ+Gyk/s0=)
software.amazon.awssdk.services.s3.model.S3Exception: The AWS Access Key Id you provided does not exist in our records. (Service: S3, Status Code: 403, Request ID: CT595RPWNJQ8GSV0, Extended Request ID: vyfMkhGyUS+I4CJ880z9VC7kYhpYNrAF/R4SzGG+Flc3B11tYUMwxqp+ya7JaWAGmLIJ+Gyk/s0=)
	at software.amazon.awssdk.core.internal.http.CombinedResponseHandler.handleErrorResponse(CombinedResponseHandler.java:125)
	at software.amazon.awssdk.core.internal.http.CombinedResponseHandler.handleResponse(CombinedResponseHandler.java:82)
	at software.amazon.awssdk.core.internal.http.CombinedResponseHandler.handle(CombinedResponseHandler.java:60)
	at software.amazon.awssdk.core.internal.http.CombinedResponseHandler.handle(CombinedResponseHandler.java:41)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.HandleResponseStage.execute(HandleResponseStage.java:40)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.HandleResponseStage.execute(HandleResponseStage.java:30)
	at software.amazon.awssdk.core.internal.http.pipeline.RequestPipelineBuilder$ComposingRequestPipelineStage.execute(RequestPipelineBuilder.java:206)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.ApiCallAttemptTimeoutTrackingStage.execute(ApiCallAttemptTimeoutTrackingStage.java:72)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.ApiCallAttemptTimeoutTrackingStage.execute(ApiCallAttemptTimeoutTrackingStage.java:42)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.TimeoutExceptionHandlingStage.execute(TimeoutExceptionHandlingStage.java:78)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.TimeoutExceptionHandlingStage.execute(TimeoutExceptionHandlingStage.java:40)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.ApiCallAttemptMetricCollectionStage.execute(ApiCallAttemptMetricCollectionStage.java:50)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.ApiCallAttemptMetricCollectionStage.execute(ApiCallAttemptMetricCollectionStage.java:36)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.RetryableStage.execute(RetryableStage.java:81)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.RetryableStage.execute(RetryableStage.java:36)
	at software.amazon.awssdk.core.internal.http.pipeline.RequestPipelineBuilder$ComposingRequestPipelineStage.execute(RequestPipelineBuilder.java:206)
	at software.amazon.awssdk.core.internal.http.StreamManagingStage.execute(StreamManagingStage.java:56)
	at software.amazon.awssdk.core.internal.http.StreamManagingStage.execute(StreamManagingStage.java:36)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.ApiCallTimeoutTrackingStage.executeWithTimer(ApiCallTimeoutTrackingStage.java:80)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.ApiCallTimeoutTrackingStage.execute(ApiCallTimeoutTrackingStage.java:60)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.ApiCallTimeoutTrackingStage.execute(ApiCallTimeoutTrackingStage.java:42)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.ApiCallMetricCollectionStage.execute(ApiCallMetricCollectionStage.java:48)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.ApiCallMetricCollectionStage.execute(ApiCallMetricCollectionStage.java:31)
	at software.amazon.awssdk.core.internal.http.pipeline.RequestPipelineBuilder$ComposingRequestPipelineStage.execute(RequestPipelineBuilder.java:206)
	at software.amazon.awssdk.core.internal.http.pipeline.RequestPipelineBuilder$ComposingRequestPipelineStage.execute(RequestPipelineBuilder.java:206)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.ExecutionFailureExceptionReportingStage.execute(ExecutionFailureExceptionReportingStage.java:37)
	at software.amazon.awssdk.core.internal.http.pipeline.stages.ExecutionFailureExceptionReportingStage.execute(ExecutionFailureExceptionReportingStage.java:26)
	at software.amazon.awssdk.core.internal.http.AmazonSyncHttpClient$RequestExecutionBuilderImpl.execute(AmazonSyncHttpClient.java:193)
	at software.amazon.awssdk.core.internal.handler.BaseSyncClientHandler.invoke(BaseSyncClientHandler.java:103)
	at software.amazon.awssdk.core.internal.handler.BaseSyncClientHandler.doExecute(BaseSyncClientHandler.java:171)
	at software.amazon.awssdk.core.internal.handler.BaseSyncClientHandler.lambda$execute$0(BaseSyncClientHandler.java:68)
	at software.amazon.awssdk.core.internal.handler.BaseSyncClientHandler.measureApiCallSuccess(BaseSyncClientHandler.java:179)
	at software.amazon.awssdk.core.internal.handler.BaseSyncClientHandler.execute(BaseSyncClientHandler.java:62)
	at software.amazon.awssdk.core.client.handler.SdkSyncClientHandler.execute(SdkSyncClientHandler.java:52)
	at software.amazon.awssdk.awscore.client.handler.AwsSyncClientHandler.execute(AwsSyncClientHandler.java:63)
	at software.amazon.awssdk.services.s3.DefaultS3Client.getObject(DefaultS3Client.java:4580)
	at software.amazon.awssdk.services.s3.S3Client.getObject(S3Client.java:8077)
	at org.eclipse.edc.connector.dataplane.aws.s3.S3DataSource$S3Part.openStream(S3DataSource.java:66)
	at org.eclipse.edc.connector.dataplane.aws.s3.S3DataSink.transferParts(S3DataSink.java:48)
	at org.eclipse.edc.connector.dataplane.util.sink.ParallelSink.lambda$processPartsAsync$4(ParallelSink.java:83)
	at org.eclipse.edc.spi.telemetry.Telemetry.lambda$contextPropagationMiddleware$2(Telemetry.java:102)
	at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1700)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

I am using vault-filesystem extension to store the secrets. When I tried to debug that issue, I found out that when the request of data transfer is received by the provider connector, the secrets such as the consumer S3 bucket credentials are stored on the producer side in the vault https://github.com/eclipse-edc/Connector/blob/main/data-protocols/ids/ids-api-multipart-endpoint-v1/src/main/java/org/eclipse/edc/protocol/ids/api/multipart/handler/ArtifactRequestHandler.java#L162 Now as keyName represents the filename instead of the bucket name, when provider tries to transfer the data from the source https://github.com/eclipse-edc/Connector/blob/main/extensions/data-plane/data-plane-aws-s3/src/main/java/org/eclipse/edc/connector/dataplane/aws/s3/S3DataSourceFactory.java#L81 , it uses consumer S3 bucket credentials because secret is accessed by the keyName, now keyName reprsents the filename that is same for both sourceDataAddress and destinationDataAddress due to which provider uses wrong credentials to access the source S3 bucket and as a result I am getting this error. I was wondering how we should solve the issue. Also I think, secrets should be identified by the bucket name because bucket names are unique but filenames  can be same for different scenarios. Also it's not easy to make changes in the code in this file https://github.com/eclipse-edc/Connector/blob/main/data-protocols/ids/ids-api-multipart-endpoint-v1/src/main/java/org/eclipse/edc/protocol/ids/api/multipart/handler/ArtifactRequestHandler.java#L162 because this code is used almost in all scenarios.

@MUsman1992 yes, we discovered this issue in the #3042 so if you pull the latest nightly artifact the bug will be already solved, will be part of the next release

@ndr-brt thanks for the reply. Yes, I have noticed that in main branch, ids modules have been removed which means that now only dsp protocol can be used for communication between 2 connectors. I have faced some new issues when I switched to the dsp protocol and tried to transfer data from one S3 bucket to another S3 bucket:

My http://localhost:9192/api/v1/management/catalog/request call was not successfully working. As a result, I had to replace this line in the code https://github.com/eclipse-edc/Connector/blob/main/extensions/control-plane/api/management-api/catalog-api/src/main/java/org/eclipse/edc/connector/api/management/catalog/CatalogApiController.java#L88 with this service.request(providerUrl, "dataspace-protocol-http", spec) then it started working successfully.
In the S3BucketProvisionedResource class https://github.com/eclipse-edc/Connector/blob/main/extensions/control-plane/provision/provision-aws-s3/src/main/java/org/eclipse/edc/connector/provision/aws/s3/S3BucketProvisionedResource.java, I had to replace these properties names bucketName and region with https://w3id.org/edc/v0.0.1/ns/bucketName and  https://w3id.org/edc/v0.0.1/ns/region otherwise during serialization when the JSON-LD structure is compacted it removes the  bucketName and region https://github.com/eclipse-edc/Connector/blob/main/data-protocols/dsp/dsp-http-core/src/main/java/org/eclipse/edc/protocol/dsp/serialization/JsonLdRemoteMessageSerializerImpl.java#L58 due to which I get errors on the producer side when validations are performed on the DataAddress Object https://github.com/eclipse-edc/Connector/blob/main/extensions/data-plane/data-plane-aws-s3/src/main/java/org/eclipse/edc/connector/dataplane/aws/s3/S3DataSinkFactory.java#L82.

@MUsman1992 the old management API has been deprecated as well, please use the v2 with json-ld semantics

@ndr-brt thanks for the reply. Yes, its working with the latest API, I have checked it now.


Update donut chart per recent changes

Fixes #19
Few notes:

Most locators look worse, as class names were removed. I've filled https://github.com/patternfly/patternfly-react/issues/1932 to return class names, so hopefully at some point we'll be able to revert locators.
Now we have a separate url for charts - http://patternfly-react.surge.sh/patternfly-4/charts/*chart_name* (same for demos, inline tables, layouts etc), so relying on static url + module_name is not an option anymore. Added module const CATEGORY which defines custom category in url (if present, otherwise defaults to 'component'). That's probably the easiest way with the least amount of changes, but feel free to suggest different approach if needed.
As of now, DonutChart.legend nested view is basically outdated, as values for legend items are not available anymore, so neither special parametrized view, nor _get_legend_item() function are needed, but since the chart itself is a subject to change (numerous issues for donut chart are open), i'll leave that part as is for now, just in case values are returned in some upcoming PR.

Some unrelated tests are failing on FF (donut test passes though). Not sure what's changed in FF or patternfly-react, will take a look tomorrow.

Turns out it's an issue with patternfly-react, i've shared my findings in https://github.com/patternfly/patternfly-react/issues/1931#issuecomment-490066699 . @quarckster i think we should ignore this travis failure for now. Technically, we can workaround it by introducing force_scroll=True kwarg for all clicks in affected widgets, but imo it's gonna be too much ugly workarounds for issue which should be fixed soon.

@abalakh PF4 documentation moved to https://www.patternfly.org/v4/documentation/react/components/aboutmodal and charts haven't been presented there yet.

@quarckster mind if i take the task to update the repo to test against new docs (in case there is smth to work on, apart from url update 🙂 )? Or you're already looking into it?

@abalakh Actually I've already changed the url in conftest.py, until charts are not presented in the new docs we could keep tests of donut charts skipped or override the url in a test fixture.


Spawning

Some of the mobs are spawning in water https://imgur.com/a/dZEmcCU

Ah, that should only be the case for the Skeleton Horseman, I forgot to register spawn placement requirements for it.

Ah, that should only be the case for the Skeleton Horseman, I forgot to register spawn placement requirements for it.

Lates version fixes this.

Lates version fixes this.


custom startDate and endDate

Thanks for the nice date picker!  Is there a way to limit display of dates to start 7 days from today and end 3 months from now?  I noticed that startDate and endDate options accept the value of "today".  How could I write
startDate:'today' + 7 days?
endDate: 'today' + 3 months?
Thanks!

Hi tonumikk,
you can easily achieve this by precalculating the desired date into a variable:
// preparing date variables
var startDate = new Date();
var endDate = new Date();
startDate.setDate(startDate.getDate() + 7);
endDate.setMonth(endDate.getMonth() + 3);

// initializing fdatepicker
$('#dp1').fdatepicker({
  startDate: startDate,
  endDate: endDate,
  format: 'mm-dd-yyyy',
  disableDblClickSelection: true,
  leftArrow:'<<',
  rightArrow:'>>',
  closeIcon:'X',
  closeButton: true
});


RadarChart has poor visibility of text labels

I think the image speaks for itself. Even with relatively small or short labels and room for them to display they overlap significantly with the labels. This is using font-size 13 for labels styling. However it's setup the label's height/width is not being considered (correctly?) when placing it at the end of the axis.

I was researching fixing this and found the function that outputs the labels. What I was thinking of doing was rendering the text SVG element to an invisible scratch space somewhere, measuring it's bounding box, and then adding offsets to the X and Y to push them a correct amount away from the text of the ticks.
To do it best I would also want to render the axis spot that the label is nearby, and use it's bounding box to make sure that if the text on the axis grows, and the label stays small that the label is also pushed away by that.
Any advice on this approach would be greatly appreciated. Primarily on a way to obtain said scratch space to render invisible elements onto to measure them before removing them. This would have to be done on every render call.
function getLabels(props) {
  var domains = props.domains,
      startingAngle = props.startingAngle,
      style = props.style;

  return domains.map(function (_ref, index) {
    var name = _ref.name;

    var angle = index / domains.length * Math.PI * 2 + startingAngle;
    var radius = 1.2;
    return {
      x: radius * Math.cos(angle),
      y: radius * Math.sin(angle),
      label: name,
      style: style
    };
  });
}


Bridge RewardTokens from L2 to L1

Let's wait for this PR to be merged first before merging #20

Thanks a lot for this PR @swapnilraj, and for having enriched the tests! Once the small comments I made are addressed, you can safely merge it.


Updated index.json

Pull Request Title
Description
Please include a summary of the change or the feature being introduced. Include relevant motivation and context. List any dependencies that are required for this change.

[ ] This change requires a documentation update
[ ] I have made corresponding changes to the documentation

Related Issue(s)
This PR addresses issue #X
Screenshots
If relevant, please add screenshots.
Notes
Please add any relevant notes if necessary.

Sorry for the inconvenience. My formatter was high.

@nothing-mann All good. Please resolve the conflict and make sure the entries have a space after the colon and no space before it

@idagelic I have resolved the merge conflict


how can share the frf to you？

1

Uploading FL_4ML907159C__0005.frf.zip…

Thanks! I hope to be able to get to unlocking Gen2.5 firmwares soon.


ignores is missing ignores added from .nowignore

After upgrading to macOS Catalina I get this error on some now-deploys:
> Error! ENOENT: no such file or directory, stat '<file that not exist>'

and the file is below a folder that should be ignored by .nowignore, think this is due to some fs-bug in my node version, but did also discover that the ignore-array returned from getNowIgnore did not include the ignores from my .nowignore, but only the default defined in the top of the function.
Is this a bug?

Codecov Report

Merging #3186 into canary will increase coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           canary    #3186      +/-   ##
==========================================
+ Coverage   13.33%   13.54%   +0.21%
==========================================
  Files         268      268
  Lines       10312    10335      +23
  Branches     1211     1212       +1
==========================================
+ Hits         1375     1400      +25
+ Misses       8877     8873       -4
- Partials       60       62       +2

Impacted Files
Coverage Δ

src/util/dev/router.ts
82.35% <0%> (-0.34%)
:arrow_down:

src/util/dev/server.ts
64.8% <0%> (+0.32%)
:arrow_up:

src/util/dev/validate.ts
87.87% <0%> (+27.87%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37c06c8...4f4e316. Read the comment docs.

There is no current test for the getNowIgnore function in now-client and it looks to me that its only used in the create-deployment.ts. But is this not "A Priori" case when the ig property is returned with what reflect the users .nowignore, but the ignore array does not?


Added help content for WFCORE-2283, CLI completion of required and alternatives

Added a note in help.

Fixed! Thanks.


Support the injection of RxJava 1 and 2 Vertx instances

This allows injecting instances of both io.vertx.rxjava.core.Vertx and io.vertx.rxjava.core.Vertx in test and lifecycle methods.
Along the way I refactored the code to make it nice for future (scoped) injectables.
Fixes #33

Updated with closable resources following @sormuras PR

@cescoffier done, your turn now

@sormuras done


Fixes for issue #1683: failed to run accelerate config in colab

Fixes for issue #1683: failed to run accelerate config in colab

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

How to reformat a file? which tool or standard did you use ?

@Erickrus please do pip install -e .[quality]; make style; make quality;. This will install the right versions of black, ruff, and hf-doc-builder, and run the right quality setup

For you to decide it can be merged to the base branch @muellerzr


FlatList not properly typed

FlatList's renderItem does not infer the type from the data prop. On the other hand, the regular react-native's flatlets does.
<FlatList
  data={["abc"]}
  renderItem={({ item })= > item} // React-native's inferred `item` to be `string`. In native-base it's `any`
/>

Same goes for other props like keyExtractor.

Hi @MoSattler,
Thanks for reporting the issue.
It is fixed now and PR is created. #4478
It will be included in upcoming release. 😄

This issue is fixed in Version 3.3.0 of NativeBase


Bollies and pokopets

Bollies done locally, will do pokopets next.

when will the update with the bollies be released?

Soon, currently really busy with irl stuff.


Audio Quality

Homework

[X] I took the time to write a good, descriptive issue title
[X] I read nativefier --help and API.md.
[X] I checked CATALOG.md for community suggestions & workarounds.
[X] I searched existing issues, open & closed. Yes, my question is new.
[X] I'm running the latest version.

Your question
Is it normal for electron apps to use some type of builtin audio? On Windows I do not get the high quality sound I would get from browser. I use Realtek Audio Console and Sonic Studio 3.  Both does detect YouTube app built with nativefier with regular volume mixer but the sound effects with SS3 and DTS with RAC do not work.
Steps to reproduce
No response
Debug info
No response
Nativefier version
50.0.1
Node.js version
18.12.1
npm version
8.19.2
OS
21H2 (OS Build 19044.1566)

I believe Electron should be leaving this up to the OS/Realtek to determine. I don't know why your app would be excluded from these. Are there any other apps that get excluded from these features? I'm wondering if Realtek just has a whitelist of apps it supports.

yes its weird that the sound effects part do not work for both Realtek Audio Console and Sonic Studio 3 but can only control the volume from them 🤷♂


int() argument must be a string

When configuring configs.py, and running main.py I get the following error:

However, if you fix this line like this:  API_ID = int(os.environ.get("APP_ID", 996380))
You will get another error on startup: ValueError: Unknown storage engine

Distributor ID: Ubuntu
Release:        20.04
Python: 3.8.10

session_name will be Authorized Telegram User Client's Session String. Use @StringSessionGen_Bot for that.

session_name is prescribed as it is. The config itself is already prepared and filled with the necessary data.
Look at the second screenshot, when I run main.py.

Session String not recognized as Session. Maybe you done that same API_ID value problem.

Session String not recognized as Session. Maybe you done that same API_ID value problem.

Um, okay. Please tell me what to do, how to fill in the app_id correctly (if you look at the first screenshot and the first paragraph)?
Because filling app_id I get an error. Thank you!

Check this: https://t.me/AbirHasan2005/94

Check this: https://t.me/AbirHasan2005/94

Thank you very much, but right now it is more important to run on your machine and not use heroku.

Directly set like
API_ID = 1234...
API_HASH = "abcd123..."

Directly set like
API_ID = 1234...
API_HASH = "abcd123..."

Below is an example of how this is recorded. I still get an error.
API_ID = int(os.environ.get(996380))
API_HASH = os.environ.get("311111111111111111111111111111")

Not Like this!
API_ID = 996380
API_HASH = "311111111111111111111111111111"


Please cover an example featuring screen sharing

Hey @Harikrishnan19 any findings so far?

I found no snippet of screen share implementation using agora rtc react. But I managed to do that by using agora-rtc-sdk-ng. I couldn't able to use their hooks directly as are immediately called after initialization.
import AgoraRTC from "agora-rtc-sdk-ng";
const [screenShareClient, setScreenShareClient] = useState(null)
const [screenVideoTrack, setScreenVideoTrack] = useState(null)
// to listen when stop sharing is clicked by user
useEffect(() => {
if (screenVideoTrack) {
screenVideoTrack.on('track-ended', async () => {
await handleScreenShareStop()
})
}
},[screenVideoTrack])
// to start screen sharing
async function handleScreenShareStart() {
const screenClient = AgoraRTC.createClient(config);
await screenClient.join(appId, channelName, token, null);
const screenTrack = await AgoraRTC.createScreenVideoTrack();
await screenClient.publish(screenTrack);
setScreenShareClient(screenClient)
setScreenVideoTrack(screenTrack)
}
// to stop screen sharing
async function handleScreenShareStop() {
screenVideoTrack.close();
await screenShareClient.leave();
setScreenVideoTrack(null)
setScreenShareClient(null)
}
// make sure to stop screen sharing when the user leaves.
You could also refer Agora rtc sdk ng documentation for screen-sharing

I'm updating the wrapper with #7 soon I'll try and add a screenshare example as well. Thanks for the feedback.


Use Hugo for Sass processing

This is a...

[x] Feature Request
[ ] Bug Report

Problem:
At the moment, the build process for Sass is separate from the Hugo generation process, which makes
Proposed Solution:
As of today, Hugo now offers native support for Sass processing. We can use this feature to create a single workflow for the site.

/assign


Extension causes high cpu load

Issue Type: Performance
Extension Name: cody-ai
Extension Version: 0.4.2
OS Version: Windows_NT x64 10.0.22621
VS Code version: 1.79.2

sourcegraph.cody-ai-unresponsive.cpuprofile.txt

Thank you for reporting this @eortegaz
Any updates since you open this issue?

i confirm the issue on macos  13.6 (22G120) with IntelliJ IDEA 2023.3.2 (Ultimate Edition) and plugin version 5.215221.

And Android Studio Hedgehog | 2023.1.1 Patch 1, plugin version 5.2.18630.
Maybe almost every JetBrains IDE.

@kampiamodikuesto @hunterMG
Please use: https://github.com/sourcegraph/jetbrains/issues/new/choose


ci: exclude pip-compile'd files from renovate

this issue might exist in all my repositories!

try'd out
  ignorePaths: ["requirements*.txt", "setup.cfg"],

and it worked:

implement!


How safe is the data if I change disk size and re-deploy

Team,
I need some advice, I have deployed a 7 node cluster (2 clients, 2 masters, 3 data nodes). My data-volume-size is 30Gi, after loading our initial data set, my store.size is 41gb and pri.store.size is 21gb, I am not sure what the best approach is here going forward, in order to not risk losing the my data. we are using GKE so we do not have snapshot enabled. Here are the 3 options i see
1.) spin up a new cluster with larger disk-sizes, use elasticdump to move data to the new instance, retire the old
2.) change the disk size and redeploy, this would only work if the controller made sure each re-deployed pod was fully in-sync before starting the next
3.) manually install repository-gcs and create a snapshot to gcp, then redeploy, manually repository-gcs again and run a restore
Any advice on which way i should proceed? My initial thought is option 3, but i have not yet looked into installing a plugin into a running upmc cluster.

Hey @thomascooper I think your best bet is to redeploy. Ideally, there would be a way to spin up larger data nodes and be able to roll through those and migrate your data but today do not have the capability for that today.
I am working on GKE snapshots, but still in progress.

Let me know if you have any further questions, I hope to get this operator to a place where it will handle these bits for you, that's really the point. Please re-open if you have further questions.


Display permanent_buffs

Need some hint how to hide this column properly for unparsed matches and matches that have no data about permanent_buffs

The way we've usually done is make the columns definition a function instead of a direct array, and determine whether to add this column in the returned array based on a passed match that you can do an if check on


[Don't Review] Only for address pyspark-errors for branch-3.4

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

@dongjoon-hyun @HyukjinKwon
I finally found the reason for pyspark-errors's failure,
The root cause is that the disk space is full, so we need to backport this PR https://github.com/apache/spark/pull/42253 (@zhengruifeng ) to branch-3.4,
At present, the test of pyspark-errors on branch-3.4 has passed, as follows:
https://github.com/panbingkun/spark/actions/runs/8370751714/job/22918653065

if disk space is full is the cause, then I think we can backport it.

After fixing the python liner issue on branch-3.4 yesterday, today's scheduled branch-3.4 jobs has been successfully completed.
https://github.com/apache/spark/actions/runs/8372278037

Additionally, why did pyspark-errors always succeed before applying this PR?
Because it uses the master's build_and_test.yml, which contains the logic Free up disk space, as shown below,
https://github.com/apache/spark/actions/runs/8372278037/job/22923008912

I think that after this PR is merged into branch-3.4, and the automatically triggered testing jobs for branch-3.4 should also succeed.

Merged to branch-3.4.


Version

Could you state all the version of all the libraries you used as it would resolve few of my errors.

Good day! I really liked your idea. But at startup, I ran into a number of problems. Could you tell me which version of tensorflow you used when training the model?


Display only the first adv

Hi,
I have my MAUI app with NET8. The plugin is working but the advs are not displayed after the first adv is displayed.
I have to close the app and reopen it to see another advertisement.
Basically, I want to display a rewarding advertisement after a user activity. Between one activity and another could pass a few minutes.
Do you know if this is a common issue?
Thank you in advance,
Enrico

I think this is fixed in version 1.3.3


Added /app to the --with-config-file-scan-dir option.

This is intentionally not using the environment variable.
To change the APP_DIR env var, first you need to change it in our PHP
binaries, upload those packages, then change it in
php-nginx/Dockerfile.

@bshaffer
Can you take a look? It turned out that we need to add /app to the config scan dir anyways, especially when we run composer install for users.

We run composer install way before we copy the file. With the current design, we need to delay copying because we need to refer to the environment variable to determine which file to copy. When we run composer install, it is better to have /app as a scan dir.
I think we can do better when we move to the builder model, but now I think we need this

Also, the original build script used to have ${APP_DIR} as the scan dir, so it's actually safe to add

But this means other *.ini files in that directory will be parsed as php config files, but we should only parse php.ini.

@bshaffer
Again, this is an old behavior and needed to migrate to debian package model. We can fix that sub optimal situation when we moved to the builder model


enh(scala) add Scala 3 end and extension soft keywords

Changes

Add Scala 3 end of definition or expression marker (see https://docs.scala-lang.org/scala3/reference/soft-modifier.html)
Simplified version of https://github.com/scala/vscode-scala-syntax/blob/main/src/typescript/Scala.tmLanguage.ts#L599-L634. Here we only need one kind of keyword.
Based on #3326
Checklist

[x] Added markup tests, or they don't apply here because...
[x] Updated the changelog at CHANGES.md

@nicolasstucki Thanks for the work on this!

It is a draft only because it depends on #3326 and any changes that might happen to that PR. Though we could skip/close #3326 and merge this one instead.

Managed to join the END rules to avoid having to modes.


in null safe dartpad, exception messages don't propagate to console

This may be a more general issue, but just trying on the null safe version right now:
This:
void main() {
  late int x;

  if (3 > 4) {
    x = 4;
  }
  print(x);
}

just triggers:
Script error.

If I wrap in a try-catch, I can see the underlying error is:
LateInitializationError: Local 'x' has not been initialized.

Can we propagate that to the console?

Should be something I can do. We've gone back and forth on how to report exceptions and runtime errors in the console. Given that the null safety version is a special case, more info seems better.

This has been fixed in the most recent deployment. Runtime exceptions and errors are now propagated to the console in glorious red text.


x/build: freebsd-amd64-race builder is failing consistently on golang.org/x/tools repo

The linux-amd64-race builder is currently configured with 15 GB RAM (via the n1-standard-4 machine type). CL 213557 has recently increased the RAM for windows-amd64-race builder to 14.4 GB in order to work around 7.2 GB not being sufficient, as described at https://github.com/golang/go/issues/35186#issuecomment-571438725.
The freebsd-amd64-race builder is currently configured to use the n1-highcpu-4 machine type, which has 3.6 GB RAM. The freebsd-amd64-race builder is failing quite often, which may be connected to insufficient memory:

signal: killed
FAIL	golang.org/x/tools/go/packages	217.792s

*** Test killed with quit: ran too long (10m0s).
FAIL	golang.org/x/tools/internal/imports	600.067s

panic: test timed out after 10m0s
[...]
FAIL	golang.org/x/tools/go/packages	611.592s

[...]
	package = golang.org/x/tools/internal/lsp/protocol
2020/01/07 18:44:29 Error:2020/01/07 18:44:29 no dep handle: no metadata for golang.org/x/xerrors
	package = golang.org/x/xerrors
2020/01/07 18:44:35 no dep handle: no metadata for golang.org/x/tools/internal/lsp/protocol
	package = golang.org/x/tools/internal/lsp/protocol
2020/01/07 18:44:35 Error:2020/01/07 18:44:35 no dep handle: no metadata for golang.org/x/tools/internal/lsp/protocol
	package = golang.org/x/tools/internal/lsp/protocol
2020/01/07 18:44:36 no dep handle: no metadata for golang.org/x/xerrors
	package = golang.org/x/xerrors
2020/01/07 18:44:36 Error:2020/01/07 18:44:36 no dep handle: no metadata for golang.org/x/xerrors
	package = golang.org/x/xerrors
2020/01/07 18:44:42 no dep handle: no metadata for golang.org/x/xerrors
	package = golang.org/x/xerrors
2020/01/07 18:44:43 Error:2020/01/07 18:44:42 no dep handle: no metadata for golang.org/x/xerrors
	package = golang.org/x/xerrors
--- FAIL: TestCommandLine (240.28s)
    --- FAIL: TestCommandLine/Modules (194.21s)
        --- FAIL: TestCommandLine/Modules/Diagnostics (159.73s)
            --- FAIL: TestCommandLine/Modules/Diagnostics/testy_test (151.73s)
                check.go:62: missing diagnostic "testy/testy_test.go:6:6: x declared but not used", map[]
FAIL
FAIL	golang.org/x/tools/internal/lsp/cmd	240.922s

2020/01/07 20:54:34 no dep handle: no metadata for nosuchpkg
	package = nosuchpkg
2020/01/07 20:54:51 no dep handle: no metadata for golang.org/x/tools/internal/lsp/protocol
	package = golang.org/x/tools/internal/lsp/protocol
2020/01/07 20:54:51 no dep handle: no metadata for golang.org/x/xerrors
	package = golang.org/x/xerrors
FAIL	golang.org/x/tools/internal/lsp/source	246.068s

If there aren't objections, I plan to bump its up RAM to be more similar in size (without exceeding the current value of 15 GB RAM used both by Linux and now Windows -race builders) to see it helps with the test failures and issues like #34621.
/cc @bradfitz @bcmills @matloob @toothrot

CL 214433 was deployed this morning, and the freebsd-amd64-race builder has been passing on x/tools since then:

I'll give it more time to gather more data, and close this issue if the reliable build results continue.

The failures in https://build.golang.org/log/74eea9d200fd346319a2595c2f2b2ab3f25c2a07 appear to be due to timeouts rather than data races, although it is possible that a data race failure is being masked by failure to propagate logs somewhere higher up the stack.

I'll give it more time to gather more data, and close this issue if the reliable build results continue.

I think the build results are reliable, keeping the specific issues mentioned above in mind.

I'll close this since the original issue is resolved, and we can follow up with more specific issues as needed.

Whoops, I misread the issue and missed the "x/tools" prefix, thinking it was about the main Go repository.
This is still a problem for x/tools:
https://build.golang.org/?repo=golang.org%2Fx%2Ftools

I'll re-open and look into this more later.

CL 227859 has been deployed earlier today. The freebsd-amd64-race builder has started to pass on x/tools:

I'll consider this resolved. If something unexpected comes up, we can re-open this issue or file a new one.


Bjorncs/cluster controller reindexing status

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Contains the 3 first commits from previous PR


Add support for the Invidious YouTube add-on

Introduction
This branch adds basic support for the Invidious YouTube add-on, as proposed in #978.
The only thing that is working so far is the direct playback of shared video URLs, which - as mentioned in the original issue - is an MVP that could be extended upon.
This new feature is lacking translation. If I can help with that as well let me know.
How to test

Checkout the branch and run the app in the emulator
Connect the app to a Kodi instance
Install NewPipe
Open NewPipe, select a video and share the video with Kore

Kodi should display a brief loading indicator and then playback the video.

Thanks in advance for your time and consideration!

Ok, i'm not 100% sure about this.
My issue is that there's no modular way for specifying plugins in Kore, so each plugin that is supported is being tightly coupled in Kore's code, and that's not something that i find scalable. Up until now, plugins dealt with different providers (arte.tv, svtplay, etc), so that was transparent to the user, but this requires a new option in the settings, getting very visible to the user, and it can get unwieldy soon.
This had already happened with the SendToKodi plugin, which i merged, but i had even greater reservations...
Anyway, i'm merging this for now, but with the caveat that i might revisit this decision in the future (and certainly also the inclusion of the SendToKodi one). The UI on the settings might change, or this might get removed - apologies in advance if that happens, but hope you understand the rationale.


Missing github ci build

mvn clean test fails here
Would be great if everything at least builds on win / mac / linux and has a matrix github ci build for every pr / commit to main.
This also means no dependencies on existing file structure outside the project dir

Yes, I'm aware of this pile of shame. Right now the test are more or less some tooling utils but far away from production. I can't say when or if this ever will reach a "production" state as this is a one-man show and I'm usually more focussed on new features than technical debts (except bugs).

I might be able to help but but let me first try to talk to you on discord

Not a pile of shame, great tool. Just not ready for other ppl to get involved.

There is a embedded testsystem available now. I haven't deleted my local environment to check if there are still hidden references, but I think I covered everything.

still not compiling on mac here:
UnsatisfiedLinkError: 'java.lang.Integer org.jnativehook.GlobalScreen.getAutoRepeatRate()'

What is that used for?

Looks like it belongs to JavaFX? I tried stackoverflow, but since I can't reproduce it without a mac its tricky for me.

Strange that this fails on the server module

anyway, don't have the time to look into this now


GitHub templates

Added very basic templates for Issues & Pull Requests

We are not really using issues at the moment, so I think we can skip that for now. Screenshot can go in the PR template though, as well as a link to the JIRA ticket maybe? A warning to add breaking changes in the PR body?

I provided this issue template in the first place for our third-party users, so they can make an issue according this template whenever they found a bug in teamleader-ui.


Re-add the cors lines for actix

Adds lines previously added to fix cors issues, but subsequently lost presumably due to a code rewrite. Fixes https://github.com/patrickelectric/mavlink2rest/issues/61 by reimplementing historical fix https://github.com/patrickelectric/mavlink2rest/commit/5964e2dc250b7ccd0614befcb6a2b99e4e41843f as mentioned in https://github.com/patrickelectric/mavlink2rest/issues/12.

Hi @noahbliss let me know if this fixes your issue

This works, but it allows from any source (*) policy. You may want to add a disclaimer in the readme.
This does, however, function. :)

I think you still have to merge my dude. :)


Improve Android prefab and triplet doc

Improve Android prefab and triplet doc

User doc (triplet.md): add a link to prefab.md
(prefab.md was not user discoverable)

Prefab.md:

Provide a way for readers to quickly generate ready
to use android triplets and to adapt them to their needs
(if required)
Update the prefab usage instructions: "vcpkg install"
the 4 archs before exporting a prefab

What does your PR fix? Fixes issue #11052

This PR can may be considered as a fix for https://github.com/microsoft/vcpkg/issues/11052
since it (hopefuly) eliminates the confusions that lead to asking this question

Which triplets are supported/not supported? Have you updated the CI baseline?

Not applicable, this is doc only

Does your PR follow the maintainer guide?
Yes

@pthom @strega-nil looks good to me

@atkawa7 : if you have a few minutes, would you mind giving me some help on this pr: https://github.com/microsoft/vcpkg/pull/11269
My issue is that I now can built a prefab package, but I do not know how to consume it (and thus test it). As a newbie to android development, the prefab doc was not that helpful for this.

@pthom I forgot another option which shows examples on how to consume it. Add this option --prefab-debug
./vcpkg export --triplet arm64-android jsoncpp --prefab --prefab-maven --prefab-debug

Output
[DEBUG] Configuration properties in Android Studio
In app/build.gradle

	com.vcpkg.ndk.support:jsoncpp:1.9.2

And cmake flags

    externalNativeBuild {
                cmake {
                    arguments '-DANDROID_STL=c++_shared'
                    cppFlags "-std=c++17"
                }
            }

In gradle.properties

    android.enablePrefab=true
    android.enableParallelJsonGen=false
    android.prefabVersion=${prefab.version}

Note:  prefab packages are supported on Android Studio 4+
If you have Android 3.6 you might need to install android 4.1 Preview

@pthom checkout the following project that I created to consume the packages created
https://github.com/atkawa7/prefab-vpkg-integration-sample

I made some changes, and added an example + android.md file.
@atkawa7  could you please have a look at
https://github.com/pthom/vcpkg/blob/fix_prefab_doc/docs/users/android.md
and
https://github.com/pthom/vcpkg/blob/fix_prefab_doc/docs/specifications/prefab.md

@pthom looks good to me

Please poke me when you think the documentation is ready to merge; I don't know anything about android, and so I'm just going to trust your judgement :)

@strega-nil I think the documentation in its current form is good. I think @pthom addressed issues that new users might come across when consuming android archive packages.  I don't know if there is still anything to be added @pthom. I am sure as more issues related to android come up we will continue to improve the docs and address concerns users might have

I added a second example
It provides a script vcpkg_android.cmake
The usage is even simpler:

Main CMakeList, before calling project()

if (VCPKG_TARGET_ANDROID)
    include("cmake/vcpkg_android.cmake")
endif()

cmake invocation:

cmake .. -DVCPKG_TARGET_ANDROID=ON -DANDROID_ABI=armeabi-v7a

I have successfuly tested on two vanillla installations of vcpkg under linux and MacOS.
@atkawa7 @strega-nil  : if this looks good to you, I think the PR is ok on my side too

The pipelines fails under osx.
The azure log file says
fatal: update_ref failed for ref 'HEAD': cannot lock ref 'HEAD':
Unable to create '/Volumes/data/work/1/s/.git/HEAD.lock': File exists.

Another git process seems to be running in this repository, e.g.
an editor opened by 'git commit'. Please make sure all processes
are terminated then try again. If it still fails, a git process
may have crashed in this repository earlier:
remove the file manually to continue.

@strega-nil : I tried to retrigger the build but the issue persists. Could you look into it?

Alright, awesome! Thanks everyone, and @pthom especially. Y'all make this project so good!


Error when click on Complete Sign Off data plane API Readiness

I wasn't able to capture the error, and now the button is disabled (as I imagine it completed). @live1206 let me know if you would like a repro and I can see how to get it

@maririos Can you post the screenshot for this case?

@maririos Yes, please help to repro and get the screenshot. I have tried a few times, was not able to reproduce it.

Got it!

When the API Readiness is complete, we will update ADO item to update the status, but seems like the field has been renamed:

It used to be Stable API readiness state, or I got it wrong in the first place.
Fix deployed to all environments now.
@maririos Please help to verify.
cc @ladonnaq

I tried it again and it didn't fail but it also didn't say it succeeded. Am I supposed to see a confirmation or something?

I tried it again and it didn't fail but it also didn't say it succeeded. Am I supposed to see a confirmation or something?

I don't think that the logic is implemented yet to complete what is needed.  I will find the GitHub issue.

No, there is no logic in place to notify the completion yet.
I think this bug is resolved for now.


Serve an instance of swagger-ui in the dashboard

To enable more effective developer tooling to discover and play with the HTTP API, the dashboard could serve an interactive openapi/swagger endpoint.
A strawman would be to use the standard Go embed library to embed a filesystem that could be served statically.

Closing this because of little interest now that we've had Postman and Buf API docs for so long.
If you happen to find this searching the GitHub issues, feel free to resurrect.


Add default root password to postgres service definition

Thanks for preparing the whole stack on docker-compose. It's really easy to use.
After docker-compose up -d, the postgres service is down and docker logs prints information about missing root password.
postgresql_1 | Error: Database is uninitialized and superuser password is not specified.
postgresql_1 |        You must specify POSTGRES_PASSWORD to a non-empty value for the
postgresql_1 |        superuser. For example, "-e POSTGRES_PASSWORD=password" on "docker run".
postgresql_1 |
postgresql_1 |        You may also use "POSTGRES_HOST_AUTH_METHOD=trust" to allow all
postgresql_1 |        connections without a password. This is *not* recommended.
postgresql_1 |
postgresql_1 |        See PostgreSQL documentation about "trust":
postgresql_1 |        https://www.postgresql.org/docs/current/auth-trust.html

Since these docker-compose files are for testing purposes, I think it's OK to use some default root password. It'll make the up process seamlessly.
Kind Regards.

I'm seeing this behavior as well with a fresh clone of the repo, but definitely have not previously. Perhaps this is new(ish) default behavior for the PostgreSQL image tag, I vaguely recall the docs previously saying POSTGRES_PASSWORD defaulted to the same as POSTGRES_USER.

I think this is related with the newer postgres docker image version. As far as I know, this is to improve security.
As far as I know, to solve the issue there are two approaches:

Set POSTGRESS_PASSWORD as @skrajewski suggested on his commit.
Explicitily tell postgres that no password is required for connection setting up POSTGRES_HOST_AUTH_METHOD=trust

The pull request associated with can be found at https://github.com/docker-library/postgres/pull/658
I think that between those I would rather choose first one.

Thanks @skrajewski, I can also reproduce the issue by pulling in the latest postgresql Docker image. With your changes this issue is fixed :+1:


how do i manipulate my epub

Does this lib has the means to manipulate the epub..such as :font size changes  , and page manipulation like seek bar changing pages ? for android

Duplicate of issue-29.


Add rendercv_settings field to the data model

In addition to the cv, design, and locale_catalog fields, we should include a new field called rendercv_settings.
rendercv_settings could contain all the CLI options (like output folder name, pdf path, etc.) and other settings like discussed in #139 and #144.

#164

I'm trying to implement this. I'll let you know when this is implemented

Thank you very much! Let me know if you need any guidance.

Question 1:
There is no requirements listed in the requirements.txt. Should I create one?
Question 2:
What would be the current cli options for the rendering?
potentials options:

Remove the cli option altogether for render only.
maintain a hierarchy say if now args is provided from the cli then we take from the rendercv_render block. (which is also an optional block btw).

What would be the current cli options for the rendering?

All the CLI options are listed in the documentation.

Remove the cli option altogether for render only.

What's the reason to remove CLI options?

maintain a hierarchy say if now args is provided from the cli then we take from the rendercv_render block. (which is also an optional block btw).

Yes, CLI options should always overwrite whatever is in the YAML file.

What's the reason to remove CLI options?

we now will have the ability to override the rendercv settings like this: --rendercv_settings.no_html true Then we have to maintain 3 levels of hierarchy.
Then when we use  --rendercv_settings.no_html true without -nohtml option. what would be the expected behaviour? I know this example the answer is simple should not be generated. but what if the provided configuration is conflicting. say with pdf_path.
Because of this scenario I was considering removing the cli option from render portion only.
But, to me the 2nd option sounds good choice.


[ISSUE #8278]fix fail test

Which Issue(s) This PR Fixes

Fixes #8278
Brief Description

How Did You Test This Change?

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.84%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8279      +/-   ##
=============================================
- Coverage      42.96%   42.84%   -0.12%
+ Complexity     10417    10388      -29
=============================================
  Files           1274     1274
  Lines          88956    88956
  Branches       11438    11438
=============================================
- Hits           38218    38113     -105
- Misses         46044    46136      +92
- Partials        4694     4707      +13

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Multiple linear regression 2

Please have alook on new updates for these 2 files

Superceded by #115

Superceded by #115


Channels with 0

When I try and change the channel to 103. I can see the request correctly but on the TV it changes to channel 13:
Received a new message: b'{"channel_data": {"channel": {"number": "103"}, "channelMetadata": {}}, "operation": "ChangeChannel", "endpointid": "40:16:3b:42:e1:7f"}' from topic: channel/28ee4056-8450-43a0-94da-d26404322688
I have to say change channel to 1003 to get it to then change correctly to 103 on the TV:
Received a new message: b'{"channel_data": {"channel": {"number": "1003"}, "channelMetadata": {}}, "operation": "ChangeChannel", "endpointid": "40:16:3b:42:e1:7f"}' from topic: channel/28ee4056-8450-43a0-94da-d26404322688

try this go into
AlexaControlledSamsungTV/helpers/mqtt_server.py
and change line 104 that says
time.sleep(0.05)
to
time.sleep(0.75)

That’s done the trick thanks.
TurnOff seems to have stopped working though?

Does the command give an error or just not turn off the tv? if its the later try giving it some time. sometimes i have noticed if i am rapidly turning the tv off an on the power off command stops working for a bit. (give it like 10 minutes and see if anything happens). If it was working before though then i'm not quite sure what could be wrong besides that


[Airbrake] [Production] No such file or directory @ rb_sysopen - /var/www/etmoses/releases/20160610160327/public/system/load_profile_components/curves/000/000/240/energy_power_wind_turbine_inland.original.csv

Airbrake error: #8465
Airbrake project: ETMoses
Error type: Errno::ENOENT
Error message: No such file or directory @ rb_sysopen - /var/www/etmoses/releases/20160610160327/public/system/load_profile_components/curves/000/000/240/energy_power_wind_turbine_inland.original.csv
Where: <no information>
Occurred at: Jun 27, 2016 14:46:49 UTC
First seen at: Jun 27, 2016 14:46:49 UTC
Occurrences: 1 (1 since last deploy on Jun 27, 2016 13:10:49 UTC)
URL: <no information>
File: [GEM_ROOT]/bundler/gems/merit-f88fa00202e1/lib/merit/curve.rb
Backtrace:
[GEM_ROOT]/bundler/gems/merit-f88fa00202e1/lib/merit/curve.rb:94:in initialize
[GEM_ROOT]/bundler/gems/merit-f88fa00202e1/lib/merit/curve.rb:94:in open
[GEM_ROOT]/bundler/gems/merit-f88fa00202e1/lib/merit/curve.rb:94:in load_file
[PROJECT_ROOT]/app/models/curve_component.rb:19:in block in network_curve

The weird thing is that this error still occurs even though we deployed way past 2016(06)(10)160327 (10th of June).
Delayed job fails to restart. There was a process running from the 10th of June. I'll have to look why Delayed job fails to restart.
I killed the old processes and started them with:
RAILS_ENV=production bin/delayed_job -n 2 start


Fix openvino build + editorials

Addressing issues #20 & #21

hi @amr-mokhtar  issue is in openvino.go file. i can't see the updated file on github repository.


Package Citation.js as a public npm package

#6 is about making it work better as a local module for node.Citation.js, while this is about publishing all of it as a npm package.

Done! https://www.npmjs.com/package/citation-js. I'll add more docs later (see #9)


add validation on query params

in case passing undefined params in the URL it will be ignored and no filtration will happen. so /nodes?total_cro=24 will return the same response as /nodes without any filtration. they may lead to a typo in the query params goes un-noticed

do this with the schema package from this pr

Is this still in accepted? I can see a PR merged referencing this issue?

yes. still no work done on this yet, I just mentioned in a conversation on the merged pr that we have an issue for the validation of the queries


As a user I would like to see FundRequest added to the list of Bounty projects

As a user I would like to see FundRequest added to the list of Bounty projects
FundRequest :  A marketplace for open source software development (https://fundrequest.io)

Hi @karelstriegel, thanks for this suggestion! I'm hesitant to add FundRequest because it isn't yet in widespread use. The goal of this project is to document useful case studies, but the site doesn't really give information that would be useful to a reader. I'm going to close this issue for now.
As a side note: as a maintainer, it doesn't feel great to see a bounty attached to an issue that hasn't yet been discussed, as it introduces conflicting incentives. I'd suggest waiting for a 👍 before funding the issue, or asking maintainers if they want the issue funded before attaching a bounty. Thanks! 😊

Hi @nayafia, thank you for your feedback. Indeed it is not widespread used, as we went live last week. Being added to your list might help spread the existence of our platform to a broader audience and thus increase the use.
Can we find a middle ground? Where for example it is indicated the our platform is very young and needs to evolve, so your readers are well aware?
The reason for the fund (in this case) was more to prove that is was working and the we are live, rather then actually funding it as a bounty.  All other funds are linked to tickets where the project maintainer have indicated that the issues are relevant and can to be solved by project contributors.


issue #246 Warnings regarding unused formal parameters in cpp templates

Commented out the argument names so the warning will not appear. ([[maybe_unused]] would have been the nicer solution, but seen it is only available from standard c++-17 it is better for a bit a conservative way).

Are there any / many people using the C++ version of JavaCC 7? Is it possible for all those to migrate to JavaCC 8? It looks that JavaCC 8 has better features / fixes for the C++ version.
Note also that the PRs / commits must be signed to be mergeable.

Looks to me that JavaCC-8 repository (https://github.com/javacc/javacc-8) hasn't been updated for 2 years and JavaCC (https://github.com/javacc/javacc) was updated 2 months ago and had a release on November 18, 2023 (version 7.0.13).
Either JavaC-8 doesn't need maintenance or ...

javacc-8 needs to be released properly :( If someone can do that it will be great!


Some compilers do not support -march=haswell

I catched some build errors:
warning<EMAIL_ADDRESS>simd_c/reedsolomon.c:1:0: error: bad value (haswell) for -march= switch
warning<EMAIL_ADDRESS> /* reedsolomon.c - SIMD-optimized Galois-field multiplication routines
warning<EMAIL_ADDRESS> ^

The reason may be that some specific version of compilers does not support -march=haswell.
-> root@AAA ~git:(main) 101? # gcc -march=native -E - < /dev/null
# 1 "<stdin>"
# 1 "<built-in>"
# 1 "<command-line>"
# 1 "/usr/include/stdc-predef.h" 1 3 4
# 1 "<command-line>" 2
# 1 "<stdin>"
-> root@AAA ~git:(main) ? # gcc -march=haswell -E - < /dev/null
# 1 "<stdin>"
<stdin>:1:0: error: bad value (haswell) for -march= switch

Could we sure that compiler supports -march=haswell when set build flag?

Which version of GCC is it specifically? Might be just too old to know about Haswell, in which case I don't think we care about it all that much.

Which version of GCC is it specifically? Might be just too old to know about Haswell, in which case I don't think we care about it all that much.

-> root@AAA ~ ? # gcc --version
gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-44)
Copyright © 2015 Free Software Foundation, Inc.

GCC 4.8.5 is from 2015, I'm fairly certain no one will bother doing anything to support it. You should really upgrade to more modern and supported OS or install newer GCC in some way yourself.

GCC 4.8.5 is from 2015, I'm fairly certain no one will bother doing anything to support it. You should really upgrade to more modern and supported OS or install newer GCC in some way yourself.

Okey. Thanks for your reply.