On page 131, the chunk about "#Generate sell and buy signals"

On page 131, the chunk about "#Generate sell and buy signals"
buys <- ifelse(data_out$spread > threshold,1,0);
sells <- ifelse(data_out$spread < -threshold,-1,0)
Shouldn't it be
sells <- ifelse(data_out$spread > threshold,-1,0);
buys <- ifelse(data_out$spread < -threshold,1,0)

Hi tsungwu,
I also noticed this issue. It seems more reasonable when the spread goes higher (lower) than the threshold and we are going to short (long) the spread. Furthermore, in order to make the code consistent, the code on page 133 should be reversed. Otherwise, you will get an opposite result.
Originally, the code on p.133 is:
for(i in 1:length(signal)) {
if(signal[i] == 1 && position == 0) {
#buy the spread
prev_x_qty <- round(beta[i] * trade_size)
qty_x[i] <- -prev_x_qty
qty_y[i] <- trade_size
position <- 1
}
if(signal[i] == -1 && position == 0) {
#sell the spread initially
prev_x_qty <- round(beta[i] * trade_size)
qty_x[i] <- prev_x_qty
qty_y[i] <- -trade_size
position <- -1
}
if(signal[i] == 1 && position == -1) {
#we are short the spread and need to buy
qty_x[i] <- -(round(beta[i] * trade_size) +
prev_x_qty)
prev_x_qty <- round(beta[i] * trade_size)
qty_y[i] <- 2 * trade_size
position <- 1
}
if(signal[i] == -1 && position == 1) {
#we are long the spread and need to sell
qty_x[i] <- round(beta[i] * trade_size) + prev_x_qty
prev_x_qty <- round(beta[i] * trade_size)
qty_y[i] <- -2 * trade_size
position <- -1
}
}
#######################################
I think it should be:
for(i in 1:length(signal)){
if(signal[i] == 1 && position == 0){
#buy the spread
prev_x_qty <- round(beta[i]*trade_size)
qty_x[i] <- prev_x_qty
qty_y[i] <- -trade_size
position <- 1
}
if(signal[i] == -1 && position == 0){
#sell the spread initially
prev_x_qty <- round(beta[i]*trade_size)
qty_x[i] <- -prev_x_qty
qty_y[i] <- trade_size
position <- -1
}
if(signal[i] == 1 && position == -1){
#we are short the spread and need to buy
qty_x[i] <- (round(beta[i]*trade_size) + prev_x_qty)
prev_x_qty <- round(beta[i]trade_size)
qty_y[i] <- -2trade_size
position <- 1
}
if(signal[i] == -1 && position ==1){
#we are long the spread and need to sell
qty_x[i] <- -(round(beta[i]*trade_size) + prev_x_qty)
prev_x_qty <- round(beta[i]trade_size)
qty_y[i] <- 2trade_size
position <- -1
}
}
Linus

Thank you for this clarification. Can you please post a pull request on my github account for this fix?

On Feb 7, 2017, at 6:12 AM, linus791025<EMAIL_ADDRESS>wrote:
Hi tsungwu,
I also noticed this issue. It seems more reasonable when the spread goes higher (lower) than the threshold and we are going to short (long) the spread. Furthermore, in order to make the code consistent, the code on page 133 should be reversed. Otherwise, you will get an opposite result.
Originally, the code on p.133 is:
for(i in 1:length(signal)) {
if(signal[i] == 1 && position == 0) {
#buy the spread
prev_x_qty <- round(beta[i] * trade_size)
qty_x[i] <- -prev_x_qty
qty_y[i] <- trade_size
position <- 1
}
if(signal[i] == -1 && position == 0) {
#sell the spread initially
prev_x_qty <- round(beta[i] * trade_size)
qty_x[i] <- prev_x_qty
qty_y[i] <- -trade_size
position <- -1
}
if(signal[i] == 1 && position == -1) {
#we are short the spread and need to buy
qty_x[i] <- -(round(beta[i] * trade_size) +
prev_x_qty)
prev_x_qty <- round(beta[i] * trade_size)
qty_y[i] <- 2 * trade_size
position <- 1
}
if(signal[i] == -1 && position == 1) {
#we are long the spread and need to sell
qty_x[i] <- round(beta[i] * trade_size) + prev_x_qty
prev_x_qty <- round(beta[i] * trade_size)
qty_y[i] <- -2 * trade_size
position <- -1
}
}
#######################################
I think it should be:
for(i in 1:length(signal)){
if(signal[i] == 1 && position == 0){
#buy the spread
prev_x_qty <- round(beta[i]*trade_size)
qty_x[i] <- prev_x_qty
qty_y[i] <- -trade_size
position <- 1
}
if(signal[i] == -1 && position == 0){
#sell the spread initially
prev_x_qty <- round(beta[i]*trade_size)
qty_x[i] <- -prev_x_qty
qty_y[i] <- trade_size
position <- -1
}
if(signal[i] == 1 && position == -1){
#we are short the spread and need to buy
qty_x[i] <- (round(beta[i]*trade_size) + prev_x_qty)
prev_x_qty <- round(beta[i]trade_size)
qty_y[i] <- -2trade_size
position <- 1
}
if(signal[i] == -1 && position ==1){
#we are long the spread and need to sell
qty_x[i] <- -(round(beta[i]*trade_size) + prev_x_qty)
prev_x_qty <- round(beta[i]trade_size)
qty_y[i] <- 2trade_size
position <- -1
}
}
Linus
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi Harry,
My apologies that your original code on p.133 and p.134 should be correct. I will look into this example and test it with more pairs.
The first time I tried your method on different pair assets, I got nice results while using the code I modified yesterday. It gave me an illusion that I might be correct. Now, I found that I was logically incorrect. Let me explain my understanding of the example shown from p.127 to p.136.
We are going to trade the spread between an ETF and a stock, namely, SPY and APPL. The regression model would look like this: y_t = beta_t-1 * x_t + e_t
where
y_t is the price of SPY,
x_t is the price of APPL,
e_t is an error term, which should be normally distributed if the pair is cointegrated,
beta_t-1 is the lag coefficient of x_t in the linear model by rolling method in this example.
I have an question here: the calculation of beta in this example is determined by the code below.
beta_out_of_sample <- rolling_beta(diff(dF), 10)
The spread seems much more normally distributed when I estimated the the rolling_beta without taking difference on their prices. Maybe you can check this part.
#######switch back to the original issue
In this example, the spread is the error term. When the spread is lower than the threshold (one std here), we long the spread, which means we long SPY and short beta*APPL. #buys <- ifelse(data_out$spread < -threshold,1,0)
if(signal[i] == 1 && position == -1) {
#we are short the spread and need to buy
qty_x[i] <- -(round(beta[i] * trade_size) + prev_x_qty)                #short beta*AAPL
prev_x_qty <- round(beta[i] * trade_size)
qty_y[i] <- 2 * trade_size                                                            #long SPY
position <- 1
}
When the spread is higher than the threshold (one std here), we short the spread, which means we short SPY and long beta*APPL. #sells <- ifelse(data_out$spread > threshold,-1,0)
if(signal[i] == -1 && position == 1) {
#we are long the spread and need to sell
qty_x[i] <- round(beta[i] * trade_size) + prev_x_qty              #long beta*AAPL
prev_x_qty <- round(beta[i] * trade_size)
qty_y[i] <- -2 * trade_size                                                    #short SPY
position <- -1
}
The same logic can be applied to the other two rules.
if(signal[i] == 1 && position == 0) {
# buy the spread
prev_x_qty <- round(beta[i] * trade_size)
qty_x[i] <- -prev_x_qty
qty_y[i] <- trade_size
position <- 1
}
if(signal[i] == -1 && position == 0) {
# sell the spread initially
prev_x_qty <- round(beta[i] * trade_size)
qty_x[i] <- prev_x_qty
qty_y[i] <- -trade_size
position <- -1
}
So the original code looks reasonable. Just need to revise the definition of buys and sells signal.
#################################
In my opinion, this strategy is profitable if we can find a cointegrated pair. In other words, we can estimate a the model well and get a normally distributed spread. Otherwise, if the spread between two assets don't converge in the long run, we will face a big loss.
I will look into this example and post a pull request to share what I get. I really appreciate your quick response. This book is really helpful for me to clarify some concepts.
Furthermore, this is what I read recently regarding pair trading and I found it is a good supplementary material: "Statistical arbitrage pairs trading strategies: Review and outlook" (https://ideas.repec.org/p/zbw/iwqwdp/092015.html)
Thank you!
Linus

Dear Linus:
On more problem.  On the bottom of page 135, the function of compute_equity_curve(), the last line defines equity as   "equity <- cumulative_sell-cumulative_buy+positionprice"
Because "sell" mean "short", hence, isn't it
"equity <- cumulative_buy-cumulative_sell+positionprice" ?

Hi tsungwu,
The original code looks fine to me. When we calculate profit and loss, it is always based on selling price (market price) minus buying price (cost).
As a result, I think the original code for this part is correct. I have already tested this part.
Another 2 questionable things in this chapter is the "rolling beta" and the way we calculate beta. After I calculated betas without taking difference on the price, the spread looks more normally distributed. However, the trading strategy using rolling beta seems non-robust to me, if beta changes drastically!
For example, if you buy a spread on day 1 with beta equals to 1.5 and you get a selling signal on day 10. If the rolling beta becomes 3 on day 10, you will face a big loss. Because the spread doesn't converge. Maybe my explanation is not that clear. But I think you can think about it.
Anyway, the concept in this chapter is still helpful. But if we don't have sufficient background knowledge in this field, it is not easy to understand the logic behind the code. The best way to gain more pair trading ideas is to read some papers in this field. There are different ways to fit the model such as state space model, Kalman filter, and PCA.

I got it. Because I calculated net profit by differencing price, hence short has to take a negative sign to accumulate revenue.  For the equity "curve", a portfolio idea usually uses price level movement to show Profit-Loss.
The rolling regression for me is a signal for long/short, I usually keeps it constant.  When signal appears, I never follow time-varying betas to adjust position.  For example, I usually take the hedge ratio=0.6, and a 10:6 position for 10-time Y and 6-time X.  10Y-6X=Spread


Error on Draggable<._onUp on Windows Firefox

This primarily happens on Windows Firefox, from version 25.0 to 34.0.
Leaflet version: 0.7
Message: 	e.className is undefined
Exception type: TypeError
Browser:	Windows Firefox 34.0
User agent:	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0

Stack trace
a.DomUtil._getClass
a.DomUtil.removeClass
a.Draggable<._onUp
a.DomEvent.addListener/s

Test url to drag on: http://timesmachine.nytimes.com/timesmachine/1969/07/21/issue.html
I traced it down to following lines, but can't see what calls _getClass that caused this error on Firefox.
https://github.com/Leaflet/Leaflet/blob/76440b9df2e802fa5691686834c76008e4488927/src/dom/Draggable.js#L111
https://github.com/Leaflet/Leaflet/blob/cb1994a3db1029bcfc2fe5bbb95c813b6a91869c/src/dom/DomUtil.js#L76

Please provide a JSFiddle that demonstrates the issue and a list of steps to replicate.

Also, does it reproduce on latest stable (0.7.3)? What about master?

@mourner we'll try to deploy the 0.7.3 in about 2 weeks and see what the system finds.

OK, will reopen if there's a reproducible test case on 0.7.3 or master later.


Login screen customization

Is your feature request related to a problem? Please describe.
I'm trying to customize the login screen on OpenSearch, and as far as I understood it's a part of the security plugging
Describe the solution you'd like
it would be useful to consider the login screen customization as a part of custom branding  features

[Triage] We are the OpenSearch project, we would want to keep the OpenSearch / OpenSearch Dashboard names as is.
@elfisher Do you have thoughts on what kind customizations we would want to support and if we should reconsider.

@opensearch-project/opensearch-ux Do you have thoughts on what kind customizations we would want to support and if we should reconsider keeping the UI as is?

@peternied - I believe custom branding includes some configs you can hook onto: See this issue: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/826 and the relevant configs (opensearchDoashboards.branding.logo, opensearchDoashboards.branding.applicationTitle)

Thanks @kgcreative it looks like we missed adding this customization logic into the login screen, thanks for referencing that pull request.

Relevant docs: https://opensearch.org/docs/latest/dashboards/branding/

@peternied
,external_osdSharedDeps_React_default.a.createElement(external_osdSharedDeps_ElasticEui_["EuiText"],{size:"m",textAlign:"center"},props.config.title|| ("please login open Search Dashboard ")
i want this with my custom text but when i am changing it my custom text is not visual on login page there is same  text please anyone  can help me change this ????


doesn't even work in 1.17

i tried pick up everything....I tried key binding..nothing is working..why?is it because i'm java edition?

You need to crouch to pick up something

Ouh,thats what you mean by control!
On Sat, Jun 19, 2021, 8:14 AM Gabriel Henrique de Oliveira <
@.***> wrote:

You need to crouch to pick up something
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GabrielOlvH/Carrier/issues/20#issuecomment-864327343,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUPITGUQQTKAFS2IK73TR6DTTPOPNANCNFSM465M7VUA
.

Nope,I tried it doesn't work.
On Sat, Jun 19, 2021, 9:19 AM Bakagema 00 @.***> wrote:

Ouh,thats what you mean by control!
On Sat, Jun 19, 2021, 8:14 AM Gabriel Henrique de Oliveira <
@.***> wrote:

You need to crouch to pick up something
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GabrielOlvH/Carrier/issues/20#issuecomment-864327343,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUPITGUQQTKAFS2IK73TR6DTTPOPNANCNFSM465M7VUA
.


[Feature] Ability to write comments / notes for Queries / APIs / widgets

Summary
Ability to write comments.
Motivation
For complex queries / APIs / widgets, it helps to write a quick summary of what they do, or what data they have, for a better understanding of the code.
For eg. an API URL like this https://discord.com/api/channels/<channel_number>/messages doesn't communicate which channel's data is being fetched. Here a comment would be helpful - It's similar to why we write comments in our codebase.
Or, another example, a table widget's Table Data could be a lengthy JS doing data-transformation. In this case also, a summary in words will be helpful to understand the code.

@pric-appsmith thanks for the feature request! This would be really helpful for new devs coming into existing apps

This is now being tracked as #5601


Improve API documentation to cover searching for messages.

Using the /messages endpoint we can search messages for text. This requires requesting with the following parameters:
        request = {
            'anchor': MAX_INT, (set at max int to search for latest messages. Id of a message can also be used to search before(set num_before>0) or after(set num_after >0) the message.)
            'num_before': self.num_before,
            'num_after': self.num_after,
            'narrow': json.dumps([['search', TEXT_TO_SEARCH]]),
        }

This can be implemeted along with #8595. @aero31aero @eeshangarg FYI.

@zulipbot label "area: documentation (api and integrations)"

This has been on /api/get-messages for some time, thanks to @YagoGG.
Any questions about those docs are appreciated!


[HOTFIX] Release https dependency link

Full context in dbt-labs/dbt-core#4891
When we dropped support for 3.6, the version checks inside linux distros like arch that need their own action, were conducting the checks with 3.6 and failed. These checks needed to be updated to a later version, or we need to continue to build for 3.6.
Tasks:

fix the release process
release to include #43

published on pypi.


Use $templateRequest instead of $templateCache to load templates

Use $templateRequest instead of $templateCache to be able to load from the server the template the first time the directive is used
This should fix #167

Please merge! :)

Any chance this will get merged soon?

Guys is it really necessary to change


Enhancing colour of website

I would like to give beautiful and elegant colours to the website to make it more attractive.
Kindly add labels.

I want to enhance the website with beautiful and elegant colors to make it more appealing.
assign this task to me. [@Codewithmeowmeow ]

Hey @Codewithmeowmeow, please provide more information on how you can enhance the design of Rentalog.in. If you have any rough designs, please share them

@SHRAVANIc01 ?

was busy with other stuff, i will work on it for sure.


Integrates Travis CI and coverage badge from CodeCov

Fixes #41
You need to enable Travis CI and CodeCov for your repo to get this stuff rolling.
https://travis-ci.org/infinitered/solidarity
https://codecov.io/gh/infinitered/solidarity
I would've integrated semaphore CI, but since there are no config files I wasn't able to do that.

🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉

🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉


lastInsertId not correct with AUTO_RANDOM id

CREATE TABLE `t` (
  `id` BIGINT NOT NULL AUTO_RANDOM,
  `name` varchar(128) NOT NULL,
  PRIMARY KEY (`id`),
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin

const tx = await conn.begin()

const r = await tx.execute(
    "insert into t (name) values (?)",
    ["banana"],
    { fullResult: true },
)

console.log(r.lastInsertId)

The output will be something like<PHONE_NUMBER>972252700 (multiple of 100) but the real id is<PHONE_NUMBER>972252673

Thanks for your report.
Seems there is a precision loss for lastInsertId. I will take a deep look tomorrow.

lastInsertId will lose precision when it exceeds the MAX_SAFE_INTEGER of the number type
After some research, we decide to change the type of lastInsertId to string in https://github.com/tidbcloud/serverless-js/pull/66. It will be a break change and we will release v0.2.0 after pr is merged

Close as it has been resolved. Please reopen it if have any questions


fix(service): fix infinite loop when fallback language async loading…

Fixes #1468

Thank you, we will have a look at asap.

Would it be possible to have a separate release including this fix?

Yeah, ongoing..

Picked as 233f30c
Thank you!


More API

adding EventType and Literal for more fluent event fire API

would be nice if
 .eventType("Cloud.Storage.Item.Created")

AND
        cloudEvent.select(
                    new EventTypeQualifier("Cloud.Storage.Item.Created"))
                .fire(event);

would not have similar code. might be handy to factor that into a method ...

Looks good.


Safari through drawImage capture screenshots failed

chrome、firefox through drawImage can get the screenshot,  Safari through drawImage capture screenshots failed! Please help to solve thank you

Can you show what you trying to do with the drawImage and Clappr? You can use the clappr.io/demo to show (:

Closing due to no response received. If there is anything new, you can open the issue again (:


Debug HC4 RM3 effectiveness for Russian

https://github.com/castorini/anserini/blob/master/docs/regressions-hc4-v1.0-ru.md#effectiveness
RM3 only gets 0.0821
Possibly a bug? We should look into it...

https://github.com/castorini/anserini/blob/master/src/main/resources/topics-and-qrels/topics.hc4-v1.0-ru.dev.desc.tsv
Appears to be only 4 topics... so I suppose it's possible.


A question：about multiscale_line_detection and line_detection.

Hello, I'm sorry to bother you again,I have a question.
Currently, I am using line_detection in line_matcher.py. What is the difference between it and multiscale_line_detection?
Will it make line detection and matching better?
Is it designed for image scale transformation or angle of view change?
Will it take more time to run multiscale detection?
I look forward to hearing from you very much！

Hi, the multiscale_line_detection is a brute-force method to obtain higher invariance to scale changes. It basically runs the network on the same image, upsampled and downsampled at different resolutions (x1 and x2 by default), then aggregate the results in the original scale.
This will make the detection and matching more robust to scale changes, but may decrease the performance if the test set has few scale changes. So this is purely about scale, there is no improvement with respect to other viewpoint changes and the multiscale option is slower than the default one.

OK,thank you very much！ I understand it！
Then if I want to improve the quality of matching or reduce the number of matches, which of the following parameters should I adjust?
'line_matcher_cfg': {
        'cross_check': True,
        'num_samples': 5,
        'min_dist_pts': 8,
        'top_k_candidates': 10,
        'grid_size': 4
    }

These are the optimal parameters in terms of performance and speed. You could try increasing the 'top_k_candidates' a bit for a slightly better performance, but it will also get much slower, so I would just keep all these parameters fixed.

OK，I see.
Thank you for your reply.
I wish you a happy life！


extracting template from rootsite generates incorrect result

Tokenizer incorrectly replaces document template url with {site} token when generating template from root site.
ExtractObjects in list instance does not resolve list from base template due to incorrect url matching.

i have a PR for this, you will find it here:
https://github.com/OfficeDev/PnP-Sites-Core/commit/f5a4c964c768e9f9cd1ad9aaa5aa1822a688e40c

This one should have been fixed by this: https://github.com/OfficeDev/PnP-Sites-Core/pull/326


change default dds profile from 0 to 7

See https://github.com/m-labs/artiq/pull/1584. All single frequency/amplitude operation of DDSes in the future (no ramping, etc.) should use profile 7 instead of 0.

Merge this branch after https://github.com/m-labs/artiq/issues/1809 is resolved. Currently there is a problem with get and get_mu commands with the above changes.

Merge this branch after https://github.com/m-labs/artiq/issues/1809 is resolved. Currently there is a problem with get and get_mu commands with the above changes.


[SPARK-6615][MLLIB] Python API for Word2Vec

This is the sub-task of SPARK-6254.
Wrap missing method for Word2Vec and Word2VecModel.

Test build #29479 has started for   PR 5296 at commit afb866d.

Test build #29479 has finished for   PR 5296 at commit afb866d.

This patch passes all tests.

This patch merges cleanly.

This patch adds the following public classes (experimental):

case class CreateStruct(children: Seq[NamedExpression]) extends Expression

This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29479/
Test PASSed.

Test build #29541 has started for   PR 5296 at commit e2bedfb.

Test build #29541 has finished for   PR 5296 at commit e2bedfb.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29541/
Test FAILed.

@Lewuathe Could you merge the current master? This PR contains merge conflicts.

@mengxr Thank you for reviewing. I merged current master and resolve conflict.

Test build #29673 has started for   PR 5296 at commit f14c304.

Test build #29673 has finished for   PR 5296 at commit f14c304.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29673/
Test FAILed.

LGTM. Merged into master. (The failed test is irrelevant.)
@andrewor14 @davies I have seen this test failure couple times:
org.apache.spark.deploy.yarn.YarnClusterSuite.run Python application in yarn-cluster mode

Is anyone working on it?

I'm not.

I filed https://issues.apache.org/jira/browse/SPARK-6701


Vim9: "v:exception" does not include name of executed command in compiled try/catch

Describe the bug
In Vim9 script, when an error is caught in a compiled try/catch, v:exception fails to include the name of the executed command.
To Reproduce
Run this shell command:
vim -Nu NONE -S <(cat <<'EOF'
    vim9script
    def Func()
        try
            eval [][0]
        catch
            assert_exception('eval')
        endtry
    enddef
    Func()
    echo v:errors
EOF
)

v:errors contains this string item:
['...function <SNR>1_Func line 4: Expected ''eval'' but got ''Vim:E684: list index out of range: 0''']

Expected behavior
v:errors is empty.
Environment

Vim version: 8.2 Included patches: 1-3281
OS: Ubuntu 20.04.2 LTS
Terminal: XTerm(353)

Additional context
If the code is run at the script level, v:exception correctly contains the name of the executed command:
vim9script
try
    eval [][0]
catch
    assert_exception('eval')
endtry
echo v:errors

[]

Same thing if the code is run from a legacy function:
vim9script
function EvalError()
    eval [][0]
endfunction
try
    EvalError()
catch
    assert_exception('eval')
endtry
echo v:errors

[]

Same thing if the code is run from a legacy function:

Well obviously, since the code is run at the script level.  What is interesting is that the behavior persists even when the code is compiled:
vim9script
function EvalError()
    eval [][0]
endfunction
def Func()
    try
        EvalError()
    catch
        assert_exception('eval')
    endtry
enddef
Func()
echo v:errors

[]

When an expression is compiled the command is not available. Keeping this as a context for a possible error or exception would add overhead, which isn't justified.

OK, but – for reference – this breaks a test in the minpac plugin:
try
  call minpac#add('k-takata/minpac', {'type': 'foo'})
catch
  call assert_exception('echoerr')
endtry

As a workaround, we need to give the error from a legacy function (or maybe rewrite the test in a different way).

breaks a test in the minpac plugin

I mean it breaks the test when we rewrite the plugin in Vim9.

Keeping this as a context for a possible error or exception would add overhead, which isn't justified.

Understood.  Performance is certainly more important here.


Inline hunks lose newlines with --color=never

When using --color=never inline hunks will be printed without newlines. I'd expect difft to return the same newlines as the command without --color=never.

Image as text (click to expand)
$ difft --version
Difftastic 0.36.1
$ cat one
1
2
3
$ cat two
1
2
2.5
3
$ difft one two
two --- Text
1 1 1
2 2 2
. 3 2.5
3 4 3

$ difft --color=never one two
two --- Text
1 1 12 2 2. 3 2.53 4 3

Thanks for this awesome tool!

Probably broken in 3147eb8e6aa0b6609440dce80e46b977c2d88aa4, but see also<PHONE_NUMBER>42422545c6a8acb2adc39ba9e9343c.


HTTP/2 support question

Hello, at the moment my server can only handle http1 connections. Can pipeline convert outbound http1 to http2 and inbound vice versa? I am trying to make support for both http1 and http2 at the same time. But I don't want to completely switch to http2-codec now. I'm trying to take the right road 😀
At the moment my pipeline looks like this:
ChannelPipeline pipeline = channel.pipeline();

if (httpConfig.isRedirectHttpToHttps() && domainMapping != null)
    pipeline.addLast(new SniHandler(domainMapping));

pipeline.addLast(new HttpServerCodec());

if (httpConfig.compression())
    pipeline.addLast(new HttpContentCompressor());

pipeline.addLast(new HttpServerKeepAliveHandler());
pipeline.addLast(new HttpObjectAggregator(512 * 1024, true));
pipeline.addLast(new ChunkedWriteHandler());

ChannelContext channelContext = new ChannelContext(channel);

pipeline.addLast(new InboundContentHandler(instance, channelContext));
pipeline.addLast(new OutboundContentHandler(instance, channelContext));
pipeline.addLast(new DownloadHandler(instance, channelContext));
pipeline.addLast(new UploadHandler(instance, channelContext));
pipeline.addLast(new NotFoundHandler(instance, channelContext));

How do I need to rewrite the pipeline, without reworking the half of repo? I rummaged through a bunch of related code, but because of the complex abstraction, I didn’t understand anything. I hope that you will treat this issue with understanding. Thanks 😊

https://github.com/netty/netty/tree/4.1/example/src/main/java/io/netty/example/http2/helloworld/server


[Bug] quoting config not working with 1.8

Is this a new bug in dbt-snowflake?

[X] I believe this is a new bug in dbt-snowflake
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
The quoting config doesn't quote the database anymore in 1.8 unlike it did pre-1.8.
Expected Behavior
The quoting configs should quote the database like it did pre-1.8.
Steps To Reproduce

Create a database that starts with a number:

create database "1_JYEO";

Use the database in the dbt project with quoting.database = true:

# dbt_project.yml
name: my_dbt_project
profile: all
config-version: 2
version: "1.0.0"

models:
 my_dbt_project:
    +materialized: table
    +database: 1_JYEO

quoting:
  database: true

-- models/foo.sql
select 1 id

Run on 1.8:

$ dbt --debug run

01:07:44  Sending event: {'category': 'dbt', 'action': 'invocation', 'label': 'start', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x1046b1510>, <snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x1046efa90>, <snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x1046f7fd0>]}
01:07:44  Running with dbt=1.8.1
01:07:44  running dbt with arguments {'printer_width': '80', 'indirect_selection': 'eager', 'write_json': 'True', 'log_cache_events': 'False', 'partial_parse': 'True', 'cache_selected_only': 'False', 'warn_error': 'None', 'fail_fast': 'False', 'profiles_dir': '/Users/jeremy/.dbt', 'log_path': '/Users/jeremy/git/dbt-basic/logs', 'debug': 'True', 'version_check': 'True', 'use_colors': 'True', 'use_experimental_parser': 'False', 'no_print': 'None', 'quiet': 'False', 'warn_error_options': 'WarnErrorOptions(include=[], exclude=[])', 'introspect': 'True', 'log_format': 'default', 'invocation_command': 'dbt --debug run', 'target_path': 'None', 'static_parser': 'True', 'send_anonymous_usage_stats': 'True'}
01:07:45  Sending event: {'category': 'dbt', 'action': 'project_id', 'label': '7e16f034-b8c9-429a-85e9-e728b206eccf', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x13518a5d0>]}
01:07:45  Sending event: {'category': 'dbt', 'action': 'adapter_info', 'label': '7e16f034-b8c9-429a-85e9-e728b206eccf', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x104142590>]}
01:07:45  Registered adapter: snowflake=1.8.2
01:07:45  checksum: ebc509fb14e151ea268e89b60fd5abf912ed99129f87516462718fa2f14f4838, vars: {}, profile: , target: , version: 1.8.1
01:07:45  Unable to do partial parsing because of a version mismatch
01:07:45  Sending event: {'category': 'dbt', 'action': 'partial_parser', 'label': '7e16f034-b8c9-429a-85e9-e728b206eccf', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x10335f790>]}
01:07:46  Sending event: {'category': 'dbt', 'action': 'load_project', 'label': '7e16f034-b8c9-429a-85e9-e728b206eccf', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x1353b2750>]}
01:07:46  Sending event: {'category': 'dbt', 'action': 'resource_counts', 'label': '7e16f034-b8c9-429a-85e9-e728b206eccf', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x136280b90>]}
01:07:46  Found 1 model, 558 macros
01:07:46  Sending event: {'category': 'dbt', 'action': 'runnable_timing', 'label': '7e16f034-b8c9-429a-85e9-e728b206eccf', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x136451110>]}
01:07:46
01:07:46  Acquiring new snowflake connection 'master'
01:07:46  Acquiring new snowflake connection 'list_1_JYEO'
01:07:46  Using snowflake connection "list_1_JYEO"
01:07:46  On list_1_JYEO: /* {"app": "dbt", "dbt_version": "1.8.1", "profile_name": "all", "target_name": "sf", "connection_name": "list_1_JYEO"} */
show terse schemas in database "1_JYEO"
    limit 10000
01:07:46  Opening a new connection, currently in state init
01:07:49  SQL status: SUCCESS 3 in 3.0 seconds
01:07:49  On list_1_JYEO: Close
01:07:49  Acquiring new snowflake connection 'list_1_JYEO_dbt_jyeo'
01:07:49  Using snowflake connection "list_1_JYEO_dbt_jyeo"
01:07:49  On list_1_JYEO_dbt_jyeo: /* {"app": "dbt", "dbt_version": "1.8.1", "profile_name": "all", "target_name": "sf", "connection_name": "list_1_JYEO_dbt_jyeo"} */
show objects in 1_JYEO.dbt_jyeo limit 10000
01:07:49  Opening a new connection, currently in state init
01:07:51  Snowflake adapter: Snowflake query id: 01b4d6e3-0804-b779-000d-3783366a862a
01:07:51  Snowflake adapter: Snowflake error: 001003 (42000): SQL compilation error:
syntax error line 1 at position 16 unexpected '1'.
01:07:51  Snowflake adapter: Error running SQL: macro list_relations_without_caching
01:07:51  Snowflake adapter: Rolling back transaction.
01:07:51  On list_1_JYEO_dbt_jyeo: Close
01:07:51  Connection 'master' was properly closed.
01:07:51  Connection 'list_1_JYEO' was properly closed.
01:07:51  Connection 'list_1_JYEO_dbt_jyeo' was properly closed.
01:07:51
01:07:51  Finished running  in 0 hours 0 minutes and 5.47 seconds (5.47s).
01:07:51  Encountered an error:
Database Error
  001003 (42000): SQL compilation error:
  syntax error line 1 at position 16 unexpected '1'.
01:07:51  Resource report: {"command_name": "run", "command_wall_clock_time": 7.0150514, "process_user_time": 3.133745, "process_kernel_time": 1.425414, "process_mem_max_rss": "202407936", "command_success": false, "process_in_blocks": "0", "process_out_blocks": "0"}
01:07:51  Command `dbt run` failed at 13:07:51.939918 after 7.02 seconds
01:07:51  Sending event: {'category': 'dbt', 'action': 'invocation', 'label': 'end', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x104717f10>, <snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x104717e90>, <snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x100afc310>]}
01:07:51  Flushing usage events

show objects in 1_JYEO.dbt_jyeo limit 10000 invalid.

Revert to 1.7 and then run again:

$ dbt --debug run

01:08:36  On list_1_JYEO: /* {"app": "dbt", "dbt_version": "1.7.14", "profile_name": "all", "target_name": "sf", "connection_name": "list_1_JYEO"} */
show terse schemas in database "1_JYEO"
    limit 10000
01:08:36  Opening a new connection, currently in state init
01:08:37  SQL status: SUCCESS 3 in 2.0 seconds
01:08:37  On list_1_JYEO: Close
01:08:38  Re-using an available connection from the pool (formerly list_1_JYEO, now list_1_JYEO_dbt_jyeo)
01:08:38  Using snowflake connection "list_1_JYEO_dbt_jyeo"
01:08:38  On list_1_JYEO_dbt_jyeo: /* {"app": "dbt", "dbt_version": "1.7.14", "profile_name": "all", "target_name": "sf", "connection_name": "list_1_JYEO_dbt_jyeo"} */
show terse objects in "1_JYEO".dbt_jyeo limit 10000
01:08:38  Opening a new connection, currently in state closed
01:08:40  SQL status: SUCCESS 2 in 2.0 seconds
01:08:40  On list_1_JYEO_dbt_jyeo: Close
01:08:40  Sending event: {'category': 'dbt', 'action': 'runnable_timing', 'label': '2678a36e-2a7c-4b6c-9c36-a03733b3b4ac', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x154929ad0>]}
01:08:40  Concurrency: 1 threads (target='sf')
01:08:40
01:08:40  Began running node model.my_dbt_project.foo
01:08:40  1 of 1 START sql table model 1_JYEO.dbt_jyeo.foo ............................... [RUN]
01:08:40  Re-using an available connection from the pool (formerly list_1_JYEO_dbt_jyeo, now model.my_dbt_project.foo)
01:08:40  Began compiling node model.my_dbt_project.foo
01:08:40  Writing injected SQL for node "model.my_dbt_project.foo"
01:08:40  Timing info for model.my_dbt_project.foo (compile): 13:08:40.768038 => 13:08:40.773299
01:08:40  Began executing node model.my_dbt_project.foo
01:08:40  Writing runtime sql for node "model.my_dbt_project.foo"
01:08:40  Using snowflake connection "model.my_dbt_project.foo"
01:08:40  On model.my_dbt_project.foo: /* {"app": "dbt", "dbt_version": "1.7.14", "profile_name": "all", "target_name": "sf", "node_id": "model.my_dbt_project.foo"} */
create or replace transient table "1_JYEO".dbt_jyeo.foo
         as
        (select 1 id
        );
01:08:40  Opening a new connection, currently in state closed
01:08:42  SQL status: SUCCESS 1 in 2.0 seconds
01:08:42  Timing info for model.my_dbt_project.foo (execute): 13:08:40.773821 => 13:08:42.848314
01:08:42  On model.my_dbt_project.foo: Close
01:08:43  Sending event: {'category': 'dbt', 'action': 'run_model', 'label': '2678a36e-2a7c-4b6c-9c36-a03733b3b4ac', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x154ada510>]}
01:08:43  1 of 1 OK created sql table model 1_JYEO.dbt_jyeo.foo .......................... [SUCCESS 1 in 2.71s]

show terse objects in "1_JYEO".dbt_jyeo limit 10000 valid.

Relevant log output
No response
Environment
- OS: macOS
- Python: 3.11
- dbt-core: 1.8.2
- dbt-snowflake: 1.8.2

Additional Context
I don't think schema quoting is working either.
1.8:
https://github.com/dbt-labs/dbt-snowflake/blob/cc1388885c596a251489e65d6a8f97a0985a000e/dbt/include/snowflake/macros/adapters.sql#L127
1.7:
https://github.com/dbt-labs/dbt-snowflake/blob/f1fc9480a8dcf9b28c5cd9b070a044cf63714894/dbt/include/snowflake/macros/adapters.sql#L127

I am experiencing something similar when quoting columns on sources. It appears to work on unit_tests but in a dbt build it errors because it looks like quotes are not being added. I see it on 1.8.3 also, which appears to have this bug fix on it. Thanks!

I am experiencing something similar when quoting columns on sources. It appears to work on unit_tests but in a dbt build it errors because it looks like quotes are not being added. I see it on 1.8.3 also, which appears to have this bug fix on it. Thanks!

Do you have a cheeky repro? Unit tests are brand new in 1.8 so it's not really an apples to apples with this issue per se - which is a regression of the quoting config in 1.7 > 1.8. In any case, a quick sense check on:
Core:
  - installed: 1.8.3
  - latest:    1.8.3 - Up to date!
Plugins:
  - snowflake: 1.8.3 - Up to date!

-- create table to test - reserved keyword as col name
create or replace table development_jyeo.dbt_jyeo.raw as (select 1 as "create");

# models/sources.yml
version: 2
sources:
  - name: dbt_jyeo
    tables:
      - name: raw
        columns:
          - name: create
            data_tests:
              - not_null

$ dbt --debug test
22:14:41  On test.my_dbt_project.source_not_null_dbt_jyeo_raw_create.f79610167c: /* {"app": "dbt", "dbt_version": "1.8.3", "profile_name": "all", "target_name": "sf", "node_id": "test.my_dbt_project.source_not_null_dbt_jyeo_raw_create.f79610167c"} */
select
      count(*) as failures,
      count(*) != 0 as should_warn,
      count(*) != 0 as should_error
    from (

select create
from development_jyeo.dbt_jyeo.raw
where create is null

    ) dbt_internal_test
22:14:41  Opening a new connection, currently in state closed
22:14:43  Snowflake adapter: Snowflake query id: 01b56876-0905-0194-000d-378339bd9326
22:14:43  Snowflake adapter: Snowflake error: 001003 (42000): SQL compilation error:
syntax error line 12 at position 7 unexpected 'create'.
syntax error line 14 at position 6 unexpected 'create'.
22:14:43  On test.my_dbt_project.source_not_null_dbt_jyeo_raw_create.f79610167c: Close
22:14:44  Database Error in test source_not_null_dbt_jyeo_raw_create (models/sources.yml)
  001003 (42000): SQL compilation error:
  syntax error line 12 at position 7 unexpected 'create'.
  syntax error line 14 at position 6 unexpected 'create'.
  compiled Code at target/run/my_dbt_project/models/sources.yml/source_not_null_dbt_jyeo_raw_create.sql
22:14:44  1 of 1 ERROR source_not_null_dbt_jyeo_raw_create ............................... [ERROR in 2.27s]

Error as expected. Add quote config on column:
version: 2
sources:
  - name: dbt_jyeo
    tables:
      - name: raw
        columns:
          - name: create
            quote: true
            data_tests:
              - not_null

$ dbt --debug test
22:15:46  On test.my_dbt_project.source_not_null_dbt_jyeo_raw__create_.56364b7a58: /* {"app": "dbt", "dbt_version": "1.8.3", "profile_name": "all", "target_name": "sf", "node_id": "test.my_dbt_project.source_not_null_dbt_jyeo_raw__create_.56364b7a58"} */
select
      count(*) as failures,
      count(*) != 0 as should_warn,
      count(*) != 0 as should_error
    from (

select "create"
from development_jyeo.dbt_jyeo.raw
where "create" is null

    ) dbt_internal_test
22:15:46  Opening a new connection, currently in state closed
22:15:47  SQL status: SUCCESS 1 in 2.0 seconds
22:15:47  On test.my_dbt_project.source_not_null_dbt_jyeo_raw__create_.56364b7a58: Close
22:15:48  1 of 1 PASS source_not_null_dbt_jyeo_raw__create_ .............................. [PASS in 2.26s]

Works as expected.
This is not a unit test though - not yet familiar with how to set that up.

Interesting when I do this in my project quote: true doesn't do anything. I do find that I need to delete the target folder anytime I change the related schema.yml file otherwise I get an error about two of the same source. I am on 1.8.4 core and 1.8.3 dbt-snowflake. I will revisit this when I have more time. Thanks for the help here @jeremyyeo!


Upgrade Go in Dockerfile and use smaller build image

Signed-off-by: KeisukeYamashita<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:
Upgrade Go to 1.16 and use smaller build images.
Which issue(s) this PR fixes:

None.
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign keisukeyamashita after the PR has been reviewed.
You can assign the PR to them by writing /assign @keisukeyamashita in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: c83fb8d11f87b05bf5fdedc3d270ac0231be7b41


Is there any way to disable the auto selection of the first suggestion?

This would be useful when implementing a search box where pressing the enter key with no suggestion selected would be used to issue a full search.
Pressing the down arrow would select the first suggestion.
Would a new event be needed to when enter is pressed with no suggestion selected.
At the moment the suggestions can be cleared with esc but I don't think there enter fires an event in this case.
Thanks

Have you found a solution for this?

Sorry, I don't think so. I have just checked the app that uses this and we use the tab key to tab to a search button to issue the search rather than except the first suggestion.

As a workaround you can use the process method to add a dummy value.   For example, here's a method that does this and also sets a max number of 5 results to display.
    process(results) {
      const ret = results.locations.slice(0, 5)
      ret.unshift({
        id: 0,
        name: 'Please choose...'
      })
      return ret
    },


Fixed quantity alignment of order page #7595

Coverage remained the same at 68.69% when pulling 56d4fb75f77391369ede3c19e84fecb3dd050f26 on gautampanday:fix-quantity into ef8fc9e96ea81c37bf39ad6190d5fd8a57319d26 on openlabs:develop.


H2 doesnt support key in create table

https://github.com/bgranvea/mysql2h2-converter/pull/8

It's been a long time since I've looked at this code but it looks like it's made its way into master already.


Fix missing IMAGE_NAME from deploy step

Issue/Task Number: -
Overview
Fix missing IMAGE_NAME env var from circleci's deploy step.
Changes

Add IMAGE_NAME to deploy executor

Implementation Details
Add IMAGE_NAME to fix the error:
sh .circleci/ci_deploy.sh

#!/bin/bash -eo pipefail
  sh .circleci/ci_deploy.sh

IMAGE_NAME has not been set.
Exited with code 1

Usage
N/A
Impact
N/A

Nope the image name wasn't needed during build but needed for publishing


Add user guide for page editor

The page editor has become much more complex. This page describes how to
use it and what features it has available.
In addition, I moved all of our help pages to be under /proofing/help. I did so
because I had a local Flask error where Flask thought editor-guide was
a project slug and attempted to load the project.summary route
instead. (The error was resolved by using /editor-guide2 or
/editor-guide3, but /editor-guide specifically fails. I'm not sure
why.) This issue suggests two potential problems going forward:

We should be careful about adding new slugs to the proofing
namespace since they can interact strangely with project.summary.

In fact, we should probably just namespace projects under a new
projects prefix. This is also avoids a potential issue where a new
project has the same slug as a toplevel page like /beginners-guide.

For (1), I'm moving these under help. I'll consider (2) going forward.
Test plan: loaded the page. I considered embedding richer versions of
the menu bar so that the user could experiment with its JS, but that
produces some quite strong coupling between a simple help page and the
underlying JS logic, which seems excessive to me right now.

Also adding @shreevatsa for review based on his passion for new user onboarding.

The easiest way to view this page is to git checkout origin/proofer--help then open localhost:5000/proofing/help/editor-guide.

Looks good. Can you add a quick screenshot of the new page so it's easier to review?

It's a little long, but here are some representative screenshots:

I'll add some more detail now on what the specific buttons do. I was feeling lazy, but seeing it in a screenshot, it doesn't give me a good feeling.

Updated, ready for another look. I think the best way to view the page is still to check out the branch.


[C++ Comm] Enable compat tests everywhere.

With this change, comm compat tests build and pass everywhere.

This is error is showing up on the Windows side:
[00:10:42] C:\projects\bond\cpp\test\compat\comm\commcompat.cpp(58): error C2220: warning treated as error - no 'object' file generated [C:\projects\bond\build\cpp\test\compat\comm\comm_compatibility_test.vcxproj]
[00:10:42] C:\projects\bond\cpp\test\compat\comm\commcompat.cpp(58): warning C4002: too many actual parameters for macro 'popen' [C:\projects\bond\build\cpp\test\compat\comm\comm_compatibility_test.vcxproj]
[00:10:42] C:\projects\bond\cpp\test\compat\comm\commcompat.cpp(58): error C2660: '_popen': function does not take 1 arguments [C:\projects\bond\build\cpp\test\compat\comm\comm_compatibility_test.vcxproj]
[00:10:43] C:\projects\bond\cpp\test\compat\comm\commcompat.cpp(82): error C2660: '_popen': function does not take 1 arguments [C:\projects\bond\build\cpp\test\compat\comm\comm_compatibility_test.vcxproj]

Looks good. Failures are not related.


[Fix] sc-27574 Fix github report security alert

Force to use<EMAIL_ADDRESS>
Signed-off-by: Kent Huang<EMAIL_ADDRESS>
** PR checklist **

[x] Ensure you have added or ran the appropriate tests for your PR.
[x] DCO signed

What type of PR is this?
Security patch
What this PR does / why we need it:

Fix github report security alert
Force to use<EMAIL_ADDRESS>
Which issue(s) this PR fixes:
sc-27574
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Ref: https://github.com/facebook/create-react-app/issues/12132#issuecomment-1149787462


Events in Stackdriver page - is outdated and third-party specific (Google)

This page: https://kubernetes.io/docs/tasks/debug-application-cluster/events-stackdriver/ should be removed. Why?

Out-dated information - screenshots are old, product name is old
It's specific to a third-party, namely Google, and K8s docs should be agnostic.

Related to PR #24769.

Related to PR #24769.

/triage duplicate

/triage duplicate

Ah no, #24769 is a PR.
/remove-triage duplicate

Ah no, #24769 is a PR.
/remove-triage duplicate

Part of issue #20232
/triage accepted

Part of issue #20232
/triage accepted

/kind cleanup
/language en

/kind cleanup
/language en

PR #24769 has merged.
This issue can close. If there are additional questions, feel free to reopen this issue.
/close


KENLM_ROOT_DIR doesn't work if it points to the installation directoy

Bug Description
If the env variable KENLM_ROOT_DIR points to the Kenlm installation directory instead of the git working copy it fails to find the required components. This is caused because when installing Kelnm the includes are located in include/kenlm (check here).
Reproduction Steps
# Install other required packages
# Install Kelnm
git clone --recursive --shallow	-submodules --depth 1 https://github.com/kpu/kenlm.git
cd kenlm
cmake -B build -S . -Wno-dev -DCMAKE_BUILD_TYPE="Release" -DCMAKE_INSTALL_PREFIX="/opt/kenlm" -DCMAKE_POSITION_INDEPENDENT_CODE=ON
cmake --build build -j`nproc`
sudo make -C build install -j`nproc`
cd ..
export KENLM_ROOT_DIR=/opt/kenlm
export MKLROOT=/opt/intel/mkl

# Build flashlight
git clone --recursive --shallow	-submodules --depth 1 https://github.com/facebookresearch/flashlight.git
cd flashlight
cmake -B build -S .

Yes. It's worth to mention that now the variable is called KENLM_ROOT.


update: added independent param to NavigationContainer

Adding binding for prop - independent to be able to accommodate nested independent NavigationContainer

@Freddy03h @MoOx

@witcher-shailesh I'm ok to merge it, but it seems it will be removed in the 7.xversion of react-navigation, replaced by a <NavigationIndependentTree> component.
Are you ok with that?

Thanks @Freddy03h, yes it should be fine for our current usecase. Later I can add bindings for the NavigationIndependentTree


RevEng: Consider a base class for IAnnotationRenderer

Base class would return false/null indicating it cannot process the annotation. Providers can override only methods for which they can understand annotations.

fixed in #8669


HttpMessageNotReadableException occurs when handling a request.

Serverless Java Container version: 2.0.0-M1
Implementations: Spring Boot 3
Framework version: SpringBoot 3.1.0
Frontend service: HTTP API
Deployment method: Console
Scenario
I've tried to deploy a simple GraphQL API using spring-boot-starter-graphql and aws-serverless-java-conainer-springboot3.
When I run it on a local environment using Tomcat, the request is processed normally. However, when I deploy it on AWS Lambda, I get an org.springframework.http.converter.HttpMessageNotReadableException: JSON parse error: No content to map due to end-of-input error.
It seems error occurs while handling request.
I've been trying to solve it for three-full-days, but it hasn't been resolved. Any help would be appreciated.
Expected behavior
200 response should come when a request is sent to http api gateway url using curl.
curl 'https://[APIGATEWAY_URL]/graphql' -H 'Accept-Encoding: gzip, deflate, br' -H 'Content-Type: application/json' -H 'Accept: application/json' -H 'Connection: keep-alive' -H 'Origin: altair://-' --data-binary '{"query":"query example{\n  exampleQuery(input: { id: 1 }) {\n    ok\n  }\n}\n","variables":{}}' --compressed

Actual behavior
An error occurs as shown in the log below.
Steps to reproduce
This is the smallest project repository that can reproduce the error.
https://github.com/2012160085/photomanagement
Full log output
START RequestId: 5beefda9-8340-4539-a1b1-c1e154571024 Version: $LATEST
--
2023-05-31T07:18:56.999Z TRACE 8 --- [           main] o.s.b.w.s.f.OrderedRequestContextFilter  : Bound request context to thread: com.amazonaws.serverless.proxy.internal.servlet.AwsProxyHttpServletRequest@450794b4
2023-05-31T07:18:57.000Z TRACE 8 --- [           main] o.s.web.servlet.DispatcherServlet        : POST "/graphql", parameters={}, headers={masked} in DispatcherServlet 'dispatcherServlet'
2023-05-31T07:18:57.000Z TRACE 8 --- [           main] o.s.w.s.function.RequestPredicates       : Method "[GET]" does not match against value "POST"
2023-05-31T07:18:57.000Z TRACE 8 --- [           main] o.s.w.s.function.RequestPredicates       : Method "[POST]" matches against value "POST"
2023-05-31T07:18:57.000Z TRACE 8 --- [           main] o.s.w.s.function.RequestPredicates       : Pattern "/graphql" matches against value "/graphql"
2023-05-31T07:18:57.000Z TRACE 8 --- [           main] o.s.w.s.function.RequestPredicates       : Content-Type "[application/json]" matches against value "application/json;charset=UTF-8"
2023-05-31T07:18:57.000Z TRACE 8 --- [           main] o.s.w.s.function.RequestPredicates       : Accept "[application/graphql-response+json, application/json, application/graphql+json]" matches against value "[application/json]"
2023-05-31T07:18:57.000Z TRACE 8 --- [           main] o.s.w.servlet.function.RouterFunctions   : Predicate "((POST && /graphql) && (Content-Type: application/json && Accept: [application/graphql-response+json, application/json, application/graphql+json]))" matches against "HTTP POST /graphql"
2023-05-31T07:18:57.000Z TRACE 8 --- [           main] o.s.w.s.f.support.RouterFunctionMapping  : Mapped to org.springframework.boot.autoconfigure.graphql.servlet.GraphQlWebMvcAutoConfiguration$Lambda$909/0x0000000801c42aa0@332a7fce
2023-05-31T07:18:57.001Z DEBUG 8 --- [           main] o.s.g.server.webmvc.GraphQlHttpHandler   : Executing: document='query example{
exampleQuery(input: { id: 1 }) {
ok
}
}
', operationName='example', id=a1e5941b-7608-2e7e-389f-de1c93d105df, Locale=ko
2023-05-31T07:18:57.003Z TRACE 8 --- [           main] o.s.b.f.s.DefaultListableBeanFactory     : Returning cached instance of singleton bean 'exampleController'
2023-05-31T07:18:57.003Z TRACE 8 --- [           main] o.s.graphql.data.method.HandlerMethod    : Arguments: [TestInput(id=1)]
2023-05-31T07:18:57.003Z DEBUG 8 --- [           main] o.s.g.server.webmvc.GraphQlHttpHandler   : Execution complete
2023-05-31T07:18:57.004Z DEBUG 8 --- [           main] o.s.w.c.request.async.WebAsyncManager    : Started async request
2023-05-31T07:18:57.004Z DEBUG 8 --- [           main] o.s.w.c.request.async.WebAsyncManager    : Async result set, dispatch to /graphql
2023-05-31T07:18:57.004Z TRACE 8 --- [           main] o.s.web.servlet.DispatcherServlet        : "ASYNC" dispatch for POST "/graphql", parameters={}, headers={masked} in DispatcherServlet 'dispatcherServlet'
2023-05-31T07:18:57.004Z TRACE 8 --- [           main] o.s.w.s.function.RequestPredicates       : Method "[GET]" does not match against value "POST"
2023-05-31T07:18:57.004Z TRACE 8 --- [           main] o.s.w.s.function.RequestPredicates       : Method "[POST]" matches against value "POST"
2023-05-31T07:18:57.004Z TRACE 8 --- [           main] o.s.w.s.function.RequestPredicates       : Pattern "/graphql" matches against value "/graphql"
2023-05-31T07:18:57.004Z TRACE 8 --- [           main] o.s.w.s.function.RequestPredicates       : Content-Type "[application/json]" matches against value "application/json;charset=UTF-8"
2023-05-31T07:18:57.004Z TRACE 8 --- [           main] o.s.w.s.function.RequestPredicates       : Accept "[application/graphql-response+json, application/json, application/graphql+json]" matches against value "[application/json]"
2023-05-31T07:18:57.004Z TRACE 8 --- [           main] o.s.w.servlet.function.RouterFunctions   : Predicate "((POST && /graphql) && (Content-Type: application/json && Accept: [application/graphql-response+json, application/json, application/graphql+json]))" matches against "HTTP POST /graphql"
2023-05-31T07:18:57.004Z TRACE 8 --- [           main] o.s.w.s.f.support.RouterFunctionMapping  : Mapped to org.springframework.boot.autoconfigure.graphql.servlet.GraphQlWebMvcAutoConfiguration$Lambda$909/0x0000000801c42aa0@332a7fce
2023-05-31T07:18:57.005Z  WARN 8 --- [           main] .w.s.m.s.DefaultHandlerExceptionResolver : Resolved [org.springframework.http.converter.HttpMessageNotReadableException: JSON parse error: No content to map due to end-of-input]
2023-05-31T07:18:57.005Z TRACE 8 --- [           main] o.s.web.servlet.DispatcherServlet        : No view rendering, null ModelAndView returned.
2023-05-31T07:18:57.005Z DEBUG 8 --- [           main] o.s.web.servlet.DispatcherServlet        : Exiting from "ERROR" dispatch, status 400, headers={}
2023-05-31T07:18:57.005Z TRACE 8 --- [           main] o.s.web.servlet.DispatcherServlet        : No view rendering, null ModelAndView returned.
2023-05-31T07:18:57.005Z DEBUG 8 --- [           main] o.s.web.servlet.DispatcherServlet        : Exiting from "ERROR" dispatch, status 400, headers={}
2023-05-31T07:18:57.005Z TRACE 8 --- [           main] o.s.b.w.s.f.OrderedRequestContextFilter  : Cleared thread-bound request context: com.amazonaws.serverless.proxy.internal.servlet.AwsProxyHttpServletRequest@450794b4
2023-05-31T07:18:57.005Z  INFO 8 --- [           main] c.a.s.p.internal.LambdaContainerHandler  : <IP_ADDRESS> null- null [31/05/2023:07:18:56Z] "POST /graphql HTTP/1.1" 400 - "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) AltairGraphQLClient/5.0.20 Chrome/102.0.5005.167 Electron/19.0.10 Safari/537.36" combined
END RequestId: 5beefda9-8340-4539-a1b1-c1e154571024
REPORT RequestId: 5beefda9-8340-4539-a1b1-c1e154571024	Duration: 9.80 ms	Billed Duration: 10 ms	Memory Size: 1024 MB	Max Memory Used: 192 MB

For comparision, local log with Tomcat.
2023-05-31T16:37:45.233+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.b.w.s.f.OrderedRequestContextFilter  : Bound request context to thread: org.apache.catalina.connector.RequestFacade@4890085a
2023-05-31T16:37:45.234+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.web.servlet.DispatcherServlet        : POST "/graphql", parameters={}, headers={masked} in DispatcherServlet 'dispatcherServlet'
2023-05-31T16:37:45.235+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.w.s.function.RequestPredicates       : Method "[GET]" does not match against value "POST"
2023-05-31T16:37:45.235+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.w.s.function.RequestPredicates       : Method "[POST]" matches against value "POST"
2023-05-31T16:37:45.235+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.w.s.function.RequestPredicates       : Pattern "/graphql" matches against value "/graphql"
2023-05-31T16:37:45.235+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.w.s.function.RequestPredicates       : Content-Type "[application/json]" matches against value "application/json;charset=UTF-8"
2023-05-31T16:37:45.235+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.w.s.function.RequestPredicates       : Accept "[application/graphql-response+json, application/graphql+json, application/json]" matches against value "[application/json]"
2023-05-31T16:37:45.235+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.w.servlet.function.RouterFunctions   : Predicate "((POST && /graphql) && (Content-Type: application/json && Accept: [application/graphql-response+json, application/graphql+json, application/json]))" matches against "HTTP POST /graphql"
2023-05-31T16:37:45.235+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.w.s.f.support.RouterFunctionMapping  : Mapped to org.springframework.boot.autoconfigure.graphql.servlet.GraphQlWebMvcAutoConfiguration$$Lambda$1053/0x000000080145ab38@7c1a8f0f
2023-05-31T16:37:45.236+09:00 DEBUG 47111 --- [nio-8080-exec-8] o.s.g.server.webmvc.GraphQlHttpHandler   : Executing: document='query example{
  exampleQuery(input: { id: 1 }) {
    ok
  }
}
', operationName='example', id=9681b2c4-bd16-f0fb-6997-6098e9a2736f, Locale=ko
2023-05-31T16:37:45.239+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.b.f.s.DefaultListableBeanFactory     : Returning cached instance of singleton bean 'exampleController'
2023-05-31T16:37:45.240+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.graphql.data.method.HandlerMethod    : Arguments: [TestInput(id=1)]
2023-05-31T16:37:45.240+09:00 DEBUG 47111 --- [nio-8080-exec-8] o.s.g.server.webmvc.GraphQlHttpHandler   : Execution complete
2023-05-31T16:37:45.241+09:00 DEBUG 47111 --- [nio-8080-exec-8] o.s.w.c.request.async.WebAsyncManager    : Started async request
2023-05-31T16:37:45.241+09:00 DEBUG 47111 --- [nio-8080-exec-8] o.s.w.c.request.async.WebAsyncManager    : Async result set, dispatch to /graphql
2023-05-31T16:37:45.241+09:00 DEBUG 47111 --- [nio-8080-exec-8] o.s.web.servlet.DispatcherServlet        : Exiting but response remains open for further handling
2023-05-31T16:37:45.241+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.b.w.s.f.OrderedRequestContextFilter  : Cleared thread-bound request context: org.apache.catalina.connector.RequestFacade@4890085a
2023-05-31T16:37:45.241+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.b.w.s.f.OrderedRequestContextFilter  : Bound request context to thread: org.apache.catalina.core.ApplicationHttpRequest@4f70ef6c
2023-05-31T16:37:45.242+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.web.servlet.DispatcherServlet        : "ASYNC" dispatch for POST "/graphql", parameters={}, headers={masked} in DispatcherServlet 'dispatcherServlet'
2023-05-31T16:37:45.242+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.w.s.function.RequestPredicates       : Method "[GET]" does not match against value "POST"
2023-05-31T16:37:45.242+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.w.s.function.RequestPredicates       : Method "[POST]" matches against value "POST"
2023-05-31T16:37:45.242+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.w.s.function.RequestPredicates       : Pattern "/graphql" matches against value "/graphql"
2023-05-31T16:37:45.243+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.w.s.function.RequestPredicates       : Content-Type "[application/json]" matches against value "application/json;charset=UTF-8"
2023-05-31T16:37:45.243+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.w.s.function.RequestPredicates       : Accept "[application/graphql-response+json, application/graphql+json, application/json]" matches against value "[application/json]"
2023-05-31T16:37:45.243+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.w.servlet.function.RouterFunctions   : Predicate "((POST && /graphql) && (Content-Type: application/json && Accept: [application/graphql-response+json, application/graphql+json, application/json]))" matches against "HTTP POST /graphql"
2023-05-31T16:37:45.243+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.w.s.f.support.RouterFunctionMapping  : Mapped to org.springframework.boot.autoconfigure.graphql.servlet.GraphQlWebMvcAutoConfiguration$$Lambda$1053/0x000000080145ab38@7c1a8f0f
2023-05-31T16:37:45.243+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.w.s.f.s.HandlerFunctionAdapter       : Resume with async result [org.springframework.web.servlet.function.DefaultEntityResponseBuilder$DefaultEntityResponse@67450a4c]
2023-05-31T16:37:45.244+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.web.servlet.DispatcherServlet        : No view rendering, null ModelAndView returned.
2023-05-31T16:37:45.244+09:00 DEBUG 47111 --- [nio-8080-exec-8] o.s.web.servlet.DispatcherServlet        : Exiting from "ASYNC" dispatch, status 200, headers={masked}
2023-05-31T16:37:45.244+09:00 TRACE 47111 --- [nio-8080-exec-8] o.s.b.w.s.f.OrderedRequestContextFilter  : Cleared thread-bound request context: org.apache.catalina.core.ApplicationHttpRequest@4f70ef6c

Quick update; Based on my current observation it appears that the GraphQl configurations are not picked up. Trying to determine why  . .

@2012160085 for my curiosity do you see the following message in the AWS logs
Resolved location pattern [classpath:graphql/**/*.graphqls] to resources [file [/Users. . . .

OR do you see it like this
Resolved location pattern [classpath:graphql/**/*.graphqls] to resources []

I see the following log from AWS Lambda.
Resolved location pattern [classpath:graphql/**/*.graphqls] to resources [file [/var/task/graphql/schema.graphqls]]

closed by mistake. sorry..

I just realised, you can remove the
@RequestMapping(path="/hi", method=RequestMethod.GET, produces = {"text/plain"})
    public Mono<String> hi() {
        return Mono.just(HELLO_MESSAGE);
    }

accidental leftover


State Sync fails on umeemania-1 w/ umeed-v2.0.3-rc2 on Apple Silicon M1 (arm)

Summary of Bug
State Sync fails on umeemania-1 w/ umeed-v2.0.3-rc2 on Apple Silicon M1 (arm)
Version
Please provide the output of the following commands:

$ umeed version : umeed-v2.0.3-rc2
$ go version : N/A built from ci
$ uname -a : Darwin deserteagle.local 21.4.0 Darwin Kernel Version 21.4.0: Fri Mar 18 00:46:32 PDT 2022; root:xnu-8020.101.4~15/RELEASE_ARM64_T6000 arm64

Steps to Reproduce
Steps to reproduce the behavior:

setup statesync against umeemania-1 with these witness servers and settings:

[statesync]
enable = true
rpc_servers = "https://rpc.alley.umeemania-1.network.umee.cc:443,https://rpc.festival.umeemania-1.network.umee.cc:443"
trust_height = 1210000
trust_hash = "089D9DB7AC8A38BCEA9EAB6C3E076CDA22B81B3026C30472FC23612B117F116F"
trust_period = "3000h"

setup persistent peers:

persistent_peers = "67cd50cac0eff503a7c9efd537d369cc7a3ebe96@<IP_ADDRESS>:26656,08f30f7119ae1317082d50fac6a08e6f2400126f@<IP_ADDRESS>:26656"

wait until you get a LastAppHash failure (~30 mins)

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

10:16AM INF committed state app_hash=E2541C6088FF3A063B598C824992DD7EC782AA589C1C27886E95119E24C337AC height=1211900 module=state num_txs=1
10:16AM INF Fast Sync Rate blocks/s=6.287607404569742 height=1211900 max_peer_height=1216217 module=blockchain
panic: failed to process committed block (1211901:625D9A3842F6A13AE97C2F4FFAF12569757CAB9D3D417A2B7EE0E0BE7CB21980): wrong Block.Header.LastResultsHash.  Expected 4DC8EAC516E66DA11D91B422061F449467040FF528E65806A848CBAA045110C0, got C1ECA3658BB19FD9BCAD17C80AE68E1A6E3A546591499A0A8790C24EC0CC3AA5 [recovered]
	panic: failed to process committed block (1211901:625D9A3842F6A13AE97C2F4FFAF12569757CAB9D3D417A2B7EE0E0BE7CB21980): wrong Block.Header.LastResultsHash.  Expected 4DC8EAC516E66DA11D91B422061F449467040FF528E65806A848CBAA045110C0, got C1ECA3658BB19FD9BCAD17C80AE68E1A6E3A546591499A0A8790C24EC0CC3AA5
last events:
0: scBlockReceived{1211907#2E5C6ECF690901CE4FB8A0F8C6750C4F9EE20252C9B392E809BF94252EB32965 from 08f30f7119ae1317082d50fac6a08e6f2400126f}
1: scBlockReceived{1211897#D6D2D26DD75247FEF129D26C340784787A12871B358000803D3E865587E90B48 from 244d611c2ee9a0a00a1c88b55e439fca661d8875}
2: scBlockReceived{1211898#C960483B5A20814860C9DF36934C3EBE9513DCE5F52B7F748F4D098BA7510839 from 08f30f7119ae1317082d50fac6a08e6f2400126f}
3: scBlockReceived{1211899#05F8F4A7BF53940F4DC1C754B663D9C82D8AF94B2379EAE64AC6EB440DCFB199 from 0eb962508b9d82629005142fc8aed7e3f225c3d3}
4: scBlockReceived{1211900#3C8B1CD32529C67AB3EDBCD0432AB0A9BE5EBEAAE853BACC902001B5575D19C1 from 08f30f7119ae1317082d50fac6a08e6f2400126f}
5: scBlockReceived{1211901#625D9A3842F6A13AE97C2F4FFAF12569757CAB9D3D417A2B7EE0E0BE7CB21980 from 0eb962508b9d82629005142fc8aed7e3f225c3d3}
6: scBlockReceived{1211902#A924D3FEE173FD0868F8C3F0452E426E92ABDE095715F459AC18AA9FE81475D5 from 08f30f7119ae1317082d50fac6a08e6f2400126f}
7: scBlockReceived{1211890#22C0642FD9E7D49D70AF6AC6AF2CF0AF55E2531DC345E8E9BDA7294178FA9FC8 from 08f30f7119ae1317082d50fac6a08e6f2400126f}
8: scBlockReceived{1211892#7D27AC5EA5B24A43CE61842AC81F05BD064EE45C371AD7F699BE6AE030B3058C from 08f30f7119ae1317082d50fac6a08e6f2400126f}
9: scBlockReceived{1211891#1E0ABF19E1A7A800FEDE070AE6E7BC4E6B3E842FE789491FB3378C598B41F5D5 from 0eb962508b9d82629005142fc8aed7e3f225c3d3}
10: scBlockReceived{1211893#508FA219EB7A65425DA02453A6EC4A3475EBEECF0229452EA1720B76F09CD4F2 from 244d611c2ee9a0a00a1c88b55e439fca661d8875}
11: scBlockReceived{1211895#91C24DCB5A307252FE6B25B02CF86635A6CB9AA47CBF060526F7A0CA463210F6 from 0eb962508b9d82629005142fc8aed7e3f225c3d3}
12: scBlockReceived{1211896#3B8F9BFE30FE71392BF4F61A1C06687D2E25B52FD6F365B3F813DEE07C0828F4 from 08f30f7119ae1317082d50fac6a08e6f2400126f}
13: scBlockReceived{1211894#D7ED4E7C4636E8E2EA245C24B38E9BCD6CB7D3CA8AD1B20384C33107F09644ED from 08f30f7119ae1317082d50fac6a08e6f2400126f}
14: scBlockReceived{1211884#6A21358880914CFFCAFCEC1BB29D7BFE3598AA9B2F1E0977C20D5C99E9267767 from 0eb962508b9d82629005142fc8aed7e3f225c3d3}
15: scBlockReceived{1211885#AEC73034442CA76EC9161FA80E5A27570C56D4ED3FB569FCA09995C2786C9F1D from 08f30f7119ae1317082d50fac6a08e6f2400126f}
16: scBlockReceived{1211887#F9D924923C254733C3071FFEB3881EDE73DA417FA672D1C8D02B3388CB3FA3B8 from 08f30f7119ae1317082d50fac6a08e6f2400126f}
17: scBlockReceived{1211886#BAD7028706520C2F8EF8F8B3498AEE3BED567EEAE714D2AFAE411D9B41A7E75A from 244d611c2ee9a0a00a1c88b55e439fca661d8875}
18: scBlockReceived{1211889#C00508C9823F82B4BA8A2D718E8EA697E692B9626F1610B7E34DFE06314BD065 from 4074c562a9e65312827987c77e49047697e6d60e}
19: scBlockReceived{1211883#E5476918BCB21A5CBCC79F308AEB514803F68A8C56B469A48A9CBF558AC264BE from 08f30f7119ae1317082d50fac6a08e6f2400126f}
20: scBlockReceived{1211888#C54BE255D54D2A873444CCDF1C8E6F6D3A4439AC68E3E7CEBF3303B8AF62339B from 0eb962508b9d82629005142fc8aed7e3f225c3d3}
21: scBlockReceived{1211877#3DE9B0B0B9942941FCCBFD534B0E4833767121BDEB84855870EA7D7772C63457 from 0eb962508b9d82629005142fc8aed7e3f225c3d3}
22: scBlockReceived{1211878#A4F5E7E410D7B712C4A8E7CA4BD18120EBE78B405A2EF8059E7BE5B7106CC78B from 08f30f7119ae1317082d50fac6a08e6f2400126f}
23: scBlockReceived{1211879#EE92BE96CFDF4BC87FAB3E6B2B54217198D6111641CBC49E6640DDE0D7ACF6BB from 244d611c2ee9a0a00a1c88b55e439fca661d8875}
24: scBlockReceived{1211880#F34D38954CCFC4F3895206837F4F5B2568D76B0EC5B613586B34FD003F792FE6 from 08f30f7119ae1317082d50fac6a08e6f2400126f}

goroutine 448 [running]:
github.com/tendermint/tendermint/blockchain/v2.(*Routine).start.func1()
	github.com/tendermint/tendermint@v0.34.19/blockchain/v2/routine.go:77 +0x234
panic({0x106a48ce0, 0x1406090e9e0})
	runtime/panic.go:838 +0x204
github.com/tendermint/tendermint/blockchain/v2.(*pcState).handle(0x140005f0060, {0x106d4b5f8?, 0x107c4cbc0?})
	github.com/tendermint/tendermint@v0.34.19/blockchain/v2/processor.go:182 +0x704
github.com/tendermint/tendermint/blockchain/v2.(*Routine).start(0x140011c4540)
	github.com/tendermint/tendermint@v0.34.19/blockchain/v2/routine.go:94 +0x204
created by github.com/tendermint/tendermint/blockchain/v2.(*BlockchainReactor).startSync
	github.com/tendermint/tendermint@v0.34.19/blockchain/v2/reactor.go:152 +0x15c
[1]  + exit 2     nohup umeed-v2.0.3-rc2 start &>> umeed.log```

duplicates  #826


[BUG] Restore from snapshot not work if target VM is restore-replaced from backup

Description
Restore from snapshot not work if target VM is restore-replaced from backup
Environment

Harvester

Version: v1.2.1-rc1
Profile: QEMU/KVM, 3 node (8C/16G/250G)
ui-source: Auto

To Reproduce

Note Click "►" to expand details.

Config backup-target ${~~~\color{green}\textsf{V}}$

Create VM, wait VM `Running` ${~~~\color{green}\textsf{V}}$

Take Backup, wait backup `Ready` ${~~~\color{green}\textsf{V}}$

Go to "Virtual Machines" -> VM -> "⋮" -> "Take Backup"

Take VM Snapshot, wait snapshot `Ready` ${~~~\color{green}\textsf{V}}$

Go to "Virtual Machines" -> VM -> "⋮" -> "Take VM Snapchot"

Stop VM, wait VM `Off` ${~~~\color{green}\textsf{V}}$

Go to "Virtual Machines" -> VM -> "Stop"

Restore (Replace) from backup, wait VM `Running` ${~~~\color{green}\textsf{V}}$

Go to "Backup & Snapshot" -> "VM Backups" -> BACKUP -> "⋮" -> "Replace Existing"

Stop VM again ${~~~\color{green}\textsf{V}}$

Restore (Replace) from snapshot ${~~~\color{red}\textsf{X, VM is not replaced and start.}}$

Go to "Backup & Snapshot" -> "VM Snapshots" -> SNAPSHOT -> "⋮" -> "Replace Existing"

Restore (New) from snapshot ${~~~\color{red}\textsf{X, no new VM created.}}$

Go to "Backup & Snapshot" -> "VM Snapshots" -> SNAPSHOT -> "⋮" -> "Restore New"

Expected Behavior
If Harvester consider "Target VM" still there even the original VM is replaced by backup restore, and restore should work.

Note

Reproduce both in single node and 3 nodes setup.

Support Bundle

single node env.
supportbundle_restore_existing_from_bak_then_snap-single_2023-10-12T05-27-41Z.zip
3 nodes env.
supportbundle_restore_existing_from_bak_then_snap_2023-08-25T07-21-23Z.zip

Verified failed on v1.3-f132d7fa-head (24/01/02) . Move this issue to implement.
Result

[x] When vm have a backup and snapshot -> stopped the vm -> restore to replace from backup
Then do the restore vm from snapshot to create new one, there is no new VM created from the snapshot
Test Result $~~$ $\color{red}{\textsf{Failed}}$
https://github.com/harvester/harvester/assets/29251855/8b750082-70ee-4b6c-8c08-61543ee04cf9

Test Information

Test Environment: 3 nodes harvester on baremetal machines
Harvester version: v1.3-f132d7fa-head (24/01/02)

Verify Steps
Execution Steps

Config backup-target to NFS

Create VM, wait VM to Running state

Take Backup, wait backup Ready

Take VM Snapshot, wait snapshot `Ready

Stop VM, wait VM Off

Restore (Replace) from backup, wait VM Running

Stop VM again

Restore (Replace) from backup, wait VM Running

Stop VM again

Restore from snapshot, create a new VM

Check if new VM created

Support bundle
supportbundle_d35d2a52-e5d8-423a-a932-f5b5eddd1acb_2024-01-02T10-11-53Z.zip

Verified failed on v1.3-f132d7fa-head (24/01/02)

Hi @TachunLin, may you use master-head to test it. My commit 03039ce has not been backported to v1.3 branch.

Verified fixed on master-d3dc81ca-head (23/01/05). Close this issue.
Test five times the scenario back and force in the row, did not encounter these issue during the verification process.
Result

[x] 1. Can restore the snapshot to replace original vm when the vm have been restored from backup
Test Result $~~$ $\color{green}{\textsf{PASS}}$
https://github.com/harvester/harvester/assets/29251855/3a8f12d6-7fdc-42af-8f51-c5d5bbfcb248

[x] 2. Can restore the snapshot to create the new vm when the vm when the vm have been restored from backup
Test Result $~~$ $\color{green}{\textsf{PASS}}$
https://github.com/harvester/harvester/assets/29251855/04034f93-2e35-4a13-9e05-71a671cfc7fe

Test Information

Test Environment: 3 nodes harvester on bare metal machines
Harvester version: master-d3dc81ca-head (23/01/05)

Verify Steps
Execution Steps

Config backup-target to NFS backup target
Create VM, wait VM to Running state
Take Backup, wait backup Ready
Take VM Snapshot, wait snapshot Ready
Stop VM, wait VM Off
Restore (Replace) from backup, wait VM Running
Stop VM again
Restore from snapshot, replace the current VM
Check the vm is running
Restore from snapshot, create a new VM
Check the new vm is created and running


Collapsed directories looking uncollapsed with -a flag

Working on the icons, I have come across this (in print_item(...)):
if path.is_file() {
  /* ... */
} else if !flags.all && constants::COLLAPSED_DIRECTORIES.contains(&item_name) {
  name_prefix = String::new().underline(flags);
}

This makes collapsed folders show as so when the software is run withot the -a flag. The problem I see is that, when running lsfp -a, collapsed directories like node_modules appear as if they were not. I think this should only happen when you run it with the -t flag, so the output is as following:

lsfp -> underlined collapsed directories
lsfp -a -> underlined collapsed directories
lsfp -t -> underlined closed collapsed directories
lsfp -a -t -> normal open collapsed directories

I have tried to change this, and I have come with the solution, which is changing the else if to teh following:
/* ... */
} else if !(flags.all && flags.tree) && constants::COLLAPSED_DIRECTORIES.contains(&item_name) {
/* ... */

LGTM

I have done some changes to the code,  and this is what I came up with:

lsfp

lsfp -t

lsfp -a

lsfp -a -t

Does the collapsed folders look good to you that way or you would like it other way? I am also setting the same "rule" for the underline and the icon mentioned in #47, I think that's the best way to go right?

Yep looks good!


Drop Ruby 1.9 support

Ruby 1.9 is already ended at Feb, 23, 2015.
see. https://www.ruby-lang.org/en/news/2014/01/10/ruby-1-9-3-will-end-on-2015/
I think psych should drop to support EOL version of Ruby.
@tenderlove How do you think about this?

I discussed this issue with @tenderlove at RubyConf Taiwan 2015. He accepted this PR.


Release 3.3.1

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_f0i54_sdap/clone/recipe/meta.yaml:20: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_f0i54_sdap/clone/recipe/meta.yaml:21: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_f0i54_sdap/clone/recipe/meta.yaml:35: missing_imports_or_run_test_py: Python packages require imports or a python test file in tests.
Errors were found


Millionaire support for tracker, via score or clone gun

I almost gave up on the score check, tbh. I didn't expect to need to check three numbers, and miscalculated a memory offset at one point.

This looks good but wanna give rule discussion a couple days to see if anyone has objections


Fix log parsing to check for lowercase fail in status

Fixes #233
While https://github.com/minio/minio-go/pull/865 updates the minio-go logs to print FAIL as status instead of fail, to avoid further issues, we should check for both values in Mint as well.

@kannappanr PR is updated, please check


Stage is empty when picked from Lunar Seer in Bazaar when teleported in menu.

Steps to reproduce:
1: Open the Teleporter menu.
2: Click on 'Hidden Realm: Bazaar Between Time'.
3: Pick a Lunar Seer stage in the Bazaar.
4: Exit the Bazaar through the regular portal and go to the next stage.
5: Observe that there are no interactables in the stage (Chests, Scrappers, Teleporter) apart from in-built ones (e.g. Fans on Rallypoint Delta).
This may also happen when using 'Skip Stage' in the Teleporter menu.

you actually fixed this?


relationships: fewer queries for parents

Pulled this out of #10160
This reduced the number of queries for things like Vm#parent_blue_folders and Vm#parent_resource_folders among other queries.
This is 1/2 of my optimization for rbac and cap&u timer.
Thanks for review @Fryguy - let me know if this went in the direction you expected

@kbrock darga yes/no?


feat: smooth resizing

I've tested on Linux and macOS. Just need to check Windows is still safe and I'll clean up and move to PR.

https://github.com/versotile-org/verso/issues/194


Add search bar for filtering flags in home page

Description
I added a search bar that can help to find a flag throw a big number of flags on the home page.
Motivation and Context
When the usage of flagr grows, I tend to add more flags for every configuration I have. By doing that, I affect directly the length of the list of flags on the home page. I was trying to suggest a new way to navigate throw all the flags easily.
How Has This Been Tested?
Tested locally, manually.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report

Merging #268 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #268   +/-   ##
=======================================
  Coverage   81.76%   81.76%
=======================================
  Files          26       26
  Lines        1530     1530
=======================================
  Hits         1251     1251
  Misses        210      210
  Partials       69       69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43030e8...90d85da. Read the comment docs.

Hey, this is GREAT!
I've wanted to do something like the search for a while, but didn't decide which way to go, client side or server side search for the UI?
The advantage of server side search is that we get the limit/offset pagination upfront to be scalable into huge amount of flags. And client side search for its simplicity.

I don't know if flagr home page is a good case for pagination and server side filtering, since I cant see a use case of too many flags (more than 1000?).
I guess that there are a lot of ways we can manage huge amount of flags, for example by grouping them or other approach. In my opinion this is a good start that we can continue with, maybe if will be a future requests from other users, we could implement a more sophisticated solution, such as server side filtering or even pagination. Please share your thoughts.


Plain connect0hook

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 52s

trunk passed

+1 :green_heart:
compile
0m 32s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 29s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 27s

trunk passed

+1 :green_heart:
mvnsite
0m 32s

trunk passed

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 50s

trunk passed

+1 :green_heart:
shadedclient
21m 18s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 22s

the patch passed

+1 :green_heart:
compile
0m 23s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

-1 :x:
javac
0m 23s
/results-compile-javac-hadoop-tools_hadoop-azure-jdkUbuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.txt
hadoop-tools_hadoop-azure-jdkUbuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 generated 18 new + 0 unchanged - 0 fixed = 18 total (was 0)

+1 :green_heart:
compile
0m 20s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

-1 :x:
javac
0m 20s
/results-compile-javac-hadoop-tools_hadoop-azure-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
hadoop-tools_hadoop-azure-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05 with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 generated 18 new + 0 unchanged - 0 fixed = 18 total (was 0)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 16s
/results-checkstyle-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure: The patch generated 25 new + 0 unchanged - 0 fixed = 25 total (was 0)

+1 :green_heart:
mvnsite
0m 22s

the patch passed

-1 :x:
javadoc
0m 18s
/patch-javadoc-hadoop-tools_hadoop-azure-jdkUbuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.txt
hadoop-azure in the patch failed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

-1 :x:
spotbugs
0m 49s
/new-spotbugs-hadoop-tools_hadoop-azure.html
hadoop-tools/hadoop-azure generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+1 :green_heart:
shadedclient
23m 35s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 54s

hadoop-azure in the patch passed.

-1 :x:
asflicense
0m 30s
/results-asflicense.txt
The patch generated 3 ASF License warnings.

90m 50s

Reason
Tests

SpotBugs
module:hadoop-tools/hadoop-azure

Inconsistent synchronization of org.apache.hadoop.fs.azurebfs.conn.AbfsHttpUrlConnection.failed100cont; locked 50% of time  Unsynchronized access at AbfsHttpUrlConnection.java:50% of time  Unsynchronized access at AbfsHttpUrlConnection.java:[line 21]

Inconsistent synchronization of org.apache.hadoop.fs.azurebfs.conn.AbfsHttpUrlConnection.insideInputStream; locked 66% of time  Unsynchronized access at AbfsHttpUrlConnection.java:66% of time  Unsynchronized access at AbfsHttpUrlConnection.java:[line 52]

org.apache.hadoop.fs.azurebfs.conn.https.AbfsDelegateHttpsURLConnection.finalize() does nothing except call super.finalize(); delete it  At AbfsDelegateHttpsURLConnection.java:super.finalize(); delete it  At AbfsDelegateHttpsURLConnection.java:[lines 83-84]

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5997/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5997

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux f1ff8d07a0a9 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fbe7f96e0f9bd1b2e919f676c2e21703061b8941

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5997/1/testReport/

Max. process+thread count
727 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5997/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Fix notes datetime ISO 8601 format

Notes that are not initiated with a dt parameter, are being created with a default dt that don't follows the ISO 8601 format. The class use the function datetime.datetime.now().isoformat() to create the string timestamp that result in a value without timezone or offset such as 2023-10-05T14:48:23.123456.
Instead, keripy normal use helping.nowIso8601() to create the timestamp that result in values like 2021-06-27T21:26:21.233257+00:00

Any interest in fixing the other usages of datetime vs helping.nowISO() @rodolfomiranda 😬

Any interest in fixing the other usages of datetime vs helping.nowISO()

I could only find  datetime.datetime used in signaling.py. I updated it. The rest of keripy seems to be ok since datetime is only used for timedelta.

Any interest in fixing the other usages of datetime vs helping.nowISO()

I could only find datetime.datetime used in signaling.py. I updated it. The rest of keripy seems to be ok since datetime is only used for timedelta.

Thanks, appreciate you taking the extra time.

Can we please explain in the description of the PR why this change is being made?  The helping functions are used in many other places in KERIpy, specifically for time in KERI events and credentials.  Why are you proposing we change them for only this small subset of date usages?
If the date functions are wrong, why not fix them?

If the date functions are wrong, why not fix them?
date functions are correct, but were not applied correctly in a couple of lines in notifying.py and signaling.py

Should be using helping.nowIso8601() or helping.toIso8601 everywhere there is a datetime string (non CESR encoded). Or Dater instance if want CESR encoded datetime


Dots

Hello, after spending some time to get real-time display for time series in jupyter notebook I found your scripts, thank you.
It works nicely, seemingly without delay of imaging frame rates and was implemented in seconds.
Is it possible to have dots and to label y_label?
What is with "finalize" - it seems not to have any obvious effects.
Otherwise, thanks, again.
Best
T

Hi @tomMEM
Glad you found the library useful. Dots are not available at this stage and the y_label can only be set on the right hand side (see examples in the readme) via plot_names.
Finalize has the effect that the resulting plot in Jupyter is persistent across sessions. So that when you start your notebook again you can see the plot from the previous session.
Hope that helps.
Cheers,
Leandro

Hello Leandro, thank you for your response and additional infos.
I am wonder, how the jupyterplot manages to stay outside the "loop", because I cannot see a reduction in live video stream while plotting some values. Is it a traitlet based or threating? Just curious. All the best. T

Hi @tomMEM
Not sure since jupyter-plot is a wrapper around the python-lrcurve library. Probably best to check there :)
Cheers, Leandro

Hello @lvwerra and @tomMEM
I am also working on time series data and wanted to plot it real-time, but I am not sure how do I put dates in the x axis, as it strictly takes in integer or float values.
Would appreciate an answer from any one of you.
Thanks,
Mustansir.

Hello @mustansir14 , indeed the x axis values have to be int or float. So you might  have to perform some transformation for the x-values.
I am also looking for some additional settings that might allow an "oscilloscope" experience, keeping only for example a second of the time series values in the display window.
In case you have suggestions how to do it, would be great. Best. T


Unit testing for auto-indent

It would be a really good idea to have some automated unit tests for the auto-indent code.  Could cover most of the important cases by setting up a test harness that loads something in codeworld mode, runs the formatSource function from codeworld.js, and then asserts the result.

See #1366 for the test framework.  That's a prerequisite for this.


[HUDI-5200] Clean up resources in hudi common UT

Change Logs
In the current UT, some resources are not closed, this causes many local disk storage to be occupied
Impact
Clean up resources in hudi common UT
Risk level (write none, low medium or high below)
low
Documentation Update
none
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@hudi-bot run azure


Example for squashfs creation is not really valid

The examples/squashfs_create.go will not ever really be viable when doing proper error checking of returned values as it calls CreateFilesystem which will always return a filesystem.ErrReadonlyFilesystem for filesystem.TypeSquashfs.
If it is possible to properly create a writable squashfs the example should be updated to properly show how it is suggested to handle above error (I know how to check types of errors in go, I'm suggesting that the example should either note the error to check if it can be ignored in this case for creating a squashfs object)

Yeah, that is a valid point. We should have:

A new examples/squashfs_read.go that reads it via the way shown, and then use it to read something
The existing examples/squashfs_create.go that does it the way the tests do and successfully creates.

Want to open a PR to fix it?


Illegal Instruction (core dumped)

Not sure if this is an issue with v1.7.3 or just something on my machine but when I run ./manage migrate I get:
root@circuits:/opt/netbox-1.7.3/netbox# ./manage.py migrate
Illegal instruction (core dumped)
I've installed previous versions of netbox with no issues and upgraded with no issues as well. Just wondered if anyone else had seen this issue or knows of a fix.
The machine is a brand new Ubuntu 16.04 VM with no other software installed and I have wiped and copy pasted the instructions step by step to see if was my fat fingering causing the issues but still seem to be hitting the same wall.

Appears to be an issue with 16.04 other installs have used 14.04 so using that


Add JDK_NATIVE_OPTIONS to all openjdk test targets

Closes: #2398
Signed-off-by: Yanshan Wan<EMAIL_ADDRESS>

run aqa --sdk_resource nightly --build_list openjdk --target sanity.openjdk --jdk_version 11 --jdk_impl hotspot --platform x86-64_linux

run aqa --sdk_resource nightly --build_list openjdk --target -jdk_custom --jdk_version 11 --jdk_impl hotspot --platform x86-64_linux

run aqa --sdk_resource nightly --build_list openjdk --target jdk_custom --jdk_version 11 --jdk_impl hotspot --platform x86-64_linux

Is there a reason we do not add JDK_NATIVE_OPTIONS into JTREG_BASIC_OPTIONS? In this way, we do not need to modify all the targets in the playlist.

We probably need to pay attention to:

-nativepath: option can't be duplicate. That is $(JDK_NATIVE_OPTIONS) $(JVM_NATIVE_OPTIONS) won't work. Also -nativepath: option doesn't support comma or semi comma separated values.
Component jdk and hotspot has different nativepath.

So we will need to set a rule that add $(JDK_NATIVE_OPTIONS) to all jdk test targets and $(JVM_NATIVE_OPTIONS) to all  hotspot targets.

@yanshan24 as talked in the meeting we can add the JDK_NATIVE_OPTIONS to all  started by jdk_ except jdk_custom. I double checked there are actually two more testcases build and jfc_demo need to add JDK_NATIVE_OPTIONS. To avoid confusion could you also update these two testCaseName with prefixed jdk_, e.g  jdk_build and jdk_jfc_demo ? Thanks.

@yanshan24 as talked in the meeting we can add the JDK_NATIVE_OPTIONS to all started by jdk_ except jdk_custom. I double checked there are actually two more testcases build and jfc_demo need to add JDK_NATIVE_OPTIONS. To avoid confusion could you also update these two testCaseName with prefixed jdk_, e.g jdk_build and jdk_jfc_demo ? Thanks.

@sophia-guo For hotspot targets, do I need to add $(JVM_NATIVE_OPTIONS) or I should leave them unchanged?

For hotspot targets, do I need to add $(JVM_NATIVE_OPTIONS) or I should leave them unchanged?

Yes, for hotspot targets if it's without $(JVM_NATIVE_OPTIONS) please add it. That's  good point. Thanks @yanshan24

@yanshan24 - this is approved, but I will wait to merge it until you push the JVM_NATIVE_OPTIONS change that you and Sophia discussed.

@sophia-guo @smlambert for tests start with <testCaseName>jdk11_ such as <testCaseName>jdk11_tier1_pack200</testCaseName>, are they considered jdk test targets?

re: https://github.com/AdoptOpenJDK/openjdk-tests/pull/2414#issuecomment-811600276, yes, consider the jdk11* targets to also be jdk targets that could be updated.

re: #2414 (comment), yes, consider the jdk11* targets to also be jdk targets that could be updated.

Thanks @smlambert . I have pushed the $(JVM_NATIVE_OPTIONS) change.

Grinder for jdk_net/jdk11/openj9: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/8111

run aqa --sdk_resource nightly --build_list openjdk --target sanity.openjdk --jdk_version 11 --jdk_impl hotspot --platform x86-64_linux


TsSecure is not tested

There is no unit test for TsSecure class, let's create one

@yegor256 sure, thanks, I added bug tag to it

@yegor256 thank you for the ticket reported, I topped your account for 15 mins, transaction 000-16ba3603

@dmzaytsev please go ahead, it's your task now, keep this in mind, and don't hesitate to ask any technical questions you may have; Budget here is 30 mins (keep this principle in mind)

@davvd I created the PR #86 for this issue

@davvd the PR #86 merged

@dmzaytsev I'm the reporter of this ticket, you should ask me to close it, not @davvd  :)

@dmzaytsev thanks!

@yegor256 somebody told me I should inform project manager every time I finished task

@dmzaytsev yes, that's true, but you should close the task first, before you inform the project manager. The task is finished/closed only when the ticket is closed by the opener, see http://www.yegor256.com/2014/11/24/principles-of-bug-tracking.html#2.-close-it!

@elenavolokhova please, review this ticket for compliance with our QA rules

@davvd Ticket passed QA review. It looks good!

@davvd Ticket passed QA review. It looks good!

@elenavolokhova thanks for the review

@dmzaytsev 10 mins was added to the account of @elenavolokhova (for QA review), in transaction 54656047. Thanks a lot, I just topped your account for 38 mins, transaction ID 54656062, total time was 118 hours and 25 mins. there is a bonus for fast delivery (age=2896). +38 added to your rating, at the moment it is: +248