FR: Daily limit clock ?

Prerequisites

[x ] I'm using latest version: v 1.0.0
[ x] I've checked Known issues
[ x] I've checked Open issues

Description
First of all thanks for great app:)
I've FR: to add Daily limit clock/counter - similar to microbreak and break - could we have a daily limit in hours?
e.g. after 8hours it will display popup with message it's time to leave work. Might be very useful now especaily when many people have to work from home because of the covid-19.
Workrave does have it: https://mintguide.org/wp-content/uploads/posts/2014-03/1395392261_preferences.gif
Can Stretchly also have it?
Operating system: all
Steps to Reproduce
N/a
Expected behavior:
After time's up (e.g. 8h) should display message it's time to stop working today.
Daily limit counter - informs when it's time to stop working with computer
Mockups:

Actual behavior:
no such feature

Hi @mwoz123 and thanks for the FR :)
I guess we'll see in the future, but right now I have other things I would like to work on.

Idea tech details ("moved" from #680) :

Daily limit should have same/similar rule set as micro- and break.
Popup should appear after (default) e.g. 6 or 8h, and can be postpone or skipped.
Daily limit should have no "break duration" time.
Once breaks are paused, or rested - daily limit counter should also be paused/rested.
(I havne't check how "natural break" works but it would be good to delay daily limit after certain period of inactivity or even reset after long enough inactivity - but I think this should be next PR)
I created "skip to daily limit" - it doesnt' have much logic sense - it's temp function to simplify development, so don't be confused by that;)
Should be removed once everything is working fine.

@hovancik answer:

To be honest, I am not sure about this. I don't like the idea of adding features that other apps have, Workrave in this case. I would prefer Stretchly to be different.
Stretchly is break time reminder app. This feature looks like a timer to finish ones shift. There are hundreds of apps for counting time or timers. I would prefer to keep Stretchly simple, as every extra features make it harder to maintain and to add core features. This feature seems to be as it should be separate application.

my response:

I would prefer to keep Stretchly simple, as every extra features make it harder to maintain and to add core features.

(From developer point of view) I totally agree.
Especially when there probably would be a need to change breakPlanner.js lines 74-102 which already has complicated logic.

There are hundreds of apps for counting time or timers

Here I disagree.
Why someone should have 2 counting down time apps and displaying notification once time is up running in same time on same system?
How about creating array that will contain number of break timers (and their configuraiton) and if someone will want to have 10 time's up reminders (instead 2 - but I belive most users will want at most 3) can be easily set in configuration. If some wants 1 will change the configuration to 1, and so on..
How about that?

Stretchly is break time reminder app.

Btw I was wondering why it's not marked with "RSI" or "prevent "Repetitive strain injury" (RSI) in tags or description.
It might be easier to find this app;)
and wanted to propose it to you;)
Anyway is there a chance such feature will be accepted? I thought so from your anser https://github.com/hovancik/stretchly/issues/667#issuecomment-683282721

@hovancik latest replay:

I will need to think more. Because much more people request that I will add "custom working times", which goes in similar direction but it would be then close to impossible to have both. Maybe a combination where people can define working hours and be notified at the end?

Working hours - I assume you mean #342, right?
From my perspective daily limit covers working hour notifications at the end of working hours, and it's more flexible.
No matter what time you start you're notified when your time is over.
And as I recently heard in radio news it's a common problem for majority of Covid-19 homeoffice workers to separate time when work is over, and starts their off work time.

Yeah similar, many people would like to see ability to tell that Stretchly should run from X to Y hours during weekdays and Z to M during weekends and so on.
I will need to think more, really not sure if this is something that Stretchly should do, it brings new complexity (both ideas). I like that it's simple and people can pause/resume/reset how they think is useful for them.

How about other way?
Break and Microbreak code is mainly duplicated.
How about creating a class for Break e.g (using pseudo-code TS for better readability here) .:
class Break {
duration: number;
interval: number;
notification: boolean;
notificationInterval: number;
postponeTime: nubmer;
ideas: string [];
... //all rest, current settings from config json goes here
//new once:
visibleName: string; //name used at UI ( localization key that will be resolved to "Mini Break", "Break", etc)
settingNamePrefix: string // name used in setting config json (e.g. 'microbreak", "break")
piority : number; // so we can easly compare which break should be shown when 2 are on same time

constructor( {piority, visiblei18nName , settingNamePrefix}) {
duration = settings.get( settingNamePrefix + "duration")
interval = settings.get( settingNamePrefix + "interval") // || settings.get("defaultInterval")
...

microbreak:
const microbreak = new Break({priority : 100. settingNamePrefix: "microbreak", visibaleName : "main.microbreak" //key to EN locale "Micro Break"});

break:
const break = new Break({priority : 200. settingNamePrefix: "break", visibaleName : "main.break" //key to EN locale "Break"});

then replace current "micrbreak" and "break" in code with
breaks ; Break [];

then in Contributor/Sponsor settings we could have length of breaks array.
so if someone wants 10 breaks can have it.
if some wants to have other e.g. "nanobreak" before mini-break can have it.
@hovancik  - this is a draft of ide - what you thinkt?

This FR is to solve Covid-19 WFH worklife balance problems.
Couple of articles:

(..) it's becoming increasingly difficult to separate our home and work lives.
source: https://www.abc.net.au/news/2020-05-19/coronavirus-unpaid-overtime-anxiety-work-life-balance/12259646
For many the reality is that working from home is more like living at work.
source: https://www.afr.com/work-and-careers/workplace/working-from-home-sees-insidious-rise-in-unpaid-overtime-study-20201117-p56f93
“COVID-19 has clearly heightened the challenge facing workers of balancing their paid jobs with their responsibilities at home.
source: https://www.smartcompany.com.au/people-human-resources/remote-work/unpaid-overtime-working-from-home/
(..)It found that in the U.K., France, Spain and Canada, people are typically working for two more hours a day since that date.  Meanwhile, people were working an extra hour in the Netherlands, Denmark, Belgium and Austria on average but the working day had not changed in Italy, which has so far been the worst-hit country in Europe by the virus.
source: https://www.cnbc.com/2020/03/30/coronavirus-lockdowns-are-making-the-working-day-longer-for-many.html

There're dozens more on the Internet about no worklife balance in Covid WFH...
Addition clock counter ("Daily limit" or array of breaks) in Stretchly could help solve this problem.

What code your new one should replace? I am not sure.
Currently, long and mini breaks are separated as it's always long break after X mini breaks and I do some math to plan them based on this logic. This is all then complicated by DND, Idle time, Suspend/Resume,Pause/Reset etc and different priorities around those actions: this is why I take weeks to think about new ideas, it's more complicated then it seems and has a lot of things that influences the behaviour.
I think next steps should be (overall):

bring some kind of state to Stretchly, so that:

Pause != Reset breaks (and think about how Pause should work when DND / Idle time) #813 #772
When we ie disable Mini Breaks, next break is correctly rescheduled #503

Add ability to specify Stretchly working time per day of week #342

Then I think we can figure out how to tell user to stop working. (I would vote for adding another group of break ideas that would talk about why people should stop working, as you mentioned above, that would be shown at the end of the day)
Why? If we add daily limit right now, it opens questions for me:

when the timer starts?
do we count DND/Pause/Suspend/Idle?

Different people will want different things, as it always is, and it will make the feature bigger and bigger. If we have working hours, all questions are gone because we know when the working hours are.

Thanks for answer.

What code your new one should replace? I am not sure.

I meant duplicated code around handling break and microbreak
I assume prerequisites for Daily limit are closed:
#813 #772 #503 & #342
Once they're closed we can get back to daily limit, right?

Let's get back when we have Working hours.

Let's get back when we have Working hours.

Thank you very much for this ticket @mwoz123
I agree with the request, but having used Workrave for years, I must say I disabled the daily limit after a couple years. Workrave's implementation may be a good idea for some, but I think it was too controlling for me. It's a relatively hard limit which allows postponing, but only by a few minutes each time. I would rather see either:

Informative messages that a certain threshold is reached
Additional information in break windows which add daily usage, perhaps becoming red beyond a certain point
A more flexible limit which easily allows me to postpone considerably (45 minutes)

To put it simply, in my mind (disclaimer: I am no ergonomist at all), the daily break is the least important/realistic one, so it should also be the least intrusive.


update from 5.x to 7.x,  throw an error , can not get  store from context

That code is trying to access the store out of legacy context, which was never part of our public API.
Please see the Accessing the Store and Hooks#useStore docs pages for instructions on how to do so safely with v7.


After Git-d5f3b9c8 cannot compile only x86 ExtendedToolsd.dll.

Git-d5f3b9c8 , build/build_release.cmd, VS2017 v15.8.6
Version: 3.0.1937 (d5f3b9c8) [master]
[00:00] Building ProcessHacker (x32)...
[00:32] Building ProcessHacker (x64)...
[01:01] Building Plugins (x32)...
[ERROR]
.\plugins\extendedtools\unldll.c(261): error C2059: syntax error: }
.\plugins\extendedtools\unldll.c(287): error C2059: syntax error: }
.\plugins\extendedtools\unldll.c(313): error C2059: syntax error: }
.\plugins\extendedtools\unldll.c(339): error C2059: syntax error: }
.\plugins\extendedtools\unldll.c(365): error C2059: syntax error: }
If check use IDE, then x64 build is success, but only x86 have this errors.

Source for this problem also SDK 10.0.17763

You keep blaming the SDK... It's never the SDK.

Thanks! It spent most of the night repairing the frequency meter ("Made in USA", but in fact, after a month of work at the measurement range switch, the harness flew off - all the rations turned out to be "raw" and ... fell off. I had to sort it out and re-solder this hack - the device needed, but there is no spare at hand) and mixed up correcting where everything was going. :) And then he himself laughed at this confusion - he earned, but wanted to help by correcting the assembly error.

Please refrain from commenting stories that were put through google translate, everybody wastes time to read and process it - just to understand that it's indecipherable


Load and use system emoji font in the editor.

Fixes https://github.com/godotengine/godot/issues/68026
macOS 13.0:

Windows 11 22H2:

Pop!_OS 22.04 LTS:

Note: depending on font versions, some listed fonts require https://github.com/godotengine/godot/pull/64530 to work.

Thanks!


crash when searching in the caravan search tab

Mod source
Factorio Mod Portal
Operating system

=Windows 10

What kind of issue is this?

[ ] Compatibility
[ ] Locale (names, descriptions, unknown keys)
[ ] Graphical
[x] Crash
[ ] Progression
[ ] Balance
[ ] Pypostprocessing failure
[ ] Other

What is the problem?
when trying to use the search bar for caravans the game will instantly crash
Steps to reproduce
open caravan manager, click on search, no typing is required in the field
Additional context

Log file
factorio-current.log

Thanks for the report, this is a duplicate of #517. We'll push the fix to the portal soon.


Add support for custom devices

added a feature flag that allows enabling / disabling the custom devices feature

add a config file in the default flutter config location (for windows, %APPDATA%/.flutter_custom_devices.json).

the config file is created with the $schema tag and some (disabled) example device configured each time any flutter command is run when the custom devices feature is enabled.

the schema tag points to https://raw.githubusercontent.com/flutter/flutter/stable/packages/flutter_tools/static/custom-devices.schema.json so we get autocompletion. (EDIT: Changed it to stable. Probably better that way, it'll probably confuse people if they get autocorrection for features that aren't yet implemented in stable. If people do want to get autocompletion for master channel features they can just change the URL)

added a CustomDevicesConfig class for querying the currently configured custom devices (with CustomDeviceConfig representing a specific device config)

added string interpolation to utils.dart (used for replacing things like ${hostPort} in the custom device commands)

added some testing

did some manual testing and it seems at least the VS Code plugin needs the linux-desktop flag (plus the custom devices flag) enabled to even list any custom devices. not sure whats up with that

also made protocol discovery not assert a loopback address since some people may not use port forwarding

by default the target platform is linux_arm64 (doesn't matter anyway since we're only building platform-agnostic stuff rn), didn't want to add a new target platform since that's probably a bigger breaking change

there's a TODO item in the code to make the target platform configurable in the future

resolves #65067

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[x] All existing and new tests are passing.

It's probably better to add some more testing, for example for CustomDevicePortForwarder. Is there anything else I didn't notice I should also test?
Some tests don't pass on my local machine but they seem unrelated to anything I've written. For example the analyze_once test fails, because the error message isn't the expected one, or commands.shard\hermetic\run_test.dart bc it tries to access the flutter artifacts dir at C:\C:\Users\hanne\devel\flutter_sdk\bin\cache\artifacts which clearly isn't the right syntax. Maybe it's because I'm on Windows?
EDIT: Added all the tests. Edited schema URL.

In hindsight, I think it may be better to just define a CustomApp and some custom_arm, custom_arm64, custom_x86, custom_x64 target platforms instead of reusing the linux ones, even if that may require additional support from any IDE plugins

okay, should all be resolved now.

Just took a first pass - overall looks good. We might need to think a bit about stabilization too. Not sure what your thoughts are there

With stabilization, do you mean like API (or generally, interface) stability or making sure everything runs nice and stable?

Sort of both. I think we can say initially that we can change this at any version to give time to shake things out, and in the meantime keep it enabled only for master/dev. Any concerns with that?

Sort of both. I think we can say initially that we can change this at any version to give time to shake things out, and in the meantime keep it enabled only for master/dev. Any concerns with that?

Sure. Yeah it'd be nice to have release support too. Maybe when implementing that we'll have to make some other breaking changes.
I'm still probably going to create a fork and backport it to stable just so I can use it on stable myself

It would help if we had a list of features that are incomplete, then maybe that could be the guidelines for a stable feature?

It would help if we had a list of features that are incomplete, then maybe that could be the guidelines for a stable feature?

Yep that's a good idea. So should we create a new GH project for that? Or a google doc?

Either works for me, GH project might be a bit easier to manage though

Either works for me, GH project might be a bit easier to manage though

GH project sounds good to me. Can create some issues that you can add to the project (can't create the project myself of course). First one is here already.

In hindsight, I think it may be better to just define a CustomApp and some custom_arm, custom_arm64, custom_x86, custom_x64 target platforms instead of reusing the linux ones, even if that may require additional support from any IDE plugins

Created an issue for this: #78644 (Seems like you've already seen it). Though this doesn't need to be implemented in this PR since it's not blocking anything and can be easily changed later

resolves #78644

My bad I didn't mean to approve yet, but its close!

My bad I didn't mean to approve yet, but its close!

nice! 😄

While working on this, I've encountered a little gotcha with Windows' ping command: It won't always quit with exit code != 0 when the device is unreachable. It's also not that easy to detect error conditions with a regex since most of the output relevant is localized (internet search says you can search for the ms of the ping response time, but some other people said that doesn't work either, also not that easy if the hostname happens to contain a ms or something
Maybe we should let the SDK do the pinging and let the user specify a hostname / IP-Address that should be pinged, instead of a complete ping command?

Maybe we should let the SDK do the pinging and let the user specify a hostname / IP-Address that should be pinged, instead of a complete ping command?

How would moving the ping functionality into the tool help? If you don't want to use the windows ping, command you could always write a script that orchestrated pinging via Dart or some other language - and then define the script as a dart program

How would moving the ping functionality into the tool help? If you don't want to use the windows ping, command you could always write a script that orchestrated pinging via Dart or some other language - and then define the script as a dart program

Sure, I think that's better actually. Every windows user will have that problem so maybe we could include that script in the SDK? Or maybe keep it as a global pub package that gets activated when the custom devices feature is enabled?

Keeping it as a pub package sounds reasonable, but it shouldn't be installed automatically. The goal of this feature is to support custom devices without extending the SDK beyond the basic interfaces

I think I've found a way to make it work with a regex, I'll push that

I would love to see a more end to end test that creates a custom device config and verifies (using the fake process manager) that all of the correct hooks are called/ not called based on that config.

Implemented it, it was a good idea, I actually found & fixed a bug that way!

Awesome! I will take another look in a bit.


Mango query uses a certain index but not when that index is specified in use_index

Expected Behavior

When an index is specified using use_index, that index should be used if it can satisfy the query.
Current Behavior

A query uses a particular index by default, but when that index is specified with use_index, CouchDB reports this error:
_design/${name} was not used because it does not contain a valid index for this query.
Steps to Reproduce (for bugs)

Consider this index:
{
  "index": {
    "fields": [
      "name"
    ]
  },
  "name": "names",
  "type": "json"
}

...and a document like this:
{ "name": "Diana" }

Running the query against /{db}/_explain without use_index confirms that CouchDB has selected our index to satisfy this query:
$ curl -X POST -H 'content-type:application/json' $COUCH_URL/contacts/_explain -d '{ "selector": { "name": "Diana" } }'

{
  "dbname": "contacts",
  "index": {
    "ddoc": "_design/e989afba40865ef0c0cb81babca885c21e33cd49",
    "name": "names",
    "type": "json",
    "def": {
      "fields": [
        {
          "name": "asc"
        }
      ]
    }
  },
  "selector": {
    "name": {
      "$eq": "Diana"
    }
  },
  "opts": {
    "use_index": [],
    "bookmark": "nil",
    "limit": 25,
    "skip": 0,
    "sort": {},
    "fields": "all_fields",
    "r": [
      49
    ],
    "conflicts": false,
    "stale": false,
    "update": true,
    "stable": false,
    "execution_stats": false
  },
  "limit": 25,
  "skip": 0,
  "fields": "all_fields",
  "mrargs": {
    "include_docs": true,
    "view_type": "map",
    "reduce": false,
    "start_key": [
      "Diana"
    ],
    "end_key": [
      "Diana",
      "<MAX>"
    ],
    "direction": "fwd",
    "stable": false,
    "update": true
  }
}

But running it with use_index elicits a warning about a lack of suitable index:
$ curl -X POST -H 'content-type:application/json' $COUCH_URL/contacts/_find -d '{ "selector": { "name": "Diana" }, "use_index": "names" }'

{"docs":[
{"_id":"efec58378ab329ede55d286425000af8","_rev":"1-257b9c40d13a455e1a5c1141b97d68d5","name":"Diana"
],
"bookmark": "g2wAAAACaAJkAA5zdGFydGtleV9kb2NpZG0AAAAgZWZlYzU4Mzc4YWIzMjllZGU1NWQyODY0MjUwMDBhZjhoAmQACHN0YXJ0a2V5bAAAAAFtAAAABURpYW5hamo",
"warning": "_design/names was not used because it does not contain a valid index for this query."}

Context

I encountered this issue while trying to develop a working example of partial indexes for a Mango tutorial. While I first encountered the issue on an index with a partial index, I was able to reproduce it without the partial index.
Your Environment

Version used: CouchDB 2.2.0-0e92688
Browser Name and version: curl 7.47.0 (x86_64-pc-linux-gnu) [libcurl/7.47.0, GnuTLS/3.4.10, zlib/1.2.8, libidn/1.32, librtmp/2.3]
Operating System and version (desktop or mobile): Ubuntu 16.04.4 LTS, desktop
Link to your project:

@garbados I think the issue here is that the design document is _design/e989afba40865ef0c0cb81babca885c21e33cd49 rather than _design/name. You can control the design document name at index creation time by specifying "ddoc" but the default will just be a uuid.
According to the documentation:, "use_index" should be specified as "<design_document>" or ["<design_document>", "<index_name>"], so do you get the expected result if you do:
$ curl -X POST -H 'content-type:application/json' $COUCH_URL/contacts/_find -d '{ "selector": { "name": "Diana" }, "use_index": "_design/e989afba40865ef0c0cb81babca885c21e33cd49" }'

?

That works! My bad for misunderstanding the docs. Thank you for the help :)


Fix schema compare formatting of scripts in diff

Fix #5419. Adds 'GO' after statements and fixes the problems below:
Blank lines no longer showing as difference:
old:

fixed:

No more blank lines at the beginning of some scripts:
old:

fixed:

Each statement now starts on its own line:
old:

fixed:

What happens if there are partial changes (not complete add or delete)? Then the highlight should show right?

@udeeshagautam Partial changes like this? Which highlight do you mean?

@kisantia yes exactly this. so the highlights in line 3-6  for changed words will still be there right?

@udeeshagautam yes they will still be there. This screenshot is from the branch with the changes in this PR.

Decided to add "GO" and remove the leading/trailing whitespace in SqlToolsService before the scripts get sent to ADS. New PR for that is https://github.com/microsoft/sqltoolsservice/pull/809.
I will close this and send a separate PR to fix the blank lines showing as a difference


Interconnect Private DNS Zone additions for on prem Private Service Connect

shadow LZ V2 work in
https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/issues/468
and
https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/issues/318
https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/issues/298
Requirements
private zone only from Xavier and our client
https://cloud.google.com/dns/docs/zones/forwarding-zones#terraform
https://cloud.google.com/blog/products/networking/how-to-use-cloud-dns-peering-in-a-shared-vpc-environment/
folderIAMAdmin needed on parent folder of each project (for bq)
forwarding from on prem to GCP:
forwarding from gCP to on prem:
My notes:
gcloud example
enable dns, compute
 gcloud dns --project=all-services-obs managed-zones create private-obrien-software --description="" --dns-name="private.obrien.software." --visibility="private" --networks="https://www.googleapis.com/compute/v1/projects/all-services-obs/global/networks/default"

add A and CNAME records
zone

name server - use PSC to *.googledomains.com.

links

https://github.com/terraform-google-modules/terraform-docs-samples/blob/HEAD/dns/managed_zone_private/main.tf
https://cloud.google.com/vpc/docs/configure-private-google-access-hybrid
https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/blob/master/blueprints/cloud-operations/dns-shared-vpc/README.md instead of https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/tree/master/examples/cloud-operations/dns-shared-vpc in https://cloud.google.com/blog/products/networking/how-to-use-cloud-dns-peering-in-a-shared-vpc-environment/ see #1586 in https://github.com/CloudLandingZone/cloud-foundation-fabric/tree/master
https://cloud.google.com/dns/docs/zones/forwarding-zones#terraform

Architecture

Design Issues
DI 0: Decide on network architecture

we are option B Hybrid Connectivity to Multiple VPC (or Shared VPC) networks
slide 27 - B3:  Hybrid DNS Option 1
slide 30 - B6:  Private Service Connect (PSC) for Google APIs
https://docs.google.com/presentation/d/13sjT2tJ4yLIYGRREE3wBrylB1OvcEMpKdquVuJB_nX4/edit?resourcekey=0-N3DruQaiutFvZ98HTT7-vQ#slide=id.g1154b3b950f_2_3611

-

found older notes I made in March in https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/issues/318
DI 1: DNS Forwarding (type 2 to on prem dns server) and DNS Peering

https://cloud.google.com/dns/docs/zones/forwarding-zones#console
https://cloud.google.com/dns/docs/zones/peering-zones
https://cloud.google.com/dns/docs/zones/zones-overview#forwarding-peering-example
https://cloud.google.com/blog/products/networking/how-to-use-cloud-dns-peering-in-a-shared-vpc-environment

simulation

3 VPCs host, perimeter, on-prem (all need private google access set)
vpc peering between host and perimeter
private zones in on-prem site.local and perimeter cloud.local
dns peering in host to
dns forwarding from on-prem to host
dns forwarding from host to on-prem

Testing
Using existing VPN in ol for PSC simulation (however global routing across 2 regions is set - may need a regional VPN)

on the VMs get dig
sudo apt-get install dnsutils -y
dig www.google.com

on m * ob.soft
project all-services-obs
https://cloud.google.com/dns/docs/zones/forwarding-zones#console
gcloud compute networks create gcp-prod-host --project=all-services-obs --subnet-mode=custom --mtu=1460 --bgp-routing-mode=regional && gcloud compute networks subnets create gcp-prod-host-pri --project=all-services-obs --range=<IP_ADDRESS>/24 --stack-type=IPV4_ONLY --network=gcp-prod-host --region=northamerica-northeast1 --enable-private-ip-google-access && gcloud compute firewall-rules create gcp-prod-host-allow-custom --project=all-services-obs --network=projects/all-services-obs/global/networks/gcp-prod-host --description=Allows\ connection\ from\ any\ source\ to\ any\ instance\ on\ the\ network\ using\ custom\ protocols. --direction=INGRESS --priority=65534 --source-ranges=<IP_ADDRESS>/24 --action=ALLOW --rules=all && gcloud compute firewall-rules create gcp-prod-host-allow-icmp --project=all-services-obs --network=projects/all-services-obs/global/networks/gcp-prod-host --description=Allows\ ICMP\ connections\ from\ any\ source\ to\ any\ instance\ on\ the\ network. --direction=INGRESS --priority=65534 --source-ranges=<IP_ADDRESS>/0 --action=ALLOW --rules=icmp && gcloud compute firewall-rules create gcp-prod-host-allow-rdp --project=all-services-obs --network=projects/all-services-obs/global/networks/gcp-prod-host --description=Allows\ RDP\ connections\ from\ any\ source\ to\ any\ instance\ on\ the\ network\ using\ port\ 3389. --direction=INGRESS --priority=65534 --source-ranges=<IP_ADDRESS>/0 --action=ALLOW --rules=tcp:3389 && gcloud compute firewall-rules create gcp-prod-host-allow-ssh --project=all-services-obs --network=projects/all-services-obs/global/networks/gcp-prod-host --description=Allows\ TCP\ connections\ from\ any\ source\ to\ any\ instance\ on\ the\ network\ using\ port\ 22. --direction=INGRESS --priority=65534 --source-ranges=<IP_ADDRESS>/0 --action=ALLOW --rules=tcp:22

2nd vpc
gcloud compute networks create on-prem --project=all-services-obs --subnet-mode=custom --mtu=1460 --bgp-routing-mode=regional && gcloud compute networks subnets create on-prem-sn --project=all-services-obs --range=<IP_ADDRESS>/24 --stack-type=IPV4_ONLY --network=on-prem --region=northamerica-northeast1 --enable-private-ip-google-access && gcloud compute firewall-rules create on-prem-allow-custom --project=all-services-obs --network=projects/all-services-obs/global/networks/on-prem --description=Allows\ connection\ from\ any\ source\ to\ any\ instance\ on\ the\ network\ using\ custom\ protocols. --direction=INGRESS --priority=65534 --source-ranges=<IP_ADDRESS>/24 --action=ALLOW --rules=all && gcloud compute firewall-rules create on-prem-allow-icmp --project=all-services-obs --network=projects/all-services-obs/global/networks/on-prem --description=Allows\ ICMP\ connections\ from\ any\ source\ to\ any\ instance\ on\ the\ network. --direction=INGRESS --priority=65534 --source-ranges=<IP_ADDRESS>/0 --action=ALLOW --rules=icmp && gcloud compute firewall-rules create on-prem-allow-rdp --project=all-services-obs --network=projects/all-services-obs/global/networks/on-prem --description=Allows\ RDP\ connections\ from\ any\ source\ to\ any\ instance\ on\ the\ network\ using\ port\ 3389. --direction=INGRESS --priority=65534 --source-ranges=<IP_ADDRESS>/0 --action=ALLOW --rules=tcp:3389 && gcloud compute firewall-rules create on-prem-allow-ssh --project=all-services-obs --network=projects/all-services-obs/global/networks/on-prem --description=Allows\ TCP\ connections\ from\ any\ source\ to\ any\ instance\ on\ the\ network\ using\ port\ 22. --direction=INGRESS --priority=65534 --source-ranges=<IP_ADDRESS>/0 --action=ALLOW --rules=tcp:22

Simpler pass on host+services projects and prem using
https://cloud.google.com/blog/products/networking/how-to-use-cloud-dns-peering-in-a-shared-vpc-environment/

Validation 1: Peering between non-prod and prod (owner of the interconnects) - will pass bgp routes.  This will avoid duplication of the interconnects in non-prod - less secure but lower cost

in progress on ol VPN test site

Validation 2: DNS forwarding between prod host (gcp) and on-prem (do the reverse next - then work on dns peering with the 3 VPCs)
add private zones
#gcloud dns --project=interconnect-perim-ol managed-zones create private --description="prod-pri-zone" --dns-name="prod.local." --visibility="private" --networks="gcp-vpc"
gcloud dns --project=interconnect-perim-ol managed-zones create prod-pri-zone --description="prod-pri-zone" --dns-name="prod.local." --visibility="private" --networks="https://www.googleapis.com/compute/v1/projects/interconnect-perim-ol/global/networks/gcp-vpc"

output
routing data NS
ns-gcp-private.googledomains.com.

GET https://dns.googleapis.com/dns/v1beta2/projects/interconnect-perim-ol/managedZones/prod-pri-zone/rrsets/prod.local./NS
{
  "name": "prod.local.",
  "rrdata": [
    "ns-gcp-private.googledomains.com."
  ],
  "ttl": 21600,
  "type": "NS"
}

prem
gcloud dns --project=interconnect-perim-ol managed-zones create prem-pri-zone --description="prem-pri-zone" --dns-name="prem.local." --visibility="private" --networks="https://www.googleapis.com/compute/v1/projects/interconnect-perim-ol/global/networks/on-prem"

output:
routing ns
ns-gcp-private.googledomains.com.

add forwarding zones
add peer zones (later)

Try embedded module before trying cff off
https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/blob/master/blueprints/cloud-operations/dns-shared-vpc/main.tf
https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/tree/main/modules/dns-zone/examples
without the public zone
│ Error: Error creating ManagedZone: googleapi: Error 403: Cloud DNS API has not been used in project tzpe-tlz-tlzprod-host4 before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/dns.googleapis.com/overview?project=tzpe-tlz-tlzprod-host4 then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.

add api to prod
dns.googleapis.com

example working - modifying to production

Step #4 - "tf apply": module.net-host-prj.module.project.google_project_service.project_services["dns.googleapis.com"]: Creating...
Step #4 - "tf apply": module.net-host-prj.module.project.google_project_service.project_services["dns.googleapis.com"]: Still creating... [10s elapsed]
Step #4 - "tf apply": module.net-host-prj.module.project.google_project_service.project_services["dns.googleapis.com"]: Still creating... [20s elapsed]
Step #4 - "tf apply": module.net-host-prj.module.project.google_project_service.project_services["dns.googleapis.com"]: Creation complete after 21s [id=tzpe-tlz-tlzprod-host4/dns.googleapis.com]
Step #4 - "tf apply": module.private_zone.google_dns_managed_zone.private[0]: Creating...
Step #4 - "tf apply": module.forwarding_zone.google_dns_managed_zone.forwarding[0]: Creating...
Step #4 - "tf apply": module.net-host-prj.module.network["tlzprod-svpc"].module.subnets["prsubnet02"].google_compute_subnetwork.subnetwork: Modifying... [id=projects/tzpe-tlz-tlzprod-host4/regions/northamerica-northeast1/subnetworks/tzpecnr-prsubnet02-host4-snet]
Step #4 - "tf apply": module.net-host-prj.module.network["tlzprod-svpc"].module.subnets["prsubnet02"].google_compute_subnetwork.subnetwork: Modifications complete after 0s [id=projects/tzpe-tlz-tlzprod-host4/regions/northamerica-northeast1/subnetworks/tzpecnr-prsubnet02-host4-snet]
Step #4 - "tf apply": module.forwarding_zone.google_dns_managed_zone.forwarding[0]: Creation complete after 1s [id=projects/tzpe-tlz-tlzprod-host4/managedZones/dns-local]
Step #4 - "tf apply": module.private_zone.google_dns_managed_zone.private[0]: Creation complete after 1s [id=projects/tzpe-tlz-tlzprod-host4/managedZones/private-local]
Step #4 - "tf apply": module.private_zone.google_dns_record_set.cloud-static-records["/TXT"]: Creating...
Step #4 - "tf apply": module.private_zone.google_dns_record_set.cloud-static-records["ns/A"]: Creating...
Step #4 - "tf apply": module.private_zone.google_dns_record_set.cloud-static-records["/MX"]: Creating...
Step #4 - "tf apply": module.private_zone.google_dns_record_set.cloud-static-records["localhost/A"]: Creating...
Step #4 - "tf apply": module.private_zone.google_dns_record_set.cloud-static-records["/MX"]: Creation complete after 1s [id=projects/tzpe-tlz-tlzprod-host4/managedZones/private-local/rrsets/private.local./MX]
Step #4 - "tf apply": module.private_zone.google_dns_record_set.cloud-static-records["localhost/A"]: Creation complete after 2s [id=projects/tzpe-tlz-tlzprod-host4/managedZones/private-local/rrsets/localhost.private.local./A]
Step #4 - "tf apply": module.private_zone.google_dns_record_set.cloud-static-records["/TXT"]: Creation complete after 2s [id=projects/tzpe-tlz-tlzprod-host4/managedZones/private-local/rrsets/private.local./TXT]
Step #4 - "tf apply": module.private_zone.google_dns_record_set.cloud-static-records["ns/A"]: Creation complete after 2s [id=projects/tzpe-tlz-tlzprod-host4/managedZones/private-local/rrsets/ns.private.local./A]
Step #4 - "tf apply": ╷

Customer side requirements
Also, for DNS forwarding return - I thought I read that the <IP_ADDRESS>/19 range was implicitly advertised but hidden on all BGP routing - it turns out it is up to the customer to advertise this - by adding a custom route directly on the interconnect/vpn router beside the dynamic BGP routes - found this a bit odd but I can see optional case for those not wanting cloud to ground and only ground to cloud for SCED/SC2G

Key for cloud to ground private DNS forwarded queries - add the network-patterns https://docs.google.com/presentation/d/13sjT2tJ4yLIYGRREE3wBrylB1OvcEMpKdquVuJB_nX4/edit?resourcekey=0-N3DruQaiutFvZ98HTT7-vQ#slide=id.g1154b3b950f_2_3152 slide 27 referenced ingress proxy <IP_ADDRESS>/19 as a custom route on the interconnect router (in addition to dynamic subnet routes) - without this DNS queries from gcp to on-prem will not resolve.
specifically - https://cloud.google.com/dns/docs/policies#return-route
"For Cloud VPN tunnels that use dynamic routing or for Cloud Interconnect, configure a custom route advertisement for <IP_ADDRESS>/19 on the BGP session of the Cloud Router that manages the tunnel or VLAN attachment."
https://cloud.google.com/network-connectivity/docs/router/how-to/advertising-custom-ip
see also https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/issues/468
on top of the partner/direct interconnect add the following
firewall rule to open incoming DNS query traffic from the private cloud DNS forwarding zone ns <IP_ADDRESS>/19 - https://cloud.google.com/dns/docs/zones/forwarding-zones#firewall-rules
add <IP_ADDRESS>/19 to the ingress policy on prem
raise an issue with GCP on whether we can add a customer provided IP for return DNS traffic

AWS (prem/ground) to GCP HA VPN up for private google access and DNS forwarding simulation in
https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/issues/494
and shadow

20240406: Closing issue during retrofit/rebase of this TEF V1 based/modified repo to TEF V4 standards
This issue may participate in the LZ refactor after rebase
Query on all issues related to the older V1 version via the tag
https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/labels/2024-pre-tef-v4


Cross sent coref

I think this is producing the desired result, but am not 100% sure it's what people want.  At the very least we should talk to @bgyori about how these mentions would be handled downstream (they're low freq I think).
If this is looking good, I can also add a unit test?

Happy to take a look but based on the PR alone I'm not sure what this will look like in practice. Could you post an example or a unit test that I can learn from? Thanks!

This looks fine to me.
Separate note: now that we do all this SD to UD changes, I wonder if we should a single class/object with POS/dependency labels, so all the representation-specific strings are in one place?

That's a lot of code.  Congratulations.  Here's one nitpick: If there's still code like val corefDeterminers = Set("this", "that", "these", "those") inside a def, can it be moved to an object?

I'm running this over a few documents (as a substitute for understanding everything that is happening in the code).  In the output of Doc5.txt it looks like one rule changed from
"rule" : "gradable-lexiconner++simple-np++quantification2++Increase_adjective_rule_1",

to
"rule" : "simple-np++gradable-lexiconner++quantification2++Increase_adjective_rule_1",

where the ordering simply changed.  That seems suspicious and I'm searching for suspicious things because of @EgoLaparra's difficulty.  Is this change explainable?

I should make that Tester thing work for a coreference.  In a near future PR, I'll try to add it.

There are some coreferences in the wild among the 52 document collection. 21, 22, 26, 28, 31, 42.

In document 19, this extraction has changed from
    "@type" : "Extraction",
    "@id" : "_:Extraction_6",
    "type" : "concept",
    "subtype" : "entity",
    "labels" : [ "Concept", "Entity" ],
    "text" : "average conditions",
    "rule" : "gradable-lexiconner++simple-np++quantification2",
    "canonicalName" : "average conditions",
    "provenance" : [ {
      "@type" : "Provenance",
      "document" : {
        "@id" : "_:Document_1"
      },
      "documentCharInterval" : [ {
        "@type" : "Interval",
        "start" : 2162,
        "end" : 2179
      } ],
      "sentence" : {
        "@id" : "_:Sentence_13"
      },
      "positions" : [ {
        "@type" : "Interval",
        "start" : 5,
        "end" : 6

to
    "@type" : "Extraction",
    "@id" : "_:Extraction_7",
    "type" : "concept",
    "subtype" : "entity",
    "labels" : [ "Concept", "Entity" ],
    "text" : "early wetter than average conditions",
    "rule" : "simple-np++gradable-lexiconner++quantification2",
    "canonicalName" : "early wetter than average conditions",
    "provenance" : [ {
      "@type" : "Provenance",
      "document" : {
        "@id" : "_:Document_1"
      },
      "documentCharInterval" : [ {
        "@type" : "Interval",
        "start" : 2144,
        "end" : 2179
      } ],
      "sentence" : {
        "@id" : "_:Sentence_13"
      },
      "positions" : [ {
        "@type" : "Interval",
        "start" : 2,
        "end" : 6

in that the order of rules have changed and the text now starts earlier.  Any idea why?

@kwalcock  -- I have no idea why a rule name would change... :(  I just looked through the code again and don't see anything that would create a change.  Is it consistent across diff runs? (perhaps we can isolate some sentences and check only them?)
re: the strange ordering effects -- i looked at that too, both in the email you sent and in the other temporal PR and I have no idea what is happening at the moment....

@bsharpataz thanks! I understand, and I think given a link between the coref and the entity it resolves to in the JSON-LD, we will be able to use these. One thing I was confused about is, why are there two "Found Relations" blocks in your example? The second block looks correct but the first one lists "more recession" which wasn't in the original sentences - where does that come from?

@bgyori haha, just checking to see if you were paying attn.... yeah, i meant to paste over that, not add below... it was from the orig example, but i figured having "recession" in 2 places wasn't a good idea when trying to demonstrate the idea, so i changed it.  But thanks for letting me know, I removed the first block :)

@bsharpataz, it is consistent across different runs.  That's good news.  I'll try to isolate an example.  If we (I) don't understand what is happening, it may as well be a neural network.

@bsharpataz, I'm trying not to merge this until after the other issue is fixed for Egoitz, just in case this and the next few changes complicate that.  However, if the delay becomes a problem, I'll back down.  A fix for that other issue might also affect the rule change in the output noted above.

@bsharpataz, could you take a look at the conflicts in EidosActions?  There aren't many, but they are important.

sure
On Tue, Sep 11, 2018 at 5:03 PM Keith Alcock<EMAIL_ADDRESS>wrote:

@bsharpataz https://github.com/bsharpataz, could you take a look at the
conflicts in EidosActions? There aren't many, but they are important.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/pull/418#issuecomment-420466553, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFIniay0kM-9hSXzpAE9qiu-wPMLflncks5uaE9BgaJpZM4WSajb
.

@bsharpataz, it's probably just a question of whether the foundBy still needs to change in EidosActions.  I'm paranoid of making changes in that file.

Thanks, @bsharpataz.  It still passes all tests, even with the time being extracted.


Bug: Goggle Freezes when binding ExpressLRS Backpack

So I originally flashed and bound the backpack just fine. Then a chain of events led to me flashing my TX Backpack again. Since the modules are no longer bound (I can tell because channel switching doesn't work), I wanted to go back and bind the TX and the Goggle Backpack again. The Goggle shows that it's bound and the corresponding UID. When I then press "Bind" the goggle freezes and I have to repower to get it working again. Also the binding doesn't work. So as a result I am currently unable to bind my TX to my Goggles again.

So after some more testing the issues seems to be that there is simply no way to back out of the binding without it being successfull. I reflashed my TX with my binding phrase and now the backpack works again.


feat: task now includes the tasktemplate resolver_inputs to be displayed directly without requesting the template informations

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature: add tasktemplate resolver_input in the GET /task/:taskId to retrieve it without requesting the tasktemplate.
This is needed when the tasktemplate is hidden and will not be listed for regular users.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:

Fixed #176


Resolve merge conflicts also for bundle.Dockerfile

/override ci/prow/e2e-ocp-4-15  ci/prow/e2e-kind ci/prow/e2e-ocp-4-15-arm ci/prow/e2e-ocp-4-16


[WIP] experimental EndianReader

This is a work-in-progress / experimental approach to #294
I don't particularly care if this is the approach we end up taking, but I wanted to try making a generic thing that would work with Rc<[u8]> and Arc<[u8]> and more generally any T: Deref<[u8]> + Clone. The idea being that T might be some custom mmap type.
In particular, check out the table in the gimli::Reader doc comment in addition to the EndianReader<T> definition.
Thoughts @philipc, @koute?

Coverage decreased (-0.4%) to 92.015% when pulling c3c7f29f3b66b7e837250bb117aa2a8ab4873bd5 on fitzgen:endian-reader into f177b94d870a8e236d4e13eaab052de2b2feed07 on gimli-rs:master.

So far this looks great!

This looks good.

Thanks. I know you were also thinking about solving this issue; was the API you were imagining much different?

Once the Pin APIs stabilize (for immovable data), we can probably do a more efficient implementation that's closer to what bytes does.

Can you expand a little more about how you expect Pin to come into play here? I think it would make some variant of EndianSlice easier to use, allowing the owning handle into hash maps without invalidating borrows, but I'd like to know what you're thinking.

I know you were also thinking about solving this issue; was the API you were imagining much different?

My initial thoughts were along the lines of struct { bytes: Bytes, endian: Endian }. However, Bytes is restricted to being a Vec internally (whereas we want any Deref), and the internals of Bytes are more complex than I expected so I don't want to be reimplementing it.

Can you expand a little more about how you expect Pin to come into play here?

Sorry, that was based on expecting Pin to allow self referential pointers to [u8], but looking into it further I don't see how it will do that, since [u8]: Unpin. Correct me if I'm wrong, but it seems like Pin ended up being a solution only for specific immovable types (such as used in generators), rather than for the general self reference problem? The problem I want to solve is that using start/end offsets means we need an extra pointer deref due to Arc/Rc, so I was hoping for some way to replace start/end with ptr/len. I think start/end also needs another bounds check,

I think we can replace start/end with ptr/len and some unsafe code without changing the public interface, assumign we see this show up in profiles.

To expand a little here, there would still be ref counting, but instead of doing
fn slice(&self) -> &[u8] {
    bounds_check(*(arc).len, start)
    bounds_check(*(arc).len, end)
    (*(arc.ptr + start), end - start)
}

fn clone(&self) -> Self {
    arc.increment_ref_count()
    Self {
        arc: self.arc,
        start: self.start,
        end: self.end,
    }
}

we would do
fn slice(&self) -> &[u8] {
    (self.ptr, self.len)
}

fn clone(&self) -> Self {
    // Still need to keep the original thing alive.
    self.arc.increment_ref_count();
    Self {
        arc: self.arc,
        ptr: self.ptr,
        len: self.len,
    }
}

Although, come to think of it, I am unsure that this optimization would be valid with arbitrary T: Deref<[u8]> + Clone and it might require an unsafe trait that says "I guarantee to always deref to the same slice, and not to use interior mutability to destroy a slice I handed out previously".

Although, come to think of it, I am unsure that this optimization would be valid with arbitrary T: Deref<[u8]> + Clone and it might require an unsafe trait that says "I guarantee to always deref to the same slice, and not to use interior mutability to destroy a slice I handed out previously".

Yes, I should have mentioned that there's https://crates.io/crates/stable_deref_trait for that, I had just thought that T: Pin<[u8]> was a similar thing, but it doesn't seem to be.

I think this is going to be useful for converting addr2line to handle the Cow changes in object, since the data needs to live as long as the addr2line::Context, rather than being able to use local variables like in dwarfdump.

Picking this back up now.

@philipc ok, I think this is ready for review!

Thanks!


CTRL+1/CTRL+2 does not move focus to the python interactive window

This only seems to affect the guest. Might have to do with #4853 (maybe status is preventing the activate from occurring)

Also ctrl-0 doesn't work consistently.

I can't repro this anymore.


Use Path.Combine to building worker exe path.

Use Path.Combine for better cross-platform support for building the worker exe path, rather than hard coding the Windows specific backslash path separator.

Assembly.Location can return null in some cases (particularly dynamic loading) so default to current directory "." in that case.

Output the worker exe path being used, for easier debugging of tests not working.

Use object initializer syntax for creating Process.StartInfo -- more compact and readable code.

LGTM

Travis build fails with error below, but that looks like it is just a limit precision problem in the  PiSample test case itself:
3.16194 - 3.14 = 0.02194 rather than <= 0.019 expected.
Assert.IsTrue(Math.Abs(approximatePiValue - 3.14) <= 0.019);

I suspect setting slices = 3 (currently 2) in  PiSample will fix this, although not directly connected to the change in this PR.
----- Running sample PiSample -----
Pi is roughly 3.13796
Pi is roughly 3.16194
----- Error running sample PiSample (duration=00:00:11.2844210) -----
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
---> NUnit.Framework.AssertionException:
  Expected: True
  But was:  False
  at NUnit.Framework.Assert.That[TActual] (NUnit.Framework.TActual actual, IResolveConstraint expression, System.String message, System.Object[] args) <0x420b4670 + 0x000fb> in <filename unknown>:0
  at NUnit.Framework.Assert.IsTrue (Boolean condition) <0x420b4540 + 0x0001f> in <filename unknown>:0
  at Microsoft.Spark.CSharp.Samples.MiscSamples.PiSample () <0x420b3f70 + 0x0044f> in <filename unknown>:0
  at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)
  at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) <0x7f446d5ab780 + 0x000a1> in <filename unknown>:0
  --- End of inner exception stack trace ---
  at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) <0x7f446d5ab780 + 0x000ef> in <filename unknown>:0
  at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) <0x7f446d3e3cf0 + 0x0002a> in <filename unknown>:0
  at Microsoft.Spark.CSharp.Samples.SamplesRunner.RunSample (System.Reflection.MethodInfo sample) <0x41ffddd0 + 0x0036c> in <filename unknown>:0

Current coverage is 42.94%

Merging #183 into master will not affect coverage as of 09e3064

@@            master    #183   diff @@
======================================
  Files           40      40
  Stmts         3621    3621
  Branches       338     338
  Methods          0       0
======================================
  Hit           1555    1555
  Partial        103     103
  Missed        1963    1963

Review entire Coverage Diff as of 09e3064

Powered by Codecov. Updated on successful CI builds.


Accept pull request with Bing added, 10X speed up option, cleaner web page text returned to ParlAI, command line args?

@JulesGM I just did a big commit on my fork and would like to submit it as a pull request if you think you'd be willing to accept it.  I was wondering if you could take a look at it first and also I'm open to making suggested changes before submitting including stylistic ones like how I coded the command line args
Commit: https://github.com/hitchingsh/ParlAI_SearchEngine/commit/14f0fba2e255c8d5ef077e8ec43b7b7e50fe5194

Thanks for your contribution. In the state it's in, it really doesn't respect the architectural choices of the original code, and suggests that you didn't take the time to understand how the server works before making your modifications. I can't accept your pull request unless you make pretty major changes, and I can't guarantee that I would accept it, because the way the code is now makes me not trust your code.

If you split your contributions into smaller patches that I could review individually, it would be a lot better.

@JulesGM I just completed the architectual and stylistic changes you requested.  Before I submit a pull request, can you do another code review and let me know if you have any more requested changes and if you are willing to accept the pull request with any additional requested changes.  Thank you again for your time.
https://github.com/hitchingsh/ParlAI_SearchEngine/commit/be2c0b2638ae685c15e7f606d1c4de8d275e8d1e
Here's the whole file (probably easier to just review this:
https://github.com/hitchingsh/ParlAI_SearchEngine/blob/master/search_server.py

Hi @JulesGM @hitchingsh , I was adding one more search engine (Aquila Network) and noticed another pull request is already pending with Bing Search. Is there a plan to accept that? If so, I can wait and resubmit to incorporate those changes. Thanks.

[Adding] I'm preparing a tutorial blog post with the intention to link back to this repository. So, if the process can be streamlined faster, it will help me a lot, otherwise, I'll have to link it back to my own fork.


.weeks() gives 0 for months with daylight saving time time change

Describe the bug
For PL locale, for month Nov, duration made with month start and end weeks() method always returns 0
Expected behavior
weeks() should return 4 or 3
Desktop (please complete the following information):

Windows
Browser: Edge
Version 2.29.4

Moment-specific environment

Warsaw
26/01/2023 3pm

Please run the following code in your environment and include the output:
s=moment('2023-10-01')
e = moment('2023-10-01').endOf("month");
dur = moment.duration(e.diff(s))
dur.weeks()

Hi can I be assigned to this Issue?

Hi, I have been trying to replicate this issue but am getting the expected behavior, is the issue still persisting when you run it?


Question - Can BCContainerhelper / Nav-ARMTemplates work with dacpac files?

For internal environments we use bacpac files to deploy using the ARMTemplate.
For EmbedApp we dacpac files to deploy to LCS.
In the pipeline we now create both bacpac and dacpac,  using the BCCOntainerhelper.
As you might know, creating bac/dacpac files is quite slow, especially with large schema's like the tenant DB
So if possible I would like to stop creating bacpacs and only rely on dacpac.
This requires the ARM templates and bccontainerhelper to also work with this format. I'm not sure if this is the case?

I would think they would just work - have you tried?


Add ministers page to reverse links

This is PR is part of moving the rendering of pages from Whitehall-frontend to Collections.
Currently ministerial role pages have a link to the ministers page provided by the Whitehall database. We are moving this link instead to the content item for minister roles pages.
Before republishing:

After republishing:

Dependent PRs:
https://github.com/alphagov/govuk-content-schemas/pull/979
https://github.com/alphagov/whitehall/pull/5554
Trello

So, the tests are passing with the add_ministerial_link_to_expanded_links branch of govuk-content-schemas [1].
1: https://github.com/alphagov/govuk-content-schemas/tree/add_ministerial_link_to_expanded_links
I guess once that schema change is reviewed and deployed, this will be ready to merge.


Crashed by "AudioRecorderManager.checkAuthorizationStatus"

Like this picture:

Did you add the message to your Info.plist file that tells the user why you need the microphone permission?
I saw this error, then I added the message, then I restarted it all, and now it's running on both the simulator and a physical device.

Hello, am facing the same above error.
RN: "0.42.0", Android OS v 7.0

I fixed that issue! I linked the library manually in Android

@RakanNimer Please add the manual linking of the library in Android in case react-native link react-native-audio failed

In my case i solved to work on iOS and Android, the problems was the react-native link don't work correctly for android i had to link manually on MainApplication.java:
**import com.rnim.rn.audio.ReactNativeAudioPackage;** ...  protected List<ReactPackage> getPackages() {         return Arrays.<ReactPackage>asList(            **new ReactNativeAudioPackage()**   );   }
check as well build.gradle:
dependencies {     **compile project(':react-native-audio')** }
and finally on settings.gradle:
**include ':react-native-audio' project(':react-native-audio').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-audio/android')**
That works for me ;)

I'm getting same issue in iOS.


Multi-search > the actual doc works only for the multi search in create-edit but not for the multi-search filter into a view list

@ismaelguerrib please be more precise. What does work mean ?

Closing as no activity in this issue


Removed IAR --vla flag which breaks compatibility with IAR Workbench

@mbed-bot: TEST
HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,uARM,IAR
TARGETS=LPC1768,K64F,KL25Z,RZ_A1H,NUCLEO_F411RE,NUCLEO_L053R8

Tests look good for IAR
+1

I don't understand why we need this? Surely --vla is supported both in the IDE and the command line?


unknown directive "vhost_traffic_status_zone" after upgrading to os-nginx 1.32.1_1

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[✓] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
[✓] I have searched the existing issues, open and closed, and I'm convinced that mine is new.
[✓] The title contains the plugin to which this issue belongs

Describe the bug
I've upgraded the Opnsense version of the secondary WAF from 21.1.9 to 23.1.10_1 for upgrade testing purposes. There weren't any errors during the update. When I synchronized the configuration from primary, I noticed that the Nginx service was not starting because of the errors below.
Working packages/plugins for OpnSense 21.1.9

os-nginx 1.28
Nginx 1.20.2_9,2

Not working packages/plugins for OpnSense 23.1.10_1

os-nginx 1.32.1_1
nginx 1.24.0_6,3

Relevant log files
nginx: configuration file /usr/local/etc/nginx/nginx.conf test failed
nginx: [emerg] unknown directive "vhost_traffic_status_zone" in /usr/local/etc/nginx/opnsense_http_vhost_plugins/vts.conf:1

Environment
OPNsense 23.1.10_1 (amd64, OpenSSL).

Update: We've upgraded step-by-step and the last working version is:

OpnSense: 23.1_6
nginx 1.22.0_7,3
os-nginx: 1.31

This has already been hotfixed yesterday...

Are you really sure? Because we've experienced that in yesterday 23.1.10 and also upgraded to 23.1.10_1 yesterday.

You need to reapply the nginx configuration again. This was broken by 1.24 but should have been in the plugin a long time ago.. for some reason the module auto-loaded on nginx 1.22..

More details:
***GOT REQUEST TO UPDATE***
Currently running OPNsense 23.1_6 at Fri Jun 23 11:25:39 CEST 2023
Updating OPNsense repository catalogue...
OPNsense repository is up to date.
All repositories are up to date.
Updating OPNsense repository catalogue...
OPNsense repository is up to date.
All repositories are up to date.
Checking for upgrades (79 candidates): .......... done
Processing candidates (79 candidates): .......... done
The following 87 package(s) will be affected (of 0 checked):
...
Message from opnsense-23.1.10_1:

--
I'm no chicken
Checking integrity... done (0 conflicting)
...
!!!!!!!!!!!! ATTENTION !!!!!!!!!!!!!!!
! A critical upgrade is in progress. !
! Please do not turn off the system. !
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Installing kernel-23.1.8-amd64.txz... done
Installing base-23.1.8-amd64.txz... done
Cleaning obsolete files... done
Please reboot.
***REBOOT***

2023-06-23T11:31:19 | Emergency | nginx | nginx: configuration file /usr/local/etc/nginx/nginx.conf test failed |
2023-06-23T11:31:19 | Emergency | nginx | nginx: [emerg] Naxsi-Config : Incorrect line MainRule id:1500 (/usr/obj/usr/ports/www/nginx/work/naxsi-29793dc/naxsi_src/naxsi_skeleton.c/973)... in /usr/local/etc/nginx/nginx.conf:33

Well, the module error is gone... and now you have the error from #3480

No. The other error comes up, when I uncomment /usr/local/etc/nginx/nginx.conf:33

With all due respect this is a waste of time. I've been through this yesterday.

If you don't have this line in https://github.com/opnsense/plugins/commit/7c83dbba152d nginx.conf you're not going to get rid of the error indeed.

    MainRule id:1401 "str:%U" "msg:M$ encoding" "mz:BODY|ARGS|URL|$HEADERS_VAR:Cookie" "s:$policy990c18d143b747479aaa6c0754cac049:4";

#    MainRule id:1500 "rx:\.ph|\.asp|\.ht|\.jsp" "msg:asp/php/jsp file upload" "mz:FILE_EXT" "s:$policyd90f9550098d4eb0bacca9ebad947934:8";

    MainRule id:1106 "str:data://" "msg:data:// scheme" "mz:BODY|ARGS|$HEADERS_VAR:Cookie" "s:$policydd6604697d034955bf975f97134d0888:8";

/usr/local/etc/nginx/nginx.conf: 2894 lines, 118739 characters.

2023-06-23T11:37:11 | Emergency | nginx | nginx: configuration file /usr/local/etc/nginx/nginx.conf test failed |
2023-06-23T11:37:11 | Emergency | nginx | nginx: [emerg] unknown directive "vhost_traffic_status_zone" in /usr/local/etc/nginx/opnsense_http_vhost_plugins/vts.conf:1

If you don't have this line 7c83dbba152d in nginx.conf you're not going to get rid of the error indeed.

I've added the line manually to nginx.conf. The error is gone but now the other error occurs:
2023-06-23T11:39:25 | Emergency | nginx | nginx: configuration file /usr/local/etc/nginx/nginx.conf test failed |
2023-06-23T11:39:25 | Emergency | nginx | nginx: [emerg] Naxsi-Config : Incorrect line BasicRule id:2003 (/usr/obj/usr/ports/www/nginx/work/naxsi-29793dc/naxsi_src/naxsi_skeleton.c/555)... in /usr/local/etc/nginx/nginx.conf:33

How to force rewrite nginx.conf completely?

# configctl template reload OPNsense/Nginx

Ran as root:
# configctl template reload OPNsense/Nginx
Execute error

Yep, all broken up it seems, but hotfix is working... You can check for errors under System: Log Files: Backend and I'm closing this.

The reason for this bug was, that the config file could not be rewritten correctly (https://github.com/opnsense/plugins/issues/3482)


Pop-up modal its background not blurry in Firefox

Steps to Reproduce

Open dApp in Firefox web-browser
Do an action like mint SVT/tokens, a transfer, .. to get a pop-up modal

Expected Result

blurry background as for example in Chromium

Actual Result

clear background with all details

Additional Infos (Optional)
- Browser & version: Mozilla Firefox 77.0.1

At least up to a point the blur filter was not supported by default in Firefox, and it was only behind a flag that you had to explicitly enable. https://www.reddit.com/r/FirefoxCSS/comments/d7bfmt/is_this_blur_possible_in_firefox/

Okay so not solvable for now?

On 78b9 Firefox developer edition the flag is still disabled by default

I would guess yes, unsolvable until Firefox enables the flag for blur by default.

Okay. So how do you proceed with such issues that become relevant later again?

There are places in the dApp where it is blurry in Firefox

For example on the token withdrawal screen

@christianbrb it didn't look blurry to me.
I am not sure if achieving the same effect as the backdrop-filter is possible or easy. There are other blur filters but they apply on the elements itself, not on the parent elements. I would say it does not make sense for me to try to work around a browser limitation at this point.

Deposit is also blurry in Firefox
I have withdrawn all my tokens :P

Ok this is probably using the overlay instead of the backdrop and applies the blur filter on the overlay.

So this are different components? :thinking:

The dialogs should be based on the same component, but they might have some different flag/property. At some point we tried to apply the blur only to the card itself but that didn't really work due to the layout.

My tests have been executed with layout.css.backdrop-filter.enabled = true


Define autoincrement with primary key and big integer for migration file

I'm finding difficulty to define the Auto increment with primary key for big integers?
The documentation is not mentioning something like that.
Please help

Try bigPrimary.

https://spiral.dev/docs/database-declaration#primary-index

Great! Thanks
That works...
I've other issues on Spiral App. Trying to find solution..


[Feature Request] Specify output file

Heya!
Since redirecting the output of a command relies on the used shell, it would be quite helpful to have a parameter that tells the program where to write the rendered template to.

+1

And what would be great is to make this option support a Jinja2 string as output name, so we can use context variable in the output name :slightly_smiling_face:

Care to provide an example of that? Not sure when that'd be needed.

Hmm. Let say you have a tool get-json-metadata that parses files and outputs metadata as JSON.
for file in *; do
  get-json-metadata "$file" | jinja2 /my/template \
    --output '{{ metadata.file_type }}/{{ metadata.file_name }}.{{ metadata.file_version }}'

My use case is rendering templates in shells that don't support output redirection or when you can't rely on it, e.g. in Dockerfiles, packer-conf.json or Vagrantfiles.

I didn't make it handle it's own variable as a template yet, but added support for the flag for now.


Cloudflare now supports process.nextTick

Cloudflare has since added support for nextTick, so Async methods could be re-implemented based on https://developers.cloudflare.com/workers/runtime-apis/nodejs/process/

After reviewing the original code implementation, it seems like very little would actually be gained by adding back async methods here, and it would definitely cause issues for anyone using it strictly in the browser (for some reason).


Request: use netloc in forwarded_host (#1678)

Summary of Changes
Use netloc instead of host in forwarded_host, to correctly reconstruct the request URI when the proxy headers are not set.
Related Issues
#1678
Pull Request Checklist
This is just a reminder about the most common mistakes.  Please make sure that you tick all appropriate boxes.  But please read our contribution guide at least once; it will save you a few review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

[x] Added tests for changed code.
[x] Prefixed code comments with GitHub nick and an appropriate prefix.
[x] Coding style is consistent with the rest of the framework.
[ ] Updated documentation for changed code.

[ ] Added docstrings for any new classes, functions, or modules.
[ ] Updated docstrings for any modifications to existing code.
[ ] Added references to new classes, functions, or modules to the relevant RST file under docs/.
[ ] Updated all relevant supporting documentation files under docs/.
[ ] A copyright notice is included at the top of any new modules (using your own name or the name of your organization).
[ ] Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.

[ ] Changes (and possible deprecations) have towncrier news fragments under docs/_newsfragments/. (Run towncrier --draft to ensure it renders correctly.)

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
PR template inspired by the attrs project.

Thanks for working on this! Could you add a towncrier news fragment? You can just name it based on the issue (i.e., 1678.bugfix.rst).

Eh, I had a comment on the way :)
But we can create a follow-up PR. I meant to say we would need to revise the Request.forwarded_host docs to make it clear that netloc, as opposed to host, is used as fallback.
Really well done otherwise @hackedd ! :tada:


Task: use real usernames/emails on xyz

Need to have a migration that is only run once on the live site and not committed (to avoid putting user emails into the version control record).

This may be more difficult because of new users who have signed up on the main site since we exported the user list (ids will not match our ids). We can still match them up by email, presumably.


Feature/cce 569

Added two new icons, feedback and gethelp, which are used in new component feedback-menu. To styling these icons in feedback-menu I created new component button-icon (but not sure if it should be component).
I will be very grateful for review ;)
Thanks!

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@jakub-gawlas - I am seeing couple of issues this with this. Please see the tickets for screen shots -
https://jira.hybris.com/browse/CCE-569

fixes done ;)

@jakub-gawlas  - here are conflicts on the branch now. please resolve those and we should be good to merge.

Can we leave out the "Button Icon" component out of the guidelines for this release?
It is not quite fitting the visual style.
The definition and CSS can stay. Probably @jakub-gawlas need it now.
The component needs some more design work.
@jakub-gawlas Agreed? Just remove the reference on the _patterns template.

We need it, otherwise we are going to be delayed with implementation of new feedback forms. This is basically why we did a pull request instead of logging an issue. Designs are from Dieter and Jeanne.
Regarding CLA. He won't be able to sign it I think as he made a mistake of comiting with a different email address. That shouldn't be a problem though as CLA is for external contributors, while he is an SAP employee.

@derberg Thanks for the clarification.
Made some changes to the documentation text.
The branch have still conflicting files... Once these has been resolved, we are good to go with the release, as planned, for tomorrow late afternoon.
I don't know if we can merge it without the CLA been signed, but we'll see soon enough ;)

@joseegm @saadmhybris conflicts resolved, CLA signed, ready to merge :)


Middlewares dispatcher as stateless service with interface

Q
A

Is bugfix?
✔

New feature?
✔

Breaks BC?
✔

Tests?
✔

Could be benchmarked against current one.


Enable cross compilation (Docker) to aarch64-unknown-linux-musl

Resolves #21
Naive and unoptimized approach for cross compilation during Docker build. Result is a multi-arch Docker image.
Cross compilation to aarch64 takes a while on my machine (~ 2hrs), but it works. amd64 version builds significantly faster (< 30mins).
Please be aware that you'll need to have buildx set up as described in the Docker blog post for it.
The conditional to skip non-targetarch build stages is described in this blog post by Docker.

It compiled! Thanks again, I'll go ahead and merge this :)


feat: add drop shadow token

📝 Description
dropShadow could not be granted as Tokens, so it can now be granted.
discussed by https://github.com/chakra-ui/panda/discussions/2677

⛳ Current behavior (updates)
Type error when trying to add dropShadows to Tokens
🚀 New behavior

Allow dropShadows to be added to Tokens
Array and Object are now received and transform into appropriate strings.

💣 Is this a breaking change (Yes/No): No
📝 Additional Information
https://developer.mozilla.org/en-US/docs/Web/CSS/filter-function/drop-shadow

@anubra266
fixed test name!

@k35o Thanks for working on this.
To prevent the need for adding new tokens for several properties css has to offer in the future. We've decided to follow the Closed for modification, open for extension pattern
https://github.com/chakra-ui/panda/pull/2681

@anubra266
thanks!
That's a good change. I'm looking forward to it.


Fixes #23. Add clap to parse cli args. Configure server.rs to accept address and…

… port arguments. Fixes Make port and server address configurable.

This looks good, thanks a lot!
One detail however: When cargo run is executed without arguments, the following is printed to the command line:
You can access the server for example via
http://<IP_ADDRESS>:8080/move?die1=3&die2=1&p24=2&p19=-5&p17=-3&p13=5&p12=-5&p8=3&p6=5&p1=-2
http://<IP_ADDRESS>:8080/swagger-ui

Those links don't work, at least not in my browser.
Maybe we could print out localhost instead of <IP_ADDRESS> if no argument for address is given? Or maybe we use <IP_ADDRESS> as default address instead?

Oh, interesting, yeah they're not working for me either. I think you're right that a good default would be <IP_ADDRESS> for local development.  When deployed to production would you want these links to show up in the logs? I'll play around a bit and see if I can come up with a flexible solution.

Regarding logs in production - I would keep it simple for now. Unless @tslocum has some special requests - he is currently the only one who has server.rs in production.

Nice, thank you!


fix: make it possible to use a canvas element

This makes it possible to also use a canvas element when initializing
tsparticles
Issue: https://github.com/matteobruni/tsparticles/issues/517

This will be merged into master for the critical fix. This will be released when #515 will be ready.


Warning about deprecated config paths when uniquePaths is empty

Describe the bug
Spring Cloud 2022.0.3
Sample
My config is using  spring.config.import, and uniquePaths =[],  yet the following WARN is repeated every 15s in the logs:
WARN s.c.k.c.c.ConfigMapPropertySourceLocator : path support is deprecated and will be removed in a future release. Please use spring.config.import
DEBUG s.c.k.c.c.ConfigMapPropertySourceLocator : paths property sources : []

Can you provide the full configuration for your application?
@wind57 FYI

Can you provide the full configuration for your application?
@wind57 FYI

Sure.
The application.yaml has these profiles. First profile with spring.cloud features disabled for local devs, and second one for k8s deployments.
spring:
  application:
    name: tata
  cloud:
    loadbalancer:
      enabled: false
    kubernetes:
      config:
        enabled: false
      reload:
        enabled: false
---
spring:
  config:
    activate.on-profile: toto
    import: "kubernetes:"
  cloud:
    loadbalancer:
      enabled: true
    kubernetes:
      config:
        enabled: true
        includeProfileSpecificSources: false
      reload:
        enabled: true
        mode: polling
        period: 15000

My helmchart config-map has this application.yaml for environment specific deployments in k8s:
apiVersion: v1
kind: ConfigMap
metadata:
 name: tata
data:
  application.yaml: |-
    spring:
      config.activate.on-profile: myenv

And my helmchart deployment sets this environment variable:
SPRING_PROFILES_ACTIVE=toto,myenv

Thanks!
@wind57 we probably want to check the List is not empty before printing the warning
https://github.com/wind57/spring-cloud-kubernetes/blob/eb7bd1a07c44f013540990065d2186ef994ecb8b/spring-cloud-kubernetes-commons/src/main/java/org/springframework/cloud/kubernetes/commons/config/ConfigMapPropertySourceLocator.java#L102


Removed rdflib-jsonld as a dependency

As of yesterday's rdflib 6.0.1 release, the rdflib-jsonld dependency is now a part of rdflib proper.  This PR just removes it from the requirements.
Tests run fine on my machine (python 3.8.3, Ubuntu), let me know if there's any else I can do to help merge.

I didn't quite notice that this should still be supported for python < 3.6. For a bit more clarification on this, I ran into a problem where I couldn't build a project that depended on extruct becasue rdflib-jsonld includes the use2to3 flag in setup.py, which has been very quickly deprecated and caused some issues (https://github.com/pypa/setuptools/issues/2769). For python < 3.6 support, we'd need to stick with rdflib-jsonld 0.5.0, which still has the offending line. I guess the work around for packages < 3.6 is just to stick with setuptools 58.0.1. I'll close this for now, it doesn't seem particularly useful.

Sorry - I wrote the comment before you closed it but didn't post it in time. I think it would be nice to have this, but removal of p3.5 and py3.6 can be a separate PR. Let me create an issue to track this to get more feedback.

Actually thinking about it more, one more option would be to declare rdflib-jsonld a dependency which is needed only for older python versions in setup.py, and remove it from requirements.txt

Hey @lopuhin, apologies for closing prematurely. I don't think this is a big enough deal to drop support for py3.5-3.6 for; rdflib-jsonld is unnecessary, but it's also harmless in 0.6.2. I like the idea of a conditional dependency in setup.py, I'll implement that later this week when I have time, and can reopen the PR when I do.

Sounds great, thank you @BryceStevenWilley

Looks like we have a problem on python 3.6: https://github.com/scrapinghub/extruct/runs/3744829798#step:5:25 - probably because a newer pip is already available there... Not sure what to do, except pinning an older pip/setuptools combo? That probably affects master as well.

Checking master build here: https://github.com/scrapinghub/extruct/pull/184 - we have a failure for 2.7, 3.5 and 3.6 but for a different reason.

hi folks, I managed to fix the 3.6 build, working on top of this PR, here https://github.com/scrapinghub/extruct/pull/188/ - what do you think about integrating the changes from there into this PR? Or we could continue in #188, at least with the review, and then merge both.

I just reviewed #188, it looks good to me! Since it has the same commits as this branch, y'all should just merge it from there for a less confusing git history. :)


Generate label points for vector tiles

Overview
Generate label points for vector tiles, in order to display them on the project map.
Demo

Notes
Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.
Testing Instructions

scripts/manage/process-geojson

Closes #86

FYI, you might want to check out my forked version of that Vector Inspector tool. I found the original to be hard to see on the map: https://meet.google.com/yby-kvsd-cgm

I just noticed that the human readable values aren't being generated. In the prototype, there's a abbreviatePopulationValues script that's being called to accomplish this. I'll create a new issue to address this.


Fix some more docs issues

[ ] Tests
[ ] Documentation
[ ] Release note

None required

Copy changes from https://github.com/projectcalico/calico/pull/2500 into master

Deploy preview for calico ready!
Built with commit 39083eb2021413413784adbae45236b98f8428d8
https://deploy-preview-2519--calico.netlify.com


create tATCalc

Issue Id you have worked upon -
Issue: #524
Briefly explain your program logic -
This program is a React component that serves as a Turnaround Time (TAT) calculator. Here's a concise explanation of what the code does:

It defines state variables to manage input and results.
Users can input the number of processes and their arrival/completion times.
When the "Calculate TAT" button is clicked, it sorts processes by arrival time and calculates TAT values.
The program handles invalid input (negative or non-numeric values).
It displays TAT values, total TAT, and average TAT.
If input is invalid or no processes are entered, it shows an appropriate error message.

Screenshots(Attach 2 screenshots of your own input and output) -

By raising this PR I affirm that -

[x] My code follows the guidelines of this project.

[x] I have performed a self-review of my own code.

[x] I have commented my code.

[x] My code gives the correct output.

[x] I affirm that I strictly follow contributing guidelines and code of conduct.

Congratulations 🎉 @WaterCubeGod on your contribution.
Thanks for adding value to this repository. 😊
Let's celebrate this fest 😃 by providing more developers 👨💻👩💻 an opportunity to contribute. Help us make this repository reach far and more by sharing this to your friends and colleagues.
Your efforts can make difference.

Hey 👋, may you also encourage us by clicking the star icon on the repository main page. ⭐


expect_raises failure breaks spec reporting.

When running a spec that uses expect_raises, if the actual error raised does not match the given error class, the spec report will break when trying to output the failure.
Here's a minimized example:
require "spec"

describe "expect_raises" do
  it "can handle wrong error types" do
    expect_raises(ArgumentError) do
      raise "wrong"
    end
  end
end

And the output it generates:
$ crystal spec
E

Failures:

  1) expect_raises can handle wrong error types

       Index out of bounds
Error running at_exit handler: Index out of bounds
$

The program immediately exits after Error running at_exit.... Any other spec failures from the run are not reported.
From the testing I did, this happens when the raised exception does not match the given type (i.e., using Exception as the given type will always work). This bug does not occur if the block for expect_raises does not raise an exception.
Running Crystal 0.24.1 on macOS Sierra.

@faultyserver I noticed this as well while releasing 0.24.1 but it seems that it was present since 0.22 and only affects osx. Probably using --no-debug would avoid the Index out of bounds.
I think is related to dwarf parsing. cc: @ysbaddaden

https://github.com/crystal-lang/crystal/issues/5224

And #5413

@straight-shoota Related but I don't think that's the issue.
I'm closing this as duplicate of #5224


OData model v4 - Using formatter on expanded property fails

OpenUI5 version:
1.82.1 (but also happening for multiple older versions tested)
Browser/version (+device/version):
Chrome Version 85.0.4183.121 (Official Build) (64-bit)
Mac OS Catalina 10.15.6
We want to use targetType any together with a formatter. We have an entity called "Project" and a navigation called "cloudFoundry". We are able to bind like this:
<Text text="{i18n>SPACES}: {cloudFoundry/$count}"/>
However, once we want to use a formatter on the cloudFoundry property like this:
<Text text="{path: 'cloudFoundry', targetType: 'any', formatter: '.getServiceInstances'}"/>
We encounter the error:
2020-10-08 14:58:57.146084 Accessed value is not primitive - /Projects(eca822b5-bf91-4ec3-8be6-05c99b66b461)/cloudFoundry sap.ui.model.odata.v4.ODataPropertyBinding
Within the formatter we only get passed through undefined
We use UI5 version 1.82.1. I also tried several older versions without any change in behaviour.
Searching through documentations and Github the targetType: 'any' is always suggested as a solution, however it is simply not working for us....
Is this because cloudFoundry is a navigation property and not on the root of the Project entity? How can we solve this issue? We would be very happy...

Hello @Smux ,
I was able to observe the same behavior when binding to NavigationProperty. I think this is expected, because such properties are not structural part of the entry they belong to. I have forwarded this question under id<PHONE_NUMBER> to our OData experts, they will update you here in GitHub.
Best regards,
Petar

Dear dimovpetar,
if you change the binding mode to OneTime the issue does no longer occur.
See
http://veui5infra.dhcp.wdf.sap.corp:8080/snippix/#95770
You can find this in the docu:;
https://ui5.sap.com/#/topic/fccfb2eb41414f0792c165e69a878717

Thanks that helped! :)

Hi Team,
I implemented above approach but have an issue.

"visitTypes" is an array object which is bound to a Text. However when I have a debug point in formatting function "getVisitTypes", I am getting id value instead of expected array object value.
Could anyone  please correct me if I miss something here ?
Regards,
Raja.

Hi @Raja-Veerappan,
your screenshot shows that data is an array with one element. What is the expectation? Could you please also show the payload of the GET request?
Best regards
Mathias.

Hi @uhlmannm

Above screen shot is a sample GET call for a specific entity set in my service.
Here issue is, I am passing "visitTypes" array object in path for Text control to formatting function. however i receive id of that entity in formatter which you see in debug screen shot. I was expecting array data in debugging point, unfortunately id is coming there.

Hello Raja!
I fear I do not quite understand "i receive id of that entity in formatter which you see in debug screen shot." From you screenshot I can see that data is an array of length 1 and the only element contains at least "id". Are you saying that the only element of that "data" array has no other property than "id"?
Best regards,
Thomas
P.S.: Are you aware of the limitations that "OneTime" has? Have you made sure that it is what you require?

Hi @Raja-Veerappan ,

Above screen shot is a sample GET call for a specific entity set in my service.

It would be good to see the actual GET that is triggered by the UI5 application. Could you please provide the request URL in particular the system query options as well as the actual response?
Could you please also provide the following information:

xml view of the binding
Model settings, in particular autoExpandSelect
the data in the array that is provided to your function getVisitTypes. Please expand the object in the array so that we can see the details! (See also @ThomasChadzelek question above.)

Please also check the question in Thomas' P.S.
Best regards
Mathias.

Hello @uhlmannm , hello @Raja-Veerappan !
Can we please focus on one GitHub issue? I recommend https://github.com/SAP/openui5/issues/3170 because that one is newly opened by Raja, is about the issue at hand, and is not yet closed ;-)
Best regards,
Thomas

Hello @uhlmannm , hello @Raja-Veerappan !
Can we please focus on one GitHub issue? I recommend #3170 because that one is newly opened by Raja, is about the issue at hand, and is not yet closed ;-)
Best regards,
Thomas

Hi Thomas @ThomasChadzelek , Mathias @uhlmannm
It is working fine now after proper expand of properties.
Thanks a lot for timely help/support.
I just closed my ticket (3107).
Regards,
Raja.


chore(Python): added equalize the array

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] New algorithm
[ ] Optimization in previous algorithms
[ ] Code style update
[ ] Refactor
[ ] Documentation
[ ] Other, please describe:

Briefly describe the changes in this PR

Algorithm name is Equalize the array . I implement this algorithm with python programming
Other information:

Implementation looks good! Though you can change the variable names a bit to make it more readable for eg. freq (or frequency) instead of hast_table and similarly for max_hash_table
Also you can shorten the code by using some built-in python functions, though its completely your choice
def equalizeArray(arr):
    mode = max(arr, key=arr.count)    # element with max number of occurrence in the array i.e. mode of array
    num_mode = arr.count(mode)
    deletions = len(arr) - num_mode
    return deletions

Hi @Tanmoy07tech,
Any updated?

Hi @Tanmoy07tech,
This pull request is closed due to is inactive, any update please re-open the pr


DOC: Want to add security

What's wrong with the existing documentation
Security of the website
Add ScreenShots
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue

Please explain!

Gossoc extd is completed
On Mon, 11 Nov 2024, 8:49 pm Stuti upreti, @.***> wrote:

Please explain!
—
Reply to this email directly, view it on GitHub
https://github.com/andoriyaprashant/DevDocsHub/issues/146#issuecomment-2468423989,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7SRZ6FUVWOSRSJHZ36IKAL2ADDJFAVCNFSM6AAAAABRAPWD6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRYGQZDGOJYHE
.
You are receiving this because you authored the thread.Message ID:
@.***>


Wrong continues actions

When I choose a continues action problem like HalfCheetah-v2, the actions are lower-bounded by -1. But, the policy does not consider that and generates actions which are beyond the lower bound. For example see:
>>> envs.action_space.low
array([-1., -1., -1., -1., -1., -1.], dtype=float32)
>>> action
tensor([[-0.2963, -2.0881,  0.2851,  0.6744, -1.1251, -0.7789]])

Why is it the case?

I encountered the same problem -- is there a way to solve this? Thanks!

I encountered the same problem -- is there a way to solve this? Thanks!