Implement: /datasets index endpoint

See Swagger API description for this endpoint in this feature branch.

Getting rid of filename and original_id as part of this work since they are subsets of the affected dataset component schema.

List all public Datasets with full metadata and additional Cell Census attributes.

The description references the "cell census". I've requested multiple times that the cell census never appear in the documentation.
The documentation is silent on the ordering of datasets in the response. There are no specific product requirements beyond documenting the order (which may be random) to set expectations (you need to sort by) for the data consumer. @atolopko-czi - does the cell census builder have any preference?

2. does the cell census builder have any preference?

there is no ordering requirement the census

A possible idea/requirement has surfaced that we may want to consider further for this endpoint: being able to filter return datasets compliant up to a given maximum Dataset Schema version.  Some initial discussion here.

The endpoint documentation does not explain the rationale for dataset_id and dataset_version_id. There are some definitions in Surfacing Versions that could be reused here?
dataset_id
A unique identifier of a Dataset.

dataset_version_id
A unique identifier of a Dataset version.

Could be simple like:
dataset_id

The unique identifier that always references the latest published version of this dataset.

dataset_version_id

The unique identifier that always identifies a specific published version of this dataset,
even after subsequent versions of this dataset have been published via revisions.

I might include an example of dataset_revision_id (perhaps using uuid(s) to be more realistic and not suggest an incremental set of numbers.)
dataset_id is 1.
dataset_version_id is 2.
The dataset is updated and republished.
dataset_id is 1.
dataset_version id is 3.
The dataset is updated again and republished.
dataset_id is 1.
dataset_version_id is 4.
It's still possible to access and download earlier versions such as dataset_version_id 3.

The order of the datasets in the response should be documented.

@atolopko-czi - I would prefer to move this idea into a separate issue . If we decide to address, it could be part of the 3.x schema (ontology bump) work. Thoughts?

Sounds good!

The order of the datasets in the response should be documented per the earlier comment.

Good catch, @brianraymor . Shall we go with reverse chron for published_at? Or should it be by revised_at?

For consistency, we could reuse the algorithm for the Datasets view asdefined in Data consumers can filter by metadata to find datasets in the data portal:
Sorting views
Both All Datasets and All Collections must be implicitly sorted in descending order based on the value of the publication date for datasets or collections.
publication date
The publication date is calculated as follows:

If the collection includes a published DOI, then the journal publication date is the publication date for both the collection and its datasets.
Otherwise, the publication date, in order of priority, is the revised_at or published_at timestamp for the collection or the dataset.

@brianraymor I am not opposed but I just want to note for clarity that this conflicts with comments from the Tech Spec.
Do you want us to change the datasets index end (and collections index endpoint) to abide by the Sorting views logic you've laid out in the previous comment?

@brianraymor we've been fooling ourselves with our terminology.

...would suggest reverse chronological order - [0] is latest and [N] is earliest. Time Machine style...

Moving back to In Progress since I'll need to incorporate updates to the sorting according to the above ☝

Somehow we'd managed to sneak in a dataset index response object shape that only has revised_at and not published_at. Obviously rectifying that as part of this ticket.

Otherwise, the publication date, in order of priority, is the revised_at or published_at timestamp for the collection or the dataset.

@brianraymor Just to make sure:

Dataset 'A' is originally published 1 May as part of first publication.

Collection is revised 2 May but Dataset 'A' is not altered/updated.

The published_at attribute on the response is 1 May and is used as the key for sorting amongst all datasets in the response, while revised_at is None.

Dataset 'B' is published 1 May as part of first publication.

Collection is revised 2 May and Dataset 'B' is updated.

The published_at attribute is 1 May on the response; the revised_at attribute is 2 May and is used as the key for sorting in the response.

@danieljhegeman - That is correct. And then the documentation is updated to reflect the default sorting of datasets .

It appears that there's a regression in DOI value.  The datasets index notebook incorrectly returns:
  'collection_doi': 'https://doi.org/10.1016/j.celrep.2018.09.006',
Compare with the correct value from the the collection itself:
'doi': '10.1016/j.celrep.2018.09.006'

dataset.published_at must be included in the datasets index. Currently, only dataset.revised_at is returned.
For GET Collections, I believe that we agreed that only the collection published_at was required since all the datasets in a collection are published at the same time as the collection itself.

For GET Collections, I believe that we agreed that only the collection published_at was required since all the datasets in a collection are published at the same time as the collection itself.

Which endpoint precisely are you talking about?

Which endpoint precisely are you talking about?
I was thinking about this endpoint. The collection has both published_at and revised_at, but the dataset only has revised_at.

I recall having a conversation about the rationale for that omission in the past. I would need to find it.
But you're absolutely right about:

This is not necessarily true. What about new datasets that are published in a revision?

I think we should be consistent about including both published_at and revised_at for collections and datasets.

Is there a plan on the books to quickly validate this endpoint with census builder?

Is there a plan on the books to quickly validate this endpoint with census builder?

No an explicit plan yet, but I've added a note to the next Cell Census team meeting so we can figure out who/when.

@atolopko-czi this endpoint is now in dev

@atolopko-czi this endpoint is now in dev

Now tracking in https://github.com/chanzuckerberg/cellxgene-census/issues/332


Generalise tree infrastructure to handle multifurcating rooted trees

From https://github.com/cogent3/cogent3/issues/1644#issuecomment-1829044833
The current tree infrastructure treats all trees as rooted trees under the hood. In various parts of the code it checks whether there are more than two children at the root of the tree as for whether to handle it as rooted/unrooted (see for instance get_sub_tree, unrooted and lin_rajan_moret).
This may cause issues when generalising to rooted multifurcating trees. For instance, consider the following.
>>> from cogent3 import make_tree
>>> t = make_tree("(a,(b,c),d);")
>>> t.get_sub_tree(["a","b","c"])
Tree("(a,b,c);")

This makes sense if the tree is considered unrooted, though Tree("(a,(b,c));") would be expected in the multifurcating rooted case (and is the result of t._get_sub_tree).
It is unclear what the best solution may be here. A boolean flag could work, but this could potentially be messy and prone to error. I see rooted/unrooted trees as different objects with common functionality,
Unclear what the best solution may be here. A boolean flag could work, but could potentially be messy and prone to error. I see rooted/unrooted trees as different objects, so some abstract tree base class defining common methods with separate rooted/unrooted implementations where necessary could also work (something like UnrootedNode/RootedNode). This would require major changes to the current tree implementation.
This issue is to discuss alternate approaches to solving the problem, and the logical complexity of said approaches.

@GavinHuttley (in https://github.com/cogent3/cogent3/issues/1644#issuecomment-1829091710) suspects a mixin class for methods whose algorithm will be the same in both cases, and an UnrootedNode and RootedNode for cases which are different. Discussion, however, is needed.

We need to accumulate the listing of methods that will BE identical between the two cases. (OR the converse, if that's easier.)


NWB Export: ANM278733_2015-05-31_3.nwb cannot be read

File ANM278733_2015-05-31_3.nwb cannot be read. It is also only 181 KB instead of around 200 MB like the other files. These suggest that something went wrong during the conversion process.

This file has been regenerated and re-uploaded


Google_Exception: (list) unknown parameter: 'maxResults'

Hi! I've probably misconfigured something, but I'm getting unknown parameter: 'maxResults' errors. I've done some digging and it seems that Google API v2 used maxResults where v3 uses pageSize. Any ideas? Here's the relevant stack trace:
Could not connect to disk google because: Google_Exception: (list) unknown parameter: 'maxResults' in /home/vagrant/app/vendor/google/apiclient/src/Google/Service/Resource.php:151
Stack trace:
#0 /home/vagrant/app/vendor/google/apiclient/src/Google/Service/Drive.php(1131): Google_Service_Resource->call('list', Array, 'Google_Service_...')
#1 /home/vagrant/app/vendor/nao-pon/flysystem-google-drive/src/GoogleDriveAdapter.php(749): Google_Service_Drive_Files_Resource->listFiles(Array)
#2 /home/vagrant/app/vendor/nao-pon/flysystem-google-drive/src/GoogleDriveAdapter.php(399): Hypweb\Flysystem\GoogleDrive\GoogleDriveAdapter->getItems('my-folder...', true)
#3 /home/vagrant/app/vendor/league/flysystem-cached-adapter/src/CachedAdapter.php(233): Hypweb\Flysystem\GoogleDrive\GoogleDriveAdapter->listContents('my-folder...', true)
#4 /home/vagrant/app/vendor/league/flysystem/src/Filesystem.php(270): League\Flysystem\Cached\CachedAdapter->listContents('my-folder...', true)
#5 /home/vagrant/app/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php(257): League\Flysystem\Filesystem->listContents('my-folder...', true)
#6 /home/vagrant/app/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php(270): Illuminate\Filesystem\FilesystemAdapter->files('my-folder...', true)

Never mind, it was mentioned in the readme that 1.1 is for V3. Apparently I was using V3 (not sure how or why), so upgrading from 1.0 to 1.1 fixes the issue. Well actually, it raises another issue, but this particular issue is closed. Sorry for the distraction ;)


(Feature) Warning on account switch

Depends on #680. Closes #647.
Demo
This only happens in the deployment modal. You can switch accounts if the deploy didn't start yet.

Pull Request Test Coverage Report for Build 1650

0 of 77 (0.0%) changed or added relevant lines in 10 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.6%) to 13.747%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/react-web3/index.js
0
1
0.0%

src/App.js
0
2
0.0%

src/components/IncompleteDeploy.js
0
2
0.0%

src/utils/microservices.js
0
3
0.0%

src/index.js
0
4
0.0%

src/components/Common/NoWeb3.js
0
4
0.0%

src/stores/DeploymentStore.js
0
6
0.0%

src/utils/cancelDeploy.js
0
8
0.0%

src/components/stepFour/index.js
0
17
0.0%

src/react-web3/Web3Provider.js
0
30
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/components/stepFour/index.js
1
0.0%

src/index.js
1
0.0%

Totals

Change from base Build 1640:
-0.6%

Covered Lines:
351

Relevant Lines:
1994

💛  - Coveralls

@dennis00010011b Can you check if the failing e2e scenarios are correct, or if the problem is with the tests?

You are right, it doesn't seem to be working now. Maybe some merge break it. I will take a look.

@vbaranov It should be working now.
I also fixed two unrelated issues:

The reload wasn't working anymore: if you refreshed the page, it would re-start the deploy from the first transaction.
If you switched accounts, and then refreshed, the deploy would resume with the invalid account. The only issue with this is that in this case you have to switch to the correct account and then restart again for the deploy to continue.


Commands: Allow for DbContexts in other assemblies

Currently, the --context command does not allow for DbContexts in other projects. For example, if you run the following command from a MyProject.Web project, which depends on a MyProject.DataAccess project that contains your DbContext:
> k ef migration apply -c "MyProject.DataAccess.MyDbContext"
System.InvalidOperationException: No DbContext named 'MyProject.DataAccess.MyDbContext' was found.
   at Microsoft.Data.Entity.Commands.ContextTool.SelectType(IEnumerable`1 types, String name)
   at Microsoft.Data.Entity.Commands.MigrationTool.GetContextType(String name)
   at Microsoft.Data.Entity.Commands.MigrationTool.ApplyMigration(String migrationName, String contextTypeName)
   at Microsoft.Data.Entity.Commands.Program.ApplyMigration(String migration, String context)
   at Microsoft.Data.Entity.Commands.Program.<>c__DisplayClass5.<Main>b__18()
   at Microsoft.Framework.Runtime.Common.CommandLine.CommandLineApplication.Execute(String[] args)
   at Microsoft.Data.Entity.Commands.Program.Main(String[] args)

You can get around this by running the k command from the MyProject.DataAccess project, but that requires duplicating the connection string in MyProject.DataAccess and MyProject.Web.

I actually can't even get the work-around to operate unless I override OnConfiguring and then hard-code the connection string, since the ef command doesn't seem to properly initialize the DI container, even if you include a Startup.cs in the DataAccess project.  Have you found a workaround to this?

@cherrydev no, my work-around is just copying the connection string from MyProject.Web\config.json to MyProject.DataAccess\config.json, and putting the following in MyProject.DataAccess.MyDbContext:
        protected override void OnConfiguring(DbContextOptions options)
        {
            var configuration = new Configuration().AddJsonFile("config.json");
            options.UseSqlServer(configuration.Get("Data:DefaultConnection:ConnectionString"));
        }

Issue 823 is related, as it will make Commands respect the various system components. I don't think that issue being fixed will allow for DbContexts in other projects, though.

I think we'll always require the commands to be run on project containing migrations (or the context if generating the first migration). As part of #823, we'll allow you to specify a start-up project that will be used to look for Startup.ConfigureServices and relative-pathed files (including configuration).

Required work is already tracked by items that @bricelam linked to


Added note for changes to copied term naming

Docs Build status updates of commit 15d20a9:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

Line 136: [Error] Restore nuget package W:\lktc-s\.optemp\dependentPackages\Microsoft.OpenPublishing.CommonPlugins\packages.config in folder:W:\lktc-s\.optemp\packages failed, possibly due to transient errors from nuget servers. Please retry building your content. If the issue still happens, open a ticket in https://SiteHelp and include the build report and the following error message for our team to troubleshoot: Errors in packages.config projects     Unable to find version '1.0.224' of package 'Microsoft.OpenPublishing.CommonPlugins'.       C:\Users\ContainerAdministrator\.nuget\packages\: Package 'Microsoft.OpenPublishing.CommonPlugins.1.0.224' is not found on source 'C:\Users\ContainerAdministrator\.nuget\packages\'.       https://docfx.pkgs.visualstudio.com/docfx/_packaging/docs-build-v2-prod/nuget/v2: Package 'Microsoft.OpenPublishing.CommonPlugins.1.0.224' is not found on source 'https://docfx.pkgs.visualstudio.com/docfx/_packaging/docs-build-v2-prod/nuget/v2'.
Line 136: [Error] Restore nuget package W:\lktc-s\.optemp\dependentPackages\Microsoft.DocAsCode.ECMA2Yaml\packages.config in folder:W:\lktc-s\.optemp\packages failed, possibly due to transient errors from nuget servers. Please retry building your content. If the issue still happens, open a ticket in https://SiteHelp and include the build report and the following error message for our team to troubleshoot: Errors in packages.config projects     Unable to find version '1.0.808' of package 'Microsoft.DocAsCode.ECMA2Yaml'.       C:\Users\ContainerAdministrator\.nuget\packages\: Package 'Microsoft.DocAsCode.ECMA2Yaml.1.0.808' is not found on source 'C:\Users\ContainerAdministrator\.nuget\packages\'.       https://docfx.pkgs.visualstudio.com/docfx/_packaging/docs-build-v2-prod/nuget/v2: Package 'Microsoft.DocAsCode.ECMA2Yaml.1.0.808' is not found on source 'https://docfx.pkgs.visualstudio.com/docfx/_packaging/docs-build-v2-prod/nuget/v2'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Week 5: Continuous Integration Using GitHub Actions

Topics: Add section 5.x to Tutorial 4 describing how to use Ansible and GitHub Actions to run HPL
Tasks:

Create a feature branch that adds a section with pictures to the tutorial content
Submit a Pull Request

To assist you in editing markdown and preparing your Pull / Merge Requests, you are strongly advised to review:

The first page from Selection Round Content Contribution to the Project, just that you will be creating a fork.
The section just below that, with the links to GitHub Markdown Syntax and Style.


Describe Sapling

@kneasle could you please describe Sapling and how it compares to other structural editor projects? It appears here in the comparison but we've yet to look deep enough to generate a meaningful description for it

Yep - give me a moment to create a PR and a description will be with you in no time :)
Also cool repo btw - I had no idea this existed... definitely worthy of a link in Sapling's README.


tv_typeface Error

Error:(29) No resource identifier found for attribute 'tv_typeface' in package 'Mypackage'
Error:(2) No resource identifier found for attribute 'rv_centered' in package 'Mypackage'

What's the exact error? Did you find a solution?
I can really help you with two lines like that and no explanation ^^

Confirming the same issue, with the following details:
In file: app/build/intermediates/exploded-aar/com.github.orangegangsters/lollipin/1.7.0/res/layout/activity_pin_code.xml
Got these errors:
Error:(29) No resource identifier found for attribute 'tv_typeface' in package
Error:(47) No resource identifier found for attribute 'tv_typeface' in package
Error:(87) No resource identifier found for attribute 'tv_typeface' in package
Also, In file:
/home/code2be/AndroidStudioProjects/Riverback/app/build/intermediates/exploded-aar/com.github.orangegangsters/lollipin/1.7.0/res/layout/view_keyboard_button.xml
Got the following erros:
Error:(2) No resource identifier found for attribute 'rv_centered' in package
Error:(2) No resource identifier found for attribute 'rv_rippleDuration' in package
Error:(2) No resource identifier found for attribute 'rv_ripplePadding' in package
Error:(2) No resource identifier found for attribute 'rv_color' in package
Error:(15) No resource identifier found for attribute 'tv_typeface' in package

Try to add TypefaceTextView and RippleView as dependencies like the example app does?

It works. Thanks@olivierg13.
The two lines you should add are these:
//RippleView
compile 'com.github.traex.rippleeffect:ripple:1.3.1-OG'
//TypefaceView
compile 'com.github.omadahealth.typefaceview:typefaceview:1.3.0@aar'

thank you @olivierg13

Another way is to import library module, so app build gradle will have this lines
    compile 'uk.me.lewisdeane.ldialogs:ldialogs:1.2.0@aar'
    compile project(':LolliPin')


Readme update

I've fixed the code samples in your Readme file to work with the latest code version.
Furthermore, I've clarified the Swift version options you got.

Thanks!


Clear built-in name field when creating new script

Previously the name would remain when creating consecutive scripts.

Thanks!


[Feature request] Redesign the interface to have a single window with increased font size, with an option to copy games file before listing excecutables.

First I would like to say that the application is amazing and I hope the following redesign would be considered:
1- Having one window for the app, with messages at the bottom and options at the top.
2- increasing the font size because it is hardly readable.
3- Give option, after creating the game folder and before listing the executable, that ask the user to copy any game files inside window folder. Currently the user have to copy the game files then go to the previous menu and back to the executables menu to refresh the list and display the excecutables in the newly copied game files.
Regards.

Hi @malnaanah , thank you for the suggestions!

1- Having one window for the app, with messages at the bottom and options at the top.

You mean to merge the logger window with the main window in the wizard? That is something I wanted to do, but it was not trivial.

2- increasing the font size because it is hardly readable.

I have increased the font size (for the next release), but could you provide a screenshot of how it looks currently on your side?

3- Give option, after creating the game folder and before listing the executable, that ask the user to copy any game files

You can copy the files with the file manager (opened by the folder icon by the side of the executable path), I think that having an extra frame just to open the WINEPREFIX directory would be a bit redundant. Another solution would be to detect newly copied files and auto-update the GUI to show them. I'll give this some thought.

I guess having an icon to refresh the executable file list is a good option.
This is how the application appear on my desktop, the resolution is 1368x768

Ok, thanks! Another thing that is fixed in the next version is scaling, the 'prev' and 'next' buttons are looking weird in there because of that.

2- increasing the font size because it is hardly readable.

Implemented in v1.4.0.

3- Give option, after creating the game folder and before listing the executable, that ask the user to copy any game files inside window folder. Currently the user have to copy the game files then go to the previous menu and back to the executables menu to refresh the list and display the excecutables in the newly copied game files.

Refresh button included in the executables frame to remedy this issue.


Anomaly detection slowing down

Hi Lee,
Thanks for sharing your AnoGAN implementation.
I implemented your version and noticed that when looping on anomaly detection the process goes slower an slower. Ater 200 iterrations, the computation can takes more than on minute !
Do you have an idea on what can cause that behaviour ?

I didn't check the issue, but i think it is because of memory usage.
Basically, define-and-run is used in tensorflow and there would be unnecessary definition of some operations.
I think i can check the issue in this weeked, but if you can check, please pull requests.

Hi, did you solve this issue? I am faced with the same.


Add the Star Crock

Twinkle Twinkle Mother Father

In Submitting this PR to handle the Star portion of this issue#5.
This PR does not implement first or second for strong versions of Star, but will once we address issue#14
💥 BONUS 💥
In addtion to the Star implementation, this PR also adds an isFunctor internal function and fixes an unreported bug with the isApply internal function


training time

Can I ask about the training time?
Thanks!

Hi,
I don't have the exact numbers readily available, but I remember training time on the order of 4-8 hours for the shapes / flying shapes experiments and on the order of a day for the multi-mnist experiment. This is assuming a reasonably fast GPU, eg. a Titan X


Update image ghcr.io/gethomepage/homepage to v0.9.13

This PR contains the following updates:

Package
Update
Change

ghcr.io/gethomepage/homepage
patch
v0.9.12 -> v0.9.13

Release Notes

gethomepage/homepage (ghcr.io/gethomepage/homepage)
v0.9.13
Compare Source
What's Changed

Feature: Prometheus Metric service widget by @fcornelius in https://github.com/gethomepage/homepage/pull/4269
Fix: use session_key instead of Id in tautulli component to resolve unique key warning by @Johnomated in https://github.com/gethomepage/homepage/pull/4278
Feature: suwayomi Service Widget by @Robonau in https://github.com/gethomepage/homepage/pull/4273
Enhancement: allow widgets to specify default headers, fix buffer error output by @shamoon in https://github.com/gethomepage/homepage/pull/4287
Feature: Add ArgoCD widget by @fcornelius in https://github.com/gethomepage/homepage/pull/4305
Feature: Spoolman Widget by @fgeck in https://github.com/gethomepage/homepage/pull/3959
Feature: gitlab service widget by @UrsKroell in https://github.com/gethomepage/homepage/pull/4317

New Contributors

@fcornelius made their first contribution in https://github.com/gethomepage/homepage/pull/4269
@Johnomated made their first contribution in https://github.com/gethomepage/homepage/pull/4278
@Robonau made their first contribution in https://github.com/gethomepage/homepage/pull/4273
@fgeck made their first contribution in https://github.com/gethomepage/homepage/pull/3959
@UrsKroell made their first contribution in https://github.com/gethomepage/homepage/pull/4317

Full Changelog: https://github.com/gethomepage/homepage/compare/v0.9.12...v0.9.13

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


documentSymbols reports wrong locs after the fast path

The most concrete description of this bug is in https://github.com/sorbet/sorbet/pull/2000
The tl;dr is that: the difference between the original file and the file after applying the .rbupdate to it is just a single newline character at the end of the file. This should not affect any locs of any symbols in the document (because it's after all definitions) and the edit should take the fast path.
It does indeed take the fast path for the edit, but for some reason, it causes some symbols's locs to update. The locs that update are printed in the diff.

Appears to be fixed.


FIXED  ->  Vertical bar are broken in Chart/Gears activities on Windows

FIX  -  #1646

Please send your PR on dev branch as mentioned in https://github.com/llaske/sugarizer/blob/dev/CONTRIBUTING.md

@llaske done


Consider using go-prompt to enable a nice interactive prompt like mssql-cli

mssql-cli has a nice prompt and nice table output thanks to the use of the following Python libraries:

CLI Helpers
Python Prompt Toolkit
Tabulate

mssql-cli is on the deprecation track, and suggests that go-sqlcmd is the future.
It would be nice if go-sqlcmd copied some of the nice usability features from mssql-cli.
There are existing Go libraries inspired by Python Prompt Toolkit and Tabulate which may help improve the go-sqlcmd interface similar to mssql-cli:
Tabulate inspired libraries:

https://github.com/markkurossi/tabulate
https://github.com/rgeoghegan/tabulate
https://github.com/bndr/gotabulate

Non-tabulate-inspired table library:

https://github.com/jedib0t/go-pretty

Python Prompt Toolkit inspired library:

https://github.com/c-bata/go-prompt

Would go-sqlcmd consider implementing some of these usability features?

I would also like to see go-sqlcmd implement more of the functionality that is available in mssql-cli and the other tools in the dbcli family (https://github.com/dbcli).

Tab completion of table names and other object names
show long output in a user-configurable pager
ability to transpose records like postgres psql's \x command
in interactive sessions, have a setting to invoke a statement without having to put GO on a newline

@shueybubbles

Regarding transpose records is that similar to sqlcmd -F vertical ?

Yes, and it is also like these:
:setvar SQLCMDFORMAT vertical
:setvar SQLCMDFORMAT horizontal

The advantage of psql's \x command is that it is much easier to type. Plus the one single command toggles the setting, as opposed to two separate commands.
Psql also has \x auto, which will automatically switch based on the width of the records selected.
This automatic behaviour is included in pgcli under the auto_expand setting:
https://github.com/dbcli/pgcli/blob/96eb37fd1989ec8fd86150f20053abd03f50e7a4/pgcli/pgclirc#L51
Looks like it was included in mssql-cli also with the expand setting:
https://github.com/dbcli/mssql-cli/blob/67a3a4364383d11776bb0a397ceae7bc19200e41/mssqlcli/mssqlclirc#L29

+1

+1

I think this is not ready to replace mssql-cli yet if tab-completion is not supported. This capabilities make using DB CLI tool a comparable alternative to full-fleshed DB tool such as DBeaver.

i checked usql cli and it had some tab completion capabilities. i haven't spent enough time to check it throughly.


Added screenshot examples to antivirus-gatekeeper.md

There was a note saying how some screenshots would be appreciated and it's been there for a while so I thought I'd just add some.

This is awesome, thank you so much!


Using UITableView with MMCloseDrawerGestureModePanningDrawerView?

Hi,
Is there a recommended way to handle gestures in a UITableView in the left drawer view?
With the default MMCloseDrawerGestureModeAll, the scrolling of the table view is sometimes misinterpreted as horizontal scrolling, and so it closes the drawer. While using the other available flags for closeDrawerGestureModeMask does work in terms of handling gestures in the tableview correctly, it would be nice if panning could be used within the drawer view too.

@kcharwood Any ideas on this one? Thanks in advance for your help!


Merging Basic Changes

👷 Deploy Preview for jdnayak processing.

Name
Link

🔨 Latest commit
8ccf4ff6205f7015a0e23d4ecd65f88df3d3d9e8

🔍 Latest deploy log
https://app.netlify.com/sites/jdnayak/deploys/67137e4ebc56d70008308bbf


Field constructors should not handle optional fields

The 'compulsory' parameter should be removed from the field constructors.
Optional parameters are to be handled by the factories with the use of a wrapper rule.

Optional fields are now wrapped by the factory.


Cannot store bigint and symbol values

Problem
When using Keyv#set, an error is thrown if the value is a symbol or bigint, even though the documentation states that "Values can be of any type.". This also applies if the values are objects that contain one of those types.
For symbols, the error message is vague:
SyntaxError: Unexpected token u in JSON at position 9
    at JSON.parse (<anonymous>)
    at Object.exports.parse [as deserialize] (C:\<project path>\node_modules\.pnpm\json-buffer@3.0.1\node_modules\json-buffer\index.js:49:15)

For bigints, the error message is more clear:
TypeError: Do not know how to serialize a BigInt
    at JSON.stringify (<anonymous>)
    at stringify (C:\<project path>\node_modules\.pnpm\json-buffer@3.0.1\node_modules\json-buffer\index.js:45:17)
    at Object.stringify [as serialize] (C:\<project path>\node_modules\.pnpm\json-buffer@3.0.1\node_modules\json-buffer\index.js:32:37)
    at C:\<project path>\node_modules\.pnpm\keyv@4.0.5\node_modules\keyv\src\index.js:89:22
    at async C:\<project path>\test-keyv-symbol.js:10:4

How to reproduce
Run this demonstration code in a directory with Keyv added as a dependency:
const Keyv = require('keyv');

const testDB = new Keyv('sqlite://test.sqlite', { namespace: 'test' });
testDB.on('error', err => console.log('Connection Error', err));

(async () => {
	const values = ['Normal string value', 1, true, Symbol('Symbol value'), 1n, { foo: Symbol('Nested symbol value') }, { [Symbol('Symbol key')]: 'bar' }];
	for (const value of values) {
		try {
			await testDB.set('key', value);
			console.log('Success: ', await testDB.get('key'));
		}
		catch (error) {
			console.log('Failure: ', error);
		}
	}
})();

The output will show Success: lines for the first 3 values (string, number, and boolean), but show Failure: for the next 3 values (symbol, bigint, and an object containing a symbol). For the final value (an object with a symbol key), the output will show Success:  {}, which is effectively a silent failure.
Expected behavior
My understanding is that it's impossible to serialize and de-serialize a symbol, because they are unique by definition. As such, the user should be clearly and eagerly warned when attempting to store them. Rather than the vague undefined JSON error or silent failure, an error message like TypeError: Symbols cannot be serialized. should be emitted whenever the value is a symbol or an object containing a symbol as a key or value.
For bigints, these should be serialized and de-serialized normally, like other primitives.
Version
4.0.5

@alphmth - it looks like you added in tests that make it so we cannot handle symbols. Is that correct?

@dshepsis - we have a fix coming in for bigint now but symbols might not be possible. We are looking into that.

@jaredwray Symbol can not be serialized So I am just checking for symbol and returning error that symbols cannot be serialized

@alphmth - thanks for the information.
@dshepsis - looks like we cannot to symbol.

@dshepsis we can also use a custom serializer for BigInt as well perhaps using https://www.npmjs.com/package/json-bigint or something.
Check custom_serializers

@dshepsis we can also use a custom serializer for BigInt as well perhaps using https://www.npmjs.com/package/json-bigint or something.
Check custom_serializers

That would be great. Can we make sure to full test it?


set up advisory board

We need to set up a SAB and I want to invite people before the x-mas holidays. Step 1 is to define a list of 5 people we wish to have on your board. Please add names and reasons for candidates:

Nick Juty (for identifiers.org)
someone from Ensembl (major mapping provider)
Gert or Diego from the UCDavid metabolomics map (host of the Chemical Translation Service)
Alex (representing WikiPathways, major BridgeDb user)

The plan so far was to use the advisory board from DTL/ELIXIR-NL and extend that for specific services with one or two people with relevant expertise. Some of the people you mention would possibly fit to that last group. SAB members are typically people that understand the service and have a good overview of the whole field (in this case also the alternatives, and the research use cases).
Since you typically have to fly such people in on a regular basis.it is pragmatic for a smaller project like BridgeDb to limit the number of people from the US.
I don't think Alex is a good fit since he is too close. Most people working on BridgeDb in fact know about WikiPathways needs best

Awaiting outcome of rebuttal.

Will be discussed at Heads of Nodes meeting in Brussels next week. I cannot participate and Jaap cannot be present. So it will take one or few weeks after that before we get an update

@Chris-Evelo, any update on this?

Nope. Too busy mainly. Just asked Rob whether it was discussed at the node services evaluation by the ELIXIR SAB recently. As far as we want suggestions for our own SAB we should probably discuss that in the next BridgeDb telco. Has that been set?


NIFI-7932 Allow MonitorActivity's "Threshold Duration" property to use variables

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
When using MonitorActivity, it would be interesting to use variables in "Threshold Duration", which will help maintain Version Control in ProcessGroups (Avoiding "breaking" versions when including the value manually).
I've included the option expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY), so we can use variables in "Threshold Duration".
Jira Ticket: https://issues.apache.org/jira/browse/NIFI-7932
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically main)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[x] Have you verified that the full build is successful on JDK 8?
[x] Have you verified that the full build is successful on JDK 11?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[x] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Hi @kevinbsilva - thanks for this pull request. The use of parameters is highly recommended over the use of variables going forward. Any reason for not using the parameters in this case? https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#Parameters

Hello @pvillard31, thank you very much for your comment!
There is no particular reason at all, i thought it would be a good idea when using older flows (from imports, etc), especially bigger ones, to avoid problems with version control or even with editing those older flows.
I didn't know much about parameters, i've read the docs and it helped me a lot. I've shared the knowledge with my team and it was very useful. Thank you very much!

I would definitely favor parameters in this situation. In general, we want to avoid having to do lots of code updates to add support for variables for this property and that. But that said, adding support for variables here is also no problem. Since it's already done and it's a trivial change, and all code looks good, will go ahead and merge.

I would definitely favor parameters in this situation. In general, we want to avoid having to do lots of code updates to add support for variables for this property and that. But that said, adding support for variables here is also no problem. Since it's already done and it's a trivial change, and all code looks good, will go ahead and merge.


Missing compiler id

When building cryptopp on apple (compiler id AppleClang) the build will fail, due to missing architecture flags. This is because in L432
if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang" OR CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
                          ^^^^^^^^

we expect Clang. The right way is to check for both of them: e.g. CMAKE_CXX_COMPILER_ID MATCHES "Clang".
Furthermore,  test headers missing ${CMAKE_CURRENT_SOURCE_DIR}/factory.h and test sources validat4.cpp.

I can't place code under Public Domain, due to german copyright restrictions. So I cannot create a pull request or is CC0 1.0 valid?

@mouse07410, @MarcelRaad,
Can you handle this change? I don't have CMake installed to test it.

Yeah, I can. I use CMake in a few projects (r.g., EncFS and CryFS).
BTW, I think we should consider keeping CMake-roasted stuff as a branch of the main repo.

@noloader what's your take on removing factory.h from the installed .h? It is used only by benchmarks and test.cpp.

@mouse07410,

what's your take on removing factory.h from the installed .h? It is used only by benchmarks and test.cpp.

factory.h is kind of interesting. It is only used in the test suite at the moment. However, it does not exist in the Test:: namespace because it can be used in regular code. For example, I have a clone that experiments with an ENGINE interface. The Engines provide an abstraction to things like Apple's CommonCrypto. I use the factory classes to get a handle to one of the engine classes.
Right now it can be removed. But I don't think it is the best choice.

OK, let's keep it in then. One .h file won't break anybody's space-bank.
Also, in the process of testing this I've hit some problems (MacOS 10.12.6). Will open another issue for those.

@fxha, thanks for your fixes. factory.h stays, other changes have been applied. I tested that it works.
Thanks again!


proposal: x/tools/cmd/godoc: strip directly-attached compiler directives

Background
The Compiler Directives documentation describes how //go:XXX compiler directives should be structured.  It leaves ambiguous what "The $X directive must be followed by $Y" means, which becomes especially important when combined with godoc.
It doesn't appear to be well-documented that distinct comment blocks can exist between the compiler directive and $Y. (This comment and the one it cites are the only "documentation" I could find.)
How $X follows $Y is important for godoc where,

if you want to exclude the Compiler Directive from the doc comment, you must split it off into a separate comment block, and
if you want to attach documentation to the compiler directive but not have it appear in godoc, you must split it off into a separate comment block, and add your documentation there.

This proposal aims to relax the first rule above by allowing Compiler Directives to exist within a doc comment, and have it stripped by the godoc tool.  The second rule seems reasonable and is unaffected by this proposal. (I've also rarely seen this rule used in practice, even within the Go source.)
This topic was previously discussed in #34276, but I wanted to reopen the discussion with the following, some of which is new:

Having Compiler Directives "directly attached" to $Y is more natural, aids in readability and manual code refactoring, where it is otherwise very easy to miss the separate comment blocks above $Y when they need to be moved or deleted as a whole.

When $Y is unexported, most examples I've seen attach Compiler Directives directly to it.  While non-exported symbols don't appear in godoc, it generally makes their treatment very different to exported symbols, and then makes it easy to screw it up with exported symbols that do appear in godoc.

I've seen lots of examples in the Go codebase (albeit in src/**/internal when using a godoc query string ?m=all) that get the above rules wrong:

In src/cmd/compile/internal/gc/go.go, the //go:generate for the Class enum type const block would appear in the godoc.
In src/cmd/compile/internal/ssa/value.go, the //go:noinline directive would appear on the AddArgX funcs godoc.
In src/cmd/internal/objabi/reloctype.go and src/cmd/internal/objabi/symkind.go similar //go:generate positioning errors exist.
(There are too many others to list here, but you get the point.)

One of the arguments in #34276 for not having godoc strip Compiler Directives is that the author might want to include the directive in a comment.  In all instances I've seen where that is the case, it typically looks like this:
// The following is how we prevent a func from being inlined:
//
//   //go:noinline
//   func example() {
//   }

That is, the Compiler Directive is typically a comment within a comment.  I've sometimes seen the above written as a block comment too, though there is no ambiguity there as Compiler Directives are not allowed to be embedded in block comments (other than the special line comment which must be positioned at the very start).

Parsing Go code via the AST is simpler when the Compiler Directive is directly attached to $Y: it exists in a node's associated *ast.CommentGroup.  For detached comments, a parser needs to correlate with top-level comment groups, which is a bit more tricky, and especially when you want to mutate the AST using dave/dst.

Proposal
Have godoc strip Compiler Directives present in a doc comment associated with an exported symbol when,

one or more directives appear in the final lines of the doc comment with a preceding "blank comment" line, or
one or more directives appear as the only lines within the doc comment.

By this proposal, godoc would strip away all of the Compiler Directives below:
package example

// FourtyTwo always returns 42.
//
//go:noinline
//export FourtyTwo
func FourtyTwo() int {
  return 42
}

// DayOfWeek is an enum for days of the week.
type DayOfWeek int

//go:generate stringer -type DayOfWeek
const (
  DayOfWeekSun DayOfWeek = iota
  DayOfWeekMon
  DayOfWeekTue
  ...
)

Is this not #37974? It seems like this has been implemented since Go 1.15:
https://github.com/golang/go/blob/3e48c0381fd1beb78e993e940c3b46ca9898ce6d/src/go/ast/ast.go#L125-L128

My apologies, it turns out my godoc binary was an older version.  On update, everything works as you describe.
I'm also pleased to see that custom directives, like //my:directive also get stripped out!  (That would've been my next request. 😃)


[BUG] gemm_test uses rocblas instead of hipblas, but dose not include rocblas

With rocm 5.7 deepspeed no longer compiles as rocblas is use directly here:
https://github.com/microsoft/DeepSpeed/blob/4fc181b01077521ba42379013ce91a1c294e5d8e/csrc/includes/gemm_test.h#L68
instead of hipblas.
hipify translates to, and will only include, hip headers and thus this will fail to compile.
Previously in AMD's rocm implementation of hip, rocblas was indirectly included here, this is no longer the case in 5.7, thus any translation unit with this header in it will fail to compile
additionally HIP_PLATFORM_HCC is deprecated and should be replaced with HIP_PLATFORM_AMD in code paths that are intended to target the rocm hip implementation only

got the same issue, is there any workarounds ?

sure just include rocblas:
diff --git a/csrc/includes/gemm_test.h b/csrc/includes/gemm_test.h
index cd9fbb5a..2567615e 100644
--- a/csrc/includes/gemm_test.h
+++ b/csrc/includes/gemm_test.h
@@ -8,6 +8,7 @@
 #include <cuda_fp16.h>
 #ifndef __HIP_PLATFORM_HCC__
 #include <cuda_profiler_api.h>
+#include <rocblas/rocblas.h>
 #endif
 #include <array>
 #include <cstdio>

Worked like a charm, ty @IMbackK

CC: @rraminen and @jithunnair-amd for feedback on this?

Checking this issue

@IMbackK You mentioned "Previously in AMD's rocm implementation of hip, rocblas was indirectly included here, this is no longer the case in 5.7". Can you please specify which ROCm/HIP header you are referring to?

@jithunnair-amd unfortunately i can not, besides empirically observing that the subject header here compiles against rocm 5.5 but not 5.7

Filed https://github.com/microsoft/DeepSpeed/pull/4538

@IMbackK - can you please test with the linked PR?

@IMbackK Also, which extension were you building that ran into this error?
And just to clarify, afaik, this issue is not exactly coming from ROCm5.6->5.7 changes, but instead from a recent PyTorch commit where we switched to hipifying cublas_v2.h -> hipblas.h (instead of rocblas.h):
https://github.com/pytorch/pytorch/pull/105881/files#diff-85bd10d67a85149584e7d7a8cba533241f7ad14450e5d54ffec23da34032429aR609

@jithunnair-amd
Surprisingly i first encountered this while building cpu_adam
the object that fails to build is built with:
/opt/rocm/bin/hipcc  -DWITH_HIP -DTORCH_EXTENSION_NAME=cpu_adam -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1017\" -Ivenv/lib/python3.11/site-packages/deepspeed/ops/csrc/includes -I/opt/rocm/include -I/opt/rocm/include/rocrand -I/opt/rocm/include/hiprand -I/usr/lib/python3.11/site-packages/torch/include -I/usr/lib/python3.11/site-packages/torch/include/torch/csrc/api/include -I/usr/lib/python3.11/site-packages/torch/include/TH -I/usr/lib/python3.11/site-packages/torch/include/THC -I/usr/lib/python3.11/site-packages/torch/include/THH -I/opt/rocm/include -I/usr/include/python3.11 -D_GLIBCXX_USE_CXX11_ABI=1 -fPIC -std=c++17 -O3 -std=c++17 -g -Wno-reorder -L/opt/rocm/lib -lcudart -lcublas -g -march=native -fopenmp -D__AVX256__ -D__DISABLE_CUDA__ -fPIC -D__HIP_PLATFORM_HCC__=1 -DUSE_ROCM=1 -DCUDA_HAS_FP16=1 -D__HIP_NO_HALF_OPERATORS__=1 -D__HIP_NO_HALF_CONVERSIONS__=1 -O3 -std=c++17 -U__HIP_NO_HALF_OPERATORS__ -U__HIP_NO_HALF_CONVERSIONS__ -U__HIP_NO_HALF2_OPERATORS__ -DROCM_VERSION_MAJOR=5 -DROCM_VERSION_MINOR=6 --offload-arch=gfx900 --offload-arch=gfx906 --offload-arch=gfx1030 -fno-gpu-rdc -c venv/lib/python3.11/site-packages/deepspeed/ops/csrc/common/custom_hip_kernel.hip -o custom_hip_kernel.cuda.o
I can confirm that the above pr solves the intimidate issue of the extensions failing to build, however the resulting extension dose not function when loaded, its use immidatly resulting in a gpu page fault derefrecing a nullptr at least when compiled for GFX906, the gfx900 version seams to work fine.
I will try see if this also shows on deepspeed examples, or try and create a more minimal repoducer and report this new problem as a separate bug.

Thanks @IMbackK and @jithunnair-amd!


Bump version to 0.1.12

Bumps gem version from 0.1.11 to 0.1.12.

Happy to discuss whether we want to bump bundler version.
Also, I had to lock the paper_trail-association_tracking dependency. When I bundled, it got updated, which caused spec failures. Perhaps forcing bundler to use an older version would be better? 🤷♂

Ok.

That introduced some problems on CI. Will need to work through them.


Symbol not found: _locale_charset

🧐 Have you fully read the README and viewed similar issues?

[X] I have read the README
[X] I have read the FAQ
[X] I have checked previous issues, open and closed
[X] I have completed all troubleshooting steps and the issue is not present on stock but returns after re-applying SpotX-Bash

Сountry of your account
Romania
What is your Spotify Plan?
Free
Do you have Spicetify installed?
No
ℹ Computer information
- Spotify version: Spotify for macOS (Apple Silicon) <IP_ADDRESS>8.g0ea3f38b
- OS: Version 15.1 Beta (24B5024e)
- Shell:

📝 Description

Install latest line command tools (Command Line Tools for Xcode 16 beta 5) from Apple website https://download.developer.apple.com/Developer_Tools/Command_Line_Tools_for_Xcode_16_beta_5/Command_Line_Tools_for_Xcode_16_beta_5.dmg
Ran " bash <(curl -sSL https://spotx-official.github.io/run.sh) " in terminal.

🖥 Terminal Input/Output
bash <(curl -sSL https://spotx-official.github.io/run.sh)
dyld[18049]: Symbol not found: _locale_charset
Referenced from: <048CD29D-401C-3C6F-8510-0E061FCC7B40> /opt/local/bin/bash
Expected in:     <9521588A-E5D2-3C93-A726-0EF520C9A854> /opt/local/lib/libiconv.2.dylib
[1]    18049 abort      bash <(curl -sSL https://spotx-official.github.io/run.sh)
curl: (23) Failed writing body
📸 Screenshots
No response

Based on your output, it suggests that this error is unrelated to SpotX-Bash script and has to do with:
_dyld[18049]: Symbol not found: locale_charset
Referenced from: <048CD29D-401C-3C6F-8510-0E061FCC7B40> /opt/local/bin/bash
Expected in: <9521588A-E5D2-3C93-A726-0EF520C9A854> /opt/local/lib/libiconv.2.dylib
It would suggest an issue between your bash and libiconv.2.dylib binaries. Those binary paths do not look to be standard macOS locations for bash. Using the default macOS bash binary or fixing your current setup should hopefully resolve the error.

I've been searching for like the past 4hrs for a solution but can't get it working.
How can i fix it or use the default macOS bash? I do not remember installing anything related to git/bash on my machine other than what was already installed by default...

Based on the paths in your error, it suggests you have used macports at some point to install bash.
Does /bin/bash binary exist on macOS 15.x?  You'd then be able to run:
/bin/bash <(curl -sSL https://spotx-official.github.io/run.sh)

If not, I'd suggest using homebrew to install bash/update and use that.
Your bash binary which is being used @ /opt/local/bin/bash is expecting and referencing "locale_charset" in the /opt/local/lib/libiconv.2.dylib binary, however "locale_charset" missing in /opt/local/lib/libiconv.2.dylib, therefore bash fails to continue running and you get the error you are seeing.

Interesting. So it seems macOS beta 15.1 has some bugs and they need to rebuild either their bash and/or libiconv.2.dylib binaries based on what I'm seeing in your errors.
As for the homebrew permission issue.. it seems you're using the bash directory path and not the binary path. An example of the full path would be:
/opt/homebrew/Cellar/bash//bin/bash
This entire issue seems unrelated to SpotX-Bash at this point and has become a macOS 15.1 beta bugs and/or how to install and setup bash with homebrew.

Yes, seems like that. Thank you for your support. You can close the issue.

Curious what your output from the following is...
/opt/homebrew/bin/bash <(curl -sSL https://spotx-official.github.io/run.sh)

still permission issue?

Very odd. And the repo alternate link in FAQ produces same error?
bash <(curl -sSL https://raw.githubusercontent.com/SpotX-Official/SpotX-Bash/main/spotx.sh)

does downloading the file and running locally also produce an error?
curl -LO https://raw.githubusercontent.com/SpotX-Official/SpotX-Bash/main/spotx.sh && chmod +x ./spotX.sh && bash ./spotX.sh

damn...

Seems that it worked with sh.
sh <(curl -sSL https://raw.githubusercontent.com/SpotX-Official/SpotX-Bash/main/spotx.sh)

Yes..

Yes..

Well that confirms it's 100% unrelated to something in SpotX-Bash. I'll assume this is just something broken in the macOS beta.
If this gets resolved for you in a future beta or stable update, please report back if you think of it. Curious wtf is going on and hoping an update resolves this.
For future reference, if macOS users run into this issue... users should attempt using sh instead of bash.
Closing this for now...


fix: do not wait on zero retries

Closes #89 , /cc @xyluet

Coverage decreased (-8.9%) to 91.105% when pulling 560faa362c2f6121d2afb614c54f4b83f2136e2c on greut:fix/wait-when-no-retries into 2f1fd2700e9d549092e9c249e08be101a6a887c6 on gojek:master.

Coverage decreased (-8.9%) to 91.105% when pulling 560faa362c2f6121d2afb614c54f4b83f2136e2c on greut:fix/wait-when-no-retries into 2f1fd2700e9d549092e9c249e08be101a6a887c6 on gojek:master.

Better to add test, an example from my issue should enough, then let the maintainer decide. :+1:

ExampleWithRetrier is the test.


CASMTRIAGE-5737-release/1.6 bump csm-testing and goss-servers version

Summary and Scope
Bump csm-testing and goss-servers version to include changes for CASMTRIAGE-5737-release/1.6
CASMTRIAGE-5737 fixes bugs in ceph-service-status.sh goss script.
Testing
Tested on CSM-1.5 system.
Pull Request Checklist

[x] Version number(s) incremented, if applicable
[ ] Copyrights updated
[ ] License file intact
[x] Target branch correct
[x] CHANGELOG.md updated
[x] Testing is appropriate and complete, if applicable
[ ] HPC Product Announcement prepared, if applicable

Closing this PR because these changes are being included in the version bump by CASMPET-6260


[tests] more runtime tests enhancements

Build testprog binaries with debug symbols for Release builds
Use Python Popen to call BEFORE and AFTER

Wait until BPF program attached to call AFTER (we need to run
programs with -v for that, otherwise we don't know when the BPF
program is attached)

Revamp TIMEOUT

Have a default timeout for attaching to a program (5 seconds) and
a default timeout for the program to exit (also 5 seconds). The second
timeout can be overriden in a test by test basis
If the test times out, check the output first to see if our test
condition passed. Only fails if it doesn't.
Kill the test if it's still running after timeout, so the process
doesn't keep running forever.

Changed a few tests to make them more reliable

These are the last changes I had to make for our runtime test suite to work on AppVeyor. I'll tidy up the appveyor config file and open a PR after this one landed.


Add ProtocolVersion property to AWS::ElasticLoadBalancingV2::TargetGroup

Hi,
When I trying to apply my troposphere template with ProtocolVersion specifyed for targetgroup i receive an error:
failed (AWS::ElasticLoadBalancingV2::TargetGroup object does not support attribute ProtocolVersion)
I need it for creating gRPC targetgroups for my infrastructure. Can somebody help me please?

Fixed. Thanks for the issue.


Autocomplete does not show up

Somehow the autocomplete doesn't work, but :CmpStatus shows that it's ready.

Tested on nvim 0.7.2

Hi, thanks for submitting this issue.
I want to first check if other source engines for cmp are working and it's only the cmp-tw2css that is not working.
Also cmp-tw2css does its job only when the cursor is in the css code block. Could you verify that it's still not working inside the css block?

Thanks for your reply. I just tested this with a minimum configuration along with cssls lsp:

init.lua
vim.cmd [[packadd packer.nvim]]

require('packer').startup(function(use)
  use 'wbthomason/packer.nvim'
  use 'neovim/nvim-lspconfig'
  use 'hrsh7th/cmp-nvim-lsp'
  use 'L3MON4D3/LuaSnip'
  use 'saadparwaiz1/cmp_luasnip'
  use { 'hrsh7th/nvim-cmp', requires = 'jcha0713/cmp-tw2css' }
end)

vim.opt.completeopt = {"menu", "menuone", "noselect"}

local cmp = require'cmp'
cmp.setup({
  snippet = {
    expand = function(args)
      require('luasnip').lsp_expand(args.body) -- For `luasnip` users.
    end,
  },
  window = {},
  mapping = cmp.mapping.preset.insert({
    ['<C-b>'] = cmp.mapping.scroll_docs(-4),
    ['<C-f>'] = cmp.mapping.scroll_docs(4),
    ['<C-Space>'] = cmp.mapping.complete(),
    ['<C-e>'] = cmp.mapping.abort(),
    ['<CR>'] = cmp.mapping.confirm({ select = true }), -- Accept currently selected item. Set `select` to `false` to only confirm explicitly selected items.
  }),
  sources = cmp.config.sources({
    { name = 'luasnip' }, -- For luasnip users.
    { name = 'nvim_lsp' },
    { name = 'cmp-tw2css' },
  })
})

local capabilities = require('cmp_nvim_lsp').update_capabilities(vim.lsp.protocol.make_client_capabilities())
local lspconfig = require('lspconfig')
lspconfig.cssls.setup {
  capabilities = capabilities,
}

Hey, thank you for providing the minimum config and sorry for the delay.
I used your your init.lua and almost reimplemented my plugin from scratch to make sure we're dealing with the same error.
It turns out that you might be missing the css parser for treesitter. You can install it using :TSInstall css command.
Try this and let me know if this solves your issue.

Hmm... It's still not working. I tried reinstalling neovim from clean start and running :TSInstall css but still get the same result. I'm going to try this with a different machine and keep you updated.

Hmm.. that's odd. Can you make sure you have nvim-treesitter installed in your neovim?

Yes

Suddenly, I can see the auto completion working. I didn't try to fix it and don't know what happened lol. Probably cause the update? Anyway, thanks for making this plugin!


Added the tag enun name to the profiling marks.

For example, whereas previously we'd have
GRPC_LAT_PROF<PHONE_NUMBER>734.095703 0x7f0b4bff7700 { 200 (nil) src/core/iomgr/tcp_posix.c 337
now we have:
GRPC_LAT_PROF<PHONE_NUMBER>734.095703 0x7f0b4bff7700 { 200(GRPC_PTAG_HANDLE_READ) (nil) src/core/iomgr/tcp_posix.c 337
Note the literal enum name in parenthesis following the tag int value.

Reassigning as I'm out today

LGTM. Waiting for Travis.


Change package name to @autorest/csharp

Also remove .v3 from the code?

We decided this is something we will not be changing


Update README.md

add yakpro-po:  a php obfuscator
framework agnostic, MIT license.

I do not know why "needs: explanation", as i already added a description...

Thanks for your suggestion.


Related to #144

Would fix various uri behavior according to rfc 3986 instead of only support rfc 2396.

I prefer a more descriptive commit message

@siad007 thanks for updates. Next steps are to rebase and squash this down to a single commit.

Closed due to age


headers order

can i change the headers order  ?

I don't think libcurl supports that.
What are you trying to achieve by reordering HTTP headers?


Use ServiceDirectory for tests builds

Uses the ServiceDirectory traversal project in tests.yml.
@Azure/azure-sdk-eng
@maririos -- This change uses a traversal project that will include all tests projects for KeyVault

@danieljurek do you have an estimate on when this is going to get addressed/merged?

/azp run net - appconfiguration - tests

/azp run net - core - tests

/azp run net - eventhubs - tests

/azp run net - storage - tests

@maririos -- this should be merged shortly


Update NuGet package

Could you please update the NuGet packages?

Will be updated with the next release

When will the new version be released?


Change default constants and update ProverStateBuilder::default() description

cf Jira ticket
Default parameters are now sufficient for any transaction (as we should expect default values to be), and added explanation about the tradeoff memory consumption / provable transactions.

The CI failure is due to latest nightly, same issue on plonky2 side. Let me pin the nightly version first.


Print local services output

     SUCCESS  Started Local Services!
    +------------------+------------------------------------------------------------------+
    | RUNNING          | true                                                             |
    | RUNDIR           | /run/user/1000/nitric/rest-api                                   |
    | GATEWAYADDRESS   | :9001                                                            |
    | MEMBRANEADDRESS  | localhost:50051                                                  |
    | MINIOCONTAINERID | 196a3cf88054b22ae740a51ade2e9aab864b3d0fc2bf54989beb3e7fd7831011 |
    | MINIOENDPOINT    | localhost:9000                                                   |
    +------------------+------------------------------------------------------------------+
    ```

Requested by @raksiv

Codecov Report

Merging #55 (06bd8f0) into develop (74bb223) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #55   +/-   ##
========================================
  Coverage    57.91%   57.91%
========================================
  Files           23       23
  Lines         1067     1067
========================================
  Hits           618      618
  Misses         381      381
  Partials        68       68

Flag
Coverage Δ

unittests
57.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74bb223...06bd8f0. Read the comment docs.


etcd cluster vote constantly!

etcd version 2.3.7
It is a three nodes cluster. Because of power cut, one of the etcd is down which snopshot file is broken. The rest two etcd are running well but vote constantly.
The network and disk are well, I checked the metrics. I tried to restart, but it doesn't work.
At the beginning of vote, both of the etcd start votes constantly, and did not reponse the other. After a while, one becomes a follower, but the other still starts votes constantly.
And there are also some "publish error: etcdserver: request timed out" errors.
Sorry I can't offer logs or something detail, becacuse it is a internal environment. I meet this situation at least twice.
Is this a problem? Please give me some idea, thanks.

What's the server error message? And metrics output?

@gyuho
The error is just "publish error: etcdserver: request timed out" and can not connect to the failed one. The vote has no error.
The log is like(sorry I can't copy)
xxx is start vote   term 22323
xxx is set to candidate
sent vote message to yyy
sent vote message to zzz
xxx is start vote   term 22324
xxx is set to candidate
sent vote message to yyy
sent vote message to zzz
...(repeat)
Metrics I checked  fsync and raft_failed. fsync are all less 0.001s, the raft_failed is all send to the failed etcd.

We are not actively maintaining etcd v2 any more. Please try etcd 3.x releases.

(ó﹏ò｡)


Add commonAnnotations to Cassandra metadata

What is missing?
There should be a commonAnnotations field in the cassandra.metadata section of the ressource K8ssandraCluster.
Why do we need it?
Other operators in our Kubernetes cluster are interfering with the resources created by the cass-operator, and we need to add annotations to exclude these resources from the other operators.
Environment

K8ssandra Operator version:
v1.9.1

Anything else we need to know?:
No.

Looks very usefull for argocd.

From discussions internally and reviewing the conversations on discord, it looks like what is being asked for here is annotations for the statefulset, pods etc. coming from cass-operator.
I was originally going to implement this in k8ssandra-operator, but

Modifying the podTemplateSpec won't necessarily modify the statefulSet itself.
There is a preference amongst the rest of the team for adding an AdditionalAnnotations field in the cass-operator CRD instead of doing this via the podTemplateeSpec.

I'll raise a ticket on cass-operator first, then expose this in k8ssandra-operator as a second step.


EnumSerializer fails when when multiple enums are used

lift-json-ext's EnumSerializer and EnumNameSerializer do not work properly when multiple enums are used to serialize/deserialize data.
The root cause appears to be the use of,
  val EnumerationClass = classOf[E#Value]

which returns the same class for all Enumeration-deriving classes, and therefore the subsequent match:
    PartialFunction[(TypeInfo, JValue), E#Value] = {
      case (TypeInfo(EnumerationClass, _), json) => json match {

matches against any possible enums, leading to -- at best -- a runtime failure because the enum value cannot be found, or -- at worst -- a sneaky failure since a different enum value may be returned.
I'm attaching a test that demonstrates the issue with EnumNameSerializer.

Hey there, this can be solved with existing tools like mentioned in this blogpost here.
By having a single Enum to match this against, this apparently works.
/*
*  Serializer and Deserializers for Enumeration
*/
class EnumerationSerializer(enumList: List[Enumeration]) extends net.liftweb.json.Serializer[Enumeration#Value] {
  import JsonDSL._
  val EnumerationClass = classOf[Enumeration#Value]
  val formats = Serialization.formats(NoTypeHints)

 //  Deserializer Function for Enumeration
  def deserialize(implicit format: Formats): PartialFunction[(TypeInfo, JValue), Enumeration#Value] = {
    case (TypeInfo(EnumerationClass, _), json) => json match {
      case JObject(List(JField(name, JString(value)))) => fetchEnumValue(enumList, value)  // Here we can perform the
      case JString(value) => fetchEnumValue(enumList, value)                               // desired function
      case value => throw new MappingException("Can't convert " +
        value + " to " + EnumerationClass)
    }
  }

  def serialize(implicit format: Formats): PartialFunction[Any, JValue] = {
    case i: Enumeration#Value => i.toString
  }

  private def fetchEnumValue(enumList: List[Enumeration], value: String): Enumeration#Value = {
    var defaultEnumValue: Enumeration#Value = Year.withName("FinalYear")
    for (enumItem <- enumList) {
      for (enumValue <- enumItem.values) {
        enumValue.toString == value match {
          case true => {
            defaultEnumValue = enumItem.withName(value)
          }
          case _ => None
        }
      }
    }
    defaultEnumValue
  }

}

Yes, I believe that's very similar to the solution holograph posted above, with the same caveat that you need to make sure your enums don't share any same-named values.

Are we really satisfied with this?
I don't think this is satisfactory at all. We use lots of Enumerations, like this:
trait ValueWithDescription[T]  {
    def description: String
    def name: String
	def wrapped: T
}

abstract class EnumWithDescriptionAndObject[T] extends Enumeration {

	abstract class ExtendedValue(id: Int) extends Val(id) with ValueWithDescription[T]

	def Value(inDescription: String, inWrapped: T) = new ExtendedValue(nextId) {
		def description = inDescription
		def name = toString()
		def wrapped = inWrapped
	}

	def Value(inWrapped: T): ExtendedValue = Value("", inWrapped)

	def getValues = {
		super.values.map(v => v.asInstanceOf[ExtendedValue]).asInstanceOf[Set[ExtendedValue]].toSeq
	}

	def valueOf(name: String) = try{Some(withName(name).asInstanceOf[ExtendedValue])} catch {case _: Throwable => None}

	def unapply(value: String) = getValues.find(_.toString == value)

}

object InvoiceStatus extends EnumWithDescriptionAndObject[(String, Int)] {
	val DRAFT = Value("Draft" -> 1)
	val IN_PROGRESS = Value("In progress" -> 2)
}

With the same-name restriction we won't get to serialize another Enum with value DRAFT, which we have several others of.
Enums we use must hold the following properties:

Must be able to contain "extra info", hence the [T]. This way we can create Enums holding arbitrary info (like i18n strings etc).
Must be able to query the values for an Enum
Must be able to create one from its String-representation

Other well established, Scala based, JSON frameworks use macros and/or reflection now, maybe it's time to reconsider?

I actually think we've been vindicated in our decision—scala.reflect will never leave experimental mode as I've understood it, as it's meant to be superseded by scala.meta. When 2.12 comes out it may be worth looking at building on top of scala.meta, since it seems that there are longer-term plans for its support—though time will tell.
We largely stopped using Scala Enumerations altogether in work projects a long while ago, opting instead to deal with our own as Farmer outlined above (singleton objects that extend sealed traits, with accompanying serializer). We haven't felt much if any pain from it.
That said, if you have a good serializer for the example you gave above, sharing it would be cool. I'm not morally opposed to improving the lift-json enum serializer with the implementation Franz and holograph posted, mind you, given that it's “less limited”, though still limited.

Scala.meta is (will be) nice, but we need solutions which work today, with today's tools, ie. scala-2.11.
I don't understand how people working with Enums don't have the 3 requirements we have.

What requirements are not met by the sealed trait / case object pattern above?

Also we're probably at the point where this discussion should be happening on the ML.

How do you hold "extra info" like a [T]?
Create an enum-instance from its String-representation
Query all values of an Enum

With my abstract EnumWithDescriptionAndObject creating an Enum by extending it is easy:
object InvoiceStatus extends EnumWithDescriptionAndObject[(String, Int)] {
    val DRAFT = Value("Draft" -> 1)
    val IN_PROGRESS = Value("In progress" -> 2)
}

It meats the requirements:

Hold "extra info"
The InvoiceStatus enum holds "extra info" of type (String, Int), which is passed to Value()
Query all values of an Enum
InvoiceStatus.getValues
Create an instance form its String-representation:
InvoiceStatus.valueOf("DRAFT")

How do you do this with the sealed trait approach?

Ah, so I see what you mean by extra info now.
So, in all honesty you can use case classes with sealed traits as well. Those could hold more information in places where you need it. Likewise, creating a case object from it's string like representation is what the SingletonSerializer does. W.r.t. querying all values, you would need to maintain an all collection on your own, which is a little bit of boilerplate but doable. Might also be some options with Java reflection to accomplish that if you must.

I'm sure its doable, but when you have many Enums with those requirements then constructing them by extending EnumWithDescriptionAndObject looks much easier then having lots of traits/case classes.

I think we've reached a difference in opinion, or perhaps one in design. We've been using the trait/case object pattern for ~ 2 years now and never run into a situation where it looked difficult enough to be annoying. There's some boilerplate, but we avoided the technical debt involved in trying to figure out custom Enum support based on a library that (it looks like) will be thrown away.
There could be some discrete requirements that you have which we don't that makes that difficult for you. YMMV. But I think the right answer from the POV of the framework is to wait on meta.
Just my $0.02.

We're using JPA and writing converters for our kind of Enums is very easy, the converter looks like this:

// The abstract converter for our Enums
abstract class EnumConverter[T, D](et: Enumeration) extends AttributeConverter[T, String] {
	def convertToDatabaseColumn(attribute: T): String = {
		if (attribute == null) {
			null
		} else {
			attribute.toString
		}
	}

	def convertToEntityAttribute(dbData: String): T = {
		if (dbData == null) {
			null.asInstanceOf[T]
		} else {
			et.withName(dbData).asInstanceOf[T]
		}
	}

}

@Converter
class InvoiceStatusConverter extends EnumConverter[(String, Int), String](InvoiceStatus)

That's one line for the developer for each Enum-type. I'm not sure the converters are so easy to write using the sealed trait approach.
I think its strange that there are so many objections to provide a good solution for this serialization-problem for Scala-2.11, given that's the version 3.0 is aiming for. Isn't waiting on meta the same as saying we're aiming for 2.12? That certainly isn't the case.
Why is using Scala-reflection any worse then today's solution using java reflection and scalap/paranamer? If the argument was lack of resources to implement this I'd be OK with it but that doesn't seem to be the case reading this thread.

Let's move this to the ML if we want to continue the discussion where everyone can see and participate instead of having the conversation in the silo of a GitHub issue.

The existing code is already written and battle-tested. If a committer wants to write new code based on scala-reflect and commit to maintaining it until scala-meta, that's fine. I'm not, and Joni seems largely occupied with other things, so it doesn't look like he is either. This isn't the first time we've had this discussion, and the only new information that's come to light since then is the certainty that scala-reflect is going to disappear from under us, which isn't exactly a vote in its favor.
Agreed that continuing on the ML is the right way to go if we want to continue.

The lack of maintainer for lift-json is, IMO, a serious concern. Even if the API is stable, if it's not meeting the needs of developers developing modern apps then other tools are needed, and developers are going to look for them. I'll try to write some "not so negative" mail on the ML and move the discussion there.


Loss increases gradually

As I go into the 70000 iteration, the loss and val_loss seem to increase then decrease training on a 2.3G dataset running the command:
th -input_h5 data/all.h5 -input_json data/all.json -model_type lstm -num_layers 3 -rnn_size 512 -batch_size 100 -seq_length 100 -print_every 1 -checkpoint_every 10000 -reset_iterations 0 -max_epochs 10

Here's a log.txt file of the entire training:
log-file.txt

There are multiple things that can cause this, in my experience. Your learning rate might be too high, or you might have to decrease faster for large datasets. For example, this is the script I use for my 230MB dataset (using my torch-rnn fork with extra features):
BASECMD='th train.lua -input_h5 data/combined-latest.h5 -input_json data/combined-latest.json -gpu 0 -gpu_opt -2 -low_mem_dropout 0 -dropout 0.10 -shuffle_data 1 -zoneout 0.01'
MODEL='-seq_offset 1 -model_type gridgru -wordvec_size 1024 -rnn_size 2048 -num_layers 4'
CPNAME='cv/combined-20190212'
CPINT=10214
CMD="$BASECMD $MODEL -checkpoint_every $CPINT"
export CUDA_VISIBLE_DEVICES=1,2
mkdir -p $CPNAME

$CMD -batch_size 128 -seq_length 256  -max_epochs 6  -learning_rate 4e-4   -lr_decay_every 2 -lr_decay_factor 0.5 -checkpoint_name $CPNAME/a -print_every 250
$CMD -batch_size 64  -seq_length 512  -max_epochs 10 -learning_rate 5e-5   -lr_decay_every 2 -lr_decay_factor 0.7 -checkpoint_name $CPNAME/b -print_every 250 -init_from $CPNAME/a_$(($CPINT*6)).t7  -reset_iterations 0
$CMD -batch_size 32  -seq_length 1024 -max_epochs 14 -learning_rate 2.5e-5 -lr_decay_every 2 -lr_decay_factor 0.7 -checkpoint_name $CPNAME/c -print_every 250 -init_from $CPNAME/b_$(($CPINT*10)).t7  -reset_iterations 0
$CMD -batch_size 16  -seq_length 2048 -max_epochs 16 -learning_rate 1.2e-5 -lr_decay_every 1 -lr_decay_factor 0.5 -checkpoint_name $CPNAME/d -print_every 250 -init_from $CPNAME/c_$(($CPINT*14)).t7 -reset_iterations 0

It also could be caused by not randomly ordering the sequences during training, this is also implemented in my fork and it made my model train more smoothly.


"raw HTML omitted" again

Hello,
Juste updated the theme, there are not so many commits on main branch so I was surprised my included pages did not work and I saw "raw HTML omitted" in html output. Well, my last follow of theme changes goes back to May 1st, a month ago, LOL.
Fortunately this was solved again by enabling this again in hugo.toml:
[markup]
  [markup.goldmark]
    [markup.goldmark.renderer]
      unsafe = true

My website's _index.md page includes other pages with relative path:
{{% include "./includes/last_thought.md" true %}}

{{% include "./includes/last_poems.md" true %}}

In /includes/_index.md I have put only this because this folder contains all the hidden pages of the site so thet I have one place for often changing content:
+++
title = "Inclusions"
hidden = true
+++

In the two aforementioned included .md pages there is a very simple header:
+++
title = "Derniers ajouts"
+++

Then some text with some other include or links to other pages. No html.
What do you think of this behavior? I also noticed that I still used Hugo 0.124 so upgraded to latest 0.126.2.

Hi Barbara, thanks for reporting.
This time "raw HTML omitted" comes from your usage of the include shortcode, which wasn't the cause in your older issue.
Sadly include currently behaves this way and to make it work for you right now is to use `unsafe=true'
As they say in the Hugo forum:

It is not unsafe if you are in control of your content.


tracker/snapshot_file_contents: use Vec::with_capacity

instead of new / reserve.
Flagged by clippy.

Came back over here to follow up on mine, saw this, it's small so let's land since we have to do a release shortly.


cmd/compile: expand_calls cleanup causes compile failure

What version of Go are you using (go version)?

$ go version
go version devel go1.22-bf876fbf44 Fri Oct 6 17:09:13 2023 -0400 darwin/amd64

(i.e., near tip on 2023-10-10)
Does this issue reproduce with the latest release?
No
What operating system and processor architecture are you using (go env)?
go env Output
$ go env

What did you do?
  git clone https://github.com/hashicorp/terraform-provider-azurerm
  cd terraform-provider-azurerm
  cd internal/
  cd services
  cd policy
  go test -c .

What did you expect to see?
Not a compiler crash
What did you see instead?
A compiler crash:
# github.com/hashicorp/terraform-provider-azurerm/internal/services/policy
./assignment_subscription_resource.go:46:2: internal compiler error: 'SubscriptionAssignmentResource.Create': not lowered: v6, StructMake0 STRUCT
etc

Duplicated of https://github.com/golang/go/issues/63433


Update CHANGELOG

There is no info after 0.16.3-0.5.1.
This should be updated.

git-chglog looks having a bug and it returns an error when a version including '+' in it is given.

git-chglog looks having a bug and it generates a wrong CHANGELOG for git-chglog v1.1.9+0.8.0..v1.1.9-0.7.0.
If we tag v1.1.9-0.8.0 for v1.1.9+0.8.0 and execute git-chglog v1.1.9-0.8.0..v1.1.9-0.7.0, it also generates a wrong CHANGELOG.
We need to make/use another tool for generating CHANGELOG for our versionings.

I missed we set a version filter in .chglog/config. We should just fix it.

We will make it strict for our repository's rule.

In main branch, we will use following version rule to release the tag in the feature. ^v\d+\.\d+\.\d[+-]\d+\.\d+\.\d+$
For example, v1.0.0-0.7.0, v1.0.0+0.8.0

In fork branch, like dynamiclink branch,  we will use following version rule to release the tag in the feature. ^v\d+\.\d+\.\d[+-]\d+\.\d+\.\d+-dynamiclink.+$
For example, v1.0.0-0.7.0-dynamiclink1, v1.0.0+0.8.0-dynamiclink2


ObservableDictionary Remove event is not fired

The ObservableDictionary class in NSwag.Core does not fire the Remove event because of the commented line:
https://github.com/RicoSuter/NSwag/blob/c3b6597f599a92d15538a362e56467ef4d1ecd71/src/NSwag.Core/Collections/ObservableDictionary.cs#L254
Please consider uncommenting this line to have the event properly fire.

What is the problem with this missing?


Lock parent objects before create/update/delete of their children

It may be possible for a write operation to a parent object's children to fail if the parent is removed by cleardeleted.py just before the child operation is performed. In this case, the client would receive an 500 internal server error status, instead of 404 not found.
This may be prevented (if necessary) by locking the child object for (for update and delete requests), which will block a delete of the parent because it would cascade to the child. As for creates, they would require explicit locking of the parent (unless the rest framework selects the parent for update during validation of the parent field against the parent queryset).

It may also be possible to implement the child locking with less code by subclassing the nest mixin from sync and using its isolated option. If that way is chosen, unnecessary transactions should be removed from nest. The same is true for limit (which explicitly inherits from sync, and may have unnecessary atomic blocks).

Fixed in e60d42a9725f4088c66a35ea40488c2bda6da005.


Fix for #107 bug - CDATA stripping

This one is difficult to cleanly fix. AngleSharp, doesn't process some of the XML elements in a suitable way for XML, and thus adds some extra text in the CDATA Tag.
I had considered using AngleSharp.Xml, but this is dependant on 0.11.X which doesn't support the version of the .Net framework we are using. Ideally I would have liked to use this to assist in proper parsing of CDATA values but is likely to be a more substantial change.
Light testing is done based on some limited info, please test with your scenario if you already have one setup.
Related to #107

@pkbullock: have been playing around with this one and indeed the root problem is AngleSharp's bad CDATA section handling. The correct solution is to wrap the contents as CDATA in the created template file and then remove the CDATA sections as "usage" time...however we need to get AngleSharp so far to give us the correct content first. Seems like it's going wrong with the CDATA ending tag as that ends up as end tag of the first element

@jansenbe I did look at this: https://github.com/AngleSharp/AngleSharp.Xml to resolve but the dependency on the version of .NET Standard makes the scope much wider.
In addition, AngleSharp alters part of the content within the CDATA tag e.g. <p> becomes <![CDATA[<p--> and  becomes ]]-->
I haven't tried altering the solution to put CDATA inside  …   rather than the attribute to see if that is parsed differently.

Hi @pkbullock , I've implemented in a slightly different way, closing this PR now


Im not even Sure...

So I set up everything and tested it and it worked. I had all the turtles come home and they were all in park before I left and rejoined. when I di they all started wondering around far away from anything. i tried resterting them, rebooting, halting clearing nothing worked. i got frustrated and just destroyed everything and started with new blocks, but now when ever I set it up
it just refuses to work. once I link a turtle it just goes north and doesn't stop. not sure what I've done wrong but I ended up nuking my world in frustration so a little help;p would be really appreciated. Thanks agina.

Oh my. Well I think under the circumstances the nuke was a good call. Other people have been having problems as well and I haven't been able to figure it out since I can't reproduce the issue (and there aren't any logs I can ask for). No chance you're playing on a server is there? I'd love to come on and take a look.

Oh my. Well I think under the circumstances the nuke was a good call. Other people have been having problems as well and I haven't been able to figure it out since I can't reproduce the issue (and there aren't any logs I can ask for). No chance you're playing on a server is there? I'd love to come on and take a look.


Storybook crashes when changing icon name

Describe the bug
As mentioned on Slack – when a user change the name value on the icon examples the page crashes.
Steps to reproduce the bug

Go to https://eds-storybook-react.azurewebsites.net/?path=/docs/components-icon--icon-examples
Change the value of the name property

Expected behavior
It should show the icon you put into the name field
Specifications

Version: n/a
Browser: Microsoft Edge
OS: macOS Big Sur

This is due to our check if provided icon name exists in our library here.
We had weird errors getting this option to work with Storybooks select option in props table for some reason during conversion of story. Might work now since we have updated Storybook since then.


move sensiolabs/security-checker to composer-dev

Q
A

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Related tickets
fixes #277

License
MIT

Ping @bitbager


Update badges to point to gz-fuel-tools10

Part of https://github.com/gazebo-tooling/release-tools/issues/1092

Can you include the abichecker in the required checks?


mock_dynamodb2 does not raise ResourceNotFoundError in call to boto3.client("dynamodb").batch_write_item() with an inexistent table

Description
Specifying a DynamoDB table that does not exist in the boto3.client("dynamodb").batch_write_item() function is expected to raise a ResourceNotFoundError. When using mock_dynamodb2, no exception is raised.
Steps to reproduce
Run the following test:
import boto3
from moto import mock_dynamodb2
import pytest

@mock_dynamodb2
def test_client_batch_write_item_exceptions():
    client = boto3.client("dynamodb")

    with pytest.raises(client.exceptions.ResourceNotFoundException):
        # Table my-table does not exist
        client.batch_write_item(
            RequestItems={"my-table": [{"PutRequest": {"Item": {}}}]}
        )

Expected behavior
The test passes, i.e. a ResourceNotFoundException is raised.
Actual behavior
No exception is raised.
$ python -m pytest -v tests/test_tests.py
========================================= test session starts =========================================
platform linux -- Python 3.8.10, pytest-6.2.4, py-1.10.0, pluggy-0.13.1 -- /home/jul/git/dynamo-pandas/.venv/bin/python3
cachedir: .pytest_cache
Using --randomly-seed=3831102734
rootdir: /home/jul/git/dynamo-pandas, configfile: tox.ini
plugins: cov-2.12.1, randomly-3.8.0
collected 1 item

tests/test_tests.py::test_client_batch_write_item_exceptions FAILED                             [100%]

============================================== FAILURES ===============================================
_______________________________ test_client_batch_write_item_exceptions _______________________________

    @mock_dynamodb2
    def test_client_batch_write_item_exceptions():
        client = boto3.client("dynamodb")

        with pytest.raises(client.exceptions.ResourceNotFoundException):
            # Table my-table does not exist
>           client.batch_write_item(
                RequestItems={"my-table": [{"PutRequest": {"Item": {}}}]}
            )
E           Failed: DID NOT RAISE <class 'botocore.errorfactory.ResourceNotFoundException'>

tests/test_tests.py:12: Failed
======================================= short test summary info =======================================
FAILED tests/test_tests.py::test_client_batch_write_item_exceptions - Failed: DID NOT RAISE <class '...
========================================== 1 failed in 0.25s ==========================================

Environment
Packages installed with pip in a virtual environment on Ubuntu 20.04.
boto3                             1.18.48
botocore                          1.21.48
moto                              2.2.7

Potentially related to #4344.


Add Part (b) assignment section in README

Ok, I think this is the correct place to make the pull request on this branch... regards...

Hello @samshadwell this is Leo (@bruceLeeO) and my fellow contributor @luisRojas29 and we are sending you this pull request as part of our collaboration project assignment at Learn.ModernDeveloper.  We are learning about GitHub and its inner workings and as part of our assignment we are to fork a popular, remarkable repository like yours and learn as much as we can about the technology and then offer to make a contribution to the already outstanding README file.
We are to offer two parts in the README file: 1) to write a Clear, Easy to Understand Introduction for TrumpScript repository and 2) to include a What is TrumpScript Use For and When to Use It section in the README.
Our aim is to provide visitor a clear, easy-to-comprehend introduction

Hello @samshadwell this is Leo (@bruceLeeO) and my fellow contributor @luisRojas29 and we are sending you this pull request as part of our collaboration project assignment at Learn.ModernDeveloper. We are learning about GitHub and its inner workings and as part of our assignment we are to fork a popular, remarkable repository like yours and learn as much as we can about the technology and then offer to make a contribution to the already outstanding README file.
We are to offer two parts in the README file: 1) to write a Clear, Easy to Understand Introduction for TrumpScript repository and 2) to include a What is TrumpScript Use For and When to Use It section in the README file.
Our aim is to provide visitor a clear, easy-to-comprehend introduction for TrumpScript and a new section that briefly describes What TrumpScript is use for and when to use it .  Seasoned developer, new programmers, and even nontechnical visitor will benefit from the clear language, exposing TrumpScript to a broader range of users.
We have learned a great deal and we strive for excellence. We are very honored to have worked through your TrumpScript repository and we hope you find our contribution beneficial.
Leo and Luis

Sorry guys, I don't think this really adds much. I appreciate that you're trying to contribute, but this PR doesn't really align with what we're trying to do. I feel like this is mostly just repeating the other information we've already got in the README, and is even a bit misleading. Like, it seems to imply that it won't throw errors, and that you can ignore the language syntax, which simply isn't true.

That's fine Sam.  This has been a great learning experience for us and we appreciate your feedback.


.stretched-link behaviour on table rows

Codepen here:
https://codepen.io/anon/pen/EJPQzL
Expected behaviour
Expected behaviour on using .stretched-link in a table would be that the whole row would get clickable by setting the
 to position-relative.
Actual output
Actual output shows that the pseudo element of the .stretched-link class gets 100% of the body height - effectively breaking hover.
A possible hacky workaround would be to place the link tag multiple times per table row and putting position-relative on each of the  items

This is just not possible in CSS due to the specs https://www.w3.org/TR/CSS21/visuren.html#propdef-position:

The effect of 'position:relative' on table-row-group, table-header-group, table-footer-group, table-row, table-column-group, table-column, table-cell, and table-caption elements is undefined.

Perhaps we add a docs mention that links to that comment @MartijnCuppens?

One way around this is to create a
 directly within each  and add the  along with any other content. You'll also need to remove the padding from each  with p-0 and add padding to the
 with p-3.
Example:

           Test


recognize the variable as a used and read variable

  Logout(access_token) {
    this.post('/Account/Logout', this.parsArgs('access_token', arguments));
  }

I expected to recognize the access_token as a used and read variable
Something that actually goes
'access_token' is defined but never used.
Environment:
Windows 10 64bit
ESLint Version: 1.9.0
Node Version: 10.16.0
npm Version: 6.9.0

This repo is probably a wrong place for this issue. That said, eslint is working as intended in that code snippet because access_token is unused.

I agree with @golopot. Closing the issue.


annotation with redirecting const factory compiled with fasta not compatible with dart2js.

I am on f6242cb100125ce2fb71627401f91c8054b2be25 linux.
I have this program:
class P {
  final List l;
  const factory P(List l) = P._;
  const P._(this.l);
}

@P([P([])])
class C {}

const A = P([P([])]);

void main() {
  print(new C());
}

I can compile this program with:
$ $DART_SDK_CHECKOUT/out/ReleaseX64/dart-sdk/bin/dart2js bin/test.dart  -o out.js

But if I first compile with fasta, and try to run dart2js on the resulting dill file gives an error:
$ $DART_SDK_CHECKOUT/pkg/front_end/tool/fasta compile -o out.dill --target=dart2js --platform=$DART_SDK_CHECKOUT/tools/sdks/dart-sdk/lib/_internal/dart2js_platform_strong.dill bin/test.dart

$ $DART_SDK_CHECKOUT/out/ReleaseX64/dart-sdk/bin/dart2js out.dill  -o out.js
bin/test.dart:8:5:
Error: Not a compile-time constant.
@P([P([])])

In the .dill file we've inserted new P._ for the redirecting factory in the annotation (compared to const P._ in the constant declaration):
@self::P::_(const <dynamic>[new self::P::_(const <dynamic>[])])
class C extends core::Object {
  synthetic constructor •() → void
    : super core::Object::•()
    ;
}
static const field dynamic A = const self::P::_(const <dynamic>[const self::P::_(const <dynamic>[])]);

This pattern occurs in google3 targets using angular.
I'm working on a kernel transform, and want to test the transform using dart2js.


Feature/mtsdk 34 disable bitcode

Disabling bitcode in the xcframework build artifacts.
Xcode 14 was officially released and brought with it a deprecation for supporting bitcode: https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes

Starting with Xcode 14, bitcode is no longer required for watchOS and tvOS applications, and the App Store no longer accepts bitcode submissions from Xcode 14.
Xcode no longer builds bitcode by default and generates a warning message if a project explicitly enables bitcode: “Building with bitcode is deprecated. Please update your project and/or target settings to disable bitcode.” The capability to build with bitcode will be removed in a future Xcode release. IPAs that contain bitcode will have the bitcode stripped before being submitted to the App Store. Debug symbols for past bitcode submissions remain available for download. (86118779)

Jenkins seems happy