10678 DEV remove moveToGrisham route references from admiral

https://github.com/Shippable/pm/issues/10678

this is done, closing.


Feature/upmcfhir 240 composition resource identity enhancement

What does this PR do?
Updates Resource.composition.identifier to include assigner reference and a default "use" set to official and adds tests for the ClinicalDocument->composition transformation.
Related JIRA tickets:
UPMCFHIR-240
UPMCFHIR-215
How should this be manually tested?
Background/Context:
New JIRA tickets for clinical review required?

Looks like this if failing tests. Fixing soon.


Access to Octopus Home Mini

I am trying to setup the Octopus Energy - Home Assistant integration.  I have a Octopous Home Mini.  In the integration configuration as I read it I need to provide details of the Octopous Home Mini URL and API key.
The configuration guide:
https://bottlecapdave.github.io/HomeAssistant-OctopusEnergy/setup/account/
Points me to this guide for making SSH connection to Octopous Home Mini.
https://github.com/OctopusSmartEnergy/Home-Pro-SDK-Public/blob/main/Home.md#sdk
I checked in DHCP and found device name OCTO-CADLITE which has IP address of <IP_ADDRESS>
When I try to SSH as per document
ssh -p 8023 -o HostKeyAlgorithms=+ssh-rsa<EMAIL_ADDRESS>I get the error
ssh: connect to host <IP_ADDRESS> port 8023: Connection refused
Can you advise how can I connect via SSH?
It looks like since the integration was written the Octopous Home Mini has become more productised.  Once I can connect via SSH will the other steps to expose API work with  Octopous Home Mini ?

@darrylcauldwell this repo is for the octopus home pro, a different device to the home mini - no ssh available on the mini unfortunately.

That makes sense sorry for confusion sounds like I need to get myself a Home Pro.


Create unit test for tools/scheduler.go

The component of scheduler is not covered by unit test: https://github.com/rodrigo-brito/ninjabot/blob/main/tools/scheduler.go

@rodrigo-brito could I give this issue a try?

Sure, have fun!
Obter o Outlook para Androidhttps://aka.ms/AAb9ysg

From: Gavin Inglis @.>
Sent: Saturday, October 8, 2022 9:22:41 PM
To: rodrigo-brito/ninjabot @.>
Cc: Rodrigo Brito @.>; Mention @.>
Subject: Re: [rodrigo-brito/ninjabot] Create unit test for tools/scheduler.go (Issue #203)
@rodrigo-britohttps://github.com/rodrigo-brito could I give this issue a try?
—
Reply to this email directly, view it on GitHubhttps://github.com/rodrigo-brito/ninjabot/issues/203#issuecomment-1272419605, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB2ESU7K3W3UPNG6W6ESTADWCIF5BANCNFSM6AAAAAARANXOG4.
You are receiving this because you were mentioned.Message ID: @.***>


[Simple Bug] 'name' should be a variable

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

TensorFlow version 1.13
Python version: 3.6.8

Describe the current behavior
I want build two convLSTMCell and use them. like follow [Code to reproduce the issue]
tensorflow talk to me: ValueError: Variable kernel already exists, disallowed. Did you mean to set reuse=True or reuse=tf.AUTO_REUSE in VarScope? Originally defined at xxxx.
Describe the expected behavior
the code can run without error.
Code to reproduce the issue
import tensorflow as tf
import tensorflow.contrib.rnn as rnn
import numpy as np

npa = np.array([[[[1,2,3],[4,5,6],[4,5,6]],[[7,8,9],[10,11,12],[10,11,12]],[[13,14,15],[16,17,18],[16,17,18]]]])
print(npa.shape)
x = tf.constant(npa, dtype=tf.float32)
print(x)
# first cell
cell_encoder = rnn.Conv2DLSTMCell(input_shape=[x.shape[1], x.shape[2], x.shape[3]], output_channels=4,kernel_shape=[3, 3], name='encoder')
initial1 = cell_encoder.zero_state(batch_size=x.shape[0],dtype=tf.float32)
x1, fs1 = cell_encoder.call(inputs=x, state=initial1)
# second cell
cell_decoder = rnn.Conv2DLSTMCell(input_shape=[x.shape[1], x.shape[2], x.shape[3]], output_channels=4, kernel_shape=[3, 3], name='decoder')
initial2 = cell_decoder.zero_state(batch_size=x.shape[0], dtype=tf.float32)
x2, fs2 = cell_decoder.call(inputs=x, state=initial2)

with tf.Session() as sess:
    sess.run(tf.global_variables_initializer())
    x = sess.run(x2)
    print(x)

[minimal standalone code ]
Other info / logs
When system execution [cell_decoder.call],  tensorflow talk to me: ValueError: Variable kernel already exists, disallowed. Did you mean to set reuse=True or reuse=tf.AUTO_REUSE in VarScope? Originally defined at xxxx.
then ,i tack the code find tensorflow/contrib/rnn/python/ops/rnn_cell.py line: 2215 & 2228, vs.get_variable function name of the function should be a variable, not a constant.
the issue is simple. If the name  is a constant, the second cell, cell_decoder, will use the same one variable.
Thanks to tensorflow for providing AI open source framework.  O(∩_∩)O

Looks like code is incomplete. In order to expedite the trouble-shooting process, please provide a minimal standalone code to reproduce the issue reported here. Thanks!

Please use triple backticks before and after the code to make it easier to read. Every textbox on GitHub has a small M and a down arrow just above the Comment/Submit/etc. green button. Clicking on it will give you a tutorial on how to properly use Markdown. Please use it properly so issues can be analyzed faster

Looks like code is incomplete. In order to expedite the trouble-shooting process, please provide a minimal standalone code to reproduce the issue reported here. Thanks!

i’m change the [Code to reproduce the issue]~

@walty19950301
Any update please. Thanks!

I have tried on colab with TF version 1.13, 1.15 and was able to reproduce the issue.Please, find the gist here. Thanks!

I have tried on colab with TF version 1.13, 1.15 and was able to reproduce the issue.Please, find the gist here. Thanks!

There is the key of the issue.  Every rnn.Conv2DLSTMCell will call same one vs.get_variable. (Conv2DLSTMCell call call, call call _conv, _conv call vs.get_variable)
/usr/local/lib/python3.6/dist-packages/tensorflow_core/contrib/rnn/python/ops/rnn_cell.py in _conv(args, filter_size, num_features, bias, bias_start)
   2228   # Now the computation.
   2229   kernel = vs.get_variable(
-> 2230       "kernel", filter_size + [total_arg_size_depth, num_features], dtype=dtype)
   2231   if len(args) == 1:
   2232     res = conv_op(args[0], kernel, strides, padding="SAME")

I use twice rnn.Conv2DLSTMCell. The first cell is right without error, but the second is error. The reason is that name of vs.get_variable is a constent. The first cell gets the 'kernel' variable, and the second cell should  get a new variable which not same with the 'kernel' varibale.
I think the _conv function should be modified as follow: (the wrong code is commented out by # )
def _conv(args, filter_size, num_features, bias, bias_start=0.0, name='_conv'):
  """Convolution.

  Args:
    args: a Tensor or a list of Tensors of dimension 3D, 4D or 5D,
    batch x n, Tensors.
    filter_size: int tuple of filter height and width.
    num_features: int, number of features.
    bias: Whether to use biases in the convolution layer.
    bias_start: starting value to initialize the bias; 0 by default.

  Returns:
    A 3D, 4D, or 5D Tensor with shape [batch ... num_features]

  Raises:
    ValueError: if some of the arguments has unspecified or wrong shape.
  """

  # Calculate the total size of arguments on dimension 1.
  total_arg_size_depth = 0
  shapes = [a.get_shape().as_list() for a in args]
  shape_length = len(shapes[0])
  for shape in shapes:
    if len(shape) not in [3, 4, 5]:
      raise ValueError("Conv Linear expects 3D, 4D "
                       "or 5D arguments: %s" % str(shapes))
    if len(shape) != len(shapes[0]):
      raise ValueError("Conv Linear expects all args "
                       "to be of same Dimension: %s" % str(shapes))
    else:
      total_arg_size_depth += shape[-1]
  dtype = [a.dtype for a in args][0]

  # determine correct conv operation
  if shape_length == 3:
    conv_op = nn_ops.conv1d
    strides = 1
  elif shape_length == 4:
    conv_op = nn_ops.conv2d
    strides = shape_length * [1]
  elif shape_length == 5:
    conv_op = nn_ops.conv3d
    strides = shape_length * [1]

  # Now the computation.
  # kernel = vs.get_variable(
  #     "kernel", filter_size + [total_arg_size_depth, num_features], dtype=dtype)
  kernel = vs.get_variable(
    name + "_kernel", filter_size + [total_arg_size_depth, num_features], dtype=dtype)
  if len(args) == 1:
    res = conv_op(args[0], kernel, strides, padding="SAME")
  else:
    res = conv_op(
        array_ops.concat(axis=shape_length - 1, values=args),
        kernel,
        strides,
        padding="SAME")
  if not bias:
    return res
  # bias_term = vs.get_variable(
  #     "biases", [num_features],
  #     dtype=dtype,
  #     initializer=init_ops.constant_initializer(bias_start, dtype=dtype))
  bias_term = vs.get_variable(
    name + "_biases", [num_features],
   dtype=dtype,
  initializer=init_ops.constant_initializer(bias_start, dtype=dtype))
  return res + bias_term

Contrib is being depricated @walty19950301 Can you please repeat this with TF 2.0 and see if the issue still persists?

Hi There,
We are checking to see if you still need help on this, as you are using an older version of tensorflow which is officially considered end of life . We recommend that you upgrade to the latest 2.x version and let us know if the issue still persists in newer versions. Please open a new issue for any help you need against 2.x, and we will get you the right help.
This issue will be closed automatically 7 days from now. If you still need help with this issue, please provide us with more information.


store certificates in OS certificate store or keychain rather than filesystem

certificatres are stored on disk. keys are stored in keychain. released in <IP_ADDRESS>. doc forthcoming


unable to get ctrl-P (ctrl-p works)

Hi,
I am not sure if I am doing something wrong, or is it a bug. I attach minimal project:
https://github.com/njskalski/bug-report-1
just run it, and try pressing shift-ctrl-p (ctrl-P). I get only ctrl-p for both with and without shift.
Kindest Regards
NJ

Hmm... and is there a way to see if shift is pressed?

No, the terminal doesn't send this info to the application. :( This is another case where we're still stuck with standards decades old...

TLDR: I know of no way to distinguish Ctrl+Shift+P from Ctrl+P in a terminal application. If you know of a way, or of an application that can do that, feel free to re-open and I'll gladly investigate.


release: v1.2.3

[v1.2.3] (Mar 4 2024)
Chore:

Injected chat-ai-widget-key key-value pair into the user agent parameter during build time.

/bot create ticket

[Creating Ticket] 🔖 Done https://sendbird.atlassian.net/browse/SDKRLSD-1150


action button slot

Can we add a slot for action button ?
That way we can add many action button

find the solution 👍
https://github.com/rubanraj54/vue-bootstrap4-table/issues/46


set logs to JSON add APM

you're right
On Thu, Nov 18, 2021 at 9:06 PM Asaf Cohen @.***> wrote:

@.**** commented on this pull request.
@obsd https://github.com/obsd i will review this but all the
opal-client code needs to move to our sidecar (commercial offering, we
don't want to put monitoring in the open source).
regarding opal-server, we will have to do a custom build or gate with
environment variables somehow.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/authorizon/opal/pull/182#pullrequestreview-810342293,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALIJQQGI6CO46TPEZDTDODUMVFBTANCNFSM5IKLQUDQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Feature request: Support for Azure SSO?

I see that Trotto only currently supports Google login - is there any chance of support for Microsoft's Azure SSO? (or at least some pointers on how to add it?)

Hey @itsojon would you accept this feature as a PR? do you have any pointers or preferences on how I would implement it?


Google Colab + Python Interface - ImportError: Cannot load backend 'TkAgg' which requires the 'tk'

I have installed the latest version of Ludwig from the master branch (!pip install https://github.com/uber/ludwig/archive/master.zip). But when I try to import ludwig from LudwigModel (from ludwig import LudwigModel), I still get the import error (ImportError: Cannot load backend 'TkAgg' which requires the 'tk' interactive framework, as 'headless' is currently running).
There is no error when I use the CLI
--
ImportError                               Traceback (most recent call last)
 in ()
----> 1 from ludwig import LudwigModel
/usr/local/lib/python3.6/dist-packages/ludwig/init.py in ()
15 # ==============================================================================
16 from ludwig.api import LudwigModel
---> 17 from ludwig.cli import CLI
18 from ludwig.globals import LUDWIG_VERSION as version
/usr/local/lib/python3.6/dist-packages/ludwig/cli.py in ()
22 from ludwig import predict
23 from ludwig import train
---> 24 from ludwig import visualize
25
26
/usr/local/lib/python3.6/dist-packages/ludwig/visualize.py in ()
30
31 from ludwig.constants import *
---> 32 from ludwig.utils import visualization_utils
33 from ludwig.utils.data_utils import load_json, load_from_file
34 from ludwig.utils.print_utils import logging_level_registry
/usr/local/lib/python3.6/dist-packages/ludwig/utils/visualization_utils.py in ()
26 from matplotlib.lines import Line2D
27
---> 28 mpl.use('TkAgg')  # make matplotlib run on mac os
29 import matplotlib.patches as patches
30 import matplotlib.path as path
/usr/local/lib/python3.6/dist-packages/matplotlib/init.py in use(arg, warn, force)
1389         if force:
1390             from matplotlib.pyplot import switch_backend
-> 1391             switch_backend(name)
1392     # Finally if pyplot is not imported update both rcParams and
1393     # rcDefaults so restoring the defaults later with rcdefaults
/usr/local/lib/python3.6/dist-packages/matplotlib/pyplot.py in switch_backend(newbackend)
220                 "Cannot load backend {!r} which requires the {!r} interactive "
221                 "framework, as {!r} is currently running".format(
--> 222                     newbackend, required_framework, current_framework))
223
224     rcParams['backend'] = rcParamsDefault['backend'] = newbackend
ImportError: Cannot load backend 'TkAgg' which requires the 'tk' interactive framework, as 'headless' is currently running

NOTE: If your import is failing due to a missing package, you can
manually install dependencies using either !pip or !apt.
To view examples of installing some common dependencies, click the
"Open Examples" button below.

I'm having the same experience.
I installed the latest Ludwig version in Colab using
!pip install https://github.com/uber/ludwig/archive/master.zip
and I still get the following error
`---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
 in ()
----> 1 from ludwig import LudwigModel
2
3 # train a model
4 model_definition = {input_features: [{name: 'acoustic_data', type: numerical}], output_features: [{name: 'time_to_failure', type: numerical}]}
5
/usr/local/lib/python3.6/dist-packages/ludwig/init.py in ()
15 # ==============================================================================
16 from ludwig.api import LudwigModel
---> 17 from ludwig.cli import CLI
18 from ludwig.globals import LUDWIG_VERSION as version
/usr/local/lib/python3.6/dist-packages/ludwig/cli.py in ()
22 from ludwig import predict
23 from ludwig import train
---> 24 from ludwig import visualize
25
26
/usr/local/lib/python3.6/dist-packages/ludwig/visualize.py in ()
30
31 from ludwig.constants import *
---> 32 from ludwig.utils import visualization_utils
33 from ludwig.utils.data_utils import load_json, load_from_file
34 from ludwig.utils.print_utils import logging_level_registry
/usr/local/lib/python3.6/dist-packages/ludwig/utils/visualization_utils.py in ()
26 from matplotlib.lines import Line2D
27
---> 28 mpl.use('TkAgg')  # make matplotlib run on mac os
29 import matplotlib.patches as patches
30 import matplotlib.path as path
/usr/local/lib/python3.6/dist-packages/matplotlib/init.py in use(arg, warn, force)
1389         if force:
1390             from matplotlib.pyplot import switch_backend
-> 1391             switch_backend(name)
1392     # Finally if pyplot is not imported update both rcParams and
1393     # rcDefaults so restoring the defaults later with rcdefaults
/usr/local/lib/python3.6/dist-packages/matplotlib/pyplot.py in switch_backend(newbackend)
220                 "Cannot load backend {!r} which requires the {!r} interactive "
221                 "framework, as {!r} is currently running".format(
--> 222                     newbackend, required_framework, current_framework))
223
224     rcParams['backend'] = rcParamsDefault['backend'] = newbackend
ImportError: Cannot load backend 'TkAgg' which requires the 'tk' interactive framework, as 'headless' is currently running

NOTE: If your import is failing due to a missing package, you can
manually install dependencies using either !pip or !apt.
To view examples of installing some common dependencies, click the
"Open Examples" button below.
---------------------------------------------------------------------------`

Please use the latest code in master, it should solve the issue.

@w4nderlust The issue is resolved. I don't see any error when I import Ludwig model. Maybe it was the cached file.
FYI, when I run "from sys import platform; print(platform)" - I get "linux".

Since I don't see the error, I am closing the issue.

Please use the latest code in master, it should solve the issue. The reason is that you report
27
---> 28 mpl.use('TkAgg') # make matplotlib run on mac os

But if you look at line 27 and 28 in master they look like this: https://github.com/uber/ludwig/blob/master/ludwig/utils/visualization_utils.py#L27
The missing if makes me thing that you are not actually using the code on master. Not sure why, maybe the zip is cached?
Plus, could you please run from sys import platform; print(platform) inside colab and thell me what do you get?
I have the same error in colab

I have the same error in colab

Please provide a link to the colab to reproduce the issue.

https://colab.research.google.com/drive/14f5gmYx8WudZXFHS5RCyogmmVqUhdCrb#scrollTo=7IZTvyEQv7uq&line=1&uniqifier=1
This link is useful?

https://colab.research.google.com/drive/14f5gmYx8WudZXFHS5RCyogmmVqUhdCrb#scrollTo=7IZTvyEQv7uq&line=1&uniqifier=1
This link is useful?

It isn't accessible.


Implement Request credentials

#357 Implements fetch request credentials

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: aguacongas sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for contributing this, @aguacongas! I appreciate the thorough PR with tests.
On consideration, I think I would propose a slightly different way to implement this feature. My concern about the approach here is that it's very specialised:

It only covers the case where you're calling one of the *JsonAsync methods, and not if you're calling say GetStringAsync or just SendAsync
It only covers setting the credentials arg on fetch, and only to a set of predefined values. It's likely that people will want to configure other aspects of fetch too, which would end up creating an explosion of method overload combinations on the *JsonAsync methods.

If I'm understanding the design of HttpClient correctly, it appears that HttpRequestMessage.Properties is designed as an arbitrary bag of additional HttpMessageHandler-specific metadata. As such the approach I'd prefer would be:

Declare some static readonly string on BrowserHttpMessageHandler such as public readonly static string FetchArgs = "BrowserHttpMessageHandler.FetchArgs";
Update the interop code so that BrowserHttpMessageHandler supplies the value request.Properties[FetchArgs] to the JS-side code
Update the JS-side code so that if the supplied "fetchArgs" value is nonnull, its properties are all added to the options object passed when we call fetch

Then, developers can construct a HttpRequestMessage and set:
myMessage.Properties[BrowserHttpMessageHandler.FetchArgs] = new
{
    credentials = "include",
    anyOtherJsProperty = new { myValue = 123 }
};

... and then the JS-side code will call:
fetch(url, { ... existing args ..., credentials: 'include', anyOtherJsProperty: { myValue: 123 } })...

... which allows a way to control all aspects of fetch, including future APIs that we don't even know about yet. It also avoids any arbitrary distinction between *JsonAsync and the regular *Async methods on HttpClient.
Drawback: I know this means you'd need to call SendAsync and do your own JSON-serialization, but I don't know of a way to avoid that while remaining consistent with the broader design of HttpClient. Developers who commonly need to specify particular custom arguments with their HTTP calls can create their own wrapper around SendAsync that takes whatever custom arguments (e.g., Credentials) that they need. We can't really put credentials directly onto GetJsonAsync in the core library here for the reasons described above, i.e., it's not consistent with HttpClient design and wouldn't scale to other flags and options that you might want to pass through to fetch.
What do you think?

Hi Steve,
It's look really better actualy, I agree. Can I implement it ?

@aguacongas
Re const vs static - either is fine here really.

And does it means the user cannot use GetJsonAsync methods if it need to use some fetch options then

In the general case, it means the user needs to construct a HttpRequestMessage and pass it to SendAsync. This allows for any HTTP method, any combination of headers, any payload (JSON or otherwise), etc.
I know there will be times where it's not as convenient as using a higher-level method like GetJsonAsync but as mentioned above, developers can create their own wrapper methods around this if they have specific needs (such as setting the credentials option, or integrity, or anything else).
Basically this is a relatively safe low-level design (not going to trap us in the future) that others can build higher-level methods on top of.

@SteveSandersonMS
I uptated according to the discussion. I didn't update the test layout but if works for one options it should for others.


CompetitiveIterator should be null if sort field does not exist in TermOrdValComparator

If sort field not in FieldInfo(eg. search sort field does not exist), it seems like we should disable Skipping, avoid intersecting termOrdValComparator's CompetitiveIterator

I wonder if this is true, wouldn't skipping also happen if a field doesn't exist? For instance if collecting 10 top hits, I would expect the collector to collect the first 10 hits produced by the query, and then the competitive iterator would skip every other hit since they cannot possibly be more competitive? It would be a shame to collect the whole segment while documents beyond the 10th hit cannot possibly be competitive?

I wonder if this is true, wouldn't skipping also happen if a field doesn't exist?

Yes, it won't do skipping. my curiosity was if search sort field does not exist, competitive iterator would be null and  would not in conjunction with query's iterator in NumericComparator but TermOrdValComparator will, should they keep the same logic?
Another question which not unrelated with this issue:

For instance if collecting 10 top hits, I would expect the collector to collect the first 10 hits produced by the query, and then the competitive iterator would skip every other hit since they cannot possibly be more competitive

Yes, in a single search sort field(which is not exist) case, It is indeed that every other hit since they cannot possibly be more competitive, but it would still collect all docs because there were as a missing value.  in this specific case, could we do some optimization(or maybe there is already some configuration could make it) and see it as an non-search-sort-field case, then such case could get an early terminate collection.

I wonder if this is true, wouldn't skipping also happen if a field doesn't exist?

Yes, it won't do skipping. my curiosity was if search sort field does not exist, competitive iterator would be null and would not in conjunction with query's iterator in NumericComparator but TermOrdValComparator will, should they keep the same logic?
Hi, @jpountz, another question which not unrelated with this issue:

For instance if collecting 10 top hits, I would expect the collector to collect the first 10 hits produced by the query, and then the competitive iterator would skip every other hit since they cannot possibly be more competitive

Yes, in a single search sort field(which is not exist) case, It is indeed that every other hit since they cannot possibly be more competitive, but it would still collect all docs because there were as a missing value. in this specific case, could we do some optimization(or maybe there is already some configuration could make it) and see it as a non-search-sort-field case, then such case could get an early terminate collection?

I'm a bit confused, I think it would help me if you could create a small test case when the behavior on missing sort fields doesn't match your expectations?

  public void test111() throws IOException{

    Directory dir = newDirectory();
    IndexWriterConfig iwc = new IndexWriterConfig(new MockAnalyzer(random()));
    RandomIndexWriter indexWriter = new RandomIndexWriter(random(), dir, iwc);
    Document doc;
    Random random = new Random();
    int count = 0;
    while (count++ < 100000){
      doc = new Document();
      doc.add(new SortedSetDocValuesField("sortedSet", new BytesRef("a")));
      doc.add(new StringField("name", String.valueOf(random.nextInt(1000000)), StringField.Store.YES));
      indexWriter.addDocument(doc);
    }
    indexWriter.commit();

    IndexReader reader = indexWriter.getReader();
    IndexSearcher searcher = newSearcher(reader);

    assert reader.maxDoc() == 100000;
    Query query = new MatchAllDocsQuery();
    Sort sort = new Sort(new SortedSetSortField("field no exist ", false));

    TopDocs noSearchField = searcher.search(query, 2000);
    assert noSearchField.totalHits.value == 2001;

    TopDocs hasSearchField = searcher.search(query, 2000, sort);
    // if the search sort field is not exist,  should early terminate after Top 2000 collected?
    assert hasSearchField.totalHits.value == 100000;

    indexWriter.close();
    reader.close();
    dir.close();

  }

If search sort field does not exist, should we early terminate collection after TopN collected?

I agree that we should fix this comparator so that the last call to IndexSearcher.search in your test only collects 2000 hits. This doesn't seem to be what your PR does though?

This doesn't seem to be what your PR does though?

It indeed has no relation to this PR》

If search sort field does not exist, should we early terminate collection after TopN collected?

I would like to open an issue for this.

+1


Update font-libertinus to 6.4

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as f327eb26c758764725971ce30b16626dace510a1. Your contribution is still credited to you.


Using the WYSIWYG editor on mobile causes consistent jump to top behaviour

Describe the bug
On mobile (Android Firefox) when typing in the WYSIWYG editor it jumps to the top of the editor (See video).
The scroll position is adjusted when the editor gains focus.
To Reproduce
Steps to reproduce the behavior:

Open the SSE on Android in Firefox.
Focus at a section in the editor lower down on the page
The keyboard opens and the editor scrolls to the top

Expected behavior
When typing in the WYSIWYG editor, the cursor should keep its position and the cursor position should not scroll out of view.
Preview

Smartphone (please complete the following information):

Device: N/A
OS: Android
Browser: Firefox
Version: 68.10.1

Additional context
Link for replicating the bug: https://ndu68.csb.app/
No further investigation has been done but I have a hunch that this bug might be caused bu the way ToastUI determines the cursorHeight and editorHeight in the scrollIntoCursor() function when the keyboard is open.

Yes! In android, the editor jump to top. While in IOS, the editor fail to show the cursor. Do you have any measure to solve it?

Yes! In android, the editor jump to top. While in IOS, the editor fail to show the cursor. Do you have any measure to solve it?


feat: store initial timeline in env fixture

really minor change, but will allow more use in future for the default tenants.
separated from #3809, and separate from rewriting all the single tenant tests to use these values instead..

In case anyone goes to look how is this used in #3809, don't waste your time, it is used, but very slightly and indirectly. I was initially thinking of using it more as one of the tenants I create, but it wasn't necessary because I added testing_api!(PUT /v1/:tenant_id/broken) to break a tenant which is also useful in our test.
I don't think we are in a hurry to merge this, but it should go in before #3809. I'll leave it open for now to raise awareness.

(it's FAILED test_runner/regress/test_compatibility.py::test_forward_compatibility@compatibility, will retry)


SameSize-Lax -> SameSite=Lax

I believe this is a typo? Great tutorial :D though not very consistent code style 😅
Thanks for writing it!!!

though not very consistent code style

would love to hear more about how we could improve this in the future 👍


Handle template variables better.

[x] PyMdown does not need to special format meta data anymore, it should be passed to the template so they can do whatever they want with it.
[x] Frontmatter data etc. should all be sent to the template under an appropriate namespace.
[x] Maybe settings content will be passed to template.
[x] Allow custom template variables in settings file.
[ ] Update docs

Some more changes may still take place.  Still trying to figure out what I ultimately want, but the template variables feel much better now.


In-game names for visors

The in-game name for visors are now displayed in the editor
Now only hats are left

Will pull when hats


[ENHANCEMENT] Add application on F-Droid

Hello,
In the scope of releasing the application in a full open-source environment, is it plan to release the app on the F-Droid alternative store ? https://f-droid.org/

Look cool

If you need some help, I think @IzzySoft can help you :)

Quick hints:

establish Fastlane structures here in your repo (minimum: short_description.txt & full_description.txt for en-US; strongly recommended: also screenshots; recommended: also icon + featureGraphic; nice: also per-release changelogs and multiple languages)
optionally ask me to cross-check the structure
have a new tag with Fastlane inside
open a RFP (Request For Packaging) with F-Droid
we pick up from there :smiley:

I came here to suggest this! Would really like to see this feature or contribute if I can.

Can I sign the f-droid APK with my signature?

Not directly. But what you're probably looking for is a dual-signed APK (carrying yours and F-Droids signature). Look for reproducible builds.

Any blockers that I can help with or things that need to still be completed?

Any blockers that I can help with or things that need to still be completed?

It just takes time. If anyone wants to do this, I'll help!

I have opened a PR to start the metadata needed, you will still need to release this app with a new tag, and hopefully add changelog and other stuff like donation info and website to the RFP at FDroid.

Some issues where flagged here, https://gitlab.com/fdroid/rfp/-/issues/2187 mainly insecure Gradle configuration.

Can we reopen this until it's included?

https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11685  for tracking and help.

How can help get this through?

I guess it's up to @BoBeR182 currently to accept the suggested changes in the MR.

Merged the changed and bumped the version to 1.2.2 (599) same one as on the Google Play store.
Looks like there is still some errors with Gradle build process, see the following job for all the errors https://gitlab.com/BoBeR182/fdroiddata/-/jobs/3221672445

There are a lot of scanner errors in that log. Examples (bottom-up):
ERROR: Found Java JAR file at build-logic/plugins/convention/build/libs/convention.jar
ERROR: Found Java compiled class at build-logic/plugins/convention/build/classes/kotlin/main/com/flipperdevices/buildlogic/ApkConfig.class

I guess someone accidentally checked in build artifacts. In that case, I'd suggest to remove them again (ideally pruning, but for the build deleting would suffice). If those structures are there on purpose, the question is whether the F-Droid build would succeed if they were not there – in which case a scandelete or rm entry could be made in the build block, here for build-logic/plugins/convention/build. That would then avoid those errors, and the build would continue; it aborted due to the scanner ERRORs:
ERROR: Could not build app com.flipperdevices.app: Can't build due to 1128 errors while scanning

@IzzySoft any ideas on this one, https://gitlab.com/BoBeR182/fdroiddata/-/jobs/3221854075
You last recommendation helped.

Yeah, looks much better already – and the build actually started :smiley:

Gradle build daemon disappeared unexpectedly (it may have been killed or may have crashed)

I'd say retry. If the error remains, being no Android dev I've no clue, sorry.

It's very strange that it takes 40 minutes to assemble. Even on free githab runners, a clean project takes about 10 minutes to build.
Have you tried disabling the demon?
What command is executed on the server? It now builds everything (even the wearos version). Can you tell it to only build the application (:instances:app:)?
I also think i should attach a link to GitHub Workflow: https://github.com/flipperdevices/Flipper-Android-App/blob/dev/.github/workflows/internal.yml#L54

I would also like to say a big thank you to @BoBeR182 for doing this. And to other contributors

Seems the compiled APK won't install on my phone, can you help debug?
https://gitlab.com/fdroid/fdroiddata/uploads/2e1c4f5ae9c82e1a917a0bb38d66406e/com.flipperdevices.app_599.apk.gz
https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11685#note_1149898055

@BoBeR182 have you signed it? The CI spits out an unsigned APK.

I assumed a rooted phone can just install unsigned APKs, I will learn how to self sign and try again.

I assumed a rooted phone can just install unsigned APKs

To my experience not. Most of my devices are rooted, and a simple adb install using an unsigned APK always failed (complaining of missing certs).

Are reproducible builds possible? Or should we move ahead here? This is above my experience level.
https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11685#note_1171890546

Reproducible builds are not a requirement – while definitely something good to aim for. If it's above your experience, feel free to skip it for now and postpone it (especially if it would keep you from "going live" for an indefinite time). You can always add that later when you feel ready.

https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11685 is merged, I think we can close this, it should be showing up in the repos soon. There might be work needed to integrate updated changelogs, or other metadata.

Why is there no app icon in f-droid?

Nice, the app is finally available on the F-Droid store (with the app icon for me) ! 🥳🥳
But the application crash when I try to open it for some reason... :/ @LionZXY Do you want to keep tracking that wrong build here or in another issue ? 🤔

It's funny - it turns out no one has tested the version. No DSN for Sentry, I will add to upstream now

Process: com.flipperdevices.app, PID: 23835
                                                java.lang.RuntimeException: Unable to get provider io.sentry.android.core.SentryInitProvider: java.lang.IllegalArgumentException: DSN is required. Use empty string to disable SDK.
                                                	at android.app.ActivityThread.installProvider(ActivityThread.java:7493)
                                                	at android.app.ActivityThread.installContentProviders(ActivityThread.java:6999)
                                                	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6770)
                                                	at android.app.ActivityThread.-$$Nest$mhandleBindApplication(Unknown Source:0)
                                                	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2134)
                                                	at android.os.Handler.dispatchMessage(Handler.java:106)
                                                	at android.os.Looper.loopOnce(Looper.java:201)
                                                	at android.os.Looper.loop(Looper.java:288)
                                                	at android.app.ActivityThread.main(ActivityThread.java:7898)
                                                	at java.lang.reflect.Method.invoke(Native Method)
                                                	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                                                	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
                                                Caused by: java.lang.IllegalArgumentException: DSN is required. Use empty string to disable SDK.
                                                	at ko.n1.d(Sentry.java:824)
                                                	at ko.n1.c(Sentry.java:49)
                                                	at io.sentry.android.core.SentryInitProvider.onCreate(SentryInitProvider.java:113)
                                                	at android.content.ContentProvider.attachInfo(ContentProvider.java:2451)
                                                	at android.content.ContentProvider.attachInfo(ContentProvider.java:2421)
                                                	at io.sentry.android.core.SentryInitProvider.attachInfo(SentryInitProvider.java:15)
                                                	at android.app.ActivityThread.installProvider(ActivityThread.java:7488)
                                                	at android.app.ActivityThread.installContentProviders(ActivityThread.java:6999)
                                                	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6770)
                                                	at android.app.ActivityThread.-$$Nest$mhandleBindApplication(Unknown Source:0)
                                                	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2134)
                                                	at android.os.Handler.dispatchMessage(Handler.java:106)
                                                	at android.os.Looper.loopOnce(Looper.java:201)
                                                	at android.os.Looper.loop(Looper.java:288)
                                                	at android.app.ActivityThread.main(ActivityThread.java:7898)
                                                	at java.lang.reflect.Method.invoke(Native Method)
                                                	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                                                	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

What do I have to do to update the version in the F-Droid?
@IzzySoft

@LionZXY we usually set up apps for auto-update. So tagging a new release should be sufficient. Should the update not turn up a few days later, check back with us. Even better, a few hours after tagging follow the build monitor, where it eventually should show up.

Happy to see this app on F-Droid! However, is there a chance to get rid of this?
This app tracks and reports your activity

By removing Sentry (or making it strictly opt-in) I guess? See the above linked MR.

I am going to add toggle for disabling analytics for FDroid users

Great, thanks! To have the anti-feature removed it must be gone entirely or default to "off", though (see above: removing, or strictly opt-in).


ENH: add Euclidean Minimum Spanning Tree

Is your feature request related to a problem? Please describe.
Euclidean Minimum Spanning Tree (EMST) is a minimum spanning tree of a set of n points in the plane or higher-dimensional Euclidean space (the weight of an edge between any pair of points is the Euclidean distance between two points).
This problem can be solved by constructing a matrix of pairwise distances followed by the minimum spanning tree algorithm (e.g. Borůvka's algorithm, Prim's algorithm, Kruskal's algorithm). But this is a very inefficient solution, as it requires O(n^2) time and space.
An efficient solution (at least on the plane) uses the Delaunay triangulation followed by the minimum spanning tree algorithm. This solution requires O(n*log(n)) time and O(n) space.
Describe the solution you'd like.
Proposed solution uses Delaunay triangulation for efficient finding Euclidean Minimum Spanning Tree.
import numpy as np

n_samples = 100
n_dim = 2

# uniform distribution
X = np.random.rand(n_samples, n_dim)
mst_pairwise = euclidean_minimum_spanning_tree(X, method="pairwise")
mst_delaunay = euclidean_minimum_spanning_tree(X, method="delaunay")
np.allclose(mst_pairwise.toarray(), mst_delaunay.toarray())  # True

# normal distribution
X = np.random.randn(n_samples, n_dim)
mst_pairwise = euclidean_minimum_spanning_tree(X, method="pairwise")
mst_delaunay = euclidean_minimum_spanning_tree(X, method="delaunay")
np.allclose(mst_pairwise.toarray(), mst_delaunay.toarray())  # True

Describe alternatives you've considered.
No response
Additional context (e.g. screenshots, GIFs)
No response

Thanks @dayyass for the proposal (and PR). The way I understand this is that it's a different method to get the MST, correct? So for trivial cases it should produce the same solution.
If this is the case: the lower complexity would be a good thing. In terms of implementation, MST is in Cython and we could add a method parameter. Then we would have a factory in the main function pointing to the different Cython methods.

Thanks @dayyass for the proposal (and PR). The way I understand this is that it's a different method to get the MST, correct? So for trivial cases it should produce the same solution.
If this is the case: the lower complexity would be a good thing. In terms of implementation, MST is in Cython and we could add a method parameter. Then we would have a factory in the main function pointing to the different Cython methods.

EMST is not a different method to get the MST, but a different MST, where distances between graph nodes (points in Euclidean space) are Euclidean distances between these points. More correctly it is MST for graph of Euclidean distances between nodes.
And for such EMST there is exist more efficient method comparing with straightforward solution (complete graph of distances + MST) using Delaunay triangulation.

Just to chime in (hopefully not too noisy)... I would appreciate having an efficient implementation of EMST in SciPy!  (I arrived at this thread while searching for one.)

I started reviewing a draft implementation at https://github.com/scipy/scipy/pull/14996 years ago, I could try to revive that a bit perhaps.

I started reviewing a draft implementation at #14996 years ago, I could try to revive that a bit perhaps.

Yes, it would be great


Add extension ZIP cache directories to type roots

As an extension developer, I want to be able to reference types from other extensions when I'm writing code that depends on those extensions.
Extension ZIP files are decompressed by the extension service so they can be loaded and executed at runtime.  We would also like to use those decompressed d.ts files inside of VS Code when developing other extensions so we can use their types.

We should also think of a way to better support sharing types between extensions you're developing. Getting types from the cache would allow development off of other published extensions, but we don't have a clear way of doing that with in-development extensions right now. We might just have to teach people how to point typeRoots to the appropriate directory...
For an extension you're working on that already has a published version installed, Maybe we could detect when an extension is provided by a directory (instead of a zip) and delete the unzipped files in the cache.

Turns out that typeRoots takes the first module definition it finds and ignores subsequent ones in order of its entries. Amazing! This means we can order typeRoots appropriately with the cache at the very end and other things before it and not have to worry about deleting cached stuff and whatnot.
Unfortunately, I discovered a few problems along the way:

Using the existing cache/extensions folder doesn't work because TypeScript considers the folder name to be the module name, and all those folder names have a version number on them. Generally, the folder name for the extension doesn't technically have to match the extension name anyway. So I ended up making a cache/extension-types folder that contains folders that contain the types files.

Each folder in cache/extension-types is the name of the extension's TypeScript module (which should match the extension's name - see below). Inside that folder is the extension's .d.ts folder renamed to index.d.ts because this is the only file structure that TypeScript liked using without significant work to adjust it.

I decided that, for consistency's sake, I'd assume the extension name is the module name in the extension's .d.ts file. I also assumed the extension's .d.ts file would be named <extension_name>.d.ts, <extension_name><other-stuff>.d.ts, or index.d.ts. We can add a types field to the manifest.json if we want, but it seemed not particularly necessary right now.


API audit

Overall, I suggest we remove "mercator" keyword from function names since the whole module is about mercator projection.

projectFlat
unprojectFlat
getMercatorMeterZoom -> getMeterZoom
getMercatorDistanceScales -> getDistanceScales
getMercatorWorldPosition -> getCenter
makeViewMatricesFromMercatorParams -> getViewMatrix (return single matrix instead of object)
makeUncenteredViewMatrixFromMercatorParams -> getUncenteredViewMatrix
makeProjectionMatrixFromMercatorParams -> getProjectionMatrix
getFov
getClippingPlanes
fitBounds

@ib

+1 to this, except I think the makeMakeViewMatrices was written that way to avoid double calculation of the matrix.
We could offer separate versions I suppose, but not sure it is worth the trouble to remove the combined one at this stage.

At the moment WebMercatorViewport in this module and deck.gl are the only users of these utils. I can confirm that there will be no double calculation if we remove the combined function.


docs: Reference TechBites videos pt.4

GitHub Issue (If applicable): internal 25, 30

PR Type
What kind of change does this PR introduce?

Documentation content changes

What is the current behavior?

What is the new behavior?

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tested code with current supported SDKs
[ ] Tested the changes where applicable:

[ ] UWP
[ ] WinUI
[ ] iOS
[ ] Android
[ ] WASM
[ ] MacOS

[ ] Updated the documentation as needed:

[ ] General Doc Update
[ ] Controls Doc Update
[ ] Extensions Doc Update
[ ] controls-styles.md
[ ] lightweight-styling.md (LightWeight Styling Resource Keys)

[ ] Runtime Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
[ ] Contains NO breaking changes
[ ] Associated with an issue (GitHub or internal)
[ ] Commits must be following the Conventional Commits specification.

Other information

Internal Issue (If applicable):

@Mergifyio backport release/stable/6.0


Unhandled promises in Topic.flush and PubSub.close prevent proper shutdown

Both methods Topic.flush and PubSub.close indicate that it is ok to call them with no parameter and await their completion. Unfortunately when passing no callback, the function internals don't properly await and instead have unhandled promises which can in certain cases lead to message not being sent correctly.
This could be a reason to the recently observed increase in Total timeout of API google.pubsub.v1.Publisher exceeded 60000 milliseconds before any response was received. errors on Google Cloud Functions and Cloud Run because those runtime instances assumingly switch to idle before all messages have been send.
Take a look at Topic.flush:
https://github.com/googleapis/nodejs-pubsub/blob/38fba8bb98636d21c1d2005be4352fb8190e1813/src/topic.ts#L193-L199
The call to this.publisher.flush(callback!); is not awaited nor returned so there is no way for the caller of Topic.flush to await the internal Promise completion without passing a callback.
Similar issue exists in PubSub.close.

After a little more inspection of the Topic.flush code path I think the problem with unhandled promises is actually more wide-spread. Take a look at the following line of code from Publisher.flush:
https://github.com/googleapis/nodejs-pubsub/blob/38fba8bb98636d21c1d2005be4352fb8190e1813/src/publisher/index.ts#L110-L124
In line 113 the internal Queue.publish method is called to publish the remaining messages. The callback from line 110 isn't passed down into Queue.publish. Instead Promise.all is used to wait for the queue to publish. But the Queue.publish method itself is void; it is not returning a Promise that can be awaited.
https://github.com/googleapis/nodejs-pubsub/blob/38fba8bb98636d21c1d2005be4352fb8190e1813/src/publisher/message-queues.ts#L162-L173
With this it seems currently impossible to reliably await the complete publication of all message with this library, no?

@cdupuis Thanks for the report. That does look wrong at first glance, but I wonder if this code was relying on promisify(), and I missed updating it or something.

Re-opening this upon request from TSEs.

This got some changes from the exactly once delivery work, and it looks like the current unit tests should cover it, so I think this is finished. Please comment if you're still having the issue.


Visualization Code

Hi, Could the code of visualization of attribute localization results share?

similar to issue #17, also see https://pytorch.org/tutorials/intermediate/spatial_transformer_tutorial.html

similar to issue #17, also see https://pytorch.org/tutorials/intermediate/spatial_transformer_tutorial.html

similar to issue #17, also see https://pytorch.org/tutorials/intermediate/spatial_transformer_tutorial.html

thanks

@Aismarter  can you share the visualization code base it will helpful !!!


remove duplicated device detection

BTW, express-device uses useragent internally

Also, it feels like we should do feature detection over user agent checks -> https://github.com/andyearnshaw/Intl.js#intljs-and-browserifywebpack for instance.

I think it's ok for now.


Task/19 bulk_update_leads_info

#19

Since I just removed the partially-completed script from master, could you rebase this against the latest master so the PR shows the full script?

I resolved conflict, try again

closes #19

will try to close #19 again.

@philfreo lets try again. now with addresses.
closes #19

should also support the date_won

@anemitz there is a problem with the date format

@congocongo what's the issue?

@anemitz  I added column, but... date may be in different formats.

that's OK if the user enters a date in a format our API doesn't expect then they can just see & deal w/ the error from the 400


feat: add support for shouldSkip

shouldSkip as implemented in #3 doesn't work as expected and was partly reverted in fe9a0acdb3c56d40ab94ec448fa382c673ac1ba7 after a discussion in https://github.com/spatie/laravel-livewire-wizard/discussions/15. This PR is a second attempt at adding support for skipping steps.
This is a different (and much better!) implementation of shouldSkip. It does not depend on events which allows for skipping steps without an additional network round-trip. Better end-user UX, hooray!

The getLivewireInstance() method is a partial implementation of what happens in Livewire::mount().
It does not yet pass state to the component. We 100% need this, but I am not completely sure what state to pass yet.
getLivewireInstance is not the same as getInstance in Livewire.
It might be cleaner to add it as a macro to Livewire. This can be changed of course.

It doesn't support excluding shouldSkip'ed steps from the navigation. This needs a new PR. And I'm out of time :)

allows for skipping steps without an additional network round-trip.

Is this the only improvement? This feels like a lot of extra code (and "magic" with the lifecycle manager) to maintain for 1 network roundtrip less, I'll leave the final decision to @freekmurze however

@riasvdv the previous implementation did not work at all and was partially removed by @freekmurze.
The event got emitted before JS was loaded. It would always show the skipped step. Because it did emit the event, the test thought the step was skipped. I initially came up with a workaround but it didn't support going back.
Discussion: https://github.com/spatie/laravel-livewire-wizard/discussions/15.

@riasvdv there is a different approach and I actually did think of this at first.
We could make shouldSkip static and pass state as a variable to it. Code-wise this will look cleaner from a maintainer point of view. It means you can remove all of the somewhat magic code to instantiate Livewire. It also means that state will work differently in shouldSkip, which I'm not a fan of myself.
I prefer the current developer experience.

I've decided against merging this as it involves too much code, and we don't need this feature ourselves.
If you need to go to a certain step in one go, use the showStep() function and pass it the step name you directly want to go to.

No problem. I disagree with that it's too much code though.
The only thing that may not be available in Livewire itself is how we retrieve the instance. It does not differ much in terms of additional code from what you made yourself to ensure tests work though. Feels a tiny bit like double standards, but it's your package 🥲
showStep is not the same, so I'd probably extend the current WizardComponent with the code from the PR.
In the end I'm not maintaining this package so no hard feelings.

@ju5t in case anybody needs the skip step functionality, here's a Livewire wizard with skip step functionality: https://github.com/satoved/laravel-livewire-steps
It uses Livewire form objects instead of Livewire components for steps.

@satoved we don't need it ourselves, I just thought it would be a nice addition back then.
Personally I'm not a fan of form components and their implementation. And we're not planning on switching to a different package for now. It's good to have an alternative but it's not for us.


Add functionality in cert-gen to skip creating certs or rewrite existing certs

Description:

By default cert-gen should not create new certs, if they already exist in the same namespace, e.g. during upgrades
A new arg such as --rewrite-certs should be added if we want cert-gen to delete existing certs and create new ones

This sounds good to me, yeah. The default for the update case should be to reuse your existing certs.


Snapshot wheel naming interferes with pip install

On some platforms (observed this on EMR), the naming scheme of snapshot wheels causes an error during pip install:
[hadoop@ip-172-31-49-55 tmp]$ pip3.6 install --user /opt/rasterframes/pyrasterframes-0.8.5-SNAPSHOT-py3-none-any.whl
ERROR: pyrasterframes-0.8.5-SNAPSHOT-py3-none-any.whl is not a supported wheel on this platform.

After some digging, it appears that the snapshot tag is being recognized as part of the platform (snapshot-py3).  Might want to consider not using a hyphen, even though this is fairly standard practice in Java land.

@jpolchlo The whl file is named based on the contents of  version.py
Also, I'd encourage some more digging in your target directory pyrasterframes/target/python/dist. I have seen sometimes there is a slightly subtle duplicated message from SBT that says there is a whl file but  is not pip installable.... Example:
$ sbt ";clean;package"
....
[info] Python .whl file written to '/Users/jbrown/src/raster-frames/pyrasterframes/target/python/dist/pyrasterframes-0.8.6.dev0-py3-none-any.whl'
[info] Maven Python artifact written to '/Users/jbrown/src/raster-frames/pyrasterframes/target/scala-2.11/pyrasterframes-0.8.6-SNAPSHOT-py3-none-any.whl'
[success] Total time: 133 s (02:13), completed Feb 11, 2020 11:09:58 AM

In this case the first message is a well formed pip installable whl, note the target directory is in the pyrasterframes package under the python language dir. The second message is actually a whl I think but because it is in the scala language dir it uses the java version name...

OK, that's fine.  But in that case be aware that pySparkCmd reports the wrong .whl:
PYTHONSTARTUP=/tmp/sbt_eb091e00/pyrf_init.py pyspark --jars /home/jpolchlopek/work/rasterframes/pyrasterframes/target/scala-2.11/pyrasterframes-assembly-0.8.5-SNAPSHOT.jar --py-files /home/jpolchlopek/work/rasterframes/pyrasterframes/target/scala-2.11/pyrasterframes-0.8.5-SNAPSHOT-py3-none-any.whl

Interesting and that is an issue. I think we have two things to fix:

Update the  sbt pySparkCmd to emit the name of the whl in the pyrasterframes/target/python dir
Possibly?  Update the sbt package messages to clarify the Python whl is suitable for pip install and clarify the purpose of the  "Maven Python artifact". I would actually prefer to omit the logging about the Maven artifact because I don't know what it is for.

As far as EMR it may be down to the pip version being used? pip --version?

I agree.  It's especially confusing to publish two wheel artifacts at all, especially when one is prone to failure.  You have my :+1: !
[info] Maven Python artifact written to '/home/jpolchlopek/work/rasterframes/pyrasterframes/target/scala-2.11/pyrasterframes-0.8.5-SNAPSHOT-py3-none-any.whl'
PYTHONSTARTUP=/tmp/sbt_eb091e00/pyrf_init.py pyspark --jars /home/jpolchlopek/work/rasterframes/pyrasterframes/target/scala-2.11/pyrasterframes-assembly-0.8.5-SNAPSHOT.jar --py-files /home/jpolchlopek/work/rasterframes/pyrasterframes/target/scala-2.11/pyrasterframes-0.8.5-SNAPSHOT-py3-none-any.whl

This might motivate me to finally fix the sbt/setuptools version synchronization problem. It's been a bugaboo for a while.

@jpolchlo I've made an initial stab at addressing this here:
https://github.com/locationtech/rasterframes/pull/480
However, I can't seem to get the output of pySparkCmd bit to work with --py-files, and have no idea why it's not working. No errors, just no pyrasterframes in the sys.path


Strings empty when contains acute accent

Hi there.
I've found a problem with your awesome framework.
Imagine you have a table... two fields, id=int, nombre=string filled with data like:
1,"árbol"
2,"arbol"
I'm searching for a substring like:
    let entidades = db["Entidades"];
    let id = Expression<Int64>("ID");
    let nombre = Expression<String>("Nombre");
    let query = entidades.select(id,nombre).filter(like("%rbo%",nombre)).order(nombre);
    let items = Array(query);

items.count is 2, as it should, but if I print the values I got this
ID: 1, Nombre: ""
ID: 2, Nombre: "arbol"
I suppose there is a problem in the Expression, so I try to avoid that writing a pure SQL query:
    for row in db.prepare("SELECT id,nombre FROM entidades WHERE nombre like (?)", "%rbo%") {
        println("ID: \(row[0]), Nombre:'\(row[1])'");
    }

And I got this:
ID: Optional(1), Nombre:'Optional("")'
ID: Optional(2), Nombre:'Optional("arbol")'
So, I'm stuck there... I don't know what else can I do, but I need to be able to retrieve accented strings. Any ideas?

Looks like a potential UTF-8 issue. I won't be able to take a look today but should have some time tomorrow. If you can attach a sample project with the problem I should be able to hit the ground running.

Hi Stephen.
It seems it was my fault. I was preparing a sample code to send you, and whoops... it worked.
I created a new .sqlite for the test, having the accents, and it worked like a charm... so I try exporting to SQLite again with another tool, and this time it worked perfect.
It seems encoding of SQLiteConverter wasn't properly UTF8 or I didn't set up properly any option. I was looking the data with Liya and it showed all the accents, so I was sure the file was right.
Converting with RazorSQL saved the day :)
Anyway, thanks for your help!

Thanks for looking into this and glad you could rectify the problem!


[noetic][Windows] Adding .lib into the symlink install file list

This enhancement makes an existing bug in CATKIN_SYMLINK_INSTALL surface up. 😉
The problem & solution is the same as https://github.com/ament/ament_cmake/pull/219.
This is a cherry-pick and please consider to back-port it into kinetic-devel as well.

Thanks for the patch.

Cherry-picked to kinetic-devel in 807c983e2c3191866b40c7e2f79c66d6f0ff8c8e.


MML-298 Fix XXE in json-schema-validator

  ✗ XML External Entity (XXE) Injection [High Severity][https://snyk.io/vuln/SNYK-JAVA-ORGMOZILLA-1314295] in<EMAIL_ADDRESS>    introduced by<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>  This issue was fixed in versions: 1.7.12

Latest available json-schema-validator (2.2.14, released May 2020) ships with an unsafe Rhino version. Need to add an exclusion and pull in a safe Rhino version explicitly.

hey @ldrozdz looks like we missed this PR, @symphony-enrico is now longer working on messageml-utils, i'll update the .github files to make sure we get notifications on new PRs
we actually ignored rhino in the Snyk reports for the Agent as it used as a fallback for Nashorn (that is still there in the JDK versions we use) and probably not even used by the Agent in any case.


wip group membership

closes https://github.com/inveniosoftware/invenio-app-rdm/issues/2186

tests passing locally


uncomment inernet_connection condition

Maybe this was commented on purpose, but I don't know for sure.

I'm not sure why I had it commented out. I need to update the Edge hard codings and do another release soon. Thanks.


Add bash-it stuff to the end of .bashrc during install.

I think it's probably pretty common for users to already have a bit of .bashrc customisation in place before they try .bashrc. It would be good not to destroy that information. For the most part, you can just add the bash-it content to the end of the existing .bashrc and it will work fine. That would probably be a better default, as then users won't lose their custom PATHs, etc.
On a side-note, the backup process fails if .bashrc is a link to elsewhere. In that case, you copy the link, then edit .bashrc, which edits the same file, so the .bashrc.bak also gets changed. You could get around that by using cp -aL ... at line 36 of the installation script, or you could just move it, and create a new .bashrc instead. I think the former is better.

Good thoughts! Feel free to provide a PR for both of these:

Fixing the backup process with cp -aL
Appending to the existing file instead of copying the template.

Hi, it seems there's no PR so far for these requests so, if it's ok for @naught101 I could do this in a couple of days. Anyway, I just discovered this project (which is quite great, by the way :) ) and I may be wrong. Thx

Don't wait for me - both of these I already had to fix manually, and now no longer need, and I haven't had time to make pull requests.

@spectrumIG Great - please feel free to provide a PR for this!

Thanks to @spectrumIG for fixing this in #641 - closing this now.


SSO SAML with Keycloak

Generally works. Not done yet:

Logging out
mapping Location, Phone and Title

Keycloak
Settings:

client ID: https://<domain>/sso/metadata
name: OnlyOffice
root url: https://<domain>/sso/acs
home url: https://<domain>/sso/acs
Valid redirect URIs: https://<domain>/sso/acs
Valid post logout redirect URIs: https://<domain>/sso/slo/callback
Name ID format: email
Force POST binding: on (else it seems not to work)
Sign documents: on
Sign assertions: on
Signature algorithm: RSA_SHA256 (or RSA_SHA512)

Keys:

Client signature required: off
Encrypt assertions: generate. Use the public key (shown) and private key (automatically downloaded) for the "SP Certificates" of OnlyOffice. Possibly a key generated by OnlyOffice might also work, but did not test this. Leave this off initially, to check if the rest works!

Client Scopes:

go to https://<domain>/sso/metadata-dedicated
Add these predefined mappers: email, givenName and surName.
Set the "SAML Attribute NameFormat" of each mapper to "URI reference". Using basic names seemingly does not work.

OnlyOffice

Load metadata from https://<keycloak-base>/realms/master/protocol/saml/descriptor
Optionally change the bindings to POST. Watch out: OnlyOffice empties what's filled in!
Change NameID format to email
Default Signature Verification Algorithm: rsa-sha256 (same as configured in Keycloak)
Use SP Certificates (public and private key) generated by Keycloak. Leave this off initially, to check if the rest works!

Be sure to add the -----BEGIN CERTIFICATE-----, -----END CERTIFICATE-----, -----BEGIN RSA PRIVATE KEY-----and-----END RSA PRIVATE KEY-----`, else OnlyOffice will not accept.
Pick "rsa-sha1" and "aes256-cbc" - others might also work - I noticed that I could just change "aes128-cbc" to "aes256-cbc" and everything kept working.
Select "signing and encrypt"

Attribute mapping. These can also be copied from Keycloak. Using basic names did not work for me.

First name: urn:oid:<IP_ADDRESS>
Last name: urn:oid:<IP_ADDRESS>
Email: urn:oid:1.2.840.1135<IP_ADDRESS>
Empty Location, Phone and Title

Debugging
In onlyoffice-community-server you'll find the only interesting logging:

tail -n 50 -f /var/log/onlyoffice/web.sso..log

Feedback welcome on:

How to get log-out working
How to do mapping with Simple names
General improvements of the above

Hello! Thank you for your tutorial.
Unfortunatlly, can not use the first step: "Load metadata from https:///auth/realms/master/protocol/saml/descriptor".
Please, can you explain what should I full in this gaps:

IdP Entity ID
IdP Single Sign-On Endpoint URL
IdP Single Logout Endpoint URL
NameID Format
It would be great if you are able to attach image explonation of using OnlyOffice SSO Control panel (screenshot).

Can not use the first step: "Load metadata from https:///auth/realms/master/protocol/saml/descriptor".

I fixed the text. The <domain> and <keycloak-base> parts were removed at some places. I hope you understood that you need to replace these parts with data from your environment. See for example https://www.itsfullofstars.de/2020/02/keycloak-download-saml-2-0-idp-metadata/ how to get the SAML descriptor, if the url does not work.
Do know that this is quite basic knowledge for Keycloak-administration. I therefore strongly suggest you read a bit further, to prevent from making some serious mistakes.

Hello! Thank you for your tutorial.
I encountered an endless redirect after successful authorization (user session is displayed in keycloak -> Clients -> Sessions). I analyzed the connection with the SAML-Tracer tool and saw a infinity loop of the following picture.

Can you see anything errors? Or maybe you got this err, thank you very mutch

@VincentSC I want to add additional parameters during SSO login, such as kc_idp_hint=github. What should I do

@YuanZhencai I don't know, as I'm not using that myself. Sorry.

Anyone get logging out to work?


setting controls

DRIVE CONTROLS
turning angle for all modules
setting throttle for all modules
extra quality of life controls; breaking, speeding up, etc
FEEDBACK
driver vibration using gyro ??
dashboard color light up ??

@Jose-prog575 bring progress and ideas here.


Add saslplan to mtls scenario

Good morning @rohit2b ,thank you for putting this one together, I've added my reviews.
A quick question, we used to include a producer example like here , do we not do that anymore?

A quick question, we used to include a producer example like here , do we not do that anymore?
Good point - I'll add one next for this scenario.


Fixing ariaWorld pose to spotWorld pose transformation

Actual bug was wrong use of lookup_transform. We were expecting target_T_source, however it returns source_T_target. Fixed.
Other hygiene:

Wrapping rotated rotation within (-pi, pi) range after adding theta.

Not needed!


Lift the deprecation from ArrayNode#each_value

This PR lifts the deprecation from ArrayNode#each_value for the following reasons:

HashNode#each_value and HashNode#each_key are not deprecated.

HashNode#each_value ... https://github.com/rubocop/rubocop-ast/blob/v1.31.3/lib/rubocop/ast/node/hash_node.rb#L76-L89
HashNode#each_key ... https://github.com/rubocop/rubocop-ast/blob/v1.31.3/lib/rubocop/ast/node/hash_node.rb#L52-L65

node.values.each is recommended by Style/HashEachMethods cop to be replaced with each_value instead of values.each. And node.each_value do |value| is clearer in intent than node.children.each do |value|.

Since it is a soft deprecation in documentation only, it has not been added to the changelog.

You are right, thank you ❤


[feature request] assertions for multi line values

I have a rendered helm chart like the following for a spring application

templateKeys:
    - key : config.yaml
      template: |
         server.port=8888
         spring.application.name=my-app

or
templateKeys:
    - key : config.yaml
      template: |
          spring:
            application:
              name: my-appp

currently I have to assert my template using
-it : test
  asserts:
    - matchRegex:
      - path: spec.templateKeys[0].template
        pattern: spring.application.name=my-app

or
-it : test
  asserts:
    - matchRegex:
     - path: spec.templateKeys[0].template
       pattern: name=my-app

would by nice if I could assert using
-it : test
  asserts:
    - equal:
     - path: spec.templateKeys[0].template.spring.application.name
       value: my-app
``

Hello @ensctom,
Thank you for the feedback.
Will look into this option.
Greetings,
@quintush


Update Readme

XRTK - Mixed Reality Toolkit Pull Request
Overview
Updated the Readme to be a bit more appealing.

/azp run


Amplify Stack Push cannot update my stack anymore, fail on resources not even being updated

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
dr30qdghmfhdu
Region
us-east-1
Amplify Console feature
Backend builds
Describe the bug
I have opened this bug a while ago: https://github.com/aws-amplify/amplify-console/issues/1469
For some divine mystery it was closed without anyone ever addressing my issue, and now I'm facing a much worse situation
As you can see on my original bug report, that report was making all my deployments through the Amplify CI/CD to fail on a specific function, even if I don't touch this  function... it loses its dependencies
To fix, this I had to always manually push the backend from my local client (amplify push) with some small change on the function (ie: increment a variable)
However, now what is happening is that I'm unable to make it work
All my attempts to push are failing now, and I have my application with limited features due to this function being in a bad state
Every time I run amplify push I get the following errors:

UPDATE_FAILED               HostedUIProvidersCustomResourceInputs               Custom::LambdaCallout      Wed Jul 28 2021 20:26:41 GMT+0200 (Central European Summer Time) Received response status [FAILED] from custom resource. Message returned: See the details in CloudWatch Log Stream: 2021/07/28/[$LATEST]8bec139d4824430c8718ef3e9f725370 (RequestId: 6f759a93-d797-4a79-853a-4de43e5dd453)

UPDATE_FAILED authlexis AWS::CloudFormation::Stack Wed Jul 28 2021 20:26:50 GMT+0200 (Central European Summer Time) Embedded stack arn:aws:cloudformation:us-east-1:679504623344:stack/amplify-lexis-staging-112559-authlexis-QLWRGJ5SZGMO/45458600-9b4e-11ea-a51d-1271b8f35690 was not successfully updated. Currently in UPDATE_ROLLBACK_IN_PROGRESS with reason: The following resource(s) failed to update: [HostedUIProvidersCustomResourceInputs].

UPDATE_FAILED               functionThumbnailsGenerator  AWS::CloudFormation::Stack Wed Jul 28 2021 20:27:02 GMT+0200 (Central European Summer Time) Resource update cancelled

If I check my stack, there is nothing in progress like it said there, and I can't find this log stream on the log groups
It seems to be related to this layer that I have introduced some time ago, then I have tried to remove it, but I can't remove it... there was only one function using it, I have remove it from there, but every time I try to remove the layer it says there is this function yet using it
I have tried adding/removing it, but now I get this error every time I try to remove the layer

Cannot read property 'filter' of undefined
TypeError: Cannot read property 'filter' of undefined
    at /usr/local/lib/node_modules/@aws-amplify/cli/node_modules/amplify-category-function/src/provider-utils/awscloudformation/utils/layerHelpers.ts:248:33
    at Array.filter (<anonymous>)
    at Object.getLambdaFunctionsDependentOnLayerFromMeta (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/amplify-category-function/src/provider-utils/awscloudformation/utils/layerHelpers.ts:245:45)
    at Object.removeWalkthrough (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/amplify-category-function/src/provider-utils/awscloudformation/service-walkthroughs/removeLayerWalkthrough.ts:25:43)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at Object.run (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/amplify-category-function/src/commands/function/remove.ts:30:29)
    at Object.executeAmplifyCommand (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/amplify-category-function/src/index.ts:248:3)
    at executePluginModuleCommand (/usr/local/lib/node_modules/@aws-amplify/cli/src/execution-manager.ts:177:3)
    at Object.executeCommand (/usr/local/lib/node_modules/@aws-amplify/cli/src/execution-manager.ts:29:5)
    at Object.run (/usr/local/lib/node_modules/@aws-amplify/cli/src/index.ts:151:5)

Now I have an application without some of its most important features, and I can't push my backend manually to fix it
I have also tried running amplify pull -restore, then just updating the variable increment on my function... still fails
I'm out of ideas what else to try
PLEASE DON'T CLOSE THIS ISSUE BEFORE IT IS SOLVED, IT IS EXTREMELY IMPORTANT
Expected behavior
The amplify push should finish without any issues
Reproduction steps
Update the lambda function in order to push the changes
push the changes with amplify push
Build Settings
No response
Additional information
No response
EDIT: I have ran again pull --restore, and then changing the single file, but now I get this error:

UPDATE_FAILED      authlexis                    AWS::CloudFormation::Stack Wed Jul 28 2021 20:55:35 GMT+0200 (Central European Summer Time) Parameters: [breakCircularDependency] must have values

UPDATE_FAILED functiondownloadDocx AWS::CloudFormation::Stack Wed Jul 28 2021 20:55:46 GMT+0200 (Central European Summer Time) Resource update cancelled
⠇ Updating resources in the cloud. This may take a few minutes...

UPDATE_FAILED               functionThumbnailsGenerator  AWS::CloudFormation::Stack Wed Jul 28 2021 20:55:46 GMT+0200 (Central European Summer Time) Resource update cancelled

I found out that this breakCircularDependency is a feature flag
It says to add it on the cli.json... I didn't have this file on my amplify folder, so I have created it with the example values:

{
  "features": {
    "graphQLTransformer": {
      "addMissingOwnerFields": true,
      "validateTypeNameReservedWords": true,
      "useExperimentalPipelinedTransformer": false,
      "enableIterativeGSIUpdates": false
    },
    "frontend-ios": {
      "enableXcodeIntegration": true
    },
    "auth": {
      "enableCaseInsensitivity": true,
      "useInclusiveTerminology": true,
      "breakCircularDependency": true
    },
    "codegen": {
      "useAppSyncModelgenPlugin": true
    }
  }
}

Then ran amplify push again... same error

amplify --version
5.2.0

I'll open it on amplify-cli as it is more related


Fixing bug in drogon_ctl when creating a model, that causes to write …

…the content of the header and sourcefiles multiple times

Thanks! merged.


Documenting small things here and there..

Hey! I've just started using Bevy by following Snake tutorial and I'm just tinkering with documenting some things here and there.
Please provide feedback.

Thanks for the additions. I'll push them in a second.
The CI fails if my file isn't rustfmt'd, but if a I run cargo fmt inside of bevy, then all the
files gets modified.. I guess, should I push a commit that has formatted every bevy file using cargo fmt?

The CI fails if my file isn't rustfmt'd, but if a I run cargo fmt inside of bevy, then all the
files gets modified.. I guess, should I push a commit that has formatted every bevy file using cargo fmt?

Never mind. I figured that it was a windows thing. I am using different line endings than Unix. I changed
rustfmt.toml line to newline_style = "Native", and that worked fine. I won't commit this change..
But these line endings might come from GIT, maybe?


Unified Log Parser Fails on Windows

I'm having issues running on Windows 11, not sure if the command is correct or not.

Logs pulled right from the device via Sysdiagnose. Any thoughts?

What happens if u specify the output filename?
Like:
unifiedlog_parser.exe -i <path> -o "C:\Users\kevin\Desktop\KP 13\out.csv"

Is KP 13 a directory?

@puffyCid yes it's a directly, do you have strictly state a file name and extension as output or can it be a folder? It wasn't very clear by the help menu

Yes an output filename is required. There have quite commits I'll try to upload a new release and update the help menu

@puffyCid great, I'll try that, and I'll keep an eye out for a new release (was wondering if a new wrapped exe would be coming), thanks!

@puffyCid finally got around to this, ran fine with a few errors and warnings, just now have to find something open a 3gb CSV file.


Memcpy hints

closes #180

Nice work! I would like for you to add this integration test though. I've tried to run it locally and it seems to be halting

Thank you! 👍


Go assembler applies wrong optimizations to MOVQ

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.8.3 linux/amd64
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/hdevalence/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build126311645=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
What did you do?
I put MOVQ $0, AX in a Go assembly file.
What did you expect to see?
A move instruction, such as
48 b8 00 00 00 00 00 	movabs rax,0x0
00 00 00

or any other equivalent instruction.
What did you see instead?
An XOR, which clobbers the carry flags, breaking the program.
31 c0                	xor    eax,eax

This is essentially a duplicate of https://github.com/golang/go/issues/12405, which is now locked.  That issue notes that MOV is now "marked as clobbering flags" (presumably in the compiler internals?) but this fact seems not to be documented in either the Go assembly documentation or in the Plan 9 assembler documentation.

Have you tried on tip or 1.9beta2?

/cc @randall77 @josharian @mdempsky

I don't think there's anything to say beyond what was said in https://github.com/golang/go/issues/12405. Unless Russ has changed his mind, this is a documentation issue.

More information about the pain this "optimization" has caused: #22325.
FWIW, I think @rsc has changed his mind at this point and agrees that we should just take this out of obj.

I just chatted about this with several runtime/compiler people and we all agreed that this should be removed from obj (and done explicitly in the compiler where it makes sense). Now someone just has to do it. :)


equilateral triangular prism Calculator

I would like to add a calculator that Calculates the volume and surface area of a equilateral triangular prism given the edge length and height. Please assign this to me.

Go ahead
Deadline 10 May,2021


✕ unmet peer<EMAIL_ADDRESS>found 16.2.3

 WARN  Issues with peer dependencies found
.
└─┬ commitlint-config-gitmoji
  └─┬ commitlint-plugin-gitmoji
    └── ✕ unmet peer<EMAIL_ADDRESS>found 16.2.3

fixed in<EMAIL_ADDRESS>


Request for more basic header bidding info

See https://github.com/prebid/Prebid.js/issues/5897 -- request for a more start-from-scratch of what header bidding is.

Discussed in committee - we should add a FAQ entry with a link to an existing resource like https://digiday.com/media/wtf-header-bidding/


Fix previous proposal handling in consensus

Problem
Nodes happily reused zero-length proposals from previous blocks.
Solution
Disallow that.

But name service test is failing.

It's a separate issue, some test problem. See rerun results.


Examples do not work without version number being declared in main.tf

I've been trying to follow some of your examples, namely "complete" and "atomic-deployments", and been getting various errors when following the instructions verbatim. I won't list the errors as I now understand why they were occurring. It is necessary to configure the appropriate version of the tf_next module in main.tf and then things work as expected.
Perhaps this just needs a small update to the documentation. Happy to submit a PR for this myself. Perhaps it's super obvious and doesn't even need to be documented. I'm quite new to terraform.

Hi, thanks for the heads up on this 👍
The examples are a little behind for now, but will try to fix this soon!
Thing is that Terraform currently doesn't accept a version range for prerelease versions, e.g. version = "~> 1.0.0-canary.4" is not working, only exact versions are currently allowed: version = "1.0.0-canary.4".
That means we have to ensure that the version in all examples is increased on each new prerelease.
Not a blocker because I think we can include this into our release pipeline pretty easily.
Also filled a bug report on Terraform, that version range on prereleases are currently not allowed: https://github.com/hashicorp/terraform/issues/31271


[ko] Translate the glossary term 'Approver' into Korean

This is a Feature Request
What would you like to be added
Translate the glossary term 'Approver' into Korean

link to en entry: https://kubernetes.io/docs/reference/glossary/?all=true#term-approver
link to ko entry: https://kubernetes.io/ko/docs/reference/glossary/?all=true#term-approver

Why is this needed
Not translated yet
Comments
/language ko
/assign

/triage accepted

Resolved by

#35561 (→ dev-1.24-ko.2)
#35767 (dev-1.24-ko.2 → main)

/close


wallet-ext: add storage migration

Description

when wallet is already initialized with accounts stored in vault
ask the user for the wallet password
do the migration to new accounts

https://github.com/MystenLabs/sui/assets/10210143/a6b67b4c-b5e6-4772-884c-531187e2b200

closes APPS-1101
Test Plan
👀

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] protocol change
[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

@mystie711 I kept the UI as simple as possible - we can revisit this at a later time (if necessary) since this will probably be enabled/shown to current users at the last state of releasing the new UI/zk

Sounds good @pchrysochoidis.
This does not look bad!
Will file a new task if needed.


[WIP] fix TestUDSLog flaky

Please provide a description of this PR:
fixes: #43115

@zirain: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
1bf5d41fce1f95d4316daccf1dfe51756d9d5e90
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zirain: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
1bf5d41fce1f95d4316daccf1dfe51756d9d5e90
link
true
/test lint

gencheck_istio
1bf5d41fce1f95d4316daccf1dfe51756d9d5e90
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

double check this on testgrid, only reproduce on arm64

/retest unit-tests-arm64_istio

@zirain: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test analyze-tests
/test gencheck
/test integ-basic-arm64
/test integ-cni
/test integ-distroless
/test integ-ds
/test integ-helm
/test integ-ipv6
/test integ-operator-controller
/test integ-pilot
/test integ-pilot-istiodremote
/test integ-pilot-istiodremote-mc
/test integ-pilot-multicluster
/test integ-security
/test integ-security-istiodremote
/test integ-security-multicluster
/test integ-telemetry
/test integ-telemetry-istiodremote
/test integ-telemetry-mc
/test lint
/test release-notes
/test release-test
/test unit-tests
/test unit-tests-arm64

The following commands are available to trigger optional jobs:

/test benchmark
/test integ-assertion

Use /test all to run the following jobs that were automatically triggered:

analyze-tests_istio
gencheck_istio
integ-basic-arm64_istio
integ-cni_istio
integ-distroless_istio
integ-ds_istio
integ-helm_istio
integ-ipv6_istio
integ-operator-controller_istio
integ-pilot-istiodremote-mc_istio
integ-pilot-istiodremote_istio
integ-pilot-multicluster_istio
integ-pilot_istio
integ-security-istiodremote_istio
integ-security-multicluster_istio
integ-security_istio
integ-telemetry-istiodremote_istio
integ-telemetry-mc_istio
integ-telemetry_istio
lint_istio
release-notes_istio
release-test_istio
unit-tests-arm64_istio
unit-tests_istio

In response to this:

/retest unit-tests-arm64_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/retest unit-tests-arm64_istio

@zirain: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test analyze-tests
/test gencheck
/test integ-basic-arm64
/test integ-cni
/test integ-distroless
/test integ-ds
/test integ-helm
/test integ-ipv6
/test integ-operator-controller
/test integ-pilot
/test integ-pilot-istiodremote
/test integ-pilot-istiodremote-mc
/test integ-pilot-multicluster
/test integ-security
/test integ-security-istiodremote
/test integ-security-multicluster
/test integ-telemetry
/test integ-telemetry-istiodremote
/test integ-telemetry-mc
/test lint
/test release-notes
/test release-test
/test unit-tests
/test unit-tests-arm64

The following commands are available to trigger optional jobs:

/test benchmark
/test integ-assertion

Use /test all to run the following jobs that were automatically triggered:

analyze-tests_istio
gencheck_istio
integ-basic-arm64_istio
integ-cni_istio
integ-distroless_istio
integ-ds_istio
integ-helm_istio
integ-ipv6_istio
integ-operator-controller_istio
integ-pilot-istiodremote-mc_istio
integ-pilot-istiodremote_istio
integ-pilot-multicluster_istio
integ-pilot_istio
integ-security-istiodremote_istio
integ-security-multicluster_istio
integ-security_istio
integ-telemetry-istiodremote_istio
integ-telemetry-mc_istio
integ-telemetry_istio
lint_istio
release-notes_istio
release-test_istio
unit-tests-arm64_istio
unit-tests_istio

In response to this:

/retest unit-tests-arm64_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/test unit-tests-arm64

/test unit-tests-arm64

/test unit-tests-arm64

/test unit-tests-arm64

/test unit-tests-arm64

/test unit-tests-arm64

/test unit-tests-arm64

I cannot reproduce this locally, add debug log first.

fwiw i tried to reproduce even on CI arm64 machine and couldn't. No clue why...

this flaky occurred once or twice per day, it's hard to reproduce.


Added 5 points Prediction  and Additional Graph Analysis Capabilities

Description

Implemented Next 5 Points Prediction: Added a feature that predicts the next five data points using a regression model, enhancing the predictive capabilities of the application.

~2. CSS Addition and Fixes: Addressed the missing CSS issue by incorporating the intended styles, improving the overall look and feel of the interface.~
~3. Updated the README.md and fixed the requirements.txt which was missing many dependencies.~

Added additional  Graph analysis capabilities

Related Issue

Fixes # (issue)
#1
#3
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Motivation and Context
A good CSS is always good to make the project appealing and other was the listed Issue #1

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Screenshots (if appropriate):
~https://github.com/user-attachments/assets/e8f7d5b4-6348-40f9-b703-807d95f71322~
Checklist:

[x] I have registered myself at Contrihub website.
[x] My code follows the code style of this project.
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] Any dependent changes have been merged and published in downstream modules
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Even though the issue for frontend was closed, project was missing any CSS styling so i made it.

Even though the issue for frontend was closed, project was missing any CSS styling so i made it.

Because they are in another branch.

Ok mam. Apologies. I'll revert it

Here is the updated work.

Added this as per my assigned issue #3

Added this as per my assigned issue #3

Make changes as per the reviews for your first issue. The third one seems fine to me.

Make changes as per the reviews for your first issue. The third one seems fine to me.

Yes mam i did the changes for the first
The time was about to get over the 3rd issue thats why i added it
Can u review and tell what more i can do?

Make changes as per the reviews for your first issue. The third one seems fine to me.

Yes mam i did the changes for the first
The time was about to get over the 3rd issue thats why i added it
Can u review and tell what more i can do or is it fine?

Third one seems fine

Make changes as per the reviews for your first issue. The third one seems fine to me.

Yes mam i did the changes for the first
The time was about to get over the 3rd issue thats why i added it
Can u review and tell what more i can do or is it fine?

Third one seems fine

OK mam thank you.

@aachintya are you making the changes as per the reviews?

@aachintya are you making the changes as per the reviews?

Yes mam i did the changes already.
I removed the css and other unncessary changes

@aachintya are you making the changes as per the reviews?

Yes mam i did the changes already.
I removed the css and other unncessary changes

@aachintya not these, migrate to the files tab and check the reviews on the code.

@aachintya are you making the changes as per the reviews?

Yes mam i did the changes already.
I removed the css and other unncessary changes

@aachintya not these, migrate to the files tab and check the reviews on the code.

Could you please explain me. i couldn't find any code reviews on the files changed tab.

@aachintya https://github.com/ContriHUB/Graph-Analyzer/pull/7#pullrequestreview-2387178130 this is the link to the code reviews.

@aachintya #7 (review) this is the link to the code reviews.

link is not opening. i am not able to see any comments out there.

@aachintya #7 (review) this is the link to the code reviews.

link is not opening. i am not able to see any comments out there.

Try this link: https://github.com/ContriHUB/Graph-Analyzer/pull/7/files#diff-c2aec32f1841f40dd9d56c7e2640bd934d497509e76dd14caf1818c6643de1d9R22

this is in files changed tab. You must have also received it's email.

@aachintya #7 (review) this is the link to the code reviews.

link is not opening. i am not able to see any comments out there.

Try this link: https://github.com/ContriHUB/Graph-Analyzer/pull/7/files#diff-c2aec32f1841f40dd9d56c7e2640bd934d497509e76dd14caf1818c6643de1d9R22  this is in files changed tab. You must have also received it's email.

Thank you mam. i'll work upon them.
i was unable to see the reviews or get any notification because they are still pending and will not be visible to others unless published  😅
i checked on this youtube video

I did the changes.


docs: Rename "webhooks" to "incoming webhooks".

@timabbott, @rheaparekh: FYI :)
I only renamed references that I thought were absolutely necessary
and only if the resulting sentence structure wasn't awkward.
If the renaming resulted in awkward structure, I replaced the term
"webhook" with "integration" (but only in some very obvious cases).
Fixes #9500.

Merged, after a few tweaks, thanks @eeshangarg!
A follow-up that reading this made obvious to me is that we should split integration-guide.md into the two independent docs (the overview for all integrations and the one for just incoming webhooks); I think it'd make the /api docs structure for these a lot cleaner.


proofs: Create task template for CHALLENGER to post claim in permissioned game

Create a task template for the CHALLENGER role to post a counter claim in a permissioned game. This would just involve calling the attack method with any claim value, but needs to be done from the permissioned account which is usually a multisig - hence the need for a superchain-op.

https://github.com/ethereum-optimism/superchain-ops/compare/aj/challenge-game-template is a draft of the task, but it fails to execute because the value option in the transaction JSON is currently ignored. From @mds1:

superchain ops doesn't currently read in value, presumably because we've had no use case for this: https://github.com/ethereum-optimism/superchain-ops/blob/4c94c8550dc60940fa904a2f06f381b87c6ffc54/src/JsonTxBuilderBase.sol#L41-L51
It's a bit tedious to support, but shouldn't hard. You'd have to:
Read in value in that loop,
which also requires changing all instances from IMulticall3.Call3 to IMulticall3.Call3Value,
then in the base-org/contracts dependency change all instances of aggregate3 to aggregate3Value, and again change from Call3 to Call3Value
and lastly update our base-org/contracts dep to the latest after the upstream change is merged
That ignores setting balance overrides, which you would do here and then make corresponding updates wherever that struct is used

I had a go at doing that and also discovered the post-state checks verify that no balances change so we'll need to have some way to set a list of addresses where the balance can change (and maybe by how much).
And something I did must have been wrong because the simulation still reverts with Multicall3: value mismatch because it expects msg.value = SUM(call[0...i].value). If I try to set a value on the simulated tx (with or without adding a balance override to ensure there are funds), GnosisSafe.execTransaction reverts without any explanation.


ARROW-7158: [C++] Use compiler information provided by CMake

The current our approach doesn't work on non English locale
environment.

@ursabot crossbow submit -g conda -g wheel -g linux

Do we have any test/job that would exercise this? Is it worth adding one?

Do we have any test/job that would exercise this?

I think that most cases are covered by existing CI jobs. But some cases such as -DARROW_USE_TSAN aren't covered.

Is it worth adding one?

It may be better but I don't think that we should add some CI jobs for testing this change. I think that we should add some CI jobs for target functions such as sanitizers. If we don't need some existing features, we should drop code for these features instead of adding new some CI jobs.

@ursabot crossbow submit -g nightly