Do the random points for a Voronoi diagram need to be ordered?

I'm having a problem with a set of randomly generated points that don't produce Voronoi cells properly unless I order them on the X-axis from smallest to largest.
Here are the problem sites in the order they were generated:
randomSites.Add(new Vector3(2.58301f, -0.07231092f, 0f));
randomSites.Add(new Vector3(4.260807f, 1.725296f, 0f));
randomSites.Add(new Vector3(8.839731f, -3.794293f, 0f));
randomSites.Add(new Vector3(-12.11187f, -0.3448925f, 0f));
randomSites.Add(new Vector3(8.466095f, 2.583772f, 0f));
randomSites.Add(new Vector3(3.597496f, -1.383692f, 0f));
randomSites.Add(new Vector3(3.421845f, 0.8252826f, 0f));
randomSites.Add(new Vector3(-7.763506f, -1.487227f, 0f));
randomSites.Add(new Vector3(-0.6644406f, 1.276973f, 0f));
randomSites.Add(new Vector3(7.997253f, 2.485325f, 0f));
randomSites.Add(new Vector3(3.234119f, -3.716683f, 0f));
randomSites.Add(new Vector3(11.37916f, 3.904939f, 0f));
randomSites.Add(new Vector3(11.13493f, -0.3131549f, 0f));
randomSites.Add(new Vector3(6.510168f, 7.292708f, 0f));
randomSites.Add(new Vector3(-2.473285f, 5.793113f, 0f));
randomSites.Add(new Vector3(-8.900781f, -1.143157f, 0f));
If I reorder these, the Voronoi diagrams are generated correctly:
randomSites.Add(new Vector3(-12.11187f, -0.3448925f, 0f));
randomSites.Add(new Vector3(-8.900781f, -1.143157f, 0f));
randomSites.Add(new Vector3(-7.763506f, -1.487227f, 0f));
randomSites.Add(new Vector3(-2.473285f, 5.793113f, 0f));
randomSites.Add(new Vector3(-0.6644406f, 1.276973f, 0f));
randomSites.Add(new Vector3(2.58301f, -0.07231092f, 0f));
randomSites.Add(new Vector3(3.234119f, -3.716683f, 0f));
randomSites.Add(new Vector3(3.421845f, 0.8252826f, 0f));
randomSites.Add(new Vector3(3.597496f, -1.383692f, 0f));
randomSites.Add(new Vector3(4.260807f, 1.725296f, 0f));
randomSites.Add(new Vector3(6.510168f, 7.292708f, 0f));
randomSites.Add(new Vector3(7.997253f, 2.485325f, 0f));
randomSites.Add(new Vector3(8.466095f, 2.583772f, 0f));
randomSites.Add(new Vector3(8.839731f, -3.794293f, 0f));
randomSites.Add(new Vector3(11.13493f, -0.3131549f, 0f));
randomSites.Add(new Vector3(11.37916f, 3.904939f, 0f));
I've uploaded a picture of the Voronoi gizmos before after sorting here (look in Orion's belt):
https://imgur.com/a/2MpFrIu

I've just tried to recreate this issue in the Habrador Test Scene and haven't had any luck.  The issue might very well be in my own code.  If I don't update for a few days, then it's probably my own issue.

I've been able to recreate the issue in the Habrardor Test Scene.  Below is the original code from the test scene and below that is the problem scenario.
`        //// Original code:
//float max = halfMapSize;
//float min = -halfMapSize;
    //for (int i = 0; i < numberOfPoints; i++)
    //{
    //    float randomX = Random.Range(min, max);
    //    float randomZ = Random.Range(min, max);

    //    randomSites.Add(new Vector3(randomX, 0f, randomZ));
    //}

    ////Points outside of the screen for voronoi which has some cells that are infinite
    //float bigSize = halfMapSize * 5f;

    ////Star shape which will give a better result when a cell is infinite large
    ////When using other shapes, some of the infinite cells misses triangles
    //randomSites.Add(new Vector3(0f, 0f, bigSize));
    //randomSites.Add(new Vector3(0f, 0f, -bigSize));
    //randomSites.Add(new Vector3(bigSize, 0f, 0f));
    //randomSites.Add(new Vector3(-bigSize, 0f, 0f));

    //Problem scenario
    float xMax = 12.40375f;
    float xMin = -12.40375f;
    float zMax = 7.945362f;
    float zMin = -4.285754f;
    float xCenter = 0f;
    float zCenter = 2f;

    randomSites.Add(new Vector3(2.58301f, 0f, -0.07231092f));
    randomSites.Add(new Vector3(4.260807f, 0f, 1.725296f));
    randomSites.Add(new Vector3(8.839731f, 0f, -3.794293f));
    randomSites.Add(new Vector3(-12.11187f, 0f, -0.3448925f));
    randomSites.Add(new Vector3(8.466095f, 0f, 2.583772f));
    randomSites.Add(new Vector3(3.597496f, 0f, -1.383692f));
    randomSites.Add(new Vector3(3.421845f, 0f, 0.8252826f));
    randomSites.Add(new Vector3(-7.763506f, 0f, -1.487227f));
    randomSites.Add(new Vector3(-0.6644406f, 0f, 1.276973f));
    randomSites.Add(new Vector3(7.997253f, 0f, 2.485325f));
    randomSites.Add(new Vector3(3.234119f, 0f, -3.716683f));
    randomSites.Add(new Vector3(11.37916f, 0f, 3.904939f));
    randomSites.Add(new Vector3(11.13493f, 0f, -0.3131549f));
    randomSites.Add(new Vector3(6.510168f, 0f, 7.292708f));
    randomSites.Add(new Vector3(-2.473285f, 0f, 5.793113f));
    randomSites.Add(new Vector3(-8.900781f, 0f, -1.143157f));

    // Set outerbound size (star shape) & image center points
    float xBigSize = (xMax - xMin) * 5f;
    float zBigSize = (zMax - zMin) * 5f;

    randomSites.Add(new Vector3(xCenter, 0f, zCenter + zBigSize));
    randomSites.Add(new Vector3(xCenter, 0f, zCenter - zBigSize));
    randomSites.Add(new Vector3(xCenter + xBigSize, 0f, zCenter));
    randomSites.Add(new Vector3(xCenter - xBigSize, 0f, zCenter));`

I fixed the problem. To generate the Voronoi I'm using a Delaunay triangulation. I've implemented several algorithms to generate Delaunay and the one I was using to generate Voronoi has apparently some problems with colinear points, so it was generating a really flat triangle, which broke the Voronoi:

So I changed the Delaunay algorithm to another one which is both faster and more accurate. But that one requires that the points are normalized or it will not work. You can see that it's generating a better triangulation and thus a better Voronoi.

Just wanted to say thanks for your fast turnaround!  New method seem to work great so far.


add microscopy tools

CryoSPARC

RELION (https://github.com/3dem/relion/tree/ver4.0)

EPU_group_AFIS (https://github.com/DustinMorado/EPU_group_AFIS)
cryOLO (https://cryolo.readthedocs.io/en/stable/installation.html)
Gautomatch v0.56 (https://www2.mrc-lmb.cam.ac.uk/download/gautomatch-056)
Chimera 1.17.1 (latest) (https://www.cgl.ucsf.edu/chimera/download.html)
EMAN2 (https://blake.bcm.edu/emanwiki/EMAN2/Install)
pyem (https://github.com/asarnow/pyem/wiki/Install-pyem-with-Miniconda)
MotionCor2 (https://emcore.ucsf.edu/ucsf-software)
Topaz (https://github.com/tbepler/topaz)
Scipion (https://scipion.i2pc.es/)
Xmipp (https://github.com/I2PC/xmipp#xmipp)
CTFFIND (https://grigoriefflab.umassmed.edu/ctffind4)

Hi,
I work at Sydney Microscopy & Microanalysis, at the University of Sydney. I suspect this was requested by me via Ryan Sullivan.
Can I be the external volunteer to implement this? I would start with implementing RELION.
I read that we need to submit an issue to request access to the interactive tool? Or is it better to use the manual method?
https://www.neurodesk.org/developers/new_tools/interactive_build/
Thanks

Dear @vennand,
It would be wonderful to have your help on this!!!
I just added you to the access group, so you can login to https://labtokyo.neurodesk.org/ - Try out the interactive build process and let us know if this works for you. Once you are more familiar with how we build containers, the manual process might be more efficient.
We are still working on improving how people can contribute new containers to our repository - so it would be wonderful to hear where things don't make sense yet and how the process could be improved!
Thank you so much
Steffen

Hi @stebo85,
Sorry for taking so long to reply. I tried the interactive build process, but it didn't let me choose a GPU node, so I went with the manual process.
I'm a bit stuck at the point of building relion, because I need to choose a CUDA toolkit version, and I also need to specify the GPU compute capabilities (assuming it's NVIDIA).
Is there a way to get those dynamically from the container before building? Because this would depend on the hardware of the system.
Thanks,
André

Hi @stebo85,
I've created this container for relion:
https://github.com/vennand/neurocontainers/tree/master/recipes/relion
The Cuda Toolkit seems to work, though I haven't tested with a dataset yet.
However, it doesn't seem like the "toolVersion" was replaced correctly in the README.md. I'm not sure if I've done something wrong.
When exiting the build process, it also tries to push it automatically to docker.io/vnmd/relion_4.0.1 , which I don't have permission to. To test it properly, I need to make sure the GUI launches technically, so it would probably be better if this step wasn't automatic.
I was wondering, is there a way to call other containers when building a container? Relion uses ctffind, motioncor2 and topaz, but they are all third party software that can be use independently. Is the best way to build all of them within the relion container, or can I create containers for them, and use them in the relion container?
Topaz would likely cause issues with relion in the same environment, since it needs it's own conda environment.

Dear @vennand,
Great to hear you are making progress :)
the toolVersion should be replaced in the README once it's building in our repository. You can just send a pull request. This will then build it and provide you with a command for testing the container and you can test if the GUI works. We are working on an interactive graphical build system that will allow to do all of this nicely, but right now, that's the best we can do.
Yes, you can call other containers from within containers! For this to work you need to install singularity and lmod in the container and the you can use the module system to call any other container. Here is an example where we do this: https://github.com/NeuroDesk/neurocontainers/blob/master/recipes/code/build.sh
from this example you need:
--install lmod \
--env GOPATH='$HOME'/go \
   --env PATH='$PATH':/usr/local/go/bin:'$PATH':${GOPATH}/bin \
   --run="wget https://dl.google.com/go/go$GO_VERSION.$OS-$ARCH.tar.gz \
    && tar -C /usr/local -xzvf go$GO_VERSION.$OS-$ARCH.tar.gz \
    && rm go$GO_VERSION.$OS-$ARCH.tar.gz \
    && mkdir -p $GOPATH/src/github.com/sylabs \
    && cd $GOPATH/src/github.com/sylabs \
    && wget https://github.com/sylabs/singularity/releases/download/v${SINGULARITY_VERSION}/singularity-ce-${SINGULARITY_VERSION}.tar.gz \
    && tar -xzvf singularity-ce-${SINGULARITY_VERSION}.tar.gz \
    && cd singularity-ce-${SINGULARITY_VERSION} \
    && ./mconfig --without-suid --prefix=/usr/local/singularity \
    && make -C builddir \
    && make -C builddir install \
    && cd .. \
    && rm -rf singularity-ce-${SINGULARITY_VERSION} \
    && rm -rf /usr/local/go $GOPATH \
    && ln -s /usr/local/singularity/bin/singularity /bin/" \
   --copy module.sh /usr/share/ \

the content of module.sh is:
trap "" 1 2 3

case "$0" in
    -bash|bash|*/bash) . /usr/share/lmod/6.6/init/bash ;;
       -ksh|ksh|*/ksh) . /usr/share/lmod/6.6/init/ksh ;;
       -zsh|zsh|*/zsh) . /usr/share/lmod/6.6/init/zsh ;;
          -sh|sh|*/sh) . /usr/share/lmod/6.6/init/sh ;;
                    *) . /usr/share/lmod/6.6/init/sh ;;  # default for scripts
esac

trap - 1 2 3

You might have to adjust the lmod version depending on your base operating system container version
I would go down the route of multiple containers if:

a software has conflicting dependencies
a software is useful for multiple other containers

Keen to see this working :)
Thank you
Steffen

Hi @stebo85,
I'm not sure I understand how to use this. So let's say I want to create a container for Topaz, so I can use it in relion. In the Topaz container, I need to install lmod and singularity? Can I use the module.sh file as is?
After that, how to I call Topaz in the relion container? For relion, I would need to set an environment variable that points to the Topaz executable. Would this work then?
--env RELION_TOPAZ_EXECUTABLE=/usr/local/topaz/latest/topaz
Thanks,
André

Dear @vennand
you don't need to install singularity and lmod in the Topaz container - only in the relion container (so the container that calls other containers). You should be able to use the module.sh file as is, but check that the lmod version fits with your base image version - otherwise adjust the version number.
the variable for RELION_TOPAZ_EXECUTABLE is a bit tricky and you need to try what works there, a few options:

the easiest would be if you can run module load topaz/version and then topaz will just be on the path - maybe you can leave the variable empty and it first tries to find topaz on the path?
if 1) doesn't work then you could create a wrapper script that does this and store it for example under /usr/local/topaz/latest/topaz
this wrapper script then contains something like:

module load Topaz/x.x.x
topaz "$@"

Then you can set the variable to this and it might work:
--env RELION_TOPAZ_EXECUTABLE=/usr/local/topaz/latest/topaz
Let me know how you go with this :)
Thank you
Steffen

Hi @stebo85,
Thanks for the instructions! I think it's going well so far.
Quick questions, would you recommend to install other software under /usr/local/ or /opt/ ?
I'll create a separate container for Topaz, but it seems like it's not necessary for motioncor2 and ctffind. So at the moment, I'm installing under /usr/local/ctffind/4.1.14 and /usr/local/motioncor2/1.6.4
Thanks,
André

It doesn’t matter where you install other software in the container :) I prefer /opt - but as long as the binaries are on the path variable it will work

Hi @stebo85,
I've made a pull requests for relion and topaz. I'm assuming the next step is to test it with a GUI, on a machine with a GPU ideally?
Also, side note, is it possible to create containers for software with licenses? Could be a dongle server or network license?
Thanks,
André

ok, great I merge that.
Yes, once the container is built you get a command for testing the container.
Dongles are difficult but network licenses would work

Topaz worked and you can test:
https://github.com/NeuroDesk/neurocontainers/issues/613
Relion failed with:
[ 9/20] RUN git clone 'https://github.com/3dem/relion.git' --branch=4.0.1	        && cd relion && mkdir build && cd build		        && cmake -DCUDA_ARCH= -DCUDA_TOOLKIT_ROOT_DIR=/usr/local/cuda-11.8 -DCMAKE_INSTALL_PREFIX=/opt/relion-4.0.1/ -DFORCE_OWN_FLTK=ON ..	        && make && make install:
#16 145.5 [  3%] Building NVCC (Device) object src/apps/CMakeFiles/relion_jaz_gpu_util.dir//jaz/cuda/relion_jaz_gpu_util_generated_test00.cu.o
#16 145.6 nvcc fatal   : Value 'sm_' is not defined for option 'gpu-architecture'
#16 145.6 CMake Error at relion_jaz_gpu_util_generated_test00.cu.o.Release.cmake:220 (message):
#16 145.6   Error generating
#16 145.6   /tmp/relion/build/src/apps/CMakeFiles/relion_jaz_gpu_util.dir//jaz/cuda/./relion_jaz_gpu_util_generated_test00.cu.o
#16 145.6
#16 145.6
#16 145.6 make[2]: *** [src/apps/CMakeFiles/relion_jaz_gpu_util.dir/build.make:77: src/apps/CMakeFiles/relion_jaz_gpu_util.dir/__/jaz/cuda/relion_jaz_gpu_util_generated_test00.cu.o] Error 1
#16 145.6 make[1]: *** [CMakeFiles/Makefile2:460: src/apps/CMakeFiles/relion_jaz_gpu_util.dir/all] Error 2
#16 145.6 make: *** [Makefile:136: all] Error 2

Does the machine have a GPU driver installed? It need nvidia-smi, otherwise the environment variable COMPUTE_CAPABILITY will come back empty.
Should I try to add some conditions, so that if COMPUTE_CAPABILITY is empty, it'll compile for CPU only (without -DCUDA_ARCH=${COMPUTE_CAPABILITY})? Though a relion without GPU won't be very appealing to users...

Dear @vennand - no, the build server doesn't have a GPU - do you really need a GPU to build it? Can't you just set this variable explicitly?

I need to specify the architecture of the GPU the container will run on, so I can't set it explicitly. For example, I'm testing it on a Telsa P40, which has a compute capability of 6.1, but new GPUs like an RTX 4090 has 8.5. It affects which binaries the software uses to compile. It'll throw errors when we try to use it otherwise.
Anyway, I'll try to find a work-around with if/else statements inline.

It would need 3 specific containers for each. You could encode this through the toolVersion. Can you build a container with compute capability 6.1, 8.5 and CPU only?

I added this instead, seems to work with my testing. Could that cause issues in the future with how NeuroDesk is coded?
&& if [[ -z '${COMPUTE_CAPABILITY}' ]] \        ;  then cmake -DCMAKE_INSTALL_PREFIX=/opt/${toolName}-${toolVersion}/ -DFORCE_OWN_FLTK=ON .. # RELION: If there is no NVIDIA driver installed, compile without GPU \        ;  else cmake -DCUDA_ARCH=${COMPUTE_CAPABILITY} -DCUDA_TOOLKIT_ROOT_DIR=/usr/local/cuda-11.8 -DCMAKE_INSTALL_PREFIX=/opt/${toolName}-${toolVersion}/ -DFORCE_OWN_FLTK=ON .. ; fi # RELION: Otherwise, compile with GPU architecture and CUDA version \

I think I don't understand how containers work then. I assumed they would be built on each machine, to install them. Is it that once they are built by the test server, they are used as is? I'd have to test on a machine without GPU, but I suspect the compile process of relion checks for a NVIDIA driver, and may compile for CPU only even if I specify an architecture.
I can make a container for each compute capability, but that would make 16 containers (from 3.5 to 9.0), plus CPU only

Do you have an example of containers using different toolVersions? Do I have to create new recipe directories?

We don't have a tool yet that needs that. I think it would be easiest for now to push different versions of the build.sh file to the repository and see if this actually works. Then we can see how to streamline this.


Rig cannot connect

ZEC:  Stratum  -  connecting  to  '139.162..'  <139.162..>  port  3032
ZEC:  Stratum  -  Connected  (139.162..:3032)
Pool  sets  new  share  target:  0x006e5846  (diff:  593H)
ZEC:  Share  rejected  (120328  ms)!
ZEC:  Authorization  failed
:  {"id":2,"result":false,"error":null}

Can you post some of the debug from the server too? My initial thoughts are that maybe the username isn't a valid t_address.

To find the reason,   works can not bring name.
t1d2VRQHwM8kRyHzfzf29cg7kuSE1dU5fWe.A01

Pool Hashrate display is not correct. 877H/s pool display 209M.

Can you post what it is after about 20 minutes of running? It should normalize after awhile. Thanks!


Issue with only seeing red border

So I have an exact issue as this guy: http://stackoverflow.com/questions/34897521/react-native-android-calendar-wont-load
I'm using react 0.19.0.
I'm also not sure about where to override the onCreate method. There is in fact a MainActivity.java but there is no onCreate method inside yet. I've just put the whole chunk of code inside for now.
edit: console throws this:

W/ReactNativeJS( 3598): Warning: Native component for "Calendar" does not exist

Help would be appreciated,
Sincerely, Jan

This is due to the breaking change that was not mentioned in react-native 0.19.0 release.
@Janckk Please refer to the new README, I've added the section for react-native 0.19.0+


Added lpg engine

Added lpg to engines

Codecov Report
Base: 89.55% // Head: 89.55% // No change to project coverage :thumbsup:

Coverage data is based on head (b73a9e7) compared to base (e0f04ec).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #173   +/-   ##
=======================================
  Coverage   89.55%   89.55%
=======================================
  Files         141      141
  Lines       17170    17170
=======================================
  Hits        15376    15376
  Misses       1794     1794

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

hi @alvalentini, i have update the old pull request merging with the main.


[INF-1630] use m1 resource class

📲 What
Updates the CircleCI config to use the M1 resources instead of x86.

Additionally, at the moment Apollo only targets x86 so this also installs Rosetta in CI

🤔 Why
CircleCI is retiring the MacOS x86 resource types.
👀 See

CirleCI m1 resource class
CirleCI orb for installing Rosetta

Also note there is a performance improvement, but also a cost increase with moving to M1. The cost is ~2x the x86 cost.

Before 🐛
After 🦋
What

avg 55 min
31 min
Total build time

@talaris It looks like there might be an extra commit pulled in here (cfed005)

I believe that was pushed onto the branch to try and fix the apollo errors. I can rebase it out if we don't want it.

@talaris Whoops, you're right! Pardon me 😅


[zh-cn]Translate Chinese version for  blog/2022/08/11/enhancing-kubernetes-one-kep-at-a-time

This is a Feature Request
This page blog/2022/08/11/enhancing-kubernetes-one-kep-at-a-time.md has no Chinese version
What would you like to be added
Translate Chinese version for  blog/2022/08/11/enhancing-kubernetes-one-kep-at-a-time
Comments
/language zh
/assign

/triage accepted

/close
closed by #35886


Add xarray-leaflet to the visualization projects

Fantastic @davidbrochart - thanks for sharing!

Really nice to see more integration between xarray and ipyleaflet!

@benbovy it's this comment of yours that convinced me it was a good idea, so thank you!


[UAT] Update redirects sheet

Update redirects sheet to reflect on the right URLs for stories and tips articles (in /en and /ms)

@asthabh23
Noticed an issue with the story page listing on MS language, The live site sitemap has 10 story pages for MS, all 10 links are accessible, but the actual story page shows only 6 story
It means, 4 story pages are not listed, but actually exist

@asthabh23 The redirect sheet is up to date now. Please validate it.

looks good!


Local resources/images are not always properly resolved

and its specifications

May I suggest changing the issue title to Local resources/images are not always properly resolved? Suggesting that because that's the main issue regarding the dir paths, both checkers (MissingLocalResourcesCheck and MissingImageFilesChecker) might not always resolve the links correctly, for example, all the following files exist yet they are reported as missing:
Missing Local Images Check
2 img src attributes checked, 2 missing image files found.

    image "../images/16/101grey.png" missing
    image "../images/16/101.png" missing

Missing Local Resources Check
4 anchor tag href attribute checked, 4 missing local resources found.

    local resource "../../../start/concepts/scope.html" missing
    local resource "../../../start/concepts/pscan.html" missing
    local resource "../../overview.html" missing
    local resource "options.html" missing

I already have a fix locally but still working in progress, I will push it sooner to gather feedback though.

thanx, you're right.
btw - I'm Gernot from Cologne, do you mind telling me who you are?

Pull request opened: #213, let me know what you think.

just tested (successfully) and merged - thanx!


why there are not file "decoder_fn.py"

why there are not file "decoder_fn.py",which mention in the tensorflow website(https://www.tensorflow.org/api_docs/python/tf/contrib/seq2seq/simple_decoder_fn_inference).

Apologies, the website generator is incorrectly linking to the master branch when in this case it should be linking to the latest release: https://github.com/tensorflow/tensorflow/blob/r1.0/tensorflow/contrib/seq2seq/python/ops/decoder_fn.py
@wolffg is in the process of fixing the website generator so that it links to code in the appropriate release branch.


MGDCTRS-1649: update the edit and review step

Updated the Review page
Added the description in the Edit flow
Added the storybook

This is some great refactoring, nice work! I just had one request.

Incorporated the change request


[docs] Remove recompose/compose

[x] I have followed (at least) the PR section of the contributing guide.

https://github.com/mui-org/material-ui/pull/14413#issuecomment-460697323

@mbrookes I was explaining the rationale for somebody wondering about the why.

I'll update it for the one recently added #14413, although those will go away with Context...


Dgvoodoo changes

Hopefully this is correct.

changes are good. will pull from your repo and submit to :dev: manually since github is having a stroke

Manually fixed! Closing. Thank you mats.


Increment localstack version

:loudspeaker: Type of change

[ ] Bugfix
[ ] New feature
[x] Enhancement
[ ] Refactoring

:scroll: Description
Increments the local stack version for better integration
:green_heart: How did you test it?
Yes
:pencil: Checklist

[ ] I reviewed submitted code
[ ] I added tests to verify changes
[ ] I updated reference documentation to reflect the change
[ ] All tests passing
[ ] No breaking changes

:crystal_ball: Next steps

Thanks.It should be also done for all the integration tests. Would you like to update it too?

Thanks.It should be also done for all the integration tests. Would you like to update it too?

Sure I will

@maciejwalkowiak , Shouldn't we change it to localstack:localstack so that always the latest one is pulled instead of changing the version for every increment?

@rajadilipkolli not really it's better to rely on exact versions.

Tests are failing now though so likely there is something to fix.


Node.js Getting Error when saving session in database in Sails.js using sails-mongo module?

i have gone through the sails doc http://sailsjs.org/documentation/reference/configuration/sails-config-session db configuration is
adapter: 'sails-mongo',
host: 'localhost',
port: 27017,
db: 'sails',
collection: 'sessions',
Getting error -->
A hook (session) failed to load! error: Could not load Connect session adapter :: sails-mongo installed "sails-mongo" by using npm install sails-mongo

Hey @kuldeepmobinett, would you try:
npm install<EMAIL_ADDRESS>--save --force

And then restart your server and give it a go?  If that solves it for you, please come back here, give us the thumbs up and close the issue.  If that doesn't do the trick, please provide some more information about the version of node, NPM, and Sails that you're currently using (see https://github.com/balderdashy/sails/blob/master/CONTRIBUTING.md#ii-issue-contributions for details)
Thanks!

@kuldeepmobinett wow- just realized there is a typo in our docs, sorry about that!  Should say connect-mongo (not sails-mongo).  This is my bad; I recently updated the docs to reflect the appropriate version and ended up with a copy/paste error.
I also noticed you'll want to change your adapter config to 'connect-mongo' or mongo (instead of "sails-mongo").  Hope that helps!

Just updated the docs -- will redeploy shortly!  (https://github.com/balderdashy/sails-docs/commit/6f74633578b9f47ca9a7e85b0cd686637f88d9e6)

i was trying to install "npm install<EMAIL_ADDRESS>--save --force"
I sure hope you know what you are doing.
npm ERR! Linux 3.19.0-31-generic
npm ERR! argv "node" "/usr/local/bin/npm" "install"<EMAIL_ADDRESS>"--save" "--force"
npm ERR! node v0.10.25
npm ERR! npm  v3.3.8
npm ERR! No compatible version found<EMAIL_ADDRESS>npm ERR! Valid install targets:
npm ERR! ["0.12.0","0.11.7","0.11.6","0.11.5","0.11.4","0.11.3","0.11.2","0.11.1","0.11.0","0.10.9","0.10.8","0.10.6","0.10.5","0.10.4","0.10.3","0.10.2","0.10.1","0.10.0-rc5","0.10.0-rc4","0.10.0-rc3","0.10.0-rc2","0.10.0-rc1","0.9.8","0.9.7","0.9.6","0.9.5","0.9.4","0.9.3","0.9.2","0.9.1","0.9.0","0.0.3","0.0.2","0.0.1"]
npm ERR!
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     https://github.com/npm/npm/issues
npm ERR! Please include the following file with any support request:

@kuldeepmobinett another doc mistake, sorry!  That should say 1.1.0  See https://github.com/balderdashy/sails/issues/3486#issuecomment-172649454 for more info.  Fixing the docs now.

npm install<EMAIL_ADDRESS>--save --force

@kuldeepmobinett I'm going to go ahead and close this as resolved-- please open a new issue and link back here if you see any other related problems.  Thank you!

Still facing same problem


test(core): use a cloak.yaml without extensions to speedup core integration test

Just a test to see if we can improve test run

tried more and dug deeper, using the same strategy here
Nothing really ground breaking.
I'm closing.


feat(api): templates.json endpoint

/api/templates.json to get the templates

Improved the content so you can have the url of the screenshot and normalized content :)

Nice!! thanks


Can the sshd parameter display the automatically generated host key fingerprint at startup?

SHA-256 or MD5 are both acceptable

what is the use case?

It is convenient for SSH clients to specify the hostkeyfp parameter for unmanned connections. Many SSH clients have this feature, so there is no need to specify a file.


Subscription Filter Subject Matching

Overview
Ensure filter subject matching when creating subscriptions is consistent.
Filter subject matching is required when a subscription is requested against an existing durable.
Glossary
SubscribeSubject - The subject used in the api call for subscription.
FilterSubject - The filter subject as set in the existing consumer. null, empty, undefined and '>' are all identical
StreamSubject - The subject for the corresponding stream. Is null/empty/undefined when the stream contains more than 1 subject and therefore cannot match.
Clients and Tools

[ ] Go @piotrpio
[x] Java @scottf
[ ] JavaScript @aricart
[x] .Net @ColinSullivan1 @scottf
[ ] C @kozlovic
[ ] Python @wallyqs
[ ] Ruby @wallyqs
[ ] Rust @Jarema

Implementation Example
isFilterMatch(subscribeSubject string, filterSubject string, streamName string) returns boolean
{
    // subscribeSubject guaranteed to not be null / empty / undefined
    // filterSubject may be null / empty / undefined or have value

    if (subscribeSubject is exactly equal to filterSubject) {
        return true
    }

    if (filterSubject is null or empty or undefined or equals ">") {
        // lookup stream subject returns null if there is not exactly one subject
        streamSubject = lookupStreamSubject(streamName)
        return (subscribeSubject is exactly equal to streamSubject)
    }

    return false
}

lookupStreamSubject(streamName string) returns string may be null / empty / undefined
{
    1. get StreamInfo for stream name
    2. if stream has more than 1 subject return null / empty / undefined
    3. else return the one subject
}

Unit Tests

Create a stream with the Stream Subject(s)
Create a push durable with the Filter Subject
Try to subscribe with the Subscribe Subject + durable name (not bind)

Stream Subject(s)
Filter Subject
Subscribe Subject
Match
Notes

foo, bar

one subject

foo
foo
Yes
FS equals SS

">"
">"
Yes
"

"*"
"*"
Yes
"

""
foo
Yes
SS != empty FS, but stream has exactly 1 subject and is a match.

">"
foo
Yes
SS != FS of '>' but stream has exactly 1 subject and '>' matches.

"*"
foo
No

foo, bar

multiple subjects no wildcards

foo
foo
Yes
FS equals SS

">"
">"
Yes
"

"*"
"*"
Yes
"

""
foo
No

">"
foo
No

"*"
foo
No

foo.>

multiple subjects via '>'

foo.A
foo.A
Yes
FS equals SS

">"
">"
Yes
FS equals SS

""
foo.A
No

">"
foo.A
No

foo_GT
foo.A
No

foo.*

multiple subjects via '*'

foo.A
foo.A
Yes
FS equals SS

">"
">"
Yes
FS equals SS

""
foo.A
No

">"
foo.A
No

foo_STAR
foo.A
No

Other Tasks

[x] Update client features spreadsheet

Client authors please update with your progress. If you open issues in your own repositories as a result of this request, please link them to this one by pasting the issue URL in a comment or main issue description.

This will be a non-issue  in JS Simplification.


Support Jetbrains IDE?

I commenly use IDEA to code front end and back end.
It helps me a lot if common-intellisense can support IDEA.

I only use vsc, if anyone is interested, welcome to pr


"No diff structure found in" with non-utf8 encodings

Thanks for making this extension!
It looks like this extension will only work with files encoded with utf8. If you use a different type it will say, "No diff structure found in (file)". I had to resave my file with UTF-8 in order to see the custom view.
I'm not very familiar with extension development but it seems like this section of code in DiffDocument.ts would need to detect the appropriate Decoder before it sets up the DiffDocument. I'm not sure off-hand how to do that. I'll see if I can find out.

Hi @domgenv, thanks for bringing this up!
Would you mind sharing a file where this behavior is reproducible?

Sure, no problem! It looks like github won't accept a file with .diff so I added .txt at the end. In VSCode it shows the file has encoding "UTF-16 LE".
changes.diff.txt

Hi, do you have any updates regarding this issue? It seems that still have the problems with files with other encodings.

Hi @Cussa, the issue hasn't been fixed yet. Feel free to send a PR :)

Fixed on v1.2.0


Unexpected Behavior with Sound Attenuation

Basic Info:
I've set up the plugin correctly (default version, not MetaSound) and it works as expected when playing 2D Sound. The issue I'm having is trying to play the imported Audio using an Audio Component with attenuation enabled. As soon as the player goes outside of the attenuation distance. The played sound stops playback because the Virtualization Mode seems to be disabled by default?
The Issue:
Audio Attenuation in UE is a bit annoying and requires you to set the Virtualization Mode setting to "Play when Silent" inside an editor sound wave file's properties but since I'm using imported Audio. I cannot modify that parameter in runtime.
A quick fix or workaround would be much appreciated!
The Setup:

Thanks for letting me know! This should now be fixed. Once the sound is imported, you can call SetVirtualizationMode with PlayWhenSilent selected, and the sound will continue to play back when the player goes outside the zone of attenuation and comes back inside again. Please reopen the issue if you have any related problems.

Thanks for letting me know! This should now be fixed. Once the sound is imported, you can call SetVirtualizationMode with PlayWhenSilent selected, and the sound will continue to play back when the player goes outside the zone of attenuation and comes back inside again. Please reopen the issue if you have any related problems.

Thank you so much for the quick fix! I'm not familiar with the release cycles. I would appreciate if you could give me an estimated date for when they happen here and on the Epic Games Store as well.
Also might be worth noting that the same should exist for MetaSounds since there seem to be 2 implementations of your amazing plugin. :)

Thank you very much for your feedback! :)
This update should already be available on the Marketplace for both the regular and MetaSounds-specific versions. I usually announce all changes in the Discord chat here, so if you'd like, feel free to join and you’ll receive updates in the announcement channel :)


Assign test owners to $default as a fallback. Pick a random owner if there are multiple options.

See also: kubernetes/kubernetes#29564

LGTM


Add easy way to install thought as a git-precommit-hook

This should be a command-line parameter or something like that. Documentation updates should run before each commit. It would be great if it could be integrated into the package.json such that it is installed when the developer calls npm install but not on each install, maybe on prepublish.

Not on todo-list anymore


Allow custom semantic segmentation tags

Our current semantic segmentation tags are limited to 12 classes. The system works by checking the file path of every mesh, and if the 3rd folder matches the name of one of our tags we tag it.
It would be nice if this was based on some config file (JSON?) that it's loaded at runtime, perhaps using regular expressions to match the path and filename.

@marcgpuig do we have a limitation of 12 classes? My understanding is that we could have an arbitrary number of classes. Could you please confirm?

@germanros1987 no, we support a total of 255 possible classes limited by UE4. However, these classes are limited in compile time, so no more classes can be created nor modified from the PythonAPI, and I think this is what the issue is referring to.


fix tab order for conversation buttons.

sort the data, not the UI. buttons are now tab-able from the top down.
before:
https://user-images.githubusercontent.com/5056972/227753230-6802113a-f0d3-4320-851c-80f4e94d1948.mp4
after:
https://user-images.githubusercontent.com/5056972/227753234-0ee18648-8a44-4d9f-a327-487c99535202.mp4
fixes #175

great ux add!


Unblock ActiveSession

Describe the feature
Extend pattern for unblocking futures/streams used in TransactionsManager (among others)  to ActiveSession.
https://github.com/paradigmxyz/reth/pull/6590#issuecomment-1976570628
Additional context
No response

@emhane Have you started working on this? If not, I'd like to fix it :)

Yes, I found it too. It seems that the existing process cannot be simply applied :)

this type already has preemption budget for incoming messages
https://github.com/paradigmxyz/reth/blob/d2010d5d25a2fb98699c00418070304348107699/crates/net/network/src/session/active.rs#L571-L579


Bug: Test CastErrorPreviousBlockNotFinished  sometimes fail

Kùzu version
master
What operating system are you using?
No response
What happened?
The test exceptions~copy~invalid_row.CastErrorPreviousBlockNotFinished sometimes fails (I've only seen it fail in the code coverage job).
Sample job: https://github.com/kuzudb/kuzu/actions/runs/11859827652/job/33053818505
Are there known steps to reproduce?
No response

fixed by https://github.com/kuzudb/kuzu/pull/4601


boards/x86: Use right GPIO names for CC2520

GPIO_QMSI_<0/1>_NAME are now generated through DTS. Until CC2520
settings are generated through Kconfig, let's use direct gpio names
instead.
Fixes #8086
Signed-off-by: Tomasz Bursztyka<EMAIL_ADDRESS>

Codecov Report

Merging #8151 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8151   +/-   ##
=======================================
  Coverage   64.54%   64.54%
=======================================
  Files         420      420
  Lines       40142    40142
  Branches     6765     6765
=======================================
  Hits        25911    25911
  Misses      11110    11110
  Partials     3121     3121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a88a986...497f63a. Read the comment docs.

GPIO_QMSI_<0/1>_NAME are now generated through DTS. Until CC2520
settings are generated through Kconfig, let's use direct gpio names
instead.

Do you mean "Until CC2520 settings are generated through DTS"?

Do you mean "Until CC2520 settings are generated through DTS"?

fixed that for @tbursztyka  :)
and added another commit to fix #8086 proper


Adds test with http over IPv6

and absence of anomalies
Requires libhtp PR https://github.com/OISF/libhtp/pull/329

This test passes w/o the libhtp PR. Does it test what it should?

Indeed, every OS defines its own AF_INET6
cf https://github.com/wireshark/wireshark/blob/eb5f4eea99593b92298bacecc5c9d885cc13a9ad/epan/dissectors/packet-null.c#L46

Needs backport of OISF/suricata@27b4f16 @jlucovsky @inashivb should we have a specific ticket for this ?

Yes

Backport still required?

Backport still required?

Backport tickets are already made:
https://redmine.openinfosecfoundation.org/issues/4793
https://redmine.openinfosecfoundation.org/issues/4794 (PR https://github.com/OISF/suricata/pull/6543)

Backport still required?

Backport tickets are already made: https://redmine.openinfosecfoundation.org/issues/4793 https://redmine.openinfosecfoundation.org/issues/4794 (PR OISF/suricata#6543)

I see these just got merged, so rebased and force-pushed to get CI running again

Merged. Thanks!


Providing the getGeometriesArray() and setGeometriesArray() methods in the public API

On the ol/geom/GeometryCollection class instance,  it is possible to call the getGeometriesArray() and setGeometriesArray() methods but there is no word about them in the documentation. Please add them to the public API and documentation.
Without the getGeometriesArray() method, it is impossible to get the original geometry passed to the constructor and requires keeping references to them in the properties (set() / setProperties()) because getGeometries() returns clones and not originals.

Can I make a pull request?

I think it would make sense to revisit why we return clones in getGeometries(). If there is no reason for that, I'd be in favor of returning the original geometries, also because of the convenience that they could be modified independently.

That said, if you want to create a pull request, make sure you add test cases that cover modifying the geometries and making sure the GeometryCollection gets notified of the changes in its geometries.


<IP_ADDRESS> export of assessment based on own module not working

🐛 Bug Report
A clear and concise description of what the bug is.
To Reproduce

build own module (no question list needed)

start assessment based on this module

try to export assessment
--> error 500

tried uninstall / new installation

tried installation and running with admin rights

tried with <IP_ADDRESS> --> working as expected

Expected behavior
export assessment as *.csetw
Any helpful log output

No longer an issue in newer builds.


fix CI setup

I've managed to get the CI setup done. As you can see, all tests are currently failing (even including some syntax errors), but this PR aims to highlight the problems that #284 is set to fix.


Write SkyLibResourcesProvider to be used for library i18n

This is not unit tested yet. I want to make sure the approach is correct.
SKY UX I18N PR: https://github.com/blackbaud/skyux-i18n/pull/12
SKY UX Lookup PR (implementation demo): https://github.com/blackbaud/skyux-lookup/pull/3

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master     #2   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           2      2
  Lines          21     42   +21
  Branches        3      3
=====================================
+ Hits           21     42   +21

Impacted Files
Coverage Δ

src/plugin.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee9ee16...da57b04. Read the comment docs.


Feature/improve csvfile

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master     #9   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           3      3
  Lines         102    100    -2
=====================================
- Hits          102    100    -2

Impacted Files
Coverage Δ

easyfile/core.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 392994a...f911317. Read the comment docs.


IDENTITY-6811: Invoke csrf token injecting js from my login sessions gadget

@malithie can you make sure this is merged ?


chore: bump msgraph to v1.45.0

fix #1369
Reason for Change:

Requirements

[ ] squashed commits
[ ] included documentation
[ ] added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

[ ] yes
[ ] no

Notes for Reviewers:

@guilhem could you rebase to resolve conflicts?

Done @aramase

/azp run

/azp run


I have changed all the requirements to 1 as they should be according to discords docs…

https://github.com/Discord-Net-Labs/Discord.Net-Labs/issues/122
I have done what has been asked in the issue.

Duplicate of #142
Closing this one was the other one is more complete.


Fix distribution location issue

Purpose

Fix distribution location issue

Codecov Report

Merging #18175 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #18175   +/-   ##
=======================================
  Coverage   15.08%   15.08%
=======================================
  Files          48       48
  Lines        1246     1246
  Branches      192      192
=======================================
  Hits          188      188
  Misses       1044     1044
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c98604...a11e021. Read the comment docs.


Update API to V2

Update the various API Endpoints, /users and /posts
Improve security on API, improve API error/status codes
Depreciate /images API

Continue to add unit tests for V2


Fixed #35837 -- Added missing alters_data=True to QuerySet and UserManager methods.

Trac ticket number

ticket-35837
Branch description
Provide a concise overview of the issue or rationale behind the proposed changes.
Checklist

[x] This PR targets the main branch.
[x] The commit message is written in past tense, mentions the ticket number, and ends with a period.
[x] I have checked the "Has patch" ticket flag in the Trac system.
[x] I have added or updated relevant tests.
[ ] I have added or updated relevant docs, including release notes if applicable.
[ ] I have attached screenshots in both light and dark modes for any UI changes.

Thank you for the review :star:


Make zunit init idempotent

Currently, running zunit init fails if either .zunit.yml or the
directory tests exists within the repository, meaning the default
.travis.yml cannot be generated. This commit checks for the existence
of .zunit.yml, tests and .travis.yml as before, but instead of
exiting with an error, raises a warning and continues.
Fixes #88

It isn't technically needed, it's just a hangover from when I was polyfilling the dependency when I first started writing ZUNIT. I've left it there for now for consistency, but truthfully we could remove echo before color right across the application in another PR

Makes sense to me. No need to dirty this PR with additional refactoring ;)


feat: change yurt-manager ClusterRoleBinding name

What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #1350
Special notes for your reviewer:

@kadisi
Does this PR introduce a user-facing change?

other Note

/lgtm


ABI checker: report any printed name changes for type nodes

Under ABI checking mode where we don't have sugar types, any printed name
changes of type nodes worth raising an alert.
rdar://45567621

@swift-ci please smoke test

This change allows us to detect one more suspicious change from stdlib:
Func BidirectionalCollection.difference(from:by:) has parameter 1 type change from (τ_0_0.Element, τ_1_0.Element) -> Bool to (τ_1_0.Element, τ_0_0.Element) -> Bool

Maybe we have swapped the positions of generic parameters? cc: @airspeedswift @lorentey


Update README.md

Bolding markdown fixed (row 347).
There seems to be another one on row 351, but not sure what was in bold in the original text.

thank you for the small fix!


UI Upgrade

resolves #389
Figma Link: https://www.figma.com/file/HzfMOKyPaKVVDN7OEKGfgs/SMART-phase-2?type=design&node-id=0-1&mode=design
Back-end Modifications:

model_run.py View - get_proposals_query was modified to get_model_run_details.  This is needed to provide additional context to getting the siteList for a model-run.  Mainly we need the title of the model-run and region information to display the site Ids (The KR_R001_0001, not the UUID) properly.

Also added were a get_proposals and get_sites endpoints for model-runs.  This provides a list of all the sites/proposals in a model-run so we can have a persistent list of sites displayed.

site.py View - Added in a get_site_query to provide information about a single site for updating it when necessary.  This could after annotations had been changed.
satellite_fetching.py View - new view to return an array of Site UUIDs that are still in the running state.  There could be arguments for me to make the single endpoint there more expansive (allowing checking more than Running states).  This allows a single request to be used in a polling interval to determine which sites are still downloading data.

Front-End Modifications:

Upgraded Vuetify and the vite-vuetify plugin
Time Slider UI modified
Sidebar Buttons modified (toggling Roads, Maps other settings)
Layer selection buttons/checkbox modified based in figma
ModelRun Details modified for proposal and RGD view
Map Legend Modified to a standalone box that is dismissable in the upper right
When selecting model runs now all sites are listed for that model-run or multiple model-runs
Bunch of Renaming of Types and variables.  I previously before I had an understanding labeled a lot of things as SiteObservation when really they were more like SiteOverview I also has a similar thing with enabledSiteObservations when really it was enabledSiteImages.  Hopefully a bunch of that is cleaned up now.
While SiteCardList.vue is used in the normal view a separate AnnotationList is used for the proposal view (We will probably change the name and path to annotations in the future).  This is done because proposals need to be handled slightly differently than the standard sites in the main view.  While it utilizes the same SiteListCard it uses the AnnotationList to manage them.

Control+Hovering over a site in the map allows the list to scroll to the position of that site
Selecting a site will automatically move it to the top of the list and also scroll your list to the top
You can have multiple sites selected at once and they move to the top of the list

Site Card is unified between Proposal and regular views.  Looks very similar with some differences in displaying

Proposals don't enable the ImageBrowser (controls for next/previous image)
Proposals are single select because only a single one can be visible at a time
Proposals have a source file copy button (indicates the source kml for the proposal)
ImageToggle.vue handles the toggling of images on/off and provides a hover context menu to open the imageViewer or to open ImageViewer in a new tab

I've modified the ImageViewer so that in the regular view it is no longer a dialog but a panel on the bottom of the screen
Store.ts

Added a selectedImageSite to the store.  Previously selecting a site was managed between components I moved all that logic into the store to simplify it.  Further down when talking about the main views and data passing you'll see where I removed this logic in the AnnotationViewer.vue and the RGD.vue components
Moved the updateCameraBoundsBasedonModelRuns into the root of the store as a function that is shared by multiple components.  It was previously attached ModelRunList.vue but is needed in a few places.

Main Views (RGD.vue and AnnotationViewer.vue

There was logic in there to handle selecting image sites and displaying them.  It involved some message passing between the components.  I've modified that to a single selectedImageSite within the store instead of having this passing logic.

Items Left for another PR:

ImageViewer UI update.  ImageViewer needs to be rearranged and modified to look like the figma
HoverState - The hover items need to be turned into a table
HoverStateConfiguration - provide a way to configure the hover table to remove or add elements
Settings Panel - UI should probably be updated for the Settings Panel
Download Scoring JSON - I disable downloading of scoring JSON because we don't have the implemented on the back-end I can push this off or try to implement it in a new PR.

Bryon's Internal TODO (You can ignore during review):

[x] Check downloading images in proposal view
[x] Checking downloading images in the RGD view
[x] Fix the single site endpoint to not use an array structure
[x] Need to determine what to do with the additional selection for the RGD view.  I.E selecting an individual site
[x] Confirm multiple modelRuns being selected for the RGD Site List will function properly
[x] Make it so hover scrolling is configurable instead of being on all the time (its annoying having it on full time).  Maybe a keyboard shortcut for it
[x] Scoring application may need to be modified so that it doesn't have to recursive queries across databases for the data that is needed.  Currently it would require going across all sites for an EvaluationRun and then querying the SiteImages and satellite fetching for each item in the list.  I don't think this can be done in a single queryset because it's across databases that have no direct relation to each other.
[x] Need to add in concept of selection for sites and how it will re-arrange the order so that selected sites are at the top
[x] Redo the site list so that there is a way to have the ability to toggle on/off the images for an individual site as well as advance through time.  This should hopefully eliminate the need for the right side bar
[x] The downloading update may need to be limited so that if you download all images for the site it isn't constantly requesting the endpoint for each site.  At that point it may make more sense to every 10-15 seconds just request the entire list again.
[x] Global selected site-image state for showing the current selected site-image.  This will require a redo to how the image-viewer opens.  Should also include moving the dialog view of the image viewer to a persistent bottom anchored item like in the proposal view.
[x] Add downloading of regular sites to the download button.
[x] Downloading SatelliteImages for multiple sites needs to be reconfigured so it doesn't constantly make a request for each site to determine if it's done if there are more than 5 active at the same time.  If there are more than 5 active it needs to refresh itself at the list level every 10-15 seconds instead of at the card level every 5 seconds.

I noticed something strange with the checkboxes on sites when testing this. Selecting a site by clicking it on the map doesn't fill the checkbox -

I believe the checkbox should get filled here? Unless I'm misunderstanding the UX

I believe the checkbox should get filled here? Unless I'm misunderstanding the UX

I had that on in the beginning and I don't remember why I turned it off.  Give me some time, I can easily turn it back on.

I believe the checkbox should get filled here? Unless I'm misunderstanding the UX

I redid the selection logic for the regular RGD viewer and the annotation viewer.
I also fixed the scrolling tool.  It was working before I switched over to utilize virtual scroll lists.  Added code to handle this so control + hover over sites will now scroll to the site in the list that is being hovered over.

Frontend code changes and the proposal view lgtm. Only thing I haven't reviewed/tested yet is the scoring app backend changes, my local scoring db got messed up so I have to repopulate that. I'll do that tomorrow and get a final review posted then.


Updated sqlite3 to version 3.10.2

RLGTM

I kept the "pointer to constant" C syntax that was already there, for instance const X * parameters. But the syntax should be const(X)* on the D side. I don't know what the policy is. Should I change this?

Auto-merge toggled on


Toward a centralized, flexible PWM resource coordination subsystem

Note
This PR is a workable branch, little bit behind latest px4/master (so all checks may fail), but as i imagine it will not be merged in short time so i need to rebase it anyway till then. You are welcome to comments on the new model and design, to see any improvements needed, and co-work if you are also interested.
If anyone would like to have a test flight you can find it here:
https://github.com/airmind/OpenMindPX
as its updated from time to time.
So far it is only tested on MindPX and MindRacer. Please let me know if you found any problem on other hardware (TAP-V1 probably broke on LED drivers, but it was not a correct implementation and needs to be fixed later anyway).
Describe problem solved by the proposed pull request
This PR starts the step towards a centralized while flexible PWM resource management system which introduce many interesting features.
Existing PWM subsystem majorly hand-wire pwm resource allocation like timers, channels, pin numbers, scattered in many different locations such as board configs, airframe config files, mixer files, or source codes, many of them hard-coded. This makes attempts to expand supported PWM devices quite difficult as one needs to manually settle all potential conflicts on resource usage.
This PR wants to build a centralized while flexible way to support as many kind of PWM devices as possible with only few simple runtime configurations needed through some kind of Human-Machine Interface(like from GUI of GCS).
Describe your preferred solution
A new model of PWM devices and a centralized resource management group of classes are defined to
achieve this goal. A detailed description of the model and design can be found here:
Design document

Some interesting features can be brought in by the new design. For example,

Camera trigger will not be limited on the first 6pins of main output. Pilot can use any free pins on Main/Aux port, if the first 6 pins all occupied, through few configuration of parameters.
A pilot that flys a hexa airframe, now can use the remaining 2 channels on Main port to drive an external PWM heater to heat any other components(not only the flight controller) on his vehicle, simply by selecting the pin number from GUI of GCS(needs further work).
in the meanwhile, he can still connect a set of external PWM LEDs to AUX channels, still through configuration of the pin numbers from GUI of GCS(needs further work).
He will not need to change the codes and compile to upload everytime he wants to change the task modules layout for different missions.

Additional context
@davids5 It will be very interesting to see the possibility of it to be combined with the hardware manifest work you initiated. I am expecting your co-work on it.
@dagar This PR is somewhat independent of the original PR #7208  and #8142 that separating the FMU from other 'flight management' tasks. I prefer that we pursuing that target in an other PR.
@DonLakeFlyer Ultimately all these configurations has to be done through GCS. I think this will need your help on QGC side, if you like it and are interested on helping it out.
@testflights I will be appreciate if you can help to test the PR. And i strongly recommend you have MindPX/MindRacer hardwares added into your testing package :-)
@mzahana I think you can have all 16 (8 main + 8 aux) channels on MindPX fully funtional and all VTOL frames available now. Pls let me know on any issue.  I think we're best off moving away from those as much as possible.

Thanks @mhkabir .
Indeed large chunk of legacy codes there in IOCTL. I don't want to touch these before we are ready to rework the entire man-machine interface.
The good thing is now we have a model to agree on so everyone gets a common standing ground and a clear picture where to go for.

@rolandash this was really needed. Thank you! I will review it in detail next week. Would you be able to join the dev call wednesday 8:00 PM PST and walk us through it?

@davids5 thank you and that's great!
Are you sure the dev call is 8PM PST? as in dev call calendar it seems to be 8AM PST.
I can do 8PM, but 8AM will be too late for me...
In latter case, I will be happy to discuss it on Slack (need someone invites me in though), or add more comments/documents where you need ...

@davids5 thank you and that's great!

Are you sure the dev call is 8PM PST? as in dev call calendar it seems to be 8AM PST.

My bad 8 AM.

I can do 8PM, but 8AM will be too late for me...

In latter case, I will be happy to discuss it on Slack (need someone invites me in though), or add more comments/documents where you need ...

We can plan a skype call with @dagar when it would work for you. What time zone are you in?

@davids5 thanks that will be nice.
I am in UTC+8, usually local time 11:00 ~ 21:00 is good for me. I am traveling till Wed next week. So sometime on Thursday or Friday would be great.
Please let me know if that suits your.

@dagar what time will work for you. I will fit it what works for both you and @rolandash

@rolandash could you please schedule something as late as possible for you either Thursday or Friday?
invite<EMAIL_ADDRESS>

I looked at the linked design document but that didn't really give me much of an idea as to what needs to happen in QGC either. So will need something I can understand to help out here.

@dagar will about 23:00 my local time work for you?

Thanks @DonLakeFlyer You are right that's not complete yet. Will let you know when more details come out.

@dagar will about 23:00 my local time work for you?

@rolandash - wouldn't that be 8AM PST which is when the dev call is? Is that time slot workable?

@davids5 @dagar Lets have the call on 23.00 Fri. my local time, i assume its better time for your guys.
I have added you on Skype @dagar
@davids5 would you please add me<EMAIL_ADDRESS>? Would you mind host the call?

@rolandash @dagar - I have added<EMAIL_ADDRESS>to skype and will place the call 8:00 AM PST on 9/28.

FMU breakup:
Safety https://github.com/PX4/Firmware/pull/10119

Multi module https://github.com/PX4/Firmware/tree/pr-module_base_multi

Document the io timer hierarch
Trigger
Servo
Capture

Make timers instanceable at run time.

CPP class them

@dagar the ECU
https://github.com/PX4/Firmware/blob/ea0941c24fb208184bf7feeeaae4648f5099f5aa/src/drivers/px4ecu/px4ecu.cpp

@davids5
I found out why i was hesitate on 'rgb_pwm_led' during the call.

MindPX has 8 main + 8 aux
the new Mindracer, has 8 main + 5 aux (exposed), and the remaining 3 pwm channels are used for rgb_pwm_led.
The problem is we want to use one single target (firmware) for both hardware(another target of this PR). This brings some extra issues in:
the channels aux port using has overlap with pwm led channels, it may interfere each other. Its not like in V5, as channels for pwm led are independent from other devices.
the rate that pwm led using has constrains on what rate aux port channels can use on new Mindracer hardware.
Of course, we still want rgb_pwm_led can also work properly on MindPX, where someone may want to use it at a different rate.
So these actually challenges on:
can a pwm device share part of its channels with another device to maximum resource util?
2.can a pwm device select the most available rate to work with the resources available instead of wasting them?

These explains where the ideas of channel conflict/rate conflict checking coming from. Sorry i forgot these during the call as they were buried under many design threads back few months ago, but it is important.
This is actually a quite typical example what the problems we will encounter when we try to add a new pwm device into existing PX4 system, not limited to pwm led only.
Instance-able FMU/ECU, and timers are great and we should work on that, but may be not enough to solve the problems, e.g., we can make main & aux run on main processor, but a 6-output aux mixer may break the pwm led on new Mindracer. And these are what i try to address in PwmGroups class in this PR.
Part of the implementation needs to be in UI side, but in flight controller side there will be structures need to support the concept.
Hope you will take this into account when we move forward. @dagar
This is the link of  MindPX/new Mindracer pinout map
Please let me know if you need further discussions.

Another question about if a pwm device can use channel across the boarder of main and aux port, on another thought it probably be feasible based on current design(depends on how we revise some existing limits), though pilots may not intend to do that by intuition. But technically its an option we can turn it on or off.

@rolandash @dagar - here is what we have
io_timer-asbuilt.pdf
The led pwm and pwm_trigger are more or less copies.  The drv_pwm_servo and drv_input_capture are lend themselves to hierarchical model.  led pwm and pwm_trigger  may be absorbed by having a pointer based implementation.

@rolandash @dagar - here is what we have
io_timer-asbuilt.pdf
The led pwm and pwm_trigger are more or less copies. The drv_pwm_servo and drv_input_capture are lend themselves to hierarchical model. led pwm and pwm_trigger may be absorbed by having a pointer based implementation.

@davids5 thanks. thats is a clear picture.
A question is can you explain bit more about what you mean by a pointer based implementation?

@rolandash
I have to look at the use case in more detail, but in general:
https://github.com/PX4/Firmware/blob/master/src/drivers/stm32/drv_io_timer.c#L523-L537
would become int io_timer_init_timer(io_timer_dev *priv, unsigned timer)
and all the compile time io_timers[timer]  would become `priv->io_timers[timer]
Then the same code can work on multiple sets of io_timer and timer_io_channels described by instances of io_timer_dev.
Then the 0th instance of the FMU (code) would used the 0th instance of io_timer_dev.
the 1st instance of the FMU (code) would used the 1st instance of io_timer_dev. etc.
Ideally this would all be done in C++ and the specialization hinted at in the uml would be implemented.  The challenges is that the PX4IO uses the same code and we have more resource limitations there.
@dagar when you get a chance we should spend some time hashing this out.

@rolandash
I have to look at the use case in more detail, but in general:
https://github.com/PX4/Firmware/blob/master/src/drivers/stm32/drv_io_timer.c#L523-L537
would become int io_timer_init_timer(io_timer_dev *priv, unsigned timer)
and all the compile time io_timers[timer] would become priv->io_timers[timer]
Then the same code can work on multiple sets of io_timer and timer_io_channels described by instances of io_timer_dev.
Then the 0th instance of the FMU (code) would use the 0th instance of io_timer_dev.
the 1st instance of the FMU (code) would use the 1st instance of io_timer_dev. etc.
Ideally this would all be done in C++ and the specialization hinted at in the uml would be implemented. The challenges is that the PX4IO uses the same code and we have more resource limitations there.
@dagar when you get a chance we should spend some time hashing this out.

@davids5
thanks for the explanation. I roughly got the idea. A few comments:

I guess the intention is to use drv_io_timer.c as a centralized coordinator of timer/channel resources. The good side of this method is we already have io_timer_channel_mode_t here so it would be natural to add resource allocation code here. The down side is other detailed resource management like channel map under different PWM working modes / mixer channels / shared channels etc., will inflate this driver into too complex than a low level driver should be.
My suggestion is while io_timer_channel_mode_t is a good place to add logic into but still keep drv_io_timer as simple as possible, and have another management class on top of it to handle higher level resource mgmt. I am not aware the detailed design of io_timer_dev yet, hope that structure can balance the design in some way like this.

We can set up another discussion if necessary @dagar


Enrich Makefile

Codecov Report

Merging #5 (da3e7d8) into master (855c662) will increase coverage by 0.40%.
The diff coverage is 73.07%.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   88.52%   88.92%   +0.40%
==========================================
  Files          15       15
  Lines        1386     1391       +5
==========================================
+ Hits         1227     1237      +10
  Misses        126      126
+ Partials       33       28       -5

Impacted Files
Coverage Δ

entry/cert_entry.go
95.69% <ø> (ø)

entry/cred_entry.go
77.31% <50.00%> (+0.42%)
:arrow_up:

entry/event_logger_entry.go
94.73% <75.00%> (+1.11%)
:arrow_up:

entry/rk_meta_entry.go
96.55% <75.00%> (+1.81%)
:arrow_up:

entry/zap_logger_entry.go
90.10% <75.00%> (+1.22%)
:arrow_up:

entry/app_info_entry.go
98.36% <85.71%> (+0.83%)
:arrow_up:

entry/config_entry.go
96.38% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dea734...da3e7d8. Read the comment docs.


Is there any way to activate the taskbar over programs (not fullscreen) as in print?

Is there any way to activate the taskbar over programs (not fullscreen) as in print?

WIN+T

WIN+T does not give me the same result of print screen, but tks...

Are you talking about turning off auto-hide? Is it like double-clicking the  icon? This action will cause the desktop layout to reset under Windows 11.
The most I can do is to add a shortcut key to let the user switch manually, otherwise frequent layout changes will make some windows constantly switch between maximized and normalized. You can see this behavior if you install an older version of SmartTaskbar.


.NET Core xUnit LUT stops working by NullReferenceException after adding a new project

Steps to reproduce

Create a xUnit Test (.NET Core) project;

Click the "Start" of "Live Unit Testing" under Test down list;

Right click the solution and add new project, choose the template "Class Library (.NET Standard)" under ".NET Standard" node

Then the output window throw an fatal error "FatalError - System.NullReferenceException: Object reference not set to an instance of an object." then live unit testing stopped:
	FatalError - System.NullReferenceException: Object reference not set to an instance of an object.  	   at Microsoft.VisualStudio.LiveUnitTesting.Setup.MSBuildProvider.<>c__DisplayClass0_0.<<Microsoft-CodeAnalysis-LiveUnitTesting-IMSBuildProvider-TryExecuteGuardedProjectAction>b__1>d.MoveNext()  	--- End of stack trace from previous location where exception was thrown ---  	   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)  	   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)  	   at Microsoft.VisualStudio.Threading.JoinableTask.CompleteOnCurrentThread()  	   at Microsoft.VisualStudio.Threading.JoinableTask1.CompleteOnCurrentThread()
at Microsoft.VisualStudio.Threading.JoinableTaskFactory.Run[T](Func1 asyncMethod, JoinableTaskCreationOptions creationOptions)  	   at Microsoft.VisualStudio.LiveUnitTesting.Setup.MSBuildProvider.Microsoft.CodeAnalysis.LiveUnitTesting.IMSBuildProvider.TryExecuteGuardedProjectAction(String projectFilePath, Project project, Action1 action)
at Microsoft.CodeAnalysis.LiveUnitTesting.SolutionManager.GetOrAddProjectNode(String projectFilePath, Project project)
at Microsoft.CodeAnalysis.LiveUnitTesting.SolutionManager.<>c__DisplayClass21_0.b__4(Project p)
at System.Linq.Enumerable.All[TSource](IEnumerable1 source, Func2 predicate)
at Microsoft.CodeAnalysis.LiveUnitTesting.SolutionManager.GenerateProjectDependencyGraph()
at Microsoft.CodeAnalysis.LiveUnitTesting.BuildManagement.BuildManagerState.d__86.MoveNext()
[23:41:00.457 Info] Live Unit Testing stopped.`

Restart the "Live Unit Testing";

Add reference from xUnit to standard class library;

From xunit calling the method of standard class, then live unit testing glyphs show up in the margin next to most lines of code in the xunit, but which don't show in .net standard class:

Expected behavior

LUT works even if adding a new project

Environment

Install d15prerel.26605.02;
Install latest CLI/SDK 2.0. from https://github.com/dotnet/cli/tree/release/2.0.0
Build version of vstest.console: 15.0.26605.02
dotnet --info
.NET Command Line Tools (2.0.0-preview2-006341)

Product Information:
 Version:            2.0.0-preview2-006341
 Commit SHA-1 hash:  19d305783b

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.14393
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\2.0.0-preview2-006341\

Microsoft .NET Core Shared Framework Host

  Version  : 2.0.0-preview2-25402-02
  Build    : 3c440c8947e7776b2c7772bcb98b3bc73e1b9193

This is LUT issue. moving it to their repo: https://github.com/dotnet/testimpact/issues/1894


Transaction are marked Invalid, but still execute completely.

To start, here is a <2min screencast demonstrating the issue. https://youtu.be/s1_ITcHzWcw
I'm working on a PoW chain  based on substrate v2.0.0-alpha.3 It compiles, and produces blocks as expected.
When an extrinsic is submitted to the chain, its status comes back as Invalid. I spent a while trying to determine why it was invalid, only to later realize that the transaction actually does execute to completion. In the screencast you can see a balance transfer marked as invalid, but the sender and receiver balances are updated correctly, and the TransferSucceeded event is emitted.

Please try with latest master.

Most likely fixed in https://github.com/paritytech/substrate/pull/5227

Indeed this is fixed on latest master. Thank you.


feat: Does it support updating applications from custom source addresses

Is your feature request related to a problem? Please describe.
Google play is not required to update the application from a custom source address.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hi @estoi,
thank you for your request.
I'm not sure I understood you correctly. If the request is if you can do live updates with this plugin like you can with Ionic Appflow, then the answer is no.
This plugin only works with the Google Play Store on Android.
For this reason, I am closing this issue. Let me know if you meant something else.

I am looking for other solutions.


[BUG] kbcli addon enable error unknown field failureThreshold

Describe the bug
kbcli version
Kubernetes: v1.26.12-gke.1111000
KubeBlocks: 0.9.0-alpha.4
kbcli: 0.9.0-alpha.1

To Reproduce
Steps to reproduce the behavior:

kbcli addon enable  oceanbase-ce
see error

kubectl get pod
NAME                                              READY   STATUS    RESTARTS   AGE
install-oceanbase-ce-addon-mhk9v                  0/1     Error     0          8s

kubectl logs install-oceanbase-ce-addon-mhk9v
Release "kb-addon-oceanbase-ce" does not exist. Installing it now.
Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(ComponentDefinition.spec.lifecycleActions.roleProbe): unknown field "failureThreshold" in io.kubeblocks.apps.v1alpha1.ComponentDefinition.spec.lifecycleActions.roleProbe

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

dup https://github.com/apecloud/apecloud-addons/issues/45


NodeViewHolder class does not exist?

When I try to implement the library, the NodeViewHolder class is not instantiated. Is it a class that I have to create myself?

Hi @BrayanOB2003, yes since GraphView is built on top of RecyclerView you need ViewHolders like in this case a NodeViewHolder which is derived from RecyclerView.ViewHolder.  And there you bind the data which should be displayed.


add schema declaration to the manifest file

This change allows editors to highlight data errors. While this won't entirely prevent bad data, it opens the door to using the schema in more automated fashions (for example a unit test that validates the document according to the schema).
Here's what the experience looks like for a subset of invalid field data in VS Code:

and in VS:

The tooltips are powered by the schema and offer tips for fixing the problem:

@leecow will this be a breaking change somehow to the release-index.json?

I checked the .NET library that parses this file and it would not impact that library because it specifically pulls the releases-index property of the json document and then deserializes that array.
This library is used in the SDK, omnisharp, arcade, and probably others based on the NuGet listing, so I would hope that since it parses this correctly there would not be too much churn.

My primary question is how is the schema maintained updated in the event of an update in either the json structure (e.g. adding a property) or updating valid values (which we will likely be doing for support phase)?

This change needs to happen in the tooling which generates and maintains the file. I've submitted a PR to schemastore to update the releases-index schema. Once that's complete, I'll update the tooling.


To build on Debian Jessie (8) you need libtool-bin

To build/install on Debian Jessie you need to apt-get install libtool-bin

added to README.md


Can't handle concurrent request.

If There are 10 requests in a queue. now handle just one at a time and the rest of request should wait for next handling.

use nginx and gunicorn


Adjust the logic of initializing serviceDefinition attribute in ServiceDescriptor

What is the purpose of the change
There is no need to use map type container for serviceDefinition attribute  of ServiceDescriptor

Codecov Report

Merging #9664 (4d1c267) into 3.0 (adea101) will decrease coverage by 0.33%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.0    #9664      +/-   ##
============================================
- Coverage     65.73%   65.39%   -0.34%
+ Complexity      297      294       -3
============================================
  Files          1192     1192
  Lines         52154    52112      -42
  Branches       7918     7887      -31
============================================
- Hits          34285    34081     -204
- Misses        14186    14325     +139
- Partials       3683     3706      +23

Impacted Files
Coverage Δ

.../org/apache/dubbo/rpc/model/ServiceDescriptor.java
78.72% <100.00%> (-0.13%)
:arrow_down:

.../dubbo/registry/client/metadata/MetadataUtils.java
73.25% <100.00%> (ø)

...dubbo/remoting/zookeeper/ZookeeperTransporter.java
55.55% <0.00%> (-33.34%)
:arrow_down:

...pache/dubbo/common/function/ThrowableFunction.java
71.42% <0.00%> (-28.58%)
:arrow_down:

...ing/zookeeper/curator/Curator5ZookeeperClient.java
42.02% <0.00%> (-27.54%)
:arrow_down:

...ache/dubbo/rpc/proxy/InvokerInvocationHandler.java
68.00% <0.00%> (-16.00%)
:arrow_down:

...ache/dubbo/remoting/transport/AbstractChannel.java
75.00% <0.00%> (-12.50%)
:arrow_down:

...dubbo/common/status/support/LoadStatusChecker.java
50.00% <0.00%> (-11.54%)
:arrow_down:

...mmon/threadpool/support/AbortPolicyWithReport.java
73.68% <0.00%> (-10.53%)
:arrow_down:

...bo/rpc/protocol/dubbo/DecodeableRpcInvocation.java
67.85% <0.00%> (-9.83%)
:arrow_down:

... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adea101...4d1c267. Read the comment docs.


Update sbt, scripted-plugin to 1.4.6

Updates

org.scala-sbt:sbt
org.scala-sbt:scripted-plugin

from 1.4.4 to 1.4.6.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt" } ]

labels: library-update, semver-patch

Superseded by #54.

Superseded by #54.


Jikkyou Powerful Pro Yakyuu '95 (Japan) (Rev 0) has no 'PS-X EXE' text in header

The game Jikkyou Powerful Pro Yakyuu '95 (Japan) (Rev 0) does not have the 'PS-X EXE; text in it's header. This was fixed in Rev 1:

This causes Japan Rev 0 to not boot with the newest executable header code recently added.
Commenting it out works fine. Not sure if it's worth checking for now since at least one game doesn't have it.
exe_header_t * exe_header = (exe_header_t *) data_buffer;
if (strncmp(exe_header->signature, "PS-X EXE", 8)) {
	debug_write("Info: header has invalid signature");
	//return;
}

I'd like to still like to check for it, even if we just disable the return and inform the user. FileRead might return complete garbage as we've seen if the laser goes out of bounds, and this information could be pretty useful for debugging such conditions.
Maybe the check could be replaced to checking if the executable code and the initial PC is within the bounds of the console main RAM (or a mirror), and if the stack resides within main RAM or the "fast RAM". Will mean more LOC but should work with every single game out there.

I'd like to still like to check for it, even if we just disable the return and inform the user. FileRead might return complete garbage as we've seen if the laser goes out of bounds, and this information could be pretty useful for debugging such conditions.
Maybe the check could be replaced to checking if the executable code and the initial PC is within the bounds of the console main RAM (or a mirror), and if the stack resides within main RAM or the "fast RAM". Will mean more LOC but should work with every single game out there.

On the over-seek PS2 issue, if that happens it will never get to the code checking for this because it will be unable to open the PSX.EXE file. You can add code to Tonyhax that will guarantee that the over-seek PS2 issue while in the loader never happens and it can open the PSX.EXE.
An alternative would be to check for what Rev 0 has instead of PSX-EXE. Check both signatures.
From my research it looks like a lot of the PS-X EXE format isn't required, just from what we know

Certain SP values (kings field issue)
Size (kileak the blood issue)
Signature (this)

So I like your idea as well because it's actually 100% mandatory. Let me know your thoughts.

Patched in https://github.com/socram8888/tonyhax/commit/c897f18dd5bc8430343686ff4f979678933fd279.
I've simplified the FileRead checks, since the functions will always either fill the entire buffer or return -1.

FYI @alex-free you might want to cherry pick https://github.com/socram8888/tonyhax/commit/ace42f56d5094782fc69e2cc7a56d12d59a75189 since I did an oopsie while rewriting the debug_write calls.

FYI @alex-free you might want to cherry pick https://github.com/socram8888/tonyhax/commit/ace42f56d5094782fc69e2cc7a56d12d59a75189 since I did an oopsie while rewriting the debug_write calls.

Thanks for the heads up, went ahead and fixed it with your current commit.


Unable to create bacpac from Azure SQL DB if it has a symmetric key

SqlPackage or DacFx Version: 19.2
.NET Framework (Windows-only) or .NET Core: .NET
Environment (local platform and source/target platforms): Windows 10 and Azure SQL DB

Steps to Reproduce:

Within the Azure SQL DB run the following:

CREATE CERTIFICATE MyTestCer
ENCRYPTION BY PASSWORD = 'abcdef123456!&'
WITH SUBJECT = 'TestExport',
EXPIRY_DATE = '20221231';
GO
CREATE SYMMETRIC KEY SymKeyTest
WITH ALGORITHM = AES_256
ENCRYPTION BY CERTIFICATE MyTestCer;
GO

After creating the cert and key, try to export directly using sqlpackage.  This also fails in SSMS.

SqlPackage 19.2:
"C:\Program Files\Microsoft SQL Server\160\DAC\bin\SqlPackage.exe" /Action:Export /ssn:tcp:,1433 /SourceDatabaseName:WWI_PS /su: /sp: /tf:C:\Temp\WWI.bacpac /p:Storage=File)
SSMS 19 Preview 3 (and SSMS 18.12.1): right-click on the database, select Tasks, Export Data-tier application.
Did this occur in prior versions?  If not - which version(s) did it work in?
I assume it's always been an issue
Error in SqlPackage:
Connecting to database 'WWI_PS' on server 'tcp:,1433'.
Extracting schema
Extracting schema from database
Resolving references in schema model
Validating schema model
Validating schema model for data package
Validating schema
*** The ledger data in system views will not be captured in the resulting bacpac file or the dacpac file. For more information see https://go.microsoft.com/fwlink/?linkid=2165963.
*** Element [dbo].[Ledger_History] is a history table for the [dbo].[LedgerTableName] updatable ledger table. Migrating data in history tables is not supported. The data will not be included in the resulting bacpac file or the dacpac file. For more information see https://go.microsoft.com/fwlink/?linkid=2165963.
*** Element [dbo].[LedgerTableName].[StartTransactionID] is a column with system-generated values (a GENERATED ALWAYS column) in a ledger table. The data stored in the column will not be captured in the resulting bacpac file or the dacpac file. For more information see https://go.microsoft.com/fwlink/?linkid=2166135.
*** Element [dbo].[LedgerTableName].[EndTransactionID] is a column with system-generated values (a GENERATED ALWAYS column) in a ledger table. The data stored in the column will not be captured in the resulting bacpac file or the dacpac file. For more information see https://go.microsoft.com/fwlink/?linkid=2166135.
*** Element [dbo].[LedgerTableName].[StartSeqNum] is a column with system-generated values (a GENERATED ALWAYS column) in a ledger table. The data stored in the column will not be captured in the resulting bacpac file or the dacpac file. For more information see https://go.microsoft.com/fwlink/?linkid=2166135.
*** Element [dbo].[LedgerTableName].[EndSeqNum] is a column with system-generated values (a GENERATED ALWAYS column) in a ledger table. The data stored in the column will not be captured in the resulting bacpac file or the dacpac file. For more information see https://go.microsoft.com/fwlink/?linkid=2166135.
*** Element [dbo].[Ledger_AddOnly].[ledger_start_transaction_id] is a column with system-generated values (a GENERATED ALWAYS column) in a ledger table. The data stored in the column will not be captured in the resulting bacpac file or the dacpac file. For more information see https://go.microsoft.com/fwlink/?linkid=2166135.
*** Element [dbo].[Ledger_AddOnly].[ledger_start_sequence_number] is a column with system-generated values (a GENERATED ALWAYS column) in a ledger table. The data stored in the column will not be captured in the resulting bacpac file or the dacpac file. For more information see https://go.microsoft.com/fwlink/?linkid=2166135.
*** Error exporting database:One or more unsupported elements were found in the schema used as part of a data package.
Error SQL71626: The element Certificate: [LocalCert] is not supported in Microsoft Azure SQL Database v12.
Error SQL71626: The element Symmetric Key: [SymKeyTest] is not supported in Microsoft Azure SQL Database v12.
Error in SSMS:
One or more unsupported elements were found in the schema used as part of a data package.
Error SQL71626: The element Certificate: [LocalCert] is not supported in Microsoft Azure SQL Database v12.
Error SQL71626: The element Symmetric Key: [SymKeyTest] is not supported in Microsoft Azure SQL Database v12.
(Microsoft.SqlServer.Dac)

Program Location:
at Microsoft.SqlServer.Dac.DacServices.<>c__DisplayClass67_2.b__2()
at Microsoft.Data.Tools.Schema.Sql.Dac.OperationLogger.Capture(Action action)
at Microsoft.SqlServer.Dac.DacServices.<>c__DisplayClass67_1.b__0(Object operation, CancellationToken token)
at Microsoft.SqlServer.Dac.Operation.Microsoft.SqlServer.Dac.IOperation.Run(OperationContext context)
at Microsoft.SqlServer.Dac.OperationExtension.CompositeOperation.Microsoft.SqlServer.Dac.IOperation.Run(OperationContext context)
at Microsoft.SqlServer.Dac.OperationExtension.CompositeOperation.Microsoft.SqlServer.Dac.IOperation.Run(OperationContext context)
at Microsoft.SqlServer.Dac.OperationExtension.Execute(IOperation operation, DacLoggingContext loggingContext, CancellationToken cancellationToken)
at Microsoft.SqlServer.Dac.DacServices.ExportBacpac(Func1 streamGetter, String databaseName, DacExportOptions exportOptions, IEnumerable1 tables, CancellationToken cancellationToken)
at Microsoft.SqlServer.Dac.DacServices.ExportBacpac(String packageFileName, String databaseName, DacExportOptions options, IEnumerable1 tables, Nullable1 cancellationToken)
at Microsoft.SqlServer.Dac.DacServices.ExportBacpac(String packageFileName, String databaseName, DacSchemaModelStorageType modelStorageType, IEnumerable1 tables, Nullable1 cancellationToken)
at Microsoft.SqlServer.Management.Dac.DacWizard.ExportDatabase.DoWork()
at Microsoft.SqlServer.Management.TaskForms.SimpleWorkItem.Run()

Tested with latest version of sqlpackage and can be reproduced in Sql DB and Sql DW databases!

Update: Its not a regression, as the error exists in 15.0.5164.1 version too, but Extract action has no issue with the certificate.

@ssreerama this is a feature request so we should keep it open and add label as feature request

Just ran into issue when trying to export to a BACPAC, happy days 😣
Error SQL71626: The element Certificate: [Cert_foo_20221124_21541231_45366] is not supported in Microsoft Azure SQL Database v12.


Changed nt to no

In line 87 the line read "criteria is nt longer active" changed to "criteria is no longer active"

:white_check_mark: Organization membership check passed
Requester is not a member of the MicrosoftDocs organization.


chore: Expose widget configuration to define properties that can set …

…widget to loading state
Description
Partially reinstates changes from the reverted commit - https://github.com/appsmithorg/appsmith/pull/11875/files
Fixes #16537
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.

Test A
Test B

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

CC @ohansFavour @eco-monk

/ok-to-test sha=b97ef83

/ok-to-test sha=b97ef83

/ok-to-test sha=18c84fb

We don't need it in Table V1. This issue is caused by the select column type which is not available in table v1.

/ok-to-test sha=18c84fb

/ok-to-test sha=18c84fb

/ok-to-test sha=f51d970

/ok-to-test sha=f51d970

/ok-to-test sha=f51d970

Will be verifying this once select type column is up on release.


Updated proptypes usage from new prop-types package

Removed deprecated usage of PropTypes from React main package
Added new prop-types package

Awesome, thanks!

Published under v1.0.0

Cheers!


Can you make it Swift 3 compatible?

Looks awesome, but it won't compile on Swift 3

It is. Are you using Carthage?


SPARK-19927: Support the --hivevar in the spark-sql command line and in the beeline

What changes were proposed in this pull request?

Read hivevar of hivevariables into sqlContext.conf in SparkSQLOperationManager
Adds TestSQL.sql as test resource
Adds spark-sql CLI test case in CliSuite

How was this patch tested?
Added a test case for spark-sql CLI mode
Manual test for Beeline mode
Please review http://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?


Cloudinary will not accept files over a certain size (I think 100mb) using the POST upload endpoint. The only way to upload larger files is to use some old jQuery thing, or their everything-and-the-kitchen-sink Upload Widget.
https://cloudinary.com/documentation/react_image_and_video_upload
The Upload Widget does not support React. They have some poorly documented instructions, but they're for an older version of the package and don't work anymore.
I found a third-party tool that wraps the widget and seems to work.
"Okay, do we still need your InvisiFileThing tool?" … probably not… I would need to rewrite the UI for avatar and banner uploads a little… so for now we have both.

@EricWVGG thanks for looking into this. I think the "custom" solution will be done via a server-side uploading with NodeJS Cloudinary SDK but this widget works perfectly for the time being


[ENHANCEMENT] Two colours for intraline diffs

Could you add a column-A/B setting for intraline diff colour like there is for full lines, so it looks like diffs on GitHub?

Sorry for the late response. Haven't much time to work on this lately.
Good idea, though. I've released an update that contains that functionality.
Because it can be difficult to find colours that work with a wide variety of different colour schemes & themes, I've left the default values to the same blue colour. This can be changed by adding modified_colour_deletion and modified_colour_addition to your user settings for the plugin.
Thanks!

Wow, thanks so much.
How exactly do I update it? Package Control says there are no packages ready to upgrade.

It should update automatically. You may also need to restart Sublime. The
updated version is 1.12.0 to be sure.
On Fri, Sep 2, 2016, 9:19 PM aaaxx<EMAIL_ADDRESS>wrote:

Wow, thanks so much.
How exactly do I update it? Package Control says there are no packages
ready to upgrade.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/DougTy/sublime-compare-side-by-side/issues/10#issuecomment-244523512,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEFDuEPum7IA-Y8_W7NjYooTfJcdeHKzks5qmOc_gaJpZM4JkJYH
.


Improve Test Runner

This PR addresses  #375 and supports the following formats:
Running tests in examples/neg depends on whether there is a check file or not:

.check file exists: .effekt program will be compiled and run; output is compared against .check
.check file does not exist: .effekt program will be compiled. The following checks will be performed

if no line has an error annotation, then it is checked whether an error exists at all.
for each line that ends in either // ERROR or // WARN a corresponding error or warning is searched for.

Additionally each // ERROR and // WARN comment can be followed by an excerpt of the error message that is expected.
https://github.com/effekt-lang/effekt/blob/a103be8e5fcfafebf1c55e95a3648329ae211a25/examples/neg/blocks_wrong_arguments.effekt#L1-L18
The trailing message will be searched verbatim in the error messages.
Additional errors that are not marked with a comment are currently ignored.

@dvdvgt This might be helpful for you to test typer more easily.

@jiribenes You mentioned the LLVM test runner. Is there anything you think would be super helpful in addition to what I implemented?

Once the tests go through I will merge this since I already want to use it on another PR :)