Accessing Conductor Server behind a nginx reverse proxy with the Java Client API

Hello,
I am running Conductor Server behind a nginx reverse proxy with basic authentication.
My code currently looks this, which works without the nginx proxy:
		wfc = new WorkflowClient();
		wfc.setRootURI(conductorUrl);

		tc = new TaskClient();
		tc.setRootURI(conductorUrl);

Is there any way to connect to Conductor Server using the Java API (WorkflowClient) via the nginx proxy?
That means, I would somehow need to specify username/password for nginx.
Many thanks for any help.

I think this should be possible by using the constructor that takes client config and clienthandler.
https://github.com/Netflix/conductor/blob/master/client/src/main/java/com/netflix/conductor/client/http/ClientBase.java#L57

I implemented a solution now for basic authentication. I simply extended the TaskClient to be able to add the HTTPBasicAuthFilter to the Jersey 1.19 client.
Here is the associated code:
import com.netflix.conductor.client.http.TaskClient;
import com.sun.jersey.api.client.Client;
import com.sun.jersey.api.client.config.ClientConfig;
import com.sun.jersey.api.client.config.DefaultClientConfig;
import com.sun.jersey.api.client.filter.HTTPBasicAuthFilter;

public class MyTaskClient extends TaskClient {

	/**
	 * Conductor URL to connect to
	 */
	protected String conductorUrl = "http://localhost:8080/api/";

	/**
	 * Username for basic authentication
	 */
	protected String username = "myUsername";

	/**
	 * Password for basic authentication
	 */
	protected String password = "myPassword";

	public MyTaskClient(String conductorUrl, String username, String password, boolean trustAllSSLCertificates) {
		this.conductorUrl = conductorUrl;
		this.username = username;
		this.password = password;

		ClientConfig config = new DefaultClientConfig();

		/*
		 * Creating the Jersey Client
		 */
		this.client = Client.create(config);
		this.setRootURI(this.conductorUrl);

		/*
		 * Adding basic authentication
		 */
		if (username != null && !username.isEmpty() && password != null && !password.isEmpty()) {
			this.client.addFilter(new HTTPBasicAuthFilter(username, password));
		}

	}
}


Expired nodes are stuck in ready, schedulingDisabled state

Version

Karpenter: v0.16.0

Kubernetes: v1.22
Expected Behavior
Nodes provisioned by karpenter should be deleted after they expired.
Actual Behavior
The nodes are stuck in Ready, SchedulingDsiabled state. Karpenter is deployed with debug mode enabled but there are no logs that indicates why the nodes would be stuck. The pods on the nodes shows healthy (none of the pods are in a terminating state). I tried to delete the node but due to Karpenter's finalizer it's not possible.
The only pod with PDB would be my ebs-csi-driver daemonset although I'm not sure if that could be the issue.
Steps to Reproduce the Problem
This seems to randomly happen. I currently have a node that is in that state and have not been deleted.

Yeah it turned out it was pgsql that was not allowing the node to terminate. Once we deleted that the node deleted. Thanks for the quick response!


Fixed #25574 -- Added a warning about clashing dictionary lookups in templates.

I added some explanation for problems described by the author of #25574 ticket, and added a link toa document that specifies full variable resolution order.

Please see our patch review checklist for details about the commit message format to use. Otherwise, this looks mostly good, thanks!

Documentation now compiles properly, i have updated commit messages.

I tried to simplify it a bit and merged in 32cd7069711d2e02fcd20c005c59c175d542c62e, thanks!


Clear button not working

When I enter text to searchview and then click the clear button only keyboard is hiding, but text is not clearing. I think it is because first removeFocus function is invoked and button is hiding, so onClick of clear button is not invoking.

I will fix it ASAP. I had a vacation :),


Create simple Sentry example for exception reporting.

Overview
For many teams using Next.js, setting up exception monitoring is a critical requirement before going to production. The current with-sentry example, while thorough, is very complicated for beginners.
This PR adds a simple example showing how to use Sentry to catch & report errors on both client and server-side.

_document.js is server-side only and is used to change the initial server-side rendered document markup. We listen at the node process level to capture exceptions.
_app.js is client-side only and is used to initialize pages. We use the componentDidCatch lifecycle method to catch uncaught exceptions.

Note: Source maps will not be sent to Sentry when running locally. It's also possible you will see duplicate errors sent when testing locally due to hot reloading. For a more accurate simulation, please deploy to Now.
Testing
With the example deployed the Now, I can click the links to simulate errors.

Then, I'm able to see the errors flow into Sentry.

The errors are properly source mapped.

@timneutkens

can you check this while you are at it https://github.com/zeit/next.js/issues/6783

@MarchWorks I can confirm that is not an issue with this example. I navigate back successfully here.

@leerob run yarn lint-fix to fix some of these issues if not all

@MarchWorks Good catch! Thanks for that.

Your example won't catch errors from getInitialProps of App

Your example won't catch errors from getInitialProps of App

Yeah, I think that's okay. If that is absolutely necessary, then they should probably use the more complex example.

Maybe add comment that warns about this?

@leerob curious if this could take advantage of _error.js per @timneutkens comment: https://github.com/zeit/next.js/pull/5727#discussion_r235981700 from previously.

@pruhstal I view overriding error.js as a nice to have. We should include the client side Sentry code in _app.js instead of just _error.js since App wraps every client-side page.
Having a custom error page would be a nice addition, but I wanted to keep this example as simple as possible.

@leerob fair enough. Are you using this setup currently in a production build anywhere? Am also curious how difficult it makes it not having a session id attached to each error (per the current with-sentry) example.

@pruhstal We are. So far, haven't seen any major issues. The first application consuming this setup isn't too complicated (Mostly static Next.js frontend + custom Hapi server). If we do run into issues with this setup, I'll plan on updating this example.

@leerob I'm okay with this example, can you resolve the suggestion made by @kris-luminar first ? 🙏

@lfades Addressed. I'm not seeing merge conflicts locally, so I'm a little confused where those are coming frome.

Ahh, I merged master instead of canary. Addressed.

@leerob The prettier changes are cool and can be included in the future but in a PR made for it, please remove the unnecessary prettier changes and focus on the example 🙏

@lfades Closing in favor of https://github.com/zeit/next.js/pull/7360 👍


Can we limit the depth of the MSA?

We have some users at our site folding large protein complexes using the multimer workflow, and have run into issues with memory exhausted on the GPUs even using the reduced databases. In the log file we notice it reporting what looks like a deep MSA:
I0822 12:49:34.498847<PHONE_NUMBER>69664 pipeline.py:238] Final (deduplicated) MSA size: 11437 sequences.
In the prediction stage, it doesn't look like the 11k sequences are used, as the msa dimensions are smaller:
I0822 12:59:51.185315<PHONE_NUMBER>69664 model.py:166] Running predict with shape(feat) = {'aatype': (4205,), 'residue_index': (4205,), 'seq_length': (), 'msa': (3072, 4205), ...
But this still looks larger than the MSA depth of 30 to 100 that I believe was identified as optimal in the original publication. Does this MSA depth appear abnormal, and if so is there anything we can do to restrict the MSA to a smaller number of sequences?

It looks like the functionality is there, based on the existence of truncate_stockholm_msa(stockholm_msa_path: str, max_sequences: int) and the places it is called, like in the Jackhmmer wrapper. And default values for max_sequences are defined for the different search databases in the class init of DataPipeline, but the upstream instantiations of pipelines leave them as default.


Investigate Endpoints - inbound-sms

User Story - Business Need

In the effort to clean up our code we need to investigate and remove unused endpoints. This ticket is to take a look at the endpoints under /service/<uuid:service_id>/inbound-sms and determine if they are useful. Remove these endpoints if it is determined that they are not useful. You can view the table of endpoints here.
User Story(ies)
As an engineer
I want to clean up and reduce our codebase
So that it is easier to maintain and upgrade in the future.
Additional Info and Resources

Endpoint Table
Endpoint Spreadsheet

Engineering Checklist

[ ] Investigate the endpoints starting with /service/<uuid:service_id>/inbound-sms to see if they are useful
[ ] Document findings and share with the team

Only do the following if it is determined that these endpoints are not useful.

[ ] (Optional) Remove tests associate with those endpoints
[ ] (Optional) Remove the code associated with those endpoints (if possible). Make sure not to remove any code used by other parts of the application.

Acceptance Criteria

IF the designated code and tests have been removed, the application retains full functionality.

QA Considerations

[ ] The QA Regression Suite passes
[ ] The Cypress regression passes

Potential Dependencies

If code removal is necessary, make sure the removal of these endpoints doesn't affect the work Strike is doing.

Closing/no longer relevant.


Run time closure of duplicity includes mesa drivers

To reproduce:
$ nix path-info -r (nix-build '<nixpkgs>' -A duplicity) | grep mesa
/nix/store/0inxqcjpcfw1syksd7d3w6s0kzm6g897-mesa-20.3.4-dev
/nix/store/a71113rnbykvfmapskscmivnd8i8bcqx-mesa-20.3.4
/nix/store/vh0k8fflhd32mvjb717k3alnsl33hwil-mesa-20.3.4-drivers

duplicity is a small command-line backup program, so this is a bit surprising to say the least.  Even if it depended on some graphics libraries, I would have maybe expected glvnd to show up.  But the actual mesa drivers is a bit too much.  There seem to be several surprising issues here:

The python wrappers automatically add the whole build-time PATH from the propagated build inputs to the wrapper.  #102613 might help a bit here.
cairo puts a whole lot of libraries into propagatedBuildInputs, including libGL.  Even if they don't end up in the wrapper, they are written to nix-support/propagated-build-inputs.
libGL.dev then depends on the mesa drivers, because the mesa pkg-config files depend on the drivers.

I don't really know where to start fixing this issue.

Should cairo have fewer propagatedBuildInputs?
Should propagated build inputs only be included in the dev output?  If the bin output includes the nix-support/propagated-build-inputs file, then the closure includes all propagated build inputs, even if they are not referenced.
Is there a way to prevent propagation of (some) propagatedBuildInputs?  Presumably python3Packages.pygobject3 doesn't need to propagate dependencies from cairo (which are only necessary to build C programs).
The mesa dependency on the default driver set is probably a bug?

We need to get rid of propagatedBuildInputs for Python packages entirely. https://github.com/NixOS/nixpkgs/pull/102613 shows how it could be done. After an RFC discussion on overriding of derivations I concluded we should use less Nix and instead use a file such as $out/nix-support/python-packages so https://github.com/NixOS/nixpkgs/pull/102613 won't go in.

Some other surprising observations:

propagatedBuildInputs = [ pyobject3.out ]; means exactly the same as propagatedBuildInputs = [ pyobject3 ];.  So you always have a dependency on the C headers of a python extension, whether you want them or not.
Adding outputs = [ "out" "dev" ]; to duplicity breaks the python wrapper.

Related: checkInputs are in the runtime closure as well #118452

Should update https://github.com/NixOS/nixpkgs/issues/1819 again, its been a while.

Adding outputs = [ "out" "dev" ]; to duplicity breaks the python wrapper.

This was noticed in the past with if I recall correctly requests and some other packages. A work-around is to use pythonPath instead of propagatedBuildInputs.

Can this be closed?

Can this be closed?

I've fixed the closure size in #118459 and the mesa issue in #118479.  But I'd still like some comments on propagatedBuildInputs.

Is cairo's use of them excessive?
Is there a way to prevent propagation?
Splitting into multiple outputs helps a bit here, because the propagated-build-inputs file is only put in the dev output.  Does this mean that every package which transitively depends on a propagatedBuildInput should have a dev output?

https://github.com/NixOS/nixpkgs/pull/102613#discussion_r518265183. It could use a PR.
https://github.com/NixOS/nixpkgs/pull/102613
This confuses me. The dependent will not create a propagated-build-inputs, unless it also declares propagatedBuildInputs.

I should write out once how things work now and what should change.

This confuses me. The dependent will not create a propagated-build-inputs, unless it also declares propagatedBuildInputs.

Then I was also confused, sorry.  This behavior sounds great, actually.  If we move python away from propagatedBuildInputs, then this issue will be automatically gone.


Cantools has no way to load frame of only one bus

Cantools.db.load_file right now loads all the frames of all the buses. No args in the load_file function to let the user load the frame of a specific bus.
When different buses have frames with the same ID, but different frame definitions, this can be a problem in the final messages returned by Cantools.db.load_file.

I suppose that fixing this would require a medium-sized overhaul of cantool's current data model, namely to store all message objects within their respective bus objects instead of directly putting them into the database. While this is IMO quite doable, it is quite a bit of work and has the potential for breakage. I'll be happy to accept pull requests for this, though.


Rationalise interface for *wait_for_value*

After discussions surrounding #453 and #447 I suggest we make the following changes to the following helpers for signal operations:

Stop returning the status from set_and_wait_for_*value and instead await it, using timeout for it rather than a separate status_timeout
Update all the areaDetector usages from:

arm_status = await set_and_wait_for_value(self.acquire, True)
...
await arm_status

to
arm_status = self.acquire.set(True)
await wait_for_value(self.acquire, True)
...
await arm_status

Support using a match function in set_and_wait_for_value and set_and_wait_for_other_value

That would make the interface:
async def observe_value(
    signal: SignalR[T],
    timeout: float | None = None,
    done_status: Status | None = None) -> AsyncGenerator[T, None]:
    ...

async def wait_for_value(
    signal: SignalR[T],
    match_value: T | Callable[[T], bool],
    timeout: Optional[float] = DEFAULT_TIMEOUT) -> None:
    ...

async def set_and_wait_for_value(
    signal: SignalRW[T],
    value: T,
    match_value: T | Callable[[T], bool] | None = None,
    timeout: Optional[float] = DEFAULT_TIMEOUT) -> None:
    ...

async def set_and_wait_for_other_value(
    signal: SignalW[T],
    value: T,
    match_signal: SignalR[S],
    match_value: S | Callable[[S], bool],
    timeout: Optional[float] = DEFAULT_TIMEOUT) -> None:
    ...

And also #402


maps: add Merge function

this function allows to merge multiple generic maps in a single one

Corresponding proposal: https://github.com/golang/go/issues/57191


Windows installer triggers AntiVirus

I was unable to install the Windows app, because my antivirus considered it a threat.
See the following screenshots:

my log id: 1d8e21db2b165233b71a7e1c

Cc: @zanderz

Thanks for the screenshots, but the registry path is cut off. Can you tell what it thinks is risky? Writing to a certain registry key? Thanks.


Update showcases.js

👋👋 Hello there! Welcome. Please follow the steps below to tell us about your contribution.

Select one of the templates below that fits your contribution
Remove this text as well as the other templates
Fill in all sections of the template
Summon a reviewr using @mentions (optional)
Click "Create pull request"

Showcase addition

Name: Project name
Description: Describe your project (See Showcase guidelines)
Link:   <link_to_project>
Source: <link_to_source_code>
Tags:

analytics
explorer
educational
game
gateway
opensource
pooltool
metadata
nativetoken
nft
wallet

Updating documentation
Issue
Fixes #issueId

Description of the change

Bugfix
Fixes #issueId

Description

Quickfix

Closing due to lack of attention to read instructions and incomplete website


refactor(aws-sam): remove duplicate aws-sam (in favor of aws-serverless)

Fixes #999
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

🎉🎉🎉 Issue 1000 🎉🎉🎉
Such a momentous one, too :)


Odd Mesos UI behavior

I have deployed a system in my AWS account and noticed a behavior I don't quite understand. My other systems are fine, but there's something about this environment that forces incorrect machine listed as a slave.
In the first image I have a screenshot of the slaves tab. You'll see that Slave host name is "ip-10-184-241-84.ec2.internal".

When I click on the ID I see "Slave:ip-10-184-241-166.ec2.internal" which in fact is the address of the master. No resources are showing either.

Any ideas on what might be causing this behavior?
Thank you!
See this problem in this environment with both Mesos 0.25 and 0.28.

It's Mesos issue not Marathon. Please report it on<EMAIL_ADDRESS>mailing list


additional stack combinators

:x-flip reverse entire stack
:x-cut takes an integer, and splits the stack at that point, putting the top chunk below the other (cut like a deck of cards)
:x-flipat takes an integer, splits the stack at that point, and reverses the top part

:x-flipstack
:x-cutflip
:x-cutstack
:x-liftstack

Needs to be wired in somehow.

Add :x-double and :x-archive

:x-archive is actually a special case of :x-liftstack

8b13f56c69bc65bd282f2573634e9f330cd31210


Request: color change and state record shortcut

I would like to change the record shortcut while recording e.g. red, blinking an with text recording in screen.
Hope it is possible to add.

This component doesn't support entities and recording functions.

I've seen a similar issue before


Add information = isRecording

Enigma2 devices from VU+ (such as VU+ UNO 4K SE) provide additional endpoints on top to enigma2 to get information about the current device status. Please add an option in the ioBroker enigma2 adapter to fetch the information from the statusinfo endpoint (if provided by device / optional) and provide it's information in the iobroker enigma2 Adapter and the object tree.
Endpoint:
http:///api/statusinfo
Example Response:
{"inStandby": "false", "currservice_begin": "16:05", "currservice_begin_timestamp":<PHONE_NUMBER>, "currservice_end_timestamp":<PHONE_NUMBER>, "muted": false, "isRecording": "false", "currservice_station": "Das Erste HD", "currservice_serviceref": "1:0:19:283D:3FB:1:C00000:0:0:0:", "currservice_description": "Handball-L\u00e4nderspiel: Deutschland-Tschechien", "volume": 85, "currservice_fulldescription": "Sportschau\n16:05 - 18:00\n\n* Reporter: Florian Na\u00df\n* Moderation: Alexander Bommes\n\n\u00dcbertragung aus Hannover", "currservice_name": "Sportschau", "currservice_filename": "", "transcoding": true, "currservice_end": "18:00", "currservice_id": 46296}
Of specific interest if you do not want to add the whole response would be the "isRecording" since it can be used to trigger further events within ioBroker (e.g. an Alexa hint).

add: .enigma2.isRecording in enigma2 V1.2.1

Changelog
1.2.2 (2019-08-08)

(Matten-Matten)       correction in .enigma2.isRecording check

Gruß
Matten Matten


The compressed RGBA color value is incorrect.

If the RGB value (the first 6 bits of the value) are the same, the RGBA value (8-bit value) is compressed to 5 bits by the compressor. @PureKrome
    class Program
    {
        static string CompressCSS()
        {
            var css = @"
                a {
                    background: #F9BE4486;
                    color: #FFFFFF20;
                }";
            var compressor = new CssCompressor();
            // The background value is correct.
            // The expected result of color is #FFFFFF20, and the actual result is #FFF20.
            var compressedCSS = compressor.Compress(css); // a{background:#F9BE4486;color:#FFF20}

            return compressedCSS;
        }
    }

Hi @1123612483 - thanks heaps for the bug report.
Unfortunately, this repo is now more in an archive-not-maintained state. I'll happily review and accept PR's but I don't have the capacity for actually working on this repo.

Good news @1123612483  -  a new version 3.1.0 is now up on NuGet.org.
🍰 thanks heaps for the PR!


Feat/ws relay

THis PR merges the ws-relay branch into dev

@heeckhau , i spoke with Jordan, he said it is ok to merge ws-relay into dev


Fixes broken testing dependencies and updates path-to-regexp

Tests were not working due to missing random dependency. path-to-regexp was updated to v1.2.1 for consistency with FlowRouter and Page.js.

Thanks,


Add Lint Rules for missing or wrong RetentionType

@runningcode mentioned in his DroidCon Berlin talk that some Lint rules would be beneficial
This PR adds the first two:

MissingRetention: Qualifier or MapKey annotation did not specify a Retention
WrongRetention: Qualifier or MapKey annotation did specify a Retention other than RUNTIME

@winterDroid which talk?

@winterDroid which talk?

You can find more information on the speaker profile and on the schedule itself. Unfortunately I was not able to link to the talk directly. AFAIK the recordings are not yet published. But here you can find the slides.

Finally found the full talk at https://www.droidcon.com/videos?path=Berlin/2019:
Dagger Reflect - The circle from runtime to compile time and back to runtime
https://www.droidcon.com/media-detail?video=357540042
(not on YouTube yet)


rename [reverse_differentiable] -> [differentiable]; add jvp and vjp

Plumbs JVP and VJP a bit farther along into the compiler. Specifically,

Renames [reverse_differentiable] -> [differentiable]. Also renames corresponding C++ types, function names, and variable names.
Adds JVP and VJP to the [differentiable] SIL attribute.

@swift-ci please test tensorflow


[WIP] Use UIViewPropertyAnimator to allow for animation on iOS

This should close #95, #152, #126, #167 and all the other iOS animation issues.

Unfortunately, UIViewPropertyAnimator is only available on iOS 10+, so it won't fly for those people targeting iOS 9. It'd be nice to find a way to support this for iOS 10, and fall back to something else gracefully on iOS 9.
I had to rework how the views were created here in order to support animating them. We can't teardown subviews on every property change, so I removed those subview dances.
This also adds in a second sample project, which uses a reference to a local package to develop against.
If this is something that people are interested in getting merged, I don't mind breaking things up into smaller PRs so it's easier to review. I wanted to put this PR up to get some feedback on the approach. I'd love to hear what you think!
TODO

[ ] Fall back gracefully on iOS 9
[ ] Add animations to vibrancy views as well.
[ ] ??? Remove BlurAmount?

Wow, looks great! Although, I'd like to ask you to split PR into more atomic chunks:

Blur refactoring
Vibrancy refactoring
New example

Feel free to ping me on twitter if anything.
This is a high prio PR for me, I'll keep an eye on it.

Sounds good! Will do. I wanted to just show my work before opening up too many PRs. I'll tackle this today!
Going to close this PR for now while I open the other PRs first.

I've opened PRs for breaking things down into smaller bits: #170, #171, #172 and #174
I'll leave this closed now, since #174 supersedes it.


Add SORA Kusama Parachain

This is in preparation for setting up a new network for our kusama parachain, as explained here: https://medium.com/sora-xor/the-sora-network-kusama-parachain-auction-5a6fe3a5f35f

Is there anything required from us?

We are waiting on this before starting our Kusama crowdloan. There are around 20,000 people waiting, so is there any estimate on when it can be merged?

Is there anything required from us?

You need to get into contact with @BenWhiteJam

Is there anything required from us?

You need to get into contact with @BenWhiteJam

Thanks for the reply. Can he contact us?
<EMAIL_ADDRESS>

@bkchr: Sora guys are saying they are getting this error because of the missing prefix:
Calling any extrinsic when prefix is 420, I get RPC-CORE: accountNextIndex(accountId: AccountId): Index:: -32602: Invalid params: UnknownVersion.

https://github.com/paritytech/substrate/pull/10541 created this to explain the error better.

@bkchr happy to approve but don't we need to bump the version as well?

Is fine, this will then just be released the next time we bump the version.


Test CI with simple test

Do not merge

This change is

PR is added to the queue for testing as 1. task. (b90dd70)

Test (Fail) 64899149 build is completed (b90dd70)
See https://github.com/ThaliTester/TestResults/tree/64899149b90dd70_Test_CI_with_simple_test_vjrantal/ for the logs

PR is added to the queue for testing as 1. task. (1c812df)

Test 648991491c812df(1c812df) has successfully finished without an error
See https://github.com/ThaliTester/TestResults/tree/648991491c812df_Test_CI_with_simple_test_vjrantal/ for the logs


RM-1305 Update debian OS libs in MPI images

What problem does this PR solve?

We need to update the base Debian image tag for *-mpi-* images to bring in OS lib updates with security fixes from upstream.
More context: RM-1305

What is the solution?

Update the base Debian image tag to quay.io/domino/debian:10.11-20220520-1846, which includes updated OS libs from upstream Debian's package manager.

Imo we can just merge to main. The change I introduced added an optional field so there should be no issues including it in 5.1.3.
Once you merge, you can simply create a tag of 0.6.2, which will publish images and charts.
You can then update the catalog to use that new version for everything after 5.1.3.
In theory we could only update the MPI images in the catalog if you are worried about the code changes to the DCO.
I will leave it to @adp312 to approve since he built these images.

In theory we could only update the MPI images in the catalog if you are worried about the code changes to the DCO.

Yep, my plan is to use this PR for updating only the two MPI images in the 5.1.3 Catalog


Build Debug mode

Hey @svaarala,
I'm trying to compile the command line debugging utility as documented here: https://github.com/svaarala/duktape/tree/master/debugger#using-the-debugger-web-ui
As soon as I run make -f Makefile.dukdebug I get this:
make: *** No rule to make target `examples/cmdline/duk_cmdline.c', needed by `duk'.  Stop.

This is both on the current master branch and on v2.2-maintenance. Is there some prerequisite step that I'm missing? Perhaps I don't understand from the docs how to execute the "compile Duktape command line tool with debugger support" step?

Makefile.dukdebug is intended to be used in the end user distributable. You could start from a distributable (duktape.org/download.html) or create a dist directory yourself in the repo:
$ git clone https://github.com/svaarala/duktape && cd duktape
$ make dist
[...]
$ cd dist/
$ make -f Makefile.dukdebug

But if you're working from a repo checkout, you can just say make duk. The compiled duk command has debugger support enabled (i.e. it supports --debugger option).

Ah, great! Thanks


[Suggestion] DME chams for dead players and weapon

Chams for dead players and weapon in DME hook

Ragdolls and weapons don't go through dme.

Ragdolls and weapons don't go through dme.
Yes, but there is a way to get ragdoll and weapons to go through DME.


Coffeescript support?

Hi!
I was wondering if you guys would be interested in adding coffeescript support to the bin/tape runner. I've already gotten it to work, just wondering if you guys would be interested in me cleaning it up and making a PR, or if you have any strong opinions on how it should be implemented. Thanks!

Coffeescript support is out of scope.
If you want coffeescript just run your tests with coffeescript.
Feel free to publish coffeetape and add a link in the wiki.

Just wrote this: https://www.npmjs.com/package/coffeetape
I didn't see that the wiki was set up, just figured I'd post it here for others to find. Thanks!


Does not seem to work with Constraints and AutoLayout

The key seems to be this line of code in JGFlipMenuItem.swift:
private func setup() {
      menuItemFrame = CGRect(x: 0, y: 0, width: self.frame.size.width, height: self.frame.size.height)

But I have no idea how to adjust it to make it work.

Take a look at the example, it uses constraints. Does your storyboard function correctly before assigning the menu classes?


[Feature/Fix] Check window layout to determine if neighboring windows can be resized

For plugins such as dap-ui, creating an autocmd disabling resize is not enough for focus to avoid resizing windows. After toggling dap ui, the created windows will sometimes be very small due to focus resizing the "main" window.
As a fix for this, I think filetype and buftype checks should be reincorporated into the plugin, and the current window's neighbors (from vim.fn.winlayout) should be checked prior to resize to determine the bounds of the focused window.
I'll get started on a PR for this soon, just submitting this as a known issue marker.

The thing is that you would need tons of special handling code for all the plugins out there. I don't think this is the right solution. Disabling focus globally while in dap-ui would be the right thing to do.

Just tested, #136 fixes the issue with dap-ui so definitely will close this issue.


sh install.sh error

used flutter pub get to download the package, but some how the TensorImage class cannot be used. So I copied and ran the bash file in project root but it gives errors:
readlink: illegal option -- f
usage: readlink [-n] [file ...]
install.sh: line 29: wget: command not found
mv: rename libtensorflowlite_c_arm.so to android/app/src/main/jniLibs/armeabi-v7a/libtensorflowlite_c.so: No such file or directory
install.sh: line 29: wget: command not found
mv: rename libtensorflowlite_c_arm64.so to android/app/src/main/jniLibs/arm64-v8a/libtensorflowlite_c.so: No such file or directory
install.sh: line 29: wget: command not found
mv: rename libtensorflowlite_c_x86.so to android/app/src/main/jniLibs/x86/libtensorflowlite_c.so: No such file or directory
install.sh: line 29: wget: command not found
mv: rename libtensorflowlite_c_x86_64.so to android/app/src/main/jniLibs/x86_64/libtensorflowlite_c.so: No such file or directory``

same problem here

@dijorajsenroy @wolfgio
wget command is not installed properly on your linux machines,
Firstly try to install them
'sudo apt-get install wget'
Then run the script.
If you are in windows then follow instructions to use 'install.bat'

That did the trick here! thanks
btw if you are a macos user you can install wget with homebrew

After trying install wget and sh install.sh it is till giving the error:
: command not found
readlink: illegal option -- f
usage: readlink [-n] [file ...]
: No such file or directory
: command not found
: command not found
: command not found:
: command not found:
: command not found:
'nstall.sh: line 22: syntax error near unexpected token `in
'nstall.sh: line 22: `  case $OPTION in

That did the trick here! thanks
btw if you are a macos user you can install wget with homebrew

brew install wget

After trying install wget and sh install.sh it is till giving the error:
: command not found
readlink: illegal option -- f
usage: readlink [-n] [file ...]
: No such file or directory
: command not found
: command not found
: command not found:
: command not found:
: command not found:
'nstall.sh: line 22: syntax error near unexpected token `in
'nstall.sh: line 22: `  case $OPTION in

same problem :(


/en-US/docs/Archive/Sample_.htaccess_file

Request type

[x] Correction or update

Details
3rd example, 2nd line: footer.php should be footer.html
Place
https://developer.mozilla.org/en-US/docs/Archive/Sample_.htaccess_file

Thanks for your issue! The page in question is archived and won't be updated anymore.


Draft ADR proposing release and integration policy with Apalache

We'll need a thoughtout policy and practice to ensure the best outcomes w/r/t integration and interoperation with Apalache.
Some options discussed today:

keep a loose and unreliable coupling, and just let quint break combat with Apalache
pin quint to specific versions of apalache, and run integration tests against the latest Apalache to catch breackage.
move development of quint and apalache into a monorepo

Let's maybe use this issue to compile requirements before we settle on an approach and document it in an ADR.
cc/ @konnov and @bugarela

For distributing apalache along-with, or thru quint, we can consider these kinds of utilities:

https://www.npmjs.com/package/node-jre would let us ensure a JRE is installed
https://www.npmjs.com/package/jdeploy would us distribute apalache via npm (and we can then add it as a dep in our package manifest)

For distributing apalache along-with, or thru quint, we can consider these kinds of utilities:
* https://www.npmjs.com/package/node-jre would let us ensure a JRE is installed

node-jre is deprecated, and its successor https://github.com/nvuillam/njre hasn't seen updates in over a year (in particular, it still lacks support for the Apple M1 arm64 architecture). So these fall flat.


Add an inactive button to the accoutn edit page

Some Speakerinnen want to deactivate their account for a certain time.
In order to do that we need a button on the account edit page to make the profile "invisible"

I really like this idea! There are definitely a lot of cases where someone might want to not receive requests for a certain time and in that case it’s so helpful for both speaker and conference organiser to have something like that so that no one wastes their time...
you could also make the account still visible (e.g. in search) but add the “inactive” label to it and put it at the bottom of search results for example, if you think it’s still worth having it be seen somehow.

add an attribute for the speaker called "inactive"
remove the contact button and just make some not usable button called "inactive" "nicht aktiv" if inactive
make sure userin can set profile to inactive in edit profile

I have added the inactive column to the profile which is per default "false". The Speakerin and the admin can change the attribute
and then the profile is still visible but the contact button is inactive and the text changed. I did not want to take away the button because then the user of the website would start to find looking for it.
Now need some feedback:, regarding wording and design:
The edit page of a speakerin:

The show page for the speakerin when she is logged in:

The show page for the user of the website:

I would need the text in english and german

Hi Anja, please find my suggestion here:
https://www.figma.com/file/aPmSe86hz49J8n1daelWUBDp/Speakerinnen?node-id=1458%3A3010

it will be great if someone else can look at it and give feedback before you implement it :-)

After nearly a year, this feature is finally done :100:


SharedPreferences: Attempt to set a non-property-list object

When i am trying to store store a string list, it works on android well but on iOS it crashes with the following error message:
[User Defaults] Attempt to set a non-property-list object (     mm,     "<null>",     "<null>",     "",     "0.0",     "" )
On android it stores the null values with ease but here on iOS it crashes
version
shared_preference : ^2.0.7
flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.0.5, on macOS 12.0.1 21A559 darwin-x64, locale en-GB)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
[✓] Xcode - develop for iOS and macOS
[✓] Chrome - develop for the web
[✓] Android Studio (version 4.0)
[✓] Connected device (2 available)

Hi @gau187
Thank you for filing this issue, I tested on the latest stable and master channel with  shared_preferences: ^2.0.8  and the issue is not reproducible. Can you please upgrade your flutter to the latest stable channel: flutter  2.5.3 and  shared_preferences: ^2.0.8 and test again if the issue persists?

code sample
import 'dart:async';

import 'package:flutter/material.dart';
import 'package:shared_preferences/shared_preferences.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'SharedPreferences Demo',
      home: SharedPreferencesDemo(),
    );
  }
}

class SharedPreferencesDemo extends StatefulWidget {
  SharedPreferencesDemo({Key? key}) : super(key: key);

  @override
  SharedPreferencesDemoState createState() => SharedPreferencesDemoState();
}

class SharedPreferencesDemoState extends State<SharedPreferencesDemo> {
  final Future<SharedPreferences> _prefs = SharedPreferences.getInstance();
  late Future<List<String>> _counter;

  Future<void> _incrementCounter() async {
    final SharedPreferences prefs = await _prefs;
    final counter = (prefs.getStringList('counter') ?? ['0']);

    setState(() {
      _counter = prefs.setStringList("counter", ['1']).then((bool success) {
        return counter;
      });
    });
  }

  @override
  void initState() {
    super.initState();
    _counter = _prefs.then((SharedPreferences prefs) {
      return (prefs.getStringList('counter') ?? ['0']);
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text("SharedPreferences Demo"),
      ),
      body: Center(
          child: FutureBuilder<List<String>>(
              future: _counter,
              builder:
                  (BuildContext context, AsyncSnapshot<List<String>> snapshot) {
                switch (snapshot.connectionState) {
                  case ConnectionState.waiting:
                    return const CircularProgressIndicator();
                  default:
                    if (snapshot.hasError) {
                      return Text('Error: ${snapshot.error}');
                    } else {
                      return Text(
                        snapshot.data![0],
                      );
                    }
                }
              })),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 2.5.3, on macOS 11.6.1 20G224 darwin-x64, locale en-US)
    • Flutter version 2.5.3 at /Users/flo/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18116933e7 (2 weeks ago), 2021-10-15 10:46:35 -0700
    • Engine revision d3ea636dc5
    • Dart version 2.14.4

[!] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/flo/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 13.0, Build version 13A5212g
    • CocoaPods version 1.11.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.60.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.27.0

[✓] Connected device (4 available)
    • sdk gphone x86 (mobile)    • emulator-5554                        • android-x86    • Android 11 (API 30) (emulator)
    • iPhone 12 Pro Max (mobile) • 98CBBFB1-4069-4A28-B7F7-138911ACBE72 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-0
      (simulator)
    • macOS (desktop)            • macos                                • darwin-x64     • macOS 11.6.1 20G224 darwin-x64
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 93.0.4577.63

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 2.6.0-12.0.pre.535, on macOS 11.6.1 20G224 darwin-x64, locale en-US)
    • Flutter version 2.6.0-12.0.pre.535 at /Users/flo/fvm/versions/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 04156b6636 (2 days ago), 2021-10-29 18:29:31 -0700
    • Engine revision 3a0a63c2d2
    • Dart version 2.15.0 (build 2.15.0-262.0.dev)

[!] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/flo/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 13.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.60.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.27.0

[✓] Connected device (4 available)
    • sdk gphone x86 (mobile)    • emulator-5554                        • android-x86    • Android 11 (API 30) (emulator)
    • iPhone 12 Pro Max (mobile) • 98CBBFB1-4069-4A28-B7F7-138911ACBE72 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-0 (simulator)
    • macOS (desktop)            • macos                                • darwin-x64     • macOS 11.6.1 20G224 darwin-x64
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 93.0.4577.63

! Doctor found issues in 1 category.

Thank you

@mamuseferha Try setting null values in the list and the put-in sharedpreferences
list = ["hi", null,"test"] sharedPreference.setStringList(list);
Something like this

@gau187 You cannot add null to the list, setStringList does not accept nullable list of strings as a parameter so the code does not compile.
List<String>  ✅
List<String?>  ❌

@mamuseferha Ok, but the same works on android, maybe because of my lower version of flutter

@gau187 yes this could be the case, please update your flutter 2.5.3 and shared_preferences 2.0.8 to the latest. I'll go ahead to close this issue as it is not reproducible, if you disagree please write in the comments and I will reopen it.
Thank you


[Feature Request]: Muti Language support

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
This feature enable user to switch between different languages, currently i am focusing to convert english to hindi but i will implement more languages as you suggest.
Use Case
Any user can interact with the webapp without languagae barriers
Benefits
Increase User Experience.
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

how are you planning to implement this feature?

There is a npm package called i18 and i18-next, with this the languagae of the webapp can be change, so i will implement this feature on the static text and all not on post because the post contain the english words and code that cannot be change. on home page, about us heading like posts, leaderboard and all.

I have no idea how that works so I am not currently assigning any badge and will assign it after reviewing pr.

Ok got it


Spring Webclient Header Propagation

Hi,
Until this time, I was using spring cloud sleuth for propagation. I was using b3 propagation. However, after upgrading to spring 3.0 I removed sleuth, switched to micrometer tracing. I started not being able to propagate b3 headers.
I am using Spring 3.0 + Webflux + Webclient.
To be more specific, my request is:
When I call an endpoint that calls the external source via WebClient, headers such as X-B3-SpanId should be added if there is not, and propagate if there exists.
I did a lot of research, tried many ways, but couldn't solve my problem. I couldn't find any documentation or sample project that provides how to do it. Nothing I've tried has worked either.
I need the guidance of community.
Best regards

Please check this sample for reference https://github.com/micrometer-metrics/micrometer-samples/tree/main/webflux

Thanks
I've actually seen this. But I believe it is very inefficient to apply this to many points in the code.
Maybe we can think about how we can make this work more practical.

I think I might miss something but your issue is that B3 headers are not propagated when you receive a request with webflux and in the controller you want to send another with webclient?
Do you see the W3C header being propagated (traceparent)?

No, W3C headers are not propagated as well.

Yes.
When I don't set management.tracing.propagation.type as B3, traceparent header is propagated.

By the way, now I now able to pass a single b3 header. I will create a sample project and share it here.
However, following headers are still not propagated.
x-b3-parentspanid, x-b3-sampled, x-b3-spanid, x-b3-traceid

@cantaylancapraz is a B3 header being propagated?
The issue we have is that after the upgrade it's defaulting to a single B3 header instead of the multiple X-B3 headers.
If we supply our own Propagation.Factory via
@Bean
Propagation.Factory get() {
    return B3Propagation.newFactoryBuilder().injectFormat(B3Propagation.Format.MULTI).build();
}

we gain the X-B3 multi headers but lose the propagation of remote baggage headers so that might fix your issue but it raises another one for us.
(Related remote baggage fix https://github.com/micrometer-metrics/micrometer/issues/3564)

You're close @jneate , just create your beans like this
@Bean
		BaggagePropagation.FactoryBuilder myPropagationFactoryBuilder(
				ObjectProvider<BaggagePropagationCustomizer> baggagePropagationCustomizers) {
			Factory delegate = B3Propagation.newFactoryBuilder().injectFormat(B3Propagation.Format.MULTI).build();
			FactoryBuilder builder = BaggagePropagation.newFactoryBuilder(delegate);
			baggagePropagationCustomizers.orderedStream().forEach((customizer) -> customizer.customize(builder));
			return builder;
		}

@marcingrzejszczak Hi, I bumped into this issue

it's defaulting to a single B3 header instead of the multiple X-B3 headers

I wonder why is it single b3 now and not multi? Is it documented somewhere? (I can not find) It's actually a breaking change that we could bypass, imo

@shakuzen this is different that you post, I'm asking about multi header approach
We had 3 headers with sb 2.7, e.g. x-b3-traceid and others
but now by default, it's just one header: b3
Please see this code https://github.com/spring-projects/spring-boot/blob/157b71b333473c2633b17362df1be83d6f9eaaed/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/tracing/BraveAutoConfiguration.java#L183

My apologies that things weren't reflected on the issue I linked or the pull request linked from there at the time I made my comment (I also didn't explicitly mention the linked pull request). We had already discussed internally about the requests here and elsewhere for b3 multi header support, and it was subsequently added to the pull request. Please see https://github.com/spring-projects/spring-boot/pull/35611. That will add support for configuring b3 multi via properties.


base-tslint.json missing in projects targeting SP2019

Category

[x] Bug

Describe the bug
Created a new project using the yo generator targeting SP 2019. tslint.json extends a file called base-tslint.json which doesn't exist in @microsoft/sp-tslint-rules/. A similar question was answered suggesting upgrading SPFx but that'll prevent the web parts from working in SP 2019.
Steps to reproduce
Create scaffolding targeting SP 2019
Expected behavior
base-tslint.json exists in @microsoft/sp-tslint-rules/
Environment details (development & target environment)

OS: [Windows 10]
Target Environment: [SharePoint Server 2019]

Additional context

I can't repo... just created a new SPFx project with the v1.10 generator targeting SP2019 & ran gulp build with no errors.
 Suggest deleting your node_modules folder, rerunning npm install & trying again.

I just tried again with brand new SP2019 and SPO projects. They both have the same issue. @microsoft/sp-tslint-rules/base-tslint.json is missing. I'm using<EMAIL_ADDRESS> If you use the tslint extension, you'll see this warning:

.
Steps to repo: Add the following code to your render method:
const str: string = "string";
if (str === "string") {
console.log("string");
}
else {
console.log("not string");
}
run gulp build. You'll see these warning messages:
[08:54:20] Warning - tslint - src\webparts\helloWorld\HelloWorldWebPart.ts(26,5): error one-line: misplaced 'else'
[08:54:20] Warning - tslint - src\webparts\helloWorld\HelloWorldWebPart.ts(22,25): error quotemark: " should be '
[08:54:20] Warning - tslint - src\webparts\helloWorld\HelloWorldWebPart.ts(23,17): error quotemark: " should be '
[08:54:20] Warning - tslint - src\webparts\helloWorld\HelloWorldWebPart.ts(24,19): error quotemark: " should be '
[08:54:20] Warning - tslint - src\webparts\helloWorld\HelloWorldWebPart.ts(27,19): error quotemark: " should be '
Older projects with the @microsoft/sp-tslint-rules/base-tslint.json in place don't complaing about quotes and else's.

OK... now I see what you're saying. These aren't errors, just warnings. But they aren't desirable IMHO. The root problem is both projects (SP2019/SPO), the file ./tslint.json has the extends property pointing to the file @microsoft/sp-tslint-rules/base-tslint.json, but that's not in the @microsoft/sp-tslint-rules package...
Will raise with SP engineering team and see what they say...

I know they’re just warnings but too many invalid warnings will prevent the
developers from catching the legit ones. Thanks for looking into it.
On Fri, May 29, 2020 at 16:21 Andrew Connell<EMAIL_ADDRESS>wrote:

OK... now I see what you're saying. These aren't errors, just warnings.
But they aren't desirable IMHO.
The root problem is both projects (SP2019/SPO), the file ./tslint.json
has the extends property pointing to the file
@microsoft/sp-tslint-rules/base-tslint.json, but that's not in the
@microsoft/sp-tslint-rules package...
Will raise with SP engineering team and see what they say...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SharePoint/sp-dev-docs/issues/5725#issuecomment-636197415,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANH3N7MOGHXDGM2LXLEIB2DRUARMRANCNFSM4M7IIQ3Q
.

--
Thanks,
-Erkan

I see base-tslint.json published in v1.10 and v1.11 e.g. https://unpkg.com/<EMAIL_ADDRESS>When I modify base-tslint.json to include a rule like quotemark and violate in source code tslint warns as expected.
That said, in next release we'll explicitly code the relative path to base-tslint.json.

I see base-tslint.json published in v1.10 and v1.11 e.g. https://unpkg.com/<EMAIL_ADDRESS>When I modify base-tslint.json to include a rule like quotemark and violate in source code tslint warns as expected.
That said, in next release we'll explicitly code the relative path to base-tslint.json.


Fix support for mailto: and tel: links

Corrected an issue with mailto: and tel: links having / prepended to the URL causing Device.OpenUri to not open device mail or phone applications.

#5


Moving average ignored a value of inf/nan when training on 200x200 images

I succesfully trained yolact resnet18 with 200x200 image using old code of yolact
(in this old code, latest merged commit is https://github.com/dbolya/yolact/commit/f46dc4385a41ed1f2df6716ecf6084081afcbec6 )
yolact_resnet18_im200_config = yolact_base_config.copy({
'name': 'yolact_resnet18_im200',
'max_size': 200,
'backbone': resnet18_backbone.copy({
    'selected_layers': list(range(1, 4)),
    'pred_scales': [[int(x[0] / yolact_base_config.max_size * 200)] for x in
                    yolact_base_config.backbone.pred_scales],
    'pred_aspect_ratios': yolact_base_config.backbone.pred_aspect_ratios,

    'use_pixel_scales': True,
    'preapply_sqrt': False,
    'use_square_anchors': True,
}),

})
However, after i clone the latest code and try to train the same model again,
this messages was shown and loss exploded..
"Moving average ignored a value of inf/nan"
this happens right after warmup phase or in the middle of 2 epoch.
whether i use multi or single gpu, this happens.
and even if i change these parameters to 0 (since this is not in old version)
'discard_box_width': 4 / 550,
'discard_box_height': 4 / 550,
again it happens.
the commit after this might affect this instability.
https://github.com/dbolya/yolact/commit/f46dc4385a41ed1f2df6716ecf6084081afcbec6
when i train the same model again with old version, it does not happen.

@zacurr did you ever find a solution? And does the f46dc43 commit work?

@zacurr did you ever find a solution? And does the f46dc43 commit work?


SEMI Baseline. Semantic extraction bug.

Add name of resource in try statement to its semantic.

See this file:
NbValidatioTransaction.txt
Traceback (most recent call last):
  File "D:/git/veniq/veniq/dataset_collection/validation.py", line 69, in <module>
    opport = _print_extraction_opportunities(
  File "D:/git/veniq/veniq/dataset_collection/validation.py", line 18, in _print_extraction_opportunities
    filtered_extraction_opportunities = filter_extraction_opportunities(
  File "D:\git\veniq\veniq\baselines\semi\filter_extraction_opportunities.py", line 24, in filter_extraction_opportunities
    return list(extraction_opportunities_filtered)
  File "D:\git\veniq\veniq\baselines\semi\filter_extraction_opportunities.py", line 21, in <lambda>
    and semantic_filter(extraction_opportunity, statements_semantic, block_statement_graph),
  File "D:\git\veniq\veniq\baselines\semi\_semantic_filter.py", line 16, in semantic_filter
    method_block_statement_graph.traverse(
  File "D:\git\veniq\veniq\ast_framework\block_statement_graph\block.py", line 48, in traverse
    self._traverse_function(self._graph, self._id, on_node_entering, on_node_leaving)
  File "D:\git\veniq\veniq\ast_framework\block_statement_graph\_nodes_factory.py", line 50, in _traverse_graph
    on_node_entering(destination_node)
  File "D:\git\veniq\veniq\baselines\semi\_semantic_filter.py", line 51, in on_node_entering
    self._on_statement_entering(node)
  File "D:\git\veniq\veniq\baselines\semi\_semantic_filter.py", line 81, in _on_statement_entering
    statement_semantic = self._statements_semantic[statement.node]
KeyError: <ASTNode node_type: Try statement, node_index: 2334>

@lyriccoder  the bug you found is not connected with described here previously. I will move you comment to another issue.


Segmentation fault with performance logger on multi-threaded environment

Hello,
I have a multi-threaded program that uses easylogging to do both normal and performance logging. My program is compiled with the define ELPP_THREAD_SAFE. Sometime it crashes randomly and the GDB backtrace always shows me an access violation inside the el::base::DefaultLogDispatchCallback::dispatch function.
Here is the backtrace:
#0  0x0000000000419002 in el::base::DefaultLogDispatchCallback::dispatch(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&) (this=0x674f10,
    logLine=<unknown type in /home/forbinn/test/build-test-Desktop-Debug/test, CU 0x31f1b, DIE 0x75520>) at ../test/easylogging++.cpp:2132
#1  0x0000000000418dc4 in el::base::DefaultLogDispatchCallback::handle (this=0x674f10, data=0x7fffdf7fd090) at ../test/easylogging++.cpp:2105
#2  0x000000000041a211 in el::base::LogDispatcher::dispatch (this=0x7fffdf7fd2b0) at ../test/easylogging++.cpp:2385
#3  0x000000000041af3c in el::base::Writer::triggerDispatch (this=0x7fffdf7fd810) at ../test/easylogging++.cpp:2516
#4  0x000000000041ad08 in el::base::Writer::processDispatch (this=0x7fffdf7fd810) at ../test/easylogging++.cpp:2499
#5  0x0000000000407430 in el::base::Writer::~Writer (this=0x7fffdf7fd810, __in_chrg=<optimized out>) at ../test/easylogging++.h:3246
#6  0x0000000000420c16 in el::base::DefaultPerformanceTrackingCallback::handle (this=0x674e70, data=0x7fffdf7fd8e0) at ../test/easylogging++.h:3579
#7  0x000000000041b7d7 in el::base::PerformanceTracker::~PerformanceTracker (this=0x7fffd00008c0, __in_chrg=<optimized out>) at ../test/easylogging++.cpp:2585
#8  0x000000000041b8a0 in el::base::PerformanceTracker::~PerformanceTracker (this=0x7fffd00008c0, __in_chrg=<optimized out>) at ../test/easylogging++.cpp:2591
#9  0x000000000040b272 in std::default_delete<el::base::PerformanceTracker>::operator() (this=0x7fffdf7fda58, __ptr=0x7fffd00008c0) at /usr/include/c++/6.4.1/bits/unique_ptr.h:76
#10 0x000000000040ab19 in std::unique_ptr<el::base::PerformanceTracker, std::default_delete<el::base::PerformanceTracker> >::~unique_ptr (this=0x7fffdf7fda58, __in_chrg=<optimized out>)
    at /usr/include/c++/6.4.1/bits/unique_ptr.h:239
#11 0x0000000000405eef in <lambda()>::operator()(void) const (__closure=0x7fffdf7fdc7c) at ../test/main.cpp:21
#12 0x0000000000406c5c in boost::asio::asio_handler_invoke<main()::<lambda()> >(<lambda()> &, ...) (function=...) at /usr/include/boost/asio/handler_invoke_hook.hpp:69
#13 0x0000000000406a68 in boost_asio_handler_invoke_helpers::invoke<main()::<lambda()>, main()::<lambda()> >(<lambda()> &, <lambda()> &) (function=..., context=...)
    at /usr/include/boost/asio/detail/handler_invoke_helpers.hpp:37
#14 0x000000000040690b in boost::asio::detail::completion_handler<main()::<lambda()> >::do_complete(boost::asio::detail::io_service_impl *, boost::asio::detail::operation *, const boost::system::error_code &, std::size_t) (owner=0x675c90, base=0x676ca0) at /usr/include/boost/asio/detail/completion_handler.hpp:68
#15 0x000000000040880a in boost::asio::detail::task_io_service_operation::complete (this=0x676ca0, owner=..., ec=..., bytes_transferred=0) at /usr/include/boost/asio/detail/task_io_service_operation.hpp:38
#16 0x0000000000409706 in boost::asio::detail::task_io_service::do_run_one (this=0x675c90, lock=..., this_thread=..., ec=...) at /usr/include/boost/asio/detail/impl/task_io_service.ipp:372
#17 0x0000000000409370 in boost::asio::detail::task_io_service::run (this=0x675c90, ec=...) at /usr/include/boost/asio/detail/impl/task_io_service.ipp:149
#18 0x0000000000409991 in boost::asio::io_service::run (this=0x7fffffffe3c0) at /usr/include/boost/asio/impl/io_service.ipp:59
#19 0x0000000000405fab in <lambda()>::operator()(void) const (__closure=0x6eb498) at ../test/main.cpp:27
#20 0x000000000040703e in std::_Bind_simple<main()::<lambda()>()>::_M_invoke<>(std::_Index_tuple<>) (this=0x6eb498) at /usr/include/c++/6.4.1/functional:1391
#21 0x0000000000406fdb in std::_Bind_simple<main()::<lambda()>()>::operator()(void) (this=0x6eb498) at /usr/include/c++/6.4.1/functional:1380
#22 0x0000000000406fba in std::thread::_State_impl<std::_Bind_simple<main()::<lambda()>()> >::_M_run(void) (this=0x6eb490) at /usr/include/c++/6.4.1/thread:197
#23 0x00007ffff790676f in std::execute_native_thread_routine (__p=0x6eb490) at ../../../../../libstdc++-v3/src/c++11/thread.cc:83
#24 0x00007ffff711473a in start_thread (arg=0x7fffdf7fe700) at pthread_create.c:333
#25 0x00007ffff6e4ee7f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97

This backtrace has been generated by the following program:
#include "easylogging++.h"

#include <vector>
#include <thread>

#include <boost/asio.hpp>
#include <boost/range/irange.hpp>

int main()
{
    constexpr auto count = 10000;
    const auto nbThread = std::thread::hardware_concurrency();

    std::vector<std::thread> threads;
    boost::asio::io_service service;

    for (auto i : boost::irange(0, count))
    {
        service.post([i]
        {
            TIMED_FUNC(blk);
            LOG(INFO) << "Log line " << i;
        });
    }

    for (std::size_t i = 0; i < nbThread; ++i)
        threads.emplace_back([&service]{ service.run(); });

    service.run();
    for (std::size_t i = 0; i < nbThread; ++i)
        threads[i].join();

    return 0;
}

This program creates a thread-pool and push 10 000 tasks in it. It then start n thread (depending on your platform) that output logs as fast as possible.
FYI: it works perfectly if I remove the TIMED_FUNC(blk) line.
Also this program is compiled using the following flags:
-std=c++11 -pthread -O0 -g -Wall -W -fPIC -DELPP_THREAD_SAFE -DELPP_DISABLE_LOGGING_FLAGS_FROM_ARG -DELPP_DISABLE_LOG_FILE_FROM_ARG -DELPP_CUSTOM_COUT=std::cerr -DELPP_STL_LOGGING -DELPP_LOG_STD_ARRAY -DELPP_LOG_UNORDERED_MAP -DELPP_LOG_UNORDERED_SET -DELPP_DISABLE_VERBOSE_LOGS -DELPP_PERFORMANCE_MICROSECONDS -DELPP_NO_DEFAULT_LOG_FILE -DELPP_FEATURE_PERFORMANCE_TRACKING -DAUTO_INITIALIZE_EASYLOGGINGPP

I've found a similar issue using Windows when logging a massive amount of information from multiple threads using a non-"default" logger.  It shows up in a couple different places.  I can't make a pretty stack trace, but in one example it's:
Writer::~Writer
Writer::processDispatch()
Writer::triggerDispatch()
LogDispatcher::dispatch()
DefaultLogDispatchCallback::handle
DefaultLogDispatchCallback::dispatch
LogMessage::level
I've tracked down the issue to the change made in https://github.com/muflihun/easyloggingpp/issues/571 regarding the global lock.  When I revert those specific changes, the issue goes away.  I don't know exactly what's going on, but it seems that DefaultLogDispatchCallback::m_data is being corrupted.

I've tracked down the issue to the change made in #571 regarding the global lock. When I revert those specific changes, the issue goes away. I don't know exactly what's going on, but it seems that DefaultLogDispatchCallback::m_data is being corrupted.

Good job, yea I also tested revert of commit 699c12ed927b02258304cca1514d637b9b67cda7 and it also helped. No more fails and no more mixed output!
So from my point of view it seems that something in dispatch() make mess if it's not synchronized. But, I have no clue what is it. Maybye author of that change @abumusamq could help us?

This issue is fixed in v9.96.4
For those affected by this change you can define ELPP_NO_GLOBAL_LOCK


Nuget Gallery with multiple feeds

@dhinesh333 move from https://github.com/NuGet/Home/issues/4399
Is their any possible ways to provide dynamic feed links in one application
My hosted packages structure Like This,

How can i provide dynamic feed links to host separate versions,
URL structure  like,
http://mydomain/packages/v1 - to host only version 1.0
http://mydomain/packages/v2 - to host only version 2.0
http://mydomain/packages/v3  - to host only version 3.0
All need to be done in one application.
If anyone know what can i do to achieve this ?

@dhinesh333, you can achieve this by deploying NuGet.Server.
A similar question was asked here: https://github.com/NuGet/NuGetGallery/issues/3575
Let me know if this helps.


Created the 'Get inspired' section, for now with slider images

Refers to: #79

I had to resolve the conflicts locally, merged it with current version from Divante repo and fixed the conflicts + the cool bags block


Please publish this on the logseq marketplace

such an important plugin belongs in the marketplace ;-)

it is now

yes, but it has not been updated in a long time, through @sawhney17 did tease some great, almost done functionality - teh much needed ability to name and define connection types - on the logseq discord some time ago


Default files encoding as UTF-8

I use Windows 7
In my preferences I selected UTF-8 as default files encoding.
Pic 1: http://joxi.ru/j1A5DKecDnOQ2E.jpg
But my files are opened in cp1251
Pic 2: http://joxi.ru/QeAOgzaT9xqeAo.jpg
If I changed the encoding for file then everything becomes fine. But after application reload it become to use system encoding again (cp1251).
Pic3: http://joxi.ru/8ZrJ7zWUw90Kmj.jpg
Is it a bug? Or I'm doing something wrong?

I have the same problem. Just came here to report this bug and noticed that it's already reported. This is very annoying problem because all my files has UTF8 encoding and contains cyrillic symbols. It's very inconvenient to switch encoding every time I open file.


Setting a default() for config() causes an error on --help

var argv = yargs.usage('Usage: $0 [options]')
  .config('c').alias('c', 'config').default('config', 'config.json')
  .help('h').alias('h', 'help').argv;

When someone tries to run command --help, yargs throws an error because config.json isn't found. But that feels not ideal. My expectation was that it'd print the help text as normal.
Is there something I'm missing?
Thanks!

@rdmurphy see: https://github.com/bcoe/yargs/issues/172
I think we need to fix the behavior around config:

perhaps we should warn if a config is missing rather than throw an error?
we should not show the warning if --help has been passed.

@rdmurphy If you don't mind, could you give this branch a shot:
https://github.com/bcoe/yargs/pull/197
I think it solves your problem for you -- and I can always use the extra help with QA.

@rdmurphy if you install<EMAIL_ADDRESS>this problem should now be solved for you.

Wasn't able to get around to checking this out last weekend, but that's great! Thanks!


deps: use native Promise instead of bluebird

Just extracted promised-method from node-auth-validation (https://github.com/Brightspace/node-auth-validation/blob/master/src/promised.js).
There exists a similar package, but wasn't a fan of the implementation, even though it's all trivial.

Coverage increased (+0.5%) to 41.065% when pulling 670fdc77f4752fc2b67354546bc3c72cc8b6e94a on omsmith:use-native-promise into 9685d4e6eda65a7d52301267315c8f09e2bc916d on Brightspace:master.

Native promises have been getting faster, and have debug/trace-ability benefits over bluebird.

You were very quick with that amend. Ignore my review comments.

Coverage increased (+0.5%) to 41.065% when pulling bdfa11cd48f3bd976296ce1b3c5ab5c78dcc9262 on omsmith:use-native-promise into 9685d4e6eda65a7d52301267315c8f09e2bc916d on Brightspace:master.

@ppaskaris-d2l should be good now


Support custom blockSize during flannel -> calico migration

Expected Behavior
I want ippool blocksize is 24
Current Behavior
ippool blocksize is 26
Steps to Reproduce (for bugs)
a ks8 cluster with flannel(vxlan).
migrate flannel to calico,
kubectl apply -f https://docs.projectcalico.org/manifests/flannel-migration/calico.yaml
kubectl apply -f https://docs.projectcalico.org/manifests/flannel-migration/migration-job.yaml
Client Version: v3.21.2
Cluster Version: v3.21.2
Cluster Type: k8s

it is not a bug.
I can find the relevant code, but I can't understand why this is done.
// Based on FlannelSubnetLen, work out the size of ippool.
blockSize := defaultIppoolSize
if m.config.FlannelSubnetLen > defaultIppoolSize {
	// Flannel subnet is smaller than one Calico IPAM block with default size of /26.
	blockSize = m.config.FlannelSubnetLen
}

Why is defaultIppoolSize 26, can I change it to 24？

You can migrate your workloads to another IP pool with a different block size per the instructions here: https://projectcalico.docs.tigera.io/networking/change-block-size
Calico's default block size is /26, but Calico will allocate additional blocks and clean them up as needed, so you are not actually limited to 64 addresses (if a node needs more, then more will be allocated to the node on-demand)

I think it would be OK to PR a change that makes defaultBlockSize configurable via an environment variable.

One thing to note is that the block size must be smaller than or equal to the flannel block size so that we don't accidentally take a CIDR that already belongs to another node.

We're actually running into issues that a pod IP on a (still) flannel node isn't reachable from a (already) calico node.
The pod's IP is <IP_ADDRESS>, so falls into the <IP_ADDRESS>/26 block.
Calico nodes only have a route for the <IP_ADDRESS>/26 block.
I assume the reason for the latter is that Calico itself hasn't assigned any IPs from the ...192/26 block yet (it was assigned by Flannel) so doesn't provide the routes for it?
@caseydavenport can you confirm this?
In that case it would be a bug that during the migration part of the inter-pod communication is disrupted.

We're actually running into issues that a pod IP on a (still) flannel node isn't reachable from a (already) calico node.

@squ94wk could you raise another issue for that? That sounds like a different issue than this one.

@caseydavenport Roght. I have raised https://github.com/projectcalico/calico/issues/5349.
This here would still provide a workaround for my issue.


[Misc] [CI] Fix CI failure caught after merge

FAILED spec_decode/e2e/test_correctness.py::test_spec_decode_e2e_logical_flow[1-1-test_llm_kwargs0-per_test_common_llm_kwargs0-common_llm_kwargs0] - TypeError: Worker.__init__() missing 1 required positional argument: 'load_config'

FAILED spec_decode/e2e/test_correctness.py::test_spec_decode_e2e_logical_flow[1-1-test_llm_kwargs0-per_test_common_llm_kwargs1-common_llm_kwargs0] - TypeError: Worker.__init__() missing 1 required positional argument: 'load_config'

Caused by merge race between https://github.com/vllm-project/vllm/pull/4097 and https://github.com/vllm-project/vllm/pull/3894

the AMD test agent is hung for some reason; I used this CI run to discover this https://buildkite.com/vllm/ci/builds/4916#_


Add paginations to the adjustments/index page

Summary
We recently added the kaminari gem for pagination in #1254. This PR added pagination to the donations/index page. We should add this to the other places where we have records that could end up with unwieldy page scrolling. This issue is to add this to the adjustments/index page. You should be able to look at PR #1254 for an example of how to accomplish this with Kaminari.
Criteria for completion

[ ] Pagination present on the adjustments/index page

@benreyn Can I work on this ?

Absolutely! 😄 Thanks for jumping in @anoopmadhav!


pubsub/kvindexer:support for big numbers - v2

Closes #769 and #767
This is a second version of the implementation adding support for big numbers - integers and floats.
In this PRs all numbers are converted to Big.Floats but when converting integers, the floating point precision is set to the number of bits needed to represent the integer.
The following other updates and fixes are included in this PR:
kvindexer:

events stored as floats have been ignored, and not read from the database
query conditions could not contain floating point values nor big int values

pubsub:

query conditions could not containg big int nor big float values
very big ints and floats would still loose precision even when using big.ParseFloat as the default precision is 64.

PR checklist

[x ] Tests written/updated
[x] Changelog entry added in .changelog (we use unclog to manage our changelog)
[x] Updated relevant documentation (docs/ or spec/) and code comments

Thanks Jasmina. Some comments, but overall looking quite good!
Do we need to add a changelog entry?

@sergio-mena , yes definitely, just uploaded them.


Unable to do testing with semantic kitti using pretrained model

Hello Thanks for providing the repo. I have tried to follow all the steps in google colab.  But, at the end of the main.py file, the code
train_dataset_loader, val_dataset_loader, test_dataset_loader = build_loader(configs)
model_file = importlib.import_module('network.' + configs['model_params']['model_architecture'])
my_model = model_file.get_model(configs)
the above code is not loading the network.arch_2dpass.py and the testing is not being started.
Please help regarding this.

Did you download our checkpoint and set the checkpoint through --checkpoint?

Did you download our checkpoint and set the checkpoint through --checkpoint?

Hello, I have downloaded the check point and gave the path from Google colab correctly as well ...but the last loop which i mentioned is not working.... I have tried to read the network.arch_2dpass.py file manually also but still it's not working.....please help


Milestone filter in Issues section

Gitea version (or commit ref): 1.11.3
Git version: 2.20.1
Operating system:
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:

Description
When access to Issues, we can filter them.
In section "Open", the Milestone filter display only open milestone.
In section "Closed", the Milestone filter display only closed milestone. But I was expected to be able to filter closed issue according an in progress milestone.
Notice that it is possible.
First, I go to "Open" section for issues.
Then I filter on the expected Milestone.
Then I go to "Closed" section. In this case, the Milestone filter is applyed.
...
Screenshots
Display issues in "Open" section with a milestone selected

Display issues in "Closed" section, same milestone filter as previous screen capture, selected milestone not displayed.

/reopen

If I understand correctly, I think this is fixed.


Matching braces in large files cause a large amount of data to be pushed on LOH

Trace: https://developercommunity.visualstudio.com/content/problem/245786/slow-f-editing-experience-up-to-a-minute-until-typ.html
GC Rollup By Generation

Gen
Count
MaxPause
MaxPeak MB
Max AllocMB/sec
TotalPause
TotalAlloc MB
Alloc MB/MSec GC
Survived MB/MSec GC
MeanPause
Induced

ALL
5196
1,652.0
744.6
8,424.125
40,245.7
29,166.1
0.7
1.026
7.7
18

0
3869
886.0
744.6
8,424.125
14,865.1
20,456.4
0.5
0.083
3.8
0

1
1286
53.5
744.6
3,284.108
17,473.7
8,524.0
0.6
0.746
13.6
0

2
41
1,652.0
744.6
502.652
7,906.8
185.7
0.3
7.355
192.8
18

6 MB of data on the LOH:

Addressed by #6001


Update selenium-java to 3.141.59

Updates org.seleniumhq.selenium:selenium-java from 3.14.0 to 3.141.59.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.seleniumhq.selenium", artifactId = "selenium-java" } ]

labels: library-update, semver-minor

Codecov Report

Merging #11 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop     #11   +/-   ##
=======================================
  Coverage     3.44%   3.44%
=======================================
  Files            2       2
  Lines           29      29
=======================================
  Hits             1       1
  Misses          28      28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31d1b6b...8ad010d. Read the comment docs.


previous attributes, orginal attributes not getting updated in version 3.5

After taking new update of backgrid (ver 3.5) previous attributes and orginal attributes of model are not getting updated its an big issue, i am checking it at backgrid: edited event is fired and comparing both model.attributes and model._previoustAttributes it not getting updated, In previous version it worked well
can you please help me with this sissue @wyuenho

Closing for being stale


Remove references to aggregation attribute on Workflows

The workflows table has an aggregation attribute that's going to collide with the new relation to the aggregations table. As far as I can tell, the only use for this was to indicate whether associated aggregation resources were "public" or "private".
This PR includes aggregation in the Workflow model's ignored_columns and removes references to this column from elsewhere. A subsequent PR will include the migration to remove the column from the database. Because ActiveRecord caches attributes at runtime (and aggregation is serialized on workflow resources), this will prevent exceptions between deployment and migration. I also needed to do some short circuiting in the policy specs, but they're all getting removed/rewritten in the batch agg PR.
Mostly this is to satisfy strong_migrations and stick to best practices. The migration PR will be a quick one to review/deploy before the batch agg PR merges.
Review checklist

[ ] First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
[ ] If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
[ ] If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
[ ] Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

Seems most sensible to just deprecate the AggregationsController now in advance of https://github.com/zooniverse/panoptes/pull/4303. This PR should fix the issues causing those specs to fail, and that PR fully refactors the AggregationsController and its spec.


Genesys: ShipWeapons - No selection of the skill to use

In Genesys, Vehicule Weapons generally use Gunnery, but not always, we should have the option of selecting a different skill to use for the weapon

Maybe be able to link a "pilot" on the vehicle so it uses their stats and the skill rolled from the vehicle sheet.

@Esrin This item has already been merged.

Fix has already been merged.


in composer.json 2.x versions not support php 7.2, 7.3, 7.4

sorry, its problem config platform composer


Disable report form submit buttons while submitting

Since we don't use the standard Formik submit handling here (because of the non-standard validation), disable them in our own submit handler.

Do we also need to setSubmitting(true) somewhere in "reports/Show.js" ?

Only if we feel it serves any purpose.


Fixes failing model generation when using namedtuple type

This pull request intends to fix model generation while using named tuple type defined in schema:
Example:
money:= <tuple<amount: decimal, currency: str>>$money,
which leads to the following error when trying to generate code:
ValueError: Unknown type: NamedTupleType(desc_id=UUID('e25571c7-d5a0-5427-83f5-4beb3caf4636'), name='tuple<amount:std|decimal, currency:std|str>', element_types={'iso2code':...

Thank you for your PR, LGTM


Provide globally convergent scalar Newton method

Current Newton's method fails on atan x = 0 if started far from x = 0, e.g x = 5.
Add line search to enhance the convergence.
Slice available here: http://smalltalkhub.com/#!/~PolyMath/PolyMathInbox/versions/SLICE-Issue-1-Globally-convergent-Newton-method-MobiusEng.1

Added in v0.55


v0.5.0-alpha, TextDiffContent HTML shows texts in inappropriate style

See the screenshot

v0.5.0-alpha, TextDiffContent HTML is wrongly styled.

I know what caused this.
https://github.com/kazurayam/materialstore/blob/develop/src/main/resources/com/kazurayam/materialstore/reduce/differ/style.css
td, th {
    font-size: 12px;
    border-right: 1px solid #ccc;
    display: table-cell;
    overflow-wrap: break-word;
}

The CSS property overflow-wrap: break-word caused this.

There is another issue.

v0.4.x, the a sequence of  tags are compact --- has fewer number of white spaces in betweeen.

            1

              @font-face {

v0.5.0-alpha, the sequence of tags are delemited by more of whitespaces.

            1

                  @font-face {

The whitespaces could be significant for CSS styling

fixed at v0.5.0


fix(formula): subtotal count

close #2018
close #2035
close #2038
close #2141
close #698

close #2129 close #755 (这些 issue 在以前的PR中附带修复，可以一起测试下)

Pull Request Checklist

[x] Related tickets or issues have been linked in the PR description (or missing issue).
[x] Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
[x] Unit tests have been added for the changes (if applicable).
[x] Breaking changes have been documented (or no breaking changes introduced in this PR).

#2141
局部样式粘贴为公式时，还是会携带样式

#2141 局部样式粘贴为公式时，还是会携带样式

fix


Enhance the autocorrect for Style/FetchEnvVar

https://github.com/rubocop/rubocop/issues/10578
This PR enhances the autocorrect for Style/FetchEnvVar.
When an ENV[] is the LHS of ||, the autocorrect makes the RHS the default value of ENV.fetch.
Examples
# from
ENV['X'] || 'y'

# to
ENV.fetch('X', 'y')

# from
ENV['X'] || ENV['Y'] || a

# to
ENV.fetch('X') { ENV.fetch('Y') { a } }

# from
z || ENV['X'] || y || ENV['Z'] || a || ENV['B']

# to
z || ENV.fetch('X') { y } || ENV.fetch('Z') { a } || ENV.fetch('B', nil)

# from
ENV['X'] || y.map do |a|
  a * 2
end

# to
ENV.fetch('X') do
  y.map do |a|
    a * 2
  end
end

Please refer to the RSpec file for more examples.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

I added some additional test cases and fixed the code to make them pass.

As I noticed in this PR, I think most ENV['TERM'] || something should be allowed. Rewriting this to ENV.fetch('TERM', something) or ENV.fetch('TERM') { something } has no of the following benefits:
      # This cop suggests `ENV.fetch` for the replacement of `ENV[]`.
      # `ENV[]` silently fails and returns `nil` when the environment variable is unset,
      # which may cause unexpected behaviors when the developer forgets to set it.
      # On the other hand, `ENV.fetch` raises KeyError or returns the explicitly
      # specified default value.

Yeah, given ENV['TERM'] || something is allowed in https://github.com/rubocop/rubocop/pull/10582 , this PR may be no longer needed.

Rewriting this to ENV.fetch('TERM', something) or ENV.fetch('TERM') { something } does not have much of the following benefits:

Yeah, that sounds correct. This problem somehow looks silmilar to https://github.com/rubocop/rubocop/pull/10582 .

As I noticed in this PR, I think most ENV['TERM'] || something should be allowed. Rewriting this to ENV.fetch('TERM', something) or ENV.fetch('TERM') { something } does not have much of the following benefits:

Still, to me this seems like the type of thing that can be optimized as the || check is essentially the same and hash has this API exactly to handle this common scenario (default value for a missing key). I do agree, however, that the optimization is not critical, so perhaps we should just have a config for the cop wether to detect and fix usages of || and or and to fix them. I, myself, would be fine if we don't and we just flag and fix all of them, as I prefer fetch + default value all of the time.  Am I missing some case in which using || is actually more useful?

Rewriting this to ENV.fetch('TERM', something) or ENV.fetch('TERM') { something } does not have much of the following benefits:
User can get the KeyError, but the fact that the default value is used would mean that it supplements that condition.

I understand the above that both codes below are read as “Get 'TERM' environment variable if it's set, otherwise, get the return value of something", so correcting the first one doesn't make any changes to the behavior when the environment variable isn't set unexpectedly, plus,  that diverges from what this cop is originally addressing, correct?
ENV['TERM'] || something

ENV.fetch('TERM', something)

I think using an option is a way, while there’s another way that we can see how it goes allowing ENV[] with || for now to move forward little by little, although I’m not sure which is the best for users.

It seems to me that this is what @koic meant, but he has to clarify himself. We can always tackle this separately in a different cop, although perhaps that'd be an overkill.

the || check is essentially the same and hash has this API exactly to handle this common scenario (default value for a missing key).

I'm sorry, I was misunderstanding 💦  The above comment makes sense. So, there is no problem correcting it with compatible API.


feat: add GitHub Actions workflow for Docker build and CDK deployment

feat: add GitHub Actions workflow for Docker build and CDK deployment

Introduced a new workflow in .github/workflows/deploy.yml to automate the Docker image build and AWS CDK deployment processes.
The workflow consists of two jobs: docker_build for building and pushing the Docker image to AWS ECR, and cdk_deploy for deploying the built image using AWS CDK.
Configured necessary permissions and environment variables for AWS interactions.
Implemented caching for Docker builds and Node.js dependencies to optimize build times.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5  👈 (View in Graphite)
#4
main-lachie

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Dec 23, 11:16 AM EST: A user started a stack merge that includes this pull request via Graphite.


Fix release note formatting

Summary
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.891%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
17362

Relevant Lines:
20214

💛  - Coveralls


scheduler(cdc): fix latency spike when a new capture online

What problem does this PR solve?

Issue Number: ref #4757
What is changed and how it works?
Latency has spike when a new capture online, bcause there are too many concurrent running move table tasks.
They bring unbouned load when there are many tables being captured.
This PR limits the concurrent running tasks to fix the spike.
Check List
Tests

Unit test
Manual test (add detailed scripts or steps below)

tpscheduler without limit
tpscheduler with limit

Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note
None

Codecov Report

Merging #6154 (f6df150) into master (792faf7) will decrease coverage by 0.7317%.
The diff coverage is 68.8196%.

Flag
Coverage Δ

cdc
63.6002% <75.8893%> (-1.6067%)
:arrow_down:

dm
51.9143% <44.3243%> (-0.0095%)
:arrow_down:

engine
62.5619% <73.4299%> (-0.0692%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #6154        +/-   ##
================================================
- Coverage   58.6479%   57.9162%   -0.7318%
================================================
  Files           711        701        -10
  Lines         83933      83089       -844
================================================
- Hits          49225      48122      -1103
- Misses        30258      30608       +350
+ Partials       4450       4359        -91

/merge


Bundle file should use Directive AppName

Instead of runnables.wasm.zip, we should name the file based on the appName in Directive.yaml, i.e<EMAIL_ADDRESS>

hey @cohix
can I pick up this one?

@kurious-diru hello! even though I filed this issue, I'm not actually sure if I think it's a good idea any more :) The main reason being that currently Atmo has a single filename to look for when starting up. If we start changing the name of the file, it would make it easier to know which file relates to which application, but it would also make it trickier for Atmo to figure out where to get the file from.
Interested to hear @javorszky and @jagger27 thoughts on this.

Hm... what was the original reason why this came up? Does it matter what the file is called? Is the file used anywhere else besides internally as a transient step between a directive file and running the runnable?

@javorszky the main thing here is knowing which version the bundle is for. If I have a runnables.wasm.zip file that was built by subo build, I have no idea which version of the application this was for.
The name of the file doesn't actually matter, it's mostly for human-readable convenience reasons.

Wouldn't you want to recompile the runnables before starting a dev server in either case? Knowing what version of the appliaction (I assume... reactr?) the wasm zip was build for is nice, but is that useful to know? What decisions does that inform?


Redis routing fix for backend proxy

Fixes #82 and #80.

Due to bad regex handling, the gateway wasn't able to proxy properly to the backend (#82). Based on discussion with @mhamann and @codymwalker, modified routing.lua to find the correct redis key based on the number of slashes in basePath + resourcePath
Updated how path parameter is handled with the new design
Also fixed the cases where the resource path is just a single "/" (#80)

@mhamann @codymwalker @DavidMGreen PTAL

@mhamann Added additional unit tests for the routing logic


C API for EntityReference

What
Following on from #549, we must implement the C API for the EntityReference class and its related Manager member functions.
Why
This is a requirement for a functional C host.
Notes
Design sketch:

/**
 * Entity reference destructor.
 *
 * Note: not paired with a constructor, since
 * `Manager.createEntityReference` should always be used.
 */
void oa_EntityReference_dtor(oa_EntityReference_h handle) {
  EntityReference* entityReference = handles::EntityReference::toInstance(handle);
  delete entityReference;
}

/**
 * Get a copy of the underlying entity reference string.
 *
 * Assumes noexcept.
 */
void oa_EntityReference_toString(oa_StringView* out, oa_EntityReference_h handle) {
  const EntityReference* entityReference = handles::EntityReference::toInstance(handle);
  openassetio::assignStringView(out, entityReference->toString());
}

/**
 * Check whether a given string is an entity reference relevant
 * to the manager.
 *
 * Assumes noexcept.
 */
bool oa_hostApi_Manager_isEntityReferenceString(oa_hostApi_Manager_h handle,
                                                oa_ConstStringView entityReferenceString) {
  const hostApi::ManagerPtr& manager = *handles::hostApi::SharedManager::toInstance(handle);
  return manager->isEntityReferenceString(
      {entityReferenceString.data, entityReferenceString.size});
}

/**
 * Construct an EntityReference.
 *
 * This is the only way of creating an EntityReference in the C API. The caller is responsible
 * for cleaning it up with oa_EntityReference_dtor.
 */
oa_ErrorCode oa_hostApi_Manager_createEntityReference(oa_StringView* err,
                                                      oa_EntityReference_h* out,
                                                      oa_hostApi_Manager_h handle,
                                                      oa_ConstStringView entityReferenceString) {
  return errors::catchUnknownExceptionAsCode(err, [&] {
    const hostApi::ManagerPtr& manager = *handles::hostApi::SharedManager::toInstance(handle);

    std::optional<EntityReference> maybeEntityRef = manager->createEntityReferenceIfValid(
        {entityReferenceString.data, entityReferenceString.size});

    if (!maybeEntityRef) {
      openassetio::assignStringView(err, "Invalid entity reference");
      return oa_ErrorCode_kInvalidEntityReference;
    }

    *out = handles::EntityReference::toHandle(new EntityReference{std::move(*maybeEntityRef)});
    return oa_ErrorCode_kOK;
  });
}

Whilst sketching out the C API for BatchElementError in #557, it became apparent that we may need additional C functions for constructing a batch of entity reference objects.
For batch functions such as resolve we need to take a list of EntitiyReference objects.  Naively, these could be created one-by-one using oa_hostApi_Manager_createEntityReference, and added to a C array of oa_EntityReference_h handles.
In C++ terms we then have a C array of pointers to EntityReference objects.  The current design of our batch methods takes a std::vector<EntityReference> - i.e. a contiguous array.  To convert from an array of pointers to a contiguous array means copying every element.
So we may wish to bind an oa_EntityReferenceList_h type, which wraps a std::vector, and add oa_hostApi_Manager_addEntityReference-like functions that append to the underlying std::vector.  This would then be trivial to unpack in the C->C++ API.

A potential improvement to the above would be to alter the argument oa_EntityReference_h* out to oa_EntityReference_h out, i.e. expect a pre-allocated EntityReference, which will be "filled in".  This allows the host to re-use storage, rather than necessitate a dynamic allocation with every createEntityReference call.
Such a scheme would be particularly useful with respect to the above comment, i.e. for building a vector of entity references.
E.g.

oa_EntityReferenceList_h refListHandle = oa_EntityReferenceList_ctor();
oa_EntityReference_h refHandle = oa_EntityReference_ctor();

oa_hostApi_Manager_createEntityReference(err, refHandle, managerHandle, firstRefString);
oa_EntityReferenceList_append(refListHandle, refHandle)

oa_hostApi_Manager_createEntityReference(err, refHandle, managerHandle, secondRefString);
oa_EntityReferenceList_append(refListHandle, refHandle)

oa_EntityReference_dtor(refHandle);

oa_hostApi_Manager_resolve(..., refListHandle, ...);

oa_EntityReferenceList_dtor(refListHandle);

This seems quite efficient, but has the disadvantage that we allow entity reference objects to be constructed independently from createEntityReference.  But then C devs are supposed to be grown-ups.

C-Api needs more holistic thinking, out of date.


Extract json_serializable test utils into an independant package

An unusual request for once:
I've been exploring a bit into the test folder of json_serializable and I got quite surprised to find a small testing framework included.
I think it would be interesting to extract everything related to ShouldThrow/ShouldGenerate into a reusable package.

Glad you like it! I'll consider it.
In the meantime, feel free to copy/paste. 😄

I started that on my own, which you can see here: https://github.com/rrousselGit/functional_widget/tree/functions/code_gen_tester
I changed a few things so that we don't decorate the element but instead manually trigger it within the test file:
testGenerate('foo', (tester) async {
  await expectGenerate(tester, MyGenerator(), throwsInvalidGenerationSourceError('message'));
}, path: 'path/to/input.dart');

I also changed resolveCompilationUnit util, so that it works with files that are not the first in the folder.

@rrousselGit check out https://github.com/dart-lang/json_serializable/pull/398
I'm going to move this issue to https://github.com/dart-lang/source_gen/ – since that's where the code will (likely) end up