Convert the search store to Pinia

Fixes

Related to #756 by @sarayourfriend
Description

This is a bigger PoC for Pinia migration based on the ideas from the RFC. The intention is to see:

how Pinia stores can be used from Vuex stores and vice versa,
how to best structure a setup store considering that setup stores give us more flexibility and responsibility for store organization, and
to figure out the best testing strategies.

Converting Vuex mutations
I have removed the simple mutations that existed only because of the Vuex limitations that did not allow mutating state inside actions: SET_SEARCH_TYPE and SET_SEARCH_QUERY. The effect of these is easy to test within the actions by checking the resulting state.
Larger mutations were converted into Pinia actions.
Extracting the filterStore from the searchStore
To make the store more organized, I've extracted the filterStore to a separate file. It is private as in its data functions are only used by the searchStore, and components do not access it (but they could). My main concern in making it a part of the search.js file is the fact that it would make the file very long and hard to read.
We could also just make the filterStore a completely separate store, and make components use it directly and not through the searchStore. This would simplify the re-exporting of filterStore actions and getters by the searchStore, but it would cause two useXStore lines in the components that use both stores instead of one useSearchStore as it is now. I think I actually prefer having filterStore as a separate store because re-exporting looks complicated.
searchStore

The searchStore only handles the searchType and the query object, which holds the data about the search term and the filters that are available for it in the form that can be used for the API request.

filterStore

Everything related to filters and filter manipulation is  extracted into a filterStore. It is an internal store, meaning that it is only used by the searchStore. If components need it, they use the actions and getters of the searchStore, which are sometimes simply re-exporting those of the filterStore.

Working with Vuex stores

To ensure that we do not have circular imports, mediaStore uses the searchStore only inside functions.
mediaStore, which is still in Vuex, uses the search store inside functions (getters, actions, mutations).

Testing
This PR has almost 100% coverage for both filter and search store. It also adds some more e2e tests for the behavior that has been affected by the PR changes.
Other changes

some searchStore actions were changed from async to sync because they do not use network calls, and don't need to be async.
mature filter was refactored to use an object type instead of a boolean to match all other filters.
pinia removed from package.json devDependencies because it is already listed in dependencies.
removed unused module, action and mutation constants.
the creation of filters list is moved to constants to make the filter store more readable.
removed a return that's outside of a function in json-to-pot (to clean up test output).
some methods in search.vue page were moved into the setup function.

Testing Instructions

Run the app and check that following actions, affected by the changes in this PR, work as expected, both on SSR and on the client:

filtering (toggling filters, clearing filters, changing applied filters when changing the search type)
searching various content types.

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

We could also just make the filterStore a completely separate store, and make components use it directly and not through the searchStore. This would simplify the re-exporting of filterStore actions and getters by the searchStore, but it would cause two useXStore lines in the components that use both stores instead of one useSearchStore as it is now. I think I actually prefer having filterStore as a separate store because re-exporting looks complicated.

FWIW I think we'll only benefit from smaller more atomic and contained stores, even if it means components have to call to multiple stores. I'd rather have the search store watching but not manipulating the filter store and let components interact with the filter store directly. To me that's more straightforward than "reexporting" the filter store from the search store.

This PR looks really good, but it feels like several changes in one place. I could see this being a few smaller PRs instead. #906 seems like a smaller batch of changes for an initial pass at adding Pina and also uses the setup store pattern.
What's the plan for how to proceed with these two PRs? Will we merge #906 and then this PR?

This PR looks really good, but it feels like several changes in one place. I could see this being a few smaller PRs instead. #906 seems like a smaller batch of changes for an initial pass at adding Pina and also uses the setup store pattern.
What's the plan for how to proceed with these two PRs? Will we merge #906 and then this PR?

This is fair. I am going to break this PR into two:

extracting filter as a Pinia setup store
converting what's left of the search store into a Pinia setup store
The plan is as you say, merge 906 first, then the first part of this PR, and then, hopefully, the second.

I've split this PR into #1038, #1039 and #1040, so I'm closing it.


[NEW ICON] Delphi

Skill Name
Delphi
Why?
Delphi is a derivative of Object Pascal and still finds use in the Software industry for GUI applications.
Reference Image

I don't think this is a popular/modern skill

fair enough


Test case on Github invalid

Hello @bdc-ehealth ,
As mentioned in the issue ESI-224, I tried the Visualization Tool on an existing test case :
https://github.com/hl7-be/lab/blob/master/testing/MIPS/UZG_scenario1/1d_bundle_22030216201.json
The validation failed :

Can you check why ?
Best regards

I checked this, and the problem is not caused by the file, but by the changed validation rules. There is a new requirement that for codes in general (and thus also for LOINC codes) the values in the discription field should correspond with the value available on the terminology server.  For the lab report, this is not always the case, because labs are allowed (although not recommended) to use their own display values. In order to allow this, we will have to add an extra parameter to the validator (see: https://github.com/hl7-be/lab/issues/199 )

We wait for the 6.0.16 release of the international validator to be able to fix this.

6.0.16 is available and tested. Now we have to change our code to add the parameter.

@khackincita Hi Kevin, we integrated the new validator in our code, and all should be well again!


[harvester] harvester dashboard -> embedded grafana page shows no data, incorrect link is embedded

Setup

Rancher version: v2.6-head (0dd1ce6)
Browser type & version: chrome

Describe the bug

embedded grafana page on the harvester dashboard works through harvester, but not on rancher on the imported harvester cluster.
To Reproduce

deploy harvester setup
in rancher, import the harvester setup through virtualization management
after importing, navigate to the harvester dashboard through rancher

Result

grafana shows no data for all fields. Grafana link also shows no data

Expected Result
Grafana should show proper data through rancher
link should be to /proxy/d/rancher-cluster-nodes-1/rancher-cluster-nodes?orgId=1&from=now-5m&to=now&refresh=30s&theme=dark (pullled from the harvester grafana URL) instead of to what it is currently set to, /proxy/d/harvester-vm-dashboard-1/harvester-vm-dashboard?orgId=1&from=now-5m&to=now&refresh=30s&theme=dark
additional context
Here is the harvester feature targeted for 0.3.0

should be addressed via https://github.com/rancher/dashboard/pull/4285

Pending on PR https://github.com/rancher/dashboard/pull/4285


[MINOR] typo in env_setup.sh

there is a typo in env_setup.sh
enviornment >> environment

Can you check if there are more types while we're here?

Codecov Report

Merging #778 into master will decrease coverage by 1.94%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
- Coverage   93.97%   92.02%   -1.95%
==========================================
  Files          32       32
  Lines        5756     5756
==========================================
- Hits         5409     5297     -112
- Misses        347      459     +112

Impacted Files
Coverage Δ

databricks/koalas/usage_logging/__init__.py
23.14% <0%> (-74.08%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
50% <0%> (-50%)
:arrow_down:

databricks/koalas/__init__.py
75% <0%> (-10%)
:arrow_down:

databricks/conftest.py
90.69% <0%> (-6.98%)
:arrow_down:

databricks/koalas/frame.py
96.24% <0%> (-0.71%)
:arrow_down:

databricks/koalas/generic.py
94.7% <0%> (-0.53%)
:arrow_down:

databricks/koalas/internal.py
95.83% <0%> (-0.47%)
:arrow_down:

databricks/koalas/plot.py
93.73% <0%> (-0.25%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b2f7a0...142e527. Read the comment docs.

@HyukjinKwon Sure, i'll check and add to this PR

@HyukjinKwon Sure, i'll check and add to this PR if they exists.

@harupy, BTW, please feel free to open test only or minor typos if you happen to find. It's legitimate to fix and merge such PRs like this.


[Bug]: error when clicking accounts on setting

What happened?
A bug happened!
idk what happened
ill give a vid
this video
idk how to upload video
To reproduce the behavior?
reproduce!
setings>accounts
What browser are you seeing the problem on?
Chrome

Duplicate of #562


fix: overlapping timecode

Pre-Flight checklist

[x] Screenshots and design review for any changes that affect layout or styling

[x] Desktop screenshots
[ ] Mobile width screenshots

[x] Testing

[x] Code is tested
[x] Changes have been manually tested

What are the relevant tickets?
Closes https://github.com/mitodl/ocw-hugo-themes/issues/752
What's this PR do?

Increases height for those transcript texts which are empty so that the timecode does not overlap.
Note: I'm not sure whether this is a good solution as ideally, we should hide the transcript line when the text is empty as stated in the issue ticket but we can not access this parent element via CSS. I also tried accessing the sibling element (i.e: transcript-timestamp) and setting display: none to it but it also didn't work.
We can achieve this via JS, but I don't think a custom JS solution only for this thing will be suitable as we will have to iterate thousands of transcript elements, check which are empty, and hide them.

How should this be manually tested?

Checkout this branch
Open any transcript page which has missing transcript texts (e.g)
Verify that the timestamps are not overlapping.

Screenshots

This PR increases the height for those transcript texts which are empty so that the timecode/timestamp does not overlap.
I'm not sure whether this is a good solution as ideally, we should hide the transcript line when the text is empty as stated in the issue ticket but we can not access this parent element via CSS. I also tried accessing the sibling element (i.e: transcript-timestamp) and setting display: none to it but it also didn't work.
We can achieve this via JS, but I don't think a custom JS solution only for this small fix will be suitable as we will have to iterate over thousands of transcript elements, check which are empty, and hide them.
btw I think, the transcript text should not be empty in the first place.
@pdpinch Can you confirm whether this solution can work for us or not? (You can see the attached screenshots above)
If not, then I think we can figure out some way to hide the element completely. @gumaerc Do you have any thoughts on this?

In theory you could use something like the CSS :has selector

Yeah, this :has selector looked pretty nice but I also did proceed with it due to limited browser support.


[CDMI] Add proper pagination to listing - MaxKeys etc

Add proper pagination to S3/CDMI connector

Use a blob in the marker, use current dewpoint repositioning algorithm.

Do we need to sort the output ? @LaurenSpiegel @rahulreddy

Listing output should be sorted.  How is the listing being accomplished?

The output is naturally sorted based on the keys because of the leveldb backend (if you're mentioning S3 object listing).

@ttvi They are talking about the CDMI backend.
And yeah I am hoping that the output is naturally sorted, as sorting on the S3 side would be expensive.

I think it is sorted by name in Mesa/SOFS no ?

I don't know yet but it is simple to test.

@vrancurel @jeremyds Is this issue really relevant in S3 ? Should it not be located in cdmiclient instead ?

@DavidPineauScality the project has been created on S3, since it is an S3 data + metadata backend.

Even if it might be problematic for some applications to output entries in a way which not entirely sorted, unless it is easy to do so, I advice not to focus on this for the moment since the pagination is way more important.

@jeremyds, can this be closed?


Minor Code / Dependencies Updates

Minor code update to allow versions of node-persist >=1.0.0 to be used which altered the return syntax of GetItem. Updated other dependencies to recent versions.

Yes, though I’ll restore it for hap-nodejs to the npm package.
The ed25519 npm package won’t compile on Windows if you have the Open SSL library Version 1.1 or greater installed on Windows.
I’ve found the issue in ed25519 is a bindings library that changed. But I’ve now restored the hap-nodejs package to the npm version of ed25519 and I’ll raise the bindings library issue separately for ed25519
From: Khaos Tian<EMAIL_ADDRESS>Sent: Monday, December 25, 2017 3:59 AM
To: KhaosT/HAP-NodeJS<EMAIL_ADDRESS>Cc: jvmahon<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [KhaosT/HAP-NodeJS] Minor Code / Dependencies Updates (#537)
@KhaosT commented on this pull request.

In package.json:

@@ -10,16 +10,16 @@
"dependencies": {
"buffer-shims": "^1.0.0",
"curve25519-n2": "^1.1.2",

"debug": "^2.2.0",
"ed25519": "^0.0.4",

"debug": "^3.1.0",
"ed25519": "git://github.com/jvmahon/ed25519",

Is there a reason why pin a git repo instead of the npm package?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/KhaosT/HAP-NodeJS/pull/537#pullrequestreview-85472851 , or mute the thread https://github.com/notifications/unsubscribe-auth/AOXTtr0NHjRUTOssC7EkVfKJmviXJLPZks5tD2PvgaJpZM4RLrRE .

Sorry about that. I’ve restored it to the original 4.36 numbering.
From: Khaos Tian<EMAIL_ADDRESS>Sent: Monday, December 25, 2017 4:00 AM
To: KhaosT/HAP-NodeJS<EMAIL_ADDRESS>Cc: jvmahon<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [KhaosT/HAP-NodeJS] Minor Code / Dependencies Updates (#537)
@KhaosT commented on this pull request.

In package.json:

@@ -1,6 +1,6 @@
{
"name": "hap-nodejs",

"version": "0.4.36",

"version": "0.5.0",

Please don't bump version number. It will be coordinated in release.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/KhaosT/HAP-NodeJS/pull/537#pullrequestreview-85472904 , or mute the thread https://github.com/notifications/unsubscribe-auth/AOXTtnTlLPBISOwDy5Hqk5UCWGCsMe30ks5tD2QagaJpZM4RLrRE .

Uncertain about that.
From: Khaos Tian<EMAIL_ADDRESS>Sent: Monday, December 25, 2017 4:01 AM
To: KhaosT/HAP-NodeJS<EMAIL_ADDRESS>Cc: jvmahon<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [KhaosT/HAP-NodeJS] Minor Code / Dependencies Updates (#537)
@KhaosT commented on this pull request.

In package.json:

 "fast-srp-hap": "^1.0.1",

"ip": "^1.1.3",
"mdns": "^2.3.3",
"node-persist": "^0.0.11",
"decimal.js": "^7.2.3"

"ip": "^1.1.5",
"mdns": "^2.3.4",
"node-persist": "^2.1.0",

Does node-persist backwards compatible with data created in older version?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/KhaosT/HAP-NodeJS/pull/537#pullrequestreview-85472988 , or mute the thread https://github.com/notifications/unsubscribe-auth/AOXTtr7VQdcW97bqbrukXW4ffseAIhwWks5tD2RggaJpZM4RLrRE .


Installing without cert-manager or secret permissions

Hi there,
I want to install this chart without any cert-manager related config and therefore without providing permissions to get,list and watch secrets.
Is this possible or even in the roadmap?
Thanks in advance

Hi @teksuo,
apparently it was a bug, so i fixed it in #110 and you can use 0.17.1 right now.
Thanks for the report!


Fix Zerion API collectibles pagination on null next page

Summary
This PR fixes a bug in the NFT retrieval from Zerion API. The cases where the next page is null (end of the paginated list of items) were incorrectly handled.
Changes

Changes the implementation of ZerionBalancesApi._buildCollectiblesPage to call ZerionBalancesApi._decodeZerionPagination when next is not null only.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 93.193%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
6447

Relevant Lines:
6677

💛  - Coveralls


CodeCleanup: Rename Application Bar to Notekeeper

Closes https://github.com/sergej-stk/notekeeper/issues/101


Data lose when upstream switch and have different binlog_row_event_max_size

What did you do?
DM has a finer-grained retry that skip N events of a GTID when it has seen N events and meet error. See https://github.com/pingcap/tiflow/blob/361aa92b62f2e8e5744208f71d8ecbababb1d3c2/dm/syncer/syncer.go#L1918-L1928
But if upstream switch happens and the new/old MySQL server have different binlog_row_event_max_size, we may skip wrong events.
| mysql8.000001 | 7468 | Gtid           |         1 |        7558 | SET @@SESSION.GTID_NEXT= '09bec856-ba95-11ea-850a-58f2b4af5188:5'        |
| mysql8.000001 | 7558 | Query          |         1 |        7631 | BEGIN                                                                    |
| mysql8.000001 | 7631 | Table_map      |         1 |        7687 | table_id: 106 (rowtest.t2)                                               |
| mysql8.000001 | 7687 | Write_rows     |         1 |        7962 | table_id: 106                                                            |
| mysql8.000001 | 7962 | Write_rows     |         1 |        8237 | table_id: 106                                                            |
| mysql8.000001 | 8237 | Write_rows     |         1 |        8512 | table_id: 106                                                            |
| mysql8.000001 | 8512 | Write_rows     |         1 |        8787 | table_id: 106                                                            |
| mysql8.000001 | 8787 | Write_rows     |         1 |        8862 | table_id: 106 flags: STMT_END_F                                          |
| mysql8.000001 | 8862 | Xid            |         1 |        8893 | COMMIT /* xid=82 */                                                      |
+---------------+------+----------------+-----------+-------------+--------------------------------------------------------------------------+
129 rows in set (0.001 sec)

MySQL [rowtest]> select @@global.binlog_row_event_max_size;
+------------------------------------+
| @@global.binlog_row_event_max_size |
+------------------------------------+
|                                256 |
+------------------------------------+
1 row in set (0.000 sec)

| mysql-bin.000001 | 5621 | Gtid           |         1 |        5686 | SET @@SESSION.GTID_NEXT= '09bec856-ba95-11ea-850a-58f2b4af5188:5' |
| mysql-bin.000001 | 5686 | Query          |         1 |        5754 | BEGIN                                                             |
| mysql-bin.000001 | 5754 | Table_map      |         1 |        5804 | table_id: 109 (rowtest.t2)                                        |
| mysql-bin.000001 | 5804 | Write_rows     |         1 |        6839 | table_id: 109 flags: STMT_END_F                                   |
| mysql-bin.000001 | 6839 | Xid            |         1 |        6870 | COMMIT /* xid=102 */                                              |
+------------------+------+----------------+-----------+-------------+-------------------------------------------------------------------+

However, this finer-grained retry does not happen in our Upstream Switch CI, so even though users has satisfied the trigger condition, he may still not encounter it.
What did you expect to see?
No response
What did you see instead?
No response
Versions of the cluster
master
current status of DM cluster (execute query-status <task-name> in dmctl)
(paste current status of DM cluster here)

again, I forgot which code path handles upstream switch 😂 @GMHDBJD

/assign lichunzhu

/unassign lance6716


Fix bugs for the trainable arguments update

A recent PR changed the behavior of arguments, their trainability and the batch_params transform. We updated the arguments for one test and the @batch_params argument for another test.

[sc-14396]


Use SemaphoreSlim instead of lock object in SharedTextWriter

Did some profiling and noticed a lot of time was spent on ShareTextWriter.WriteLine and SharedTextWriter.WriteLineAsync.
Noticed the lock and figured we could use SemaphoreSlim instead.

Could do some benchmarks to see if there's any actual performance boost.

I just figure if we can avoid blocking a thread at all it would probably be better.

@mholo65 What do you think of implementing this with BlockingCollection? https://docs.microsoft.com/en-us/dotnet/api/system.collections.concurrent.blockingcollection-1?view=netcore-3.0

@rchande I'd be fine with that.
@mholo65 lsp already has this with the output handler https://github.com/OmniSharp/csharp-language-server-protocol/blob/7d8567c09c88d27b4b4a2209959f689df8e9419d/src/JsonRpc/OutputHandler.cs

Actually, blockingCollection blocks a thread, so this is probably better.

A blocking collection will only block it's own thread, not the calling task, assuming you just queue the item up.  For input / output it probably makes more sense to just have the dedicated thread, then we can queue data up for it as fast as we're allowed, but it'll write out at whatever rate it can.
As long as the order is guaranteed (which by default BlockingCollection uses ConcurrentQueue) I think dumping handling the writing in another thread might make sense.
Thoughts? @mholo65 @rchande
As it is I'm fine with this change, but it might almost make more sense to refactor it entirely.

@david-driscoll @rchande I think that BlockingCollection is even better, then we'll dump the IO to another thread, and won't block main thread.

@david-driscoll @rchande @filipw I modified this PR to use BlockingCollection instead, also no need for the Async version anymore.

thanks 👏


[api] Token Management Enhancements

Enhanced API to define a ui_token_ttl in token manager instance to reflect the UI session.timeout
Enhanced Token Manager to store a token_ttl per token
Updated API GET /api/auth to return token_ttl in token details
Added reset_token method in token manager to update expires_in/expires_on based on the token_ttl
Updated API to reset token upon valid token authentication/use
Support for requester_type paramater for GET /api/auth, supported values are "ui"
Updated/Added Specs

https://trello.com/c/MdffY1wV

This enhancement assures that API tokens' expiration times are reset upon use. So the expiration of a token is the token_ttl since the last time used instead of time created.
The default token_ttl for API is still driven by the config api.token_ttl (600), but callers can request a different requester type that would honor the UI based timeout as defined in the config session.timeout (3600)
Token metadata now includes the token_ttl as that is needed as each token may have a different timeout.
GET /api/auth

{
  "auth_token": "43e1e1d57ba27c1a5354f29cad4564b0",
  "token_ttl": 600,
  "expires_on": "2015-09-24T19:23:30Z"
}

And the UI based requests as follows:
GET /api/auth?requester_type=ui

{
  "auth_token": "eecf091fd1bc64db422a286d7bff8d21",
  "token_ttl": 3600,
  "expires_on": "2015-09-24T20:14:31Z"
}

@gtanzillo @imtayadeway please review.
@dclarizio @h-kataria as discussed, please review/kick the tire.  SSUI code could not be simplified w.r.t. API token use.

:+1: Looks good

A couple of minor comments, but otherwise :+1:


chore: lint all file

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[x] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[x] 📦 Chore (Release)
[ ] ⏩ Revert

Description
fixing lint issues based on: https://github.com/open-sauced/ai/issues/129 I have used the npm run format for auto fix and fixed the other issues manually, removed the UNIX breakline check from eslint as well.

Related Tickets & Documents

Fixes #129
Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

Can you fix all indentations as a part of this PR too?

I am on windows, and it gave around 300 errors when I used it, I can add it back if it's needed.

@diivi does this do what you are asking for:

or is there another rule I need to add?

@diivi does this do what you are asking for

This should do it, did you try messing the indentation up and formatting the files?

I am on windows, and it gave around 300 errors when I used it, I can add it back if it's needed.

Ok understood. This however is not enough reason for he change. My suggestion is doing more research, but for now I'd suggest you run the linting in a Codespaces or similar Unix container.
Does the Windows Terminal not provide a Unix environment

@bdougie Yes, windows has a unix environment, I will check it.
I will try your suggestion @diivi and comment back.

Lint done, I added the unix line back, used typescript indent, disabled eslint default one and the react one. (we can use one of this three only)
Reference for the typescript linting:
https://typescript-eslint.io/rules/indent/
For the the default indent linting of eslint: https://eslint.org/docs/latest/rules/indent#rule-details
for the js props: https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-indent-props.md
Why I used the typesrcipt one? cause I thought it's more suitable for the whole project since we have only ts files and js files and this option will check all of them.

@bdougie Thank you for the feedback, I got the UNIX idea, Thank you for this information.


[stable/kured] add support for priorityClassName

What this PR does / why we need it:
Adds support for priorityClassName, exposes the variable in values.yaml
Which issue this PR fixes

fixes #14420

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/ok-to-test
/assign
/lgtm


Mapping tiles

Facility to choose mapping tiles to match the gazetteer look up and/or mapview

For this round, the limitation will remain that the UI will only offer a single base map. (I.e. no layer switcher in the gazetteer search.) However, the base map is now configurable in the plugin admin interface.

The user can set any GoogleMaps-compatible X/Y/Z tileset, if they know the tileset URL. The plugin also comes with a set of presets to choose from, currently OpenStreetMap, Consortium of Ancient World Mappers (formerly AWMC map tiles), Digital Atlas of the Roman Empire.


[scss] support @forward configuration

Issue Type: Bug
Hi, I'm experiencing an issue with Dart Sass syntax: editor reports an error at the 'with' statement on @forward rules if the 'as' statement is used as well:
@forward "../node_modules/lr-css-modules/components/_forms.scss" as components-* with (
  $field-border-radius: 16px,
  $field-border: false
);

That is valid syntax instead, and compiles properly.

VS Code version: Code 1.65.2 (c722ca6c7eed3d7987c0d5c3df5c45f6b15e77d1, 2022-03-10T14:33:49.188Z)
OS version: Darwin x64 20.6.0
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7500 CPU @ 3.40GHz (4 x 3400)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
3, 2, 2

Memory (System)
32.00GB (1.28GB free)

Process Argv
--crash-reporter-id be98acbe-d6d8-4759-8f3a-afeac4211d43

Screen Reader
no

VM
0%

Extensions (24)

Extension
Author (truncated)
Version

laravel-extra-intellisense
ami
0.6.2

vscode-eslint
dba
2.2.2

vscode-html-css
ecm
1.11.0

vscode-great-icons
emm
2.1.84

vsc-material-theme-icons
equ
1.2.2

php-intellisense
fel
2.3.14

vscode-firefox-debug
fir
2.9.6

text-transform
flo
0.1.0

html-slim-scss-css-class-completion
gen
1.7.8

material-color
guo
1.3.2

smarty
imp
0.3.0

volar
joh
0.33.2

vscode-docker
ms-
1.20.0

remote-containers
ms-
0.224.2

laravel-blade
one
1.32.0

material-icon-theme
PKi
4.14.1

text-power-tools
qcz
1.30.0

subtle-brackets
raf
3.0.0

inputer
syp
0.0.9

vscode-icons
vsc
11.10.0

file-icons-mac
way
1.0.1

php-debug
xde
1.25.0

php-pack
xde
1.0.3

php-intellisense
zob
1.0.5

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
pythonvspyl392:30443607
pythontb:30283811
pythonvspyt551cf:30345471
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
vsclayoutctrt:30451275
dsvsc009:30452663
pythonvspyt640:30450904
vscscmwlcmc:30438804
vscgsvidc:30447482
pynewfile477:30450038

Spec is here: https://sass-lang.com/documentation/at-rules/forward#configuring-modules

Hi, I'm new to open source and would like to work on this issue!

The parser code is here: https://github.com/microsoft/vscode-css-languageservice/blob/11ed0f7f417fd5139a2e1743c48930cbe0759f60/src/parser/scssParser.ts#L852
You would create a PR in that repo
See here how you can develop and test this.

I'm having a hard time setting up the development environment. Whenever I run yarn link vscode-css-languageservice as detailed in https://github.com/microsoft/vscode-css-languageservice/blob/main/README.md#development, I get an error that there is no registered package. I made to run npm install --save vscode-css-languageservice first.

You need to run yarn link in the folder of vscode-css-languageservice. I updated the readme.

When I get to the Debug: Attach to Node Process part, I am not seeing any code-oss process with the css-language-features path. I completed all steps before this one and have VSCode running out of sources, but I am unable to develop and test because of this.

Did you open a scss file?


⚠ Bofrost.be has degraded performance

In 1618a7f, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2422 ms

Resolved: Bofrost.be performance has improved in 2fc8c3f.


4.1 upgrade + Little fix

This branch includes:

The automatic Godot 4.1 adjustments Godot makes.
a fix to the following error: An error kept appearing that stated an invalid substraction in type_context_settings between a "Vector2i" and "Vector2" was occuring. Upon looking, the last of the 3 times the readjust_size() function is called on, get_parent().size is of type Vector2i.

This doesn't solve the crashing or the errors in setting type_context_settings's editor_plugin but that will have to be looked into.
Let me know thoughts!

Looks clean. I would take issue in auto-updating or formatting files in a PR, but I would need to do that anyway, so thanks.
I didn't get that error when working, but I see this could trouble some folks. The goal is no errors at all. Thank you for the Fix!
This made me notice there's an ImageTexture stuck in that scene file, I'll remove it now.


increase supplier frontend instances and memory

scaling up in anticipation of increased traffic

Can we bump the api as well (to 20)?


Optimize jlab images

Docker dive output on the jupyter-lab3 vanilla images.
Total Image size: 6.4 GB   Potential wasted space: 3.2 GB  Image efficiency score: 72 %

New updates commit reduce the image size.
Total Image size: 5.0 GB  Potential wasted space: 2.7 GB  Image efficiency score: 65 %


5.0.0-beta.23.1101 - slack messages jump back in time when switching services

Bug Description
I have 10 slack services integrated with desktop Franz. After updating to 5.0.0-beta.23.1101, I switched from an extracurricular Slack to my work Slack, and after loading the most recent messages very briefly, the messages in the open channel jumped back about a week.
When switching back to the other slack service, it also jumps back in time; switching back yet again moves the work slack messages up another several weeks.
To Reproduce
Steps to reproduce the behavior:

Go to a Slack service in Franz.
Switch to another slack service in Franz.

Screenshots
Where I started:

After switching:

An instant later:

Switching back:
Links to screen capture
Desktop (please complete the following information):

OS: OS Mojave 10.4.2
Version: 5.0.0-beta.23.1101

Same here

Yep, same here

same here!

Same, and in my case, the channel menu also disappears apart from the workspace name and my name.

Can confirm, fixed for me 👍

Also confirmed! Thanks so much for the quick response and fix, @adlk--vielen Dank!

Confirmed fixed in b24

Phew, that manual scrolling was brutal! Nice fix.


Enhance support for reading HTTP results with errors

When handling errors from HttpClient try to convert to a more meaningful .NET exception rather than simply using HttpResponseException (e.g. like WCF). For example if a 400 occurs but the error response object indicates an argument exception then throw an argument exception instead of the standard exception. This will make it easier for apps to handle errors intelligently rather than always working with the HTTP response.

b2413f3cdfe4cf059b187d9a703e80556d0cff9e


Add a JSON file to S3 build directories to control what triggers an update notification

Currently, if Etcher detects that all builds are present in S3, it will show a notification to the user. We want to have a json file in each of the S3 sub directories for fine grained control. For example:

Only show update notification dialogs for the Linux builds of this version
Don't show update notifications at all for this version

etc

Ping @jhermsmeier as I guess this ties into the "gradual releases" thing that got discussed a while ago.


does it work?

Test the mod with another player in-game

no.
Mumble provides some PA settings.
The defaults are (volume changes from 1m to 15m, to a minimum of 25% volume)

After changing them to this (volume changes from 0m to 14.2m, to a minimum of 0% volume)

I observe:
With only player position and camera position changing

When PA (Positional Audio) is enabled, other speakers volumes reduce to what feels like 25% *
There is no change of volume when players walk around (up to 100s of m away)

Changing all variables

[The same as above.]

Conclusion
It feels like:

PA is enabled, because of the volume drop on enabling/disabling it.
The "Minimum Volume" setting above has no effect, and that the Postional Audio has no effect.

This could be an issue with

Postional Audio in Mumble v1.5
The direction/axis should be set to something

These may be required to be unit vectors(?)

Next steps:

try with direction/axis vectors set
try with Mumble 1.4
if those do not work, further action is unknown

It works!
Mumble 1.4
With these settings

it works! 1 chest in game (1 square) is 1 metre in Mumble.
Mumble 1.5
Doesn't seem to fully work, for example:

when using the above settings, I could hear another player at any distance away. They stopped hearing me as usual. Increasing/decreasing minimum volume had the intended effect, but it never went fully to 0%.

mumble-voip/mumble#6149

It works in Mumble 1.4
It does not work in Mumble 1.5 (until https://github.com/mumble-voip/mumble/issues/6149 is fixed)

The positional audio fixes have been merged into master an will most likely land in the next 1.5 RC

The positional audio fixes have been merged into master an will most likely land in the next 1.5 RC

beautiful :)


"Processing typed transaction, but parameter_json is None" error raised during indexing (7.0.0rc4)

Steps to reproduce:
We had a similar issue before here: https://github.com/dipdup-io/dipdup/issues/769
The Steps to reproduce: are similar between the two errors.
However this time I got the error with an entrypoint that has an option as a parameter (in this case, the parameter is either a String or None/null).
I was able to fix the issue locally by replacing this in src/dipdup/indexes/tezos_tzkt_operations/matcher.py line 57:
if operation_data.parameter_json is None:
    raise FrameworkException('Processing typed transaction, but parameter_json is None')

into this:
if not hasattr(operation_data, 'parameter_json'):
    raise FrameworkException('Processing typed transaction, but parameter_json is None')

Environment

Python version: 3.11.4
DipDup version or commit hash: 7.0.0rc4
Database engine version: TimescaleDB 15
Hasura version: 2.30.1
Are you in docker? No
Can you reproduce this issue on next? Yes

I wasn't able to reproduce this error, I have indexed the call of operation mint in plenty. Do you have any examples?
The type of operation_data should have an attribute parameter_json, so your fix has worked in some not straightway.

I had my issue when I tried to index the %councilActionSetBaker entrypoint of this contract KT1KZHRFrvAYD3WPXTJVGbS36BShjcoivTTe on the Ghostnet.
This parameter type is an option that can either be equal to a key_hash or None.
When I index it while setting None, I think I'm getting None too in the parameter_json.


bootstrap with pure python wheels

This relates to the last PR but it improves how we gather wheels for the bootstrap

Coverage remained the same at 82.739% when pulling ee9678ac7bec4be275124901880917c78617dd79 on matt/create_offline_install into d1fcc90d5feeaa09661c3f9e4c20ef0779f6cfaa on master.

Coverage remained the same at 82.739% when pulling ee9678ac7bec4be275124901880917c78617dd79 on matt/create_offline_install into d1fcc90d5feeaa09661c3f9e4c20ef0779f6cfaa on master.


Add event for when Eureka registry is updated

Adds support for #761

/azp run

Given the location of the change it's not immediately clear to me how somebody would take advantage of this change, can you provide an example of what you expect that'd look like?

Something like this
public void Configure(IApplicationBuilder app, IWebHostEnvironment env, IDiscoveryClient client)
        {
            var eureka = (DiscoveryClient) client;
            eureka.OnApplicationsChange += (sender, applications) =>
            {
                Console.WriteLine("====");
                foreach (var application in applications.GetRegisteredApplications())
                {
                    Console.WriteLine($"App: {application.Name}");
                    foreach (var instance in application.Instances)
                    {
                        Console.WriteLine($"  {instance.Actiontype} {instance.HostName}:{instance.Port}");
                    }
                }
            };

This implementation should be OK for now, but we'll probably want to revisit with this issue to align with Spring and things like ApplicationEvent
Do you have time to add a unit test for this?


Checking in test_k8_ingress.py, updated common_fixtures and all relat…

…ed resource files
@sangeethah : Please take a look when u get a chance.

LGTM


Add support for the ESP32-C2

Sorry for the noise, closed in favour of the WiFi/Bluetooth/Coex tracking issues.


Add support for visual variations of tool parts

Adding support for creating tool part using different skins to customise your tools. I haven't decided if skins should enhance the tools properties, but a system like that would be very cool. In the first place I probably don't need to implement stat changes.
Upgrades/skins should be applied with a pattern/schematic found in the world, creating tool parts with this schematic will create a tool part with different visuals. I will probably use the exact same technique for creating textures as with the default system.

Being developed as a part of Pattern #79


Question: How to use semantic graph & add edges

TLDR: How do we use both similarity search and define edges with the semantic graph?
In the example on how to build a graph it shows how to use GraphFactory to create a graph, then graph.addnode to create a node and graph.addedge to create the edges.
However lower down in the notebook it shows how to use embeddings and emeddings.index to load data into nodes.
Is there a way to use both of these together? I have a dataset of nodes with UID for each node and edges that link the nodes together. I'd like to use those to define the known relationships and then use similarity on the nodes to identify relationships that are inferred based on similarity.
So for example I have a node that contains an articles of text, that node has entities which I know are mentioned in the text. They also have nodes that have categories like "Logistics". So I would want to query nodes similar to "logistics" and get "shipping", "trucking" then walk the graph to get the entities (via the linked articles)
Is this possible?

Thank you for the quick response!
I tried that before I posted this and it wasn't working properly.. However I think I figured out what's going on..
When I use emeddings.index((uid, text)) it doesn't appear to use the uid as the node id in the graph it uses the index position (the order of insertion) for the node id. Since I gave each node a random UID when I generated the data, the edges aren't going to line up with the new node ids once I insert.
when i use embeddings.graph.addnode(uid, text=content) to add a node, it does the proper UID as the node id but that  doesn't  index seem to create a vectorized version of the text so embeddings.search('my phrase') doesn't match those nodes.
I do like the idea of being able to say some nodes need to have a 1:1 text match and others can use similarity search, that's very useful. I'm just a bit confused on how to best accomplish that.
The other thing that is confusing.. When using the embedding approach, I have to use embeddings.index() to add at least 1 node before it will let me insert nodes using addnode().
I tried to initialize the graph but I'm clearly not doing that correctly since I get errors, saying "'NoneType' object has no attribute 'initialize'"
graph = embeddings.creategraph()
graph.initialize()

Good point. Probably need a top level method to add graph nodes. That method would resolve the uid->internal id mapping.
I'll think about a clean implementation and follow up. I do think it's good functionality to add.
In the meantime, if you want to get something working locally, you can look at the embeddings.delete method. If you use that same logic for uid lookups, you'll then be able to use internal id to add graph edges.

I looked through the embeddings.delete method but I didn't see anything obvious. I ended up adding in some logic for tracking what the uid to index position as a lookup table. Then used the lookup table to remap all the edges. Not something I'd want to do every time but good enough for a prototype.
Appreciate the help. Hope you don't mind if I ask more questions about how to continue to iterating on my graph.

I looked through the embeddings.delete method but I didn't see anything obvious. I ended up adding in some logic for tracking what the uid to index position as a lookup table. Then used the lookup table to remap all the edges. Not something I'd want to do every time but good enough for a prototype.
Thank you for the help & this amazing project! I've been trying for over a month (failing many times) to find a database that I can build this type of graph.
Hope you don't mind if I ask more questions about how to continue to iterating on my graph.

Glad you were able to get something working.
I've added #525 to create a clean way to do this through the framework. Please take a look and see if that spec would make it easier for you to accomplish what you're trying to do.


parallel compilation (-jN) seems to produce broken code randomly

I have noticed that randomly our test application breaks in CI testing and have been investigating the reason for it. I noticed that the binary size of the final binary varies between builds and some builds work fine, others fail on error below:
RTX error code: 0x00000001, task ID: 0x20015210
[0255][DBG ][mClt]: M2MInterfaceImpl::~M2MInterfaceImpl() - IN
[0256][DBG ][mClt]: M2MNsdlInterface::~M2MNsdlInterface() - IN
[0257][DBG ][mClt]: M2MNsdlInterface::~M2MNsdlInterface() - OUT
[0258][DBG ][mClt]: M2MConnectionHandlerPimpl::stop_listening()
[0259][DBG ][mClt]: M2MConnectionHandlerPimpl::~M2MConnectionHandlerPimpl()
sys_mbox_post error

We then through that this might be related to the -j flag. Compiling code with -j1 produces reliably nearly similar binary sizes, but using anything else makes it quite random.
For ex. building with -j32
+-----------------------------+--------+-------+-------+
| Module                      |  .text | .data |  .bss |
+-----------------------------+--------+-------+-------+
| Fill                        |    541 |    14 |  2237 |
| Misc                        |  88062 | 11229 |  8195 |
| features/FEATURE_CLIENT     |  70573 |     3 |    57 |
| features/FEATURE_COMMON_PAL |  25298 |    89 | 10452 |
| features/frameworks         |   3823 |    52 |   784 |
| features/mbedtls            | 127373 |    51 |   119 |
| features/net                |  34692 |   102 | 51261 |
| hal/common                  |   2977 |    20 |   297 |
| hal/targets                 |  15237 |    12 |   200 |
| rtos/rtos                   |    205 |     4 |     0 |
| rtos/rtx                    |   7385 |    20 |  2686 |
| Subtotals                   | 376166 | 11596 | 76288 |
+-----------------------------+--------+-------+-------+
Allocated Heap: 65536 bytes
Allocated Stack: 32768 bytes
Total Static RAM memory (data + bss): 87884 bytes
Total RAM memory (data + bss + heap + stack): 186188 bytes
Total Flash memory (text + data + misc): 388802 bytes
Image: ./.build/K64F/GCC_ARM/mbed-client-testapp.bin

with -j12
+-----------------------------+--------+-------+-------+
| Module                      |  .text | .data |  .bss |
+-----------------------------+--------+-------+-------+
| Fill                        |    493 |    14 |  2241 |
| Misc                        |  88067 | 11229 |  8195 |
| features/FEATURE_CLIENT     |  70506 |     3 |    57 |
| features/FEATURE_COMMON_PAL |  25298 |    89 | 10452 |
| features/frameworks         |   3823 |    52 |   784 |
| features/mbedtls            | 127204 |    51 |   119 |
| features/net                |  34692 |   102 | 51261 |
| hal/common                  |   2977 |    20 |   297 |
| hal/targets                 |  15237 |    12 |   200 |
| rtos/rtos                   |    205 |     4 |     0 |
| rtos/rtx                    |   7385 |    20 |  2686 |
| Subtotals                   | 375887 | 11596 | 76292 |
+-----------------------------+--------+-------+-------+
Allocated Heap: 65540 bytes
Allocated Stack: 32768 bytes
Total Static RAM memory (data + bss): 87888 bytes
Total RAM memory (data + bss + heap + stack): 186196 bytes
Total Flash memory (text + data + misc): 388523 bytes
Image: ./.build/K64F/GCC_ARM/testapp2.bin

while with -j0
+-----------------------------+--------+-------+-------+
| Module                      |  .text | .data |  .bss |
+-----------------------------+--------+-------+-------+
| Fill                        |    469 |    14 |  2241 |
| Misc                        |  88067 | 11229 |  8195 |
| features/FEATURE_CLIENT     |  70506 |     3 |    57 |
| features/FEATURE_COMMON_PAL |  25298 |    89 | 10452 |
| features/frameworks         |   3823 |    52 |   784 |
| features/mbedtls            | 127204 |    51 |   119 |
| features/net                |  34684 |   102 | 51261 |
| hal/common                  |   2977 |    20 |   297 |
| hal/targets                 |  15237 |    12 |   200 |
| rtos/rtos                   |    205 |     4 |     0 |
| rtos/rtx                    |   7385 |    20 |  2686 |
| Subtotals                   | 375855 | 11596 | 76292 |
+-----------------------------+--------+-------+-------+
Allocated Heap: 65540 bytes
Allocated Stack: 32768 bytes
Total Static RAM memory (data + bss): 87888 bytes
Total RAM memory (data + bss + heap + stack): 186196 bytes
Total Flash memory (text + data + misc): 388491 bytes
Image: ./.build/K64F/GCC_ARM/testapp.bin

There is a few hundred byte difference in the produced binary size with completely identical builds otherwise (expect maybe time-stamp).
Could there by some issue that the build order of the files result in broken linking with bad luck?
mbed-cli 0.9.1
arm-none-eabi-gcc (15:4.9.3+svn231177-1) 4.9.3 20150529 (prerelease)

mbed-client-testapp (784f1742d26e)
|- mbed-client-cli (d4844ef43abd)
|- mbed-os (0712b8adf6bb)
|  |- features/FEATURE_CLIENT/mbed-client (47a2eea08c0c)
|  |- features/FEATURE_CLIENT/mbed-client-classic (3f8574348306)
|  |- features/FEATURE_CLIENT/mbed-client-mbed-tls (68f93f7834e9)
|  `- features/FEATURE_COMMON_PAL/mbed-client-c (758fd1e11cb9)

Could there by some issue that the build order of the files result in broken linking with bad luck?

Looking at the toolchain implementation here (https://github.com/ARMmbed/mbed-os/blob/master/tools/toolchains/init.py) It seems that the only thing that might change between runs is the order of the object files returned from compile_sources. The order of the object files are compiled in matches the order that they are passed to the linker. If this is changing on you, you should be able to observe it by passing -v to the tools to get the linker invocation.

Also, something to note is that the Fill is the only thing changing between your builds.

There is differences in other components also
| features/FEATURE_CLIENT     |  70573 |     3 |    57 |
| features/FEATURE_CLIENT     |  70506 |     3 |    57 |
| features/net                |  34692 |   102 | 51261 |
| features/net                |  34684 |   102 | 51261 |
| features/mbedtls            | 127373 |    51 |   119 |
| features/mbedtls            | 127204 |    51 |   119 |
Small changes, I do not know if that is significant but seems quite suspicious.
Also as a possible other issue, the error sys_mbox_post error can be found from two identical functions in two different places in mbed-os.
https://github.com/ARMmbed/mbed-os/blob/860fdd282b0dc3631a6c46b39442d4ab5343e534/libraries/net/lwip/lwip-sys/arch/sys_arch.c#L119
https://github.com/ARMmbed/mbed-os/blob/db99e726e006ca3260769d6cd444f51eefec1708/features/net/FEATURE_IPV4/lwip-interface/lwip-sys/arch/lwip_sys_arch.c#L119

these issues might be related to this one:
https://github.com/ARMmbed/mbed-os-example-client/issues/37
https://github.com/ARMmbed/mbed-os/issues/2411#issuecomment-238853473

I heard that only way to avoid this issue is to define -j1 to use single core instead of default one -j0

I don't think I've ever had a problem using -j0 (which is the default), but I've also never had that many cores to play with :)

When in doubt, we can always sort the linker's object/library list alphabetically. Quite random, but also consistent.

I actually suggested sorting the objects a month ago. You always want the libraries after the object files though. Getting a link on that one.

@bridadan I don't have issues with this, and I have all of the cores to play with.

I think we can finally close this.


DASH live stream with subtitle track doesn't show subtitles

Have you read the FAQ and checked for duplicate open issues?
Yes
If the problem is related to FairPlay, have you read the tutorial?

Not related to FairPlay
What version of Shaka Player are you using?

4.9.9
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from main?
Not sure how to test this
Are you using the demo app or your own custom app?
Custom app
If custom app, can you reproduce the issue using our demo app?
No because of CORS
What browser and OS are you using?
Electron, macOS
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A
What are the manifest and license server URIs?

Dynamic manifest, with geo-restrictions, and widevine with auth (from F1 TV), only available during live sessions, otherwise service uses DASH.
repro-case.zip (wasn't able to grab the original manifest, but got the parsed manifest for this one, then fetched a new manifest for the same media, so hopefully this is correct)
What configuration are you using?  What is the output of player.getConfiguration()?

Show JSON
{
    "drm": {
        "retryParameters": {
            "maxAttempts": 2,
            "baseDelay": 1000,
            "backoffFactor": 2,
            "fuzzFactor": 0.5,
            "timeout": 30000,
            "stallTimeout": 5000,
            "connectionTimeout": 10000
        },
        "servers": {},
        "clearKeys": {},
        "advanced": {},
        "delayLicenseRequestUntilPlayed": false,
        "persistentSessionOnlinePlayback": false,
        "persistentSessionsMetadata": [],
        "logLicenseExchange": false,
        "updateExpirationTime": 1,
        "preferredKeySystems": [],
        "keySystemsMapping": {},
        "parseInbandPsshEnabled": false,
        "minHdcpVersion": "",
        "ignoreDuplicateInitData": true
    },
    "manifest": {
        "retryParameters": {
            "maxAttempts": 2,
            "baseDelay": 100,
            "backoffFactor": 2,
            "fuzzFactor": 0.5,
            "timeout": 30000,
            "stallTimeout": 5000,
            "connectionTimeout": 10000
        },
        "availabilityWindowOverride": null,
        "disableAudio": false,
        "disableVideo": false,
        "disableText": false,
        "disableThumbnails": false,
        "defaultPresentationDelay": 0,
        "segmentRelativeVttTiming": false,
        "raiseFatalErrorOnManifestUpdateRequestFailure": false,
        "dash": {
            "clockSyncUri": "https://api.multiviewer.app/api/v1/time",
            "ignoreDrmInfo": false,
            "disableXlinkProcessing": false,
            "xlinkFailGracefully": false,
            "ignoreMinBufferTime": true,
            "autoCorrectDrift": false,
            "initialSegmentLimit": 1000,
            "ignoreSuggestedPresentationDelay": true,
            "ignoreEmptyAdaptationSet": false,
            "ignoreMaxSegmentDuration": false,
            "keySystemsByURI": {
                "urn:uuid:1077efec-c0b2-4d02-ace3-3c1e52e2fb4b": "org.w3.clearkey",
                "urn:uuid:e2719d58-a985-b3c9-781a-b030af78d30e": "org.w3.clearkey",
                "urn:uuid:edef8ba9-79d6-4ace-a3c8-27dcd51d21ed": "com.widevine.alpha",
                "urn:uuid:9a04f079-9840-4286-ab92-e65be0885f95": "com.microsoft.playready",
                "urn:uuid:79f0049a-4098-8642-ab92-e65be0885f95": "com.microsoft.playready"
            },
            "sequenceMode": false,
            "enableAudioGroups": false,
            "multiTypeVariantsAllowed": true,
            "useStreamOnceInPeriodFlattening": false,
            "updatePeriod": -1,
            "enableFastSwitching": true
        },
        "hls": {
            "ignoreTextStreamFailures": false,
            "ignoreImageStreamFailures": false,
            "defaultAudioCodec": "mp4a.40.2",
            "defaultVideoCodec": "avc1.42E01E",
            "ignoreManifestProgramDateTime": false,
            "ignoreManifestProgramDateTimeForTypes": [],
            "mediaPlaylistFullMimeType": "video/mp2t; codecs=\"avc1.42E01E, mp4a.40.2\"",
            "useSafariBehaviorForLive": true,
            "liveSegmentsDelay": 1,
            "sequenceMode": true,
            "ignoreManifestTimestampsInSegmentsMode": false,
            "disableCodecGuessing": false,
            "disableClosedCaptionsDetection": false,
            "allowLowLatencyByteRangeOptimization": true
        },
        "mss": {
            "sequenceMode": false,
            "keySystemsBySystemId": {
                "9a04f079-9840-4286-ab92-e65be0885f95": "com.microsoft.playready",
                "79f0049a-4098-8642-ab92-e65be0885f95": "com.microsoft.playready"
            }
        }
    },
    "streaming": {
        "retryParameters": {
            "maxAttempts": 10,
            "baseDelay": 200,
            "backoffFactor": 2,
            "fuzzFactor": 0.5,
            "timeout": 10000,
            "stallTimeout": 5000,
            "connectionTimeout": 10000
        },
        "rebufferingGoal": 0.1,
        "bufferingGoal": 60,
        "bufferBehind": 60,
        "evictionGoal": 1,
        "ignoreTextStreamFailures": true,
        "alwaysStreamText": false,
        "startAtSegmentBoundary": true,
        "gapDetectionThreshold": 0.1,
        "gapJumpTimerTime": 0.25,
        "durationBackoff": 0,
        "safeSeekOffset": 5,
        "stallEnabled": true,
        "stallThreshold": 1,
        "stallSkip": 0.1,
        "useNativeHlsOnSafari": true,
        "useNativeHlsForFairPlay": true,
        "inaccurateManifestTolerance": 0,
        "lowLatencyMode": true,
        "autoLowLatencyMode": false,
        "forceHTTP": false,
        "forceHTTPS": false,
        "preferNativeHls": false,
        "updateIntervalSeconds": 0.1,
        "dispatchAllEmsgBoxes": false,
        "observeQualityChanges": false,
        "maxDisabledTime": 1,
        "parsePrftBox": false,
        "segmentPrefetchLimit": 5,
        "prefetchAudioLanguages": [],
        "disableAudioPrefetch": false,
        "disableTextPrefetch": false,
        "disableVideoPrefetch": false,
        "liveSync": false,
        "liveSyncTargetLatencyTolerance": 0.5,
        "liveSyncMaxLatency": 1,
        "liveSyncPlaybackRate": 1.1,
        "liveSyncMinLatency": 0,
        "liveSyncMinPlaybackRate": 0.95,
        "liveSyncPanicMode": false,
        "liveSyncPanicThreshold": 60,
        "allowMediaSourceRecoveries": true,
        "minTimeBetweenRecoveries": 5,
        "vodDynamicPlaybackRate": false,
        "vodDynamicPlaybackRateLowBufferRate": 0.95,
        "vodDynamicPlaybackRateBufferRatio": 0.5,
        "infiniteLiveStreamDuration": false,
        "preloadNextUrlWindow": 30,
        "loadTimeout": 30,
        "clearDecodingCache": false
    },
    "mediaSource": {
        "codecSwitchingStrategy": "smooth",
        "forceTransmux": false,
        "insertFakeEncryptionInInit": true
    },
    "offline": {
        "usePersistentLicense": true,
        "numberOfParallelDownloads": 5
    },
    "abr": {
        "enabled": true,
        "useNetworkInformation": true,
        "defaultBandwidthEstimate": 10000000,
        "switchInterval": 8,
        "bandwidthUpgradeTarget": 0.85,
        "bandwidthDowngradeTarget": 0.95,
        "restrictions": {
            "minWidth": 0,
            "maxWidth": null,
            "minHeight": 0,
            "maxHeight": null,
            "minPixels": 0,
            "maxPixels": null,
            "minFrameRate": 0,
            "maxFrameRate": null,
            "minBandwidth": 0,
            "maxBandwidth": null,
            "minChannelsCount": 0,
            "maxChannelsCount": null
        },
        "advanced": {
            "minTotalBytes": 128000,
            "minBytes": 16000,
            "fastHalfLife": 2,
            "slowHalfLife": 5
        },
        "restrictToElementSize": false,
        "restrictToScreenSize": false,
        "ignoreDevicePixelRatio": false,
        "clearBufferSwitch": false,
        "safeMarginSwitch": 0,
        "cacheLoadThreshold": 20
    },
    "autoShowText": 3,
    "preferredAudioLanguage": "",
    "preferredAudioLabel": "",
    "preferredTextLanguage": "",
    "preferredVariantRole": "",
    "preferredTextRole": "",
    "preferredAudioChannelCount": 2,
    "preferredVideoHdrLevel": "AUTO",
    "preferredVideoLayout": "",
    "preferredVideoLabel": "",
    "preferredVideoCodecs": [],
    "preferredAudioCodecs": [],
    "preferForcedSubs": false,
    "preferSpatialAudio": false,
    "preferredDecodingAttributes": [],
    "restrictions": {
        "minWidth": 0,
        "maxWidth": null,
        "minHeight": 0,
        "maxHeight": null,
        "minPixels": 0,
        "maxPixels": null,
        "minFrameRate": 0,
        "maxFrameRate": null,
        "minBandwidth": 0,
        "maxBandwidth": null,
        "minChannelsCount": 0,
        "maxChannelsCount": null
    },
    "playRangeStart": 0,
    "playRangeEnd": null,
    "textDisplayer": {
        "captionsUpdatePeriod": 0.25
    },
    "cmcd": {
        "enabled": false,
        "sessionId": "",
        "contentId": "",
        "rtpSafetyFactor": 5,
        "useHeaders": false,
        "includeKeys": []
    },
    "cmsd": {
        "enabled": true,
        "applyMaximumSuggestedBitrate": true,
        "estimatedThroughputWeightRatio": 0.5
    },
    "lcevc": {
        "enabled": false,
        "dynamicPerformanceScaling": true,
        "logLevel": 0,
        "drawLogo": false
    },
    "ads": {
        "customPlayheadTracker": false,
        "skipPlayDetection": false,
        "supportsMultipleMediaElements": true
    }
}

What did you do?

Play manifest
Enable subtitles

What did you expect to happen?
Subtitles show up (they do in other players, namely Bitmovin)
What actually happened?

No subtitles show up. They are being fetched, parsed, and added but it almost seems like either the timestamp is parsed wrong, or they are not showing outside of the bounds of the segment?
If I disable this code:
https://github.com/shaka-project/shaka-player/blob/88d2a0227bc23ae2e02d45fd3fc27cd3d3e3f66d/lib/text/ttml_text_parser.js#L334-L338
They do show up, just duplicated.
Are you planning send a PR to fix it?
I'm not sure I have the experience with Shaka that requires this.

Since this impacts another issues, I think @theodab  can help here, I also think it may be related to https://github.com/shaka-project/shaka-player/issues/6773

We have supplied additional test instructions and a manifest to<EMAIL_ADDRESS>

@joeyparrish moving from email. The details were sent to<EMAIL_ADDRESS>

@theodab Did you have a chance to take a look at the details we emailed?

If more information is required, please let us know. We'd be more than happy to provide additional data wherever we can. Thank you.

@avelad @theodab hey guys, any insight here?

@joeyparrish bringing this back up :)

Sorry, we haven't had time to work on this.

No subtitles show up. They are being fetched, parsed, and added but it almost seems like either the timestamp is parsed wrong, or they are not showing outside of the bounds of the segment?

I recommend you check the following:

If you're using the UI, get the Player with player = video.ui.getControls().getLocalPlayer() and then check (uncompiled): player.mediaSourceEngine_.textDisplayer_.cues_ (in compiled or debug builds, you will need to find the minified names).  That will let you see easily what cues have been parsed and sent for display.
If you're not using the UI, try video.textTracks[0].cues for the same.

This will help you determine if the timestamps are the root of the problem.  We can try to guide you further from there.


Feature: Add Course Wide Search, Filtering and Sorting for Messages

Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server.
[x] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Client

[x] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
[x] I strictly followed the client coding and design guidelines.
[x] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[x] I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
[x] I documented the TypeScript code using JSDoc style.
[x] I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

We currently have two communication modules: one named 'Communications,' which functions as a legacy system, and another named 'Messages.' We aim to consolidate them under the 'Messages' module and phase out the legacy 'Communications' module. To achieve this, implementing the missing course-wide search feature in the 'Messages' module is the first step.
Steps for Testing

Prerequisites:

1 Student
1 Course with Communications enabled

Log in to Artemis
Navigate to Messages of a Course
Post messages to different channels
Search messages using the search bar over the sidebar
Make sure search functions correctly and everything else works as expected

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Performance Review

[ ] I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
[ ] I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

[x] Code Review 1
[x] Code Review 2

Manual Tests

[x] Test 1
[x] Test 2

Test Coverage

Screenshots

Summary by CodeRabbit

New Features

Added a search bar in the course conversations section to enhance user interaction with conversation threads.
Introduced a new course-wide search component to facilitate searching and interaction within course conversations.

Enhancements

Updated conversation headers to display relevant information based on the user's current page.
Improved layout and visibility of conversation elements across different pages.

Bug Fixes

Adjusted display logic in conversation messages to correctly reflect the active conversation context.

Documentation

Enhanced in-app documentation accessibility through new documentation buttons.

Style

Implemented new styles for the course-wide search functionality to improve user experience.

Refreshing the page after searching show all messages and displays "Search results for ' ' "

I am not quite sure if it is a good idea to implement this with a client side search. I could imagine that a course accumulates quite some messages over the semester. I am thinking of courses like Introduction to Software Engineering with more than 2000 students. At the end of the semester this could become super slow!
Do we have numbers from previous courses that actively used the Messaging feature on how many messages will be accumulated (and would need to be filtered and sorted client side)?

The search logic was already implemented in the legacy communications module, so there are existing queries that do this. I just reused the methods on the client side. In the ConversationMessageRepository class on the server side, the query is created.

We should hide the search bar in the code of conduct page.

We should hide the search bar in the code of conduct page.

fixed


Dust fixes

There are a number of tests that are currently failing (in standard mode), not for the intended reason, but because the output amounts are too low.
This PR simply increases the appropriate amounts for those tests.
These adjusted tests now behave as expected on BCHN.

Thanks for finding these @Andrew-128!!


Custom notification sound on background (Android)

I cant't get to customize the notification sound (in background, because in foreground I can do anythinga want). I tried to send "soundname" parameter with value "beep.wav" (The file I play in foregrpund and that is in my www folder) but doesn't work. Please help

He I solved this problem from here. I spent a week to find out solution at last got this and worked :)
https://github.com/phonegap-build/PushPlugin/pull/421


[Bug]: Hot reload not working when referencing ReactiveUI.WinUI when targeting net7.0

Describe the bug 🐞
I was recently incorrectly referencing ReactiveUI in a WinUI project. After changing to ReactiveUI.WinUI edit & continue and hot reload stopped working. I get the following error message:

CS7038: Failed to emit module MyApp. Changing the version of an assembly reference is not allowed during debugging: 'System.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' changed version to '<IP_ADDRESS>'.

If I remove the package or switch back to ReactiveUI the problem goes away.
Step to reproduce

Create a WinUI project using the lastest WindowsAppSDK and target net7.0-windows10.0.19041.0
Add the Reactive.WinUI nuget package to the project
Debug the project
Edit some code to trigger an "Edit & Continue" or HotReload
Check the output from hot reload in the output window

Reproduction repository
https://github.com/reactiveui/ReactiveUI
Expected behavior
This should happen...
Screenshots 🖼
No response
IDE
Visual Studio 2022
Operating system
Windows
Version
No response
Device
No response
ReactiveUI Version
20.1.1
Additional information ℹ
No response

I can confirm that this is an issue with 20.1.1. I downgraded to 20.0.1 then triggered a hot reload without any problem. Upgraded back to 20.1.1 and triggered a hot reload same issue forcing me to close the application.

Thank you for raising this issue, I will try to locate the root cause and release an update if necessary

Is it the fact it's net7? Net 7 went out of support in may 2024 so reactiveui does not support it


config isn't applied when doing a "release" run in ios

I followed the basic installation instruction. I now wanted to run the app under "release" config instead of "debug".
Now the env variables are not available anymore.
Any idea what's wrong?

sorry, my .env file got deleted right before i did the build... -.-
its working perfectly, thx!


Fix compiler feature warnings

Towards https://github.com/informalsystems/apalache/issues/1064. Closes #1473.
Fixes all current compiler feature warnings.
Rationale for each fix in the commit message.

Codecov Report

Merging #1482 (20202e6) into unstable (42aacb1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           unstable    #1482      +/-   ##
============================================
+ Coverage     74.88%   74.90%   +0.02%
============================================
  Files           358      358
  Lines         11477    11475       -2
  Branches        541      530      -11
============================================
+ Hits           8594     8595       +1
+ Misses         2883     2880       -3

Impacted Files
Coverage Δ

...rsyte/apalache/tla/bmcmt/smt/Z3SolverContext.scala
80.45% <ø> (ø)

...a/at/forsyte/apalache/tla/lir/TestingPredefs.scala
76.47% <ø> (ø)

...ala/at/forsyte/apalache/tla/lir/TypedPredefs.scala
77.27% <ø> (ø)

...a/at/forsyte/apalache/tla/lir/UntypedPredefs.scala
80.00% <ø> (ø)

...yte/apalache/tla/lir/convenience/convenience.scala
100.00% <ø> (+66.66%)
:arrow_up:

...t/forsyte/apalache/io/json/impl/UJsonFactory.scala
100.00% <100.00%> (ø)

.../at/forsyte/apalache/tla/imp/StandardLibrary.scala
100.00% <0.00%> (ø)

...forsyte/apalache/tla/typecheck/etc/ToEtcExpr.scala
94.33% <0.00%> (ø)

...scala/at/forsyte/apalache/tla/pp/Keramelizer.scala
96.96% <0.00%> (+1.51%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42aacb1...20202e6. Read the comment docs.

@Kukovec why the preference against informative git messages? I tend to think these are great. But do you see them causing some sort of problem?

@Kukovec why the preference against informative git messages? I tend to think these are great. But do you see them causing some sort of problem?

That's a loaded question. My preference isn't against informative messages, it's against information dispersion. As it stands, we have explanations a) in the issue b) in the PR c) in issue/PR comments d) in the source code comments, and now also in e) commit messages. (a)-(d) are searchable, and (a)-(c) show up in emails. (d) is persistently visible. To view PR comments, one has to either manually invoke git commands or check the GithubUI (where PR messages are greyed out and behind an "expand"/"..." button).

I’ll echo Thomas in noting that each of these locations serves a different purpose.

(a) is to direct and inform future work
(b) is to communicate and give high-level context for merge requests (which conclude WIP)
(c) is for dynamic dialogue and discussion around planning and review
(d) is for elucidating/explaining complex code for a reader who is looking at the current state of the program (i.e. looking at the source code at one particular point in time)
(e) is for leaving a persistent record of the reason for a change or (in the event of a squashed pr) to give granular insight into changes to inform review (i.e. looking at the source code across two points in time)

afaict, there is no really useful place to record the kind of granular information about changes that Thomas has provided here outside of commit messages. Perhaps the only other contender would be as comments on the pr? That can help with review but isn't actually recorded in way that remains useful after the branch is merged.
The kind of disciplined commits Thomas is making here will prove very useful if we ever need to, e.g., run git bisect to track down an issue or pull up got blame to see why certain lines were changed (which I recommend doing in your editor, btw!).


No 1.4.3 release tarball

There is no Zulip version 1.4.3 release tar ball at https://www.zulip.com/dist/releases/.
@timabbott
Will there be a Zulip version 1.4.3 release tar ball?

Yep, we've moved the hosting to https://www.zulip.org/dist/releases/.
I guess I should have mentioned that in the email, sorry!


One Z-wave switch is being duplicated into Homebridge

Describe The Bug:
One (of several) Z-wave SmartThings switches is appearing twice.  Removing both from cached accessories results in duplication again.
To Reproduce:
Clear cached accessories.
Expected behavior:
Each Z-wave switch should appear once.
Logs: See attached.
Plugin Config:
    "name": "SmartThings",
    "BaseURL": "https://api.smartthings.com/v1/",
    "AccessToken": "XXXXXXX",
    "GarageDoorMaxPoll": 40,
    "PollLocksSeconds": 10,
    "PollDoorsSeconds": 10,
    "PollSensorsSeconds": 5,
    "PollSwitchesAndLightsSeconds": 5,
    "platform": "HomeBridgeSmartThings"
}

Screenshots:

Environment:

Plugin Version: 1.58
Homebridge Version: 1.6.0
Node.js Version: 18.13.0
NPM Version:
Operating System: Docker

After further investigation, the problematic device is an old one.  It was a Z-wave device that died, and was removed from SmartThings.  It does not appear in the SmartThings app, but this plug-in is still seeing it as being valid.

User error. Resolved.


Upgrade to sprockets 4

Migration guide available here: https://github.com/rails/sprockets/blob/master/UPGRADING.md
Basically, they're moving away from the practice of auto-compiling everything under assets/, and instead expect a manifest.js file to know what to compile. It also seems like it's a bit picky with some unexpected asset files like .xml or .json, so we had to reference the relevant favicon files directly to have them compiled.

Weird - the test seems to have flaked and died here? Retrying


Implement pep257 on repository.py

Current coverage is 100% (diff: 100%)

Merging #833 into master will not change coverage

@@           master   #833   diff @@
====================================
  Files          16     16
  Lines         632    632
  Methods         0      0
  Messages        0      0
  Branches        0      0
====================================
  Hits          632    632
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update 2513d43...2c4ef12

Thank you @terryjbates! 🍪


watchValue on a get property

i have a class with ValueNotifier<bool> get valueNotifierFromToBeDeterminedClass.
since it's a situation where the class is to be determined, in my watchValue, i can't hardcode that class name in watchValue.
how can i do this? thanks

Just use the basic watch function and add a .value
Am 15. Jan. 2024, 00:37 +0100 schrieb Matthew Kooshad @.***>:

i have a class with ValueNotifier get valueNotifierFromToBeDeterminedClass.
since it's a situation where the class is to be determined, in my watchValue, i can't hardcode that class name in watchValue.
how can i do this? thanks
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

ok, i've tried getting that syntax simply as you've stated, but unable so far. as i've exhausted the readme on the 5 examples of the basic watch function, i'll search around.

Can you add a code snippet where you want to use it then I can show you
Am 15. Jan. 2024, 17:21 +0100 schrieb Matthew Kooshad @.***>:

ok, i've tried getting that syntax simply as you've stated, but unable so far. as i've exhausted the readme on the 5 examples of the basic watch function, i'll search around.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

thanks,
class _Test extends WatchingWidget {
  const _Test();

  @override
  Widget build(BuildContext context) {
    final isEditing = watch(TestHelper).isEditing; // wrong
    return Text(isEditing);
  }
}

class TestHelper{
  static ValueNotifier<bool> get isEditing {
    return determineClassToUse().isEditing;
  }
}

do it like this
class _Test extends WatchingWidget {
  const _Test();

  @override
  Widget build(BuildContext context) {
    final isEditing = watch(TestHelper.isEditing).value;
    return Text(isEditing);
  }
}

class TestHelper{
  static ValueNotifier<bool> get isEditing {
    return determineClassToUse().isEditing;
  }
}

ah, i was close, thanks for the correction/help!
instead of:
final isEditing = watch(TestHelper).isEditing; // wrong
this works:
   final isEditing = watch(TestHelper.isEditing).value;
thanks again


Wrong warning "Code is Unreachable" when not using await in a async method

Environment data

Language Server version: v2020.9.0
OS and version: Windows 10 - 10.0.19041
Python version (& distribution if applicable, e.g. Anaconda): 3.7.3

Expected behaviour
Should not show Code is unreachable since the method being called is not awaited
Actual behaviour

Code Snippet / Additional information

without any await
import asyncio

class TestUnreachableCode:

    @staticmethod
    async def never_done_task():
        while True:
            await asyncio.sleep(0.01)

    async def test_sould_not_show_unreachable_code(
        self,
        some_object
    ):

        some_object.name = self.never_done_task()

        print('')  # <-- this code should not be marked as unreachable

using await keyword:
import asyncio

class TestUnreachableCode:

    @staticmethod
    async def never_done_task():
        while True:
            await asyncio.sleep(0.01)

    async def test_sould_not_show_unreachable_code(
        self,
        some_object
    ):

        some_object.name = await self.never_done_task()

        print('')  # <-- It's ok to mark this as unreachable code

Thanks for the bug report. You're correct that code after such a call should not be marked unreachable. I've disabled the NoReturn logic for all async functions, since it's often difficult or impossible to detect when the async function will execute. With the fix in place, neither of the above examples will report unreachable code. This fix will be in the next version of Pylance and Pyright.

Somewhat related... re: the latest Pylance changes (v2020.9.0)
Pylance still appears to be hinting Code is unreachable after calls to methods that had NoReturn and now (with the changes) return something else like Any.
I have the latest VSCode and Pylance as of writing.

@krooq, I'm not sure what you mean. If you think that there's a separate bug, please file a new issue and provide a sample. Thanks!

@krooq, I'm not sure what you mean. If you think that there's a separate bug, please file a new issue and provide a sample. Thanks!

Ticket raised here, it seems mostly unrelated to this ticket #334

Thanks for your attention @erictraut

This issue has been fixed in version 2020.9.4, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/master/CHANGELOG.md#202094-10-september-2020


Women's tennis?

Would be great to have these stats on women's tennis as well.

Woman's tennis would be great, but not enough free time :(.

Duplicate of #289

Get it, glad it's on the radar. I'd recommend making it more explicit though that it's a men's tennis site, as simple as adding one word here: "Welcome to Ultimate Tennis Statistics, the ultimate men's tennis statistics destination for the die-hard tennis fans!"
I spent some time looking for the women's stats. Great site, thanks for your work on it!


SSLError: HTTPSConnectionPool(host='www.quandl.com', port=443): Max retries exceeded

I am facing an issue. Kindly help me
Here's the code:
import pandas
import quandl
import time
df = quandl.get('FINRA/FNSQ_GOOGL')
print(df.head())
and the error which i am facing is:
Traceback (most recent call last):
File "C:\Users\Desktop\My Folder\test.py", line 5, in
df = quandl.get('FINRA/FNSQ_GOOGL')
File "C:\Python27\lib\site-packages\quandl\get.py", line 48, in get
data = Dataset(dataset_args['code']).data(params=kwargs, handle_column_not_found=True)
File "C:\Python27\lib\site-packages\quandl\model\dataset.py", line 47, in data
return Data.all(**updated_options)
File "C:\Python27\lib\site-packages\quandl\operations\list.py", line 14, in all
r = Connection.request('get', path, **options)
File "C:\Python27\lib\site-packages\quandl\connection.py", line 36, in request
return cls.execute_request(http_verb, abs_url, **options)
File "C:\Python27\lib\site-packages\quandl\connection.py", line 50, in execute_request
raise e
SSLError: HTTPSConnectionPool(host='www.quandl.com', port=443): Max retries exceeded with url: /api/v3/datasets/FINRA/FNSQ_GOOGL/data?order=asc (Caused by SSLError(SSLError("bad handshake: Error([('SSL routines', 'tls_process_server_certificate', 'certificate verify failed')],)",),))
I even tried the below code, but no luck,
import pandas
import quandl
import time
df=''
while df=='':
try:
df = quandl.get('FINRA/FNSQ_GOOGL')
except:
time.sleep(5)
print("try")
continue
print(df.head())
It would be grateful if somebody help me solve this issue. Thanks in advance!!

Hi there! Thanks for opening this issue. Unfortunately, it seems this is a request for help instead of a report of a defect in the project. Please use StackOverflow for general usage questions instead and only report defects here.
Further more, it appears as if this is not actually related to urllib3. The exception looks familiar but there's no urllib3 files in the traceback.


SQLite needed for installation?

I followed all instructions for installation from scratch with the following:
Ubuntu 20.04.3
PIP 21.3.1
Python 3.8.10
WG/WG-tools
When the installation is complete, I try to access the webpage, there is an error in the browser:
Internal Server Error
The server encountered an internal error and was unable to complete your request. Either the server is overloaded or there is an error in the application.
When running ./wgd.sh debug I get this:
user@vpn:~/wgdashboard/src$ ./wgd.sh debug
| Starting WGDashboard in the foreground.                  |

Serving Flask app 'WGDashboard' (lazy loading)
Environment: production
WARNING: This is a development server. Do not use it in a production deployment.
Use a production WSGI server instead.
Debug mode: off
Running on all addresses.
WARNING: This is a development server. Do not use it in a production deployment.
Running on http://<IP_ADDRESS>:10086/ (Press CTRL+C to quit)
[2022-01-26 16:04:28,665] ERROR in app: Exception on / [GET]
Traceback (most recent call last):
File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 2073, in wsgi_app
response = self.full_dispatch_request()
File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1518, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1514, in full_dispatch_request
rv = self.preprocess_request()
File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1857, in preprocess_request
rv = self.ensure_sync(before_func)()
File "dashboard.py", line 637, in auth_req
g.db = connect_db()
File "dashboard.py", line 61, in connect_db
return sqlite3.connect(os.path.join(configuration_path, 'db', 'wgdashboard.db'))
sqlite3.OperationalError: unable to open database file
<IP_ADDRESS> - - [26/Jan/2022 16:04:28] "GET / HTTP/1.1" 500 -
[2022-01-26 16:04:28,737] ERROR in app: Exception on /favicon.ico [GET]
Traceback (most recent call last):
File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 2073, in wsgi_app
response = self.full_dispatch_request()
File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1518, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1514, in full_dispatch_request
rv = self.preprocess_request()
File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1857, in preprocess_request
rv = self.ensure_sync(before_func)()
File "dashboard.py", line 637, in auth_req
g.db = connect_db()
File "dashboard.py", line 61, in connect_db
return sqlite3.connect(os.path.join(configuration_path, 'db', 'wgdashboard.db'))
sqlite3.OperationalError: unable to open database file
<IP_ADDRESS> - - [26/Jan/2022 16:04:28] "GET /favicon.ico HTTP/1.1" 500 -

It seems to be trying to access a database file that doesn't exist.
I notice that there is mention in the changelog that there has been a move from TinyDB to SQLite but there is no mention of SQLite in the installation instructions.  Are we supposed to install this separately or should the WGdashboard installer call for the the installation?  And if we are to install it separately, how do we link WGdashboard to the DB?

Hi, there are no need to install SQLite, Python already included it. I'm suspecting is because python does not have the permission to read files. Could you please try to run it with sudo ./wgd.sh debug and see if this would help ;)

Thanks - that was it!

Hi, I'm glad we solved this!! If you do not want to run in sudo mode, you can do the following sudo chown -R user:user wgdashboard from the folder where it contain the dashboard's folder ;)

Perfect Thanks!


tencent-meeting.exe, rongda-zhihuiyun.exe, wind-financial-tool.exe  need to be updates

updates
1**Package Name: tencent-meeting.exe   V<IP_ADDRESS>2   [https://updatecdn.meeting.qq.com/cos/947a8fd1faf0d491148980605952049b/TencentMeeting_0300000000_<IP_ADDRESS>2.publish.exe]
2**Package Name: rongda-zhihuiyun.exe   V2.8.6   [https://download.rongdasoft.com/update/prod/280/Rd_IBSaas_V2.8.6.exe]
3**Package Name: wind-financial-tool.exe   V22.8.0   [https://d-cdn.wind.com.cn/windnet/WFT_Setup_CHS.zip]

thank you very much

@NoPKU  Thank you for reporting, will try to update them and try to write RegEx-es. Cannot see the manifests right now as I'm on the phone, but it is funny how the Python bots, who are supposed to update the packages automatically, don't update them at all. Right now I'm at work, will try to make sense about it in about 8-10 hours from now.

[x] Updated rongda-zhihuiyun
[ ] Updated wind-financial-tool
[ ] Updated tencent-meeting


Update Dockerfile and build to use logmet

The only test I've done is just a clean rebuild.

This change is

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

map-wlpcfg/Dockerfile, line 23 at r1 (raw file):

ADD ./servers/gameon-map /opt/ibm/wlp/usr/servers/defaultServer/
ADD ./server-logmet-dropin.xml /opt/ibm/wlp/usr/servers/defaultServer/configDropins/overrides/

We're removing this one.. Moved/handled in startup.sh instead of in the dockerfile

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.

Comments from Reviewable

Reviewed 13 of 13 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Project configuration - multiple save buttons can lose data

Describe the bug
When configuring a project - each section has a save button. However its common to configure multiple options in multiple sections in 'one go'
Hitting save after doing so may cause one to loose configurations in other sections.
To Reproduce
Steps to reproduce the behavior:

Go to 'Project, configure'
Click on 'Collaborators'
Configure options in Instruction, Interface and Completions.
Click one of the save buttons.
Only one of the options configured is saved.

Expected behavior
All options are saved.

It seems it's not a bug. Each section has own "Save" button. To save anything in section you need to tap corresponding to this section "Save". But yes, it's not very comfortable, in future we'll make an instant saving of options without "Save" buttons.

I agree it’s not a bug - but it’s a design issue that makes it easy to configure things and then lose the configuration unexpectedly. Thanks for consideration!


optimize black

the change can make code cleaner and faster.

wait for https://github.com/Azure/autorest.python/pull/1317 so close temporarily


Add recommended way to upgrade Docker container

Awesome container... Might be helpful to new Docker users (myself included), to provide some instructions on upgrading the Docker container:
As far as I know, upgrading should be just:

Stop existing container: docker stop caravel
Remove existing container: docker rm caravel
Pull new container from repo: docker pull amacevice/caravel
Run new container linking it up to the existing Docker storage on the host used for the previous container (as per instructions on front page)
Execute Caravel upgrade function in the container: caravel db upgrade

Is this correct?

Yeah, that all looks correct  to me. Good suggestion.

Added a bit too the README


Parse environment variables in config file

I would like to know if there's a way to use environment variables in a config file. In the following example, $HOME and $CUDA will not be converted to the corresponding values:
data-dir=$HOME/data
cuda-dir=$CUDA

Thank you very much in advance for your help!

This is not currently supported. It's non-trivial to add this behavior in a robust way.

or it might not be that difficult. If you still need this, please submit a PR, adding an option to the ArgParser constructor to enable this behavior (since enabling it by default might break existing config files).
Then run os.path.expandvars() on config file value strings.


deal with calls blocked by twilio

twilio blocked<PHONE_NUMBER> for some reason
what other numbers are blocked?
maybe we should have a special error message?

at least preblock them so w don't get the unavailable log entry

I figure we should just redirect this to the operator since those 1212 numbers are telco information numbers.

+1


Replace luet-makeiso with elemental build-iso.

Problem:

We need to migrate from luet-makeiso to elemental build-iso.
Solution:

Add elemental base image for elemental binary and rsync package for elemental build-iso command execution.
Related Issue:
https://github.com/harvester/harvester/issues/2204
Test plan:

Build an ISO from elemental-build branch (both harvester and harvester-installer repo);
Try to boot up using this ISO in UEFI environment, it should boot up without problem;
Try to boot up using this ISO in legacy BIOS environment, it should not boot up;

Additional Information:
We might need to create another issue to add legacy BIOS boot capability if it's necessary.

As I'm working on adding legacy BIOS support, converting this PR to draft.


Recipe highlighting

Parse recipe ingredients and steps to extract critical parts of it such as:

Ingredient quantity and UOM
Step times and temperatures

Implemented in #198


Automatically discard interview records that are outside of study area

Use the strata_names object for this.

Closed in #131


Telegram

I suggest to add an option for telegram because discord keeps banning everything and everyone, sadly that wouldnt make it a discord rat but what would you need a discord rat for if it cannot function for more than a day you could just keep discord but the telegram option migth be a little bit more sustainable for longer use or you can just create a dedicated control gui without this discord stuff but i dont know if that is possible and i am no coder so thank you for reading this and i apologize for my grammar english is not my first language thank you for rewiewing this goodbye.

Never apologize for knowing other language, especially never apologize people who's english is their first language and probably only language, because you actually did something and learned a foreign language. As of telegram thing - we are currently working on telegram based version, however it won't be open sourced. Join our telegram community group to stay up-to-date with that.

Thank you for replying i have two questions by “wont be open sourced” do
you mean it wont be open to the public or the code will just be private
also how can i join the telegram comunity sincerely
Lukas.
út 29. 10. 2024 v 10:56 dop. odesílatel mategol @.***>
napsal:

Never apologize for knowing other language, especially never apologize
people who's english is their first language and probably only language,
because you actually did something and learned a foreign language. As of
telegram thing - we are currently working on telegram based version,
however it won't be open sourced. Join our telegram community group to stay
up-to-date with that.
—
Reply to this email directly, view it on GitHub
https://github.com/mategol/PySilon-malware/issues/713#issuecomment-2443750624,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BBFBLJUHIMYZ7NNI6CVUTR3Z55LUVAVCNFSM6AAAAABQZH4WFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBTG42TANRSGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Telegram community: https://t.me/+8razFyklyFw2OWU0

by “wont be open sourced” do you mean it wont be open to the public or the code will just be private

It won't be open to the public. At least not as open source repository on github. It will be paid to limit the community size and get rid off skids.