[SCM] Ability to edit while commit is in process is misleading

This issue is very noticeable if you have git hooks which take a little time to execute

VSCode Version: 1.11-insider
OS Version: Win10

Steps to Reproduce:

Stage some files, make a commit
While the commit is in progress, the commit message text box is enabled, which allows me to change the message - but this message doesn't get committed.
While the commit is in progress, I can change the staged files (add/remove more files), which do get committed.

Now, I'm not sure exactly what the intended behaviour is, but as I see it:

The message should not be editable, or if it is editable, the final message should be applied to the commit.
The staged file list should not be editable, because if it is, then there is a problem since the list of files passed to the pre-commit hook, and the list of files committed can be different. This can cause potential bugs in projects if they rely on commit-hook to be a source of truth.

For a reference, Git-GUI disables any action while a commit is in progress.

To keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed.
Thanks for your understanding. Happy coding!


Charts missing axis labels on genome overview

(See "Genomic Features" and Speciality Genes")

https://patricbrc.org/view/Genome/520456.3
i'm assuming he means the units on the x-axis for protein features and Specialty Genes, but I think those are just a simple count of how many there are?

My confusion with this UI is that the label for each chart is above the chart and there is no separation between charts so it is not easy to tell which chart goes with which heading. So just move the heading closer to the chart that matches it, and put more spaces in between each chart  or a separation of some sort.

https://github.com/PATRIC3/p3_web/pull/706


feat: date picker

resolve #297

Good first version! There are few things we could improve (iteratively in a separate PR):

Indeed, the date picker seems very innocent but there are a lot of small details that makes it difficult to implement well.

* solve displaying the calendar on small screens

I would consider detecting if running on mobile and using a hidden input with type="date" and trigger that so that a native date picker is displayed on mobile.

Works well.
I found a minor issue: when using the keyboard you have to press tab twice so that the focus leaves the text input. This can be addressed in a different PR.


Added Pickery

https://github.com/Performador/Pickery

Pickery is an AWS based photos app. It uploads your pictures to S3 and provides a simple and efficient browsing experience.

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 or later
[x] Supports Swift 3
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Error

:no_entry_sign:
Found 1 link issue

Link issue by awesome_bot

Line
Status
Link

754
301
https://github.com/zalando/MapleBacon redirects tohttps://github.com/zalando-incubator/MapleBacon

  Generated by :no_entry_sign: danger

Hey @Performador , thanks for contributing to AwesomeiOS! 👍
Great work, but before collaborators can merge your PR, I need you to fix this issue.

@naeemshaikh90 @Performador we usually do not add apps to our list, thanks
@lfarah can we put something in contributing guidelines?

Yes I forgot that😁

Wrong project, my bad. Sorry.


Bare variables aren't supported anymore (ansible 2.0+)

Replication
After starting with fresh ms-lifecycle  docker box I've ended up with an error:
$ vagrant up cd --provision
...
==> cd: fatal: [localhost]: FAILED! => {"failed": true, "msg": "the field 'args' has an invalid value, which appears to include a variable that is undefined. The error was: 'unicode object' has no attribute 'host_ip'\n\nThe error appears to have been in '/vagrant/ansible/roles/common/tasks/main.yml': line 7, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Host is present\n  ^ here\n"}
Fix
According to ansible 2.0 changelog bare variables aren't supported anymore, they must use the full jinja2 syntax ('{{var_name}}').
ansible/roles/common/tasks/main.yml line 7:
   with_items: "{{ hosts}} "
ansible/roles/common/tasks/main.yml line 7:
    with_items: "{{ obsolete_services }}"

This really helped ! Just to correct the typo, with_items: "{{ obsolete_services }}" is at ansible/roles/common/tasks/main.yml line 20


Python breakpoints not being 'hit'.

Python code Breakpoints not being hit.

Breakpoints window shows error for each breakpoint.
Refers to error 12548

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3c93cd83-ee45-dbd4-e3b2-48c731e46419
Version Independent ID: e8920cca-b8db-369a-e249-938b995b5f14
Content: Debug user code with Just My Code - Visual Studio (Windows)
Content Source: docs/debugger/just-my-code.md
Product: visual-studio-windows
Technology: vs-ide-debug
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

@livewiresw -- thank you for your feedback.  This repo is solely for documentation issues, and this appears product-related.  Please consider these resources:

Visual Studio on Microsoft Q&A
Visual Studio MSDN Forum
Stack Overflow
Reddit

cc @Mikejo5000 for awareness
I am closing this issue now.  You are welcome to @ mention me for any followup.  We hope to hear from you again.


Endorse usage of UUIDs for podcast feeds (and episodes?)

Coming back to the iTunes ID discussion in this weekends podcasting 2.0 episode:
I think we should endorse a randomly generated ID for a podcast feed which uniquely identifies a feed, even if the URL to that feed changes. This is basically what the iTunes ID is used for in many third party systems today, which the exception of Google Podcasts which uses a hash of the first URL of a feed it discovers.
Should there be add a new element <podcast:guid>c26c1f8b-eb53-47ad-8248-8ff276a4539e</podcast:guid> on the feed level?
Should we add relations between feeds e.g. for spinoffs e.g. https://fyyd.de/podcast/rabbit-hole which is a short one-time series of https://fyyd.de/podcast/the-daily/ ?
<podcast:guid parent="53057254-79bc-4363-bfc9-13e97459babb">c26c1f8b-eb53-47ad-8248-8ff276a4539e</podcast:guid>

Should alternate versions of a feed (e.g. the OPUS version, instead of MP3) have the same GUID value?

I'm 100% on board with this.  I think it makes more sense to discuss it in the podping repo though.  And, then what we decide there can be pulled into the namespace if it's going to be applicable:
Universal podcast identifiers

Agreed. This is becoming a bigger discussion. Also talking about it in the channel proposal thread.

Just for reference: On the feed level we introduced <podcast:guid> for episodes there is already a typical mechanism now documented at https://github.com/Podcastindex-org/podcast-namespace/blob/main/docs/other-recommendations.md#episode-guid

So Podlove is producing the feed level guid now?  podcast:guid has gained traction quicker than I anticipated.  I need to do a write up on it for larger market so people understand what they can do with it.

@daveajones Sorry for the confusion bad wording on my site: "We" meant the Podcasting 2.0 developer community here in this org. It looks like nobody in the Podlove project has implemented it yet, but maybe I will create a PR now... :-)
(I was just cleaning up some thoughts/issues)


Issue reporting link follows the wrong repository

Describe the bug
The link follows the original repository instead of this one. At least, the owner of the original repo archived the repo today and added a pinned issue pointing to this place after I asked them about the repo status, so this isn't going to be a big issue anymore
Environment:

Browser: Vivaldi
Hosted Azure DevOps

Screenshots

To Reproduce
Steps to reproduce the behavior:

Open editor
Click on Report an issue

Expected behavior
It to send people here

Hi, The link is correct, and you should use this extension instead for Otto's extension

@AminTi, thanks. I'll report it to the people who manages our Azure DevOps.
Is it possible to migrate without losing our queries?


Add Documentation for different runners for release 0.1

Add Documentation for different runners for release 0.1
Current runners for 0.1 release are:

[ ] ssh runner
[ ] docker runner
[ ] Kubernetes runner
PRs needed for each.

we will have a runner spec to guide the runner standard, which should make documentation easier for individual runners. we will probably have a discussion on that this week.

SSH and Docker runners are implemented in #77.

Done.


composer require "magento/magento:<IP_ADDRESS>" does not work

My Repo contains <IP_ADDRESS> and I've also tried your repo too.
I get:
composer require "magento/magento:<IP_ADDRESS>"
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - The requested package magento/magento could not be found in any version, there may be a typo in the package name.

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://groups.google.com/d/topic/composer-dev/_g3ASeIFlrc/discussion> for more details.

Read <http://getcomposer.org/doc/articles/troubleshooting.md> for further common problems.

Installation failed, reverting ./composer.json to its original content.

However running composer require "magento/magento:<IP_ADDRESS>" does work from your repo!

Hey, could you show your composer.json file? And does your core repository have a composer.json file? Does it contain the correct name and is it tagged correctly?
Did you specify your core-repo as a repository in your projects composer.json file?

my composer.json is:
{
    "require": {
        "aydin-hassan/magento-core-composer-installer": "~1.3"
    },
    "repositories": [
      {
        "type": "vcs",
        "url": "git@github.com:AydinHassan/magento-community.git"
      }
    ]
}

I didn't tag <IP_ADDRESS> yet that's why. I'm not sure why your's doesn't work. You should check out the composer docs because this is unrelated to the installer. I'm travelling atm so not able to tag the new version, sorry.

@AydinHassan How do you "tag" a release? I am on my own repo, It's created a 1.9 branch, The commit history says Magento Community <IP_ADDRESS> and my composer.json looks like this:
I did create as per your instructions
{
    "name": "magento/magento",
    "description": "Magento Community",
    "type": "magento-core"
}

You need to use git, Composer uses git tags to pull in releases. You can do this on the command line or via GitHub by clicking on the releases tab.
Sent from my iPhone

On 29 Oct 2015, at 15:50, Craig Carnell<EMAIL_ADDRESS>wrote:
@AydinHassan How do you "tag" a release? I am on my own repo, It's created a 1.9 branch, The commit history says Magento Community <IP_ADDRESS> and my composer.json looks like this:
I did create as per your instructions
{
"name": "magento/magento",
"description": "Magento Community",
"type": "magento-core"
}
—
Reply to this email directly or view it on GitHub.

@AydinHassan Thanks works a treat :+1:

Good to hear!
Sent from my iPhone

On 29 Oct 2015, at 16:04, Craig Carnell<EMAIL_ADDRESS>wrote:
@AydinHassan Thanks works a treat
—
Reply to this email directly or view it on GitHub.

@AydinHassan One final issue, my composer.json in the root was replaced with the one from my composer related repo?

Ah, if you don't deploy to a subdirectory you will need to exclude that file from the copy, just do a search in the readme for excludes and you should see it
Sent from my iPhone

On 29 Oct 2015, at 16:16, Craig Carnell<EMAIL_ADDRESS>wrote:
@AydinHassan One final issue, my composer.json in the root was replaced with the one from my composer related repo?
—
Reply to this email directly or view it on GitHub.

@AydinHassan Exactly, thanks!


Add trait types for c++

For a message like
message MyMessage {
  float number = 1;
}

It would be great if the following extra template constants existed

static pb_field_t const* const pb_traits<MyMessage>::fields == MyMessage_fields

static int const pb_traits<MyMessage>::tag_v<&MyMessage::number> == MyMessage_number_tag (C++17)
static int const pb_traits<MyMessage>::tag_v<&MyMessage::number, float> == MyMessage_number_tag (C++14)
static int const pb_traits<MyMessage>::tag<&MyMessage::number, float>::value == MyMessage_number_tag

static size_t const pb_traits<MyMessage>::max_size == MyMessage_size
static MyMessage const pb_traits<MyMessage>::init_zero == MyMessage_init_zero
static MyMessage const pb_traits<MyMessage>::init_default == MyMessage_init_default

You can kinda-sorta approximate this by having a macro that specializes all those traits you specify for a given type name, then just calling the macro with all your NanoPB message types.
I agree that this would be handy though.  I'd like to do some type-safe boilerplate reduction in C++ using traits such as these, and it would be nice to have all of it generated.
Note that they should probably be constexpr.

Add a basic kind of thing in #384. Can be used to expand on this request further.

Can you give an example of the code yours generates here?

vlovich's pull request is now included in 0.4.0.


Dev/crutkas/fix spelling error

Summary of the Pull Request
Trying to resolve the warning for 8LWXpg user name

/azp run


Initial run failing

Node version: 6.9.2
npm version: 3.10.9
Operating system: Sierra
Command line used: npm start
Steps to reproduce:

Download latest build
npm install
npm start

Result: Failed at the<EMAIL_ADDRESS>prestart script 'npm-run-all --parallel start-message'.
Seems related to: https://github.com/coryhouse/react-slingshot/issues/231

Can you explain how you downloaded the repo?
I was unable to reproduce this. Steps I took.

Open term to react-slingshot working directory
Pulled latest master
Ran git clean -fdx - this removes all files/directories not commited or in .gitignore this ensures I don't have any node_modules not specified in the package.json
Ran npm install - per-instructions
Ran npm start - per-instructions

I was able to open see the example app.
Could you please clone the latest and see if the issue persists? Version 6.0.0 was released since this was opened and includes new features such as Webpack 2, Jest, and PostCSS w/ autoprefixer. There may have been changing with the last few days that may resolve the error you were receiving.

events.js:141
throw er; // Unhandled 'error' event
^
Error: watch null EMFILE
at exports._errnoException (util.js:907:11)
at FSEvent.FSWatcher._handle.onchange (fs.js:1217:21)
npm ERR! Darwin 16.3.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "test" "--" "--watch"
npm ERR! node v4.5.0
npm ERR! npm  v2.15.9
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>test: jest "--watch"
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>test script 'jest "--watch"'.
npm ERR! This is most likely a problem with the react-slingshot package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     jest "--watch"
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs react-slingshot
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls react-slingshot
npm ERR! There is likely additional logging output above.

Up and running now. Thanks.


Fix "skip", "next" and "done" button positions on iOS

Fixes #111. Not tested on Android, so please do before merging.

You can also apply the same style adding custom style:
<AppIntro customStyles={{ btnContainer: {flex: 1} }}>
...
</AppIntro>```

Works, thanks @fortinmike & @arturowczarek !


Encode secondary login URL

Details
iOS treats URL encoding a bit differently and I had to adjust it to be able to deeplink into the secondary login page in OldDot.
Fixed Issues
$ https://github.com/Expensify/App/issues/6475
Tests

Launch the app and login with gmail account
Initiate VBA flow and add an "Open" bank account. Instructions.
At the last step tap "Add work email address"
Verify that OldDot opens in the accounts page and the add secondary login modal opens.

QA Steps

Launch the app and login with gmail account
Initiate VBA flow and add an "Open" bank account. Instructions.
At the last step tap "Add work email address"
Verify that OldDot opens in the accounts page and the add secondary login modal opens.

 I think there were some conflicts while merging, we're not seeing build 1.1.16-9 https://github.com/Expensify/App/pull/6481#issuecomment-979434234

Thanks @isagoico! Conflicts resolved. Deploying here

🚀 Cherry-picked to staging by @madmax330 in version: 1.1.16-9 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

App is crashing on iOS and Android when tapping on "Add work email..." button. Video belo
https://user-images.githubusercontent.com/44479856/143505325-b0659e02-e343-4969-a8cd-0a1ef3931686.mp4

Tested this on Android and iOS and it's a pass 🎉 No more crashes!

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by @madmax330 in version: 1.1.16-11 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

The accessibility issues related to this PR:

The "Add work email address" link is announced without role, just as plain text. The screen reader user is not informed that it opens a new browser tab - failure of WCAG SC 4.1.2

The grey Close button (#C6C9CA) on white background (#FFFFFF) has a color contrast ratio of 1.66:1, failing the minimum contrast requirements of 3.00:1 - failure of WCAG SC 1.4.11
The grey Email or Phone placeholder text (#7D8B8F) on white background (#FFFFFF) has a color contrast ratio of 3.52:1, failing the minimum color contrast of 4.50:1 - failure of WCAG SC 1.4.3

The white text (#FFFFFF) against green background (#03BB6D) has a color contrast ratio of 2.52:1, failing the minimum contrast requirements of 4.50:1 - failure of WCAG SC 1.4.3

The Close button and Privacy link have no visible outline on focus due to CSS outline:0 rule. The keyboard users will not be able to determine the currently focused element - failure of WCAG SC 2.4.7

The light green focus outline (#80E8BC) against green button (#03BB6D) has a color contrast ratio of 1.70:1, failing the minimum contrast requirements of 3.00:1 - failure of WCAG SC 1.4.11

The blue Privacy link (#0185FF) against white background (#FFFFFF) has a color contrast ratio of 3.62:1 failing the minimum color contrast requirements of 4.50:1 - failure of WCAG SC 1.4.3

The Close modal button is announced without any label, as "button" - failure of WCAG SC 4.1.2

Incorrect document role and no label provided for modal dialog - failure of WCAG SC 1.3.1

The Email or Phone text field uses placeholder text as the only label. Once user starts typing into the field, the placeholder text disappears and the field's purpose is no longer obvious - failure of WCAG SC 3.3.2

The focus is not trapped in the modal dialog and the background elements can be focused with keyboard - failure of WCAG SC 2.4.3

https://user-images.githubusercontent.com/88733897/144472100-349125b6-fb46-47e1-9426-e386f041b407.mp4

🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[A1111] Use the Webui's built-in InputAccordion component

The Automatic1111 Webui now has a built-in InputAccordion component, which functions basically the same as it is right now.
Therefore, no longer need to implement one again using JavaScript.

This will close #104 and Haoming02/sd-webui-tabs-extension#25


Updated commit message

As per issue #186. References updated:

Unit tests in PullRequestBodyTests.cs
Comment in PullRequestBody.cs
CommitMessageTitle variable in KnownGitHubs.cs
Sample commit data in commit-imgbotbranch-byimgbot.json

:+1 :+1 :+1 awesome


Use Metagov slack.emoji-vote for boolean PlatformAction votes and elections

Use the slack.emoji-vote metagov governance process to administer two kinds of votes: (1) Boolean votes on PlatformActions, and (2) Choice votes on PlatformActionBundle elections. Slack election voting was broken before, this fixes it.

Follow-ups:

Support ConstitutionActions https://github.com/amyxzhang/policykit/issues/412
Handle closing processes so we don't have dangling pending processes in metagov

Looks good!


Fix Elevate operator GUI crash.

Description
Resolves # (If this PR is unrelated to a ticket, please erase this line)
Please include a summary of the change
Type of change
Please select one below (Please click check boxes AFTER submitting ticket)

[ ] Bug fix
[ ] New feature
[ ] New Documentation
[ ] Other (please describe below)

How Has This Been Tested?
Please describe the tests you've added or any tests that already cover this change. Include relevant information, such as which operating system you tested on.
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have updated the release notes
[ ] I have made corresponding changes to the documentation
[ ] I have added debugging support to my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I have added any new baselines to the repo
[ ] I have assigned reviewers (see VisIt's PR procedures for more information).

Thanks Brad

Thanks Brad, just wondering, are you going to apply the fix to 3.0RC as well?

If Brad doesn't have time, I'll do it.

Hi Mark, I hadn't planned on doing any 3.0RC merge. I don't know what the procedure is these days. I just came across this little fix I had from a couple months ago when updating VisIt locally.

No worries. I'll cherry-pick your commit here into 3.0RC


Fix android initialization order

What does the pull request do?
Before Skia was initialized twice on android backend.
Also, before TopLevelImpl was created before AppBuilder was set up.
And updates some AOT build parameters

You can test this PR using the following package version. 0.10.999-cibuild0021015-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]


[BUG] Snyk job stays pending

Describe the bug
Snyk job is currently staying in "pending state"
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Logs
If applicable, add logs to help explain your problem.
Environment (please complete the following information):

OS: N/A
Output of the mvn -version` command
Kaoto Version [e.g. 1.0]

Additional context

there are 2 jobs for Snyk:

one with Kaoto label which is fine
one with Delawen label which stays pending

on latest PR, there is no more the job with Delawen label https://github.com/KaotoIO/kaoto-backend/pull/430


Fix release name

Description
Changes proposed in this pull request:

set the release name to the serverless

Related issue(s)

https://github.com/kyma-project/serverless-manager/issues/107

/recheck-cla

/cla-recheck

/cla-recheck


Fix start:mocks and dev:remix

Fixes #20 and #21

@kentcdodds Hi this is awaiting approval to run the workflow, thanks very much!

Hmm... So this may have been done preemptively, I can see that this misses out the script files that do some system checks and whatnot... so not so sure if this is just a good temp fix until the scripts can be sorted out or if this just shouldn't be done as it may cause other issues (which I'm sure the script files were created to address)

The challenge here is that cli.js is really an implementation detail, so I'm not sure we want to hit it directly if we can avoid it. Investigating some other solutions though.

I've already got a good solution. I'm working on this now.

Could you try the latest version? I'm pretty sure this is resolved now.


chore: add aviralsharma07

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Thanks, @Panquesito7 and @Pradumnasaraf  for your Help !!


MVC6 Razor views are not compiled at runtime. Console application project.

I have problem similar with Cannot use types from class libraries (csproj) in razor views . When some MVC Razor View is requested at runtime no reference is found:

Workaround with context.Compilation works for me, but it still a workaround and I'm looking for a real solution. The main difference in my approach is I'm not using .NET CORE SDK to create MVC6 app, but installed all required packages in a simple Console application project. Not using project.json, but packages.config. Building from command line with MsBuild 14.
Any thoughts on this?
If neccessary I can upload repro project.

Thanks, so instead of adding all the references in compilation callback I'm adding additional references to the AdditionalCompilationReferences collection and it works just fine:
services.AddMvc()
    .AddRazorOptions(
        options
            => {
            var assemblies = AppDomain.CurrentDomain.GetAssemblies().ToList();
            assemblies.Add(typeof(Microsoft.CSharp.RuntimeBinder.Binder).Assembly);
            var refs = assemblies
                .Where(x => !x.IsDynamic && !string.IsNullOrWhiteSpace(x.Location))
                .Select(x => MetadataReference.CreateFromFile(x.Location))
                .ToList();
            foreach (var portableExecutableReference in refs) {
                options.AdditionalCompilationReferences.Add(portableExecutableReference);
            }
        });

But I'm still wondering if it's a workaround or the intended behavior?... Seems strange, that I have to explicitly specify to RazorEngine to load even mscorlib.dll, not talking about some 3rd party library.

@rusanov-vladimir You should only need to add assemblies that aren't referenced by your project. Do you have "preserveCompilationContext": true in your buildOptions?

@NTaylorMullen  preserveCompilationContext Is a build option of project.json. Since I'm not installing .NET Core SDK (project constraint - web-site should be built on client's machine where it's not available), I'm unable to set that option, because there is no project.json, just regular .csproj. Is there a way to set this option via code? Doubt that MsBuild could have some option for it...

@rusanov-vladimir this is our detection logic in MVC: https://github.com/aspnet/Mvc/blob/760c8f38678118734399c58c2dac981ea6e47046/src/Microsoft.AspNetCore.Mvc.Core/ApplicationParts/AssemblyPart.cs#L48

@NTaylorMullen Pardon my ignorance, but I don't understand how this information could help me. As I understand MVC is relying on .deps.json file, that is generated by cli during the build. Since there is no .deps.json generated in my case  DependencyContext.Load returns null and GetReferencePaths() returns assembly itself, which is not enough for RazorCompiler to succeed. Currently I'm feeding all the assemblies in my output directory to the Razor Compilation, but I susspect at least 2 issues with this:

performance - I'm loading unneeded stuff
GAC references - If a reference is not copied to output, like GAC references, it's not considered during Razor Compilation.
I'm not sure if I could generate .deps.json without 'project.json', but I don't needed it, it's enough to know which references should be included for Razor Compilation.

@pranavkm Thank you for details! I will check if I could adapt the solution with MsBuild. Regarding the issues I've mentioned:

Great, didn't think of it!
Here I have some doubts: In my snippet you could notice, that I'm adding explicitly Microsoft.Csharp.dll. The reason is that without it on a clean machine(only .NET 4.5.2 installed) I'm getting following error during Razor Compilation:

It's hardly reproduced on my development machine. I thought that the reason for this to happen is that Microsoft.Csharp.dll is referenced from GAC and not copied in output. Adding Microsoft.Csharp.dll to the list of libraries fixes the issue, but I'm worried if there would be no other lib that might be missing.

The Microsoft.CSharp scenario is interesting. Mvc references the package (https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.Abstractions/project.json#L47), so using DependencyContext \ preserveCompilationContext in a project.json world would've added this reference to your project.
One way to ensure you're not missing these binaries might be to restore a net4x targeting project.json- based class library that has Microsoft.AspNetCore.Mvc as a solitary reference. The project.lock.json that gets produced as part of restore should include the closure of binaries that you would have picked up transitively as a result of referencing Mvc.

@pranavkm  Finally I've tried your suggestion. The result is not exactly as I've expected. First of all, I've noticed that when building a project.json-world solution without any reference at all, there are 4 compile referencies in -compile.deps.json. I'm not sure if it's related to my issue and it's enough just to add them to AdditionalCompilationReferences.
project.json:
	{
	  "dependencies": {
		/*"Microsoft.AspNetCore.Mvc": "1.1.0-preview1-final"*/
	  },

	  "tools": {

	  },

	  "frameworks": {
		"net452": {}
	  },

	  "buildOptions": {
		"emitEntryPoint": true,
		"preserveCompilationContext": true
	  },

	  "publishOptions": {
		"include": [
		  "wwwroot",
		  "web.config"
		]
	  },

	  "scripts": {
		"postpublish": [
		  "dotnet publish-iis --publish-folder %publish:OutputPath% --framework %publish:FullTargetFramework%"
		]
	  }
	}

-compile.deps.json
	{
	  "runtimeTarget": {
		"name": ".NETFramework,Version=v4.5.2/",
		"signature": "da39a3ee5e6b4b0d3255bfef95601890afd80709"
	  },
	  "compilationOptions": {
		"defines": [
		  "DEBUG",
		  "TRACE",
		  "NET452"
		],
		"platform": "x64",
		"optimize": false,
		"emitEntryPoint": true
	  },
	  "targets": {
		".NETFramework,Version=v4.5.2": {
		  "MvcCoreApp/1.0.0": {
			"compile": {
			  "MvcCoreApp.exe": {}
			}
		  },
		  "mscorlib/<IP_ADDRESS>": {
			"compile": {
			  ".NETFramework/v4.5.2/mscorlib.dll": {}
			}
		  },
		  "System/<IP_ADDRESS>": {
			"compile": {
			  ".NETFramework/v4.5.2/System.dll": {}
			}
		  },
		  "System.Core/<IP_ADDRESS>": {
			"compile": {
			  ".NETFramework/v4.5.2/System.Core.dll": {}
			}
		  },
		  "Microsoft.CSharp/<IP_ADDRESS>": {
			"compile": {
			  ".NETFramework/v4.5.2/Microsoft.CSharp.dll": {}
			}
		  }
		},
		".NETFramework,Version=v4.5.2/": {
		  "MvcCoreApp/1.0.0": {
			"runtime": {
			  "MvcCoreApp.exe": {}
			}
		  },
		  "mscorlib/<IP_ADDRESS>": {},
		  "System/<IP_ADDRESS>": {},
		  "System.Core/<IP_ADDRESS>": {},
		  "Microsoft.CSharp/<IP_ADDRESS>": {}
		}
	  },
	  "libraries": {
		"MvcCoreApp/1.0.0": {
		  "type": "project",
		  "serviceable": false,
		  "sha512": ""
		},
		"mscorlib/<IP_ADDRESS>": {
		  "type": "referenceassembly",
		  "serviceable": false,
		  "sha512": ""
		},
		"System/<IP_ADDRESS>": {
		  "type": "referenceassembly",
		  "serviceable": false,
		  "sha512": ""
		},
		"System.Core/<IP_ADDRESS>": {
		  "type": "referenceassembly",
		  "serviceable": false,
		  "sha512": ""
		},
		"Microsoft.CSharp/<IP_ADDRESS>": {
		  "type": "referenceassembly",
		  "serviceable": false,
		  "sha512": ""
		}
	  }
	}

In case I'm adding  "dependencies": {"Microsoft.AspNetCore.Mvc": "1.1.0-preview1-final" }, I'm getting a long project.lock.json. Analyzing it I've noticed that there are quite a lot "runtime" dependencies. So I suppose that you meant to extract all "runtime" dll's in a list and supply that list to Razor's AdditionalCompilationReferences? But the problem is again with Microsoft.CSharp package:
  "Microsoft.CSharp/4.3.0-preview1-24530-04": {
    "type": "package",
    "frameworkAssemblies": [
      "Microsoft.CSharp"
    ],
    "compile": {
      "ref/net45/_._": {}
    },
    "runtime": {
      "lib/net45/_._": {}
    }
  },

There is no dll specified for this case. Maybe it's because in my case library is available from GAC?

I guess for desktop you might have to additionally look at frameworkAssemblies which is the set of assemblies that come from the GAC. You should be able to Assembly.Load those by name and add it to AdditionalCompilationReferences.

In case I'm adding "dependencies": {"Microsoft.AspNetCore.Mvc": "1.1.0-preview1-final" }, I'm getting a long project.lock.json.

As part of the 1.1.0 milestone, we switched to adding NETStandard.Library to all our projects. (https://github.com/aspnet/WebListener/issues/268 has some discussion about our rationale for this). Consequently you end up with a whole slew of references as a result of referencing Mvc.

@pranavkm  Thank you a lot for looking into this. For me things are getting too complicated now to continue this way.

For Microsoft.AspNetCore.Mvc project I could theoretically gather all the "runtime" and "frameworkAssemblies" assemblies that are indicated in project.lock.json, but what if I'll add some other nuget package later, that add some other dlls transitively? I would be restricted to perform such routine on every package change.
Loading assemblies from GAC using Assembly.Load by name indicated in "frameworkAssemblies" isn't working, because I have to specifify fully qualified name, but I get something like "Microsoft.CSharp". I could use something like this but I'm unsure that it worth it.
Another point of concern is that cshtml files should be compiled with the rest of solution(I want to know at compile time about all possible errors, not on runtime). That is another thing I would have to struggle with.

I was hoping that there is was some "standard way" of dealing with all these problems when using MVC6 in csproj projects, but seems not and such "standard way" is coming with new version of msbuild.
I think we can close this for now.

1 / 2.
3. We released a CLI based tool (https://github.com/aspnet/MvcPrecompilation, https://www.nuget.org/packages?q=Microsoft.AspNetCore.Mvc.Razor.Precompilation) as part of the 1.1.0 preview release. That might help with performing build time compilation.


Update LambdaRank example documentation

Add reference to documentation on the query data format.
Refer readers to the official install instructions.
Change command to use relative path to the lightgbm binary built at
the project's root when following build instructions.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: malcolmgreaves sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


feat(connect-modal): Integrate NFT support into connect modal

This PR introduces the ability to add NFTs to the connect modal in the thirdweb package. By using the supportedNFTs configuration, users can customize which NFTs are shown in the 'View Funds' section within the details modal. This update includes modifications to several TypeScript files to support the new functionality, adjustments in the UI components to handle NFT displays, and updates to hooks and utility functions to fetch and display owned NFTs.

PR-Codex overview
This PR adds support for NFTs in the connect modal and introduces customization options for the NFTs displayed in the "View Funds" screen.
Detailed summary

Added support for NFTs in the connect modal
Customization options for NFTs in the "View Funds" screen
Updated types and components related to NFTs and tokens

The following files were skipped due to too many changes: packages/thirdweb/src/react/web/ui/ConnectWallet/screens/ViewFunds.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/Details.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/ViewNFTs.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

#3585  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gregfromstl and the rest of your teammates on  Graphite

@gregfromstl that's so awesome!
We could add the collection that we use in the playground to test it out?


broken badges

Not quite sure what's up there, they seemed to be working locally.

Oh, looks like it was some sort of cache thing.


redundant "sample.label" processing code

Let's put that into a function rather than repeating it in each model.
if(is.null(sample.label)) {
s = rep(1, ncol(counts))
sample.label = s
} else if(is.factor(sample.label)) {
s = as.integer(sample.label)
} else {
sample.label = as.factor(sample.label)
s = as.integer(sample.label)
}

Very DRY, will do.


Conditional Select Fields

I was looking at the example:
async function selectUsers(withName: boolean) {
  return db
    .select({
      id: users.id,
      ...(withName ? { name: users.name } : {}),
    })
    .from(users);
}

const users = await selectUsers(true);

Is the suggestion to use a ternary operator for each field that you want to make conditional? Is there another way to do this without having to wrap each field with logic?

You can wrap an object with multiple fields into a same condition if you need. Otherwise, there's no other way to do it for now.


Antrea-native policy without a Tier set in it's spec should have "application" tier set

Describe the bug
When an Antrea-native policy is created without a Tier, it is pushed to the default "Application" Tier but the kubectl output shows the field as empty.
To Reproduce
Create ACNP without a Tier in spec.
kubectl get acnp <name> and notice Tier field is empty. Although the ACNP is by default associated to Application Tier.
Expected
Tier field is automatically set to "application" tier
Additional context
Achieve this by setting empty Tier filed to "application" in our mutation webhook.

note.. this bug has no effect on functionality .. more cosmetic


[bug]  cursor

Description
<rh-tile>'s arrow should move on hover like <rh-cta>'s arrow.
Suggested solution

[ ] On hover, move <pf-icon> to the right by 3px. Check that this doesn't change the size of the tile.
[ ] Update hover style in docs.

Example API
No response
Additional context
No response

Reopening this issue because it's separate from #1267