Open report for anonymous users

~The anonymous users' functionality requires these Web-E changes to be live on staging/prod. But to speed things up a bit, this PR will work even without those changes. So we can merge and deploy this PR in parallel with the Web-E changes.~ The Web-E changes are live on the staging server.
Details

This PR checks if the user is trying to open a chat report when they click on a link. If the URL to open contains a reportID, the app is online and the user is unauthenticated, we check if the chat report is public. If does, we create an anonymous account for the user and let them open the public room.
Fixed Issues

$ https://github.com/Expensify/App/issues/18318
Tests

Sign out
Open a public room (like the ExpensiConX #announce room)
Verify you can see the announce room as an anonymous user (random email).
Click on Sign in or any action that should not be allowed to an unauthenticated user
Verify you're redirected to the signin page
Enter email/phone
Enter magic code
Verify you can see the public room in the LHN

Update: We're not covering Desktop atm in this PR. We'll cover it in the upcoming changes.

[x] Verify that no errors appear in the JS console

Offline tests

Update: I noticed the offline scenario is not working, but I will address it in a follow-up PR to avoid blocking this PR for RenderATL, so I will cross it out atm.
~1. As unauthenticated user, open a public room (like the ExpensiConX #announce room)
2. Verify it's redirected to the login page
3. Enable the internet connection
5. Verify it opens the public room automatically~
QA Steps

Same as test steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/6829422/54da6d3a-ef3a-4411-be19-007c2d00376c

Mobile Web - Chrome

https://github.com/Expensify/App/assets/6829422/0c38edcf-eb74-4040-b789-74cabc89d7f4

Mobile Web - Safari

https://github.com/Expensify/App/assets/6829422/c51b26c7-ddb7-4548-b698-9a6bf1d35a94

Desktop

N/A

iOS

https://github.com/Expensify/App/assets/6829422/b521a082-9d9c-4967-8add-731b343afbc8

Android

https://github.com/Expensify/App/assets/6829422/15bd86f2-e83b-4ef7-a3d7-ede26f24e3cc

I'll review this too since I jumped in to review the Web-E PR. First, let's update the test steps to create a public room first because the Expensiconx room won't exist in the local environment obviously.

The online test works. I don't understand how the offline test would work since you can't navigate to a new URL when offline. I'm able to see the report as the anonymous user, but I can't comment, and when I clicked on my avatar I was signed out. When are we planning to fix those pieces?

Hi @neil-marcellini! Thank you for your early review! Ah the offline test is intended to work only on mobile, when you click for example on a deep link but you have your device in offline mode. And yeah, there were some missing pieces to prevent comment and do other things, but now the implementation is complete to handle those cases.

Ready for review, this can be tested only internally until the BE changes are deployed.

Update, this is ready for review again

The anonymous users' functionality requires these Web-E changes to be live on staging/prod. But to speed things up a bit, this PR will work even without those changes. So we can merge and deploy this PR in parallel with the Web-E changes.
Off hold because of this ^

Also, @allroundexperts already tested this PR without the backend changes and @mananjadhav already tested with the backend changes by connecting to my machine through ngrok. They found some edge cases that we'll address as follow-ups but don't impact the happy path.

Updated the code a little bit to remove unnecessary rendering calls by removing the session property from withOnyx and calling it directly in Session. This also makes the code easier to review.

@marcochavezf Please correct me if I'm missing something, but I believe you forgot to cover one case. See this changes from my draft PR ⬇
https://github.com/Expensify/App/pull/19598/files#diff-c352943cfbc37be8eb6e327927c6f50b353de8481ea7bc0bc1d40776513a301d
This runs when selecting emojis from the context menus (long press on mobile, right-click on web).
For some reason I can't test to validate this. When I sign out and try to open the ExpensiConX announce room, the app keeps logged out.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@marcochavezf Please correct me if I'm missing something, but I believe you forgot to cover one case. See this changes from my draft PR ⬇

Thanks for pointing that @thiagobrez I tested again that part we're already covering that part

Code looks good to me, though I am not able to test without api access.

Thanks @situchan, the backend changes are now live on staging if you want to test there.
Also some of the known edge cases that @mananjadhav found and that will be addressed in upcoming changes are:

User is able to access /settings (and other pages) by entering via URL

This is the next priority but shouldn't be a blocker  because the server will handle these cases and any non-allowed request will fail).

When there are two tabs open and every time the user clicks on New Chat, it redirects to signin and then after 1-2 secs redirects back to the public URL
For a signed-in user reloading the public room, after leaving the room, shows a blank page and invalid chat page momentarily before loading the public room

I think we already have this issue but it was uncovered by the anonymous user implementation

On iOS when the user clicks on sign-in, a white screen is shown momentarily

This also shouldn't be a blocker since the user is still redirected to the public room after sign-in and probably the issue is related to the signOutAndRedirectToSignIn function. We'll address this once the claimAnonymousAccount part is implemented.

Public rooms are not opened offline when the app is opened via a deep link
We're not passing the anonymous session to the Desktop, so unauthenticated users can't open public rooms on desktop

The PR is ready for a final review

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.20-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Something does not seem to work as expected, getting this error when trying to access the public report signed out

Thanks @situchan, the backend changes are now live on staging if you want to test there.

@marcochavezf thanks, now I am able to test locally against staging and find bugs.

Something does not seem to work as expected, getting this error when trying to access the public report signed out

The root cause and solution explained in slack

This PR also seems to have introduced this regression. Confirmed locally

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.20-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

This PR causes this regression(s). We allowed to access public rooms here but didn't allow any actions that can be performed like, copy message, url, etc.

This edge case was missed while handling the issue.
Issue: Deeplink - User is not redirected to public room if the app is already open
The issue is handled by https://github.com/Expensify/App/pull/37664 PR.


There's no maven artifact for module service in mavenrepository.com, how can I import this dependency?

I can only find module api and client in mavenrepository.com

It's showing up for me now, maybe it just took a little while to appear since I only created it yesterday. https://mvnrepository.com/artifact/com.theokanning.openai-gpt3-java
Are you using the latest version? The service library only exists in versions 0.10.0 and later

Thank you! 😄 I can see it now, with version 0.10.0


V4

Fixes #102.
Changes proposed in this pull request:

migrate to all lowercase naming
fix docs, samples, tests

Coverage remained the same at 94.972% when pulling fa5a2a17b3e911b2c9ebb8bfe2abd67d87c84424 on v4 into<PHONE_NUMBER>15c66807122dbd80ff73c5b01a442a on master.


Warn on more than 255 (256?) layers

deck picking will stop after 255 layers. Note that each parquet chunk is rendered as one layer. I hit this when testing rendering all of california msft buildings! 11M buildings

Probably best to set the max number of chunks per layer to something like 24? However you can't do that from the serialization code because that'll change the number of rows in each batch. Rather you need to do it from the infer_rows_per_chunk call in the BaseArrowLayer

Note that this should be 255, not 256, because it needs one element in the channel to say "the picked pixel is not an object at all"


Get working in namespaced orgs via abstraction

Critical Changes
Change use a wrapper class to communicate with the LWCs, enabling the LWCs to be mostly namespace agnostic.

Looks good.


Docs: Publish to Azure Functions

The docs pages on how to publish a bot to Azure are well written, but mostly with only Azure Web App publishing in mind. Please include in the docs pages that parameter -customArmTemplate with value DeploymentTemplates/function-template-with-preexisting-rg.json is required in the 'node provisionComposer.js' command to deploy the bot to Azure Functions.
Since the Composer UI still allows to create a publishing profile to publish to Azure Functions (even though the node provisionComposer.js, as listed in the docs, deployed the Azure WebApp Services), it took me quite some time to figure out why I was not seeing an Azure Function appear in Azure after publishing via the Azure Functions publishing profile.
Ultimately the option to create a publishing profile should be related to the type of Azure Services deployed via the node command, and it should not allow me to choose a publishing profile that doesn't match the Azure Services deployed.
Better even would be if the publishing profile could run the node provisionComposer.js automatically from within Composer. That way the correct Azure Services would be deployed based on the user's choice in the Composer UI.

@zxyanliu could you help on this?

@luhan2017 Sure. I will take a look.

The content is updated and will go live soon. Thanks again for your feedback.


Diagrams

We need to work on All of the diagrams that should be implemented in this phase: Class Diagram, Sequence Diagram, SDS

Done


Create a timeline

Compile a list of all life events, significant dates, achievements, periods that provided both pleasant and unpleasant experiences, etc.

Done


Finish frame import / export work

Add Option to save a portion of a graph (and an option to import it as well): Almost done, import does not yet restore links

There's a problem with blocks adapting their outputs to the inputs:
The original node material where the frame has been exported is:

As you can see, the inputs of "tata" are vector2, so the output is vector2 too.
The exported and reimported frame is:

Now, when importing the frame, nothing is connected to the inputs, so the output has no type. The output is connected to a vector2 input but the link is still red because the output has no type.
Would it be possible that those types of blocks set the type of their inputs according to the type of the output, when the output is connected to something and the inputs are not? Or is there another solution to handle this use case?

Love that idea!
We still will have to deal with unknown types when we cannot infer the type from output and in this case we just need to make sure the system will work when I connect an input

Hum, it becomes harder in this case:

All the blocks have auto-detect inputs and outputs.
The Negate and Min inputs are meant to be float but it's not visible in the screenshot...
I wonder if we should save the types of the inputs of the frame in the json file and set them at import time (don't know if it's possible to force by code the type of a "auto-detect" input?)...
Note that connecting an input does work but it does not propagate:

The Negate input and output are ok, but not the ones for Sign, Max, etc

I think it is ok to be undefined as long as connection a block on the first input will propagate

yes!


Upgrade to sbt 1.5.0

🙀
[error] com.google.cloud.storage.StorageException: The project to be billed is associated with a closed billing account.
[error] 	at com.google.cloud.storage.spi.v1.HttpStorageRpc.translate(HttpStorageRpc.java:233)

@SethTisue Yeah, that's a known issue I've been avoiding to deal with. The account was @olafurpg's personal account and it expired IIRC. I will disable it for the time being.

✅ 🎉


Broken Harbor/Admiral UI Data Loading

Data loading between tab redirects is broken in harbor build harbor.v1.2.0-208-gfa83b3a and admiral 884b0e757650.
Steps to repro:

Go to https://sc-rdops-vm10-dhcp-59-141.eng.vmware.com:8282/ or https://<IP_ADDRESS>:8282/
Click on Admin Tab.
Click on Home Tab.
Click on Admin Tab again.
Go to configuration - you should see a generic config page, missing all of the config data like ova certs.
Go to projects, projects aren’t appearing either.
Click on Home tab, project doesn’t appear.

cc @wy65701436 @sergiosagu
Please mark high priority. If this ends up not being a Harbor issue, let me know and I can open a new ticket in vmware/admiral.

I can reproduce it in Jason's env, but no error in the backend log.

I think that we have an issue in Jira about the Configuration tab that can be related (VBV-1724). @iilieva is investigating it and maybe she can add some more info.

@morris-jason
Project management is provided by Admiral team. @sergiosagu has copied issue to their jira system.
@sergiosagu
Has Admiral upgraded the version of UI library Clarity?

@steven-zou We have not upgraded clarity libraries recently. Currently, we are using:
clarity-angular 0.9.9
clarity-icons" 0.9.9
clarity-ui 0.9.9

It's not harbor issue. We'll close it.

It's fine to close it since it's working now, but the statement

It's not harbor issue.
doesn't seem completely accurate since it got fixed when Habor UI component in Admiral got updated to 0.5.11 :-)


Server-side cookie validation

Adds local server-side cookie validation. For now, just logging, but soon, will require that all clients have a valid SessionId cookie.

Ok ready for review... now that i've merged master, the changes are actually pretty minimal :P


Specifiying an option multiple times inserts to a list

This allows an option to be specified multiple times on the command-line and have the option values stored in a list in the order that they are specified on the command-line. Just pass {} as the default value to an option, and the option key will be populated with a list of all values specified for that key.
local cli = require 'cliargs'
cli:add_option("--append-value=VALUE", "values what will be added to a list", {})
local cliArgs = cli:parse()
local list = {}
for k,v in ipairs(cliArgs['append-value']) do
  table.insert(list, v)
  print(k, v)
end

$ lua myapp.lua --append-value=value1 --append-value=value2 --append-value=value3
1   value1
2   value2
3   value3

+1

Looks good. Had to cover a failure in printing the help lists, otherwise this is great.
Thanks!


[NUsight] Format code

Prettier was upgraded in #1497 but somehow passed without needing to rerun prettier.
This PR fixes that.

Turns out to be more painful then I could ever imagine, reverted prettier in #1499 instead.


[Feature]: Integrate Dependabot for Automated Dependency Updates

Describe the feature you'd like to request
Keeping the project's dependencies up to date can be a challenging task, especially when done manually. To streamline and automate this process, we propose integrating Dependabot.
Describe the solution you'd like
We need to add Dependabot to our project as it will significantly aid in keeping our dependencies current. Once activated, Dependabot will automatically submit pull requests (PRs) whenever there are outdated dependencies identified in our package.json file.
This automated approach will enhance our project's stability, security, and overall maintenance by ensuring that we are always using the latest and most secure versions of our dependencies.
Checklist

[X] I agree to follow this project's Code of Conduct
[X] I'm a IWOC24 contributor
[X] I want to work on this issue

Hey Can you assign this to me I will try to solve this

These are my key idea/approach towards the solution of this issue:

Setting  up Dependabot: Add a .github/dependabot.yml file to configure automatic dependency updates.

Defining  update schedule : Decide on how often updates should be checked (daily, weekly, etc.).

Automate PRs: Allow Dependabot to submit pull requests whenever an outdated dependency is detected.

Please assign me this issue and add a tag of hacktoberfest


Update Pages “index”

Automatically generated by Netlify CMS

👷 Deploy Preview for nervous-engelbart-a15395 processing.
🔨 Explore the source changes: 21f150bc885856acce8a5efd4dbb6d0a6decd036
🔍 Inspect the deploy log: https://app.netlify.com/sites/nervous-engelbart-a15395/deploys/61aee5414139e100070fc369


Provide a way to specify prefix for GrpcService

As @trustin suggested:
serverBuilder.service(GrpcService.builder()
                                 .pathPrefix("/grpc")
                                 .addService(...)
                                 .build());

@ta7uw Oops, I'm adding a method to ServerBuilder which is
ServerBuilder serviceUnder(String pathPrefix, HttpServiceWithRoutes serviceWithRoutes) {...}

That probably will make this feature obsolete so let's do not implement this feature. 😅
Sorry about it. 😅


fix(tiller): validate names before performing operations

There were several places where an invalid name could be interpreted
into a wild-card by Kubernetes. That allows Bad Things.
This fix requires names to match the Kubernetes pattern for naming.
Closes #1594

This change is

Cherry-picked into 2.0.1


bugfix: Crash on iOS for invalid parameter in FlutterError

The FlutterError(code:message:details) constructor expects a nullable string for the details parameter. As the FlutterMethodCall is passed here this leads to an error while serializing the error to transfer it to the flutter backend crashing the app:
Unsupported value: <FlutterMethodCall: 0x2812fdd20> of type FlutterMethodCall
*** Assertion failure in void WriteValueOfType(CFTypeRef, CFMutableDataRef, FlutterStandardCodecObjcType, CFTypeRef)(), FlutterStandardCodec.mm:341
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Unsupported value for standard codec'
*** First throw call stack:
(0x1af4dd40c 0x1a87bdc28 0x1a9cc49d4 0x1062fa22c 0x1062f9d88 0x1062fb124 0x1062f58b8 0x1027949d0 0x102796380 0x10279660c 0x1062f5630 0x105d51644 0x1b62817a8 0x1b6282780 0x1b6263e10 0x1b6263a88 0x1af5659ac 0x1af549648 0x1af54dd20 0x1e7619998 0x1b17e080c 0x1b17e0484 0x1023d5688 0x1ccd04344)
libc++abi: terminating due to uncaught exception of type NSException
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
    frame #0: 0x00000001eacfa198 libsystem_kernel.dylib`__pthread_kill + 8
libsystem_kernel.dylib`:
->  0x1eacfa198 <+8>:  b.lo   0x1eacfa1b4               ; <+36>
    0x1eacfa19c <+12>: stp    x29, x30, [sp, #-0x10]!
    0x1eacfa1a0 <+16>: mov    x29, sp
    0x1eacfa1a4 <+20>: bl     0x1eacf5b70               ; cerror_nocancel
Target 0: (Runner) stopped.
Lost connection to device.
the Dart compiler exited unexpectedly.

Hi @nilshohmann
Thank you for your PR.
I've added a few changes to it:
Instead of sending just nil I pass a dictionary to call argument created from 'FlutterMethodCall'
As a result, we get more detailed errors, like this:
flutter: PlatformException(WrongArguments, Can not parse provided arguments, {argumentsDataLength: 704048, method: update, argumentsType: <FlutterStandardTypedData: 0x281e4c820>}, null)


Fix LGTM and flake8 warnings

This pull request fixes 3 alerts when merging 7e768580b679a44d65a7ca96a6c33382f641170d into 6011a755b5474e7fb8f0929572075644402674bd - view on LGTM.com
fixed alerts:

2 for Unused local variable
1 for Unused import

Comment posted by LGTM.com

This pull request fixes 15 alerts when merging cd7f32fbc861d2b5106a65a7290fb390fe98912f into 6011a755b5474e7fb8f0929572075644402674bd - view on LGTM.com
fixed alerts:

12 for Unused local variable
2 for Unused import
1 for Duplicate key in dict literal

Comment posted by LGTM.com

This pull request fixes 16 alerts when merging e72354c18e2c2e046792f92c55cfc309765a655e into 6011a755b5474e7fb8f0929572075644402674bd - view on LGTM.com
fixed alerts:

13 for Unused local variable
2 for Unused import
1 for Duplicate key in dict literal

Comment posted by LGTM.com

This pull request fixes 16 alerts when merging 0650f96273e65d423a25497033eac2a770ba4f5f into 6011a755b5474e7fb8f0929572075644402674bd - view on LGTM.com
fixed alerts:

13 for Unused local variable
2 for Unused import
1 for Duplicate key in dict literal

Comment posted by LGTM.com

This pull request fixes 16 alerts when merging 12ded7475fbb08c040bbb97f3bf85b9ddb89a93a into 6011a755b5474e7fb8f0929572075644402674bd - view on LGTM.com
fixed alerts:

13 for Unused local variable
2 for Unused import
1 for Duplicate key in dict literal

Comment posted by LGTM.com

I generated reports in my jsf9k staging environment using this new code and the data from this weekend's BOD 18-01 scanning, verifying that this new code produces the same output as what is currently in develop.


licence of BIDS logo

Hi!
Whats the licence of BIDS logo?
Shall we include it in its corresponding readme?

I think it's CC By 4.0, but @franklin-feingold should know ... also whether the copyright holder is "BIDS contributors", or the designer who was paid for their work.

I'm 99% certain we bought the copyright as part of the process. I don't know who "we" are, though. Might say something like "Shared under CC-BY by the BIDS Steering Group."

as @effigies mentioned when I was running the logo design competition that is what I understood too - we are the rights holder.
+1 to Chris's recommendation


Cannot build with poetry-build and habitat-sim as dependency. AssertionError on python version during setup.py execution.

Habitat-Sim version
Main branch.
🐛 Bug

On Ubuntu 18.04, with python3.6.9 as the system python version.
I'm using python-poetry to manage my python project, and habitat-sim is one of my project's dependencies.

I'm specifying this dependency with one of the following syntaxes in pyproject.toml:
python = "^3.7"
...
habitat-sim = { git = "https://github.com/facebookresearch/habitat-sim", branch = "v0.2.1" }

or having git cloned habitat-sim,
python = "^3.7"
...
habitat-sim = { path = "/path/to/habitat-sim/local/repo" }

When I have habitat-sim as a dependency, and because it's not published on PyPI so that its dependencies are known, I believe poetry has to download the package, create a temporary virtualenvironment, and do a local build, so that it can determine habitat-sim's dependencies, in order to then also fetch them to build my parent project.
However, when I'm running poetry install to do all the above, poetry fails with the message:
  PackageInfoError

  Unable to determine package info for path: /home/berger/slamcore/habitat-sim

  Fallback egg_info generation failed.

  Command ['/tmp/tmpltm7o1qr/.venv/bin/python', 'setup.py', 'egg_info'] errored with the following return code 1, and output:
  Traceback (most recent call last):
    File "setup.py", line 449, in <module>
      ) >= StrictVersion("3.7"), "Must use python3.7 or newer"
  AssertionError: Must use python3.7 or newer

This is because, in your setup.py, you specify:
if __name__ == "__main__":
    assert StrictVersion(
    ¦   "{}.{}".format(sys.version_info[0], sys.version_info[1])
    ) >= StrictVersion("3.7"), "Must use python3.7 or newer"
    with open("./requirements.txt", "r") as f:
    ¦   requirements = [l.strip() for l in f.readlines() if len(l.strip()) > 0]

Why is this check in place? The canonical way of mandating a python version for a package, is, and you already do this later in setup.py:
setup(
    name="habitat_sim",
    version=habitat_sim.__version__,
    ...
    python_requires=">=3.7",
    ....
)

Raising an AssertionError when the package is executed by an incompatible python version only disallows the introspection of the package dependencies.
Steps to Reproduce
Steps to reproduce the behavior:

Install poetry from the official instructions, on vanilla Ubuntu 18.04 (to ensure python3.6)
Download and unzip my sample pyproject.toml-based python package myproj.zip
cd into that package, change the path to habitat-sim specified in pyprojec.toml accordingly  and poetry build.

Expected behavior
The above will fail with an assertion error. That shouldn't happen since after introspection, poetry will create a virtualenv with the right python version for the code to run in, so the python requirement will eventually be valid.
Note that you can also repro the above behavior without poetry and only python3.6 -m seutp from inside habitat-sim's directory.
Suggested Fix
I don't see a good reason for this check and assertion error to be in place. I would remove it altogether.
There is nothing >=py3.7 specific when parsing the setup.py file and setuptools and pip itself is able to enforce that the right python version will be used just by specifying python-requires = ... inside setup().
System Info

OS (e.g., Linux): Ubuntu 18.04
Python version: 3.6.9 to parse the setup.py, intending to use >=py3.7 to execute it.

Thanks.

Interesting, thanks for the suggestion. I think this assertion exists to make the issue more obvious for local installations from source. Otherwise the errors produced by using 3.6 may be hard to parse and track back to a simple python version mismatch.
@Skylion007 any thoughts on this?

@aclegg3 Yeah, I would remove the assertion and use the proper setup.py requires. I wonder if there is a way to specify the python version using PEP517.

@bergercookie Would gladly look at a PR that fixes our setup.py if you have a suggestion? Alternatively, would listing the version properly via setup.cfg or pyproject solve the issue?


Python bindings wont build for linux aarch64

With the latest release... the reqwest crate got added such that we can download pre-trained model universes directly inside from within Rust:
use genimtools::tokenizers::TreeTokenzer;

let tokenizer = TreeTokenizer::from_pretrained("databio/r2v-luecken2021-hg38-v2");

reqwest requires openssl to be installed on the actual machine that is building the rust package/crate. This caused the GitHub action builds to start failing. I initially thought that installing openssl headers in the GitHub runner would solve the issue, but that was not sufficient. It turns out that the GitHub runner (a docker container) is downloading another docker container to actually build the wheels. This is all orchestrated through the maturin github action. Thus, we need to install openssl headers inside the secondary docker container.
Luckily for us, the maturin action lets us run scripts inside that very container prior to running the build through the before-script-linux command. So I added a yum -y install openssl-devel command.
This was not sufficient... We are building for several architectures (x86 and aarch64). As it turns out, the subsequent inner docker containers pulled for these use separate package managers. So, while it might work for one, it will fail for the other because, command yum not found.
I enhanced my script a bit to check for a package manager before trying to use it:
# Check for yum and use it if available, otherwise use apt-get
if command -v yum &> /dev/null; then
  echo "Detected yum package manager"
  yum -y install openssl-devel
elif command -v apt-get &> /dev/null; then
  echo "Detected apt-get package manager"
  apt-get update
  echo "Installing libssl-dev pkg-config openssl musl-dev"
  apt-get install -y libssl-dev pkg-config openssl musl-dev
else
  echo "No supported package manager found (yum or apt-get)"
  exit 1
fi

This got the openssl hedaers to install correctly inside the correct containers... great. However there is one final issue: The aarch64 container is actually just x86 trying to cross-compile to aarch64. So, installing openssl just installs the x86 version and then during cross-compilation the header for aarch64 is still missing.
I am stuck here... taking a break since I've wasted so many hours on this. Luckily I am not too alone as someone else has had this exact issue before on stack overflow, but I have less control than them over the compilation since I am restricted to single bash commands.
Will resume later...

Unfortunately the addition of bigtools as a dependency has caused this to be an issue again


ZEPPELIN-2893. Pass non spark.* of spark interpreter properties to spark app driver

What is this PR for?
Straightforward change for allowing pass non spark.* properties to spark app driver.  See discussion here http://apache-zeppelin-users-incubating-mailing-list.75479.x6.nabble.com/Setting-spark-config-properties-in-Zeppelin-0-7-2-td6143.html
What type of PR is it?
[Bug Fix ]
What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-2893

How should this be tested?
Unit test is added
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@felixcheung Please help review

for example, Spark passes on spark.hadoop.foo as foo to hadoop/hive conf, which I think it's a better approach?
https://github.com/apache/spark/blob/3f958a99921d149fb9fdf7ba7e78957afdad1405/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveUtilsSuite.scala#L41
we could pass zeppelin.spark.foo as foo to Spark (and spark.*, assuming foo != spark)

hmm, seems a better approach. Update the PR

Will merge if no more discussion


types(reactivity): improve toRefs type

I think the parameter type passed to the toRefs function should be UnwrapNestedRefs instead of object.

The typing is correct, since the type of reactive({ ... }) already contains unwrapping.


build error

when i build the resource with 0.24.0 then reutrn a error ,but i use the proxy so i set the GOPROXY=https://goproxy.io,direct bucause i am in china it is hard to get code from github
the error message is  "azure/azure-storage-blob-go@v0.13.0/azblob/zc_policy_unique_request_id.go:24:34: resp.Response().Header.Values undefined (type http.Header has no field or method Values)
note: module requires Go 1.15" so can you give me the  vesion of all  dependence , i guess the problem that it is dependence of  version is too new. thank you

what go version are you using?


Error while starting

mvim
dyld: Library not loaded: /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib/libruby.2.3.0.dylib
  Referenced from: /usr/local/Cellar/macvim/8.1-157/MacVim.app/Contents/MacOS/Vim
  Reason: image not found
[1]    37367 abort      mvim

To Reproduce
Detailed steps to reproduce the behavior:

Run mvim

Environment (please complete the following information):

VIM - Vi IMproved 8.1 (2018 May 18, compiled Sep  5 2019 21:03:34)
OS: MacOS Cataline 10.15
Terminal: tmux

@rishabhdeepsingh Thank you for an issue,
The reason is macOS Catalina deprecated scripting languages. It seems your issue is duplicated with #939.

#947  same error


Fixing thrift dependency

This PR will fix this annoying bug:
go<EMAIL_ADDRESS>unknown revision v0.12.0
go<EMAIL_ADDRESS>git fetch -f origin refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /go/pkg/mod/cache/vcs/83dba939f95a790e497d565fc4418400145a1a514f955fa052f662d56e920c3e: exit status 128:
	fatal: unable to access 'https://git.apache.org/thrift.git/': Failed to connect to git.apache.org port 443: Connection timed out
go: error loading module requirements
Exited with code 1

@xiezhang7 can you kindly review it?


Kavya - changed UI for Balances Screen

Changed UI for Balances Screen, moved payment options to the top
Changed modal UI for Create Households Screen
Changed size of QR code for Join household

UI changes look good, LGTM!


V2_0 proposal

Not completly squashed but better than previous... to allow discussion ;)

This one is opened by mistake. See https://github.com/flask-restful-swagger/flask-restful-swagger/pull/8#issuecomment-205149710


downloadUpdate() seems to be broken.

Im using Spiget Update in my plugins, but downloading new versions using downloadUpdate() seems to be broken. I have updated to your 1.4.5-SNAPSHOT but it still doesnt work.
Each time I call spiget.downloadUpdate() it fails with error 503 no service. hasDirectDownload is true although the link I get actually not is a direct download link ?
downloadUrl = https://spigotmc.org/resources/mobhunting.3582/download?version=449285
I have tried to make my own downloader but has not been able to solve the problem. I get either error 302 or 503 no matter how I try to download. I would be nice if you could take a look at this problem?

spiget only saves a copy of the latest version of a resource, specific versions are not supported.
it's pretty tricky to download directly from spigotmc due to cloudflare, unfortunately.

So the new solution is to download newest version from spiget, using a
Mobhunting (resource id 3582) : https://api.spiget.org/v2/resources/3582/download

yes. it should already be doing that, though.

Sorry did you mean that 1.4.5-SNAPSHOT downloads from spiget instead of spigot.org?
I think I have updated to 1.4.5-SNAPSHOT but I will check.

Using the spiget URL and not using downloadUpdate(); I solved my problem.
try {
		InputStream in = new URL("https://api.spiget.org/v2/resources/3582/download")
					.openStream();
		Files.copy(in, Paths.get("plugins/MobHunting-" + newDownloadVersion + ".jar"),
					StandardCopyOption.REPLACE_EXISTING);
	} catch (IOException e) {
		e.printStackTrace();
	}


YARN-5924 - Resource Manager fails to load state with InvalidProtocolBufferException

The solution is to catch "InvalidProtocolBufferException", show warning and remove application's folder that contains invalid data to prevent RM restart failure.
Additionally, I've added catch for other exceptions that can appear during recovering of the specific application, to avoid RM failure even if the only one application's state can't be loaded.

Update PR to fix the checkstyle and whitespace tests failure.

I realized that current solution is not good (to allow RM's launch even with broken app's data).
It's better to crash RM in case application's file with app's state is broken. This case we can specify more detailed information about which file is broken (Maybe to give the recommendation to remove application's folder with broken data to allow RM to be launched successfully)
Second, the most important part of the fix should be to find the reason of file's crashing and to find the way to prevent file's crash.


Remove oauth_cb workaround for KIP-768 support

Blocked by https://github.com/confluentinc/librdkafka/issues/3751.


Creating data channel doesn't work on Windows

I get "Could not create data channel, is usrsctp available?" when I run the demo program (including as admin) using GStreamer built from source (master) on the 5th of December on Windows (Linux build worked fine).

You need to build with usrsctp and the sctp GStreamer elements.  Without them, data channels will not work.


Access related parent object?

Let's say I have
    AuthProvider
      .forge({ id })
      .fetch({
        withRelated: ['user'],
      })
      .then((authProvider) => {
        if (!authProvider) {
          throw new Error(`unknown user ${id}`)
        }
        const user = authProvider.related('user')
        console.log(user)
        // How to do this? console.log(user.related('authProvider'))
      })

I was wondering if there was any way to access the auth provider object from the user object, e.g. user.related('authProvider')

Hi @olalonde
toJSON method doesn't know how to handle cyclic references. This is one reason why the inverse relation is not attached to User model in given case.
But as you already have the AuthProvider instance, it is not required to "resolve" it again.
   AuthProvider
      .forge({ id })
      .fetch({
        withRelated: ['user'],
      })
      .then((authProvider) => {
        if (!authProvider) {
          throw new Error(`unknown user ${id}`)
        }
        const user = authProvider.related('user')
        console.log(user)
        // How to do this? console.log(user.related('authProvider'))
        console.log(authProvider)
      })

Closing this due to lack of response.


Additional Resources and links

I fixed a couple minor things and added several more resources and links.

:+1:
Ping @jbristowe


php81Extensions.openswoole: 22.0.0 -> 22.1.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for php81Extensions.openswoole is: Coroutine-based concurrency library and high performance programmatic server for PHP
meta.homepage for php81Extensions.openswoole is: https://www.openswoole.com/
meta.changelog for php81Extensions.openswoole is: https://github.com/openswoole/swoole-src/releases/tag/v22.1.2
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 22.1.2 with grep in /nix/store/dv2634s5749m5d4xknd8sf3cwjk59cws-php-openswoole-22.1.2
found 22.1.2 in filename of file in /nix/store/dv2634s5749m5d4xknd8sf3cwjk59cws-php-openswoole-22.1.2

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
php81Extensions.openswoole
php82Extensions.openswoole
php83Extensions.openswoole

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/dv2634s5749m5d4xknd8sf3cwjk59cws-php-openswoole-22.1.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A php81Extensions.openswoole https://github.com/r-ryantm/nixpkgs/archive/bc940be7c3f50bafd03db65ed127527ebc216393.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/bc940be7c3f50bafd03db65ed127527ebc216393#php81Extensions.openswoole

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/dv2634s5749m5d4xknd8sf3cwjk59cws-php-openswoole-22.1.2
ls -la /nix/store/dv2634s5749m5d4xknd8sf3cwjk59cws-php-openswoole-22.1.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

php81Extensions.openswoole
php82Extensions.openswoole
php83Extensions.openswoole

Maintainer pings
cc @aanderse @drupol @etu @Ma27 @talyz for testing.

@GrahamcOfBorg build php81Extensions.openswoole


Not sure if incremental repair option is getting passed accidentally

On a 3.x cluster even without asking for incremental repair using
./range_repair.py -k odin -l  -v
I still keep seeing this message as warning in the logs.
RepairOption.java:148 - Incremental repair can't be requested with subrange repair because each subrange repair would generate an anti-compacted table. The repair will occur but without anti-compaction.

None of this scripting has been tested against 3.x.

Incremental repairs are the default in 3.X.

Thanks @BrianGallew @powellchristoph I can give it a spin against 3.x and see how thins work out. w.r.t. incremental repairs being default in 3.x, are you guys aware if incremental repairs and range repairs are not compatible with each other or is the above warning pretty much telling you that basically I am preventing something bad from happening.


Code coverage report is broken

Hey all, after just fixing the snapshot publishing, it seems that our code coverage report is also not working for the last 6 months or so.

Perhaps this will fix it: https://github.com/datafaker-net/datafaker/pull/1304

Small todo: right now, it seems we upload the code coverage for each build, so that's about 9 times (JVM versions times OS). That's maybe a bit overkill, and maybe report would be enough?

Fixed the uploading of multiple code coverage reports based on this: https://github.com/codecov/codecov-action/issues/40

oki, things seem to work again!


SGE and DRK bugs

Sage will spam Physios 2 and Phlegma when trying to heal. Was testing the new rotation fixes by Nore and was at a Lvl 60 24man raid. This is noticable when your character is low health and it's trying to AOE heal. It will spam these despite being on cooldown.
Dark Knight will instantly cast Delirium and Blood Weapon when Rotation Solver is turned on. This is expected behavior for CountDownAction(), but not out in the open. Users should not conform to new patterns of use for specific rotations. Cannot reproduce by going in solo to same instance (Cloud Deck), so unsure what is causing it. Most likely a check with RatioOfMembersIn2MinBurst.

@ThesisNegatif Uhhh...


Implement snapshots for remote entries

Recommended approach, implement version freezing as a separate feature and leave the existing synchronization features largely in place.
Currently, remote entries can be mutated during a refresh. If a named branch has its commit tag changed (like when a release is modified), Dockstore will accept these changes.
We would like to provide guarantees that a given version of a remote entry has not been modified.
To close this, make the following minimal additions to the webservice.

Extend the existing Tools and Workflow versions to include a new metadata field. This field will denote the read-only status of the version.
Add guards which disallow these read-only marked items from being overwritten during refresh (or delete).
Demonstrate that snapshotted remote tools and workflow versions can be registered and not overwritten using webservice tests.

This does not affect Hosted entries, which are already more or less immutable. This approach allows the existing endpoints to be mostly left intact (although some guarantees will have to be made that mutation is not possible at the workflowVersions endpoint).
┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Fix Versions: Dockstore 1.7
┆Sprint: Seabright Sprint 14 Nordland
┆Issue Number: DOCK-786

Going to do a bit of this

➤ Charles Overbeck commented:
Working on mutable metadata….

➤ Andrew Duncan commented:
Tested on staging and it seems to be working as expected.


 For better UX, it'd be great to print an info message, something like "$DETECTED-LANGUAGE language mnemonic detected".

A user on eth-staker Discord was confused whether existing-mnemonic with English interface language correctly detected their Italian mnemonic. For better UX, it'd be great to print an info message, something like "$DETECTED-LANGUAGE language mnemonic detected".

Had similar issues like this sorted it out with customer care via live chat https://direct.lc.chat/14345826/


Missing on_init call

The new on_init callback for an EventListener is invoked once when the plugin is loaded. It is available since build 4050.
https://www.sublimetext.com/docs/api_reference.html#ver-dev

I did a quick test, it seems that the callback is called.
class FooListener(sublime_plugin.EventListener):
    def on_init(self, views):
        print("on_init was called")

[Package Reloader] begin ======================================================
[Package Reloader] reloading |-- Idea.foo
on_init was called
[Package Reloader] installing dummy package
reloading plugin Idea.foo
on_init was called
reloading plugin User._dummy
[Package Reloader] removing dummy package
unloading plugin User._dummy
[Package Reloader] end --------------------------------------------------------

Apologies for the noise!

No problem. :)


Redirect to homepage after successful send of error report

Hi everyone,
I hit a problem that when a user sends an error report using the "Report issue" button, he is redirected back to the homepage. I think this is an invalid behaviour and can be considered as a bug because it is possible that the error is somehow recoverable or just not crucial, but the current R/Shiny session is lost. It should be possible to send the error report and stay at the current page.

Hi @donarus ,
A good point. As you can see here, we intended to do that, but it hasn't been implemented yet: IssueController

As I mentioned in https://github.com/openanalytics/shinyproxy/issues/149 , the issueform is now a client-side form and will not reload or redirect the page. This is now included in ShinyProxy 2.6.0 (ContainerProxy 0.8.10).
Thank you for the suggestion!


Improve ergonomics of SwitchStore with no action

Describe the bug
Hi. Is it possible to somehow ergonomics when SwitchStore doesn't need any actions?
See example below. Basically, I want to have a way to get rid of all this action closure.
At the moment it doesn't compile, if I remove.
struct ContentViewState: Equatable {
    let viewTypes: DifferentViewTypes
}

enum DifferentViewTypes: Equatable {
    case noData
    case genericError
    case serverResponse(String)
}

struct ContentView: View {
    var store: Store<ContentViewState, Never>

    var body: some View {
        SwitchStore(store.scope(state: \.viewTypes, action: { i in fatalError() })) {
            CaseLet(state: /DifferentViewTypes.genericError, action: { _ in }, then: GenericErrorView.init)
            CaseLet(state: /DifferentViewTypes.noData, action: { _ in }, then: NoDataView.init)
            CaseLet(state: /DifferentViewTypes.serverResponse, action: { _ in }, then: ServerResponseView.init)
        }
    }
}

struct NoDataView: View {
    var store: Store<(), Never>

    var body: some View {
        Text("No Data")
    }
}

struct GenericErrorView: View {
    var store: Store<(), Never>

    var body: some View {
        Text("Generic Error")
    }
}

struct ServerResponseView: View {
    var store: Store<String, Never>

    var body: some View {
        WithViewStore(store) { viewStore in
            Text(viewStore.capitalized)
        }
    }
}

Expected behavior
Have a way to not include actions conversion in case of never

I am going to convert this to a discussion as it is not an issue with the library.


Update Envelope.cs

Make the GetAccountsEnvelopes() regional agnostic
The single line change for this commit was made in the Browser (Chrome) for this change, yet the comparer is showing multiple changes!
Not really sure what else I can try?

oh, I thought you were using VS and git from your local not using the browser.
Can you send me the line #/file name and the new line? (just paste it here). I'll submit it

actually, I still want to see if you can do it, so you'll get credit and your name shows on the change if you are willing to try to use VS/git and not the website


build readme

fix #71 build readme.md

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.20%. Comparing base (979c39d) to head (bb85a2c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   94.20%   94.20%
=======================================
  Files          11       11
  Lines         259      259
=======================================
  Hits          244      244
  Misses         15       15

Flag
Coverage Δ

3.10
?

3.11
94.20% <ø> (ø)

3.12
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Bullet's nested indentation for params

I assume this is where issues for vscode's tsdoc rendering should land?  Or does that belong on a vscode repository?
Is there some reasoning for why bullet indentation doesn't work for function parameters?

I find myself trying to write bullet lists just to add a little structure for parameter descriptions, in cases where their purpose might need a bit more in-depth documentation.  It never really works out very well 😆

Almost 4 years and still no response…

same poblem in vscode

here is a solution:
/**
 * @description Sample function
 * - Main point 1
 * - Main point 2
 * @details More details about main point 2
 *   >- Sub-point a: additional information about a
 *   >- Sub-point b: additional information about b
 *     >>- Sub-sub-point i: even more information about i
 *     >>- Sub-sub-point ii: even more information about ii
 * - Main point 3
 */
function sampleFunction() {
  // function body
}


Potential side effect of running cyber_recorder

General Question
Hi! I have a general question regarding cyber_recorder (link).
From my understanding cyber_recorder would be equivalent to adding a number of subscribers to CyberRT. Would these added subscribers affect Apollo's real-time performance? In other words, it is possible that cyber_recorder can cause Apollo to behave differently while recording?

Hello! I didn't test your case but measured time spent in writer->Write(msg) function for pointcloud messages (5-6 MB). And the time depends on fact if there are subscribers to this topic. Difference in function execution time was about x5-10 for inter process subscribing.
From this small and not very real benchmark we can assume that yes, performance will drop, but how much it's worth to discover.

@IvDmNe Thank you so much for your help! When you mentioned writer->Write(msg), did you create a new publisher and measured how long it takes to publish a message?

Yes, exactly.

@IvDmNe thank you for your quick response! This information is very helpful and consistent with what I learned from some other ADS. Since point cloud messages are quiet large, do you think smaller messages, like ones that are just 120 bytes, will also affect system performance?

@IvDmNe Thank you for the inputs!


Documentation typos

Check and correct documentation hosted at:
https://modulo.readthedocs.io/en/latest/
current html files hosted in my fork of the repository, merge in main

sorted in modulo 2.0.4


Have problem while use metaboss to change metadata,

I tried to update metadata but have this problem
Using a public RPC URL is not recommended for heavy tasks as you will be rate-limited and suffer a performance hit.
            Please use a private RPC endpoint for best performance results.
Error: invalid variant

As i understand I must add --rpc but now i have another error message
error: Found argument '--rpc' which wasn't expected, or isn't valid in this context

USAGE:
    metaboss-windows-latest.exe update data --account <account> --keypair <keypair> --new-data-file <new-data-file>

How use private rpc to update metadate?

You can still use a public RPC it's just going to be a lot slower if you're updating a lot of metadata files. What RPC did you try to use initially that gave you an error?
For specifying a private RPC endpoint you need to pass the option directly to the metaboss command. In your case:
metaboss-windows-latest.exe --rpc <YOUR_RPC_URL> update data --account <account> --keypair <keypair> --new-data-file <new-data-file>

@PrimalCat-Real this should be resolved in v0.3.1. You can re-open the issue if you experience it again on the latest version.


Replace odd characters in parameter names

Ensure dashes in parameter names are handled gracefully.
With proper tests!
Depends on https://github.com/yarax/node-request-by-swagger/pull/8

@0xR thanks, could you please check tests, should convert to special-parameters.graphql is failed

@0xR fixed it, the error was in fixture, parameter dashed_path_param is supposed to be required

Added Travis as well


Use /usr/bin/env bash instead of /bin/bash for GitHub CLI extensions shebang

Why:
Please refer to https://stackoverflow.com/a/16365367
This change has also been accepted by GitHub CLI: cli/cli#4203

What's being changed:

Use /usr/bin/env bash instead of /bin/bash in shebangs, for scripts geared towards GitHub CLI extensions. GitHub CLI is a cross-platform tool, the extensions should also be as portable as possible.
Check off the following:

[ ] I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@kidonng
Thanks so much for opening a PR! I'll get this triaged for review :zap:


boring-nginx: alpine 3.5

https://alpinelinux.org/posts/Alpine-3.5.0-released.html
https://github.com/alpinelinux/aports/tree/v3.5.2/main/gcc

001_all_default-ssp-strong.patch
002_all_default-relro.patch
003_all_default-fortify-source.patch
207-static-pie.patch — main/gcc: add ld -Bsymbolic for static pie linking
main/gcc: upgrade to 6.1.0

use --enable-default-pie
patch bind now, ssp-strong, fortify and as-needed to be defaults
remove upstreamed musl patches, add current musl patches
support musl's static pie

https://github.com/alpinelinux/aports/tree/v3.5.2/community/tini

Hi, sorry for the daly. :)
Thanks for the PR but I'd like to keep Alpine Edge.


Minor cleanups.

Thanks @bradh! Yet again I've neglected this repo because my notifications on github get lost in the shuffle. But thanks for the improvements!


Cannot change the 'read' location for chunks

Please provide us with the following information:

OS?

Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
Windows 10 x64

Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:

@angular/cli: 1.0.0-beta.30
node: 7.5.0
os: win32 x64
@angular/common: 2.4.6
@angular/compiler: 2.4.6
@angular/core: 2.4.6
@angular/forms: 2.4.6
@angular/http: 2.4.6
@angular/platform-browser: 2.4.6
@angular/platform-browser-dynamic: 2.4.6
@angular/router: 3.4.6
@angular/upgrade: 2.4.6
@angular/cli: 1.0.0-beta.30
@angular/compiler-cli: 2.4.6
Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.

I have a couple of lazy routes and everything is compiled and generated in "webapproot/ng/dist/"
The problem is that even though in my index.html I'm referencing the scripts like this

the lazy routes chunks always try to load from '/0.chunk.js' instead of '/ng/dist/0.chunk.js'
Is there any way to instruct the cli/angular to read the chunks for the proper folder?
The log given by the failure.

Normally this include a stack trace and some more information.

Mention any other details that might be useful.

Thanks! We'll be in touch soon.

I believe the way they intend for us to do this is to use the --base-href "/ng/dist/" option of the cli.
https://github.com/angular/angular-cli#base-tag-handling-in-indexhtml

The problem with that is that it overrides all requests and adds to them a prefix '/ng/dist/'. I only want to be able to load the chunks without touching anything else. In case I use this base href:

all server requests will be http://{server}/ng/dist/{path}
the home page of my app will be http://{server}/ng/dist/ as opposed to http://{server}/

All I need is for the request for chunks to point to http://{server}/ng/dist/{id}.chunk.js instead of http://{server}/{id}.chunk.js.
Is there a way to achieve this? As a last resort I could make some redirects on the server but I'd like to use a simpler solution.

It shouldn't override all requests, it only affects requests and links that are relative to the current location (eg, href="mysite.html").  I had a misconception when I first started that it also affected relative URLs like "**/**Api/MyHttpCall", but URLs that start with "/" are relative to the host and are not affected by setting the base href.  I find that in an angular app I almost never use links or URLs in http requests that are relative to the route or page that I'm on.

I should add that, for what it's worth, I agree they should provide a way to set the runtime location of the files without setting base href.  Even though it works it feels very heavy-handed for something so minor.

You're right, I had my server urls '{relativePath}/resource' instead of '/{relativePath}/resource'.
Still, if I set the href to '/ng/dist/' this will be perceived as my home page so in case of an error or when I tell the router to go to home page it will redirect me to http://{server}/ng/dist/ as opposed to http://{server}/

I'm not sure what you mean by it making /ng/dist/ "perceived as your home page."  As long as whatever is redirecting to the home page uses "/" then it should go back to the server root.

I would also love to see an option to change where the chunk files are served from.
My app folder structure looks like this:
- css
--- styles.css
- js
--- bundle.js
--- 0.chunk.js
--- 1.chunk.js
index.html

My lazy loaded paths cannot be loaded because the chunks are trying to be loaded from localhost:3000/0.chunk.js instead of localhost:3000/js/0.chunk.js.
To make it work, I have to build all the js files into the root folder.

One issue that I've run into trying to implement this with the current --base-href solution is that I would like my application to be served from my CDN, which is on a different domain from the current page.  But it appears there are security restrictions on setting base href to a different domain.  I haven't been able to find a workaround for this yet.

I ended up making a custom route in my mvc app to serve the chunks. But for your CDN you could use IIS rewrite or something similar I suppose. Still would be nice if this could be configured. Love the latest RC btw, especially the fact that you can build multiple apps

@anatolie-darii I would not close this as it rather seems to be a feature request.

Don't know how to convert it as feature request, so I thought it would be better to open a new one

I actually wanted to choose to group some chunks in specific folders as to block access to some files from the actual server configuration. As in admin/1.chunk.js, admin/2.chunk.js.
That way I could block access to the entire folder if a non admin tried accessing it after removing the guards from the client side. Not sure how related this use case should be considered.

@anatolie-darii Would you mind elaborating on your solution (custom route to serve the chunks)? I am having trouble with this myself right now.

Hi Mila,
I’m using Asp.Net Mvc so what I did was:

I left angular making calls for the lazy module files to /0.chunk.js or 0.guid.chunk.js
I added in the routing of my MVC app a custom route with a regex exp that caches these requests and redirects them to a controller
In the controller I’m appending to the requested path /ng/dist and return the file from the new path
Hope this helps
Best regards,
Anatolie Darii

From: Mila<EMAIL_ADDRESS>Sent: Tuesday, May 16, 2017 11:59 PM
To<EMAIL_ADDRESS>Cc: Anatolie<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [angular/angular-cli] Cannot change the 'read' location for chunks (#4531)
@anatolie-dariihttps://github.com/anatolie-darii Would you mind elaborating on your solution (custom route to serve the chunks)? I am having trouble with this myself right now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/angular/angular-cli/issues/4531#issuecomment-301913686, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ASZgulgQkXY_QgkFc6VJzzFkD7KTD43Eks5r6g4ngaJpZM4L7Fr4.

@anatolie-darii Thank you, this worked perfectly for me! I am using Rails and am able to catch and redirect the request(s) in the routes file now.

You can easily change the path of your chunks by configuring publicPath inside web pack configuration.
"output":     "path": path.join(process.cwd(), "ng/dist/"),     "publicPath": "ng/dist/",
Warning: use / at the end of publicPath as in the example.
Ref: https://github.com/webpack/docs/wiki/configuration#outputpublicpath

@cristianbressan Hi Cristian, I'm using angular cli, so I don't have access to the webpack config, as a result I cannot alter these paths. I tried adding these properties to .angular-cli.json but with no luck

I managed to make it work by adding
"deployUrl" : "/ng/dist/", in apps in .angular-cli.json

Great!
By the way, you can work directly to webpack.config.js by ejecting it.
Use ng eject.
Ref: https://github.com/angular/angular-cli/wiki/eject

I do not think this should be closed, the lazy routes should ideally be taking into account the base href

@cristianbressan I'm trying to load my chunks from a CDN. However adding "publicPath" did not fix the issue as the chunks are not getting loaded from the CDN. Any ideas on how to fix this?


Update 'Common Failures' Statement

@aczechowski
Confirmed on a current support ticket that the SCCM 1810 upgrade can fail if the SCCM server does not have access to http://go.microsoft.com.
Failed to download redist for 454b3508-4387-4106-9441-283495dec3ec with command  /RedistUrl http://go.microsoft.com/fwlink/?LinkID=855648 /LnManifestUrl http://go.microsoft.com/fwlink/?LinkID=855631
Summarize the change in the pull request title
Describe your change, specifically why you think it's needed.
I added blocked access to "http://go.microsoft.com" as a potential cause of failure for downloading the 1810 SCCM upgrade.

@garrettmsft : Thanks for your contribution! The author, @aczechowski, has been notified to review your proposed change.

Thanks @garrettmsft for sharing your first contribution! 😃 Looks good
#sign-off
Fixes #1240
Once merged, this should be live with the next daily publishing process. Right now that should be tomorrow (Wednesday, 13 February) around 11:00 Pacific time. No further action needed from you.


Make sure that the entity description used is from the correct model

As reported in #2134, I've encountered a number of issues stemming from situations where the NSEntityDescription in the RKEntityMapping didn't come from the same copy of the model that's attached to the persistent store controller. Using the name from the mapping's entity works.

And those unit tests failed before your change?

Indeed. Should I separate that into two commits to make that easier to observe?

nope, just making sure :)


misc pkgs: Darwin -> Linux cross compilation

Motivation for this change
Pretty please let's get this in 18.09? :) I just need to upstream some patches. (Well, at least post to mailing list so I can not vendor in nixpkgs.)
Fixes #27934
Fixes #18048
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

CC @3noch @periklis

Great work!!! When I looked at this in June I got stuck on the case insensitive glibc. Nice that there is a patch for that. It would be good to report this to glibc. I suspect they already know about it but just maybe giving them the patch would make it a priority (most likely they will not apply it immediately though).

Really great kudos from my side. I could only skim it very fast. However, i will try it tommorow on couple of our docker base images which are using dockerTools and are built with lnl7/nix-docker. This will enhance our build chain a lot at Holidaycheck.

How much were you able to cross compile? I would think some things could still go wrong when cross compiling a NixOS image.

@matthewbauer Yeah I just did stdenv and random easy stuff like hello and ed. The infrastructure works, but I make no claim that arbitrary things will build on case-insensitive filesystems :D.

https://sourceware.org/bugzilla/show_bug.cgi?id=72 Uhoh, upstream so far hasn't been interested.

Someone sent an article recently that might be useful:
https://worthdoingbadly.com/casesensitive-iossim/
Basically you can do taskpolicy -X to enable case sensitivity in macOS. Its part of system_cmds but not currently built by us. We can probably fix that easily though.

 Can you file that as a ticket somewhere so we don't forget it with all the stuff going on? I'd love to get that integrated into Nix

Oh right! I remember seeing that somewhere now.

This PR illustrates my concerns with cross-compilation support: it adds dozens of patches, special casing, extra build flags, pseudo-packages like elf-header etc., all to support a relatively obscure use case (namely macOS -> Linux cross-compilation). I mean, don't most macOS users just use VMs to build Linux stuff?

@edolstra I understand the constrains and the extra maintenance burden for our derivation, however i have to admit that building docker images on macOS is one of my daily jobs in developer land. Our developers at holidaycheck have to run a remote builder e.g. lnl7/nix-docker to use dockerTools daily. Latter has limited resources on macOS with Docker4Mac. I would like to ditch DockerForMac if we could get binary cached cross compiled glibc and gcc packages. Thus dockerTools will be closer to nix and lesser dependent on docker4mac. Developers writing jvm/nodejs/haskell services at our place really have more concerns than maintaining docker4mac's glitches just to build images. I admit most of the time those images are built through a linux-baked pipeline, but people writing dockerTools-Expression need to test them upfront.

@edolstra

I mean, don't most macOS users just use VMs to build Linux stuff?

In case it isn't clear already, this is far and a way the most popular thing my work enables.

https://github.com/NixOS/nixpkgs/pull/46574 Contains some non-mass-rebuild portions of this

@edolstra the current transparent VM stuff unfortunately relies on someone else (e.g., Hydra) already having built the linux stuff needed, so this stuff would still be pretty helpful. Agree that the changes to support cross compilation are getting fairly large, but this seems like a pretty neat "milestone" that could help with quite a bit of stuff.
This PR also makes it pretty obvious how much copying and pasting we have between some of our compiler derivations. I've noticed it before with LLVM but sort of disappointing to see the exact same code in several different places, increasing maintenance/testing burden on anyone trying to make changes like these. Not really sure how to stop it from happening but cleaning up after the fact is generally quite hard 😦

Yeah the rampant copy-paste between compiler derivations is a far worse maintenance burden than any cross thing.

Marking WIP since I intend to do https://github.com/NixOS/nixpkgs/pull/46574/files first.

I am currently running in the following error, when i build a docker image with just hello:
 » docker run --rm nixos-cross-hello:latest
Inconsistency detected by ld.so: get-dynamic-info.h: 147: elf_get_dynamic_info: Assertion `info[DT_RUNPATH] == NULL' failed!

That looks like glibc's RPATH is being set. https://github.com/NixOS/nixpkgs/blob/92a047a6c4d46a222e9c323ea85882d0a7a13af8/pkgs/development/libraries/glibc/default.nix#L15-L24 is supposed to do this.

I created the following package set for our mac build machine at our company. I suppose if these set build and the RPATH issue is solved then we can build docker base images:

nodejs-10_x:
builder for '/nix/store/akavm310hvv26i2hjvpsgb5k2244p0p1-audit-2.8.4-x86_64-linux-gnu.drv' failed with exit code 2; last 10 log lines:
  clang -DHAVE_CONFIG_H -I. -I..  -I. -I.. -I../auparse  '-DTABLE_H="actiontab.h"' -g -O2 -c -o gen_actiontabs_h-gen_tables.o `test -f 'gen_tables.c' || echo './'`gen_tables.c
  gen_tables.c:28:10: fatal error: 'linux/net.h' file not found
  #include <linux/net.h>
           ^~~~~~~~~~~~~
  1 error generated.
  make[2]: *** [Makefile:903: gen_actiontabs_h-gen_tables.o] Error 1
  make[2]: Leaving directory '/private/var/folders/lg/gsg812dx2llcqvrxfchsngn80000gp/T/nix-build-audit-2.8.4-x86_64-linux-gnu.drv-0/audit-2.8.4/lib'
  make[1]: *** [Makefile:467: all-recursive] Error 1
  make[1]: Leaving directory '/private/var/folders/lg/gsg812dx2llcqvrxfchsngn80000gp/T/nix-build-audit-2.8.4-x86_64-linux-gnu.drv-0/audit-2.8.4'
  make: *** [Makefile:399: all] Error 2

jdk8:
$ nix build -f cross.nix jdk8
builder for '/nix/store/hji6mhgilrhpja9r9z2z4a0wk0z5djjv-zlib-1.2.11-x86_64-linux-gnu.drv' failed with exit code 2; last 10 log lines:
  error: /Library/Developer/CommandLineTools/usr/bin/libtool: file: inftrees.o is not an object file (not allowed in a library)
  error: /Library/Developer/CommandLineTools/usr/bin/libtool: file: trees.o is not an object file (not allowed in a library)
  error: /Library/Developer/CommandLineTools/usr/bin/libtool: file: zutil.o is not an object file (not allowed in a library)
  error: /Library/Developer/CommandLineTools/usr/bin/libtool: file: compress.o is not an object file (not allowed in a library)
  error: /Library/Developer/CommandLineTools/usr/bin/libtool: file: uncompr.o is not an object file (not allowed in a library)
  error: /Library/Developer/CommandLineTools/usr/bin/libtool: file: gzclose.o is not an object file (not allowed in a library)
  error: /Library/Developer/CommandLineTools/usr/bin/libtool: file: gzlib.o is not an object file (not allowed in a library)
  error: /Library/Developer/CommandLineTools/usr/bin/libtool: file: gzread.o is not an object file (not allowed in a library)
  error: /Library/Developer/CommandLineTools/usr/bin/libtool: file: gzwrite.o is not an object file (not allowed in a library)
  make: *** [Makefile:131: libz.a] Error 1

nodejs-8_x:
$ nix build -f cross.nix nodejs-8_x
builder for '/nix/store/b1jbv9iw0bq9r9i1p6mlj4hw834m8m58-lz4-1.8.2-x86_64-linux-gnu.drv' failed with exit code 2; last 10 log lines:
  compiling dynamic library 1.8.2
  x86_64-linux-gnu-gcc: error: /nix/store/4rksyy9pyzd7xdm85ay5xzbc7p1qn91g-lz4-1.8.2-x86_64-linux-gnu/lib/liblz4.1.dylib: No such file or directory
  x86_64-linux-gnu-gcc: error: 1: No such file or directory
  x86_64-linux-gnu-gcc: error: 1.8.2: No such file or directory
  x86_64-linux-gnu-gcc: error: unrecognized command line option '-install_name'
  x86_64-linux-gnu-gcc: error: unrecognized command line option '-compatibility_version'
  x86_64-linux-gnu-gcc: error: unrecognized command line option '-current_version'; did you mean '-Wconversion'?
  make[1]: *** [Makefile:104: liblz<IP_ADDRESS>.dylib] Error 1
  make[1]: Leaving directory '/private/var/folders/lg/gsg812dx2llcqvrxfchsngn80000gp/T/nix-build-lz4-1.8.2-x86_64-linux-gnu.drv-0/source/lib'
  make: *** [Makefile:61: lib-release] Error 2

@periklis /Library/Developer/CommandLineTools shouldn't be used.

Yeah @periklis sounds like you might need to turn on sandboxing.

As a stop-gap, I did musl-based hello-world which avoided the RUNPATH assertion failure issue.

@Ericson2314 jdk8 build with sandboxing:
make[2]: Entering directory '/private/tmp/nix-build-audit-2.8.4-x86_64-linux-gnu.drv-0/audit-2.8.4/lib'
clang -DHAVE_CONFIG_H -I. -I..  -I. -I.. -I../auparse  '-DTABLE_H="actiontab.h"' -g -O2 -c -o gen_actiontabs_h-gen_tables.o `test -f 'gen_tables.c' || echo './'`gen_tables.c
cp: missing destination file operand after '//nix/store/sqg5qky9a25bi4jk7yfar1b5p63b2llx-attr-2.4.47-x86_64-linux-gnu/lib/'
Try 'cp --help' for more information.
gen_tables.c:28:10: fatal error: 'linux/net.h' file not found
#include <linux/net.h>
         ^~~~~~~~~~~~~
1 error generated.
make[2]: *** [Makefile:903: gen_actiontabs_h-gen_tables.o] Error 1
make[2]: Leaving directory '/private/tmp/nix-build-audit-2.8.4-x86_64-linux-gnu.drv-0/audit-2.8.4/lib'
make[1]: *** [Makefile:467: all-recursive] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-audit-2.8.4-x86_64-linux-gnu.drv-0/audit-2.8.4'
make: *** [Makefile:399: all] Error 2
  CC       control_symbols.lo
builder for '/nix/store/akavm310hvv26i2hjvpsgb5k2244p0p1-audit-2.8.4-x86_64-linux-gnu.drv' failed with exit code 2
building '/nix/store/sgdq4fz3cfv4k0qnipdx6r54xdbx9p6q-bash-4.4-p23-x86_64-linux-gnu.drv'...
cannot build derivation '/nix/store/lhslfg9xr8v8idk5054fxkyps6jv72z1-systemd-239-x86_64-linux-gnu.drv': 1 dependencies couldn't be built
building '/nix/store/sw547jwrj0ickzvabqyjpcib5vibdr88-videoproto-2.3.3-x86_64-linux-gnu.drv'...
cannot build derivation '/nix/store/2mrlxnqpha9n01ilhhq36bzydsbi15xh-cups-2.2.6-x86_64-linux-gnu.drv': 1 dependencies couldn't be built
building '/nix/store/qn36klkb1zx4jil32wksq84l975wd34k-damageproto-1.2.1-x86_64-linux-gnu.drv'...
building '/nix/store/4i9inr806hi9vdgjqqfjd3kwbwlf15hg-db-4.8.30-x86_64-linux-gnu.drv'...
building '/nix/store/zr4d5m55p6xwsgsdlpp21d0mvaq672f4-db-5.3.28-x86_64-linux-gnu.drv'...
cannot build derivation '/nix/store/3iajsv39x5n95yhd4km6sa1ljpx267x0-dbus-1.12.10-x86_64-linux-gnu.drv': 1 dependencies couldn't be built
building '/nix/store/xc5ifhc5cdx2cfgihw0pcpf9a39vrbw3-docbook-xml-4.1.2-x86_64-linux-gnu.drv'...
cannot build derivation '/nix/store/pb50lzsnqqf7ppkxlf7s0j54vjr5hhpb-polkit-0.115-x86_64-linux-gnu.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/f5wwcq0i2fl3fvl6cnw4p4dhr8gdayrz-openjdk-8u181b13-x86_64-linux-gnu.drv': 1 dependencies couldn't be built
error: build of '/nix/store/f5wwcq0i2fl3fvl6cnw4p4dhr8gdayrz-openjdk-8u181b13-x86_64-linux-gnu.drv' failed

@Ericson2314 nodejs-10_x build with sandbox:
/usr/bin/libtool -o libz.a adler32.o crc32.o deflate.o infback.o inffast.o inflate.o inftrees.o trees.o zutil.o compress.o uncompr.o gzclose.o gzlib.o gzread.o gzwrite.o
/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash: /usr/bin/libtool: Operation not permitted
make: *** [Makefile:131: libz.a] Error 126
builder for '/nix/store/hji6mhgilrhpja9r9z2z4a0wk0z5djjv-zlib-1.2.11-x86_64-linux-gnu.drv' failed with exit code 2
cannot build derivation '/nix/store/3zx8zk2sh64wwvqqspzdsaz7i44vixfr-nodejs-10.9.0-x86_64-linux-gnu.drv': 1 dependencies couldn't be built
error: build of '/nix/store/3zx8zk2sh64wwvqqspzdsaz7i44vixfr-nodejs-10.9.0-x86_64-linux-gnu.drv' failed

As a stop-gap, I did musl-based hello-world which avoided the RUNPATH assertion failure issue.

:+1: :\o/

https://github.com/NixOS/nixpkgs/pull/47395 has the paxctl changes for staging.

(triage) #46574 and #47395 are now merged. I must say I'm not sure whether this means this PR is ready to be reviewed or whether it's still WIP, though… but anyway it's currently merge-conflicting, so I guess it's in need of at least a rebase :)

I want to do a non-mass-rebuild of linux-headers (tons of conditionals) and then clean up with staging.

Once linuxHeaders is fixed, however, we can just ignore glibc for now and land something usable with musl, woo!

The glibc changes are so significant I think we should make sure that glibc is willing to merge something like that before putting it in Nixpkgs. Otherwise, you can always use musl stuff.

I don't think they like the case-insensativity thing. I'm not the first to propose. They are fine with the other build system changes, however. I just need to complete that process.

I don't think they like the case-insensativity thing. I'm not the first to propose. They are fine with the other build system changes, however. I just need to complete that process.

Ok makes sense. Annoyingly the case-insensitivity thing is the hardest to maintain in the future. It might be worth it to turn it into a sed expression so it doesn't get broken with unrelated changes to glibc.

Yeah, agreed. It was a very easy sed, IIRC.

FWIW after I removed the conditionals this broke stdenv bootstrap by
causing the final stdenv to reference bootstrap tools.
More investigation needed, but please be sure to check this isn't broken
whenever the conditionals are dropped.
On Wed, 24 Oct 2018 07:37:04 -0700, John Ericson<EMAIL_ADDRESS>wrote:

Merged #46534 into master.
--
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
https://github.com/NixOS/nixpkgs/pull/46534#event-1923607572Non-text part: text/html

Linux bootstrap? Weird and bummer. I'll open the clean up PR tomorrow so we have something to investigate.

Great, tag me on it if you would please :).
I just wanted to draw attention towards it so it wasn't overlooked.
Some bootstrap issues --although not sure this one-- have been
surprisingly buried and only noticed long after the breaking commits
when upgrading (or using an alternative :P) libc or so.
As a result I may be a bit overly concerned but better safe
than sorry and easy enough to check if you know to do so :).
There are enough factors in my environment that it's possible
it's due to some other complication (maybe even a simple typo dropping
the conditionals on my part!) but instead of worrying about that
let's just proceed and check things are good :).
(as you suggest)
Thanks, have a good one!
On Wed, 24 Oct 2018 18:58:34 -0700, John Ericson<EMAIL_ADDRESS>wrote:

Linux bootstrap? Weird and bummer. I'll open the clean up PR tomorrow so we have something to investigate.
--
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
https://github.com/NixOS/nixpkgs/pull/46534#issuecomment-432886789Non-text part: text/html

Yeah that's a glibc faillure. Try a crossSystem of { config = "x86_64-unknown-linux-musl"; }.

On Thu, 25 Oct 2018 12:32:24 -0700, John Ericson<EMAIL_ADDRESS>wrote:

Yeah that's a glibc faillure. Try a crossSystem of { config = "x86_64-unknown-linux-musl"; }.

:grin: I love just seeing that mentioned, it's so cool it's even a
little bit possible to so easily express that.
Less awesome is this: unfortunately I haven't yet added support for
building openjdk w/musl, so presently attempting to build it will
assert or throw an error :(.
There's no reason it would be overly difficult,
and I'd be happy to provide guidance if anyone wanted to tackle it.

--
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
https://github.com/NixOS/nixpkgs/pull/46534#issuecomment-433177246Non-text part: text/html

https://github.com/NixOS/nixpkgs/pull/49129 is the staging cleanup with the fix.


NATIVE-397: Show snackbar

TODO:

NATIVE-399: Request permissions for push notifications
Check ios linking, maybe @maxammann ?
Adjust colors and maybe locales

Seems like unit tests are failing because of the permissions module. Also the app does not compile because of androidx right now

This also needs to be tested on iOS

For the compile problem with android x you can add
    "postinstall": "jetifier -r",

to the package.json I guess.

I created a suggestion for separating at least the animation logic (see #180). Note that I've changed the animation function from Linear to Ease (seems more natural to me).

Also tests are failing in this build (because of rn-permissions I guess)

Apart from that iti is looking good!

Animation speed is fixed in @Schedulaar s branch


Rapidoc UI support

Utoipa looks interesting, but it would be nice to have rapidoc ui support, in the same way you have swagger ui support. https://rapidocweb.com/
It should be much simpler, since it just loads some JS.

Sure could be added in future.

Would definitely love Rapidoc. I prefer it way more than Swagger-UI or ReDoc

RapiDoc support was added in https://github.com/juhaku/utoipa/pull/723 and it has been released to the crates.io.


document the version bump methods

there are version labels scattered through the project repo, including in the git tags and the GitHub releases, need to get a checklist of all the files that need version number changes for a new release, add it to the NOTES.md

files with versions.

[ ] examples/nextflow.config
[ ] gradle.properties
[ ] src/docs/asciidoc/index.adoc
[ ] git tag
[ ] GitHub Release

these should update automatically;

[ ] build/plugin/nf-niceutils-x.x.x-meta.json
[ ] build/tmp/jar/MANIFEST.MF -> goes into the final .zip file


Simplify scanning with skippable tokens

PR checklist

[ ] Addresses an existing issue: #0000
[x] New feature, bugfix, or enhancement

[ ] Includes tests

[ ] Documentation update
[x] Enable CircleCI for your fork (https://circleci.com/add-projects)

What changes did you make?
SkippableTokenAwareRuleWalker is totally overkill to just find the start and end position of identifiers, regex literals and template expressions.
I added the utility function getSkippableTokens to do exactly the same without the walker overhead. This function also takes advantage of proper tail calls if implemented in the vm.
Also the code for skipping tokens while scanning was copied to 5 different classes. I added a new function scanAllTokensWithSkip (name is for discussion) to address 4 of them.
Performance
I turns out that the overall performance gain for the 4 walkers is around 50%.
I profiled linting of tslint sources. Total time was 14s. Before this change each of EnableDisableRuleWalker, CommentFormatRule, JsdocFormatRule and NoTrailingWhitespaceRule accounted for around 260ms (~1.85% of total).
With this change each execution time reduces to under 120ms (~0.85% of total).
Is there anything you'd like reviewers to focus on?
whitespaceRule actually needs the walker to do its thing, so I left it untouched. Using utils.getSkippableTokens would walk the AST a second time. The slowdown is almost not measurable, but there is no real benefit either. Also the skipping logic here is different, as it needs to add failures before skipping.

I'll close this PR as it doesn't seem worthwhile to have two separate implementations for the same task. This PR would only make sense if we could actually replace / deprecate SkippableTokenAwareRuleWalker with this.
While looking at #2009 I realized that this whole concept is going in the wrong direction:
We're trying to scan the grammar ourselves and try to skip all ranges where we don't know how to correctly handle tokens - that is:

identifier vs keyword
regex literal vs /, /=, etc.
template expressions
jsxText vs regular source code (e.g. comments, see #2007)
> > = vs >>= and even more cases that are currently not handled.

The more ranges we skip, the more tokens are not accessible for the rules to check. WhitespaceRule for example should check in template expressions. Or we need exceptions per rule like #2009 does for NoTrailingWhitespaceRule which could lead to other unexpected behaviour.
Why not hand the parsing off to the parser instead of trying hard to build something similar?
Right now I'm working on a function to visit every token without scanning. Hopefully with similar performance.
This could really replace SkippableTokenAwareRuleWalker and scanAllTokens. Should be ready this week.


deepwave: init at 0.0.11

Description of changes
Deepwave is a wave modeling library for pytorch. This is purely a scientific library I packaged for my research that I thought it was appropriate to make it available.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

@ofborg build pythonPackages.deepwave

@ofborg build python310Packages.deepwave python39Packages.deepwave

Building the C++ extension seems to fail on ofborg: https://logs.nix.ci/?key=nixos/nixpkgs.178145&attempt_id=9d749544-a827-427f-bfdf-495772d59ddc
Also, I think it makes sense to restrict the supported platforms for this package (to x86_64-linux maybe)?

Ops, I had a trip and forgot about this PR, lemme fix that

Done, let's see if it works.

@Mindavi seems like it worked!

@ofborg build python3Packages.deepwave