Cannot add_plugin aws_s3

New Release Candidate Issue Checklist

[x] Updated fastlane to the latest release candidate version (2.150.0.rcX)
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Information

Breaking version: 2.150.3
Last working version: [e.g. 2.x.x]
State of app: [e.g. Prepare for Submission, Developer Rejected]
First version of app?: [e.g. Yes]

Issue Description
Cannot add_plugin aws_s3
bundle exec fastlane add_plugin aws_s3
Complete output when running fastlane, including the stack trace and command used
Installing plugin dependencies...
Bundler could not find compatible versions for gem "rubyzip":
  In snapshot (Gemfile.lock):
    rubyzip (= 2.3.0)

  In Gemfile:
    fastlane-plugin-aws_s3 was resolved to 1.8.0, which depends on
      apktools (~> 0.7) was resolved to 0.7.1, which depends on
        rubyzip (~> 1.1)

    fastlane (= 2.150.3) was resolved to 2.150.3, which depends on
      rubyzip (>= 2.0.0, < 3.0.0)

Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.

✅ fastlane environment ✅
Stack

Key
Value

OS
10.15.5

Ruby
2.6.3

Bundler?
false

Git
git version 2.21.1 (Apple Git-122.3)

Installation Source
/usr/local/bin/fastlane

Host
Mac OS X 10.15.5 (19F101)

Ruby Lib Dir
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib

OpenSSL Version
LibreSSL 2.8.3

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
11.3.1

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL

LANGUAGE

fastlane gems

Gem
Version
Update-Status

fastlane
2.150.3
✅ Up-To-Date

Loaded fastlane plugins:

Plugin
Version
Update-Status

fastlane-plugin-badge
1.4.0
✅ Up-To-Date

fastlane-plugin-aws_s3
undefined
💥 Check failed

Loaded gems

Gem
Version

did_you_mean
1.3.0

slack-notifier
2.3.2

rouge
2.0.7

xcpretty
0.3.0

terminal-notifier
2.0.0

terminal-table
1.8.0

plist
3.5.0

multipart-post
2.0.0

word_wrap
1.0.0

colored
1.2

highline
1.7.10

commander-fastlane
4.4.6

unf
0.1.4

domain_name
0.5.20190701

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

gh_inspector
1.1.3

multi_xml
0.6.0

rubyzip
2.3.0

security
0.1.3

xcpretty-travis-formatter
1.0.0

bundler
2.1.4

jwt
2.1.0

uber
0.1.0

declarative-option
0.1.0

representable
3.0.4

retriable
3.1.2

mini_mime
1.0.2

httpclient
2.8.3

google-api-client
0.38.0

nanaimo
0.2.6

colored2
3.1.2

claide
1.0.3

CFPropertyList
3.0.2

atomos
0.1.3

xcodeproj
1.17.0

unicode-display_width
1.7.0

public_suffix
4.0.5

addressable
2.7.0

tty-screen
0.8.0

tty-cursor
0.7.1

tty-spinner
0.9.3

babosa
1.0.3

excon
0.75.0

faraday
1.0.1

unf_ext
<IP_ADDRESS>

faraday_middleware
1.0.0

fastimage
2.1.7

json
2.3.1

mini_magick
4.10.1

dotenv
2.7.5

naturally
2.2.0

simctl
1.6.8

declarative
0.0.20

multi_json
1.14.1

signet
0.14.0

os
1.1.0

memoist
0.16.2

googleauth
0.13.0

rake
13.0.1

digest-crc
0.6.1

google-cloud-errors
1.0.1

google-cloud-env
1.3.2

google-cloud-core
1.5.0

google-cloud-storage
1.26.2

emoji_regex
3.0.0

aws-eventstream
1.1.0

aws-sigv4
1.2.1

aws-partitions
1.338.0

jmespath
1.4.0

aws-sdk-core
3.103.0

aws-sdk-kms
1.36.0

aws-sdk-s3
1.73.0

forwardable
1.2.0

logger
1.3.0

stringio
0.0.2

ipaddr
1.2.2

openssl
2.1.2

ostruct
0.1.0

strscan
1.0.0

date
2.0.0

fileutils
1.1.0

etc
1.0.1

io-console
0.4.7

zlib
1.0.0

libxml-ruby
3.1.0

rexml
3.2.4

psych
3.1.0

mutex_m
0.1.0

webrick
1.4.2

curb
0.9.10

badge
0.12.0

fastlane-plugin-badge
1.4.0

generated on: 2020-07-06

Spaceship Logs

[INSERT OUTPUT HERE]

Environment

[INSERT OUTPUT HERE]

Mentioning

cc: @joshdholtz

@ducnnguyen Looks like we are currently waiting on https://github.com/devunwired/apktools/pull/26 (by @giginet) to be merged in 😊
You should be able to add 👇 to your Gemfile to fix this:
gem "apktools", git: "https://github.com/giginet/apktools.git", branch: "ruby-zip2"

Run bundle update and you should be good 🤞

I implemented the fix that @joshdholtz suggested and was able to build and upload an iOS app.

@ducnnguyen Looks like we are currently waiting on devunwired/apktools#26 (by @giginet) to be merged in 😊
You should be able to add 👇 to your Gemfile to fix this:
gem "apktools", git: "https://github.com/giginet/apktools.git", branch: "ruby-zip2"

Run bundle update and you should be good 🤞

Thank you @joshdholtz. With your suggestion, now i can submit app to AppStore or upload ipa file to s3 successfully.

It appears that the dependencies were updated in apktools as requested in this commit: https://github.com/devunwired/apktools/commit/ad53af91ec625d66f5b353c7c18d8034df33bc2e
Included in https://github.com/devunwired/apktools/releases/tag/0.7.4


PermissionError: [Errno 13] Permission denied: './outputs/website-logs'

Running the project with Docker on Windows
Running docker commands in WSL2 Ubuntu:
docker-compose up -d --build
sudo docker exec -it --workdir=/app/collector anything-llm python main.py

When using collector main.py with
Article or Blog Link(s) > URL Crawler
I got:
PermissionError: [Errno 13] Permission denied: './outputs/website-logs'
I tried to do
echo "$(id -u):$(id -g)"
in the Ubuntu terminal, and it reports 1000:1000
From the Readme:
About UID and GID in the ENV

The UID and GID are set to 1000 by default. This is the default user in the Docker container and on most host operating systems. If there is a mismatch between your host user UID and GID and what is set in the .env file, you may experience permission issues.

But they are matching.

Same issue for me.  Fixed by running chmod -R 777 outputs in the /collector folder.   Not sure if this is best practice but it worked 🤷


Need a clean way to reload current scene

Right now just reloading the current scene is a real bear, something that beginners will want to do very early on. Since there's already a Scene class maybe Core or Scene could have a 'restart' function?

Good call! I'll figure something out!


[BloombergLP] Support template in a subfolder of a repo

Bloomberg LP contribution.
Allows to specify a subfolder in the repo in which to search for the template.
Usage
At Bloomberg we find it convenient to keep the templates in one repo (like templates belonging to the same team, or grouped by any other criteria), i.e.:
.
|-- cookiecutter-pipproject
|   |-- README.md
|   |-- cookiecutter.json
|   |-- tasks.py
|   `-- {{cookiecutter.app_name}}
`-- cookiecutter-python-app
    |-- LICENSE
    |-- README.rst
    |-- cookiecutter.json
    |-- requirements.txt
    |-- tests
    `-- {{cookiecutter.project_slug}}

Unfortunately, cookiecutter doesn't allow you to have such a configuration easily.
This patch makes it possible with `cookiecutter' using the following syntax:
cookiecutter --subfolder cookiecutter-python-app <YOU REPO>

where <YOU REPO> is the git repo where the templates are and cookiecutter-python-app is the name of the template inside the repo (as in the example above) to be used for generating the code.
I hope all the guidelines have been followed, but please feel free to point me out to any problem with the PR!
Many thanks

Codecov Report

Merging #1063 into master will decrease coverage by 0.25%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1063      +/-   ##
==========================================
- Coverage     100%   99.74%   -0.26%
==========================================
  Files          18       18
  Lines         781      785       +4
==========================================
+ Hits          781      783       +2
- Misses          0        2       +2

Impacted Files
Coverage Δ

cookiecutter/main.py
100% <ø> (ø)
:arrow_up:

cookiecutter/repository.py
100% <100%> (ø)
:arrow_up:

cookiecutter/cli.py
100% <100%> (ø)
:arrow_up:

cookiecutter/utils.py
96% <0%> (-4%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0730981...eb49642. Read the comment docs.

First off, thanks for this pull request. However, is there any reason why this can't be placed in a tool that employs the internal Cookiecutter API?

FWIW I was just looking for this feature (just to avoid repo profileration). Having it as a flag in the main cookiecutter binary would aid discovery

That is awesome! I essentially did this the other day using the Cookiecutter API, but this PR would simplify all the boilerplate and the concerns I had with repo proliferation too for those using the CLI.
+1 to that if the owners agree to that as this adds a huge value

In case this is rejected because it adds a feature to a set that we want to keep minimal, is there an alternative cookiecutter cli application that can accept features like this? Or are users expected to whip up custom applications of their own?

Speaking as a long-time cookiecutter user ( i'm not a maintainer of this project. ).
I believe that any new feature, however useful and cool it may be, is unlikely to be accepted in this momment, because this project, even if it is used by a lot of people, including extra large companies, is not sufficiently funded, so that their maintainers can not devote more time to it than they currently do.
Maintainers can not cope with an even greater burden of to support this library without sufficient funding. https://github.com/audreyr/cookiecutter/pull/848#issuecomment-259575460.
Current project has almost seven thousand stars in github, but still failed to get even $60 per month of funding.
https://www.patreon.com/hackebrot
https://www.patreon.com/danielroygreenfeld
(Although it is obvious, as incredible as it sounds, software developers, also have the day with 24h like everyone, of which, have to use to get the money to pay the bills. :-) )
If you work in a company (or not), and cookiecutter helps you Create Value ( saving you time with boring and repetitive tasks, necessary to create a new project ), and you have some money and want to support this incredible software, talk about it with the maintainers.
related links:
https://www.fordfoundation.org/library/reports-and-studies/roads-and-bridges-the-unseen-labor-behind-our-digital-infrastructure/
https://github.com/pybee/paying-the-piper

@vivainio Cookiecutter does one thing, and it does it quite well. Cookiecutter supports every supported version of Python in every environment, so increasing it's features is often more complicated than it seems. And as much as we love working on this project, our work on it comes out of our free time. Adding more features means the maintainers have to do even more unpaid volunteer work.
@luzfcb is right to point out this project is not sufficiently funded. It's frustrating knowing how many Fortune 500 companies use this tool and yet all that we make from it is worth what in the USA we call "Enough for Taco Bell twice a month".
That said, I hear your plea and those of the others on this thread. We love this project and want to improve it. We're working to change the funding method. To that end, we are launching paid courses that use Cookiecutter extensively. A substantial amount from these courses will be going to support Cookiecutter and its ecosystem.
So if you want this feature and this project to move forward, please go to https://courses.twoscoopspress.com/courses/creating-and-distributing-python-packages

@DmitrySavinBloomberg with the 5 minutes of unpaid volunteer time I can afford to spare, it doesn't appear to have any problems.

Assuming cookiecutter won't be growing in features much due to resource starvation, it seems like the best workaround is to write own cli's using cookiecutter api (but cli would deal with discovery etc, and just do the rendering with cookiecutter lib). Are there best practice or documentation examples on how to use the api, or is it just about reading the source? An example of such an utility I was thinking of would be seeking the templates from package.json up the tree, and then render them in current directory.


reCaptcha is not been validated when logging to devportal

Description:
I configured reCaptcha as described in the documentation.
https://apim.docs.wso2.com/en/latest/install-and-setup/setup/security/logins-and-passwords/setting-up-recaptcha/
Changed deployment.toml with my keys and changed Identity Providers -> Resident -> Login Attempts Security -> reCaptcha for SSO Login -> Always prompt reCaptcha.
However, although reCaptcha appears on the devportal login screen, it is not validated when logging in. If I try to log into devportal without checking the recaptcha box, I can log in without any problems.
Steps to reproduce:

Download wso2 API Manager version 3.2.0 or version 4.0.0
Start api manager wso2server.bat for version 3.2.0 or api-manager.bat for version 4.0.0
Stop api manager
Follow the steps described here: https://apim.docs.wso2.com/en/latest/install-and-setup/setup/security/logins-and-passwords/setting-up-recaptcha/
Start  api manager wso2server.bat for version 3.2.0 or api-manager.bat for version 4.0.0
Access https://localhost:9443/devportal and try to logging in do devportal without checkin reCaptcha

Affected Product Version:
3.2.0
4.0.0
Environment details (with versions):

OS: Windows
Client: localhost
Env (Docker/K8s): localhost

solved here: https://github.com/wso2/product-apim/pull/12082


Implementation of evaluate_parallel requires pickling pygame.Surface

The evaluation_parallel method in the Evaluation class in src/Evaluation/evaluation_parent.py requires pickling the pygame.Surface object used by the game attribute object. pygame.Surface cannot be pickled, which raises an error when the run_longer method is called in the SimulatedAnnealing class.

What is odd is that this issue is not encountered when calling the evaluate_parallel method from the calc_batch_size method of the Analytics class in src/Utils/analytics.py.
Parallel evaluation must be implemented in a different way. Otherwise, the game attribute object must stop using a pygame.Surface object to run the game.

This code was fixed by this commit. Both the game object and the ple object attributes are set to None after each evaluation and will be initialized before each evaluation starts. This ensures that there's not any pygame.Surface object to be pickled during parallel evaluation. Therefore, each new child process initializes its own game and ple objects.


Fix branch-0.3 -> branch-0.4 automerge

This fixes the failed automerge in #1394.
NOTE: This should be committed with a merge commit instead of being squashed!

build


Toolbar icons are stuck to the text

Needs some space ASAP.

https://github.com/dlang-tour/core/pull/570

The dmd-beta failure is caused by https://issues.dlang.org/show_bug.cgi?id=17608.

thanks.


Elasticsearch doesn't come up

/var/log/supervisor/elasticsearch.log is empty, so not really sure how to troubleshoot this, I ran the command in the supervisor config for ES manually and it seemed to work fine?
[root@elk supervisor]# cat supervisord.log
2015-10-14 23:25:14,387 CRIT Supervisor running as root (no user in config file)
2015-10-14 23:25:14,387 WARN Included extra file "/etc/supervisord.d/diamond.ini" during parsing
2015-10-14 23:25:14,387 WARN Included extra file "/etc/supervisord.d/statsd.ini" during parsing
2015-10-14 23:25:14,387 WARN Included extra file "/etc/supervisord.d/nginx.ini" during parsing
2015-10-14 23:25:14,387 WARN Included extra file "/etc/supervisord.d/kibana.ini" during parsing
2015-10-14 23:25:14,387 WARN Included extra file "/etc/supervisord.d/elasticsearch.ini" during parsing
2015-10-14 23:25:14,387 WARN Included extra file "/etc/supervisord.d/logstash_watchdog.ini" during parsing
2015-10-14 23:25:14,387 WARN Included extra file "/etc/supervisord.d/logstash.ini" during parsing
2015-10-14 23:25:14,387 WARN Included extra file "/etc/supervisord.d/watchpsutil.ini" during parsing
2015-10-14 23:25:14,387 WARN Included extra file "/etc/supervisord.d/consul.ini" during parsing
2015-10-14 23:25:14,388 WARN Included extra file "/etc/supervisord.d/rsyslog.ini" during parsing
2015-10-14 23:25:14,418 INFO RPC interface 'supervisor' initialized
2015-10-14 23:25:14,419 CRIT Server 'unix_http_server' running without any HTTP authentication checking
2015-10-14 23:25:14,419 INFO supervisord started with pid 12
2015-10-14 23:25:15,422 INFO spawned: 'elasticsearch' with pid 15
2015-10-14 23:25:15,424 INFO spawned: 'logstash_watchdog' with pid 16
2015-10-14 23:25:15,428 INFO spawned: 'statsd' with pid 17
2015-10-14 23:25:15,430 INFO spawned: 'diamond' with pid 18
2015-10-14 23:25:15,437 INFO spawned: 'consul' with pid 19
2015-10-14 23:25:15,451 INFO spawned: 'kibana' with pid 23
2015-10-14 23:25:15,460 INFO spawned: 'watchpsutil' with pid 26
2015-10-14 23:25:15,462 INFO spawned: 'nginx' with pid 27
2015-10-14 23:25:15,479 INFO spawned: 'rsyslog' with pid 32
2015-10-14 23:25:15,565 INFO exited: elasticsearch (exit status 1; not expected)
2015-10-14 23:25:16,474 INFO success: logstash_watchdog entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2015-10-14 23:25:16,474 INFO success: statsd entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2015-10-14 23:25:16,474 INFO success: diamond entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2015-10-14 23:25:16,475 INFO success: kibana entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2015-10-14 23:25:16,475 INFO success: watchpsutil entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2015-10-14 23:25:16,475 INFO success: nginx entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2015-10-14 23:25:16,490 INFO success: rsyslog entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2015-10-14 23:25:16,701 INFO spawned: 'elasticsearch' with pid 288
2015-10-14 23:25:16,722 INFO spawned: 'logstash' with pid 290
2015-10-14 23:25:16,771 INFO exited: elasticsearch (exit status 1; not expected)

Hey there,
I pulled the latest qnib/elk image and for me it works...

[root@elk opt]# cat /var/log/supervisor/supervisord.log
2015-10-15 12:20:07,881 CRIT Supervisor running as root (no user in config file)
2015-10-15 12:20:07,882 WARN Included extra file "/etc/supervisord.d/statsd.ini" during parsing
2015-10-15 12:20:07,882 WARN Included extra file "/etc/supervisord.d/diamond.ini" during parsing
2015-10-15 12:20:07,882 WARN Included extra file "/etc/supervisord.d/nginx.ini" during parsing
2015-10-15 12:20:07,882 WARN Included extra file "/etc/supervisord.d/kibana.ini" during parsing
2015-10-15 12:20:07,882 WARN Included extra file "/etc/supervisord.d/elasticsearch.ini" during parsing
2015-10-15 12:20:07,882 WARN Included extra file "/etc/supervisord.d/logstash_watchdog.ini" during parsing
2015-10-15 12:20:07,882 WARN Included extra file "/etc/supervisord.d/logstash.ini" during parsing
2015-10-15 12:20:07,882 WARN Included extra file "/etc/supervisord.d/watchpsutil.ini" during parsing
2015-10-15 12:20:07,882 WARN Included extra file "/etc/supervisord.d/consul.ini" during parsing
2015-10-15 12:20:07,882 WARN Included extra file "/etc/supervisord.d/rsyslog.ini" during parsing
2015-10-15 12:20:07,911 INFO RPC interface 'supervisor' initialized
2015-10-15 12:20:07,912 CRIT Server 'unix_http_server' running without any HTTP authentication checking
2015-10-15 12:20:07,912 INFO supervisord started with pid 9
2015-10-15 12:20:08,922 INFO spawned: 'elasticsearch' with pid 12
2015-10-15 12:20:08,924 INFO spawned: 'logstash_watchdog' with pid 13
2015-10-15 12:20:08,926 INFO spawned: 'statsd' with pid 14
2015-10-15 12:20:08,929 INFO spawned: 'diamond' with pid 16
2015-10-15 12:20:08,932 INFO spawned: 'consul' with pid 19
2015-10-15 12:20:08,934 INFO spawned: 'kibana' with pid 21
2015-10-15 12:20:08,936 INFO spawned: 'watchpsutil' with pid 23
2015-10-15 12:20:08,939 INFO spawned: 'nginx' with pid 25
2015-10-15 12:20:08,947 INFO spawned: 'rsyslog' with pid 30
2015-10-15 12:20:09,944 INFO success: elasticsearch entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2015-10-15 12:20:09,945 INFO success: logstash_watchdog entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2015-10-15 12:20:09,945 INFO success: statsd entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2015-10-15 12:20:09,945 INFO success: diamond entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2015-10-15 12:20:09,945 INFO success: kibana entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2015-10-15 12:20:09,945 INFO success: watchpsutil entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2015-10-15 12:20:09,945 INFO success: nginx entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2015-10-15 12:20:09,952 INFO success: rsyslog entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2015-10-15 12:20:10,121 INFO spawned: 'logstash' with pid 301
2015-10-15 12:20:11,243 INFO success: logstash entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2015-10-15 12:20:14,245 INFO success: consul entered RUNNING state, process has stayed up for > than 5 seconds (startsecs)
2015-10-15 12:20:31,031 INFO exited: diamond (exit status 127; not expected)
2015-10-15 12:20:32,036 INFO spawned: 'diamond' with pid 535
2015-10-15 12:20:33,038 INFO success: diamond entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2015-10-15 12:20:54,072 INFO exited: diamond (exit status 127; not expected)
2015-10-15 12:20:55,075 INFO spawned: 'diamond' with pid 684
2015-10-15 12:20:56,078 INFO success: diamond entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2015-10-15 12:21:17,111 INFO exited: diamond (exit status 127; not expected)
2015-10-15 12:21:17,819 INFO spawned: 'diamond' with pid 826
2015-10-15 12:21:19,755 INFO success: diamond entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2015-10-15 12:21:39,853 INFO exited: diamond (exit status 127; not expected)
2015-10-15 12:21:40,621 INFO spawned: 'diamond' with pid 977
2015-10-15 12:21:41,629 INFO success: diamond entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)

How much memory do you got on the machine? Maybe it's not enough to supply the JVM. :)

Ah, yeah, that was the issue. I am running docker-machine and my VM only had 1GB of RAM. I bumped it to 2GB and things are working. Thanks!

My pleasure... thanks for the feedback! I guess I should add a check somehow...

I put it in the readme...


Accessibility and Usability Optimisations

As discussed with Josiah …
https://github.com/tgrosinger/tw5-checklist/issues/29#issuecomment-304064258
The demo is updated here: https://tid.li/tw5/test/checklist.html
A big step for this wonderful plugin :)

@telmiger Can you put up a an updated version of your demo when you get a chance? Thank you again!

The new version, in which I have tried to consider all your inputs, is online: https://tid.li/tw5/test/checklist.html – I hope you like it.
If I find out how to update a PR, I will be happy to do so.

@telmiger the new demo looks awesome! Once you push the changes to the pull request I will take a final pass over it and then we can get it merged.
Please notice that I made a small change in the Usage.tid which has caused a merge conflict in your review.

@telmiger  I just checked out your branch to build the state that has been uploaded, but it is definitely missing changes that are reflected in the demo you uploaded. You should be able to just use a git push to upload a new version of your changes.

My master branch is updated. Should I send a new PR or can you proceed with this one here?

No need for a new PR, I can see the commits and will take a look at them as soon as I get a chance. Thank you!


Add npm deployment to github actions for provide-types

This package should be automatically build and deployed by github actions: https://www.npmjs.com/package/@provide/types

The NPM_PUBLISH_API_TOKEN is available.

ty @FiretronP75


Add license

Can you add a license please for people who would like to use your code?

Ok, I added it.


Allow to get the currently focused window

Something like "Desktopia.Windows.Main" but "Desktopia.Windows.Focused" to get the currently focused window would be neat.

Added in 25dc221b480ee9e2489b2582edb9d092e82cd836.


SWC error: jsc.baseUrl must be absolute

Problem
With the recent update(issues here and here), swc doesn't accept relative baseUrl anymore. When rollup plugin reads tsconfig.json, it passes baseUrl in whatever format is there, and normally, it is something like . or ./src. It leads to errors:

[!] (plugin swc) Error: failed to handle: base_dir(./) must be absolute. Please ensure that jsc.baseUrl is specified correctly. This cannot be deduced by SWC itself because SWC is a transpiler and it does not try to resolve project details. In other works, SWC does not know which directory should be used as a base directory. It can be deduced if .swcrc is used, but if not, there are many candidates. e.g. the directory containing package.json, or the current working directory. Because of that, the caller (typically the developer of the JavaScript package) should specify it. If you see this error, please report an issue to the package author.

Suggested solution
If tsconfig file found, resolve baseUrl as absolute path (value from its compilerOptions.baseUrl field resolved against absolute path of the given tsconfig file)

Right now I solved this with manual baseUrl resolution in base config file shared across monorepo packages:
import fs from 'node:fs'
import path from 'node:path'
import json5 from 'json5'

// HACK https://github.com/SukkaW/rollup-plugin-swc/issues/41
const tsconfig = json5.parse(fs.readFileSync(TSCONFIG_PATH))
const baseUrl = path.resolve(tsconfig.compilerOptions.baseUrl)

export default {
  // rest skipped
  plugins: [
    swc({
      tsconfig: TSCONFIG_PATH,
      jsc: {
        baseUrl,
      },
    }),
  ],
}

Thanks for reporting this!
However, rollup-plugin-swc3 also supports extends in the tsconfig.json as well. So keeping the previous behavior might not be that easy.

@SukkaW I am using rollup-plugin-dts to generate the declaration files. With this plugin, the above error is thrown.
plugin version: 0.10.2


Commit message suffix so message can end with a period or whetever someone desires.

Is there an existing issue for this?

[X] I have searched the existing issues

Feature description
I do believe this has been requested before in #533 as well as #1446 however both issues are closed. Not being able to set a suffix is causing my git commit message linters to fail.
A similar request is #2091 however that is for a description suffix whereas this is the actual commit message I would like to be able to set this on.

I can't comment if this can be implemented or not within a reasonable amount of time. If the team accepts it, will you send a PR for it? You don't have to, but it'll definitely speed it up
In the meantime, did you ever consider excluding dependabot pull requests from your linting process?
I understand that it is not the ideal solution for you and that you'd like to keep it consistent, but it should at least unblock you while this feature is discussed and it'll be a quicker win for you and your projects

I have temporarily done that. I'd be happy to do a PR but I'm not a ruby person so don't know where to start but if you could point me in the direction of which files etc would need updating i may be able to figure it out. Thanks @yeikel

I have temporarily done that. I'd be happy to do a PR but I'm not a ruby person so don't know where to start but if you could point me in the direction of which files etc would need updating i may be able to figure it out. Thanks @yeikel

If I am not mistaken, the logic you're looking for should be here
https://github.com/dependabot/dependabot-core/blob/main/common/lib/dependabot/pull_request_creator/message_builder.rb#L62-L67
In this example, I believe that you'd need to extend MessageBuilder to accept a new optional parameter such as commit_message_suffix
And then use it within the commit message builder as the first parameter like this :

 def commit_message
       message += commit_message_suffix + "\n\n"
       message += commit_subject + "\n\n"
        message += commit_message_intro
        message += metadata_links
        message += "\n\n" + message_trailers if message_trailers
        message

Note that this is just an example and it would need to be reviewed and accepted by the team.
Before starting to work on it, it is advisable to wait for confirmation from the dependabot team that they are willing to review and accept the new feature into core.
Since this is a new addition to dependabot-core and not just a bug fix, implementing it is only part of the work required to make it available in the public dependabot service, unless you plan to use dependabot core directly.
This implies that the new feature must be integrated into the dependabot schema, documented, and tested, among other things before it can reach general availability for you to use it.
It is not impossible, and your wiliness to help is appreciated, I am just trying to be honest with you so that you can keep your expectations realistic.
I hope it helps, and thank you again.

Thanks for the detailed explanation @yeikel. Happy to wait for feedback from the dependabot team first. On having a poke at that file you linked, it seems quite similar to Python so that makes me hopeful it wouldn't be too steep of a learning curve which is a relief. I didn't realise the two languages shared a similar look.
And not sure if it came across clear in the first post. I'd like the suufix to be added to the first line of the commit message rather than right at the end of the whole message as well which guessing may complicate it further.

And not sure if it came across clear in the first post. I'd like the suufix to be added to the first line of the commit message rather than right at the end of the whole message as well which guessing may complicate it further.

Can you share some examples?

@yeikel So this is one of my current Dependabot commit messages:
build(deps-dev): bump black from 22.3.0 to 23.3.0
Basically I would like this to be:
build(deps-dev): Bump black from 22.3.0 to 23.3.0.
So what I need to be able to change is to be able to add a suffix to the commit message title so that can have it end with a period. Another thing is that I need to be able to capitalise the first word after the colon.
I have attached a screenshot of a list of my commits so you can see more of the messages which meet my linters.

Thank you for the examples.
Have you considered using this transformation at merge time in the meantime?
If you use squash commits, you'll get the opportunity to change the final commit message and you might me able to build a simple script to do this using the github cli
I understand that is not the solution you're looking for, but it'll be easier for you.

To be honest it doesn't really work for me as I prefer a proper rebase workflow to keep the entire git history. I think at the moment I'd rather just exclude dependabot commits from the linters and then see how this progresses.

To be honest it doesn't really work for me as I prefer a proper rebase workflow to keep the entire git history. I think at the moment I'd rather just exclude dependabot commits from the linters and then see how this progresses.

I meant to squash only the dependabot commits. Generally, they're always 1 commit

Hi, any update on this issue ? We need it it for [skip ci] is certain case ;)

Did you consider what I suggested above?


feature: ddcommon-net2 crate

What does this PR do?
This adds the ddcommon-net2 crate which uses hyper 1, unlike ddcommon-net1 which uses hyper 0.14. The datadog-profiling and datadog-profiling-ffi crates are moved to use ddcommon-net2.
Motivation
Hyper migration.
Additional Notes
I was hoping that this specific implementation strategy would get rid of a specific linking issue I hit on Windows in another PR. However, ddcommon-ffi depends on ddcommon-net1 so both net crates are in play. The relationships are a bit different (better, IMO) but it didn't outright fix the issue. I think all crates built together on Windows need to have the same hyper version dependency :'(
How to test the change?
Describe here in detail how the change can be validated.

Codecov Report
Attention: Patch coverage is 27.73537% with 284 lines in your changes missing coverage. Please review.

Project coverage is 70.24%. Comparing base (1cf5035) to head (55eec29).

Additional details and impacted files
@@                Coverage Diff                 @@
##           levi/split-net     #766      +/-   ##
==================================================
- Coverage           70.55%   70.24%   -0.32%
==================================================
  Files                 297      300       +3
  Lines               43547    43815     +268
==================================================
+ Hits                30726    30779      +53
- Misses              12821    13036     +215

Components
Coverage Δ

crashtracker
44.89% <ø> (ø)

crashtracker-ffi
8.41% <ø> (ø)

datadog-alloc
98.73% <ø> (ø)

data-pipeline
89.09% <ø> (ø)

data-pipeline-ffi
0.00% <ø> (ø)

ddcommon
75.24% <18.12%> (-8.03%)
:arrow_down:

ddcommon-ffi
68.50% <ø> (ø)

ddtelemetry
59.07% <ø> (ø)

ddtelemetry-ffi
22.13% <ø> (ø)

dogstatsd
89.45% <ø> (ø)

dogstatsd-client
79.77% <ø> (ø)

ipc
82.76% <ø> (-0.11%)
:arrow_down:

profiling
84.85% <69.86%> (+0.54%)
:arrow_up:

profiling-ffi
77.43% <60.00%> (-0.07%)
:arrow_down:

serverless
0.00% <ø> (ø)

sidecar
38.01% <ø> (ø)

sidecar-ffi
0.00% <ø> (ø)

spawn-worker
50.36% <ø> (ø)

tinybytes
93.47% <ø> (ø)

trace-mini-agent
72.38% <ø> (ø)

trace-normalization
98.23% <ø> (ø)

trace-obfuscation
95.77% <ø> (ø)

trace-protobuf
77.67% <ø> (ø)

trace-utils
93.29% <ø> (+0.38%)
:arrow_up:


Should csv format be specified, and does it matter?

Submitter:
Is it significant if the csv is CSV UFT-8 or another csv type. Saving as "csv" from Excel offers multiple options. Could add guidance on this to the instructions.

@regnans It is a good point. I typically save as just .csv in Windows and ignore the other .csv options. The options you have differ on the software or OS. @robcrystalornelas Did we have a question about this to Deb and Charu? It seems familiar. I would have to go back and check notes in Google drive.

@regnans It is a good point. I typically save as just .csv in Windows and ignore the other .csv options. The options you have differ on the software or OS. @robcrystalornelas Did we have a question about this to Deb and Charu? It seems familiar. I would have to go back and check notes in Google drive.

This may have come up during the last couple of meetings in the review process, but we should check back in with them to confirm.

This may have come up during the last couple of meetings in the review process, but we should check back in with them to confirm.

@vchendrix just wanted to highlight this issue about encoding. We are wondering whether it is important to suggest the type of encoding for CSV files since researchers saving CSVs from Excel are offered different encoding options.


⚠ Syncthing-KA-TM has degraded performance

In e396fb7, Syncthing-KA-TM ($URL_SYNCTHING_MERZ_NIMBUS_TM) experienced degraded performance:

HTTP code: 200
Response time: 5640 ms

Resolved: Syncthing-KA-TM performance has improved in 07c1a86 after 6 minutes.


Democratic-co different classifiers

I have been reviewing the Democratic-co learning algorithm implementation and I think the three classifiers to use should be parametrizable, i.e., the user should be able to change them.

Sounds like an appropriate enhancement

And the same with the tri-training: instead of giving a fixed possibilities of classifiers, it should be better if the user can select any of Scikit-learn classifiers.

And only one more issue: Add the original citation on a comment at the beginning of the code (such as you did on Democratic-co).
Thanks

Based on current comments, Democratic Co-Learning and Tri-Training could be parametrized as desired in terms of classifiers to use. Co-Training should be too, shouldn't it? @alvarag


Handle re-ranking a ranked model when current_first/current_last is nil

A take on 'first do no harm' when seeing the occasional
NoMethodError: undefined method `rank' for nil:NilClass (Most recent call first)

File /app/vendor/bundle/ruby/2.6.0/gems/ranked-model-0.4.4/lib/ranked-model/ranker.rb line 188 in rearrange_ranks

There are various possible strategies for handling a missing 'current_x'

reset cache and retry
make a best effort with what we know
calculate 'freshness' of the current instance and do something when not fresh

have a pluggable strategy when no longer fresh

try to lock the re-reranking

Related

https://github.com/mixonic/ranked-model/issues/124
https://github.com/mixonic/ranked-model/pull/117

My preference would be locking, perhaps with an advisory lock if you wanted to investigate that. Does this problem still occur with the latest version of ranked-model?

Sorry, obviously it does since that's mentioned in your error :)
How do we end up with no current_first? It would imply that finder.first returns nil which would be an empty list?

@brendon Here's our ranked model
class JobProductionPlanSegment < ApplicationRecord
  include RankedModel
  ranks :sequence, with_same: :job_production_plan_id

The migration for it specified
 t.integer :sequence, null: false

The database is pg 11
Here are some logs from a recent occurrence
all requests below are POST to /v1/job-production-plan-segments with the same job_production_plan_id

timestamp
server
pid
thread
post response status
post body sequence-position
notes

2019-07-21T13:37:26.112Z
web.1
451
70057487585260
201
0

2019-07-21T13:37:26.149Z
web.1
836
70057503954640
500
1
failed

2019-07-21T13:37:26.234Z
web.1
451
70057487580040
201
3

2019-07-21T13:37:26.352Z
web.1
836
70057504046960
201
2

2019-07-21T13:37:26.456Z
web.1
451
70057487574620
201
4

2019-07-21T13:37:35.848Z
web.1
451
70057487561080
201
1
appears to be a successful retry of the failed request

so maybe sequence-position 0 hadn't been persisted yet?

@brendon on reflection I decide it made sense to make failing the 'before-save' hook to be a first class thing, and then used that as the default strategy for handling current-first or current-last being missing.
If you want to point me to where the appropriate test would go and give a few pointers, I'd be happy to add it.

OMG, I wrote a failing test and made it pass.  But I don't think my code style is right for the repo.

Hi @bf4, this is going to take me a while to look through. At first glance it seems like a mildly ungraceful solution to the problem that seems to deal with the symptoms rather than trying to figure out the cause. Nonetheless I'll star this to look at once I've cleared my other backlog of work :D

@brendon In that case, allow me to break this up into smaller prs

strategy 1: skip cannot rearrange
strategy 2: abort save
unrelated misc

I replaced the commit in the PR with just the failing test

Closing as stale


Add Basic Auth to HTTP Server

The Realm interface is in charge of authenticating a user and getting its Roles. There are 2 implementations at the moment: File based and Anonymous (to get default role) which can be chained. The Realm name is inspired by Tomcat, Elasticsearch...
The UserChecker is in charge of integrating HTTP Server with Realms.
The types names may be changed: suggestions are welcome.
The File Realm uses bcrypt to hash passwords on disk: I can use another hashing library/algorithm.
This pull request is related to PR #184 which brings HTTPS

This will need to be refactored for 1.0 now. At present, there's still no auth in the API endpoint

I'm closing this out as it appears abandoned as a PR and it's incompatible with 1.x.


Tagged release of picorv32

I'm considering updating the picorv32 core for the FuseSoC standard library, but it would be great to have a tagged release that I can use

There are a couple of open todo items that I'd like to address first. As soon as this is done I'll tag a release.

Cool. I'll prepare the stuff on the FuseSoC side in the meantime

I second this.  Hopefully FuseSoC has a AXI4-Wishbone bridge.  It would be nice to have a RISC-V SoC with DDR and Ethernet support.

Just tagged v1.0.


Allow for variables in me requests and bot responses

Is your feature request related to a problem? Please describe.
We have a need to run botium tests on different data sets.  We can work around this by adding strings like {{PersonAName}} in .convo.txt files and then using sed script to replace the strings with an actual data value, but sure would be nice if we could use environment variables like ${BOTIUM_PersonAName} and botium CLI replace that environment variable in real time so we don't have to generate convo.txt files based on the data the bot is connected to.
Describe the solution you'd like
In the botium.json file, could have a variables object where that variable would be replaced with the value in #me and #bot utterances when tests are run.
Describe alternatives you've considered
Make our convo.txt files have the same variables, but have to use scripts to make copies of convo.txt files with strings replaced by sed.  Have to add this scripts to our DevOps process.
Additional context

maybe this is what you are looking for ?
https://botium.atlassian.net/wiki/spaces/BOTIUM/pages/48824412/Scripting+Memory+File

Maybe.  I have a couple questions on the usage of this "Memory file"

on page https://botium.atlassian.net/wiki/spaces/BOTIUM/pages/48824412/Scripting+Memory+File
I'm not sure where the lines below "scripting memory for product" and "scripting memory for order number" are stored. If they are in the .convo.txt file then that won't work for us.  If the memory file can be outside the convo.txt files, then I could have our script just modify (or generate) the memory file and leave all the convo.txt files with $variable names.  That would be much less work for us.

To further explain our issue...
let's say our order bot can order anything, so the bot is used by a grocery store and an electronics store, so the "scripting memory for product" needs to be different for each.  Can't order bread at the electronics store.

You are using text files, so the scripting memory files are recognized with the .scriptingmemory.txt file extension, outside of the convo files.

The examples only show the variables used in the #me requests.  Can they be used in the #bot responses?

The examples also show using the variable in the #me requests and not using the variable values, like we have a test like this...
#me
What can I order from you?

#bot
You can order Bread, Beer, and Eggs.

Can particular values from the .scriptingmemory.txt file be used like "$product1 $product2"?
And I assume the values for product1 and product2 can have multiple words and that's okay.  For example:
            | $productName
product1|49 inch plasma television
product2|natural gas grill

So after giving some thoughts, my conclusion is that the scripting memory files are not a solution for your question. The scripting memory is more about capturing parts of the chatbot response for later reuse (example: bot response with an order number you want to use later in the conversation).
The good news is that your original suggestion, to use environment variable replacement, was just a very small code change and will be included in the next build (pull request #392). You can use environment variables in your convo file like this:
Add $func(process.env.BOTIUM_PRODUCT) to the shopping cart

Cool.  And sounds like that will work for #me requests and #bot response.

After giving some more thoughts, the scripting memory files could indeed be a good solution for this question as well.
You have a convo file representing the generic conversation part:
#me
What can I order from you?

#bot
You can order $available_products

#me
Ok, then send me some $productName

#bot
Added $productName to the shopping cart

Then you have a directory holding the scripting memory files:
                 | $available_products
product1  | Bread, Beer, Eggs

                 | $productName
product1  | Bread
product2  | Beer

And then use the botium-cli "--convos" flag to point to the directory holding the convo, and additionally to another directory holding the scripting memory files.
for this case, it is important to set the SCRIPTING_MEMORY_MATCHING_MODE capability to joker, as the values are not simple words but include spaces
I added exactly this example as unit test to the repository: https://github.com/codeforequity-at/botium-core/pull/392/commits/1add3f2db9f73717e8f24079457fa8988393c36e

news here ? can this issue be closed ?

news here ? can this issue be closed ?

Thanks for asking.  Yes, go ahead and close.  I can reopen if we have issues.  We aren't using this yet and likely will use the process.env.VAR first.  It's easier to have a single file of env vars than to have a file for every list that we might provide in the skill (i.e. we might have many of those $available_products lists)

If you have a suggestion for a good solution when working with multiple lists, pls make another feature request. I currently don't have an idea what you want to reach.


Add ARIA build back again

Added enable-aria to builds that enable rc5 and md2.
Fixes #3038.

So this depends on your #3011 being merged, then you'll have to rebase.  Maybe you want to just do the simple change in travis.yml?

Ignore this one please.  Not for the first time, I screwed up my branch point.
#3046 should work and is the same.


Can I directly integrate the model.py when using tuning  code instead of calling script through command

Describe the issue:
Now the way NNI calls the train script is:
experiment. config. trial_ command = 'python train. py'
This method of calling by command is not convenient for the integration of our current projects, because we do not want to start the train script by calling the file. We want to start it directly by calling the code, such as import train, and then NNI directly calls the train() function. We do not know whether NNI provides this form

@xiaoerqi thanks for raising this issue. Directly calling a train() function in script is indeed convenient in some scenarios, will support this feature probably in v3.1 release.

I'm very glad that NNI will support this function. Will v3.1 release be the next version？

The next release is v2.9. We have planned items for v2.9 and v3.0. Therefore, this feature is planned in v3.1


HBASE-24740 Enable journal logging for HBase snapshot operation

Sample Journal entry:
Table snapshot journal :
Running FLUSH table snapshot test_snapshot C_M_SNAPSHOT_TABLE on table test at<PHONE_NUMBER>584
Consolidate snapshot: test_snapshot at<PHONE_NUMBER>691 (+107 ms)
Loading Region manifests for test_snapshot at<PHONE_NUMBER>692 (+1 ms)
Writing data manifest for test_snapshot at<PHONE_NUMBER>693 (+1 ms)
Verifying snapshot: test_snapshot at<PHONE_NUMBER>706 (+13 ms)
Snapshot test_snapshot of table test completed at<PHONE_NUMBER>710 (+4 ms)

@apurtell @bharathv @virajjasani  Can you please review ?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
docker
0m  7s
Docker failed to build yetus/hbase:7cf97016b9.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/2076

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2076/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
9m 49s
branch-1 passed

+1 :green_heart:
compile
0m 40s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
compile
0m 46s
branch-1 passed with JDK v1.7.0_262

+1 :green_heart:
checkstyle
1m 41s
branch-1 passed

+1 :green_heart:
shadedjars
3m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 50s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 41s
branch-1 passed with JDK v1.7.0_262

+0 :ok:
spotbugs
3m  3s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m  0s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 56s
the patch passed

+1 :green_heart:
compile
0m 42s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javac
0m 42s
the patch passed

+1 :green_heart:
compile
0m 44s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
javac
0m 44s
the patch passed

+1 :green_heart:
checkstyle
1m 28s
hbase-server: The patch generated 0 new + 20 unchanged - 10 fixed = 20 total (was 30)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 46s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 45s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 32s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 44s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
findbugs
2m 54s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
133m 40s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 38s
The patch does not generate ASF License warnings.

175m 40s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2076/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2076

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux<PHONE_NUMBER>6c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2076/out/precommit/personality/provided.sh

git revision
branch-1 / 71aec0f

Default Java
1.7.0_262

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_262

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2076/2/testReport/

Max. process+thread count
4488 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2076/2/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Looks good overall, few minor nits. We are planning PR for master branch also?

Yes @virajjasani  , we can commit this PR for master branch as well

LGTM

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
9m 43s
branch-1 passed

+1 :green_heart:
compile
0m 41s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
compile
0m 44s
branch-1 passed with JDK v1.7.0_262

+1 :green_heart:
checkstyle
1m 40s
branch-1 passed

+1 :green_heart:
shadedjars
3m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 47s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK v1.7.0_262

+0 :ok:
spotbugs
2m 58s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 55s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 54s
the patch passed

+1 :green_heart:
compile
0m 43s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javac
0m 43s
the patch passed

+1 :green_heart:
compile
0m 44s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
javac
0m 44s
the patch passed

+1 :green_heart:
checkstyle
1m 29s
hbase-server: The patch generated 0 new + 20 unchanged - 10 fixed = 20 total (was 30)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 47s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 34s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 31s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 43s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
findbugs
2m 49s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
132m  0s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 37s
The patch does not generate ASF License warnings.

173m 20s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2076/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2076

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 76406a1354d4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2076/out/precommit/personality/provided.sh

git revision
branch-1 / 37903b0

Default Java
1.7.0_262

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_262

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2076/3/testReport/

Max. process+thread count
4280 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2076/3/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Remove period from find messages

What does this PR change? What problem does it solve?
Simplifies cut-and-paste of IDs by removing the period from two find messages.
(And makes the output stylisticly consistent with other messages.)
Was the change previously discussed in an issue or on the forum?
Closes #3659
Checklist

[x] I have read the contribution guidelines.
[x] I have enabled maintainer edits.
[ ] I have added tests for all code changes.
[ ] I have added documentation for relevant changes (in the manual).
[x] There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
[x] I have run gofmt on the code in all commits.
[x] All commit messages are formatted in the same style as the other commits in the repo.
[x] I'm done! This pull request is ready for review.

I hadn't included the changelog until I got to the checklist, and ended up amending the commit. :slightly_smiling_face:
I've removed the changelog again.


Clock countdown

Pull request za odbrojavanje.

Trenutno je ovisan o "ReferenceTime" tagu iz pdfa, kojeg livechess uvijek stavi u pdf.

The change is merged here.
 Best should have been for me to push to your fork first. Sorry about that.
Action item for future is to fix interaction with "Rotate board" function. On single board view a delay (of up to 1 second) for updating background clock color is introduced.


Update background-jobs.md

Fixing broken link per https://mseng.visualstudio.com/TechnicalContent/_workitems/edit/1284761

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/best-practices/background-jobs.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@dragon119  - Hi, Masashi. I needed to fix a link per the work item listed above. Could you please approve for me? Or please let me know who I should reach out to instead. Thanks! Craig


Exporter/OcAgent: Add connection and config worker threads.

Blocked by https://github.com/census-instrumentation/opencensus-java/pull/1574.

Codecov Report

Merging #1506 into master will decrease coverage by 0.7%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #1506      +/-   ##
============================================
- Coverage     83.47%   82.77%   -0.71%
  Complexity     1813     1813
============================================
  Files           261      262       +1
  Lines          8339     8411      +72
  Branches        803      813      +10
============================================
+ Hits           6961     6962       +1
- Misses         1123     1194      +71
  Partials        255      255

Impacted Files
Coverage Δ
Complexity Δ

...e/ocagent/OcAgentTraceServiceConnectionWorker.java
0% <0%> (ø)
0 <0> (?)

...ter/trace/ocagent/OcAgentTraceExporterHandler.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...census/implcore/trace/export/SpanExporterImpl.java
94.52% <0%> (-1.37%)
9% <0%> (ø)

...e/ocagent/OcAgentTraceServiceConfigRpcHandler.java
79.31% <0%> (+3.44%)
12% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72d3a9a...00cee3f. Read the comment docs.

Discussed offline, we'd like to refactor the retry for export and config separately, and simplify the export retry logic. Going to close this and post a new PR after refactoring.


Reduce distribution package size

Currently we distribute a lot with the whole package. The export actually also contains /docs if I am not mistaken. Composer per default uses --prefer-dist (unless told to fetch from source) and therefore uses git archives. Now the size of an archive can be reduced by introducing a .gitattributes file and ignoring specific non-distribution files.
Edit: As I was just looking around, I found this mess in a GitHub repo. We can avoid that.

I'm going to merge the branch into dev so it will be part of next release.

@franz-josef-kaiser it's merged on dev. We can close this, right?

Done with 0abea7a


WIP: Replumbing: Add the Provider Object, type OSSL_PROVIDER

The OSSL_PROVIDER is the core object involved in loading a provider
module, initialize a provider and do the initial communication of
provider wide and core wide dispatch tables.
Checklist

[ ] documentation is added or updated
[x] tests are added or updated

Note: this is made on top of #8286, ensure that you know which is which

TODO: docs and test.  That will be for tomorrow

This now includes a few tests that contain a very simple provider that provides nothing but a greeting.  This simple provider gets to act both as a built in provider and as a loadable provider module.
Count this as official first boot!

TODO: documentation

Hmmm, Travis fails the loaded provider module test with a segfault.  The tests work right on all machines I can get my hands on for the moment...  so does anyone else have a clue?

Never mind that, found myself a clue

Travis errors are relevant.

Travis errors are relevant.

Yeah, I discovered that as well

The CIs finally approve :-)

Back in WIP, I forgot that I need to add docs as well

Glad you picked up on that...  personally, I find the use of underscore when not absolutely required (like in the limitations of symbol names) incredibly ugly.
Furthermore, it's interesting that you mention packaging in relation to this.  See, in the Debian universe, underscores are used as delimiters in package file names, to separate between the package name (which can and frequently does include dashes), the package version, and the applicable architecture.  Here are a couple of example from my cache:

libpandoc-wrapper-perl_0.9.0-1_all.deb
xserver-xorg-video-amdgpu_18.1.99+git20190207-1_amd64.deb

Don't get me wrong: I'm not opposed to using the dash per se. (I love them in Lisp code ;-) ). I am just against inconsistently mixing separators inconsistently and without a reason.
The debian packages are actually a good example for having two separate kinds of separators, because in this case both separators serve different purposes. So if you can give a good justification of why and when to use dashes instead of underscores, and if this convention gets accepted by all other project members, that's ok for me. But just thinking that it looks nicer is not enough of a reason.

If it were a new project, it would be ok (though uncommon) to use the dash throughout. But we already have a lot of files containing underscores.

Actually, we do use underscore as a sub-system / prefix delimiter, although not entirely consistently.  In crypto/rsa, you'll see rsa_ everywhere.  In crypto/evp, you will see encryption algorithm implementations fairly consistently prefixed with e_ and digest algorithm implementations fairly consistently prefixed with m_.
I have no intention to make "provider" a prefix or otherwise sub-system indicator.  The only reason I have for two file names is that I wanted to separate the public API implementation from the internal API implementation.  So "provider" and "provider-core" are just two names, with no other meaning intended.

However, if everyone else would prefer "provider_core" over "provider-core", I can change that.  It's not like I'm very attached to either form.

My preferences are clear, I think ;-)

Yeah, so maybe a second opinion, 'cause if it's left to just you and I, I fear we may get nowhere...

That's ok for me. Since I braught up the subject, I'll right a short note to openssl-project.

I have a slight tendency to agree with @mspncp on the underscore vs dashes issue.

don't add another naming convention; use underscore.  yes it is a PITA.

@mattcaswell:

I have a slight tendency to agree with @mspncp on the underscore vs dashes issue.

@richsalz:

don't add another naming convention; use underscore.

Yeah, ok, I heard you...
@richsalz:

yes it is a PITA.

That brought me a smile, that we do agree, even though...

My change request has been resolved.

If it were not for all the existing underscores, I'd perfer dashes, too. But having an inconstent mixture of separators would be much worse.

@mspncp, I suggest you never look in the asm directories :wink:

My feeling is that consistency is better than not and thus underscores would make more sense.
However, I'm not going to zealously push this viewpoint.  I'd live with either.

@mspncp, I suggest you never look in the asm directories 😉

Of course I saw those files: I ran find  -name '*-*' before posting my request, you should know me better.  (Indeed, I even mentioned the Perl(asm) files in my post.)  And I was relieved that the case was not hopelessly mixed up in the case of the  C files. 😉 😉

(Before anyone gets me wrong: I did not mean to say that the naming scheme of the perlasm files was mixed up. On the contrary, with only marginal exceptions, it consistently uses dashes as separators.)

I'm a bit apprehensive regarding refcounting and its interaction with the provider store and possible race conditions.  I'd appreciate a second pair of eyes telling me that I'm overly paranoid, or that yes, there is indeed a concern.

Regarding underscores, the case is clear at this point, and if you look, I have changed the few dashes to underscores

I remade the refcounting so that any internal function that returns a OSSL_PROVIDER pointer also makes sure to increment the refcount.  This means that ossl_provider_new now returns a provider object with a refcount of 2 (one is for the store reference)
I did a slight alteration in the docs, where I'm now talking about "activated" and "inactivated" providers, to clarify their reason to still be in the store.

The Travis failure isn't directly related to this...  it's a detected "memory leak", which really just happens because the default library context is cleaned out after the memory leak reporter had its say.
This has me thinking that it might be time to retire the memleak detection stuff...  valgrind does a better job anyway (the memleak detection stuff is pre-valgrind, so was much more needed back then)

Took this out of WIP, as I think I've completed all that was needed here

Now that #8286 is out the way, it should be clearer what belongs in this PR

I added another commit with better check and error reporting if store == NULL.

Documentation changes approved.

I took a moment and listened to the critique regarding naming, and did an adjustment.  It was less work than I expected it to be.  I hope it will be satisfactory enough.
I've also rebased against a fresh master.

Merged.
c453283421299b7f8e0db6d6069c68369294a9f7 Add documentation
021a65527735af2ddc063d9300138660e3782a15 Add provider tests
16c2f1bdb5f051ee2c0ac96182a0fb5bad7daa68 Add provider module infrastructure
3374dc03edda56cbfd2a558fc62b7970eb0b9ad1 Replumbing: New public API to load or add providers
4c2883a9bf59c5ee31e8e2e101b3894a16c06950 Replumbing: Add the Provider Object, type OSSL_PROVIDER
3f4e8d6604842db4f416d029e9bbeddf90976c00 Replumbing: Add MODULESDIR macro and OPENSSL_MODULES environment variable


fix version not being picked up due to cwd change

Codecov Report

Merging #22 into master will decrease coverage by 8%.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           master     #22   +/-   ##
======================================
- Coverage    93.2%   85.2%   -8%
======================================
  Files           6       6
  Lines         690     690
======================================
- Hits          643     588   -55
- Misses         47     102   +55

Impacted Files
Coverage Δ

conda_concourse_ci/execute.py
74.8% <0%> (-15.8%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c604bd9...a3b4129. Read the comment docs.


Digest cleanups 2

Depends https://github.com/ostreedev/ostree-rs-ext/pull/87

lib/container: Change manifest fetch API to return raw bytes and digest
This allows us to use it more consistently.  We also drop the
unnecessary wrapper structure.

lib/container: Add API to fetch from already downloaded manifest
The flow here is then nicer, because at a high level apps like
rpm-ostree will want to do:

Fetch manifest, digest pair
Do we already have this? If so, we're done
Otherwise, perform the fetch using that already downloaded manifest

Previously we were fetching the manifest twice.

lib/container: Make use of skopeo copy --digestfile if present
This came from https://github.com/containers/skopeo/pull/1266
and has landed in Fedora 34 at least.

Rebased :surfer: and lifting draft!


Question - Create a list of things to do for the 1.0 release?

Hello
I think it would be a good idea to have somewhere a list of things that still need to be done before we can have a real 1.0 release. That way we have a kind of roadmap to work towards.
I've taken the liberty to close all the current milestones which were finished and created a 1.0.0 milestone that we can assign to tickets that need to be done. I've also removed a couple of unused labels (invalid and duplicate, as we close issues that have these states immediately anyway). I've already assigned a few issues to this milestone, feel free to add more or remove some you feel aren't needed.
1.0.0 would also be a good time to fix all the minor quirks or annoyances one noticed but didn't fix because it was less important in light of the more serious issues.
Finally, this does not mean we can't have any more releases until 1.0 arrives, but if all tickets matching the milestone are finished, it means we can label the next version as 1.0.
Thanks in advance

I was planning to do that in fact, great idea.


Doc sidebar active category not highlighted

https://github.com/facebookincubator/infima/blob/8c592e4fad80d410fcb9ffb132e6b2efc70c9db4/packages/core/styles/components/menu.pcss#L88
This !important has prevented the category link from being highlighted.

To achieve this, there is menu__list-item-collapsible--active class that needs to be set for the current active category.
It should be fixed in this PR https://github.com/facebook/docusaurus/pull/6531


German Scheme Feedback:  Identify the SFR Impact on Cloud Deployment

Under 3rd bullet, 2nd sub bullet: "It may be the case that a requirement simply does not apply to a cloud environment, in
which case the PP author could consider defining that requirement as an implementation based
SFR that applies only to the on-premise use case."  Is this the same as selection-based SFR as in ND_cPP? Using PP-Modules could also be an option in this case.

Yes, either the higher level mandatory SFR could include a selection for the on-prem specific SFR or you would have to modify the SFR to have selections for on-prem or cloud itself.


changed a small typo in comments

There was a small typo in comments which said, the pagination will only be rendered if the 'total' was greater than 2, where it should have been greater than 1.

thanks, very carefully


ES5 build

Hi,
Is there any chance to have the published packages be in ES5 instead of ES6?
The reason being that UglifyJs doesn't support ES6 yet, and being in a TS project we find bringing in Babel just to compile a dependency a bit too much.
Thanks

Hi @luanped!
I believe that as of TypeScript 1.8, ES6 inputs can be included and transpiled by passing them to the compiler and specifying the --allowjs option.
https://github.com/Microsoft/TypeScript/wiki/What's-new-in-TypeScript#including-js-files-with---allowjs
(There's a tsconfig equivalent syntax as well I think.)
Would this work for you?
Regards,
Nick

Hi @Nick!
Tried this method, unfortunately it doesn't fully work - it works when bundling, however it fails with some errors when I run Mocha tests (error does not occur if I manually convert the bunyan-seq code to ES5 first however)
Thanks,
Pedro

Thank you Pedro.
It sounds like Mocha can accept a --compilers option to ease this up; do you test in TypeScript or ES
5? It may be a bit much plumbing to deal with either way....
Which version of Node are you developing/deploying on?
Also, may be an odd question, but are you using Uglify because you're sharing code with the browser, or is the space win enough to justify it on your server-side code?
Thanks again for the info, keen to remove as many blockers for you as I can here, just trying to build a clearer picture for myself of how the landscape lies :-)
Cheers,
Nick

Hi Nick,
Thanks for your suggestions, I was able to solve my problems by using --allowJs and tsloader with the include property on bunyan-seq and seq-stream :)
Regards,
Pedro

That's awesome, thank you for the follow-up Pedro!


EXSWHTEC-35 - Implement negative tests for hipMallocFromPoolAsync

invalid device pointer
invalid mempool handle
invalid stream handle
out of memory

Please review
Nives Vukovic
Dino Music

closing since PR is migrated to hip-tests repo


Updated naming

Django to Mango
django to django
django/django to nikhiljohn10/mango

Sorry. Wrong PR


fix: use blue instead of teal for variable.other.member

Fixes the colors of member properties in objects like the following Nix file. Matches VSCode.

Before
After

This also actually fixes CSS too :D
Before:

Vscode:

neat!


Ensure cursor is not obscured by iOS onscreen keyboard

By implementing Program.textEditor() which provides hints to the Swift side about where any text cursor on screen is, and maybe moving the program view up to ensure it's not obscured by the onscreen keyboard.

Yeah.  You're right in that this is a change from the shipping code as we didn't have native text boxes and were kicking out to an iOS native dialog.

I expect the navigation bar to overlap the app view, but it looks like a weird little iOS bug that we've lost the 'thin material' background for the navigation bar. Good to get it recorded here though as I'd already forgotten about it. 🙃


fix action bar size

This PR fixes #22252
Recently a new export to markdown action was added, but the min-height is not adjusted.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
5 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.005%) to 41.942%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/dialog/configurePython/configurePythonWizard.ts
1
46.46%

extensions/sql-bindings/src/common/azureFunctionsUtils.ts
1
80.65%

extensions/machine-learning/src/common/processService.ts
3
77.78%

Totals

Change from base Build<PHONE_NUMBER>:
-0.005%

Covered Lines:
28802

Relevant Lines:
63751

💛  - Coveralls


krita 5.0.2: fails to build

Describe the bug
Krita fails to build with the following error
/build/krita-5.0.2/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw.cpp: In member function 'bool KDcrawIface::KDcraw::extractRAWData(const QString&, QByteArray&, KDcrawIface::DcrawInfoContainer&, unsigned int)'
:
/build/krita-5.0.2/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw.cpp:386:24: error: 'struct libraw_output_params_t' has no member named 'shot_select'
  386 |     raw.imgdata.params.shot_select = shotSelect;
      |                        ^~~~~~~~~~~

Steps To Reproduce
Steps to reproduce the behavior:
Build /nix/store/phqfm6gn6k7ql57i27ypmnvdxmz21q03-krita-5.0.2.drv
Expected behavior
Krita should build.
Metadata
nixpkgs @ c157bf1222949b63073821678cbef211d9b6129f

In https://github.com/NixOS/nixpkgs/pull/151592 libraw was updated. Switch to the old stable libraw_0_20 to fix this build.

Installing kirta is showing
building '/nix/store/phqfm6gn6k7ql57i27ypmnvdxmz21q03-krita-5.0.2.drv'

like it's not in the cache, any idea why?

You're attempting to build the older derivation.  And building it would fail.  Newer binaries are available: https://hydra.nixos.org/job/nixpkgs/trunk/krita.x86_64-linux

If you rely on channels, you might want to watch https://nixpk.gs/pr-tracker.html?pr=170108

I'm using  the "https://nixos.org/channels/nixpkgs-unstable"  and just updated it, and I get this:
nix-env -i krita
installing 'krita-5.0.2'
this derivation will be built:
  /nix/store/phqfm6gn6k7ql57i27ypmnvdxmz21q03-krita-5.0.2.drv
  ....

If you rely on channels, you might want to watch https://nixpk.gs/pr-tracker.html?pr=170108

So, that means the PR is not in that channel yet? If it's that, good to know, didn't know that tool.

Yes, channels that are not -small usually lag by roughly one day.


Add 'dashes' option for camelCase

The css-loader camelCase parameter takes a new option called dashes, which only camelizes dashes in the resulting module. This is handy if you have classes starting with an upper case.
Example
.My-class {
  color: red;
}

My webpack.config contains the following rule:
{
  loader: 'css-loader',
  options: {
    // Enable CSS modules
    modules: true,
    // Export Classnames in CamelCase
    camelCase: 'dashesOnly',
  }
}

Which creates a css module object like this
{
  MyClass: '....'
}

With this pull request, we can configure the typed-css-module loader the same way:
{
  enforce: 'pre',
  test: /\.css$/,
  exclude: /node_modules/,
  loader: 'typed-css-modules-loader',
  options: {
   camelCase: 'dashesOnly'
  }
}

It seems cool ! thanks :)

Wuhuu 😍 do you know when you will release this?

I've already released it as v0.3.0 👍

Awesome 😎


Creating a BART GitHub Wiki

Would there be interests for creating GitHub Wiki pages for BART ?
I know that BART comes bundled with some documentation, but making that available directly from the GitHub repository might be more convenient for users looking to troubleshoot common problems.
As an example, I have written a small page on building pyBART after a question I got from @jtamir (pyBART wiki). If there is interest, I could expand that to include a detailed description of the CMake build system (I personally don't use the Makefile...). This could be a good addition to the existing website but more focused towards building BART.

Well, in principle yes. But I will be able to move BART a way from Github at some point... so everything which could lock me into the Github platform is a no go.   All the issues stuff already starts to annoy me...

Actually, the content of all GitHub wikis are easily downloadable since they are themselves also Git repositories. Additionally, they are nothing more than text files in Mardown format (or similar), so you should be able to very easily port them to other platforms.
Anyway, I will slowly develop the wiki on my fork of BART (covering the areas that I know well enough). Feel free to add parts of it to the official BART project  if you feel that it is worth it.


This is a Test PR and after raising it, I will be closing it.

Action And Func Delegates Demo This is a Test PR and after raising it, I will be closing it.

Closed


Without italics

Thank you for your great theme !
Is it possible to build a version with all italics disabled?

Thanks, I'm glad you like it.
The new version I just published (0.6) now includes a variant of each theme with italics disabled.
VS Code has some default styles and I cannot disable them in one place, so just let me know if you find any italics that I missed.

Thank you very much !


Add support for the Nimble (nim) package manager

Add support for the Nimble dependency manager to the analyzer module.
See also https://github.com/nim-lang/nimble
To implement Nimble support in ORT, we need several things things:

ability to detect whether a project is using Nimble

If a project has an .nimble then it likely a Nim-based project. Can use this files for globsForDefinitionFiles

declared license for a package

See license in .nimble. Furher research need to determine how to read-out the package name, version and license from .nimble file

source code location of the package (VCS location + revision, package source code/binary artifact)

.nimble files do not defined source code location but we could download and parse https://github.com/nim-lang/packages/blob/master/packages.json which contains central listing of all packages for Nimble and then query Git tag to determine the revision / SHA1 for a specific version.

dependency tree including package name, version

No dependency tree option found in Nimble's docs but believe we can use nimble list

Example Nim project that can be used to test Nimble support

Maybe use https://github.com/PMunch/nimlsp/blob/master/nimlsp.nimble? or pick another package from https://github.com/nim-lang/packages which contains central listing of all packages for Nimble

For known scopes I propose we use by default requires for dependencies.
No plugin should be required/to be installed in order to analyze Nimble based projects

Closed as part of backlog grooming. Feel free to comment if you would like to contribute to this.


Is there any plans to deverlop an agent for lua ？

Which module is your feature request related to?
Plugin/UI etc
Is your feature request related to a problem?
A clear and concise description of what the problem is.
Describe the solution you'd like
A clear and concise description of what you want to happen.
agent for lua
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Is there any plans to deverlop an agent for lua ？

Unfortunately we have no plans.


Production app only works when the homepage is left blank

App with the problem.
Using pushstate-server the browser looks for a non-existent /proverb-generator/static/js/main.916a0ac9.js file when my package.json says
...
"homepage": "http://timurtu.github.io/proverb-generator"
...

It loads when I build leaving the homepage blank
...
"homepage": ""
...

Using __https://github.com/timurtu/proverb-generator__ as the homepage property fails with the same error.
I saw a similar issue where it will only work with http but this error still occurs after removing the s.

Probably a duplicate of https://github.com/facebookincubator/create-react-app/issues/1335?

If you build for GH Pages you can’t use pushstate-server locally like this. It will assume files exist at / whereas they exist at /proverb-generator. For now this is working as designed: you can either build for / path (and use pushstate-server) or build for /proverb-generator (and deploy to GH Pages).
I know this is not super convenient and we’ll need to look into it again as part of solving https://github.com/facebookincubator/create-react-app/issues/1094. Please subscribe to that issue if you’re interested.
I’m closing this specific issue since it is not actionable at the moment. This is just how it works right now.


HADOOP-19115. Upgrade to nimbus-jose-jwt 9.37.2 due to CVE-2023-52428. (#6637)

Description of PR
HADOOP-19115 - backport to 3.4
How was this patch tested?
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-3.4 Compile Tests _

+0 :ok:
mvndep
4m  3s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 39s

branch-3.4 passed

+1 :green_heart:
compile
9m  3s

branch-3.4 passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
8m 24s

branch-3.4 passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
mvnsite
12m 48s

branch-3.4 passed

+1 :green_heart:
javadoc
4m 41s

branch-3.4 passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
4m 49s

branch-3.4 passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
shadedclient
29m 21s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
18m 14s

the patch passed

+1 :green_heart:
compile
8m 43s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
8m 43s

the patch passed

+1 :green_heart:
compile
8m 20s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
8m 20s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
8m 46s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
4m 40s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
4m 49s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
shadedclient
30m 18s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
618m 57s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
1m  4s

The patch does not generate ASF License warnings.

791m 20s

Reason
Tests

Failed junit tests
hadoop.hdfs.protocol.TestBlockListAsLongs

hadoop.hdfs.server.datanode.TestLargeBlockReport

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6682/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6682

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs

uname
Linux 85ea4734d0f2 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.4 / df3bd0e04c3c29a0893707c12817e1da8030a38a

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6682/1/testReport/

Max. process+thread count
4157 (vs. ulimit of 5500)

modules
C: hadoop-project . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6682/1/console

versions
git=2.25.1 maven=3.6.3 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

LGTM +1.


Python bindings

Recently (branch devel) I decided to use talsh::Tensor instead of TensorDenseBlock in tensor_method.hpp (inside TensorMethod interface which is now called TensorFunctor). Consequently, I went inside exatn-py.cpp and replaced TensorDenseBlock with talsh::Tensor, which necessitated inclusion of talshxx.hpp, which in turn includes talsh.h, whic is a C header with many symbols in GLOBAL scope. This C part did not build in exatn-py.cpp. So I got rid of it. But now it does not look like I can refer to talsh::Tensor in the Python bindings (see commented block there). What would a solution be here?

I just uncommented the TensorFunctor py::class code and added talshxx and tensor_method to the includes, and it built for me, no C errors

To use this, we will need to expose talsh::Tensor (or at least some of its API) to Python in exatn-py.cpp. I can handle this.
It would be helpful though to see a full example of using TensorFunctor and the numerics API. Can you put that together?

Ok, let me try to rebuild from a clean state ...

I had to add a new argument "tag" to exatn::NumServer::registerTensorMethod() in order to distinguish different functors of the same class. We need to correct Python binding for this function. I also added registerTensorMethod, getTensorMethod, registerExternalData, getExternalData, and getLocalTensor to high-level exatn_numerics.hpp header. We need Python bindings for these.

I almost finished the mechanism for getLocalTensor() API. I had to modify the interface for this function such that it returns a std::future<std::shared_ptrtalsh::Tensor> now. Please check consistency of Python bindings for this API function.

Actually just realized that I will need to modify it again to return std::shared_ptrtalsh::Tensor, so let's hold on on it.

Ok, fixed, please check exatn::getLocalTensor() and exatn::NumServer::getLocalTensor() interface. This is its final version. We need to Pybind it properly such that numpy array is returned instead of talsh::Tensor.


Update metadata plugins

CLOUDBLD-8265

For details, please refer to each commit message.
Maintainers will complete the following section

[x] Commit messages are descriptive enough
[x] Code coverage from testing does not decrease and new code is covered
[x] Python type annotations added to new code
[x] JSON/YAML configuration changes are updated in the relevant schema
[n/a] Changes to metadata also update the documentation for the metadata
[n/a] Pull request has a link to an osbs-docs PR for user documentation updates
[n/a] New feature can be disabled from a configuration file

LGTM, the code is much more readable now! :tada:
Just a couple minor comments

The build-osbs-components is still unavailable. I'm going to merge this pr for now.
@chmeliik Keep these 18 commits :sweat_smile:


Incompatibility with open parties and claim mod

This mod conflicts with the open parties and claim mod, as a result it is not possible to see the information. This happens when you claim a chunk area and you are in that area.

Should be fixed in 1.4.14


CM-747: Select a Dropdown Option Using Selenium WebDriver in C#

Hello @semirteskeredzic,
I am not able to run the test locally, is there anything specific I should do before running the test, apart from running the app?
OpenQA.Selenium.WebDriverException: unknown error: result.webdriverValue.value list is missing or empty in Runtime.callFunctionOn response

Hi @karimkod , the issue probably lies in the discrepencies of the drivers e.g Google Chrome installed on the machine is probably 119...* while ChromeDriver is 118...*
The same applies to Edge. You can also change VersionResolveStrategy of the browserVersion from Latest to MatchingBrowser.
For reference: https://stackoverflow.com/questions/77428873/im-getting-this-error-unknown-error-result-webdrivervalue-value-list-is-missin

@karimkod , I've retested on my M1 machine and can't replicate the issue.
Google Chrome version was 116. and chromewebdriver was 118. I updated the Chrome on my machine to 119 and still couldn't replicate the issue.
Then I updated all packages to latest versions and still all tests pass. I then moved to Win11 machine and again weren't able to replicate the issue. To be on the safe side I've updated the edgewebdriver and added the driver for windows machines.
Please pull the latest code, build, run and test and let me know if you continue to have issue.

Thanks @semirteskeredzic, it's seems like the issue is fixed.


ndarray.argmax_channel function location

Hi ,
could anyone tell me where the ndarray.argmax_channel is defined? I got some type issue and stuck here.
Thanks

@Godricly https://github.com/dmlc/mxnet/blob/master/src/operator/broadcast_reduce_op-inl.h#L460-L465

ah.. Thank you. I was looking for it under ndarray folder. One more question on this, how is the result memory allocated? I got a exception of different type on some kind of memory copy between different devices.

@Godricly I think it should be allocated on the same context as the input?

The problem I have not is that asnumpy function. Somehow, it's trying to give a float type ndarray while I'm using double now. And  this exception is given. I tried to add some print and nothing was printed after this WaitToRead.
The most confusing thing is that I won't counter this problem when using one GPU. It only fails when I'm using more GPUs.

kvstore issue.


App service public access still enable

When following the tutorial, the app service, public access is still enable which means that the website is available outside of the vnet which contradict the tutorial. Need to disable the public access in order to block any connection outside the vnet

@yaronpri Thank you for the feedback. It looks like they changed the behavior when you enable a private endpoint.  It used to disable public access automatically, now is not the case.  Good catch.
#sign-off


Remove version: qBittorrent.qBittorrent version 4.6.2

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://sourceforge.net/projects/qbittorrent/files/qbittorrent-win32/qbittorrent-4.6.2/qbittorrent_4.6.2_lt20_qt6_x64_setup.exe/download
Status Code: 200
(Automated message - build 896)

Close with reason: Package still available.;


Add 404 error page

@apoorvaron  error page is not added in this project , i am intrested to it so @apoorvaron please assign it to me

Assigned ! Start Contributing

yay ! sure working...

@PatilHarshh Are you still working ?

Yes I am working, just about to pr , due to my college submission little late sorry!

@PatilHarshh Okay

hello @apoorvaron facing little issue can you provide discord handle

@PatilHarshh   apoorvaron

@PatilHarshh update ?

@apoorvaron yes working, working on your idea as you said... to update using db uri

@PatilHarshh When will you create PR?

@apoorvaron unfortunately it closed

raising another pr

ok

@PatilHarshh I am unassigning you because of inactivity
@Mrprayag077 do you want to work on this ?  Now you just have to create a 404 page (I have the coding part)

@apoorvaron bro i have already complete all task ! adds the error page which suits to UI ! ... But Ok  your wish further!

@PatilHarshh I am unassigning you because of inactivity
@Mrprayag077 do you want to work on this ? Now you just have to create a 404 page (I have the coding part)

ya sure i will love to contribute 😃

@PatilHarshh i can't keep asking for update. Check this out (https://github.com/apoorvaron/Shorty/pull/268)

@PatilHarshh I am unassigning you because of inactivity
@Mrprayag077 do you want to work on this ? Now you just have to create a 404 page (I have the coding part)

ya sure i will love to contribute 😃

@Mrprayag077 Assigned. Take pull from main branch , i have added code , just create a 404.php and change the code in /shorty/index.php file for redirection

sir the ISSUE is not assigned to me till now? could u plz check

@Mrprayag077 done

I have created two themes plz check which should I apply. @apoorvaron
https://github.com/apoorvaron/Shorty/assets/99162236/3ab48af2-796c-4ac9-960a-bbe39073f4c4

@Mrprayag077
in first one , color is not matching
in second one , Dog seems. not good & not available star js

have a to this pages... i feel this are matching to theme
1

2

3

@Mrprayag077
2 , https://codepen.io/nhatanh17/pen/VwwVmLK
Don't just copy n paste , do some your creativity also

Features:
Redirect to the home page.
anything searched input box will search inside the domain only.
responsive for all devices.
https://github.com/apoorvaron/Shorty/assets/99162236/30891988-9f5f-413d-a881-67e515669161

@Mrprayag077
2 , https://codepen.io/nhatanh17/pen/VwwVmLK
Don't just copy n paste , do some your creativity also

I have told you that, I go with the second one not this you have implemented

@Mrprayag077
2 , https://codepen.io/nhatanh17/pen/VwwVmLK
Don't just copy n paste , do some your creativity also

I have told you that, I go with the second one not this you have implemented

ohhhhh ... i took it wrongly. ok i will work on 2nd

ok

@Mrprayag077 if you are adding search bar then make it proper like

good view of drop down (the previous "home" was not good enough)
if i click the home in drop down , it must directly redirect me to home page without directing to another google page

I have made changes you can check the changes. @apoorvaron
Sorry for the late changes.
https://github.com/apoorvaron/Shorty/assets/99162236/ea769673-d4a3-4c58-a83a-5bb374747974

@Mrprayag077 Mobile view ?

i think the moon looks good. so i have kept it in mobile view too
https://github.com/apoorvaron/Shorty/assets/99162236/44b1bf91-8f10-492a-9e6e-e2bd8dd7c4bc

@Mrprayag077 make PR i will request the changes if required


Mobile integration

Is there any mobile integration for AR stuff? (React-Native, Kotlin or Swift)

I've tried to run onnx model on react native, it's still quite slow

@hungtooc may you share the implementation code? I'd like to try it out.

@rkz98 here is react native code:
import { InferenceSession, Tensor, } from "onnxruntime-react-native";
// const IMAGE_PATH = "/assets/data/beach.jpg";
const IMAGE_EMBEDDING = "/assets/data/beach_embedding.npy";

const App = () => {
  const [model, setModel] = useState<InferenceSession | null>(null); // ONNX model
  const [tensor, setTensor] = useState<Tensor | null>(null); // Image embedding tensor

  useEffect(() => {
    // Initialize the ONNX model
    const initModel = async () => {
      try {
        const model = await InferenceSession.create('file://' + RNFS.DocumentDirectoryPath + '/sam.onnx');
        console.info(model.inputNames)
        setModel(model);
      } catch (e) {
        console.log(e);
      }
    };
    initModel();

    // Load the Segment Anything pre-computed embedding
    Promise.resolve(loadNpyTensor(IMAGE_EMBEDDING, "float32")).then((embedding) => {
      console.info("embedding.dims", embedding.dims)
      setTensor(embedding)
    });
  }, []);
const loadNpyTensor = async (tensorFile: string, dType: string) => {
    // notice I created fake data
    const data = new Float32Array(256 * 64 * 64);
    const tensor = new Tensor("float32", data, [1, 256, 64, 64]);
    return tensor;
  };
## end of init

useEffect(() => {
    console.info("runONNX once")
    if (model && tensor)
      runONNX(model, [{
        clickType: 1,
        x: 150,
        y: 150
      }], tensor, {
        samScale: 1.28,
        height: 640,
        width: 480
      });
  }, [state]);

}

any way to also generate the embeddings on mobile?

I am trying to integrate it on flutter plugin. is it possible?

You can find the converter for the encoding part to the onnx format in the repository Segment Anything CPP Wrapper.
Here is the Segment Anything CPP Wrapper for macOS.
This code is originated from Segment Anything CPP Wrapper and implemented on macOS app RectLabel. We customized the original code so that getMask() uses the previous mask result called as low_res_logits and retain the previous mask array for undo/redo actions.
We hope this macOS version would help to develop the iOS version.
Please let us know your opinion.