Add support for listener callbacks

This PR implements the new listener-related functions that were introduced by #44.
Signed-off-by: Andrea Sorbini<EMAIL_ADDRESS>

Linux CI with only Connext enabled for initial validation:

Linux CI with only Connext enabled for initial validation:

I investigated the failures, I believe the issues lie either in some test problem or they are unrelated to this PR (and they manifested because I ran CI with just this RMW enabled, which usually doesn't happen).

rclcpp.TestSubscription.on_new_message_callback: in the last case, the test only waits while c3 == 0 while instead the loop should continue for as long as c3 < 3.
rclcpp.TestWaitForAllAckedWithParm/TestPublisherWaitForAllAcked.check_wait_for_all_acked_with_QosPolicy/0: unrelated issue. Problem is with the test which only waits for 500ms to receive an ACK. Connext's default settings use a 3s periodic heartbeat, which may cause the ACK not to be received within the timeout. Increasing the wait to 6s makes the test pass consistently.
rclpy.rclpy.test.test_client.TestClient.test_service_timestamps: unrelated problem. The issue lies with the test which doesn't take into account the possible return value (None, None) which indicates a successful take_request() with no request actually taken (i.e. an "empty polling" of the requests)..
launch_testing_examples.launch_testing_examples.check_node_launch_test and launch_testing_examples.launch_testing_examples.set_param_launch: unrelated issue. It seems like the failures can be avoided by increasing the wait timeout or by configuring Connext to more quickly repair samples on topic "ros_discovery_info".
Errors in rviz_rendering seem to be unrelated to the RMW layer because they occur also with other RMW implementations.

rclcpp.TestSubscription.on_new_message_callback: in the last case, the test only waits while c3 == 0 while instead the loop should continue for as long as c3 < 3.

Could we fix that test?
It's directly related to the listener callbacks API, so it would be good to get it fixed to make sure that's the only issue.

Could we fix that test? It's directly related to the listener callbacks API, so it would be good to get it fixed to make sure that's the only issue.

I opened ros2/rclcpp#1900 to fix the unit tests.

Could we fix that test? It's directly related to the listener callbacks API, so it would be good to get it fixed to make sure that's the only issue.

I opened ros2/rclcpp#1900 to fix the unit tests.

Also opened ros2/rclcpp#1901 to fix the issue with the wait_for_acknowledgments() test.

Looks good to me, I just want to confirm how the notify_new_data function works exactly.

@clalancette @ivanpauno can this PR be merged now even with the freeze? It doesn't change API/ABI.

@clalancette @ivanpauno can this PR be merged now even with the freeze? It doesn't change API/ABI.

Hi @asorbini, I don't think we should merge this because it is a feature addition and the freeze is in place. If it doesn't break API/ABI, it should be able to be added in a patch release.

Did anyone ever test this PR with irobot's events executors? https://github.com/irobot-ros/events-executor
If I run their tests with rmw_connextdds enabled and these changes here applied to the rmw_connextdds humble branch, I get these kinds of errors/warnings:

This PR is needed though, if one is trying to use events executors with connextdds. It would be nice if someone could have a look at this issue.

#109 fixes the issue with the events executors.

@asorbini FYI we recently opened the PR for the events-executor in rclcpp and we currently have disabled it from running with connext.
To test this PR you can easily remove the "if connext -> skip" parts of the tests
https://github.com/ros2/rclcpp/pull/2140

@alsora thank you for the heads up, that's very useful to validate these changes.
Do you have a .repos file that I can use to test that PR or is it just those rclcpp changes + current rollng?

What's the status of this PR? Given that https://github.com/ros2/rclcpp/pull/2155 is merged now, it would be really greate to have this PR "officially" approved and merged in order to use rclcpp with ConnextDDS to it's full potential out of the box.

What's the status of this PR? Given that ros2/rclcpp#2155 is merged now, it would be really greate to have this PR "officially" approved and merged in order to use rclcpp with ConnextDDS to it's full potential out of the box.

At this point, it needs another approval (there have been changes since the previous ones), and CI run on it.  I can do the latter, but I'd prefer @asorbini or @alsora did another review/approval first.

I'm not really familiar with connext, but overall the PR looks sane.
From my perspective I would suggest to create a rclcpp branch where the checks that disable events-executor with connext are removed, and then, if it passes all unit-tests, it should be good to go.

@alsora here is the PR to enable the callback groupd tests in rclcpp again: https://github.com/ros2/rclcpp/pull/2182

The tests reenabled in https://github.com/ros2/rclcpp/pull/2182 are now succeeding. Although they seem to be somewhat flakly, I'd suppose, that this PR should be mergable now?

Although they seem to be somewhat flakly, I'd suppose, that this PR should be mergable now?

We'd really prefer to not merge in "somewhat flaky" tests.  We are just down to handful of those now, and I'd like not to increase that number.


Ft/s3 c 1183/gcp tagging

Review: d19262edf2c0fd1ae98bdb1c471a9f619d154a4b

PR has been updated. Reviewers, please be cautious.

PR has been updated. Reviewers, please be cautious.

PR has been updated. Reviewers, please be cautious.

PR has been updated. Reviewers, please be cautious.

PR has been updated. Reviewers, please be cautious.

PR has been updated. Reviewers, please be cautious.

PR has been updated. Reviewers, please be cautious.

PR has been updated. Reviewers, please be cautious.

@ironman-machine
DEFAULT_BRANCH=rel/7.4
SCALITY_INTEGRATION_BRANCH=test/zenkobb
SCALITY_FEDERATION_BRANCH=ft/S3C-1114/GCP-BACKEND
SCALITY_S3_BRANCH=ft/S3C-1183/GCP-Tagging
try

Hello @alexanderchan-scality
"DEFAULT_BRANCH=rel/7.4": Success
"SCALITY_INTEGRATION_BRANCH=test/zenkobb": Success
"SCALITY_FEDERATION_BRANCH=ft/S3C-1114/GCP-BACKEND": Success
"SCALITY_S3_BRANCH=ft/S3C-1183/GCP-Tagging": Success
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/19560' with the following env. args:
{
    "DEFAULT_BRANCH": "rel/7.4",
    "SCALITY_S3_BRANCH": "ft/S3C-1183/GCP-Tagging",
    "SCALITY_INTEGRATION_BRANCH": "test/zenkobb",
    "REPO_NAME": "S3",
    "SCALITY_FEDERATION_BRANCH": "ft/S3C-1114/GCP-BACKEND"
}

:broken_heart: :umbrella: circleCI test failed.

PR has been updated. Reviewers, please be cautious.

@ironman-machine
DEFAULT_BRANCH=rel/7.4
SCALITY_INTEGRATION_BRANCH=test/zenkobb
SCALITY_FEDERATION_BRANCH=ft/S3C-1114/GCP-BACKEND
SCALITY_S3_BRANCH=ft/S3C-1183/GCP-Tagging
try

Hello @alexanderchan-scality
"DEFAULT_BRANCH=rel/7.4": Success
"SCALITY_INTEGRATION_BRANCH=test/zenkobb": Success
"SCALITY_FEDERATION_BRANCH=ft/S3C-1114/GCP-BACKEND": Success
"SCALITY_S3_BRANCH=ft/S3C-1183/GCP-Tagging": Success
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/19563' with the following env. args:
{
    "DEFAULT_BRANCH": "rel/7.4",
    "SCALITY_S3_BRANCH": "ft/S3C-1183/GCP-Tagging",
    "SCALITY_INTEGRATION_BRANCH": "test/zenkobb",
    "REPO_NAME": "S3",
    "SCALITY_FEDERATION_BRANCH": "ft/S3C-1114/GCP-BACKEND"
}

:sunny: :+1: circleCI test succeeded!

The tests that I have written under raw-node are testing the gcp apis that I have implemented. These aren't yet plugged into S3.

PR has been updated. Reviewers, please be cautious.

increased the timeout for initiateMPU test: 16000ms -> 180000ms.

@ironman-machine
DEFAULT_BRANCH=rel/7.4
SCALITY_INTEGRATION_BRANCH=test/zenkobb
SCALITY_FEDERATION_BRANCH=ft/S3C-1114/GCP-BACKEND
SCALITY_S3_BRANCH=ft/S3C-1183/GCP-Tagging
try

Hello @alexanderchan-scality
"DEFAULT_BRANCH=rel/7.4": Success
"SCALITY_INTEGRATION_BRANCH=test/zenkobb": Success
"SCALITY_FEDERATION_BRANCH=ft/S3C-1114/GCP-BACKEND": Success
"SCALITY_S3_BRANCH=ft/S3C-1183/GCP-Tagging": Success
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/19585' with the following env. args:
{
    "DEFAULT_BRANCH": "rel/7.4",
    "SCALITY_S3_BRANCH": "ft/S3C-1183/GCP-Tagging",
    "SCALITY_INTEGRATION_BRANCH": "test/zenkobb",
    "REPO_NAME": "S3",
    "SCALITY_FEDERATION_BRANCH": "ft/S3C-1114/GCP-BACKEND"
}

:sunny: :+1: circleCI test succeeded!

As discussed, we can follow this up with a refactor PR to address these changes and add additional test cases for versioning.


Fixed order to get last tag

What?

Describe high-level what changed as a result of these commits (i.e. in plain-english, what do these changes mean?)
Use bullet points to be concise and to the point.

Why?

Provide the justifications for the changes (e.g. business case).
Describe why these changes were made (e.g. why do these commits fix the problem?)
Use bullet points to be concise and to the point.

References

Link to any supporting github issues or helpful documentation to add some context (e.g. stackoverflow).
Use closes #123, if this PR closes a GitHub issue #123

Before release
Review the checklist here

Closing


yolov2 sample

hi guys
is there any yolov2 sample to take advantage of rknn?
I don't know how to organize the output of the region layer of yolov2 on rknn

I also looking for yolov2 sample. I try use yolov5 demo on my pp-yolov2 model but there was many problem and no explicit solution.

I still has not found any sample and not attempt to implement yolov2 from yolov3's sample.
the support team should hep us.
@Caesar-github @JeffyCN


San Pablo CA

Can you add San Pablo CA to the roster of cities to email?

Hi @closetedstan, thanks for your interest in adding your city to the website. Emails on defund12.org are all written by community members. To add your city, you must provide:

Subject line for the email
Email addresses (at least one) of the government officials you’d like to receive the message
Detailed message concerning the budgeting decisions at stake in your community

Until you provide this content, we cannot post your city.
Follow our email style guidelines for quicker acceptance. Remember that messages must be city-specific and focused on defunding the police. If your message is copied from an external source, please provide a link to the original source.
Your request will be closed until you reply with the necessary content. Thank you!


Docs

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.72%. Comparing base (cfba4ae) to head (2f72bb8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   91.72%   91.72%
=======================================
  Files          13       13
  Lines         822      822
=======================================
  Hits          754      754
  Misses         68       68

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[DOCFIX] Clarify mounting in gluster/nfs docs

Rename the mount point to be more obviously a mount point since vol can mean something else.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10767/
Test PASSed.

Merged build finished. Test PASSed.

LGTM. Thanks for the clarification

alluxio-bot, check this please

LGTM


Not all links in MD are available the website

I have that in the docs: https://github.com/nf-core/sarek/blob/dev/docs/usage.md#--skipqc
But that won't work in the website: https://nf-co.re/sarek//docs/usage#--skipQC

Correct - it appears that if a heading contains only <code> then the automatic anchors don't work. I guess the code is stripping HTML tags first, so in this case strips the entire text.

Yeah, the problem is this regex: https://github.com/nf-core/nf-co.re/blob/79ebe9c4d5d27df3ca3f3a8fd55472058fe4b5e0/includes/header.php#L73


how to use images uploaded on Vercel on a block?

(Filling out the following with as much detail as you can provide will help us answer your question sooner.)
@slack/bolt version
"@slack/bolt": "^3.17.1"
Refer to your package.json
Your App and Receiver Configuration
e.g. const myApp = new App({ ... what options are you using? })
const expressReceiver = new ExpressReceiver({
signingSecret: env.SLACK_SIGNING_SECRET,
processBeforeResponse: true,
});
const app = new App({
logLevel: LogLevel.INFO,
receiver: expressReceiver,
authorize: async (args) => {
log.info("authorizing slack installation teamId %s", args.teamId);
const result = await features.slackAuthorize({ db }, args);
if (typeof result === "string") {
log.error(
"failed to authorize slack installation for teamId %s: %s",
args.teamId,
result
);
throw new Error(result);
}
return result;
},
});
Node.js runtime version
(Paste the output of node --version)
v18.17.0
Steps to reproduce:
(Share the commands to run, source code, and project settings)

Upload an image to Vercel Storage;

Try to use it on a block with the event app_home_opened as:
{
type: "image",
image_url:
"https://8t58pjbjalgqmf8j.public.blob.vercel-storage.com/slack-home-banner-KJDB1A5LFgVzjmGK5ikeMlATxkWVZS.svg",
alt_text: "graphic",
},

See error below.

Expected result:
(Tell what you expected to happen)
I would expect the image to render correctly.
Actual result:
(Tell what actually happened with logs, screenshots)
[ERROR]  web-api:WebClient:1 downloading image failed [json-pointer:view/blocks/0/image_url]
[10:40:11.655 PM]            error: An API error occurred: invalid_arguments {
"error": {
"code": "slack_webapi_platform_error",
"data": {
"ok": false,
"error": "invalid_arguments",
"response_metadata": {
"messages": [
"[ERROR] downloading image failed [json-pointer:view/blocks/0/image_url]"
],
"scopes": [
"app_mentions:read",
"channels:history",
"channels:join",
"channels:manage",
"channels:read",
"channels:write.invites",
"chat:write",
"chat:write.public",
"commands",
"groups:history",
"groups:read",
"groups:write",
"im:history",
"im:write",
"mpim:history",
"reactions:read",
"team:read",
"users:read",
"incoming-webhook"
]
}
}
}
}
Requirements
For general questions/issues about Slack API platform or its server-side, could you submit questions at https://my.slack.com/help/requests/new instead. :bow:
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

Hi @Kettss1, do you still encounter the same issue with one of the other supported file types?

hey! you're right, SVGs are not supported! i changed the image to be a PNG and it works. thanks so much!


Update import and export docs

@manthey I've fixed import docs if you want to take a look. I'll do export docs next.


Add timer for total time step and reformat timer output

This looks like:
Step: 1
  Tioga: 0.002000 0.002000 0.002000
  Total: 0.002000
Nalu-Wind step: 1
  Pre: 0.000000 0.000000 0.000000
  PreConn: 0.000000 0.000500 0.001000
  PostConn: 0.001000 0.001000 0.001000
  Register: 0.000000 0.000000 0.000000
  Update: 0.000000 0.000000 0.000000
  Solve: 0.158000 0.158000 0.158000
  Post: 0.003000 0.003000 0.003000
  Total: 0.162500
AMR-Wind step: 1
  Pre: 0.000000 0.000000 0.000000
  PreConn: 0.000000 0.000500 0.001000
  PostConn: 0.005000 0.005500 0.006000
  Register: 0.006000 0.006000 0.006000
  Update: 0.006000 0.006500 0.007000
  Solve: 4.898000 4.898000 4.898000
  Post: 0.000000 0.000000 0.000000
  Total: 4.916500
Total: 5.086000

Nalu-Wind Memory Usage min: -1 avg: -1 max: -1 total: -2
AMR-Wind Memory Usage min: -1 avg: -1 max: -1 total: -2

Step: 2

Actually maybe I need to do a reduction to make sure I account for every rank? Or are there MPI barriers that make that overkill?

As for the reductions... I think the barriers take care of it.

Looking at other codes...

AMR-Wind::Preconn                   1      3.992      5.264      6.484
[...]

Nalu-Wind also has the per equation timing output. It would be nice to have that also.

I think Marc's last table is probably what I would prefer in the end. I'm not sure I'm prepared to implement that at the moment, but that would be a good direction. However, I don't think this output is too difficult to parse:
% egrep -A 8 "AMR-Wind step" out.txt | grep Total | awk '{print $2}'
4.672500
4.803500
4.213500
4.129000
3.631500
3.895000
3.821500
3.866000
4.122500
4.044000

I think to get to that table will require a refactoring of how the timer output is currently done. I've been trying to work though it.

Actually, I can get it part of the way to the table and then will have to leave the rest for a refactor.

Sounds good. Also it's fine it you have other things to do, we can do it later too.

Ok it looks like this. I think this is as far as I'm going to go in this PR.
Exawind step: 9
  Exawind:    4.9210  4.9210  4.9210
  Total:      4.9210
  Tioga:      0.0010  0.0015  0.0020
  Total:      0.0015
Nalu-Wind step: 9
  Pre:        0.0000  0.0000  0.0000
  PreConn:    0.0000  0.0000  0.0000
  PostConn:   0.0020  0.0020  0.0020
  Register:   0.0000  0.0000  0.0000
  Update:     0.0000  0.0000  0.0000
  Solve:      0.1920  0.1920  0.1920
  Post:       0.0040  0.0040  0.0040
  Total:      0.1980
AMR-Wind step: 9
  Pre:        0.0000  0.0000  0.0000
  PreConn:    0.0010  0.0010  0.0010
  PostConn:   0.0080  0.0080  0.0080
  Register:   0.0080  0.0080  0.0080
  Update:     0.0050  0.0055  0.0060
  Solve:      4.7050  4.7050  4.7050
  Post:       0.0000  0.0000  0.0000
  Total:      4.7275
Nalu-Wind memory -- min: -1 avg: -1 max: -1 total: -2
AMR-Wind memory -- min: -1 avg: -1 max: -1 total: -2

@jrood-nrel For an output like the below, what would be the appropriate way to grep nalu-wind time totals for each instance ?
 We probably need some barriers or flushing to get the output ordered, or I guess would could just over-label each timer.


Builder factories

@rock3r I'd like your opinion in this.
Now that we have writer support, the current library API is not very Java friendly from a producer perspective. Some model data class have numerous fields, and populating them in Java is tiresome and error prone. Builders provide expressive construction, but are currently not part of the public API. I don't feel that exposing the entire builder implementation part helps improving the library usability.
This PR adds factory methods for builders to all model classes companion objects, following the example of how the Immutables library adds static factory methods to the immutable model class implementations.
This way it is easy to obtain a builder instance for each model, without exposing the builder implementation classes. The public API remains nice and clear. The model implementations get a bit crowded with all the companion objects, but these classes were rather cluttered before anyway.

LGTM now 👍


PG Flex Server authentication documentation is incomplete

I've set up an AAD group and added a matching Postgres role so I can authenticate with my db. In that group, I added myself and a service principal. In my node app, I was able to successfully authenticate as myself using @azure/identity -> AzureCliCredential with the scope https://ossrdbms-aad.database.windows.net. However, authentication failed when trying to use a service principal. After spending 4 hours looking through the AZ docs and random message boards, I finally found something saying that it actually should be https://ossrdbms-aad.database.windows.net/.default. This seemed to fix it, but the lack of documentation on this was frustrating.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 791277a5-0623-57d1-3f3a-1424acc9cb6f
Version Independent ID: 682f3fa1-7c23-ca12-e79e-7cde1ee7dad2
Content: Use Azure Active Directory for authentication with Azure Database for PostgreSQL - Flexible Server
Content Source: articles/postgresql/flexible-server/how-to-configure-sign-in-azure-ad-authentication.md
Service: postgresql
Sub-service: flexible-server
GitHub Login: @kabharati
Microsoft Alias: kabharati

@tasdflkjweio Thank you for sharing your feedback. We Apologize for this.
We will review ASAP and make an update if appropriate.

for me the issue is when I add the user directly on Azure Active Directory Administrators (Azure AD Admins) in PostgreSQL flex server authentication page the login is working, but when I add the AD group in there all the member under that group cannot login, I get the error => connection failed: FATAL: password authentication failed for user<EMAIL_ADDRESS>

I am having the same problem as @umairsyed613
When using an AD group, authentication always fails,  But when using an individual, it works.
FYI, this same configuration works for the standard Postgres server, just not on the flexible server.

@umairsyed613 @akitson-degreed are you using the group name to log in or the individual user's name? i think it needs to be the group name

@umairsyed613 @akitson-degreed - When logging using a group , you need to provide the group name but use your individual token as password.  Steps are documented here https://review.learn.microsoft.com/en-us/azure/postgresql/flexible-server/how-to-configure-sign-in-azure-ad-authentication?branch=main#use-a-token-as-a-password-for-signing-in-with-psql-or-pgadmin

Please feel free to re-open the issue if you have any other questions

#please-close


Update state hex map page

I don't know I generated the final image of original US map:

The colors are super saturated, and
The state abbreviations are a light color vs. black


[WIP] Fuse Interface

PR adds a fuse interface using the hdfs3 lib

[x] ls
[x] copy
[ ] move
[x] create
[x] delete

Setup

install fuse/libfuse
apt-get install libfuse2 fuse
yum install fuse fuse-libs.x86_64
mkdir hdfs_mnt
pip install fusepy
python hdfsfuse.py / hdfs_mnt/

ubuntu@ip-172-31-54-49:~$ ll /home/ubuntu/hdfs_mnt/
total 4
drwxr-xr-x  0 hdfs   hadoop 4096 Feb  5 22:13 ./
drwxr-xr-x 15 ubuntu ubuntu 4096 Feb  9 02:14 ../
drwxrwxrwt  0 hdfs   hadoop 4096 Feb  2 14:23 tmp/
drwxr-xr-t  0 hdfs   hadoop 4096 Feb  2 05:12 user/
drwxr-xr-x  0 hdfs   hadoop 4096 Feb  2 05:12 var/

I am getting RuntimeError: 1 - was there any additional setup aside from apt-get for fuse and pip install fusepy?

you will also need libfuse

yum install fuse-libs.x86_64
apt-get install libfuse2

You may also need to change the HDFileSystem() constructor to use the correct host:ip

To work in docker, required --cap-add SYS_ADMIN --device /dev/fuse on the docker run command.
Not yet complete, and no tests (it's bash stuff), but I encourage people to play. Move may already work, and append should not be difficult.


[Bug] Problem with show my card in creators

My card doesn't show in creators section. Also, I completed all links needed in my profile, But my card doesn't show up yet!
Please help me to fix it.

Yea, that will be fixed once we have your feed completely working. "Creator's" are currently identified by having a proper feed.

Yea, that will be fixed once we have your feed completely working. "Creator's" are currently identified by having a proper feed.

My feed now is ok and I checked my rss feed and it was ok and healthy. It doesn't have any problem. But in the creators section, But still my section is not shown!

Had a few busy days but gonna check that to orrow again, ill get that sorted

Had a few busy days but gonna check that to orrow again, ill get that sorted

Thanks.

@meysamhadeli got your feed indexed properly now, i did not force a cache refresh but it should be there in an hour or two


Use without composer

Hi,
is any way to use it with PHP without composer?

The question is: why not use composer? If you can't install it on a production server, just copy all the required files over from your local install and you don't need to run it there.

I want run it just with cURL and a simple php framework like codeigniter. Just want to do a small thing.

Can't really help you with that then... composer installs are the de-facto standard for PHP right now for some time. It's not really a big library, and it works on all OSes, so just go and get it.

Composer is the way to go. Closing this.


Docker Extension for GenAI Stack

How about building a Extensions for GenAI Stack?

Which tech stack will be used to build this extension?

@StarTrooper08
Frontend - React, TypeScript, MaterialUI
Backend - Node, Golang
Here's a complete blog post that shows how to build it from Scratch https://collabnix.com/how-to-build-a-docker-extension-from-the-scratch/

Hey @ajeetraina , I am on to building this up. Idea is to introduce LLMs into Monitoring data through the GenAI stack. Would love to have your thoughts at this. Do let me know if we can continue this conversation at a better place.
Thanks


tasklaunchrequest-transform - incorrect app type

On importing apps from http://bit.ly/Avogadro-SR1-stream-applications-rabbit-maven, tasklaunchrequest-transform gets listed as sink however it should get listed as processor. Because of this following exception gets thrown on deploying the stream,
Command failed org.springframework.cloud.dataflow.rest.client.DataFlowClientException: failed to resolve MavenResource: org.springframework.cloud.stream.app:tasklaunchrequest-transform-sink-rabbit:jar:1.1.1.RELEASE. Configured remote repository: REPO1_URL

This is addressed in Bacon.RELEASE -> http://bit.ly/Bacon-RELEASE-stream-applications-rabbit-maven


Add Snips

This company is a great example of humane technology. Their idea is to make our interaction with technology more natural (through speech) while at the same time campaigning for what they call Privacy by Design.
I am not sure why GitHub added a newline character at the end of the file after the edit.

@aschrijver Friendly ping :)

@aschrijver That makes sense. Thanks for explaining!

Thanks @johnjago !


xClusterPreferredOwner: The resource is moving cluster group in Set-TargetResource

When setting preferred owner on a cluster group or a cluster resource it moves the cluster group to the first node. In a production environment this could be a bad thing.
See line 98-99
        Write-Verbose -Message "Moving Cluster Group $ClusterGroup to node $($Nodes[0])"
        $null = (Get-ClusterGroup -cluster $ClusterName) | Where-Object {$_.name -like $ClusterGroup} | Move-ClusterGroup -Node $Nodes[0]

Why is it moving the cluster group? And if this is a must, then I think this should be handled differently.

Is it meant to move to the preferred owner, if that owner is not the preferred? But that should not be up to the resource, would it?

I don't think you want a resource to fight with what the cluster service is doing. Just have it configure the setting and leave it alone would be best IMO.

I agree.


[token-upgrade] Remove deprecated functions from cli

Problem
Solana clap-v3 utils deprecated a number of functions with version 1.18. https://github.com/solana-labs/solana-program-library/pull/6278 temporarily suppresses the warnings from deprecated functions.
Solution
Remove the deprecated functions from the cli.

Resolved with #6526


feat(api-key/backend): introducing support for api-key based auth EE-978

Addresses backend implementation for EE-978.
features

Prefixing generated api-keys with ptr_
Endpoint to generate user access token (api-key)

This endpoint requires JWT auth (api-key auth cannot be used to create more api-keys)
An admin user cannot generate api-keys for other users

Endpoint to retrieve all user access tokens
Endpoint to revoke existing user access token
Tests for all the functionality above
APIKey middleware to authenticate and authorise x-api-key based requests

note: the key can be present in request header or as query param (similar to JWT auth)

APIKey caching to improve middleware performance (api-key -> user mapping lookups using LRU cache)

Example
# generate user api access token (api-key)
curl -X POST \
  -H "Authorization: Bearer $(curl 'http://localhost:9000/api/auth' -d'{"username":"admin","password":"admin123"}' --compressed | jq -r '.jwt')" \
  -d '{"description": "github-api-key"}' \
  http://localhost:9000/api/users/1/tokens

# get user api access tokens (api-keys)
curl \
  -H "Authorization: Bearer $(curl 'http://localhost:9000/api/auth' -d'{"username":"admin","password":"admin123"}' --compressed | jq -r '.jwt')" \
  http://localhost:9000/api/users/1/tokens

# remove a user's api access token (api-key)
curl -X DELETE \
  -H "Authorization: Bearer $(curl 'http://localhost:9000/api/auth' -d'{"username":"admin","password":"admin123"}' --compressed | jq -r '.jwt')" \
  http://localhost:9000/api/users/1/tokens/1

# use api-key auth (generated access token) to get all user access tokens
curl \
  -H "x-api-key: vEMa4rwbWWL308KJG1D9NWe/h03tVUQsk78+ubwEr4k=" \
  http://localhost:9000/api/users/1/tokens

Closes https://github.com/portainer/portainer/issues/813


Splice considered argument out of process.argv

Such that downstream argument parsers need not consider these patterns.

I don't think a module like this should magically remove arguments. Keep in mind that this module is mostly included implicitly and it would create some rather unexpected behavior.
// @jbnicolai

I can buy that argument. What do you think about ignoring options after the option terminator?

Not sure what you mean, can you elaborate?

By convention, option parsers ignore all arguments after a -- argument with no flag, e.g., rm -- -f would delete a file named -f.

Yes, I agree. It should ignore that.

I agree that the options terminator (--) should be respected. This could be achieved with a single regular expression though, instead of several indexOf checks.

I don't think a module like this should magically remove arguments. Keep in mind that this module is mostly included implicitly and it would create some rather unexpected behavior.

Tough call! From an academic / architectural standpoint I agree that the flags should be 'consumed' and not propagate to other modules. From a practical standpoint I think you're right, Sindre, and we shouldn't introduce unexpected behaviour.
Seems like we both agree only to go for the options terminator part of the PR. @kriskowal would you like to rebase, create a new PR, or have me pick that up?

I would suggest something like:
var  flags = argv.replace(/ -- .*/, '');

if flags.match(/--(no-colors?|color=false)\b/g) {
  return false;
}

if flags.match(/--(colors?|color(=true|=always)?)\b/g) {
  return true;
}

@jbnicolai Can you do a PR?

Closing in favor of #26.


Saving interactive setup output to a file that can be run later

To run: bash ~/myopenaps/oref0-runagain.sh

Worked great.  Thanks!


feat: make host configurable

Thanks!

Oh I missed the translation. Thank you for your help!

Docker's hint also applys to PORT

Docker's hint also applys to PORT

🤔 I'll add it in the next document revision.


The "group_id" property doesn't correspond with the grouped objects

My actions before raising this issue

[x] Read/searched the docs
[x] Searched past issues

Expected Behaviour

To find out what's wrong with the group_id in the attached xml file
Current Behaviour

Noticed that some grouped objects don't  have the same group_id.
For example, I've attached the xml file with annotations.
Track ID 13 and 82 are grouped, but they have different group_ids:

In the same time if we search the objects which have the group_id 71 we will find the following:

But the track IDs 13 "person" and 101 "face" have different group colors when we use the "color by group" view. It must mean that they aren't grouped.

Operating System and version (e.g. Linux, Windows, MacOS):
Code example or link to GitHub repo or gist to reproduce problem:
Other diagnostic information / logs:
Logs from `cvat` container

Next steps
You may join our Gitter channel for community support.

task_rbhe_people_1_mall-24mm-300_lux-2.mp4_test-2020_06_08_15_51_43-cvat for video 1.1.zip

I haven't been able to reproduce this issue. I will close this issue. Reopen it if you have this problem please.


Better handle markdown headings when editing issues

#197 took care of being able to use # at the start of a line, but I just noticed that there isn't a great user flow for editing an issue that already has markdown headings.

Create an issue with at least 1 heading
Edit the issue with lab issue edit [ID]
Make changes and save
The issue will now have its heading(s) stripped out

I'm not sure what the best course would be, but perhaps requiring escaped hashes wasn't the best solution for #197.

Haha, yeah I've been thinking about this a lot myself lately, interesting to see you bringing it back up. I'm really not sure what the best way to differentiate markdown from git comments when the default comment char # is used.
Personally I have no interest in changing the comment char in git myself, so I'd like to find a solution that just works.

It's definitely an interesting problem since it's not likely that people mix these two formats often. I'll have a look around and see if I can think of anything.

I think in an edit context, I'm loading text that won't have comments. So perhaps could escape them all on load. Thoughts?
... Tired -- not sure if making sense

I think you're making sense, and that's the approach I was going to
suggest. For the time being, there's always :%s/^#/\\#/g

I was going to suggest something similar, but escaping them on application exit instead. That way you could edit as if it's normal markdown and lab would just handle things for you.

fix #314: --version not showing lab version
# ------------------------ >8 ------------------------
# Do not modify or remove the line above.
# Everything below it will be ignored.

Requesting a pull to zaquestion:master from zaquestion:fix_version_flag

Write a message for this pull request. The first block
of text is the title and the rest is the description.

https://github.com/github/hub/blob/12083a59317dc879f26e2464974f175d4fd0a85b/github/editor.go#L86-L93 They read the content literally until the "scissors" line and then discard everything below it. So lines that begin with # above the scissors line aren't removed.
# ------------------------ >8 ------------------------

Oh, that makes sense! That seems like a good solution, but the scissors line probably doesn't even matter unless lab was to include some instructions underneath it. If everything below that line is ignored, then the only reason for including it is to include some sort of prefilled message to the user. lab could just interpret things literally, the way that hub handles whatever is above the line. But like I said, it would probably be good to include instructions anyway.

In an edit context it probably doesn't make as much sense, because yeah, there might now be in other information to show. The cutline would mostly be useful for the create flows which include instructions at the bottom and a summary of commits when creating merge request.

I think the biggest thing I got from the hub code is that it isn't relying on the git mechanism for editing the MR/Issue text. It just opens up an editor window and waits for it to be closed. Is there a reason that lab does this differently?
(Sorry if my vagueness is hard to follow and/or just totally incorrect... I still only partially understand what lab is doing under-the-hood since I'm not a golang dev and haven't spent the time to fully grep through the codebase.)

@jwkicklighter lab essentially operates the same way, in fact the implementation in lab was inspired by hubs own implementation. It looks like they've moved ahead and we're still like this. In large tho, we open the editor and wait for it to close. We store the file being edited within .git/, but I believe hub does the same (or at least the used to). At this point I think adjusting our implementation to use a cutline is the right way to go as it address this issue updates our behavior to be similar to hub

@zaquestion Let me know if there's any way I can help, since I keep bringing up these issues 🙂

It's pretty much just a matter of swapping in the hub logic, which shouldn't be too bad. LMK if you wanna try and take on implementation, I'm also talking with a potential new contributor and pointed them at this, but I'm not sure yet if they'll take it on, they might jump in somewhere else. So feel free to tackle it, it'll happen soon enough for sure.
hub impl: https://github.com/github/hub/blob/12083a59317dc879f26e2464974f175d4fd0a85b/github/editor.go#L75-L100
lab impl: https://github.com/zaquestion/lab/blob/master/internal/git/edit.go#L94-L107
And then adding the scizzors line into the edit templates. Below is the mr create one, but may need to get issue and snippet, but I think thats everything. (also fix tests)
https://github.com/zaquestion/lab/blob/master/cmd/mr_create.go#L195-L203

+1


Fallback to metadata from YouTube if not found on Spotify

What is the purpose of your issue?

[ ] Bug
[x] Feature Request
[ ] Question
[ ] Other

Description
We should fallback to metadata from YouTube if it isn't found on Spotify. IMO better than having nothing.

call spotify_tools::generate_metadata() or youtube_tools::generate_metadata() accordingly.

Lol! Were you doing C++ stuff at that time? :wink:

cough Scope resolution operator cough :laughing:


mgmt: mcumgr: lib: cmd: dev: Add device information handler

Draft PR for comment on suitability of a device information mcumgr group. Has a basic implementation for board name and optional build date, needs firmware version and board revision added, and any additional information that could be added (zephyr version?), and documentation.
The device information handler can be used to retrieve information about
the configuration of the configured device such as board name, board
revision, firmware version and build date.

Example output, no parameters:
Zephyr
'a' parameter, with default Bluetooth enabled settings:
Zephyr Zephyr zephyr-v3.0.0-2569-g7f0654f969f7 3.0.99 arm unknown bt510 Zephyr

@de-nordic Moved to OS and uname-style output, still some parts to implement. Thoughts on this? Not sure if the processor response is already available or if it would become an #ifdef mess with many types of processors and processor families. Is there a way to currently get the overall package that you know of e.g. "Zephyr" for if purely using zephyr or "nRF connect SDK" if using that, etc.?

@de-nordic Moved to OS and uname-style output, still some parts to implement. Thoughts on this? Not sure if the processor response is already available or if it would become an #ifdef mess with many types of processors and processor families. Is there a way to currently get the overall package that you know of e.g. "Zephyr" for if purely using zephyr or "nRF connect SDK" if using that, etc.?

I do not think that we have a way to get processor name for now.
During compilation we do not know processor name only the arch, maybe processor name could be pulled out of DTS somehow.
We can probably postpone the processor part and complete all other "letters".

Added a custom function to allow additional options in application, and changed OS to be it's own (weak) function to allow overriding by vendors

@nordicjm Should we bring this back to live?

Would be a good feature to add, yes.

Would be a good feature to add, yes.

Can we re-open this and set target to 3.3?

Rebased

@de-nordic Changes made, left some of the text as-is to prevent duplicating strings

@fabiobaltieri can you merge this please?

Needs a second review, I'll take a look.


RFC3066.pm6 missing

Hi!
I'm getting the following error during installation:
Failed to copy '/home/bduggan/git/clones/Perl6-Grammar--HTTP/.panda-work/1456177051_1/lib/Grammar/HTTP/RFC3066.pm6' to '/home/bduggan/.rakudobrew/moar-2016.01/install/share/perl6/site/sources/2850CD22226A9BC3826EA84B36CA9EA815B94F3F': Failed to copy file: no such file or directory
 ```
Looks like the location of RFC3066.pm6 in META6.json is lib/Grammar/HTTP but it is in lib/Grammar/IETF/IOL.

thanks and all the best
Brian

Thanks, looks like I overlooked quite a few!


SCSS testing

Now that our flexibility of our scss is going to extended with PRs like https://github.com/twbs/bootstrap/pull/28445, we should have a look at automated tests for scss.  With these tests I mean: check the output if scss configuration is changed (like adding utilities, etc..)
I used MochaJS for doing these tests with RFS, that worked pretty well, but maybe we can use the same "thing" for js and (s)css tests.

I'd love to see some examples of how this helps us and others. Never have found a good solution that didn't seem superfluous to writing CSS, but I haven't actively sought that out :).

Here is how it works in RFS:
https://github.com/twbs/rfs/tree/master/test
For example for sass, there are 10 different configurations that are tested with the same main file(https://github.com/twbs/rfs/tree/master/test/sass).
In the expected folder the expected output is shown (https://github.com/twbs/rfs/tree/master/test/expected).
These tests are triggered by git hooks for each commit and also in travis to make sure we don't introduce breaking changes.
For Bootstrap we can something alike to test if changes to the utilities api won't break anything. Other tests could be the output of functions or mixins with specific configurations.

If I may chime in, at the end of the day CSS controls how things look. In terms, facing a similar problem, we decided to test the visual output of static pages. A screenshots is generated build time (on travis) and if it doesn't match up, we commit it and then trigger the build again.
There were some caveats, like specifying the correct tolerance; dealing with browser updates (we are using firefox for the screenshots), spinning animations prove impossible (need to be disabled). I mean it's not the best solution but it works for us and gives us nice visual diffs as well.

Hello,
As part of implementing mixins and functions to help manipulate the utilities map, I wanted to look into having some tests (as there some end up being a bit more than just a chain of map-get).
@mdo mentionned two efforts that had already started on the subject:

His work on https://github.com/twbs/bootstrap/pull/34967: from what I gathered, it uses ad-hoc @if and @warn(or possibly @error further down that route) to output whether exxpectations are met
The gs/test-sass-unit-tests branch by @GeoSot and @XhmikosR  : this one uses [sass-true] to write the tests with custom JS scripts to gather the tests to run and interpret their output, if I understood correctly.

I tried a 3rd way to get start getting a sense of safety for the functions I was building using:
a. [sass-true], still, to write the tests, as it already provides mixins for structuring the tests and making assertions
b. Mocha for collecting the test files, running them and their results
The logic behind this approach is to let each tool do what they're good at so there's no need to maintain either a library for structuring the test code (which is more or less where 1. would lead, I think), nor scripts for collecting, running tests and reporting their results (which is what 2. does).
Setup is in this commit on my fork and here is a commit with some test (though that one is just plain sass-true test, nothing out of this world). It works by making Mocha understand that the project uses .test.scss files (instead of the regular .js extension) and turn each them into a JS module that runs sass-true.
It's not all rainbows and unicorns, though, and there's a few downsides:

its reliance on require.extensions for letting NodeJS require .scss files and transform them into a JS module on the fly. The feature is [marked as deprecated by NodeJS][require-extensions], however, it's what tools like babel-register use to hook onto NodeJS. As Node shifts to ESModule, they're looking at a [loader API for doing that kind of transpilation][node-loader-api], but it's experimental for now. Cleanest alternative may be to use [Jest and its transform option][jest-transform]. If you're aware of another testing tool with that kind of opening, that could work too.
watching the files require using nodemon rather than Mocha's --watch, likely because of some NodeJS internal caching of the module created programmaticaly.  I could look for a way to cache bust it, but a watch-css-test script is much simpler.
its reliance on Mocha in the current state rather than Jasmine (which is already used by Karma, maybe?, so that would be some extra dev dependency), but I think the same approach may be achievable with Jasmine (or other test libraries). I did see some comments about Jasmine issue on windows 10 in the branch for 2. though. So maybe not as straightforward. On that topic, I'm working on Linux, so would need to check that it works on other platforms too.

Hopefully I'm not stepping on anyone's toes, but thought I'd describe the approach I'd take (especially as I went through it to give myself some help) 😊 Obviously happy to discuss in more details.
[sass-true]: https://www.npmjs.com/package/sass-true)
[require-extensions]: https://nodejs.org/dist/latest-v16.x/docs/api/modules.html#requireextensions
[node-loader-api]: https://nodejs.org/docs/latest/api/esm.html#esm_experimental_loaders
[jest-transform]: https://jestjs.io/docs/configuration#transform-objectstring-pathtotransformer--pathtotransformer-object

As mentioned elsewhere, love this @romaricpascal! I'd love @XhmikosR's feedback on the additional testing dependency. I'm fine with it, but if there's a way to keep dependencies down, I'm always for that more :).

The gs/test-sass-unit-tests branch by @GeoSot and @XhmikosR : this one uses [sass-true] to write the tests with custom JS scripts to gather the tests to run and interpret their output, if I understood correctly.

To be honest I cannot recall the exact reason I used custom js.  I can just remember (if that helps) that couldn't find a solution using jasmine, and the js script , is a copy of true-sass internals.
Plus the time the script was written dart-sass didn't provide much configuration through js, so I used exec to parse the files.
At least the written tests are using the sass-true functions 😋
So, if you need any help I'll try to give you a hand

We shipped this finally!

@mdo can you remove any unused related branches too?


[MRG] Compute channel connectivity using Delaunay.

Related to https://github.com/mne-tools/mne-python/issues/4343
The computation for gradiometers is not working yet. I'm not sure what to do with the overlap. Maybe combine them so that for 204 channels it'll return conn matrix of 102X102?
The conn matrix seems to be a bit different to the connectivity here, but the end result is quite identical.

Codecov Report

Merging #4356 into master will decrease coverage by 0.1%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master    #4356      +/-   ##
==========================================
- Coverage   86.07%   85.96%   -0.11%
==========================================
  Files         346      346
  Lines       63059    63090      +31
  Branches     9691     9697       +6
==========================================
- Hits        54275    54235      -40
- Misses       6115     6188      +73
+ Partials     2669     2667       -2

IIRC Fieldtrip does something more than Delaunay triangulation - for sensors positions based on a square mesh the triangulation is not the best thing to do. Anyway I usually correct adjacency by hand - previously in fieldtrip and now in python - I will push a PR with interactive plotting function soon.

IIRC Fieldtrip does something more than Delaunay triangulation - for sensors positions based on a square mesh the triangulation is not the best thing to do. Anyway I usually correct adjacency by hand - previously in fieldtrip and now in python - I will push a PR with interactive plotting function soon.

Looks like they do something similar + manual adding/removal. What's weird is that their template sometimes has one of the grad pair as the neighbor but not the other. Does the orientation matter?

how about with introduce: find_ch_connectivity like we have find_layout
logic is that you read it from disk if you have it and otherwise compute it.
wdyt?

+1 from me

any blocker here?

besides LGTM

+1 for MRG if CIs are happy

so file ch names gets renamed dynamically to match info?

The raw reader renames the channels.

so now the find_layout / find_connectivity need to do the same by guessing?

thx @jaeilepp
let' say we'll fix the 4D mess when/if problems appears in the future...

@jaeilepp
Hey, just wanted to get back to the point that fieldtrip does adjacency creation a little diffrent - it uses a little trick to circumvent the problem that with triangulation connections cannot cross but adjacency relations are free of this constraint (this is clearly visible when channels are on a rectangular grid).
Fieldtrip circumvents this by combining triangles obtained on original sensor positions and two other versions: one where x dimension is squeezed a little (0.5 * original xpos) and another one where the same is performed on y dim (0.5 * original ypos), see here.

I see. Our solution is already giving more neighbors than the files from fieldtrip though (at least with neuromag data). It's also weird that the fieldtrip definitions sometimes give only one of the grad pairs as a neighbor.
For instance, neighbors for MEG0112 are:
[u'MEG0112', u'MEG0113', u'MEG0122', u'MEG0123', u'MEG0132', u'MEG0133', u'MEG0143']
So it gives MEG0143 as a neighbor, but not MEG0142.

so is it working on not? something more to understand?

In the case that two channels are at numerically identical precision, it would be good to treat them the same way. Does that happen automagically with Delaunay?

No. That's why I need to do the Delaunay using only one of the pairs and copy for the other.


Wishlist: release guesswidth as its own separate package

I've wanted to use the guesswidth package in a couple projects of my own. I don't want to have to depend on all of kingpin (and inherits its deps) just to do this, so I'm copying files around.
It'd be great to see this code released as its own Go package.

@alecthomas Would you be okay with me releasing this package and then making a PR for kingpin to use it?

Sure thing!

I did a bit more digging and I realized that the golang.org/x/crypto module already has a package at godoc.org/golang.org/x/crypto/ssh/terminal with a GetSize() func. It's not quite exactly the same, as it can actually return an error and it doesn't check the COLUMNS env var, but for my needs it was good enough.
I'm not sure that it makes sense to have kingpin also use that terminal package as well. But regardless, I'll close this particular issue.


Fix lib_menu

Added edge case check for lib_menu.

@akrasuski1 What do you think?

OK. In current kOS version  we don't really have tools to deal with unexpected situations (exceptions), so we might as well print error and crash.

This is better when crashing at a random point without a proper explanation of what had gone wrong. Merging.


Failure in creating a New folder when Filename with same name exists

When we try to create a New Folder, it results in a failure if there is already a file with same name in the corresponding folder.
The image attached should be self explanatory.

Could you please move this over to the atom/tree-view repository?  Thanks.

Looks like a duplicate of https://github.com/atom/tree-view/issues/31.


build: add option to build executable

Don't we need something in the makefile to set the env var that is used to name the utility? Right now I'm not sure how to use this build utility, so could you also include a little guide in the README and/or a make target that does this? like make build-dev-utility or something

Since we would typically build this from within a docker image, it would require a new ostk-build command in the base image. Which is fine, I can add it, but I think for now just using ccmake and setting the option to ON and then running ostk-build is sufficient. I can definitely update the README.


Feature Request: List/Dict of Import Statements

I am currently writing a small command line (cli) tool. This tool uses one direct dependency (Chevron) which in turn depends on another dependency (PyYAML). When I try to compile it I get the following error message:
$ python3 -m nuitka --follow-imports mycli.py
Nuitka:WARNING:/usr/local/lib/python3.6/dist-packages/chevron/renderer.py:12: Cannot find 'tokenizer' in package 'chevron' as absolute import (tried tokenizer).
Nuitka:WARNING:/usr/local/lib/python3.6/dist-packages/chevron/main.py:15: Cannot find 'renderer' in package 'chevron' as absolute import (tried renderer).
Nuitka:WARNING:/usr/local/lib/python3.6/dist-packages/chevron/main.py:16: Cannot find 'metadata' in package 'chevron' as absolute import (tried metadata).
Nuitka:WARNING:/usr/local/lib/python3.6/dist-packages/yaml/cyaml.py:5: Cannot find '_yaml' in package 'yaml' as absolute import (tried _yaml).
Nuitka:WARNING:Unresolved '__import__' call at '/usr/local/lib/python3.6/dist-packages/yaml/constructor.py:505' may require use of '--include-plugin-directory' or '--include-plugin-files'.
Nuitka:WARNING:Unresolved '__import__' call at '/usr/local/lib/python3.6/dist-packages/yaml/constructor.py:521' may require use of '--include-plugin-directory' or '--include-plugin-files'.

I installed the packages via PIP and I would like to use the packages from PIP. Yes, I can use the --include-plugin-directory or the --include-plugin-files. However, I do not want to download the source code for both Chevron and PyYAML. Instead I would like to provide a list with filepath:linenumber: import statement entries instead.
For example:
[chevron/main.py](https://github.com/noahmorrison/chevron/blob/master/chevron/main.py)
try:
    from .renderer import render
    from .metadata import version
except (ValueError, SystemError):  # python 2
    from renderer import render
    from metadata import version

imports.txt
chevron/main.py:15: from .renderer import render
chevron/main.py:16: from .metadata import version

$ python3 -m nuitka --import-file imports.txt mycli.py

So, basically the idea is to tell Nutika what to overwrite, but we don't have to change the source code.
Python and Nutika version:
python3 -m nuitka --version
<IP_ADDRESS>
Python: 3.6.6 (default, Sep 12 2018, 18:26:19)
Executable: /usr/bin/python3
OS: Linux - Ubuntu
Arch: x86_64

Is this only to disable the warnings, or should it actually impact behavior?

Without example or explanation there is no point in having it open.


.Net: [Feature branch] Perf / reliability improvements for FlowOrchestrator

Summary
This pull request updates the EmailPluginV2 in Example60_FlowOrchestrator to prompt for multiple email addresses, adds logging to the orchestrator, and adds new flow control features. The changes include:
Changes

Updated EmailPluginV2 to prompt for multiple email addresses instead of a single email address
Added logging to Example60_FlowOrchestrator using Microsoft.Extensions.Logging
Changed the 'email_address' variable to 'email_addresses' in CollectEmailAsync
Added a logger factory to GetKernelBuilder to enable logging in the orchestrator
Added a new function to terminate the session, only used when previous attempts failed with FATAL error and need notify user
Added two new extension methods to check if we should terminate flow based on current context and if all variables to be provided with the flow are available in the context
Modified ReActEngine.cs file to append the stop and prompt user function to the available functions if auto-termination is enabled, and to add passthrough data to referenced flow steps
Added EnableAutoTermination property to FlowOrchestratorConfig class
Updated AddPassthrough method in FlowStep class to allow passthrough arguments in referenced flows
Updated skprompt.txt file in ReActEngine plugin to clarify usage instructions

Powered by Microsoft Semantic Kernel
Motivation and Context

Improve performance and reliability for FlowOrchestrator
Description

Contribution Checklist

[x] The code builds clean without any errors or warnings
[x] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[x] All unit tests pass, and I have added new tests where possible
[x] I didn't break anyone :smile:

/sk generate-pr-description prefix

@lemillermicrosoft to help review


Request for Python Environment Details

Dear contributors,
Thanks for your valuable work and your code release. I am interested in reproducing your results; however, the code does not seem to be working with the recent changes in the dependencies.
Could you please share in your repo a venv / conda environment that has been used in your paper?
Best,
Leo.

can you tell me what error you get? the code used here should be pretty
stable except maybe
in mne-bids-pipeline that has renamed a few options.

Message ID: @.***
.com>


Callback chaining clarification

The documentation states:

Note that txaio doesn’t do anything special with regards to callback or errback chaining – it is highly recommended that you always return the incoming argument unmodified in your callback/errback so that Twisted and asyncio behave the same.

But even for asyncio there is a slightly hacky call-chaining implemented in txaio/aio.py. And this seems to be used extensively, e.g. in autobahn/wamp/protocol.py.
Please either update the documentation, rendering this functionality "official and supported" or remove the hack from aio.py (which I expect to cause quite some test failures in dependent libraries). If the decision is to remove the hack, please consider providing a replacement for this idiom used in crossbario/autobahn-python:
d = txaio.as_future(func1)
txaio.add_callbacks(d, txaio.as_future(func2), None)
txaio.add_callbacks(d, txaio.as_future(func3), None)

Okay, I think the sane thing to do here is to keep the "hack" and document it. This basically makes the callback-value-chaining work the same way as Twisted. Do you foresee any problems with this for asyncio users?

Also, the recommendation in the docs should still be to always return the incoming arg (i.e. to not depend on mutating the return-values in your library).

Do you foresee any problems with [rendering the hack official] for asyncio users?

I am just getting started with async programming in Python (which is why I actually read the docs and found this...), so I am not the best person to ask.
Having said that, it seems that asyncio.Future()._result is an undocumented internal, which may be changed at any time. So maybe add some check like assert(hasattr(f, '_result')).


Gh 779 remove koryphe

Codecov Report

Merging #827 into develop will increase coverage by 0.3%.
The diff coverage is 73.07%.

@@             Coverage Diff              @@
##             develop     #827     +/-   ##
============================================
+ Coverage      58.79%   59.09%   +0.3%
+ Complexity      2671     2281    -390
============================================
  Files            489      401     -88
  Lines          12220    10990   -1230
  Branches        1341     1250     -91
============================================
- Hits            7185     6495    -690
+ Misses          4449     3957    -492
+ Partials         586      538     -48

Impacted Files
Coverage Δ
Complexity Δ

...encies/binaryoperator/StringsSketchAggregator.java
100% <ø> (ø)
3 <0> (?)

.../export/resultcache/GafferResultCacheExporter.java
76.25% <ø> (ø)
7 <0> (ø)
:arrow_down:

...antiles/binaryoperator/StringsUnionAggregator.java
100% <ø> (ø)
2 <0> (?)

...antiles/binaryoperator/DoublesUnionAggregator.java
100% <ø> (ø)
2 <0> (?)

...affer/binaryoperator/IntegerFreqMapAggregator.java
100% <ø> (ø)
4 <0> (?)

...sketches/theta/binaryoperator/UnionAggregator.java
100% <ø> (ø)
2 <0> (?)

...quencies/binaryoperator/LongsSketchAggregator.java
100% <ø> (ø)
2 <0> (?)

...k/gov/gchq/gaffer/store/schema/TypeDefinition.java
37.86% <ø> (ø)
18 <0> (ø)
:arrow_down:

.../binaryoperator/ReservoirItemsUnionAggregator.java
100% <ø> (ø)
2 <0> (?)

.../binaryoperator/ReservoirLongsUnionAggregator.java
100% <ø> (ø)
2 <0> (?)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 827ac47...c9805c4. Read the comment docs.


Sorting summary results

Is it possible to sort the aggregated summary result by the value of "count", as I want to know which hosts hit the rule the most? Currently looks like it's sorted by timestamp, and I cannot find a way to customise it.
In the following result, I'd like the row of "r489" to be the first row. Is there any way to do that?
`Aggregation resulted in the following data for summary_table_fields ==> ['syslog_hostname', 'count']:
+-----------------+-------+
| syslog_hostname | count |
+=================+=======+
| r260            | 1     |
+-----------------+-------+
| r3343           | 1     |
+-----------------+-------+
| r3289           | 1     |
+-----------------+-------+
| r489            | 12    |
+-----------------+-------+
| r1578           | 1     |
+-----------------+-------+
| r1782           | 1     |`

I'm facing the same problem, would love to know if this is possible.


KYLIN-3838 Fix retry mechanism is invalid when build with spark

Can one of the admins verify this patch?

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@68bffc1). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master     #496   +/-   ##
=========================================
  Coverage          ?   24.47%
  Complexity        ?     4963
=========================================
  Files             ?     1145
  Lines             ?    69456
  Branches          ?     9903
=========================================
  Hits              ?    16998
  Misses            ?    50738
  Partials          ?     1720

Impacted Files
Coverage Δ
Complexity Δ

...org/apache/kylin/engine/spark/SparkExecutable.java
0% <0%> (ø)
0 <0> (?)

...e/kylin/engine/spark/exception/SparkException.java
0% <0%> (ø)
0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68bffc1...c15846a. Read the comment docs.

Pull Request Test Coverage Report for Build 4192

0 of 10 (0.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 26.955%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutable.java
0
2
0.0%

engine-spark/src/main/java/org/apache/kylin/engine/spark/exception/SparkException.java
0
8
0.0%

Totals

Change from base Build 4187:
0.003%

Covered Lines:
18722

Relevant Lines:
69456

💛  - Coveralls


[WIP] Feat/cornerstone wado

Bringing cornerstoneWADOImageLoader to the cornerstonejs mono repo, why?

Convert the library to typescript
Increasing need for webworkers in cornerstonejs, makes it hard to manage workers both in wado and here in core or tools or consuming apps (e.g., OHIF)
Better development experience for devs

Remaining works

Adding the CSWIL examples
Adding CSWIL tests

Hi @sedghi I recently converted the cornerstoneWadoLoader to typescript myself and typed many of the functions.  Would you be interested in help with this? If so, do you have any thoughts/guidelines on how to name types? I normally prefix types used by a package with a common namespace ie: CornerstoneWadoLoaderOptions or CornerstoneWadoLoaderImage extends IImage.

@jmannau This is awesome! and yes we are interested for sure.
How about you create a PR to this branch and we discuss there?
We always appreciate community support and give appropriate attributions as you can see in our previous newsletters here

I got started on this today. But ran into webpack config issues.  Is there somewhere to put chats/discussions. Rather than give myself more grey hair due to webpack - thought it best to ask if others have a suggestion

closing in favor of https://github.com/cornerstonejs/cornerstone3D-beta/pull/343


Docs/Fix(Planner), Docs(Discoverer)

Updated Planner configuration file with "cloudfoundry-istance" artifact
Updated Planner README with all configuration variables
Updated Discoverer README with mongoimport as requirement
Fixed DAM Generator issue, now Monitoring rules are correctly passed to SLA

@rosogon, @jacopogiallo can you please review it?

@PaoloCifariello, could you rebase it? #294 contains an useful feature to test this PR

Current coverage is 41.11%

Merging #295 into master will decrease coverage by -7.03% as of 16b954b

@@            master    #295   diff @@
======================================
  Files          219     365    +146
  Stmts         9045   13236   +4191
  Branches      1322    1660    +338
  Methods          0       0
======================================
+ Hit           4355    5442   +1087
- Partial        355     430     +75
- Missed        4335    7364   +3029

Review entire Coverage Diff as of 16b954b

Powered by Codecov. Updated on successful CI builds.

No comments from my side. +1

Regarding AgreementGenerator, it would be good to have a unit test using mockserver.

This PR is included in #297. Then, it should be closed.


[Bug] quay.io/kubecarrier/apiserver:v0.2.0 401 Unauthorized

Describe the bug
Following the installation guide of kubecarrier on kind. When running the setup step the installtion runs into a timeout.
The apiserver images ends in an ImagePullBackoff State:
  - image: quay.io/kubecarrier/apiserver:v0.2.0
    imageID: ""
    lastState: {}
    name: manager
    ready: false
    restartCount: 0
    started: false
    state:
      waiting:
        message: Back-off pulling image "quay.io/kubecarrier/apiserver:v0.2.0"
        reason: ImagePullBackOff

│ Events:                                                                                │
│   Type     Reason       Age                     From                  Message                                                                                │
│   ----     ------       ----                    ----                  -------                                                                                │
│   Normal   Scheduled    7m52s                   default-scheduler     Successfully assigned kubecarrier-system/kubecarrier-api-server-manager-7bd6786bdd-m8pmt to kind-worker                                │
│   Warning  FailedMount  7m51s (x2 over 7m52s)   kubelet, kind-worker  MountVolume.SetUp failed for volume "serving-cert" : secret "apiserver-tls-cert" not found                                             │
│   Normal   Pulling      6m23s (x4 over 7m50s)   kubelet, kind-worker  Pulling image "quay.io/kubecarrier/apiserver:v0.2.0"                                                                                │
│   Warning  Failed       6m22s (x4 over 7m46s)   kubelet, kind-worker  Failed to pull image "quay.io/kubecarrier/apiserver:v0.2.0": rpc error: code = Unknown desc = failed to pull and unpack image "quay.io │
│ /kubecarrier/apiserver:v0.2.0": failed to resolve reference "quay.io/kubecarrier/apiserver:v0.2.0": unexpected status code [manifests v0.2.0]: 401 Unauthorized                                              │
│   Warning  Failed       6m22s (x4 over 7m46s)   kubelet, kind-worker  Error: ErrImagePull                                                                                │
│   Normal   BackOff      6m8s (x5 over 7m45s)    kubelet, kind-worker  Back-off pulling image "quay.io/kubecarrier/apiserver:v0.2.0"                                                                          │
│   Warning  Failed       2m45s (x20 over 7m45s)  kubelet, kind-worker  Error: ImagePullBackOff

To Reproduce
Steps to reproduce the behavior:

Install kind cluster with kubernetes version v1.17.5

Install kubecarrier kubectl plugin

kubectl kubecarrier version --full
branch: v0.2.0
buildTime: "2020-06-26T15:17:56Z"
commit: ee0fcd1
goVersion: go1.14.3
platform: darwin/amd64
version: v0.2.0

Run Installation command: kubectl kubecarrier setup

Expected behavior
Successfull installation
Kubernetes/Openshift Cluster

Version

Desktop (please complete the following information):

OS: macOS Catalina

Thank you for reporting this issue, I'm looking into it

P.S.
Issue number fits as well
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/504
:P

Anyway, apiserver is a bit newer component and we forgot marking that repo public as well. Fixed.
Please try it out and report if there are any further issues.
Locally tested with:
mv ~/.docker/config.json ~/.docker/config.json.bak  # "deleted" my quay.io auth credentials
docker pull quay.io/kubecarrier/apiserver:v0.2.0

Works,thanks!


docs(plugins) remove loaderoptions plugin which was used for migratin…

…g wp1 to wp2
As agreed before we are removing this plugin from the docs, it is still accessible on v3 tag and v4.webpack.js.org

Thanks!


chat: occasional double-render

Often in talk and groups messages will display twice, sometimes back to back, sometimes out of order.

dupe of #1430


Allow patients to view test results

Related Issue or Background Info

Part of #1076

Changes Proposed

When a test result is submitted, create a new Patient Link and send a text to the patient (in the TestOrderService)
Renamed our PXP classes to be more clear (PxpApiWrapper -> PxpRequestWrapper, PxpPersonWrapper -> PxpVerifyResponse)
Added some fields to the PxpVerifyResponse, including the OrderStatus and the test device used for the last test result
On the frontend, after making a verify request, check the OrderStatus. If complete, route to the TestResult component
Built out the TestResult component based on these designs, which might still be WIP, so we may need to update
Added another field as requested below to the pre-test questions which allows the patient to specify whether or not they'd like to receive their test results via text

Screenshots / Demos

@ClydeDroid can you add a state for "Inconclusive" since that's the third result someone can get?

@maya What should the notes content be for "Inconclusive"?

@hmyers-cms and @katiealoisi haven't told us yet, so we'll need to confirm with them. Offhand, it seems like the "Negative" result note could apply if we need a placeholder.

@nullflux Here's the note to use:

An inconclusive result is neither positive nor negative. This result can occur from
inadequate sample collection, very early-stage infection, or for patients close to
recovery. With an inconclusive result, collecting and testing another sample is
recommended. Please make an appointment for another test as soon as possible.

This may change later on though.

Need to update the TOT Modal to include a question about how they want to receive a copy of their results. We'd like their response to be remembered for next time, and no selection is essentially the same as "none". Someday maybe we will add email as an option.
I've also included in this a slight design refresh as it was starting to look extra busy, so I got rid of extra header labels and such. This is in the engineering-ready version of our prototype now

Here is the inconclusive result page:

This is working now! Here's some up to date screenshots:

Can we add it to the text option too?
Currently shows as this:

Also, the screenshots made me discover Firefox doesn't collapse margins like Chrome/webkit, this is what it looks like in Chrome:

Can we add "Test result delivery" to the text option too?

We don't need to add it there, as we added it in AoE form. Therefore, if a patient chooses to get a link texted to them to fill out their pre-test questions, they will be able to choose their preference when they go to fill out their pre-test question on their phone.

I wonder if @hmyers-cms screenshot is an older version b/c it doesn't include the form legends that are in the current version.
I found one design where the legend is just "Results" so will want to confirm what it should say.
Either way, we use sentence case, so can we update to: "Test result delivery"?

Updated to sentence case in 4cc1780.

The latest design screenshot I sent above actually removes the H3 labels because some of the sections only have 1 question in them, so they were taking up space but not necessarily adding a lot of value. Trying to help clean things up and make it easier to scan through the content

Thanks for the context @hmyers-cms. Since the form is also used on the patient side (and I'll have some q's about it), I wonder if it makes sense to do any refinements in a separate PR so we keep this one focused on the core feature.

Yeah I'm fine with doing the refinements separately

To close the loop on my Firefox comment, I remembered that for the provider experience, we only support webkit-based browsers: Chrome and mobile Safari on iPad, so we can ignore.


self._computed role and undesired behaviour

Subclassing the Metric class in my custom metric class im collecting model predictions and at the end of the epoch I calculate  multiple metrics using those predictions.  for this I am passing an argument to the compute() method to just use the stored predictions and calculate metrics. however after calling compute once, the successive compute() cvalls are blocked due to the flag self._computed being set to previous computed value after first call apparently which prevents from any further computations. Is there a good explanation for this whole _computed flag ?
Of course I "can" create different metric classes for different metrics that all use the same prediction scores, but that would be quite stupid and redundant as all metrics are using the exact same data and that would just accumulate multiple copies of a same data. So to me ._computed just seems unnecssarily blocking.

Hi @astrocyted, thanks for raising this issue.
There are a couple of reasons:

To prevent that repeated calls to compute leads to repeated computations
We never had a use case where people have arguments in compute, thus calling compute would always return the same value and therefore it makes sense to cache
For compatibility reasons with the logging in pytorch lightning

All that said, we had another usecase recently where this caching behaviour was also a problem, and that lead us to introduce a new global argument to all base metrics. Its called compute_with_cache and introduced in PR https://github.com/Lightning-AI/torchmetrics/pull/1754. By default it is True and computed results are caches. If setting to False then they are not cache.
Please see the following small example:
from torchmetrics.metric import Metric
import torch

class M(Metric):
    def __init__(self, **kwargs):
        super().__init__(**kwargs)
        self.add_state("x", default=torch.tensor(0), dist_reduce_fx="sum")

    def update(self, x):
        self.x += x

    def compute(self, pow=2):
        return self.x ** pow

m = M()
m.update(torch.tensor(2))
print(m.compute(pow=2))  # prints 4 (2^2)
print(m.compute(pow=3))  # prints 4 due to cache

m = M(compute_with_cache=False)
m.update(torch.tensor(2))
print(m.compute(pow=2))  # prints 4 (2^2)
print(m.compute(pow=3))  # prints 8 (2^3)

To get access to the new feature please update to master:
pip install https://github.com/Lightning-AI/torchmetrics/archive/master.zip

Thanks @SkafteNicki for the explanation and the solution. For now, I'm alternatively providing a list of arguments to compute() and compute all the desired metrics in one call, circumventing the cache issue, although now i have an issue with my internal state variables not being reset automatically after calling compute().
However I genrally find there is something missing in the base class for cases when multiple metrics are computed (say in obj. detection) using essentially same model predictions and just instantiating a IoU, gIoU, ... only for all of them to independently accumulate predictions. for now Im like i said writing a wrapper to compute all metrics at once using single set of state variable but it would be nice if that was an option generally to integrate all desired metrics into one object smoothly without having to instantiate separate Metric class for each.

Thanks @SkafteNicki for the explanation and the solution. For now, I'm alternatively providing a list of arguments to compute() and compute all the desired metrics in one call, circumventing the cache issue, although now i have an issue with my internal state variables not being reset automatically after calling compute().

@astrocyted Not sure what is causing the problem with the internal state variables not being reset (would need to see the code for that), but if you need custom logic regarding the reset, then you can manually overwrite reset
def reset(self):
     super().reset()
     self._manual_reset_stuff()

However I genrally find there is something missing in the base class for cases when multiple metrics are computed (say in obj. detection) using essentially same model predictions and just instantiating a IoU, gIoU, ... only for all of them to independently accumulate predictions. for now Im like i said writing a wrapper to compute all metrics at once using single set of state variable but it would be nice if that was an option generally to integrate all desired metrics into one object smoothly without having to instantiate separate Metric class for each.

We have that functionality in the MetricCollection object. If I have metric M1 and metric M2, and both of them share the exact same internal states, MetricCollection will automatically make sure that if I call .update on the collection, then only update of M1 is called and the resulting state is propergated to M2. As an example, here is Precision and Recall which have the same state but differs in their compute
from torchmetrics import MetricCollection
from torchmetrics.classification import BinaryPrecision, BinaryRecall
import torch

preds = lambda : torch.rand(10)
target = lambda : torch.randint(2, (10,))

m = MetricCollection([BinaryPrecision(), BinaryRecall()])
print(m.compute_groups)  # {0: ['BinaryPrecision'], 1: ['BinaryRecall']}
m.update(preds(), target())
print(m.compute_groups)  # {0: ['BinaryPrecision', 'BinaryRecall']}
m.update(preds(), target())
res = m.compute()

as you can see in the example, the compute_groups property indicates if two metrics share state. Initially, we do not know this and precision and recall is in individual groups. After the first update call we check if states matches (by name and value), and then merge precision and recall into the same group because they match. Then calls to update afterwards will only call the update method of the first metric in each group and propagate the state to the rest of the group.


plot_summaries() should show pulse_rms

Original report by Joseph Fowler (Bitbucket: joe_fowler, ).

Pulse_rms should be an option in addition to (instead of?) pulse_average when you do data.plot_summaries() or ds.plot_summaries().

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).

Methods plot_summaries() can now plot pulse RMS.
Other summaries have been re-ordered to collect similar quantities together.
Fixes #50.


/etc/fstab entry won't load on reboot

I have added entry as specified in https://learn.microsoft.com/en-us/azure/storage/blobs/network-file-system-protocol-support-how-to guide. However on reboot, the path does not mount as the aznfswatchdog is still loaded.
Error in /opt/microsoft/aznfs/aznfs.log
Sun Jun 04 2023 18:27:57.660 anq-ci-internal-gitlab 431: aznfswatchdog service not running!
entry in /etc/fstab
XXXXXXXXXX.blob.core.windows.net:/XXXXXXXXX/YYYY  /ZZZZ    aznfs defaults,sec=sys,vers=3,nolock,proto=tcp,nofail    0 0
It works fine if I remove aznfs and set it to just nfs.
Possible fix:
in /opt/microsoft/aznfs/mountscript.sh, modifying ensure_aznfswatchdog function to start the service. Not the best idea but it works.

I have also run into this issue and would be interested to hear a solution besides modifying the mount script.

In the fstab entry, user has to give '_netdev' option as well so that systemd can understand that 'aznfs' is a remote FS and aznfswactchdog has started before remote-fs.target. To ensure latter, aznfswatchdog.service has been updated.
Now '/etc/fstab' entry will be:
'.blob.core.windows.net://  /nfsdata    aznfs defaults,sec=sys,vers=3,nolock,proto=tcp,nofail,_netdev    0 0'
Documentation will be updated soon.

Official doc has also been updated for /etc/fstab entry. Can check it out.
https://learn.microsoft.com/en-us/azure/storage/blobs/network-file-system-protocol-support-how-to

Thank you, I ran into this issue while testing on RHEL 8.x server.
The entry and the 1.02 update appears to have solved the issue now for my test environment.

I appear to be bumping into this issue on SLES 15 hosts even with the _netdev option in fstab


fix(repo): Set the correct node engine for the SDKs

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[x] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ ] @clerk/clerk-expo
[x] @clerk/backend
[ ] @clerk/clerk-sdk-node
[x] gatsby-plugin-clerk
[ ] @clerk/shared
[ ] build/tooling/chore

Description

[ ] npm test runs as expected.
[ ] npm run build runs as expected.

This is a follow-up of https://github.com/clerkinc/javascript/commit/fdcd6b3f7c61490297a5fdfa80228cbb7787b49b

It looks like we no longer need to support node 12, so let's merge this and then we can also revert the node 12 fetch polyfil change we made in https://github.com/clerkinc/javascript/pull/679/commits/c69d33f1a1ae5924447733dbfa5a3402a46fb9d4

@nikosdouvlis Can you please do a follow-up PR?

@nikosdouvlis Can you please do a follow-up PR to remove the fetch polyfill support?

Will do :)


Fix flaky panoramas test

https://github.com/WillNilges/meshdb/pull/273
The tests on this PR should not be failing, it's a readme change lol
We need to mark that test as flaky, mock the GitHub API call, or remove it

this is my fault. I can deal with it!


why not include the command 'gettxoutsetinfo'?

Hello, I am develop a safely and quickly trading platform now.
I want to fetch current total namecoins in existence, the command 'gettxoutsetinfo' show the value 'total_amount' that I want to fetch. But namecoin not support this command, why?

Namecoin (in this repository) is based on an ancient version of Bitcoin and does not keep track of the UTXO set.  Thus this command is not easy to implement.  There was an experimental branch that added UTXO tracking which eventually turned into an UTXO implementation for Huntercoin, but this is obsolete now.
If you want this command (and a lot more), take a look at https://github.com/domob1812/namecore.  Be careful, though, this is still experimental but works fully and will be released officially in the future.

Thanks. But I just want to fetch the  current total namecoins in existence, how to get this value directly in namecoin?
Thanks again.

You can just calculate it from the block height.  50 NMC per block until 210,000, then 25 NMC per block.  Note that the UTXO set of Namecore gives you a slightly less number, since it knows about destroyed coins (the early-days "name fee") and expired names.


Moved JSON strings in tests to .json files to improve compile times.

It was really bothering me how I pieced the JSON deserializer tests together and it seemed to be taxing on the compiler. Moving these strings into .json files cut the start to finish times for building Sage.jar from 2 minutes to 1 minute.

I was going to hold off on this, but it's a lot of files being changed that you don't care about and I didn't want to make a future push harder to follow.

I don't ever review the test code...so if it passes the build test, it's good enough for me. :)


Redwerkz patch 1

@lafriks

locale_fa-IR.ini should now be properly reverted
there is already whitespace included to make the icon squared

I think you pushed to the wrong PR. That should go into #21123.

As per @KN4CK3R