feat: add extradeploy

By defining the list of k8s resources that users need in relation to datahub in extradeploy, such as serviceAccount, role, rolebinding, and so on.
The reason is that we want to complete the creation of the token together during the deployment of datahub and write it to a k8s secret. We started with datahub's datahubSystemUpdate to execute the relevant commands.
        datahubSystemUpdate:
          image:
            repository: acryldata/datahub-upgrade
            command: ["/bin/sh", "-c"]
            args:
            - |
              curl -sSLo /tmp/kubectl "http://oss-cn-hangzhou-zjy-d01-a.ops.cloud.zhejianglab.com/data-and-computing/public/dl.k8s.io/release/v1.29.1/bin/linux/amd64/kubectl" &&
              chmod u+x /tmp/kubectl &&
              mkdir -p ${HOME}/bin &&
              mv -f /tmp/kubectl ${HOME}/bin/kubectl &&
              export PATH="${PATH}:${HOME}/bin" &&
              JQ_LINK=https://github.com/stedolan/jq/releases/download/jq-1.7/jq-linux64 &&
              wget $JQ_LINK -O ${HOME}/bin/jq-linux64 &&
              chmod +x ${HOME}/bin/jq-linux64 &&
              JQ_PATH="${HOME}/bin/jq-linux64" &&
              PASSWORD=$(kubectl -n datahub get secret datahub-user-secret -o jsonpath='{.data.user\.props}' | base64 -d | cut -d: -f2-) &&
              curl -k --cookie-jar /tmp/cookie.txt 'http://datahub-datahub-frontend:9002/logIn' \
                -H 'content-type: application/json' \
                --data-raw "{\"username\":\"datahub\",\"password\":\"$PASSWORD\"}" &&
              ACCESS_TOKEN=$(curl -k --cookie /tmp/cookie.txt -X POST 'http://datahub-datahub-frontend:9002/api/graphql' \
                --header 'X-DataHub-Actor: urn:li:corpuser:datahub' \
                --header 'Content-Type: application/json' \
                --data-raw '{ "query":"mutation { createAccessToken(input: { type: PERSONAL, actorUrn: \"urn:li:corpuser:datahub\", duration:NO_EXPIRY,name: \"my personal token2\" } ) { accessToken metadata { id name description} } }", "variables":{}}' | "$JQ_PATH" -r '.data.createAccessToken.accessToken') &&
              kubectl create secret generic datahub-access-token \
                --from-literal=access-token="$ACCESS_TOKEN" \
                -n datahub
          annotaions:
              helm.sh/hook: post-install
          serviceAccount:
            datahub-system-update

But the serviceAccount (here is 'datahub-system-update',as well as role and rolebinding) needed to execute the relevant kubectl commands needed to be created in advance of deploying datahub.
We want these k8s objects to be configured and installed together with datahub in a values.yaml, so we use the extrdeploy function to install the required serviceAccount, role, rolebinding together.
extraDeploy:
  - |
    apiVersion: v1
    kind: ServiceAccount
    metadata:
      name: datahub-system-update
      namespace: datahub
  - |
    apiVersion: rbac.authorization.k8s.io/v1
    kind: Role
    metadata:
      name: secret-manager-role
      namespace: datahub
    rules:
    - apiGroups: [""]
      resources: ["secrets"]
      verbs: ["get","list", "create"]
  - |
    apiVersion: rbac.authorization.k8s.io/v1
    kind: RoleBinding
    metadata:
      name: secret-manager-rolebinding
      namespace: datahub
    subjects:
    - kind: ServiceAccount
      name: datahub-system-update
      namespace: datahub
    roleRef:
      kind: Role
      name: secret-manager-role
      apiGroup: rbac.authorization.k8s.io

Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

I like the idea to have an option to add arbitrary objects to the Helm chart, however is there any common standard how this option should be named (I do not know!)? In case of the OpenSearch Helm chart the option is called "extraObjects": https://github.com/opensearch-project/helm-charts/blob/a018f838ec44dd0b9337e0403a541580cc39c0f3/charts/opensearch/values.yaml#L493-L531
"extraDeploy" could imply that it can only be used for deployments and not for any object?

I like the idea to have an option to add arbitrary objects to the Helm chart, however is there any common standard how this option should be named (I do not know!)? In case of the OpenSearch Helm chart the option is called "extraObjects": https://github.com/opensearch-project/helm-charts/blob/a018f838ec44dd0b9337e0403a541580cc39c0f3/charts/opensearch/values.yaml#L493-L531
"extraDeploy" could imply that it can only be used for deployments and not for any object?
edit: I think "extraObjects" is kind of a common standard:
* [Add `extraObjects` value that allows creating supportive / adhoc resources traefik/traefik-helm-chart#595](https://github.com/traefik/traefik-helm-chart/issues/595)

* [[FR] Allow the Chart to create extra manifest  cert-manager/cert-manager#5900](https://github.com/cert-manager/cert-manager/issues/5900)

* [Install arbitrary resources with the Helm chart rstudio/helm#115](https://github.com/rstudio/helm/issues/115)

* [Add `extraObjects` value that allows creating supportive / adhoc resources apache/couchdb-helm#72](https://github.com/apache/couchdb-helm/issues/72)

* ...and of course the OpenSearch Helm chart

I noticed that the Bitnami repositories include an extraDeploy feature, as seen in this example. However, I couldn't find a similar feature in DataHub, so I copied some code from Bitnami here. Unfortunately, I found this issue after completing my implementation. After reviewing this code, it seems to follow Bitnami's approach and names it extraDeploy, so it should be fine.


fix: add ClinicalFinding semantic type

Not critical, but this would support ID resolution and handling this semantic type for Multiomics Provider Wellness API. Currently we don't have any ID resolution (which leads to bugs in handling these IDs / semantic type).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.831%

Totals

Change from base Build 972320854:
0.0%

Covered Lines:
439

Relevant Lines:
444

💛  - Coveralls

Ideally, add the relevant tests @colleenXu

I'll note in my to-dos that tests would ideally be added for clinical finding, especially if we will work more with this semantic type going forward

Note that we have changed to using refactored ID resolver with SRI-based service (dev)...
It's not clear if code like this is used anymore, or what kind of tests need to be done (discussions in https://github.com/biothings/BioThings_Explorer_TRAPI/issues/283 and issues that I will create later)

Looks like the code you changed is part of the old resolver. All of the code for the new SRI-based resolver is in sri.ts so if it isn't able to resolve it it is probably SRI not handling it


Meetings can be incorrectly reported as concluded when the previous meeting runs over

Our logic to check whether a meeting has concluded assumes that if it's after a meeting's start time, but the meeting is not live, then that meeting has concluded. This isn't necessarily the case, as meetings can start late if a prior meeting runs over, or for some other reason.
If a previous meeting (or concurrently scheduled) meeting is still streaming, the meeting has not yet started and should not be marked as concluded.
It's a bit harder if there is not a previous meeting. For current meetings, we introduced a 20-minute buffer to account for late starts. @shrayshray, does a similar approach make sense here? What's a reasonable buffer for the start time of the first meeting of the day?

@shrayshray Is it true that every meeting will be broadcast?
If so, we could simplify the logic to determine whether a meeting is over by marking a meeting as having been streamed when it is returned by the running events endpoint (http://metro.granicus.com/running_events.php). (We use this endpoint to determine when meetings are current.) Then, we can use that indicator to tell when the meeting has concluded. The logic would look like:
If the meeting has been streamed but is no longer ongoing, then it's concluded. Otherwise, it is not concluded.
What do you think?

@hancush Yes, every meeting will be broadcast. This sounds effective to me: "If the meeting has been streamed but is no longer ongoing, then it's concluded. Otherwise, it is not concluded."

Reference screenshot for meetings occurring on 1/27/2022. Regular Board meeting had not started yet, but the LA Safe meeting was running.
—
Omar Camacho
Sr. Manager, Systems Projects, Research & Records Information Management
Office of Board Administration
213.922.2335
Metro Los Angeles
metro.net | facebook.com/losangelesmetro | @metrolosangeles
Metro provides excellence in service and support.
From: shrayshray @.>
Sent: Thursday, January 27, 2022 1:44 PM
To: datamade/la-metro-councilmatic @.>
Cc: Subscribed @.***>
Subject: Re: [datamade/la-metro-councilmatic] Meetings can be incorrectly reported as concluded when the previous meeting runs over (Issue #772)
@hancushhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhancush&data=04|01|camachoo%40metro.net|2ff211e02e71485f1dd908d9e1de12f7|ab57129bdbfd4cacaa77fc74c40364af|1|0|637789166179722066|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=bfZJFRxjyppd9iK1eUA8%2BNWrEkvCm62qRfhP%2FI0S0m8%3D&reserved=0 Yes, every meeting will be broadcast. This sounds effective to me: "If the meeting has been streamed but is no longer ongoing, then it's concluded. Otherwise, it is not concluded."
—
Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdatamade%2Fla-metro-councilmatic%2Fissues%2F772%23issuecomment-1023665289&data=04|01|camachoo%40metro.net|2ff211e02e71485f1dd908d9e1de12f7|ab57129bdbfd4cacaa77fc74c40364af|1|0|637789166179722066|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=82Cvc51sTb3Xkw7zGYmUSh1vSUR8S8v6LPDwCAgcxq8%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAG3PL6U4TFJ2TADQ35IKXTDUYG4ARANCNFSM5IKSDVZA&data=04|01|camachoo%40metro.net|2ff211e02e71485f1dd908d9e1de12f7|ab57129bdbfd4cacaa77fc74c40364af|1|0|637789166179722066|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=nRKAe%2Bx87njd4kXjh0BJN1T1hmu3N5XVDrYBUllPbH8%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|camachoo%40metro.net|2ff211e02e71485f1dd908d9e1de12f7|ab57129bdbfd4cacaa77fc74c40364af|1|0|637789166179722066|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=h9hrR6GcwOh42ZV60226LcTpm8Vd1LevnUIO03PJBDg%3D&reserved=0 or Androidhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|camachoo%40metro.net|2ff211e02e71485f1dd908d9e1de12f7|ab57129bdbfd4cacaa77fc74c40364af|1|0|637789166179722066|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=rpSBo9LSSfTF55dHCzp9UbZ7gjy%2FLi%2B4D0OBp%2FkoS1Y%3D&reserved=0.
You are receiving this because you are subscribed to this thread.Message ID<EMAIL_ADDRESS>

I will draft this ahead of February meetings and we'll trial it on staging!

@shrayshray I've deployed the change in logic to the staging site: https://lametro-upgrade.datamade.us/
Can you keep an eye on it during this week's meetings and let me know whether you spot anything amiss?

FYI @shrayshray @camachoo this is redeployed to staging for testing during today's meeting: https://lametro-upgrade.datamade.us/

Apologies, I was caught up in other troubleshooting during last week's meetings. I set up a calendar reminder to watch the site during next month's meetings and will report back.

No problem, @shrayshray, sounds like a plan! 👍

This, along with #790, has been staged ahead of tomorrow's meetings, @shrayshray!

@hancush Today's meeting didn't run over, but it was showing as "In Progress" and "Concluded" as expected! Will keep an eye out tomorrow as well.

Deployed.


contrib.layers: TypeError: optimize_loss() got an unexpected keyword argument 'summaries'

Trying to provide a custom list of summaries to tf.contrib.layers.optimize_loss fails
>>> import tensorflow as tf
>>> tf.contrib.layers.optimize_loss(tf.constant(1), tf.constant(1), 0.01, tf.train.AdamOptimizer, summaries=['loss', 'gradients'])
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: optimize_loss() got an unexpected keyword argument 'summaries'
>>>

Tested on a fresh 0.10.0rc0 install, as well as in the tensorflow/tensorflow:nightly docker image.
Little mystified by how this is occuring since the it's correct in source. I suspect it has something to do with everything being brought into the layers namespace.

Just checked with current version (0.11rc1) - doesn't seem to have this issue. Please re-open if it still persists on your side.


Can't send accented characters.

I've been using your WebSocketStompKit library.  Pretty great!  Thanks for making it.
I noticed an issue when trying to send special characters like é.  The count is calculated incorrectly, resulting in a failure to send the message.
I think there's a fix on line 372 of WebSocketStompKit.m.  You just need to calculate the length using UTF-8.
So the calculation should be:
[body lengthOfBytesUsingEncoding:NSUTF8StringEncoding]
in this file:
https://github.com/rguldener/WebsocketStompKit/blob/master/WebsocketStompKit/WebsocketStompKit.m#L372
Thanks again for this library.

Thanks for the report! Can you test the fix you proposed with your app and open a pull request please?
Thanks!

On 21 Oct 2015, at 20:13, Aaron Scherbing<EMAIL_ADDRESS>wrote:
I've been using your WebSocketStompKit library. Pretty great! Thanks for making it.
I noticed an issue when trying to send special characters like é. The count is calculated incorrectly, resulting in a failure to send the message.
I think there's a fix on line 372 of WebSocketStompKit.m. You just need to calculate the length using UTF-8.
So the calculation should be:
[body lengthOfBytesUsingEncoding:NSUTF8StringEncoding]
in this file:
https://github.com/rguldener/WebsocketStompKit/blob/master/WebsocketStompKit/WebsocketStompKit.m#L372
Thanks again for this library.
—
Reply to this email directly or view it on GitHub.

Sure thing.  When I get some free time, I'll submit that.
On Wednesday, October 21, 2015, Robin Guldener<EMAIL_ADDRESS>wrote:

Thanks for the report! Can you test the fix you proposed with your app and
open a pull request please?
Thanks!

On 21 Oct 2015, at 20:13, Aaron Scherbing<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:
I've been using your WebSocketStompKit library. Pretty great! Thanks for
making it.
I noticed an issue when trying to send special characters like é. The
count is calculated incorrectly, resulting in a failure to send the message.
I think there's a fix on line 372 of WebSocketStompKit.m. You just need
to calculate the length using UTF-8.
So the calculation should be:
[body lengthOfBytesUsingEncoding:NSUTF8StringEncoding]
in this file:

https://github.com/rguldener/WebsocketStompKit/blob/master/WebsocketStompKit/WebsocketStompKit.m#L372

Thanks again for this library.
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
https://github.com/rguldener/WebsocketStompKit/issues/3#issuecomment-150042104
.

--
Aaron Scherbing -<PHONE_NUMBER>

I had the same problem when trying to send latin characters like Š Č - this fix worked great!


Update try_out.rst (changed --local-id param to --model and moved notes about drivers.

Converted --local-id to --model to ensure that the commands work 😄
Moved the note about needing to have the vulcan driver before the core instructions -- this should be done before the rest of the instructions, so should appear before then.

Thanks @rojotek! Super timely fix!


potential listener LEAK detected renderActivityCount

Saw this while selfhosting
Version: 1.53.0-insider (user setup)
Commit: f3e95ede9e4b9818c29a5bca3564d6fd162fb210
Date: 2020-12-15T08:23:08.890Z
Electron: 11.0.5
Chrome: 87.0.4280.88
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19042

[847] potential listener LEAK detected, having 703 listeners already. MOST frequent listener (468):
check @ event.ts:452
event.ts:453     at file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:95:312
    at Object.onFirstListenerAdd (file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:95:452)
    at _event._event (file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:98:809)
    at new g (file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5050:627)
    at d._createInstance (file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1761:671)
    at d.createInstance (file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1761:92)
    at p.showViewActivity (file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:5051:824)
    at f.renderActivityCount (file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6118:568)
    at file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6117:86
    at file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:96:82
    at c.fire (file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:99:696)
    at p.$spliceGroupResourceStates (file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:4493:757)
    at m.$spliceResourceStates (file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:4495:914)
    at p._doInvokeHandler (file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:4529:202)
    at p._invokeHandler (file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:4528:901)
    at p._receiveRequest (file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:4527:554)
    at p._receiveOneMessage (file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:4526:385)
    at file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:4524:535
    at c.fire (file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:99:696)
    at fire (file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:447:356)
    at t.PersistentProtocol._receiveMessage (file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:452:525)
    at file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:449:519
    at c.fire (file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:99:696)
    at g.acceptChunk (file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:444:789)
    at file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:444:141
    at Socket.t (file:///C:/Alex/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:454:389)
    at Socket.emit (events.js:315:20)
    at addChunk (_stream_readable.js:295:12)
    at readableAddChunk (_stream_readable.js:271:9)
    at Socket.Readable.push (_stream_readable.js:212:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:186:23)
check @ event.ts:453

Great catch, this was a misuse of MutableDisposable.


[REQUEST/QUERY] Demarcation between rows of a table

Hi,
Going through the documentation and the library I didn't find a way where I could add a demarcation line between two rows of a table. My understanding is the box styles for the table are limited to the headers and footer. Additionally it seems like this is in the purview of the "row_styles". If so could you please give me pointers of achieving the same.
Thanks

You can set show_lines=True on the Table constructor.

Thanks a lot.


Update frame.tsx

@xinyao27 Hi I'm updating lines in frame.tsx to handle WebSocket for https. See SecurityError: Failed to construct 'WebSocket': An insecure WebSocket connection may not be initiated from a page loaded over HTTPS..

ty!


How do I use this?

I'm creating 3D letter using THREE.TextGeometry and THREE.Mesh and would like to have it collide with other letters using Cannon.js, much like http://schteppe.github.io/cannon.js/demos/collisions.html How do I run v-hacd ?  I'm sorry for such a basic question, but I couldn't figure it out.

How far did you get?

Haha what?  Sorry I gave in.  I hope you're able to get it.

Please, find below an example of command line to decompose a mesh. You can also use the Blender add-on (http://www.bulletphysics.org/Bullet/phpBB3/viewtopic.php?f=4&t=6619&start=30)
./testVHACD --input camel.off --output camel_acd.wrl --log log.txt --resolution 1000000 --depth 20 --concavity 0.0025 --planeDownsampling 4 --convexhullDownsampling 4 --alpha 0.05 --beta 0.05 --gamma 0.00125 --pca 0 --mode 0 --maxNumVerticesPerCH 256 --minVolumePerCH 0.0001 --convexhullApproximation 1 --oclDeviceID 2


setTaskDidSendBodyDataBlock & uploadTaskWithStreamedRequest 's block different between 4s .

why difference between about 4s ?
It course the MBProgressHud stay in screen 4s  with 100% progress

I'm confused? You can see those are clearly two different timestamps in the console from the left there. What are you expecting here?

Yeah, It is two  different timestamps. The cause of the problem is that the service side need to be processed for a period of time (about 4 seconds), so, when the progress bar reaches 100%, it will suspend there about 4 seconds, which makes the user experience is very bad. What is the good solution?

You are tracking two different things. The upload progress is complete, but the response does not come back in a timely manner.
There is no good way to track what you are trying to do, unless you merge together a few NSProgress's and manually calculate your server side delay times into it.


Configure Postgres with separate env variables

:warning: This PR depends on a yet-to-be-released Studio version, so please hold on merging
Some users may want to use Postgres variables with certain symbols such as @ in them. Unfortunately, this breaks the Postgres connection URI, as certain symbols get treated as delimiters.
To work around it, I've refactored the values and environment passed to Studio so that we always use separate environment variables for the Postgres configuration. This means that the previous fields:

global.postgres.databaseUrl
global.postgres.databaseUser
global.postgres.databasePassword

are now deprecated.

I bumped the Studio version to v2.4.0


Made tensorflow IsNan actually work

IsNan was added to tensorflow.rst in fa1b859f but this commit makes IsNan actually work

Thanks for the patch. Can you please add a test case for IsNan, to make sure it doesn't regress in future?

Thanks for the patch. Can you please add a test case for IsNan, to make sure it doesn't regress in future?

Thanks for the patch. Can you please add a test case for IsNan, to make sure it doesn't regress in future?

I'm not familiar with the code base. Where can I add this test? I tried following the example of IsInf, but it seems that IsInf doesn't have an analogous test. Is there another function that has an analogous test that I can use as a reference?

Thanks for the patch. Can you please add a test case for IsNan, to make sure it doesn't regress in future?

I'm not familiar with the code base. Where can I add this test? I tried following the example of IsInf, but it seems that IsInf doesn't have an analogous test. Is there another function that has an analogous test that I can use as a reference?

Thanks for the patch. Can you please add a test case for IsNan, to make sure it doesn't regress in future?

I'm not familiar with the code base, but I think the test will be similar to test_forward_isinf() in tests/python/frontend/tensorflow/test_forward.py. Is that the right approach?

cc @anijain2305 @siju-samuel @zhiics

Thanks for the patch. Can you please add a test case for IsNan, to make sure it doesn't regress in future?

I'm not familiar with the code base, but I think the test will be similar to test_forward_isinf() in tests/python/frontend/tensorflow/test_forward.py. Is that the right approach?

cc @anijain2305 @siju-samuel @zhiics


project abandoned. please dont write new issue

as the title says

if it's abandoned, please take it off the vscode marketplace

if it's abandoned, please take it off the vscode marketplace

i will, but im not the owner


feat: user feedback for containers expert view and store refactor

Description

[x] change services state to containers - for managing containers and keeping track of their state/stats
[x] make BaseNode slice responsible for starting and killing Base Node service (using the more granular container actions)
[x] BaseNode now shows user the health of the service, checking all services required to be run, showing which containers are not running correctly
[x] TabContent tag is synchronised with the same logic that BaseNodeContainer uses for calculating health
[ ] catching and showing errors on expert view containers when there is an error from backend - NEXT PR

Motivation and Context
#45 #7
How Has This Been Tested?

maybe it's overkill that BaseNode page reacts to Tor being started in expert view?
I'm not sure, tbh


NullReferenceException with ComputeBuffer and Disc shader using Universal Render Pipeline (URP)

Hi, I get this error when using Universal Render Pipeline and the ComputerBuffer type of rendering.
Discs show up in editor, but not in Game view and this error is thrown
NullReferenceException: Object reference not set to an instance of an object
Pcx.PointCloudRenderer.OnRenderObject () (at Library/PackageCache/jp.keijiro.pcx@1.0.0/Runtime/PointCloudRenderer.cs:88)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr)

Same problem here, using Unity 2020.2.2f1, Universal RP 10.2.2

@keijiro is setting var camera = Camera.main the correct solution here? I am running into the same problem.

I have this same issue and tried modifying the PointCloudRenderer script to the above suggestion. However, the change reverts back because the package gets revalidated (I think).
here is the warning: The package cache was invalidated and rebuilt because the following immutable asset(s) were unexpectedly altered:
Packages/jp.keijiro.pcx/Runtime/PointCloudRenderer.cs
How can I apply this fix?


Fix copy-paste errors in "GetXGroup" functions in orgs and spaces packages

LdapGroups option is not read when you have no org-manager or space-manager defined in org/space config. Probably it is a copy-paste error, here is a quick fix for this.

thanks @allomov


master source code download vs NuGet packages

I created a small test FTP server (with some custom connection handling) using master source code (by downloading the .zip file).
Now, I am trying to compile it against the NuGet package (I have tried the 2.0.0 and v3.0.0-beta3) but my application does not compile. It looks like number of classes have changed (e.g. PassCommandHandler and FtpConnection having different signatures as compared to the downloaded source code).
Any suggestion on resolving these issues will be appreciated.

You have to use the source code with the given tag.


Add gobal mean timeseries plot for AODVIS

Requested by the aerosol working group.

This is possible by adding variable AODVIS to atm_plot parameter through global_time_seris task.


GSI throws error when key field allows for undefined value.

The error message I'm recieving below is a bit confusing so I'm guessing what is going on.  But it looks like when i define a field as being able to be undefined, then i get the following error.  As far as I understand it should be possible to have an empty GSI key field.
Error: "mySecondaryId" is used in key {{mySecondaryId}}, thus it's type must be or scalar type, if attribute type is Enum, please set "isEnum" to true in attribute decorator.
@Entity({
  name: "myentity",
  primaryKey: {
    partitionKey: "{{id}}",
    sortKey: "{{someOtherField}}",
  },
  indexes: {
    MySecondaryIdIndex: {
      type: INDEX_TYPE.GSI,
      partitionKey: '{{mySecondaryId}}',
      sortKey: '{{id}}'
    },
  },
})

my secondary index field is defined as follows:
  @Attribute()
  mySecondaryId: string | undefined;

So setting this to useEnum made the error go away,  but at the same time I also noticed that this only will work on a string field.  If you have a GSI that is a Number this will fail.
Should this be logged as a bug?  Maybe to add an isNullable to the attribute decorator?

For being able to set the GSI attribute to optional, you don't have to define anything special as all secondary index keys are optional by default in DynamoDB and TypeDORM both, and this behaviour is defined as Sparse Indexes in AWS.
The error you are getting is probably because of the way the attribute is referenced in the Entity schema.
When keys are made up of simple attribute values and do not have any other complex pattern structure to them, the schema should be defined as aliases of attributes on the entity, as shown below
@Entity<TestEntity>({
  name: 'test-entity',
  table: testTable,
  primaryKey: {
    partitionKey: {
      alias: 'id',
    },
    sortKey: {
      alias: 'someOtherField',
    },
  },
  indexes: {
    GSI1: {
      type: INDEX_TYPE.GSI,
      partitionKey: {
        alias: 'mySecondaryId',
      },
      sortKey: {
        alias: 'id',
      },
      isSparse: false,
    },
  },
})
export class TestEntity {
  @Attribute()
  id: string;

  @Attribute()
  someOtherField: string;

  @Attribute()
  mySecondaryId: string | undefined;
}


Unable to connect to server

👓 What did you see?
I tried to enable the add on within VS code and had 3 error messages (attached)
✅ What did you expect to see?
I expected to see no error messages and the ability to auto complete steps
📦 Which tool/library version are you using?

🔬 How could we reproduce it?
I merely tried to enable the add on

See https://stackoverflow.com/help/minimal-reproducible-example
Please outline the steps below:
-->
Steps to reproduce the behavior:

Install '...' version '...'
Create a file called '....'
Run command '....'
See error '....'

📚 Any additional context?

This text was originally generated from a template, then edited by hand. You can modify the template here.

Thanks for raising @okinlai26, appears to be a duplicate of #cucumber/vscode/155. There's an incompatibility with the extension and VSCode versions 1.78 - 1.81. Can you update to the latest version of VSCode and check whether that resolves the issue for you. Otherwise would suggest to leave a comment on the linked issue or if you think is a separate issue, we can reopen this ticket. Cheers! 🙌


Recovery from OOM

I am instantiating an LLM class for local inference. I noticed that when an OOM error happens in vllm.LLM.llm_engine.step() and I capture it, previous requests are not aborted and would mess up with my next call to LLM.generate. I was wondering what is the proper way of recovering from OOM errors during inference?

@Ja1Zhou did you find a solution for this?

@Ja1Zhou did you find a solution for this?
I didn't. Had to make sure that no OOMs would occur.


[Feature Enhancement] : ✨Dark mode toggle✨

I have noticed a task has been assigned on it 2 days before and since there isnt any action on it , can you assign me the task? I'll work on it asap.
Thank you!

@T-Rahul-prabhu-38 I'll need to check with him first. Please avoid creating duplicate issues. If he’s unable to resolve the original issue, I’ll assign it to you directly.

sure!   looking forward to it.


A user with "admin" role should be able to manage users

If you login to the demo, you'll get a list of users http://yawik.org/demo/de/user/list

The List is generated via the UserController
https://github.com/cross-solution/YAWIK/blob/develop/module/Auth/src/Auth/Controller/UsersController.php
The following Features are missing and should be implemented.

detail views of a user. Users Details should be editable by the admin.

User account should be able to deactivate.

Details follow.

The list of Users should have an additional column with links to edit the Users Data. They can be simply added to the view
https://github.com/cross-solution/YAWIK/blob/develop/module/Auth/view/auth/users/list.ajax.phtml

The detail view of a User should look like .

It should be possible to reuse the Code for the Formular
https://github.com/cross-solution/YAWIK/blob/develop/module/Auth/src/Auth/Form/UserInfoContainer.php
In addition the admin should be able to deactivate a User. This means, we have to add an additional attribute to the user entity.
 /**
     * Status of the user
     *
     * @var Status
     * @ODM\EmbedOne(targetDocument="Status")
     * @ODM\Index
     */
    protected $status;

The status entity should look like our status entities for job and applications, but with the following states:
protected static $orderMap = array(
        self::ACTIVE => 50,
        self::INACTIVE => 60,
      );

https://github.com/cross-solution/YAWIK/blob/develop/module/Jobs/src/Jobs/Entity/Status.php
The findByLogin, findByProfileIdentifier, findByEmail and findByLoginOrEmail functions have to check for the Users status 'ACTIVE'.
To make it backward compatible we have to update all users and set status to "ACTIVE" where status does not exists.
https://github.com/cross-solution/YAWIK/blob/develop/module/Auth/src/Auth/Repository/User.php
On the detail page of a User an additional form container should allow the admin to change the status of a user.
@TiSiE , can you review please?

@fedys
We discussed yesterday about your feedback and came to the following conclusion about the handling of deactivated users:

The user repository will throw an exception (You already implemented a UserDeactivatedException) if find() or findOneBy() would return a deactivated user UNLESS a flag is provided, which explicitly allow such an entity to be returned.

The user repository will skip deactivated user entities on findBy(), unless the query provided explicitly sets the status field to be queried against. (analogically to the handling of drafts)

A listener (analogically to the UnauthorizedAccessListener will catch any UserDeactivatedExcpetion and sets an dedicated error template for that case. (With meaningful message such as "This user account has been disabled. Please contact the system adminstrator...")

The UserDeactivatedException should be moved to the \Auth\Exception namespace. (and following ZF practice implement the \Auth\Excpetion\ExceptionInterface)

By taking this approach we still allow code to handle deactivated users (by catching exceptions or explicitly query for) but at the same time have one central point (the Listener) to handle all other cases.

@TiSiE
ok, this sounds good. I am going to implement it.

this was completed by @fedys in https://github.com/cross-solution/YAWIK/commit/77b219c722cd3cf5cbb56cce557c281b86bac94f


Add wiring pathway : ASSY-77> Adpt.A64-Om32_2x-sm >RHD2164

See #56
@Enakcihc could you have a look and test with this plot
probe = get_probe('XXXXXXXXX')
wire_probe(probe, 'ASSY-77>Adpt.A64-Om32_2x-sm>RHD2164')
plot_probe(probe, with_contact_id=False,
                with_device_index=False)

@Enakcihc : I propose to merge this now. And to fix separtly the error on gin.


File preview in light terminal not readable with default theme

If I use the default terminal on linux Gnome with a light theme, the text on the right side isn't readable:

Seems like the colors in the preview are made for dark mode, but the filebrowser on the left site got black on grey text if I switch the terminal to dark mode:

The default syntax theme inside the fm.yml file is dracula which is better suited for dark themed terminals. You can change the syntax theme inside the config to something like pygments which should work on light and dark themed terminals. I might consider updating the default to something that is better suited for both

Thank you, pygments works better for me.
You wrote in your README.md "Colors adapt to terminal background" and in this issue #34 about support for different terminal backgrounds/themes.
Is there a way, to define different themes for light and dark terminal background?

Welcome! Let me look into this a little more and try to get something out there so light and dark syntax themes can be set in the config file

It's true that the syntax theme does not work with light mode right now, but judging from @sam9032's screenshot there seems to be another issue with fm's UI on the left. For example, the text color of the file size on the left is black for the dark terminal screenshot, although it should be white.
This has already been implemented in 550ff774d868cd4d7824ae8f72aed2e69a0fead5 and it works on my end (I get white text color on a dark terminal).
It looks like the terminal background detection is using the $COLORFGBG, perhaps this environment variable is not set on your configuration.
If you set $COLORFGBG, it should work, however the issue with the syntax theme of the displayed file is a problem that I am experiencing as well.

It's true that the syntax theme does not work with light mode right now, but judging from @sam9032's screenshot there seems to be another issue with fm's UI on the left. For example, the text color of the file size on the left is black for the dark terminal screenshot, although it should be white. This has already been implemented in 550ff77 and it works on my end (I get white text color on a dark terminal).
It looks like the terminal background detection is using $COLORFGBG, perhaps this environment variable is not set on your configuration.
If you set $COLORFGBG, it should work, however the issue with the syntax theme of the displayed file is a problem that I am experiencing as well.

Seems like gnome doesnt set the $COLORFGBG` variable? Its empty.
https://bugzilla.gnome.org/show_bug.cgi?id=733423
https://github.com/neovim/neovim/issues/2764

@sam9032 I opened up #81 let me know if something like that would be useful. It will allow you to set a light and dark syntax theme and then based on your terminal color it will use the appropriate one

@sam9032 I opened up #81 let me know if something like that would be useful. It will allow you to set a light and dark syntax theme and then based on your terminal color it will use the appropriate one

This would be amazing and exactly what I am looking for! Thank you :rocket:
I'm just afraid that libgloss or better termenv in libgloss builds on the $COLORFGBG and that's why no automatic detection in the Gnome terminal is possible at the moment.

Just tried this example in the termenv repo:
https://github.com/muesli/termenv/blob/master/examples/hello-world/main.go
And oddly enough it detects my terminal background correctly. :sweat_smile:

On a closer look, it looks like termenv only uses $COLORFGBG as
fallback. First it tries to use OSC 11 to request the background color,
which seems to be then working:
https://github.com/muesli/termenv/blob/89347d64da90146184f36fa636a743da8595fd42/termenv_unix.go#L67
Then if it is detected correctly, the only weird thing is that fm shows
black on black text color in your second screenshot.
Am Fri, Jan 21, 2022 at 05:53:42AM -0800 schrieb sam:

Just tried this example in the termenv repo:
https://github.com/muesli/termenv/blob/master/examples/hello-world/main.go
And oddly enough it detects my terminal background correctly. :sweat_smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/knipferrc/fm/issues/78#issuecomment-1018523920
You are receiving this because you are subscribed to this thread.
Message ID: @.***>

On a closer look, it looks like termenv only uses $COLORFGBG as fallback. First it tries to use OSC 11 to request the background color, which seems to be then working: https://github.com/muesli/termenv/blob/89347d64da90146184f36fa636a743da8595fd42/termenv_unix.go#L67 Then if it is detected correctly, the only weird thing is that fm shows black on black text color in your second screenshot. Am Fri, Jan 21, 2022 at 05:53:42AM -0800 schrieb sam:
…
Just tried this example in the termenv repo: https://github.com/muesli/termenv/blob/master/examples/hello-world/main.go And oddly enough it detects my terminal background correctly. sweat_smile -- Reply to this email directly or view it on GitHub: #78 (comment) You are receiving this because you are subscribed to this thread. Message ID: @.***>

It seems like fm doesn't change the theme while running. If I start with a dark terminal the colors on the left site seem to be fine. But if I switch to a light terminal theme while fm is open, it is even more beautiful :sweat_smile:

It seems like fm doesn't change the theme while running. If I start with a dark terminal the colors on the left site seem to be fine.

That is indeed very beautiful. Some terminals abuse the SIGWINCH signal to notify running terminals that the colorscheme changed (see e.g. https://github.com/neovim/neovim/pull/16030), but fm would first need to listen to that signal to support this kind of advanced runtime theme switching.

Yeah in its current state a change in theme of the terminal would require restarting fm. Also, the PR for dark and light syntax themes has been merged now, will cut a release a little later today


1.5.6 release

If current master is stable, why not make a new release?

It's on my todo list.
One of the things holding up a new release up where the IPython 4.0.0 problems but those seem to be solved now.
Time permitting I might release 1.5.6 today

Thanks!  Looking forward to the PyPi release.

@trbs:
Thanks!


ERRO Failed to query DNS from host: lookup api.crc.testing: no such host

OS Name:                   Microsoft Windows 10 Home
OS Version:                10.0.19041 N/A Build 19041
OS Manufacturer:           Microsoft Corporation
OS Configuration:          Standalone Workstation
OS Build Type:             Multiprocessor Free
Hypervisor: Hyper-V

Did you run crc setup before starting it (Yes/No)?
Yes
Running CRC on: Laptop

CRC version
CodeReady Containers version: 1.14.0+36ad776
OpenShift version: 4.5.4 (embedded in binary)

The following is run after the failure so it's expected at this point.
CRC status
DEBU CodeReady Containers version: 1.14.0+36ad776
DEBU OpenShift version: 4.5.4 (embedded in binary)
DEBU
ERRO Cannot get root partition usage: Error getting config for native Go SSH: open C:\Users\kpric\.crc\machines\crc\id_rsa: The system cannot find the file specified.
Cannot get root partition usage: Error getting config for native Go SSH: open C:\Users\kpric\.crc\machines\crc\id_rsa: The system cannot find the file specified.

CRC config
- nameserver                            : <IP_ADDRESS>

Host Operating System
Host Name:                 KEVIN-LENOVO
OS Name:                   Microsoft Windows 10 Home
OS Version:                10.0.19041 N/A Build 19041
OS Manufacturer:           Microsoft Corporation
OS Configuration:          Standalone Workstation
OS Build Type:             Multiprocessor Free
Registered Owner:          <redacted>
Registered Organization:
Product ID:                00326-10000-00000-AA723
Original Install Date:     07/07/2020, 20:26:04
System Boot Time:          07/08/2020, 18:34:56
System Manufacturer:       LENOVO
System Model:              20EQS64N09
System Type:               x64-based PC
Processor(s):              1 Processor(s) Installed.
                           [01]: Intel64 Family 6 Model 94 Stepping 3 GenuineIntel ~2712 Mhz
BIOS Version:              LENOVO N1EET89W (1.62 ), 18/06/2020
Windows Directory:         C:\WINDOWS
System Directory:          C:\WINDOWS\system32
Boot Device:               \Device\HarddiskVolume2
System Locale:             en-gb;English (United Kingdom)
Input Locale:              es;Spanish (Traditional Sort)
Time Zone:                 (UTC+01:00) Brussels, Copenhagen, Madrid, Paris
Total Physical Memory:     32,663 MB
Available Physical Memory: 7,832 MB
Virtual Memory: Max Size:  37,527 MB
Virtual Memory: Available: 8,910 MB
Virtual Memory: In Use:    28,617 MB
Page File Location(s):     C:\pagefile.sys
Domain:                    WORKGROUP
Logon Server:              \\KEVIN-LENOVO
                           [01]: KB4565627
                           [02]: KB4560366
                           [03]: KB4561600
                           [04]: KB4566785
                           [05]: KB4565503
Network Card(s):           10 NIC(s) Installed.
                           [01]: TAP-NordVPN Windows Adapter V9
                                 Connection Name: Ethernet 2
                                 Status:          Media disconnected
                           [02]: Intel(R) Dual Band Wireless-AC 8260
                                 Connection Name: WiFi
                                 DHCP Enabled:    Yes
                                 DHCP Server:     <IP_ADDRESS>
                                 IP address(es)
                                 [01]: <IP_ADDRESS>
                                 [02]: fe80::74d8:5382:4516:349
                                 [03]: 2a01:c50e:2181:a300:bd31:29ec:9722:6083
                                 [04]: 2a01:c50e:2181:a300:74d8:5382:4516:349
                           [03]: Intel(R) Ethernet Connection (2) I219-LM
                                 Connection Name: Ethernet
                                 Status:          Media disconnected
                           [04]: Nlwt Tun
                                 Connection Name: NordLynx
                           [05]: Bluetooth Device (Personal Area Network)
                                 Connection Name: Bluetooth Network Connection
                                 Status:          Media disconnected
                           [06]: TAP-Windows Adapter V9
                                 Connection Name: Local Area Connection 2
                                 Status:          Media disconnected
                           [07]: TAP-Windows Adapter V9
                                 Connection Name: Local Area Connection 3
                                 Status:          Media disconnected
                           [08]: Hyper-V Virtual Ethernet Adapter
                                 Connection Name: vEthernet (Default Switch)
                                 DHCP Enabled:    No
                                 IP address(es)
                                 [01]: <IP_ADDRESS>
                                 [02]: fe80::b89e:1878:5f17:2084
                           [09]: Hyper-V Virtual Ethernet Adapter
                                 Connection Name: vEthernet (WSL)
                                 DHCP Enabled:    No
                                 IP address(es)
                                 [01]: <IP_ADDRESS>
                                 [02]: fe80::e480:5b28:5c66:b6a2
                           [10]: Microsoft KM-TEST Loopback Adapter
                                 Connection Name: Ethernet 4
                                 DHCP Enabled:    Yes
                                 DHCP Server:     <IP_ADDRESS>
                                 IP address(es)
                                 [01]: <IP_ADDRESS>
                                 [02]: fe80::a4b6:7307:6e3:a005
Hyper-V Requirements:      A hypervisor has been detected. Features required for Hyper-V will not be displayed.

Steps to reproduce

crc setup
crc start

Expected
both internal and external DNS queries are successful
Actual
internal DNS resolution fails
Logs
logs
Comments
I managed to workaround this issue by capturing the IP of the VM before the DNS checks in the script happen and I added them in the etc/hosts file. This obviously points to an issue with how DNS resolution is happening with the default switch but I'm using a clean environment where no networking configuration has ever been done previously. There is some configuration steps missing from the deployment guide I feel.
I already tried creating a new switch named crc as suggested in other posts but this didn't resolve the issue. Bizarrely after removing that switch last night and reverting to the default switch the startup succeeded where it normally failed and then failed on public DNS resolution. I was able to fix that by setting a nameserver in the crc config. However, I left the cluster running over night and it went into a degraded state and I am now back to the same situation.
Is there something I might be missing with the networking configuration that needs to be done?
Other important notes: I use WSL2 + Docker Desktop. I am not aware of the feature LCOW and whether that is enabled, I cannot find it anywhere in my settings.

Other things I've checked:
Firewall logs show no dropped packets on DNS and TCP protocols for the IPs associated to the VM.
Switched off all Windows Defender Firewall settings and still the same result.

It looks like there is still an unresolved issue regarding the expected DNS configuration on Windows as mentioned in #756 . That issue links back to #751 where you can see the same workaround has to be applied as I was doing with the etc/hosts file. So aside from what seems to be missing documentation on DNS setup in Windows I think clearly there is some differences between certain Windows environments given that you are unable to reproduce this @praveenkumar . Is it possible to look at the Switch settings you are using to see if we can find some differences there? I am using the default switch and did not touch anything there, it has DHCP disabled by default and I see that it gets an IP and subnet mask assigned whilst the DNS entries are empty until the CRC VM is started up at which point the first DNS entry is populated with the IP of the VM. This to me seems expected so I'm not sure what is wrong here.
I have tried enabling DHCP on a custom switch called crc. The IP was set automatically once I shared my WiFi network with that switch and I populated the DNS entry with the IP of the VM as soon as it started up. It still failed with the following:
INFO Check DNS query from host ...
DEBU api.crc.testing resolved to [<IP_ADDRESS>]
ERRO Failed to query DNS from host: lookup foo.apps-crc.testing: no such host
Failed to query DNS from host: lookup foo.apps-crc.testing: no such host

Notice how the first internal DNS is resolved successfully on api.crc.testing but the next one on foo.apps-crc.testing fails. Why is this and what does CRC use that domain for?

Unfortunately we do not support deploying CRC on Windows 10 Home, until Microsoft officially launches the use of Hyper-V on this edition. When patched or modified we can not guarantee this works identical to the Pro edition of Windows due to other dependencies that might exist.

@gbraad The same behaviour is seen on Windows 10 Enterprise with Hyper-V using the current version of CRC.
OS Name:                   Microsoft Windows 10 Enterprise
OS Version:                10.0.17134 N/A Build 17134

CodeReady Containers version: 1.14.0+36ad776
OpenShift version: 4.5.4 (embedded in binary)

Out-of-the-box, the same DNS query failure occurs for api.crc.testing.
To get around this I used the same workaround as kevprice83, namely to edit the Windows 'hosts' file while 'crc start' was running to add the VM's IP address for the necessary mappings (api.crc.testing console-openshift-console.apps-crc.testing oauth-openshift.apps-crc.testing).
There is only a small window to do this, maybe 30 seconds between Hyper-V assigning an IP address and the start script reaching 'Check DNS query from host ...'
It has to be re-edited each time it is started as well, since Hyper-V doesn't always give the same address.

The reporter has been instructed to look into another issue to see if this helps: https://github.com/code-ready/crc/issues/1193
This was closed as being reported for Home. We have discussed this in an online session.


Potential thread leak

i noticed that one of my process is leaking threads. It could be due to not always closing the WorkflowManager. Any other possibility?. Here is an example of thread dump:
"SimpleQueue-0" #27573 daemon prio=5 os_prio=0 tid=0x00007f1068a92800 nid=0x6bc8 waiting on condition [0x00007f0f61d5c000]
java.lang.Thread.State: WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for  <0x00000000ca6ff380> (a java.util.concurrent.CountDownLatch$Sync)
at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836)
at java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedInterruptibly(AbstractQueuedSynchronizer.java:997)
at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1304)
at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:231)
at com.nirmata.workflow.queue.zookeeper.SimpleQueue.runLoop(SimpleQueue.java:197)
at com.nirmata.workflow.queue.zookeeper.SimpleQueue$$Lambda$17/1746711015.run(Unknown Source)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Locked ownable synchronizers:
- <0x00000000bb5b1ab8> (a java.util.concurrent.ThreadPoolExecutor$Worker)

I did some tests and I don't see any leaks. Are you certain it's not you?

Yes it could be me. I  am trying to isolate the problem. The question I was
asking was about this specific thread. Is there one associated to each
WorkflowManager? Understanding how this tread is created could help me to
isolate the problem.
On Wed, Mar 16, 2016 at 4:27 PM, Jordan Zimmerman<EMAIL_ADDRESS>wrote:

I did some tests and I don't see any leaks. Are you certain it's not you?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/NirmataOSS/workflow/issues/24#issuecomment-197602809

There's one for each scheduler of each TaskType. Then there's one for each task executor.

Is this still an issue?

I think I found an issue on my side: some of the workflow managers are
allocated dynamically and never released. You can close this issue.
On Mon, Mar 28, 2016 at 3:06 PM, Jordan Zimmerman<EMAIL_ADDRESS>wrote:

Is this still an issue?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/NirmataOSS/workflow/issues/24#issuecomment-202599257


[WIP] Upgrade opn to open

Resolve #619

This change requires Node.js 8 or higher. I will make another pull request to target Node.js 8.

Can you actually for the Node.js 8 bump into the same PR? I'd prefer we don't break the CI as other people might come by and wish to send PR.

@SBoudrias No problem.

I disabled promise/prefer-await-to-then temporary. Because we have to fix lots of functions in library and unit test. I think we could do this refactor job in another pull request.

Yeah no worries about that rule, it's not really important.


Add support for sruct composition

Hi.
Nice tool you developed here. I love the idea behind it.
However, I have a problem with it.
Take a look at the program below:
type A struct {
}

func (a *A) SomeFunc() {}

type B struct {
	A
	someField int
}

func main() {
	_ = B{someField: 42}
}

You raise an error in this case, but in my opinion, it's a perfectly reasonable piece of code. I only add the A struct in B to use its method implementation. I'm not interested in filling its fields, But exhaustruct makes me to do it.
 main.B is missing field A

I don't want to add an exception on struct B either because I may forget filling other fields of it in the future and I need exhastruct to check on its other fields.
Please contact me if you have any other questions regarding this issue.
Thanks!

You can use field tag to make individual fields optional.

Oh. Sorry. I didn't see this option.
Thanks!


Node Modules Compile Error

I'm getting compile errors as soon as I include import { createClient } from 'redis'; and I build tsc.  And not just a few, getting 223 errors.
This doesn't happen if I include via const redis = require('redis') which is not the recommended way.
The weird thing is tsconfig has node_modules excluded. And this never happened in a nother library before.

Environment:

Node.js Version: 12
Redis Server Version: redis:5.0.3-alpine (Not relevant. Will start using redis 6 after installing this)
Node Redis Version: 4.0.1
Platform: Mac OS 12.1

tsconfig.json:
{
  "compilerOptions": {
    "module": "CommonJS",
    "target": "ES2019",
    "sourceMap": true,
    "inlineSources": true,
    "strictNullChecks": true,
    "removeComments": false,
    "moduleResolution": "node",
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "forceConsistentCasingInFileNames": true,
    "noImplicitReturns": true,
    "skipLibCheck": true,
    "types": [
      "node",
      "mocha",
      "chai"
    ],
    "typeRoots": [
      "node_modules/@types"
    ],
  },
  "exclude": [
    "./node_modules"
  ]
}

Which version of TypeScript are you using (see #1781)?

Which version of TypeScript are you using (see #1781)?

^3.9.9

Ok so I need to upgrade Typescript to v4 before installing this. Thanks


MaxLength/MinLength: It's not trimming the string before validate

I'll close this due to inactivity. If it's still relevant, please, feel free to comment.


feat(k8s): Add Pod disruption budgets

Kubernetes allows a lot flexibility when it comes to cluster and node updates.
Cluster updates can happen at any time and can lead to massive interruptions (Guacamole not available) and session termination with potential data loss.
Pod discruption budgets define under which circumstances the cluster operator can terminate or restart Pods.
Our new policy is now:

For each service of the management portal, at least one Pod has to be up&running at any time.
Session termination by the control plane is not allowed. The cluster operator has to contact the system administrator or wait until the session is terminated.

Resolves #1089

Did my best to increase the test coverage by testing the start_session and kill_session functions. Patch coverage is still red as the general coverage of the k8s operator is bad. Overall coverage and k8s coverage are better.

Looks good.
Isn't it a bit overkill to create one PodDisruptionBudget per backend service?
I'm not sure how the PostgreSQL databases behave with this PDB: the database can be opened by one postgres instance at a time, right?

The PDB doesn't provide any information about how many Pods can run at the same time. It just says: Don't terminate the Pod if there is  other container of the deployment running. Now, this is kind of deadlock: It can't terminate the old Pod and doesn't start a new Pod because of the "Recreate" strategy type.
Now, the cluster operator has to decide what happens, sometimes they get in touch with the system administrators of the application and tell them to restart the database, sometimes they don't respect it at all.
Why we should still add the PDB: Cluster administrators can define a CronJob to disable / enable the PDB at specific times. This allows the system administrators to specific timeframes, e.g. during night, where updates are allowed.


404 on Flutter Web

Hello. All good?
I'm using it at startup (Flutter Web):
await FastCachedImageConfig.init(clearCacheAfter: const Duration(days: 7));
and then
FastCachedImage(
                          url:
                              kHandWithCellphoneWithoutContentWithPhotoTransparentBackground,
                          fit: BoxFit.cover,
                          scale: lpHomeViewModel.handScale,
                          fadeInDuration: const Duration(seconds: 1),
                          errorBuilder: (context, exception, stacktrace) {
                            return Text(stacktrace.toString());
                          },
                          loadingBuilder: (context, progress) {
                            debugPrint(
                              'Progress: ${progress.isDownloading} ${progress.downloadedBytes} / ${progress.totalBytes}',
                            );
                            return Stack(
                              alignment: Alignment.center,
                              children: [
                                if (progress.isDownloading &&
                                    progress.totalBytes != null)
                                  Text(
                                    '${progress.downloadedBytes ~/ 1024} / ${progress.totalBytes! ~/ 1024} kb',
                                    style: const TextStyle(color: Colors.red),
                                  ),
                                SizedBox(
                                  width: 120,
                                  height: 120,
                                  child: CircularProgressIndicator(
                                    color: Colors.red,
                                    value: progress.progressPercentage.value,
                                  ),
                                ),
                              ],
                            );
                          },
                        ),

When I run it locally, it works, when I use it in production I get a 404 for 'assets/images/landing_page/mao_com_celular_sem_conteudo_com_foto_transparente.png';
Can you help me?

It's possible that the file 'mao_com_celular_sem_conteudo_com_foto_transparente.png' is not properly included in your production build. Here are a few steps you can take to troubleshoot the issue:

Check if the file is included in the asset section of your pubspec.yaml file. Make sure it is spelled correctly and the file path is correct.

Run the command flutter clean to clear any previously built files and then rebuild your project using the command flutter build web --release.

Check the built files to see if the image file is included in the assets folder. You can find the built files in the build/web folder of your project.

If the file is still not included, try manually copying the file to the assets folder in the built files and then rebuilding your project.

If none of the above steps work, try changing the URL to the image file to an absolute URL and see if that works.


DoctorDark theme: Menu bar icons gray

I'm not sure if this is an issue with mySIMBL or with the DoctorDark theme, but with that theme enabled, certain menu icons are gray on gray.  See attached screen capture.  is there a way to change these icons to match the rest?

It's an issue with a plugin, I don't know which one. If I recall correctly it might be FullscreenER that causes that but I don't remember.
Next time I get some free time I'll try to look into which plugin causes this.

The only plugin that I'm using is the DoctorDark plugin.  Also, the font is flipped upside down.  That should probably be added as a new issue.  But here's what it looks like.

Did you activate reduce transparency? I tried to use Doctor Dark in the past and this option was causing problems.


improve the iOS camera plugin thread model

Use case
There have been multiple issues/crashes (for example, #52578, #59124) related to the thread model in iOS camera plugin, and multiple attempts (for example, #4140) to patch workaround fixes. We want to propose a long term solution to improve the thread model for iOS camera plugin.
Proposal
We wrote up a formal proposal to improve the thread model, with detailed execution plan in the end. There are also a couple non-threading issues that we'd like to address in the spirit of "yak shaving".

I think this is already what https://github.com/flutter/flutter/issues/52578 is tracking.  Can we close this, and you can just add a comment to that issue with a link to your proposal?

@jmagman Looks like #52578 only tracks the crash with calling engine API on the background thread. Though either way is fine for me.

Re-opened this issue to track various threading related tasks in the proposal

im closing this issue since all required action items are complete.


refactor: phase out anyhow in prqlc core

remove anyhow from the prqlc
clippy
refactor: remove anyhow from prqlc

Closes #4220

Well yes - we were only producing Error or String as the error types in the core compiler.
There were a few other errors which I converted to strings, all coming from from_text for parsing CSV and JSON. I've converted those to strings and wrapped into Error::new_simple().
But this makes sense: output of the compiler must be either successful compilation or an error message that points to a span of the source and maybe has hints.


Copy of: Add gnomad_gks() and get_gks() for extracting gks information for a specified variant

Copy of Pull Request "Add gnomad_gks() and get_gks() for extracting gks information for a specified variant" with only relevant changes included. The Git History got extremely confused when consulting with Steve Jahl, and his suggestion in the face of the problem was to copy the relevant changes to a new PR/branch, given how complicated to resolve the GitHistory would have been

rebased with Steve's method!


Question: making documentation with python?

Why did you use a python package and not a php solution?
because we love php ;-)

Hi,
Sphinx seems to be a very popular documentation solution and it looks good. :)
But of course, I'm open for suggestions.
Feel free to reopen if you have any more questions or feedback. :)


ParseException.java is always public

Despite the documentation on SUPPORT_CLASS_VISIBILITY_PUBLIC, the generated ParseException.java class is always public. As seen in the ParseException.template, there is no ${SUPPORT_CLASS_VISIBILITY_PUBLIC?public :} check like in other templates.
I encountered this issue while enabling the javadoc linter, since the constructors have missing @param descriptors in their documentation. While this may be a separate issue, I think the class visibility should still be consistent.

Well ...
1 - the documentation states that if the option is set to false the classes will be generated to private, which seems not to be true - it will have the default no modifier (package-private).
2 - I think that people how introduced this option thought that it would be needed for the support classes that are not usually directly used in the parsers' callers (like CharStream or TokenManager), but not for the more often used ParseException class (think : can one really write a tool T in package a that calls a parser P in package b without having to catch b.PE in a.T ?) :
3 - IMHO this option is not very interesting : if one wants to fine-grained control the generated classes, he should switch to javaCC 8 and customize the templates.
4 - for javacc 7 we'll have to fix either only the docs or the docs + the PE template.

Thanks for the quick response. To your points:

I think the documentation is fine. It states

If set to false, the classes will be generated with package private visibility.

The only misleading thing here may be the highlighting of the private keyword, since JavaCC does not actually generate a private class but a "package-private" class (i.e., the lack of all visibility modifiers).

The main appeal of this option (at least to me) is to hide the implementation details of the parser. So typically, I would just wrap the ParseException in a custom execption type and expose this type in the public interfaces. Especially if you have multiple grammars, you would have several (identical) ParseExceptions which clutter the API/documentation.

Can you maybe point me in the correct direction? Both javacc and javacc-8 seem to refer to the same artifacts. Although, to be honest, maintaining a custom template for a class I will probably never touch anyway seems to introduce an unnecessary maintenance burden.

ad 3) javacc 8 is consists of multiple Maven artifacts (the core + one generator for each output language), each has its own GitHub repo. The ParseException template is in https://github.com/javacc/javacc-8-java/blob/release/src/main/resources/templates/ParseException.template

Dear @zbynek, thanks for the heads-up. Unfortunately, I use the javacc-maven-plugin which does not seem to support the new javacc-8 version yet. But even if it did, both javacc and javacc-8 seem to load the templates as resources. So unless I hijack the classloader to inject my own template, I don't see a (convenient) way for providing custom templates, or am I missing something?
While I was able to workaround my initial problem, I still think the proper way to address this issue is to include the public check in the ParseException.template as well, just like in all the other templates. Given the documentation, I think this was the intention from the beginning and it just slipped through. I'm also happy to provide a PR, if you are willing to merge it.

I'm not sure if ParseException should count as "support class" though -- in most usecases ParseException will be used in the signature of public methods of the generated parser, and should therefore be also public. So maybe a new option is needed?
Btw. you linked this issue from a PR that's about Javadoc issues -- does that mean that the current ParseException is giving you some Javadoc warnings?

I'm not sure if ParseException should count as "support class" though -- in most usecases ParseException will be used in the signature of public methods of the generated parser, and should therefore be also public. So maybe a new option is needed?

I think I see the issue. In my use-case, I want the parser to be hidden from the public API which is why my parser definition (after PARSER_BEGIN) is package-private and I use SUPPORT_CLASS_VISIBILITY_PUBLIC = false;. However, you are concerned with the case of a public parser definition + SUPPORT_CLASS_VISIBILITY_PUBLIC = false;. In this case, the ParseException should probably be public, indeed.
Could this then probably be auto-detected upon parsing the parser definition? If the parser itself is package-private, even its public methods cannot be accessed outside of its package, so a package-private ParseException should be safe (and is probably intended by the grammar author). If the parser is public, the ParseException should be public as well, irrespective of the  SUPPORT_CLASS_VISIBILITY_PUBLIC value (as it is now).

Btw. you linked this issue from a PR that's about Javadoc issues -- does that mean that the current ParseException is giving you some Javadoc warnings?

Yes, doclint complained:
Warning:  Javadoc Warnings
Warning:  /home/runner/work/automatalib/automatalib/modelchecking/ltsmin/target/generated-sources/annotations/net/automatalib/modelchecker/ltsmin/ParseException.java:34: warning: no @param for currentTokenVal
Warning:  public ParseException(Token currentTokenVal,
Warning:  ^
Warning:  /home/runner/work/automatalib/automatalib/modelchecking/ltsmin/target/generated-sources/annotations/net/automatalib/modelchecker/ltsmin/ParseException.java:34: warning: no @param for expectedTokenSequencesVal
Warning:  public ParseException(Token currentTokenVal,
Warning:  ^
Warning:  /home/runner/work/automatalib/automatalib/modelchecking/ltsmin/target/generated-sources/annotations/net/automatalib/modelchecker/ltsmin/ParseException.java:34: warning: no @param for tokenImageVal
Warning:  public ParseException(Token currentTokenVal,
Warning:  ^
Warning:  /home/runner/work/automatalib/automatalib/modelchecking/ltsmin/target/generated-sources/annotations/net/automatalib/modelchecker/ltsmin/ParseException.java:60: warning: no @param for message
Warning:  public ParseException(String message) {
Warning:  ^

However, this was on JDK <17, so only incomplete docs are flagged. JDK >= 17 (and 21 most definitely) also flags any missing documentation on public members.

Ok, thanks. I note:

special processing for public / none modifier for ParserException: take the parser's class's one; not a "support" class
add decent javadoc comments for all public fields / methods: but what about the generated productions methods (marked final public): will they also need a javadoc comment?
clarify how to customize templates

By the way, in a close area, what do you think about the GENERATE_ANNOTATIONS option, which adds a @SuppressWarnings("all")? Should it be also used in all support class & ParseException? Knowing that TokenManager class is generated with @SuppressWarnings("unused").

@MarcMazas

add decent javadoc comments for all public fields / methods: but what about the generated productions methods (marked final public): will they also need a javadoc comment?

https://github.com/javacc/javacc-8-java/pull/4/files provides enough Javadoc to the generated classes, so that default checks should not fail -- a Javadoc check for the generated code was also added to CI to verify that. Whether that Javadoc counts as decent is a question, but it's a starting point and I'm happy to improve it if there's some feedback.
I'm not sure if Javadoc compliance is important enough for a 7.0 backport.
@mtf90

both javacc and javacc-8 seem to load the templates as resources. So unless I hijack the classloader to inject my own template, I don't see a (convenient) way for providing custom templates

If you're using Maven or Gradle plugins, you can just add the generated ParseException (with your improvements) to git in the right package under src/main/java, then the plugin won't generate another one. (Actually it generates it into temp folder, but then doesn't copy it to your classpath). Keeping a generated file in Git is not great, but it's the same as keeping the template (there is just 1 statement in the template that is optionally included, depending on a parameter).

Thanks @zbynek, your advice does work and allows me to provide a custom (package-private) ParseException.
Do you consider this issue as resolved then? While the ability to provide a custom implementation allows for a workaround and somewhat lessens the impact of the original issue, I think the downside of having to maintain this file as an actual source file still justifies thinking about the ability to adjust the generation process (either by means of auto detection of another config property).
Any opinions on this?

@mtf90 I don't think this is really resolved, my PR only addresses the second suggestion by @MarcMazas . It might still be useful to implement the first one (though I'd prefer to do all non-critical fixes only in JavaCC 8 and make them available to Maven users by cleaning up https://github.com/mojohaus/javacc-maven-plugin/pull/4).

Just tested on javacc 7, under an ant script: in your product's project:

create a specific resource directory: eg: src/main/javacc-resources and a sub-directory templates
copy under templates any template you want: eg ParserException.template and modify it
set your javacc generation java task with such a classpath: src/main/javacc-resources:<path-to-javacc-7.0.n.jar>
do not set the JAVA_TEMPLATE_TYPE option to "modern", keep the "classic" default

and you should get the corresponding support file generated from your template.
I let somebody find if there is a direct solution for maven (scope provided or system for the different javacc-maven-plugin (s)?).


Course not added after getting merged.

@lewtun I am creating this pull request to let you know about the crashed documentation from HI/Chapter1 from 5.mdx to 10.mdx including Quiz. I'm not able to see that on the MAIN Branch of documentation. It gives an error - "The course page CHAPTER1/5 doesn’t exist in hi, but exists on the English version. Click here to redirect to the English version of the course."
I think the problem occurred while building documentation action runs before merging into the MAIN Branch.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Hi @pandyaved98 are you referring to the quiz URL as the problem: https://huggingface.co/course/hi/chapter1/10?fw=pt ?
I see that it's giving a 500 error, so gently pinging @mishig25 for some insight into what might be causing this 🙏
FYI the doc builds fine for this section: https://github.com/huggingface/doc-build/tree/main/course/main/hi/chapter1


How to 301 redirect all uppercase urls to lowercase

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting questions.
[X] I have removed any sensitive information from my code snippets and submission.

App Id
d3iwl33i8l297g
AWS Region
us-east-1
Amplify Hosting feature
Redirects
Question
I have a react app hosted on amplify.
How to 301 redirect all uppercase urls to lowercase?
For example - https://www.example.in/tg/Dog-Cat to https://www.example.in/tg/dog-cat

Hi @aditya-gogobus 👋🏽 for this type of scenario you can add a redirect rule like so:
 {
        "source": "/Dog-Cat",
        "target": "/dog-cat",
        "status": "200",
        "condition": null
    }

In this case, you'd have to add a redirect rule for every lowercase target address.
I'm currently investigating if there is a way to create one redirect rule that works for any url and will get back to you once I have more information.

Upon further investigation, we do not support dynamically transforming the URL in redirects. If you would like to redirect uppercase URLs to lowercase URLs using Amplify, you will have to add a redirect rule for each target address. We apologies for this inconvenience.


Incorrect handling of finally block in async generator

Describe the bug
The generator finally block is called on every yield, not just on termination.
Input code
(() => {
  async function* generator() {
    try {
      while (true) {
        yield "value";
      }
    } finally {
      console.log("exit generator");
    }
  }

  async function test() {
    let output = 0;
    for await (const val of generator()) {
      console.log(val);
      output++;
      if (output === 2) {
        break;
      }
    }
  }

  test();
})();

Config
{
  "jsc": {
    "parser": {
      "syntax": "typescript",
      "tsx": false
    },
    "target": "es5",
    "loose": false,
    "minify": {
      "compress": false,
      "mangle": false
    }
  },
  "module": {
    "type": "es6"
  },
  "minify": false,
  "isModule": true
}

Playground link
https://play.swc.rs/?version=1.3.2&code=H4sIAAAAAAAAA2WPwQ7CIBBEz%2FYrJj2BJsZ4beq%2FYF2USMDQxdqY%2FrvUim30AuyyM%2FtGCIn6gGcBqLZ3DXR0DRvv1jiTo6DYhzQy%2FgMc%2Bs8L6C7GEgSHSPLbBHpD9oTyrmyksvq0h%2Fc9QBunrJ09Gu9ab2lr%2FVmU9DA87yzlJB6lQ%2FFHB6aWv1yWGD7yLTJq7Cah9gGqU8lTjGsYCQleL1Nl%2BWrJkcZk5p48N5tcGw2R99Q19svgx0Dq%2BhM4s0%2BwVTHIdL4AD7K37nIBAAA%3D&config=H4sIAAAAAAAAA0WNSwrDMAxE76J1ts0id%2BghjKsEF%2F%2FQKBBjfPfawSU7aebpqdIXlrZK2QhYxoQS1Vy0kZbMsOKy0kKKHu3Gg1tfjBysHWG8eudTAs92oeCi28sw2RSyMPBUJh7%2BT7YuCulzjqDez27hSu1xzDuH9wRVTm4%2FOkwQUrUAAAA%3D
Expected behavior
value
value
exit generator
Actual behavior
value
exit generator
value
exit generator
Version
1.3.2
Additional context
No response

@kdy1 I did search apologies; I wasn't aware that the behaviour here was the same root cause [in this case there is no yield in the finally block but it still is incorrectly executed]


Add Hive icon to Electron

Hive is a fast growing teamwork tool. See https://hiveteams.com and https://www.crunchbase.com/organization/hive-technology#/entity.
Thanks!

Cool, thanks @jfurneaux!


don't show duplicate songs in library

So some song are appearing like 4 times, because I apparently have 4 copies of the same song. Could duplicates be hidden?
feature request

The philosophy of a music player is one file = one track. Why do you have multiple times the same track? I’d like to understand the use case :)

Do you know any other music player who act like you would like? Genuinely curious.

Grove music player on android did I think, I know of one other on ubuntu that did it but i can't remeber

Once/If we'll have a criteria to call N tracks "identical", I think it will be helpful to have a way to identify their location better somehow, so that people can understand where duplicates are coming from


Layer Norm before Residual

Hello, I noticed that on line 186 in model.py you put layer norm before MultiHeadAttention and Residual, as opposed to putting Layer Norm after Residual as described in the original Transformer paper.
def forward(self, x: torch.Tensor):
    x = x + self.attention(self.ln_1(x))
    x = x + self.mlp(self.ln_2(x))
    return x

In my research I found this paper which argues that such configuration improves convergence and removes the need for careful warmup.
In my experiment when I used your implementation of Transformer Block for seq2seq model 1 layer works pretty nice, however when I stuck 2 layers performance significantly degrades.
So my questions are: What is the reasoning behind it? And how to make it work with stacked layers?

The linked paper shows some reasoning behind using normalizations in the residual branch as opposed to the main trunk. One intuition is that keeping an identity mapping flow helps stabilize the training, as suggested by He et al. (2016), as opposed to going through multiple layer normalization ops proportional to the depth. This approach is adopted in most of OpenAI models since GPT-2, as outlined in page 4, column 2 of the GPT-2 paper and Figure 8d of the Jukebox paper.


Assets-Cargo Train for Ore materials

Create a new asset for cargo train where the station only store and load goods derivates from ore natural resources.

Replace the assets used and duplicated from Railway Infrastructure mod so we can avoid any issues by using an asset from other author.

Included in #17


fix: compatibility with TreeNodeInterface

Anyone? Is this project dead?

Hi, the project is not dead, @TomasVotruba is just busy with something else.
But I think you can start to make the CI green! :)

That's how free and open-source work, Tomas does not owe anything to us.
If it's urgent for you, you can use your own fork instead.

@Kocal I don't get it really.. There was an issue with this bundle, I submitted a fix. So I spent my time to do the fix and 19 days so far the code is not merged..
Don't get me wrong I don't need this anyway and I'm not on a rush. Just explain to someone else how the open-source works.

@netbull Thank you for pull-request :+1: I've probably missed this in amount of open-source notifications I'm getting. I'm sorry about that.
I've just updated to PHPStan Symplify rule sets, that include a rule that checks exactly this types conflitcs with traits/classes/interfaces: https://github.com/symplify/phpstan-rules/blob/main/docs/rules_overview.md#checkparentchildmethodparametertypecompatiblerule
Saying that, I've fixed this ~30 minutes ago and released in 2.3.0: https://github.com/KnpLabs/DoctrineBehaviors/commit/35ba29cefdfa18778f5273e1dc7c156f43d92340#diff-b02f17f75334fed0fdfe5a8777457e2e429c746224a9f7c2b661b3588eeb9819
@Kocal Thank you for support here :heart:

@TomasVotruba don't worry :) Thank you!


drivers/sensor: lis2dh: use gpio_dt_spec oriented macros

Use gpio_dt_spec structure and related macros for both drdy
and AnyMotion interrupts, to have a more compat, readable and
safe code.
This commit also fixes the bug #34794.

I added DNM as I'm not sure it fixes #34794 (not able to replicate it). It's something that should go in anyway, but I want also to be sure it fixes that issue.

@mbolivar-nordic I would like to get your opinion on device_is_ready() usage when the pointer is NULL.

@mbolivar-nordic I would like to get your opinion on device_is_ready() usage when the pointer is NULL.

What opinion, sorry? We discussed making device_is_ready() return false when the argument is NULL and I think that makes sense.

@mbolivar-nordic I would like to get your opinion on device_is_ready() usage when the pointer is NULL.

What opinion, sorry? We discussed making device_is_ready() return false when the argument is NULL and I think that makes sense.

So is device_is_ready() currently returning false if arg is NULL? Is it really the case?

So is device_is_ready() currently returning false if arg is NULL? Is it really the case?

Sorry, no, I'm saying it would make sense for that to work. You cannot pass NULL to device_is_ready() right now, at least the last time I checked.

So is device_is_ready() currently returning false if arg is NULL? Is it really the case?

Sorry, no, I'm saying it would make sense for that to work. You cannot pass NULL to device_is_ready() right now, at least the last time I checked.

ok, I'll do in a separate PR

ok, I'll do in a separate PR

#32367 is somewhat relevant but isn't going anywhere.  So is #32587 but it needs a shepherd.

ok, I'll do in a separate PR

for anyone watching: https://github.com/zephyrproject-rtos/zephyr/pull/35268#pullrequestreview-659096162

ok, I'll do in a separate PR

for anyone watching: #35268

This PR depends on that one, right?

@MaureenHelm
Actually no, there is no strict dependency between this PR and #35268.
But debugging an issue for which this PR is (maybe) a solution (and for sure a code semplification), I also observed yesterday that there is a device_is_ready() misusage (actually quite spread over zephyr code).

there is a device_is_ready() misusage (actually quite spread over zephyr code).

@avisconti do you have pointers for this?
I wonder if there is some way to annotate the function so coverity knows it can't take null, and likewise annotate things like DEVICE_DT_GET_ANY so coverity knows they may return null, to start to get some static coverage for this.

there is a device_is_ready() misusage (actually quite spread over zephyr code).

@avisconti do you have pointers for this?
I wonder if there is some way to annotate the function so coverity knows it can't take null, and likewise annotate things like DEVICE_DT_GET_ANY so coverity knows they may return null, to start to get some static coverage for this.

I'm answering on #35268. This PR is somehow related, but its intent is more a code simplification.

@avisconti / @mbolivar-nordic did you guys come to resolution on this?

@avisconti / @mbolivar-nordic did you guys come to resolution on this?

I didn't look at this PR since I thought it was a new feature; I missed it was a bugfix also. Looking at it now

@MaureenHelm
Hello Maureen, can you take a look to this PR again?


CAMERA_STREAM doesn't work anymore on the latest versions, while it always worked fine in previous versions of Tileboard

This is the code I used successfully for months, to have the camera streams directly accessible on specific Tileboard pages:
{
                     position: [0, 0],
                     width: 5,
                     height: 3,
                     type: TYPES.CAMERA_STREAM,
                     id: 'camera.front_door_cam',
                     bgSize: 'contain',
                     state: false,
                     bufferLength: 5,
                     fullscreen: {
                        objFit: 'cover',
                        type: TYPES.CAMERA_STREAM,
                        entity: 'camera.front_door_cam',
                        bufferLength: 5
                     },
                     refresh: function() { return 3000 + Math.random() * 500; },

                  },

This has always worked fine, but for some reason I do not see any streams anymore - it's just a blank screen. Similarly, when I click on it, it will also have a blank screen, no streaming happening.
I did put stream: in my config.yaml in HASS, and I can access the live stream in regular Home Assistant Lovelace just fine, which seems to point to Tileboard being the issue. For example, on one of my Lovelace pages, I have this code:
- type: picture-entity
   entity: camera.front_door_cam
   camera_view: live
   show_state: false

Which shows the camera stream directly, it works perfectly fine.
Any ideas on how to get the camera stream to work again in Tileboard?

What browser / device are you trying this on? Does it misbehave on all of them, even the modern ones?
Can you open TileBoard in a browser with developer tools opened and check if there are any relevant errors in the console
If not, can you check the Network tab in developer tools and check if there are any failing requests?

What browser / device are you trying this on? Does it misbehave on all of them, even the modern ones?
I'm testing on both Fully Kiosk Browser on an Android tablet, as well as the latest version of Firefox (83.0, 64 bit).

Can you open TileBoard in a browser with developer tools opened and check if there are any relevant errors in the console
Yes, in Firefox I get this error:

GET http://<IP_ADDRESS>:8123/local/tileboard/index.html/api/hls/b316fca4b00192b4bc475fe7d764b94d6c9fj3e365b5488c5d0bf292a2cf5339/master_playlist.m3u8  [HTTP/1.1 404 Not Found 0ms]

Seems like it's looking for the HLS stream in the wrong location? Again, the streams work fine from within Home Assistant and the Lovelace frontend.

What do you have CONFIG.serverUrl set to?

From my config.js:
serverUrl: "http://<IP_ADDRESS>:8123/local/tileboard/index.html",

It should be just the HA origin so http://<IP_ADDRESS>:8123

That fixed it! Thank you @rchl, appreciate the help!


[dkr] Add azcopy and gsutil to tools image

Add azcopy and gsutil to support backup in Azure and GCP. Install
gsutil using the standalone method instead of installing the entire
Cloud SDK: https://cloud.google.com/storage/docs/gsutil_install#alt-install

/land

:boom: Tests timed-out

/land


Write migration instructions to v2.0.0

#4 introduces a backwards-incompatible change (the cloud formation script has an updated template and the stack no longer creates its own VPCs). There needs to be migration instructions for upgrading.
Alternatively, it may be possible do do that change in a backwards compatible way by allowing the games to be created with or without a custom VPC.

Steps are likely to be something like:

Take a backup of old game
Remove old game
Re-create game with the same mods
Upload the backup to the autosave folder

Done :)

For any games that can be archived:

Make sure there is an appropriate backup and save the link somewhere.
Delete the game using !delete .

For any games to be carried over:

Download the latest backup.
Update the bot
Re-create the game (with a new name). Make sure the version and mods are the same as the original.
Copy the backup into the saves folder: scp -i <key.pem> <backup-file> ec2-user@<ip>:/opt/factorio/saves/
(Optional) SSH into the server and check that the settings/save file all looks good.
Join the game - it should now be working ?!

For any games that can be archived:

Make sure there is an appropriate backup and save the link somewhere.
Delete the game using !delete .

For any games to be carried over:

Download the latest backup.
Update the bot
Re-create the game (with a new name). Make sure the version and mods are the same as the original.
Copy the backup into the saves folder: scp -i <key.pem> <backup-file> ec2-user@<ip>:/opt/factorio/saves/
(Optional) SSH into the server and check that the settings/save file all looks good.
Join the game - it should now be working ?!

Closing as the upgrade has been done.


Write log to file

#185

Codecov Report

Merging #187 (2971fbf) into main (d3e9b93) will decrease coverage by 0.49%.
The diff coverage is 65.51%.

@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
- Coverage   97.18%   96.68%   -0.50%
==========================================
  Files          45       45
  Lines        2270     2295      +25
==========================================
+ Hits         2206     2219      +13
- Misses         37       47      +10
- Partials       27       29       +2

Impacted Files
Coverage Δ

dtmsvr/config/config.go
100.00% <ø> (ø)

dtmsvr/svr.go
80.28% <0.00%> (-10.20%)
:arrow_down:

dtmcli/logger/log.go
93.47% <90.47%> (-3.08%)
:arrow_down:

dtmsvr/trans_type_saga.go
95.80% <0.00%> (-1.40%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3e9b93...2971fbf. Read the comment docs.


Possible to extract reference block text as task label?

Hi there, I love this extension so much! I've tried all the todo apps and this one works for me, and also keeps me motivated to keep maintaining a todo list for the simple fact that it doesn't suck.
I know from the documentation that:

You can use Roam references to blocks in your task list. It means you can just Alt/Option + drag and drop tasks from other pages/blocks without having to rewrite them from scratch.

I am indeed able to add reference blocks, but the label shown is the reference number:

Is it possible to make it so it is the actual text that is shown? Could I be doing something wrong? If not, please consider this request, please and thank you!

Hi, Carlisia, thank you for your nice words. It actually should work like you are suggesting, at least up to one level of referencing depth. Could the reason be you are somehow referencing already referenced content?
If you need help, we can simply connect over Zoom or whatever tool some day and try to debug the issue :)


Remove unnecessary files

There are 2 unnecessary files in the DesignPatterns/ActiveObjects folder that can be removed.
Files:

../Open_GDS/ClassProviders/DesignPatterns/ActiveObjects/ActiveObjects_DynamicEvents_SubVIs_VIT.aliases
../Open_GDS/ClassProviders/DesignPatterns/ActiveObjects/ActiveObjects_DynamicEvents_SubVIs_VIT.lvlps

I placed them there when I was testing my own ActiveObject template

Hmm, I don't see those in the repo

This should be fixed in the next release, I've removed them from the master branch


Discover Page: Add "Published" as a value under the "Filter by Availability" facet

This would help in limiting search results to include only formally published resources.

same as #1185


Added global settings for part and category

Fixes #268
Updated sections:
https://inventree--273.org.readthedocs.build/en/273/settings/global/#parts
https://inventree--273.org.readthedocs.build/en/273/settings/global/#categories

Nice work thanks @eeintech


Pop-up of detail page whenever a button is clicked

Checklist

[x] I'm running the latest version of CustomUI (Update guide) or using a specific release that is not marked as "Broken".
[x] I tried to force-refresh (Ctrl+Shift+R / Ctrl+F5) the browser
[x] I'm using IOS App to reproduce. Chrome Browser does not have this issue.

Browser + Version: iPhone 6s Plus, iOS 10.3.3

CustomUI version: Updated as of 30 March 2018
Home Assistant release (hass --version): 0.65.6
Recently I updated to the latest Home Assistant to 0.65.6 and noticed that the on, off buttons that I created start to pop-up the detail page whenever it is clicked. This does not happened prior to the update because “ev.stopPropagation();” is used as advised.
How do I now stop that pop-up from appearing? For example if I press Storeroom Light “ON”, the detail page will appear. I will need to close it in order to go back to the main.

The UI doesn't look familiar.
Could you post the relevant config part?

The UI is from the IOS Home Assistant App. The state-card-custom I used is as below for reference. Another guy from Home Assistant Community advised to change the "on-tap" to "on-click" and this is resolved.
<dom-module id="state-card-custom_fan1">
  <template>
    <style is="custom-style" include="iron-flex iron-flex-alignment"></style>
    <style>
      :host {
        line-height: 1.5;
      }
      paper-button {
        min-width: 29px;
        height: 30px;
        background-color:#f3f3f3
      }
    </style>

<div class='horizontal justified layout'>
  <state-info state-obj="[[stateObj]]"></state-info>
  <paper-button-group>
      <paper-button on-tap="btnlow">L</svg></paper-button>
      <paper-button on-tap="btnmed">M</svg></paper-button>
      <paper-button on-tap="btnhigh">H</svg></paper-button>
  </paper-button-group>
</div>
</template>
</dom-module>
<script>
        Polymer({
          is: 'state-card-custom_fan1',
          properties: {
            hass: {
              type: Object,
            },
            stateObj: {
              type: Object,
            },
          },

          btnlow: function (ev) {
            this.setVol('fan_speed_low', ev);
          },
          btnmed: function (ev) {
            this.setVol('fan_speed_med', ev);
          },
          btnhigh: function (ev) {
            this.setVol('fan_speed_high', ev);
          },

          setVol(vol,ev) {
            var serviceData = {entity_id:('scene.'+vol)};
            this.hass.callService('scene', 'turn_on', serviceData);
            ev.stopPropagation();
  },

});
</script>