Adds a novels table to the DB schema

Description
This PR adds a novels table to the DB schema. This table will be used to link chapters together as part of a larger whole story.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Number of files changed
1 file changed
1 commit
24 additions
No deletions
Change Status

[ ] Complete, tests written, ready to review and merge
[x] Complete, but no tests written or needs new tests
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

If Tested, how?

[ ] Production
[ ] Locally

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] There are no merge conflicts
[x] Gone through Lambda Rubric?
[x] At least 2 reviewers assigned

Next steps(if applicable)

Questions for reviewer?
Known problems in PR?
[ ] Comments left for PR?
[ ] Suggestions completed?

Creating a new PR to fix Prettier errors

Creating a new PR to fix Prettier errors


Duplicate keys for cool

Originally reported in https://github.com/plotly/plotly.js/issues/5457
Which "cool" is the cool?
https://github.com/bpostlethwaite/colormap/blob/cb22a04d23b9fd47a6663d80d44ad77594bd394a/colorScale.js#L8
Or
https://github.com/bpostlethwaite/colormap/blob/cb22a04d23b9fd47a6663d80d44ad77594bd394a/colorScale.js#L58

Both added around the same time.
$ git blame colorScale.js -L8,+1
b0502b98 colorScales.js (Dmitry 2016-05-20 18:57:21 -0400 8)    "cool":[{"index":0,"rgb":[0,255,255]},{"index":1,"rgb":[255,0,255]}],

$ git blame colorScale.js -L58,+1
1601f158 colorScales.js (Dmitry 2016-05-20 19:46:44 -0400 58)   "cool": [{"index":0,"rgb":[125,0,179]},{"index":0.13,"rgb":[116,0,218]},{"index":0.25,"rgb":[98,74,237]},{"index":0.38,"rgb":[68,146,231]},{"index":0.5,"rgb":[0,204,197]},{"index":0.63,"rgb":[0,247,146]},{"index":0.75,"rgb":[0,255,88]},{"index":0.88,"rgb":[40,255,8]},{"index":1,"rgb":[147,255,0]}],

@alexcjohnson seems like we could safely remove the first one, right?

Actually it is the side effect of #6.

BTW the first cool appear to be similar to matlab's: https://www.mathworks.com/help/matlab/ref/cool.html
cc: @dy

Yes, we can certainly drop the first one - it's been there for nearly 5 years so recent backward compatibility is more important than original intent at this point.
It's a bit unfortunate that plotly.js includes these scales at all though, since it's a different set than we already have - a lot of overlap but some differences and different conventions. Are there cases where surface, cone, or mesh (those are the places this is referenced according to npm ls colormap) can access these scales rather than the ones we define within plotly.js?
There are a lot more scales here that we don't include, but the parts we have that this package misses:

Cividis
Blues
Reds
This package still has the typos yignbu and yiorrd instead of ylgnbu and ylorrd


Socks issue when connecting to node over Tor

Background
For some reason, I am unable to create a peer connection over Tor.  lncli connect is resulting in an ambiguous Socks error. I have access to both of the nodes (connecting side and the one where the connection is being made to).
On the connecting side, I am able to connect to other nodes over Tor. It is my other node that I am unable to connect to for some reason. I tried debugging on both ends, but not getting any meaningful output in the logs, even if debuglevel is increased.
To make things even more interesting, I'm able to connect to other nodes over Tor from the node I am unable to connect to.
Would be very grateful for any tips on how to debug this further. I'm more than convinced that it is an issue with the configuration, might just need a few pointers.
Environment

Ubuntu 20.04 LTS
lnd - v0.14.1-beta
bitcoind - v22.0
tor - v<IP_ADDRESS>

Steps to reproduce
On the target node side
I'm using a custom Docker setup with the following configuration (shortened) -
version: "3.5"
services:
  lnd:
    image: lightninglabs/lnd:v0.14.1-beta
    container_name: lnd
    restart: unless-stopped
    depends_on:
      - bitcoind
      - tor
    networks:
      - ln-network
    ports:
      - 9735:9735
    volumes:
      - ./mount/ssd/lnd:/root/.lnd
  tor:
    image: osminogin/tor-simple:<IP_ADDRESS>
    container_name: tor
    restart: unless-stopped
    networks:
      - ln-network
    volumes:
      - ./mount/ssd/tor:/var/lib/tor
      - ./mount/ssd/tor-config:/etc/tor
      - ./mount/ssd/tor-data:/srv/tor
networks:
  ln-network:

Also torrc configuration:
# Bound to external interface to be able to communicate with other containers
SocksPort <IP_ADDRESS>:9050
ControlPort <IP_ADDRESS>:9051
Log notice stdout
ExitRelay 0

And lnd.conf:
[tor]
tor.active=true
tor.v3=true
tor.streamisolation=false
tor.privatekeypath=[keypath]
tor.socks=tor:9050
tor.control=tor:9051
tor.password=[removed]
tor.skip-proxy-for-clearnet-targets=true

Expected behaviour
Should be able to connect to to the target node over Tor.
Actual behaviour
Tor connection fails with error message:
[lncli] rpc error: code = Unknown desc = socks connect tcp <IP_ADDRESS>:9050->[removed].onion:9735: unknown error general SOCKS server failure

For the node from the connecting side, what's the setup looking like?

The connecting side is a Raspiblitz setup with lnd 0.13.0-beta.

The connecting side is a Raspiblitz setup with lnd 0.13.0-beta.

Oh ok, so you do have two separate machines running tor. You may need to change the tor's log level to find out more as the ambiguity is intended by tor. Maybe change this line Log notice stdout from notice to info or debug and see what error is returned inside tor.

The connecting side is a Raspiblitz setup with lnd 0.13.0-beta.

Oh ok, so you do have two separate machines running tor. You may need to change the tor's log level to find out more as the ambiguity is intended by tor. Maybe change this line Log notice stdout from notice to info or debug and see what error is returned inside tor.

Thanks for the tip. I did some digging - found something that might point towards the issue.
On the connecting side, Tor info.log:
...
[info] link_apconn_to_circ(): Looks like completed circuit to hidden service does allow optimistic data for connection to [removed]
...

On the Docker setup, Tor logs the following (with log level set to info):
...
[info] connection_handle_write_impl(): in-progress connect failed. Removing. (Connection refused)
...

With increased log level - debug:
[debug] connection_exit_connect(): about to try connecting
[debug] connection_connect(): Connecting to "(rendezvous)":9735.
[debug] connection_connect_sockaddr(): Connection to socket in progress (sock 14).
[debug] connection_add_impl(): new conn type Exit, socket 14, address (rendezvous), n_conns 8.
[debug] connection_or_process_cells_from_inbuf(): 9: starting, inbuf_datalen 0 (0 pending in tls object).
[debug] conn_write_callback(): socket 14 wants to write.
[info] connection_handle_write_impl(): in-progress connect failed. Removing. (Connection refused)
[debug] connection_edge_end(): Sending end on conn (fd 14).
[debug] relay_send_command_from_edge_(): delivering 3 cell forward.
[debug] relay_send_command_from_edge_(): Sending a RELAY_EARLY cell; 2 remaining.
[debug] relay_encrypt_cell_outbound(): encrypting a layer of the relay cell.
[debug] relay_encrypt_cell_outbound(): encrypting a layer of the relay cell.
[debug] relay_encrypt_cell_outbound(): encrypting a layer of the relay cell.
[debug] relay_encrypt_cell_outbound(): encrypting a layer of the relay cell.
[debug] relay_encrypt_cell_outbound(): encrypting a layer of the relay cell.
[debug] append_cell_to_circuit_queue(): Made a circuit active.
[debug] scheduler_set_channel_state(): chan 1 changed from scheduler state WAITING_FOR_CELLS to PENDING
[debug] conn_close_if_marked(): Cleaning up connection (fd -1).

My guess would be that Tor is unable to connect to LND. Does Tor expect to have LND running on port 9735 in the same network? If that's the case, how could I point it to e.g. lnd:9735 (following Docker-specific network configuration)?

My question now is - can I use the same private key in LND config for tor.privatekeypath that is used by Tor hidden service? 🤔 Both are ED25519...

If you place a private key here with the expected encoding, then you're able to re-use an existing one.
I think everything has been resolved here? An issue in a config env rather than lnd's implementation AFAICT.

If you place a private key here with the expected encoding, then you're able to re-use an existing one.

That does not work unfortunately. Both Tor and lnd fail to start up with errors pointing towards conflicting private keys.
Tor's error log:
[notice] New control connection opened from <IP_ADDRESS>.
[warn] tor_bug_occurred_(): Bug: src/feature/hs/hs_service.c:3817: hs_service_add_ephemeral: Non-fatal assertion !(register_service(hs_service_map, service) < 0) failed. (on Tor <IP_ADDRESS> )
[warn] Bug: Tor <IP_ADDRESS>: Non-fatal assertion !(register_service(hs_service_map, service) < 0) failed in hs_service_add_ephemeral at src/feature/hs/hs_service.c:3817. (Stack trace not available) (on Tor <IP_ADDRESS> )
[warn] Onion Service private key collides with an existing v3 service.

I've followed the steps explained by @lnd-routing at https://github.com/lightningnetwork/lnd/issues/5750#issuecomment-922240346, but the problem is that I need to expose the node on public IP and on the .onion. For the externalip, I don't think I'm able to set both IPs?

If you want to re-use that same key across two distinct services, you'll need to do some manual work to insert a reverse proxy.
Closing as there's no issue with lnd and this is a matter of a user trouble shooting their advanced set up.
Feel free to pick this up in the Discussions section here to see if others are running a similar set up.

Does Tor expect to have LND running on port 9735 in the same "localhost" network? If that's the case, how could I point it to e.g. lnd:9735 (following Docker-specific network configuration)?

You need to make that port of the docker container reachable on the host machine, so the tor daemon can forward the requests over to that port.


Make sure PLAYER_READY only fired once, and events reregistered on container change

I think previously if the container changed the player ready event would be fired again, and I presume the intention is only for this to fire once then the player has loaded, not when new containers are ready?

The build is failing because of #737


Add support for GraphQL

As suggested in https://github.com/sindresorhus/refined-github/pull/1399 and https://github.com/sindresorhus/refined-github/pull/1495
Can be merged after https://github.com/sindresorhus/refined-github/pull/1449

Can you fix the merge conflict?


Remove legacy vendoring

It's complex and unusably slow.
Vendoring is still marked experimental, so this shouldn't require bumping major version. Still, to provide a grace period, this shouldn't be merged before 1.2.0.

1.2.0 failed to build and release because of a race condition in legacy vendoring... clean break it is then.


Is this issue being tracked?

Can you post a link to where is issue is being tracked or if it has already been fixed?

A fix has actually just been merged yesterday https://github.com/cloudflare/wrangler2/pull/2404. I haven't gotten around to testing if it fixes the issue yet.


basic operations like getPosition(), setPosition() etc.

I was wondering if there is a simple way to directly control the hardware without going through the multidimensional acquisition functions.  Basically I just want to do things like getPosition, setPosition, setProperty('Turret', 'State', value).  Do you have any quick an easy examples that I can follow?

https://pycro-manager.readthedocs.io/en/latest/core.html

Thanks, that's a nice resource on how to use the package.


[DNM] Automate selinux setup for assisted ABI

Test-Hints: assisted-abi

cc: @ramperher

The idea is to get help of @nsilla and @pierreblanc to automate the selinux config for the assisted setup.

from change https://github.com/redhatci/ansible-collection-redhatci-ocp/pull/137:

SUCCESS https://www.distributed-ci.io/jobs/cbeb1b6c-8b61-4c14-bfa8-33d020672f45/jobStates

ABI has passed with permissive selinux. We'll probably stop selinux setup at this point, and move towards upgrade etc.


App orientation is locked but the LNNotification rotates

Hello LeoNatan,
I have used this in my Live app and currently facing some issues.
Our entire app is locked to Portrait orientation but the LNNotification gets rotated.
Ive used the pods and hence if I update he Pods then the code will be overwritten by the latest for the changes I make.
Can you provide a function to pass the orientation locked and Type (Landscape / Portrait) while registering this LNNotification View.

I have put this in LNNotificationBannerWindow but i know it will overwrite on the pods update for the fixes you may do to improvise this component.
-(UIInterfaceOrientationMask)supportedInterfaceOrientations
{
return UIInterfaceOrientationMaskPortrait;
}

(UIInterfaceOrientation)preferredInterfaceOrientationForPresentation
{
return UIInterfaceOrientationPortrait;
}

Can we have a handle outside to lock or access this.

Another option is to implement - (UIInterfaceOrientationMask)application:(UIApplication *)application   supportedInterfaceOrientationsForWindow:(UIWindow *)window in your app delegate, and provide the portrait orientation there.
I am not sure how to solve this. Each window allows its controller stack to determine the allowed orientation. So I could query the main window's allowed orientation, but this is incorrect, as there may be multiple windows alive, each with different supported orientations. Another option is to display notifications only in the orientation the interface was at the time of presentation. I don't like this because the experience suffers for all other applications where rotation is supported.

Hello LeoNatan,
I have implemented the stack in every controller to past the code that will determine what orientation is supported in the view controller.
`
 -(BOOL)shouldAutorotate
 {
   return YES;
 }

- (UIInterfaceOrientationMask)supportedInterfaceOrientations{    //NSLog(@"supported called in red    1");
    return UIInterfaceOrientationMaskPortrait;
}

- (BOOL)shouldAutorotateToInterfaceOrientation:(UIInterfaceOrientation)toInterfaceOrientation
{
    return toInterfaceOrientation == UIInterfaceOrientationPortrait;
}

- (UIInterfaceOrientation)preferredInterfaceOrientationForPresentation
{
    return UIInterfaceOrientationPortrait;
}

Also the customised navigation controller have this code.
 - (BOOL)shouldAutorotate {
    return [[self.viewControllers lastObject] shouldAutorotate];
}

- (UIInterfaceOrientationMask)supportedInterfaceOrientations {
    return  [[self.viewControllers lastObject] supportedInterfaceOrientations];
}

- (BOOL)shouldAutorotateToInterfaceOrientation:(UIInterfaceOrientation)toInterfaceOrientation
{
    return [[self.viewControllers lastObject] shouldAutorotateToInterfaceOrientation:toInterfaceOrientation];
}

- (UIInterfaceOrientation)preferredInterfaceOrientationForPresentation
{
    return [[self.viewControllers lastObject] preferredInterfaceOrientationForPresentation];
}

As i have some view controller that support both orientation so the above APPDelegate fix is not good. Please suggest me some solution over this.

I just tested on my demo project.
If the project is defined correctly to only support portrait, notifications do not rotate.

No my few pic gallery full screen views are supporting both orientation hence I can't use the settings above as u mentioned


allow unstyling del/ins html components

What does your PR address?
Allow unstyling <del>/<ins> with unstyle or prose classes, see #1060

@obayemi seems to be working perfectly. I'll merge this now.
Just note our next release is going to be a little further out than our standard 2 week cycle. We're hoping this will be our v1 , so thank you for your patience in the meantime!
But given this is merged it means it 100% will be part of this next release. Thanks!


Polarization jones

Polarization basics are done and seem to work. Current Jones matrices are: E, P, K

missing just valid baselines


setup

@h1alexbel I couldn't find any assignee for this task. This is either because there are no contributors with role REV available or because the project does not have enough funds.
Please, make sure there is at least one available contributor with the required role and the project can afford to pay them.

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.


Note regarding multiple components in the same BOM

Per conversation with Paul Horton (https://cyclonedx.slack.com/archives/CVA0G10FN/p1660383842828799), I am adding a note to the JSON schema explaining how to handle multiple instances of the same component (so that it is possible to reflect different analyses for each one).

Hello @Walter-Haydock
first of all: please also update the description i the other schema definitions, too. XML, protobuf, ...
the current discretion reads:

An optional identifier which can be used to reference the component elsewhere in the BOM. Every bom-ref MUST be unique within the BOM.

You suggest to addto the description:

If a component appears multiple times in a BOM, each instance of such component MUST have its own unique bom-ref.

Your addition appears to be already covered by the current description."unique"  means "once in a universe". there is no value in your addition, or is there? Maybe i don't get it.
On the other hand, your addition is wrong: The bom-ref is optional - a "MUST have its own unique bom-ref" is wrong - as the bom-ref is still not mandatory.
what do i not see?

Hi @jkowalleck - thanks for the comments. My goal is to answer the same question I had regarding multiple instances of the same component (https://cyclonedx.slack.com/archives/CVA0G10FN/p1660339494343359). The answer wasn't initially obvious to me, so perhaps this is better for an FAQ-type document.
If not, then perhaps the following wording would be more helpful: "If a component appears multiple times in a BOM, each instance of such component with a bom-ref MUST have a separate bom-ref."
I would greatly appreciate your input on this issue, in order to proactively address this type of question in the future.

If a component appears multiple times in a BOM, each instance of such component with a bom-ref MUST have a separate bom-ref.

is this not just another phrasing of

Every bom-ref MUST be unique within the BOM.

Since this misunderstanding might be unique to me, I'll just close out this PR.


Creating default object from empty value in.. multiple lines.

Hey, thanks for the great software. Sadly I encountered a problem.
I used the advanced installation and the demo you have on the <>code page.
I filled in the blind-text as my real mailserver (mail.domain.tld), used my outlook/domain login in the code-snippet and executed the code.
This is the error:
➜  Exchange-Web-Services-for-PHP git:(master) ✗ php outlooktest.php
PHP Warning:  Creating default object from empty value in /var/www/html/Exchange-Web-Services-for-PHP/lib/ExchangeClient.php on line 349
PHP Warning:  Creating default object from empty value in /var/www/html/Exchange-Web-Services-for-PHP/lib/ExchangeClient.php on line 355
PHP Warning:  Creating default object from empty value in /var/www/html/Exchange-Web-Services-for-PHP/lib/ExchangeClient.php on line 357
PHP Warning:  Creating default object from empty value in /var/www/html/Exchange-Web-Services-for-PHP/lib/ExchangeClient.php on line 370

All the files are there and are modified as the advanced installation requires.
➜  lib git:(master) ✗ ls
ExchangeClient.php  ExchangeNTLMStream.php  messages.xsd  NTLMSoapClient.php  NTLMStream.php  Services.wsdl  types.xsd

Maybe you can help me with that! Thanks a lot!

Did you manage to fix that error @perskes ?

Looking through past commits, it seems the issues causing these warnings has been resolved:
https://github.com/rileydutton/Exchange-Web-Services-for-PHP/commit/95d941af42261cba7962a9df87a407a840b0cc52


Revert "add new region support for Rekognition"

Reverts awslabs/aws-media-insights-engine#163

Nevermind this PR


Should we check if the pcap file exists in the file index?

Moloch: 1.5.2
Elasticsearch: 6.3.0
I found a problem. When a new pcap file is generated by moloch-capture, the file name should be indexed to es,but sometimes it won't be indexed successfully. Therefore,when the free space is less than 10%, the delete task will be triggered,but this will only delete the file whose file name existed in es, and other files won't be deleted.so there will be more and more unindexed pcap files, and then they will cause a proplem:"No space left on device".
So should we add a task to deal with this kind of problem?
a crontab reindex task? or a delete task?

This should rarely, if ever happen.  When it does usually it means that the ES server is overloaded and you are dropping ES requests, is that the case?
./db.pl sync-files can repair the problem

I can add a crontab task  to resolve the problem.Thanks.


Break down KafkaAsyncExecutor into multiples Single Responsibility elements

https://github.com/michelin/ns4kafka/blob/master/src/main/java/com/michelin/ns4kafka/services/KafkaAsyncExecutor.java
This class is currently responsible of the following (one instance is generated per cluster):

Synchronize Topics

List ns4kafka Topics (from TopicRepository)
List Kafka Topics (with AdminClient)
Convert org.apache.kafka.Topic to ns4kafka.Topic for easier comparison
Compute change lists (to_create, to_update, ...)
Execute changes with AdminClient

Synchronize ACLs

List ns4kafka AccessControlEntry (from TopicRepository)
List Kafka ACLBinding (with AdminClient)
Convert ns4kafka.AccessControlEntry to org.apache.kafka.AclBinding for easier comparison (note : inverse of Topic)
Compute change lists (to_create, to_update, ...)
Execute changes with AdminClient

Synchronize Users (not implmented)

This doesn't respect SingleResponsibilityPrinciple.
Discussion is required in order to find the best split.

Implemented with #51


MLT-0043 Update Order (PUT) endpoint

Adds an API endpoint for updating existing orders

Marking this as ready for now. We do still need Controller tests, but to do this we first need to update dummy-synq


Druid 0.15.1-incubating upgrade issue

Affected Version
Druid 0.15.1-incubating
Description
In https://github.com/Homebrew/homebrew-core/pull/42693, I am trying to help upgrading the druid version, but somehow, I could not connect to http://localhost:8083/status when testing locally.
I did not find any documentation about how to test single-server situation. So file this issue for some support.

I see that in your homebrew PR you changed the URL to https://www.apache.org/dyn/closer.cgi?path=/incubator/druid/0.15.1-incubating/apache-druid-0.15.1-incubating-bin.tar.gz
That url does not lead a file, it is just a helper page to find the nearest mirror, does that URL need to link to a specific mirror? Something like https://www-eu.apache.org/dist/incubator/druid/0.15.1-incubating/apache-druid-0.15.1-incubating-bin.tar.gz ?

@vogievetsky  can you help with the brew upgrade?


How delete folder in one command ?

How can we delete a folder in a single execution?
I tried the following but it didn't work
        $storage = Yii::$app->get('storage');
        $result = $storage->commands()->delete($folder_path)->execute();

Please advice

There's no such functionality at the moment. So the only way is to iterate over required objects and delete them one by one.

Thanks for your reply.


reduce bloat from assert code

By switching from a dynamic array to a static array, this reduces bloat generated for assert() functions.

Why is win64 different?

Win64 has a wacky calling convention that only allows 64 bit parameters. Applying the same fix to Win64 involves creating stack temporaries and other stuff, which might be worthwhile doing later.

noice


http: support for adding tokenized HTTP headers to local reply mappers

Commit Message: this PR introduces support for adding tokenized HTTP headers to local reply, which was mentioned as part of https://github.com/envoyproxy/envoy/issues/11648.
Additional Description:
Risk Level: low
Testing: new unit and integration tests
Docs Changes: n/a
Release Notes: updated version history

@mattklein123 sorry, it took me a while to circle back to this. I have changed the API so that the configuration of a formatter for a header value is supported. Not sure if that's closer to what you had in mind: could you please take a look when you get a chance and lmk what you think? Thanks!

Sorry, stepping back, can you describe at a high level what problem we are trying to solve? And then we can figure out the right solution? I'm a little confused what we are trying to achieve (generic formatting, substitution, etc.). Thank you.
/wait-any

Yep, good idea to take a step back.
The original issue reported here https://github.com/envoyproxy/envoy/issues/11648 was that custom headers were not being added to local replies; that was taken care of by this code change https://github.com/envoyproxy/envoy/pull/12093.
However there was a larger discussion around the original issue, and a point was made about possibly introducing support for a tokenised header (where each token is a header name/value pair) that could be useful in a scenario where you want to send hop by hop debug info.
I thought that introducing the idea of a tokenised formatter for a header’s value would be one way to achieve this, but I might have misunderstood something or made the wrong assumptions. I hope that clarifies what I am trying to achieve?

I thought that introducing the idea of a tokenised formatter for a header’s value would be one way to achieve this, but I might have misunderstood something or made the wrong assumptions. I hope that clarifies what I am trying to achieve?

I think my question is if we support the full substitution formatter (which I think you are saying we do) can't the user just do whatever concatenation they want manually?
/wait-any

Right, what the heck, the current API and formatters already support all this. Sorry for the confusion, I wasn't thinking straight: closing the PR.


Add support for v2 endpoint

Add EventBuilderV2
Add serialization logic to create POST requests for new endpoint using 4 supported JSON libraries

@aliabbasrizvi @delikat @haleybash-optimizely @wangjoshuah @jophde @alda-optimizely @mikeng13

Higher level question, are we getting rid of the V1 event builder?

Synced offline with @vraja2 about changes to be made.

Going to split this PR up


podenv doesn't work with rbenv-gemset?

I've installed podenv and rbenv-gemset both with homebrew
I tried to install a version of cocoapods
Then cocoapods is installed in /usr/local/var/rbenv/versions/2.3.1/gemsets/global/gems
It should be in ~/.podenv/versions I guess.
What can I do to make them work together?

I uninstalled rbenv-gemset, then podenv install 1.5.0. then things go well.
I've found the directory in versions is very similar with the one in /usr/local/var/rbenv/versions/2.3.1/gemsets/global/gems.
It seems the directory in versions is a gemset.

@aelam How to config podenv to works along with rbenv?
I install rbenv first to manage ruby version then install podenv but when i which pod
it's in  /Users/myId/.rbenv/shims/pod

I am using
rbenv and bundle right now. Its better
Please check

I don't use podenv right now
rbenv + bundle can handle different versions
It's a better solution


On fail-safe navigational collections and adding new elements

On fail-safe navigational collections and adding new elements
Context
In section 6.1.5. you show an interesting bug where a Book instance is fetched from the database without including its collection of Review instances and where that collection is initialised outside of EF Core's control, causing a merge conflict when saving the changes.
Your proposed solution is to make the setter private and to keep the collection uninitialised everywhere, so that the code will throw an exception when the property is not included with EF. This will catch any unintentional merges.
Caveat when adding new elements
But with this design in mind, how would you handle a business model that has a method to specifically populate its collection? For example, if I have the following ShoppingCart class which exposes an AddToCart(GroceryItem item) method...
public class ShoppingCart
{
  private List<GroceryItem> _items = null!;

  public Guid Id { get; private set; }
  public IEnumerable<GroceryItem> Items
  {
    get => _items;
    private set => _items = value.ToList();
  }

  public void AddToCart(GroceryItem item)
    => _items.Add(item);
}

Adding items to a fetched ShoppingCart
If I query the database and fetch an existing ShoppingCart, including its Items, then EF Core will initialise and populate the _items backing field and ensure that Items is not null. This means that any grocery items associated with that shopping cart will be loaded and that adding new grocery items before saving will work as intended.
If I query the database without including the Items property, then the AddToCart method will throw an exception, which is also acceptable. However...
Adding items to a newly created ShoppingCart
If I at some point create a new ShoppingCart and try to add items to it using the AddToCart method, then it will also throw an exception, since the _items backing field was never populated. I could change the AddToCart method in two ways; either I change the addition line to _items?.Add(item) and have it fail quietly, or I can initialise the _items backing field manually to make sure that the user can add items to a newly created cart, which seems more desirable. However...
Adding items to a fetched ShoppingCart (reprise)
If I now query the database and fetch a ShoppingCart without including the Items property, then the AddToCart method will still initialise the collection if I try to add an item to it, effectively enabling the bug you mentioned in the book.
Final thoughts
As long as a newly created ShoppingCart is saved to the database upon construction and loaded with its (empty but not null) items collection before manipulating it, then none of this would matter. But if that cart needs to be emptied or discarded, I would have to keep track of it and remove it using EF Core. This seems rather unwieldy.
Can these requirements coexist? Is there a better approach to accomplish this interaction?

Thank you for your reply! Yes, this did clear things up. I did not consider the fact that the constructor with parameters would only be called if a new instance was created manually rather than through an EF Core query, in which case there would be no side-effects to initialising the collections.


Fix off by one error in annotator JSON output

This patch fixes an off-by-one error in the annotator JSON output. Essentially, the very first block would automatically trigger a write to the file since the file count was zero, and zero modulo anything is still zero, which was the condition for writing to a file. This becomes a problem if there are fewer blocks than blocks_per_json_file as after processing all the blocks, the final chunk will be written, but it will overwrite the first chunk in this case, leaving blocks out. This patch fixes that behavior by simpling computing the module with file_counter +1, which has the same effect but avoids this behavior.

This (and other issues) I think definitely highlight the need for lit tests. I'd really like to get the infrastructure for that up and running, but having to get it to work with Bazel doesn't seem particularly fun.


forge clone: Clone verified contracts as foundry project

Component
Forge
Describe the feature you would like
Problem
Currently, foundry provides a feature that downloads the source code of contracts from Etherscan: cast etherscan-source. However, cast etherscan-source only dumps the sources of contract in the filesystem simply, without being able to compile.
This creates an obstacle on blockchain developers, who may want to re-compile the contracts of popular DApps, customize it, deploy in a local chain, write foundry tests/scripts with the contract, etc.
Proposal
We propose to add a new subcommand for forge: forge clone, which clones source code of a verified contract on Etherscan and creates a foundry project on local file system. The usage of the command is forge clone <address> <path/to/cloned/project>.
Our fork of foundry, EtherDebug/foundry, has already implement this feature. We encourage developers to try out this subcommand on our fork of foundry.
We welcome any comments and suggestions helping us improve this feature and contribute to a better smart contract development and debugging experience.
Downstream Application
Cloning the source code of contracts from Etherscan also enables multiple downstream usage, one of which is on-chain contract tweak feature that we introduce in our fork EtherDebug/foundry.
The on-chain contract tweak allows users to alter the code of an on-chain contract with its on-chain state preserved. This feature enables a very handy feature that developers can insert "printf" into on-chain contracts and replay transactions.
The first step of tweaking an on-chain contract is to clone the source code of an on-chain contract. So we presume introducing forge clone to foundry is a significant step forward.
This tweak feature has recently attracted much attention on Twitter. We would like to bring the discussion to a broader audience regarding upstreaming the forge clone and tweak features to the main foundry project.
Disclosure
@ZhangZhuoSJTU and me (@Troublor) are the authors of EtherDebug/foundry, which introduces the On-chain Contract Tweak features in foundry. Please take a look at our demo on Twitter.
Additional context
A demo of forge clone and on-chain contract tweak feature:

that's awesome, very supportive of this feature!
happy to start the integration of this!!
best way would probably a big PR for forge clone, then we can extract the required tweaks and apply them separately

The PR of forge clone is already on the way!

Hi @mattsse, I am wondering that, considering the merge of forge clone, could we discuss potential next steps for integrating the tweak feature?

If the current working directory is a foundry project created by forge clone, then the command forge replay is available to replay a historical transaction with the on-chain contract's code tweaked by the current project. Note that the cloned project "knows" which contract address it should tweak.

I believe this is very similar to vm.transact cheatcode?
what if generate a test that

deploys the cloned contract to the onchain addres

@mattsse, yes, it is a very good point. However, there are a few subtle nuances to consider (especially when we tweak the contracts and hence change the data in the creation Tx).
The most challenging issue concerns create2. Due to potential tweaks and modifications to the original code, the creation code might change, resulting in a target address that differs from the original one. In this context, a practical workaround would be to first execute a transaction to obtain the deployed code, and then forcibly assign this code to the original address. It's important to note that when replaying using tweaked contracts, we hope that these contracts occupy the same addresses (so that we do not need to change other contracts involved in the replayed Tx).
Moreover, this solution might not be sufficient. Some contracts include expressions like immutable X = address(this), meaning that if the target address (address(this)) changes (due to tweaks), the deployed code will not match the expected output. To address this, we may need to introduce an inspector to hook the behavior of the ADDRESS opcode during creation.
Additionally, there are several peripheral tasks, such as identifying the creation transaction and its corresponding block, and forking & adjusting the Tx position, which users might find cumbersome to handle themselves.
That is basically the main motivation of use to introduce an additional code module (but the current code organization may not be optimal and needs your advise).

Another challenge here is that, not all contracts are deployed by EoA, but rather by other (factory) contracts, e.g., Uniswap. In our implementation, we hook the actual creation call and do the aforementioned replacement.
By writing a test, I somewhat do not figure out an elegant approach to do this. Lol

Hi @mattsse,
I am wondering whether there is any update on the status of this issue? Any insights would be greatly appreciated.
Thanks!

Marking as resolved by https://github.com/foundry-rs/foundry/pull/7576 which adds forge clone


Add a Wave Animation using CSS

Describe the project you want to add with tech stack
I would like to add a Wave Animation using HTML & CSS that would show a soothing wave going up and down through the screen endlessly.
Expected behavior

Screenshots (optional)

Additional context (optional )

@MohitGupta121  sir kindly assign me this issue 🙏


DevServer  missing  'server' option

Version
5.0.0-rc.1
Reproduction link
[]( ValidationError: webpack Dev Server Invalid Options  options should NOT have additional properties)
Environment info
nodejs 12.*

Steps to reproduce
please:
devServer: {
server: 'https'  // set this option
}
What is expected?
please support this option
What is actually happening?
1

Actual version is 5.0.1 but still have no support for server option :(


Feature Request: Add posibillity to disable notifications about translations

It can be possible as something like "if on end of url is /, then do not post notification" - is this possible?

Could you try $wgDiscordExcludeNotificationsFrom = [ 'Translations:' ]; or $wgDiscordExcludeNotificationsFrom = [ '/en' ];? I don't know it is a spec 😃


Testing every AM-Reflect interaction

Before we roll out, realy rest every possible interactions!

Heroes tested:

Abaddon (IMBA)
Alchemist (IMBA)
Ancient Apparition
Anti Mage (IMBA)
Arc Warden
Axe (IMBA)
Bane (IMBA)
Batrider
Beastmaster
Bloodseeker (IMBA)
Bounty Hunter (IMBA)
BristleBack
BroodMother
Centaur (IMBA)
Chaos Knight
Chen
Clinkz (IMBA)
Clockwerk
Crystal Maiden (IMBA)
Dark Seer
Dazzle (IMBA)
Death Prophet
Disruptor (IMBA)
Doom and neutrals he eat
Dragon Knight
Drow (IMBA)
Earth Shaker
Earth Spirit
Elder Titan
Ember Spirit
Faceless Void (IMBA)
Pugna (IMBA)
Tide Hunter

(Note to self: last stopped at Enchantress)
Items tested:
TODO
Errors Found

[ ] Alchemist Greevil error

[ ] Alchemist Unstable Concoction will cause AM to use the ability but has no way to throw the concoction, hence a certain self stun
[ ] Bane Fiend's Grip error

[ ] Bat Rider reflected lasso will still disarm anti mage

[ ] Reflected Clinkz's Searing arrow (manual cast) causes infinite loop but does not crash server (not suppose to be reflected I think)

[ ] After reflecting Death Prophet's Spirit Siphon, Anti mage will retain the charges

[ ] Reflected Earth Spirit Boulder Smash does nothing

Unsure Interactions  (might be intended)

[ ] If AM has aghanim, reflected spells are aghanim versions
[ ] Chen's Test of Faith is not reflected
[ ] Dark Seer's Ion Shell not reflected
[ ] Disruptor's Glimpse is not reflected
[ ] Doom's Infernal Blade is not reflected

Very nice work! Which portion of Test of Faith is not reflected? I'm assuming the "go home bitch" portion which we made available for both teams but has no linken check since it's ally only ability in normal dota.

Alchemist Greevil error
Alchemist Unstable Concoction will cause AM to use the ability but has no way to throw the concoction, hence a certain self stun

Made Spell Reflect ignore those for now.

Bane Fiend's Grip error

fixed.

Bat Rider reflected lasso will still disarm anti mage

Intended, the caster of lasso disarms itself.

After reflecting Death Prophet's Spirit Siphon, Anti mage will retain the charges

I don't know how to solve it. Hmm.

Reflected Earth Spirit Boulder Smash does nothing

Not sure why. It just.. doesn't.

If AM has aghanim, reflected spells are aghanim versions

Intended.

Chen's Test of Faith is not reflected
Dark Seer's Ion Shell not reflected

Probably because it has no Linken's check.

Disruptor's Glimpse is not reflected

Has no position to revert to. Disabled on Anti Mage.

Doom's Infernal Blade is not reflected
It doesn't proc Linken's.


Add session service

This should be able to store multiple things (backups of transactions, other private keys, the whole state for the provider and consumer


config.lua unexpected event

I updated today the packages from packer.
It updated your plugin.
After i tried to enter neovim, it started acting weird, stoped working and gave me this error(scrrenshot)
I checked your commits, 12 hours ago you commited some changes, and there are keywords related to my error in the scrrenshot.

Same with Lazy.nvim. No error if using commit f7c845749aba6096f041a73a26ba64f3817bab99

Same here. It's introduced by the new commit 5a48c7e22f2c56aa7d8412e1b327d054c917286d.

Whooops, sorry about that. I failed to consider that spaces are in fact allowed in strings xD
Should work again in a bit.

Fixed with 14cb88c825f93604acd846411964938387bc7a87


checkWith option is only working with checkOnSave.

Version: 0.1.3.
I'm trying to set up code checking with Clippy.

I use settings:

"rust.checkWith": "clippy",
"rust.checkOnSave": false

With Rust file opened, I invoke "Cargo: Check Library" command.

I expect cargo clippy command to be invoked, but instead I see output:
Started cargo check --lib
...

When I change rust.checkOnSave to true, "Cargo: Check Library" command still works the same, but checking file on saving is done with Clippy.

It appears, this is the only place in the extension's code, where checkWith setting is used:
https://github.com/KalitaAlexey/vscode-rust/blob/ddec37cdf534073b5a38d1c2b5b6a17e2a752d9d/src/extension.ts#L97
Shouldn't this setting be used for the Cargo Check command too?

Hi @mitskevich,
Yes, it should. I know about it. I will fix it now.

Hi @mitskevich,
Please look at #7
Write your opinion about it.

@mitskevich,
Could you close it in favor of #7?


Cookbook: add more axis examples

Review the ScottPlot 4.1 cookbook and add more ScottPlot 5.0 recipes showing things like how to have "right axis only" ticks

I'll track this in #4380


Fill 0 returns type instead of value

Type of issue: bug report | feature request

Impact: no functional change (code could technically rely on this behavior but it would be super weird)

Development Phase: request
Other information

If the current behavior is a bug, please provide the steps to reproduce the problem:
What is the current behavior?
chisel3.util.Fill when given n = 0 returns UInt(0.W) which is a type rather than a value which it returns for n >= 1: https://github.com/freechipsproject/chisel3/blob/387274784115bee2bf7167547a7ee459219e1413/src/main/scala/chisel3/util/Bitwise.scala#L68
What is the expected behavior?
Ideally this would return a zero-width-wire which would then go away, but since support for that is lacking, it should probably just error in the meantime.
What is the use case for changing the behavior?
Better error messages and with zero-width wire support, cleaner generators that don't have to special case zero.

I have been bitten by this.  Also, please fix it in such a way that Cat(x, Fill(0, y), z) is exactly equivalent to Cat(x, z).  The broken status quo is actually better than it "working" but producing Cat(x, 0.U, z).

Yeah, Fill(0, y) producing 0.U is a big no, if it does not error, it must return 0.U(0.W) which currently doesn't work but is the ideal result.


[DDW-911]: Fix warning sign displayed when recommend decimals is zero

This PR intends to fix the bug where warning icons are displayed next to assets when the recommended decimal places is zero.
Screenshots

Testing Checklist
Test Scenarios
Scenario 1: Tokens with 0 recommended decimal places
Given I have tokens with 0 recommended decimal places
And I haven't altered any settings
When I navigate to Summary -> Tokens
Then there is no warning icon shown next to the token

Scenario 2: Tokens with 0 recommended decimal places with altered settings
Given I have tokens with 0 recommended decimal places
And in Settings, I have saved the number of decimal places to  > 0
When I navigate to Summary -> Tokens
Then there is a warning icon shown next to the token
And upon hovering the tooltip displays
"You are not using recommended decimal place configuration for this native token"

Scenario 3: Tokens with non zero ( > 0) recommended decimal places
Given I have tokens with non zero ( > 0) recommended decimal places
And I haven't altered any settings
When I navigate to Summary -> Tokens
Then there is a warning icon shown next to the token
And upon hovering the tooltip displays
"The recommended value for decimal place configuration for this native token is X decimal places"

Scenario 4: Tokens with non zero ( > 0) recommended decimal places with altered settings to recommended
Given I have tokens with non zero ( > 0) recommended decimal places
And in Settings, I have saved the number of decimal places to the recommended
When I navigate to Summary -> Tokens
Then there is no warning icon shown next to the token

Slack QA thread

Prerequisite: You must have a token with 0 recommended decimal places.

[ ] Go to Summary -> Tokens. The token with 0 recommended decimal places must not have a warning icon showing.
[ ] Regression: Tokens with > 0 recommended decimal places AND an unmatching saved decimal places must show the icon.

Review Checklist
Basics

[ ] PR assigned to the PR author(s)
[ ] input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
[ ] If there are UI changes, Alexander Rukin assigned as an additional reviewer
[ ] All visual regression testing has been reviewed (assign run Chromatic label to PR to trigger the run)
[ ] PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
[ ] PR link is added to a Jira ticket, ticket moved to In Review
[ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
[ ] PR has a good description that summarizes all changes
[ ] PR contains screenshots (in case of UI changes)
[ ] CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
[ ] There are no missing translations (running yarn manage:translations produces no changes)
[ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
[ ] Japanese text changes are proofread and approved (Junko Oda)
[ ] Storybook works and no stories are broken (yarn storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly commented and documented
[ ] Code is properly typed with typescript types
[ ] React components are split-up enough to avoid unnecessary re-renderings
[ ] Any code that only works in main process is neatly separated from components

Testing

[ ] New feature/change is covered by acceptance tests
[ ] New feature/change is manually tested and approved by QA team
[ ] All existing acceptance tests are still up-to-date
[ ] New feature/change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review

[ ] Update Slack QA thread by marking it with a green checkmark

Hi @shawnbusuttil ,
This is the report for build 21133,
Overall you did a great job! 👍 . However, I found an issue when executing Scenario 2. Basically, the warning icon wasn't displayed after saving the number of decimal places from 0 to > 0. Please see video.. Thank you.

Hi @shawnbusuttil ,
This is the report for build 21133,
Overall you did a great job! 👍 . However, I found an issue when executing Scenario 2. Basically, the warning icon wasn't displayed after saving the number of decimal places from 0 to > 0. Please see video.. Thank you.

This is something I was mindful of but the requirement says that "if the recommend decimal places is 0, then we do not display the warning". The token you are testing with has 0 recommended decimal places so it will never trigger a warning under the current logic.
@dmitrii-gaico Can you confirm this?

Hi @shawnbusuttil ,
This is the report for build 21133,
Overall you did a great job! 👍 . However, I found an issue when executing Scenario 2. Basically, the warning icon wasn't displayed after saving the number of decimal places from 0 to > 0. Please see video.. Thank you.

This is something I was mindful of but the requirement says that "if the recommend decimal places is 0, then we do not display the warning". The token you are testing with has 0 recommended decimal places so it will never trigger a warning under the current logic.
@dmitrii-gaico Can you confirm this?

Let me explain the Logic :
Token with "Recommended 0 decimal place" - Do not show a triangle as zero place is already applied by default. So Recommended 0 = default 0
If you change the Decimal Place for such token f.e. from 0 to 5 that means you are using "5" and this is not recommended decimal place. In this case "warning triangle" should be displayed.


How Format my json from af.database.list

Hi,
This my data firebase structure:
sections:
 - section1: {name: News}
 - section2: {name: Tech, parent: section 1}
 - section3: {name: Other, parent: section1}

Get Section list: var sections =  this.af.database.object('/sections'); => working fine
Now how do loop 'sections' and return a new json by my structure:
Ex: [
{
      name: News,
      nodes: [
          name: Tech, nodes: []
     ]
]

Because i can't using foreach(var s in sections) :(
thank you so much,

I would use:
this.af.database.list('/sections')
.map(sections => sections.map(section => {
  // Do something with each section here
  return section;
}))
.do(formattedSections => console.log(formattedSections));


AlmaLinux 9

Additional fixes for AlmaLinux 9
Create packages recipe for installing rsync and vim by default

!bump minor

Jenkins has merged this PR into main and has automatically performed a minor-level version bump to v2.5.0.  Have a nice day!


Bad Flicking on Linux Gnome

Looks like the overlays flicker on and off really bad when dragging a window in Gnome on Arch.

Played around with this for a while and reducing the number of repaint helps. I'm wondering if it's because I'm on an old laptop with integrated graphics. I'm sure that doesn't help.

This will be fixed with the overlay refactor and was finally achieved by using a BufferStrategy instead of manually repainting the JFrame.

Same issue on Linux Mint 21.1. The flicking causes a huge lag.
https://github.com/user-attachments/assets/f31c18aa-59b9-464b-9644-c7601354e2a8

Interesting. That is the exact behavior I've seen on Arch. Maybe integrated graphics is the common issue. I had found a fix for it, but it broke the windows side of Modern Docking. I'll look into some way that I can do Linux specific code.

Maybe integrated graphics is the common issue.

Maybe it's an issue with Gnome rather than integrated graphics? The person in the SO question mentions having "nvidia drivers", so   he most likely has dedicated graphics.
Did you confirm it works in a linux computer with dedicated graphics ?

I had found a fix for it, but it broke the windows side of Modern Docking

Why don't you put a check on the OS type and operate accordingly ?

There is something else to point out, the overlay thinks the window size is bigger than it originally is, so the right and bottom handles overflow the screen (see video again). Did you also find a fix for this ?

Maybe it's an issue with Gnome rather than integrated graphics? The person in the SO question mentions having "nvidia drivers", so   he most likely has dedicated graphics.
Did you confirm it works in a linux computer with dedicated graphics ?

Yes. I use this at work on Gnome on CentOS and haven't encountered this issue there.

I had found a fix for it, but it broke the windows side of Modern Docking

Why don't you put a check on the OS type and operate accordingly ?

That's likely what I'll try.

There is something else to point out, the overlay thinks the window size is bigger than it originally is, so the right and bottom handles overflow the screen (see video again). Did you also find a fix for this ?

That is intentional. The overlap frame is larger to account for drawing handles off the edge of the main frame.

Maybe integrated graphics is the common issue.

Good news. I finally had the time and energy to fix this. I believe I have a working solution. The common issue appears to be integrated graphics not supporting multi-buffer. Wrote some code that will work one way for multi-buffer and another when it's not available and have tested that.

There is something else to point out, the overlay thinks the window size is bigger than it originally is, so the right and bottom handles overflow the screen (see video again). Did you also find a fix for this ?

Sorry, I just realized this is actually an issue. Looks to be specific to using the application in full screen mode. Looking into it now.


doc(test-features): improvements in the scorecard

Description of the change:
Some improvements in the scorecard
Motivation for the change:
Try to make easier its understanding.
To Review:
Check its result here: https://github.com/operator-framework/operator-sdk/blob/5ab5232a623a852e4e54ff23832926192553cd94/doc/test-framework/scorecard.md

Hi folks,
A red hatter checked it and give the feedback that it could help understand the content better. Could we move forward with? WDYT?
c/c @joelanford @estroz @hasbro17 @jmrodri @jmccormick2001

Hi @jmccormick2001,
Really thank you for your review 🥇 . All changes requested are done.

/hold
We have a bunch of upcoming changes planned for the scorecard, so I'm not sure it makes sense to spend much time updating and reviewing the documentation for the current implementation unless there's something specifically incorrect or misleading about it.
I'll defer to @jmccormick2001 and @dmesser if they would find it helpful to have these updates made now.

Hi @joelanford,
The few changes performed here are helpful for the users who try to understand this feature currently. I redhater use this PR yesterday and tell me that he could understand much easier how it works with.
Note that we just supplement a few info, and improve the sequence of the info and add the tables which makes easier check the content. It should is not really L in POV. (The L here is just because of putting the same content in tables and change a little the order of the info)
In order to advocate for we merge this PR the scorecard will change but also it will take a while and I think we will be updating this doc incrementally so at the end the changes performed n POV will still helpful.

/test e2e-aws-ansible

/test e2e-aws-ansible

/test e2e-aws-ansible

Hi @dmesser,
@jmccormick2001 already approved before this PR. Have you any objection about these improvements or could we move forward here?
Thank you for your attention and time.

/lgtm

hi @joelanford,
I am removing the "hold" label since @dmesser and @jmccormick2001 are ok with the changes here. Also, after we merge it I will try to help on  https://github.com/operator-framework/operator-sdk/pull/1816. I hope that these changes will help us to organize better the content of this one too.

/lgtm


Fix the SortBuffer's noMoreInput called twice when enable smj

We encountered an exception while executing Q22 on a 1TB TPC-H dataset using sort merge join. The issue arises because the SortBuffer#noMoreInput() method is invoked multiple times. By eliminating this redundant check, Q22 executes successfully.
Caused by: org.apache.gluten.exception.GlutenException: Exception: VeloxRuntimeError
Error Source: RUNTIME
Error Code: INVALID_STATE
Retriable: False
Expression: !noMoreInput_
Context: Operator: OrderBy[1] 1
Function: noMoreInput
File: /mnt/DP_disk3/jk/projects/gluten/ep/build-velox/build/velox_ep/velox/exec/SortBuffer.cpp
Line: 101
Stack trace:
# 0  facebook::velox::VeloxException::VeloxException(char const*, unsigned long, char const*, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >, bool, facebook::velox::VeloxException::Type, std::basic_string_view<char, std::char_traits<char> >)
# 1  void facebook::velox::detail::veloxCheckFail<facebook::velox::VeloxRuntimeError, facebook::velox::detail::CompileTimeEmptyString>(facebook::velox::detail::VeloxCheckFailArgs const&, facebook::velox::detail::CompileTimeEmptyString)
# 2  facebook::velox::exec::SortBuffer::noMoreInput()
# 3  facebook::velox::exec::OrderBy::noMoreInput()
# 4  facebook::velox::exec::Driver::runInternal(std::shared_ptr<facebook::velox::exec::Driver>&, std::shared_ptr<facebook::velox::exec::BlockingState>&, std::shared_ptr<facebook::velox::RowVector>&)
# 5  facebook::velox::exec::Driver::next(std::shared_ptr<facebook::velox::exec::BlockingState>&)
# 6  facebook::velox::exec::Task::next(folly::SemiFuture<folly::Unit>*)

@pedroerp Can you help to review? Thanks for your help.

@JkSelf thanks for looking into this. While this seems like a simple fix, I wonder in this case if the caller is doing something wrong? Did you check which code is actually calling this function twice (which it shouldn't)?

@pedroerp The orderBy#noMoreInput() method appears to be invoked twice at here, with the second invocation resulting in this failure.

I think the check is right, we should not sort the data twice and release the pool twice https://github.com/facebookincubator/velox/pull/10614/files#diff-f80347d211a617e028feceac2e8d028932b9232c73fe841b8c2f4eb3cc61a870L130.
Why is it invoked twice, can we avoid invoking twice?

Thanks for your investigate. Looks good. Can you add a unit test?

@pedroerp @jinchengchenghh
I've debugged the issue and found that it's because the MergeJoin#getOutput() method, after going through a filter, returns nullptr while input_ is not empty. This causes the condition for needsInput() (which is input_ == nullptr) to not be satisfied. The current fix is to set input_ to nullptr when getOutput() returns nullptr. This problem can be reproduced in the gluten benchmark, but not in the velox unit tests. Do you have any input on this?

@pedroerp Can you help to look this PR? Passed in my local test.

Thanks @JkSelf for digging into this! Could you add a unit test that reproduces this error? I'm concerned that if we need to refactor this code in the future we may break this again unless we have a unit test to protect the behavior.

Thanks @JkSelf for digging into this! Could you add a unit test that reproduces this error? I'm concerned that if we need to refactor this code in the future we may break this again unless we have a unit test to protect the behavior.

@pedroerp Yes. Added the failed unit test. Can you help to review again? Thanks.


report on what needs to be improved upon publish

Describe the improvement
Upon clicking publish, errors can be given that metadata is missing. To help the user to identify what is missing and where to add it, create an overview with link to relevant field.
Current summary shows all sections in green, while mandatory metadata is missing and/or an error is reported.
"There are some problems with your input."  what is wrong? message is e.g. given when fake data for ISSN or WoS ID is entered.
Complementary to completeness bars? Or direct completeness bars for this purpose?

What are the business rules applied now for displaying a success in the summary?
If they are not clear yet, I would op to hide the summary page until we have that sorted – as we are creating a false sense of security.

Replaced by validation upon publish


IOTSTOOL-1891 Notification retries for failed requests

Added notification mechanism based on Polly
https://github.com/App-vNext/Polly
Now retries for HTTP Status 500 without stopping the notifications up to ~2 mins

This should be merged into master, not beta.

Ok closing this and will open new one for master


Compatibility with Singularity

Are there any workarounds for Singularity? I'm getting permission issues trying to pull directly from Docker, and haven't been able to build from a tar after a successful docker build locally.
Pull from Docker:
singularity pull docker://bigbio/diann
FATAL:   While making image from oci registry: failed to get checksum for docker://bigbio/diann: Error reading manifest latest in docker.io/bigbio/diann: errors:
denied: requested access to the resource is denied
unauthorized: authentication required

Output for successful docker build from github
docker build -t bigbio/diann .
#[...]
Successfully built 6133e2d962ab
Successfully tagged bigbio/diann:latest

Failed singularity build:
(base) amb@a553-37:~/diann-docker$ docker save bigbio/diann > diann.tar
(base) amb@a553-37:~/diann-docker$ sudo singularity build diann.sif diann.tar
2024/11/25 11:43:43 bufio.Scanner: token too long

Thanks

Nevermind, solved my own question with a fresh apptainer install


Error

Having an issue with building this project.
[ERROR] Failed to execute goal on project Hackweek: Could not resolve dependencies for project com.jagrosh:Hackweek:jar:0.2: Failed to collect dependencies at com.github.DV8FromTheWorld:JDA:jar:experimental~lazy-loading-SNAPSHOT: Failed to read artifact descriptor for com.github.DV8FromTheWorld:JDA:jar:experimental~lazy-loading-SNAPSHOT: Could not transfer artifact com.github.DV8FromTheWorld:JDA:pom:experimental~lazy-loading-SNAPSHOT from/to central (http://jcenter.bintray.com): Authorization failed for http://jcenter.bintray.com/com/github/DV8FromTheWorld/JDA/experimental~lazy-loading-SNAPSHOT/JDA-experimental~lazy-loading-SNAPSHOT.pom 403 Forbidden

Latest commit should fix this, it was an outdated dependency from before some new features were merged into the main jda branch.


Include parameter to change number of sensitive attributes

The code had a hard-coded value for the number of sensitive attributes. CelebA only had one sensitive attribute (based on @vasishtduddu's code). Needed to generalize it to make it work.

merge away


devcontainer build failure

I've tried to build the devcontainer locally and I get the following error
[276489 ms] Start: Run in container: /bin/sh -c .devcontainer/scripts/post-create-command.sh
find: ‘AzureTRE/devops/’: No such file or directory
[277020 ms] postCreateCommand failed with exit code 1. Skipping any further user-provided commands.

Just downloading the AzureTRE release seems to fix it.
Hardware: M1 Pro Mac
OS: MacOS 12.5.1
build_log.txt
Many thanks for your help in advance.

Thanks @t-young31 just to confirm I have just tested and hit the same issue in WSL.
@tamirkamara @LizaShak is this something you have seen?

Thanks for the logs. That's useful.
Can you try pulling the latest code, and re-running this again please? A number of files have changed in the repo since this was opened. This issue was opened 7 days ago, but the release of AzureTRE that you're installing appears to be...
OSS_VERSION=v0.4.3

... and this was only referenced in this deployment repo 3 days ago. So, I'm hoping that pulling the latest code from here and re-running (rebuilding the dev container) will help fix this.
You shouldn't need to download a copy of the AzureTRE yourself. You should find a download in the location pointed to by...
ENV AZURETRE_HOME=/home/$USERNAME/AzureTRE

If this doesn't work, can you tell me what AZURETRE_HOME is set to inside the devcontainer?

I'm on v0.4.3 and get the same issue, it's set to: AZURETRE_HOME=/home/vscode/AzureTRE.
For some reason the download step on line 96 of the dockerfile doesn't seem to be creating the files, but don't get an error.

Just to be sure I'm clear: have you...

pulled the latest version of this repo
performed a "rebuild dev container" in VS Code

If/when you do, can you share the logs for that please?

RUN layers aren't automatically invalidated, and so I was wondering if we're seeing a cache issue

Just to be sure what you're done: have you...

pulled the latest version of this repo
performed a "rebuild dev container" in VS Code
If/when you do, can you share the logs for that please?
Just run exactly that & same issue:
build_log_22092022.txt

I rebuilt without cache and got the same.@martinpeck can you build the dev container from this repo with any success?

So, I see the same error.
The copy isn't failing. The AzureTRE has been downloaded, and unzipped, exactly where we expect it to be.
For example, I have a folder /home/vscode/AzureTRE that contains everything I'd expect, and includes the version.txt file that install-azure-tre-oss.sh creates as its final step.
So, the Docker commands appear to be working as expected. The find is failing in the postCreateCommand step.

I've got a fix. This certainly allows the devcontainer to build/open successfully, and appears to copy the .env files.
However, it results in git seeing changes because these .env files are tracked already.

@t-young31 hopefully this fixes things for you


Fix and enable linux license validation, exclude from guest package integration test pipelines

Licensevalidation is validating the image metadata, not the behavior, so this is completely unaffected by guest packages. Building the guest package derivative images in a way that looks more like how we build them for prod would make this work as well, but doesn't bring any benefit to guest package testing and this is simpler.
/cc @drewhli @dorileo
/hold

/unhold


pod-policy: add automountServiceAccountToken to the pod policy

By default, Kubernetes will mount a service account token into the etcd
pods. This allows users to disable this via the pod-policy.

@etcd-bot ok to test

@etcd-bot retest this please

Sorry, I had violated a minor go-simple rule. This has been fixed. Hopefully CI will agree.

@etcd-bot retest this please

Took 3 tries to get tests to pass.
On the first two runs, e2eslow and unit tests passed, but jenkins-ci failed in a unique way.
Test 1: https://jenkins-etcd-public.prod.coreos.systems/job/etcd-operator/2256/console
19:21:59 --- FAIL: TestPerClusterS3AllDown (70.51s)
19:21:59 	crd_util.go:45: creating etcd cluster: test-etcd-wgb5l
19:21:59 	util.go:82: 2017-09-07 19:17:20.409401557 +0000 UTC waiting size (3), healthy etcd members: names ([])
19:21:59 	util.go:82: 2017-09-07 19:17:30.410119671 +0000 UTC waiting size (3), healthy etcd members: names ([])
19:21:59 	util.go:82: 2017-09-07 19:17:40.409618991 +0000 UTC waiting size (3), healthy etcd members: names ([])
19:21:59 	util.go:82: 2017-09-07 19:17:50.408909517 +0000 UTC waiting size (3), healthy etcd members: names ([test-etcd-wgb5l-0000])
19:21:59 	util.go:82: 2017-09-07 19:18:00.409892369 +0000 UTC waiting size (3), healthy etcd members: names ([test-etcd-wgb5l-0002])
19:21:59 	util.go:82: 2017-09-07 19:18:10.410668413 +0000 UTC waiting size (3), healthy etcd members: names ([test-etcd-wgb5l-0002])
19:21:59 	util.go:82: 2017-09-07 19:18:20.410634434 +0000 UTC waiting size (3), healthy etcd members: names ([test-etcd-wgb5l-0003 test-etcd-wgb5l-0002])

Test 2: https://jenkins-etcd-public.prod.coreos.systems/job/etcd-operator/2257/console
20:04:03 --- FAIL: TestBackupStatus (90.35s)
20:04:03 	crd_util.go:45: creating etcd cluster: test-etcd-z1hj3
20:04:03 	util.go:82: 2017-09-07 20:01:58.30972811 +0000 UTC waiting size (1), healthy etcd members: names ([])
20:04:03 	util.go:82: 2017-09-07 20:02:08.305941564 +0000 UTC waiting size (1), healthy etcd members: names ([])
20:04:03 	util.go:82: 2017-09-07 20:02:18.305902963 +0000 UTC waiting size (1), healthy etcd members: names ([test-etcd-z1hj3-0000])
20:04:03 	cluster_status_test.go:103: failed to create backup pod: still failing after 6 retries

Test 3: https://jenkins-etcd-public.prod.coreos.systems/job/etcd-operator/2258/console
Successful.

🎉

@ultimateboy have you test this code manually?

Yes. I built the image and pushed to docker hub with:
$ IMAGE=ultimateboy/etcd-operator ./hack/build/operator/build

Then I deployed with helm using:
$ helm install stable/etcd-operator --set image.repository="ultimateboy/etcd-operator" --set image.tag=latest --set image.pullPolicy=Always

Then tested with two different cluster definitions:
$ cat mount.cluster.yaml
apiVersion: "etcd.database.coreos.com/v1beta2"
kind: "EtcdCluster"
metadata:
  name: "example-etcd-cluster-mount"
spec:
  size: 1
  version: "3.1.8"

$ cat nomount.cluster.yaml
apiVersion: "etcd.database.coreos.com/v1beta2"
kind: "EtcdCluster"
metadata:
  name: "example-etcd-cluster-nomount"
spec:
  size: 1
  version: "3.1.8"
  pod:
    automountServiceAccountToken: false

After creating the above clusters (using kubectl create -f file.yaml), verified with:
$ kubectl get po example-etcd-cluster-mount-0000 -o yaml | grep automount
$ echo $?
1

$ kubectl get po example-etcd-cluster-nomount-0000 -o yaml | grep automount
  automountServiceAccountToken: false

@ultimateboy What's the output with automountServiceAccountToken: false when running
$ kubectl get po example-etcd-cluster-nomount-0000 -o yaml | grep serviceAccount

@fanminshi
$ kubectl get po example-etcd-cluster-nomount-0000 -o yaml | grep serviceAccount
  serviceAccount: default
  serviceAccountName: default

$ kubectl get po example-etcd-cluster-mount-0000 -o yaml | grep serviceAccount
  serviceAccount: default
  serviceAccountName: default

lgtm

@ultimateboy Can you add a line to CHANGELOG? LGTM after that.

CHANGELOG line added and rebased to fix conflict.

I really appreciate the fast turnaround here. Thanks @hongchaodeng and @fanminshi!!


Item attachments not integrating with Armor

I'm noticing that Armor items are not currently able to receive item attachments.

I'm not seeing a change.

The change has been made in the dev branch.


outbound emails are send as "agents@none"

I'm using Sendgrid and set my mail domain as kamva.ir
Sendgrid shows me the mail is from agents@none even though I set the email to<EMAIL_ADDRESS>update: this happens if you try to open an issue with the same email as one of your agents

Are you on the master branch?  This is actually the notifications feature- it sends to agents@none and bcc's to each agent that has opted in to receive notifications.  Customers should still be receiving from your support address.


Link to Achintya’s phd starter kit

https://raoofphysics.github.io/phd-starter-kit/
(Tagging @raoofphysics so he knows, but not extpecting extra work!)

Let me know how I can help! :)


Updating the Ivy repository to point to real url for Releases

Signed-off-by: Sarat Vemulapalli<EMAIL_ADDRESS>Description
Updating the Ivy repository to point to real URL for Releases.
Snapshot releases are not yet supported by the infrastructure.
For example 1.0.0-alpha1 would be:
https://artifacts.opensearch.org/releases/core/opensearch/1.0.0-alpha1/opensearch-1.0.0-alpha1-linux-x86_64.tar.gz
Issues Resolved
#600
Check List

[ ] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

start gradle check


Speech to Video

Hey LiveKit team!
I'm working on an animated agent that is lipsynced with the TTS-generated audio. So I decided it would be good to contribute back to you guys, because LiveKit is awesome and I'm really grateful you're doing it open source.
Here's a draft that I wrote more like a proposal, happy to get your comments and improve it, I really think speech-to-video and animated avatars is something that could be reused in the community
So 10000ft view of what's going on here:

I'm using 11labs streaming alignment to syncronize video with the TTS: https://elevenlabs.io/docs/api-reference/websockets#streaming-output-audio
now it works only with 11labs streaming API, but can be easily modified to support their chunked stream as well
the rest of the TTS unfortunately doesn't provide char alignment, but we can come up with some hacks similar to what you've done with transcript forwarding. might be enough for simple animated faces
I've added "alignment" capability to the TTS base class (but not really used it yet lol)
Next I've added video_playout_source to AgentPlayout and video buffer to AgentOutput
I syncronize audio and video streams in the AgentPlayout. audio stream is a primary source for sync rn (and I don't quite like it because if someone decides to use a more sophisticated model to generate face from audio+transcript, we'd have a delay between first audio chunk and first video frame and video will have to catch up with audio during agent speech, which might look off)
so the STV (speech-to-video) class has two streams it operates: SpeechStream (for lipsync frames) and IdleStream (for animations in between utterances. I wasn't sure here about the right approach (comments are very welcome), but the SpeechStream generates timestamped rtc.VideoFrameEvent sequences (that base off timestamp offsets from the start of the audio to match alignment timings) while the IdleStream just generates rtc.VideoFrames at it's own pace (since there's no good start \ sync point, but might be the end of the last utterance)
There's a very crude example that blinks random solid squares while idle and spits out syncronized letters on white background one-by-one when agent speaks
Some next steps would be to add or modify your WordStreamer\hyphenator to be able to consume timestamped char alignment streams and convert them to a timestamped stream of phonemes/visemes, making an adapter for other TTS engines that doesn't support timestamps, maybe syncronizing tts_forwarder during the playout time and not generation time as it is now and reusing alignment there also with the help of those timestamped text streaming adapters
it was a little had to wrap my head around your way of passing handlers into handlers to stream streams from streams lol. I've added a bunch of TODOs here and there as hooks for discussion or places to continue, this whole thing needs a thorough review

ok, I hope you could help me out here to pull it up to par with the rest of your codebase if this feels useful.
P.S. I'll need multimodal input to vision transformers, do you have any plans there? do you need help?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Dmitry Matasov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Commenting for support. This will be a very interesting addition to the framework.
My use case is where I am generating video from audio like the one in EchoMimic. So based on the design here, as you pointed out in #6, it would create a lagging effect considering video generation can be much slower than audio generation.


High cardinality counter metric in TSDB with low cardinality labels

What did you do?
I have a counter metric (e.g. events_total) being collected from a custom app. The prometheus config limits the labels collected.
The resulting metric has ~12 labels in prometheus, all of which are extremely low cardinality (normally 1 value) and static, one label (service_id) that is approximately 650 values, and another metric (dataset) that is related to the service_id but will only vary by about 3. So basically there are about 30 possible values for dataset, but for each service_id value, it will only be paired with at most 2-3 dataset values.
So the labels and number of values looks like:

__name__: 1
container: 1
job: 1
service_id: 650
dataset: 30
namespace: 1
prometheus: 1

And this metric is being collected from thousands of pods, but the other high-cardinality labels like pod are dropped because pods are constantly rotating, leaving only approximately 12 labels like the labels above.
Prometheus is extremely slow returning these metrics, and will complain that it cannot load the metrics into memory even for a simple sum() over a small timeframes like 5 minutes.
What did you expect to see?
I expect the total combination of label values to make the cardinality of the events_total metric be approximately 3000.
What did you see instead? Under which circumstances?
Using promtool tsdb analyze, the output shows:
Highest cardinality labels:
31021 id
23975 name
16709 container_id
7544 uid
7402 pod
...
621 service_id

Highest cardinality metric names:
...
534322 events_total

Where events_total is basically the second highest cardinality metric name in the TSDB.
System information
Linux 5.10.90+ x86_64
Prometheus version
prometheus, version 2.39.1 (branch: HEAD, revision: dcd6af9e0d56165c6f5c64ebbc1fae798d24933a)
  build user:       root@273d60c69592
  build date:       20221007-15:57:09
  go version:       go1.19.2
  platform:         linux/amd64

Prometheus configuration file
- job_name: podMonitor/my-namespace/my-app/0
  honor_labels: false
  kubernetes_sd_configs:
  - role: pod
    namespaces:
      names:
      - my-namespace
  scrape_interval: 30s
  metrics_path: /metrics/
  relabel_configs:
  - source_labels:
    - job
    target_label: __tmp_prometheus_job_name
  - action: drop
    source_labels:
    - __meta_kubernetes_pod_phase
    regex: (Failed|Succeeded)
  - action: keep
    source_labels:
    - __meta_kubernetes_pod_label_app_name
    - __meta_kubernetes_pod_labelpresent_app_name
    regex: (my-app);true
  - action: keep
    source_labels:
    - __meta_kubernetes_pod_label_workload
    - __meta_kubernetes_pod_labelpresent_workload
    regex: (my-app);true
  - action: keep
    source_labels:
    - __meta_kubernetes_pod_container_port_name
    regex: user-port
  - source_labels:
    - __meta_kubernetes_namespace
    target_label: namespace
  - source_labels:
    - __meta_kubernetes_pod_container_name
    target_label: container
  - source_labels:
    - __meta_kubernetes_pod_name
    target_label: pod
  - target_label: job
    replacement: my-namespace/my-app
  - target_label: endpoint
    replacement: user-port
  - regex: __name__
    action: labeldrop
  - regex: endpoint
    action: labeldrop
  - regex: pod
    action: labeldrop
  - regex: instance
    action: labeldrop
  - regex: container_id
    action: labeldrop
  - regex: pod_ip
    action: labeldrop
  - regex: interface
    action: labeldrop
  - source_labels:
    - __address__
    target_label: __tmp_hash
    modulus: 1
    action: hashmod
  - source_labels:
    - __tmp_hash
    regex: 0
    action: keep
  metric_relabel_configs: []

Alertmanager version
No response
Alertmanager configuration file
No response
Logs
No response

I expect the total combination of label values to make the cardinality of the events_total metric be approximately 3000.

Where are you getting this 3000 from?
Just look at these number alone:
service_id: 650
dataset: 30

If you have that many combinations per each target then a single target will end up with: 30*650 = 19500
If you then multiply that by thousands of pods then you end up with numbers you see.
It doesn't really matter that you drop pod or other labels, you'll have at least one unique label per target - it has to be unique, otherwise Prometheus won't scrape it because you can't scrape same unique time series from multiple targets, only one will be accepted.

If you look at scrape_samples_post_metric_relabeling you'll see exactly how many time series were scraped from each target

it isn't 65030 - for each of the 650 service_id labels, it is only paired with 2-3 unique dataset label values at most. Worst case its 6503.
However, I didn't realize the instance label is so critical and added for each pod. I'm closing this as this is more of a scaling issue because as scraping targets increase (or just churn in this case), the cardinality increases.


⚠ Site ANTS has degraded performance

In aaf4f83, Site ANTS (https://ants.gouv.fr) experienced degraded performance:

HTTP code: 200
Response time: 3428 ms

Resolved: Site ANTS performance has improved in dee3928.


No support for 20pt @1x @2x & @3x

for iPhone and iPad notification

Thanks @elichamberlin. Added these sizes to v1.1.

How come latest commit removes 20pt icons? As far as I see in Xcode 9.2 we still have notifications icons size at 20pt 1x 2x 3x..

Hey @staticdreams, these sizes have been added back to v1.2.1. You can read the release notes wrt what happened there. Thanks.


Switch to main branch

Belongs to ivx/injixo#26556

@ivx/schedules pls check if these changes are the only ones needed to switch to main. Ping @ivx/platform-engineering before merging so that we can rename master to main. 🙏


How to set up nitro server

Environment
How to set up nitro server from nuxt like express with all packages like: csurf, helmet and cors.
Reproduction

Describe the bug
example of production ready app with all things set up
Additional context
No response
Logs
No response

For anyone who wants to know how to implement cors with nitro:
// middleware/cors.ts
import cors from 'cors';

export default defineEventHandler(({ req, res }) => new Promise((resolve) => cors()(req, res, resolve)));

Or helmet or any express package:
// middleware/helmet.ts
import helmet from 'helmet';

export default defineEventHandler(({ req, res }) => new Promise((resolve) => helmet()(req, res, resolve)));


Remove link preview

Hi everyone :)
Is it possible to remove the link previews?

This can get quite annoying and can make the message much bigger than it has to be.

Hello, @AtomicLemon
You can try to pass disable_web_page_preview: true as a parameter to the send_message or edit_message method.
Official documentation: https://core.telegram.org/bots/api#editmessagetext

This worked perfectly! Thank you so much for your fast reply :blush:
+1


Invalid encoding for the temporary file

[x] The .ml in the temporary output folder has an invalid encoding, should be UTF-8

I will use the original file encoding


Perform update in parallel

The update command implementation runs over files that are independent from each other. As such, the overall update operation can be trivially parallelised to speed things up.
This change introduces  The list of files that need to be compared/updated is collected in a first past. This list is then given to a multiprocessing pool to farm out the actual update of each individual file. The amount of parallelism is controlled through a new "jobs" parameter, command line option and environment variable. If no value is given for this option, all CPUs are used.
I noticed this chance for improvement when doing a test run of the update of .po files for the Spanish translation of the CPython documentation. Local numbers in my 8-core, hyper-threaded AMD Ryzen 7 5825U:
-j 1 (same as old behaviour)

real    12m5.402s
user    12m4.942s
sys     0m0.273s

-j 8

real    2m23.609s
user    17m45.201s
sys     0m0.460s

<no value given>

real    1m57.398s
user    26m22.654s
sys     0m0.989s

Thanks @shimizukawa for reviewing and merging. I wonder whether you'd be inclined to make a release to PyPI with these changes at some point? No rush though, we can always install the package from this git repository in the meanwhile.

I'm going to drop py38 and release as soon as possible.

2.3.0 has been shipped ;)
https://pypi.org/project/sphinx-intl/2.3.0/

@shimizukawa thank you very much, this is very helpful 😄


WIP: do not skip bridge creation if bridge exists

I recommend to review each commit separately.
This PR does a few things:

Removes create_bridge from the weave script. As a consequence, weave attach $CIDR $CONTAINER is no longer possible without running weaver.
Removes unnecessary create_bridge from weave expose and weave hide.
Makes net/bridge.go:EnsureBridge do not skip creation of the bridge if such already exists, and also makes the function idempotent.

Part of the #3133 fix; going to add netlink subscribe for changes to the bridge in a separate PR.

As commented on the other issue, thank you very much for this. The “reboot bug” bit us more than once.

On my phone, so hard to read, but does this also ensure iptables correctness?

On my phone, so hard to read, but does this also ensure iptables correctness?

Yep, it should.
If you want to do an early testing, please let me know - I could build images for you.

I’d be happy to test. We have an infra sandbox where we setup and tear down clusters all the time (automated through terraform) so more than happy to run tests there if you can provide an image.

@deitch Cool, thanks! You can start using the fixed version by replacing weaveworks/weave-{kube,npc}:latest with weaveworks/weave-{kube,npc}:git-a7ea71bd in https://github.com/weaveworks/weave/blob/master/prog/weave-kube/weave-daemonset-k8s-1.7.yaml

PTAL

Will do @brb, thank you.

upgraded weave to the specific image,
First test: manually recreated the problem: weave bridge down and WEAVE rules removed from iptables. Killed pod, let daemonset restore it. Everything came back perfectly.
Second test: Same as first, but reboot. Everything came back perfectly.

Looks good to me! Please do tag version here when it is merged in and released.

@deitch Thanks! I'm waiting for someone to review the PR.

I have read through the code, and that all seems fine.
I would like to know more about what it will do under different failure conditions, e.g. if some of the iptables rules are present and some are absent.


Unpin Discord.py, and return it to pypy

Travis tests have failed
Hey @silasary,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
1st Build
View build log

     echo $CMD

python dev.py mypy

     $CMD

$ $CMD
CONFIG: production=False
/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/aiohttp/web_urldispatcher.py:263: error: Cannot determine consistent method resolution order (MRO) for "MatchInfoError"

Exit status: 2 (Failure)
1 issues

TravisBuddy Request Identifier: 8af64f90-c3d1-11e9-a73e-8f33893bc238


Updated React Grid Layout placeholder to use the theme color and fixed no kebab case error

Bug
'-webkit-user-select': 'none',
Using kebab-case for css properties in objects is not supported.
Enhancement
before the placeholder color used to be red, now it'll use the theme primary color.

Side note: using the theme color was a nice touch. Looks great.


trankplots() and precis() function

Discussed in https://github.com/orgs/StatisticalRethinkingJulia/discussions/156

Originally posted by Zhe-Jessica March  2, 2023
Hi, I notice that trankplots() and precis() function has been added to StatisticalRethinking.jl during the previous update. This documentation (see below) also mentioned this two function.
https://stanjulia.github.io/Stan.jl/stable/WALKTHROUGH2/
I tested them in the 09-Chapter 9. Markov Chain Monte Carlo.ipynb, but these functions don't work. The error shows 'trankplots not defined' and 'no method matching precis'. I think these two functions are very useful. Is it possible to give an example code for how to use them?

Hi @Zhe-Jessica
Moved this topic to Issues.
First of all, apologies for not answering this. Apparently I don't get a message when a new discussion is started (or I have missed it).
To help you, is it correct to assume that Stan (the binary of cmdstan) works on your system? E.g. you can run the examples in either Stan.jl or StanSample.jl? If not, we first need to get to that point and, in that case, on which platform do you work? Linux, MacOS or Windows?
Have you used any of the notebooks in earlier chapters of any of the StatisticalRethinking.jl based projects? Do you use the SR2StanPluto project or older versions?
Just let me know if I use terminology you are not familiar with.
Best,
Rob


is booting with QEMU really supported? (help)

Sorry to be that type of idiot that tries to do something in an unsupported way. but not QEMU?? no frickin way.
The current issue is that ZealOS won't detect the boot cdrom supplied to QEMU. Saying it cannot "Detect the ATAPI Boot drive"
# current supplied commands
qemu-system-x86_64 -m 512M -enable-kvm -drive file=zeal.iso,format=raw,index=0,media=disk \
-device ahci,id=ahci \
-display sdl

I've also tried to look up anything related to QEMU and ATAPI. and i found this old page on the wiki
It appears that ATAPI support is yet to be added (since almost a decade ago). Or this page might be outdated. and ATAPI support is already out. but i don't know how to use it.
Is QEMU really unsupported? even though it can boot TempleOS just fine?

@coloredmarble
This works for me on the latest ISO, using qemu 8.2.2
qemu-system-x86_64 -display gtk,gl=on,zoom-to-fit=on -machine q35,kernel_irqchip=on,accel=kvm -audiodev driver=pa,id=pa1 -cdrom ZealOS-PublicDomain-BIOS  -*.iso -device AC97,audiodev=pa1 -hda ZealOS.qcow2 -m 8G -smp $(nproc) -rtc base=localtime -nic user,model=pcnet
The QEMU uasge documentation and implementation itself is a bit rough because qemu keeps changing and removing legacy stuff (like they did from version 8)

@coloredmarble  https://zeal-operating-system.github.io/ZealOS-wiki/Installing-(QEMU)

Assuming issue was resolved after 2 month stale, setting inactive


Jekyll Theme

Yo!) I wrote you in LinkEdIn but there is no reaction :)
Can I make an jekyll theme from your website? It allows you to write your articles using markdown and it will generate google analytics, seo etc.
What you think a bout it? May I make it? (And use MIT license for it)

Hi @gebeto, actually it is not my template, I used the same as this and this blogs.
I don't know the template actual name tbh.
If it was mine, I would let you make the jeykll theme for sure.

Great! Thank you!)


params: Fix doc mix-up between genesisHash and trustedHash

Codecov Report

Merging #747 (3ae49d9) into main (38a6a96) will decrease coverage by 0.01%.
The diff coverage is 50.65%.

@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
- Coverage   52.26%   52.25%   -0.02%
==========================================
  Files         103      117      +14
  Lines        6224     6593     +369
==========================================
+ Hits         3253     3445     +192
- Misses       2629     2785     +156
- Partials      342      363      +21

Impacted Files
Coverage Δ

das/daser.go
70.58% <ø> (ø)

fraud/bad_encoding.go
31.11% <ø> (ø)

fraud/proof.go
0.00% <ø> (ø)

header/dah.go
100.00% <ø> (ø)

header/header.go
49.15% <ø> (ø)

header/p2p/request.go
0.00% <0.00%> (ø)

header/p2p/serde.go
0.00% <0.00%> (ø)

header/serde.go
50.00% <ø> (ø)

header/testing.go
100.00% <ø> (ø)

header/verify.go
81.39% <ø> (ø)

... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1be3d4...3ae49d9. Read the comment docs.


Renamed AKAudioFile function parameters. Made AKMicrophoneRecorder an…

…d AKPhasedLockedVocoder use AKAudioFile. Edited OSX Playgrounds.
iOS playground edits will be done tomorrow.

You can continue committing and this pull request will update.  When its ready to merge, add a comment letting me know.


Blank page

This page is blank, but it's the first search result from here https://docs.microsoft.com/en-us/search/index?search=cloud+voicemail

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 283d323b-ac4e-e9a6-9fa2-19f4945a0376
Version Independent ID: f9b5a089-3fb7-4194-1736-293aea7a753e
Content: Cloud Voicemail
Content Source: Skype/SfbOnline/what-is-phone-system-in-office-365/phone-system-voicemail/phone-system-voicemail.md
Service: skype-for-business-online
GitHub Login: @tonysmit
Microsoft Alias: tonysmit

@officedocsbot assign @scanum

@TorrenManson Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.

@officedocsbot close


ui select list does't update

when the array is updated in the component it does not re initialize list in ui select

if you add or delete an array item angular seems not notice the change because the reference to this array has not changed.
if you do something like this:
this.itemList.push({id: '1', text: 'something'});
this.itemList= JSON.parse(JSON.stringify(this.itemList));
then the items list will be updated


basic restoration prompt B in paper

How to understand B and how to obtain B? What is the relationship between the shape of B(c×h×w) and the shape of Z？The section "Basic restoration prompt" does not provide  a clear introduction.

Hi, thank you for your attention. The details are provided in the supplementary material. In brief, we align Z with B, treating B's shape as an independent hyperparameter. In general, increasing 'c' enhances the capability of prompt at the expense of higher computational cost. Similarly, 'h' and 'w' are also trade-off parameters. We set h,w = H/2, W/2 and found it works well.

Hi, thank you for your attention. The details are provided in the supplementary material. In brief, we align Z with B, treating B's shape as an independent hyperparameter. In general, increasing 'c' enhances the capability of prompt at the expense of higher computational cost. Similarly, 'h' and 'w' are also trade-off parameters. We set h,w = H/2, W/2 and found it works well.

Thanks for your reply !

Hi, I have another question to ask.
Is the shapes of U and Z the same?
Is the elements in each row of attention map A calculated by a certain channel in Z for each channel of U?
Thx!

Hi, thank you for your attention. The details are provided in the supplementary material. In brief, we align Z with B, treating B's shape as an independent hyperparameter. In general, increasing 'c' enhances the capability of prompt at the expense of higher computational cost. Similarly, 'h' and 'w' are also trade-off parameters. We set h,w = H/2, W/2 and found it works well.

Hi, I have another question to ask.
Is the shapes of U and Z the same?
Is the elements in each row of attention map A calculated by a certain channel in Z for each channel of U?
Thx!

We use simple rules to fit prompt dimension and feature dimension. This supports images with different resolutions without modifying the prompt dimension.
Specifically, we use a simple linear interpolation to fit the width and height in each dimension. The prompt channel c can also be different from feature channel C. Obviously, if "c > C", the prompt is wasted and we only use the first C channel. If "c < C", we zero-pad U on the channel to fit C. A simple rule is enough.

We use simple rules to fit prompt dimension and feature dimension. This supports images with different resolutions without modifying the prompt dimension.
Specifically, we use a simple linear interpolation to fit the width and height in each dimension. The prompt channel c can also be different from feature channel C. Obviously, if "c > C", the prompt is wasted and we only use the first C channel. If "c < C", we zero-pad U on the channel to fit C. A simple rule is enough.

get it!


Add InCluster support as a CronJob

I liked this tool and wanted to fit one of my use cases, which was to send the output to Slack on a weekly basis.
This PR add a support for kor to run as a CronJob inside the cluster and send the output to Slack in 2 ways, either by sending raw text with a Slack webhook, or using hte files.upload Slack API to send the output as an attached file which supports formatted and bigger outputs than a webhook.
First of all, sorry about the big PR.
Let me know of your thinking on this.
If it satisfies and you want to have it merged, change the DockerHub repository from patricktoledodea/kor to one of yours on both release.yml and values.yaml as I won't be maintaining the image with all updates.

Hey @patricktalmeida
This is an incredible contribution, great features most of which are on the roadmap.
It would be super helpful if we can break this down into multiple MR's.

Docker related stuff(I'll add credentials and a repository)
Slack related code changes
Helm chart(we would want to give the option to run this as a deployment with a loop in order to allow prometheus metrics)

Also feel free to put your ideas here

Hey @patricktalmeida This is an incredible contribution, great features most of which are on the roadmap. It would be super helpful if we can break this down into multiple MR's.

Docker related stuff(I'll add credentials and a repository)
Slack related code changes
Helm chart(we would want to give the option to run this as a deployment with a loop in order to allow prometheus metrics)

I'll break this into 3 branches as you asked and push them soon.
About the Deployment part, yeah a friend of mine suggested me to push those metrics to Prometheus in order to have warnings. I also like that feature, though I focused on the one that I really needed for now. We can discuss this one further.
The CronJob can also be left for whoever wants to use it as I left and enabled: true flag which people can opt in or out when the Deployment feature gets created.
Let me know if you have other comments meanwhile.

Issue for docker ci https://github.com/yonahd/kor/issues/74

The general direction is good. I want to add something like this https://github.com/yonahd/kor/issues/75

Yeah, this PR cover this, actually. I'll still split them into 3.
I changed a little the logic on GetKubeClient function and it covers loading a SA with Role permissions.

Closing this PR. This was split into: #76 #77 #78


[Feature request] add paid column to apipayments table

very useful to keep failed payments and delete them later.
pending = False and paid = False means its failed

Maybe we should try to be explicit and introduce another column called Failed?
That way we could spot bugs