Remove unused branches

Hi @chrfalch , @wcandillon :
In the repository I noticed that there are a total of 57 branches, many of which are unused paths, tests and highs.
When one clones a repository they usually clone everything if they don't specify which branch they want, which is done by few.
To reduce the time for cloning, it would be better that when a branch is no longer used, it is deleted.
It is only a suggestion.

Just did a round of cleanup. We clean these from time to time.

@wcandillon : Great, I noticed that of the ones left there are some that are Closed or Merged but they are from @chrfalch  I think as soon as I can remove them.


On some pages, the date doesn't need to be there

There's no point in having date shown in some pages - for example, an about page. Removing date on the markdown's front matter would make it 0001-01-01.
What's the best possible way to go about doing this?
(Not a terribly critical issue; just a nice to have feature.)

I solved this by setting a variable inside the frontmatter. Something like „showdate: True“ and in the template simply query the variable with if, then, else.

Well, hey, thank you @saschadieter for the idea.
I found an easier solution:
{{ if .Params.Date }}

<p datetime="{{ .Date.Format " 2006-01-02T15:04:05Z07:00" }}" class="post-date">
  {{ .Date.Format "2006-01-02" }}
</p>

{{ end }}

By doing this, the date won't be there just by deleting the date variable in the front matter.
(It works, but the padding looks a little bit off. Will make a PR once this is fixed.)

Fixed on b1b407559eb8458388910bd41d0825cc1c20c674 and dc755b50a122f27b0f4a42ed2fd0dc57cab52efd.
Again, thank you @saschadieter.

Well, I guess that separates a full on developer from a technical writer.


Cache activated env variables if it takes >=500ms to activate

For https://github.com/microsoft/vscode-jupyter/issues/7952

Codecov Report

Merging #8363 (8ca0793) into main (59c7231) will decrease coverage by 0%.
The diff coverage is 59%.

:exclamation: Current head 8ca0793 differs from pull request most recent head 7e5f669. Consider uploading reports for the commit 7e5f669 to get more accurate results

@@          Coverage Diff          @@
##            main   #8363   +/-   ##
=====================================
- Coverage     71%     71%   -1%
=====================================
  Files        375     375
  Lines      23746   23788   +42
  Branches    3653    3662    +9
=====================================
+ Hits       17080   17103   +23
- Misses      5186    5200   +14
- Partials    1480    1485    +5

Impacted Files
Coverage Δ

src/client/common/process/interpreterActivation.ts
72% <59%> (-4%)
:arrow_down:

.../datascience/editor-integration/codeLensFactory.ts
87% <0%> (-2%)
:arrow_down:

src/client/datascience/jupyter/kernelVariables.ts
56% <0%> (-2%)
:arrow_down:

src/client/debugger/jupyter/kernelDebugAdapter.ts
77% <0%> (+<1%)
:arrow_up:

src/client/common/process/currentProcess.ts
100% <0%> (+50%)
:arrow_up:


Mvp1

Removed some MVP1 and move outside as separate branch (example monorepo or single repo which is a breaking change)
Also some functionalities disabeld as not used for the moment and some moved to MVP2


Invert key input (DSR) for use with MODEM

Using a MODEM to convert old dialup Morse (MODEM) recordings to the PyKOB data file format requires that the key input value from DSR be inverted to match the 'MARK' and 'SPACE' defined by the RS-232 standard.
This is a temporary change while we convert a number of saved audio dialup Morse recordings.

@leskerr would rather not implement a full-featured 'MODEM' interface option (as MKOB 2.5 had) - but, in order to easily convert the archive of dial-up (modem) recordings to the PyKOB recording format - it would help to have an option that can be set rather than switching to a dedicated branch. This is needed because the 'KEY' signal from the recordings is inverted from the current 'key' input.
I seperate 'Invert Key Input' config option will allow setting up dial-up conversion by selection the 'Key and/or Sender' interface and the 'Invert Key Input' options.

Gee, I even used the modem interface option a few times but haven't had to use it lately...  Before the Canadian hub died early this year I occasionally (but only much less occasionally successfully) linked MorseKOB to the Canadian hub this way.  But it was about three or four years ago that I did this last and I was never able to get a successful connection to the hub on any Morse Day.  I think Ed Trump was the last one to try and failed on a Morse Day.73, Chris-----Original Message-----
From: Ed Silky
Sent: Oct 19, 2020 5:53 AM
To: MorseKOB/PyKOB
Cc: Subscribed
Subject: Re: [MorseKOB/PyKOB] Invert key input (DSR) for use with MODEM (#150)
@leskerr would rather not implement a full-featured 'MODEM' interface option (as MKOB 2.5 had) - but, in order to easily convert the archive of dial-up (modem) recordings to the PyKOB recording format - it would help to have an option that can be set rather than switching to a dedicated branch. This is needed because the 'KEY' signal from the recordings is inverted from the current 'key' input.
I seperate 'Invert Key Input' config option will allow setting up dial-up conversion by selection the 'Key and/or Sender' interface and the 'Invert Key Input' options.
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or unsubscribe.

Adding a separate invert key input config option as suggested, rather than adding a modem interface type like MorseKOB 2.5, makes perfect sense. I like it.


Add MCALF

MCALF: Multi-Component Atmospheric Line Fitting
MCALF is an open-source Python package for accurately constraining velocity information from spectral imaging observations using machine learning techniques.
This software package is intended to be used by solar physicists trying to extract line-of-sight (LOS) Doppler velocity information from spectral imaging observations (Stokes I measurements) of the Sun, especially observations where individual spectra can contain multiple spectral components. A ‘toolkit’ is provided that can be used to define a spectral model optimised for a particular dataset.
I have labelled all of the PyHC standards as "Good".

This seems like an awesome project. I agree you're "Good" with all our standards, your repo is pretty flawless. How would you feel about presenting this at a telecon sometime? Just give us an overview of how it works?

Hi @sapols and @jibarnum, thank you! That would be great. I can introduce this project at the next telecon on 26th July. Would about 15 min presentation be okay? Happy to do longer or shorter. I'll try to highlight the aspects of the project which may be useful for heliophysics research. Thanks for the opportunity!

Hi @ConorMacBride - Awesome! I'll get you put down for the telecon on the 26th. Our telecons go 9-10 AM MT, so you're definitely free to use more time! Typically, people present something for 25-40 ish minutes, and leave time for questions. I'll send telecon info to the email indicated on your GitHub acct (we use Zoom).

That's brilliant @jibarnum! See you all then!

Good stuff! Welcome to PyHC.

MCALF is now on the Projects page: https://heliopython.org/projects/


[BUG] Machine fails to boot when QCOW2 image uses zstd compression (longhorn volume "faulted")

Describe the bug
A VM created from a zstd-compressed QCOW2 image never boots.
To Reproduce

Download the following Ubuntu image:
https://cloud-images.ubuntu.com/releases/jammy/release-20240801/ubuntu-22.04-server-cloudimg-amd64.img
Run:

wget https://cloud-images.ubuntu.com/releases/jammy/release-20240801/ubuntu-22.04-server-cloudimg-amd64.img
qemu-img convert -c -O qcow2 -o compression_type=zstd ubuntu-22.04-server-cloudimg-amd64.img ubuntu-22.04-server-cloudimg-amd64-zstd.img

Upload the ubuntu-22.04-server-cloudimg-amd64-zstd.img image through Harvester UI (everything left as default, I only removed the .img suffix from the image name).
Create a new virtual machine test-zstd:

1 CPU
2 GiB of memory
any SSH key
On the Volumes tab, set the disk-0's Image to the previously created image

See that the machine forever stays in the "Starting" state. When checking the Longhorn UI (/dashboard/c/local/longhorn), the VM's volume's health shows as "Faulted"

For comparison, you can try creating a VM from the same image in the zlib-compressed variant (i.e. the ubuntu-22.04-server-cloudimg-amd64.img file). That will succeed.
Please also note that both the zlib and zstd variants of the image run fine in a normal QEMU VM.
Here's output from qemu-img detailing both of these images:
$ qemu-img info ubuntu-22.04-server-cloudimg-amd64.img
image: ubuntu-22.04-server-cloudimg-amd64.img
file format: qcow2
virtual size: 2.2 GiB<PHONE_NUMBER> bytes)
disk size: 622 MiB
cluster_size: 65536
Format specific information:
    compat: 0.10
    compression type: zlib
    refcount bits: 16

$ qemu-img info ubuntu-22.04-server-cloudimg-amd64-zstd.img
image: ubuntu-22.04-server-cloudimg-amd64-zstd.img
file format: qcow2
virtual size: 2.2 GiB<PHONE_NUMBER> bytes)
disk size: 606 MiB
cluster_size: 65536
Format specific information:
    compat: 1.1
    compression type: zstd
    lazy refcounts: false
    refcount bits: 16
    corrupt: false
    extended l2: false

Expected behavior
I expected to be able to use zstd-compressed QCOW2 images. Zstd offers a better compression rate at vastly better compression and decompression speeds.
Support bundle
supportbundle_de0ba72b-15e7-44f6-911a-3d1069036141_2024-08-05T18-35-07Z.zip
Environment

Harvester ISO version: 1.3.1
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): Single-node test cluster running on libvirt (KVM) virtual machine with 16G RAM and 8 cores

I'm aware that this is not a supported configuration but it makes for an easy reproducer and the issue appears to be related to the virtualized storage backend, not the underlying hardware

Additional context
This is likely some sort of issue with longhorn but since Harvester doesn't provide support for direct usage of the embedded longhorn, I figured it might be better to report it here in case there's anything about Harvester that could be affecting the result. Besides, it makes for an easier reproducer than creating a whole Kubernetes/Rancher stack for hosting Longhorn and trying to figure how it works underneath since Harvester abstracts that out :smile:

this is currently not supported in longhorn: https://github.com/longhorn/longhorn/issues/3988

Hmm, this doesn't really seem like the same issue.
This is a feature of the qcow2 format, same as the zlib (deflate) compression that is supported, while the linked issue seems to be about supporting qcow2 images wrapped into generic archive files which isn't part of the qcow2 format itself. Zstd compression has been added into the format a few years ago:

Spec:
https://github.com/qemu/qemu/blob/e7207a9971dd41618b407030902b0b2256deb664/docs/interop/qcow2.txt#L223
Relevant commits: https://github.com/qemu/qemu/commit/66fcbca5a7202d2ff2973b61a30f915204917eb7,
https://github.com/qemu/qemu/commit/d298ac10add95e2b7f8850332f3b755c8a23d925

longhorn at present does not support having qcow images with compression enabled. This is likely why you are experiencing the faulted volume when trying to launch a vm with the backing image made from the compression enabled raw image.

Sorry, if you're already aware of this but I just want to make sure that there's no communication issue here. I think that my issue may not be within the scope of the linked issue (longhorn/longhorn#3988) and I would want to avoid a situation where the linked issue ends up being resolved but the support for what I'm describing isn't there because it actually turns out to need to be implemented in a different place. I realise that either way it may take a while because this is supported but I just want to be sure it's properly tracked (even if it were to come to a point where it just gets rejected).
More concretely, the QCOW2 compression is done at a cluster level within the image while the compression in the linked issue is done at, for lack of a better term, a "whole file" level. This, afaik, means that the former would be done at the QCOW2 driver abstraction while the latter would be abstracted out for the driver such that when it reads data, it sees the actual QCOW2 file bytes rather than compression-specific bytes. That's why I'm not sure that my issue falls under the linked issue's scope.

longhorn at present does not support having qcow images with compression enabled

But it does - QCOW2's (cluster-level) zlib (deflate) compression is supported (volumes are healthy and the VM is accessible) which I mentioned in the issue description. The newer zstd type is the only compression type from QCOW2 that is not supported by longhorn.

This is still relevant but I guess should be marked as an improvement same as the issue on longhorn side:
https://github.com/longhorn/longhorn/issues/9243


Link broken to download files

The following links are broken, is it possible for you to create and share new links
http://www.robots.ox.ac.uk/~vgg/data/scenetext/preproc/bg_img.tar.gz
http://www.robots.ox.ac.uk/~vgg/data/scenetext/preproc/seg.h5
http://www.robots.ox.ac.uk/~vgg/data/scenetext/preproc/depth.h5

Please see the updated links (on thor):  https://github.com/ankush-me/SynthText#pre-processed-background-images


MDC, Angular MDC, Angular Material choice

Hi,
I am quite newbie to Angular and Material.
Time is now to choose an approach to integrate Material Design in my Angular 2 project.
As I am not experimented in Angular yet, I don't understand what will be the big advantages to choose a wrapper solution like Angular Material or Angular MDC over using the MDC core project directly.
Maybe you can help me to understand why it is better or absolutely necessary to use this angular mdc wrapper?
If I understand, the wrapper is implemented independently from the core MDC library.
Is it just a wrapper around the core libraries, or a specific implementation?
Are there some features of the core MDC that are not available via the wrapper?
How the future developments in the core MDC have to be implemented in the wrapper?
There is one main contributor, does it mean that the project relies only on one developer?
Jim

@jim20100 Great choice incorporating Material Design into your next project!

Maybe you can help me to understand why it is better or absolutely necessary to use this angular mdc wrapper?

Obviously I'm a bit biased here, but I'll offer my thoughts.
First and foremost, you can focus on project development activities instead of making idiomatic Angular  components. Another option to consider is, Angular MDC is licensed under the MIT License, meaning your welcome to clone and/or fork the project to modify as you see fit.
For a fair comparison of MDC-Web vs Material 2, I'd suggest Material Components for the Web vs Angular Material 2

Is it just a wrapper around the core libraries, or a specific implementation?

Angular MDC incorporates MDC-Web via an advanced approach using Foundations and Adapters.
The MDC-Web components are split into packages, each come with a Foundation class and an Adapter interface. The Foundation contains the business logic that best represents Material Design, without referring to any HTML. The Adapter interfaces with methods that the Foundation needs to implement Material Design business logic.

Are there some features of the core MDC that are not available via the wrapper?

The goal of Angular MDC, is to be a canonical implementation of MDC-Web for Angular; a complete match for component specifications as they are made available by the MDC-Web team.

How the future developments in the core MDC have to be implemented in the wrapper?

Not quite sure I follow, could you elaborate?

There is one main contributor, does it mean that the project relies only on one developer?

I am just one, but our community is fairly small at the moment. Notwithstanding, we've had excellent contributors solve a range of issues and all contributions are appreciated! 😄

Thx for your first answer.
Maybe my questions were not clear enough. I try another way.
As I Understand there is a philosophy for material described here:
https://material.io/guidelines/
There are some usable and REAL implementations:

MDL managed by google (https://getmdl.io/)
MDC Web managed by google (replaces MDL)

specific to Angular:

Angular Material 2 managed by third-party developers
Angular MDC managed by third party developers

When you say about MDC Web it is a "canonical implementation", for me it has non sense, because it is a real implementation we can use it for real projects: https://material.io/components/web/docs/getting-started/?
I did not go into the detail of the implementation of the MDC Web by google, but it relies on css and javascript.
So does your implementation is just an additional layer/wrapper above the google code or a totally independent implementation of the components with no relation with the MDC Web by Google.
Angular Material 2 is for example a totally independent implementation.
So when I say: How the future developments in the core MDC have to be implemented in the wrapper?
You may understand that I want to understand if it will be fast to get new features via your Angular MDC.
I would be pleased to be contributor, but I have to find additional 24h in a day. :-)
Jim

@jim20100

So does your implementation is just an additional layer/wrapper above the google code or a totally independent implementation of the components with no relation with the MDC Web by Google.
Angular Material 2 is for example a totally independent implementation.

We add an Angular layer via the MDC-Web Foundations and Adapters, meaning we depend on MDC Web to execute Material Design.

So when I say: How the future developments in the core MDC have to be implemented in the wrapper?

MDC-Web normally publishes a new version every two-weeks, and it normally takes 2-3 weeks to implement those changes and publish a compatible Angular MDC release.

Closing.


Spark.Engine project Naming: Spark.EngineR4 & Spark.EngineSTU3

Problem description
I can't install the Spark.Engine R4 and Spark.Engine.STU3 packages in the same projects.
Solution I'd like
I was wondering if you could change the name of the outputs build dll in, for example, Spark.EngineR4 and Spark.EngineSTU3 in their relative branch.
Details of my project
I'm building a project that supports Fhir version HL7.Fhir.STU3 and HL7.Fhir.R4.
Since the original Hl7.Fhir packages have different names between them, I can install Hl7.Fhir.R4.dll and Hl7.Fhir.STU3.dll in the same project.
The project implements through dependency injection some components dedicated to R4 Mode and others to STU3 mode.
I tried to do the same thing with packages Spark.Engine.R4 and Spark.Engine.STU3 but both presents the same dll name and one override the other one.
By downloading the source code of Spark R4/master and Stu3/master and re-building pakages and renaming dll (i chose Spark.EngineR4 and Spark.EngineSTU3 names), I succeded to install Spark.EngineR4 and Spark.EngineSTU in the same projects.
Additional context
Spark Versions (nugetpackages)

Release v2.2.1-stu3 (link)
Release v2.2.1-r4 (link)

Hey @johnsierra24, that seems reasonable. If it doesn't cause any other problems (which I do not think it will) I will get it into the next release.

Thank you very much for your availability!
Let us know if also you the change is safe

@johnsierra24 this was released just now in 2.3.0


What's the meaning of "readSourceHash" function?

I just wonder what is the meaning of this function? Why can it work when using "readSourceHash" to produce dummyCode and then pass them as code to "vm.script" function?
const readSourceHash = function (bytecodeBuffer) {

  if (!Buffer.isBuffer(bytecodeBuffer)) {
    throw new Error(`bytecodeBuffer must be a buffer object.`);
  }

  if (process.version.startsWith('v8.8') || process.version.startsWith('v8.9')) {
    // Node is v8.8.x or v8.9.x
    return bytecodeBuffer.slice(12, 16).reduce((sum, number, power) => sum += number * Math.pow(256, power), 0);
  } else {
    return bytecodeBuffer.slice(8, 12).reduce((sum, number, power) => sum += number * Math.pow(256, power), 0);
  }
};

Thanks in advance :)

I wrote about this before, check this article: https://medium.com/hackernoon/how-to-compile-node-js-code-using-bytenode-11dcba856fa9
Let me know if you still have a question.

I wrote about this before, check this article: https://medium.com/hackernoon/how-to-compile-node-js-code-using-bytenode-11dcba856fa9
Let me know if you still have a question.

thanks！！！helps a lot


feat!: change default value of switchoverDelay to 3600

BREAKING CHANGE: The default value of switchoverDelay has now been changed to 3600 seconds, equivalent of 1 hour. Previously, it was set to 40000000 seconds.
Closes #2845

/test limit=local

The default value only affects new clusters; is this a breaking change?


authentication done using email and password

This PR does the following:

Adds user authentication using Firebase with email and password.
Fixes the logout button functionality by implementing loaders and toaster notifications.
Updates the user interface to reflect authentication state changes without needing a page refresh.

Related Issues:

Fixes #243

Changes

Added Firebase authentication integration for user registration and login.
Implemented the logout button with a working loader and toaster notifications.
Updated user interface elements to dynamically show login/logout states.

Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

Pull this branch.
Run npm install to install dependencies.
Set up Firebase configuration in the project.
Run npm start to start the application.

Verify the following:

User can register and log in using email and password.
User can log out and see a loader and toaster notification.
Upon logout, the interface updates correctly to show the login button without needing a page refresh.

This PR is based on the initial proposal to implement authentication and authorization features. The implementation uses Firebase for both authentication and database management as a preference over MongoDB/Mongoose.
Checklist

[x]  I have performed a self-review of my code
[x]  I have commented my code, particularly in hard-to-understand areas
[x]  My changes generate no new warnings
[x]  I am working on this issue under GSSOC

@RahulRudra81 do it with env file than i'll add environment variables in vercel deployment.

@Satyam1923 I have added signin with goggle and env files . Since i got the opportunity to signin with goggle I also gave an option for profile picture so if you are logging with goggle it will fetch your goggle profile picture too

@RahulRudra81 but why did you push node_modules this time.

@Satyam1923 i dont know why they got pushed i mentioned node modules in git ignore file. wait i will delete and push again. Sorry for the inconvenience

@Satyam1923
in your firebase console go to authentication and enable

email and password and also goggle

Also here is my env you can try to check if my code works properly.
VITE_API_KEY=AIzaSyCa-ssdrMojEtIqfe4ugN9_7KgiyuP26-M
VITE_AUTH_DOMAIN=spring-9c847.firebaseapp.com
VITE_PROJECT_ID=spring-9c847
VITE_STORAGE_BUCKET=spring-9c847.appspot.com
VITE_MESSAGING_SENDER_ID=590720161705
VITE_APP_ID=1:590720161705:web:09750dd0c67fc07005d6b8

https://github.com/Satyam1923/Spring-Music-Player/assets/104068640/87f6b2b6-330d-4043-90a9-a9f2e1741ba8
This error is happening for login with google.

https://github.com/Satyam1923/Spring-Music-Player/assets/104068640/611208a0-dc62-4fac-82fb-6a112d525256
this error for login with email account.

env which I am utilizing.

can you please also send the console if that is generating any errors while login and register

this error when register user and login.

@Satyam1923 can you please go to firestore database and the rules option there and check if you rule is set such that anyone can access it.
Check for the following code in your rules:
rules_version = '2';

service cloud.firestore {
  match /databases/{database}/documents {

    match /{document=**} {
      allow read, write: if request.time < timestamp.date(2024, 7, 9);
    }
  }
}

if this doesn't work try using the followig code :
service cloud.firestore {
  match /databases/{database}/documents {
    match /Users/{userId} {
      allow read, write: if request.auth.uid == userId;
    }
  }
}

@RahulRudra81 ya now seems login with user email and password is working
but still google login is not working.

@Satyam1923
You have to setup oauth following these steps:

Configure OAuth Consent Screen:

Go to https://console.cloud.google.com/
Select your project or create a new project.
Navigate to the "APIs & Services" > "OAuth consent screen".
Configure the consent screen by providing the necessary information such as the application name, support email, authorized domains, etc.
Make sure to add the domain where your app is hosted to the authorized domains list.

Create OAuth Client ID:

In the Google Cloud Console, go to "APIs & Services" > "Credentials".
Click on "Create credentials" and select "OAuth client ID".
Configure the OAuth client by selecting the appropriate application type (Web application, iOS, Android, etc.).
For a web application, add your app's URL to the "Authorized JavaScript origins" and "Authorized redirect URIs".
Save the OAuth client ID and secret. You'll need to use these in your Firebase project.

Add OAuth Client ID to Firebase:

In the Firebase Console, go to the "Authentication" section again.
Under "Sign-in method", click on the "Google" provider.
Enter the OAuth client ID and secret obtained from the Google Cloud Console.
Save the configuration.

here only right ?

@Satyam1923 just delete the provider in firebase authentication and then add go to add new provider and add goggle from there . this time put the same email you used for creating oauth acc. it should work fine then

@RahulRudra81 not working even though after that.

@Satyam1923 is there anything in console when you click on the sign in with goggle?

this error when i click on sign up with google.

The error auth/unauthorized-domain occurs when the domain from which the authentication request is made is not listed in the authorized domains in the Firebase project settings. Here’s how to resolve this issue:
Steps to Resolve auth/unauthorized-domain Error

Add Authorized Domains in Firebase Console:

Go to the Firebase Console.
Select the relevant project.
Navigate to the "Authentication" section.
Go to the "Sign-in method" tab.
Scroll down to the "Authorized domains" section.
Add the domain from which the owner of the repo is testing the application (e.g., localhost for local development or the actual domain where the app is hosted).

Verify Project Configuration:

Ensure that the Firebase configuration used in the project matches the Firebase project credentials the owner is using.

Update Firebase Configuration in Code:

Verify OAuth Consent Screen and Client ID

Ensure OAuth Consent Screen is Configured:

Go to the Google Cloud Console.
Select the Firebase project.
Navigate to "APIs & Services" > "OAuth consent screen".
Ensure the consent screen is properly configured.

Check OAuth Client ID and Secret:

Ensure the OAuth client ID and secret used in the Firebase authentication configuration match the details from the owner's Google Cloud Console.
In the Firebase Console under "Authentication" > "Sign-in method" > "Google", the OAuth client ID and secret should be correctly set.

Additional Troubleshooting

Clear Browser Cache:

Sometimes, browser caching can cause issues. Clear the browser cache or use an incognito window to test.

CORS Issues:

Ensure there are no CORS issues. This can be verified by checking browser console logs for any related errors.
By following these steps, the owner of the repo should be able to resolve the auth/unauthorized-domain error and successfully test the Google Sign-In feature using their own Firebase credentials.

@RahulRudra81 fine got the issue actually I have authorizing my vercel doman but It needed your branch vercel url. So it's working now so fix these conflicts and if possible implement these sign in and sign out.

I have resolved all the conflicts and made changes in the latest codebase . @Satyam1923

@RahulRudra81 nice work.


Inter-account isolation

Hi,
Could be possible to have inter-account isolation allowing to isolate entirely the files beetween users?
Thank's
Roger

Hi, Roger
just to clarify: you'd essentially want smth like cdmi-server:port/~user/contaner1/container2..., but with that ~user part being deduced from the authentication?

Yes exactly,
In a way that, for instance, user1 cannot see (read, write...) anything about the other system users.
Roger


Prometheus exposition format output support

Similar to the InfluxDB output format we could support Prometheus exposition format for output. This can easily be done manually to print the data in accordance to the format specification; but there is also expfmt Go package available although it may be too much overhead to convert data to Prometheus model data for decoding. On the other hand it would be more correct.

Initial pass at this has been added to 0.102.0. Please test it out and feel free to create a new issue if there are improvements to be made.

hi @bojand , Is there a grafana panel currently available，Apply to Prometheus


Update README to reflect 1.18 go get deprecation

Updated README from go get to go install to reflect 1.18 deprecation of go get.

This is not a library you can download, go get looks fine for me. Is there a reason you want to change it?

In this case I misread the deprecation. I'll go ahead and close this out. My mistake.


[Sage 10] "Class 'Intervention\HttpAuth\Laravel\HttpAuthServiceProvider' not found"

[x] I've read the guidelines for Contributing to Roots Projects
[x] This request isn't a duplicate of an existing issue
[x] I've read the docs and followed them (if applicable)
[x] This is not a personal support request that should be posted on the Roots Discourse community

Description
After having a Sage 10 theme created and activated the following error occurs:
Class 'Intervention\HttpAuth\Laravel\HttpAuthServiceProvider' not found

Steps to reproduce

Create a new Sage 10 project (composer create-project roots/sage your-theme-name dev-master).
Run npm install && npm run build (composer install is already run by the composer installer script).
Activate that theme. Note the error mesage.

Expected behavior: No error message.
Actual behavior: Exception Class 'Intervention\HttpAuth\Laravel\HttpAuthServiceProvider' not found
Reproduces how often: Always.
Versions
Current master (10.0.0-beta.1: TBA).
Recent Bedrock (1.16.1: 2021-07-30).

what plugins are you running? i think it might be caused by wp-optimize

Yes, after removing the plugins folder and re-running composer for the Bedrock site, the error went away.
IMHO the issue is that there are actually two composer projects: One for the Bedrock site and one for the Sage theme.
Usually these don't interfere - but because both composer managed projects are loaded at the same time (and plugins are allowed to use practically anything, composer, bundled libraries, etc that will be used by the Bedrock composer), issues like these can happen sometimes. It would be nice if composer projects can be somehow chained/linked so composer knows about the other composer files and harmonize the dependencies.


fix(cypress): Fix failing/flaky E2E tests

SUMMARY

This PR attempts to fix some failing/flaky Cypress tests:

Horizontal FilterBar > should spot changes in "more filters" and apply their values (fail 23%, flake 22% on master last 7 days)
Drill to detail modal > Tier 1 charts > Modal actions > paginates (fail 8%, flake 30% on master last 7 days)
Charts list > Cross-referenced dashboards > should show the newly added dashboards in a tooltip (fail 0%, flake 80% on master last 7 days)
Horizontal FilterBar > should go from vertical to horizontal and the opposite (fail 3%, flake 22% on master last 7 days)
Horizontal FilterBar > should show all default actions in horizontal mode (fail 0%, flake 13% on master last 7 days)
Horizontal FilterBar > should display newly added filter (fail 2%, flake 13% on master last 7 days)

The code changes include:

Replacing .then with .should calls in drilltodetail.test.ts to allow for retries within the callback
Adding a timed .wait in nativeFilters.test.ts to give the filter bar orientation menu time to change orientation after scrolling into position
Switching the target for .type from the input's parent to the input itself in horizontal filter bar tests, as the input's parent was at times not considered "visible" by Cypress
Making Cypress wait for the confirmation toast to appear after saving a chart to a dashboard before navigating away from the page

TESTING INSTRUCTIONS

Check that E2E tests pass on CI, and feel free to re-run a few times to try to catch any extra issues
Run Cypress E2E tests locally several times with throttling enabled, specifically looking for issues in:

dashboard/drilltodetail.test.ts
dashboard/nativeFilters.test.ts
chart_list/list.test.ts

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Hi @codyml! I have problem with chart_list/filter.test.ts and dashboard_list/filter.test.ts

@codyml Can you see my #22489 PR and check failed cypress CI?


DisplayPower API implementation for Echo Dot with Clock

Is your feature request related to a problem? Please describe.
A solution for implementing the on / off toggle that permit he visible / hide of clock on echo dot with clock
Describe the solution you'd like
A binary toogle to hide / show the clock
Describe alternatives you've considered
Probably send a message "alexa, tun on / off the display"
Additional context
Hello,
is it possible to integrate a switch for echo dot with clock.
I have found the undocumented API.
You can have a look here :
https://github.com/Apollon77/ioBroker.alexa2/issues/356
Or Here :
https://github.com/sigalou/jeedom_alexaapi/issues/35
the URL to call is :
/api/v1/devices/A0XXXXXXXUI/settings/displayPower
With payload {"value":""ON""} or {"value":""OFF""}

Thanks. Happy to take a PR to add this.

If the API doesn't provide state back it may need to be a button.

Hello
If i remember correctly, calling the url with GET http verb give you the current status.


Move Container to Winery Model for Tosca interactions

Short Description
This change drops the duplication of the Tosca-Model by the container and instead directly uses the model exposed by the winery. It additionally changes the representation of CSARs used by the container. Instead of a self-rolled half-unpacked representation that necessitates resolving any contents of the CSAR through XML-Queries, a Csar is now encapsulated into a standalone winery IRepository that exposes query methods acting on the aforementioned winery model.
Current Status, Functionality and Coming Work
The core functionality for Csars (namely storage and retrieval) is fully functional with the current changes. There is some ironing out for bugs to be done when retrieving deeper components of Csar.
Note that the current status does break a lot of other uses. Notably it completely breaks the planbuilder, because the planbuilder relies on the ToscaMETAFile of a CSAR to be readable. It also breaks any functionality that depends on the ToscaReferenceMapper, given that this class is supposed to be completely replaced by queries against IRepository and usage of the winery model.
The changeset most likely also breaks downstream API consumers, because the internal representation of a CSAR was exposed on different API endpoints. Most notably this will affect any users of the content endpoint.
The final goal of the changes is to completely remove the classes CSARContent and CSARID and replace all of their usages with Csar and CsarId respectively. For now this also breaks the ability to store a csar on a distributed filesystem. Future implementations of Csar could reintroduce that capability.
The directly following next steps are in decreasing order of imporance:

Find a way to limit or even stop the breakage in other components
Migrate directly related components and Controllers (ServiceTemplateController, BoundaryDefinitionController, ...)

Migrating these controllers implies migrating the core and satellite functionality they access

Pull Planbuilder onto winery model and new Csar representation
Simplify Services and Functionality not directly related (mostly those services with an internal proxy)

None of these steps should involve interdependencies. As such it should be possible to work on this with multiple people given little coordination.
Further notes:
This PR currently contains a few bad references:

The CSARs are currently stored to a basically hardcoded path under /tmp. This should be made configurable at the start of the product, possibly at runtime.
A number of types have been marked Deprecated. On one hand I have been generous with marking old API and files as obsolete, on the other hand, I have probably missed some API that should be deprecated. There's some work to be done in determining what can be dropped and what should be kept for the future.

Kleines Statusupdate, damit ich es nicht vergesse:
bouncycastle's bcprov:1.54.0 spezifiziert den folgenden Bundle-RequiredExecutionEnvironment header:


thuang-radio-useState

Reviewers
Functional:
Readability:

Changes

add
remove
modify

Thanks for the quick review, @seve ! Merging 🤩!

Thanks for the quick review, @seve ! Merging 🤩!


iOS: Saved story tags popover too small on top

See screenshot. Also we should fix the header spacing.


Issue with hibernation and wifi

Hello all!
I've bought a new xiaomi notebook pro 15, i7 with 16gb ram for my office.
Bios version: 603, I patched the scripts on w10 (fan scripts, speedshift, and so, like my other notebook pro).
I had to change the ssd pm981 to a samsung 970 m2 because of the incompatibility, and now everything is installed and working fine, except wifi and hibernation.
When I installed AirportBrcmFixup.kext to check the wifi, after restart, wifi worked ok. But after first hibernation, the wifi crash, and hibernation too. I mean, after the first sleep, the wifi didnt work anymore (I rebooted more than 30 times and tried everything without success), and the hibernation now doesnt work too. It goes to sleep ok, but when I press power button, the screen keeps black. I tried to replace full EFI folder again (newest release one) but nothing. I have dumped all files required by rehabman, maybe you can guide me.
The wifi chip I'm using is this: DW1560 BCM94352Z NGFF M.2 with shentek adapter in 2nd SSD slot, like my other notebook.
debug_23685.zip

Hi, I am using BCM943602CS without any kexts like AirportBrcmFixup.kext, and it works great. I don't come up with an idea about your problem. Maybe you can leave the issue open here or do the Disable Hibernation part in https://www.tonymacx86.com/threads/guide-native-power-management-for-laptops.175801/.

I followed rehabman guide to disable hibernation but hibernation still "hibernates". When I click on sleep, notebook goes to sleep after few seconds. And wifi still doesnt work. I have bought 2 packs of BCM943602CS with adapter to ngff m2 (1 in aliexpress and 1 in taobao).

You can try to remove HibernationFixup.kextin /CLOVER/kexts/Other, check NeverHiberante, and uncheck HibernationFixup in config.plist.

OK. Then, with BCM943602CS, you can hibernate without troubles with wifi, right?

@alexmenn so far mine is working like a charm. Highly recommended.

Yeah! The chip arrived today, works like a charm, really cool. Now I need 3 cool mhf4 antennas, who can give me aliexpress link of good antennas?

@alexmenn , can you please post some pictures, I bought the same chips and adapter mentioned in this post. They are still in flight. Also a link to procedure will be much appreciated.
Thanks

Hi @kampav . My notebook is closed, but the process is very easy. You just have to hold the chip and adapter with any tape and then hold the adapter to the m2 slot with the screw :)
I didnt weld the bluetooth wires yet, but I will.

@alexmenn , thanks mate, once you open the box for soldering. Please upload some pictures before and after solder. Thank you so much in advance.

hi @stevezhengshiqi . Im speaking with Rehabman (tonymacx expert) and we are having some troubles injecting 3rd party kext in probook.
You may consider a little change in config.plist to avoid kext injection in clover folder and in /S/L:
config.plist/SystemParameters/InjectKexts=Yes is wrong. Should be "Detect".

@alexmenn Thank you, I may consider that. It is set to Yes because I am afraid that some people may install kexts incorrectly, and this option can let system ignore the unsupported kexts. You can put your kexts into CLOVER folder as well.

Sadly experiencing the same issue with op's original card.
It works only with a full reboot somehow, when you click reboot it says hardware missing, when you click shutdown and press power button to boot it works.  Also if computer hibernates, wifi is stuck on disabled, BUT if you hibernate again it re enables itself !


UE5 errors

I did install latest plugin version and I am trying to run this example but I am getting tons of errors inside this ArtisticStyleTransfer blueprint.

This repository was originally created for UE4. Generally speaking, you can just refresh (recreate) all nodes with the errors to update the project for UE5.
I just added a new branch for UE5 for you. Download the new release for UE5 here.


Product added to cart and removes on the page load - cookie not set

Expected Behaviour

When user add product to cart, it is added.
When user refresh the page or navigate to any other page, the added product stays in cart.

Actual Behaviour
Product removes from cart if navigate to other page or we reload the page.
The cookie 'cif.cart' is not set
Reproduce Scenario (including but not limited to)
Steps to Reproduce
Platform and Version
AEM 6.5.0
Magento 2.3.4
CIF 1.1.0
Sample Code that illustrates the problem
Logs taken while reproducing problem

@bharathkeystride can you please check if the issue is solved with the latest version? I suspect the issue occurred because of https://github.com/adobe/aem-core-cif-components/pull/389.


nixos/networkd: update configuration options

Motivation for this change
While working on my person home router configuration I started adding a few more options to our systemd-networkd configuration options. The entire area around prefix delegation wasn't really covered. Also upstream just recently added support for PrefixDelegationHint which is a must-have  (for me). That flag will become available soon. @NinjaTrappeur is working on the systemd v244 upgrade.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Awesome, it was on my todo list!
One thing though: the systemd configuration parser won't error when encountering some unknown keys. That's kind of an issue when we'll update systemd and a key has been renamed. The module could silently break.
One way to mitigate that problem is to add some nixos tests and check that each networkd directive has indeed been applied to a test network. We started doing that in nixos/tests/systemd-networkd.nix.
Do you plan to add some tests for the RA/DHCPv6 setup? If you don't, could you please wait for me to add some RA-related tests before merging that?

@andir can you address the requested changes, and rebase on latest master?

On 00:49 08.03.20, Félix Baylac-Jacqué wrote:

Awesome, it was on my todo list!
One thing though: the systemd configuration parser won't error when
encountering some unknown keys. That's kind of an issue when we'll
update systemd and a key has been renamed. The module could silently
break.
One way to mitigate that problem is to add some nixos tests and check
that each networkd directive has indeed been applied to a test
network. We started doing that in nixos/tests/systemd-networkd.nix.
Do you plan to add some tests for the RA/DHCPv6 setup? If you don't,
could you please wait for me to add some RA-related tests before
merging that?

Yes, I have some extensive test suite locally that tests the whole
IA-NA/IA-PD setup but I do not intend to commit it with this PR. It
needs a bunch of polishing. Will likely happen soon(tm) but not
immediately.

Rebased and fixed a few typos. Any further requests? @flokli
As I stated earlier the tests I plan to add are probably too big to be in scope of this change and will require some discussions while these changes here should not be controversial.

Adding the tests later is fine. Let's merge this :+1:


when click back from settings url, should dismiss setting pane

perhaps we eventually do somethign like notice if they've made changes they didn't save as in http://stackoverflow.com/q/26161854/1449799

this might help: http://stackoverflow.com/questions/24713242/using-ui-router-with-bootstrap-ui-modal

Fixed issue when click back from settings url, should dismiss setting pane #29


fix: if image starts with 'ipfs://', the return value should be string type

Explanation
return promise value if image starts with 'ipfs://' at ERC721Standard.ts
References
Changelog
Checklist

[x] I've updated the test suite for new or updated code as appropriate
[ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
[ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate
[ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Hi @GinMu, thanks for submitting this PR. Glancing at the code there does seem to be a bug with getDetails in the case you highlighted.
It would be good to have a test which confirms the bugfix and then we can merge this. If you'd like to add this then that would be great, but otherwise we could do that.

Hi @mcmire , have added test case.


Support package distribution tags

Tested via npm link on OSX with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Closes #4348

I retriggered it, but can you please add a test for this to e2e-installs?

Any idea why npm run e2e:docker fails upon publishing packages to the local registry?

If you're talking about running the docker e2e tests locally then that's a known issue. They haven't been working properly for a while.

@iansu thank you for clarification. I struggle to find the reasons of build failures.
I doublechecked every line of code I changed and still can't figure out what might cause a fail.
Any chance you could point me mistakes I made?
Travis: same errors as I wrote above.
AppVeyor:

error An unexpected error occurred: "http://localhost:4873/react-scripts-fork/-/react-scripts-fork-0.4.3.tgz: unexpected end of file

Reopened to trigger CI

@Timer here we go :)

Awesome! Thanks much.


Small typos fixes

This PR fixes some (very) small typos in Channel's Javadoc.

@pdalpra could you please sing our ICLA:
http://tinyurl.com/netty-icla

♫ He is singing your ICLA ♪♩
Sorry, I couldn't resist :)
On Sat, Mar 21, 2015 at 4:31 PM, Norman Maurer<EMAIL_ADDRESS>wrote:

@pdalpra https://github.com/pdalpra could you please sing our ICLA:
http://tinyurl.com/netty-icla
—
Reply to this email directly or view it on GitHub
https://github.com/netty/netty/pull/3520#issuecomment-84266015.

:)
@normanmaurer Just signed it !

Cherry-picked into 4.0 (2221dc6b20e38cc84e5c17ef27d35266b3def554) , 4.1 (2ebf07e62234d02804a6707957288f4292294f16) and master (d7581e57269eb291b3cec217c5beaf25e76a90af)


Error:  couldn't find file 'jquery' with type 'application/javascript'

When I deploy the forked repository locally the terminal comes across the the following error:
Error:  couldn't find file 'jquery' with type 'application/javascript' in `_posts/2017-12-22-configuring-chalk.md'

I have the same problem. Tried npm clean up with --force, removing node_modules and reinstall and the result is the same.
Doing this on Arch.

Same problem here. Is the repo maintained? The owner hasn't answer about this. I'm not a front-end expert and I've been trying to fix the problem with no luck and I'm not able to execute the demo locally: jekyll serve keeps giving me that erro:
Liquid Exception: couldn't find file 'jquery' with type 'application/javascript' in `_posts/2017-12-21-chalk-sample-post-with-all-elements.md' Checked in these paths:  /Users/xxx/Development/Website/Thirds/Chalk/_assets/icons
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/javascripts
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/stylesheets
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/yarn
  /Users/xxx/Development/Website/Thirds/Chalk/assets/css
  /Users/xxx/Development/Website/Thirds/Chalk/assets/fonts
  /Users/xxx/Development/Website/Thirds/Chalk/assets/images
  /Users/xxx/Development/Website/Thirds/Chalk/assets/videos
  /Users/xxx/Development/Website/Thirds/Chalk/assets/audios
  /Users/xxx/Development/Website/Thirds/Chalk/assets/components
  /Users/xxx/Development/Website/Thirds/Chalk/assets/javascript
  /Users/xxx/Development/Website/Thirds/Chalk/assets/video
  /Users/xxx/Development/Website/Thirds/Chalk/assets/audio
  /Users/xxx/Development/Website/Thirds/Chalk/assets/image
  /Users/xxx/Development/Website/Thirds/Chalk/assets/img
  /Users/xxx/Development/Website/Thirds/Chalk/assets/js
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/css
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/fonts
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/images
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/videos
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/audios
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/components
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/javascript
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/video
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/audio
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/image
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/img
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/js
  /Users/xxx/Development/Website/Thirds/Chalk/css
  /Users/xxx/Development/Website/Thirds/Chalk/fonts
  /Users/xxx/Development/Website/Thirds/Chalk/images
  /Users/xxx/Development/Website/Thirds/Chalk/videos
  /Users/xxx/Development/Website/Thirds/Chalk/audios
  /Users/xxx/Development/Website/Thirds/Chalk/components
  /Users/xxx/Development/Website/Thirds/Chalk/javascript
  /Users/xxx/Development/Website/Thirds/Chalk/audio
  /Users/xxx/Development/Website/Thirds/Chalk/video
  /Users/xxx/Development/Website/Thirds/Chalk/image
  /Users/xxx/Development/Website/Thirds/Chalk/img
  /Users/xxx/Development/Website/Thirds/Chalk/js
  /Users/xxx/Development/Website/Thirds/Chalk/.jekyll-cache/assets/proxied in /_layouts/post.html
jekyll 3.8.4 | Error:  couldn't find file 'jquery' with type 'application/javascript' in `_posts/2017-12-21-chalk-sample-post-with-all-elements.md'

Checked in these paths:
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/icons
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/javascripts
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/stylesheets
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/yarn
  /Users/xxx/Development/Website/Thirds/Chalk/assets/css
  /Users/xxx/Development/Website/Thirds/Chalk/assets/fonts
  /Users/xxx/Development/Website/Thirds/Chalk/assets/images
  /Users/xxx/Development/Website/Thirds/Chalk/assets/videos
  /Users/xxx/Development/Website/Thirds/Chalk/assets/audios
  /Users/xxx/Development/Website/Thirds/Chalk/assets/components
  /Users/xxx/Development/Website/Thirds/Chalk/assets/javascript
  /Users/xxx/Development/Website/Thirds/Chalk/assets/video
  /Users/xxx/Development/Website/Thirds/Chalk/assets/audio
  /Users/xxx/Development/Website/Thirds/Chalk/assets/image
  /Users/xxx/Development/Website/Thirds/Chalk/assets/img
  /Users/xxx/Development/Website/Thirds/Chalk/assets/js
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/css
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/fonts
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/images
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/videos
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/audios
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/components
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/javascript
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/video
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/audio
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/image
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/img
  /Users/xxx/Development/Website/Thirds/Chalk/_assets/js
  /Users/xxx/Development/Website/Thirds/Chalk/css
  /Users/xxx/Development/Website/Thirds/Chalk/fonts
  /Users/xxx/Development/Website/Thirds/Chalk/images
  /Users/xxx/Development/Website/Thirds/Chalk/videos
  /Users/xxx/Development/Website/Thirds/Chalk/audios
  /Users/xxx/Development/Website/Thirds/Chalk/components
  /Users/xxx/Development/Website/Thirds/Chalk/javascript
  /Users/xxx/Development/Website/Thirds/Chalk/audio
  /Users/xxx/Development/Website/Thirds/Chalk/video
  /Users/xxx/Development/Website/Thirds/Chalk/image
  /Users/xxx/Development/Website/Thirds/Chalk/img
  /Users/xxx/Development/Website/Thirds/Chalk/js
  /Users/xxx/Development/Website/Thirds/Chalk/.jekyll-cache/assets/proxied

You probably do not have certain yarn modules installed. I had the same issue until I looked into the build script at bin/setup. The last couple lines take care of the JS dependency:
npm install -g yarn
yarn install --modules-folder ./_assets/yarn

If anyone is still stuck with this, I believe it’s because the yarn.lock file is offending. Delete it, and then remove _assets/yarn.  Then running the very last command @knhash mentioned, again, should do the trick. In my case I think I originally made use of this repo by mirroring it, and hadn’t received any updates from it in a while. So I set https://github.com/nielsenramon/chalk.git as upstream and then merged it into one my local branches. Maybe the yarn.lock file was left over since it appears to be ignored.


yarn.lock should not be listed in .gitignore

I noticed that the yarn lock file is ignored. Is this on purpose?
https://github.com/yarnpkg/yarn/issues/1583

It is, yarn + lerna = trouble for us right now.
You're free to use yarn to install in root, but lerna should be using npm.
We're caching node_modules in travis CI, so builds are already relatively fast, yarn is not that much faster in this case to warrant the issues when combining with lerna at this point.


Support for custom HTTP codes

Sleuth checks if the response is successful (successful or redirection, see). The TraceFilter uses HttpStatus.valueOf(response.getStatus()); that throws an exception on custom HTTP codes.
The actual exception:
java.lang.IllegalArgumentException: No matching constant for [560] at org.springframework.http.HttpStatus.valueOf(HttpStatus.java:497) at org.springframework.cloud.sleuth.instrument.web.TraceFilter.httpStatusSuccessful(TraceFilter.java:253) at org.springframework.cloud.sleuth.instrument.web.TraceFilter.doFilter(TraceFilter.java:133)

This is related to https://jira.spring.io/browse/SPR-14205

@robwin so this will work without any change in Spring 4.2.5?

No, but it provides an alternative which allows custom status codes.

Sry I think there is only a fix for ResponseEntity.

@FlorianLautenschlager is it also fixed in 1.1 x and 1.0.x?

Yes it is. The latest release contains the old code, that produces the exception.


rebase script broken by latest changes

@bparees as @php-coder found out, we are not adding the pkg/run package when we bump origin.
do we remove the package or the exception in the script?
exception:https://github.com/openshift/source-to-image/blob/master/hack/rebase-to-origin.sh#L29
and variable.
https://github.com/openshift/source-to-image/pull/543/files#diff-234f90ce9afdfa35fbed6beda2f55c53R14
currently this is broken, so we shouldn't bump origin.

The dependency on github.com/openshift/source-to-image/pkg/run package was added in PR #543 I suggest to move this constant to somewhere else and leave rebasing script as-is.

yeah, agreed, we can move the constant somewhere else.


SlackAdapter Sample answer more than once for each message

Description
Testing an echo bot sample with the SlackAdapter included, we noticed that the bot answers repeatedly to a single message. Even it echos back previous messages.
Expected Behavior
The bot should answer only one time to a message.

Fixed


didkit build error

while I was building credible, following the steps in README, I had some problem running
 make -C lib ../target/test/android.stamp

error:
// snip..
"-Wl,-Bdynamic" "-ldl" "-llog" "-lunwind" "-ldl" "-lm" "-lc" "-Wl,--eh-frame-hdr" "-Wl,-znoexecstack" "-L" "/home/uni01/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/i686-linux-android/lib" "-o" "/home/uni01/spruceid/didkit/target/i686-linux-android/release/deps/libdidkit.so" "-Wl,--gc-sections" "-shared" "-Wl,-zrelro,-znow" "-Wl,-O1" "-nodefaultlibs"
  = note: ld: error: unable to find library -lunwind

however I have libunwind installed on my system
libunwind.so
libunwind.so.8
libunwind.so.8.0.1
libunwind-x86_64.a
libunwind-x86_64.so
libunwind-x86_64.so.8
libunwind-x86_64.so.8.0.1

and about LD_LIBRARY_PATH:
/usr/lib/x86_64-linux-gnu

so what is going on and what i have missed?

Use forked repository https://github.com/alan-turing-institute/trustchain-mobile.git
and follow the instructions from install_trustchain_mobile.md file to setup the project.
This is updated latest repo.
Android and iOS running successfully without any issues.


Sub-queries are not wrapped in parentheses if toParam is used

Sub-queries are not wrapped in parentheses as you state in your examples on main page when using toParam()
var squel = require('squel').useFlavour('postgres');
var res = squel.insert().into('t1')
.set('col1', 1)
.set('col2', squel.select().field('col2').from('t2')).toParam();
//res.text: INSERT INTO t1 (col1, col2) VALUES ($1, SELECT col2 FROM t2)

Is this invalid SQL as far as the db engine is concerned?


project.getPath() did not exist causing undefined method error, fixed.

I'm sure there's a cleaner way to do this, but I haven't had the chance to look at much of atom-core. An improvement that implements project.getPath() as project.rootDirectories[0].path would be sweet.

I think we just need to use project.getPaths()[0]. Have a look at this commit for reference: https://github.com/alkama/atom-racer/commit/9978b827f7bbefd8b044c23862a13184f1f142aa
Could you test that and update your PR? Thank you :)

I tested with project.getPaths() in the fix to terminalClicked and it worked fine in the commit I just added, as well as in the runAll function. I'm going to make them all getPaths()[0] though, that seems more correct.

@matugm should be all good now, tested both runAll and the links in rspec-views using getPaths()[0]. Both work fine.


Handle multiple unused submodule imports

I've got the tests and the right behaviour in place, but the code is not pretty right now.

[ ] Cleanup code

This resolves the issue where ruff doesn't see any unused imports in code like this:
import multiprocessing.pool
import multiprocessing.process
z = multiprocessing.pool.ThreadPool()

The underlying issue was twofold:

When tracking submodule imports, we used the first part of the module (multiprocessing in this example) as the key in the bindings map. Therefore both submodule imports would end up as one entry, with no way to differentiate between them.

When tracking references to imports, we only looked at Name expressions. A compound (attribute) expression such as multiprocessing.process resulted in two attempts to mark names/imports used:
One for multiprocessing and one for process. Marking multiprocessing used together with the issue in 1) meant that all imports of multiprocessing were marked as used.

The solution:

For submodule imports, use the full name as key in the bindings map.

Detect Attribute access (such as foo.bar.baz, but not foo.bar["baz"]) and use that to check if it matches an import. If the visitor is not in such an Attribute in the tree right now, keep looking at Name expressions.
With an attribute access like multiprocessing.pool.ThreadPool, iterate through all parts of it and try to look them up in bindings. This is necessary because certain modules can have different access patterns, e.g.
import os
os.path.exists("foo")

instead of
   import os.path
   os.path.exists("foo")

Closes #60

Awesome! Will review this soon!

@squiddy - Re-reading the summary -- do you want a code review on this, or did you wanna do any cleanup first?

I should have specified that more. I'd really appreciate a code review on the approach itself, the cleanup part is primary about the changes to handle_node_load.

You got it :)

(Overall, what you've written in the summary makes sense. Haven't read the code yet.)

@squiddy - Would you like me to clean up based on the comments and get this merged? Totally up to you.

@squiddy - Would you like me to clean up based on the comments and get this merged? Totally up to you.

I've give it a try, thanks for the review.

Cool, gonna profile this tonight to make sure it's not a significant regression, then we can merge.

Introduces a small slowdown so wanna see if I can optimize this a bit, then will merge.

@charliermarsh I know you're very busy - good evidence to the success of ruff - so I'm not being pushy here.
Can I help you here move this forward? If it's the slowdown that is blocking this, how would I go about that measuring that? Is it just hyperfine + running ruff on the cmdline, or did you do some in-depth profiling?
I'm happy for anything you can share that helps me help you. :)

Thanks for this really kind and understanding message (and not pushy at all). I've been a bad maintainer on this one, asking you to make changes and then failing to follow-up, so I apologize.
I did try to get this across the finish line once or twice but was struggling to eke out any more performance gains and felt mixed about introducing a performance penalty. But the blocker now is that I need to do a fairly substantial rebase due to https://github.com/charliermarsh/ruff/pull/1147 and https://github.com/charliermarsh/ruff/pull/1137. If you're up for trying to handle that, it'd be appreciated. But otherwise, I'll continue to try to get to this when I can.

I'm doing the rebase now and see what else I can do.

Currently experimenting with putting this attribute specific logic after the "simple" name-based lookup, under the assumption that Name are way more common generally than just inside Attribute, e.g. in function calls or variable lookups.
Benchmarks against CPython look promising, but I need to fix one more test. :crossed_fingers:

Closing for now. I haven't made any good progress, might look into that again at some later point.


Wrote some vim stuff

vim is neat

I merged the key value stuff so you can update this to the new API.


embed_doc outputs NaNs

With one of my trained models embed_doc returns bunch of nans (more precisely: -nan -nan -nan ...) for some texts (at least for one) (but not for all texts, so this event is generally rare).
Is this behaviour normal? What reasons could cause it? I'm trying to train on increased dataset now, but I'm not sure, if that will help for any future input.

Uploaded the example to google drive:
(https://drive.google.com/open?id=1Mf6yi1eYYemisRJjZabQySR_ZAcUbEkE)
found_text.txt contains the problematic input for embed_doc.
products_search_categorical and products_search_categorical.tsv are model files. If my checking script was good enough, the .tsv file does not contain nans.

@hakami1024 Thanks for providing the examples. This is a tricky one: I think you turned on -useWeight in your training, where the model assumes that the input comes from the form "word_1:weight_1" where weight1 is numerical. However, in the test example, there's "feature:infant", so the model parses that the word feature has infinite weight ("inf"). To fix this, you can change the ':' in your training examples by some other character ("_" for instance). We'll make the error message more informative and add an option to specify the separator to some other character.


General improvements

Update engines to match with the dependencies.
Update URLs to decrease HTTP redirections.
Prettify some JSON files that had incoherent indentation.
Add missing newlines at EOF of text files.

I find it a bit problematic that the inputHeaders textarea is resizeable while the position of the other elements is fixed.

This is easily fixable by making the textarea not resizeable.

Awesome work - thanks!


add upload form

This adds a form to the CNERG website for others to upload files to us

Looks good too!.


client.getTags() is broken.

client.getTags() returns an empty array and i had to use the following to get the tags.
Replace my-repo-name with your repo name.
const url = new URL('https://my-repo-name.cdn.prismic.io/api/tags');
url.searchParams.set('access_token', client.accessToken);
let test = await client.fetch(url.toString());

Hi @akumanara, apologies on the delay for a response. Thanks for reporting the issue and providing your workaround. It highlighted that the getTags() method was not properly sending the client's accessToken parameter to the Tags API endpoint.
This should be fixed as of #245. The fix is not published yet, but it will be included in the next version.


WW-5042 Upgrade jackson-databind to version 2.10.0

(cherry picked from commit 4556f404bddc99c90f90c359351797f4b54b3917)
@lukaszlenart I guess, this is also needed for the current support branch 2.5.x

Coverage remained the same at 47.057% when pulling 7ffa750c68e5e61af9f91bf523bfcef2bd702b0a on sepe81:update-jackson-to-210 into 313876aa3c2c4a9253e119adc4bd6a1ec6a0aad1 on apache:struts-2-5-x.

LGTM 👍


Added Documentation for Prefix Sum of Array

Have you read the Contributing Guidelines on Pull Requests?
YES.
Description
Added Doc for Prefix Sum Algorithm
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
Fixes #245

Please review , it's been 4 days
@ankitaggarwal23 @iamrajiv @HarshCasper

@vybhav72954  kindly review.

@HarshCasper Kindly review. It's been 9 days :)

@vybhav72954  all changes done. Kindly review.

@vybhav72954  kindly review

@vybhav72954 @iamrajiv kindly add labels.


Add user information to log

Codecov Report

Merging #2405 into dev will increase coverage by 0.08%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #2405      +/-   ##
============================================
+ Coverage     32.81%   32.90%   +0.08%
- Complexity     2268     2277       +9
============================================
  Files           422      423       +1
  Lines         19830    19842      +12
  Branches       2363     2366       +3
============================================
+ Hits           6508     6529      +21
+ Misses        12741    12733       -8
+ Partials        581      580       -1

Impacted Files
Coverage Δ
Complexity Δ

...heduler/api/controller/TaskInstanceController.java
20.00% <0.00%> (-2.23%)
2.00 <0.00> (ø)

...scheduler/api/controller/TaskRecordController.java
12.50% <0.00%> (-1.79%)
2.00 <0.00> (ø)

...lphinscheduler/api/service/AccessTokenService.java
88.13% <0.00%> (-3.10%)
10.00% <0.00%> (ø%)

.../org/apache/dolphinscheduler/api/utils/Result.java
92.85% <0.00%> (-0.48%)
13.00% <0.00%> (+5.00%)
:arrow_down:

.../org/apache/dolphinscheduler/api/enums/Status.java
100.00% <0.00%> (ø)
5.00% <0.00%> (ø%)

...inscheduler/common/task/sqoop/SqoopParameters.java
80.00% <0.00%> (ø)
15.00% <0.00%> (ø%)

...nscheduler/api/exceptions/ApiExceptionHandler.java
75.00% <0.00%> (ø)
3.00% <0.00%> (?%)

...cheduler/api/controller/AccessTokenController.java
8.33% <0.00%> (+3.20%)
2.00% <0.00%> (ø%)

...scheduler/alert/template/AlertTemplateFactory.java
71.42% <0.00%> (+28.57%)
3.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 320469d...8a7991c. Read the comment docs.

please solve Conflicting files locally

please solve Conflicting files locally


Reported line and column numbers are wrong on CRLF (windows) line endings + Ludtwig formats in CRLF

Example Input:
{% block swag_migration_loading_screen %}
    <div class="swag-migration-loading-screen">

        {% block swag_migration_loading_screen_card %}
            <sw-card v-show=!isPaused" class="swag-migration-loading-screen__card">
            </sw-card>
        {% endblock %}

    </div>
{% endblock %}

Make sure to format the file with CRLF line endings.
Ludtwig does report:
Parsing files...

File: "./something.html.twig"
[Error] Parsing goes wrong in line 9 and column 29 :
            <sw-card v-show=!isPaused" class="swag-migration-loading-screen__card">
                            ^
                            |
missing '"' quote

Files scanned: 2, Errors: 1, Warnings: 0
Happy bug fixing ;)

But it should be line 5 column 29

Linux and Mac file endings (LF) and also classic MacOS (CR) seem to work fine.
It looks like each LF (\n) and CR (\r) is counted instead of both together for CRLF.

Also ludtwig currently always prints the files back in CRLF. Ludtwig should adapt to the operating system for this (use LF for linux and macOS and CRLF for windows).

Part of the issue is fixed with #32 but the line reporting is still broken on windows and needs a fix in the parser crate: https://github.com/MalteJanz/ludtwig-parser/issues/2


Improved crash experience for all apps

Proposal: Improved crash experience for UWP apps
Today when an unhandled exception is reached to the UI thread, it hangs for some time and goes away. In desktop apps however, it tells that it's reporting the issue to Microsoft but in UWP apps it does report but without telling the user. Both of these are frustrating and is not a good experience.
Summary
When an exception is thrown and no debugger is there and it doesn't get caught, I simply expect the app window to become invisible and hidden from the taskbar instantly and the report operation + stack unwinding should continue in the background without the user noticing. A notification could be sent that Windows is sending a report instead of a blocking dialogue box.
This will make more sense and make Windows less frustrating to use at times.
Rationale

Make Windows better to use
Less time spent on displaying dialog box allowing the user to do other stuff

Scope

Capability
Priority

This proposal will allow end users to use their PCs without apps hanging because of crash
Must

This may not work well with desktop apps since they create the window on their own with CreateWindow function however since UWP app windows are owned by the system when it detects an unhandled exception, it should just hide the window without terminating the app process

Is it possible for Windows to retrieve the last non-successful HRESULT's message that can be sent as a notification so the user knows what caused the problem. Many apps handle UnhandledException in the App class but often have issues.

Is it possible for Windows to retrieve the last non-successful HRESULT's message that can be sent as a notification so the user knows what caused the problem. Many apps handle UnhandledException in the App class but often have issues.

We log exceptions to the App Center. On UnhandledException we log the exception and and try to pop a ContentDialog to let the user know we are tracking the issue.
The ContentDialog won't always show. Of course if the issue is memory exhaustion or something like that, there is not much can be done. Still it would be nice to have something light-weight that will fly when ContentDialog wont.

We log exceptions to the App Center. On UnhandledException we log the exception and and try to pop a ContentDialog to let the user know we are tracking the issue.
The ContentDialog won't always show. Of course if the issue is memory exhaustion or something like that, there is not much can be done. Still it would be nice to have something light-weight that will fly when ContentDialog wont.

@VagueGit Although a ContentDialog could be useful for some errors, you shouldn't show it for everything. If critical exceptions occur, you should just terminate.

@VagueGit Although a ContentDialog could be useful for some errors, you shouldn't show it for everything. If critical exceptions occur, you should just terminate.

Unfortunately, this isn't an issue that can be addressed in Project Reunion. Not all OS functionality fits the model, and in this case, application crashes are squarely in the domain of the core OS code. I've forwarded this to the appropriate OS team to investigate further.
Thanks,
Ben
For reference of the Windows Development Team, this is OS work item ID: 31335662. Note that the OS work database is not public. The information is included here only for cross-referencing purposes by the OS development team.

Unfortunately, this isn't an issue that can be addressed in Project Reunion. Not all OS functionality fits the model, and in this case, application crashes are squarely in the domain of the core OS code. I've forwarded this to the appropriate OS team to investigate further.
Thanks,
Ben
For reference of the Windows Development Team, this is OS work item ID: 31335662. Note that the OS work database is not public. The information is included here only for cross-referencing purposes by the OS development team.

Many services today exist for crash reporting however they can't send exception that can't be easily caught. It would be nice if Windows could send the crash report to a custom server specified in the manifest


[SPARK-40162][BUILD] Upgrade RoaringBitmap from 0.9.30 to 0.9.31

What changes were proposed in this pull request?
This pr aims upgrade RoaringBitmap from 0.9.30 to 0.9.31.
Why are the changes needed?
This version contain bug fix: simplify BatchIterators, fix bug in advanceIfNeeded
The changes between 0.9.30 and 0.9.31 as follows:
https://github.com/RoaringBitmap/RoaringBitmap/compare/0.9.30...0.9.31
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.

I will run MapStatusesSerDeserBenchmark like https://github.com/apache/spark/pull/36719

Merged to master


Bug in "Share and Get rewarded" modal on solana

1-
-user is signed out
-Tap on "share and get rewarded" button
-Tap on "connect wallet"
https://github.com/Giveth/impact-graph/assets/111529185/a6cb4f4f-fdcd-4c4a-ab55-85c79ebb10b5
2-
-Connect wallet is done from user menu
-Tap on "share and get rewarded" button
-Tap on "sign in"

an empty modal is shown

https://github.com/Giveth/impact-graph/assets/111529185/693bbd4c-cff7-4803-8e85-899e35fb0858

After a call we had, we decided to let the user switch network to use referral feature as the chain-vine is not evm compatible.
The copy for these views:
Currently this feature is only available on EVM chains.  Switch Network
Thanks @alireza-sharifpour
FYI @maryjaf

Yeah definitely, Solana is not supported by them. So I'm sure their api will not work. As we would probably need to ask them to add the integration too. I will double check tomorrow the exact error, but it's my guess looking and the code and how it works.

@alireza-sharifpour @aminlatifi
Would you pls help me finalize the attached pr, I guess review is still pending

Thanks @alireza
This issue has been fixed


on French espaces insécables

@ajaniak: When typing French (in translations, in quotes), is it recommended to explicitly type espaces insécables where they are expected in French typography, or is it better not to type them and to let our system insert them where they are wanted (as long as @xml:lang is duly encoded)?
Example: which of the following versions should I retain, version 1 (with spaces before : and ?) or version 2 (without)?

<note>Bergaigne adds to his reading the note: <q xml:lang="fra">Pour <foreign>guptau</foreign> ? Le contexte suggérerait plutôt <foreign>gatau</foreign> : mais cette correction serait trop éloignée du texte</q>.</note>
<note>Bergaigne adds to his reading the note: <q xml:lang="fra">Pour <foreign>guptau</foreign>? Le contexte suggérerait plutôt <foreign>gatau</foreign>: mais cette correction serait trop éloignée du texte</q>.</note>

@danbalogh: should the EGD contain any guidance on this question?

@ajaniak : would it be possible to make the display transformation insensitive to whether or not they are present, so that both Arlo's version 1 and 2 display as expected?
Whether it's possible or not, and whatever you decide on, I'll find a place to add a note on this to the EGD, though we don't really have a suitable section. Perhaps a new appendix on style issues in modern languages? That could also be the place to put some other items that I've been reluctant to add on the grounds that they concern style, not encoding.

Can we come to a conclusion on this point? I would like to know how I should tell my team members to encode.

I haven't answer this issue yet because I am trying to find a stable solution.
Indeed, I am reluctant to add such feature to the HTML XSLT because I had to force several hierarchy levels already making it a little unstable. So I am exploring several possibilities : a pipeline to add a step to handle editorial features before the html or an automated launching to clean the content of the French parts linked to the repositories. I will try to have a more advanced answer for the brainstorming.

Pipeline for editorialisation setup by Axelle Janiak, following DHARMA brainstorming (2021/12/17).

Pipeline for editorialisation setup by Axelle Janiak, following DHARMA brainstorming (2021/12/17).


IDENTITY-7141 Allowing spaces for Home Realm identifier resulted in a failure for IDP redirection

Moved from https://wso2.org/jira/browse/IDENTITY-7141
Steps to recreate the issue

Create Facebook as IDP by adding a value that contains a space as the Home Realm identifier
ex: "test 123"

Create Travelocity as SP and add the facebook as outbound authenticator

Configure the fidp value in the travelocity application.
QueryParams=fidp=test 123

Access travelocity application with SAML

Observations
Allowed to provide a value to Home Realm Identifier with spaces in it
Authentication redirection failed without any error message
Expected Results

If Home Realm Identifier should not contain spaces it should be applied as a validation when creating or editing the IDP
If not (Home Realm can contain spaces) travelocity login should direct to Facebook authentication

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Add when_any() for waiting for at least one task to complete

The difficult part of designing when_any() will be how to handle cancellation of the co_await operations of the other tasks.
Currently, the task, lazy_task, shared_task and shared_lazy_task types don't allow the caller to cancel the co_await operation once it has been awaited. We need to wait for the task to complete before the awaiting coroutine returns.
If the tasks themselves are cancellable, we could hook something up using cancellation_tokens.
eg. If we pass the same cancellation_token into each task then concurrently await all of the tasks and when any task completes, we then call request_cancellation() on the cancellation_source to request the other tasks to cancel promptly. Then we could just use when_all() to wait for all of the tasks.
To do this more generally, we'd need to be able to cancel the await operation on a task without necessarily cancelling the task itself. This would require a different data-structure in the promise object for keeping track of awaiters to allow unsubscribing an awaiter from that list in a lock-free way.
Maybe consider a similar data-structure to that used by cancellation_registration?

A somewhat cumbersome way of implementing the when_any() pattern such that the first operation to complete is a "winner" and the others are "losers" and should be cancelled:
lazy_task<> alternative1(cancellation_token ct);
lazy_task<> alternative2(cancellation_token ct);

lazy_task<> cancel_on_success(lazy_task<> task, cancellation_source cs)
{
  co_await task;
  cs.request_cancellation();
}

lazy_task<> do_1_or_2(cancellation_token ct)
{
  cancellation_source source;
  cancellation_registration cancellationForwarder{ ct, [&source] { source.request_cancellation(); } };
  co_await when_all(
    cancel_on_success(alternative1(source.token()), source),
    cancel_on_success(alternative2(source.token()), source));
}

This will cancel both sub-tasks if the cancellation_token passed in has cancellation requested.
When either sub-task completes successfully (ie. without throwing an exception) then it will request cancellation of the other task.

The other main use-case of when_any() is to act as an event loop, allowing code to handle completion of a number of concurrently executing tasks serially in the order they complete in.
eg. Something like this (not thoroughly thought out)
task<std::string> get_record(int id);

task<> example()
{
  std::vector<task<std::string>> tasks;
  for (int i = 0; i < 100; ++i) tasks.push_back(get_record(i));

  while (!tasks.empty())
  {
    std::size_t readyIndex = co_await when_any(tasks);
    std::cout << co_await tasks[readyIndex] << std::endl;
    tasks.erase(tasks.begin() + readyIndex);
  }
}

However, I feel that something like this could be handled just as well using (and possibly more efficiently) using when_all to execute them concurrently and async_mutex to serialise processing of each individual event.
eg.
task<std::string> get_record(int id);

task<> example()
{
  async_mutex mutex;

  auto handleRecord = [&](int id) -> task<>
  {
    auto& result = co_await get_record(id);
    {
      auto lock = co_await mutex.scoped_lock_async();
      std::cout << result << std::endl;
    }
  };

  std::vector<task<>> tasks;
  for (int i = 0; i < 100; ++i) tasks.push_back(handleRecord(i));
  co_await when_all(std::move(tasks));
}


Write Haplopainter input file independently of chosen pedigree plotting method

An input file for Haplopainter pedigree plotting software can be written by FamAgg only if the plotting method is set to haplopaint via a call to switchPlotFun. When this call is done, the package checks if Haplopainter is installed by trying to run a simple pedigree rendering. If this fails, FamAgg falls back to kinship2-based plotting. This way an input file for later Haplopainter invocation can never be written.
This scenario may happen (and has already happened to the unfortunate issue submitter) on a server installation where Haplopainter was not installed, but the FamAgg user wants to draw pedigrees on another machine where that software is installed, for example when preparing publication figures.

I guess a simple helper function a la writeHaplopainterFile should suffice? The unfortunate user (😄 ) could then invoke this function directly.

Unfortunately, things are not that straight forward. The option to write a haplopainter output file is passed to plotting-functions.R::haplopaint (called via plotting-functions.R::doPlotPed), which first generates a suitable data frame and then sees whether to render the pedigree or output the text file. Things are a bit nested here. I will see if this can be deconvoluted.


Libtorch AlphaZero at Test-Time

Quick, and possibly silly, question regarding libtorch AZ at test-time (as in alpha_zero_torch_game_example).
alpha_zero_torch_game_example is running AZ as an MCTSBot with AZ's value network -- i.e. it inits an MCTSBot with the VPNetEvaluator instead of the standard evaluator. So it seems that (i) AZ is forced to use mcts at test-time (which requires at least max_simulations=2) and (ii) AZ uses the same number of mcts simulations (max_simulations) as its opponent.
Getting around number (ii) is pretty straightforward --> adding another flag separating, say, max_az_simulations from max_opponent_simulations, but I'm not quite sure about (i). So far, I've just been running AZ with max_simulations=2, but I'm not sure if this is equivalent to not using mcts at all. But I can confirm that changing max_simulations at test-time changes AZ's performance (especially from an early checkpoint where AZ is playing sub-optimally).
Any feedback/insight would be much appreciated!

Hi @ngrupen, I might be missing something -- what's the alternative.. sampling from the prior? Minimax? What would you like to do that's different from MCTS at test time?

Hmm my thought was to evaluate performance as a function of “thinking time” — by degrading max_sims until there is virtually no look-ahead, but I’m realizing that might be misguided.

No that makes perfect sense. I guess you're saying it can't go any less than 2? What does less than 2 simulations even mean? 1 simulation should be essentially sampling from the prior (since there's nothing else to compare to), e.g. no search at all. 2 simulations should still at least compare two different options and choose the best one?
Maybe you're saying the code does not support the case of max_sims=1 ? We can probably fix that, if so. Can you elaborate on what breaks when you try max_sims=1?

Yes, I guess this question comes down to sampling from the prior :) Playing with max_sims = 1 returns:
Spiel Fatal Error: .../mcts.cc:222 root->children.size() > 0
root->children.size() = 0, 0 = 0

which is also the behavior of trying to play with max_sims = 0 (and this error makes sense, since it is basically not a search anymore, as we discussed). For now, I am happy to proceed with max_sims=2, unless you think there would be enough other people interested in sampling from the prior to warrant changing this behavior.

We should be supporting that case, we've used it several times in the past, and it's come in handy.
I went through the MCTS code and I think I understand why it's happening: because the root does not even add a child on the first simulation (it only gets expanded). Also it seems to me that we're not even sampling from the prior at any point, but rather always using the PUCT values. This seems like a (minor) bug: the first time we encounter a new node, the action should be sampled from the prior.
I'm off until early January, so I encourage you to fix this (and submit a PR). Here's how I suggest doing it: write a function called SampleFromPrior which does exactly that (from the node object, once it's initialized). Then, instead of the of having that check on line 222, check if max_simulations is 1. If so, return root.SampleFromPrior(). If not, continue with the rest of the function. Then, the bug fix: in ApplyTreePolicy we should use SampleFromPrior to get an action when children.size() == 0, rather than maximizing over PUCT values.
If you don't do it, I'll try to do it at some point when I'm back. If you only want to add the support for max_sims=1 but not fix that bug, that'd be great too, I can easily fix that afterward.

@lanctot Thank you for the detailed description of this fix! I took a little time off as well since we last spoke, but I am back on this -- just wanted to keep you in the loop so that we aren't double fixing :)
I've implemented SampleFromPrior() and will tackle the bug fix next. Will let you know when the PR is ready.

Sounds good, thanks for the heads up because I was going to look into it soon. But I have other stuff to do as well, so will do those first. Still happy to help if you hit any snags and can imporr it whenever it is ready.

One quick question: should max_simulations=0 be handled in the same way as max_simulations=1? After SampleFromPrior() and the bug fix, max_simulations=1 samples from the evaluator as expected, but now max_simulations=0 seg faults because there is no check on line 222 anymore.
Changing the if statement to be an or over both 0 and 1 seems to fix it, but I'm not sure if there are unintended consequences of that that I am missing.

Yeah I think max_simulations as 0 or 1 can be handled in the same way (where 0 is just a special case for convenience). That sounds fine to me. I will take a deeper look when I see the code, so I encourage you to submit the PR and we can iterate on it if necessary. Thanks for doing this!

@lanctot Just submitted PR #760 with proposed fix. Let me know what you think!


AzureStorage liveness

Hi folks,
I've added new liveness to BeatPulse to support AzureStorage services like Blobs, Tables and Queues.
I hope they will be useful.
Regards!

Thanks @lurumad, merged!


Scalar store

Why not use SQLAlchemy, which can help us support multiple databases.

Great, I'll learn more about this and then support it. Additionally, if you have some free time, you're welcome to contribute to the PR as well.

finished with #46


Separate search json and JS in separate files

Search json can be put in a separate file and loaded asynchronously. This will reduce search page size and loading time.
I had it working on my site here : https://github.com/mathieubrun/mathieubrun.github.io
I can make a PR if requested !

Yeah, it was like that at first the only issue is that as a gem the search feature does not work. So I put everything in one file as a workaround.
If you can make it work on a separate file while being on a gem, I would be good with it. 👍

I'll have a look if I can make it working then !

PR here https://github.com/Sylhare/Type-on-Strap/pull/78

Thanks! I have merged it 😉


Make sure you see Simulate poor internet connection toggle.
Turn it on and see that the connection randomly changes from online to offline.
Turn it off, see that random connection changes are stopped.

Offline tests

N/A
QA Steps

[x] Verify that no errors appear in the JS console

Same, as in the Tests section.
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message: https://expensify.slack.com/archives/C01GTK53T8Q/p1733729348546269

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/3fb8372e-d144-4f1e-8ffc-bf2434866ce4

Android: mWeb Chrome

https://github.com/user-attachments/assets/ebd02b97-6a56-4856-9957-68506e5dc7d8

iOS: Native

https://github.com/user-attachments/assets/c143d564-726b-44e5-a902-58521656c6cc

iOS: mWeb Safari

https://github.com/user-attachments/assets/95ce9edb-1c8d-414e-89cd-89b43d7b56be

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/80b9ad19-23b2-4da4-a778-533e69725c87

MacOS: Desktop

https://github.com/user-attachments/assets/7c75544c-e15e-47ad-81a1-579183912fd3

@hoangzinh Please, take another look!

@hoangzinh Here it is:
https://github.com/user-attachments/assets/cbbb30ab-e09e-46de-aeff-b5dd1e13b782
The only thing I've noticed is that the modal is full-screened there, but I've checked and it's the same on main.

@hoangzinh done!

@tgolen, I see you were involved in the issue. Would you mind reviewing this, please? 🙏

Sure, no problem. I'll unassign you and review this.

Thank you!
On Fri, Dec 13, 2024 at 12:31 PM Tim Golen @.***> wrote:

Sure, no problem. I'll unassign you and review this.
—
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/pull/53698#issuecomment-2541818701, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7Y2OK3H3BMGHA6QDVR6I32FMDVVAVCNFSM6AAAAABTEQKKVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBRHAYTQNZQGE
.
You are receiving this because your review was requested.Message ID:
@.***>

There were some issues with tests implementation, so I had time to implement only basic ones today:
https://github.com/Expensify/App/pull/53698/commits/53b39c58dca9e3d47fa683945b68ce8001802810 .
I can try to cover more cases tomorrow, let me know what you think @tgolen

@tgolen Done - https://github.com/Expensify/App/pull/53698/commits/ba653602c4557cdffa98d987c13a8da36e308467

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.