Update ngx_rtmp.c

Hello!
As I think, currently all the postconfiguration handlers are called with a wrong context assigned to cf->ctx.
IMHO, they shall be called with the rtmp block's context (as preconfiguration handlers are), but indeed they are called with the context of the very last server block observed in the rtmp configuration. This happens due to context switching performed in the line 254: "cf->ctx = cscfp[s]->ctx;" -- which is not undone after the work is completed prior to enter the postconfiguration cycle.
Fortunately all the modules in the rtmp suite did not faced this fact yet as soon as both the rtmp block's context and all the server blocks' contexts have exactly the same main_conf part, while neither srv_conf nor app_conf parts are actually used by existing postconfiguration handlers.
I propose to change this behavior and pass the rtmp block's context. To do this it's enough to add just one line of code.
I'm not 100% sure if my understanding is correct. So, please, verify my proposal.
Thank you!

Alex

No, the code is not wrong, but your patch won't be wrong either. Because the pointer cf->ctx points to the main_conf context and there is ONLY one main_conf in the different levels configuration context. When the symbol "rtmp" is met, an object with the type ngx_rtmp_conf_ctx_t will be allocated, and in turn the context of main_conf, srv_conf and app_conf in the object will be allocated. When the symbol "server" in the "rtmp" block is met, another object with the type ngx_rtmp_conf_ctx_t will be allocated, but this time, the context of main_conf will NOT be allocated, only srv_conf and app_conf do. Why? Because the context of main_conf in the server level points back to the context of main_conf in the main level(or rtmp level). The processing of app level is the same, in addition, the context of srv_conf points back to the context of srv_conf in the server level. The whole context is as follows:
+->|  main_conf   | srv_conf | app_conf | <-- rtmp
|
+---|  main_conf  | srv_conf | app_conf | <-- server
|                                /|
|                                 |
+---|  main_conf  | srv_conf | app_conf | <-- app
So, no matter what cscfp[s]->ctx points, the macro:
#define ngx_rtmp_conf_get_module_main_conf(cf, module)
((ngx_rtmp_conf_ctx_t *) cf->ctx)->main_conf[module.ctx_index]
in the postconfiguration functions will always get the same context of main_conf in the rtmp level.

No, the code is not wrong, but your patch won't be wrong either. Because the pointer cf->ctx points to the main_conf context and there is ONLY one main_conf in the different levels configuration context. When the symbol "rtmp" is met, an object with the type ngx_rtmp_conf_ctx_t will be allocated, and in turn the context of main_conf, srv_conf and app_conf in the object will be allocated. When the symbol "server" in the "rtmp" block is met, another object with the type ngx_rtmp_conf_ctx_t will be allocated, but this time, the context of main_conf will NOT be allocated, only srv_conf and app_conf do. Why? Because the context of main_conf in the server level points back to the context of main_conf in the main level(or rtmp level). The processing of app level is the same, in addition, the context of srv_conf points back to the context of srv_conf in the server level. The whole context is as follows:
+->| main_conf | srv_conf | app_conf | <-- rtmp
|
|
+---| main_conf | srv_conf | app_conf | <-- server
|+-------------------------^
| |
|+------------------------+
+---| main_conf | srv_conf | app_conf | <-- app
So, no matter what cscfp[s]->ctx points, the macro:
#define ngx_rtmp_conf_get_module_main_conf(cf, module)
((ngx_rtmp_conf_ctx_t *) cf->ctx)->main_conf[module.ctx_index]
in the postconfiguration functions will always get the same context of main_conf in the rtmp level.

Sorry, I think I misunderstood what you meant.
You meant that some postconfiguration handlers may not be called in the srv_conf part and the app_conf part, right?
I checked the project, no postconfiguration handler used the srv_conf and app_conf part, neither the srv_conf and loc_conf in the original nginx code, they has used only the main_conf part, but you're right, indeed a context restore was missed, and that may lead to a potential bug. Good job!

Hello, Winshining!

I don't claim either my point is correct or not. -- I claim only that all POSTconfiguration handlers are called with the context of the last defined 'server' block in the nginx.conf file, while all the PREconfiguration handlers are called with the context of the 'rtmp' block. And this is true 100% - I have checked carefully under debug. And my exact point is that, at least: (1) it's not intuitively clear when symmetric things - pre and post - are called in so different ways, and (2) postconfiguration should not depend on the order in which 'server' blocks are given in the configuration file and which one is the very last of them, and (3) the srv_conf and app_conf of the 'rtmp' block becomes inaccessible at the postconfiguration if the server's context is passed (there is no back-link to the rtmp's context from the server's context or an app's context). That's the reason of my comment. Just dry facts.

"I checked the project, no postconfiguration handler used the srv_conf and app_conf part"
<< Right. That's what I said under "Fortunately ... neither srv_conf nor app_conf parts are actually used ..."
However, today I have designed (it's true!) my own module that does use app_conf part of the 'rtmp' block. And my module needs it namely in the postconfiguration phase. I use app_conf to bind some ancillary data structures allocated at the postconfiguration phase. And among them there are N instances for applications and one specialized 'master' instance of the same kind which I decided to bind to the app_conf of the 'rtmp' block just for uniformity. I was surprised that my postconfiguration was called for the server's app_conf instead of the rtmp's app_conf. So, I'm the first lucker who stepped on these rake :)

"So, no matter what cscfp[s]->ctx points, the macro: ... in the postconfiguration functions will always get the same context of main_conf in the rtmp level."
<< Yes. But srv_conf and app_conf will be different. For example, the 'live' directive -- its value is saved in the app_conf. If it is defined in the 'rtmp' block directly, its value is saved in the rtmp's app_conf object (and then implicitly adopted by all the servers and apps as the default). What if I need, for some reason, to check the value of this directive as it was defined namely in the 'rtmp' block (maybe for some error logging or anything else), and what if I need it namely during the postconfiguration. It's just a simplified example, maybe not perfect, but nevertheless.

Anyway. Thank you for your response!
And let's do this project better!

Alex

Hi Alex!
In fact, you're right!  Looking forward to your module!


blockscout integration

fix #45

Have you been able to run the explorer and check that everything is functional?
I was able to run it during the hackathon and get to the page but it didn't really work (it was just syncing... I think?).
At minimum we should be able to see the system transactions for every block!

have you checkout this PR to try.

Have you been able to run the explorer and check that everything is functional?
I was able to run it during the hackathon and get to the page but it didn't really work (it was just syncing... I think?).
At minimum we should be able to see the system transactions for every block!

changed frontend image back, it seems there is a new image published by blockscout.
./rollop setup --yes
./rollop --clean devnet --explorer

open localhost:80 should works.

have you checkout this PR to try.

No, I was just reviewing very quickly, but I'll definitely try it out later. Just wanted to confirm :)

have you checkout this PR to try.

No, I was just reviewing very quickly, but I'll definitely try it out later. Just wanted to confirm :)

I tested several times with the last two commit image tags, it could shows blocks and transactions which i assume it works basiclly

Hey, I'm sorry, sort of lost track of this.
I'm trying it right now and it does not seem to work for me. I can access blockscout, but it keeps saying " 0% Blocks Indexed - We're indexing this chain right now. Some of the counts may be inaccurate." in a banner at the top, which is what it was doing before as well. This persists even if letting it run for 10+ minutes, and this is of course a chain that has been created merely a few seconds before blockscout is launched.
The blockscout launch seems to be reporting a lot of errors, though I'm not sure what they indicate:
blockscout               | ** (ArgumentError) Could not convert receipt to elixir
blockscout               |
blockscout               | Receipt:
blockscout               |   %{"blockHash" => "0xf6fa36eed182319d352c3551a432a72c175c07b03296b5d0b4c5c48c11b3f9c6", "blockNumber" => "0x2a", "contractAddress" => nil, "cumulativeGasUsed" => "0xcce5", "depositNonce" => "0x29", "effectiveGasPrice" => "0x0", "from" => "0xdeaddeaddeaddeaddeaddeaddeaddeaddead0001", "gas" => 1000000, "gasUsed" => "0xcce5", "logs" => [], "logsBloom" => "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", "status" => "0x1", "to" => "0x4200000000000000000000000000000000000015", "transactionHash" => "0x78f80e3f408a20cd4c3794cd3dcdda5d43fb83fd42d3ab89876e1a9fce7dd4cd", "transactionIndex" => "0x0", "type" => "0x7e"}
blockscout               |
blockscout               | Errors:
blockscout               |   {:unknown_key, %{key: "depositNonce", value: "0x29"}}
blockscout               |
blockscout               |     (ethereum_jsonrpc 5.1.0) lib/ethereum_jsonrpc/receipt.ex:236: EthereumJSONRPC.Receipt.ok!/2
blockscout               |     (elixir 1.13.1) lib/enum.ex:1593: Enum."-map/2-lists^map/1-0-"/2
blockscout               |     (ethereum_jsonrpc 5.1.0) lib/ethereum_jsonrpc/receipts.ex:138: EthereumJSONRPC.Receipts.fetch/2
blockscout               |     (elixir 1.13.1) lib/task/supervised.ex:89: Task.Supervised.invoke_mfa/2
blockscout               |     (elixir 1.13.1) lib/task/supervised.ex:34: Task.Supervised.reply/4
blockscout               |     (stdlib 3.17) proc_lib.erl:226: :proc_lib.init_p_do_apply/3

What I did was pull this branch then:
./rollop setup
./rollop --clean devnet --explorer

Did you use a different procedure?

Hey, I'm sorry, sort of lost track of this.
I'm trying it right now and it does not seem to work for me. I can access blockscout, but it keeps saying " 0% Blocks Indexed - We're indexing this chain right now. Some of the counts may be inaccurate." in a banner at the top, which is what it was doing before as well. This persists even if letting it run for 10+ minutes, and this is of course a chain that has been created merely a few seconds before blockscout is launched.
The blockscout launch seems to be reporting a lot of errors, though I'm not sure what they indicate:
blockscout               | ** (ArgumentError) Could not convert receipt to elixir
blockscout               |
blockscout               | Receipt:
blockscout               |   %{"blockHash" => "0xf6fa36eed182319d352c3551a432a72c175c07b03296b5d0b4c5c48c11b3f9c6", "blockNumber" => "0x2a", "contractAddress" => nil, "cumulativeGasUsed" => "0xcce5", "depositNonce" => "0x29", "effectiveGasPrice" => "0x0", "from" => "0xdeaddeaddeaddeaddeaddeaddeaddeaddead0001", "gas" => 1000000, "gasUsed" => "0xcce5", "logs" => [], "logsBloom" => "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", "status" => "0x1", "to" => "0x4200000000000000000000000000000000000015", "transactionHash" => "0x78f80e3f408a20cd4c3794cd3dcdda5d43fb83fd42d3ab89876e1a9fce7dd4cd", "transactionIndex" => "0x0", "type" => "0x7e"}
blockscout               |
blockscout               | Errors:
blockscout               |   {:unknown_key, %{key: "depositNonce", value: "0x29"}}
blockscout               |
blockscout               |     (ethereum_jsonrpc 5.1.0) lib/ethereum_jsonrpc/receipt.ex:236: EthereumJSONRPC.Receipt.ok!/2
blockscout               |     (elixir 1.13.1) lib/enum.ex:1593: Enum."-map/2-lists^map/1-0-"/2
blockscout               |     (ethereum_jsonrpc 5.1.0) lib/ethereum_jsonrpc/receipts.ex:138: EthereumJSONRPC.Receipts.fetch/2
blockscout               |     (elixir 1.13.1) lib/task/supervised.ex:89: Task.Supervised.invoke_mfa/2
blockscout               |     (elixir 1.13.1) lib/task/supervised.ex:34: Task.Supervised.reply/4
blockscout               |     (stdlib 3.17) proc_lib.erl:226: :proc_lib.init_p_do_apply/3

What I did was pull this branch then:
./rollop setup
./rollop --clean devnet --explorer

Did you use a different procedure?

Did you remove the previous blockscout repo manually?

So I retried after delete the directory, but I'm running into mac-specific issues. If trying with the exact code, it complains that it can find the image, but it is linux/amd64 instead of the requested linux/arm64 — it's indeed what can be found here.
If I remove the modification and try to pull the linux/amd64 image (trying to make it work via emulation) then blockscout crashes on startup.
This appears multiple times, that might be the issue (and not mac specific):
db                              | 2023-11-11 19:00:58.259 UTC [234] FATAL:  password authentication failed for user "postgres"
db                              | 2023-11-11 19:00:58.259 UTC [234] DETAIL:  Role "postgres" does not exist.
db                              | 	Connection matched pg_hba.conf line 100: "host all all all scram-sha-256"

But it's annoying given that postgres is launched in Docker as well (as explained here).
Re-running, I get other db issues, but no longer the password ones.
The problem, however, is that the backend is crashing with init terminating in do_boot.
Next thing: I tried 5.3.0-postrelease-b6136977
This fails because there are too many connections to postgres (both on the arm64 and amd64 variants):
backend                         | 2023-11-11T20:58:22.579 application=db_connection [error] Postgrex.Protocol (#PID<0.4401.0>) failed to connect: ** (Postgrex.Error) FATAL 53300 (too_many_connections) sorry, too many clients already

Next step, I'm removing DOCKER_TAG=1.55 FRONTEND_DOCKER_TAG=1.55. But this causes it to download a bunch of things and my connection is super slow right now. Will continue to look into this later.

So I retried after delete the directory, but I'm running into mac-specific issues. If trying with the exact code, it complains that it can find the image, but it is linux/amd64 instead of the requested linux/arm64 — it's indeed what can be found here.
If I remove the modification and try to pull the linux/amd64 image (trying to make it work via emulation) then blockscout crashes on startup.
This appears multiple times, that might be the issue (and not mac specific):
db                              | 2023-11-11 19:00:58.259 UTC [234] FATAL:  password authentication failed for user "postgres"
db                              | 2023-11-11 19:00:58.259 UTC [234] DETAIL:  Role "postgres" does not exist.
db                              | 	Connection matched pg_hba.conf line 100: "host all all all scram-sha-256"

But it's annoying given that postgres is launched in Docker as well (as explained here).
Re-running, I get other db issues, but no longer the password ones.
The problem, however, is that the backend is crashing with init terminating in do_boot.
Next thing: I tried 5.3.0-postrelease-b6136977
This fails because there are too many connections to postgres (both on the arm64 and amd64 variants):
backend                         | 2023-11-11T20:58:22.579 application=db_connection [error] Postgrex.Protocol (#PID<0.4401.0>) failed to connect: ** (Postgrex.Error) FATAL 53300 (too_many_connections) sorry, too many clients already

Next step, I'm removing DOCKER_TAG=1.55 FRONTEND_DOCKER_TAG=1.55. But this causes it to download a bunch of things and my connection is super slow right now. Will continue to look into this later.
EDIT: finished downloading, still experiencing the same error

I don't have an mac with arm, let me ask others to try it.

Now works. The indexing % is wonky, only goes down, but restarting the explorer (by running it separately via ./rollop explorer, quitting and restarting) seems to bump it 100%, then it drops again.
We need to try this on Linux and see how it works there.

I also ended up updating optimism to 1.3.1 and op-geth (which I forgot in the update to 1.3.0, though somehow that didn't change anything??).
Also I fixed quite a few misc issues, the most annoying being that the most recent version of foundry causes the deploy script to fail. We now install a local known version of foundry to avoid this.


Add an option to pass the model name as string

The current SparkAI init method receives a BaseLanguageModel object and then creates a ChatOpenAI as the default.
I suggested adding an additional string type parameter to the init method (say model_name) and then create ChatOpenAI object with that model.
This will make it more streamlined to try out different open AI models and compare them.
It also removes the need for the additional important from langchain.
I ca  create a PR if that sounds helpful

Hi @BelgiAmir ,
It's already there. You can pass in the llm parameter while calling SparkAI.
spark_ai = SparkAI(llm=ChatOpenAI(model_name='gpt-3.5-turbo', temperature=0))
Thanks


Create an alerts_dashboard view for visualizing change detection alerts

Now that we have change detection alerts flowing into partner data warehouses, let's create a bespoke dashboard view that visualizes change detection alerts on contextual maps (with useful data such as historical change detection, concessions data, and more) and provides links to download map resources (generated by GCCD) for each alert.

Features for an MVP:

[ ] Differentiate latest import batch of alerts in a different color from the rest
[ ] Legend with an option to toggle layers on/off
[ ] Alerts are clickable and properties plus links (to preview HTML maps, Mapeo map package downloads) are shown in a sidebar
[ ] Stretch goal: date range filter to allow the user to filter the alerts

Future:

[ ] Ability to batch download all alerts as GeoJSON
[ ] Ability to batch download a selection of alerts (i.e. what is shown on the screen after filtering has been applied)
[ ] Ability to mark alerts as having been verified (e.g. ground truthed, inspected, or socialized within the community) and show a visual cue somewhere on the dashboard.


add NotImplementedError when filter_pattern is given to filter_log_events

fix #2419

Coverage decreased (-0.2%) to 93.369% when pulling 37877c6fb2f7a5135183ae308815e50129d42fb5 on edekadigital:filter_logs_raises_if_filter_pattern into 36a8a4ad00a6983ec6afc8bb6f77afa2a035389b on spulec:master.

Thanks for opening!
It looks like the tests aren't passing in server-mode. The easiest solution for now is probably to put your new tests behind an if statement and exclude it from the server tests. Something like this.

@SelenaHaettasch nice work! Thanks for getting the tests passing. Your contribution here will help anyone in the world who's trying to test their log-filtering code. This is really helpful!

Oh, and congrats on your first contribution. Welcome to Moto! 😃


amenity=clock

What's your idea for a cool feature that would help you use OHM better.
display an icon of some sort for amenity=clock
just added Clock of the World to the Disneyland map and the name displays but there is no icon on the actual spot.
https://openhistoricalmap.org/#map=20/33.81206/-117.91815&layers=O&date=1962-08-03&daterange=1922-01-01,2022-12-31

This is now in staging:


PolynomialTensor dictionary should be accessed through methods

When I was rewriting PolynomialTensor, I forgot to make it so that the attributes one_body_tensor and two_body_tensor of InteractionOperator are updated after a call to rotate_basis. After thinking a little about the best way to fix this, I concluded that one_body_tensor should actually be a method, rather than an attribute. More generally, for any subclass of PolynomialTensor, information tied to the dictionary n_body_tensors should be  retrieved using methods. That way any functions that manipulate PolynomialTensor objects don't need to worry about updating related attributes in subclasses.
What do people think of this? I probably should have made an issue first, but it didn't take long to just implement the change. The one thing I wasn't sure about was whether the method should return a copy or not; for now I made it return a copy because it seems less likely to cause bugs.

On second thought, perhaps this change is not necessary, because the one_body_tensor attribute is actually a view into the numpy array stored in the n_body_tensors dictionary? It might still be a good change though.

I'm not sure I fully understand the motivation behind the change.  We should avoid redundancy in data storage where possible, so if it's being updated somewhere and we are passing references to it that should be fine?  If we want to update it only when the element is accessed, then we should use getters and setters as in molecular_data, so that it acts like an attribute but has the flexibility of a function.

My main motivation was that I thought the one_body_tensor attribute needed to be updated, but I was mistaken because I hadn't realized it was really a view (reference). So actually, I'm thinking most of this PR might not be needed after all. However, the constant attribute is not a view, so do you think that should be a method of PolynomialTensor? I'm imagining a scenario where a function changes the value of n_body_tensors[()] without updating the corresponding constant attribute. But maybe I'm overthinking things.

I'm still not sure why it being a method makes a difference.  You are always free to have the object modify it's own internal components, including the constant, and components of the dictionary.  Not having a view doesn't really matter, as it just rebinds the variable and will still return the correct value when checked?  Loading the attribute from the class that has been updated should still work.
Maybe I'm missing a use case you have personally, where you load the value of the tensor somewhere else, and want changing the object to change a pointer to it elsewhere?

 I think I understand now.  I would use the getter and setters via decorators we use in molecular data for this, that will let it behave like an attribute but access the dictionary to get the updated value every time it is accessed.

Ah, that is a neat solution I wasn't aware of. I think this PR can be dismissed; I might submit another related one in the future using the decorators. Thanks!


aarch64 binary?

Hi, any chance of providing an aarch64 binary for Linux in the build actions? Cargo's taking quite a while to build on Raspberry Pi. Thank you!

Thanks for your report. I do not very familiar with the action of arch, I will be glad that if you can make a pr for me

Ah ok. I actually have no idea either, but I'll give it a shot. Thank you!

https://github.blog/changelog/2024-06-03-actions-arm-based-linux-and-windows-runners-are-now-in-public-beta/

Arm runners are available to customers on our Team and Enterprise Cloud plans. We expect to begin offering Arm runners for open source and personal accounts by the end of the year.

Maybe we can try cross compile? I saw texlab compiles from aarch64 to x86-64.

Thanks, that's helpful to know! I was just checking out the docs for distributed compilation with sccache, which seems like a good option. I'll give it a shot.

https://github.com/neocmakelsp/neocmakelsp/actions/runs/11571163835?pr=128 @eeeXun , can you try the target here? To check if it will works on your platform

solved by https://github.com/neocmakelsp/neocmakelsp/pull/128, you take a try for the built target

https://github.com/neocmakelsp/neocmakelsp/actions/runs/11571163835?pr=128 @eeeXun , can you try the target here? To check if it will works on your platform

Sorry, I don't have any arm64 computer for testing. @sadguitarius, can you try it?

Just tried and it works perfectly! Thanks so much

ok, done


Fix verify doc

The docs don't interperet ``` properly without a newline before

Coverage remained the same at 81.049% when pulling db95f62f7da4fe35d4edb1fc9d4840c574e81340 on derekdreery:patch-2 into da873207a75306069b17c144c9fa68d20d586935 on Geal:master.

Coverage remained the same at 81.049% when pulling db95f62f7da4fe35d4edb1fc9d4840c574e81340 on derekdreery:patch-2 into da873207a75306069b17c144c9fa68d20d586935 on Geal:master.

Coverage remained the same at 81.049% when pulling db95f62f7da4fe35d4edb1fc9d4840c574e81340 on derekdreery:patch-2 into da873207a75306069b17c144c9fa68d20d586935 on Geal:master.

Coverage remained the same at 81.049% when pulling db95f62f7da4fe35d4edb1fc9d4840c574e81340 on derekdreery:patch-2 into da873207a75306069b17c144c9fa68d20d586935 on Geal:master.

Coverage remained the same at 81.049% when pulling db95f62f7da4fe35d4edb1fc9d4840c574e81340 on derekdreery:patch-2 into da873207a75306069b17c144c9fa68d20d586935 on Geal:master.

thanks!


Policy view for gateway doesn't show any policies applied for the gateway

Description
The policy view for the gateway doesn't show any policies applied for the gateway. It might require changes in API to return correct data.

If I understand right, yeah its no longer the case.
Here's the view of what I think we are talking about (builtin and delegated)


Sensors/Switch component

Hi,
going on with my Netio implementation, I was wondering what was the best way to have a sensor/switch combination: netio4all is a remote controllable socket plug with consumption sensors and com is build upon telnet, so I was thinking about:

creating a new component: switch/sensor specific
creating a new generic component:
creating a kind of object provider, accessible from a switch component and a sensor component
using something existing that I missed .. :)

What would be the best action path ?

I am planning to refactor the switch entity that platforms implement to be able to show power consumption and allow dimmers.
Have a look at the Wemo platform which actually exposes the current power usage and today power usage in MWH.

Ok, thanks !

On 11 Jun 2015, at 21:45, Paulus Schoutsen<EMAIL_ADDRESS>wrote:
I am planning to refactor the switch entity that platforms implement to be able to show power consumption and allow dimmers.
Have a look at the Wemo platform https://github.com/balloob/home-assistant/blob/master/homeassistant/components/switch/wemo.py which actually exposes the current power usage and today power usage in MWH.
—
Reply to this email directly or view it on GitHub https://github.com/balloob/home-assistant/issues/175#issuecomment-111256960.

hi guys. Any luck with this? I tried to add the current power consumption to the WeMo Insight in Home Assistant with no luck under the configuration.yaml. Did you guys figured this out how to add this? and perhaps KWH and not MWH as I've found in some documentation online?
Is this even relevant? "states.switch.server.attributes.current_power_mwh" where "server" is the name of my insight switch. has anyone incorporated the usage into their system?


C++ scoped enums

The new c++0x standard supports scoped enumerators. Implement enums (e.g., UNITS, DATATYPES) as scoped...should carry through swig to python API.   This way enums won't just appear in the global namespace, they will be grouped under the enum type name

fixed in develop branch by adding DataType class

This was actually resolved, but by moving away from enums and instead adding a DataType class.    So this issue no longer applies.


ManipulationHandler works with grab instead of select

Describe the problem
Sometimes, you might have something you want to be movable, but it's interactable throughout at the same time (browser window). Since we have a grab button on the side of any 6DOF MotionController, it would be nice to directly interact with select and move it around with grab. The problem is, that the ManipulationHandler handles it's interactions all by itself. Instead of being called from a script on how to operate things it deals with them in its own right (it implements the interaction interfaces directly).
One can not specify what the action is that moves it. Furthermore, only OnPointerDown respects the eventData's use property. This means, you cannot even reroute the OnPointerUpdate through another script.
Describe the solution you'd like
ManipulationHandler should be handling the movement, orientation, constraints etc. The logic for where the input comes from should be put into another script. The ManipulationHandler knows what Input it needs so the current OnPointer* calls could be replaced and called from outside. The we would have control over where the input comes from and what type it is.
Describe alternatives you've considered
I'll see if I modify the DefaultControllerPointer so it does react to the grab action in addition to the select action.
I also might hack something to mimic selection with the grab input, alter the ManipulationHandler so it does not listen itself and then also call into the DefaultControllerPointer so it looks as if select was pressed.
Additional context
Maybe there is an existing way, I could not find one

There is currently a PR pending approval which adds near interactions to controllers, making it so that the users can use the grab action on 6dof controllers and move objects via near manipulation with the grab button.
I'm not sure if this issue is also asking for using the grab button for far interactions, but a more complicated set of effort would be required on that front, since each pointer is only associated with one pose action, and adding a redundant far pointer would warrant some performance considerations.
@Alexees if you have more context on the original scenario, please reach out and let us know!

Related: #10057

marking a closed due to #10057 and v 3.0 improvements to object manipulation.


Ruby procs show the wrong predicted hit at Whisperer

Ruby procs show the wrong predicted hit at Whisperer
https://github.com/user-attachments/assets/de424682-bd81-4539-9740-ce39de4ecdbd

I would also add that predicted hits for the Whisperer using tumeken's shadow are also wrong. I can provide an example if required.

Can confirm, I was only paying attention to the ruby procs at first. the shadow exp drops also show a way lower predicted hit

Yea I must have messed up the xpbonus for whisperer in the last update. Thanks for bringing it to my attention

Should be fixed now

Thank you! I appreciate your work! I heard there was also some problem at
duke, but haven't been there myself so can't confirm this yet
On Mon, Jul 15, 2024 at 7:36 PM l2- @.***> wrote:

Should be fixed now
—
Reply to this email directly, view it on GitHub
https://github.com/l2-/template-plugin/issues/115#issuecomment-2229041408,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BJEFIPJ6D2FPXHI43DX74S3ZMQCDFAVCNFSM6AAAAABK3O7MOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRZGA2DCNBQHA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Smaller EXE size

Pyinstaller makes 13mb EXE file, this is a big negative for any RAT, squeezing the file-size by removing unnecessary files would be a good upgrade.

I'm having a load of trouble understanding how to actually getting pyinstaller to work now. Ritiek's version didn't need .spec files or anything. I'm gonna read up a little more...

Aha. Using pyinstaller --upx-dir  followed by the directory of UPX's directory managed to bring 3 MB (~20%) off the binary.
It's not much but it's something. Problem with Python is that apparently much has to go into the executable. I read about Cython which is an optimizing compiler but that would take a little longer to get going.
Is 20% better enough? Mind if I close this issue?

@LearnerZone @mvrozanti Might as well keep this around as a tracking issue that's either open all the time, or re-opened whenever a new method is proposed.  Since Cython is currently in play, maybe keep open 'til determination is made re: that?

@TPS There's already an issue for suggestions but I feel the executable can still be shrinked. You're right. I'll let this open until we get size even lower.

This can be done relatively easily:
Create a smaller RAT that will just infect and download the "larger" bot RAT (dropper).
I will start working on it

@Dviros The main USP of this bot is you do not need a server (which leaves traces) so hosting less delivery of a smaller filesize should still be the first choice, also I guess you could use many other non-python droppers to achieve a very smaller filesize.


Remove deprecated gradle code for removal in gradle 9

Is your feature request related to a problem? Please describe.
The gradle plugin gives build warnings for some deprecated classes being used:
The Project.getConvention() method has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.3/userguide/upgrading_version_8.html#deprecated_access_to_conventions
The org.gradle.api.plugins.JavaPluginConvention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.3/userguide/upgrading_version_8.html#java_convention_deprecation
at build_000000.doCall(/path/to/project/build.gradle:74)
build.gradle:74
id "org.springframework.cloud.contract" version "${springCloudContractVersion}" apply false

Describe the solution you'd like
Removal of the use of this deprecated code using upgrading guides
Describe alternatives you've considered
Simply ignoring the warnings till Gradle 9 when they will become errors
Additional context
springCloudContractVersion=4.0.4

@shanman190 :pray: :pray: :pray:


Fix reflexive relationships

This PR should be merged after #88, and closes #85 . As I don't know the actual order in which this PR, #88, and #87 are going to be merged, I left it as it is, and will fix it when it needs to.

This PR only fixes reflexive relationships where the FK is on the base model (I didn't touch the hasMany SQL query generator).

Basically, this PR does two things:

It changes the belongsTo SQL generator, so that one of the tables has an alias, to avoid a DB error.
It adds a filter to the serializer, because it seems that the change in the SQL makes possible the existence of undefined objects in the data.relationships property.

This is an example of the endpoint working

@spersico Can you fix these merge conflicts?

@spersico Can you fix these merge conflicts?

yep, I was expecting this. I'll see to it later


Not found: No registered 'Pad' OpKernel for CPU devices compatible with node Pad_12 = Pad[T=DT_STRING, Tpaddings=DT_INT32](Reshape_6, stack_12)

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):binary
TensorFlow version (use command below):1.5
Python version:2.7
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):5.4
CUDA/cuDNN version: cuda9.0 cudnn 7 nvidia- 384driver
GPU model and memory: 12G
Exact command to reproduce:
python object_detection/model_main.py     --pipeline_config_path=${PIPELINE_CONFIG_PATH}     --model_dir=${MODEL_DIR}     --num_train_steps=${NUM_TRAIN_STEPS}     --num_eval_steps=${NUM_EVAL_STEPS}     --alsologtostderr
TITANX  python object_detection/model_main.py \

--pipeline_config_path=${PIPELINE_CONFIG_PATH} \
--model_dir=${MODEL_DIR} \
--num_train_steps=${NUM_TRAIN_STEPS} \
--num_eval_steps=${NUM_EVAL_STEPS} \
--alsologtostderr

WARNING:tensorflow:Estimator's model_fn (<function model_fn at 0x7eff51d9a6e0>) includes params argument, but params are not passed to Estimator.
WARNING:tensorflow:num_readers has been reduced to 1 to match input file shards.
WARNING:tensorflow:From /mnt/object_detection/core/box_predictor.py:407: calling reduce_mean (from tensorflow.python.ops.math_ops) with keep_dims is deprecated and will be removed in a future version.
Instructions for updating:
keep_dims is deprecated, use keepdims instead
WARNING:tensorflow:From /mnt/object_detection/meta_architectures/faster_rcnn_meta_arch.py:2037: get_or_create_global_step (from tensorflow.contrib.framework.python.ops.variables) is deprecated and will be removed in a future version.
Instructions for updating:
Please switch to tf.train.get_or_create_global_step
WARNING:tensorflow:From /mnt/object_detection/core/losses.py:317: softmax_cross_entropy_with_logits (from tensorflow.python.ops.nn_ops) is deprecated and will be removed in a future version.
Instructions for updating:
Future major versions of TensorFlow will allow gradients to flow
into the labels input on backprop by default.
See tf.nn.softmax_cross_entropy_with_logits_v2.
WARNING:tensorflow:From /mnt/object_detection/meta_architectures/faster_rcnn_meta_arch.py:1930: calling reduce_sum (from tensorflow.python.ops.math_ops) with keep_dims is deprecated and will be removed in a future version.
Instructions for updating:
keep_dims is deprecated, use keepdims instead
/usr/local/lib/python2.7/dist-packages/tensorflow/python/ops/gradients_impl.py:97: UserWarning: Converting sparse IndexedSlices to a dense Tensor of unknown shape. This may consume a large amount of memory.
"Converting sparse IndexedSlices to a dense Tensor of unknown shape. "
2018-07-24 16:38:16.076136: I tensorflow/core/platform/cpu_feature_guard.cc:137] Your CPU supports instructions that this TensorFlow binary was not compiled to use: SSE4.1 SSE4.2 AVX AVX2 FMA
2018-07-24 16:38:16.529363: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:895] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2018-07-24 16:38:16.532926: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1105] Found device 0 with properties:
name: TITAN X (Pascal) major: 6 minor: 1 memoryClockRate(GHz): 1.531
pciBusID: 0000:00:06.0
totalMemory: 11.90GiB freeMemory: 11.75GiB
2018-07-24 16:38:16.532987: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1195] Creating TensorFlow device (/device:GPU:0) -> (device: 0, name: TITAN X (Pascal), pci bus id: 0000:00:06.0, compute capability: 6.1)
2018-07-24 16:38:34.429255: E tensorflow/core/common_runtime/executor.cc:651] Executor failed to create kernel. Not found: No registered 'Pad' OpKernel for CPU devices compatible with node Pad_12 = Pad[T=DT_STRING, Tpaddings=DT_INT32](Reshape_6, stack_12)
(OpKernel was found, but attributes didn't match)
.  Registered:  device='GPU'; T in [DT_INT32]; Tpaddings in [DT_INT64]
device='GPU'; T in [DT_INT32]; Tpaddings in [DT_INT32]
device='GPU'; T in [DT_DOUBLE]; Tpaddings in [DT_INT64]
device='GPU'; T in [DT_DOUBLE]; Tpaddings in [DT_INT32]
device='GPU'; T in [DT_FLOAT]; Tpaddings in [DT_INT64]
device='GPU'; T in [DT_FLOAT]; Tpaddings in [DT_INT32]
device='GPU'; T in [DT_HALF]; Tpaddings in [DT_INT64]
device='GPU'; T in [DT_HALF]; Tpaddings in [DT_INT32]
device='CPU'; T in [DT_BOOL]; Tpaddings in [DT_INT64]
device='CPU'; T in [DT_BOOL]; Tpaddings in [DT_INT32]
device='CPU'; T in [DT_COMPLEX128]; Tpaddings in [DT_INT64]
device='CPU'; T in [DT_COMPLEX128]; Tpaddings in [DT_INT32]
device='CPU'; T in [DT_COMPLEX64]; Tpaddings in [DT_INT64]

got the same error.

Hi，have you solved the problem yet? I have the same problem

Could you take a test on the latest version of tensorflow?

I had the same issue. However, after I updated tensorflow from 1.5.0 to 1.9.0. It runs smoothly.

@xinyuegtxy does this issue resolve after up-grading to the latest tensorflow?

To me, upgrading tensorflow from 1.5.0 to 1.9.0 resolves the issue.

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

It has been 30 days with no activity and the awaiting response label was assigned. Is this still an issue?

Tf1.9 resolve it

tensorflow 1.11 or 1.9 is ok.


Varnish Cache issue

Also, for the life of me, I can't figure out how to clear Varnish cache from within an ssh session to the VM.

Here's what my config looks like:
apache_listen_port: "81"
# Varnish Configuration (if enabled above).
varnish_listen_port: "80"
varnish_default_vcl_template_path: templates/drupalvm.vcl.j2
varnish_default_backend_host: "<IP_ADDRESS>"
varnish_default_backend_port: "81"

Source: http://docs.drupalvm.com/en/latest/extras/varnish/
Are the above ports correct? I'm second guessing myself because when I run:
curl -X BAN http://<IP_ADDRESS>:81/ -H "X-Drupal-Cache-Tags: block_view"
I see the following error:
The website encountered an unexpected error. Please try again later.

Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException: No route found for "BAN /": Method Not Allowed (Allow: GET, POST, DELETE) in Symfony\Component\HttpKernel\EventListener\RouterListener->onKernelRequest() (line 180 of /var/www/webny/vendor/symfony/http-kernel/EventListener/RouterListener.php).
Drupal\Core\Routing\UrlMatcher->finalMatch(Object, Object) (Line: 152)

My assumption is that I'd want varnish listening on port 80 and apache would be on 81, I'm not sure exactly what the varnish_default_backend_port is. I'm assuming it's to access the varnish data store.
I've also got my the following settings.php changes added:
$settings['reverse_proxy'] = TRUE;
$settings['reverse_proxy_addresses'] = array('<IP_ADDRESS>');

I've read through this thread which was super informative
https://github.com/geerlingguy/drupal-vm/issues/397
Unfortunately I still seem to be running into issues when trying to simply clear the cache via curl.
When I run the following,
curl -X BAN http://<IP_ADDRESS>/ -H "X-Cache-Tags: block_view"
I see the following error
<!DOCTYPE html>

    <title>403 Purge-Cache-Tags header missing.</title>

Error 403 Purge-Cache-Tags header missing.

Purge-Cache-Tags header missing.

Guru Meditation:

XID: 229633

Varnish cache server

So my first goal is just to just be able to manually clear my varnish cache, so I know I've got things setup correctly. Then I'm hoping to clear using tags, but honestly, that's not even that important.
Any help is greatly appreciated.

So after digging into the VCL file closer, I'm seeing
    # Only allow PURGE requests from IP addresses in the 'purge' ACL.
    if (req.method == "PURGE") {
        if (!client.ip ~ purge) {
            return (synth(405, "Not allowed."));
        }
        return (hash);
    }

I'm wondering why we're returning (hash) here?
From the varnish documentation: https://www.varnish-cache.org/docs/4.0/users-guide/purging.html it seems like we'd want to return (purge) no?
Here's a bit more about how I got to this point:
First, I finally was able to figure out how to access the CLI  via varnishadm
$ varnishadm "ban req.http.host == amber.dev"
This did in fact clear my varnish cache, in that I'd see a X-Varnish-Cache: MISS if I did curl request or inspected the headers via my browser . A few of the other varnishadm commands confirmed that varnish seemed to be up and running for me.
To simplify my testing, I ended up just creating a simple html page (varnish.html) so I could monitor the varnish log via $ varnishlog and not have to deal with all of the other requests showing up with a full drupal page.
Regardless though, with the PURGE request returning (hash), when I would run:
$ curl -I -v -X PURGE -H 'host: amber.dev' amber.dev/varnish.html
The cache would not be cleared, I would see a HIT if I inspected the headers through the browser, and I would see the following headers via curl:
* Hostname was NOT found in DNS cache
*   Trying <IP_ADDRESS>...
* Connected to amber.dev (<IP_ADDRESS>) port 80 (#0)
> PURGE /varnish.html HTTP/1.1
> User-Agent: curl/7.35.0
> Accept: */*
> host: amber.dev
>
< HTTP/1.1 200 OK
HTTP/1.1 200 OK
< Date: Fri, 28 Oct 2016 15:48:04 GMT
Date: Fri, 28 Oct 2016 15:48:04 GMT
* Server Apache/2.4.7 (Ubuntu) is not blacklisted
< Server: Apache/2.4.7 (Ubuntu)
Server: Apache/2.4.7 (Ubuntu)
< Last-Modified: Fri, 28 Oct 2016 15:47:46 GMT
Last-Modified: Fri, 28 Oct 2016 15:47:46 GMT
< Vary: Accept-Encoding
Vary: Accept-Encoding
< Cache-Control: max-age=1209600
Cache-Control: max-age=1209600
< Expires: Fri, 11 Nov 2016 15:48:04 GMT
Expires: Fri, 11 Nov 2016 15:48:04 GMT
< Content-Type: text/html
Content-Type: text/html
< X-Varnish: 10 3
X-Varnish: 10 3
< Age: 18
Age: 18
< Via: 1.1 varnish-v4
Via: 1.1 varnish-v4
< ETag: W/"97-53feec7898c80-gzip"
ETag: W/"97-53feec7898c80-gzip"
< X-Varnish-Cache: HIT
X-Varnish-Cache: HIT
< Transfer-Encoding: chunked
Transfer-Encoding: chunked
< Connection: keep-alive
Connection: keep-alive
< Accept-Ranges: bytes
Accept-Ranges: bytes

<
* Excess found in a non pipelined read: excess = 164 url = /varnish.html (zero-length body)
* Connection #0 to host amber.dev left intact

From everything I was reading, I should see HTTP/1.1 200 PURGE returned if the purge actually succeeded.
I then changed the /etc/varnish/default.vcl to the following:
    # Only allow PURGE requests from IP addresses in the 'purge' ACL.
    if (req.method == "PURGE") {
        if (!client.ip ~ purge) {
            return (synth(405, "Not allowed."));
        }
        return (purge);
    }

And restarted Varnish with:
$ sudo service varnish restart - I think you might also be able to run $  sudo /etc/init.d/varnish reload
I immediately noticed a difference when running :
$ curl -I -v -X PURGE -H 'host: amber.dev' amber.dev/varnish.html
Because I saw the following returned:
HTTP/1.1 200 Purged
I then confirmed that the cache was getting cleared via my browser as well.
source:

https://www.varnish-cache.org/docs/4.0/users-guide/purging.html
http://book.varnish-software.com/4.0/chapters/VCL_Basics.html

I'll try to take a look soon... I was fairly certain this was working as-is earlier, at least with Varnish 4.x, but maybe I didn't commit a fix I though I had or something :/

Hmm... is this happening using the default Varnish version (4.x, I believe), or only when you're trying to switch to 3.x? At this time, Drupal VM's defaults are only guaranteed to work with 4.x, and purging/banning changed a lot between the two versions. The 3.x style PURGE request is a bit different than BANs in 4.x.

This is with the latest Varnish 4.x - I could be totally wrong with the vcl though as I really don't know what I'm doing with Varnish or the VCL file.

Another potential issue with provisioning/templates/drupalvm.vcl.j2 file is that since Purge 8-x.1.4 the header is now Cache-Tags vs the older Purge-Cache-Tags which means the VCL file would need to be updated to:
# Only allow BAN requests from IP addresses in the 'purge' ACL.
    if (req.method == "BAN") {
        # Same ACL check as above:
        if (!client.ip ~ purge) {
            return (synth(403, "Not allowed."));
        }

        # Logic for the ban, using the Cache-Tags header. For more info
        # see https://github.com/geerlingguy/drupal-vm/issues/397.
        if (req.http.Cache-Tags) {
            ban("obj.http.Cache-Tags ~ " + req.http.Cache-Tags);
        }
        else {
            return (synth(403, "Cache-Tags header missing."));
        }

        # Throw a synthetic page so the request won't go to the backend.
        return (synth(200, "Ban added."));
    }

source: https://wunderkraut.se/blogg/varnish-purge-8x14-out
: https://gitlab.wklive.net/snippets/32

drupal.org docs also uses return (purge).

Sounds good enough for me, merging the PR for now, will try to get some more time to retest later. Also linking http://www.jeffgeerling.com/blog/2016/use-drupal-8-cache-tags-varnish-and-purge for posterity (that was when I was initially adding this support... I notice in the blog post I never mentioned returning the hash).


ImportError: No module named hogwatch.server.web_service

I'm getting this error when running the program.
Traceback (most recent call last):
  File "/home/zerinol/.local/bin/hogwatch", line 7, in <module>
    from hogwatch.server.web_service import app_server
ImportError: No module named hogwatch.server.web_service

and if I try it with sudo
sudo: hogwatch: command not found
which is even weirder.
I'm on ubuntu 18.04 and /usr/bin/python is symlinked to python2.7

tryied symlinking to 3.6 and the result is
  File "/home/zerinol/.local/bin/hogwatch", line 10
    print "Hit ctrl-c to exit"
                             ^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print("Hit ctrl-c to exit")?


given CanEqual reported as unused even if required by strictEquality

Compiler version
    scalaVersion := "3.3.0",
    scalacOptions ++= List(
      "-language:strictEquality",
      "-Wunused:all",
      "-Xfatal-warnings",
      "-source:future"
    )

Minimized code
@main
def main(): Unit = {

  type DorS = Double | String

  val a: DorS = 1.0
  val b: DorS = "hello"

  given CanEqual[DorS, DorS] = CanEqual.derived

  println(a == b)

}

Output
[error] -- Error: .../main.scala:9:8
[error]   |  given CanEqual[DorS, DorS] = CanEqual.derived
[error]   |        ^^^^^^^^^^^^^^^^^^^^^^^^
[error]   |        unused local definition

but if I remove it the compiler rightfully states that
Values of types DorS and DorS cannot be compared with == or !=

Expectation
I expect no warning since the given is used and needed

This has already been fixed in Next (3.4.0 and onwards), as well as backported to 3.3.4-RC1.
For the LTS line, either test with the RC or wait for 3.3.4 to be out.
//> using options -language:strictEquality -Wunused:all -Xfatal-warnings -source:future
//> using scala 3.3.4-RC1 3.4.0 3.4.1 3.4.2 3.5.0
@main def main(): Unit = {
  type DorS = Double | String
  val a: DorS = 1.0
  val b: DorS = "hello"
  given CanEqual[DorS, DorS] = CanEqual.derived
  println(a == b)
}

Closing this, nothing to be done.


datastreams: add affiliations and update funders

:heart: Thank you for your contribution!
Description
Adds the affiliation datastreams and updates the location of the funders datastreams to match https://github.com/inveniosoftware/invenio-vocabularies/pull/327
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

[x] I'm aware of the code of conduct.
[x] I've created logical separate commits and followed the commit message format.
[x] I've added relevant test cases.
[x] I've added relevant documentation.
[x] I've marked translation strings.
[x] I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
[x] I've NOT included third-party code (copy/pasted source code or new dependencies).

If you have added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

You license your contribution under the same terms as the current repository’s license.
You agree that you have the right to license your contribution under the current repository’s license.

Thanks @ptamarit! I've simplified the imports, and will fix any isort issues once https://github.com/inveniosoftware/invenio-vocabularies/pull/327 is merged/released so the tests can run.

Re-opened as https://github.com/inveniosoftware/invenio-app-rdm/pull/2749 because we had to rebase + isort


Add APEX and Kermantech Mk3 IVA

https://forum.kerbalspaceprogram.com/index.php?/topic/206744-112x-reviva-the-iva-revival-and-editorflight-switcher-now-with-airplane-plus-bdb-apollo-cm-075-29th-apr-2022/&do=findComment&comment=4139721

I may be adopting one or both of these mods, and if that happens I can add Reviva support directly to them.  Just something to keep in mind…it might be harder to undo a direct patch to Reviva in the future.


Errors when updating labels "this.github.issues.getLabels" is not a function

I was integrating the settings bot with my own bot, and am getting the error this.github.issues.getLabels is not a function in lib/plugins/labels.js:24.31.
I looked at the octokit/rest.js documentation and could not find a function for "issues.getLabels". Should it be this.github.issues.listLabelsForRepo (https://octokit.github.io/rest.js/#octokit-routes-issues-list-labels-for-repo) ?

I also am having a similar error with milestones: this.github.issues.getMilestones is not a function lib/plugins/milestones.js:17:42

thanks for the report. the getLabels issue has been previously reported, but a fix has been slowed as we discuss options around a similar problem with updateLabel. i've suggested splitting that PR so that we can get the getLabels fix in place. if you have any feedback on either piece of that PR, please feel free to comment there.
i imagine that the getMilestones issue that you are seeing is for a similar reason. if you'd be interested in tracking down the details and submitting a PR to fix, i'd be happy to help you through the details to get this resolved.

@travi I created a PR for the getMilestones issue. I'm not sure if I did it correctly, as this is my first time.


Missing/Incorrect images showing on Xamarin Profiler page

There are several images that are missing or incorrect on the Xamarin Profiler docs page.

[x] Issue 1: Cycles screenshot for VSMac is missing

[x] Issue 2: Incorrect image is shown when you click to zoom in on the Visual Studio tab in the same Cycles section

Inline image:

Zoomed image:

Thanks for finding this!  Fixed in https://github.com/MicrosoftDocs/xamarin-docs-pr/pull/344.


Javadoc comments with carriage returns

Hi
Currently when we add javadoc comments e.g. to class definitions the eclipse IDE formatting settings will wrap with carriage returns to ensure the comment stays in view in the editor.  This makes perfect sense however in ascii doctor we often don't want to do this i.e. we use soft wrapping. How do others handle this? Is there a configuration option we could enable to take carriage return line feeds within eclipse and remove although this would be difficult as some CRLF characters maybe required for paragraph separation.
Thanks
Matt

Can you give an example?


Ignore GCS in CI

We got booted from the GCS account, so skip this in CI for now.
Signed-off-by: Lucas Servén Marín<EMAIL_ADDRESS>cc @thanos-io/thanos-maintainers

Can we just change Makefile in this pr? (:

-_______- messed it up

Let's work with the CNCF to get a GCS account for these tests, I think this is really important.

We have already account, and all of us has permissions to set it up. Also, there is a ticket for this: https://github.com/thanos-io/thanos/issues/2367


Making 9.2.x backwards compatible with 9.1.x

In order to make 9.2.x backwards compatible against plugins compiled
with 9.1.x, this PR does the following:

Adds back exposed enum values removed in 9.2.x
Any added enum values are put at the end of their enumeration lists.
Adds back the TSHttpTxnCntl function

We'll want this for the 9.x trains (currently 9.2.x and master), but not for the 10.x train. That experimental TSHttpTxnCntl should not exist in 10.x. Thus after this is merged, I'll merge up 10-Dev and then revert this patch from there.

[approve ci centos]

[approve ci debian]

[approve ci fedora]

[approve ci ubuntu]

[approve ci centos]

[approve ci debian]

[approve ci ubuntu]

Are you sure we really need that experimental crud? Is someone using it? :-). The Lua feature has been updated already to use the new API and should be in 9.2.x.

Are you sure we really need that experimental crud? Is someone using it? :-). The Lua feature has been updated already to use the new API and should be in 9.2.x.

I vote to remove it in 10.x, but keep it for 9.2.x. Yahoo has an internal plugin that uses the TSHttpTxnCntl function.

Oh, I see. The regression tests try to use the proxy.client.verify.server config via the TS_CONFIG_SSL_CLIENT_VERIFY_SERVER which I put back in to preserve the ABI, but it fails because none of that is implemented now.
@zwoop / @randall : I think we'll have to back out #7639 from 9.2.x. 10.x will be fine, for sure, but I don't think we can remove porxy.client.verify.server and be compatible with the previous 9.x branches.

Oh, I see. The regression tests try to use the proxy.client.verify.server config via the TS_CONFIG_SSL_CLIENT_VERIFY_SERVER which I put back in to preserve the ABI, but it fails because none of that is implemented now.
@zwoop / @randall : I think we'll have to back out #7639 from 9.2.x. 10.x will be fine, for sure, but I don't think we can remove porxy.client.verify.server and be compatible with the previous 9.x branches.

As an alternative to this, I'm updating the InkAPITest.cc to handle the defunct proxy.client.verify.server config. If this seems OK to @randall and @zwoop, then we can move forward with that.

[approve ci]

I am still seeing some issue with data types:
https://trafficserver.apache.org/compat_reports/traffic_server/9.1.x_to_master/compat_report.html

I am still seeing some issue with data types:
https://trafficserver.apache.org/compat_reports/traffic_server/9.1.x_to_master/compat_report.html

We talked about this offline, but just to record it here: this will happen on master because the configure.ac defines TS_VERSION_MAJOR as 10, so some enum values and definitions are removed in master. This shouldn't be a problem once this patch is picked back to 9.2.x.

Cherry-picked to v9.2.x


Changing the number of open editors is not resizing the open editors view

Set number of open editors configuration to 10
Open 10 files. See the open editors view is showing all 10 files
Set the configuration to 4

Expected: View should be resized to 4 show files
Bug: View is not getting resized

I'd like to discuss the meaning of this setting. The User Settings say explorer.openEditors.visible is the number of editors shown in the Open Editors pane.
In my opinion, it could mean two things:

The Open Editors pane should show at least as much editors.
The Open Editors pane should show at most as much editors.

The expected behavior @sandy081 described sounds like the second option (correct me if I got it wrong).
However, in the code (pointer here) it seems to calculate as follows:

The minimum body size: itemsToShow * OpenEditorsDelegate.ITEM_HEIGHT, where itemsToShow is the minimum between the number of open editors from the configuration and the number of  actual open editors, and OpenEditorsDelegate.ITEM_HEIGHT is hard-coded to be 22.
The maximum body size: the number of actual open editors * OpenEditorsDelegate.ITEM_HEIGHT.
That is the reason for the "buggy" behavior (option 1).

My question is, which one should it be?

Option 1.
However the view actually always has the minimum size unless the user explicitly resizes it. So @sandy081 finds it weird that the view is still not the minimal size since he did not manullay expand it.
@oriash93 if you are passionate about open editor sizing please read these issues
https://github.com/Microsoft/vscode/issues/43501
https://github.com/Microsoft/vscode/issues/25911
https://github.com/Microsoft/vscode/issues/491


Search Crashes

Hi
I have 3lakhs nodes in jstree loaded from ajax.
The search crashes when a specific string whose number is large.
Could anyone please suggest me some solution?

I can not help you without a demo, but usually this means you have duplicated node IDs. I will reopen if this is not the case and you are able to provide a demo.

Hi,
I am quite sure I am not providing duplicate node id.I can only provide you the demo if you can connect to my machine remotely as I am using data from  WEBservice to build the tree.If possible please let me know.
 With RegardsSaumen Dasgupta
On Tuesday, 1 November 2016, 22:02, Ivan Bozhanov<EMAIL_ADDRESS>wrote:

Closed #1611.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi
Please let me know your appropiate time so that you can take remote.
 With RegardsSaumen Dasgupta
On Wednesday, 2 November 2016, 10:39, Saumen Dasgupta<EMAIL_ADDRESS>wrote:

Hi,
I am quite sure I am not providing duplicate node id.I can only provide you the demo if you can connect to my machine remotely as I am using data from  WEBservice to build the tree.If possible please let me know.
 With RegardsSaumen Dasgupta
On Tuesday, 1 November 2016, 22:02, Ivan Bozhanov<EMAIL_ADDRESS>wrote:

Closed #1611.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi ,
I am unable to load a 3lakhs files at a go in jstree. I would need help on that.I am ready to pay charges for the same.Please revert if it is possible With RegardsSaumen Dasgupta
On Tuesday, 8 November 2016, 15:46, Saumen Dasgupta<EMAIL_ADDRESS>wrote:

Hi
Please let me know your appropiate time so that you can take remote.
 With RegardsSaumen Dasgupta
On Wednesday, 2 November 2016, 10:39, Saumen Dasgupta<EMAIL_ADDRESS>wrote:

Hi,
I am quite sure I am not providing duplicate node id.I can only provide you the demo if you can connect to my machine remotely as I am using data from  WEBservice to build the tree.If possible please let me know.
 With RegardsSaumen Dasgupta
On Tuesday, 1 November 2016, 22:02, Ivan Bozhanov<EMAIL_ADDRESS>wrote:

Closed #1611.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Once again - I can't help you without a demo - I can not reproduce the issue. I am currently not available for contract work.


[multistage] Add support for RANK and DENSE_RANK ranking window functions

This PR adds support for the ranking RANK() and DENSE_RANK() window functions in Apache Pinot. These functions use only RANGE window frame types and an ORDER BY clause within OVER() is mandated by Apache Calcite. Types of queries where these ranking functions can be used are:

OVER(ORDER BY)(s)
OVER(PARTITION BY ORDER BY)(s) [the partition by and order by key can be the same]

There are some limitations with RANK() and DENSE_RANK() which are:

Cannot use custom frames including explicitly setting the default custom frame. The default frame behavior is RANGE BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW
Must include ORDER BY in the OVER() clause

The design document and issue for window functions support can be found below:

Design document for Phase 1: https://docs.google.com/document/d/13CmFm4djI09JKF_Xty5acoXxJoxC9CLXAsmikgzgtIs/edit?usp=sharing
Window functions Issue: https://github.com/apache/pinot/issues/7213

Prior Phase 1 PRs related to window functions:

Window Function Planner PR: https://github.com/apache/pinot/pull/10228
Window Functions Runtime PR for empty OVER() and OVER(PARTITION BY): https://github.com/apache/pinot/pull/10286
Adding ordering as a part of the SortExchange: https://github.com/apache/pinot/pull/10408
Window Functions Runtime PR for OVER(ORDER BY) and OVER(PARTITION BY ORDER BY): https://github.com/apache/pinot/pull/10449

Support for ROW_NUMBER ranking function:

https://github.com/apache/pinot/pull/10587
Bug fix for empty LogicalProject issue (does not affect RANK() or DENSE_RANK() since an ORDER BY column is mandated): https://github.com/apache/pinot/pull/10635

cc @siddharthteotia @walterddr @vvivekiyer @ankitsultana

Codecov Report

Merging #10700 (ba9ee40) into master (f5dba86) will decrease coverage by 54.61%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #10700       +/-   ##
=============================================
- Coverage     68.44%   13.83%   -54.61%
+ Complexity     6418      439     -5979
=============================================
  Files          2108     2054       -54
  Lines        113885   111414     -2471
  Branches      17201    16909      -292
=============================================
- Hits          77950    15416    -62534
- Misses        30397    94736    +64339
+ Partials       5538     1262     -4276

Flag
Coverage Δ

integration1
?

unittests1
?

unittests2
13.83% <0.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...g/apache/pinot/query/planner/stage/WindowNode.java
0.00% <0.00%> (-82.50%)
:arrow_down:

...uery/runtime/operator/WindowAggregateOperator.java
0.00% <0.00%> (-95.29%)
:arrow_down:

... and 1621 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

thanks @somandal is this ready for review?

Yes this is ready for review 👍

I would like to take a look at couple of things today before merging.

@siddharthteotia is this ready to get merged?

@siddharthteotia can you take another look for this PR?

@siddharthteotia can you take another look for this PR?

@walterddr discussed with @siddharthteotia and he is okay with merging this PR. Thanks!


Typo on last line of 6.1.3

... "Additional Substate CLI usage options are available ..."

Fixed by #2754


Let the user define its own embedded languages in the settings

Issue Type: Feature Request
It would be helpful to have the user be able to define its own embedded languages in the settings (user or workspace)
This would be especially useful with C++11 Raw String Delimiters
(see issue stef-levesque/vscode-shader#13)
I would expect something like that, in a similar manner to how the editor settings can be overridden per language
    "[cpp]":  {
        "embeddedLanguages": [{
            "hlsl": {
                "begin": "(?:^\\s*)R\"glsl\\(",
                "end": "\\)glsl\"",
            }
        }]
    },

    "[html]":  {
        "embeddedLanguages": [{
            "python": {
                "begin": "(?:^\\s*)<\\?python(?!.*\\?>)",
                "end": "\\?>(?:\\s*$\\n)?",
            }
        }]
    }

VS Code version: Code 1.21.1 (79b44aa704ce542d8ca4a3cc44cfca566e7720f1, 2018-03-14T14:46:47.128Z)
OS version: Windows_NT x64 10.0.15063

@mjbvz you probably know who to send this one to

Extensions can already contributed injected grammars, see the styled-components extension for example: https://github.com/styled-components/vscode-styled-components
Doing this properly gets rather complicated (and it is not easily simplified) so it's probably a better fit for an extension rather than a user setting


WIP - Running livebook on iOS

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Per @dominicletz finding we cannot do it because we can't spawn new processes on iOS and we need that for Livebook runtimes.

We do have the embedded runtime that runs in the same BEAM node, that's what NervesLivebok uses. It has limitations, but works for certain group of use cases.

We do have the embedded runtime that runs in the same BEAM node, that's what NervesLivebok uses. It has limitations, but works for certain group of use cases.

Thanks @jonatanklosko , just found that as well while browsing the code. I've updated my branch to use that and it seems fine for the examples. I'll leave that branch there in case anyone wants to check it out.


fix to skip 'testdata' directory #140

LGTM because it fixes the issue, but I would copy and paste the way the Go tool does this exactly, instead of using a different syntax. That way it's easier to keep it in sync with any future changes to the Go tool.
// Avoid .foo, _foo, and testdata directory trees, but do not avoid "." or "..".
elem := w.Stat().Name()
dot := strings.HasPrefix(elem, ".") && elem != "." && elem != ".."
if dot || strings.HasPrefix(elem, "_") || elem == "testdata" {

Source: https://github.com/golang/go/blob/dc870d5f4b77c0a2a276f8fd12510a53969c56b5/src/cmd/go/main.go#L616-L619

Actually, this may not fix issue, looking into it.

Okay, I've done some testing regarding https://github.com/tools/godep/issues/140#issuecomment-98222302, and this fix does work. But the problem is that it's not retroactive. Workspaces saved with older godep will need to be removed and recreated using new version, which will skip over testdata folder and avoid the issue in the future.

Actually, I will retract my LGTM and say -1, I'd prefer this not be merged as is.
I think what it fixes is a symptom, not the real cause. It should be okay to vendor testdata folders, the issue is that they shouldn't be navigated into when listing Go packages and causing errors since testdata folders may purposefully (correctly) contain .go files that are invalid Go code.
That issue should  be fixed first, then perhaps testdata folders should be skipped when vendoring also. After all, folders starting with . and _ are already skipped.
I'll try to look into this more closely in some time.


Ensure no input values are modified anywhere

This fixes #224, a long-standing risk where we manipulated input values (Object.assign mutates its first argument). Usually, the guard against this is to just pass an empty object to Object.assign, but since Datasets and Blobs are not always (depending on the implementation, I suppose) plain JS objects, we couldn't do that - we need an actual instance of their classes with copied data. This adds a function internal_cloneResource that uses a heuristic to copy over the properties we've added to such an instance (by only copying over properties with atomic values, i.e. not functions like Dataset.match), which is slightly better than what we did before (copy over a list of known properties, e.g. internal_withResourceInfo) and thus can be used everywhere.

[x] I've added a unit test to test for potential regressions of this bug.
[x] The changelog has been updated, if applicable.
[x] Commits in this PR are minimal and have descriptive commit messages.

Hi @Vinnl - this is probably my lack of TS / JS experience again, but I'm struggling to fully understand the issue here (is it as simple as our SDK wanting to have pure immutable JS objects, whereas the underlying RDF/JS libraries use JS classes with mutable state?).
The heuristics in the cloneResource() also make me nervous (i.e. it 'seems' like there might be a need for something like the termType field in the basic RDF/JS classes, like Literal, BlankNode, NamedNode, etc. - i.e. an explicit field providing the exact object type as a string, rather than relying on the presence of specifically named methods).
Anyway, I guess you consider this important to do before GA, so I assume it's really important that I properly understand the actual problem better here...

(is it as simple as our SDK wanting to have pure immutable JS objects

yes

whereas the underlying RDF/JS libraries use JS classes with mutable state?

It's not so much that they're using classes with mutable state, but that there are no native JS facilities to clone a class instance, and that the RDF/JS doesn't even mandate that Datasets actually are class instances, I think.

The heuristics in the cloneResource() also make me nervous (i.e. it 'seems' like there might be a need for something like the termType field in the basic RDF/JS classes, like Literal, BlankNode, NamedNode, etc. - i.e. an explicit field providing the exact object type as a string, rather than relying on the presence of specifically named methods).

That would be nice, but the RDF/JS spec doesn't specify that. That said, I'm not worried too much about the heuristics for distinguishing Files and SolidDatasets (since we'd expect to get one of those anyway, so they're reliable). The heuristics for identifying our own properties rather than instance functions are somewhat more iffy, but still better than what we had.
Longer term, ideally we'd just use raw JS data structures (would be more efficient too) and provide a quick translation functions that exports it into an RDF/JS dataset proper (we discussed something like that earlier with Emmet), but that's more of a 'cleanup' thing. For now, this PR at least prevents actual bugs (i.e. in which the developer is trying to access stale data but unexpectedly gets data that is out of sync with their View).


VRCFaceTracking Not Working

Hello, I did have normally setup anything like the installation said but, getting a lot of errors in the VRCFaceTracking console and it's too don't work.

Thanks for the heads-up! I'll look into this, I have a feeling it's a locale-related parsing issue

Made a new build, try this out: https://github.com/dfgHiatus/NoVRCFT/releases/tag/v1.0.1a
All you need to do is replace WCFace.dll with this one

Did try right now with the file you did send (Did replace it only in the CustomLibs folder) And now when I do want to launch VRCFaceTracking, it's just crash with this error (Hope it's okay that some part of the error are in French since it's my main language):

Could you copy that text into a file? I think I have an idea of what's going on

Here the text :
[00:17:21] VRCFT Standalone Initializing!
[00:17:21] Loaded library C:\Users\Hugo\AppData\Roaming\VRCFaceTracking\StockLibs\libHTC_License.dll
[00:17:21] Loaded library C:\Users\Hugo\AppData\Roaming\VRCFaceTracking\StockLibs\nanomsg.dll
[00:17:21] Loaded library C:\Users\Hugo\AppData\Roaming\VRCFaceTracking\StockLibs\SRWorks_Log.dll
[00:17:21] Loaded library C:\Users\Hugo\AppData\Roaming\VRCFaceTracking\StockLibs\ViveSR_Client.dll
[00:17:21] Loaded library C:\Users\Hugo\AppData\Roaming\VRCFaceTracking\StockLibs\SRanipal.dll
[00:17:21] Loaded library C:\Users\Hugo\AppData\Roaming\VRCFaceTracking\StockLibs\PimaxEyeTracker.dll
[00:17:21] Initialized DependencyManager Successfully
[00:17:21] Initialized UnifiedLibManager Successfully
[00:17:21] Finding and initializing runtimes...
[00:17:21] Loading External Modules...
[00:17:21] Loading C:\Users\Hugo\AppData\Roaming\VRCFaceTracking\CustomLibs\WCFace.dll
[00:17:21] [WARNING] Due to a bug with VRChat's current OSC implementation, it's important you pause the runtime before switching avatars, and unpause when the swap has completed.
Press P to toggle the pause state.
Exception non gérée : System.IO.FileLoadException: Impossible de charger le fichier ou l'assembly 'file:///C:\Users\Hugo\AppData\Roaming\VRCFaceTracking\CustomLibs\WCFace.dll' ou une de ses dépendances. L'opération n'est pas prise en charge. (Exception de HRESULT : 0x80131515) ---> System.NotSupportedException: Tentative de chargement d'un assembly à partir d'un emplacement réseau qui aurait entraîné l'utilisation de l'assembly en mode Bac à sable (sandbox) dans les versions antérieures du .NET Framework. Cette version du .NET Framework n'activant pas la stratégie CAS par défaut, ce chargement peut être dangereux. Si ce chargement n'est pas destiné à utiliser l'assembly en mode Bac à sable (sandbox), activez le commutateur loadFromRemoteSources. Pour plus d'informations, consultez http://go.microsoft.com/fwlink/?LinkId=155569.
--- Fin de la trace de la pile d'exception interne ---
à System.Reflection.RuntimeAssembly._nLoad(AssemblyName fileName, String codeBase, Evidence assemblySecurity, RuntimeAssembly locationHint, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks)
à System.Reflection.RuntimeAssembly.InternalLoadAssemblyName(AssemblyName assemblyRef, Evidence assemblySecurity, RuntimeAssembly reqAssembly, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks)
à System.Reflection.RuntimeAssembly.InternalLoadFrom(String assemblyFile, Evidence securityEvidence, Byte[] hashValue, AssemblyHashAlgorithm hashAlgorithm, Boolean forIntrospection, Boolean suppressSecurityChecks, StackCrawlMark& stackMark)
à System.Reflection.Assembly.LoadFrom(String assemblyFile)
à VRCFaceTracking.UnifiedLibManager.LoadExternalModules()
à VRCFaceTracking.UnifiedLibManager.FindAndInitRuntimes(Boolean eye, Boolean lip)
à VRCFaceTracking.UnifiedLibManager.<>c__DisplayClass7_0.b__0()
à System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
à System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
à System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
à System.Threading.ThreadHelper.ThreadStart()

Try opening the file properties and clicking 'Unblock', like in this post: https://stackoverflow.com/questions/15238714/net-local-assembly-load-failed-with-cas-policy

Now It's working yay ! Thanks :D

Fantastic! Glad to help out


Docs not updated

@mregni commented on Mon Jul 22 2019
The docs are not updated since Oct 2018 but it seems that DISTINCT is implemented and should be explained on this page (see following post: https://feedback.azure.com/forums/263030-azure-cosmos-db/suggestions/6719531-provide-support-for-distinct)

Documentdetails
⚠ Dit gedeelte niet bewerken. Het is vereist om problemen te koppelen tussen docs.microsoft.com en GitHub.

ID: 65ef452c-ff25-a2ec-feba-5dafa56cb918
Version Independent ID: 733a3a55-e899-5c1d-9bcc-34c2d7e17d27
Content: Aan de slag met SQL-query's in Azure Cosmos DB
Content Source: articles/cosmos-db/sql-query-getting-started.md
Service: cosmos-db
GitHub Login: @timsander1
Microsoft Alias: tisande

@srvbpigh commented on Mon Jul 22 2019
Hello, @mregni
Thank you for your feedback.
We are actively reviewing your comments and will get back to you soon.
Kind regards,
Microsoft DOCS International Team

@timsander1 Hi Tim, could you please help to check this issue? Thank you.

Distinct and other keywords are documented here: https://docs.microsoft.com/en-us/azure/cosmos-db/sql-query-keywords#distinct

@CeciAc Please check the link and confirm that all correct documentation is there.
https://docs.microsoft.com/en-us/azure/cosmos-db/sql-query-keywords#distinct

@CeciAc hope the link addresses this issue. We will close it if there aren't further questions.
#please-close


fixed code based on retro from lab2

Rules
Make sure that your pull request contains the following:

[x] Good branch naming convention (e.g. feature/ or doc/ prefixes)
[x] Relevant Issue related to the PR
[ ] Add the reviewer
[x] Add the fields to the pull request (e.g. project, labels)

Describe the change (new feature or documentation)
Selon la rétroaction reçu lors de la correction du laboratoire, ce PR fix ces petits défauts.

Le code a été fixed


Drop use of the contour operator

Looks like we weren't using it in our kind e2e tests
/assign @carlisia

👍 thank you!
/lgtm
/approve


build: not relying on gax's zip archive

gax-java is now part of gapic-generator-java. No need to fetch
the released zip file to get the dependencies list.
In future, we'll revisit how we maintain the dependencies to
the user of gapic-generator-java, even for self-service users.

Unclear error.
2023-01-25T19:07:41.5888110Z [INFO] ------------------------------------------------------------------------
2023-01-25T19:07:41.5888197Z [INFO] Reactor Summary:
2023-01-25T19:07:41.5888262Z [INFO]
2023-01-25T19:07:41.5888507Z [INFO] GAPIC Showcase Client Core Parent 0.0.1-SNAPSHOT ... SUCCESS [  2.602 s]
2023-01-25T19:07:41.5888756Z [INFO] proto-gapic-showcase-v1beta1 0.0.1-SNAPSHOT ........ FAILURE [05:48 min]
2023-01-25T19:07:41.5888979Z [INFO] grpc-gapic-showcase-v1beta1 0.0.1-SNAPSHOT ......... SKIPPED
2023-01-25T19:07:41.5889176Z [INFO] GAPIC Showcase Client 0.0.1-SHAPSHOT ............... SKIPPED
2023-01-25T19:07:41.5889401Z [INFO] ------------------------------------------------------------------------
2023-01-25T19:07:41.5889482Z [INFO] BUILD FAILURE
2023-01-25T19:07:41.5889711Z [INFO] ------------------------------------------------------------------------
2023-01-25T19:07:41.5889800Z [INFO] Total time:  05:52 min
2023-01-25T19:07:41.5889962Z [INFO] Finished at: 2023-01-25T19:07:41Z
2023-01-25T19:07:41.5890184Z [INFO] ------------------------------------------------------------------------
2023-01-25T19:07:41.5890725Z [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.1.0:exec (verify-showcase) on project proto-gapic-showcase-v1beta1: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]

SonarCloud failed:
Error:  Failures:
Error:    BatcherImplTest.testThrottlingBlocking:897
Wanted but not invoked:
apiCallContext.withOption(
    <Capturing argument>,
    <Capturing argument>
);
-> at com.google.api.gax.batching.BatcherImplTest.testThrottlingBlocking(BatcherImplTest.java:897)
Actually, there were zero interactions with this mock.

[INFO]
Error:  Tests run: 529, Failures: 1, Errors: 0, Skipped: 0

Retrying.

~/gapic-generator-java $ bazel run //showcase:verify_grpc succeeded in my laptop. Strange.
@mpeddada1 @burkedavison  The failure is unclear. In another pull request, would you separate golden test and integration tests?

It turned out that the failure is about golden file. Not integration tests.


RE2 room 405 704 crashed

Version
3.1.8
Seed
R723-V318-ZXPH40N4XWY2M07N8MJ3BFAFZZZZZZZZZZZZZZZZZZPL8FVZZ
Scenario
RE 2 (Claire B)
Player Character
Jessica
What happened?
re2.405.zip

Connected 114:1 to 405:1 crashed.

Randomizing room 405 with enemy: Spider
Created 405:0 (0x0) [SPIDER,0,0,16,0] at (-19407,0,-958)
Created 405:1 (0x0) [SPIDER,0,0,16,0] at (-22889,0,-4513)
Created 405:2 (0x0) [SPIDER,0,0,16,0] at (-10420,0,-1680)
Created 405:3 (0x0) [SPIDER,0,0,16,0] at (-13899,0,-26161)
Created 405:4 (0x0) [SPIDER,0,0,16,0] at (-15118,0,-8628)
Created 405:5 (0x0) [SPIDER,0,0,16,0] at (-10143,0,-4327)
Created 405:6 (0x0) [SPIDER,0,0,16,0] at (-22889,0,-4513)
Created 405:7 (0x0) [SPIDER,0,0,16,0] at (-19407,0,-958)
Created 405:8 (0x0) [SPIDER,0,0,16,0] at (-10420,0,-1680)
Created 405:9 (0x0) [SPIDER,0,0,16,0] at (-15118,0,-8628)

703 to 704 crashed

Randomizing room 704 with enemy: G-Embryo
Created 704:5 (0x8) [G EMBRYO,3,0,20,0] at (1893,0,-24995)
Created 704:6 (0x1E) [G EMBRYO,3,0,20,0] at (-6096,0,-23251)
Created 704:7 (0x34) [G EMBRYO,3,0,20,0] at (5623,0,-22932)
Created 704:8 (0x4A) [G EMBRYO,3,0,20,0] at (-18730,0,-23845)
Created 704:9 (0x60) [G EMBRYO,3,0,20,0] at (12987,0,-21753)
Created 704:10 (0x76) [G EMBRYO,3,0,20,0] at (-11996,0,-25367)
Created 704:11 (0x8C) [G EMBRYO,3,0,20,0] at (-11523,0,-20965)
Created 704:12 (0xA2) [G EMBRYO,3,0,20,0] at (-11523,0,-20965)
Created 704:13 (0xB8) [G EMBRYO,3,0,20,0] at (-6096,0,-23251)
Created 704:14 (0xCE) [G EMBRYO,3,0,20,0] at (1893,0,-24995)
Created 704:15 (0xE4) [G EMBRYO,3,0,20,0] at (12987,0,-21753)
Created 704:16 (0xFA) [G EMBRYO,3,0,20,0] at (5623,0,-22932)

I wasn't able to reproduce this, possibly because when I generate that seed, I get different enemies in those rooms.


ForceEqualSignAlignment shouldn't use method definition in alignment

$ rubocop -V
0.36.0 (using Parser <IP_ADDRESS>, running on ruby 2.3.0 x86_64-darwin14)

# .rubocop.yml
Style/ExtraSpacing:
  ForceEqualSignAlignment: true

Running rubocop -a turns the following dfs method:
def dfs(node = @root)
  nodes = []
end

into this dfs method:
def dfs(node = @root)
  nodes      = []
end

Rubocop shouldn't take the method definition into consideration when forcing equal sign alignment. I can fix this by adding or modifying the .select statement within the def investigate(processed_source) method in extra_spacing.rb.

@alexdowad I think that one of the keys here is that, for reference of proper alignment, the cop needs to go up line by line until it gets to either:

a line of lesser indentation level as the current line
a line of the same indentation level as the current line

In that way, both of these (currently broken) cases will be caught:
Previous Line of Lesser Indentation Contains Token
class Foo
  def here_is_a_long_method_name(options = {})
    self.bar = 'cool'
    self.bazinga = 'sweet'
  end
end

Should be corrected to:
class Foo
  def here_is_a_long_method_name(options = {})
    self.bar     = 'cool'
    self.bazinga = 'sweet'
  end
end

Instead of:
class Foo
  def here_is_a_long_method_name(options = {})
    self.bar                             = 'cool'
    self.bazinga                         = 'sweet'
  end
end

Previous Line of Greater Indentation Does Not Contain Token
class Foo
  def bar(options = {})
    self.bazinga = {
                     one: '1',
                     two: '2',
                   }
    self.bar   = 'cool'
  end
end

Should be corrected to:
class Foo
  def bar(options = {})
    self.bazinga = {
                     one: '1',
                     two: '2',
                   }
    self.bar     = 'cool'
  end
end

Instead of:
class Foo
  def bar(options = {})
    self.bazinga = {
                     one: '1',
                     two: '2',
                   }
    self.bar = 'cool'
  end
end

@jfelchner Good points. But I wonder if the suggestion from @Dbz should also be heeded.
def method1(arg1, arg2 = :default); end
def method2(arg3 = :default); end

It would look pretty strange to align the equals signs in those arglists, don't you think?

@alexdowad in the rare cases where I have multiple single line methods, I dunno, I might actually like them aligned :grinning: but honestly I could go either way with whatever you decide. :+1:
You've been killing it lately man. Thank you so much for your work.

I agree with Alex that it might seem awkward to align the two methods- especially because you would be aligning the second parameter from method1 with the first parameter from method2.
I also think there might be a bug where calling rubocop -a fixes a lot of the equal sign alignment, but still throws the error of not being aligned.
I'd be happy to pair with you @alexdowad on working out a solution to fix these cops if you're up for it. It would give me better insight to the codebase.

I'd be happy to pair with you @alexdowad on working out a solution to fix these cops if you're up for it. It would give me better insight to the codebase.

Your suggested fix using .select will work fine. (It won't cover all the scenarios presented by @jfelchner, of course.) Would you like help on how to code the body of the select?

Oh, I can definitely do the rather simple select fix. I was talking about your approach by working upwards and tracking the bug where it says the lines are in violation after fixing them even though they aren't. I'll post a code example this weekend of that.

@alexdowad would there be any way, while you're in that cop, to make it handle my second use case above?  Where the cop looks at the token placement on the previous line of equal indentation?

@Dbz I re-read this issue and saw your example for the alignment of those method definitions with fresh eyes.  I didn't even notice that the first one had two arguments hahahaha  Definitely shouldn't align the equal signs on those. :wink:


Ionic serve does not recognise platform anymore

From @EmmanuelFRANCOIS on August 26, 2017 6:36
Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x] 3.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
When launching Ionic serve with the following command:
ionic serve --platform android --browser chrome
Platform reports that app is running on a desktop instead of a mobile...
this.platform.is('core') returns true
this.platform.is('mobile') returns false
this.platform.is('tablet') returns false
this.platform.is('phablet') returns false
This makes testing in browser difficult...
Expected behavior:
Platform should report:
this.platform.is('core') returns false
this.platform.is('mobile') returns true
this.platform.is('tablet') returns true
this.platform.is('phablet') returns true
Steps to reproduce:
Related code:
Other information:
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
cli packages: (C:\Users\OSCAR\AppData\Roaming\npm\node_modules)
@ionic/cli-utils  : 1.9.2
ionic (Ionic CLI) : 3.9.2
global packages:
Cordova CLI : 7.0.1
local packages:
@ionic/app-scripts : 2.1.3
Cordova Platforms  : android 6.2.3 ios 4.4.0 windows 5.0.0
Ionic Framework    : ionic-angular 3.6.0
System:
Android SDK Tools : 25.2.5
Node              : v6.11.2
npm               : 5.0.3
OS                : Windows 7
Copied from original issue: ionic-team/ionic#12758

Hello! Thank you for opening an issue with us!
This appears to be an issue with the Ionic app scripts, so I am moving this issue to the ionic-team/ionic-app-scripts repo.
Thank you for using Ionic


What is up with the github wiki?

I know there is a advanced rocketry documentation here, but why is there also the github wiki which seems to be very incomplete and useless?

The github wiki was made very early on, I had actually forgetten it even existed until you mentioned it.  Though going forward I'm not sure whether I should attempt to copy everything over or just remove the github wiki.  Probably the latter as I don't think the github wiki allows for nice formatting/generic HTML and CSS


Ability to log outlier event to stderr

Title: Able to log outlier event to stderr
Description:
We run envoy as sidecar and want to monitor outlier events. We already have the log shipper setup to read from docker container logs. Right now envoy supports configure the outlier event to a file sink, which needs to have additional log rotation and log shipping in place to read that information. It would be much more straightforward if the outlier events are also dumped into stderr so we can use the existing log shipping infrastructure.

Have you tried specifying the target of the file sink as /dev/stderr? This is typically supported for file outputs

Thanks @snowp for your quick response! Just tried and it is indeed able to send log to stderr.
Closing


error when pasted into console

Got this error when pasted into console
const cookie = document.cookie;
const serverUrl = "http://<IP_ADDRESS>:8080";

fetch(`${serverUrl}/set-cookie`, {
  method: "POST",
  headers: {
    "Content-Type": "application/json",
  },
  body: JSON.stringify({ cookie }),
})
  .then((res) => res.json())
  .then((res) => console.log(res))
  .catch((err) => console.log(err));
Mixed Content: The page at 'https://www.bing.com/search?q=Bing+AI&showconv=1&FORM=hpcodx' was loaded over HTTPS, but requested an insecure resource 'http://<IP_ADDRESS>:8080/set-cookie'. This request has been blocked; the content must be served over HTTPS.

This doesn't work because of limitation to send from https://bing.com (https environment) to non-secure http! Even the original example using http://localhost -- which is in most browser not handled strict for https<>http) didn't work for me on recent google-chrom(e|ium) Browser.
If you use this in your own app/implementation simply send the cookie yourself:
POST http://<IP_ADDRESS>/set-cookie
headers: [
'Content-Type' => 'application/json'
]
data: [
'cookie' => 'MUID=0883xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx'
]
then fetch identifiers:
POST http://<IP_ADDRESS>//create-conversation
and with that one should be able to enter into /generation identifiers even contain parameter conversationPath which seems to have relative url-path including all required parameters.
But at least with PHP/Laravel I'm still running into 200 OK, but NO DATA response.

Just noticed the last response for /generate was no json in my case:
data: [ERROR] Missing required parameters: conversationId, clientId, conversationSignature, text
data: [END]

So there's somewhere else the culprit for missing conversationSignature


improve swap left/right

When using node swap with direction, we want to be sure that we pick node that has

right sibling (when doing swap right)
prev sibling (when swap left)
This PR takes above into account.  Node under cursor that has no correct sibling will be ignored.

Thanks, this is a good fix! However, really quickly, could you format with 2 spaces indentation please?

It just seems I cant fix the indents.  It all look ok in nvim, but after coming all  spaces are converted to long tabs...
I tried different: ts, sw, sts settings no luck. I dont want spend 2 hours fixing spaces.... sorry :(

fixed after all.  Had to enable listchars to see what is going on. Kind of weird I could not spot tabs using arrows keys in edit mode.

Thanks, sorry about the inconvenience. I didn't want to overwrite ur contributions with a formatting commit. Also reminds me I should look into figuring out stylua/luacheck for CI.

Thanks! Sorry for getting to this late


[2pt] Add flag to optionally deleted intermediate inundation files

In the mapping/{huc}/{lid} are a bump of inundated images changed extent files. It is done to each branch, then merged to a single "extent" file for that {huc}/{lid}/{lid}_{magnitude}_extent.tif.  We obviously need to keep the final extent files per magnitude and not all of the branch intermediary files. Note: that system is now in but the code commented for version or two for tracing reasons. Maybe uncomment in the next HV 2.1.8 release (in a few months) to clean up all of those intermediate tif files as there is A LOT.  Update: We have commented out code in there to delete them, just make it driven by an arg to delete or not (default delete). Can helps with debugging during dev.
Add an argument in for deleting or not, default to delete. Nice to have when code/debugging and most of the code is there, easy to finish.

Held over and not included in CatFIM 2.1


Command wsl in admin mode dont'work (company computer)

Version
Microsoft Windows [version 10.0.19044.2006]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
2
Distro Version
No response
Other Software
No response
Repro Steps
i configure wsl by enable in this via DEP (i active the the virtual machine too )
Launch powershell in admin and write for example wsl --list --verbose , its say me nothing even if i write wsl.exe
Expected Behavior
i excepting to see for example a reponse of my command.
Actual Behavior
i receive nothing

Diagnostic Logs
No response

/logs


🐛 Bump coinbase-sdk version

Updated coinbase SDK version from 3.7.1 to 4.0.3

Closing as handled by https://github.com/devfolioco/siwe-oidc/pull/13


Role - permissions to be able to "Initiate Sign-out"?

Hi - which permission is required to be able to "initiate sign-out" from O365 Admin console?
https://docs.microsoft.com/en-us/microsoft-365/admin/add-users/remove-former-employee?view=o365-worldwide#sign-out-now
**

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4e366b9c-0d35-83c6-f509-1774dd351504
Version Independent ID: 702f2dc1-46f8-508a-68bc-b5d033c56a9a
Content: Remove a former employee - Microsoft 365 admin
Content Source: microsoft-365/admin/add-users/remove-former-employee.md
Service: o365-administration
GitHub Login: @KwekuA
Microsoft Alias: kwekua

@ii-batman  Thank you for your feedback. You need to be a Global Administrator to initiate sign-out. We have added a note to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/2482
Thanks
Sri

@msbemba  Thank you very much for the contribution and updating the documentation with PR. @ii-batman Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


How can I stop the camera in multi video?

I use session.disconnect() and then delete MultiVideo component from view to finish the call.
Even after that the camera is still on for android emulator.
So if I make another call, there occurs an error because it tries to start camera which is already on.
So when I finish calling, I want to stop the camera.
Is there any way to do this?

The way to do this is with the PublisherKit.onStop() method. This releases the camera.

@devwithzachary Solved it. Thank you.


Delete ControllerResource Kinds with ControllerInstallation

What this PR does / why we need it:
This PR makes Gardener deleting all ControllerResource Kinds in a Seed whenever the deletion of a depending ControllerInstallation is triggered. Thus, Gardener gives Extension controllers a chance to clean-up their resources before the controller itself is deleted.
This PR also adds a documentation for the Extension resource.
Release note:

NONE

Thanks for your reviews. PTAL.


Integrate Gasify with Browserify

Gasify will let us use require statements in our GAS code.

Closing, as all dev environment work has moved to New-Project-Template.


fixed flickering and wrong rendering of some dom elements

Browser was trying to set index.html itself as background image. That invoked a warning: Resource interpreted as Image but transferred with MIME type text/html: "file:///android_asset/www/index.html". For the time of downloading index.html there was a flicker and some elements was not renered properly.

I see. Thanks!