[Feature Request] Add remarks to parameters

I'd like to be able to add remarks to complex parameters for my endpoints, but currently, only the summary will show up. Unless I'm missing a particular setting?

Unlike it's Operation object, the Swagger/OpenAPI Parameter object only supports a single description field for entering descriptive text. For simplicity, I'd like to maintain a 1:1 mapping between XML Comments tag and Swagger/OpenAPI field as opposed to combining/formatting multiple tags into the one field. So, your request is not something I plan on adding to SB at this point.

Unlike it's Operation object, the Swagger/OpenAPI Parameter object only supports a single description field for entering descriptive text. For simplicity, I'd like to maintain a 1:1 mapping between XML Comments tag and Swagger/OpenAPI field as opposed to combining/formatting multiple tags into the one field. So, your request is not something I plan on adding to SB at this point.

I also really like this feature. But luckily, it could be added with a IParameterFilter ! (nice!)
See the code posted here:  https://stackoverflow.com/questions/60447302/how-to-show-remarks-in-swagger-documentation/73057660#73057660


Omniauth failed to detect the url -> Authentication passthru

Configuration

Provider Gem: omniauth
Framework: Rails 7

Problem and easy fix
I don't know why, but inside omniauth strategy, the current_path is always with double /
i.e. //users/auth/xxx instead of /users/auth/xxx
So it makes the method https://github.com/omniauth/omniauth/blob/66110da85e3106d9c9b138d384267a9397c75fe7/lib/omniauth/strategy.rb#L293-L295
always returning false. Then the middleware do not catch the route and it always ends up with Authentication passthru (note that is only hapenning on my production env, not on my local dev)
An easy fix is to change the method to following
to
def on_path?(path)
  current_path.squeeze("/").casecmp(path.squeeze("/")).zero?
end

I know this is probably a problem linked to my app, but I have struggling 4hours on this. It's a easy change that could save time for others
Thank you !
Sebastian
Ps: sorry I have been lazy for not submitting a PR for such small change

Just to +1 this, such a messy bug to catch. My setup was a NGINX proxy_pass in a Dockerfile routing /api to http://rails:3000/.
The bug is that in NGINX if your location /api/ { line doesn't END(!!!) with a tailing-slash, then the trailing slash isn't removed when it's passed to Rails, meaning that Omniauth see's //users/auth/microsoft_graph_auth which it declares as invalid. Jury's out on whether that's right or wrong given technically they are two different URLs, but yeah.
Either way, half my weekend spent on a missing /.


[Bug] IE throws TypeError in destroyed hook in Vue components using vue-apollo

Am running into a couple errors when using Vue Apollo in IE (in Chrome everything runs smoothly):

Right now I'm getting an error in IE when removing a Vue component that is using vue-apollo. Specifically, it is happening if I have an apollo object on data like so: https://github.com/Akryum/vue-apollo#usage-in-components, and the error is [Vue warn]: Error in destroyed hook: "TypeError: Object expected". It's been tough debugging Vue-apollo code to figure out where exactly the error is getting thrown because I'm not super familiar with the implementation of vue-apollo, so any suggestions on lines of code I can put breakpoints that are related to cleaning up vue apollo would be super helpful, thanks! Or if you know what is going wrong, that'd also be great.

I am also getting a TypeError in this line of graphql in IE (and I suspect any browser that only supports ES5):
https://github.com/apollographql/apollo-client/blob/master/packages/graphql-anywhere/src/graphql.ts#L138. The TypeError is Object.keys argument is not an object and is because fieldResult is sometimes a string (from what I've seen, it's usually the name of a query in start casing so if in my component I have this in the apollo object:

apollo: {
 myQuery: gql`some valid query`
}

I put a breakpoint inside the graphql-anywhere code I linked above and see that 'fieldResult' is the string 'MyQuery', and then inside of the merge function, it calls Object.keys('MyQuery') which throws errors in IE, because ES5 doesn't support this: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/keys.
I only get this second error when I use vue-apollo in my Vue components, it works fine when using apollo client directly. I didn't do much digging past that, wanted to know if other people have been experiencing this in IE or could point me in to how I can debug further. Thanks!

Update: My second bug has been fixed in the latest version of graphql-anywhere that just got released (4.1.10). Here is the commit fixing it: https://github.com/apollographql/apollo-client/commit/1677bb3b31a2ac3e622b8e0069cf9eed2458c1c3

Is this still happening?

@Akryum The first bug still happens [Vue warn]: Error in destroyed hook: "TypeError: Object expected for me in IE, although I locked down my verison to beta.5 because there were some outstanding issues on versions after that version. Do you know if you've fixed the issue in a more recent release?
Otherwise, do you have a jsbin or codepen with necessary Vue-apollo boilerplate that I can use to create a reproducer? If not, I can probably see if I can create one  and I'll comment back here with it.

You can use vue-cli-plugin-apollo to have a project with Vue and Apollo ready in matter of minutes.

@Akryum The first bug still happens to me [Vue warn]: Error in created hook: "TypeError: Object expected" in IE 11. I am using vue-apollo beta.19 version. I did a little bit investigation by looking into the source code. I think the line 542 in vue-apollo.esm.js is where the error comes from. I think some how handlers[Symbol.iterator] in that loop return undefined in IE 11 while it return a function in Chrome. I have the es6-symbol polyfill setup but it looks like not fixing this problem. Ps: I also upgrade my vue-apollo to the latest version beta.28 but it not fix this issue.

Any updates on this?


arangodb cluster read speed problems with authentication mode

my environment running ArangoDB
I'm using the latest ArangoDB of the respective release series:

[ ] 2.8
[ ] 3.0
[1 ] 3.1
[ ] 3.2 pre-releases: ___
[ ] self-compiled devel branch

On this operating system:

[1 ] DCOS on

[ ] AWS
[ ] Azure
[ ] own infrastructure

[ ] Linux

[ ] Debian .deb
[ ] Ubuntu .deb
[ ] SUSE   .rpm
[ ] RedHat .rpm
[ ] Fedora .rpm
[ ] Gentoo
[ 1] docker - official docker library
[ ] other:

[ ] Windows, version:
[ ] MacOS, version:

this is an AQL-related issue:
[ ] I'm using graph features
I'm issuing AQL via:

[ ] web interface with this browser:     running on this OS:
[ ] arangosh
[ ] this Driver:

I've run db._explain("<my aql query>") and it didn't shed more light on this.
The AQL query in question is:
The issue can be reproduced using this dataset:
Please provide a way to create the dataset to run the above query on; either by a gist with an arangodump, or `db.collection.save({my: "values"}) statements. If it can be reproduced with one of the ArangoDB example datasets, it's a plus.
Foxx
this is a web interface-related issue:
I'm using the web interface with this browser:     running on this OS:

[1 ] authentication is enabled?
[1 ] using the cluster?
[1 ] _system database?

These are the steps to reproduce:

Install arangodb3.1.15 with the dcos 1.8.8
add a collection about 111k size, and install a service designed for testing download speed.
when i used the default seting which doesn't enable arangodb-jwt-secret, the maximum download speed is proportional to the coordinator number. And the download speed with just one client is equal to the arangodb standalone mode. It's great.
However, when I enable the "arangodb-jwt-secret" and do the same experiment, the maximum download get a half discount. Also it's never relative to the coordinator number.  I would be thankful if
you talent will solve it soon! Thanks!

The following problem occurs: [Screenshot?]
Instead I would be expecting:
this is an installation-related issue:
Describe which steps you carried out, what you expected to happen and what actually happened.

Can you give us some hard numbers on this? It seems rather strange because the coordinators won't talk to each other. So to me it seems surprising that the number of coordinators should play any role in this issue.
Also the jwt authentication should not influence any download speed issues. How are you accessing arangodb? Is it through the DC/OS frontend? Please note that there are several components from DC/OS involved before it is even making it to arangodb.
Can you give us some more details on your setup (especially how you are accessing your foxx application?)
Also can you put up an example which is accessing ArangoDB from within the DC/OS cluster without any Mesos DNS etc. So something which would access the coordinator IP and port directly and give us some numbers?

We're pleased to anounce that ArangoDB 3.2 containing lots of improvements to the clustering.
Closing this ticket since feedback has been missing.


RFC Support capture events, fix custom events, support on/onCapture

Support capture events
Events like onClickCapture are present in typings, but weren't working. PR add support for Capture variants.
Fix custom events
Currently custom events are not working, seems like if was improperly copied in #38
https://github.com/proteriax/jsx-dom/blob/35d58db68c783d3ab2f7a84abec90bc5f22a92a6/src/jsx-dom.ts#L298-L306
This PR brings back addEventListener. If it'd working properly before, this would also introduce breaking change - now events are registered as lowercase and without on, but custom events were not working anyway (onCustomEvent was assigned to element.oncustomevent instead of calling addEventListener).
Support on/onCapture
To properly support custom event I'm proposing 2 new properties on and onCapture. Every key is added as-is, so user have full control of event name. Standard events are supported in lowercase form - as expected. These are always registered using addEventListener - this is good compromise for people who don't want to use element.onclick properties. onClick handlers are left for people like OP from #17 . Also this should fully satisfy #33
Look at tests for examples.

why not use key.startsWith('on') ?

why not use key.startsWith('on') ?

@adminy This was already present in code, but my guess is performance optimization or compatibility or no reason at all.

Is this PR likely to be merged anytime soon?

@DojoEnglish No, do you have a use case for this?

@alex-kinokon nice to hear after a year that there is a problem with PR.
@DojoEnglish I'm using patch-package to fix issues, which are ignored by author.

Same reason as the initial comments for this PR, I'm looking to support custom events, as a workaround for now I've had to manually add an event listener


Make handing of "os" dimension for linux bots consistent with other OSes

The "os" dimension in recipes are misconfigured for linux bots, and inconsistent with the way we refer to bots of other OS types. Need to make it consistent.
This was brought about with a recent change to use device_doctor for handling dimensions, which now correctly labels the "os" dimension as "Debian" for linux bots, as opposed to the previous "Android" value.

https://flutter-review.googlesource.com/c/infra/+/18441 modifies the staging config to be consistent.
The prod config will need to be coordinated with a change to use device_doctor in bot_config, and change prod builds (https://cs.opensource.google/flutter/flutter/+/master:.ci.yaml;l=50) to specify appropriate value for "os".

This is now complete.


[Linux] "mousedown" event of the left mouse button is only fired when the mousebutton is released

On Linux, for the left mouse button, the mousedown event is only fired when the button is being released.
For the right and middle mouse button, it works correctly.

Hi there, we're happy to help ! Could you please use our template so we can try to figure it out ?


Update provider libraries to download tarball vs cloning a git repository

Downloading the archive vs cloning the repository is a detail of the provider I think it would be nice to configure or change altogether.
In fact, using the archive link may be the better route for all deploys. The reason being is you can download a 3GB git repo as a 25MB tarball a lot faster.

One area where this is advantageous to clone is frequently deploying and reusing the same checkout. Perhaps we should try the --depth command ` (link)

But the same tarball and even the same extracted tarball can be reused just the same.

Yup, they will be but small changes between deployments will end up being more costly by checking out new revisions rather than a fetch and hard reset to the specific sha.
Wanna whip up a PR and we can look at it more closely?

Right, that's certainly a disadvantage. But, probably not a big one. Let's examine the scenarios.
If you have a small repository anyways then the download time is negligible, about as negligible as a git connection and fetch.
If you have a large repository, then it should be obvious an archive link would be advantageous.
It might look something like this provider.

The bundler capistrano provider will also have the drawback of rebundling on each new tarball download, often really time/resource expensive, which will slow down your deployments.

Again, I don't think there are any extra cpu cycles offered by the tarball approach.
On heroku everyting in /tmp is gone after reboot or dyno cycling which happens once or twice a day. So, the system should work fast in the worse case scenario more often.
That being said, we're looking at exactly the same time for cached git repositories or tarball downloads once git fetch or curl has been run. Once gems are installed, they are simply installed and bundle install runs bundle check and exits very quickly.

Can you make a PR for this?

Yes.
On Wed, Jun 24, 2015 at 12:42 AM Corey Donohoe<EMAIL_ADDRESS>wrote:

Can you make a PR for this?
—
Reply to this email directly or view it on GitHub
https://github.com/atmos/heaven/issues/148#issuecomment-114663959.


CMake flags cleanup

Scope & Purpose
This PR cleans up the cflags and cxxflags used for building arangod and the client tools.
It removes the duplicate usage of the same flags inside each compile command, which previously happened because we set CMake options like as follows:
    CMAKE_CXX_FLAGS=-Wall -Wextra ...
    CMAKE_CXX_FLAGS_DEBUG=${CMAKE_CXX_FLAGS} ... (more flags)
    CMAKE_CXX_FLAGS_RELEASE=${CMAKE_CXX_FLAGS} ... (more flags)
    CMAKE_CXX_FLAGS_RELWITHDEBINFO=${CMAKE_CXX_FLAGS} ... (more flags)

As can be seen, the CMAKE_CXX_FLAGS were copied into the build type-specific flags CMAKE_CXX_FLAGS_DEBUG, CMAKE_CXX_FLAGS_RELEASE, CMAKE_CXX_FLAGS_RELWITHDEBINFO etc.
However, CMake automatically concatenates the base flags in CMAKE_CXX_FLAGS with the build-type specific flags in CMAKE_CXX_FLAGS_${CMAKE_BUILD_TYPE}, so we were effectively seeing the base flags multiple times on each
compiler invocation.
In addition, this PR introduces a new CMake option USE_MINIMAL_DEBUGINFO.
This option is turned off by default. If turned on, the created binaries will contain only a minimum amount of debug symbols, reducing the size of the executables. If turned off (which is the default), the binaries will contain full debug information, which will make them bigger in size unless the debug information is later stripped again.
Finally, the PR turns on the -Wsuggest-overrides flag for g++, which will warn about missing override specifiers. Note that this will make future build fail when compiling with USE_FAIL_ON_WARNINGS=On.

[ ] :hankey: Bugfix
[x] :pizza: New feature
[x] :hammer: Refactoring
[x] :book: CHANGELOG entry made
[x] :muscle: The behavior in this PR was manually tested
[x] :computer: The behavior change can be verified via automatic tests

Backports:

[x] No backports required

Testing & Verification
Compilation must still succeed, even with new warnings turned on.
http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/12438/

Tests blue

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/12497/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/12504/


Add docopt.sh option: DOCOPT_OPTIONS_FIRST=true

This will allow to use resticw as a true wrapper, enabling to pass
restic options through it, for example:
resticw --profile profileX snapshots --compact

will now be suported by the wraper :)
Relates to https://github.com/erikw/restic-automatic-backup-scheduler/pull/71

Great! I tried it out -- works :)


Question for implicit cast in table action

I have a question about implicit cast in table action.
In P4 spec, I saw P4 example code below.
action a_params(bit<9> x) { standard_meta.egress_spec = x; }
/* omitted */
const entries = {
(0x01, 0x1111 &&& 0xF) : a_params(1);
It seems implicit cast is allowed for action arguments. But I couldn't find description for this. I found this instead.
At 8.20. Method invocations and function calls,
The compiler only inserts implicit casts for direction
in arguments to methods or functions as described in Section 8.11. The types for all other arguments
must match the parameter types exactly.
So, even though action is a kind of function, does it not follow that explanation, but it allows implicit cast for all arguments?

Section 8.20, as implied by its title, is restricting its attention to method calls and function calls, and does not have anything to say about action calls.
See Section 8.11.2, where it says:
"To keep the language simple and avoid introducing hidden costs, P4 only implicitly casts from int to fixed-width types and from enums with an underlying type to the underlying type."
In the example you show, 1 has type int, and it is being implicitly cast to a fixed-width type, bit<9> in your example.

I got confusion between action calls and function calls. Thank you for ypur answer!


'PATH' feature requires a reboot. The MSI installer should therefore set a ScheduleReboot after InstallFinalize

'PATH' feature requires a reboot. The MSI installer should therefore set a ScheduleReboot after InstallFinalize
OS & version Windows 10/11
MSFT Build of OpenJDK Version: 21.0.4
To Reproduce:
Steps to reproduce the behavior:

Download OpenJDK MSI
Install MSI with default options ('PATH' feature is selected)
See that no reboot is scheduled

Expected behavior
A reboot should be scheduled when installing the 'PATH' feature.
Screenshots, Logs etc
None
Additional context
To confirm that the PATH variable has not updated after installation, run psexec -s cmd /c set PATH and inspect the output.

Isn't there a WM_SETTINGCHANGE message posted to indicate that the system environment variables changed? But I suppose window messages cannot be received by noninteractive services like whatever PsExec is using.

Good question! I will verify the WM_SETTINGCHANGE. I suppose WM_SETTINGCHANGE is something that is related to interactive desktop session?
the psexec -s simulates my actual use case by running a new process under the service manager (inside svchost.exe). The service manager is the component that will only get a copy of the full new environment after a reboot.
I just looked up WM_SETTINGCHANGE and that is a Desktop application message from winuser.h, so yeah it only affects desktop applications. Not many Java applications are desktop applications in my experience (but I could be wrong)

Good question! I will verify the WM_SETTINGCHANGE. I suppose WM_SETTINGCHANGE is something that is related to interactive desktop session?

I confirmed that WM_SETTINGCHANGE works fine for desktop applications. Any newly spawned process that the current logged in user's shell launches will have an up-to-date copy of the system environment.
So, in summary, the WM_SETTINGCHANGE works of a very specific scenario which is interactive desktop java applications on a physical desktop (WM_SETTINGCHANGE won't work on Terminal Server I believe. From past experience Terminal Server session like used by RDS are children of a System service and they inherit the system environment from the Terminal Server service)
My specific use case is that I am distributing a Java application that runs as a service on Windows.
When my customers perform the OpenJDK installation and my Java application MSI installation without performing a system reboot, they will see an error in the eventlog from my Windows Server wrapper (which is responsible to spawn a java.exe -jar) that java.exe is not on the PATH.
Which is confusing for my customers because they won't be aware of these intricacies of how the system environment works in Windows and it won't be obvious to them that a simple computer reboot is required.

@brunoborges & @d3r3kk for triage

Same issue as adoptium/installer#133

One potential workaround (in the interim) could be to have the service's installer install the JDK and then dictate this behaviour, but that may not be applicable to every scenario either.

Yes. I did consider something like this.
I'm not overly in love with that idea though. It seems that this would make my installer much smarter than it needs to be. I do prefer to have installers to be independent and composable and not have to know anything about external dependencies.

Can you make the wrapper use OpenProcessToken and CreateEnvironmentBlock to get the updated PATH environment variable, and use that when starting the java.exe process?

Thanks @KalleOlaviNiemitalo , I will need to investigate that option. My wrapper is a Golang app and currently uses the exec package of the Go std library. My gut feel is that I probably would need to look at CFFI for this functionality. I'll have a look and see if that might be an option.


General: improve dialogs' data persistence

Currently only "Migrations project" and "Startup project" are persisted.
Need to extend these data for common options used in almost all dialogs and dialog specific ones:
From suggestion #46

Common (per startup project)

Target framework

Common (per migrations project)

DbContext class

Add migration (per migrations project)

Migrations folder

Update database (per migrations project)

Connection

I've possibly come up with a solution for at least the Scaffold DbContext dialog if you'd be interested in it.  It doesn't cover the Build Options tick at the bottom as that's inherited from the DialogWrapper, but the rest of the fields are holding values.

@t3mp0ralflux thanks! You could create a PR with your suggestion if you want. BTW do we really need to persist data from Scaffold Database runs? I'm not sure that it will be executed often.

So with the way I and others I work with use the plugin, we have one base project at work and each ticket usually requires a re-scaffold based on the ticket requirements.  It's nice to not have to re-enter all the info every time I have to do this process, hence the persistence.  I'll put a PR up once I can prove to myself that I didn't break anything along the way.

We actually do "database first" and every database change is actually done in the database, then scaffolded, and then we create a migration off the new scaffolding.  In our case, it is run very often.  We have a powershell script that automates it, but I'm sure it would be nice for others that do the same.


Is this project abandoned?

What happened:
No commit has been checked into main for 8 months. There's plenty of open issues with little to no progress and many open PRs, some with trivial changes, others with bigger features. Many of them untouched for months
What you expected to happen:
There's three main scenarios, which one you choose (if any at all) is of course completely up to you. I'm just laying out the options I see.

Someone should appoint one (or preferably multiple) new maintainers and hand dive over to them to ensure dive is revived.
Make it official and archive the repository. If a well-maintained fork exists I please point to it as the de-facto successor in the README. In any case please add at least the info/warning/banner about the project being archived to the README.
The current maintainer(s) could pick up the PRs and issues that exist and merge quality PRs or request changes where necessary. If you don't have time for implementing new features maybe reviewing PRs is still manageable

How to reproduce it (as minimally and precisely as possible):
Not applicable, I'd rather not reproduce this scenario in the futre
Anything else we need to know?:
dive is pretty good IMO, but it still lacks a little polish and some quality of life feature. I'd hate to see it go the way of the dodo as there's no alternative TUI with similar functionality

https://github.com/wagoodman/dive/issues?q=is%3Aissue+is%3Aopen+abandoned
https://github.com/wagoodman/dive/issues/388 points towards a more active fork https://github.com/jauderho/dive

Thanks, I'm aware of that fork. There's little to no feature development going on there, mostly just dependency version bumps from what I gather. Better than nothing and definitely appreciated, but I wouldn't call that actively maintained

tl;dr: yes

tl;dr: yes

it's a bit sad to learn this 😢

I was a bit annoyed with Dive not working properly on macOS with Apple Silicon, so I created a fork and applied some of the open PRs from this repository.
See https://github.com/joschi/dive/releases/tag/v0.13.1 for the latest release.
Disclaimer: I really don't want to maintain the fork and would be much happier if @wagoodman would incorporate the changes here, in the upstream repository.
Alternatively, it could move to a dedicated GitHub organization and add more maintainers. 🤷

@joschi I'm willing to be a maintainer as I'd like to see this project garner more traction. As to moving it to a dedicated GitHub organization, happy to discuss this as well.

@joschi thanks for forking&fixing dive. It wasn't working at all for me on my M1.


BaseModel constructor is not documented

https://pythonhosted.org/Flask-SQLAlchemy/api.html#flask.ext.sqlalchemy.BaseQuery has no documentation for BaseModel constructor. This:

makes it unclear how to write BaseQuery derivative classes
makes it unclear how to instantiate BaseQuery or derived class instances

I'm not exactly clear what you're asking for, but I've cleaned up the docs for BaseQuery and Model.  Typically, you don't instantiate these things yourself, although you can subclass both of them just like normal classes.


FormArray value is List<String?>?

Hi @joanpablo
The FormArray element has default type like List<String?>?
Isn't it enough to make it List<String?>.
The [] empty array and null has the same meaning in case of array of items - no value.

Hi @vasilich6107,
Sorry, but I didn't get you. Could you give me more details?


Can't use MicroRos Custom Messages on STM32H723ZG

Hi everyone,
after months of excruciating pain and panic attacks and many kilos gained by stress eating, I managed to have microros running on my H723ZG nucleo: this however is true only with standard messages. Countless hours have now been wasted on trying to make custom messages work, to no avail. I already have the custom messages definitions ready, can even create a ros2 pub node to send them and I can even see them through a quick ro2 topic echo, but I can't for the life of me get this onto my stm32 board and I have lost all hope completely.
Do you maybe happen to know some insights, or maybe a procedure I could follow? Really, anything would help.
I just want to clarify that, since I have to use the .ioc, my only way is using the Stm32CubeIDE to create a project, and then find some sort of satanic ritual to bring custom messages to the project.

Hello @antoniocaso, sorry for the big inconvenience micro-ROS is causing, usually is preferable to not deal with embedded libraries nor cmake/python mixtures of build system... xd
Now seriously, I assume that you have tried the following: https://github.com/micro-ROS/micro_ros_stm32cubemx_utils?tab=readme-ov-file#adding-custom-packages
Normally this part of the build script is in charge of copying the ROS 2 message packages that you have in the library_generation/extra_packages folder. Once they are copied along with the rest of the micro-ROS packages they are built together. It seems that you are building correctly the builtin set of packages, so this shall be a matter of checking if this part is copying your custom packages to the correct folder.
As far as this procedure normally run inside a docker, make sure that volumes are being shared correctly:

docker pull microros/micro_ros_static_library_builder:jazzy && docker run --rm -v ${workspace_loc:/${ProjName}}:/project --env MICROROS_LIBRARY_FOLDER=micro_ros_stm32cubemx_utils/microros_static_library_ide microros/micro_ros_static_library_builder:jazzy

Let me know if you find something.

Hi Pablo, and thank you so much for your help! Sorry for not replying earlier!
I’ll try to be as clear as possible, and forgive me if I lack expertise on the subject.
Yes, I confirm that I tried taking the package with the messages and copying it into the "extra_packages" folder located inside the CubeIDE project folder. I’m using this project creation method because I not only need the IOC file but I’m also working on the Nucleo H723ZG as my platform. Here’s the tree starting from the ros2_ws/src/ folder, which contains all the messages.
antonio@antonio:~/prova/ros2_ws/src/custom_microros_msgs$ tree
.
├── CMakeLists.txt
├── include
│   └── custom_microros_msgs
├── msg
│   ├── StmToUbuntuMessage.msg
│   ├── UbuntuToStm32Arbiter.msg
│   └── UbuntuToStm32Info.msg
├── package.xml
└── src
4 directories, 5 files
I copy this in the extra_packages folder, then try to run, and then nothing happens at all, like nothing was ever moved there. Here, this is the path
/home/antonio/STM32CubeIDE/workspace_1.16.1/h723_microros_pt6/micro_ros_stm32cubemx_utils/microros_static_library_ide/library_generation/extra_packages
├── custom_microros_msgs
│   ├── CMakeLists.txt
│   ├── include
│   │   └── custom_microros_msgs
│   ├── msg
│   │   ├── StmToUbuntuMessage.msg
│   │   ├── UbuntuToStm32Arbiter.msg
│   │   └── UbuntuToStm32Info.msg
│   ├── package.xml
│   └── src
└── extra_packages.repos
And I also copy the message package in the other extra_packages under the microros_static_library (not _ide) folder just to be sure, but alas nothing.
Unfortunately, I am forced to do this blend because I will need to interface an SRR520DI sensor with this board, use its FDCAN port to retrieve data from it, process the data, and then send custom messages to the onboard computer of an autonomous vehicle using micro-ROS. On the PC, there will, of course, be a standard ROS 2 setup, which the board will interface with thanks to the essential agent.
So, as I was saying, I confirm that I tried pasting it into that folder and building it using the command you provided, modified for Humble:
docker pull microros/micro_ros_static_library_builder:humble && docker run --rm -v ${workspace_loc:/${ProjName}}:/project --env MICROROS_LIBRARY_FOLDER=micro_ros_stm32cubemx_utils/microros_static_library_ide microros/micro_ros_static_library_builder:humble VERBOSE=1
Actually, I’ve been dedicating myself entirely to trying to get all this to work for several days now, trying every possible method, starting with simply taking the headers and .a files (and unfortunately, even with .a, I’ve encountered endless problems since the simple colcon build only gives me .so files. To get .a files, I had to struggle quite a bit, and I ended up with FastRTPS files, which I’m not even sure are suitable. As expected, I ran into even more issues there).
By doing this I actually even managed to get things to build, but only when no "elements" of the library where used in the code, but if I dared to use the library it would tell me the type support .c was missing, even though the headers were all being seen correctly.
Unfortunately, all my efforts have been unsuccessful, and I’m now out of tears to shed. This is just a small part of my thesis project, which will require months and months of more struggles like this… and this one alone seems never-ending.
If you need anything—any clarification, anything at all—I’m entirely at your disposal and immensely grateful for any time you dedicate to helping me.

Could you please:

Remove the micro_ros_stm32cubemx_utils folder from your repo, to start from a clean start point.
Ensure there is no libmicroros.a or micro-ROS include folder anywhere in the project.
Clone the repo in the project as stated here
Copy your custom message package to the required folder
Continue the instructions

And paste here the output of the console so I can look at what is happening.

Hello @pablogs9 ! Thank you for your VERY PRECIOUS help!! Sorry if I took some time but I wanted to make everything right and clean and so I created a new project and a new custom message folder and all. Well, let's get to it.
This is tree command done to the project's folder in order to check if nothing regarding microros was present at all.
Then, I created a whole new, simpler custom message package (just one .msg to now over-complicate things) separately, namely on my Desktop for easy access, by doing this sequence of actions:

ros2 pkg create --built-type ament_cmake custom_msg
cd custom_msg
mkdir msg
gedit MyCustomMessage.msg and this is the cat of the file:
antonio@antonio:~/Desktop/not_custom_msg/custom_msg$ cat msg/MyCustomMessage.msg
float32 throttle
float32 brake

Then I modified the CMakeLists.txt and package.xml as by the instructions given here: https://micro.ros.org/docs/tutorials/advanced/create_new_type/
and the result is:
----#----#----#----#----#----#----#----#----#----#----#----#----#----#----#----#----#----#----#----#----#----#----#----#----#
CMakeLists.txt
cmake_minimum_required(VERSION 3.8)
project(custom_msg)
if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
add_compile_options(-Wall -Wextra -Wpedantic)
endif()
find dependencies
find_package(ament_cmake REQUIRED)
find_package(rosidl_default_generators REQUIRED)
uncomment the following section in order to fill in
further dependencies manually.
find_package( REQUIRED)
rosidl_generate_interfaces(${PROJECT_NAME}
"msg/MyCustomMessage.msg"
)
if(BUILD_TESTING)
find_package(ament_lint_auto REQUIRED)
the following line skips the linter which checks for copyrights
comment the line when a copyright and license is added to all source files
set(ament_cmake_copyright_FOUND TRUE)
the following line skips cpplint (only works in a git repo)
comment the line when this package is in a git repo and when
a copyright and license is added to all source files
set(ament_cmake_cpplint_FOUND TRUE)
ament_lint_auto_find_test_dependencies()
endif()
ament_package()
----#----#----#----#----#----#----#----#----#----#----#----#----#----#----#----#----#----#----#----#----#----#----#----#----#
package.xml

custom_msg
0.0.0
TODO: Package description
antonio
TODO: License declaration
<buildtool_depend>ament_cmake</buildtool_depend>
<test_depend>ament_lint_auto</test_depend>
<test_depend>ament_lint_common</test_depend>
<build_depend>rosidl_default_generators</build_depend>
<exec_depend>rosidl_default_runtime</exec_depend>
<member_of_group>rosidl_interface_packages</member_of_group>

<build_type>ament_cmake</build_type>

Then, after saving, I took the custom_msg folder and pasted it inside microros_static_library/library_generation/extra_packages/
This is the tree command from the not_custom_msg folder that contains the actual "custom_msg" package.
antonio@antonio:~/Desktop/not_custom_msg$ tree
.
└── custom_msg
├── CMakeLists.txt
├── include
│   └── custom_msg
├── msg
│   └── MyCustomMessage.msg
├── package.xml
└── src
5 directories, 3 files
And, after doing so, this is the tree from inside the microros_static_library folder:
antonio@antonio:~/STM32CubeIDE/workspace_1.16.1/h723_microros_pt7/micro_ros_stm32cubemx_utils/microros_static_library$ tree
.
└── library_generation
├── colcon.meta
├── extra_packages
│   ├── custom_msg
│   │   ├── CMakeLists.txt
│   │   ├── include
│   │   │   └── custom_msg
│   │   ├── msg
│   │   │   └── MyCustomMessage.msg
│   │   ├── package.xml
│   │   └── src
│   └── extra_packages.repos
├── library_generation.sh
└── toolchain.cmake
7 directories, 7 files
Having already set up the build settings, and having already pasted to the freertos.c the contents of the simple_main.c in order to get microros actually running, I started the "build project" command, and attached to this reply is the build_output plain text file which is what the console on Stm32CubeIDE gave me when trying to build.
Also I want to clarify that trying to do #include "custom_msg/..." results in build error as the .h can't be seen or found, and it's especially mind-breaking the fact that the build didn't even give an error, it just... ignored completely the package I copied, didn't even give me the honour of refusing, just ignored me.

Having already set up the build settings, and having already pasted to the freertos.c the contents of the simple_main.c in order to get microros actually running, I started the "build project" command, and attached to this reply is the build_output plain text file which is what the console on Stm32CubeIDE gave me when trying to build.

Nothing attached

Having already set up the build settings, and having already pasted to the freertos.c the contents of the simple_main.c in order to get microros actually running, I started the "build project" command, and attached to this reply is the build_output plain text file which is what the console on Stm32CubeIDE gave me when trying to build.

 I edited the reply, it should be at the top of my message now.

It seems that you folder is not being copied, could you add some debug echo commands here and rerun the whole procedure to check what is happening? Something like:
# Import user-defined packages
echo "Starting to import user-defined packages..."
mkdir extra_packages
echo "Created 'extra_packages' directory."

pushd extra_packages > /dev/null
echo "Switched to 'extra_packages' directory."

USER_CUSTOM_PACKAGES_DIR=$BASE_PATH/../../microros_component/extra_packages
echo "USER_CUSTOM_PACKAGES_DIR set to: $USER_CUSTOM_PACKAGES_DIR"

if [ -d "$USER_CUSTOM_PACKAGES_DIR" ]; then
    echo "Copying contents of $USER_CUSTOM_PACKAGES_DIR to current directory..."
    cp -R $USER_CUSTOM_PACKAGES_DIR/* .
else
    echo "Directory $USER_CUSTOM_PACKAGES_DIR does not exist. Skipping copy."
fi

if [ -f $USER_CUSTOM_PACKAGES_DIR/extra_packages.repos ]; then
    echo "Found extra_packages.repos in $USER_CUSTOM_PACKAGES_DIR. Importing..."
    vcs import --input $USER_CUSTOM_PACKAGES_DIR/extra_packages.repos
else
    echo "No extra_packages.repos found in $USER_CUSTOM_PACKAGES_DIR. Skipping vcs import."
fi

echo "Copying library generation packages..."
cp -R $BASE_PATH/library_generation/extra_packages/* .

if [ -f extra_packages.repos ]; then
    echo "Found extra_packages.repos in the current directory. Importing..."
    vcs import --input extra_packages.repos
else
    echo "No extra_packages.repos found in the current directory. Skipping vcs import."
fi

popd > /dev/null
echo "Returned to the previous directory."
echo "Completed user-defined packages import."

Ok @pablogs9 , I'm back with some... interesting news on all fronts: sorry for not replying these past few days, but a lot of interesting things have popped up.
First of all, before I tried implementing what you suggested, I tried to create an online repo ad put my custom messages package there, you know, just for shits and giggles cause I had seen that also "control_msgs" was being included this way, and so I gave it a try with absolutely zero hope it would work... well fuck, it did.
At that point then I tried to create another project from scratch, same Ide same workspace same everything and same procedure, I did this like the same day so everything in my mind was absolutely the same. This time, instead of using the extra_packages.repo and the online ad-hoc created repo, I just copied and pasted the packages like I had tried (and failed) the first time, always sticking to both your advices and the official procedure on the repo.
This time, with no online repo, worked as well! At that point I thought "maybe it was the fact I did not enable the REENTRANT option for the freertos middleware in the ioc", and so I created yet ANOTHER project, from scratch, and did the exact same completely identical setup and procedure as the first time where things where not working the build process was ignoring the extra_packages: this time it ALSO worked.
I mean, maybe you won't believe all of this, but I swear to God this is completely nuts and I have no idea why, and its part of the reason why I haven't replied in the past few days, I've been trying to uncover this mistery, alas with no success.
Still though, I added the code you told me to add to the library_generation.sh, so I will still provide the build output as attached. Since I didn't change anything at all, both the CMakeLists.txt and package.xml of the custom message package are still the same, and the folder's paths and all are still all the same. I will also provide the main.c and freertos.c files though, maybe something there has been getting things to work.
build_output.txt
freertos.c.txt
main.c.txt
On a footnote, many other warfronts have sadly opened up, all regarding microROS I'm afraid (like the code working absolutely fine in flash mode, but debug mode completely makes the board invisible to the microROS agent on my pc): do I open another thread or do I just stick with this one?

Nice to know that you managed to solve it.
Please open new issues for new problems you have with the library.
I'm closing this as solved.


API to capture and apply captured state.

Since we pipe all changes through our model, we can expose API that can let user capture and apply captured state.
That can be helpful for state save/restore, reproducing UI from bug reports, etc.

To keep this thing efficient, we don't want to observe all properties and only capture the state of those that are programmatically changed (including some properties like CheckBox.checked that can be changed by user interaction).
The state object will be produced on demand, so we're not re-allocating on every property update. Properties that were not changed programmatically or by user will be null which is type-safe thanks to Kotlin.
Most of the bits are actually already there for this, we have an AtomicReferenceArray in every component that tracks state of properties, so we'll just need to convert it to type-safe data class object on request.

Thank you for you contribution to this repository.
Closing this Issue as this repository is being archived.


Serialise 'initialState' Containing Immutable JS

Hey, first of all, what you guys have made is extremely impressive. Scraped my janky old build setup and migrated this into my current project. Also, I am quite new to web applications, and am still learning, so I apologise in advance!
My project makes use of Redux and Immutable JS for most of the state objects. I used your master branch, instead of your Redux opinionated branch, as I had no need for thunks in my project. I did pretty much copy all of your relevant changes to get Redux working.
However, the serialize-javascript package (used within generateHTML.js) seemed to convert my Immutable JS into regular JS objects. Immutable.fromJS(window.APP_STATE) was unable to convert back certain data-structures, such as the Ordered Set.
To try to solve this, I discovered a module transit-immutable-js which I use on the initialState key within the object that is passed into generateHTML in the server's reactApplicationMiddleware function. Then, I convert the transit string back into Immutable JS objects in client\index.js as I create the Redux store.
This solution seems to work, but I am wondering if it is the ideal way of going about things?

Hey @Braden1996 !
Great question, I actually use the json-stringify-safe package when generating parsable JSON.
I also added a XSS filter for security reasons.
https://github.com/ctrlplusb/react-universally/blob/c70d95e22ac7bba2dd1b9ef745c6e1dd03a05120/shared/utils/json/stringify.js
I would use Immutable toJS method (same as toString(), right?), pass it into json-stringify-safe, then apply the xss filter.
I have tried the serialize-javascript before with same problems like you are reporting.

Hey @birkir, thanks for getting back to me.
When I use Immutable JS's toJS() method in order to obtain the JSON, I lose information regarding the data-structure's type. For example, both Immutable.Set([...]) and Immutable.OrderedSet([...]) are converted into identical JSON arrays. This means I would be unable to read the JSON back into the originally typed Immutable JS objects without explicit knowledge of my store's state scheme.
However, I assume it would be fine to run the JSON (obtained after calling transit-immutable-js) and then pass that into stringify?

Ok this is outside the scope of my knowledge.
I usually construct the store manually in my mobx projects so in redux + Immutable this may be different.
But check out transit and the transit-immutable-js driver.
https://github.com/glenjamin/transit-immutable-js


Client Allocation Request for: This is a test application - Please ignore

Client Allocation Questions
Core Information

Name: This is a test application - Please ignore
Website / Social Media: [This is a test application - Please ignore](This is a test application - Please ignore), (This is a test application - Please ignore, Twitter)
Region: Africa
DataCap Requested: 512 GiB
Addresses to be Notarized: This is a test application - Please ignore
Notary Requested: Andress Sarria

Application created via filplus.storage

This user’s identity has been verified through filplus.storage

This user’s identity has been verified through filplus.storage

This user’s identity has been verified through filplus.storage

This user’s identity has been verified through filplus.storage


Karma single/auto run..

Whenever you use karma:single-run or karma:auto-run, they call runTests function wich override the run mode to be always singleRun
Your code:
function runTests (singleRun,done) {
  var singleRun = true;
  ...

Thank you for your feedback @jjcastano .We are fixed this issue in version 1.2.5. Be careful when you try to execute commands in next times, because we are changed our task by npm scripts. Check out our README.md file to view how to run the commands of angular basic. Thank you once again for your proactive work ;)


steval-eth001v1: add FOC examples

Summary
steval-eth001v1: add FOC examples
depends on https://github.com/apache/incubator-nuttx/pull/6811
Impact
None
Testing
examples/foc (float and fixed16 options)

@raiden00pl some build error need to fix before merge:
https://github.com/apache/incubator-nuttx/runs/7839035478?check_suite_focus=true


mx922 print wavy

Similar to this thread, prints are wavy and sometimes faint.
What I did:

Nozzle clean
Clean
Deep clean
Auto head alignment -> fails and says see manual ヽ(`Д´)ﾉ

Cleaning the encoder film as suggested in the forum seemed to have worked.

I can see it's still slightly wavy. Maybe cleaning was not 100%, but it's acceptable for most cases.


No Python 3.6 Windows or Linux packages

It looks like something went amiss when #4 was merged and the Python 3.6 packages for Linux and Windows were not created.  Will submit a re-render PR shortly.

The bot PRs won't produce the PY36 packages because of the commit message: MNT: Re-render the feedstock [ci skip]
We need to either send the PRs manually or remove the  [ci skip] until we have all Python 3.6 packages in the channel.

send the PRs manually

Done in #6.  At least I think that will fix the issue.


Error when running launcher on Wrangler

Can anyone please help here?
Below are the logs:
Tue Aug 30 00:09:08 CDT 2016
WARNING: LAUNCHER_WORKDIR variable not set. Using current directory.
Launcher: Setup complete.

------------- SUMMARY ---------------
   Number of hosts:    1
   Working directory:  /data/projects/G-817549/aerosols/jobs
   Processes per host: 2
   Total processes:    2
   Total jobs:         2
   Scheduling method:  dynamic

-------------------------------------
Launcher: Starting parallel tasks...
Ncat: Invalid -d delay "c251-127" (must be greater than 0). QUITTING.
Ncat: Invalid -d delay "c251-127" (must be greater than 0). QUITTING.
Ncat: Invalid -d delay "c251-127" (must be greater than 0). QUITTING.
Ncat: Invalid -d delay "c251-127" (must be greater than 0). QUITTING.
WARNING: No response from dynamic task server. Retrying...
WARNING: No response from dynamic task server. Retrying...
Ncat: Invalid -d delay "c251-127" (must be greater than 0). QUITTING.
WARNING: No response from dynamic task server. Retrying...
Ncat: Invalid -d delay "c251-127" (must be greater than 0). QUITTING.
WARNING: No response from dynamic task server. Retrying...
Ncat: Invalid -d delay "c251-127" (must be greater than 0). QUITTING.
WARNING: No response from dynamic task server. Retrying...
Ncat: Invalid -d delay "c251-127" (must be greater than 0). QUITTING.
WARNING: No response from dynamic task server. Retrying...
Ncat: Invalid -d delay "c251-127" (must be greater than 0). QUITTING.
WARNING: No response from dynamic task server. Retrying...

Hi Karanjeet,
Can you give me some specifics on the system you are using?

Lucas A. Wilson, Ph.D.
Director, Training & Professional Development
Texas Advanced Computing Center
The University of Texas at Austin
+1<PHONE_NUMBER>
lwilson<EMAIL_ADDRESS>From: Karanjeet Singh<EMAIL_ADDRESS>Sent: Tuesday, August 30, 2016 1:12 AM
To: TACC/launcher<EMAIL_ADDRESS>Subject: [TACC/launcher] Error when running launcher (#7)
Can anyone please help here?
Below are the logs:
Tue Aug 30 00:09:08 CDT 2016
WARNING: LAUNCHER_WORKDIR variable not set. Using current directory.
Launcher: Setup complete.
------------- SUMMARY ---------------
Number of hosts:    1
Working directory:  /data/projects/G-817549/aerosols/jobs
Processes per host: 2
Total processes:    2
Total jobs:         2
Scheduling method:  dynamic

Launcher: Starting parallel tasks...
Ncat: Invalid -d delay "c251-127" (must be greater than 0). QUITTING.
Ncat: Invalid -d delay "c251-127" (must be greater than 0). QUITTING.
Ncat: Invalid -d delay "c251-127" (must be greater than 0). QUITTING.
Ncat: Invalid -d delay "c251-127" (must be greater than 0). QUITTING.
WARNING: No response from dynamic task server. Retrying...
WARNING: No response from dynamic task server. Retrying...
Ncat: Invalid -d delay "c251-127" (must be greater than 0). QUITTING.
WARNING: No response from dynamic task server. Retrying...
Ncat: Invalid -d delay "c251-127" (must be greater than 0). QUITTING.
WARNING: No response from dynamic task server. Retrying...
Ncat: Invalid -d delay "c251-127" (must be greater than 0). QUITTING.
WARNING: No response from dynamic task server. Retrying...
Ncat: Invalid -d delay "c251-127" (must be greater than 0). QUITTING.
WARNING: No response from dynamic task server. Retrying...
Ncat: Invalid -d delay "c251-127" (must be greater than 0). QUITTING.
WARNING: No response from dynamic task server. Retrying...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/TACC/launcher/issues/7, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABLfulnImqihoB0Zp9KiVRBLNYB0ZJ25ks5qk8m0gaJpZM4JwLd-.

Thanks, @lwilson
I am running this on Wrangler. The SLURM script and job file are located at 0 & 1 respectively.

Hi @karanjeets,
The -d flag was added for Lonestar5, and doesn't affect other systems which are using the BSD nc command. CentOS 7 (which is on Wrangler) uses the nmap/ncat implementation, which uses this flag for a different purpose. Upstream versions of nmap/ncat will include a --no-shutdown option which implements the same functionality, but Wrangler's version doesn't include this fix.
Long story short, I will build a small fix to detect whether the system has nc or ncat, and change the flags accordingly. For now, you can change the following lines in paramrun to have no -d flag:
71:  export LAUNCHER_JID=nc $LAUNCHER_DYN_SRV
103:      export LAUNCHER_JID=nc $LAUNCHER_DYN_SRV
Sorry about that. I will be sure to get this fix put in ASAP. I'll leave this issue open and will link to it when I push the fix.
-Luke

Hi @lwilson,
Thanks a lot for the fix. Minor Correction - The lines, you pointed out, are present in "launcher" script and not in "paramrun".
+1 to keep the issue open. Let me also change the subject of this issue to include the system name. It will help people to relate.

We are seeing this error in stampede-KNL. The fix works nicely.

I fixed my comment to reference launcher and not paramrun. I'm still working on a method for detecting which version is being used, and therefore which flags to include.

I have decided to remove the -d option for now since it is Cray specific.


[vcpkg] Add clang-format tool

Describe the pull request

What does your PR fix? Fixes #

clang-format.exe cannot be found now, So adding CLANG_FORMAT tool.
'clang-format' is not recognized as an internal or external command,
operable program or batch file.
'true' is not recognized as an internal or external command,
operable program or batch file.

The regressions caused by gettext will be fixed by PR https://github.com/microsoft/vcpkg/pull/15740

The regressions caused by gettext will be fixed by PR https://github.com/microsoft/vcpkg/pull/15740

cc @BillyONeal

cc @BillyONeal

Currently, I have added clang-format. Seems it needs to be installed on our CI machine.
CMake Error at scripts/cmake/vcpkg_find_acquire_program.cmake:566 (message):
  Could not find clang-format.  Please install it via your package manager:

      sudo apt-get install clang-format

Currently, I have added clang-format. Seems it needs to be installed on our CI machine.
CMake Error at scripts/cmake/vcpkg_find_acquire_program.cmake:566 (message):
  Could not find clang-format.  Please install it via your package manager:

      sudo apt-get install clang-format

Rather than trying to provide clang-format I think we should be patching out whatever uses it in poppler's build system.

Rather than trying to provide clang-format I think we should be patching out whatever uses it in poppler's build system.

Thanks for your suggestion @BillyONeal. I will revert this changes about clang-format.

Thanks for your suggestion @BillyONeal. I will revert this changes about clang-format.


Enhance Lint/DuplicateSetElement to detect offences within SortedSet

SortedSet was in Ruby's standard library until 3.0, and I believe some people keep using it as a gem after its removal.

Before submitting the PR make sure the following are checked:

[X] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[X] Wrote good commit messages.
[X] Commit message starts with [Fix #issue-number] (if the related issue exists).
[X] Feature branch is up-to-date with master (if not - rebase it).
[X] Squashed related commits together.
[X] Added tests.
[X] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[X] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

The cop's description and examples need to be updated as well.

The cop's description and examples need to be updated as well.

Done.

Does this make sense for RuboCop? It used to be part of set which was/is a default gem, but now this is just some 3rd-party (ruby maintainer, but still)

AFAIK, RuboCop can analyze all MRI versions starting from 2.0, which means that most of the analyzable versions include SortedSet in their standard library. Also, I believe it does no harm in ~> 3.0 either. Right?

I don't see an issue with adding handling for SortedSet here, as it's both easy and useful IMO. (even if it's not longer in the StdLib) @koic @dvandersluis What do you think?

Seems low risk to me to support SortedSet. Examples should be updated to cover SortedSet.new as well given the changed pattern matchers.

Yeah, it's fine to detect SortedSet in all Ruby versions.

OK, I'll merge this after cutting a bugfix release tomorrow.

Can we merge this? 1.69.2 has been released recently 🙂

I haven't forgotten about this - I was just crazy busy this week. Done!

Thanks!


Test PR

👀

Codecov Report

Merging #217 (3155d50) into master (352a415) will increase coverage by 0.75%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #217      +/-   ##
============================================
+ Coverage     76.33%   77.08%   +0.75%
- Complexity      801      806       +5
============================================
  Files           115      115
  Lines          2252     2252
  Branches        262      262
============================================
+ Hits           1719     1736      +17
+ Misses          456      441      -15
+ Partials         77       75       -2

Impacted Files
Coverage Δ

src/main/java/seedu/address/model/event/Event.java
92.20% <0.00%> (+3.89%)
:arrow_up:

...a/seedu/address/model/participant/Participant.java
94.39% <0.00%> (+13.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 352a415...3155d50. Read the comment docs.


Entire Mastodon instance opt-in

Create a mechanism in which Mastodon admins can automatically opt their entire instance into Bridgy.

Wrong repo


Cannot recreate published results

Hello @thss15fyt,
Thank you for your work and for making the code publicly available.
I trained your model and I'm not able to recreate the test accuracy of the pre-trained model. I'm getting a test accuracy of 0.8847 after 150 epochs and a training accuracy of 0.9054.
This issue has also been reported in #8, can you elaborate more on the following questions?
Can you tell me what was this complex training strategy or share its code?
Also, what problem in the data set are you referring to?
Thank you.

Please refer to the new update and we provide a more stable training script to reproduce or even ourperform the results in paper.


pastCities in local storage render to screen on load

Also added styling

Also stopped past search list after 10 items


[Feature Request] LUIS API to retrieve all entities

Bot Info

SDK Platform: Node.js
SDK Version: Latest
Active Channels: -
Deployment Environment: Local development

Issue Description
I am currently working on a custom UI to manage (Create/Read/Update/Delete) an entity and its values.  All I did was to get a list of all entities first and then let our user to do anything they like.
I have gone through the LUIS API 2.0 several times and, surprising, there is no such API that will list out all the entities I have created in MS LUIS backend admin.

Is there any way I can do that?  Without that, it seems that I cannot use all the other API that requires entities IDs.
Thank you.

Thank you for opening an issue against the Bot Framework SDK v3. As part of the Bot Framework v4 release, we’ve moved all v3 work to a new repo located at https://github.com/microsoft/botbuilder-v3. We will continue to support and offer maintenance updates to v3 via this new repo.
From now on, https://github.com/microsoft/botbuilder repo will be used as hub, with pointers to all the different SDK languages, tools and samples repos.
As part of this restructuring, we are closing all tickets in this repo.
For defects or feature requests, please create a new issue in the new Bot Framework v3 repo found here:
https://github.com/microsoft/botbuilder-v3/issues
For Azure Bot Service Channel specific defects or feature requests (e.g. Facebook, Twilio, Teams, Slack, etc.), please create a new issue in the new Bot Framework Channel repo found here:
https://github.com/microsoft/botframework-services/issues
For product behavior, how-to, or general understanding questions, please use Stackoverflow.
https://stackoverflow.com/search?q=bot+framework
Thank you.
The Bot Framework Team


Mekanism-1.10.2-<IP_ADDRESS>2 - CTD - Basic Cable set to pull against Turbine

I encountered a crash while in survival mode, I recreated it in creative mode.
If you have formed turbine multi-block. Placing a universal cable next to the cable valve works fine, BUT If you change the universal cable to PULL it crashes to desktop and crashes again if you re-open the world.
If there is anymore information needed please let me know.
Thanks for all your hard work. I love Mekanism.
crash-2016-10-04_05.49.36-server.txt
crash-2016-10-04_05.52.37-client.txt

Fixed in 1.11 :)


The entities disappear when navigating to more than the 10th page then manually refreshing

Storage Explorer Version: 1.29.0-dev
Build Number: 20230224.3
Branch: feature/table-explorer-react
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Ventura 13.2.1 (Apple M1 Pro)
Architecture: ia32/x64
How Found: From running test cases
Regression From: Previous release (1.28.0)
Steps to Reproduce

Expand one storage account -> Tables.
Right click one table -> Click '[2] Open'.
Import more than 1000 entities.
Click 'Load more' -> Switch to the 11th page -> Click 'Refresh'.
Check whether the entities still display.

Expected Experience
The entities still display.
Actual Experience
The entities disappear.

Additional Context
The page number changes to 1.

Verified this issue on the build main 20230317.1. Fixed. So, we are going to close it.


Allow loading the native library from a custom resource path

This makes the native library loading significantly more flexible. In particular, applications can embed native components built for both optimised and portable profiles and dynamically select which to load at runtime.

Mmmm.... "Motif" so far was to not hard code package name, not in blst.swg. For this reason I wonder if it would be acceptable to use $imclassname.class.getPackageName() + ".jniResource" instead? There is $imclassname.class already, so it would be appropriate to add a variable to hold $imclassname.class and use it for both getResourceAsStream and getPackageName. Can you verify that this works for you and amend this request?
For my education. The shared library loader is called when you do import. Does "dynamically select which to load at runtime" mean that you would set the property prior import-ing. How does it work in practice? I mean import always appears at other-most scope in examples, which in my mind contradicts the idea of dynamic decision. Can you refer to an example? You don't have to answer this if you have no time:-)

Mmmm.... "Motif" so far was to not hard-code package name, not in blst.swg. For this reason I wonder if it would be acceptable to use $imclassname.class.getPackageName() + ".jniResource" instead? There is $imclassname.class already, so it would be appropriate to add a variable to hold $imclassname.class and use it for both getResourceAsStream and getPackageName. Can you verify that this works for you and amend this request?

I'll need to work through the details in the morning but yes if we can make the swig stuff do it then I don't have any problem with what the system property name actually comes out as.

For my education. The shared library loader is called when you do import. Does "dynamically select which to load at runtime" mean that you would set the property prior import-ing? [I wonder] How does it work in practice? I mean import always appears at ~other~ outer-most scope in examples, which in my mind contradicts the idea of dynamic decision. Can you refer to an example? You don't have to answer this if you have no time:-)

So my plan is to build the jblst jar with both versions in it (https://github.com/ConsenSys/jblst/pull/27).  And then Teku has a BlstLoader class that uses reflection to load the blstJNI class so we have complete control over when the class is initialised and tries to load the native library.  We can set the appropriate system property there.  There's a dodgy version of detection in https://github.com/ConsenSys/teku/pull/4733/commits/06ca40654f3af35e5c0013e8d50cac04649ce4a5 but I'm pretty sure I'll wind up moving the detection logic out of the sh script and into Java so it's more maintainable. Shows the basic idea though.

reflection to load a class

Ah! Well, not that I know exactly what it means, but I can recognize it as a pointer to right direction. Thanks!

reflection in this case just means using Class.forName("supranational.blst.blstJNI") which triggers loading the class and running the static initialiser but it executes as part of the normal control flow of the application rather than it being used via the usual import and then the JVM largely decides when it will load the class which can be quite unpredictable.
I've fixed up the package name - it was trivially simple once I was fully awake. :)

I've squashed commits and restyled the subject line. Thank you very much!


add underscore.string lib and use it to simplify code

Just a simple change, using underscore.string to simplify a few helper methods.
Wasn't sure if I should have included the tmi.js and tmi.min.js files, but I didn't think it could hurt.

Great idea, merged!
Thanks! :smile:


Cache folder very big

Really like this plugin, it helps a lot developing my own plugins.
But as I just observed, you're using your own cache folder in var/cache/production_xxxxx. Inside there are many more subfolders which weighed almost 1 GB of space. I can't remember how long I used this tool in my current project, but I imagine a lot of space wasted using your plugin in all my projects.
Can you implement a log rotate and a setting for the backend to restrict the cache to  a certain amount? That would be much appreciated!

It is a good point. I will add a config with max profile limitations and add the cache to the shopware default performance module to discover the cache and clear :)

That would be great, thanks!

Fixed in Plugin version 1.0.8

Thanks, that was fast!
I downloaded the latest version and updated it from inside the plugin manager. Though it seemed to work, I got this error while updating:
An exception occurred while executing 'INSERT INTO s_core_config_elements (name, value, description, label, type, required, position, scope, options, form_id) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)' with params ["maxProfiles", "i:50;", "You can disable it with 0 amount", "Max amount profiles, which should be saved", "number", 0, 0, 0, "a:0:{}", 294]:

SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '294-maxProfiles' for key 'form_id_2'

Nevertheless it seems to work. I set the max value to 5 and surfed a little bit through the shop. Then I looked inside the cache folders an saw that there were eight files. Shouldn't there be just five? Surely it's not a big deal, but maybe you should have an eye on it.
But thanks for this great tool 👍

The index is also in cache. It holds a array of all profiles. I am working in develop branch to replace it with a sql table and make filters work :)


IV_NCP=2 and OpenVPN 2.4

We always send IV_NCP=2:
https://github.com/robur-coop/miragevpn/blob/35a8d96783695674913ee42379f8384b34d83fe9/src/engine.ml#L360
But in the cipher-negotiation section of the man page it says OpenVPN 2.5+ only send IV_NCP=2 if --data-ciphers include AES-{128,256}-GCM.
https://github.com/OpenVPN/openvpn/blob/5af57e348ed3a5f451aca1bba5ba57b3a34e5d11/doc/man-sections/cipher-negotiation.rst?plain=1#L75-L76
Since OpenVPN 2.4 reached EOL in March this year maybe we can just drop IV_NCP=2? https://community.openvpn.net/openvpn/wiki/SupportedVersions

as I understand it, openvpn 2.4 didn't had IV_CIPHERS at all, but the presence of IV_NCP was used to (implicitly) indicate that AES-GCM is supported...
still, we need to decide what the lower bound of openvpn is that we support... does https://repology.org/project/openvpn/versions help us to find an opinion?

Implemented in #154


Desktop app does not find wax wallet

I have created two wax accounts, one via the Anchor iOS app and one via the wax cloud wallet using a private key generated in the desktop app. I imported both private keys into the Anchor desktop app. When searching for accounts it detects nothing. I can see both accounts on the bloks.io site.

It looks like it just took a few hours for it to recognize it or something but it found one of them at least.

Ah sorry about that. Yeah, current we're working through some troubles with one of the lookup services for WAX and it fell behind today. That was the source of it not showing up for a while.
We're hoping to have those hiccups resolved soon.


[Qol Survey] Improve qol survey saving implementation

Changes
adds tiny-timer
Submits the partial state of the Qol survey every 5 seconds instead of after each question.
Requirements
Requires: yarn install in /mobile
Testing
Reset your user before going through the onboarding and completing the qol survey, check firebase as you go to confirm your survey is being saved every 5 seconds.

[x] Manual

Getting this error:

@wynnset fixed

Looks great!

 This is on the latest version that's been released:
We should make sure that this.submissionTimer is never set to null. I saw that in your code that was not the case always.


obabel missing libraries

I am running centos 7 and the obabel binary from chemalot did not run due to missing libraries.  Should we ask users to install their own obabel instead of including a binary in the package?

I would agree.

no OEChem Java library available, any other alternative tools?

There is no out of the box alternative to OEChem at the moment. The RDKit package provides much of the functionality that the OEChem library provides but the API is different. We have thought about building a set of interfaces that encapsulate the functionality and allow for flexibility in the underlying chemical library but at this point we do not have any immediate intention to implement anything like that.


Find a way to match more easily any smoke test in the payload report and the code

Should it be via type name? other?

Published the type


V9 Tracking Issue

By Tuesday, May 17th:

[ ] #1501
[ ] #1516
[ ] #1523
[ ] RC0 tagged

By Friday, May 20th:

[ ] #1191
[ ] #1505
[ ] #1507
[ ] #1508
[ ] #1509
[ ] v9.0.0 released and tagged
[ ] #1521

Saturday May 21st - Sunday May 22nd:

[ ] Testnet created for integrators to test on

Monday May 23rd:

[ ] Gov prop created before epoch

Wednesday May 25th:

[ ] v9.0.0 on chain

Optional:

[ ] #1510
[ ] #1506

Changed issues -> PR for the issues that have an open PR for it so that we can better track what issues are currently being worked on, what issues hasn't started


adding increased margin for scatterplot log scale

This addresses a suggestion, https://github.com/VEuPathDB/web-eda/issues/1153#issuecomment-1142637556, which needs to increase margin for scatterplot log scale
After testing several cases, one of the simplest solution is to increase the margin when log scale is used. Screenshot is added for a comparison with Danica's screenshot at the comment above. As shown, marker is not cut in this implementation.
Note that this is only applied to max range of dependent axis because it would be most likely the case we need to consider.

@jtlong3rd Oh! as usual, you are so fast! 👍 ⚡ (lightening, I mean 😄)


[META] Forecasting in Anomaly Detection

Is your feature request related to a problem?
This is a container to house forecasting feature requirements as they progress.
What solution would you like?
Proposal
What alternatives have you considered?
TBD
Do you have any additional context?
TBD

Added to the RFC section of the user forum


Use ORCID?

Consider(ed) using ORCID or other author/researcher PIDs for contributor information? Might be relevant to at least consider adding that functionality in the future, so integration with journals, publishers, archives, online resumes etc is possible (perhaps for partners who would like to use the RSD) and auto-enrichting author names with hyperlinks, recent publications etc becomes possible.
see also the recent EU project FREYA: https://project-freya.eu/en/about/mission
and https://orcid.org/organizations/integrators

To think about enabling integration with ORCID (or other author PID systems) in the back, in the future. Front-end possible, but not really needed I guess.
Van: Jurriaan H. Spaaks<EMAIL_ADDRESS>Verzonden: woensdag 11 april 2018 12:22
Aan: research-software-directory/landing-page<EMAIL_ADDRESS>CC: Tom Bakker<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Onderwerp: Re: [research-software-directory/landing-page] Use ORCID? (#90)
For clarity, you are suggesting to put an ORCID next to the author's name on the human-readable text of the contributor section?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/research-software-directory/landing-page/issues/90#issuecomment-380403323, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ASvxgr9dSvZgFIQOBdqiua8ICHWb8Wd5ks5tndlhgaJpZM4TNNLW.

It is currently already possible to have the ORCID metadata as part of the CITATION.cff (e.g.https://github.com/NLeSC/ODEX-FAIRDataPoint/blob/a96125ba3c431a952c81ddfcffec9e5a970be46d/CITATION.cff#L9), but we're not displaying it on the frontpage (also not foreseen).


Fix the "Run the script" example

Hello,
There is an issue with the Run the script example in the Usage Guide.
An excessive indentation leads to a wrongly rendered misleading code.
Best regards!

Hi @tadeodonegana,
Is there any reason to just close this PR? 🤔
The Usage Guide still looks like this:

Hi @tadeodonegana, Is there any reason to just close this PR? 🤔 The Usage Guide still looks like this:
cc @igorriti

Please check 8005ab2. Problem was fixed.

Wait a minute. Let's repeat what you've did.

Silently closed this PR
Added changes from the PR into your own commit mixing them with completely unrelated changes, with no Co-authored-by in a commit message
Submitted a new mixed PR: #17
Merged your own PR

And I see it's not a first time. The same situation was here: #5 (https://github.com/Flode-Labs/vid2densepose/commit/7358842af3af12a2799a15a0dd30ef2f119191b1)
I completely realize my changes were trivial, but your approach on handling pull requests is surprisingly disrespectful. You might think it's fine to do things like this, but it's definitely not.

Wait a minute. Let's repeat what you've did.

Silently closed this PR
Added changes from the PR into your own commit mixing them with completely unrelated changes, with no Co-authored-by in a commit message
Submitted a new mixed PR: Ignore .DS_Store and Update README.md #17
Merged your own PR

And I see it's not a first time. The same situation was here: #5 (7358842)
I completely realize my changes were trivial, but your approach on handling pull requests is surprisingly disrespectful. You might think it's fine to do things like this, but it's definitely not.

My apologies if you felt disrespected.
Feel free to open other pull requests if you want to collaborate, and we will review it like we do with all of them.
Have a good day.


Dropping stops examination

About the PR

Title.
Closes #19387.
Why / Balance

Technical details

Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

fix: Dropping item stops its examination

you're right, seems fixed now


Update Tkn version to latest

Fix: #398

Codecov Report

Merging #400 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #400   +/-   ##
=======================================
  Coverage   72.56%   72.56%
=======================================
  Files          54       54
  Lines        3663     3663
  Branches      659      659
=======================================
  Hits         2658     2658
  Misses       1005     1005

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5213ea6...22c496b. Read the comment docs.


Download script archive fails...

Please explain the Issue / Feature Request here:
Running
 curl -s "https://get.sdkman.io" | bash
Results in

Installing SDKMAN scripts...
Create distribution directories...
Getting available candidates...
Prime the config file...
Download script archive...

curl: (56) Received HTTP code 403 from proxy after CONNECT
Extract script archive...
[/home/tkctsejd/.sdkman/tmp/sdkman-5.6.1+290.zip]
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /home/tkctsejd/.sdkman/tmp/sdkman-5.6.1+290.zip or
        /home/tkctsejd/.sdkman/tmp/sdkman-5.6.1+290.zip.zip, and cannot find /home/tkctsejd/.sdkman/tmp/sdkman-5.6.1+290.zip.ZIP, period.

Please follow the contributor guidelines before opening a github issue. Also, cannot replicate this issue.


add rukpak and lifecycle manager to 4.17

Same as https://github.com/openshift/check-payload/pull/186, but for 4.17 config

/lgtm


Elemental CAPI HTTPS support

This issue is about supporting HTTPS on the Elemental API server.
Currently it is possible to just define an ingress and terminate TLS there, however there are scenarios where TLS termination is not visible due to security concerns.
The provider should be able to load a certificate to use.
Since many CAPI components already depend on cert-manager, we do have the option to also depend on that.
However to keep it simple we can also add a kubernetes.io/tls secret with tls.key and tls.cert empty values and mount is as volume by default.
The administrator should be able to simply refresh the secret.
In the same fashion an empty configmap can be also instantiated to pass environment variable values to the controller.
Packaging the controller with Helm could be a valid alternative, but the intended way to install the controller is by using clusterctl.

Linking parent epic #968

Actually it's more convenient to rely on cert-manager.
I added a selfsigned issuer to bootstrap a CA certificate issuer, where the CA cert has 10 years validity.
This is then passed to the agents through the Registration spec, if https protocol is in use for the API and the Registration's CAcert field is empty.
Normally this would not be the case. I would expect a HTTPS proxy to be put in front of the Elemental API and the agent to use the system's trust store to verify TLS.


Add contributors section

I want to add contributors section in readme please assign under JWOC

@DarkFalc0n please assign it


Fix build errors with library evolution enabled

We do not support building this package with -enable-library-evolution, but I don't see a reason not to fix build errors with that configuration.
Checklist

[X] I've read the Contribution Guidelines
[X] My contributions are licensed under the Swift license.
[X] I've followed the coding style of the rest of the project.
[ ] I've added tests covering all new code paths my change adds to the project (if appropriate).
[X] I've verified that my change does not break any existing tests.
[ ] I've updated the documentation if necessary.

@swift-ci test

@swift-ci test


flutter_tool should support hot reload for Fuchsia

https://fuchsia-review.googlesource.com/c/scripts/+/229455


Allow to install nikic/php-parser

... and remove changes introduced in 5e9b61d366911012d4c8ddc5b9d97f51f20545af
Changes from 5e9b61d366911012d4c8ddc5b9d97f51f20545af is redundant with
this commit as there is no need to load dependencies from the PHAR
itself.
NOTE: Adding a note that I do not know what the reasoning behind adding a replace in the first place, only that I can't see the need for it now.

This change does not make much sense, there’s a reason why we do it that
way. PHPStan extensions also require the php-parser and this “replace” key
tells Composer not to install the parser again, because it’s already in the
PHAR.
On Tue, 10 Jul 2018 at 15:27, Edvin Hultberg<EMAIL_ADDRESS>wrote:

... and remove changes introduced in 5e9b61d
https://github.com/phpstan/phpstan-shim/commit/5e9b61d366911012d4c8ddc5b9d97f51f20545af
Changes from 5e9b61d
https://github.com/phpstan/phpstan-shim/commit/5e9b61d366911012d4c8ddc5b9d97f51f20545af
is redundant with
this commit as there is no need to load dependencies from the PHAR
itself.
You can view, comment on, or merge this pull request online at:
https://github.com/phpstan/phpstan-shim/pull/20
Commit Summary

Allow to install nikic/php-parser and remove changes introduced in
5e9b61d366911012d4c8ddc5b9d97f51f20545af

File Changes

M README.md
https://github.com/phpstan/phpstan-shim/pull/20/files#diff-0 (2)
D bootstrap.php
https://github.com/phpstan/phpstan-shim/pull/20/files#diff-1 (5)
M composer.json
https://github.com/phpstan/phpstan-shim/pull/20/files#diff-2 (6)

Patch Links:

https://github.com/phpstan/phpstan-shim/pull/20.patch
https://github.com/phpstan/phpstan-shim/pull/20.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/phpstan/phpstan-shim/pull/20, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGZuP2BGe88tm17cWXNx0RL5S-0IE_dks5uFKuzgaJpZM4VJZ1Y
.

--
Ondřej Mirtes

@ondrejmirtes What exactly was/is the issue with having nikic/php-parser installed in a composer project that also depends on this shim package? PHAR files are pre-built and should be self-contained as I have stressed multiple times.

You can install PHPStan extensions like phpstan-phpunit alongside both
phpstan and phpstan-shim. We didn’t want the phpstan-phpunit installation
to install nikic/php-parser again because it’s already available in the
PHAR.
Extensions require nikic/php-parser because classes from it are part of
their public interface and thus should be required explicitly in
composer.json. We use composer-requirements-checker for that.
I don’t know what’s the current problem - seems to be solved in current
dev-master of phpstan-shim and we’ll be tagged alongside PHPStan 0.10.2.
On Tue, 10 Jul 2018 at 15:57, Edvin Hultberg<EMAIL_ADDRESS>wrote:

@ondrejmirtes https://github.com/ondrejmirtes What exactly was/is the
issue with having nikic/php-parser installed in a composer project that
also depends on this shim package? PHAR files are pre-built and should be
self-contained as I have stressed multiple times.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/phpstan/phpstan-shim/pull/20#issuecomment-403831655,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGZuI7OIab24e6-UjG7SXHSaNmV8QKsks5uFLLBgaJpZM4VJZ1Y
.

--
Ondřej Mirtes

Fixed by 0.10.2.


Update API objects to be more descriptive

This markdown doc describes updates to the API to align names with existing conventions within ACM and to provide more straightforward language for discussing what has been called the nucleus operator.

@pmorie @qiujian16 updates in place based on comments above. Let me know if I misinterpreted anything.

The name changes look good.  I think my only substantive comment is https://github.com/open-cluster-management/api/pull/28#discussion_r432724588, the rest are minor.

/approve
@mdelder i believe you meant this to no longer be WIP, would you rename and remove the hold?
@qiujian16 can lgtm if he's good with this.

Removed WIP and squashed into a single commit.

/lgtm


Bug: input field and data gets updated despite it shouldn't

Hi,
As usual, here is the fiddle:
http://jsfiddle.net/xc2o8y08/31/
The other input field (and data) sometimes get updated despite it shouldn't. Note that the behavior is rather odd. If the text of the input fields is the same, they'll get updated (and the data too), but only some of them, and only those "after" it.
This concerns both latest and edge.

There is some kind of loopback effect here. Because the data changed, the sorting is triggered again, then it seems the data is set again, despite it shouldn't.

I've tracked this back to a locking issue that will hopefully get resolved along with all of the observer issues. What's happening is the element is being updated and locked while the computation is also taking place, so the correct value gets shuffled down to its new location while its replacement can't update the locked element.

I was trying to come up with an alternate fix for this, and I think I found a reasonable one that fails part of a test for #771. The fix is to change locking from a boolean to an equality check against the value set in the binding - so in binding this.attribute.lock = value and in update delegate if (this.lock !== value).
The failing test is expecting the value not to update when the observer sets it because it is locked. Only the first assertion fails because the value gets set to BAR when the lock is expecting it to be bar and thus allows it to change. The rest of the test seems to be fine.
I think that this test case is a bit bizarre because it expects the model and view to be out of sync on purpose. It seems like modifying an input with an observer should be handled by a lazy binding, which is now possible at the element level. Locking is still required because without it, the value gets reset with every char on non-lazy bindings, which makes the cursor jump to the  beginning.
So, I would propose that we drop support for observers getting the model and view out of sync in favor of lazy bindings and locking with the value instead of a non-specific true/false. Thoughts?

modifying an input with an observer should be handled by a lazy binding

What does that mean?

I'll see if I can ramble through it :smile:
The current behavior, which the test relies on, is:

a non-lazy two-way binding causes an update to the model (say, the user typed 'f')
the observer for that value then fires and also updates the model (toUpperCase - so 'F' is now in the model)
the time to update the attribute rolls around, and it is locked, so the attribute keeps its original value ('f')

I think that behavior was added because laziness wasn't readily available for a single input and without it, every character typed would update the input value, making the cursor jump back to the beginning of the input.
With a lazy binding, the model isn't updated until the input loses focus (or a timeout), so the model and input don't have an opportunity to get out of sync:

the lazy binding effectively buffers the user input (say 'foo')
the binding gets round to firing, which triggers the observer that updates the model (toUpperCase, so now the model is 'FOO')
there's no danger of messing up the input by making the cursor jump, so the value can be safely updated to match the model ('FOO')

My question is should we modify the behavior of bindings to keep the jumpiness of the cursor at bay only if the value stays the same from the binding getting a change to the update being called on the bound attribute. That would eliminate the class of binding bug found in this issue, but it also breaks observers that expect to be able to update the model without having the binding that fired them (and that shares the same mode) update as well.

thanks, as usual, good job!


comment after ^ triggers parse error

I had this code in a project
if (or (re:match '.*{$' $line) ^ # ends with {
        (re:match '.*^$' $line) ^ # ends with ^
        (re:match '.*{\ *|[^|]*|$' $line)) { # ends with params
  put foo
}

it produced a parse error like
Exception: Multiple parse errors:
  should be ')'
   ...foobar.elv, line 260:
                 (re:match '.*^$' $line) ^ # ends with ^
  should be '}'
    ...foobar.elv, line 260:
                 (re:match '.*^$' $line) ^ # ends with ^
  should be '}'
    ...foobar.elv, line 260:
                 (re:match '.*^$' $line) ^ # ends with ^
  unexpected rune '^'
    ...foobar.elv, line 260:
                 (re:match '.*^$' $line) ^ # ends with ^

This was unexpected b/c of how comments normally work.  Even if it's not technically a bug, it was surprising.
Removing the comments fixes the issue.

From the documentation:

A line continuation: a ^ followed by a newline ("\n"), or a carriage return and newline ("\r\n").

It's modeled on the equivalent POSIX shell syntax of placing a backslash just before a newline to elide the newline. In other words, in a traditional POSIX shell you can't do this:
echo A\ # the echoed text continues on the next line
B

See, for example, https://superuser.com/questions/794963/in-a-linux-shell-why-does-backslash-newline-not-introduce-whitespace

I thought that might be the case.
Good thing elvish isn't posix compliant. Support could be added if xiaq wants to.
Consider this a feature request.
I'm cool either way.

Good thing elvish isn't posix compliant.

Yes, I think everyone who uses Elvish would agree its explicit non-POSIX compliance is a good thing. 😄 But my point was that there are reasons for the current behavior. Having said that, your proposal could, in theory, be implemented. However, it's not clear what that means for other variations; e.g., echo a^b. See issues #989 and #979 for context regarding the current behavior. Especially this comment regarding using ^ elsewhere in the future.

Good points!


No color

Branch with only updates related to the axis definition. Without color support which causes problems in rovioli for some reason.

Sorry I missed this, whats ROVILI needs RGB?

Hi Chrostopher,
No, quite the opposite. 😊, We forked a copy of your repo  and modified the coordinate definition and added RGB stream ( https://github.com/hcaltenco/rs4se/tree/master https://github.com/hcaltenco/rs4se/tree/master). We used it for object detection, which needs RGB. But the RGB stream caused problems with ROVIOLI, so I created a branch of the forked repo without the RGB, only the other fixes ( https://github.com/hcaltenco/rs4se/tree/no-color https://github.com/hcaltenco/rs4se/tree/no-color).
So far we are running with two cameras, one for object detection and one for ROVIOLI.
We will work on a fix to run with only one camera (and have RGB and depth streams).
From: Christopher Choi<EMAIL_ADDRESS>Sent: den 2 december 2019 12:27
To: chutsu/rs4se<EMAIL_ADDRESS>Cc: Héctor Caltenco<EMAIL_ADDRESS>State change<EMAIL_ADDRESS>Subject: Re: [chutsu/rs4se] No color (#6)
Sorry I missed this, whats ROVILI needs RGB?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://protect2.fireeye.com/v1/url?k=e2d52802-be012570-e2d56899-86859b2931b3-c70378ee43b0797a&q=1&e=bb0cd589-a34e-47e0-9327-3d935b59e5e9&u=https%3A%2F%2Fgithub.com%2Fchutsu%2Frs4se%2Fpull%2F6%3Femail_source%3Dnotifications%26email_token%3DAANTOAYXPIPZF27XAZYOIVTQWTWGXA5CNFSM4JOYSP62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFTFTAI%23issuecomment-560355713 , or unsubscribe https://protect2.fireeye.com/v1/url?k=4e62abe2-12b6a690-4e62eb79-86859b2931b3-9a956b43236486e6&q=1&e=bb0cd589-a34e-47e0-9327-3d935b59e5e9&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAANTOA2A7X32ROG72I3KEETQWTWGXANCNFSM4JOYSP6Q .

Ok, yeah for ROVIO you don't want to use the RGB stream because it is rolling shutter. It is incredibly susceptible to motion blur causing VIO algorithms like ROVIO to not give good results. Instead you should run it against the two IR cameras with the IR emmitter switched off.
The original intension for rs4se was just for VIO only* but I'm beginning to see a fair few people are begging to use the RealSense for object detection as well. I am currently opening up the RGB stream (stole bits of your code) as well as the depth.

Hi Christopher,
Indeed, we use RS4SE with IR camera and IMU for ROVIO since it gives good results.  The problem of not including RGB and depth are that if you want to use two different ROS wrappers, then you need two cameras. And switch off the IR emitter on the second camera too, otherwise it will disturb  the first camera. But would be great if one could use RS4SE for both tasks, Object detection, depth estimation and VIO.
Feel free to use the RGB parts of the code for merging into your new implementation.
From: Christopher Choi<EMAIL_ADDRESS>Sent: den 2 december 2019 16:00
To: chutsu/rs4se<EMAIL_ADDRESS>Cc: Héctor Caltenco<EMAIL_ADDRESS>State change<EMAIL_ADDRESS>Subject: Re: [chutsu/rs4se] No color (#6)
Ok, yeah for ROVIO you don't want to use the RGB stream because it is rolling shutter. It is incredibly susceptible to motion blur causing VIO algorithms like ROVIO to not give good results. Instead you should run it against the two IR cameras with the IR emmitter switched off.
The original intension for rs4se was just for VIO only* but I'm beginning to see a fair few people are begging to use the RealSense for object detection as well. I am currently opening up the RGB stream (stole bits of your code) as well as the depth.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://protect2.fireeye.com/v1/url?k=e5f7a575-b97d6fcb-e5f7e5ee-869a17b5b21b-e403907791f6be0d&q=1&e=698198e1-9045-411e-b9cf-c11921c5b4a3&u=https%3A%2F%2Fgithub.com%2Fchutsu%2Frs4se%2Fpull%2F6%3Femail_source%3Dnotifications%26email_token%3DAANTOAYFUOUBKULFZRXP62TQWUPGJA5CNFSM4JOYSP62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFTYMBQ%23issuecomment-560432646 , or unsubscribe https://protect2.fireeye.com/v1/url?k=cb8333e3-9709f95d-cb837378-869a17b5b21b-8f9f4ad569383deb&q=1&e=698198e1-9045-411e-b9cf-c11921c5b4a3&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAANTOA7W3JT5L2DL2XSBJR3QWUPGJANCNFSM4JOYSP6Q .  https://github.com/notifications/beacon/AANTOA5YWWVJSWHVRNUDFALQWUPGJA5CNFSM4JOYSP62YY3PNVWWK3T UL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFTYMBQ.gif


Error in scipy.integrate.dblquad when using variable integration bounds and parametric arguments

Similar to #5452, dblquad fails when called with args because the args get passed to the range function in nquad, even though the range functions are supposed to not have additional arguments (as per the documentation):
>>> from scipy.integrate import dblquad
>>> g= lambda x: x
>>> h= lambda x: 2 * x
>>> args = 1, 2
>>> func = lambda x0, x1, t0, t1: x0 + x1 + t0 + t1
>>> dblquad(func, 1, 2, g, h, args=args)
TypeError: <lambda>() takes exactly 1 argument (3 given)

This example works in 0.16.0 (the version I have installed) and I think the changes in #5906 are to blame.
I would suggest fixing this in a way that restores the old dblquad API. tplquad likely has the same issue, but I haven't checked.

@woodscn: ping

Thanks for the heads up. The API for dbl- and tpl-quad should have remained unchanged. I'll look into it.

I have a fix. Does anyone have the output from the given problem, so I can set up a test?

Eh, nevermind. Easy enough to come up with.

In [2]: >>> from scipy.integrate import dblquad

In [3]: >>> g= lambda x: x

In [4]: >>> h= lambda x: 2 * x

In [5]: >>> args = 1, 2

In [6]: >>> func = lambda x0, x1, t0, t1: x0 + x1 + t0 + t1

In [7]: >>> dblquad(func, 1, 2, g, h, args=args)
Out[7]: (10.333333333333334, 1.1472304587793286e-13)

In [8]: import scipy

In [9]: scipy.__version__
Out[9]: '0.17.1'

Fixed in gh-6492, closing.

Hello,
I seem to have run into the same problem in
scipy.version '0.18.0'
Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python2.7/site-packages/scipy/integrate/quadpack.py", line 495, in dblquad
return nquad(func, [lambda x: [gfun(x), hfun(x)], [a, b]], args=args)
File "/usr/local/lib/python2.7/site-packages/scipy/integrate/quadpack.py", line 705, in nquad
return _NQuad(func, ranges, opts, full_output).integrate(*args)
File "/usr/local/lib/python2.7/site-packages/scipy/integrate/quadpack.py", line 760, in integrate
**opt)
File "/usr/local/lib/python2.7/site-packages/scipy/integrate/quadpack.py", line 315, in quad
points)
File "/usr/local/lib/python2.7/site-packages/scipy/integrate/quadpack.py", line 380, in _quad
return _quadpack._qagse(func,a,b,args,full_output,epsabs,epsrel,limit)
File "/usr/local/lib/python2.7/site-packages/scipy/integrate/quadpack.py", line 749, in integrate
low, high = fn_range(*args)
TypeError: () takes exactly 1 argument (3 given)

@shantanu9847 upgrading to scipy 0.18.1 or 0.19.0 should fix your issue.


  Instead results are returned from the entire document.  Is this intended behavior?

Sorry, new to Xpath and didn't know about the .// syntax


inconsistent behaviour of InstructionList.find

In general InstructionList.find(lat, lon, dist) finds the closest point on the route and then yields the upcoming instruction.
In the case the closest point on the route is the start or endpoint of an edge instead the previous instruction is returned.
See: https://github.com/graphhopper/graphhopper/blob/master/core/src/main/java/com/graphhopper/util/InstructionList.java#L319

You mean that in the case !validEdgeDistance the index++ could be missing? That would be indeed rare but ugly

yes, thanx for clarification :)

Do you have a test case for this?

not yet, but I will write one