Documenting JavaScript Code

To make slack-statistics accessible for newcomers, it would be nice if someone could take the time to document the code such that someone with a basic understanding of JavaScript could easily understand it.
Example: comments on what is happening with the promises, the API calls, etc.

Provided this isn't super time critical I could take a look at it.

I would refactor the data function in smaller bits,
so you can chain like
.then(fnName1).then(fnName2)....
and maybe you can use fetch() instead of xmlHttpRequest that provides already a Promise based implementation.

@pvdsp At least for the existing code is this the level of detail you are looking for?  I would like to make this more concise without sacrificing clarity but do you think something like this is too specific?
function getData() {
    /* Chain all the requests and console.log caught errors.
	   After each successful call the next call will execute, however if a
	   call fails there will be no more calls and the error will be logged */
    data(null, "info", "teamName")
        .then(() => data(todayQuery, "search", "todayCount"))
        .then(() => data(yesterdayQuery, "search", "yesterdayCount"))
        .then(() => data(null, "users", "userCount"))
        .then(() => data(null, "users", "userList"))
        .then(() => getPercentage())
        .then(() => getTalkativeUser())
        .then(() => postToHTML())
        .catch(error => console.log(error))
};

@itsdegan: that's exactly what I meant, you're welcome to document in when you have the time.
@david1983: great idea! You're welcome to send a pull request at any time, if it works and it's cleaner than the current version, we'll aprove it

I'll make adjustments to the inline documentation based off the recent commits and have a PR ready soon.

Made PR #30 to address this

Amazing work, I'll close this issue. Thanks!


Wechat and Facebook Messenger conflict

Replaced the messenger regex id for WeChat as Facebook Messenger is using that regex id and given WeChat a new regex id called wechat fixes github issue: https://github.com/WhichBrowser/Parser-PHP/issues/488

Coverage remained the same at 100.0% when pulling a64215f8295d7b51620e6cbff3991a742bde8e46 on ayumi-cloud:wechat into 4899110cd2f87b01e04ced62dbb9dec541031dee on WhichBrowser:master.


Allow us to pre-assign a metatable to a userdata

Currently, Luau-defined userdatas all have their own metatables
The problem with this is when it comes to the behaviour around the metamethods for >, <, >= and <= where it requires both objects to have the same metatable.
The best way to accomplish this without breaking the sandboxing around host-defined metatables is to assign it using newproxy as a second argument;
newproxy(bool shouldAdd = true, table metatable)

Just to quickly comment on this - presumably this is why this was closed, but I want to have this for posterity - this is not necessary because for equality and relational operators to be overridden, what needs to match is metamethods, not metatables.
That is, the following code should work fine for tables, despite the newly created metatable:
local function lt(a, b) print("lt") return false end
local t1 = setmetatable({}, { __lt = lt })
local t2 = setmetatable({}, { __lt = lt })
print(t1 < t2)

The behavior is identical for userdata, the tables are used above for clarity.
Separately, userdata is primarily a host extension mechanism; newproxy is supported for compatibility but really tables should be used instead. newproxy is removed in later versions of Lua, as such we may deprecate it in the future (even though we of course will need to keep supporting it to keep existing code working).


Remove ESCAPED_QUOTE variable

Minor edit - no functionality changes.
Removing this variable because it's used so inconsistently (line 110 - used at start and then not again on this line in places it should).
Plus, the variable name is longer than what it actually represents, and since it's unlikely to ever change, doesn't even work as a shortcut.

Much of this is going to be changed in the next day or two, but for now it doesn't hurt to merge it. Thanks @Pandrex247


update IPFS deployment hash

Cutting out a new release.

I'll merge this and make a release tag.

We should probably try it out first and make sure it works at least a bit


Add option to skip validations when setting values

Closes #110
This adds the option to skip validations when setting values to the underlying object. This option would only be available when creating the changeset programmatically by using a forth parameter. The user would be responsible for manually invoking validate on their changeset.
In combination with ember-changeset-validations, it would looks like this:
  ...
  model() {
    return new Changeset(
       someObject,
       lookupValidator(SomeValidator),
       SomeValidator,
       { skipValidationsOnSet: true }
    );
  }
  ...

I've updated the code to reflect your requests. Let me know if you want anything else changed!

Docs and helper have been updated to reflect the new option.

It looks like the tests failed for a reason unrelated to the code changes?

Is there anything else that you would want changed?


Add command to display OSS licenses

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Matthew Willer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Matthew Willer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


How to generate a CHANGELOG like version 7 and below?

I have upgraded my libraries and upgrade semantic-release to the latest version 9.8.5. I was coming from version 7 before.
Everything is working correctly after some tweaks, but the CHANGELOG generation is much worse than before in my opinion. Any suggestion on how to improve this?
Example:
Old CHANGELOG
Paragraphs based on commit (feat, fix, docs etc)
Module in Bold (core, auth, users)
One long list of changes for every version
# Changelog

<!--next-version-placeholder-->

## v1.16.0 (2024-07-04)

### Feature

* **users:** something something [CSR-1234] ([`4bcca39`](https://github.com/....))
* **auth:** something something [CSR-1235] ([`98c011e`](https://github.com/....))

## v1.15.0 (2024-06-14)

### Feature

* **core:** something something [CSR-1235] ([`98c011e`](https://github.com/....))

### Documentation

* **core:** something something [CSR-1235] ([`98c011e`](https://github.com/....))

New CHANGELOG:
Paragraphs based on commit (feat, fix, docs etc)
Module are not in bold (core, auth, users)
Mixed up pre releases with full releases, very confused
# CHANGELOG

## v1.1.0 (2024-07-18)

## v1.1.0-rc.1 (2024-07-18)

### Feature

* fix(users): fixed users API [CSR-11111] ([`73a1823`](https://bitbucket.org/git/scm/...))

## v1.0.0 (2024-07-18)

## v1.0.0-rc.2 (2024-07-18)

### Feature

* feat(users): added users API [CSR-2222] ([`fa91e5a`](https://bitbucket.org/git/scm/...))

## v1.0.0-rc.1 (2024-07-18)

## v0.0.0-rc.1 (2024-07-18)

I had a similar situation (and in fact, I added some of the behavior in 7.x).
Maybe check out #952 and #953 - I posted a custom template I'm using there that does at least some of what I think you're looking for; sounds like we may have to wait for a major for some bigger changes.

I had a similar situation (and in fact, I added some of the behavior in 7.x). Maybe check out #952 and #953 - I posted a custom template I'm using there that does at least some of what I think you're looking for; sounds like we may have to wait for a major for some bigger changes. (I also updated my template snippet to include some spacing tweaks made since I first added it).
But the meat of what I'm doing is like this... would be nice if there were a slightly less messy way to handle the scopes.
* {% if commit.scope %}**{{ commit.scope }}**: {% endif %}{{ commit.descriptions[0] }} ([`{{ commit.short_hash }}`]({{ commit.hexsha | commit_hash_url }}))

Someone more adept at Jinja than me could probably also write little macros / functions that can be shared between the changelog / release notes, and reused within templates, to make it a little more readable.

Thank you! I couldn't see you templates but I have downloaded this CHANGELOG.angular.md.j2 and with that the CHANGELOG looks better already (the md preview is good but the actual md file is badly formatted with huge spaces between lines, don't know why).
Anyway, one other behaviour that I would like to understand is this:
The npm library of semantic-release generates the CHANGELOG based on the branch I am in. So if I am in main, it is going to generate a CHANGELOG based only on full releases. This creates a very clean file with only full releases.
If I am on stage or qa, it generates a CHANGELOG based only on stage releases (rc). This creates a very clean file showing changes only for rc (I call it BETA_CHANGELOG).
In case of the python semantic-release library, this generates a single CHANGELOG and puts all the prereleases and full releases together (you can see that in the second example on the OP). Basically, when I do a full release I will NOT have a list of changes for the full version (let's say 1.2.0), but I will have a long list of prereleases (1.2.0-rc1, rc2 etc) and for each the changes of that particular prereleases. Then at the top I will just have the title ## v1.2.0 (2024-07-18), wrapping all the prereleases together. I would like to have a CHANGELOG like my first example when I am in main. I do not want to see any prerelease, just list all the changes since the last full release!

@GiamBoscaro, yes, I agree, I have fix in the works to improve the issue with prereleases all being inside of the full changelog. Thank you for your description of you desired outcome.

@GiamBoscaro, yes, I agree, I have fix in the works to improve the issue with prereleases all being inside of the full changelog. Thank you for your description of you desired outcome.

Thank you!
There is also some other things that are different from npm semantic- release. I do not know if it is the right place to talk about this, but I have seen that any prerelease from any branch is considered the same prerelease during versioning. What I mean is:
I have a prerelease tagged like 1.2.0-dev.3 from dev branch, I merge dev into stage. Semantic release will run and will not release a 1.2.0-rc.1, but will skip it because since the latest prerelease no relevant commits were pushed (indeed there was only a PR merged). This is different from npm semantic release since there all the branches are considered different and semantic release with actually push a prerelease in this case.

Yes, this is a bug discussed in #789.

but I have downloaded this CHANGELOG.angular.md.j2 and with that the CHANGELOG looks better already (the md preview is good but the actual md file is badly formatted with huge spaces between lines, don't know why).

That file from PR was a draft. Obviously I hadn't finished the spacing created by my attempt to make it more readable with syntax formatting. I recently found out that you can use a hyphen at the end of a closure (-}}) to have jinja consume the newline character thanks to @wyardley.

but I have downloaded this CHANGELOG.angular.md.j2 and with that the CHANGELOG looks better already (the md preview is good but the actual md file is badly formatted with huge spaces between lines, don't know why).

That file from my PR was a draft. Obviously I hadn't finished the spacing created by my attempt to make it more readable with syntax formatting. I recently found out that you can use a hyphen at the end of a closure (-}}) to have jinja consume the newline character thanks to @wyardley.

Sure I know it is a draft. No complaint. The md rendering is good enough for me at the moment.

Hi, had the same problem got the spaces removed, heres my current CHANGELOG.md.j2 It also includes the commit body, each line is a bullet point.
# CHANGELOG

{% if context.history.unreleased | length > 0 %}
## Unreleased
{% for type_, commits in context.history.unreleased | dictsort if type_ != "unknown" -%}
### {{ type_ | capitalize }}
{%- for commit in commits if type_ != "unknown" %}
{% if commit.scope -%}
- **{{ commit.scope }}**: {{ commit.descriptions[0] }} ([`{{ commit.short_hash }}`]({{ commit.hexsha | commit_hash_url }}))
{% else -%}
- {{ commit.descriptions[0] | capitalize }} ([`{{ commit.short_hash }}`]({{ commit.hexsha | commit_hash_url }}))
{% endif %}
{%- if commit.descriptions | length > 1 %}
  {%- for description in commit.descriptions[1:] %}
    - {{ description }}
  {%- endfor %}
{%- endif %}
{%- if commit.breaking_descriptions | length > 0 %}
    **BREAKING CHANGES:** {{ commit.breaking_descriptions | join(" ") }}
{%- endif %}
{%- endfor %}
{% endfor %}
{% endif %}

{% for version, release in context.history.released.items() -%}
## {{ version.as_semver_tag() }} ({{ release.tagged_date.strftime("%Y-%m-%d") }})
{%- for type_, commits in release["elements"] | dictsort if type_ != "unknown" %}
### {{ type_ | capitalize }}
{%- for commit in commits if type_ != "unknown" %}
{% if commit.scope -%}
- **{{ commit.scope }}**: {{ commit.descriptions[0] }} ([`{{ commit.short_hash }}`]({{ commit.hexsha | commit_hash_url }}))
{% else -%}
- {{ commit.descriptions[0] | capitalize }} ([`{{ commit.short_hash }}`]({{ commit.hexsha | commit_hash_url }}))
{% endif %}
{%- if commit.descriptions | length > 1 %}
  {%- for description in commit.descriptions[1:] %}
    - {{ description }}
  {%- endfor %}
{%- endif %}
{%- if commit.breaking_descriptions | length > 0 %}
    **BREAKING CHANGES:** {{ commit.breaking_descriptions | join(" ") }}
{%- endif %}
{%- endfor %}
{% endfor %}
{%- if "breaking" in release["elements"] %}
### BREAKING CHANGES
{%- for type_, commits in release["elements"] | dictsort if type_ == "breaking" %}
{%- for commit in commits %}
{% if commit.breaking_descriptions | length > 0 -%}
{% if commit.scope -%}
- **{{ commit.scope }}**: {{ commit.breaking_descriptions | join("\n\n") | capitalize }}
{% else -%}
- {{ commit.breaking_descriptions | join("\n\n") | capitalize }}
{% endif %}
{% endif %}
{%- endfor %}
{%- endfor %}
{% endif %}
{% endfor %}


JS spread triggering auto-complete

With this code:
const [foo, bar] = [Math.min(|)]

where | is the cursor, typing ... yields in . followed by a random auto-completion.  This doesn't happen in other cases, e.g.:
const foo = Math.min(|);

which leads me to believe it's a bug.

What VS Code version are you using?

1.30.1


Feat: add quick tour

supercedes #920 #930 #927
fixes #899

@fsdavid final check to see everything looks good?

One thing found, on some slides arrow is a little bit left - what do you think? I can make a fix

One thing found, on some slides arrow is a little bit left - what do you think, is it ok? I can make a fix

@xgui3783 Now the arrow looks better, and I guess it's ready for merge.

https://github.com/HumanBrainProject/interactive-viewer/pull/931/commits/d7ebeec34510eb177938731fd13b4c278d648213#diff-494acace84b4eef28c7a5be32d62fb2f05e514dc01f4b957b4d6377623dd3a59R4-R5 we probably need viewbox attr here

@fsdavid d7ebeec#diff-494acace84b4eef28c7a5be32d62fb2f05e514dc01f4b957b4d6377623dd3a59R4-R5 we probably need viewbox attr here

It works pretty without the attribute and more problematic with it. I just reduced the arrow size to 2.4 rem and transform to 1.2 rem, so the arrow is in the middle and works well for all the slides. viewbox was taking only 1/4 of SVG and was more problematic to center it for different angels, so with it I could not really center arrow for all slides. Is there some specific reason why we should use viewbox?

2.4 rem

You reduced the size. I am fine with that

viewbox was taking only 1/4 of SVG and was more problematic to center it for different angels, so with it I could not really center arrow for all slides. Is there some specific reason why we should use viewbox?

viewBox should have nothing to do with the physical viewport of the svg (which is defined by svg width and height attribute). viewBox really defines the size of the svg canvas (not a canvas element). What it really mean is, if one defined viewBox of 0 0 100 100, and in the svg, you have an instruction M100 100, you are moving to the right most, bottom most point.
without it, it can be difficult to predict how the svg will behave in different browsers/different versions. In the commit above, M.5 17.819 can literally mean move to 1 unit to the right, 35 unit down, or 2 unit to the right, 70 unit down, depending on the viewbox definition.
I was sure most programs will export the viewbox property on export. which program are you using to export svg?

Yes, I was using vecta.io.

I double checked, as far as vecta.io is concerned, viewBox can be enabled if, when exporting svg, uncheck the optimize svg option.
The default export option seems to hard code the width and height, which is probably ok for print, but dubious for the web.
The workflow to get a a svg with viewBox attr is as follows:

file -> page setup -> custom -> 100x100 px
(scale the svg as the size may have changed)
export -> export as svg
optimize slider -> optimization mode -> object (you might also want to tick maintain ID ... etc in future projects)

@xgui3783 Thank you very much, I've added viewbox.


Add graph printer tool

Prints the table of all transitions and attributes allowed by states
Generate png image of workflows

Add a console command maybe

use https://github.com/knsv/mermaid ?


Unit tests pass but ios-sim exits with an error code of 1

Hello,
We are getting an intermittent issue where our unit tests pass, but ios-sim returns an error code of 1.  Has anyone encountered this issue before?

Try with v4.x


Support for stacking modals

Do not merge this yet!
Ok, this is not something I really like, but some people think that stacking modals is not that bad. One of those people being the designer in the company I work for :)
I really like Remodal and wanna continue using it, but for this I need stacking modals on top of each other. I've made some initial changes to the library in order to support that.
Basically changes include:

Overlay div is moved inside the wrapper, so that every modal has it's own overlay
Instead of a global remodal-is-active class, I'm using remodal-is-opened class on a wrapper, that allows showing/hiding individual modals
There's a stack option in settings that determines wether the modal should replace the current one of stack on top of it. Default is false in order to keep original behaviour

So I know that it kinda goes against your original idea, but this is quite a minimal change that won't fight people trying to implement this behaviour.
This is still work in progress, just wanted to make sure you are happy with the direction this is going. Otherwise I'll have to maintain a version of Remodal, that supports stacking, which is something I'm not sure I wanna do (keeping two versions of the same library).
In case you're happy to proceed I'll do some refactoring, add usage examples and update docs.

Fantastic! Really needed this imo. :+1:

:+1:

Truly needed ! Stackable modals for confirm/yes-no windows, for exmaple

I develop the new version - 1.0.0(in the 'dev' branch). So, i don't accept any PR until v1.0.0 will be released. Sorry.

With API of the v1.0.0 it will be possibe to make this in minor versions without incompabilities.

Shouldn't there be a line of code that enlarges the z-Index on the wrapper? How can this work with always the same z-index?

@PoeHaH correct me if I'm wrong, but elements with the same z-index stack on top each other, latest to appear in HTML to be on the top.

@VodkaBears since the 1.0.0 is out, I'm gonna resurrect this PR. Or maybe open another one, since this one's not gonna merge very well.

Cool. Create another one, pls, i'll close it.

@antstorm i also thought that, but it wasn't working for me so I added incremental zIndex, which fixed my issues.

@PoeHaH good to know that! I'll definitely take this into account.

it has released 1.0.1 now . waiting this ! @antstorm

Here's the new PR — #162. Let's get done and it merged.


[language][bootcamp] Replace instance of unsafe arithmetic with checked alternative

Motivation
We are creating bootcamp tasks to address all the instances of unsafe arithmetic (+,-,*,/,etc) in the diem core code base.
This is an example fix we expect which we are using to test the end-to-end process these bootcampers will go through.
The Instructions will be available in a future wiki. Ping me directly if you would like access to the draft.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
cargo x lint && cargo xfmt && cargo xclippy --all-targets
cargo xtest

One thing to note, this is an open sourced project and both that task number as well as the quip doc linked are inaccessible to non-Facebook employees.

One thing to note, this is an open sourced project and both that task number as well as the quip doc linked are inaccessible to non-Facebook employees.

Good point. I was thinking they could include the task number for tracking on our end, but if you think it would be better we can leave it out.  Is there any specific content that should be included in the PR description that should be added? (aside from explaining that this is a fix for uncheck arithmetic)

Old PR, feel free to re-open.

We decided not to go with the bootcamp approach for these fixes since it will require too much support from the Diem core team, but I think we still want to land this one just to get one low hanging fruit out of the way.

@mickayz, can you rebase, it seems the PR is a bit stale.

Closing out again as the PR is stale. Please rebase and update before re-opening.


Warning from App Store

Hi, after submission for internal testing I've got that message:
Non-PIE Binary - The executable 'JTAppleCalendar.framework' is not a Position Independent Executable. Please ensure that your build settings are configured to create PIE executables. For more information, refer to Technical Q&A QA1788 - Building a Position Independent Executable
I'm using version 4.0.0
Any Idea what it is about?
Thanks
Kristof

ok one thing.
I just updated to version 4.0.1
Also, what in the world is a PIE ? :/
I'm looking this up now. If you look at my code, i use regular stuff in there. I'm checking this out now.

Btw, we're already on version 4.0.2

So was the app rejected?
Here is what i found on PIE.
https://developer.apple.com/library/ios/qa/qa1788/_index.html
Let me know if it helped?

And here is information on what the PIE is.
https://www.madewithmarmalade.com/blog/announcing-support-position-independent-executables-pie-ios

Ok. so after reading up on it, i believe i have to update my project's settings to be PIE complaint? I'm not sure how to do this yet, as this is the first time im reading it up and I am occupied at the moment. But i'm sure the fix is a simple settings change in build settings. I will get to it once i am free. Sorry for the inconvenience.

OK, great that you found it! Please let me know when you fix it.
Thanks

Ok so i'm stumped. I read this thread from cocoapods -> https://github.com/CocoaPods/CocoaPods/issues/5453

Closing this as i believe this has something to do with the project settings from your end? If you have more information on it then let em know, but I couldn't find anything more on this.


Feature/build artifact slash and burn

3 changes in this PR:

I killed all the multi-loc artifact stuff because it didn't work very well and no one was using it. I instead reverted multi_build_artifact back to what it originally was when it was useful: a parallel build artifact for multiple locations at once
I axed all the old cluster stuff since we don't need it anymore
I decided while I was at it to refine the version comparison because I got burned so many times by patch version changes. Now it only rebuilds the artifact from scratch if there are any major/minor version differences but not patch differences

Will you make a ticket to use the same launch mechanism we use for psimulate (array job using drmaa)?

Will you make a ticket to use the same launch mechanism we use for psimulate (array job using drmaa)?

I ended up making a ticket for this instead of doing it because it was more complicated than I originally realized. When I've done this in research repos, I've known what the set of locations was & had an easy way for each task in the array to choose one location via the model specs. Here where the locations are specified as args to the cli, we need to save them somewhere/do something clever so each task can access them. I also realized that there are a lot of utilities in vivarium_cluster_tools we would want to use so probably want to rearrange things. all that to say, it looked like it was going to turn into a bigger task than I have time for


Remove host discovery ip tweaks

Switch using SHDP 2.4.0 snapshots which contains
a fix for SHDP-546. For that we don't need local
ip discovery tweak anymore as it can be configured
via yml.
Fixes #41

Merged via commit 9d8759dbe80e31f1b39b3cff0f0f92c0d529de6b


Bug: uniclip doesn't run on Android

Description of the bug
./uniclip doesn't work on Android
Verbose output (Use the --debug option)

error: "/data/data/com.termux/files/usr/bin/uniclip" has unexpected e_type: 2

Steps to Reproduce

Open Termux
download via wget
tar -xf to extract
./uniclip

Expected behavior
Should at least print the help message.
OS and Uniclip version
Android 14, uniclip v2.3.6
Additional info
The README instructions on the Android setup are incredibly vague. There has to be something I'm missing here...
I tried chmod +x, didn't help

I had the same issue, but it is in fact coming from Termux, cf this post.

Termux from Google Play? If so, uninstall and reinstall from F-Droid or GitHub.
Google Play build doesn't support running static binaries anymore.

wtf? Thanks a lot for telling me! I've switched to KDE Connect for now, but when I inevitably revisit this at some point I'll try with the F-Droid version.
In that case, please update the instructions in the readme to specify F-Droid/Github instead of explicitly mentioning the play store version of Termux.
Also, please make the Android instructions more detailed in general, how do I make uniclip run in the background permanently? Do I need to add it to some sort of autostart system? How am I supposed to install uniclip at all after installing the termux-api?


steam@nightly: fix steam uninstall failed use pre_uninstall

to fix #1905, add pre_uninstall for steam.

Closes #1905

Relates to #1905

[x] I have read the Contributing Guide.

a bit useless as it's actually mentioned in the error message...

you can use let it try uninstalling with sudo script I guess

a bit useless as it's actually mentioned in the error message...

you can use let it try uninstalling with sudo script I guess

看不到图🤔，链接显示private，其他人看不到

just in your issue

seems you didn't notice it.

ok, I think the error message before colon make me confused, so can wrap error in scoop.


[Project question] Force Image to redraw / repaint

I am trying to load old video game image/animation formats into a GUI using gotk3 and I am running in to an issue where I can't seem to get an Image widget to repaint when I need to (roughly synchronously after I modify the underlying pixbuf byte slice).
Is there anything I can do like that?
My searching leads me to this but I don't see any obvious parallel to those calls in the API docs.
I'm trying to avoid writing code that is overly coupled to gotk3 as I intend to use this same underlying code in a go-sdl2 based game client.

Using a GtkDrawingArea (gtk_widget_queue_draw_area) permit to refresh DA widget.
By the use of signal "draw" with callback function that paint (image) inside it.

Sdl2 handle this behavior, specially to make some simple games, why trying this with gotk3 instead of sdl ? since your goal is to finally use it ?
Because I'm writing a complex UI, for modding tools


refactor(costmodels): remove dead code

Codecov Report

Merging #1639 into master will increase coverage by 0.40%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1639      +/-   ##
==========================================
+ Coverage   78.53%   78.93%   +0.40%
==========================================
  Files         240      240
  Lines        3936     4006      +70
  Branches      719      719
==========================================
+ Hits         3091     3162      +71
+ Misses        747      746       -1
  Partials       98       98

Impacted Files
Coverage Δ

src/components/charts/common/chart.styles.ts
100.00% <0.00%> (ø)

src/pages/state/maintenance/maintenanceState.tsx
75.00% <0.00%> (ø)

...rc/components/charts/costChart/costChart.styles.ts
100.00% <0.00%> (ø)

.../components/charts/trendChart/trendChart.styles.ts
100.00% <0.00%> (ø)

.../components/charts/usageChart/usageChart.styles.ts
100.00% <0.00%> (ø)

...components/charts/common/chartLegendItem.styles.ts
100.00% <0.00%> (ø)

...components/reports/reportSummary/reportSummary.tsx
92.30% <0.00%> (ø)

...ges/dashboard/components/dashboardWidget.styles.ts
100.00% <0.00%> (ø)

...ponents/reports/reportSummary/reportSummaryAlt.tsx
60.00% <0.00%> (ø)

...nents/reports/reportSummary/reportSummaryItems.tsx
79.16% <0.00%> (ø)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1527dd0...0cccd37. Read the comment docs.


with -e VIRTUAL_PROTO=https upstream server still listening on port 80

the configuration generated by nginx-proxy when using this option is like this
upstream www.example.com {
                        # example_com_live
                        server <IP_ADDRESS>:80;
}

server {
        server_name www.example.com;
        location / {
                proxy_pass https://www.example.com;
        }
}

I'd rather expect it to listen to 443 like this :
upstream www.example.com {
                        # example_com_live
                        server <IP_ADDRESS>:443;
}

server {
        server_name www.example.com;
        location / {
                proxy_pass https://www.example.com;
        }
}

VIRTUAL_PROTO only controls how the proxy connects to the backend, as you've found. In order to have the proxy accessible on port 443, you'll also need to configure SSL support according to the instructions: https://github.com/jwilder/nginx-proxy#ssl-support

the proxy listen externally to both :80 and :443 ports and if I drop a certificate and its key in the certs folder it will serve the backend container with https. However for specific reasons the ssl is on backend container. I just need to transparently pass the requests to the apache container with ssl.

Nginx isn't capable of "transparently" proxying SSL. SSL is terminated by the nginx-proxy container and another SSL connection is made to the backend.
I'm not sure what problem you're actually having.

I just ran into this issue. I'm using nginx-proxy to mimic AWS ELB for local development.
We're switching ELB to TCP mode in production so that we can have a backend service handle SSL negotiation. But I'm not sure how to mirror this for local development.
Any advice?

FWIW I was able to work around the issue by setting up dnsmasq to forward requests for that particular service directly to the backend server, removing nginx-proxy from the chain in this specific scenario.


Allow disabling of included Stylesheet

I know that it is possible to override the included stylesheets, but we wanted to remove the overhead of loading the included stylesheet at all.
In my opinion it would still be a better solution to remove the loading of stylesheets completely, as I think it is kinda unexpected that some library-components - loaded through npm - start loading there own css (in ways you might not want it in your project). The default-style could still be part as an example plain-css file and/or js-stylesheet file for folks that want to use that. (e.g. jss(require('react-tabs').Stylesheet))
What yo you think about that? You probably had an idea on why to integrate the styling in the components, right?

Hi, you can also take a look at PR #25 for exactly the same issue

I should have had a look before at open PR. Thanks.
Closing in favor of #25


fix: improve archived api performance

Fixes #13382
Motivation

Modifications

Verification

After fixing make pre-commit -B and make test problems, I'll resubmit the Pull Request.

After fixing make pre-commit -B and make test problems, I'll resubmit the Pull Request.

For future reference, it is better to just push the changes to the same branch and PR rather than making a new PR, which is unnecessary and noisy.
Superseded by #13394


Text Stack Count Not Showing

Thanks for the addon, love it!  It's the only thing allowing me to use the default blizzard raid frames.
However, I have a problem where the text stack count is not showing when it should.

In the Text tab select Show Text: Stack Size
Get a debuff with stacks, text stack size not shown.

Technical info:

Retail Client ver 10.0.2 (47213) x64 Dec-19-2022
Addon ver 3.5.3 11-22-2022

Screenshots:
Settings Screenshot: https://imgbox.com/qnw60nmQ
Bug Screenshot.  I have 2 stacks of grevious wound, but ERF grevious indicator shows no stack text at all: https://imgbox.com/FcwHK3EP
Anyone else have this issue?

Is it specific for debuffs? All debuffs or only some?

Seems to be only certain debuffs, because here is thundering with a stack text working from that same run.  Even though I don't know what that stack text means for Thundering....
https://imgbox.com/ChCBkMMs
And here is another debuff from the same run, where the primal chill debuff is not showing stacks.
https://imgbox.com/A3s76mt4
As far as buffs, I don't use ERF for buffs so I don't know.

Is this still an issue? I just rebuilt the core engine and I may have resolved this in the process as I'm not using Blizzard's new UNIT_AURA API to gather information. If for some reason the issue is still there, it's because Blizzard is not providing the stack size information when queried, which means there's nothing I can really do about it :-/


Warn on embedded new lines in CSV/TSV import

Although cells can have multi-line values, it's unusual.  It would probably be helpful to users to warn when we encounter embedded newlines in cell values on import.
Related email thread: https://groups.google.com/g/openrefine/c/hmnjFVSINaY/m/sfdXqpja8lcJ

That would be very useful, I have run into this problem multiple times.

The main question that needs to be resolved for this is how can an importer generate warnings and how should they be displayed in the UI?
This particular warning is likely to go undetected at the preview stage, because an embedded newline could well occur after the first 100 lines of the file. So that means we need to wait for project creation, but then it is kind of too late…

I see this fitting better immediately after project creation.  Informing the user somewhere along the top area where we inform to download latest OpenRefine or show processing of reconciling.  It should stay until the user clicks their choice.  The operation is stored as a Change and allows to Undo/Redo.
Warning:  Your data contains New Lines embedded in cells.  Do you want to "create new rows" for these lines ? Yes/No/Cancel
(Informatica Powercenter has an optional detector for embedded newlines that can throw an ERROR and pauses ETL operations if so desired.)

It would be useful to have an example dataset which should trigger such a warning. In my experience, this happens when the dataset contains unescaped quote symbols, forcing the parser to parse multiple actual lines into a single cell.
Here is a synthetic example:
a,b
c,"d,
e,f
g,h

(it would still be better to have a real-world one to confirm)

It would be useful to have an example dataset which should trigger such a warning. In my experience, this happens when the dataset contains unescaped quote symbols, forcing the parser to parse multiple actual lines into a single cell.
Here is a synthetic example:
a,b
c,"d,
e,f
g,h

(it would still be better to have a real-world one to confirm)

I've updated the description with a link to the email thread that prompted this. The original problem was triggered by a bug in OpenRefine's quote processing, but, as @wetneb says, it also could be triggered by a bugging CSV writer (of which there are more than a few). Probably the most common way would be home grown variants where people just do ",".join(fields) or '"'+'","'.join(fields)+'"' with arbitrary text without quoting/escaping anything. The latter example with an unescaped fields value array of ["c",""d"] would produce the example above.

I've updated the description with a link to the email thread that prompted this. The original problem was triggered by a bug in OpenRefine's quote processing, but, as @wetneb says, it also could be triggered by a bugging CSV writer (of which there are more than a few). Probably the most common way would be home grown variants where people just do ",".join(fields) or '"'+'","'.join(fields)+'"' with arbitrary text without quoting/escaping anything. The latter example with an unescaped fields value array of ["c",""d"] would produce the example above.

@wetneb Yes, there's an example in the RFC 4180 (where it mentions "should" and is not strict...it's a misnomer, and I've never seen this supposedly "strict" memo that people sometimes mention, ever.)
   6.  Fields containing line breaks (CRLF), double quotes, and commas
       should be enclosed in double-quotes.  For example:

       "aaa","b CRLF
       bb","ccc" CRLF
       zzz,yyy,xxx

+1 agree that we warn users.  Give them options to deal with it later after import...as part of a cleaning task.  I've always that we should be giving users more hints by having Rules...and even making OpenRefine pluggable for that as part of the whole Data Validation issues we have.

@wetneb Yes, there's an example in the RFC 4180 (where it mentions "should" and is not strict...it's a misnomer, and I've never seen this supposedly "strict" memo that people sometimes mention, ever.)
   6.  Fields containing line breaks (CRLF), double quotes, and commas
       should be enclosed in double-quotes.  For example:

       "aaa","b CRLF
       bb","ccc" CRLF
       zzz,yyy,xxx

+1 agree that we warn users.  Give them options to deal with it later after import...as part of a cleaning task.  I've always that we should be giving users more hints by having Rules...and even making OpenRefine pluggable for that as part of the whole Data Validation issues we have.

That example is valid (quoted) CSV and should parse fine. As an aside, there are a couple of errata against that example, including one that points out that if you don't make quoting embedded commas mandatory, it makes the file pretty hard (ie impossible) to parse.

That example is valid (quoted) CSV and should parse fine. As an aside, there are a couple of errata against that example, including one that points out that if you don't make quoting embedded commas mandatory, it makes the file pretty hard (ie impossible) to parse.

@tfmorris Ah thanks, yes, you seem to have found that mystical "strict" memo...which is actually errata against the original RFC4 1080 memo.  Thanks so much for finding that for us!

@tfmorris Ah thanks, yes, you seem to have found that mystical "strict" memo...which is actually errata against the original RFC4 1080 memo.  Thanks so much for finding that for us!


Commit is out of range

We've observed a problem with clustered etcd, that after recreating one of the instances, it is entering crashloop and panicing with:
2017-11-29 05:47:07.905742 I | etcdserver: advertise client URLs = http://<IP_ADDRESS>:2379
2017-11-29 05:47:08.076040 I | etcdserver: restarting member 9af8ed310dba8214 in cluster 488ce3f49fab5e77 at commit index 20707
2017-11-29 05:47:08.077815 C | raft: 9af8ed310dba8214 state.commit 20707 is out of range [10001, 11535]
panic: 9af8ed310dba8214 state.commit 20707 is out of range [10001, 11535]

What exactly is happening is that we are recreating a VM where the etcd is running (without calling remove/add member) preserving all the addresses, etcd data etc. So after recreation, it the etcd is being started as the old member (similarly as it was restarted, though with a big bigger downtime).
We are running 3.0.17 version.
I found this https://github.com/coreos/etcd/issues/5664, which seems to be a similar (same?) problem. Has this been fixed? If so, in what release?
@xiang90 @gyuho @heyitsanthony @jpbetz

What exactly is happening is that we are recreating a VM where the etcd is running (without calling remove/add member) preserving all the addresses, etcd data etc. So after recreation, it the etcd is being started as the old member (similarly as it was restarted, though with a big bigger downtime).

Is the old etcd stopped before the new one is started? What is the exact sequence of events happening?
Also can you provide the full log instead of just the 3 lines before panicing?

Yes - it is stopped. The sequence is:

all 3 instances of etcd is running
one of them is being stopped (be deleting the VM in which it is running)
the VM is being recreated (the PersistentDisk where etcd data lives is attached)
the etcd is started

Also can you provide the full log instead of just the 3 lines before panicing?

Yeah sorry.

Logs from few minutes from the initial VM (before it was deleted): https://gist.github.com/wojtek-t/22665ffaee649a9c263fea090766a1a7
Logs from recreated VM: https://gist.github.com/wojtek-t/f9b9f27fcfaf7207464d0c6b81f61f5e

Thanks. I am not sure if this is the same issue you linked as I have not
looked into the logs. We will give this a look soon.
On Wed, Nov 29, 2017 at 7:19 AM Wojciech Tyczynski<EMAIL_ADDRESS>wrote:

Yes - it is stopped. The sequence is:

all 3 instances of etcd is running
one of them is being stopped (be deleting the VM in which it is
running)
the VM is being recreated (the PersistentDisk where etcd data lives
is attached)
the etcd is started

Also can you provide the full log instead of just the 3 lines before
panicing?
Yeah sorry.

Logs from few minutes from the initial VM (before it was deleted):
https://gist.github.com/wojtek-t/22665ffaee649a9c263fea090766a1a7
Logs from recreated VM:
https://gist.github.com/wojtek-t/f9b9f27fcfaf7207464d0c6b81f61f5e

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/coreos/etcd/issues/8935#issuecomment-347892371, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AERby_epjttx_OncgaEdZxFjqfyvK7gGks5s7XYFgaJpZM4Qu1ol
.

@wojtek-t
How large is each request you sent to etcd? Are you able to share the broken WAL file? Are you able to reproduce this problem every time you did the sequences of operations you listed?

No - it's not reliably reproducible. We've seen this twice in the last few days in continuously running suite.
We no longer have WAL file unfortunately.
@mborsz - if we observe it again, we may want to try capturing this, if possible.

How large is each request you sent to etcd?

These are coming from our internal k8s tests. But the cluster is pretty small (3 nodes IIRC), so there isn't anything that is very big.

@wojtek-t
OK. Also can you try on latest 3.2 to see if you can reproduce it?
Thanks.

@wojtek-t I'll start an investigation of this shortly.

And I will try running with 3.1 and potentially also 3.2 to see if any of those is fixing those.

FYI - we have changed our tests to run etcd in 3.1.11 version. So far it looks promising, but we need a bit more time to validate it.

@jpbetz @wojtek-t
We probably should move your test to upstream. It will make sure that etcd wont introduce regression that breaks it.
It is fine for the test case to be specific to GCP environment. All our e2e descriptive tests are running against GCP: http://dash.etcd.io/dashboard/db/functional-tests?orgId=1.
@saranbalaji90 from AWS will setup the test on AWS environment. Azure might want to do the same thing.

FYI - we have changed our tests to run etcd in 3.1.11 version.

I will be surprised that etcd 3.1.11 fixes the root cause. I feel the root cause is somewhere in raft pkg, and it is a pretty subtle one.
We probably should still spend sometime to understand why it happens under 3.0.10, and if 3.1.x fixes it which commit exactly fixed it.
/cc @jpbetz @wojtek-t

Definitely - Joe already said that he will be looking into that.

Yes. As glad as I am to see the problem go away. It makes me uncomfortable
not knowing why.  We’ll get to the bottom of it.
On Mon, Dec 11, 2017 at 11:50 AM Wojciech Tyczynski <
<EMAIL_ADDRESS>wrote:

Definitely - Joe already said that he will be looking into that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/coreos/etcd/issues/8935#issuecomment-350837442, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAf9Ru-vB6Qu67H0sSyUCIgs30UirK1jks5s_Yd6gaJpZM4Qu1ol
.

I encountered a similar case, but it is due to no space left on device, and the etcd holds v2 and v3 data
etcd version
2017-12-12 11:34:20.270243 I | etcdmain: etcd Version: 3.1.9

produce
It produced by following steps ...
I run a three node (HA) etcd cluster (such as node-1/node-2/node-3), Unfortunately, after a long time, node-1 was out of disk, in that time the remain two etcd members still running. Then I clear some useless data to free disk space, but the free space still can not match the need of etcd as it will receive a snapshot from the leader member (as its data behind far more then the cluster). Then things got worse.
The following logs shows that when i clear some data the action taken by node-1 etcd, it receive snapshot from leader and restore commitIndex to 116658132, but after that in raft progress save snapshot to .snap failed due to out of disk again as I didn't free enough space for etcd
node-1 etcd logs
2017-12-12 10:42:28.621858 I | rafthttp: receiving database snapshot [index:116658055, from 544c9d165e070a18] ...
2017-12-12 10:42:30.253747 E | rafthttp: failed to save KV snapshot (write /var/etcd-data/etcd/etcd-0/member/snap/tmp674225970: no space left on device)
2017-12-12 10:42:30.545319 I | rafthttp: receiving database snapshot [index:116658101, from 544c9d165e070a18] ...
2017-12-12 10:42:31.938653 E | rafthttp: failed to save KV snapshot (write /var/etcd-data/etcd/etcd-0/member/snap/tmp632108265: no space left on device)
2017-12-12 10:42:32.124505 I | rafthttp: receiving database snapshot [index:116658132, from 544c9d165e070a18] ...
2017-12-12 10:42:34.587907 I | snap: saved database snapshot to disk [total bytes: 47972352]
2017-12-12 10:42:34.587937 I | rafthttp: received and saved database snapshot [index: 116658132, from: 544c9d165e070a18] successfully
2017-12-12 10:42:34.588027 I | raft: e84ebc30798eec96 [commit: 113988062, lastindex: 113988062, lastterm: 28] starts to restore snapshot [index: 116658132, term: 28]
2017-12-12 10:42:34.588106 I | raft: e84ebc30798eec96 [commit: 116658132] restored snapshot [index: 116658132, term: 28]
2017-12-12 10:42:34.589685 I | etcdserver: applying snapshot at index 113979383...
2017-12-12 10:42:34.597730 I | etcdserver: recovering lessor...
2017-12-12 10:42:34.602677 C | etcdserver: raft save snapshot error: write /var/etcd-data/etcd/etcd-0/member/snap/000000000000001c-0000000006f40fd4.snap: no space left on device

however, I found this segment shows write wal and snapshot is a non-atomic operation
// SaveSnap saves the snapshot to disk and release the locked
// wal files since they will not be used.
func (st *storage) SaveSnap(snap raftpb.Snapshot) error {
	walsnap := walpb.Snapshot{
		Index: snap.Metadata.Index,
		Term:  snap.Metadata.Term,
	}
	err := st.WAL.SaveSnapshot(walsnap)
	if err != nil {
		return err
	}
	err = st.Snapshotter.SaveSnap(snap)
	if err != nil {
		return err
	}
	return st.WAL.ReleaseLockTo(snap.Metadata.Index)
}

And at this point, I dump the wal of etcd
node-1 etcd wal dump logs
Snapshot:
term=28 index=113979383 nodes=[544c9d165e070a18 bb4d3bda10d567f8 e84ebc30798eec96]
Start dupmping log entries from snapshot.
WAL metadata:
nodeID=e84ebc30798eec96 clusterID=1e81083acbac81f6 term=28 commitIndex=116658132 vote=0
WAL entries:
lastIndex=113988062

it can be seen commitIndex has been set to 116658132, but as we know snapshot was saved error in node-1 etcd logs, then node-1 etcd will encounter a panic when it restarted again
2017-12-12 11:34:20.499718 I | etcdserver: restarting member e84ebc30798eec96 in cluster 1e81083acbac81f6 at commit index 116658132
2017-12-12 11:34:20.500412 C | raft: e84ebc30798eec96 state.commit 116658132 is out of range [113979383, 113988062]
panic: e84ebc30798eec96 state.commit 116658132 is out of range [113979383, 113988062]

can this be a cause to this problem or am i misunderstanding something about my problem ?

@zrss
I do not think your issue is the same as the one originally reported here. You hit a ENOSPC, but this issue did not.
@wojtek-t @jpbetz any progress on investigating the root cause of this issue?

@xiang90 - Joe wanted to look into that. I can only say that 3.1.11 release is fixing this issue.

@wojtek-t
I feel 3.1 probably includes something mitigates the issue, not fixing it. I am concerned that the root cause still exists, and eventually you will hit this bug again after a longer run.

Fix is in bbolt coreos/bbolt v1.3.1-coreos.5. Main summary is on https://github.com/coreos/etcd/pull/8813#issuecomment-344158430 and the backport to 3.1 is https://github.com/coreos/etcd/pull/8902.

So anyone knows how to fix it in 3.0.17 if happened this problem? Any workrounds? I tried remove member and add member again, it does not work and shows the same error.

Sorry, for unknown reason, failed to remove etcd data directory in the crashed node. So it is still crashed.
I tried the commands again, remove member, remove crashed node etcd data, add member, start etcd can deal with this problem for multiple nodes.


Can't import evaluation function in colab

For some reason using the stable-baselines from colab and importing evaluate_policy fails.
Here is my complete code:
!pip install stable-baselines -q
# stable_baselines needs tensorflow 1
%tensorflow_version 1.x
from stable_baselines.common.policies import MlpPolicy
from stable_baselines.common.vec_env import DummyVecEnv
from stable_baselines import PPO2
from stable_baselines.common.evaluation import evaluate_policy
import gym
import numpy as np

and here is the error:
TensorFlow 1.x selected.
WARNING:tensorflow:
The TensorFlow contrib module will not be included in TensorFlow 2.0.
For more information, please see:
  * https://github.com/tensorflow/community/blob/master/rfcs/20180907-contrib-sunset.md
  * https://github.com/tensorflow/addons
  * https://github.com/tensorflow/io (for I/O related ops)
If you depend on functionality not listed there, please file an issue.

---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-2-9a251b4aa149> in <module>()
      5 from stable_baselines import PPO2

----> 7 from stable_baselines.common.evaluation import evaluate_policy
      8 import gym
      9 import numpy as np

ModuleNotFoundError: No module named 'stable_baselines.common.evaluation'

Hello,
please take a look at the provided notebooks, the order is important ;):
https://colab.research.google.com/github/Stable-Baselines-Team/rl-colab-notebooks/blob/master/stable_baselines_getting_started.ipynb
You need to do the pip install after requesting tf1 and you need to use --upgrade because an old version of sb is installed by default on colab.

Duplicate of https://github.com/hill-a/stable-baselines/issues/799 and https://github.com/hill-a/stable-baselines/issues/464
The root cause is the same, the error is different though.


Only configure stdout logging in setup and teardown hooks

Fix to issue #79
Also includes bumping libcalico to the correct version that supports specifying rules at profile creation

One comment then LGTM.  Make sure it still has 100% coverage.

@caseydavenport can we make this fix a 1-liner by changing our previous stdout logs to use stderr instead? I'm not crazy about conditionally changing where we make logs, and I suspect that Kubelet will capture stderr in the same way.

@Symmetric - Hmm, yeah, that could be a much better way to do this.  We should check that the kubelet behaves the way we expect in this case, but if it does, then let's make that change.


Is there a Grunt plugin

Is there a grunt plugin for this library? I would like to use the bundle feature in a grunt build. Before I work on creating one I just wanted to ask first.

If you found/made one let us know!

If you found/made one let us know!


Error: The inputs have already been written to an output stream and can not be consumed again.

Hi, I have an Android application that needs to upload a local temp file to a server. At runtime I receive the following error:
The inputs have already been written to an output stream and can not be consumed again.
	com.github.kittinunf.fuel.core.FuelError$Companion.wrap(FuelError.kt:86)
	com.github.kittinunf.fuel.core.FuelError$Companion.wrap$default(FuelError.kt:83)
Caused by: java.lang.IllegalStateException: The inputs have already been written to an output stream and can not be consumed again.
	com.github.kittinunf.fuel.core.requests.UploadBody.writeTo(UploadBody.kt:100)
	com.github.kittinunf.fuel.toolbox.HttpClient.setBodyIfDoOutput(HttpClient.kt:273)
	com.github.kittinunf.fuel.toolbox.HttpClient.sendRequest(HttpClient.kt:140)
	com.github.kittinunf.fuel.toolbox.HttpClient.doRequest(HttpClient.kt:79)
	com.github.kittinunf.fuel.toolbox.HttpClient.executeRequest(HttpClient.kt:37)
	com.github.kittinunf.fuel.core.requests.RequestTask.executeRequest(RequestTask.kt:23)
	com.github.kittinunf.fuel.core.requests.RequestTask.call(RequestTask.kt:44)
	com.github.kittinunf.fuel.core.requests.RequestTask.call(RequestTask.kt:14)
	com.github.kittinunf.fuel.core.requests.RequestTaskCallbacks.call(RequestTaskCallbacks.kt:28)
	com.github.kittinunf.fuel.core.requests.RequestTaskCallbacks.call(RequestTaskCallbacks.kt:20)
	java.util.concurrent.FutureTask.run(FutureTask.java:266)
	java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	java.lang.Thread.run(Thread.java:764)

The android version is the following:
android {
    defaultConfig {
        compileSdk 34
        minSdkVersion 21
        targetSdkVersion 34
    }
}

Those are my dependencies:
dependencies {
    implementation "org.jetbrains.kotlin:kotlin-reflect:1.9.21"
    implementation "org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.0"
    implementation "org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.0"

    implementation 'com.github.kittinunf.fuel:fuel:2.3.1'
    implementation 'com.github.kittinunf.fuel:fuel-android:2.3.1'
    implementation 'com.github.kittinunf.fuel:fuel-gson:2.3.1'
    implementation 'com.github.kittinunf.fuel:fuel-coroutines:2.3.1'
}

And this is the code I'm using to upload:
private suspend fun uploadFile(localPath: String): String {
    val bearerToken = authenticate() //retrieves a jwt bearer token
    val url = "***REDACTED***" //simple upload endpoint that accepts multipart/form-data file and saves it elsewhere

    withContext(Dispatchers.IO) {
        Fuel.upload(url, Method.POST)
            .authentication()
            .bearer(bearerToken)
            .upload()
            .add { FileDataPart(File(localPath), name = "file", filename = "input.pdf", contentType = PDF_MIME_TYPE) }
            .progress { readBytes, totalBytes ->
                if (readBytes > 0 && totalBytes > 0) {
                    val progress: Int = (readBytes.toFloat() / totalBytes.toFloat() * 100).toInt()
                    Log.d(TAG, "Upload progress: $progress%")
                }
            }
            .responseString { _, _, result ->
                result.fold({
                    Log.d(TAG, "Upload completed")
                }, { error ->
                    Log.e(TAG, "Unable to upload the file", error)
                })
            }
            .awaitUnit()
    }
}

The file localPath should not be locked by anyone else. I've even make a copy of it and pass the copy to Fuel to double check but it returns the same error. Could it be a bug?
Thanks in advance

UPDATE: the problem seems to be caused by multiple calls of the .add {} function. I have yet to understand why... seems to be related to coroutines


add dart dev channel

I've just realized that it's also easy to add the dev version of dart, so here it is.

Maybe this would be better in scoop-extras—the main bucket is just for current stable versions.

Ah, makes sense. Will fix tomorrow.


fire extinguisher tile doesn't correctly remove used items

i think the error here is related to the semicolons, where it is evaluating a blank if statement then just appending all options instead of associating the actual option statement with the if. i'll have to test it out but if that's the error this is an easy fix.

TES confirms that was the issue! hooray. i'll remove those tomorrow and that'll fix that up.
another issue TES identified in the same vein:

this one i am not as sure on... will look at it tomm.

this was solved in #43


Zenject doesn't inject in the runtime

Hi everybody!!!
I am new in the zenject. I am trying to do the next
    public class AdditionBuilder : IBlockBuilder
    {
        [Inject]
        private BlockPrefabs m_BlockPrefabs;

        public GameObject BuildNew()
        {
            return m_BlockPrefabs.Operators.ArithmeticBlock;
        }
    }

I created this objects in the runtime. But m_BlockPrefabs always is null, if this object created on the app start, everything is ok. Please advise me, why this happens?

AdditionBuilder must be built by Zenject for injection to occur.  You cannot just call new AdditionBuilder.
By the way - github issues are meant for feature requests or bug reports with the library.  Please use stackoverflow, the google group, or gitter chat for other problems or misunderstanding.

Thanks.


🎉 New types2:library Gradle subproject

📝 Description
We would like to create a library Gradle subproject in the types2 project.
This subproject should be a Kotlin Multiplatform library supporting the Kotlin/JVM, the Kotlin/JS, and the Kotlin Native platforms (for Linux x64, macOS x64 and arm64, and MinGW x64).
Also, we should be able to generate its documentation using Dokka.
🔗 Dependencies
This issue is blocked by the following items:

[x] #607

✅ Checklist

[ ] Create the subproject.
[ ] Create a README documentation for this subproject.
[ ] Create a Gradle plugin for all projects, then apply it to this subproject. It will be useful for controlling the recommended Gradle tasks listed when running the :types2:library:tasks task (or a custom equivalent).
[ ] Create a Gradle plugin for Kotlin Multiplatform projects, then apply it to this subproject.
[ ] Create a Gradle plugin for projects supporting documentation generation with Dokka, then apply it to this subproject.
[ ] Include this subproject in the integration workflow dedicated to the types project.
[ ] Close this issue as completed and update tracking ones if present.

We will not create a second edition of Kotools Types for maintaining its backward compatibility (reverts done in 60382ca58aeba621005d6c909b58ca55b9b78f00).


(PYL-W0614) Unused import from wildcard import found

Description
In a wildcard import, all public names defined in the module are imported. It is advised to explicitly import the values needed or modify the module being imported from and define all to restrict the names to be imported.
Occurrences
There are 3336 occurrences of this issue in the repository.
See all occurrences on DeepSource → deepsource.io/gh/robotichead/NearBeach/issue/PYL-W0614/occurrences/

Yes please :) Any help will be greatly appreciated.


Avoid duplicates in history

It would be nice to avoid duplicates in history, so identical barcodes scanned more than once do not "polute" it with multiple entries.

Implemented in v1.6

Thank you!


[stylus] tap into Stylus to use its javascript API

Clear and concise description of the problem
Hello,
I would like to add some functionalities in my stylus code by defining new functions in order to transform the output CSS. [^1]
To do so I would need to use the stylus.define function, as mentioned in Stylus’ javascript API documentation.
There is no possibility to do that using Vite. I suggest to tap directly into imported nodeStylus into the stylus preprocessor, using a tap options :
{
   tap: stylus =>
     stylus
       .define('$var', 32)
       .define('fn', () => /* do something useful */)
   ...otherOptions // additionalData, filename, imports...
}

As set, include, import, define and use are chainable (they return the stylus instance), it is safe to use a tap-like mechanics. The case of deps, resolver and the final render can break the chain and lead to unexpected results, and thus may be addressed (e.g. not accessible, maybe using a subset of the stylus instance ?)
What do you think ?
[^1]: In my use case, I target specific elements using selectors like [fill="#33C5FF"] (to override some style of iframes that are reversed-proxied, but I guess other use cases might be found). I loop over all the palette colors and do {s('[fill="%s"]', $from)}. The thing is the s function using the only available %s ends up with a lower-cased color, hence the new selectors [fill="#33c5ff"] do not target anything. This is a stylus problem, that can be bypassed by defining a custom function for that very operation.
Suggested solution
I can implement the thing, but I wanted to make sure it is relevant.
Alternative
For the final Vite config API, instead of tap: (stylus: Stylus) => Stylus which can lead to unexpected behavior if used unwisely, maybe we can use explicitly a define option which is an object [key: string]: any:
{
  define: {
    $var: 32,
    fn: () => /* do soemthing useful here */
  }
}

Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Any update on this proposal ? I know a lot of issues are running around (648 at the time of speaking) but I can implement the feature really quick, I only need guidance on the way to do it so that it fits the Vite config design.

Since css.preprocessorOptions seems to have a generic Record<string, object> interface, I will go for the second solution which seems to be safer. I guess I will update the documentation too.

Sorry, this wasn't in my radar when it's created. I'll add this to the team board for discussion (when we have the chance). But I do wonder what else from the JavaScript API would be beneficial to be configured besides .define, if there's more, I think it makes sense to have a tap-like API, especially that it's future-proof too..

Apart use which is quite marginal, I don’t see any other functionality that needs to be implemented. (see the Stylus Javascript API documentation. Indeed, set and include does not have a usage that needs to be covered as import does what we need, and is covered already).
So I stuck with the .define object configuration. I have dug into the code : see this PR https://github.com/vitejs/vite/pull/7227


More QoS features supported in NATGW

Feature request
Trying to implement more QoS features supported in NATGW.
Use case
The following QoS features will be supported:

Bandwidth rate limit for NATGW net1 NIC
Bandwidth rate limit for NATGW net1 EIP (already supported in #2496)
Bandwidth rate limit for external network traffic on NATGW net1

This is a simple test using tc tc-qos.md


Not triggering on /** in javascript.

I just installed the docblockr plugin and restarted atom.
Creating a new file with this contents:
function hello(name) {
  alert('Hello ' + name);
}

And then typing in /** on the line above the function statement only inserts the default snippet from atom.
/**
 * [cursor]
 */
function hello(name) {
  alert('Hello ' + name);
}

My environment:
$ apm -v
atom 1.0.7
apm  1.0.1
npm  2.5.1
node 0.10.35
python 2.7.10
git 1.9.5.github.0
visual studio 2010

Should I somehow disable the default behaviour? It seems like the plugin is working somewhat at least since pressing enter inside of a jsdoc comment autmatically inserts the leading *.

I do have the same issue here. I have to reinstall the package in order to make it functional again. However, once Atom restart docblockr will no longer work anymore.

Same issue here.

According to this https://atom.io/packages/docblockr docblockr doesn't support javascript at the moment

+1
<EMAIL_ADDRESS><EMAIL_ADDRESS>

Same issue, however guys you can switch syntax to c++ and then run dockblockr

Deactivated 'Simple mode' within the docblockr settings an voila!

@davepies Simple Mode is deactivated by default.

Same here :
Atom : 1.019
Win : 8.1

+1

+1. I usually disable/enable the package to fix this but it gets tedious.

It'll trigger when pressing space after /**
/** [Tab] - simple comment
/**
 * [cursor]
 */
function hello(name) {
  alert('Hello ' + name);
}

/** [Space][Tab] - execute docblockr
/**
 * [hello description]
 * @method hello
 * @param  {[type]} name [description]
 * @return {[type]}      [description]
 */
function hello(name) {
  alert('Hello ' + name);
}

Enter and shift-enter keystroke work fine too:
/** [Enter]

I am currently busy with college projects.. So have not been able to do much work... I am not sure I will be able to work on it any time soon.... Any help would be appreciated. :(

This was fixed with #189. In version 0.7.4 it shouldn't happen anymore.
@nikhilkalige can you please close this issue?

Running Atom on ubuntu 14.04
Atom version: 1.10.2
Dockblockr version: 0.8.7
The problem still persists.

@dpkshrma Your problem has very likely nothing to do with the issue described here. Please open a new issue and give a detailed description of your problem.

@MoritzKn The issue I am facing seemed to be exactly the same as @tregusti described in the issue description. So, I didn't see a point to open a new one. Although, I am not sure what more information would be required to replicate it. Docblockr worked for the first time, but on Atom restart, it stopped triggering.
I am currently working with ES6 syntax which I believe was partially enabled by this commit :
const testFunction = (testParam) => {
  return testParam;
};

Also, my environment details look like this:
$ apm -v
apm  1.12.5
npm  3.10.5
node 4.4.5
python 2.7.6
git 1.9.1

@dpkshrma Your problem is probably occurring because one of these reasons:

Another package adds a keybinding that overrides the event enter event. You can test this by using the keybinding-resolver with cmd-.
You have docblockr configured to work in Simple Mode

I don't want to reopen this issue, because it described a problem that occurred due to new snippets in Atoms core packages and this problem is fixed.
If none of the described reasons applies or you need further help, please open a new issue.

It worked for me by typing /** and then the Tab key as opposed as my previous attempts by typing Enter or Space after having typed /**


Write small results to file rather than stream large results

After writing to file enlarge and then make video

Implemented in d7149aee55d25dfeebb2923786fb9c6679e8fd81


chore(CI): dont run Hive tests on Py 3.7

SUMMARY
Skip Python 3.7 for Hive-based unit tests to free up precious CI queue slots.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
CI should pass
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

LGTM


What is the best way to select train questions?

Suppose I have a question, which require the answer to be generated by examining multiple sections of a document.
What kind of training questions should I include?
Does it need to be a mix of direct answer questions and multi section examine ones?
Any best practices to prepare the training Q/A pairs, especially when using with Program5 on intro notebook. Thanks in advance.

In general, KNN (dsp.knn) selection will yield good results, since it chooses the most similar demonstration questions.

In general, KNN (dsp.knn) selection will yield good results, since it chooses the most similar demonstration questions.

thanks for the response.


Idempotency support does not work for Direct Pay In

With both the latest version of the gem from Rubygems, and the latest version available in the master branch, this call to create a Direct Pay In does not add the Idempotency-Key http header to the request.
MangoPay::PayIn::Card::Direct.create({
  AuthorId:            author_id,
  CreditedUserId:      account_id,
  CreditedWalletId:    wallet_id,
  DebitedFunds:        { Currency: curreny, Amount: amount },
  Fees:                { Currency: curreny, Amount: 0 },
  CardType:            'CB_VISA_MASTERCARD',
  CardId:              card_id,
  SecureModeReturnURL: 'https://test.com/',
  Tag:                 'any tag'
}, idempotency_key)

Sample headers logged with HTTPLogger:
User_agent: MangoPay V2 RubyBindings/3.0.22
Authorization: Bearer c7e7ef2b0b644b3880209da57ed487ff
Content-Type: application/json
X_mangopay_client_user_agent: {"bindings_version":"3.0.22","lang":"ruby","lang_version":"2.2.5 p319 (2016-04-26)","platform":"x86_64-darwin15","uname":"Darwin MacBook-Air-2.local 15.5.0 Darwin Kernel Version 15.5.0: Tue Apr 19 18:36:36 PDT 2016; root:xnu-3248.50.21~8/RELEASE_X86_64 x86_64"}
Accept-Encoding: gzip;q=1.0,deflate;q=0.6,identity;q=0.3
Accept: */*
User-Agent: Ruby
Host: api.sandbox.mangopay.com
Content-Length: 282

However it does work for preauthorizations like this:
MangoPay::PreAuthorization.create({
 AuthorId: author_id,
 DebitedFunds: { Currency: currency, Amount: amount },
 CardId: card_id,
 SecureMode: 'DEFAULT',
 SecureModeReturnURL: 'https://test.com',
 Tag: 'any tag'
}, idempotency_key)

Sample headers logged with HTTPLogger:
User_agent: MangoPay V2 RubyBindings/3.0.21
Authorization: Bearer 059dfeae29b84c7098c6a00bd8185e4d
Content-Type: application/json
X_mangopay_client_user_agent: {"bindings_version":"3.0.21","lang":"ruby","lang_version":"2.2.5 p319 (2016-04-26)","platform":"x86_64-darwin15","uname":"Darwin MacBook-Air-2.local 15.5.0 Darwin Kernel Version 15.5.0: Tue Apr 19 18:36:36 PDT 2016; root:xnu-3248.50.21~8/RELEASE_X86_64 x86_64"}
Idempotency-Key: preauthorization-49
Accept-Encoding: gzip;q=1.0,deflate;q=0.6,identity;q=0.3
Accept: */*
User-Agent: Ruby
Host: api.sandbox.mangopay.com
Content-Length: 200

I've traced the problem to this method, when the idempotency key is passed to MangoPay::PayIn::Card::Direct.create, it is received in this method as the id argument instead of the idempotency_key. I am not sure what's the reason for that legacy logic.
Should I be calling MangoPay::PayIn::Card::Direct.create in a different way? Is this a bug?

Thanks for bring this up @javiercr. It looks like the legacy logic was added very early on, but I can't immediately see why. We're looking into it and the best way to get round this and I'll update you when I can :-)

Thank you for the prompt reply @hobailey.
The legacy logic was actually added in the same commit that introduced the support for idempotency keys, but I don't understand what it's for.

You can reproduce this by editing /spec/mangopay/shared_resources.rb like this:
 let(:new_payin_card_direct) { create_new_payin_card_direct(new_wallet) }
  def create_new_payin_card_direct(to_wallet, amnt = 1000)
    cardreg = new_card_registration_completed
    MangoPay::PayIn::Card::Direct.create({
      AuthorId: new_natural_user['Id'],
      CreditedUserId: to_wallet['Owners'][0],
      CreditedWalletId: to_wallet['Id'],
      DebitedFunds: { Currency: 'EUR', Amount: amnt },
      Fees: { Currency: 'EUR', Amount: 0 },
      CardType: 'CB_VISA_MASTERCARD',
      CardId: cardreg['CardId'],
      SecureModeReturnURL: 'http://test.com',
      Tag: 'Test PayIn/Card/Direct'
    }, 'idempotency-key-test-12345')
  end

Enabling logging with http_logger and running:
rspec ./spec/mangopay/payin_card_direct_spec.rb:19
Relevant output:
HTTP POST (1945.88ms)   https://api.sandbox.mangopay.com:443/v2.01/sdk-unit-tests/payins/card/direct
Request body   {"AuthorId":"14306735","CreditedUserId":"14306735","CreditedWalletId":"14306737","DebitedFunds":{"Currency":"EUR","Amount":1000},"Fees":{"Currency":"EUR","Amount":0},"CardType":"CB_VISA_MASTERCARD","CardId":"14306742","SecureModeReturnURL":"http://test.com","Tag":"Test PayIn/Card/Direct"}
HTTP request header   User_agent: MangoPay V2 RubyBindings/3.0.22
HTTP request header   Authorization: Bearer bc7fb47987bd43c3b4386acc8290ff3e
HTTP request header   Content-Type: application/json
HTTP request header   X_mangopay_client_user_agent: {"bindings_version":"3.0.22","lang":"ruby","lang_version":"2.3.0 p0 (2015-12-25)","platform":"x86_64-darwin15","uname":"Darwin MacBook-Air-2.local 15.5.0 Darwin Kernel Version 15.5.0: Tue Apr 19 18:36:36 PDT 2016; root:xnu-3248.50.21~8/RELEASE_X86_64 x86_64"}
HTTP request header   Accept-Encoding: gzip;q=1.0,deflate;q=0.6,identity;q=0.3
HTTP request header   Accept: */*
HTTP request header   User-Agent: Ruby
HTTP request header   Host: api.sandbox.mangopay.com
HTTP request header   Content-Length: 289
Response status   Net::HTTPOK (200)
HTTP response header   Cache-Control: no-cache
HTTP response header   Pragma: no-cache
HTTP response header   Content-Type: application/json; charset=utf-8
HTTP response header   Expires: -1
HTTP response header   Server: Leetchi
HTTP response header   Date: Mon, 27 Jun 2016 13:13:45 GMT
HTTP response header   Content-Length: 638
Response body   {"Id":"14306743","Tag":"Test PayIn/Card/Direct","CreationDate":1467033223,"AuthorId":"14306735","CreditedUserId":"14306735","DebitedFunds":{"Currency":"EUR","Amount":1000},"CreditedFunds":{"Currency":"EUR","Amount":1000},"Fees":{"Currency":"EUR","Amount":0},"Status":"SUCCEEDED","ResultCode":"000000","ResultMessage":"Success","ExecutionDate":1467033225,"Type":"PAYIN","Nature":"REGULAR","CreditedWalletId":"14306737","DebitedWalletId":null,"PaymentType":"CARD","ExecutionType":"DIRECT","SecureMode":"DEFAULT","CardId":"14306742","SecureModeReturnURL":null,"SecureModeRedirectURL":null,"SecureModeNeeded":false,"StatementDescriptor":null}

Note the absence of the Idempotency-Key header.

OK, thanks for these infos. Effectively, I'm not sure either why the legacy support was added, but I've asked @sergiusz-woznicki to update us as to why :-)

After some further research I've found this is not actually a bug but an inconsistence in the (ruby) API:
MangoPay::Preauthorization.create expects two arguments params and idempotency_key as defined here.
This led me to think that idempotency_key was always the second argument passed to any create method.
However the other objects which clases do not overwrite the create method, expect 3 arguments: params, id and idempotency_key as can be seen in this example:
MangoPay::NaturalUser.create(u, nil, idempotency_key)

@sergiusz-woznicki is there a reason to have different signatures in the created method of PreAuthorization and the rest of API objects?

Hi @javiercr, I haven't forgotten about this, but Sergiusz has been away this week - he'll get back to us in the next couple of days :-)

@javiercr is right: it's not a bug, it's an inconsistency between the general create method and its newer versions (in PreAuthorization and Mandate classes). The id param, present in the general signature, is not required in most cases (I don't even recall if it's used anywhere in the SDK itself), however I've left it here for legacy reasons: it may be used somewhere in the wild out there. The new versions do not use this param so I've decided to simplify these signatures.

@javiercr does this make sense, and is it satisfactory for you?

I just got bitten by this problem again... 2 years later.
To be clear, the main problem is that the current SDK expect these method calls:
MangoPay::PreAuthorization.create(params, idempotency_key)
MangoPay::PayIn::Card::Direct.create(params, nil, idempotency_key)
MangoPay::NaturalUser.create(params, nil, idempotency_key)

Note that nil in last two calls is the value for the id argument defined here.
Having to pass nil for creating objects such as PayIn::Direct or NaturalUser in order to use idempotency keys, doesn't make a lot of sense IMHO.
Also the problem is that if you happen to use
MangoPay::PayIn::Card::Direct.create(params, idempotency_key)
MangoPay::NaturalUser.create(params, idempotency_key)

(note the absence of nil). The SDK won't complain and you'll think you are using idempotency keys when in reality you are not.
If changing the method signature for these methods is too much of a breaking change, at least I think this behavior should be documented somewhere.
Thanks!

Hello @javiercr,
What SDK version are you using ?
We have release a v4.0 version with some technical improvements, maybe it could help?
I'll have a look closer too, and will keep you posted.
Mickaël


Update springConfigLocations test

Fix Concourse CI build failure
Update springConfigLocations test add log4j2-spring.properties

oh, thanks. I have literally added it before seeing this PR.
thank you.


Add imwheel

Hi, first of all, thanks for your contribution!
I'm a bit confused by your description, since only /etc/X11/imwheel/imwheelrc and $HOME/.imwheelrc are considered, symlinking to $XDG_CONFIG_HOME/imwheelrc isn't going to do anything.
I'll suggest some changes based on what I gathered from the manpage.

Hi, first of all, thanks for your contribution!
I'm a bit confused by your description, since only /etc/X11/imwheel/imwheelrc and $HOME/.imwheelrc are considered, symlinking to $XDG_CONFIG_HOME/imwheelrc isn't going to do anything.
I'll suggest some changes based on what I gathered from the manpage.

Hi, I agree what I wrote could have been phrased a little better. The intent was to show a workaround where you could write a config file in your home and then link it to the global config (which I found may differ based on distro or version). I tested this locally and it worked as intended.

Usually, symlinking from a local to global config file is not something you want to do, and I don't think we should suggest it. I'll apply my suggestion and merge this for now, if there's any specific reason you'd want to do it the way you suggested, feel free to open an issue.


[cirqflow] Quantum Executable workflow broken because Engine. _serialize_program doesn't support FrozenCircuit

Description of the issue
A call to cg.execute(rt_config, executable_group) to run circuits on the hardware is currently broken because with a processor that returns a QuantumEngineSampler, the run_sweep gets forwarded to cg.Engine and the following validation check fails:
https://github.com/quantumlib/Cirq/blob/a0497a411f494498778fae25b20011cd0b8b0eae/cirq-google/cirq_google/engine/engine.py#L633
How to reproduce the issue
cg.execute(rt_config, executable_group)

See details for the stack trace.

TypeError                                 Traceback (most recent call last)
<ipython-input-76-66aab6e69b44> in <module>()
----> 1 rt_config_hdw.processor.get_sampler().run(executables[0].circuit)

4 frames
/usr/local/lib/python3.7/dist-packages/cirq/work/sampler.py in run(self, program, param_resolver, repetitions)
     53             Result for a run.
     54         """
---> 55         return self.run_sweep(program, study.ParamResolver(param_resolver), repetitions)[0]
     56
     57     def sample(

/usr/local/lib/python3.7/dist-packages/cirq_google/engine/engine_sampler.py in run_sweep(self, program, params, repetitions)
     65                 repetitions=repetitions,
     66                 processor_ids=self._processor_ids,
---> 67                 gate_set=self._gate_set,
     68             )
     69         return job.results()

/usr/local/lib/python3.7/dist-packages/cirq_google/engine/engine.py in run_sweep(self, program, program_id, job_id, params, repetitions, processor_ids, gate_set, program_description, program_labels, job_description, job_labels)
    305             raise ValueError('No gate set provided')
    306         engine_program = self.create_program(
--> 307             program, program_id, gate_set, program_description, program_labels
    308         )
    309         return engine_program.run_sweep(

/usr/local/lib/python3.7/dist-packages/cirq_google/engine/engine.py in create_program(self, program, program_id, gate_set, description, labels)
    511             self.project_id,
    512             program_id,
--> 513             code=self._serialize_program(program, gate_set),
    514             description=description,
    515             labels=labels,

/usr/local/lib/python3.7/dist-packages/cirq_google/engine/engine.py in _serialize_program(self, program, gate_set)
    632     def _serialize_program(self, program: cirq.Circuit, gate_set: Serializer) -> any_pb2.Any:
    633         if not isinstance(program, cirq.Circuit):
--> 634             raise TypeError(f'Unrecognized program type: {type(program)}')
    635         program.device.validate_circuit(program)
    636

TypeError: Unrecognized program type: <class 'cirq.circuits.frozen_circuit.FrozenCircuit'>

Cirq version
0.14.0.dev20211117174531
cc @mpharrigan

yes I actually ran into this. EngineSampler needs to learn what's up!


French language support

Since this is public facing it should have the following:

[ ] Bilingual Documentation
[ ] French Language Support

@gordbot I've been thinking about it and I'm not sure yet. Do you have any recommendation?

@gordbot I've deployed a bilingual version of the dictionary. Would love your help to fill in the gap in the definitions.


Make a user manual

Suggested by Cheesy Brik in the Discord.
This would cover:

general usage (setup & toggling plugins)
documentation for each plugin
troubleshooting (& temporary workarounds to unfixed bugs)

Ideally this would look like https://desmos.s3.amazonaws.com/Desmos_User_Guide.pdf (LaTeX? HTML? A Figma frame for each page?). Or just use a GitHub wiki / md document. No matter what, put it in the "Resources" section of help on desmos.com.
Want to consolidate all into one document, so maybe each plugin gets one page (or two) to document? Or separate docs on each plugin's github page with links in between.

After further thought and inspiration from https://flight-manual.atom.io/, this might be able to merged with #2, with a section for usage and a section for writing plugins.


mathjax_view need update to Gradle 1.3.10 or >

pubspec.yaml

[x] mathjax_view: ^0.1.2

FAILURE: Build failed with an exception.

What went wrong:
The Android Gradle plugin supports only Kotlin Gradle plugin version 1.3.10 and higher.
The following dependencies do not satisfy the required version:
project ':mathjax_view' -> org.jetbrains.kotlin:kotlin-gradle-plugin:1.2.71

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 10s
Gradle task assembleDebug failed with exit code 1
flutter doctor -v
[√] Flutter (Channel dev, v1.14.6, on Microsoft Windows [versÃ£o 10.0.18363.592], locale pt-BR)

[x]  Flutter version 1.14.6 at C:\src\flutter
[x]  Framework revision fabeb2a16f (3 days ago), 2020-01-28 07:56:51 -0800
[x]  Engine revision c4229bfbba
[x]  Dart version 2.8.0 (build 2.8.0-dev.5.0 fc3af737c7)

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.0)

[x] Android SDK at E:\Android\sdk
[x] Android NDK location not configured (optional; useful for native profiling support)
[x] Platform android-29, build-tools 29.0.0
[x] ANDROID_HOME = E:\Android
[x] ANDROID_SDK_ROOT = E:\Android\sdk
[x] Java binary at: E:\Android\sdk\openjdk\bin\java
[x] Java version OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_212-b04)
[x] All Android licenses accepted.

any update on this ? is this library still active @touyou ?

@sumesh1993 (CC: @GuiHS01 )
Sorry, I already stop updating it because it is difficult to implement for my ideal use.
So I think it should be archived in a few days.
By the way, there is a very similar package named 'flutter_tex' ( https://pub.dev/packages/flutter_tex ).
You can try it instead of this package. Please check it. Thank you.


Fitness Directionality in Raw DMS Files

First off, thanks for putting this collection of datasets together! It has been extremely helpful.
I wanted to clarify the expected direction of the relationship between phenotype and fitness in the raw DMS files. For DMS studies that originally had a negative correlation between phenotype and fitness (i.e. a "-1" in the "raw_DMS_directionality" column of the ProteinGym reference files), has the phenotype been adjusted in the raw files to make the relationship positive? I believe this is the case, as higher values in the "DMS_score" columns correlate with higher values in the "DMS_score_bin" column, but the section giving raw file download instructions states that the files download are "the raw, unprocessed DMS files...". Some clarification would be greatly appreciated!

Dear Bruce,
Thank you for the kind words - means a lot coming from you!
We adjusted the directionality in the processed files (e.g., https://marks.hms.harvard.edu/proteingym/ProteinGym_substitutions.zip) so that in these files higher values of the DMS_score should always correlate with higher fitness (and also higher values of the DMS_score_bin column). The raw files (e.g., https://marks.hms.harvard.edu/proteingym/raw/substitutions_raw_DMS.zip) should in principle not have this correction.
Kind regards,
Pascal

Thanks, Pascal! That clears things up for me :)


[BUG] Replica rebuilding gets triggered if network bandwidth is restricted below 80mbit

Describe the bug
Replica rebuilding is observed if the network between engine and replica is restricted below 80mbit.
To Reproduce
Steps to reproduce the behavior:

Create a volume with 3 replicas.
Go to engine and run the below command to restrict the network bandwidth

tc qdisc del dev eth0 root
tc qdisc add dev eth0 root tbf rate 50mbit latency 0.1ms burst 50mbit

Attach the volume to a node and run below job to write data.

fio -filename=/dev/longhorn/vol -name=write-test -ioengine=libaio -direct=1 -iodepth=32 -rw=write -numjobs=2 -runtime=60 -group_reporting -bs=1m

Observe the rebuilding of replicas (Either all or one of them)

Expected behavior
Replica rebuilding should not happen.
Environment:

Longhorn version: Longhorn v1.2.0-preview1
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): Kubectl
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: RKE 1.21.3

Number of management node in the cluster: 1
Number of worker node in the cluster: 3

Node config

OS type and version: Ubuntu 20.04
CPU per node: 4
Memory per node: 8 Gi
Disk type(e.g. SSD/NVMe): SSD
Network bandwidth between the nodes: Upto 10 Gi

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): DO
Number of Longhorn volumes in the cluster: 1

@keithalucas Please help move to ready for testing state next time if the issue gets ready to verify.

Verified with Longhorn-v1.1.3-head and Longhorn-master 08/23/2021
Validation - Pass
Validated with 10mbit bacndwidth, no replica rebuilding is observed and writing worked fine.


play button not working after stopped.

as already mentioned by @irongomme in #384 the play button stopped working after the player was stopped once.
it stopped working with this commit: c34b40764fc2a75ac4d86a35b1a96a773f02b70b
so some dependencies may have broken it.
the latest working commit is c34b40764fc2a75ac4d86a35b1a96a773f02b70b ( i am using that one right now)

I'm doing the same, i use new releases for js but old release for the swf

@towerz Great job !


fix field selection for lists

Hi,
we're currently building a prototype and using your library for that. Apparently the field selection for lists is broken. This PR should fix that (assuming I understood the code correctly :-) ).
Cheers,
Mark

Thanks! This looks pretty good and along the lines of what I'd started already. The only thing I'll add is a List type, but will merge this in. :+1:


Won't load word: percent

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Fixed?


Vertical alignment does not take into account tableheaderview

When adding a tableheaderview, the empty view is not aligned correctly, the image is overlapping the tableheaderview. Is this an issue or should this be adjusted using offset?
To reproduce in the example project:
override func viewDidLoad() {         super.viewDidLoad()         tableView.tableFooterView = UIView()         tableView.tableHeaderView = UIView.init(frame: CGRect.init(x: 0, y: 0, width: 300, height: 150))         tableView.tableHeaderView?.backgroundColor = UIColor.black         setupEmpty()     }

It should be solved in 3.0.4 🍺


SLIM-247 Fixed: IllegalStateException: unit M_3 in destionation differs from u…

…nit M3 in source

All is well.

All is well.


Ease access to CFF contribution statistics

As a CF user

in order to assess community health
in order to use data to understand vendor involvement contribution
I need to easily have access to statististics and data about community contributions (in particular code, and handling issues, reviews of PRs)

As an inspiration, the CNCF hosts the https://devstats.cncf.io/ for CNCF projects

Full list of dashboards
Community sizing and health assessment dashboards
* Companies contributing in repository groups
* Companies table
* Company Statistics by Repository Group
* Countries stats
* Github Stats by Repository
* Github Stats by Repository Group
* Overall Project Statistics
* Stars and Forks by Repository
Contributor statistics dashboards

Bot commands repository groups
Company PRs in repository groups
Contributions chart
Developer Activity Counts by Companies
Developer Activity Counts by Repository Group
New and Episodic PR Contributors
New contributors
PR Reviews by Contributor
PRs authors repository groups
SIG mentions

Issue velocity dashboards

Inactive Issues by SIG
Issues age by SIG and repository groups
Issues Opened/Closed by SIG
New And Episodic Issue Creators

PR velocity dashboards

Awaiting PRs by SIG
Blocked PRs repository groups
Inactive PRs by SIG
Open issues/PRs by milestone and repository
Open PR Age by Repository Group
PR Comments
PR Time to Approve and Merge
PR Time to Engagment
PR Workload per SIG Chart
PR Workload per SIG Table
PRs approval repository groups
PRs labels by SIG
PRs labels repository groups
PRs opened by SIG
Other
Licenses and programming languages
Repository groups

Sample screenshots
with Community sizing and health assessmentCompany Statistics by Repository group

per project statistics, e.g. cluster api

Fortunately, the code powering devstats.cncf.io is opensource and could be used as is by the CFF.
See related KubeCon session Who What How: Understanding Kubernetes Development through DevStats with video and slides
Associated code is at https://github.com/cncf/devstats and https://github.com/cncf/devstatscode

Is this useful? https://cloudfoundry.biterg.io/app/kibana#/dashboard/Overview
Also take a look at the LFX Insights page for CF (DATA NOT CONSIDERED READY): https://insights.lfx.linuxfoundation.org/projects/cloud-foundry%2Fcloud-foundry/dashboard
One of our challenges is that the paired programming model necessitates sometimes "splitting" commit attribution amongst two or more people. That was implemented for the CFF by Bitergia a few years ago. As the project progresses, this may or may not remain an issue... but we are assuming that pairing will continue (and is obviously of historical significance). We worked with the LFX Insights team on this feature over the last year, and are starting to validate the data that they are pulling in. That work is not done yet.
We can support whatever the technical community would prefer long term, so this is a great discussion to have!

Thanks @chipchilders, this dataset is pretty useful!
Was it shared with the community a long time ago (sorry if I had missed the announcement)?
The dataset seemed accurate to me regarding my company (Orange) including my own contributions.
Some feedback of potential improvements (besides paired commit issue you mentionned) covering use-cases I did manage to cover in the tool:

support qualitative analysis: enable drilldown to actual data in dashboards: e.g. PR/issue/email URL/Subject
monitor responsiveness to community contributions (PR and issues),

PR Time to Engagment
PR Time to Approve and Merge
Issues without comments/responses (excluding automated response such as cla bot and pivotal tracker bots)
Time to Issue comments/responses (excluding automated response such as cla bot and pivotal tracker bots)

@gberche-orange  - Thanks for the feedback!
The bitergia dashboard was put in place back in 2015, so that was a long time ago. :) We don't highlight it much, because vanity statistics are always an apples to oranges comparison. We also deemphasized it when the community started getting flooded with very low value PRs in an attempt to game the system.
The LFX Insights page / dashboard will get more promotion once we are comfortable with the data and features there, including adding it on the main cloudfoundry.org website. It's still early, so no... no community "announcement" about it yet. I'll make one when I'm satisfied enough with the quality (sometime early 2021) and when we have incorporated it into cloudfoundry.org.
For your specific needs, here are some Bitergia pages that might help... we will work with the LFX team to have similar stats. FWIW, CNCF is also working with LFX to implement many of the most commonly used features of devstats.

Drilldown - You can drill into the PR's in the dashboards below
PR Responsiveness
Backlog
Timing
Efficiency

Hopefully I answered all of your questions @gberche-orange ... I'm going to close this issue now, but let me know if there is something specific that's outstanding with it!