Training model  and accuracy.

So far I have managed to stream video to my computer and taking training data by saving them in .npz file. (Still, I have more than 4000 pics and labels- training data)
train.shape - (1762, 38400)
train_label.shape - (1762, 4)
But now I have a problem with a model which returns as output always the same number: all 0s,1s or 2s.
Here I used two models- from opencv3: cv2.ml.ANN_MLP_create() and from Tensorflow.
Question

How to reach the best accuracy?

Train rate: 60.491493:

output of cv2.ml.ANN_MLP:
(1762, 38400)
(1762, 4)
Loading image duration: 3.847764051
Training MLP ...
Training duration:<PHONE_NUMBER>23
Ran for 1 iterations
Prediction: [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
 0 0 0 0 0 0 0 0 0 0 0]
True labels: [2 1 2 0 2 2 0 1 2 2 2 2 2 2 1 2 0 2 2 2 0 0 2 2 1 0 0 0 0 1 2 2 2 2 0 2 1
 1 2 2 2 2 1 2 0 1 2 0 2 1 0 2 0 2 1 2 1 2 2 2 2 2 0 2 0 0 2 2 2 2 2 2 2 2
 2 2 1 2 2 2 2 2 1 1 2 2 2 1 2 1 2 0 2 2 2 1 2 2 1 2 0 0 2 2 2 2 2 2 2 0 2
 2 0 2 0 2 0 1 2 0 2 2 2 2 2 1 1 2 1 0 2 2 0 1 2 2 2 2 2 2 2 1 2 1 1 2 2 2
 2 2 1 1 2 2 2 2 1 1 0 2 0 2 2 2 0 2 2 2 2 1 2 0 2 0 2 2 1 2 1 1 2 0 2 2 0
 2 2 2 0 0 2 2 2 1 0 0 2 2 0 2 2 2 0 2 0 2 1 2 2 2 2 2 0 2 2 1 2 2 2 0 2 2
 1 2 2 0 2 2 0 0 2 2 2 2 2 2 2 0 0 2 2 0 2 2 2 2 1 0 2 2 2 2 0 2 1 2 0 2 2
 0 2 2 2 2 2 0 2 2 0 2 2 0 2 2 2 1 1 2 2 2 2 0 1 2 1 2 0 2 2 2 0 2 2 2 0 2
 1 2 1 2 0 0 1 2 0 2 0 0 1 2 2 2 1 2 2 2 2 2 2 1 2 3 2 2 0 1 2 1 1 2 2 2 2
 2 2 2 2 2 2 2 2 2 1 1 1 1 2 0 0 2 0 2 1 0 2 2 2 2 2 2 2 0 2 2 1 2 2 2 2 2
 2 2 2 2 0 2 2 1 1 0 2 0 2 0 1 2 2 2 2 0 2 2 2 2 2 2 2 2 1 2 2 2 2 1 2 2 0
 2 2 0 2 0 0 1 1 0 2 2 2 2 2 0 2 2 2 2 0 2 0 2 1 0 2 2 2 0 1 1 2 0 0 2 0 2
 2 0 1 0 0 2 2 2 1 0 2 1 2 2 2 2 0 2 2 2 2 2 0 2 2 2 2 2 2 0 2 2 0 2 2 2 1
 2 2 1 2 2 0 2 2 2 2 0 2 2 0 1 2 0 2 2 2 2 0 2 2 2 1 2 0 2 1 2 2 0 2 2 2 2
 0 2 2 2 2 1 2 1 1 2 1]
Testing...
Train rate: 19.848771:

Pls help!!!

@hamuchiwa  having slightly same problem . please help

Training neural network is non trivial, try to use whole image which may give you a better result. To give you peace of mind, here is a self-driving video from aha124226675.

@hamuchiwa . I seem to have a similar problem, except that I have successfully trained the model (see below).
But when I'm running rc_driver.py, it is predicting only one output , that is, 'left'. I am still debugging, but open to suggestions.
Loading training data...
['train_labels', 'train']
(219, 38400)
(219, 4)
['train_labels', 'train']
(74, 38400)
(74, 4)
['train_labels', 'train']
(16, 38400)
(16, 4)
['train_labels', 'train']
(34, 38400)
(34, 4)
['train_labels', 'train']
(75, 38400)
(75, 4)
['train_labels', 'train']
(57, 38400)
(57, 4)
(475, 38400)
(475, 4)
Loading image duration: 1.18788429317
Training MLP ...
Training duration: 57.7994991789
Ran for 30 iterations
Prediction: [2 2 2 3 2 0 2 0 3 2 2 2 0 0 0 0 0 2 2 0 0 0 2 0 2 2 2 2 0 0 0 0 0 2 1 2 0
 0 2 0 0 0 2 0 2 3 2 2 2 0 0 2 0 0 0 2 2 2 2 1 1 2 2 0 0 0 2 0 0 0 0 0 0 1
 2 0 2 3 2 1 1 2 2 0 0 0 0 0 0 0 0 2 2 3 2 0 0 2 2 1 0 2 0 0 0 0 0 0 2 2 3
 3 2 2 2 2 0 0 0 0 1 2 0 0 0 2 2 2 2 2 1 1 0 3 0 0 0 0 2 1 1 1 3 3 1 1 2 3
 2 0 0 0 0 2 2 1 1 2 2 2 1 1 2 1 1 1 2 2 2 2 2 2 2 1 2 1 1 1 1 1 1 2 1 1 2
 1 1 1 1 2 1 1 3 3 0 2 2 2 2 2 1 2 2 0 2 2 2 1 1 1 1 1 1 2 2 2 2 2 2 2 2 2
 2 2 1 1 2 2 2 2 1 1 2 2 2 1 1 1 1 2 2 2 3 2 2 2 1 2 2 2 2 2 2 1 1 1 1 1 1
 2 2 2 3 1 2 2 2 1 1 1 1 1 2 1 1 1 1 2 2 2 0 0 0 2 1 1 1 1 0 0 2 2 2 2 2 2
 3 2 2 2 0 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 0 3 2 2 2 2 2 3 2 2 2 2 2 2 2 3 2
 2 2 2 2 2 2 3 3 3 2 2 2 2 2 2 1 1 0 0 0 0 0 0 0 0 0 0 2 1 1 0 3 3 3 3 3 3
 2 2 0 0 0 0 0 2 0 0 2 3 1 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 3 1 1 0
 0 0 0 2 2 2 0 0 0 0 0 2 2 2 2 2 2 2 2 0 0 0 0 0 0 0 3 2 2 2 0 0 0 0 0 0 0
 2 0 0 0 0 0 3 3 3 3 3 3 3 3 1 3 2 0 1 0 0 0 0 0 0 0 0 0 0 0 0]
True labels: [2 2 2 2 2 0 2 0 2 2 2 2 0 0 0 0 0 2 2 0 2 0 2 2 2 2 2 2 0 0 0 0 0 2 1 2 0
 0 2 0 0 0 0 0 2 2 2 2 2 0 0 2 0 0 2 2 2 2 2 1 1 2 0 0 0 0 2 0 0 0 0 0 0 1
 2 2 2 2 2 1 1 2 2 0 0 0 0 0 1 0 0 2 2 2 2 0 0 2 2 1 0 2 0 0 0 0 0 0 2 2 2
 2 2 2 2 2 0 0 0 0 1 2 0 0 2 2 2 2 2 2 1 1 0 0 0 0 0 0 2 1 1 1 1 1 1 1 2 2
 0 0 0 0 0 2 2 1 1 2 2 2 1 1 2 1 1 1 2 2 2 2 2 2 2 1 2 1 1 1 1 1 1 2 1 1 2
 1 1 1 1 2 1 1 0 0 2 2 2 2 2 2 1 2 2 0 2 2 2 1 1 1 1 1 1 2 0 2 2 2 2 2 2 2
 2 2 1 1 2 2 2 2 1 1 2 2 2 1 1 1 1 2 2 2 2 2 2 2 1 2 2 2 2 2 2 1 1 2 1 1 0
 2 2 2 1 1 2 2 2 1 1 1 1 1 2 1 1 1 1 2 2 2 0 0 2 2 1 1 1 1 1 1 2 2 2 2 2 2
 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2
 2 2 2 2 2 2 2 2 2 2 2 2 2 2 2 1 1 0 0 2 0 0 0 0 0 0 2 2 1 1 0 0 0 0 0 0 0
 2 2 0 0 0 0 1 2 1 0 2 2 1 1 0 2 0 0 0 0 0 0 1 0 2 2 0 0 0 0 2 0 0 2 1 1 0
 0 0 0 2 2 0 0 0 0 0 0 2 2 2 2 2 2 0 2 0 0 0 0 0 1 1 2 2 2 2 0 0 0 0 0 0 1
 2 0 0 0 0 1 2 0 1 2 1 2 1 1 1 2 2 0 1 0 0 0 0 0 0 0 0 0 0 0 0]
Testing...
Train rate: 84.631579:

Just wanted to mention that I am not exactly using rc_driver.py but an equivalent script just to check predictions of my network and not worry about the ultrasonic sensor or stop signs. I have uploaded it as a gist here

@smahajan07 You could do cross validation to see how good the model is performed. Of course, if your keep using the same track then a high accuracy on training set is sufficient, overfitting is irrelevant in this case.

@hamuchiwa I will try to cross validate my training set and get back, in the mean time could you tell me if the procedure I am following is faulty.
Before training it on dozens of different tracks, I am training it on 2 tracks (straight and then right/left respectively) back and forth. The data being collected is approximately 500 images in total. Using the now generated npz files I'm running the 'mlp_training.py' and getting an xml file.
What concerns me is the training is happening too fast (i didn't expect this on my i5 and integrated graphics card, I have a server but not currently using it for this) and that every time my xml file is approx 35 MB (even though I change my number of training images).
I know these are very trivial concerns,but let me know if you have any suggestions.
Also, what is the minimum number of images that we should train the neural network on?

@hamuchiwa I am planning to create a branch for this repo where in those who are making this project using an external webcam (and not raspi cam) and use a different streaming method (and not socket server).

@smahajan07 Hi, I think 500 images in total is good enough. If you are not entirely satisfied with your training data, you could "cheat" a bit meaning that you can manually put the car on the track where you think it should be, then create a sample, and then do ti over and over again. Sometimes I found this helpful as I do make mistakes while controlling the rc car, but it is really tedious doing this...
The xml file contains weights and biases for your trained model, the dimension of the weights matrix and bias matrix depends on the architecture of the neural network (layer size) rather than number of samples. If you have a deep neural network then you probably would see the file size increase.

@hamuchiwa , I cross validated my data set and it looks promising, but I am unfortunately facing the same problem that my script (an equivalent to your rc_driver.py, instead only focuses on driving, no signs or distance calculation) is causing some problem and the only output I am receiving is 'LEFT'.
And this cross validation was performed by inputting the complete image and not just half. Also I changed the layer size to [(76800, 64,4)].
    Loading training data...
    ['train_labels', 'train']
    (114, 76800)
    (114, 4)
    ['train_labels', 'train']
    (100, 76800)
    (100, 4)
    ['train_labels', 'train']
    (122, 76800)
    (122, 4)
    ['train_labels', 'train']
    (75, 76800)
    (75, 4)
    (411, 76800)
    (411, 4)
    Loading image duration: 1.81404559868
    Training MLP ...
    Training duration:<PHONE_NUMBER>89
    Ran for 76 iterations
    Prediction: [2 2 2 2 0 0 0 0 0 0 0 0 0 0 0 0 2 0 0 0 0 0 0 0 0 2 1 1 0 0 2 2 0 0 0 0 0
     0 0 0 0 0 0 0 0 0 0 0 0 0 2 2 2 2 2 1 1 1 1 1 1 2 0 0 1 1 1 1 1 1 2 2 2 2
     2 1 1 1 0 0 2 2 2 2 0 0 2 2 0 0 0 2 2 2 2 0 0 0 0 3 3 2 0 0 0 0 0 0 0 0 0
     0 0 0 2 2 2 1 1 1 1 1 1 2 2 0 0 0 0 0 1 1 2 2 2 2 2 0 0 1 1 0 0 0 0 0 0 0
     1 1 1 1 0 0 0 0 0 0 2 0 0 0 0 0 0 0 0 0 0 0 2 0 0 1 1 1 1 1 1 1 1 1 1 1 1
     1 1 0 0 2 0 1 1 1 2 2 0 0 0 0 0 2 0 0 0 0 0 0 0 0 0 0 1 1 1 1 1 1 2 0 0 2
     2 1 1 0 1 2 2 2 1 2 2 0 0 0 0 1 1 0 0 0 0 0 0 0 0 0 0 0 0 1 1 0 0 1 1 1 1
     1 0 1 1 1 0 0 2 2 1 1 1 1 1 1 1 1 1 0 0 0 2 2 2 2 2 0 0 2 2 2 2 0 0 0 0 3
     2 2 1 1 1 1 1 1 2 2 2 2 2 2 0 0 1 1 0 0 0 2 2 2 0 0 0 0 1 0 0 1 1 1 1 1 1
     1 1 2 2 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 2 2 2 2 2 2 2 2 0 0 0 0 0 0 0 0
     0 0 0 0 0 0 0 0 0 0 1 1 1 2 2 2 2 2 2 2 2 1 1 1 1 1 1 1 1 1 1 1 1 2 2 2 2
     2 2 2 2]
    True labels: [2 2 2 2 0 0 0 0 0 0 0 0 0 0 0 0 2 0 0 0 0 0 0 0 2 2 1 1 0 0 2 2 0 0 0 0 0
     0 0 0 0 0 0 1 1 0 0 0 0 0 2 2 2 2 2 1 1 1 1 1 1 2 0 0 1 1 1 1 1 1 0 0 2 2
     2 1 1 0 0 0 2 2 2 2 0 0 2 2 0 0 3 2 2 2 2 0 0 0 0 1 1 2 0 0 0 0 0 0 0 0 0
     0 0 0 2 2 2 1 1 1 1 1 1 2 2 0 0 0 0 1 1 1 2 2 2 2 2 0 0 2 0 0 0 0 0 0 0 0
     1 1 1 1 0 0 0 1 1 0 2 0 0 0 0 0 0 0 0 0 0 1 2 0 0 1 1 1 1 1 1 1 1 1 1 1 1
     1 1 0 0 2 0 1 1 1 2 2 0 0 0 0 2 2 0 0 0 0 0 0 0 0 0 0 1 1 1 1 1 1 2 0 0 2
     2 1 1 0 1 2 2 2 2 2 2 0 0 0 0 1 1 0 2 0 0 0 0 0 0 0 0 0 0 1 1 0 0 1 1 1 1
     1 0 1 1 0 0 0 1 1 1 1 0 0 1 1 1 1 0 0 0 0 2 2 2 2 2 0 0 2 2 2 2 0 0 0 0 3
     2 2 1 1 1 1 1 1 2 2 0 2 2 2 0 0 1 1 0 0 1 2 0 2 0 0 0 0 1 0 0 1 1 1 1 1 1
     1 1 2 2 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 2 2 2 2 2 2 2 2 0 0 0 0 0 0 0 0
     0 0 0 0 0 0 0 0 2 2 1 1 2 2 2 2 2 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 2 2 2 2
     2 2 2 2]
    Train rate: 91.727494:
    ['train_labels', 'train']
    (75, 76800)
    (75, 4)
    (411, 76800)
    (411, 4)
    Testing Prediction: [2 2 2 2 0 0 0 0 0 0 0 0 0 0 0 0 2 0 0 0 0 0 0 0 0 2 1 1 0 0 2 2 0 0 0 0 0
     0 0 0 0 0 0 0 0 0 0 0 0 0 2 2 2 2 2 1 1 1 1 1 1 2 0 0 1 1 1 1 1 1 2 2 2 2
     2 1 1 1 0 0 2 2 2 2 0 0 2 2 0 0 0 2 2 2 2 0 0 0 0 3 3 2 0 0 0 0 0 0 0 0 0
     0 0 0 2 2 2 1 1 1 1 1 1 2 2 0 0 0 0 0 1 1 2 2 2 2 2 0 0 1 1 0 0 0 0 0 0 0
     1 1 1 1 0 0 0 0 0 0 2 0 0 0 0 0 0 0 0 0 0 0 2 0 0 1 1 1 1 1 1 1 1 1 1 1 1
     1 1 0 0 2 0 1 1 1 2 2 0 0 0 0 0 2 0 0 0 0 0 0 0 0 0 0 1 1 1 1 1 1 2 0 0 2
     2 1 1 0 1 2 2 2 1 2 2 0 0 0 0 1 1 0 0 0 0 0 0 0 0 0 0 0 0 1 1 0 0 1 1 1 1
     1 0 1 1 1 0 0 2 2 1 1 1 1 1 1 1 1 1 0 0 0 2 2 2 2 2 0 0 2 2 2 2 0 0 0 0 3
     2 2 1 1 1 1 1 1 2 2 2 2 2 2 0 0 1 1 0 0 0 2 2 2 0 0 0 0 1 0 0 1 1 1 1 1 1
     1 1 2 2 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 2 2 2 2 2 2 2 2 0 0 0 0 0 0 0 0
     0 0 0 0 0 0 0 0 0 0 1 1 1 2 2 2 2 2 2 2 2 1 1 1 1 1 1 1 1 1 1 1 1 2 2 2 2
     2 2 2 2 3 3 3 2 3 3 3 3 0 0 3 3 3 3 3 1 1 0 0 2 2 3 0 0 0 0 0 0 0 0 0 0 1
     1 1 2 2 3 3 3 3 2 2 2 2 2 1 1 1 1 1 1 1 2 2 3 3 0 0 0 2 0 2 0 0 1 1 1 1 1
     1 2 2 2 2]
    Testing True labels: [2 2 2 2 0 0 0 0 0 0 0 0 0 0 0 0 2 0 0 0 0 0 0 0 2 2 1 1 0 0 2 2 0 0 0 0 0
     0 0 0 0 0 0 1 1 0 0 0 0 0 2 2 2 2 2 1 1 1 1 1 1 2 0 0 1 1 1 1 1 1 0 0 2 2
     2 1 1 0 0 0 2 2 2 2 0 0 2 2 0 0 3 2 2 2 2 0 0 0 0 1 1 2 0 0 0 0 0 0 0 0 0
     0 0 0 2 2 2 1 1 1 1 1 1 2 2 0 0 0 0 1 1 1 2 2 2 2 2 0 0 2 0 0 0 0 0 0 0 0
     1 1 1 1 0 0 0 1 1 0 2 0 0 0 0 0 0 0 0 0 0 1 2 0 0 1 1 1 1 1 1 1 1 1 1 1 1
     1 1 0 0 2 0 1 1 1 2 2 0 0 0 0 2 2 0 0 0 0 0 0 0 0 0 0 1 1 1 1 1 1 2 0 0 2
     2 1 1 0 1 2 2 2 2 2 2 0 0 0 0 1 1 0 2 0 0 0 0 0 0 0 0 0 0 1 1 0 0 1 1 1 1
     1 0 1 1 0 0 0 1 1 1 1 0 0 1 1 1 1 0 0 0 0 2 2 2 2 2 0 0 2 2 2 2 0 0 0 0 3
     2 2 1 1 1 1 1 1 2 2 0 2 2 2 0 0 1 1 0 0 1 2 0 2 0 0 0 0 1 0 0 1 1 1 1 1 1
     1 1 2 2 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 2 2 2 2 2 2 2 2 0 0 0 0 0 0 0 0
     0 0 0 0 0 0 0 0 2 2 1 1 2 2 2 2 2 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 2 2 2 2
     2 2 2 2 2 2 2 2 0 0 2 2 2 2 1 1 1 1 1 1 1 1 1 0 2 2 2 2 1 1 1 1 1 1 1 1 1
     1 2 0 2 2 1 1 2 0 0 1 1 0 0 0 1 2 2 2 2 2 2 2 2 0 0 0 2 2 3 0 0 0 0 0 0 1
     1 1 1 0 2]
    Test rate: 81.481481:
    Process finished with exit code 0

Could you look at my script and see if something is wrong?

@hamuchiwa
I'm so sorry, there was a very minor bug in my code. It was not looking in the right folder. :/
I apologize for the confusion, and thanks for your help.
Everything is fine, except my the response is a little delayed. Do you have any suggestions to speed up the response?

@smahajan07 You could lower the image resolution, or maybe create a buffer and use two threads, one for just getting image from camera, another for streaming. Another "quick" way is to make your car go slower...

@hamuchiwa I am planning to create a branch for this repo where in those who are making this project using an external webcam (and not raspi cam) and use a different streaming method (and not socket server).

Did you manage to do it?


v1.12.2 hotfix

Changes

https://github.com/kubeshop/testkube/issues/4009

Fixes

How to test it

screenshots

Checklist

[ ] tested locally
[ ] added new dependencies
[ ] updated the docs
[ ] added a test

E2E tests are failing most likely because we don't have this mechanism merged into the main branch yet.


Minify Razor Output

As covered by @madskristensen in his recent blog post, minifying HTML, in addition to GZipping, can provide significant file size reductions.
Getting HTML to the client as quickly as possible is the first step towards a speedy experience, and #1048 provides one way to do this.
If Razor provided a configuration option to minify the HTML it was generating, we'd have another.
JSON.NET has a setting for minifying the JSON it produces. A similar switch in Razor configuration would be awesome.
Of course, there are lots of things this switch could do. Here's a few things I'd expect, but this certainly isn't an exhaustive list:

Collapse whitespace
Collapse Boolean HTML attributes (e.g. <... disabled="disabled"> → <... disabled>)
Remove empty attributes (e.g. <... class=""> → <...>)
No need to remove HTML comments. Authors can use Razor comments if they don't want HTML comments to appear.
Remove default values. This might be dangerous? (e.g. <form method="get"> → <form>)

I'd expect Razor to operate the way it does today by default, but for this to be an opt-in setting so as to not break any JavaScript that is explicitly dependent on the HTML currently generated.

NOTE: Dean Hume does have an open source .NET HTML Minifier. But he admits to its simplicity and something better could be done.

For those who are following this issue but not the other one, you can hack up changes to the Razor MarkupChunkGenerator that will minify markup at compile-time: aspnet/Razor #444. It's rough and I did it at 3am last night, but it seems to work ok. Something like that could be provided now (with an MVC options switch so that devs would be opting-in if they want it) even if it doesn't hit all of the edge cases, then the team could address it properly next year.
I'm still hoping this issue will be moved off the backlog. The bandwidth savings are huge; and as @DamianEdwards pointed out on yesterday's Community Standup (9/8), Razor has gone through several generations now without this much-needed capability. Think of the :deciduous_tree: :palm_tree: :evergreen_tree: that can be saved by doing this now.


chore: add prettier terraform formatting in markdown files

This PR enables Terraform formatting in markdown files (via bun fmt). Since the prettier-plugin-terraform-formatter plugin doesn't register hcl we also rename all code-blocks to tf, atlernatively we could patch the plugin but I think this is fine.

chore: add prettier terraform formatting in markdown files
rename hcl codeblocks to tf to enable formatter
bun fmt
fix invalid tf
bun fmt

Should we add a lint check to make sure there is no hcl codeblocks?

Should we add a lint check to make sure there is no hcl codeblocks?

That's a good idea 👍🏻


Refactor/footer

Resolves #23
What kind of change does this PR introduce?

Refactor Footer component to adhere to Carbon Design System's look and feel.
Optimize Footer component code to remove unused features and adhere to BEM class naming conventions.

Testing instructions

Run yarn develop.
Review Footer implementation.

Also, I was prompted to install the following - should these get added to the package.json?
carbon-components-react
react-disqus-comments

@kellychurchill fixed your what you requested, it's ready for your review again.


TypeError: argument 'ids': 'NoneType' object cannot be converted to 'Sequence'

I face this error whenever I trying to evaluate a model with a benchmark type generation or (Open Question)  like triviaqa, nq_open and truthfulqa
Is there anyone face this problem ?

Without more information we can't help you solve this issue.
What command are you running when you receive this error? What model type and specific model are being used for evaluation? What are any other relevant system details?

I tried this command in the picture to evaluate model: huawei-noah/TinyBERT_General_4L_312D
also I tried it with model: Intel/dynamic_tinybert
and I tried it with these tasks: triviaqa, nq_open and truthfulqa
in every time I got this error

Is there any update?


Get's stuck with the same password

It works fine but on the process of finding the password it gets stuck and it gets repeated. Sometimes it gets stuck by repeating a password that doesn't work and after that it changes the ip and then tries the same password and so on

Dm seve,services on instagram if you still need help with this issue

same for me. Are you using kali linux??


[BUG] No SenderKeyRecord found for decryption

Describe the bug
I have a server with 15 connected whatsapp users.
I find this on the log from time to time:
{
  "level": 50,
  "time":<PHONE_NUMBER>643,
  "pid": 41327,
  "hostname": "ip-xxx-xxx-xxx-xxx",
  "key": {
    "remoteJid"<EMAIL_ADDRESS>    "fromMe": false,
    "id": "FD997580F27B33CF3430FB6A0D3FA104",
    "participant"<EMAIL_ADDRESS>  },
  "err": {
    "type": "Error",
    "message": "No SenderKeyRecord found for decryption",
    "stack": "Error: No SenderKeyRecord found for decryption
   at xxx@g.us::xxx::0 [as awaitable] (/baileys/WASignalGroup/group_cipher.js:49:15)
   at async asyncQueueExecutor (/baileys/WASignalGroup/queue_job.js:20:29)"
  },
  "msg": "failed to decrypt message"
}

To Reproduce
Don't know how to reproduce, it happens from time to time on a server with 15 connected whatsapp users.
Expected behavior
No errors on the log
Environment (please complete the following information):

Is this on a server? yes
What do your connectOptions look like?

const { version, isLatest } = await fetchLatestBaileysVersion()
const { state, saveCreds } = await useMultiFileAuthState('myPath')
const msgRetryCounterCache = new NodeCache()

        async function getMessage(key)  {
            if(store) {
                const msg = await store.loadMessage(key.remoteJid, key.id)
                return msg?.message || undefined
            }
            // only if store is present
            return proto.Message.fromObject({})
        }

 makeWASocket({
            version,
            logger,
            printQRInTerminal: false,
            mobile: false,
            auth: {
                creds: state.creds,
                keys: makeCacheableSignalKeyStore(state.keys, logger),
            },
            msgRetryCounterCache,
            generateHighQualityLinkPreview: true,
            // ignore broadcast and newsletter messages
            shouldIgnoreJid: jid => !jid || isJidBroadcast(jid) || isJidNewsletter(jid),
            // implement to handle retries & poll updates
            getMessage,
            shouldSyncHistoryMessage: () => true,
            markOnlineOnConnect: false
        })

Do you have multiple clients on the same IP? yes, 15 clients
Are you using a proxy? no

Additional context
Using baileys v6.7.5

These bugs may be related
https://github.com/WhiskeySockets/Baileys/issues/885
https://github.com/WhiskeySockets/Baileys/issues/886
https://github.com/WhiskeySockets/Baileys/issues/887
https://github.com/WhiskeySockets/Baileys/issues/888

The auth session lost the senderKeyRecord

Same, using SQL


Build Swift 2.2.1 Fail

$ swiftenv install 2.2.1
Downloading swift (swift-2.2.1-RELEASE)
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   132    0   132    0     0    371      0 --:--:-- --:--:-- --:--:--   371
100 8245k    0 8245k    0     0  3806k      0 --:--:--  0:00:02 --:--:-- 6934k
Downloading swift-llvm (swift-2.2.1-RELEASE)
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   137    0   137    0     0    419      0 --:--:-- --:--:-- --:--:--   420
100 21.5M    0 21.5M    0     0  4424k      0 --:--:--  0:00:04 --:--:-- 5977k
Downloading swift-clang (swift-2.2.1-RELEASE)
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   138    0   138    0     0    430      0 --:--:-- --:--:-- --:--:--   429
100 12.3M    0 12.3M    0     0  4184k      0 --:--:--  0:00:03 --:--:-- 6868k
Downloading swift-lldb (swift-2.2.1-RELEASE)
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   137    0   137    0     0    412      0 --:--:-- --:--:-- --:--:--   413
100 13.5M    0 13.5M    0     0  4432k      0 --:--:--  0:00:03 --:--:-- 6802k
Downloading swift-cmark (swift-2.2.1-RELEASE)
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   138    0   138    0     0    425      0 --:--:-- --:--:-- --:--:--   425
100  209k    0  209k    0     0   146k      0 --:--:--  0:00:01 --:--:--  319k
Building Swift
This may take a very long time...
Building Swift failed
Check out the logfile for more information: [/usr/local/var/swiftenv/tmp/swiftenv-build-2.2.1/swiftenv-build.20180419150546.6911.log](https://paste.ee/p/8Zm6E#section0)
You can inspect or delete the working tree at:[ /usr/local/var/swiftenv/tmp/swiftenv-build-2.2.1](https://paste.ee/p/8Zm6E#section1)

https://paste.ee/p/8Zm6E - For the logs
Building 2.2.1 fails. I have ninja and cmake both installed...
I believe the problem is related to not having Xcode 7 installed. I was thinking of installing Xcode 7 and using xcode-select...or I also found xcode-install but it seems to have several problems that I dunno I want to deal.
I would appreciate any feedback...

Swift 2.2.1 has some very specific Xcode requirements, there's an open issue (https://github.com/kylef/swiftenv/issues/103) with the same problem so let's move over there.
Check out the last comment:

Slava suggested installing an older Xcode. I have 7.3.1 under a different name, so I switched the Tools (using xcode-select), and it still didn't work. Then I noticed in the log that it wasn't using xcrun; instead the script is using the default Tools location. So, I renamed my current Xcode.app, renamed my copy of Xcode 7.3.1 to Xcode.app, and tried again. The build worked, then, and I was able to install v2.2.1 successfully.

I'd install Xcode 7.3.1 and give that a go, you might hit same problem as leanne63 did so you may need to fiddle with Xcode to select the correct one.

@kylef good looking out! I forgot to look for closed issues! Thanks.


scip-java for Bazel does not handle .srcjar inputs

Hey, thanks for this tool. We just started trying it out to try and index Java code in our Bazel monorepo.
We hit an issue where running the Bazel aspect would hit compilation failures for some code. e.g.
info: /tmp/scip-java3739267713397442642/s/com/x/y/z/File.java:33: error: cannot find symbol
info:     @MissingClass private final String some_variable;
info:      ^
info:   symbol:   class MissingClass
info:   location: class AnotherClass

Digging deeper, it turns out that MissingClass is a java file that is stored in a .srcjar, that is passed as an input to a java target. We use the .srcjar mechanism to allow us to generate some Java files beforehand and easily pass them to a java target (for those unfamiliar with srcjar in Bazel, it is simply just a normal jar of .java files, that Bazel will first unpack before passing to the javac compiler)
It looks like scip-java calls javac directly, but does not unpack the .srcjar contents beforehand, and so it fails.
Here is a small repro. Note interestingly the scip-java run does work for this small repro, but we get an error message "Some SemanticDB files got generated even if there were compile errors. In most cases, this means that scip-java managed to index everything except the locations that had compile errors and you can ignore the compile errors.". However in the larger private example, it seems the compilation failure is blocking. If we run the command that the aspect is running, we see the compilation failure
# testing/BUILD.bazel
genrule(
    name = "generated-srcjar",
    outs = ["sources.srcjar"],
    cmd = "echo 'package com.testing; public class Bar {};' > Bar.java && jar cf $(@) Bar.java",
)

java_library(
    name = "testing",
    srcs = [
        "Foo.java",
        ":generated-srcjar",
    ],
)

// testing/Foo.java
package com.testing;

public class Foo {
    public Bar foo(Bar value) {
        return value;
    }
}

$ bazel build //testing # successful
$ "/home/code/scip-java" index --no-cleanup --index-semanticdb.allow-empty-index --cwd "/home/code" --targetroot bazel-out/k8-dbg--cd/bin/testing/testing.semanticdb --scip-config "bazel-out/k8-dbg--cd/bin/testing/testing.scip.json" --output "bazel-out/k8-dbg--cd/bin/testing/testing.scip"
info: $ /opt/.../jdk/bin/javac @/home/code/bazel-out/k8-dbg--cd/bin/testing/testing.semanticdb/javacopts.txt
info: /home/code/testing/Foo.java:4: error: cannot find symbol
info:     Bar value;
info:     ^
info:   symbol:   class Bar
info:   location: class Foo
info: 1 error
info: Some SemanticDB files got generated even if there were compile errors. In most cases, this means that scip-java managed to index everything except the locations that had compile errors and you can ignore the compile errors.
info: Result of /opt/.../jdk/bin/javac…: 1

info: /home/code/bazel-out/k8-dbg--cd/bin/testing/testing.scip

Also, inside of the testing.scip.json, we see the srcjar listed in sourceFiles:
{
  ...
  "sourceFiles": [
    "testing/Foo.java",
    "bazel-out/k8-dbg--cd/bin/testing/sources.srcjar"
  ]
}

but then in the generated javacopts.txt, it disappears:
"-encoding"
"utf8"
"-nowarn"
"-d"
"/tmp/scip-java8260898732520975292/d"
"-s"
"/tmp/scip-java8260898732520975292/s"
"-h"
"/tmp/scip-java8260898732520975292/h"
"-classpath"
"/tmp/scip-java8260898732520975292/semanticdb-plugin.jar"
"-Xplugin:semanticdb -targetroot:/home/code/bazel-out/k8-dbg--cd/bin/testing/testing.semanticdb -sourceroot:/home/code"
"-source"
"11"
"-target"
"11"
"-g"
"-parameters"
"/home/code/testing/Foo.java"

As a side note, I notice that scip-java calls javac directly from the provided JAVA_HOME. Bazel has a wrapper around Javac that you'll see in the "Javac" action. 2 points from this:

It seems sub-optimal to rely on the JAVA_HOME variable set on the system, as it can potentially be different than what is configured for Bazel. Maybe it could access the java_home from the toolchain instead, and then this env variable doesn't need to be used?

It could be done by adding an attrs to the aspect, then accessing it like so:
attrs = {
        "_jdk": attr.label(default = Label("@bazel_tools//tools/jdk:current_host_java_runtime")),
    },

...
"javaHome": ctx.attr._jdk[java_common.JavaRuntimeInfo].java_home,

# also need to include 'ctx.attr._jdk[java_common.JavaRuntimeInfo].files' as an input to the ScipJavaIndex action

I tried testing by modifying the command line that bazel uses to compile the Javac action (i.e., add -Xplugin:semanticdb ... to javacopts and semanticdb-plugin.jar to the classpath in the command line). This did seem to work, handling the .srcjar appropriately, and generating the semanticdb data. Might be an avenue to explore, but unsure how complex it is to integrate.

@JohnnyMorganz are you using scip-java as a Sourcegraph customer? If so, would you mind reaching out through your account's assigned Support Engineer for help?

Yes we are, I can forward it to them thanks


#26789 Save empty GIS geometries to the database

Previously Falsey geometry objects didn't get saved, which is a random mix depending on their types & content. Every geometry object is now explicitly saved regardless of Truthiness.
EMPTY handling isn't that great with the supporting libraries/DBs, but this at least always ensures the geometry is passed to the database to decide.

Skips issue with GEOS 3.5.0 for 'POINT EMPTY'
Skips issue with PostGIS 2.2.2 for 'POLYGON EMPTY'

This is still a WIP for ticket discussion

buildbot, add to whitelist.

The test04_city failures in the build are fixed in 081fdaf110386db940d834ba51d93e23aa293fcd. Looks like the proposed test doesn't pass on MySQL though.

Officially GeoDjango supports GEOS 3.3 and 3.4 (at least according to current state of docs). Also I don't feel very confident that result of saving empty geometries is so fuzzy across the different versions of libs and database backends.

Yeah, I guess the question is do we pass it to the database and caveat emptor from there, or do we try and restrict/normalise behaviour on the Django side? If you're happy with the approach I can do some more testing on different GEOS/PostGIS versions.

This may be actually backwards incompatible change which may cause currently functioning code to stop functioning after these changes.
Implementation is really tricky since GeoDjango supports four backends: Spatialite, PostGIS, Oracle and MySQL and they all seem to behave slightly differently specially if geom column is nullable then with some backends you don't get out the value that you put in.
Spatialite fails with empty geometries (seems to implicitly casts them to NULL)
Oracle fails with empty geometries currently (Oracle built-in WKT converter doesn't support empty geoms, tested with 10g and 11g. Not with 12c)
PostGIS seem to fail with some empty geometries  (version dependent?)
MySQL seems to fail empty geoms just like spatialite (implicit cast empty geom to NULL)
I suggest that you add also a test case when you insert empty geometries to nullable geometry field just to check that you really get empty geometry value back - not None.

This may be actually backwards incompatible change which may cause currently functioning code to stop functioning after these changes.

For us this was a regression between 1.7 & 1.8 where it stopped working (specifically MULTIPOLYGON EMPTY changed to save as NULL)

I suggest that you add also a test case when you insert empty geometries to nullable geometry field just to check that you really get empty geometry value back - not None.

Yep, I can add some more tests.

Apparently somewhere after 1.6 code changed from https://github.com/django/django/blob/stable/1.6.x/django/contrib/gis/db/models/fields.py#L257-L262 to just test false value (which in turn checks object len)
Given that, I think it would be best to rollback to 1.6.x code, and preferably let backend adapters to make checks against empty geoms if needed.
At least this behavior should be documented so nobody gets surprises.

https://code.djangoproject.com/ticket/23731 committed in https://github.com/django/django/commit/d6d55368d45ca05c4c08c4981f9dba5c9b2bd72e was the change made.
The change proposed in this PR still casts blanks to None but lets genuine geometry objects through, which will mirror the old behaviour but (AFAICT) also allow 23731 to pass. Which then leaves EMPTY behaviours up to the backend.
Alternatively:
if value is None or (isinstance(value, str) and value == ''):
  return None
else:
  return connection.ops.Adapter(self.get_prep_value(value))

Hi, Are you blocked on anything to complete this? Just want to help if I can.

Closing due to inactivity.


makemigrations didn't applied in v<IP_ADDRESS>

django summernote needs makemigrations before migrate.
version <IP_ADDRESS>

Could you share the migration code?

0003_auto_20170921_0131.py file:
# -*- coding: utf-8 -*-
# Generated by Django 1.11.5 on 2017-09-20 16:31
from __future__ import unicode_literals

from django.db import migrations, models

class Migration(migrations.Migration):

    dependencies = [
        ('django_summernote', '0002_update-help_text'),
    ]

    operations = [
        migrations.AlterField(
            model_name='attachment',
            name='name',
            field=models.CharField(blank=True, help_text='Defaults to filename, if left blank', max_length=255, null=True),
        ),
    ]

Not with master branch, but happends with v<IP_ADDRESS> tag branch :)

Thank you for sharing. Then it should occur by missing of unicode_literals in the previous migration file.

I will close this issue after releasing the next version.


Add toggle for metronome in right-click menu on prayer orb

As requested on Discord.

Closing this as this is unreasonable request as metronome has not much to do with prayer.


GH-43453: [Format] Add Opaque canonical extension type

Rationale for this change
Add the newly ratified extension type.
What changes are included in this PR?
The type specification only.
Are these changes tested?
N/A
Are there any user-facing changes?
No.

GitHub Issue: #43453

For future reference, most discussion happened in https://github.com/apache/arrow/pull/41823


Two more regression samples & fix bug on thumbnail upside down

2 more reg samples :

Maximum
RegMax

Thumbnail were also upside down ! The problem is thumbnails and network are not generated the same way (network comes from svg data). The easiest was to fix the renderThumbnail function.

I signed it!

@googlebot  You're welcome.


Android 12 and Java 11

Description
Need to validate compliance with the upcoming release of Android 12

Testing on Android 12 today and while I needed to manually set up the adb reverse to hit the bundler (unexpected, maybe not Detox' problem - adb reverse tcp:8081 tcp:8081) everything in the react-native-firebase e2e tests appeared to pass with Detox current-as-of-now - v18.20.4
Note that we are not doing anything fancy with regard to artifacts and dialogs and permissions and such, but it does at least run, vs ios15 which is currently a crash-on-startup per #2895

Thanks @mikehardy, that's great input.

If you just need to bump your app to targetSdkVersion 31, this diff will work as a patch file named patches/detox+18.23.1.patch in your apps for patch-package, proposed in #3055 and in use now in react-native-firebase's e2e test harness
diff --git a/node_modules/detox/android/detox/build.gradle b/node_modules/detox/android/detox/build.gradle
index 8bef864..3689459 100644
--- a/node_modules/detox/android/detox/build.gradle
+++ b/node_modules/detox/android/detox/build.gradle
@@ -86,12 +86,12 @@ dependencies {
     // Versions are in-sync with the 'androidx-test-1.2.0' release/tag of the android-test github repo,
     // used by the Detox generator. See https://github.com/android/android-test/releases/tag/androidx-test-1.2.0
     // Important: Should remain so when generator tag is replaced!
-    api('androidx.test.espresso:espresso-core:3.3.0') { // Needed all across Detox but also makes Espresso seamlessly provided to Detox users with hybrid apps/E2E-tests.
+    api('androidx.test.espresso:espresso-core:3.4.0') { // Needed all across Detox but also makes Espresso seamlessly provided to Detox users with hybrid apps/E2E-tests.
         exclude group: 'com.google.code.findbugs', module: 'jsr305'
     }
-    api 'androidx.test.espresso:espresso-web:3.3.0' // Web-View testing
-    api 'androidx.test:rules:1.2.0' // Needed because of ActivityTestRule. Needed by users *and* internally used by Detox.
-    api 'androidx.test.ext:junit:1.1.1' // Needed so as to seamlessly provide AndroidJUnit4 to Detox users. Depends on junit core.
+    api 'androidx.test.espresso:espresso-web:3.4.0' // Web-View testing
+    api 'androidx.test:rules:1.4.0' // Needed because of ActivityTestRule. Needed by users *and* internally used by Detox.
+    api 'androidx.test.ext:junit:1.1.3' // Needed so as to seamlessly provide AndroidJUnit4 to Detox users. Depends on junit core.

     // Version is the latest; Cannot sync with the Github repo (e.g. android/android-test) because the androidx
     // packaging version of associated classes is simply not there...

If you open your android project in AndroidStudio and load the AndroidManifest.xml file, you should have a tab near the bottom that says "Merged Manifest", it is the result of AndroidStudio reading your manifest and all libraries etc manifests and combining them all in to what the system will see at the end.
In that window, you should be able to scan through and investigate to find whichever one is not setting exported correctly

Currently, the only known Detox issue is this: #3560

detox+18.23.1.patch

I have ensured that they are all being exported correctly now, but still have the same issue as @sergiulucaci :(

If you open your android project in AndroidStudio and load the AndroidManifest.xml file, you should have a tab near the bottom that says "Merged Manifest", it is the result of AndroidStudio reading your manifest and all libraries etc manifests and combining them all in to what the system will see at the end.
In that window, you should be able to scan through and investigate to find whichever one is not setting exported correctly

I have ensured that they are all being exported correctly now, but still have the same issue as @sergiulucaci :(

@CallumHemsley what I recommend is to make sure you have it set up correctly.
What I was missing was this:

In your root buildscript (i.e. android/build.gradle), register both google() and detox as repository lookup points in all projects:

// Note: add the 'allproject' section if it doesn’t exist
allprojects {
    repositories {
        // ...
        google()
        maven {
            // All of Detox' artifacts are provided via the npm module
            url "$rootDir/../node_modules/detox/Detox-android"
        }
    }
}


cmd/cgo: cannot create file using cgo function: file name becomes an invalid encoding

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go1.10.2 linux/amd64
Does this issue reproduce with the latest release?
not sure, didn't tested with anything above the version I have
What operating system and processor architecture are you using (go env)?
GOHOSTARCH="amd64"
GOHOSTOS="linux"
What did you do?
I'm trying to convert a GO program into a shared library to be used on my R script. At first I tested with something simple,  I have a  function that takes an input path (string) and creates a file on the disk. My problem is that the string with the path becomes something with an invalid encoding, see below:
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
This is my function:
import "C"

(...)

//export testWriter
func testWriter(path string) string {

	file, err := os.Create(path)
	if err != nil {
		return "error"
	}
	defer file.Close()

	return path
}

I compile the library with:
go build -o gowriter.so -buildmode=c-shared ./gowriter

And then I run my R script like this:
 Rscript -e 'dyn.load("/home/user/go/src/github.com/user/gowriter.so"); .Call("testWriter", "/home/user/test.txt")'

I also tried running this in a Python program:
from ctypes import *
lib = cdll.LoadLibrary("/home/user/go/src/github.com/prvst/testwriter.so")
lib.testReader("/home/user/test.txt")

And what I get is a file called  ` � (invalid encoding) `.  That's literally the file name, including that exclamation symbol you see there.
I added some print functions  trying to understand the problem and this is what I get :
fmt.Println(reflect.TypeOf(path))                     # string
fmt.Println(reflect.TypeOf(C.CString(path)))   # *main._Ctype_char
fmt.Println(C.CString(path))                            # 0x559b609e1210

I also tried this without any success:
func testWriter(path *C.char) *C.char {

	file, err := os.Create(C.GoString(path))
	if err != nil {
		return C.CString("error")
	}
	defer file.Close()

	return path
}

What I find curious is that the function ends at the return statement and I can see on the terminal the correct string with the path that was passed to the function.
What did you expect to see?
An empty file on my disk called test.txt
What did you see instead?
An empty file on my disk called � (invalid encoding)

Using func testWriter(path string) string definitely won't work.  You can only export a Go function that presents a C API, as documented at https://golang.org/cmd/cgo/#hdr-C_references_to_Go.  I don't know what R and Python are passing when they pass a string, but I'm sure it's not a Go string type.
The func testWriter(path *C.char) *C.char variant has a chance of working, depending on how R and Python pass strings when calling a C function.  What do you see with that version if you call fmt.Println(C.GoString(path))?

By the way, for questions about using Go, including using with other languages like R and Python, you are much more likely to get a better answer in a forum than on the issue tracker.  See https://golang.org/wiki/Questions .

Thanks for the fast reply.
This is the fmt.Println(C.GoString(path)) output:
�
just the symbol, nothing else.
About the forum; thanks I'll try that too. I tried Reddit without success.

Thanks for following up.  Glad you got it working.


failure in multiindex-based access in  Panel

Example:
import pandas as pn
ind = pn.MultiIndex.from_tuples([('a', 1), ('a', 2), ('b', 1), ('b',2)], names=['fist', 'second'])
wp = pn.Panel(np.random.random((4,5,5)), items=ind,
major_axis=np.arange(5), minor_axis=np.arange(5))
In [10]: wp['a']
...
KeyError: 'no item named a'
In [11]: wp.ix['a']
...
KeyError: 'no item named a'

Closing this, but in general need to hash out all the missing slicing features on panel.


Support DEMs

Once heightmap support is ready, we should add support to load a Digital Elevation Map. When loaded, we need to provide a basic API to query the main properties of the DEM, and then, load it as a heightmap.

Here's the latest series of PRs:

https://github.com/ignitionrobotics/ign-common/pull/292
https://github.com/ignitionrobotics/ign-rendering/pull/539
https://github.com/ignitionrobotics/ign-rendering/pull/560
https://github.com/ignitionrobotics/ign-physics/pull/315
https://github.com/ignitionrobotics/ign-gazebo/pull/1262

All PRs are merged.

Quick question, is there any documentation or tutorials on how to use this feature? I was unable to find any.

Unfortunately, the only tutorial available is from gazebo-classic found here: https://classic.gazebosim.org/tutorials?tut=dem&cat=build_world
It is outdated but will hopefully get you in the right direction. When following the tutorial, you should be able to copy this section into a Gazebo Garden compatible SDF world: https://github.com/gazebosim/gazebo-classic/blob/1bef2dc573aa15ca8a56b4a7dadb9905cf978582/worlds/heightmap_dem.world#L8-L54
If you'd like to contribute, feel free to open a PR for a newer tutorial on DEMs here: https://github.com/gazebosim/docs :smile:


music_478/r_0.wav is missing

Hi,
I found that music_478/r_0.wav is missing in audio.tar.gz.
Could you please add it to the audio.tar.gz?
Thank you.

Hi @Baiiiiiiiiii , thanks for pointing out the issue.
I update the google drive link in the readme. Now the audio.tar.gz should contain all the audio.


Rework Recorder to not depend on the Defects4j validation script

Similarly to #22, Recorder is mostly tailored for a specific benchmark. This is not too hard to do but will require investigation into the scripts of recorder and making a whole new docker image probably.

@Marti2203  - I believe you were able to make progress in this ?

Yes, I will add it this weekend. I found the script so will make some updates.


Scale data products to focus on variation in AGB distribution, not magnitude

Data products mostly disagree on the magnitude of AGB in places with high AGB, so it is difficult to see where they disagree about the relative distribution of AGB.  One possible way to focus in on this is to scale each dataset before calculating standard deviation across them.

Here's an example with AZ


[Localization/Typo] Check rendering of latin chars

Proposed changes
See #246

This does not seem to be a problem on my devices, maybe you can evaluate @gitgauner?

Some screenshots from my machine (latest macOS):
Latest Chrome:

Latest Firefox:

In Chrome, diacritic marks are visibly misplaced.
In Firefox it looks slightly better but I can still see Polish characters (ą, ó, ź, ł) looking different than their 'regular' counterparts (e.g. compare 'ą' and 'a'). Same applies to Czech version, but it's not that apparent.
On Android the issue doesn't occur (default system font is used).
That usually means webfont files used in the project don't contain required letters in their character table.
I had a look at the font repository and I'm afraid the issue might not be fixable until the authors add missing characters to the font (see https://github.com/github/mona-sans/issues/20 or https://github.com/github/mona-sans/issues/16) 😢

This really seems like an issue with mona sans, which is very sad, but unfortunately we can not change anything about the font atm.
We'll keep an eye on it and update this issue as soon as we can update the dependency. 😊


Support named PK constraints

Summary of the changes / Why this improves CrateDB
Resolves https://github.com/crate/crate/issues/11025 which is to allow PK constraints to be named. PK names can be handled the same way as the names for check constraints. The only difference should be that the PK is unique per table. When PK names are provided, they will be persisted in meta mapping with primary_key_constraint_name as the key.
Checklist

[x] Added an entry in the latest docs/appendices/release-notes/<x.y.0>.rst for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in the latest docs/appendices/release-notes/<x.y.0>.rst
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

retest this please
unrelated test failed

Noticed https://github.com/crate/crate/blob/bf3eab10bbab3096a93fcb17cfa4cefd04374e4f/server/src/main/java/io/crate/execution/ddl/tables/TableCreator.java#L105, will do this after merging this PR.

Noticed
https://github.com/crate/crate/blob/bf3eab10bbab3096a93fcb17cfa4cefd04374e4f/server/src/main/java/io/crate/execution/ddl/tables/TableCreator.java#L105
, will do this after merging this PR.

If there is no cost in keeping it we don't need to remove it.
It would break create table in mixed version clusters with old nodes. People sometimes skip versions,  so supporting this a bit longer is an upside

we need to add the pk to pg_constraint table: https://www.postgresql.org/docs/current/catalog-pg-constraint.html

This can be done in a follow up PR. We've basic exposure via information_schema.table_constraints
Please don't increase the scope of PRs if not necessary

we need to add the pk to pg_constraint table: https://www.postgresql.org/docs/current/catalog-pg-constraint.html

This can be done in a follow up PR. We've basic exposure via information_schema.table_constraints Please don't increase the scope of PRs if not necessary

Of course I don't mind if this is done as a followup, but I thought I should mention as it's missing, and to me it seems to "belong" to the same scope.

Thanks for reviewing @matriv, Please check again.
Regarding ddl/create-table.rst, I did not find much information regarding primary keys nor constraints in general so I did not update it.

cr> create table t (a int constraint c_123 primary key);
CREATE OK, 1 row affected  (1.883 sec)
cr> select conname from pg_catalog.pg_constraint where conname = 'c_123';
+---------+
| conname |
+---------+
| c_123   |
+---------+
SELECT 1 row in set (0.026 sec)

It looks like pg_catalog.pg_constraint is implicitly taken care of.

thx for checking!  then, you can just add a test that tests an explicit pk name.

Of course I don't mind if this is done as a followup, but I thought I should mention as it's missing, and to me it seems to belong to the same scope.

Oh sorry, I read that as needing to add the pg_constraint table. I forgot we already have it.

Oh sorry, I read that as needing to add the pg_constraint table. I forgot we already have it.
No worries!


⚠ Secret Website 3 has degraded performance

In 43cedb3, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2983 ms

Resolved: Secret Website 3 performance has improved in 2486f60.


add possiblity to edit profiles

This could be as simple as loading a existing profile into the builder and then deleting the old profile. You do have to remember to save otherwise it will be deleted.

was already done, didn't see that there was the button


Feature: filter preset

closes #108 with working prototype.
advantages:

I have example code in the image below that works using a jsonserializer.
Imgur image
The button Button_Write_Click saves the filterpreset to a json file and the Button_Read_Click reads the filterpreset from the json file and applies it on the datagrid.

disadvantages:

the package will depend on Newtonsoft.json, because we need [JsonIgnore] attributes on the FilterCommon class

video:
you can watch the video of how it works here:

https://youtu.be/1Box0_oVUJo
it waits for 5 seconds before it filters, so it is not slow even though it looks like

Hello Ericvdberge,
Thank you for having taken into account the recommendation not to use an external dependency, your code advantageously replaces the use of this one.
However, please note that the version on which you developed the "filter preset" functionality is deprecated since the integration of nested object support (1.2.8).
I won't make any further changes until your solution has matured.
best regards

@macgile, yes it is hard to make something work. Normally, you would use the namespace System.Text.Json.JsonSerializer, because it is an internal class within c# to serialize and deserialize objects into json format and the other way arround. The problem I encounter, is that this is not supported by .net framework. At that time, it was not included into c#. I am searching for a solution to work, but it takes some time i guess

@ericvdberge I think we should remove JSON Load & Save feature, developer can handle this feature himself. It might be enough if we just add a feature to set the filter. what are you thinking?

Hi @BEDIRHANSAMSA, I think this is not possible, or we should adapt the FilterCommon class.

I think no one is going to set a filterpreset from memory (without saving a preset to a file)
The filtercommon class is not serializable, because it has properties like public Type FieldType { get; set; } or public PropertyInfo FieldProperty { get; set; }. These properties are not serializable. someone that wants to save the preset to a file does not know the contents of the filtercommon class, and needs to guess which properties to serialize? I think that is not really a solid solution.

I agree that we should not make a feature to save it in a certain format, but I think that we at least should make it possible to json serialize the preset. What I mean by that is that we should make the class serializable, but not make the feature to save it (if you understand what I try to say here)
Do you agree?


feat: allow float for image size

SVGs allow for floating point width and height in the viewbox definition Illustrator and other editing tools generate floating point values and the SVG support code in development use the Viewbox width and height for the image width and height.  While the SVG implementation in willow could round this width and height, from a fidelity perspective it is best to defer rounding to as late a possible to minimize artifacts such as skewing that could be created by rounding errors.
For example a designer with a poorly scaled coordinate system who zoomed in way to far in illustrator and ended up with a viewbox like 0 0 0.320 0.480. If we rounded this at image  load it would result in a 1x1 image. if max: 320x480 were set, it would result in a 320x320 with pretty extreme skewing.  However if the max operation mathematically scales .320x.480 it would yield a 320x480 image.

Please check the following:

[ ] Do the tests still pass?[^1]
[ ] Does the code comply with the style guide?

[ ] Run make lint from the Wagtail root.

[ ] For Python changes: Have you added tests to cover the new/fixed behaviour?
[ ] For front-end changes: Did you test on all of Wagtail’s supported environments?[^2]

[ ] Please list the exact browser and operating system versions you tested:
[ ] Please list which assistive technologies [^3] you tested:

[ ] For new features: Has the documentation been updated accordingly?

Please describe additional details for testing this change.
[^1]: Development Testing
[^2]: Browser and device support
[^3]: Accessibility Target

@dopry are you able to add some unit tests for this?

We might need to consider how this relates to #8042 - there are known issues with rounding errors due to us performing multiple image/float conversions. (Since this specific PR is really just relaxing some validation criteria, I think the worst that could happen is that some existing faulty code that wrongly resizes something to <1 pixels will fail with an obscure error in the image library rather than a descriptive error up-front - but would be good to sanity-check that.)

I can work on some tests in a week or two. I'm not familiar with where these values are used, so I'm not sure what exactly to test. Are there any existing tests around scaling that would need to be modified or specific tests that you (@lb- , @gasman) would require?

Addressed as part of #9842.


Build: Only use -fPIE and -pie if soletta is shared library.

Signed-off-by: Guilherme Iscaro<EMAIL_ADDRESS>

It doesn't seem to make much sense.
Have you checked how are the binaries generated with your patch?
You can see hardening-check log if Position Independent Executable is enabled

@bdilly According to GCC these flags are used for shared libraries.
Take a look at gcc man pages.
"-fpic: Generate position-independent code (PIC) suitable for use in a shared library....."

You're Right I will create a new Pullreq.


Rename UrlRoutePredicate to Uri or Path

Finical issue.. But UrlRoutePredicate is much more an URI or even simply a Path but not an URL as referenced by RFC https://www.ietf.org/rfc/rfc3986.txt

I like Path since it uses a PathMatcher :-)


Frontend.Console: fix password confirm problem

Password confirmation returned successful when password was wrong, and returned with error when password was right.

LGTM

This is a bugfix, therefore it should target the stable branch (unless the bug doesn't exist there).

This is a bugfix, therefore it should target the stable branch (unless the bug doesn't exist there).

The bug doesn't exist in the stable branch 🤔

CI was failing in your fork. By looking into the issue I see it's something that is not related to your fix, as in, it's my responsibility (not yours) to fix it.
However, if CI is red, it is you the first person that have to look into the issue, not me. And if you determine that it's an issue that you shouldn't fix yourself or don't know how to fix, then you have to ask me about it, not leave this PR sitting here with a red CI.


work-for-faction.js not doing the best work

Reported by @MaKeG0

Even if the function detectBestFactionWork was finding the best work in the targetted faction, there was no code to actually do the best work, but it was keeping doing the last one he checked

PR #261 was offered as a solution, but the original intent was for this to be handled in the body of workForSingleFaction. I'll want to dig in and see what went wrong.

Should be working now. New behaviour is to re-detect what the best faction work is every minute (status update interval) - and now I've made sure we're correctly assigning that best work instead of leaving it as it was.
Thanks again for the report and stab at a solution @MaKeG0


Create patch_88_89_b.sql

Make hit_name in protein_feature table case sensitive. Required to store PDB features like 'abcd.a' and 'abcd.A'.

That's ok, but the schema changes need to be added to the table.sql. Tests are failing as the test databases need to be patched as well.
Please have a look at:
https://www.ebi.ac.uk/seqdb/confluence/pages/viewpage.action?spaceKey=ENSCORE&title=Core+release+coordination#Corereleasecoordination-Schemachanges

Better, thanks. The patch has to be added to the meta table in table.sql as well. How about patching the test databases?

Sorry I was committing the changes one by one. Now I'm stuck with the test databases patching. I'm not sure what I should patch nor how to do it. Should I submit another pull request to the ensembl-test repository to apply the patch there before this one can be accepted?

Patching the test DBs does not involve the ensembl-test repo, but it's using some of its scripts taking as argument the location of the test DBs in the ensembl core repo. This is described in the link I've given in my first comment with an example.
Nevermind if all this sounds not too clear, we'll close this and make the changes ourselves.

Coverage remained the same at 81.844% when pulling 1329508a18bc0b419a256cf64ee55584011481be on ens-carlos:master into 9af65650f4ccbf23f141a960659968cd237e55df on Ensembl:master.

I'd give it a try but I'm not sure which are the test databases as I found some hardcoded test databases in those instructions and I'm not sure if those are the ones I have to update.

They reside under <path_to_ensembl_repo>/modules/t, don't need to explicitly refer to them.
You'll be fine if you do like in the examples:
./cleanup_databases.pl --curr_dir <path_to_ensembl_repo>/modules/t
./patch_test_databases.pl --curr_dir <path_to_ensembl_repo>/modules/t

Thank you. I'll try.

It does not work. It requires "MultiTestDB.pm" files, which I do not have. I tried a copy of the MultiTestDB.pm.default file but it failed too:
Trying to load [circ] databases
Can't locate object method "_dbi_options" via package "Bio::EnsEMBL::Test::MultiTestDB"
Looks like it requires a few more configs. Btw, the checks seem to have been passed in the meantime? :)

I've added this update to Feature.pm that was pending in my Ensembl repo. I couldn't find an easy way to make a separate pull request for this.

Coverage decreased (-0.002%) to 81.842% when pulling b07da76a31e38202838b18bb28bec747c3785a93 on ens-carlos:master into 9af65650f4ccbf23f141a960659968cd237e55df on Ensembl:master.

Sorry we'd like to have atomic PRs referring to just one identifiable aspect. Can't you just not git add the changes to Feature ot git stash them?

As far as patching the test DBs is concerned:

include ensembl-test in your PERL5LIB to find the MultiTestDB module
inside <path_to_ensembl_core_repo>/modules/t, include a file MutliTestDB.conf like the following
{
'host' => 'localhost',
'port' => 3306,
'user' => 'somelocaluser',
'pass' => 'somelocaluserpass'
}

which enables the module to create test DBs on your localhost. Indeed, this requires you have a mysql server on your localhost and that the user/pass specified in the conf file can actually create DBs.
As I told you before, just tell me if that sounds to complicated. We're somewhat in haste and would like to start human xrefs asap.


bigquery: update example for new bigquery client surface

Change iterator to new methods.
Also, return nil instead of rows so far on error, to be idiomatic.

@broady @rakyll

@dpebot merge when green


Read from Compacted Topic

Currently you cannot consume a compacted topic.

Closed by https://github.com/apache/pulsar-client-node/pull/73


Fargate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

test


fix for go generate command

When wire command generate wire_gen.go file, go generate will not be work in module mode
$ go generate ./...
/Users/kb/.go/pkg/mod/github.com/google/wire@v0.5.0/cmd/wire/main.go:34:2: missing go.sum entry for module providing package github.com/google/subcommands (imported by github.com/google/wire/cmd/wire); to add:
        go get<EMAIL_ADDRESS>/Users/kb/.go/pkg/mod/github.com/google/wire@v0.5.0/internal/wire/copyast.go:21:2: missing go.sum entry for module providing package golang.org/x/tools/go/ast/astutil (imported by github.com/google/wire/internal/wire); to add:
        go get<EMAIL_ADDRESS>/Users/kb/.go/pkg/mod/github.com/google/wire@v0.5.0/internal/wire/parse.go:30:2: missing go.sum entry for module providing package golang.org/x/tools/go/packages (imported by github.com/google/wire/internal/wire); to add:
        go get<EMAIL_ADDRESS>/Users/kb/.go/pkg/mod/github.com/google/wire@v0.5.0/internal/wire/analyze.go:26:2: missing go.sum entry for module providing package golang.org/x/tools/go/types/typeutil (imported by github.com/google/wire/cmd/wire); to add:
        go get<EMAIL_ADDRESS>app/wire_gen.go:3: running "go": exit status 1

need

Resolved on #353


Any non-latin symbols make debugger swear

Operating system or device:
Windows 10
Issue description what happened, and what was expected):
I live in Russia, so I do have russian keyboard layout and if I write some russian letters or whatever it will not appear in the editor, and i won't be able to erase it or backspace. And I also won't be able to compile the code. The only way out is to undo the action by pressing Ctrl-Z.
Just letting you know :)

You can type and see by doing this.
http://docs.godotengine.org/en/latest/reference/changing_editor_fonts.html

Duplicate of #871 (the issue being that the non ascii characters are added to the script, but not shown).


Correctness: Require Coinbase + k>=parallel scan

It’s important that transactions are proven in the snark before we drop history in the transition frontier or else you have to trust nodes.
We need to either make sure this happens or show me a proof that this isn’t actually an issue.

If we want coinbase in every block then coinbase should be >= prover fee for one Transaction_snark_work

We definitely should not crash in this situation as this means another user could denial-of-service attack by just offering an expensive snark


DC1: Encrypt storage gateway EC2 AMI root(non-EBS) /dev/xvda volume to adhere AWS SEA deny rule on encryption: false

This is one of the encryption flags - the other root (non-EBS) volume is hidden because it comes with the unencrypted snapshot backing the AMI
see
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/AMIEncryption.html
https://github.com/aws-quickstart/quickstart-uipath-orchestrator/blob/main/templates/storage.template.yaml#L296
API: ec2:RunInstances You are not authorized to perform this operation.
"DecodedMessage": "{"allowed":false,"explicitDeny":true,"matchedStatements":
{"items":[{"statementId":
"PreventEc2MountUnencryptedVolume"
,"effect":"DENY","principals":
{"items":[{"value":"ARO....HWH"}]},"principalGroups":{"items":[]},"actions":
{"items":[{"value":"ec2:RunInstances"}]},"resources":{"items"
:[{"value":"arn:aws:ec2:::volume/*"}]},"conditions":{"items":
[{"key":"ec2:Encrypted","values":{"items":
[{"value":"false"
}]}}]}}]},
other fixes - ha template
add to ha template
HAMaster:
Type: 'AWS::EC2::Instance'
Properties:
  BlockDeviceMappings:
    - DeviceName: /dev/sda1
      Ebs:
        DeleteOnTermination: true
        Encrypted: true
        VolumeSize: 100
        VolumeType: gp2

the unencrypted snapshot backing the AMI see
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/AMIEncryption.html
ami-081419a3f54890191

Volume ID
Device name
Volume size (GiB)
Attachment status
Attachment time
Encrypted
KMS key ID
Delete on termination

vol-03a8688d236eed4fb
/dev/xvda
80
Attached
Tue Oct 26 2021 11:11:21 GMT-0400 (Eastern Daylight Time)
No
–
Yes

vol-05ac349c22fda6756
/dev/sdb
150
Attached
Tue Oct 26 2021 11:11:21 GMT-0400 (Eastern Daylight Time)
No
–

experiment: ami existing ec2 - turn on encryption by default - restore ami to new vm (although this should have worked during the cf deployment on the DENY account)
Noticed that the offending drive is greyed on encrypting via AMI creation

Weird, they are already encrypted - in the 60 day old version before the deny rule - looks like the global flag was flipped in the middle

testing by raising the original ami to check encryption status
worst case we save the existing encrypted ami for later use in the cf script

Anyway both drives are EBS and encrypted (as per the ami).
It looks like the account DENY rule only blocks cf ec2 create - but if we allowed it through - then the account level encryption=true override would encrypt all volumes anyway.
will reuse the previous activation key from 145

ActivationKey
J635P-LII2P-FHF20-32FBR-DCTUV
Custom::ActivationKey
CREATE_COMPLETE

Summary:
When the account is set for EC2 | Dashboard | Encryption | encryption = True (for new volumes during runinstance ops) - all EBS volumes are encrypted - even those that came in through any AMI that had un-encrypted volumes
The IAM DENY rule on EC2:createinstance where the encryption flag is set to false  - has no effect when the global encrypt flag is on - all volumes are encrypted anyway.
I see however there would be case where the regional encryption global flag is turned off and and EC2 was created (indirectly via ec2 api via CloudFormation) - that would now come in un-encrypted.
For the purposes of the dev account as long as the regional ec2 encryption flag is always false - we can relax the rule on the EC2 deny during development of the storage gateway AMI retrofit.
The remaining issue is that the root drive on the AMI used for the SG is unencrypted - however the latest run of 317 flipped the encryption to true as soon as the AMI was used via the EC2 global flag.  If you check all the volumes for the entire account you will see that except for 2 test instances from another user last quarter are encrypted - specifically the pre-prod 145 from 6 weeks ago actually already had encrypted volumes across all the EC2 VMs
reference

Hey, thank you very much for reporting this.
If I understand correctly you need a feature where the storage gateway will have encryption enabled for the root volume. Is this correct?


Create an Ubuntu image without unattended-upgrades

Definition of Done

packer template with unattende-upgrades

Depending on #ISSUE-76
Recreate PR after ISSUE-76 is done.

The PR-82 was merged.

The PR-82 was merged.


[HOLD for payment 2023-08-10] [$1000] Mweb - "Deleted message" chat appears in chat list for pinned deleted threads

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login to staging new dot
Go to any chat and long press on any message within the chat
Click on reply in thread and send a message in thread
Pin the thread using the pin icon at top right corner
Now delete the parent message in the thread
Go back to parent message and click on thread
Now delete the child message in the thread
Go back to chat and observe the thread has been removed
Go to chat list and observe that the deleted thread can be found pinned as "Deleted message" chat

Expected Result:
The deleted thread should also be removed
Actual Result:
The deleted thread remains in the chat list even after parent and child messages are both deleted
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.41-1
Reproducible in staging?: y
Reproducible in production?:  y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/c1785bd6-2c66-404f-a63c-08112ea47bb9
https://github.com/Expensify/App/assets/93399543/fe96eaa4-e0fd-4b15-889b-c2dd726af8c3
Expensify/Expensify Issue URL:
Issue reported by: @sofoniasN
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689361647727409
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01259a3effbfb36398
Upwork Job ID:<PHONE_NUMBER>803457536
        2023-07-21Automatic offers:

 |  | 0
hoangzinh | Contributor | 25765217
sofoniasN | Reporter | 25765220

I was assigned over the weekend-- I will review it soon.

@fedirjh and @MonilBhavsar - Could I get feedback here? I see that @hungvu193 worked on the fix for https://github.com/Expensify/App/issues/21103. That issue was focused on web. To confirm, that fix does not take into account Mweb say for Chrome on Android? I'm trying to confirm this one isn't a dupe before assigning the external label. Thanks!

@fedirjh - thank you for putting me in a better direction! I'll wait for @dangrous or @mananjadhav feedback before assigning the external label.

@alexpensify This issue doesn’t looks related to the PR @hungvu193 worked on. But I think this is a missed case from #21508 , cc @dangrous or @mananjadhav could you please add any feedbacks ?

If a deleted parent doesn't have a thread anymore, hide it #22690

Yep, I think this is a case we didn't think about when we changed the expected behavior in that issue. Not specifically a regression since I'm guessing this behavior would have happened before the change too. Should be a pretty easy fix though!

Thank you @dangrous for the review. I'm going to mark this one as external to kick off the party and get it moving.

@rushatgabhane - when you get a chance, please review the proposals. Thank you!

No update, waiting on the proposals to be reviewed here.

Umm, I'm thinking out loud about the expected behavior.
A report (pinned / unpinned) shouldn't be shown in LHN if it has no messages.

We can move the condition in those line

@hoangzinh sorry your proposal isn't clear to me. Instead of talking about what code to move where, could you please explain in simple words your proposed changes? Thanks

hide report thread in LHN if it doesn't have any comments regardless its pinned status

perfect, thanks!

C+ reviewed https://github.com/Expensify/App/issues/22950#issuecomment-1645793420
🎀 👀 🎀

Thanks @hoangzinh assigned

Thank you @hoangzinh for the update!

@rushatgabhane - the PR is ready for review. If you can complete it, please reply. If no reply, tomorrow, I will be asking in the C+ room for someone to step in and reassign. Thank you!

The PR was reviewed and approved! We are back on track. Thank you!

I've confirmed that the hires are in Upwork and will complete the payment summary next as we get closer to the payment date.
@rushatgabhane - when you get a chance, can you please complete the checklist before August 10? Thanks!

@rushatgabhane - bumping again, we are approaching the pay period. Please complete the checklist to avoid payment delays. Thanks!

WIP ⚠

The PR that introduced the bug has been identified. Link to the PR:

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Determine if we should create a regression test for this bug.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

Here is the payment summary:

External issue reporter - @SofoniasN $250
Contributor that fixed the issue @hoangzinh $1000
Contributor+ that helped on the issue and/or PR @rushatgabhane $1000

Upwork Job: https://www.upwork.com/jobs/~01259a3effbfb36398
*If applicable, the bonuses will be applied on the final payment
Extra Notes regarding payment: No urgency bonus here but I've completed the payments in Upwork for @SofoniasN and @hoangzinh

@rushatgabhane it looks like the checklist is still WIP but please request a payment via chat when it's complete. Thanks!

checklist done
manual request created - https://staging.new.expensify.com/r/750834249578109

Thank you for the update! We are all set and I'm going to close this GH.

Reviewed the details for @rushatgabhane. Approved for payment in NewDot based on BZ summary above.


Where to find the Market Data fields?

subscription_data = {
    'conid': gc_futures[0]['conid'],
    'fields': [
        FIELD_BID_PRICE,
        FIELD_ASK_PRICE,
        FIELD_BID_SIZE,
        FIELD_ASK_SIZE,
        FIELD_LAST_PRICE,
        FIELD_VOLUME,
    ]
}

Saw this example in one of the issues, I've been digging in docs and unable to understand how to bind correct market data fields for the subscription request
Where do I find these values for fields?

Hey @Tsopic thanks for describing your issue 👍
You can find these here:
https://www.interactivebrokers.com/campus/ibkr-api-page/cpapi-v1/#market-data-fields
Or indirectly in IBind, in ibkr_definitions.py (though note that these are manually typed in and may become out of date at some point):
https://github.com/Voyz/ibind/blob/master/ibind/client/ibkr_definitions.py
Let me know if that helps 👍


Specify working directory in client and server

It might be useful to tell users at the beginning of the README for the client/server to navigate to src/client or src/server.

Do you mean before the pip install step?

Yes. They should already be there but just to make sure


Plyr video Safari support

add class to video tag for mobile safari

@nathakits please see my comments in the review and commit and I can merge.


Notification Message Updates

Updated NotificationMessage to new designs. Added new type 'info' for an informative message. Added description property that will add a description under the message that is optional when creating notification or calling this.notify(message, type, description);
Ticket: https://nanopay.atlassian.net/browse/NP-1010
nanopay pr: https://github.com/nanoPayinc/NANOPAY/pull/10044

LGTM

@blakegreen32 if you could update LogLevel:

convert it's custom colour config to the new colour support Kevin added to Enums
change the colours themselves to those we've selected for toast notifications.  Use the blue for debug.


Document using Draft with Docker for Mac/Windows and Kubernetes

Should have checked issue queue first.. 😄
Duplicate of #762

Some news about that? I can't run eval $(minikube docker-env) on the Docker for Windows With Kubernetes.


Make pnpm a prerequisite for development, update debugger config for vitest enabled packages

Developers using npm might not exit vitest coverage runs before the timeout for the underlying close() kicks in, and the solution would be to use pnpm instead, which is more performant. pnpm isn't an explicit requirement, but in light of this, it should be the recommended package manager devs use when contributing. Updated our root README to reflect that.
Also, updated our launch.json to support debugging vitest. Just enabling it per package that already moved to vitest. Dropped outFiles, we don't need to explicitly specify this to enable source maps when debugging. Most important part of the configuration is to pass in autoAttachChildProcesses, because vitest uses child processes to run tests in multiple threads.
Also, documenting here that the vitest maintainer says you can't filter a test like how we did it with chai: https://github.com/vitest-dev/vitest/issues/1497
It seems that .only does not filter the test files, it filters out the tests cases inside of a found test file.
To quickly run a single test file you can go to vitest.config.mts and add include: "", right below setupFiles - that will tell vitest to run test files that match that pattern. Then if there is a .only inside the test file, vitest will run only the describe.only or it.only found within.

@saeeedtorabi @dassaf4 try setting a breakpoint in one of the geometry test files, and launch the debugger profile for Geometry Tests. You can also filter out the one test file you are setting a breakpoint in via vitest.config.mts include if you don't want to run all the other tests...

can you update the readme to reference using pnpm instead of npm too?
i see at the bottom for example that says run npm run docs

Is it weird to say pnpm when this is a rush repo? Rush does use pnpm under the hood im pretty sure, but not sure if that would be confusing at all? I could just as easily run rushx docs in core/backend, which I think is essentially the same thing.
It also does seem the majority of the messaging in that readme is rush based

Is it weird to say pnpm when this is a rush repo? Rush does use pnpm under the hood im pretty sure, but not sure if that would be confusing at all? I could just as easily run rushx docs in core/backend, which I think is essentially the same thing.
It also does seem the majority of the messaging in that readme is rush based

Yes, it may be weird, but it's not easy for developers to tell that there's a difference. You can easily run npm docs or npm test in the individual folders as well.
Maybe we can encourage developers to use pnpm, or rushx in individual folders, by explicitly stating that in the root README of our repo

I could just as easily run rushx docs in core/backend, which I think is essentially the same thing.

I'll add here that on my laptop, pnpm is faster than rushx. Just today we were testing vitest, and found that only pnpm cover successfully completes in core-geometry, while rushx cover times out just like npm run cover.

I tested debugging in VSCode using this PR. This PR fixed the debugging issue.
However, the old method of debugging was nuch faster (specially when you test a single unit test using .only). It used to take a couple seconds to get to the first breakpoint. The new method is slow to get to the first breakpoint no matter you test a single unit test or all unit tests. It took me around 15 sec to get to the first breakpoint in VSCode debugger (first time took 60 sec but I repeated and it settled at 15 sec and did not reduce no matter how many times I ran the tests).
I see this message in VSCode and wondering if that can improve the speed:

I tested debugging in VSCode using this PR. This PR fixed the debugging issue.
However, the old method of debugging was nuch faster (specially when you test a single unit test using .only). It used to take a couple seconds to get to the first breakpoint. The new method is slow to get to the first breakpoint no matter you test a single unit test or all unit tests. It took me around 15 sec to get to the first breakpoint in VSCode debugger (first time took 60 sec but I repeated and it settled at 15 sec and did not reduce no matter how many times I ran the tests).

I can look to add another command in launch.json that can debug the current file that is open, I just need to state that command is for vitest converted test files only, since we still are using mocha+chai in other places

Added another launch configuration: 'Debug Current Vitest File`, and it will debug just the active tab you have opened in vs code

I can look to add another command in launch.json that can debug the current file that is open in your vs code editor, I just need to state that command is for vitest converted test files only, since we still are using mocha+chai in other places

Since all core-geometry tests are converted to vitest, can this be made the default for the Geometry Tests section?

I can look to add another command in launch.json that can debug the current file that is open in your vs code editor, I just need to state that command is for vitest converted test files only, since we still are using mocha+chai in other places

Since all core-geometry tests are converted to vitest, can this be made the default for the Geometry Tests section?

I've already updated the Geometry Tests section to have the debugger work, it just runs against all of geometry's vitest files by default. You can use this other launch config to debug just the one test file you might have opened. Both launch configs will catch your breakpoints, but the latter will make it quicker to get to that breakpoint since it only runs one test file

Added another launch configuration: 'Debug Current Vitest File`, and it will debug just the active tab you have opened in vs code

I tested your last commit. Now it takes 50 sec to get to the first breakpoint! I ran it multiple times but it made it worse.

I tested your last commit. Now it takes 50 sec to get to the first breakpoint! I ran it multiple times but it made it worse.

@saeeedtorabi try the 'debug current file in vitest' again - I updated that config to not spawn multiple child threads when debugging just a single file, since attaching the debugger to each thread would be a reason the startup time took so long. Me and a colleague noticed it was faster now

"To quickly run a single test file you can go to vitest.config.mts and add include: "", right below setupFiles - that will tell vitest to run test files that match that pattern. "
is this information captured anywhere besides the description of the PR?

Do we know that this screenshot from Saeed's posts isn't important? I see you mentoined that we don't need to explicitly set this in the description, but the ss is a bit concerning for performance reasons isn't it?

"To quickly run a single test file you can go to vitest.config.mts and add include: "", right below setupFiles - that will tell vitest to run test files that match that pattern. "
is this information captured anywhere besides the description of the PR?

David provided an example within core geometry's vitest.config.mts in a recent commit to master

@hl662 I have issues with debugging in VS Code using this change. Step Into does not work properly.

@hl662 I have issues with debugging in VS Code using this change. Step Into does not work properly.

I hopped on a call with Saeed to look at the issue - the debugger is working as expected - when setting a breakpoint on a line that calls a static method, like Line.doThis, he expected 'step into' to go into the doThis method, but instead it actually goes into 'Line', pointing to the closing brace of the class. That's expected - step into should retrieve the class object containing the static method first, before diving into the static method itself.

I see you mentoined that we don't need to explicitly set this in the description, but the ss is a bit concerning for performance reasons isn't it?
It's hard to justify including the outFiles - vitest uses vite to build and compile, and by default, the outDir of that is dist, not lib/ like how we specify. By default, vitest includes everything in the workspaceFolder, it doesn't change any of the options specified here, but even so, maybe I should keep outFiles in, maybe in case of stepping into adjacent subdirectories and their methods...

@hl662 I have issues with debugging in VS Code using this change. Step Into does not work properly.

I hopped on a call with Saeed to look at the issue - the debugger is working as expected - when setting a breakpoint on a line that calls a static method, like Line.doThis, he expected 'step into' to go into the doThis method, but instead it actually goes into 'Line', pointing to the closing brace of the class. That's expected - step into should retrieve the class object containing the static method first, before diving into the static method itself.

This might be the expected new behaviour but I'm pretty sure it was not the old behaviour. I think running the tests is made faster by new changes but debugging is harder and slower now. I hope it can be improved because in the long run people spend more time on debugging than just running the tests.

It's hard to justify including the outFiles - vitest uses vite to build and compile, and by default, the outDir of that is dist, not lib/ like how we specify. By default, vitest includes everything in the workspaceFolder, it doesn't change any of the options specified here, but even so, maybe I should keep outFiles in, maybe in case of stepping into adjacent subdirectories and their methods...

Your link takes me here:

Is that what you intended?
vitest includes everything in the workspaceFolder by default when searching for outFiles? Right now the launch.json is more specific than workspaceFolder for outFiles, i.e. "${workspaceFolder}/extensions/frontend-tiles/lib/**/*.js".
if vite uses an outDir of dist by default, why shouldn't we change our outFiles to have dist instead of lib as opposed to removing them completely?

Is that what you intended?
vitest includes everything in the workspaceFolder by default when searching for outFiles? Right now the launch.json is more specific than workspaceFolder for outFiles, i.e. "${workspaceFolder}/extensions/frontend-tiles/lib/**/*.js".
if vite uses an outDir of dist by default, why shouldn't we change our outFiles to have dist instead of lib as opposed to removing them completely?

Oof yeah, I should have pointed out the outFiles param is node:launch dropdown in that link.
So I just tried out outFiles to match any .js files in either dist or lib and it made no difference to the performance. It also caused bad behavior in the debugger - it wasn't tracing the lines properly, and the block scoped variables in the debugging panel didn't match where I was stepping through. I had to remove outFiles to get the debugger to work properly.

@dassaf4 @saeeedtorabi
I just pushed a commit that adds support for a test explorer for vitest. It adds a suggestion to install an extension called 'vitest.explorer'. Can you install it andd see if in the Testing tab of VSCode, you can see something like this:

The UI should be pretty straight forward to interpret how to debug a single test case, i tried setting a breakpoint and it correctly steps over as well

@dassaf4 @saeeedtorabi I just pushed a commit that adds support for a test explorer for vitest. It adds a suggestion to install an extension called 'vitest.explorer'.

Brilliant! This adds a "Testing" icon that you can use instead of "Run and Debug". No more "it.only". No more editing vitest.config.mts to test a single file. Run a single test, or all the tests at the describe/file/repo level directly within Code. And it journals the results in a new "Test Results" tab.

Brilliant! This extension adds a "Testing" icon that you can use instead of "Run and Debug".
Great, I'm going to remove the 'debug current vitest file' from launch.json, it has a lot of problems with it and executing that in a monorepo, I'll recommend using the vitest extension instead

This might be the expected new behaviour but I'm pretty sure it was not the old behaviour.

I agree with what Saeed said here. I don't remember a scenario where while stepping into a call the debugger stepped into the closing brace of the class


supply lacks support for updating Android expansion file information

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
Currently supply provides the ability to upload Android obb expansion files, but does not allow subsequent builds to simply reference the existing expansion file.   Uploading a new expansion file means that an existing user would need to redownload the expansion file on each update, whether or not the expansion data had changed.
The Google API that supply uses provides an update_expansion_file method that would allow supply to  address this issue.

@skicson That's for the report. 👍 We'd be happy to review a PR that handles this use case!


Support allow_duplicate_keys for json processor

Description
This is to support creating an ingest pipeline for ECS JSON logs.
Due to how some logging frameworks work, ECS JSON logs may contain duplicate keys. Instead of failing, the JSON parser should be more lenient and prefer the last value.
Ported from https://github.com/elastic/elasticsearch/pull/74956
Related Issues
Resolves #[Issue number to be closed when this PR is merged]

Check List

[x] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[x] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This is still relevant! @opensearch-ci-bot

I don't know much about the xcontent business, maybe @reta can review this? Who else?

Thanks for the pull request @MunifTanjim but we cannot port features from elasticsearch "as-is" without violating license

Oh I didn't notice the port from Elastic. That PR is from Jul 6, 2021 which is after 7.10.2 I believe, closing this PR.
Anyone wanting this feature in OpenSearch: please ensure that you're not copying any non-APLv2 code.


Create example PR for review

This is a:

[ ] ✨ New feature - new behaviour has been implemented
[ ] 🐛 Bug fix - existing behaviour has been made to behave
[ ] ♻ Refactor - the behaviour has not changed, just the implementation
[ ] ✅ Test backfill - tests for existing behaviour were added but the behaviour itself hasn't changed
[ ] ⚙ Chore - maintenance task, behaviour and implementation haven't changed

Description

Purpose -

How to check -

Links

Author checklist

[ ] I have written a title that reflects the relevant ticket
[ ] I have written a description that says what the PR does and how to validate it
[ ] I have linked to the project board ticket (and any related PRs/issues) in the Links section
[ ] I have added a link to this PR to the ticket
[ ] I have made the PR to main from a branch named <category>/<name>, e.g. feature/edit-spaceships or bugfix/restore-oxygen
[ ] I have manually tested that the app still works correctly
[ ] I have requested reviewers here and in my team chat channel

[ ] I have spoken with my PM or TL about any parts of this task that may have become out-of-scope, or any additional improvements that I now realise may benefit my project
[ ] I have added tests, or new tests were not required
[ ] I have updated any documentation (e.g. diagrams, schemas), or documentation updates were not required

Hi @textbook, Thank you for the pull request.
Request changes

❌ When reviewing, I noticed that there are conflicts in server/resources/resourcesController.js that need to be resolved before merging, so I request that you rebase to the main branch.
❌ Additionally, the application is crashing when ran.
💡 Could we prioritize resolving these issues?

Ignore any conflicts, the point is to review the proposed changes
The module is missing because you don't have the relevant dependencies installed. Also please present text as text so it's accessible, indexable, searchable, ...

I've updated the branch upstream because it was still requiring older versions of Node.js/npm, and juggling these adds unnecessary effort. You can ignore any remaining conflicts, though.


proxy: Add tls_config_last_reload_seconds metric

Depends on #1141.
This PR adds a tls_config_last_reload_seconds Prometheus metric
that reports the last time the TLS configuration files were reloaded.
Proof that it works:
Started the proxy with no certs, then generated them:
➜ http GET localhost:4191/metrics
HTTP/1.1 200 OK
content-encoding: gzip
content-length: 323
content-type: text/plain
date: Mon, 25 Jun 2018 23:02:52 GMT

# HELP tls_config_reload_total Total number of times the proxy's TLS config files were reloaded.
# TYPE tls_config_reload_total counter
tls_config_reload_total{status="io_error",path="example-example.crt",error_code="2"} 9
tls_config_reload_total{status="reloaded"} 3
# HELP tls_config_last_reload_seconds Timestamp of when the TLS configuration files were last reloaded successfully (in seconds since the UNIX epoch)
# TYPE tls_config_last_reload_seconds gauge
tls_config_last_reload_seconds<PHONE_NUMBER>
# HELP process_start_time_seconds Time that the process started (in seconds since the UNIX epoch)
# TYPE process_start_time_seconds gauge
process_start_time_seconds<PHONE_NUMBER>

Started the proxy with certs already present:
➜ http GET localhost:4191/metrics
HTTP/1.1 200 OK
content-encoding: gzip
content-length: 285
content-type: text/plain
date: Mon, 25 Jun 2018 23:04:39 GMT

# HELP tls_config_reload_total Total number of times the proxy's TLS config files were reloaded.
# TYPE tls_config_reload_total counter
tls_config_reload_total{status="reloaded"} 4
# HELP tls_config_last_reload_seconds Timestamp of when the TLS configuration files were last reloaded successfully (in seconds since the UNIX epoch)
# TYPE tls_config_last_reload_seconds gauge
tls_config_last_reload_seconds<PHONE_NUMBER>
# HELP process_start_time_seconds Time that the process started (in seconds since the UNIX epoch)
# TYPE process_start_time_seconds gauge
process_start_time_seconds<PHONE_NUMBER>

@hawkw Can you resolve the conflicts with master when you get a chance?

Rebased, sorry about that.


service power Steering on a 2021 Ram 1500 DT Laramie ecodiesel

Describe the bug
anyone want to take a crack at my dilemma using comma three and a 2021 Ram 1500 DT Laramie Eco diesel? I would appreciate it
No matter what generation 2 cable I use because I’ve tried various ones including the stock one that comes from comma three I keep getting a service power Steering error message on my dashboard. Trying to set this up in my 2021 Ram 1500 DT Laramie eco diesel. I have also attempted uninstalling and reinstalling an open pilot.
Some one also asked me these questions
When do you get the error?
I get the error message as soon as my truck hits 30 mph which I noticed 30 mph is the speed necessary to achieve before comma 3 using open pilot to engage
What device are you using: C2, C3, custom hardware?
I'm using a comma 3 six parts came with this kit, 3, the harness for my ram pickup truck, the USB C to Ethernet cable, the generation two USB C to USB C cable, the mounts, and the OBD2 connector
Do you see the front camera video?
Yes I do see my front camera and there are videos when I've created a coma account and I see my videos uploaded
Any other messages?
Negative there are no other messages other than service cruise control on my dashboard of my 2021 Ram 1500 DT Laramie EcoDiesel and I'm assuming because this message comes on is why it's not engaging because everything seems to be working with the comma three I mean it's watching the road it's taking videos it's setting destinations if I put an address in the app it'll transmit to the device!
Provide a route where the issue occurs
https://connect.comma.ai/06794b0d8a5d85ed/1686334412971/1686337332448
openpilot version
0.9.2
Additional info
I have provided a link for a route above however this occurs on a ll trips

Hi, can you get another route with the example and upload rlogs?

We already figured out the problem. Iam in the process of installing ACC in my vehicle. I thought I had it already.Thanks Joe Catran<PHONE_NUMBER> Apply for Life Insurance all on your own. Scan the QR code below to apply with Ethos or CLICK HERE
-------- Original message --------From: Shane Smiskol @.> Date: 6/25/23  23:50  (GMT-05:00) To: commaai/openpilot @.> Cc: joecatran @.>, Author @.> Subject: Re: [commaai/openpilot] service power Steering on a 2021 Ram 1500 DT Laramie ecodiesel (Issue #28486)
Hi, can you get another route with the example and upload rlogs?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


"Related topics" links are displayed vertically in PDF versions

Describe the bug
In the PDF versions of pages that have "Related topics," the links to the related topics are displayed vertically.
To Reproduce

Go to a page that has related topics (e.g., Dynamic Link Libraries).
Download PDF (e.g., for the Dynamic Link Libraries page).
Observe that the link to the related topic "DLLs (Visual C++)" is displayed vertically (at the bottom of page 3 in the example).

Expected behavior
The related topics should be displayed horizontally like normal text.
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser: Chrome
Version: 81.0.4044.129

@drewbatgit FYI Win 32 docs have extra tags in the Next steps causing problems in PDF rendering.

The <dl> and <dt> tags are the likely culprit. Can those be removed throughout?
## Related topics

<dl> <dt>

[DLLs (Visual C++)](https://msdn.microsoft.com/library/1ez7dh12.aspx)
</dt> </dl>

 ```

Thanks for reporting this issue. We will investigate and get this fixed.