Fails to delete temporary files related to analyzers

Describe the bug
Temporary files and directories created by the analyzers cannot be deleted after analysis.
Version of dependency-check used
dependency-check-maven version 9.0.8
Log file
Warnings seen in the end failing to delete.
[INFO] --- dependency-check-maven:9.0.8:aggregate (dependency-cve-check) @ myproject ---
[INFO] Checking for updates
[INFO] Download Started for NVD Cache - https://myhost/owasp/nvdcve-modified.json.gz
[INFO] Begin database maintenance
[INFO] Updated the CPE ecosystem on 132272 NVD records
[INFO] Cleaned up 20 orphaned NVD records
[INFO] End database maintenance (9261 ms)
[INFO] Updating CISA Known Exploited Vulnerability list: https://myhost/owasp/known_exploited_vulnerabilities.json
[INFO] Begin database defrag
[INFO] End database defrag (4255 ms)
[INFO] Check for updates complete (17191 ms)
[INFO]

Dependency-Check is an open source tool performing a best effort analysis of 3rd party dependencies; false positives and false negatives may exist in the analysis performed by the tool. Use of the tool and the reporting provided constitutes acceptance for use in an AS IS condition, and there are NO warranties, implied or otherwise, with regard to the analysis or its use. Any
use of the tool and the reporting provided is at the user's risk. In no event shall the copyright holder or OWASP be held liable for any damages whatsoever arising out of or in connection with the use of this tool, the analysis performed, or the resulting report.

   About ODC: https://jeremylong.github.io/DependencyCheck/general/internals.html
   False Positives: https://jeremylong.github.io/DependencyCheck/general/suppression.html

? Sponsor: https://github.com/sponsors/jeremylong

[INFO] Analysis Started
[INFO] Finished Archive Analyzer (0 seconds)
[INFO] Finished File Name Analyzer (0 seconds)
[INFO] Finished Jar Analyzer (0 seconds)
[INFO] Finished Dependency Merging Analyzer (0 seconds)
[INFO] Finished Hint Analyzer (0 seconds)
[INFO] Finished Version Filter Analyzer (0 seconds)
[INFO] Created CPE Index (1 seconds)
[INFO] Finished CPE Analyzer (2 seconds)
[INFO] Finished False Positive Analyzer (0 seconds)
[INFO] Finished NVD CVE Analyzer (0 seconds)
[INFO] Finished Vulnerability Suppression Analyzer (0 seconds)
[INFO] Finished Known Exploited Vulnerability Analyzer (0 seconds)
[INFO] Finished Dependency Bundling Analyzer (0 seconds)
[INFO] Suppression Rule had zero matches<EMAIL_ADDRESS>regex=true, caseSensitive=false},cve={CVE-2022-42003,}}
[INFO] Suppression Rule had zero matches<EMAIL_ADDRESS>regex=true, caseSensitive=false},cve={CVE-2016-1000027,}}
[INFO] Suppression Rule had zero matches<EMAIL_ADDRESS>regex=true, caseSensitive=false},cpe={PropertyType{value=cpe:/a:yaml_project:yaml, regex=false, caseSensitive=false},}}
[INFO] Finished Unused Suppression Rule Analyzer (0 seconds)
[WARNING] Failed to delete the Archive Analyzer's temporary files from `C:\Users\myuser\AppData\Local\Temp\dctemp552d032d-66fb-4e7c-a664-54856a3da541\check2213629750402486390tmp`, see the log for more details
[WARNING] Failed to delete the JAR Analyzder's temporary files from `C:\Users\myuser\AppData\Local\Temp\dctemp552d032d-66fb-4e7c-a664-54856a3da541\check2272745657097529580tmp`, see the log for more details
[INFO] Analysis Complete (3 seconds)

To Reproduce
Do not have a minimal example to publish here but configuration done is to point to internal URLs and disabled several analyzers but not the ones seen warnings on:

format = ALL
nvdDatafeedUrl = to internal URL
knownExploitedUrl = to internal URL
hostedSuppressionsUrl = to internal URL
Following analyzers are disabled:

nexus
assembly
nuspec
ossindex
node
nodeAudit

So far only tested this on a Windows machine running it via PowerShell with Maven 3.8.5
Expected behavior
Temporary files deleted and now warnings seen.

@jeremylong I recall seeing a fix related to this problem in version 6.0.9-SNAPSHOT, but I cannot find it at the moment. The issue is causing us trouble as well, and we have added a pre-build step to our Jenkins builds to remove /tmp/dctemp* as a temporary solution. However, sometimes the number of files is too large, and the build times out, making it unreliable. I am considering moving back to version 6.0.7 for now, but I noticed that version 6.0.8 has a change to fix issues with NIST rate-limiting. Have you found 6.0.7 to be stable enough that moving back might be a better option until 6.0.9 is released? Do you have an idea when 6.0.9 will be released?

Same here
[INFO] Finished Unused Suppression Rule Analyzer (0 seconds)
[WARNING] Failed to delete the Archive Analyzer's temporary files from `/tmp/dctempbd0f19eb-8cf1-4867-b209-fa0ce30f1545/check5936538525634683319tmp`, see the log for more details
[WARNING] Failed to delete the JAR Analyzder's temporary files from `/tmp/dctempbd0f19eb-8cf1-4867-b209-fa0ce30f1545/check9451207815810687080tmp`, see the log for more details
[INFO] Analysis Complete (6 seconds)

with dependency-check-maven version 9.0.8

fixed with https://github.com/jeremylong/DependencyCheck/pull/6375. new version should be released soon.


[HOLD for payment 2023-10-02] Memoize expensive calls in ReportActionsList renderItem

Problem
Some of the operations we do in ReportActionsList renderItem are pretty expensive since this function is executed for every items in the render window every time the render window changes. To improve performance of FlatList scrolling we need to move any expensive computation inside a memoized component. This way when FlatList re-renders to display new items but the data did not change only the new rendered items will need to render.
We were already memoizing ReportActionItem, but renderItem still contains some expensive calls, specifically isConsecutiveActionMadeByPreviousActor which has to do some date comparisons. I moved those to a new component ReportActionsListItemRenderer which will prevent any re-renders coming from from FlatList for items that were already rendered. This reduces the number of calls to isConsecutiveActionMadeByPreviousActor from the number of currently rendered item (~100 depending on the FlatList window size) to just the new items being added (usually 10 since this is the batch size).

merged

@mountiny @sonialiap I think there's nothing we can add to the BZ checklist.

I agree, no need here for the checklist

@sonialiap I think I can request payment in NewDot for this issue.

@sonialiap Can you please add a payment summary to this issue so I can pay?

Sorry for the delay, working 50% while trying to juggle the normal work load.
Payment:

@mollfpr review + time bonus = $750

$750 payment approved for @mollfpr based on BZ summary.

@sonialiap @JmillsExpensify Sorry to open this up. I just noticed that the request on the ND I did was requested and approved for $500, so there's there is a shortage in payment here. Could you help confirm it? Thank you!

Friendly bump @JmillsExpensify


[4.0 xpt] API Integration for the Reservations page

Replace the static data on the reservation page with API's data(dynamic data from the end-point).


Fix https://github.com/rg3/youtube-dl/issues/11890

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

https://github.com/rg3/youtube-dl/issues/11890

Please approve this commit!!!! Thank you @Khang-NT!!!

I just integrated youtube-dl into my system , I love the program, hoping this error is resolved soon, please keep me in the loop<EMAIL_ADDRESS>is my email

To get @Khang-NT's fix while you're waiting for the pull request to be approved, you can install it with pip. pip install git+https://github.com/Khang-NT/youtube-dl.git

when i try to install with pip i get this error:
Error [WinError 2] The system cannot find the file specified while executing command git clone -q git://github.com/Khang-NT/youtube-dl C:\Users\100623~1\AppData\Local\Temp\pip-build-f3f27dna\youtube-dl
Cannot find command 'git'

@AsunaXXII Install Git.

Fix worked for me.
This pull now closes 7 issues:
#11902, #11900, #11897, #11895, #11894, #11891, #11890.

ETA on release?

Can someone build this into exe form otherwise I will have to wait for release and that could be several hours :/

I have published an UNOFFICIAL Windows build that includes this fix here: https://github.com/user890104/youtube-dl/releases/tag/2017.01.31-user890104

This is just a temporary solution. It just works for the videos that do not require a signature. This does not work for all videos.

@yasinalm Please provide a YouTube URL, which is not working.

@user890104
https://www.youtube.com/watch?v=BLIjRIpLJVE

@doublex: I can download your provided video without any problems (after applying the commit from the pull request).
I also tried some other without (I think some with signature) and all worked well.
What error do you get?
[youtube] BLIjRIpLJVE: Downloading webpage [youtube] BLIjRIpLJVE: Downloading video info webpage [youtube] BLIjRIpLJVE: Extracting video information WARNING: Requested formats are incompatible for merge and will be merged into mkv. [download] Destination: Κωνσταντίνος Αργυρός - Όσα Νιώθω - Official Video Clip-BLIjRIpLJVE.f137.mp4 [download] 100% of 65.37MiB in 00:01 [download] Destination: Κωνσταντίνος Αργυρός - Όσα Νιώθω - Official Video Clip-BLIjRIpLJVE.f251.webm [download] 100% of 4.30MiB in 00:00 [ffmpeg] Merging formats into "Κωνσταντίνος Αργυρός - Όσα Νιώθω - Official Video Clip-BLIjRIpLJVE.mkv" Deleting original file Κωνσταντίνος Αργυρός - Όσα Νιώθω - Official Video Clip-BLIjRIpLJVE.f137.mp4 (pass -k to keep) Deleting original file Κωνσταντίνος Αργυρός - Όσα Νιώθω - Official Video Clip-BLIjRIpLJVE.f251.webm (pass -k to keep)

So, is this still a temporary solution or is it fixed completely now?

Works fine for me and the pull request has been officially commited!

I am still unable to get this fixed on my local system? Do I need to do a reboot or something? I pulled the request mentioned above and it downloaded but says it's the 2016.08.31 version?

@ztackett11 You're still using Youtube-DL '2016.08.31'. So your update didn't work at all. How do you update? Changes are that your Repository is not up to date (if using Linux).

@ThomasChr I figured out the problem late last night. I had two installations of youtube-dl, one inside my directory from which the program I use youtube-dl, and another in my main User directory.
Going into my Python site-packages directory and deleting the youtube-dl folder and files, then reinstalling youtube-dl is what fixed it for me.
Everything is working great for me now.


Viewing Response Body Icon

Hi all.
Much appreciated on adding the copy button and the drop down icon for viewing the Response Body of a FHIR Request.
I have a little feedback that you can take as is or apply however you see fit.

While having the copy button and drop down icon is great, on 1st experience, I thought maybe something was wrong or broken
There's not a clear enough indication that the JSON is collapsed by default and that you need to click the drop down icon to expand
Maybe adding some background color in a circle or adding some animation for the drop down icon to go up and down may help

Other than that, little usability fixes like you all have been adding are great for those who use this wonderful tool day in and day out.
Thanks - Mat

Thank you very much for your feedback and kind words about Inferno.  We'll see if we can make that a little more obvious in future versions.

No problem at all Rob. Thank y'all as always!

Hi Mat, thanks for the feedback! We've made some updates to the way the Response Body looks to help alleviate these issues. The icons should now be larger and more visible, and we've added color and interactions to the body header to make the body easier to access. We've also added a line count to the header title to suggest that the body is collapsed.
I'm going to go ahead and close this issue for now, but definitely reach out if you feel it should be reopened or there are other issues to report. Thanks again!


WinUI 3 Desktop: Drag and drop file from Explorer to app window does not work

Describe the bug
I have the following simple WinUI 3 Desktop app running on Window 11. Dragging a file from the Explorer into the window does not work. Grid_DragOver() is not being called. You just get the red cursor symbol as if drop is not allowed.
Strangely it works if I drag a file from the Recent items in the Start section of the Explorer. But all other places like the Desktop don't work.
Steps to reproduce the bug
MainWindow.xaml:
<Grid AllowDrop="True" Drop="Grid_Drop" DragOver="Grid_DragOver" Background="LightGray">
     <TextBlock
         x:Name="FileNameTextBlock"
         Text="Drag a file here"
         HorizontalAlignment="Center"
         VerticalAlignment="Center"
         FontSize="20"
         FontWeight="Bold" />
 </Grid>
</Window>

MainWindow.xaml.cs:
 using Microsoft.UI.Xaml;
 using Microsoft.UI.Xaml.Controls;
 using Microsoft.UI.Xaml.Input;
 using System;
 using System.IO;
 using Windows.ApplicationModel.DataTransfer;
 using Windows.Storage;

namespace FileDragDropApp
{
    public sealed partial class MainWindow : Window
    {
        public MainWindow()
        {
            this.InitializeComponent();
        }

        private async void Grid_Drop(object sender, DragEventArgs e)
        {
            // Check if the dropped data contains files
            if (e.DataView.Contains(StandardDataFormats.StorageItems))
            {
                // Get the file(s) from the DataPackage
                var items = await e.DataView.GetStorageItemsAsync();
                if (items.Count > 0)
                {
                    // Display the first file's name
                    var storageFile = items[0] as StorageFile;
                    if (storageFile != null)
                    {
                        FileNameTextBlock.Text = $"File: {storageFile.Name}";
                    }
                }
            }
        }

        private void Grid_DragOver(object sender, DragEventArgs e)
        {
            // This is not being called
            e.AcceptedOperation = DataPackageOperation.Copy;
        }
    }
}

Expected behavior
Dragging files from the explorer onto a AllowDrop="True" enabled view should work.
Screenshots
This one works:

This does not:

NuGet package version
WinUI 3 - Windows App SDK 1.6.1: 1.6.240923002
Windows version
Windows Insider Build (xxxxx), Windows 11 (22H2): Build 22621
Additional context
Edition	Windows 11 Pro
Version	24H2
OS build	26100.2161
Experience	Windows Feature Experience Pack 1000.26100.32.0

I tried to reproduce it, but it works on Windows 10 22H2, Windows App SDK 1.6.240829007 :

That's so strange. I've others test it as well. For some it works, for others it does not. Is there some kind of Windows settings that could block this?

GetStorageItemsAsync is broken and the documentation has not been updated. Solution and additional details:
https://github.com/microsoft/microsoft-ui-xaml/issues/9296#issuecomment-1916853813

GetStorageItemsAsync is broken and the documentation has not been updated. Solution and additional details:
#9296 (comment)

Thanks for pointing this out. Still neither Grid_Drop nor Grid_DragOver is being called, so I don't even come to the point where it could crash.

@Iomegan The problem is that all of the pointer events get broken and stop functioning correctly as you are experiencing once GetStorageItemsAsync malfunctions. I would recommend you give the workaround a try real quick just to see if it helps.

@kmgallahan I did.
<StackPanel AllowDrop="True"  DragEnter="Grid_DragEnter" Background="LightGray">
    <TextBlock
     x:Name="FileNameTextBlock"
     Text="Drag a file here"
     HorizontalAlignment="Center"
     VerticalAlignment="Center"
     FontSize="20"/>
</StackPanel>

private void Grid_DragEnter(object sender, DragEventArgs e)
{
    Debug.WriteLine("Grid_DragEnter");
}

Grid_DragEnter is not being called and I don't call GetStorageItemsAsync at all. Clean restart. Nothing.

Screen recording: https://github.com/user-attachments/assets/8e91ee15-02c2-4c1f-8069-c99e9edc5c7b


test: delete test.filter.js if test is pass in tests/webpack-test

Summary

With Rspack develop, there are more and more webpack-tests can be pass.
So we should delete those test test.filter.js
Checklist

[ ] Tests updated (or not required).
[ ] Documentation updated (or not required).

The CI failed, can you take a look?

Done~


Add support for Instant values

In addition to Date, LocalDate, LocalTime, and LocalDateTime, HTTP-RPC should support the Instant type.
Support for Instant should be added to BeanAdapter as well as JSONEncoder and CSVEncoder. Instants should be seamlessly translated to and from their string representations, similar to how other temporal types are handled.
TemplateEncoder may already support Instant but additional tests should be added to verify.

This is done.

This is done.


Makefile and pep8 fixes

Coverage decreased (-0.08%) to 43.75% when pulling 2536eec893a3d90ee7036bfca55481f59d2a3470 on F483:master into b639d4ed8e8ad25102c9cf0d08784200824fa5ed on Storj:master.

I think the drop of code coverage can be neglected.
I've made my comments but I don't see any problem merging this.
@super3 and @Miskerest feel free to merge if you're comfortable with the changes.


The position to add attention modules

Dear kobiso:
Thanks for your re-implementations of cbam-tensorflow-slim and SENet-tensorflow-slim.
However, I find that the position you add cbam block is different from the paper "CBAM: Convolutional Block Attention Module" for the inception-resnet-v2. The same situation also happens for the  inception-resnet-v2 in SENet-tensorflow-slim.
From my point of view, in both papers, i.e., "CBAM: Convolutional Block Attention Module" and "Squeeze-and-Excitation Networks", the attention modules should be placed between the original blocks of the inception-resnet-v2. So for the inception-resnet-v2, code of adding cbam and SENet modules would be as:
net += scaled_up
if activation_fn:
net = activation_fn(net)
if cbam_block:
net=cbam_block(net, 'cbam_block')
if se_block:
net = se_block(net, 'se_block')
which means that the attention modules would be added after "net += scaled_up".
Also in the inception-resnet-v2 of cbam-tensorflow-slim, you add the attention module in the  scaled_up branch as " scaled_up= cbam_block(scaled_up, 'cbam_block')" before  "net += scaled_up", while in the the inception-resnet-v2 of SENet-tensorflow-slim, you add the attention module in the  identity  branch as " net = se_block(net, 'se_block')" before  "net += scaled_up".
I don't know if you make these modifications because these modifications show better performance in your own re-implementations. Or, do I make mistakes in understanding the way of adding these two attention modules to the inception-resnet-v2?
Thank you again for your hard work.
All the best.

Since the  inception-resnet-v2 is a residual network, the right way to add  attention modules would be as scaled_up= cbam_block(scaled_up, 'cbam_block')" before "net += scaled_up" according to the paper "Squeeze-and-Excitation Networks". I have made a mistake in understanding the way of adding attention module.

Actually, this is the thing made me confused as well.
Since inception-resnet-v2 model has inception module which has residual summation and SENet paper did not specify where to put attention module, I was confused where to put it for best performance.
So I did experiments for both cases: 1) attention module after inception, 2) attention module before residual summation.
In the case of 2), the model became hard to train (I had to use small learning rate) and got poor performance.
And the case of 1) showed better performance than the other case.
One more to mention, I haven't tried to put attention module after reduction module in inception models.
I think it is good attempt to put attention module after reduction module and see if it gives any performance increase.

I have the same problem when using inception with attention module (have to use small learning rate).
Also, put attention module after reduction module in inception models is a good idea which is worth trying.
All the best.


Add 'upsert' function for observation field values

Currently, put_observation_field_values() will fail if the specified observation field value already exists. It would be much more convenient to create if it doesn't exist, and update (delete and recreate) otherwise. I see this was already noted in the TODOs.

Since this is part of the old API, I'd rather drop this issue and do this for the v1 API instead (see #142)


Support for native typhoeus timeouts

With this patch the typhoeus way of checking timeouts works. The way they check timeouts is with the curl_return_code
https://github.com/dbalatero/typhoeus/blob/master/lib/typhoeus/response.rb#L100

Looks good. I thought it was based on response code 0 before, but maybe it was wrong from the beginning.

code + test = merge to master :) cheers!

Thanks a lot! Any idea when this will get into a release? It's not terribly urgent, but we found the bug while developing a gem and would like to test it properly :) Cheers!

It was just released as 1.7.9 :) Cheers.

That was quick! Thanks a lot :D


wrangler dev runs published worker, not local

🐛 Bug report
Describe the bug
I have a worker that I've already published (not via wrangler publish). When I run wrangler dev, I get a local HTTP server that seems to run the published version of the worker, regardless of what my local code looks like.
Reproduce the bug
Create a webpack-style worker
# wrangler.toml
account_id = "2d9f…"
entry-point = "./index.js"
name = "my-worker"
routes = [
  "www.example.com/my-worker/*",
]
type = "webpack"
webpack_config = "./webpack.config.js"
zone_id = "97d7…"

// index.js

// The published version is much more complex, but I've reduced it to debug locally:
addEventListener('fetch', event => {
  console.log(`fetch ${event.request.method} ${event.request.url}`)
  event.respondWith(new Response('OK', { status: 200 }))
})

Run wrangler dev:
$ wrangler dev
👂  Listening on http://<IP_ADDRESS>:8787
🌀  Detected changes...
💁  Ignoring stale first change

Make a local request:
$ curl -svo /dev/null http://<IP_ADDRESS>:8787
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 8787 (#0)
> GET / HTTP/1.1
> Host: <IP_ADDRESS>:8787
> User-Agent: curl/7.64.1
> Accept: */*
>
< HTTP/1.1 307 Temporary Redirect
< date: Fri, 26 Feb 2021 00:14:55 GMT
< content-type: text/plain;charset=UTF-8
< content-length: 24
…

The wrangler dev log shows
[2021-02-25 16:14:55] GET example.com/ HTTP/1.1 307 Temporary Redirect

If I make a minor change, like commenting out the console.log, the wrangler dev log shows
🌀  Detected changes...

But the request always goes to my zone. It never invokes the local worker.
I've also tried running wrangler build both before wrangler dev and while it's running. Neither has any effect.
Expected behavior
When I make a request to http://<IP_ADDRESS>:8787, it invokes the worker, prints to the log, and receives a 200 OK.
Environment and versions
Mac OS 11.2
$ wrangler -V
👷 ✨  wrangler 1.13.0

$ node -v
v12.16.3

The problem was that "www.example.com/my-worker/*" didn't match the URL since www.example.com doesn't match <IP_ADDRESS>:8787. The only thing that works is removing routes and adding workers_dev = true.
Is there no way to keep routes in my wrangler.toml and yet also support local development?

Possibly a duplicate of #1546

I had the same experience and came up with a work-around. I have my worker published to a subdomain and dev doesn't work correctly, hitting the root domain.
Removing the route in the default config and adding a production env fixed it.
Here's my working wrangler.toml:
name = "worker-dev"
type = "javascript"
account_id = "***"
workers_dev = true
zone_id = "***"

[env.staging]
name = "worker-staging"
route = "worker-staging.example.com/*"

[env.production]
name = "worker"
route = "worker.example.com/*"

wrangler publish no longer publishes to the correct domain, so just do wrangler publish -e production instead.

That doesn't quite work for me, but it inspired this, which does!
name = "worker-dev"
type = "javascript"
account_id = "***"
workers_dev = true
zone_id = "***"

[env.development]
name = "worker-development"
route = "*"

[env.staging]
name = "worker-staging"
route = "worker-staging.example.com/*"

[env.production]
name = "worker"
route = "worker.example.com/*"

I can then wrangler dev --env=development. I just need to make sure never to do wrangler publish --env=dev.
When I run the worker that way and inspect fetchEvent.request.url, the origin https://myzone.com/ even though my curl is to http://<IP_ADDRESS>:8787/.

Awesome. Glad it worked out.
I added all my wrangler scripts in package.json to avoid mistakes. Forgetting to add the env is something I would definitely do.

Bump. There's a good workaround, but this is definitely still a bug.

+1 to solve this issue.
It is very annoying


Remove DNS alias from crackmapexec.wiki -> netexec.wiki

Hello,
Please remove the DNS alias that's currently redirecting crackmapexec.wiki to netexec.wiki.
Thank you.

You should reach out to whoever maintains that DNS directly, it's unrelated to this project.


How to delete a scheduled campaign ?

Hello,
I created a scheduled campaign via the API  but I want to delete this campaign.
How can I do delete a scheduled campaign ?
Could you help me ?
Thank you.
Kind regards.

For your information, we have some new API features for managing your newsletters that you might find useful and there's a blog post here:
https://www.mailjet.com/blog/introducing-new-newsletter-action-endpoints-api/
and the documentation is here:
http://dev.mailjet.com/guides/newsletter-guide/


No peer certificate for SSL resulting in UNRECOGNIZED NAME error

Checklist

Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?

Yes

Are you sure you're not using someone else's docker image?

Yes

Have you searched for similar issues (both open and closed)?

Yes

Describe the bug

After installing NPM using the official instructions and setting up a certificate for domain x.y.com, https connections do not work at all, including the congratulations page. Trying to access the congratulations page via https results in a UNRECOGNIZED NAME error in the browser. Inspecting the certificate via openssl results in:
openssl s_client -showcerts -connect x.y.com:443
CONNECTED(00000003)
40B7D2AD887F0000:error:0A000458:SSL routines:ssl3_read_bytes:tlsv1 unrecognized name:../ssl/record/rec_layer_s3.c:1586:SSL alert number 112
---
no peer certificate available
---
No client certificate CA names sent
---
SSL handshake has read 7 bytes and written 329 bytes
Verification: OK
---
New, (NONE), Cipher is (NONE)
Secure Renegotiation IS NOT supported
Compression: NONE
Expansion: NONE
No ALPN negotiated
Early data was not sent
Verify return code: 0 (ok)
---

Nginx Proxy Manager Version

2.11.2
To Reproduce
Steps to reproduce the behavior:

Install using the quick setup instructions from the README file.
In the portal, add SSL certificate for chosen domain. Using cloudflare DNS challenge, if that makes a difference.
Connect to chosen domain via https. Note the error.

Expected behavior

Congratulations page, as visible via plain HTTP.
Screenshots

n/a
Operating System

TrueNAS custom app deployment.
Additional context

Plain HTTP works. The domain used seems to not be the problem - tried on two different ones.

Running into the same error. I'm using a custom certificate that works when the given configured site is enabled.

I started to get this on Firefox on Windows last week, but not on Ubuntu, until yesterday, when my Firefox on Ubuntu updated to 130.0 and now I get this error on both machines.
However, openssl returns no errors, it only affects browsers in my case.

I'm getting this same error on Ubuntu server lts, in Chromium, Firefox, and openssl


Using netCDF mesh files in dynamics

Writing a python script that converts and exemplary netCDF files to be handled by dynamics.
Later we will decide if we directly handle netCDF in c++ or always run conversion in python before starting computations.

In the future, we plan to have that python script as part of the script that builds an init/restart file. The mesh information is then stored in the init file and passed to the dynamics at run time.

Currently, we have a script creating a smesh file from the information in the restart file. The model then reads the restart file and the smesh file.
In the future, we'll skip creating the smesh file and read everything from the restart file. We'll leave this until the dynamics are merged and we've confirmed everything is working.

We'll leave this until the dynamics are merged and we've confirmed everything is working.

Since we have a working thermo & dynamics model without this feature, I am moving it from 1 Dynamics Merge to 2 Stand-alone model.

A description of the .smesh files, taken from the file run/25km_NH.smesh.

ParametricMesh 2.0
nx ny
Array of coordinates, either as x y pairs in metres for a flat grid or longitude latitude pairs in radians for a spherical grid. nx * ny lines.
landmask npoints

npoints = nx * ny

Array of landmask values. 0 is land, 1 is ocean. nx * ny lines.
dirichlet nbdy

nbdy = the number of edges which have a zero velocity constraint

The dirichlet section details which boundaries have a zero velocity condition. Each line consists of an element index and the edge label of the edge of that element which has a zero velocity constraint. The labels are:

0 bottom, -y
1 right, +x
2 top, +y
3 left, -x


Update StaticSite.json

Add private endpoint connections to static site object.
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
[ ] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@zhangyan133 - can you help take a look at why the python sdk track is failing?

@weidongxu-microsoft , you helped us merge this PR (#13144). We needed make a few updates to the static sites swagger for SDK generation, can you help rerun the failing/flakey test and help us merge this PR to switch the default package? Thanks!

@zhangyan133 Please check python track2 error.
@mkarmark I am not authorized to merge (the button is grey) when python fails. If you really want to force merge, you can find Arthur Ning<EMAIL_ADDRESS>

please add some examples too

@RAY-316 @zhangyan133 Anyone can give a reason why python track2 failed? You are assignee of the release request https://github.com/Azure/sdk-release-request/issues/1419 and I assume you know about the python track2 build?

Citing management @yungezz @yonzhan
Is anyone can help on the Python build failure? It is blocking appservice for days!

@jsntcy to help with

@jsntcy to help with

Wait for a autorest core to fix performance issue, should be fixed early in next week.
@iscai-msft, @timotheeguerin

/azp run

For python, breaking change is ok


Example partial method is not correct.

The partial method demo has a comment that the code can be commented, but if you do so, the example will not compile because of:
CS8795 Partial method 'UserQuery.A.OnSomethingHappened(string)' must have an implementation part because it has accessibility modifiers.
void Main()
{
	var a = new A();
	a.OnSomethingHappened("Ok?");
}

partial class A
{
	public partial void OnSomethingHappened(string s);
}

// This part can be in a separate file.
partial class A
{
	// Comment out this method and the program
	// will still compile.
	//public partial void OnSomethingHappened(String s)
	//{
	//	Console.WriteLine("Something happened: {0}", s);
	//}
}

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b4eedbc9-36be-6c79-fcb4-d5fe6998e5b1
Version Independent ID: 85bf7eb0-b476-94b6-e10a-d0f42fee407b
Content: partial method - C# Reference
Content Source: docs/csharp/language-reference/keywords/partial-method.md
Product: dotnet-csharp
Technology: csharp-language-reference
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Forget it...
By adding public I created the error myself. 🤦


refactor(binding): use the new binding everywhere

Description
extends Bindings is deprecated now, so change to the new way everywhere
Pre-launch Checklist

[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making or feature I am adding, or @jonataslaw said the PR is test-exempt.
[x] All existing and new tests are passing.

@jonataslaw

Thanks for your contribution!
LGTM


Installation trouble

I have been getting this error repeatedly when I try  install. It causes the installation tl stop and cancel out.
zip:unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
Failed to complete chroot setup
Unmounting /usr/local/chroots/precise

well the file that is being downloaded is corrupted (most likely not complete), more info would be needed to figure out which file.

zip? I can't think where crouton would try to extract a zip file...


JTACMonthLayout Crash

(Required) Version Number: 8.0.3
Description
#0	0x000000010483853c in JTACMonthLayout.setupDataFromDelegate() at ~/Pods/JTAppleCalendar/Sources/JTAppleCalendar/JTACMonthLayout.swift:168
JTAppleCalendar was compiled with optimization - stepping may behave oddly; variables may not be available.
Line 168:
strictBoundaryRulesShouldApply = thereAreHeaders || delegate._cachedConfiguration.hasStrictBoundaries
Steps To Reproduce
func setupCalendarView() {
        calendarView.minimumLineSpacing = 0
        calendarView.minimumInteritemSpacing = 0
        calendarView.visibleDates { (visibleDates) in
            self.setupViewsOfCalendar(from: visibleDates)
        }

        if(self.appoDates.count > 0) {
            self.calendarView.selectDates(self.appoDates)
        }
        self.formatter.dateFormat = "yyyy MM dd"
        self.calendarView.selectDates([formatter.date(from: getTodayDate())!])
    }

    func setupViewsOfCalendar(from visibleDates: DateSegmentInfo){
        let date = visibleDates.monthDates.first!.date
        formatter.dateFormat = "yyyy"
        year.text = formatter.string(from: date)
        formatter.dateFormat = "MMMM"
        month.text = formatter.string(from: date).capitalized
    }

Expected Behavior
Additional Context

is it possible you can provide a sample app with this crash?

I am also getting the same crash.
Any luck with solving that @cesariel ?

@umarchohan
is it possible you can create a sample app (a barebones minimal app with no company code inside it) that recreates this issue?

@patchthecode
you can check with these settings as per @cesariel
func setupCalendarView() {
        calendarView.minimumLineSpacing = 0
        calendarView.minimumInteritemSpacing = 0
        calendarView.visibleDates { (visibleDates) in
            self.setupViewsOfCalendar(from: visibleDates)
        }

        if(self.appoDates.count > 0) {
            self.calendarView.selectDates(self.appoDates)
        }
        self.formatter.dateFormat = "yyyy MM dd"
        self.calendarView.selectDates([formatter.date(from: getTodayDate())!])
    }

    func setupViewsOfCalendar(from visibleDates: DateSegmentInfo){
        let date = visibleDates.monthDates.first!.date
        formatter.dateFormat = "yyyy"
        year.text = formatter.string(from: date)
        formatter.dateFormat = "MMMM"
        month.text = formatter.string(from: date).capitalized
    }

if you are using the same code.
Can you confirm that it is not crashing at the forced optional values?
I see you force the values
here -->         self.calendarView.selectDates([formatter.date(from: getTodayDate())!])
and here ->    let date = visibleDates.monthDates.first!.date
using the ! character.


"Ask for Help" Modal text legibility

Describe the Issue
I was looking at #52233 and I wonder if we should improve the legibility of that heading text as well.

The default Bootstrap line-height: 1.1 isn't great here.
The Hack-ZeroSlash font used with font-weight: 700 makes it harder to read in my opinion.

Here is the Modal with line-height: 1.5rem and the default font-weight: 400 for the heading.

And here is the original

Affected Page
Any challenge with "Get Help"
Steps to Reproduce
Open the Modal
Expected behavior
Better legibility of the heading text.
Screenshots
No response
System

Device: [e.g. iPhone 6, Laptop]
OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 22]

Additional context
No response

Isn't it already correct?

I don't know what you mean by correct.
I'm suggesting changing the line-height and font-weight to make it easier to read. I'm talking about the h3 with the Read-Search-Ask link in it to be clear.

It is less of an issue in light mode than dark mode but I still think the legibility can be improved by the suggested changes.

I don't think it's hard to read, but it does feel a little condensed and I do think it looks better with a little more space. With the added space, we may not need to make the adjustments to the link underlines.


@RetryableTopic: support for re-processing of records after DLT handling

Expected Behavior
Support, or at least easiness, to allow designs where records may need to be "reprocessed" again after the DLT handling has been done and after the root cause of the processing error has been fixed.
Current Behavior
After retries have been exceeded, the application has to deal with the record in the @DltHandler method. But in some application cases, the record cannot be completely discarded.
Context
As for critical topics records that exceeded retries cannot be discarded, what we do here is to persist the record data somewhere else (tipically in a database).
The application has an Administration Console where the operations team can query and inspect the records that exceeded retries (and also the Exception data that caused the error, because in the @DltHandler we actually submit the record to the actual listener one more time to have the information of the Exception being thrown by the listener).
After the root cause of the error has been fixed (for instance, a database or an external service that was not responding gets back online, or a bug in the code has been fixed), through the console the operator has the means to select some of the records (or all from a specific original topic) and trigger a "reprocessing" of such records.
A good way of doing this reprocessing would be to restart the flow again, that is, to resend the record to topics chain again.
However, we cannot send the message to the original topic, because we would be creating dirt in it. As it is my problem that I was not able to consume the record, I should send the record to the first retry topic in my retriy topics chain.

for fixed delay and multiple topics, this would be "originalTopic-retry-0".
for fixed delay and single topic, this would be "originalTopic-retry"
for non-fixed delay, this would be the first retry topic, like say "originalTopic-retry-1000"

What spring-kafka might provide would be easiness for the application to send a record to the first retry topic in the chain, for a given original topic. And it is fine that when sending a message to the first topic, if the consumer is currently stopped waiting for the delay of the messages that are already there.
This might be done in more than one way:

just providing some utility to return to the application the name of the first retry topic in the same way the framework internally mount this name, and the application takes care of everything else.
providing some mean/method that receives a ProducerRecord already instantiated by the application, and then populate in this record the needed headers and then send the record to the first retry topic.

In fact, we are already doing this by ourselves here, just sending the record to the first retry topic. But we are doing this in a risky way, because we duplicated the logic to mount the first topic name, and also, counting on luck because it turns out that posting a record without the internal control headers just work. But ideally the library should populate all the control headers properly.

Hi @jgslima, thanks for bringing this up.

because in the @DltHandler we actually submit the record to the actual listener one more time to have the information of the Exception being thrown by the listener).

These record headers in the message received in the DLT should contain the information regarding the exception thrown by the listener: kafka_exception-fqcn, kafka_exception-message, kafka_exception-stacktrace, so you shouldn't need to consume the record again. Do you not have access to these, or maybe you need some other information?

What spring-kafka might provide would be easiness for the application to send a record to the first retry topic in the chain, for a given original topic. And it is fine that when sending a message to the first topic, if the consumer is currently stopped waiting for the delay of the messages that are already there.

You can get the next topic name by injecting the DestinationTopicResolver bean and using the resolveDestinationTopic(String topic, Integer attempt, Exception e, long originalTimestamp) method. This will return a DestinationTopic instance with which you can then getDestinationName().
Besides the main topic name you need to provide arguments that will classify for retrial, e.g. attempts < maxAttempts for the topic, a retryable exception, and a timestamp before timeout if timeout is configured for the topic.
You can for example have something like: resolver.resolveDestinationTopic("myMainTopic", 0, new RuntimeException(), Instant.now().toEpochMilli()).getDestinationName().
Do you think that would solve the problem?
We could look into having a more direct getNextTopic(String topic) method, but then it could return a different result from the actual topic the record will be sent to, in case some other criteria fails, which might generate some confusion.

This might be done in more than one way:

just providing some utility to return to the application the name of the first retry topic in the same way the framework internally mount this name, and the application takes care of everything else.

Since topic naming includes bean-based and per-topic configurations, I don't think it'd be straightforward to provide such a utility. Maybe we could have an addNamingListener method with listeners that would be called with the topic names as they are created so users can have access to them, in case the DestinationTopicResolver solution isn't enough.

providing some mean/method that receives a ProducerRecord already instantiated by the application, and then populate in this record the needed headers and then send the record to the first retry topic.

In fact, we are already doing this by ourselves here, just sending the record to the first retry topic. But we are doing this in a risky way, because we duplicated the logic to mount the first topic name, and also, counting on luck because it turns out that posting a record without the internal control headers just work. But ideally the library should populate all the control headers properly.

If my understanding is correct, you're feeding the record to the first retry topic and it's being consumed as a regular record, without back off (unless the partition is already paused) or attempt counting. I haven't tested that exact scenario, but that shouldn't be a problem - if the record processing fails, it'll be forwarded to the next retry topic and the control headers will be added normally by the framework.

One caveat I've noticed is that, since the RetryTopicBootstrapper kicks in lazily in a @KafkaListener bean post processing, if you try to inject any of the feature's beans in a @Component before the bootstrapping happens it will throw a NoSuchBeanException.
If that happens, a workaround would be bootstrapping the feature eagerly in a @Configuration class, with something like:
@Bean(name = RetryTopicInternalBeanNames.RETRY_TOPIC_BOOTSTRAPPER)
public RetryTopicBootstrapper retryTopicBootstrapper(ApplicationContext applicationContext) {
	RetryTopicBootstrapper bootstrapper =
			new RetryTopicBootstrapper(applicationContext, applicationContext.getAutowireCapableBeanFactory());
	bootstrapper.bootstrapRetryTopic();
	return bootstrapper;
}

@garyrussell, I'll take a look to see if I can come up with a way around this, but it doesn't sound trivial since we only have access to the annotation-based configurations when the beans are being processed, to detect if the feature is being used. Maybe we could have a @EnableRetryableTopic annotation in Boot's auto configuration that calls this logic eagerly if present?
If you have any ideas please let me know.
Thanks

Thank you for dedicating time to my issue and providing a detailed answer.

These record headers in the message received in the DLT should contain the information regarding the exception thrown by the listener: kafka_exception-fqcn, kafka_exception-message, kafka_exception-stacktrace, so you shouldn't need to consume the record again. Do you not have access to these, or maybe you need some other information?

That sounds fine, I had forgotten about those headers. I will try and use them.

If my understanding is correct, you're feeding the record to the first retry topic and it's being consumed as a regular record, without back off (unless the partition is already paused) or attempt counting. I haven't tested that exact scenario, but that shouldn't be a problem - if the record processing fails, it'll be forwarded to the next retry topic and the control headers will be added normally by the framework.

Yes, it just works. If there is again an error when consuming from the first topic, the flow continues normally. And it is fine if there is no backoff for the first record.

Since topic naming includes bean-based and per-topic configurations, I don't think it'd be straightforward to provide such a utility.

I do not want to insist on this. If its complicated, or if you think it does not add to spring-kafka, nevermind and feel free to close the issue.
I just wonder whether it might be useful to include in the documentation some guidance about this. Wondering here whether there may be other applications that may have critical topics and want to make the same approach than us (to store the record in the DltHandler, and after the root cause has been fixed, to "restart" the flow).

I do not want to insist on this. If its complicated, or if you think it does not add to spring-kafka, nevermind and feel free to close the issue.
I just wonder whether it might be useful to include in the documentation some guidance about this. Wondering here whether there may be other applications that may have critical topics and want to make the same approach than us (to store the record in the DltHandler, and after the root cause has been fixed, to "restart" the flow).

No worries, I think you have a valid use-case, and that it's important that the framework assists you as much as it can.
Did you check the DestinationTopicResolver solution?
You can for example inject it in your DLT handler class and use it to fetch the retry topic name for that topic, and then persist it alongside the record for the console application to retrieve later.
Or you can have an endpoint in your application that the console app could access passing the failed record's topic as a parameter - your app would lookup the retry topic in the  DTR bean and provide it in the response.
Does this look like it would work for you?
If the method signature looks complicated, we can look into providing a simpler one as I mentioned.
Once we find a suitable solution for your use case, we can look into documenting it.
Thanks

I tried here DestinationTopicResolver.
It worked well, like you suggested:
resolver.resolveDestinationTopic("myMainTopic", 0, new RuntimeException(), Instant.now().toEpochMilli()).getDestinationName()
I tested for all those cases:

fixed delay with single topic.
fixed delay with multiple topics.
non-fixed delay.

Some remarks:

attempt parameter => I noticed it does not really matter (at least when specifying the topic parameter as the main topic). But, if this will be included in the documentation, as the intention is to resolve to the first retry topic, I think it is more intuitive (and more prepared for eventual modifications in the logic) to inform the value 1.

Exception parameter => I noticed in DefaultDestinationTopicResolver that it is used to define whether the exception should be retried or sent directly to DLT. So, it may be good in the documentation to recommend to pass an Exception that is not filtered to go directly to the DLT (although I believe in most cases a RuntimeException should no be filtered to go to the DLT).

indeed it was not possible to inject a DestinationTopicResolver. I had to initialize it lazily in the firs use with applicationContext.getBean(DestinationTopicResolver.class). For me that's fine.

So what I requested in the issue is accomplished. Now it is the case to decide whether to include in the documentation some tips/guidance.
Thank you.

That's good news, thanks. I think we can create a simpler method call in the DestinationTopicContainer interface - we actually have internal methods for resolving topics, it should be a matter of opening them up and adding to the interface.
May I ask what approach you used - persisting the topic in the database along the record maybe, or some other strategy? That might make a good example in the documentation.
As for the autowiring problem, I've opened this issue and hopefully we'll be able to have the fix in the upcoming 2.8.4 version.

We are doing the following way
DTL handling
We make the @DltHandler of each listener to have a single parameter, of type ConsumerRecord, and just it is passed to the console library's class.
In it, these headers are extracted:

KafkaHeaders.ORIGINAL_TOPIC
KafkaHeaders.EXCEPTION_STACKTRACE
KafkaHeaders.EXCEPTION_MESSAGE (although what I think is more useful is just the message of the rootCause, but that's ok).

The key and value are extracted and re-serialized to byte[] in order to store the binary contents (unfortunately the ConsumerRecord does not provide means to access the original byte[] of the key and value). This part is a little tricky, because in theory the central component must have means to know the proper Serializer for each application topic.
Also, just to allow the message content to be inspected in case of a drill down in the application console, we pass the value Object of the record through Jackson, just to have a textual (in this case, JSON) representation of the message (regardless if the actual Serializer used for this topic is JSON or Avro or whatever).
All those information are then stored in the database, alongside some timestamp. From there, they can be queried, and from the console the user can trigger a reprocessing (either of specific records or for all records from the same original topic).
Currently we do not support the persistence of arbitrary headers the records may have. This may be added in the future.
Reprocessing
If the user triggers a reprocessing of the message:

Key and value are re-serialized to Objects.
A ProducerRecord is created.

with the topic name being the first retry topic.
here, a detail: we must populate the KafkaHeaders.ORIGINAL_TOPIC with the original topic name. Otherwise, if this record exceed retries again, in the next @DltHandler processing, the framework will assume that the original topic was the first retry topic, not the real original topic.

The ProducerRecord is sent.

It takes some work to develop these features but they are worth it. On top of that one may add some enhancement, like generate metrics and alerts to operations team when there are new, or many, new records in the database and so on.


Add validation for multiple fields use case

Is there a way to remove the "/" in the input, make them separate input fields and still make the animation work? I'm using stripe to submit my payment form and it doesn't accept the format 12/1996 etc. It needs separate fields like Month:12, Year: 1996. Is there a work around to this?

Validation for mm/yyyy would be nice to making sure that first its a proper year as i can enter 00/0000 and it still accepts + the epiry mm/yyyy is not less than current date

Is it possible to use two  inputs for month/year? I'm trying it with no luck. . . The Card.js finds the  tags just fine. . . but when the values change it does not update the card.
If not, can you advise on how to programmatically update the expiry? I tried creating a hidden text field. .  but no matter what event I trigger on that field, the card visual does not get updated.

This should work fine:
https://github.com/jessepollak/card#using-multiple-inputs-for-one-field.
On Tue, Oct 6, 2015 at 9:46 AM, Luke Walker<EMAIL_ADDRESS>wrote:

Is it possible to use two inputs for month/year? I'm trying it with no
luck. . . The Card.js finds the tags just fine. . . but when the values
change it does not update the card.
If not, can you advise on how to programmatically update the expiry? I
tried creating a hidden text field. . but no matter what event I trigger on
that field, the card visual does not get updated.
—
Reply to this email directly or view it on GitHub
https://github.com/jessepollak/card/issues/98#issuecomment-145923917.


Continued IE map issues...

The Germans report continued issues on certain computers using IE, although it only becomes an issue on a few computers... We're trying to get more information, and will update you soon!

Any more information on this ?

Nope... let's email them what we've got tonight and ask them what their problems are. Perhaps they're using a different version from what they told us?


exploitdb: 2022-03-01 -> 2022-03-03

Motivation for this change
update to 2022-03-03
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 162611 run on x86_64-linux 1

1 package built:

exploitdb


vm in test cases

variables defined with vm
vm = this;
vm.var1 = 1;
now in jasmin test cases
$controller('RiskAnalysis', {
$scope: scope,
});
I can not access the scope.var1
For that should I need to use also
$scope.var1 = 1 in controller?

Those vm variables are defined on the this which is in your case the controller object.
Therefore in your jasmine tests you can access those on the controller. The $controller function returns the controller object. On which you should be able to access the var1 variable.
The following should work.
var riskAnalysisController = $controller('RiskAnalysis', {
    $scope: scope,
});

expect(riskAnalysisController.var1).toBe(1);


Add /kanye command using Kanye Rest API

Command Name
/kanye
Public API Resource
https://api.kanye.rest
Description
This command will generate a random Kanye West quote.
Implementation Details

Add a new javascript file in the commands folder
Use axios fetch the data from your public API
Format the data in a readable way and send it to the user
Use the discord.js docs to get started

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I would like to work on this. Please assign me.

@Soumi150 Sure, go ahead!


FireShot makes this redundant

The FireShot Chrome extension (and any screenshot extension that supports full page shots) makes this project redundant because you can always create a gist (ej gist.github.com) and screenshoot it instead of using this.
Example (taken with FireShot, no cropping but it has that option too):

Also, it damages readability (cant be googled cause it's an image, etc); so its better just to copy the generated HTML with something like  SnappySnippet

Thanks for the suggestion! FireShot doesn't quite do what I want, which is capture HR images in bulk.
I generally only use images of code in Keynote presentations, so I am okay with the lack of indexability in those cases.


UI Improvements for Login and Sign-Up Pages

Enhanced the UI of the login and sign-up pages to align with the main site's aesthetic and improve user interaction. Adjustments include updated colors, improved button placement, and more cohesive styling to ensure a polished and consistent look. These updates aim to streamline the user experience, making the login and sign-up process visually appealing and intuitive.
Kindly assign this issue to me under GSSoC-Extd and Hacktoberfest.

similar issues are already assigned


Check contract exist

Coverage increased (+0.07%) to 88.294% when pulling c56e35215f5ab1671a4c85375e95e9c9822b26c9 on oleksiyVeretiuk:check_contract_exist into 6784f5f122890b30b444cfbe478be47e2726b540 on openprocurement:master.


Simplify branch protections: sentinel only

Per https://github.com/pulumi/ci-mgmt/pull/687#issuecomment-1766798595
would like to simplify branch protections to only require "sentinel" to pass.
Using branch protections that mention individual step names is making the system sensitive to refactors of the CI job layout.
It appears that relying on the sentinel is now safe.

Fixed in #948


silence body logging for a single request.

Not sure if this is viable, but I have a request that returns a massive payload. instead of logging it, I would prefer to silence it. We use a singleton(ish) axios instance, because... well, whatever. I could overwrite the interceptors temporarily, maybe there's an option that can be handled by the interceptor. Probably an opportunity for an option to be passed to the logger.

this apparently is happening with logging the body in an error...

anyways, it's a 19M body, but I don't actually want to squelch the body logger for everything. Just things over a certain content size, or probably unknown size.

@xenoterracide would silensing body configuration work for you ?
// If you want to ommit request headers and body
const config = { response: { shouldLogBody: false} }

?

yes, but I want it only on a specific request, but I'd rather not recreate the interceptors or the instance of logger for this, so if there was something I could set on the request itself... which is kind of why I'm suggesting a size limit
{ response: { maxLogBodySize: 1024 }}

note: also have a problem where there's a layer between us and axios, which I think is stripping configs. so setting in the interceptors themselves is difficult because I would have to make a match url regex...

maxLogContentLength is probably a better name

@xenoterracide give it a try in 0.2.9 version )

❯ npm explain @new10com/axios-logger
<EMAIL_ADDRESS>
doesn't actually seem to work :'(
Content-Length | 314290

still has the body logged
const axiosLogger = AxiosLogger.default({
  obfuscation: {
    obfuscate: true,
  },
  response: {
    maxLogContentLength: 1024,
  },
})

function withTracingInterceptor(axiosInstance: AxiosInstance): AxiosInstance {
  axiosInstance.interceptors.request.use(
    config => axiosLogger.logRequest(config),
    error => axiosLogger.logErrorDetails(error),
  )
  axiosInstance.interceptors.response.use(
    response => axiosLogger.logResponse(response),
    error => axiosLogger.logErrorDetails(error),
  )
  return axiosInstance
}

@xenoterracide you are right about the message - i missed that part to fix it. I have updated it in 0.2.10 version. The way I was calculating the length of the body is following :
const bodyLengthInBytes = Buffer.byteLength(bodyAsString)
      if (bodyLengthInBytes > maxLogContentLength) {
        return `Body is too long to be displayed. Length: ${bodyLengthInBytes} bytes. Max length: ${maxLogContentLength} bytes.`
      }

The thing is that I'm not checking Content-Lenght header because parser of the body does not take headers as an input. I might be wrong on this side, but I thought that calculating size this way will be accurate. Are there cases when this would not work ?
I used a very simple unit test to verify that this work:
it(`should return warning message when body length is longer then set in config`, () => {
      const body = 'Hello how are you?'.repeat(100)
      expect(
        formatter.prettyFormatBody({ body, maxLogContentLength: 10 })
      ).toEqual(
        `Body is too long to be displayed. Length: 1802 bytes. Max length: 10 bytes.`
      )
    })

No, that should work. I think... That doesn't read all of them into memory does it?... Like make a second copy. I'm on my phone right now so I can't check.
I think if that's how it's going to be measured then the API should be a little bit different in order to make it clear that we're dealing in kilobytes or whatever... I just found it a little unintuitive and if I hadn't read the code I wouldn't have noticed that it wasn't in bytes directly.

it would appear that memory usage has gone up, not sure to what exactly but this code runs in 128M of ram without this. Also I think it conflicts in a weird way with shouldLogBody: true it seems like no body's were being logged when I had that set.

Will need to look into optimization of it based on header indeed

Yeah, as it is, doesn't help me sadly. Oh well, I conditionalized the should log for now

so, any chance for having this based on header if present soon?

@xenoterracide I have refactored how body length calculation happens ( now it's based on Content-Length header value ) . It's published in 0.2.12 version. Could you give it a try and see how it works ? Keep in mind that maxLogContentLength is present in both request and response configurations. So, if you want to "cut" both request and response - it has to be set in both configs.

tested, looks good to me. thanks!

oh, this is not at all important, but if you ever wanted to print the values in human readable, like 19M instead of 19247467 that'd be cool. Not important or blocking though.


Session Cookies

While Shrimp appears to be dumping my session cookies correctly to the file, it doesn't appear that PhantomJS is loading them correctly.
Is this a defect or expected behavior?  Any suggestions for correcting the issue?

which phantomjs version ?
I dop not have any problem, with a custom phantomjs build (v2 compile with qt4 - qt5 is not working)


odo url list -o json should return json with empty list if no url present

[kind/bug]
What versions of software are you using?

Operating System: macOS
Output of odo version:

odo v0.0.20 (bd3e74a4)
Server: https://<IP_ADDRESS>:8443
Kubernetes: v1.11.0+d4cacc0

How did you run odo exactly?
odo url list --component <comp> --app <name> -o json
Actual behaviour
Currently it prints the text as mentioned below:
✗  no URLs found for component front in application demo
Expected behaviour
If there are no URLs odo url list --component <comp> --app <name> -o json should return an empty list.
{   "kind": "List",   "apiVersion": "odo.openshift.io/v1alpha1",   "metadata": {},   "items": [] }
Any logs, error output, etc?

Can we please mark this as priority, as this will help us to fix 2-3 issues together on vscode side. :)

/priority High

/priority medium
@syamgk everything marked with new workflow has higher priority than this,

/remove-priorty high

@kadel  ack!


nutch isn't on the PATH

nutch is a user-installed tool, so celery workers (which do not invoke a shell) don't know how to discover it on the local PATH.
I think our long-term solution to this is going to be using the REST API to communicate with nutch, so I'm just going to kludge around this by invoking shell=True.  I understand that this is a security risk, but we're not locking down this code right now.

Okay, this fixes at least one issue and is exposing another.

We ended up not using this idea.


What is the purpose of telegraf ?

I'm a bit new to the docker world and I'm trying to wrap my head around it:
Wouldn't this stack only colect metrics from inside the telegraf container?
Thanks!

Feel free to close the issue


Feature request: lua support

It would be really nice to add support for lua (or any other scripting language). Below follows a design that could work, but really I care most about the capability and not so much the specifics.
The only way to add functionality is to open an issue. Sometimes functionality really does not belong in BeefText itself because it is too specific, but that is currently the only way. I don't think that scripting should replace built-in variables, but it would be a nice extension.
My personal use case is more advanced date manipulation. Specifically I am using Roam Research which formats dates like June 1st, 2020. There is currently no way to add the st using qt date format strings that I could find.
Initial design
As I said above, this is just a suggestion. Similar to Combos, scrips are user defined snippets of lua code. They must be a function and can have a name. These can be called from combos.
In Combos, there's a new special variable that allows calling functions: #{script:myFunc('some input')}. This calls the function and inserts the returned string. The general format is #{script:<single line of valid lua>}.

It's an interesting idea, however I must admit this is quite a development effort, and I have limited time to work on Beeftext, so you should not expect it to be implemented soon.

I don't have much experience with C/C++ but if I created a mock implementation, would you be willing to review it? There would be no expectation to have it merged, just want to see if I can get it working.

Hi.
No. I have many other things I want implemented first, and such a feature will require a level of maintenance that I cannot afford.

for my purposes this can be closed with #305.


People list for admin page closes #41

Making a PR to use GitHub's code review tools. @ktinubu to update this message when the PR is ready.

@ktinubu I realize that you can't see the actual specs for the designs. It would have made it easier, as it would have provided widths etc. This looks great though, approximate design is perfect.

okay the PR is ready

good stuff


Memory leak when computing multiple SOAPs in the same script

Hi,
I am currently working on a project to use SOAP vectors as descriptors of atomic environments for protein pockets.
I was working with another package until now, and would like to use dscribe to compute soaps and derivatives. However working with protein system is quite large, and there is an issue of memory leak that I found while computing soaps for hundreds of proteins.
I tried to show this with a script that compute the same soap for 1000 times, and check the memory usage throughout the iterations. Doing this for water only does show the behaviour, but it is way more visible in terms of memory when doing this for a protein (what I'm actually doing is that I compute the SOAP integrating the protein atom environment but using ligand atomic positions).

import os
import psutil
import matplotlib.pyplot as plt
from ase.io import read as aseread
from ase.build import molecule
from dscribe.descriptors import SOAP

# define soap calculator
rcut = 5
nmax = 6
lmax = 4
sigma = 1
calculator = SOAP(
        rcut = rcut,
        nmax = nmax,
        lmax = lmax,
        sigma = sigma,
        species = "H,C,N,O,S".split(",")
    )

# load molecules to be processed
water = molecule("H2O")

protein_config = aseread('protein_6q48AA.pdb')
protein_config = protein_config[[atom.index for atom in protein_config if atom.symbol in ['C', 'N', 'O', 'S']]]

ligand_config = aseread('ligand_6q48AA.pdb')

# Loop 1 : No action
memory_usages = []
baseline = psutil.Process(os.getpid()).memory_info().rss / 1024 ** 2
for _ in range(1000) :
    usage = psutil.Process(os.getpid()).memory_info().rss / 1024 ** 2
    memory_usages.append(usage)

memory_usages = [usage - baseline for usage in memory_usages]
plt.plot(memory_usages, label='No action')

# Loop 2 : Computing SOAP for a single water system
memory_usages = []
baseline = psutil.Process(os.getpid()).memory_info().rss / 1024 ** 2
for _ in range(1000) :

    soaps = calculator.create(system=water)
    usage = psutil.Process(os.getpid()).memory_info().rss / 1024 ** 2
    memory_usages.append(usage)

memory_usages = [usage - baseline for usage in memory_usages]
plt.plot(memory_usages, label='SOAP for water')

# Loop 3 : Computing SOAP for a protein system
memory_usages = []
baseline = psutil.Process(os.getpid()).memory_info().rss / 1024 ** 2
for _ in range(1000) :

    soaps = calculator.create(system=protein_config, positions=ligand_config.positions)

    usage = psutil.Process(os.getpid()).memory_info().rss / 1024 ** 2
    memory_usages.append(usage)

memory_usages = [usage - baseline for usage in memory_usages]
plt.plot(memory_usages, label='SOAP for protein')

plt.title('Creating SOAPS for a system 1000 times')
plt.xlabel('Iteration')
plt.ylabel('Memory usage (MB)')
plt.legend()
plt.savefig('memory_leak_dscribe_soaps', bbox_inches='tight')

Here are the files to reproduce the script if needed. Replace the .txt extension by .pdb
ligand_6q48AA.txt
protein_6q48AA.txt
I'm using dscribe v1.1.0, installed with pip.
Do you have any idea where does the memory leak come from ? Is there any work around or ways to fix this ?
Best regards, and thanking you in advance
Benoit

Hi @benoitba!
Thank you for reporting this. Indeed it looks like a memory leak based on your test script, thank you for providing it. We will take a look and try to find the culprit. If you want to quickly try something, you can downgrade to some previous version (e.g. 1.0.0), and try if the leak is present there.
-Lauri

The leak is not here on dscribe 1.0.0, so I will work with this version from now on. Thanks a lot for the advice, and hope you find the cause of the leak on the 1.1.0 version :)

Now fixed in v1.2.0.

Hi, I understand this issue has been fixed. I am curious to know what cause the memory leak in v1.1.0, I tried using del some varibales in the loop and gc.collect(), that way didn't solve the memory leak problem.

Hi @GravityPHY!
Yes, the problem has been fixed from v1.2.0 onwards. You may not notice it, but like many other Python libraries that target high performance, we are using C/C++ extensions underneath to do the heavy lifting. This is where the memory leak was happening (missing free somewhere). It would be really hard to introduce a memory leak with python only :)


SCSS install instructions not working

$material-design-icons-font-directory-path: '~material-design-icons-iconfont/dist/fonts/';
@import '~material-design-icons-iconfont/src/material-design-icons';
Leads to:
Error: File to import not found or unreadable:

Try
$material-design-icons-font-directory-path: '~material-design-icons-iconfont/dist/fonts/';
@import 'material-design-icons-iconfont/src/material-design-icons';

Remove the ~ from the @import statement

On my side, basing myself on the readme in the Google Materials icons project, this seems to wor for me:
@import 'material-design-icons-iconfont/dist/material-design-icons.css';


Is there a list of all know shipit tasks? (3rd party and official)

@callerc1 no, but I will try to do it in the readme.

@neoziro awesome thats great. I was wandering if anyone has tackled a "shipit-npm" package that is based on the concept of https://github.com/capistrano/composer/

@callerc1 I don't know, @timkelty has done a lot of plugins, but I don't know if there is one like that.

@callerc1 Are you looking for a composer task? I actually have one I just need to publish. I'll do that this week.

Or are you looking for something that runs an npm command before deploying?

Looking to run npm commands as part of the deploy process. Eg on "updated" event npm install.
Cheers
Chris
On Mon, Mar 2, 2015 at 8:24 PM, Tim Kelty<EMAIL_ADDRESS>wrote:

Or are you looking for something that runs an npm command before deploying?
Reply to this email directly or view it on GitHub:
https://github.com/shipitjs/shipit/issues/39#issuecomment-76809224

@callerc1 Is there a reason you don't want to do that stuff locally in the shipit workspace? (on the fetched event?

Kind of a toss up, but that way you don't have to worry about deps on your server, which is why I do it locally.

Because I've noticed some issues with  some of my app dependencies and npm installing direct on the box seems to fix it. That's something I can double check tho. Event callback aside I think an shipit npm equivalent to the cap composer gem that mimics the task functionality would be really helpful. I'll probably make a start on something later this week.

I think perhaps having the option to change the callback listener as an option could work, that way it covers both scenarios.

Ok - I'll let you know if I push anything out.

Awesome.

@neoziro could be a good use for a Github wiki on this repo?

@timkelty I think we can put all in the readme, the module is quite simple.

Yeah I would like to see a list of events. I'm trying to populate server addresses before I run any deployments, and I can't figure out which task to bind to.

@outrunthewolf the events are all listed here: https://github.com/shipitjs/shipit-deploy#workflow-tasks

Awesome. Whats the syntax for using that:
shipit.on('deploy:init', function() {
});

Is that right?

shipit.on('deploy', function() {
});

The name of the event is where it says

Emit event "deploy".

@timkelty @neoziro i published this just now. would be great to have your thoughts:
https://www.npmjs.com/package/shipit-npm
Cheers

Nice! I was considering just making a shipit-package-managers to do this, composer, bower, bundler etc.

@callerc1 @timkelty thank you!

Now in the readme, I close it.


Can i contribute

I have a few like 5-6 passwords used by fellow Indians with me. I always wanted to create a huge database for Indian passwords. So can we contribute?

Ya sure, please fork the repo and make the update.
I will merge the results.
I also was unable to find an Indian wordlist so I created one, even though it's still small but will grow with more contributions.


Unable to find appropriate backend for test.bucket.amazonaws.com.Remember

Hello,
I'm using moto_server on moto versions 3.1.0 and 3.1.1 to mock S3 for testing an S3 backed PyPI server that I'm building.  I'm creating a test_bucket with the following code:
        self.moto_portnum = random.randint(9000, 9999)
        self.bucket_name = 'test_bucket'
        self.moto_endpoint = f'http://localhost:{int(self.moto_portnum)}'

        ...

        moto = sh.command('moto_server')
        job = sh(
            moto('-p', str(self.moto_portnum)),
            wait = False
        )

        ...

        s3 = boto3.resource(
            's3',
            endpoint_url=self.moto_endpoint,
            aws_access_key_id='testing',
            aws_secret_access_key='testing',
            aws_session_token='testing',
            region_name='us-east-1'
        )
        s3.create_bucket(Bucket=self.bucket_name, ACL='public-read')

Then I'm attempting to download a file from it using pip, with a flask server as an intermediary facilitating package listing, uploads, and downloads:
        sh = self.sh
        pip = self.pip
        python = sh.command('python')

        # The following call to boto3 works
        s3 = boto3.resource(
            's3',
            endpoint_url=self.moto_endpoint,
            aws_access_key_id='testing',
            aws_secret_access_key='testing',
            aws_session_token='testing',
            region_name='us-east-1'
        )
        key = "repo/axle-test-a/axle_test_a-0.0.0-py2.py3-none-any.whl"
        x = s3.Object(self.bucket_name, key).get()

        # But the pip install fails, after my Flask engine that lives at self.endpoint redirects the download to self.moto_endpoint
        sh(pip('install', '--verbose', '--index-url', self.endpoint, '--retries', '1', 'axle_test_a'))
        result = sh.evaluate(python('-m', 'axle_test_a'))

        self.assertEqual(result, "axle_test_a\n")

The call to s3.Object().get() works great:
<IP_ADDRESS> - - [22/Mar/2022 15:06:00] "GET /test_bucket/repo/axle-test-a/axle_test_a-0.0.0-py2.py3-none-any.whl HTTP/1.1" 200 -

But the call to pip fails when it tries to download the wheel from moto_server's mock S3 directly:
Unable to find appropriate backend for test.bucket.amazonaws.com.Remember to add the URL to urls.py, and run scripts/update_backend_index.py to index it.
<IP_ADDRESS> - - [22/Mar/2022 15:06:01] "GET /test_bucket/repo/axle-test-a/axle_test_a-0.0.0-py2.py3-none-any.whl HTTP/1.1" 500 -
  http://localhost:9205 "GET /test_bucket/repo/axle-test-a/axle_test_a-0.0.0-py2.py3-none-any.whl HTTP/1.1" 500 290
Error on request:
Traceback (most recent call last):
  File "/home/alaric/projects/src/axle/venv/lib/python3.9/site-packages/werkzeug/serving.py", line 324, in run_wsgi
    execute(self.server.app)
  File "/home/alaric/projects/src/axle/venv/lib/python3.9/site-packages/werkzeug/serving.py", line 313, in execute
    application_iter = app(environ, start_response)
  File "/home/alaric/projects/src/axle/venv/lib/python3.9/site-packages/moto/moto_server/werkzeug_app.py", line 239, in __call__
    backend_app = self.get_application(environ)
  File "/home/alaric/projects/src/axle/venv/lib/python3.9/site-packages/moto/moto_server/werkzeug_app.py", line 181, in get_application
    app = self.create_app(backend)
  File "/home/alaric/projects/src/axle/venv/lib/python3.9/site-packages/moto/moto_server/werkzeug_app.py", line 261, in create_backend_app
    backend_dict = backends.get_backend(service)
  File "/home/alaric/projects/src/axle/venv/lib/python3.9/site-packages/moto/backends.py", line 48, in get_backend
    module_name, backends_name = BACKENDS[name]
KeyError: None

This appears to be a bug in moto_server's handling of unauthenticated custom S3 buckets' urls.  Please advise.

Hi @jroose, welcome to Moto!
Where is this URL, test.bucket.amazonaws.com, coming from?
Looking at the error message, it looks like the full URL that PyPi tries to connect to is:
test.bucket.amazonaws.com/test_bucket/repo/axle-test-a/axle_test_a-0.0.0-py2.py3-none-any.whl
Which looks wrong - IIRC, it should be either s3.amazonaws.com/bucket, or bucket.amazonaws.com/file

I'm honestly not sure where the test.bucket.amazonaws.com is coming from -- I assumed it was something within moto.  The output of pip --verbose (omtited for brevity) shows that pip isn't/shouldn't be trrying to connect to it:
http://localhost:8868 "GET /simple/axle-test-a/ HTTP/1.1" 200 496
  Found link http://localhost:9161/test_bucket/repo/axle-test-a/axle-test-a-0.0.0.tar.gz (from http://localhost:8868/simple/axle-test-a/), version: 0.0.0
  Found link http://localhost:9161/test_bucket/repo/axle-test-a/axle-test-a-0.0.0.zip (from http://localhost:8868/simple/axle-test-a/), version: 0.0.0
  Found link http://localhost:9161/test_bucket/repo/axle-test-a/axle_test_a-0.0.0-py2.py3-none-any.whl (from http://localhost:8868/simple/axle-test-a/), version: 0.0.0
Given no hashes to check 3 links for project 'axle-test-a': discarding no candidates
Collecting axle_test_a
  Created temporary directory: /tmp/pip-unpack-ddgqgy1b
  Starting new HTTP connection (1): localhost:9161

The logs prefixed with <IP_ADDRESS> appear to come from moto_server, so I'm pretty confident pip is connecting to it appropriately, otherwise moto_server wouldn't have caught the "GET" request.

I think I've figured this out.  It appears that underscores are invalid in bucket names because AWS normally translates them into DNS names.  As a result, I think moto_server was converting "test_bucket" to "test.bocket".  I replaced "test_bucket" with "testbucket" and now the unit test is passing.
Thanks for your help!


Proposed revisions to spec text

Mostly minor text improvements, in addition to a rewrite of the Topdown section.

Here's the resulting PDF from these changes:
riscv-perf-events-latest.pdf


private key pulled from env expects a string

I'm not sure if this is a bug or if it is expected behavior.
If you set PRIVATE_KEY in your environment, it had better be the key itself instead of the path to the key file, or SSL will bonk:
(node:44369) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 3): Error: error:0906D06C:PEM routines:PEM_read_bio:no start line

This is the intended behavior, but I see how it's confusing. I'd be up for updating it to work with a path or the raw key material.

How about PRIVATE_KEY_PATH for the former... I'll send something over.


Update to Monolog v3

This PR updates Monolog to v3. Unfortunately I cannot run the test suite as various dev-dependencies conflicts (Livewire most notable).
Edit: I also had to drop support for PHP 8.0 and Laravel 8 & 9.

Thanks!


contrib: update github login

Signed-off-by: Leonardo Rossi<EMAIL_ADDRESS>

Coverage increased (+0.03%) to 76.73% when pulling ca1dde8811d7c60ec4ea569dc90a5b2794952ac9 on hachreak:fix_github into 869beb5626f83697f9180ab1c78e7bf0dbda399a on inveniosoftware:master.

ping @lnielsen

Coverage increased (+0.03%) to 76.73% when pulling 4645082f6f06fca2f856a256b8ee9950e8049bd3 on hachreak:fix_github into 869beb5626f83697f9180ab1c78e7bf0dbda399a on inveniosoftware:master.

Coverage increased (+0.03%) to 76.73% when pulling d6a6976563398d8a291ffa60f28bd1f6b343221b on hachreak:fix_github into 869beb5626f83697f9180ab1c78e7bf0dbda399a on inveniosoftware:master.

Coverage increased (+0.03%) to 76.73% when pulling 4645082f6f06fca2f856a256b8ee9950e8049bd3 on hachreak:fix_github into 869beb5626f83697f9180ab1c78e7bf0dbda399a on inveniosoftware:master.

Coverage increased (+0.03%) to 76.73% when pulling 7474b98d8b57b884bd3d1f88ce12c542071c5bbb on hachreak:fix_github into 869beb5626f83697f9180ab1c78e7bf0dbda399a on inveniosoftware:master.

Coverage increased (+2.7%) to 79.381% when pulling 44cf2e41c14d78ef88a444cc116593d802e65eae on hachreak:fix_github into 869beb5626f83697f9180ab1c78e7bf0dbda399a on inveniosoftware:master.

Coverage increased (+2.7%) to 79.381% when pulling 74a691a99492bb5cde06acf7c0471f8f5176025f on hachreak:fix_github into 869beb5626f83697f9180ab1c78e7bf0dbda399a on inveniosoftware:master.

Coverage increased (+2.6%) to 85.349% when pulling 72981a8dc1fc9fe32d94a5116e65ea8016d3d4c0 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Coverage increased (+2.6%) to 85.349% when pulling dcdeee0ef7b967100ae2c8ba90bca871db0d618d on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Coverage increased (+2.6%) to 85.349% when pulling e7891e322e3584446b1d2b4c07d5de73b32adf0c on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Coverage increased (+2.6%) to 85.349% when pulling 731b56b3a70f452061af684b384a5b0d199d7311 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Coverage increased (+2.6%) to 85.349% when pulling 731b56b3a70f452061af684b384a5b0d199d7311 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Another thing to test:

Create a local Invenio account with the same username as your github account, and different email.
Try to sign up using GitHub. This will create a conflict. Email doesn't exist in database, but username does.

Currently I don't think the sign-up form can handle this. I.e. we should probably provide the entire signup form instead of only an email address

Coverage increased (+3.06%) to 85.774% when pulling c550aa0005aed2263894f9774e7cf259429843ca on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Coverage increased (+3.06%) to 85.774% when pulling cae09f83d5df84c0d5d90d4fb4020e33783c4fbb on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Coverage increased (+3.06%) to 85.774% when pulling 7609a277d982766b71b3d6cdb61b3302d59a21f1 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Coverage increased (+2.6%) to 85.359% when pulling 001f04400cc62fa1c8b84f5e5e27342430ba2cc4 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Coverage increased (+2.6%) to 85.359% when pulling 001f04400cc62fa1c8b84f5e5e27342430ba2cc4 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Coverage increased (+2.6%) to 85.359% when pulling e2e75f8d95829f4a5cfa2a8ebca55004ab14d32e on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Coverage increased (+2.6%) to 85.359% when pulling d5548d8f86267557d50c51a4256ed06031d9cbea on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Coverage increased (+2.6%) to 85.359% when pulling 3c0c732686b59c2b937fb3acbff7c23954ba5e42 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Coverage increased (+2.6%) to 85.359% when pulling 94229888feb89f31609a85c5f095f189da0f0983 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Coverage increased (+2.6%) to 85.339% when pulling a846ecbcdc24bbf24328109ff9184645d1f3ba30 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Coverage increased (+2.6%) to 85.339% when pulling fcd8a1e09e68bafd09031571598cff065eb615b5 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Coverage increased (+2.6%) to 85.339% when pulling 6ea1ac84c37fade2c4a116619d5c45692c4fe12a on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

ping @lnielsen
(see the second commit for latest changes)

Coverage increased (+3.3%) to 86.043% when pulling 1b5a6b3adb00c0733d4abb13d96db5e06b739ffb on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Coverage increased (+3.3%) to 86.024% when pulling 4364fc9f0bafdb36b57a75e2f26269d205a26d12 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Coverage increased (+3.3%) to 86.024% when pulling 4364fc9f0bafdb36b57a75e2f26269d205a26d12 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Coverage increased (+3.3%) to 86.024% when pulling 2dc7cd0334d5e617cb34a97572f27f73d1da14f8 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Coverage increased (+3.3%) to 86.043% when pulling 4f3781e094bfb183a9fb7614331d4fda3bc0a9e9 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Coverage increased (+3.3%) to 86.043% when pulling 5a43bf0fcca101aff9f7cc0fa8ef78ee1de90393 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Coverage increased (+3.3%) to 86.043% when pulling 1d2a0ab183bf6ee9238726f7e376e81bdcb5832f on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

Coverage increased (+3.3%) to 86.043% when pulling 43ee9553129228eeed9981b96911bc69653924f0 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

@hachreak Can you take a look why the tests are not passing.

ok, I'll take a look

Coverage increased (+3.3%) to 85.986% when pulling 62b1ca6b0aee2314f642fb8161685d5b56f8c13a on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

ping @lnielsen


How to compile?

Running on React, I need an app.js file. Is there a video or tutorial on compiling this?

It's for React Native. You need either Xcode or Android.

I have android but need to know how to compile this and build the apk. Is there a tutorial or docs?

https://facebook.github.io/react-native/docs/getting-started.html
https://github.com/7kfpun/FinanceReactNative#running

symbol:   class ReactNativeHost
location: class MainApplication
C:\new_projects\FinanceApp\android\app\src\main\java\com\finance\MainApplication.java:32: error: method does not override or implement a method from a supertype
@Override
^
8 errors
:app:compileDebugJavaWithJavac FAILED

Maybe you could try building a new project react-native init AwesomeProject and run it first.
I think your issue has nothing to do with the project.


Configmaps params

Description
This PR adds missing parameters in configmaps while installing a driver.
This PR was created due to a defect that was raised where dell-csm-operator-controller-manager-* pod from the dell-csm-operator namespace reconciles and overwrites a configmap in the other namespace where I have my csm-isilon-controller- CSI drivers running issue.
In csm-operator,  customers cant add any new parameters into the configmaps. the operator will reconcile and overwrite the configmap everytime the customer edited the configmaps. The parameters that are added were provided in helm and were missing in csm-operator. There were discrepency in parameters provided in configmaps to customers while deploying through helm and csm-operator.
Hence added all the missing params and verified the installation.
GitHub Issues
List the GitHub issues impacted by this PR:

GitHub Issue #

https://github.com/dell/csm/issues/1193

Checklist:

[x] I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
[x] I have verified that new and existing unit tests pass locally with my changes
[x] I have not allowed coverage numbers to degenerate
[x] I have maintained at least 90% code coverage
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have maintained backward compatibility

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

with resileincy installed which enables podman:

with resiliency disabled:

can we add the fixed configmap to the n-1, n-2 versions as well? Have you been able to test the install of Unity, PowerFlex, and PowerScale?

I have added the fixed configmap to n-1, n-2 version as well
I was able to test it on powerscale and powerflex


[wil] new port

Fixes #6340 and https://github.com/microsoft/wil/issues/22

Could you change the version to 2019-02-08?  We are trying to move to the date rather than the sha for the control version on ports that don't have labeled releases.  See Abseil as an example.

Fair enough, I found no guidance on https://vcpkg.readthedocs.io/en/latest/maintainers/control-files/ so I just did what I thought made the most sense.

Thanks for pointing that out, I will make sure that documentation gets updated.  Also thanks for the PR!


MyQ updates, scan_interval, status retries

Description:

default SCAN_INTERVAL defined as 120 seconds not the standard 15 seconds
SCAN_INTERVAL (the default of 120 seconds) can be overridden in configuration.yaml with scan_interval on the component
Switch to 0.0.16 of the pymyq library which includes an endpoint change for get_status, its a more direct endpoint and the return is much smaller. Also retries 3 times for status update if server returns an error.
change init to check door status immediately and if fails fall back to None, better than waiting for the update to get the status after HA start/restart
Updates to close_cover and open_cover based on @ehendrix23 code with additional status check. Does two things, retries sending the open/close command if it initially fails the API call. Once API is successful it queries status until it gets an open or close status or fails. Provides a quicker update of confirmed open/close than waiting for update to occur.
Change to update to check for False from pymyq and return either current status or None.

Related issue (if applicable): fixes #17301 #16244 #16078 #9193(maybe)
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6873
Example entry for configuration.yaml (if applicable):
cover:
  - platform: myq
    username: !secret myq_username
    password: !secret myq_password
    type: chamberlain
    scan_interval: 300

Checklist:

[X] The code change is tested and works locally.
[X] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[X] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[X] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[X] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

@arraylabs I'm a MyQ owner and am well-versed in asyncio; happy to submit a PR to pymyq (or, if you'd rather do it, I'm at your disposal for help, questions, etc.). 👍

@arraylabs I've submitted a PR to turn your library to async: https://github.com/arraylabs/pymyq/pull/11 – I've also included suggestions for how to proceed with this PR. Let me know!

This PR seems to have gone stale. Closing it.