Paging seems broken in nosqlbench5

Describe the bug
Paging doesn't seem to work with cql and nosqlbench5, regardless of how high the maxpages
value is, I keep running into the same error.
To Reproduce
Steps to reproduce the behavior:
Spin up a cluster with the following benchmark yaml, trigger the schema,
rampup and eventually main-read.
description: |
  TODO

bindings:
  id: Shuffle(0,10); Template("{}-{}", Hash(), Hash());
  date: Shuffle(0,31); ToString();
  timestamp: AddHashRange(0L,2592000L); Mul(1000); StartingEpochMillis("2023-04-01 12:00:00"); ToJavaInstant();
  value: Shuffle(0,50); Template("value-{}-{}-{}", Hash(), Hash(), Hash());

blocks:
  schema:
    params:
      prepared: false
    ops:
      create-keyspace: |
        CREATE KEYSPACE IF NOT EXISTS TEMPLATE(keyspace, baselines)
        WITH replication = {'class': 'NetworkTopologyStrategy', 'ue1': 'TEMPLATE(rf,3)'}
        AND durable_writes = true;
      create-table : |
        CREATE TABLE IF NOT EXISTS TEMPLATE(keyspace,baselines).TEMPLATE(table,test) (
          id text,
          date text,
          timestamp timestamp,
          value text,
          PRIMARY KEY((id), date, timestamp)
        ) WITH CLUSTERING ORDER BY (date DESC, timestamp DESC)
        AND compaction = { 'class':'LeveledCompactionStrategy' }
        AND compression = { 'class': 'LZ4Compressor', 'chunk_length_in_kb': 4 };
  rampup:
    params:
      cl: TEMPLATE(write_cl,LOCAL_ONE)
      prepared: true
      page_size: 100
      maxpages: 100
    ops: |
      INSERT INTO TEMPLATE(keyspace,baselines).TEMPLATE(table,test) (id, date, timestamp, value)
      VALUES ({id}, {date}, {timestamp}, {value})
  main-read:
    params:
      cl: TEMPLATE(read_cl, LOCAL_ONE)
      prepared: true
    statements:
      select:
        op: |
          SELECT * FROM baselines.test
          WHERE id={id}
          ORDER BY date DESC, timestamp DESC

Schema: ./nb5 run workload=bench-small.yaml host={HOST} driver=cql localdc=ue1 tags=block:schema
Rampup: ./nb5 run workload=bench-small.yaml host={HOST} driver=cql localdc=ue1 cycles=10000 striderate=100 stride=100 tags=block:rampup threads=10
Read: ./nb5 run workload=bench-small.yaml host={HOST} driver=cql localdc=ue1 cycles=1 striderate=100 stride=100 tags=block:main-read threads=180
This runs into the following error, regardless of how high we bump maxpages:
Error in core motor loop:java.lang.RuntimeException: io.nosqlbench.adapter.cqld4.exceptions.UnexpectedPagingException: Additional paging would be required to read the results from this query fully, but the user has not explicitly indicated that paging was expected. fetched/allowed: 102/100 fetchSize(100): SELECT * FROM baselines.test

What was Expected
A clear and concise description of what you expected to happen.
The maximum page rows per partition should be ~1000, so we should be able to page through this
with the given maxpages and page_size.
Additional context
Add any other context about the problem here.
OS: Windows, Linux (distribution), macOS ...
environment: k8s, docker, ...
version info (./nb --version or java -jar nb.jar --version)
Screenshots, if applicable
If applicable, add screenshots to help explain your problem.

Hi @anderoo, thanks for reporting this issue.
Can you provide the specific version of nb5 as well as the trace output of your read command?  Also, any details of the environment you are running this scenario on.
For example, run your block:main-read with -vvv > trace.out included and capture the output of that run.
I was able to run your scenario locally without that error, and want to align what else may be the issue on your end.
Thank you!

@anderoo I was able to find the issue with this. I'll have a fix in before the next release is out.


Verifier to acknowledge & respond to transfer report before VC transfer complete

TODO
Verifier should respond to transfer report request before it identifies the VC transfer as complete.

This enhancement is released as part of 07-02-2023 release.
Tuvali version: v0.2.2
Tuvali PR: https://github.com/mosip/tuvali/pull/12
INJI PR: https://github.com/mosip/inji/pull/541


Add useFormState validation to all other forms

In #53 we only added validation using useFormState to the Add Provider form. We should put it in all the other forms we have so far (mappings, host network selection, plan wizard steps, ???)

Also, the validation criteria for the Add Provider form were pretty arbitrary and strict, we need to figure out the actual character limits etc to enforce there.

The form validation left to be done are:
[ ] SelectNetworkModal - Host Network
[ ] AddEditMappingModal - for Network and Storage mappings

Related note: the form state in the MappingForm (storage and network mapping steps of the plan wizard) is incomplete, but that will be finished as part of #103


documentation on github's organization organization

update README in JB repo to reflect new contents
include general name conventions
what goes in its own repo vs. JB book repo

Closed by https://github.com/hytest-org/.github/pull/1


Can't use converted 13/30/65b models

Hi,
I'm probably doing something dumb, but I used the "convert_hf_checkpoint.py" to convert all the HF models. After the conversions, I have model sizes of 27Gb, 52Gb, 130Gb and 260Gb.
I checked, and I used the following commands for the conversions:
 python scripts/convert_hf_checkpoint.py --hf_checkpoint_path /mnt/data/llama_hf_models/llama-13b-hf  --model_size 13B
 python scripts/convert_hf_checkpoint.py --hf_checkpoint_path /mnt/data/llama_hf_models/llama-30b-hf  --model_size 30B
 python scripts/convert_hf_checkpoint.py --hf_checkpoint_path /mnt/data/llama_hf_models/llama-65b-hf  --model_size 65B
 python scripts/convert_hf_checkpoint.py --hf_checkpoint_path /mnt/data/llama_hf_models/llama-30b-hf  --model_size 30B

The 7B model works flawlessly, and I was able to fine-tune and quantise the model. However, for all the other sizes, I get error like this when I attempt to use the model in any way:
	size mismatch for transformer.h.29.rms_2.scale: copying a param with shape torch.Size([5120]) from checkpoint, the shape in current model is torch.Size([4096]).
	size mismatch for transformer.h.30.rms_1.scale: copying a param with shape torch.Size([5120]) from checkpoint, the shape in current model is torch.Size([4096]).
	size mismatch for transformer.h.30.rms_2.scale: copying a param with shape torch.Size([5120]) from checkpoint, the shape in current model is torch.Size([4096]).
	size mismatch for transformer.h.31.rms_1.scale: copying a param with shape torch.Size([5120]) from checkpoint, the shape in current model is torch.Size([4096]).
	size mismatch for transformer.h.31.rms_2.scale: copying a param with shape torch.Size([5120]) from checkpoint, the shape in current model is torch.Size([4096]).
	size mismatch for transformer.ln_f.scale: copying a param with shape torch.Size([5120]) from checkpoint, the shape in current model is torch.Size([4096]).

It looks like some of the model parameters are read incorrectly, but I'm not sure why. Any help would be appreciated!

Thanks for reporting this @dnhkng, I'll check this in the next few hours

When is the error showing up? Conversion time or loading time after conversion?

The conversion seems to run OK. The 33 and 65Gb models use a lot of ram 2-300Gb, but I'm using a system the 8x V100 and 640 Gb ram 👍
The model sizes are the output from the conversion. When I try use them (inference, training or quantisation), the i get the error reported on size mismatch.

Ongoing work on #122
It should also greatly decrease memory use as well as allow you to generate bfloat16 weights without allocating the full model

@dnhkng #122 is ready
I tested it and it generates viable checkpoints.
To convert to bfloat16 (if you omit it will convert to float32):
python scripts/convert_hf_checkpoint.py --hf_checkpoint_path checkpoints/llama-hf/llama-13b-hf --lit_checkpoint lit-llama.pth --model_size 13B --dtype bfloat16

It's much faster than before and it uses less memory.
To generate:
python generate.py --dtype bfloat16 --prompt "Hello, my name is" --checkpoint_path foo.pth --model_size 13B

In your case I think the error arose because you didn't specify --model_size 13B when invoking generate.py

Testing it now, I'll report back after the 13B version

Great, thank you for letting me know @dnhkng

Sorry to reopen this, but I just found another (potential) issue:
but after reaching the model level:
0 mlp.c_fc2 collecting stats quantizing time 22s quantization error 351.9
I get an out-of-memory error.
OutOfMemoryError: CUDA out of memory. Tried to allocate 730.00 MiB (GPU 0; 31.75 GiB total capacity; 29.65 GiB already allocated; 82.69 MiB free; 30.68 GiB reserved in total by PyTorch)
If reserved memory is >> allocated memory try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF

Although I can in theory quantize 13B, in practice I can't even with 40Gb VRAM.  I can't even start on the 30B model, as I get OOM instantly.
I am using the command:
python quantize.py --model_size 30B --checkpoint_path checkpoints/lit-llama/30B/lit-llama-30b.pth --tokenizer_path checkpoints/lit-llama/tokenizer.model --output_path llama-30b-gptq.4bit.pt --dtype bfloat16  --quantize gptq.int4
This is after using the new push, so I think the models are already in BF16 (the 30B model is now only 65Gb).


Space in Display Name

Currently if there is a space in the display name it will show a \s. I'm thinking that is a bug.
http://puu.sh/jn1o0/e9a1dc507f.png
I also have no idea how the user has a space at the end of his name but....
https://api.twitch.tv/kraken/users/tuff_elite
He does.
Keep up the good work.

Not sure how that is possible, someone must have missed the trimming code on twitches side.
Very interesting.


From Jessie to Stretch in README

Update installation with download of Raspbian Stretch Lite instead of Jessie.

Thanks for the updated text!


East Docker 2 has full disk

The disk is currently full, should increase the size or migrate instances
ACs

[ ] Determine which instances need restart or deletion

Resolved per Chris


Can't reset resources to unlimited for a container

Bug description
Can't reset resources to unlimited for a container
Expected behavior
Setting to unlimited will persist across container restarts
Steps to reproduce the issue:
Steps to reproduce the behavior:

Stop container
Click on Duplicate/edit
Scroll down to Runtime and resources
Drag slider to unlimited, and click Deploy
Slider resets to previous value. NOTE selecting a non-unlimited value works as expected

Technical details:

Portainer version: 1.20.1
Docker version (managed by Portainer):
Platform (windows/linux): Ubuntu 18.04
Browser: Chrome Version 71.0.3578.98

Reproduced on 1.23.2

Reproduced on the development branch. Closing as this will be addressed via #3964 in v2.0


Compile node_modules for Jest

Fixes #5107
Todo

[x] Tweak eject behavior

I'm not entirely sure we want to do this. import() and ES Modules should not be present in the main entry point of a published package (not until NodeJS supports them without a feature flag and in a LTS release).
These features would only normally be on in the module or browser entry points.
/cc @gaearon

My opinion is: if some feature doesn’t work on latest Node without flags, it shouldn’t be supported in node_modules. Violating this principle will lead to all sorts of inconsistencies and problems later. Let’s not jump ahead of the train.

@gaearon Could you please cherry-pick only this commit to keep consistent with the normal config?
https://github.com/facebook/create-react-app/pull/5121/commits/3c4b1445b500c1ed67185ba19411dab1625e5af1

Send a new PR? Sorry I’m on a phone right now

Ok here it is: https://github.com/facebook/create-react-app/pull/5125

@Timer @gaearon I have a new problem now.
If I want to write some tests for my component which imported some file like package/path/to/file, and that file may contain es module code, what should I do for the best practice? (as an author of packages or apps)

There are no such things like .module.js for files other than the entry file of a package. We have no good way to apply both tree-shaking (require es modules) and node-compatible (without es modules) to a file before mjs landed.


Contents loading

add Next.js Image blur effect
add Load Animation with @emotion/styled

 Transition on contents


No caption block in embedded Instagram

The caption block does not appear in the embedded instagram.
I'm using 2.5.9 version of the package.
In the official documentation not work either

Is there a necessary step for it to appear that I have skipped?

Hey @oliverfg we solved it by adding a prop "captioned" to the component:
<InstagramEmbed url={url} captioned />

Re-added official support for this.
Live example here:
https://justinmahar.github.io/react-social-media-embed/?path=/story/embeds-instagramembed--main-example-with-captions


Fix clippy warnings, fix #511

Fix #511
This simplify the code a little and avoid formatting string in expect blocks.

Probably because that defers actually calling the format function (or any function for that matter).


Provide experimental support for elevating Windows privileges when running Composer update

Elevation prompt works, but not the install...
Checking for updates... A new version is available (v0.7.14)
Updating to the latest version...
Updating the application...
Updating via Composer...

 The application path may require elevated privileges to update. Do you want to provide administrator permissions, or try updating without? (yes/no) [yes]:
 >

 > Changed current directory to C:/Users/Caen/AppData/Roaming/Composer
 > ./composer.json has been updated
 > Running composer update hyde/cli
 > Loading composer repositories with package information
 > Updating dependencies
 > Lock file operations: 0 installs, 1 update, 0 removals
 > - Upgrading hyde/cli (v0.7.13 => v0.7.14)
 > Writing lock file
 > Installing dependencies from lock file (including require-dev)
 > Package operations: 0 installs, 1 update, 0 removals
 > - Downloading hyde/cli (v0.7.14)
 > - Upgrading hyde/cli (v0.7.13 => v0.7.14): Extracting archive
 > Update of hyde/cli failed
 >
 > In BinaryInstaller.php line 176:
 >
 > file_put_contents(C:\Users\Caen\AppData\Roaming\Composer\vendor\bin/hyde): Failed to open stream: Permission denied
 > require [--dev] [--dry-run] [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--fixed] [--no-suggest] [--no-progress] [--no-update] [--no-install] [--no-audit] [--audit-format AUDIT-FORMAT] [--update-no-dev] [-w|--update-with-dependencies] [-W|--update-with-all-dependencies] [--with-dependencies] [--with-all-dependencies] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [-m|--minimal-changes] [--sort-packages] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--] [<packages>...]
The application has been updated successfully.
'hyde' is not recognized as an internal or external command,
operable program or batch file.


vre back in

As promised in https://github.com/populationgenomics/saige-tenk10k/pull/179, adding code around making the VRE plink files back in.
VCF + index files making only running:

chr21: https://batch.hail.populationgenomics.org.au/batches/493682/jobs/1 🎉
chr1-20 + chr22: https://batch.hail.populationgenomics.org.au/batches/493685/jobs/1

Note: for chr21, VCF files had already been generated (in https://batch.hail.populationgenomics.org.au/batches/493678/jobs/1), here we only added index files because the run didn't fail at the VRE stage any longer
All files are being generated at: cpg-bioheart-main/saige-qtl/bioheart_n787_and_tob_n960/241008_ashg/input_files/genotypes/vds-tenk10k1-0_qc_pass

All good, but next time you can just revert your previous commit instead of manually undoing it all :)

there was a minor typo (it was saying **CV** VCF rename/index jobs scheduled! every time it was running this, even for the RV VCF) that was annoying me, so this is reverting everything back but that tiny change 😅


ignore tags_all attribute

Description

As discussed on https://github.com/cloudskiff/driftctl/issues/635
Example

wen from (0.10.0-pre)
Found changed resources:
    - vol-0e022e1567c9cec58 (aws_ebs_volume):
        + tags_all: <nil> => {
  Terraform: "true",
  Name: "aws-www-1-root"
} (computed)

to (0.10.0-pre build 797f527-dev)
# nothing

LGTM!!


chore: add enterprise 2.1 2.2 and 2.3 to test suite

So I spend a bit of time to setup CI for new enterprise versions and it seems we have some breakage in the API from Kong.
ping @rainest

2.1 and onward use a new workspace implementation, which doesn't provide entity sharing at all:
https://github.com/Kong/kong-ee/pull/1794
https://github.com/Kong/kong-ee/commit/58c1c13d447ad48e83ec44826642e21557f2ee2e
The /workspaces/WS_ID/entities/* endpoints no longer exist and have no replacement, so this test should not run on 2.1+ at all: fdc494a

Not sure what's up with the oauth2 failure on <IP_ADDRESS>. That "all or none of these fields" message should come up only if the token DAO has a mutually_required rule, but it doesn't. Per https://github.com/Kong/kong-ee/commit/946568c7892d392e67a8bd185bfe17f18fd942c1 that field should be optional, and the longer history doesn't show any changes for that code since that'd have changed how it's validated.

@rainest Thanks for digging into this.
Could you get some help from internal teams to figure out the cause for the Oauth test breakage. That seems like a breaking change and it is potentially already impacting KIC.
ping @tjrivera. Did you use Workspace entities endpoint anywhere by any chance?

Oauth test looks like it's something that you'd already run into previously: https://github.com/Kong/kong/issues/6173
The core bug remains open and likely won't be fixed any time soon.
I mistakenly thought this was something Enterprise-only and didn't look through the core history because that's sort of what tests reported, but it's actually because Enterprise release tags look like semver pre-release tags, even though that's not how we're using them in practice.
As far as the semver range function is concerned, <IP_ADDRESS>-enterprise < 2.1.0, because pre-releases are less than final releases. As such, it passes the gate, whereas a 2.2.x.y-enterprise "pre-release" does not.
https://github.com/blang/semver/issues?q=is%3Aissue+pre shows others raising this question, but there doesn't appear to be any way around it/any way to ignore the pre-release during comparison. We'd need to chop off the Enterprise bits in runWhenKong() before comparing to avoid that problem completely. A less perfect approach is to change the version we compare against here:
diff --git a/kong/oauth2_auth_service_test.go b/kong/oauth2_auth_service_test.go
index 3326215..8c3404e 100644
--- a/kong/oauth2_auth_service_test.go
+++ b/kong/oauth2_auth_service_test.go
@@ -138,7 +138,7 @@ func TestOauth2CredentialGet(T *testing.T) {
 }

 func TestOauth2CredentialUpdate(T *testing.T) {
-       runWhenKong(T, "<2.1.0")
+       runWhenKong(T, "<=2.0.5")
        assert := assert.New(T)

        client, err := NewTestClient(nil, nil)

ping @tjrivera. Did you use Workspace entities endpoint anywhere by any chance?

We did use the workspace entities endpoint to migrate a service and its associated routes, plugins, etc. from one workspace to another. We plan on dropping this as we move to Kong 2.x since we understand the workspace membership constructs have changed a bit in the new version.


added react state management tools like redux and recoil

First Change
Changes proposed
Add State management tool in react js section
##ScreenShot

Second Change
Changes proposed
Added Rust language
##ScreenShot

Hey @surajmaurya0 can you please reference the the respective issue and also resolve merge conflicts

resolve merge conflicts

Added two card in React js section
react-redux
recoil
both are help for state management in react
Added One New language in language section
Rust
Rust is used for  performance, safety, and memory management

@surajmaurya0 please add closes #issue number so that issue linked to it closes automatically


Stackoverflow with execute() function

I've narrowed the problem to this case:
<cfscript>   for (a=1;a lte b;a=a+1)   {     if (comparenocase(c, d) is 0)     {       e.f=g;       execute(h = i,               l = m);     }   }   </cfscript>
The error is
Exception in thread "main" java.lang.StackOverflowError
at cfml.parsing.cfscript.script.CFExpressionStatement.Decompile(CFExpressionStatement.java:17)
at cfml.parsing.cfscript.script.CFCompoundStatement.Decompile(CFCompoundStatement.java:54)
...
...
This version of the test
<cfscript>   for (a=1;a lte b;a=a+1)   {     if (comparenocase(c, d) is 0)     {       e.f=g;       fooexecute(h = i,               l = m);     }   }   </cfscript>
runs just fine.

Actually, works with dev branch, probably just an already solved bug of cfml.parsing


python3Packages.dulwich: 0.20.20 -> 0.20.21

Motivation for this change
Update to latest upstream release 0.20.21
Change log: https://github.com/dulwich/dulwich/blob/master/NEWS
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 117834 run on x86_64-linux 1

21 packages built:

breezy (python38Packages.breezy)
cabal2nix
dep2nix
devpi-client
errbot
flatpak-builder
hydra-unstable
klaus (python38Packages.klaus)
nix-prefetch-bzr
nix-prefetch-scripts
nix-update-source
python38Packages.check-manifest
python38Packages.dulwich
python39Packages.breezy
python39Packages.check-manifest
python39Packages.dulwich
python39Packages.klaus
rabbitvcs
reno
vcstool
xandikos

Result of nixpkgs-review pr 117834 at eaff5544 run on aarch64-linux 1

1 package skipped due to time constraints:

cabal2nix

20 packages built successfully:

breezy (python38Packages.breezy)
dep2nix
devpi-client
errbot
flatpak-builder
hydra-unstable
klaus (python38Packages.klaus)
nix-prefetch-bzr
nix-prefetch-scripts
nix-update-source
python38Packages.check-manifest
python38Packages.dulwich
python39Packages.breezy
python39Packages.check-manifest
python39Packages.dulwich
python39Packages.klaus
rabbitvcs
reno
vcstool
xandikos

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 117834 run on x86_64-linux 1

21 packages built:

breezy (python38Packages.breezy)
cabal2nix
dep2nix
devpi-client
errbot
flatpak-builder
hydra-unstable
klaus (python38Packages.klaus)
nix-prefetch-bzr
nix-prefetch-scripts
nix-update-source
python38Packages.check-manifest
python38Packages.dulwich
python39Packages.breezy
python39Packages.check-manifest
python39Packages.dulwich
python39Packages.klaus
rabbitvcs
reno
vcstool
xandikos


Why are there 2 different caffemodel files?

I found two links in your readme which lead to 2 different caffemodel files. What's the difference between these 2 files?

hi, @firefox1031 I can't download the caffemodel file and the prototxt file from googledrive .If it is convenient, could you share your download files, thanks very much !
my email is<EMAIL_ADDRESS>thanks again.

hi, @firefox1031 I can't download the caffemodel file and the prototxt file from googledrive .If it is convenient, could you share your download files, thanks very much !
my email is<EMAIL_ADDRESS>thanks again

The deploy caffemodel merged batch normal for acceleration.


Add a 5 minute delay to feedback prompt

To avoid too many notifications from the Python extension on load, we can add a 5 minute delay to display the notification asking for users feedback.
This is to avoid situations like the one below:

We don't think that this will work to address the core problem.

@greazer would you be able to clarify why is that? I created this issue after talking to @ronglums.

@claudiaregio is aware too :) @greazer, I agree it doesn't address the core problem, but as the core problem is being worked on in parallel, this is a reasonable workaround for a nicer (less annoying) experience.

@ronglums, let's talk about this.

I don't trust that our notebook survey prompt is being displayed at appropriate times. Either our criteria wrong, too easy to hit, or suffering from a bug that is causing it to display way too early. I'd like to revisit the entirety of the mechanics from the ground up. If we have to change it completely, so be it.
There are a couple of non-debatable requirements and one mildly debatable one:

We don't prompt somebody who has already ever been prompted in the past. I think we have a memento set already that can allow us to make this a reality. If we can do this based on user rather than machine, that is best.
We don't ever prompt on simply opening an ipynb file regardless of whether any criteria metrics have been met in prior sessions or not.
Debatable: Our criteria should be based on actual serious use of the notebook features. I don't think it's worthwhile to query somebody who has only mildly tried it. 100 cell runs is not serious use, imo. I don't think that somebody who has spent a lot of time with our notebook support will be willing to spend any time filling out a survey. Even if they are, I'm confident the reasons that they are leaving so early can be gleaned via other means than a survey.

So, if possible, I would propose that our current criteria is greatly increased and/or replaced with or combined with a "total time user has had a notebook file opened in one or more sessions of VS Code". That time should be on the order of at least an hour. We need to be sure that at least some notebook operations are being performed during this time too.
Then when we do prompt it shouldn't be before at least 20 minutes have elapsed after the user performed at least 10 cell runs in and one cell edit their current session.

Based on our call:
For Native Notebooks (whether in Stable or Insiders)

Prompt using same criteria.
If user hits Yes, do not show prompt for 6 months.
If user hits No, do not show prompt for 3 months.
If user clicks x, treat it same as no. Do not show prompt for 3 months.

For Webview

Prompt using this new criteria: 1. They opened 15 notebooks. 2. They ran at least 250 cells.
If user hits Yes, do not show prompt for 1 year.
If user hits No, do not show prompt for 6 months.
If user clicks x, treat it same as no. Do not show prompt for 6 months.


WaitForFrame times out on RPi (with LifeCam and RPi internal camera)

On RPi3 with Ubuntu/arm64 with a Microsoft Studio webcam always times out on cam.WaitForFrame(..) call when using YUYV 4:2:2 and 1920x1080 while 640x480 works just fine. However MJPEG works fine at 1920x1080. No other errors just a timeout. Potential there is a buffer issue somewhere since the amount of data with YUY will be much higher?
However MJPEG also fails. A different RPi with Raspbian and an internal RPi Cam getting the following trace:
DeviceConfig: /dev/video0, Motion-JPEG,
Available formats:
Planar YVU 4:2:0, 32-bit BGRA/X 8-8-8-8, H.264, UYVY 4:2:2, Y/CbCr 4:2:0, VYUY 4:2:2, YUYV 4:2:2, 24-bit RGB 8-8-8, JFIF JPEG, Motion-JPEG, YVYU 4:2:2, Y/CrCb 4:2:0, Planar YUV 4:2:0, 24-bit BGR 8-8-8,
Supported frame sizes for format: Motion-JPEG
[32-3280;2]x[32-2464;2],
Request: Motion-JPEG [32-3280;2]x[32-2464;2]
Result: Motion-JPEG 3280x2464
Wait frame..
Webcam wait frame, retrying:  Timeout occured
Wait frame..
Webcam wait frame, retrying:  Timeout occured
Wait frame..
The timeout is at 10sec but I have tried minutes and it never yields data same when trying YUYV Is this normal? What could the issue be?
Also a Logitech Brio has the same issue, timeout on WaitForFrame.

rmmod bcm2835-v4l2
modprobe bcm2835-v4l2
Destroys and re-creates /dev/video0
pi zero W. CSI  is OK

With my raspicam i get always streaming:operation not permitted - any ideas? (also with sudo). If i attach a usb webcam everything works fine.

I have the same problem as @tobearlabs - Pi Zero WH, Pi ZeroCam..

Fixed it! This happens because the Zero is to slow to handle high-resolution video streams. Using 	f, w, h, err := cam.SetImageFormat(format, uint32(size.MinWidth), uint32(size.MaxWidth)) instead of 	f, w, h, err := cam.SetImageFormat(format, uint32(size.MaxWidth), uint32(size.MaxHeight)) for example https://github.com/blackjack/webcam/blob/master/examples/stdout_streamer/stdout_streamer.go works.


Automatic Sorting of Notes by Date

Hi,
I am using the Single File Daily Notes plugin and I am experiencing an issue with the sorting of notes by date. When notes are added out of chronological order, the plugin does not automatically sort them. This results in a disorganized list of notes, as shown in the attached screenshot.
Feature Request:
Implement a feature that ensures notes are automatically sorted by date whenever a new note is added or an existing note is modified.

how do you get the name of the day in your language?

how do you get the name of the day in your language?

The names of the days are below.

English
Turkish

Monday
Pazartesi

Tuesday
Salı

Wednesday
Çarşamba

Thursday
Perşembe

Friday
Cuma

Saturday
Cumartesi

yeah but how do you get it to show in that language and not english?

yeah but how do you get it to show in that language and not english?

I understand now. The screenshot I shared is not suitable for sorting by name. DD-MM-YYYY would not be suitable. Actually the name is not important, if possible the file name or alternatively an extra date yaml value can be used to sort.

@alitekdemir I would recommend using the built-in calendar view to insert new notes out of order. It should automatically parse your file and insert the note in the right place for any date (past or future). Using this method, you should never have any out-of-order dates.
It would be quite expensive to check the entire file for out-of-order dates on every edit, as doing this would require parsing and (potentially) rewriting the entire file everytime.

@jcesguerram this plugin uses Obsidian's built-in moment.js library. It will determine the display language used in Obsidian and display the dates in that language. Here alitekdemir must have set his language to Turkish, which is why they see the day names in Turkish.
You can change it for your vault by changing the language by going to Settings -> General -> Language.


tmstore: add LinkHash to tendermint Tx

It can be useful for Block Explorers

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Add Integtest.sh for OpenSearch integtest setups

Signed-off-by: Peter Zhu<EMAIL_ADDRESS>Description
Add Integtest.sh for OpenSearch integtest setups
This is a file that can be used as an abstraction for integTests to run.
This is better than what ODFE has in which all plugins runs saved in a single yml.
Issues Resolved
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Please do not merge this PR after approval, I will merged once all the PRs are up.

@Bukhtawar we are currently working on the security enabled Integ tests. Is this PR blocked on that effort?

@eirsep It does not block just approve the PR it works for both security enable/disable tests.


DNS resolution fails in restrictive LANs; --dns is useless after container creation

My institute LAN blocks all outgoing UDP and only select TCP traffic; only the internal DNS server is expected to be used. The internal DNS server's IP is served via DHCP, so all normal systems work normally.
But when docker decides to use <IP_ADDRESS> inside a container, that container now cannot use DNS.
One would say I could simply use the --dns option when creating a container. But that works only when creating a container.
I work from multiple locations, only one of them being the institute with the restrictive-LAN mentioned above. When I create a container with docker run --dns inside, stop the container, go out to another network, I cannot start the container with a different --dns again. I either have to create a new container, or manually edit /etc/resolv.conf.
My proposed solutions:

Add an option to docker to proxy DNS by listening on the bridge IP. This has the advantage of being seamless. One does not have to manually switch dns entries when switching networks. The proxy should detect and handle changes in host's /etc/resolv.conf, of course; and/or
Bring the --dns option to docker start

I have the former working, in a private branch. I'm bringing this up partly so the design can be discussed with the core team.

hmm, missing support of a --dns flag for docker start could be considered a bug.
@LK4D4 @jfrazelle how do you think about this?

Well 1 thing that is cool on the master branch (and that will be in the release) is when you edit the resolv.conf on your host it automatically refreshes the one in the container, so i think that would be helpful here.

here is some more information on that as well https://github.com/docker/docker/pull/9648

^ & ^^: That still does not address restrictive LANs.

^Especially when the host has an entry like <IP_ADDRESS> (e.g., for local caching of DNS)

we could add the flag on start then

#dibs

Wouldn't setting this at the daemon level (which is available today) resolve this?

Not sure, if I read this part;

When I create a container with docker run --dns inside, stop the container, go out to another network, I cannot start the container with a different --dns again. I either have to create a new container, or manually edit /etc/resolv.conf.

But you can always restart the daemon with a new dns server.

Also true. Not sure if restarting all containers is desirable in all cases of course.

We already support this flag in docker run and docker create. Setting that flag must happen at the create stage. Closing this as fixed:
docker git:(master) docker run --help | grep dns
--dns=[]                        Set custom DNS servers
--dns-opt=[]                    Set DNS options
--dns-search=[]                 Set custom DNS search domains


Mega menu: update links to new Consumer Tools portal pages

Update two Consumer Tools menu links to go to newly created portal pages
Changes

Link locations

Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the development playbook
[ ] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated
[ ] Reviewers requested with the Assignee tool :arrow_right:

Merging after CEIA team verification of new link locations


Update README.md with added documentation

Enhance README with comprehensive project documentation

Add detailed project description and feature list
Include installation and usage instructions
Document main properties of the GPUTrail3D node
Provide a basic usage example
Add sections for contributing, license, and acknowledgements
Incorporate TODO list for future development plans

Awesome. Thanks!


lumbridge & draynor elite diary should be filtered by all quest requirements

currently, the lumbridge & draynor elite diary is not filtered by skills such as defense, despite those skills being required for the quest cape, and subsequently the diary itself

The method to check all quests here isn't a "quest requirement" in the same way it can be seen here. Meaning it won't enter the stream here  as a quest requirement.
I don't see a good fix for this, cause adding all the quests as a requirement to the diary isn't ideal - and adding logic for specific quests to the skill filtering config is also not ideal.

https://github.com/Zoinkwiz/quest-helper/commit/d46bb21735b62148b5ba3d7cdf25f5b2279ffe7f should make this check its own implementation of a Requirement, which means we can potentially handle a version of this base new requirement to be considered for pass checks. Not fixed yet, but worth considering when this is looked at for fixing.


Add files via upload

We could now load our already pretrained model to make inference and prediction. This is an example of Mnist dataset that I trained on my Colab and converted that model to .bin and model.json which contains the weights and architecture of our model. This is an example of how we could any model by converting into .json file and uploading its .bin file.

Don't sent pull requests from master branch.
Read and Follow
https://stackoverflow.com/questions/14680711/how-to-do-a-github-pull-request


Adding spectre-ai.org (impersonating spectre.ai)

https://urlscan.io/result/314a4c9b-36b5-47fc-b065-cc11e7158271#summary

https://urlscan.io/result/857d354c-491f-4357-8ab4-deaa4393d685#summary
Domain Name: SPECTRE-AI.ORG
Registry Domain ID: D402200000004073292-LROR
Registrar WHOIS Server: whois.reg.com
Registrar URL: http://www.reg.com
Updated Date: 2017-11-14T10:06:50Z
Creation Date: 2017-10-31T07:31:27Z
Registry Expiry Date: 2018-10-31T07:31:27Z
Registrar Registration Expiration Date:
Registrar: Registrar of Domain Names REG.RU LLC
Registrar IANA ID: 1606
Registrar Abuse Contact Email<EMAIL_ADDRESS>Registrar Abuse Contact Phone: +7.4955801111
Reseller:
Domain Status: clientTransferProhibited https://icann.org/epp#clientTransferProhibited
Domain Status: serverTransferProhibited https://icann.org/epp#serverTransferProhibited
Registry Registrant ID: C198640441-LROR
Registrant Name: Protection of Private Person
Registrant Organization: Privacy Protection
Registrant Street: PO box 87, REG.RU Protection Service
Registrant City: Moscow
Registrant State/Province:
Registrant Postal Code: 123007
Registrant Country: RU
Registrant Phone: +7.4955801111
Registrant Phone Ext:
Registrant Fax: +7.4955801111
Registrant Fax Ext:
Registrant Email<EMAIL_ADDRESS>Registry Admin ID: C198640442-LROR
Admin Name: Protection of Private Person
Admin Organization: Privacy Protection
Admin Street: PO box 87, REG.RU Protection Service
Admin City: Moscow
Admin State/Province:
Admin Postal Code: 123007
Admin Country: RU
Admin Phone: +7.4955801111
Admin Phone Ext:
Admin Fax: +7.4955801111
Admin Fax Ext:
Admin Email<EMAIL_ADDRESS>Registry Tech ID: C198640444-LROR
Tech Name: Protection of Private Person
Tech Organization: Privacy Protection
Tech Street: PO box 87, REG.RU Protection Service
Tech City: Moscow
Tech State/Province:
Tech Postal Code: 123007
Tech Country: RU
Tech Phone: +7.4955801111
Tech Phone Ext:
Tech Fax: +7.4955801111
Tech Fax Ext:
Tech Email<EMAIL_ADDRESS>Name Server: NS1.HOST01.NET.IN
Name Server: NS2.HOST01.NET.IN
DNSSEC: unsigned
URL of the ICANN Whois Inaccuracy Complaint Form: https://www.icann.org/wicf/

Last update of WHOIS database: 2017-11-14T22:30:38Z

For more information on Whois status codes, please visit https://icann.org/epp
Access to Public Interest Registry WHOIS information is provided to assist persons in determining the contents of a domain name registration record in the Public Interest Registry registry database. The data in this record is provided by Public Interest Registry for informational purposes only, and Public Interest Registry does not guarantee its accuracy. This service is intended only for query-based access. You agree that you will use this data only for lawful purposes and that, under no circumstances will you use this data to: (a) allow, enable, or otherwise support the transmission by e-mail, telephone, or facsimile of mass unsolicited, commercial advertising or solicitations to entities other than the data recipient's own existing customers; or (b) enable high volume, automated, electronic processes that send queries or data to the systems of Registry Operator, a Registrar, or Afilias except as reasonably necessary to register domain names or modify existing registrations. All rights reserved. Public Interest Registry reserves the right to modify these terms at any time. By submitting this query, you agree to abide by this policy.


networks screen refresh after network prune command

Network prune command is not generting system events, therefore the tui will not refresh the screen after prune command.
Refreshing networks screen after network prune.
Signed-off-by: Navid Yaghoobi<EMAIL_ADDRESS>

LGTM
Should the networkprunecommand generate system events?

Hi @rhatdan
I might be totally wrong but I was thinking maybe system events will include all operation's event that are executed via podman.


Feature Request: Getting metadata via DOI

When the web page is a research document, is it possible to obtain and add the year of publication, journal name, impact factor, journal division, etc. via DOI in Front matter

或者有没有什么方法可以实现和Zotero条目的关联

This would also be an amazing feature for the Logseq plugin!

+1 this would be a great feature, not only as a researcher, but as an alternative to Zotero.


Not showing all shared servers

Hi, for me It only shows one local and one of the 2 shared servers that I have in my shared list.

Same.  Not seeing any servers that were added recently even after refreshing token.

Closing.
Others have made some better apps than what I did here.
Could try using one of theirs. I have not used this one, but it looks good:
PlexRipper


Use constants instead of magic numbers

Description
The code for the drawer setup uses magic numbers to determine behaviour (may also apply somewhere else)
What are the steps to reproduce this issue?

Open the class MainActivity
Look at the method setUpDrawers()
Try to follow the setup of the drawers and/or the switch case statement which handles the logic

What happens?
You will get dizzy scrolling up and down to see which number corresponds to which item.
new PrimaryDrawerItem().withIdentifier(1) (what is 1?)
What were you expecting to happen?
You should be able to read the code like a book without the need to scroll back.
new PrimaryDrawerItem().withIdentifier(ID_PRIMARY_COLOR)
What versions of software are you using?
App version: 0.1

In the method MainActivity.onItemClick there are several cases that are handled by the right drawer. See case 21 to case 26.  I guess they weren't removed when the logic was moved from the left to the right drawer. Should I remove them while cleaning this up or do you want this in an extra issue/commit?

@Viciouss nice catch

@naushad-madakiya please write an explanation before closing a PR


Draft: Update docs for new page URL features

The new features for page URLs are to be released in Mendix 10.0.0 Beta 2. Related to [UFC-696].

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Wim Jongeneel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello. I talked with Jonathan Diehl today about upcoming improvements to Page URLs and Deeplinking. I see this PR is slated for Beta 2.
How big of a portion of the Page URL updates does this PR capture? Will there be bigger Page URL PRs/updates for GA?

Hi @ConnorLand it's likely there will be more changes for Page URLs and other related features for the docs for GA. We want to get these docs out there, as we want people to start playing around with the feature in beta 2.


Bug Fix missing HTTP2 ALPN for UpstreamTLSContext

For HTTP2 cluster, ALPNH2Only was not being set in SIMPLE mode. Added more unit tests to cover this as well as SNI
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[x] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@nschhina: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
1d99d9bab5a14e54f20ce5cb4102f9cd7d085741
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nschhina: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
1d99d9bab5a14e54f20ce5cb4102f9cd7d085741
link
/test lint_istio

gencheck_istio
1d99d9bab5a14e54f20ce5cb4102f9cd7d085741
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Is there an associated issue?

Is there an associated issue?

No, this caught my attention when I was writing unit tests

I think this looks right to me, @lambdai can you verify? We already have the same code for MUTUAL so should be the same for simple?

@howardjohn this was removed during refactoring by mistake, there was no test coverage for it. It's already there in 1.6. I'm going to move all tls context generation to a separate function and create a unit test for that particular functiion to handle all cases.

we should merge this as soon as possible

@nschhina: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
7403b4e952813c0232d178c4660a893580cb827b
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


the script again does not work

if Dan Pollock's hosts file is turn on in ublock addon
Firefox 51, greasemonkey,
i dont know witch exception i must add to list
i dont want to turn off whole Dan Pollock's list :/

Hmm. I cannot reproduce. It's working for for me on Firefox 51.

2017-02-25 23:30 GMT+01:00 Evgueni Naverniouk<EMAIL_ADDRESS>
Hmm. I cannot reproduce. It's working for for me on Firefox 51.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/EvNaverniouk/youtube-hide-watched/issues/7#issuecomment-282517287,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQKvGJBbqdXAhjUXiQX5Er-gQqoYC_cTks5rgKtugaJpZM4MLaIh
.


Issues that need to be resolved before preview release this week

The issue tracker has a list of 13 issues that are tagged with the 1.0 label:
https://github.com/openpathsampling/openpathsampling/milestone/1
There are also two issues tagged with the ASAP label:
https://github.com/openpathsampling/openpathsampling/milestone/3
Do all of these need to be addressed before we get out our preview release this week?

Do all of these need to be addressed before we get out our preview release this week?

ASAP issues: Yes. Note that one is under review (I gave it the first round, and it needs some responses from @jhprinz) and the other is probably fixed, but we need to confirm that the bug is actually gone.
1.0 issues: Not all of them. For example, the reorganization of various directories and miscellaneous renamings of variables should be done before the official release, but we can release a beta without that. Also, 3 issues from that will be closed by #517 (under review, ASAP milestone), and (at least) another 2 will be closed by #500 (under review, no milestone). A couple others are related to SRTIS, which we've said doesn't need to be in the beta. Others are things like "cool logo" and "docstring cleanup": good things to put on the final polish, but not required for a working beta.
Note that using the beta could be frustrating since the API might have some name changes. I'll open an issue today with some of the renamings that I think we should consider.

Can we call it an alpha and create a 1.0alpha milestone to flag the issues that we need to address this week?

Sure, although it might be easier to just list the main PRs here. I think that we can call it alpha after:

#517
#500
#386

Several of these resolve multiple issues; adding all the issues that they resolve to a 1.0alpha milestone would probably be more confusing, if you're looking at it to see how much work is left.
I gave the first two an initial round of review yesterday. Next step will get done when @jhprinz has time outside his teaching responsibilities this week and responds to the review. Once #517 is merged, I'll fix any incompatibilities in #386, and JHP will review that (as a partially complete PR, just to get the changes to file format included).
Does anyone else see other things as required for an alpha?

@jhprinz is back at 3.00P today, I think, so I'll work with him to see what needs to be done.

@dwhswenson and @jhprinz: Can you give us an update on how far along you are with closing up the three open PRs above so we can cut an alpha?

From my side:

#517, this is done and I made changes according to Davids questions. This is a VERY big PR so it might need some more time to check that it works as expected, but otherwise it passes tests and is feature complete
#500, this one is done and checked by David. There are more associated things we should fix but only for 2.0. This is ready to be merged and I think David is practically done with it.
#386, needs the other two to be merge first and then we need to apply fixed to merge. I am currently looking at it and I think this is also ready to be merged.

Summary: The PRs are done. Still finishing review and one needs to be fixed when the others are merged.

Yep. This morning, all three of these were on JHP's side of the court. Now all three are on mine. I'm about to look over #500; unless there's a surprise, it will be merged tonight. As I mentioned in a comment to #517, because of its size, I'm not going to review the whole thing in detail, but instead trust that it does what JHP says. I'll give it a brief once-over, but will probably merge it either tonight or tomorrow (I think JHP addressed everything from my first round of review). That leaves #386, which I'll need to update to match the recent changes. I probably won't finish that until tomorrow.
I'm also preparing a PR that will have significant effects on some user-facing stuff (this is the treatment of the MS-outer interface that JHP and I discussed in Berlin). I'm hoping that will be ready for review tomorrow night, Wednesday at the latest. This wasn't part of the original 1.0-alpha, but if we're still making some fixes to the paper (I'd like to take a run through before we put a first preprint out), then it might be worth getting that change in and updating the paper to match it.
(Early version of the main file in that PR: ms_outer_interface.py)

#500 is done.

I'm also preparing a PR that will have significant effects on some user-facing stuff (this is the treatment of the MS-outer interface that JHP and I discussed in Berlin). I'm hoping that will be ready for review tomorrow night, Wednesday at the latest. This wasn't part of the original 1.0-alpha, but if we're still making some fixes to the paper (I'd like to take a run through before we put a first preprint out), then it might be worth getting that change in and updating the paper to match it.

Sounds good. Go ahead with this.
I'm still working on my paper PR that makes changes to Abstract and Introduction, along with some structural changes. Hope to have this finished up tonight, and then put the rest of my edits in Wed: https://github.com/choderalab/pathsampling-manuscripts/pull/28

Updates on this:

#500 and #517 have been merged
#386 is under review by @jhprinz
#530 is the PR-in-preparation I referenced above. Core code written, with tests. I'm hoping I'll be able to integrate that into the main code tomorrow, and have it ready to review very soon.

The only other thing I'm aware of that will make stored files incompatible or require changes to the (existing) text of the paper will be the renamings in #527. @jhprinz, is there anything else you have on the way for 1.0 that we need to keep in mind? Otherwise, I think everything is clean-up and polish.

#386 is mergeable from my point of view. So go ahead and merge or I do it tomorrow. It is still marked as WIP, so I am not sure.
I will try to fix the alanine example stuff tomorrow. Means we can do the renaming session and then release the alpha

Do you need to do a docs cleanup pass too at some point?

Do you need to do a docs cleanup pass too at some point?

Yes, definitely. We should do a last pass after finish renaming things. Of course, we can start earlier. We do ironing the docs once in a while but have postponed most of it until the API is done.

386 is merged.

Great!
Let me know when I should put together a conda recipe. You probably want to cut a release at some point. It's totally OK if this is 0.9.1 or something, since we want 1.0 to be the version that goes with the actual paper release.

I would suggest we get into the process of cutting releases more rapidly at this point. Once those PRs are merged, we can cut incremental releases (0.9.x) as different rounds of bugfixes or cleanups are performed.

With the merge of #530 (following merges of the PRs I listed originally), the only thing that I think will have API-breaking effects will be renamings in #527. (@jhprinz: you agree?)
This means that, if you don't mind the renamings causing trouble, I think we're ready to cut a 0.9.1 (or so) release, assuming @jhprinz is in agreement. Once we have the renamings set, we could even call it 1.0, although there might be some quick 1.0.1 or 1.0.2 follow-up.

I think we should aim to have a series of 0.9.x releases (marked as "preview" when cutting the github release) until the 1.0.0 release corresponding to paper submission.

Sure: so is it 1.0beta (or 1.0release_candidate) == submission, with 1.0 (proper) == proofs? That's my gut on how to do this.
In any case, I think that the API changes will stop within the next week. There's plenty of cleanup to do (unused fucntions and better docs, in particular), but we should be reasonably stable.

Yes, I agree. We can start with an 0.9.1-alpha. While making renamings and little updates as we finish the example for the paper.

Let's not call them alpha or beta, since this makes things more complicated and there's no need for a lengthy release candidate testing period. Let's just run up the 0.9.z counter until we actually submit the paper, and have 1.0.0 be the submitted version (with 1.0.z being post-submission bugfixes).
Major changes to the API that break backwards-compatibility should cause us to go from 1.y.z to 2.y.z, while major feature updates should increment the y from 1.0.z to 1.1.z.

The two PRs are ready. Removal of two files and one renaming. Should not interfere with anything

Can this be closed? I think all the PR we wanted are merged.

Seems to me that releasing 0.9.0 implied this was solved, but what do you think, @jchodera?

Yes!


Migrations doesn't force or even allow specifying ALGORITHM=INPLACE on schema alterations, which hands mysql users a loaded footgun

For mysql, adding columns to tables and other schema operations are sometimes executed in place, which makes them fast and also means they don't require table level locks.
However sometimes they're not, which means mysql will lock the table and copy its entire contents! This can let's just say have an adverse impact if done on production.
So because of that best practice is to specify ALGORITHM=INPLACE when running a migration. This way if for some reason it doesn't support doing a safer in place alteration, the migration will quickly fail rather than bringing down production.
The reasons ALGORITHM=INPLACE might not be supported can be extremely arbitrary and hard to predict.
Migrations currently don't have a column modifier or anything to allow specifying this, and don't specify it by default. Which mean that mysql users need to hand write alter statements in order to utilize this safety feature.

Heya, thanks for submitting this.
This seems like a feature request or an improvement. It's best to post these at the laravel/ideas repository to get support for your idea. After that you may send a PR to the framework. Please only use this issue tracker to report bugs and issues with the framework.
Thanks!

Ok thanks, submitting it there.

https://github.com/laravel/ideas/issues/2084

@paulcdejean Hi Paul. Looks like the ideas repo has been archived and no further action was taken.
I agree, it would be good if we could pass the ALGORITHM and LOCK variables via artisan migrate. It’s essential for mission-critical apps.
Did you ever find a good way to handle this?

@driesvints Hey Dries, here’s a bit more background on why this is important: https://planetscale.com/blog/zero-downtime-laravel-migrations

MySQL 8 uses the algorithm in the following order: INSTANT -> INPLACE -> COPY. You can specify algorithms for any indexing, just not adding columns. Is this option really still needed?
I understand if you are on MySQL 5.6 this might be very useful. But I think for those still on older versions, using raw sql works adequately.

@binaryfire you can vote for this here https://github.com/laravel/framework/discussions/44757


Ghost vertical line

Hello , I have another issue with my back and white panel 96x16 pixels.
I already check wiring and test programs, no ways any idea?

Solved : A led in the line was defect. I remove the led and then the line is OK (exept the removed led ;)


Add new fields to the invoice form.

Add fields to Invoice form.

Invoice number.
Invoice amount.

@abhiXII We already show an automatically generated "Invoice number" in UI. Do we want to update that as well and show this new Invoice number instead of that?

Oh yes yes @sandeepsajan0 this won't be auto-generated after our implementation. We want to use the user-input invoice number.


Increase quota for N2_CPUS for hub-env prior to deployment

part of #446
details coming
https://console.cloud.google.com/kubernetes/object/compute.cnrm.cloud.google.com/computeinstances/northamerica-northeast1/krmapihost-kcc-oi4/networking/hub-fgt-secondary-instance?apiVersion=v1beta1&project=kcc-boot-ls-8704&orgonly=true&supportedpurview=organizationId

status:
  conditions:
  - lastTransitionTime: "2023-10-24T14:23:37Z"
    message: "Update call failed: error applying desired state: summary: Error waiting
      for instance to create: Quota 'N2_CPUS' exceeded.  Limit: 8.0 in region northamerica-northeast1.\n\tmetric
      name = compute.googleapis.com/n2_cpus\n\tlimit name = N2-CPUS-per-project-region\n\tlimit
      = 8\n\tdimensions = map[region:northamerica-northeast1]\n"

Thank you for submitting Case # (ID:6978a02638da4bb5bb) to Google Cloud Platform support for the following quota:
Change N2 CPUs - northamerica-northeast1 from 8 to 16
Your request is being processed and you should receive an email confirmation for your request. Should you need further assistance, you can respond to that email. You can also track the status of this reques

usually these come in easier

Reduced machine size temporarily to n2-standard-2 (6 cores for 3 vms)
wont work because of the nic count
  Warning  UpdateFailed  6s                    computeinstance-controller  Update call failed: error applying desired state: summary: Error creating instance: googleapi: Error 400: Invalid value for field 'resource.networkInterfaces': ''. Too many network interfaces. The maximum number of network interfaces allowed for this machine type is 2., invalid

trying
  machineType: e2-standard-2
for management and n2-standard-2 for fg vms

root_@cloudshell:~/pdt-ls/obriensystems/pubsec-declarative-toolkit/solutions/project (kcc-boot-ls-8704)$ kubectl get gcp -n networking | grep computeinstance
computeinstancegroup.compute.cnrm.cloud.google.com/hub-fgt-primary-umig     3d6h   True    UpToDate   109s
computeinstancegroup.compute.cnrm.cloud.google.com/hub-fgt-secondary-umig   3d6h   True    UpToDate   7s
computeinstance.compute.cnrm.cloud.google.com/hub-fgt-primary-instance     3d6h   True    UpToDate   2m34s
computeinstance.compute.cnrm.cloud.google.com/hub-fgt-secondary-instance   3d6h   True    UpToDate   7s
computeinstance.compute.cnrm.cloud.google.com/hub-management-instance      3d6h   True    UpToDate   26s

gui has not caught up

quota issue solved by using a different machine type for the management instance
and hit refresh on the gce pane

Status:
  Conditions:
    Last Transition Time:  2023-10-27T21:07:26Z
    Message:               The resource is up to date
    Reason:                UpToDate
    Status:                True
    Type:                  Ready
  Cpu Platform:            Intel Cascade Lake
  Current Status:          RUNNING
  Instance Id:<PHONE_NUMBER>601886829
  Label Fingerprint:       Z9VAAJ71T-w=
  Metadata Fingerprint:    GXJWD0MkUvs=
  Observed Generation:     7
  Self Link:               https://www.googleapis.com/compute/v1/projects/xxdmu-admin4-ls/zones/northamerica-northeast1-b/instances/fgt-secondary-instance
  Tags Fingerprint:        tvYV2XqMUG4=
Events:
  Type     Reason        Age                    From                        Message
  ----     ------        ----                   ----                        -------
  Warning  UpdateFailed  31m (x2153 over 3d6h)  computeinstance-controller  Update call failed: error applying desired state: summary: Error waiting for instance to create: Quota 'N2_CPUS' exceeded.  Limit: 8.0 in region northamerica-northeast1.
           metric name = compute.googleapis.com/n2_cpus
           limit name = N2-CPUS-per-project-region
           limit = 8
           dimensions = map[region:northamerica-northeast1]
  Normal   Updating  5m36s (x2190 over 3d6h)  computeinstance-controller  Update in progress
root_@cloudshell:~/pdt-ls/obriensystems/pubsec-declarative-toolkit/solutions/project (kcc-boot-ls-8704)$ ^C
root_@cloudshell:~/pdt-ls/obriensystems/pubsec-declarative-toolkit/solutions/project (kcc-boot-ls-8704)$ kubectl get gcp -n networking | grep computeinstance
computeinstancegroup.compute.cnrm.cloud.google.com/hub-fgt-primary-umig     3d6h   True    UpToDate   5m53s
computeinstancegroup.compute.cnrm.cloud.google.com/hub-fgt-secondary-umig   3d6h   True    UpToDate   4m11s
computeinstance.compute.cnrm.cloud.google.com/hub-fgt-primary-instance     3d6h   True    UpToDate   6m38s
computeinstance.compute.cnrm.cloud.google.com/hub-fgt-secondary-instance   3d6h   True    UpToDate   4m11s
computeinstance.compute.cnrm.cloud.google.com/hub-management-instance      3d6h   True    UpToDate   4m30s

Closing once more testing on mgmt VM behaviour under the reduced instance


[Improvement]: Optimize the commit process of commit snapshots for UnKeyedTable optimizing

Search before asking

[X] I have searched in the issues and found no similar issues.

What would you like to be improved?
Before version 1.3.x of Iceberg, the RewriteFiles interface did not provide methods for specifying sequence numbers while adding and deleting delete files. Therefore, in UnKeyedTableCommit, we had to complete table rewrite through transactional submission and an additional snapshot of deleting files. However, Iceberg version 1.3.x provides a more flexible interface design to improve this, and we can complete the rewrite in one submission through the following approach:
RewriteFiles dataFileRewrite = icebergTable.newRewrite();
addDeleteFiles.forEach(dataFileRewrite::addFile);
removedDataFiles.forEach(dataFileRewrite::deleteFile);
addDeleteFiles.forEach(dataFileRewrite::addFile);
removedDeleteFiles.forEach(dataFileRewrite::deleteFile);
dataFileRewrite.dataSequenceNumber(sequenceNumber);
dataFileRewrite.commit();

How should we improve?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Subtasks
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

cc @861752346

This issue has not be resolved, right?


Filter on rating in Plex

I've been trying to create a collection of my top rated movies, but it looks like filtering on Plex rating is not possible. If I use rating, it converts to critic_rating, and audience_rating is not what I'm after either. I want the rating I set myself on the movies

i can probably add user_rating

If you look in plex on there is:

Critic rating
Audience rating
Rating

So it would make sense that the filtering options reflect the same names

i get that but i dont want to be ambiguous about it so I'm gonna go with user_rating

also it makes it a little confusing codewise because in plex's backend they use rating, userRating, and audienceRating to store the values. Critic rating is stored in rating which is why rating translates to critic_rating. I find it confusing to instead call userRating,  rating when rating is actually critic rating.

Ok, I see. In that case I think it would be more clear to remove rating completely

im probably gonna leave it in converting to critic_rating because that's what it was before the change and I don't wanna mess up an old config but it shouldn't be listed on the wiki. It is lol I apparently forgot to remove it

added user_rating to dev

I tested it out and it works great


Error: 'Having multiple overloads of method 'Configure' is not supported.' after upgrading .NET 6.0 to .NET 8.0 using Upgrade Assistant

What version of .NET does your existing project use?
.NET 6
What version of .NET are you attempting to target?
.NET 8
Description
After upgrading project's Target Framework from .NET 6.0 to .NET 8.0 using Upgrade Assistant CLI, encountered an issue while running the program with 'Having multiple overloads of method 'Configure' in 'Program.cs' file
Project configuration and dependencies
Project.csproj
csproj.zip
StartUp.cs
StartUp.zip
Program.cs
Program.zip
HttpTrigger Function
HttpTriggerFunction.cs.zip
Timer Trigger Function
TimerTriggerFunction.zip
Link to a repository that reproduces the issue
No response

I recommend you creating a new project using the .NET 8 template, move all your implementations to this new project and then add this new project back into your first solution.
I've done that and a lot of the issues I was having were resolved.


Consider removing Axios in favour of node-fetch

fetch is not native in Node yet (I think they're working on it), but there is node-fetch.
It has a way smaller footprint than Axios and the extra stuff Axios provides is not required in the project from what I can tell. This change would also require pulling out the axios-mock-adapter package and replacing it with most likely jest-fetch-mock.
Documents and Links

Relates to #116
Axios on Bundlephobia, 13.4kB MINIFIED 4.6kB MINIFIED + GZIPPED
node-fetch on Bundlephobia, 452B MINIFIED 289B MINIFIED + GZIPPED

I just really like working with Axios ;D

I'll close this then @raae.


Added new settings for members signup redirects

refs #12366
Two new settings for redirecting members after signup, based on if
they're paid or free, defaulting to the current redirect of "/"

@tpatel So this migration is to ensure that the setting is added to the right group when migrating from v. old version, there is no previous value in this case so a down version doesn't really make sense here! But usually we do include one!
The signature for the helper we're using doesn't have default params so we have to pass it explicitly


Migrate tests to new testing framework

See details in the parent issue napalm-automation/napalm-base#99

Implemented in #47


add helper function to load robot from package name + urdf + srdf

Description
Adds a little helper function to load a RobotModel given a package name and URDF / SRDF paths relative to the package, in case someone needs to load a robot for testing, different than the pre-set ones.
Checklist

[ ] Required by CI: Code is auto formatted using clang-format
[ ] Extend the tutorials / documentation reference
[ ] Document API changes relevant to the user in the MIGRATION.md notes
[ ] Create tests, which fail without this PR reference
[ ] Include a screenshot if changing a GUI
[ ] While waiting for someone to review your request, please help review another open pull request to support the maintainers

Wouldn't it make sense to rewrite the existing functions to use the newly added one and just pass the corresponding paths?


Invalid invite Discord

I think the discord invite link has expired

Yea, I get an error saying the invite link may have expired or I do not have permission to join

This is the link in the README: https://discord.gg/Jsey3mX98B Seems to work for me, do you get some sort of error?

I just tried it with my phone, and it worked. Thanks.

This is the link in the README: https://discord.gg/Jsey3mX98B Seems to work for me, do you get some sort of error?

I just tried it with my phone, and it worked. Thanks.


create-sandbox: do we ever expect more than one container?

doing some static review, I notice in createSandboxFromConfig we call create containers.
AFAIU, if we are creating a sandbox, the only container that should be expected from a "create" call is the pause container.  Can someone clarify if this is an incorrect assumption?
We may want to consider just calling the simpler (and very common in code flow) function CreateContainer from sandbox.go.
Another side comment - can we agree we shouldn't add any more functions with the name createContainer - we have a enough right now, right?  :)

@bergwolf @sboeuf - PTAL and help clarify?

I guess the main reason is we have containers listed in the sandbox config? For hyperd, we are able to get all container configs when creating the sandbox but we still choose to create an empty sandbox and insert all containers to it thereafter.
I think we can do the same here and simply remove createcontainers from createSandboxFromConfig, and then change the API callers (cli and shimv2 atm) to call CreateContainer after calling CreateSandbox etc.

@egernst

AFAIU, if we are creating a sandbox, the only container that should be expected from a "create" call is the pause container. Can someone clarify if this is an incorrect assumption?

The reason why we introduced such logic was to ensure the API would let the caller provide a SandboxConfig with one or more containers, and those containers would be created at the same time  the sandbox is being created, which makes sense IMO.
Now, from a kata-runtime (CLI) perspective, we want to call into CreateContainer(), we could definitely do that by not doing any modification to the API. The only thing we would need is to submit a patch to the CLI, making sure we're not creating any ContainerConfig as part of the SandboxConfig, and after the call to CreateSandbox returns, we would call into CreateContainer. Does that help?

@sboeuf The purpose is to make CreateSandbox API possible to implement for some hypervisors (i.e., firecracker) that do not support hotplug. We need to change the API flow from create sandbox -> start vm -> create container -> start container to create sandbox -> create container -> start vm & container. As for CLI, there will be a emulated Created state where no VM is created at all.


Adding ENV for setting custom DNS Server in /etc/resolv.conf

As some users facing issues with name resolution/ DNS settings it might be useful to add an ENV to manually set a custom DNS for the Docker container in /etc/resolv.conf.

As I see this is not really necessary because already built in:

https://docs.docker.com/config/containers/container-networking/#dns-services


BUG: configuration file example is broken

The example for the configuration file is no longer complete.
Some changes to the EnergyNetwork have broken the example.
I think mergeBuses is a required argument to setFromExcel.
When it stays None, the following error is raised:

https://github.com/SPF-OST/optihood/blob/main/optihood/buildings.py line 108.

mergebuses is a required argument, if you set mergeLinkBuses to True. It's a list specifying the names of buses to be merged. In this case I would set it to ["electricity", "space_heat", "domestic_hot_water"].


Choo SSR w/ Express example

Can someone post a quick gist demonstrating Choo on the front and Express in the back w/ SSR?

that's awesome! i will explore it and ping you if I have any further questions!

Note that this cli/generator uses old style store rehydration, it would most likely be updated for the new API that allows you to do initialState like this: https://github.com/choojs/choo#server-rendering

Bumped to 0.0.6 so you can now see full example with initialState hydration


Include Order failure reason as part of CertificateRequest failure message

What this PR does / why we need it:
Updates the acme certificate request controller to surface the Order's reason field if an Order has failed for whatever reason.
This should make it easier to debug issues as they'll be immediately obvious via kubectl describe certificate and kubectl describe certificaterequest instead of the user having to go all the way down to the Order level.
Release note:
acme: surface the 'reason' for Order's failing on Certificate & CertificateRequest resources for easier debugging of failures

/area acme
/kind feature
/milestone v0.16

/lgtm


[Failing Test]: beam/testing/passert Go Test flaky

What happened?
This test has been flaky on Go Test GitHub Actions for a while. Example run: https://github.com/apache/beam/actions/runs/6426709641/job/17451278741
example error:
2023/10/06 02:25:55 ERROR process bundle failed for instruction inst004 using plan stage-007 : while executing Process for Plan[stage-007]:
1: DataSource[S[stage-007_source@localhost:42229], i0] Out:2 Coder:W;cwv_n9<bytes;c0>!GWC
2: ParDo[passert.failIfBadEntries] Out:[] Sig: func([]uint8, func(*typex.T) bool, func(*typex.T) bool, func(*typex.T) bool) error, SideInputs: [SideInputAdapter[S[e8@localhost:42229], i1] - Coder W<string;c2>!GWC SideInputAdapter[S[e8@localhost:42229], i2] - Coder W<string;c2>!GWC SideInputAdapter[S[e8@localhost:42229], i3] - Coder W<string;c2>!GWC]
	caused by:
source failed
	caused by:
DoFn[UID:2, PID:passert.EqualsList/passert.failIfBadEntries, Name: github.com/apache/beam/sdks/v2/go/pkg/beam/testing/passert.failIfBadEntries] failed:
actual PCollection does not match expected values
=========
2 correct entries (present in both)
=========
1 unexpected entries (present in actual, missing in expected)
+++
example
=========
1 missing entries (missing in actual, present in expected)

Issue Failure
Failure: Test is flaky
Issue Priority
Priority: 1 (unhealthy code / failing or flaky postcommit so we cannot be sure the product is healthy)
Issue Components

[ ] Component: Python SDK
[ ] Component: Java SDK
[X] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam YAML
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

This is certainly a flake on Prism I wasn't aware of. Investigating.

It's definitely a prism thing, and not this specific test. Recently there were other failures (which have been fixed) due to an uncompiled change failure change (unused import).
I see a few test timeouts.
I see a few "runner ran out of memory" (https://github.com/apache/beam/pull/28954 should help there) by properly caching go deps.
I see a couple where govulncheck is taking ages (this has now been removed, which will help).
One "send on a closed channel" which is definitely a race condition (and statistically likely to be the root cause of the timeouts).
https://github.com/apache/beam/actions/runs/6432180597/job/17466495105
https://github.com/apache/beam/actions/runs/6424305310/job/17444659174

Scratch that. The caching and no more vuln check runs does seem to have speed things up from ~8-12 minutes for test runs to ~3. I'll take it.

This seems to have been resolved between the various stability fixes to prism and the precommits.


Setting urlMaximumLength revokes access to original complete URL

When the length of the URL in an ActiveLabel (i.e.: label.urlMaximumLength = 30) is greater than the set urlMaximumLength, the original full url inside label.handleURLTap { url in  ... } is not available.
Is there a way to trim the URLs in the label while maintaining the original full URL so to open it inside handleURLTap such as via UIApplication.sharedApplication().openURL(url) ?
Currently, tapping on a URL inside an ActiveLabel that trims a URL contained inside it via the urlMaximumLength property, leads to an invalid web page when opening the url (i.e. via openURL).

Hi @dnadri, I've been checking the issue you are having, and I cannot reproduce it.
To double check it I just added new tests for that checking the cases when the URL in the label is above and below the limits. You can take a look at them here: https://github.com/optonaut/ActiveLabel.swift/commit/446dbcd9fbc6403aa4434ad8d79eae765b8bff17
If you are still having issues with it, please attach a snippet of code. 😄

@poolqf Thanks for checking out this issue.
Here's a snippet of code inside an ActiveLabel subclass I created:
Let's say inside the label is the following URL (56 characters long):
https://github.com/optonaut/ActiveLabel.swift/issues/150
        urlMaximumLength = 30
        customize { label in
            label.enabledTypes = [.URL]
            label.numberOfLines = 0
            label.textColor = UIColor.darkTextColor()
            label.URLColor = UIColor.blueColor()
            label.URLSelectedColor = UIColor.grayColor()
            label.handleURLTap { url in
                print("url: \(url)")
                // prints "https://github.com/optonaut/Ac" (30 characters)
                // trying to open this link would lead to an invalid page
                UIApplication.sharedApplication().openURL(url)
                // it should have access to the original full link (https://github.com/optonaut/ActiveLabel.swift/issues/150) if one decides to open the link inside this block, for example
            }

        }

Thanks!

I just copy pasted it on the Demo project, and it is working.. 🙃
I can see you are using Swift 2.3, so maybe there's an issue on that branch. I'll take a look

Currently, we have the same error.
Using the URL https://github.com/optonaut/ActiveLabel.swift/issues/150 results in the exact same error like @dnadri described.
Here is our code:
            label.URLSelectedColor = UIColor.black
            label.urlMaximumLength = 30
            label.handleURLTap({ (url) in
                if url.absoluteString.isValidForUrl() {
                    UIApplication.shared.openURL(url)
                } else if let url = URL(string: "http://" + url.absoluteString) {
                    UIApplication.shared.openURL(url)
                }
            })

@poolqf I don't know why but original and trimmed are both set to the trimmed one.
(lldb) po activeElements[.url]
▿ Optional<Array<(range : _NSRange, element : ActiveElement, type : ActiveType)>>
  ▿ some : 1 element
    ▿ 0 : 3 elements
      ▿ range : _NSRange
        - location : 0
        - length : 30
      ▿ element : ActiveElement
        ▿ url : 2 elements
          - original : "https://github.com/optonaut/Ac"
          - trimmed : "https://github.com/optonaut/Ac"
      - type : ActiveLabel.ActiveType.url

Breakpoint set inside didTapStringURL(_ stringURL: String).
Cheers,
Aaron

Sorry, we misused label.text.
We assigned label.text to a new variable, altered the variable, and assigned the variable to label.text.
This causes the problem since label.text already contains the trimmed url.
@dnadri May be this is also your error?!


Fix typo in README

Coverage remained the same at 89.697% when pulling a8a8773e5bd826d6fae0a856f1dd0ba214e3ea9a on amorphid:master into 8992ea90c0934f5b22dbbf079cd095c28c7ca535 on bryanjos:master.


ng build --prod still does NOT minify / uglify / remove comments using angular-cli 9 (and 8)

🐞 Bug report
Command (mark with an x)

[ ] new
[x ] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] xi18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?

 Yes, but I don't know what is the previous version in which this bug was not present.
Description
 When I build my Angular project with ng build --prod, all comments remain in the html, spaces aren't removed, etc. Seems like no minification / uglification / comment removal is taking place.
🔬 Minimal Reproduction

Simply: ng build --prod (run on a basic project with an html comment in index.html
🔥 Exception or Error
No exception, just doesn't minify / uglify / remove comments when it should.
🌍 Your Environment

Angular CLI: 9.1.3
Node: 12.16.2
OS: win32 x64

Angular: 9.1.3
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.901.3
@angular-devkit/build-angular     0.901.3
@angular-devkit/build-optimizer   0.901.3
@angular-devkit/build-webpack     0.901.3
@angular-devkit/core              9.1.3
@angular-devkit/schematics        9.1.3
@angular/cdk                      9.2.1
@angular/material                 9.2.1
@ngtools/webpack                  9.1.3
@schematics/angular               9.1.3
@schematics/update                0.901.3
rxjs                              6.5.5
typescript                        3.8.3
webpack                           4.42.0

Anything else relevant?

I'm running this on Windows 10 x64, if that matters.
Somewhat duplicate of https://github.com/angular/angular-cli/issues/9973, however still not solved in Angular 8 or 9 (I had 8 and upgraded to 9 in the hopes that it would be fixed there, but it isn't). Also, the previously suggested workaround of running ng build --target=production --environment=prod doesn't work, it gives an error message:

Unknown option: '--target'
Unknown option: '--environment'

Thanks!!

Duplicate of https://github.com/angular/angular-cli/issues/11360

@alan-agius4 I don't think this is a duplicate, I gave index.html as an example, but I can also see css comments inside main-es2015...js file, and I didn't search for js or html comments outside index.html, but there might be some of those as well...

Can you share the build section of your angular.json?

        "build": {
          "builder": "@angular-devkit/build-angular:browser",
          "options": {
            "aot": true,
            "preserveSymlinks": true,
            "rebaseRootRelativeCssUrls": true,
            "outputPath": "dist",
            "index": "src/index.html",
            "main": "src/main.ts",
            "tsConfig": "src/tsconfig.app.json",
            "polyfills": "src/polyfills.ts",
            "assets": [
              "src/assets",
              "src/favicon.ico",
              "src/favicon.png",
              "src/web.config",
              {
                "glob": "**/*",
                "input": "node_modules/leaflet/dist/images",
                "output": "/assets/img/markers"
              }
            ],
            "styles": [
              "node_modules/bootstrap/dist/css/bootstrap.css",
              "node_modules/typeface-exo/index.css",
              "node_modules/roboto-fontface/css/roboto/roboto-fontface.css",
              "node_modules/ionicons/scss/ionicons.scss",
<EMAIL_ADDRESS>              "node_modules/socicon/css/socicon.css",
              "node_modules/nebular-icons/scss/nebular-icons.scss",
              "node_modules/angular-tree-component/dist/angular-tree-component.css",
              "node_modules/pace-js/templates/pace-theme-flash.tmpl.css",
              "node_modules/leaflet/dist/leaflet.css",
<EMAIL_ADDRESS>            ],
            "scripts": [
              "node_modules/pace-js/pace.min.js",
              "node_modules/tinymce/tinymce.min.js",
              "node_modules/tinymce/themes/modern/theme.min.js",
              "node_modules/tinymce/plugins/link/plugin.min.js",
              "node_modules/tinymce/plugins/paste/plugin.min.js",
              "node_modules/tinymce/plugins/table/plugin.min.js",
              "node_modules/echarts/dist/echarts.min.js",
              "node_modules/echarts/dist/extension/bmap.min.js",
              "node_modules/chart.js/dist/Chart.min.js"
            ]
          },
          "configurations": {
            "production": {
              "budgets": [
                {
                  "type": "anyComponentStyle",
                  "maximumWarning": "6kb"
                }
              ],
              "optimization": true,
              "outputHashing": "all",
              "sourceMap": false,
              "extractCss": true,
              "namedChunks": false,
              "aot": true,
              "extractLicenses": true,
              "vendorChunk": false,
              "buildOptimizer": true,
              "fileReplacements": [
                {
                  "replace": "src/environments/environment.ts",
                  "with": "src/environments/environment.prod.ts"
                }
              ]
            }
          }
        },

This seems like a bug but we'll need to look at a reproduction to find and fix the problem. Can you setup a minimal repro please?
You can read here why this is needed. A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.
This might be related to your directory structure so its really important to get an accurate repro to diagnose this.

Ok, so here's what I found so far:

css comments - apparently comments starting with /*! don't get removed, I'm guessing this is a feature, not a bug (didn't know that).
whitespaces in html code - I couldn't (within the reasonable time I can afford for this) give simple reproduction steps, however I can say that I use @nebular/auth npm package, in it (in auth.component.js) there is the following code:
NbAuthComponent = __decorate([
Component({
selector: 'nb-auth',
template:  <nb-layout>    <nb-layout-column>      <nb-card>        <nb-card-header>                                    <nb-icon icon="arrow-back"></nb-icon>                              </nb-card-header>        <nb-card-body>          <nb-auth-block>            <router-outlet></router-outlet>          </nb-auth-block>        </nb-card-body>      </nb-card>    </nb-layout-column>  </nb-layout>,

(most likely generated from the code here: https://github.com/akveo/nebular/blob/master/src/framework/auth/components/auth.component.ts)
The template code can be found as-is inside main-es2015...js, i.e. ({selector:"nb-auth",template:'\n    <nb-layout>\n      <nb-layout-column>\n        <nb-card>\n          <nb-card-header>\n...
whitespaces in css code - even inside a new project, after running ng build --prod, you can find inside main-es2015...js code such as: styles:['[_nghost-%COMP%] {\n    font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol";\n    font-size: 14px;\n    color: #333;\n.... Seems like at least some of those whitespaces can be removed...

css comments - apparently comments starting with /*! don't get removed, I'm guessing this is a feature, not a bug (didn't know that).

Indeed comments starting with /* ! have a special meaning for CSS tools and in the majority of cases these comments will not be dropped.

whitespaces in html code - I couldn't (within the reasonable time I can afford for this) give simple reproduction steps, however I can say that I use @nebular/auth npm package, in it (in auth.component.js) there is the following code:
NbAuthComponent = __decorate([
Component({
selector: 'nb-auth',
template:  <nb-layout>    <nb-layout-column>      <nb-card>        <nb-card-header>                                    <nb-icon icon="arrow-back"></nb-icon>                              </nb-card-header>        <nb-card-body>          <nb-auth-block>            <router-outlet></router-outlet>          </nb-auth-block>        </nb-card-body>      </nb-card>    </nb-layout-column>  </nb-layout>,

(most likely generated from the code here: https://github.com/akveo/nebular/blob/master/src/framework/auth/components/auth.component.ts)
The template code can be found as-is inside main-es2015...js, i.e. ({selector:"nb-auth",template:'\n    <nb-layout>\n      <nb-layout-column>\n        <nb-card>\n          <nb-card-header>\n...

I tried to reproduce this locally and wasn't able to reproduce. This is also quite surprising because in the output, you shouldn't be seeing any HTML code, because HTML is transformed into JS (instruction sets) when building in AOT mode.

whitespaces in css code - even inside a new project, after running ng build --prod, you can find inside main-es2015...js code such as: styles:['[_nghost-%COMP%] {\n font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol";\n font-size: 14px;\n color: #333;\n.... Seems like at least some of those whitespaces can be removed...

CSS optimisation only happen on external styles, when styles are inlined either in the html template using the style tag or within the component class using the styles property. The css optimization pipeline is bypassed totally. Maybe the compiler can always remove the new lines, that said for a better optimisation use stylesURLs? //cc for their input @petebacondarwin and @alxhub.

Hi there, some strange thing is happening with prod compilation/minification.
With Angular 9, PageSpeed Insights advise us that main-es2015 file is not minified

We have not made any changes to the build parameters for production when we have made the migration to Angular 9 and never we have seen this "error" with production builds and we have our website developed with Angular since Angular 2.
Our build section:
{
  "build": {
    "builder": "@angular-devkit/build-angular:browser",
    "options": {
      "outputPath": "dist/apps/client/browser",
      "index": "apps/client/src/index-dev.html",
      "main": "apps/client/src/main.ts",
      "polyfills": "apps/client/src/polyfills.ts",
      "tsConfig": "apps/client/tsconfig.app.json",
      "aot": true,
      "assets": [
        "apps/client/src/assets",
        {
          "glob": "**/*",
          "input": "../../node_modules/@cnv/ui/components/form/input-phone/src/assets/flags",
          "output": "assets/flags"
        },
        {
          "glob": "**/*",
          "input": "../../node_modules/@cnv/ui/components/form/dropdown/src/assets/icons",
          "output": "assets/icons"
        }
      ],
      "styles": [
        "../../node_modules/normalize.css/normalize.css",
        "apps/client/src/styles.scss"
      ],
      "scripts": [],
      "stylePreprocessorOptions": {
        "includePaths": [
          "apps/client/src/styles"
        ]
      }
    },
    "configurations": {
      "production": {
        "fileReplacements": [
          {
            "replace": "apps/client/src/environments/environment.ts",
            "with": "apps/client/src/environments/environment.prod.ts"
          },
          {
            "replace": "apps/client/src/build-specifics/index.ts",
            "with": "apps/client/src/build-specifics/index.prod.ts"
          }
        ],
        "index": "apps/client/src/index.html",
        "optimization": true,
        "outputHashing": "all",
        "sourceMap": false,
        "extractCss": true,
        "namedChunks": false,
        "extractLicenses": true,
        "vendorChunk": false,
        "buildOptimizer": true,
        "budgets": [
          {
            "type": "initial",
            "maximumWarning": "2mb",
            "maximumError": "5mb"
          },
          {
            "type": "anyComponentStyle",
            "maximumWarning": "6kb",
            "maximumError": "10kb"
          }
        ],
        "tsConfig": "apps/client/tsconfig.app.prod.json"
      },
      "hmr": {
        "budgets": [
          {
            "type": "anyComponentStyle",
            "maximumWarning": "6kb"
          }
        ],
        "fileReplacements": [
          {
            "replace": "apps/client/src/environments/environment.ts",
            "with": "apps/client/src/environments/environment.hmr.ts"
          }
        ],
        "vendorSourceMap": true
      },
      "es5": {
        "budgets": [
          {
            "type": "anyComponentStyle",
            "maximumWarning": "6kb"
          }
        ],
        "tsConfig": "apps/client/tsconfig-es5.app.json"
      },
      "es5-production": {
        "budgets": [
          {
            "type": "anyComponentStyle",
            "maximumWarning": "6kb"
          }
        ],
        "tsConfig": "apps/client/tsconfig-es5.app.prod.json"
      }
    }
  }
}

Our tsconfigs used for production:
workspace tsconfig.json
{
  "compileOnSave": false,
  "compilerOptions": {
    "baseUrl": "./",
    "outDir": "./dist/out-tsc",
    "sourceMap": true,
    "declaration": false,
    "downlevelIteration": true,
    "experimentalDecorators": true,
    "module": "esnext",
    "moduleResolution": "node",
    "importHelpers": true,
    "target": "es2015",
    "lib": [
      "es2018",
      "dom"
    ]
  },
  "angularCompilerOptions": {
    "fullTemplateTypeCheck": true,
    "strictInjectionParameters": true
  }
}

base tsconfig.json
{
  "extends": "../../tsconfig.json",
  "compilerOptions": {
    "baseUrl": "./"
  },
  "include": [
    "src/**/*.ts"
  ]
}

tsconfig.app.json
{
  "extends": "./tsconfig.json",
  "compilerOptions": {
    "outDir": "../../dist/out-tsc/apps/client",
    "types": [
      "node"
    ],
    "paths": {
      "@app/*": [
        "src/app/*"
      ],
      "@common/*": [
        "src/app/common/*"
      ],
      "@core/*": [
        "src/app/core/*"
      ],
      "@env/*": [
        "src/environments/*"
      ],
      "@build-specifics": [
        "src/build-specifics"
      ],
      "@cnv/*": [
        "../../libs/*/src/index.ts"
      ]
    }
  },
  "files": [
    "src/main.ts",
    "src/polyfills.ts"
  ],
  "include": [
    "src/**/*.d.ts"
  ]
}

tsconfig.app.prod.json
{
  "extends": "./tsconfig.app.json",
  "compilerOptions": {
    "paths": {
      "@app/*": [
        "src/app/*"
      ],
      "@common/*": [
        "src/app/common/*"
      ],
      "@core/*": [
        "src/app/core/*"
      ],
      "@env/*": [
        "src/environments/*"
      ],
      "@build-specifics": [
        "src/build-specifics"
      ]
    }
  }
}

We have tried to minify the main file(previously minified by angular-cli) manually with other tools but it seems that it's completely minified.
You can check it at carnovo.com or SpeedInisghts

@eranzim, can you provide a minimal repro of what you are seeing? It's hard for us to debug further without one. /*! comments are not stripped and CSS using the styles decorator option is not minified, so those are both working as expected. If you can get a minimal reproduction of the template HTML persisting in a prod build, we can look into that further.
@rafa-as, can you open a new issue for what you're seeing? It will be easier to debug/track that in a separate issue.

@dgp1130 I added my comment here because it seems to be something closely related.
Anyway, I'll open another issue about minification problems.

Closing as no reproduction has been provided.
If the problem persists please open a new issue and provide a reproduction.

@rafa-as rafa-as have you found a solution because i have exactly the same issue since my migration from angular 8 to 9.

Unfortunately not @Spawnrad . I still have to add the issue about this problem.


Update repositories.txt

@ArduinoBot

@ArduinoBot check mal

Hello @Justin-Pl. The automated system here only operates on open pull requests. Since your submission was already accepted and the pull request merged, the bot won't pay any more attention to this pull request.
But this human is happy to provide assistance. Was there something you needed from the bot?

Hello @per1234, Im a little confused with the lint log: no example sketch found. My repo has a /examples dir with a sketch but lint dont see this dir.
https://downloads.arduino.cc/libraries/logs/github.com/Justin-Pl/PCA9685_LED_DRIVER/
https://github.com/Justin-Pl/PCA9685_LED_DRIVER

My repo has a /examples dir with a sketch

This is incorrect. Your repo has an examples dir with a .ino file in it.
Because many sketches consist of only a single .ino file, it is easy to get the impression that the .ino file is the sketch, but this is not so. It is the folder that is the sketch. The .ino file must be inside a folder that matches the filename in order for it to be a valid sketch that will show up in the File > Examples > PCA9685_LED_DRIVER menu in Arduino IDE:
examples/
└── simpleTest/
    └── simpleTest.ino

Thanks for the help


how to integrate?

continue riobard/go-shadowsocks2#1

@septs Do you think you can work with the changes introduced here https://github.com/riobard/go-shadowsocks2/commit/3e9aaf3caad95ee55f550cd01c52946705df72a6 ?
I've moved all cipher-related code to core.

thx

Now merged into https://github.com/shadowsocks/go-shadowsocks2
Let me know if there's any problem.


Store exception traceback in logs f pipeline fails

The finally clause kicks in even if another exception is raised in the except clause
any improvement suggestions are welcome

we could also just log the traceback, but it seemed better to put it into a separate file