[WIP] ARROW-5255: [Java] Proof-of-concept of Java extension types

Not quite sure that ExtensionType and ExtensionTypeVector are correct.
Also, needs a more sophisticated example/more complete unit tests.

Codecov Report

Merging #4251 into master will increase coverage by 1.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4251      +/-   ##
==========================================
+ Coverage   88.27%   89.45%   +1.17%
==========================================
  Files         763      622     -141
  Lines       93639    83191   -10448
  Branches     1251        0    -1251
==========================================
- Hits        82660    74416    -8244
+ Misses      10866     8775    -2091
+ Partials      113        0     -113

Impacted Files
Coverage Δ

go/arrow/math/uint64_amd64.go

go/arrow/memory/memory_avx2_amd64.go

go/arrow/ipc/file_reader.go

js/src/enum.ts

go/arrow/array/builder.go

js/src/Arrow.node.ts

js/src/schema.ts

go/arrow/type_traits_boolean.go

js/src/ipc/node/writer.ts

js/src/visitor/vectorloader.ts

... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25dc4c9...2a37e4a. Read the comment docs.

@lihalite do you think this is good enough for a first go round in Java? @emkornfield or @jacques-n can you help review in advance of the extension types vote closing?

This is not up-to-date with the proposal, but the general approach should be ready for review.

Rebased & addressed feedback.

Just rebased. @emkornfield can you give this a final review, and if there is follow up work for any missing items or questions, let's open some JIRA issues?

Should be able to review by tomorrow.

Thanks for the review! I've fixed those two things.

+1, LGTM Build failure wasn't Java or Gandiva (looks like just a timeout).

I created: https://issues.apache.org/jira/browse/ARROW-5649 to verify this with an integration test.


cpu-stress Chaos Experiment

Why We Need This PR
Adds m-agent based cpu-stress experiment which can stress the CPU of target machines

It uses stress-ng tool to stress the CPU

Which Issue This PR Fixes
fixes #517
Special notes for your reviewer
Experiment execution logs:
INFO[2022-05-11T20:31:15+05:30] Experiment Name: cpu-stress
INFO[2022-05-11T20:31:15+05:30] [PreReq]: Getting the ENV for the  experiment
INFO[2022-05-11T20:31:15+05:30] [PreReq]: Updating the chaos result of cpu-stress experiment (SOT)
INFO[2022-05-11T20:31:17+05:30] [Info]: The stress process parameters are as follows  Load Percentage=50 CPUs=1
INFO[2022-05-11T20:31:17+05:30] [Status]: Connecting to the agents
INFO[2022-05-11T20:31:18+05:30] [Status]: Verify that stress-ng is available in the target machine
INFO[2022-05-11T20:31:19+05:30] [Chaos]: Injecting CPU stress for <IP_ADDRESS>:41365 agent endpoint
INFO[2022-05-11T20:31:20+05:30] [Chaos]: CPU stress chaos injected successfully in <IP_ADDRESS>:41365 agent endpoint
INFO[2022-05-11T20:31:20+05:30] [Wait]: Waiting for chaos interval of 30s
INFO[2022-05-11T20:31:50+05:30] [Chaos]: Reverting CPU stress for <IP_ADDRESS>:41365 agent endpoint
INFO[2022-05-11T20:31:51+05:30] [Status]: Disconnecting the agents
INFO[2022-05-11T20:31:51+05:30] [The End]: Updating the chaos result of cpu-stress experiment (EOT)

Checklist:

[x] Fixes #
[ ] PR messages has document related information
[ ] Labelled this PR & related issue with breaking-changes tag
[ ] PR messages has breaking changes related information
[ ] Labelled this PR & related issue with requires-upgrade tag
[ ] PR messages has upgrade related information
[ ] Commit has unit tests
[ ] Commit has integration tests
[x] E2E run Required for the changes

Should we rebase the m-agent branch with the master branch, and then take this PR?
cc: @uditgaurav @ksatchit

Rebasing the m-agent branch gives conflicts - we need to resolve them!

The build should pass in the CI @neelanjan00 !


set multi SPLASH_URLS

I have multiple servers,so I want to implement dynamic urls.What should I do?

@wisew you can specify splash_url argument for the SplashRequest: https://github.com/scrapy-plugins/scrapy-splash#requests or alternatively use https://github.com/TeamHG-Memex/aquarium to run a pool of splash processes under one proxy

@lopuhin Thanks,I have soloved the problem by specifing splash_url argument for the SplashRequest.

@wisew Can you close this issue?


Double click to maximise/minimise on windows

Tell us about the task you want to perform and are unable to do so because the feature is not available
Native windows apps usually have a "double click to maximise/unmaximise the window" feature.
Describe the solution/feature you'd like us to add
Double click to maximise/unmaximise.

Hey, Can I work on this?

As API Dash does not have an explicit title bar in Windows, this feature will not be intuitive for (and expected by) the end user.
Hence, closing this issue.


CupboardsCloseAll  Bug Fix

CupboardsCloseAll: It seems there are some issues with this environment, can I request a fix for this environment?

Hi @fangqi-Zhu,
Thanks for reporting this. Unfortunately can't reproduce the issue shown in the screenshot. Could you provide more details, such as the platform you're using, the code/configuration, and the steps to reproduce the problem? This will help us investigate further.
Thank you!

Thank you for your confirmation!
I was able to reproduce this issue on both macOS and Windows operating systems without modifying the code. You can reproduce the issue using the following code:
"""An example of using BiGym with state."""
from bigym.action_modes import JointPositionActionMode
from bigym.envs.reach_target import ReachTarget
from bigym.envs.cupboards import (
    DrawerTopOpen,
    DrawerTopClose,
    DrawersAllOpen,
    DrawersAllClose,
    WallCupboardOpen,
    WallCupboardClose,
    CupboardsOpenAll,
    CupboardsCloseAll,
)

from bigym.robots.configs.h1 import H1

print("Running 1000 steps without pixels...")
env = DrawersAllOpen(
    action_mode=JointPositionActionMode(floating_base=True, absolute=True, block_until_reached=False),
    render_mode="human",
    robot_cls = H1
)

print("Observation Space:")
print(env.observation_space)
print("Action Space:")
print(env.action_space)

env.reset()
for i in range(100000):
    actions = env.action_space.sample()
    obs, reward, terminated, truncated, info = env.step(actions)
    img = env.render()
env.close()

I found that when I modified the Euler parameters in bigym/envs/presets/counter_base_wall_3x1.yaml, I was able to rotate the BaseCabinet, but the WallCabinet could not be rotated. I'm not sure if you can reproduce this issue. Thank you very much for your help.

Thanks for sharing the code and details!
I haven’t been able to reproduce the issue on Linux, but I’ll check it out on macOS and update you here.

Quick update on the issue, it is related to updates of the Mojo, we are working on fixing these problem, it will be fixed in https://github.com/chernyadev/bigym/pull/19.

The issue should be resolved in #19. Could you please confirm on your side?

Thank you for your kind help!


selectParent method

In ChemGE, selectParent method is implemented. But it seems this method is not in use.
How can I use this method ?
$ grep -nir "selectparent"
optimize-rdock-qsub.py:54:def selectParent(population, tournament_size=3):
optimize-rdock.py:55:def selectParent(population, tournament_size=3):
optimize-J.py:54:def selectParent(population, tournament_size=3):

I previously used that method, but I don't use it in the current version. I just forgot deleting.


update branding from 3KeyCompany to CZERTAINLY

Resolved by https://github.com/3KeyCompany/CZERTAINLY-Appliance/commit/f1f7e9f2b6d59160dc50bbd60efab6c60083fe3c


Extension with native code

Prerequisites

[x] Is this Brackets-Electron specific problem (did you test it with latest brackets build)?

Description
I tryed to install my extension manually but it fails with this message in the console:
failed to run terminals.startConnection:  Unable to load one of the modules: ...../AppData/Roaming/Brackets-Electron/extensions/user/brackets-terminal-x/src/node/TerminalsDomain, reason: Error: A dynamic link library (DLL) initialization routine failed.
\\?\.....\AppData\Roaming\Brackets-Electron\extensions\user\brackets-terminal-x\node_modules\node-pty\build\Release\pty.node

do you have an idea?
I tryed to delete the .npmrc  file or to add one like this but failed.
# Electron's version.
npm_config_target=1.6.2
# The architecture of Electron, can be ia32 or x64.
npm_config_arch=x64
npm_config_target_arch=x64
# Download headers for Electron.
npm_config_disturl=https://atom.io/download/electron
# Tell node-pre-gyp that we are building for Electron.
npm_config_runtime=electron
# Tell node-pre-gyp to build module from source code.
npm_config_build_from_source=true

Versions
Windows 10
1.9.4
Steps to Reproduce

Clone https://github.com/ficristo/brackets-terminal-x/releases in the extensions folder
Delete the .npmrc file
Run npm install (with the same node version of Brackets-Electron)
Start Brackets

Expected behavior: [What you expected to happen]
My extensions should load
Actual behavior: [What actually happened]
An error is logged on the console

The path in the console log looks broken to me. Wondering who can't deal with windows paths properly


KeyError: 'cumulative-assigned-addresses

How to launch kea-exporter?
example 1
[root@southpark kea_exporter]# kea-exporter --address "<IP_ADDRESS>" --port 8001 /tmp/kea4-ctrl-socket
Listening on http://<IP_ADDRESS>:8001
Traceback (most recent call last):
  File "/usr/local/bin/kea-exporter", line 11, in <module>
    sys.exit(cli())
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/kea_exporter/cli.py", line 22, in cli
    exporter.update()
  File "/usr/local/lib/python3.6/site-packages/kea_exporter/kea.py", line 502, in update
    metric_info = self.metrics_dhcp4_map[key]
KeyError: 'cumulative-assigned-addresses'

example2
[root@southpark kea_exporter]# kea-exporter --address "localhost" --port 8001 /tmp/kea4-ctrl-socket
Listening on http://localhost:8001
Traceback (most recent call last):
  File "/usr/local/bin/kea-exporter", line 11, in <module>
    sys.exit(cli())
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/kea_exporter/cli.py", line 22, in cli
    exporter.update()
  File "/usr/local/lib/python3.6/site-packages/kea_exporter/kea.py", line 502, in update
    metric_info = self.metrics_dhcp4_map[key]
KeyError: 'cumulative-assigned-addresses

I would be grateful for an example.

This is probably due to new metrics, that kea-exporter does not handle yet.

I've added a patch for you to try in the pull request above.

I'm still seeing a KeyError with the patch applied.
I believe this is caused by a further instance of "cumulative-assigned-addresses" on each subnet which isn't captured by self.metrics_dhcp4_ignore.
echo '{ "command": "statistic-get-all" }' | socat UNIX:/sockets/kea-dhcp4-ctrl.sock -,ignoreeof | jq
{
  "arguments": {
    "cumulative-assigned-addresses": [
      [
        0,
        "2020-08-05 11:14:44.552701"
      ]
    ],
    ...... omitted for brevity .......
    ],
    "subnet[1].cumulative-assigned-addresses": [
      [
        0,
        "2020-08-05 11:14:45.591529"
      ]
    ...... omitted for brevity .......
  },
  "result": 0
}

Here is the traceback:
Traceback (most recent call last):
  File "/usr/bin/kea-exporter", line 11, in <module>
    load_entry_point('kea-exporter==0.4.1', 'console_scripts', 'kea-exporter')()
  File "/usr/lib/python3.8/site-packages/click-7.1.2-py3.8.egg/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/usr/lib/python3.8/site-packages/click-7.1.2-py3.8.egg/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/usr/lib/python3.8/site-packages/click-7.1.2-py3.8.egg/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/lib/python3.8/site-packages/click-7.1.2-py3.8.egg/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/usr/lib/python3.8/site-packages/kea_exporter-0.4.1-py3.8.egg/kea_exporter/cli.py", line 22, in cli
  File "/usr/lib/python3.8/site-packages/kea_exporter-0.4.1-py3.8.egg/kea_exporter/kea.py", line 506, in update
KeyError: 'cumulative-assigned-addresses'

Then we could apply the same ignore rules to the per subnet metrics. Can you try this?
diff --git a/kea_exporter/kea.py b/kea_exporter/kea.py
index decc023..031af0e 100644
--- a/kea_exporter/kea.py
+++ b/kea_exporter/kea.py
@@ -485,6 +485,14 @@ class KeaExporter:
                         subnet_id = int(match.group('subnet_id'))
                         key = match.group('metric')

+                        if kea.dhcp_version is DHCPVersion.DHCP4:
+                            if key in self.metrics_dhcp4_ignore:
+                                continue
+                        elif kea.dhcp_version is DHCPVersion.DHCP6:
+                            if key in self.metrics_dhcp6_ignore:
+                                continue
+                        else:
+                            continue
                         try:
                             subnet = kea.subnets[subnet_id]
                         except KeyError:

Yes, that resolves the issue. Thanks!


Fix: Security for recovery phrase

Summary (Please recap what you changed or fixed)

Related task: #257

Checklist (If you won't pass this checklist please comment why)

[ ] I removed all commented or unnecessary code.
[ ] Provide the screenshots due to UI changed or bug fixed
[ ] My code has covered these test cases (please list down your tested cases):

@hoailinh1210 User can copy phrase without reveal , please help to move the copy button outside sensor section

@hoailinh1210  Please apply reveal for viewing secret key as well

Hi @djhahe , I updated all our feedback,
Please help me review on it, thanks  👍


v3.0.0

fixes #93
fixes #91

This PR solves issue #93
With a few adjustments to my example as noted in the v3 branch's examples directory both audio and video playback seem to work fine via MediaElement. I am also able to put the video's waveform in a separate div using the container option for wavesurfer.
Thanks a ton @thijstriemstra !

Coverage decreased (-7.6%) to 73.106% when pulling da519115c89e5aed9349e47fa2eb3eb97e87243b on v3 into 27256c55373c709e274b7fa1ee18163d90c635f6 on master.

Support for MediaElement backend is fixed now. WebAudio backend (i.e. the original implementation of videojs-wavesurfer) is next.

. I am also able to put the video's waveform in a separate div using the container option for wavesurfer.

if you can improve the video example in this branch like that, help is always welcome @ybinnenwegin2ip

TODO: how to distribute/enable the middleware in the plugin, see https://github.com/videojs/video.js/issues/6311


Bump Pitest version to 1.4.10

Changelog since 1.4.6:
1.4.10

Smaller blocks for more precise test targeting (thanks @jon-bell)
Fix A0D2 map key (thanks @Vampire)
Escape characters in init methods for html report (thanks @Vampire)
Filter junk mutations to compiler generated Objects.requireNonNull calls

1.4.9

Fix for powermock issues on (thanks @jon-bell)
Improved error message when no test plugin (thanks @szpak)
Support annotation processors such as Micronaut that do not set debug filename

1.4.8

Fix for bug in coverage when large number of classes (thanks @jon-bell)
Avoid stealing keyboard focus on macos (thanks @maxgabut)

1.4.7

Faster coverage calculation (thanks @jon-bell)

Replace by PR #107


Cannot run in CUDA10.0 + cuDNN

Before I install CUDA10.0 and CUDNN I can still use it. After install CUDA,it will crash each time i use.Error Tips is " cudaSuccess (10 vs. 0)  invalid device ordinal".Plz fix it, thx!

Did you rebuild torch7 for CUDA10? and installed a GPU driver that supports CUDA10?

invalid device ordinal

This error occurs when the GPU device cannot be used from CUDA.

I just fix the problem of drivers
But after I fix it I still cannot use it normally, then I use NVIDIA Nsight to check all the process that waifu2x used, and I found that all the process in GPU was not use my GTX1070 (GPU No.1) at all, it use my GPU No.0 (Intel UHD 630), which is inside my CPU.
But before run this programe I already set using GPU No.1 ... I dont know what happend.

I just solve the problem right now
I set GPU No.0 and it work ... doesnt it mean GPU number in Windows Task manager？

If you are using code from this repository, use the -gpu 2 option.
Even with other software, there is probably an option to specify the GPU ID to use.
GPU ID has 1 origin(start from 1) and 0 origin(start from 0) depending on the software.

Thanks help me solve the problem!!(^▽^)


Implemented head tail modifier that works on multiple scope types

take head funk
clear tail pair
Fixes #623
Checklist

[x] I have added tests

Performed git surgery.  Original branch at https://github.com/cursorless-dev/cursorless/tree/bak/headTail; feel free to delete if this branch looks ok

The problem with that approach is that we want to be able to say things like head that or tail air. My point is that it's not just modifiers that can be proceeded by head or tail. We even have the implicit one take head
Another option is that instead of storing it in the targets themselves the pipeline could have that information in the context maybe?

No the trailing modifier is optional, and defaults to "line". So "take head" will still be valid

Okay that is what you mean with the question mark.

Right sorry yeah couldn't remember the syntax without a talon file in front of me so just fell back to regex 😅

No problem I understood that as soon as I grasped your intention :)
I will give it a try!

The one thing to think about is what happens if they say something like "head every key". We may want to infer "head line every key"?

Maybe. Maybe we should leave that one for now and try it out first?

@pokey This implementation I think is more to your liking :)

By the way now we are actually free with the ordering. If we want we could have take funk head instead of take head funk


Low flow metrics and regions

The PR computes low flow metrics and regions using a similar method as is used for high flow metrics and regions.
Low flow metrics for each flow magnitude include: duration, frequency, volume, and minimum flow for events less than or equal to the flow threshold, and the volume for events greater than the threshold.
A set of targets is also made for those same metrics except the volume for events greater than the threshold.
There are sites whose quantiles are 0 flow (intermittent streams). For these sites, the seasonal (fractional) flow volume less than the threshold is computed as the number of events per season instead of flow volume per season. The minimum flow fraction is assigned equally to all seasons in which 0 flows occur.
All metrics are rounded to 3 decimal places. Some sites have quantile magnitudes that are separated by < 0.001, so the tabulated magnitude metric has the same value for several quantiles. The other flow metrics were computed from the un-rounded magnitude values.
I think we can retain all sites with 0 flows for clustering as a result of their other metrics being non-zero. It could actually help to know if a site has several quantiles with the same value because it indicates the intermittency of the flows at that site.
Edits:
Calc_FDC - added the threshold_type argument to specify if metrics are to be computed for low (below) or high (above) the specified threshold. Other edits address quirks to handle low flows, and function and parameter descriptions.
seasonal_metric_cluster - added fixed = TRUE to grep so that 0.005_ would not be grabbed when using 0.5_ as the pattern. Also added function and parameter descriptions.
EDA_metric_plots - I added 3 arguments to generalize the function to work for low flow quantiles. Also added function and parameter descriptions, and mode format edits.
Calc_HIT - added function and parameter descriptions

After these edits, the p6 predict targets were all not outdated, so that confirms that the edits I made to functions to handle low flows did not affect the high flow metric values.
It seems like as a result of random seeds between Charlie's run (on which this PR is built) and Sara's run (most recent previous predict commit) we now see different results for the testing in rain region (training for all of CONUS is better than training in only rainfall dominated). That reinforces a known gap of needing to run several replicates (random seeds) for each predict target and compare their RMSEs considering the sampling uncertainty.


Host Name is substituted with wrong value when server is configured only with bind attribute.

For reference -
https://github.com/Terracotta-OSS/terracotta-configuration/issues/96.

TDB-3333 for reference. ClusterTool configure command use to fail because we were not storing correct host address for tc-config in which server is configured with only bind attribute.

@myronkscott could you review this PR?

We don't need this change.


[REQUEST] Output a list of authors for a search

For the search option it would also be super useful to have an option to output a list of de-duplicated authors for all the matching tweets (lowercase ideally) together with follower counts and any other stats about them you are able to obtain.

@hudmb Can you give me an example of how you would want this outputted?

Thanks for elaborating @hudmb
That'd be easy to implement

Hi @hudmb ,
it depends on how deep you want to go.
Options:

write a "post-processing" tool to load scraped tweets from saved files (not so good);
store in RAM the authors of every tweet and filter them out (good way).

While the first case is quite easy, in the second case might not be.
You could create a new function in twint/output.py that's called from _output, this would pass obj arg to your new function, and that stores in a global variable the obj.username attribute, then this new function would do some kind of remove-duplicate-authors.
When the whole scraping process is done, call from twint.run.Search a function that writes to a file (unique for every search) your unique_list_of_authors

Usage
import twint

c = twint.Config()
c.Search = "something here"

twint.run.Search(c)

author_list = twint.output.author_list


Fix Some Broken Bookmarks

Fixes #23396

@wadepickett  finish what you have. This is ultra low priority and your #26477 is ultra high priority.

I understand the priority. See your calendar.  Thanks.


Crash in ListView when using sections

Today I encountered a difficult to understand crash when one ListView was pushing to another View (in this case another ListView but I don't that is related).  In the detail view an action was performed which would cause a Section to be removed from the Parent view on next render.  SwiftUI really did not like this and crashed are at @main with an unhelpful stack trace.
Only through trial and error and vague recollection of encountering this before did I fix this by ensuring no sections are added or removed by child views of a ListView.

Spent some time trying to reduce the problem and there must be something more subtle about than I can easily find.  I thought this would reproduce the problem but it turns out to run as expected.
import SwiftUI

@main
struct AppMain: App {
    var body: some Scene {
        WindowGroup {
            ItemsView()
        }
    }
}

class Store: ObservableObject {
    @Published var isVisible = false
}

struct DetailsView: View {
    @EnvironmentObject private var store: Store

    var body: some View {
        VStack {
            Text("Visible: \(store.isVisible ? "Yes" : "No")")
            Button("Toggle") { withAnimation { store.isVisible.toggle() } }
        }
    }
}

struct ItemsView: View {
    @StateObject private var store = Store()

    var body: some View {
        NavigationStack {
            List {
                Section(header: Text("Items")) {
                    Text("This section is always visible")
                }
                if store.isVisible {
                    Section(header: Text("Optional Section")) {
                        NavigationLink(value: "details", label: { Text("Details") })
                    }
                }
            }
            .toolbar { Button("Toggle") { withAnimation { store.isVisible.toggle() } } }
            .navigationDestination(for: String.self) { _ in DetailsView() }
        }
        .environmentObject(store)
    }
}

I'll continue to add comments to this issue as I gather more information.


[.NET] Turkish Numbers (Percent) support

Follow up to #1653.
9 passes 2 skips.
Issues:

negative percentage, "-5%" actual "5%"

Explanation of modified localization:
NumberWithSuffixPercentage can only be used with a (Num+Suffix)(Percent+Suffix), e.g. 210'un yüzdesi (per cent of 210). However, "yüzde 210" has the same meaning and more common than "210'un yüzdesi". Also, "yüzdesi" is mostly used as "percentage" and used with nouns more frequently than numbers, e.g. "kütle yüzdesi" (meaning "mass percentage").

Hello @tellarin, this is ready for review.


Rich diagnostics extension

What thinking has previously been done here? The OASIS SARIF technical committee has released a public draft of a common interchange format for transporting rich diagnostics results. This format can include complex paths through functions, associated data state at specific thread flow locations, graph representation/traversals of code, stack-based reporting, as well as simple, user-facing string diagnostics.
This format/mechanism is particularly useful for tools that run out-of-band due to the costs of analysis. For these scenarios, it is interesting to think about an end-to-end results management protocol that would allow an editor to 'connect' to a result store or otherwise associate a sidecar repository of results with code that is currently under development. The end-to-end lifecycle of a diagnostic pulls in other complex topics such as bug filing, annotating results as false positives, won't fix for other considerations (such as a tool firing against test code), or as low quality (the result is not actionable, is poorly described, etc.).
Discussed previously? I've looked in issue history and haven't uncovered any obvious prior conversation.
https://github.com/oasis-tcs/sarif-spec/

@michaelcfanning thanks for the pointer. No, we never discussed that spec in the LSP land. One thing to keep in minds is that the LSP is a UI driven protocol not a program structure driven protocol. So for diagnostics we added information that is usually presented to a user in the UI and no information that will allow a client to interpret the diagnostic. This is basically true for all the results returned from a LSP server.

I am very interested a protocol for connecting analysis tools, results managers, and viewers. We have been working with @michaelcfanning on a viewer for SARIF in VS Code.
I think there's an opportunity to incorporate SARIF in LSP in a way that would allow LSP clients to present more static analysis results. For example, @michaelcfanning mentioned "code flows." These are expressed as a sequence of code regions, which are expressed using offsets in source files --- which I think is similar to LSP. SARIF also uses JSON, though unfortunately the code regions are expressed slightly differently.
If diagnostic reports could include SARIF (or at least code flows) they be visualized in LSP clients, as we're demonstrating in our VS Code plugin. That's one example. There is plenty of other interesting information in SARIF.
I think down the road, we will want a "Static Analysis Server Protocol (SASP)" that cannot be a simple extension to LSP. For example, an LSP server seems more like a plugin than a true server that can have multiple simultaneous connections. Still, maybe SASP could use LSP as a subcomponent, or maybe making a client that handles LSP+SARIF would be a stepping stone to making a client that handles SASP?
Perhaps a demo of the SARIF viewer would be helpful?

Repeating a bit of David's content here. SARIF as a format is intended to help drive rich UI experiences for the range of static analysis results. And so, as David notes, this might include packaging path-through-function data that helps illustrate a presumed code path through a function that leads to a quality problem. An editor such as VS Code might usefully colorize source files to help drive investigation. As another example, some tools may persist stack information as part of a diagnostic. For this case, an IDE such as visual studio might populate its stack window and enable a navigate-to-code experience on clicking an individual frame - again, in support of investigation a potential quality defect.
The examples above are strictly UI/viewer experiences. We have a SARIF Visual Studio add-in that represents a start on providing useful investigation capabilities. We have a SARIF VS Code extension for the same scenario.
There is an interesting broader scenario to consider whether we can codify a protocol for managing a store of static analysis results, that might be consumed by multiple clients simultaneously, who are attempting to push these results through their disposition life-cycle (i.e., trying to investigate issues, drive fixes for true positives, permanently suppress false positives from future consideration, etc.). This life-cycle could be very complex, entail filing work items, drive an exception process for ignoring a security relevant concern, attempt to kick off a rerun of a tool to verify whether a proposed fix succeeds.
Based on David's post and the above, I wonder what your feedback is? Where are the limits of what might make sense here to address via a proposed LSP extension? Where are the clear limits you perceive in LSP's purpose that would argue for defining something altogether separate (a SASP as David has termed it).

I think there's an opportunity to incorporate SARIF in LSP in a way that would allow LSP clients to present more static analysis results.

As an implementor of an LSP client, I don't think there is need nor wish for more structured complexity so far, and I'd rather not have to implement this complex standard in the default LS client.
However, I think it would be interesting for experimental purpose at the moment to try SARIF in some LSP servers/clients. Rather then using the default textDocument/publishDiagnostics and Diagnostics elements, you could create a language server which would also include operations such as sarif/publishDiagnostics, sarif/codeFlow... and extend the clients to also support and use those new elements.
I think that as long as there are no good examples of SARIF working on multiple LSP servers and clients, the integration cannot be perceived as mature enough and the value as high enough to standardize it in LSP. If after some successful demos there is a wider interest in SARIF from the LSP community, then it can be considered as an "official" extension in the spec, or even have dedicated elements integrated in the model.

we will want a "Static Analysis Server Protocol (SASP)" that cannot be a simple extension to LSP. For example, an LSP server seems more like a plugin than a true server that can have multiple simultaneous connections.

That's I think where things diverge with LSP. As @dbaeumer mention, the LSP is UI-based and doesn't really care about what's happening under the hood: is this compilation, is this parsing, is this static analysis, is this dynamic analysis, is this test execution, is this just someone in the internet typing content and annotating your code on the fly... It simply thinks in term of what you want to show your user while editing code in the general case.
I think static analysis fits very well in LSP if you want to render the results as diagnostics, quickfixes, hovers, completion...
So if you want the LSP to serve SARIF better, rather than focusing on the format of the SARIF content and put in in the LSP, it would be more interesting to consider what kind of UI you need to express SARIF results to the end-user in an IDE and what's missing in LSP to express this UI.
SARIF could be a way to do a language server (basically one could create a LS that can turn any SARIF report into a set of LSP concepts to user and this would be generic). As far as I understood so far, SARIF is a technology that would make more sense in the language server implementation side than in the protocol or in the client.

I think there's an opportunity to incorporate SARIF in LSP in a way that would allow LSP clients to present more static analysis results.

As an implementor of an LSP client, I don't think there is need nor wish for more structured complexity so far, and I'd rather not have to implement this complex standard in the default LS client.
However, I think it would be interesting for experimental purpose at the moment to try SARIF in some LSP servers/clients. Rather then using the default textDocument/publishDiagnostics and Diagnostics elements, you could create a language server which would also include operations such as sarif/publishDiagnostics, sarif/codeFlow... and extend the clients to also support and use those new elements.
I think that as long as there are no good examples of SARIF working on multiple LSP servers and clients, the integration cannot be perceived as mature enough and the value as high enough to standardize it in LSP. If after some successful demos there is a wider interest in SARIF from the LSP community, then it can be considered as an "official" extension in the spec, or even have dedicated elements integrated in the model.

we will want a "Static Analysis Server Protocol (SASP)" that cannot be a simple extension to LSP. For example, an LSP server seems more like a plugin than a true server that can have multiple simultaneous connections.

That's I think where things diverge with LSP. As @dbaeumer mention, the LSP is UI-based and doesn't really care about what's happening under the hood: is this compilation, is this parsing, is this static analysis, is this dynamic analysis, is this test execution, is this just someone in the internet typing content and annotating your code on the fly... It simply thinks in term of what you want to show your user while editing code in the general case.
I think static analysis fits very well in LSP if you want to render the results as diagnostics, quickfixes, hovers, completion...
So if you want the LSP to serve SARIF better, rather than focusing on the format of the SARIF content and put in in the LSP, it would be more interesting to consider what kind of UI you need to express SARIF results to the end-user in an IDE and what's missing in LSP to express this UI.
SARIF could be a way to do a language server (basically one could create a LS that can turn any SARIF report into a set of LSP concepts to user and this would be generic). As far as I understood so far, SARIF is a technology that would make more sense in the language server implementation side than in the protocol or in the client.


x/tools/go/analysis/unitchecker: export output JSON schema and include SuggestedFixes

Currently the unitchecker offers a JSON (via the -json flag).
The schema of the JSON output is not documented and the output does not contain SuggestedFixes. I propose to document the schema and include SuggestedFixes in the output. I think it is reasonable to export the position information as filename and byte offsets for start and end into the file. The end is exclusive (similar to the AST representation).
The implementation for the JSON output is here. Exporting and extending it should solve this issue.
I have not yet checked in detail if this is used by other code as well.
It might make sense to flag protect the new output to not break existing tools that rely on the output without SuggestedFixes.

cc @timothy-king @zpavlinovic

Including SuggestedFixes in json output seems like a good idea to me.
If possible it would be preferable to not add another flag, but we should do at least a preliminary investigations of tools that use -json to confirm whether these are backwards compatible. Based on what the investigation finds, we can choose whether we can safely add a flag or not.


Develop: Add functionality to add notification subscription with the chatbot

As a user, I want to be able to add a notification subscription using the chatbot.
Acceptance Criteria

Chatbot accepts a command for adding a notification subscription with a keyword.
Chatbot can add a notification subscription based on the input.
Document any relevant content in the Programmer guide (draft thoughts of usage and importantly the "Why")
Updates SRS and STP (and other docs if necessary)
Add/Update relevant unit tests

tested on android

tested on iPhone

tested on iPad

tested on android virtual device

Verified - Test PASS


[v1.15] helm: Add validation to prevent users from using deprecated values that have been removed

I've seen a few users who upgraded from v1.14 to v1.15 and encountered issues because they were still using the tunnel: disabled, and upon upgrading to v1.15, they suddenly found themselves using vxlan. In many cases, the upgrade proceeded but cilium failed in unexpected ways due to other configuration options being used that are incompatible with vxlan, such as the hybrid loadbalancer mode. An example of such an issue came up in this slack thread: https://cilium.slack.com/archives/C1MATJ5U5/p1722983084876839
To prevent these sorts of issues when upgrading, let's add some validation that fails the helm install/upgrade entirely if the user is specifying an option that was once previously valid, but has since been removed.
helm: Add validation to prevent users from using deprecated values that have been removed

We've added helm schema validation in v1.16 so I don't know if we need this for everything in v1.16, however a small test reveals using options that were removed in v1.16 also encounter this issue. Based on https://docs.cilium.io/en/v1.16/operations/upgrade/#helm-options when I try using the first options that were removed in v1.16, nothing fails:
helm template cilium/cilium --version v1.16.0 --set proxy.prometheus.enabled=true --set proxy.prometheus.port=1234

I can do another PR for v1.16 to address this. My question is: do we want to keep the validations for the options in v1.15? I know users are supposed to not skip minor versions when upgrading, but it might be a good idea to cherry-pick this to v1.16 and add additional validations for the options that were removed in v1.16. What do people think?

/test

/test-backport-1.15

Am I correct assuming that this will filter down into v1.15 via regular backport of https://github.com/cilium/cilium/pull/34229 ?

Am I correct assuming that this will filter down into v1.15 via regular backport of #34229 ?

If we wanted to, we could do it that way, but I basically forward ported this to main since I wasn't sure if people would agree on keeping the v1.15 validations v1.16/main. At the moment #34229 is only marked to be back ported to v1.16 since I opened this separately.


dev_start.sh error on TX2

Hi there,
When I run
bash docker/scripts/dev_start.sh  on TX2,
I got this error:
[INFO] Start pulling docker image apolloauto/apollo:dev-aarch64-20170927_1111 ... dev-aarch64-20170927_1111: Pulling from apolloauto/apollo Digest: sha256:10fc9daa7699f30650df05b9f3aff9762a236433e089e8755dcb0f6cfb7baab0 Status: Downloaded newer image for apolloauto/apollo:dev-aarch64-20170927_1111 Cannot find device "can0" Cannot find device "can0" modprobe: FATAL: Module nvidia not found in directory /lib/modules/4.4.38-tegra modprobe: FATAL: Module nvidia-uvm not found in directory /lib/modules/4.4.38-tegra Error response from daemon: manifest for apolloauto/apollo:localization_volume-aarch64-latest not found Unable to find image 'apolloauto/apollo:localization_volume-aarch64-latest' locally docker: Error response from daemon: manifest for apolloauto/apollo:localization_volume-aarch64-latest not found. See 'docker run --help'.
Any help? Thanks.

Sorry that I have no experience on this platform. It looks like the script is not intelligent enough to locate dependencies automatically.
As it's not referenced hardware by Apollo, unfortunately we don't have bandwidth to support trouble shooting for it by now. Please kindly share with us if you got any progress :)

@Zoltan3057  As far as I know. The arm version docker has not been updated since last year. While the X86_64 version is changing fast. The docker architecture is much different than the initial version. The pre compiled dependencies has been divided into separated docker data volumes(yolo3d, localization, map data). Also, there is no latest version Apollo Platform( Apollo ROS) for ARM.  Because of lack of these dependencies, Apollo on ARM may not full featured.
With this in mind, If you still want to run Apollo on TX2, I would suggest you :

Build the latest version Apollo Platform (Apollo ROS), which may need a little changes for build (there is a PR issue61 for that).  And put it in to docker. This is my build  apollo-platform-2.1.2_aarch64.tar.gz (ubuntu 16.04) passcode: dvtm
Remove the pull docker volumes procedure from dev_start.sh script.   (This may cause the related feature not to work, since there is no ARM version pre compiled dependencies / caffe , they will never work on ARM platform for now.)
Copy the all bazel dependent source tarball into docker.  You may need to build some of them manually.    You also may need to do some trick to make it possible to install debs inside docker(that docker does not have sudo installed by default, so just copy it from the host would work.)
Execpt the moules which are not supported from bazel build.

You will finally get dreaview working if you're lucky  :P

@Zoltan3057 I met the same error, have you solved it?

@zombiiee I couldn't figure it out ,so  I just purchase a new IPC with x86 version. You can find some information on this website
https://mp.weixin.qq.com/s/KEdXmwUGHysy_LZAfdkmlw
Good luck!

@zhxt thanks for you detailed reply.

@zhxt I am also trying to build apollo 2.5 on jetson tx2, is there any step-by-step guide or off-the-shelf bash scripts can help? Thanks.

@yang-le I didn't write all the steps down. But you can follow with what I said in the early comment. If you have any questions, catch me at #apolloaudo Channel on freenode IRC.

@zhxt hi,I am trying to build apollo2.0.0 on TX2
/apollo/modules/common/BUILD:31:1: undeclared inclusion(s) in rule '//modules/common:apollo_app':
this rule is missing dependency declarations for the following files included by 'modules/common/apollo_app.cc':
'/apollo/ros/include/ros/ros.h'.
how to solve the proble ? 3Q

@263868161 As I already said, you need to install Apollo ROS(apollo-platform) first.
For 2.0 , you can follow this post wrote by Mr. Huang.

@zhxt I have already performed the following steps:

cp -a ros/include/* /usr/include/.
2）cp -a ros/ /home/tmp/ros
and ros from  apollo-platform-2.1.2_aarch64.tar.gz ,but build the apollo project
/apollo/modules/common/BUILD:31:1: undeclared inclusion(s) in rule '//modules/common:apollo_app':
this rule is missing dependency declarations for the following files included by 'modules/common/apollo_app.cc':
'/apollo/ros/include/ros/ros.h'.
what happed?

@263868161 not sure，maybe there is a broken link under /apollo .

@263868161 You may need docker cp ros_aarch64 apollo_dev:/home/tmp/ros to put ros to the right place.
nvidia@in_dev_docker:/apollo$ ls /home/tmp/
benchmark-1.1.0.tar.gz  curlpp-0.8.1.tar.gz  gflags-2.2.0.tar.gz  googletest-release-1.8.0.tar.gz  modules_data         proj.4-4.9.3.zip       qp-oases-3.2.1-1.zip  tinyxml2-5.0.1.zip
civetweb-1.10.tar.gz    eigen-3.2.10.tar.gz  glog-0.3.5.tar.gz    libconsolve.tar                  opencv-<IP_ADDRESS>.zip  protobuf-3.3.0.tar.gz  ros                   yaml-cpp-0.5.3.zip
nvidia@in_dev_docker:/apollo$

@zhxt I work with @263868161 , we had met this issue for few days, we have folder ros/ in /home/tmp/, but the issue isn't soluted. Do you have another proposal?Thank you very much!

@263868161 From the error log, it seems that it tried to find ROS header file in a wrong directory "/apollo/ros/", not "/home/tmp/ros", so please check this. Maybe there a duplicated "ros" directory inside the source code director? Not sure.
Also, I made a docker image for tx2 that contains the most dependencies(but there are still some additional work need to be done by yourself, like nvidia driver, cuda, etc. NOT fully tested.), it can be pulled with:
export DOCKER_REPO=zhxt/apollo &&  docker/scripts/dev_start.sh  -t dev-aarch64-comminity-20180621_2330

NOTE: You also need a patched version dev_start.sh  to pull the image and some other patches to pass the build.
NOTE 2:  This docker image is just for learning or technique validation, try at your own risk.

@263868161 From the error log, it seems that it tried to find ROS header file in a wrong directory "/apollo/ros/", not "/home/tmp/ros", so please check this. Maybe there a duplicated "ros" directory inside the source code director? Not sure.
Also, I made a docker image for tx2 that contains the most dependencies(but there are still some additional work need to be done by yourself, like nvidia driver, cuda, etc. NOT fully tested.), it can be pulled with:
export DOCKER_REPO=zhxt/apollo &&  docker/scripts/dev_start.sh  -t dev-aarch64-comminity-20180621_2330

NOTE: You also need a patched version dev_start.sh  to pull the image and some other patches to pass the build.
NOTE 2:  This docker image is just for learning or technique validation, try at your own risk.

@zhxt Thank you very much!!!

Closing this issue as it appears to be resolved. Thank you @zhxt :)


stepper version???

good day i am enjoying this info you share!
i have experience with steppers and power systems through
3d printing and cnc, this is the first sim rig i am building
i am building a sim wheel myself but want to use a double 3nm nema 23 beqause i have them lying around with open loop drivers,
for power i use 4 350 watt hp server psu's in series so 48 volt, otherwise the nema 23 are to slow
costing €20 euro per 10 pieces here
but can i use open loop system with an hall encoder you are using on the steering shaft? the steppers are going to be belt drive 1:4 so i have 24 nm at max, having a little reserve power is wished so the motors don't need to maxxed out and burn..
regards giel

Sorry, I think I do not understand your question well.
If you want to use stepper in sim wheel controller as feedback motor - I doubt it can be done easily.
I actually tried that once with disappointing results.
Usually, you can control stepper rotating speed and direction. When there's no control signal, it's standing still.
And it IS still - one almost cannot turn stepper's shaft by hand when it is powered.
So, who needs a sim wheel which only turns by itself, but cannot be turned by hand?
I tried to enable/disable stepper at high frequency, and also lower stepper's current. It somehow helped, but caused stepper to jerk a lot. It was unusable and I did not experiment further.
Of course, you can experiment yourself, but I cannot help with that.
At least, you will need to replace BTS7960 with stepper driver, and rewrite motor handling code to work with this driver.
"hall encoder" (I suppose, you mean TLE5010 or AS5600?) is merely a rotation angle sensor and have nothing to do with feedback motor.

from the 3 d printing systems i always have the position the stepper is moved to
then it stays powered to prevent the moving when an other stepper is running ( the z axis height) is always holding position beqause otherwise it could fall down..sort of standby current ist is adjustable from 10 to 80% typically using 25..
my thoughts where change the pwm signal into a step /dir signal but as i read it isn't that easy..
i also have closed loop drivers but they will always move to the commanded position so i think this couldn't be used eighther or do you think it will?
i was thinking stepper motors are more rigid than dc.. i have a big wiper motor and a starter motor from a truck.. but if you put force on it i was thinking it would burn out in a very short time or am i afraid for nothing?

ill work it out thanks

of course dc motor can burn if it is powered and blocked (stalls). I suggest to use external current limiter, or power source that will not exceed stall current of motor.

thinking about another thing,is it also possible to add 10 potentiometers more on it for brake balance etc etc,i am building a full f1 wheel made the wheel itself in carbon/glass fiber when ready i can pull a mold from it so i can duplicate them for 30/50€ 80/100€ including pedalbox and steer base with room for a screen on the base or the steer itself,ill include a picture from the frontplate ( remember it is in the rough!!!)

You mean add 10 additional axes? No, there is a limit of 8 axes per generic controller.
But simplest solution is to use additional controller. a ProMicro with MMJoy2, or STM32F103C8 with FreeJoy firmware will allow to add 8 axes/128buttons more. If game/sim can use such number of axes, it will defininely work with multiple controllers.

thankyou!!


Fixes #3234. ProcessContinuousButtonPressedAsync is always passing the start location.

Fixes

Fixes #3234

Proposed Changes/Todos

[x] WindowsDriver
[x] EscSeqUtils used by CursesDriver and NetDriver.

Pull Request checklist:

[x] I've named my PR in the form of "Fixes #issue. Terse description."
[x] My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
[x] My code follows the Terminal.Gui library design guidelines
[x] I ran dotnet test before commit
[ ] I have made corresponding changes to the API documentation (using /// style comments)
[x] My changes generate no new warnings
[x] I have checked my code and corrected any poor grammar or misspellings
[x] I conducted basic QA to assure all features are working

@tig do you want I do a R# cleanup code on this PR?

@tig do you want I do a R# cleanup code on this PR?

No. Once you address my review comment we can merge this.


fix: ssg compatibility

This PR fixes the SSG with this plugin. (always renders  currently).
BTW @JohnCampionJr, if you don't mind, can I have the access to this repo and the npm publish right (handle antfu)? I can help with maintaining this package as it's upstream of Vitesse. Thanks.

Hi @antfu - added you to both.  Can we make the ssr example separate from non-ssr, like in vite-plugin-pages?

Thanks a lot!

Can we make the ssg example separate from non-ssg

SSG is more like an addition, the dev server would be the exact same. I think it's not worth to duplicate the example and double the maintaining work, WDTY?


Add BorderRadius for EyeStyle and DataModuleStyle, gradient, cutout of image embedded, background shape embedded image

do you really have to import package:flutter/material.dart in types.dart just to use Colors.black?

thank you for addressing the review so quickly!

wow very nice! thank you

up

up

@vanyasem What's preventing this from being merged? The proper image cutout alone makes the result look much more professional.

LGTM!!!

@vanyasem why this update is still not merged?

@Hilbert2048 because I am just a random contributor, and not a maintainer of this project. I do not have write access to this repository, and thus I cannot merge this PR :)
You need to contact the actual maintainers of this repo by email<EMAIL_ADDRESS>

I think @lukef might have the write permission, would you please have a look at this pull request?


Not doing anything in Radarr or Sonarr[BUG]

Hey,
I like the program, it has gone through all of my libraries and found about 150 problems.
I have the list, so I can do delete them and had then sonarr and radarr will go find new ones (if I have those files monitored), but I thought this program did that automatically.  If so, I can't figure out how to get it to work.  The webui is working, and I see the list there.  I don't get any errors.  And right now I'm just exporting it to a .csv and manually deleting.  Many thnaks!
Here is my config.
checkrr:
checkpath:
- "d:/media/movies"
- "d:/media/Movies (Spanish)"
- "d:/media/tv shows"
- "d:/media/TV Shows (Spanish)"
- "e:/media/movies"
- "e:/media/Movies (Spanish)"
- "e:/media/tv shows"
- "e:/media/TV Shows (Spanish)"
- "g:/my drive/media/movies"
- "G:/My Drive/Media/Movies (Spanish)"
- "g:/my drive/media/tv shows"
- "g:/my drive/media/TV Shows (Spanish)"
database: ./checkrr.db
debug: true
logjson: false
ignorehidden: true
csvfile: "./badfiles.csv"
logfile: "./checkrr.log"
ignoreexts:
- .txt
- .nfo
- .nzb
- .url
arr:
radarr:
process: true
service: radarr # should be one of: sonarr radarr lidarr
address: <IP_ADDRESS>
apikey: "redacted"
baseurl: /
port: 7878
ssl: false
#mappings: # maps directories between docker and arr services
#"/mnt/user/Movies/": "/Movies/" # what radarr sees: what checkrr sees
sonarr:
process: true
service: sonarr
address: <IP_ADDRESS>
apikey: "redacted"
baseurl: /
port: 8989
ssl: false
mappings:
#  "/mnt/user/tv/": "/tv/"

webserver:
port: 8585
baseurl: "/"
trustedproxies:
- <IP_ADDRESS>

hey, a couple of questions:

what does the log file say about sonarr and radarr?
what version of sonarr and radarr are you running?

hey, a couple of questions:

what does the log file say about sonarr and radarr?
what version of sonarr and radarr are you running?

Let me investigate.  the only log I see in the checkrr.log file are these 2 entries at the top.  Everything else is just the results from ffprobe.  is there another log file, or something I have to enable to get more logging detail?
time="2024-07-04T00:19:48-05:00" level=info msg="Sonarr Connected." Sonarr "sonarr" Connected=true Startup=true
time="2024-07-04T00:19:48-05:00" level=info msg="Radarr Connected." Radarr "radarr" Connected=true Startup=true
Versions:
sonarr <IP_ADDRESS>5
radarr <IP_ADDRESS>5

Thank you for your quick response and your time!
Troy

sonarr 4.x and radarr 5.x aren't currently supported: https://github.com/aetaric/checkrr/issues/81

sonarr 4.x and radarr 5.x aren't currently supported: https://github.com/aetaric/checkrr/issues/81

Ok.  Sorry I missed that.
Does checkrr still run on to identify the corrupt files?

Yeah, it works without sonarr and radarr integrated, it just can't tell them fetch replacements if the version is too new.

closing as duplicate


vesktop launching under xwayland

Describe the bug
vesktop is lauched under xwayland instead of  native wayland, i assume this is a bug as it works when launched via terminal
Version
latest git build
Minimal Config
{
  "list": {
    "height": 500
  },
  "search": {
    "placeholder": "Search"
  },
  "switcher": {
    "prefix": "/"
  },
  "ui": {
    "anchors": {
      "bottom": true,
      "top": true
    },
    "fullscreen": true,
    "width": 800
  },
  "websearch": {
    "prefix": "?"
  }
}

To Reproduce
Launch vektop with walker
Expected behavior
I expect vesktop to launch under wayland, I have the NIXOS_OZONE_WL=1 env var set
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop

OS : NixOS
DE Hyprland

Can't reproduce on Arch, i suspect an issue with your systems config.
echo "--enable-features=UseOzonePlatform --ozone-platform-hint=auto" > ~/.config/vesktop-flags.conf

Ran Vesktop via Walker. Uses Wayland, confirmed by hyprctl clients.

i'd say it's more a system specificity eventually more than an issue with my system config. I don't have the problem with wofi for example.

Well, but you don't run wofi as a service. I assume your walker instance doesn't get the ozone config from nix in time.

that's it, still wierd tho, service should be ran after user connection, and env var is set on system start

Closing as it's not an issue with Walker.

So i got my answer, because it is a service ran by systemd, walker as a service will never get any environment variable. it will always get them from systemd, but systemd as first process is never started with env var
I do think though this will not only be a nix problem, only difference i guess is that many people use flags instead

Yeah, always keep in mind that systemd-services are not really meant to be used to autostart gui applications, which walker is. anything around them will be funky.


Sticky top and bottom

how i can make header sticky top and footer sticky bottom?

Remove relative class from header and add this classes sticky top-0 z-10
before
<!-- Navbar -->
<header class="relative bg-white dark:bg-darker">

after
<!-- Navbar -->
<header class="sticky top-0 z-10 bg-white dark:bg-darker">

and add to footer this classes sticky bottom-0 z-10
before
 <!-- Main footer -->
 <footer
     class="flex items-center justify-between p-4 bg-white border-t dark:bg-darker dark:border-primary-darker"
 >

after
 <!-- Main footer -->
 <footer
     class="flex items-center justify-between sticky bottom-0 z-10 p-4 bg-white border-t dark:bg-darker dark:border-primary-darker"
 >

thanks


修复中文文档参数显示不全的问题

修复了下列api中文文档参数显示不全的问题
paddle.nn.functional.elu
paddle.nn.functional.hardsigmoid
paddle.nn.Hardswish

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Early termination fee is not in effect for any reservation at the mom…

…ent.
RI team answered as follows.
https://portal.microsofticm.com/imp/v3/incidents/incident/503723461/summary
Ashok Chhilar
Submitted at 2024-05-17 06:55:34 GMT+9
Early termination fee is not in effect for any reservation at the moment.
++++++++
Best Regards,
Jun Tokizawa<EMAIL_ADDRESS>

@JunTokizawa this change is being made in another PR that will merge later this week. Thanks for your contribution.
#please-close


Latest version of accelerate generates error

venv/lib/python3.10/site-packages/accelerate/utils/modeling.py", line 1415, in infer_auto_device_map
current_max_size = max_memory[device] if device != "disk" else None
TypeError: 'NoneType' object is not subscriptable
=> solution accelerate==1.1.1

Locate the brushnet_nodes.py script in the custom_nodes\ComfyUI-BrushNet directory, search for sequential, and replace it with balanced_low_0.


Design User-Centric Interface for Stockist Music Discovery and Creation

This issue focuses on crafting a user-centric interface for Stockist, a music generation platform targeting content creators. The UI should prioritize:

Efficient Music Discovery:  Content creators need an intuitive way to find high-quality royalty-free music that aligns with their specific content needs (e.g., genre, mood, video type).
Seamless Music Creation:  The UI should provide a smooth workflow for music generation and basic customization using Stockist's functionalities.
Freemium Model Implementation:  Design a user interface that effectively integrates a freemium model, showcasing the value proposition of both free and premium tiers.
Success Criteria:
Users can effortlessly discover music that matches their content requirements.
Creating and customizing music within Stockist feels intuitive and efficient.
The freemium model is clearly communicated, enticing users to explore premium features.
Next Steps:
Conduct further user research (if needed) to understand content creator workflows and pain points related to music discovery and creation.
Develop wireframes or mockups to illustrate the proposed UI concepts.

Here's a further refinement of the Stockist UI based on your latest input:
Client Input & Dynamic Toolkit:

Top Toolbar:  Maintain the fixed toolbar at the top of the page.
First Row: Input Field:  The first row remains dedicated to the text input field where clients describe their music desires, ask questions, or provide feedback.
Dynamic Tool Kit:
Second Row: Interactive Tool List:

Heading: The second row will have a heading that suggests tools relevant to the current musical direction.  This suggestion can be dynamically generated by Stockist based on the conversation.
Interactive List:  Below the heading, implement a vertical list of buttons representing the current "kit" of available tools.  Each button will display:

Tool Title:  A concise title that clearly identifies the tool's function.
Tool Description:  A brief description that explains the tool's impact on the music.  This description can appear upon hovering over the button.

Expanding Tools:  Clients can click on any tool button to expand it. The expanded view can display:

Detailed Description:  A more comprehensive explanation of the tool's functionality and potential outcomes.
Customization Options (Optional):  Depending on the tool, the expanded view might offer sliders, menus, or other UI elements for clients to adjust specific parameters.

Multiple Tool Expansion:  Clients can expand any number of tools simultaneously, allowing them to explore different options and compare their potential impact on the music.
Tool Reordering (Optional):  Consider allowing clients to drag and drop the tool buttons within the list to sort them according to their preference.  This can be helpful for organizing their "kit" of frequently used tools.
Stockist Response:

Following the Tool List:  The area below the dynamic tool list will display Stockist's response in a markdown-like format.  This ensures a clear and readable presentation of Stockist's generated music descriptions, suggestions, or feedback.
Benefits:
Enhanced Context:  The heading with suggested tools provides additional context for the client, guiding them towards relevant options for their music creation journey.
Flexible Exploration:  Clients have the freedom to expand and explore multiple tools simultaneously, allowing for a more in-depth understanding of their functionalities.
User-Organized Workflow:  The optional tool reordering functionality empowers clients to personalize their workspace and prioritize frequently used tools.
Clear Communication:  The markdown-like format for Stockist's responses maintains readability and clarity.
Additional Considerations:
Collapsible Tool Expansions:  To prevent overwhelming the UI, consider implementing a system where only one tool can be fully expanded at a time.  Clients can collapse and expand different tools as needed.
Visual Cues:  Provide visual cues to indicate expanded tools and any potential interactions within the expanded view.
Search Functionality (Optional):  For a large number of tools, a search function within the tool list can be helpful for clients to quickly find specific options.
By incorporating these refinements, we create a user-friendly and adaptable UI for Stockist.  The dynamic tool kit empowers clients to explore and utilize various music creation tools while maintaining a clear workspace for collaborative music creation.


content security policy is incorrectly configured correctly for the new URL

See ui/src/frontend/index.ts:setupContentSecurityPolicy, and various errors in chrome dev tools when loading magic-trace.org. The site still mostly works, but we should clean this up.

Fixed by #10


return a Result from Task functions

Tasks must be converted to return GooseTaskResult.
This allows the use of ? as it supports returning a GooseTaskError:
pub type GooseTaskResult = Result<(), GooseTaskError>;

Currently we define 3 errors:
/// Definition of all errors Goose Tasks can return.
#[derive(Debug)]
pub enum GooseTaskError {
    /// Contains any possible Reqwest library error.
    Reqwest(reqwest::Error),
    /// The request failed.
    RequestFailed,
    /// The request was canceled (this happens when the throttle is enabled and
    /// the load test finished).
    RequestCanceled,
}

One thing:
I’d leave one example where we explictly call the debug_log — we optimized it away from all examples unless I miss something.

There was a commented out debug println!() in drupal_loadtest, which I converted to a commented out call to log_debug, along with a comment explaining why it's useful (if you're editing the load test).


CVE-2024-24790

The latest temporalio/admin-tools, temporalio/server and temporalio/ui images are using a version of Go that is impacted by CVE-2024-24790.
Updating Go to 1.21.11 or newer would fix the issue.

Thanks for reporting this! The latest temporalio/admin-tools, temporalio/server and temporalio/ui images are using a version of Go that is impacted by CVE-2024-24790.
You can fix this by updating Go to 1.21.11 or newer.

Thanks for reporting this!  This is a known issue. Please review the Temporal Security page for updates and mitigation recommendations.

Thanks for reporting this!  It's a known issue and is tracked in the following Temporal issue: https://github.com/temporalio/temporal/issues/3984.
Until it is fixed, you can update to a newer version of Go that is not impacted by this vulnerability.


Detox init using Yeoman

@noomorph please describe what you think should be the scope here (preferably, that is feasible within the timeframe...)

Refactor → all things that detox init does currently, they should stay the same but under Yeoman's umbrella.
Add logic to mess with android/ folder if it roughly follows the structure of RN boilerplate project:

add DetoxTest.java
maybe add CustomJUnitRunner
add paths to APKs
add clearTextTraffic things, etc.

@noomorph can this be merged with https://github.com/wix/Detox/pull/2512?

@d4vidi, I guess so. Basically the same goal there and there. Mind that this is an issue, and #2512 is a PR 😄

True that! So maybe we ought to change the title, etc.?


"ls" returns different sort order, incorrect results for subdirectory listings.

In a recent commit, ls began changing the order in which results are returned.
I use ls --all --human-readable --color -l.
With GNU ls, results are returned in this order:
$ /usr/local/opt/coreutils/libexec/gnubin/ls --all --human-readable --color -l
total 8.0K
drwxr-xr-x  6 kevin staff  192 Dec  7 12:09 .
drwxr-xr-x 84 kevin staff 2.7K Apr 15 15:01 ..
drwxr-xr-x 15 kevin staff  480 Apr 30 11:02 .git
drwxr-xr-x 24 kevin staff  768 Apr 28 14:28 Formula
-rw-r--r--  1 kevin staff  136 Nov 25 13:45 Makefile
-rw-r--r--  1 kevin staff 1.7K Dec  7 12:09 README.md

With coreutils ls, results are returned with ".git" in the middle of "Formula" and "Makefile", which seems incorrect.
$ ls --all --human-readable --color -l
drwxr-xr-x  6 kevin  192 Dec  7 12:09 .
drwxr-xr-x 84 kevin 2.7K Apr 15 15:01 ..
drwxr-xr-x 24 kevin  768 Apr 28 14:28 Formula
drwxr-xr-x 15 kevin  480 Apr 30 11:02 .git
-rw-r--r--  1 kevin  136 Nov 25 13:45 Makefile
-rw-r--r--  1 kevin 1.7K Dec  7 12:09 README.md

If I call ls on a subdirectory, the top level "." is replaced with the directory name, in a way that makes me think there is a subdirectory of "Formula" named "Formula". It doesn't make sense.
$ ls --all --human-readable --color -l Formula
drwxr-xr-x 24 kevin  768 Apr 28 14:28 Formula
drwxr-xr-x  6 kevin  192 Dec  7 12:09 ..
-rw-r--r--  1 kevin  473 Nov 25 13:45 aws-vault.rb
-rw-r--r--  1 kevin  561 Apr 12 10:27 benchstat.rb
-rw-r--r--  1 kevin  928 Mar 11 22:21 bump_version.rb

Again this differs from the behavior of GNU ls:
$ /usr/local/opt/coreutils/libexec/gnubin/ls --all --human-readable --color -l Formula

total 96K
drwxr-xr-x 24 kevin staff  768 Apr 28 14:28 .
drwxr-xr-x  6 kevin staff  192 Dec  7 12:09 ..
-rw-r--r--  1 kevin staff  473 Nov 25 13:45 aws-vault.rb
-rw-r--r--  1 kevin staff  561 Apr 12 10:27 benchstat.rb
-rw-r--r--  1 kevin staff  928 Mar 11 22:21 bump_version.rb

Regarding the order of the files, the change was made intentionally to match GNU, so now I'm a little bit confused

Difference in sort order is most likely due to locales.
$ LC_COLLATE=en_IN ls -1
aa.A
AAb

$ LC_COLLATE=en_US ls -1
AAb
aa.A

for what it's worth, here are my LC settings
$ env | grep LC
LC_TERMINAL_VERSION=3.4.4
LC_TERMINAL=iTerm2
LC_CTYPE=en_US.UTF-8
LC_ALL=en_US.UTF-8

@cbjadwani @kevinburke Thanks! That makes sense. Maybe it's best to revert to the C locale then until we get around to implementing locale-specific sorting. This would be:
❯ LC_ALL=C ls -al                                                                                09:18:22
total 12
drwxr-xr-x  3 terts terts 4096 May  1 09:16 .
drwxr-xr-x 15 terts terts 4096 Apr 30 13:35 ..
drwxr-xr-x  2 terts terts 4096 Apr 30 21:23 .git
-rw-r--r--  1 terts terts    0 Apr 30 21:23 Formula
-rw-r--r--  1 terts terts    0 Apr 30 21:23 Makefile
-rw-r--r--  1 terts terts    0 Apr 30 21:23 README.md
-rw-r--r--  1 terts terts    0 May  1 09:16 formula


Non-Substantive changes per recommendations

Non-substantive changes as recommended here https://github.com/KristjanESPERANTO/MagicMirror-3rd-Party-Modules/blob/main/result.md#MMM-PGA-by-mumblebaj
I also cleaned up the documentation a bit.  And I swapped the filenames and README references of two images so that the more representative picture will show up in the module list.
The @KristjanESPERANTO also recommends:

Replacing node-fetch and XMLHttpRequest with the built-in fetch function
Adding an ESLint configuration
Making the LICENSE file and the license description in package.json consistent

I'm not entirely sure what rotateInterval actually does.  Is that a refresh interval?  Nothing is rotating in my setup.  A bit more description in the README on this would be useful.
One of the suggestions was to change a reference to require('request') in node_helper.js to the built-in fetch function.  As far as I could tell, this function was never used, so I just removed it entirely.  I tested it, but you may want to double-check.

This has taken on some substantive importance since the release of the latest MagicMirror version n 4/1/24.  The program complains about the request function, and will not start.  Seems to work ok with the fork I updated to remove request.


AttributeError: _data

installed and i wrote GoogleScraper -h
then i got this message
AttributeError: _data
ubuntu 20.04

installed and i wrote GoogleScraper -h then i got this message AttributeError: _data
ubuntu 20.04

i too:(

Successfully installed sqlalchemy-1.3.0
I fix it through changed the version of sqlalchemy.


do not print "Scheduling 0 handled"

unless settings.DEBUG is on, so that it's less noisy for less busy nodes.
I personally prefer not to print it at all regardless of DEBUG, but assume it was there for a reason?

It was mostly there so you could tell if Stator was alive when there were more async issues - I agree it makes sense to flag it behind DEBUG!


Fix release tag on README

Changed it with shields.io's version.

Codecov Report

Merging #3945 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3945      +/-   ##
==========================================
+ Coverage   20.26%   20.27%   +0.01%
==========================================
  Files         146      146
  Lines       29316    29316
==========================================
+ Hits         5942     5945       +3
+ Misses      22472    22470       -2
+ Partials      902      901       -1

Impacted Files
Coverage Δ

modules/process/manager.go
73.91% <0%> (+4.34%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d0ac7...1e31a37. Read the comment docs.


vue cli with getstorybook - sample "MyButton.vue" addon-action can't work

I have used vue cli to generate my project and init storybook by "getstorybook".
I found the basic sample MyButton.vue has no react with click event to show in action log.
I have searched the vue way to use addon-action in stroybook example but can't work.

which project template do you use when running vue cli?

It can look like this:
import { storiesOf } from '@storybook/vue';
import { action } from '@storybook/addon-actions';

import MyButton from './MyButton';

storiesOf('Button', module)
  .add('With action', () => ({
    template: '<my-button :handle-click="log">Click me to log the action</my-button>',
    methods: {
      log: action('log1'),
    },
  }))

I believe the project generate by vue-cli and init "getstorybook" which's add-action log has no react with the sample MyButton by click.. the sample use @click and methods, here you use prop $emit vue way. Neither can't work.

Can you please upload your project to github as a repo?

sure, https://github.com/sky790312/storybook-test
it's just set up by vue-cli and getstorybook

Seems like Vue events are not working, to make the action work you need to send it as a prop and execute it inside the component :/

Looks like MyButton.vue lacked $emit: https://github.com/sky790312/storybook-test/pull/1. I will add that fix to #1867

got it! there will be a little confuse to use @click and $emit together for vue developer, just a remind.

Why? https://vuejs.org/v2/guide/components.html#Using-v-on-with-Custom-Events

Sorry, forget that.
I mean..I see :handle-click="action" (<- it's prop) In some sample code.
It should use @handleClick="action" to $emit back parent element.

Code with :handle-click assumes that MyButton declares the corresponding prop, I just took that from examples/vue-kitchen-sink

Yes, I think it should be
@handleClick="action"
then in parent method 'action' trigger the addon-action

You mean that child should $emit('handleclick') instead of $emit('click')? But it's just a matter of naming, isn't it?

Alternatively, you can use a prop, like this: https://github.com/storybooks/storybook/blob/master/examples/vue-kitchen-sink/src/stories/Button.vue

I think we are discussing different things, the issue is clearify now.
never mind.  Sorry for my poor expression. lol

Looks like this is relolved


zwave renaming is now a mess in 0.63

Before 0.63 you just added a node. Renamed it. Restarted and the entity was renamed and all of the zwave sensors of this node were renamed as well. As an example. Take fibaro dimmer 2 and rename it to zwave_entrance. Before we then got
light.zwave_entrance
sensor.zwave_entrance_alarm_level and so on.
Now the renaming doesn't take place. Instead in the entities (/dev-state) it shows up as light.level with the following data
light.level	off	node_id: 15
value_index: 0
value_instance: 2
value_id:<PHONE_NUMBER>32331009
old_entity_id: light.zwave_entrance_level_15_0_2
new_entity_id: light.zwave_entrance_level
friendly_name: zwave_entrance Level
supported_features: 33
Although it does display correctly in the frontend. But looking at the sensor entities - complete mess
light.level:
platform: zwave
unique_id: 15-xx
sensor.unknown:
platform: zwave
unique_id: 15-xx
sensor.alarm_type:
platform: zwave
unique_id: 15-xx
sensor.alarm_level:
platform: zwave
unique_id: 15-xx
light.fibaro_system_fgd212_dimmer_2_level:
platform: zwave
unique_id: 15-xx
Seems this is due to the new entity_id engine introduced recently @balloob  ?

Yeah, once the entites are added to the new entity registry, renaming the zwave node does not update the entity IDs.
Technically, that's why the entity registry exists, so the entity_id's stay the same. But this behavior is not optimal for zwave devices when you are first adding and naming a device. Not sure what the best way to correct it would be. Maybe a checkbox on the rename node option to regenerate entity_ids?

A checkbox sound great!

Is there any workaround for the moment? Manual renaming? Please post solution here
[https://community.home-assistant.io/t/renaming-zwave-nodes-after-0-63/43434](HA forum)

From an entity perspective this is working as intended. We are giving the same entity id each time. To change the registered entity id, you can update the entity_registry.yaml file.
Adding a checkbox to regenerate entity ID is also a good idea👍

IMO the Rename Node service needs updated to interact with the entity registry correctly (no tick box - it should just work). Requiring people to know to enable a tickbox so that the service works is likely to lead to (more) frustration and confusion.

I ran in to this issue a short while ago and couldn't figure out why the old entity name was being used in some places (e.g. automation triggers, services dev tools) and the new entity name was being used in other places (e.g. HA dashboard). An option to regenerate the ID, or even automatically updating the ID would be extremely useful.
https://community.home-assistant.io/t/home-assistant-using-previous-entity-id-for-automations-after-device-rename/43570

Totally agree on @KingJ  Hopefully a PR can be made soon enough. I just can imagine the struggle of new comers when they will be presented with such overwhelming name scheme

There's already been two threads on the forum in the last half day where people have been confused by this and struggled with renaming their Z-Wave devices.

@DubhAd it shouldn't be done automatically. You change the name, not the identifier.

^ from an end-user perspective that's the same thing.
Example: Fibaro multisensor - has 7 or so sensors. I rename the node to 'kitchen'. Clearly I expect the sensors to now be called sensor.kitchen_motion and sensor.kitchen_temperature.
That's the only reason to rename the node in the first place, as zwave.kitchen for the device makes no difference whatsoever for automations or anything.

Indeed, until I sought help on the forums I had zero idea why my device had been renamed in one place (e.g. the main dashboard was showing the new entity ID), but automations were using the old ID.
I've found Home Assistant in general to be a pretty user-friendly platform - the documentation is good and a lot of functionality is naturally intuitive. This unfortunately hasn't quite been the same. At no point in the Z-Wave renamer was there any opportunity for me to know that I also had to rename the identifier in the Entity Registry, and from the dashboard's perspective everything was using the 'renamed' entity ID (quite literally, if you were to click on a component on the dashboard, the entity ID listed is the 'renamed' one, not the identifier contained within entity_registry.yaml - as per my post linked above).
I can appreciate that there's still a lot planned for the Entry Registry, but right now it is not at all clear to the majority of users that you need to update the Entity Registry if you rename a device and want to use the new name for it. The inconsistent display of the entity ID after a rename only further adds to this confusion - from my perspective I had renamed the node, and the dashboard was showing the 'renamed' entity ID - I didn't have any reason to think otherwise that the 'renamed' entity ID displayed on the dashboard was not the one I needed to use if I wanted to reference that component in an automation. I had no way of knowing the difference until I went in to the Services Dev Tools, and even then it wasn't apparent as to why the old entity ID was there.
To improve this i'd personally think one of the following would be appropriate for most users - and preferably the first option;

Provide a checkbox on the Z-Wave rename screen to optionally also update the Entity Registry for that node (enabled by default).
Provide a clear warning on the Z-Wave rename screen that this only renames the node and that the the old name will still be used in the Entity Registry.

Additionally, it could be useful to surface the Entity Registry's Entity ID when viewing the component's details on the dashboard. A lot of users 'discover' the entity ID from here that they then use in an automation - so if the entity ID on the dashboard is different from the Entity Registry's Entity ID, that can become rather confusing.
(Hope this hasn't come off as overly negative - I love HA overall but unfortunately at the moment this particular area is at odds with the rest of HA, which is in general really intuitive and user friendly)

I completely agree with @mf-social
Even fibaro dimmer 2 exposes 10+ enitites.
So let's say somebody decides to switch to HA from OH2 with 10+ of those dimmers.
100+ enitities to play around and rename manually figuring out which one is which. That sounds like a lot of fun. Really :)

@balloob This change fails the POLA check since it changes the existing behaviour completely. It's also an undocumented breaking change.
Either Rename Node needs to interact with the registry, or it needs to be removed. What we have currently is the worst of both worlds - a service that achieves nothing, but used to change the entity id and according to the documentation still does.

Not sure if it is related but since 0.63 also hiding some z-wave sensors by using the checkbox is broken.

You know the more I think about it.  The more I wonder if Rename Node just needs to be removed.  Upon further inspection the zwave entity itself is missing from entity_registry.yaml.  Based on what Entity Registry is supposed to do for the end user we should make sure those entities show up there right?  All renaming should be done in 1 place to make things easier for the user.

... Which begs the further question:
Should devices that spawn multiple entities have a different type of entry in the entity registry? Maybe tiered somehow?
As was pointed out earlier, somebody with 10 Zwave devices should only have to change 10 things, not 70 - 100.

@dshokouhi definitely it shouldn't be removed. Yes 10+ entities are needed as they are different sensors and calling them out through attributes in automation will be more complicated. Those are my 5 cents.

@dshokouhi IMO the best solution is to integrate it with the entity registry, so that Rename Node causes the entity IDs to be updated, as they were before 0.63.
Failing that, yes, it should be removed so that people aren't confused as to why it's only changing a couple of attributes, and the default friendly name. What we've got now is just confusing people, there's not a day that goes by where we're not seeing multiple posts in the forum or Discord about this.

If this is a 'component that is still in development phases', it should NOT have broken the old way until such time that everyone could transition away, or we had fully documented, or capable ways to manage the entities.
You broke the usability of adding zwave devices without so much as a notice in the release notes, and with no documentation on this new method.  This is a breaking change and should have been noted as such.

I made all necessary changes in entity_registry.yaml when I updated to 63.x version and automation worked until I updated to 64.0. Updated to 64.1 but it did not help. I had ZWave switches to turn off in 10 minutes. I also tried to use old IDs and new IDs, but the automation still does not work.

I was able to fix the problem. I opened Automation page, selected the automation for switches and clicked on save button. It modified the code a little and works now.

I'm new to this platform but have had a zwave network in my house for a few years.  I've been getting hassio up and running in an effort to migrate away from a Vera controller (which has its own issues).  I finally got the onboard Zwave controller on my PINE64+ up and running last night and started to add devices today.  After I got to about 5 devices, I realized that renaming them wasn't working.
So (having come from another ZWave system) that the ability to rename devices as they're added to the network/system is a critical path item.  Without that (relatively) basic capability, zwave functionality is too impaired to be attractive.  Whether there's a way to manage it without linking the process into entity_registry.yaml, I couldn't say.  But either way, removing the functionality from the front-end should be a non-starter.
And I'd probably pay someone for my 2 cents worth...

I've just moved my zwave network ono HA, the hard way. Rename node is changing the root, and I can change entity names in entity_registry.yaml, although I have to wait for zwave config to write it into the file, and it is time consuming.
So I'd very grateful for the renaming to be automatic.
For many of my devices, I had to create a customize record too, or a template device (eg battery level).
I'd like to keep in mind that some of these changes coild be solved with a device class template: for any zwave device with class X, template X will be used to change the entities.
Then anything device specific can be done in customize, eg template lights for certain switches should be for one-off fixes, changing on/off behaviour, etc, weigh we'd have a lot less to do.

  You can use Rename node to rename the root node, and then click the save config button to have it write to the zwave config file.   Then stop hass and delete all of the old entries out of the entity_registry.yaml for that node.  If you keep the file in version control, it's a little easier to find the new ones that were added.
After you delete the old entries and restart hass, it should name everything with the prefix of what you named the root node.

@justyns for this suggestion. I have been battling with getting an automation to work for days having used the new entity from the panel. I eventually worked out what was going on from the logs and have my automation working but finding the entities to use customise and hide the ones not needed on my door sensors is time consuming and messy, this suggestion at least keeps the naming conventions sensible.
I’ve found homeassistant to be very easy to configure in general but this is just plain broken imho. The disconnect between the new entity id and the registry entry is not immediately obvious, I’m no coding expert but I’ve been around and this has been extremely frustrating with 3 zwave devices.
A simple warning statement on the z wave page should suffice to let people know whilst a more elegant solution is developed.
It’s probably because HA is so good and so well documented elsewhere that this is so frustrating.

I was tracking this issue, but it seemed unactive. So today I had a couple of hours to spare and decided to give it a go. I upgraded from 0.61.1 to 0.66.0.
I got an error stating that I had to remove the new_entity_ids setting from the config, so I did. And everything worked out of the box. So have any secret improvements been made that we are unaware of?
As expected an entity_registry.yaml has been created but I haven't modified it in any way.

Presumably you already had your entity ids set? That's not the problem. The problem is if you add a new device now, you'll need to go through the entity registry and change all the individual ids.

Hmm, then I'll have to wait until I have to do that. Ik can remember that everything zwave-related was broken when I upgraded to 0.63. So I just assumed it was this issue. I'll update once I've added a device.

There's a further (probably related) issue. Every time I have been adding a new node, all of the existing nodes have lost their disabled_by property. Names seem to be ok.

@Timple The removal of the new_entity_id value was mentioned in the 0.66 breaking changes (https://www.home-assistant.io/blog/2018/03/30/release-66/#read-more). Any questions about that are best kept to the forum ;)
@reevery Best to open a new issue about that, because even if it's related, it's not what this issue is about.

I just want to echo the above comments that this behavior is infuriating...I couldn't figure out why renaming my Z-Wave nodes was no longer renaming the entities attached to them. In the Z-Wave config, it shows my new name, but the entities listed on the dev-state page are still the old names. I spent a long time digging through forums threads and eventually arrived here.
Look at this example. This Z-Wave motion sensor used to be called "OfficeMotion". I renamed it to "PlayroomMotion" using the Z-Wave control panel, saved, and restarted HA. This is what Z-Wave CP shows:

NOTE THE LIST OF "ENTITIES OF THIS NODE". Specifically the binary_sensor.PlayroomMotion Sensor.
Then I go over to the device list and binary_sensor.playroommotion_sensor is nowhere to be found. Instead, I still have the old binary_sensor.officemotion_sensor. I also still have the zwave device with the original name, zwave.officemotion, although it now shows a friendly name of Playroom Motion...that's not helpful:

So basically, there's now inconsistency between what the Z-Wave control panel shows as the attached entity names for a z-wave device and what entities ACTUALLY exist. And, the Z-Wave node renaming feature is essentially pointless.

What a disaster - why would we release a breaking feature labeled "experimental" without the ability to make it optional.  Had I not already been a (fairly) experienced HA user and encountered the issues association with adding a new device post-implementation of the entity-registry, I would have given up on HA.  This situation needs some serious attention, and sooner rather than later.

This issue has all but ended my efforts on the platform unfortunately.  I
got my outdoor lights running and have control over the environmental
assets in the house, but everything else is DOA.
[image: Mailtrack]
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&
Sender
notified by
Mailtrack
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&
06/21/18,
11:45:38 AM
On Thu, Jun 21, 2018 at 11:31 AM LeapFrogSupport<EMAIL_ADDRESS>wrote:

What a disaster - why would we release a breaking feature labeled
"experimental" without the ability to make it optional. Had I not already
been a (fairly) experienced HA user and encountered the issues association
with adding a new device post-implementation of the entity-registry, I
would have given up on HA. This situation needs some serious attention, and
sooner rather than later.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/issues/12430#issuecomment-399145459,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYHs3cj5xIYZXZasEkS4qjY_iPT0LfSbks5t-7xpgaJpZM4SGp8w
.

The easiest way I've found to work through this is to remove the entries of any renamed devices from entity_registry.yaml and restart hass.  Maybe there should just be a re-build registry button in the z-wave config page which will update all entity id's, or possibly a list with checkboxes to only re-build selected items.

@timpeq : I'm missing the point. what does that do?
Until now I'm sticking to 0.62 while I'm building my home setup. Renaming works like a charm but of course this is not sustainable. I would like to understand your workaround a bit better...

@edwinvandalen In my case when I was trying to rename zwave switches an entity id was not changing until I removed all entries of the zwave and associated switch in the entity_registry they were created with the proper names.

ah, so the workaround process would be to

backup the entity_registry
include a new z-wave device (which puts default names in the entity_registry)
rename the new z-wave device (which does not modify the entity_registry
replace the entity_registry with the backup
restart hass

?

These days I usually do the following:
Include new zwave device
Rename zwave device
Rename zwave device and all other related entities in device registry
Restart home assistant
This leads to all names being changed and only requires a single restart. This is for sure not how it should be but I guess until the rename process is fixed we will have to deal with this.

So here we are, 6 or 7 months later, and the entity registry concept has still not been fully reconciled with the Z-wave feature set. I don't know enough about the inner workings of this to help, or even who to tag in here other than @balloob, but this is really a disaster and needs some attention. Z-Wave, although not the new sexy thing on the block, is still used extensively, and this stuff needs to work.

Did you tried the new feature to rename entity_id through UI?

Is this even a bug still?  You can still rename things, just not the way you did in the past. There is nothing that you could do before that you can't do today.  Every zwave entity ID can be renamed.  Just not from the zwave panel.  Please tell me otherwise if that is the case but renaming nodes is not a "mess" there is just a new process to follow (regardless of it having more steps)  Also as @awarecan pointed out you can now rename directly from the UI.  So what features in 0.63 are missing from 0.75?

Yes, you can use the UI to go find and change your entity names once you can find the right ones. The situation still exists where if you rename a Z-wave device from the Z-Wave control panel, it shows a set of entity names that don't really exist (see comment from June 19). That, at bare minimum, is a bug. The zwave entity itself (zwave.*) also doesn't reflect the new name of the z-wave device, and I would argue you would expect it to.
So there is no obvious or intuitive link between the two features, or what steps you're supposed to follow if you want consistency between your renamed Z-Wave devices and the entities associated with them. It's extremely confusing, and it took a lot of digging and troubleshooting to figure out what was going on. If someone renamed a bunch of z-wave devices at once, it would be a lot of work to trace down what HA entities are associated with which z-wave devices, since the entity list UI shows the old zwave.* name. So yes...I would still say a mess.
Someone else suggested something along the lines of having a way from the UI to clear out entity registry items associated with a z-wave device as part of the z-wave renaming process. Not sure what other ramifications that might have, but it sounds like a possible solution.

I agree it's still confusing at best. My suggestion:

Every device (Z-Wave or other) gets an unique identifier, which might not be very human-readable (e.g. based on MAC, Z-Wave Node ID etc). This is already provided by the Entity Registry.
Z-Wave customization is removed, everything is performed using Entity Registry and Customize (which should maybe be merged to one concept?)
Add location property to entities. I assume this makes for at better integration with Google Assistant, and removes the need to include the location in an entity name.
Entity IDs would be built up as .[_].
An Entity Management page, showing all entities as tiles or similar, with key properties (identifier, entity name, friendly name, hidden/ignored, location, all other customized properties) displayed for all entities at once, giving possibility to efficiently edit every entity without navigating away from the page.

The Z-Wave node renaming is going to be removed from the Z-Wave control panel. There should only be one way of doing things and that is via the entity registry which supports both name and entity ID renaming.

Hello. Can I ask the dummy question: why is that you need to do special convention for z-wave (ex: the "location" proposal two comments above)? Why not extending the solution to every other types or devices (ex: rfx auto discovered entities? they also are not human readable).
My opinion is that a node should be renamed easily with custom defined convention (I may or may not add the location on my devices, dependending on my need), but sure it should resist to removing/adding the same device. At the end we should have:

internal z-wave id (and other type), probably never displayed to the user (do not see the need). It probably derives from the z-wave node id.
z-wave name: "slug" that could be customized for whatever reason by the user
friendly name: what will be displayed on the UI.

I still use Domoticz for Z-wave management (I only have sensors) + mqtt, its UI is really helpful (and have some cool stuffs). Hope to switch z-wave to HA soon to discontinue domoticz completely. But damned it's easy to deal with z-wave devices with DZ !

How to change the node name now? This was much easier before. Did just use rename node in zwave control panel and delete the entity registry and all of the new devices with sensor etc was created with the correct name on next reboot. including in the zwave device list.

You can literally open the entity_registry file in a text editor still and find->replace the entity_ids. It's not really that difficult. Just make sure HA is shut down when you save the changes. I've never understood deleting everything when you can almost as easily find->replace them and have complete control over them.

Yes did try that. But it did not update the names in the Zwave controll panel list. Just on everything else. But did not stop HA, so maybe that was the problem. Need to have the correct name in the zwave control panel to when I have 6-7 identical devices.
Why not just options? Is it very difficult to have the rename node button in the control panel for Z wave?

The developers have stated (more than once) that they won't automatically change the entity_id of related devices because the entity_id of the "root" changed. Similarly changing the name displayed in the UI of the root won't change anything else.
There is a device concept coming that will mean that Z-Wave is no longer the odd one out. This will also introduce UI changes to manage these. As these start arriving in the beta releases the best thing to do is to provide constructive feedback.

Work by manually updating entity_registry.yaml, as long as the nodes names are unique.
Fun fact: some entities wasn't show for some reason. Removing options.xml zwcfg_*.xml zwscene.xml files and restarting home assistant fixed the issue.
"device" concept seems similar to the devices in domoticz. 1 device can provides n entities. And basically every entities are linked to a device. Not sure if it should also be the case for Home Assistant. But in domoticz it was a mess to deal with virtual devices to add our own custom entities. Each time a new virtual device would need to be created first (to retrieve its id).
For z-wave management it seems like device would be mapped to "node".