Unable to send command switches to Jest Runner.

Summary
SFDX LWC Test Runner not respecting -- to send commands to the next command mismatching what npm run and lwc-jest does.
This works, for instance:
npm run test:unit -- -- --ci --reporters=default --reporters=jest-junit
Steps To Reproduce:

Run sfdx force:lightning:lwc:test:run -- -- -- --ci --reporters=default --reporters=jest-junit

Expected result
Jest runner is informed that is running on Continuous Integration, should run default reporter and JUnit reporter.
Actual result
Error: Unexpected arguments: --, --ci, --reporters=default, --reporters=jest-junit
Additional information
SFDX CLI Version:
sfdx-cli/7.47.0-0e5d18732f darwin-x64 node-v10.15.3
SFDX plugin Version:
@oclif/plugin-autocomplete 0.1.5
@oclif/plugin-commands 1.2.3 (core)
@oclif/plugin-not-found 1.2.3 (core)
@oclif/plugin-plugins 1.7.9 (core)
@oclif/plugin-warn-if-update-available 1.7.0 (core)
@oclif/plugin-which 1.0.3 (core)
@salesforce/lwc-dev-server 1.0.10
├─ @oclif/plugin-help 2.2.0
└─ @oclif/plugin-update 1.3.9
@salesforce/sfdx-trust 3.0.7 (core)
analytics 1.7.1 (core)
generator 1.1.2 (core)
salesforcedx 48.2.0
├─ @salesforce/sfdx-plugin-lwc-test 0.1.5
├─ salesforcedx-templates 48.3.0
└─ salesforce-alm 48.3.0
sfdx-cli 7.47.0 (core)
OS and version:
macOS Catalina 10.15.3 (19D76)

@jefersonchaves I have notified the team that owns this command and they are taking a look

The command force:lightning:lwc:test:run is really for simple use cases. You should continue to use lwc-jest directly for more complicated scenarios as you are doing with your test:unit script.

Hi @ntotten
I'm not sure if my use case is really considered a complicated scenario because all it is doing is telling jest to run continuous integration mode and setting up two reporters. I think this is pretty common use case for Continuous Integration.
Would you consider adding native flags for running sfdx force:lightning:lwc:test:run in Continuous Integration environment?


2 consecutive parallax layers

Hi,
I am trying to add 2 consective parallax layers but it seems to break things.
No error in the console.
Is it possible to do it? If not which would be the best alternative?

It is possible, but it requires some tweaking (at least set a proper z-index to actually display the parallax-layers in the correct stacking order), and the effect is not always great.
Can you tell me more about what you are trying to achieve, maybe share some code?

Sure - basically I am trying to use it along the polymer starter kit (PSK) - with as few modifications as possible on the PSK - I got a basic demo working - I'll push it today and send you the link!
Thanks

This #1 issue was actually related to PSK, and I explained there how to properly integrate parallax-element.
You can find a working (although a bit dated) implementation here : https://github.com/vguillou/vguillou.github.io/tree/master/examples/PSK_with_parallax_layers
I probably will add a link to this on the main Readme very soon.


error AL1024: A package with publisher 'Microsoft', name 'System', and a version compatible with '<IP_ADDRESS>' could not be loaded.

Questions at the end in bold.
After upgrading a NAV 2017 database to NAV 2018, I tried to deploy my extensionv2 app to the server following instructions on (https://docs.microsoft.com/en-us/dynamics-nav/developer/devenv-how-publish-and-install-an-extension-v2).
After issuing the Publish-NAVApp command from within the NAV 2018 Admin Shell I got the following error:

Publish-NAVApp
: Extension compilation failed
error AL1024: A package with publisher 'Microsoft', name 'System', and a version compatible with '<IP_ADDRESS>' could not be loaded.

It then went on to list all of the objects (standard objects that the extension references) that could not be found.
The publish works OK for the clean CRONUS install, so we knew it was something to do with the database we had upgraded.
I set the “Enable loading application symbol references at server startup” property to ticked on the server instance and ran the finsql.exe Command=generatesymbolreference
This seemed to remove all the errors relating to the standard application objects but it did not fix the problems with the system tables.
In the end, I solved my problem by taking these two files from the CRONUS database (by using VS Code to download the symbols) and then manually re-deployed the standard application app packages back to the upgraded DNE database using the following commands:

Publish-NAVApp -ServerInstance MyServerInstance -SkipVerification -PackageType SymbolsOnly -Path "C:\NAVApps\Microsoft_Application_11.0.19394.0.app"
Publish-NAVApp -ServerInstance MyServerInstance -SkipVerification -PackageType SymbolsOnly -Path "C:\NAVApps\Microsoft_System_11.0.12925.0.app"

This then allowed me to publish my app without errors.
My questions are: Did I do something wrong in the database upgrade that resulted in these standard apps being missing? Is there a better way of getting these standard app symbols added to the database? Should this be added to the database conversion instructions?

It doesn't sound like you did something wrong.
What you are missing are the symbol files used when compiling Extension v2 apps.
You can read more about it here, and especial take a look at task 18 where you populate your database with the right symbols.
https://docs.microsoft.com/en-us/dynamics-nav/upgrading-the-data

Thanks, that makes sense.


Add cd workflow for uploading new releases to PyPI

When a release is made, the continuous deployment action will upload it to pypi.
I can add you all to the pypi list of maintainers- it is currently pending

Looks successful: https://pypi.org/project/spurt/


Implement spread out retries

Currently, if a job fails it will be immediately queued for retry. This is appropriate in some but not all circumstances. For example, if a third-party API is down for a few hours, retrying the job immediately would cause it to be retried many times before permanently failing. It would be better to spread out the retries over time. E.g. the first retry is immediate, the next one is 15 minutes later, the next one is 1 hour later, etc.

I think your looking for exponential backoff.
http://en.wikipedia.org/wiki/Exponential_backoff

@albrow would you accept a pr to fix this?
We're running into this in production as we use api's with unreliable uptime especially on weekends. A ton of jobs are failing and we have to manually go restart them.
I think it would require a adding a parameter to the schedule and scheduleRecurring functions. This would be a breaking change. But to avoid these in the future we could switch it to accept a schedule struct instead. This way you could add options without breaking things in the future.

@epelc I'm not going to have time to implement this anytime soon, but I would be happy to review a PR for it :) Couldn't we make this a field (or fields) of PoolConfig with some sensible default values to make it a non-breaking change?

@albrow I think that'd work well if you have a single job type or they are all similar. But if your hitting different apis it'd require separate pools then.
I think we could get away with the pool config in our app but I'm not sure how others are using this. If you have a lot of different job types it might be problematic. Let me know your thoughts though. I'll do either one.

Hmm... as I understand it, one of the great things about using exponential backoff is that it handles a variety of failure conditions pretty well. For example, it will handle both cases where there was a temporary, one-time failure and in cases where e.g., a service is down for the weekend. I think this is why  delayed_job, a popular ruby gem which I drew some inspiration from, doesn't let you tweak the exponential backoff parameters. My opinion is that we should add one or two parameters to PoolConfig for now. When I finally get the time to fix #14, it will be easier to express different options for individual job types, so we can consider changing this at that time.

Sounds good. I'll add some sort of option to the PoolConfig like you said.


Pod Can't connect the stunner server

I deployed a service in a different namespace than Stunner, Stunner has some error messages when I access the service

<IP_ADDRESS> is my service pod IP  <IP_ADDRESS> is stunner pod ip

Hi @FLM210,
Could you please check whether your situation is similar to #90 or not?

Hi @FLM210,
Could you please check whether your situation is similar to #90 or not?

Yeah ,my situation is the same as that


Issues with Internal Logging

Hi,
I've two problem using Nlog internal logging.
Firstly  while starting I execute the following code:
 LogManager.Configuration = new NLog.Config.XmlLoggingConfiguration("NLog.debug.config", true);
            LogManager.ReconfigExistingLoggers();
            InternalLogger.LogToConsole = true;
            InternalLogger.LogToConsoleError = true;
            InternalLogger.LogLevel = LogLevel.Trace;
            LogManager.ThrowExceptions = true;
InternalLogger.LogFile = Path.Combine(ConfigurationManager.AppPath, "Nlog.log");

My first problem is the logToconsole do not display in my Visual output. Is that normal ?
My second issue is when I try to log on C:\log.txt (to test internal log)
This should crash because Nlog cannot create files at the root of C:.
Unfortunaly It do not crash (and do not create the file) (it works with C:\test\log.txt for example).
Here my internal Nlog.log content:
2015-04-23 18:44:09.8593 Debug TestManager.Info Rejecting message because of a filter.
2015-04-23 18:44:09.8593 Debug TestManager.Info Rejecting message because of a filter.
2015-04-23 18:44:09.8593 Debug TestManager.Info Rejecting message because of a filter.
2015-04-23 18:44:09.8593 Debug TestManager.Info Rejecting message because of a filter.
2015-04-23 18:44:09.8593 Trace Opening C:test.log with concurrentWrite=False
Rejected is normal (I've several targets)
So Why haven't I exception and no trace ?
Thanks a lot for the incoming help

Hi,
Why are you trying to log to the internal logger? This is only needed for checking what NLog is doing. You need probably you a regular logger and simple config.

My goal is to save warning and error in debug mode, and error in release from Nlog to understand reason of log fail.

I'm sorry but I don't get it. Is NLog not working correctly? Only then you will need the internal logger.

I want to avoid any production error and keep track of any problem
Like rights errors while logging which unfortunately could happen
But like in my example I'm not able to get the error (thrown by the logger) or tracked  in the nlog internal log...
that's why i'm looking for some help

Please check https://github.com/NLog/NLog/blob/master/CONTRIBUTING.md#questions
It's unclear to me what result you're expecting.

I just found out concerning exceptions.
I logger attempt to log into C:\myfile.txt
il fails if file do not exist because Nlog cannot create the file (because its the Windows root)
but no exception happens.
It was my issue.
But If I try to log into a file in an other place and lock the file to simulate an access error, the exception is raised.
So I think its just a particular case concerning file creation and exception throwing system.

Can this question be closed?

Yes thanks for the help !


Refactoring: Use Byte Specified Access Width for CRC

CRC access is currently using bit specification (8, 16, 32 or 64).
This could imply that other values might be valid, a byte based specification (1, 2, 4 or 8) could remedy that

Decision was made to stay with Bits, as XSD is defined for bits and we dont want to break compatibility


chore(main): release cli 1.10.0

:robot: I have created a release beep boop
1.10.0 (2024-05-27)
Features

release to DockerHub (487b24e)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/flexydox/flexydox/releases/tag/cli%40v1.10.0 :sunflower:


issue with blender armatures and godot

I don't know why but when I import rigged characters into Godot the armature and all the bones from blender turn into spatial nodes. Sometimes the meshes related to the bones are deformed in an undesired way but no bones. I tried all the file formats available.GLB .GLTF .GLTF+BIN .FBX .OBJ
The only thing that kind of resembled bones was .DAE but it only created 5 skeletons and no bones and no meshes. I had more than 5 bones In the rig
if there is a way to create 3D bones in Godot that I could work around it  or is there an addon that I need
I am using Godot 3.2.3 and blender 2.80

You can try ESCN from the Godot Blender Exporter Addon.
https://github.com/godotengine/godot-blender-exporter

Can you post a minimal reproduction project?  --  A small Godot project which reproduces the issue.

I don't have a reproduction case. Closing. Feel free to add a minimal reproduction project.


first version of ProvideProductionForecast

Description

-->
Closes #230
requires use of header https://github.com/eclipse-tractusx/sldt-semantic-models/pull/227

MS2 Criteria
(to be filled out by PR reviewer)

[ ] the model validates with the BAMM SDS SDK in the version specified in the Readme.md of this repository by the time of the MS2 check  (e.g., 'java -jar bamm-cli.jar -i <path-to-aspect-model> -v ). The  BAMM CLI is available here and in GitHub
[x] use Camel-Case (e.g., "MyModelElement" or "TimeDifferenceGmtId", when in doubt follow https://google.github.io/styleguide/javaguide.html#s5.3-camel-case)
[x] the identifiers for all model elements start with a capital letter except for properties
[x] the identifier for properties starts with a small letter
[x] all model elements at least contain the fields "preferred name" and "description" in English language. The description must be comprehensible. It is not required to write full sentences but style should be consistent over the whole model
[x] Property and the referenced Characteristic should not have the same name
[x] the versioning in the URN follows semantic versioning, where minor version bumps are backwards compatible and major version bumps are not backwards compatible.
[ ] use abbreviations only when necessary and if these are sufficiently common
[x] avoid redundant prefixes in property names (consider adding properties to an enclosing Entity or even adapt the namespace of the model elements, e.g., instead of having two properties DismantlerId and DismantlerName use an Entity Dismantler with the properties name and id or use a URN like io.catenax.dismantler:0.0.1)
[x] fields preferredName and description are not the same
[ ] preferredName should be human readable and follow normal orthography (e.g., no camel case but normal word separation)
[x] name of aspect is singular except if it only has one property which is a Collection, List or Set. In theses cases, the aspect name is plural.
[x] units are referenced from the BAMM unit catalog whenever possible
[ ] use constraints to make known constraints from the use case explicit in the aspect model
[x] when relying on external standards, they are referenced through a "see" element
[ ] all properties with an simple type have an example value
[x] metadata.json exists with status "release"
[ ] generated json schema validates against example json payload
[x] file RELEASE_NOTES.md exists and contains entries for proposed model changes
[ ] all contributors to this model are mentioned in copyright header of model file

MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)

[ ] All required reviewers have approved this PR (see reviewers section)
[ ] The new aspect (version) will be implemented by at least one data provider
[ ] The new aspect (version) will be consumed by at least one data consumer
[ ] There exists valid test data
[ ] In case of a new (incompatible) major version to an existing version, a migration strategy has been developed
[ ] The model has at least version '1.0.0'
[ ] The release date in the Release Note is set to the date of the MS3 approval

this PR seems to be outdated and is superseded by
https://github.com/eclipse-tractusx/sldt-semantic-models/pull/259/files
i will do the review for
https://github.com/eclipse-tractusx/sldt-semantic-models/pull/259/files


fix(executor): exit early when limit = 0

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Issue: #6244
When limit = 0, LimitExecutor will still call child.execute() at least once, if the executor below LimitExecutor is expensive, we will suffer a lot, so we need to exit early when limit = 0.

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features).
[ ] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
[ ] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

[ ] My PR DOES NOT contain user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note

/cc chenzl25


SaveChangesWithoutTriggersAsync throws when invoked from within a trigger

Discussed in https://github.com/koenbeuk/EntityFrameworkCore.Triggered/discussions/181

Originally posted by nahropro August  1, 2023
I have an after save trigger, in that trigger I update some entity and for avoid infinite loop I make a call to SaveChangesWithoutTriggersAsync(), but it throws this exception 'System.InvalidOperationException: 'A triggerSession has already been created''!

I like to reopen this


Example rfid_default_keys.ino authenticates with the first key only

If the PICC happens to be encrypted with other than first key from knownKeys array, the result is:
PCD_Authenticate() failed: Timeout in communication.
This code put in the line 151 seems to solve the issue:
    while (true) {
      if (mfrc522.PICC_IsNewCardPresent() &&  mfrc522.PICC_ReadCardSerial()) {
        break;
      }
    }

I'm not sure how this would solve the claimed issue; but I also noted that the rfid_default_keys.ino example itself was updated on 5 Dec 2015... now is your proposed change applicable to before or after those changes?  It would be best to provide a Pull Request (PR) change proposal, or provide a little bit more context (as "line 151" is ambiguous...).

It is a very old issue and honestly I don't remember how this code solved the problem. I suggest to close it.


merge package template from Kronos-Tools/npm-package-template

Updated standard to latest version

Codecov Report

Merging #253 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #253   +/-   ##
=======================================
  Coverage   88.42%   88.42%
=======================================
  Files           1        1
  Lines         216      216
=======================================
  Hits          191      191
  Misses         25       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d453c32...7772153. Read the comment docs.


AI.js

AI.js at line 1544 twoList.push(Count2List);  changeto twoList.push(Count2List[j]);???

AI.js at line 1544 twoList.push(Count2List); changeto twoList.push(Count2List[j]);???

Thanks，you are right.
This repository is imported from my gitee repository,I will fixed the bug in gitee,but not github.
this is the address:https://gitee.com/changjiuxiong/ddz


Table of content links show page under the header on the second click

When using links in the ToC in the DocLayout, the page position is correct in the first clic but wrong on the second clic with the content being behind the top header.

Hey, have you got any solution for this problem? currently I'm also facing this problem


cellxgene-schema must detect and fail reserved names that start with "__"

Reserved Names. The names of metadata keys MUST NOT start with "__".

Looks good to me! :)

Test Case
Expected Result
Obtained Result
Test File
Needs attention

scRA-seq witth 1 obs column start with '__'
Fail validation
Failed validationLogging: ERROR: The field '__n_genes' in 'obs' is invalid. Fields that start with '__' are reserved.
adata_obs_underscore.h5ad

scRA-seq witth 2 obs column start with '__'
Fail validation
Failed validationLogging: ERROR: The field '__n_counts' in 'obs' is invalid. Fields that start with '__' are reserved.ERROR: The field '__n_genes' in 'obs' is invalid. Fields that start with '__' are reserved.
adata_obs_underscores.h5ad


Added support for Android 20 and 21

Added support for Android 20 and 21 as well as tests to confirm that the max support version is Android 21.

@danderson1967 Did you actually run tests on android 5.x?

I ran my full suite of 140 tests on Android 5.0. However with the 0.13.0-SNAPSHOT codebase, I was unable to run the all of JUnit tests. Some were failing, and I didn't have the time to figure out why.

I'm fine mergin this in, i have done it in the past like this. enabling it first and then adding the support. Then the users can at least use what is working fine.


micro-reactive-events plugin

Plugin for scheduling and tracking jobs in a reactive way.

Superseded on cyclops-react branch


Add Cachet exporter to the list

Hi!
We, at ContaAzul, created an exporter to collect some metrics from Cachet status page (number of incidents by status and number of components by status). Its use the Cachet API to scrape the data.
The metrics exposed are:
cachet_up
cachet_scrape_duration_seconds
cachet_incidents_total
cachet_components_total

And it can be used to take insights about incidents and, if necessary, make some alerts on
forgotten open incidents.
@brian-brazil can you have a look please?

Thanks!
A few tips to improve things:
Gauges should not end in _total, that's for counters.
Config and metricConfig in collector.go are unused.
You should only set up to 1 after all requests (i.e. GetAllComponentGroups) have succeeded, otherwise you won't be able to alert on errors. Accordingly there's also no need for the ping.
The numbers for incident/component statuses are a bit oapque, using their names might be better. You're also missing incident statuses 0 and 4.

@brian-brazil thanks for the review in the code! We're making the improvements suggested by you 😄


Error: There are no simulated data present for this project.

Hi.
I have used the following code to simulate data with a maf file as the input.
>>> from SigProfilerSimulator import SigProfilerSimulator as sigSim
>>> sigSim.SigProfilerSimulator("CBCGA", ".", "GRCh38", contexts = ['96'], chrom_based=True, simulations=100, vcf=False)
======================================
        SigProfilerSimulator
======================================

Checking for all reference files and relevant matrices...
     Matrices per chromosomes do not exist. Creating the matrix files now.
Starting matrix generation for SNVs and DINUCs...Completed! Elapsed time: 191.3 seconds.
Starting matrix generation for INDELs...Completed! Elapsed time: 100.58 seconds.
     ./output/SBS/CBCGA.SBS96.all does not exist. Creating the matrix file now.
Starting matrix generation for SNVs and DINUCs...Completed! Elapsed time: 10.44 seconds.
Starting matrix generation for INDELs...Completed! Elapsed time: 4.96 seconds.
Matrices generated for 944 samples with 0 errors. Total of 137935 SNVs, 254 DINUCs, and 9849 INDELs were successfully analyzed.

Files successfully read and mutations collected. Mutation assignment starting now.
          Please generate simulations before running SigProfilerClusters.
	The package can be installed via pip:
			$ pip install SigProfilerSimulator

	and used within a python3 sessions as follows:
			$ python3
			>> from SigProfilerSimulator import SigProfilerSimulator as sigSim
			>> sigSim.SigProfilerSimulator(project, project_path, genome, contexts=['6144'], simulations=100)

	For a complete list of parameters, visit the github repo (https://github.com/AlexandrovLab/SigProfilerSimulator) or the documentation page (https://osf.io/usxjz/wiki/home/)

I was truly confused of this condition since I have simulated the data.
Thanks.

the same for me.


Add ConfigureAwait.body

Related : https://github.com/abpframework/abp/issues/4800
Should not require the same context, this will deadlock.
I used https://github.com/Fody/ConfigureAwait to configure async code's ConfigureAwait at a global level,

What is the purpose of this change? There don’t appear to be any code changes. If there is a deadlock, why not just fix the code where the dead lock is?

I don’t want to bring in the Fody dependency.

Like quartz's code, need to call ConfigureAwait(false) in all codes that use asynchronous methods.
Fody can help you configure at a global level. If you don't want to configure it globally, you can also write it manually.

I would prefer we just fix the missing instances in code. Also, is this code that is eventually run on .Net Framework because that is the only runtime where ConfigureAwait(false) actually has any effect.

However , choose is your's.


Weird code

I stumbled over this code segment in the link function in the uiTreeNodes directive:
ngModel.$render = function () {
    if (!ngModel.$modelValue || !angular.isArray(ngModel.$modelValue)) {
        scope.$modelValue = [];
    }
    scope.$modelValue = ngModel.$modelValue; // This will overwrite whatever happens above
};

As I see it the scope.$modelValue = [] assignment has no effect since it is overwritten right after.
Am I missing something here?

Looks like that code was refactored and that statement became redundant: https://github.com/angular-ui-tree/angular-ui-tree/commit/443e5fad7e84643773ed97059227da2e9392f75f#diff-569690a868827f658f34e4f67dc84ae5. Probably a simple oversight.
I don't think you're missing anything - that block of code can probably be removed.

You're right. I've removed that condition. Thanks!


bbox crossing the antimeridian

Currently the specification says:

The bbox, if specified, must be encoded with an array containing the minimum and maximum values of each dimension: [<xmin>, <ymin>, <xmax>, <ymax>]. This follows the GeoJSON specification (RFC 7946, section 5).

"Minimum" and "maximum" are not correct for cases where the bbox crosses the dateline, at least if GeoJSON is used as the basis. See GeoJSON 5.2, the following is a rough bbox for the Fiji archipelago, spanning 5 degrees of longitude: [177.0, -20.0, -178.0, -16.0].
If GeoJSON is followed, the wording should be updated/clarified. If it should be strictly minimum/maximum, then the GeoJSON reference should be removed.
Happy to create a PR for review, but it would help to understand the intention for GeoParquet. I personally would prefer the first option and be consistent with GeoJSON, which is also what is used in OGC API Features and I think STAC.

Hi, What about using North South East West (relative to the center of the bounding box) I believe that would always work

There can be a discussion on what the correct wording should be. In effect the intended meaning of the existing spec is to follow GeoJSON, where the bbox is always west, south, east, north. And when crossing the antimeridian the numeric value of west is allowed to be larger than the numeric value of east

Call 11/7:
We should update our wording here - we use minimum and maximum, while geojson does east/west.
Issue for geoparquet is that there's non-geographic CRS's.
Consensus is to clarify that for geographic CRS's we follow GeoJSON, and update the spec. And to say 'less' on the non-geographic crs's, perhaps just something about being up to the client / crs.
@tschaub to take a pass and write a PR, we can continue review / discussion there.


Fix game over when trying to move in opposite direction

For example, the snake is moving towards right. If user inputs ← (left), the snake bites itself and game ends. I do not know if this is intended but this PR fixes it by ignoring opposite movement inputs.

Thanks for the PR!
Sorry for taking so long to merge this, I was really busy at the time and then I forgot about it.

No problem! Glad to be of help. :smile:


When will v0.4.2 be released?

pip install whisper-live is old version
or is there any way I can pack it myself?
Thanks

Hello @kxbin v0.5.0 released.

Thanks so much


Add warning for html.script

Current Situation
Currently, there is no documented warnings for the potential of XSS attacks when using html.script
Proposed Actions
We should add a disclaimer to warn users not to use raw user inputs (from any untrusted data source) within the script contents to avoid XSS attacks.

Can you assign me the task? Will be a good starting point.

We don't utilize the issue assignment feature on GitHub. The first person to open a draft PR gets priority to resolve it.

ok thanks! will do that.

@Archmonger, was your intention for this to be in the docstring.

Yeah, since the docstring gets turned into auto-docs.

hey! can you please tell me where do i have to put or write the documention i mean in which file?

https://github.com/reactive-python/reactpy/blob/main/src/reactpy/html.py

@Archmonger, can we create a follow-up ticket for a tool that would sanitize inputs to scripts? I think we can do more to help mitigate this risk for users.

You think this could be added to our flake8 plugin?

It's possible, but if that's all we supplied, users might improperly sanitize inputs. Better to provide a standardized solution.

That might be a bit over engineered for a tag that we shouldn't incentive using.
In my opinion, due to script tags being inherently dangerous, we should treat them similar to React dangerouslySetInnerHtml.
It's best to get the idea into user's heads that "you can use this but it's risky so you're on your own."

I like that idea. We could require the script to be passed as a kwarg with a scary name like insecurely_eval or something.


Remove 2s delay between result write and statement state update

As https://github.com/opensearch-project/sql/issues/2436 fixed in PPL plugin, the previous mitigation (2 seconds sleep between result index write and statement state update) can be removed.
Ref: https://github.com/opensearch-project/opensearch-spark/pull/174

For the safe side, this will be fixed after the fix in PPL plugin rollout.

fixed in https://github.com/opensearch-project/opensearch-spark/pull/245


Visualization Tool: alignment and rounding

For the metrics, Power Consumption... through Last Run Carbon.... the alignment is wonky. The first and third lines are left-justified, second and fourth are right-justified. Also, I'm thinking you could probably round these values somewhat?

Looks like maybe you did this on purpose???
html.Div(
[
html.H4(
[
"Power Consumption Across All Experiments : ",
html.Strong(
id="project_power_consumption",
style={"fontWeight": "normal", "color": "green"},
),
],
style={"float": "left"},
),
html.H4(
[
"Last Run Power Consumption : ",
html.Strong(
id="last_run_power_consumption",
style={"fontWeight": "normal", "color": "green"},
),
],
style={"float": "right"},
),
]
),


Missing dependency injection extension

For example, there are many factory classes that do not implement interface, but require dependency injection. In this case, should implement an AddFactory() method. Frameworks can provide a simple injection extension

Do you want to implement automatic injection according to convention?

Do you want to implement automatic injection according to convention?

yes


Genetic value

Function to compute genetic values from effect size dataframe

Note:
codecov is saying that it is failing because I haven't implemented the unit tests to examine the codes that are speeded up by using numba. However, I have thoroughly examined the validity of the function through unit tests, so there is no need to worry about it when merging the commit.

Note: codecov is saying that it is failing because I haven't implemented the unit tests to examine the codes that are speeded up by using numba. However, I have thoroughly examined the validity of the function through unit tests, so there is no need to worry about it when merging the commit.

This is a numba thing isn't. Pytest-cov doesn't 'see' the jitted functions. One way around this would be to disable jit compilation to generate the codecov report.

Trying to wrap my head around the intended use here. This proposed functionality is only used when we want to provide our own custom dataframe with effect sizes, right? This is not used to simulated genetic values for the multitrait model for example?

Trying to wrap my head around the intended use here. This proposed functionality is only used when we want to provide our own custom dataframe with effect sizes, right? This is not used to simulated genetic values for the multitrait model for example? Would you mind creating an issue for this, to describe what we want to achieve here. This would allow me to help you much more effectively here I think. Thanks!

Thank you for your feedback. I'm thinking about (based on Jerome's suggestions)

Simulate effect sizes, and obtain the dataframe with effect sizes
Obtain genetic values based on the effect size dataframe obtained in 1
Simulate environmental noise and phenotype given the genetic value dataframe obtained in 2

I'm planning to largely modify the codes in sim_phenotypes.py, and rewrite sim_phenotype function, such that it uses the functions in 1-3.

Sure, but in the MultiTraitModel where all causal sites are identical for all traits, then we wouldn't want to use this workflow right. A single tree traversal for each causal mutation should suffice right?

I totally agree with that, but the number of traits produced by MultiTraitModel should only be around 2-3, so I wrote the code like this to support the genetic value computation when the causal allele is different among different traits. However, I would be happy to hear your suggestions,

I totally agree with that, but the number of traits produced by MultiTraitModel should only be around 2-3, so I wrote the code like this to support the genetic value computation when the causal allele is different among different traits. However, I would be happy to hear your suggestions,

@daikitag imagine though simulating express me, metabolome, proteome, phenome, … of an individual - you could easily have hundreds or more traits, though I agree these types of simulations were not common in the past, but might become common in future (if we can parameterise them reasonably well).

@gregorgorjanc
Thank you very much for your feedback, and I really appreciate it. I'm actually thinking about trying to incorporate it in the future release, but I'll continue to think about how I can modify the functions to support simulations of hundreds of traits.

OK, good to keep this in mind. With a MultiTraitModel we should indeed be able to simulate genetic values with a single pass through each subtree with a causal mutation.
This also made me wonder, currently you're proposed code iterates across each trait, and for each trait then iterates over all causal sites. Would we want to test whether it makes more sense to do a single pass through the tree sequence by iterating over all possible causal sites independent of the trait assigned to it. Jumping back and forth within the tree sequence is an expensive operation isn't it.

OK, good to keep this in mind. With a MultiTraitModel we should indeed be able to simulate genetic values with a single pass through each subtree with a causal mutation.
This also made me wonder, currently you're proposed code iterates across each trait, and for each trait then iterates over all causal sites. Would we want to test whether it makes more sense to do a single pass through the tree sequence by iterating over all possible causal sites independent of the trait assigned to it. Jumping back and forth within the tree sequence is an expensive operation isn't it.

Yeah, instead of working for one trait vector (say a column) we can work for multi-trait matrix (say multiple columns) in one pass.


Snowchange not picking up files with uppercase extension

Hey guys,
Thank you for the very useful script that is Snowchange.
We are having an issue when people using Windows are sending files into the pipeline with names like
V1.2__something.SQL
These files are being ignored by Snowchange because the regexp used for files is
script_name_parts = re.search(r'^([V])(.+)__(.+)\.sql$', file_name.strip())
repeatable_script_name_parts = re.search(r'^([R])__(.+)\.sql$', file_name.strip())

I think these 2 regular expressions should ignore case, at least for the extension part of the filename.
What do you think? I can send a PR if required.

Just pushed a fix for this! And just updated the package in PyPI so you can now install snowchange via pip!


Rasa X Decoding error with German umlauts

Rasa version: 1.1.7
Rasa X version (if used & relevant): 0.19.5
Python version: 3.7.0
Operating system (windows, osx, ...): windows
Issue:
I am getting a decoding error when I want to start rasa x with German umlauts in the domain.yml.  If I remove the special characters, I can start rasa x without problems. Same issue has been reported already on a rasa-x-demo repository here : https://github.com/RasaHQ/rasa-x-demo/issues/16
After testing, this error also occurs when running rasa train.
Error (including full traceback):
(base) C:\Users\Documents\workspace_python\FuBo\bot>rasa x
Starting Rasa X in local mode... 🚀
Traceback (most recent call last):
  File "c:\users\appdata\local\continuum\anaconda3\lib\site-packages\rasa\cli\x.py", line 322, in run_locally
    local.main(args, project_path, args.data, token=rasa_x_token)
  File "c:\users\appdata\local\continuum\anaconda3\lib\site-packages\rasax\community\local.py", line 190, in main
    project_path, data_path, session, args.port
  File "c:\users\appdata\local\continuum\anaconda3\lib\site-packages\rasax\community\local.py", line 139, in _initialize_with_local_data
    domain_path, domain_service, COMMUNITY_PROJECT_NAME, COMMUNITY_USERNAME
  File "c:\users\appdata\local\continuum\anaconda3\lib\site-packages\rasax\community\initialise.py", line 136, in inject_domain
    domain_yaml=read_file(domain_path),
  File "c:\users\appdata\local\continuum\anaconda3\lib\site-packages\rasa\utils\io.py", line 130, in read_file
    return f.read()
  File "c:\users\appdata\local\continuum\anaconda3\lib\codecs.py", line 322, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf6 in position 127: invalid start byte

Command or request that led to error:
rasa x

Content of configuration file (config.yml) (if relevant):
# Configuration for Rasa NLU.
# https://rasa.com/docs/rasa/nlu/components/
language: de
pipeline: pretrained_embeddings_spacy

# Configuration for Rasa Core.
# https://rasa.com/docs/rasa/core/policies/
policies:
  - name: MemoizationPolicy
  - name: KerasPolicy
  - name: MappingPolicy

Content of domain file (domain.yml) (if relevant):
intents:
- affirm
- deny
- goodbye
- greet
templates:
  utter_greet:
  - text: Hallo ich bin dein persönlicher Assistent. Wie kann ich Dir helfen?
  utter_did_that_help:
  - text: Konnte ich Dir damit weiterhelfen?
  utter_goodbye:
  - text: Ich wünsche Dir noch einen schönen Tag!
actions:
- utter_did_that_help
- utter_goodbye
- utter_greet

Thanks for raising this issue, @gausie will get back to you about it soon.

@kristiankolthoff Which encoding is your file in? Can you please save it as utf-8?

I saved it as utf-8 explcitly and the error still remains.

@erohmensing Can you please check whether you can reproduce that when I'm gone? Thanks!

Hm, I added ö to my domain.yml, nlu.md and stories.md and it loaded up with no problem. I can see the umlauts in all 3 of these places on the UI too. Of course I am also running the latest version, so you might want to try updating. Can you run this in the console for me?
❯ python
Python 3.7.3 (default, Mar 27 2019, 16:54:48)
[Clang 4.0.1 (tags/RELEASE_401/final)] :: Anaconda, Inc. on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import sys
>>> sys.stdout.encoding
'UTF-8'
>>> sys.stdin.encoding
'UTF-8'

This error still reproduces for me on the latest version, using Windows in German locale. The stdin and stdout streams show UTF-8, but they are not the root cause here.
The underlying issue is that python by default writes to files with the system code page, unless an override is provided when opening the file, and rasa does not specificy UTF8. Additionally, when loading the domain.yml file rasa first reformats and saves it, before actually loading and parsing it, during the first step we lose the encoding, and when loading we are no longer in UTF8 causing the error.
Workaround: (Python 3.7+ only) set the environment variable PYTHONUTF8 to 1 before running rasa, this forces python to use utf8 as default encoding. On Windows: set PYTHONUTF8=1
Solution for rasa/rasa x: When saving the domain file (and other files as well .. ) specify utf8 as override. Python 3.7+ only: Enable utf8 mode in code.

Thanks for the very descriptive into @taotsetung. I've tracked down the part where the domain gets written in Rasa X and you're right, the encoding isn't specified:
def dump_yaml_to_file(filename: Text, content: Any) -> Optional[str]:
    """Dump content to yaml."""
    with open(filename, "w") as f:
        f.write(dump_yaml(content))

I assume that with open(filename, "w", encoding="utf-8") as f:should do the job, but we'll check it out.

fixed in #1195

fix is part of Rasa X 0.20.3


Reparenting on runtime trows an error if the node has an animation tree

Godot version:
3.1-RC1
OS/device including version:
Zorin OS Core 12.4
Issue description:
Reparenting on runtime trows an error if the node has an animation tree
Steps to reproduce:
Create a kinematicbody, add an animation tree, reparent on runtime.
Minimal reproduction project:
Parent-Bug.zip

Fixed by #27895.


Implicit inner join doesn't tokenize correctly

When running the following code
using Carbunql;

string sql = "select * from TableA join TableB on TableA.Id = TableB.FK where 1=1 and TableA.Id = 10";
var query = new SelectQuery(sql);

foreach(var token in query.GetTokens())
{
    Console.WriteLine(token.Text);
}

I get the output:
select
*
from
TableA
as
join

The expected output is:
select
*
from
TableA
join
TableB
on
TableA
.
Id
=
TableB
.
FK
where
1
=
1
and
TableA
.
Id
=
10

It works once I add an explicit "inner" to the sql query.

Thank you for your advice. I was able to reproduce the symptoms. I would like to correct it.

I'll stop working for now.

fixed


[fix] #4099: Fix of the websocket request builder

Description
Fixed the web socket bug which gives HTTP 400.
All library versions saved as-is
Linked issue

Closes #4099:

Benefits

Checklist

[x] I've read CONTRIBUTING.md
[x] I've used the standard signed-off commit format (or will squash just before merging)
[x] All applicable CI checks pass (or I promised to make them pass later)
[x] (optional) I've written unit tests for the code changes
[x] I replied to all comments after code review, marking all implemented changes with thumbs up

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 7 (0.0%)  changed or added relevant lines in 1 file are covered.
7015 unchanged lines in 129 files lost coverage.
Overall coverage decreased (-3.1%) to 56.304%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

client/src/http_default.rs
0
7
0.0%

Files with Coverage Reduction
New Missed Lines
%

config/base/derive/src/view.rs
1
99.37%

config/src/block_sync.rs
1
95.0%

config/src/network.rs
1
93.75%

config/src/torii.rs
1
95.45%

config/src/wasm.rs
1
87.5%

core/src/smartcontracts/isi/block.rs
1
87.5%

config/src/kura.rs
2
79.41%

config/src/lib.rs
2
0.0%

ffi/src/option.rs
2
71.43%

config/src/genesis.rs
3
72.92%

Totals

Change from base Build<PHONE_NUMBER>:
-3.1%

Covered Lines:
23024

Relevant Lines:
40892

💛  - Coveralls


camera-ffmpeg-omx

I use RPi0w... So, Raspbian. In raspbian backports right now is available ffmpeg:
ffmpeg/jessie-backports 7:3.2.5-1~bpo8+1 armhf [upgradable from: 3.1.4-1]
So, it not working with 3.2.5... How to make it works with this ver?

The omx compatible version which @legotheboss compiled works for me:
https://github.com/legotheboss/YouTube-files/raw/master/ffmpeg_3.1.4-1_armhf.deb
Install via
wget https://github.com/legotheboss/YouTube-files/raw/master/ffmpeg_3.1.4-1_armhf.deb
sudo dpkg -i ffmpeg_3.1.4-1_armhf.deb

I haven't come across a newer compiled version which has the omx plugin already installed, and I don't want to waste half an hour compiling it myself.

I'm not sure what you understand me. This topic about ffmpeg 3.2.5 from Debian backports. 3.1.4 works for me too.

ffmpeg 3.2.5 in Debian backports doesn't contain the omx plugin so it won't work with hardware encoding/deciding on the Raspberry Pi.
If you want this version, you'll need to build it from source yourself, but there are no new features you'd benefit from on the Raspberry Pi so I wouldn't bother.

you can use the capabilities of the v4l2 driver instead of h264_omx


passing "True" instead of "true"

:+1:

Is this really necessary? That seems like an API bug?

Oh there's a bug listed. Nevermind


Ar and fa

Updated fa plus ar

Hi @RUN-Projects this PR looks good and thanks. @vipinpaul this PR can be merged, both Arabic and Farsi are reflected on the UI and messages as expected.
Arabic

Farsi

The following stings need to be translated and added to the file.

'label-import-door43-resources': 'Import Door43 helps resources',
'label-documentation': 'Documentation',
'label-tech-support': 'Tech Support',
'msg-helps-filepath': 'Helps Resource filepath with valid manifest.yaml',
'tooltip-supported-resources': 'supported resources are TN, TW, TQ, TA',
'label-upload-help-resources': 'Upload Help Resources',

@RUN-Projects, Please update/send a new PR once it is done.


Decode Ways II from Leetcode

Hi sir this is a hard level problem from leetcode
and related to dp
can you please assign this issue to me

hello sir,
can you please assign this issue to me


IntentSleepTimer not working due to AMAZON.DURATION Format

Amazon provides sth. like PT10M for 10 minutes. We expect an integer. We have two options:

parse amazon value
change to number?

@Extrawurst  What are you thinking about this?

actually the returned duration has a standardized format ISO-8601 (see https://developer.amazon.com/public/solutions/alexa/alexa-skills-kit/docs/built-in-intent-ref/slot-type-reference#duration)
std.datetime supports the same format: https://dlang.org/phobos/std_datetime.html

It's right that Amazon uses the ISO 8601 duration format. But Duration is only a part of the complete standard - which is used by dlang as well. But in my point of view there is no "parsing" function to convert a ISO-8601 string to an duration object.


Script for renaming saved variables

It would be handy to have a script that would rename variables and/or graph ops by loading the saved vars and metagraph and saving the new one.

de-duping with #600


No .build folder when updating to 0.1.17

We used version 0.1.17 of wdio-browserstack-service and noticed all our builds broke.
See the stacktrace below.
When downgrading to 0.1.16 all was fine again, and the missing "build" folder was there again.
/home/shopuser/workspace/wdio-yode_live_smoke/node_modules/webdriverio/build/lib/cli.js:457                 throw e;                 ^ Error: Couldn't initialise launcher from service "browserstack". Error: Cannot find module './build/browserstack-launch-service'     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:603:15)     at Function.Module._load (internal/modules/cjs/loader.js:529:25)     at Module.require (internal/modules/cjs/loader.js:658:17)     at require (internal/modules/cjs/helpers.js:22:18)     at Object.<anonymous> (/home/shopuser/workspace/wdio-yode_live_smoke/node_modules/wdio-browserstack-service/launcher.js:1:99)     at Module._compile (internal/modules/cjs/loader.js:722:30)     at Object.Module._extensions..js (internal/modules/cjs/loader.js:733:10)     at Module.load (internal/modules/cjs/loader.js:620:32)     at tryModuleLoad (internal/modules/cjs/loader.js:560:12)     at Function.Module._load (internal/modules/cjs/loader.js:552:3)     at Launcher.getLauncher (/home/shopuser/workspace/wdio-yode_live_smoke/node_modules/webdriverio/build/lib/launcher.js:815:35)     at Launcher._callee$ (/home/shopuser/workspace/wdio-yode_live_smoke/node_modules/webdriverio/build/lib/launcher.js:234:49)     at tryCatch (/home/shopuser/workspace/wdio-yode_live_smoke/node_modules/regenerator-runtime/runtime.js:62:40)     at Generator.invoke [as _invoke] (/home/shopuser/workspace/wdio-yode_live_smoke/node_modules/regenerator-runtime/runtime.js:296:22)     at Generator.prototype.(anonymous function) [as next] (/home/shopuser/workspace/wdio-yode_live_smoke/node_modules/regenerator-runtime/runtime.js:114:21)     at step (/home/shopuser/workspace/wdio-yode_live_smoke/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)     at /home/shopuser/workspace/wdio-yode_live_smoke/node_modules/babel-runtime/helpers/asyncToGenerator.js:35:14     at new Promise (<anonymous>)     at new F (/home/shopuser/workspace/wdio-yode_live_smoke/node_modules/core-js/library/modules/_export.js:36:28)     at Launcher.<anonymous> (/home/shopuser/workspace/wdio-yode_live_smoke/node_modules/babel-runtime/helpers/asyncToGenerator.js:14:12)

My bad. I forgot to build the project before publishing 0.1.17 just earlier. I've published 0.1.18 to fix this. Sorry for the trouble!


Improve UX around creating an account and giving password

Right now, the first thing which a user sees when booting up Bee is:
password
This is not super user-friendly.
It would be better to give the user slightly more context, telling him that, as it is the first time that he boots up Bee, he should make a new password.
Then, the user should be re-prompted to enter this password again to unlock the Bee.

@janos

@janos , do we want this in for next release? If so: let' move the card in our Kanban board. If not, also fine.

Maybe you could tell @pradovic what your idea was?

@Eknir, @janos Sorry, I was a bit late on this. I have implemented some logic, but now that I take a look at it I don't really like it. We are currently not remembering the password and the user. If we start to do it, then what should we do if the user enters a wrong password? We would need to add the way to change the password etc.. Only thing that we are checking at the moment is that if the keys exists or not, and if not we create the new ones, but password is typed every time (unless provided by config or file). I think this is kind of a good approach. Maybe we should just change the text? Or should we remember the password for the user and refuse the user if new/wrong password is used?

There is no need to remember (store) the password.
First case: there are no keys and user must provide password to protect newly generated keys. Two password inputs on creation is just a repercussion that the user entered the password correctly. They are just in memory, checked if they are equal before new key is created.
Second case: keys already exist and user needs to provide a password only once over terminal to decrypt it.
These two cases are only when the password is required to be entered over terminal. When the password is provided with cli configuration options (flag, env var or config file), there is no interaction over terminal.
There is no need for a password to be changed, at least not at this time. If that would be needed, a dedicated command or even binary can be provided.


Verus not respecting --no-solver-version-check flag

What Happened
I have z3 of 4.13.0 installed locally and verus expected 4.12.5, according to the note:
vargo build
error: Verus expects z3 version "4.12.5", found version "4.13.0"
Run ./tools/get-z3.(sh|ps1) to update z3 first.
If you need a build with a custom z3 version, re-run with --no-solver-version-check.

I added the --no-solver-version-check because I think it's compatible with 4.12.5 API according to z3's release note, but Verus still panicked with
thread '<unnamed>' panicked at /tmp/verus/source/air/src/smt_verify.rs:192:21:
The verifier expects z3 version "4.12.5", found version "4.13.0 - build hashcode 3049f578a8f98a0b0992eca193afe57a73b30ca3"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I checked the code and thought this flag was not respected:
https://github.com/verus-lang/verus/blob/aa8b42313d8e7a9a724abfa3dc481460aaeef2c1/source/air/src/smt_verify.rs#L182-L196
What Was Expected
Verus respect --no-solver-version-check and proceed with no panic / error

This bug still exists after this commit:
Building succeeded with
verus/source ((release/rolling/0.2<IP_ADDRESS>76465))> vargo build --no-solver-version-check --release
vargo info [0]: building rust_verify
    Finished release [optimized] target(s) in 0.04s
vargo info [0]: building builtin
    Finished release [optimized] target(s) in 0.02s
vargo info [0]: building builtin_macros
    Finished release [optimized] target(s) in 0.03s
vargo info [0]: building state_machines_macros
    Finished release [optimized] target(s) in 0.02s
vargo info [0]: building vstd_build
    Finished release [optimized] target(s) in 0.02s
vargo info [0]: building verus
    Finished release [optimized] target(s) in 0.03s
vargo info [0]: vstd fresh

But runtime panicked:
verus/source ((release/rolling/0.2<IP_ADDRESS>76465))> ./target-verus/release/verus rust_verify/example/guide/getting_started.rs

thread '<unnamed>' panicked at verus/source/air/src/smt_verify.rs:192:21:
The verifier expects z3 version "4.12.5", found version "4.13.0 - build hashcode 3049f578a8f98a0b0992eca193afe57a73b30ca3"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: expected z3 version 4.12.5, found 4.13.0 - build hashcode 3049f578a8f98a0b0992eca193afe57a73b30ca3

thread '<unnamed>' panicked at rust_verify/src/verifier.rs:352:17:
dropped, expected call to `into_inner` instead
stack backtrace:
   0:     0x74620163e6f6 - std::backtrace_rs::backtrace::libunwind::trace::hbee8a7973eeb6c93
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/../../backtrace/src/backtrace/libunwind.rs:104:5
   1:     0x74620163e6f6 - std::backtrace_rs::backtrace::trace_unsynchronized::hc8ac75eea3aa6899
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
   2:     0x74620163e6f6 - std::sys_common::backtrace::_print_fmt::hc7f3e3b5298b1083
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/sys_common/backtrace.rs:68:5
   3:     0x74620163e6f6 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::hbb235daedd7c6190
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/sys_common/backtrace.rs:44:22
   4:     0x746201690f40 - core::fmt::rt::Argument::fmt::h76c38a80d925a410
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/fmt/rt.rs:142:9
   5:     0x746201690f40 - core::fmt::write::h3ed6aeaa977c8e45
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/fmt/mod.rs:1120:17
   6:     0x74620163253f - std::io::Write::write_fmt::h78b18af5775fedb5
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/io/mod.rs:1810:15
   7:     0x74620163e4d4 - std::sys_common::backtrace::_print::h5d645a07e0fcfdbb
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/sys_common/backtrace.rs:47:5
   8:     0x74620163e4d4 - std::sys_common::backtrace::print::h85035a511aafe7a8
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/sys_common/backtrace.rs:34:9
   9:     0x746201641267 - std::panicking::default_hook::{{closure}}::hcce8cea212785a25
  10:     0x746201640fc9 - std::panicking::default_hook::hf5fcb0f213fe709a
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:292:9
  11:     0x746201641828 - std::panicking::rust_panic_with_hook::h095fccf1dc9379ee
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:779:13
  12:     0x5e0d80baf54d - std::panicking::begin_panic::{{closure}}::h7d943025b9aab28a
  13:     0x5e0d80bab4c6 - std::sys_common::backtrace::__rust_end_short_backtrace::hbe36db03c1754811
  14:     0x5e0d80aca66a - std::panicking::begin_panic::h7ede8bd9c91d2094
  15:     0x5e0d80bb1ee6 - core::ptr::drop_in_place<core::option::Option<rust_verify::verifier::util::PanicOnDropVec<(alloc::sync::Arc<vir::messages::MessageX>,air::messages::MessageLevel)>>>::hbd7d395a3f6460ac
  16:     0x5e0d80bd3c14 - rust_verify::verifier::Verifier::verify_bucket::hf3ebbe0a20e79754
  17:     0x5e0d80bac3e8 - std::sys_common::backtrace::__rust_begin_short_backtrace::h5bb45eaeb7d063f8
  18:     0x5e0d80b8a77b - core::ops::function::FnOnce::call_once{{vtable.shim}}::h599537c8f06ad65a
  19:     0x74620164b8e5 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::h12de4fc57affb195
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/alloc/src/boxed.rs:2015:9
  20:     0x74620164b8e5 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::h3c619f45059d5cf1
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/alloc/src/boxed.rs:2015:9
  21:     0x74620164b8e5 - std::sys::unix::thread::Thread::new::thread_start::hbac657605e4b7389
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/sys/unix/thread.rs:108:17
  22:     0x7461fb6a339d - <unknown>
  23:     0x7461fb72849c - <unknown>
  24:                0x0 - <unknown>
thread '<unnamed>' panicked at library/core/src/panicking.rs:163:5:
panic in a destructor during cleanup
thread caused non-unwinding panic. aborting.
fish: Job 1, './target-verus/release/verus ru…' terminated by signal SIGABRT (Abort)

Whoops, you actually need to add -V no-solver-version-check.

I saw the update for z3 version is rolled back, I fixed it in my fork, should I merge?
Also, I'm using Arch Linux and shipped z3 has the version number as Z3 version 4.13.0 - 64 bit - build hashcode 3049f578a8f98a0b0992eca193afe57a73b30ca3, which happened to pass the version checks in vargo wrapper at
https://github.com/verus-lang/verus/blob/27764656a55aa214134f79187aac28435ae52ebc/tools/vargo/src/main.rs#L80
and
https://github.com/verus-lang/verus/blob/27764656a55aa214134f79187aac28435ae52ebc/tools/vargo/src/main.rs#L161
because the hash part is skipped using the 2nd match group. But it fails at runtime even if the versions compared are the same(see the error above):
error: expected z3 version 4.12.5, found 4.13.0 - build hashcode 3049f578a8f98a0b0992eca193afe57a73b30ca3

May I open a PR to update the version and fix the problem with build hash?

I'm a little confused about the problem - I understand the comparison doesn't work properly, but I think the comparison should be skipped entirely if you supply -V no-solver-version-check. Is that not the case?
We like to keep up-to-date with z3, so I doubt you'll receive much pushback for updating the version -- but it's also a process that requires a bit of testing. I also want to make sure I understand the problem you're running into.

By the way, if you follow the instructions here, you shouldn't need to rely on your system Z3.

I think the comparison should be skipped entirely if you supply -V no-solver-version-check

Yes.

if you follow the instructions here, you shouldn't need to rely on your system Z3.

Yes, I moved this part of discussion in PR and I think this makes sense, though it could be more convenient to add the support

Do we need a no-sover-version-check for vargo too?


Text replacement for Prevent Layout overrun.

Thank you for the fix! If necessary we can also adjust where the text is displayed to prevent it from overflowing.


Icon compatibility

Bulma: v0.6.0
Buefy: v0.5.4
There is an update needed for correct mdi icons support

https://github.com/rafaelpimpa/buefy/blob/fd4bed9fd0ae20df108e6410fa8108b666f41282/src/components/icon/Icon.vue#L3
I guess it's linked to #375
Thanks!

Actually nothing changed to icons on bulma 0.6, I've used it already on a project and it's normal.
Are you using the community MDI or the original one?

I use @import '~mdi/css/materialdesignicons' so it's the Community one.
Maybe you should switch to this one as Bulma documentation points to it.

Sure I'll add it.


fixed: small optimization

Codecov Report

Merging #396 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #396   +/-   ##
=======================================
  Coverage   55.91%   55.91%
=======================================
  Files          52       52
  Lines        6197     6197
=======================================
  Hits         3465     3465
  Misses       2408     2408
  Partials      324      324

Impacted Files
Coverage Δ

enforcer/lookup/lookup.go
98.24% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2550060...a04769e. Read the comment docs.


Why my VS Code did't throw the typescript error ?

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.66.2
OS Version: Darwin x64 19.6.0
VS Code Typescript Version: 4.6.3

Steps to Reproduce:
Here is the original typescript code:
enum Test {
    AA = 'aa',
    BB = 'bb'
}

Object.keys(Test).forEach((key) => {
    console.log(key, Test[key]);
});

In typescript official playground:

In vscode: (there were no error prompt)

What's your TSConfig?
The TS Playground enables noImplicitAny by default. Do you also have it in your local environment?

What's your TSConfig?
The TS Playground enables noImplicitAny by default. Do you also have it in your local environment?

Sure, solved my problem, thanks!
By the way, could the TS playground exposed the tsconfig? Because when I use it, I can't find its tsconfig.

The Playground supports a portion of the compiler options, which are listed in the "TS Config" panel.
For more information, please see its Help:
https://www.typescriptlang.org/play#handbook-1


[wrt] Update test.xml format error in tct-ex02-wrt-tests

The test.xml file missing one '' node

LGTM


Add constant for 'associated-link-name'

Description
Brief description of the changes made in the PR.

This exposes additional constant required for Service Bus operations.
Per offline discussions, it is now required to pass in "associated-link-name". Since any link which is idle for 10 mins gets disconnected from the service, passing in the associated link name (say, receiver link on which message was received) will make Service Bus and system not consider the link as idle.

cc @ramya-rao-a @AlexGhiondea

The RequestResponseLink is a generic concept where we use a AMQP sender and receiver and their session as single entity to send a single request and then get the response.
Event Hubs and Service Bus use this for $cbs and $management links.
The need for an associated-link is very specific to the request being sent. Not all requests may have an associated-link. Therefore, I don't believe we need to update SendRequestOptions for this.

The parameter is that's why made optional. Also ask from Service Bus was to have it on all request-response operations, hence this proposal.

Why not set the associated-link property just like we set any other property when sending the request?
For example: https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/servicebus/service-bus/src/core/managementClient.ts#L313

Yes, we can do that.
But based on conversation about propagating these changes to all request-response operations, this seems befitting.
Is there any disadvantage to this approach as such?

Is there any disadvantage to this approach as such?

There is no disadvantage as such other than this being not the right place for the fix. The fix for the issue is adding a property to the application_properties bag of the request.

SendRequestOptions is the options for how the request is sent and not on the request contents. We are now extending it to contain information on the request contents
amqp-common has by far refrained from editing the contents of the request being made other than adding a messageId if it doesnt exist (probably because it is a required entity). We are now having this library edit the incoming request

Also ask from Service Bus was to have it on all request-response operations, hence this proposal.

The issue is specific to operations on the $management link. Its still debatable that all request-response operations need this fix. Even if we do arrive at that conclusion, the fix can still be made in the Service Bus SDK such that the fix is restricted to all the $management operations.

Also, when the service team refers to "all request-response operations" they are referring to the all the operations on the $management link as listed in this spec

Addressed comments.
@ramya-rao-a @AlexGhiondea
Can you respond, take a look?

Can you respond, take a look?

The points in https://github.com/Azure/amqp-common-js/pull/47#issuecomment-484351956 still hold true. Any updates here?

Thanks for the review @bterlson

Can you respond, take a look?

The points in #47 (comment) still hold true. Any updates here?

About,

SendRequestOptions is the options for how the request is sent and not on the request contents. We are now extending it to contain information on the request contents

The statement above seems confusing, as the option added is part of request headers and not content/body.
Do you mean to treat request headers as request content?
The code usage of SendRequestOptions  seems to be packaging request and setting the application properties based on option values, correct?
Overall, it seems like the only concern is appropriateness of fix which is still pending conversations, investigation with team and Service Bus that haven't concluded yet.
For now, since there is no concern about system breaks - would like to move forward with these changes and unblock the bug fix for Azure/azure-sdk-for-js#2288. Does this sound ok? @ramya-rao-a

Do you mean to treat request headers as request content?

Yes, when I meant request content, I meant everything inside the request variable here.

The code usage of SendRequestOptions seems to be packaging request and setting the application properties based on option values, correct?

2 properties (delayInSeconds and times) on SendRequestOptions are used for the retry logic
3rd property (timeoutInSeconds) is used in the timeout that ensures that the request doesnt take more than the configured time
They arent used for packaging the requests or for setting application properties

Overall, it seems like the only concern is appropriateness of fix which is still pending conversations, investigation with team and Service Bus that haven't concluded yet

The fix (to set the application property) is correct. The concern is where the fix should be made. In managementClient.ts file in Service Bus SDK or here.

For now, since there is no concern about system breaks - would like to move forward with these changes and unblock the bug fix for Azure/azure-sdk-for-js#2288. Does this sound ok? @ramya-rao-a

If unblocking the bug fix is the main priority, then I would prefer a local solution (in Service Bus SDK) rather than one done in an upstream dependency.

FWIW I just chatted with @ramya-rao-a and I now agree with her point about not wanting this change in amqp-common. I thought the associated link was a more common AMQP convention but it's really specific to service bus/event hubs, so I agree amqp-common isn't the right place to make the change. Headers are part of the message contents (similar to HTTP where headers are considered part of a request/response).

Got it, thanks for clarifying - please take a look again @bterlson @ramya-rao-a
Based on notes from @AlexGhiondea updated description to not be a blocker for issue# 2288 in azure-sdk-for-js repo, and tracking this as part of https://github.com/Azure/azure-sdk-for-js/issues/2361 instead

Thanks @ramya0820

Can anyone merge this PR?
@bterlson @ramya-rao-a @AlexGhiondea


How to set up Nuxt.js with Nginx

I would like to ask for some tutorial or advice on how to set up Nuxt.js + Express.js (whatever) with Nginx. I have some problems with loading and caching files by Nginx. My public path is wrong.

run your node server ( npm run start ) on port 3000
and add nginx host proxy_pass 80 to 3000 .
https://www.digitalocean.com/community/tutorials/how-to-set-up-a-node-js-application-for-production-on-ubuntu-16-04
is this helpful ?

@ausir0726
Nope, I am run the application and everything looks nice, except console log in chrome.
I have a lot of 404 errors in "public", it looks like I have a bad configuration for public directory.
My conf: https://d3uepj124s5rcx.cloudfront.net/items/362C0z1b0h0I05281m2K/Image 2017-04-02 at 12.21.25 PM.png

maybe you don't need setting root folder
just forward 80 to 3000
server {
    listen 80;
    server_name dev.nuxt;
    location / {
        proxy_pass http://localhost:3000;
        proxy_http_version 1.1;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Connection 'upgrade';
        proxy_set_header Host $host;
        proxy_cache_bypass $http_upgrade;
    }
}

if you just run http://localhost:3000
is also got public error ?

@ausir0726
I am changed the config in Nginx and server still doesn't working. https://cl.ly/joLi
It's weird because the application is working, although in the console still has errors.
In localhost:3000 without Nginx application works properly and looks like static files are read from public dir.
Localhost: http://localhost:3000/public/vendor.bundle.00f8a7a6911fb6e55d16.js - 304
Nginx: http://dev.nuxt/public/manifest.00f8a7a6911fb6e55d16.js - 404

@ald890 ummm....
but if you use nuxt/express template .
those file should in nuxt folder ..
do you have change it ?

@ausir0726
I solved this error, in nginx conf.
I don't have the "dist" folder with assets.
location ~* \.(?:css|js)$ {
                expires 1y;
                access_log off;
                add_header Cache-Control "public";
}

To fix this I create bundle with command "nuxt build" and then nuxt create folder
"./nuxt/dist/", before that I was used "npm run build" and this command don't make this folder so nginx wasn't see files.
But now I have another errors...
"[Vue warn]: The client-side rendered virtual DOM tree is not matching server-rendered content. This is likely caused by incorrect HTML markup, for example nesting block-level elements inside , or missing . Bailing hydration and performing full client-side render. "
I was change my template to simple as possible.
<template>

Hello

 </template>

And I have still errors.

@ald890
do you have used some client-side only package ?
that could make client-side rendered virtual DOM tree is not matching server-rendered content .
If the function to be displayed is normal, I personally ignore it ....

@ausir0726

How to fix errors with client-side rendered virtual DOM
In "express-templte" https://github.com/nuxt/express
commands "nuxt build" doesn't working, but with "npm run build" templates works.

How to fix errors with Nginx caching
In Nginx conf:
root /project_path;
In Nuxt project copy all files from "project_path/./nuxt/dist" to "project_path/_nuxt"
Then Nginx can see static files, I don't think this is the best solution... https://nuxtjs.org/api/configuration-build#publicpath

Strange becouse I have everything working out of the box. Few days ago generated Let's Encrypt for nuxt/express, and I just point .public folder in nginx config (for certbot). As for app files in public folder - I can acess them in public folder without any of your nginx config. Try to delete all of this, and start with simple proxy.

server {

        listen 80;
        listen [::]:80;
        server_name example.top;
        return 301 https://$server_name$request_uri;

}

server {

        listen 443 ssl http2;
        listen [::]:443 ssl http2;
        include snippets/ssl-example.top.conf;
        include snippets/ssl-params.conf;

        location / {
                proxy_pass http://localhost:3000;
                proxy_http_version 1.1;
                proxy_set_header Upgrade $http_upgrade;
                proxy_set_header Connection 'upgrade';
                proxy_set_header Host $host;
        }

        location /.well-known {
                root /home/ubuntu/again/222/static;
        }
}

server {

        listen 80;
        listen [::]:80;
        server_name old.example.top;
        return 301 https://$server_name$request_uri;

}

server {

        listen 443 ssl http2;
        listen [::]:443 ssl http2;
        server_name old.example.top;
        include snippets/ssl-example.top.conf;
        include snippets/ssl-params.conf;

        location / {
                proxy_pass http://localhost:5000;
                proxy_http_version 1.1;
                proxy_set_header Upgrade $http_upgrade;
                proxy_set_header Connection 'upgrade';
                proxy_set_header Host $host;
        }
}

@kodekrendel
The reverse proxy works properly from the box.
I have problems with caching static files, but I solved this problem.

@ald890 ok, now I get it. I don't think manual copy files is the best solution. Or you speak about another solution?
"[Vue warn]: The client-side rendered virtual DOM tree is not matching server-rendered content. This is likely caused by incorrect HTML markup, for example nesting block-level elements inside

, or missing . Bailing hydration and performing full client-side render. "

I think everybody have this error now. Not sure why, but everyone says you can ignore it.

@kodekrendel
I also think about manual copying files is a bad idea but in the docs is explained this topic https://nuxtjs.org/api/configuration-build#publicpath
 The client-side rendered virtual DOM tree... - this error shows only when I run "nuxt build", but if I run "npm run build" errors are not showing up.

@kodekrendel
Nginx is better for serve and cache static files.
You can look for results - better results belongs to the Nginx ofc :)
This is a very simple example, but if you have a lot of images this is big difference.
https://cl.ly/joQ7

@ald890, look at the configuration below, it serves static files through nginx if available or fall back as a request to express. I believe that is what you want.
    /// nuxt.config.js
     ....
      generate: {
        dir: r('./public')
      },
   ...

            // /etc/nginx/sites-enabled/example.app
            server {
	    listen 80;
	    listen 443 ssl http2;
	    server_name example.app;
	    root "/var/www/example/public";

	    charset utf-8;

	    location / {
		try_files $uri $uri/ @proxy;
	    }

	    location @example {
		proxy_set_header X-Real-IP $remote_addr;
		proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
		proxy_set_header Upgrade $http_upgrade;
		proxy_set_header Connection "upgrade";
		proxy_set_header Host $host;
		proxy_http_version 1.1;
		proxy_pass http://<IP_ADDRESS>:3000;
	    }

	    access_log off;
	    error_log  /var/log/nginx/example-error.log error;

	    #ssl_certificate     /etc/nginx/ssl/example.crt;

	    #ssl_certificate_key /etc/nginx/ssl/example.key;
	}

For me it worked by only changing publicPath to '/dist/'
nuxt.config.js
...
build: {
  publicPath: '/dist/'

...

And in Nginx I put as path root the directory '.nuxt'
my-domain.conf

@ausir0726 thanks
it's works for me


It would be a good idea to have the "target" section select targets according to the type chosen

For example, when choosing the type self, the effect you want to cause is automatically directed to the spell's autor or feature in the chat.

This would make it much easier for both the master and the player to reduce time between turns and errors when marking wrong objectives (which happens a lot).

Also if other variations that involve an area taget such as cylinders are possible, there are already some modules that automatically select you when you put some AoE on the layer.

It could even be a reusable tool when reselecting the area from the menu of Measurement Controls.


Add directory sharding step in wikipedia article

If this step is missing, some of the tips of the article regarding the command line have problems.

Closing due to age.


Support New TSS (Thread Specific Storage) API of Python 3.7

TLS (Thread Local Storage) API will be deprecated as https://github.com/python/cpython/blob/731e18901484c75b60167a06a0ba0719a6d4827d/Include/pythread.h#L81-L92 and TSS (Thread Specific Storage) API is newly added as https://github.com/python/cpython/blob/731e18901484c75b60167a06a0ba0719a6d4827d/Include/pythread.h#L98-L142.
see also https://www.python.org/dev/peps/pep-0539/
pythread.pxd does not support it yet https://github.com/cython/cython/blob/31752522d88f03642fb9c17474135cb16d2fe474/Cython/Includes/cpython/pythread.pxd.

Pull request welcome.
This probably also means that we should update the TLS usage inside of Cython itself, specifically in the FastGil code in ModuleSetupCode.c.

Is there a way to use preprocessors like #if PY_VERSION_HEX >= 0x03070000 in pythread.pxd?

You don't have to. Just declare them there. Users will have to take care that they are only used when available.
That being said, it's probably possible to backport the API to older CPython versions by defining Py_tss_t as a simple struct containing an int as native key, and then using that as key value in the old TLS C-API. There is already lots of compatibility code in ModuleSetupCode.c, so it shouldn't hurt much to add it there.

fixed via https://github.com/cython/cython/pull/1939


does it support files?

Does it support (or planning to) support files? As PrivateGPT for instance. Thank you.

Sorry for the late response.
Because this bot is based on the ollama api, I don't think it will support files soon.


Test Support for correlation logs

This PR contains the same commits in the PR 12950. Refer that PR for more information.
Note - Since the author of the above mentioned PR is no longer with the company and there are changes that needed to be done to the PR, we are unable to add any changes to that PR.
Because of that, another approach was needed to merge this PR. This issue is tracked by this issue.
cherry-picked those commits to a branch which was rebased with the current product-apim and added the required changes by another commit.

Note - Before Merging, we should bump relevant carbon.apimgt PR and carbon.mediation PR versions. This PR is blocked till those builds are available.


Code release

Hello, thank you for sharing the great work.
I wonder when the code will be released.
Also, I have a question about the intuition of using an unmasked teacher in UMT and InternVideo2.
Why do you use feature distillation rather than directly adopting MAE-family models?

Waiting to test out the models!!

waiting...


Update build.sbt file so that IntelliJ can parse/understand the project

Update build.sbt file so that IntelliJ can parse/understand the project and it loads without errors.
Unit tests all succeed.

Codecov Report

Merging #1164 (8e1fc5b) into master (8bd9aec) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1164      +/-   ##
==========================================
+ Coverage   81.25%   81.32%   +0.07%
==========================================
  Files         122      122
  Lines        3958     3958
  Branches      121      121
==========================================
+ Hits         3216     3219       +3
+ Misses        742      739       -3

Impacted Files
Coverage Δ

...e/akka/actor/process_index/ProcessIndexProto.scala
98.11% <0.00%> (+0.94%)
:arrow_up:

...ala/com/ing/bakery/baker/InteractionRegistry.scala
80.95% <0.00%> (+4.76%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd9aec...8e1fc5b. Read the comment docs.


Asutula/pull upstream

Pulling it updates, mostly to get updated Android project configuration that should be compatible with our updated Android project and updated RN

Also ended up removing what we added for raw multipart uploads... It was causing compilation problems with the rest of these updates, and I don't think we have any use for it anymore, so it was easiest to just remove it. Cool @sanderpick and @andrewxhill ?


standardize multi-versioning suffix pattern in all-packages.nix

Issue description
There are currently multiple different ways packages with multiple versions in all-packages.nix are named.
As this can be is confusing, it would be better to have a common pattern for versions suffixes.
Non exhaustive list:
packageVVV

php55
python33
perl520
ghc801
erlangR18
gcc49
jdk7

package_V_V

ruby_1_9
scala_2_11
ocaml_3_08_0
guile_2_1

other patterns

package-V_x: nodejs-6_x
packageV_V: lua5_0

In certain cases we have multiple versions because we want to support all those versions (e.g. Python interpreters) whereas in other cases we just need that version for a single or a couple of other packages. I've noticed that in python-packages.nix the format package_V_V is mostly used.
My preference is packageVV because it is shortest. If it is not in the guidelines I suggest adding this.

I'd prefer package_V_V as it isn't ambiguous.

@globin could you give an example of when another pattern would be ambigious?
Thinking a bit further about it. We also have suffixes like -unstable and. To stay in line with those we should maybe have package-VV (or package-V_V although I find that rather ugly and confusing) instead?

Currently only theoretically, but if we have package_1, package_1_0, package_10 and package_10_0 that would be ambiguous. Apart from that I think it's easier to parse visually.

It's not even theoretical, we have spidermonkey_1_8_0rc1 and spidermonkey_185 currently (1.8.0rc1 and 185 respectively).

Another theoretical issue: rustc-1110. I'm voting against the short version, the ambiguity is very annoying.

I thought the manual said versioned attributes should be named foo-1-2, but I cannot find that reference anymore.

I'm in favor of package_V_V. Note that in a few rare cases the package name includes part of the version, as in python3. Not sure if we should use python3_3 or python_3_3 (probably the former to be consistent with the python3 attribute).

Not sure if we should use python3_3 or python_3_3 (probably the former to be consistent with the python3 attribute).

python3 should not be a separate attribute. Instead, if multiple python versions can be chosen, they shall be stored in a set (dict, list, etc.) which can be used to determine the requested python version(s).

Ah, there it is [1]:

If there are multiple versions of a package, this should be reflected in the variable names in all-packages.nix, e.g. json-c-0-9 and json-c-0-11. If there is an obvious “default” version, make an attribute like json-c = json-c-0-9;

[1] https://nixos.org/nixpkgs/manual/#sec-package-naming

We have it there but I think most cases don't follow it :-)

Can we conclude that we go for package_V_V and that the manual should be updated to reflect this decision?

I actually think if the range of versions is small for a certain package that it should be fine to just use packageXX as well. E.g., in the case of Python we only expose 2.7 to 3.5. We don't include minor versions (e.g. 3.5.2). We do have 2 and 3, but I think to anyone using these packages it would be obvious what it would refer to.
With spidermonkey that's not really the case. Version numbers can be very different, so there it would be good to use a method which is unambiguous, like package_V_V.
However, while I think it's clear what the Python version digits imply, it might not be the case when we would support multiple versions of pypy. In that case you would have to refer to the Python language version, and the PyPy version, so you might get something like pypy3_5_5 to refer to version 5.5 of the Python 3 compatible PyPy interpreter.

It should be noted that in practice single version components are joined with the attribute differently than multiple version components: the former tend to have no separator and the latter tend to be separated by underscores. (Personally I also like this arrangement.) See the classification of python-packages.nix at https://github.com/NixOS/nixpkgs/pull/25261#issuecomment-298260713.

I recently opened a similar topic on Discourse and came to a similar result on what seems to be the consensus here.

Closing as this should be a RFC, so that we could reach some kind of consensus on this question.
Feel free to reopen something against https://github.com/NixOS/rfcs/ , preferably pointing to this as prior discussion and summing the discussions here up :)

We should definitely change the docs to something else because it's out of touch by two orders of magnitude.
8 attributes satisfy [a-zA-Z]-[0-9]+(-[0-9]+)+ =.  (nix-2-5)
689 attributes satisfy [a-zA-Z]_[0-9]+(_[0-9]+)+ = (nix_2_5)
17 attributes satisfy [a-zA-Z]-[0-9]+(_[0-9]+)+ = (nix-2_5)

The verson part is clear cut. The data speaks for itself; no need for an RFC. See comment above and PR: https://github.com/NixOS/nixpkgs/pull/156857


Reader Tap Zones not working

Steps to reproduce

Open Aniyomi
Set desired Tap Zone
Open a manga

Expected behavior
The tap zones should be registered correctly
Actual behavior
The tap zones no matter which ones I use do not work
Crash logs
No response
Aniyomi version
<IP_ADDRESS>
Android version
Android 13.1.0
Device
Infinix GT10 Pro
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] If this is an issue with an official manga extension and this issue can be replicated in the Tachiyomi app, that I should be opening an issue in Tachiyomi's extensions repository.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Almost same issue for me. Only when I aim and tap perfectly in a small area around the middle of the screen that tapping to the next page works on manhwa. No issue on manga where it's one page per screen.
Was working fine in Tachiyomi in any zone.

@https://github.com/aniyomiorg/aniyomi/issues/1294
This issue fixed and will be added in version 0.15.3


Fix: Git config conflicts with other actions

This probably should have been the functionality anyway, but the reason for this change is to avoid conflicts with git configurations set by other actions running in the same workflow.
For example, using another action like Import GPG to enable gpg signing would have failed before since the sync action overrode any git config values that Import GPG would have set. Now the sync sets config values a little more carefully - i.e. only when they're empty.
An example of using Import GPG on the sync wiki - https://github.com/aormsby/Fork-Sync-With-Upstream-action/wiki/GPG-Signing
This PR 's changes are currently testable by setting uses: aormsby/Fork-Sync-With-Upstream-action@feature/gpg in your workflow's sync step.
Fixes issue #33

Excellent I’ll try this shortly.  Your program has been working flawlessly as part of our CI/CD platform.

I am testing now! On the wiki just a cosmetic change, you have two "# Step 2:" may want to increment the second to step 3 :). I will report back on the run is complete on how I made out.

Test passed. Wiki instructions are clear and followed. all working great. I am waiting for an upstream repo change but a dry run looks fine. I expect an upstream repo change today and will report back.

All tests have been completed successfully and no other impacts were noted. I'd suggest this be merged to master!
Thank you again for all your work on this and the detailed wiki.


[SPARK-33933][SQL][3.0] Materialize BroadcastQueryStage first to avoid broadcast timeout in AQE

This PR is the same as https://github.com/apache/spark/pull/30998 to merge to branch 3.0
What changes were proposed in this pull request?
In AdaptiveSparkPlanExec.getFinalPhysicalPlan, when newStages are generated, sort the new stages by class type to make sure BroadcastQueryState precede others.
It can make sure the broadcast job are submitted before map jobs to avoid waiting for job schedule and cause broadcast timeout.
Why are the changes needed?
When enable AQE, in getFinalPhysicalPlan, spark traversal the physical plan bottom up and create query stage for materialized part by createQueryStages and materialize those new created query stages to submit map stages or broadcasting. When ShuffleQueryStage are materializing before BroadcastQueryStage, the map job and broadcast job are submitted almost at the same time, but map job will hold all the computing resources. If the map job runs slow (when lots of data needs to process and the resource is limited), the broadcast job cannot be started(and finished) before spark.sql.broadcastTimeout, thus cause whole job failed (introduced in SPARK-31475).
The workaround to increase spark.sql.broadcastTimeout doesn't make sense and graceful, because the data to broadcast is very small.
Does this PR introduce any user-facing change?
NO
How was this patch tested?

Add UT
Test the code using dev environment in https://issues.apache.org/jira/browse/SPARK-33933

Can one of the admins verify this patch?

Can one of the admins verify this patch?

The failure is relevant to AQE. Could you take a look at it, @zhongyu09 ?

The failure is relevant to AQE. Could you take a look at it, @zhongyu09 ?

The failure is relevant to AQE. Could you take a look at it, @zhongyu09 ?

I will have a look.

The failure is relevant to AQE. Could you take a look at it, @zhongyu09 ?

I will have a look.

Thanks!

Thanks!

ok to test

ok to test

Test build #133820 has started for PR 31084 at commit 03c9b09.

Test build #133820 has started for PR 31084 at commit 03c9b09.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38409/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38409/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38409/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38409/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38409/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38409/

Hi @dongjoon-hyun
I try the test tens of times and the test failed twice.
As we discussed with @viirya and @cloud-fan in https://github.com/apache/spark/pull/30998, the solution is not perfect. The order of calling materialize can guarantee that the order of task to be scheduled in normal circumstances, but, the guarantee is not strict since the submit of broadcast job and shuffle map job are in different thread. So there's still risk for the shuffle map job schedule earlier before broadcast job. I wonder should we need to remove the UT until we thorough resolve the issue.

Hi @dongjoon-hyun
I try the test tens of times and the test failed twice.
As we discussed with @viirya and @cloud-fan in https://github.com/apache/spark/pull/30998, the solution is not perfect. The order of calling materialize can guarantee that the order of task to be scheduled in normal circumstances, but, the guarantee is not strict since the submit of broadcast job and shuffle map job are in different thread. So there's still risk for the shuffle map job schedule earlier before broadcast job. I wonder should we need to remove the UT until we thorough resolve the issue.

Test build #133820 has finished for PR 31084 at commit 03c9b09.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #133820 has finished for PR 31084 at commit 03c9b09.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133820/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133820/

Got it. I'm not sure about removing UTs.
WDYT, @cloud-fan and @HyukjinKwon ?

Got it. I'm not sure about removing UTs.
WDYT, @cloud-fan and @HyukjinKwon ?

Retest this please

Retest this please

Test build #133857 has started for PR 31084 at commit 03c9b09.

Test build #133857 has started for PR 31084 at commit 03c9b09.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38446/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38446/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38446/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38446/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38446/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38446/

Test build #133857 has finished for PR 31084 at commit 03c9b09.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #133857 has finished for PR 31084 at commit 03c9b09.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133857/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133857/

The same test case failed in Jenkins Maven environment again. (https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133857/testReport)
- SPARK-33933: AQE broadcast should not timeout with slow map tasks *** FAILED ***
  1693 was not greater than 2000 (AdaptiveQueryExecSuite.scala:926)
14:59:38.190 WARN org.apache.spark.sql.execution.adaptive.AdaptiveQueryExecSuite:

The same test case failed in Jenkins Maven environment again. (https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133857/testReport)
- SPARK-33933: AQE broadcast should not timeout with slow map tasks *** FAILED ***
  1693 was not greater than 2000 (AdaptiveQueryExecSuite.scala:926)
14:59:38.190 WARN org.apache.spark.sql.execution.adaptive.AdaptiveQueryExecSuite:

I'm wondering if this test is stable in master and branch-3.1.

I'm wondering if this test is stable in master and branch-3.1.

I'm wondering if this test is stable in master and branch-3.1.

Yes, also not stable in master. I create a PR to remove the UT.  https://github.com/apache/spark/pull/31099

I'm wondering if this test is stable in master and branch-3.1.

Yes, also not stable in master. I create a PR to remove the UT.  https://github.com/apache/spark/pull/31099

A partial fix is fine but let's make sure to mention/document what cases the partial fix does not cover.

A partial fix is fine but let's make sure to mention/document what cases the partial fix does not cover.

I reverted it for now for RC preparation . Let's make a PR with clarifying which case it doesn't cover, and why this is a partial fix.

I reverted it for now for RC preparation . Let's make a PR with clarifying which case it doesn't cover, and why this is a partial fix.

I reverted it for now for RC preparation . Let's make a PR with clarifying which case it doesn't cover, and why this is a partial fix.

For partial fix, it is difficult to give an stable UT. I would rather give an stable fix. I think two directions:

make sure broadcast job is submitted before shuffle map job, the calling of materialize() for non-broadcast query stage should wait until all the broadcast jobs are submitted.
excluded the schedule time for broadcast job when we calculate time out. This is very hard to measure. For downgrade, perhaps we can measure the time for pure broadcast, that is, minus collect time. But this also has big changes, as well as changes for non-AQE.

I prefer for #1, it behavior more like non-AQE and is this PR's original intention and will have less impact to non-AQE.

I reverted it for now for RC preparation . Let's make a PR with clarifying which case it doesn't cover, and why this is a partial fix.

For partial fix, it is difficult to give an stable UT. I would rather give an stable fix. I think two directions:

make sure broadcast job is submitted before shuffle map job, the calling of materialize() for non-broadcast query stage should wait until all the broadcast jobs are submitted.
excluded the schedule time for broadcast job when we calculate time out. This is very hard to measure. For downgrade, perhaps we can measure the time for pure broadcast, that is, minus collect time. But this also has big changes, as well as changes for non-AQE.

I prefer for #1, it behavior more like non-AQE and is this PR's original intention and will have less impact to non-AQE.