Balanced_braces

program to check whether braces are balanced are not using stack
Description of Change

Checklist

[ ] Added description of change
[ ] Added file name matches File name guidelines
[ ] Added tests and example, test must pass
[ ] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
[ ] Relevant documentation/comments is changed or added
[ ] PR title follows semantic commit guidelines
[ ] Search previous suggestions before making a new one, as yours may be a duplicate.
[ ] I acknowledge that all my contributions will be made under the project's license.

Notes:

this is my first contribution  please give more info. for enhancement and documentation i have added proper comments


Overhaul and port deTiN

The algorithm is basically reasonable but needs some touching-up.

Actually, does anyone care about doing this?

I assume the cancer people do?

People care about being able to filter out artifacts that are due to tumor DNA present in the normal sample. How that is to be done is entirely up to you.

@LeeTL1220 @vdauwera Is it our responsibility?  Do you see it as being part of the Mutect wdl?  And what artifacts does tumor-in-normal create?  Naively I would expect it to do the opposite i.e. decrease sensitivity by flagging true somatic variants as germline events.
If this is important I would consider putting in our next quarterly goals.  The time investment would be similar to the new contamination tool, about 3 weeks

I would like us to consider this part of the somatic short variants discovery pipeline (which is probably what you mean by Mutect wdl). I'm not sure how urgently we need it, probably "not very urgent in the scheme of things, but should be done eventually". I assume @LeeTL1220 has a better idea of what we need when on the somatic side of things.
And you're right that this creates a loss of sensitivity, not false positives. I'm being distracted by a tiny human.

We should do it.  Generally, I agree with Geraldine's statement about
urgency, though.  We can meet to discuss prioritization relative to other
auxiliary tools.
On Tue, Mar 14, 2017 at 11:15 AM, Geraldine Van der Auwera <
<EMAIL_ADDRESS>wrote:

I would like us to consider this part of the somatic short variants
discovery pipeline (which is probably what you mean by Mutect wdl). I'm not
sure how urgently we need it, probably "not very urgent in the scheme of
things, but should be done eventually". I assume @LeeTL1220
https://github.com/LeeTL1220 has a better idea of what we need when on
the somatic side of things.
And you're right that this creates a loss of sensitivity, not false
positives. I'm being distracted by a tiny human.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/broadinstitute/gatk-protected/issues/800#issuecomment-286453446,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACDXk6kK5A_Mhh9S3s4xX_EEZQlwtKvGks5rlq8hgaJpZM4K3d-Q
.

--
Lee Lichtenstein
Broad Institute
75 Ames Street, Room 7003EB
Cambridge, MA 02142
617 714 8632

Issue moved to broadinstitute/gatk #2919 via ZenHub


Add Empirical Distribution

Third time is a charm??

I guess so, practice makes perfect?  There should be a change log from previous implementations right?

truncation still needs to be handled


SELECT query does not print folders from recursive paths.

A simple SELECT query should be able to identify the relative path of a file, which should include its folder name.
Example:
fsql "SELECT * from /Users/---/vagrant/jenkins"

prints:
`-rw-r--r--	5248	Dec  7 14:28:14	b874568	config.xml`

instead of:
-rw-r--r--	5248	Dec  7 14:28:14	b874568	jobs/1/config.xml

@fubarhouse, thanks for the issue! I agree, relative path definitely makes more sense than just the filename (note that you can get the full path using the FULLPATH attribute modifier).
Kind of limited on time right now, so I'm marking this as help wanted (feel free to give it a go, if you'd like!), but will definitely try to get around to it in the coming weeks.

@kshvmdn I've got a one-liner which switches the name out for the path in the walk function.
I've no idea how you want to control this - always on vs optional on, flags etc.
But, for the argument of functionality, I would expect it to always provide the path, rather than the name.
func(path string, info os.FileInfo, result map[string]interface{}) {
	result["name"] = path
	results = append(results, result)

So, this one line makes it do what I would expect it to.
If you'd like this submitted as a PR let me know - but it is one line which might cause a difference in behaviour elsewhere for you.

@fubarhouse, sorry for the late response – just got the chance to play around with this.
This solution works in the most basic case, but it breaks when using path-modifiers on the name attribute. I'm not sure how to resolve this just yet; I think we're going to have to play around with how names/paths are handled in the format step, maybe use filepath.Rel with the inputted path(s) to get each file's relative path.
Nevertheless, feel free to create the PR, I can merge it to an off-branch and then make changes there. Thanks for taking a look!

PR #38 has been created.


Problems with assembly via cmake

hello everyone!
I'm trying to build RetDec via cmake, but he's not complaining about python on a permanent basis. Python "Could NOT find Python3 (missing: Python3_EXECUTABLE Interpreter) (Required
is at least version "3.4")"
cmake -DCAPSTONE_LOCAL_DIR="G:\Programs\Soft\Coding\C\VisualStudio\Coders\CapstoneWin64\capstone"  -DPYTHON_LOCAL_DIR="G:\Programs\Soft\Coding\C\VisualStudio\Coders\Python-3.9.0\PCbuild\amd64" -DCMAKE_INSTALL_PREFIX="G:\Programs\Soft\Coding\C\VisualStudio\Coders\retdec-5.0" -G"Visual Studio 16 2019" -DRETDEC_ENABLE_ALL=ON ..

Why is he acting like this?

I solved the problem. To save other people's time:
cmake -DCAPSTONE_LOCAL_DIR="G:\Programs\Soft\Coding\C\VisualStudio\Coders\CapstoneWin64\capstone" -DCMAKE_INSTALL_PREFIX="G:\Programs\Soft\Coding\C\VisualStudio\Coders\retdec-5.0" -G"Visual Studio 16 2019" -DRETDEC_ENABLE_ALL=ON ..

Python should either be specified in system variables and not a folder should be specified to it, namely itself .exe he interpreter like this
C:/Users/NAME/AppData/Local/Programs/Python/Python311/python.exe


ImportError: No module named 'modules._ext.__ext'

Hi,
in modules/_ext/init.py, line 2
from .__ext import lib as _lib, ffi as _ffi
I couldn't find __ext, is there something missing?
I have installed inplace_abn.
Thanks for your help

Fixed by executing
cd modules/
python3 build.py

Thanks!

Hi! When trying to run your suggested Code, I encounter the following Error:
TypeError: dist must be a Distribution instance
All the suggestions I have researched did not work. Could you tell me which versions of pytorch etc you are using?


Track 170

https://eao-dst.atlassian.net/jira/software/c/projects/TRACK/boards/10?selectedIssue=TRACK-170
Migration is needed for unit tests to pass. Have to update the new work types that were added is_active to true otherwise during test setup it fails
In resource_forecast_report.py add filter is_active == True to ensure when getting the staff we are only getting the current active one

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (develop@ad6f6e5). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2408   +/-   ##
==========================================
  Coverage           ?   77.82%
==========================================
  Files              ?      293
  Lines              ?     9808
  Branches           ?        0
==========================================
  Hits               ?     7633
  Misses             ?     2175
  Partials           ?        0

Flag
Coverage Δ

epictrack-api
77.82% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


perf(api): speed up requires_version

Overview
This is a performance PR to address RSS-144 and do some re-organization of the APIVersion interface and friends to make navigating the code a bit easier.
Changelog

Rework the requires_version decorator for speed

Do not set unused attribute on the method
Flip if around so more common "version check is ok" condition is the first branch

Move APIVersion, APIVersionError, MAX_SUPPORTED_VERSION, and MIN_SUPPORTED_VERSION to be exports of opentrons.protocol_api

APIVersion and APIVersionError are already publicly declared types, so having them come out of opentrons.protocol_api is a more client-friendly export
Previous homes were opentrons.protocols.api_support.types and opentrons.protocols.api_support.utils, respectively
MAX_SUPPORTED_VERSION and MIN_SUPPORTED_VERSION were already exported from opentrons.protocol_api, so I moved their source of truth from the old home of opentrons.protocols.api_support.definitions

Review requests

Performance changes make sense

I did some actual light profiling of this that I could dig up and post, if people are interested

Exports re-orgs make sense

Is there a risk here that I'm not thinking about?

Risk assessment
Low, unless we expect protocol authors to have been importing APIVersion, for some reason. Given that its home has changed over the years, I would find that unlikely

I'm neutral on the reorganization. What makes you say APIVersion and APIVersionError are publicly declared?

Both of them are called out by name in the public docs, though not spec'd any further than that.
APIVersion example:

property api_version: APIVersion
Return the API version supported by this protocol context.
The supported API version was specified when the protocol context was initialized. It may be lower than the highest version supported by the robot software. For the highest version supported by the robot software, see protocol_api.MAX_SUPPORTED_VERSION.
New in version 2.0.

APIVersionError example:

Changed in version 2.13: Adds the prep_after argument. In version 2.12 and earlier, the plunger can’t prepare itself for aspiration during pick_up_tip(), and will instead always prepare during aspirate(). Version 2.12 and earlier will raise an APIVersionError if a value is set for prep_after.


Add support for .attachments in non-root folder

First of all - thank you for the great tool. Exactly what I have been looking for.
Small improvement:
In order to also manage an Azure Devops "code wikis" (https://docs.microsoft.com/en-us/azure/devops/project/wiki/publish-repo-to-wiki) I would like to suggest to allow the .attachments folder to be located in a subfolder.
For example, if I have a repo like this where the wiki folder represents my entire code wiki (simplified here of course):
$
  src
    ...
  wiki
    .attachments
      cat.png
    .order
    doc.md

I would like to be able to reference images in my markdown files like this: /wiki/.attachments/cat.png and still get it fixed during conversion.
The simple fix in this PR does the trick.
With that fix, it will be possible to have .attachments folders in:

root of repo
root of code-wiki folder
any subfolder of the code-wiki folder

I would then just run the tool as usual with the -s arg pointing to the wiki folder.

@phatcher Is this PR something you would be interested in? Please let me know if there is something you want me to change/update.

@ricfre Apologies, had a decent break and only just picking this up - I think I've already subsumed this in a current branch as I had this issue internally as well but I'm trying to improve the testability of the code.
I should do a push in the next couple of days so you can see if it fixes your problem.
BTW Thanks for the PR, hopefully more people will find this project useful.

@phatcher Ah, that sounds great! I will keep my eyes open for the new push.
Thank you for the work. Let me know if I can assist in some way.

@ricfre Can you checkout the feature/tests branch and see if works for your scenario now; I have tests showing copying of attachments in subfolders.
I'm also surprised that the earlier commit in October to fix attachment subfolders also wasn't good enough

@phatcher Thank you for the update. I have now checked out the feature/tests branch and tested my use-case. Unfortunately it does not work.
My use case is related to having the entire wiki in a subfolder of the repo (meaning that the .attachments folder is not in the root of the repo, which in turn results in a situation where the image links cannot just start with /.attachments (well, they can from the AZ Devops point of view, but VS Code does not like it at all, making local editing a pain).
As simple way to repeat my use case is to modify the src\WikiExport.Core.Test\Samples\Sample.wiki\S1\Bar.md like below:

The test ExporterFixture\DefaultOptions test will now fail.
Adding my first commit (f4db670) fixes that.
My second commit (e8c8d19) is about maintaining the use of forwardslash in the resulting markdown. Mostly to keep things tidy, but also because I have found that popular VS Code plugins (like Markdown PDF for example) may have problems with the backslash.
Today I also realized that it would be good with an additional ? in the regex in order to support image links of both these types:

.attachments/image.png
../attachements/image.png

The below still being supported of course.

/.attachments/image.png

I have pushed the regex fix as well (7fa698c). I'm not that sure about the tests. I seems like I maybe should create another PR based on the feature/tests branch in order to add some specific tests for my use case?

@ricfre I'll merge feature/tests down to main, if you update your PR to do the change your suggested to one of the image references and fix up the tests then I can accept it.
You can put a comment in the wiki page saying it shows an image from a non-root directory.

@ricfre I've merged the changes back to main, you'll need to a few changes but shouldn't be too hard to fixup

@phatcher I have now merged and adjusted to the new approach. Also added and adjusted some unit tests.


gazelle does not rewrite build files from vendored go code

What version of gazelle are you using?
0.40.0
What version of rules_go are you using?
0.50.1
What version of Bazel are you using?
7.4.1
Does this issue reproduce with the latest releases of all the above?
Those are latest releases
What operating system and processor architecture are you using?
linux/amd64
What did you do?
As mitigation to #1977, we start to vendor via go mod vendor.
go mod vendor keeps build files from go dependencies if they exist. Some of our go dependencies (github.com/grpc-ecosystem/grpc-gateway & github.com/google/flatbuffers) have build files using io_bazel_rules_go. For example: https://github.com/grpc-ecosystem/grpc-gateway/blob/195cb0fb4abb13a20b42dc97dd754fc81e28b63d/utilities/BUILD.bazel#L1.
We use rules_go as the name in our MODULE.bazel:
...
bazel_dep(name = "rules_go", version = "0.50.1")
...

And after go mod vendor, bazel run //:gazelle -- fix also left those build files untouched (it generates build files for vendored directories lacking them, but not change them if they already exists), resulting in the code won't build because io_bazel_rules_go cannot be resolved.
Currently we just run buildozer after bazel run //:gazelle -- fix:
buildozer 'substitute_load ^@io_bazel_rules_go//(.*)$ @rules_go//${1}' //vendor/...:__pkg__

But it would be great if gazelle can (provide an option to) fix them so we don't have to use buildozer.
What did you expect to see?
What did you see instead?

I guess we can also do this between go mod vendor and bazel run //:gazelle --fix to force gazelle to regenerate all build files:
find vendor/ \( -name "BUILD" -or -name "BUILD.bazel" \) -delete


HKDF context re-use issue

Normally with all openssl algorithms I've used (at least with cipher, digest and a few others), if you re-init the context structure, it can be re-used to perform another round of the same algorithm.
But for some reason this doesn't work for HKDF.
This demo code was compiled and linked with openssl 1.1.1 on Linux
#include <string.h>
#include <stdio.h>

#include <openssl/evp.h>
#include <openssl/kdf.h>

int main(int argc, char *argv[])
{
	int i;
	int try = 0;
	EVP_PKEY_CTX	*pctx;
	const EVP_MD	*md;

	uint8_t inkey[] =	"\x0b\x0b\x0b\x0b\x0b\x0b\x0b\x0b\x0b\x0b\x0b";
	uint8_t salt[] =	"\x00\x01\x02\x03\x04\x05\x06\x07\x08\x09\x0a\x0b\x0c";
	uint8_t info[] =	"\xf0\xf1\xf2\xf3\xf4\xf5\xf6\xf7\xf8\xf9";
	uint8_t outkey[] =	"\x08\x5a\x01\xea\x1b\x10\xf3\x69\x33\x06\x8b\x56\xef\xa5\xad\x81\xa4\xf1\x4b\x82\x2f\x5b\x09\x15\x68\xa9\xcd\xd4\xf1\x55\xfd\xa2\xc2\x2e\x42\x24\x78\xd3\x05\xf3\xf8\x96";
	uint8_t outkey_cmp[sizeof(outkey)-1];
	size_t keysize = sizeof(outkey)-1;

	md = EVP_get_digestbyname("sha1");

	pctx = EVP_PKEY_CTX_new_id(EVP_PKEY_HKDF, NULL);

restart:

	if (EVP_PKEY_derive_init(pctx) <= 0) {
		printf("failed init HKDF key\n");
		goto done;
	}

	if (EVP_PKEY_CTX_set_hkdf_md(pctx, md) <= 0) {
		printf("failed to set HKDF digest\n");
		goto done;
	}

	if (EVP_PKEY_CTX_set1_hkdf_salt(pctx, salt, sizeof(salt)-1) <= 0) {
		printf("failed to set HKDF salt\n");
		goto done;
	}

	if (EVP_PKEY_CTX_set1_hkdf_key(pctx, inkey, sizeof(inkey)-1) <= 0) {
		printf("failed to set HKDF secret\n");
		goto done;
	}

	if (EVP_PKEY_CTX_add1_hkdf_info(pctx, info, sizeof(info)-1) <= 0) {
		printf("failed to set HKDF info\n");
		goto done;
	}

	if (EVP_PKEY_derive(pctx, outkey_cmp, &keysize) <= 0) {
		printf("failed to derive HKDF key\n");
		goto done;
	}

	printf("orig key: ");
	for (i=0;i<keysize;i++) {
		printf("%.2x", outkey[i]);
	}
	puts("\n");
	printf(" kdf key: ");
	for (i=0;i<keysize;i++) {
		printf("%.2x", outkey_cmp[i]);
	}
	puts("\n");

	if (memcmp(outkey, outkey_cmp, keysize)) {

		printf("keys don't match!\n");
	} else {
		printf("keys match!\n");
	}

	if (try < 4) {
		try++;
		goto restart;
	}

done:

	return 0;
}

Hmm, EVP_PKEY_derive_init doesn't seem to reset any of the previous parameters. In this case this means that the EVP_PKEY_CTX_add1_hkdf_info() call appends info to the previous info each time around the loop - rather than starting again.

Yes - I think it should. Patch on the way.

Fix in #7501.


Adding command for managing maven repositories in an installation

Cc @spyrkob, proposal for the repository command.

I think all changes are ready.


DAV Generic - Excetpio for "Depth: infinity" not allowed.

Add exception and logging for when using the DAV "generic" method and it encounters an endpoint that does not allow the "Depth: infinity" header, meaning it will be unable to recursively list and obtain the accounting for all files being held there.

v0.8.3 Added 200 status code check and handler for DAV endpoints, which also takes care with issues with Depth: infinity is not allowed (as this returns a 403 forbidden code).


Ptv 1797 - dylan_20220718

Update Kaiju to v1.9.0 and update refdata dbs
Add longtail to summary table with no collapse of rare taxa
Handle weird read IDs with index in typical fwd/rev indicator position

The rest looks good to me. IIRC when we tested the new Kaiju dbs ~1 year ago, we had some potential app output UI issues for the new databases because, at least in some cases, there were no hits to the database.
Probably just need to test a few things in the KBase narrative, let me know if I can help.

do you mean how if you use "viruses" you get all pink?  Or something else?

The rest looks good to me. IIRC when we tested the new Kaiju dbs ~1 year ago, we had some potential app output UI issues for the new databases because, at least in some cases, there were no hits to the database.
Probably just need to test a few things in the KBase narrative, let me know if I can help.

do you mean how if you use "viruses" you get all pink? Or something else?

That was one of the oddities. I'll try and dig up the test narrative to comment further.

@jungbluth I finally got the bug fixed with the multiple dots in the read id (I think it was also that Kaiju doesn't like the read ID in the delimiter line between seq and qual lines, but not 100% sure).  Anyway, I tested it on the data in PUBLIC-2055 and merged that into this branch.  I think we should finally merge this to master and push the fixes through the release process.  Can you please do a quick re-review of this so we can merge?  Thanks!

Note that we expect the Github Actions tests to fail because of the lack of refdata


Git error (128) !

I keep seeing
Git error (128) !
Press $ to see the command history

as notifications.
Not only that but pressing $ does nothing.
Is there a way to suppress these notifications ?
Btw I like your notification system and you may be interested in https://github.com/neovim/neovim/pull/13843

more worrying seems like neogit autoremoves some files, disabling neogit fixed it.

Not only that but pressing $ does nothing

I should probably change the message if the status buffer is not open, because $ is only mapped when inside the status window.

more worrying seems like neogit autoremoves some files, disabling neogit fixed it.
@teto which files were removed?

It's a file I had just renamed. Everytime I opened it with neovim it would get emptied with neogit.

Could you please tell me the steps you took to encounter this issue?

@TimUntersberger  The errors should come from the renamed file. If git detects a rename, the output looks as follows:
Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
	renamed:    a.txt -> b.txt

We then naively put that into git commands:
 128 git diff a.txt -> b.txt
 128 git diff --cached a.txt -> b.txt

I can also reproduce that file getting emptied, most likely due to those diff commands. They'd be interpreted as piping the output from the diff commands to b.txt - which is nothing since the commands fail and their only output is on stderr


RFE: double encrypt all Meshtastic messages

In some cases, one or more ATAK user groups may need to communicate over a shared, or even public Meshtastic channel - for example, when using pre-existing network infrastructure to increase coverage. In these cases, the Meshtastic built-in channel encryption layer is insufficient to ensure the secrecy and integrity of the communications.
For these cases, it would be really useful to have a second in-app encryption layer controlled from the plugin settings - which encrypts all messages prior to sending to the Meshtastic channel using a separate pre-shared key that never leaves the EUD.
Similar to the ATAK builtin function AES-256 Mesh Encryption, but for Meshtastic comms.
It would be really useful even in case of loss of a Meshtastic radio, which is currently a fatal attack vector as each radio contains the channel key in cleartext.

Would also be nice to have a way to programmatically/remotely wipe the key, and distribute a new key.
For example having a group key and a channel key, the group key is used for centralized automated operations like updating a channel key, the channel key is used to encrypt/decrypt COS traffic only.  This would enable using SMS/Meshtastic to distribute new keys.  Send a text with:
spcKpllQKBx8kYw381FBzXLJEHmV/XZUWBCLRwxVv0Y=TAK998Dgv2Pt31vmwWIxhfA4mVV7R+ZRZXO8tvuzNOznJQ=
Where "TAK" is your delineator, and it is preceded with the Sha256 hash in Base64 of "TAK, {channelname}", and followed by a new key encrypted by the group key in base64 for the key-value pair with the channel name as the key.  Nothing in plaintext that way, and should fit inside a 160 character limit for SMS/Meshtastic.

for example, when using pre-existing network infrastructure to increase coverage

My understanding is that Meshtastic will repeat all messages that meet its radio channel settings, without regard for its encryption channel settings. If there is a long-fast repeater and it hears packets, even ones that don't match its encryption, it will repeat them. You should be able to make use of existing infrastructure without sharing your keys.


Low quality exports when using Math Typesetting

As explained on the titel, when using this option and trying to export a .png for example, it doesn't show the option to zoom

Had the same problem, my workaround is to use advanced export to export the whole canvas.

Zoom and border options are added. Will be available in the next release.


EventOutcome field and value do not appear in CommonSecurityLog table

Microsoft CEF event mapping documentation says the Outcome field is mapped in the CommonSecurityLog table.

However, there's no Outcome field in the CommonSecurityLog schema.
But there's one field called EventOutcome as shown in MS Sentinel below.

Although once a CEF event arrived in the Sentinel. The outcome value does not appear in the correct field, despite the outcome being set in the raw event.

outcome value appears in AdditonalExtensions
Issue
The document version of CommonSecurityEvent schema mapping and MS Sentinel version of CommonSecurityEvent schema should be homogenous.
Bug-1
Raw events contain outcome values (success or failure) that appear in AdditionalExtension and not in the EventOutcome field.
Bug-2
Once the Raw event has the EventOutcome field, it completely disappears from the CommonSecurityEvent table.

@LaraibKhan555 The documentation for the schema change has been updated. Please refer the documentation links below:
https://learn.microsoft.com/en-us/azure/sentinel/cef-name-mapping
https://learn.microsoft.com/en-us/azure/azure-monitor/reference/tables/commonsecuritylog
Closing the issue as this is fixed.


fix bug in order.hpp to satisfy cpp11 standard

@aska-0096 : these merges should not appear on GitHub page. Are you doing them locally and accidentally pushed them to remote? Thanks!


Cannot compile gason.cpp on Visual Studio 2012 C++

This code does not compile in MS Visual Studio 2012 C++:
inline JsonIterator begin(JsonValue o) {
return JsonIterator{o.toNode()};
}
(Compiled OK in MS Viaual Studio 2015 Community + Update 1,
but I use VS 2012 C++ for my project as VS 2015 Community is buggy.)
Can you please fix it or can you describe how to fix it by myself to compile it on VS 2012?
Best regards,
Alexander
P.S. And please replace one known 3-letter Russian word from test-suite.cpp, bad style and "plokhaya primeta, programma budet plokho rabotat'" .

Maybe this fix the problem:
inline JsonIterator begin(JsonValue o) {
    JsonIterator it;
    it.p = o.toNode();
    return it;
}

btw gason can compile in vs2013, early versions as I know.


FR: Add flag to FUIAuthDelegate didSignInWith to indicate if anonymous auto-upgrade occurred

Step 1: Are you in the right place?
Yes
Step 2: Describe your environment

Objective C or Swift: Swift
iOS version: >=11.1
Firebase SDK version: 6.27.1
FirebaseUI version: 8.4.2
CocoaPods Version: 1.9.2

Step 3: Describe the problem:
We're using FUI's shouldAutoUpgradeAnonymousUsers feature to, well, auto upgrade anonymous users. In the didSignInWith function for the FUIAuthDelegate we want to determine if the auto-upgrade was applied, or if the user already had a non-anonymous provider linked. In other words: we want to know if the "sign in" should be considered as a "sign up" where the user used a non-anonymous provider for the first time.
There are numerous work-arounds we can perform on our end to perform this same task, but built-in functionality would be a nice feature in the long run.

I might try to work on a PR for this, if I find enough time to set aside. The only problem I see up front is that the function signature authUI(_:didSignInWith:error:) doesn't leave any room for this flag unless I either 1) add a new parameter to the function, or 2) tack the property onto the FUIAuth instance provided in the function. The former is obviously not optimal, and the latter isn't perfect either but I think it's preferable.
My tentative plan is to add a didUpgradeAnonymousUser read-only boolean property to the FUIAuth class that is set during every sign in. This property can be read within the didSignInWith function to check the state for the most-recent sign in.
Still brainstorming other solutions but from what I've come up with so far this is, in my opinion, the best option for minimal API impact.

IMO the first solution is preferable, because the boolean didUpgradeAnonymousUser is scoped by the callback to the only place where it makes sense. Otherwise, you end up with a mutable bit on a global object that is only meaningful during a particular function call.
We can make this a non-breaking change by adding a new delegate method, deprecating the old one, and then having FUIAuth call both delegate methods if they're available.

If I'm not mistaken, there are currently three didSignInWith delegate methods in play, one of which is deprecated. So is your idea to add a fourth and deprecate the other two...? Part of the problem is that one of the methods takes a URL and one does not, and now if we add another item you end up with a number of combinations each with its own function:

FIRAuthDataResult*, NSError*
FIRAuthDataResult*, NSURL*, NSError*
FIRAuthDataResult*, BOOL, NSError*
FIRAuthDataResult*, BOOL, NSURL*, NSError*

Maybe it would be best to deprecate both existing functions and add only function 4 with all parameters nullable? Then the developer can have all items available and only use what they need for their application.

I'll bring this up with some of the other Firebase staff and brainstorm a design. I'm not opposed to having more callbacks, as long as it's clear when/where they should be used. In this case I think if people implement the one method with the signature they want they should be able to ignore the other three. But for clarity it is always nice to have fewer redundant methods.


Update functions-create-function-app-portal.md

I can create functions on portal with Python v2 programming model.

@ggailey777
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@ggailey777
Thank you for your suggestion.
I updated PR.

#sign-off Thanks!

merging


DeadFunctionElimination: an alloc_global instruction keeps the referenced global alive

Fixes a crash caused by a deleted global variable which is still referenced by an alloc_global instruction.
rdar://109093730

@swift-ci smoke test

@swift-ci smoke test windows


[From 15.5 preview test day] - Newly-added file is not recognized

Give this test script: https://gist.github.com/cartermp/b19e80506b6a51c54cb9006fcd6eb07b
Step 13 fails because IntelliSense does not pick up the file.  This was working when I tested out #3564, and afterwards when I reviewed the script, so something may have gone awry between after we merged and when we tested a build of 15.5 internally.

That issue is because of:
https://github.com/Microsoft/visualfsharp/blob/master/vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs#L418
There was a huge performance degrade for legacy projects with the updated event.  However, that is now fixed and the updated event is in the Project References PR.
https://github.com/KevinRansom/visualfsharp/blob/d887a3b7feb998ccbda584bf458793d47cf7e87d/vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs#L378
Kevin

@KevinRansom awesome.  Sounds great.  #3653.

Fixed by #3777


Do not fail on missing secrets in PR

Gradle signing configuration is only set if secrets are available
(e.g. not in foreign PRs).

Tested in https://github.com/Codearte/gradle-nexus-staging-plugin/pull/63 (Travis).


Handle situation when unikernel stops (crashes)

When doing a dry-run for today's presentation one of our unikernels crashed (some runtime error, not related to Virtlet I think). However, the error that I got from Virtlet was somewhat strange:

The unikernel was booted properly and crashed while operating due to mistake in application code:

What I'd expect from Virtlet is to say "VM has stopped unexpectedly" instead of crashing with this error.
/cc @jellonek

Why did our unikernel crash in runtime? -> It appears we haven't given it enough RAM. After increasing RAM from 256MB to 1GB everything seems to be working (I can deploy and redeploy application without any problems).

Ok, we'll fix VM crash handling in Virtlet.


[Bug] On first reconcile FRR (zebra) does not always load the VRF VNI map correctly

Description
When a node is booted it starts with a baseline configuration to bring up the necessary interfaces to form a cluster.
After the intial configuration is loaded nwop starts reconciling additional configuration from the kube-apiserver.
When it then reconciles this new configuration by running systemctl reload frr the daemon does not always load the configuration as desired. And instead of L3 VNIs the daemon just load L2 VNIs.
It rather loads only parts into the configuration.
E.g.
# frr-reload runtime.txt snippet
vrf vr.blue
 vni 922
exit
 vrf vr.red
 vni 980
exit
 router bgp<PHONE_NUMBER> vrf Vrf_mgmt
  address-family ipv4 unicast
   neighbor mgmt_def activate
  exit
 exit
 frr version 8.0.1
 vrf vr.san
exit
 vrf vr.san
 vni 990
exit
 vrf vr.green
exit
 vrf vr.green
 vni 920
exit
 vrf vr.teal
exit
 vrf vr.teal
 vni 924
exit
 vrf vr.purple
exit
 vrf vr.purple
 vni 925
exit
 vrf vr.yellow
exit
 vrf vr.yellow
 vni 926
exit
 vrf vr.black
exit
 vrf vr.black
 vni 929
exit
 vrf vr.white
exit
 vrf vr.white
 vni 981
exit
 vrf vr.rose
exit
 vrf vr.rose
 vni 9801
exit

# vtysh -c "show evpn vni"
VNI        Type VxLAN IF              # MACs   # ARPs   # Remote VTEPs  Tenant VRF
920        L2   vx.green              0        0        0               vr.green
929        L2   vx.black              0        0        0               vr.black
980        L2   vx.red                0        0        0               vr.red
925        L2   vx.purple             0        0        0               vr.purple
922        L2   vx.blue               0        0        0               vr.blue
9801       L2   vx.rose               0        0        0               vr.rose
981        L2   vx.white              0        0        0               vr.white
924        L2   vx.teal               0        0        0               vr.teal
990        L2   vx.san                0        0        0               vr.san
926        L2   vx.yellow             0        0        0               vr.yellow

Hints
It seems we already tried to mitigate this behaviour in these code lines.
https://github.com/telekom/das-schiff-network-operator/blob/28a37d84370870e9f30044b37b2ad932cc28a490/pkg/reconciler/layer3.go#L68-L96
Hotfix
Run this command and the vnis are correctly configured in frr
systemctl reload frr

I've did some testing and I've created draft PR on this: #144
It seems that the only thing that differentiates the L2 VNI from L3 VNI for FRR is whether or not it is defined in the config file. For example, if we define interfaces in the config file:
vrf vr.test10030
 vni 10030
exit-vrf

But the interface is not yet created it will be present in FRR as L3 interface with no VxLAN interface.
VNI        Type VxLAN IF              # MACs   # ARPs   # Remote VTEPs  Tenant VRF
10032      L3   None                  0        0        n/a             Unknown

After the interface VxLAN interface is created, FRR will automatically discover it and add as L3 without transitioning from L2.
VNI        Type VxLAN IF              # MACs   # ARPs   # Remote VTEPs  Tenant VRF
10032      L3   vx.test10030                  0        0        n/a             vx.test10030

In current implementation we do as follow:

Create L3 interfaces.
Update FRR config and reload
Set interfaces up.

So, in the PR I've changed order of operations:

Update FRR config and reload (which creates L3 interfaces with no VxLAN as a placeholder).
Create L3 Interfaces.
Set interfaces up

With this order I did not see the transition to L3-VNI messages. However I am not sure if this approach to FRR configuration is correct, so it would be best if someone with more knowledge on FRR could take a look at this.
Additionally, I've fixed the second issue you've reported - during the configuration of the interfaces operator will now try to set up any interface that was already existing (was created in previous iteration of reconciliation loop). For example, if L3 named test was created but newer got up due to some other errors, the operator will try to bring it up in next iteration.


Image quality getting bad

Hi,
I am new to image optimization. I just want to optimize my images tomake them small in size and dimension, but maintaining quality. I used the following code:
new Jimp("img.jpg", function (err, image) {
        if(!err){
            var origImageDim = {width:this.bitmap.width,height:this.bitmap.height};
            var dimensions = calculateImageDimensions(origImageDim.width,origImageDim.height,600,400);//Get proportionate dimensions
            var imageClone = image.clone();
            image.cover(dimensions.width, dimensions.height).write("destFolder/img.jpg", function(err, image){
                    if(!err){
                        console.log("Image optimised successfully");
                    }
                    else{
                        console.log(err);
                    }
                }
            )
		}
	}

	function calculateImageDimensions(width,height,maxWidth,maxHeight){
    // calculate the width and height, constraining the proportions
    if (width > height) {
        if (width > maxWidth) {
            height = Math.round(height *= maxWidth / width);
            width = maxWidth;
        }
    }
    else {
        if (height > maxHeight) {
            width = Math.round(width *= maxHeight / height);
            height = maxHeight;
        }
    }
    return {width:width,height:height};
}

The problem i am facing is that the quality of the resultant image is getting bad and the size (KB's) is  getting bigger. Can you please help? Am I doing anything wrong?

Hi, @canvas-manik. A lot of these methods are provided for you:
new Jimp("img.jpg", function (err, image) {
	// resize the image to 400px high, set JPEG quality to 60, and save
	image.resize(Jimp.AUTO, 400).quality(60).write("img-small.jpg");
}

Let me know if this works for you.

Yeah, I tried that as well. the quality is getting very bad. Even though the size might get okay. Is there some way to retain the same quality reducing the dimensions and KBs. PFA the images with 60%, 80%, 90% quality.

There's a couple of possible issues.
The first thing is that it's a pretty low quality image to begin with. It looks like its been through the JPEG rinse a few times. For example, look at the artifacts in the original around the saddle, pedal and handlebars.
Secondly, resizing will mess with your pixels. You can't retake the photograph only smaller. The scaling algorithm will do its best but, by definition, if you half the size of the image, you're trying to squeeze four pixels into one. You will lose some detail in doing so. Different techniques do that differently with different outcomes but none can do the impossible.
Lastly, you're saving it again as a JPEG. That's lossy and will further will further reduce the quality:
http://petapixel.com/2010/02/04/saving-jpeg-photos-hundreds-of-times/
Taking all that into account I performed the same operation in Gimp. I compared that to the output of Jimp using PNG, JPEG, and BMP. See the output below.
Original

Gimp (JPEG)

Jimp (JPEG)

Jimp (PNG)

Thanks a lot Oliver for your response. Yes, you are right, while uploading the images from the browser, I am using HTML Canvas object to optimize /EXIF rotate the images before sending them to server. I am not sure what are the best practices for that. Can you share something out of your experiences?
My goal is to upload the images to my site, while doing so, I want:

To reduce the size on client when the image is uploaded, to save bandwidth for user
Retain quality of the images
Reduce the page footprint, for that I want to make the uploaded images to smaller sizes, say a thumbnail (8080)/card(400400) and load the smaller sizes of images initially. Load the full size images (1000*700) only when required.

I am using NodeJS on the backend, and angular js on the front-end.
Any help is deeply appreciated.
Regards,
Manik Mittal

Thanks a lot Oliver,
After uploading the original images, it looks like it is working fine.
Thanks,
Manik Mittal

@canvas-manik can this issue be closed then?

Closing this issue, as issue is resolved.

Thanks Vladimir,
I have closed the issue.
Regards,
Manik Mittal
From: Vladimir Starkov<EMAIL_ADDRESS>Sent: Wednesday, October 28, 2015 2:44 PM
To: oliver-moran/jimp<EMAIL_ADDRESS>Cc: Manik Mittal<EMAIL_ADDRESS>Subject: Re: [jimp] Image quality getting bad (#54)
@canvas-manikhttps://github.com/canvas-manik can this issue be closed then?
—
Reply to this email directly or view it on GitHubhttps://github.com/oliver-moran/jimp/issues/54#issuecomment-151775318.

"Jimp uses a bi-cubic two-pass scaling algorithm"

@oliver-moran Hello, has jimp switched from bilinear to bicubic interpolation recently? I'll be updating sharp's performance test results soon and want to ensure I'm correctly categorising it.

@lovell - No, it hasn't changed. It was the only one I could find!
I had it in my head (since Day 1) that it was bi-cubic but I may be wrong. The original project I pulled it from has been taken down and it's beyond my knowledge to tell the difference by looking at the code.
If you can tell, here's the resizer: https://github.com/oliver-moran/jimp/blob/master/resize.js

@oliver-moran Thanks for the quick reply. https://github.com/taisel/JS-Image-Resizer looks like the (resuscitated) project you're referring to. If so, @taisel should be able to answer the bilinear vs bicubic question.

There's two modes of scaling if you refer to the demo presented at http://taisel.github.io/JS-Image-Resizer/
One is bilinear, another is neither, but results in preserving the image crispness (it looks like nearest neighbor integer upscale+bilinear for a comparable end result). Downscaling is always the custom algorithm, since the algorithm is equivalent to multiple passes of bilinear limited to 2x downscaling in each pass, so it doesn't miss a source input pixel. That's emphasized in the demo with one of the images shown (context2d uses bilinear usually). If you downscaled with context2d (presuming bilinear) multiple times in a ratio of no more than 2x to get the same final image size, you'd get the same result as the custom algorithm.
I hope I explained the peculiarities here.

If you all want bicubic as an upscaling algorithm, or want to propose another downscaling mode of operation, feel free to chime in. That resizing project is ancient and in need of update.

Looking at JIMP's code, bilinear is being used instead of the custom algorithm for upscaling.

Thanks for the detailed information @taisel!


Add support for quorum queues

I would be very happy if it could be possible to use  quorum queues in rabbitmq together with rascal.

Hi @svrnwnsch, I believe these should work out of the box. You just need to specify the appropriate queue arguments.

Thank you for the quick response I tried this before and there was some cryptic error. And I therefore assumed this was not supported.
But now it worked with an empty exchange. :tada:
As a suggestion maybe the README.md could be updated to include a hint to use:
              arguments: {
                'x-queue-type': 'quorum',
              },

Hi @svrnwnsch,
README currently has the following
To define a queue with extensions add arguments to the options block
{
  "queues": {
    "q1": {
      "options": {
        "durable": false,
        "arguments": {
          "x-message-ttl": 65000,
          "x-queue-mode": "lazy"
        }
      }
    }
  }
}

I don't want to update the readme every time the RabbitMQ team adds another extension, but given how important the quorum queues are, I'lll update to
To define a queue with extensions such as x-queue-type etc. add arguments to the options block, e.g.
At least that way a search of the README should find it. Make sense?


Issue in loading blade view component class

There is an issue on loading blade view component class
steps to reproduce
create a fresh laravel project and require laravel-modules
make a module
php artisan module:make Example

then make a component
php artisan module:make-component Example Example

after that on Modules/Resources/views/index.blade.php load that component
<x-example::example />

this will load the component blade file, and ignore the component class located here
Modules/Example/View/Component/Example.php
Fix:
is to register component name space on the module service provider
Blade::componentNamespace(\Config::get('modules.namespace')."\\".$this->moduleName."\\View\\Component", $this->moduleNameLower);

if you find mark this as an issue i will make a pull request to fix it

It is not a issue, https://laravel.com/docs/8.x/blade#manually-registering-package-components
you can use
Blade::component('package-alert', Alert::class);
<x-package-alert/>

or
Blade::componentNamespace('Nightshade\\Views\\Components', 'nightshade');

<x-nightshade::calendar />
<x-nightshade::color-picker />

Components Namespace must be loaded automatically? no?
so you don't need to register the component namespace on each module.


Whitespace between the taghelper directives and their value should not be metacode

It should instead be markup. This will make them consistent with all the other extensible directives.

Note: This is a minor issue and doesn't have any impact on the functionality.

This has always bothered me 😄

f3d121cacf5d4b98e1cb49c3e7cbbe04c98d2830


bicubic resolution vs Nearest neighbor

Actually when you change the resolution in redwire you get the bicubic result which destroys pixel art/illustrator... artworks It would be cool to change this for nearest neighbor so that it keeps a more accurate version of the artwork. Here is an example of both bicubic and nearest neighbor.

I see nearest one on my Linux Chrome. That depend of the web browser.
Maybe we can implement that:
http://stackoverflow.com/questions/10525107/html5-canvas-image-scaling-issue

I will try it out :)
Date: Thu, 2 Jul 2015 11:35:53 -0700
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [RedWire] bicubic resolution vs Nearest neighbor (#501)
I see nearest one on my Linux Chrome. That depend of the web browser.
Maybe we can implement that:
http://stackoverflow.com/questions/10525107/html5-canvas-image-scaling-issue
—
Reply to this email directly or view it on GitHub.


Real-time stabilization on incoming frames, but not passing capture source object directly into VideoGear

Question
Can this code be implemented to work on real-time incoming frames? The frames are not captured by
stream = VideoGear(source=0, stabilize = True).start()

Instead, they will be received as numpy arrays through reading from a disk location frame by frame. Can I still use Vidgears to perform stabilization? Thanks.
Acknowledgment

https://stackoverflow.com/questions/51970072/real-time-video-stabilization-opencv
Context

Your Environment

VidGear version:
Branch:
Python version:
pip version:
Operating System and version:

Optional

@AlexYiningLiu Absolutely yes, that what Stabilizer Class built for. That's why it is advised to always check Vidgear Docs before raising an issue here. Also, please fill Issue template before raising one. See Stabilizer Class docs


State provided via constructor is ignored

The docblock for AbstractProvider constructor mentions state as one of the properties that can be included in the $options array.
Is there a reason why the getAuthorizationParameters doesn't check if $this->state already has a value? If so, what is the point of passing a state value to the constructor?

The AbstractProvider doesn't handle state, but it is provided so that third-party providers may use it.


Bulk import issue

Describe the bug
It fails when trying to do the bulk import with the error: "The Endpoint Import has failed. (Error message: Unable to create associations for endpoints)" however - there are green icons by the MAC addresses itself and I noticed that endpoints are added to the "endpoints" table but not to the "endpointAssociations" one.
To Reproduce
Steps to reproduce the behavior:
Use "Bulk import" feature with CSV file.
Expected behavior
Register a group of MAC addresses.
Screenshots

Desktop (please complete the following information):

OS: Win11
Browser: Edge, Firefox

@pio-gra, I've tried to reproduce this and am unable.  Do you have any other details to reproduce it maybe?

I'm having a similar issue with bulk import.  I get the CSV built according to the template, but it complains of illegal characters.  Then I remove everything but the MAC addresses, and it states that all entries are filtered.  I don't believe I have any illegal characters in any of the fields, but it's hard to know when the output doesn't give any meaningful error handling.

@joe-catanzaro just curious are you using the latest code that was committed a few weeks ago?
Is it possible for you to attach the file you are trying to upload that causes the issue so I can try and reproduce with that same file upload?
Thanks
Nick

@joe-catanzaro just curious are you using the latest code that was committed a few weeks ago?
Is it possible for you to attach the file you are trying to upload that causes the issue so I can try and reproduce with that same file upload?
Thanks
Nick

hey Nick. this instance was just installed and brought running last week, I did run a git pull and it stated it's up to date.
I had to sanitize the file of the email address field, but that didn't seem to be the one that was causing problems. It seemed to be more the description field. Are there any character count limitations on that field? And I assume underscores are ok in the email field? I.e<EMAIL_ADDRESS>problem file.csv

@ciesinsn realized I forgot to tag, hopefully you saw this.

@joe-catanzaro The file you attached I'm able to upload just fine, I assume it may be something in your description causing the issue.  There is a filter that checks for invalid characters when a file is uploaded.  When you upload the file do you see the count for invalid characters be anything other then zero?  A code comment states " is a illegal character but I've found that & is also triggering the invalid character count and breaking a upload even though & is in the regular expression list.  By chance are you using either of those in your file?

So with no email addresses or descriptions, it still comes back and says ‘successful upload with exceptions on unformatted content.  It recognizes the 209 entries, but shows all 209 entries filtered:
@.***
From: Nick Ciesinski @.>
Sent: Saturday, November 11, 2023 4:45 PM
To: CiscoDevNet/iPSK-Manager @.>
Cc: Joe Catanzaro @.>; Mention @.>
Subject: [EXT] Re: [CiscoDevNet/iPSK-Manager] Bulk import issue (Issue #23)
ATTENTION: This email originated from outside of the organization. Please do not open any attachments or click any links unless you recognize the sender and know the content is safe.
@joe-catanzarohttps://urldefense.com/v3/__https:/github.com/joe-catanzaro__;!!LVMHySo!iLfz4CULkgcLXWq-zmh422FoK0cqouxwE8-25E0Y1DdKB75Fh-8e12TNbnx93I-jrYQwlhUPL65a7Nj_WV-t_jqmm0-z$ The file you attached I'm able to upload just fine, I assume it may be something in your description causing the issue. There is a filter that checks for invalid characters when a file is uploaded. When you upload the file do you see the count for invalid characters be anything other then zero? A code comment states " is a illegal character but I've found that & is also triggering the invalid character count and breaking a upload even though & is in the regular expression list. By chance are you using either of those in your file?
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/CiscoDevNet/iPSK-Manager/issues/23*issuecomment-1806924583__;Iw!!LVMHySo!iLfz4CULkgcLXWq-zmh422FoK0cqouxwE8-25E0Y1DdKB75Fh-8e12TNbnx93I-jrYQwlhUPL65a7Nj_WV-t_ol1hM6m$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/BDZS322XBPRZVOIPZUDTYGLYD7WVBAVCNFSM6AAAAAAQCESLA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBWHEZDINJYGM__;!!LVMHySo!iLfz4CULkgcLXWq-zmh422FoK0cqouxwE8-25E0Y1DdKB75Fh-8e12TNbnx93I-jrYQwlhUPL65a7Nj_WV-t_hd5cHv3$.
You are receiving this because you were mentioned.Message ID: @.***>
======================================================================
The information in this email is confidential, and is intended solely for the addressee(s). Access to this email by anyone else is unauthorized and therefore prohibited. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited and may be unlawful.

@joe-catanzaro so this is when you try to upload the file you attached the other day?  I have no issues with that file.  Can you include a screenshot of the screen that shows whats been uploaded/filtered (the count).  What version of PHP are you using and what OS is this on?

@joe-catanzaro so this is when you try to upload the file you attached the other day? I have no issues with that file. Can you include a screenshot of the screen that shows whats been uploaded/filtered (the count). What version of PHP are you using and what OS is this on? Also, can you attach your php.ini file.

Yes, same file.

This is running on RHEL 9.2, PHP version info below:
PHP 8.0.30 (cli) (built: Aug  3 2023 17:13:08) ( NTS gcc x86_64 )
Copyright (c) The PHP Group
Zend Engine v4.0.30, Copyright (c) Zend Technologies
with Zend OPcache v8.0.30, Copyright (c), by Zend Technologies
PHP ini attached also
ipskmanager php ini.txt

@ciesinsn

@ciesinsn  so now I've done the git pull, restarted the box etc., and I can't get any file to upload to it now.  Using chrome, i've updated the browser and disabled adblockers etc. but nothing happens when i click the upload button.

@joe-catanzaro when was the last time you did a pull?  The only things changed regarding this particular issue was two modifications to one line of code to handle a & and _ being in the CSV text.  Is there any sort of error if you open developer tools on the browser?

@ciesinsn did it again today just to be sure, return was 'already up to date'.  In the dev tools I see this:

Can you try and back rev that file only?  That was the only one changed.
Don't understand why you'd have a issue and I wouldn't, especially for the
minor change that was done.
On Wed, Nov 15, 2023 at 1:33 PM joe-catanzaro @.***>
wrote:

@ciesinsn https://github.com/ciesinsn did it again today just to be
sure, return was 'already up to date'. In the dev tools I see this:
[image: devtool error]
https://user-images.githubusercontent.com/150154731/283227721-63a08bc5-5b93-4b1c-b5ef-572c9d6f234f.PNG
—
Reply to this email directly, view it on GitHub
https://github.com/CiscoDevNet/iPSK-Manager/issues/23#issuecomment-1813140674,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI5G4RIBBOCNXGWEZ5LW673YEUKKHAVCNFSM6AAAAAAQCESLA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJTGE2DANRXGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Can you try and back rev that file only? That was the only one changed. Don't understand why you'd have a issue and I wouldn't, especially for the minor change that was done.
…
On Wed, Nov 15, 2023 at 1:33 PM joe-catanzaro @.> wrote: @ciesinsn https://github.com/ciesinsn did it again today just to be sure, return was 'already up to date'. In the dev tools I see this: [image: devtool error] https://user-images.githubusercontent.com/150154731/283227721-63a08bc5-5b93-4b1c-b5ef-572c9d6f234f.PNG — Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI5G4RIBBOCNXGWEZ5LW673YEUKKHAVCNFSM6AAAAAAQCESLA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJTGE2DANRXGQ . You are receiving this because you were mentioned.Message ID: @.>

@ciesinsn sorry, how would I do that?

https://github.com/CiscoDevNet/iPSK-Manager/tree/7db641c58a722e680fe16898b11b0b48bb59e683/adminportal/ajax

@ciesinsn ok, back rev'ed that file and noticed it was set for root as owner not apache.  Fixed that, restarted HTTPD and still getting the same condition when I click 'upload' (nothing happens) but no more error in the dev tools console.

Did you try a different csv just to make sure it wasn’t something with the
file all the sudden? I’m not able to reproduce the issue at all.
Before the last pull you did when was the last time you did a pull?
On Thu, Nov 16, 2023 at 8:16 AM joe-catanzaro @.***>
wrote:

@ciesinsn https://github.com/ciesinsn ok, back rev'ed that file and
noticed it was set for root as owner not apache. Fixed that, restarted
HTTPD and still getting the same condition when I click 'upload' (nothing
happens) but no more error in the dev tools console.
—
Reply to this email directly, view it on GitHub
https://github.com/CiscoDevNet/iPSK-Manager/issues/23#issuecomment-1814516966,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI5G4RLV5EMDXYZGU5ATXZDYEYN3RAVCNFSM6AAAAAAQCESLA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJUGUYTMOJWGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

I don't think I had done a pull since initial installation up until the update for this issue

pulled a new template file, copied in some mac values and populated other values but same condition.  it recognizes the file, lights up the upload button, but clicking 'upload' doesn't do anything and nothing happens in the dev console.

@joe-catanzaro I can not reproduce any issue like that and I've tried a few files.  Did you clear cache/history/etc.. in browser already?
Also, from within developer tools you should see in the network tab when you press upload it should place a new fileupload.php in the list, does it?  if it does click it, go to the response tab, what is shown there, anything?

Yes, I do see a new fileupload.php being generated each time.  Output from response page attached.
Uploading response page.txt…

@joe-catanzaro Looks like the file didn't upload right on your last message

response page.txt
May not have waited long enough

@joe-catanzaro Still think something isn't right with that file upload.  There is a lot of text/code in it referencing github.

I created a new CSV, manually typed in everything except I copy/paste values for the MAC addresses, nothing happens when I click upload.

opened the CSV in notepad, nothing out of the ordinary in the file

@joe-catanzaro I meant the upload of that response data from the web debugger

is it maybe something to do with the fileupload.php file?

@joe-catanzaro This is what I'm looking for from you from the developer tools in a browser which isn't coming through on your attachments in github correctly.

Yes, all that text in the file I sent is what comes up in the 'response' tab

@joe-catanzaro The text in the file you attached when I downloaded it has a lot of text that says "github". That in no way should be in that file.

Something for sure went wrong pulling down that fileupload.php file.  Going to try replacing it

ok, fixed the fileupload.php file and now I'm at least getting responses, but back to square one with all of the csv's we've been working with here.
problem file still fails with Successful Upload with exceptions on unformatted content, illegal characters
original file with blank descriptions sees same failure as above
newly created file fails with Invalid CSV Header Attributes, even though they're identical to the template

@joe-catanzaro Sure you have the latest version of the fileupload.php file?  I've tried all your files and don't have any issues with the changes in the latest version.  I even hand typed a few lines of your image a few messages above and don't have a issue.

I've tried with both the previous version as well as the most recent one, doesn't seem to make a difference.

Line 105 reads:
$tempEntrydata = filter_var(trim($data),FILTER_VALIDATE_REGEXP, Array('options'=> Array('regexp' => "/^(?:([a-z]|[A-Z]|[0-9]|-|:|,|'|@|.|;|/|(|\|&|#|*|\s){1,})$/")));
Nothing other than the single line of JSON.

@joe-catanzaro That is not the latest file then.  It's also missing the &

aha.  that did it.
apparently what appeared to be the most recent file that I was looking at in github was not.
I went in and replaced line 105 with the updated version and now it worked.

@joe-catanzaro no problem on the assistance.  So just wanted to make sure, it sounds like all your uploads are working now, is that the case?  if so I'll probably close out this mile long issue :)

Yes, it appears that way.  The ultimate resolution was the updated fileupload.php.  Not sure why the header fields in the other file were no good, but it’s working now.
From: Nick Ciesinski @.>
Sent: Monday, November 20, 2023 12:12 PM
To: CiscoDevNet/iPSK-Manager @.>
Cc: Joe Catanzaro @.>; Mention @.>
Subject: [EXT] Re: [CiscoDevNet/iPSK-Manager] Bulk import issue (Issue #23)
ATTENTION: This email originated from outside of the organization. Please do not open any attachments or click any links unless you recognize the sender and know the content is safe.
@joe-catanzarohttps://urldefense.com/v3/__https:/github.com/joe-catanzaro__;!!LVMHySo!laCYGsfDs48WkjZT4QqYXPlLSoFRA-vbez4Vz8Na3BZAAArcLPyqynaI5GrZ1zurKa8Kzl3NpAGWdG_h_jetK9w6AkLK$ no problem on the assistance. So just wanted to make sure, it sounds like all your uploads are working now, is that the case? if so I'll probably close out this mile long issue :)
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/CiscoDevNet/iPSK-Manager/issues/23*issuecomment-1819482842__;Iw!!LVMHySo!laCYGsfDs48WkjZT4QqYXPlLSoFRA-vbez4Vz8Na3BZAAArcLPyqynaI5GrZ1zurKa8Kzl3NpAGWdG_h_jetK0PdLFdZ$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/BDZS3255FUOPFVFRITIDU6LYFOFNTAVCNFSM6AAAAAAQCESLA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJZGQ4DEOBUGI__;!!LVMHySo!laCYGsfDs48WkjZT4QqYXPlLSoFRA-vbez4Vz8Na3BZAAArcLPyqynaI5GrZ1zurKa8Kzl3NpAGWdG_h_jetKx-WfAcW$.
You are receiving this because you were mentioned.Message ID: @.***>
======================================================================
The information in this email is confidential, and is intended solely for the addressee(s). Access to this email by anyone else is unauthorized and therefore prohibited. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited and may be unlawful.


List.js: Adding combine function to merge and remove duplicates

This PR introduces the combine function to the List that creates a new list using the items from itself and the passed one, discarding all possible duplicates.

Ok, new version is here. Ugly, but faster. Comments please :nerd_face:

@wavesoft I'm proud of you! 👍

Allrighty, now it should be cleaner to read 😃

Nit aside this is great - really like how you optimize the combine method 💯 ✨ Great job!

Nice work @wavesoft - clever solution. O(n + m) space and O(n + m) time is probably as good as this gets 👍

Lets ship it after Orlando's comment is addressed.

Let's merge this once the test pass. Great job! 💯 🚢 🚀


Update tutorial to have brief intro to functional

Also two minor updates:

remove _count() in tutorial
Fix the TODO about "concat"

Preview:


The newline break is missing in Issue content

Description
The newline break is missing in Issue content ， for example

edit(OK):
1
2
3
preview tab (OK):
1
2
3
actual web page display as (newline break is missing) :
123
also see below

edit(OK):
> 1
> 2
> 3

preview(OK with quote block):
| 1
| 2
| 3
actual web page display as (newline break is missing) :
| 123

Gitea Version
main branch
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
main branch
Operating System
windows
How are you running Gitea?
windows with ms sql server
Database
SQLite

Regression from #32492

Will fix it

Let's try this:  Improve markdown rendering #32522

1.23 nightly is ready, could you take a try?
ps: before 1.23 frozen, there will be some more refactorings to the render system to make it maintainable and secure. if there is any regression, feel free to open an issue and I will fix them ASAP.


ytsaurus-client warns about incompatible chardet & charset_normalizer on modern Ubuntu

On Ubuntu 23.10 ytsaurus-client reports the followin warning whenever yt.wrapper is imported:
$ yt
/home/max/.local/lib/python3.11/site-packages/yt/packages/requests/__init__.py:115: RequestsDependencyWarning: urllib3 (1.26.9) or chardet (5.1.0)/charset_normalizer (3.3.2) doesn't match a supported version!
  warnings.warn("urllib3 ({}) or chardet ({})/charset_normalizer ({}) doesn't match a supported "
usage: yt [-h] [--proxy PROXY] [--prefix PREFIX] [--config CONFIG] [--tx TX] [--master-cell-id MASTER_CELL_ID]
          [--ping-ancestor-txs] [--trace] [--version]
          command ...
yt: error: the following arguments are required: command

I suspect the following logic to be broken (or at least not be ready for fresh library versions):
https://github.com/ytsaurus/ytsaurus/blob/main/yt/python/contrib/python-requests/requests/__init__.py#L51-L98
ytsaurus-client does not vendor charset_normalizer nor chardet, so they are taken from the host environment. At the same time, ytsaurus-client fixes the charset-normalizer version >=3.3.0, which contradicts the assertion from the check above.
https://github.com/ytsaurus/ytsaurus/blob/e11de159f4964a42fd33380a0a718ac9a2bafb72/yt/python/packages/ytsaurus-client/setup.py#L49
Finally, ytsaurus-client does not have a dependency on chardet, but it somehow appeared in my system (possibly, as a dependency of some other package), and it is also of much fresher version (5.1.0), which also does not fit into the requirements of the code above.
I am not sure, which one of these two libraries is actually used, but my YT client works perfectly fine for a couple of months of active use, so I'd suggest relaxing these checks one way or another. At the very least, two statements for charset_normalizer should be contradicting.
Reproduce this issue by running the following command:
$ docker run ubuntu:mantic bash -c "apt update; apt install -y python3 python3-pip; pip3 install ytsaurus-client --break-system-packages; yt"
...
/usr/local/lib/python3.11/dist-packages/yt/packages/requests/__init__.py:115: RequestsDependencyWarning: urllib3 (1.26.9) or chardet (None)/charset_normalizer (3.3.2) doesn't match a supported version!
  warnings.warn("urllib3 ({}) or chardet ({})/charset_normalizer ({}) doesn't match a supported "
usage: yt [-h] [--proxy PROXY] [--prefix PREFIX] [--config CONFIG] [--tx TX]
          [--master-cell-id MASTER_CELL_ID] [--ping-ancestor-txs] [--trace]
          [--version]
          command ...
yt: error: the following arguments are required: command

@denvr, @savnadya
This issue is quite annoying, might having a look?

It seems the issue was fixed in https://github.com/ytsaurus/ytsaurus/commit/f7db734cacc99fc679b824f7b7ce52cc785145b6
According to the first message there are "urllib3 (1.26.9) or chardet (None)/charset_normalizer (3.3.2)" ->

urllib3 == 1.26.9 (valid https://github.com/ytsaurus/ytsaurus/blame/8edad184e0eb11eb0e6884ba98f50a72bec24e80/yt/python/contrib/python-requests/requests/init.py#L81)
chardet is not installed (skipped by https://github.com/ytsaurus/ytsaurus/blame/8edad184e0eb11eb0e6884ba98f50a72bec24e80/yt/python/contrib/python-requests/requests/init.py#L87C11-L87C11)
charset_normalizer == 3.3.2 (valid now because of https://github.com/ytsaurus/ytsaurus/blame/8edad184e0eb11eb0e6884ba98f50a72bec24e80/yt/python/contrib/python-requests/requests/init.py#L95, but was not valid before https://github.com/ytsaurus/ytsaurus/commit/f7db734cacc99fc679b824f7b7ce52cc785145b6)

And right now I can't reproduce the problem:
docker run ubuntu:mantic bash -c "apt update; apt install -y python3 python3-pip; pip3 install ytsaurus-client --break-system-packages; yt"
.....
Downloading tqdm-4.66.4-py3-none-any.whl (78 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 78.3/78.3 kB 8.7 MB/s eta 0:00:00
Downloading typing_extensions-4.11.0-py3-none-any.whl (34 kB)
Installing collected packages: typing-extensions, tqdm, six, simplejson, distro, decorator, charset-normalizer, argcomplete, ytsaurus-client
Successfully installed argcomplete-3.3.0 charset-normalizer-3.3.2 decorator-4.4.2 distro-1.9.0 simplejson-3.19.2 six-1.16.0 tqdm-4.66.4 typing-extensions-4.11.0 ytsaurus-client-0.13.14
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
usage: yt [-h] [--proxy PROXY] [--prefix PREFIX] [--config CONFIG] [--tx TX]
          [--master-cell-id MASTER_CELL_ID] [--ping-ancestor-txs] [--trace]
          [--version]
          command ...
yt: error: the following arguments are required: command

There is another warning WARNING: Running pip as the 'root', but it only appears when you call --break-system-packages.
# chiffa @ chiffa-osx in ~/Code/yt-client-chardet-warning-222 [20:32:49]
$ cat Dockerfile
FROM ubuntu:mantic

RUN apt update && apt install -y python3 python3-pip
RUN pip3 install ytsaurus-client --break-system-packages

CMD ["/bin/bash"]

# chiffa @ chiffa-osx in ~/Code/yt-client-chardet-warning-222 [20:32:53]
$ docker build -t yt-client-chardet-warning-222 .
[+] Building 0.0s (7/7) FINISHED                                                                                docker:orbstack
 => [internal] load build definition from Dockerfile                                                                                0.0s
 => => transferring dockerfile: 225B                                                                                0.0s
 => [internal] load metadata for docker.io/library/ubuntu:mantic                                                                                0.0s
 => [internal] load .dockerignore                                                                                0.0s
 => => transferring context: 2B                                                                                0.0s
 => [1/3] FROM docker.io/library/ubuntu:mantic                                                                                0.0s
 => CACHED [2/3] RUN apt update && apt install -y python3 python3-pip                                                                                0.0s
 => CACHED [3/3] RUN pip3 install ytsaurus-client --break-system-packages                                                                                0.0s
 => exporting to image                                                                                0.0s
 => => exporting layers                                                                                0.0s
 => => writing image sha256:ebc2a5f3198f126340912f47a8cd901283fef51a4a40a59f1ced6354d42f9b45                                                                                0.0s
 => => naming to docker.io/library/yt-client-chardet-warning-222                                                                                0.0s

# chiffa @ chiffa-osx in ~/Code/yt-client-chardet-warning-222 [20:33:19]
$ docker run -it yt-client-chardet-warning-222
root@509f745d8c8e:/# yt
usage: yt [-h] [--proxy PROXY] [--prefix PREFIX] [--config CONFIG] [--tx TX] [--master-cell-id MASTER_CELL_ID] [--ping-ancestor-txs] [--trace] [--version] command ...
yt: error: the following arguments are required: command

Problem has been reproduced when a user has fresh chardet in a python environment.
https://github.com/ytsaurus/ytsaurus/commit/6f6b729862cc45b867134960e7e138543789c810 should fix this issue.


refactor(semantic): call with_trivias before build_with_jsdoc

#5875  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on  Graphite


Rename project OP2TilesetConverter

I don't think we plan to support converting non-tileset bitmaps. I probably chose a bad name to start with.

Right. Well, I suppose we're looking to convert to/from the custom bitmap format used by OP2, which happens to be used for tilesets. Maybe OP2CustomBitmapConverted? Though really I'm fine with the proposed name change. People probably will be thinking about tilesets when they use it.

Yeah, I was thinking that since it doesn't actually convert any of the sprites besides the tilesets, the current name would be confusing as someone might think they could use this project to convert other game art assets. To my knowledge, this project would only be useful for the tilesets since the other art assets are stored in a separate manner.


Project description

This is my first pull request.
It adds the R package structure, the documentation, as well as a basic function 'play()' which starts the shiny app.

Please don't merge the pull request yourself next time but wait until class!

Nice project - the package structure looks good :)! Maybe delete also the .DS_store files.


Allow enum declarations to have duplicate members reusing same constants

Purpose

Allow enum declarations to have duplicate members reusing same constants.

Fixes #31485
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

const FIVE = 5;
const FIVE = 5;

compiles without an error