A way to map repeat s motions? (Hopefully with ;/, as well)

Thanks for this plugin!
Just like there is a way to map ; and , (or custom keys) to repeat f/t motions, is there a way to map keys to repeat s (2-key) motions? If not, is there a way to repeat them at all? perhaps, by pressing s again?
It isn't currently documented and I tried to do it myself adhoc by adjusting the example for ft but from looking at the code, the ft and the s tables aren't exactly identical so I couldn't simply adjust the code in the documentation to apply to s.
I wonder if it's just a niche use-case? I'm using 2-key motions for everything; same line, next line or across half a screen. I find that the cost of pressing the second character is almost zero and the benefits it brings in disambiguation to reduce the number of matches is big.  I also have jump-to-first-match enabled.
Thanks again!

I'm using 2-key motions for everything; same line, next line or across half a screen. I find that the cost of pressing the second character is almost zero and the benefits it brings in disambiguation to reduce the number of matches is big.

Totally agree, I rarely use f/t, except for operations (quickly df-ing something in the proximity, stuff like that).

I wonder if it's just a niche use-case?

I've been thinking a lot about whether I should support this too. The question is, what's the use case here? Do you want to repeat right away (i.e., you'd like to have an "instant-repeat" feature for 2-char search too, not having to use labels to reach a target, just press ;;; mindlessly), or repeat the search sometime later?
The first case is very simple: you can map dedicated keys to <Plug>Lighspeed_s/S<cr>. In fact, this also works as a quick and dirty hack for the second case - the "flashing" labels are a bit annoying though, as this will relabel the whole area at every step.
nmap ; <Plug>Lightspeed_s<cr>
nmap , <Plug>Lightspeed_S<cr>

Do you happen to have some good use cases in mind where this latter behavior - instant-repeating - would be truly useful? It would require just a little bit of hacking I guess, but I'm not convinced about the feature yet. The whole point of the plugin and its ahead-of-time labeling is that you can rely on labels now, without (or with minimal) disruption.

Thanks for your quick reply!

or repeat the search sometime later?

The second case is very simple: you can map dedicated keys to <Plug>Lighspeed_s/S<cr>. In fact, this works fine as a quick and dirty hack for the first case too - the "flashing" labels are a bit annoying though, as this will relabel the whole area at every step.

Just to make sure I understand you correctly, to repeat the search in this case, one has to not just press s but also the extra 2 keys as well, correct? Or is there a way I am missing to repeat it without those 2 extra presses?
If by "sometime later" you mean something along the scope of tens of seconds upward, then I agree that
repeating the search anew is no problem. And I am using a dedicated key by the way, it is mapped to f ;)
(i.e. no more 1-key jumps for me), but to avoid confusion I am refering to it as s.

I've been thinking a lot about whether I should support this too. The question is, what's the use case here? Do you want to repeat right away (i.e., you'd like to have an "instant-repeat" feature for 2-char search too, not having to use labels to reach a target, just press ;;; mindlessly),

Do you happen to have some good use cases in mind where this latter behavior - instant-repeating, without labeling - would be truly useful? It would require just a little bit of hacking I guess, but I'm not convinced about the feature yet. The whole point of the plugin and its ahead-of-time labeling is that you can rely on labels now, without (or with minimal) disruption. Also, s/S is not really for macro-like, repetitive editing tasks - IMHO, for those you'd better use the normal /?*# search commands, that allow for more precision (in that case, the speed gain for the initial search by Lightspeed s/S is negligible/irrelevant anyway). But I'm happy to hear any good counter-arguments!

Indeed it is for instant repeating.
Perhaps I got used to sneak.vim's ; repeat that works for 2-key search and jumps to the following matches further down the screen.
It might sound odd at first but it is to do an interactive find and replace.
I could roughly split find and replaces to deliberate and indeliberate cases.
In the case of an indeliberate find and replace, I jump somewhere do some change
and only then the intention to propagate this change occurs, and then I would like to do (used to do with sneak.vim), for example, ;.;.;. to repeat the change quickly, sometimes skipping some matches, like ;.;;;.;;..
In the case of a deliberate find and replace, I could use /, <CR> and n instead, at the cost of potentially getting out of the zone beause I have to be cognizant of two ways of jumping to specific places.

I find it cumbersome because of the <CR> at the end of the search string,
and the key press to ":nohl" afterwards in the end.
I find it slower because I have smartcase enabled, which means that it
requires more keys to pinpoint the search whereas lightspeed.nvim is case sensitive. In that case you could suggest I disable smartcase but I do want it on as my use for / is for a search of something I am not completely sure about, even if it isn't a regex, it is helpful not to search both upper and lowercase options when using "/", for this reason.

However, in the case of less-than-trivial find and replaces, especially those involving a regex or more than say 3-4 replaces, I agree there is no gain to be had by using lightspeed.nvim, but most of my repetitive editing cases are trivial changes to no more than 3-4 instances of some text.  And in the case of a more involved find and replace I am down a couple of flow notches anyway.
Another distinction is that when I am jumping to somewhere that I am not looking at, I use "/", and when I jump to somewhere I am looking at, I use lightspeed.nvim.  For the simple find and replace, I am looking at the first match, but for the second/third/fourth replaces I don't search them with my eyes, I press ; and let that grab my attention.  If that makes sense.
(bonus) As a somewhat less subjective reason, I think it will make s and f a bit more symmetrical :)

There is c flag for :s which does exactly what you are describing. :s/foo/bar/c will jump between matches and prompt you whether you want to apply replacement.

Just to make sure I understand you correctly, to repeat the search in this case, one has to not just press s but also the extra 2 keys as well, correct? Or is there a way I am missing to repeat it without those 2 extra presses?

No, this is a fully functioning workaround - pressing <enter> repeats the previous search for any of the commands, that is a built-in feature. So you just have to map s<cr>  (or the original <Plug>...<cr>) to something, and there you have your instant repeat. (The labeling - that cannot be turned off, as of now - is the only minor annoyance, as I mentioned.)
As for the rest, there's some food for thought there. Meditate on this, I will. :D

There is c flag for :s which does exactly what you are describing. :s/foo/bar/c will jump between matches and prompt you whether you want to apply replacement.

Sorry @gegoune my comment was a bit misleading, I did say "interactive find and replace" but I was not referring to the kind you kindly mentioned in your comment.
Thanks for the suggestion 🙏

Just to make sure I understand you correctly, to repeat the search in this case, one has to not just press s but also the extra 2 keys as well, correct? Or is there a way I am missing to repeat it without those 2 extra presses?

No, this is a fully functioning workaround - pressing <enter> instead of giving a search pattern repeats the previous search for any of the commands, that is a built-in feature. So you just have to map s<cr> (or the original <Plug>...<cr>) to something, and there you have your instant repeat. (The labeling - that cannot be turned off, as of now - is the only minor annoyance, as I mentioned.)

@ggandor That is interesting! I have a feeling I tried  before and nothing happened but I may be confusing with something else, I shall try this tomorrow and see how it goes!

Just to make sure I understand you correctly, to repeat the search in this case, one has to not just press s but also the extra 2 keys as well, correct? Or is there a way I am missing to repeat it without those 2 extra presses?

No, this is a fully functioning workaround - pressing <enter> instead of giving a search pattern repeats the previous search for any of the commands, that is a built-in feature. So you just have to map s<cr> (or the original <Plug>...<cr>) to something, and there you have your instant repeat. (The labeling - that cannot be turned off, as of now - is the only minor annoyance, as I mentioned.)
As for the rest, there's some food for thought here. Meditate on this, I will. :D

I tried it, and it does work somewhat but not ideal :)
There is the flashing lights which makes the cursor stand out less, but also it doesn't continue past where the screen currently is (not that I plan for it to scroll downwards that much), in contrast with your repeating f which does continue downwards.
Even without this implemented however, I still think it's a great plugin :)

In the case of an indeliberate find and replace, I jump somewhere do some change and only then the intention to propagate this change occurs, and then I would like to do (used to do with sneak.vim), for example, ;.;.;. to repeat the change quickly, sometimes skipping some matches, like ;.;;;.;;..

Okay, this is a very rare situation I guess.
It might still be beneficial to just switch to *, because you potentially has to skip a lot of false posivites in-between, if you're repeating the 2-char search pattern.

do #*, and go back to the first match with the opposite key

" The * will stay on the current instance (stolen from Steve Losh's config)
nnoremap <silent> * :let view = winsaveview()<cr>*:call winrestview(view)<cr>

Also, one should usually use {op}gn, in these cases, so after landing on the target, you can just press e.g. *cgn.... for changing 4 instances of the word under the cursor, instead of *ciwn.n.n.n. That is a very neat trick, see :h gn.  With repeating 2-char search, it is not possible.

and the key press to ":nohl" afterwards in the end.

Yeah, that could be annoying, I have already mapped <esc> (which is of course CapsLock) to :noh in Normal mode.

in contrast with your repeating f which does continue downwards.

No, it does not... If scrolloff is set to > 0, then it might go vertically off-screen in a kinda unintended way, but the same is true for s/S. (Actually, f/t shouldn't go into folded areas either, but somehow I decided to allow it by default. However, f/t should definitely be able to go horizontally offscreen on non-wrapped lines, because we might record a macro, or execute a :normal command.)

As a somewhat less subjective reason, I think it will make s and f a bit more symmetrical :)

That's the point, I don't want them to be symmetrical :) For f/t, it is natural to provide either "clever-f" functionality, or ;/,, because for those, the targets cannot be labeled ahead of time anyway. But I don't want to encourage inefficient patterns/behaviors, and induce the "having a hammer, everything looks like a nail" syndrome. /? has all kinds of supporting stuff, there is almost a mini-DSL for search and replace in Vim, with which we cannot - and should not - compete. There are shortcuts for repeat (//, /~/, /&, :s, :&, :s//~/, &, g&), offsets (:h search-offset), the above mentioned gn/gN, etc. etc. We should come up with additional mappings or helper functions then, that encapsulate common patterns and allow this DSL to be used even more efficiently. Lightspeed is for jumping from A to B.
Anyway, this is just my current view on things, feel free to discuss this further here.

do #*, and go back to the first match with the opposite key

" The * will stay on the current instance (stolen from Steve Losh's config)
nnoremap <silent> * :let view = winsaveview()<cr>*:call winrestview(view)<cr>

Also, one should usually use {op}gn, in these cases, so after landing on the target, you can just press e.g. *cgn.... for changing 4 instances of the word under the cursor, instead of *ciwn.n.n.n. That is a very neat trick, see :h gn. With repeating 2-char search, it is not possible.

Wow, I did not know those two tricks, but they work really great!

No, it does not... If scrolloff is set to > 0, then it might go vertically off-screen in a kinda unintended way, but the same is true for s/S. (Actually, f/t shouldn't go into folded areas either, but somehow I decided to allow it by default. However, f/t should definitely be able to go horizontally offscreen on non-wrapped lines, because we might record a macro, or execute a :normal command.)

You are correct!  Sorry for the mistake.

That's the point, I don't want them to be symmetrical :) For f/t, it is natural to provide either "clever-f" functionality, or ;/,, because for those, the targets cannot be labeled ahead of time anyway. But I don't want to encourage inefficient patterns/behaviors, and induce the "having a hammer, everything looks like a nail" syndrome. /? has all kinds of supporting stuff, there is almost a mini-DSL for search and replace in Vim, with which we cannot - and should not - compete. There are shortcuts for repeat (//, /~/, /&, :s, :&, :s//~/, &, g&), offsets (:h search-offset), the above mentioned gn/gN, etc. etc. We should come up with additional mappings or helper functions then, that encapsulate common patterns and allow this DSL to be used even more efficiently. (And/or use plugins like vim-subversive, or even better, LSP/Treesitter-aided solutions.) Lightspeed is for arbitrary jumps between A and B.
Anyway, this is just my current view on things, feel free to discuss this further here. :)

You make a very good point.
I think I may have gotten used to a sub-optimal workflow precisely because sneak.vim allowed to have those repeatable jumps for 2-character searches.
The points you make and the tricks you taught me make perfect sense, now it is just a matter of getting used to them.
I agree with your approach so I will close this issue.  If it is desired by anyone that I reopen this, I will.
Thanks again!

Thanks, glad to hear it was useful! Also, these arguments might be worth adding to the "Why no feature X..." section of the Readme.

Also, these arguments might be worth adding to the "Why no feature X..." section of the Readme.

Screw it, I will just implement this. I've already implemented "proper" ;/, repeat for ft, and it's not much code, pretty clean actually. So even though this might only rarely be useful, the leverage is still high enough I guess.

@ggandor Cool, thanks!
I wonder what changed your mind?

@talw We're talking about shortcuts for what I call - for lack of a better term - "cold" repeat in the codebase now. For ft, it is native, even though it's quite useless when one has a dedicated "instant" repeat option already. But if we have ft + cold-repeat, then sx + cold-repeat is actually a bit more useful. Also, it's true that 10/1 cognitive load + "quite fast" just feels better sometimes than 10/3 cognitive load + maximal speed; this is why one just likes to press wwwwwww when really immersed in a task. I mapped them to <a-;> and <a-,> for now, and I think they have some potential. Especially once I implement labeling for this (would work the same, but you can also directly jump to a distant match). For this mode, I'm also thinking about underlining/highlighting the occurrences of the word (or WORD) that was targeted by the original search.

@ggandor
Indeed, you have a point.
Thanks!


Prepare code to be python package

It would be great to have the code globally in an environment. Please add setup.py and simple configuration for that.

Thanks for a suggestion! I'll do it soon in my spare time :)

setup.py added - see README. In case of problems please reopen.


Site notification

adds two new URLs get a notification and seen notification

get notification -> return all the notifications that the user hasn't
seen

seen notification let the server know that the user has seen this
notification and do not need to send them again the next time

adds manager to reminder class

depends on #73

fix: #68


Fetch tx Timestamp using height

Tx Timestamp in the Transaction Details page is static.

Yes we have receive timestamp from additional block query


[IO-1344] Fix for OOM find_contours issue

Problem
find_contours function calls sometimes result in an OOM issue. Some issue in the underlying simplify_polygon function causes the algorithm to fail to exit and therefore continually append points to a list, resulting in a continually growing use of memory.
Solution
By comparing the simplify_polygon algorithm to existing implementations here
https://namekdev.net/2014/06/iterative-version-of-ramer-douglas-peucker-line-simplification-algorithm/
and the base recursive algorithm here
https://en.wikipedia.org/wiki/Ramer–Douglas–Peucker_algorithm
we can see that the algorithm is meant to iterate from i=startIndex+1 to i<endIndex-1 (exclusive) in both instances, but currently iterates to (endIndex) on one of the loops, not setting the stack correctly.
Changelog
Fixes an issue that causes memory use to spiral out of control when attempting to find the contours of an image.

Discussion here: https://github.com/v7labs/upolygon/pull/15


3.1 build issue on Amazon Linux

Building OpenSSL 3.1.0 on Amazon Linux we get this issue
2023/04/21-12:25:33: [INFO] OpenSSL: Building version 3.1.0 for aarch64-pc-linux-gnu
Text::Template version 1.46 required--this is only version 1.45 at /builds/platform/cdev-openssl/openssl/openssl-3.1.0/util/perl/OpenSSL/Template.pm line 41.
BEGIN failed--compilation aborted at /builds/platform/cdev-openssl/openssl/openssl-3.1.0/util/perl/OpenSSL/Template.pm line 41.
Compilation failed in require at /builds/platform/cdev-openssl/openssl/openssl-3.1.0/Configure line 22.
BEGIN failed--compilation aborted at /builds/platform/cdev-openssl/openssl/openssl-3.1.0/Configure line 22.
make: *** No targets specified and no makefile found.  Stop.

The build machine has Perl 5.16.3. installed and Perl's Text::Template 1.59 installed.

Working fine for me in latest AmazonLinux 2023 with perl 5.32.1 and Text::Template 1.59 for Openssl 3.1.0. Maybe you need to install perl-core modules.

Hi, sorry - I should have mentioned as well that we are building for ARM on AmazonLinux2 and we've discovered that the problem is

AmazonLinux2 does not have Perl Text Template
EPEL (which we load) has Perl Text Template 1.59 for x86_64, but only Perl Text Template 1.45 for ARM

I think you can still install the perl module from CPAN?

Yes - thank you. We tried that here and it worked.


[feature] Use upstream version of npm for publishing

We currently use a fork of the npm cli for publishing to npmjs.com. We need to merge a change to allow out-of-band provenance.
Related to https://github.com/gh-community/npm-provenance-private-beta-community/issues/11
Related to https://github.com/npm/cli/pull/6300

Blocked on https://github.com/gh-community/npm-provenance-private-beta-community/issues/11 which is, in turn, blocked on https://github.com/npm/cli/issues/6313

Blocked by https://github.com/npm/cli/issues/6455

The PR we are blocked on is: https://github.com/npm/cli/pull/6490


Rename key -> pageKey

In order to increase clarity and consistency, I propose changing the parameter label key to pageKey in the paginate methods.
Motivation
The Swift API Design Guidelines urges us to "Include all the words needed to avoid ambiguity". By changing key to pageKey we remove any ambiguity about what key is — specifically that it is the page key in the query.
This also increases consistency throughout the code since everywhere else (see: Pagination.defaultPageKey) this key is referred to as the pageKey.
Breaking Change?
Potentially, but not drastic. Since the parameter is provided a default value, unless a user has specified the key parameter, there won't be any breaking changes. If, however, they have specified key the compiler can automatically suggest the renamed parameter label which makes upgrading trivial.

We had talked on Discord about potentially changing instances of pageSize to match the new perPage wording. How do you feel about moving forward on that? Or is it unnecessary.

Yeah, I say change the pageSize to better match the style we are after here. Definitely makes more sense to keep everything matching and organized that pertains to each other.

+1
The page and per like the kaminari

I've gone ahead and merged this. 👍

Awesome, I'll open another PR with the other wording changes.

 But sounds good.


restore Info.plist CURRENT_PROJECT_VERSION

Otherwise build rejected w/ App Store Connect Operation Error

...Schedule.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion.

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #42   +/-   ##
======================================
  Coverage    98.8%   98.8%
======================================
  Files          12      12
  Lines         835     835
======================================
  Hits          825     825
  Misses         10      10


Crash strategy

@ricardopereira @tcard as discussed, we are going to approach the reported crashes in the library in four ways:

[x] Wrap all public methods with error handling such that an error is handled, logged, and the connection is moved to the failed state (if appropriate).  The same generic handler should also apply to any incoming events that generate exceptions, and I expect in almost all cases should move the connection to the failed state.
[x] Like a lot of more traditional lower level libraries, they often make assertions about state/properties/context before executing code.  Whilst this won't add any more resilience to the code i.e. it will still fail, it will hopefully help us to diagnose issues more quickly as we can add more context to the failure i.e. a field was expected, an non-null value was expected, and include other details.
[x] The logger should store the last X log lines at verbose level (we need to think about the implications of this from a performance perspective though, can we cache the log entries but perhaps not interpolate the log line until needed?) so that when we generate error reports, we have more context to the events leading up to this crash.
[x] We will consider how we can introduce an Ably client-library exception reporting service where we can send errors when an unexpected error in the library occurs.

PS. Can we double check that https://docs.ably.io/client-lib-development-guide/features/#RTE6 is working.  I am not sure we would need to log these errors to the central service as these are errors in customer code, not ours.  However, we should definitely output that to the local logger and handle the error gracefully.

All done.


refactor current weather and app comonents

move state  and fetch to App component

Hey, this is great. I feel like we now have a more complete understanding of how this all works. Christie, you’re just a diamond in a rhinestone world


Hoist dev dependencies

To reduce duplication among packages, version's mismatch. Several dev
dependencies can be moved to the root package.json.
This also secures only one version for those versions, something that
is not even certain when two packages have the same version string on
the package.json (as can be seen on this yarn.lock)
Moved dependencies:

typescript
ts-node
jest
ts-jest

Exceptions:

blockchain-api & notification-service are google app engine projects
that are built on google cloud, using only dependencies on it's
package.json. Thus, typescript needs to be defined there.

Description
A few sentences describing the overall effects and goals of the pull request's commits.
What is the current behavior, and what is the updated/expected behavior with this PR?
Tested
yarn build, yarn test and ci
Other changes
Remove jest.config from celotool (it doesn't uses jest)
Related issues

Fixes #702

isnt web hosted on google cloud engine too?

isnt web hosted on google cloud engine too?

@aaronmgdr it is. Good catch. But, it seems we build locally, see the npm script:
"deploy": "yarn run kill-dev; yarn run build; yarn remove @celo/types @celo/typescript; gcloud app deploy $MANIFEST",


port over securitytrails

https://github.com/subfinder/subfinder/tree/master/libsubfinder/sources/securitytrails

Note: this source requires an account to do testing/development which you can register for here. I'd imagine most of the dev can be done in the free tier.


update antora structure

Motivation
Update the antora structure to match other SDK docs format/syntax
Progress

[x] Move docs under /docs/modules/ROOT/pages
[x] Remove all other folders under modules
[x] update README to use new routes
[x] small adoc fixes

@laurafitzgerald Really excited to see you contributing to IOS SDK! Great job!

@finp there are some docs still under docs/contrib I wasn't sure how to approach those. Were there similar files in the android one?

Do not touch them. This what we agreed on the list with @finp. It's literally safe heaven for developers who can put any content without exposing them to end users. We document there release process etc. More info on the mailing list.
Verified with: antora local-site.yml

@wtrocki thanks for the reivew. I did move the core.adoc documentation from the contrib folder. I think the extending-metrics.adoc file is a candidate to be moved as well... wdyt? I did some other small fixes if could have some time to look at those changes. thanks :)

@laurafitzgerald Please do not move them! There are internal as we mentioned on the mailing list. Let's revert this changes. extending-metrics.adoc  should not be moved. We had trello card to hide metrics from users etc.

@wtrocki will move those back in a new commit, thanks for info

Linking: https://github.com/aerogear/aerogear-ios-sdk/pull/117 as changes are related.

@laurafitzgerald World class job! Leaving @finp to do final approval!


Firmware update/sync with base/modified Miryoku

Hello!
I've been getting the hang of using my Cheapino with Miryoku, and found a few things that I wanted to tweak. I have my own repo for these, and wanted to share those tweaks here:
Default behavior for encoder has been modified to left/right arrow for cursor control. Seems reasonably universally useful.
I brought everything (QMK and Miryoku) up to upstream current (as of 2023-11-21).
I made what I consider to be a very useful change to default Miryoku's behavior. The right modifier keys are actually the right modifier keys now, so the left split has LCTRL and the right split has RCTRL. For the most part, this change should be invisible, but for programs like VirtualBox that define hotkeys based on CTRL position, this will match expected behavior on a more traditional keyboard.
I have not touched the default keymap, only compiled it with current QMK sources.
I also re-enabled the LED color changes, mostly because I wanted to :-).
The release page is here: https://github.com/ggppjj/qmk_firmware/releases

Thnx! I linked to your release page from the readme.


pls wait few minute,status:fail

hi dear
i have used your wonderfull tool for 2 months but one day i faced with this awful problem and i cant use it anyway becase it always say me:
[-] --:: RESPONSE START -> @armin.fa  ::--
b'{"message": "Please wait a few minutes before you try again.", "status": "fail"}'
[+] --:: RESPONSE   END ::--
[+] Current IP :: <IP_ADDRESS>
[*] Changing IP Address...
[+] Trying [FOR] @armin.fa  :: admin
[-] --:: RESPONSE START -> @armin.fa  ::--
b'{"message": "Please wait a few minutes before you try again.", "status": "fail"}'
[+] --:: RESPONSE   END ::--
[+] Current IP :: <IP_ADDRESS>
[*] Changing IP Address...
[+] Trying [FOR] @armin.fa  :: admin
[-] --:: RESPONSE START -> @armin.fa  ::--
b'{"message": "Please wait a few minutes before you try again.", "status": "fail"}'
[+] --:: RESPONSE   END ::--
[+] Current IP :: <IP_ADDRESS>
[*] Changing IP Address...
and as you see allways status become fail
pls help me anthony
Ways to Reproduce the issue (optional):

pls help me

im also the same

Also seeing the same thing after just installing the running the tool for the first time

im also the same


fix: unwanted drop shadow to the right side of the hero section.

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[x] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Description
Basically, the SVG file of the hero's background had an issue that resulted in the unwanted drop shadow to the right side of the hero section. So, I have slightly tweaked the SVG file which has fixed the problem.
Related Tickets & Documents
Fixes #227
Mobile & Desktop Screenshots/Recordings
Before:

After:

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

https://deploy-preview-402--hot-sauced-ui.netlify.app/

I can see there is an inner shadow on the left side which seems to be intentional by the designer. Can we keep it? @0-vortex

@shamimbinnur I don't see the difference between the before and after. I honestly was not bothered by this and was confused because the linked issue seems unrelated. https://github.com/open-sauced/hot/issues/227
My recommendation is to annotate the screenshot. Also provide more context on how this relates to the issue.

@shamimbinnur I don't see the difference between the before and after. I honestly was not bothered by this and was confused because the linked issue seems unrelated. #227
My recommendation is to annotate the screenshot. Also provide more context on how this relates to the issue.

The image used as SVG gradient has a 1px space on the left and right - without this limitation, we could just be using colors. On browser platforms that don't support scrollbar styling this is making the right tear visible, while the left tear has always been visible, just ignored.
Ideally, we should remove the image and use the tailwind gradient colors for left and right. For what it's worth, the current PR does indeed solve the right tearing, tho it should do the left one too IMHO 😅

@bdougie I added the annotated screenshot.

@bdougie I added the annotated screenshot.

Wow. I wasn't event looking there or noticed. Annotations help.


etcd 3.0.7 rkt container is not starting with permission denied for ssl certs

Hi Team,
When trying to run etcd-3.0.7 as rkt container it complain with below error using etcd-wrapper.
etcdmain: open /etc/ssl/etcd/kube-etcd-member.pem: permission denied****
I can see that volume seems to be mounted where certs are stored.
ls -lrt /etc/ssl/etcd
total 40
-rw-r--r--. 1 root root 1472 Sep  1 12:18 kube-etcd.pem
-rw-r--r--. 1 root root 1472 Sep  1 12:18 kube-etcd-member.pem
-rw-r--r--. 1 root root 1675 Sep  1 12:18 kube-etcd-member-key.pem
-rw-r--r--. 1 root root 1675 Sep  1 12:18 kube-etcd-key.pem
-rw-r--r--. 1 root root 1387 Sep  1 12:18 kube-ca.pem

run: adding {V:etcd-certs,kind=host,source=/etc/ssl/etcd M:{Volume:etcd-certs Path:/etc/ssl/etcd}}
etcd-wrapper[3036]: run: cannot run as unprivileged user
Here is the etcd3.service content:
- name: etcd3.service
  enable: true
  command: start
  content: |
    [Unit]
    Conflicts=etcd.service etcd2.service
    Requires=mnt-data.mount resize-data.service
    After=mnt-data.mount resize-data.service

    [Service]
    Environment="ETCD_DATA_DIR=/mnt/data"
    Environment="ETCD_TAG=v3.0.7"
    Environment="ETCD_IMG_USER=etcd"
    Environment="RKT_RUN_ARGS=--mount volume=etcd-certs,target=/etc/ssl/etcd --volume etcd-certs,kind=host,source=/etc/ssl/etcd,readOnly=true"
    ExecStartPre=/usr/bin/chmod 0755 /opt/etcd3/etcd-wrapper
    ExecStart=/opt/etcd3/etcd-wrapper \
    --election-timeout=1200 \
    --advertise-client-urls=https://$private_ipv4:2379 \
    --initial-advertise-peer-urls=https://$private_ipv4:2380 \
    --initial-cluster=etcd1=https://${host1}:2380,etcd2=https://${host2}:2380,etcd3=https://${host3}:2380 \
    --initial-cluster-state=new \
    --initial-cluster-token=k8s_etcd \
    --listen-client-urls=https://$private_ipv4:2379,https://<IP_ADDRESS>:2379 \
    --listen-peer-urls=https://$private_ipv4:2380 \
    --name=${etcd_name} \
    --peer-trusted-ca-file=/etc/ssl/etcd/kube-ca.pem \
    --peer-cert-file=/etc/ssl/etcd/kube-etcd-member.pem \
    --peer-key-file=/etc/ssl/etcd/kube-etcd-member-key.pem \
    --peer-client-cert-auth=true \
    --trusted-ca-file=/etc/ssl/etcd/kube-ca.pem \
    --cert-file=/etc/ssl/etcd/kube-etcd.pem \
    --key-file=/etc/ssl/etcd/kube-etcd-key.pem \
    --client-cert-auth=true
    Restart=always
    RestartSec=10s

    [Install]
    WantedBy=multi-user.target

I tried to run same rkt run command manually on server using root, gives same problem:

/usr/bin/rkt run --debug --mount volume=etcd-certs,target=/etc/ssl/etcd --volume etcd-certs,kind=host,source=/etc/ssl/etcd --trust-keys-from-https --mount volume=systemd-dir,target=/run/systemd/system --volume systemd-dir,kind=host,source=/run/systemd/system,readOnly=true --volume data-dir,kind=host,source=/mnt/data --mount volume=etc-ssl-certs,target=/etc/ssl/certs --volume etc-ssl-certs,kind=host,source=/etc/ssl/certs --stage1-from-dir=stage1-fly.aci coreos.com/etcd:v3.0.7 --user=232 --exec=/etcd -- --election-timeout=1200 --advertise-client-urls=https://<IP_ADDRESS>:2379 --initial-advertise-peer-urls=https://<IP_ADDRESS>:2380 --initial-cluster=etcd1=https://<IP_ADDRESS>:2380,etcd2=https://<IP_ADDRESS>:2380,etcd3=https://<IP_ADDRESS>:2380 --initial-cluster-state=new --initial-cluster-token=k8s_etcd --listen-client-urls=https://<IP_ADDRESS>:2379,https://<IP_ADDRESS>:2379 --listen-peer-urls=https://<IP_ADDRESS>:2380 --name=etcd1 --peer-trusted-ca-file=/etc/ssl/etcd/kube-ca.pem --peer-cert-file=/etc/ssl/etcd/kube-etcd-member.pem --peer-key-file=/etc/ssl/etcd/kube-etcd-member-key.pem --peer-client-cert-auth=true --trusted-ca-file=/etc/ssl/etcd/kube-ca.pem --cert-file=/etc/ssl/etcd/kube-etcd.pem --key-file=/etc/ssl/etcd/kube-etcd-key.pem --client-cert-auth=true
image: using image from file /usr/lib64/rkt/stage1-images/stage1-fly.aci
image: using image from local store for image name coreos.com/etcd:v3.0.7
stage0: Preparing stage1
stage0: Writing image manifest
stage0: Loading image sha512-f7e8c8ac24b6b995987bc4362beeeaacd859c0aaa8b6258655d79d37605d0905
stage0: Writing image manifest
stage0: Writing pod manifest
stage0: Setting up stage1
stage0: Wrote filesystem to /var/lib/rkt/pods/run/d07430ed-62ca-4d2d-bd85-8d0783a54e1f
stage0: Pivoting to filesystem /var/lib/rkt/pods/run/d07430ed-62ca-4d2d-bd85-8d0783a54e1f
stage0: Execing /run
run: adding {V:,kind= M:{Volume:etcd-certs Path:/etc/ssl/etcd}}
run: adding {V:,kind= M:{Volume:systemd-dir Path:/run/systemd/system}}
run: adding {V:,kind= M:{Volume:etc-ssl-certs Path:/etc/ssl/certs}}
run: adding {V:,kind= M:{Volume:data-dir Path:/data-dir}}
run: adding {V:etcd-certs,kind=host,source=/etc/ssl/etcd M:{Volume:etcd-certs Path:/etc/ssl/etcd}}
run: adding {V:systemd-dir,kind=host,source=/run/systemd/system,readOnly=true M:{Volume:systemd-dir Path:/run/systemd/system}}
run: adding {V:data-dir,kind=host,source=/mnt/data M:{Volume:data-dir Path:/data-dir}}
run: adding {V:etc-ssl-certs,kind=host,source=/etc/ssl/certs M:{Volume:etc-ssl-certs Path:/etc/ssl/certs}}
run: adding {V:data-dir,kind=host,source=/mnt/data,readOnly=false M:{Volume:data-dir Path:/data-dir}}
run: chroot to "stage1/rootfs/opt/stage2/etcd/rootfs"
run: setting uid 232 gid 0
run: execing ["/etcd" "--election-timeout=1200" "--advertise-client-urls=https://<IP_ADDRESS>:2379" "--initial-advertise-peer-urls=https://<IP_ADDRESS>:2380" "--initial-cluster=etcd1=https://<IP_ADDRESS>:2380,etcd2=https://<IP_ADDRESS>:2380,etcd3=https://<IP_ADDRESS>:2380" "--initial-cluster-state=new" "--initial-cluster-token=k8s_etcd" "--listen-client-urls=https://<IP_ADDRESS>:2379,https://<IP_ADDRESS>:2379" "--listen-peer-urls=https://<IP_ADDRESS>:2380" "--name=etcd1" "--peer-trusted-ca-file=/etc/ssl/etcd/kube-ca.pem" "--peer-cert-file=/etc/ssl/etcd/kube-etcd-member.pem" "--peer-key-file=/etc/ssl/etcd/kube-etcd-member-key.pem" "--peer-client-cert-auth=true" "--trusted-ca-file=/etc/ssl/etcd/kube-ca.pem" "--cert-file=/etc/ssl/etcd/kube-etcd.pem" "--key-file=/etc/ssl/etcd/kube-etcd-key.pem" "--client-cert-auth=true"] in "stage1/rootfs/opt/stage2/etcd/rootfs"
2016-09-01 12:22:14.146834 I | flags: recognized and used environment variable ETCD_DATA_DIR=/data-dir
2016-09-01 12:22:14.148874 I | etcdmain: etcd Version: 3.0.7
2016-09-01 12:22:14.148956 I | etcdmain: Git SHA: 5695120
2016-09-01 12:22:14.149045 I | etcdmain: Go Version: go1.6.3
2016-09-01 12:22:14.149123 I | etcdmain: Go OS/Arch: linux/amd64
2016-09-01 12:22:14.149206 I | etcdmain: setting maximum number of CPUs to 1, total number of available CPUs is 1
2016-09-01 12:22:14.149324 W | etcdmain: found invalid file/dir lost+found under data dir /data-dir (Ignore this if you are upgrading etcd)
2016-09-01 12:22:14.149410 I | etcdmain: peerTLS: cert = /etc/ssl/etcd/kube-etcd-member.pem, key = /etc/ssl/etcd/kube-etcd-member-key.pem, ca = , trusted-ca = /etc/ssl/etcd/kube-ca.pem, client-cert-auth = true
2016-09-01 12:22:14.149488 C | etcdmain**: open /etc/ssl/etcd/kube-etcd-member.pem: permission denied**
Please let me your inputs on why it complain with permission denied error for SSL certs.
Thanks!

Hi again,
I did some more testing and seems more problem like this:
Scenario-1: When I tried to use coreos latest beta version (CoreOS 1122.1.0) which has etcd-wrapper script natively then etcd rkt container is starting properly without any permission denied error.
Scenario-2: When I tried to use CoreOS stable version: CoreOS 1068.10.0 and tried to copy and use same wrapper script then I am getting permission denied error ssl certificates which mounted as volume.
Hence I am not sure the exact problem here.
In this case, I would like to use CoreOS stable version if possible.
Else I need to go with Beta version to get rid of permission denied errors.
Please let me know your thoughts on this.

@crawford @steveeJ can you help to take a look at this etcd wrapper related question? thanks!

@sachincab Please create an issue here: https://github.com/coreos/bugs. Thanks!


Use pointer to actually load configuration file

config was being passed to ini.MapTo as a copy of the struct, so the fields were never getting updated.

Good catch.


App Config Schema for aio app pack is outdated

Describe the bug
The file should be taken from https://github.com/adobe/aio-cli-lib-app-config/blob/master/schema/app.config.yaml.schema.json
#682 is fixing this but it is still in discussion as it is a breaking change. It could be preferable to come up with an intermediate update just for the app pack command.

@moritzraho Is there an update on this? Was testing aio app install for the EQP checks and noticed it doesn't fail the app.config.yaml schema validation check for extensions. I think this is because the config files aren't coalesced before the schema is validated

@MichaelGoberling fixed in #723


feat: Configure networks

Description of change

Adds option to create developer profiles (+ removes developerMode in appSettings)
Adds overview of network information like name and status (in settings page)
Adds automatic detection for specific IOTA network based on node configuration
Add function to help migrate profiles on login (+ general object migration function)
Adds new SVG data for wifi icon

Type of change

Enhancement (a non-breaking change which adds functionality)
New (a change which implements a new feature)

How the change has been tested
Successfully swapped networks in one Firefly profile while broadcasting transactions over each one.
Tested on:

MacOS (Catalina 10.15.7)

Change checklist

[x] I have followed the contribution guidelines for this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Closing as the recent changes in develop have blown up this PR. Also missing important functionality from wallet.rs regarding associating networks for different outputs.


fix: column ajuster body height

before:

after:

https://user-images.githubusercontent.com/4471489/225721965-730205b5-d5bf-4998-b762-d575f5847cb8.mov
Todo:
scroll table

There is a lot of flickering on the actual blue outliner? Have you noticed that? When I run this locally I barely see the blue outliner at all

Example:
https://user-images.githubusercontent.com/16608020/225833164-483d5dbf-ed50-4d55-b876-a690d41932cd.mov

Example: https://user-images.githubusercontent.com/16608020/225833164-483d5dbf-ed50-4d55-b876-a690d41932cd.mov

looks like it is not blue when the pointer is over the border?


Kube Advisor repo is archived and doc needs to be updated for best practices

[Enter feedback here]
https://github.com/Azure/kube-advisor
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fd6a725f-02ee-4337-609d-bdb4adff3359
Version Independent ID: 8b2116c8-5ca3-32ee-e187-87e665c999a0
Content: Operator best practices - Basic scheduler features in Azure Kubernetes Services (AKS) - Azure Kubernetes Service
Content Source: articles/aks/operator-best-practices-scheduler.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@sudivate Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

Any update?  This was also mentioned in #71759

Thank you @sudivate for the feedback.
We've updated the article to address your feedback and the changes should be available soon.


Updated intro to Razor Pages URL generation.

Fixed #14428.

This is a little bit different to the original suggestion, which didn't read well in the context of the surrounding explanations. I hope it's still OK.


Mysterious test hangs in start_edgedb_server

Fantix and I have both been able to replicate this, at least sometimes.
edb test -j32 -k test_server_adjacent -k test_server_proto  -v fairly consistently has a hang on @fantix's machine.
I've managed to reproduce it with taskset -c 0-15 edb test -j32 -k test_server_adjacent -k test_server_proto  -v on my test machine, but not consistently.
I discovered this while testing https://github.com/edgedb/edgedb/pull/6782, and with https://github.com/edgedb/edgedb/pull/6782 there seemed to also be knock-on effects where some other DROP DATABASE commands hung, which needs to be tracked down.

Looks like the hanging happens during server start, when the pool failed to complete a connection acquisition when it's exhausted by concurrent database (early) introspection due to test database clones, like shown in my debug:
413955 EARLY INTROSPECT __edgedbsys__
413955 EARLY INTROSPECT edgedb
413955 EARLY INTROSPECT serverprotoconcurrentddl
413955 EARLY INTROSPECT serverconfig
413955 EARLY INTROSPECT serverproto
413955 EARLY INTROSPECT serverprotoddlpropagation
413955 EARLY INTROSPECT serverprotoconcurrentglobalddl
413955 EARLY INTROSPECT serverprotoddl
413955 EARLY INTROSPECT serverprotomigration
413955 EARLY INTROSPECT serverproto_413755
413955 EARLY INTROSPECT serverproto_413753
413955 EARLY INTROSPECT serverprotoddl_413751
413955 EARLY INTROSPECT serverprotoddl_413752
413955 EARLY INTROSPECT serverprotoddl_413745
413955 EARLY INTROSPECT serverprotoddlpropagation_413749
413955 EARLY INTROSPECT serverprotoddlpropagation_413748
413955 EARLY INTROSPECT serverprotoddlpropagation_413747
413955 EARLY INTROSPECT serverprotomigration_413750

(18 concurrent requests on the pool with a size of 10)
In detail, the pool had to steal a connection from other blocks, but the async task was never resumed for some reason.
@msullivan @1st1 With databases transiting to branches, is it still necessary to maintain a connection pool that mostly deals with the case when many databases/branches are competing for a limited number of connections?


Travis: Add PHP72 and 73 test environments.

Coverage remained the same at 100.0% when pulling 613d798d6355299552d95119b769523398b1d775 on php72-73 into 44362c7c8aace5c52bd20d917b87e6c1d2d8c5c6 on master.


Added debugpy dev dependency to support remote debugging in VS Code

Closes: #1273
What's Changed

Related to #2831
Add debugpy dev dependency to support remote debugging in docker containers.
TODO

[x] Explanation of Change(s)
[x] Added change log fragment(s) (for more information see the documentation)

Instead of adding this dependency can vscode leverage the rdb functionality of celery?
https://docs.celeryq.dev/en/stable/userguide/debugging.html#debugging-tasks-remotely-using-pdb


Missing feature in vexflow 5

@jaredjj3 do you have any request for vexflow 5?

Is there a coloring API? I would like to be able to color elements before and after they're rendered. In stringsync, I have to interact with SVG elements directly, which isn't ideal.

Yes there is:

setStyle which modifies an Element
setGroupStyle which modifies an Element and its associated childs.

Do you think that we could use vexml in pianoplay? I do not think that osmd will update to vexflow 5 in the medium term.

Yes, of course. I don't really know about piano-specific notations, so I could use your help there.

@rvilarl, is there something like getGlyphWidth that's public?
I'm interested in precalculating widths in order to perform that calculation that splits a system into several smaller ones. I would replace these hacky implementations with this vexflow font width calculation API.

Yes there is:

setStyle which modifies an Element
setGroupStyle which modifies an Element and its associated childs.

I forgot to reply to this. Ok, this is good enough for my use case.

@rvilarl, is there something like getGlyphWidth that's public?
I'm interested in precalculating widths in order to perform that calculation that splits a system into several smaller ones. I would replace these hacky implementations with this vexflow font width calculation API.

You can use an Element set the text and get the width.

Is there a way to get the current font? Tables.currentMusicFont() doesn't seem to be public.

Element takes the fonts directly from the metrics file. The function is Metrics.getFontInfo(), this would take the general one. Metrics.getFontInfo('Accidental') would get the default fonts for accidentals. You can pass the selector to the constructor of Element:
const element = new Element('Clef');
element.setText(Glyphs.fClef);
const width = element.getWidth();

@rvilarl do you know when https://github.com/0xfe/vexflow/pull/1596 will be in vxflw-early-access? Development is slowing down since I have been having to hack around the current limitations in my environment.

This is already in. @ronyeh could you make a release? I should learn how to do it.

I made a new alpha release:
https://www.npmjs.com/package/vxflw-early-access?activeTab=versions
https://github.com/vexflow/vexflow/releases/tag/5.0.0-alpha.3
@rvilarl You can make the next release :-) See https://github.com/vexflow/vexflow/issues/116

Thanks Ron, it’s working for me.

setText

@rvilarl, it looks like Glyph got unexported in https://github.com/vexflow/vexflow/commit/afadd9b557ad653304df58b22af66676965c1e5f#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80. Is there another way I could get the glyph?

Glyph is no longer there. A Glyph is a character in a Font. Element is the new abstraction which is valid for the previous MusicFont and TextFont. TextFormatter is also not there.

Hi Jared,
Can you tell us what you were doing with the Glyph class? Perhaps Rodrigo can suggest an alternative method. If it is something that is no longer possible in v5, we should investigate to see if we can bring back that functionality somehow. If you find it important, other people might find it important too.
Thanks!

@ronyeh sure, I'm happy to explain in detail.
In vexml, there is a procedure that takes a single system and splits them into several smaller systems to fit the renderer width (code). In order to do this, I need to determine the width for each measure. I identified the minimum width of each measure to be the max(stave modifiers width + the justification width) across all the parts related to that measure. I would like this to be done cheaply.
For the stave modifiers width, it feels like I'm hacking vexflow. I render a vexflow.Stave at x = 0, and read vexflow.Stave.getNoteStartX to determine how much width the modifiers take up. I end up doing this for each modifier separately (code).
I don't feel the same way about the measuring justify width, because vexflow.Formatter exposes a measuring utility that does exactly what I need. That is, pre calculate the minimum total width needed to accommodate the vexflow.Voices (code).
I'm asking for a way to measure the stave modifiers without having to render the entire stave.

I assume this was easier in v4 (before Glyph was removed)?
Do you have a proposed API for this? (Or did you like the v4 method?) We
can probably figure out a way to implement the getWidth() that you need and
then add it to the API.
On Thu, Oct 5, 2023, 3:43 AM Jared Johnson @.***> wrote:

@ronyeh https://github.com/ronyeh sure, I'm happy to explain in detail.
In vexml, there is a procedure that takes a single system and splits them
into several smaller systems to fit the renderer width (code
https://github.com/stringsync/vexml/blob/44e8817a3be276b738ac7c1dcbc1de084d7c3ccd/src/rendering/system.ts#L49).
In order to do this, I need to determine the width for each measure. I
identified the minimum width of each measure to be the max(stave modifiers
width + the justification width) across all the parts related to that
measure. I would like this to be done cheaply.
For the stave modifiers width, it feels like I'm hacking vexflow. I
render a vexflow.Stave at x = 0, and read vexflow.Stave.getNoteStartX to
determine how much width the modifiers take up. I end up doing this for
each modifier separately (code
https://github.com/stringsync/vexml/blob/0e09bb854ccacdbeafb0902ac8e7eb5e8a13a8c6/src/rendering/stave.ts#L264-L297
).
I don't feel the same way about the measuring justify width, because
vexflow.Formatter exposes a measuring utility that does exactly what I
need. That is, pre calculate the minimum total width needed to accommodate
the vexflow.Voices (code
https://github.com/stringsync/vexml/blob/44e8817a3be276b738ac7c1dcbc1de084d7c3ccd/src/rendering/chorus.ts#L182
).
I'm asking for a way to measure the stave modifiers without having to
render the entire stave.
—
Reply to this email directly, view it on GitHub
https://github.com/stringsync/vexml/issues/113#issuecomment-1748638371,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB2MCKII456UKSQPATFPJ3X52FORAVCNFSM6AAAAAA5NDXIXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBYGYZTQMZXGE
.
You are receiving this because you were mentioned.Message ID:
@.***>

I only learned about it in this thread https://github.com/stringsync/vexml/issues/113#issuecomment-1742186051, so I never used it. After studying vexflow more, I think I found a solution to my problem.
Currently, I'm using Stave.[addClef|addKeySignature|addTimeSignature] to add stave modifiers, which also has the convenience of guaranteeing a stave association.
I learned that constructing a Clef or TimeSignature causes the width to be set, so I can call StaveModifier.getWidth on that.
However, KeySignature.getWidth has a precondition for a stave to be set, so I'd have to create and associate a dummy Stave in order to get a width after constructing it. This feels hacky. How feasible is it to remove the stave association precondition to get a key signature width?

However, KeySignature.getWidth has a precondition for a stave to be set, so I'd have to create and associate a dummy Stave in order to get a width after constructing it. This feels hacky. How feasible is it to remove the stave association precondition to get a key signature width?

I will look into that

Is there a way to get the current font? Tables.currentMusicFont() doesn't seem to be public.

Hi! I haven't been following this conversation, so I just saw this comment.
My current work in progress PR deals with improving the font API. There is already something in flow.ts which exposes the current music font, but this API might change a little due to my PR.
Hopefully by next week I'll respond to this thread again with the suggest V5 solution to this. (But in the past we have kept tables.ts internal, but exposed some things through flow.ts).

@rvilarl, is there something like getGlyphWidth that's public?
I'm interested in precalculating widths in order to perform that calculation that splits a system into several smaller ones. I would replace these hacky implementations with this vexflow font width calculation API.

@jaredjj3 we have now Element.measureWidth()

Awesome! After I finish #162, I'll use it instead of the current hacky implementation.

I'm going to update vexflow and try using Element.measureWidth now. When that's done, I'll close this issue since things have been discussed in the pull requests.


Provide a template without any CSS

In order to use revealmd plugin, a blank template must be used, but at the same time we do also like to have features like Piwik, Google Analytics, etc.
The revealmd template could inherit/extend from a blank template (no css loaded) and then, add the ones for revealjs.com that it will require, but at the same time, having all the features already available in the theme.
Actual 'base' could extend from that blank one, and add the relevant css files

Here is what I understand and please correct me if I am wrong.

Issue that all our templates include elegant.css. You want a template that can include custom CSS created especially for presentations.
You want this special template to have all other stuff like support for Google analytics etc.

That's all there is to it.

Exactly!!


SQL Migration Extension Version bump up to 1.5.3 with hotfix

SQL Migration Extension Version bump up to 1.5.3 with hotfix

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 41.761%

Totals

Change from base Build<PHONE_NUMBER>:
0.002%

Covered Lines:
30829

Relevant Lines:
69082

💛  - Coveralls


Is this in inferrer and/or ssa/types_propagation?

inference - Johnni added the regression tests here: https://dart-review.googlesource.com/c/sdk/+/19566


Allow for checkout steps when no ecommerce object is present

The project I'm working on now doesn't send the ecommerce object with checkout steps. It would be great if what I set under "Checkout Setup" works when no ecommerce object is present.

Fixed.


CLI does not return non-zero on error

Always seems to return 0, even when ERROR is encountered.

Thanks for reporting this, will fix this for the pull request that is up

This is resolved with the latest commit and is part of the open pull request now.


Typescript poc

Description:
Hi Chris,
We (@marcalexiei & @giovannipiller) have been thinking to contribute a bit to the project and had a couple of ideas.
Convert Ractive to Typescript
As suggested in #3172. This could help a lot while refactoring the code or hunting for bugs.
From our initial tests it looks like having a project which mixes JS and TS is possible, which should make things easier for us. We only noticed problems when importing JS from a TS file, but not the other way around.
Automate generation of API documentation
Documentation seems to be kind of an issue.
Storing part of it alongside the code should make it easier to maintain, reduce duplication and avoid inconsistencies (ex. changing a type in the code should also update the doc)

We’ve set up this PR to start some progress and gather some discussion.
To generate the documentation:

npm i
npm run doc

As a proof of concept, we added some content forRactive.prototype.toHTML() method and Ractive.prototype.observe, which will be found in the following paths:

{RepoFolder}/docs/modules/ractive_prototype_observe.html
{RepoFolder}/docs/modules/ractive_prototype_tohtml.html

Is breaking:
Nothing, but it's a WIP

Just wanted to say that I think that a gradual move to ts is a great idea. There are some really chewy parts of ractive that will probably fight typing pretty hard, but it can probably be persuaded. I think it may help to modernize the build system a bit too, since gobble is no longer developed and likely stuck at node 8.
It's great to see a pr open up here! Let me know if you have any questions about the wild and wooly code base. I'd be happy to chat, and I'll try to lend a hand if you'd like when my schedule opens up a bit.

Hi @evs-chris, I have more than 50% of the conversation (I think :D).
If you have some spare time could you please take a look and let me know what do you think about it.
I left a large amount of any across the code but I think we will can get rid of them in the future.
Thanks in advance!

Yes! I should be able to clone this weekend and give you a bit of feedback.

Hi @evs-chris,
refactor is nearly complete but there are some points that I would like to bring to your attention:
General information

I have created a RactiveDefinition file which define Ractive as a class.

Should we consider making Ractive as a class?
There are many any keywords which cause many eslint warning.
I would like to leave them and progressively remove them in the future.
In the meantime, I added --quiet option on lint:all task to exclude them from the build process log
All implementation change due to this refactor have a comment TSRChange followed by a briefly description of the change
I updated node to version 12 (ESlint no longer supports node 8)

Improvements To-Do

It would be nice to generate ts definition file automatically.
Update build system
Automatic documentation generation
Some Ractive prototype function may use generic typings to improve their param signature

Do you want to procede with a merge to a 2.x branch or would you like to make some adjustments?

Hi everyone, just as a FYI, next week I'm planning to run a few tests using a build of this branch on a pretty complex web-app.
As of now I've been able to build and run everything without any obvious issue.
I'll report back next week!

Nice! I think this would be a good opportunity to start a 2.x branch.
I personally think a factory may be a better pattern than a class, but I'm not positive. Going into 2.0, we have the opportunity to adjust some things.
@marcalexiei would you like to be added as a maintainer?
On a somewhat related topic, I cleaned up the rollup-plugin-ractive-bin project a bit last week, and it now integrates much more cleanly with the typescript rollup plugin. What do you usually use to build your projects?

I personally think a factory may be a better pattern than a class, but I'm not positive. Going into 2.0, we have the opportunity to adjust some things.

Yes, I imagine that there is some way to combine factory pattern and types.
In my opinion the main goal is to find a way to have automatic deginition generation.
Any solution that makes this possibile is a good to go.

@marcalexiei would you like to be added as a maintainer?

Yes. Thank you 😊

What do you usually use to build your projects?

I use webpack with a custom HTML loader which parse HTML into a template object (basically a fork from official webpack-html-loader).
Basically for each component there are 3 files:

component.rhtml -> which is parsed by the custom loader
component.css
component.js -> import the two other files and export the Component "definition"

Hi @evs-chris, do you want to make other adjustments before merging into a new branch?
Just re-checking 😀

I'm having a few issues while using the runtime.js bundle of Ractive. I'll check them out with @marcalexiei and report back.

No, I think we should probably go ahead and merge this into the new 2.0 branch and carry on from there!

As a next step I will try to remove as many "any" as possible from the source code.


Fix errcheck linter by adding error checks everywhere

All these changes, just to enable the errcheck linter: https://github.com/cert-manager/cert-manager/compare/master...inteon:fix_errcheck?expand=1#diff-9917ddc9f1c3304218f7269265b746d997c5c0615478177b5fceecd33ef47cb5L5
Note for reviewer:
Generally, this PR should not contain anything unexpected (lots of additional err checks).
I had to update some of the test cleanup code to fix issues with delete operations that were incorrect.
Kind
/kind cleanup
Release Note
NONE

/approve


[SPARK-24872] Replace taking the $symbol with $sqlOperator in BinaryOperator's toString method

What changes were proposed in this pull request?
“||” will perform the function of STRING concat, and it is also the symbol of the "OR" operation.
When I want use "||" as "OR" operation, I find that it perform the function of STRING concat，
spark-sql> explain extended select * from aa where id==1 || id==2;
== Parsed Logical Plan ==
'Project [*]
+- 'Filter (('id = concat(1, 'id)) = 2)
+- 'UnresolvedRelation aa
spark-sql> select "abc" || "DFF" ;
And the result is "abcDFF".
In predicates.scala, "||" is the symbol of "Or" operation. Could we remove it?
How was this patch tested?
We can test this patch  with unit tests.
Please review http://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Jenkins, test this please.

cc @gatorsmile @cloud-fan @HyukjinKwon this is a good thing to do?

ok to test

Looks it's gonna make a compilation failure and I see potential references referring this field. @httfighter, I think manual build and tests are required.

ok to test

test this please

Test build #93378 has started for PR 21826 at commit fb98029.

Test build #93378 has finished for PR 21826 at commit fb98029.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93378/
Test FAILed.

I am not sure there is much to do here. OR is the standard syntax for or, and || is pretty common syntax for string concatenation. Removing || breaks binary compatibility and also makes our SQL dialect less compatible with others. The only thing I think that might be worth fixing is the precedence of || in the example, parsing id==1 || id==2 into ('id = concat(1, 'id)) = 2 is a bit weird IMO.

I did the following tests in mysql.
mysql> select "abc" || "def";
+----------------+
| "abc" || "def" |
+----------------+
|              0          |
+----------------+
mysql> select "abc"  "def";
+--------+
| abc    |
+--------+
| abcdef |
+--------+
mysql> select * from aa where id=1 || id=2;
+------+------+
| id   | name |
+------+------+
|    1 | sdf  |
|    2 | ader |
+------+------+
mysql> select * from aa where id=1 or id=2;
+------+------+
| id   | name |
+------+------+
|    1 | sdf  |
|    2 | ader |
+------+------+
It seems that it does not act as a string connector, but as an "or" operation. I don't know if my tests are correct.

I have a suggestion that I don't know if it is reasonable.
In our spark, since we already support “||” as a string concatenation function, I don't know if we can make such an improvement. In the SQL project part, we will use "||" as a string concatenation function. In the SQL filter part, we will use  "||" as the “Or” operation.
@HyukjinKwon @viirya @gatorsmile @rxin @hvanhovell

No we can't because you can still use string concat in filters, e.g.
colA || colB == "ab"
What is "||" here?

Test build #93596 has started for PR 21826 at commit 7ab449f.

I have submitted a new code. Could you help me review the code? Thank you! @HyukjinKwon @viirya @gatorsmile @rxin @hvanhovell
In Hive, "||" performs the function of STRING concat, the symbol of "Or" operator is 'or'
hive> explain select * from aa where id=1 or id=2;
and its Filter part is
predicate: ((id = 1) or (id = 2)) (type: boolean)
In Spark, "||" also performs  the function of STRING concat. We can change the symbol of "Or" operator to 'or'.
spark-sql> explain extended select * from aa where id=1 or id=2;
| == Parsed Logical Plan ==
'Project [*]
+- 'Filter (('id = 1) or ('id = 2))
+- 'UnresolvedRelation aa

Test build #93596 has finished for PR 21826 at commit 7ab449f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93596/
Test PASSed.

Test build #93714 has started for PR 21826 at commit 3743b79.

Test build #93714 has finished for PR 21826 at commit 3743b79.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93714/
Test FAILed.

Merged build finished. Test FAILed.

The last test bulid failed, but all the test cases passed. I don't know what the problem is.  Could you help me trigger it again? @HyukjinKwon

retest this please.

Test build #93766 has started for PR 21826 at commit 3743b79.

Thank you very much! @viirya

Test build #93766 has finished for PR 21826 at commit 3743b79.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93766/
Test FAILed.

It failed again. I don't know what the problem is. Could you help me trigger it again?@viirya

retest this please.

Test build #94501 has started for PR 21826 at commit 3743b79.

Test build #94501 has finished for PR 21826 at commit 3743b79.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94501/
Test PASSed.

retest this please

Test build #100523 has started for PR 21826 at commit 3743b79.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6463/
Test PASSed.

Test build #100523 has finished for PR 21826 at commit 3743b79.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100523/
Test FAILed.

retest this please

Test build #100536 has started for PR 21826 at commit 3743b79.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6472/
Test PASSed.

Test build #100536 has finished for PR 21826 at commit 3743b79.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100536/
Test PASSed.

@gatorsmile This solution is more suitable！I have updated the submission.

Test build #100680 has started for PR 21826 at commit d15ffc4.

Test build #100680 has finished for PR 21826 at commit d15ffc4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100680/
Test PASSed.

Looks like it gets approved but not merged yet. The PR description looks not really correct.
@httfighter Will you like to update the PR description?

retest this please.

retest this please

Test build #104464 has started for PR 21826 at commit d15ffc4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9794/
Test PASSed.

@viirya Thank you for your review. I have updated the PR description.

Test build #104464 has finished for PR 21826 at commit d15ffc4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104464/
Test PASSed.

cc @cloud-fan for final check.

thanks, merging to master!


Openinvoice::getOptionalFormFields also used in HPP

That was quite unexpected, we've made changes to the Openinvoice::getOptionalFormFields and while debugging a problem with visa and paypal we found HPP also calls the Openinvoice method (and a bug in our code might have caused the problem).
(we added the tax-over-discount fix, but apparently it is not fully working, so we removed it - rather have some people complain about their Klarna invoice than have people not being able to do a payment).
What is it used for in other HPP payments?
We could have seen this earlier of course, as it is logged in adyen_http-request.log and I could have done a search of course.
Anyway, it's a bit odd, as Openinvoice extends HPP, that HPP would call a method in Openinvoice.
Suggestion is to move this to either Adyen_Payment_Model_Adyen_Hpp or Adyen_Payment_Model_Adyen_Abstract, or not :) (we now know this is how it works and can handle accordingly).

Hi Ewald,
That is correct we want HPP to send in all data as well for fraud purposes. We could move it so it is more clear that is used for all HPP payment methods.
Regards,
Rik
Adyen

Ok, clear :)
So if the order lines don't add up, a visa/paypal payment is also denied on basis of fraud?
Because that would explain why we have had some payments that couldn't go through because the customer got a "Invalid Request - Unfortunately we were unable to process this request" directly from Adyen.
I'm taking my fixes for Klarna invoices back to the drawing board anyway.

Hi Ewald,
No that should not be an issue we would make sure with a extra line that it will be correct. We only give this if the request is not correct.
Regards,
Rik
Adyen


Cannot get connection details: object is not part of release

What happened?
I tried to expose one of the secret fields in connectionDetails, but got warning: cannot get connection details:
cannot get connection details: object is not part of release: {Secret test vc-vcluster-test v1 data.config}
because reason:
CannotObserveExternalResource
But I found out that the secret named vc-vcluster-test exists in namespace test.
How can we reproduce it?
Apply this file to crossplane with a verified secret named vc-vcluster-test exists in namespace test:
apiVersion: helm.crossplane.io/v1beta1
kind: Release
metadata:
  name: vcluster-test
  annotations:
    crossplane.io/external-name: vcluster-test
spec:
  connectionDetails:
    - apiVersion: v1
      kind: Secret
      name: vc-vcluster-test
      namespace: test
      fieldPath: data.config
      toConnectionSecretKey: kubeconfig
  writeConnectionSecretToRef:
    name: vcluster-test-secret
    namespace: crossplane-system
  rollbackLimit: 3
  providerConfigRef:
    name: helm-provider
  forProvider:
    namespace: test
    chart:
      name: vcluster
      repository: https://charts.loft.sh
      version: "0.12.2"

What environment did it happen in?

Crossplane version: crossplane-1.9.1
Kubernetes version: v1.21.11
Kubernetes distribution: rke2r1
provider-helm: xpkg.upbound.io/crossplane-contrib/provider-helm:v0.12.0
Kernel :Linux harvester1 5.3.18-150300.59.63-default #1 SMP Tue Apr 5 12:47:31 UTC 2022 (d77db66) x86_64 x86_64 x86_64 GNU/Linux

It seems to be the same as #99. As provider-helm expects all objects to be marked as part of the release which means it contains helm annotations: https://github.com/crossplane-contrib/provider-helm/blob/master/pkg/controller/release/observe.go#L175
There is unfortunately no workaround for that. You can use provider-kubernetes to observe any resource and just wrap those two to custom XRD.

Closing as duplicate of #99


DateTime format from the local system causes dotnet ef database update to fail

To repeat

Have your Windows region a country that by default does not have ':' as a time digit separator
Have a model
Add public DateTime test { get; set; }
Add a migration dotnet ef migrations add DateAdded
Update database dotnet ef database update
Exception: 22007: invalid input syntax for type timestamp: "0001-01-01 00.00.00"
Go to the Windows system settings and change the time format from "H.mm.ss" to "H:mm:ss".
Success!

Versions: Npgsql: 2.2.0, AspNetCore: 2.2.0

It's a duplicate of #787.

We should probably do a patch release soon...


Avoid warns in clojure 1.11

Clojure 1.11 introduced a update-keys
Without this change, we will see this warn line every time we load the library

WARNING: update-keys already refers to: #'clojure.core/update-keys in namespace: io.aviso.exception, being replaced by: #'io.aviso.exception/update-keys

Can we get a release with this fix merged?

@skynet-gh This is fixed it seems io.aviso/pretty {:mvn/version "1.1.1"}


update for new pymmcore-plus mda

Is it ok to just relying on the old tests for now? I'd like to add more once the mda widgets get a bit cleaned up as discussed in #130

ahh. and all the tests will of course fail bc 0.4.0 doesn't exist

Tests will still fail as remotemmcore does not support mda anymore

@tlambert03 thoughts on what to do about remote in the tests?
Though also looks as though I've indeed broken some tests even for local

Tests will still fail as remote mmcore

yeah, and so now we basically need to give up on it over here too :)  I'm ok with getting rid of the remote parameter in the global_mmcore fixture.

ah this is not ready. I do need to add a basic test (it caught some errors)

Ok tests all passed locally and I added an engine swap to the existing test. Should be good for review once all tests pass here.

note @fdrgsp, this is a breaking API change on the pymmcore-plus side.  After this merges, you will need to have the latest main branch of pymmcore-plus active in your environment.


Stepper module potentially incorrect

The Stepper example has a stepper with two leads -- I'm not sure that exists.  Which types of steppers are to be used with Nanpy, and what does the wiring look like?

Is it meant for something like this?
https://www.pololu.com/product/2980

Nanpy has only a wrapper for Arduino Stepper library:
https://www.arduino.cc/en/Reference/Stepper
Your questions are about Arduino not Nanpy.
So first try to test Stepper without Nanpy, using only Arduino code.

Gotcha, thanks for the response.  I ended up just going with a controller, which has worked perfectly for my needs.


Add option to specify external addresses advertised by legs

Add an option to explicitly set the external addresses advertised as
part of legs messages on gossipsub.
Upgrade legs to fix the bug in supplying DNS addresses.

Infra work here: https://github.com/filecoin-project/lotus-infra/pull/584


Subscription service tests

Added SubscriptionServiceShould tests:

Creation tests
Subscribe on topic test
Activate subscription test
Cancel subscription test

Current coverage is 77.59% (diff: 100%)

Merging #183 into stand-in-memory will increase coverage by 1.16%

@@           stand-in-memory       #183   diff @@
=================================================
  Files                  138        138
  Lines                 5235       5235
  Methods                  0          0
  Messages                 0          0
  Branches               574        574
=================================================
+ Hits                  4001       4062    +61
+ Misses                1125       1063    -62
- Partials               109        110     +1

Powered by Codecov. Last update b6e841c...128f50a

Coverage of SubscriptionService now is 83.56% - everything except catch blocks.

@armiol PTAL and also please see my comment above.

@dmdashenkov please see my comments.

@armiol PTAL
Also, there was a fail from Travis in previous build of PR type. Please, see the build history. It doesn't seem to be caused by these changes, so it might be stand-in-memory issue.

@dmdashenkov LGTM.


Added support for Array[Struct] to GpuCreateArray [databricks]

Added single and double nested struct support to CreateArray in GpuOverrides
Added a getRapidsType method to GpuColumnVector to return nested and non-nested type or throw an IllegalArgumentException if the type isn't yet supported.
Added test to test Array[Struct] and Array[Array[Struct]]

closes #3515

build

CI failing on DB for a seemingly unrelated change.

Looks like something that needs to be fixed.  I'll file a tracking issue for it.

Filed #3703

build

build

build

build


Web components: mega menu Safari lag in responsive desktop resizing

Detailed description

Describe in detail the issue you're having.

The mega menu has a significant lag when resizing the browser on a desktop in Safari.
Screen recording

Is this a feature request (new component, new icon), a bug, or a general
issue?

Bug (?)

Is this issue related to a specific component?

web component mega menu

What did you expect to happen? What happened instead? What would you like to
see changed?

What browser are you working in?

Version 14.0 (156<IP_ADDRESS>.9, 15610)

What version of Carbon for IBM.com are you using?

Canary

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

Steps to reproduce the issue

Open web component mega menu in safari
Scale browser width (while mega menu is open)
Step three
etc.

Additional information

Screenshots or code
Notes

I'm also seeing layout issue between large (1056px) and max (1584px) breakpoints—the forth column starts disappearing
As-is

To-be (as seen in the React version)


Can AttributeFilter match against the actual attribute?

Discussed in https://github.com/saleor/saleor/discussions/9620

Originally posted by heyarne April 25, 2022
When writing queries that work against the list of products stored in Saleor, I noticed that the AttributeFilter in a ProductsQuery matches against the slug form of the attribute's value, not the actual attribute. The query looks like this:
query {
  products(first: 100, channel: "eur", filter: {
    attributes: { slug: "doi", values: ["104171000", "10.4171/000"] }
  }) {
    edges { node { id, name, attributes { attribute { name, slug }, values { name, slug } } } }
  }
}

What is matched against in this case is 104171000, not 10.4171/000. If I remove the second value the result is unchanged, if I remove the first one it is empty.
I found this behavior a bit surprising. Is there a way to match against the attribute's value literally as I stored it?

+2 This is crucial, needs a fix pls


Build failure: osquery-5.12.2

Steps To Reproduce
Steps to reproduce the behavior:
nix build nixpkgs/50d494e5a4370394af0e09db2a2e864f146ff3b6#legacyPackages.x86_64-linux.osquery
Build log
@nix { "action": "setPhase", "phase": "configurePhase" }
Running phase: configurePhase
-- The C compiler identification is unknown
-- The CXX compiler identification is unknown
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - failed
-- Check for working C compiler: /nix/store/pglcybidbkf4pc3fkiqmjspsfr2xs7h5-osquery-toolchain-bin/usr/bin/clang
-- Check for working C compiler: /nix/store/pglcybidbkf4pc3fkiqmjspsfr2xs7h5-osquery-toolchain-bin/usr/bin/clang - broken
CMake Error at /nix/store/aqckch626lg0vxh41dabyzrq0jx7gdk5-cmake-3.29.6/share/cmake-3.29/Modules/CMakeTestCCompiler.cmake:67 (message):
  The C compiler

    "/nix/store/pglcybidbkf4pc3fkiqmjspsfr2xs7h5-osquery-toolchain-bin/usr/bin/clang"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: '/build/source/build/CMakeFiles/CMakeScratch/TryCompile-Z4uLEz'

    Run Build Command(s): /nix/store/4mwzwdhdiqviz9bsb4i8ngy5j04qkvf5-ninja-1.12.1/bin/ninja -v cmTC_8420a
    [1/2] /nix/store/pglcybidbkf4pc3fkiqmjspsfr2xs7h5-osquery-toolchain-bin/usr/bin/clang    -o CMakeFiles/cmTC_8420a.dir/testCCompiler.c.o -c /build/source/build/CMakeFiles/CMakeScratch/TryCompile-Z4uLEz/testCCompiler.c
    FAILED: CMakeFiles/cmTC_8420a.dir/testCCompiler.c.o
    /nix/store/pglcybidbkf4pc3fkiqmjspsfr2xs7h5-osquery-toolchain-bin/usr/bin/clang    -o CMakeFiles/cmTC_8420a.dir/testCCompiler.c.o -c /build/source/build/CMakeFiles/CMakeScratch/TryCompile-Z4uLEz/testCCompiler.c
    Inconsistency detected by ld.so: dl-call-libc-early-init.c: 37: _dl_call_libc_early_init: Assertion `sym != NULL' failed!
    ninja: build stopped: subcommand failed.

Full log: https://gist.github.com/sgrb/671b2b571d6a38c2755372ce38116906
Additional context
Add any other context about the problem here.
Notify maintainers
@znewman01 @nlewo @squalus
Metadata

system: "x86_64-linux"
host os: Linux 6.6.37, NixOS, 24.11 (Vicuna), 24.11.20240708.655a58a
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.18.4
channels(root): ""
channels(slava): ""
nixpkgs: /etc/nix/nixpkgs

Add a :+1: reaction to issues you find important.

Confirmed. I ran a bisect and this was broken by 80be92660e in #307068.


use a separate builder image and deploy in Alpine

What problem does this PR solve?

Small, consistent executable image.
Use the latest golang version which supports go modules.

What is changed and how it works?
Use separate build and deploy images.
Check List

Manually tested only by verifying that pd starts up.
Need to be included in the release notes

It may be possible to use "scratch" instead of Alpine as TiDB does, but I didn't want to bother auditing the repo for usage of Linux utilities.

I should also note that our docker-compose repo has an Alpine Dockerfile for pd.


preflight checks on tools

Hi team , we need a mechanism to check if all the tools required for bootstrap and cluster phase are present in the computer running furyctl.
Today we got stuck because the openvpn tool needed by furyagent was not present.
Maybe a simple command -v target-command can be a solution

Hi team , we need a mechanism to check if all the tools required for bootstrap and cluster phase are present in the computer running furyctl.
Today we got stuck because the openvpn tool needed by furyagent was not present.
Maybe a simple command -v target-command can be a solution

I did this in a Makefile before:
check-%: # detection of required software.
	@which ${*} > /dev/null || (echo '*** Please install `${*}` ***' && exit 1)

is this a duplicate of #30?

I don't think so, that one is for logical preflight, this issue is about cli tools requirements already present on the machine that runs furyctl


Fix the error message. Ask user to create an issue instead of asking them to contact support

The error shown in case of internal server error is like below
something went wrong. contact support

This is an open source project & We have no support team :)
So instead of this error message simply ask user to create an issue in this repository.

Fixed


Remaining compiler warnings in 479fe9c

479fe9c37055ecf8004f4eeb9bcb8dcc7c1e89c5 still results in these warnings (only warnings are shown):  http://dpaste.com/3DWZ4VP
Created with
(git pull)
./autogen.sh
./configure --enable-debug
make &>make.log
agrep -d "^/bin/sh" warning make.log > make-warnings.txt
(uploaded to http://dpaste.com/3DWZ4VP )

ProTip: I used agrep: https://github.com/Wikinaut/agrep because the option "-d" allows to define a "record" which is then printed, if if a match within is found (here: "warning").

@stweil Stefan, hi. I identified some more remaining warnings. See https://github.com/tesseract-ocr/tesseract/issues/138#issue-115242227

@Wikinaut Most of those warnings also occur in my builds and are less interesting (like -Wsign-compare which can be ignored IMHO), but there are also some warnings which need further investigations (-Warray-bounds).

@stweil I informed you, and listed the remaining warnings, because it looked as if you were "hunting" these last (moretheless cosmetic) problems. I really would like to see them disappearing one after the other... :-))


More than one quad for ordered property error

Trying to open https://api.stage.sinopia.io/resource/6a8f7dec-bbca-4a4a-a00c-093445e63258 results in:
Error retrieving https://api.stage.sinopia.io/resource/6a8f7dec-bbca-4a4a-a00c-093445e63258: More than one quad for ordered property http://id.loc.gov/ontologies/bibframe/subject: [object Object],[object Object],[object Object]

I believe the problem is that the resource template was changed to make subject ordered after this resource was created.
I'm going to change so that loads the resource, but considers the triples unused.


Flow: Cannot call this.methodName with arr bound to paramName because read-only array type [1] is incompatible with array type [2].

I am getting Flow: Cannot call this.methodNamewitharrbound toparamName because read-only array type [1] is incompatible with array type [2]. from
<TagInput
    ...
    onChange={(arr) => this.methodName(arr)}
    ^
    ...
    />

I am new in JS/React-Native/Flow. Why this is happening.? and how can i fix the error.

It seems that you're passing a read-only array in a function that expects mutable array as a parameter, which is an error, because otherwise it would be possible to mutate a read-only array in such a function.

Please refrain from asking usage questions here; stackoverflow.com with the flowtype tag is a good resource for that.


Inline - No way to tell the input value changes

Hi guys,
I am passing inline => true and trying to read the value of the input as it changes. Since it is changed by jQuery('#$id').val(e.format()); there is no 'change' or similar event fired.
I had to hack around it like this:
    $('.datepicker-wrapper').on('click', function(e) { // datepicker widget does .val which does not trigger events
        if (!($(e.target).is('.day'))) { // passing '.day' as second arg to .on does not work either because the whole thing gets redrawn
            return;
        }
        setTimeout(function() { // and timeout because click happens faster than the .val
            doThingWithValue($('#datepicker-input').val());
        }, 32);
    });

I think the best solution (besides using ActiveForm, I know) would be to let me pass my own clientEvents['changeDate'] and skip this if I do pass it:
if ($this->inline) {
    $this->clientEvents['changeDate'] = "function (e){ jQuery('#$id').val(e.format());}";
}

Let me know if you want a pull request.
Mike

I do not see anything wrong by you having to write the javascript code to get the value as its changed/clicked on the inline way.  In fact, is exactly how I would probably do it.

The issue is that the input value changes without triggering a change event so it requires a really hacky approach (listening for the click that causes the change + a timeout). But since you don't see anything wrong with that, we don't have anything to discuss further :)


regression: sharp drop in performance under a certain circumstances

In regression,  when  standard deviation of  target value is more than 10,000,  there is  a sharp drop in performance.
The code  below,  show that origin  y in [-500, 500] mostly,  multiply by 1000 and y is in [-500k, 500k]. You will find origin predict value of lightgbm is in [-500, 500],  but it is in [-50k, 50k] after multiplying.
I would like to know why and how to deal with it.
code:
`
from lightgbm import LGBMRegressor
from sklearn.datasets import make_regression
from sklearn.model_selection import train_test_split
from sklearn.metrics import mean_squared_error
import pandas as pd
import numpy as np
import matplotlib.pyplot as plt
x, y = make_regression(n_samples=5000, n_features=10, random_state=2018)
y *= 1000
X_train, X_test, y_train, y_test = train_test_split(x, y, test_size=0.1, random_state=2018)
params = {
'max_depth': 50,
'task': 'train',
'boosting_type': 'gbdt',
'objective': 'regression',
'metric': {'l2'},
'num_leaves': 20,
'min_data_in_leaf': 50,
'learning_rate': 0.2,
"n_estimators": 100,
}
lgb_model = LGBMRegressor(**params)
lgb_model.fit(X=X_train, y=y_train)
lgb_pred = lgb_model.predict(X=X_test)
mse = mean_squared_error(y_test, lgb_pred)
print(np.sqrt(mse))
real = y_test.reshape(-1, )
result = pd.DataFrame(np.stack([lgb_pred, real], axis=1), columns=["pred", "real"])
result.plot()
plt.show()
`
origin y:

y *1000:

This may be related to the issue I had: https://github.com/Microsoft/LightGBM/issues/1278 (I believe it's the large regression numbers that cause a problem, rather than the standard deviation of the target)

@kylelee82  Not because of  large regression numbers, you can add 1 million to y,  the performance will not drop. In a addition, XGB will  perform much better  with  similar  hyper-parameters.

@luobotaxinghu num_leaves=20 with max_depth=50 ?
It is because by large regression target. LightGBM will limit the max tree output to 100 (https://github.com/Microsoft/LightGBM/blob/master/include/LightGBM/tree.h#L14), as a result, for large regression target, it needs much more trees to convergence. You can change 100 to larger number or set reg_sqrt=True. However, large regression target is always not recommended.
LightGBM will start the training from the average label, as a result, it still can learn well when you add 1 million to the labels.

@guolinke Thank you.


Doesn't appear to work with subcommands

class_after is working nicely on top-level commands, but we also utilise thor subcommands and I noticed that the hollaback callback doesn't fire after running them. We're using thor-hollaback v0.2.1.

Thanks for the report! I'll take a look.

@ohookins I'm testing this with v0.2.1 and it appears to be working. Here's the script I'm testing with:
require "bundler/setup"
require "thor"
require "thor/hollaback"

class ChildCLI < Thor
  class_before { puts "Hello from child class" }
  class_after { puts "Goodbye from child class" }
  class_around :around

  desc "child", "Child command"
  before { puts "Hello from child" }
  after { puts "Goodbye from child" }
  def child
    puts "Child"
  end

  no_commands do
    def around
      puts "Around from child start"
      yield
      puts "Around from child end"
    end
  end
end

class ParentCLI < Thor
  class_before { puts "Hello from parent class" }
  class_after { puts "Goodbye from parent class" }
  class_around :around

  desc "parent", "Parent command"
  before { puts "Hello from parent" }
  after { puts "Goodbye from parent" }
  subcommand "parent", ChildCLI

  no_commands do
    def around
      puts "Around from parent start"
      yield
      puts "Around from parent end"
    end
  end
end

ParentCLI.start(ARGV)

and then I'm running:
ruby test.rb parent child

which results in
Around from parent start
Hello from parent
Hello from parent class
Around from child start
Hello from child
Hello from child class
Child
Goodbye from child
Goodbye from child class
Around from child end
Goodbye from parent
Goodbye from parent class
Around from parent end

Can you put a reproduction in here? I'm going to go ahead and close it but if you have something I can test I'll reopen.


Added the address field for the coin json.

Returning the address of the coin as part of json (besides scriptPubKey) has some useful uses and some others like coinprism and blockcypher implement it, too.
This request include changes for P2PKH and P2SH. Please merge it, if you see it appropriate.

my main problem with it is that for developers relying on a full hex ScriptPubKey is more useful than an address. Presenting an address only make sense for a user interface.

Thank you for expressing your views on this. I look at it, as I want this address output to use it and I wish how good would it be to have that. Anyway thank you for your large contributions to .Net Bitcoin space.

Thanks! what framework are you using ? normally using the hex in frameworks is EASIER for a programmer than an address.

We are using QBit.Ninja output in 2 places .Net Framework and iPhone. The request for addition of address is for iPhone.

can you tell me what framework they are using ? If the framework don't support Script as hex it is problematic. Most likely I would say the iPhone devs are not used to bitcoin yet and thinks everything is an address so they did not think about using ScriptPubKey instead.

It seems QBit.Ninja API will be consumed by javascript on iPhone, although it is still under development.

So they use bitcore : https://bitcore.io/api/lib/script (part Script Parsing and Identification)

Thanks you very much.


STORM-959:remove unnecessary dependency from storm-hive/pom.xml

org.apache.calcite:calcite-core:0.9.2-incubating does not take affect at all.

@harshach
Could you please have a look at this PR?

duplicates #609

@caofangkun
I can see "nexus.codehaus.org" is unreachable. I merged your PR to my forked repo and started Travis CI build.
https://travis-ci.org/HeartSaVioR/storm/builds/74997515
We can see if it helps.

There're some issues regarding using SNAPSHOT version of dependencies.

Tez: https://issues.apache.org/jira/browse/HIVE-8845
Calcite: https://issues.apache.org/jira/browse/HIVE-8873

Since it is fixed at 1.0.0, we'd be better to upgrade Hive version, not excluding artifacts.
I didn't have time to use Hive, but normally 1.x.y feels more stable compared to 0.x.y. ;)
@harshach @ptgoetz @revans2
Could you verify storm-hive can work with recent version of Apache Hive, 1.2.1? Thanks!

I'm sorry, but it would be better to discuss it from #609 since this PR is duplicated and it contains same patch.
@caofangkun
Could you close this PR and relevant issue as duplicated? Thanks!


Update azuredeploy.json with latest api version

Update azuredeploy.json with latest api version

@cloudmelon , the API versions that have been added to the templates are not supported on AzureStack yet. Were you intending to update them on the "Azure-QuickStart-Templates" repo?

Hello Krishna,
Thank you very much for your information, it was a great point. Actually,
the reason why I request change is because I found this template in Azure
stack repository is not exactly conform with the best practice of ARM
template, there are a lot of minor points such as :
use https for the schema element, use variables for location, or fill the
parametter.json file etc. Regarding the incompatibility of api version
Azure stack, I usually use the following commands to check the api version
:
((Get-AzureRmResourceProvider -ProviderNamespace
Microsoft.Network).ResourceTypes | Where-Object ResourceTypeName -eq
virtualNetworks).ApiVersions
((Get-AzureRmResourceProvider -ProviderNamespace
Microsoft.Compute).ResourceTypes | Where-Object ResourceTypeName -eq
availabilitySets).ApiVersions
Could you please share me with a working Azure powershell command to check
the latest api version in Azure Stack ? I'll take a look at the similar arm
template in Azure quick start repository, thanks :)
Melony
On Fri, Jun 29, 2018 at 8:29 AM, Krishna Nithin<EMAIL_ADDRESS>wrote:

@cloudmelon https://github.com/cloudmelon , the API versions that have
been added to the templates are not supported on AzureStack yet. Were you
intending to update them on the "Azure-QuickStart-Templates" repo?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Azure/AzureStack-QuickStart-Templates/pull/354#issuecomment-401260855,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEaE-L1KZzOlhUs6wp2_jUGkQUJn0Hgwks5uBclagaJpZM4U7VGJ
.