Could not find a matching version of package generate-migrations-hook. Check the package spelling, your version constraint and that the package is available in a stability which matches your minimum-stability (dev)

InvalidArgumentException  : Could not find a matching version of package generate-migrations-hook. Check the package spelling, your version constraint and that the package is available in a stability which matches your minimum-stability (dev).
at C:\laragon\www\iamhairsalon\vendor\composer\composer\src\Composer\Command\InitCommand.php:759
755|                     implode("\n    ", $similar)
756|                 ));
757|             }
758|

759|             throw new \InvalidArgumentException(sprintf(
760|                 'Could not find a matching version of package %s. Check the package spelling, your version constraint and that the package is available in a stability which matches your minimum-stability (%s).',
761|                 $name,
762|                 $this->getMinimumStability($input)
763|             ));

Exception trace:
1   Composer\Command\InitCommand::findBestVersionAndNameForPackage(Object(Symfony\Component\Console\Input\ArrayInput), "generate-migrations-hook", "7.1.20", "stable")
C:\laragon\www\iamhairsalon\vendor\composer\composer\src\Composer\Command\InitCommand.php:401
2   Composer\Command\InitCommand::determineRequirements(Object(Symfony\Component\Console\Input\ArrayInput), Object(Larapack\Hooks\RawOutput), "7.1.20", "stable")
C:\laragon\www\iamhairsalon\vendor\composer\composer\src\Composer\Command\RequireCommand.php:136
Please use the argument -v to see more details.

InvalidArgumentException : Could not find a matching version of package generate-migrations-hook. Check the package spelling, your version constraint and that the package is available in a stability which matches your minimum-stability (dev).
at C:\laragon\www\iamhairsalon\vendor\composer\composer\src\Composer\Command\InitCommand.php:759
755| implode("\n ", $similar)
756| ));
757| }
758|

759|             throw new \InvalidArgumentException(sprintf(
760|                 'Could not find a matching version of package %s. Check the package spelling, your version constraint and that the package is available in a stability which matches your minimum-stability (%s).',
761|                 $name,
762|                 $this->getMinimumStability($input)
763|             ));

Exception trace:
1 Composer\Command\InitCommand::findBestVersionAndNameForPackage(Object(Symfony\Component\Console\Input\ArrayInput), "generate-migrations-hook", "7.1.20", "stable")
C:\laragon\www\iamhairsalon\vendor\composer\composer\src\Composer\Command\InitCommand.php:401
2 Composer\Command\InitCommand::determineRequirements(Object(Symfony\Component\Console\Input\ArrayInput), Object(Larapack\Hooks\RawOutput), "7.1.20", "stable")
C:\laragon\www\iamhairsalon\vendor\composer\composer\src\Composer\Command\RequireCommand.php:136
Please use the argument -v to see more details.

The error was caused because i tried to install the hook prior to installing voyager (php artisan voyager:install).


Add millis methods to DateClientParam

Addresses issue #1798

Yes—thanks for pointing me to the test code. Added checks for the new millis functions.

Thanks David! This is great, merging now.


fix(helm): add --devel flag to allow dev releases again

2.4.0 stopped installing development versions by default. This allows
the user to re-enable that support by setting --devel.
Closes #2407

I put this on a patch branch because this appears to be causing headaches for production users.

need to generate docs


Fix propType tests for latest React (v15.2.0)

React 15.2.0 changed the propType validation warning text:
https://github.com/facebook/react/blob/master/CHANGELOG.md#1520-july-1-2
016
This PR adapts the assertion to work for both versions of the warning text.

Thanks!


Adds Maven coordinates to README

The README still contains Java examples, but is missing what most Java projects would use: Maven coordinates. This PR adds that.
Note that something about the README (or the lack of an actual pom.xml file perhaps) confuses GitHub's Dependency graph page. Here https://github.com/nielsgron/quicksilver/network/dependencies it detects for com.squareup.okhttp3:okhttp the repository https://github.com/lizhangqu/PriorityOkHttp . It would be good to see with GitHub how to make this the canonical repository for OkHttp on Maven.

PS: I contacted GitHub and they manually linked the com.squareup.okhttp3:okhttp dependency as shown with their Dependency graph page with this repository.

Java projects use Gradle. I think I would rather just show the coordinates and let the user figure out what to do for their build system. This is what we did for Retrofit: https://github.com/square/retrofit#download

I've updates the PR. Just mentioning Maven and the coordinates instead of the Kotlin/Gradle line would also do.

OK, I'm linking to Maven Central now and mention the 4.2.2 release in the README (there was 4.2.1 before).


Update and verify the code links to our storybook etc from the web site

eg https://pages.github.ibm.com/syd/pal-1/components/page-header/code contains a link with an old URL (cloud-cognitive) and an old story name which no longer exists.

The first columns of the tables listing out the assets contain a mix of; links to design assets on the site, CarbonDesignSystem.com and links to coded assets in storybook. Not sure what they should be.

Addressed in https://github.ibm.com/CDAI-design/pal/pull/881


button-hover & year_header

Adjest the size of header for mobile ,
download button feel hover and click
add year_header that show year clearly

before

now

@ahsan-abc Hey, Thanks for looking into it. Did you read the Contribution Guide !. Your changes are awesome, but it will be great if you write your css codes inside scss file and then compile them, not directly to css file.

fine , ok i  will


net/http: use top-level font media type in sniffer

RFC 8081 declares a top level font media type for all types of fonts.
The same has been incorporated in https://github.com/whatwg/mimesniff/issues/23. Should we move too ?
The changes would require updating the following mime types -

Obsolete
New

application/font-ttf
font/ttf

application/font-cff
font/collection

application/font-off
font/otf

application/font-sfnt
font/sfnt

application/font-woff
font/woff

application/font-woff2
font/woff2

/cc @bradfitz

Sure. If it doesn't break any browser's font parsing, but from that other bug it sounds like it doesn't.


feat: ADDON-65006 add group name to URL when redirecting with Menu

ADDON-65006
The value of input is taken from groupName field of globalConfig (if present).
The menu itself (for reference):

Click on S3 Access Logs -> SQS-Based S3 opens the URL with populated input query:

For a root-level menu item the input value is not populated:

the input value provided by custom component by calling navigator function takes precedence.
Related PR: splunk/splunk-add-on-for-amazon-web-services#1053

:tada: This PR is included in version 1.31.0 :tada:
The release is available on:

v1.31.0
GitHub release

Your semantic-release bot :package::rocket:


Change demo page for battery status API

Previous demo site only supports the outdated spec version.
New demo site supports both current and outdated spec version, and therefore works with Chrome.

Thanks!


Added the Classy Llama blog

Lots of good dev content on there :) also alphabetized the company blog list

Hi David, thanks for your contribution!


Cleanup

Current coverage is 100% (diff: 100%)

Merging #17 into master will not change coverage

@@           master   #17   diff @@
===================================
  Files           2     2
  Lines          32    32
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
  Hits           32    32
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update 0a74fb8...36e97ca


Que : does it have perform_all?

When you are testing various jobs in Rspec is there something that can execute the jobs inside the queue similar to ResqueSpec.perform_all(queue_name)?   We have found the rspec-quelibrary but it appears to be missing this functionality too.
Thoughts?
References
https://github.com/leshill/resque_spec
https://github.com/gocardless/rspec-que

Going through old issues. There's not a perform_all-type method, the general testing strategy is to let jobs be persisted to the DB and then assert on their presence in tests. You can optionally also set jobs to run as they are queued - this is Que.mode = :sync in 0.x and Que.run_synchronously = true in 1.0.


bug: peer management of subscriptions is questionable

This is a bug report
Problem
Filter subscription's peer management is not ideal so that ping has no peers to use because this.getPeers returns empty array, probably, due to previous renewals.
But at the same time subscription is functioning so that all previously used peers are still returning messages.

Proposed Solutions
This issue requires investigation.
Once renewal has happened - previously used peer should not be used and has to be removed properly.

Figured the bug. This issue happens due to how renewal logic works: https://github.com/waku-org/js-waku/blob/b2efce5ec27807325685cc32f9333805e6321ac7/packages/sdk/src/reliability_monitor/receiver.ts#L172
During renewal - we add new peer and create a subscription to it without unsubscribing from previous peer AND without disconnecting.
At the same time libp2p still awaits for filter-push here https://github.com/waku-org/js-waku/blob/b2efce5ec27807325685cc32f9333805e6321ac7/packages/core/src/lib/filter/index.ts#L45
And once previously "used" peer pushes messages to js-waku - it successfully receives it.
For now it is not a critical bug for functionality of Filter but it definitely is not expected behavior.
Fix:

unsubscribe on renewal
potentially drop connections to renewed peers

Blocked by https://github.com/waku-org/js-waku/issues/2158 and potentially https://github.com/waku-org/js-waku/issues/1969 (as we need to improve connection management before).


Hololens 2 Socket IO connection not working

Currently I'm working on an application for the Hololens 2.
I created a small NodeJS server which watches a folder for new added files. This server then sends with Socket IO this data to the Unity client. This works perfectly in the editor. However, When I have a build on my Hololens 2. The application doesn't want to connect to my pc.

I made sure I'm on the same network.
I enabled all build settings capabilities

Steps to reproduce:

Create a simple server with the Socket IO installed
Create a Unity client that connects to this server.
Make sure all capabilities are toggled in build settings
Build the Unity application to the UWP hololens 2
socket.Connected shows false when app launched on hololens UWP.

Do you know what might cause this issue or how I can solve it?
many thanks

Hello ThimoDev,
Have you tried using http pool transport instead of websocket and setting AutoUpgrade to false (AutoUpgrade default value is true If websocket is available, it will be automatically upgrade to use websocket)
see:
https://github.com/doghappy/socket.io-client-csharp#options
https://stackoverflow.com/a/40805832
Hope this is helpful.

I found out there was a problem in our offices network security. After disabling that it worked. Thank you for all your help!


Locking is not exclusive when two threads request for a lock at a very close interval

We are using py-filelock 3.0.12 and have experienced a problem when multiple threads are trying to acquire the lock on the same file at almost the same time. This happens quite often in our AWS EC2 instance and causes data corruption. We are just following the examples in the documentation to use the module. Is there any way to avoid this?

Do you have the same problem with a local computer or did you observe that only in EC2?

Do you have the same problem with a local computer or did you observe that only in EC2?

I tried it locally and it seems to work, although my setup on EC2 is hard to simulate. I wrote a multi-threading program to test it and it works on Windows 10.

I tried it locally and it seems to work, although my setup on EC2 is hard to simulate. I wrote a multi-threading program to test it and it works on Windows 10.

Your EC2 is Linux or windows based? Because it's not the same api between
POSIX and Windows.
On Thu, Jan 14, 2021, 00:51 fhcat<EMAIL_ADDRESS>wrote:

I tried it locally and it seems to work, although my setup on EC2 is hard
to simulate. I wrote a multi-threading program to test it and it works on
Windows 10.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/benediktschmitt/py-filelock/issues/81#issuecomment-759578614,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAWX4PIWBY2TRTGJWGMB5UDSZXFQRANCNFSM4VBWPU4Q
.

Your EC2 is Linux or windows based? Because it's not the same api between
POSIX and Windows.
On Thu, Jan 14, 2021, 00:51 fhcat<EMAIL_ADDRESS>wrote:

I tried it locally and it seems to work, although my setup on EC2 is hard
to simulate. I wrote a multi-threading program to test it and it works on
Windows 10.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/benediktschmitt/py-filelock/issues/81#issuecomment-759578614,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAWX4PIWBY2TRTGJWGMB5UDSZXFQRANCNFSM4VBWPU4Q
.

Hello, if you make a PR for this (with tests) we would be happy to review it, thanks!

I'm closing this for lack of feedback, however, if you can provide more information we can reopen it.


Windows adding RPC

I read all issues if I could find anything about this error:
neo> dotnet neo-cli.dll /rpc
error
It just give back an error in windows. Nothing else. Does anyone have a solution or is there an error log somewhere?
Added: Or is this not needed in windows to do this? And/or do I have to run a fully in sync wallet in order to use rpc or to get access to rpc? Because currently I try to reach it trough my browser and that doesn't work.

You need to add /rpc when you start neo-cli:
dotnet neo-cli.dll /rpc

Not in the neo-cli itself:
neo>

I figured it out like this:
"C:\Program Files\neo-cli\neo-cli.exe" /rpc


generated/options-db.xml parse error

Issue description
I don't really know what to say about this other than I'm trying to upgrade from the latest (git) nixpkgs.
generated/options-db.xml:35760: parser error : Opening and ending tag mismatch: literal line 35758 and para
</para><para>
       ^
generated/options-db.xml:35766: parser error : Opening and ending tag mismatch: literal line 35758 and listitem
            </filename></member></simplelist></listitem></varlistentry><varliste
                                                        ^
generated/options-db.xml:35766: parser error : Opening and ending tag mismatch: para line 35755 and varlistentry
            </filename></member></simplelist></listitem></varlistentry><varliste
                                                                       ^
generated/options-db.xml:49422: parser error : Opening and ending tag mismatch: listitem line 35755 and variablelist
      </filename></member></simplelist></listitem></varlistentry></variablelist>
                                                                               ^
generated/options-db.xml:49422: parser error : Opening and ending tag mismatch: varlistentry line 35755 and appendix
lename></member></simplelist></listitem></varlistentry></variablelist></appendix
                                                                               ^
generated/options-db.xml:49424: parser error : Premature end of data in tag variablelist line 3

^
generated/options-db.xml:49424: parser error : Premature end of data in tag appendix line 3

^
./manual.xml:45: element include: XInclude error : could not load generated/options-db.xml, and no fallback was found
builder for '/nix/store/rqiil2vr3wiw14l2wbg3bjgy1frbwj83-nixos-manual-combined.drv' failed with exit code 1
cannot build derivation '/nix/store/kzkdz6dyqhyjgya0v8sidc2imlvyk7is-nixos-manpages.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/gx7im2zwc4js7dgzga0185n3pci8h2xq-nixos-manual.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/7j95jczdp99d5kh41a7j7ngbhfi2fzmk-system-path.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/qlfab3sxync1nvnn47ygsv08mlbk7vg6-nixos-system-okinan-18.09.git.656dc51.drv': 1 dependencies couldn't be built
error: build of '/nix/store/qlfab3sxync1nvnn47ygsv08mlbk7vg6-nixos-system-okinan-18.09.git.656dc51.drv' failed

Steps to reproduce
Download latest (git) nixpkgs, attempt to upgrade from that.
Technical details

system: "x86_64-linux"
host os: Linux 4.17.2, NixOS, 18.09.git.a73a941 (Jellyfish)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.0.4
channels(root): "nixos, nixpkgs-18.09pre143801.5ac6ab091a4"
warning: Nix search path entry '/home/okina/.nix-defexpr/channels' does not exist, ignoring
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Problem went away with the latest nixpkgs lol. ¯_(ツ)_/¯

@Chiiruno If it occurs again, I ended up working around it temporarily by setting services.nixosManual.enable = false;


Prevents rand_from_seed from exceeding RANDOM_MAX

Even though the seed being returned had the most significant bit killed by & masking with Math::RANDOM_MAX, the value was already set in memory. Thus, calls that don't use the return value of the function (which is completely sane behavior, given that the function sets the pointer) can get a number larger than RANDOM_MAX.

That will conflict with #6751, so CC @SuperUserNameMan. Please see together what should be merged first :)

Yeah, no, there's something going on there that I don't grasp. I thought I'd killed this pull request. This is a no go.

what bother me with the idea of fixing the current PRNG of Godot, is that we don't know its characteristics.
Maybe is it a standard and well known algorithm ?
:-/

I found out where the algorithm is from. Here is a possible origin, and reference to possible original implementation.
In any case, even the fast implementation is slower than xorshift32: xorshift32 does 3 xors and 3 shifts, and the current algorithm (2 subtractions, an integer division, 2 multiplications, and a branch).
I'd go with xorshift32 on those grounds alone.


Cleanup of caps

[ ] Public API changes documented in changelogs (optional)

Signed-off-by:

TODO: should be added on top of https://github.com/matrix-org/matrix-rust-sdk/pull/2465.

It is now part of: https://github.com/matrix-org/matrix-rust-sdk/pull/2475
And merged.


key and region parameters not properly documented in spx CLI

@key and @region config are not working properly in Windows nor Ubuntu CLI. Documentation and cli help suggest @region --set and @key --set but none work, luckily appending this at the end works: --key 7a4fxyz --region westeurope. Please update doc and help pages
I have pasted below session details, windows 11 22000.194, dotnet 3.1.413 and CLI 1.18.0
PS C:\Users\x> dotnet --version
3.1.413
PS C:\Users\x> spx config @key --set 7a4fxyz
SPX - Azure Speech CLI, Version 1.18.0
Copyright (c) 2020 Microsoft Corporation. All Rights Reserved.
"--set 7a4fxyz" is invalid; missing @file, name, or value
PS C:\Users\x> spx config @region --set westeurope
SPX - Azure Speech CLI, Version 1.18.0
Copyright (c) 2020 Microsoft Corporation. All Rights Reserved.
"--set westeurope" is invalid; missing @file, name, or value
PS C:\Users\x> spx translate --microphone --source en-US --target es-ES --key 7a4fxyz --region westeurope
SPX - Azure Speech CLI, Version 1.18.0
Copyright (c) 2020 Microsoft Corporation. All Rights Reserved.
audio.input.type=microphone
source.language.config=en-US
target.language.config=es-ES
x.command=translate
SESSION STARTED: 8316xyz
Listening; press ENTER to stop ...
Connection CONNECTED...
TRANSLATING into 'es': Hola (from 'Hello')
--
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 91e2ab62-8804-694f-f51a-ab5cef82c2d6
Version Independent ID: 3eac47ce-d629-6a1f-914b-ce60ab13ebae
Content: Speech CLI quickstart - Speech service - Azure Cognitive Services
Content Source: articles/cognitive-services/Speech-Service/spx-basics.md
Service: cognitive-services
Sub-service: speech-service
GitHub Login: @PatrickFarley
Microsoft Alias: pafarley

@ignaciofls Thanks for the feedback! We will review and update accordingly.

@PatrickFarley Could you please help with the document update for Create subscription config.

@PatrickFarley what is the status here? I believe the bug is still there

#reassign:eric-urban

@ignaciofls - Thanks for reporting this issue! We have updated documentation e.g., Create subscription config.

#please-close


Add package signing to the Create Release sequence AB#288 AB#289 AB#290

add "Create PFX certificate for AppxBundle" step
add signing parameters to the "Build and generate bundles" step
set all steps' attributes into proper order, according to our code conventions
made the SonarCloud steps more readable

@kulov  Pipeline fails, because we are currently not handling the Base64 secret on PR.
Created a task to discuss tomorrow.


Crash with wrong topic type

I get the following error: [ERROR] [1597284029.114291]: [Client 0] [id: subscribe:/tf:6] subscribe: Tried to register topic /tf with type tf2_msgs/TFMessage but it is already established with type tf/tfMessage and jupyter-lab subsequently crashes.

Related: where can I find the config files to remove the tf topic for now?

Related to the error, I need more information to dig into.
To start rosmaster, the extension launches a launch file with:
<launch>
  <node name="rosapi" pkg="rosapi" type="rosapi_node" />
  <node pkg="tf2_web_republisher" type="tf2_web_republisher" name="tf2_web_republisher" />
</launch>

From settings, you can change this file adding the path to your own, but you need to keep the rosapi node otherwise Zethus won't work. In addition, if you don't runtf2_web_republisher Zethus will complain getting the following error:
[ERROR] [1597491469.362135]: [Client 0] [id: subscribe:/tf:7] subscribe: Cannot infer topic type for topic /tf as it is not yet advertised
[ERROR] [1597491469.370366]: [Client 0] [id: subscribe:/tf_static:8] subscribe: Cannot infer topic type for topic /tf_static as it is not yet advertised


[$1000] Inconsistency while selecting dropdown in mWeb and Android

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app in Android
Navigate to Settings > Workspaces > Select any workspace
Reimburse expenses
Click on Unit Input
Do the exact same steps for mWeb
Notice that the dropdown input's border gets green when focused in mWeb but in Android this only happens when we click on the input

Expected Result:
Behavior should be consistent.
Actual Result:
The behavior of the field isn't consistent
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.2.76-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/221579483-aab7a1f8-0181-42b6-bf90-6465848868e0.mp4
https://user-images.githubusercontent.com/43996225/221579538-8a836cfc-a657-46ec-9789-d6896fb08e91.mp4
Expensify/Expensify Issue URL:
Issue reported by: @daraksha-dk
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1677253047142869
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010c6b32476cf961bc
Upwork Job ID:<PHONE_NUMBER>411161088
Last Price Increase: 2023-03-02

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Reproducible.

Job added to Upwork: https://www.upwork.com/jobs/~010c6b32476cf961bc

Current assignee @arielgreen is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

Triggered auto assignment to @marcaaron (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Same issue here.

Proposal
Please re-state the problem that we are trying to solve in this issue.
When opening the Picker, there is an inconsistent behaviour between the green bottom border indicator on mobile web and mobile native.
What is the root cause of that problem?
The events that trigger the border to change are not applicable to both platforms (see here).  onClose does not support mobile web, and the events that do target mobile web are implemented as onFocus and onBlur.  Neither of those happen when selecting a picker item.
What changes do you think we should make in order to solve the problem?
We have to add additional events that will create the same behavior on mobile web to disable the green border when a picker item is selected.  After making the changes it works:
https://user-images.githubusercontent.com/1311325/222307120-e92559c0-ae60-4e0e-80ba-f8cb7be1d9e3.mp4
What alternative solutions did you explore? (Optional)

Ah, is it me or is it debatable which behavior is correct? The proposal sounds good though I am unsure which is the preferred direction to go here.
Would making a selection not return the focus to the field itself? Can native match the behavior that mobile web has?
Curious to get @shawnborton's take here. I think we can hire @redstar504 for this one. Though - I would like to get some consensus on the correct behavior first if we can.

📣 @redstar504 You have been assigned to this job by @marcaaron!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

@marcaaron Thank you.  I debated that as while when digging into this.  The existing logic seemed to lean towards changing the colour back when the picker is closed.  I am not sure it provides any benefit to the user to keep the field highlighted after they have chosen an option and moved on.

Yeah, this is an interesting one. I think I agree with @redstar504's proposal though to remove the "focus" feeling after something is picked.

Ok cool sounds good to me. Let's go with the O.G. proposal. Thanks all.

@thesahindia @daraksha-dk @redstar504
offers sent in Upwork

@redstar504, @marcaaron, @arielgreen, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

Solution is on staging now - just waiting for it to hit production.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.85-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/15673

If no regressions arise, payment will be issued on 2023-03-23. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@thesahindia / @marcaaron] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@thesahindia / @marcaaron] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@thesahindia / @marcaaron] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@arielgreen] Determine if we should create a regression test for the bug.
[ ] [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to the appropriate location to ensure the same bug will not reach production again.
[ ] [@arielgreen] Review the proposed regression test steps and location.
[ ] [@arielgreen] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Looks like something related to react-navigation may have been mentioned in this issue discussion.
As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.
Feel free to drop a note in #expensify-open-source with any questions.

@marcaaron @thesahindia please see and complete checklist

It wasn't a regression so we can skip the first three items.

👍

Excellent, we are good to close then.


(serveStatic plugin) Do not leak file descriptors and always call next()

Fixes https://github.com/restify/plugins/issues/42

@DonutEspresso Any ETA as to when you can take a look at this? (It has already been almost a week.) This is a fairly critical security fix.

LGTM thanks for the fix!

@micahr Any chance you could publish a new package on NPM?

Sure

Version 1.0.3 has been published. Thanks again for your fix!

@koute apologies for not getting to this earlier. Thanks again for the contrib - much appreciated!


Revert "Add swift-crypto dependency"

Reverting apple/swift-package-manager#3202, for it's causing build issues downstream.
Jenkins URL: https://ci.swift.org/job/oss-swift-package-macos/5567

fatal error: module map file '/Users/buildnode/jenkins/workspace/oss-swift-package-macos/build/buildbot_osx/swiftpm-macosx-x86_64/apple/Intermediates.noindex/GeneratedModuleMaps/macosx/CCryptoBoringSSL.modulemap' not found

@swift-ci please smoke test

https://github.com/apple/swift-package-manager/pull/3247 fixes the issue, so this is no longer needed.


how do you get this to run using linux terminal?

I'm trying to get my friend to be able to run this so we can play stuff together, but i can't figure out how to run this in a chromeos terminal. I can try to use ./phantom-linux, but it doesn't find the command still. Neither does just typing phantom-linux do anything. I know this is improper usage and you need to supply parameters to do anything useful, but i don't even get a proper error message. How do?

Mine works but it doesnet start a connection with the server I'm trying to get to

chmod +x phantom-linux


Rust Analyzer weird behavior?

Describe the bug
When I open the rust folder in VSCode (the project was generated by flutter_rust_bridge), in many cases I have no autocompletion from rust analyzer. Maybe this bug is related to somewhere else, but right now its really annoying working without any autocomplete.
VSCode output displays nothing, the same behavior after restarting my rust analyzer server.
Here is my simple.rs file:
use std::sync::{Mutex, OnceLock, RwLock};

static COUNTER: OnceLock<RwLock<i32>> = OnceLock::new();

#[flutter_rust_bridge::frb(sync)] // Synchronous mode for simplicity of the demo
pub fn greet(name: String) -> String {
    format!("Hello, {name}!")
}

#[flutter_rust_bridge::frb(sync)]
pub fn get_counter() -> i32 {
    let locked = COUNTER.get().unwrap();
    *locked.read().unwrap()
}

#[flutter_rust_bridge::frb(sync)]
pub fn increment() {
    let mut counter = COUNTER.get().unwrap();
    let mut c = counter.write().unwrap();
    *c += 1;

    let one: OnceLock<i32> = OnceLock::new();
    let m = Mutex::new(0);
}

#[flutter_rust_bridge::frb(init)]
pub fn init_app() {
    // Default utilities - feel free to customize
    flutter_rust_bridge::setup_default_user_utils();
    COUNTER.set(RwLock::new(0)).unwrap();
}

Working with the COUNTER static no autocomplete, if I create for example a mutex inside a function, no autocomplete for that at all.
Do you have any advice?
Steps to reproduce
Hint: A simple way to reproduce is to clone and modify the https://github.com/fzyzcjy/flutter_rust_bridge/tree/master/frb_example/dart_minimal example package according to your needs.

...
...
...

Logs
I have no error at all.

Expected behavior
No response
Generated binding code
No response
OS
No response
Version of flutter_rust_bridge_codegen
No response
Flutter info
No response
Version of clang++
No response
Additional context
No response

If I remove the frb macro, everything works.
#[flutter_rust_bridge::frb(sync)]
Do you have any advice how to solve this issue?

If I remove the frb macro, everything works.

One way may be somehow improve this proc macro. Since there is an ongoing PR related to this part https://github.com/fzyzcjy/flutter_rust_bridge/pull/1676, maybe cc @Desdaemon - what do you think?
Btw, have you seen any macros (except for builtin ones) like such #[...], which makes your Rust analyzer still works well? If so, we can follow their best practices.
Another way may be add support for some comment-based syntax, like /// frb: sync (similar to cbindgen's way IIRC).

Yeah #1676 would fix this issue, since span info is currently being tossed out when unparsing a TokenStream.

@Desdaemon That looks great! I edited the comment to link to this

Thank you for your super fast response. For now it seems to me a tiny workaround solves this issue:
fn _get_counter() -> i32 {
    *COUNTER.get().unwrap().read().unwrap()
}

#[flutter_rust_bridge::frb(sync)]
pub fn get_counter() -> i32 {
    _get_counter()
}

If I remove the frb macro, everything works.

One way may be somehow improve this proc macro. Since there is an ongoing PR related to this part #1676, maybe cc @Desdaemon - what do you think?
Btw, have you seen any macros (except for builtin ones) like such #[...], which makes your Rust analyzer still works well? If so, we can follow their best practices.
Another way may be add support for some comment-based syntax, like /// frb: sync (similar to cbindgen's way IIRC).
(This does not look like a bug, since it is known that rust analyzer sometimes gets confused about proc macros, so I relabel it. Feel free to relabel if you think not proper!)

Comment based syntax looks awesome.

The related PR is already merged


Support optional inputs

Note for next me: RootScalarTestCase and some other testcase that uses root scalar with operation variable doesn't work
since up until now we didn't needed to check that root scalars were created in order to update them. but now since they are
cached by args and we need to check that the map contains it to update it is required.
A simple hacky patch would be to only check if the map contains and do not check for emptiness.
A more robust solution would be  to make all of the root types std::optional<...>.


Adding devices is mixed up / LSC devices

Starting with version above 2.0.2 (can't find anything after 2.0.2 on github, like the 2.0.5 currently on test branch) the LSC Smart Power Plug and LSC Smart LED Light Strip have been swapped. Can't add either.

Fixed this, and i have downloaded the latest binaries to github. Homey moved away from Github will keep it updated for the forks.


server leaderboard dropdown and profile dorpdown buttons looks bad if the user don have server to display

Bugreport:
Bug reported by Jecsham
Is it a bugreport for the website or for the bot?: website
What is the title of your bugreport?: server leaderboard dropdown and profile dorpdown buttons looks bad if the user don have server to display
How can you reproduce the bug? (Explain in steps):

Login in https://lenoxbot.com with a account without lenoxbot servers
Use the mentioned buttons
Which result would normally have to be?: A message like "You aren't in a server with lenoxbot"
What happens if you do the action now?: Buttons look bad

ReportID: 67

➤ LenoxBot commented:
Approve:
could be reproduced
Nickkel

➤ LenoxBot commented:
Approve:
could be reproduced
Wandi

➤ LenoxBot commented:
Approve:
reproducible
Denarioyt


Test tree checkbox API

Refs: https://github.com/microsoft/vscode/issues/116141

[x] anyOS @TylerLeonhardt
[ ] anyOS @aeschli

Complexity: 5
Roles: Developer, Engineering Manager
Create Issue

Tree items support an optional checkbox with this API proposal:
https://github.com/microsoft/vscode/blob/0524ecce238fb19b5847a6ddac026775f1e234c1/src/vscode-dts/vscode.proposed.treeItemCheckbox.d.ts#L8-L15
To verify, you'll need to use this checkbox property in a tree view. If you don't have an extension that could benefit from having checkboxes, you can use the tree view sample and add the checkbox property here:
https://github.com/microsoft/vscode-extension-samples/blob/f7b27a91779e770b8f8f0e6791bcefc5d9c64035/tree-view-sample/src/testView.ts#L77-L81
And listen for the checkbox change event on this tree view:
https://github.com/microsoft/vscode-extension-samples/blob/f7b27a91779e770b8f8f0e6791bcefc5d9c64035/tree-view-sample/src/testView.ts#L6-L7
Things to verify:

Verify that by default, if you check the checkbox of a node with children, the children get checked.  Verify that when you check all children, the parent gets checked. Also verify that you see this reflected in the onDidChangeCheckboxState.
Verify that if you set the manuallyManageCheckboxSelection option (https://github.com/microsoft/vscode/blob/0524ecce238fb19b5847a6ddac026775f1e234c1/src/vscode-dts/vscode.proposed.treeItemCheckbox.d.ts#L51-L56) that you do not see the children and parents get automatically checked as described in the previous point.
Verify that the JS Doc comments make sense.
Verify that the checkbox tool tip and accessibility information are applied in the way you'd expect.

Feels really nice! Excited for finalization so I can adopt it completely 😄

@aeschli I was using a tree data provider by setting the checked state on the TreeItem, then firing the did change event. This allowed me to programmatically set an item as checked/unchecked.

I think this should be closed, reopen if I'm wrong

Using a tree data provider and setting the checked state on the TreeItem, then fireing the on did change event is the way to set the checked state programatically.


Improved data upload instructions for PQ SDK Test framework data

Changes:

Added notes for uploading decimal and timestamp values
Changed improvement_surcharge field to be double instead of string type

Was this a mistake in this sample schema file? I'd think that changing the column type in the data set would impact the output files.

Yes, this was a mistake in the schema file. There is no change in the data set type and therefore the output files remain unaffected.


Stix file generated from Instinkt Group's publication

Stix file with Predator IOCs generated based on this publication by Recorded Future https://www.recordedfuture.com/predator-spyware-operators-rebuild-multi-tier-infrastructure-target-mobile-devices

Hi @ditord,
That's great thanks! I think it makes more sense to add it to the predator folder with the other indicators, I'll do that today!

Thanks @ditord for opening the PR. @Te-k has added them in 57b19d7 and they should now be available for MVT users.


Revert fsnotify changes

Reverts changes to remove fsnotify from json log reader.
This caused a slowdown that made TestLogsFollowSlowStdoutConsumer fail on ARM 100% of the time.
benchmark                               old ns/op     new ns/op     delta
BenchmarkJSONFileLogger-8               53205         53077         -0.24%
BenchmarkJSONFileLoggerWithReader-8     93100         56483         -39.33%

benchmark                               old MB/s     new MB/s     speedup
BenchmarkJSONFileLogger-8               68.23        68.39        1.00x
BenchmarkJSONFileLoggerWithReader-8     20.30        33.46        1.65x

benchmark                               old allocs     new allocs     delta
BenchmarkJSONFileLogger-8               30             30             +0.00%
BenchmarkJSONFileLoggerWithReader-8     193            128            -33.68%

benchmark                               old bytes     new bytes     delta
BenchmarkJSONFileLogger-8               960           960           +0.00%
BenchmarkJSONFileLoggerWithReader-8     5753          3857          -32.96%

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "revert_inotify_changes" git@github.com:cpuguy83/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~4
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

ping @LK4D4 @anusha-ragunathan @mountkin

@cpuguy83 can you check if #20605 mitigates the performance issue introduced by #19498 ?
In my test environment #20605 + #19498 is faster than the old approach.
fsnotify:
BenchmarkJSONFileLogger-8          	  200000	     67501 ns/op	  53.78 MB/s	     960 B/op	      30 allocs/op
BenchmarkJSONFileLoggerWithReader-8	  100000	    127740 ns/op	  14.80 MB/s	    5875 B/op	     197 allocs/op

#20605 + #19498
BenchmarkJSONFileLogger-8          	  300000	     57026 ns/op	  63.65 MB/s	     960 B/op	      30 allocs/op
BenchmarkJSONFileLoggerWithReader-8	  100000	    180476 ns/op	  10.47 MB/s	    2043 B/op	      80 allocs/op

BTW, I'm seeing the file poller is leaking a lot of fds on rotation (with the following test command)
docker run -d --name=test --log-opt max-size=50 --log-opt max-file=5 busybox sh -c "sleep 1;yes X|head -c 200"; docker logs -f test

I ran arm tests on your PR and they failed.

Can you help to test if https://github.com/mountkin/docker/tree/jsonlog-with-read-indexes fixed the ARM tests? I haven't got an ARM environment.

I don't have one either, it's just part of CI.

I'll open another PR to see the ARM tests result :smiley:

@mountkin Yeah, I see that we are missing a defer f.Close() in the pollers watch function... will follow-up after this PR if it gets merged.

LGTM.

Actually docker logs -f doesn't work with rotation at all in master("bad file descriptor").

Test passed on arm, I'm merging.
LGTM


[Menu]: clicking options on mobile also triggers events of elements below

🐛 Bug report
When I have a context menu over some element with event handlers, clicking on menu option also triggers events of underlying element. It only reproduces on touch devices, on desktop everything works fine. Probably related to #756
💥 Steps to reproduce

Go to https://2jwv52.csb.app/
Enter the mobile/responsive dev mode (or make sure you have touch mode enabled)
Open context menu via press&hold
Select an option which is located over pink section
Notice how counter is increased

💻 Link to reproduction
CodeSandbox reproduction: https://codesandbox.io/s/zag-js-menu-2jwv52?file=/src/index.js
🧐 Expected behavior
Clicks of underlying element is not triggered (the same as on desktop)
🌍 System information

Software
Version(s)

Zag Version
0.13

Browser
All

Operating System
macOS 13.1

📝 Additional information
I've debug a little in examples/next-ts/pages/context-menu.tsx. I've created almost the same markup as in the sandbox and log events from menu.connect.ts. It looks like the difference between desktop and mobile is that mobile doesn't trigger onClick event when desktop does.
Events when testing on mobile:

Events when testing on desktop:

Looks like "onPointerUp" event executes much faster than "onClick" so zag closes root menu even before handling "onClick" on list item, so click event somehow passes to underlying element. Should be noticed, that if disable "closeOnSelect" or comment "onPointerUp" handler, everything works fine, both desktop and mobile have same events.

Duplicate of #756
I think the underlying root cause is the same. We’ll get to the bottom of it shortly


linear isn't working as expected.

I'm trying to use sharp.linear function to equalize the histogram (stretch min and max values across the entire range of levels). In my application, this removes a type of fogging and colour casting from images.
This has worked fantastically up until I came across images that have a very compressed-looking histogram for one of the channels (I'm using Photoshop here to illustrate):

The expected result after applying my linear function would change the histogram from something that looks compressed (see above) into something that looks evenly spread, like this:

But instead, sharp.linear gave me a histogram that looks like this:

...Which left the image with a very strong blue cast:
unexpected result

...Normally, the results would not have the cast:
expected result

...And here's the file I've been trying to process with sharp.linear:
source

(The above image is a JPEG which is not what I used with sharp but because GitHub doesn't allow large TIFF files, this will have to do for now — the only thing to know is that if you try to replicate my results you will see less colour depth and JPEG artifacts).
Code
Here's how I calculate values for sharp.linear function:
// First, I extract a single channel from an image:
const blue = await sharp(image)
      .extractChannel("blue")
      .toColorspace("b-w")
      .toBuffer();

// Then, I get stats for that channel:
const stats = await sharp(blue).stats();

// This is the function I use to calculate the values for `sharp.linear` params:
const levels = (min: number, max: number) => {
  const scale = 255 / (max - min);
  return [scale, -min * scale];
};

// I run min/max numbers I got from stats through the above function:
const linearNumbers = levels(stats.channels[0].min, stats.channels[0].max);

// The resulting numbers are then plugged into `sharp.linear` as part of the final output steps:
const result = await blue.linear(...linearNumbers);

// ...This is then repeated for each channel and saved to file (I can add the bits that do that if needed).

I'm also including the data I got from stats using the above code below:
min/max for blue channel: [ 239, 255 ]
`levels` function output with the above numbers: [ 15.9375, -3809.0625 ]

min/max for green channel [ 209, 255 ]
`levels` function output with the above numbers: [ 5.543478260869565, -1158.5869565217392 ]

min/max for red channel  [ 141, 250 ]
`levels` function output with the above numbers: [ 2.3394495412844036, -329.86238532110093 ]

What I think is happening
The closest to a possible answer I got in my research is that the numbers being fed as blue channel's sharp.linear parameters are too extreme. Here's the source to that guess: https://github.com/libvips/libvips/issues/1607 However, this isn't helpful as I'm not sure if that's actually the case and how can I solve for this.

Would love to get any comments or feedback on this issue. Happy to add code/more info.

Since this implementation of linear is meant to solve the same problem as #200, it can be closed once that ticket is resolved. Otherwise, if anyone has any pointers, I'd love to hear them. 😅

Hi, sorry I missed this question first time around, I agree that #200 is probably what you need.
As a workaround for now, given you're already comfortable with extracting and joining channels, perhaps you could try using .toColorspace('lab').extractChannel(0) to extract the luminosity channel and experiment with altering it.

Thank you, will try! Will also post here if find any success.

@dmitrizzle Were you able to make any progress with this?

So sorry, @lovell, I couldn't get around to it 😬.

Closing due to inactivity but please feel free to reopen with more details if further help is required.


[WIP] fix(multiline): return chart data on data request

SUMMARY
Move the multiline logic from frontend to backend to avoid multiple requests. Requires https://github.com/apache-superset/superset-ui/pull/899 to be merged and deployed and bumped in this PR.
SCREENSHOT

TEST PLAN
Local testing
ADDITIONAL INFORMATION

[x] Has associated issue: closes #12268
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #12660 (853c71b) into master (734fb75) will decrease coverage by 3.48%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #12660      +/-   ##
==========================================
- Coverage   66.85%   63.36%   -3.49%
==========================================
  Files        1018      486     -532
  Lines       49776    29991   -19785
  Branches     4869        0    -4869
==========================================
- Hits        33278    19005   -14273
+ Misses      16375    10986    -5389
+ Partials      123        0     -123

Flag
Coverage Δ

cypress
?

javascript
?

python
63.36% <0.00%> (-0.64%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/viz.py
59.21% <0.00%> (-0.79%)
:arrow_down:

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.24%)
:arrow_down:

superset/db_engine_specs/presto.py
70.56% <0.00%> (-10.83%)
:arrow_down:

superset/db_engine_specs/sqlite.py
90.62% <0.00%> (-6.25%)
:arrow_down:

superset/utils/celery.py
96.42% <0.00%> (-3.58%)
:arrow_down:

superset/db_engine_specs/postgres.py
93.42% <0.00%> (-2.64%)
:arrow_down:

superset/views/database/mixins.py
80.70% <0.00%> (-1.76%)
:arrow_down:

superset/result_set.py
96.69% <0.00%> (-1.66%)
:arrow_down:

... and 543 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 734fb75...853c71b. Read the comment docs.

Codecov Report

Merging #12660 (853c71b) into master (734fb75) will decrease coverage by 3.48%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #12660      +/-   ##
==========================================
- Coverage   66.85%   63.36%   -3.49%
==========================================
  Files        1018      486     -532
  Lines       49776    29991   -19785
  Branches     4869        0    -4869
==========================================
- Hits        33278    19005   -14273
+ Misses      16375    10986    -5389
+ Partials      123        0     -123

Flag
Coverage Δ

cypress
?

javascript
?

python
63.36% <0.00%> (-0.64%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/viz.py
59.21% <0.00%> (-0.79%)
:arrow_down:

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.24%)
:arrow_down:

superset/db_engine_specs/presto.py
70.56% <0.00%> (-10.83%)
:arrow_down:

superset/db_engine_specs/sqlite.py
90.62% <0.00%> (-6.25%)
:arrow_down:

superset/utils/celery.py
96.42% <0.00%> (-3.58%)
:arrow_down:

superset/db_engine_specs/postgres.py
93.42% <0.00%> (-2.64%)
:arrow_down:

superset/views/database/mixins.py
80.70% <0.00%> (-1.76%)
:arrow_down:

superset/result_set.py
96.69% <0.00%> (-1.66%)
:arrow_down:

... and 543 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 734fb75...853c71b. Read the comment docs.

@villebro Should I do extra steps to make this working? When I open multiline chart I got this:

@villebro Should I do extra steps to make this working? When I open multiline chart I got this:

@adam-stasiak that's peculiar, I wonder if your frontend assets are properly rebuilt? With the new version of the NVD3 package axis1 shouldn't be present in the codebase any longer.

@adam-stasiak that's peculiar, I wonder if your frontend assets are properly rebuilt? With the new version of the NVD3 package axis1 shouldn't be present in the codebase any longer.

I rerun npm install and docker and now without an issue:) 🟢

I rerun npm install and docker and now without an issue:) 🟢


12 GitHub actionsworkflow cont

happy for now, project is still mostly empty though. will recreate ticket re github issues template and/or tidying autograding at a later stage.


Concise reporting of aliases

For this justfile,
# Auto-format the source tree
fmt:
    treefmt
alias f := fmt

# Run the project locally
watch $RUST_BACKTRACE="1":
    cargo leptos watch
alias w := watch

When I run just, I see:
Available recipes:
    default
    doc
    fmt                       # Auto-format the source tree
    f                         # alias for `fmt`
    test                      # Run tests (backend & frontend)
    watch $RUST_BACKTRACE="1" # Run the project locally
    w $RUST_BACKTRACE="1"     # alias for `watch`
    watch-release             # Run cargo in release mode (prints red panic)

What I'd like to see instead:
Available recipes:
    default
    doc
    fmt [aliases: f]                      # Auto-format the source tree
    test                      # Run tests (backend & frontend)
    watch $RUST_BACKTRACE="1" [aliases: w] # Run the project locally
    watch-release             # Run cargo in release mode (prints red panic)

This can keep the output tidy when there are a lots of aliases.

yes +1


fix README

Signed-off-by: Akihiro Suda<EMAIL_ADDRESS>

Codecov Report

Merging #239 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #239   +/-   ##
=====================================
  Coverage       0%     0%
=====================================
  Files          14     14
  Lines         782    782
=====================================
  Misses        782    782

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 641582d...8ea6a87. Read the comment docs.


Fix content.config.ts location in docs [i18nIgnore]

The path of the new content collection config file has change since 4. The docs said it moved to src/content.config.ts however, it actually moved to just content.config.ts. When the file exists in under src/ it causes issues with collections not being found.
I see that you want changes in only one language, however this is just a file path change so I've done it everywhere it existed. If you truly need it broken into just en I can do that, or really anyone with sed

Suggested label: code-snippet-update, improve documentation

Hi! I'm sorry you're having trouble with your collections being found, but the correct location for the content.config.ts is absolutely within src/
It might be that moving your file outside of src/ makes it not seen by Astro at all, and with some of our built-in backwards compatibility, this might coincidentally be working because this file was in fact not necessary in v4.
So I will close this as incorrect, and can recommend you try to make your project work knowing that the file must be in src/. If you need assistance, or someone to help troubleshoot your code, you are welcome to post in our #support channel in the Astro Discord. It's also possible you've discovered a bug! If so, you can submit an issue to the main Astro repo with a reproduction so they can look into it.
And for future reference, please do follow the instructions and submit in one language only. This requirement is clearly stated in the template.


[Bug]: Git Issues in release

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

[x] Keep commit input empty by default instead add a placeholder, for the first commit post connection we might want to keep it as Initial Commit (@haojin111)
[x] #10003
[ ] #10536
[x] Update message for contact message for intercom: (@haojin111)

Hey there, Thanks for getting in touch! We understand that you’d like to extend the number of private repos for your <Organisation Name>. Could you tell us how many private repos you’d require and why? We'll get back to you in a short while.

[x] The update button should be similar to COnnect button for the consistence (@haojin111)->Fixed
[x] The commit change tooltip retains when user click on + icon (@haojin111)->Fixed
[x] #10517
[x] The Appsmith server unavailable error is displayed instead of page not found when the user switch between the branch which has missing pages (@haojin111 )->Fixed
[x] When the user creates a new branch in git in the appsmith application the new remote branch wont be displayed until the new branch is created in local->Fixed
[x] When the user delete the branch from git and try to sync it the delete branch will still be displayed in the Application @AnaghHegde
[x] The internal server error is displayed when the user checkout from the remote branch @AnaghHegde
[x] when the user tries to click on local branch created from the remote branch the appsmith server is unavailable message is displayed @AnaghHegde
[x] when the user select the local branch created from the remote branch for merging the change the null pointer error is displayed
[x] The user configuration is not checked by default ->Fixed
[ ] The user is able to connect 2different application same repo in bit bucket
[x] The open repo link doesn't work for the bit bucket(in progress by @haojin111), (duplicated by #10216)
[x] The disconnect flow doesn't work in release->fixed
[x] #9989
[x] #10004

[ ] ssh url input
[ ] ssh key box
[ ] conflicts found: (deploy / merge tabs and bottom bar popup)
[ ] disconnect popup
[ ] repo limit reached modal
[ ] error while connecting at the connection tab
[ ] push error: pending upstream changes at the deploy tab

[x]  When the user tries to add a new branch and clicks multiple times on the branch name the error is displayed and then the user is unable to switch on the new branch created(Disable the click action until we get the response from backend)(@haojin111 )
[x] The Pull changes button shows infinite loading when there are a merge conflict(@haojin111)
[ ] When the users are in the same branch the multiple Cursors are displayed
[ ] The page count is wrong in the deploy tab
[ ] When Multiple users tries to merge the changes at the same time the error is displayed in the merge tab
[x] When the merge is not successful the error message should be displayed(@haojin111 )
[x] Some time user tries to merge the changes metadat.json error is displayed
[x] If 2 users create a branch at the same time internal server error is displayed
[x] Replace the ID with Readable slug  (this should be a part of clean URLs project)
[x] The new Deploy key should autogenerated when user change the remote URL(@haojin111)
[x] Invalid URL or page has no data error is displayed on the Canvas
[x] The wrong error message is displayed when user tries to connect to git without adding a deploy key (@AnaghHegde)
[x] #10216
[x] #10217
[x] #10333
[x] #10354
[x] User is unable to delete the imported curl api
[x] #10537
[x] The git Icon retains even after deleting the connection(@haojin111 )

The issue which came up after the new changes done

[x] When the user creates a new branch Until we refresh the browser i won't be able to see the branch(local branch)
[x] When we create a new remote branch Until we refresh the browser i won't be able to see the branch
[ ] When we commit and push it take a lot of time  to complete the action (i am comparing it with the previous release) same goes with the merging
[x] The user should not be allowed to click multiple times on the same Remote branch
[ ]When user update the page name the count is displayed as “2page updated” instead of 1

Steps To Reproduce

Connect your application to git and check for the above issues

Environment
Release
Version
Cloud

Adding few more new issues

[ ] When the user do a curl import the user is not able to rename the API
[ ] when the user bind curl imported data into a text widget the then in the deployed version the user is not able to see the Data
[ ] the page is not selected by default in this scenario its difficult for user to switch the branches
[ ] The invalid URllimage is displayed on the canvas
[ ]

@RakshaKShetty we are following the above issues under #10637

[ ] Hide bottom bar in the preview mode
[ ] Allow multi line commit messages

Lets close this issue? We can track the issues separately as the feature is in production now ?


Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue
Installation issue.
Brief description of your issue
I am unable to install Bitwarden (other Programs work, but this specific one brings issues for me). Winget says it is already installed, but it definitly is not. If I run the installer in a user context with no admin permissions it works and brings me a admin pop up. But I got this issue now on multiple clients while running in the system context.
The Bitwarden installations worked fine for me with the 2022.10.X versions. I think afterwards the issues started.
I had written about the issue here too:
https://github.com/Romanitho/Winget-Install/issues/71
I have also tried it with --scope machine with no success.
Steps to reproduce
Deploy Bitwarden via winget with a user with administrator permissions or with a system account (Intune for example). Winget will say it is installed, but it definitly is not.
Actual behavior
Winget detects the app to be installed even through it is not. The installation directorys are not there and in the user context with
winget list Bitwarden
it does not find anything. Reinstalling does not work as winget says it is already installed. When I run the command
winget uninstall Bitwarden.Bitwarden
it tries to uninstall it, but as it is not really installed it gets an error
An unexpected error occurred while executing the command:
0x800401f5 : Application not found.

and afterwards still says it is installed.
Expected behavior
Bitwarden installer should throw an error if it does not work, but winget definitly should not say it is installed when it is not.
Environment
Windows-Paket-Manager v1.3.2691
Copyright (c) Microsoft Corporation. Alle Rechte vorbehalten.

Windows: Windows.Desktop v10.0.22621.963
Systemarchitektur: X64
Paket: Microsoft.DesktopAppInstaller v1.18.2691.0

Protokolle: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
-----------------------------------------------------------------------------------------
Datenschutzerklärung              https://aka.ms/winget-privacy
Lizenzvereinbarung                https://aka.ms/winget-license
Hinweise von Drittanbietern       https://aka.ms/winget-3rdPartyNotice
Startseite                        https://aka.ms/winget
Windows Store Nutzungsbedingungen https://www.microsoft.com/en-us/storedocs/terms-of-sale

Screenshots and Logs
No response

But I got this issue now on multiple clients while running in the system context.

Winget does not support installing applications under the system context. Please try using a standard user or admin context

I had also tried it with a admin user where it didnt work. Also it works just fine for every other application, just for Bitwarden it does not.

Some applications don't support systemwide installation. So that might be your issue with Bitwarden

Some applications don't support systemwide installation. So that might be your issue with Bitwarden.

OK I just looked on bitwarden installer and it supports systemwide install but parameter might be required to start it.

OK that's weird I just tried to install Bitwarden in clean VM using machine scope in winget and it installed system wide after checking it's manifest.

Some installers prohibit installing in administrator mode. That may be the case here. Try installing as a "user" with machine scope. If it works under that context and fails under admin, then the "prohibitsElevation" should be added to the manifest to give the warning.
Note: we will have to do a manual review to approve it in that case while we work through some validation logic to support these scenarios. It's the most common reason Spotify.Spotify fails.

Okay thanks for your information. For now we are deploying it in the user context and it works. So we have a workaround for now.

In SYSTEM context you must --override this install with /allusers /S, we deploy it like that with Winget-Install

I was wondering if this has anything to do with #133334, a fix I made to solve a problem I was having installing Bitwarden with --scope machine as it always ended up being a user-level install instead of a system-level install.


feat(commands): add disable command

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #10

PR #11

PR #12   👈

This stack of pull requests is managed by Graphite.

Merge activity

Jan 1, 3:43 AM: @ToastedDev started a stack merge that includes this pull request via Graphite.


use the 'String#endsWith' method instead

In the case of checking if a file path ends with rc, filePath.endsWith("rc") is likely to be faster. This is because it's a straightforward string comparison without the need for the more complex pattern matching capabilities of regular expressions.

Absolutely, thanks for the PR! Please follow the checklist and format the code (npm run format) and I'm happy to merge this.

Thanks, Marco!

:rocket: This pull request is included in v4.0.2. See Release 4.0.2 for release notes.


Update SymEngine commit hash

Sage tests on travis keep failing because sage is downloaded twice and disk space runs out.

How many tests test Sage? I can see one test failure (fails to download Sage) and 3 tests time outs. Let's disable Sage for now, but we need our tests to pass before merging. To make sure no other bugs creep in.
Then we can think about fixing Sage.

Fixed Sage. 3 timeouts were due to a strange bug in travis.

Tests pass on Travis and they pass on Appveyor in the previous commit (and the latest commit doesn't touch any files that are used on Appveyor). Merging.


Thread.alive?

Added specs
Added alive? to thread.cr
Added try_kill to libpthread

This is unsafe as per the pthread_kill manpage:

POSIX.1-2008 recommends that if an implementation detects the use of a thread ID after the end of its lifetime, pthread_kill() should return the error ESRCH. The glibc implementation returns this error in the cases where an invalid thread ID can be detected. But note also that POSIX says that an attempt to use a thread ID whose lifetime has ended produces undefined behavior, and an attempt to use an invalid thread ID in a call to pthread_kill() can, for example, cause a segmentation fault.

Darn, looks like MRI maintains its own flag: http://rxr.whitequark.org/mri/source/thread.c#2575

The only other option I saw was to use "pthread_tryjoin_np"
But it gave me some segfaults as well, but, this also could be because I didn't use it well

This might be stupid, but, what about doing something like
@jhass @ysbaddaden
Can the pointer be a Thread even if the Thread died ? (as in joined?) or would he be deleted by the GC ?
t = Thread.new { a = 5}
check =  pointerof(t)
puts "alive" if check.is_a?(Pointer(Thread))
puts "dead" if !check.is_a?(Pointer(Thread))

A dead thread is still a thread, it's just not running anymore.

Can we add this to Thread and put a note saying that a use of this option is for now "unsafe" ?
I did more the 100000 runs of this check, not even once did it segfaulted.

It may pass on a Linux glibc, but be unsafe in other versions, libc or platforms, and complicate ports. The problem is the undefined behavior: https://en.wikipedia.org/wiki/Undefined_behavior
Note: you don't need to push it into crystal to use it.

Note that in the long run to do concurrent things you will have to use spawn and channels. Threads will be used by the runtime scheduler to manager the coroutines/fibers, so it doesn't matter much for the end-user what Thread will end up having or looking like (thought we might need something to know if a Thread is alive). Maybe Thread will be there, maybe with another name, but it's usage will be discouraged.

@asterite Using spawn is almost like using Fiber.new right ?
Doesn't it means that a code invoked with spawn won't have the same performance like Thread.new ? as 2 Fibers cannot really be running concurrently right ? won't that just take us to GIL issue like Ruby, but just without the Interpretor part.

As we don't expose Thread to the user, this shouldn't be needed. If later we need it internally for the scheduler, we'll probably do it with a flag inside the thread or something like that.


The reference space type is not updated until the frame after the session started

In the actual quest, the new reference type is already local floor when the session start, but with the emulator is not which is annoying and requires me to have special cases to handle the emulator if I want to test with it.
As u can see in the video, if I ask for it after the session started is properly updated to local-floor in this case.
https://github.com/meta-quest/immersive-web-emulator/assets/16962655/f44ba115-a93b-4dc3-97a8-b76452f917f8
This is with Wonderland Engine

Good find, will fix in v1.4


Support modal file dialogs Windows

Windows dialogs need the handle of the window which the dialog will be modal with. native-dialog does not currently support this in any way, which is particularly unfortunate for file dialogs since these are almost always modal.
This will of course require changes to wfd.
cc @ben-wallis

I'll look into adding this to wfd

I'll look into adding this to wfd

wfd 0.1.7 has been released to add support for providing the owner HWND
https://github.com/ben-wallis/wfd/compare/0.1.6...0.1.7

wfd 0.1.7 has been released to add support for providing the owner HWND
https://github.com/ben-wallis/wfd/compare/0.1.6...0.1.7

I'm working for the feature, but I'd wonder how to expose appropriate APIs for it.
This feature is platform-specific. Cocoa also have such API to modal the dialog with a window (runModalForWindow:), and Zenity/KDialog does not.
Both Win32 API and Cocoa accepts a pointer but their type is different in Rust and belongs to different crates (HWMD / *mut Object). Should I accept a usize (seems not safe enough), or should I accept those specific types and make the APIs platform-specific (requires the user to call the APIs with #[cfg(...)])?

I'm working for the feature, but I'd wonder how to expose appropriate APIs for it.
This feature is platform-specific. Cocoa also have such API to modal the dialog with a window (runModalForWindow:), and Zenity/KDialog does not.
Both Win32 API and Cocoa accepts a pointer but their type is different in Rust and belongs to different crates (HWMD / *mut Object). Should I accept a usize (seems not safe enough), or should I accept those specific types and make the APIs platform-specific (requires the user to call the APIs with #[cfg(...)])?

Both Win32 API and Cocoa accepts a pointer as parameter for this feature but their type is different in Rust and belongs to different crates (HWND / *mut Object). Should I accept a usize (seems not safe enough), or should I accept those specific types and make the APIs platform-specific (requires the user to call the APIs with #[cfg(...)])?

I think there's room for both #[cfg(...)]-ed functions and a cross-platform function.
The cross-platform function should take a reference to a type which implements HasRawWindowHandle. The window types from winit, sdl2, and glfw implement this trait. It should be documented that the function does nothing on Unix-y platforms, if it is impossible to implement.

Both Win32 API and Cocoa accepts a pointer as parameter for this feature but their type is different in Rust and belongs to different crates (HWND / *mut Object). Should I accept a usize (seems not safe enough), or should I accept those specific types and make the APIs platform-specific (requires the user to call the APIs with #[cfg(...)])?

I think there's room for both #[cfg(...)]-ed functions and a cross-platform function.
The cross-platform function should take a reference to a type which implements HasRawWindowHandle. The window types from winit, sdl2, and glfw implement this trait. It should be documented that the function does nothing on Unix-y platforms, if it is impossible to implement.

v0.5.3 has been publish. The version supports modal dialogs on Windows.
Modal sheet on macOS will be support later, because I'm spending the New Year in my hometown, and I have no access to my macOS device now...

I have a couple of nit-picks:

I don't think you're supposed to re-export raw-window-handle.
set_owner is an unusual name for this, I had expected something along the lines of set_parent, as parent-child relationships between windows in Windows are fairly easy to figure out. Window "ownership" in Windows is something I couldn't really find much about when I tried (briefly) looking into it once (some time ago).
Exposing a safe method which takes a RawWindowHandle isn't really a good idea, as it is now up to the caller of the function to ensure that the handle is valid, rather than whomever implements the type which implements HasRawWindowHandle.

I've made changed according to the suggestions, and published v0.5.4. Thanks!

Modal sheet support for macOS is added in v0.6.1


Add support for TOPK.COUNT bloom command

The associated API is documented at https://redis.io/commands/TOPK.COUNT

Closing since TOPK.COUNT consider deprecated since RedisBloom v2.4


Pin package and tool versions to make build more repeatable

Part of https://github.com/aspnet/Universe/issues/575 and https://github.com/aspnet/KoreBuild/issues/239
This removes floating versions of dependencies. This includes the korebuild version and versions used by PackageReference's. This solves issues with being unable to build source code when the packages on our myget feeds change.

@natemcmaster,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Heads up other reviewers, I'm planning to merge this later this afternoon. Take a look now if you want to add feedback before then.

Feel free to merge this change.


Wrong MD5 checksum when uploading files

This is a continuation of #29.
Steps to reproduce:

Create a brand new Sails app, based on latest stable (0.11.2): sails new md5bug
Apply this patch to the generated app from within the project root: patch -p1 < 0001-Trivial-file-upload-API.patch
Install dependencies added in the patch: npm install
Edit your S3 credentials in api/controllers/UploadController.js
Start the Sails application in the background: sails lift &
Upload a random file, i.e. the attached patch: curl -v -F<EMAIL_ADDRESS>localhost:1337/file
Locally calculate md5 of the file: md5 0001-Trivial-file-upload-API.patch
Observe difference in calculated checksum

Lower Sails by typing fg to put the process to foreground, then kill it with ctrl+c.

It turns out that the ETag header has different semantics than I expected:

If the file is uploaded using a single putObject() operation, the ETag is an md5 checksum of the file
If the file is uploaded using a multipart upload, then the ETag is calculated in the following way:
Calculate md5 sum bytes of all the individual parts
Concatenate the md5 sum's bytes of all the parts
Calculate md5 of the above concatenation
Add how many parts were uploaded to the end of the md5 checksum string

This library behaves as Amazon intends - no bug here regarding checksum calculation. Sorry for the confusion!


Write reflections on Hub Champion Training in a blog post

This issue tracks the drafting, review and approval for adding a new blog post to the Catalyst Project blog.
This issue is complete when: the copy of this page is approved and published on the website.
Please edit and insert information enclosed by the  below
Google Doc draft 👉 https://docs.google.com/document/d/1xDE3s4a7nU5pE5M2xx_vBaHHxWl5tQr9-H4MhRW0wbQ/edit?usp=sharing
Please consult the Style Guide for more information, including which metadata tags to choose from for your blog post.
Roles

[x] Drafting content: @jnywong
[x] Final approval of English post by Katie @katiepratt
[x] Hand off to Crowdin for translation
[ ] Hand off to Jenny to draft website previews - 2 separate posts @jnywong
[ ] Final approval of Spanish post by Sabrina @SLLDeC

Hey @katiepratt !
This one is ready for you to review.
Once that's approved, I'll work on getting this translated into Spanish with Crowdin 👍

Looks good, Jenny! I've added some edits and comments. Let me know if you'd like me to take another look, or if everything makes sense to you no worries. Have a good weekend.

Thanks for the suggestions @katiepratt ! I've added them in and passed the copy to Crowdin for translation into Spanish (Latin America).
@Tajuddeen1 FYI I am keeping track of costs in this spreadsheet: https://docs.google.com/spreadsheets/d/1VjE9L6Q9SNc3atbGxJGqHV_lE4IODW2sif3BTAto5ew/edit?usp=sharing.

@SLLDeC the proofreading task is ready for you on Crowdin 😄
https://crowdin.com/project/catalyst-project/tasks/48


Use CRUD functions internally

Is it possible to the call the CRUD functions inside the application from other parts of the code? How do I do that?
ie:
user = users.get(f"/user/{user_id}")
or something like that?

Hi @Zaffer, good question! At the moment this in not currently possible.
However this should hopefully possible in the future (would require a small refactor)

I would really like to see official support for this functionality! It would make some of my use cases so much easier and also solve  issue #136 ! Is there any progress on this @awtkns ?


Implement aggregation of patient data

Duplicate. Will not let me add a description or label.

Created on wrong repo


sos mutation counter

Coverage increased (+0.6%) to 96.923% when pulling 1e1fc73fee0d37ad24ae92f907209700113036c6 on mars-exploration into 1ff62106828c6d9618b61442131870061b466093 on master.


Move code to hawtio-integration

With the intent of reducing the number of Hawtio projects, move the code from this project to hawtio-integration.

done


Sample Project Build Error related to recent fix

"Method 'fetchOGData(urlString:completion:)' with Objective-C selector 'fetchOGDataWithUrlString:completion:' conflicts with method 'fetchOGDataWithUrlString(_:completion:)' with the same Objective-C selector"

There was a same problem with my project, just renaming this method solved my issue.


installation: update readme and tweak dependencies

Removing a confusing link in the documentation per #64. Also cleaning up some unnecessary(?) references to scipy and jaxlib, adding a missing numpy dep, and adding more info on JAX installation.

In the spirit of making the installation easier to debug, I also changed JAX_FINUFFT_USE_CUDA=ON to fail if CUDA is not found, instead of proceeding with a CPU installation with a warning. Otherwise, it's easy for a broken CUDA installation to cause the GPU extensions to not be built, resulting in confusing "MLIR translation rule for primitive ... not found for platform cuda" messages later.

LGTM - thank you!!


keep_sequences() issue

Hi Jeet,
I was having an issue with the keep_sequences() function.
#read in dataset from phylip
ds = dendropy.DnaCharacterMatrix.get_from_path(src="plethodon.phy", schema="phylip")
#just two taxa on the tree
t_l = ds.taxon_namespace[0:5]
#make an iterator, per function docs
ds.keep_sequences(t_l)

RuntimeError: dictionary changed size during iteration

I think this is due to a python 2 --> 3 change with the dictionary keys() method now returning an iterator. There are several ways to solve this issue - making a static list of the keys in the original dictionary at the function start is one way. Another might be to add a class attribute to the character matrix objects that is the original taxon set. That may be more expedient if you anticipate other functions will have this issue.
I'm happy to contribute a fix if you let me know what would be best.
Edit: Fixed creation of list.

Thanks, April. You nailed the problem and solution exactly. I'm ironing out some glitches in DendroPy in preparation for a release, so I just worked in the fix here 504b5d7d . Appreciate the heads up.

This might be an issue in a few other places - discard_sequences(), for example.

Ok, actually it looks like keep_sequences is the only place where we are iterating over a view of a container and mutating the same container in-place in the loop. In other places such as discard_sequences, we are iterating over an independent container. I'm closing this now, but please feel free to re-open and comment if you come across anything I've missed in this regard. Once again, thanks.


database/gdb: Have you ever considered using gorm directly instead of maintaining a separate orm in a framework?

Is your feature request related to a problem?
Option Yes
Describe the solution you'd like
框架只需提供解耦方案就可以
Describe alternatives you've considered
框架只需提供解耦方案就可以
Additional
No response

Yes, please refer to https://goframe.org/docs/design/project-dao-pain

感觉gdb更好用, 哈哈哈.


INSTALL.md: Restore $ as command prompt indicator

We have a notational convention in INSTALL.md, which says this among
others:

Any line starting with a dollar sign is a command line.
$ command

The dollar sign indicates the shell prompt and is not to be entered as
part of the command.

That notation exists to make it clear what is a command line and
what's output from that command line.

Does OpenSSL have the issue in other places, like manpages?  "git grep '^ '" might be useful.

Repeating some comments of mine that apparently were ignored being in https://github.com/openssl/openssl/pull/12175/files#r444780398 and below it:
I am not happy about that $  notation, mostly because when there is a number of shell commands in a row, such as in
    $ mkdir /var/tmp/openssl-build
    $ cd /var/tmp/openssl-build
    $ whatever

you cannot simply copy&paste that series of commands, while with
    mkdir /var/tmp/openssl-build
    cd /var/tmp/openssl-build
    whatever

you can.
And I suppose there are just a few cases where, leaving it out, command input and output could be confused.
In such cases we could, e.g., insert a blank line to help understanding this distinction.
Moreover, the $ symbol is not knows to Windows users, where typically a > is used as prompt symbol.

Some examples intermix command and output and the "$" prompt is used to mark off those.
I notice that "!" is used as a comment char for the OpenVMS line and I'm not sure it should get special treatment.

Is there a way in MarkDown to render those $  in a way that they are not copied when selecting and copying text including them?
In HTML for instance there are some tricks for making text non-selectable.

There is no way to make something non-selectable in markdown.

(FWIW, my prompt is a semicolon

There is no way to make something non-selectable in markdown.

I see :-( but thanks for the info!

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged
270540fd5413b00a746a581e8939c30862c689b1 INSTALL.md: Restore $ as command prompt indicator


⚠ ESPN has degraded performance

In e622151, ESPN (https://espn.com) experienced degraded performance:

HTTP code: 200
Response time: 754 ms

Resolved: ESPN performance has improved in 9fa3176.


Using onreadystatechange to improve performance

This commit uses the onreadystatechange callback instead of the previous polling code to improve performance.

@divdavem I am fine with these changes.

@benouat Thank you for your review!


Watcher creates alarm at hits > 0 but gives error with hits == 0

Sentinl and Kibana version
6.2.3-3

Issue description
I am trying to create a flatline alert. I have a ES query that returns 30 hits in the dev tools. If I create an alert with payload.hits.total == 0 for the condition I get a  Watchers: no data was found that match the used "script" conditions. If I switch the condition to payload.hits.total > 0 then I get an alarm triggered.

Here is my raw watcher:
{
  "actions": {
    "Email X-Men": {
      "throttle_period": "0h15m0s",
      "email": {
        "to": "admin@localhost",
        "from": "sentinl@localhost",
        "subject": "DelayedJob Flatline Alarm",
        "priority": "high",
        "body": "Unable to detect the delayed_job process in the last 5 minutes"
      }
    }
  },
  "input": {
    "search": {
      "request": {
        "index": [
          "metricbeat-*"
        ],
        "body": {
          "query": {
            "bool": {
              "must": [
                {
                  "match_phrase": {
                    "beat.name": {
                      "query": "machinename"
                    }
                  }
                },
                {
                  "query_string": {
                    "query": "system.process.cmdline:delayed_job*",
                    "analyze_wildcard": true,
                    "default_field": "*"
                  }
                },
                {
                  "range": {
                    "@timestamp": {
                      "gte": "now-5m",
                      "lte": "now",
                      "format": "epoch_millis"
                    }
                  }
                }
              ]
            }
          }
        }
      }
    }
  },
  "condition": {
    "script": {
      "script": "payload.hits.total == 0"
    }
  },
  "transform": {},
  "trigger": {
    "schedule": {
      "later": "every 5 minutes"
    }
  },
  "disable": true,
  "report": false,
  "title": "DelayedJob Flatline Alarm - fleet-portal1.staging"
}

Hi @zinefer are  you sure your response has a payload.hits.total field when there are no hits?

I am sure of that, actually...
I did some more testing, replacing the query that returned 30 hits with one that specifically returned 0 and found that my watcher is working correctly.
I think the issue here is that the UI was warning me that my watcher condition was returning false when I was running it manually.

That's good to hear. If you can replicate this, please check out the Kibana logs from the sentinl plugin in case there are warnings or errors there as you execute and we'll look into that. Thanks!

I'm experiencing the same thing.  It seems like there is a (confusing) warning message when everything is operating normally.
The condition script should return true or false. However when it returns false there always seems to be the warning message: "no data was found that match the used script conditions".  This is also needlessly logged to Kibana.


feat: LEAP-206: Ensure users can navigate freely and drafts are saved when leaving the labelling screen

PR fulfills these requirements

[X] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
[ ] Tests for the changes have been added/updated (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[X] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
[X] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)
(check all that apply)

[ ] Product design
[ ] Backend (Database)
[ ] Backend (API)
[X] Frontend

Describe the reason for change
To better support the flows of annotators, we want to to retain the draft work if they leave the labelling screen.
Which logical domain(s) does this change affect?
LabelStream, QuickView, DataManager

/git merge develop


Add .once modifier description for v-on

Add .once modifier description for v-on and modifiers in render functions

Thanks @KingMario! I moved things around a bit (trying to keep render function stuff collected in that section), but this looks really good!


[Feature Request] Figma file for NextUI components

Is your feature request related to a problem? Please describe.
Building a Figma design that corresponds & syncs with the actual code implementation is really hard. It really takes time to make designs with a component library in mind.
Describe the solution you'd like
I feel like NextUI already has a design system, would love it, if they make it public for the community.
Describe alternatives you've considered
There are libraries like ChakraUI which have their own Figma component library open source. Also, Flowbite and Untitled-UI also made their component library public. (even tho they have a premium version). The least NextUI can do is, they can have a community-free version to get started with the design.
Screenshots or Videos
No response

Figma file will be published with NextUI release


Popovers fail to open without jQuery's compatibility layer

OpenUI5 version
Probably since https://github.com/SAP/openui5/commit/48ed6d31c4ff97ae96c4fb9159eb40ed8d007f0a.
URL (minimal example if possible)
https://jsbin.com/vequcul/edit?html,js,output
Steps to reproduce the problem

Open the above sample. It has the bootstrap config data-sap-ui-excludejquerycompat enabled.
Try opening picker popup (F4) from one of the select controls.

At https://github.com/SAP/openui5/commit/48ed6d31c4ff97ae96c4fb9159eb40ed8d007f0a#diff-00d589248ea177fea4b7f629afacf3742506eb01c9ae3742d1dc8e6467156234R1433, jQuery(/*...*/).offset() was added which eventually calls jQuery's getClientRects() internally. That getClientRects function, however, is removed in jQuery 3.x and thus not available without the compatibility layer.

I've faced the same issue, the workaround: data-sap-ui-excludejquerycompat = "false".
The problem occurs starting 1.90, on 1.89.x everything is OK.

Hello @boghyon ,
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards,
Tsanislav

The change at https://github.com/SAP/openui5/commit/6fcc0415538ca16af9ddc6aebffd0227b08971f2 fixes this issue more or less because jQuery's offset() is no longer called in the case of the above JSBin sample. But the main issue, that offset() still calls getClientRects(), remains.

Mhmm, I don't get this. IMO, there never was a getClientRects function in jQuery and the compatibility layer does not add it back. getClientRects only exists on DOM elements.
I'm aware of two changes / issues around jQuery.fn.offset

jQuery 2.x allowed to call jQuery.fn.offset on non-DOM elements (esp. on window) and returned zero offsets in that case. jQuery 3.x instead fails as it always calls getClientRects on the given object. The compatibility layer partially restored the old behavior as the method no longer fails but it returns undefined and a warning is logged to notify the caller about the deprecated usage
Safari has a problem with calling getClientRects on SVG which made jQuery.fn.offset return unexpected results. This has recently been fixed with 8d4f21dda .

When the compatibility layer is switched off, any calling code has to obey the incompatible changes that jQuery 3.x. made. So  it can't be expected that offset still works for the window object in such an environment. That's where Popover missed UI5's goal to work without the compatibility layer, but that exactly has been fixed with 6fcc041.
Well, maybe I missed some point. If you still see a UI5 issue regarding jQuery.fn.offset's and getClientRect, can you then please elaborate a bit more on this?
BTW: The change to jQuery.fn.offset is documented here.

You're right. I understand the problem now better. My previous comment was nonsense. Sorry for the confusion.  This issue can be closed.


Allow --labels and --annotations options for every kubectl create ... subcommand

What would you like to be added:
Add --labels and --annotations options to all/specific* kubectl create commands.
Why is this needed:
Preamble: I wish this enhancement for all resources, I am just using the secrets as an example.
I recently stumbled upon a change in serviceaccounts, that since k8s 1.22 they don't automatically create token secrets.

Versions of Kubernetes before v1.22 automatically created long term credentials for accessing the Kubernetes API. This older mechanism was based on creating token Secrets that could then be mounted into running Pods. In more recent versions, including Kubernetes v1.28, API credentials are obtained directly by using the TokenRequest API, and are mounted into Pods using a projected volume.

To currently create long-lived tokens you'll need to write a full yaml:

kubectl apply -f - <<EOF
apiVersion: v1
kind: Secret
metadata:
  name: build-robot-secret
  annotations:
    kubernetes.io/service-account.name: build-robot
type: kubernetes.io/service-account-token
EOF

There exists so much to almost create a functioning oneliner:
$ kubectl create secret -n somenamespace generic build-robot-token --type kubernetes.io/service-account-token
error: failed to create secret Secret "build-robot-token" is invalid: metadata.annotations[kubernetes.io/service-account.name]: Required value

It would be really great, if we could add the required annotation directly. Because of the error, you can't use kubectl annotate as it already blocks us from even creating the secret. It would be really handy to just add the required annotation in the create command, for example:
$ kubectl create secret -n somenamespace generic build-robot-token --type kubernetes.io/service-account-token --annotations kubernetes.io/service-account.name=build-robot

While this was now an example for secrets, labels and annotations are an integral part of every resource - every resource needs/has the metadata object otherwise you couldn't even give a name to it. This is in my opinion a useful property for every resource and thus this enhancement request is asking for adding --labels and --annotations for every resource.
I see two possible criterias on where and how it can be added (* from above):

all create commands: Every kubectl create command has those two new options available. Pro: The options are tied to the create subcommand. Con: Every subcommand of create must be changed and now also read these properties and apply it to their implementation (or ignore it). Quirk: kubectl create -f probably should ignore those options, since you already have to define a full YAML and with it you can define the labels and annotations there.
specific create subcommands: If there is a subcommand to create - e.g. create role, create secret, create job and many more - those places should get also those --labels and --anotations. Pro: Only places where useful get those options. Con: All those places get those options so it is not centrally specified in create command. They all also have specific examples already specifying that they have custom options. To list a few:

  # Create a job from a cron job named "a-cronjob"
  kubectl create job test-job --from=cronjob/a-cronjob

  # Create a new secret named my-secret using a combination of a file and a literal
  kubectl create secret generic my-secret --from-file=ssh-privatekey=path/to/id_rsa --from-literal=passphrase=topsecret

  # Create a new config map named my-config with key1=config1 and key2=config2
  kubectl create configmap my-config --from-literal=key1=config1 --from-literal=key2=config2

  # Create a new ClusterIP service named my-cs (in headless mode)
  kubectl create service clusterip my-cs --clusterip="None"

  # Create a deployment named my-dep that runs the busybox image and expose port 5701
  kubectl create deployment my-dep --image=busybox --port=5701

  # Create an ingress with a default backend
  kubectl create ingress ingdefault --class=default \
  --default-backend=defaultsvc:http \
  --rule="foo.com/*=svc:8080,tls=secret1"

I'm leaning towards 2: Any create subcommand can benefit from allowing to set directly labels and annotations during creation.
Note: kubectl run command has those options (I inherited the naming of the options from there to keep it consistent):
      --annotations=[]: Annotations to apply to the pod.
  -l, --labels='': Comma separated labels to apply to the pod. Will override previous values.

We're hesitant to add new flags.  Using kubectl apply would be a better choice in this case.
See also this comment for a similar feature requested: https://github.com/kubernetes/kubectl/issues/1465#issuecomment-1681390198
Creating a kubectl plugin might be helpful if this is something you need frequently.  After kubectl version 1.27, kubectl allows plugins for subcommands of create, so this might be a good use case for that new functionality if you want to make a plugin for it.

/close