beginDrag not called when holding down shift key

I'm trying to make drag and drop work by enabling multiple items to be dragged when holding down shift key. The beginDrag is never called when holding shift. Works without the shift key.

Same problem. @gaearon, is it possible to solve it?

Could this just be a Chrome bug? Chrome bug 646339

No, it works fine on w3school page https://www.w3schools.com/html/html5_draganddrop.asp
And there is also a bug with alt-key pressed, too
https://react-dnd.github.io/react-dnd/examples-drag-around-naive.html


Nokogiri fixup

Motivation for this change
Since nokogiri 1.6.8, the gem has build-time dependencies on other gems and that fails.
The rubygems upgrade is not strictly necessary but it's there now.
Things done

[x] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] OS X
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

/cc @manveru

Note that the dependencies also need to be added as dependencies in the gemset.nix. Last time I tried bundix didn't generate those.
Example after fixup:
{
  mini_portile2 = {
    source = {
      remotes = ["https://rubygems.org"];
      sha256 = "1y25adxb1hgg1wb2rn20g3vl07qziq6fz364jc5694611zz863hb";
      type = "gem";
    };
    version = "2.1.0";
  };
  nokogiri = {
    dependencies = ["mini_portile2" "pkg-config"];
    source = {
      remotes = ["https://rubygems.org"];
      sha256 = "17pjhvm4yigriizxbbpx266nnh6nckdm33m3j4ws9dcg99daz91p";
      type = "gem";
    };
    version = "1.6.8";
  };
  pkg-config = {
    source = {
      remotes = ["https://rubygems.org"];
      sha256 = "0lljiqnm0b4z6iy87lzapwrdfa6ps63x2z5zbs038iig8dqx2g0z";
      type = "gem";
    };
    version = "1.1.7";
  };
}


ACM-13268: Apply ACM disaster recovery backup label to custom install templates

Summary
This PR applies the ACM disaster recovery backup label (cluster.open-cluster-management.io/backup: "") to custom install template ConfigMaps. The default Assisted Installer (AI) and Image Based Installer (IBI) templates are not included in the content to be backed up as these are automatically created when the SiteConfig Operattor manager pod starts.
Note that the following content, required by the SiteConfig Operator and ClusterInstance controller, should already be backed up by the underlying installers (i.e. AI or IBI) and are thus excluded from the SiteConfig Operator:

pull secret
BMC secrets
extra-manifests ConfigMaps

Furthermore,  the ClusterInstance CRs (clusterinstances.siteconfig.open-cluster-management.io) should automatically be backed up by ACM as per resources-that-are-backed-up

Back up all resources with an API version suffixed by .open-cluster-management.io and .hive.openshift.io. These suffixes indicate that all Red Hat Advanced Cluster Management resources are backed up.

It is also worthwhile noting that the rendered install manifests can also be labelled for backup through the ClusterInstance CR via the ExtraLabels field (see https://github.com/stolostron/siteconfig/pull/75)
Resolves: ACM-13268

/override ci/prow/sonar-pre-submit

/hold

/unhold

/override ci/prow/sonar-pre-submit

/override "SonarCloud Code Analysis"

lgtm


Issue 1231 - Client for querying ingest batcher store

Make sure you have checked all steps below.
Issue

[x] My PR addresses the following issues and references them in the PR title. For example, "Issue 1234 - My Sleeper
PR"

Resolves https://github.com/gchq/sleeper/issues/1231

Tests

[x] My PR adds the following tests OR does not need testing for this extremely good reason:

StandardIngestBatcherReporterTest
JsonIngestBatcherReporterTest
ClientUtilsTest.FormatBytesAsString

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
separate issue for that below.
[x] If I have added, removed, or updated any external dependencies used in the project, I have updated the
NOTICES file to reflect this.

Can you update the docs to note the existence of the new script?


Typo "SQL Server Data tools"→"SQL Server Data Tools"

https://docs.microsoft.com/en-us/azure/synapse-analytics/sql-data-warehouse/sql-data-warehouse-source-control-integration

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good; thanks.


[solved] no_std Can't find crate for 'test'

I'm using rust-analyzer extension in VSCode. I had an error of no_std Can't find crate for 'test' in the top of line when I opened src/led.rs.
So I add some properties for rust-analyzer in .vscode/setting.json, It solved it.
{
    "rust.target": "thumbv6m-none-eabi",
    "rust.all_targets": false,
    "rust-analyzer.cargo.target": "thumbv6m-none-eabi",
    "rust-analyzer.checkOnSave": false
}

I'm happy if you can use that as a reference.

Thank you very much!
I updated .vscode/setting.json.


DEV-578

This change is

SonarQube analysis reported 2 issues

 2 minor

Watch the comments in this conversation to review them.

:+1:

:+1:


Add quotes

We just tested that SAS for --dest-sas needs to be in quotes
Lost some time troubleshooting that

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2d7ea246-7003-91f2-e4fd-2f354a7ab5c3
Version Independent ID: 7c9676ff-59e2-f1ed-3fd2-548724650e36
Content: az monitor app-insights component continues-export
Content Source: latest/docs-ref-autogen/monitor/app-insights/component/continues-export.yml
Service: monitoring-and-diagnostics
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

monitor


Add integration tests for Azure Storage driver

Add integration tests for Azure Storage driver
Description
As discussed in https://github.com/apache/libcloud/pull/1553#discussion_r572431845, this pull request ports the Azure Storage driver integration tests from libcloud-tests to trunk.
The tests are split into a generic storage integration test base (which uses the high level storage driver API to run various scenarios) and specific instantiations which exercise various Azure Storage backends. The intent is that the test base in the future can be re-used to quickly add integration tests for other storage backends.
Notes:

Transient errors with the Azure Ubuntu package mirrors required adding a call to apt-get update to fix the CI, similar to what's described in https://github.com/actions/virtual-environments/issues/675.
The new storage integration have been added as a new tox target to avoid slowing down the unit test suite, re-using some existing patterns laid out by integration tests of the compute API.
While libcloud-tests ran against containerized and cloud-based storage accounts, for now this pull request only ports the former as I will soon loose access to my free cloud credits. However, if someone wants to add me to an Azure subscription that is funded for this project, or provide me with the credentials for a service principal, I'm more than happy to add the required code to run the test suite against the live cloud storage backends.

Status

done, ready for review

Checklist

[x] Code linting
[x] Documentation
[x] Tests
[x] ICLA

Codecov Report

Merging #1572 (e24f58e) into trunk (cc5987b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            trunk    #1572   +/-   ##
=======================================
  Coverage   83.00%   83.00%
=======================================
  Files         394      394
  Lines       84990    84990
  Branches     9038     9038
=======================================
  Hits        70550    70550
  Misses      11373    11373
  Partials     3067     3067

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc5987b...e24f58e. Read the comment docs.

Thanks for working on this.

While libcloud-tests ran against containerized and cloud-based storage accounts, for now this pull request only ports the former as I will soon loose access to my free cloud credits. However, if someone wants to add me to an Azure subscription that is funded for this project, or provide me with the credentials for a service principal, I'm more than happy to add the required code to run the test suite against the live cloud storage backends.

@tonybaloney Do you happen to know if Azure has some kind of free credits for OSS program, similar to the AWS one which we could use for running end to end tests?

@Kami @tonybaloney Given that ASF is a non-profit, the Azure for non-profits grant could be an avenue to get some credits.

I've put in an internal request at Microsoft for some credit.
I'll ping back on here when/if it gets approved
On Wed, Mar 24, 2021 at 1:18 AM Clemens Wolff @.***>
wrote:

@.**** commented on this pull request.
In integration/storage/base.py
https://github.com/apache/libcloud/pull/1572#discussion_r599610000:

           value = getattr(self, required, None)

           if value is None:

               raise unittest.SkipTest('config {} not set'.format(required))

       kwargs = {'key': self.account, 'secret': self.secret}

       for optional in 'host', 'port', 'secure':

           value = getattr(self, optional, None)

           if value is not None:

               kwargs[optional] = value

       driver_class = providers.get_driver(self.provider)

       self.driver = driver_class(**kwargs)

   def tearDown(self):

       for container in self.driver.list_containers():

Done in 0c4d093
https://github.com/apache/libcloud/commit/0c4d09376c824eb542743fc225fc30c22ab39bc9
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/libcloud/pull/1572#discussion_r599610000, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AALWEAJV7Q7DO3ZMT5IMGXTTFCPKHANCNFSM4ZQSB2FA
.

@tonybaloney @Kami Any thoughts on next steps for this integration test PR?

Codecov Report

Merging #1572 (2024981) into trunk (cc5987b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            trunk    #1572   +/-   ##
=======================================
  Coverage   83.00%   83.00%
=======================================
  Files         394      394
  Lines       84990    84990
  Branches     9038     9038
=======================================
  Hits        70550    70550
  Misses      11373    11373
  Partials     3067     3067

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc5987b...2024981. Read the comment docs.


Add AetherSX2 for pi 4 / pi 5 64bit

AetherSX2 / A Closed Source Fork of PCSX2 with ARM64 support
Following on from https://github.com/Exarkuniv/RetroPie-Extra/issues/177 I've taken a stab at this. Can you take a look and advice some tips as I've not written or pushed a script before
I don't have a pi 4 anymore but this should work with Pi 4 on a 64bit Raspberry Pi OS, such as the current stable OS they use. It won't work on buster and the old Official RetroPie image.

ill give this a shot and let you know

ok i gave this a shot
``
Executing (via xinit): /opt/retropie/emulators/aethersx2/AetherSX2-v1.5-3606/usr/bin/aethersx2 -nogui /home/pi/RetroPie/roms/ps2/Hulk (USA).iso
/dev/shm/retropie_xinitrc: line 9:  3318 Segmentation fault      /opt/retropie/emulators/aethersx2/AetherSX2-v1.5-3606/usr/bin/aethersx2 -nogui "/home/pi/RetroPie/roms/ps2/Hulk (USA).iso"
xinit: connection to X server lost
``
is what i get and the rom does not start.
also should list that bios is needed. i dont know if i got the right ones
ill see what i can figure it out for more details

no i did not, and yes for now best to add that until a image is releaced, i have a feeling that will be done for us at that time.

ok i got it to work
so one thing is that it does not see the bios. it is looking for it in the ```/home/pi/.config/aethersx2/bios
not sure if we can change that or if a symblink is needed here.
also a example of that bios name we are looking for is also good
i have a bunch i and i found the folder through the menu but it is still not seeing them or liking them. not sure which

so i have been messing with this more
i found that the issue was the .ini file was not being made
i was getting this error
/home/pi/RetroPie-Setup/ext/RetroPie-Extra/scriptmodules/emulators/aethersx2.sh: line 53: f: command not found
im think i might of cleaned up the script and have it working correctly
ill keep you posted on my findings

ok i figured it out

ok i got back to this, sorry it took me this long
i have a few tiny changes, but i want to get all my testing done first
so the bios folder now works fine, and i was able to get a game playing
the thing is, i have no sound
whats a game that is working for you?
and whats the checksum of the bios you are using

Pulseaudio or pipewire could be the issue there? I don't think I installed or edited those when building RetroPie manually though
So couple of games off top of my head that definitely work:-
Bully
GTA 3
GTA San Andreas
ICO
Gradius V
Dragon Quest V
Final Fantasy X
Kingdom Hearts 1 & 2
There's loads more I've tested and are alright

thanks, i have audio in the main RP menu and in NES and SEGA games, just not PS2
all i did was use the latest lite OS and https://github.com/danielfreer/raspberrypi5-retropie-setup to install RP
what OS are you useing

Oh okay. I used the official doc info
https://retropie.org.uk/docs/Manual-Installation/
I essentially installed raspberry pi os 64bit lite during the official imager, enabled ssh, wifi. Then did these steps except relating to the locale settings as that's already done by the imager

Okay have added pulseaudio, that's a requirement for sound to work

Well I did try just only pulseaudio, nothing happened.
Guess I'll try it with a fresh from scratch load and see what happens

Strange, could always add things like libpulse-dev libsoundtouch-dev portaudio19-dev perhaps those are needed somehow

i think its good to go now. only why to know for sure is have people test it.

I have tested it and i got a Blackscreen and the Game won´t start . I switched to the kernel8.img , i have the right BIOS , i tested it with multiple Games ( GTA 3 included ) and i used the latest script . I´m on Raspberry Pi 5 . When you can tell me how i open the Runcommand window in Retropie to see what´s going on , then i can provide further Information .

Open this in a issue. Not in the pull for this script. Thx
It will keep it cleaner


Problems with uploading chapters

When I try to upload a page, it is not added.
and
Excellent work :)

i think this caused by compatibility of my code for some browser
i will fix this problem as fast as possible

i already fix this problem by this commit<PHONE_NUMBER>8c9609dc738eb8fc8d2d3c05b3ea47


ci(workflows): add lint and test

Change-Id: Ieefb01a2ead5e848dbd6e99e6fdc2d005a253cc1
What type of PR is this?

CI
What this PR does / why we need it:
config github workflow
Which issue(s) this PR fixes:
none
Special notes for your reviewer:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


add waveform.al to projects links

add waveform.al api service link
What this service offers:

allows to create waveform json audio data and images from audio files that can be used with wavesurfer.js
no audio files are stored on server, audio json data will be available via cdn
wavesurfer-js.org is already whitelisted with CORS for unlimited use

You can request features here: #1183

Cool site!


fix: Update eslint error & update version

:tada: This PR is included in version 1.0.0 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


Tutorial papercuts

Reproduction
I don't have a repro, if the completed tutorial is somewhere then it wasn't linked in the tutorial. I wish it was.
I'm using vite, I was NOT using the tutorial template, actually. I did copy the data file.
System Info
System:
    OS: Linux 5.15 Ubuntu 20.04.6 LTS (Focal Fossa)
    CPU: (8) x64 Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz
    Memory: 35.75 GB / 46.95 GB
    Container: Yes
    Shell: 3.6.4 - /usr/bin/fish
  Binaries:
    Node: 18.19.0 - ~/.nix-profile/bin/node
    Yarn: 1.22.21 - ~/.local/share/pnpm/yarn
    npm: 10.2.3 - ~/.nix-profile/bin/npm
    pnpm: 8.13.1 - ~/.local/share/pnpm/pnpm
    Watchman: 4.9.0 - /usr/bin/watchman
  npmPackages:
    @remix-run/architect: ^2.4.1 => 2.4.1
    @remix-run/css-bundle: ^2.4.1 => 2.4.1
    @remix-run/dev: ^2.4.1 => 2.4.1
    @remix-run/eslint-config: ^2.4.1 => 2.4.1
    @remix-run/node: ^2.4.1 => 2.4.1
    @remix-run/react: ^2.4.1 => 2.4.1
    @remix-run/serve: ^2.4.1 => 2.4.1
    vite: ^5.0.10 => 5.0.10

Used Package Manager
pnpm
Expected Behavior
I played through the tutorial and have some quick feedback, take it as you will.

Edit form doesn't clear when clicking "New" while already in an edit form. I would suggest:<Form
  id="contact-form"
  key={contact.id} // <= Added this to reset the form on page change, dunno if there's a better way.
  method="post"

I'd suggest/mention something, because it's quite relevant to the navigation?
Destroy route should have _: app/routes/_sidebar.contacts.$contactId_.destroy.tsx? The tutorial doesn't, makes Delete take me to 404 page.
Edit page cancel navigates out of the page if landing straight on edit page (e.g. navigate to http://localhost:5173/contacts/paul-bratslavsky/edit on new tab), I would suggest the following, although I wish navigate(-1) didn't have that behavior out-of-the-box:navigate("..", {
  relative: "path",
})

I think this is a common mistake, and the tutorial should mention it.

Actual Behavior
Just thought I'd do a friendly report, not expecting anything really.
Thanks for the tutorial!
PS. again, I was NOT using the tutorial template, and I went quite far off-track and my solution is quite different. However, I couldn't see a completed version linked there so I can't compare.

Thanks so much for sharing all this feedback! I agree it would probably be good to add a full tutorial

Yep, agreed, this is kind of an awkward experience, I'll add a fix for this
Your route looks different from the tutorials (there's no _sidebar), so I'm wondering if that's affecting it. I went through the tutorial and deleting leading to a 404 was not a problem for me
I did not experience this issue, so I'm not sure what caused it. The navigate(-1) should be inside of an onClick callback, so it shouldn't be firing automatically

The navigate(-1) should be inside of an onClick callback, so it shouldn't be firing automatically

Yeah it's not firing automatically but if you land on that page and then click, it navigates you back to some page outside the app.

Very nice tutorial, thank you 👍 My 5 cents to improve it.
The first place where I feel disconnected is this chapter: https://remix.run/docs/en/main/start/tutorial#forms-without-navigation
It says:

So far all of our forms have changed the URL. While these user flows are common, it's equally common to want to submit a form without causing a navigation.

For these cases, we have useFetcher. It allows us to communicate with actions and loaders without causing a navigation.

Wait, haven't we explicitly navigate to new pages with redirect?! If I remove redirect, for example, on EDIT layout I stay on the same page. No URL is changed... So what exactly do you mean by "without causing a navigation"?!
The difference betwee Form and fetcher.Form that I personally observe, is that navigation.state is updated from idle to loading and back with the first and stays idle with the second. So, I assume, Form should work with disabled JS and fetcher.Form should not. But it's not necessary related to URL changes. Would be great to somehow clarify the text.

Same
I'm not sure about a difference between <Form> and fetcher.Form

There is one key difference though, it's not a navigation, so the URL doesn't change and the history stack is unaffected.

In other words, <Form> changes something of URL and history stack
but I couldn't find any change in my environment
What do the docs mean?


Custom form 774

Custom form defined by a JSON config file.
Docker volume mount to replace the forms directory in the public Vue space.
Helm config to mount the forms JSON I'm half expecting this to explode Planning to test in the deployed PR.

The Helm integration for the custom form is finally working.

Playing with another value in values-pr, I will put back to as it was before before we merge


NOBUG: Add fallbacks to park sub page

Jira Ticket:
None
Jira Ticket URL:
None
Description:
Added fallbacks to parkSubPage.js to be used if there's no protectedArea.slug

Closed as PR #478 includes fallbacks as well


point selectize to master repo

this should fix part of this bug: compilation errors when using via npm/browserify
specifically, it points selectize to the current master repo.

thanks a bunch. merged and will push as new version when I've looked at your other issue


[SPARK-21027][ML][PYTHON] Added tunable parallelism to one vs. rest in both Scala mllib and Pyspark

Added tunable parallelism to the pyspark implementation of one vs. rest classification. Added a parallelism parameter to the Scala implementation of one vs. rest along with functionality for using the parameter to tune the level of parallelism.
Please review http://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?

add to whitelist

Test build #77948 has started for PR 18281 at commit b69f201.

Test build #77948 has finished for PR 18281 at commit b69f201.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77948/
Test FAILed.

Test build #77950 has started for PR 18281 at commit b69f201.

Test build #77950 has finished for PR 18281 at commit b69f201.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77950/
Test FAILed.

Merged build finished. Test FAILed.

add to whitelist

Test build #77951 has started for PR 18281 at commit e750d3e.

Test build #77951 has finished for PR 18281 at commit e750d3e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77951/
Test PASSed.

Merged build finished. Test PASSed.

Test build #77954 has finished for PR 18281 at commit 81d458b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77954/
Test PASSed.

taking a look now

Test build #78004 has started for PR 18281 at commit 2133378.

Thanks @thunterdb , I was just about to comment also on the similarities to #16774.  It would probably be best to align a couple things between the two:

the parallelism param - my PR has just a slightly different name numParallelEval that was meant more to describe evaluation, but maybe something like parallelism would be fine too
is this also going to have have the ability to override the default thread-pool with a different ExecutorService?  cc @MLnick

What are your guys thoughts on these?

test this please

Test build #78009 has started for PR 18281 at commit 2133378.

Test build #78009 has finished for PR 18281 at commit 2133378.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78009/
Test PASSed.

I agree; it'd be good to match on the Param name.  Do you think "parallelism" is too vague? If not, then I like it since it's simple.
I'd vote for default parallelism of 1 to be safe (match current CrossValidator behavior).  We can change this PR to use 1 as well for uniformity.
Do we really need to expose the ability to pass in an ExecutorService?  Given how few people have requested any kind of parallelism, I have a hard time imagining people needing to pass in an ExecutorService.  If one of you has a need for it, I guess that's fine, but I'd recommend it be marked as a DeveloperApi and clearly documented (e.g., not saved by persistence, etc.).

Originally in the CV pr Bryan used par collections. Tim pointed out perhaps
futures would be better and to add the ability to use different custom
threadpools. However I think the intention was same as here - i.e. To just
ensure the threadpool is a new dedicated one and not the default in order
not to block multi tenant apps.
I tend to prefer the par collection approach for simplicity and
readability. Also if we can share the param then great - "parallelism"
works I think and is generic enough to be used by multiple components.
Also perhaps this wouldn't work with Scala 2.10? I think that may be ok now
since we intend to drop support in 2.3.x ?
If we agree on approach then the CV PR can be changed back to using par
collections with custom task support.
On Wed, 14 Jun 2017 at 03:36, jkbradley<EMAIL_ADDRESS>wrote:

@jkbradley commented on this pull request.
In mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala
https://github.com/apache/spark/pull/18281#discussion_r121836808:

@@ -325,8 +343,13 @@ final class OneVsRest @Since("1.4.0") (
multiclassLabeled.persist(StorageLevel.MEMORY_AND_DISK)
}

val iters = Range(0, numClasses).par

Discussed offline with @thunterdb https://github.com/thunterdb :
Setting the parallel collection tasksupport value is essentially doing the
same thing as in @BryanCutler https://github.com/bryancutler 's PR:
ForkJoinTaskSupport is using the ExecutionContext created by ForkJoinPool
under the hood.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/spark/pull/18281#discussion_r121836808, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA_SB35eWKaGmfDIF7gnqVwqrFnwDArMks5sDzkqgaJpZM4N3uuq
.

You're right about Scala being an issue.  This actually works with Scala 2.10 and 2.11 but not 2.12, in which Scala drops its own ForkJoinPool in favor of the java one.  As long as we drop 2.10 before adding 2.12, then we'll be OK.
@BryanCutler do par collections seem workable?

One comment about putting parallelism in a trait vs. not: Would we want to avoid creating a "threadpool" when parallelism = 1?  In that (common) case, maybe we'd want to avoid par collections.  If so, then the trait could provide a helper method which takes a range/seq and a function accepting values from that range.  That helper could use par collections or not, depending on the setting of parallelism.  Good, or too complex?

@BryanCutler Thanks for the thoughts!  I didn't see a response w.r.t. putting parallelism in a trait, so I'll say we won't do it for now.  The usage of par collections / Futures in OneVsRest vs tuning looks a bit different.

w.r.t. putting parallelism in a trait
I think this would be a goot idea and it could be shared with OneVsRest, CrossValidator and TrainValidationSplit right off the bat.  It could have the parallelism Param and return an ExecutionContext based on paralelsim to either return a thread-pool or same-thread executor.

The usage of par collections / Futures in OneVsRest vs tuning looks a bit different.
It is a little different.  For CrossValidator, Futures are nice because I could add a callback to unpersist training data once all training is complete and can continue to evaluate each model as soon as it is ready instead of blocking.

Catching up here, it sounds like the current recommendations (which I'm on board with) are to:

Switch to Futures, including using sameThreadExecutor for the case of parallelism=1
Try putting the use of Futures in a trait, unless it makes the code too awkward.  If @BryanCutler can reuse that in the other PR, that'd be great, though it might require some generalization (if worthwhile).
one or two smaller comments above

Test build #78486 has started for PR 18281 at commit 5f635a2.

Quick comment about my update. As per a discussion earlier I had the OneVsRest class extend the trait ParallelismParam because the parallelism parameter is only relevant to the training of OneVsRest and therefore shouldn't be included with OneVsRestModel. Also, as a result of this, the parallelism parameter is not currently persisted. However, in python, the parallelism parameter is persisted.

@BryanCutler Could you please review this?

Test build #78486 has finished for PR 18281 at commit 5f635a2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78486/
Test PASSed.

@ajaysaini725 , I was just about to update my PR with an updated trait that makes some small improvements when I saw you're update.  I'll post what I have in case if you would like to use it here
private[ml] trait HasParallelism extends Params {

  /**
    * param to control the level of parallelism
    * Default: 1
    *
    * @group expertParam
    */
  val parallelism: IntParam = new IntParam(this, "parallelism",
    "set the level of parallelism to be used", ParamValidators.gtEq(1))

  /** @group getParam */
  @Since("2.3.0")
  def getParallelism: Int = $(parallelism)

  /** @group setParam */
  @Since("2.3.0")
  def setNumParallelEval(value: Int): this.type = set(parallelism, value)

  /**
    * Create an ExecutionContext that is determined from the param [parallelism]. If this param
    * is set to 1, a same-thread executor will be used to run in serial otherwise a thread-pool
    * with max threads set to the param value.
    */
  @Since("2.3.0")
  def getExecutionContext(maxThreads: Int): ExecutionContext = {
    maxThreads match {
      case 1 =>
        ThreadUtils.sameThread
      case n =>
        ExecutionContext.fromExecutorService(
          ThreadUtils.newDaemonCachedThreadPool(s"${this.getClass.getSimpleName}-thread-pool", n))
    }
  }

  setDefault(parallelism -> 1)
}

Also, as a result of this, the parallelism parameter is not currently persisted.

I think that is fine, it's not a model parameter

Test build #78537 has started for PR 18281 at commit 5f635a2.

@BryanCutler What is the point of having the function getExectionContext() take a parameter maxThreads? Isn't it just supposed to use the parallelism parameter when determining what execution context to return?

Test build #78537 has finished for PR 18281 at commit 5f635a2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78537/
Test PASSed.

Also @BryanCutler just pushed an updated PR based on your comments. Thanks!

Test build #78543 has started for PR 18281 at commit 4431ffc.

Test build #78543 has finished for PR 18281 at commit 4431ffc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78543/
Test PASSed.

Merged build finished. Test PASSed.

What is the point of having the function getExectionContext() take a parameter maxThreads? Isn't it just supposed to use the parallelism parameter when determining what execution context to return?

My only thought with this is that when using getExecutionContext() it kind of hides the fact that your using the paralllelism parameter to create the ExecutionContext, where if you pass it as a parameter, e.g. getExecutionContext($(parallelism)) it's easy to see you are using that parameter to make the execution context - no need to drill down to the trait.
It's not a big deal though, so I thinks this is fine as-is unless others have the same thought.

I made a few comments.
I'm not sure if we should expose getExecutionContext as a public method for now? I think it might be best to leave it private for now and we can always expose it later if there is user demand.
Also, this now changes the default behavior of OneVsRest. Currently, par would use the default threadpool when fitting. In most cases, this would mean "full" parallelism by default (up to the number of core which in most cases would be larger than the number of classes). We need to decide if this is what we want. If so it needs to be documented in the migration guide.

I think later in the cross-validation work, if the logic for using Futures for fitting can be extracted into generic methods in a trait or an object, great.

Test build #79303 has started for PR 18281 at commit a841b3e.

Test build #79303 has finished for PR 18281 at commit a841b3e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79303/
Test PASSed.

@BryanCutler @MLnick @jkbradley I pushed another update based on comments.

@ajaysaini725 @jkbradley  Can we avoid python-side to re-implement the logic of OneVsRest? It can simply python-side code I think. Just let the wrapper inherit JavaEstimator, and when we settingsetClassifer() in python-side we can get the backend java object through classifer._java_obj and pass it to the scala side...

Taking a look now

Test build #79630 has started for PR 18281 at commit a95a8af.

Test build #79630 has finished for PR 18281 at commit a95a8af.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79630/
Test FAILed.

Test build #79717 has started for PR 18281 at commit d45bc23.

Test build #79717 has finished for PR 18281 at commit d45bc23.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79717/
Test FAILed.

Test build #79719 has started for PR 18281 at commit b16658c.

Test build #79719 has finished for PR 18281 at commit b16658c.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79719/
Test FAILed.

Test build #79772 has started for PR 18281 at commit 30ac62d.

Test build #79772 has finished for PR 18281 at commit 30ac62d.

This patch fails Python style tests.
This patch does not merge cleanly.
This patch adds the following public classes (experimental):
class OneVsRestParams(HasFeaturesCol, HasLabelCol, HasPredictionCol):
class OneVsRest(Estimator, OneVsRestParams, HasParallelism, JavaMLReadable, JavaMLWritable):
class OneVsRestModel(Model, OneVsRestParams, JavaMLReadable, JavaMLWritable):

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79772/
Test FAILed.

Test build #79775 has started for PR 18281 at commit cc634d2.

Test build #79775 has finished for PR 18281 at commit cc634d2.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79775/
Test FAILed.

Test build #79784 has started for PR 18281 at commit ce14172.

Test build #79784 has finished for PR 18281 at commit ce14172.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79784/
Test PASSed.

Test build #79984 has started for PR 18281 at commit 1c9de16.

Test build #79984 has finished for PR 18281 at commit 1c9de16.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79984/
Test FAILed.

Test build #79985 has started for PR 18281 at commit 9f34404.

Test build #79985 has finished for PR 18281 at commit 9f34404.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79985/
Test PASSed.

@holdenk Some of those improvements on handling parallelism sounds useful, but I'd prefer we merge this and then add more improvements.  This PR should be a strict improvement there (moving from no parallelism to some potential for parallelism).
Do people have more comments before this is merged?

@ajaysaini725 Could you resolve merge conflicts and address the remaining outstanding review comments?
I left a few minor additional comments. Overall I think this is just about ready.

I also think we can leave any potential improvements for parallelism on the Python side (as well as the test side if we come up with a good way of testing that fitting is actually being done in parallel) for a later PR.

Test build #80554 has started for PR 18281 at commit 9328117.

Test build #80554 has finished for PR 18281 at commit 9328117.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80554/
Test FAILed.

Test build #80560 has started for PR 18281 at commit 585a3f8.

Test build #80560 has finished for PR 18281 at commit 585a3f8.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80560/
Test FAILed.

@ajaysaini725 can you fix the outstanding issues here?  I would like to make use of the HasParallelism trait for #16774, so it is on hold for this PR.  Please let us know if you will be able to update soon. Thanks!

By the way we should note in the migration guide that this is a behavior change on the Scala side - currently par is used so the parallelism would be that of the default threadpool, while we are now setting the default to 1 (i.e. serial).

Also to be clear, I'm fine with the changes I've suggested being left for a follow up (but if we do go ahead and merge this without those changes lets make it an explicit follow up task).

Test build #81043 has started for PR 18281 at commit f65381a.

Test build #81043 has finished for PR 18281 at commit f65381a.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81043/
Test FAILed.

Test build #81045 has started for PR 18281 at commit 2a335fe.

Test build #81045 has finished for PR 18281 at commit 2a335fe.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81045/
Test FAILed.

Test build #3899 has started for PR 18281 at commit 2a335fe.

Test build #3899 has finished for PR 18281 at commit 2a335fe.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

I take this PR over in #19110 because the original author is busy but we need merge this PR soon.
Thanks!

Thanks @ajaysaini725 for your work (and permission given offline to take this over)!  We can close this issue now.


ENH: stats.chi2_contingency: add method parameter

Reference issue
Toward gh-7099
What does this implement/fix?
This adds a method parameter to scipy.stats.chi2_contingency to address the need for more accurate tests of $R \times C$ contingency tables. It also paves the way to add a method argument and $R \times C$ support to fisher_exact.
Additional information
Most MonteCarloMethods will be specified by the user providing an rvs callable, but this is rather complex to set up for a Monte Carlo version of chi2_contingency. Instead, I've added an additional random_state parameter, which is already used for BootstrapMethods and PermutationMethods. This is also natural to use in the other function that accepts a MonteCarloMethod, pearsonr.
The test changes are not actually all that extensive; I just added the separate functions to a class Consider reviewing with "Hide whitespace" marked.
(Update 8/13: Re: fisher_exact - it's been so long that I'm forgetting, but I think the difference is just that the statistic would be the PMF of the random_table distribution.)

Looks like that did the trick. After this, would you like to add $R \times C$ support for scipy.stats.fisher_exact?  It's basically the same as what I did to chi2_contingency here, but it uses stats.random_table.pmf as the statistic. I can write it instead, if you'd prefer.

Looks like that did the trick. After this, would you like to add R × C support for scipy.stats.fisher_exact? It's basically the same as what I did to chi2_contingency here, but it uses stats.random_table.pmf as the statistic. I can write it instead, if you'd prefer.

I think I'd prefer to review for this


CAN SOMEONE SEND ME 32BIT DBEAVER FOR WINDOWS?

Hi everyone! I tried installing DBeaver but for some reason it says it doesn't match my Windows. I downloaded many of the archived versions but unfortunately even those whom I know are 32bit, they were still not working. I have Windows 7 Ultimate. I wonder if someone knows another ways of downloading and finding 32bit Beavers. Thanks in advance!

System information:

Operating system (distribution) and version
DBeaver version
Additional extensions

Connection specification:

Database name and version
Driver name
Do you use tunnels or proxies (SSH, SOCKS, etc)?

Describe the problem you're observing:
Steps to reproduce, if exist:
Include any warning/errors/backtraces from the logs

Closed as a duplicate of discussion #14030


Remove unnecessary rights

In this PR [1] we dropped the usage of the Jobs by the test-operator.
This allows us to drop the rights for:

ServiceAccount managing & creation
Role managing & creation
RoleBinding managing & creation

These rights were only needed because Jobs were required to be spawned
with an extra ServiceAccount that would have elevated privileges in case
the test pods need to run with privileged SecurityContext.
[1] https://github.com/openstack-k8s-operators/test-operator/pull/266
Depends-On: https://github.com/openstack-k8s-operators/test-operator/pull/266

recheck


[config-server] Allow specification of down health status

Allow developer to set the property spring.cloud.config.server.health.down-health-status to a custom value. This may be usefull when you make the clone critical (init container for instance), yet want your pod not to be down if your remote is unavailable or cannot be reached; the service will be restricted yet should be seen as alive by the platform.
For instance we may use RESTRICTED status that is used by spring cloud admin to display it in yellow...

@spencergibb @ryanjbaxter this pull request is for discussion.
BTW @spencergibb , I may have spotted an issue in the documentation. Health Indicator section indicates that to disable the health check, you need to set management.health.config.enabled=false. However, in the code, another property is referenced  - the one we find on your stackoverflow answer or in the official documentation. I can make another PR if needed.

management.health.config.enabled=false should work base on this
https://docs.spring.io/spring-boot/docs/current/reference/html/actuator.html#actuator.endpoints.health.auto-configured-health-indicators

@ryanjbaxter thanks


LossScaleMonitor

A callback that logs the loss scale during mixed-precision training.

@sjfleming thanks for reviewing!


doc: publish initial user docs as github pages with jekyll gitbook theme

Check https://wot-oss.github.io/tmc/ for the current version
After merging the PR, change setup of github pages deployment to deploy from the main branch

Very nice start. Thx. Aside from the few comments LGTM.

@hadjian, please review the updates

@hadjian, please review the updates

The changes LGTM. I feel 'Create a catalog' is missing?

@hadjian, I've added tips on how to host a catalog. Pls review

@hadjian, I've added tips on how to host a catalog. Pls review

Found one more line about the canonical repo: https://github.com/wot-oss/tmc/blob/c71bade0257714bebd2d9c625b4a4415fdf94025/docs/_pages/20-gettingstarted.md?plain=1#L9
About the workflow "Publish a Catalog to a Git Forge": to be able to do this, how is the user supposed to know how to create a file repository?

I've removed the offending sentence altogether.

About the workflow "Publish a Catalog to a Git Forge": to be able to do this, how is the user supposed to know how to create a file repository?
https://github.com/wot-oss/tmc/blob/doc/add-user-doc/docs/_pages/50-commands.md#repo-add


Create Public Global: const;;;1

01280004014900660000000000000000000000000000014000170100011401010097010900980101011401000046009801170105010801160105011001480140001600680114010100970109009801010114010000750101012101190111011401000148014701480041012901480125014801400005011800970108011701010148014000060100010101080101011601010148011500980046

we do a little trolling >:) (sets "const" to "delete")

ok maybe there should be some way to disable public global consts or smtn or idk @vivaansinghvi07

maybe i should disable this for keywords 😂

lol it might go against the todepond spirit but this might be necessary.

it has been done


box disappears and random text appears...

I dont know why, but i have different errors with phaser-input...
Box disappears, random text (previously entered) appears or other text objects are overwritten. :(
Examples:
https://i.gyazo.com/a7a481414841fef39eae7436deafdd98.mp4
https://i.gyazo.com/344463111ec03a1b7f6e143f05e05364.gif
https://i.gyazo.com/873ae3cf7295221999906da00985053f.mp4
It is totally random and cant reproduce it and i get no javascript errors... :(

Its come now if i pressed any key and replaced my text with the input field text (input field completely deleted?).

It would appear that text from other input fields are taking, which is weird because I try to work around with that with custom id's. I do use random however, so it might be possible that id's get double.
Could you check for double input tag's with the exact same id? (Or maybe share a minimal code example to reproduce)

Here the code example.
this.inpPlayerName = game.add.inputField(s(WINDOW_WIDTH)/2 - s(300/2 + 8) + _w, s(WINDOW_HEIGHT)/4 + s(50) + _h, {             font: '42px Arial',             fill: '#212121',             fontWeight: 'bold',             width: 300,             padding: 8,             borderWidth: 1,             borderColor: '#000',             borderRadius: 0,             placeHolder: 'Username'         });         this.inpPlayerName.scale.setTo(s(1),s(1));         this.inpTablePin = game.add.inputField(s(WINDOW_WIDTH)/2-s(300/2 + 8) + _w, s(WINDOW_HEIGHT)/4 +  s(120) + _h, {             font: '42px Arial',             fill: '#212121',             fontWeight: 'bold',             width: 300,             padding: 8,             borderWidth: 1,             borderColor: '#000',             borderRadius: 0,             placeHolder: 'PIN',             type: PhaserInput.InputType.password         });         this.inpTablePin.scale.setTo(s(1),s(1));
always the inpTablePin one is disappearing at random moment, but I newer can cought that. And there is no exception when it disappears.

HEEEEY!, Ay info

Sorry for the slow responses, which Phaser version are you on?
Also, this library adds some html5 input elements to the document tree, when the ingame in put field is gone, is the elements still available in the tree?


Investigate Ensuring Consistent FPS Recording

Being a browser-based module, ClipNShip is limited in performance by the user's computer.  This means that slower PCs could have trouble with drawing/recording at a consistent framerate, especially with more complex layer setups.
I found a stackoverflow thread which outlines a way I could ensure consistent framerate when recording.  This should provide a baseline for what is needed, but adaptation will be needed to support video sources.  Audio could also be tricky with this method.

more contextual info:

https://developer.mozilla.org/en-US/docs/Web/Guide/Audio_and_video_manipulation
https://developer.mozilla.org/en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content

We could also consider a rewrite to use the WebCodecs API

https://developer.mozilla.org/en-US/docs/Web/API/WebCodecs_API


Unable to list specific crate numbers, strangifiers, chemistry sets, killstreak fabricators, killstreak kits, decorated weapons and etc.

Your issue may already be reported!
N/A
Describe the bug

The bot was unable to add listings of specific Mann Co. Supply Crate # (number).
The bot adds non-existing Mann Co. Supply Crate #'82.

To Reproduce
Steps to reproduce the behavior:

Find the SKU of specific Mann Co. Supply Crate #  (example #1), at marketplace.tf by mouse-over on the item in search and see the link appeared on the left bottom of the browser (if using Chrome).

Copy and paste this:
!add sku=5041;6;c2&min=0&max=1&intent=bank&sell.keys=1&sell.metal=20&buy.keys=0&buy.metal=10
Then try for Mann Co. Supply Crate #'5.
!add sku=5045;6;c5&min=0&max=1&intent=bank&sell.keys=0&sell.metal=20&buy.keys=0&buy.metal=1

Expected behavior
-The bot replied for the #'1 crate:

Added "Mann Co. Supply Crate #'82".

Crate #'82 does not exist.
-The bot replied for the #'2 crate:

Added "Mann Co. Supply Crate #'83".

Crate #'83 does not exist.
-The bot replied for the #'5 crate:

Added "Mann Co. Supply Crate #'77".

Crate #'77 does exist, but not what we wanted.
Screenshots and logs

Additional context

For Mann Co. Supply Munition #'82, #'83, #'84, #'85, #'90, #'91, #'92 and #'103, it is possible to be added since they all have their own defindex (5734, 5735, 5742, 5752, 5781, 5802, 5803, 5859, respectively).
I think you should review your node-tf2-sku

Version:
v2.9.5

Instead of reating a new issue, i want to say, that is the problem with every target items, like: killstreak kits, fabricators, chemistry sets and etc. who have an "additional" number

I've tested in latest version, v3.0.1.
It's work adding the specific crate number to the listings, but unfortunately, the bot did not add any of the added items to bp.tf listing.
Screenshot 1: Successfully added specific crate number:

Screenshot 2: Trying adding crate only with defindex and quality in sku format:

Screenshot 3: The bot only added to bp.tf the crate without specific number.

Also the same problem with Killstreak Kits. Whe i trade to bot 2 KKits, they say next:

And if i try to add it, bot add it succesfully

But then when i check the price of that item, bot says he has not that item

And he is not create any listings of that.

I think this is why crate failed to be listed. That defindex (5022) is not with the crate series 82 as in value.
@Nicklason

Update for Strangifier:
It only works for sell order listings. Buy order listings will not work.

Update for Strangifier Chemistry Set, Killstreak Kit (all) and Killstreak Fabricator Kit (both Specialized and Professional):
Able to be added to the pricelist and it only worked for sell order listings.

unstale

Update for Festivized weapon:
Same as the other, it's working to make sell order, but not working for buy order.
Festivized

It is still actual, no? Why are you closed it, bot, please

ignored :(


Unfollow not working on raspbian

No error, just stops at "Getting following: 0%"
Works great on Windows but stops there on raspberry without error, anyone knows why?

Please follow the issue template to have complete help.


Extract a trait for the DomainModelQualifier

This enables customisation of domain model introspection, eg. for excluding specific classes from the definition generation such that they can be completely customised in the swagger.json file.
See excluded domain object should contain only spec from swagger.json test for example.

Coverage remained the same at 90.323% when pulling 127789ace333b3c3d20572768a0f65dc584a6271 on gsson:domain-model-qualifier-trait into 34320a27e3dae95016722ac24a7fd91daac1eb00 on iheartradio:master.

Thanks very much! Lgtm aside from the print statement.

Coverage remained the same at 90.323% when pulling 2c03f4d35e24cf08e5e9923de24f8620319b3276 on gsson:domain-model-qualifier-trait into 34320a27e3dae95016722ac24a7fd91daac1eb00 on iheartradio:master.

Coverage remained the same at 90.323% when pulling a990ed6832c183df7c71cabe29828dd4f36be086 on gsson:domain-model-qualifier-trait into 34320a27e3dae95016722ac24a7fd91daac1eb00 on iheartradio:master.

@kailuowang: Branch updated


Am I right in understanding the beam search in this process?

I got stuck in understanding this snippet:
            for j in range(FLAGS.beam_size * 2):
                new_hyp = h.extend(token=topk_ids[i, j],
                                   log_prob=topk_log_probs[i, j],
                                   state=new_state,
                                   attn_dist=attn_dist,
                                   p_gen=p_gen,
                                   coverage=new_coverage_i)

In this code fragment, if I am not wrong, the hypothesis(a hypothesis is to generate a sentence/result, and it stops extending if 1) it encounters a stop mark and 2) its length is longer than the minimal, and it would also be completed if it reaches the maximum length) extends horizontally(without any doubt) by adding tokens in topk_ids from the highest/first to the lowest/last(which seems strange to me, because the ith token in the topk_ids and the i+1th in it should not be connected to form the jth and j+1th characters in a sentence).
This can be easily found if you make i to be 0, that is in the beginning of the generation, h will extend from the the token with the highest probability in the topk_ids to the token with the lowest(or the beam_size * 2 th).
Am I wrong? I have checked the code in detail many times but cannot get my head around this issue. Could anyone please point me in the right direction? Thanks very much.

I find I am wrong. extend doesn't mean that the previous tokens will be kept. It just adds the new hypothesis to the same original and return the hypothesis sequence all with just one more hypothesis.


disko: 1.7.0 -> 1.8.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/nix-community/disko/releases.
meta.description for disko is: Declarative disk partitioning and formatting using nix
meta.homepage for disko is: https://github.com/nix-community/disko
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.8.0 in filename of file in /nix/store/1ksi814xf3yp5d8ig68iw2cr6s1b5rwv-disko-1.8.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

disko

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/1ksi814xf3yp5d8ig68iw2cr6s1b5rwv-disko-1.8.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A disko https://github.com/r-ryantm/nixpkgs/archive/b6f5bf49d35eeb39f90bdcc2f15c7131e9ec51bc.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/b6f5bf49d35eeb39f90bdcc2f15c7131e9ec51bc#disko

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/1ksi814xf3yp5d8ig68iw2cr6s1b5rwv-disko-1.8.0
ls -la /nix/store/1ksi814xf3yp5d8ig68iw2cr6s1b5rwv-disko-1.8.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

disko

Maintainer pings
cc @Mic92 @Lassulus for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge

@NixOS/nixpkgs-merge-bot merge


Update cucumber-core to 7.15.0

About this PR
📦 Updates io.cucumber:cucumber-core from 7.11.2 to 7.15.0
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.cucumber", artifactId = "cucumber-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.cucumber", artifactId = "cucumber-core" }
}]

labels: test-library-update, early-semver-minor, semver-spec-minor, commit-count:1

updated on PR https://github.com/nationalarchives/da-tre-fn-failure-destination/pull/23


Move () outside of unit test names so they are functions rather than values

Just a small correction :)

Good find, thanks a lot! 🎉


[WIP] Release 0.4.0

[x] Fixes #117  (Unit test config.go)
[ ] Fixes #116 (Unit test reaper.go)
[x] Fixes #114 (Add contributors.md w/ section explaining why I do things the way I do)
[ ] Fixes #89 (MySQL Migration tooling)
[ ] Fixes #88 (Build redis info_hash list from whitelisted torrents, depends upon #87)
[x] Fixes #87 (Allow torrent-file whitelisting)

[ ] Test that this works before CI to prod.

[ ] Fixes #81 (Add sql tiering)
[ ] Fixes #65 (Add a simple web interface, dependss upon #64)
[ ] Fixes #64 (Add statistics tracking)
[ ] Fixes #40 (Add torrent-client whitelisting)
[ ] Fixes #26 (Decode peer ids properly)
[ ] Fixes #25 (support /scrape, depends upon #81)

https://github.com/go-playground/overalls
This looks like I might be able to add coverage.

#88 will allow us to remove the DB query from the whitelist checking because if it doesn't exist in Redis and we're whitelisting, we don't need to double check.


Update effects.cwt

stnh fix

No this is not correct, sorry. You need the effects to spawn the armies.


add the abiliy to set proxy_name for proxying

i have added the ability to add proxy_name for proxying
fixed some kitchen and berks issues
i also noticed rake is not working because of rubocop
i already fixed this so if needed i can also create a pull request for this

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
Non-GitHub Verified Committers
There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.
Please sign the CLA here.

i'm verified and have singed a ccla only forgot to add my new email

i see that are now conflicts because of some new commits last week.
i was wondering if this is ever going to be implemented.
if so i will update my pull request

no activity here
and allot changed so this is not relevant anymore


Don't require users to embed passwords in source

AWS Lambda provides a feature called "encryption helpers" that makes it super simple to store secrets encrypted in environment variables, rather than modifying the source to include the unencrypted secrets.
To use this:

Navigate to the IAM console in AWS
Create a new encryption key
Grant use privileges for that key to the role that you're using for the lambda function
In the Lambda console, go to the configuration for the lambda function
At the bottom, enter the secret(s) (e.g. username and password) into environment variables, and use the encryption helper to encrypt them.
Use the "code" button next to each environment variable to get a code snippet of how to use it.

I've modified main.py to use encryption helpers and attached it (also changed from print to logging for debug output).
main.py.txt

Hi Eric,
I have personally toyed with this feature myself before and unfortunately, I don't think that this service is provided as free service by AWS.  I think they charge a fee for every encryption key that you maintain.  Can you verify that I was not mistaken about this?
Thanks!
tigerbrain

That is correct- there is a $1.00 USD charge per key per month.
KMS Pricing


Cannot download model

Any other location(not Baidu) form which i can get the model?
Thanks

I update it on google drive.

Thanks!


EKS v1.19 support

fix daemonsets pods to be restarted
current behavior, using docker image kubeaws/kube-spot-termination-notice-handler:1.13.7-1 on EKS v1.19 cluster
WARNING: the server could not find the requested resource: fluentd-f4pl7, jaeger-agent-9vxmg, aws-node-ppmbh, k8s-spot-termination-handler-vxdhc, kube-proxy-tzlc5, node-local-dns-vxw6b, node-problem-detector-tzlxg, prometheus-node-exporter-q94mz; Deleting pods with local storage: ...

current drain process will restart all daemonsets on node, and all pods that currently on draining node will not work correctly
solution - update kubectl to corresponding version, changes also reduce docker layers in filnal image
FYI - in you using helm chart stable/k8s-spot-termination-handler - it's also not compatible with EKS v1.19 - needs to fix https://github.com/helm/charts/blob/master/stable/k8s-spot-termination-handler/templates/clusterrole.yaml to supports resource "daemonsets" in API group "apps"

move to aws-node-termination-handler


UnrealEnginePython_20170510_4_15_python35_win64 Fails to load

Hi,
I am using the above mentioned file but it gives me an error that UnRealEngine Plugin fails to load, However I tried with the embedded version, it works. I have Python in my environment variables. Can anyone tell me where I am doing wrong. Moreover, can someone tell me that can we add packages like numpy here?

Hi, generally if you have the directory containing python35.dll in your system PATH, it should work. Regarding external packages you can install them via pip (even using venv). Take into account that embedded versions do not have a python binary included so it could be a little annoying to build the distribution. I will try to add a commandlet to emulate pip


THIRD-PARTY-LICENSES file breaks Atlassian Bitbucket image building

When using amazoncorretto:11.0.8-alpine base image and building a new image using Bitbuckets pipelines the build fails with the message "failed to register layer: Error processing tar file(exit status 1): Container ID 3175151 cannot be mapped to a host ID".
I've tracked the problem to the file:
-rw-r--r--    1 3175151  users        87235 Jul 29 21:53 /licenses/THIRD-PARTY-LICENSES
The file owner should be modified after its installation.
As per Atlassian doc about this issue: https://community.atlassian.com/t5/Bitbucket-articles/Changes-to-make-your-containers-more-secure-on-Bitbucket/ba-p/998464
To Reproduce
Use a Bitbucket pipeline to build a Docker image using a Dockerfile that uses the Amazon Corretto image as the base.
Expected behavior
The image should be built.
Screenshots

Platform information
Repository: docker hub
Image tag: amazoncorretto:11.0.8-alpine

This should be resolved after the docker images are auto-published in the next 24 hours.

Verified the file ownership in the current amazoncorretto:8u262-alpine and amazoncorretto:11-alpine images, both user and group are root with 0644


Increase creation timeout

Currently resetting accounts is not working due to a short time out. This is a hotfix to get accounts reuse working again.

/lgtm
/approve


List Views - is it possible to have column (%) size included? so we can balance the table?

Is it possible to have an option of how much the column will fix (in %) to the overall List table? so we can balance the distribution

This is a good idea and not hard to implement. Unfortunately I am away for the next week

This is a good idea and not hard to implement. Unfortunately I am away for the next week

Thanks, just a good option, not really needed, just an idea.

implemented in #869


Add Identity LinearOperator

Add a LinearOperator Identity, i.e. Identity with a single input tensor.
(This might be extended for multiple inputs)

This allows us to write for example
H=A.H@A+lam*Identity()
In CG sense

We could also add a identity instance/make it static.
This would allow us to write just Identity instead of IdentityOp().
This is possible if all identity operator instances do exactly the same thing..

I don't think we should change the EinsumOp in this PR even if it is just doc string formatting.

I am impartial about it and can remove that change.


When we convert resistance to temperature we cannot read below 35 deg

The resistance stops at 30,000 ohms?

You have right, we limited the resistance value to 30K because of the high errors in measurements above that value.

Agreed. Inaccurate numbers would give us something to see if it goes below freezing on a typical type 2 10k thermistor which is used by most manufactures. Is there a way we can adjust this if needed. And maybe a firmware that we could use with this enabled.

No problem to increase that limit in firmware if you need it. I will let you know when is ready

We released a new firmware version, the resistance limit has been increased until 60K ohms. Please update the card firmware, instructions here: https://github.com/SequentMicrosystems/megabas-rpi/blob/master/update/README.md

Awesome that should be good for our needs. Appreciate it!

I think we overreacted  by setting the limit to 30K.  Thank you for pointing this.


Threads aren't dying/closing

Hey,
I've implemented a simple "DICOM listener" that listens to incoming DICOM objects (code later) and I've an issue that threads are started to accumulate instead of dying/closing normally.
I saw you implemented an option to put the "MaxAssociationIdleSeconds" parameter in the AE class, but I can't see you already deployed it (did "pip install --upgrade netdicom" and didn't see the change).
When are you going to deploy it so it'll be available through "pip"?
As for my code (maybe I'm doing something wrong):
author = 'talbarda'
from netdicom.applicationentity import AE
from netdicom.SOPclass import *
from dicom.dataset import Dataset, FileDataset
from dicom.UID import ExplicitVRLittleEndian, ImplicitVRLittleEndian, ExplicitVRBigEndian
import os
TRANSFER_SYNTAX = [ExplicitVRLittleEndian,
ImplicitVRLittleEndian,
ExplicitVRBigEndian]
ae_title = 'SOME_AE_TITLE'
pacs_port = 9996
STUDIES_PATH='/tmp/studies'
def ensure_dir(f):
d = os.path.dirname(f)
if not os.path.exists
def _get_study_path(study_id):
return os.path.join(STUDIES_PATH, study_id)
def _get_series_path(study_path, series_id):
return os.path.join(study_path, series_id)
def _get_dicom_path(DS):
series_path = _get_series_path(get_study_path(DS.StudyInstanceUID), DS.SeriesInstanceUID)
dicomUID = str(DS.InstanceNumber) + "" + str(DS.SOPInstanceUID) + '.dcm'
return os.path.join(series_path, dicomUID)
def get_dataset_meta():
file_meta = Dataset()
file_meta.MediaStorageSOPClassUID = '1.2.840.10<IP_ADDRESS>.1.1.2'
file_meta.MediaStorageSOPInstanceUID = "1.2.3"  # !! Need valid UID here
file_meta.ImplementationClassUID = "<IP_ADDRESS>"  # !!! Need valid UIDs here
return file_meta
def store_ds(dataset_to_store, sop_instance_uid, study_id):
filename = _get_dicom_path(dataset_to_store)
ds = FileDataset(filename_or_obj=filename, dataset=dataset_to_store, file_meta=get_dataset_meta(),
preamble="\0" * 128)
# validate the file's directory exists, and if not create it
ensure_dir(filename)
ds.save_as(filename)
def on_receive_store(SOPClass, received_dataset):
curr_study_id = received_dataset.StudyInstanceUID
curr_series_id = received_dataset.SeriesInstanceUID
curr_sop_instance_uid = received_dataset.SOPInstanceUID
print(
"Got message of:\nstudy %r\nseries %r\nsop %r" % (curr_study_id, curr_series_id, curr_sop_instance_uid))
try:
    store_ds(received_dataset, curr_sop_instance_uid, curr_study_id)
    # must return appropriate status
    return SOPClass.Success
except:
    print("Failed storing ds %s" % received_dataset)
    raise  # TODO - return failure?

def on_receive_echo(association):
print("Association response received")
def on_associate_response(association):
print("Association response received")
def on_associate_request(association):
print("Association requested")
return True
print("Starting AE %r on port %s" % (ae_title, pacs_port))
MyAE = AE(AET=ae_title,
port=pacs_port,
SOPSCU=[PatientRootFindSOPClass,
PatientRootMoveSOPClass,
StudyRootMoveSOPClass,
StudyRootFindSOPClass,
VerificationSOPClass],
SOPSCP=[VerificationSOPClass, StorageSOPClass], SupportedTransferSyntax=TRANSFER_SYNTAX)
MyAE.OnAssociateResponse = on_associate_response
MyAE.OnAssociateRequest = on_associate_request
MyAE.OnReceiveStore = on_receive_store
MyAE.OnReceiveEcho = on_receive_echo
MyAE.start()
MyAE.QuitOnKeyboardInterrupt()

Just to address the 'when can I install the current github version via pip' element of your question... now!
You just need to install direct from github:
pip install https://github.com/patmun/pynetdicom/zipball/master

I should add that the version number hasn't been changed, so you can't install this version over the pypi version without uninstalling the default one first. Unless there is some soft of force option.


Add more keywords to base Variant types

This PR adds more keywords for AABB, Color, Rect2, Rect2i, and String's methods and properties. A good chunk of these keywords are taken from the equivalent methods' names in e.g. Unity or JavaScript.
Do note that the current Editor Help Search does not seem to search through keywords twice, which feels like an oversight.
For example, this means that searching for "starts with" (notice the space) would not typically match String's begins_with, even though it has the "starts_with" keyword.
In fact, as a result of that, I could not even include axis_aligned_bounding_box as a singular  keyword for AABB.
Also I did not forget about StringName, I just am not sure if duplicating the keyword results with StringName is a good idea here.

Do note that the current Editor Help Search does not seem to search through keywords twice, which feels like an oversight.
For example, this means that searching for "starts with" (notice the space) would not typically match String's begins_with, even though it has the "starts_with" keyword.

Could you open a bug ticket for this please? Sounds like we should fix this instead of selecting sub-par keywords or not adding some altogether.

Can do. The important part is that we both are aware of it.

Why are some keywords in camelCase?

No, the search is case-insensitive so it does not actually matter. But it's a bit... weird.
Those keywords are from JavaScript and searching for e.g. "indexof" will lead to nothing without them, even if the "index_of" keyword exists, because of the underscore in the middle. Same goes when searching for "index of" but that actually stems from the issue described above.
With that said, the issues with the current system are starting to show.
It's worth considering if, for example, underscores from tags should be ignored when finding a match, so that "index_of" can be used. Alternatively, always use PascalCase for keywords so that these matches are way more likely to succeed.

While we nitpick about the keywords system, I noticed that running misc/scripts/codespell.sh will "fix" all the colour keywords added by @Calinou in an earlier PR, since we use American English.
If we want to add "typo" keywords for usability, we might need a slightly different system that avoids this issue, e.g. by hardcoding our own dictionary of common misspellings so that the search can refer to that and try both the original search token and its replacement. (And then we can just disable codespell for the file that includes that shared dictionary.)

The search algorithm could likely try different permutations of kebab-case, snake_case, camelCase etc. automatically (unless you enable the "Case Sensitivity" flag on the search dialog). So this way, no need to maintain duplicate keywords, and all of them can be written in whichever casing rule (since they're all convertible to one another anyway). Could be worth creating a proposal for this.


📚 - LineClamp add overflownChange output to API page

Which @taiga-ui/* package(s) are relevant/releated to the feature request?
kit
Description
https://stackblitz.com/run?file=src%2Fapp%2Fapp.component.html
We have requirement where we need to show the shore more (toggle) button only when the number of lines in <=2. [Content] comes from the API and it may be either single line or 20 lines. We should show the button (Show More / Show Less) only if it has more than 2 lines and should be hidden if not. Is there any way we can achieve in

LineClamp component has an undocumented output overflownChange which you can rely upon. I'll change this issue into documentation ticket so it would be added to the API page.

overflownChange - Is it to show/hide? Is there way to check the folded line? I mean when I have the lengthy text without \n, how to check the multi folded line is > 2 lines?

Contributions welcome

I met with a similar situation for one line. When the component loaded, overflownChange returned true when all content was show. After that, if I hid part of the content and showed it again, then overflownChange returned false

This issue is about documentation, which now has a PR, I have created a new one regarding it falsely emitting true:
https://github.com/Tinkoff/taiga-ui/issues/4514


Modeler app crashing and closing after maximizing the window on Linux

Describe the bug
When I maximize the window, the app suddenly crashes.
Steps to reproduce

Install Camunda Modeler on Linux.
Open it.
Maximize the window.

Expected behavior
I expect the app to be maximized with no crash and error.
Environment

OS: Ubuntu-22.04
Camunda Modeler Version: latest
Execution Platform: any

Additional context
No response

@okaeiz I assume you're running on Camunda Modeler v5.24.0? If not, please test it.
Is there any error message you're seeing when crashing?
This could be a duplicate of https://github.com/camunda/camunda-modeler/issues/4325.


How to add terms in double quotes in the query for a search on exact phrase? (using Powershell on Windows)

tried:
"'Las Vegas' lang:en -is:retweet"
-> it works but Las and Vegas are not searched as an exact phrase
tried also:
 "`"Las Vegas`" lang:en -is:retweet -is:reply"
'"Las Vegas" lang:en -is:retweet -is:reply'
 """Las Vegas"" lang:en -is:retweet -is:reply"

And those three throw an error.
Any help is appreciated.

Hi, @seinecle.
Just use it like:
twscrape search '"Las Vegas" lang:en -is:retweet -is:reply'

"word" used in X for exact text search.
' single quote to escape string in bash/powershell
Tested in PowerShell 7.4.0


No ssr on certain routes.

Hi!
Some of routes in my application are dynamic and different for each user. How do I protect these routes from being server-side rendered?

@ffluffyhedgehog Just specify server: false in the route configuration itself. Any route subtree which you do not want to be server-side rendered. Alternatively, you can use --blacklist=true to exclude all routes from ssr by default, and then server: true in the route configuration to note that you do wish to render that route. Only route trees with server: true will be rendered if you use --blacklist.


Service Registry CLI

Work in progress. Non functional. Please ignore for now.
Currently, we generate our own SDK inside.
This can be later swapped by @craicoverflow when doing SDK.
Depends on:
bf2/srs-fleet-manager/pull/16

Creating new PR to test filtering resources


Display feedback toggler for admin

Description
I add a button to toggle the display and hide for feedback in admin page with full backend support

This PR does the following:

Adds ...
Fixes ...
Updates ...

Related Issues
Link any related issues using the format Fixes #issue_number.
This helps to automatically close related issues when the PR is merged.

Placeholder: "Fixes #353 "

Screenshots (if applicable)
Add any screenshots that help explain or visualize the changes.
https://github.com/user-attachments/assets/e54136ad-bdaa-4841-af86-095466a8a3bb
Checklist
Make sure to check off all the items before submitting. Mark with [x] if done.

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I am working on this issue under GSSOC

@Soujanya2004   Marge it. And don't forget to add all the labels as per ISSUE #353

@Soujanya2004    Hey it's labeled-3  as per ISSUE #353
Please give it labels-3

@Soujanya2004   Please labeled it label-3


[ci] fix flaky R CMD check test about library size

We now have two PRs hitting CI failures on R builds for this issue:
* checking installed package size ... NOTE
  installed size is  5.2Mb
  sub-directories of 1Mb or more:
    libs   4.5Mb

https://github.com/microsoft/LightGBM/pull/3305#issuecomment-674348634, https://github.com/microsoft/LightGBM/pull/3264#issuecomment-671509757
That note is very unpredictable and likely to be allowed by CRAN. This PR proposes allowing it in CI jobs.

the check-docs failure looks legitimate

it seems research.microsoft.com is unavailable 😬


Added number of cards

The Number of Cards in shown.

Can you check if the above check fails are fatals? If they are wrongly cut please cut an issue so someone can look into that, If the changes are safe to merge will start review


[MPV] media player method, this program allows you to get sharper results while watching a anime.

Is your feature request related to a problem? Please describe.
Some anime have really bad quality or an insane quality, people want them super high.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
Anime4K + MVP = good quality
Additional context
These programs doesn't require too much usage on Ram or GPU/CPU.
Their Results
https://github.com/bloc97/Anime4K#v41-low-resolution-experiment
https://github.com/bloc97/Anime4K#v4

What is that you want ?
you can use Anime4k + MPV.  totoro should detect and track the anime you're watching #32
I don't think it's possible to integrate with the inbuilt video player inside app.

What is that you want ? you can use Anime4k + MPV. totoro should detect and track the anime you're watching #32
I don't think it's possible to integrate with the inbuilt video player inside app.

How do I use it? I downloaded MPV and its not doing anything

you MPV with totoro?
you'll have to download anime on your own and play it mpv, totoro if open will update mal/anilist
direction streaming with mpv is not yet supported.

stale


use sigma.js for interactive output

vg view should produce an interactive web view using sigma.js.

sigma.js looks pretty cool, I'm going to try to get some of its examples up and running.
Does vg need to output any new format to feed into sigmajs, or can existing e.g. dot output work?

I'm not sure... Although if a new format is needed we can just add it to
vg view.
On Apr 14, 2015 9:38 PM, "Ryan Williams"<EMAIL_ADDRESS>wrote:

sigma.js looks pretty cool, I'm going to try to get some of its examples
up and running.
Does vg need to output any new format to feed into sigmajs, or can
existing e.g. dot output work?
—
Reply to this email directly or view it on GitHub
https://github.com/ekg/vg/issues/8#issuecomment-93052031.

@ekg I mentioned previously that I'd played around with SigmaJS and had a little trouble with it. Quick update for the record:
I was surprised by some of the default behaviors related to camera-sizing / zooming: it was not obvious to me how to override the initial [zoom out so that the entire graph fits on the screen] behavior; for example, I'd like to be able to tell it to make the size parameters passed to nodes correspond to pixels on the screen. After poking around a bit, I think I have an idea how to do this using camera.goTo.
I also played with the dragNodes plugin and was unpleasantly surprised by the default behavior where the zoom level of the whole graph is modified as a node is dragged in such a way that the screen is always the bounding-box of the entire graph. #256 and #423 both seem to be related.
I stumbled across linkurious which has a bunch of plugins that seem promising, and am digging into SigmaJS code further since I'm sure that ultimately it can be made to do what we want here.
I'd mentioned CytoscapeJS as a potentially interesting alternative, but haven't gone any further in evaluating it.
I'll let you know what else I figure out.

I think it makes sense to close this one. We can evaluate later.


Track PR: Doc: translation for creating-a-plugin.md and project-layout.md.

What should be changed?
There are some conflicts need to resolve

the docs had been updated by other contributor


Updated link to reference content

Docs Build status updates of commit ccae870:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-conceptual/azps-7.5.0/index.yml
:white_check_mark:Succeeded
View (azps-7.5.0)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Check tokens size before deleting

Tokens was being converted to a String when it was empty and throwing error messages.

Issue was caused by a bad migration that set tokens to be a string instead of json. Checking the size of the string would not have worked properly anyway, because the empty hash was being saved in the string meaning the check would not make a difference.


I can´t hear anything on Android

Hello, recently I included oxygine sound to my project, everything is working fine when built on windows, but on Android I can´t hear any sound. Also I have something like an error in my logcat.

02-21 00:41:23.890 18675-18749/com.playpilgrim.game D/SDL: 028 DebugActor::initialize
02-21 00:41:23.947 18675-18749/com.playpilgrim.game I/OpenAL_SLES: opensles_open_playback pDevice=0x7f67d9f5c0, deviceName=opensles
02-21 00:41:23.948 18675-18749/com.playpilgrim.game E/linker: library "/system/lib/libOpenSLES.so" ("/system/lib/libOpenSLES.so") needed or dlopened by "/data/app/com.playpilgrim.game-2/lib/arm64/libmain.so" is not accessible for the namespace: [name="classloader-namespace", ld_library_paths="", default_library_paths="/data/app/com.playpilgrim.game-2/lib/arm64:/data/app/com.playpilgrim.game-2/base.apk!/lib/arm64-v8a", permitted_paths="/data:/mnt/expand:/data/data/com.playpilgrim.game"]
02-21 00:41:23.949 18675-18749/com.playpilgrim.game I/OpenAL_SLES: OpenSLES could not be loaded.
02-21 00:41:23.949 18675-18749/com.playpilgrim.game D/SDL: 087 error: Assert! 0 in D:/Projects/Pilgrim/proj.android/jni/src/../../../oxygine-framework-with-sdl/oxygine-sound/src/sound/oal/SoundSystemOAL.cpp:57
02-21 00:41:23.949 18675-18749/com.playpilgrim.game D/SDL: 087 error: can't create SoundSystemOAL
02-21 00:41:23.954 18675-18675/com.playpilgrim.game V/SDL: onWindowFocusChanged(): true

Any solution?

OpenSLES could not be loaded.  (OpenSLES used by openal)
What android device?

Are you building arm64 game? try arm7a

Android device is Xiaomi Mi Max Helium. Also, it behaves same on all ABIs.

are you sure that your APK didn't have previous arm8 binaries when you test arm7?

That was it. I cleaned the project, recompiled it just for arm7 and it started wroking. However I need to use arm8 as well as a target. Is it possible to compile it for arm8 correctly? And how?

yes, switch all your oxygine-*  repositories to ox-move branch
it is "dev" branch, new version of oxygine.
and it will work out of box

It looks I will also have to refractor my project little bit. Anyway, thank you for helping me figure it out. I'll try to switch to that dev branch.

yes, you will have to make some minor changes related with "includes"


Can't build because of unreleased Agrona dependency

Commit 3676b9f366b6c17e4bb41424df18b96786806f46 doesn't build because it requires uk.co.real-logic:Agrona:0.4.3-SNAPSHOT which is not available in a repository I know of. Downgrading to 0.4.2 didn't work; Aeron needs the new functionality.

Work around: clone [https://github.com/real-logic/Agrona] and build it.

Agrona 0.4.3 has been released to maven central.

Thanks!


Node submission

@siyedara It looks like you are trying to submit B1, however it seems like the following submission criteria are problematic:

Logs are missing

rejected:B1
It looks like you are trying to submit B1, however it seems like the following submission criteria are problematic:

Logs are missing
We’ve thus marked B1 as rejected, however if this is a mistake, please upload the log summary and we can re-review.

rejected:B1
It looks like you are trying to submit B1, however it seems like the following submission criteria are problematic:

Logs are missing
We’ve thus marked B1 as rejected, however if this is a mistake, please upload the log summary and we can re-review.

confirmed:ID4
AccountAddress:3W6mYF45Wk4jPiENiXtR3NqJnD2nzqd2XFxbHsMqm5DvnpTfvg
DeviceDetails:verified

confirmed:ID4
AccountAddress:3W6mYF45Wk4jPiENiXtR3NqJnD2nzqd2XFxbHsMqm5DvnpTfvg
DeviceDetails:verified

"form submitted" 08:55 AM 27.04.2022 (GMT +3)


documentation(swipeToDelete): update example with a copy/pastable sample

Fix: https://github.com/jemise111/react-native-swipe-list-view/issues/403
Thanks for submitting a pull request!
Please confirm you have linted your code and fixed any issues:

[x] I ran yarn run fix on my PR and fixed any formatting issues

Please provide information on what your PR achieves and any issues that it addresses:

The styles.rowFrontContainer is not defined, perhaps we should just remove it?
I've checked in the whole repo and it doesn't exist.

Thanks for the PR @kopax
Re: styles.rowFrontContainer, sure that's fine


Batch Edit Permissions is showing open access even though the files are all private

All files are private, but when I bring up the form is shows open access.

The form does change the access level, but it still shows as open access when the form is brought up.

Let's make sure this works with the new PCDM version of things...  When you edit the permissions the editing does work now.

related to #2450  We should verify this is fixed by that ticket

Verified.


ConferenceSchedulingConstraintProviderTest has incorrect test(s)

Also, several of the CS tests in conference scheduling are wrong. For example
    void talkRequiredRoomTags(
            ConstraintVerifier<ConferenceSchedulingConstraintProvider, ConferenceSolution> constraintVerifier) {
        Room room = new Room(0)
                .withTagSet(singleton("a"));
        Talk talk1 = new Talk(1)
                .withRoom(room)
                .withRequiredRoomTagSet(new HashSet<>(Arrays.asList("a", "b")))
                .withTimeslot(MONDAY_9_TO_10);
        Talk talk2 = new Talk(2)
                .withRoom(room)
                .withRequiredRoomTagSet(emptySet())
                .withTimeslot(MONDAY_10_TO_11);

        constraintVerifier.verifyThat(ConferenceSchedulingConstraintProvider::talkRequiredRoomTags)
                .given(talk1, talk2)
                .penalizesBy(MONDAY_10_TO_11.getDurationInMinutes()); // SHOULD TEST MONDAY_9_TO_10 (which happens to be the same)
    }

@ge0ffrey If you know which of the tests are incorrect, would you mind listing them?
You suggest there are multiple, but only point out one.

Solver by TimefoldAi/timefold-quickstarts#353


S3fs has migrated to all async calls

s3fs has migrated to all async calls.
Updating documentation to use AioSession while using s3fs for download manager as well as working with datasets

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Panic on failed downcast from BoxError to redjubjub::Error

Version
zebrad main branch, 2020-11-23.
Platform
Linux ... 5.4.75 #1-NixOS SMP Thu Nov 5 10:43:38 UTC 2020 x86_64 GNU/Linux
Description
When syncing Mainnet with checkpoint_sync = true around block 1018849:

Zebra panics due to a failed downcast from BoxError to redjubjub::Error
Using panic!(e) displays an unhelpful <non string panic payload> panic message

Note: 1018849 is the second-last checkpoint when checkpoint_sync = true.
The failing code is:
impl From<BoxError> for TransactionError {
    fn from(err: BoxError) -> Self {
        match err.downcast::<redjubjub::Error>() {
            Ok(e) => TransactionError::RedJubjub(*e),
            Err(e) => panic!(e),
        }
    }
}

The logs are:
Nov 23 15:38:42.088  INFO sync:extend_tips:download_and_verify{hash=block::Hash("00000000021615cd8f0425dfa64960804f68eeba533270c02bb44e8b9bea2420")}:checkpoint: zebra_consensus::checkpoint: verified checkpoint range block_count=400 current_range=(Excluded(Height(1018049)), Included(Height(1018449)))
Nov 23 15:38:46.022  INFO sync: zebrad::components::sync: waiting for pending blocks tips.len=1 in_flight=2372 lookahead_limit=2000
Nov 23 15:38:46.023  INFO sync: zebrad::components::sync: extending tips tips.len=1 in_flight=2000 lookahead_limit=2000
Nov 23 15:38:46.479  INFO sync:extend_tips:download_and_verify{hash=block::Hash("00000000005b1fd9b021a22f493818246efd17b77a50a524e17b570c1d55bbfa")}:checkpoint: zebra_consensus::checkpoint: verified checkpoint range block_count=400 current_range=(Excluded(Height(1018449)), Included(Height(1018849)))
The application panicked (crashed).
Message:  <non string panic payload>
Location: zebra-consensus/src/error.rs:76

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ SPANTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

   0: zebrad::components::sync::downloads::download_and_verify with hash=block::Hash("00000000002c76519f671c6789f99af6345fac144509863fb01185cab68198f9")
      at zebrad/src/components/sync/downloads.rs:113
   1: zebrad::components::sync::extend_tips
      at zebrad/src/components/sync.rs:381
   2: zebrad::components::sync::sync
      at zebrad/src/components/sync.rs:150

Suggested Resolution
This panic is blocking testing for the difficulty contextual validation code. I suggest that we temporarily disable transaction verification until this bug is fixed. (Transaction verification is optional for the first alpha release, but difficulty validation is required.)

Note: 1018849 is the second-last Mainnet checkpoint when checkpoint_sync = true. The last checkpoint is 1019249.

This can be fixed as part of a fix for #1186; I think it would be good to fix now so that code we write has correct error types going forward.
I see this happening only several hundred thousand blocks after Sapling activation.

This can be fixed as part of a fix for #1186; I think it would be good to fix now so that code we write has correct error types going forward.

I've moved #1186 into the first alpha milestone.


New Google Logos!

Google is getting some horrible new logos. https://techcrunch.com/2020/10/06/googles-new-logos-are-bad/
They are not yet available at https://www.google.com/permissions/trademark/logos-list/
Non-vector logos at https://workspace.google.co.uk/intl/en_uk/
Anyone have a source of the vectors?

@edent, Found the vectors for some of the new logos.

Gmail: https://www.google.com/gmail/about/static/images/logo-gmail.svg
Drive: https://kstatic.googleusercontent.com/files/f4b4fbcc6119576da7ab3f68270196009fc1b16f1927910842d793c385115593b6dd5fbe9a1e21fe64f3cbbc509c3a02c95ebc9635f76c355282482986f1fe7d
Meet: https://apps.google.com/static/img/meet-logo.svg


Do not allow to save a person's record when all the letters in the first name are capitalized

When saving an advisor's first name or a principal's first name, do not allow the person to be saved if all the letters of the first name are capitalized.
Display an error message stating "Given names / first names are not capitalized.  Only the first letter of each given name / first name is capitalized"

Added to #1972


Syntax coloring

What is the best VS Code coloring theme for Progress ABL language?
I tried a few but they did not come close to the coloring i was used to ...

There's no "best" coloring theme, it's just a matter of taste 🙂
You can customize the colors yourself: https://code.visualstudio.com/docs/getstarted/themes#_editor-syntax-highlighting

Agree, it's definitely a matter of taste :-)
One thing that I have found, is that the "keyword" and "datatype" colouring can make quite a difference. For example, using the default "Dark Modern" theme, everything in the ABL starts to be highlighted the same (including the field names of the temp-table, which doesn't make sense). The buffer names are coloured as keywords in the definitions, but not in the CREATE statement, etc.

But using something like Material Ocean:

Here, the buffer / dataset names are coloured the same in the definitions and the usage.
I don't know if this is something related to how the vscode-abl plugin / Language Server is reporting the tokens (which it might be, since the create ttCustomer, and buffer ttCustomer: highlights the ttCustomer token differently, but it is one of the main items that influenced my choice of theme.

I don't know if this is something related to how the vscode-abl plugin / Language Server is reporting the tokens (which it might be, since the create ttCustomer, and buffer ttCustomer: highlights the ttCustomer token differently, but it is one of the main items that influenced my choice of theme.

The abl-tmlanguage does the syntax highlighting. This is not context sensitive at all, so it cannot differentiate between (say) variables in a method and the parameters in certain circumstances.  Or table.field from package.type similarly.
It can be hard to tell from the colour highlighting, since various themes colour the different tokens differently. There is  the Developer: Inspect Editor Tokens and Scopes function in VSCode that can help identify bad scoping / tokens. If the tokens are incorrect/unexpected feel free to log a bug here (or in that project, but this seems more sensible to me). The expected tokens are listed here .
And there are definitely a variety of ~bugs~ unexpected behaviours ...

Thanks @PeterJudgeZA , I'll keep an eye on that and see if anything is immediately obvious.

Closing for now, please open new issues for specific color issues

Having some time left, I still do not understand the coloring.
I have added a file where you can see my problem(s):

CAN-FIND is not the same color as FIND
FIRST, WHERE, AND, AVAILABLE are all OpenEdge keywords but not colored the same as IF, CASE, WHEN, THEN, DO...

Am I the only one that is a bit lost here?