Series fetch issue

querying store failed: receive series: rpc error: code = Aborted desc = fetch series for block 01C18S2S39ZQ4VK43SKVYBRKSR: invalid remaining size 4096, expected 13485
From time to time.

This is on certain query: graph?g0.range_input=2w&g0.end_input=2017-11-23%2013%3A48&g0.expr=go_goroutines&g0.tab=0
(after some time and then 100% reproducible)

This started happening just after you started compaction again?

well not really. I was doing lot's of queries for different things and it started on certain query after some time.. so not sure if there is any correlation with compaction. (new compactor is running 1,5h)

Yes, did you ever see this happen before that though?

nope

I mean this ultimately just seems like some series entries get a good bit longer than the 4KB we expected.
It seems generally possible given we generated a lot of chunks initially with out 5s scrape interval. If you compact a week worth of those together, the series entry has to reference several hundred chunks.
13KB of chunk-indexing data for a single series in a single block actually makes me a bit worried :) But ultimately anything becomes worrisome if you keep the high resolution in long-term storage.
The answer here is basically to just bump the range we fetch per series.

I just hit it as well. It seems indeed to be non-deterministic for the same query over the same time range... that's rather odd though.

Got 'fixed' by bumping the maximum series size we are reading. Anything fully save will require upstream changes to the storage format.

Revisiting this as we saw some issues of violating this again e.g https://github.com/thanos-io/thanos/issues/552
Given just one error, it might still not worth to change.
Just leaving the calculation for max size of series entry:

Max varint lengths: https://github.com/golang/go/blob/master/src/encoding/binary/varint.go#L19
max series entry size in bytes: 10 (max uvarint64) + 2 * 5 (max uvarint32) * a number of labels pairs + 10  (max uvarint64)  + 3 * 10 (max uvarint64) * chunks


Set ai.user.useragent to userAgentOriginal

Follow up https://github.com/Azure/azure-sdk-for-net/pull/37508#discussion_r1261431291

API change check
API changes are not detected in this pull request.


Opening reddit comments thread in Newsboat from feed article

Newsboat version (copy the output of newsboat -v or the first line of git show):
Newsboat 2.32.0
System: Linux 6.4.3-arch1-2 (x86_64)
Compiler: g++ 13.1.1 20230429
ncurses: ncurses 6.4.20230520 (compiled with 6.4)
libcurl: libcurl/8.1.2 OpenSSL/3.1.1 zlib/1.2.13 brotli/1.0.9 zstd/1.5.5 libidn2/2.3.4 libpsl/0.21.2 (+libidn2/2.3.4) libssh2/1.11.0 nghttp2/1.55.1 (compiled with 8.1.2)
SQLite: 3.42.0 (compiled with 3.42.0)
libxml2: compiled with 2.10.4
Config file (copy from ~/.newsboat/config or ~/.config/newsboat/config):
auto-reload yes

bind-key j down
bind-key k up
bind-key j next articlelist
bind-key k prev articlelist
bind-key J next-feed articlelist
bind-key K prev-feed articlelist
bind-key G end
bind-key g home
bind-key d pagedown
bind-key u pageup
bind-key l open
bind-key h quit
bind-key a toggle-article-read
bind-key n next-unread
bind-key N prev-unread
bind-key D pb-download
bind-key U show-urls
bind-key x pb-delete

browser "firefox --new-tab %u"

Steps to reproduce the issue:

Include url for subreddit psot in urls file, i.e  https://www.reddit.com/r/commandline/comments/1533rs5/rumos_cli_utility_for_controlling_screen/.rss

Get the following links along with the article:

Links:
[1]: https://github.com/octagony/rumos (link)
[2]: https://crates.io/crates/rumos (link)
[3]: https://www.reddit.com/user/okloqi (link)
[4]: https://www.reddit.com/r/commandline/comments/1533rs5/rumos_cli_utility_for_controlling_screen/ (link)

Other info you think is relevant:
The key for the comments link would change depending on the post. I tried to take a look at the filters mechanism, but was not fruitful. Only way I could think of viewing the comments of the specific thread would be to copy the comments link, append .rss to the link, and use a macro to pass the link through newsboat?

It looks like the comments url is stored by newsboat on the feed level.
To open it, you need to go back to the list of feeds and press 'o' to open the link in a browser.
Another way to open the comments url (without leaving the specific comment view) is to use a newsboat macro, by using a line like the following in your newsboat config:
macro a set browser "firefox $(echo %F | sed 's/[.]rss$//')" ; open-in-browser ; set browser "firefox %u"

It can be executed by pressing ,a and works in the feed list, the comment lists, and in the articles themselves.
"firefox" is just an example, the trick is to temporarily set the browser to something which cuts of the .rss part, run the open-in-browser command, and then switches back to a regular browser config (you will have to update those parts if you are using something else than firefox).
The %F bit is explained in the Using Browser part of the documentation.
It might make sense for us to add another %<letter> placeholder which expands into the feed url.
That would simplify the macro by not needing the sed invocation.
Relevant place in our code:
https://github.com/newsboat/newsboat/blob/e89dd81e787a43b622b10cef9209f027acd7148e/src/view.cpp#L382-L399
A somewhat relevant issue: https://github.com/newsboat/newsboat/issues/1691 (for me to look into if I would try to make this functionality available in a way which does not require a macro)


Ensure task pods have reasonable execution timeout.

Ensure task pods have reasonable execution timeout.
Perhaps 1 hour. Longer?
Ideally this would be a policy/limit in the pod spec.  This is a safety measure in case other limits/timeouts failing.

Closing for now.  Unsure about the problem being solved.


Wrong reference to nodelist_to_latex func.

Issue
The apply_simplify_repl function within the LatexNodes2Text object references a non-existing function with the name self.nodelist_to_latex.
The issue only appears when parsing a document with the "%" character, as the only references to that non-existing function are within an if "%" in simplify_repl block.
Proposal
There is already a nodelist_to_latex function defined on the latexwalker/__init__.py file.
A simple fix would be to replace:
self.nodelist_to_latex

By:
latexwalker.nodelist_to_latex

Testing
I have tried to parse this ArXiV paper by calling LatexNodes2Text.latex_to_text function before and after the fix.
Where before it crashed, now it does not.

Thanks for noticing this. It looks like the bug only affected certain environments and went unnoticed until now. The method call should have been "self.nodelist_to_text", not "self.nodelist_to_latex". Fixed, will be included in next release.


feat: better default value range and slider for customization

This PR improves the default value range for the abundance metric to use the 5th-95th quantile (instead of min/max forced to 3). Additionally, this PR adds a slider to allow adjusting the value range / quantile range.
https://github.com/OzetteTech/comparative-embedding-visualization/assets/84813279/1b5544b1-50c4-4bb4-a9f0-ba77f3f52268

Oh the distance_key is there to know when the distance calculation can be skipped. Otherwise, the distance is recomputed on every drag of the slider. :)


UI assorted fixes

UI fixes to address missing useful columns and fixes copy console button.
Remove unnecessary copy button on info card that looks congested and confusing.
Fixes #9368
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[x] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI
[ ] test (unit or integration test code)

@blueorangutan ui

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

looks generally good, will test in FF and Chrome.

UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9381 (QA-JID-402)

works in FF and Chrome, but I don't think we need remove the copy console button here:

@DaanHoogland as the copy button isn't what most people want (they could just click the console button), I find that duplicated and  annoying; so only keep the button in the actions button-bar. The info card is supposed for quick/common use-case so console button is still there.


fix kanban-manager, update kanban definition

Coverage increased (+0.01%) to 63.354% when pulling fbc2c6dff46681951efcd98b4372b2e97d809443 on vfenk:dev into f8063f8bc90a4b773b3371c6a3396996cc5fd789 on danliris:dev.


Ensure CRC is using our new dnsmasq

Since #1777, a special dnsmasq instance is created and managed by the
ci-framework.
While most of the testing was done with OCP cluster in mind, we have to
ensure CRC is able to properly consume that new service.
This allows to remove all of the hacks we had in CRC node related to
DNS, making everything really easier for everyone.
As a pull request owner and reviewers, I checked that:

[X] Appropriate testing is done and actually running

/approve


code: -1021 Timestamp for this request was 1000ms ahead of the server's time.

it was fine until for no reason it started saying this
2022-06-12 20:50:23.133[1655059823133] | ERROR | main       | c.m.m.BinanceConnection              - fullErrMessage: {"code":-1021,"msg":"Timestamp for this request was 1000ms ahead of the server's time."}
errMessage: Timestamp for this request was 1000ms ahead of the server's time.
errCode: -1021
HTTPStatusCode: 400
com.binance.connector.client.exceptions.BinanceClientException: {"code":-1021,"msg":"Timestamp for this request was 1000ms ahead of the server's time."}

the time is not given by my code but by the binance-connector-java automatically, how can i fix or override it? i tried by manually setting the timestamp parameter in the linked hashmap parameters like this
parameters.put("timestamp", System.currentTimeMillis());
but it gives me the same error.

ok i solved, it seems to be a System problem, i mean, a machine problem, i just had to sinchronize the time of my computer

AdamPavlik commented on 13 Apr 2021
Library gets time from System.currentTimeMillis(); thats is your machin time, machine time can grift a bit, so you needjust synchronise your time.
for example for windows OS you need just:
a. Click on clock and select “Change date and time settings”.
b. Click on the “Internet Time” tab.
c. Check if it is set to “synchronize the time with time.windows.com”
d. If the option is selected, click on change settings to check the option “Synchronize with an Internet Time server”
e. Click on OK.


chore: add sponsor name for a11y

The Standard Library sponsor on the sidebar is missing the name in the config, which leads to the image on the sidebar to be missing its alt property (https://github.com/vuejs/vuejs.org/blob/master/themes/vue/layout/partials/sponsors_sidebar.ejs#L7). Since the anchor is just that image without any text, having it would improve accessibility.

👍 Thanks!


Missing BigInteger operations

Describe the bug
BigInteger class is missing some operators that would make it closer to the Java big int (since we are looking at kotlin extended java BigInteger as inspiration amongst others).
This issue does not include prime operations, single bit operations or modular arithmetic, which are all also missing at this moment.
To Reproduce
Steps to reproduce the behavior:

Try to find absolute value method in BigInteger class
Fail at finding it

Expected behavior
I expected a abs() method.
Platform

Common

Additional context
Methods to add:

~Power - pow(int)~
Greatest common divisor - gcd(BigInteger)
~Absolute value - abs()~
~Negate - negate()~
~Signum function - signum()~
Square root

Still GCD and SQRT left to do

I created a seperate issue for modInverse: https://github.com/ionspin/kotlin-multiplatform-bignum/issues/14

Everything implemented, currently using naive implementations, but the goal for 0.1.0 is full functionality


Content modifications eibar

Addition of electroanalytical techniques from IUPAC reccommendations 2022 (https://doi.org/10.1515/pac-2018-0109)

A few things to remember:

naming conventions are that class labels (also altLabels) are UpperCamelCase and singular nouns
it's best to make separate pull requests for changes in quantities. The main ttl file reads the quantities file from the main branch.
there were a few concepts that had been duplicated, so please double check that a concept doesn't already exist before creating a new one.


pypi: allow packages in global exclude list if explicitly requested

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[ ] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?
[ ] Have you successfully run brew man locally and committed any changes?

Some python formulae may require packages that are in the global exclude list to function. Allow them to be added if they're explicitly requested.

Review period will end on 2021-01-19 at 14:07:21 UTC.

Review period will end on 2021-01-19 at 14:07:21 UTC.

Review period ended.

Review period ended.


100% CPU usage with rust repos

This looks a lot like https://github.com/atom/atom/issues/6437 -- CPU runs constantly until I disable ide-rust. JavaScript profiler in Atom developer tools show that it is constantly forking.
Repro with Atom 0.21.0 on macOS:
cargo new foobar
cd foobar
open -a /Applications/Atom.app --args "$PWD" "$PWD/src/lib.rs"
watch -n 0.1 'ls -lR'

Repro on Linux:
cargo new foobar
cd foobar
atom "$PWD" "$PWD/src/lib.rs"
watch -n 0.1 'ls -lR'

The watch command at the end will show that it's constantly rebuilding rls dependencies. This appears to be a conflict between file change notification watchers. But I cannot pinpoint the cause beyond these initial steps.
I don't have this problem when opening a parent directory of the rust project. In this case, rls isn't getting built in the project directory, either.

From what I've observed if there is some internal issue in RLS the whole thing explodes like this. The most common issue (for me) is having a line longer than 100 characters.
This is also a problem that we can't fix over here. Please re-open on RLS if you're still experiencing this issue.

Huh strange. This happens with a "fresh" crate template from cargo new and not even editing any of the files. Are you sure RLS is really the problem?

@parasyte Can you try VS Code with the "Rust (rls)" (the official one) extension to see if it occurs there?

@mehcode I updated my nightly toolchain, rls, and ide-rust to 0.4.0 tonight, and now ide-rust is not really doing anything. I thought I was just hitting #6, but rls isn't running in the background.
It seems to be caused by this: https://github.com/mehcode/atom-ide-rust/blob/master/lib/index.js#L188
$ rustup run rls
error: The following required arguments were not provided:
    <command>...

USAGE:
    rustup run <toolchain> <command>...

For more information try --help

Calling rls with rustup run nightly rls or rustup run stable rls works. Patching ide-rust to add the missing parameter gets everything working again as it did before, and I'm still able to repro this bug with the most basic hello-world possible.
To followup, I will try VS Code tomorrow!

Haven't had a chance to try VS Code yet, but ... I enabled debug logging by patching my local copy of ide-rust. When opening any *.rs file with a Cargo.toml in the top-level project directory, I get the following stream of never-ending messages in the debug console:

Expanding the workspace/didChangeWatchedFiles Objects shows that it is watching the target/rls subdirectory, as well as .git/index.lock and similar.
atom-languageclient appears to be triggering rls builds based on with build artifacts being written to the watched directory tree?
When I change the package name in Cargo.toml to anything that is not the same as the project directory name, this death spiral stops. It starts again when I rename the package back to the original value. This seems to break the cycle because the rls build is basically a no-op when the package name doesn't match... It's also an effective workaround for the meantime.

I can confirm. Also, rls stops working after making any edit to a source file (sometimes even inserting a newline makes it stop working).
The problem is not with ide-rust, but with atom-languageclient.
I have patched .atom/packages/ide-rust/node_modules/atom-languageclient/build/lib/languageclient-js:
  didChangeWatchedFiles(params) {
    params.changes = params.changes.filter(c => {
      return c.uri.indexOf('/target/rls/debug/') === -1 && c.uri.indexOf('/target/rls/release/') === -1
    });
    if (params.changes.length > 0) {
      this._sendNotification('workspace/didChangeWatchedFiles', params);
    }
  }

After replacing didChangeWatchedFiles with the patched version, all the issues disappear. Also, ide-rust works much faster now.

@pgkos Thanks for the followup and the patch. I've filed an issue against atom-languageclient directly.

atom-languageclient appears to be triggering rls builds based on with build artifacts being written to the watched directory tree?

No, atom-languageclient is notifying you that something in the file system changed.
Really the rebuild logic in the language server needs to be smarter otherwise you're going to cause rebuilds also for changing .gitignore, readme.md's, project configuration...

No, atom-languageclient is notifying you that something in the file system changed.

@damieng Are you suggesting this is a bug in rls? And if it's a bug in rls then this issue should be reproducible in VS Code, assuming VS Code also notifies the server of every recursive change in the project directory.
The implementation in rls is very simple; it just executes a build action in response to the change notification: https://github.com/rust-lang-nursery/rls/blob/cc07a612682cb77fe9705b49fb79fdfd4587a6c8/src/actions/notifications.rs#L273-L281
I looked at the eclipse.jdt server for comparison, and it uses some business logic in the change handler: https://github.com/eclipse/eclipse.jdt.ls/blob/c0b85986546492ad0f7b73c4678b9bd852ec83bb/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/ProjectsManager.java#L126
Alright, welp, I'll file this against rls  too!

The specification mentions nothing about filters or specific types of files to be watched https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#workspace_didChangeWatchedFiles
That rls implementation is going to recompile for any file change whether it is something that would affect the output or not which seems over-eager.  e.g. readmes, .git, .travis.yml files etc.
It does look like the eclipse language server tries to figure out if it's something worth recompiling for as you say.

@parasyte VS Code's Rust extension does not notify the rls about the changes inside the ./target directory.
I think I may have found the cause: please look at notifications.rs:37 in rls repo. Than function will cause the client to ignore the ./target path, but it is called only after the client (Atom) sends the initialized notification (see the LSP specification), but Atom never sends it.
I have logged all the stdin and stdout of rls when spawned by VS Code. It sends the initialized notification to rls:
{
  "jsonrpc": "2.0",
  "method": "initialized",
  "params": {}
}

This causes rls to respond:
{
  "jsonrpc": "2.0",
  "id": 1,
  "method": "client/registerCapability",
  "params": {
    "registrations": [
      {
        "id": "rls-watch",
        "method": "workspace/didChangeWatchedFiles",
        "registerOptions": {
          "watchers": [
            {
              "globPattern": "/home/pgkos/rust/testproject/Cargo{.toml,.lock}"
            },
            {
              "globPattern": "/home/pgkos/rust/testproject/target",
              "kind": 4
            }
          ]
        }
      }
    ]
  }
}

Also see:
https://github.com/Microsoft/vscode-languageserver-node/blob/master/client/src/client.ts#L1058
https://github.com/Microsoft/vscode-languageserver-node/blob/master/protocol/src/protocol.ts#L1151

The language server protocol at https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md has nothing about registerOptions or watchers.
Either we're coding to the spec or we're reverse engineering vscode...

I've raised a PR to do the server side filtering https://github.com/rust-lang-nursery/rls/pull/534

...and another https://github.com/atom/atom-languageclient/pull/127 to allow filtering client side, which alongside the rls patch is still an optimisation for the client.

Awesome!
@mehcode It's safe to close this issue, now that we have progress being made in the other projects.

The filtering just went out as atom-languageclient 0.6.6 so this package can bump and override behavior.

@parasyte It's probably premature to close this issue - the atom-languageclient change is going to require implementing a method in ide-rust to use the filtering.

@parasyte @damieng Looks like @alexheretic was awesome and added #15 👍

Rls-side filtering rust-lang-nursery/rls#534 has now been merged. So once we merge #15 to eliminate the large & redundant client-side messaging we shouldn't be suffering from this issue at all.


[dataloss] Support undo of deletion

It's very easy to delete (z) when you want to extract (x).

I have written the code to support undo for deletion as well as highlighting. I am planning to update the add-on tomorrow.

This is done. Press u to undo any changes.

Works, thanks!


Transfer: How to link PyPI?

@jpscaletti
How do we fare about the uplink of this repo to PyPI?
After all, people will want to be able to install copier via pip I presume.
Do you have got any idea/instructions on that part of the transfer?

@jpscaletti Whilst I co-maintain packages listed on PyPI this is going to my first own package there.
I am going to open an account and let you know.
I am busy right now but I will do it no later than Sunday.

Sure, just let me know.

I a have just opened an account on PyPI:
https://pypi.org/user/pykong/

Congrats 🎉  You are now the owner.
You can remove me now (I can't remove myself).

Got the project on PyPI. I have removed you.
Closing this issue.
Thanks!


how to setup proxy

Hy guys, is there is a way to setup a proxy, problems with conexion. thanks,

sorry, what do you mean?

I had problems with conexion, but nothing to do with proxy, my mistake. I cloned the program again, and it worked. tx.


Documentation and Examples

Do something more comprehensive than the readme?
Mdoc?
https://scalameta.org/

Started, won't do more unless someone displays interest!


Support meta main yaml extension

Related to https://github.com/ansible-community/molecule/issues/3849
Reference: https://github.com/ansible/ansible/pull/46505

Weird, I have version 24.5.1 of ansible-compat installed, but molecule still refuses to handle .yaml.


CircularBalloon with only one branch overlays the objects

The Y coordinate gets set to zero for all children/grandchildren, etc.

Sorry, that wasn't the problem

This looks like a duplicate of #2650 (which was retracted by the author… I haven’t had time to investigate why). Appears to be a fix for #2646, also.

Ok, I also put in a fix for his and vylan's "root only node" problem.

Thanks @jfrickson , I 've tested with your code. I believe it fixed the issue. by the way, please change seq2 to sep2.

Should be good to go!

I’ve pushed a slightly simpler fix in d3/d3-hierarchy@68055b9d22b2b1f002fd2cc1995238cbb778f644 for 4.0. In the case of a single-branch tree, the left- and right-most node is always the root, and I think it’s best to avoid invoking the separation function when a and b are the same node (the root); in that case, we can simply center the tree within the layout area.
I’m probably not going to back-port the fix to 3.x. A simple workaround is to not return Infinity from the separation function:
function separation(a, b) {
  return (a.parent === b.parent ? 1 : 2) / Math.max(1, a.depth);
}


example does not run as expected

the example starts the server ok and im able to get there with a browser(chrome) and even move things around, but if i try to click an edge i get an error on the python side:
Traceback (most recent call last):
  File "C:\WinPython-64bit-<IP_ADDRESS>Qt5\python-3.6.3.amd64\Lib\site-packages\tornado\websocket.py", line 494, in _run_callback
    result = callback(*args, **kwargs)
  File "C:\WinPython-64bit-<IP_ADDRESS>Qt5\python-3.6.3.amd64\Lib\site-packages\transitions_gui\handlers\__init__.py", line 37, in on_message
    self.machine.process_message(message)
  File "C:\WinPython-64bit-<IP_ADDRESS>Qt5\python-3.6.3.amd64\Lib\site-packages\transitions\core.py", line 1102, in __getattr__
    raise AttributeError("'{}' does not exist on <Machine@{}>".format(name, id(self)))
AttributeError: 'process_message' does not exist on <Machine@2978679876352>

This issue went stale. I will close this issue. If it still persist, feel free to comment and I will reopen the issue if necessary.


add a few more useful commands for easier onboarding

When I was setting up ssh access I had to use these commands, I think they are useful as suggestions.

I made the changes.

"changes."
Looks pretty funny in our above comments.
Sorry for this spam comment I couldn't help it 😔.


Docker image

Can you build a docker image with the current develop and push it to docker hub please.

its already here: https://hub.docker.com/r/buildkite/puppeteer

All fixed!


Fixed error on basemaps URLs

reviewer @xavijam
close #6059
Invalid space within the basemap urls.

Yay! :) :+1:


[Bug] Can't store IPv6 address decimal data for decimal length is not enough

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
v2.0.1
What's Wrong?
Currently the maximum number of Decimal type integers supported by Doris can only be 38.
We hope to store the digital form of IPv6 addresses through Doris, which will cause the data to be stored incorrectly.
After browsing the Decimal type of the ClickHouse database, the Decimal type can support up to Decimal256(S), which can effectively solve the storage problem when the value is large.
What You Expected?
The precision of the integer part of Decimal can at least support the length of the number corresponding to the IPv6 address.
How to Reproduce?
Documentation about Decimal type and practice have confirmed that when the Decimal precision is specified as DECIMAL(38, 0), the value corresponding to the IPv6 address (2409:8087:574C:14:1000::49) cannot be saved.
Anything Else?
No response
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

IP type is already supported
https://github.com/apache/doris/pull/24965


"Couldn't recognize the image format for file" on big-endian (PowerPC 32-bit)

I have compiled libjxl (with libhwy built with SIMD instructions disabled) on my Powerbook G4 running Debian. The library works fine on my little-endian systems (x86, ARM) but fails on the big endian one. The standalone cjxl and djxl tools are working on the powerbook, so I know that my library build is functional.
My error (in MComix3, but my own fork that has imports for jxlpy in appropriate locations) is [ImageHandler] ERROR: Could not load pixbuf for page <n>: GLib.Error('Couldn't recognize the image format for file ""', 'gdk-pixbuf-error-quark', 3)`.
My guess (without looking at the code) is that the library is doing a 'magic word' check for some hexadecimal number, which has the bytes in opposite order on big endian hardware.
I think that something like what's being done here may be in order? Not really sure.

Hi, thanks for opening the issue!
For the last couple of days I've been trying to compile libjxl on PowerPC 32-bit using Debian 10 port running QEMU. Sadly I ran into some really weird compilation errors while building it. May I know how did you succeed with that? So far I wasn't able to reproduce your issue :(
Honestly I've never used PowerPC architecture before...
If I were you, I would look in 2 places: where I assume that the image is native endian (this is based on imagecodecs implementation) and in the Pillow accept function.
Sometimes Pillow's behavior is weird so that if there's an error trying to load the image, it would say the image isn't recognized.
If there's a problem with magic word checking, can you please look at the hex view of the image you're trying to open and see if it's really different than in the _accept function?

Yeah, to build libhwy I had to do it with all SIMD support turned off; I also had to comment out the lines in the libjxl makefile relating to some submodule of it that depends on node.js somehow or another - since Blink/V8 still doesn't care about ppc32. It's totally unnecessary to make a working jxl library (tested with cjxl and djxl), so I'm not sure why it's burned into the makefile.
I'll try to hop on the powerbook sometime soon to get a more concrete description of what I did; I'll also try what you said. I need to sleep now, though.

Hey again, quickly before bed I just ran git diff on my sources on the powerbook. They're for older git revisions (see the contents of the patch files for the hashes).
These worked on my Debian Sid installation.
patches_highway_jpegxl.zip

Hi and thanks for patches :)
Lastly I've successfully installed libjxl and jxlpy on my ppc32 Debian. Unfortunately I wasn't able to reproduce your issue.
On my machine everything works fine (tested all scripts in examples/ directory and decoded some images with no problems).
Can you please try running examples yourself to see if there's a problem with them and if you can, you may provide me the image which your code is failing with?


 Also, consolidate the two
copies of the same code into one module.
Fixes #617

Pull Request Test Coverage Report for Build 1982

7 of 53 (13.21%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.2%) to 67.418%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

routes/my_api.js
2
3
66.67%

routes/thingengine_ws.js
2
6
33.33%

routes/cloud-sync.js
3
44
6.82%

Files with Coverage Reduction
New Missed Lines
%

routes/my_conversation.js
1
66.37%

Totals

Change from base Build 1981:
0.2%

Covered Lines:
6898

Relevant Lines:
9608

💛  - Coveralls


Adding Homebrew Installation

Thanks for the PR. Aren't you supposed to make a PR in the https://github.com/Homebrew/homebrew-core instead, as mentioned in https://github.com/aome510/spotify-player/issues/189#issuecomment-1537426696?
Also, let's wait for the new release with M1 binary support in release (https://github.com/aome510/spotify-player/issues/191) before adding a Homebrew support

I'll do that as well, the merging sometimes takes a while so using the tap works in a similar manner

https://github.com/Homebrew/homebrew-core/pull/128997

Close this for now as https://github.com/Homebrew/homebrew-core/pull/128997 is merged. Thanks @tresni.
I did try installing the app using brew install spotify_player and it works perfectly!


ci: move to GitHub Actions

I'd like to contribute the the HTSInfer repo too.
I see you are still running on Travis, I could transfer the CI to GH Actions. I like setting up CIs, I do this for fun :)
Would you like that @uniqueg?

Absolutely - thanks a lot


New contributor has added 1 facility. The total facility count has gone up by 3.

Overview
A new contributor, Andrew Rogers, joined the site on 8th Jan. He uploaded one facility to the site. However, the total facility number on the site has increased by 3 from 69,374 to 69,377 from w/e 6th Jan to w/e 13th Jan. See "Weekly facility numbers" tab for tracking here: ****
As far as we can see (and our access is limited) no other contributors have uploaded facilities during this time, which suggests that the the addition of this one facility has created three entries.
Expected Behavior
The total number of facilities on the site should only have increased by one.
Actual Behavior
It appears that the addition of one facility has created three new facilities on the site.
Steps to Reproduce

Filter site by Contributor -> Andrew Rogers
1 facility is returned
Note that total number of facilities on the site is 69,377
Using the site on Chrome on a 2017 MacBook Air

Additional context
We are aware of this issue on the site already, but thought this new occurrence might be a helpful one to dig into!

I'm closing out some old issues which have either been addressed or have been superseded. I believe we generally fixed this bug while rewriting the API.
I'm going to close this issue, but if we observe the bug again we can re-open it.


Document missing hidden filed

also validation on crud

@serverfire Documention of Validation of crud fields is added.


Hexen 2: Add armhf and x86_64, update port.json, gamelist.xml, and scripts

Add support for armhf and x86_64
Fix cfg not loading on muOS
Update gameinfo.xml
To clarify the config not loading, the symlink to the conf folder was being created as it should, but would still fail to either find or read the contents of the $home/config directory.  Hexen 2 doesn't have a command line option to point it directly to a custom config folder like blake stone does, but does use the autoexec.cfg method that all the Quakes have support for.  By having the script copy the existing config.cfg to the game's autoexec.cfg worked like a charm.  Any OSes that don't have issues with the home folder will still allow users to make and keep changes as it will copy them from the config.cfg file from the last time the game was run so the user won't lose those settings.  This only won't be true for muOS atm.

Sorry, @Cebion.  I see you had approved it for me already.  It's all set and ready to go now this time for sure 👍


Managed namespace: Try setting talksToHsm as a quoted string

Currently although it looks like a boolean we are getting
for: "manifests/gsp-cluster/templates/00-aws-auth/managed-namespaces.yaml": unrecognized type: string
Chris thinks this might work.

oh god not this again


Dem contact models

This PR fixes a small bug in particle-particle contact force calculations. Before, the tangential relative velocity from the previous iteration was used to update the tangential overlap in the current iteration. Furthermore, now the DEM solver calculates the tangential torque using the radius of each particle present in a contact, so the exerted tangential force on two particles with different sizes in a contact will be different. Finally, some of the application tests are modified to test the linear contact model and viscous rolling friction model.

I have added two additional contact models (Hertz-Mindlin with limiting the tangential force, and Hertz models). In the first model (Hertz-Mindlin with limiting the tangential force), the tangential force is limited if gross sliding occurs. In the second model (Hertz) the damping force is not included in the tangential force calculations and the tangential force is limited.
All the comments are applied/answered.

All the comments are addressed. pp and pw are changed to particle-particle and particle-wall all over Lethe.


Implement a subtitle synchronizer

Sometimes subtitles are out of sync.
We need an add-on that will let the user add delay inside the srt file.

+1


To avoid ambiguity, please specify that this is only a Python client and cannot be self-hosted.

That is all

Okay, I just added an explanation. Thanks


Desktop. Case study page. Contact form is not centered

WTR:

Go to case study page(Clients=>View case)
Pay attention at contact form

Result: Contact from is not centered
Expected result: Contact form is centered

Fixed


magicblueshell crashes after firing the second command on a raspberry pi

After starting magicblueshell, connecting to my Magic Blue Bulb and firing the second command, magiblueshell hangs for a while and stops without any further output.
Hardware / Software
Raspberry PI Model B Revision 2.0 256 MB
pi@raspberrypi:~ $ python --version
Python 3.4.2

pi@raspberrypi:~ $ lsusb
Bus 001 Device 004: ID 0a12:0001 Cambridge Silicon Radio, Ltd Bluetooth Dongle (HCI mode)

Execution
pi@raspberrypi:~ $ sudo magicblueshell
Magic Blue interactive shell v0.1
Type "help" to see what you can do
> connect DE:0C:59:91:F3:81
INFO:magicblue.magicblueshell:Connected : True
> set_warm_light 0.1
> set_warm_light 0.5
*** WAITING FOR 5 SECONDS **
pi@raspberrypi:~ $

Do you have any idea why this happens?

You can try to connect using GattTool (How to use manually with Gatttool) to see if you get disconnected after the second command.
If this is the case then there's probably a compatibility problem with your bluetooth device
It may also be a problem with bluetooth library (libbluetooth-dev).
I can't investigate further, I'm moving out of the country in a few months and right my bulb is thousand miles away from me... unfortunately bluetooth 4.0 isn't that powerful!
Good luck, keep me in touch if you find anything

Hey Betree,
Thanks for your fast response. I tried and it works like charm!
gatttool -i hci0 -b 'DE:0C:59:91:F3:81' -t random -I
[DE:0C:59:91:F3:81][LE]> connect
Attempting to connect to DE:0C:59:91:F3:81
Connection successful
[DE:0C:59:91:F3:81][LE]> char-write-req 0x000c 56FFFFFF00f0aa
Characteristic value was written successfully
[DE:0C:59:91:F3:81][LE]> char-write-req 0x000c 56FF000000f0aa
Characteristic value was written successfully

Do you think it might be the pygattlib? I would appreciate any further help with this!

Not so far away from you actually, I'm moving to New Caledonia :)
Gattlib hasn't been updated since I last tested it so I doubt it came from this lib. Maybe a difference in libbluetooth-dev version ? I can't tell which one I use to have installed, it would be nice if someone who has a working installation can provide the info.
Another possibility is that they changed some stuff in the bulb API in the newest versions (i bought mine around September 2015).
It can also be a bug in my code but again I can't really test it right now.
So, what can you do ?

Try on a Linux PC
Go deeper and modify the python script. @b0tting added some very interesting details about the bulb protocol ont the wiki page that I haven't tried to implement yet. He also started a project you may use as reference (doesn't use this lib but the implementation is very similar)

I had the exact same problem on the same platform (Raspbian, RPI-B 256mb). Adding more pauzes between commands seemed to lower the freezing frequency, but my scripts remained unstable. The issue was with the pygattlib and was beyond my technical capabilities. I could not use Benjamin's library and had to fall back to running shell commands, which have not failed even once.

Thanks @b0tting for the reply! I found a solution. I switched to bluepy python interface (https://github.com/IanHarvey/bluepy). Using this library solved the problem. I could change the current code to use this library. @Betree: Would that we okay?
import bluepy.btle
bulb_id = 'DE:0C:59:91:F3:81'
p = bluepy.btle.Peripheral(bulb_id, bluepy.btle.ADDR_TYPE_RANDOM)
p.writeCharacteristic(0x000c,b'\xCC\x23\x33',True) #TURN ON
p.writeCharacteristic(0x000c,b'\xCC\x24\x33',True) #TURN OFF

Bluepy looks a lot more maintained than pygattlib, that seems great !

@Betree alright, I am going to update your code to the bluepy project on the weekend :-)


fix(deps): update terraform-module

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/cbr/ibm (source)
module
minor
1.22.2 -> 1.23.0

terraform-ibm-modules/event-notifications/ibm (source)
module
patch
1.6.5 -> 1.6.7

terraform-ibm-modules/secrets-manager/ibm (source)
module
minor
1.14.1 -> 1.15.0

Release Notes

terraform-ibm-modules/terraform-ibm-cbr (terraform-ibm-modules/cbr/ibm)
v1.23.0
Compare Source
Features

Ability to add optional location for each serviceRef when creating zone (#457) (3142064)

v1.22.3
Compare Source
Bug Fixes

update required ibm provider version to >= 1.65.0, < 2.0.0 to ensure fix for known provider issue is included (#467) (2e9cff1)

terraform-ibm-modules/terraform-ibm-event-notifications (terraform-ibm-modules/event-notifications/ibm)
v1.6.7
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/cos/ibm to v8.5.2 (#238) (993db8e)

v1.6.6
Compare Source
Bug Fixes

updated CBR module to 1.23.0- updated required ibm provider version to >= 1.65.0, <2.0.0 (#236) (66512d2)

terraform-ibm-modules/terraform-ibm-secrets-manager (terraform-ibm-modules/secrets-manager/ibm)
v1.15.0
Compare Source
Features

added support to the DA for use case where KMS is in a different account by adding new optional variable ibmcloud_kms_api_key (#147) (20c16a9)

v1.14.3
Compare Source
Bug Fixes

added a sleep to workaround timing issue when creating Event Notifications topic with a newly provisioned Secrets Manager instance (#152) (ac214a2)

v1.14.2
Compare Source
Bug Fixes

deps: update terraform-module (#150) (4008189)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This issue has been resolved in version 1.17.4 :tada:
The release is available on:

GitHub release
v1.17.4

Your semantic-release bot :package::rocket:


exclude slf4j-nop from geopackage to avoid SLF4J warning

Planetiler from current main is complaining a little bit:
SLF4J(W): Class path contains multiple SLF4J providers.
SLF4J(W): Found provider [org.apache.logging.slf4j.SLF4JServiceProvider@49097b5d]
SLF4J(W): Found provider [org.slf4j.nop.NOPServiceProvider@6e2c634b]
SLF4J(W): See https://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J(I): Actual provider is of type [org.apache.logging.slf4j.SLF4JServiceProvider@49097b5d]

This PR fixes that by excluding org.slf4j:slf4j-nop from mil.nga.geopackage:geopackage.

Note: As per SLF4J's recommendation, I've also reached out to the relevant component project and filled a bug-fix report, see:

https://github.com/ngageoint/geopackage-java/issues/62

So either we update to fixed newer version or merge this.

Thanks! I just started noticing this too but wasn't sure where it was coming from.


[engsys][formrecognizer] upgrade dependency magic-string to ~0.30.10

Packages impacted by this PR
@azure/ai-form-recognizer
Issues associated with this PR
#24124

API change check
API changes are not detected in this pull request.

Same form recognizer failures in main due to test proxy/recorder changes.

/check-enforcer override


Handle cam track ended event

Description
Summary:

monitor cam track for ended event
set delay for turning of cam to 0 ms when disabling cam and the track has ended

Related Issue:

Testing

Screenshots/GIFs (if applicable)

Checklist

[x] My code follows the project's coding standards.
[x] Prefixed the PR title and commit messages with the service or package name
[ ] I have written unit tests (if applicable).
[ ] I have updated the documentation (if applicable).
[x] By submitting this pull request, I confirm that my contribution is made
under the terms of the MIT license.

Additional Information

/canary

/canary

same testing instructions as this one?
https://github.com/whereby/pwa/pull/4121

same testing instructions as this one? whereby/pwa#4121
Yes.


Improve performance of maxBytes()

I'd like to use maxBytes() to help prevent certain types of abuse sending large amounts of data to clients in order to overload them. This makes it fairly important that maxBytes() is as fast as possible and is not itself a bottleneck if someone attempts to send hundreds of megabytes of data
Before:
Since the current implementation will always read all of the bytes of the string, there is no significant difference between size limits enforced

input/limit
any size

1B
1’894’455.1

5MB
1’507.1

50MB
150.1

500MB
13.4

max
12.5

All values are operations per second, tested on an 2021 Apple M1 Pro MacBook Pro.

After: (ops/sec)
Caching Uint8Array speeds up 1B inputs by about 30x, and because this new implementation stops reading/writing N+4 after the maxBytes requirement, the performance is more dependent on the requirement than the input itself

Note: It needs to read past the requirement to test if the string is too long, the +4 bytes is because the next character in the string could be anywhere from 1-4 bytes, and encodeInto() will drop it if there's not enough room in the array.

input/limit
<=5MB
<=50MB
<=500MB

1B
30’240’582.3
31’011’981.5
30’389’671.3

5MB
6’611.1
7’095.6
7’071.8

50MB
6’736.9
551.4
498.7

500MB
6’685.8
547.4
51.6

max
6’318.7
538.0
51.5

All values are operations per second, tested on an 2021 Apple M1 Pro MacBook Pro.

Thanks for the catch! Why would you prefer to use maxBytes instead of maxLength?

It just tends to be how we specify things. JavaScript strings are UTF-16 encoded, but many languages default to UTF-8 encoded (Rust, Swift, Golang, Ruby, etc). If you don't check these in an encoding-aware way, you end up with strings that are allowed to be different lengths depending on the language you are checking them in.
Aside: I've also opened an issue in the whatwg/encoding standard to suggest a faster method for this https://github.com/whatwg/encoding/issues/333

You can actually make this even faster by avoiding calculating the specific number of bytes when possible:
if (dataset.value > maxBytes) {
  // The minimum number of bytes is already too long
}

if (dataset.value * 4 <= maxBytes) {
  // The maximum number of bytes is already small enough
}

You can actually make this even faster by avoiding calculating the specific number of bytes when possible:

Can you provide more details? When does this work? In general, how should I proceed with this PR? What is your recommendation?

Sure, let me give you some context:
Encoding is expensive
Strings in JavaScript are sequences of UTF-16 code units.

In UTF-16, each character is 1 or 2 code units (2 or 4 bytes)
In UTF-8, each character is 1 to 4 code units (1 to 4 bytes)

Converting a sequence of UTF-16 code units to UTF-8 code units is relatively expensive operation that involves a fair bit of math, but right now it's the only way to calculate the UTF-8 byte length of a string in browsers.
It's much faster to calculate just the number of bytes in a string because you can skip the work to convert them into their specific values and just match UTF-16 ranges to byte values. This is the primary reason why functions like Buffer.byteLength(input) are much faster than new TextEncoder().encode(input) (besides not needing to allocate more memory).
But since that's not an option on the web, you could at least avoid encoding the entire string, and only check if it's too long, which is what this PR does with encodeInto()
Skipping encoding when possible
You can optimize this even further by avoiding encoding at all with a little bit of knowledge about how UTF-16 code units get converted to UTF-8 bytes.

Char
UTF-16

UTF-8

UTF-16 units to UTF-8 bytes

'a'
0061
(1 units → 2 bytes)
41
(1 units → 1 bytes)
1 → 1 (min)

'¢'
00A2
(1 units → 2 bytes)
C2 A2
(2 units → 2 bytes)
1 → 2

'ก'
0E01
(1 units → 2 bytes)
E0 B8 81
(3 units → 3 bytes)
1 → 3 (max)

'𝄢'
D834 DD22
(2 units → 4 bytes)
F0 9D 84 A2
(4 units → 4 bytes)
2 → 4

The conversion ratio of UTF-16 code units when encoded in UTF-8 is 1-3 bytes.
So without having to encode anything, we can know that the max and min possible byte length for any JavaScript string just by doing:
let MIN_UTF8_BYTES_PER_UTF16_CODE_UNIT = 1
let MAX_UTF8_BYTES_PER_UTF16_CODE_UNIT = 3

let min = string.length * MIN_UTF8_BYTES_PER_UTF16_CODE_UNIT
let max = string.length * MAX_UTF8_BYTES_PER_UTF16_CODE_UNIT

Not needing to encode anything will speed up the vast majority of usage of maxBytes()
Optimized Solution
This is a slightly updated version of the current PR which is currently the fastest option for asserting that a string is under a certain UTF-8 byte length:
let encoder: TextEncoder
function maxBytes(bytes: number) {
  let array: Uint8Array
  return function check(input: string): boolean {
    if (input.length > requirement) return false
    if (input.length * 3 <= requirement) return true
    encoder ??= new TextEncoder();
    array ??= new Uint8Array(bytes);
    let read = cachedTextEncoder.encodeInto(input, cachedUint8Array).read
    return read <= input.length
  }
}

Problem
The only problem is that this doesn't give you a received value of a specific byte length. The only reason that this is fast is because it gives up computing the exact length of the string once it's past the limit.
If you're okay with dropping the received value from the issue that this adds, you could use this more optimized version

Thanks for the details! I now understand the problem and possible solutions much better. I am not sure what to do. We use the expected and received pattern everywhere. So I am not sure if we should do an execution here. On the other hand, of course, I see the downside that this could be abused by sending extrem long strings to the server.

Some options:

Drop received
Make received an estimate `${string.length} to ${string.length * 3}`
Make received an estimate only at larger sizes
Make received the UTF-16 bytes `${string.length * 2} UTF-16 bytes`
Add an option to disable received

I think at the moment I prefer to wait until more developers encounter this problem to get more feedback on how to proceed. In the meantime, as a workaround, you could implement a fastMaxBytes action yourself for use in your own schemas.


Added deprecation notice for EngineBlock 5.x range

The tests provided by EngineBlock teststand have been embedded within the 5.x range of EngineBlock. This means that this project should no longer be used from the first production release of EngineBlock 5.x onwards.

@relaxnow Just a warning, wording could be improved though...


Add “timeout” status for regression tests.

The “timeout” status skips tests on CI, but runs them locally.
It will also tell you if a “timeout” test should be changed to some “lesser”
failure, and vice versa.

@drostron, @rabbitonweb, @wemrysi – I added you all as reviewers since you’re the ones who will likely run into some unexpected failures when you first try this locally.
You’ll probably get some failures with messages like change “timeout” to “pending”. This is to help us run as many tests as possible on Travis. If they’re not timing out, we should run them. And we should only use "skip" when either 1. the query is crashing the process or 2. it’s a connector-specific test (and those should hopefully go away as well).

With this new status we should be able to remove all the notes in the integration tests that say things like "This test is skipped on X because it times out."

@alissapajer Good point – and that already shows me some couchbase ones that should be made pending.

@sellout also, how are you updating the newTests.data and oldTests.data files? Also, what is the difference between the two? It would be really cool if one of those could be kept up to date with our actual regressions tests via a script, and then we could write meaningful queries like "how many tests are timing out for couchbase".

I’m not updating those data files. I considered keeping them up-to-date, but decided against it, because it doesn’t really matter for the tests and would just make them break. I think we can update them manually (find . -name ".test" -exec tr …) periodically if they no longer reflect the structure.
We should be able to use the spark-local connector via the REPL to write queries against our tests, no? Or importing them into whatever other data store using our import scripts.
oldTests is from master and newTests is from the new Mongo branch, since I was originally trying to figure out where things differ as I work on new Mongo.

@sellout yeah, thinking about it I agree it doesn't make sense to change the test data frequently because then tests will break. And we can always query the data files locally to ask real questions. It doesn't matter if integration test questions and answers are accurate in that sense. So :+1:


Upgrade to 6.1.y kernel?

https://github.com/starfive-tech/VisionFive2/releases/tag/VF2_v3.7.5 advertises support for 6.1.31. Could we do that?

I've given it a try, but unfortunately, Linux kernel version 6.1 from StarFive is still plagued with numerous bugs and incomplete features. For instance, in the arch/riscv/lib directory, there's no memcpy.S, only memcpy_aligned.S. However, various parts of the Linux kernel still expect to link to memcpy, not memcpy_aligned. I attempted to fetch memcpy.S from the mainline and make changes to the string.c file to use it, which allowed the kernel to be built and run. But, there's still an issue during reboot, causing the board to freeze for an extended period before the watchdog intervenes and forces a reboot. I'm planning to wait for the next release and test it again.

Too bad and yes I have observed that the Starfive code is particularly low-quality, lots of use-after-frees (luckily detected by kfence) and that kind of thing. Maybe they should have written the driver in rust :stuck_out_tongue:


[docs] change /svelte/ to username placeholder for the opt-in link

i think the link in adapter-vercel's README.md isn't correct, i replaced the /svelte/ part with a /[YOUR_USERNAME]/ placeholder.

Whoops! Thanks


issue with installing oauth2client: "NameError: name 'sys_platform' is not defined'

I was trying to install oauth2client on my local windows machine but got the following error:
C:\repo\Cloud\appengine\standard\endpoints\backend>pip install --upgrade oauth2client
Collecting oauth2client
  Using cached oauth2client-2.2.0.tar.gz
Requirement already up-to-date: httplib2>=0.9.1 in c:\python27\lib\site-packages (from oauth2client)
Requirement already up-to-date: pyasn1>=0.1.7 in c:\python27\lib\site-packages (from oauth2client)
Requirement already up-to-date: pyasn1-modules>=0.0.5 in c:\python27\lib\site-packages (from oauth2client)
Requirement already up-to-date: rsa>=3.1.4 in c:\python27\lib\site-packages (from oauth2client)
Requirement already up-to-date: six>=1.6.1 in c:\python27\lib\site-packages (from oauth2client)
Building wheels for collected packages: oauth2client
  Running setup.py bdist_wheel for oauth2client ... error
  Complete output from command c:\python27\python.exe -u -c "import setuptools, tokenize;__file__='c:\\users\\clarence\\appdata\\local\\temp\\pip-build-t45sz8\\oauth2client\\setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" bdist_wheel -d c:\users\clarence\appdata\local\temp\tmpyabjs1pip-wheel- --python-tag cp27:
  Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "c:\users\clarence\appdata\local\temp\pip-build-t45sz8\oauth2client\setup.py", line 69, in <module>
      'Topic :: Internet :: WWW/HTTP',
    File "c:\python27\lib\distutils\core.py", line 137, in setup
      ok = dist.parse_command_line()
    File "build\bdist.win32\egg\setuptools\dist.py", line 276, in parse_command_line
    File "c:\python27\lib\distutils\dist.py", line 467, in parse_command_line
      args = self._parse_command_opts(parser, args)
    File "build\bdist.win32\egg\setuptools\dist.py", line 602, in _parse_command_opts
    File "c:\python27\lib\distutils\dist.py", line 523, in _parse_command_opts
      cmd_class = self.get_command_class(command)
    File "build\bdist.win32\egg\setuptools\dist.py", line 406, in get_command_class
    File "build\bdist.win32\egg\pkg_resources.py", line 2272, in require
    File "build\bdist.win32\egg\pkg_resources.py", line 2489, in requires
    File "build\bdist.win32\egg\pkg_resources.py", line 2700, in _dep_map
    File "build\bdist.win32\egg\pkg_resources.py", line 2733, in _compute_dependencies
    File "build\bdist.win32\egg\pkg_resources.py", line 2730, in reqs_for_extra
    File "build\bdist.win32\egg\_markerlib\markers.py", line 109, in marker_fn
    File "<environment marker>", line 1, in <module>
  NameError: name 'sys_platform' is not defined

  ----------------------------------------
  Failed building wheel for oauth2client
  Running setup.py clean for oauth2client
Failed to build oauth2client
Installing collected packages: oauth2client
  Running setup.py install for oauth2client ... done
Successfully installed oauth2client-2.2.0
You are using pip version 8.1.1, however version 8.1.2 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command.

@zoeticclarence So, oauth2client was installed. Pip just failed to build the 'wheel' for the package.
From a cursory search, it seems like over versions of setuptools/distribute can cause this. Can you try running
pip install --upgrade distribute
And see if that fixes it?

Thanks for your help @jonparrott.
It shows:
Requirement already up-to-date: distribute in c:\python27\lib\site-packages Requirement already up-to-date: setuptools>=0.7 in c:\python27\lib\site-packages (from distribute)
I think I figured out what was the issue.
I need to run as administrator to install them.


Ng-grid tabbing issue

Consider the grid width is 400px, and it has four columns. All column width is 100px. then tabbing between columns are working as expected.
http://plnkr.co/edit/2yMGLTY1L69lGwY7W667
Similar kind of grid with the same 400 px width. It has 4 columns. But Consider each column has 300px width, then tabbing between columns are not working. It is tabbing out only within the column which are visible on the screen. Please find the plunker here.
http://plnkr.co/edit/HtWt7soGrpGwTtP7khaB
I am not sure why this is happening. I am displaying almost 20 columns in the ng-grid, and would like to implement the tabbing functionality

I'd consider upgrading to ui-grid, I'm pretty sure this works there.

The application is almost ready with ng-grid, I am missing only this functionality. Now moving to ui-grid would be costly. Am I missing to include any other option in ng-grid to make that work.

This is not working in ui-grid though. https://github.com/angular-ui/ng-grid/issues/3451


rename Entity trait?

I saw that in 73a3fad, the hyper 0.12.x branch introduces an Entity trait to represent a streaming body. Would it be possible to change the name?
The reason I ask is: as I understand it, the HTTP RFCs use that term in a different way, and I think it'll be confusing. I care because I find the RFC meaning useful; in fact it's a central abstraction in a crate I'm working on that takes care of handling conditional GETs, byte range serving, and such. I could find a different name for my trait but I think it'll be extra confusing to flip between the HTTP RFCs, my crate's thing, and hyper's docs.
To be precise, as I read the HTTP RFCs, an entity is something that has a tag (etag), some headers (entity-headers), and a body (entity-headers). (Maybe also trailers? Unsure.) This trait is just representing a request/response body (and trailers, with HTTP/2); that's only part of the entity's body with range requests / 206 Partial Content.
I confess I don't have another suggestion for the name of this trait, though. You basically want the trait and the concrete type (currently Body) to have similar but not identical names, right? and not Stream, as that's taken by the futures concept? Naming is hard, let's go shopping...

Yea, naming is super hard! :cry: I chose Entity as I noticed its usage in Akka HTTP... 🤷♂
There is a trait, and a "default" implementation, by which this default is used as both a "recvbody", and is a fair option for users as a "sendbody". Here's a few options I've scrapped together:

Trait
Default Impl

Entity
Body

Payload
Body

Stream
Body

Body
DefaultBody

Stream conflicts with futures::Stream, and so would be confusing...
Maybe a trait name of Payload is best?

It occurs to me that maybe in the future, a custom base trait wouldn't be needed, and it really could be just a futures::Stream, with traits like PollTrailers existing, and if implemented, they'd be polled, thanks to specialization? I can't say it would all work just as well, as I haven't explored it since specialization isn't stable.

I've tended to think of it as the body stream, being a futures::Stream containing the body of the request or response. Would BodyStream work as a trait name?

Additional trait name options:

Content (like Content-Length describes the Content)
Transfer

I think any of Payload, Content, or Transfer would work well. I searched through RFC 7233 and didn't see any usage of any of those terms that's inconsistent with what this trait does. Mild preference for Payload still; no particular reason.


[SPARK-22383][SQL] Generate code to directly get value of primitive type array from ColumnVector for table cache

What changes were proposed in this pull request?
This PR generates the Java code to directly get a value for a primitive type array in ColumnVector without using an iterator for table cache (e.g. dataframe.cache). This PR improves runtime performance by eliminating data copy from column-oriented storage to InternalRow in a SpecificColumnarIterator iterator for primitive type. This is a follow-up PR of #18747.
The idea of this implementation is to add ColumnVector.UnsafeArray to keep UnsafeArrayData for an array in addition to ColumnVector.Array that keeps ColumnVector for a Java primitive array for an array.
Benchmark result: 21.4x
OpenJDK 64-Bit Server VM 1.8.0_121-8u121-b13-0ubuntu<IP_ADDRESS>-b13 on Linux 4.4.0-22-generic
Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz

Filter for int primitive array with cache: Best/Avg Time(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------
InternalRow codegen                           1368 / 1887         23.0          43.5       1.0X

Filter for int primitive array with cache: Best/Avg Time(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------
ColumnVector codegen                            64 /   90        488.1           2.0       1.0X

Benchmark program
  intArrayBenchmark(sqlContext, 1024 * 1024 * 20)
  def intArrayBenchmark(sqlContext: SQLContext, values: Int, iters: Int = 20): Unit = {
    import sqlContext.implicits._
    val benchmarkPT = new Benchmark("Filter for int primitive array with cache", values, iters)
    val df = sqlContext.sparkContext.parallelize(0 to ROWS, 1)
                       .map(i => Array.range(i, values)).toDF("a").cache
    df.count  // force to create df.cache
    val str = "ColumnVector"
    var c: Long = 0
    benchmarkPT.addCase(s"$str codegen") { iter =>
      c += df.filter(s"a[${values/2}] % 10 = 0").count
    }
    benchmarkPT.run()
    df.unpersist(true)
    System.gc()
  }

How was this patch tested?
Added test cases into ColumnVectorSuite, DataFrameTungstenSuite, and WholeStageCodegenSuite

Test build #83179 has started for PR 19601 at commit 80b9e31.

Test build #83179 has finished for PR 19601 at commit 80b9e31.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 public static final class UnsafeArray extends ArrayData

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83179/
Test PASSed.

@Ueshin @cloud-fan could you please review this?

My feeling is that, we should change the cache format of array type to make it compatible with ColumnVector, then we don't need conversion from cached data to columnar batch.

Current ColumnVector uses primitive type array (e.g. int[] or double[]) based on data type of each column. On the other hand, cached data uses byte[] for all data type.
Do we change format (Array[Array[Byte]]) in CachedBatch for an primitive array?

Can we use OffHeapColumnVector for cached data?

So for primitive types, we encode and compress them to binary. When reading cached data, they are decoded to primitive array and can be put in OnHeadColumnVector directly.
For primitive type array, we treat it as binary. So when decoding it, we get a byte[] and need more effort to convert it to primitive type and put in OnHeadColumnVector.
Can we change how we encode array type like Arrow did?

There are two approaches to support a primitive array that is treated as binary. One is to add new ColumnVector.Array that I did. The other is to add new WritableColumnVector like @ueshin added ArrowColumnVector.  Both are preferable to me.
I can add a new ColumnVector for primitive array (e.g. for UnsafeColumnVector) like Arrow did. Is it OK with you? To add the new class can avoid data conversion as Arrow did.

I'd like to also improve the write path. I think the current way to cache array type is not efficient, arrow-like format which put all elements(including nested array) together is better for encoding and compression.

I agree with you that we need to improve the write path. It will be addressed after improving the frequently-executed read path, as you suggested before. It will be addressed by the following PR.
For improving the read path, which approach is better? To add new ColumnVector.Array or to add new WritableColumnVector?

both ways work, just pick the simpler one. I'm concerned about how to access the nested array, you can try both approaches and see which one can solve the problem easier.

For now, this implementation has an limitation only to support non-nested array for ease of review.

After I think about the choice for a while, I conclude that it is better to add the new WritableColumnVector (i.e. UnsafeColumnVector) and to keep the current ColumnVector.Array.
I think that to add a new class will give us some flexibility and good abstraction between public class ColumnVector and other internal classes.

Jenkins, retest this please

Test build #83208 has started for PR 19601 at commit c78d462.

Test build #83210 has started for PR 19601 at commit c78d462.

Test build #83208 has finished for PR 19601 at commit c78d462.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public final class UnsafeColumnVector extends WritableColumnVector

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83208/
Test FAILed.

Merged build finished. Test FAILed.

Test build #83210 has finished for PR 19601 at commit c78d462.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public final class UnsafeColumnVector extends WritableColumnVector

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83210/
Test FAILed.

Test build #83223 has started for PR 19601 at commit b971506.

Jenkins, retest this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83236/
Test FAILed.

Jenkins, retest this please

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83237/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins, retest this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83240/
Test FAILed.

Jenkins, retest this please

Test build #83246 has started for PR 19601 at commit b971506.

Test build #83246 has finished for PR 19601 at commit b971506.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83246/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins, retest this please

Test build #83250 has started for PR 19601 at commit b971506.

Test build #83250 has finished for PR 19601 at commit b971506.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83250/
Test PASSed.

@cloud-fan could you please review this PR?
In my prototype, I succeeded to support a current nested array for table cache by changing only UnsafeColumnVector.java.
For ease of review, I would like to ask to review this PR a simple case (non-nested primitive array) at first.

@cloud-fan could you please review this PR?
In my prototype, I succeeded to support a current nested array for table cache by changing only UnsafeColumnVector.java.
For ease of review, I would like to ask to review this PR for a simple case (non-nested primitive array) at first.
cc: @ueshin

can we hold it for a while? I'm thinking about ColumnVector refactoring and see how to deal with nested data uniformly.

My prototype for nested array can handle nested array by changing UnsafeArray.getArray and its callee methods, and does not require to change ColumnVector.
If the refactoring takes more than several weeks, I can commit my prototype to support nested array to be merged into Spark 2.3.

Test build #83460 has started for PR 19601 at commit 2270304.

Test build #83460 has finished for PR 19601 at commit 2270304.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83460/
Test FAILed.

Test build #83463 has started for PR 19601 at commit 4666974.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83463/
Test FAILed.

Jenkins, retest this please

Test build #83465 has started for PR 19601 at commit 4666974.

Test build #83465 has finished for PR 19601 at commit 4666974.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83465/
Test PASSed.

Merged build finished. Test PASSed.

@cloud-fan could you please review this again since this version avoids to override ColumnVector.getArray as you suggested?
cc @ueshin

Test build #83689 has started for PR 19601 at commit eac3d30.

Test build #83689 has finished for PR 19601 at commit eac3d30.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83689/
Test PASSed.

@cloud-fan could you please review this again? Now, this PR does not apply any change to ColumnVector and WritableColumnVector.

Test build #83905 has started for PR 19601 at commit b025565.

Test build #83905 has finished for PR 19601 at commit b025565.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83905/
Test PASSed.

@cloud-fan could you please review this again? I merged with the ColumnarArray. As you suggested, the latest implementation does not change ColumnVector and ColumnarArray.

Test build #83930 has started for PR 19601 at commit 17449b4.

Test build #83930 has finished for PR 19601 at commit 17449b4.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83930/
Test FAILed.

Test build #83931 has started for PR 19601 at commit 9a41914.

Test build #83931 has finished for PR 19601 at commit 9a41914.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83931/
Test FAILed.

Jenkins, retest this please

Test build #83934 has started for PR 19601 at commit 9a41914.

Test build #83934 has finished for PR 19601 at commit 9a41914.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83934/
Test PASSed.

Merged build finished. Test PASSed.

Does it work for non-top-level array type fields and nested array? Generally I think this is not the right direction. The root cause is that, table cache array format is not the arrow-style format(put all leaf elements together) and can't fit in ColumnarArray. To avoid the expensive conversion, what you did here is kind of creating a fake ColumnarArray to be able to read the table cache array data directly. I think this is not a general solution but just a hack.
Futher more, all complex types face the same problem in table cache. I think the right direction is to revisit the columnar cache format and design how to deal with complex types. This is something we dropped at the beginning(treat complext types as binary data) and now it's time to pay back.

This approach also works for nested array. I have this implementation in my machine. For ease of review, I commit the version of only primitive type array support. If you like it, I can commit the version for nested array support.
Yes, I created a wrap ColumnarArray corresponding to an UnsafeArrayData for an array at each nest level. It can avoid expensive data copy, which is very important for array and complex type. This is because data size of these data structures are large.
If we can still avoid expensive data copy, which is accomplished by pointing a part of one large array (not copying data from the large array), by using the new design (you may think about such a format), I am happy to revisit the format with you. It is an issue for internal implementation. The redesign would not affect the external interfaces ColumnVector and ColumnarArray.

There are some parts that relies on the format of UnsafeArrayData. I mean that bit-by-bit copy of UnsafeArrayData is performed. Can we handle this copy using the new format for an unsafe array?

We'd need to change the UnsafeArrayData format too, to avoid data copying when building the cache. BTW I think it's ok to release this columnar cache reader without efficient complex type support, so we don't need to rush.

I see. Let us revisit this design later.
I would appreciate it if you would review this columnar cache reader with simple primitive-type (non-nested) array.

Test build #84080 has started for PR 19601 at commit 63d9d57.

Test build #84080 has finished for PR 19601 at commit 63d9d57.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84080/
Test FAILed.

Test build #84082 has started for PR 19601 at commit 9b6b890.

Test build #84082 has finished for PR 19601 at commit 9b6b890.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84082/
Test PASSed.

Merged build finished. Test PASSed.

@cloud-fan could you please review this?

Jenkins, retest this please

Test build #84215 has started for PR 19601 at commit 9b6b890.

Test build #84215 has finished for PR 19601 at commit 9b6b890.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84215/
Test FAILed.

Test build #84253 has started for PR 19601 at commit 20d2ba2.

Test build #84253 has finished for PR 19601 at commit 20d2ba2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84253/
Test PASSed.

Hi, @kiszk . Is this still valid?

Hi, @kiszk . Can we close this for now? You can make another PR later if you want.

Thanks!


Add empty batch support for DeformConv2d

This is very similar to https://github.com/pytorch/pytorch/issues/12013, but for DeformConv2d which is implemented in torchvision.
This would allow detectron2 to potentially move to use the torchvision implementation of DeformConv2d, instead of their own version
cc @ppwwyyxx

Fixed by https://github.com/pytorch/vision/pull/2782


changes to Final

let me know if this works

This is the latest of my changes let me know if this is working right


dist-modules contains non-ES5 code

The contents of dist-modules that are used by the module available on NPM contain non-ES5 code. This seems to be a regression that appeared in 2.2.6.
See the comment here for further clarification: https://github.com/prakhar1989/react-tags/commit/b7f7152a06825a121ca9f8d3a4d35b58ac1d7269#commitcomment-17297357

any updates on this? I got the same issue.
var { DragDropContext } = require('react-dnd');
    ^

SyntaxError: Unexpected token {
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:387:25)
    at Module._extensions..js (module.js:422:10)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/longhuynh/Awake/githubs/longh/awakeui-component-taglist/node_modules/babel-register/lib/node.js:166:7)
    at Module.load (module.js:357:32)```

To avoid this problem, you can run the latest nods.js with --harmony_destructuring argument.

Sorry everyone - I've been quite busy which is why this repo has not got a lot of love. I'm working on this now to fix this. Let me know if anyone has ideas on how to proceed!

Hey folks, I've published a new version which fixes this. Let me know if you still see something wrong and feel free to re-open this issue. Thanks again for your patience.


Add Option-like type?

It would be useful to export a standard Option/Optional type definition from the prelude that can be used by fallible operations. (And include a const value definition).
This can currently be defined as a sum [T] + [], but having it as a common definition would ensure we have an homogeneous interface.

This sounds like having utilities for using sums?

Yeah, it should probably be something like the definition for BOOL_T, which is just an alias for a sum.


file size 0 if bitPerSample is 8

Here are my options:
sampleRate: 11025,
channels: 1,
bitsPerSample: 8,
wavFile: 'test.wav'
After recording the test.wav size is 0. If I set bitsPerSample as 16, it works fine. Can anyone take a look at this issue? Thanks

@diwu86 could you test with the latest version?


[Request] Allow for weapons with the ammunition property to also roll the saving throw and description field of ammunition used

Currently the system handles ammunition by only adding its damage formula and its attack bonus field to the roll of the weapon that is set to use that ammunition.
Ammunition items themselves though have a field in their details tab to set things like saving throws and chat messages.
It would be useful for the system to be able to roll those fields when selecting that ammunition in the weapon
For example, if I want to make a custom arrow that has a saving throw and applies disadvantage to attacks if the saving throw is failed I currently would have to manually roll the ammunition item itself rather than being able to set that ammunition in the weapon (for example with Forien's Ammo Swapper) and rolling the weapon itself.

With v4's activities, it would be useful to be able to prompt for an ammunition's activities somewhere in the roll process, maybe in the attack prompt when the ammo is selected?

Or maybe triggering the activity-choice dialog if the selected ammunition has activities?


Configuring VerneMQ though ENV vars

Environment

VerneMQ Version: 1.8.0
OS: Docker
Erlang/OTP version (if building from source): 21
VerneMQ configuration (vernemq.conf) or the changes from the default
Cluster size/standalone:

Expected behavior
I have set:
DOCKER_VERNEMQ_PLUGINS.VMQ_PASSWD: "off"
DOCKER_VERNEMQ_PLUGINS.VMQ_ACL: "off"

in docker compose, and expected vars in conf file in docker to be set to "off"
Actual behaviour
In the container:
plugins.vmq_passwd = on
## Default: ./etc/vmq.passwd
vmq_passwd.password_file = ./etc/vmq.passwd
vmq_passwd.password_reload_interval = 10
/mainflux $

Additionally, is it possible to add some other vars that do not exist in the config file via ENV vars?
Point is that I would like to enable my plugin, but it does not exist in the config file.

Hi, you should use double underscore for dots as described in the docker readme: https://github.com/vernemq/docker-vernemq#remarks
So use DOCKER_VERNEMQ_PLUGINS__VMQ_PASSWD=off to disable the vmq_passwd plugin.
Hope this helps.

Actually the docs there says dots should work - haven't tried that - but with double underscores it worked.. will test the dot version...

Looks like with the dot version that there's a bug where the plugin name isn't lowercased. So the appended part of vernemq.conf looks like:
########## Start ##########
plugins.VMQ_PASSWD=off
log.console=console
erlang.distribution.port_range.minimum = 9100
erlang.distribution.port_range.maximum = 9109
listener.tcp.default = <IP_ADDRESS>:1883
listener.ws.default = <IP_ADDRESS>:8080
listener.vmq.clustering = <IP_ADDRESS>:44053
listener.http.metrics = <IP_ADDRESS>:8888
########## End ##########

Could you open an issue for this on the docker-vernemq repo? Thanks


while index.less file change   ,  this not work ...

while index.less file change , this not work ... #3
yeah,,,,it work  fine  in the last week  ,
i   do nothing,
maybe i need to read your core code && rewrite another one ....

thanks for your code inspire my mind to write nodejs  file to    cover less => css

Hi @pengliheng!
This project currently has a host of issues to be resolved, but I think that this particular one is not one of them. I think you might be using a different NPM project with a similar name.
Looking at your screenshot, the syntax you use in your command and the output of less-watch-compiler matches the project I linked to above.


remove debug override and colors module

This PR will remove confusing use of debug when the opts passed to pubsub contain a debug:true flag, the client overrides debug and logs to console using colors module
No functionality is lost as the common way to get debug logs is to specify: DEBUG=appc:pubsub

@jareddlc<EMAIL_ADDRESS>is published with this and #20 in tow.


Difficulty in reproducing builds across setups

The setup is working on my PC but not on another user's. Before the PR to wxHaskell is accepted, it would be better to make sure it works on multiple PCs.
At the start, I think we should just install stack and not install haskell-platform to get rid of one variable.
curl -sSL https://get.haskellstack.org/ | sh
stack upgrade
sudo apt install libwxgtk3.0-dev

To get a sample wxhaskell project working in a ci configuration, I needed this line:
apt install -y libwxgtk-media3.0-dev libwxgtk-webview3.0-dev libwxgtk3.0-dev make xz-utils

Additionally, on my vm, I needed to install libtinfo-dev.

Okay, so inside the VM, I'm getting the same error as you were initially (the Cabal mismatch). Let's see if I can fix it...

@concavegit can you pull the latest changes (including the ones to reactive-banana-wx), run stack setup --upgrade-cabal (preferably from inside the reactive-banana-wx directory after cloning, but I think it should work elsewhere too), and try building,  first the updated reactive-banana-wx only (cd into its directory and stack build) and then wxhs-test? Hope it works now 😅
If it works, I can try to explain what is going on...

stack build and stack ghci now work without further intervention on both ubuntu and my unstable gentoo. Good work!

So the problem was that the custom setup script uses the system Cabal, whose version was left unspecified. I added an extra custom-setup field in reactive-banana-wx.cabal which specifies what Cabal version should be used for the Setup.hs script. We need to have version >= 1.24 (not sure if for cabal-install or Cabal or both) for cabal-install to recognize the custom-setup field.
Since the wxhs-test repository has an external dependency a Cabal-<IP_ADDRESS> to appease wx-<IP_ADDRESS> (which now expects >= 2.0), I specified the same version inside reactive-banana-wx.cabal and it works now.
What stack setup --upgrade-cabal did was updated the cabal-install being used by Stack for that project (or globally?), so that we're able to get version >= 1.24.


Fix & Improve JWT / Response Validations

coverage: 87.091% (-2.2%) from 89.249% when pulling 644b4114d63112d2e820bb40adce33547cbe9e74 on fix_validations into 68f5fe87edb1d41358c247a0cf793039e3f71c35 on main.


Support [Codecov] coverage badge with flag

resolves #3512

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @MunifTanjim!

  Generated by :no_entry_sign: dangerJS against 3a4ca5c2dface4d21101e124817a4828256e0911

Hi @MunifTanjim, thanks for the PR!
I've tweaked the PR title so that our CI process will execute the tests (more detail here and as you can see there's quite a few test failures.
Could you take a look at those when you get a chance?

@calebcartwright Thanks for adjusting the PR title, I missed reading that section of the docs.
I've fixed the failed tests. Could a take a look when you get a chance?

I did go ahead and setup a private repo and enabled Codecov to test this out. The good news is that I can confirm this is successfully maintaining backwards compatibility with private projects!
However, it seems like this may no longer be working with the flag param
For example:
We're showing 92% with or without the flag (note that Shields conditionally rounds coverage up in all our coverage badge whereas Codecov always rounds down, hence the 92 vs 91)
https://shields-staging-pr-4968.herokuapp.com/codecov/c/github/ethereumjs/ethereumjs-vm?flag=vm

https://shields-staging-pr-4968.herokuapp.com/codecov/c/github/ethereumjs/ethereumjs-vm

As compared to the native Codecov badges
https://codecov.io/gh/ethereumjs/ethereumjs-vm/branch/master/graph/badge.svg?flag=vm

https://codecov.io/gh/ethereumjs/ethereumjs-vm/branch/master/graph/badge.svg

We're showing 92% with or without the flag (note that Shields conditionally rounds coverage up in all our coverage badge whereas Codecov always rounds down, hence the 92 vs 91):

This is strange 🤔 This is the result when I'm running it locally on my pc:

Does indeed seem to be working now!

@paulmelnikow - I've approved but will wait another day or two to merge in case you want to review given the discussion in https://github.com/badges/shields/pull/4968#discussion_r418593467
Basically, this PR does two cool things for our Codecov badges: (1) enables badges for coverage with flags/monorepos and (2) allows us to switch the way support codecov badges for private repos to a read-only, project specific token.
Both of those require SVG scraping Codecov's native badges, whereas we were previously using Codecov's API. So while we've switched to the SVG scraping implementation, we have to keep support for Codecov's API which is required to maintain BC for existing usage of our codecov badges for private repos

What you're saying makes sense to me! 👍


A  way to set preview to starting lines

Dear @sainnhe, Thanks for your amazing work on tmux-fzf. I really enjoy using it.
I'm having a preview issue since I first started using the tmux-fzf, that is preview starts in the middle or by the end instead the first line.
Is there away you know of or configuration I missed to make preview start from the first lines
Thanks

It's controlled by :follow option.
https://github.com/sainnhe/tmux-fzf/blob/1801dd525b39154745ea668fb6916035023949e3/scripts/.envs#L20
Try to upgrade your fzf.

🤔 I believe my Tmux is up to date no? 3.2a also fzf is 0.30
my fzf opts are
[
           "-p" "-w" "70%" "-h" "50%" "-m"
             "--height 60%"
            "--preview-window=right:60%"
            "--bind='ctrl-d:preview-half-page-down'"
            "--bind='ctrl-u:preview-half-page-up'"
            "--bind='ctrl-space:toggle-preview'"
            "--bind='alt-space:toggle-preview'"
            "--bind=',:toggle-preview'"
            "--preview-window=right:65%:nocycle:nofollow"
            "--reverse"
            "--scroll-off=8"
            "--cycle"
            "--no-info"
            "--no-bold"
            "--border=rounded"
            "--preview-window=:nofollow"
          ]

You set it to nofollow
"--preview-window=:nofollow"

Yah I added that thinking it would changed it and show first lines. but didn't have any effect.


Remove direct_infusion_category and DirectInfusionEnum

Removed direct_infusion_category (now incorporated into eluent_introduction_category) and DirectInfusionEnum (now part of EluentIntroductionCategoryEnum) from v10-vsv11-retrospective.md and basic_slots.yaml.
Fixes #2234.
These slots were never part of the schema (they were iterations within the berkeley fork that should have been removed pre-v11 release). No deprecation or migration needed; no released version of the schema ever used this slot or Enum on any classes.

I am going to merge this but am interested in hearing some feedback.
@samobermiller when you say the elements removed in this PR "were never used in the schema" do you mean they were never used in the data?
@brynnz22 @eecavanna I agree with @samobermiller that this PR doesn't need a migration, but I wanted to loop you in since you think about that kind of thing more than me.

@turbomam My understanding is that the slot and its associated Enum were never associated with a class while the schema was in production, so there was never an opportunity for the database to use the slot (and Enum), so no migrator necessary

Thanks, @samobermiller. I guess I was thinking of eluent_introduction_category and EluentIntroductionCategoryEnum, with the values direct_infusion_syringe	and direct_infusion_autosampler. Are we going to keep using those?

@turbomam that is beyond my scope at this point so I'll tag @kheal

Thanks, @samobermiller. I guess I was thinking of eluent_introduction_category and EluentIntroductionCategoryEnum, with the values direct_infusion_syringe and direct_infusion_autosampler. Are we going to keep using those?

Yes, we are using those PVs. PVs for direct infusion were added to EluentIntroductionCategoryEnum (referenced via eluent_introduction_category slot) during the course of the refactoring, thus the lack of need for a separate DirectInfusionEnum.


Added tests for "typed memoryviews" part 6

Hmmm, would actually be nice to have this example as a running test, not just compile it.


We shouldn't be using inline styles

Styles should be declared in CSS files outside of the HTML file. This can reduce loading times due to minification and make code easier to read.

Yes, it is a brade-off in development. It is convenient to use inline style to get page style setup. Once page is in good shape, inline style should get moved into corresponding css files.


Created Data model

Acomplishment

Connected to PostgreSQL database
Created and run the necessary migration files.
Table and column names match the ERD diagram.
All columns that are foreign keys  have a corresponding index

Hi @NalianAchei2020,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request

Your migrations are failing. You did not set up your migration files properly. You should create users table, followed by posts, then comments and likes. But since you created comments and likes before posts they raise errors for a new user setting up your app because comments and likes tables depend on posts table, which chronologically is not created until later.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.

Hi @julie-ify
From my commit history, I created it in the order you just mentioned. The post was created before comments and likes.


Missing devDependency tslib

michiel-2:utils michiel$ npm run build:js

><EMAIL_ADDRESS>build:js /Users/michiel/gh/NoelDeMartin/utils
> noeldemartin-build-javascript

src/main.ts → dist...
[!] (plugin typescript) Error: @rollup/plugin-typescript: Could not find module 'tslib', which is required by this plugin. Is it installed?
Error: @rollup/plugin-typescript: Could not find module 'tslib', which is required by this plugin. Is it installed?
    at error (/Users/michiel/gh/NoelDeMartin/utils/node_modules/rollup/dist/shared/rollup.js:158:30)
    at throwPluginError (/Users/michiel/gh/NoelDeMartin/utils/node_modules/rollup/dist/shared/rollup.js:21769:12)
    at Object.error (/Users/michiel/gh/NoelDeMartin/utils/node_modules/rollup/dist/shared/rollup.js:22472:20)
    at preflight (/Users/michiel/gh/NoelDeMartin/utils/node_modules/@rollup/plugin-typescript/dist/index.js:495:17)
    at Object.buildStart (/Users/michiel/gh/NoelDeMartin/utils/node_modules/@rollup/plugin-typescript/dist/index.js:736:13)
    at /Users/michiel/gh/NoelDeMartin/utils/node_modules/rollup/dist/shared/rollup.js:22681:25
    at async Promise.all (index 0)
    at rollupInternal (/Users/michiel/gh/NoelDeMartin/utils/node_modules/rollup/dist/shared/rollup.js:23397:9)
    at build (/Users/michiel/gh/NoelDeMartin/utils/node_modules/rollup/dist/bin/rollup:1547:20)
    at runRollup (/Users/michiel/gh/NoelDeMartin/utils/node_modules/rollup/dist/bin/rollup:1731:21)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build:js: `noeldemartin-build-javascript`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build:js script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/michiel/.npm/_logs/2023-11-20T09_54_33_178Z-debug.log

Thanks for opening the issue, I've updated the @noeldemartin/scripts dependency which now declares tslib as a dependency so it should be fixed.


fix const enum output

This PR fixes the generated output for const enum.

That code sample has // @showEmit which means it will output the JS, so I don't think this PR needs to be merged

You're right, thanks for your feedback. Don't know how I ended up on a page where it was not giving the right output. I'll close the PR.


How to deal with complex equations?

It appears that IRKGaussLegendre.jl does not work with complex equations. For example, the following MWE results in MethodError: no method matching isless(::ComplexF64, ::Float64).
function simpleprob!(du::Vector{Complex{Float64}}, u::Vector{Complex{Float64}}, p, t)
    du[1] = u[2]
    du[2] = -im*u[1]
end

u0=[1.0+0.0im,0.0+0.0im]

prob1 = ODEProblem(simpleprob!,u0,(0.0,1.0),nothing)
sol1 = solve(prob1,IRKGL16())

You are right, RKGaussLegendre.jl fails with complex equations.
We will need some time to correct the error.
I'm sorry for the inconvenience and I hope we can resolve it soon.

Now, IRKGaussLegendre.jl works well with complex equations. You must upgrade to v0.2.5 release:
pkg>up IRKGaussLegendre

I have checked it with a new notebook called "/Examples/Office example using complex numbers (Github).ipynb" where I have coded the nbody problem with complex variables z=x+iy


Update links to docs

Update links to docs so that they go to the new docs site.

These changes are already in the develop branch and will be rolled out to master with our 0.3.4 release:
https://github.com/spatialos/gdk-for-unity/pull/1325/files

Ah nice, thanks @paulbalaji!