Requesting conda package for simplified installation

First of all, thanks for your hard work making this tool.
Current Installation Process:
The current instructions involve several steps, including cloning the repository, running shell scripts or batch files, and ensuring specific software versions and compilers are installed. While this is manageable, it can be cumbersome, error-prone, and hinders gtalign being effectively built into other software/workflows.
Benefits of a Conda Package:

Ease of Installation: A simple conda install gtalign command could replace multiple steps in the current process.
Dependency Management: Conda handles dependencies automatically, reducing the likelihood of version conflicts or missing packages.
Cross-Platform Support: Conda works across Linux, macOS, and Windows, ensuring a consistent installation experience.
Environment Isolation: Conda environments can isolate the installation, preventing potential conflicts with other software.
Adopted by Scientists: Conda is widely used and expected by scientists

Thank you for your valuable suggestion. I plan to revisit this point in a month or two.

Conda packages are now available.


fix/github-release

Please review before merging.

:tada: This PR is included in version 1.8.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


New repo for integration builds

Requires coordination with https://github.com/scala/scala-jenkins-infra/pull/223

Whis doesn't need a backport to 2.11.x: there we're still building scala as part of the community build, and there's no mention of scala-release-temp. We need it in 2.13.x though: https://github.com/scala/community-builds/pull/490

I updated the local-Artifactory config in a46b9b4ac9a56951032633c66564159f4c113cdf

thanks!


Update README.adoc with a few fixes

Sorry I didn't see this before.  To merge this I would need you to complete one of the contributor agreements.  If you don't wish to I will submit a PR for this change myself.
Thank you.

Thanks, I just filled out the Individual Contributor Agreement form.


Use toml_edit to edit the Cargo.toml while preserving format in --fix?

https://crates.io/crates/toml_edit

lol we were already using it?


Tasks unable to run when using UNC paths / WSL

VSCode Version: 1.43.2
OS Version: Windows 10 2004
Shell used: pwsh 7

Steps to Reproduce:

Have the following task

{
            "label": "npm: build",
            "type": "npm",
            "options": {
                "statusbar": {
                    "hide": false
                }
            },
            "script": "build",
            "dependsOn": [
                "npm: lint"
            ],
            "group": {
                "kind": "build",
                "isDefault": true
            }
        },

Have project in the WSL container

Does this issue occur when all extensions are disabled?: Yes
Error:
> Executing task: yarn run lint <

The terminal shell CWD "\\\wsl$\Ubuntu\home\stan\projects\personal\WeakAurasCompanion" does not exist

Terminal will be reused by tasks, press any key to close it.

Verified using
		{
			"type": "shell",
			"label": "DIR",
			"command": "dir"
		}


MCCFR addition?

It would be great to test MCCFR in these settings. Any idea if this might be included in the future?

Which settings do you mean? MCCFR as a baseline algorithm should be quite easy to implement - take it as a challenge to try it yourself.


Display garbled characters in vim

environment

vim: 8. 2*
vim-airline: 0.12
OS: wsl2-ubuntu 20. 04
Have you reproduced with a minimal vimrc: ???
What is your airline configuration:.
if you are using terminal:
terminal: zsh
$TERM variable:.
color configuration (:set t_Co?):2
if you are using Neovim:
does it happen in Vim:

actual behavior
Display icons correctly
expected behavior
Displays garbled characters, when the powerline font has been installed(in win10) (DejaVu Sans Mono for Powerline)
Installed powerline in wsl (only installed directly through the package manager)(like "sudo apt install powerline")
screen shot (if possible)

I think you are missing the linenr symbol. Check the health and see if manually setting a different character helps.

I think you are missing the linenr symbol. Check the health and see if manually setting a different character helps.

Well, I am a newbie to vim, so I clone a configuration project directly(https://github.com/chxuan/vimplus.git), and it is on another device (Android terumx) , which runs very well, so it should not be a configuration problem.
And thank you for your reply

okay, try this in your configuration:
if !exists('g:airline_symbols')
  let g:airline_symbols = {}
endif
let g:airline_symbols.linenr = ''

okay, try this in your configuration:
if !exists('g:airline_symbols')
  let g:airline_symbols = {}
endif
let g:airline_symbols.linenr = ''

I added that piece of code and restarted vim, but nothing seems to get better......

Check the output of :echo g:airline_symbols. do you see this strange symbol there? If yes, then specifically set that name to a different symbol in your configuration similar to the ones I did above

Check the output of :echo g:airline_symbols. do you see this strange symbol there? If yes, then specifically set that name to a different symbol in your configuration similar to the ones I did above

Thank you, I changed it.


feat(version update): Update both services with API version 2020-10-06

:tada: This PR is included in version 0.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Added support to toggle to full resolution data.

Coverage increased (+0.3%) to 88.609% when pulling 4d0e16c01ca792cff6cf87f2f555ebd8512c9ecc on thongsav-usgs:master into 824f57437ff3d45c998f8505f7b21605364b5132 on USGS-R:master.


proxy support

This is a duplicate of #20 but I couldn't find a way to reopen it.
How can we configure the ftp connection to use a proxy? My network requires the use of a proxy in order to access the internet. I've tried setting FTP_PROXY as per the standard, but it didn't work. The connection still attempts to go direct, and thus times out.

FTP proxies are just HTTP Connect proxies. Usually you define it by setting the FTP_PROXY environment variable, which is analogous to the HTTP_PROXY and HTTPS_PROXY env vars.
They aren't FTP servers themselves, so connecting directly to it with an FTP client won't work.

You are saying it proxies FTP over HTTP? When I googled for FTP proxy, all I saw are actual FTP proxy servers where you connect to them using FTP, and they proxy to other FTP servers. Do you have a link describing how your FTP proxy works?

It's a standard web proxy that you would find at most companies:
https://en.wikipedia.org/wiki/Proxy_server#Web_proxy_servers
Our specific one is Squid, and we need to use it in order to access resources on the internet.
Essentially, an application will read the proxy configuration from the environment or elsewhere, then instead of connecting to the target server directly it will open a tunnel through the proxy using an HTTP CONNECT request. After the connection is established it's used by the application as normal.
Here's an example configuration from filezilla:
https://www.youngzsoft.net/ccproxy/faq_66.htm
Here's an example for lftp:
https://www.librebyte.net/en/ftp/lftp-behind-a-proxy/
I was looking for similar instructions for this client, but after examining the code it doesn't appear to support proxies at all...

Thanks!
I have no plans to support proxies like this in goftp. It seems like they are various kinds of proxies and they fall outside the purvey of ftp itself.
We could add the ability to create an ftp connection given a generic net.Conn so the user's code could set up the proxy connection and pass that to goftp. Would that solve your problem?

That would work for any other protocol except FTP. Without knowing what ports the ftp session needs for data transfers, there's no way to create the correct connections ahead of time.
I'm going to see if I can wrap our app in something that can catch connections, or see if there's a way to forward all traffic through the proxy using redsocks and iptables... Failing that I guess we'll just need to rewrite our app using something else.
Thanks anyways!

I have implemented this on my fork of the repo and created a pull request #55
I have used this in conjunction with mwitkow/go-http-dialer to be able to make connections via squid proxy.


possible issues for the codes

Hello,
I just checked the code in train_for_crossdata_projection.py. there are some possible problems.
deepsilencer.fit(whole_data,whole_data_kmer,train_label,filename= modelname,learning_rate=lr)
Would you like to double check them?

We apologize for any confusion caused. You may be curious whether including both training and testing data in the model training process could lead to information leakage. It is important to clarify that the training and testing data mentioned in the code are specific to the self-projection experiment. However, in the cross-data projection experiment, we combine all the data from the self-projection experiment and train the DeepSilencer model.

But the train lab length is 1600, the whole data is 2000

Sorry for that, we have fixed the bug in the revised version. Thanks for your kind reminder!

gotcha

whole_mat = np.vstack(train_mat,test_mat) to whole_mat = np.vstack((train_mat,test_mat))

Thanks for your reminder again! We have updated the related codes.


Error, mockRouter not found

Details
Cheers!
To be honest, I am not really sure if this is an error or maybe a misconfiguration at my side.
I am trying to use unlighthouse in comination with a dockerized AdonisJS 6 instance. Can someone help me? I've tried to create the same functionality in NuxtJS and getting the same error.
I am getting the following error:
adonis_app      | [15:34:39.022] ERROR (1070): Cannot read properties of undefined (reading 'mockRouter')
adonis_app      |     request_id: "npv35w2mmh3f9phg194ajzxs"
adonis_app      |     x-request-id: "npv35w2mmh3f9phg194ajzxs"
adonis_app      |     err: {
adonis_app      |       "type": "TypeError",
adonis_app      |       "message": "Cannot read properties of undefined (reading 'mockRouter')",
adonis_app      |       "stack":
adonis_app      |           TypeError: Cannot read properties of undefined (reading 'mockRouter')
adonis_app      |               at normaliseRoute (file:///home/node/app/node_modules/@unlighthouse/core/dist/index.mjs:431:42)
adonis_app      |               at file:///home/node/app/node_modules/@unlighthouse/core/dist/index.mjs:5458:28
adonis_app      |               at Array.map ()
adonis_app      |               at resolveReportableRoutes (file:///home/node/app/node_modules/@unlighthouse/core/dist/index.mjs:5458:15)
adonis_app      |               at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
adonis_app      |               at async ctx.start (file:///home/node/app/node_modules/@unlighthouse/core/dist/index.mjs:6043:18)
adonis_app      |               at UnlighthousesController.analyze (/home/node/app/app/controllers/unlighthouses_controller.ts:15:5)
adonis_app      |               at ShieldMiddleware.handle (/home/node/app/node_modules/@adonisjs/shield/src/shield_middleware.ts:64:5)
adonis_app      |               at SessionMiddleware.handle (/home/node/app/node_modules/@adonisjs/session/src/session_middleware.ts:81:22)
adonis_app      |               at  (/home/node/app/node_modules/@adonisjs/static/src/static_middleware.ts:74:11)
adonis_app      |       "status": 500
adonis_app      |     }
And this is the code I am using
unlighthouses_controller.ts:
import type { HttpContext } from '@adonisjs/core/http'
import { createUnlighthouse } from 'unlighthouse'
import { createServer } from '@unlighthouse/server'
export default class UnlighthousesController {
async analyze({ request }: HttpContext) {
const unlighthouse = await createUnlighthouse({
site: request.input('url'),
cache: false,
})
console.log(unlighthouse)
const { server, app } = await createServer()
await unlighthouse.setServerContext({ url: server.url, server: server.server, app })
await unlighthouse.start()

}
}
unlighthouse.config.ts:
export default {
puppeteerOptions: {
args: ['--no-sandbox', '--disable-setuid-sandbox'],
},
}

Hi, GitHub closes the issues when I push a commit that relates to the issue. You'll need to wait for the release before you can use it though. I'll ping this issue once it's out :)


[Bug] iOS Popup: Position of Popup is not centered when the orientation of the device changes

Description
If you change the orientation of the iOS device (e.g. from portrait to landscape mode or vice versa), the Popup is not in the center anymore. On Android this works fine.
I guess that is, because the position on iOS is set when initializing to the coordinates of the center of the screen, but the coordinates don't change when the orientation changes.
Steps to Reproduce

Open the Samples app and open the Popup sample on an iOS device.
Change the orientation of the device.

Expected Behavior
The popup should still be in the center of the screen.
Actual Behavior
The popup still has the same coordinates, which are not the center of the screen anymore.
Basic Information

Version with issue: v1.1.0

We are encountering the same issue in our app.

I guess in the same area as #1402

We too, is there any chance someone get fixing this annoying bug?

Bug is still not fixed?
When opening your popup view subscribe to:
Application.Current.MainPage.SizeChanged += MainPage_SizeChanged;
Manually trigger the PropertyChanged event with OnPropertyChanged(nameof(VerticalOptions)) in the SizeChanged event. This will force the PopupRenderer to recenter the popup.


Add CLI support for unconditional sampling and assessing data likelihood of any dataset

What does this issue request?
Add CLI support for two modes of evaluating posterior models, to make it easy to do either of two things:
1. Unconditional sampling of synthetic data
The goal here is to generate posterior samples to create datasets that can be compared to the training data/observations and held-out data.
2. Compute held-out likelihood scores
The goal here is to be able to compute held-out likelihood scores for training and held-out data.
Why do we want this?
This allows us to compare special cases of GenDB against relevant baselines, like previous CrossCat implementations. Note that some relevant baselines may generate synthetic data but not allow assessing held-out likelihood. The effort should be particularly relevant for evaluations that would be needed for a future publication -- but it's also not urgent right now.

For the held-out likelihoods, do you need them per held-out item or only per test set?
(Or to ask another way:  if there are 1000 items in the held out test set, do you want a single log likelihood for all of them, or do you want 1000 individual log likelihoods?)

For the held-out likelihoods, do you need them per held-out item or only per test set?
(Or to ask another way: if there are 1000 items in the held out test set, do you want a single log likelihood for all of them, or do you want 1000 individual log likelihoods?)

I would return a table or list of the latter because we can aggregate easily -- but we also may want to dig into which rows generate which log-likelihood values in case we encounter bugs (e.g. NaNs for certain held-out rows).


bug(ngc): Referencing a page breaks with --prod

Ionic version:  (check one with "x")
[x] 3.x
I'm submitting a ...  (check one with "x")
[x] bug report
Current behavior:
I have code which works perfectly but not in --prod. When a user navigates to a page, I highlight which page they are currently on the the menu.
This is what is meant to happen:

This is what happens when running with a --prod build on a device:

Expected behavior:
I am not expecting such different behaviour due to a --prod build.
Related code:
Repo here:
ngcissue.zip
The app.component.ts class looks as follows:
pages: Array<{ title: string, component: any, isActive: boolean }>;

  constructor(public platform: Platform, public statusBar: StatusBar, public splashScreen: SplashScreen) {
    this.initializeApp();

    // used for an example of ngFor and navigation
    this.pages = [
      { title: 'Home', component: HomePage, isActive: false },
      { title: 'List', component: ListPage, isActive: false },
      { title: 'Test', component: TestPage, isActive: false }
    ];

  }

openPage(page) {
    // Reset the content nav to have just this page
    // we wouldn't want the back button to show in this scenario
    this.nav.setRoot(page.component);

    // set which page is active
    for (let p of this.pages) {
      p.isActive = false;

      if (p == page) {
        p.isActive = true;
      }
    }
  }

  ngAfterViewInit() {
    this.nav.viewWillEnter.subscribe(x => {

      for (let p of this.pages) {
        if (x.component.name === p.component.name) {
          p.isActive = true;
        }
        else {
          p.isActive = false;
        }
      }
    });
  }

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
global packages:

    @ionic/cli-utils : 1.3.0
    Ionic CLI        : 3.3.0

System:

    Node       : v6.10.3
    OS         : macOS Sierra
    Xcode      : Xcode 8.3.2 Build version 8E2002
    ios-deploy : 1.9.0
    ios-sim    : 5.0.10

AoT build uglifies the code, and makes the name value on Component to be equal to "t" (in my testing at least), because first it uglifies the class's name, to be t, then when setting name it just copies that "t".
(your init for loop does: if("t" === "t") and sets isActive on everything)
I am not sure this should be considered a bug, and especially not a bug with ionic, probably with angular.

Hey @dylanvdmerwe, you can check out the conference app for an example of how to achieve this functionality. @AmitMY is correct that your current logic will not work in prod mode because of how uglify works, but if you use the way we do it in the conference app it will work in prod mode.


Stan performance tests fail when setting macro NDEBUG

Description
Scrounging for optimizations wherever I can I noticed we did not set the NDEBUG macro flag which can have some nice teny benefits. However setting the NDEBUG macro at compile time causes the SIR test to fail. If we don't support NDEBUG being defined we should catch it and throw an error message. Otherwise we should figure out how that happens. @wds15 have you ever seen test failures for that before?
Example
git clone --recursive https://github.com/stan-dev/performance-tests-cmdstan
cd performance-tests-cmdstan

replace compare-git-hashes.py with the version here that changes the compiler flags on the second iteration.
./compare-git-hashes.sh "stat_comp_benchmarks/benchmarks/sir/ -j32 --runs 1" develop develop develop develop

Failure's are here everything is off by a good bit.
Expected Output
Tests pass
Current Version:
v3.2.0

This is new to me and should be resolve.

@SteveBronder, I just ran it and it didn't reproduce.
Mind making it a little simpler for me to follow along? Can you commit the changes on a branch and I'll see if I can reproduce it locally?

I'll retry this tmrw. Would be great if this went away magically. Dan what compiler and cpu are you using?

I'm on a MacBook Pro:
$ clang++ --version
Apple clang version 12.0.0 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin19.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
2.9 GHz Quad-Core Intel Core i7
On Wed, Nov 25, 2020 at 12:45 AM Steve Bronder<EMAIL_ADDRESS>wrote:

I'll retry this tmrw. Would be great if this went away magically. Dan what
compiler and cpu are you using?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/issues/1939#issuecomment-733480374, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADH6F5JXTS2BFA6CEYRPDDSRSKXTANCNFSM4N5UBEOA
.

@SteveBronder, any updates?


Improve readme

The objective of this pull request is to set up the repository so we can make further contributions. The script was copied as is from the blog post, so we can have the original version in the history. After this gets merged, I'll open a new pull request with fixes for building projects that depend on OpenSSL, as well as some ergonomic improvements to the build script itself.

Thanks for this. I'll merge as-is but the script has a bunch of references to the, "lobsters", project it was extracted from. It would be worth making that more generic in any future updates.

Sure. I have started working on this, tomorrow I'll open up another PR


DNP QW-410 wrong paper size

Hi, thanks for your work.
I have problems with a DNP QW-410.
I installed CUPS via ubuntu (22.04) apt and then installed Gutenprint 5.3.4 compiling it. Then I setup the printer via CUPS web interface correctly by selecting the gutenprint driver and selecting the 4x6 paper.
I added the printer successfully through Ubuntu settings but when I try to print a 4x6 picture (the one that comes from DNP as test picture), the printer prints not a 4x6 but a 4x4 I think (see attachments).
I tried the last two days by tweaking the original PPD related to the QW-410 but all the attempts print wrong image sizes.
Can anyone help with that?
Thanks!
Ubuntu 22.04
CUPS version 2.4.1

I think you need to report this to the Gutenprint folks - there are no attachments but ordinarily these sorts of issues turn out to be either Gutenprint or cups-filters issues and are not specific to CUPS itself.


Scalars do not show if run is terminated early

If the operation is interupted by for example ctrl + c then guild compare does not show the scalars that have been printed so far

I was able to create this in this issue project:
https://github.com/guildai/issues/tree/master/67-scalars-do-not-show-if-run-is-terminated-early
The fix is teed up in 0.6.7.dev6 (not yet released but should be later today).


Export the Military Overlay into Multiple file format with SIDC code included

The DOD has multiple file input format.  After an analyst create the overlay, it needs to be distributed to multiple systems of record.
File types required is
[] .cxv
[] .shp
[] .txt
In the file it must include the SIDC for the system that use it for it's symbology.  example CPOF.

This issue was moved to Esri/military-symbology#281


Fix failed test on Windows 10(JP)

Test should generate error response in case of error in raw handler and should generate error response in case of error in case class handler failed on Windows 10 (JP).
Because Charset.defaultCharset().name() returns windows-31j Windos 10(JP).
Test fork and specified JVM option for avoid this problem.

Thanks again!


Num_trips doesn't sum up to num_trip_starts

Hi!
I'm trying to use compute_route_time_series on the MBTA GTFS files - I'm running a really simple script to calculate trip stats for every hour in the GTFS file, and I'm doing it in batches of days, so I'm running something like this:
import gtfstk
import sys
import pandas as pd

feed = gtfstk.read_gtfs(sys.argv[1], dist_units="mi")
start_date = sys.argv[2]
end_date = sys.argv[3]
print(feed, start_date, end_date)

trip_stats = gtfstk.compute_trip_stats(feed)

dates = [d.strftime('%Y%m%d') for d in pd.date_range(start_date, end_date)]
dfs = []
for d in dates:
    print(d)
    dfs.append(gtfstk.compute_route_time_series(feed, trip_stats, d, freq="1h"))

df = pd.concat(dfs)

Then, when I look at num_trips vs num_trip_starts, I see weird patterns. I would expect num_trips to be a version of num_trip_starts where they are piece-wise distributed among the bins depending on how much of the duration of the trip falls within the bin, which means when you sum it it should add up to the same value, right? Here is each value I have for each route, and the values are clearly related but have a very large discrepancy. Any idea why?

Hi makmanalp,
When GTFSTK computes a route time series, both num_trip_starts and num_trips are computed at minute frequency, then downsampled to the desired frequency, e.g. hour-frequency, but the kind of downsampling differs for the two quantities.
The num_trip_starts for the hour is the sum of the (integer) num_trip_starts for each minute, but the num_trips for the hour is the mean of the (integer) num_trips for each minute.
Downsampling by the mean makes sense in the latter case, because num_trips represents the number of trips in service during the hour and not all trips that start in the hour run the entire hour.
Taking the mean will weight the trip counts by the fraction of the hour for which the trips are in service.
For example, if two trips start in the hour, one runs for the entire hour, and the other runs for half the hour, then num_trip_starts will be 2 and num_trips will be 1.5 for that hour.
I don't know what sum you are referring to in your question, but does my answer clear your confusion?
Maybe i should elaborate the docs on this point.

I will elaborate this point in the docs in the next version.


matrix-synapse: build a pythonEnv out of extraPackages to include dependencies

Description of changes
By just appending site-packages to the extraPackages, you would get situations like pysaml2 being included in pythonpath, but not its dependencies like pytz and dateutils. This PR changes from just prepending site-packages to building a real pythonEnv including the extraPackages.
We could also mix the two pythonEnvs to a single one
This seems to work and resolve the issue of using saml2 with the new package structure, but maybe there's some reason it wasn't done like this in the first place?
This was tested in https://github.com/dali99/nixos-matrix-modules and the nixos tests in nixpkgs

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

We could also mix the two pythonEnvs to a single one

I am thinking that this would be less complex. Anyone else has an opinion on this?

Okay, they now share an env


Netsparker team id fix - how to handle multi tenancy

Situation
Netsparker has (currently) following permission model:
user1a (=Team1 = Team1 admin)
|_user1b
|_user1c

user2a (=Team2 = Team2 admin)
|_user2b
|_user2c

so when user1a scans something user1b and user1c will have access to all of these results. But user2a,user2b,user2c will not have access.
At the moment we provide only one Team means, when we would give users access to netsparker UI, they will see all results .
Wanted
Every project user should only see its own project results.
Obstacles
One thought solution was to define a team for every sechub project and give access to users
inside this team only.
Unfortunately netsparker users must all have unique email adresses and we got a 1:1 mapping between team admin and users, means when we got a user which is in project1 and project2 we could not manage this situation - except when we add two different email addresses (means accounts) to same person! So a solution by just setting up for netsparker teams for each sechub project will not work!
Solution
Netsparker provides a mechanism called "website groups". Inside these groups you can give explicit permissions.  Having a website group defined those scans are no longer visible for all users but only dedicated ones.
Example:
user1a (=Team1 = Team1 admin)
|_user1b
|_user1c
|_website-group1 (contains. test1.example.com)
   |_assign user1b to this group
|_website-group2 (contains. test2.example.com)
   |_assign user2b to this group

In the example before user2b has only access t o scans for test2.example.com.
So this solves our problem and we have no
Consequences

If you need to separate results because of need of multi tenancy you are currently forced
to create website groups (manual) and add users to these website groups (manual)

Close issue because described workaround

is related to #58


Documentation error for mod helper

The documentation under "Combination of keys" appears to be incorrect. It shows 'ctrl+s' and 'command+s' where it should be 'mod+s'.

Oh wow. This is very bizarre. This shows up correctly for me:

I just made a lot of updates to Rainbow (my syntax highlighting library) so I wonder if it is some sort of strange issue there. If you disable javascript on the page does it show up correctly?

I just checked the page again and it's correct now. Weird. I also took a
look at my browser history to make sure I wasn't on some other website (I
tend to rely on Google too much), and confirmed that I was at
https://craig.is/killing/mice. So I guess it's no longer a problem.
BTW, great library! We're using it pretty heavily in an Ember project and
it's been working great.
On Tue, Jul 5, 2016 at 9:34 AM, Craig Campbell<EMAIL_ADDRESS>wrote:

Oh wow. This is very bizarre. This shows up correctly for me:
[image: v3h1]
https://cloud.githubusercontent.com/assets/259316/16592019/b158ad30-42ac-11e6-9f52-c7a05e80b653.png
I just made a lot of updates to Rainbow (my syntax highlighting library)
so I wonder if it is some sort of strange issue there. If you disable
javascript on the page does it show up correctly?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ccampbell/mousetrap/issues/347#issuecomment-230531413,
or mute the thread
https://github.com/notifications/unsubscribe/AB1-5tas5kHalvhyMocgLQ4F9RuOq1Wqks5qSoeegaJpZM4JFS1W
.

Thank you! Glad to hear it.
So weird. So rainbow processes the syntax highlighting using a webworker and assigns it back to the proper div using a randomly generated identifier:
https://github.com/ccampbell/rainbow/blob/3374f1322bfa01885ce7d19a7c5021336af09513/src/rainbow.js#L162
So I suppose this is technically possible if somehow both of those blocks were assigned the same identifier, but I feel like that is extremely unlikely. Going to close this out for now then.


Use secure heap for BigNum in OpenSSL.

Fix #26

Out of scope for this PR, but I think the equivalent is not happening for the pure rust implementation, correct?

@berendsliedrecht seems like that. I don't expect zeroing from default BigNum implementation.
Another side question: is the pure rust usable at all? I tried some tests and got x15 slow down vs openssl.

@berendsliedrecht seems like that. I don't expect zeroing from default BigNum implementation.

Probably have to add there then as well.

Another side question: is the pure rust usable at all? I tried some tests and got x15 slow down vs openssl.

Yes, it is usable. The downside of the pure rust implementation is that it does not rely on openssl's massively optimized safe prime generator. Right now, IIRC, we rely on glass_pumpkin for this, which does not have access to a lot of asm optimizations.
Mike, the author of glass_pumpkin has created another library unknown_order which we should probably use for all BN related work. It comes built in with a pure rust, openssl and GMP versions. This would remove quite a bit of code from this repository, but that is for another time I'd say.


Rewrite UnitTests to PyTest

@davidism mentioned here that there is a plan to rewrite tests to be using PyTest layout instead of UnitTest. I have some spare time so I can start work on that if it helps to the project.

Yeah, if you want to start rewriting things to use pytest patterns, that's great. I think the PRs are low enough at this point to deal with the few tests they affect.

You can do it in phases, that's fine. Might be good to break large files apart into directories.

OK, then the first PR is out. I will think about the file split, that's a good idea.

@davidism I'm back from the vacations. I see that there are some changes in the directory structure.  Can you please share how run the tests locally ? Then I can continue with the work on this issue ;-)

You must install the project in editable mode in your virtualenv: pip install -e .

Hi @jirivrany, I was wondering if this is still something you are working on?

Hi @ftm, to be honest, I'm currently overloaded by other tasks and I don't have time to work on this.  Should I close the issue? I hope that during the summer months I will have some time to return and finish this task.

Don't close the issue, since this is still something we'd like to do. Don't stress over it though, I'll make a branch and start converting the tests and if you want to contribute a few then you're welcome to :) .


Slash Command - xkcd search emphemeral

depends on #16
xkcd search should confirm with the user using ephemeral messages that it has found the comic they wanted, allowing the user to cancel if it has found the wrong one.

Since this would involve multiple interactions of different types (slash command + button) and potentially concurrent invocations by multiple users, we would need to keep track of the interaction in the database. Shouldn't be difficult, but would take some planning

I'll take this chance here to add on the additional feature of search by term instead of by number. For now, it only searches by order number but this would be a good chance to add in searching by a related term.


Any plan of implementing the addBatch(String query) in future?

https://github.com/xerial/sqlite-jdbc/blob/5105677bb66e0245bf76fc1175d0be3f30833c8e/src/main/java/org/sqlite/jdbc3/JDBC3PreparedStatement.java#L546

I have no explicit timeline to work on that. Your contribution is welcome :)

You should not:
https://docs.oracle.com/javase/8/docs/api/java/sql/Statement.html#addBatch-java.lang.String-

Note:This method cannot be called on a PreparedStatement or CallableStatement.


Error installing the integration test tool in v2.6.1

I'm trying to install the krakend-integration tool, using the instructions in the documentation. I'm building a docker image using Go 1.22.2
 > [ 6/21] RUN go install<EMAIL_ADDRESS>#9 1.200 go: downloading github.com/krakend/krakend-ce/v2 v2.6.1
#9 5.344 go<EMAIL_ADDRESS>version constraints conflict:
#9 5.344<EMAIL_ADDRESS>parsing go.mod:
#9 5.344        module declares its path as: github.com/krakendio/krakend-ce/v2
#9 5.344                but was required as: github.com/krakend/krakend-ce/v2

The same occurs if I run the command on my mac with Go 1.18.
Am I missing something?

Hi @torresdiego ,
The documentation is wrong; we will correct it. Use go install<EMAIL_ADDRESS>instead


Multithreaded implementation

basic multi-threaded behavior and coverage added

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@9904874). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #2   +/-   ##
=======================================
  Coverage        ?   98.49%
=======================================
  Files           ?        5
  Lines           ?      133
  Branches        ?        0
=======================================
  Hits            ?      131
  Misses          ?        2
  Partials        ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


PMC Tools: Read project.assets.json as UTF8

Because they don't write a BOM/signature, so it gets interpreted as ASCII.
We mitigate these types of problems in EF by always using File.WriteAllText(path, contents, Encoding.UTF8) instead of File.WriteAllText(path, contents) which write UTF8 but without a signature.

We're following up with the NuGet team determine if this is the best fix.


Allow image extensions in widgets

Currently you have to omit extensions of images in widgets. Either allow extensions or at least have a nice error message if usera get it wrong.

Hi, can you please provide steps to reproduce? I'd like to start working on this but I am unfamiliar with the project. Thanks!

Hi Max,
Here arw some examples: http://docs.missionpinball.org/en/dev/examples/assets_and_image/index.html for images in slides. To get a working machine you could go through the first five steps of our tutorial: http://docs.missionpinball.org/en/dev/tutorial/index.html.
The issue is caused by asset loading. See this last example for a config: http://docs.missionpinball.org/en/dev/examples/assets_and_image/index.html#id3. If you do not specify your assets explicitly this is exactly what we generate internally.

@maxpereira if you're not on this anymore I'd like to give it a try :)

Go ahead and give it a shot! I couldn’t get MPF to run on my computer.


rosGenericMsg : invalid type

Hello, i'm trying to run ros_sever with SRS.
ros_sever, ros_libs folder are in this directory "C:\Users\MHM\Documents\Staubli\SRS\ros_test2\Controller1\usr\usrapp"
which is a cell dicrectory.
I opened ros_sever application and used emulator to run
+Disk->ros_server
but error occur and log says "rosGenericMsg: rosGenericMsg : invalid type"
I set the TCP sever two socket (Feedback, Motion) but same error occurs.
same rosGenericMsg error occurs when i tried real robot.
Am i missing something? or  is there a problem ?
thx!

Interestingly, I am also facing the same problem now,
Any suggestion would be highly appreciated :)
Thanks a  lot

Interestingly, I am also facing the same problem now,
Any suggestion would be highly appreciated :)
Thanks a  lot

Tbh I don't know immediately what would cause this.
Seeing as you're both running into the same problem, perhaps a good first step would be to provide details on:

(virtual) controller versions
system software versions
VAL3 versions
how you retrieved a copy of the VAL3 source
how you copied the code to the controller / simulation

etc.
The type is defined here: ros-industrial/staubli_val3_driver/staubli_val3_driver/val3/ros_server/ros_server.dtx, so it's definitely provided by the sources.

Tbh I don't know immediately what would cause this.
Seeing as you're both running into the same problem, perhaps a good first step would be to provide details on:

(virtual) controller versions
system software versions
VAL3 versions
how you retrieved a copy of the VAL3 source
how you copied the code to the controller / simulation

etc.
The type is defined here: ros-industrial/staubli_val3_driver/staubli_val3_driver/val3/ros_server/ros_server.dtx, so it's definitely provided by the sources.

Sorry for late reply
(virtual) controller versions : CS8 (not sure where i can check in virtual env but my real controller version is CS8)
system software versions : SRS 2019.7.2
VAL3 versions : s7.11.2
how you retrieved a copy of the VAL3 source : I download from this page, and put ros_libs, ros_server folder into usr/usrapp folder which exists in cell location. (I'm not sure i understand your question well..)
how you copied the code to the controller / simulation : for controller, i used FTP surfer to put ros_libs, ros_server into usr/usrapp for controller, and simulation is same as above method
I noticed that when i first start the SRS Cell, 7 error occurs.
datatype 'rosTrajPtMsg': type 'JointTrajPtMsg" is unknown.
datatype 'rosTrajPtFMsg': type 'JointTrajPtFMsg" is unknown.
datatype 'rosStatusMsg': type 'RobotStatusMsg" is unknown.
datatype 'rosJointMsg': type 'JointStateMsg" is unknown.
datatype 'rosTrajFbkMsg': type 'JointFbkMsg" is unknown.
datatype 'rosGenericMsg': type 'RosSimpleMsg" is unknown.
datatype 'qMoveBuffer': type 'Queue" is unknown.
(some spelling might wrong since i translate the korean error msg to english)
maybe problem some files from ros_libs ? or i copied wrong place?
(both ros_server folder and ros_libs folder are located C:\Users\MHM\Documents\Staubli\SRS\ros_test2\Controller1\usr\usrapp here)
or do i have to "open application" for all the ros_libs files?
not sure what is the problem at all, i'd appreciate any tips, ideas.
If you need more information to figure out i will give it to you.
thx.

Sorry for late reply
(virtual) controller versions : CS8 (not sure where i can check in virtual env but my real controller version is CS8)
system software versions : SRS 2019.7.2
VAL3 versions : s7.11.2
how you retrieved a copy of the VAL3 source : I download from this page, and put ros_libs, ros_server folder into usr/usrapp folder which exists in cell location. (I'm not sure i understand your question well..)
how you copied the code to the controller / simulation : for controller, i used FTP surfer to put ros_libs, ros_server into usr/usrapp for controller, and simulation is same as above method
I noticed that when i first start the SRS Cell, 7 error occurs.
datatype 'rosTrajPtMsg': type 'JointTrajPtMsg" is unknown.
datatype 'rosTrajPtFMsg': type 'JointTrajPtFMsg" is unknown.
datatype 'rosStatusMsg': type 'RobotStatusMsg" is unknown.
datatype 'rosJointMsg': type 'JointStateMsg" is unknown.
datatype 'rosTrajFbkMsg': type 'JointFbkMsg" is unknown.
datatype 'rosGenericMsg': type 'RosSimpleMsg" is unknown.
datatype 'qMoveBuffer': type 'Queue" is unknown.
(some spelling might wrong since i translate the korean error msg to english)
maybe problem some files from ros_libs ? or i copied wrong place?
(both ros_server folder and ros_libs folder are located C:\Users\MHM\Documents\Staubli\SRS\ros_test2\Controller1\usr\usrapp here)
or do i have to "open application" for all the ros_libs files?
not sure what is the problem at all, i'd appreciate any tips, ideas.
If you need more information to figure out i will give it to you.
thx.

Hi @benthebear93
I can't seem to recreate the error in SRS. Can you run a syntax check in SRS and show me the output?

Hi @benthebear93
I can't seem to recreate the error in SRS. Can you run a syntax check in SRS and show me the output?

@marshallpowell97

here is the error

@marshallpowell97

here is the error

@benthebear93: could you please clarify how you downloaded the files of the driver exactly?
If you downloaded any links, please tell us which links.
if you used git, please tell us how.

@benthebear93: could you please clarify how you downloaded the files of the driver exactly?
If you downloaded any links, please tell us which links.
if you used git, please tell us how.

@gavanderhoorn
i got from this git. using zip file for download to test.
also used git clone to test.
but after you said, i test it again with git clone from readme description and it works.
No error when i used "Check ros_server"
No error using SRS emulator  application manager
I didn't really changed anything. I also reused the old files that i used before today but error didn't show too, weird.
thanks for the answers though, if you need any more information i love to answer.

@gavanderhoorn
i got from this git. using zip file for download to test.
also used git clone to test.
but after you said, i test it again with git clone from readme description and it works.
No error when i used "Check ros_server"
No error using SRS emulator  application manager
I didn't really changed anything. I also reused the old files that i used before today but error didn't show too, weird.
thanks for the answers though, if you need any more information i love to answer.

then the same questions about how you checked out the sources for @SinaMirrazavi.

then the same questions about how you checked out the sources for @SinaMirrazavi.

I'm going to close this.
It seems @benthebear93's problem was resolved.
@SinaMirrazavi: if you're still experiencing problems, please post an update in a comment here.

I'm going to close this.
It seems @benthebear93's problem was resolved.
@SinaMirrazavi: if you're still experiencing problems, please post an update in a comment here.

Sorry for the late reply. I exactly followed the same procedure benthebear93 described and by cloning the repo the problem was sovled.

Sorry for the late reply. I exactly followed the same procedure benthebear93 described and by cloning the repo the problem was sovled.

So downloading the .zip didn't work, but git clone-ing it did work?
Did you git clone on Windows? Or on Linux and then copied the files to the Windows machine?

So downloading the .zip didn't work, but git clone-ing it did work?
Did you git clone on Windows? Or on Linux and then copied the files to the Windows machine?

@gavanderhoorn
So i tried to re-generate the error but couldn't
git clone from window (worked)
download .zip from window(worked)
git clone at linux and move to window machine (worked)
download .zip from linux and move to window machine (worked)
it's weird but everything works for me now.

@gavanderhoorn
So i tried to re-generate the error but couldn't
git clone from window (worked)
download .zip from window(worked)
git clone at linux and move to window machine (worked)
download .zip from linux and move to window machine (worked)
it's weird but everything works for me now.

Hm.
Then unless @SinaMirrazavi tries this as well and reports something else, I don't believe we'll be able to figure out what went wrong.

Hm.
Then unless @SinaMirrazavi tries this as well and reports something else, I don't believe we'll be able to figure out what went wrong.

does SRS / the controller require Windows line-endings?

@gavanderhoorn I don't believe so. If it did, I think we would see more errors than that.
Like you said, the type is provided by the source, so I don't think the problem is in the repo.

Re-opening as it seems others have ran into this now as well.
See #28.

So I encountered same problem today as i tried to change some code in ros_server.
And i took a time to test few things

using USB to run ros_server NO WORKING
git clone and download .zip both WORKS

using SRS to send the ros_sever&ros_lib to controller and run ros_server WORKING
using FTP to send the ros_sever&ros_lib to controller and run ros_server WORKING

i guess using USB dosent work?


How to collect logs from Rancher server setup

@moelsayed , can you please draft a doc for this issue that I can edit afterwards?


Troubleshooting Guide

Purpose

Adding a troubleshooting guide to help users understand their issues better. Provides a step-by-step tutorial on how they can use our new troubleshooting tools.

Does this introduce a breaking change?
[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

How to Test
N/A
Other Information
Relevant PR for the Application Insights Workbooks repo  to add the Workbook template will follow

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: keikumata sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


$fa-font-path: '~font-awesome/fonts' is not found on Azure build

hi all
I got issue
$fa-font-path: '~font-awesome/fonts' is not found
and font-awesome module is missing
but i added it to package.json
on azure build I got error
but on local everithyng good
how to refresh npm on azure?

Do you have:
const nonTreeShakableModules = [
'font-awesome/css/font-awesome.min.css',
];
in webpack.config.vendor.js?

hi, yea I have,
but on azure deploy path not found

I think the variable is supposed to be:
$icon-font-path: '~font-awesome/fonts/';
This is what I have been using in my projects for awhile.


[$500] Android – Settings - App flickering when enter an authenticator code in 2FA creation page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.23-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to https://staging.new.expensify.com/
Log in
Tap on Settings/ Security/ Two-factor authentication
Tap on Copy and Next
Then enter any six digits in a code field.

Expected Result:
App is not flickering when enter an authenticator code in 2FA creation page
Actual Result:
App flickering when enter an authenticator code in 2FA creation page
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/79e9a3e5-08a6-4ec9-9a1d-8a4022ec4a70
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0178f42913610b69a7
Upwork Job ID:<PHONE_NUMBER>958515712
Last Price Increase: 2024-03-11

I am not able to reproduce on main. Tested on both android phone and emulator

Verified it's no longer reproducible:
https://github.com/Expensify/App/assets/7277067/38e4eb96-ba68-4f89-bc1f-bfb5b553d66c
Closing this out!

Issue is still reproducible on the latest build 1.4.48-0
Repro on Pixel (stg and prod), not repro on Samsung
https://github.com/Expensify/App/assets/78819774/16ffdd45-1bcf-4b2f-a1eb-90b7adaa687e

Hmm I just retested on a Pixel 3a and am still unable to repro. I'll assign BZ to attempt to repro/take triage from here.

@amyevans I do not see any flickering. Here is my test (pixel 3):
https://github.com/Expensify/App/assets/17131195/ceaa64a1-11db-4c14-adec-ba905e413a5c

@lanitochka17 @kbecciv I cannot reproduce the flickering but I noticed that in both videos where it is reproducible, there's an auto-fill suggestion which neither Amy nor I have. I'm not sure how to reproduce this. Do you guys know where that suggestion is coming from? Katya I see yours says autofill but I can't quite see from where, maybe "з почты"? Sveta, your video shows "from messages". So both of your apps are trying to auto-fill from SMS messages? Did you recently receive a code by SMS that might be affecting the test?
I tried logging into an app that sends me a SMS code and didn't read it. Then tried the test and I did not get the "auto fill from messages". Not sure how to repo the behavior you're seeing.

My test, no auto-fill suggstion

Asked in #qa: https://expensify.slack.com/archives/C9YU7BX5M/p1710168520121459

I guess we can go external with it and see if we get any traction, but if not I could also see us closing after a week or two.

Awaiting proposals

Alright it's been a week and we don't have any proposals, it's also not assigned to a wave or VIP so not a priority. I'm going to close, but feel free to reopen if you disagree @sonialiap!


Email Application opening on clicking Email ID on the footer

Is your feature request related to a problem? Please describe.
An email is mentioned on the website so that if someone clicks it must open a mail application to seamlessly send a mail. That is exactly the feature I want to add.
Describe the solution you'd like
On clicking the email mentioned on page a mail application opens up in users device with our email id already at recieving end.
Describe alternatives you've considered
If not this then there is no such use of email link so we can remove it.
Additional context
It is important that the mail feature makes it easier for user to send mail.

Kinfly , don't raise so many issues at once, complete 1-2 issues then raise a new one .👍


Flesh out client keystore and truststores

I had to get client certificates working with a CA and wanted to set up different truststores for client and server, with the trust stores containing no private keys.
I tweaked things a bit to add an organization prefix and to use the password throughout the system in both openssl, and to break statements over multiple lines where the parameter had required arguments.
Probably need a link to https://stackoverflow.com/a/907515 to expand on the problem with keytool and private keys.
There may be a way to use openssl to import certificates without private keys, but when I used -nokeys to import just the ca.pem, it would tell me there was nothing in the PKCS12 file at all.  Keytool was fine with that, so I just did it in the reverse direction.

Thanks for the PR @wsargent - is this good to merge as far as you are concerned?

I’ll take another look at it tonight.

On Aug 21, 2018, at 2:30 PM, Drew Farris<EMAIL_ADDRESS>wrote:
Thanks for the PR @wsargent - is this good to merge as far as you are concerned?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

There's only one change which I'm on the fence here The java keystore does not keep track of aliases, but defines its own explicitly -- that is, it defines alias which is not always desirable.
keytool -importkeystore \
  -srckeystore ${NAME}-server-keystore.p12 \
  -srcstorepass:env PW \
  -alias "$NAME-server" \
  -srckeypass:env PW \
  -srcstoretype pkcs12 \
  -destkeystore ${NAME}-server-keystore.jks \
  -deststoretype jks \
  -deststorepass:env PW

If you want to use the alias already existing from the pkcs12 store, you'd remove the alias / keypass:
keytool -importkeystore \
  -srckeystore ${NAME}-server-keystore.p12 \
  -srcstorepass:env PW \
  -srcstoretype pkcs12 \
  -destkeystore ${NAME}-server-keystore.jks \
  -deststoretype jks \
  -deststorepass:env PW

The issue is that pkcs12 doesn't really HAVE the concept of an alias, and so it kind of gets made up:  https://stackoverflow.com/questions/25349631/keytool-list-shows-different-aliases-for-p12-keystore-depending-on-whether-you
Anyway, more information than you ever wanted to know about keystores here:
https://tersesystems.com/blog/2018/07/28/building-java-keystores/

There's only one change which I'm on the fence here The java keystore does not keep track of aliases, but defines its own explicitly -- that is, it defines alias which is not always desirable.

In practice I can't recall any time that I've used or needed the alias feature of java keystores. So I'd lean towards not being too concerned about it . Have you run into cases where the alias in the keystore is useful?
Thanks for the references, I'll take a look to see if there's new info there that might shift my thinking.

Yes, when replacing an EE certificate with one that has a longer NotAfter, So renewing the certificate.

On Aug 23, 2018, at 10:11 AM, Drew Farris<EMAIL_ADDRESS>wrote:
There's only one change which I'm on the fence here The java keystore does not keep track of aliases, but defines its own explicitly -- that is, it defines alias which is not always desirable.
In practice I can't recall any time that I've used or needed the alias feature of java keystores. So I'd lean towards not being too concerned about it . Have you run into cases where the alias in the keystore is useful?
Thanks for the references, I'll take a look to see if there's new info there that might shift my thinking.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

realistically, I think it's not going to be an issue so LGTM :-)

Thanks @wsargent!


WIP: Fix host counter

@DavidVorick This is a first attempt to fix the host financial metrics that are off most of the time for all the hosts.
I noticed that whenever my host financial metrics increased a lot in a small period of time, there were at the same time consensus errors in the host.log. These errors always repeated themselves 6 times with 15s interval. See host.log.
Therefore, I looked at negotiate.go and found out that there is a loop that calls
err = h.managedAddStorageObligation(so) .
Worst case this function is called 6 times if there are issues with the acceptance of the transaction set (leading to the logged errors). Every time this function is called on the same storage obligation, the host financial metrics are updated.
This PR tries to fix the double counting issue. This PR will not prevent additional insertions into the host database. These additional insertions could lead to several other bugs where a host can't provide a storage proof when a storage obligation ends.
I know the focus is on upgrading the renter. But this could potentially fix a lot of errors for the hosts. Any feedback is welcome...
cc @lukechampine

This seems basically correct to me. Although, it makes me suspect that the host state isn't being properly rolled back in the event of an error. For example, there's a db.Update call earlier in the function; if managedAddStorageObligation ultimately fails, then we'd want to revert those changes, right? Perhaps that can be tackled in a subsequent PR.

@lukechampine I reverted the old and added some new commits. Please take a look if I am not missing something.
The only thing that still bothers me is the way a storage obligation with obligatonRejected status is removed within removeStorageObligation. In this PR I make use of it twice (to prevent duplication of code):

after AcceptTransactionSet return an error (this PR),
or if there is an error with a queueActionItem (original code)

Before the financial metrics are updated it checks:
h.financialMetrics.TransactionFeeExpenses.Cmp(so.TransactionFeesAdded) >= 0
but I don't know when this is true (or not). Maybe you have more insight if it works in this special case.


[FR] add support for query fields

Adds support for the gated preview feature query_fields. Also refactors code in DAC in order to support multi-api (part of https://github.com/Azure/azure-sdk-for-python/issues/29478)

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-formrecognizer


[BUG] Admin Extesions show Enable for non admin users

Summary
Some extensions can be marked as admin-only by admins.
Users can see these extensions on the extension list.
Actual Result

users see the Enable button and think they can use the extension

Expected Result

the Enable button should not be visible (or the functionality allowed on the backed)
some message should inform the user that the respective extension is only for admins

Fixed here: https://github.com/lnbits/lnbits/pull/1764


Styles from the theme are not applied to the endingIcon of the Button

I am trying to style endingIcon for button from Theme
I have multiple classes that change the button appearance and the style depends on the Tokens ,
so I need to change the endingIcon color according to the class.
Example:
Theme:
Themes:
  - DefaultTheme:
      default: true

DefaultTheme:
  label: Default theme
  Tokens:
    Colors:
      primary: "#0F216B"
      onPrimary: "white"
    FontSizes:
      S: 16
  Styles:
    .primaryButton:
      backgroundColor: ${Colors.primary}
      labelStyle:
        color: ${Colors.onPrimary}
      endingIcon:
        size: ${FontSizes.S}
        color: ${Colors.onPrimary}

View:
View:
    styles:
      scrollableView: true
      backgroundColor: green
    header:
      title: Home

    body:
      Column:
        children:
           - Button:
              className: primaryButton
              label: Hi
              endingIcon:
                library: remix
                name: close_fill

endingIcon dosn't take the style from Theme

Also didn't show any icons next to the label

@kmahmood74 is there any update on this issue

hi @Mohammad-Al-Refai this is already supported and works fine. You are missing the name under endingIcon i.e.
Themes:
  - DefaultTheme:
      default: true

DefaultTheme:
  label: Default theme
  Tokens:
    Colors:
      primary: "#0F216B"
      onPrimary: "white"
    FontSizes:
      S: 16
  Styles:
    .primaryButton:
      backgroundColor: ${Colors.primary}
      labelStyle:
        color: ${Colors.onPrimary}
      endingIcon:
        name: star
        size: ${FontSizes.S}
        color: ${Colors.onPrimary}

name is required as without it platform does not know which icon to use as endingIcon.


we're being pinned to older versions of pub packages

When running pub get / pub upgrade we're being pinned to older versions of some pub packages. In particular, dart2js is forced to use older versions of package (like dart2js_info) then it wants. It looks like this is mostly caused by the rpc package (issue filed here: https://github.com/dart-lang/rpc/issues/91).

fixed upstream


Add a isDataEqual prop, for custom Series data comparison

I felt uneasy about changing the behaviour of Lodash's isEqual to Object.is, I fear it may create confusion when upgrading versions.
Therefore, I have added an isDataEqual prop to Series, of the form
(data, prevData) => boolean

If the returned boolean is

true - data hasn't changed, then setData isn't called
false- data has changed, so setData is called

This allows users to override the default Object.is behaviour, and re-inject Lodash's isEqual if they choose.

Codecov Report

Merging #254 into master will decrease coverage by 0.37%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
- Coverage   90.23%   89.86%   -0.38%
==========================================
  Files          78       82       +4
  Lines         973     1026      +53
  Branches      179      195      +16
==========================================
+ Hits          878      922      +44
- Misses         82       91       +9
  Partials       13       13

Impacted Files
Coverage Δ

...act-jsx-highcharts/src/components/Series/Series.js
97.01% <100%> (+0.04%)
:arrow_up:

...s/react-jsx-highmaps/src/components/XAxis/XAxis.js
100% <0%> (ø)

...s/react-jsx-highmaps/src/components/YAxis/YAxis.js
100% <0%> (ø)

packages/react-jsx-highmaps/test/test-utils.js
47.05% <0%> (ø)

...omponents/HighchartsMapChart/HighchartsMapChart.js
100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92d4a43...1b0d553. Read the comment docs.


Update .travis.yml

Hi @andreybolonin , thanks for the contribution, however 7.4 build on Travis is still broken and we cannot use it, see https://github.com/facebook/php-webdriver/pull/708#issuecomment-563214676 .


[gts] compile gts on osx

compile gts on osx:

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[x] The "supports" clause reflects platforms that may be fixed by this new version
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

I close it for now, I will come back it later.


[PHP 8] Warning on EncodesUrl

The following PHP warning is generated under PHP 8:
League/OAuth1/Client/Signature/HmacSha1Signature::League/OAuth1/Client/Signature/{closure}():
Argument #2 ($value) must be passed by reference, value given in
/vendor/league/oauth1-client/src/Signature/EncodesUrl.php on line 54

Seems to be caused by the second parameter being passed as a reference. Removing the '&' symbol from value seems to work for me, but I don't know if there are greater implications outside of my particular use case.

Submitted PR #128 to fix this.

Thanks Matt! I’ll take a look 👍

Submitted https://github.com/thephpleague/oauth1-client/pull/129 to not only get rid of the exception, but actually make the code do what it was supposed to do - that is, normalize keys and values. First time doing a pull request, so I hope I didn't do any mistakes. 😅

Great. Thanks!

@bencorlett would you mind taking a look? Thanks!

Any idea when a new release is going to be issued? Laravel Socialite is using this library and currently the Twitter Login is broken on PHP 8 because of this bug. :(

@bencorlett: Could you please create a new version since this bug is in the current released version 1.8.2 which is not usable due to this bug. That would be great.

I anticipate that I’ll have 1.9.0 out within a day or two. Thank you for your patience.

Sounds great, thx a lot

@bencorlett any update on getting 1.9.0 out the door? Sorry to be a nuisance. Thanks!

I am away for the Christmas holidays. Will be early in the new year. Thanks
Sent from my iPhone

On 27 Dec 2020, at 9:52 pm, Matt Kingshott<EMAIL_ADDRESS>wrote:

@bencorlett any update on getting 1.9.0 out the door? Sorry to be a nuisance. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@bencorlett really sorry to be a nuisance buddy, but is there any chance of 1.9.0 getting tagged this week as I'm hoping to push a major new app version next week that uses this library with PHP 8?

@bencorlett really sorry to be a nuisance buddy, but is there any chance of 1.9.0 getting tagged this week as I'm hoping to push a major new app version next week that uses this library with PHP 8?

Because of issues like this in the past, we ended up creating a GitHub organization account where we fork all repositories we use in our projects. You can then decide whether to always use the own fork or only use the fork when a fix is taking too long in upstream.

Because of issues like this in the past, we ended up creating a GitHub organization account where we fork all repositories we use in our projects. You can then decide whether to always use the own fork or only use the fork when a fix is taking too long in upstream.

@mattkingshott thanks for your interest, and patience in the project mate :) I haven't been committing too much time to OSS over the past couple of weeks but rather spending quality time away from the computer with my family.
There's a few moving parts to getting the next release out. Firstly, we need to get this PR to build so that we can merge it in. There's a few prerequisites for that, namely working around php-cs-fixer's lack of PHP 8 support and also hacking past PHPStan's errors regarding OpenSSL changes in PHP 8, such as this and this.
Given the large user base of this library, both directly and through Laravel packages, it's imperative that the release goes smoothly. The additional checks and balances performed by analysis tooling are there to pick up potential issues, so any workaround for their support for PHP 8 must be carefully considered.
I'm currently camping with limited internet access however I'm prioritising getting this PR to build so I can merge and release it.
@smares' suggestion is something I regularly do as well - you can read more on that here :)
Thanks!

@mattkingshott thanks for your interest, and patience in the project mate :) I haven't been committing too much time to OSS over the past couple of weeks but rather spending quality time away from the computer with my family.
There's a few moving parts to getting the next release out. Firstly, we need to get this PR to build so that we can merge it in. There's a few prerequisites for that, namely working around php-cs-fixer's lack of PHP 8 support and also hacking past PHPStan's errors regarding OpenSSL changes in PHP 8, such as this and this.
Given the large user base of this library, both directly and through Laravel packages, it's imperative that the release goes smoothly. The additional checks and balances performed by analysis tooling are there to pick up potential issues, so any workaround for their support for PHP 8 must be carefully considered.
I'm currently camping with limited internet access however I'm prioritising getting this PR to build so I can merge and release it.
@smares' suggestion is something I regularly do as well - you can read more on that here :)
Thanks!

@bencorlett no worries mate. I've made a fork for now.
Enjoy time off with the family :)

@bencorlett no worries mate. I've made a fork for now.
Enjoy time off with the family :)

namely working around php-cs-fixer's lack of PHP 8 support

you can use PHP CS Fixer 2.18+ for PHP 8

namely working around php-cs-fixer's lack of PHP 8 support

you can use PHP CS Fixer 2.18+ for PHP 8

namely working around php-cs-fixer's lack of PHP 8 support

you can use PHP CS Fixer 2.18+ for PHP 8

Wonderful! I saw they released this a couple of days back. I've got a workaround in place and I have published v1.9.0, but I'll look to upgrade this at some point.

namely working around php-cs-fixer's lack of PHP 8 support

you can use PHP CS Fixer 2.18+ for PHP 8

Wonderful! I saw they released this a couple of days back. I've got a workaround in place and I have published v1.9.0, but I'll look to upgrade this at some point.


Add Kotlin Ktor RESTful getting started example

Since project is using Kotlin, it could make sense to include simple RESTful application based on Kotlin Ktor framework to lure Kotlin growing backend developers. Functionality could be similar to one in #133 and it should use Jib to build images.

Deprecated. https://github.com/GoogleCloudPlatform/google-cloud-intellij/issues/2367


Calendar loading randomly fails if files stored locally

Platform: Raspberry PI 4 (bullseye)
Node Version: 20.5.1
MagicMirror² Version: 2.26.0
Description:
I have several calendars stored locally and they are set in the config file as: url: "webcal://<IP_ADDRESS>:8090/modules/calendar_files/geburtstage.ics" and fetchInterval: 120000. The files only change once per day. However, I often receive messages that the calendar cannot be loaded.
A typical error message is:
[18.01.2024 20:02.38.254] [ERROR] Calendar Error. Could not fetch calendar:  http://<IP_ADDRESS>:8090/modules/calendar_files/geburtstage.ics TypeError: fetch failed
    at Object.fetch (node:internal/deps/undici/undici:11576:11) {
  cause: Error: read ECONNRESET
      at TCP.onStreamRead (node:internal/stream_base_commons:217:20) {
    errno: -104,
    code: 'ECONNRESET',
    syscall: 'read'
  }
}

A few minutes later the calendar can be loaded without any change to the file. Sometimes one of the other calendars fail.
I changed the log level to DEBUG but there is no additional information at that time. The previous message comes from another calendar file:
[18.01.2024 20:02.38.164] [INFO]  Calendar-Fetcher: Broadcasting 50 events from http://<IP_ADDRESS>:8090/modules/calendar_files/privat.ics.

The next message is related to a third file:
[18.01.2024 20:02.38.518] [DEBUG] parsed data={"8b65f88b-4983-40f1-9060-898f88c31eb5":{

If I don't load the biggest calendar file (~500KB), the error does not occur. Putting the big file at the end of the files does not help.
Summary:
The configuration is correct and the calendar files are valid. If multiple are loaded and there is a bigger one (~500KB), it fails randomly.

is this new with v2.26.0 ?
are you using npm start (electron) or npm run server (server only) for starting?

in calendar config, please use localhost instead of <IP_ADDRESS>, which means any/all interfaces

we have already other problems with the node version which is used by electron v27.2.0 (which is used in the v2.26.0 release).
So you could test with a newer elctron version with npm install<EMAIL_ADDRESS>

in calendar config, please use localhost instead of <IP_ADDRESS>, which means any/all interfaces @drtorchwood

I followed this approach (#3147) but will try with <IP_ADDRESS> later.

we have already other problems with the node version which is used by electron v27.2.0 (which is used in the v2.26.0 release).
So you could test with a newer elctron version with npm install<EMAIL_ADDRESS>
I tested both proposals (<IP_ADDRESS> and  npm install<EMAIL_ADDRESS>but they do not solve the issue.
In the meantime, realized that the first time the error occurs, it is slightly different:
[22.01.2024 18:25.23.892] [ERROR] Calendar Error. Could not fetch calendar:  http://<IP_ADDRESS>:8090/modules/calendar_files/feiertage2.ics TypeError: fetch failed
    at Object.fetch (node:internal/deps/undici/undici:11576:11) {
  cause: SocketError: other side closed
      at Socket.onSocketEnd (node:internal/deps/undici/undici:9790:26)
      at Socket.emit (node:events:526:35)
      at endReadableNT (node:internal/streams/readable:1359:12)
      at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
    code: 'UND_ERR_SOCKET',
    socket: {
      localAddress: '<IP_ADDRESS>',
      localPort: 58200,
      remoteAddress: undefined,
      remotePort: undefined,
      remoteFamily: undefined,
      timeout: undefined,
      bytesWritten: 492,
      bytesRead: 441164
    }
  }
}

After that, the messages for every refresh is (as mentioned in the initial post):
[22.01.2024 18:27.30.243] [ERROR] Calendar Error. Could not fetch calendar:  http://<IP_ADDRESS>:8090/modules/calendar_files/feiertage2.ics TypeError: fetch failed
    at Object.fetch (node:internal/deps/undici/undici:11576:11) {
  cause: Error: read ECONNRESET
      at TCP.onStreamRead (node:internal/stream_base_commons:217:20) {
    errno: -104,
    code: 'ECONNRESET',
    syscall: 'read'
  }
}

I reverted to v2.24.0 (using git checkout e87f50e (hope that this is correct)) and the error has not occurred for several hours. I will wait for some more hours to be sure. Then, I will try to identify the commit that causes the error. From the history, this one (https://github.com/MagicMirrorOrg/MagicMirror/commit/f2957f90df66a2392b190e68a923f97c9087892b) would be my starting point.

yes, we know that all that junk is coming from the internal fetch, but we don't know WHY..
this was supposed to get RID of problems.. internal fetch has been around for years and electron just picked it up recently.

I reverted to v2.24.0 (using git checkout e87f50e (hope that this is correct)) and the error has not occurred for several hours. I will wait for some more hours to be sure. Then, I will try to identify the commit that causes the error. From the history, this one (https://github.com/MagicMirrorOrg/MagicMirror/commit/f2957f90df66a2392b190e68a923f97c9087892b) would be my starting point.

you are right so far:

we replaced node-fetch with internal fetch provided by nodejs with https://github.com/MagicMirrorOrg/MagicMirror/commit/f2957f90df66a2392b190e68a923f97c9087892b
the errors you are posting above are coming from undici which is used by internal fetch
the internal fetch is experimental in nodejs v18 and official since v20
electron is still using nodejs v18, see https://releases.electronjs.org/, so maybe this is fixed in a future electron version when using a newer nodejs version
I don't think we will revert back to node-fetch

is this still an issue with latest MagicMirror Release v2.28.0?
Background: In the new release we are using electron v31 which internally uses node v20 (instead of v18 before).

seems to be solved with latest mm/electron version.


[V8] Mailimporter update

The intention of these changes is to update the mail importer classes/files.
They seemed pretty outdated. I needed this functionality from within a package and it's working now (v8.5.2).
I am not 100% sure if e.g. Zend_Mail_Storage_Pop3 can savely be changed to Zend\Mail\Storage\Pop3 on every system.
Nonetheless - it threw exceptions on my system with PHP Version 7.3 and the sources of the importer classes
were not touched since three years.
Please review.
We are using this within a custom package checking mails from within a job, reading and saving data from a csv file sent every day at 5AM.
Fixes: #1622
Test environment
# concrete5 Version
Core Version - 8.5.2
Version Installed - 8.5.2
Database Version -<PHONE_NUMBER>2210

# Database Information
Version: 10.3.21-MariaDB
SQL Mode: STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION

# concrete5 Packages
*private* (0.0.1)

# concrete5 Overrides
single_pages/login.php

# concrete5 Cache Settings
Block Cache - Off
Overrides Cache - Off
Full Page Caching - Off
Full Page Cache Lifetime - Every 6 hours (default setting).

# Server Software
nginx/1.16.1

# Server API
fpm-fcgi

# PHP Version
7.3.16

# PHP Extensions
apcu, bcmath, bz2, calendar, cgi-fcgi, Core, ctype, curl, date, dba, dom, exif, fileinfo, filter, ftp, gd, gettext, gmp, hash, iconv, imap, intl, json, ldap, libxml, mailparse, mbstring, mysqli, mysqlnd, openssl, pcntl, pcre, PDO, pdo_dblib, pdo_mysql, pdo_pgsql, pdo_sqlite, pgsql, Phar, posix, readline, Reflection, session, shmop, SimpleXML, soap, sockets, sodium, SPL, sqlite3, ssh2, standard, sysvmsg, sysvsem, sysvshm, tokenizer, wddx, xml, xmlreader, xmlrpc, xmlwriter, xsl, Zend OPcache, zip, zlib

# PHP Settings
max_execution_time - 3600
log_errors_max_len - 1024
max_file_uploads - 20
max_input_nesting_level - 640
max_input_time - 36000
max_input_vars - 10000
memory_limit - 1024M
post_max_size - 64M
upload_max_filesize - 32M
ldap.max_links - Unlimited
mbstring.regex_stack_limit - 100000
mysqli.max_links - Unlimited
mysqli.max_persistent - Unlimited
pcre.backtrack_limit - 1000000
pcre.recursion_limit - 100000
pgsql.max_links - Unlimited
pgsql.max_persistent - Unlimited
session.cache_limiter - <i>no value</i>
session.gc_maxlifetime - 7200
soap.wsdl_cache_limit - 5
opcache.max_accelerated_files - 500000
opcache.max_file_size - 0
opcache.max_wasted_percentage - 5

Test case

Create a package
Add src/Mail/Importer/Type/TestMailImporter.php (copy and rename controler etc. from PrivateMessage)
Register in package with your settings:

\Concrete\Core\Mail\Importer\MailImporter::add([
      'miHandle'           => 'test_mail_importer',
      'miPort'             => 0,
      'miIsEnabled'        => true,
      'miEncryption'       => 'SSL',
      'miConnectionMethod' => 'IMAP',
      'miServer'           => '',
      'miUsername'         => '',
      'miPassword'         => '',
      'miEmail'            => ''
    ], $this);

Generally if you see it in {page}/dashboard/system/mail/importers/ it's working

Info:
This is my/our first pull request on an open source project ever.
Since we extensively using C5 now I/we would like to contribute any changes/bug fixes/additions
done to the core to the project available for others. Expect to see more coming this year.
Just to ask... which branch is preferred for pull requests? Why is it showing commits of other contributers when I point to concrete5:develop eventhough I have just created the new branch?
Greetings from KoalaSoft, Düsseldorf Germany!

I added new functionality to the ImportedMail class:

delete() method which uses the unique id of the mail
moveTo() method to move the mail to a different folder
getAttachments() method to retrieve an array of attached files with {type, name, content}

Thank you! I apologize for not seeing this sooner. Must have had my head down and wanted to come back to it later. Thank you for the work on this. I've merged it by hand into the latest develop branch.


Cut Plane Graphics for Batched Tiles

This modification allows cut plane graphics to be generated for batched tiles.

@pmconne Paul, I've put this up as a draft PR so you can look at it.  It's probably not what you were expecting, but it seems to work just fine.

@MarcNeely plans to run ImageTests to check for any unintended consequences.


Fix uninstall CoreMetrics (3x)

Close https://github.com/neo-project/neo-cli/issues/366

Is not possible to fix without travis


QSIPrep failed: 'DynamicTraitedSpec' object has no attribute 'btable_t1'

On qsiprep 0.18.0, HCP-style dMRI data with RPE series. It fails with the error if I include --distortion-group-merge average.
This runs OK (so far):
singularity run   --cleanenv   --no-home   \
  -B /scratch/qsiprep.20746781.5YqJPRJQ.tmpdir:/tmp   \
  -B /project/ftdc_pipeline/templateflow:/opt/templateflow   \
  -B /appl/freesurfer-7.1.1:/freesurfer   \
  -B /project/picsl/cookpa/anx/bids:/data/input   \
  -B /project/picsl/cookpa/anx/preps/output:/data/output   \
  -B /project/picsl/cookpa/anx/preps/eddy_params_prisma.json:/config/eddy_params_prisma.json  \
  /project/ftdc_pipeline/ftdc-picsl/pmacsPreps-0.2.2/containers/qsiprep-0.18.0.sif   \
  /data/input /data/output participant   \
  --fs-license-file /freesurfer/license.txt  \
  --notrack   --nthreads 2   --omp-nthreads 2  \
   --work-dir /tmp   --stop-on-first-crash   --verbose   \
   --participant_label NDARPA762UGZ --output-resolution 1.5 \
  --eddy-config /config/eddy_params_prisma.json

but if I add --distortion-group-merge average I get
230623-15:15:24,384 nipype.workflow INFO:
	 Workflow qsiprep_wf settings: ['check', 'execution', 'logging', 'monitoring']
QSIPrep failed: 'DynamicTraitedSpec' object has no attribute 'btable_t1'
Traceback (most recent call last):
  File "/usr/local/miniconda/bin/qsiprep", line 8, in <module>
    sys.exit(main())
  File "/usr/local/miniconda/lib/python3.8/site-packages/qsiprep/cli/run.py", line 677, in main
    qsiprep_wf.run(**plugin_settings)
  File "/usr/local/miniconda/lib/python3.8/site-packages/nipype/pipeline/engine/workflows.py", line 628, in run
    execgraph = generate_expanded_graph(deepcopy(flatgraph))
  File "/usr/local/miniconda/lib/python3.8/site-packages/nipype/pipeline/engine/utils.py", line 967, in generate_expanded_graph
    graph_in = _remove_nonjoin_identity_nodes(graph_in, keep_iterables=True)
  File "/usr/local/miniconda/lib/python3.8/site-packages/nipype/pipeline/engine/utils.py", line 847, in _remove_nonjoin_identity_nodes
    _remove_identity_node(graph, node)
  File "/usr/local/miniconda/lib/python3.8/site-packages/nipype/pipeline/engine/utils.py", line 873, in _remove_identity_node
    _propagate_internal_output(graph, node, field, connections, portinputs)
  File "/usr/local/miniconda/lib/python3.8/site-packages/nipype/pipeline/engine/utils.py", line 945, in _propagate_internal_output
    value = getattr(node.inputs, field)
AttributeError: 'DynamicTraitedSpec' object has no attribute 'btable_t1'

Looks like a regression - should be a quick fix

@cookpa could you try patching in the fix/concat-avg-btable branch?
Also, why are you mounting the local freesurfer?

Thanks! I'll check out the patch later.
Freesurfer was just for the license, I guess it's bad form to mount the entire thing, I'll change my script.

Now getting a different error
Traceback (most recent call last):
  File "/usr/local/miniconda/lib/python3.8/multiprocessing/process.py", line 315, in _bootstrap
    self.run()
  File "/usr/local/miniconda/lib/python3.8/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/local/miniconda/lib/python3.8/site-packages/qsiprep/cli/run.py", line 950, in build_qsiprep_workflow
    retval['workflow'] = init_qsiprep_wf(
  File "/usr/local/miniconda/lib/python3.8/site-packages/qsiprep/workflows/base.py", line 228, in init_qsiprep_wf
    single_subject_wf = init_single_subject_wf(
  File "/usr/local/miniconda/lib/python3.8/site-packages/qsiprep/workflows/base.py", line 645, in init_single_subject_wf
    merging_group_workflows[merged_group] = init_distortion_group_merge_wf(
  File "/usr/local/miniconda/lib/python3.8/site-packages/qsiprep/workflows/dwi/distortion_group_merge.py", line 194, in init_distortion_group_merge_wf
    workflow.connect([
  File "/usr/local/miniconda/lib/python3.8/site-packages/nipype/pipeline/engine/workflows.py", line 239, in connect
    raise Exception("\n".join(["Some connections were not found"] + infostr))
Exception: Some connections were not found
Module btab_t1 has no output called btable_t1

oof I clearly need to add some CI tests for this option. Just fixed this error, hopefully that will solve it

That seems to have got it, running normally now. Thanks!


Warn about mentions in 1:1 private message conversations

Link to the issue: https://github.com/zulip/zulip/issues/17998
Tests: add node test case for warning function
HTML: edit compose.html to include div for warning
HTML: add .hbs file to render warning
typeahead: add warning call when mentioning
Added warning if mentioning a user in a one on one private message, per the issue.
Was done by editing HTML and adding a function call checking the parameters to call.
Tested to make sure it worked within the development environment and wrote test cases that check if warning appears in correct or incorrect spots

@ChloeTang99 thanks for working on this.  Can you please adjust this PR to follow Zulip's commit guidelines?  I fixed the title of this PR, but you need to write a proper commit message.  Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

Closing in favor of https://github.com/zulip/zulip/pull/27213 for this issue.


It takes some time to load the home page

thanks for the observation, a fix is coming soon

Ya its good but it has minor bugs here and there though

It takes a longer time to load the leaderboard result


syft: 0.84.1 -> 0.85.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/anchore/syft/releases.
meta.description for syft is: CLI tool and library for generating a Software Bill of Materials from container images and filesystems
meta.homepage for syft is: https://github.com/anchore/syft
meta.changelog for syft is: https://github.com/anchore/syft/releases/tag/v0.85.0
Updates performed

Golang update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.85.0 with grep in /nix/store/vr8x8239h1qk35jqvxab34y2il7cc9qf-syft-0.85.0
found 0.85.0 in filename of file in /nix/store/vr8x8239h1qk35jqvxab34y2il7cc9qf-syft-0.85.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
syft

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/vr8x8239h1qk35jqvxab34y2il7cc9qf-syft-0.85.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A syft https://github.com/r-ryantm/nixpkgs/archive/1f9d30c9af258c0d46e701a56eb7a1c21b59cfde.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/vr8x8239h1qk35jqvxab34y2il7cc9qf-syft-0.85.0
ls -la /nix/store/vr8x8239h1qk35jqvxab34y2il7cc9qf-syft-0.85.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

syft

Maintainer pings
cc @06kellyjac @developer-guy for testing.

Result of nixpkgs-review pr 244208 run on x86_64-linux 1

1 package built:

syft


unblock https://github.com/nim-lang/Nim/pull/16714

/cc @citycide
unblock https://github.com/nim-lang/Nim/pull/16714

ping @citycide , that's the only package blocking https://github.com/nim-lang/Nim/pull/16714


The Tests and UnrealEngine modules are missing

DotNetPlugin/Source/Tests And UnrealEngine There's nothing in it, After starting the project, you will receive the following prompt, The project cannot be started normally. May I ask whether something has not been uploaded or my operation is wrong

Hi, these modules are generated from managed code. You have to follow the building instructions quite carefully for it all to work due to the mentioned cyclical dependencies. Once you do code for these modules will be generated.


Gradle up-to-dateness

It's important that snapshot files are included in up-to-date checks. We should get to the bottom of when they are / aren't included, and figure out how best to fix it.

This is the fix:
test {
  inputs.files(fileTree("src/test") { // optional, improves up-to-date checking
    include "**/*.ss"
  })
}

added to the install instructions of the docs in #205


"patch" crashes when an existing .patch file is not from git-format-patch

Seeing the following crash with master (4dd0bef9b99a409ff59055a48526b31e778019ef)
$ rdopkg patch
## get_package_env
## ensure_patches_branch
## get_patches_branch
git update-ref refs/heads/ceph-2-rhel-patches refs/remotes/patches/ceph-2-rhel-patches
## check_new_patches
Traceback (most recent call last):
  File "/home/kdreyer/dev/rdopkg/venv/bin/rdopkg", line 9, in <module>
    load_entry_point('rdopkg', 'console_scripts', 'rdopkg')()
  File "/home/kdreyer/dev/rdopkg/rdopkg/cli.py", line 46, in main
    sys.exit(rdopkg(*cargs))
  File "/home/kdreyer/dev/rdopkg/rdopkg/cli.py", line 38, in rdopkg
    return shell.run(runner, cargs=cargs, version=VERSION)
  File "/home/kdreyer/dev/rdopkg/rdopkg/shell.py", line 84, in run
    action_runner.engage()
  File "/home/kdreyer/dev/rdopkg/rdopkg/core.py", line 194, in engage
    new_args = self.action_manager.run_action(step, self.args)
  File "/home/kdreyer/dev/rdopkg/rdopkg/action.py", line 208, in run_action
    return action_fun(*fun_args)
  File "/home/kdreyer/dev/rdopkg/rdopkg/actions/distgit/actions.py", line 515, in check_new_patches
    if helpers.is_same_hash(hash, old_hash):
  File "/home/kdreyer/dev/rdopkg/rdopkg/helpers.py", line 86, in is_same_hash
    if h1 == h2 or h1.startswith(h2) or h2.startswith(h1):
TypeError: startswith first arg must be str, unicode, or tuple, not NoneType

I should mention that in this case the ceph-2-rhel-patches branch was modified such that the last couple of commits were deleted and that was all - none were added.

I found that this crash happens because I have an additional .patch file at the root of my dist-git tree that lacks the standard headers that git-format-patch creates. specfile.get_patches_from_files() returns None for the hash in that case.

This is fallout from the fact that we have to occasionally ship .patch files for Git submodules :(
https://review.rdoproject.org/r/4533


404 error when try to configure

Describe the bug
I receive a 404 error when I try to configure the plugin.
To Reproduce
Steps to reproduce the behavior:
Administration - Plugins - Redmine Webhook Plugin - Configure
Expected behavior
It should display a configuration page
Packages versions (please complete the following information):

Redmine Webhook Plugin: 1.0.0
Environment:
Redmine version                3.4.4.stable
Ruby version                   2.4.6-p354 (2019-04-01) [x86_64-linux]
Rails version                  4.2.8
Environment                    production
Database adapter               Mysql2

Hi @geniolius!
Sorry for the inconvenience and late response.
I checked your setup and found that 404 happens if the plugin directory is named different from webhook. This is not clear from the readme and I added a note about that in https://github.com/ostrovok-team/redmine-plugin-webhook/commit/2a9c4b65b6e29f858203ab60614b8b806ed5332f. Please rename the plugin directory and try again.


Android: Use volk instead of NDK Vulkan headers

We no longer build the Vulkan loader, and volk lets us load it dynamically.
Roblox uses volk on Android so it should work well for us too.
Follow-up to #51516.

Superseded by #51524.


Let params override baseParams

I think it makes more sense to let params override baseParams instead of the current implementation which defaults to baseParams if present. For me baseParams define the default but I would like to make an exeception in specific calls. Thus instead of doing params + baseParams I think it should be baseParams + params.
What doe you think?

Thank you so much for your suggestion!!!! I am glad that you like Fuel.
I am not sure by having params overrides baseParams. I can explain why I opt to go for this option.
My server wants to have api_key bundled in all API call in order to grant the access right.
Consider, we have baseParams=("api_key" to "abcdefghi")
Then, API to list all dogs call will need to be
http://example.com/api/dogs?api_key=abcdefghi
This means that if we make params overrides baseParams.  List all dogs with french bulldog type is supposedly be http://example.com/api/dogs?api_key=abcdefghi&type=french_bulldog which in this case params=("type" to "french_bulldog").
Then, if we let params overrides it, one might find it hard to use. So, my ultimate option is to add them together (both params and baseParams) to achieve use case that I am looking for.
If you have a better alternative, I am very happy to discuss.

What I mean is when we have duplicate parameters, which should take precedence? E.g.
fun main(args: Array<String>) {
    val a = mapOf ("key" to 1)
    val b = mapOf ("key" to 2)
    val ab = a + b
    val ba = b + a
    println("ab = ${ab["key"]}") // prints 2
    println("ba = ${ba["key"]}") // prints 1
}

I think it makes more sense to let params take precedence over baseParams. That way you can configure for instance a default api_key as you suggest and let this be overridden by any concrete call.
Another point, which is maybe even more important, http allows you to have multiple values for the same key, so this:
http://somedomain.com/?key=1&key=2&key=4
is perfectly valid.

Oh!!! Sorry @mplatvoet for my stupidity!! In that case, I am totally on your side. To be honest, I overlooked this and agree with you that params should take precedence. It should be very simple. I will fix in the next release for sure.
Also,happy to merge if you are willing to send PR to fix that. :smile:

Yeah next time I can suggest these things with a PR. Last time I tried to build Fuel I got as far as running the tests which all failed at the time. But I believe you have fixed that now so I can give it another try :)

Yup. I fixed it now. Can you try build on master branch.

Fixed with version 0.52. Thanks for your valuable feedback. :+1:


Feat/api doc

Coverage decreased (-1.008%) to 84.664% when pulling b617461f0d37c98c842eb71af11be362bcd4d8ae on feat/api-doc into 42683ad47e11fcec1f02a54e69b42aff157c8ab9 on master.

Coverage increased (+0.3%) to 85.937% when pulling 274a17109786c2aa2b517bb2ddbaeb1bb08d8c72 on feat/api-doc into 42683ad47e11fcec1f02a54e69b42aff157c8ab9 on master.


Updates for auth-next

Note, this also needs an updated release of soroban-client dep, which is still pending release.

@esteblock Do we need to do something specific with lerna to update the interdependencies between the subpackages?

Hello @paulbellamy ,
This is done automatically by lerna.
Just
yarn build
yarn lerna-publish

Got some errors while building. Will check this now.
arn run v1.22.19
$ lerna run build
lerna notice cli v6.4.0

    ✔  @soroban-react/types:build (5s)
    ✔  @soroban-react/utils:build (6s)
    ✔  @soroban-react/freighter:build (5s)
    ✔  @soroban-react/chains:build (5s)
    ✔  @soroban-react/core:build (5s)
    ✔  @soroban-react/connect-button:build (5s)

    ✖  @soroban-react/contracts:build
$ rm -rf dist
$ tsc
       src/setTrustline.tsx(25,46): error TS2345: Argument of type 'GetAccountResponse' is not assignable to parameter of type 'Account'.
         Type 'GetAccountResponse' is missing the following properties from type 'Account': accountId, sequenceNumber, incrementSequenceNumber
       src/useSendTransaction.tsx(109,26): error TS2339: Property 'prepareTransaction' does not exist on type 'Server'.
       src/useSendTransaction.tsx(116,7): error TS18048: 'txn' is possibly 'undefined'.
       src/useSendTransaction.tsx(117,16): error TS18048: 'txn' is possibly 'undefined'.
       src/useSendTransaction.tsx(120,51): error TS18048: 'txn' is possibly 'undefined'.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

    ✔  @soroban-react/wallet-data:build (5s)

 ——————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————

 >  Lerna (powered by Nx)   Ran target build for 8 projects (26s)

    ✔    7/8 succeeded [0 read from cache]

    ✖    1/8 targets failed, including the following:
         - @soroban-react/contracts:build

Was by bad, I forgot to install the new dependencies.
Seems to be all ok. Merged and published!