Error: strip_outer_array is an invalid format type option for format type json

I believe the is an issue with the resource snowflake_file_format
During terraform plan I had no issues however after terraform apply I receive the following message
Error: strip_outer_array is an invalid format type option for format type json

I am positive that strip_outer_array is an acceptable option for JSON file formats, so my guess is some error.
terraform {
  backend "http" {
  }
  required_version = "= 1.1.3"
}

terraform {
  required_providers {
    snowflake = {
      source = "chanzuckerberg/snowflake"
      version = "0.25.36"
    }
  }
}

terraform
resource "snowflake_file_format" "large_json_array" {
  name        = upper("strip_outer_array_json_format")
  database    = var.database
  schema      = var.schema
  format_type = "json"
  strip_outer_array = true
  lifecycle {
    ignore_changes = [
      binary_format,
      compression,
      date_format,
      skip_byte_order_mark,
      time_format,
      timestamp_format,
    ]
  }
}

Hi @brunocastroibarburu94 you need to uppercase the format_type is my guess. 'json' isn't understood by Snowflake.
I can confirm that I have a working resource with the same specs, simply uppercase format_type value.


Alexa hears me just once, then goes idle and "dies"

after the first "alexa" it doesn't pick up my voice anymore, unless i restart magicmirror

[
pi@raspberrypi:~ $ cd ~/MagicMirror
pi@raspberrypi:~/MagicMirror $ npm start

<EMAIL_ADDRESS>start /home/pi/MagicMirror
./run-start.sh

[17:36:42.745] [LOG]    Starting MagicMirror: v2.10.0
[17:36:42.774] [LOG]    Loading config ...
[17:36:42.798] [LOG]    Loading module helpers ...
[17:36:42.803] [LOG]    No helper found for module: alert.
[17:36:45.848] [LOG]    Initializing new module helper ...
[17:36:45.849] [LOG]    Module helper loaded: MMM-awesome-alexa
[17:36:45.961] [LOG]    Initializing new module helper ...
[17:36:45.962] [LOG]    Module helper loaded: updatenotification
[17:36:45.963] [LOG]    No helper found for module: clock.
[17:36:45.965] [LOG]    No helper found for module: currentweather.
[17:36:45.966] [LOG]    No helper found for module: weatherforecast.
[17:36:45.967] [LOG]    All module helpers loaded.
[17:36:45.969] [LOG]    Starting server on port 8080 ...
[17:36:45.986] [LOG]    Server started ...
[17:36:45.987] [LOG]    Connecting socket for: MMM-awesome-alexa
[17:36:45.990] [LOG]    Connecting socket for: updatenotification
[17:36:45.991] [LOG]    Sockets connected & modules started ...
[17:36:46.326] [LOG]    Launching application.
[17:37:33.122] [LOG]    transiting to state: listening
[17:37:37.886] [LOG]    transiting to state: busy
ALSA lib pcm.c:8507:(snd_pcm_set_params) Channels count (1) not available for PLAYBACK: Argomento non valido
[17:37:48.050] [LOG]    transiting to state: idle
] Before submitting your issue add logs from your MagicMirror by running command pm2 log MagicMirror

I get now the same problem :-(
[17:58:51.316] [LOG]    transiting to state: listening
[17:59:48.235] [LOG]    transiting to state: busy
[18:00:02.486] [LOG]    transiting to state: idle
The first connection needs a long time (1 minute or so) after that it answers one time and thenthe service going into a idle state and never comes back again until next startup of magicmirror

me too :(

I meet the same issue. Did somebody solve it?

Experiencing the same issue here as well, first command works fine, and reponse is fine, get "transisting to state: idle" in the log, then the same errors as in issue #92.
No joy solving yet, will post back if i find anything

Same here , any lead on this will be very useful

Same here , any lead on this will be very useful

Did you get any errors or warnings? while installing any module?

@Ameyalgudkar I am sure it said some error during a long list of installation and dependencies.  Issue #211 is what I saw during installation. Other than that I can't think of any.

Got this working.
When I try to listen to recorded voice in /temp it is too loud. Application is thinking that that user is not yet done talking due to noises.
The fix is to adjust your capture device and playback device using alsamixer.
run alsamixer in CLI and press up to adjust playback volume, then press F4, to adjust volume press down.
Hope this helps

@ocelino Thanks a lot that worked like a charm
One more questions : Why is there a small delay after hearing my question example : Alexa, what's the weather
Then there is a 5 seconds gap n then Alexa answers me , do you know how to fix the delay ?

Also, for anyone experiencing problem of Alexa not listening for the second time , check if ur connected via Bluetooth speaker if yes then u might need to use Aux connection to make it work consistently


Update README.md

Fixed a couple of typos, clarified the JSON.stringify payload explanation, changed spacing in example snippet.

Thank you!


Adding routes and training

@bikeoid
Greenlink is going have special routes for Fall For Greenville and the Wellness Center route. Could adding those routes all be done through http://tracker.wallinginfosystems.com/ ?
If so, would you have some time to train Greenlink folks on the system?

The routes can be selected on the schedule, after the route path has been defined.   I don't have a good route path editor yet.   I can probably guess at the Fall For Greenville route, but not absolutely sure about the Wellness Center route.   So it's a bit early to train the Greenlink folks.   I hope to have a map-based stop editor soon (with photos); the route path editor is more advanced though.
For schedule, it would be useful to have an auxiliary / override schedule, that can be invoked by specifying  "The Greenville Drive/Swamp Rabbits will be in town for 7:00 games from Tuesday through Sunday 9/3 - 9/7" and they would appear on the schedule and automatically be removed.

Grant can provide a shape file for the alt routes and lat and lon for the stop if that would help.

Grant just made a Github account @greenlinktransit Looping him in to this conversation.

Yes, the shape files for The Well route and Fall For Greenville and lat/lon for any new stops would be helpful

Who should I email the shapefiles to?  The stops for Fall for Greenville are as follows:
County Square Route :

County Square: 34,502832, -82241272
Augusta @ Main: 34.503925, -82.241575

Kroc Route:

Kroc Lot: 34.505778, -82.243638
Greenlink Transfer Station:  34.510156, -82.240411

Please send them to niceman  (@) att.net

We also have a shared, public Google Drive account if you want to upload these files there too https://drive.google.com/drive/u/0/folders/0B1Wxj_5D6dLNfnFEeXo3a3pFVl9VVmxmWWpaNElCaXJrUXhxNi0ycVdOb3Y2SzRrWExFRTA?ths=true

Are the coordinates in Google convention / EPSG:4326?   When I try to go to those coordinates in Google, I end up in Laurens County - https://www.google.com/maps/place/34°30'10.2"N+82°14'28.6"W/@34.5028328,-82.2412778,15z/data=!3m1!4b1!4m2!3m1!1s0x0:0x0
Also, can you export the shape in either .SHP format or OpenStreetMap format?  I can't find any way to read Arcgis directly.
Thanks!


Access to an undefined property object::$property_name

Example
$user = User::where('id', '=', '1')->first();

$user->first_name

Result
Access to an undefined property object::$first_name.

The same problem is still open in phpstan. (Access to an undefined property object::$property_name)

What kind of object is $user in runtime?

@ondrejmirtes On the first method, the return type wrote on the PHPDocs is object instead of an instance of Model::class. I will write a PR to the core of Laravel to fix this.

@nunomaduro What return typehint where method has? If you want to return the same object as it's called on, you should use both @return static in phpDoc and self native return typehint at the same time.

Or you can fix this with dynamic return type extension 😊

@ForzaSFerrari Thanks again for reporting this false positive. 👍
This issue got fixed on the version v0.1.7. Do you mind of performing a composer update nunomaduro/larastan and test it again?

Looks like it's been fixed. @nunomaduro

@nunomaduro I'm on "nunomaduro/larastan": "^0.3.4", and still having this issue :(

@neoplomero could you provide us with more information about your issue, is it in a foreach loop etc. Between 0.3.4 and 0.3.12 quite some false positives has been addressed related to here. Could you proform a composer update nunomaduro/larastan and test it again? If it still is an false positive could you address it as a new issue.

@adminfriso  Thanks. Issue created https://github.com/nunomaduro/larastan/issues/216


Snakemake is not recognizing arguments

Hi @jdblischak,
Many thanks for creating a simple profile for SLURM. I am facing issues with using this profile though:
I am using snakemake version 8.4.2. On Snakemake documentation, I learned that config file should be names "config.v8+.yaml".  I named accordingly and here the content.
cat simple/config.v8+.yaml
cluster:
  mkdir -p logs/{rule} &&
  sbatch
    --partition={resources.partition}
    --cpus-per-task={threads}
    --mem={resources.mem_mb}
    --job-name=smk-{rule}-{wildcards}
    --output=logs/{rule}/{rule}-{wildcards}-%j.out
default-resources:
  - partition=small
  - mem_mb=1000
  - threads=48

restart-times: 3
max-jobs-per-second: 10
max-status-checks-per-second: 1
local-cores: 1
latency-wait: 60
jobs: 500
keep-going: True
rerun-incomplete: True
printshellcmds: True
scheduler: greedy
use-conda: True

On running snakemake command, I get the following error:
snakemake  -np --snakefile dl.smk  fastq_from_geo/SRR8245078_1.fastq.gz --profile simple/

snakemake: error: unrecognized arguments: --cluster=mkdir -p logs/{rule} && sbatch --partition={resources.partition} --cpus-per-task={threads} --mem={resources.mem_mb} --job-name=smk-{rule}-{wildcards} --output=logs/{rule}/{rule}-{wildcards}-%j.out

Just the dry run command works fine:
snakemake  -np --snakefile dl.smk  fastq_from_geo/SRR8245078_1.fastq.gz
Building DAG of jobs...
Job stats:
job                    count
-------------------  -------
download_using_curl        1
total                      1

Execute 1 jobs...

[Fri Feb  2 19:18:39 2024]
localrule download_using_curl:
    output: fastq_from_geo/SRR8245078_1.fastq.gz
    jobid: 0
    reason: Missing output files: fastq_from_geo/SRR8245078_1.fastq.gz
    wildcards: srr_id=SRR8245078_1
    resources: tmpdir=<TBD>

sh scripts/download.sh SRR8245078_1 metadata/srr_to_ftp_url.tsv fastq_from_geo/SRR8245078_1.fastq.gz
Job stats:
job                    count
-------------------  -------
download_using_curl        1
total                      1

Reasons:
    (check individual jobs above for details)
    missing output files:
        download_using_curl

This was a dry-run (flag -n). The order of jobs does not reflect the order of execution.

Any help would be greatly appreciated! Please let me know if you need more information.
Thank you very much,
Satya

@satyanarayan-rao Snakemake 8 completely changed the interface to Slurm. Both this profile (#21) and the official slurm profile (https://github.com/Snakemake-Profiles/slurm/issues/117) were broken by these changes. You have 3 options:

Downgrade to snakemake 7 and continue to use this profile (this is the quickest option)
Determine how to adapt this profile to use the new Snakemake 8 behavior (see #21 for ideas for getting started)
Switch to using the new Slurm submission that is built-in to Snakemake 8 (note that this will require you to give up some control, eg on where the log files are saved, as discussed in https://github.com/snakemake/snakemake-executor-plugin-slurm/issues/11)

Thanks a lot, @jdblischak! I had to downgrade to snakemake 6 and use --cluster-config option. I think I would wait for the stable version of the new Snakemake to migrate.

I had to downgrade to snakemake 6 and use --cluster-config option.

I'm glad you got it working, but to clarify, I don't recommend using --cluster-config.

If you used the smk-simple-slurm profile in this repo, it should have worked fine with Snakemake 7. If you're interested in giving it a try, and you still get errors, please feel free to open a new Issue to share the error message and your profile config file

I think I would wait for the stable version of the new Snakemake to migrate.

I totally understand the frustration. One option would be to migrate from --cluster-config directly to the new Snakemake 8 cluster support, which would completely bypass the stage that this profile was meant to address.
Though I wouldn't get your hopes up about a mythical stable version of Snakemake. As long as it is actively developed (which is generally a good thing), it will continue to change. I have lots of old pipelines that use --cluster-config as well as plenty that use smk-simple-slurm. As long as you pin the version of snakemake in your conda env, your pipeline should continue to run.


Update CHANGELOG.md

Changes proposed in this Pull Request:

Changelog

Did you mean March 14

Did you mean March 14

Nope 6.4.1 is already published.


Cancel concurrent CI runs for same pr/commit

Signed-off-by: 1gtm<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: 1gtm:x: kodiakhq[bot]You have signed the CLA already but the status is still pending? Let us recheck it.


[SPARK-33739] [SQL] Jobs committed through the S3A Magic committer don't track bytes

BasicWriteStatsTracker to probe for a custom Xattr if the size of
the generated file is 0 bytes; if found and parseable use that as
the declared length of the output.
The matching Hadoop patch in HADOOP-17414:

Returns all S3 object headers as XAttr attributes prefixed "header."
Sets the custom header x-hadoop-s3a-magic-data-length to the length of
the data in the marker file.

As a result, spark job tracking will correctly report the amount of data uploaded
and yet to materialize.
Why are the changes needed?
Now that S3 is consistent, it's a lot easier to use the S3A "magic" committer
which redirects a file written to dest/__magic/job_0011/task_1245/__base/year=2020/output.avro
to its final destination dest/year=2020/output.avro , adding a zero byte marker file at
the end and a json file dest/__magic/job_0011/task_1245/__base/year=2020/output.avro.pending
containing all the information for the job committer to complete the upload.
But: the write tracker statictics don't show progress as they measure the length of the
created file, find the marker file and report 0 bytes.
By probing for a specific HTTP header in the marker file and parsing that if
retrieved, the real progress can be reported.
There's a matching change in Hadoop https://github.com/apache/hadoop/pull/2530
which adds getXAttr API support to the S3A connector and returns the headers; the magic
committer adds the relevant attributes.
If the FS being probed doesn't support the XAttr API, the header is missing
or the value not a positive long then the size of 0 is returned.
Does this PR introduce any user-facing change?
No
How was this patch tested?
New tests in BasicWriteTaskStatsTrackerSuite which use a filter FS to
implement getXAttr on top of LocalFS; this is used to explore the set of
options:

no XAttr API implementation (existing tests; what callers would see with
most filesystems)
no attribute found (HDFS, ABFS without the attribute)
invalid data of different forms

All of these return Some(0) as file length.
The Hadoop PR verifies XAttr implementation in S3A and that
the commit protocol attaches the header to the files.
External downstream testing has done the full hadoop+spark end
to end operation, with manual review of logs to verify that the
data was successfully collected from the attribute.

Test build #132588 has started for PR 30714 at commit 132a2e9.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37193/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37193/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37193/

Test build #132588 has finished for PR 30714 at commit 132a2e9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132588/

Test build #134371 has started for PR 30714 at commit c680138.

Test build #134371 has started for PR 30714 at commit c680138.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38958/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38958/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38958/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38958/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38958/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38958/

Test build #134371 has finished for PR 30714 at commit c680138.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #134371 has finished for PR 30714 at commit c680138.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134371/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134371/

Thank you for updating. I'm looking forward to using Hadoop 3.3.1!

Thank you for updating. I'm looking forward to using Hadoop 3.3.1!

ok, Hadoop-side PR is in trunk; verifying backport compiles and new tests work then it'll be in branch-3.3.
This patch is ready for final review/merge

ok, Hadoop-side PR is in trunk; verifying backport compiles and new tests work then it'll be in branch-3.3.
This patch is ready for final review/merge

cc @tgravescs @mridulm FYI

cc @tgravescs @mridulm FYI

I'll update the docs. Also going to cut back on the warnings now that AWS S3 is consistent (And all third party ones were consistent out the box too). This is a good thing for apps like spark (much easier to do workflows across applications), but you still can't safely use the rename committer there as dir rename is non-atomic.
Fortunately, commit-by-rename is so slow people have a reason to switch to a better one, either the S3A ones or that from EMR :)

I'll update the docs. Also going to cut back on the warnings now that AWS S3 is consistent (And all third party ones were consistent out the box too). This is a good thing for apps like spark (much easier to do workflows across applications), but you still can't safely use the rename committer there as dir rename is non-atomic.
Fortunately, commit-by-rename is so slow people have a reason to switch to a better one, either the S3A ones or that from EMR :)

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134657/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39245/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39245/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134657/

I've looked at the stores for which hadoop-trunk has connectors, looks like only openstack swift is inconsistent. Moved the details on consistency down, called out swift and said "consult the docs". After all, alternative implementations of the swift API (I'm thinking IBM's work) probably is consistent.

Test build #135156 has started for PR 30714 at commit 4b08f49.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39737/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39737/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39737/

Test build #135156 has finished for PR 30714 at commit 4b08f49.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

The doc change looks good to me, but I don't feel qualified to review the code. As @tgravescs already reviewed and approved, it sounds more natural if he can make "sign-off".
@tgravescs Kindly reminder. Thanks!

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135156/

Test build #135196 has started for PR 30714 at commit 81c0a52.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39777/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39777/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39777/

Test build #135196 has finished for PR 30714 at commit 81c0a52.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135196/

@tgravescs can you hit the merge button before some other change breaks this PR? thanks

merged to master, thanks @steveloughran @dongjoon-hyun @HeartSaVioR

thanks!

I was here too! 😃


Feat/autotune int ops

Pull Request Template
Checklist
WIP

[x] Confirmed that run-checks all script has been executed.
[x] Made sure the book is up to date with changes in this PR.

Related Issues/PRs
#944
Changes
Added int_random() to int tensor ops, new autotuning calls for sum_dim and mean_dim.
Testing
Unit tests for int_random(), sum_dim() and mean_dim() on WgpuTensors with IntElements .

@louisfd Finally got the chance to start on #944. I'm going down the long route and trying to add support at large for random() on int tensors. When you say "add a call to autotune for sum_dim and mean_dim (int versions)", I'm assuming that means creating an impl<E: IntElement, const D: usize> SumDimAutotuneOperationSet<E, D> and associated AutotuneOperationSet impl (and similar story for mean_dim)?

@louisfd Finally got the chance to start on #944. I'm going down the long route and trying to add support at large for random() on int tensors. When you say "add a call to autotune for sum_dim and mean_dim (int versions)", I'm assuming that means creating an impl<E: IntElement, const D: usize> SumDimAutotuneOperationSet<E, D> and associated AutotuneOperationSet impl (and similar story for mean_dim)?

Hi @agelas, thanks for tackling this issue!
The only place that was problematic was these lines in burn-wgpu/src/kernel/reduce/tune/sum_dim.rs
fn autotunables(&self) -> Vec<Box<dyn AutotuneOperation>> {
    let random_bounds: (E, E) = ((-10.0).elem::<E>(), (10.0).elem::<E>());
    let input = random_like_uniform(&self.input, random_bounds.0, random_bounds.1);

because random_like_uniform only worked with floats even if E was an int. I'm not sure if you could just rewrite those lines to make it call your new int ops instead of the lower level random_like_uniform or if you'll have trouble determining if you need to call the float or int version. If that's the case then yes you can duplicate the AutotuneOperationSet, but it should keep the same key.
In the end you will only have to change sum_dim / mean_dim implementations in burn-wgpu/src/ops/int_ops.rs to something very similar to the float ones:
    fn sum_dim<const D: usize>(tensor: FloatTensor<Self, D>, dim: usize) -> FloatTensor<Self, D> {
        #[cfg(feature = "autotune")]
        {
            reduce::sum_dim_autotune(tensor, dim)
        }

        #[cfg(not(feature = "autotune"))]
        {
            let output = init_reduce_output(&tensor, dim);
            reduce::sum_dim(tensor, output, dim)
        }
    }

@louisfd I'm gonna take a breather and ask for feedback here because this PR is starting to get on the large size. I think everything is working just about the way it should. I had to unfortunately basically copy the whole AutotuneOperationSet and associated functions/impls since the WgpuElement vs IntElement trait bound can't be determined at runtime.
Also I'm not sure what's up with the fusion::base::tests::aggregation::tests::test_should_mean_last_dim_int, it worked on the prior commit and locally and the only thing I've changed is the book docs.

@louisfd Yes sorry, I kept changing the distributions around on the backends for testing purposes and forgot to make them all the same. I think it's nice to have a default just in case, and the flexibility to choose your own distribution is provided anyways without much extra effort . What the bounds should be though I'm not sure. If we mimic the [0,1] behavior of floats like you mentioned it would be pretty easy to port this over to bool tensors so I sort of lean towards that approach.

@louisfd actually on second thought, maybe it would be best for the default distribution to be [0, 255]- I think that's the standard range for 8-bit quantization and would also be good for most image data as well, so that covers a lot of use cases right there.

The casting problem is quite obvious in cast_float.
This function is used in the prng shader.
fn cast_float(number: u32) -> {{ elem }} {
   return 2.3283064365387e-10 * {{ elem }}(number);
}

I think it should be :
fn cast_elem(number: u32) -> {{ elem }} {
   let tmp = 2.3283064365387e-10 * f32(number);
   return {{ elem }}(tmp);
}

It was assume that {{ elem }} was a float, but with this PR, it becomes an int i32. @agelas @louisfd

@nathanielsimard In burn-wgpu/src/kernel/prng/bernoulli.rs, it looks like there's already a cast_elem function, so maybe convert_elem or something similar?
@louisfd Also, for the test that's failing, is there a way to switch to use int_mean_dim(1) instead of mean_dim(1)? I think that and the next test in the aggregation.rs file (test_should_sim_last_dim_int()) now have int versions that should probably be used.
#[test]
    fn test_should_mean_last_dim_int() {
        let tensor = TestTensorInt::from([[0, 1, 2], [3, 4, 5]]);

        let data_actual = tensor.mean_dim(1).to_data(); // <- use int_mean_dim(1) instead?

        assert_eq!(data_actual, Data::from([[1], [4]]));
    }

@nathanielsimard In burn-wgpu/src/kernel/prng/bernoulli.rs, it looks like there's already a cast_elem function, so maybe convert_elem or something similar?
@louisfd Also, for the test that's failing, is there a way to switch to use int_mean_dim(1) instead of mean_dim(1)? I think that and the next test in the aggregation.rs file (test_should_sim_last_dim_int()) now have int versions that should probably be used.
#[test]
    fn test_should_mean_last_dim_int() {
        let tensor = TestTensorInt::from([[0, 1, 2], [3, 4, 5]]);

        let data_actual = tensor.mean_dim(1).to_data(); // <- use int_mean_dim(1) instead?

        assert_eq!(data_actual, Data::from([[1], [4]]));
    }

Hi @agelas Sorry for the late reply.
Regarding the cast functions, since it's getting a bit confusing I think we should be more explicit with the names:
cast_X_to_Y with X and Y changed to bool, float or elem when it depends.
For your second question, maybe you're confusing tensor methods and backend operations? Because it's an int tensor the mean_dim method will call int_mean_dim underneath.
impl<B: Backend> Numeric<B> for Int {
    // ...

    fn mean_dim<const D: usize>(tensor: Self::Primitive<D>, dim: usize) -> Self::Primitive<D> {
        B::int_mean_dim(tensor, dim)
    }

    // ...
}

For the CI error, it seems to be the modulo. Are you positive that both random_u32 and range are the same type?
  48 │     let random_in_range = (random_u32 % range) + low;
     │                                              ^^^^^^^^^^^^^^^^^^ naga::Expression [93]

Hi @antimora @louisfd , sorry about the delay, life got in the way.
@louisfd  w/regards to the naming issue, I changed cast_float to cast_u32_to_float like you suggested. For the CI error, it seemed to be with the KernelSettings, but that's resolved now.
The CI is failing on codecov/path now at 63455c4 (the latest commit), I'm not sure what to do here since a lot of the code here gets used via a somewhat complicated mixture of macros and regular rust,

@agelas, thank you for the update. Do not worry, the life is a priority.
Regarding the coverage - it's not a hard requirement to hit 80%. We can override manually.


[login] wallet selection sometimes not working - MM & Coinbase conflict

I have a clean Brave browser with only Metamask and Coinbase wallet installed.
Bug is a bit difficult to reproduce, but sometimes this works:
1.) Shut down Brave completely, open it again.
2.) Go to https://staging.carbonmark.com/retire (or any other subpage of Carbonmark).
3.) Try to log in, select Metamask.
4.) Coinbase wallet pops up instead, asking me to enter my password. If I click Coinbase wallet instead in step 3, Coinbase also pops up, so I cannot access Metamask at all.
But: If I unlock Metamask before I try to log on Carbonmark, it lets me log in instantly.
Second but: If I then log out of Carbonmark and back in, it asks me to pick a wallet again, which sends me back to Coinbase popping up again (despite Metamask being unlocked now).
Feels a bit random, because sometimes I have no issues and sometimes it sends me through all the steps I just described. Could be that it's just two wallets in the background having a fight, so maybe not worth investigating this and instead help users on a case by case basis?

thanks @0xtapi
I've seen this issue or something similar before.
Not specific to CM Contract v2 so I've removed from the QA epic and renamed the issue.
Also an edge case and low priority.
For anyone working on this, I believe it had something to do with MM and CB both using a window.ethereum parameter.
#881 and #923 may have clues.

Hey guys, I spent some time investigating this and unfortunately I can't find an easy solution to the problem. It seems both are battling for the window.ethereum. I tried some fixes suggested by coinbaseand a number of other fixes, but none of them seemed to work as intended.
One fix I tried worked okayish if your metamask wallet was opened, but it involved making a number of changes through some window.ethereum functions, but the minute your MM wallet is locked, it doesn't work as expected i.e. you get the Coinbase wallet popup again when selecting Metamask.

Hey guys, I spent some time investigating this and unfortunately I can't find an easy solution to the problem. It seems both are battling for the window.ethereum. I tried some fixes suggested by coinbase and a number of other fixes, but none of them seemed to work as intended.
One fix I tried worked okayish if your metamask wallet was opened, but it involved making a number of changes through some window.ethereum functions, but the minute your MM wallet is locked, it doesn't work as expected i.e. you get the Coinbase wallet popup again when selecting Metamask.

@Atmosfearful what do you think? Kind of an edge case...any ideas or should we just de-prioritize this one for now?

The code I'm seeing on our end looks correct:

all we can do is invoke window.ethereum methods, we can't differentiate between different wallets
we check for provider.isMetaMask and only show the metamask button if they have it. Here we would expect metamask to pop up if isMetaMask is true.... but it seems this is not the case. Nothing we can do about this.


detekt-cli 1.17.0-RC2 is published with multiple runtime variants

Expected Behavior
Single variant with "org.gradle.usage": "java-runtime" (apiElements) is published in Gradle metadata.
Observed Behavior
Two variants with "org.gradle.usage": "java-runtime" (apiElements, shadowRuntimeElements) are published in Gradle metadata.
Steps to Reproduce
Compare .module file in https://repo1.maven.org/maven2/io/gitlab/arturbosch/detekt/detekt-cli/1.16.0/ & https://repo1.maven.org/maven2/io/gitlab/arturbosch/detekt/detekt-cli/1.17.0-RC2/
Diff: https://gist.github.com/3flex/c82cf481f4d45c0bb38ee04dd769bcb8
Context
This makes it more difficult to consume detekt-cli in Gradle projects, see https://github.com/detekt/detekt/pull/3738

It looks like the new runtime variants were introduced in https://github.com/detekt/detekt/pull/3574

Thanks, that's pointed me in the right direction.
I'll have a PR soon.


[4pt]  - Display list of items on the Homepage - Student A

Create the main part of the homepage that keeps the layout from the wireframe:

When the page loads, the webapp retrieves data from  the selected API and shows the list of items on screen with the basic data (e.g. title + image).
Prepare also "Comments" and "Reservations" buttons. They should be doing nothing - just being displayed.
This task does not include displaying the number of likes for each item.
This task does not include the counter of the items.

We have created the main part of the homepage that keeps the layout from the wireframe:

When the page loads, the web app retrieves data from the Meal-DB API and shows the list of Meals on the screen with the basic data (title + image).

We have also Prepared the "Comments" buttons. They have done nothing - just being displayed.

List of Items has been fully updated, Comments and likes updated as well.

Hello @uisendy ,
You have successfully updated LIst of items Comments, and Likes,

You did great.


Feature/backup metadata

This PR adds the ability to add metadata to backups.
The metadata works about the same as assets metadata. (a file is generated when accessed, then data is put in)
Api
$backup = app(BackupRepository::class)->find($timestamp);

$metadata = $backup->getMetadata();

$metadata->getRestores() // collection of `UserActionDto`
$metadata->getDownloads() // collection of `UserActionDto`
$metadata->getSkippedPipes() // collection of `['pipe' => class-string, 'reason' => string]`
$metadata->getCreatedBy() // the user that created the backup

UI

would like to rebuild the UI a bit so we can show more of the data we now might have, might be in another PR to keep the scope smaller here.

To skip a pipe, the pipe can do this in the "backup" method.
return $this->skip(
    reason: 'No users found.',
    next: $next,
    zip: $zip
);

This might be an option as well, but I don't like either that much...
return $next($this->skip(reason: string, $zip));


Router-state plugin

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

What is the motivation / use case for changing the behavior?
I am considering Akita for a fairly complex app and I seem to miss just a single puzzle piece in migrating from ngrx/ngxs - the router state. This plugin would address two important use cases in my view:

Memoized selectors based on route params and queryParams (e.g. active entity based on id param)
Time travel with Redux DevTools & overall transparency while debugging (Router_Navigate, Router_Cancel, etc.)

Would it fit well in Akita's infrastructure?

It seems like a good idea. Will need to investigate it.

@NetanelBasal A rough idea how I synchronized the router with the router-state:
https://stackblitz.com/edit/akita-todos-app-ge8rcp?file=src%2Fapp%2Frouter%2Frouter.service.ts
It's just a quick dirty implementation and there are many things open:

Navigation Cancel and Navigation Error: only the methods with custom actions are there, I got to figure out how to update the state in each case
The ability to provide a custom router serializer: the plugin would need to provide some interfaces/abstract classes to implement
Transform to plugin 😃

Looks like a good start. My colleague @shaharkazaz also started to investigate this. I migrated the code to an application with routing so you can test it.
https://stackblitz.com/edit/angular-router-basic-example-agvggd

https://medium.com/@NetanelBasal/whats-new-in-akita-v1-9-small-things-that-make-you-happy-b2567bc7c719


catalyst works with numpy 2.0

Context:
After Pennylane support numpy 2.0, catalyst needs to add this support.
Description of the Change:

Bump pennylane version to include the numpy 2.0 support
Since programs built using numpy 1.x would not readily work with numpy 2.0, we upgraded reuirements.txt to install numpy2.0. The reason is that wrapper.cpp uses the numpy C-API that should be built using numpy 2.x.
pyblind11 dependency was upgraded to 2.12.0 which adds support to numpy 2.0
scipy dependency includes 1.13 which adds support for numpy 2.0
removed optax dependancy from requirements (it was a TODO and unrelated to numpy but would cause CI delay)

Benefits:
Adds support for numpy 2.0
Related GitHub Issues:
[sc-61401]

Is this still labeled do-not-merge? I'll leave it up to you to decide when to merge.

Sorry, forgot to remove the tag. I think it should be good for merging.

Should wheels be built to check against the numpy upgrade?

@erick-xanadu, I just pushed a last change, which is to add scipy==1.13 to requirements. I think it is necessary since we have numpy==2.0.

Should wheels be built to check against the numpy upgrade?

Added the label


buildOne.bash --> Unbound "DAY" and "RDR"?

Hi. I am attempting to compile a particular apk file (https://github.com/foolish314159/NHK-Easy-News), however when I run ./buildOne.bash, I get an error message stating:
./buildOne.bash: line 133: DAY: unbound variable
./buildOne.bash: line 48: RDR: unbound variable
I ran the script outside of the directory containing the android manifest file and received the same result.

Use the command "termux-setup-storage". See the StackOverflow answer.

It looks like DAY could be omitted, and RDR is the root directory?
RDR=$PREFIX
DAY=''

Well, I already had the termux storage directory set up.
I also used the build.dir (whichever one that was), and it seemed to run
fine (i.e. ran it in the directory with the android manifest xml file).
However, the script was returning an error: i.e. for every "asset" called
(i.e. menu bars, etc.), it was saying "could not find". (deleted the
scripts previously, but I can re-run it if you want the output.
So, that leads me to my second question: can your program build/compile any
random android app into an apk? (i.e. I was trying to build an app I
downloaded from github using your script). Or can it ONLY compile files
that are specifically compatible with it?
-Adam
On Mon, Mar 4, 2019, 12:15 Quasic<EMAIL_ADDRESS>wrote:

It looks like DAY could be omitted, and RDR is the root directory?
RDR=$PREFIX
DAY=''
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sdrausty/buildAPKs/issues/14#issuecomment-469405240,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AjxJuJxgiVvNHIeeCnlqvkqIppfHhdxYks5vTX7sgaJpZM4bOzBF
.

It doesn't build many projects. It is still a work in progress, I believe.
The unbound variables are usually ignored by bash. This would be ok for DAY, I think, but RDR is a path to a directory with scripts to fix issues and includes a var subdirectory for log files...I haven't used this script, but that's how I read it.

Same here too...

Resolved: https://github.com/sdrausty/buildAPKs/commit/0b41b1e6796239dc32301854bff9b5063dfd7d07

buildOne.bash is currently build.one.bash

buildOne.bash is currently build.one.bash.  New files build.sh and build.zsh are added for convenience.  Three shells are supported by BuildAPKs: bash, sh and zsh.


No such service: tinkerwell

Hi @tjespers,
Just a quick note - in the examples, the service name in cli.interpreter differs from that in the docker-compose.yaml
https://github.com/tjespers/tinkerwell-interpreters/blob/54dd143ab2843ba89f0786e8d88b658044bb2c4e/examples/docker-compose/cli.interpreter#L18
https://github.com/tjespers/tinkerwell-interpreters/blob/54dd143ab2843ba89f0786e8d88b658044bb2c4e/examples/docker-compose/docker-compose.yaml#L5
Great work on this by the way!

@CallumEddisford thanks for pointing that one out! Will fix that one right away.


Abstract away the 5 verifySignaturesOn* functions

(Feel free to tag as TODO, and assign me.) The following 5 functions do a lot of the same stuff and there's a significant opportunity to DRY up the code. It took me quite a long time to parse and precisely understand what was going on in those functions, as the code in uncommented and a bit messy. It's important that these crypto functions be crystal clear for review.

verifySignaturesOnOrderCompletion
verifySignaturesOnOrderConfirmation
verifySignaturesOnOrderFulfilment
verifySignaturesOnListing
verifySignaturesOnOrder

This refactor is being postponed for #199.

I experimented a bit with abstracting those into verifySignature() function, that accepts pubkey, message  and function to call from inside to obtain signatures (which is exactly in what they differ). Will submit a PR for review, if that's ok.

@yurizhykin that would be great. Just keep in mind I just merged a change to that code today so make sure you're working with the latest.

@cpacia , yep, I specifically waited until that PR was merged:)


Form

Hi,
I love your work and always think on it how to use.
I have an idea to use it as (database) form, like PDF form.
If I could use inline fields (more in one row) in rows, I could make contextual form to collect data.

(prefix::{"type": "select", "options":["his", "her"]}) name is {{name}}, age: (age:: .. ) -- something like this mixture
the fields come from fileClass or define in place
the fields palceholders are UIs to make the process faster in view mode (like in dataviewjs)
can build a process way, the order of UIs
can print it
can export the structured data to data folders (csv, excel, JSON, databases)

It is very simple.
For you, not for me 😀.
What is your opinion?
Füles

You can do that already, but all the results are saved in the same field:
My Field:: {"type":"Input","options":{"template":"This is a template using a {{subField}} to get data"}}

You just have to go to Manage <MyClass> fields, select or add the field you want to set. Then, the field type should be "Accept any value". In "Template" you could set that the sub fields, I don't know if this is what you want.
Or, could set a template using templater plugin which allows place holders and can support a lot of successive inputs.
like:
[pronouns:: <% tp.system.suggester(["his", "her", "their"], ["his", "her", "their"]) %>]
[name::  <% tp.system.prompt("Name of the person") %>]
[age::  <% tp.system.prompt("Age of the person") %>]

As they're inline fields you could use it even in a sentence that is the thing, I think, you want to. The only limitation is the inputs are requested in reverse order when are replaced.
If this helps you let me know. But I don't know if I explained myself clearly. However I don't know how to make it using dataviewjs or exported to csv, excel, etc. I don't think any plugin could that. Have you think about using another app to achieve that, like microsoft Access or postgres, or google forms? (In case you need it in excels more than in notes)

Hi,
Thanks your answere.
I have a HR Controller, but I write programs to help my work.
I used Access, MS SQL, flat databases, wrote programs in basic, PHP, Python, C# and ...
I have just looked at your program and realised how fast I could make collection forms based on database like system.
Just for myself I put the documentum system on Obsidian and it could help me to fill documents (forms) and collect information from them and your solution seems very practical. 😀
Füles

I'm glad that it helped you ^^
If you want to learn more about templater you can check the documentation


This library vs AWS SDK for .NET

Hello
I'm a dev on the official AWS SDK for .NET and I was curious what were your design goals that you had to warrant writing your own versus using ours. Where there things lacking in our SDK that you wanted to improve on?
Impressive work writing your own SDK.
Norm

An alternative SDK becomes necessary when you run into blocking issues in the official AWS SDK. For example, there is a threading issue which is causing an occasional lock in AWS SDK for DynamoDb:
https://github.com/aws/aws-sdk-net/issues/1476
I've resorted to writing my own API wrapper to circumvent this until I found this SDK.

In Nuget, this package is way too similar to the official AWS package. For inexperienced devs or those just not paying attention, this package will get installed instead of the official AWS package.
As I was about to install this package, I realized that the Nuget information was missing the project URL; the only way I found this project was by going to the Nuget website and finding the source repository.
At a minimum, this package should be renamed to something like: Amazon S3 Wrapper. And update the description so it clearly states this is not the official AWS S3 package, but an alternative. Finally, the Readme for this repo really should clearly state this is not the official AWS package, and then provide concrete examples of why this wrapper is needed.
Nearly 500k downloads; I'm gonna go out on a limb and say the vast majority thought they were downloading the official AWS package.


Add handling for http errors and add host header

Axios will reject the returned promise if a non-200 response is returned. Request does not do this for us. This adds handling for that. Also, set the relevant request headers for both Axios and Request.

This looks safe to me but requires updating the doc to tell people to add the host header.
https://spec.corp.creditkarma.com/talon-docs/nodejs/client/
Anybody that already has a getThriftClient() in Node will need to update as well to work through linkerd.
It's a bit tricky to notice since most testing seems to be local or direct to a docker container without going through linkerd. It works fine without the header when you connect directly to the service.

@bradley-marker-ck Yeah, I'll update the docs and generator code for the host header. For ck content-type doesn't matter because we use hapi, but for express middleware it actually is required.


[SA] can not place a packed memory unit in remote view ?

If I [alt+D] a building in romote view .I got a packed item .which store in my yellow chest,
but I cant place it out in remote view.
maybe add a packed item in ghost mode ?

Sorry, this is too difficult due to technical reasons.


How to sort by 2nd column for md5sum?

Is there a way to sort the resulting md5.txt by file name (2nd column)? @danielecook
md5sum_pre.out.concat(md5sum_post.out).collectFile(name: md5sum_path, newLine:false)

I fiddled around and the code got too messy XD So i'll settle for an easy work around. Thanks!!


Skip code analysis if code modifiers are yet to run

Purpose
$subject
Fixes https://github.com/ballerina-platform/ballerina-lang/issues/39503
Approach
The PackageCompilation->compile method skips the code analysers iff compilation happens with code generators. This logic is now extended to skip code analysers when there are code modifiers as well.
Samples
Manually checked the running of the code analysers using an example. With the new fix, the expected behaviour was observed.
Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

https://github.com/ballerina-platform/ballerina-lang/pull/39505 will not be completed without the changes in this PR. Hence I am closing this PR and changes will be added to 39505


Refactor ingest system

Refactor the ingest system to remove NFS requirement.
Implement new monitor system to allow Strike to have different ways of receiving ingest file events

One note for when refactoring the ingest system. Currently, if you retry a failed ingest that has some of the file-related database records, the ingest will be marked as a duplicate and that the job will exit as a success.

For this issue we will need to consider how the long-running Strike process can detect issues with a Docker NFS mount and exit so that a new container (job execution) can be started.

Also don't forget to remove the ENABLE_NFS env var being passed to the ingest and Strike containers.

Here are a few notes that I had scribbled for this issue as a potential design:
Add read_only flag to workspace, should throw exception when changing things in workspace
Strike config:
monitor:
	workspace (has a broker config)
	monitor config (watch directory within NFS, S3 events)

what to do:
	filename regexs -> data types, workspace, new workspace path

monitor takes monitor config in constructor
monitor has methods for:
is the given workspace broker type valid for this monitor?
given a workspace, perform the monitoring (blocking call), also needs to be given some class for call backs to create/update ingest records and create ingest tasks
method to kill/stop monitoring
event of file arriving has the following things:
path of file in Strike workspace
basic info of file (file size, media type)
how to ingest the file has the following things:
basic info of file (data types), this is new stuff based on Strike config
new workspace
new workspace path
ingest job steps:
if strike workspace and final workspace are same, just do a workspace move (if new workspace path is provided)
if workspaces different, do a type lookup on Strike and final workspace to find class that does optimal transfers
if no special optimal transfer, just do a straight download to local disk from Strike workspace and upload to final workspace
rethink ingest statuses?

Example new Strike configuration schema:
{   "version": "2.0",   "workspace": "my-workspace",   "monitor": {"type": "s3", "sqs_name": "my-sqs"},   "files_to_ingest": [     {"filename_regex": ".*", "data_types": [], "new_workspace": "my-workspace", "new_workspace_path", "my/path"}   ] }

@dfaller Am I correct in guessing that there should there be a colon after "new_file_path" instead of a comma?

Yeah, it's corrected now. :)

Key Change Log Notes:

new automated workspace which requires host mounts of NFS
in DB migrations note that failed ingest jobs cannot re-run successfully, must cancel and ingest the file again


[stable/percona-xtradb-cluster] SSL support in stable/percona-xtradb-cluster

Is this a request for help?:
No
Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Feature Request
Version of Helm and Kubernetes:
All
Which chart:
Percona-XtraDB-Cluster
Feature Request:
The stable/mysql chart has support for starting the MySQL server with SSL support:
https://github.com/helm/charts/blob/dafdf97d0c992ed85b3ce43476164c8ce3f93c92/stable/mysql/values.yaml#L134-L150
It would be awesome to have the stable/percona-xtradb-cluster Helm chart support the same options in the my.cnf. Alternately, just having some documentation on how to do the needful w.r.t. injecting my.cnf values for SSL options securely at helm install time would be useful.

+1 for this request.


Implement zip via unzip

As @jdalton noted a while ago https://github.com/jashkenas/underscore/pull/1806#discussion_r16799291 (though wasn't possible at the time until #1520 was merged)

Let's tag 'em as we close 'em.


Feature/discovery server side refactor

Hi @punalsc,
Here's the refactored code.
Thanks!

Hi @punalsc,
I've made the changes, could you have a quick look? If I've missed/misunderstood something just let me know.
Thanks!


Added a test to check UUIDs of tokens

Description
Just a simple test based on Cable's work to add UUIDs to each token value; it checks if an ID is present and unique.
Motivation and Context
I accidentally published a release with some tokens missing IDs.
How Has This Been Tested?
Locally.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Run report for b0b6085c
Total time: 46.8s | Comparison time: 44.7s | Estimated loss: 2.1s (4.4% slower)

Action
Time
Status
Info

🟩
SetupNodeTool(18.13.0)
3.7s
Passed

🟩
InstallNodeDeps(18.13.0)
15.8s
Passed

🟩
SyncNodeProject(tokens)
0.8ms
Passed

🟩
SyncNodeProject(visualizer)
0.2ms
Passed

🟩
RunTarget(tokens:build)
24.9s
Passed

🟩
SyncWorkspace
0ms
Passed

🟩
RunTarget(tokens:test)
1.9s
Passed

🟩
RunTarget(tokens:generateDiffResult)
2.4s
Passed

🟩
RunTarget(visualizer:noop)
491.5ms
Passed

🟩
RunTarget(tokens:noop)
11.6ms
Passed

Touched files
packages/tokens/test/checkId.test.js


Fix the bug to remove internal key when receiving the 100-continue header

Codecov Report
Attention: Patch coverage is 16.00000% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 18.75%. Comparing base (52ba813) to head (a267ca7).
Report is 6 commits behind head on master.

Files
Patch %
Lines

...a/com/github/ambry/rest/NettyMessageProcessor.java
0.00%
11 Missing :warning:

...in/java/com/github/ambry/rest/MockRestRequest.java
0.00%
4 Missing :warning:

...om/github/ambry/frontend/AmbrySecurityService.java
57.14%
2 Missing and 1 partial :warning:

.../main/java/com/github/ambry/rest/NettyRequest.java
0.00%
1 Missing :warning:

...java/com/github/ambry/rest/WrappedRestRequest.java
0.00%
1 Missing :warning:

...om/github/ambry/tools/perf/rest/PerfNioServer.java
0.00%
1 Missing :warning:

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2781       +/-   ##
=============================================
- Coverage     64.24%   18.75%   -45.50%
+ Complexity    10398     2917     -7481
=============================================
  Files           840      840
  Lines         71755    71877      +122
  Branches       8611     8635       +24
=============================================
- Hits          46099    13478    -32621
- Misses        23004    57163    +34159
+ Partials       2652     1236     -1416

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Any plans to support netcoreapp2.0?

Also, any idea when NuGet will be updated? I want [JsonObject(ItemNullValueHandling = NullValueHandling.Ignore)] but it doesn't seem to be in the 10.0.3 release.

Json.Net targets netstandard 2.0 and other netstandards https://github.com/JamesNK/Newtonsoft.Json/blob/master/Src/Newtonsoft.Json/Newtonsoft.Json.csproj#L3. There is no need to target netcoreapp2.0. See here for more information about netstandard https://docs.microsoft.com/en-us/dotnet/standard/net-standard

.netstandard 2.0 is indeed in the source code but, if I'm correct, still
not yet released
On Mon, Nov 13, 2017 at 3:39 PM, ralsu091<EMAIL_ADDRESS>wrote:

Json.Net targets netstandard 2.0 and other netstandards
https://github.com/JamesNK/Newtonsoft.Json/blob/master/
Src/Newtonsoft.Json/Newtonsoft.Json.csproj#L3. There is no need to target
netcoreapp2.0. See here for more information about netstandard
https://docs.microsoft.com/en-us/dotnet/standard/net-standard
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/JamesNK/Newtonsoft.Json/issues/1498#issuecomment-343938508,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABbrOF9n5rQzHsrNGv0Y8kGgOzXPy0Tiks5s2FSogaJpZM4Qb0tU
.

@nbsoftware right, the latest on Nuget doesn't target netstandard2.0 but targets netstandard1.3. My understanding is that an app targeting netcoreapp2.0 should be able to reference lower netstandard packages.
I guess you will have to wait for a new release if you really want the netstandard2.0 targeting.

There will never be an assembly targeting netcoreapp2.0. The next release will have a netstandard2.0 target.


Add support for detached canvas element

Allow to create a chart from a canvas not yet attached to the DOM (detection based on CSS animations described in https://davidwalsh.name/detect-node-insertion). The resize element (IFRAME) is added only when the canvas receives a parent or when style.display changes from none. This change also allows to re-parent the canvas under a different node (the resizer element following). This is a preliminary work for the DIV based resizer.
Fixes #3790

FYI This broke our isomorphic app on line 274 of platform.dom.js. The issue is that document doesn't exist for document.createElement('style') under Node.js and somehow that is now being called when the module is being loaded.

Thanks @hach-que for reporting this issue. Not sure what the best way to fix it, ideally, the DOM platform should not be instantiated on Node.js. Are you able to share your app or a minimal use case?

We can't share the application source code at this time. We're using react-chartjs2 and we're rendering on both the client and the server. This way when the user requests a page, they get the HTML immediately as the Javascript loads in (once the JS is downloaded it then takes over navigation so that everything is client side).
The best way to check for this stuff is to see if window is set with if (window) {. If it's not present in a global scope, you're not running the browser and should avoid using window or document on startup.

I'm not familiar with isomorphic apps and I don't understand why Chart.js is evaluated server side. Of course checking window will workaround that issue, but I'm wondering if it would not be better to avoid loading platform.dom.js in the case we are not in a compatible environment (ie. with window and document defined).

Well react-chartjs-2 just renders out the <canvas> tag on the server, but the issue is that the initialize method in module.exports of chart.js is now trying to access window. So I don't think it's that the code is trying to do any runtime stuff with Chart.js on the server, but rather that the initialize method called in src/chart.js is now trying to access document, so the module can't even be loaded server side now (even if we never actually use any of the functionality that hits the DOM on the server).
It's probably reasonable to just not load platform.dom.js though, especially if all DOM related access is encapsulated in that file.  Maybe a platform.null.js implementation that does nothing on every call if window / document is not present?

(The reason we want the <canvas> element rendered on the server is that you only get the benefits of server side rendering if the HTML emitted by the server exactly matches the HTML that would be rendered by React on first load, otherwise React has to recalculate and rewrite the DOM to match)

https://github.com/chartjs/Chart.js/issues/4067#issuecomment-484988121

hi, I have problems with dynamically created canvases in 2.8.0 version.
I'm trying to insert charts in DataTable, in "td" element. So, for each "td" I use appendChild() with add_shartJS() procedure. Chart data and options were taken from the documentation. The only difference is adding { responsive: false }.
add_chartJS(title) {
        var canvas = document.createElement("canvas");
        var id = 'chartjs_' + title;
        canvas.id = id;
        var ctx = canvas.getContext("2d");

        var myChart = new Chart(ctx, {
            type: 'bar',
            data: {
                labels: ['Red', 'Blue', 'Yellow', 'Green', 'Purple', 'Orange'],
                datasets: [{
                    label: '# of Votes',
                    data: [12, 19, 3, 5, 2, 3],
                    backgroundColor: [
                        'rgba(255, 99, 132, 0.2)',
                        'rgba(54, 162, 235, 0.2)',
                        'rgba(255, 206, 86, 0.2)',
                        'rgba(75, 192, 192, 0.2)',
                        'rgba(153, 102, 255, 0.2)',
                        'rgba(255, 159, 64, 0.2)'
                    ],
                    borderColor: [
                        'rgba(255, 99, 132, 1)',
                        'rgba(54, 162, 235, 1)',
                        'rgba(255, 206, 86, 1)',
                        'rgba(75, 192, 192, 1)',
                        'rgba(153, 102, 255, 1)',
                        'rgba(255, 159, 64, 1)'
                    ],
                    borderWidth: 1
                }]
            },
            options: {
                scales: {
                    yAxes: [{
                        ticks: {
                            beginAtZero: true
                        }
                    }]
                },
                responsive: false
            }
        });
        return canvas;
    }

As a result, I have empty canvases.
Also, tried to use the development build from previous comment, just to be sure, but all the same.


singular names

Fields match the registry names, as they do/will in Blocks, Items, etc.
When you read it: "block registry", "item registry", etc

I have to say, I'm not a fan. But I'll let a discussion take place.

I suggested the name change to status effect because it makes more sense than mob effect and enough people agreed for it to go thru

AFAIK the correct (English) term would be "block registry", not "blocks registry".
"block registry" -> "BlockRegistry" -> "RegistryBlock" -> "Registry.BLOCK" is imo a reasonable transformation, so the change makes sense.

Overall I like the changes, just a few that could do with better class/field names.

Beware, the sound instances in yarn is called "SoundEvent". Consider changing that.

I guess it depends on how you read it. You could read it as Block Registry or Registry of Blocks. Block Registry is probably the more proper english way... so I guess singular makes sense. I could also see Registry of Blocks just as well though.


Compilation fails with IDF 5.0.1

IDF: 5.0.1
OS: Windows 11
VS Code: 1.77.3
Espressif IDF VS Code Extension: v.1.6.1
Create sample project based on IDF C++ template (like "blink"), add "components" directory, anc checkout M5GFX and M5Unified modules, then try to use M5:
#include <cstdlib>
#include <thread>
#include "esp_log.h"
#include "gpio_cxx.hpp"
#include "M5Unified.hpp"

using namespace idf;
using namespace std;

extern "C" void app_main(void)
{
    try
    {
        GPIOInput gpio(GPIONum(26));
        gpio.set_pull_mode(GPIOPullMode::PULLUP());

        auto cfg = M5.config();
        M5.begin(cfg);
        M5.Lcd.setRotation(3);
        M5.Lcd.fillScreen(BLACK);
        M5.Lcd.setCursor(0, 0, 4);
        M5.Lcd.println("PIR TEST");

        while (true)
        {
            auto level = gpio.get_level();
            M5.Lcd.setCursor(110, 55, 6);
            M5.Lcd.println(level == GPIOLevel::HIGH ? "1":"0");
        }
    }
    catch (GPIOException &e)
    {
        printf("GPIO exception occurred: %s\n", esp_err_to_name(e.error));
        printf("stopping.\n");
    }
}

Compiler warns about deprecated API, but along those error is reported:
error: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'int' [-Werror=format=]
Adding to CMakeLists.txt as a last line in M5GFX solves problem (although it may require better solution)
target_compile_options(${COMPONENT_LIB} PRIVATE  -Wno-format)
Application @ https://github.com/andrzejroszkowski/m5gfx-sample
build-log.txt

+1

Hello, @andrzejroszkowski
Thank you for pointing this out.
I will check and make adjustments...


Targeting SDK 31 Crashes app when notification received in background

I'm not sure if this is just a me thing or if anyone else is currently experiencing this. I am using an android 12 device for testing and currently using version 3.0.1 of this plugin.
When a notification is received while the app is in the background, it crashes the app. The pertinent error message in the log states
Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent.
I can list the pending intents if helpful.
I currently have androidxenabled=true, including cordova-plugin-androidx-adapter and have no other FCM enabled plugins.
Is this an issue with the plugin? Is there a workaround or some other fix I can implement?

Yep, got the same thing and came here looking for issues. Also Android 12, targeting API 32.
2022-08-23 15:40:56.785 8434-8657/xxxx E/AndroidRuntime: FATAL EXCEPTION: Firebase-Messaging-Intent-Handle
    Process: xxxx, PID: 8434
    java.lang.IllegalArgumentException: xxxx: Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent.
    Strongly consider using FLAG_IMMUTABLE, only use FLAG_MUTABLE if some functionality depends on the PendingIntent being mutable, e.g. if it needs to be used with inline replies or bubbles.
        at android.app.PendingIntent.checkFlags(PendingIntent.java:375)
        at android.app.PendingIntent.getActivityAsUser(PendingIntent.java:458)
        at android.app.PendingIntent.getActivity(PendingIntent.java:444)
        at android.app.PendingIntent.getActivity(PendingIntent.java:408)
        at com.adobe.phonegap.push.FCMService.createNotification(FCMService.kt:447)
        at com.adobe.phonegap.push.FCMService.showNotificationIfPossible(FCMService.kt:411)
        at com.adobe.phonegap.push.FCMService.onMessageReceived(FCMService.kt:136)
        at com.google.firebase.messaging.FirebaseMessagingService.dispatchMessage(com.google.firebase:firebase-messaging@@20.2.3:85)
        at com.google.firebase.messaging.FirebaseMessagingService.passMessageIntentToSdk(com.google.firebase:firebase-messaging@@20.2.3:55)
        at com.google.firebase.messaging.FirebaseMessagingService.handleMessageIntent(com.google.firebase:firebase-messaging@@20.2.3:34)
        at com.google.firebase.messaging.FirebaseMessagingService.handleIntent(com.google.firebase:firebase-messaging@@20.2.3:23)
        at com.google.firebase.messaging.EnhancedIntentService.lambda$processIntent$0$EnhancedIntentService(com.google.firebase:firebase-messaging@@20.2.3:43)
        at com.google.firebase.messaging.EnhancedIntentService$$Lambda$0.run(Unknown Source:6)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
        at com.google.android.gms.common.util.concurrent.zza.run(Unknown Source:6)
        at java.lang.Thread.run(Thread.java:920)

It's fixed in #185 but not yet released as a new version?

Aah, thanks for noticing that PR. I was able to get notifications to work by altering my package.json dependencies and not using the version number.
"@havesource/cordova-plugin-push": "git+https://github.com/havesource/cordova-plugin-push/"

@AndrWeisR I was trying to install the plugin directly from Github.
But now,  It breaks Android build:

It seems like that's related to this PR: https://github.com/havesource/cordova-plugin-push/pull/185

iOS is failing. Did someone fix this issue?

I also have same problem with push notifications on device in background, but it happens only on certain Android devices, not on all. I'be tried changing package.json with
"@havesource/cordova-plugin-push": "git+https://github.com/havesource/cordova-plugin-push/"
but with no results.
Any news?

I am using github:havesource/cordova-plugin-push#c3fb5b894afe17a05e21be135961f5831bafb1e0

as suggested by @AndrWeisR, this line in package.json seems to solve the crash
 "@havesource/cordova-plugin-push": "github:havesource/cordova-plugin-push#c3fb5b894afe17a05e21be135961f5831bafb1e0",
But I think I am seeing a change in fuctionality. If my (React) app is in the background then the incomming Push shows up in the OS shade OK, and clicking on it brings the app to the foreground OK. But the app no longer reacts to the incomming Push.
ie the handler
window.push.on('notification', function (data) {...
is not fireing.
(handler does fire if app is in Foreground when Push arrives)

I am using github:havesource/cordova-plugin-push#c3fb5b894afe17a05e21be135961f5831bafb1e0 successfully.

When i try to install it, I getting this error:
Failed to fetch plugin github:havesource/cordova-plugin-push#c3fb5b894afe17a05e21be135961f5831bafb1e0 via registry.
You know why?

Closing this ticket as resolved. The fix from PR #185 has been merged and released in version 4.0.0.


Add Chris M's contained instance example

It's very handy to have an example of a contained instance in FSH.
Credit to @cmoesel from https://chat.fhir.org/#narrow/stream/179166-implementers/topic/Custodian.20Practitioner.20References/near/380755922

Sure, done.


Timeout issues when using MacOS Sierra and IPv6

I just upgraded to MacOS Sierra and all test using passthrough server timeout. I finally found the origin stack trace:
test_expose(org.terracotta.management.entity.management.ManagementAgentServiceTest)  Time elapsed: 20.344 sec  <<< ERROR!
org.junit.runners.model.TestTimedOutException: test timed out after 5000 milliseconds
	at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
	at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
	at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
	at java.net.InetAddress.getLocalHost(InetAddress.java:1500)
	at org.terracotta.passthrough.PassthroughServerProcess.connectConnection(PassthroughServerProcess.java:961)
	at org.terracotta.passthrough.PassthroughServer.connectNewClient(PassthroughServer.java:116)
	at org.terracotta.passthrough.PassthroughConnectionService.connect(PassthroughConnectionService.java:62)
	at org.terracotta.connection.ConnectionFactory.connect(ConnectionFactory.java:43)
	at org.terracotta.management.entity.management.ManagementAgentServiceTest.test_expose(ManagementAgentServiceTest.java:123)

Also:
➜  terracotta-platform git:(issue-178) ✗ cat /etc/hosts
##
# Host Database
#
# localhost is used to configure the loopback interface
# when the system is booting.  Do not change this entry.
##
<IP_ADDRESS>       matc.local
<IP_ADDRESS>	localhost
<IP_ADDRESS>	broadcasthost
::1             localhost

I think something has changed in Sierra concerning the ip stack settings that cause timeouts when connecting to uris like:
passthrough://localhost:9510/.
Yesterday, I had the problem when connecting the TMS to a real voltron server by using: terracotta://localhost:9510 or terracotta://<IP_ADDRESS>:9510. I had to disable the firewall (weird on the local interface)

If you look at the stack trace you posted, the hang is in java.net.InetAddress.getLocalHost.  The passthrough server doesn't create any connections through the network stack.  The only reason why it is asking for localhost data is to generate some of the fake data for PlatformConnectedClient.
This is a known issue with Sierra which appears to be resolved by fiddling with the /etc/hosts on the machine where it is observed.  While the one you posted should be reasonable, I don't have a sense of the before and after appearance in the cases of people who have fixed it.

Assuming "matc" is your machine name, you need to put that entry last:
<IP_ADDRESS>	localhost
<IP_ADDRESS>	broadcasthost
::1             localhost
<IP_ADDRESS>       matc.local

I did that @GaryWKeim :
➜  terracotta-platform git:(issue-178) ✗ cat /etc/hosts
##
# Host Database
#
# localhost is used to configure the loopback interface
# when the system is booting.  Do not change this entry.
##
<IP_ADDRESS>	localhost
<IP_ADDRESS>	broadcasthost
::1             localhost
<IP_ADDRESS>       matc.local

And I still have the same issue.

I needed to add both lines to make it work.
<IP_ADDRESS>       matc.local
::1             matc.local

OK, but I didn't do that and I don't have any problems.


List ITEM_REMOVED event with index of the removed object as param of the eventHandler onSuccess function

List ITEM_REMOVED event with index of the removed object as param of the eventHandler onSuccess function.
the list.remove function receives an index but the ITEM_REMOVED callback is called with the element removed and without the index information

Also, providing a method list.add(item, index) would be interesting


Fix SNYK-JS-ANSIREGEX-1583908 and move to ESM

Is your feature request related to a problem or a nice-to-have?? Please describe.
As of https://snyk.io/vuln/SNYK-JS-ANSIREGEX-1583908 my investigations lead to mocha referencing the vulnerability by peer dependencies of "wide-align": "v1.1.3" -> "string-width": "^1.0.2 || 2" -> "strip-ansi": "^4.0.0" -> "ansi-regex": "^3.0.0".
Describe the solution you'd like
Forcing @iarna to accept https://github.com/iarna/wide-align/pull/57 from @jimmywarting will update "string-width": "^5.0.1" resulting in a fix of https://snyk.io/vuln/SNYK-JS-ANSIREGEX-1583908 with peer-dependencies "strip-ansi": "^7.0.1" -> "ansi-regex": "^6.0.1". It will require some changes towards ESM on mocha-side too: https://github.com/mochajs/mocha/blob/27bfc7425fed7a9a9cadb6dabc536a0bd32abd7a/lib/cli/one-and-dones.js#L11
Describe alternatives you've considered
Alternatively the use of @jimmywarting branch https://github.com/jimmywarting/wide-align/tree/esm as dependency, or investigation of a replacement for string-width are thinkable.

We get issues like this one on regular basis.

please add a PoC explaining how this ReDoS is supposed to affect Mocha. Is there a masked tester attacking himself? How will he/she accomplish this attack? Which server/services are endangered?
[...] move to ESM: no, we won't move to ESM for now. Certainly not based on a security message like this.

I have used a simpler variant in one other project of mine (not that it dose not take into consideration the string width)
export function alignLeft(str, width) {
    return String(str).slice(0, width).padEnd(width)
}
export function alignRight(str, width) {
    return String(str).slice(0, width).padStart(width)
}
export function alignCenter(str, width) {
    const internalString = String(str)
    const leftPadding = Math.floor((width - internalString.length) / 2) + internalString.length
    return internalString.padStart(leftPadding).padEnd(width).slice(0, width)
}

honestly, now when i looked at what you used wide-align for in the one-and-done (which is the only place)
where it only use align left and dumps something out in the console.log
https://github.com/mochajs/mocha/blob/27bfc7425fed7a9a9cadb6dabc536a0bd32abd7a/lib/cli/one-and-dones.js#L32-L36
then i don't think the wide-align package (and 4 other dependencies) is worth keeping around to solve one such tiny thing. 2kb don't justify the things you use it for.
there are other decent ways to present it into the log with 0 dependencies.
i say: remove the wide-align dependency (and don't replace it with something else)
find other ways to dump it nicely to the log

I don't have an opinion here as to if you should use wide-align but I will note that it doesn't do the same thing as the code @jimmywarting -- the whole point of wide-align is that it can do console alignment of wide characters, something that anything using padStart/padEnd (or string.length) is gonna fail at. If wide characters are not a concern, then there's no point in using the module. If they are important, then you need either wide-align or another module that implements the same logic.

@dhuang612 are you interested in removing dependency wide-align and replacing it with alignLeft() shown above?
If yes, go ahead and open a PR, please use npm v6 to rebuild package-lock.json.

Hi,
Was I tagged by mistake?

No

Sure, I can try to work on this

@dhuang612 I will publish a new release this weekend, probably.
I would take over this one, unless your PR is ready within the next days. Thanks.

I am really busy over this next week and wouldn't have time to get to it before October.


github action runs npm ci and npm test

Duplicates Circle CI config to GitHub Actions to run tests on here

Now we actually need to write test. 😂

@jameskip tbh, I thought assert poop was a reasonable smoke test.


Are here document or example? thx

native ad is not implemented.


Save Manager struggles with loading on startup

When the save manager has a lot of logs and save codes stored, it struggles to load for a while on startup.

Hey, thanks for reporting. This happens because VRChat logs persist for some users, like me. Probably because VRChat fails to delete them or some launch parameters might make them persist that way. And I am reading logs to recover saves just in case.
Since It is always reading logs on app start up, it takes some time to parse every line for each log file.
I will make reading already parsed logs an optional feature, that should make things load quickly.

Yup. After updating with the artifact it loads swiftly for me now and no longer hangs on startup.


Lint/ShadowingOuterLocalVariable: clarify the ruby warning [doc]

Make it clear that ruby no longer warns about variable shadowing:

The “shadowing outer local variable” warning is removed. [Feature #12490]

Thank you!


Add anime to the top bar

The top bar is very lonely. We should add anime characters because it's funny in the top bar. Frfr if you agree leave a comment

+1 🚀

I agree. We should add more NPC's and my cs3241 lab 3 render to the top bar!

Skull Emoji


Remove hidden attr when showing DjDT items and readd it when hiding.

Another take at #742.
Removes hidden attribute when showing items and adds it when hiding. It does add the attr in a lot of places.
This approach does seem to break fade-in animation though. Fade-out animation is unaffected.

I checked and it seems function show_toolbar(animate) is never called with true, hence fade-in animation code is never run. Removing the functionality if it's not used is probably out of scope of this PR, though I can do it in a new PR if people think it's a good idea.

It's unlikely that we'd remove show_toolbar since it's a part of the public API for the toolbar. An improvement I can see with this PR would be to create a jQuery plugin that would handle removing of the hidden attribute and handling the hide call at once to make things a bit cleaner.
If you have the time to implement it, great. Otherwise I'll test this out when I have some time and get it merged.

I found some time this morning and implemented a jQuery plugin for show/hide functionality. It may be rough around the edges as I'm bad at Jabbascript. Feel free to comment if something looks wrong.


Edge color in svg graphs

Hi,
When I dynamically upadate the edge.color property, the color changes fine with the canvas and webgl renderer. But the color does not update when I am using the svg renderer. Any suggestions?

Hello @wrick17. This is probably because I forgot to deal with colors in the dedicated renderer. Probably because my use cases were dealing with a freeStyle renderer so that CSS classes can apply etc. Let me check that.

Thanks. Well I am new to this, so i am using the default one only, thats how i came to see the issue.

With freestyle to true or false, CSS class are applied.
In the 'svg-freestyke-renderer.html, if I remove css, and put a red color on edge, it's working.

I am trying to use the default svg renderer. there it is not applying.

What is for you the default SVG renderer  (for me I use it) ?
Can you create a plunker with an example of your code ?

err posting the code is a bit tough. its way too complex. i'll post a snippet below:
$.each(s.graph.nodes(), function(index, node) {
if (mod_array[node.attributes.modularityclass] === undefined) {
node.color = getRandomColor();
mod_array[node.attributes.modularityclass] = node.color;
} else {
node.color = mod_array[node.attributes.modularityclass];
}
});
$.each(s.graph.edges(), function(index, edge) {
  edge.color = s.graph.nodes()[edge.source.split('').splice(1, edge.source.split('').length - 1).join('')].color;
});

so this is how i am adding color to the nodes and edges. so nodes and edges from the same community have the same color.  then i do this:
s.startForceAtlas2({
strongGravityMode: true,
gravity: 0.1,
worker: true,
scalingRatio: 1,
slowDown: 2,
barnesHutOptimize: true,
barnesHutTheta: 0.1,
nodesize: 'original'
});
  s.refresh({
    skipIndexation: true
  });

and the graph renders. it goes well with canvas and webgl. but doesnt go for svg.
PS: sorry for the bad formatting. i m really new to this. :p

I think the bug come from the update method into the file sigma.svg.edges.def.js.
If I add this line it's work line.setAttributeNS(null, 'stroke', edge.color);

@sim51 where do i add it? a little detail would really help. thanks

https://github.com/jacomyal/sigma.js/blob/master/src/renderers/svg/sigma.svg.edges.def.js#L62

@sim51 sorry. no luck. still taking the default color.
i tried to change it to this:
line.setAttributeNS(null, 'stroke-width', edge[prefix + 'size'] || 1);
  line.setAttributeNS(null, 'stroke', edge.color);
  line.setAttributeNS(null, 'x1', source[prefix + 'x']);
  line.setAttributeNS(null, 'y1', source[prefix + 'y']);
  line.setAttributeNS(null, 'x2', target[prefix + 'x']);
  line.setAttributeNS(null, 'y2', target[prefix + 'y']);

still it takes the default color.

Look at this example : http://embed.plnkr.co/Rvgzjq5vor97lFKNl1vj/preview
All edges are blue, not red

@sim51 so can i update the graph without recreating the sigma instance? i mean i am using forceAtlas2 which adds properties to the running instance. based on that i have to change the colors and update the graph.

@wrick17 yes of course, it what I do into the example ... I have created a sigma instance with red edge, and after (with your code snippet) I change all edge color to blue (and it's the same sigma instance!).
If you want to run a forceatlas after the color modification, you can. I have added it to the example.


Configure Github Actions script for Continuous Deployment

Configure Github actions script for continuous deployment of the master branch. You can refer Github Actions
Open for any other tool you know of for automated deployment on Github pages.

I can pick this up after Containerization commit

I was trying my hand at this. Build keeps failing, need to fix that. I hope the below script might come in handy

name: Build and Deploy
on:
push:
branches:
- master
jobs:
build-and-deploy:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v1
- uses: actions/setup-node@v1 #this installs node and npm for us
with:
node-version: '12.x'
- uses: actions/cache@v1 # this allows for re-using node_modules caching, making builds a bit faster.
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-
- name: Build
run: |
npm install
npm run-script deploy
- name: Deploy
uses: JamesIves/github-pages-deploy-action@releases/v3
with:
GITHUB_TOKEN: SHA256:qK2PuGso5dA95xjcEI6ZnX1caMeSm8gtJ1vHV31wpyk
BRANCH: gh-pages
FOLDER: dist/ifsc

Do you have logs ?
I was also trying to run with the following script and error , Can you help me I do not have much idea abiut node and angular
####################################################################################################
This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
name: Node.js CI
on:
push:
branches: [ workflows ]
pull_request:
branches: [ workflows ]
jobs:
build:
runs-on: ubuntu-latest

strategy:
  matrix:
    node-version: [12.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
  uses: actions/setup-node@v1
  with:
    node-version: ${{ matrix.node-version }}
- run: npm install -g @angular/cli #install angular cli
- run: npm link @angular/cli #link angular cli
- run: npm install
- run: ng build
- run: ng test

########################################################################################
Run ng build
internal/modules/cjs/loader.js:968
throw err;
^
Error: Cannot find module 'ansi-colors'
Require stack:

<EMAIL_ADDRESS><EMAIL_ADDRESS>/opt/hostedtoolcache/node/12.18.4/x64/lib/node_modules/@angular/cli/bin/ng
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:965:15)
at Function.Module._load (internal/modules/cjs/loader.js:841:27)
at Module.require (internal/modules/cjs/loader.js:1025:19)
at require (internal/modules/cjs/helpers.js:72:18)
at Object. (/opt/hostedtoolcache/node/12.18.4/x64/lib/node_modules/@angular/cli/utilities/color.js:11:20)
at Module._compile (internal/modules/cjs/loader.js:1137:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
at Module.load (internal/modules/cjs/loader.js:985:32)
at Function.Module._load (internal/modules/cjs/loader.js:878:14)
at Module.require (internal/modules/cjs/loader.js:1025:19) {
code: 'MODULE_NOT_FOUND',
requireStack: [
<EMAIL_ADDRESS><EMAIL_ADDRESS>'/opt/hostedtoolcache/node/12.18.4/x64/lib/node_modules/@angular/cli/bin/ng'
]
}
Error: Process completed with exit code 1.

@bishtsaurabh5 Awesome work with #29 .


A batch of changing: GUI support, URDF/SDF include tags, better docs.

Did we change anything in Aidan's SDF parser? I can't pass the tests.

Did we change anything in Aidan's SDF parser? I can't pass the tests.

It looks the API for load_sdf as been changed. It was previously def load_sdf(model_name: str, models_dir: str) -> SDF:
The tests that are failing use a fixture models_dir defined in tests/conftest.py which returns the path of the lisdf-models/models directory.

I addressed all the comments. Thank you both!!
I haven't added more tests.


Autodetect device in MS5611 driver

@ChristophTobler this should fix the offset in the altitude reported by the barometer in your board.

@lucasdemarchi Thanks! I'll give it a try as soon as possible

@lucasdemarchi I can confirm that this fixes the baro offset


🥢 ERC721: what does the double xor achieve in _setExtraData

Hey, so ive been gawking over
    /// @dev Sets the extra data for token `id` to `value`.
    /// Minting, transferring, burning a token will not change the extra data.
    /// The extra data can be set on a non existent token.
    function _setExtraData(uint256 id, uint96 value) internal virtual {
        /// @solidity memory-safe-assembly
        assembly {
            mstore(0x00, id)
            mstore(0x1c, _ERC721_MASTER_SLOT_SEED)
            let ownershipSlot := add(id, add(id, keccak256(0x00, 0x20)))
            let packed := sload(ownershipSlot)
            sstore(ownershipSlot, xor(packed, shl(160, xor(value, shr(160, packed)))))
        }
    }

The double xor does seem to ensure that value gets the correct value after the first xor:
xor(value, shr(160, packed)))
But Im just wondering, is there anything wrong/bad with just:
 sstore(ownershipSlot, or(packed, shl(160, value)))
I would appreciate your insight on this, thank you :)

Also forgive me if gh issues is not the best medium for this question. lmk if these types of q's are better suited for twitter or some other medium :)

The aim is to replace some of the old bits with the new bits.
One way is to mask out the old bits with an and, and do a or to overlay in the old bits.
Another way is to do a xor with some number that will flip the bits in a way that gives the same result.
This special number will be the xor difference between the old number and the desired final result.
Hence the double xors.
The second way is sometimes slightly more efficient, and gives more compact bytecode.


Feature/gunney/multidomain closest point search

Support domain over/underloading in DistributedClosestPoints (obsolete)
This PR has been superceded by PR #950.

This PR is a feature
It does the following (modify list as needed):

Modifes DistributedClosestPoints to support multidomain (or singledomain) blueprint meshes (for both object mesh and query mesh).  Domain underloading is when the blueprint mesh has no domain locally.  Domain overloading is when the blueprint mesh has multiple domains locally.
Largely preserves the search code.  Domain loops were put around domain operations.  The most significant changes were caused by the change from the singledomain blueprint format to the multidomain format.
Continues to support singledomain objects.  The code puts the single domain in a temporary multidomain object, using conduit::blueprint::mesh::to_multi_domain, which doesn't require any deep copies.
Preserves DistributedClosestPoints API.  The code just does the right thing when given a multidomain mesh.
Changes the distributed closest point search tests.  The test no longer uses the singledomain MFEM meshes.
Add utility script src/tools/gen-multidom-structured-mesh.py for generating simple multidomain meshes.  I've generated 2 meshes and added them to axom_data so we don't have to run this script in the test recipe.  The script requires a conduit build that with conduit's python3 interfaces enabled.  The meshes added to axom_data were 2-domain and 6-domains.

This fixes issue https://github.com/LLNL/axom/issues/909
This is a high-priority feature for Ares.

@gunney1 -- if #950 supersedes this PR, should this one be closed?

This PR has been superceded by PR #950.  Closing.


Hope to provide multi-language support

Recognize the current language environment and change the software language.

Sorry, I don't have any plans to localize the app. It's simply too much work for a free app.


Escape angle brackets

Fix Markdown missing text in "http://:9000/, where is the internet" by escaping

@javierruizjimenez : Thanks for your contribution! The author, @barbkess, has been notified to review your proposed change.


Trailing comma of a closure-like macro is deleted when the macro requires it

rustfmt deletes the trailing comma of a closure-like macro invocation even though the macro requires the trailing comma to compile.  For example, with
macro_rules! m {
    (|$($up_var:ident,)*| $body:block) => {};
}

fn f() {
    m!(|x,| {});
}

rustfmt tries to apply this change:
 fn f() {
-    m!(|x,| {});
+    m!(|x| {});
 }

But this change would not compile.
In this case of the macro, the trailing comma isn't needed; it could be rewritten to not require it.  But for something like this,
macro_rules! m {
    (|$($up_var:ident: $up_var_ty:ty$( = $up_var_val:expr)?,)*| $body:block) => {};
}

the trailing comma is necessary since | cannot come after a :expr.
rustfmt doesn't usually seem to format the code within a macro invocation (and doesn't otherwise for this use case, like wrapping long lines), except now it's reformatting things such that the code won't compile anymore.

This is a tough one. rustfmt doesn't have context about the macro definition when rewriting the macro call so it doesn't know that the trailing comma is actually required, and because the body of the macro parses as a closure rustfmt is going to format this as a closure.
Great to see that you can modify the macro definition to make the comma optional, but if you're using nightly rustfmt you can also consider setting the skip_macro_invocations config in your rustfmt.toml.