Runtime issue relating to NavigationLink usage

I'm not sure if it's possible to fix this, but at runtime I get the following issue:

NavigationLink presenting a value must appear inside a NavigationContent-based NavigationView. Link will be disabled.

I'm not 100% confident of the root cause of this, but I know it happens when I tap an NBNavigationLink.
I see 2 places in the project that use NavigationLink: https://github.com/johnpatrickmorgan/NavigationBackport/blob/79fed7bfd6323850634881632365c7f4318442f0/Sources/NavigationBackport/Router.swift#L36 and https://github.com/johnpatrickmorgan/NavigationBackport/blob/79fed7bfd6323850634881632365c7f4318442f0/Sources/NavigationBackport/Node.swift#L38. I tried – naively – to wrap these in NavigationViews, but I guess the NavigationView then handles/overrides the links being tapping the link then does nothing.
Maybe this is something we'll just have to live with, but it would be nice to not have the runtime issue if possible!
I'm using Xcode 14 beta 2.

Thanks @JosephDuffy. My guess is that these are erroneous warnings: the text refers to NavigationLink presenting a value, but the only NavigationLinks used, as you found, are not using the value-based initialisers. I also saw a couple of others saw these warnings inexplicably, but I wasn't able to make a small reproduction.

Sounds like a beta bug then, hopefully it gets resolved in an Xcode update 😊
I'm happy for this to be closed, or kept open for visibility, it's up to you!

Thanks, I'll leave it open for visibility and hope it gets resolved.

I get the same message when I tap the back button but nothing is broken

Thanks, I still think this is an erroneous message. I can trigger it with the following vanilla SwiftUI code:

import SwiftUI

@main
struct NavigationWarningLogDemoApp: App {
  var body: some Scene {
    WindowGroup {
      NavigationView {
        Content1View()
      }.navigationViewStyle(.stack)
    }
  }
}

struct Content1View: View {
  @State var pushing = false

  var body: some View {
    VStack {
      NavigationLink(destination: Content2View(popToRoot: { pushing = false }), isActive: $pushing, label: { Text("Go")})
    }
    .navigationTitle("1")
  }
}

struct Content2View: View {
  @State var pushing = false
  let popToRoot: () -> Void
  var body: some View {
    VStack {
      NavigationLink(destination: Content3View(popToRoot: popToRoot), isActive: $pushing, label: { Text("Go")})
      Button(action: popToRoot, label: { Text("Pop to root")})
    }
    .navigationTitle("2")
  }
}

struct Content3View: View {
  @State var pushing = false
  let popToRoot: () -> Void

  var body: some View {
    VStack {
      // The warning does not appear if you remove this NavigationLink.
      NavigationLink(destination: Text("4"), isActive: $pushing, label: { Text("Go")})
      // Tapping this button triggers a warning to be logged:
      //
      // NavigationLink presenting a value must appear inside a NavigationContent-based NavigationView. Link will be disabled.
      Button(action: popToRoot, label: { Text("Pop to root")})
    }
    .navigationTitle("3")
  }
}

I’ve filed a feedback FB11490806.

Still experiencing this issue. Any ways to solve it?

@ivarvanwooning I'm afraid not. As this affects vanilla SwiftUI (whenever a NavigationLink is removed from the view tree due to popping multiple screens), I can't do much beyond filing a feedback (FB11490806).

@johnpatrickmorgan Ah, that's really too bad. The library works amazing, but it fills my console with warnings. Hopefully we can somehow find a workaround or way to mute it in the future.

Apple replied:

The NavigationView API  and the NavigationLink(destination:isActive:label:)' method was deprecated in iOS 16.0: I would recommend you use NavigationLink(value:label:) inside a NavigationStack or NavigationSplitView. It’s important you consider migrating to new navigation types.
The compiler warnings are a good indicator of potential issues in your project. Disabling the compiler warnings is typically not the recommended approach. Additionally, I would suggest you migrate to the New Navigation type and use a conditional compilation so you're able to support iOS less than 16.0.
Apart from this, there is no workaround DTS can provide for Feedback ID FB12111423; it is still under investigation. Please continue to track the problem via the bug report.

Not very helpful.

In the latest release (v0.8.0), you can add .nbUseNavigationStack(.whenAvailable) anywhere outside your NBNavigationStack so that the library will use NavigationStack under the hood instead of NavigationView, which avoids these annoying logs.


Upgrade @kyma-project/asyncapi-react to 0.14.2

There is an interesting fix for displaying async messages in the docs.
See https://github.com/asyncapi/asyncapi-react/pull/156
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)

@Fox32 one conflict to solve - maybe there will be more after we merge #2654 - please hold off on merging this one as well until after that :) It's due to be merged tomorrow morning

@freben If I resolve the conflict, should I also add a changeset?

@Fox32 Can be good to add a patch changeset to make sure that it gets released

Done!


How does this compare to Trusted Advisor reports?

I was left wondering after reading through the brief, how does this compare to built in Trusted Advisor reports on cost optimization?

Thanks for your feedback. We have updated the FAQ to include this:
Q: How does this solution differ from the AWS Trusted Advisor Cost Optimization check?
Both the EC2 Right Sizing solution and AWS Trusted Advisor analyze utilization on EC2 instances running any time during the last two weeks. The EC2 Right Sizing solution analyzes all instances with a max CPU utilization lower than 50% and determines a more cost-effective instance type for that workload, if available. In comparison, AWS Trusted Advisor can alert you to low utilization thresholds such as daily CPU utilization of 10% or less and network I/O of 5 MB or less on 4 or more days during the two-week period.
Each tool provides valuable information about your Amazon EC2 usage that can help you lower your costs.

what is the amount of time it takes to run the complete script, please post the steps to implement in manually without cloud formation template


assertion for :focus

Would you find it useful to have a new assertion for focus (as per jQuery's focus selector)
In the end, we would get something like: expect('#mystuff').to.have.focus as a new assertion.
If it makes sense to you (notably @keithamus), I'd be happy to try a PR for that!

I'd say that makes perfect sense!
It should be really easy to add, all you need to do is add 'focus' to the list of is assertions, on L157-164.
Of course, the trickier part might be writing tests for it. You could use one of the existing tests, for example here is the test for .visible.
Lastly, you'd also need to add some documentation into the README. Maybe somewhere about here would do.
Let me know when you've made a PR, and I'll happily review it - with a view to merging and releasing as a minor version :smile:

Thanks for this @keithamus, you definitely made the PR easier to write! I'm on it, I'll come back to you within a few hours...

Feel free to take about 8 or 9 hours, as I wont be back on until then :wink:

So I tried to create this new assertion...
I finally did not add 'focus' to the list of 'is' assertions as you suggested, but I created a new method for that, and I've written some tests.
The tests simply don't pass on the CLI. But after an hour of struggle, I tried to open test/index.html in a browser and got the tests to pass (without modifying anything).
Here is a gist of what I've actually done: https://gist.github.com/T1st3/b500986f0209466c16e5, if you'd like to check by yourself.
So, I'm still in an investigation about these tests that work in the browser but not on CLI. I think the problem is on PhantomJS's side (see a bug in PhantomJS about focus: https://github.com/ariya/phantomjs/issues/10427).
At the moment, this can't be added to the project as-is. I'm going to rethink about this before submitting a PR...

@T1st3 you should absolutely file this as a PR - because we can work on it together, or others can provide input there.
Ultimately, jQuery's :focus is a well tested piece of code - so if need be we can just mock jquery to ensure the assertion is calling the right things, forgoing the need for Phantom or a Phantom like environment.
I say raise the PR, and we'll

Actually, I just noticed the same work has been done before in #55. @golmansax managed to pass the tests, but he used a workaround rather than jQuery's own is(:focus)

So the tests don't pass on the CLI with PhantomJS, and they also don't pass in Google Chrome or Rekonq (all 3 are Webkit implementations).
These tests only pass when using Firefox.

If I try the following workaround just before the tests for the assertion, I get the tests pass on the CLI, in Chrome and in Rekonq:
  var _jQuery_is = $.fn.is;
  $.fn.is = function(s) {
  if (s === ':focus') {
    return this.get(0) === document.activeElement;
  }
    return _jQuery_is.apply(this, arguments);
  };

Yet, it solves the problem, but it is kind of ugly... I don't think that such monkey-patching should be used in tests.

You could apply that behaviour inside of the assertions instead. Or as I say just spy on the is method to make sure we're calling jQuery's api and be done with it.

I finally put the workaround directly in the assertion, as in commit https://github.com/chaijs/chai-jquery/commit/11ddaf979ecb5f5308fbd1610800a152a80570d5 .
Now tests pass (see PR #73).
Sorry for the delay on this!


Added banner config to english emotion demo data

1. Why is this change necessary?
That place is clickable in german emotion, but in english its does not work 😢 . I want to buy a fancy Ibiza Beach Towel
2. What does this change do, exactly?
Adds the missing banner config
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[X] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-21557
Please use this issue to track the state of your pull request.

Thanks @shyim  👍


firefox: increase build timeout

Motivation for this change
Firefox aarch64 builds are timing-out: https://hydra.nixos.org/job/nixos/unstable-aarch64/nixpkgs.firefox-unwrapped.aarch64-linux
Things done
Increase meta.timeout.

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Wait... the link you referenced had a last attempt years ago.  How is that relevant now?  Besides, I hear that the default is 10h so it's actually a decrease.

Its not relevant, I'm just not able to navigate hydra effectively :\


Issue 013

Page now scrolls to most recent AI message.

Nice 👍

Yeah works fine. I think for M3 we should probably find a way to get either the search bar to move down, or generate a new one with each response


set_machine_var vs create_machine_var

Can we remove create_machine_var? What is the usecase for set_machine_var which just ignores variables when they have not been created before.
I propose either:
a) Remove create_machine_var
or:
b) Raise an exception when using set_machine_var (MPF will no longer start in almost all cases)

Let's change machine vars so they are more similar to player vars. We can use the same base class and they can live in self.machine.vars. That way you don't need the create method.
Then for machine vars that persist to disk, we can create another subclass and only those will use the create method (since they need to have settings for expire time, etc.)


Installation fails in Windows 11

I was able to clone, but installing from requirements fails. How do I get around this?
For reference I'm using a RTX 4090 system with i9-13900k CPU, 96GB of RAM, so any optimizations suggestions also appreciated.

You can install PyTorch separately, from here. CUDA toolkit can be installed from here.
To run the JIT version of ExLlamaV2 you'll also need the Visual Studio (or VS build tools) installed, but alternatively you can get a prebuilt wheel from here.
As for optimization, you'll probably want flash-attn-2 installed, though it can be a bit tricky on Windows. There are people who've got it working. Then, if you're on the latest NVIDIA driver keep an eye on your VRAM usage and see if it seems suspiciously high (as in, higher than 24 GB) since then the driver may have started swapping VRAM to system RAM which slows everything to a crawl. There should be an option for disabling that behavior in the latest driver, or you could downgrade to 531.x or lower.

"You can install PyTorch separately, from here. CUDA toolkit can be installed from here."
Thanks, but I already have both of these installed, because I use Automatic1111 (and SD.NEXT) and OOBE for AI text generation (all of which require these)...at least I know OOBE is using 12.1 CUDA and my other image generation software is using Pytorch...so I'm not sure why it's acting like I don't have these installed.
I guess I'll wait until flash-attn-2 is more friendly to install in Windows...not good enough at that...

Are you sure you have torch installed? According to the screenshot you don't, or at least it's in an isolated venv somewhere. It's also possible you have an older version (probably 2.0.1) and simply need to upgrade.
As for Flash Attention, it's entirely optional. It helps on long contexts, but it's not a massive difference most of the time.

so... it needs to install another copy of pytorch and everything else, in addition to Auto1111, Oobabooga & etc?

It needs a copy of PyTorch. Oobabooga etc. install themselves into virtual environments to keep everything because they have a mountain of dependencies that all need to be very specific versions. Which also means that all those dependencies aren't available to other applications.
This pretty much just needs the latest PyTorch and ExLlamaV2.

Hmm ok, I installed the requirements, now it fails to start with

No CUDA runtime is found, using CUDA_HOME='C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA\v11.3'
Traceback (most recent call last):
...
import exllamav2_ext
ImportError: DLL load failed while importing exllamav2_ext: The specified module could not be found.

Does it really need the CUDA toolkit installed? Which version?
Where do I get exllamav2_ext?

exllamav2_ext is a component of the exllamav2 package. It's a PyTorch extension that gets built and loaded when you import exllamav2, which requires CUDA to be installed. You can also install the extension as its own package with python setup.py install --user`.
Alternatively, there are prebuilt wheels here that contain both exllamav2 and exllamav2_ext pre-compiled for various CUDA and Python versions. These should work without the CUDA toolkit installed. It does look like there were some changes made to PyTorch between versions 2.0.1 and 2.1.0, so you'll probably need PyTorch>=2.1.0 since they were pre-built on that version.

This is where I installed exllamav2 from, and it gave me all the above error messages.
It seems to me that pip install -r requirements.txt installed a CPU-only version of PyTorch. I've reinstalled it using command line from https://pytorch.org/get-started/locally/, and now it actually works.


[Feature Request] Font Selection

Thanks for this pretty theme.
I would love to be able to customize it by defining fonts myself.
Would this be non-trivial to implement?

This may be possible, I'll try to look at it, but to be honest it would be simple to edit the theme and build it from sources

I want to change fonts too, at least deactivate italic.
Thanks for this great theme, i'm using it on Xubuntu.

@rauldipeas This feature is not a priority for the project, but as suggested by the author, you can edit the theme in place to point to the font you wish to use.
See https://github.com/Litarvan/lightdm-webkit-theme-litarvan/search?q=font&unscoped_q=font


top navbar: Add nice support for long/multi-line stream descriptions

Here's the new top navbar design from #11894:

If one writes a stream descriptions that's longer than a single line, we don't have a great way to display it, either here or in the
I think it'd be nice to design a way to see longer descriptions.  One design idea that's been suggested a few times is to have a button to pop down a block showing the full stream description (overlayed over the message feed) extending the current navbar area when one hovers the mouse over the stream description text.

Update by @alya (2023-06):
Design from #21913:
Description is a text without formatting, but links are autodetected. Usually it's no longer than 1 line and fits into the dedicated space. I thought to have more link to expand, but it takes extra space and feels too complex.

So I suggest to expand description on hover in a rectangle with 5px corder radius of the same background color. This will be pretty rare case but it might be important for those cases.
In the normal state the text of description just text-overflow: ellipsis;. Description area should be from the end of stream/narrower name till the search button.

@zulipbot claim

I think we've settled on at least the first version of the design for the the initial and final states for this.
The initial state this this message https://chat.zulip.org/#narrow/stream/101-design/topic/navbar.20redesign/near/883327 and the final state is as in the figma prototype just a little above.

for a touch device we could use tap on description to pop it like this and touch again to pop it back in, unless the touch resulted in text selection

Sounds good, added the above comment to the issue description.

I think having the description expandable will also help new users select the correct channel for their first post. Since the full descriptions are difficult to discover, I'm observing that new users just tend to guess which channel to use, and more often times than not guess wrong. For example, we get a lot of new users making their first post to #announce instead of #users. But the description of the two channels clearly states that they should post to #users first.


Frame background image keeps changing

I have my own background image for IDE "Frame", but it's changed on every IDE restart to https://raw.githubusercontent.com/mallowigi/material-theme-jetbrains-extended/master/src/main/resources/themes/wall.jpg.
Please don't modify this setting if it was already modified by user.

Apparently there is a bug with "set Custom Wallpaper option" as it doesnt get saved. Taking care of it.

OK I've released a fix, it should be working now.

Oh, I didn't realise there's an option for that. It probably should default to false, though.

I've updated to the latest version and now it removes wallpaper set manually :(

And I also can't just set "Custom Wallpaper" path because it doesn't provide a way to change opacity.

Are you sure? I tested unchecking the option and setting a new manually through the IDE and it worked...
I will check it again...

Pretty sure, yeah. Don't know if it matters, but I'm using PyCharm 2017.2 EAP (Build #PY-172.2656.2, built on May 30, 2017).

By the way, did you restarted IDE after unchecking option and setting wallpaper?

You're right, it does overwrite the custom bg. I wonder what to do though, two options:

If the user has a custom BG set (through the IDE option or through the plugin) and the option is checked, it will set the config value to this custom BG (or use the provided one if he clicks Restore), and unchecking the checkbox will remove the bg whatsoever
If the user has a custom BG set but the option is checked, it will replace the bg with whatever the user entered in the MT options. If it is unchecked though it will leave it as is.

What do you think?

Seconds options seems good. Just to clarify, in the case when user didn't check option in MT settings and set custom wallpaper (wall.png) through IDE settings wallpaper stays as wall.png with whatever opacity was set by the user through IDE settings. If, however, user does check option in MT settings, IDE settings are ignored completely.
That seems okay, but by default the option should be unchecked, so that users that already have set wallpapers through IDE won't suffer.

The thing is that most users don't know about this feature so this will look like this is something coming from the plugin. The best course of action of course would be that setting a custom BG through the IDE will also modify the material settings, but I can't do that as they don't provide an event listener for this.
Doing the second option means that I will need to store whatever value the user set while the option is off, and load this value when the option is off, and when it is on load the value the user put on the file chooser. But it may be harder to implement.
For the moment I've implemented the first option, so I will suggest to do so for the moment:

Turn off the option
Define a bg color through the IDE and save
Reopen the settings: your new wallpaper and opacity should be set instead of the wallpaper I provided.
Turn on the option and leave it like that.
Restart the IDE and see if the values are persisted.

I believe background image setting was a major feature at the time, JetBrains even posted about a thousand videos on YouTube on how to use it.
The appropriate thing for users that don't know about this feature, IMO, is advertising plugin feature through plugin changelog.

Ok I've changed the behavior a bit, so now if you disable the checkbox it will stop setting the background set in Material theme settings and you can use the IDE settings

Thanks!


Remove "phone disconnected" icon

In the simulator, there's a red icon indicating the phone is not connected. I'm not sure if it's related to the app config, HealthKit config or something else, but it doesn't show up for other apps.
Need to figure out the source of this, and if possible to remove.
Screenshot below.

I can't see the phone disconnected icon on my simulator as you can see below.

Instead I can see the icon on watch screen.


Poor recovery when enum constant with type arguments, dot

enum E {
  v<int>.;
}

or
enum E {
  v<int>;
}

or
enum E {
  v.;
}

Can we insert synthetic arguments () in these cases?
And make sure that ; is not lost.
I tried to do it myself, but eventually found TokenStreamRewriter and decided that this is too much for me.
This causes wrong completion in enum constants.

I don't think I understand what the bad thing about the current parsing is.
E.g.
enum E {
  v<int>.;
}

is parsed as
enum E {
  v<int>.*synthetic*;
}

which seems fine? (and doesn't appear to throw any semicolon away?)

You are right, the semicolon is not discarded, I was confused.
The main issue is that when an enum constant has type arguments, according to the grammar it also must have value arguments. Looking into the spec now, I don't see it saying this explicitly, although it used to do so. Maybe it was too obvious. But examples in Enum values: still show it.
So, could parser insert not only a synthetic identifier after ., but also synthetic ()?

Thank you, this works great!


Run MRI 2.3 on Travis CI

Currently We cannot specify the version as "2.3" since it does not work:
https://twitter.com/travisci/status/681909200591654913

Do you want to use this to open PR's everywhere?

Do you want to use this to open PR's everywhere?

Yeah

Yeah

Done

https://github.com/rspec/rspec-core/pull/2147
https://github.com/rspec/rspec-expectations/pull/882
https://github.com/rspec/rspec-mocks/pull/1048
https://github.com/rspec/rspec-rails/pull/1516
https://github.com/rspec/rspec-support/pull/261

Done

https://github.com/rspec/rspec-core/pull/2147
https://github.com/rspec/rspec-expectations/pull/882
https://github.com/rspec/rspec-mocks/pull/1048
https://github.com/rspec/rspec-rails/pull/1516
https://github.com/rspec/rspec-support/pull/261


 In this case the firstException will be null and the throw fails:
https://github.com/dropwizard/dropwizard/blob/master/dropwizard-auth/src/main/java/io/dropwizard/auth/chained/ChainedAuthFilter.java#L55
Is this expected behaviour? If we use auth filters must we set the securityContext or throw a WebApplicationException? Is this the same requirement for a single filter? How is this to work with @Auth(required=false)? There does not appear to be a test case for this scenario?
The old chainedAuthFactory did check for null:
https://github.com/dropwizard/dropwizard/blob/v0.8.4/dropwizard-auth/src/main/java/io/dropwizard/auth/ChainedAuthFactory.java#L104

After delving into it a little more it appears that this might be working as expected? @Auth does not support required any more. So to have optional injection of the principal is now not supported, in which case does this mean we must always have a final filter that will create a securityContext that must return a principal of the type expected (which must have some indication that it is not actually an authenticated principal)? This seems a little difficult to implement optionally protected resources now.

Per https://github.com/dropwizard/dropwizard/pull/1162, does it work if you add the @PermitAll annotation to the resource method?

No, it still fails with the NPE in the ChainedAuthFilter. If I do add the null check so it doesn't cause the NPE, it then fails further downstream when attempting to provide the principal to the @Auth annotation:
https://github.com/dropwizard/dropwizard/blob/master/dropwizard-auth/src/main/java/io/dropwizard/auth/AuthValueFactoryProvider.java#L67
The @PermitAll seems to still require a principal - and the docs imply that with @PermitAll. All authenticated users will have access to the method.
#1162 uses the PermitAllAuthorizer, it doesn't address the Authenticator and the requirement that a securityContext must be added. The authorizer is used on the principal gotten from the securityContext.
I'm running into the issue that if I have any chained auth filters one of them must provide a security context or throw an exception otherwise I get an NPE. This means I can't mix resources that use @Auth with ones that don't (regardless of required or not).

@ferdy-lw Could you please provide a small, minimal Dropwizard application to reproduce this issue?

After reading through the source and the comments I think the way it currently works is fine, and with a little rehash of my auth strategy I was able to use my (cookie auth) filter and respond correctly.
The filter must throw an exception or set the securityContext - this make sense with the understanding that auth filters are only used when a resource has a role annotation or @Auth; consequently, the filters must provide a security context or error, and this implies the responded error will be the first of the chained filters if they all fail.
While I like the new filtering, it makes for much simpler building authenticated (and authorized) principals, it does make it harder to have an optionally authenticated resource as you always have to provide a principal even with @PermitAll. If there are no credentials there really should be no principal.
Thanks for following up so quickly, the new auth filtering is a great enhancement.


NamedExec broken utf8 encoding where Exec succeeds

I'm attempting to batch upsert some data using NamedExec & named struct parameters but receiving the error:
pq: invalid byte sequence for encoding "UTF8": 0xc3
Now, we're using Golang here so all inputs to pq, I assume, should be UTF8 encoded by default. I'd say there is something wrong with the data I'm inputting (zero byte runes, invalid utf8 or whatever) but if I insert the same data using single operation Exec, it doesn't fail.
Succeeding example:
_, err := r.client.Exec(`
    INSERT INTO table(id, val1, val2, val3) VALUES ($1, $2, $3, $4)
    ON CONFLICT (lookup_id) DO UPDATE
    SET  val1 = $2, val2 = $3, val3 = $4
`, id, val1, val2, val3) // val3 contains latin chars
if err != nil {
    log.Println(a)
    return err
}

Failing example:
_, err := r.client.NamedExec(`
    INSERT INTO table(id, val1, val2, val3) VALUES (:id, :val1, :val2, :val3)
    ON CONFLICT (lookup_id) DO UPDATE
    SET  val1 = :val1, val2 = :val2, val3 = :val3
`, records) // records of type []value
if err != nil {
    log.Println(a)
 }

type value struct {
  Id string `db:"id"`
  Value1 string `db:"val1"`
  Value2 string `db:"val2"`
  Value3 string `db:"val3"` // contains latin chars
}

I'd expect both of these examples to succeed. Postgres database server encoding is UTF8 (as is client encoding as per the pq driver specification).

Exec does not actually work with the same file, I have added a step to the program alongside the NamedExec refactor that trims val3 to 50 characters. It seems like I'm breaking a two-char rune in half by doing that.


v120 tools needed for Windows hence superscript install fails

I am using Windows 10 with an x64 architecture and trying to install superscript. I never managed to install superscript since the last month. I know this issue is related to node-gyp and v120 wont work as I have Visual Studio 2015 on my end which I believe is v140. I have also been tracking your issue where you guys seem to work node-re2 Does that mean fixing node-re2 dependency will resolve the problems below because I plan to use superscript on a server environment and would certainly prefer not installing Visual Studio on the server. Thank you for your suggestions in advance
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.Cpp.Platform.targets(57,5): error MSB8020: The build tools for v120 (Platform Toolset = 'v120'
) cannot be found. To build using the v120 build tools, please install v120 build tools.  Alternatively, you may upgrade to the current Visual Studio tools by
selecting the Project menu or right-click the solution, and then selecting "Retarget solution". [C:\Program Files\nodejs\node_modules\superscript\node_modules\
re2\build\re2.vcxproj]

Fixed in v1.0.0 which will no longer require any build tools (or RE2).


Cannot access external terminal

The plugin works great, but there is one feature that I cannot seem to get to work.
CTRL-X focuses the internal command line, which is great. But "?" should show me the external terminal with all of the stdout values etc, but instead it redirects the focus to the internal terminal. I have no way (that I can tell) of accessing the external terminal.
Is it possible to access the external terminal?

That is a great question.  My gut tells me you'll have to remap the neovim bind, but I'll look at this.


doc: small improvements to docstrings for let and have tactics

@david-christiansen I did a little bit of work on the docstrings for have and let here. It would be good to have a standard for how a tactic docstring should be organized, and how I've imagined it is
Short high-level description of tactic

* syntax variant one
* syntax variant two

Other brief notes you should know about the tactic, like related tactics.

# Examples

some illuminating examples

# Limitations

explanations of what you shouldn't expect from this tactic

# See also

other things to look into

That's just a quick idea jotted down, and really I've got the Mathematica documentation style in mind, which is worth emulating.


🐛  Stop thrashing workload objects in the WEC, when max-num-wrapped is 1

Summary
This PR stops the thrashing of workload objects in a WEC (see #2634) IF the transport-controller's max-num-wrapped is 1. The trick is to make the name of the ManifestWork a function of its one and only workload object.
This PR is built on #2641, and I will rebase this one if that one merges first.
Preview at https://mikespreitzer.github.io/kcp-edge-mc/doc-no-thrash/direct/release-notes/#0260-alpha1
Related issue(s)
Hopefully this will fix #2634 but I want to wait for confirmation from @cwiklik before closing that Issue.

/cc @vMaroon
/cc @waltforme
/cc @nirrozenbaum
@cwiklik
@eaepstein

/lgtm

/approve


'Dotnet.exe publish' silently creates bad format for mis-matching architectures

When using dotnet.exe publish for specific runtimes, say win-x86, if using the 64 bit dotnet.exe, this runs without error, but when running the result executable, a BadImageFormatException is thrown. Same with target win-x64 from 32 bit dotnet.exe
It should be an error to create a runtime with the wrong 32 bit or 64 bit dotnet.exe, there should be an exception clearly stating that you need to run the dotnet.exe with the same architecture as the runtime you are targetting.
After two days of pain, I finally realized I had to fully qualify the path to dotnet.exe as I had both 32 bit and 64 bit sdk installed. So now for my 32 bit runtime targets, I use the 32 bit dotnet.exe, for the 64 bit targets, the 64 bit dotnet.exe. All run fine without errors.
Please add this as an error condition and save many, many people a lot of pain, headaches and frustration.
Example that fixes the problem in powershell:
& "c:/program files/dotnet/dotnet.exe" publish Project.csproj -f netcoreapp2.2 -o package/linux-x64 -c Release -r linux-x64
& "c:/program files (x86)/dotnet/dotnet.exe" publish Project.csproj -f netcoreapp2.2 -o package/win-x86 -c Release -r win-x86

@livarcocc @nguerrera does it belong to CLI or core-setup?

CLI would be a good starting point. We can move it to core-setup if the issue was in the production of the apphost.
cc @peterhuene

Issue moved to dotnet/cli #11564 via ZenHub

@nguerrera thanks for closing.  I didn't notice that the tool hadn't closed it 😞.


Check Jenkins; There are jobs failing consistently

Job failing
https://jenkins.bigcat.unimaas.nl/job/Metabolite ID Mapping Database/

The problem here turns out to be an upstream data error, which I just filed: https://github.com/ebi-chebi/ChEBI/issues/3591
cc @DeniseSl22

Fixed with https://github.com/bridgedb/create-bridgedb-metabolites/commit/018826407334873831d802ec95707d4d754d30e2


Santized charset used in files

The comments in the .cpp and .h files are shown as garbled text on machines using UTF-8 charset.
@Unparalleled-Calvin Can you fix them? I'd love to be able to read your comments. :)

I suppose that charset GBK which VS uses by default causes this problem. I will fix it in my next submission.


gce 'getting started' cleanup.

Addresses #9632 for GCE. Also partially addresses #9420, by giving some sanity-check kubectl commands on cluster startup.  Adds a TOC (LMK what you think of that) and expands on some of the sections.
If this looks good, can make similar mods to some of the other 'getting started' docs.
TJ, since #9632 was your bug, assigning to you, but feel free to unassign.

LGTM.  You might want to squash your commits before we merge.

squashed.


Anime preloading in video player reset.

Steps to reproduce
After opening an anime and watching it in the player, the player automatically preloads a certain part of the episode ahead of the current watching position.
Expected behavior
And this happens as it should.
Actual behavior
But after minimising and reopening the app, the preloaded amount gets reset and it again starts preloading ahead from the watch position. This results in tons of mobile data being wasted with each time i minimize the app while watching. Please fix this
Crash logs
No response
Aniyomi version
0.14.3-6145
Android version
Android 10
Device
Redmi 9 i
Other details
I am using animepahe extension
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

https://github.com/aniyomiorg/aniyomi/issues/1178

Its not working


Roll engine 6a1f093398c6..5f5713e33971 (5 commits)

git@github.com:flutter/engine.git/compare/6a1f093398c6...5f5713e33971
git log 6a1f093398c6..5f5713e33971 --no-merges --oneline
2019-11-08<EMAIL_ADDRESS>Roll src/third_party/skia 99b558b594a1..8c1e265f6f81 (1 commits) (flutter/engine#13751)
2019-11-08<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from H_5HL... to KRali... (flutter/engine#13750)
2019-11-08<EMAIL_ADDRESS>Roll src/third_party/skia 3fd426d19df3..99b558b594a1 (1 commits) (flutter/engine#13749)
2019-11-08<EMAIL_ADDRESS>Roll src/third_party/skia 76eaab6b8cef..3fd426d19df3 (1 commits) (flutter/engine#13746)
2019-11-08<EMAIL_ADDRESS>Create a new picture recorder even when the embedder supplied render target is recycled. (flutter/engine#13744)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Auto-roller completed checks. About to merge.


code tunnel doesn't work since update to VS Code 1.81.0

Describe the bug
code tunnel doesn't work anymore due to a missing binary in the VS Code package. I do not yet know whether it is an upstream issue or not.
Steps To Reproduce
Steps to reproduce the behavior:

NIXPKGS_ALLOW_UNFREE=1 nix shell --impure nixpkgs#vscode-fhs (FHS required for vscode-server to work properly, because it downloads arbitrary binaries)
code tunnel
Observe ENOENT error due to a missing file

Expected behavior
code tunnel runs successfully
Screenshots
n/a
Additional context
Bisection revealed 754c7b7c0261225b9581cb7464394e1b52c92410 as the commit introducing the bug.
Notify maintainers

@K900 as author of the commit revealed by bisection
@eadwu @Synthetica9 @maxeaubrey @bobby285271 @Enzime as maintainers

Huh. There is no code-tunnel anywhere in the official distribution.

Oh great it's just broken upstream: https://github.com/microsoft/vscode/issues/189383

Oh well. I thought this could be an upstream issue, and turns out it indeed was.

Fixed by #248438.


Gateway and VirtualService ordering should not matter

Describe the bug
{{ Succinctly describe the bug }}
Gateway needs to be created VirtualService in order for the service to respond back. Otherwise the service endpoint gives curl: (52) Empty reply from server.
Expected behavior
Expected the service to return a valid response
Steps to reproduce the bug
Use the following config file for the service to return an error:
apiVersion: networking.istio.io/v1alpha3
kind: DestinationRule
metadata:
  name: greeting
spec:
  host: greeting
  subsets:
  - name: greeting-hello
    labels:
      greeting: hello
  - name: greeting-howdy
    labels:
      greeting: howdy
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: greeting
spec:
  gateways:
    - greeting # namespace of the Gateway
  hosts:
    - greeting.com
  http:
  - route:
    - destination:
        host: greeting
        subset: greeting-hello
        port:
          number: 80
      weight: 50
    - destination:
        host: greeting
        subset: greeting-howdy
        port:
          number: 80
      weight: 50
---
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: greeting
spec:
  selector:
    istio: ingressgateway # use Istio default gateway implementation
  servers:
  - port:
      number: 80
      name: http
      protocol: HTTP
    hosts:
    - "*"

If Gateway is ordered as the first item in this file then the service returns expected response.
Version
istioctl version
Version: 1.0.5
GitRevision: c1707e45e71c75d74bf3a5dec8c7086f32f32fad
User: root@6f6ea1061f2b
Hub: docker.io/istio
GolangVersion: go1.10.4
BuildStatus: Clean

kubectl version
Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.1", GitCommit:"eec55b9ba98609a46fee712359c7b5b365bdd920", GitTreeState:"clean", BuildDate:"2018-12-13T19:44:10Z", GoVersion:"go1.11.2", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"11+", GitVersion:"v1.11.5-eks-6bad6d", GitCommit:"6bad6d9c768dc0864dab48a11653aa53b5a47043", GitTreeState:"clean", BuildDate:"2018-12-06T23:13:14Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"linux/amd64"}

Installation
https://aws.amazon.com/blogs/opensource/getting-started-istio-eks/
Environment
AWS
Cluster state
{{ If you're running on Kubernetes, consider following the
instructions
to generate "istio-dump.tar.gz", then attach it here by dragging and dropping
the file onto this issue. }}
Script did not work
Thanks @ZackButcher for helping debug and encouraging to submit the issue.

We reliably saw Pilot fail to configure the ingress gateway when these resources were submitted in the order VirtualService-then-Gateway (in rapid succession - kubectl apply -f file-with-virtualservice-then-gateway.yaml), but works as expected in the other order.
This seems to point to a race condition processing the config and generating xDS for Envoy. I would've expected the error in xDS to be resolved by Pilot's periodic config re-pushes, but the misconfiguration persisted.

Any update on this @arun-gupta ?

Any update on this @arun-gupta ?


MSFT_xExchAutoMountPoint: Fix PSSA Issues

PowerShell Script Analyzer is bringing up a few issues for the MSFT_xExchAutoMountPoint resource.
No errors, but there are a few warning/informational issues that should be either fixed or excluded.
This is the result of running Invoke-ScriptAnalyzer:

(Please disregard issues brought up by the PSDSCDscExamplesPresent and PSDSCDscTestsPresent rules for now.)

This resource requires a bigger change.
These global variables need to be changed to Get- methods both here and in the helper file. There can be script-scope variables in the helper, just no globals.
The only approved global variable so far is DSCMachineStatus.
On a different note, you can now also disregard the PsUseShouldProccessForStateChangingFunctions rule.

Consolidating into https://github.com/PowerShell/xExchange/issues/149


Consider removing all *.ts and *.map files from node_modules

We're shipping like 45 MB of *.ts and *.map files, these likely aren't needed during production...can we delete them?

We have a task that is supposed to be removing all *.js.map files, but it seems to have stopped working. Assuming we can get this working again, it should be simple to add *.d.ts files to the exclude list.


hashCode for doubles should be better.

This issue was originally filed by @mdakin

What steps will reproduce the problem?

Run http://try.dartlang.org/s/P6E_
It seems hashCode for double numbers is only the integer part of the number.so hashCode of 0.1 and 0.9 are both 0.

What is the expected output? What do you see instead?
hashCode for different double numbers should be different.

This is still the case.
main() {
  print(0.2345.hashCode);  // 0
  print(1.9999.hashCode);  // 1
  print(1.00000.hashCode);  // 1
  print(123.456.hashCode);  // 123
}

This seems like it might cause problems in Flutter.
Many of our objects have hashCode getters that derive their hashCode from the hashCodes of their properties. Many of our objects have double properties. Many of them in particular have a double in the range 0.0..1.0, with no other changes.
For example, if you use FlutterLogoDecoration.lerp to fade in a logo, you'll get back a series of objects that are identical except for their opacity, which will vary from 0.0 to 1.0. Say you want to fade something in over 10 seconds. If you stick all of these objects in a Map for efficiency, you'll get hash collisions on all values except the last one, so you'll have one bucket with 599 objects and one bucket with 1 object.

Let me take a stab at this!

Started working on this: https://dart-review.googlesource.com/c/sdk/+/15140.
main() {
  print(0.2345.hashCode);  //<PHONE_NUMBER>615499378
  print(1.9999.hashCode);  //<PHONE_NUMBER>917960216
  print(1.00000.hashCode);  // 1
  print(123.456.hashCode);  //<PHONE_NUMBER>6626392
}

I am so curious to see what impact this has on our benchmarks!

Fixed in 1db8615e29cf1e62854d041b805c6d3c43c2225c.


Dan new rails 5

I'll need to fix the merge conflicts...

Current coverage is 99.04% (diff: 100%)

Merging #569 into master will decrease coverage by <.01%

@@             master       #569   diff @@
==========================================
  Files            39         39
  Lines          1045       1043     -2
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           1035       1033     -2
  Misses           10         10
  Partials          0          0

Powered by Codecov. Last update caeb59d...bcb10d4


Replace "sample of the type of information ... present in a Span" image with a text

At the top of section Spans within Observability Primer we use the following image to show a sample of a span:

I think this picture has a few issues:

it is hard to read & for someone with a screenreader it is entirely inaccessible.
it looks like a vendor specific UI screenshot
it provides client side telemetry attributes, which are not the most common ones.

Especially (1) makes me think, that we should replace that image with a table showing keys & values of a common example (server side http request?)

I would like to work on this issue and will submit a draft pr for more inputs.

thanks @Gaurang-Patel , assigned it to you!


Video Recording Duration always stopped below 2 minutes

Hi All,
I've tried to invoke video recording by call http://myseleniumgridextrasurlandport/video?action=start&session=videoName and wait untill my test is finished, and call video?action=stop&session=videoName.
There's a video file in my hdd, but when I play it, it's only record below 2 minutes duration while my test is run for 9 minutes.

@dirathea I think the default video timeout is set to 2 minutes. This issue , #172 is related. I think I might have an idea about that other defect. After that one is fixed, you can set the timeout in the config file.

@dirathea This should be fixed in the latest version 1.12.2 . Can you verify and post back?


Add @flow mention in module

@flow is mandatory in export.js files otherwise flow just do not report errors.

It's implied that // @flow should follow each file processed by flow, this is mentioned in Getting Started section of README.md


Update Footer Component

Need to work on having real data in the footer component. Such as contact information.  Provide user information on the purpose of the website and the expectations/limitations of adding a name to the database?  OR...not have a footer.

I will start working on this component update.

basic update complete


new features in json file

@martinholmer recently augmented the JSON reform file to include Growth, Behavior, and Consumption parameters in https://github.com/open-source-economics/Tax-Calculator/pull/1083
These changes break backwards compatibility for TB and TC, and some updates to TB are required before we can deploy any version of TC greater than 0.7.2 to TB.
I described the core issue in https://github.com/open-source-economics/Tax-Calculator/pull/1083:

it won't be trivial to adopt on TaxBrain because of how TaxBrain guides users to static modeling first and then to dynamic modeling. Right now, partial eq and other dynamic runs come after the static results; with the new file upload feature, users will be able to jump directly to a partial equilibrium run without first generating static results. I don't think it will be hard to deal with the user interface and backend changes that will need to result from that, but it won't be trivial either.

To be more specific, the problem is that the new JSON format allows users to upload a file that will produce a partial equilibrium result rather than to a static result. The resulting page shouldn't have the same functionality as a static results page, and it also probably can't have the same functionality as the partial equilibrium result page.
The reason that the page shouldn't have the same functionality as the static results page is that it won't make sense for the user to continue on to dynamic modeling after having specified behavioral parameters.
The reason that the page probably can't have the same functionality as the partial equilibrium result page is that our existing PE page allows the user to return to the static results, but no static results were generated with the json file.
I see two options for when the user includes nonzero behavioral parameters:

Have the page take the user to what looks like the static results page, but when the user clicks "Link to Dynamic Simulations" a pop up will say "Your simulation is already a partial equilibrium dynamic simulation. Please resubmit without behavioral parameters if you would like to link to other dynamic modeling options."

Have the page look like the partial equilibrium results page and either:
a) remove the "The microsimulation upon which this dynamic simulation was based can be found here"  or,
b) (fancier version) leave the "The microsimulation upon which this dynamic simulation was based can be found here" and when the user clicks "here", run that static calculation and generate the static results on the fly.

@talumbau, it would be helpful to know which of these is easier to implement, and if there will be any other difficulties on the back end with incorporating the new json features from https://github.com/open-source-economics/Tax-Calculator/pull/1083

@MattHJensen said:

I see two options for when the user [uploads a JSON reform file that] includes nonzero behavioral parameters:
(1) Have the page take the user to what looks like the static results page, but when the user clicks "Link to Dynamic Simulations" a pop up will say "Your simulation is already a partial equilibrium dynamic simulation. Please resubmit without behavioral parameters if you would like to link to other dynamic modeling options."

I don't know anything about the easy or difficulty of different kinds of changes to TaxBrain, but it seems to me that this first option is a very sensible approach.  There is no need for different output options, just a need to block the current path to the "dynamic" analysis options.
That's my two cents on this.
@MattHJensen @talumbau @feenberg @brendancol @Amy-Xu @GoFroggyRun @andersonfrailey

Thanks @martinholmer! That makes sense to me too.

Added this to milestone b1 as it is blocking any new TC releases.

I actually think 1 is probably the easiest, due to the fact that it maintains the "file based reform generates static results page" workflow, which is desirable. I can take this on.

Sounds good. Thanks @talumbau


Update CodeEditor.php

Remove message 'CodeEditor module bootstrapped'.
This message adds a lot of junk to the logs
Description
Related issues

So it should only be adding this log message when devMode is enabled... or unless you have customized the production logging in some manner.
I think for that reason it probably should stay in, because it's useful to see in some developmental contexts, and doesn't appear in staging or production contexts (where devMode should be disabled).
Thoughts?


Replace generic prebuilt bindings with target specific bindings

This commit replaces the generic gdal bindings with architecture specific ones. This is necessary as bindgen 0.71 introduced a feature that essentially turned the size assertions into a compile time check. This pointed to several potential mismatches between the bindings and the actual type definitions.
This commit now introduces different bindings for 32 and 64 bit platforms. Additionally it differentiates between windows and linux/macos bindings. For any unsupported platform a build error is generated that the built_time bindgen feature needs to be used there.
Finally it adds documentation on how to generate these bindings.

[x] I agree to follow the project's code of conduct.
[ ] I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Thanks, this is great! I meant to do it, but you were faster :-).


when I write in the input,it unblure every  time

can you provide a working sample in codepen or codesandbox to show what you mean?

I had this problem, but I have to create the enhanced component dynamically. The solution using hooks looks like this:
const DraggableForm = React.useMemo(()=> SortableElement(viewFor(type, "form")), [type])

My components are not created dynamically, so created outside of the render method. I did try @gunn's solution by moving it into the render function with the hook but that does not solve the issue. My keys are unique so that is also not what is causing the rerender. Any help would be appreciated.
Codesandbox: https://codesandbox.io/s/agitated-almeida-jvp6q?fontsize=14

PS. I used immer to handle the immutable state changes but it could just as well be done with a standard Array.slice and destructuring of array or whatever other method to change the state. That is not the source of the problem. It seems to be creating a new div when options change, even if keys stay the same


Debugging make launch

Originated in #520
What is the output of:
kubectl logs pachd-smta1

kubectl logs pachd-smta1
**No output**

Ok how about:
kubectl logs pachd-smta1 --previous
And I'd also like to see kubectl get all again to make sure we're still seeing an error of some kind w that pod

Closing for staleness. Please reopen if there's new information.


We should document main.yaml launch config (and link to docs in the default one)

It's not at all clear to me what these options do.  Specifically debug vs. checked.  @devoncarew

or just put comments in the file

Atom is no longer our recommended editor.


Support make protos in development docker image

Cherry-pick Docker.dev changes from 7e041843258c0af48d3ebdc21c40ce87e86c37be in PR #981.

Coverage remained the same at 32.86% when pulling 81aef9a390d363e12729f89eeedea810fb25820d on TS_docker_dev_protoc into b89e3a5bd36f32d84f59d68d981525fe163eac26 on master.


Relax IP/Domain Validation

Summary
When adding a new connection, the validation on the "IP address or domain" field is too restrictive. For example, my Pi-Hole is reachable via a single-word hostname (e.g. http://pihole). This value, though correct, is rejected by the field validation.
Suggested Change
Relax the validation on the "IP address or domain" field when adding a new connection to allow single-word hostnames.

Hi. Please check if this works for you.
app-release.apk.zip

Changed on v3.9.0.


Error 500 when browsing Kafka datasets - from GraphQLController

We have ingested some Kafka topics using the Kafka source plugin

Showing search results of Kafka datasets works.
Viewing an individual Kafka dataset is works.
Attempting to browse Kafaka datasets results in an error 500 in the browser.

No schema information was ingested with the topics, so the only metadata associated with these Kafka datasets are their topic names.
To Reproduce
Steps to reproduce the behaviour.

Select Kafka datasets from the home page of DataHub - (no error) link for reference
View an individual Kafka dataset - (no error) link for reference
Click on the Datasets->PROD->kafka link from the breadcrumbs to go to https://datahub.wikimedia.org/browse/dataset/prod/kafka
See error 500 bar across the top of the screen

Expected behavior
No error and a list of Kafka datasets again
Screenshots

Server environment

DataHub version: 0.8.34
Graph database: Opensearch 1.2.4
Schema registry: Karapace (for licensing reasons)
RBDMS: MariaDB 10.4

Additional context
The following error messages are displayed in the GMS log at the time:
09:11:44.373 [Thread-2769] ERROR c.l.datahub.graphql.GmsGraphQLEngine:1127 - Failed to load Entities of type: Dataset, keys: [urn:li:dataset:(urn:li:dataPlatform:kafka,-L,PROD), urn:li:dataset:(urn:li:dataPlatform:kafka,-l,PROD), urn:li:dataset:(urn:li:dataPlatform:kafka,04,PROD), urn:li:dataset:(urn:li:dataPlatform:kafka,ContentTranslationAbuseFilter,PROD), urn:li:dataset:(urn:li:dataPlatform:kafka,DataHubUsageEvent_v1,PROD), urn:li:dataset:(urn:li:dataPlatform:kafka,EditorJourney,PROD), urn:li:dataset:(urn:li:dataPlatform:kafka,FailedMetadataChangeEvent_v4,PROD), urn:li:dataset:(urn:li:dataPlatform:kafka,FailedMetadataChangeProposal_v1,PROD), urn:li:dataset:(urn:li:dataPlatform:kafka,KaiOSAppFeedback,PROD), urn:li:dataset:(urn:li:dataPlatform:kafka,MetadataAuditEvent_v4,PROD)] Failed to batch load Datasets
09:11:44.374 [Thread-2769] ERROR c.l.d.g.e.DataHubDataFetcherExceptionHandler:21 - Failed to execute DataFetcher
java.util.concurrent.CompletionException: java.lang.RuntimeException: Failed to retrieve entities of type Dataset
        at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:273)
        at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:280)
        at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1606)
        at java.lang.Thread.run(Thread.java:750)
Caused by: java.lang.RuntimeException: Failed to retrieve entities of type Dataset
        at com.linkedin.datahub.graphql.GmsGraphQLEngine.lambda$null$136(GmsGraphQLEngine.java:1128)
        at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1604)
        ... 1 common frames omitted
Caused by: java.lang.RuntimeException: Failed to batch load Datasets
        at com.linkedin.datahub.graphql.types.dataset.DatasetType.batchLoad(DatasetType.java:135)
        at com.linkedin.datahub.graphql.GmsGraphQLEngine.lambda$null$136(GmsGraphQLEngine.java:1125)
        ... 2 common frames omitted
Caused by: java.lang.IllegalStateException: Duplicate key com.linkedin.metadata.entity.ebean.EbeanAspectV2@d416e85f
        at java.util.stream.Collectors.lambda$throwingMerger$0(Collectors.java:133)
        at java.util.HashMap.merge(HashMap.java:1255)
        at java.util.stream.Collectors.lambda$toMap$58(Collectors.java:1320)
        at java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169)
        at java.util.ArrayList$Itr.forEachRemaining(ArrayList.java:901)
        at java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
        at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
        at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
        at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
        at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
        at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:566)
        at com.linkedin.metadata.entity.ebean.EbeanAspectDao.batchGet(EbeanAspectDao.java:228)
        at com.linkedin.metadata.entity.ebean.EbeanEntityService.getEnvelopedAspects(EbeanEntityService.java:715)
        at com.linkedin.metadata.entity.ebean.EbeanEntityService.getCorrespondingAspects(EbeanEntityService.java:247)
        at com.linkedin.metadata.entity.ebean.EbeanEntityService.getLatestEnvelopedAspects(EbeanEntityService.java:207)
        at com.linkedin.metadata.entity.EntityService.getEntitiesV2(EntityService.java:180)
        at com.linkedin.entity.client.JavaEntityClient.batchGetV2(JavaEntityClient.java:99)
        at com.linkedin.datahub.graphql.types.dataset.DatasetType.batchLoad(DatasetType.java:119)

Apologies, this error is a single long line.
09:11:44.375 [Thread-2765] ERROR c.datahub.graphql.GraphQLController:93 - Errors while executing graphQL query: "query getBrowseResults($input: BrowseInput!) {\n  browse(input: $input) {\n    entities {\n      urn\n      type\n      ... on Dataset {\n        name\n        origin\n        properties {\n          name\n          description\n          __typename\n        }\n        editableProperties {\n          description\n          __typename\n        }\n        platform {\n          ...platformFields\n          __typename\n        }\n        ownership {\n          ...ownershipFields\n          __typename\n        }\n        globalTags {\n          ...globalTagsFields\n          __typename\n        }\n        glossaryTerms {\n          ...glossaryTerms\n          __typename\n        }\n        subTypes {\n          typeNames\n          __typename\n        }\n        domain {\n          ...entityDomain\n          __typename\n        }\n        __typename\n      }\n      ... on Dashboard {\n        urn\n        type\n        tool\n        dashboardId\n        properties {\n          name\n          description\n          externalUrl\n          access\n          lastModified {\n            time\n            __typename\n          }\n          __typename\n        }\n        editableProperties {\n          description\n          __typename\n        }\n        ownership {\n          ...ownershipFields\n          __typename\n        }\n        globalTags {\n          ...globalTagsFields\n          __typename\n        }\n        glossaryTerms {\n          ...glossaryTerms\n          __typename\n        }\n        platform {\n          ...platformFields\n          __typename\n        }\n        domain {\n          ...entityDomain\n          __typename\n        }\n        __typename\n      }\n      ... on GlossaryTerm {\n        ownership {\n          ...ownershipFields\n          __typename\n        }\n        properties {\n          name\n          description\n          definition\n          termSource\n          sourceRef\n          sourceUrl\n          customProperties {\n            key\n            value\n            __typename\n          }\n          __typename\n        }\n        __typename\n      }\n      ... on Chart {\n        urn\n        type\n        tool\n        chartId\n        properties {\n          name\n          description\n          externalUrl\n          type\n          access\n          lastModified {\n            time\n            __typename\n          }\n          __typename\n        }\n        editableProperties {\n          description\n          __typename\n        }\n        ownership {\n          ...ownershipFields\n          __typename\n        }\n        globalTags {\n          ...globalTagsFields\n          __typename\n        }\n        glossaryTerms {\n          ...glossaryTerms\n          __typename\n        }\n        platform {\n          ...platformFields\n          __typename\n        }\n        domain {\n          ...entityDomain\n          __typename\n        }\n        __typename\n      }\n      ... on DataFlow {\n        urn\n        type\n        orchestrator\n        flowId\n        cluster\n        properties {\n          name\n          description\n          project\n          __typename\n        }\n        editableProperties {\n          description\n          __typename\n        }\n        ownership {\n          ...ownershipFields\n          __typename\n        }\n        globalTags {\n          ...globalTagsFields\n          __typename\n        }\n        glossaryTerms {\n          ...glossaryTerms\n          __typename\n        }\n        platform {\n          ...platformFields\n          __typename\n        }\n        domain {\n          ...entityDomain\n          __typename\n        }\n        __typename\n      }\n      ... on MLFeatureTable {\n        urn\n        type\n        name\n        description\n        featureTableProperties {\n
description\n          mlFeatures {\n            urn\n            __typename\n          }\n          mlPrimaryKeys {\n            urn\n            __typename\n          }\n          __typename\n        }\n        ownership {\n          ...ownershipFields\n          __typename\n        }\n        platform {\n          ...platformFields\n          __typename\n        }\n        __typename\n      }\n      ... on MLModel {\n        name\n        origin\n        description\n        ownership {\n          ...ownershipFields\n          __typename\n        }\n        globalTags {\n          ...globalTagsFields\n          __typename\n        }\n        platform {\n          ...platformFields\n          __typename\n        }\n        __typename\n      }\n      ... on MLModelGroup {\n        name\n        origin\n        description\n        ownership {\n          ...ownershipFields\n          __typename\n        }\n        platform {\n          ...platformFields\n          __typename\n        }\n        __typename\n      }\n      __typename\n    }\n    groups {\n      name\n      count\n      __typename\n    }\n    start\n    count\n    total\n    metadata {\n      path\n      totalNumEntities\n      __typename\n    }\n    __typename\n  }\n}\n\nfragment platformFields on DataPlatform {\n  urn\n  type\n  name\n  properties {\n    type\n    displayName\n    datasetNameDelimiter\n    logoUrl\n    __typename\n  }\n  displayName\n  info {\n    type\n    displayName\n    datasetNameDelimiter\n    logoUrl\n    __typename\n  }\n  __typename\n}\n\nfragment ownershipFields on Ownership {\n  owners {\n    owner {\n      ... on CorpUser {\n        urn\n        type\n        username\n        info {\n          active\n          displayName\n          title\n          email\n          firstName\n          lastName\n          fullName\n          __typename\n        }\n        properties {\n          active\n          displayName\n          title\n          email\n          firstName\n          lastName\n          fullName\n          __typename\n        }\n        editableProperties {\n          displayName\n          title\n          pictureLink\n          email\n          __typename\n        }\n        __typename\n      }\n      ... on CorpGroup {\n        urn\n        type\n        name\n        properties {\n          displayName\n          email\n          __typename\n        }\n        info {\n          displayName\n          email\n          admins {\n            urn\n            username\n            info {\n              active\n              displayName\n              title\n              email\n              firstName\n              lastName\n              fullName\n              __typename\n            }\n            editableInfo {\n              pictureLink\n              teams\n              skills\n              __typename\n            }\n            __typename\n          }\n          members {\n            urn\n            username\n            info {\n              active\n              displayName\n              title\n              email\n              firstName\n              lastName\n              fullName\n              __typename\n            }\n            editableInfo {\n              pictureLink\n              teams\n              skills\n              __typename\n            }\n            __typename\n          }\n          groups\n          __typename\n        }\n        __typename\n      }\n      __typename\n    }\n    type\n    __typename\n  }\n  lastModified {\n    time\n    __typename\n  }\n  __typename\n}\n\nfragment globalTagsFields on GlobalTags {\n  tags {\n    tag {\n      urn\n      name\n      description\n      properties {\n        colorHex\n        __typename\n      }\n      __typename\n    }\n    __typename\n  }\n  __typename\n}\n\nfragment glossaryTerms on GlossaryTerms {\n  terms {\n    term {\n      urn\n      name\n      properties {\n        name\n        __typename\n      }\n      __typename\n    }\n    __typename\n  }\n  __typename\n}\n\nfragment entityDomain on Domain {\n  urn\n  properties {\n    name\n    __typename\n  }\n  __typename\n}\n", result: {errors=[{message=An unknown error occurred., locations=[{line=3, column=5}], path=[browse, entities], extensions={code=500, type=SERVER_ERROR, classification=DataFetchingException}}], data={browse=null}}, errors: [DataHubGraphQLError{path=[browse, entities], code=SERVER_ERROR, locations=[SourceLocation{line=3, column=5}]}]

I encountered error 500 previously, what i did was to rollback and ingest one by one to see which dataset was causing the fetching error. The last time it was failing was because one of the dataset tags was not a valid tag in the system (something about capitalcase letters in the tag) but it was resolved in newer versions.

Thanks @xiphl - that's a great suggestion. We haven't got any tags for any of these datasets, but it's possible that the names is invalid. The only one which seems unusual at the moment is a topic named -l which might be causing the error. I'll try deleting that one.
I've already tried deleting them in bulk and redoing the ingestion, but I'll try it again, perhaps in smaller batches.

Well that's interesting. It looks like it might be a case sensitivty issue, and or an issue regarding duplication:
When listing topics I can see that we have a few oddly named topics, including the following two.

-l
-L

I tried deleting these specific urns by hand, but got a 500 error for both of these:
datahub delete --urn 'urn:li:dataPlatform:kafka,-L' --env PROD
datahub delete --urn 'urn:li:dataPlatform:kafka,-l' --env PROD

I then did a bulk delete of everything using the kafka platform:
datahub delete --env PROD --entity_type dataset --platform kafka --hard
...followed by a new ingestion with a filter applied. The source in the recipe is as follows:
source:
  type: "kafka"
  config:
    connection:
      bootstrap: "kafka-jumbo1001.eqiad.wmnet:9092"
      schema_registry_url: http://karapace1001.eqiad.wmnet:8081
    topic_patterns:
      deny:
        - "^-.*"

This was intended to filter out anything starting with a hyphen. Indeed the ingestion run claims to have filtered out these two topics:

Now the filter_platform view correctly omits the dataset:

The browse view returns a 200 now (instead of a 500) but it still shows an entry for the -L dataset.

I think that we can close this now as it's no longer affectng us. It was definitely something related to case sensitivity and duplicates though.


Parametrise instance type

Remove spot price

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Have you signed the CLA already but the status is still pending? Recheck it.


Setup GitHub automations

The process for a pull request getting added should be:

Compile TypeScript
Run unit test suite
Check code quality and code style
Manual review of the PR
Accept and merge the PR to master
Repo uploads to firebase automatically

I have put a nodejs automation in.
But it is throwing an error every run. For some reason it is looking in the wrong folder for package.json

The issue of running tests from the wrong directory is fixed.
The tests are now running as expected, apart from mocha is throwing an error when called

Okay, Nice.


Support JupyterLab 3

JupyterLab 3 is out. It's great if this plugin can be updated to be compatible with JupyterLab 3.

I couldn't install the extension using pip.


Replace x11 CDT deps with xorg- packages

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I tried for a little while to get this compiling on osx-arm64 with the latest meson, but I haven't been able to make it work yet. So that'll have to wait for the future, for the sake of finishing the xorg package transition.

The implementation here is looking good.
For background, I generally heard two reasons for using X11 via CDT rather than the xorg- packages. These may be discussed in more detail in my ancient (but still open!) PR conda-forge/cfep#7.

One reason was to maintain compatibility with the Anaconda recipes.
The other reason was concerns about interfaces with system libraries farther down the stack, namely the OpenGL layer. The worry was that maybe custom conda-forge X11 libraries would be stuck using software GL instead of the best, potentially vendor-specific, library for the host machine.

This discussion was happening all before the CDT concept even was defined. I don't know if there are well-defined GL CDTs, but if so, that might obviate the second issue. As for the first issue, I feel like I haven't heard the general issue of recipe compatibility mentioned recently in any context ... I don't have a good sense for exactly how the topic has shaken out. It's worth chasing down for an important platform library, but there's also only so much we can do without external input.

* The other reason was concerns about interfaces with system libraries farther down the stack, namely the OpenGL layer. The worry was that maybe custom conda-forge X11 libraries would be stuck using software GL instead of the best, potentially vendor-specific, library for the host machine.

This discussion was happening all before the CDT concept even was defined. I don't know if there are well-defined GL CDTs, but if so, that might obviate the second issue.

I do think that if there were an issue here, it would have already come up. There are GL CDTs, and it is (still) what epoxy uses to connect the GTK stack to OpenGL. From the other side, this package on conda-forge has effectively been running with the xorg-libx11 dependency and friends the whole time, because they are always installed in the environment by cairo. So even though we have been building with CDTs, we've been running with conda-forge's xorg. And so far nobody has complained (or maybe even noticed). Anyway, as far as I understand it, users have always and will continue to be able to run the stack with hardware GL support.
Still, broader discussion around these topics would be good so we don't catch conda-forge core unawares. I guess I'll go ping https://github.com/conda-forge/cfep/pull/7, since our own bug https://github.com/conda-forge/gtk3-feedstock/issues/7 doesn't have nearly as much visibility.

Thanks for working through this. My overall feeling is similar: I'm not aware of any actual complaints about GL issues or the like, so I'm inclined to say it's fine. But the worry is worth taking seriously, and it's also good to go the extra mile to work well with Anaconda.com. Unfortunately I haven't had the bandwidth to pursue the topic for a long time (i.e. multiple years) but I'd really love to converge on a solid policy for how to approach X11 — I believe that it's the most significant difference between the conda-forge and defaults frameworks.

@conda-forge/core Any comments on this proposal? I'm generally in favor but am not up to speed on where things are at with the broader policy questions.

I just had this discussion with @isuruf during a core meeting.
He feels strongly that the only concern we should have with the usage of CDTs is when they hamper a critical feature (like the usage of OpenGL).
I feel that we should strive for compatibility with Anaconda.org, but I do not think it is worthwhile at this moment to sacrifice the usage of in-built x11 packages.
Ultimately, this difference is "pretty easy to spot" in the sense that I don't think it requires any changes within the build.sh file itself. The build system typically find X11 from either the CDT, or the host dependencies with little intervention (in my experience).
xref: https://github.com/conda-forge/qt-main-feedstock/pull/114

I also meant to reference the meeting minutes https://github.com/conda-forge/conda-forge.github.io/blob/main/src/orga/minutes/2023-02-08.md


reference management inside chapters folder

I have a question regarding references. So, when I add references inside .qmd files inside the Chapters folder, a references.bib file is created inside the Chapters folder. The problem is that this .bib file is not recognized by _quarto.yml. I am wondering if you have encountered this before and if you have any ideas to solve it.
Thanks

I recommend exporting your references from your reference manager (e.g. I use Zotero) to one references.bib file in the top-level directory of your quarto project, and this single bib file is specified in the _quarto.yml file https://github.com/kelly-sovacool/rackham/blob/3d9dd264205e7c32001d89a5916a7c0ff571628b/_quarto.yml#L58


Add Start - End DateTime range Observer configuration setting

Add the ability to specify Start - End DateTime range configuration setting to enable only running an observer when the current time falls within the specified range...

Makes more sense to just implement RunInterval support to limit complexity for end users. So, that's what will ship.
--Charles...

Capability added in latest merge (and Release)...


Add removePoolLiquidity RPC

What kind of PR is this?:

/kind feature
What this PR does / why we need it:
Implemented type for RPC: #48
poolpair.removePoolLiquidity

What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Implemented type for RPC: #48
poolpair.removePoolLiquidity

that's a standardize requirement, we need follow the pull_request template as usual
What kind of PR is this?:

/kind feature
What this PR does / why we need it:

Added resignMasternode rpc
Which issue(s) does this PR fixes?:

Fixes part of #48
Additional comments?:


Extract RecordFilter Mixin into compat

Related to https://github.com/fluent/fluentd/wiki/Changes-proposed-for-v0.14.x#misc-development-tasks.

Good change :)

@cosmo0920 Could you move some others in lib/fluent/mixin into compat?
I wrote that task description very shortly, but it includes these in fact :P

@tagomoris OK, I'll try it tomorrow.

Umm, compat module migration needed modules are HandleTagNameMixin and SetTimeKeyMixin?
If other modules also should migrate from mixin.rb, please let me know.


Revwalk panic with shallow clones

Hello, I don't know if this is a git2-rs issue, an upstream problem or if I am misusing the crate but when using revwalk on a
shallow clone the last commit is shifted by one.
  See https://github.com/libgit2/libgit2/issues/3058

I see, I guess we can close this then. Thank you for the quick response.

I was taking a look at this option in the Rust documentation. Following the link in this issue I found that shallow support was landed on libgit2 3 weeks ago 😄. https://github.com/libgit2/libgit2/issues/3058


[Enhance] Update reload_dataloaders_every_epoch to reload_dataloaders_every_n_epoch

🚀 Feature
reload_dataloaders_every_epoch reloads dataloader every epoch. We can change it to reload dataloaders after every n epochs. It will accept both bool and int values. True will be treated as 1 and False will be treated as 0 (means no reload).
Motivation
Recently a request came up on slack regarding reloading dataloaders after some epochs. Also since we have enhanced fast_dev_run like this, we can update this too.
Alternatives
Can be done manually by calling the method to reload dataloaders with a simple conditional statement by setting reload_dataloaders_every_epoch=False, but we can let this attribute accept an integer to avoid manual work.

cc @PyTorchLightning/core-contributors is this a good feature to have??


Change from: email to<EMAIL_ADDRESS>for automated emails

@jszwedko is it as simple as just changing this:
class ApplicationMailer < ActionMailer::Base
  default from<EMAIL_ADDRESS>  layout 'mailer'
end

in application_mailer.rb
I wasn't sure if there was something else that needed to happen to make this change.

@jasonlally yeah, that should be it -- I don't think we are doing anything fancier like publishing a SPF record for the domain.

It looks like we are publishing one for sfwater.org though:
➜  adopt-a-drain git:(production) nslookup -type=txt sfwater.org
Server:		<IP_ADDRESS>
Address:	<IP_ADDRESS>#53

Non-authoritative answer:
sfwater.org	text = "v=spf1 a mx ~all"

We may want to add sendgrid.net there (see https://sendgrid.com/docs/Glossary/spf.html) to reduce the probability it'll be gray listed or marked as spam.

Closed by #95


Regtest bech32 address support

In the spirit of #84, add support for regtest bech32 addresses that start with "bcrt1".
Also added a test that I had added locally when updating rust-bitcoin with my rust-bech32-bitcoin/regtest library.
Please consider this PR, thanks!

We really need to move to a https://github.com/rust-bitcoin/bitcoin-constants lib so that we dont have to keep doing network-tag-enum conversion.

Not for something as simple as this, no, but it really needs to happen.
On July 27, 2018 12:26:02 AM UTC, Franck Royer<EMAIL_ADDRESS>wrote:

@TheBlueMatt happy to get this integrated as is or you consider the
refactoring to bitcoin-constants as blocking?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/rust-bitcoin/rust-bitcoin/pull/110#issuecomment-408274755

@TheBlueMatt can you advise how I can get this merged? Thanks!


Deleting user diagnostic data with Windows diagnostic data processor configuration

When the Windows diagnostic data processor configuration is enabled, users can’t initiate deletion requests for their own data from Windows Settings.  Instead, it’s stated in the article that administrators can do so “by invoking a delete request from the admin portal”.
I’ve looked through both the M365 admin portal and the Azure portal and didn’t find any settings related to Windows telemetry or diagnostic data.  Please elaborate on the deletion procedure.
(admin edit: refresh metadata with latest)

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7fb999d2-1864-9a75-8c93-44884a0d5f27
Version Independent ID: da983002-7246-fb74-15fb-f4415ea90ee0
Content: Windows Privacy Compliance Guide - Windows Privacy
Content Source: windows/privacy/windows-10-and-privacy-compliance.md
Product: windows-client
Technology: itpro-privacy
GitHub Login: @DHB-MSFT
Microsoft Alias: danbrown

You can find more information on how an IT administrator can fulfill DSR delete requests here:
https://docs.microsoft.com/en-us/compliance/regulatory/gdpr-dsr-windows#step-2-delete

Is there no way to delete a user’s associated diagnostic data without deleting the AAD user object itself (as you could with a consumer Microsoft account)?

To make it easier for you to submit feedback on articles on learn.microsoft.com, we're transitioning our feedback system from GitHub Issues to a new experience.
As part of the transition, this GitHub Issue will be moved to a private repository. We're moving Issues to another repository so we can continue working on Issues that were open at the time of the transition. When this Issue is moved, you'll no longer be able to access it.
If you want to provide additional information before this Issue is moved, please update this Issue before December 15th, 2023.
With the new experience, you no longer need to sign in to GitHub to enter and submit your feedback. Instead, you can choose directly on each article's page whether the article was helpful. Then you can then choose one or more reasons for your feedback and optionally provide additional context before you select Submit.
Here's what the new experience looks like.
Note: The new experience is being rolled out across learn.microsoft.com in phases. If you don't see the new experience on an article, please check back later.
First, select whether the article was helpful:

Then, choose at least one reason for your feedback and optionally provide additional details about your feedback:

Article was helpful
Article was unhelpful

Finally, select Submit and you're done!


build.sh does not fail if createArchive() fails to produce an archive

What are you trying to do?
Run a build testing a new openjdk-build change
Expected behaviour:
Build Green and produces an archive
Observed behaviour:
Build Green but bug in openjdk-build meant createArchive() had actually failed, build should have Failed
PR build tester thus did not fail
Any other comments:

PR build tester probably needs to be a little more robust on what archives are produced?

Should be fixed by the above PR. We can re-open if that turns out not to be the case :-)


Add styling for validated text input

Would like to have common styling for text inputs that need to indicate the value has been validated.
Similar to:

cc @mcarrano @kybaker

@mcarrano @kybaker I have the code ready to implement this if this is agreed upon. The only issue I have is getting the right color green to pass a11y tests and still show the bottom border of the text input as green. I could use some help there.

@jeff-phillips-18 While I don't really see a problem with what you've done here, I do have a question about intended usage. Typically on a form you only reflect feedback from validation if there is an error. Is the suggestion to give feedback on all fields, even those with no errors? Only certain fields? Would like to hear more about the use case.

In a form the user can enter a value. At that time, we need to determine if the value is valid before allowing the user to continue. The validation process can take some time and we want to give the user some feedback that the field has in fact been validated once the validation completes.
The help text is updated during the validation process to inform the user that the validation is in progress.

Use case is to provide feedback for a text input that takes some time to validate once the user enters the text. During the validation the help text is updated to inform the user that the validation is in process. Once complete we want to provide feedback that the validation was successful.
@parvathyvr @serenamarie125 @mceledonia @rachael-phillips

@jeff-phillips-18 Thanks for the explanation. This makes sense. @kybaker @mceledonia do you have input on the colors to use? Seems we'd want to use the same color treatment as a 'success' inline alert.

@mcarrano Agreed - using the success treatment makes sense to me.

Using the success inline treatments yields:

It gets the point across, but the text color setting doesn't stand out to me. Is this what we want?
@mcarrano @kybaker

so we had reached out to @mceledonia and the suggestion was to use --pf-chart-color-green-400 for the icon & the underline, but open for discussion for sure!

Yeah the lime green feels too bright to me here since it's not over a dark green background like the alerts. It's subjective but it kinda feels a little fluorescent, and I thought the regular green fixed that.
@kybaker This all gets back to that secondary color palette from brand, it would be nice to only have one set of greens so we can avoid the confusion.

Here are both together for comparison:

There are issues with success-100 #2168 this is why we would like to change it to the darker green.

@kybaker @mceledonia if you have no objections, I would like to go ahead with using a darker green to indicate success across the board. Looks like this at least affects, progress bars, alerts, and this new validation pattern. Can we change this globally (via a CSS variable) or will we need to update each component?  @mcoker thoughts?

@mcoker Should I update the global color with my fix for this issue or is that going to be done separately?

@kybaker what are your thoughts here?  We need this for 4.3 so the earlier the better!  Thanks

@mcarrano that sounds fine to me. Confirmed we're only using that color in those 2 components:
src/patternfly//components/Progress/progress.scss:  --pf-c-progress--m-success__bar--BackgroundColor: var(--pf-global--success-color--100);
src/patternfly//components/Progress/progress.scss:  --pf-c-progress--m-success__status-icon--Color: var(--pf-global--success-color--100);
src/patternfly//components/Alert/alert.scss:  --pf-c-alert--m-success__icon--BackgroundColor: var(--pf-global--success-color--100);
src/patternfly//components/Alert/alert.scss:  --pf-c-alert--m-inline--m-success__icon--Color: var(--pf-global--success-color--100);
src/patternfly//components/Alert/alert.scss:  --pf-c-alert--m-inline--m-success--before--BackgroundColor: var(--pf-global--success-color--100);

The only concern I have is that if someone is using $pf-color-light-green-400 or #92d400 directly as the value for a custom style in their application in a way that is intended to match our use of $pf-global--success-color--100 in our components, but I would consider that an improper way to use the color, so I don't think it would be a breaking change - just something to keep in mind.

@serenamarie125 I agree with both Michaels here. I am fine with the darker color design change as long as it is not breaking.

Jotting down some notes here:
[current success variables]
success-100 = light-green-400 = #92d400, on white = 1.8 (fail)
success-200 = light-green-600 = #486b00, on white = 6.22 (pass)
[success alert styling]
success-200 on top of success-100 = 3.45 (AA+/fail)
Two options I see here:

[changing from light-green to -green]
green-400 on top of white = 3.10 (AA+ = fail)
green-500 on top of white = 4.85 = (AA = pass)
So changing success-100 to green-500 works well on white, but not well for the toast alert styling. Since it's -500, that means we need to go up a step to -700 for the icon fill (success-200) which is very dark and still doesn't get us to AA (3.3)

FAIL
1b.
The other option is to use -500 as our dark color (success-200) and go lighter for success-100..
that gets us to 3.46, still not AA (AA+) and also starts to not fit in very well with the other alerts

FAIL

[Darker light-green]
Light-green-500 on white = 3.14 = fail
Light-green-600 on white = 6.22 = pass, but ugly color.
FAIL

2b. [Both?]
We already know green-500 on white = pass
Does Light-green-100 pass with green-500 on top? No, but it is closer with 4.17. On to 2c.
FAIL
2c. [Using opacity to lighten light-green-100 so green-500 passes on it.]
I think this is our best option for the short term, going for no breaking changes. Essentially forcing that 4.17 up to a 4.5. After all this we might want to rethink the toast designs in the future, as getting the contrast ratio is proving difficult.

PASS
Conclusion/proposal
Success-100 = light-green-100 set to 49% opacity
Success-200 = green-500 = #467F40
Success-100 on Success-200 = 4.5 (PASS)
Success-200 on white = 4.85 (PASS)
Side note - these troubles might be solved by the new secondary palette the brand team is implementing.

Using
Success-100: $pf-color-light-green-100
Success-200: $pf-color-green-500
I get:

Which looks reasonable to me and doesn't need to introduce opacity which I would think would be much more of a breaking change. Maybe this doesn't get us all the way there but it's pretty close and an improvement on what we have currently.

@jeff-phillips-18 Agreed, and this definitely works for now but I do think we should mark it as something we still need to solve. Shooting for the numbers here on accessibility we unfortunately come up short without the opacity.
@kybaker I'm hoping the new brand secondary colors come in handy here, if not we can always reconfigure the toast design to avoid the color on color.
cc @mcoker @jgiardino @mcarrano

Went over the proposal from @mceledonia and while this wouldn't technically be a breaking change for any patternfly components, it likely would be a visual breaking for applications using our pf-global--success-color variables to style success states in their application, depending on how they're using the success color vars. In order to proceed with this proposal, I'd prefer wait to introduce this in a breaking change release.
@mceledonia is going to re-evaluate the existing green color palette and see if there is a way we can tweak the existing variables such that they provide the proper contrast and wouldn't result in breaking changes for users using the existing success color vars to represent state in their application.

So far I have tried our chart colors, the new brand colors, a modified version of our chart colors which introduces a darker -600, and now I'm trying out a modified brand new green based on our current colors and the new brand direction. No luck yet, I can make it work with a whole new green palette, but this begs the question:
Should we be changing our entire green palette for this, or should we reconsider the toast alert design?
This problem stems from a very specific set of requirements we are currently imposing on our green palette. It must -

Have a "main" green color which is dark enough to be accessible over white for general usage (think success icons, success progress bar state). This isn't difficult, but it must also...
Not be too dark, to ensure a darker -600 or -700 will work over it without just basically being black. <- This is where we get in trouble and is forcing us to create a new green palette.

Here's a few tests I've run, I'm still working on this and I'm confident I'll be able to find a solution, but the solution is a brand new set of greens which won't necessarily fit the cadence of the other palettes. So I guess I'm asking if that's worth it just to meet that second criteria I listed above.
I would be in favor of changing the toast design altogether to something that has more contrast, but I know that in itself is probably a breaking change.
@mcoker @kybaker @mcarrano

Spoke with @kybaker and we landed on a solution-
Success-100 -> Chart-green-400 (4CB140)
Success-200 -> New green-600 (183C14)
These two colors pass when stacked. Success-100 does not pass on top of white, which in general is fine as long as there is an accessible indicator of the success otherwise, such as supportive text under the input as seen above. Another option here is adding an accessible success-150, for areas where we do need the accessibility on white. That color could be:
success-150 = 3E8635 which gives us a perfect 4.5 contrast ratio.
We can then reconfigure things like the progress bar or the success input underline to use this color which does pass, without having to worry about a darker color which also passes when on top.
@mcoker @kybaker @jgiardino

We're in business, folks! @jeff-phillips-18 @mcoker @mcarrano @kybaker @jgiardino
And from what I can tell, no breaking changes.

Change Green-500 to #3E8635 (for perfect 4.5 over white)
Change Success-100 to call Green-500
Change Scccess-200 to call Green-700 (current)

I commented on the 24px qualifying as large text in another issue, if you're interested in how we arrived at that conclusion.

:tada: This issue has been resolved in version 2.38.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Some sliders not loosing focus on mouse release + mouse cursor offset when they loose focus (DisplayServer regression)

Godot version
4.0.alpha1.official [31a7ddbf8]
System information
Windows 10, 2560x1440 display (125% scaling)
Issue description
On some specific sliders, like the ones in Settings or in Preview environment, releasing the mouse click after changing the value of the slider does not make it loose focus, we are "stuck" in it.
I forced the loss of focus by clicking the "Enter" key, but then the mouse cursor is offset from the slider :

Sliders that are in the inspector do not have this problem though, the loss of focus is effective on mouse release and there is no cursor offset.
Steps to reproduce

Create Root Node: 3D Scene
Edit Sun and Environment settings
Use a slider

Minimal reproduction project
No response

Duplicate of https://github.com/godotengine/godot/issues/57383.


Add pug-lint

@XhmikosR I'm going to let you resolve these conflicts, don't want to mess anything update.