Support param in Router

https://github.com/pmlopes/yoke/blob/develop/framework/src/test/java/com/jetdrone/vertx/yoke/test/middleware/Router.java#L137
if you have a route /users/:id you can add a param('id', regex) or param('id', handler) and it will be called before the handler

That's a very interesting feature a lot of framework actually provide (RESTEasy, ...).
I think it could be called ParameterResolver.
The interface could look like this :
public interface ParameterResolver<T> {

    @Fluent
    public ParameterResolver accept(T unboxed);

    @Fluent
    public ParameterResolver reject(int statusCode, String reason);

    public String rawValue();

}

And then :
router.param("userId", resolver -> {
    Long userId;
    try {
        Long.parseLong(resolver.rawValue());
    } catch (Exception e) {
        resolver.reject(400, "Invalid user id");
    }
    mongo.find("users", new JsonObject().put("_id", userId), callback -> {
        if (callback.failed()) {
            resolver.reject(500, "Something is wrong with mongo");
        } else {
            List<JsonObject> matchingUsers = callback.result();
            if (matchingUsers.size() > 1) {
                resolver.accept(matchingUsers.get(0);
            } else {
                 resolver.reject(404, "User not found");
            }
        }
    });
});

Then, resolver should be called first (before other handlers) for each route invokation, and contextHandlers should be called only once the parameter has been resolved.
Then, in RoutingContext, we could add a method like :
public void handle(RoutingContext context) {
    User user = (User)context.unboxedParam("userId");
    // ...
}

But I'm not sure if this generic approach (Resolver) works with the polyglot approach of Vert.x
What are your thoughts ?

The interface you described is not a functional interface so in Java8 you won't be able to use it as a lambda, if you have a simple functional interface:
@FunctionalInterface
public interface Handler {
    void resolve(RoutingContext context)
}

then you could inline it as:
router.param("userId", ctx -> {
    ... go to mongodb for example and in success
    ctx.next();
    ... or in error
    ctx.fail();
});

And this makes the Handler the same as a normal route handler so no need for extra types. BTW this is how it works with Yoke.
The behavior is that for each route registered with the router, all param names are extracted and these handlers are kept on a different list, then for each request the list of params in use is iterated and prefixed to the chain so it works like you're just iterating the normal middleware list.
If we would go with your interface we then cannot use the compact code of lambdas, it is just a matter of preference. I personally prefer less code.

I thought about ParameterResolver<T> as a way to abstract the RoutingContext.
So that maybe people could have their own implementations (not failing the RoutingContext directly, store something somewhere, notify some stuff).
Just in order to provide a simple way to accept / reject parameters.
And then yes, a functionnal interface that takes ParameterResolver<T> as parameter as you described. (with the resolve method) so that it's useable as a lambda. (didn't write the code for this one).

sidenote : the same mechanism, whether it involves ParameterResolver or context.put() directly could be used (with almost no additional effort) for query parameters.
router;route("/api/1/*").queryParam("from", ctx -> {
    String rawValue = ctx.param("from");
    try {
        Date fromDate = parseJSONDate(rawValue);
    } catch(ParseException pe) {
        ctx.fail(400);
        return;
    }
    ctx.put("fromDate", fromDate); // or resolver.accept(fromDate);
    ctx.next();
});

then in user's code :
Date d = ctx.unboxedQueryParam("fromDate");

Something like that.

The issue is clear however the style of the API does not match the current Vert.x-Web, since i reported it using Yoke's style.
I think it should be something like:
router.route("/api/*").param("from").handler(ctx -> {
    String rawValue = ctx.request().getParam("from");
    try {
        Date fromDate = parseJSONDate(rawValue);
    } catch(ParseException pe) {
        ctx.fail(400); // or resolver.reject(400, "ISO 8601 Date expected");
        return;
    }
    ctx.put("fromDate", fromDate); // or resolver.accept(fromDate);
    ctx.next();
});

Also the same for RegEx:
router.route("/api/*").param("from").handlerWithRegex("^(0|[1-9][0-9]*)$');

After giving more though and playing around with the API I am inclined to think this is method is not required in the API. The current implementation allows plugging multiple handlers on the same route, a param validator is just a simple handler, so we can get exactly the same result with it.
We can however implement a set of helper validators that validate if a param is Number, String, Date, etc, or matches a Regex and sets the value with the correct type in the context. e.g.:
router.route(/api/:apiKey").handler(ParamHandler.create("apiKey", "/^(?=[a-f\d]{24}$)(\d+[a-f]|[a-f]+\d)/"))

For complex scenarios, like we would do with the param we just use a normal handler:
router.route(/api/:apiKey")
  .handler(ctx -> {
    // go to the db fetch the value to the context
    // or fail
  })

In order to reuse it, all one would need is to declare the closure outside the handler method and give it a name:
Handler<RoutingContext> apiKeyValidator = ctx -> {
    // go to the db fetch the value to the context
    // or fail
  }

router.route(/api/:apiKey").handler(apiKeyValidator)
router.route(/api/:apiKey").handler(ctx -> {
  // at this moment apiKey is valid so do something...
})

I'm closing this issue for now since it would be adding duplicate functionality as described on the previous comment.


v57: uBo settings affected by clearing Offline Website Data on close.

I have always had Offline Website Data checked (value = true) for both privacy.cpd.offlineApps & privacy.clearOnShutdown.offlineApps. Since v57 this causes uBo to lose it's settings just as it was doing before adding an exception in v56.
Additionally, I get this in Preferences. Notice the Site Data info. It permanently reads "Calculating" and the options are unavailable.

I do NOT want to start allowing a bunch of BS to get stored in order for extensions to work like they have all the years before.
Anyone else getting this? I imagine we all have relatively similar settings.

Terms

local storage = storage.sqlite and/or extensions using storage api where I think they store this stuff elsewhere in extension folders eg "browser-extension-data" dire (this is not IDB)
IDB = OWD = not local storage in my words below
I am treating these two items separately

I'm still on FF56 and clearing OWD on close or manually doesn't affect uMatrix or uBo's IDB
We better do a user.js patch and turn these two prefs to inactive with a note (FYI see  1416219 )
@grauenwolfe - We need to clarify this

so this removes the IDB entries? or just the localStorage?
if you clear OWD and NOT cookies what happens to profile/storage/default/moz-extension+++UUID dirs and profile/browser-extension-data/Ext-ID dir contents (this is not the UUID, eg see<EMAIL_ADDRESS>folder)

my<EMAIL_ADDRESS>storage is 45.5kb

same dirs to watch, but this time also clear cookies

Comment 5 suggests that "localStorage" will be cleared, and I assume this means the profile/browser-extension-data/Ext-ID folder
Note: I haven't got a 57, but I am intrigued as to whether or not this requires clearing cookies (which I don't as per the user.js) - because I thought clearing cookies cleared the localStorage

The prefs UI changes / section - in FF56->57 diffs we are looking at the storage thing
pref("browser.storageManager.enabled", true); // prev: false 2706 1399398
pref("dom.storageManager.enabled", true); // prev: false 2706

We currently have them in 56 and lower as disabled. In 57+ we will make them inactive. Suggest you do the same and reset them in about:config. For starters it then shows some extra settings in the prefs UI. I am not entirely sure exactly which new UI stuff is added.
I am not worried about the actual storage (we control that via numerous other means), and I am almost certain that the new Storage API is used a lot and being disabled might have side-effects.
PS: I am almost out of time and will be gone for the next week, back on the 26th

see - https://github.com/ghacksuserjs/ghacks-user.js/commit/7ae034a23c7d1cfd2edcd7f5bfcdab7a08d3fcf7
I too (in FF56) get a non-stop "calculating" and the settings and clear all data buttons are disabled. We will have to figure out what is stopping that - might be something to do with browser.cache.offline.enable (1004)

Side Note: from the other bit in your pic, AFAIK (cannot find tickets in a hurry) - the cached web content quota is broken and has been years regards limiting amount and asking for permission (i.e i think it was limited to 5mb per domain and it had to ask for more = broken). I do not know anymore where this data is - maybe it refers to OWD
something I think to do with 2450a+b

offline-apps.allow_by_default
browser.offline-apps.notify

These two prefs should probably be tied move from the 2400s and moved to the new storage section or to cache section - IDK

Made a new profile from scratch, not one thing was imported, and have gone through implementing the changes I have always had, item by item. Still a problem on new profile.
It seems that data from extensions is treated no differently than offline website data. Either Prefences>Cached Web Content -or- Offline Website Data on close is clearing extension data, uBo at least. Adding exceptions makes no difference anymore. Maybe something unique to only uBo? Universal? Shit.

if you clear OWD and NOT cookies what happens to profile/storage/default/moz-extension+++UUID dirs and profile/browser-extension-data/Ext-ID dir contents (this is not the UUID, eg see<EMAIL_ADDRESS>folder)...

Not clearing cookies at all, Cookies + Site Preferences are left unchecked, not cleared. Interesting to note that<EMAIL_ADDRESS>has a creation time of a few minutes ago, 13:05. While New Tab Override's storage.js file shows creation at 8:09, when I created a new profile.

pref("browser.storageManager.enabled", true);
pref("dom.storageManager.enabled", true);

These are both enabled so we can rule that out.

might be something to do with browser.cache.offline.enable

This is my hunch as well. About to try more things out. What a f'ing mess, again. I genuinely may just go back to v56. Three days of using v57 and nothing is better or faster, only slightly more broken and glitchy, to be expected though I guess.

^^ Yeah, I will not move to 57 until I am ready. I can of course do a FF57 portable using my current profile as a secondary - but only when I get back. First I want NoScript and probably several weeks of that in the wild for serious bugs to be fixed.
Meanwhile, this extension data getting wiped is a problem - not moving until I know how to stop it, and the ramifications of any changes to stop it.

@grauenwolfe - see https://github.com/ghacksuserjs/ghacks-user.js/issues/254#issuecomment-345425166 and previous comment by earthlng
enforce the two storage prefs in 2706 to false and test again

I'm 99.9% sure this is caused by clearing Offline Website Data. What I'm not at all sure of is if it's an issue only with uBo or if it is universal.
Below configuration solves the issue. Bad solution.
privacy.clearOnShutdown.offlineApps = false
privacy.cpd.offlineApps = false

^^ didn't we already confirm that (it also says it in that bugzilla ticket)
My Q was

if you make the two storage api prefs in 2706 false does it still happen
also, I am still no closer to knowing if it removes extension local storage and/or IDB storage

I haven't had time to test myself yet and am about to head out the door

I have both privacy.clearOnShutdown.offlineApps and privacy.cpd.offlineApps set to true and I'm not experiencing this on FF 57 stable. :confused:

@claustromaniac - so I assume you have the 2706 prefs enforced and active at false

@Thorin-Oakenpants Yup. It must be that.

My Q was

if you make the two storage api prefs in 2706 false does it still happen
also, I am still no closer to knowing if it removes extension local storage and/or IDB storage

Shit man, I'm sorry, you're talking about:
dom.storageManager.enabled + browser.storageManager.enabled
OK, they were set to true. Switched them to false so we'll see what happens.
PS - If you're still talking about different entries than this then just tell me specifically.

I've tested a fresh new profile with only my user.js and a new install of the latest uBO and clearing offlineApps on shutdown (or manually) doesn't remove my uBlock config in 57 stable. IDK what to tell you, must be something on your end. Am still trying to figure out the "Calculating" part.

Ok, so ... the "Calculating" part is because of browser.cache.offline.enable=false.
Changing it to true creates a new folder OfflineCache which can also be seen under about:cache -> appcache -> location: profile\OfflineCache. Keeping it on true and setting browser.cache.offline.capacity = 0 changes that "location" to "none, only stored in memory" in about:cache for appcache. However then the Site Data UI thingy also doesn't work, .capacity needs to be at least =1.
from nightly's sanitize.js:
offlineApps now clears:

AppCache - which seems to be what's stored under profile/OfflineCache
-> I've tested the IDB testpage and about:cache still said "storage in use: 0 KiB" - IDK which API is used for this AppCache stuff

LocalStorage - (or DOM Storage as Pants likes to call it) which I think is what's stored in webappstore.sqlite
-> API: window.localStorage (sometimes also used in Webextensions)

ServiceWorkers

QuotaManager stuff - which is IDB and presumabely other stuff stored in profile/storage/...

When I tested the IDB testpage the Site Date Preferences UI now reads
"Your stored site data is currently using 48.0 KB of disk space" and the domain is listed under "Settings..."
"Clear All Data" deletes it, as expected, HOWEVER manually clearing "Offline Website Data" does not remove it!?! WTF?!
console shows:
Error sanitizing offlineApps Exception { name: "NS_ERROR_ILLEGAL_VALUE", message: "Component returned failure code: 0x…", result:<PHONE_NUMBER>, filename: "chrome://browser/content/sanitize.js", lineNumber: 336, columnNumber: 0, data: null, stack: "clear/</</<@chrome://browser/conten…", location: XPCWrappedNative_NoHelper }  sanitize.js:152
Error: Error sanitizing  sanitize.js:184:13

At least Quantum is fast, right? LOL :facepalm:
Also didn't clear it on shutdown - good stuff

I suggest we do the following changes for 57:
user_pref("browser.cache.offline.capacity", 1);
user_pref("browser.cache.offline.enable", true);
user_pref("browser.storageManager.enabled", true);
user_pref("dom.storageManager.enabled", true);
user_pref("privacy.firstparty.isolate", false);

Then the new Site Data UI works and offlineApps (Offline Website Data) clearing on shutdown or manually works correctly. A bit sad to disable FPI but IDK what else to do. What do you guys think?

PREFACE:
As a matter of respect and efficiency I try my best to convey only relevant info, in as few words as possible. None of it is extraneous so please be sure to read and consider every word. I only say this because (a) it's a long post and (b) I'm guilty of first jumping to bullet points, screen shots, etc.
Now, on with the show...

I spent all night trying to isolate this. I toggled more settings in one night than anyone ever should but in the end the only single thing that mattered was clearing OWD. Either via History>Clear Recent History or via clear on close, it didn't matter. I toggled these one off one on, back and forth, etc. and just as you may expect they had the same effect individually or paired. When both clear OWD settings are off, everything is fine. No progress there - only confirmed what I already knew.
Issue 1
Setting browser.preferences.offlineGroup.enabled = true, adds this to the Privacy & Security UI:

It shows "using 0 bytes of disk space". So I changed some extension settings, visited a few sites, and refreshed the Privacy page to see if it changed. It didn't, still "0 bytes". Yet when I clicked the "Clear Now" button, uBo settings are wiped clean - even though it says there's nothing there to clear.
Issue 2
Within Privacy & Security UI, three seperate references for storage show the following:

Cached Web Content = 0 bytes
Site Data = 0 bytes
Offline Web Content and User Data = 0 bytes

However, at the very same time:

You can clearly see Offline Storage is 30.9 MB. Add to this that clicking either the "Clear Now" (via Offline Website Content UI) or the "Clear Storage" (via Permissions Manager UI) buttons had the same effect on the same data even though they show inconsistant values.
Can I also just say that I have never been asked to allow a site storage permission. Not one time.

Quickie reminder points:

This issue started with v57 on a profile which I have used trouble free since v53 or 54.
Issue persists on new profile from scratch without importing a single item from the previous profile to eliminate chance of corruption.

@earthlng I read your posts, not dismissing them, I just had a post ready to go.
Aside from my minor problem, it seeming like there's still some funky issues with storage overall. I read through some bugzilla tickets regarding storage last night and it quickly become apparent that sometimes the devs themselves are unsure about data storage - what gets stored, where, or what gets cleared and by what means.
I'll get back on this later today and of course post any progress made.

First of all LOL at the preface xD It wasn't that long of a post. Maybe for today's youth it is because they won't read a tweet if it's longer than 1 sentence but that's another problem entirely ;)
2ndly just forget about browser.preferences.offlineGroup.enabled! That's old and probably won't work correctly anymore or could even interfere with the new "Site Data" UI. Reset it to false and see if that changes anything. 3rdly I also didn't have to change any permissions for uBlock and I can clear cookies, OWD, and everything else for that matter and it still retains uBlock's config.
Regarding the "0 bytes" throughout that's the same here. I think storage used for extensions is not included in "Site Data"'s counter.
I assume you're using the latest version of uBlock? Have you tried making a couple screenshots of the settings and copying the filters and rules and completely remove and reinstall the latest version and then re-configure it?
@claustromaniac couldn't reproduce your issue and neither could I, maybe it's a Mac problem IDK.

@earthlng Before starting this post I implemented the recommended changes so after posting this I'll restart FF and see where it goes (which may end up making this post pointless then).

claustromaniac couldn't reproduce your issue and neither could I, maybe it's a Mac problem IDK.

I understand that it's more than likely an issue for only me or maybe very few, but it's not been a problem before as I've cleared OWD for as far back as I can remember. Certain settings are sort of second nature for me at this point. It started immediately after updating to v57. From some tickets I read last night and this one 1416219 referenced by Pants, I know it's at least real even if contained.

I assume you're using the latest version of uBlock?

Using v1.14.18 - latest as far as I know.

Have you tried [...] completely remove and reinstall the latest version and then re-configure it?

Yes. I tried a number of things before posting and this was the second thing I did, actually. It didn't help so the next step was creating a new profile. It also didn't help.

3rdly I also didn't have to change any permissions for uBlock and I can clear cookies, OWD, and everything else for that matter and it still retains uBlock's config.

(Assuming this excludes permissions asked for on install) you haven't granted any permissions or added any exceptions? Would be nice if that was only necessary for v56.
Couple of quick questions for anyone:

Is your uBo data in profile/storage/default -or- profile/storage/permanent?
Did you update or clean install v57?
Do you have anything in your profile folder named webappsstore2

@grauenwolfe

profile/storage/default.
I updated to v57, but I had previously clean-installed v56 if I remember correctly. It might be relevant.
No.

(Assuming this excludes permissions asked for on install) you haven't granted any permissions or added any exceptions?

No, but I use network.cookie.cookieBehavior;1 because I don't need any permanent cookies (and I clear them on shutdown). So perhaps you still need cookie-exceptions if you block them with that pref IDK.

same as @claustromaniac
clean install (portableApps)
no profile folder with that name. webappsstore2 is the name of the database table in the file webappsstore.sqlite. That bugzilla is about problems with extensions that still use the window.localStorage API but I'm pretty sure uBlock doesn't use that anymore. The new storage API that WE's should use is browser.local.storage which creates the files in profile/browser-extension-data/extension-name/storage.js. uBlock also stores some of its data in IndexedDBs in the folder profile/storage/default/extension-UUID/...

No. EDIT: Wait. Was that a typo? I do have webappsstore.sqlite, for whatever it's worth.

Not a typo, webappsstore2 is correct but @earthlng cleared this up. Just me grasping at straws.

No, but I use network.cookie.cookieBehavior;1

Same here.

no profile folder with that name. webappsstore2 is the name of the database table in the file webappsstore.sqlite.

Ohhhh, ok. Got it.

Unfixable for now
As a final test I tried this once more:

created new profile via command-line, set as default
launched Firefox with new profile
immediately to AMO and installed uBlock0
opened uBlock0 dashboard  and updated default lists
cleared History (default checkmarks) - settings remain
cleared History (default checkmarks + OWD) - settings gone

So it's time to call it on this issue.
Maybe something got off when updating? Don't know, could be a million things. Having an untouched, pristine profile still do it - it's beyond me. Maybe I'll just reinstall from scratch at some point. I'll deal with it but ultimately just wanted to understand the issue more than anything.

@grauenwolfe

default/storage/default/
update from my old regular profile
webappsstore.sqlite, webappsstore.sqlite-shm, webappsstore.sqlite-wal

No issue wit uBO.

from @grauenwolfe 's ridiculously excessively long post xD .. issue 2 .. site permissions for OWD are obsolete (the pic provided is showing permissions for moz-extension, but all the bugzillas are referring to domains, so maybe but I doubt it, moz-ext* is different, but highly unlikely) - they have been removed in 58, and for years the whole thing has been broken.  They're littered around in this repo under all the IDB, storage, strategy issues we've got (closed and open). I think the oldest ticket is 8 years old. I was tracking around 20+ tickets on OWD (it gets really confusing! - I don't really want to track them down again).
Re "site" permissions on a moz-extension: personally I would expect it to clear if you asked, because you EXPLICITLY asked to clear it. That's a big diff to clearing OWD manually from recent history or on close - that should really only be web content, and AFAIK that has been fixed.
Just got back - sunburnt too. Am sporting a super-secksie bikini line now. Will take me a few days to catch up. I can't even remember what this issue was about.
PS: I already saw earthlng's comment moaning about being overworked and to wake him up when ESR52 is EOL .. xD

@claustromaniac couldn't reproduce your issue and neither could I, maybe it's a Mac problem IDK

and I couldn't repro either

window.localStorage API but I'm pretty sure uBlock doesn't use that anymore.

I think it does, as a fallback, when cookies are denied (and thus IDB is denied) ask @gorhill - he implemented this so settings are not lost for those in PB mode

From the wee bit I have digested in the last half hour eg your unfixable for now test, this seems like a MAC problem BUT

created new profile via command-line, set as default
launched Firefox with new profile

so cookies are allowed by default

immediately to AMO and installed uBlock0
opened uBlock0 dashboard and updated default lists

add some filters (just make them up), change your default * settings in the dropdown

cleared History (default checkmarks) - settings remain
cleared History (default checkmarks + OWD) - settings gone

did ALL settings vanish - not just lists back at default

from @grauenwolfe 's ridiculously excessively long post xD ..

And I tried so hard ... :)

so cookies are allowed by default

Yes. That list is verbatim and literal. 1. Launched FF and 2. immediately went to AMO. No setting prefs or anthing else in-between the steps posted.

did ALL settings vanish - not just lists back at default

Wednesday night I deleted FF thoroughly and installed v57. Fresh install is still doing it, sort of. My filters, rules, etc., are fine but it still won't keep uB0's dashboard settings. This is minor although annoying. For example, if I collapse a filter group it will stay collapsed indefinitely until OWD is cleared. So I'm still kind of left wondering what's going on. I would think if anything that maybe clearing "Site Preferences" would be responsible, not OWD. Examples screen shots below.

Dashboard set like this:

Reverts to this after OWD is cleared:

So, that's where it stands as of now. Just cosmetic really and I can completely live with this. Still annoys the piss out of me though since I can't figure out why.

Just some more relevant tickets: https://bugzilla.mozilla.org/show_bug.cgi?id=832660 <-- about the site preferences and OWD and how it doesn't/didn't read data properly etc (see comment 0 and it's attachment pic). There are other tickets about prompts for saving data not working and limits being ignored. This has been closed since I was away in favor of https://bugzilla.mozilla.org/show_bug.cgi?id=1102808 which says "This bug explicitly does not track cases where data clearing is overzealous" so that's not going to help us since this is clearing some Ext data (? is anything actually being lost? I am still not sure on this becuase we talking at cross purposes sometimes - but only because the whole storage thing is complex and a mess right now what with FPI, OA, WE, etc).

PREFACE - PART II:
This is mostly a rant. No, it's entiely a rant, actually. So incredibly frustrated with Firefox and although I know better than to email or post when angry, I'm doing it anyway.

Thorin, I agree with you entirely and I'm done.
Storage management is broken / implementated to poorly to be of any use. In a number of those tickets, the devs themselves are often confused by this monster they've created, what hope have I then? I've seen enough tickets, enough contradictions, and enough of Mozilla's amateur hour hackshow. I don't think answering your follow-up questions will matter since I don't think there's anything for us to figure out, it's broken. Think of Jack Skellington doing all of his tests and experiments trying to figure out Christmas...
I'll leave you with this:
To solidify my feeling that 'managing storage' in Firefox is a sham, I disabled every storage, cache, disk, capacity, you-name-it, option. Set them all to off, disable, 0 value, etc., and guess what, none of it mattered, not one damn bit. Defying belief, data was still stored and data was still there to be deleted. So, either there are dozens of hidden preferences or it really is just a facade and sham.
Even with me clearly saying "No Firefox, don't do this." Firefox just looked at me and said "What? You mean this?" as it continued to store and cache away.
 Best guess: it's unfixable and probably because it has never really  been properly implemented to begin with.

I think you need a hug brother :hugs:
I am still on 56. I do not think persistent web data has gotten WORSE in 57 - I think it's manageable (but everyone has different mileage)

Default deny cookies FFS and set site exceptions - this stops all that local storage & IDB crap

You may also need to allow exceptions for cookies in uMatrix depending on your default rules
Site exceptions should be session only as much as possible - there is no need to clear cookies on close unless you want to. Keep cookies for auto-logins = you're tracked on that site anyway
Do NOT use a cookie extension (well not yet) - they are f**ked when it comes to FPI

Deny all workers as I know you do grauenwolfe because that too can set persistent data (dont ask me where, I have seen IDB entries but there must be more
Kill that storage API (its still being debated in #281) - the two prefs in 2706 - the UI is useless
Use FPI - it covers way more than just persistent data
Until the FPI + IDB clearing issue is solved, just run a script to wipe all IDB folders in storage/default except the moz-extension ones

personally, my mileage with my massive 8 allowed cookies means I never get any

I currently have zero issues with controlling storage with my methodology.  Persevere brother. I shall drink a dozen beers tonight for you.

This is a long thread, I don't know if this was clear so I will just state it here:

Reverts to this after OWD is cleared

These UI settings are saved uBO's window.locaStorage.
The filter lists' contents and their compiled versions are saved into window.indexedDB.
The rest goes into WebExtensions brower.storage.local (what is saved when backing up uBO settings).

@gorhill

These UI settings are saved uBO's window.locaStorage.

<EMAIL_ADDRESS>:question:

The filter lists' contents and their compiled versions are saved into uBO's window.indexedDB.

profile\storage\default\moz-extension-UUID :white_check_mark:

The rest goes into WebExtensions browser.storage.local (what is saved when backing up uBO settings).

:question:

<EMAIL_ADDRESS>is browser.storage.local and window.localStorage is in webappsstore.sqlite

Makes sense now that @grauenwolfe is having UI setting issues because its stored in webappstore.sqlite which is where website localStorage is also stashed. Just looked in mine. I see (besides 4 entries for websites) 58 entries for 3 specific moz-extension scopes - but the strings do not match up with UUID or Extension IDs (as seen in about:debugging). I can recognize one from the keys and values as being Stylus. I guess the other two must come from uM, uBo, ViolentMonkey?

@gorhill Hey, the man himself.

This is a long thread, I don't know if this was clear ...

It's pretty long so probably best to ask you this:
What about:config prefs need to be left alone or are "off-limits" for uBO to function perfectly as designed? Anything like dom.indexedDB, browser.cache.offline, dom.storage, any other storage, any particular caches or anything else along these lines that uBO must have acces to? Or does it get access to everything it needs through asking for permissions when installed?
Maybe this is just a temporary condition with v57, I don't know, but uBO is an incredibly important extension for me so if there's anything you suggest, it'll be done.

^ you need to allow a cookie exception at minimum (for now) else WE have no access to storage
^ you need to allow IDB else WE cannot use it
^ pretty sure dom.storage would be needed (we've never disabled that in the js)
Everything else, AFAIK, would be just items that interfere/supplement eg referer settings, various ua prefs, tracking protection & safe browsing etc

@grauenwolfe
Can I confirm that on FF57Mac with latest uBo, that you are NOT losing any settings - that is, your lists are kept up to date (stored in IDB), and your changes to options in the dashboard are not lost, and that your personal filters and rules are not lost
In other words, the only thing you are experiencing is the dashboard collapsing/expanding the filter lists shenanigans?

Yes, correct. Since deleting and fresh installing 57 from scratch, filter list display issue now only. It doesn't affect uBO's functionality, just a minor annoyance.
uBO is working great since reinstalling, conveyed in post 346779584, maybe not clearly enough.

Wednesday night I deleted FF thoroughly and installed v57. Fresh install is still doing it, sort of. My filters, rules, etc., are fine but it still won't keep uB0's dashboard settings. This is minor although annoying. For example...

Before that (installed update from 56) was a complete nightmare. Updating filter lists over and over, 3p scripts enforced/not enforced randomly, wierd stuff and probably something funky during the update process, not sure.

sounds exciting :aren't-u-the-lucky-one: ... I am still on 56 here, hope I have no upgrade issues
I'll close this, but maybe you could post an issue on the uBo repo - @gorhill has anyone mentioned this - scroll up to the two pics here

I am still on 56 here, hope I have no upgrade issues

OK .. now I have zero legacy extensions and can upgrade .. might pull the trigger tomorrow, running outta time

@grauenwolfe I updated to 57, I have no issues with my uBo UI on windows (and I do not lose any data)
Should we close this?

@grauenwolfe can you please update your original post with the solution (did you only have to re-install FF or also start a new profile?), and a note that this happened on a Mac. You can link to this comment https://github.com/ghacksuserjs/ghacks-user.js/issues/273#issuecomment-345508296 re: the "calculating part". And then please close this issue. Thanks

@earthlng Sure, good idea.

@grauenwolfe - see https://github.com/gorhill/uMatrix/issues/863#issuecomment-348732013 and feel free to elaborate after gorhill responds

@grauenwolfe - did u see gorhill's reply?

Of course, forcing a reload of the "3rd-party filters" pane was necessary


Update default lpmethod and remove cplex.opt deletion

This PR makes two changes:

The default lpmethod is set to "4", therefore changing the default solving option for CPLEX from "DUAL Simplex" to "Barrier".
For applications based on the MESSAGEix-GLOBIOM model, this solving option should always be used as it is much faster, solving in seconds as opposed to minutes.
The cplex.opt file generated with each solving workflow has traditionally always been removed upon completion. This causes issues for both debugging as well as when running scenarios in parallel (see #575 )

How to review

Read the diff and note that the CI checks all pass.

PR checklist

[x] Continuous integration checks all ✅
[x] Add or expand tests; coverage checks both ✅
[x] Add, expand, or update documentation.
[x] Update release notes.

Since this branch was updated by merging main rather than by rebase, please remember to use the “Rebase and merge” or “Squash and merge” option.

closes #575, closes #250


Add AuthenticationService to log in customers

As the service is directly extended from BaseService, the request is performed with .save (as it's the method which will perform a json POST to the endpoint).
It could be a good idea to add an .save alias for AuthenticationService.

@Sikian thx for the PR. Maybe simply add the alias like https://github.com/sphereio/sphere-node-sdk/blob/master/src/coffee/services/base.coffee#L394
Could you also provide a spec, please.

And tests please!

Refs https://github.com/sphereio/sphere-node-sdk/issues/18

@Sikian are you going to update your PR to implement @emmenko's idea from https://github.com/sphereio/sphere-node-sdk/pull/68/files#r31109950
Or should we do it?

I think the most sensible thing would be for your team to implement it as
you have a deeper knowledge of how the module is structured and documented.
Thanks!
On Tue, Jun 23, 2015 at 12:06 AM, Hajo<EMAIL_ADDRESS>wrote:

@Sikian https://github.com/Sikian are you going to update your PR to
implement @emmenko https://github.com/emmenko's idea from
https://github.com/sphereio/sphere-node-sdk/pull/68/files#r31109950
Or should we do it?
—
Reply to this email directly or view it on GitHub
https://github.com/sphereio/sphere-node-sdk/pull/68#issuecomment-114281176
.


Add Rule programmatically

Hello, i'm writing a dynamic form generator for Android and i want to know how can i add a rule programmatically. I've searched on Google and StackOverflow and have not found something similar.
Thank you in advance

You can use quick rules to programmatically add rules during runtime to the Validator.

@ragunathjawahar I was trying to do this and I couldn't find an easy way to do it. Especially when I want to reuse existing rules you have in library rather than re-code them. This question on Stackoverflow essentially nails the essence of my question:
http://stackoverflow.com/questions/35737186/how-to-add-saripaar-validator-in-code-and-not-as-attribute
Let me know your stance on this - if needed I can do a pull request and add support for this in library; just would prefer to get clearance from you on if this is something you would want in library before I start coding.

Right, we need to do something like this in v2. Feel free to send a PR. Follow the AOSP style guide for code style and look into the existing rules to see how existing rules are implemented.

OK, let me see what I can do... I'll try to send first PR in as something small so that you can sign off on coding style and direction - the last thing I want is to spent lots of time on this and then you just reject it ;).

That's the way to go :+1:

Hey Ragunath,
I'm liking this library, but are there any updates on this issue?


 Can you reopen this on the 6to5.github.io repo? Thanks!

Superseded by 6to5/6to5.github.io#115


compiling go errors

Im trying to compile go for the first time.  I'm new to go.  I'm getting this message and I am a bit lost on how to proceed.  I checked my ubuntu certificate store and it seems to be correct.  I realize this probably isn't a rclone issue but was just looknig for some help trying to compile it.  I tried a few go versions with the same errors.  I'm currently on 1.7.5
HS -> lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 14.04.5 LTS
Release:	14.04
Codename:	trusty
HS -> go version
go version xgcc (Ubuntu 4.9.3-0ubuntu4) 4.9.3 linux/amd64
HS -> go get -u -v github.com/ncw/rclone
github.com/ncw/rclone (download)
Fetching https://bazil.org/fuse?go-get=1
https fetch failed.
Fetching http://bazil.org/fuse?go-get=1
import "bazil.org/fuse": http/https fetch: Get https://bazil.org/fuse?go-get=1: x509: certificate signed by unknown authority (possibly because of "x509: cannot verify signature: algorithm unimplemented" while trying to verify candidate authority certificate "COMODO ECC Certification Authority")
package github.com/ncw/rclone
imports bazil.org/fuse: unrecognized import path "bazil.org/fuse"
Fetching https://bazil.org/fuse/fs?go-get=1
https fetch failed.
  See SO answer
That should hopefully fix it.

ah. that was it!  Such simple things. When I removed the ubuntu packaged go (version 1.35)  and installed a new version it left that.  I just assumed it was gone.  Thanks.  I needed that kick in the right direction.


CAMEL-21417: Fix JettySessionSupportTest

Description

Target

[x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[x] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[x] I checked that each commit in the pull request has a meaningful subject line and body.

[x] I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

Can you fix code formatting of the file


 It should have darker (more brown) color.

Hello,
the "boar" Twemoji:

looks like a normal pig due to it's light color.
Please change it's color to a darker (more brown) color so that it actually looks like a boar.
Regards

like and thanks


Unable to install latest Xamarin.JOSE.JWT in Xamarin PCL project

Hello,
I am unable to install this package in xamarin project with versions:
Xamarin.Forms = v.<IP_ADDRESS>
Newtonsoft.Json = v.7.0.1 and also latest.
Error:
Install-Package : Could not install package 'Xamarin.JOSE.JWT 1.0.2'. You are trying to install this package into a project that targets
'.NETPortable,Version=v4.5,Profile=Profile111', but the package does not contain any assembly references or content files that are compatible with that framework. For more
information, contact the package author.
But was able to install v.1.0.1 of this library. But facing issues while using it.
Kindly let me know why I am unable to install this library.

I am having the same issue.  The latest version will not add to my Xamarin Forms PCL.

Did some more testing, 1.0.1 works.  1.0.2 and 1.0.3 does not.

+1, this still doesn't work. I can't seem to find any suitable JWT library for Xamarin besides this one either.
Installing 1.01 works, but it somehow doesn't show up in my references, and because of that I cannot find the namespace Jose.JWT.

+1, still having issues installing the packages.  Even problem referencing 1.0.1 in the projects. Can you address this issue at the earliest.?
Thank you.

+1, Still this doesn't work. able to install the 1.0.1, but the references never adds to the project. Can you assist us in this regard?
Thank you

+1, Still this doesn't work. able to install the 1.0.1, but the references never adds to the project. Can you assist us in this regard?
Thank you

+1 Installing Version 1.01 works, as @wsloth and @SivanTR  said the reference is never added automaticly. To resolve this do the following.

Go to your project, right click references and click add reference.
Click browse.
Navigate to your project and then follow this path "\packages\Xamarin.JOSE.JWT.1.0.1\lib\4.0"
add the jose-jwt.dll

This should do the trick, you should now be able use the lib.
Good luck!

NO

+1 Installing Version 1.01 works, as @wsloth and @SivanTR said the reference is never added automaticly. To resolve this do the following.

Go to your project, right click references and click add reference.
Click browse.
Navigate to your project and then follow this path "\packages\Xamarin.JOSE.JWT.1.0.1\lib\4.0"
add the jose-jwt.dll

This should do the trick, you should now be able use the lib.
Good luck!
No works for me


Handle streamer connection error

#115
This PR changes the application logic to resubscribe in this scenario instead of crushing.
Test results from logs:

please include a github issue with the error message so that we know what's been fixed. Also, please include a test log of the fix.

Added


Stop Restarting of Mirror

What do I type into the terminal to stop the restarting of the magic mirror application? I need to make a few more changes to my code and I am unable to do this since the mirror autostarts every time I restart my raspberry pi. Thanks!

How did you start it? Did you use the PM2 method?
In that case: pm2 stop mm

Personally I SSH into my rPi when I need to make changes to MM's config, then issue the pm2 restart command.


Plugin update fails due to composer restraints

Describe the bug
When trying to update the plugin via the shopware backend, there is an error message:
Required plugin/package "monolog/monolog ^1.16" does not match installed version == <IP_ADDRESS>.
Versions
Shopware version: <IP_ADDRESS>
Plugin version: 3.3.1
To Reproduce

Go to installed plugins
Click "update" for the Adyen Payments für Shopware 6 plugin

Expected behavior
The plugin updates without an error
Screenshots

Additional context
When manually changing the monolog version in the composer.json back to "^2" from "^1.16" the plugin update can be done via console.
Commit that does change the version constraint: 9e9e9e34cea39e33b79f6218044ab0b3a2cb28e6

Hello @mm-mereien thanks for reporting this issue. We're are working on fixing this ASAP

The plugin has been updated on the marketplace, please try again

Hello @peterojo , Plugin update via backend is succesfull again, thank you


Update Photon Controller cloud provider for authentication support

Update the configuration file for Photon Controller cloud provider
Only master nodes can communicate with Photon Controller endpoint
Enable support for authentication-enabled Photon Controller endpoint
Update NodeAddresses function for query from local node

New format of photon controller config file:
[Global]
target = https://[LOAD_BALANCER_IP]:443
project = [PROJECT ID]
overrideIP = true
vmID = [LOCAL VM ID]
authentification = true

This config file will be automatically created by Photon Controller cluster management.
If authentication file is set to true, then a pc_login_info file should be placed under /etc/kubernetes with username and password.
This file can be created by user directly.
Or the user can choose to use kubernetes secret and a handling pod to avoid directly login to master nodes. This usage will be available soon.
This is a temporary solution before metadata service becomes available in Photon Controller.

@ashoksekar07
Thanks for catching the typo!
Fixed now.

Merged to k8s master branch: https://github.com/kubernetes/kubernetes/pull/40843

You need to cherry pick to 1.5.x rt?


fix docs

Address an error in the docs for FirstPersonView where the pitch angle 90 was deemed "up" and -90 was deemed "down", while it's actually the opposite, which for mapping makes sense.

@Pessimistress FIY.

Coverage remained the same at 80.64% when pulling 592e13c945aa39b66358214ba957703e7c84ca59 on damix911:ddamico/fix-fpv-updown-md into 621bcb985f54c42a35e6f0e2137ff5e85747fb83 on uber:master.


CLI now accepts strings as stdin

Finally I modified clap to accept either a file or a string.
It came with a couple of architectural changes:

➖ I decided to clean the Session struct, because it wasn't really relevant to have it.
➖ Input was also a rock the way to interpret files to format. So also it was deleted for better code readability
➕ I added 2 functions: format_single_file and format_string that redirects the code to format_inner, where the code is formatted. The first 2 functions have the responsibility of reading & writing the file, or writing to stdout respectably.

Looking good! Thanks again!


handle more gracefully an empty query for POST besthitsearch

@elipapa commented on Thu May 17 2018
call to bestHitSearch (POST, http://api.opentargets.io/v3/platform/docs#operation/postBestHitSearch) fails when the query parameter q is an empty array…
successful POST call has q: ["GLUR", "GRD1", "GSR"]
error POST call has q: []
we should handle it more gracefully

@ElaineMcA is this not more of an API design issue? It would require the function to control this situation.
I would be happy to look into it but I would need the developers (perhaps @mkarmona or @LucaFumis?) to guide me.


Fixes createNCConnection and closeNCConnection in Android. Closes #356

The functions  createNCConnection and closeNCConnection were not prepending 'RO_' when searching in internal dbDict, so the connections were not found when opened or closed.
Closes #356

@oscarfonts Thank you for this PR


Problem with dragging image

Informations
Browser + version: Google Chrome Version 59.0.3071.115
OS: Windows 10
Resolution: Full HD
How to reproduce the bug?
Hello.
After uploading image i need to wrap it in tag  with styles, it works fine. But if I upload 2 images and then drag second image above first one, my tags around image that was dragging are totally disappeared. Can you help me please which way is better to wrap image or how to resolve issue with drag?

Drag'n'drop is not supported in Trumbowyg. If it works, it's a browser feature so I can't fix that.
Sorry :/


Add theme support for dev site.

Feature Request
Description
Dev Site has styles but they aren't theme-able. We should change that to not blind our (potential) dark mode theme users.
Additional Context / Screenshots
@ Mentions

This should include clinical-lowlight-theme and orion-fusion-theme.


incompatible or mismatched c/c++ extension binaries

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

### Tasks

/extC++

It looks like this is caused by the C++ extension. Please file the issue to the C++ extension repository. Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our issue reporting guidelines for more information.
Happy Coding!


Issue with k8s.io/docs/tutorials/hello-minikube/

This is a...

[ ] Feature Request
[x] Bug Report

Problem:
Launching minikube dashboard encountered the following error and unable to continue tutorial:
demo failed to open browser: exec: "xdg-open": executable file not found in $PATH
Proposed Solution:
Page to Update:
https://kubernetes.io/docs/tutorials/hello-minikube/

Open a 'Web Preview' to render the response from a running web server.
virtual terminal session:
minikube version; minikube start
$
$ minikube version; minikube start
minikube version: v0.34.1
o   minikube v0.34.1 on linux (amd64)

Configuring local host environment ...
Creating none VM (CPUs=2, Memory=2048MB, Disk=20000MB) ...

"minikube" IP address is <IP_ADDRESS>
Configuring Docker as the container runtime ...
Preparing Kubernetes environment ...
@   Downloading kubeadm v1.13.3
@   Downloading kubelet v1.13.3
Pulling images required by Kubernetes v1.13.3 ...
Launching Kubernetes v1.13.3 using kubeadm ...
Configuring cluster permissions ...
Verifying component health .....

kubectl is now configured to use "minikube"
=   Done! Thank you for using minikube!
$ minikube dashboard

Enabling dashboard ...
Verifying dashboard health ...
Launching proxy ...
Verifying proxy health ...
Opening http://<IP_ADDRESS>:40646/api/v1/namespaces/kube-system/services/http:kubernetes-dashboard:/proxy/ in your default browser...
X   failed to open browser: exec: "xdg-open": executable file not found in $PATH

dup of #12968


Tower layer

[x] Route based layer
[x] Demo Role based auth example
[x] Demo Model Testing
[x] Demo E2E Testing
[x] Documentation for middleware with basic example and advance example which uses AppContext
[x] Grammar Check for documentation

This roles addition is super interesting. I will review this feature shortly, thanks!

Thanks @yinho999,
Looks very good and approved from my side. small comment, can you please add the layer function into the loco.rs docs?

Thanks @yinho999, Looks very good and approved from my side. small comment, can you please add the layer function into the loco.rs docs?

No worries, I will add that in later

@kaplanelad, added the source code and description of layer function into the middleware documentation. Would you mind double check about the changes, please?

@yinho999 Yes, I saw it, and it is great. But I think to add it also here: https://loco.rs/docs/the-app/controller/
WDYT?

I just mean that maybe we need to document the new layer function that you added in our docs website here

Thanks @yinho999


NTUEEPLUS-2. Delete un-used routes and create column page

What is this PR for?

Delete un-used routes and create column page
What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
improvement
Todos

[ ] - Column

What is the Jira issue?

https://ntueeplus.atlassian.net/browse/NTUEEPLUS-2
Screenshots (if appropriate)

@featherchen


feat: Added visualization method to Page and Documents

Following up on #173, this PR introduces the following modifications:

added a .show method to Page and Document for a cleaner UX
updated README, scripts and unittests accordingly

Any feedback is welcome!

#173 needs to be merged first


Cluster Tasks Cannot be Run from a pipelineRun

Expected Behavior
Cluster tasks should be runnable from pipelineRuns.
Actual Behavior
The pipeline run and task run fails. TaskRun with the status
status:
  conditions:
  - lastTransitionTime: "2019-06-21T15:38:58Z"
    message: 'error when listing tasks for taskRun demo-pipeline-run-4-cluster-task-pipeline-4-p6ch2:
      task.tekton.dev "cluster-task-pipeline-4" not found'
    reason: TaskRunResolutionFailed
    status: "False"
    type: Succeeded
  podName: ""
  startTime: "2019-06-21T15:38:58Z"

Root cause seems to be the taskRun is created with the wrong kind attached to the taskRef.spec.kind field. (see the taskRun resource below)
Steps to Reproduce the Problem

Apply the resources below
Check status for taskRun and PipelineRun

Additional Info
apiVersion: tekton.dev/v1alpha1
kind: ClusterTask
metadata:
  name: cluster-task-pipeline-4
spec:
  steps:
  - name: task-two-step-one
    image: ubuntu
    command: ["/bin/bash"]
    args: ['-c', 'echo success']
---
apiVersion: tekton.dev/v1alpha1
kind: Pipeline
metadata:
  name: sample-pipeline-cluster-task-4
spec:
  tasks:
  - name: cluster-task-pipeline-4
    taskRef:
      name: cluster-task-pipeline-4
      kind: ClusterTask
---
apiVersion: tekton.dev/v1alpha1
kind: PipelineRun
metadata:
  name: demo-pipeline-run-4
spec:
  pipelineRef:
    name: sample-pipeline-cluster-task-4
  trigger:
    type: manual
  serviceAccount: 'default'

controller logs
{"level":"error","logger":"controller.taskrun-controller","caller":"taskrun/taskrun.go:164","msg":"Error stopping sidecars for TaskRun \"demo-pipeline-run-4-cluster-task-pipeline-4-p6ch2\": resource name may not be empty","knative.dev/controller":"taskrun-controller","stacktrace":"github.com/tektoncd/pipeline/pkg/reconciler/v1alpha1/taskrun.(*Reconciler).Reconcile\n\t/Users/stephen/cloud/go/src/github.com/tektoncd/pipeline/pkg/reconciler/v1alpha1/taskrun/taskrun.go:164\ngithub.com/tektoncd/pipeline/vendor/github.com/knative/pkg/controller.(*Impl).processNextWorkItem\n\t/Users/stephen/cloud/go/src/github.com/tektoncd/pipeline/vendor/github.com/knative/pkg/controller/controller.go:330\ngithub.com/tektoncd/pipeline/vendor/github.com/knative/pkg/controller.(*Impl).Run.func1\n\t/Users/stephen/cloud/go/src/github.com/tektoncd/pipeline/vendor/github.com/knative/pkg/controller/controller.go:282"}
{"level":"error","logger":"controller.taskrun-controller","caller":"controller/controller.go:345","msg":"Reconcile error","knative.dev/controller":"taskrun-controller","error":"resource name may not be empty","stacktrace":"github.com/tektoncd/pipeline/vendor/github.com/knative/pkg/controller.(*Impl).handleErr\n\t/Users/stephen/cloud/go/src/github.com/tektoncd/pipeline/vendor/github.com/knative/pkg/controller/controller.go:345\ngithub.com/tektoncd/pipeline/vendor/github.com/knative/pkg/controller.(*Impl).processNextWorkItem\n\t/Users/stephen/cloud/go/src/github.com/tektoncd/pipeline/vendor/github.com/knative/pkg/controller/controller.go:331\ngithub.com/tektoncd/pipeline/vendor/github.com/knative/pkg/controller.(*Impl).Run.func1\n\t/Users/stephen/cloud/go/src/github.com/tektoncd/pipeline/vendor/github.com/knative/pkg/controller/controller.go:282"}
{"level":"info","logger":"controller.taskrun-controller","caller":"controller/controller.go:332","msg":"Reconcile failed. Time taken: 837.3µs.","knative.dev/controller":"taskrun-controller","knative.dev/traceid":"3d40844a-f82c-4fd3-a5d8-7d9599895052","knative.dev/key":"default/demo-pipeline-run-4-cluster-task-pipeline-4-p6ch2"}

The Task Run which gets created (The taskRef.kind field has Task as its value)
apiVersion: tekton.dev/v1alpha1
kind: TaskRun
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"tekton.dev/v1alpha1","kind":"Pipeline","metadata":{"annotations":{},"name":"sample-pipeline-cluster-task-4","namespace":"default"},"spec":{"tasks":[{"name":"cluster-task-pipeline-4","taskRef":{"kind":"ClusterTask","name":"cluster-task-pipeline-4"}}]}}
  creationTimestamp: "2019-06-21T15:38:58Z"
  generation: 1
  labels:
    tekton.dev/pipeline: sample-pipeline-cluster-task-4
    tekton.dev/pipelineRun: demo-pipeline-run-4
    tekton.dev/pipelineTask: cluster-task-pipeline-4
  name: demo-pipeline-run-4-cluster-task-pipeline-4-p6ch2
  namespace: default
  ownerReferences:
  - apiVersion: tekton.dev/v1alpha1
    blockOwnerDeletion: true
    controller: true
    kind: PipelineRun
    name: demo-pipeline-run-4
    uid: afa1512a-943a-11e9-887a-025000000001
  resourceVersion: "733285"
  selfLink: /apis/tekton.dev/v1alpha1/namespaces/default/taskruns/demo-pipeline-run-4-cluster-task-pipeline-4-p6ch2
  uid: afb0bc47-943a-11e9-887a-025000000001
spec:
  inputs: {}
  outputs: {}
  serviceAccount: default
  taskRef:
    kind: Task
    name: cluster-task-pipeline-4
status:
  conditions:
  - lastTransitionTime: "2019-06-21T15:38:58Z"
    message: 'error when listing tasks for taskRun demo-pipeline-run-4-cluster-task-pipeline-4-p6ch2:
      task.tekton.dev "cluster-task-pipeline-4" not found'
    reason: TaskRunResolutionFailed
    status: "False"
    type: Succeeded
  podName: ""
  startTime: "2019-06-21T15:38:58Z"

Looking to get involved in contributing to the pipeline project. If it's unexpected behaviour I'd be happy to take this one.

/kind bug
/milestone 9

/assign

I have the same error message in #1096. Can anyone explain to me what happened in sidecars.Stop to trigger this error message?

Hello!
I am using minishift v1.34.1  from https://github.com/minishift/minishift/releases , and looks like I am hit with the issue reported above.

do you know if https://github.com/tektoncd/pipeline/commit/cf2ecd56bcb73fa25118a280a2562a69b8957b83 is included in v1.34.1?
are there workarounds possible? I qualified the pipelineref and taskref with kind in my definitions, but the issue persists.

Thanks!


[Task]: Update Java version requirement on Apache Hop installation page

What needs to happen?
Update the Apache Hop installation page to reflect the correct Java version requirement. Currently, it mentions Java 11 as the official version, but Apache Hop 2.10 requires Java 17.
https://hop.apache.org/manual/latest/getting-started/hop-download-install.html

Issue Priority
Priority: 3
Issue Component
Component: Documentation

.take-issue


Fix the wrong argument in UfsManager.addMount()

#8825

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3109/
Test PASSed.

Merged build finished. Test PASSed.

@madanadit A small fix for the mount information. The key here is the mounted address in alluxio namespace, but the parameter required in addMount is ufs uri. This PR fixed the issue that after fs mount get wrong ufs type after restart. PTAL, thanks

@madanadit The bug cannot be tested in unit test and I found it hard to test in integration test as well.
In the designed integration test, my steps are:
(1) mount a ufs other than local ufs
(2) getMountPointInfo and make sure the ufs type is correct (is not local)
(3) restart the local cluster
(4) getMountPointInfo again and make sure the ufs type is correct (is not local)
but step one is hard to fulfill in our integration test: we do not support mounting systems other than local ufs.
and the
    String localPath = com.google.common.io.Files.createTempDir().getAbsolutePath();
    UnderFileSystem ufs =
        new DelegatingUnderFileSystem(UnderFileSystem.Factory.create(localPath,
            ServerConfiguration.global())) {
          @Override
          public String getUnderFSType() {
            return "FakeType";
          }
        };
    UnderFileSystemFactoryRegistry.register(new DelegatingUnderFileSystemFactory(ufs));
    mFsMaster.mount(alluxioUri, ufsUri, MountContext.defaults());
    MountPointInfo info = mFsMaster.getMountPointInfo(alluxioUri);

the ufsType in info.getUfsType is still local.
I think this bug is a rare happen case and hard to add tests for it. Could we leave it without test?
Thanks

alluxio-bot, merge this please.


Different ways to translating morphosyntactic features

There's no reason why we can't provide UDLexicon's UD features as such, or translate UM features back to UD features, and so on. The more's the merrier.

Closed in #25.


Check if jq installed in install.sh

Fixes #10
With this change, I am comfortable saying that this supports MacOS as the only dependency needed on mac is jq which we are now testing for in the installation.

@Leo6Leo do you think it would be okay to merge this since the remaining issue is captured in https://github.com/Cali0707/git-utils/issues/16?

@Leo6Leo can you send me the contents produced by echo $PATH? No need to send on github if its something you want to keep private, maybe slack?

@Leo6Leo I think we could maybe do this, but this isnt a MacOS bug, this is just saying that you didn't provide a URL to git clonefork. So maybe open this as a bug in a separate issue? You would get the same behaviour on linux

@Leo6Leo I think we could maybe do this, but this isnt a MacOS bug, this is just saying that you didn't provide a URL to git clonefork. So maybe open this as a bug in a separate issue? You would get the same behaviour on linux.
Currently, clonefork only supports cloning by the remote URL:

git clonefork {REMOTE_ORIGIN_URL}

Yeah I intentionally miss the URL. What I want to say is that the error logs currently contains usage: git remote add [<options>] <name> <url> usage: git clone [<options>] [--] <repo> [<dir>]
Which might make user confuse if they haven't used git that much u know @Cali0707

yeah good point, let's definitely capture this in a new issue then!
since this is a non-MacOS bug, do you think this PR is good to merge?


[SPARK-27094][YARN][branch-2.4] Work around RackResolver swallowing thread interrupt.

To avoid the case where the YARN libraries would swallow the exception and
prevent YarnAllocator from shutting down, call the offending code in a
separate thread, so that the parent thread can respond appropriately to
the shut down.
As a safeguard, also explicitly stop the executor launch thread pool when
shutting down the application, to prevent new executors from coming up
after the application started its shutdown.
Tested with unit tests + some internal tests on real cluster.

Test build #103920 has started for PR 24206 at commit 27db3bf.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9281/
Test PASSed.

Test build #103920 has finished for PR 24206 at commit 27db3bf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103920/
Test PASSed.

LGTM. Merged into branch 2.4 Thanks!


add demo notebook

includes use case context, scripts to convert individual label JPEGs to GeoTIFFs using .aux.xml files from initial tiff-to-jpg conversion and mosaicking those labels together (if they were tiled from a larger TIFF), and documents some issues (e.g. "ghost classes" that arise from some conversion step).

nice, thx @jmdelvecchio !


1 day prediction

Hi - Great work.

Why only a 1 day prediction ? Why not try to predict over a longer duration ? 2nd waves ?
Why not predict across multiple countries ?

Hi,

Kalman filter is an iterative model that means every timestamp (1 day in our case) it needs to get feedback of updated data. Then, the model update parameters estimation and can produce a prediction for the next time. Predictions for longer periods are more challenging as we don't get updated measurements along the way. But still can be done approximately by predicting the general trend with some calculated noise.
The model tracks each region as a separated time series but absolutely can be upgraded and improve estimation based on other regions' time series as well.
Regards,
Ran

Hi Ran - Do you want to chat offline ? I'm a prof. at a univ exploring the issue of 2nd waves. If you give me an email I'll reach out to you ? Thanks.

Sure.
<EMAIL_ADDRESS>


About the raw dataset of smarts

Thank you for opening source for the good and solid work!
It seems that the raw dataset is collected by the author themselves, but I didn't find a pkl file for the raw dataset in the code.  Could you provide the raw dataset pkl or the collection code?
Thanks again for your excellent work!

Sorry for late response. Due to my oversight, I missed uploading the smarts dataset. I will complete it by this Thursday (UTC+8).

Dataset Link: https://drive.google.com/file/d/1_KNH8EziubY2s3r6ySSSzLKnlXexInPp/view?usp=sharing. I will close the issue and feel free to reopen it if you have more questions.


Update find-and-release-quarantined-messages-as-a-user.md

@chrisda

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks

@faoquong Please update with the feedback. Thanks.


Desktop veiwing options.

Issue Type: Feature Request
Dear sirs
Unfortunatelly, I've got quite hard difficulties for seeing. In VS Code I haven't found any way to change desktop colors and font size. That's turning it almost impossible to read. I need to open magnifying window all the time.
Please, let me choose background color and font size, not only for code editing. I simply can't see what to do!
Thank you.
Regards,
Ciro.
VS Code version: Code 1.37.1 (f06011ac164ae4dc8e753a3fe7f9549844d15e35, 2019-08-15T16:16:34.800Z)
OS version: Darwin x64 17.7.0

Hi Ciro,
You can try-out a couple of things:

View > Appeareance > Zoom In / Out
Change the following settings 	"editor.fontSize"
F1 > Prefererences: Color Theme and you can choose the theme which suits you best.

Cheers


Removing extra spacing in remote-secure config

#sign-off

@SnehaGunda: I'm sorry - only the author of this article, @luisbosquez, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@GitHubber17 can you please merge this PR.


Fix golang-ci lint issues

most golang-ci lint issues are linked to the added functions in go stdlib in 1.21 versus 1.18

I think that we can disable linter via comment for these functions

I am correcting some of the issues... But other, like G107 (HTTP request made with variable url) can not be changed, as we want to provide to users the ability to choose. I will carrect when it seems possible and add //nolint elsewhere...

What do you think about fmt.Println errors ? I find  overkill to use a log lib for cli display...

@dvaumoron agree about Println issues; Let's use // nolint comment for such cases

If you need any help with golint issues, I will able to work on it today's evening

Everything seem ok on GitHub (my local installation of golangci-lint have a different behaviour, not digged why yet)

@dvaumoron I also have the different results locally, but now we have green master. Good work!


GET /user/list

List all users by user id. Only accessible to admins.

Seems to be implemented in a similar way to data/list in that it expects filters so really the endpoint is users/list/user_id/{ids} where {ids} is one or more comma-separated ids. See original source. From the description however, I would expect the endpoint to not take any parameters (query or path) and just return all users. Currently, if you access it with users/list then there is simply an internal server error.


[MSG] update last message timestamp with real data

Sister PR: https://github.com/artsy/metaphysics/pull/649
Related: https://github.com/artsy/collector-experience/issues/295

also, patience! :P haha

@mennenia lol word, got a bit ahead of myself, I'll push a change to that branch anyway

@l2succes nah man! not necessary to fix now, but was just trying to explain the reason I was asking. Let's just wait and see what the spec is ^_^


Pass modified database to doConvert if split db is true

Summary

Checklist
Delete items not relevant to your PR:

[ ] Unit and integration tests covering the common scenarios were added
[ ] A human-readable description of the changes was provided to include in CHANGELOG
[ ] For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I think we need tests for this, because looks like this case was missing from test.


Data source contributing docs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: vijaykiran:white_check_mark: m1n0:x: Janet RevellJanet Revell seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[Event Request] - OnValidateTransferFromCodeOnBeforeModify in Table 5700 "Stockkeeping Unit"

Hello, please consider adding the following event to Table 5700 "Stockkeeping Unit"
    [IntegrationEvent(false, false)]
    local procedure OnValidateTransferFromCodeOnBeforeModify(var StockkeepingUnit: Record "Stockkeeping Unit"; var IsHandled: Boolean)
    begin
    end;

and call it accordingly inside "OnValidate" trigger of the "Transfer-from Code" field:
            trigger OnValidate()
            var
                FromSKU: Record "Stockkeeping Unit";

                **IsHandled: Boolean;**

            begin
                FromSKU.SetRange("Location Code", "Transfer-from Code");
                FromSKU.SetRange("Item No.", "Item No.");
                FromSKU.SetRange("Variant Code", "Variant Code");
                if not FromSKU.FindFirst() then
                    "Transfer-Level Code" := -1
                else
                    "Transfer-Level Code" := FromSKU."Transfer-Level Code" - 1;
                FromLocation := "Transfer-from Code";

                **IsHandled := false;
                OnValidateTransferFromCodeOnBeforeModify(Rec, IsHandled);
                if not IsHandled then**

                    Modify(true);

                CheckTransferRoute();
            end;

Thank you!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 52804.


Increased maxResponseBytes to avoid NIOTooManyBytesError

Calling getPrinterAttributes to request "printer-description", "job-template" and "media-col-database" (as per example at https://www.pwg.org/ipp/ippguide.html#querying-the-printer-attributes ) on Simulated InkJet results in an NIOTooManyBytesError. Raised the hardcoded max value to 1 MB instead of 20 KB and made it an optional param.

thanks!


Add files via upload

@natnaeltadesse I close this request as a duplicate. The domain is already in the trusted list.


Ask for folder to deploy before asking for web app

For two reasons:

Creating a web app can take a while, whereas there's no long-running action after selecting the folder. Better to get all prompts out of the way first
The folder should be used to select smart defaults when creating the web app (Not a huge deal because this only matters if you have a multi-root workspace)

Need to watch out for Java case


README.md: add tab completion usage

How-to use bash, fish and zsh completions.

Thank you for the head start. README is not really the place for it, I feel. There are also a number of corrections needed. I’ll make the changes shortly, still credited to you.

Thank you for the contribution. It needed some fixes, so they were made in b5ccc39b173b3866971ba2b563997fd0c9c5afd3. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.

Glad this got merged :)


Context.CancellationToken

This issue starts with the question on how can I implement something like Timeout in Nancy.
Here is the twitter discussion. https://twitter.com/PrabirShrestha/status/371729596695457792
I personally think the NancyContext should contain CancellationToken property with getter and setters.
Before += Timeout(60 * 1000);

public void Timeout(int ms) {
    var oldCancellationToken = context.CancellationToken;
    var cts = new CancellationTokenSource();
    oldCancellationToken.Register(cts.Cancel);
    var ct = cts.Token;
    Task.Delay(ms, ct).ContinueWith(t => cts.Cancel());
    context.CancellationToken = ct;
}

@damianh @grumpydev something for 2.x and the TPL & await/async change?

Yes 2.x

I think this can be in 2.1 or after.


lavastuff/init.lua:113: attempt to index local 'def' (a nil value)

just happened
is version from d3a0da6/25.02.2022
but I didn't see solved issues this direction.
2023-02-10 21:01:58: ERROR[Main]:
ServerError: AsyncErr: Lua: Runtime error from mod 'lavastuff' in callback item_OnPlace(): ../mods/lavastuff/init.lua:113: attempt to index local 'def' (a nil value)
stack traceback:
../mods/lavastuff/init.lua:113: in function </home/thomas/minetest/bin/../mods/lavastuff/init.lua:106>
I even take new version and see your result in this one.

What were you doing when the crash was caused? I suspect another mod is using API functions incorrectly
You could try adding
if not def then minetest.log("error", "[lavastuff]: "..dump(pointed).." -|- "..dump(node)) return end

to line 112 if you want to temporarily fix the crash and send me info I could use to fix this

I have no idea who it has been, as at that time I am to bed - and sure all my local kids was off before
sure non of the advanced player as they report or ask what was wrong
lines now 121-123
activate_func(user, node.name, def, pointed)
if not def then minetest.log("error", "[lavastuff]: "..dump(pointed).." -|- "..dump(node)) return end
COOLDOWN:set(user, 1)
but not restart yet, I will remember this and look if triggered and post then.

That should be on line 112, not 121

Sorry for the late reply

d6d43a4828


[Patch/Bugfix] Supporting events detection for workers

Motivation/Description of the PR
Currently events from the steps are not exposed when parallel execution is done using workers. However, this is not the case for non-parallel execution where all the events are detected within a plugin.
Applicable helpers:

[ ] WebDriver
[ ] Puppeteer
[ ] Nightmare
[ ] REST
[ ] FileHelper
[ ] Appium
[ ] Protractor
[ ] TestCafe
[ ] Playwright

Applicable plugins:

[ ] allure
[ ] autoDelay
[ ] autoLogin
[ ] customLocator
[ ] pauseOnFail
[ ] coverage
[ ] retryFailedStep
[ ] screenshotOnFail
[ ] selenoid
[ ] stepByStepReport
[ ] stepTimeout
[ ] wdio
[ ] subtitles

Type of change

[ ] :fire: Breaking changes
[ ] :rocket: New functionality
[x] :bug: Bug fix
[ ] :clipboard: Documentation changes/updates
[ ] :hotsprings: Hot fix
[ ] :hammer: Markdown files fix - not related to source code
[ ] :nail_care: Polish code

Checklist:

[ ] Tests have been added
[ ] Documentation has been added (Run npm run docs)
[ ] Lint checking (Run npm run lint)
[ ] Local tests are passed (Run npm test)

@DavertMik - Fixed the UTs. Could you please merge this?

Thanks, let's have it!


Gossipsub: ignore duplicate publish errors

Motivation
Got PublishError.Duplicate errors at validator side even through it's a success. There are 2 reasons for it:

when publishing a block using buider flow, builder may already published that block and gossip block reached our node (see #5140)
when vc works with more than 1 beacon nodes, an item may reach one node first and spread across the network through gossipsub, when the other node calls gossipsub.publish() it throws PublishError.Duplicate error because it sees that item already through gossipsub (see #5098)

Description

ignoreDuplicatePublishError option was added to gossipsub through https://github.com/ChainSafe/js-libp2p-gossipsub/pull/404/files and included in gossipsub v6.2.0
Apply that to all publish*() APIs that come from vc

Closes #5140 #5098

:tada: This PR is included in v1.6.0 :tada:


new:usr:Improve RPM package with configuration and scripts

This commit adds

configuration files for bookkeeper and lds.
Start/Stop scripts
Sets up run, log and conf directories.

Tested using rubix-admin on Qubole clusters.

Done. I've removed HADOOP_CUSTOM_OVERRIDES and created #62 @stagraqubole


unable to install version 0.36, version 0.35 and below on multiple windows 7.  Error:  missing api-ms-win-core-winrt-string-l1-1-0.dll

Microsoft PowerToys version
0.35.0
Running as admin

[X] Yes

Area(s) with issue?
Installer
Steps to reproduce
Download version 0.35.0 and below and install it using admin rights from the download directory.  You'll get the same error message on windows 7.
✔ Expected Behavior
I'm expecting this program to be able to install on windows 7 since I've downloaded version 0.35.0 and below, but I get the same error message during installation.
❌ Actual Behavior
unable to install version 0.36, version 0.35 and below on multiple windows 7 x64.  Error:
"The program can't start because
api-ms-win-core-winrt-string-l1-1-0.dll is missing from your computer.
Try reinstalling the program to fix this problem."
I've even installed VC_redist.x64.exe
and
Windows6.1-KB2999226-x64.msu
Same error message.  I've googled.
I appreciate if someone can look into and fix this issue.
Thank you.
Other Software
No response

Hi @knowledgebaseglinux ,
PowerToys was never supported on Windows 7, AFAIK.
The minimum has always been some version of Windows 10.


UART and TWIM: Implement large buffer splitting and  check for readonly buffers in flash

Same type of changes as done for SPI.
I have not split up the dma transfer for: pub fn write_then_read()
it is not clear to me what assumptions can be made about read and write - for instance if a write and read always completes in sync or if all writes shall be done before data starts to be revived.
There have been no attempts to verify this change -- other than it is almost the same as I did for SPI.

@jamesmunns / @hannobraun / @Yatekii Should we try to do something about this change?
This patch includes the fail-if-DMA is not in RAM check and replaces the 255 limit on easy DMA by splitting it up in several if there is a limit.

Sorry, I don't have time to take a closer look right now. I've added it to my list.

@simonsso I tried to speed up discussions about the implicit copy and batching.
We did also think about possible compiletime solutions.
Maybe it should be merged for now and adapted later on (even tho I think we'll never adapt it then :P).
If @jamesmunns  and @hannobraun agree, I am ok with merging this for now if you fix the minor issue with bondary checks pointed out.
What do you think about this @jamesmunns @hannobraun? Appart from the ongoing issue about implicity, this seems to be sound otherwise (except for the minor issue pointed out by @somemetricprefix which can be fixed easily.).

Close in favor of #74 and #75


feat: implements labels using jsonb

Closes https://github.com/trustification/trustify/issues/273
Closes https://github.com/trustification/trustify/issues/160

@jcrossley3 added the migration and left a gap for https://github.com/trustification/trustify/pull/444

I made the change anyway, I hope we can merge it now.


Moves 'spo folder copy' to new endpoint

Closes #6310

Ready to merge 🚀

Merged manually. Thank You 👏👏👏👏


Safari transition seems not working properly with complex interface

This is bug in iOS 10 Simulator for iPhone 7 / 7 Plus. Still exist at 03-25-17


Failing with Intl plugin upgrade to 16.0.0

I am using the older version on Intl and Intl_translation. But When I am trying to upgrade these plugins to latest version its conflicting with flutter_paystack and showing that version solving failed.
Your plugin requires  intl: ^0.15.7. Can you please upgrade it to 16.0.0 and push the plugin
Could you please upgrade the plugin asap
Thanks

I  just bumped the dependencies. Please, can you give it another try?

Since there has been no activity here for some time now, I will be closing this issue.
Please, feel free to reopen it if you are still experiencing the issue.


Kafkajs consumer not receiving messages

Hello everyone, I'm using kafkajs v1.12.0 with an AWS MSK cluster
my producer code looks like this:
const kafkaClient = new KafkaClient({
    clientId: KAFKA_CLIENT_ID,
    brokers: process.env.KAFKA_BROKERS_URLS.toString().split(','),
    connectionTimeout: 10000,
});

const producer = kafkaClient.producer({
    allowAutoTopicCreation: true,
    createPartitioner: Partitioners.JavaCompatiblePartitioner,
});

producer.on(CONNECT, e => logger.info(`Producer connected at ${e.timestamp}`));
producer.on(DISCONNECT, e => logger.info(`Producer disconnected at ${e.timestamp}`));
producer.on(REQUEST_TIMEOUT, e => logger.warn(`Producer request timed out at ${e.timestamp}`, JSON.stringify(e.payload)));

try {
await producer.connect();
await producer.send({
  topic: 'my-topic',
  compression: CompressionTypes.Snappy,
  messages,
});
} catch (err) {
	logger.error(err)
}

After publishing messages, my RecordMetadata looks like:
[ { topicName: 'my-topic', partition: 0, errorCode: 0, baseOffset: '37182', logAppendTime: '-1', logStartOffset: '0' } ]

in a different application my consumer code looks like this:
const kafkaClient = new KafkaClient({
    clientId: KAFKA_CLIENT_ID,
    brokers: process.env.KAFKA_BROKERS_URLS.toString().split(','),
    connectionTimeout: 10000,
});

const consumer = kafkaClient.consumer({
    groupId: KAFKA_CONSUMER_GROUP,
    allowAutoTopicCreation: false,
});

const { CONNECT, DISCONNECT, GROUP_JOIN, CRASH, REQUEST_TIMEOUT, STOP } = consumer.events;
consumer.on(CONNECT, e => logger.info(`A Consumer from Consumer Group (${KAFKA_CONSUMER_GROUP}) connected at ${e.timestamp}`));
consumer.on(DISCONNECT, e => logger.info(`A Consumer from Consumer Group (${KAFKA_CONSUMER_GROUP}) disconnected at ${e.timestamp}`));
consumer.on(GROUP_JOIN, e => logger.info(`A Consumer (${e.payload.memberId}) joined the Consumer Group (${e.payload.groupId}) at ${e.timestamp}`, `LeaderId=${e.payload.leaderId}`));
consumer.on(CRASH, e => logger.error(`A Consumer from the Consumer Group (${KAFKA_CONSUMER_GROUP}) crashed at ${e.timestamp}`, e.payload.error));
consumer.on(REQUEST_TIMEOUT, e => logger.warn(`Consumer request timed out at ${e.timestamp}`, JSON.stringify(e.payload)));
consumer.on(STOP, e => logger.info(`Consumer stopped`, JSON.stringify(e)));

try {
	await consumer.connect();
	await consumer.subscribe({ topic: 'my-topic', fromBeginning: false });
	await consumer.run({
	    eachMessage: async ({ topic, partition, message }) => { // This was never executed.
	      logger.info(`------ Debugging getMessages function`);
	      const messageAsJson: EventMessage = JSON.parse(message.value.toString());
	      await this.saveData(messageAsJson);
	    },
	})
} catch (err) {
	logger.error(err)
}

My consumer logs are:

A Consumer from Consumer Group (kirby-for-web) connected at<PHONE_NUMBER>445
A Consumer (gid-7d97643a-70a1-480b-8dad-823e8c23b9e3) joined the Consumer Group (kirby-for-web) at<PHONE_NUMBER>467 LeaderId=gid-3e1347af-22d2-4456-bb87-f42837104ef6
A Consumer (gid-3e1347af-22d2-4456-bb87-f42837104ef6) joined the Consumer Group (kirby-for-web) at<PHONE_NUMBER>470 LeaderId=gid-3e1347af-22d2-4456-bb87-f42837104ef6

For further inspection I tried getting the topics meta data with the admin and this was the result
{ topics: [ { name: 'my-topic2', partitions: [ { partitionErrorCode: 0, partitionId: 0, leader: 4, replicas: [ 4, 3, 2 ], isr: [ 4, 3, 2 ], offlineReplicas: [] } ] }, { name: 'my-topic', partitions: [ { partitionErrorCode: 0, partitionId: 0, leader: 1, replicas: [ 1, 4, 3 ], isr: [ 1, 4, 3 ], offlineReplicas: [] } ] } ] }

I could see Network RX/TX packets traffic in the AWS brokers

I'm not sure why the eachMessage function was never executed so I wasn't able to receive the messages in the consumer

Just to make sure, you don't have any ACLs applied on the topic that would prevent you from reading from it? Also, are you continuously producing messages from your producer? Otherwise with fromBeginning set to false your consumer will start from the end of the topic if there is no other committed offset to resume from for that group.
You can run your consumer with debug log level to get more information on what your consumer is up to: https://kafka.js.org/docs/configuration#log-level

@Nevon Thanks for helping out, I finally found the issue.
I was using the same consumer group (using the same groupId) to consume two different topics,
due to this, I wasn't receiving messages in either of them.
After using a unique groupId my code is working. (I wonder if the kafkajs can be noisy about this issue)

@Nevon I wonder why we cannot fetch messages from different topics in the same consumer group?
if it is intentional can we mention this in the documentation or be noisy about it (throw an error)

Well, the concept of a consumer group in Kafka is that you have multiple identical nodes that together form a group. It doesn't make sense from a Kafka conceptual point of view not to.
We do emit a  warn log about this if we receive assignments for topics that we aren't subscribed to, because that's the only way we can find out that you are doing this.


mlPerBucket can't be < 0

Some mods can't allow the fluid buckets with blow 0 ml fluid, it will get carsh, such as PneumaticCraft: Repressurized.
Caused by: java.lang.IllegalArgumentException: mlPerBucket can't be < 0!
    at me.desht.pneumaticcraft.common.PneumaticCraftAPIHandler.registerFuel(PneumaticCraftAPIHandler.java:114)
    at me.desht.pneumaticcraft.common.fluid.FluidFuelManager.registerFuels(FluidFuelManager.java:12)
    at me.desht.pneumaticcraft.PneumaticCraftRepressurized.postInit(PneumaticCraftRepressurized.java:184)

Should be fixed in alpha release 2.0.1, can you confirm?

Considered fixed due to lack of response.


[RCORE] makedir does not compile on linux.

the recent change as part of commit https://github.com/raysan5/raylib/commit/100f6624d62d29638fc7174f41a6cba1548fb3e2
does not compile on linux
❯ make
==== Building raylib (debug_x64) ====
Creating obj/x64/Debug/raylib
raudio.c
In file included from ../external/raylib-master/src/raudio.c:270:
../external/raylib-master/src/external/jar_xm.h:242:9: warning: "DEBUG" redefined
  242 | #define DEBUG(...)
      |         ^~~~~
<command-line>: note: this is the location of the previous definition
rcore.c
../external/raylib-master/src/rcore.c: In function ‘MakeDirectory’:
../external/raylib-master/src/rcore.c:210:25: error: too few arguments to function ‘mkdir’
  210 |     #define MKDIR(dir)  mkdir(dir)  // OLD: mkdir(dir, 0777) -> w64devkit complaints!
      |                         ^~~~~
../external/raylib-master/src/rcore.c:2299:48: note: in expansion of macro ‘MKDIR’
 2299 |                 if (!DirectoryExists(pathcpy)) MKDIR(pathcpy);
      |                                                ^~~~~
In file included from ../external/raylib-master/src/rcore.c:178:
/usr/include/sys/stat.h:389:12: note: declared here
  389 | extern int mkdir (const char *__path, __mode_t __mode)
      |            ^~~~~
../external/raylib-master/src/rcore.c:210:25: error: too few arguments to function ‘mkdir’
  210 |     #define MKDIR(dir)  mkdir(dir)  // OLD: mkdir(dir, 0777) -> w64devkit complaints!
      |                         ^~~~~
../external/raylib-master/src/rcore.c:2306:36: note: in expansion of macro ‘MKDIR’
 2306 |     if (!DirectoryExists(pathcpy)) MKDIR(pathcpy);
      |                                    ^~~~~
/usr/include/sys/stat.h:389:12: note: declared here
  389 | extern int mkdir (const char *__path, __mode_t __mode)
      |            ^~~~~
make[1]: *** [raylib.make:186: obj/x64/Debug/raylib/rcore.o] Error 1
make: *** [Makefile:54: raylib] Error 2

@JeffM2501 Yeap, I'm trying to solve it but it seems more complicated than expected... 😞

some systems are not defining linux it seems and falling back to the mingw code.
I this works in WLS but we have reports of it not working on other systems. I wonder if there is a different #define to check?

@JeffM2501 It should be already solved.


The iscsid daemon does not start on Ubuntu 18.04

Describe the solution you'd like
I set up Ubuntu 18.04 according to the following documentation.
https://github.com/NetApp/trident/blob/master/docs/kubernetes/operations/tasks/worker.rst
NetApp/Trident installation succeeds. However, a volume is not mounted on Pod.
Because, it is necessary to discover target port with iscsiadm command before starting open-iscsi service in Ubuntu 18.04. If you do not do this, the iscsid daemon will not start.
This was not needed in Ubuntu 16.04.
Please see the Ubuntu documents.
https://help.ubuntu.com/lts/serverguide/iscsi-initiator.html
Could you fix the documentation on the correct setup method for Ubuntu 18.04?

At the top of that worker.rst page it states "All of the worker nodes in the Kubernetes cluster need to be able to mount the volumes that users have provisioned for their pods."
If you follow those instructions and try to mount volumes from your eventual iSCSI portal, you have to run iscsiadm discovery. That hasn't changed and isn't new - it was the same way in Ubuntu 16.04 and before (see https://github.com/open-iscsi/open-iscsi/blob/master/README).
My guess is before (with Ubuntu 16.04) you had already used the same portal prior to using Trident, so the only difference is you didn't notice that you had to do that step and incidentally, you could skip it without noticing that.

The difference point between Ubuntu 16.04 and 18.04 is the configuration of systemd.

/etc/systemd/system/iscsi.service (Ubuntu 16.04)

[Unit]
Description=Login to default iSCSI targets
Documentation=man:iscsiadm(8) man:iscsid(8)
Wants=network-online.target remote-fs-pre.target iscsid.service
After=network-online.target iscsid.service
Before=remote-fs-pre.target
DefaultDependencies=no
Conflicts=shutdown.target
Before=shutdown.target

[Service]
Type=oneshot
RemainAfterExit=true
# iscsiadm --login will return 21 if no nodes are configured,
# and 15 if a session is alread logged in (which we do not
# consider an error)
SuccessExitStatus=15 21
# iscsiadm will only work if iscsid is running. But we can't use a
# Requires= dependency, since restarts of iscsid would then be
# propagated to this service - and that would cause all sorts of
# mayhem. Therefore, check it in ExecStartPre.
ExecStartPre=/bin/systemctl --quiet is-active iscsid.service
ExecStart=/sbin/iscsiadm -m node --loginall=automatic
ExecStart=/lib/open-iscsi/activate-storage.sh
ExecStop=/lib/open-iscsi/umountiscsi.sh
ExecStop=/bin/sync
ExecStop=/lib/open-iscsi/logout-all.sh
...

/etc/systemd/system/iscsi.service (Ubuntu 18.04)

[Unit]
Description=Login to default iSCSI targets
Documentation=man:iscsiadm(8) man:iscsid(8)
Wants=network-online.target remote-fs-pre.target
After=network-online.target iscsid.service
Before=remote-fs-pre.target
DefaultDependencies=no
Conflicts=shutdown.target
Before=shutdown.target
# Must have some pre-defined targets to login to
ConditionDirectoryNotEmpty=|/etc/iscsi/nodes
# or have a session to use via iscsid
ConditionDirectoryNotEmpty=|/sys/class/iscsi_session

[Service]
Type=oneshot
RemainAfterExit=true
# iscsiadm --login will return 21 if no nodes are configured,
# and 15 if a session is alread logged in (which we do not
# consider an error)
SuccessExitStatus=15 21
# Note: iscsid will be socket activated by iscsiadm
ExecStart=/sbin/iscsiadm -m node --loginall=automatic
ExecStart=/lib/open-iscsi/activate-storage.sh
ExecStop=/lib/open-iscsi/umountiscsi.sh
ExecStop=/bin/sync
ExecStop=/lib/open-iscsi/logout-all.sh
...

Therefore, the iscsid doesn't work on Ubuntu 18.04 by just setting the NetApp/Trident documentation.
https://netapp-trident.readthedocs.io/en/latest/kubernetes/operations/tasks/worker.html#iscsi
As you know, we need to run iscsiadm discovery or change /etc/systemd/system/iscsi.service.
So, I think the better way is update the document for all trident user.

The documentation will be updated with the Trident 20.07 release.


OPENSSL_showfatal uses the fmt variable uninitialized

In OPENSSL_showfatal (openssl/crypto/cryptlib.c), when it si defined STD_ERROR_HANDLE, the first call to _vsnprintf uses the variable fmt uninitialized, causing a failure of the library.

Which OpenSSL version are you refering to?

It is the FIPS stable version. In particular this file:
https://github.com/openssl/openssl/blob/OpenSSL-fips-2_0-stable/crypto/cryptlib.c

Around line 300 of cryptlib.c:
len=_vsnprintf((char *)buf,sizeof(buf),fmt,ap);

Should be "fmta" instead of "fmt"
len=_vsnprintf((char *)buf,sizeof(buf),fmta,ap);

ping @snhenson

This was already fixed in the dev branch.
https://github.com/openssl/openssl/commit/493119b1a81ccd447a88654cbc95aaab73289d85
https://github.com/openssl/openssl/blob/OpenSSL-fips-2_0-dev/crypto/cryptlib.c


Resize Month Events and Resize Week/Day Events on Both Ends

Description
This PR adds the ability to resize month events as well as resize week/day events on both ends, top and bottom. I wasn't able to get this to perform correctly on hover which I suppose is ideal. We might find inspiration from #577.
This is a long standing issue so it would be good to see some movement on this.
Also, I think this could be a good first implementation that is refined on going forward.
Screenshots
Month

Week

Issues
#382
PRs
#577, #541, #406

I did not mean to push this to master. My mistake.

Actually, I think I will keep this open

@arecvlohe @jnmandal any idea if this excellent feature you guys added is going to get merged into the project?

@svanetten1976 I don't have a good idea. @jquense might know better than me. I don't really know what/how things get vetted and merged.

looking great!

@jquense Thanks for taking a look at this some more and making comments! I will try and work on it this weekend and push some updates. Anyone else feel free to take this up and push it forward if you have time.

@jquense Howdy! I made changes based on your comments. Please let me know if this works and if I need to make any more changes!

@jquense I made the requested changes. Let me know if there is anything else I need to do!

Any progress here?

Nope, waiting on updates

There are only 2 small conflicts in examples/events.js. @arecvlohe please, can you take a look?

I'm wondering, why DnD behavior for top dragging and bottom dragging is different (see second "week" gif in description)?

If you drag top side of event, new position will be set to highlighted cell exactly
But if you drag bottom side, new position will be set to a previous cell before highlighted one
Why?

I will take a look @AlexMarvelo at what you are referring to.

Thanks for the work guys! We are really looking forward to building this into our app here at DNSFilter once changes are approved.

I have been busy the past few weekends so I should be able to get to it this weekend (12/09/2017). Or during the week if I feel up for it 😄

Can someone show me how to merge these conflict and get them into my local branch?

Everytime I think I have resolved them it still keeps showing them as conflicts

@AlexMarvelo I think I addressed your issue with the dnd bottom. I think the information coming back from the hover event is off by 30 min so I added 30 min.

Okay, I think I got it

Let me know what else I need to do.

:thumbsup: Bottom DnD looks good for me now

But all-day event's behavior sometimes seems unexpectable.

All-day items can be resized horizontally only. Vertical resize is disabled
Right/left side icon should be a horizontal arrow, not vertical

Do you agree, that all-day items should be more similar to items on month tab?
@arecvlohe I can help and open a PR to your fork if you want

@AlexMarvelo Ah I did not notice that behavior and I agree it is unexpected. Sure, If you can work on this feel free to fork and make changes!

@AlexMarvelo I made an update based on your recommendation but I am not sure if it is a good solution. I think I am missing some things. Let me know what you think!

@jquense @AlexMarvelo How are things looking?

The changes look good to @jquense so if I don't hear from @AlexMarvelo in the next couple days I will merge this on Thursday (12/21/2017) before the holiday break.

@arecvlohe can you also please update the Changelog (you can put the entries in an unreleased heading)

Hello
Unfortunately, I still see the same issue

Sometimes vertical arrow icon appears on hover for all-day items. To change the duration of all-day item (vertical resize) seems not clear to me
A short draggable line sometimes appears on all-day items. I think it shouldn't

I guess in some cases vertical arrow icon should be replaced with horizontal. Will check out the code and give more details tomorrow

Ah I see, I will check it out some more tonight @AlexMarvelo

@AlexMarvelo I am a little lost in terms of trying to fix this. DayColumn is not passing any information related to the events. I am not sure why this is happening.

Just started using the resize/DnD stuff - thanks @arecvlohe & others - hugely useful!
tl;dr: I'm looking for advice on how to best marry DnD with custom components.
When creating the underling calendar, it looks like the addon's withDragAndDrop HOC overwrites a bunch of component: props to add DnD. Alas, I have a custom Event component in day/week/month views (and in a custom view), so this is a bit of a challenge.
Would something like this make sense:
   const DnDCalendar = withDragAndDrop(BigCalendar)
   <DnDCalendar
     components={{
       week: {
         event: myCustomEventComponent
       }
     }}
   />

becomes instead:
   <DnDCalendar
     components={{
       week: {
         event: withDragAndDrop.customComponent(myCustomEventComponent)
       }
     }}
   />

The new HOC would wrap the user's components with one based on the current ResizableEvent (yes, there would have to be a month view variant, too).
I'm keen to get folks' other ideas/approaches (or validation of this one). I'm probably misunderstanding the DnD philosophy, but it was a surprise to see examples/dnd basically overwrite custom component props.
thx for any guidance/advice.

I think that no more additional work should be required to enable DnD except wrapping the calendar with withDragAndDrop. It's  the best practice. I will take a look, what can be done. I see, that DnD addon does not really take care of custom event renderer now.