Gather.ps1 - link broken

Hello MS Team,
The link to the Gather.ps1 script is broken and I could not find it on the search as well on the landing page of that current link.
Please see if this can be fixed.
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: af8c59c3-65e9-1e4c-f78d-8d2770e88690
Version Independent ID: 0d0b65d8-5026-8232-5658-561d88cc2065
Content: Simulate a Windows 10 deployment in a test environment (Windows 10) - Windows Deployment
Content Source: windows/deployment/deploy-windows-mdt/simulate-a-windows-10-deployment-in-a-test-environment.md
Product: w10
Technology: windows
GitHub Login: @greg-lindsay
Microsoft Alias: greglin

@ksaib . broken link is conformed by me also.

I can't find a link in the article to Gather.ps1, it just lists the contents of such file in a Text area for the reader to copy into a file with this name. Also the link provided by @RAJU2529 is not authored by Microsoft and is different from the Gather.ps1 described in this article.

Thanks for the feedback @ksaib! This was fixed in PR 5965, so I'm closing this issue.


Scaling the interface on iOS (pinching) feels weird

Location
Everywhere
Expected behavior
I cannot scale the interface, like with a webpage, as this destroys my feeling of it being an app instead of a webpage
Actual behavior
I can pinch to zoom in on the interface. Sometimes I can double tap to zoom in.
Steps to reproduce the problem
Pinch, double tap
Operating system / hardware
iOS / havent tested android

@kikipluche I wasn't able to reproduce it with latest code. Can you test and let me know if the issue still exists?

Transaction: 0x555555eee8e827a3439a9040538d7b6e40264c90662a314b2de3a55a54eaaa8f


adding link to LRNWebcomponents which contains HAX and more

Added link to LRNWebcomponents which contains HAX and 100s of other openly available, primarily Lit based elements.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Open
On 5/5/22, CLAassistant @.***> wrote:

Thank you for your submission! We really appreciate it. Like many open
source projects, we ask that you sign our Contributor License
Agreement before
we can accept your contribution.You have signed the CLA already
but the status is still pending? Let us
recheck
it.
--
Reply to this email directly or view it on GitHub:
https://github.com/open-wc/open-wc/pull/2446#issuecomment-1118932622
You are receiving this because you are subscribed to this thread.
Message ID: @.***>


start up with docker compose fail.

Environment
docker version:
Docker version 20.10.12, build e91ed57
root@iZj6c8znm5l1ysn7c1dxstZ:/data/ada/cardano-graphql# DOCKER_BUILDKIT=1 \
> COMPOSE_DOCKER_CLI_BUILD=1 \
> RESTORE_SNAPSHOT=https://update-cardano-mainnet.iohk.io/cardano-db-sync/12/db-sync-snapshot-schema-12-block-6764999-x86_64.tgz \
> docker-compose up -d --build &&\
> docker-compose logs -f
ERROR: yaml.scanner.ScannerError: while scanning a plain scalar
  in "./docker-compose.yml", line 31, column 21
found unexpected ':'
  in "./docker-compose.yml", line 31, column 57
Please check http://pyyaml.org/wiki/YAMLColonInFlowContext for details.
root@iZj6c8znm5l1ysn7c1dxstZ:/data/ada/cardano-graphql#

[PASTE_REPORT_HERE]
Alternatively, what release or Git revision are you using:
Platform

[√ ] Linux / Ubuntu
[ ] Linux / Other
[ ] macOS
[ ] Windows

Platform version:
Runtime

[ ] Node.js
[√ ] Docker

Runtime version:
 node -v
v16.14.0
docker version

Steps to reproduce the bug
1
git clone   --single-branch   --branch 6.2.0   --recurse-submodules   https://github.com/input-output-hk/cardano-graphql.git   && cd cardano-graphq
2
DOCKER_BUILDKIT=1 COMPOSE_DOCKER_CLI_BUILD=1 RESTORE_SNAPSHOT=https://update-cardano-mainnet.iohk.io/cardano-db-sync/12/db-sync-snapshot-schema-12-block-6764999-x86_64.tgz docker-compose up -d --build &&docker-compose logs -f
What is the expected behavior?

See: Getting started with Cardano GraphQL

I also encountered this problem, maybe you can update your docker-compose to version 1.25.4?After update docker-compose from version 1.17.1 to 1.25.4 then it worked.


Provide complete Docker image for ease of use

The tutorial code and dependencies could be deployed via Docker to enable testing on Android. Currently many people are unable to successfully setup an Android development environment for use with appium.

I can contribute with another appium docker image:
https://registry.hub.docker.com/u/davidbaena/appium
You could set up several appium servers giving bootports, ports and Device as a parameters at start time:
$ docker run -d --privileged -v /dev/bus/usb:/dev/bus/usb -e appium_args="-p 4723 -bp 2251 -U 32456"  -p 4723:4723 davidbaena/appium

$ docker run -d --privileged -v /dev/bus/usb:/dev/bus/usb -e appium_args="-p 4724 -bp 2252 -U 43364" -p 4724:4724 davidbaena/appium

This image is updated with the latest appium version.

awesome! maybe we need an appium docker repo so people can find these images easily.

Thats not a bad idea. We can link to it in the docs.

:+1:

I have written a tutorial on this,
https://github.com/vbanthia/appium-docker-test
It will great to get some feedback :)

@aluedeke or anyone that can answer my question: Given that I have never used Appium before, I have a WhatsApp.java test file, I have a running container of the image you created (aluedeke/appium-android), and I have an Android device pluged into the computer. How do I run that test on that container?. Im using Ubuntu.


gl-matrix in jspm/es6 registry

I'm starting a "modern" webgl project, i.e. es6, jspm/babel, modules etc.  This lead me to look into getting webgl basic libraries available as es6 modules via jspm.io.
We've gotten Khronos' webgl-debug converted (refactored repo w/ DevTools branch, semver versioning).
Next, matrices.  I noticed gl-matrix is module ready, broken into vec2,2d,3,4; mat2,3,4; quat but also noticed stack.gl has (an older?) refactored gl-matrix .. even into function decomposition.
The issue/question is: would it be best for me to simply jspm-ify using this repo's refactored modules, as well as the gl-matrix "bundled" module? Or is there a reason to defer to stack.gl?
I could put it into the jspm registry as well, making it easier for es6 import/export use.
No changes are needed for the code. Jspm simply knows how to directly convert npm & github repos into es6 modules. Doing it locally looks like:
bundle: jspm install gl-matrix=github:toji/gl-matrix -o "{main:'src/gl-matrix.js'}"
individual: jspm install gl-mat4=github:toji/gl-matrix -o "{main:'src/gl-matrix/mat4.js'}"
I'll experiment locally, but after no hitches, would it be OK to convert to the public registry?

Oops, looks like I don't have the jspm install commands quite right.  I'll get back to you after a chat with the jspm folks.

I'm closing this for now. StackGL is not attempting, AFAIK, to track recent version.  So...

I'll simply use the dist/*.js & *.min.js builds locally via jspm install.
When I'm comfortable with this, I'll submit it to the jspm registry for CDN style access
If I can wrap my head around webpack-jspm integration, I'll submit the refactored regestry entries when I'm sure local usage is correct.


Fix cursor oddness

Especially on large documents it seems to me like the cursor is always detected a bit to the left

Duplicate of #142, oops


WFLY-16974 Upgrade to Hibernate ORM 6.1.4 to resolve test failures with security manager

https://issues.redhat.com/browse/WFLY-16974
This change enables to tests that were previously excluded when run with the Java security manager.
To run tests that previously failed with earlier Hibernate ORM versions:
cd wildfly/testsuite/integration/basic
mvn clean test -Dtest=SessionFactoryTestCase -Dsecurity.manager
mvn clean test -Dtest=EntityTestCase -Dsecurity.manager

No JPA tests failed in this test run.

WebJPATestCase failure looks legit, looking into that.

That's been happening a lot for quite a while now, often enough that we need a JIRA to fix it and perhaps to @Ignore it.
https://ci.wildfly.org/project.html?projectId=WF&buildTypeId=&tab=testDetails&testNameId=-2956571154730036622&order=TEST_STATUS_DESC&branch_WF=__all_branches__&itemsCount=50
I thought I'd filed a JIRA but I don't see one.

The Linux - JDK 11 job failed, but clustering ts has been problematic lately.
https://wildfly.zulipchat.com/#narrow/stream/174184-wildfly-developers/topic/Clustering.20failures
That job got ok results on an earlier run and I believe the latest runs are just testing a change the removed some commented out code lines in a test class.


Can't seem to access tables not on "public"

Hi there,
I recently started a new instance on Heroku, but I'm not able to access tables under schemas other than public. For example, I'm trying to access a table named event on a schema named blanket, but I get this error on the Rows tab:

ERROR: pq: relation "public.event" does not exist

Has anyone seen this issue before? Happy to share more information if needed.
Thanks in advance.

Which version of pgweb are you using ?

@sosedoff I used the "Deploy to Heroku" button, so I'm guessing I'm on the latest version.

I'll have a look

@ric2z  is this still an issue for you? i tried to replicate your setup, but i had no problem seeing different schemas in my test db on heroku.

Same here:
Pgweb v0.10.0 (git: 54da27ef70b1d2ae9297cc5ea65158148b36107d)

The schema and its tables do appear in the left sidebar, but if I click one of them, instead of seeing the table's contents, I get an error:

ERROR: pq: relation "public.tablename" does not exist

Indeed it doesn't, because tablename is not in the public schema.

Finally was able to replicate the issue on my machine. There's a bug with row estimation query that causes this error. Will fix.

This issue has been fixed, please upgrade to 0.11.0


Linebreak after added textnode

Originally eported by @shtse8
Code to reproduce
$doc = FluentDOM('

', 'html-fragment');
$doc->html(FluentDOM('hihi', 'html-fragment'));
echo $doc;

Expected Result:

hihi

Actual Result:

hihi

@shtse8 You're really good at finding edge cases. :-)
What happens is that DOMDocument::saveHtml() usually saves HTML document with a linefeed at the end. I changed that method because of the multibyte problems, but added  the linefeed if no context node was provided.
In your case the document end up with a single text node, this document is saved as HTML and the linefeed was added. I added some conditions to avoid that.
https://github.com/FluentDOM/FluentDOM/commit/79ad39ae4e9fd96251d53571582fbb40d95b7250


Fix client code gen to use efficient symbol

What
Change the client generated code to use the efficient compile time const Symbol generation for contract invocation function names when the function names are small enough.
Why
The client is intended to be a zero-cost abstraction when compared with invoking a contract with env.invoke_contract(cid, fn, args), but currently it is ~200 bytes more expensive in WASM size. This is because the generated client code is using runtime conversion from a &str to a Symbol for all symbols, even small ones that can be converted to a Symbol at compile time using const expressions.
This change reduces the size of contracts using a single short symbol by ~200 bytes.
Close #1290

@kalepail this is released in v21.2.0.


Show required asterisks for required descendant blocks of required streamfields

Fixes #5983; possibly also has a bearing on #4306. A CSS rule dating from the original StreamField design was hiding the 'required' asterisk on fields within a required StreamField, presumably on the mistaken belief that they duplicate the information given by the top-level asterisk on the streamfield. (In #5983 this was reported as a regression in 2.7 when the react-streamfield CSS was introduced, so it's possible that the old design had something to mitigate this, e.g. an asterisk being inserted elsewhere.)

Merged in 23096b9f733292432b5ad66c1e44659f907dd360

Merged in 23096b9f733292432b5ad66c1e44659f907dd360


Correct off by one error with the range header.

As per https://github.com/moby/buildkit/issues/2568 and https://github.com/docker/for-linux/issues/1296, the header being off by one is an issue when using BuildKit's buildctl command as the manifest contains the wrong size - being one too large which then fails when trying to read one byte too many from the image.
The issue can be seen when viewing the manifest in the registry data:
In the layers payload:
  ...
  "size": 894478744,
  "digest": "sha256:929d4d417adbdafe947076e47161e10f88afcb63716ff7ec3205bc8f62be085f"

Whilst a du -b of the blob 929d4d417adbdafe947076e47161e10f88afcb63716ff7ec3205bc8f62be085f is actually 894478743.
The error doesn't present when using the Docker daemon to build (using BuildKit or not) as it doesn't check this size. It needs to be the buildctl directly.
Note that buildctl caches the manifest data from the first place the image was pulled from, so pulling from a broken registry and then an unbroken one; the build will still fail. The error in buildctl is:
/moby.buildkit.v1.Control/Solve returned error: rpc error: code = Unknown desc = failed to compute cache key: failed to read expected number of bytes: unexpected EOF

Or
error: failed to solve: failed to compute cache key: failed commit on ref "layer-sha256:929d4d417adbdafe947076e47161e10f88afcb63716ff7ec3205bc8f62be085f": "layer-sha256:929d4d417adbdafe947076e47161e10f88afcb63716ff7ec3205bc8f62be085f" failed size validation: 894478743 != 894478744: failed precondition

Depending on the version of buildctl.

Having never written any Rust, this is probably not the best way to solve this :-D So feel free to adjust as needed - but I wanted some code to test with. With this change buildctl now builds correctly.
I think the change to upload_info.rs fixes the issue we saw, but saw the repetition of the issue so changed it too.
Also, thanks for all the work you do with Trow, it's been great for us :-)
(https://github.com/distribution/distribution/blob/main/registry/handlers/blobupload.go#L346 is the equivalent off-by-one handling in the Docker Distribution registry, as a note.)

Ah, I've hit this before! I wondered what was going on - I ended up having to edit manifests directly.

(Just repushed with a formatting fix that I hadn't notice (which was why the tests failed))

Let me see if I can come up with a test for this and I'll get it merged as soon as I can. I'm a little busy today, so it might be Monday.

Looking at this now. You're absolutely right about the problem, but I think it's probably better to fix on the ContentInfo level, so that the responses don't need to change the data. I should even be able to put in a check that the max range < length.

Fixed in #304
Big thanks for the report, apologies for not using the PR.

Also, please test and open an issue if you hit any problems.

Fixed in #304
Big thanks for the report, apologies for not using the PR.

Absolutely no issue at all :-) I can definitely see how fixing it in blob is the better solution :+1:


Finops

Nice post! I think you might find infracost tool interesting, as it might help forecasting infrastructure change costs before even applying them. There is even a GH action for displaying price change in PR review.
That being said, I'm a bit concerned about blurred out prices from reports - It's possible to restore image after gaussian blur, with e. g. Richardson-Lucy deconvolution algorithm. I think black bars, although less aesthetically pleasing, are better suited for redaction

infracost too: Try to think what kind of costs it could predict? And what is a major costs for data pipelines. The tool is not able to forecast anything particular interesting for data pipelines IMHO.
restore blur: there are many easier methods to get real numbers than de-gaussian :) Have you read kevin mitnick?


ConnectionManager too bloated

That is currently the ConnectionManager class: it stores the code and can update and modify it (for the modifications it depends on the Modifier class obviously).
My idea would be having something like an Editor class that does all of this:
class Editor:
    def __init__(...):
        self.code = ...
        ...
    def update_code_cache(...):
        ...
    def modify_code(...):
        ...

Originally posted by @kappq in https://github.com/Vthechamp22/kindly-kappa/pull/35#discussion_r932702321
Separating any and all of the code/cache logic from the connection manager makes much more sense than keeping them together.

I was thinking about creating a Room class instead.
What brought me to this thought was the difficulty of the room: it seems like the ConnectionManager isn't supposed to hold the information, but at the same time, the editor shouldn't as well.
So here comes the Room class: it would hold all the information related to a room (e.g. owner ID, clients, etc. Basically what ActiveRoom currently has) plus the code and the methods to manipulate it.
Let me know what you think about this.

I was thinking about creating a Room class instead.
What brought me to this thought was the difficulty of the room: it seems like the ConnectionManager isn't supposed to hold the information, but at the same time, the editor shouldn't as well.
So here comes the Room class: it would hold all the information related to a room (e.g. owner ID, clients, etc. Basically what ActiveRoom currently has) plus the code and the methods to manipulate it.
Let me know what you think about this.

Yes, I guess from your original example, the Editor here would be deemed as a subclass of the Room. This looks better.


Rd 8832 implement http request response body attribute size capping in

:tada: This PR is included in version 1.1.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


IME Support

When using input methods such as Chinese or Japanese, the native IME UI is not displayed.Is there any plan to add IME support?

Support for IME is not planned.

Thanks for the reply.
But I searched and found that to enable IME support, you only need to upgrade the SDL2 library and set the SDL_HINT_IME_SHOW_UI of the SDL2 library to 1:
SDL_HINT_IME_SHOW_UI
SDL2Fix
This is much more convenient for non-English users.


Income From Last Month: wrong amount

Name of Defective Feature

Income From Last Month

System Settings (Required)

ToolKit Version: 2.7.2
Operating System (Mac/Windows/Etc): Windows 10
Browser (Chrome/Firefox/Safari): Firefox Nightly
Browser Version: 62.0a1 (2018-06-21) (64-bit)
Other Extensions: Privacy Badger, Session Sync, Zotero Button, HTTPS Everywhere

Export of Toolkit Settings (Bottom Left of Settings Page)

Settings Export
[{"key":"goalIndicator","value":true},{"key":"highlightNegativesNegative","value":true},{"key":"l10n","value":"0"},{"key":"popupCalculator","value":false},{"key":"reports","value":true},{"key":"AdjustableColumnWidths","value":false},{"key":"AutoDistributeSplits","value":true},{"key":"CalendarFirstDay","value":"1"},{"key":"ChangeEnterBehavior","value":true},{"key":"ClearSelection","value":true},{"key":"CustomFlagNames","value":false},{"key":"EasyTransactionApproval","value":true},{"key":"AccountsEmphasizedOutflows","value":false},{"key":"LargerClickableIcons","value":true},{"key":"RightClickToEdit","value":true},{"key":"RowHeight","value":"0"},{"key":"ShowCategoryBalance","value":true},{"key":"SpareChange","value":false},{"key":"SplitKeyboardShortcut","value":true},{"key":"SplitTransactionAutoAdjust","value":true},{"key":"AccountsStripedRows","value":false},{"key":"SwapClearedFlagged","value":false},{"key":"ToggleSplits","value":true},{"key":"ToggleTransactionFilters","value":"0"},{"key":"CheckNumbers","value":false},{"key":"ReconciledTextColor","value":"0"},{"key":"RunningBalance","value":"0"},{"key":"TransactionGridFeatures","value":true},{"key":"DisableToolkit","value":false},{"key":"BudgetProgressBars","value":"0"},{"key":"CategoryActivityCopy","value":false},{"key":"CategoryActivityPopupWidth","value":"0"},{"key":"CheckCreditBalances","value":true},{"key":"CreditCardEmoji","value":false},{"key":"DaysOfBuffering","value":true},{"key":"DaysOfBufferingHistoryLookup","value":"0"},{"key":"DisplayTargetGoalAmount","value":"2"},{"key":"DisplayTotalMonthlyGoals","value":true},{"key":"EnlargeCategoriesDropdown","value":true},{"key":"EnterToMove","value":true},{"key":"GoalWarningColor","value":true},{"key":"HideAgeOfMoney","value":false},{"key":"CurrentMonthIndicator","value":true},{"key":"IncomeFromLastMonth","value":"1"},{"key":"MonthlyNotesPopupWidth","value":"0"},{"key":"Pacing","value":"0"},{"key":"QuickBudgetWarning","value":true},{"key":"RemovePositiveHighlight","value":false},{"key":"RemoveZeroCategories","value":true},{"key":"ResizeInspector","value":false},{"key":"RowsHeight","value":"0"},{"key":"SeamlessBudgetHeader","value":false},{"key":"StealingFromFuture","value":false},{"key":"TargetBalanceWarning","value":false},{"key":"ToBeBudgetedWarning","value":true},{"key":"ToggleMasterCategories","value":true},{"key":"AccountsDisplayDensity","value":"0"},{"key":"BetterScrollbars","value":"0"},{"key":"BudgetQuickSwitch","value":false},{"key":"CollapseSideMenu","value":false},{"key":"ColourBlindMode","value":false},{"key":"EditAccountButton","value":"0"},{"key":"GoogleFontsSelector","value":"0"},{"key":"HideAccountBalancesType","value":"0"},{"key":"HideHelp","value":true},{"key":"HideReferralBanner","value":true},{"key":"ImportNotification","value":"2"},{"key":"NavDisplayDensity","value":"0"},{"key":"PrintingImprovements","value":true},{"key":"PrivacyMode","value":"0"},{"key":"ShowIntercom","value":true},{"key":"SquareNegativeMode","value":false},{"key":"CompactIncomeVsExpense","value":false},{"key":"ViewZeroAsEmpty","value":false},{"key":"DisplayUpcomingAmount","value":false},{"key":"IncomeVsExpenseHoverHighlight","value":true},{"key":"BudgetCategoryFeatures","value":true},{"key":"GoalIndicator","value":true},{"key":"HighlightNegatives","value":true}]

Steps to Reproduce the Behavior

Activate feature "Income From Last Month"
Any of the options produces a wrong number
Display Budget page and navigate between months, wrong number on every month

Expected Behavior
The "Funds for this month" should become "Income From Last Month" in the next month.
Actual Behavior
Screenshot showing wrong numbers:

Console errors:

@GeorgLink do these numbers line up with the "income" column for their respective months in your Income vs Expense report? They should not match "Funds for XXX"

No they do not match.

@GeorgLink Do you have large starting balances in either April or May?

@joshmadewell

@GeorgLink Do you have large starting balances in either April or May?

What do you mean by starting balances? I always like to maintain a good account balance (Age of Money > 30 days), but I have not added or changed accounts (where I would have a starting balance). Inflow is mainly salary.

@joshmadewell

@GeorgLink Do you have large starting balances in either April or May?

What do you mean by starting balances? I always like to maintain a good account balance (Age of Money > 30 days), but I have not added or changed accounts (where I would have a starting balance). Inflow is mainly salary.

Hey @GeorgLink the fix for this should be in our current release! If you notice the issue still exists and you're definitely running the newest version of the toolkit, please reopen! Thanks!
Please note, all browser can take up to an hour to provide updates to all users. You can force an update if it's available for you by going to chrome://extensions and clicking the "Update" button. Firefox users can go to about:addons, click the setting cog, and click "Check for updates...".


Autosave feature on Chat Page

I want to be able to title anything in the new chat and then click OUTSIDE of the box and that it autosaves...similar to Windows Explorer when I retitle a file and then click away and it autosaves.

Completed


Version number not incremented for 3.0.11

Is there a specific reason the version number was not updated for release 3.0.11? Expected "Pixi.js 3.0.11" but saw "Pixi.js 3.0.10" on the console. Makes for more difficult version management.

3.0.11 hasn't been released to npm yet. Looks like no one has pushed it up yet, I'll have to try and remember to do it when I get home.

When can the push be expected. Thanks!

Done.


[Help] Is there anyway config neovim suggestion

I see Vscode IntelliSense can suggest tailwindcss syntax but is there any way it worked for nvim LSP?

You can suggest a config here if you find one but for now this is not supported.


unpin numexpr

Since the latest version of numexpr is 2.10.0, can it be unpinned?  (pandas pins a floor but not ceiling for numexpr.)

@rootsmusic new versions should work now


Resolves StackVisualizer is Obsolete

About the PR

Splits the StackVisualizer into a component/system pair.
TODO:

[ ] Testing

Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Reopen when you come back to this.

@DrSmugleaf
Commits tested and pushed. Please reopen whenever's convenient.


Add trade ID to the admin trade completed notification

Sometimes steam glitches and admin receives two messages from same trade looking like a same trade twice.

any ETA sir ?

any ETA sir ?

Next update which i will be working on soon, feel free to join our discord server where we post announcements and info about the updates.
Discord
We push updates based on donations and stars activity on the project:
Leave an Star
Donate


feature enable shared exchange sink buffer to reduce RPC concurrency.

What problem does this PR solve?
In the past, each exchange sink had its own sink buffer.
If the query concurrency is n, there would be n * n RPCs running concurrently
in a typical shuffle scenario (each sender instance can send data to all downstream instances).
Here, we introduce support for shared sink buffers.
This does not reduce the total number of RPCs but can limit the number of concurrent RPCs.
Release note
None
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[x] No need to test or manual test. Explain why:

[x] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[x] No.
[ ] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run beut

run buildall

run buildall

run buildall


Fix small issues

Summary
Fix a couple of small issues

bulma deprecation warning for form

WARNING: The form.sass file is DEPRECATED. It has moved into its own /form folder. Please import sass/form/_all instead.

unnecessary binding to this in RecommendationsView component
change some RecommendationsView logging from debug to info because the functionality is very new and if something isn't working as expected, it would be nice to see something in the console
update the simplewebrtc package commit to the same one used in riff-rtc
This should fix errors about log not being a function

Ticket Link
no matching issue
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed

Release 1.0.0-dev.37


Inconsistent behavior slewing between PlatformIO and Arduino

I've noticed inconsitent behavior betwen PlatformIO and Arduino IDE
When compiling via PlatformIO dates appear to wrap at 09:06:07 instead of 23:59:59.
This appears to be a 16 bit signed integer overflow error, possibly related to the usage of abs(totalSeconds) in DayTime.cpp

https://github.com/MCUdude/MCUdude_corefiles/commit/4a89b74edc745f9e2da61a90e3580221de14c63e
This appears to have been fixed in upstream MCUdude_corefiles but a fresh installation of PlatformIO still pulls an older version.
(putting this here in case anyone else notices the error)

https://github.com/MCUdude/MCUdude_corefiles/commit/4a89b74edc745f9e2da61a90e3580221de14c63e
This appears to have been fixed in upstream MCUdude_corefiles but a fresh installation of PlatformIO still pulls an older version.
(putting this here in case anyone else notices the error)


change default version

Description of PR
change default version in  docs
added sqlite3 to the docs and defaults for more visibility
Type of change
Docs Pull Request

Thanks! 👍


add search history settings

Adds a settings screen where users can configure whether to enable search history, or delete their existing history. Close #1145

I would rather not see the merging of User and UserProfile in the frontend, but keep profile as a separate class on a User. I (think) I can follow your reasons, and also find them valid.

Fair enough, I wasn't sure about this myself. I would like these to be handled in a single view, but UserProfile can also just be included as a nested model.

I would rather not see the merging of User and UserProfile in the frontend, but keep profile as a separate class on a User. I (think) I can follow your reasons, and also find them valid.

Fair enough, I wasn't sure about this myself. I would like these to be handled in a single view, but UserProfile can also just be included as a nested model.

Ah, I remembered the implementation incorrectly, so this reply makes no sense. It's already nested.
I can see the merit of having one view for authentication and one for user information, but the current implementation already merges those. I'm not sure that separation should be included in this PR.


⚠ Bofrost.es has degraded performance

In e001fa7, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 2669 ms

Resolved: Bofrost.es performance has improved in 6c3d2b6 after 6 minutes.


Fixed a problem with the order of the apps in the Template Loader

Hi I have found a problem when a third party app overrides the Django Admin templates
The problem happens in 'django.template.loaders.app_directories.Loader'
As this apps name are stored in a dictionary the order is not consistent so sometimes you get the template of the Django app and sometimes you get the template of the third party app. This makes it impossible for a third party app to override the admin templates. In the Third Party app I maintain (Django-Tenants) it really important to be able to override the admin templates.
So the fix I have done is very simple it changes the self.app_configs = {} to an ordered dict.

Django 3.0 and higher don't support Python 3.5 so this change is not necessary.

@felixxm Can I ask when has this got to do with Python 3.5 as I was using Python 3.7 and it will still causing an issue?

I don't know how this change can fix any issue in Python 3.6+. Dictionaries preserve order since Python 3.6.

@felixxm I found out that I was only using python 3.6 and that order change only came in on 3.7. I will upgrade.
https://docs.python.org/3/library/collections.html

As of Python 3.7, regular dicts are guaranteed to be ordered. If the extra features of OrderedDict are required, the suggested remediation is to cast the result to the desired type: OrderedDict(nt._asdict()).


Save ordering between different use

By default, ordering is done with createdAt column. But for some classes, it's not the most convenient. It would be nice that the dashboard remembered on which column it should order. Just like he remembers the places of the columns.

This should be reported in parse-dashboard IHMO

Sorry, wrong tab in browser...


Adding redirection rules for new Three-Parks-Savanna dataset

Add redirect for https://linked.data.gov.au/dataset/three-parks-savanna. Thanks!
Best regards,
Javier Sanchez, TERN

We (Nick and I) are currently refining the processes for pull requests. Sorry, we don't yet have a public document explaining it.
So your request is timely.
Your PR is from your repo/branch that's 83 commits behind our master branch. Please rebase your clone of this repo. You may have to fix some conflicts ... Then let's see if GitHub updates this PR to match.
Also, we have a test suite; Nick, please have a look and advise.
In any case, I'll edit the PR to redirect it into a feature branch so that the test suite can do its thing.

Rebased this PR into a new branch PR50 cloned from master.

This is for https://catalogue.linked.data.gov.au/resource/297 , currently with Registry Status "Submitted".

Hi Richard,
Thanks for the help and clarification. I have pulled the 83 commits from your master to my repo's master, no conflicts.
Yes, this redirection is related to the resource indicated. I have also contacted Nick to review my request in the catalogue.
What next step should I do now?
Thank you very much in advance.
Javier

Commits merged into our feature branch, and now showing a tick at https://github.com/AGLDWG/pid-proxy/tree/PR50 .
Next step is to add tests to the test suite; Nick to continue the conversation at this point.
When ready, we will do the push to staging, then to master, then deploy.


Improve MessageBox design

Changes

Increase spacing between title and message to better separate them
Change title to SemiBold weight to improve visual hierarchy
Vertical alignment for message icon is the top instead of center

Screenshots
New:

Old:

Thanks


[cli] [fix] Fix display of OT node log information

OT firmware with full logs enabled wasn't working; this is now fixed. For a usable experience at the "Info" log level, detailed messages are only shown when in the context of the node.  (This may have different requirements when running from script.)
It now uses the new style of short log level strings as used by OT ([C], [I], etc.)
Idea is that in simulation/node.go in the future maybe different logging policies could be applied, depending on the need. E.g. some users may have a need to write all OT node's logs to individual files for later analysis.
Also the log level of the "Watch" function is fixed - instead of warning it now uses Info.

Codecov Report

Merging #349 (95441ef) into main (c616148) will decrease coverage by 0.26%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
- Coverage   49.97%   49.71%   -0.27%
==========================================
  Files          38       38
  Lines        4608     4610       +2
==========================================
- Hits         2303     2292      -11
- Misses       2123     2136      +13
  Partials      182      182

Impacted Files
Coverage Δ

cli/CmdRunner.go
23.07% <0.00%> (-0.06%)
:arrow_down:

dispatcher/dispatcher.go
57.10% <0.00%> (ø)

simulation/node.go
40.00% <9.09%> (-1.41%)
:arrow_down:

otoutfilter/OTOutFilter.go
90.47% <77.77%> (-1.69%)
:arrow_down:

web/web.go
47.61% <0.00%> (-3.18%)
:arrow_down:

Just added code for the proposal that if a user types "watch 1" in the CLI, then all the OT debug/info/note messages of Node 1 would be shown - regardless of the current CLI's node context.  This works well with the watch command in #348. Use case example: set watch on node 1, then do a "ping 1 2" without being in node 1 context.


modify some wrong func information in device_tool.go

modify some wrong func information in device_tool.go.

yeah, has been restored the first.


[FEATURE] Compute age at the time of the recording

We currently don't have access to the age information in recordings.csv
To compute it, we need 'dob' from children.csv and 'date_iso.csv' from recordings.csv itself.
It'd be particularly useful for longitudinal studies :)
Please, ignore this if the feature already exists (in which case, I'm sorry, I missed it).
For Lyon, I did it myself, using:
import pandas as pd
from pathlib import Path
import numpy as np
import datetime as dt

# Read metadata files
metadata_path = Path("/scratch2/mlavechin/Longforms/FR/lyon/metadata")
children = pd.read_csv(metadata_path / 'children.csv')
recordings = pd.read_csv(metadata_path / 'recordings.csv')

# Import the dob column from children.csv and convert dob et child_id to datetime
recordings = recordings.merge(children[['child_id', 'dob']])
recordings.dob = pd.to_datetime(recordings.dob)
recordings.date_iso = pd.to_datetime(recordings.date_iso)

# Compute age in months and remove dob column
recordings['age'] = ((recordings.date_iso - recordings.dob) / np.timedelta64(1, 'M')).astype(int)
recordings.drop('dob',inplace=True, axis=1)

EDIT : I also realized that you may not want to go in that direction as the number of features to implement would be virtually infinite *_*

I think it would make sense to have such a feature.
However,  pd.to_datetime will fail for dates that are too far back, e.g. 01/01/1000. You may ask why this is relevant. Well, in EL1000 for instance, dates have been "anonymised" like that. This has the merit to make it obvious that the dates are not the real dates, but instead made up to keep ages consistent while protecting the privacy of the participants.
This is solved by using datetime.datetime.strptime instead.
(saying this for whoever wanna implement this)
Regarding the implementation, maybe ChildProject.projects.ChildProject should have a compute_age method that returns a pd.Series with the computed age.
e.g.
project = ChildProject('.')
project.read()
project.children['age'] = project.compute_age()

but the function should also accept custom dataframes maybe:
project = ChildProject('.')
project.read()
children = project.children.copy()
recordings = project.recordings.copy()
# work on the dataframes...
# ...
children['age'] = project.compute_age(children = children, recordings = recordings)


Add equivalent of GenServer's terminate callback

We should have equivalent of GenServer's terminate (e.g. handle_terminate) both in pipelines and elements to allow proper cleanup.

We already have this in elements, (handle_shutdown/1), we should only add Pipeline's counterpart. BTW I'm not sure if it should be the only solution anyway, because GenServer's terminate callback is not guaranteed to be executed (see https://hexdocs.pm/elixir/GenServer.html#c:terminate/2. So we should either spawn a process for monitoring each element/pipeline and execute such callbacks there or encourage users to create such processes for each resource that needs to be cleaned up (the way the File does it)

handle_shutdown for pipelines done in #176


:sparkles: Add sleep staging example (on sleep-edf expanded dataset)

Codecov Report

Merging #18 (9bb1ef9) into main (6643c04) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage   95.67%   95.67%
=======================================
  Files          20       20
  Lines         786      786
=======================================
  Hits          752      752
  Misses         34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6643c04...9bb1ef9. Read the comment docs.


onlyOnRoot redirecting prefix routes

Version
"nuxt": "^2.14.7",
"nuxt-i18n": "^6.15.4"
Nuxt configuration
mode:

[X] universal
[] spa

Nuxt-i18n configuration
"nuxt-i18n",
{
        strategy: "prefix_and_default",
        locales: [
          {
            name: "English",
            code: "en",
            iso: "en-US"
          },
          {
            name: "Español",
            code: "es",
            iso: "es-ES"
          }
        ],
        vueI18n: {
          fallbackLocale: "en",
          messages: {
            en: require("./locale/en.json"),
            es: require("./locale/es.json")
          },
          silentTranslationWarn: false
        },
        defaultLocale: "es",
        seo: false,
        baseUrl: "https://getsilt.com",
        detectBrowserLanguage: {
          useCookie: true,
          cookieKey: "i18n_redirected",
          onlyOnRoot: true
        }
      }

Reproduction Link
https://getsilt.com/es
Steps to reproduce
Go to https://getsilt.com/es and it will always be redirected to the root.
What is Expected?
https://getsilt.com/es Should keep its "es".
The idea is to get the result of prefix_and_default, so have both getsilt.com and getsilt.com/es, and obviously have translated pages crawled by Google.
What is actually happening?
https://getsilt.com/es redirects to https://getsilt.com/es
Google is not crawling the translated page "/es", and I think it is because it always redirects to "/".
Now the "prefix" page, is only available under "/en".
Which makes google to not index "/es" route, and therefore no translated pages are indexed.
The root are indexed in English, which I think is expected.
These are the headers in https://getsilt.com/:
<html data-n-head-ssr="" lang="en-US" data-n-head="%7B%22lang%22:%7B%22ssr%22:%22en-US%22%7D%7D"><!--<![endif]--><head>
<meta data-n-head="ssr" data-hid="og:locale" property="og:locale" content="en_US" />
<meta data-n-head="ssr" data-hid="og:locale:alternate-es-ES" property="og:locale:alternate" content="es_ES" />
<link data-n-head="ssr" rel="icon" type="image/x-icon" href="/favicon.ico">
<link data-n-head="ssr" data-hid="alternate-hreflang-en" rel="alternate" href="https://getsilt.com/en" hreflang="en" />
<link data-n-head="ssr" data-hid="alternate-hreflang-en-US" rel="alternate" href="https://getsilt.com/en" hreflang="en-US" />
<link data-n-head="ssr" data-hid="alternate-hreflang-es" rel="alternate" href="https://getsilt.com/" hreflang="es" />
<link data-n-head="ssr" data-hid="alternate-hreflang-es-ES" rel="alternate" href="https://getsilt.com/" hreflang="es-ES" />

With prefix_and_default strategy the default locale has no prefix. Maybe you want to use prefix strategy if you want all locales to have a prefix?

The idea is to get the result of prefix_and_default, so have both getsilt.com and getsilt.com/es, and obviously have translated pages crawled by Google.
But Google is not crawling the translated page "/es", and I think it is because it always redirects to "/".
Now the "prefix" page, is only available under "/en".
Does it make sense now? :)

The idea is to get the result of prefix_and_default, so have both getsilt.com and getsilt.com/es, and obviously have translated pages crawled by Google.

Nope, this won't happen. Google will just decide on it's own what page url (/ or /es) to select as duplicate content and excluding it (if not both of them).
Basically, search engines doesn't like duplicate content at all. They simply can't decide which is original and giving a chance to them will only harm. Changes are not instant and correction might take a months (speaking from personal experience).

But Google is not crawling the translated page "/es", and I think it is because it always redirects to "/".

This is actually correct - in prefix_and_default strategy redirecting to root. You've / and /es with same content and / should be the main.

Does it make sense now? :)

Absolutely. I don't see the issue, however misunderstanding of SEO and what has been done over here to improve it.
Thanks!

Basically, search engines doesn't like duplicate content at all. They simply can't decide which is original and giving a chance to them will only harm. Changes are not instant and correction might take a months (speaking from personal experience).
That's true, but since Google is crawling "/" as english version, with onlyOnRoot: true,  "/es" should not be equal to "/" right?

I'm not sure I got what you meant...
The issue is that currently there are no pages crawled in spanish, neither "/" or "/es"
With prefix_and_default, how could I make Google crawl any page both in spanish and english. I thought that using onlyOnRoot: true should be enough.

Are you able to find out what headers does google crawler sends when visiting the / page?
If it explicitly sends "Accept-language: en" (or similar) then / would redirect to /en indeed. That's one of the drawbacks of automatic browser language detection, even with onlyOnRoot.

As I understand from this Link, Googlebot does not provide an Accept-language header.
But still, I thought that the purpose of onlyOnRoot was to redirect only for the root page, as de documentation defines.

onlyOnRoot (default: false) - Set to true (recommended for improved SEO) to only attempt to detect the browser locale on the root path (/) of the site. Only effective when using strategy other than 'no_prefix'.

I think that there's somehow a redirect from "/es" to "/".
prefix_and_default should make both pages available right?
I think that the only issue is that https://getsilt.com/es/ redirects to https://getsilt.com and it all makes the crawling of spanish unavailable. But I don't know why that's happening 🤷♂

I may be mistaken... Somehow I found that the spanish sites are crawled: Google search
The actual issue, is that Google is not structuring the results grouping them by language as expected.
Having the browser language preference set to spanish, the results are in english first, and the websites crawled are not structured as expected.
I discovered that the issue is that the 4th of november "/es" version crawled does not have a canonical link, but the "live version (released on 25th Nov) it actually has a proper canonical link (tanks to the latest version of nuxt-i18n <3 ).
I'll close this issue, since I think it is a matter of waiting to get crawled again... (The option of reindex in search console being "temporary" deactivated does not help either :( )
Thank you all, and apologies for any disturbance created.

@Perezmarc I've just checked it up.
https://getsilt.com/es returns empty content, this is probably related and fixed in https://github.com/nuxt-community/i18n-module/pull/989
Can you create a simple reproduction? I can't reproduce it locally.
Thanks!

This ticket should be re-opened. I don't think this is solved for static generated sites.
While now the pages that are redirected away from are no longer empty (which was an important fix) it still redirects for static sites.
Let's break it down. The relevant configuration properties are these:
strategy: "prefix_and_default",
detectBrowserLanguage: {
          useCookie: true,
          onlyOnRoot: true
}

Accoridng to the documentation the Strategy prefix_and_default is defined as such:

This strategy combines both previous strategies behaviours, meaning that you will get URLs with prefixes for every language, but URLs for the default language will also have a non-prefixed version.

This is fulfilled in the sense that both prefixed and non-prefixed pages are generated as HTML files during build and have the correct content.
The detectBrowserLanguage onlyOnRoot property is defined as:

With it set, the language detection is only attempted when the user visits the root path (/) of the site. [...] It also allows linking to pages in specific locales.

Ignoring Crawler and SEO for simplicity as they are just one use-case but not the cause then this means that if I hit a static hosted website it should behave as follows ind regards of language detection alone:
www.domain.tld/ -> this is root, so attempt to detect language (if no cookie is set)
www.dotmain.tld/en -> this is NOT root as we have a path, do not attempt to detect language, but set a cookie with language EN; overwrite if exists
for language detection only, the stategy is not relevant, but the misbehaviour gets clear when combining them both. This si what should happen when using prefix_and_default with onlyOnRoot detectBrowserLanguage:
www.domain.tld/ -> this is root, so attempt to detect language (if no cookie is set) -> REDIRECT if language does not match default language
www.dotmain.tld/en -> this is NOT root as we have a path, do not attempt to detect language, but set a cookie with EN as language -> NO REDIRECT
www.dotmain.tld/en/page -> this is NOT root as we have a path, do not attempt to detect language, but set a cookie with EN as language -> NO REDIRECT
This is hat actually happens:
www.domain.tld/ -> this is root, so attempt to detect language (if no cookie is set) -> REDIRECT if language does not match default language
www.dotmain.tld/en -> this is NOT root as we have a path, do not attempt to detect language, but set a cookie with EN as language -> REDIRECTS TO  www.domain.tld/ if EN is default language
www.dotmain.tld/en/page -> this is NOT root as we have a path, do not attempt to detect language, but set a cookie with EN as language -> REDIRECTS TO  www.domain.tld/page if EN is default language
This behaviour is closer to strategy prefix_except_default, as defined:

Using this strategy, all of your routes will have a locale prefix added except for the default language

Why? because I have no chance of getting to www.dotmain.tld/en/page without being redirected; if EN is the default locale.

This ticket should be re-opened. I don't think this is solved for static generated sites.

Hello,
Could you please try onlyOnNoPrefix option instead of onlyOnRoot that was introduced in https://github.com/nuxt-community/i18n-module/pull/896 and released in 6.16?
https://i18n.nuxtjs.org/options-reference#detectbrowserlanguage
Thanks!

Thank you @divine, yes, I think this kind of works.
But still, I think that prefix_and_default may not be a good strategy for SEO, at least in my case.
I have defaultLocale: "es", but the crawled version of / is actually in English.
I'd like to have the following:

route / --> always in defaultLocale

if language is en, redirect to /en
if language is es no redirect

route /es or /en --> never redirect

Desired Crawled versions:

/ language in defaultLocale: es
/es language in es
/en language in en

Actual Crawled versions:

/ language in Google bot browserLanguage: en
/es language in es
/en language in en -> Not indexed because duplicated content

Is that possible?
Does it make sense?
What do you think it would be the best strategy for SEO?
right now I'm seeing my google search results in multiple languages:
https://ibb.co/n1mKd2N

Hello @Perezmarc,
Not sure how I missed your message.

But still, I think that prefix_and_default may not be a good strategy for SEO, at least in my case.

The best strategy for SEO is prefix & prefix_except_default

right now I'm seeing my google search results in multiple languages:
https://ibb.co/n1mKd2N

It has been almost 6 months, what did you choose and what results do you have?
Also, this issue can be closed?
Thanks!

I have been using prefix for a few months now. I still see indexed
/ in English
/es in Spanish
and the same results as the previous image https://ibb.co/n1mKd2N
In search console though, it says that root / is not indexed, the canonical for root is /en, and the canonical for /es is /es.
Still not positioning properly my site with the google maps and the proper language. It should not show first the page in English when searching in spanish.

Still not positioning properly my site with the google maps and the proper language. It should not show first the page in English when searching in Spanish.

Hello @Perezmarc! Glad to see you here again!
This happens only on a statically generated version because redirection to /en happens via JavaScript after a full page load.
I'm having the same issue, but the only solution is to use the target: 'server' version.
Thanks!

That's a shame, I decided to use nuxt for the static site generation :S

Hi,
is this problem about nuxt-i18n still open? There is no clean solution yet?
Even with onlyOnRoot it's a semi-solution cause search engines will index the homepage only in English. Need to disable the auto redirect in order to get every page indexed in every language i have.

I think SEO and multilanguage is a must for a landing page, and I use Nuxt for the static site generator. This could be a problem that would make me choose to migrate to other solutions.

Disable auto-detection of the language then.
If you think it's possible to support this case with auto-detection enabled, or you find that other solutions support that, then feel free to let me know.
I'm not asking for a solution implemented in the code but just a generic idea of how it should work.

Hi @rchl I was thinking... have you tried by checking the user agent of the bots, and then only redirect if the ua is not in the list of ua bots?

@Perezmarc Sorry for bringing up such an old issue.
I face the same problem.
I am using auto-redirect to the browser language, but this is not desired for the crawlers because they always get redirected when landing on homepage.
Is there a way to disable the redirect based by the user agent of the bots?
I've been looking through the code but I couldn't find anything about that.

It's not generally recommended to have crawler-specific logic. It can even lead to rank decrease in some cases.
Also I believe that crawlers on purpose make small amount of requests without identifying itself to catch cases where they are treated differently.
So I'm not such it's a good idea.

@rchl so the solution is to disable the detectBrowserLanguage ?
How do I do that?
Is this ok?
  i18n: {     detectBrowserLanguage: false,   },

Closing this as v7 is not being actively worked on (critical hotfixes only), if this still applies to v8 and later please open a new issue!


Firebase functions version

Which versions of firebase-functions npm package is currently in use ? Shouldn't that be added within devDependencies ?

Firebase functions is present in package.json here https://github.com/Instant-Visio/InstantVisio-WebApp/blob/master/functions/package.json#L20

It seems it has been removed from current package.json file on master branch, creating a little issue for that ;)

the link is correct and it is on master
no need for a new issue

Am I looking in the wrong spot ? I don't see that within the file I linked although ^^'

https://github.com/Instant-Visio/InstantVisio-WebApp/blob/master/functions/package.json#L20
vs
https://github.com/Instant-Visio/InstantVisio-WebApp/blob/master/package.json

Ok closed the new issue, my bad :)


update to 1.19.4

update to 1.19.4

when using the 1.19(latest) version on 1.19.4 it crashes the game

Now available


Update sbt to 1.4.6

Updates org.scala-sbt:sbt from 1.4.5 to 1.4.6.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: library-update, semver-patch

Codecov Report

Merging #126 (c49e1f0) into main (aaac77c) will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
+ Coverage   94.57%   94.69%   +0.12%
==========================================
  Files           7        7
  Lines         830      830
  Branches       75       75
==========================================
+ Hits          785      786       +1
+ Misses         45       44       -1

Impacted Files
Coverage Δ

core/shared/src/main/scala/cats/parse/Parser.scala
94.92% <0.00%> (+0.14%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaac77c...c49e1f0. Read the comment docs.


retext-knwl

So there is this seemingly abandoned piece of software called knwl.js. I am fairly unfamiliar with retext and it's ecosystem but still I was wondering if it might make sense to create a knwl-js plugin for retext. This would enable basic NER.

Thanks for suggesting. It would be possible to create some tool like this for retext, but I'm not (no longer) interested in creating it. The reason being that retext's power comes from retext-equality, retext-simplify, spelling detection, and the like, rather than plain natural language processing.
The syntax tree format used internally is really useful for detecting patterns as seen in these plug-ins, and less so for phone numbers (which can be better found using a regex than a syntax tree).
Hope this helps!

Thank you for the insight! What I gathered is that retext is a  completely different thing and NER is out of scope.

Quite right!


Remove Istio 1.17 version check

Please provide a description of this PR:

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio
2f0644217377301921540f4bed40680d434c3ce3
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-multicluster


Not consistent behavior of methods default_action in Chef::Resource::LWRPBase class and action in Chef::Resource class.

This PR fixes different behavior in cases then we set action during resource call and then actions sets from default_action method.
If we call resource and set action directly:
foo_resource 'bar' do
  action :add
end

variable @action will be always an array, no matter if we gave an array or a symbol to the method action.
If we call resource without action:
foo_resource 'bar'

and in its declaration contains:
default_action :add

variable @action will be an array if we gave an array to the method default_action or a symbol if we gave a symbol.
I fixed this difference so that the variable @action always has been an array.

Ah, yes. I've also faced with this when I tried to hack over the resource collection.
So, I think the fix is OK. The action should be an Array type regardless of it is defined explicitly or not.
Chefs, please, check it out.

@lamont-granquist review please.

Did this change between Chef 11 and Chef 12 or something?  Just unclear on what issues are driving the change.
Other than that, it looks okay to me.  The action setter in Chef::Resource coerces actions to arrays already (and we should really clean up our use of @action = :whatever to be action(:whatever) consistently throughout all the Chef resources to not bypass that.
I do have some very vague concerns that this might be a breaking change for someone.  If anyone is inspecting resource.action then this will obviously change that API (although the difference between picking up the default_action and declaring an explicit action is already ambiguous, so I can accept the argument that this is an undocumented edge case that we're fixing and if we do break someone that its acceptable breakage in a minor version).

I renamed this pr on a more understandable name.
In the current situation it is difficult inspecting resource.action, because you don't know type of variable.
I have use case:
checks = run_context.resource_collection.select { |r| r.is_a?(Chef::Resource::NrpeCheck) && r.action == [:add] }.map(&:command_name)

and it behavior is unpredictable, now. Of course i can bypass it, but this would be dirty hack.

@lamont-granquist, what do you say about this?

@chef/client-engineers @chef/client-core needs review

While it's possible to be a breaking change, it seems anyone that's relying on it returning a symbol is already broken when an action is set and an array is returned. :+1:

:+1:

:+1:

Guys, when you plan to merge this PR?

I believe @thommay is planning a merge pass soon in preparation for a 12.4.0 RC.

Ok, thanks! ✨👍

Thanks for your contribution, @Kasen!


Add a "Select all" button

We have the "Clear selection" link.
We need the "Select all" link as well, in order to not need to tick all skills to select everyone.

done in #265


Android Fails to build citing  new DynamicFontModule

Build/Submit details page URL
https://expo.dev/accounts/safercity/projects/SaferCity-mobile-app/builds/962c2d6f-4bf6-456c-89cf-3efea90a9aa8
Summary
I get this error when I want to build for Android, the IOS build works with no issues.
Managed or bare?
managed
Environment
expo-env-info 1.0.5 environment info:
System:
OS: macOS 13.4.1
Shell: 5.9 - /bin/zsh
Binaries:
Node: 18.18.0 - ~/.nvm/versions/node/v18.18.0/bin/node
Yarn: 1.22.19 - ~/.nvm/versions/node/v18.18.0/bin/yarn
npm: 9.8.1 - ~/.nvm/versions/node/v18.18.0/bin/npm
Managers:
CocoaPods: 1.13.0 - /Users/ab/.rvm/gems/ruby-3.1.2/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 22.4, iOS 16.4, macOS 13.3, tvOS 16.4, watchOS 9.4
IDEs:
Xcode: 14.3.1/14E300c - /usr/bin/xcodebuild
npmPackages:
expo: ^49.0.0 => 49.0.13
react: 18.2.0 => 18.2.0
react-dom: 18.2.0 => 18.2.0
react-native: 0.72.5 => 0.72.5
react-native-web: ~0.19.6 => 0.19.9
react-navigation: ^4.4.4 => 4.4.4
npmGlobalPackages:
eas-cli: 5.4.0
expo-cli: 6.3.10
Expo Workflow: managed
Error output

Reproducible demo or steps to reproduce from a blank project

Run eas build -p android  command

The issue was a 3rd party libray


Prevent infinite cascade of re-layout after label text reshaping

This avoids the editor freeze that some, including @clayjohn, have run into when certain internal errors occur and are shown in toasts.

Yeah, this change smells like a hack, but I couldn't see a better way either.

Hi, I'm not familiar with this topic, but from the title I think it may refer to my problem. I am using godot 4.12 to make a video game. Everything works fine there. But when you open it in 4.14 something different happens without making any changes.
I have a tags with a panel as child. The labels adapt to the size of the text and with it the child panel. But that only happens correctly in 4.12. In 4.14 they adapt, but they no longer do it correctly, they leave the text cut at an arbitrary height (although always in the same place).
I don't know if the theme is correct, for now I will continue using 4.12 until I find the solution. Thank you for your attention and best regards.

Sounds likely. After all, the patch is not taking the height into consideration. I'll investigate and report my findings.


[IMP] list-depends: topological sorting

Add a new --sort option on the list-depend command allowing to apply a topological sorting to the result.
https://docs.python.org/3/library/graphlib.html

I see graphlib is python 3.9+, but that is ok, we can simply error out if the topological sort is selected by the user and sys.version_info < (3,9).

This is taking shape. Can you add tests for the sorters and update the documentation too?

Can you also

add a news/62.feature with a short changelog entry
add the sort option to the list and list-codepends commands


Feature/#34 implement budget account entity deletion

Closes #34

we also have problem with forms, they are almost invisible

we also have problem with forms, they are almost invisible

Noted - I'll fix this in scope of dark / light theme switching


use a GitHub Actions bot user as committer

Signed-off-by: Di Xu<EMAIL_ADDRESS>
What type of PR is this?
kind/workflow
What this PR does / why we need it:
  git rebase origin/main
  shell: /usr/bin/bash -e {0}
  env:
    GOPATH: /home/runner/work/clusternet/clusternet
    GO111MODULE: on
    GOROOT: /opt/hostedtoolcache/go/1.15.15/x64
Rebasing (1/1)
Committer identity unknown

*** Please tell me who you are.

Run

  git config --global user.email<EMAIL_ADDRESS>  git config --global user.name "Your Name"

Which issue(s) this PR fixes:

Supercedes #231
Special notes for your reviewer:

Codecov Report

Merging #232 (5daa791) into main (fd045f2) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 5daa791 differs from pull request most recent head 81fdc6c. Consider uploading reports for the commit 81fdc6c to get more accurate results

@@           Coverage Diff           @@
##             main     #232   +/-   ##
=======================================
  Coverage   10.26%   10.26%
=======================================
  Files          39       39
  Lines        4237     4237
=======================================
  Hits          435      435
  Misses       3771     3771
  Partials       31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd045f2...81fdc6c. Read the comment docs.


Authentication by stream key

stream_key
Syntax: stream_key str
Context: rtmp, server, application
rtmp {
    ...
    server {
        ...
        application mytv {
            live on;
            stream_key 77Yp6pAd;
            pull rtmp://rtmp.example.com;
        }
    }
}

note: I noticed that this doesn't work with HLS playlists, might be a bug

Similar question here: https://github.com/arut/nginx-rtmp-module/issues/565 from @mknwebsolutions
@schumann2k have you found a solution for HLS stream renaming after setting 3xx Location:?
@arut I will pay in beers for insight. This is an excellent module, BTW.

@mvberg @arut I will also donate :) +1

@schumann2k have you found a solution for HLS stream renaming after setting 3xx Location:?

HLS/DASH segments still expose the original play path/stream key, DASH more so than HLS:

hls/dash_nested on;

DASH creates a subdirectory named after the original stream key, which can be worked around by using an alias, and also exposes the key inside the <Representation> tags in the generated index.mpd (see tail of this post).
The segments themselves have a trivial filename (timestamp?).
HLS creates a subdirectory named after the original stream key, which can be worked around by using an alias, but doesn't expose the key in the m3u8 playlist.
The segments themselves have a trivial filename (segment index).

hls/dash_nested off;

both HLS and DASH segments use a similar streamkey-segmentid.m4v|.ts filename

I believe the most useful fix, or rather configuration option, would be to have nginx use the new, rewritten/renamed play path for recordings and segments. That way there wouldn't be a need for any special configuration rules and every streamer could use the same application { }.
I haven't looked at the code and have no idea how hard this would be to implement, could give it a go though.
index.mpd:
<Representation
          id="mystreamsecret_H264"
          ...


Add missing require

Coverage increased (+0.003%) to 96.68% when pulling eae4987992d63126f35c99009174c4791129e6cd on fix/require-sidekiq-scheduler-on-web into 6bbe2accea4f57fb69aa6c16f6c47f01a38a9d83 on master.


Allow to release maker seperate from taker

I think there is high value in being able to release taker and maker separately because this would allow us to shoot out small fixes on the maker which do not influence the taker.

This project is unmaintained


[CalendarReminder.json>Snooze for]: Voice access user is not able to access the 'Snooze for' combo box through move to 'Snooze for' command under 'CalendarReminder.json'.

Target Platforms
UWP
SDK Version
3.0.2206.2001
Application Name
Adaptive Cards
Problem Description
Test Environment:
OS Version: 22H2 (Build 25126.1000)
Application: Adaptive Cards UWP
Application Version: 3.0.2206.2001
Tool: Voice access
Actual Result:
Voice access user is not able to access the 'Snooze for' combo box through move to 'Snooze for' command under 'CalendarReminder.json'.
Expected Result:
Voice access user should be able to access the 'Snooze for' combo box through move to 'Snooze for' command under 'CalendarReminder.json'.
Observation:
'Click Snooze for' command is also not working.
User Impact:
People with limited mobility (cerebral palsy, quadriplegia) who use Voice Access will get impacted as they will not be able to interact with the control easily and accessing through numbers would take more time for them.
MAS reference link:
[No Disruption of Accessibility Features - Liquid (microsoft.com)]
Have feedback to share on Bugs? Please help fill Trusted Tester Bug Feedback (office.com)"
Screenshots

https://user-images.githubusercontent.com/104483005/173425823-76f4029e-5172-4974-a9b1-db818cc1448a.mp4
Card JSON
NA

Sample Code Language
No response
Sample Code
No response

To whoever starts work on this issue: we should remove all of the samples that should be using labels (clicking "Snooze for" would work here if it the sample correctly supplied it as a label, as we do with CalendarReminderWithLabels.json).

Issue has been fixed in below test environment, hence adding A11yTTValidated tag.
Test Environment:
OS Version: 22H2 (Build 25330.1000)
Application: Adaptive Card Visualizer
**
https://user-images.githubusercontent.com/104483005/235418224-4f3927ba-3216-4dff-b798-1908f8d323ee.mp4
**: Adaptive Cards~ Issue fixed snooze for combobox.mp4


spark.read.geotrellisCatalog do not use spark.hadoop.fs.s3a.* config correctly

Current situation
When I to read Geotrellis catalog with an s3a:// URI using spark.read.geotrellisCatalog,
I get the following error:
https://gist.github.com/jdenisgiguere/61161a1bd9636ec91c3b75cbb6a845b9
A workaround is to first read data with the spark.read.parquet method in the same bucket.
After this call,  spark.read.geotrellisCatalog will be able to read data.
See:
https://github.com/jdenisgiguere/rasterframes-minio-ZazJXB4U/blob/acaa3b1de2372a642223ff9b48abba9d8e208dd5/read-with-rasterframes0.9/src/main/scala/io/anagraph/zazjxb4u/RfBisReader.scala#L69-L72
Expected situation
Prior invocation of spark.read.parquet should not be required to read a Geotrellis HadoopAttributeStore.

The second line of the Gist you posted points out that the credentials are missing....
In your posted code I do see the credentials explicitly set, which explains how the parquet read with s3a:// scheme works.
Can you double check that the credentials are set in the initial  attempt to read geotrellisCatalog, without the parquet?

@vpipkt , to reproduce the issue, the only thing I do is commenting the lines 71 and 72. If they are commented, I get the error message, if theyr are not, the spark.read.geotrellisCatalog is working.

@metasim any reason why the geotrellis catalog reader would not honor the config options setting s3 credentials?

@vpipkt @jdenisgiguere I'm surprised it's not getting passed along, because under the covers it's actually pulling from native Spark datasources, which I'd expect to honor that. IOW, how would spark.read.json be any different than spark.read.parquet?

Actually, those calls are actually just parsing data that's been fetched by other operations.  Probably,  need to look at the GeoTrellis APIs to see if they pay attention to the Spark properties.

This may also be an issue with the use of different Hadoop library versions in the final application build.


[WIP] Add exercise conclusions.

In two documents there was a link to Google Groups. Changed it to new Discourse platform.
One of those two documents contained a link at the bottom of the exercise, I added a conclusion with link to the bottom of all exercises to be consistent. It's a good thing to have the ability for attendees (or anyone just looking at this repo) to discuss the exercises and workshop content after the workshop.

I learned from the master, so be prepared: the 2 commits should be into 2 different PRs 😄, one for the links update and the second one for the exercises conclusion.
The content is good to go, though

I cherry-picked the fixing of the forum link into https://github.com/Particular/Workshop.Microservices/pull/154
This PR can now become the addition of exercise conclusions. Marking as WIP until #154 is merged.

Didn't see the squash remark. Can we also squash it when merging into master?

Please review again

yes


Distributed training

The following errors occurred in distributed training

@InstantWindy Hi, could you please proviode more detailed information about this error?


docs: docs generation and modify readme

Description

Added packages for automatic docs generation
Made some readme changes
Add a document on how to interpret the standard format

Closes #29

@derberg PR is ready for review :)


Test rustc bootstrapping on AArch64

Hey, I mentioned I had an issue natively running test_rustc_tests.sh but the same issue presents when running test_bootstrap.sh.
The issue shows up when compiling the byteorder-1.3.4 crate.
   Compiling proc-macro-error v1.0.4
error: failed to run custom build command for `byteorder v1.3.4`

Caused by:
  process didn't exit successfully: `/home/ubuntu/git/rustc_codegen_cranelift/rust/build/bootstrap/debug/build/byteorder-80e24b4ddeadaf84/build-script-build` (signal: 6, SIGABRT: process abort signal)
  --- stderr
  thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/byteorder-1.3.4/build.rs:54:14
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: build failed
failed to run: /home/ubuntu/.rustup/toolchains/nightly-2021-06-30-aarch64-unknown-linux-gnu/bin/cargo build --manifest-path /home/ubuntu/git/rustc_codegen_cranelift/rust/src/bootstrap/Cargo.toml
Build completed unsuccessfully in 0:00:33

Here's the offending line.
This is a bit weird because running --version on cg_clif works:
ubuntu@ubuntu:~/git/rustc_codegen_cranelift$ ./build/bin/cg_clif --version
rustc 1.55.0-nightly (6d820866a 2021-06-29)

Even if i set $RUSTC to cg_clif I get the same error:
ubuntu@ubuntu:~/git/rustc_codegen_cranelift$ RUSTC="/home/ubuntu/git/rustc_codegen_cranelift/build/bin/cg_clif" ./scripts/test_bootstrap.sh
...
same error as above

Am I missing anything?

Isn't this the offending line: https://github.com/BurntSushi/byteorder/blob/eaaad370715c04d78334d6a5b49c637549c84c71/build.rs#L54 (line 54, not 45) Doesn't look like a None unwrap should be possible at that point though. Can you get a backtrace?

I just finished compiling cg_clif for aarch64 using qemu. The panic happens in build_script_build::Version::parse. It doesn't like the cranelift version in the cg_clif -vV output I guess.

Oh, right, I think I got mixed up, because the issue I was having in test_rustc_tests.sh was about the --version flag not giving us anything.
It is indeed in line 54. Here's the backtrace:
RUST_BACKTRACE=1 ./scripts/test_bootstrap.sh
...
   Compiling crossbeam-utils v0.8.3
error: failed to run custom build command for `byteorder v1.3.4`

Caused by:
  process didn't exit successfully: `/home/ubuntu/git/rustc_codegen_cranelift/rust/build/bootstrap/debug/build/byteorder-80e24b4ddeadaf84/build-script-build` (signal: 6, SIGABRT: process abort signal)
  --- stderr
  thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/byteorder-1.3.4/build.rs:54:14
  stack backtrace:
     0: rust_begin_unwind
               at /home/ubuntu/git/rustc_codegen_cranelift/build_sysroot/sysroot_src/library/std/src/panicking.rs:515:5
     1: core::panicking::panic_fmt
               at /home/ubuntu/git/rustc_codegen_cranelift/build_sysroot/sysroot_src/library/core/src/panicking.rs:92:14
     2: core::panicking::panic
               at /home/ubuntu/git/rustc_codegen_cranelift/build_sysroot/sysroot_src/library/core/src/panicking.rs:50:5
     3: core::str::slice_error_fail
               at /home/ubuntu/git/rustc_codegen_cranelift/build_sysroot/sysroot_src/library/core/src/option.rs:388:21
     4: core::str::traits::<impl core::slice::index::SliceIndex<str> for core::ops::range::RangeFrom<usize>>::index
               at /home/ubuntu/git/rustc_codegen_cranelift/build_sysroot/sysroot_src/library/core/src/str/traits.rs:365:21
     5: core::str::traits::<impl core::ops::index::Index<I> for str>::index
               at /home/ubuntu/git/rustc_codegen_cranelift/build_sysroot/sysroot_src/library/core/src/str/traits.rs:64:9
     6: build_script_build::Version::parse
               at ./build.rs:54:14
     7: build_script_build::Version::read
               at ./build.rs:47:9
     8: build_script_build::main
               at ./build.rs:10:25
     9: core::ops::function::FnOnce::call_once
               at /home/ubuntu/git/rustc_codegen_cranelift/build_sysroot/sysroot_src/library/core/src/ops/function.rs:227:5
  note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
warning: build failed, waiting for other jobs to finish...
error: build failed
failed to run: /home/ubuntu/.rustup/toolchains/nightly-2021-06-30-aarch64-unknown-linux-gnu/bin/cargo build --manifest-path /home/ubuntu/git/rustc_codegen_cranelift/rust/src/bootstrap/Cargo.toml
Build completed unsuccessfully in 0:00:07

It doesn't like the cranelift version in the cg_clif -vV output I guess.

Never mind. That only happens when you explicitly pass -Zcodegen-backend together with the -vV.

The error seems to happen at https://github.com/rust-lang/rust/blob/851c82e88ade86bfe3b4ee785d5e5ab1d954b61c/library/core/src/str/mod.rs#L112 suggesting a non-utf8 string.

With a debug sysroot:
   Compiling byteorder v1.3.4 (/home/bjorn/Projects/cg_clif2/byteorder)
error: failed to run custom build command for `byteorder v1.3.4 (/home/bjorn/Projects/cg_clif2/byteorder)`

Caused by:
  process didn't exit successfully: `/home/bjorn/Projects/cg_clif2/byteorder/target/debug/build/byteorder-25926a0b98921ea4/build-script-build` (signal: 15, SIGTERM: termination signal)
  --- stderr
  thread 'main' panicked at 'byte index 6 is not a char boundary; it is inside 'r' (bytes 0..1) of `rustc 1.55.0-nightly (6d820866a 2021-06-29)
  `', build.rs:54:14
  stack backtrace:
  thread 'main' panicked at 'byte index 7 is not a char boundary; it is inside '.' (bytes 0..1) of `.debug_addr`', sysroot_src/library/std/src/../../backtrace/src/symbolize/gimli/elf.rs:121:26

and then it hangs. Couldn't even see this until I killed qemu.

Hmm, I modified the build.rs file to include a dbg!(s). It seems to be correct:
[build.rs:51] s = "rustc 1.55.0-nightly (6d820866a 2021-06-29)\n"

Here's a minimal repro case:
fn main() {
    let mut s = "rustc 1.55.0-nightly (6d820866a 2021-06-29)\n";
    s = &s[6..];
    dbg!(s);
}

Thanks for the debugging!

Now getting
   Compiling merge_derive v0.1.0
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
error: could not compile `merge_derive`

Caused by:
  process didn't exit successfully: `/home/bjorn/Projects/cg_clif2/rust/../build/bin/cg_clif --crate-name merge_derive --edition=2018 /home/bjorn/.cargo/registry/src/github.com-1ecc6299db9ec823/merge_derive-0.1.0/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type proc-macro --emit=dep-info,link -C prefer-dynamic -C embed-bitcode=no -C debuginfo=2 -C metadata=9ead013e1ae016e2 -C extra-filename=-9ead013e1ae016e2 --out-dir /home/bjorn/Projects/cg_clif2/rust/build/bootstrap/debug/deps -C linker=aarch64-linux-gnu-gcc -L dependency=/home/bjorn/Projects/cg_clif2/rust/build/bootstrap/debug/deps --extern proc_macro_error=/home/bjorn/Projects/cg_clif2/rust/build/bootstrap/debug/deps/libproc_macro_error-d02fc3c73f17a371.rlib --extern proc_macro2=/home/bjorn/Projects/cg_clif2/rust/build/bootstrap/debug/deps/libproc_macro2-de20e217372061ee.rlib --extern quote=/home/bjorn/Projects/cg_clif2/rust/build/bootstrap/debug/deps/libquote-51534bb9a71bfbd9.rlib --extern syn=/home/bjorn/Projects/cg_clif2/rust/build/bootstrap/debug/deps/libsyn-f967af3d96e2e23c.rlib --extern proc_macro --cap-lints allow -Cdebuginfo=2 -Wrust_2018_idioms -Wunused_lifetimes -Wsemicolon_in_expressions_from_macros` (signal: 11, SIGSEGV: invalid memory reference)

This seems to be an abi incompatibility with cg_llvm:

Backtrace
#0  0x000000400827a204 in ?? () from /usr/aarch64-linux-gnu/lib/libc.so.6
#1  0x0000004019b256e4 in core::slice::<impl [T]>::copy_from_slice () at /home/bjorn/Projects/cg_clif2/build_sysroot/sysroot_src/library/core/src/intrinsics.rs:1861
#2  0x0000004019b1d6ec in <u32 as proc_macro::bridge::rpc::DecodeMut<S>>::decode () at /home/bjorn/Projects/cg_clif2/build_sysroot/sysroot_src/library/proc_macro/src/bridge/rpc.rs:39
#3  0x0000004019b17b20 in <core::num::nonzero::NonZeroU32 as proc_macro::bridge::rpc::DecodeMut<S>>::decode ()
    at /home/bjorn/Projects/cg_clif2/build_sysroot/sysroot_src/library/proc_macro/src/bridge/rpc.rs:168
#4  0x0000004019b159fc in <proc_macro::bridge::client::TokenStream as proc_macro::bridge::rpc::DecodeMut<S>>::decode ()
    at /home/bjorn/Projects/cg_clif2/build_sysroot/sysroot_src/library/proc_macro/src/bridge/client.rs:116
#5  0x0000004019b16bf8 in <(A,B) as proc_macro::bridge::rpc::DecodeMut<S>>::decode () at /home/bjorn/Projects/cg_clif2/build_sysroot/sysroot_src/library/proc_macro/src/bridge/rpc.rs:183
#6  0x0000004019b15d64 in proc_macro::bridge::client::run_client::{{closure}}::{{closure}} ()
    at /home/bjorn/Projects/cg_clif2/build_sysroot/sysroot_src/library/proc_macro/src/bridge/client.rs:372
#7  0x0000004019b1c100 in proc_macro::bridge::scoped_cell::ScopedCell<T>::set::{{closure}} ()
    at /home/bjorn/Projects/cg_clif2/build_sysroot/sysroot_src/library/proc_macro/src/bridge/scoped_cell.rs:80
#8  0x0000004019b1c41c in proc_macro::bridge::scoped_cell::ScopedCell<T>::replace ()
    at /home/bjorn/Projects/cg_clif2/build_sysroot/sysroot_src/library/proc_macro/src/bridge/scoped_cell.rs:75
#9  0x0000004019b1c088 in proc_macro::bridge::scoped_cell::ScopedCell<T>::set () at /home/bjorn/Projects/cg_clif2/build_sysroot/sysroot_src/library/proc_macro/src/bridge/scoped_cell.rs:80
#10 0x0000004019b16914 in proc_macro::bridge::client::<impl proc_macro::bridge::Bridge>::enter::{{closure}} ()
    at /home/bjorn/Projects/cg_clif2/build_sysroot/sysroot_src/library/proc_macro/src/bridge/client.rs:325
#11 0x0000004019b1bec4 in std::thread::local::LocalKey<T>::try_with () at /home/bjorn/Projects/cg_clif2/build_sysroot/sysroot_src/library/std/src/thread/local.rs:399
#12 0x0000004019b1b3e0 in std::thread::local::LocalKey<T>::with () at /home/bjorn/Projects/cg_clif2/build_sysroot/sysroot_src/library/std/src/thread/local.rs:375
#13 0x0000004019b19580 in proc_macro::bridge::client::<impl proc_macro::bridge::Bridge>::enter ()
    at /home/bjorn/Projects/cg_clif2/build_sysroot/sysroot_src/library/proc_macro/src/bridge/client.rs:325
#14 0x0000004019b15c24 in proc_macro::bridge::client::run_client::{{closure}} () at /home/bjorn/Projects/cg_clif2/build_sysroot/sysroot_src/library/proc_macro/src/bridge/client.rs:370
#15 0x0000004019b2386c in <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once ()
    at /home/bjorn/Projects/cg_clif2/build_sysroot/sysroot_src/library/std/src/panic.rs:341
#16 0x0000004019b21364 in std::panicking::try::do_call () at /home/bjorn/Projects/cg_clif2/build_sysroot/sysroot_src/library/std/src/panicking.rs:401
#17 0x0000004019b21170 in std::panicking::try () at /home/bjorn/Projects/cg_clif2/build_sysroot/sysroot_src/library/std/src/panicking.rs:365
#18 0x0000004019b15b18 in proc_macro::bridge::client::run_client () at /home/bjorn/Projects/cg_clif2/build_sysroot/sysroot_src/library/std/src/panic.rs:428
#19 0x0000004019b16048 in proc_macro::bridge::client::Client<fn(proc_macro::TokenStream,proc_macro::TokenStream) -> proc_macro::TokenStream>::expand2::run ()
    at /home/bjorn/Projects/cg_clif2/build_sysroot/sysroot_src/library/proc_macro/src/bridge/client.rs:425
#20 0x00000040054f48f0 in proc_macro::bridge::server::run_server () from /home/bjorn/.rustup/toolchains/nightly-2021-06-30-aarch64-unknown-linux-gnu/lib/librustc_driver-5839d4fe983c4c9c.so
#21 0x00000040054d6c74 in <rustc_expand::proc_macro::AttrProcMacro as rustc_expand::base::AttrProcMacro>::expand ()
   from /home/bjorn/.rustup/toolchains/nightly-2021-06-30-aarch64-unknown-linux-gnu/lib/librustc_driver-5839d4fe983c4c9c.so
#22 0x00000040054c4a5c in rustc_expand::expand::MacroExpander::fully_expand_fragment ()
   from /home/bjorn/.rustup/toolchains/nightly-2021-06-30-aarch64-unknown-linux-gnu/lib/librustc_driver-5839d4fe983c4c9c.so
#23 0x00000040054c2630 in rustc_expand::expand::MacroExpander::expand_crate ()
   from /home/bjorn/.rustup/toolchains/nightly-2021-06-30-aarch64-unknown-linux-gnu/lib/librustc_driver-5839d4fe983c4c9c.so
#24 0x0000004001b79d90 in rustc_session::utils::<impl rustc_session::session::Session>::time ()
   from /home/bjorn/.rustup/toolchains/nightly-2021-06-30-aarch64-unknown-linux-gnu/lib/librustc_driver-5839d4fe983c4c9c.so
#25 0x0000004001b9d9b8 in rustc_interface::passes::configure_and_expand_inner ()
   from /home/bjorn/.rustup/toolchains/nightly-2021-06-30-aarch64-unknown-linux-gnu/lib/librustc_driver-5839d4fe983c4c9c.so
#26 0x0000004001b77e44 in rustc_interface::passes::boxed_resolver::BoxedResolver::new ()
   from /home/bjorn/.rustup/toolchains/nightly-2021-06-30-aarch64-unknown-linux-gnu/lib/librustc_driver-5839d4fe983c4c9c.so
#27 0x0000004001b83f60 in rustc_interface::queries::Queries::expansion ()
   from /home/bjorn/.rustup/toolchains/nightly-2021-06-30-aarch64-unknown-linux-gnu/lib/librustc_driver-5839d4fe983c4c9c.so
#28 0x0000004001abba3c in rustc_interface::queries::<impl rustc_interface::interface::Compiler>::enter ()
   from /home/bjorn/.rustup/toolchains/nightly-2021-06-30-aarch64-unknown-linux-gnu/lib/librustc_driver-5839d4fe983c4c9c.so
#29 0x0000004001a892ac in rustc_span::with_source_map () from /home/bjorn/.rustup/toolchains/nightly-2021-06-30-aarch64-unknown-linux-gnu/lib/librustc_driver-5839d4fe983c4c9c.so
#30 0x0000004001abcc04 in rustc_interface::interface::create_compiler_and_run () from /home/bjorn/.rustup/toolchains/nightly-2021-06-30-aarch64-unknown-linux-gnu/lib/librustc_driver-5839d4fe983c4c9c.so
#31 0x0000004001a8e3ec in scoped_tls::ScopedKey<T>::set () from /home/bjorn/.rustup/toolchains/nightly-2021-06-30-aarch64-unknown-linux-gnu/lib/librustc_driver-5839d4fe983c4c9c.so
#32 0x0000004001abd740 in std::sys_common::backtrace::__rust_begin_short_backtrace () from /home/bjorn/.rustup/toolchains/nightly-2021-06-30-aarch64-unknown-linux-gnu/lib/librustc_driver-5839d4fe983c4c9c.so
#33 0x0000004001a70fcc in core::ops::function::FnOnce::call_once{{vtable-shim}} () from /home/bjorn/.rustup/toolchains/nightly-2021-06-30-aarch64-unknown-linux-gnu/lib/librustc_driver-5839d4fe983c4c9c.so
#34 0x0000004008100674 in <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once () at /rustc/6d820866a27b1949e237be79b9c8c0145fe728b7/library/alloc/src/boxed.rs:1575
#35 <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once () at /rustc/6d820866a27b1949e237be79b9c8c0145fe728b7/library/alloc/src/boxed.rs:1575
#36 std::sys::unix::thread::Thread::new::thread_start () at library/std/src/sys/unix/thread.rs:72
#37 0x00000040083867e4 in start_thread () from /usr/aarch64-linux-gnu/lib/libpthread.so.0
#38 0x00000040082c698c in ?? () from /usr/aarch64-linux-gnu/lib/libc.so.6

At the moment of the crash the register state is:
x0             0x4008d61820<PHONE_NUMBER>52
x1             0x910003fda9bf7bfd  -7998388550200493059
x2             0x4                 4

For a memcpy that represents the dst, src and count arguments. They may have already been clobbered by this point though. I can't seem to get attaching a debugger to qemu emulated programs working natively though, so I can't really tell if it was clobbered or not.

With de7342b4446476a2d9375a7f93be54dc9f8707d1 and 244455d8e3137f3bd3e2ee6a49ebb787e7d7f792, all rustc tests now pass on AArch64 with the Cranelift main branch. Bootstrapping rustc also works.


feature(typescript_indexer): extend symbol cache to store contexts

Create a proper caching instance for the TypeScript indexer that caches
VNames for a symbol under a particular TypeScript namespace and symbol
declaration context.
Cache lookups are done by querying a 2-layer map, mapping from a symbol
to a serialized namespace and context to a VName. The namespace and
context must be serialized because object instances are always unique in
JavaScript, and creating a new object for each lookup would render the
cache useless. An alternative to this would be to store an object with
namespace/context tuples:
interface { [nsctx: [TSNamespace, Context]]: VName }

but TypeScript doesn't support this.
This PR also moves some blocks of code around so they make more sense in
their spatial and contextual locations.

Let's get #3909 first before merging this.
cc @evmar, @zzmp

This is hard to review because it mixes code moves with code changes, can you split it?

yep, that's my bad. Fixed. Also renamed the VName cache to SymbolVNameStore to better represent its purpose.


Update cluster-unavailability-troubleshooting.md

Updating to reflect the output from SHOW DATABASES in v2.0

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/c9ff99ce3304c2b500a57f151cf4ffce38074dd4/

LGTM. Thanks for the update, @rkruze, and sorry for the delay.


Tokens that not listed

Hello, I have few questions about the ERC20 tokens
I have the offline wallet, and i wanted to send there a token that is not listed in the default token list
what happens when I send that tokens to the wallet that tokens are not listed in?
Do they dissapear?
lets say they are not dissapear , if i come back after a year and making "custom add" , will it recognize them?
and the last question is, could you add IFT (investfeed token) to the default list in the next update?
Thx
good day

You tokens are held on the blockchain and adding a token to MEW is simply adding it to the user interface. You can access any tokens on MEW via our interface or another interface at any time via the add custom token.

You can read about how to add a new default token here: https://myetherwallet.groovehq.com/knowledge_base/topics/i-just-created-a-new-token-can-you-add-it-to-mew


use base java images provided by docker

These are newer base images provided and curated by Docker.

Thanks for contribution. Yes, we should definitely use the offical java images curated by Docker. Merged to master.


README: Add reference to SPIR-V size reduction white paper

Rebased and pushed onto master as cdeb669541


Add auto dark mode/light mode switching based on system preference

This feature is currently only included in the default light/dark mode setup: https://github.com/saadeghi/daisyui/blob/ae4f2a1d9e2e957ff683feb49d7fe7f0cd0ed312/src/index.js#L119-L120
Would be nice if you could do something like mytheme-light and mytheme-dark and have it be picked up the same way.

Now you can specify one of themes to be the default dark mode theme (based on prefers-color-scheme: dark):
https://play.tailwindcss.com/CLrZGvf3ww?file=config
And the first item in themes config will be the default light theme.


Support sharing binary files

Currently, it does not seem Live Share works for editor tabs other than code/text. It would be great if at least sharing the look of an image tab would be possible. I.e.

Start Live Share in Visual Studio for user A
Open Live Share by user B
User A opens an image e.g. Image.png in Visual Studio.
User B cannot see this image or editor tab for the image

Live Share <IP_ADDRESS> in Visual Studio 2017

Thanks for the feedback, @nietras. We'll leave this open and see if we get any other input.

I think that a warning should appear that sending binary files over Live Share is not supported. Otherwise people can be confused.
See https://github.com/MicrosoftDocs/live-share/issues/3308

I am trying to visualize an image output from a live share session, but the file is not shown properly. Also when I tried to donwloaded it local it does not work.

@cyberbiont Are there any plans if that will be supported in the future? I think it would be a great addition and very convenient if all participants in the session would be able to also see image on the side of the host.
For example: I am currently using liveshare to work on project with some other people, which produces images as output. Now only the host of the session can see the output, but nobody else in the session. Not a great workflow.
I think liveshare should have such functionality. If there are security concerns for this, you could still have it disabled by default and make it a setting that can manually enabled, if people are okay with that.

@cyberiont @fubaduba
Are there any plans to add this in the near future?
I am currently working on a project with some other people over liveshare, where images are produced as output.
Currently only the host can view the output, but no other participant in the session.
I really think this would be a great (and needed) addition for a good workflow.

Hey @lostintangent @daytonellwanger,
Do you have any news on the discussions you planned for the new year on this topic? :)
Thanks in advance!

Hey @lostintangent @daytonellwanger,
Do you have any news on the discussions you planned for the new year on this topic? :)
Thanks in advance!

@Davsterl as well.
I think this is a great addition to Live Share, and technically it's pretty easy to achieve. The only barrier is the compliance/regulatory hurdles to overcome, which I don't have a full understanding of.

@Davsterl as well.
I think this is a great addition to Live Share, and technically it's pretty easy to achieve. The only barrier is the compliance/regulatory hurdles to overcome, which I don't have a full understanding of.

Hey!
I tried getting around this limitation.
In Markdown there is a way to embed images with the data:base64 attribute. While this works, it bloats the file immensely as the full picture would have to be embedded into the text file.
There is a real need for binary transfers. If there are barriers regarding regulatory issues, maybe you could limit the binary support to just png or image files for example.
I hope there will be progress soon. Thumbs pressed!

Hey!
I tried getting around this limitation.
In Markdown there is a way to embed images with the data:base64 attribute. While this works, it bloats the file immensely as the full picture would have to be embedded into the text file.
There is a real need for binary transfers. If there are barriers regarding regulatory issues, maybe you could limit the binary support to just png or image files for example.
I hope there will be progress soon. Thumbs pressed!

I hope we can push this issue forward to implement the feature sooner than later.
Meanwhile, is this a clientside only topic or does the live-share protocol need to be changed?
I would like to work around this issue until it might get solved in the future.
Big thanks for the discussion so far!

Hey @H8to , you could always work around this by syncing binary files yourself with an extension that adds Live Share support via our extensibility API. We'll provide the connectivity layer, and you just need to provide business logic on top.

Hey, I had a look into this over the weekend, but struggle with it as I'm not a developer 😅
My last hope is the implementation of this feature as it allows for

copying images into liveshare sessions from the clipboard
working on LaTeX documents with several people at the same time.

Same will be true for markdown, even if we would be fine with pngs being allowed.
Please give it another look 🤓

This is now resolved and will be included in the upcoming Live Share release. Thanks!

@lostintangent … as of today this still does not seem to be fixed. Can you give an update? Should i open a new issue?

Today, I just wasted two hours until realizing that the images were in fact tainted from myself moving them to a new directory during a session ( I did not start the session).

Going to continue the echoes for an update. Was working with binary files and spent hours trying to fix an issue that occurred only because of using this feature to transfer the file.

Still seems to not be working - trying to open an image in live share gives "An error occurred while loading the image. Open file using VS COde's standard text/binary editor?" And doing so gives binary bullshit, e.g. <ш4y���*��xƭ�Z-�&�z�"�}��

still a problem for me not even pasting the bytes from the image and pasting them into the file works


[Feature Request] Rally point and poke adding some description text

Would be nice to have possibility to add some short message in the body of email ( in our case Slack ) message.
On the bottom, like :
Message:   Capitals in the static
Map:        Mordor
System:        J212612
Region:        F-R00030
Security:    C6
Character:    Johnson
Time:        10:48 pm; August 16, 2016

I talked to my corpmates and this is must have addition, because currently there is no intel inside this poke, maybe if it helps strip Region and replace it with Message.

this would be nice, i'd like to see this added but also can we get issue 297 tagged to get fixed @exodus4d

@rmcginnis you got your fix, now I want my feature  :o)

I´m curious if others are happy with information which are added to poke, my corpmates asking for description text because if they getting Slack notify , they don´t know if the poke is important or not.

@exodus4d can you look on the feature now ? Descriptive text and @everyone tag, that on Slack everybody on channel getting notify from Slack app on mobile phone.


fixes #438

fixes #438: if URI is given in proxy_pass then nginx decodes and re-encodes path
which breaks submission attachment with special characters in webform more details: https://trac.nginx.org/nginx/ticket/2506
What has been done to verify that this works as intended?
Manually verified it locally and on Dev server
Why is this the best possible solution? Were any other approaches considered?
This is simplest and safest fix. I am going to create separate issue to investigate encoding protocol between Central and Enketo.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
None
Does this change require updates to documentation? If so, please file an issue here and include the link below.
None
Before submitting this PR, please make sure you have:

[ ] verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

Targeting the next branch because I think we'll release the patch off of next.