Set registers in Flex Server

Feature
Added a function to inject values directly into the Flex-Server.
Currently only 8 and 16bit writes are supported.
Should also solve the https://github.com/biancode/node-red-contrib-modbus/pull/124#issuecomment-480552650 request
Bugfix
Fixed a Bug in funcGetDiscreteInput.
It was not possible to get the state of address 0
Tested on
Device : Raspberry Pi
Linux: Debian 9.4

Linux 4.14.52-v7+ arm LE
Node-RED version: v0.18.7
Node.js  version: v8.11.3
node-red-contrib-modbus version: 4.1.3

TCP Test done with Radzio! Modbus Master Simulator

I have to do some tests on v0.20 of node-red and v10 of nodejs to release it. Thank you!

Hi have you got an example of this please I'm trying this but don't seem to be even able to generate an error.
I too would like to achieve the same goal as https://github.com/biancode/node-red-contrib-modbus/pull/124#issuecomment-480552650 I'm surprised there aren't more people trying to do this.
[     {         "id": "9f1c31db.f86f2",         "type": "inject",         "z": "7c901ce1.97f324",         "name": "",         "topic": "",         "payload": "[0]",         "payloadType": "bin",         "repeat": "",         "crontab": "",         "once": false,         "onceDelay": 0.1,         "x": 170,         "y": 160,         "wires": [             [                 "fcd0afb0.7a1cf"             ]         ]     },     {         "id": "fa376833.7c3268",         "type": "inject",         "z": "7c901ce1.97f324",         "name": "",         "topic": "",         "payload": "[1]",         "payloadType": "bin",         "repeat": "",         "crontab": "",         "once": false,         "onceDelay": 0.1,         "x": 170,         "y": 200,         "wires": [             [                 "fcd0afb0.7a1cf"             ]         ]     },     {         "id": "fcd0afb0.7a1cf",         "type": "function",         "z": "7c901ce1.97f324",         "name": "",         "func": "let value = msg.payload;\nmsg.payload = {\n    register:'input', \n    address: 0,\n    value:value\n}\nreturn msg;",         "outputs": 1,         "noerr": 0,         "x": 360,         "y": 180,         "wires": [             [                 "4ace8df4.f5aad4",                 "6e630377.f85cdc"             ]         ]     },     {         "id": "6e630377.f85cdc",         "type": "modbus-flex-server",         "z": "7c901ce1.97f324",         "name": "",         "logEnabled": true,         "serverAddress": "<IP_ADDRESS>",         "serverPort": 11502,         "responseDelay": "0",         "unitId": 1,         "delayUnit": "ms",         "coilsBufferSize": "2",         "registersBufferSize": "2",         "minAddress": 0,         "splitAddress": "1",         "funcGetCoil": "function getFlexCoil(addr, unitID) {\n\tif (unitID === node.unitId && \n\t\taddr >= node.minAddress && \n\t\taddr <= node.splitAddress) { \n\n\t\treturn node.coils.readUInt8(addr * node.bufferFactor) \n\t}  \n}",         "funcGetDiscreteInput": "function getFlexDiscreteInput(addr, unitID) {\n\taddr += node.splitAddress\n\tif (unitID === node.unitId && \n\t\taddr > node.splitAddress && \n\t\taddr <= node.splitAddress * 2) { \n\n\t\treturn node.coils.readUInt8(addr * node.bufferFactor) \n\t}  \n}",         "funcGetInputRegister": "function getFlexInputRegister(addr, unitID) { \n\tif (unitID === node.unitId && \n\t\taddr >= node.minAddress && \n\t\taddr <= node.splitAddress) { \n\n\t\treturn node.registers.readUInt16BE(addr * node.bufferFactor)  \n\t} \n}",         "funcGetHoldingRegister": "function getFlexHoldingRegsiter(addr, unitID) { \n\taddr += node.splitAddress\n\tif (unitID === node.unitId && \n\t\taddr >= node.splitAddress && \n\t\taddr <= node.splitAddress * 2) { \n\n\t\treturn node.registers.readUInt16BE(addr * node.bufferFactor)  \n\t} \n}",         "funcSetCoil": "function setFlexCoil(addr, value, unitID) { \n\tif (unitID === node.unitId && \n\t\taddr >= node.minAddress && \n\t\taddr <= node.splitAddress) { \n\n\t\tnode.coils.writeUInt8(value, addr * node.bufferFactor)  \n\t} \n}",         "funcSetRegister": "function setFlexRegister(addr, value, unitID) { \n\taddr += node.splitAddress\n\tif (unitID === node.unitId && \n\t\taddr >= node.splitAddress && \n\t\taddr <= node.splitAddress * 2) { \n\n\t\tnode.registers.writeUInt16BE(value, addr * node.bufferFactor)  \n\t} \n}",         "showErrors": true,         "x": 600,         "y": 200,         "wires": [             [                 "d3191ed7.41aaa"             ],             [                 "d3191ed7.41aaa"             ],             [                 "d3191ed7.41aaa"             ],             [                 "d3191ed7.41aaa"             ]         ]     } ] that last node not included is just a debug


clang-tidy-sarif 0.3.2 panics

The recently released clang-tidy-sarif v0.3.2 panics on parsing the command line arguments.
clang-tidy-sarif v0.3.1 works correctly.
$ touch in.txt
$ ./clang-tidy-sarif in.txt
thread 'main' panicked at 'Must use `Arg::allow_invalid_utf8` with `_os` lookups at `[hash: 912D1D99AB2F394C]`', /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/clap-3.2.15/src/parser/matches/arg_matches.rs:1732:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This seems to be related to a change from clap 3.2.0 (https://github.com/clap-rs/clap/blob/master/CHANGELOG.md#320---2022-06-13)
I'll try to send a PR with the fix once I get some time.

@igrr thanks for the report -- i believe https://github.com/psastras/sarif-rs/pull/284 should fix this which will be bundled in 0.3.3

@igrr 0.3.3 is released with the fix. please try it and let me know if it doesn't fix the issue for you.

Thanks for the very quick fix, I can confirm that 0.3.3 works fine!
and thanks for developing and maintaining this very useful project!


feat: supporting the new version mechanism

I have read the CLA Document and I hereby sign the CLA

I have read the CLA Document and I hereby sign the CLA

:tada: This PR is included in version 4.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


sepsis survival prediction

ML-Crate Repository (Proposing new issue)
:red_circle: Project Title : sepsis survival prediction
:red_circle: Aim : to determine if patient died or survived after sepsis
:red_circle: Dataset : https://www.kaggle.com/datasets/joebeachcapital/sepsis-survival-minimal-clinical-records/data
:red_circle: Approach : Try to use 3-4 algorithms to implement the models and compare all the algorithms to find out the best fitted algorithm for the model by checking the accuracy scores. Also do not forget to do a exploratory data analysis before creating any model.

Data Loading
Data Cleaning and preprocessing
EDA
Modelling
Preprocessing
Evaluation

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.

:white_check_mark: To be Mentioned while taking the issue :

Full name : Aditya D
GitHub Profile Link :  https://www.github.com/adi271001
Participant ID (If not, then put NA) : NA
Approach for this Project : 1. Data Loading

Data Cleaning and preprocessing
EDA
Modelling
Preprocessing
Evaluation

What is your participant role? (Mention the Open Source Program name. Eg. HRSoC, GSSoC, GSOC etc.) VSOC Contributor

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Assigned @adi271001


[BUG] Application Insights reports 'not_specified' to Azure when tracking unhandled browser exception

Description/Screenshot
Application Insights has automatic exception tracking enabled by default.
However, it seems to assume that the exception is always of type Error.
If the exception is simply a string, the trackException itself fails, throws an exception with message 'not_specified'.
Steps to Reproduce
Here is my setup:
import { DebugPlugin } from '@microsoft/applicationinsights-debugplugin-js';
import { ApplicationInsights } from '@microsoft/applicationinsights-web'

// Initialize AppInsights
const toTrack = [
	'trackEvent',
	'trackPageView',
	'trackPageViewPerformance',
	'trackException',
	'trackTrace',
	'trackMetric',
	'trackDependencyData',
	'throwInternal',        // called when a message is logged internally
	'logInternalMessage',   // called when a message is logged internally
	'triggerSend',          // called when data is queued to be sent to the server
	'_sender',              // called when data is sent to the server
];
const debugPluginInstance = new DebugPlugin();
const applocation = this.AppLocation;
const pageName = EAppLocationPage[applocation.Page];
const appInsights = new ApplicationInsights({
	config: {
		connectionString: (window as any).appInsightsConfig.connectionString,
		extensions: [debugPluginInstance],
		extensionConfig: {
			[DebugPlugin.identifier]: {
				trackers: toTrack
			}
		},
		disableExceptionTracking: false,
		enableDebug: false,
		loggingLevelConsole: 2, //0: off, 1: Critical errors only, 2: Everything(errors & warnings)
		loggingLevelTelemetry: 2, //0: off, 1: Critical errors only, 2: Everything(errors & warnings)
		enableRequestHeaderTracking: true,
		enableResponseHeaderTracking: true,
		correlationHeaderExcludedDomains: ['*.queue.core.windows.net']
	}
});
appInsights.setAuthenticatedUserContext((window as any).appInsightsConfig.authenticatedUserContext);
appInsights.addTelemetryInitializer((x) => {
	x.tags!['ai.operation.name'] = 'Full_Load/' + pageName;
});
appInsights.loadAppInsights();

When I throw a dummy exception with simply a string message in the console to test AI's auto trackException, this is what AI does:
(Stacktrace shown by using the @microsoft/applicationinsights-debugplugin-js plugin.)

It seems that AI then itself fails, as it does not expect a string, but an Error.
This it what is then reported to Azure:

AnalyticsPlugin/</_self[_DynamicConstants__WEBPACK_IMPORTED_MODULE_1__._DYN_SEND_EXCEPTION_INTER13]@https://localhost:44385/js/ViewModels/patientsViewModel.min.js?v=PVKRkSfmexWSsx2UaNtVhIFEkwUYJoTDiuQ6OoT7Tyw:15684:224
AnalyticsPlugin/</_self.trackException@https://localhost:44385/js/ViewModels/patientsViewModel.min.js?v=PVKRkSfmexWSsx2UaNtVhIFEkwUYJoTDiuQ6OoT7Tyw:15703:138
dynProtoProxy@https://localhost:44385/js/ViewModels/patientsViewModel.min.js?v=PVKRkSfmexWSsx2UaNtVhIFEkwUYJoTDiuQ6OoT7Tyw:33706:29
_createFunctionHook/<@https://localhost:44385/js/ViewModels/patientsViewModel.min.js?v=PVKRkSfmexWSsx2UaNtVhIFEkwUYJoTDiuQ6OoT7Tyw:26241:119
_createProxyFunction/<@https://localhost:44385/js/ViewModels/patientsViewModel.min.js?v=PVKRkSfmexWSsx2UaNtVhIFEkwUYJoTDiuQ6OoT7Tyw:25946:112
@debugger eval code:1:20

If I throw an exception in code of type Error and catch it myself to manually call trackException(),
try {
	throw new Error('TESTPIETER FULL');
}
catch (error) {
	if (error instanceof Error) {
		appInsights.trackException({
			exception: error
		});
	} else {
		appInsights.trackException({
			exception: new Error(error as string)
		});
	}
}

then I see the following:

And the error is correctly reported to Azure:

So, to me, it seems that AI exception tracking does not work correctly out of the box.
Currently, I would need to override the current global exception handler of the browser, to convert a string exception to an Error and call trackException() manually.
This should be done by AI itself out of the box.

OS/Browser: Any browser
SDK Version [e.g. 22]: 2.8.9
How you initialized the SDK: npm

https://github.com/microsoft/ApplicationInsights-JS/issues/1006

This issue also rises here:
https://github.com/OfficeDev/microsoft-teams-library-js/issues/577

We "should" be handling string "exceptions" and we have specific tests and code to handle this.
But at least on looking at the code it does appear that when using the snippet a "string" won't necessarily be handled (it falls back to window.event so it will work on some browsers).
For the scenario provided (using NPM) this should be working as it should come through this hook for the window.onerror https://github.com/microsoft/ApplicationInsights-JS/blob/master/extensions/applicationinsights-analytics-js/src/JavaScriptSDK/AnalyticsPlugin.ts#L699-L706 so it should "not" be calling trackException with a string value (the snippet onerror does look like this will happen)

Just a note to inform that this issue is not forgotten, but due to scheduling conflicts, release lockdowns and holidays it's probably going to be early next year (2023) before I can carve out a decent amount of time to understand why strings are not always supported... I suspect that we will need to move the current string detecting code a little deeper in the stack.

Allocating to the next release, but there is a risk (depending on the size of any required change) that it may not make this release.

Great, thanks for following up!

Ok, I've tried 4 scenarios

Just call throw "string error" -> resulted in the window.onerror to get called (Chromium based Edge) with an Error with the message set as the string -- works
Directly call trackException(theError: IExceptionTelemetry) with a string as the exception value -- works when called directly or in a catch with the caught string. See here for the definition of the trackException arguments
Directly call trackException("string value") -- resulting in what looks like your scenario Error being reported in the sendExceptionInternal as it wraps the provided first object (which is supposed to be an IExceptionTelemetry object) in an error -- This is considered to be an invalid usage of the API

    <button onclick="javascript: throw 'String Error'">Throw String Exception</button>
    <button onclick="javascript: appInsights.trackException({ exception: 'String Error' })"">trackException with String as the exception</button>
    <button onclick="javascript: try { throw 'String Error'; } catch(e) { appInsights.trackException({exception: e})}">trackException with try / catch</button>
    <button onclick="javascript: appInsights.trackException('String Error')"">trackException with String</button>

So while I could instead use our helper dumpObj() function to dump the object as theError instead of creating a new Error instance, there could still be other issues as the rest of the code is still attempting to use the first argument as an iExceptionTelemetry instance...
So you "should" be able to just use the following
try {
	throw 'TESTPIETER FULL';
}
catch (error) {
   appInsights.trackException({
	exception: error
   });
}

or just let the exception bubble up to the window.onerror handler.
Here is a screendump of the appInsights.trackException("String Error") version, this is also the same for the try / catch example

For the one where I let it bubble to the window.onerror

And finally with appInsights.trackexception({ exception: "String Error" })

The screen dumps where taken using F12 dev tools with the breakpoint @ https://github.com/microsoft/ApplicationInsights-JS/blob/65fddb125b16af1b1da0348f0e7eaa3368241f11/extensions/applicationinsights-analytics-js/src/JavaScriptSDK/AnalyticsPlugin.ts#L427 this is after we have created the envelope (the event detail) but before we send it off for batching.
Shorter answer

I just figured out that in 1 place we were in fact using trackException with the wrong type of parameter.

Although this will not be the cause of all of our errors.

The PR that I've just pushed in (so it will be in the next release) provides a "fallback" cases for cases where someone passes a non-IExceptionTelemetry (doesn't contain an error or exception object) to attempt to convert to provide more information.
This has test coverage and appears to now be handling strings or Error instances directly (as well as null / undefined which should be the only cases for the "not_specified" now)

Great!


Make K8s secrets watchable (#680)

Extracts common watch functionality for secrets and config-maps into abstract base classes and implement those for the dedicated sub types, so that watch config looks the same for both types and has the same base implementation.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@n0tl3ss please test this feature in production k8s deployment and resolve the failing tests. Thanks.

Thanks for the contribution!


Write single pages for python packages

Landing pages in the Other Packages section are blank for now, should be simple content for most, quickly taken from their READMEs

Closed by #22


send browser finegrprint on every request

@Kirkkt

test/test.html seems broken, can you double-check?

it thorws some errors for me, but they don't seem to be related - i see errors with the history pushstate - but i get those on master too

all tests passed on the latest master branch for me
for starters, can you doublecheck whether you need to update this test https://github.com/BranchMetrics/Smart-App-Banner-Deep-Linking-Web-SDK/blob/send-browser-fingerprint-id/test/6_branch.js#L400 ?

weird - those are not failing on me, but they definitely would need to be changed. hmm, something is definitely fishy here

fixed

:+1:


Lost "wan" interface in the JSON output.

Hi, I updated to latest version of pfSense 2.3.4-RELEASE (amd64)
Then I lost my "wan" interface in the JSON output.
If I print the "$a_gateways" I get this:
Array (
[VPN_VPNV4]	=> Array (
[interface] => bge1
[gateway] => dynamic
[name] => VPN_VPNV4
[weight] => 1
[ipprotocol] => inet
[interval] =>
[descr] => Interface VPN_VPNV4 Gateway
[dynamic] => 1
[monitor] => dynamic
[friendlyiface] => lan
[attribute] => 0
)
[WAN_DHCP] => Array (
[interface] => bge0
[gateway] => <IP_ADDRESS>
[name] => WAN_DHCP
[weight] => 1
[ipprotocol] => inet
[interval] =>
[descr] => Interface WAN_DHCP Gateway
[defaultgw] => 1
[dynamic] => 1
[monitor] => <IP_ADDRESS>
[friendlyiface] => wan
[attribute] => 1
)
)
But the JSON output is:
{"lan":{"inKbps":3864.2620418484,"outKbps":5268.2221868671,"interface":"bge1"}}
Not sure why this happens... Any ideas? :)
Best regards Snille

Looks like the "$gateways_status" variable is just an empty array.
Maybe that's why it does not work?

It's possible it's something with a newer version of PHP they're using.  I haven't upgraded to the latest pfSense yet so can't check myself right now.  But from looking at the latest code, they seem to initialize the variable with array() before calling return_gateways_status():

$gateways_status = array();
$gateways_status = return_gateways_status(true);

Try adding that first line and see if it works for you.  If so, I'll update the repo.  Thanks!

Nope, still only get the "lan" interface in the json. :(

from their code, really the only other line from pfsense's "status_gateways.php" there is require_once("guiconfig.inc");. Perhaps they changed something that requires that first.  Maybe try dropping the following php file into that directory to see if that gives you anything.
testgateways.php:
require_once("guiconfig.inc");
//define('COLOR', true);
$a_gateways = return_gateways_array();
$gateways_status = array();
$gateways_status = return_gateways_status(true);
print_r($gateways_status);

Nope, just an empty array... :(
Array ( )

That's really strange then, possible something else is going on then with your setup, because that's the exact code from the pfsense interface!  how about when you visit your router's "Status: Gateways" page.  Does that show the information, or is it blank too?  http://routerip/status_gateways.php

Oh, that gave a hint! :)
First I got this when entering the URL:

Then I wounder, is that really right.... So I "restarted" the gateways? (clicked the circle arrow at the top right corner) and then I got this:

And now it works! :)
Sorry for all your troubles... I actually did not know you could restart the "gateways". :)

ok great, glad you finally solved it!  hopefully this thread will at least help others who also run into the same issue! 👍


[Enhancements] Streaming option + Query Parameters

Hi there!
In my app, I needed these enhancements: stream data directly (instead of multipart) and (due to API characteristics) query parameters support. So... I decided to share those with the community.

@Amir-P change request fulfilled.

@Amir-P I had some commits pending push. Now everything is ok.


New Sub module - cognitive service account

Overview
This PR contains a new module for creating a cognitive services account. It references the current version of TF being used by ALZ (2.64.0). Within the locals.tf file a new local object is created for cognitive_service since there wasn't another one where it would fit.
Testing
This code was tested by a QnAMaker kind and a non QnaMaker resource. It also leverages most of the optional parameters. The only one that wasn't fully tested was the virtual_network_subnet_ids, the reason being that the necessary subnet service endpoint was not configured. but I believe this is fine since my code was able to reference a subnet ID and Terraform was successfully able to pick it up (even if it didn't accept it).
.....
virtualNetworks/vnet-eus2-test-spoke do not have ServiceEndpoints for Microsoft.CognitiveServices resources configured. Add Microsoft.CognitiveServices to subnet's ServiceEndpoints collection before trying to ACL Microsoft.CognitiveServices resources to these subnets."

hi @abdulrabbani00, I'll integrate this one on a branch (abdulrabbani00-sub-module/cognitive-service) where i have changed:

adding CI/CD
modified cognitive_services to plural
added outputs


Default block enhancements

This improves the highlighting of the default block properties. The scoping of property prefixes like "Weapon." and "Player." are more accurately described as classes.

Do you (and @PROPHESSOR) mind if I backport these (#6 and #7) fixes to the my fork?
Also, do you have any "example" files where I can see the issues happening myself?
Anyway, thanks for the help.

Do you (and @PROPHESSOR) mind if I backport these (#6 and #7) fixes to the my fork? Also, do you have any "example" files where I can see the issues happening myself? Anyway, thanks for the help.

I personally have no problem with that! I can set up a gist here that can reproduce the problems #6 and #7 produce: https://gist.github.com/DenisBelmondo/e6423945692e0b15b1421f68faf819c6


Pinot column to support no dictionary indexing

The basic idea is dictionary may not benefit too much for the columns with very high cardinality like gps points/uuid, we may just store raw double/string.
This required change either interface of getting object from forward index or we can make a NoopDictionary which point to the foward indexes for raw value fetch.

This has a been a long outstanding item in our back log :). I like the idea of NoOp dictionary as it does not change the interfaces. However, JF or Mayank might have thought about this a bit more than me. Should be worth a discussion with them.

Thanks for starting the issue @fx19880617. This is critical for improving scan performance on high cardinality columns e.g metrics and string columns where maintaining dictionary does not make sense.
While our initial goal was to not expose Dictionary outside of data source, parts of existing code make direct reference to Dictionary. The No-Op dictionary can only work for columns with columns of int data type.
We should use this to fix the usage of dictionary class outside of data source. This will involve changes across all operators but I don't see any other option. But I think it's worth the effort, it will allow us to improve performance drastically in some scenarios.
Here are my thoughts.
Most operators work on Blocks and use the BlockValSet to read values. But unfortunately, they first read the dictionary ids
  void readIntValues(int[] inDocIds, int inStartPos, int inDocIdsSize, int[] outDictionaryIds, int outStartPos);
and then use dictionary interface to read actual values.
void readIntValues(int[] dictionaryIds, int startPos, int limit, int[] outValues, int outStartPos);
void readLongValues(int[] dictionaryIds, int startPos, int limit, long[] outValues, int outStartPos);
void readDoubleValues(int[] dictionaryIds, int startPos, int limit, double[] outValues, int outStartPos);
void readFloatValues(int[] dictionaryIds, int startPos, int limit, float[] outValues, int outStartPos);
void readStringValues(int[] dictionaryIds, int startPos, int limit, String[] outValues, int outStartPos);

We need to provide reading the actual value on block val set. This allows the data source to handle dictionary/no dictionary case transparently.
The downside of this is that some of the operators might benefit by using raw dictionaryId instead of actual value. Which means we have to provide both methods on blockValSet readDictionaryIds and readValues.
I will give it a try and see how the interfaces look. We also have some usage of dictionary in filter phase but its much easier to push down that functionality to data source.


Sprites become corrupted at random as more sprites are spawned

Bevy version
0.6.1
Operating system & version
Pop!_OS 21.10
What you did
I simply had a system to spawn fireballs from a player position on click. After extensive testing, I've determined that any sort of sprite spawning at all has a chance to cause this, even on a fixed timestep.
What you expected to happen
Sprites should show up on the screen and work as normal.
What actually happened
The sprites gradually became corrupted at random as more sprites are spawned. As an example:

The affected sprites seem to be completely random - sometimes the fireballs are corrupted, while other times the player sprite is the one corrupted.
Additional information
My graphics card information as given by bevy:
INFO bevy_render::renderer: AdapterInfo { name: "NVIDIA GeForce GTX 960M", vendor: 4318, device: 5019, device_type: DiscreteGpu, backend: Vulkan }

I believe this may be an issue specific to my system, though I have no idea how I'd begin debugging it.
EDIT: Here's a repo for the code that consistently reproduces the bug for me: link

Can you try running our bevymark example? That spawns lots of sprites, and so should hopefully reproduce the issue.

Huh, strangely the bevymark example seems to work with no issues on the v0.6.1 tag - no corrupted sprites. Does this mean I'm doing something potentially incorrectly?

Could you share example code that we could try to reproduce?

Here's a minimum reproducible example I came up with, the only additional dependency being alea for RNG:
use bevy::prelude::*;

fn main() {
    App::new()
        .add_plugins(DefaultPlugins)
        .add_startup_system_set(
            SystemSet::new()
                .with_system(setup_camera)
                .with_system(spawn_player),
        )
        .add_system(player_shoot)
        .run();
}

pub fn setup_camera(mut commands: Commands) {
    commands.spawn_bundle(OrthographicCameraBundle::new_2d());
}

pub fn spawn_player(mut commands: Commands, asset_server: Res<AssetServer>) {
    commands.spawn_bundle(SpriteBundle {
        texture: asset_server.load("sprites/player.png"),
        ..Default::default()
    });
}

pub fn player_shoot(
    mut commands: Commands,
    asset_server: Res<AssetServer>,
    mouse_input: Res<Input<MouseButton>>,
) {
    if mouse_input.just_pressed(MouseButton::Left) {
        commands.spawn_bundle(SpriteBundle {
            texture: asset_server.load("sprites/fireball.png"),
            transform: Transform {
                translation: Vec3::new(
                    alea::f32_in_range(-640.0, 640.0),
                    alea::f32_in_range(-480.0, 480.0),
                    0.0,
                ),
                ..Default::default()
            },
            ..Default::default()
        });
    }
}

This is part of the resulting window after only a few clicks:

It would probably be helpful to have the sprites you are using too, in case it's something about the image?

I was able to replicate, this happens around every fifth launch of the game

I was using these two sprites. The player is from this pack, and the fireball was custom and exported from GIMP.

Just tried reproing on main with some of our pre-packaged sprites and couldn't. Can anyone repro on main with this example?
use bevy::prelude::*;
use rand::Rng;

fn main() {
    App::new()
        .add_plugins(DefaultPlugins)
        .add_startup_system_set(
            SystemSet::new()
                .with_system(setup_camera)
                .with_system(spawn_player),
        )
        .add_system(player_shoot)
        .run();
}

pub fn setup_camera(mut commands: Commands) {
    commands.spawn_bundle(OrthographicCameraBundle::new_2d());
}

pub fn spawn_player(mut commands: Commands, asset_server: Res<AssetServer>) {
    commands.spawn_bundle(SpriteBundle {
        texture: asset_server.load("textures/simplespace/enemy_A.png"),
        ..Default::default()
    });
}

pub fn player_shoot(
    mut commands: Commands,
    asset_server: Res<AssetServer>,
    mouse_input: Res<Input<MouseButton>>,
) {
    if mouse_input.just_pressed(MouseButton::Left) {
        commands.spawn_bundle(SpriteBundle {
            texture: asset_server.load("textures/simplespace/enemy_B.png"),
            transform: Transform {
                translation: Vec3::new(
                    rand::thread_rng().gen_range(-640.0..640.0),
                    rand::thread_rng().gen_range(-480.0..480.0),
                    0.0,
                ),
                ..Default::default()
            },
            ..Default::default()
        });
    }
}

Can't repro on main with any of the sprites linked above (or by swapping alea back in for the random numbers).

Can't repro on 0.6.1 either. Nows probably a good time to start sharing relevant environment info:

Arch Linux: Nvidia GTX 1070 (Proprietary driver version 510.54), Vulkan Backend

Hm, I couldn't reproduce with the built-in sprites on 0.6.1, but it happens pretty consistently with my own sprites.
I've uploaded a minimal repo that generates the glitch semi-consistently for me here.
As for my environment info:

Pop!_OS: Nvidia GTX 960M (Proprietary driver version 510.54), Vulkan Backend

I couldn't reproduce with your repo, with 10 runs
AdapterInfo { name: "Apple M1 Max", vendor: 0, device: 0, device_type: DiscreteGpu, backend: Metal }

Yeah sadly I can't repro with your repo either on my machine. I'll try arch+nvidia 750m+proprietary next (on my apple laptop)

Ok so the good news is ... I got a repro:

The bad news is ... I got a repro which means this isn't just a problem on your machine :)
Likely somehow related to Linux + nvidia mobile gpus with proprietary drivers?

Oh thank goodness I'm not going crazy.
I'm assuming that's the case too, but in that case this is way above my paygrade right now, haha.

@kirusfg can you share your environment information so we have another datapoint? I'm guessing its linux + a mobile nvidia gpu?

I can also repro with MaterialMesh2dBundle, which means this isn't related to our sprite batching logic.

Pulling in @kvark and @cwfitzgerald as a heads up (we'll file a bug once we have a bit more information and wgpu traces ... unless y'all have easy answers).

Yes, I am on Arch Linux with an Nvidia GeForce 920MX using the proprieatry drivers.

No particular issue pops out to me, so a semi-minimalized repo would be great

At the very least, please file a bug to us and provide a zipped API trace (the smaller the better), please.

Getting the same issue here, running arch linux with proprietary nvidia drivers version 515.65.01
AdapterInfo { name: "NVIDIA GeForce GTX 750 Ti", vendor: 4318, device: 4992, device_type: DiscreteGpu, backend: Vulkan }

I can also reproduce the issue with the repo above. This is the system and adapter logs:
SystemInfo {
    os: "Linux  Arch Linux",
    kernel: "6.4.3-arch1-1",
    cpu: "Intel(R) Core(TM) i5-4430 CPU @ 3.00GHz",
    core_count: "4",
    memory: "15.6 GiB",
}

AdapterInfo {
    name: "NVIDIA GeForce GT 635",
    vendor: 4318,
    device: 4736,
    device_type: DiscreteGpu,
    driver: "NVIDIA",
    driver_info: "470.199.02",
    backend: Vulkan,
}

It would be really nice if this can be fixed. It's a really huge show-stopper.
@kvark

provide a zipped API trace

Can you tell me how to get the trace?

I've managed to make a minimal reproduction repo with the latest 0.11 version of Bevy: https://github.com/mydumpfire/sprite_debug
All it does is load a 16x16 flat blue square png. If the artifacting doesn't occur right away, try to restart the built binary a few times. Personally, the artifact happens around 80-90% of the time.
Zoomed-in screenshot of the artifact:

@kvark I've also made a zipped API trace: wgpu_trace.zip

This appears to match with my report #8355.
I also have an Optimus system.
I found that 64x64 is the minimum (at least on my machine) to prevent such artifacts.
Please test if this holds true for others.
The specific resolution seems to follow the COPY_BYTES_PER_ROW_ALIGNMENT of wgpu, if that is worth mentioning.
I did check that the texture data is not corrupted by transferring it to a bigger texture image, so it seems to be a visual thing.

https://github.com/mydumpfire/sprite_debug

I can reproduce this too.
@zentasumu
You mentioned that a <=2GB vram size might be the culprit, can people in this thread contribute some data on this? I am also personally using a 2GB GPU, so this strengthens the theory.
I also suspected that this is an nvidia driver issue, but:

I also tried modifying some simple sample vulkan c++ programs to create texture images smaller than 64x64, and I could not reproduce the issue.

So this sounds like a wgpu/bevy bug. Anyone have a clue of the cause of this bug?

Further down the line, I've had suspicion that this is solely with wgpu.
Using textures with sizes lower than 64x64 have a high chance that it will produce the artifact, but as said before, try the same test on texture related vulkan examples in c/c++ and it should not have an issue.
The randomness of producing the artifact across runs is due to the unordered generation of textures. Plus we also need to consider that Bevy itself generates some of its own, like fallback images.
Backing this, I forgot to say that I've done an additional test of generating checkerboard textures from 1x1 up to 128x128 with only wgpu, and I can confirm that it matches the weird reproduction behavior with multiple textures loaded, in which some are rendered correctly and some don't, excluding 64x64 and up which are always rendered correctly.
Again, this does not appear to be a texture data corruption, which is confirmed by doing an image to image copy, rather the texture sampler is returning wrong colors for some reason.
One thing though, I seem to notice that the artifact changes when using __NV_PRIME_RENDER_OFFLOAD=1 __VK_LAYER_NV_optimus=NVIDIA_only vs overriding VK_ICD_FILENAMES if that is worth mentioning.
I'm still unsure what wgpu does under the hood which results in the artifact, but following the COPY_BYTES_PER_ROW_ALIGNMENT,  which has a value of 256, seems to work which is where my theory of a minimum 64x64 texture size came from.

I've tested the reproduction again with 0.12 and the bug now happens a lot more rarely and less harshly. I re-ran the debug build many times and the worst I got was this:

Can anyone else confirm any experienced differences since 0.12?


Fix Listserv 16.5 scarping error

This PR implements a simply (based on the fact that the root problem couldn't be identified yet) solution for the bug mentioned in #472.
Merging it none the less is motivated by the fact that is fixes the scraping error, such that bigbang/listserv.py can now uninterruptedly scrape the archives (at time of writing since 3 days).
The issue is in the function ListservMessageParser._get_header_from_html() as soup.find("b", text=re.compile(r"^\bSubject\b")) sometimes returns None and more often not, while there is no clear explain to why it happens... yet.

Codecov Report

Merging #476 (ffea832) into main (62367fe) will decrease coverage by 0.04%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #476      +/-   ##
==========================================
- Coverage   75.13%   75.08%   -0.05%
==========================================
  Files          16       16
  Lines        2284     2288       +4
==========================================
+ Hits         1716     1718       +2
- Misses        568      570       +2

Flag
Coverage Δ

unittests
75.08% <83.33%> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

bigbang/listserv.py
81.95% <83.33%> (-0.25%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62367fe...ffea832. Read the comment docs.


[CT-3322] [Bug] Incorrect behaviour described in docstring for get_custom_database macro.

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
Incorrect behaviour described in docstring for get_custom_database macro: describes postfix when it is replacement of database target.
Expected Behavior
Docstring for get_custom_database macro describes replacement of database target.
Steps To Reproduce
N/A
Relevant log output
No response
Environment
No response
Which database adapter are you using with dbt?
No response
Additional Context
No response

Thanks for reaching out about this @LeoTheGriff !
Can you share more about what specifically you are seeing?
e.g., share a screenshot or a link to a website that highlights what looks incorrect to you.
Also, could you share what steps we can take to see it as well?

Apologies, I used a GitHub reporting mechanic that said it would attach the permalink but didn’t.
“If a database override is specified, then the resulting database is the default database concatenated with the custom database.”
The default macro replaces the default database with custom, it doesn't concat them.
https://github.com/dbt-labs/dbt-core/blob/main/core/dbt/include/global_project/macros/get_custom_name/get_custom_database.sql

From: Doug Beatty @.>
Sent: Monday, November 6, 2023 6:09:18 PM
To: dbt-labs/dbt-core @.>
Cc: Leo Griffiths @.>; Mention @.>
Subject: Re: [dbt-labs/dbt-core] [CT-3322] [Bug] Incorrect behaviour described in docstring for get_custom_database macro. (Issue #9003)
Thanks for reaching out about this @LeoTheGriffhttps://github.com/LeoTheGriff !
Can you share more about what specifically you are seeing?
e.g., share a screenshot or a link to a website that highlights what looks incorrect to you.
Also, could you share what steps we can take to see it as well?
—
Reply to this email directly, view it on GitHubhttps://github.com/dbt-labs/dbt-core/issues/9003#issuecomment-1795771958, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACGF7N7JCH3G2EY7PC6FJADYDERU5AVCNFSM6AAAAAA67NSLPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJVG43TCOJVHA.
You are receiving this because you were mentioned.Message ID: @.***>

It is a minor fix, I proposed a solution in the linked PR

No prob. Looks like there was copy-paste within https://github.com/dbt-labs/dbt-core/pull/2143 in which the comments didn't get fully updated for accuracy.
Thanks for opening that PR!


Bluetooth: PTS upper tester: GAP/CONN/NCON/BV-02-C Fails because of usage of NRPA

Describe the bug
The implementation of GAP/CONN/NCON/BV-02-C in PTS v7.6.2
needs non-connectable undirected advertising,
with the IUT using its identity address.
Currently, our upper tester will use bluetooth.h::BT_LE_ADV_NCONN, which means NRPA, for all test cases that require non-connectable undirected advertising.
The test will fail as the lower tester will use a whitelist with the IUT's identity address.
To Reproduce
Run GAP/CONN/NCON/BV-02-C and observe failure.
An air trace reveals that the IUT is using an NRPA.
Check the test's HCI trace (attached) and observe that the lower is using a whitelist with the IUT's id address.
Expected behavior
The upper tester should not instruct the IUT to use an NRPA unless explicitly stated in a test's spec.
wid_54: TSC_MMI_iut_send_advertising_report_event_0203_general_discoverable
should not have the same effect as
wid_79: TSC_MMI_iut_send_advertising_report_event_non_resolvable_address
Impact
The conformance test fails when run with auto-pts.
Logs and console output
GAP_CONN_NCON_BV_02_C_2020_09_25_16_53_51.zip
Environment (please complete the following information):

PTS v7.6.2
zephyr v2.4.0-rc3
auto-pts @ 5c1f50f

Need to use BT_LE_ADV_OPT_USE_IDENTITY for non-connectable advertiser to use the identity address.
@kromancer Are you reporting a bug on the tester now?

@joerchan Yes, I am reporting a, low priority IMHO, bug on the tester.
The offending line, which makes the wrong assumption that all non connectable advertising should use an NRPA, is here:
https://github.com/zephyrproject-rtos/zephyr/blob/zephyr-v2.4.0/tests/bluetooth/tester/src/gap.c#L299

@kromancer will you send a PR?

GAP/CONN/NCON/BV-02-C passed after enabling CONFIG_BT_PRIVACY. This issue can be closed.
As this test is not using extended advertising, it won't change set a new advertising random address.
https://github.com/zephyrproject-rtos/zephyr/blob/zephyr-v2.4.0/subsys/bluetooth/host/hci_core.c#L778

Thanks @ryanjh


Added some OpenAI helper APIs

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.CloudMachine


build(renovate): read-only token for public docker repos

v14.2.1 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems.


so much error called [Unable to add a banner to the leaflet!]

Am also getting this, weirdly enough, whenever I apply a template that creates the following query:
-file:"Changelog"
"[[<%tp.file.title%>"

Never happens anytime else. Obviously I'm not adding a banner, so I don't know why the plugin throws the error.

I get the same error, just add a callout in note like this "> [!tips]- xxx"

I am also getting this when I have the "Display header by default" option toggled on. Happens when opening files containing tables and callouts.

I'm experiencing the same issue. Appears to happen because of callouts, and if, for instance, a note has multiple callouts, with some too far down to be off-screen, scrolling down to reveal them causes more of the same error messages to be displayed.
(Using 2.0.5 beta)

Getting this as well


Add a GitHub action to deploy to a production environment with GitHub environments.

blue green deployment using an .deployment.yml file:
https://github.com/marketplace/actions/read-yaml

https://levelup.gitconnected.com/kubernetes-merge-multiple-yaml-into-one-e8844479a73a


Avoid string reallocations in glCheckError

Didn't expect std::filesystem::path to have that much overhead behind the scenes (string conversion/reallocation). This replaces the filename() logic with a simplified approach that should be fully sufficient for any and all file paths within the SFML project following common naming conventions.

But the string was only constructed in an error case unless you are erroring out so much this shouldn't matter much or does it?

Yes, should only happen in case there are issues (or the driver isn't ready for whatever reason, which might actually pile up on window creation on Android as far as I remember).

I'm not sure I can behind a performance optimization for code that only runs when an error occurs in debug builds. We're pretty far away from hot path code at this point.

Unless you have a specific use case where this causes issues, I also don't see it as a problem to do more work on a fail path in debug mode.
The hot path issues were already solved with #3359 and #3358 and #3362


what's the different between command react-native and create-react-native-app

I have seen these two commands on the tutorial. However, what's the different? why two different commands to create project?
https://facebook.github.io/react-native/docs/getting-started.html#content

The Caveats section explains the main differences. Basically, with CRNA you won't need to install or use Android Studio or Xcode. You simply write JavaScript code, and run it within the Expo app on a device.
Check out the FAQ for CRNA at https://github.com/react-community/create-react-native-app#faqs, copied here for convenience:
What API specification should I be looking at while developing?
Apps made with Create React Native App support everything in the Components and APIs sections of the React Native Documentation.
Apps made with Create React Native App also support most of the JavaScript-to-Native APIs provided by the Expo SDK, since they are loaded by the Expo app.
What are the limitations of Create React Native App?
The main limitation of a Create React Native App project is that it must be written in pure JavaScript and not have any dependencies which rely on custom native code (i.e. ones which require running react-native link to work). This allows the projects to load directly on a phone without native compilation, and also means that it's not necessary to install or use Android Studio or Xcode.
What if I want to write custom native code for my app?
If you're sure that you need custom native code, please read the ejecting guide.
How do I get my app into the Play Store/App Store?
If you need to build IPAs and APKs for publishing to the App Store and/or Play Store, you can either eject (see above guide) and build them yourself using Xcode and Android Studio, or you can use a service like Expo's standalone app builds to publish your pure JS app.


fix: prevent panic when ChartDownloader.getOciURI

needs to lookup tags because no version is provided but no RegistryClient is provided
Add tests for oci registries

What this PR does / why we need it:
Special notes for your reviewer:
If applicable:

[ ] this PR contains documentation
[x] this PR contains unit tests
[x] this PR has been tested for backwards compatibility

includes #13436


Tests fail frequently in bluebird v3.6.0 and v3.7.0

What version of bluebird is the issue happening on?

v3.6.0 and v3.7.0

What platform and version? (For example Node.js 0.12 or Google Chrome 32)

Node.js 12.11.1 on macOS

Did this issue happen with earlier version of bluebird?

No.
(Write description of your issue here, stack traces from errors and code that reproduces the issue are helpful)
I bisected the issue to 60ef7a0e23fd320a11281f67c64a39ff95612ce9. That commit makes the tests unreliable for me locally on macOS using Node.js 12.11.1. It doesn't fail every time but it fails most of the time if I use npm test and less often if I use node tools/test --run=unhandled_rejections.js:
55 passing (222ms)
  1 failing

  1) issues GH-1487-8:
     Error: Reporting handled rejection as unhandled from: function testFunction() {
        var ret = onUnhandledFail(testFunction);
        var arr = [ Promise.reject( new Error('foo') ) ];
        var p = Promise.resolve( arr );
        p.filter( function() {} ).caught( function() {} );
        return ret;
    }
      at /Users/trott/temp/bluebird/test/mocha/helpers/util.js:142:23
  From previous event:
      at onUnhandledFail (/Users/trott/temp/bluebird/test/mocha/helpers/util.js:141:16)
      at context.testFunction (/Users/trott/temp/bluebird/test/mocha/unhandled_rejections.js:869:19)
      at callFn (/Users/trott/temp/bluebird/node_modules/mocha/lib/runnable.js:251:21)
      at Test.Runnable.run (/Users/trott/temp/bluebird/node_modules/mocha/lib/runnable.js:244:7)
      at Runner.runTest (/Users/trott/temp/bluebird/node_modules/mocha/lib/runner.js:374:10)
      at /Users/trott/temp/bluebird/node_modules/mocha/lib/runner.js:452:12
      at next (/Users/trott/temp/bluebird/node_modules/mocha/lib/runner.js:299:14)
      at /Users/trott/temp/bluebird/node_modules/mocha/lib/runner.js:309:7
      at next (/Users/trott/temp/bluebird/node_modules/mocha/lib/runner.js:248:23)
      at /Users/trott/temp/bluebird/node_modules/mocha/lib/runner.js:271:7
      at done (/Users/trott/temp/bluebird/node_modules/mocha/lib/runnable.js:207:5)
      at callFn (/Users/trott/temp/bluebird/node_modules/mocha/lib/runnable.js:262:7)
      at Hook.Runnable.run (/Users/trott/temp/bluebird/node_modules/mocha/lib/runnable.js:244:7)
      at next (/Users/trott/temp/bluebird/node_modules/mocha/lib/runner.js:259:10)
      at Immediate.<anonymous> (/Users/trott/temp/bluebird/node_modules/mocha/lib/runner.js:276:5)
      at processImmediate (internal/timers.js:439:21)

Error: Reporting handled rejection as unhandled from: function testFunction() {
        var ret = onUnhandledFail(testFunction);
        var arr = [ Promise.reject( new Error('foo') ) ];
        var p = Promise.resolve( arr );
        p.filter( function() {} ).caught( function() {} );
        return ret;
    }
    at /Users/trott/temp/bluebird/test/mocha/helpers/util.js:142:23
    at onUnhandledFail (/Users/trott/temp/bluebird/test/mocha/helpers/util.js:141:16)
    at context.testFunction (/Users/trott/temp/bluebird/test/mocha/unhandled_rejections.js:869:19)
    at callFn (/Users/trott/temp/bluebird/node_modules/mocha/lib/runnable.js:251:21)
    at Test.Runnable.run (/Users/trott/temp/bluebird/node_modules/mocha/lib/runnable.js:244:7)
    at Runner.runTest (/Users/trott/temp/bluebird/node_modules/mocha/lib/runner.js:374:10)
    at /Users/trott/temp/bluebird/node_modules/mocha/lib/runner.js:452:12
    at next (/Users/trott/temp/bluebird/node_modules/mocha/lib/runner.js:299:14)
    at /Users/trott/temp/bluebird/node_modules/mocha/lib/runner.js:309:7
    at next (/Users/trott/temp/bluebird/node_modules/mocha/lib/runner.js:248:23)
    at /Users/trott/temp/bluebird/node_modules/mocha/lib/runner.js:271:7
    at done (/Users/trott/temp/bluebird/node_modules/mocha/lib/runnable.js:207:5)
    at callFn (/Users/trott/temp/bluebird/node_modules/mocha/lib/runnable.js:262:7)
    at Hook.Runnable.run (/Users/trott/temp/bluebird/node_modules/mocha/lib/runnable.js:244:7)
    at next (/Users/trott/temp/bluebird/node_modules/mocha/lib/runner.js:259:10)
    at Immediate.<anonymous> (/Users/trott/temp/bluebird/node_modules/mocha/lib/runner.js:276:5)
From previous event:
    at Object.run (/Users/trott/temp/bluebird/tools/job-runner/job-runner.js:141:27)
    at runTestGroup (/Users/trott/temp/bluebird/tools/test.js:123:22)
    at /Users/trott/temp/bluebird/tools/test.js:261:16
    at processImmediate (internal/timers.js:439:21)
From previous event:
    at Object.<anonymous> (/Users/trott/temp/bluebird/tools/test.js:254:27)
    at Module._compile (internal/modules/cjs/loader.js:945:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:962:10)
    at Module.load (internal/modules/cjs/loader.js:798:32)
    at Function.Module._load (internal/modules/cjs/loader.js:711:12)
    at Function.Module.runMain (internal/modules/cjs/loader.js:1014:10)
    at internal/main/run_main_module.js:17:11

Fixed in 3.7.1


We see lot's packet drops on our cisco ip sla probes

Hi,
We have app. 5000 probes pointing to the responder. We are seeing lots of packet loss.
It's a centos 5.6
ifconfig on eth0 is <IP_ADDRESS>.
the responder config is very simple:
vlansupport=0
iface=eth0
debuglevel=0
ciscoport=64000
We don't see any drops on eth0 , and cpu and memory load is very little
Can you please help
Regards
Carsten

Where are you seeing the packet loss? Can you describe your setup?

Hi,
Well, of course we se the drops on the router ip sla statistics.
We have done a lot of tracing.
When we ping the eth0 ip address on the responder from from the default router everything works fine, but when we ping the responder address , we get packet loss.
So we expect the packets ar lost between the eth0 ip and the responder ip
Med venlig hilsen / Regards
Carsten Ishøj Nielsen
System Engineer
TDC Operations, OTVA , Bredbånd
Teglholmsgade 1-3 , Bygning B1
2450 København SV
Danmark
T: +45 66 67 44 66
M: +45 20 10 13 34
E: cin<EMAIL_ADDRESS><EMAIL_ADDRESS>Fra: Aki Tuomi<EMAIL_ADDRESS>Sendt: 28. november 2016 13:58
Til: cmouse/ip-sla-responder<EMAIL_ADDRESS>Cc: Carsten Ishøj Nielsen<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Emne: Re: [cmouse/ip-sla-responder] We see lot's packet drops on our cisco ip sla probes (#10)
Where are you seeing the packet loss? Can you describe your setup?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/cmouse/ip-sla-responder/issues/10#issuecomment-263264849, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALWMKe373CY4mxx4p3OBPN_hp8B6Jw5bks5rCs_UgaJpZM4K9uqz.

Can you verify that the responder address is not mapped to any interface on the responder machine and that you are routing the packages to the responder machine's interface IP. This might sound bit illogical, but the responder software is supposed to care of it's own IP package handling.

That is correct. Ifconfig only shows ip on eth0
Med venlig hilsen / Regards
Carsten Ishøj Nielsen
System Engineer
TDC Operations, OTVA , Bredbånd
Teglholmsgade 1-3 , Bygning B1
2450 København SV
Danmark
T: +45 66 67 44 66
M: +45 20 10 13 34
E: cin<EMAIL_ADDRESS><EMAIL_ADDRESS>Fra: Aki Tuomi<EMAIL_ADDRESS>Sendt: 28. november 2016 14:38
Til: cmouse/ip-sla-responder<EMAIL_ADDRESS>Cc: Carsten Ishøj Nielsen<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Emne: Re: [cmouse/ip-sla-responder] We see lot's packet drops on our cisco ip sla probes (#10)
Can you verify that the responder address is not mapped to any interface on the responder machine and that you are routing the packages to the responder machine's interface IP. This might sound bit illogical, but the responder software is supposed to care of it's own IP package handling.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/cmouse/ip-sla-responder/issues/10#issuecomment-263272991, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALWMKWZISsXxC9m5f_8L9s9kFlZKrwnLks5rCtk0gaJpZM4K9uqz.

the IP address must not be configured on any interface on the responder host. the responder software will handle it's own IP stack. you must route the responder service IP towards the responder host IP.

Hi,
Here is the ip setup :
<EMAIL_ADDRESS>Med venlig hilsen / Regards
Carsten Ishøj Nielsen
System Engineer
TDC Operations, OTVA , Bredbånd
Teglholmsgade 1-3 , Bygning B1
2450 København SV
Danmark
T: +45 66 67 44 66
M: +45 20 10 13 34
E: cin<EMAIL_ADDRESS><EMAIL_ADDRESS>Fra: Aki Tuomi<EMAIL_ADDRESS>Sendt: 28. november 2016 14:44
Til: cmouse/ip-sla-responder<EMAIL_ADDRESS>Cc: Carsten Ishøj Nielsen<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Emne: Re: [cmouse/ip-sla-responder] We see lot's packet drops on our cisco ip sla probes (#10)
the IP address must not be configured on any interface on the responder host. the responder software will handle it's own IP stack. you must route the responder service IP towards the responder host IP.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/cmouse/ip-sla-responder/issues/10#issuecomment-263274346, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALWMKesS577kdaCOma1hfDbsWZStS-p2ks5rCtq6gaJpZM4K9uqz.

Github seems to ignore attachments over email.

Also, have you checked that your CoPP filter does not ratelimit packets?

thank you. can you confirm with packet sniffing on egress point that the server is indeed receiving more packets than it's not responding to? it also seems you are using virtual environment for running the software, and it might be the cause of your trouble. Last time I tested this with virtual machine it had trouble working correctly due to limitations in virtual platform.

Hi,
Yes, a sniffer trace taken over several hours , shows a packet loss of one percent.
We have prepared a physical server , installed with responder. I will ask our server people if the can try replacing with the virtual server.
Med venlig hilsen / Regards
Carsten Ishøj Nielsen
System Engineer
TDC Operations, OTVA , Bredbånd
Teglholmsgade 1-3 , Bygning B1
2450 København SV
Danmark
T: +45 66 67 44 66
M: +45 20 10 13 34
E: cin<EMAIL_ADDRESS><EMAIL_ADDRESS>Fra: Aki Tuomi<EMAIL_ADDRESS>Sendt: 28. november 2016 15:14
Til: cmouse/ip-sla-responder<EMAIL_ADDRESS>Cc: Carsten Ishøj Nielsen<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Emne: Re: [cmouse/ip-sla-responder] We see lot's packet drops on our cisco ip sla probes (#10)
thank you. can you confirm with packet sniffing on egress point that the server is indeed receiving more packets than it's not responding to? it also seems you are using virtual environment for running the software, and it might be the cause of your trouble. Last time I tested this with virtual machine it had trouble working correctly due to limitations in virtual platform.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/cmouse/ip-sla-responder/issues/10#issuecomment-263280952, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALWMKR8mkV0UeAa9JiqaLJBzch6vQttyks5rCuGdgaJpZM4K9uqz.

Hi,
We replaced the virtual with physical server.
It worked. So virtual is no good.
Thanks for your help
Med venlig hilsen / Regards
Carsten Ishøj Nielsen
System Engineer
IP tjenester, OBNT
Teglholmsgade 1-3 , Bygning B1
2450 København SV
Danmark
T: +45 66 67 44 66
M: +45 20 10 13 34
E: cin<EMAIL_ADDRESS><EMAIL_ADDRESS>Fra: Aki Tuomi<EMAIL_ADDRESS>Sendt: 28. november 2016 15:14
Til: cmouse/ip-sla-responder<EMAIL_ADDRESS>Cc: Carsten Ishøj Nielsen<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Emne: Re: [cmouse/ip-sla-responder] We see lot's packet drops on our cisco ip sla probes (#10)
thank you. can you confirm with packet sniffing on egress point that the server is indeed receiving more packets than it's not responding to? it also seems you are using virtual environment for running the software, and it might be the cause of your trouble. Last time I tested this with virtual machine it had trouble working correctly due to limitations in virtual platform.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/cmouse/ip-sla-responder/issues/10#issuecomment-263280952, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALWMKR8mkV0UeAa9JiqaLJBzch6vQttyks5rCuGdgaJpZM4K9uqz.

Hi,
I wrote to Aki Toumi about running on vm. As I remember he recalled that there were issues running on VM. Our VM people tuned everything they could on the VM server , but we still saw pckt loss.
Then we decided to install phys server instead, and then everything worked. We have app 5000 cisco sla probes and server has no issues.
The server has very low cpu and mem load.
Med venlig hilsen / Regards
Carsten Ishøj Nielsen
cin<EMAIL_ADDRESS>Fra: Allan Pinto<EMAIL_ADDRESS>Sendt: 2. november 2018 02:22
Til: cmouse/ip-sla-responder<EMAIL_ADDRESS>Cc: Carsten Ishøj Nielsen<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Emne: [EXT] Re: [cmouse/ip-sla-responder] We see lot's packet drops on our cisco ip sla probes (#10)
UK/DK: Be aware, this is an external email and may not be genuine / Vær opmærksom på, at dette er en ekstern e-mail og muligvis ikke ægte.
sorry to jump on this after two years, but could i know what was the VM configuration and the physical server configuration you used?. i'm planning to test this, but most probably will not have option of physical server. I don't think there will be more than 2000 probes per vm.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcmouse%2Fip-sla-responder%2Fissues%2F10%23issuecomment-435240689&data=02|01|cin%40tdc.dk|cf0bd07b3a90448e38c308d640618c2d|e8dcf6e63acc4af99cb277f688cb688b|0|0|636767185056585678&sdata=%2F8gAgZqr0px1Ou4Bcunh1ZMjz1NyqbdXemBOlHTaB6c%3D&reserved=0, or mute the threadhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALWMKXl0NuCo32nWzYc4RpYdJScip2Vmks5uq54jgaJpZM4K9uqz&data=02|01|cin%40tdc.dk|cf0bd07b3a90448e38c308d640618c2d|e8dcf6e63acc4af99cb277f688cb688b|0|0|636767185056585678&sdata=TnzOWjJQZtSJdoNXxfl%2Fhw5Lt21soIMlMaHvPVZtS8M%3D&reserved=0.

Hi,
System Information
Manufacturer: HP
Product Name: ProLiant DL320e Gen8
CentOS release 6.7 (Final)
Med venlig hilsen / Regards
Carsten Ishøj Nielsen
cin<EMAIL_ADDRESS>Fra: Allan Pinto<EMAIL_ADDRESS>Sendt: 2. november 2018 10:28
Til: cmouse/ip-sla-responder<EMAIL_ADDRESS>Cc: Carsten Ishøj Nielsen<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Emne: [EXT] Re: [cmouse/ip-sla-responder] We see lot's packet drops on our cisco ip sla probes (#10)
UK/DK: Be aware, this is an external email and may not be genuine / Vær opmærksom på, at dette er en ekstern e-mail og muligvis ikke ægte.
Thanks a lot. Could I know the specs of the server so I can plan similarly.
On Fri, 2 Nov 2018, 19:36 cishoejnielsen<EMAIL_ADDRESS>wrote:
<EMAIL_ADDRESS>wrote:> Hi,

I wrote to Aki Toumi about running on vm. As I remember he recalled that
there were issues running on VM. Our VM people tuned everything they could
on the VM server , but we still saw pckt loss.
Then we decided to install phys server instead, and then everything
worked. We have app 5000 cisco sla probes and server has no issues.
The server has very low cpu and mem load.
Med venlig hilsen / Regards
Carsten Ishøj Nielsen
cin@tdc.dk<mailto:cin@tdc.dkmailto:cin<EMAIL_ADDRESS>Fra: Allan Pinto <notifications<EMAIL_ADDRESS>Sendt: 2. november 2018 02:22
Til: cmouse/ip-sla-responder <ip-sla-responder<EMAIL_ADDRESS>Cc: Carsten Ishøj Nielsen <cin<EMAIL_ADDRESS>Author <author<EMAIL_ADDRESS>Emne: [EXT] Re: [cmouse/ip-sla-responder] We see lot's packet drops on our
cisco ip sla probes (#10)
UK/DK: Be aware, this is an external email and may not be genuine / Vær
opmærksom på, at dette er en ekstern e-mail og muligvis ikke ægte.
sorry to jump on this after two years, but could i know what was the VM
configuration and the physical server configuration you used?. i'm planning
to test this, but most probably will not have option of physical server. I
don't think there will be more than 2000 probes per vm.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<
https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcmouse%2Fip-sla-responder%2Fissues%2F10%23issuecomment-435240689&data=02|01|cin%40tdc.dk|cf0bd07b3a90448e38c308d640618c2d|e8dcf6e63acc4af99cb277f688cb688b|0|0|636767185056585678&sdata=%2F8gAgZqr0px1Ou4Bcunh1ZMjz1NyqbdXemBOlHTaB6c%3D&reserved=0>,
or mute the thread<
https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALWMKXl0NuCo32nWzYc4RpYdJScip2Vmks5uq54jgaJpZM4K9uqz&data=02|01|cin%40tdc.dk|cf0bd07b3a90448e38c308d640618c2d|e8dcf6e63acc4af99cb277f688cb688b|0|0|636767185056585678&sdata=TnzOWjJQZtSJdoNXxfl%2Fhw5Lt21soIMlMaHvPVZtS8M%3D&reserved=0>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/cmouse/ip-sla-responder/issues/10#issuecomment-435308071,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA7PbtTa2e8_MZWpLOdM_VSkvt2uKCX1ks5urAQPgaJpZM4K9uqz
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcmouse%2Fip-sla-responder%2Fissues%2F10%23issuecomment-435320505&data=02|01|cin%40tdc.dk|94edab7c0a62430ab95808d640a57f2f|e8dcf6e63acc4af99cb277f688cb688b|0|0|636767476883138627&sdata=4XZsdyMqFVUfHmYTTnXpfJrQMi9HhuaH7AoGoLK2GrE%3D&reserved=0, or mute the threadhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALWMKcBTnS8hTFRh6BN_TliNZoZpVqRXks5urBAUgaJpZM4K9uqz&data=02|01|cin%40tdc.dk|94edab7c0a62430ab95808d640a57f2f|e8dcf6e63acc4af99cb277f688cb688b|0|0|636767476883138627&sdata=gOGfHLqHqtjjoC0eDv5yt90Etp7fgc%2FkhnsA4656PxA%3D&reserved=0.


Inserting mentions programatically

Is it possible to insert a mention into the text programmatically at cursor position?
Let's assume I have a text:
foo bar | baz where | is a cursor position.
I need a way to insert some mention at cursor position and apply jquery.overlay
foo bar @example baz

Sorry for my late reply.
It seems there is no need to use the jquery-textcomplete plugin to achieve your aim. Please use pure DOM APIs instead.


Support Remove pointers for Android

**Is your feature request related to a problem?
For android OS based devices that have a touchpad and/or external mouse (chromebooks, et al), the remote pointer of the host is not supported.
Describe the solution you'd like
There's setPointerIcon support available on API 24 and above. We use that to set the pointer the same way as other clients.
Additional context
I am working on this right now, happy to take in any feedback/pointers.

@lakshmanpasala nice to hear.
if you have any questions don´t hesitate to ask (we' re reachable via matrix, see https://freerdp.com for a link


Lazyload filter not working

Hello,
How can I verify if lazyload filter is working?
I have a page with tons of small images in display: none, and we must scroll the page + scroll inside the divs with overflow.
But when I check the page info, the media shows all the images are already loaded and when I scroll they seem already loaded (no micro loading).
So is it working? I guess not

Hi
The filter for lazyload fires an event on load that load all images. The reason for this is that in mobile devices is a cost to stablish a new connection but the payload is downloading bytes that maaybe never seen.
Try to use ModPagespeedLazyloadImagesAfterOnload off to disable this feature

I have set this to off too and same result. I have left default settings for everything else.
 It means it's not lazyloading at all if it loads all images o_0
In fact, the problem might also come from the fact that the page completely freezes after 2 seconds because it doesn't load my Jquery script (1.12). The browser says "the script is not responding, continue or abort" and if I continue it still pops again after few seconds

Hi
I know your feel about this, but is stated in the doc "The lazyload_images filter defers loading of images until they become visible in the client's viewport or the page's onload event fires.".
I don´t knoe too much abput this fillter cause i don´t use it. Instead i use lazysizes script to do this.

or the page's onload event fires

Don't understand
https://yousite.com/?PagespeedFilters=+debug so I can change the conf of any site on the web? o_0
Thank you for the lazysizes script, I spent hours trying to find one, I'll try this one. I just thought that the apache mod would work much better and doesn't require me to specify each image one by one.
And no about critical image beaconing, what is that?

Hi
The onload is an event in the browser side, like on scroll or on click, and is fired when all elements (html,css,js,,,) on a page are loaded.
With these url parameters you can change the config of the pagespeed module for these request, you can enable or disabe filters, even disable pagespeed module (?PageSpeed=off) so you don´t need to change the conf file to see how a filter work in a request.
A beacon is a javascript snipet that is injected in the page by pagespeed, this snipet return to the server info about the image (Is the image in the viewport? What size have the image rendered?...) . For example if you use ModPagespeedEnableFilters resize_rendered_image_dimensions the module must know what dimensions the image has when rendered to shrinks the image to these dimensions.
This can be enabled with:
ModPagespeedCriticalImagesBeaconEnabled true

With these url parameters you can change the config of the pagespeed module for these request, you can enable or disabe filters, even disable pagespeed module (?PageSpeed=off) so you don´t need to change the conf file to see how a filter work in a request.

So anybody can change my settings o_0
I can't test anything for now because of this issue https://github.com/apache/incubator-pagespeed-mod/issues/1894 @Lofesa

ok that kinda works I guess, but apparently images in divs with display:none are not loaded by default (no need for mod_pagespeed)
and if you open up the page info/media it loads all images from the page (even display:none)
For the beacon thing, I guess it's by default in the by image filter right ?

I'll reopen if I see this bug again


iPad crash in ApptentiveInteractionTextModalController

It looks like ApptentiveInteractionTextModalController can create a UIAlertViewController with an alertType of UIAlertControllerStyleActionSheet, but it is not setting the sourceView and sourceRect on the corresponding UIPopoverPresentationController on iPad devices.  That will result in a crash, since action sheets are popovers there.
We got this in version 3.5.1, but looking at the code, while changed I think it still has this issue.

NSGenericException: Your application has presented a UIAlertController (<UIAlertController: 0x15fdabd30>) of style UIAlertControllerStyleActionSheet. The modalPresentationStyle of a UIAlertController with this style is UIModalPresentationPopover. You must provide location information for this popover through the alert controller's popoverPresentationController. You must provide either a sourceView and sourceRect or a barButtonItem. If this information is not known when you present the alert controller, you may provide it in the UIPopoverPresentationControllerDelegate method -prepareForPopoverPresentation.

  | 0 | CoreFoundation 0x000000018acc2fe0 __exceptionPreprocess + 120
  | 1 | libobjc.A.dylib 0x0000000189724538 objc_exception_throw + 52
  | 2 | UIKit 0x0000000191832be8 -[UIPopoverPresentationController presentationTransitionWillBegin] + 2780
  | 3 | UIKit 0x00000001911400d4 __71-[UIPresentationController _initViewHierarchyForPresentationSuperview:]_block_invoke + 1968
  | 4 | UIKit 0x000000019113de04 __56-[UIPresentationController runTransitionForCurrentState]_block_invoke + 448
... [UIKit frames -- looks like a asynchronous block raises the exception]

I can't positively attribute that to Apptentive, but we don't have an alert controller on the page it's crashing on, and we do have an Apptentive trigger.  And, this was the only place in our code or Apptentive's where I could see UIAlertControllerStyleActionSheet being used without setting a sourceView.

I'll definitely take a look at this. The SDK should never reach that code path because as far as I'm aware the layout property of the configuration dictionary is never set to bottom.
Are you using an integration method where you could temporarily edit the Apptentive SDK source code to disable that code path (e.g. change UIAlertControllerStyleActionSheet to UIAlertControllerStyleAlert) and try and reproduce the issue?
Since it isn't practical for us to supply a source rect, I will make a note to disable that code path entirely on iPad devices in our next release.

It is hard to debug the Apptentive path.  However, we disabled the alert completely in the Apptentive config -- though it may have been re-enabled with an iPhone check -- and the crashes have slowed but not stopped, meaning we do have another issue in our code somewhere.  May be a situation where our code has been fortuitously changed since the branch which is in production.  I am suspicious there may be a path where a view was being passed down as nil in our code,  which is as good as not setting it.  It's not possible in our current codebase, but maybe it was earlier.
Anyways, any use of ActionSheet should be protected by setting a sourceView.  You could always use the presenting view controller's view, with the bottom-center edge and a size of {1,1}.  But, if you suspect that this code path is impossible in Apptentive, you may well be correct, in which case this is a minor code issue but not a real bug.  Sorry for the false alarm in that case ;-)

The code that was theoretically capable of displaying a text modal (Note) in action sheet mode has been removed in 4.1.0.


adding input fields for custom screen size and validations

Pull Request Template
Description
This PR adds a feature for passing custom screen sizes.
Related Issue
https://github.com/suryanshsingh2001/mockly/issues/4
Closes # (issue)
https://github.com/suryanshsingh2001/mockly/issues/4
Changes Made
1.) Implemented separate state variables to manage the dimensions of "customScreenSize" and "presetScreenSize". This allows for better tracking and control over the values for each screen size type.
2.) Updated the "screenSize" state based on the currently active tab, either "custom" or "preset". This ensures that the displayed screen size reflects the user's selection accurately.
3.) Added "handleCustomSizeChange" function to validate input for "customScreenSize". The validation allows only positive numerical values, ensuring data integrity and preventing invalid entries.
Type of Change
Select the type of change made with this pull request:

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Screenshots (if applicable)
https://github.com/user-attachments/assets/3c418488-1d7d-46c2-91ae-a8e62771812d
How Has This Been Tested?

Manually tested on local environment

Checklist
Check off the following items before submitting the pull request:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Hi @rahulchaudhary2244 ,
I noticed that changing the screen size to a very large value, such as 140000, breaks the image rendering and the state becomes irreversible. To address this, we should set maximum and minimum limits for both height and width in the custom screen size input to prevent such issues.
Task List:

[ ] Define appropriate maximum (e.g., 2000px) and minimum (e.g., 100px) limits for height and width in the custom screen size input.
[ ] Implement validation to ensure input values stay within the defined range.
[ ] Display an error message when values outside the allowed range are entered.

Let me know your thoughts on this, and I can proceed with implementing the changes.
https://github.com/user-attachments/assets/c0dbd65f-7ed9-43c5-888f-3721b9ce79ff

@rahulchaudhary2244
Just a quick reminder to pull the latest changes from the master repository to ensure you’re all up to date and avoid any potential merge conflicts as you work on new updates.

Hi @suryanshsingh2001 ,Thank you for reviewing the changes! I have implemented the following updates:
Added submit functionality for both the Enter key and the onBlur event.

Increased the maximum resolution to 2K.

When a user clicks on a different input field, the onBlur event is triggered. This will either display an error state or update the screenSize if the input is valid.

Hey, everything good and working. Only issue left.

[ ]  Take the latest pull from master branch. Your branch in one commit behind right now.
Please resolve this.

Hi @suryanshsingh2001 , just rebased the branch., should be fine now

@rahulchaudhary2244
Hi,
I wanted to take a moment to personally thank you for your valuable contributions. Your insights and solutions have truly shaped the way Mockly has progressed, and I’m incredibly grateful for your work.
If there are any other issues you’d like to explore or areas for further improvement, feel free to dive in. I’d love the opportunity to collaborate with you again in the future.

One more small request @rahulchaudhary2244
Please make sure to star this to increase the overall reach of this repository to more open source traffic.


Array Out of Bound Error in Post-Dominance Analysis Implementation

https://github.com/CompArchCam/Janus/blob/dff62bf4f9d9be173d67a487df44db1d40a2a828/static/analysis/ControlFlow.cpp#L540-L547
Here, entry is a raw pointer to the first basic block in the vector, and the index d here may exceed the boundary of the array. This is not being checked, as a result it points the immediate post-dominator of blocks that does not actually have a post-dominator (deduced from out of bound d values) to a random block that may or may not exist.
Expected behaviour: check for array bound and set ipdom for blocks that does not have a post-dominator to nullptr.

I have made a simple patch at PR https://github.com/CompArchCam/Janus/pull/4. Thanks!


{db-up} Fix #3143: db-up does not return correct PostgreSQL host for Azure Government

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

db-up


"A non-IMessage field was encountered" error

A Google Ads API Forum Advisor has responded to my post advising that they believe it “seems that the .NET client library is possibly the reason behind the Inner Exception 1: ArgumentException: error.  I recommend you to consult the implementation with .NET client library owner as they are appropriate to provide insights on data retrieved and getting above mentioned errors.”
I am running the code from a Windows (10) machine running .NET 6.0 (we are in Test mode).
The nature of the problem we are experiencing is that - in using the latest .NET sample code for getting GoogleAds Change Details (V14) - it works as expected (i.e., without an error since it's the exact sample code) for only 65 of 114 active client customers.
May you please assist regarding what can be done since - for the other 49 client customers - the sample code errors upon attempting to retrieve change details because it encounters the following type of “non-IMessage field” error?
“Inner Exception 1: ArgumentException: Cannot retrieve field value. A non-IMessage field was encountered after navigating keyword.match_type upto keyword.”
During some analysis, I found eight variations of change fields this non-IMessage field happened regarding.
One variation had fifteen (15) of the errors. They were similar “non-IMessage field” errors, except were "Cannot retrieve field value. A non-IMessage field was encountered after navigating manual_cpc.enhanced_cpc_enabled upto manual_cpc". These came via the following nine (9) Request IDs:

-VGrm3_Ib4Udoo1NUQU0dQ
0ZCK8I-CN5Fi_vzohsxQ
109YbJlU6SC6EuBt0nNRzA
DXSSxjFCZ-7tPrWacbizfQ
EmbI0CXTS9PyY2xpcoUhNA
hvVQAa27BRQ7NwcOs9jcJQ
Lg0f_NpQN76OIBUuIk4PeA
Pjt8vO_XxI4o0Iya7_hbUg
XDUPNC4GwZyqEegZMuhQCg

… All fifteen were changes the API response confirmed were initiated using the GoogleAdsWebClient.
I have attached a text file showing the correct below-mentioned snytax because I cannot seem to get it to render with the backslash for the non-errant below, etc. in this Issue-submission GUI.
When I looked at examples of that kind(/field) of errant response result (i.e., one GoogleAds Row in the response), 8 of the 15 had syntax in the result as follows:
•	…ChangedFields":{"Paths":["manual_cpc.enhanced_cpc_enabled","maximize_conversions.target_cpa_micros"]},"Campaign" …
The other 7 of these 15 had errant results with syntax as follows:
•	...ChangedFields":{"Paths":["manual_cpc.enhanced_cpc_enabled"]},"Campaign":...
When I look to an acceptable (non-errant) change event that also had this “manual_cpc.enhanced_cpc_enabled”, I found its result had syntax as shown in the attached text file (i.e., like the 7 of 15, but with several backslashes).
Questions:

Is the non-errant syntax (with the backslash) the only syntax that the .NET code owners believe is the properly-formed data received from the GoogleAds API, whereas the other two (in red) do not follow an expectation?
If so (for the first question's answer), where did that expectation come from (e.g., within GoogleAds documentation)?
If not, and all three forms should be acceptable, can an adjustment be made within the .NET sample code to handle these appropriately without an error?
Lastly, since this is only one type of non-IMessage data being encountered, can a solution be employed for this as well as the others (I have encountered at least seven others involving other change fields)?

manual_cpc_enhanced_cpc_enabled upto manual_cpc.
maximize_conversions_target_cpa_micros upto maximize_conversions.
responsive_display_ad_long_headline_text upto responsive_display_ad.long_headline.
target_spend_cpc_bid_ceiling_micros upto target_spend.
target_cpa_target_cpa_micros upto target_cpa.
target_impression_share_cpc_bid_ceiling_micros upto target_impression_share.
target_impression_share_location upto target_impression_share.
target_impression_share_location_fraction_micros upto target_impression_share

I hope I have provided what is needed, but please let me know if more information is necessary.
Thank you!
manual_cpc.txt

There have been some issues with change history and change events in the API in the past few days, it may be the reason why you are not able to retrieve your data correctly from the API.
The issues have been resolved now, so can you please try again in a few days' time to see if you are still experiencing the issue?
Thanks and sorry for the inconvenience

Thank you for your follow up on this.
Unfortunately, it does seem to still be happening. For example, six change items just impacted (for request ID N7hVnTJHdTp3-AEb1I19ww which was processed between 2023-08-28 19:36:31.707 UTC and 2023-08-28 19:36:32.807 UTC) were as follow:
•	"Cannot retrieve field value. A non-IMessage field was encountered after navigating maximize_conversions.target_cpa_micros upto maximize_conversions." (happened twice)
•	"Cannot retrieve field value. A non-IMessage field was encountered after navigating target_impression_share.location_fraction_micros upto target_impression_share."
•	"Cannot retrieve field value. A non-IMessage field was encountered after navigating target_impression_share.location upto target_impression_share."
•	"Cannot retrieve field value. A non-IMessage field was encountered after navigating target_impression_share.cpc_bid_ceiling_micros upto target_impression_share."
•	"Cannot retrieve field value. A non-IMessage field was encountered after navigating responsive_display_ad.long_headline.text upto responsive_display_ad.long_headline."

Thank you! I appreciate your verification, and all your work on this.

The last "Cannot retrieve field value. A non-IMessage field was encountered" type of error we received was for RequestID qqNqE8AgmNa6mXQzyjfs1A and was at 2023-08-30 16:35:43.430Z
However, unfortunately, now we are not even able to get as far as where that error was happening to confirm it would be resolved. This is because for any new ChangeEvent, the FieldMaskPath navigation attempt now actually immediately errors out with "Nullable object must have a value" and so it disallows navigation toward collecting changeEvent item data.
This happened between 2023-08-31 17:47:12.517Z and 2023-08-31 17:58:36.507Z for the following 20 RequestIDs:
•	0E1uXFKPULIu-XoaoWp6OQ
•	48s0cblMXdhKMv-syfWavQ
•	4sPMHP-j0Xfe6G3jDIgvVw
•	bmcztLFaK3_90BlTpAVv1Q
•	F2lKKFzsiRAw635NatKnhg
•	fd6OmcOZgBqAv4011pJ0jg
•	Gt0EVU748udeG6SyygYuGw
•	Ipvvf3ZzRwbt0fuhhWwvJQ
•	j3j8oI0cNaOExe2AKOCvzA
•	l7xPk00MFbNJOxM43Gxo-g
•	LQdEf5eWUNy1THcaK-VPCg
•	Mc70fCQ4_B3B9w7Q_9rNpw
•	ObV19xWLoRMjJnQswbmWdA
•	pZ4_beuKO5qFa_NkeiEO2A
•	RTNli-cJ-_bwB16-r6BsqA
•	S8aKX0uD0R8-bOz5GDl09g
•	t2UZeZbsRU2kuznvylTISg
•	XjMTab-bhi-zDnxTur6UBw
•	XY9cr2nowln3OSLYUmuNiQ
•	zEE4kne2UWAmpGrmrOsx-w
I was not sure whether this should be reported as a bug in issue #534 that my issue ended up associated to, or reported in my issue #533 that I have not been able to confirm is resolved yet, or in a new issue altogether.
May you please let me know if I should report this differently, and what can be done to resolve this as well as for me to then be enabled to confirm the IMessage-related issue #533 has been resolved?

I am still encountering the same problem reported in this issue #533.

Are you using the code we recently merged to the main branch? I have just tried running the GetChangeDetails example and it executes successfully.

My code is based off of what I see in Main for GetChangeDetails which says it has not changed since June 08, 2023.
I am looking at ...
https://github.com/googleads/google-ads-dotnet/blob/main/Google.Ads.GoogleAds/examples/AccountManagement/GetChangeDetails.cs
I have also found it at:
https://developers.google.com/google-ads/api/samples/get-change-details
Is there a different place I should be looking?

Ah, I see.
The fix I merged is in the FieldMasks class, and we haven't published a release that contains the change yet.
I'm planning to publish a release next week.

I just released v17.0.1, you should be able to use it now.

Should the GetChangeDetails code (still on V14) pick it up automatically (by virtue of its reference to it)?
For dotnet, I am not seeing FieldMasks available directly; it's a 404 (https://developers.google.com/google-ads/api/docs/client-libs/dotnet/fieldmasks).
When I run the same GetChangeDetails (V14), I am still getting the error (e.g., requestID UrJc6q5toMaJT0IUw4qpOw "Cannot retrieve field value. A non-IMessage field was encountered after navigating target_impression_share.location_fraction_micros upto target_impression_share." at 2023-09-05 14:59:57.000).

That depends on how you are running the examples; if you are including the Google.Ads.GoogleAds PackageReference in your project, you need to update it to version 17.0.1 to see the bugfix.

Thank you; I did have that NuGet package 17.0.0; I have now updated it to the 17.0.1 where you've made the bug fix. So far no repeated error. I will watch it a little while longer. Thanks again for your quick work on this!


pythonPackages.plaid-python: 2.3.0 -> 2.3.3

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python2Packages.plaid-python python3Packages.plaid-python

Success on x86_64-linux (full log)
Attempted: python2Packages.plaid-python, python3Packages.plaid-python
Partial log (click to expand)
============================= test session starts ==============================
platform linux -- Python 3.6.6, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
rootdir: /build/plaid-python-2.3.3, inifile:
collected 1 item

tests/unit/test_errors.py .                                              [100%]

=========================== 1 passed in 1.04 seconds ===========================
/nix/store/5gvd2vsc5x48la5yka1d4a0dlshfh304-python2.7-plaid-python-2.3.3
/nix/store/z6v60ismdrqn1g4c04x5ppj80119y2my-python3.6-plaid-python-2.3.3

Success on aarch64-linux (full log)
Attempted: python2Packages.plaid-python, python3Packages.plaid-python
Partial log (click to expand)
============================= test session starts ==============================
platform linux2 -- Python 2.7.15, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
rootdir: /build/plaid-python-2.3.3, inifile:
collected 1 item

tests/unit/test_errors.py .                                              [100%]

=========================== 1 passed in 8.57 seconds ===========================
/nix/store/1q358fvk45rq9s9k0a3zyfnp0y5gjiam-python2.7-plaid-python-2.3.3
/nix/store/8fv82g5xymkw1v9kpsyx2mn10qzhx34r-python3.6-plaid-python-2.3.3


🔧⚙🔩 [Breaking Change] (config) Add Google guide of Python style as Pylint config and upgrade Poetry settings.

Target

Add Google guide of Python style as Pylint config and upgrade Poetry settings.

Modify Code Scope

Configuration files

Effecting Scope

Nothing, the configuration files all for development.

Description

For Poetry settings:

Upgrade Python version need to newer than 3.7.2.
Add Python dependencies:

About code quality checking:

Pylint

About document development:

Sphinx

Apply configuration of Pylint about Google guide of Python style

refer: https://google.github.io/styleguide/pyguide.html

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.411%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1098

Relevant Lines:
1163

💛  - Coveralls


how to calculate avg effect and spend share?

Hi thanks for your great work.
Here is my question:
It seems that the avg spend share is not the real spend share (spend by channel / total spend).
can you share the formular to calculate avg effect and spend share? Thanks.

clear， thanks a lot.


Automated Package Upgrade

:tada: This PR is included in version 12.2.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Use exact version of mdns-server: 1.0.8

This is to address some differences in the updated mdns-server dependency that change how txt-record parsing is done. We'll switch to using exactly 1.0.8 of mdns-server for the time being.


Reimplement  support for 3D spatialization

Dropping support for AK3DPanner in AudioKit 5 makes sense if it wasn't working in previous versions. But when I first came to AudioKit I was hoping (expecting?) to find it doing some 3D audio spatialization and still think it would be nice to have this available.
The Feature Request is for AudioKit to include 3D audio spatialization by leveraging AVAudioEnvironment or Resonance Audio. Both have both become more stable in recent years and Resonance Audio in particular now incorporates lots of advances features—not all of which would need to be implemented in AudioKit.
I'm not sure how much my coding skills could contribute to this but I'm willing to do what I can, and I can certainly help with implementation ideas, testing, and documentation.
Here's a link to a review that shows of some of what Resonance Audio can do: https://designingsound.org/2018/03/29/lets-test-3d-audio-spatialization-plugins/

2 cent thought:
Resonance Audio uses the Apache 2.0 license. I am no lawyer, but Including this cwould mean that all apps using AK would have to deal with including that licence's notice and license in their 'distribution'. I don't know what that means, legally.

Agreed. If someone needs what Resonance Audio offers they should probably just include that separately.
Probably not a priority, but what are people's thoughts about eventually reimplementing spatialization using AVAudioEnvironment?

I could see those spatialization features being implemented as a 3DMixerNode or similar..
Seems worthwhile, would you take a stab at something like that, @roaring-b ?

I'm not sure my abilities are a good match for this but when I find time I'm willing to see how far I can get on my own.

We will accept this as a PR if you or anyone would like to do it, thanks.


Add my profile Hritvik-Mohan.json

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Hi, I've un-committed the changes. Please check my pull request.


Implements Issue #157- Add support for foreign key constraints

I've opened a disucssion about how we approach the different PR's here: https://groups.google.com/forum/#!topic/gorp-dev/rEsu0efgUfw

Hey @rickb777,
Thanks for this PR!
The last commit (423a897) moves a lot of code from gorp.go to schema.go. I agree with the concept of splitting the code into multiple smaller files, but right now it will probably break a lot of open PR's. Can you undo the moving of code and squash/overwrite that commit? We've also deprecated the develop branch, but you should be able to rebase on master without any problems.
We will split the code in desperate files once the open PR's are closed.

Hi @rickb777
Any chance you can work a bit more on this so we can merge it into master?

This will need some work and manual merging before it can be added. Could be done in v2-phase3 (see #270).


Variadic template impl for CreateAndStart

Less code is good code.

Can you please give a useful description of what your PR does and why?


Direct messages cause notification icons to appear on each team

I confirm (by marking "x" in the [ ] below):

[x] This is not a feature idea. Feature ideas go here: http://www.mattermost.org/feature-ideas/
[x] This is not a troubleshooting question. Troubleshooting questions go here: http://www.mattermost.org/troubleshoot/
[x] This is a product defect issue that can be reproduced using the steps listed below.
[x] I have read CONTRIBUTING.md.

Summary
When receiving a direct message, a red notification icon is added to all tabs and can only be cleared by opening the message on each team.
Steps to reproduce
This is for the Windows Desktop Application version 1.3.0.

Open the Windows Desktop Application and make sure you have joined more than one team (you should have multiple tabs in the application).
Ask someone to send you a direct message.

Expected behavior
The direct message notification icon should be displayed on one team only (e.g. the main team on the server, or make this a user preference), or at least be cleared for all tabs when read on one of the teams.
Observed behavior
The direct message notification icon is displayed on all the teams. The user must open the message in each team for all notification icons to be cleared.

Duplicate of #160.


Removing unit does not remove node from cluster

Removing a microceph unit does not remove the node from microceph cluster.
Deployed sunbeam 2 node with all roles.
Removed the non-primary node using [1]
However microceph status on primary node shows the non-primary node (sunbeam-2) as part of cluster.
$ sudo microceph status
MicroCeph deployment summary:
- sunbeam1 (<IP_ADDRESS>)
  Services: mds, mgr, mon, rgw, osd
  Disks: 3
- sunbeam2 (<IP_ADDRESS>)
  Services: mds, mgr, mon, rgw
  Disks: 0

[1] https://microstack.run/docs/scaling-down

Hm, I couldn't immediately reproducing it using charm-microceph, cf. below
Do you still see this behaviour? If so, would you be able to provide steps for reproducing and logs (juju logs, microceph logs and /v/l/syslog ideally)?
juju deploy microceph -n2 --channel reef/candidate --config default-pool-size=1
juju run microceph/2 add-osd loop-spec=4G,1 --wait=2m
juju run microceph/3 add-osd loop-spec=4G,1 --wait=2m
...

ubuntu@cm-0:~/src/charm-microceph$ juju ssh 2 -- sudo microceph status
MicroCeph deployment summary:
- juju-79f944-2 (<IP_ADDRESS>)
  Services: mds, mgr, mon, osd
  Disks: 1
- juju-79f944-3 (<IP_ADDRESS>)
  Services: mds, mgr, mon, osd
  Disks: 1
Connection to <IP_ADDRESS> closed.
ubuntu@cm-0:~/src/charm-microceph$ juju status
Model           Controller           Cloud/Region         Version  SLA          Timestamp
microceph-test  localhost-localhost  localhost/localhost  3.5.3    unsupported  08:37:35Z

App        Version  Status  Scale  Charm      Channel         Rev  Exposed  Message
microceph           active      2  microceph  reef/candidate   73  no

Unit          Workload  Agent  Machine  Public address  Ports  Message
microceph/2*  active    idle   2        <IP_ADDRESS>
microceph/3   active    idle   3        <IP_ADDRESS>

Machine  State    Address        Inst id        Base          AZ  Message
2        started  <IP_ADDRESS>  juju-79f944-2<EMAIL_ADDRESS>    Running
3        started  <IP_ADDRESS>   juju-79f944-3<EMAIL_ADDRESS>    Running
ubuntu@cm-0:~/src/charm-microceph$ juju remove-unit microceph/3
WARNING This command will perform the following actions:
will remove unit microceph/3

Continue [y/N]? y
ubuntu@cm-0:~/src/charm-microceph$ juju status
Model           Controller           Cloud/Region         Version  SLA          Timestamp
microceph-test  localhost-localhost  localhost/localhost  3.5.3    unsupported  08:39:08Z

App        Version  Status  Scale  Charm      Channel         Rev  Exposed  Message
microceph           active      1  microceph  reef/candidate   73  no

Unit          Workload  Agent  Machine  Public address  Ports  Message
microceph/2*  active    idle   2        <IP_ADDRESS>

Machine  State    Address        Inst id        Base          AZ  Message
2        started  <IP_ADDRESS>  juju-79f944-2<EMAIL_ADDRESS>    Running
ubuntu@cm-0:~/src/charm-microceph$ juju ssh 2 -- sudo microceph status
MicroCeph deployment summary:
- juju-79f944-2 (<IP_ADDRESS>)
  Services: mds, mgr, mon, osd
  Disks: 1

Closing this bug as this works now and could be something wrong on my side while testing.