[PERF] Simplify AST with smart pretty printing

The pretty printer should do reverse precedence parsing, to decide the correct precedence operators to use for a given operation (like match) instead of requiring them to be encoded separately int the AST.

Remove long form ops


[MM-23727] Proposal to remove unnecessarily strict channel url validation

Summary

This ticket was originally for fixing inconsistent validation when renaming the channel url property (Restricted channel urls from containing __ on create but not on rename)

After our discussion on https://github.com/mattermost/mattermost-server/pull/14230 it was found that restricting a channel url to not contain __ is not required.
Only channels of the format UserId__UserId needed to be prevented from being created for non direct channels (eg. uzsfmtmniifsjgesce4u7yznyh__uzsfmtmniifsjgesce5u7yznyh)

Changes proposed in this PR would change channel URL validation to only ensure that something of the format UserId__UserId cannot be saved, resulting in a validation error that looks like User ids are not permitted in channel URL for non-direct message channels. (Wording to Require PM / UX Review)

Ticket Link
https://mattermost.atlassian.net/browse/MM-23727
Screenshots

@andrewbrown00 I have attached some screenshots based on the discussion we had on mattermost
let me know if you notice any issues

Updated screenshot with fixed wording for new validation error "Start and end with..."

Thanks @fmunshi, I replied in our DM to resolve to items.

Adding the updated messages for visibility based on my review with @fmunshi.
HELP TEXT You can use lowercase letters, numbers, dashes, and underscores.
START WITH URLs must start with a lowercase letter or number.
END WITH URLs must end with a lowercase letter or number.
START AND END URLs must start and end with a lowercase letter or number.
Invalid DM User IDs are not allowed in channel URLs.
Invalid URL URLs must have at least 2 characters.
Invalid Name Display name must have at least 2 characters.

Thanks @andrewbrown00 I updated the error message to address the last couple of issues you mentioned and have attached screenshots showing those two changes.

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-5342.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

Test server destroyed

Bump @sudheerDev for dev review

/update-branch

@stevemudie a UserID is any 26 character string so the format that will return an error on rename will only be two 26 character strings separated by a __. I tried it on the test server and the error did get thrown for me.

@fmunshi I've used both an actual 26 character UserID as well as a random one and even tried using two different 26 character strings all with an underscore between them when renaming a channel and still haven't seen any errors.

@stevemudie Looks like you dont have two underscores between the user ids
the format is 26 character string => two underscores => 26 character string

Sorry for the confusion 😅


Trigger build again

Status
Ready
Related Content Pull Request
Related PR:
Related Issues
Related: https://github.com/demisto/etc/issues/41939
Description
Trying to upgrade the readpdf image.

@glicht Why isn't circle reporting the build?


Add 30° angled FTD style back

I added the image and STL for a 30° angled FTD style back. I also removed the fillet at the bottom and replaced it with small chamfers, making it possible to print it without any infill with the large flat area down.

Nice @bergdahl !


hub.docker.com outdated

Due to https://github.com/DefectDojo/django-DefectDojo/issues/1527, the current (pre-)release is not getting build.
Expected: Images are build more often (also to include current OS package updates)

@aaronweaver @devGregA  can you retrigger to see if the error stays, please.


Added CSharp .NET Core examples

I ported the opc client from the python examples to c# using .NET core.

Wow, sorry I'm so slow at email stuff, finally saw this :-/
Thanks for the patch!

No problem!  Happy to contribute!  I love the fadecandy!


Automated cherry pick of #7693

Cherry pick of #7693 on release-5.33.
/cc  @sbishel

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: c756342e8c7ef64f48b5317eeba09cf7e6b3e9d9


Custom Nuget Package Issue with TFS

I have wrapped up my java script code in Nuget package for distribution.Other team members can use this code by installing the nuget package created by us. this package contains nested folder structure and bulk java script  files.
I have created this package by using Nuget Package Explorer. Hosted it locally and run the command from package console. "install-package ".
It works very well but the issue comes on TFS. When someone install the package on TFS project, it throws weird error "Collection Was Modified; Enumeration Operation May Not Execute." Al tough the package in installed with this error.
This is embracing  because we did everything but in the end it fails if we can not distribute that. Alternatively i have used batch file for that.
I have already posted an issue on the following url:
https://social.msdn.microsoft.com/Forums/vstudio/en-US/3c9e8980-8ddd-4479-9e81-6423c9556c40/install-nuget-package-error-collection-was-modified-enumeration-may-not-execute-in-tfs?forum=tfsworkitemtracking&prof=required
They suggesting me to contact with Nuget team.
Is this a good practice to wrap up thousands of java scripts files in a package?
Please look into this, i hope will get some resolution here.......

Moved to https://github.com/NuGet/Home/issues/932

Closed Without resolution.....
Great......

Closed after moving to https://github.com/NuGet/Home/issues/932, which is still open.

ok, Sorry for the comments. Hope will get the resolution here.


Find another maintainer

I don't use the project myself, with the several programmable type-class features in GHC it's less important, and the projects which would have a serious need for this kind of thing (e.g. lens) contain the code themselves. To remain relevant and useful some thought should probably be given to exactly what derive should do, and how it should do it, and given I have no itch to scratch, I'm the wrong person to do it.
On the flip side, there are 67 reverse dependencies, so it's a fairly well-used project. I'll keep up with bug fixes for the time being, but aim to find an alternative maintainer (or co-maintainer to start with). This ticket is to write a blog post for that.

I just used derive to generate QuickCheck Arbitrary, first time I've ever used derive.
By the way, the Hackage page https://hackage.haskell.org/package/derive points to http://community.haskell.org/~ndm/derive/ where there is nonexistent link to a manual https://rawgithub.com/ndmitchell/derive/master/derive.htm, so I see the need for a maintainer :-). I'm still completely new to derivations, however, and am planning to learn how to write my own.

I've uploaded derive-2.5.21 with the fixed home page - there are many reasons it needs a new maintainer, but dodgy web links shouldn't be one!

Blog post published: https://neilmitchell.blogspot.co.uk/2016/07/maintainer-required-for-derive.html

I am interested in maintaining a library. I've done a little work with template Haskell and derive.
Before I do anything like this I'd like to have a conversation about where you see the library going, remaining issues and problems, and to make sure I'd be a good fit.
https://github.com/pa-ba/compdata/pull/14

The main work required is to follow both template-haskell and haskell-src-exts releases and keep on top of them.
On a day to day maintenance, there are a few things. There is lots of scope for improving code quality - lots of modules lack explicit export lists for example. There are CPP definitions for GHC 6.12, which could be removed. The library is more useful the more types of derivation it supports, and there are plenty of new ones it doesn't support at all.
On the forward looking, there is the question of how this related to GHC's generic deriving. Maybe this is a more convenient way to specify such an instance? Maybe there is some other relationship? Maybe it's all about generating instances that auto-specialise and chase the high-performance end? I'd like the library to be useful to the people who have already started using it, but as I don't use it, I don't consider myself to have much opinion on where it goes from here.

The need has arisen to make a fairly substantial haskell-src-exts upgrade, as tracked in #19.
I've done a bunch of work on it, but absent another maintainer, I don't really intend to keep doing that. If another maintainer isn't found I'll probably just keep the tight bound on an old haskell-src-exts and remove derive from Stackage.

I've removed derive from Stackage: https://github.com/fpco/stackage/pull/1772

Can do lah!
Shall we make GitHub organization for maintaining Derive?

That's up to you and @tomberek or anyone else who offers. I'd just fork the project or have me transfer ownership unless two of you want to co-maintain, and in that case you can make an organisation or anything else you fancy.

So I'd like to get this issue closed out, and give over maintainership, as there are questions trickling in that I don't feel anyone is in a place to reply to without a proper maintainer. @tomberek @mgajda - are you happy to be co-maintainers? Or does one want to take it with the other a sub-maintainer? Do you want to set up an organisation, or just one of you clone it and give the other write permission (that works just fine if it's only two of you). I suggest your first order of business should be a new 0.0.1 release changing the maintainer field - and then this bug will be well and truly closed.

I would join a github derive maintainer group.

@ddssff everyone who has said they would be happy to be a maintainer hasn't yet actually created a maintainer group. If you do that, it's all yours!

@ddssff thanks for creating https://github.com/DeriveMaintainers. I note that the project th-typegraph is already assigned to that project - was it intentional?

Yes, its my solution to #13.  It could use some polish though.

Cool, as long as it's intentional that seems sensible.


I0512 09:20:43.552963       1 generic_scheduler.go:434] "Plugin scored node for pod" pod="kube-system/open-local-init-job-4t5vh" plugin="ImageLocality" node="master-480b2-2" score=10
I0512 09:20:43.552975       1 generic_scheduler.go:434] "Plugin scored node for pod" pod="kube-system/open-local-init-job-4t5vh" plugin="ImageLocality" node="master-a98ee-1" score=10
I0512 09:20:43.552985       1 generic_scheduler.go:434] "Plugin scored node for pod" pod="kube-system/open-local-init-job-4t5vh" plugin="ImageLocality" node="master-e6344-0" score=10
I0512 09:20:43.552996       1 generic_scheduler.go:434] "Plugin scored node for pod" pod="kube-system/open-local-init-job-4t5vh" plugin="InterPodAffinity" node="master-480b2-2" score=0
I0512 09:20:43.553007       1 generic_scheduler.go:434] "Plugin scored node for pod" pod="kube-system/open-local-init-job-4t5vh" plugin="InterPodAffinity" node="master-a98ee-1" score=0
I0512 09:20:43.553018       1 generic_scheduler.go:434] "Plugin scored node for pod" pod="kube-system/open-local-init-job-4t5vh" plugin="InterPodAffinity" node="master-e6344-0" score=0
I0512 09:20:43.553028       1 generic_scheduler.go:434] "Plugin scored node for pod" pod="kube-system/open-local-init-job-4t5vh" plugin="NodeResourcesFit" node="master-480b2-2" score=70
I0512 09:20:43.553042       1 generic_scheduler.go:434] "Plugin scored node for pod" pod="kube-system/open-local-init-job-4t5vh" plugin="NodeResourcesFit" node="master-a98ee-1" score=66
I0512 09:20:43.553053       1 generic_scheduler.go:434] "Plugin scored node for pod" pod="kube-system/open-local-init-job-4t5vh" plugin="NodeResourcesFit" node="master-e6344-0" score=68
I0512 09:20:43.553064       1 generic_scheduler.go:434] "Plugin scored node for pod" pod="kube-system/open-local-init-job-4t5vh" plugin="NodeAffinity" node="master-480b2-2" score=0
I0512 09:20:43.553073       1 generic_scheduler.go:434] "Plugin scored node for pod" pod="kube-system/open-local-init-job-4t5vh" plugin="NodeAffinity" node="master-a98ee-1" score=0
I0512 09:20:43.553081       1 generic_scheduler.go:434] "Plugin scored node for pod" pod="kube-system/open-local-init-job-4t5vh" plugin="NodeAffinity" node="master-e6344-0" score=0
I0512 09:20:43.553089       1 generic_scheduler.go:434] "Plugin scored node for pod" pod="kube-system/open-local-init-job-4t5vh" plugin="PodTopologySpread" node="master-480b2-2" score=200
I0512 09:20:43.553097       1 generic_scheduler.go:434] "Plugin scored node for pod" pod="kube-system/open-local-init-job-4t5vh" plugin="PodTopologySpread" node="master-a98ee-1" score=200
I0512 09:20:43.553104       1 generic_scheduler.go:434] "Plugin scored node for pod" pod="kube-system/open-local-init-job-4t5vh" plugin="PodTopologySpread" node="master-e6344-0" score=200
I0512 09:20:48.553928       1 generic_scheduler.go:491] "Calculated node's final score for pod" pod="kube-system/open-local-init-job-4t5vh" node="master-480b2-2" score=464
I0512 09:20:48.553964       1 generic_scheduler.go:491] "Calculated node's final score for pod" pod="kube-system/open-local-init-job-4t5vh" node="master-a98ee-1" score=459
I0512 09:20:48.553973       1 generic_scheduler.go:491] "Calculated node's final score for pod" pod="kube-system/open-local-init-job-4t5vh" node="master-e6344-0" score=461
or
coredns-8bc66bb95-2lrv4                          1/1     Running     0               6d21h   <IP_ADDRESS>       master-a98ee-1
coredns-8bc66bb95-kdccp                          1/1     Running     0               6d21h   <IP_ADDRESS>       node-5decf-1
etcd-master-480b2-2                              1/1     Running     0               6d21h   <IP_ADDRESS>     master-480b2-2
etcd-master-a98ee-1                              1/1     Running     0               6d21h   <IP_ADDRESS>     master-a98ee-1
etcd-master-e6344-0                              1/1     Running     0               6d21h   <IP_ADDRESS>     master-e6344-0
kube-apiserver-master-480b2-2                    1/1     Running     1 (6d21h ago)   6d21h   <IP_ADDRESS>     master-480b2-2
kube-apiserver-master-a98ee-1                    1/1     Running     1 (6d21h ago)   6d21h   <IP_ADDRESS>     master-a98ee-1
kube-apiserver-master-e6344-0                    1/1     Running     0               6d21h   <IP_ADDRESS>     master-e6344-0
kube-controller-manager-master-480b2-2           1/1     Running     0               6d21h   <IP_ADDRESS>     master-480b2-2
kube-controller-manager-master-a98ee-1           1/1     Running     0               6d21h   <IP_ADDRESS>     master-a98ee-1
kube-controller-manager-master-e6344-0           1/1     Running     2 (6d21h ago)   6d21h   <IP_ADDRESS>     master-e6344-0
kube-proxy-cf85t                                 1/1     Running     0               6d21h   <IP_ADDRESS>     node-5decf-1
kube-proxy-ctcgs                                 1/1     Running     0               6d21h   <IP_ADDRESS>     node-5d530-0
kube-proxy-p5976                                 1/1     Running     0               6d21h   <IP_ADDRESS>     node-8188c-2
kube-proxy-qmwjg                                 1/1     Running     0               6d21h   <IP_ADDRESS>     master-a98ee-1
kube-proxy-sx87r                                 1/1     Running     0               6d21h   <IP_ADDRESS>     master-e6344-0
kube-proxy-txhrm                                 1/1     Running     0               6d21h   <IP_ADDRESS>     master-480b2-2
kube-scheduler-master-480b2-2                    1/1     Running     4 (15h ago)     15h     <IP_ADDRESS>     master-480b2-2
kube-scheduler-master-a98ee-1                    1/1     Running     4 (15h ago)     15h     <IP_ADDRESS>     master-a98ee-1
kube-scheduler-master-e6344-0                    1/1     Running     4 (15h ago)     15h     <IP_ADDRESS>     master-e6344-0
open-local-agent-4dcxm                           3/3     Running     0               12h     <IP_ADDRESS>     master-480b2-2
open-local-agent-97bvp                           3/3     Running     0               12h     <IP_ADDRESS>     node-5d530-0
open-local-agent-t7f27                           3/3     Running     0               12h     <IP_ADDRESS>     node-8188c-2
open-local-agent-tgdhd                           3/3     Running     0               12h     <IP_ADDRESS>     master-e6344-0
open-local-agent-vqzjt                           3/3     Running     0               12h     <IP_ADDRESS>     master-a98ee-1
open-local-agent-vscxm                           3/3     Running     0               12h     <IP_ADDRESS>     node-5decf-1
open-local-controller-5685c7478d-22hsw           6/6     Running     0               12h     <IP_ADDRESS>   node-8188c-2
open-local-init-job-6fbxc                        0/1     Completed   0               12h     <IP_ADDRESS>     master-480b2-2
open-local-init-job-ksv58                        0/1     Completed   0               12h     <IP_ADDRESS>     master-e6344-0
open-local-init-job-ls97g                        0/1     Completed   0               12h     <IP_ADDRESS>     master-e6344-0
open-local-scheduler-extender-7cd95c99d4-pbf9s   1/1     Running     0               12h     <IP_ADDRESS>     master-480b2-2
tigera-operator-744458d65c-lkdnk                 1/1     Running     0               6d21h   <IP_ADDRESS>     node-5d530-0

open-local-init-job-4t5vh 0/1 Completed 0 3m54s <IP_ADDRESS>   master-480b2-2
open-local-init-job-nggwp 0/1 Completed 0 3m54s <IP_ADDRESS> master-a98ee-1
open-local-init-job-v5lsr 0/1 Completed 0 3m54s <IP_ADDRESS>    master-480b2-2
or
open-local-init-job-6fbxc 0/1 Completed 0 12h <IP_ADDRESS>  master-480b2-2
open-local-init-job-ksv58 0/1 Completed 0 12h <IP_ADDRESS> master-e6344-0
open-local-init-job-ls97g 0/1 Completed 0 12h <IP_ADDRESS>  master-e6344-0

open-local-init-job-4t5vh 0/1 Completed 0 3m54s <IP_ADDRESS> master-480b2-2
open-local-init-job-nggwp 0/1 Completed 0 3m54s <IP_ADDRESS> master-a98ee-1
open-local-init-job-v5lsr 0/1 Completed 0 3m54s <IP_ADDRESS> master-480b2-2
or
open-local-init-job-6fbxc 0/1 Completed 0 12h <IP_ADDRESS> master-480b2-2
open-local-init-job-ksv58 0/1 Completed 0 12h <IP_ADDRESS> master-e6344-0
open-local-init-job-ls97g 0/1 Completed 0 12h <IP_ADDRESS> master-e6344-0

please check if podAntiAffinity exists in helm/templates/init-job.yaml

@shaolila @lihezhong93 any update?

increase sleep  time in init-job container commands, such as 'sleep 10'

that's right!

@shaolila @lihezhong93 any update?

fixed!

increase sleep time in init-job container commands, such as 'sleep 10'

It's right!


Allow using non-bash shells

I'm using zsh which has all my kubectl aliases, but kui uses bash by default. Couldn't find any setting to swith the shell

/remove-lifecycle stale
I'm having this issue as well (version 0.4.31_Linux_amd64):

Thanks for the update 👍


Fix picker demo safe area layout

Fixes https://github.com/flutter/flutter/issues/22240

I can't tell what the original problem was, or how this fixes it.  Can you explain?

From the image in #22240, the top MediaQuery padding is causing the top of the wheel to be too far from the top of the bottom sheet.

And that padding fixes the "gradient" issue referenced in that bug, too?


Title in Plots

Need to add a part of the code to add titles to the generated plot.

Added code to make a title at the top center of the plot.


CON-1169: Upgrade dokka to 1.5.31

The folder .github/workflow should be removed.

The check Dokka (Conclave Core)  is failing because the task that publishes to Artifactory does not exist. That task was added by us.


"Double click to edit" possibly misleading

I just updated two of my throwaway passwords through the breached passwords dialog and when I was done, I lost access to those services because as it turned out... Keepass didn't actually store the edited passwords.
The odd thing is - after editing the passwords, I double clicked the entries again to double check whether the passwords had really been changed. And they were there. So... somehow, the passwords get updated in the breached passwords dialog but aren't transferred to the actual database.
Might it have to do with the fact that Keepass locked itself in the background while I was editing the passwords?
Anyway, - if you can't ensure that the edited passwords actually are updated in the database on closing the dialog, I think that it would be great if you could warn the user in bold red text or not allow editing from that dialog from the get-go...

Double click to edit should be opening the entry in the database not a copy from the breached password dialog.
Did you try opening the entries from the main keepass window after closing the breached entries dialog?
Also, editing entries will not automatically save the database.
I'm unsure how you determined that keepass didn't store the passwords.
If the database locks itself in the background then this definitely is a problem, the dialog should ideally be disabled until then database is unlocked again.

Alright, my process step by step:

double clicked an entry from the breached password dialog
went to that website, the change password process
generated a new password, displayed it in plain text so I could copy it from that window
finished the change password process
clicked OK on that editing password window
did the same with the other password
closed the breached entries dialog
tried logging into one of the services using the global hotkey and it tried entering my old password (which I immediately realized because it was just ~8 characters instead of 20)

Interesting, so I just tried to replicate this with a dummy entry which I know has a breached password.

Double clicked entry
Changed password to a known new password
Clicked OK on edit password window
Closed breached entries dialog
Autotyped into a new text editor window (CTRL-V), it entered new password
Opened entry from main database window and confirmed that new password was stored.

I'll need to test this again to see what happens when the database is locked while the breach dialog/editor dialog are open.

Well... that workflow makes you return quicker from the breached password dialog to the main window but it still assumes that you do that within your set "lock time". Which is 1 minute in my case...
(And apparently, you can't assume that everybody does things the way you do them. ;) )
But I suppose the breach dialog getting disabled when the database locks would indeed be one way of resolving this... in my case, it obviously stayed enabled.


Add simple helm CLI wrapper for fleet charts

We need to implement Helm CLI wrapper, which would provide basic functionality for fleet CRD, agent and controller operations, like:

[ ] Helm repo operation
[ ] Helm list
[ ] Helm install
[ ] Helm template
[ ] Helm uninstall

The CLI will be available in the addon image, and it will use in-cluster kubeconfig. RBAC roles should updated accordingly to allow performing operations like helm install and helm uninstall.

Deprecated in favor of #42

Deprecated in favor of #42


Please describe the POST methods to create the new DRS objects to the DRS database.

Dear @jb-adams,
Thanks for providing this repo to help us to implement the DRS in our institute much easier.
However, a detailed description of POST methods is lacking. It would be great if the POST methods can be documented as well as GET methods.
Currently, I can only call the admin UI APIs to create a new object to DRS.
referenced issue: https://github.com/ga4gh/data-repository-service-schemas/issues/383
Thanks,

Thanks for raising this @polarbear127 , we really do need to get a swagger UI associated with the API.
We have the following endpoints for DRS object admin:
POST /admin/ga4gh/drs/v1/objects
PUT /admin/ga4gh/drs/v1/objects/{object_id}
DELETE /admin/ga4gh/drs/v1/objects/{object_id}

To hit these endpoints successfully, you will have to use the administrative API port, which is different from the public API port (defaults: public port: 4500, admin port: 4501)
But there are custom fields for storing information about the DRS Object that can't be inferred from the public API, so you'll need the Swagger UI to see how a DRS object is formatted when creating one in our implementation.

Thanks for raising this @polarbear127 , we really do need to get a swagger UI associated with the API.
We have the following endpoints for DRS object admin:
POST /admin/ga4gh/drs/v1/objects
PUT /admin/ga4gh/drs/v1/objects/{object_id}
DELETE /admin/ga4gh/drs/v1/objects/{object_id}

To hit these endpoints successfully, you will have to use the administrative API port, which is different from the public API port (defaults: public port: 4500, admin port: 4501)
But there are custom fields for storing information about the DRS Object that can't be inferred from the public API, so you'll need the Swagger UI to see how a DRS object is formatted when creating one in our implementation.

Thanks a lot! I've gotten these APIs through developer tools in the web browser. But it's helpful that I can confirm they are correct!


Add a GUI for converting Earth Engine JavaScript to Python without coding

This feature will add a button to the toolbar. Users just need to click a few buttons to convert scripts.

This feature has been implemented. Users can now convert Earth Engine JavaScript to Python without coding.
https://user-images.githubusercontent.com/5016453/107839323-11152180-6d79-11eb-8313-8c01602ad14e.mp4


If nodate is set do not show the date line.

For pages like about or bio or things like that, people may not want to have a date line.
With this change, you can have nodate = true set for a page to suppress the date.

Thanks for telling me about the page feature. That solves my issue perfectly.


GUI functionallity and usage

Hello @helene-t ,
do you have some documentation the SciDataTool GUI?
I tried to visualize e.g. phase fluxlinkage and their FFT but I was not able to do that. Or at least it seems to be not intuitive to me. Further the 'Filter' button seem to have no functionallity (at least for now).
Best regards, Sebastian

Hello @SebGue ,
Unfortunately we did not have the time to write a documentation for the GUI yet.
To perform FFT, you should have the option "FFT" available in the combobox for the x-axis (instead of None). If you do not check "auto-refresh", you must not forget to click on "Refresh" to see the actualization on the graph.
The filter button is designed for string axes (with is_components=True). It opens a dialog with filtering options.
Do not hesitate to ask for further information.
Helene

Hello @helene-t ,
I think I finally understand at least some of the GUI (fig. I).
'Axes Selection' (blue section) is 'Plot Axes Selection'.
'Axes Operation' (red section) means 'Other Axes Operations'.

Figure I
Now if I select 'overlay/filter' for phase axes as 'Axes Operations', I get the expected result (fig. II). Nevertheless it would be more convenient if this was the default setting. At least for fluxlinkage this makes sense, but maybe for your needs 'rms' is the better choise?!

Figure II
Still I'm don't really know how to get a valid FFT of the 3 phases fluxlinkage. If I do a FFT with 'Phase=rms' I get a bin of a senseful magnitude but it is only one bin and there are no other frequency components (fig. III).

Figure III
If I select 'overlay/filter' instead, there is an error:
Traceback (most recent call last):
  File "C:\Program Files\Python38\lib\site-packages\SciDataTool\GUI\DDataPlotter\DDataPlotter.py", line 149, in auto_update
    self.update_plot()
  File "C:\Program Files\Python38\lib\site-packages\SciDataTool\GUI\DDataPlotter\DDataPlotter.py", line 488, in update_plot
    self.data.plot_2D_Data(
  File "C:\Program Files\Python38\lib\site-packages\SciDataTool\Methods\DataND\plot_2D_Data.py", line 493, in plot_2D_Data
    indices = [
  File "C:\Program Files\Python38\lib\site-packages\SciDataTool\Methods\DataND\plot_2D_Data.py", line 496, in <listcomp>
    if abs(y) > abs(thresh * np_max(Ydatas[0]))
ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

Further there is an issue if I select 'phase' axes for X:
Traceback (most recent call last):
  File "C:\Program Files\Python38\lib\site-packages\SciDataTool\GUI\DDataPlotter\DDataPlotter.py", line 149, in auto_update
    self.update_plot()
  File "C:\Program Files\Python38\lib\site-packages\SciDataTool\GUI\DDataPlotter\DDataPlotter.py", line 488, in update_plot
    self.data.plot_2D_Data(
  File "C:\Program Files\Python38\lib\site-packages\SciDataTool\Methods\DataND\plot_2D_Data.py", line 213, in plot_2D_Data
    result = d.get_along(
  File "C:\Program Files\Python38\lib\site-packages\SciDataTool\Methods\DataND\get_along.py", line 36, in get_along
    axes_list, transforms = self._comp_axes(axes_list)
  File "C:\Program Files\Python38\lib\site-packages\SciDataTool\Methods\DataND\_comp_axes.py", line 67, in _comp_axes
    axis_requested.get_axis(self.axes[axis_requested.index], is_real=self.is_real)
  File "C:\Program Files\Python38\lib\site-packages\SciDataTool\Methods\RequestedAxis\get_axis.py", line 46, in get_axis
    values = axis.get_values(unit=self.unit)
  File "C:\Program Files\Python38\lib\site-packages\SciDataTool\Methods\Data1D\get_values.py", line 122, in get_values
    values = convert(values, self.unit, unit)
  File "C:\Program Files\Python38\lib\site-packages\SciDataTool\Functions\conversions.py", line 256, in convert
    raise UnitError(
SciDataTool.Functions.UnitError: Units rad and  do not match

Do you have is_overlay=True in your "phase" axis? It should help solve all the above issues.

Is this an axis attribute? The SciData Object I try to plot is the 'default' Pyleecan fluxlinkage (i.e. Out.Mag.Phi_wind_stator).

Yes it is an attribute of Data1D. In the latest versions of Pyleecan and SciDataTool, it should be set correctly. You can also try to initialize the GUI with Phi_wind_stator.plot("time", "phase[]")

Thank you, setting the attribute helped. Nevertheless there is only one freqency.  Also the filter is disabled now. Is there an option to only analyze a single (string) axis value?
Regarding export, what's your default decimal seperator? Would you mind to enable at least the option for default 'comma'?

There is a filter of low amplitude harmonics. You should maybe try the simple plot Phi_wind_stator.plot_2D_Data("freqs", "phase[0]") to check if the issue comes from the GUI or from the plot itself. You can use the plot_2D_Data options (x_max, is_auto_ticks, is_auto_range, etc) to check your data.
The filter should be available on your phase axis, through the "overlay" button.
Concerning exports, it is for now only available in csv format, therefore with "." decimal separator.


[UI/UX] UP/DOWN button on slide preview in sidebar to change slide order

Description
Currently slide order cannot be changed. Drag and drop feature to change order will be implemented by this issue (https://github.com/UNDP-Data/geohub/issues/3889). however, it would be nice to have buttons (UP/DOWN) to move a chapter.
Screenshots
current

maybe addition two buttons (UP/DOWN) to change order
maybe following icons can be used

UP: https://fonts.google.com/icons?selected=Material+Symbols+Outlined:keyboard_arrow_up:FILL@0;wght@400;GRAD<EMAIL_ADDRESS>DOWN: https://fonts.google.com/icons?selected=Material+Symbols+Outlined:keyboard_arrow_down:FILL@0;wght@400;GRAD<EMAIL_ADDRESS>
Mockup URL/file
No response

@balagurova I implemented this feature by #3896. PR was already merged, but I will update UI later.

first chapter

middle chapter

last chapter

Figma prototype for this issue

Please remove the buttons (as discussed on the call)

reverted by #3905


Encryption/Decryption on ent fields level?

Is there any way I can encrypt the data before I save it to database?
For example, there is a sensitive data says "first_name" that I'd like to encrypt it before save it to DB. Also, I need to decrypt it after I retrieve it from DB. Is this something I can achieve in ent?
I am using ent+gqlgen. One solution I can come up is that writing custom graphql resolvers for those sensitive fields.

hey @kerryoscer,
I opened a discussion on this topic at https://github.com/ent/ent/discussions/2364, you're welcome to join in.
I will post there now some details on an experiment we're running with this at @ariga.

Can you share more details on your use case in the discussion there?


Enum issue: 'subscript(dynamicMember:)' is unavailable

I am trying to use an enum which is declared like this:
enum Lang: String, CaseIterable, Codable, DefaultsSerializable {
    case en
    case fr
    case ru
}

And this is how I implemented SwiftyUserDefaults
public struct DefaultsKeys: DefaultsKeyStore {
    // This doesn't work (enum)
    var currentTargetLang: DefaultsKey<Lang?> { return .init("learningLang") }

    // This works (string)
    var enVoiceIdentifier: DefaultsKey<String?> { return .init("enVoiceIdentifier") }
}

// Actually call
var Defaults = DefaultsAdapter<DefaultsKeys>(defaults: UserDefaults(suiteName: appGroupName)!, keyStore: .init())

Defaults.enVoiceIdentifier // works
Defaults.currentTargetLang // doesn't work

How am I supposed to use enum with DefaultsKey?

Hey @Kalzem. This is a problem when you have an enum that is both Codable and RawRepresentable (String in your case). See my answer in this issue and let me know if it helps.

Ohhh I couldn't find the ticket you mention as the xcode error is different :)
Thank you!

@Kalzem no problem at all, hope it helped with the issue :)


Repo sync for protected CLA branch

The pull request is created from main638028543140217536sync_temp to main to fix git push error for protected CLA branch

Learn Build status updates of commit 3be84cd:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


About the total batch size

Hello, is your total batch is 4*4 on 4 V100 GPUs?
Have you tried bigger batch size? I have tried bigger batch size but the results are not good.

I tried 8 gpu + 4 batch size. Results are similar. I linearly scale the lr (using 2x)

I tried 8 gpu + 4 batch size. Results are similar. I linearly scale the lr (using 2x)

I tried 2 A100 with 248 batch size，the lr is 0.06/0.04， but both the result is lower than the batch 82.

I guess it is too large ( and linear scaling doesn't apply) maybe try some smaller one ?

I guess it is too large ( and linear scaling doesn't apply) maybe try some smaller one ?

Yeah，I have tried the original lr 0.01 ， and the results are similar to those results of small batch. So linear scaling seems not work well.


doesn't build with psc 0.10

➜  purescript-aff git:(master) pulp build
* Building project in /Users/rvion/dev/purescript-aff
Error found:
in module Control.Monad.Aff.Console
at /Users/rvion/dev/purescript-aff/src/Control/Monad/Aff/Console.purs line 36, column 1 - line 36, column 34

  No type class instance was found for

    Control.Monad.Eff.Class.MonadEff ( console :: CONSOLE
                                     | t0
                                     )
                                     (Aff
                                        ( console :: CONSOLE
                                        | eff1
                                        )
                                     )

  The instance head contains unknown type variables. Consider adding a type annotation.

while checking that expression (compose liftEff) warnShow
  has type forall a eff.
             (Show a) => a
                         -> Aff
                              ( console :: CONSOLE
                              | eff
                              )
                              Unit
while applying a function compose
  of type forall b c d a. (Semigroupoid a) => a c d -> a b c -> a b d
  to argument liftEff
in value declaration warnShow

where eff1 is a rigid type variable
        bound at line 36, column 1 - line 36, column 34
      t0 is an unknown type

See https://github.com/purescript/purescript/wiki/Error-Code-NoInstanceFound for more information,
or to contribute content related to this error.

psc --version
0.10.0

Everything that uses MonadEff or any of the transformers classes doesn't work in 0.10, due to a fix in inference that now requires fundeps for the types to work out. We'll be releasing a new round of core libraries soon and then updating everything.

Hi! I was wondering if there were any news from this issue? It is pretty inconvinient as the new versions of psc becomes more and more adopted.

Hi! I was wondering if there were any news from this issue? It is pretty inconvinient as the new versions of psc becomes more and more adopted.

We are still waiting for a new version of purescript-parallel before we can release an update.


Feature: Add Code clicking component

Create a component where clicking on a given line of code should load the corresponding image.
Put the component into the Lesson 5 page here:

Will be here on the site.

is there a figma with the diarams?


i cant run application

hi
how i can run redis server in windows?
i cant run app and i get Rediss Connection to localhost:6379 faild - connet ECONNREFUSED <IP_ADDRESS>:6379
i use cmd in windows
thanks

This is probably why I prefer the web versions of various games, as well as online casinos, because there are almost never problems with the sites. There are now a wide variety of gambling platforms. You can even find 5 dollar minimum deposit casino. Without risking your own money too much, you can play and have a great gambling experience.


Add support for Any

and also potentially oneof (not currently tested)

Should be fixed by a84f4bb and available in 1.1


GitHub RSS SSH Host key changed

This is not a problem regarding this plugin, but I assume that many who use this plugin and have hosted their remote repo on GitHub currently have some problems because of that.
GitHub changed their RSS SSH Host key: https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/
At first I had to remove the old keys for github.com in ~/.ssh/known_hosts and import the new key. See the linked article for instructions.
After that I still had some problems with Git inside Obsidian. Unfortunately there were no error/warning logs in the dev console (maybe something that can be improved). On the terminal I was able to see the problem:
Warning: the ECDSA host key for 'github.com' differs from the key for the IP address '<IP_ADDRESS>'
...
Are you sure you want to continue connecting (yes/no)?

So I also had to remove old entries in known_hosts for all IP addresses of github.com (there were many entries with 140.82.x.x in the file).
Finally the git integration in Obsidian worked again.
Optional improvement:
I don't want that my known_hosts file includes multiple entries for all the ip addresses github.com is using (github.com uses DNS load balancing). Instead it should be sufficient to only have one entry with the host name github.com.
There I have now disabled the SSH option CheckHostIP for github.com in the config file (~/.ssh/config):
Host github.com
  CheckHostIP no

I guess this one cannot be solved on the plugin side

@GameFixxer You are right. I created this issue especially to help others who had the same problems and were unsure whether the problem was perhaps caused by the plugin (it wasn't, GitHub is to blame).


Warn/fail on long IPCache convergence times

For https://github.com/cilium/cilium/issues/16302.
Commit 37d795c483bd861635a11c7592ea0136a7de77cc introduced a wait loop to watch for ipcache entries the test suite depends on. Currently, its timeout is set to 20 seconds, and exceeding it results in a testing error.
@gandro @jrajahalme Should this timeout be lowered? Anything else we could add here?

In my opinion, I think if IPCache updates takes longer than say 30 seconds, it should be a hard test failure, as this will also be noticeable to users. If we just warn and increase the timeout, I'm afraid the warnings will likely just be ignored by most developers.

The question is whether we should lower it to 10 seconds or less

This seems as random as the current configured duration. Currently, we have set an upper bound, but it'll be good to get some heuristics around what's acceptable or not, and catch regressions if any. I've opened #248 to start that discussion.

Alright, let's continue there then.


Stability of the example/test data used by the cli.ingest.yml file

We are planning to add a test suite to our Python REST client library for DSpace.
It would be useful to be able to consistently run this test suite against an example instance with a known set of data in it. For this we would like to use the AIP or database dump provided for setting up test instances. However, we don’t want tests to start breaking just because future versions of this AIP might be released with different contents.
Is there a stability or versioning policy in place for the testing AIP data?

@dpk : The AIP data should likely NOT be used for tests, as it's extremely basic data (and not at all realistic).
For the User Interface e2e tests, we use the Entities Test Data (in db.entities.yml and cli.assetstore.yml) as our official test data.  See the build scripts in dspace-angular here: https://github.com/DSpace/dspace-angular/blob/main/.github/workflows/build.yml#L117-L123
That data set is therefore more "stable", because it's used by DSpace's own e2e tests.  That said, because it is test data, we may still chose to change it in the future at some point...so, depending on it is at your own risk.  We don't have any versioning policy on test data, nor any way to notify people if we change our test data.
Closing this as answered.  It's not a bug, just a question.


Minor Meta cleanup

Removed unnecessary function. Improved robustness of meta concat function to ensure consistency between labels across the meta objects.

Coverage increased (+0.3%) to 83.429% when pulling f187164a4c58fae8bae217958dfc5215c0d7ec9c on minor_meta into 16025e9a92df02dca851fa08633612a586e29434 on develop.


Blind Sight Stops Working Sometimes

I am playing a multiplayer game with a friend. We both have this mod, and only this mod, installed with the same settings.xml file. Our entire party has blind sight from one thing or another.
In this screenshot the character is a Moonlit Warlock trying to cast eldritch blast through a fog. It was working previously, then suddenly all of our characters can't see more than one tile through the fog. None of our range attacks or polearm attacks from 2 tiles work.

Edit: We did some more testing and it seems like it is tied to light effects such as faerie fire on the target. When the enemy has a light effect then it breaks the blind sight.

do you have a save?

It looks like vanilla isn't considering the polearm range. Can you confirm with another weapon?


added option for insecure http driver download

Added option for insecure http driver download in the docker-entrypoint.sh script. By passing --http-insecure to the container via an argument, the flag is forwarded to the falcoctl driver install command.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:
Adds a simple functionality to the driverbuilder script which has not been enabled before
Which issue(s) this PR fixes:
Feature has been available until the migration from script based driver build to falcoctl based one.

Fixes #3057
Special notes for your reviewer:
Simply adds a flag that is forwarded
Does this PR introduce a user-facing change?:
No, everythin works as before and the default of the flag is false anyway

added option for insecure http driver download

Welcome @toamto94! It looks like this is your first PR to falcosecurity/falco 🎉

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: toamto94
Once this PR has been reviewed and has the lgtm label, please assign leogr for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

docker/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign

Thanks for this PR! Can you add the same code to driver-loader-legacy and Falco images entrypoints?

Btw sorry, I completely forgot to add the option back in the 0.37.0 dev cycle!

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: toamto94
Once this PR has been reviewed and has the lgtm label, please ask for approval from fededp. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

docker/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP Code is added. First added a typo do the description of the docker command in the legacy script but this fixed as well now

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, toamto94
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

docker/OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.38.0
Might be ported into a 0.37.1 patch release, if needed.

/milestone 0.37.1


Image thumbnails are wanted

Images pasted into Logseq all have the same file name and without a thumbnail there is no way to know which is the image I want to use.

Yes ... thumbnails would be great but not only for images. All documents that a preview-able (if that is a correct word) should do so. Nice plugin ... 👍

There is a similar project issue, can watch it together
https://github.com/sosuisen/logseq-cardbox/issues/4


Fixing toc for ADAL.NET and MSAL.NET ref doc

the toc of the reference documentation for ADAL.NET and MSAL.NET shows internal namespaces that should not be presented

this PR aims at hiding them
cc: @dend

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

xml/_filter.xml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[$250] [Search v1] Settings - Delay in avatar highlight and blank Search page when opening from Inbox

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.3-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Go to staging.new.expensify.com/settings/preferences/priority-mode
Click Account settings
Go to Inbox
Go to Search

Expected Result:
In Step 2, avatar will be instantly highlighted when clicking on Account settings
In Step 4, Search page will open instantly
Actual Result:
In Step 2, avatar is not instantly highlighted when clicking on Account settings
In Step 4, Search page opens with blank page for a few seconds
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/98a5f17d-e2a1-417e-8081-f120ef64bae0
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~011ff0642a6c2f2946
Upwork Job ID:<PHONE_NUMBER>995654813
Last Price Increase: 2024-06-28

Issue OwnerCurrent Issue Owner: @ikevin127

@robertjchen  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsp

Proposal
Please re-state the problem that we are trying to solve in this issue.
In Step 2, avatar is not instantly highlighted when clicking on Account settings
In Step 4, Search page opens with blank page for a few seconds
What is the root cause of that problem?
The check to show loading isn't correct.
https://github.com/Expensify/App/blob/1d607acab9c47f2e0da4e8c85de5d90e2d47c11b/src/components/Search.tsx#L95
isLoadingOnyxValue(searchResultsMeta) is only true at the first time this key is loaded in Onyx. So after the first time we open the search page, the blank will appear when the search API is called.
About the delay bug, I think it maybe related here https://expensify.slack.com/archives/C01GTK53T8Q/p1719497873778469
What changes do you think we should make in order to solve the problem?
We should change to show the loading if the onyx value is loading or the search api is calling
const isLoadingItems = (!isOffline && (isLoadingOnyxValue(searchResultsMeta) || currentSearchResults?.search.isLoading)) || searchResults?.data === undefined;

https://github.com/Expensify/App/blob/1d607acab9c47f2e0da4e8c85de5d90e2d47c11b/src/components/Search.tsx#L95
What alternative solutions did you explore? (Optional)
NA

cc @luacmartins

I wonder if we can simplify the loading condition to just !isOffline && searchResults?.data === undefined. I think we should have data defined in all other instances when we got a response from the API so that would either display the empty state or the data

@luacmartins' suggestion is a definite improvement on the Search page loading logic.
Regarding the bottom tam navigator tab switch UI delay, it still happens and I checked the slack discussion about the recent introduction of React StrictMode and this does not seem to be the issue as the behaviour is also present on latest staging.

Not sure which direction we should move forward with this issue:

Go with nkdengineer's proposal which would only improve the Search page loading logic.
Keep looking for proposals for one that would fix the issue entirely including the bottom tab navigator tab switch delays.

cc @mountiny @robertjchen

Proposal
Please re-state the problem that we are trying to solve in this issue.
On the Expensify Website, the bottom tab navigator has a significant delay when switching tabs.
(a) The Account avatar is not highlighted immediately.
(b) The search tab renders content after an unwarranted delay.
What is the root cause of that problem?
(a) The navigation state is not being reported to child components promptly.
(b) The javascript thread seems to be blocked by callbacks from the Inbox tab.
What changes do you think we should make in order to solve the problem?
(a) Within the tab navigator component, the current route is being reported via the ActiveTabContext. We should useContext in our child components to get an immediate report and re-render the state. This will show the Account avatar highlighted immediately on tab change, rather than after a delay.
(b) Unmounting the inbox component on tab change should cancel pending callbacks. If we again use the ActiveTabContext to report the tab as changed, we can unblock the thread faster and remove the rendering delay.
What alternative solutions did you explore? (Optional)
(a) Use an alternative navigator or avoid navigation entirely? (painstaking and messy)
(b) Cache data in memory and only re-render based on diffs. (would required deeper investigation)

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: (https://www.upwork.com/freelancers/~0144a75be415af6251)

@Zakpak0 Thanks for the proposal.

(a) Within the tab navigator component, the current route is being reported via the ActiveTabContext. We should useContext in our child components to get an immediate report and re-render the state. This will show the Account avatar highlighted immediately on tab change, rather than after a delay.
(b) Unmounting the inbox component on tab change should cancel pending callbacks. If we again use the ActiveTabContext to report the tab as changed, we can unblock the thread faster and remove the rendering delay.

In order for me to be able to review a proposal and be able to test whether it works in fixing our issue I need a more detailed explanation of your solution, there are 2 ways you can go about this:

Create a test branch on your Expensify/App fork where you apply the changes you detailed in your solution, then post the link to your fork branch here in a comment, this way I can test whether your solution fixes the issue.
Note: Do not create a pull request, just a branch on your Expensify/App fork where you push the changes.

You can post a comment here detailing step by step, with code references if possible, where all the changes mentioned in your solution ([a.] & [b.]) should be applied in Expensify/App's codebase, this way I can apply the changes locally and verify whether your solution fixes the issue.

@ikevin127 No problem, here you are! Is it ok if I do a little bit of both?
https://github.com/Zakpak0/Expensify-App-Fork/tree/zakpak0/bugfix-issue-%2344587
(a)
src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar/index.website.tsx
Here I imported the useActiveRoute hook and use it to check the name of the current route.
Then we match that to the tab we want highlighted.
 /**
  * Use active route context in web because useNavigationState events aren't being fired immediately on tab change.
 */
    const activeRoute = useActiveRoute();

    const chatTabBrickRoad = getChatTabBrickRoad(activeWorkspaceID);

    const navigateToChats = useCallback(() => {
        if (currentTabName === SCREENS.HOME) {
            return;
        }
        const route = activeWorkspaceID ? (`/w/${activeWorkspaceID}/home` as Route) : ROUTES.HOME;
        Navigation.navigate(route);
    }, [activeWorkspaceID, currentTabName]);

    return (
        <View style={styles.bottomTabBarContainer}>
            <Tooltip text={translate('common.inbox')}>
                <PressableWithFeedback
                    onPress={navigateToChats}
                    role={CONST.ROLE.BUTTON}
                    accessibilityLabel={translate('common.inbox')}
                    wrapperStyle={styles.flex1}
                    style={styles.bottomTabBarItem}
                >
                    <View>
                        <Icon
                            src={Expensicons.Inbox}
                            fill={activeRoute?.name.includes('Report') ? theme.iconMenu : theme.icon}
                            width={variables.iconBottomBar}
                            height={variables.iconBottomBar}
                        />
                        {chatTabBrickRoad && (
                            <View style={styles.bottomTabStatusIndicator(chatTabBrickRoad === CONST.BRICK_ROAD_INDICATOR_STATUS.INFO ? theme.iconSuccessFill : theme.danger)} />
                        )}
                    </View>
                </PressableWithFeedback>
            </Tooltip>
            <Tooltip text={translate('common.search')}>
                <PressableWithFeedback
                    onPress={() => {
                        if (currentTabName === SCREENS.SEARCH.BOTTOM_TAB || currentTabName === SCREENS.SEARCH.CENTRAL_PANE) {
                            return;
                        }
                        interceptAnonymousUser(() => Navigation.navigate(ROUTES.SEARCH.getRoute(CONST.SEARCH.TAB.ALL)));
                    }}
                    role={CONST.ROLE.BUTTON}
                    accessibilityLabel={translate('common.search')}
                    wrapperStyle={styles.flex1}
                    style={styles.bottomTabBarItem}
                >
                    <View>
                        <Icon
                            src={Expensicons.MoneySearch}
                            fill={activeRoute?.name.includes('Search') ? theme.iconMenu : theme.icon}
                            width={variables.iconBottomBar}
                            height={variables.iconBottomBar}
                        />
                    </View>
                </PressableWithFeedback>
            </Tooltip>
            <BottomTabAvatar isSelected={activeRoute?.name.includes('Settings')} />
            <View style={[styles.flex1, styles.bottomTabBarItem]}>
                <BottomTabBarFloatingActionButton />
            </View>
        </View>
    );

(b)
src/pages/home/sidebar/SidebarScreen/index.tsx
Here I imported the useActiveRoute hook again and to check the name of the current route.
On the surface it seems that when the route is either "Report" or undefined, we are in the Inbox tab.
So I created a condition to return the component as null when those aren't the cases.
/**
 * In web, useActiveRoute reports tab change immediately.
 */
const route = useActiveRoute();

/**
 * Immediately unmount component on tab change to avoid blocking JS thread.
 */
if (route?.name !== 'Report' && !!route?.name) {
    return null;
}

@Zakpak0 Thanks for the update!
Currently the proposed solution for (a.) using useActiveRoute seems to work on web (wide layout devices) but if we switch to mWeb (mobile - narrow layouts) where the bottom tab navigation works differently, the solution would cause a regression if implemented for the BottomTabAvatar highlight because activeRoute?.name is undefined (see video below).

MacOS: Chrome

Regarding solution for (b.) -> I don't think those changes are necessary as the Search page part could be improved by the suggestion made in https://github.com/Expensify/App/issues/44587#issuecomment-2197152916.
Summary

The direction of using useActiveRoute seems good, but it has to work on mWeb as well. Checkout SCREENS.ts to potentially improve the solution by using navigation specific constants (includes('Settings') is not recommended) and take note of the currentTabName logic in order to better understand how that works.
For the second problem (b.) the suggestion made in #44587 (comment) should be enough, as the main focus should be the highlights delay.

@ikevin127 thank you for the feed back. I apprecaite the call out there.
I updated the branch with a bit of refactoring.
[src/libs/Navigation/AppNavigator/Navigators/BottomTabNavigator.tsx]
(https://github.com/Expensify/App/commit/1c05f2d53872403c135475def4d5b59586a3f3dd#diff-37de7bfd6ee84ea939b79f5393349fa93d8ad843d47cf321eddd0cc55ce17a3fR24-R41)
The previous navigation state selector was limited in the screens it was selecting.
After deeper investigation I noticed it only implemented a hand.
I followed the styling
const activeRoute = useNavigationState<RootStackParamList, NavigationPartialRoute<keyof BottomTabScreensParamList> | undefined>((state) => {
        if (!state) {
            return undefined;
        }
        let route: NavigationPartialRoute<keyof BottomTabScreensParamList> | undefined;
        for (let selector of [getTopmostBottomTabRoute, getTopmostCentralPaneRoute]) {
            const selectedRoute = selector(state);
            if (isBottomTabName(selectedRoute?.name)) {
                route = selectedRoute as NavigationPartialRoute<keyof BottomTabScreensParamList>;
            }
        }

        return route;
    });
}

@ikevin127 thank you for the feed back. I apprecaite the call out there.
I updated the branch with a bit of refactoring.
src/libs/Navigation/AppNavigator/Navigators/BottomTabNavigator.tsx
The previous navigation state selector was limited in the screens it was selecting.
I followed the styling from the previous implementation and used the SCREENS.ts constants to define the routes.
const activeRoute = useNavigationState<RootStackParamList, NavigationPartialRoute<keyof BottomTabScreensParamList> | undefined>((state) => {
        if (!state) {
            return undefined;
        }
        let route: NavigationPartialRoute<keyof BottomTabScreensParamList> | undefined;
        for (let selector of [getTopmostBottomTabRoute, getTopmostCentralPaneRoute]) {
            const selectedRoute = selector(state);
            if (isBottomTabName(selectedRoute?.name)) {
                route = selectedRoute as NavigationPartialRoute<keyof BottomTabScreensParamList>;
            }
        }

        return route;
    });
}

src/libs/NavigationUtils.ts
I also created helper functions to determine whether the selected tab falls within whichever category.
const SETTINGS_SCREENS = Object.values(flattenObject(SCREENS.SETTINGS));
const SEARCH_SCREENS = Object.values(flattenObject(SCREENS.SEARCH));
const HOME_SCREENS = [SCREENS.HOME, SCREENS.REPORT];
const BOTTOM_TAB_SCREEN_NAMES = new Set([...SETTINGS_SCREENS, ...SEARCH_SCREENS, ...HOME_SCREENS]);

const SETTINGS_TAB_SCREEN_NAMES = new Set(SETTINGS_SCREENS);

const SEARCH_TAB_SCREEN_NAMES = new Set(SEARCH_SCREENS);

const HOME_SCREEN_NAMES = new Set(HOME_SCREENS);

function isBottomTabName(screen: string | undefined): screen is BottomTabScreenName {
    if (!screen) {
        return false;
    }
    return BOTTOM_TAB_SCREEN_NAMES.has(screen as any);
}

function isSettingTabName(screen: string | undefined): screen is any {
    if (!screen) {
        return false;
    }
    return SETTINGS_TAB_SCREEN_NAMES.has(screen as any);
}

function isSearchTabName(screen: string | undefined): screen is (typeof SEARCH_SCREENS)[0] {
    if (!screen) {
        return false;
    }
    return SEARCH_TAB_SCREEN_NAMES.has(screen as (typeof SEARCH_SCREENS)[0]);
}

function isHomeTabName(screen: string | undefined): screen is (typeof HOME_SCREENS)[0] {
    if (!screen) {
        return false;
    }
    return HOME_SCREEN_NAMES.has(screen as (typeof HOME_SCREENS)[0]);

src/libs/Navigation/types.ts
Corresponding types were exported to match the style of the previous implimentation.
src/hooks/useActiveBottomTabRoute.ts
src/libs/Navigation/AppNavigator/Navigators/ActiveBottomTabRouteContext.ts
I updated the name of useActiveRoute to useActiveBottomTabRoute to make it more identifiable.
It only ever relayed information about the bottom tabs and I didn't want to be misleading.
src/components/Search/index.tsx
Lastly I implemented the code from @luacmartins suggestion and removed the code from my implementation.

Thanks @Zakpak0. @ikevin127 could you please test the solution above when you get a chance?

@Zakpak0 Thanks for the follow-up! I reviewed your changes and I confirm that your changes fix the highlight delay issue on both wide and narrow layout devices as can be observed below.

Before
After

Notes on the code

addition of new flattenObject function which is not needed as we already have it in @src/languages/translations
noticed some typing errors mainly in NavigationUtils.ts
minor naming improvements required

I took the liberty of correcting all of these, below is the diff which you should apply to your current test branch:

DIFF

diff --git a/src/libs/Navigation/AppNavigator/Navigators/BottomTabNavigator.tsx b/src/libs/Navigation/AppNavigator/Navigators/BottomTabNavigator.tsx
index 24d8afca10..372c1ce478 100644
--- a/src/libs/Navigation/AppNavigator/Navigators/BottomTabNavigator.tsx
+++ b/src/libs/Navigation/AppNavigator/Navigators/BottomTabNavigator.tsx
@@ -26,7 +26,7 @@ function BottomTabNavigator() {
             return undefined;
         }
         let route: NavigationPartialRoute<keyof BottomTabScreensParamList> | undefined;
-        for (let selector of [getTopmostBottomTabRoute, getTopmostCentralPaneRoute]) {
+        for (const selector of [getTopmostBottomTabRoute, getTopmostCentralPaneRoute]) {
             const selectedRoute = selector(state);
             if (isBottomTabName(selectedRoute?.name)) {
                 route = selectedRoute as NavigationPartialRoute<keyof BottomTabScreensParamList>;
diff --git a/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar/index.website.tsx b/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar/index.website.tsx
index 995be14834..b27c5bc9df 100644
--- a/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar/index.website.tsx
+++ b/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar/index.website.tsx
@@ -3,11 +3,12 @@ import React, {useCallback, useEffect} from 'react';
 import {View} from 'react-native';
 import type {OnyxEntry} from 'react-native-onyx';
 import {withOnyx} from 'react-native-onyx';
+import type {TupleToUnion} from 'type-fest';
 import Icon from '@components/Icon';
 import * as Expensicons from '@components/Icon/Expensicons';
 import {PressableWithFeedback} from '@components/Pressable';
 import Tooltip from '@components/Tooltip';
-import useActiveRoute from '@hooks/useActiveBottomTabRoute';
+import useActiveBottomTabRoute from '@hooks/useActiveBottomTabRoute';
 import useActiveWorkspace from '@hooks/useActiveWorkspace';
 import useLocalize from '@hooks/useLocalize';
 import useTheme from '@hooks/useTheme';
@@ -41,6 +42,7 @@ function BottomTabBar({isLoadingApp = false}: PurposeForUsingExpensifyModalProps
     const styles = useThemeStyles();
     const {translate} = useLocalize();
     const navigation = useNavigation();
+    const HOME_SCREENS = [SCREENS.HOME, SCREENS.REPORT];
     const {activeWorkspaceID: contextActiveWorkspaceID} = useActiveWorkspace();
     const activeWorkspaceID = sessionStorage.getItem(CONST.SESSION_STORAGE_KEYS.ACTIVE_WORKSPACE_ID) ?? contextActiveWorkspaceID;

@@ -70,10 +72,7 @@ function BottomTabBar({isLoadingApp = false}: PurposeForUsingExpensifyModalProps
         return topmostBottomTabRoute?.name ?? SCREENS.HOME;
     });

-    /**
-     * Use active route context in web because useNavigationState events aren't being fired immediately on tab change.
-     */
-    const activeRoute = useActiveRoute();
+    const activeBottomTabRoute = useActiveBottomTabRoute();
     const chatTabBrickRoad = getChatTabBrickRoad(activeWorkspaceID);

     const navigateToChats = useCallback(() => {
@@ -97,7 +96,7 @@ function BottomTabBar({isLoadingApp = false}: PurposeForUsingExpensifyModalProps
                     <View>
                         <Icon
                             src={Expensicons.Inbox}
-                            fill={isHomeTabName(activeRoute?.name) ? theme.iconMenu : theme.icon}
+                            fill={isHomeTabName(activeBottomTabRoute?.name as TupleToUnion<typeof HOME_SCREENS>) ? theme.iconMenu : theme.icon}
                             width={variables.iconBottomBar}
                             height={variables.iconBottomBar}
                         />
@@ -110,7 +109,7 @@ function BottomTabBar({isLoadingApp = false}: PurposeForUsingExpensifyModalProps
             <Tooltip text={translate('common.search')}>
                 <PressableWithFeedback
                     onPress={() => {
-                        if (isSearchTabName(activeRoute?.name)) {
+                        if (isSearchTabName(activeBottomTabRoute?.name)) {
                             return;
                         }
                         interceptAnonymousUser(() => Navigation.navigate(ROUTES.SEARCH.getRoute(CONST.SEARCH.TAB.ALL)));
@@ -123,14 +122,14 @@ function BottomTabBar({isLoadingApp = false}: PurposeForUsingExpensifyModalProps
                     <View>
                         <Icon
                             src={Expensicons.MoneySearch}
-                            fill={isSearchTabName(activeRoute?.name) ? theme.iconMenu : theme.icon}
+                            fill={isSearchTabName(activeBottomTabRoute?.name) ? theme.iconMenu : theme.icon}
                             width={variables.iconBottomBar}
                             height={variables.iconBottomBar}
                         />
                     </View>
                 </PressableWithFeedback>
             </Tooltip>
-            <BottomTabAvatar isSelected={isSettingTabName(activeRoute?.name)} />
+            <BottomTabAvatar isSelected={isSettingTabName(activeBottomTabRoute?.name)} />
             <View style={[styles.flex1, styles.bottomTabBarItem]}>
                 <BottomTabBarFloatingActionButton />
             </View>
diff --git a/src/libs/NavigationUtils.ts b/src/libs/NavigationUtils.ts
index 8a9e2f9bab..34e9df9546 100644
--- a/src/libs/NavigationUtils.ts
+++ b/src/libs/NavigationUtils.ts
@@ -1,8 +1,9 @@
 import cloneDeep from 'lodash/cloneDeep';
+import type {TupleToUnion} from 'type-fest';
+import {flattenObject} from '@src/languages/translations';
 import SCREENS from '@src/SCREENS';
-import {flattenObject} from './flattenObject';
 import getTopmostBottomTabRoute from './Navigation/getTopmostBottomTabRoute';
-import type {BottomTabScreenName, CentralPaneName, RootStackParamList, State} from './Navigation/types';
+import type {CentralPaneName, RootStackParamList, State} from './Navigation/types';

 const CENTRAL_PANE_SCREEN_NAMES = new Set([
     SCREENS.SETTINGS.WORKSPACES,
@@ -46,32 +47,32 @@ const SEARCH_TAB_SCREEN_NAMES = new Set(SEARCH_SCREENS);

 const HOME_SCREEN_NAMES = new Set(HOME_SCREENS);

-function isBottomTabName(screen: string | undefined): screen is BottomTabScreenName {
+function isBottomTabName(screen: TupleToUnion<typeof SETTINGS_SCREENS> | undefined) {
     if (!screen) {
         return false;
     }
-    return BOTTOM_TAB_SCREEN_NAMES.has(screen as any);
+    return BOTTOM_TAB_SCREEN_NAMES.has(screen);
 }

-function isSettingTabName(screen: string | undefined): screen is any {
+function isSettingTabName(screen: TupleToUnion<typeof SETTINGS_SCREENS> | undefined) {
     if (!screen) {
         return false;
     }
-    return SETTINGS_TAB_SCREEN_NAMES.has(screen as any);
+    return SETTINGS_TAB_SCREEN_NAMES.has(screen);
 }

-function isSearchTabName(screen: string | undefined): screen is (typeof SEARCH_SCREENS)[0] {
+function isSearchTabName(screen: TupleToUnion<typeof SEARCH_SCREENS> | undefined) {
     if (!screen) {
         return false;
     }
-    return SEARCH_TAB_SCREEN_NAMES.has(screen as (typeof SEARCH_SCREENS)[0]);
+    return SEARCH_TAB_SCREEN_NAMES.has(screen);
 }

-function isHomeTabName(screen: string | undefined): screen is (typeof HOME_SCREENS)[0] {
+function isHomeTabName(screen: TupleToUnion<typeof HOME_SCREENS> | undefined) {
     if (!screen) {
         return false;
     }
-    return HOME_SCREEN_NAMES.has(screen as (typeof HOME_SCREENS)[0]);
+    return HOME_SCREEN_NAMES.has(screen);
 }

 export {isCentralPaneName, isBottomTabName, isSearchTabName, isSettingTabName, isHomeTabName, removePolicyIDParamFromState};
diff --git a/src/pages/Search/SearchPageBottomTab.tsx b/src/pages/Search/SearchPageBottomTab.tsx
index 58a8c54c0c..ad95824fa6 100644
--- a/src/pages/Search/SearchPageBottomTab.tsx
+++ b/src/pages/Search/SearchPageBottomTab.tsx
@@ -27,7 +27,7 @@ const defaultSearchProps = {
 function SearchPageBottomTab() {
     const {translate} = useLocalize();
     const {isSmallScreenWidth} = useWindowDimensions();
-    const activeRoute = useActiveBottomTabRoute();
+    const activeBottomTabRoute = useActiveBottomTabRoute();
     const styles = useThemeStyles();

     const {
@@ -36,11 +36,11 @@ function SearchPageBottomTab() {
         sortBy,
         sortOrder,
     } = useMemo(() => {
-        if (activeRoute?.name !== SCREENS.SEARCH.CENTRAL_PANE || !activeRoute.params) {
+        if (activeBottomTabRoute?.name !== SCREENS.SEARCH.CENTRAL_PANE || !activeBottomTabRoute.params) {
             return defaultSearchProps;
         }
-        return {...defaultSearchProps, ...activeRoute.params} as SearchPageProps['route']['params'];
-    }, [activeRoute]);
+        return {...defaultSearchProps, ...activeBottomTabRoute.params} as SearchPageProps['route']['params'];
+    }, [activeBottomTabRoute]);

     const query = rawQuery as SearchQuery;

diff --git a/src/pages/settings/InitialSettingsPage.tsx b/src/pages/settings/InitialSettingsPage.tsx
index d3b9e28fe6..ef781d7813 100755
--- a/src/pages/settings/InitialSettingsPage.tsx
+++ b/src/pages/settings/InitialSettingsPage.tsx
@@ -1,11 +1,11 @@
 import {useRoute} from '@react-navigation/native';
 import React, {useCallback, useContext, useEffect, useLayoutEffect, useMemo, useRef, useState} from 'react';
+// eslint-disable-next-line no-restricted-imports
 import type {GestureResponderEvent, ScrollView as RNScrollView, ScrollViewProps, StyleProp, ViewStyle} from 'react-native';
 import {NativeModules, View} from 'react-native';
 import type {OnyxCollection, OnyxEntry} from 'react-native-onyx';
 import {withOnyx} from 'react-native-onyx';
 import type {ValueOf} from 'type-fest';
-// eslint-disable-next-line no-restricted-imports
 import AvatarWithImagePicker from '@components/AvatarWithImagePicker';
 import ConfirmModal from '@components/ConfirmModal';
 import CurrentUserPersonalDetailsSkeletonView from '@components/CurrentUserPersonalDetailsSkeletonView';
@@ -105,7 +105,7 @@ function InitialSettingsPage({session, userWallet, bankAccountList, fundList, wa
     const waitForNavigate = useWaitForNavigation();
     const popoverAnchor = useRef(null);
     const {translate, formatPhoneNumber} = useLocalize();
-    const activeRoute = useActiveBottomTabRoute();
+    const activeBottomTabRoute = useActiveBottomTabRoute();
     const emojiCode = currentUserPersonalDetails?.status?.emojiCode ?? '';

     const [shouldShowSignoutConfirmModal, setShouldShowSignoutConfirmModal] = useState(false);
@@ -332,7 +332,11 @@ function InitialSettingsPage({session, userWallet, bankAccountList, fundList, wa
                                 hoverAndPressStyle={styles.hoveredComponentBG}
                                 shouldBlockSelection={!!item.link}
                                 onSecondaryInteraction={item.link ? (event) => openPopover(item.link, event) : undefined}
-                                focused={!!activeRoute && !!item.routeName && !!(activeRoute.name.toLowerCase().replaceAll('_', '') === item.routeName.toLowerCase().replaceAll('/', ''))}
+                                focused={
+                                    !!activeBottomTabRoute &&
+                                    !!item.routeName &&
+                                    !!(activeBottomTabRoute.name.toLowerCase().replaceAll('_', '') === item.routeName.toLowerCase().replaceAll('/', ''))
+                                }
                                 isPaneMenu
                                 iconRight={item.iconRight}
                                 shouldShowRightIcon={item.shouldShowRightIcon}
@@ -352,7 +356,7 @@ function InitialSettingsPage({session, userWallet, bankAccountList, fundList, wa
             userWallet?.currentBalance,
             isExecuting,
             singleExecution,
-            activeRoute,
+            activeBottomTabRoute,
             waitForNavigate,
         ],
     );

What's next ?

Zakpak0 Should should apply the DIFF changes to the test branch then update their proposal (by edit) to reflect the latest changes in both RCA and solution with all relevant details. Let us know when the proposal was updated.
Once (1.) is completed I will perform a final review and if all good -> will move on with assignment.
(Optional) @Expensify/design to chime in regarding the blank Search page UI and possibly propose some sort of loader, I was thinking skeleton could look good there, since even with @luacmartins's suggested change applied from #44587 (comment), sometimes it can still take a bit until the list is rendered -> which shows the blank page (see below).

MacOS: Chrome
https://github.com/Expensify/App/assets/56457735/459ce10a-df20-4a2b-ab8b-85ec521f701c

Proposal
Updated
@ikevin127 thank you for the feedback again!

@Zakpak0's updated proposal looks good to me. The root cause was identified and the updated solution fixes the issue as per the expected result. Some before / after of the solution can be seen in https://github.com/Expensify/App/issues/44587#issuecomment-2207196137.
@Zakpak0 The raw proposal template suggest that it's not allowed to post diffs in proposals, that's why I advised to use the diff and apply it to your test branch, which you are allowed to showcase in a proposal.

I think the design part (if needed) and ither details can be handled during PR.
🎀👀🎀 C+ reviewed

Proposal
Updated
@ikevin127 thank you again for the callout!!!

Regarding the blank search page, curious from @luacmartins why we aren't using our skeleton loaders there? I could have sworn we used to be doing that, in fact we even went as far as updating the skeleton loader for mobile to make it match the shape of the mobile rows. Any idea where they went?!

It seems like we do show the loading skeleton briefly but then it disappears and the page goes blank before loading the content. I wonder if the following is happening:

No data locally
Loading skeleton is shown
API request is sent
API request returns the data
Data is merged locally and loading skeleton disappears
List is large so the device takes a while to render the content, in the meantime page appears blank

If that's the issue then we have a performance issue and should probably tackle that as a separate issue.

Tackling that separately works for me.

Hey, the PR for this can be ready for review today at EOD for me.

Update
Pending receiving the job offer on Upwork.

@Zakpak0 Don't worry too much about the Upwork offer / contract, rest assured -> you will get paid.
Being your first contract, it is not automated yet, as the bot mentioned in https://github.com/Expensify/App/issues/44587#issuecomment-2209151897 - that will change with your 2nd assignment.
You should move forward with opening the PR, the sooner the better because the way things will work is:

You open PR, completing your PR author checklist.
I review, test, complete my PR reviewer checklist then Approve.
Once I Approve, an Expensify engineer will double-check and if all good, it will get merged.
Once merged, the QA team will do some testing and after that the PR will be deployed to Staging (can take 1-2 days).
Once deployed to staging, some more testing will be done, after which it will be deployed to Production.
Once deployed to Production, the GH automation should add a [HOLD for payment X] to the issue's title - which is always 7 days after the PR was deployed to production.

If 7 days pass without any regressions, that's when your payment will be issued.
Being your first job, the contract will have to be handled manually by the BZ team member once the 7-day regression period is over.

@ikevin127 Oh got it! Thanks. I'll send the PR in then. Thank you so much for clarifying.

@luacmartins @robertjchen Can you please add the Bug label to assign somebody for payments ?
Note: I don't think we need a BZ Checklist here since the issue wasn't caused by any recent PR, but instead it's more of a performance improvement task.

@Zakpak0 - can you link your Upwork profile here so that I can send along the offer?

Payment summary:

Contributor: @Zakpak0 $250
Reviewer: @ikevin127 $250 (paid in Upwork)

@Zakpak0 - can you link your Upwork profile here so that I can send along the offer?

@Ischurr sure https://www.upwork.com/freelancers/~0144a75be415af6251

@lschurr 👋 Before closing here, there's one more payment due on 30th coming from a follow-up polishing PR https://github.com/Expensify/App/pull/45663 which I reviewed. More context on the payment due date here and confirmation that it should be handled in this issue from Carlos in https://github.com/Expensify/App/pull/45663#issuecomment-2249241153.
⚠ Looks like automation failed -> reason for which the 2nd payment due date wasn't added to this issue automatically.

@Zakpak0 - sent offer here in Upwork

I'll change the date in the title for the other payment that's due on the 30th. That PR was created by @WojtekBoman and reviewed by @ikevin127 - so we just need payment for you, right Kevin?

@lschurr Yes, only for me as reviewer since the author is from SWM. Thank you!

cc @lschurr

@ikevin127 - I added a bonus rather than sending a new offer on this one.
Additional $250 paid in Upwork for this PR.


add blockscape

Description
All previous genesis validators should name their PRs "Update {validator_alias}.toml for tesntet-15" and provide links to previous PRs merged.
If this is an UPDATE for a previous genesis validator
Checks are made against your net_address. If this has changed since the previous testnet, make sure you provide links of previous prs merged from your previous git username.
Thanks in advance!
Checklist before merging

[*] Only one toml is added in this PR
[*] The file being added is indeed a .toml file
[*] The toml being added is to the correct folder, and only to the correct folder
[*] The eth_hot_key and eth_cold_key are present
[*] The email, discord, elements telegram, and twitter fields are present and valid

This validator was not recognised as a previous validator and has update in the title. Please read the description.


Flacs without album art crash spotdl

System OS
Windows
Python Version
3.11 (CPython)
Install Source
pip / PyPi
Install version / commit hash
4.2.10
Expected Behavior vs Actual Behavior
Expected: spotdl should scan flacs without image metadata
Steps to reproduce - Ensure to include actual links!

Have an existing downloaded song without an image
Run a download command in that folder with --scan-for-songs

Traceback
│ y:448 in get_file_metadata                                                                       │
│                                                                                │
│   447 │   │   │   if path.suffix == ".flac":                                                     │
│ ❱ 448 │   │   │   │   song_meta["album_art"] = audio_file.pictures[0].data                       │
│   449 │   │   │   │   continue                                                                   │
╰─────────────────────────────────────────────────────────────────────────────────────────────────

Other details
I have a fix for this already

will be included in next release of spotDL. (4.2.11 or 4.3.0)
In the interim install from dev
pip install --force -U https://codeload.github.com/spotDL/spotify-downloader/zip/dev

@joeyballentine can you please provide song examples so I can test this?


RDO_USD_CACHED_RESOLVER_ENABLE_SHOTGRID

Add env car to enable SG query, has to be explicitely set, for now only during buildLayerStack

Hey,
really cool that you are working on a SG integration. Would you be interested in porting this back into the "main" repo as a new variation? Or is it too Rodeo specific?

Hi!
We're still in exploration phase with the asset resolver stuff, but it
would clearly be interesting to share our stuff.
Thanks for the great work by the way, it's really giving us a head start !
On Wed, Nov 29, 2023 at 7:05 AM LucaScheller @.***>
wrote:

Hey,
really cool that you are working on a SG integration. Would you be
interested in porting this back into the "main" repo as a new variation? Or
is it too Rodeo specific?
—
Reply to this email directly, view it on GitHub
https://github.com/rodeofx/VFX-UsdAssetResolver/pull/8#issuecomment-1831769051,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB4KNKYSISGACVA73GUBKQTYG4QJJAVCNFSM6AAAAAA76SNX2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZRG43DSMBVGE
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

Cool, looking forward to seeing how this develops!
Happy to help :)


Hanging on "Cleaning Browser project" when executing "$ionic cordova build browser --prod"

Short description of the problem:
When running $ ionic cordova build browser --prod the build seems to be succesfull but cleaning step is hanging forever. Node process consumes 99% CPU.
May be related to https://github.com/ionic-team/ionic-app-scripts/issues/1064
What behavior are you expecting?
The cleanup stage should finish in reasonable time (less than a minute?)
Steps to reproduce:
$ ionic cordova build browser --prod
Running app-scripts build: --prod --iscordovaserve --externalIpRequired --nobrowser
...
> cordova build browser
✔ Running command - done!
Running command: /Users/astec/debtstracker/ionic-apps/public/platforms/browser/cordova/build
Cleaning Browser project

Which @ionic/app-scripts version are you using?
@ionic/app-scripts: 1.3.11
See more details about my environment at https://github.com/ionic-team/ionic-app-scripts/issues/1064
Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)
$ ionic cordova build browser --prod
Running app-scripts build: --prod --iscordovaserve --externalIpRequired --nobrowser

[23:56:40]  build prod started ...
[23:56:40]  clean started ...
[23:56:40]  clean finished in 2 ms
[23:56:40]  copy started ...
[23:56:40]  ngc started ...
[23:57:07]  ngc finished in 27.36 s
[23:57:07]  preprocess started ...
[23:57:07]  deeplinks started ...
[23:57:12]  deeplinks finished in 5.10 s
[23:57:12]  optimization started ...
[23:57:13]  copy finished in 33.27 s
[23:58:09]  optimization finished in 56.67 s
[23:58:09]  preprocess finished in 61.78 s
[23:58:09]  webpack started ...
[23:58:47]  webpack finished in 37.94 s
[23:58:47]  sass started ...
[23:58:47]  uglifyjs started ...
[23:58:52]  sass finished in 4.85 s
[23:58:52]  cleancss started ...
[23:58:55]  cleancss finished in 3.09 s
[23:59:49]  uglifyjs finished in 62.31 s
[23:59:49]  postprocess started ...
[23:59:49]  postprocess finished in 34 ms
[23:59:49]  lint started ...
[23:59:49]  build prod finished in 189.50 s
> cordova build browser
✔ Running command - done!
Running command: /Users/astec/debtstracker/ionic-apps/public/platforms/browser/cordova/build
Cleaning Browser project
<-- HANGS HERE

Can you add --verbose to that command and run it again?
Can you try npm run ionic:build --prod --verbose - does this also take as long?
What is your ionic info output?

We're experiencing a similar behavior,
ionic cordova build browser --prod --release --no-interactive takes more than twice as long as npm run ionic:build --prod --verbose.  The build hangs for about 3 minutes at  Cleaning Browser project, running with verbose provides no additional output at the offending location.

Do you really need to use ionic cordova build browser at all?
ionic build also builds a web version, but without the Cordova browser platform. It should be much faster.

It appears I don't need to :man_facepalming:.  That solves the problem for me, thanks!

The command is new since Ionic CLI 3.7 - so no wonder it is not as known yet ;)

We have the same issue but Cordova is required. The Cleaning Browser project section is taking 10 to 15 minutes.

The "Cleaning Browser project" is not directly part of Ionic but probably done by Cordova CLI. Best location to report this would be http://issues.cordova.io/ then. (Note that your issue there has higher chance of being handled if it doesn't include Ionic and can also be reproduced with a plain Cordova app - maybe try to reproduce it with a new Cordova project and cordova build ... first.)


add carriage return to inspect --format

[root@bootp-73-3-165 ~]# buildah inspect -t container  -f "{{ .Container }}" nginx-working-container
nginx-working-container[root@bootp-73-3-165 ~]#

@gouyang this is what I am seeing. I am on Fedora 26.
➜  buildah git:(master) ✗ buildah version
Version:       0.11
Go Version:    go1.8.5
Image Spec:    1.0.0
Runtime Spec:  1.0.0
Git Commit:    49095a83
Built:         Thu Feb  1 11:15:04 2018
OS/Arch:       linux/amd64
➜  buildah git:(master) ✗ sudo buildah inspect -t container -f "{{.Container}} {{.Type}}" alpine-working-container
alpine-working-container buildah 0.0.1%

@gouyang ignore what I said, I guess it was something to do with me shell. Working on a fix.

I am closing this as #442 was merged.
Thanks @umohnani8 for working on this.
@gouyang I am closing this ticket but feel free to reopen it in case we missed something. Thanks.


Team 6 Sprint 1 Final - Minimap Addition

Added files/classes
MinimapComponent

Render component that, when attached to the game's terrain entity, will visualise the game terrain to the bottom right corner of the screen
Attached to the terrain entity alongside the TerrainComponent in AtlantisGameArea

Modified files/classes

AtlantisGameArea

Feature itself looks good, and appears to be well documented. Maybe one small thing which could be changed is removing commented out print lines in the CameraInputComponent. Also, it may be useful to give more descriptive names to constants in worldToTile() function.


Source some average fcs file sizes

    can we source some average `fcs` file sizes? I can post a message in the slack.

Originally posted by @avahoffman in https://github.com/fhdsl/NIH_Data_Sharing/pull/34#discussion_r1012397370
A response from Slack:

In our lab it varies by project but usually 1-50 MB each, with the averages ranging from 2 - 20MB

@avahoffman I think we might just want to put 1-50 MB in the table.


⚠ Jenkins Plugins Artifactory has degraded performance

In 7338e02, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1071 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 08e9e72 after 38 minutes.


Using Variadic Tuple Types in rxjs API

Feature Request
Currently rxjs uses overloading and only supports tuple type variables of a specific length.
We can use Variadic Tuple Types of ts 4.0 to solve this problem.

Core team already awares and discusses internally about possible timeline to make changes.


Create a separate deployment for the develop branch

Currently, changes can't be integration tested until they hit production, however, if we had a separate heroku app with its own add-ons (MongoDB & New Relic) then we could build that automatically from our develop branch for pre-production integration testing that won't affect production stability and data.

This has been complete and can now be found on the following server:
https://staging-thebroonline.herokuapp.com/
As mentioned previously, this app updates automatically when the develop branch changes.


added Basic Auth authentication method

I needed Basic Auth authentication method for a project.
Feel free to revise and merge it if you think it can be a cool addition to the module.

Thank you for sharing this code!  I also need basic authentication for my application (as it's an enterprise app that has other applications pulling information from processwire).  This tied in nicely with LDAP https://modules.processwire.com/modules/ldap-sign-in/ and I was able to accomplish what I needed.


10.0-ir_attachment_url-image_resize_fix

When the "image_resize_image" function was called, they received the error "binascii.Error: decoding with base64 codec failed (Error: Incorrect padding)", since the value of the binary field is the URL, not the base_64 string.

Still
ir_attachment_url/models/ir_http.py:84:13: F841 local variable 'last_update' is assigned to but never used


Fix the url in the titles and the files url

Currently in the title of the functions, methods, types, etc, even in thepackages list, the links are broken.
For example, you get titles like:
## type [ConfigSCM](/src/target/configuration.go?s=4077:4383#L107)

What this PR does is that it uses the URLForSrc to rewrite the package name into a url using almost the same regex as the gddo project that handles godoc.org.
In the end the above title looks like:
## type [ConfigSCM](https://github.com/beamly/go-gocd/tree/master/gocd/configuration.go?s=4077:4383#L107)

And a go package link that used to look like:
[resource_stages.go](/src/github.com/beamly/go-gocd/gocd/resource_stages.go)

Now looks like:
[resource_stages.go](https://github.com/beamly/go-gocd/tree/master/gocd/resource_stages.go)

Note that I only added the support for github and bitbucket but I think we can add later on the support for custom package url transformation regex patterns.
I guess it's also related to what was asked in #7 but I'm not 100% sure that what was meant by link generation is not implemented.
Anyway, let me know what you think about it. Happy to help on improving this.
Thanks
Joseph

Hi,
I just refactored my code to:

add unit tests
support builtin packages
support github.com. bitbucket.com (as it was in the 1st version)
add a default support for all other websites (specific will be easy to add)

I also fixed an issue with the current template that adds an empty trailing space at the end of the list of package files.
And lastly I updated the examples. You can have a look at what that generates here for example:
https://github.com/aerostitch/godoc2md/tree/links_issue/examples/build#index
https://github.com/aerostitch/godoc2md/tree/links_issue/examples/fs#index
https://github.com/aerostitch/godoc2md/tree/links_issue/examples/martini#index
https://github.com/aerostitch/godoc2md/tree/links_issue/examples/sessions#index
Let me know what you think.
Thanks
Joseph

Thanks for doing this. I run some hacky sed commands to fix the URLs when I run godoc2md.
I ran into the problem of needing examples today and I didn't see that this PR existed, so I implemented it myself and opened #21. Now, I'm seeing this PR and I'm sorry about the collision.
FWIW, I initially implemented it very similarly to you, with an example_md function that spit out the markdown, but I realized that wouldn't work well if a user supplied an alternate template. My solution was to create an examples template function that outputs a slice of matching examples with formatted code and let the template decide how it's displayed.
type example struct {
	Name   string
	Doc    string
	Code   string
	Output string
}

func examplesFunc(info *godoc.PageInfo, name string) []*example {
	//...
}

I defined a nested examples_md template inside the main template and used it where needed.
var pkgTemplate = `{{define "examples_md"}}{{range .}}
#### Example{{example_suffix .Name}}
{{comment_md .Doc}}
Code:
{{pre .Code}}{{if .Output}}
Output:
{{output .Output}}
{{end}}
{{end}}{{end}}
...
{{range .Funcs}}{{$name_html := html .Name}}### func [{{$name_html}}]({{posLink_url $ .Decl}})
{{node $ .Decl | pre}}
{{comment_md .Doc}}
{{template "examples_md" (examples $ .Name)}}{{end}}
...
`


Issue221

resolving issue #221

still working on this, an update is coming soon

hi @jeromekelleher, i think this is ready to be merged in to the master, all tests and validation are passing

Something's gone a bit weird here @shajoezhu --- can you rebase this off upstream/master please?

sorry @jeromekelleher , had some problem with merging, and did something wrong, i have created an separate branch regarding to issue #221, and submitted a new pull request #264.


Dataset creation to use with unsloth fine tuning

I have single json file with following format.

{"Instruction": "Explain the attention mechanism in transformer models.", "Input": ""A transformer model with an attention mechanism processes the input sequence [CLS, 'This', 'is', 'a', 'test'], where CLS represents the classification token."", "Output": ""The attention mechanism allows the transformer model to focus on specific parts of the input sequence that are relevant for making predictions. In this case, the model may give more weight to the word 'test' due to its potential relationship with the task."\n\n"},...

How do I fine tune using this format ? I do not want to use hugging face dataset.

Any reason why you didn't want to use datasets of huggingface? because many function in the example notebook uses datasets function of .map to transform the data.
You can load your model from json btw to datasets of huggingface :

dataset = Dataset.load_from_json("<your json path>")
```


Problems installing

This is the first time I'm using Vagrant. I'm following the instructions; I downloaded VirtualBox and Vagrant. I copied and made the changes to the example files. When I try to run vagrant up I get the following error message:
There was an error while executing `VBoxManage`, a CLI used by Vagrant
for controlling VirtualBox. The command and stderr is shown below.

Command: ["clonevm", "24ec6ddb-7c6d-47be-ad3b-c3cfb5213756", "--register", "--name", "temp_clone_1456361698378_21314"]

Stderr: VBoxManage.exe: error: Could not find a registered machine with UUID {24ec6ddb-7c6d-47be-ad3b-c3cfb5213756}
VBoxManage.exe: error: Details: code VBOX_E_OBJECT_NOT_FOUND (0x80bb0001), component VirtualBox, interface IVirtualBox, callee IUnknow
VBoxManage.exe: error: Context: "FindMachine(Bstr(pszSrcName).raw(), srcMachine.asOutParam())" at line 434 of file VBoxManageMisc.cpp

I know it's not an issue with VirtualBox because I'm able to run that command from another vagrant file.
Any help would be really appreciated.
Thanx.

Any chance you're computer has an i3 CPU?

https://github.com/geerlingguy/drupal-vm/issues/439
https://github.com/geerlingguy/drupal-vm/commit/532ccf77a2354ae249c00c4c9b87434e82809623

Thanx for the quick reply. After a long while of looking around I finally got it to work.
I tried to install it yesterday and it went through successfully. However, at the very last stage I got an error telling me that it couldn't connect. It turned out my VT-x was disabled. I enabled my VT-x and then ran through the setup again. That's when I started getting the current error. So, I uninstalled VirtualBox, deleted the .VirtualBox directory from my user profile directory and did a clean install. That did the trick.
So I'm thinking the first time I ran the setup when my VT-x was disabled it created the machine successfully even though it wasn't appearing in the VirtualBox console. Then after I enabled my VT-x and ran it again it was conflicting with that original machine.
I'm new to VirtualBox and Vagrant, I'm sure someone with more experience would've know right away.
Anyways, thanx!!

Great, glad you could work it out!

:+1: